* buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
dea7f1e5
PE
12012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2
3 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
4
76046526
DA
52012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
6
7 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
8
39adff0d
PE
92012-07-04 Paul Eggert <eggert@cs.ucla.edu>
10
63807d47
PE
11 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
12 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
13 since GCC 4.4.6 issues a bogus warning for them.
14
39adff0d
PE
15 Fix bugs in file timestamp newness comparisons.
16 * fileio.c (Ffile_newer_than_file_p):
17 * lread.c (Fload): Use full timestamp resolution of files,
18 not just the 1-second resolution, so that files that are only
19 slightly newer still count as newer.
20 * fileio.c (Ffile_newer_than_file_p): Don't assume file
21 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
22
dbeed9a6
PE
232012-07-03 Paul Eggert <eggert@cs.ucla.edu>
24
25 * fileio.c: Improve handling of file time marker. (Bug#11852)
26 (special_mtime): New function.
27 (Finsert_file_contents, Fverify_visited_file_modtime):
28 Use it to set special mtime values consistently.
29
636334d6
AS
302012-07-03 Andreas Schwab <schwab@linux-m68k.org>
31
32 * fileio.c (Finsert_file_contents): Properly handle st_mtime
33 marker for non-existing file. (Bug#11852)
34
e2017fe2
GM
352012-07-03 Glenn Morris <rgm@gnu.org>
36
37 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
38 and did not make it into globals.h).
39
404dbd37
TT
402012-07-03 Tom Tromey <tromey@redhat.com>
41
42 * window.c (Fset_window_margins, Fset_window_fringes)
43 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
44 * textprop.c (Fprevious_property_change): No longer static.
45 * syntax.c (Fsyntax_table_p): No longer static.
46 * process.c (Fget_process, Fprocess_datagram_address): No longer
47 static.
48 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
49 * keyboard.c (Fcommand_execute): No longer static.
50 Remove EXFUN.
51 * insdel.c (Fcombine_after_change_execute): No longer static.
52 * image.c (Finit_image_library): No longer static.
53 * fileio.c (Fmake_symbolic_link): No longer static.
54 * eval.c (Ffetch_bytecode): No longer static.
55 * editfns.c (Fuser_full_name): No longer static.
56 * doc.c: (Fdocumentation_property, Fsnarf_documentation): No
57 longer static.
58 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
59 static.
60 * dired.c (Ffile_attributes): No longer static.
61 * composite.c (Fcomposition_get_gstring): No longer static.
62 * callproc.c (Fgetenv_internal): No longer static.
63
64 * ccl.h: Remove EXFUNs.
65 * buffer.h: Remove EXFUNs.
66 * dispextern.h: Remove EXFUNs.
67 * intervals.h: Remove EXFUNs.
68 * fontset.h: Remove EXFUN.
69 * font.h: Remove EXFUNs.
70 * dosfns.c (system_process_attributes): Remove EXFUN.
71 * keymap.h: Remove EXFUNs.
72 * lisp.h: Remove EXFUNs.
73 * w32term.h: Remove EXFUNs.
74 * window.h: Remove EXFUNs.
75 * xsettings.h: Remove EXFUN.
76 * xterm.h: Remove EXFUN.
77
8e4fd1e1
GM
782012-07-03 Glenn Morris <rgm@gnu.org>
79
80 * lisp.h (Frandom): Make it visible to C.
81 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
82 buffer for invisible buffers. (Bug#1229)
83
ca95b3eb
DA
842012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
85
86 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
87 values which aren't power of 2.
88 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
89 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
90 accordingly.
91
7555c33f
SM
922012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
93
94 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
95
96 * alloc.c (mark_object): Revert part of last patch to use `switch'.
97
d12e8f5a
DA
982012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
99
100 * alloc.c (allocate_vector_block): Remove redundant
101 calls to mallopt if DOUG_LEA_MALLOC is defined.
102 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
103 avoid calls to mallopt if zero_vector is returned.
104
296094c3
DA
1052012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
106
107 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
108 is enabled, avoid dereferencing NULL current_sblock if
109 running undumped.
110
36429c89
DA
1112012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
112
113 Cleanup basic buffer management.
114 * buffer.h (struct buffer): Change layout to use generic vector
115 marking code. Fix some comments. Change type of 'clip_changed'
116 to bitfield. Remove unused #ifndef old.
117 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
118 (GET_OVERLAYS_AT): Fix indentation.
119 (for_each_per_buffer_object_at): New macro.
120 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
121 (Fbuffer_local_variables): Use it.
122 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
123 * alloc.c (allocate_buffer): Adjust to match new layout of
124 struct buffer. Fix comment.
125 (mark_overlay): New function.
126 (mark_buffer): Use it. Use mark_vectorlike to mark normal
127 Lisp area of struct buffer.
128 (mark_object): Use it. Adjust marking of misc objects
129 and related comments.
130
3b3e4cac
PE
1312012-07-02 Paul Eggert <eggert@cs.ucla.edu>
132
133 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
134 wrapper that is not needed because the wrapped code is a no-op (zero
135 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
136 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
137
cf5c0175
DA
1382012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
139
140 * alloc.c (mark_buffer): Simplify. Remove prototype.
141 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 142 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
143 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
144 redundant calls to mark_vectorlike for bool vectors.
145
ca26824c
GM
1462012-06-30 Glenn Morris <rgm@gnu.org>
147
2e4c5312
GM
148 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
149
ca26824c
GM
150 * epaths.in (PATH_SITELOADSEARCH): New.
151 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
152 This is rather than relying on --enable-locallisppath elements
153 having "site-lisp" in their names. (Bug#10208#25, 11658)
154
0d23c240
EZ
1552012-06-30 Eli Zaretskii <eliz@gnu.org>
156
c9240d7a
EZ
157 * w32proc.c (sys_select): Accept and ignore one more argument.
158
159 * w32.c (emacs_gnutls_pull): Call select with one more argument.
160
0d23c240 161 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 162 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
163
164 * sysdep.c: Don't include dos.h and dosfns.h.
165
166 * process.c (sys_select):
167 * msdos.c (sys_select): Accept one more argument and ignore it.
168
169 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
170 adapt data types and code to that.
171
172 * dosfns.c:
173 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
174 which clashes with the gnulib function of the same name.
175
af5a5a98
AS
1762012-06-30 Andreas Schwab <schwab@linux-m68k.org>
177
c5e4379c
AS
178 * font.c (font_style_to_value, font_style_symbolic)
179 (font_prop_validate_style): Add type checks for values in
180 font_style_table.
181
af5a5a98
AS
182 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
183 argument.
184 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
185 uses.
186
8d38f461
EZ
1872012-06-29 Eli Zaretskii <eliz@gnu.org>
188
2e5a6631
EZ
189 * xdisp.c (try_window_id): Undo last change.
190
8d38f461
EZ
191 * w32.c (getwd): Adjust commentary about startup_dir.
192 (init_environment): Always call sys_access, even in non-MSVC
193 builds. Don't chdir to the directory of the Emacs executable.
194 This undoes code from 1997 which was justified by the need to
195 "avoid conflicts when removing and renaming directories". But its
196 downside was that every relative file name was being interpreted
197 relative to the directory of the Emacs executable, which can never
198 be TRT. In particular, it broke sys_access when called with
199 relative file names.
200 (sys_access): Map GetLastError to errno.
201
2af3565e
DA
2022012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
203
204 * window.h (struct window): Change type of 'fringes_outside_margins'
205 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 206 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
207 Adjust comment.
208 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
209 to ptrdiff_t.
210
c8d3a25c 2112012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 212
c8d3a25c
GM
213 * gnutls.c (emacs_gnutls_handshake):
214 Add QUIT to make the loop interruptible.
57570cd3 215
c8d3a25c 2162012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 217
c8d3a25c
GM
218 * charset.c (init_charset): Make lack of etc/charsets fatal.
219
3e984ee8
DA
2202012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
221
222 * editfns.c (region_limit): Fix type mismatch.
223
ef884f23
DA
2242012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
225
226 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
227 undefined. Convert from xassert to eassert.
228 * nsmenu.m: Convert from xassert to eassert.
229 * nsterm.m: Likewise.
230
7d7e0027
SM
2312012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
232
233 * editfns.c (region_limit): Clip to narrowing (bug#11770).
234
aa754e6a
PE
2352012-06-28 Paul Eggert <eggert@cs.ucla.edu>
236
237 Avoid integer overflow on scroll-left and scroll-right.
238 * window.c (HSCROLL_MAX): New macro.
239 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
240 overflow when requested scroll falls outside ptrdiff_t range.
241
80b00b08
DA
2422012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
243
244 * window.h (struct window): Change type of 'hscroll',
245 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
246 'last_modified' and 'last_overlay_modified' to EMACS_INT.
247 Adjust users accordingly.
248 * xdisp.c (try_cursor_movement): Replace type check with eassert.
249 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
250 from EMACS_INT to ptrdiff_t.
251 (make_window): Omit redundant initialization.
252
62b2bcf6
JB
2532012-06-28 Juanma Barranquero <lekktu@gmail.com>
254
255 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
256
45942c7d
DA
2572012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
258
259 * window.h (struct window): Change type of 'use_time' and
260 'sequence_number' from Lisp_Object to int.
261 * frame.c (make_frame): Adjust users accordingly.
262 * print.c (print_object): Likewise.
263 * window.c (select_window, Fwindow_use_time, make_parent_window)
264 (make_window): Likewise.
265
e509cfa6
DA
2662012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
267
268 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
269 enabled with --enable-checking=[all,glyphs] configure option.
270 Fix GLYPH_DEBUG usage assuming that it may be undefined,
271 adjust comments accordingly.
272 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
273 undefined, adjust comments accordingly.
274 * image.c: Likewise.
275 * scroll.c: Likewise.
276 * w32fns.c: Likewise.
277 * w32term.c: Likewise.
278 * xdisp.c: Likewise.
279 * xfaces.c: Likewise.
280 * xfns.c: Likewise.
281 * xterm.c: Likewise.
282
a54e2c05
DA
2832012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
284
285 Generalize run-time debugging checks.
286 * dispextern.h (XASSERTS): Remove.
287 * fontset.c (xassert): Remove.
288 Convert from xassert to eassert.
289 * alloc.c: Convert from xassert to eassert.
290 * bidi.c: Likewise.
291 * dispnew.c: Likewise.
292 * fns.c: Likewise.
293 * fringe.c: Likewise.
294 * ftfont.c: Likewise.
295 * gtkutil.c: Likewise.
296 * image.c: Likewise.
297 * keyboard.c: Likewise.
298 * menu.c: Likewise.
299 * process.c: Likewise.
300 * scroll.c: Likewise.
301 * sound.c: Likewise.
302 * term.c: Likewise.
303 * w32console.c: Likewise.
304 * w32fns.c: Likewise.
305 * w32term.c: Likewise.
306 * window.c: Likewise.
307 * xdisp.c: Likewise.
308 * xfaces.c: Likewise.
309 * xfns.c: Likewise.
310 * xselect.c: Likewise.
311 * xterm.c: Likewise.
312
1ec4b7b2
SM
3132012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
314
315 * fns.c (maybe_resize_hash_table): Output message when growing the
316 purify-hashtable.
317
2014308a
DA
3182012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
319
320 * alloc.c (allocate_string_data): Remove dead code.
321 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
322 avoid GCC warning about unused macro.
323
246155eb
DA
3242012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
325
326 * alloc.c (allocate_string): Omit intervals initialization.
327 * alloc.c (make_uninit_multibyte_string): Initialize intervals
328 as in make_pure_string and make_pure_c_string.
329
43184b7b
DA
3302012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
331
332 * alloc.c (allocate_string): Fix last change.
333
3fe6dd74
DA
3342012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
335
336 * alloc.c (allocate_string): Remove two redundant calls
337 to memset, add explicit initialization where appropriate.
338
1ba6038a
GM
3392012-06-27 Glenn Morris <rgm@gnu.org>
340
341 * lisp.mk (lisp): Remove paths.elc.
342
c89926a5
CY
3432012-06-27 Chong Yidong <cyd@gnu.org>
344
345 * doc.c (Fsubstitute_command_keys): Fix punctuation.
346
ed6b3510
JW
3472012-06-26 John Wiegley <johnw@newartisans.com>
348
1ec4b7b2 349 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
350 on Mac OS X Lion: __mod_init_func and __mod_term_func.
351
ed6b3510
JW
352 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
353 when building with Clang.
354
8edd4a2b
SM
3552012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
356
357 * eval.c (Fapply): Allow calling it with a single argument.
358
f6f62d1b
EZ
3592012-06-26 Eli Zaretskii <eliz@gnu.org>
360
361 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
362 _stricmp and _strnicmp.
363 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
364
62efea5e
DA
3652012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
366
367 * alloc.c (allocate_window): Zero out non-Lisp part of newly
368 allocated window.
369 (allocate_process): Likewise for new process.
8edd4a2b 370 (allocate_terminal): Change to use offsetof.
62efea5e
DA
371 (allocate_frame): Likewise.
372 * frame.c (make_frame): Omit redundant initialization.
373 * window.c (make_parent_window): Use memset.
374 (make_window): Omit redundant initialization.
375 * process.c (make_process): Omit redundant initialization.
376 * terminal.c (create_terminal): Likewise.
377
42997f4d
DA
3782012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
379
380 * term.c (delete_tty): Remove redundant call to memset.
381
1130ecfc
DA
3822012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
383
384 * alloc.c: Remove build_string.
385 * lisp.h: Define build_string as static inline. This provides
386 a better opportunity to optimize away calls to strlen when the
387 function is called with compile-time constant argument.
388 * image.c (imagemagick_error): Convert to build_string.
389 * w32proc.c (sys_spawnve): Likewise.
390 * xterm.c (x_term_init): Likewise.
391
cf38a720
PE
3922012-06-26 Paul Eggert <eggert@cs.ucla.edu>
393
99027bdd
PE
394 Use sprintf return value instead of invoking strlen on result.
395 In the old days this wasn't portable, since some sprintf
396 implementations returned char *. But they died out years ago and
397 Emacs already assumes sprintf returns int.
398 Similarly for float_to_string.
399 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
400 * ccl.c (ccl_driver):
401 * character.c (string_escape_byte8):
402 * data.c (Fnumber_to_string):
403 * doprnt.c (doprnt):
404 * print.c (print_object):
405 * xdisp.c (message_dolog):
406 * xfns.c (syms_of_xfns):
407 Use sprintf or float_to_string result to avoid need to call strlen.
408 * data.c (Fnumber_to_string):
409 Use make_unibyte_string, since the string must be ASCII.
410 * lisp.h, print.c (float_to_string): Now returns int length.
411 * term.c (produce_glyphless_glyph):
412 Use sprintf result rather than recomputing it.
413
cf38a720
PE
414 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
415 * Makefile.in (ALL_CFLAGS):
416 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
417 * gmalloc.c, regex.c: Include <config.h> unconditionally.
418
3511c784
DA
4192012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
420
0a08eb21 421 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
422 strcasecmp if available.
423 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
424
fb7da12e
AS
4252012-06-25 Andreas Schwab <schwab@linux-m68k.org>
426
427 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
428 Avoid comma operator.
429 * menu.c (push_submenu_start, push_submenu_end)
430 (push_left_right_boundary, push_menu_pane): Likewise.
431 * msdos.c (dos_rawgetc): Likewise.
432
afa2ffd8
DA
4332012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
434
435 * xfns.c (xic_create_fontsetname): Remove redundant calls
436 to memset.
437
b3b4476b
PE
4382012-06-25 Paul Eggert <eggert@cs.ucla.edu>
439
4495ff38
PE
440 * gtkutil.c (get_utf8_string): Remove redundant assignment.
441 sprintf already null-terminates its output.
442
b3b4476b
PE
443 * xfns.c (x_window): Remove redundant cast.
444
b00876c9
DA
4452012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
446
447 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
448 `const char *' to `char *' to avoid compiler warning.
449
d188e26b
PE
4502012-06-24 Paul Eggert <eggert@cs.ucla.edu>
451
885d1d74
PE
452 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
453 instead of truncating it to 63 (admittedly a generous limit).
454
d188e26b
PE
455 * process.c: Fix spelling and caps in comments.
456
e2f560b1
DN
4572012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
458
e86db54b 459 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
460 * sysdep.c (setpgrp): Remove definition, not used in this file.
461
7583a3a1
JB
4622012-06-24 Juanma Barranquero <lekktu@gmail.com>
463
464 * makefile.w32-in: Update dependencies.
465
696056c2
EZ
4662012-06-24 Eli Zaretskii <eliz@gnu.org>
467
468 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
469 (SYSTIME_H): Add nt/inc/sys/time.h.
470
471 * systime.h [WINDOWSNT]: Include sys/time.h.
472
473 * s/ms-w32.h (struct timespec): Definition moved from
474 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
475
845ca893
PE
4762012-06-24 Paul Eggert <eggert@cs.ucla.edu>
477
478 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
479 * buffer.h (buffer_slot_type_mismatch):
480 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
481 * eval.c (unwind_to_catch):
482 * image.c (my_png_error, my_error_exit):
483 * keyboard.c (quit_throw_to_read_char, user_error)
484 (Fexit_recursive_edit, Fabort_recursive_edit):
485 * lisp.h (die, args_out_of_range, args_out_of_range_3)
486 (wrong_type_argument, buffer_overflow, __executable_start)
487 (memory_full, buffer_memory_full, string_overflow, Fthrow)
488 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
489 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
490 (fatal):
491 (child_setup) [!DOS_NT]:
492 * lread.c (end_of_file_error, invalid_syntax):
493 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
494 * puresize.h (pure_write_error):
495 * search.c (matcher_overflow):
496 * sound.c (sound_perror, alsa_sound_perror):
497 * sysdep.c, syssignal.h (croak):
498 * term.c (maybe_fatal, vfatal):
499 * textprop.c (text_read_only):
500 * undo.c (user_error):
501 * unexmacosx.c (unexec_error):
502 * xterm.c (x_ins_del_lines, x_delete_glyphs):
503 Use _Noreturn rather than NO_RETURN.
504 No need for separate decl merely because of _Noreturn.
505 * sound.c (sound_warning, parse_sound):
506 Remove unnecessary forward decls.
507
f1dd8073
PE
5082012-06-24 Paul Eggert <eggert@cs.ucla.edu>
509
510 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
511 * lisp.h (WAIT_READING_MAX): New macro.
512 * dispnew.c (Fsleep_for, sit_for):
513 * keyboard.c (kbd_buffer_get_event):
514 * process.c (Faccept_process_output):
515 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
516 This improves on the previous patch, which introduced a bug
517 when time_t is unsigned and as wide as intmax_t.
518 See <http://bugs.gnu.org/9000#51>.
519
b82c1755
EZ
5202012-06-23 Eli Zaretskii <eliz@gnu.org>
521
522 * dispnew.c (sit_for, Fsleep_for):
523 * keyboard.c (kbd_buffer_get_event):
524 * process.c (Faccept_process_output): Avoid compiler warnings when
525 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
526
ca300656
JB
5272012-06-23 Juanma Barranquero <lekktu@gmail.com>
528
049ec95b
JB
529 * makefile.w32-in: Update dependencies.
530
ca300656
JB
531 * w32.c (ltime): Add return type and declare static.
532 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
533
db7b8d06
PE
5342012-06-23 Paul Eggert <eggert@cs.ucla.edu>
535
536 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
537 Privately reported by Herbert J. Skuhra.
538 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
539 All uses changed.
540 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
541 not make_lisp_timeval, when the argument is of type EMACS_TIME.
542
0bd8297f
EZ
5432012-06-23 Eli Zaretskii <eliz@gnu.org>
544
96512555
EZ
545 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
546 last argument of make_unibyte_string.
547
0bd8297f
EZ
548 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
549 language ID in the event parameters.
550
551 * w32term.c (w32_read_socket): Put the new keyboard codepage into
552 event.code, not the obscure "character set ID".
553
63def6b6
CY
5542012-06-23 Chong Yidong <cyd@gnu.org>
555
556 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
557
e8a02204
EZ
5582012-06-23 Eli Zaretskii <eliz@gnu.org>
559
388cdec0
EZ
560 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
561 * w32.c (fdutimens): New function.
562
563 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
564
565 * s/ms-w32.h (pselect): Redirect to sys_select.
566
567 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
568
e8a02204
EZ
569 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
570 in the logic of incrementing and decrementing the value of
571 use_relocatable_buffers.
572
d054f3fb
PE
5732012-06-23 Paul Eggert <eggert@cs.ucla.edu>
574
575 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
576 Privately reported by Herbert J. Skuhra.
577 [__FreeBSD__]: Remove "*/" typo after "#include".
578 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
579 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
580 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
581 Don't assume EMACS_TIME and struct timeval are the same type.
582
d35af63c
PE
5832012-06-22 Paul Eggert <eggert@cs.ucla.edu>
584
585 Support higher-resolution time stamps (Bug#9000).
586 The time stamps are only nanosecond-resolution at the C level,
587 since that's the best that any real-world system supports now.
588 But they are picosecond-resolution at the Lisp level, as that's
589 easy, and leaves room for future OS improvements.
590
591 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
592 (LIBES): Use it.
593
594 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
595 Don't get current time unless it's needed.
596
597 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
598 now provides it if it's absent.
599 (start_atimer): Port to higher-res time stamps.
600 Check for time stamp overflow. Don't get current time more
601 often than is needed.
602
603 * buffer.h (struct buffer): Buffer modtime now has high resolution.
604 Include systime.h, not time.h.
605 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
606
607 * dired.c: Include stat-time.h.
608 (Ffile-attributes): File times now have higher resolution.
609
610 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
611 (struct image): Timestamp now has higher resolution.
612
613 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
614 has at least microseconds now. All uses removed.
615 (update_frame, update_single_window, update_window, update_frame_1)
616 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
617
618 * editfns.c (time_overflow): Now extern.
619 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
620 (float-time, Fformat_time_string, Fcurrent_time_string)
621 (Fcurrent_time_zone): Accept and generate higher-resolution
622 time stamps.
623 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
624 (decode_time_components, lisp_seconds_argument): New functions.
625 (make_time): Now static.
626 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
627 Report an error if the time is invalid, rather than having the caller
628 do that.
629
630 * fileio.c: Include <stat-time.h>
631 (Fcopy_file): Copy higher-resolution time stamps.
632 Prefer to set the time stamp via a file descriptor if that works.
633 (Fset_file_times, Finsert_file_contents, Fwrite_region)
634 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
635 (Fvisited_file_modtime, Fset_visited_file_modtime):
636 Support higher-resolution time stamps.
637
638 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
639
640 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
641
642 * image.c (prepare_image_for_display, clear_image_cache)
643 (lookup_image): Port to higer-resolution time stamps.
644
645 * keyboard.c (start_polling, bind_polling_period):
646 Check for time stamp overflow.
647 (read_char, kbd_buffer_get_event, timer_start_idle)
648 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
649 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
650 Port to higher-resolution time stamps. Do not assume time_t is signed.
651 (decode_timer): New function. Timers are now vectors of length 9,
652 not 8, to accommodate the picosecond component.
653 (timer_check_2): Use it.
654
655 * nsterm.m (select_timeout, timeval_subtract): Remove.
656 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
657 as they're a bit more accurate and handle overflow better.
658 (ns_select): Change prototype to be compatible with pselect.
659 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
660 * nsterm.h (ns_select): Adjust prototype.
661
662 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
663 us-resolution time stamps.
664 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
665
666 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
667
668 * lisp.h (time_overflow): New decl.
669 (wait_reading_process_output): First arg is now intmax_t, not int,
670 to accommodate larger waits.
671
672 * process.h (struct Lisp_Process.read_output_delay):
673 Now counts nanoseconds, not microseconds.
674 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
675 EMACS_HAS_USECS.
676 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
677 (wait_reading_process_output):
678 Port to ns-resolution time stamps.
679 (Faccept_process_output, wait_reading_process_output):
680 Check for time stamp overflow. Do not assume time_t is signed.
681 (select_wrapper): Remove; we now use pselect.
682 (Fprocess_attributes): Now generates ns-resolution time stamps.
683
684 * sysdep.c: Include utimens.h. Don't include utime.h
685 or worry about struct utimbuf; gnulib does that for us now.
686 (gettimeofday): Remove; gnulib provides a substitute.
687 (make_timeval): New function.
688 (set_file_times): Now sets ns-resolution time stamps.
689 New arg FD; all uses changed.
690 (time_from_jiffies, ltime_from_jiffies, get_up_time)
691 (system_process_attributes):
692 Now returns ns-resolution time stamp. All uses changed.
693 Check for time stamp overflow.
694
695 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
696 provides a substitute now.
697
698 * systime.h: Include timespec.h rather than sys/time.h and time.h,
699 since it guarantees struct timespec.
700 (EMACS_TIME): Now struct timespec, so that we can support
701 ns-resolution time stamps.
702 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
703 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
704 (EMACS_USECS): Remove.
705 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
706 so multiply the arg by 1000 before storing it.
707 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
708 New macros.
709 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
710 Port to ns-resolution time stamps.
711 (EMACS_TIME_NEG_P): Remove; replaced by....
712 (EMACS_TIME_SIGN): New macro.
713 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
714 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
715 (set_file_times, make_time, lisp_time_argument): Adjust signature.
716 (make_timeval, make_lisp_time, decode_time_components): New decls.
717 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
718 that it mishandled time_t overflow. You can't compare by subtracting!
719 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
720 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
721
722 * term.c: Include <sys/time.h>.
723 (timeval_to_Time): New function, for proper overflow wraparound.
724 (term_mouse_position, term_mouse_click): Use it.
725
726 * undo.c (record_first_change): Support higher-resolution time stamps
727 in the undo buffer.
728 (Fprimitive_undo): Use them when restoring time stamps.
729
730 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
731 (w32_get_internal_run_time):
732 Port to higher-resolution Emacs time stamps.
733 (ltime): Now accepts single 64-bit integer, as that's more convenient
734 for callers.
735
736 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
737
738 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
739 for compatibility with pselect. Support ns-resolution time stamps.
740
741 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
742
743 * xselect.c (wait_for_property_change, x_get_foreign_selection):
744 Check for time stamp overflow, and support ns-resolution time stamps.
745
746 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
747 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
748 (timeval_subtract): Remove; no longer needed.
749 (XTflash, XTring_bell, x_wait_for_event):
750 Port to ns-resolution time stamps. Don't assume time_t is signed.
751
b6a92dfe
CY
7522012-06-22 Chong Yidong <cyd@gnu.org>
753
754 * xdisp.c (x_consider_frame_title): Revert last change.
755
d251c37c
EZ
7562012-06-22 Eli Zaretskii <eliz@gnu.org>
757
758 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
759 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
760 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
761 staticidx goes up to 1597 out of 1600 = 0x640.)
762
f10deafb
PE
7632012-06-20 Paul Eggert <eggert@cs.ucla.edu>
764
765 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
766 Otherwise, the umask might be mistakenly 0 while handling input signals.
767
ec6de1e2
SM
7682012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
769
770 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
771
28be1ada
DA
7722012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
773
774 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
775 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
776 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
777 access to `contents' member of Lisp_Vector objects with AREF and ASET
778 where appropriate.
779
c6bf3022
CY
7802012-06-19 Chong Yidong <cyd@gnu.org>
781
782 * frame.c (delete_frame): When selecting a frame on a different
783 text terminal, do not alter the terminal's top-frame.
784
785 * xdisp.c (format_mode_line_unwind_data): Record the target
786 frame's selected window and its terminal's top-frame.
787 (unwind_format_mode_line): Restore them.
788 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
789 Callers changed.
790 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
791 since tty frames can be explicitly named.
792 (prepare_menu_bars): Likewise.
793
794 * term.c (Ftty_top_frame): New function.
795
defd4196
PE
7962012-06-18 Paul Eggert <eggert@cs.ucla.edu>
797
798 Port byte-code-meter to modern targets.
799 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
800 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 801 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
802 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
803 (METER_1, METER_2): Simplify.
804
1053a871
SM
8052012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
806
807 * data.c (Fdefalias): Return `symbol' (bug#11686).
808
b7e8d081
MR
8092012-06-18 Martin Rudalics <rudalics@gmx.at>
810
811 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
812 gets killed during executing of this function (Bug#11665).
813 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
814 (Vkill_buffer_query_functions): In doc-string say that functions
815 run by this hook should not change the current buffer.
816
7ea2b339
PE
8172012-06-18 Paul Eggert <eggert@cs.ucla.edu>
818
819 Fix recently-introduced process.c problems found by static checking.
820 * process.c (write_queue_push, write_queue_pop, send_process):
821 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
822 (write_queue_pop): Fix pointer signedness problem.
823 (send_process): Remove unused local.
824
96a313a1
CY
8252012-06-17 Chong Yidong <cyd@gnu.org>
826
827 * xdisp.c (redisplay_internal): No need to redisplay terminal
828 frames that are not on top.
829
20ca2e94
TN
8302012-06-17 Troels Nielsen <bn.troels@gmail.com>
831
832 * process.c (make_process): Initialize write_queue.
833 (write_queue_push, write_queue_pop): New functions.
834 (send_process): Use them to maintain correct ordering of process
835 writes (Bug#10815).
836
9a900ca9
PE
8372012-06-17 Paul Eggert <eggert@cs.ucla.edu>
838
310fbfa8
PE
839 * lisp.h (eassert): Assume C89 or later.
840 This removes the need for CHECK.
841 (CHECK): Remove. Its comments about always evaluating its
842 argument were confusing, as 'eassert' typically does not evaluate
843 its argument.
844
27bb1ca4
PE
845 * coding.c (produce_chars): Use ptrdiff_t, not int.
846
9a900ca9
PE
847 * xterm.c (x_draw_underwave): Check for integer overflow.
848 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
849
41b7f8bc 8502012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
851
852 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
853 referenced (Bug#11583).
854
9b0e3eba
AA
8552012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
856
857 Implement wave-style variant of underlining.
858 * dispextern.h (face_underline_type): New enum.
859 (face): Add field for underline type.
860 * nsterm.m (ns_draw_underwave): New function.
861 (ns_draw_text_decoration): Use it.
862 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
863 New functions.
864 (x_draw_glyph_string): Use them.
865 * xfaces.c (Qline, Qwave): New Lisp objects.
866 (check_lface_attrs, merge_face_ref)
1053a871
SM
867 (Finternal_set_lisp_face_attribute, realize_x_face):
868 Handle wave-style underline face attributes.
9b0e3eba
AA
869 * xterm.c (x_draw_underwave): New function.
870 (x_draw_glyph_string): Use it.
871
0fb52f11
JB
8722012-06-16 Juanma Barranquero <lekktu@gmail.com>
873
874 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
875 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
876 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
877 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
878 ($(BLD)/w32select.$(O)): Update dependencies.
879
e5560ff7
AS
8802012-06-16 Andreas Schwab <schwab@linux-m68k.org>
881
882 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
883 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
884 * character.c (_fetch_multibyte_char_p): Remove.
885 * alloc.c: Include "character.h" before "buffer.h".
886 * bidi.c: Likewise.
887 * buffer.c: Likewise.
888 * bytecode.c: Likewise.
889 * callint.c: Likewise.
890 * callproc.c: Likewise.
891 * casefiddle.c: Likewise.
892 * casetab.c: Likewise.
893 * category.c: Likewise.
894 * cmds.c: Likewise.
895 * coding.c: Likewise.
896 * composite.c: Likewise.
897 * dired.c: Likewise.
898 * dispnew.c: Likewise.
899 * doc.c: Likewise.
900 * dosfns.c: Likewise.
901 * editfns.c: Likewise.
902 * emacs.c: Likewise.
903 * fileio.c: Likewise.
904 * filelock.c: Likewise.
905 * font.c: Likewise.
906 * fontset.c: Likewise.
907 * fringe.c: Likewise.
908 * indent.c: Likewise.
909 * insdel.c: Likewise.
910 * intervals.c: Likewise.
911 * keyboard.c: Likewise.
912 * keymap.c: Likewise.
913 * lread.c: Likewise.
914 * macros.c: Likewise.
915 * marker.c: Likewise.
916 * minibuf.c: Likewise.
917 * nsfns.m: Likewise.
918 * nsmenu.m: Likewise.
919 * print.c: Likewise.
920 * process.c: Likewise.
921 * regex.c: Likewise.
922 * region-cache.c: Likewise.
923 * search.c: Likewise.
924 * syntax.c: Likewise.
925 * term.c: Likewise.
926 * textprop.c: Likewise.
927 * undo.c: Likewise.
928 * unexsol.c: Likewise.
929 * w16select.c: Likewise.
930 * w32fns.c: Likewise.
931 * w32menu.c: Likewise.
932 * window.c: Likewise.
933 * xdisp.c: Likewise.
934 * xfns.c: Likewise.
935 * xmenu.c: Likewise.
936 * xml.c: Likewise.
937 * xselect.c: Likewise.
938
2f07e6af
EZ
9392012-06-16 Eli Zaretskii <eliz@gnu.org>
940
1053a871
SM
941 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
942 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 943 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
944 row.
945 (handle_face_prop): Use chunk-relative overlay string index when
946 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
947 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
948 the rightmost. (Bug#11720)
2f07e6af 949
29b83cec
AS
9502012-06-16 Andreas Schwab <schwab@linux-m68k.org>
951
952 * category.h (CHAR_HAS_CATEGORY): Define as inline.
953 (CATEGORY_MEMBER): Enforce 1/0 value.
954 * category.c (_temp_category_set): Remove.
955
4c5501e9
EZ
9562012-06-16 Eli Zaretskii <eliz@gnu.org>
957
958 * window.c (Fdelete_other_windows_internal)
959 (Fdelete_window_internal): Don't access frame's mouse highlight
960 info of the initial frame. (Bug#11677)
961
2b570124
PE
9622012-06-14 Paul Eggert <eggert@cs.ucla.edu>
963
e93864f9
PE
964 * .gdbinit (xgetint): Fix recently-introduced paren typo.
965 Assume USE_2_TAGS_FOR_INTS.
966 (xreload): Adjust $tagmask width to match recent lisp.h change.
967
2b570124
PE
968 Simplify lisp.h in minor ways that should not affect code.
969 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
970 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
971 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
972 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
973 (INTTYPEBITS): New macro, for clarity.
974 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
975 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
976 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
977 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
978 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
979
81755f69
JB
9802012-06-13 Juanma Barranquero <lekktu@gmail.com>
981
982 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
983
16192a57
GM
9842012-06-13 Glenn Morris <rgm@gnu.org>
985
986 * s/bsd-common.h (BSD4_3):
987 * s/usg5-4-common.h (USG5_4): No longer define; unused.
988
646b5f55
AS
9892012-06-13 Andreas Schwab <schwab@linux-m68k.org>
990
991 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
992 instead of union.
993 (XLI, XIL): Define.
1053a871
SM
994 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
995 Use them.
996 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 997 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 998 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
999 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1000 * frame.c (delete_frame): Remove outdated comment.
1001 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1002 USE_LISP_UNION_TYPE.
1003 (Fw32_unregister_hot_key): Likewise.
1004 (Fw32_toggle_lock_key): Likewise.
1005 * w32menu.c (add_menu_item): Likewise.
1006 (w32_menu_display_help): Use XIL instead of checking
1007 USE_LISP_UNION_TYPE.
1008 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1009 (init_heap): Likewise.
1010 * w32term.c (w32_read_socket): Update comment.
1011
1d3823c9
GM
10122012-06-13 Glenn Morris <rgm@gnu.org>
1013
c62ff706
GM
1014 * s/usg5-4-common.h, src/s/unixware.h:
1015 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1016
1d3823c9
GM
1017 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1018
bfe3e0a2
PE
10192012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1020
1021 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1022 * alloc.c (make_number) [!defined make_number]:
1023 Remove, as lisp.h always defines this now.
1024 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1025 (roundup_size): Verify that it is a power of 2.
1026 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1027 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1028 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1029 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1030 USE_LSB_TAG now is always defined to be either 0 or 1.
1031 All uses changed.
1032 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1033 code works fine either way, and efficiency is not a concern here,
1034 as the union type is for debugging, not for production.
1035 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1036 Use an inline function on all platforms when using the union type,
1037 since this is simpler and 'static inline' can be used portably
1038 within Emacs now.
1039 (LISP_INITIALLY_ZERO): New macro.
1040 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1041 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1042
45fa9c0f
GM
10432012-06-12 Glenn Morris <rgm@gnu.org>
1044
b4492cba
GM
1045 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1046
1047 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1048
45fa9c0f
GM
1049 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1050 Move BROKEN_SIGIO to configure.
1051
1052 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1053 Move NO_TERMIO to configure.
1054
0e25d334
CY
10552012-06-12 Chong Yidong <cyd@gnu.org>
1056
1057 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1058 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1059 MagickExportImagePixels is undefined.
1060
43682bb6
PE
10612012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1062
1063 * image.c (imagemagick_load_image): Remove unused label.
1064
a9be7d2b
GM
10652012-06-11 Glenn Morris <rgm@gnu.org>
1066
1067 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1068 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1069 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1070 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1071
3017f87f
SM
10722012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1073
1074 * alloc.c (make_byte_code): New function.
1075 (Fmake_byte_code): Use it. Don't purify here.
1076 * lread.c (read1): Use it as well to avoid extra allocation.
1077
1b9b4cf4
CY
10782012-06-11 Chong Yidong <cyd@gnu.org>
1079
1080 * image.c (imagemagick_load_image): Implement transparency.
1081
95988fcf
AS
10822012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1083
1084 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1085 account for preceding backslashes. (Bug#11663)
1086
cd4eb164
CY
10872012-06-09 Chong Yidong <cyd@gnu.org>
1088
1089 * term.c: Support italics in capable terminals (Bug#9652).
1090 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1091 (turn_on_face): Output using TS_enter_italic_mode if available.
1092 Don't handle unused blinking and alt-charset cases.
1093 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1094 and tty_alt_charset_p cases.
1095 (tty_capable_p, init_tty): Support italics.
1096
1097 * termchar.h (struct tty_display_info): Add field for italics.
1098 Remove unused blink field.
1099
1100 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1101 Handle slant.
1102
1103 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1104 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1105 tty_alt_charset_p. Add tty_italic_p.
1106
ff88beb8
MA
11072012-06-09 Michael Albinus <michael.albinus@gmx.de>
1108
1109 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1110 dbus_type_is_basic if available.
1111 (xd_extract_signed, xd_extract_unsigned): Rename from
1112 extract_signed and extract_unsigned, respectively. Adapt callers.
1113
44286096
CY
11142012-06-09 Chong Yidong <cyd@gnu.org>
1115
1682701f
CY
1116 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1117
44286096
CY
1118 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1119 case (Bug#9752).
1120
d86feb17
PE
11212012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1122
1123 * xdisp.c (vmessage): Treat frame message as multibyte.
1124 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1125 would generate the diagnostic "Making \302\247 buffer-local while
1126 let-bound!".
1127
d5c20fe8
EZ
11282012-06-08 Eli Zaretskii <eliz@gnu.org>
1129
1130 * dispnew.c (showing_window_margins_p): Undo last change, which
1131 was done due to an inadvertent commit.
1132 (adjust_frame_glyphs_for_frame_redisplay): Do call
1133 showing_window_margins_p.
1134
513749ee
SM
11352012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1136
1137 * eval.c (Fmake_var_non_special): New primitive.
1138 (syms_of_eval): Defsubr it.
1139 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1140
d4a8f5c1
JB
11412012-06-08 Juanma Barranquero <lekktu@gmail.com>
1142
1143 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1144 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1145
8bbbc977
EZ
11462012-06-08 Eli Zaretskii <eliz@gnu.org>
1147
1148 * alloc.c (allocate_vectorlike): Fix last change.
1149
f3372c87
DA
11502012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1151
1152 Block-based vector allocation of small vectors.
1153 * lisp.h (struct vectorlike_header): New field `nbytes',
1154 adjust comment accordingly.
1155 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1156 to denote vector blocks. Adjust users (live_vector_p,
1157 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1158 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1159 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1160 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1161 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1162 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1163 (roundup_size): New constant.
1164 (struct vector_block): New data type.
1165 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1166 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1167 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1168 (sweep_vectors): New functions.
1169 (allocate_vectorlike): Return `zero_vector' as the only vector of
1170 0 items. Allocate new vector from block if vector size is less than
1171 or equal to VBLOCK_BYTES_MAX.
1172 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1173 (init_alloc_once): Add call to init_vectors.
1174
4f18a4ed
SM
11752012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1176
1177 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1178
86f158bc
PE
11792012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1180
1181 * doprnt.c (doprnt): Truncate multibyte char correctly.
1182 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1183 would mishandle a string argument "Xc" if X was a multibyte
1184 character of length 2: it would truncate after X's first byte
1185 rather than including all of X.
1186
c5cfcbe0
CY
11872012-06-06 Chong Yidong <cyd@gnu.org>
1188
1189 * buffer.c (word_wrap): Doc fix.
1190
c05cf390
PE
11912012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1192
1193 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1194
0c3461de
GM
11952012-06-03 Glenn Morris <rgm@gnu.org>
1196
1197 * xdisp.c (tool-bar-style): Doc fix.
1198
c71232db
UM
11992012-06-03 Ulrich Müller <ulm@gentoo.org>
1200
1201 * Makefile.in (PAXCTL): Define.
1202 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1203 binary via PaX flags if the paxctl utility is available.
1204 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1205 Restore PaX flags to their default. (Bug#11398)
1206
383f7350
CY
12072012-06-03 Chong Yidong <cyd@gnu.org>
1208
1209 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1210 buffer (Bug#11226).
1211
5f2c76c6
CY
12122012-06-03 Chong Yidong <cyd@gnu.org>
1213
1214 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1215 (note_mode_line_or_margin_highlight): If there is no help echo,
1216 use mode-line-default-help-echo. Handle the case where the mouse
1217 position is past the end of the mode line string.
1218
1219 * buffer.c (buffer_local_value_1): New function, split from
1220 Fbuffer_local_value; can return Qunbound.
1221 (Fbuffer_local_value): Use it.
1222 (Vmode_line_format): Docstring tweaks.
1223
773d47f6
PE
12242012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1225
1226 * sysdep.c (system_process_attributes): Improve comment.
1227
f2d6a3df
SM
12282012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1229
1230 * keyboard.c: Export real-this-command to Elisp.
1231 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1232 and DEFVAR it. Update all users.
1233
63810350
PE
12342012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1235
7bd5c1f4
PE
1236 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1237
63810350
PE
1238 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1239 Convert pctcpu and pctmem to Lisp float properly.
1240 Let the compiler fold better, as 100.0/0x8000 is exact.
1241
a2821611
AS
12422012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1243
1244 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1245 cons_block.
1246
5fceba1d
PE
12472012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1248
1249 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1250
c98ff5dd
DA
12512012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1252
1253 For a 'struct window', replace some Lisp_Object fields to
1254 bitfields where appropriate, remove unused fields.
1255 * window.h (struct window): Remove unused 'last_mark_x' and
1256 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1257 change it's type from Lisp_Object to bitfield.
1258 Change type of 'force_start', 'optional_new_start',
1259 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1260 fields from Lisp_Object to bitfield. Adjust users accordingly.
1261
ca34e0be
PE
12622012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1263
1264 Pacify gcc -Wdouble-precision when using Xaw.
1265 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1266 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1267 Use 'float' consistently, rather than 'float' in most places
1268 and 'double' in a couple of places.
1269
efc00ab1 12702012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1271
1272 * xdisp.c (handle_stop): Detect whether we have overlay strings
1273 loaded by testing it->current.overlay_string_index to be
1274 non-negative, instead of checking whether n_overlay_strings is
1275 positive. (Bug#11587)
1276
efc00ab1 12772012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1278
1279 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1280
1281 * doc.c (Fsubstitute_command_keys): Doc fix.
1282
efc00ab1 12832012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1284
1285 * search.c (search_buffer): Remove calls to
1286 r_alloc_inhibit_buffer_relocation, as it is now called by
1287 maybe_unify_char, which was the cause of relocation of buffer text
1288 in bug#11519.
1289
efc00ab1 12902012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1291
1292 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1293 for the duration of call to load_charset, to avoid problems with
1294 callers of maybe_unify_char that access buffer text through C
1295 pointers.
1296
1297 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1298 decrement the inhibition flag, instead of just setting or
1299 resetting it.
1300
ba93a187
PE
13012012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1302
1303 Remove obsolete '#define static' cruft.
1304 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1305 This #undef was "temporary" in 2000; it is no longer needed
1306 now that '#define static' has gone away.
1307 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1308 (gray_bitmap_bits): Remove; no longer needed.
1309 All uses replaced with definiens.
1310 * xterm.c: Include "bitmaps/gray.xbm".
1311
9e4bf381
PE
13122012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1313
1314 Clean up __executable_start, monstartup when --enable-profiling.
1315 The following changes affect the code only when profiling.
1316 * dispnew.c (__executable_start): Rename from safe_bcopy.
1317 Define only on platforms that need it.
1318 * emacs.c: Include <sys/gmon.h> when profiling.
1319 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1320 (__executable_start): Remove decl, since lisp.h does it now.
1321 (safe_bcopy): Remove decl; no longer has that name.
1322 (main): Coalesce #if into single bit of code, for simplicity.
1323 Cast pointers to uintptr_t, since standard libraries want integers
1324 and not pointers.
1325 * lisp.h (__executable_start): New decl.
1326
32d72c2f
GM
13272012-05-31 Glenn Morris <rgm@gnu.org>
1328
1329 * image.c (Fimagemagick_types): Doc fix.
1330
baac5bc7
JM
13312012-05-30 Jim Meyering <meyering@redhat.com>
1332
1333 * callproc.c (Fcall_process_region): Include directory component
1334 in mkstemp error message (Bug#11586).
1335
72cb32cf
PE
13362012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1337
1338 * alloc.c, lisp.h (make_pure_vector): Now static.
1339
61b108cc
SM
13402012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1341
1342 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1343 Move to byte-run.el.
1344 (Fautoload): Do the hash-doc more carefully.
1345 * data.c (Fdefalias): Purify definition, except for keymaps.
1346 (Qdefun): Move from eval.c.
1347 * lisp.h (Qdefun): Remove.
1348 * lread.c (read1): Tiny simplification.
1349
471fe23d
TN
13502012-05-29 Troels Nielsen <bn.troels@gmail.com>
1351
934f3f58 1352 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
1353 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1354 Bug#9642, but explicitly check that the buffer the overlay would
1355 be moved to is live and rearrange lines to make sure that errors
1356 will not put the overlay in an inconsistent state.
1357 (Fdelete_overlay): Cosmetics.
1358
85d0efd1
EZ
13592012-05-28 Eli Zaretskii <eliz@gnu.org>
1360
1361 * w32term.c (my_bring_window_to_top): New function.
1362 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
1363 could be different from the original one.
1364 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
1365 (Bug#11513)
1366
1367 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1368 by calling BringWindowToTop.
1369
1370 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1371 (WM_EMACS_END): Increase by one.
1372
da92a98c
PE
13732012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1374
1375 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1376 This avoids undefined behavior that might cause the eassert
1377 to not catch an out-of-range value.
1378
74d1f848
JB
13792012-05-28 Juanma Barranquero <lekktu@gmail.com>
1380
1381 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1382 Update dependencies.
1383
9e1a06fc
EZ
13842012-05-27 Eli Zaretskii <eliz@gnu.org>
1385
1386 * bidi.c (bidi_mirror_char): Fix last change.
1387
f3dd7312
AS
13882012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1389
1390 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1391 when referring to sectname field in printf format.
1392
81899c91
PE
13932012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1394
57b81a9f
PE
1395 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1396 Only r_alloc_inhibit_buffer_relocation needed to be added;
1397 the others were already declared.
1398
81899c91
PE
1399 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1400 before checking whether it's out of range. Put the check inside
1401 eassert. See
1402 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1403
33017faf 14042012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
1405
1406 * callproc.c (Fcall_process): Restore a line that was accidentally
1407 commented out in the 2011-02-13 change (bug#11547).
1408
33017faf 14092012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
1410
1411 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1412 defined on ralloc.c.
1413
1414 * buffer.c [REL_ALLOC]: Remove prototypes of
1415 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1416 they are now on lisp.h.
1417
1418 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1419
1420 * search.c (search_buffer): Use it to inhibit relocation of buffer
1421 text while re_search_2 is doing its job, because re_search_2 is
1422 passed C pointers to buffer text. (Bug#11519)
1423
23415acf
EZ
1424 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1425 Update value to 24.
1426
44e27368
EZ
1427 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1428 state after an additional call to move_it_in_display_line_to, keep
1429 the values of it->max_ascent and it->max_descent found for the
1430 entire line.
1431 (pos_visible_p): Revert the comparison against bottom_y to what it
1432 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1433 (Bug#11464)
1434
c1892f11
PE
14352012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1436
1437 Fix coding-related core dumps with gcc -ftrapv.
1438 The code was computing A - B, where A and B are pointers, and B is
1439 random garbage. This can lead to core dumps on platforms that
1440 have special pointer registers, and it also leads to core dumps on
1441 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1442 A - B only when B is initialized properly.
1443 * coding.c (coding_set_source, coding_set_destination): Return void.
1444 (coding_change_source, coding_change_destinations): New functions,
1445 with the old behaviors of coding_set_source and coding_set_destination.
1446 All callers that need an offset changed to use these new functions.
1447
eb7afdad
GM
14482012-05-26 Glenn Morris <rgm@gnu.org>
1449
1450 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1451
f12fdf02
EZ
14522012-05-26 Eli Zaretskii <eliz@gnu.org>
1453
53a63be6 1454 Extend mouse support on W32 text-mode console.
61b108cc
SM
1455 * xdisp.c (draw_row_with_mouse_face):
1456 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1457
eb3f6f01 1458 * w32console.c: Include window.h.
61b108cc
SM
1459 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1460 New functions.
eb3f6f01
EZ
1461 (initialize_w32_display): Initialize mouse-highlight data.
1462
53a63be6
EZ
1463 * w32inevt.c: Include termchar.h and window.h.
1464 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1465 moves, call note_mouse_highlight. If help_echo changed, call
1466 gen_help_event to produce help-echo message in the echo area.
1467 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1468 highlight info.
1469
4cfd81f6
PE
14702012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1471
1472 * lread.c (read1): Simplify slightly to avoid an overflow warning
1473 with GCC 4.7.0 on x86-64.
1474
4446092a
EZ
14752012-05-26 Eli Zaretskii <eliz@gnu.org>
1476
1477 * bidi.c (bidi_mirror_char): Revert last change: an int is
1478 definitely wide enough here.
1479
42b2a986 14802012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1481
42b2a986 1482 Fix integer width and related bugs (Bug#9874).
eb106a49 1483 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1484 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1485 (string_bytes, check_sblock, allocate_string_data):
1486 (compact_small_strings, Fmake_bool_vector, make_string)
1487 (make_unibyte_string, make_multibyte_string)
1488 (make_string_from_bytes, make_specified_string)
1489 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1490 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1491 (mark_vectorlike):
1492 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1493 (allocate_pseudovector):
1494 Use int, not EMACS_INT, where int is wide enough.
1495 (inhibit_garbage_collection, Fgarbage_collect):
1496 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1497 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1498 int might not be wide enough.
1499 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1500 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1501 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1502 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1503 (bidi_level_of_next_char, bidi_move_to_visually_next):
1504 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1505 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1506 (Fkill_buffer, Fset_buffer_major_mode)
1507 (advance_to_char_boundary, Fbuffer_swap_text)
1508 (Fset_buffer_multibyte, overlays_at, overlays_in)
1509 (overlay_touches_p, struct sortvec, record_overlay_string)
1510 (overlay_strings, recenter_overlay_lists)
1511 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1512 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1513 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1514 (Foverlay_recenter, last_overlay_modification_hooks_used)
1515 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1516 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
1517 (validate_region): Omit unnecessary test for b <= e,
1518 since that's guaranteed by the previous test.
d311d28c
PE
1519 (adjust_overlays_for_delete): Avoid pos + length overflow.
1520 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1521 (report_overlay_modification):
1522 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1523 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1524 Omit pointer cast, which isn't needed anyway, and doesn't work
1525 after the EMACS_INT -> ptrdiff_t change.
02481186 1526 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
1527 * buffer.h: Adjust decls to match defn changes elsewhere.
1528 (struct buffer_text, struct buffer):
1529 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1530 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
1531 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1532 not int, to avoid needless 32-bit limit on 64-bit hosts.
1533 (exec_byte_code): Use tighter memory-full test, one that checks
1534 for alloca overflow. Don't compute the address of the object just
1535 before an array, as that's not portable. Use EMACS_INT, not
1536 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
1537 * callint.c (Fcall_interactively):
1538 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1539 * callproc.c (call_process_kill, Fcall_process):
1540 Don't assume pid_t fits into an Emacs fixnum.
1541 (call_process_cleanup, Fcall_process, child_setup):
1542 Don't assume pid_t fits into int.
1543 (call_process_cleanup, Fcall_process, delete_temp_file)
1544 (Fcall_process_region):
1545 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1546 (Fcall_process): Simplify handling of volatile integers.
1547 Use int, not EMACS_INT, where int will do.
1548 * casefiddle.c (casify_object, casify_region, operate_on_word)
1549 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1550 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1551 (casify_object): Avoid integer overflow when overallocating buffer.
1552 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1553 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1554 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1555 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1556 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1557 integers are now checked earlier. All uses replaced with XINT.
1558 (ccl_driver):
1559 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1560 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1561 (ccl_driver, Fregister_code_conversion_map):
1562 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1563 (resolve_symbol_ccl_program): Check that vector header is in range.
1564 Always copy the vector, so that we can check its contents reliably
1565 now rather than having to recheck each instruction as it's being
1566 executed. Check that vector words fit in 'int'.
1567 (ccl_get_compiled_code, Fregister_ccl_program)
1568 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1569 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1570 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1571 contents are in range.
1572 (Fccl_execute_on_string): Check that status is in range.
1573 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1574 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1575 Accept and return EMACS_INT, not int, because callers can pass values
1576 out of 'int' range.
1577 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1578 (multibyte_chars_in_text, parse_str_as_multibyte)
1579 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1580 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1581 (string_escape_byte8, Fget_byte):
1582 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1583 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1584 avoid mishandling large integers.
1585 * character.h: Adjust decls to match defn changes elsewhere.
1586 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1587 (Ffind_charset_region):
1588 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1589 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1590 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1591 Don't assume fixnum fits in int.
d311d28c
PE
1592 (load_charset_map_from_vector, Fmap_charset_chars):
1593 Remove now-unnecessary CHECK_NATNUMs.
1594 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1595 Don't rely on undefined behavior with signed left shift overflow.
1596 Don't assume unsigned int fits into fixnum, or that fixnum fits
1597 into unsigned int. Don't require max_code to be a valid fixnum;
1598 that's not true for gb10830 4-byte on a 32-bit host. Allow
1599 invalid_code to be a cons, for the same reason. Require code_offset
1600 to be a character. Avoid int overflow if max_char is close
1601 to INT_MAX.
1602 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1603 this is intended anyway and avoids some undefined behavior.
1604 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1605 INDEX_TO_CODE_POINT, as that's what it expects.
1606 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1607 * charset.h (DECODE_CHAR): Return int, not unsigned;
1608 this is what was intended anyway, and it avoids undefined behavior.
1609 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1610 integer-overflow issues.
1611 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1612 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1613 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1614 * chartab.c (Fmake_char_table, Fset_char_table_range)
1615 (uniprop_get_decoder, uniprop_get_encoder):
1616 Don't assume fixnum fits in int.
1617 * cmds.c (move_point): New function, that does the gist of
1618 Fforward_char and Fbackward_char, but does so while checking
1619 for integer overflow more accurately.
c96e5d6a 1620 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1621 (Fforward_line, Fend_of_line, internal_self_insert)
1622 (internal_self_insert):
1623 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1624 Fix a FIXME, by checking for integer overflow when calculating
1625 target_clm and actual_clm.
1626 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1627 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1628 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1629 (coding_alloc_by_making_gap, alloc_destination)
1630 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1631 (encode_coding_utf_16, detect_coding_emacs_mule)
1632 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1633 (detect_coding_iso_2022, decode_coding_iso_2022)
1634 (encode_invocation_designation, encode_designation_at_bol)
1635 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1636 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1637 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1638 (encode_coding_ccl, encode_coding_raw_text)
1639 (detect_coding_charset, decode_coding_charset)
1640 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1641 (produce_composition, produce_charset, produce_annotation)
1642 (decode_coding, handle_composition_annotation)
1643 (handle_charset_annotation, consume_chars, decode_coding_gap)
1644 (decode_coding_object, encode_coding_object, detect_coding_system)
1645 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1646 (code_convert_region, code_convert_string)
8f50130c
PE
1647 (Fdefine_coding_system_internal)
1648 (coding_set_source, coding_set_destination):
d311d28c
PE
1649 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1650 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1651 (Fdefine_coding_system_internal):
1652 Don't assume fixnums fit in int.
1653 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1654 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1655 (Funencodable_char_position, Fcheck_coding_systems_region)
1656 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1657 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1658 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1659 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1660 Don't access memory outside of the args array.
d311d28c 1661 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1662 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1663 result of ENCODE_CHAR.
d311d28c
PE
1664 * coding.h: Adjust decls to match defn changes elsewhere.
1665 (struct coding_system):
1666 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1667 * composite.c (get_composition_id, find_composition)
1668 (run_composition_function, update_compositions)
1669 (compose_text, composition_gstring_put_cache)
1670 (composition_gstring_p, composition_gstring_width)
1671 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1672 (composition_compute_stop_pos, composition_reseat_it)
1673 (composition_update_it, struct position_record)
1674 (find_automatic_composition, composition_adjust_point)
1675 (Fcomposition_get_gstring, Ffind_composition_internal):
1676 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1677 (update_compositions):
1678 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1679 * composite.h: Adjust decls to match defn changes elsewhere.
1680 (struct composition):
1681 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1682 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1683 Do not attempt to compute the address of the object just before a
1684 buffer; this is not portable.
1685 (Faref, Faset):
1686 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1687 (Faset): Use int, not EMACS_INT, where int is wide enough.
1688 (Fstring_to_number): Don't assume fixnums fit in int.
1689 (Frem): Don't assume arg is nonnegative.
1690 * dbusbind.c (xd_append_arg): Check for integers out of range.
1691 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1692 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1693 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1694 (xd_get_connection_references): Return ptrdiff_t, not int.
1695 All uses changed.
1696 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1697 (xd_read_message_1):
1698 Use int, not unsigned, where the dbus API uses int.
1699 (Fdbus_message_internal): Don't overflow mtype.
1700 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
1701 * dired.c (directory_files_internal, file_name_completion, scmp)
1702 (file_name_completion_stat):
1703 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1704 (file_name_completion): Don't overflow matchcount.
1705 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1706 * dispextern.h: Adjust decls to match defn changes elsewhere.
1707 (struct text_pos, struct glyph, struct bidi_saved_info)
1708 (struct bidi_string_data, struct bidi_it, struct composition_it)
1709 (struct it):
1710 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1711 (struct display_pos, struct composition_it, struct it):
1712 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1713 * dispnew.c (increment_matrix_positions)
1714 (increment_row_positions, mode_line_string)
1715 (marginal_area_string):
1716 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 1717 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
1718 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1719 (duration_to_sec_usec): New function, to check for overflow better.
1720 (Fsleep_for, sit_for): Use it.
1721 * doc.c (get_doc_string, store_function_docstring):
1722 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1723 (get_doc_string, Fsnarf_documentation):
1724 Use int, not EMACS_INT, where int is wide enough.
1725 (get_doc_string):
1726 Use SAFE_ALLOCA, not alloca.
1727 Check for overflow when converting EMACS_INT to off_t.
1728 * doprnt.c (doprnt):
1729 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1730 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1731 Don't assume uid_t fits into fixnum.
1732 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1733 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1734 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1735 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1736 (general_insert_function)
1737 (Finsert_char, make_buffer_string, make_buffer_string_both)
1738 (update_buffer_properties, Fbuffer_substring)
1739 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1740 (Fsubst_char_in_region, check_translation)
1741 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1742 (transpose_markers, Ftranspose_regions):
1743 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1744 (clip_to_bounds): Move to lisp.h as an inline function).
1745 (Fconstrain_to_field): Don't assume integers are nonnegative.
1746 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1747 (Fsubst_char_in_region, Fsave_restriction):
1748 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1749 (Femacs_pid): Don't assume pid_t fits into fixnum.
1750 (lo_time): Use int, not EMACS_INT, when int suffices.
1751 (lisp_time_argument): Check for usec out of range.
1752 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
1753 (Fuser_login_name, Fuser_full_name): Signal an error
1754 if a uid argument is out of range, rather than relying on
1755 undefined behavior.
c8d5c857
PE
1756 (Fformat_time_string): Remove now-unnecessary check.
1757 lisp_time_argument checks for out-of-range usec now.
243e0530 1758 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
1759 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1760 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1761 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1762 (init_cmdargs, Fdump_emacs):
1763 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1764 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1765 the bottom (typically) 32 bits of the fixnum.
1766 * eval.c (specpdl_size, call_debugger):
1767 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1768 (when_entered_debugger, Fbacktrace_debug):
1769 Don't assume fixnum can fit in int.
1770 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1771 the object just before a buffer; this is not portable.
1772 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1773 (grow_specpdl, unbind_to):
1774 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1775 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1776 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1777 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1778 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1779 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1780 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1781 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1782 (a_write, e_write):
1783 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1784 (Fcopy_file, non_regular_nbytes, read_non_regular)
1785 (Finsert_file_contents):
1786 Use int, not EMACS_INT, where int is wide enough.
1787 (READ_BUF_SIZE): Verify that it fits in int.
1788 (Finsert_file_contents): Check that counts are in proper range,
1789 rather than assuming fixnums fit into ptrdiff_t etc.
1790 Don't assume fixnums fit into int.
125b3835 1791 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1792 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1793 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1794 (string_char_to_byte, string_byte_to_char)
1795 (string_make_multibyte, string_to_multibyte)
1796 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1797 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1798 (substring_both, Fdelete, internal_equal, Ffillarray)
1799 (Fclear_string, mapcar1)
1800 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1801 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1802 (larger_vector, make_hash_table, maybe_resize_hash_table)
1803 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1804 (Fmaphash, secure_hash):
1805 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1806 (concat): Check for string index and length overflow.
1807 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1808 (Frequire):
1809 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1810 (larger_vector): New API (vec, incr_min, size_max) replaces old
1811 one (vec, new_size, init). This catches size overflow.
1812 INIT was removed because it was always Qnil.
1813 All callers changed.
1814 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1815 the upper bound on a hash table index size.
1816 (make_hash_table, maybe_resize_hash_table): Use it.
1817 (secure_hash): Computer start_byte and end_byte only after
1818 they're known to be in ptrdiff_t range.
1819 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1820 (Ffont_get_glyphs, Ffont_at):
1821 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1822 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1823 (Flist_fonts, Fopen_font):
1824 Don't assume fixnum can fit in int.
1825 (check_gstring): Don't assume index can fit in int.
1826 (font_match_p): Check that fixnum is a character, not a nonnegative
1827 fixnum, since the later code needs to stuff it into an int.
1828 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1829 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1830 conversion overflow issues.
1831 (Fopen_font): Check for integer out of range.
1832 (Ffont_get_glyphs): Don't assume index can fit in int.
1833 * font.h: Adjust decls to match defn changes elsewhere.
1834 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1835 integer overflow.
1836 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1837 printmax_t, where ptrdiff_t is wide enough.
1838 (Finternal_char_font):
1839 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1840 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1841 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1842 (Fset_frame_position, x_set_frame_parameters)
1843 (x_set_line_spacing, x_set_border_width)
1844 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1845 Check that fixnums are in proper range for system types.
1846 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1847 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1848 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1849 Use SAFE_ALLOCA_LISP, not alloca.
1850 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1851 intptr_t is wide enough.
1852 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1853 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1854 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1855 Check for fixnum out of range.
1856 * ftfont.c (ftfont_list): Don't assume index fits in int.
1857 Check that fixnums are in proper range for system types.
1858 (ftfont_shape_by_flt):
1859 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1860 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1861 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1862 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1863 Check that fixnums are in proper range for system types.
1864 * gnutls.h: Adjust decls to match defn changes elsewhere.
1865 * gtkutil.c (xg_dialog_run):
1866 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1867 (update_frame_tool_bar):
1868 Check that fixnums are in proper range for system types.
1869 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1870 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1871 * indent.c (last_known_column, last_known_column_point):
1872 (current_column_bol_cache):
1873 (skip_invisible, current_column, check_display_width):
1874 (check_display_width, scan_for_column, current_column_1)
1875 (Findent_to, Fcurrent_indentation, position_indentation)
1876 (indented_beyond_p, Fmove_to_column, compute_motion):
1877 (Fcompute_motion, Fvertical_motion):
1878 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1879 (last_known_column_modified): Use EMACS_INT, not int.
1880 (check_display_width):
1881 (Fcompute_motion):
1882 Check that fixnums and floats are in proper range for system types.
1883 (compute_motion): Don't assume index or fixnum fits in int.
1884 (compute_motion, Fcompute_motion):
1885 Use int, not EMACS_INT, when it is wide enough.
1886 (vmotion): Omit local var start_hpos that is always 0; that way
1887 we don't need to worry about overflow in expressions involving it.
1888 * indent.h: Adjust decls to match defn changes elsewhere.
1889 (struct position):
1890 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1891 Use int, not EMACS_INT, where int is wide enough.
1892 Remove unused members ovstring_chars_done and tab_offset;
1893 all uses removed.
1894 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1895 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1896 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1897 (make_gap, copy_text, insert, insert_and_inherit)
1898 (insert_before_markers, insert_before_markers_and_inherit)
1899 (insert_1, count_combining_before, count_combining_after)
1900 (insert_1_both, insert_from_string)
1901 (insert_from_string_before_markers, insert_from_string_1)
1902 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1903 (adjust_after_replace, adjust_after_insert, replace_range)
1904 (replace_range_2, del_range, del_range_1, del_range_byte)
1905 (del_range_both, del_range_2, modify_region)
1906 (prepare_to_modify_buffer, signal_before_change)
1907 (signal_after_change, Fcombine_after_change_execute):
1908 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1909 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1910 (balance_an_interval, split_interval_right, split_interval_left)
1911 (find_interval, next_interval, update_interval)
1912 (adjust_intervals_for_insertion, delete_node, delete_interval)
1913 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1914 (static_offset_intervals, offset_intervals)
1915 (merge_interval_right, merge_interval_left, make_new_interval)
1916 (graft_intervals_into_buffer, temp_set_point_both)
1917 (temp_set_point, set_point, adjust_for_invis_intang)
1918 (set_point_both, move_if_not_intangible, get_property_and_range)
1919 (get_local_map, copy_intervals, copy_intervals_to_string)
1920 (compare_string_intervals, set_intervals_multibyte_1):
1921 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1922 * intervals.h: Adjust decls to match defn changes elsewhere.
1923 (struct interval):
1924 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1925 * keyboard.c (this_command_key_count, this_single_command_key_start)
1926 (before_command_key_count, before_command_echo_length, echo_now)
1927 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1928 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1929 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1930 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1931 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1932 (last_non_minibuf_size, last_point_position, echo_truncate)
1933 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1934 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1935 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1936 (stuff_buffered_input):
1937 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1938 (last_auto_save, command_loop_1, read_char):
1939 Use EMACS_INT, not int, to avoid integer overflow.
1940 (record_char): Avoid overflow in total_keys computation.
1941 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1942 * keyboard.h: Adjust decls to match defn changes elsewhere.
1943 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1944 (Fkey_description, Fdescribe_vector, Flookup_key):
1945 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1946 (click_position): New function, to check that positions are in range.
1947 (Fcurrent_active_maps):
1948 (describe_command):
1949 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1950 (Faccessible_keymaps, Fkey_description):
1951 (preferred_sequence_p):
1952 Don't assume fixnum can fit into int.
1953 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1954 Check for integer overflow in size calculations.
1955 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1956 avoid mishandling large integers.
1957 * lisp.h: Adjust decls to match defn changes elsewhere.
1958 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1959 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1960 (struct Lisp_Marker):
1961 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1962 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1963 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1964 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1965 All callers changed.
1966 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1967 Assume the arg has valid form, since it always does.
1968 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1969 unsigned integer system type.
1970 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1971 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1972 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1973 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1974 (duration_to_sec_usec): New decl.
1975 * lread.c (read_from_string_index, read_from_string_index_byte)
1976 (read_from_string_limit, readchar, unreadchar, openp)
1977 (read_internal_start, read1, oblookup):
1978 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1979 (Fload, readevalloop, Feval_buffer, Feval_region):
1980 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1981 (openp): Check for out-of-range argument to 'access'.
1982 (read1): Use int, not EMACS_INT, where int is wide enough.
1983 Don't assume fixnum fits into int.
6efdadfd 1984 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1985 (read_filtered_event): Use duration_to_sec_usec
1986 to do proper overflow checking on durations.
d311d28c
PE
1987 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1988 in size calculation.
1989 (Fexecute_kbd_macro):
1990 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1991 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1992 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1993 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1994 (set_marker_both, set_marker_restricted_both, marker_position)
1995 (marker_byte_position, Fbuffer_has_markers_at):
1996 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1997 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1998 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1999 It now merely ensures that the menu is large enough, without
2000 necessarily growing it, as this avoids some integer overflow issues.
2001 All callers changed.
2002 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2003 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2004 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2005 Use SAFE_ALLOCA_LISP, not alloca.
2006 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2007 to EMACS_INT. Check that fixnums are in proper range for system types.
2008 * minibuf.c (minibuf_prompt_width, string_to_object)
2009 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2010 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2011 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2012 (get_minibuffer, read_minibuf_unwind):
2013 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2014 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2015 this simplifies overflow checking. All callers changed.
2016 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2017 (Ftest_completion):
2018 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2019 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2020 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2021 Check that fixnums are in proper range for system types.
2022 (Fx_create_frame, Fx_show_tip):
2023 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2024 * nsfont.m (ns_findfonts, nsfont_list_family):
2025 Don't assume fixnum fits in long.
2026 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2027 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2028 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2029 wide enough.
17fdb222 2030 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2031 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2032 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2033 (PRINTDECLARE, PRINTPREPARE):
2034 (strout, print_string):
2035 (print, print_preprocess, print_check_string_charset_prop)
2036 (print_object):
2037 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2038 (PRINTDECLARE):
2039 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2040 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2041 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2042 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2043 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2044 (print_error_message): Use SAFE_ALLOCA, not alloca.
2045 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2046 (print_depth, new_backquote_output, print_number_index):
2047 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2048 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2049 (Fset_process_window_size, Fformat_network_address)
2050 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2051 (sigchld_handler):
d311d28c 2052 Check that fixnums are in proper range for system types.
d44287d4 2053 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2054 Check for process-ids out of pid_t range rather than relying on
2055 undefined behavior.
e4d81efc 2056 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2057 (Fformat_network_address, read_process_output, send_process)
2058 (Fprocess_send_region, status_notify):
2059 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2060 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2061 (wait_reading_process_output, read_process_output, exec_sentinel):
2062 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2063 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2064 (Faccept_process_output): Use duration_to_sec_usec to do proper
2065 overflow checking on durations.
dde14581
PE
2066 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2067 Don't assume pid_t fits in int.
02481186
PE
2068 * process.h (struct Lisp_Process): Members tick and update_tick
2069 are now of type EMACS_INT, not int.
b62b53e8
PE
2070 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2071 configured --with-wide-int.
d311d28c
PE
2072 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2073 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2074 * search.c (looking_at_1, string_match_1):
2075 (fast_string_match, fast_c_string_match_ignore_case)
2076 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2077 (scan_newline, find_before_next_newline, search_command)
2078 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2079 (set_search_regs, wordify):
2080 (Freplace_match):
2081 (Fmatch_data):
2082 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2083 (string_match_1, search_buffer, set_search_regs):
2084 (Fmatch_data):
2085 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2086 (wordify): Check for overflow in size calculation.
2087 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2088 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2089 Check that fixnums are in proper range for system types.
2090 * sound.c (struct sound_device)
2091 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2092 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2093 (Fplay_sound_internal):
2094 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2095 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2096 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2097 (Fparse_partial_sexp):
2098 Don't assume fixnums can fit in int.
2099 (struct lisp_parse_state, find_start_pos, find_start_value)
2100 (find_start_value_byte, find_start_begv)
2101 (update_syntax_table, char_quoted, dec_bytepos)
2102 (find_defun_start, prev_char_comend_first, back_comment):
2103 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2104 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2105 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2106 (Finternal_describe_syntax_value): Check that match_lisp is a
2107 character, not an integer, since the code stuffs it into int.
2108 (scan_words, scan_sexps_forward):
2109 Check that fixnums are in proper range for system types.
2110 (Fforward_word):
2111 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2112 (scan_sexps_forward):
2113 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2114 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2115 * syntax.h: Adjust decls to match defn changes elsewhere.
2116 (struct gl_state_s):
2117 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2118 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2119 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2120 * sysdep.c (wait_for_termination_1, wait_for_termination)
2121 (interruptible_wait_for_termination, mkdir):
2122 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2123 (emacs_read, emacs_write):
2124 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2125 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2126 and double all fit in int.
d311d28c
PE
2127 * term.c (set_tty_color_mode):
2128 Check that fixnums are in proper range for system types.
2129 * termhooks.h (struct input_event):
2130 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2131 * textprop.c (validate_interval_range, interval_of)
2132 (Fadd_text_properties, set_text_properties_1)
2133 (Fremove_text_properties, Fremove_list_of_text_properties)
2134 (Ftext_property_any, Ftext_property_not_all)
2135 (copy_text_properties, text_property_list, extend_property_ranges)
2136 (verify_interval_modification):
2137 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2138 (Fnext_single_char_property_change)
2139 (Fprevious_single_char_property_change):
2140 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2141 (copy_text_properties):
2142 Check for integer overflow in index calculation.
d311d28c
PE
2143 * undo.c (last_boundary_position, record_point, record_insert)
2144 (record_delete, record_marker_adjustment, record_change)
2145 (record_property_change):
2146 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2147 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2148 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2149 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2150 (Fx_hide_tip, Fx_file_dialog):
2151 * w32menu.c (set_frame_menubar):
2152 Use ptrdiff_t, not int, for consistency with rest of code.
2153 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2154 (select_window, Fdelete_other_windows_internal)
2155 (window_scroll_pixel_based, window_scroll_line_based)
2156 (Frecenter, Fset_window_configuration):
2157 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2158 (Fset_window_hscroll, run_window_configuration_change_hook)
2159 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2160 (Fscroll_other_window, Frecenter):
d311d28c
PE
2161 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2162 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2163 Don't assume fixnum fits in int.
2164 (Fset_window_scroll_bars):
2165 Check that fixnums are in proper range for system types.
2166 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2167 (string_pos, c_string_pos, number_of_chars, init_iterator)
2168 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2169 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2170 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2171 (face_before_or_after_it_pos, handle_invisible_prop)
2172 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2173 (display_prop_intangible_p, string_buffer_position_lim)
2174 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2175 (get_overlay_strings_1, get_overlay_strings)
2176 (iterate_out_of_display_property, forward_to_next_line_start)
2177 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2178 (get_next_display_element, set_iterator_to_next)
2179 (get_visually_first_element, compute_stop_pos_backwards)
2180 (handle_stop_backwards, next_element_from_buffer)
2181 (move_it_in_display_line_to, move_it_in_display_line)
2182 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2183 (add_to_log, message_dolog, message_log_check_duplicate)
2184 (message2, message2_nolog, message3, message3_nolog
2185 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2186 (current_message_1, truncate_echo_area, truncate_message_1)
2187 (set_message, set_message_1, store_mode_line_noprop)
2188 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2189 (text_outside_line_unchanged_p, check_point_in_composition)
2190 (reconsider_clip_changes)
2191 (redisplay_internal, set_cursor_from_row, try_scrolling)
2192 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2193 (redisplay_window, find_last_unchanged_at_beg_row)
2194 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2195 (trailing_whitespace_p, find_row_edges, display_line)
2196 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2197 (display_mode_element, store_mode_line_string)
2198 (pint2str, pint2hrstr, decode_mode_spec)
2199 (display_count_lines, display_string, draw_glyphs)
2200 (x_produce_glyphs, x_insert_glyphs)
2201 (rows_from_pos_range, mouse_face_from_buffer_pos)
2202 (fast_find_string_pos, mouse_face_from_string_pos)
2203 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2204 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2205 (safe_call, init_from_display_pos, handle_fontified_prop)
2206 (handle_single_display_spec, load_overlay_strings)
2207 (with_echo_area_buffer, setup_echo_area_for_printing)
2208 (display_echo_area, echo_area_display)
2209 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2210 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2211 (redisplay_window, dump_glyph_row, display_mode_line)
2212 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2213 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2214 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2215 (handle_single_display_spec, build_desired_tool_bar_string)
2216 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2217 (get_specified_cursor_type):
2218 Check that fixnums are in proper range for system types.
2219 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2220 (Flookup_image_map):
2221 Don't assume fixnums fit in int.
2222 (compare_overlay_entries):
2223 Avoid mishandling comparisons due to subtraction overflow.
2224 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2225 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2226 (handle_tool_bar_click):
2227 Use int, not unsigned, since we prefer signed and the signedness
2228 doesn't matter here.
2229 (get_next_display_element, next_element_from_display_vector):
2230 Use int, not EMACS_INT, when int is wide enough.
2231 (start_hourglass): Use duration_to_sec_usec to do proper
2232 overflow checking on durations.
2233 * xfaces.c (Fbitmap_spec_p):
2234 Check that fixnums are in proper range for system types.
2235 (compare_fonts_by_sort_order):
2236 Avoid mishandling comparisons due to subtraction overflow.
2237 (Fx_family_fonts, realize_basic_faces):
2238 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2239 (Fx_family_fonts):
2240 Don't assume fixnum fits in int.
2241 Use SAFE_ALLOCA_LISP, not alloca.
2242 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2243 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2244 (face_at_buffer_position, face_for_overlay_string)
2245 (face_at_string_position):
2246 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2247 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2248 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2249 (Fx_show_tip):
2250 Check that fixnums are in proper range for system types.
2251 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2252 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2253 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2254 (Fx_change_window_property): Don't assume fixnums fit in int.
2255 * xfont.c (xfont_chars_supported):
2256 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2257 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2258 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2259 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2260 * xml.c (parse_region):
2261 * xrdb.c (magic_file_p):
2262 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2263 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2264 (x_get_local_selection, x_reply_selection_request)
2265 (x_handle_selection_request, wait_for_property_change):
2266 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2267 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2268 short is wide enough.
2269 (x_send_client_event): Don't assume fixnum fits in int.
2270 * xterm.c (x_x_to_emacs_modifiers):
2271 Don't assume EMACS_INT overflows nicely into int.
2272 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2273 may come from Lisp.
2274 (handle_one_xevent): NATNUMP can eval its arg twice.
2275 (x_connection_closed):
2276 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2277 * xterm.h: Adjust decls to match defn changes elsewhere.
2278 (struct scroll_bar): Use struct vectorlike_header
2279 rather than rolling our own approximation.
2280 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2281
c6574eb5
GM
22822012-05-25 Glenn Morris <rgm@gnu.org>
2283
2284 * lisp.mk (lisp): Update for more files being compiled now.
2285
e8d32c7e
SM
22862012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2287
48def666
SM
2288 * lread.c: Remove `read_pure' which makes no difference.
2289 (read_pure): Remove var.
2290 (unreadpure): Remove function.
2291 (readevalloop): Don't call read_list with -1 flag.
2292 (read1, read_vector): Don't test read_pure any more.
2293 (read_list): Simplify.
2294
e8d32c7e
SM
2295 * fileio.c, character.h: Minor style tweaks.
2296
4b2addb7
DA
22972012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2298
2299 * window.h (clip_changed): Remove useless declaration.
2300
584461b2
JB
23012012-05-22 Juanma Barranquero <lekktu@gmail.com>
2302
2303 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2304 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2305
34374650
PE
23062012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2307
2308 Remove src/m/*.
2309 This directory predates autoconf and is no longer needed nowadays.
2310 Move its few remaining bits of functionality to where they're needed.
2311 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2312 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2313 * m/template.h: Remove.
2314 * Makefile.in (M_FILE): Remove. All uses removed.
2315 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2316 * lisp.h (USE_LSB_TAG):
2317 * mem-limits.h (EXCEEDS_LISP_PTR):
2318 Use VAL_MAX, not VALBITS, in #if.
2319 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2320 (EMACS_UINT): Define unconditionally now.
2321 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2322 (BITS_PER_EMACS_INT): New constants, replacing
2323 what used to be in config.h, but not useful in #if.
2324 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2325 define them any more.
2326 (VAL_MAX): New macro.
2327 (VALMASK): Use it.
2328 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2329 BITS_PER_EMACS_INT, in #if.
2330 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2331 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2332 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2333 * s/ms-w32.h (DATA_START):
2334 Move here from removed file m/intel386.h.
2335 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2336 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2337
261cb4bb
PE
23382012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2339
2340 Assume C89 or later.
2341 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2342 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2343 (xrealloc):
2344 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2345 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2346 * textprop.c, tparam.c (NULL): Remove.
2347 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2348 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2349 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2350 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2351 * xterm.c (input_signal_count): Assume volatile works.
2352
ff23cd9f
KB
23532012-05-21 Ken Brown <kbrown@cornell.edu>
2354
2355 * xgselect.c (xg_select): Fix first argument in call to 'select'
2356 (bug#11508).
2357
1b170bc6
KB
23582012-05-20 Ken Brown <kbrown@cornell.edu>
2359
2360 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 2361 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 2362
b2f4d39f
KB
23632012-05-19 Ken Brown <kbrown@cornell.edu>
2364
2365 * xfns.c (x_in_use): Remove `static' qualifier.
2366 * xterm.h (x_in_use): Declare.
2367 * xgselect.c: Include xterm.h.
2368 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2369 and `display_arg' (bug#9754).
2370
003fdae2
PE
23712012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2372
9232a6d9
PE
2373 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2374
003fdae2
PE
2375 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2376 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2377
784b56e2
EZ
23782012-05-18 Eli Zaretskii <eliz@gnu.org>
2379
2380 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2381
2382 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2383 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2384
2385 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2386 reference to image_cache->refcount.
2387 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2388
a0a79cde
JL
23892012-05-17 Juri Linkov <juri@jurta.org>
2390
2391 * search.c (Fword_search_regexp, Fword_search_backward)
2392 (Fword_search_forward, Fword_search_backward_lax)
2393 (Fword_search_forward_lax): Move functions to isearch.el
2394 (bug#10145, bug#11381).
2395
b0572523
PE
23962012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2397
2398 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2399
9660f5fc
SM
24002012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2401
2402 * lread.c (init_obarray): Declare Qt and Qnil as special.
2403
4374de83
GM
24042012-05-14 Glenn Morris <rgm@gnu.org>
2405
2406 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 2407 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 2408
dc44c39a
PE
24092012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2410
078c97cb
PE
2411 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2412
dc44c39a
PE
2413 * unexaix.c: Port to more-recent AIX compilers.
2414 (report_error, report_error_1, make_hdr, copy_sym)
2415 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2416 Make arguments const char *, not char *, to avoid violations of C
2417 standard and to fix some AIX warnings reported by Gilles Pion.
2418
e18afed7 24192012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
2420
2421 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2422 already have overlays loaded.
2423 (handle_single_display_spec): Before returning without displaying
2424 fringe bitmap, synchronize the bidi iterator with the main display
2425 iterator, by calling iterate_out_of_display_property.
2426 (iterate_out_of_display_property): Detect buffer iteration by
2427 testing that it->string is a Lisp string.
2428 (get_next_display_element): When the current object is exhausted,
2429 and there's something on it->stack, call set_iterator_to_next to
2430 proceed with what's on the stack, instead of returning zero.
2431 (set_iterator_to_next): If called at the end of a Lisp string,
2432 proceed to consider_string_end without incrementing string
2433 position. Don't increment display vector index past the end of
2434 the display vector. (Bug#11417)
c8fb9dc6
EZ
2435 (pos_visible_p): Don't report a position visible when move_it_to
2436 stopped at the last line of window, which happens to be scanned
2437 backwards by the bidi iteration. (Bug#11464)
ac268e67 2438
e18afed7 24392012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2440
2441 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2442 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2443 are on a TTY, and thus unable to display on the fringes.
2444 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2445 so we need to signal to the caller that this is a "replacing"
2446 display spec. This fixes display when the spec is invalid or we
2447 are on a TTY.
2448
e18afed7 24492012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2450
2451 * unexaix.c (make_hdr): Fix typo in prototype.
2452 This bug broke the build on AIX. Problem reported by Gilles Pion.
2453
9d0a235a
MA
24542012-05-14 Michael Albinus <michael.albinus@gmx.de>
2455
2456 * keyboard.c (kbd_buffer_get_event): Read special events also in
2457 batch mode. (Bug#11415)
2458
9e6b06ed
GM
24592012-05-12 Glenn Morris <rgm@gnu.org>
2460
2461 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2462
c1a1d7a3
EZ
24632012-05-12 Eli Zaretskii <eliz@gnu.org>
2464
2465 * lisp.mk (lisp): Add newcomment.elc.
2466
3fe7cdc8
GM
24672012-05-12 Glenn Morris <rgm@gnu.org>
2468
2469 * Makefile.in (MKDIR_P): New, set by configure.
2470 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2471
53f7d2c0
PE
24722012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2473
2474 Remove unused function hourglass_started.
2475 * dispextern.h (hourglass_started):
2476 * w32fns.c (hourglass_started):
2477 * xdisp.c (hourglass_started): Remove.
2478
75aafb17
JB
24792012-05-10 Juanma Barranquero <lekktu@gmail.com>
2480
2481 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2482 Update dependencies.
2483
12959e8e
PE
24842012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2485
97107e2e
PE
2486 * xgselect.c (xg_select): Put maxfds+1 into a var.
2487 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2488
12959e8e
PE
2489 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2490
836d29b3
DA
24912012-05-10 Dave Abrahams <dave@boostpro.com>
2492
2493 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2494 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2495
5cb67954
MA
24962012-05-09 Michael Albinus <michael.albinus@gmx.de>
2497
2498 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2499 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2500 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2501 Initialize xd_registered_buses.
2502
3478ec45
PE
25032012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2504
b263a6b0
PE
2505 Untag more efficiently if USE_LSB_TAG.
2506 This is based on a proposal by YAMAMOTO Mitsuharu in
2507 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2508 For an admittedly artificial (nth 8000 longlist) benchmark on
2509 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2510 Emacs's overall text size by 1%.
2511 * lisp.h (XUNTAG): New macro.
2512 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2513 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2514 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2515 * eval.c (Fautoload):
2516 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2517 * frame.h (XFRAME): Use XUNTAG.
2518
3478ec45
PE
2519 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2520 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2521 Remove unportable assumptions about print widths of types like
2522 dbus_uint32_t.
2523 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2524 intptr_t when converting between pointer and integer, to avoid GCC
2525 warnings about wrong width.
2526
666b903b 25272012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
2528
2529 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2530 stack for each reader_thread, instead of defaulting to 8MB
2531 determined by the linker. This avoids failures in creating
2532 subprocesses on Windows 7, see the discussion in this thread:
2533 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2534
b120cc17
JC
25352012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2536
2537 Fix up display of the *Minibuf-0* buffer in the mini window.
2538 * keyboard.c (read_char): Don't clear the echo area if there's no
2539 message to clear.
2540 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 2541 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2542
9a4b36f8
MA
25432012-05-07 Michael Albinus <michael.albinus@gmx.de>
2544
2545 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2546 batch mode.
2547
e5f9458f
CY
25482012-05-06 Chong Yidong <cyd@gnu.org>
2549
2550 * lisp.mk (lisp): Update.
2551
eceeb5fc 25522012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2553
2554 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2555
71873e2b
SM
25562012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2557
2558 * data.c (PUT_ERROR): New macro.
2559 (syms_of_data): Use it. Add new error type `user-error'.
2560 * undo.c (user_error): New function.
2561 (Fprimitive_undo): Use it.
2562 * print.c (print_error_message): Adjust print style for `user-error'.
2563 * keyboard.c (user_error): New function.
2564 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2565
ab0fa4e4
PE
25662012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2567
2568 Do not limit current-time-string to years 1000..9999.
2569 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2570 (Fcurrent_time_string): Support any year that is supported by the
2571 underlying localtime representation. Don't use asctime, as it
2572 has undefined behavior for years outside the range -999..9999.
2573
7ed806a7
PE
25742012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2575
2576 Fix race conditions involving setenv, gmtime, localtime, asctime.
2577 Without this fix, interrupts could mess up code that uses these
2578 nonreentrant functions, since setting TZ invalidates existing
2579 tm_zone or tzname values, and since most of these functions return
2580 pointers to static storage.
2581 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2582 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2583 Grow the critical sections to include not just invoking
2584 localtime/gmtime, but also accessing these functions' results
2585 including their tm_zone values if any, and any related TZ setting.
2586 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2587 so that the struct tm is saved in the critical section.
2588 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2589 motivated by the fact that memory allocation needs to be outside
2590 the critical section.
2591
0c16dfed
DA
25922012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2593
2594 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2595 with RESET_INTERVAL.
2596
2597 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2598 Remove duplicated buffer name initialization.
2599
3f83ace8
JM
26002012-05-02 Jim Meyering <jim@meyering.net>
2601
2602 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2603
c7b8541e
JM
2604 * xfns.c (x_window): Use xstrdup (Bug#11375).
2605
90207a15 26062012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2607
2608 * xdisp.c (pos_visible_p): If already at a newline from the
2609 display string before the 'while' loop, don't walk back the glyphs
2610 from it3.glyph_row. Solves assertion violation when the display
2611 string begins with a newline (egg.el). (Bug#11367)
2612
b593d6a9
AH
26132012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2614
2615 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2616 Move to simple.el.
2617
4737362e
GM
26182012-05-01 Glenn Morris <rgm@gnu.org>
2619
99cf43f9
GM
2620 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2621 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2622 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2623 All were removed before 23.1.
2624
9311dcff
GM
2625 * dispnew.c: Remove HAVE_LIBNCURSES test;
2626 it is always true on relevant platforms.
2627
4d5c6349
GM
2628 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2629 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2630
4737362e
GM
2631 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2632
74dd3a6b
AS
26332012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2634
2635 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2636 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2637 Remove.
2638
13c379ee
PE
26392012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2640
2641 Do not avoid creating empty evaporating overlays (Bug#9642).
2642 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2643 That is, do not delete an evaporating overlay if it becomes
2644 empty after its bounds are adjusted to fit within its buffer.
2645 This fix caused other problems, and I'm reverting it until we get
2646 to the bottom of them.
2647
a8e7d6d7 26482012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2649
2650 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2651
a8e7d6d7 26522012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2653
2654 * xdisp.c (pos_visible_p): If the window start position is beyond
2655 ZV, start the display from buffer beginning. Prevents assertion
2656 violation in init_iterator when the minibuffer window is scrolled
2657 via the scroll bar.
2658
2659 * window.c (window_scroll_pixel_based): Likewise.
2660
a8e7d6d7 26612012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2662
2663 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2664
a8e7d6d7 26652012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2666
2667 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2668 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2669
a8e7d6d7 26702012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2671
b593d6a9
AH
2672 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2673 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2674
1c6900d9
EZ
26752012-04-26 Eli Zaretskii <eliz@gnu.org>
2676
4c3fa1d9
EZ
2677 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2678 display element, check also the underlying string or buffer
2679 character. (Bug#11341)
2680
1c6900d9
EZ
2681 * w32menu.c: Include w32heap.h.
2682 (add_menu_item): If the call to AppendMenuW (via
2683 unicode_append_menu) fails, disable Unicode menus only if we are
2684 running on Windows 9X/Me.
2685
42bf8205
AS
26862012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2687
2688 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2689 (xgetint): Add missing shift for LSB tags.
2690
b1bac16e
MR
26912012-04-24 Martin Rudalics <rudalics@gmx.at>
2692
2693 * keyboard.c (read_char): Don't wipe echo area for select window
2694 events: These might get delayed via `mouse-autoselect-window'
2695 (Bug#11304).
2696
d69621cc
JB
26972012-04-24 Juanma Barranquero <lekktu@gmail.com>
2698
2699 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2700 manipulation of :loaded-from data.
2701
02fd101b
JB
27022012-04-23 Juanma Barranquero <lekktu@gmail.com>
2703
2704 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2705 now a cons (bug#11311).
2706
888bec30
PE
27072012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2708
89a438bd
PE
2709 Do not create empty overlays with the evaporate property (Bug#9642).
2710 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2711 if it becomes empty after its bounds are adjusted to fit within
2712 its buffer. Without this fix, in a nonempty buffer (let ((o
2713 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2714 yields an empty overlay that has the evaporate property, which is
2715 not supposed to happen.
2716
1068fe4d
PE
2717 Fix minor GTK3 problems found by static checking.
2718 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2719 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2720 (struct _EmacsFixedClass, emacs_fixed_get_type):
2721 Move decls here from emacsgtkfixed.h, since they needn't be public.
2722 (emacs_fixed_get_type): Now static.
2723 (emacs_fixed_class_init): Omit unused local.
2724 (emacs_fixed_child_type): Remove; unused.
2725 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2726 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2727 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2728 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2729 (EMACS_FIXED_GET_CLASS): Remove; unused.
2730 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2731
888bec30
PE
2732 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2733 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2734
de85e130
PE
27352012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2736
d0baac98 2737 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 2738 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
2739 (__malloc_size_t, __malloc_ptrdiff_t):
2740 Remove. All uses removed, replaced by the definiens if needed,
2741 since we can assume C89 or better now.
2742 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2743 (protect_malloc_state, align, get_contiguous_space)
2744 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2745 (malloc_atfork_handler_child, malloc_enable_thread)
2746 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2747 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2748 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2749 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2750 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2751 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2752 Define using prototypes, not old style.
2753 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2754 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2755 (align): Don't assume that signed integer overflow wraps around.
2756 Omit unused local var.
2757 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2758 (_free_internal_nolock, memalign, mallochook, reallochook):
2759 Omit no-longer-needed casts.
2760 (valloc): Use getpagesize, not __getpagesize.
2761 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2762 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2763
de85e130
PE
2764 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2765
dcbf5805
MA
27662012-04-22 Michael Albinus <michael.albinus@gmx.de>
2767
2768 Move functions from C to Lisp. Make non-blocking method calls
2769 the default. Implement further D-Bus standard interfaces.
2770
2771 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2772 (QCdbus_request_name_allow_replacement)
2773 (QCdbus_request_name_replace_existing)
2774 (QCdbus_request_name_do_not_queue)
2775 (QCdbus_request_name_reply_primary_owner)
2776 (QCdbus_request_name_reply_in_queue)
2777 (QCdbus_request_name_reply_exists)
2778 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2779 (QCdbus_registered_serial, QCdbus_registered_method)
2780 (QCdbus_registered_signal): New Lisp objects.
2781 (XD_DEBUG_MESSAGE): Use sizeof.
2782 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2783 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2784 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2785 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2786 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2787 (xd_signature, xd_append_arg): Allow float for integer types.
2788 (xd_get_connection_references): New function.
b593d6a9
AH
2789 (xd_get_connection_address): Rename from xd_initialize.
2790 Return cached address.
dcbf5805
MA
2791 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2792 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2793 level.
2794 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2795 Return number of refcounts.
dcbf5805
MA
2796 (Fdbus_get_unique_name): Make stronger parameter check.
2797 (Fdbus_message_internal): New defun.
2798 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2799 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2800 (Fdbus_send_signal, Fdbus_register_service)
2801 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2802 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2803 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2804 (Vdbus_compiled_version, Vdbus_runtime_version)
2805 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2806 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2807 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2808 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2809 Adapt docstring.
dcbf5805 2810
52828e02
PE
28112012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2812
da05bc4c
PE
2813 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2814 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2815 Do not assume ptrdiff_t is the same width as 'int'.
2816
52828e02
PE
2817 * alloc.c: Handle unusual debugging option combinations.
2818 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2819 since the two debugging options are incompatible.
2820 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2821 is defined.
2822 (mem_init, mem_insert, mem_insert_fixup):
2823 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2824 (NEED_MEM_INSERT): Remove; no longer needed.
2825
f01769f9
LL
28262012-04-22 Leo Liu <sdl.web@gmail.com>
2827
2828 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2829
5790543d
PE
28302012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2831
2832 * sysdep.c [__FreeBSD__]: Minor cleanups.
2833 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2834 Use Emacs indenting style more consistently. Avoid some casts.
2835 Use 'double' consistently rather than mixing 'float' and 'double'.
2836
b91b7e4d
EW
28372012-04-21 Eduard Wiebe <usenet@pusto.de>
2838
b593d6a9
AH
2839 * sysdep.c (list_system_processes, system_process_attributes):
2840 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2841
6114eb15
AS
28422012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2843
2844 * lisp.mk (lisp): Update.
2845
2f38dff7
PE
28462012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2847
2848 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2849 It is never used otherwise.
2850
4ae29f89
SM
28512012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2852
2853 * print.c (print_preprocess): Only check print_depth if print-circle
2854 is nil.
2855 (print_object): Check for cycles even when print-circle is nil and
2856 print-gensym is t, but only check print_depth if print-circle is nil.
2857
f30d612a
CY
28582012-04-20 Chong Yidong <cyd@gnu.org>
2859
2860 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2861 set the status to "failed" and ensure that sentinel is run.
2862
c07a4c0b 28632012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2864
2865 * process.c (Fset_process_inherit_coding_system_flag)
2866 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2867 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2868
c07a4c0b 28692012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2870
2871 * xdisp.c (string_buffer_position_lim): Limit starting position to
2872 BEGV.
2873 (set_cursor_from_row): If called for a mode-line or header-line
2874 row, return zero immediately.
2875 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2876 farther than the first row after the header line, if any.
2877 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2878 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2879
c07a4c0b 28802012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2881
4ae29f89
SM
2882 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2883 (bug#11238).
ad3a2b41 2884
c07a4c0b 28852012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 28862012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2887
2888 configure: new option --enable-gcc-warnings (Bug#11207)
2889 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2890 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2891 (ALL_CFLAGS): Use new macros rather than old.
2892 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2893 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2894 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2895 -Wunused-result, -Wunused-variable. This should go away once
2896 the Emacs and Gnulib regex code is merged.
2897 (xmalloc, xrealloc): Now static.
2898
aba027e8
PE
28992012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2900
2901 * dired.c (Fsystem_groups): Remove unused local.
2902
e5a36063
GM
29032012-04-17 Glenn Morris <rgm@gnu.org>
2904
2905 * dired.c (Fsystem_users): Doc fix.
2906
316411f0
DA
29072012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2908
2909 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2910 (syms_of_dired): Add them.
2911
9426aba4
PE
29122012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2913
b62a57be
PE
2914 Fix minor alloc.c problems found by static checking.
2915 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2916 New extern decls, to avoid calling undeclared functions.
2917 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2918 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2919 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2920 (NEED_MEM_INSERT): New macro.
2921 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2922 Remove one incorrect comment and fix another.
b62a57be 2923
3539f31f
PE
2924 Fix minor ralloc.c problems found by static checking.
2925 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2926 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2927 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2928 (r_alloc_sbrk): Now static.
2929
a041960a
PE
2930 Improve ralloc.c interface checking.
2931 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2932 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2933 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2934 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2935 [REL_ALLOC]: ... to here, to check interface.
2936 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2937 Remove decls. This fixes an "It stinks!".
2938
9426aba4
PE
2939 * alloc.c (which_symbols): Fix alignment issue / type clash.
2940
d55c12ed
AS
29412012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2942
2943 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2944 (struct Lisp_Misc_Any): Likewise.
2945 (struct Lisp_Free): Likewise.
2946 * alloc.c (union aligned_Lisp_Symbol): Define.
2947 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2948 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2949 (union aligned_Lisp_Misc): Define.
2950 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2951 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2952 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2953
b948ce8b
PE
29542012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2955
2956 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2957 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2958 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2959 * s/netbsd.h, s/sol2-6.h:
2960 Remove definition of GC_MARK_STACK, since the default now works.
2961 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2962 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2963 no longer the default.
2964 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2965
35dc09a1 29662012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2967
35dc09a1
GM
2968 * lread.c (lisp_file_lexically_bound_p):
2969 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2970
35dc09a1
GM
29712012-04-14 Eli Zaretskii <eliz@gnu.org>
2972
2973 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2974 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2975
29762012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2977
2978 * nsterm.m (constrainFrameRect): Always constrain when there is only
2979 one screen (Bug#10962).
2980
bcd86815
KB
29812012-04-13 Ken Brown <kbrown@cornell.edu>
2982
2983 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2984
c25df26e
RT
29852012-04-13 Reuben Thomas <rrt@sc3d.org>
2986
2987 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2988
0fc59f1e
DC
29892012-04-11 Daniel Colascione <dancol@dancol.org>
2990
2991 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2992 against is gone. It's better to use vfork now so that when Cygwin
2993 gains a new, working vfork, we use it automatically (bug#10398).
2994
de8c03dc
SM
29952012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2996
2997 * window.c (save_window_save): Obey window-point-insertion-type.
2998
2f097256
GM
29992012-04-11 Glenn Morris <rgm@gnu.org>
3000
3001 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3002
453b951e
SM
30032012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3004
3005 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3006
75f1671a 30072012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3008
3009 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3010 (force_quit_count): New var.
3011 (handle_interrupt): Use it.
3012
2a8ce227
JB
30132012-04-10 Juanma Barranquero <lekktu@gmail.com>
3014
3015 * w32.c (w32_delayed_load): Record the full path of the library
3016 being loaded (bug#10424).
3017
935396c0
GM
30182012-04-09 Glenn Morris <rgm@gnu.org>
3019
05920a43
GM
3020 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3021 not just in the obarray, before snarfing them. (Bug#11036)
3022
935396c0
GM
3023 * Makefile.in ($(leimdir)/leim-list.el):
3024 Pass EMACS rather than BUILT_EMACS.
3025
a18ecafa
TZ
30262012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3027
3028 * process.c (make_process):
3029 * process.h: Add integer `gnutls_handshakes_tried' member to
3030 process struct.
3031
6bbef4e5
JC
3032 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3033 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3034
3035 * gnutls.c (gnutls_log_function2i): Convenience log function.
3036 (emacs_gnutls_read): Use new log functions,
3037 `gnutls_handshakes_tried' process member, and
3038 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3039 attempts per process (connection).
3040
b4d3bc10
CY
30412012-04-09 Chong Yidong <cyd@gnu.org>
3042
3043 * eval.c (Fuser_variable_p, user_variable_p_eh)
3044 (lisp_indirect_variable): Functions deleted.
3045 (Fdefvar): Caller changed.
3046
3047 * callint.c (Finteractive, Fcall_interactively):
3048 * minibuf.c (Fread_variable): Callers changed.
3049
70f4d973
EZ
30502012-04-09 Eli Zaretskii <eliz@gnu.org>
3051
3052 * xdisp.c (set_cursor_from_row): If the display string appears in
3053 the buffer at position that is closer to point than the position
3054 after the display string, display the cursor on the first glyph of
3055 the display string. Fixes cursor display when a 'display' text
3056 property immediately follows invisible text. (Bug#11094)
3057
cb3c2e3e
PE
30582012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3059
3060 composite.c: use 'double' consistently
3061 * composite.c (get_composition_id): Use 'double' consistently
3062 instead of converting 'float' to 'double' and vice versa; this is
3063 easier to understand and avoids a GCC warning.
3064
fd06db5d
GM
30652012-04-09 Glenn Morris <rgm@gnu.org>
3066
50fe702a
GM
3067 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3068 preparation for dumping it with emacs. (Bug#4789)
3069 (leimdir): New variable.
3070 ($(leimdir)/leim-list.el): New rule.
3071 (emacs$(EXEEXT)): Depend on leim-list.el.
3072
fd06db5d
GM
3073 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3074 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3075 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3076
55c131ee
AS
30772012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3078
3079 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3080 proper alignment.
3081
9209588f
JB
30822012-04-07 Juanma Barranquero <lekktu@gmail.com>
3083
3084 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3085 Remove unused local variable.
3086
e3fb2efb
PE
30872012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3088
3089 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3090 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3091 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3092 objects, as mark_maybe_pointer will catch them otherwise.
3093 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3094 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3095
b5385551
PE
30962012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3097
3098 Fix typo that broke non-Windows builds.
3099 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3100
9078ead6
EZ
31012012-04-07 Eli Zaretskii <eliz@gnu.org>
3102
3103 Support building on MS-Windows with libxml2.
3104
3105 * makefile.w32-in (OBJ2): Add xml.$(O).
3106 (GLOBAL_SOURCES): Add xml.c.
3107 ($(BLD)/xml.$(O)): New dependency list.
3108
3109 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3110 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3111 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3112 [!WINDOWSNT]: New macros.
3113 (init_libxml2_functions, libxml2_loaded_p): New functions.
3114 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3115 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3116 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3117 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3118 linked in).
6bbef4e5
JC
3119 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3120 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3121 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3122
3123 * emacs.c: Don't include libxml/parser.h.
3124 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3125 xmlCleanupParser directly.
3126
3127 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3128
3811fdf3
EZ
31292012-04-07 Eli Zaretskii <eliz@gnu.org>
3130
3131 * indent.c (Fvertical_motion): If there is a display string at
3132 point, use it.vpos to compute how many lines to backtrack after
3133 move_it_to point. (Bug#11133)
3134
2f8e16b2
EZ
31352012-04-06 Eli Zaretskii <eliz@gnu.org>
3136
3137 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3138 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3139 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3140 macros related to unification of CJK characters. For the details,
3141 see the discussion following the message here:
3142 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3143
3d439cd1
CY
31442012-04-04 Chong Yidong <cyd@gnu.org>
3145
3146 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3147
8bc53d00
EZ
31482012-04-01 Eli Zaretskii <eliz@gnu.org>
3149
3150 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3151 instead of alloca. (Bug#11138)
3152
3b0512a3
AS
31532012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3154
3155 * w32menu.c (is_simple_dialog): Properly check lisp types.
3156 (Bug#11141)
3157
8427ddd2
EZ
31582012-03-31 Eli Zaretskii <eliz@gnu.org>
3159
979022ef
EZ
3160 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3161 position we get to after a call to move_it_to fails the
3162 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3163 only if we wind up in a string from display property. (Bug#11063)
3164
a6b1c7cc
EZ
3165 * window.c (Fdelete_other_windows_internal): Invalidate the row
3166 and column information about mouse highlight, so that redisplay
3167 restores it after reallocating the glyph matrices. (Bug#7464)
3168
8427ddd2
EZ
3169 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3170 string comes from a `display' text property, use the buffer
3171 position of that property as if we actually saw that position in
3172 the row's glyphs.
697ba24b
EZ
3173 (move_it_by_lines): Remove the assertion that
3174 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3175 violated when there's a before-string at the beginning of a line.
3176 (Bug#11063)
8427ddd2 3177
65a0a738
EZ
31782012-03-30 Eli Zaretskii <eliz@gnu.org>
3179
3180 * xdisp.c (append_space_for_newline): If the default face was
3181 remapped, use the remapped face for the appended newline.
3182 (extend_face_to_end_of_line): Use the remapped default face for
3183 extending the face to the end of the line.
3184 (display_line): Call extend_face_to_end_of_line when the default
3185 face was remapped. (Bug#11068)
3186
581355cc
EZ
31872012-03-29 Eli Zaretskii <eliz@gnu.org>
3188
3189 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3190
e8fc049f
SM
31912012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3192
3193 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3194
4fb9a543
GM
31952012-03-27 Glenn Morris <rgm@gnu.org>
3196
3197 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3198 Doc fixes.
3199
679910f1
KH
32002012-03-26 Kenichi Handa <handa@m17n.org>
3201
3202 * dispextern.h (struct glyph): Fix previous change. Change the
3203 bit length of glyphless.ch to 25 (Bug#11082).
3204
90d49b7f
CY
32052012-03-26 Chong Yidong <cyd@gnu.org>
3206
3207 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3208 (command_loop_1): Use it; inhibit selection update for
3209 handle-select-window too (Bug#8996).
3210
f514f6f0
FP
32112012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3212
e8fc049f 3213 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3214
bf43fa51
KH
32152012-03-25 Kenichi Handa <handa@m17n.org>
3216
3217 * dispextern.h (struct glyph): Change the bit length of
3218 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3219
8a0c01dd
EZ
32202012-03-24 Eli Zaretskii <eliz@gnu.org>
3221
3222 * s/ms-w32.h (tzname): Include time.h before redirecting to
3223 _tzname. Fixes the MSVC build. (Bug#9960)
3224
7d1c3a76
AS
32252012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3226
8ed79523
AS
3227 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3228 characters.
3229
7d1c3a76
AS
3230 * xterm.c (XTread_socket): Only modify handling_signal if
3231 !SYNC_INPUT. (Bug#11080)
3232
e99a9b8b
EZ
32332012-03-23 Eli Zaretskii <eliz@gnu.org>
3234
3235 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3236 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3237 when fetching a multibyte character consumes more bytes than
3238 CHAR_BYTES returns, due to unification of CJK characters in
3239 string_char. (Bug#11073)
3240
5063c0e1
TN
32412012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3242
3243 * process.c (wait_reading_process_output): Handle pty disconnect
3244 by refraining from sending oneself a SIGCHLD (bug#10933).
3245
9f851fbd
CY
32462012-03-22 Chong Yidong <cyd@gnu.org>
3247
3248 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3249
5063c0e1 3250 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3251 Mark string as coming from a prefix property.
3252 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3253 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3254
fb5b8aca
CY
32552012-03-21 Chong Yidong <cyd@gnu.org>
3256
3257 * xfaces.c (Vface_remapping_alist): Doc fix.
3258
62356a1b
EZ
32592012-03-20 Eli Zaretskii <eliz@gnu.org>
3260
3261 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3262 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3263 Doc fixes.
62356a1b 3264
025de85b
CY
32652012-03-20 Chong Yidong <cyd@gnu.org>
3266
3267 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3268 to reflect default non-nil value of redisplay-dont-pause.
3269
4827f94e
KH
32702012-03-19 Kenichi Handa <handa@m17n.org>
3271
3272 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3273 it fit in a valid range (Bug#11003).
3274
e50a24a2
EZ
32752012-03-18 Eli Zaretskii <eliz@gnu.org>
3276
3277 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3278 that is not from display property, accept the row as a "cursor
3279 row" if one of the string's character has a non-nil `cursor'
3280 property. Fixes cursor positioning when there are newlines in
3281 overlay strings, e.g. in icomplete.el. (Bug#11035)
3282
9af5ed87
PE
32832012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3284
3285 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3286
d1f55f16
CY
32872012-03-12 Chong Yidong <cyd@gnu.org>
3288
3289 * eval.c (inhibit_lisp_code): Rename from
3290 inhibit_window_configuration_change_hook; move from window.c.
3291
3292 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3293 * window.c (run_window_configuration_change_hook)
3294 (syms_of_window): Callers changed.
3295
66c5eebd
CY
32962012-03-11 Chong Yidong <cyd@gnu.org>
3297
413df973
CY
3298 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3299
66c5eebd
CY
3300 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3301
1de11f56
CY
33022012-03-10 Chong Yidong <cyd@gnu.org>
3303
3304 * frame.c (other_visible_frames): Don't assume the selected frame
3305 is visible (Bug#10955).
3306
cae07000
SM
33072012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3308
3309 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3310
89c94350
JD
33112012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3312
3313 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3314 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3315 zero (Bug#10954).
3316
999dd333
GM
33172012-03-03 Glenn Morris <rgm@gnu.org>
3318
01a6dcc8 3319 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3320
de0100f2
EZ
33212012-03-02 Eli Zaretskii <eliz@gnu.org>
3322
3323 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3324 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3325 (redisplay_window, next_element_from_string): Fix typos in
3326 comments.
3e441275
EZ
3327 (redisplay_window): Pass to move_it_vertically the margin in
3328 pixels, not in screen lines.
de0100f2 3329
96a72ee9
GM
33302012-03-02 Glenn Morris <rgm@gnu.org>
3331
3332 * buffer.c (buffer-list-update-hook): Doc fix.
3333
312508d7
EZ
33342012-02-29 Eli Zaretskii <eliz@gnu.org>
3335
3336 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3337 push_it before setting up the iterator for the first overlay
3338 string, even if we have an empty string loaded.
3339 (next_overlay_string): If there's an empty string on the iterator
3340 stack, pop the stack. (Bug#10903)
3341
27f3c637
PE
33422012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3343
3344 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3345 Suggested by Stefan Monnier in
3346 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3347 * alloc.c (widen_to_Lisp_Object): New static function.
3348 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3349 and widening them to Lisp_Objects. This would work even if
3350 USE_LSB_TAG is defined and wide integers are used, which might
3351 happen in a future version of Emacs.
3352
3c9dfce6
CY
33532012-02-25 Chong Yidong <cyd@gnu.org>
3354
fa74b241
CY
3355 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3356 Doc fix.
3357
3c9dfce6
CY
3358 * xselect.c (Fx_selection_exists_p): Doc fix.
3359 (x_clipboard_manager_save_all): Print an informative message
3360 before saving to clipboard manager.
3361
9486df08
CY
33622012-02-24 Chong Yidong <cyd@gnu.org>
3363
3364 * keyboard.c (process_special_events): Handle all X selection
3365 requests in kbd_buffer, not just the next one (Bug#8869).
3366
f01d3321
CY
33672012-02-23 Chong Yidong <cyd@gnu.org>
3368
3369 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3370 call when setting menu-bar-lines and tool-bar-lines parameters.
3371 (unwind_create_frame_1): New helper function.
3372
3373 * window.c (inhibit_window_configuration_change_hook): New var.
3374 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 3375 (syms_of_window): Initialize it.
f01d3321 3376
86b847b6
CY
33772012-02-22 Chong Yidong <cyd@gnu.org>
3378
3379 * xterm.c (x_draw_image_relief): Add missing type check for
3380 Vtool_bar_button_margin (Bug#10743).
3381
a59225b1
CY
33822012-02-21 Chong Yidong <cyd@gnu.org>
3383
3384 * fileio.c (Vfile_name_handler_alist): Doc fix.
3385
3386 * buffer.c (Fget_file_buffer): Protect against invalid file
3387 handler return value.
3388
310f5bd4
PE
33892012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3390
cb3a28cc
PE
3391 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3392 when computing $valmask.
3393
310f5bd4
PE
3394 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3395 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3396 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3397 It's useless in that case, and it can cause problems on hosts
3398 that allocate halves of EMACS_INT values separately.
3399 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3400 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3401 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3402 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3403 it avoids undefined behavior on hosts where shifting right by more
3404 than the word width has undefined behavior.
3405
2375c96a
CY
34062012-02-19 Chong Yidong <cyd@gnu.org>
3407
3408 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3409 (Funhandled_file_name_directory, Ffile_name_as_directory)
3410 (Fdirectory_file_name, Fexpand_file_name)
3411 (Fsubstitute_in_file_name): Protect against invalid file handler
3412 return values (Bug#10845).
3413
3eb49e71
EZ
34142012-02-18 Eli Zaretskii <eliz@gnu.org>
3415
3416 * .gdbinit (pitx): Fix incorrect references to fields of the
3417 iterator stack.
3418
7b926f3f
CY
34192012-02-17 Chong Yidong <cyd@gnu.org>
3420
3421 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3422
11273115
PE
34232012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3424
3425 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3426 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3427
c3a70e2b
CY
34282012-02-15 Chong Yidong <cyd@gnu.org>
3429
3430 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3431 marked as special. Also, starting docstrings with * is obsolete.
3432
0ca43699
AS
34332012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3434
3435 * gnutls.c (emacs_gnutls_write): Fix last change.
3436
2e8f3c56
LI
34372012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3438
3439 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3440 send_process.
3441
af70074f
SM
34422012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3443
3444 * keymap.c (Fsingle_key_description): Handle char ranges.
3445
95986d52
CY
34462012-02-12 Chong Yidong <cyd@gnu.org>
3447
afd83bd1
CY
3448 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3449 as that creates a dangerous corner case.
3450
95986d52
CY
3451 * window.c (Fdelete_window_internal): Invalidate the mouse
3452 highlight (Bug#9904).
3453
bd7da63e
GM
34542012-02-12 Glenn Morris <rgm@gnu.org>
3455
3456 * xselect.c (Fx_own_selection_internal)
3457 (Fx_get_selection_internal, Fx_disown_selection_internal)
3458 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3459 * nsselect.m (Fx_own_selection_internal)
3460 (Fx_disown_selection_internal, Fx_selection_exists_p)
3461 (Fx_selection_owner_p, Fx_get_selection_internal):
3462 Sync docs and argument specs with the xselect.c versions.
3463
77abcbc2
LI
34642012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3465
3466 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3467
90b671e2
EZ
34682012-02-11 Eli Zaretskii <eliz@gnu.org>
3469
1c0ca0b7
EZ
3470 * w32select.c (Fx_selection_exists_p): Sync doc string and
3471 argument list with xselect.c. (Bug#10783)
3472
3473 * w16select.c (Fx_selection_exists_p): Sync doc string and
3474 argument list with xselect.c. (Bug#10783)
90b671e2 3475
49241268
GM
34762012-02-10 Glenn Morris <rgm@gnu.org>
3477
3478 * fns.c (Fsecure_hash): Doc fix.
3479
f998bbe7 34802012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3481
3482 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3483
0992bd9c
CY
34842012-02-07 Chong Yidong <cyd@gnu.org>
3485
3486 * buffer.c (Fbuffer_local_variables)
3487 (buffer_lisp_local_variables): Handle unbound vars correctly;
3488 don't let Qunbound leak into Lisp.
3489
af008560
GM
34902012-02-07 Glenn Morris <rgm@gnu.org>
3491
dd605cc4
GM
3492 * image.c (Fimagemagick_types): Doc fix.
3493
af008560
GM
3494 * image.c (imagemagick-render-type): Change it from a lisp object
3495 to an integer. Move the doc here from the lisp manual.
3496 Treat all values not equal to 0 the same.
3497
1449fa1d
CY
34982012-02-06 Chong Yidong <cyd@gnu.org>
3499
3500 * doc.c (store_function_docstring): Avoid applying docstring of
3501 alias to base function (Bug#2603).
3502
3723ec07
AS
35032012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3504
3505 * .gdbinit (pp1, pv1): Remove redundant defines.
3506 (pr): Use pp.
3507
79c1cc1e
CY
35082012-02-04 Chong Yidong <cyd@gnu.org>
3509
3510 * nsterm.m: Declare a global (Bug#10694).
3511
d7f29f8e
EZ
35122012-02-04 Eli Zaretskii <eliz@gnu.org>
3513
cae07000
SM
3514 * w32.c (get_emacs_configuration_options):
3515 Include --enable-checking, if specified, in the return value.
d7f29f8e 3516
3b95a6f9
MR
35172012-02-04 Martin Rudalics <rudalics@gmx.at>
3518
3519 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3520 after rounding frame sizes. (Bug#9723)
3521
d6fa96a6
EZ
35222012-02-04 Eli Zaretskii <eliz@gnu.org>
3523
3524 * keyboard.c (adjust_point_for_property): Don't position point
3525 before BEGV. (Bug#10696)
3526
df0b2940
PE
35272012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3528
3529 Handle overflow when computing char display width (Bug#9496).
3530 * character.c (char_width): Return EMACS_INT, not int.
3531 (char_width, c_string_width): Check for overflow when
3532 computing the width; this is possible now that individual
3533 characters can have unbounded width. Problem introduced
3534 by merge from Emacs 23 on 2012-01-19.
3535
6bee44d6
MA
35362012-02-02 Michael Albinus <michael.albinus@gmx.de>
3537
3538 * dbusbind.c (Fdbus_register_method): Mention the return value
3539 :ignore in the docstring.
3540
44f92739
GM
35412012-02-02 Glenn Morris <rgm@gnu.org>
3542
1b9f60cc
GM
3543 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3544
44f92739
GM
3545 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3546 Unconditionally set to t. (Bug#10673)
3547 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3548 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3549 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3550
c5d3843c
KH
35512012-02-02 Kenichi Handa <handa@m17n.org>
3552
3553 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3554 0, do not call append_composite_glyph.
3555
159462d4 35562012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3557
3558 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3559 NULL (Bug#6988).
3560 (x_produce_glyphs): If the component of a composition is a null
3561 string, set it->pixel_width to 1 to avoid zero-width glyph.
3562
78cef877
EZ
35632012-02-01 Eli Zaretskii <eliz@gnu.org>
3564
3565 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3566 first 2 arguments are identical. This makes inserting large
3567 output from a subprocess an order of magnitude faster on
3568 MS-Windows, where all sbrk'ed memory is always contiguous.
3569
97897668
GM
35702012-01-31 Glenn Morris <rgm@gnu.org>
3571
3572 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3573 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3574 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3575
31fd3586
GM
35762012-01-29 Glenn Morris <rgm@gnu.org>
3577
3578 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3579
0e24a8b2
CY
35802012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3581
3582 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3583
cc0adcb0
CY
35842012-01-28 Chong Yidong <cyd@gnu.org>
3585
3586 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3587
acc28cb9
CY
35882012-01-26 Chong Yidong <cyd@gnu.org>
3589
9c69cfb7
CY
3590 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3591
acc28cb9
CY
3592 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3593 repeat counts (Bug#10507).
3594
48da7392
GM
35952012-01-26 Glenn Morris <rgm@gnu.org>
3596
3597 * lread.c (syms_of_lread): Doc fix.
3598
14af5f7f
CY
35992012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3600
3601 * coding.c (encode_designation_at_bol): Change return value to
3602 EMACS_INT.
3603
0b21c100
CY
36042012-01-25 Chong Yidong <cyd@gnu.org>
3605
3606 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3607
3c2907f7
CY
36082012-01-21 Chong Yidong <cyd@gnu.org>
3609
3610 * floatfns.c (Fcopysign): Make the second argument non-optional,
3611 since nil is not allowed anyway.
3612
959ad23f
AS
36132012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3614
3615 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3616 (send_process): Likewise.
3617
34a02f46
MR
36182012-01-19 Martin Rudalics <rudalics@gmx.at>
3619
3620 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3621 (Vwindow_persistent_parameters): Do not use Qstate.
3622 Rewrite doc-strings.
34a02f46 3623
1259009a 36242012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3625
3626 * character.c (char_width): New function.
70d4fdf6
GM
3627 (Fchar_width, c_string_width, lisp_string_width):
3628 Use char_width (Bug#9496).
25ed9e61 3629
6a6ee00d
MR
36302012-01-16 Martin Rudalics <rudalics@gmx.at>
3631
3632 * window.c (Vwindow_persistent_parameters): New variable.
3633 (Fset_window_configuration, save_window_save): Handle persistent
3634 window parameters.
3635
c85efaf7
EZ
36362012-01-14 Eli Zaretskii <eliz@gnu.org>
3637
3638 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3639 thrashing the stack of the thread. (Bug#9087)
3640
5944709e
PE
36412012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3642
3643 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3644
e71f5d99
EZ
36452012-01-11 Eli Zaretskii <eliz@gnu.org>
3646
3647 * xdisp.c (rows_from_pos_range): Handle the case where the
3648 highlight ends on a newline. (Bug#10464)
3649 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3650 he end column for display of highlight that ends on a newline
3651 before a R2L line.
3652
ce316182
GM
36532012-01-11 Glenn Morris <rgm@gnu.org>
3654
3655 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3656 from load-path also when installation-directory is nil. (Bug#10208)
3657
5b43da69
GM
36582012-01-10 Glenn Morris <rgm@gnu.org>
3659
74cc8ff9
GM
3660 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3661
7d8d6e4e
GM
3662 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3663 Update template values to be closer to their typical values these days.
5b43da69 3664
a0db8d43
EZ
36652012-01-09 Eli Zaretskii <eliz@gnu.org>
3666
3667 * xdisp.c (rows_from_pos_range): Accept additional argument
3668 DISP_STRING, and accept any glyph in a row whose object is that
3669 string as eligible for mouse highlight. Fixes mouse highlight of
3670 display strings from overlays. (Bug#10464)
3671
9a0115ab 36722012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3673
b9110d6a 3674 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3675 * fileio.c (auto_saving_dir_umask): New static var.
3676 (Fmake_directory_internal): Use it.
3677 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3678 creating the directory. The old code temporarily assigns
3679 too-generous permissions to the directory.
3680 (do_auto_save_eh): Clear it.
b9110d6a 3681 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3682 that the var is always cleared.
3683
6c1bd3f3
EZ
36842012-01-07 Eli Zaretskii <eliz@gnu.org>
3685
3686 * search.c (scan_buffer): Pass character positions to
3687 know_region_cache, not byte positions. (Bug#6540)
3688
069d2b50
L
36892012-01-07 LynX <_LynX@bk.ru> (tiny change)
3690
3691 * w32.c (sys_rename): Report EXDEV when rename of a directory
3692 fails because the target is on another logical disk. (Bug#10284)
3693
75bf0d33
DB
36942012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3695
3696 * xterm.c (x_embed_request_focus): New function.
3697
3698 * xterm.h: Add prototype.
3699
3700 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3701
1c6e5a32
GM
37022012-01-05 Glenn Morris <rgm@gnu.org>
3703
3704 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3705
651e947e
EZ
37062012-01-01 Eli Zaretskii <eliz@gnu.org>
3707
3708 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3709 Load gnutls_transport_set_lowat only if GnuTLS version is below
3710 2.11.1.
3711 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3712 GnuTLS versions below 2.11.1.
3713
3778cdd8
AL
37142011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3715
3716 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3717 to the doc string advising against its use for altering the way
3718 windows are scrolled.
3719
0e5317f7
KH
37202011-12-28 Kenichi Handa <handa@m17n.org>
3721
3722 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3723 coding-system ASCII compatible only when it does not produce BOM
3724 on encoding (Bug#10383).
3725
93d5ca1f
JD
37262011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3727
3728 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3729 can scroll.
3730 (create_and_show_popup_menu): Always use menu_position_func for
3731 Gtk3 (Bug#10361).
3732
ca22b785
AS
37332011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3734
3735 * callint.c (Fcall_interactively): Don't truncate prompt string.
3736
d048e1e6
EZ
37372011-12-23 Eli Zaretskii <eliz@gnu.org>
3738
3739 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3740 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 3741 resumed from there (after widening). (Bug#10360)
d048e1e6 3742
5ccaba1f
JD
37432011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3744
3745 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3746
204ee57f
JD
37472011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3748
b81d40f0
JB
3749 * nsterm.m (x_free_frame_resources):
3750 Release f->output_data.ns->miniimage.
204ee57f
JD
3751 (ns_index_color): Fix indentation. Do not retain
3752 color_table->colors[i].
3753
3754 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3755 before returning.
3756
3757 * nsfns.m (x_set_background_color): Assign return value from
3758 ns_index_color to face-background instead of NSColor*.
3759 (ns_implicitly_set_icon_type): Fix indentation.
3760 Change assignment in for loop to comparison.
3761
3762 * emacs.c (ns_pool): New variable.
3763 (main): Assign ns_pool.
3764 (Fkill_emacs): Call ns_release_autorelease_pool.
3765
3766 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3767 autorelease fdesc, release fdAttrs and tdict.
3768 (ns_get_covering_families): Release charset.
3769 (ns_findfonts): Release NSFontDescriptor created with new.
3770 (ns_uni_to_glyphs): Fix indentation.
3771 (setString): Release attrStr before assigning new value.
3772
c803b2b7
JD
37732011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3774
678f4426
JD
3775 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3776 and NS_IMPL_COCOA.
3777 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3778 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3779
cd394be1 37802011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3781
5fecd5fc
JD
3782 * nsterm.m (ns_term_init): Subscribe for notifications
3783 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3784 to method trackingNotification in EmacsMenu.
3785
3786 * nsmenu.m (trackingMenu): New variable.
3771cb17 3787 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3788 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3789 from Aquamacs (Bug#7030).
678f4426
JD
3790
37912011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3792
c803b2b7
JD
3793 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3794 (symbol_to_nsstring): Fix indentation.
3795 (ns_symbol_to_pb): New function.
cae07000
SM
3796 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3797 (Fns_rotate_cut_buffers_internal): Remove.
3798 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3799 Fns_store_cut_buffer_internal.
3800 (ns_get_foreign_selection, Fx_own_selection_internal)
3801 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3802 (Fns_get_selection_internal, Fns_store_selection_internal):
3803 Use ns_symbol_to_pb and check if return value is nil.
3804 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3805 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3806 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3807 renamed to Sns_store_selection_internal.
3808 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3809 and remove this function.
3810 (ns_handle_selection_clear): Remove, never used.
3811 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3812 here.
3813
e1b01a3a
KB
38142011-12-17 Ken Brown <kbrown@cornell.edu>
3815
3816 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3817 GID is unknown (Bug#10257).
3818
2adb6e85
PE
38192011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3820
3821 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3822 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3823 which caused a build failure on GNU/Linux IA-64. This problem was
3824 introduced by my 2011-10-07 patch.
3825
d1d7b339
JL
38262011-12-15 Juri Linkov <juri@jurta.org>
3827
3828 * image.c (imagemagick_error): New function. (Bug#10112)
3829 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3830 Use `imagemagick_error' where ImageMagick functions return
3831 `MagickFalse'.
3832 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3833 proper order.
3834
100d5755
KH
38352011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3836
3837 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3838 fill background (Bug#8992).
3839
454592a6
MR
38402011-12-13 Martin Rudalics <rudalics@gmx.at>
3841
3842 * window.c (Vwindow_combination_resize)
3843 (Vwindow_combination_limit): Use t instead of non-nil in
3844 doc-strings.
61d4b438
MR
3845 (Vrecenter_redisplay): Add first sentence of doc-string on
3846 separate line.
53524d93 3847 (Frecenter): Fix doc-string typo.
454592a6 3848
3633e3aa
KH
38492011-12-11 Kenichi Handa <handa@m17n.org>
3850
3851 * coding.c (Funencodable_char_position): Pay attention to the
3852 buffer text relocation (Bug#9389).
3853
7b9d523a 38542011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3855
7b9d523a
JD
3856 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3857 gtk_init (Bug#10100).
3858
b73189c6
EZ
38592011-12-10 Eli Zaretskii <eliz@gnu.org>
3860
3861 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3862 IT->string is nil. (Bug#10263)
3863
f7dfe5d6
JD
38642011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3865
83faebb4
JD
3866 * nsterm.h (x_free_frame_resources): Declare.
3867
f7dfe5d6
JD
3868 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3869 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3870
3871 * nsterm.h (ns_get_defaults_value): Declare.
3872
3873 * nsterm.m (ns_default): Call ns_get_defaults_value.
3874
7cd4e72c
EZ
38752011-12-09 Eli Zaretskii <eliz@gnu.org>
3876
3877 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3878 (Bug#10170)
3879
b34d7317
YM
38802011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3881
3882 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3883 that where the value of an _OBJC_* symbol points to is in the .bss
3884 section (Bug#10240).
3885
76470ad1
KH
38862011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3887
3888 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3889 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3890
745fff94
KH
38912011-12-08 Kenichi Handa <handa@m17n.org>
3892
3893 * ftfont.c (get_adstyle_property): Fix previous change
3894 (Bug#10233).
3895
6e44397c
JB
38962011-12-07 Juanma Barranquero <lekktu@gmail.com>
3897
3898 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3899 dirs from the default value of EMACSLOADPATH (bug#10208).
3900
7efa6272
GM
39012011-12-07 Glenn Morris <rgm@gnu.org>
3902
3903 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3904 installation and source directories as well. (Bug#10208)
3905
f6fc4d87
CY
39062011-12-06 Chong Yidong <cyd@gnu.org>
3907
3908 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3909
2bf26180
GM
39102011-12-06 Glenn Morris <rgm@gnu.org>
3911
3912 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3913 as an error, not just -1. (Bug#10217)
3914
3a6ad4f0
CY
39152011-12-05 Chong Yidong <cyd@gnu.org>
3916
3917 * keyboard.c (process_special_events): New function.
3918 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3919
75a3b399
PE
39202011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3921
3922 * coding.c (encode_designation_at_bol): Don't use uninitialized
3923 local variable (Bug#9318).
3924
c3c9e25e
KH
39252011-12-05 Kenichi Handa <handa@m17n.org>
3926
3927 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3928 return Qnil (Bug#8046, Bug#10193).
3929
5eb05ea3
KH
39302011-12-05 Kenichi Handa <handa@m17n.org>
3931
3932 * coding.c (encode_designation_at_bol): New args charbuf_end and
3933 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3934 (coding_set_source): Return how many bytes coding->source was
3935 relocated.
3936 (coding_set_destination): Return how many bytes
3937 coding->destination was relocated.
3938 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3939 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3940
39412011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3942
3943 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3944 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3945 macro (Bug#9318).
3946
39472011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3948
3949 The following changes are to fix Bug#9318.
3950
a79703f5 3951 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3952 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3953 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3954 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3955
7dbda6df
JB
39562011-12-05 Juanma Barranquero <lekktu@gmail.com>
3957
3958 * lisp.h (process_quit_flag): Fix external declaration.
3959
6d5eb5b0
SM
39602011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3961
3962 Don't macro-inline non-performance-critical code.
3963 * eval.c (process_quit_flag): New function.
3964 * lisp.h (QUIT): Use it.
3965
a0c3fad0
JD
39662011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3967
3968 * nsfns.m (get_geometry_from_preferences): New function.
3969 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3970
6c07aac2
AS
39712011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3972
3973 * emacs.c (Qkill_emacs): Define.
3974 (syms_of_emacs): Initialize it.
3975 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3976 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3977 (quit_throw_to_read_char): Add parameter `from_signal'.
3978 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3979 * lisp.h (QUIT): Call Fkill_emacs if requested.
3980
c052ead4
JD
39812011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3982
3983 * widget.c (update_wm_hints): Return if wmshell is null.
3984 (widget_update_wm_size_hints): New function.
3985
3986 * widget.h (widget_update_wm_size_hints): Declare.
3987
3988 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3989 widget_update_wm_size_hints (Bug#10104).
3990
9e49252b
EZ
39912011-12-03 Eli Zaretskii <eliz@gnu.org>
3992
3993 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3994 before a newline, prepare the bidi iterator for consuming the
3995 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3996 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3997
02b16839
JL
39982011-12-02 Juri Linkov <juri@jurta.org>
3999
4000 * search.c (Fword_search_regexp): New Lisp function created from
4001 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4002 (Fword_search_backward, Fword_search_forward)
4003 (Fword_search_backward_lax, Fword_search_forward_lax):
4004 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4005 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4006
0068070e
SM
40072011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4008
4009 * fileio.c (Finsert_file_contents): Move after-change-function call
4010 to before the "handled:" label, since all "goto handled" appear in
4011 cases where the *-change-functions have already been properly called
4012 (bug#10117).
4013
3360a3fc
AS
40142011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4015
4016 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4017 waiting for input. (Bug#10169)
4018
73d6c093
EZ
40192011-11-30 Eli Zaretskii <eliz@gnu.org>
4020
4021 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4022 verifies glyph row's hash code--we have just reallocated the
4023 glyphs, so their contents can be complete garbage. (Bug#10164)
4024
febe6bea
JB
40252011-11-30 Juanma Barranquero <lekktu@gmail.com>
4026
4027 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4028
801a4313
EZ
40292011-11-30 Eli Zaretskii <eliz@gnu.org>
4030
4031 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4032 attributes are tested _before_ calling verify_row_hash, to protect
4033 against GCC re-ordering of the tests. (Bug#10164)
4034
2b56b87e
JD
40352011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4036
4037 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4038
4039 * xterm.c (handle_one_xevent): Only set async_visible and friends
4040 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4041 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4042 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4043
dbf31225
PE
40442011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4045
4046 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4047 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4048 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4049 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4050 All uses changed to use GCPRO1 etc.
4051 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4052 Revert to old implementation (i.e., before 2011-03-11).
4053
1305621b
YM
40542011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4055
4056 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4057 of scroll runs so as to avoid assigning disabled bogus rows and
4058 unnecessary graphics copy operations.
4059
8c9afb46
EZ
40602011-11-27 Eli Zaretskii <eliz@gnu.org>
4061
4062 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4063 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4064 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4065 (malloc, free, realloc, calloc): Redirect to e_* only when
4066 compiling Emacs.
4067
4068 * lisp.h (GCTYPEBITS): Move before first use.
4069 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4070 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4071 this macro definition.
4072
4073 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4074 _MSC_VER.
4075
54e9e3bf
JD
40762011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4077
6d5eb5b0
SM
4078 * gtkutil.c (xg_create_frame_widgets):
4079 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4080 present with Gtk+ 2.0.
4081
83aca1cb
PE
40822011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4083
4084 * fileio.c (Finsert_file_contents): Undo previous change; see
4085 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4086
5b76caa4
PE
40872011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4088
4089 Rename locals to avoid shadowing.
4090 * fileio.c (Finsert_file_contents):
4091 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4092 * process.c (wait_reading_process_output):
4093 Rename inner 'proc' to 'p' to avoid shadowing.
4094 Indent for consistency with usual Emacs style.
4095
8c535114
EZ
40962011-11-25 Eli Zaretskii <eliz@gnu.org>
4097
4098 * xdisp.c (redisplay_window): If cursor row is not fully visible
4099 after recentering, and scroll-conservatively is set to a large
4100 number, scroll window by a few more lines to make the cursor fully
4101 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4102 (start_display): Don't move to the next line if the display should
4103 start at a newline that is part of a display vector or an overlay
4104 string. (Bug#10119)
8c535114 4105
fa4fdb5c
JL
41062011-11-24 Juri Linkov <juri@jurta.org>
4107
4108 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4109 after the `MagickPingImage' call. (Bug#10112)
4110
90ec88df
CY
41112011-11-23 Chong Yidong <cyd@gnu.org>
4112
4113 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4114
56e2e794
MR
41152011-11-23 Martin Rudalics <rudalics@gmx.at>
4116
4117 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4118 making another buffer current. (Bug#10114)
4119
b6e64c41
GM
41202011-11-23 Glenn Morris <rgm@gnu.org>
4121
4122 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4123
6b21de18
CY
41242011-11-23 Chong Yidong <cyd@gnu.org>
4125
4126 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4127 using it (Bug#5984).
4128
b12cd789
EZ
41292011-11-22 Eli Zaretskii <eliz@gnu.org>
4130
4131 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4132 and header-lines, as they don't have one computed for them.
4133 (Bug#10098)
4134
4135 * .gdbinit (prow): Make displayed values more self-explaining.
4136 Add row's hash code.
4137
261b6fd4
LMI
41382011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4139
4140 * process.c (wait_reading_process_output): Fix asynchrounous
4141 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4142 (wait_reading_process_output): Add comment and URL.
261b6fd4 4143
e7cfd277
JD
41442011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4145
4146 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4147
a9b9b7f5
CY
41482011-11-21 Chong Yidong <cyd@gnu.org>
4149
4150 * window.c (Fnext_window, Fprevious_window): Doc fix.
4151
b0d15b4f
SM
41522011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4153
4154 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4155
fe7a3057
JB
41562011-11-20 Juanma Barranquero <lekktu@gmail.com>
4157
4158 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4159
d2999b1a
MR
41602011-11-20 Martin Rudalics <rudalics@gmx.at>
4161
4162 * window.c (Fset_window_combination_limit): Rename argument
4163 STATUS to LIMIT.
4164 (Vwindow_combination_limit): Remove "status" from doc-string.
4165
d5ff9cd0
AS
41662011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4167
4168 * m/ibms390.h: Remove.
4169 * m/ibms390x.h: Don't include "ibms390.h".
4170
a5bb9bd3
SM
41712011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4172
4173 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4174 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4175
cd1181db
JB
41762011-11-20 Juanma Barranquero <lekktu@gmail.com>
4177
4178 * casetab.c (Fset_case_table):
4179 * charset.c (Fcharset_after): Fix typos.
4180
615a3b8d 41812011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4182
17e845af
PE
4183 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4184 Otherwise, valgrind does not work on some platforms.
4185 Problem reported by Andreas Schwab in
6a0bf43d
PE
4186 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4187 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4188 is set, removing the need for VIRT_ADDRESS_VARIES.
4189 (PURE_P): Use a more-efficient implementation that needs just one
4190 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4191 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4192 to 4 (xorl, subq, cmpq, setbe).
4193 * alloc.c (pure): Always extern now, since that's the
4194 VIRT_ADDR_VARIES behavior.
4195 (PURE_POINTER_P): Use a single comparison, not two, for
4196 consistency with the new puresize.h.
4197 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4198 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4199 Remove VIRT_ADDR_VARIES no longer needed.
4200
f8fe6f96
EZ
42012011-11-19 Eli Zaretskii <eliz@gnu.org>
4202
4203 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4204 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4205 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4206 behave as if the cursor position were at the window margin.
4207
4208 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4209 and the cursor position is out of bounds, behave as if the cursor
4210 position were at the window margin. (Bug#10075)
4211
df05a53c
CY
42122011-11-18 Chong Yidong <cyd@gnu.org>
4213
4214 * window.c (Fwindow_combination_limit): Make first argument
4215 non-optional, since it is meaningless for live windows like the
4216 selected window.
61ccba97 4217
2071918e
DA
42182011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4219
4220 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4221
b50a28de
SM
42222011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4223
4224 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4225 (graft_intervals_into_buffer): Simplify.
4226
015137db
EZ
42272011-11-18 Eli Zaretskii <eliz@gnu.org>
4228
4229 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4230 hash values of the two rows.
4231 (copy_row_except_pointers): Preserve the used[] arrays and the
4232 hash values of the two rows. (Bug#10035)
68c95424 4233 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4234
4235 * xdisp.c (row_hash): New function, body extracted from
4236 compute_line_metrics.
4237 (compute_line_metrics): Call row_hash, instead of computing the
4238 hash code inline.
4239
4240 * dispnew.c (verify_row_hash): Call row_hash for computing the
4241 hash code of a row, instead of duplicating code from xdisp.c.
4242
4243 * dispextern.h (row_hash): Add prototype.
4244
a2addb04
TH
42452011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4246
4247 * frame.c (delete_frame): Don't delete the terminal when the last
4248 X frame is closed if emacs is built with GTK toolkit.
4249
df85d315
JB
42502011-11-17 Juanma Barranquero <lekktu@gmail.com>
4251
4252 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4253
a0c2d0ae
MR
42542011-11-17 Martin Rudalics <rudalics@gmx.at>
4255
4256 * window.c (Vwindow_splits): Rename to
4257 Vwindow_combination_resize. Suggested by Juri Linkov.
4258 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4259 of Vwindow_splits.
4260
58179cce
JB
42612011-11-16 Juanma Barranquero <lekktu@gmail.com>
4262
7877f373
JB
4263 * nsfns.m (Fns_font_name):
4264 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4265
b6f67890
MR
42662011-11-16 Martin Rudalics <rudalics@gmx.at>
4267
4268 * window.h (window): Rename slot "nest" to "combination_limit".
4269 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4270 (Fset_window_nest): Rename to Fset_window_combination_limit.
4271 (Vwindow_nest): Rename to Vwindow_combination_limit.
4272 (recombine_windows, make_parent_window, make_window)
4273 (Fsplit_window_internal, saved_window)
4274 (Fset_window_configuration, save_window_save): Rename all
4275 occurrences of window_nest to window_combination_limit.
4276
c7015153
JB
42772011-11-15 Juanma Barranquero <lekktu@gmail.com>
4278
4279 * image.c (imagemagick_load_image): Fix typo.
4280
322ad6ec
EZ
42812011-11-14 Eli Zaretskii <eliz@gnu.org>
4282
4283 * xdisp.c (display_line): Move the call to
4284 highlight_trailing_whitespace before the call to
4285 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4286 faces of all the glyphs to compute ROW's hash value.
4287 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4288
f067b8ec
JB
42892011-11-14 Juanma Barranquero <lekktu@gmail.com>
4290
4291 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4292 just return (bug#10044).
4293
1e5b2111
EZ
42942011-11-12 Eli Zaretskii <eliz@gnu.org>
4295
7ef3cbd5
EZ
4296 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4297 with user-defined heap size. Bump the default size of the temacs
4298 heap to 27MB, to avoid memory warning when running temacs.
4299 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4300
1e5b2111
EZ
4301 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4302 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4303 (verify_row_hash) [XASSERTS]: New function.
4304 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4305 that the hash value of glyph rows is correct.
1e5b2111 4306
89d61221
MR
43072011-11-12 Martin Rudalics <rudalics@gmx.at>
4308
4309 * window.h (window): Remove splits slot.
4310 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4311 (Fdelete_other_windows_internal, make_parent_window)
4312 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4313 (Fset_window_configuration, save_window_save): Don't deal with
4314 split status of windows.
4315 (saved_window): Remove splits slot.
4316 (Vwindow_splits): Rewrite doc-string.
4317
97f18cc8
JD
43182011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4319
4320 * xfns.c (unwind_create_frame):
4321 * nsfns.m (unwind_create_frame):
4322 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4323 Vframe_list (Bug#9999).
4324
22a648b4
DA
43252011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4326
0b381c7e 4327 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 4328
659afede
KH
43292011-11-11 Kenichi Handa <handa@m17n.org>
4330
4331 * callproc.c (Fcall_process): Set the member dst_multibyte of
4332 process_coding.
4333
9ac0394b
KH
43342011-11-11 Johan Bockgård <bojohan@gnu.org>
4335
4336 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4337 avoid a crash (bug#9496).
4338
2fbdc249
CY
43392011-11-09 Chong Yidong <cyd@gnu.org>
4340
4341 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4342 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4343
ac6b1f81
PE
43442011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4345
4346 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4347
09db192c
PE
43482011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4349
4350 Avoid some portability problems by eschewing 'extern inline' functions.
4351 The trivial performance wins aren't worth the portability hassles; see
4352 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4353 et seq.
4354 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4355 (window_box_width, window_box_left, window_box_left_offset)
4356 (window_box_right, window_box_right_offset): Undo previous change,
4357 by removing the "extern"s.
4358 * intervals.c (adjust_intervals_for_insertion)
4359 (adjust_intervals_for_deletion): Undo previous change,
4360 making these static again.
4361 (offset_intervals, temp_set_point_both, temp_set_point)
4362 (copy_intervals_to_string): No longer inline.
4363 * xdisp.c (window_text_bottom_y, window_box_width)
4364 (window_box_height, window_box_left_offset)
4365 (window_box_right_offset, window_box_left, window_box_right)
4366 (window_box): No longer inline.
4367
105216ed
CY
43682011-11-08 Chong Yidong <cyd@gnu.org>
4369
4370 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
4371 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4372 Signal an error if not a live window.
105216ed
CY
4373 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4374 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4375
ae9e237f
JB
43762011-11-07 Juanma Barranquero <lekktu@gmail.com>
4377
4378 * lisp.h (syms_of_abbrev): Remove declaration.
4379 Reported by CHENG Gao <chenggao@royau.me>.
4380
c7aa8333
EZ
43812011-11-07 Eli Zaretskii <eliz@gnu.org>
4382
4383 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4384 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4385 of temacs in GUI mode.
4386
be7f5545
MR
43872011-11-07 Martin Rudalics <rudalics@gmx.at>
4388
4389 * window.h: Declare delete_all_child_windows instead of
4390 delete_all_subwindows.
4391 * window.c (Fwindow_nest, Fset_window_nest)
4392 (Fset_window_new_total, Fset_window_new_normal)
4393 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4394 (delete_all_subwindows): Rename to delete_all_child_windows.
4395 (Fdelete_other_windows_internal, Fset_window_configuration):
4396 Call delete_all_child_windows instead of delete_all_subwindows.
4397 * frame.c (delete_frame): Call delete_all_child_windows instead
4398 of delete_all_subwindows.
4399
ca78dc43
PE
44002011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4401
4402 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4403 This is also needed for porting to any host where GC_MARK_STACK is
4404 not GC_MAKE_GCPROS_NOOPS.
4405 (which_symbols): Use it.
4406
a0241d01
KH
44072011-11-07 Kenichi Handa <handa@m17n.org>
4408
4409 * coding.c (coding_set_destination): Check coding->src_pos only
4410 when coding->src_object is a buffer (bug#9910).
4411
4412 * process.c (send_process): Set the member src_multibyte of coding
4413 to 0 (bug#9911) when sending a unibyte text.
4414
4415 * callproc.c (Fcall_process): Set the member src_multibyte of
4416 process_coding to 0 (bug#9912).
4417
a64bfdfa 44182011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
4419
4420 * xmenu.c (cleanup_widget_value_tree): New function.
4421 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4422 calling free_menubar_widget_value_tree directly (Bug#9830).
4423
cb41b32a
PE
44242011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4425
4426 Fix some portability problems with 'inline'.
4427 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4428 (window_box_width, window_box_left, window_box_left_offset)
4429 (window_box_right, window_box_right_offset): Declare extern.
4430 Otherwise, these inline functions do not conform to C99 and
4431 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4432 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4433 * intervals.c (adjust_intervals_for_insertion)
4434 (adjust_intervals_for_deletion): Now extern, because otherwise the
4435 extern inline functions 'offset_intervals' couldn't refer to it.
4436 (static_offset_intervals): Remove.
4437 (offset_intervals): Rewrite using the old contents of
4438 static_offset_intervals. The old version didn't conform to C99
4439 because an extern inline function contained a reference to an
4440 identifier with static linkage.
4441
b7041366
AS
44422011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4443
4444 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4445 GC.
4446
88a37c4d
EZ
44472011-11-06 Eli Zaretskii <eliz@gnu.org>
4448
4449 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4450 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4451 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4452 return Qleft_to_right.
4453
49745b39
CY
44542011-11-06 Chong Yidong <cyd@gnu.org>
4455
4456 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4457 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4458 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4459 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4460 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4461 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4462 (Fwindow_vscroll): Doc fix.
4463 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4464 argument, since it makes no sense to pass a live window and for
4465 consistency with window-child.
4466
1f05cd82
CS
44672011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4468
4469 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4470 support MSVC.
4471
22610910
JR
44722011-11-05 Jason Rumney <jasonr@gnu.org>
4473
4474 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4475 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4476 fonts (Bug#6029).
4477 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4478 bitwise arithmetic preventing use of unicode-sip and non-truetype
4479 opentype fonts.
4480
a06776b2
EZ
44812011-11-05 Eli Zaretskii <eliz@gnu.org>
4482
3ad924ba
EZ
4483 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4484 "emacs"-only part.
4485
a06776b2
EZ
4486 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4487 initialization code to keep similarity to xfns.c after changes
4488 from 2011-11-05.
4489
c9e7db78
JD
44902011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4491
a97f8f3f
JD
4492 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4493 (unwind_create_frame): New function (Bug#9943).
4494 (Fx_create_frame): Restructure code to be more similar to the one in
4495 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4496 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4497 Move terminal->reference_count++ just before making the frame official
4498 (Bug#9943).
4499
4500 * nsterm.m (x_free_frame_resources): New function.
4501 (x_destroy_window): Move code to x_free_frame_resources.
4502
c9e7db78 4503 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4504 (Fx_create_frame, x_create_tip_frame):
4505 Move terminal->reference_count++ just before making the frame
75f1671a 4506 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4507 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4508
a6fc3b5c
EZ
45092011-11-05 Eli Zaretskii <eliz@gnu.org>
4510
4511 Support MSVC build with newer versions of Visual Studio.
4512 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4513 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4514 nt/gmake.defs.
4515
4516 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4517 which are not supported by MSVC.
4518 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4519 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4520 bitfields.
4521 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4522 types in bitfields.
4523 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4524
4525 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4526
58179cce 45272011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
4528
4529 Support MSVC build with newer versions of Visual Studio.
4530 * w32.c: Don't include w32api.h for MSVC.
4531 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4532
4533 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4534 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4535 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4536 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4537 e_* cousins.
4538 (alloca) [_MSC_VER]: Define to _alloca.
4539
4540 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4541
4542 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4543
a58c13ed
EZ
45442011-11-04 Eli Zaretskii <eliz@gnu.org>
4545
4546 * xdisp.c (note_mouse_highlight): If either of
4547 previous/next-single-property-change returns nil, treat that as
4548 the beginning or the end of the buffer. (Bug#9955)
4549
fe0b6370
JD
45502011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4551
a58c13ed 4552 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4553 label is not null (Bug#9951).
4554 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4555 may be NULL.
4556
89bd5ee1
EZ
45572011-11-04 Eli Zaretskii <eliz@gnu.org>
4558
4559 * window.c (Fwindow_body_size): Mention in the doc string that the
4560 return value is in frame's canonical units. (Bug#9949)
4561
84c3edb9
EZ
45622011-11-03 Eli Zaretskii <eliz@gnu.org>
4563
4e2fb5c7
EZ
4564 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4565
84c3edb9 4566 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4567 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4568 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4569
bc17a887
EZ
45702011-11-01 Eli Zaretskii <eliz@gnu.org>
4571
4572 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4573 Don't stop backward scan on the continuation glyph, even though
4574 its CHARPOS is positive.
6d5eb5b0
SM
4575 (mouse_face_from_buffer_pos, note_mouse_highlight):
4576 Rename cover_string to disp_string.
bc17a887 4577
4ee88440
MR
45782011-11-01 Martin Rudalics <rudalics@gmx.at>
4579
4580 * window.c (temp_output_buffer_show): Don't use
4581 Vtemp_buffer_show_specifiers.
4582 (Vtemp_buffer_show_specifiers): Remove unused variable.
4583
c2ff3c02
EZ
45842011-10-30 Eli Zaretskii <eliz@gnu.org>
4585
4586 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4587 past the beginning of the current glyph matrix.
4588
58179cce 45892011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4590
4591 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4592 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4593 HAVE_GTK3 (Bug#9869).
b77a6a7f 4594
3b574623
JD
4595 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4596 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4597
b77a6a7f
JD
4598 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4599
4600 * xterm.c: Declare x_handle_net_wm_state to return int.
4601 (handle_one_xevent): Check if we are iconified but don't have
4602 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4603 (get_current_wm_state): Return non-zero if not hidden,
4604 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4605 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4606 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4607 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4608
196e41e4
PE
46092011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4610
4611 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4612 so that this new function doesn't get optimized away by a
4613 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4614
021f2e1a
AS
46152011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4616
4617 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4618
8b058d44
EZ
46192011-10-29 Eli Zaretskii <eliz@gnu.org>
4620
4621 Fix the `xbytecode' command.
4622 * .gdbinit (xprintbytestr): New command.
b50a28de 4623 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4624 (xbytecode): Print the byte-code string as well.
4625
4452fb80
EZ
46262011-10-29 Kim Storm <storm@cua.dk>
4627
8b058d44
EZ
4628 * alloc.c (which_symbols): New function.
4629
21b72067
AS
46302011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4631
4632 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4633 line. (Bug#9903)
4634
83ed7b5c
GM
46352011-10-29 Glenn Morris <rgm@gnu.org>
4636
4637 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4638 Not clear what it was for, and it causes various bugs. (Bug#9839)
4639
5a7a728b
EZ
46402011-10-28 Eli Zaretskii <eliz@gnu.org>
4641
4642 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4643 possible random value that matches one of those tested as
4644 condition to clear the mouse face.
4645
d3d0842f
CY
46462011-10-28 Chong Yidong <cyd@gnu.org>
4647
4648 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4649
31b39d13
DN
46502011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4651
4652 * window.c (make_window): Initialize phys_cursor_on_p.
4653
9aba6043
SM
46542011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4655
4656 * lisp.h (struct Lisp_Symbol): Update comments.
4657
c20992f4
JB
46582011-10-28 Juanma Barranquero <lekktu@gmail.com>
4659
4660 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4661
db4f02f2
EZ
46622011-10-28 Eli Zaretskii <eliz@gnu.org>
4663
4664 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4665 <oslsachem@gmail.com> for helping to debug this.
4666
4667 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4668 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4669 (g_b_init_get_glyph_outline_w): New static variables.
4670 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4671 (GetGlyphOutlineW_Proc): New typedefs.
4672 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4673 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4674 New functions.
4675 (w32font_open_internal, compute_metrics):
4676 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4677 instead of calling the "wide" APIs directly.
4678
4679 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4680
4681 * w32.h (syms_of_w32font): Add prototype.
4682
87e68db4
JB
46832011-10-27 Juanma Barranquero <lekktu@gmail.com>
4684
4685 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4686 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4687 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4688 (Fmove_to_window_line): Doc fix.
4689
435c1d67
CY
46902011-10-27 Chong Yidong <cyd@gnu.org>
4691
4692 * process.c (make_process): Set gnutls_state to NULL.
4693
4694 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4695 non-NULL, regardless of GNUTLS_INITSTAGE.
4696 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4697 an error. Set process slots as soon as we allocate them.
4698
4699 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4700
9c6c6f49
CY
47012011-10-27 Chong Yidong <cyd@gnu.org>
4702
9aba6043
SM
4703 * gnutls.c (emacs_gnutls_deinit): New function.
4704 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
4705 (Fgnutls_deinit, Fgnutls_boot): Use it.
4706
4707 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4708 (deactivate_process): Call emacs_gnutls_deinit.
4709
657d08d3
JB
47102011-10-27 Juanma Barranquero <lekktu@gmail.com>
4711
4712 * image.c (x_create_x_image_and_pixmap):
4713 * w32.c (sys_rename, w32_delayed_load):
4714 * w32font.c (fill_in_logfont):
4715 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4716
5430d399
JB
47172011-10-26 Juanma Barranquero <lekktu@gmail.com>
4718
4719 * w32fns.c (w32_default_color_map): New function,
4720 extracted from Fw32_default_color_map.
a7ef684b 4721 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 4722
fe0055fa
PE
47232011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4724
4725 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4726
e6346438
SM
47272011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4728
4729 * keyboard.c (test_undefined): New function (bug#9751).
4730 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4731
e112cc37
ET
47322011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4733
4734 * sysdep.c (init_sys_modes): Fix the check for the controlling
4735 terminal (Bug#6649).
4736
7b5d6677
EZ
47372011-10-20 Eli Zaretskii <eliz@gnu.org>
4738
4739 * dispextern.h (struct bidi_it): New member next_en_type.
4740
4741 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4742 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4743 current character, check also for next_en_type being WEAK_EN.
4744 (bidi_resolve_weak): Don't enter the expensive loop if the current
4745 position is before next_en_pos. Record the bidi type of the first
4746 non-ET, non-BN character we find, in addition to its position.
4747 (bidi_level_of_next_char): Invalidate next_en_type when
4748 next_en_pos is over-stepped.
4749
7da0b018
PE
47502011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4751
4752 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4753 * editfns.c: Rewrite current-time-zone so that it invokes
4754 the equivalent of (format-time-string "%Z") to get the time zone name.
4755 This fixes a bug when the time zone name contains characters that
4756 need converting from the system time locale to Emacs internal format.
4757 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4758 that patch fixed format-time-string to do the conversion, but
4759 I forgot to fix current-time-zone.
4760 (format_time_string): New function, containing most of
4761 what Fformat_time_string used to contain.
4762 (Fformat_time_string): Rewrite in terms of format_time_string.
4763 This doesn't change this function's behavior.
4764 (current-time-zone): Rewrite to use format_time_string.
4765 This fixes the bug reported by Michael Schierl in
4766 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4767 Jason Rumney's 2007-06-07 change worked around this bug, but
4768 didn't fix it.
4769 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4770
8547b010
EZ
47712011-10-19 Eli Zaretskii <eliz@gnu.org>
4772
4773 * xdisp.c (start_display): If the character at POS is displayed
4774 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4775 (try_window_reusing_current_matrix): If a line ends in a display
4776 vector or the next line starts in a display vector, continue
4777 redrawing the window even though the character position of
4778 start_row was reached.
8547b010
EZ
4779 (Bug#9771, part 2)
4780
4e948d15
CY
47812011-10-18 Chong Yidong <cyd@gnu.org>
4782
4783 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4784 with nobreak-char-display too.
4785
4787455f
EZ
47862011-10-18 Eli Zaretskii <eliz@gnu.org>
4787
4788 Fix part 3 of bug#9771.
4789 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4790 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4791 non-neutral characters if the current character is a paragraph
4792 separator (a.k.a. Newline). This avoids running the same
4793 expensive loop twice, once when we consume the preceding newline
4794 and the other time when the line actually needs to be displayed.
4795 Avoid the loop when we see neutrals on the base embedding level
4796 following a character whose directionality is the same as the
4797 paragraph's. This avoids running the expensive loop when a line
4798 ends in a long sequence of neutrals, like control characters.
4799 Add assertion against STRONG_AL type. Slightly rearrange code
4800 that determines the type of a neutral given the first non-neutral
4801 that follows it.
4802 (bidi_level_of_next_char): Set next_en_pos to zero when
4803 invalidating its info.
4804
2c91f553
EZ
48052011-10-17 Eli Zaretskii <eliz@gnu.org>
4806
4807 * xdisp.c (push_display_prop): Determine whether to record string
4808 or buffer position by IT->string, not by IT->method. Allow
4809 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4810 (move_it_vertically_backward): Don't look for character position
4811 immediately after the newline when in a continuation line.
4812 (Bug#9771, part 1)
2c91f553 4813
c7b08b0d
MR
48142011-10-15 Martin Rudalics <rudalics@gmx.at>
4815
4816 * window.c (coordinates_in_window): Rewrite and delabelize
4817 vertical border check. (Bug#5357) (Bug#9618)
4818
6b02f655
SM
48192011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4820
4821 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4822 errors in XSetWindowBorder (bug#9310).
4823
81d40c92
DA
48242011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4825
4826 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4827 avoid crash when xmalloc overrun checking is enabled.
4828
d4172c3b
EZ
48292011-10-13 Eli Zaretskii <eliz@gnu.org>
4830
4831 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4832 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4833 cursor motion with <left> and <right> arrow keys.
4834
4835 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4836 some callers set that themselves.
4837
b00eea75
EZ
48382011-10-12 Eli Zaretskii <eliz@gnu.org>
4839
4840 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4841 display string and the previous row comes from the same string and
4842 is empty. (Bug#9739) (Bug#9738)
4843
8fe012c4
SM
48442011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4845
4846 * doc.c (get_doc_string): Encode file name (bug#9735).
4847
0074aef2
EZ
48482011-10-12 Eli Zaretskii <eliz@gnu.org>
4849
79beb178
EZ
4850 * bidi.c (bidi_level_of_next_char):
4851 * xdisp.c (get_visually_first_element): Remove old incorrect
4852 comments regarding the Unicode Line Separator character.
4853
0074aef2
EZ
4854 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4855
6e4b3fbe
DA
48562011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4857
4858 * alloc.c (Fgc_status): Do not access beyond zombies array
4859 boundary if nzombies > MAX_ZOMBIES.
4860 * alloc.c (dump_zombies): Add missing format specifier.
4861
0324f3af
PE
48622011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4863
b5525cac
PE
4864 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4865 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4866
0324f3af
PE
4867 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4868 Some packages use them to denote characters with modifiers.
4869
e9b5f888
AS
48702011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4871
4872 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4873 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4874 matching a pp-number. Rename parameter var to var1.
4875
127827c0
SM
48762011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4877
4878 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4879
c8fd3bd0
GM
48802011-10-08 Glenn Morris <rgm@gnu.org>
4881
4882 * callint.c (Fcall_interactively): Give a more explicit error for the
4883 'c' case with a non-character input. (Bug#8479)
4884
352ec8ff
EZ
48852011-10-08 Eli Zaretskii <eliz@gnu.org>
4886
03669ccb
EZ
4887 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4888 lines.
7061c986
EZ
4889 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4890 lines that are hscrolled on the left.
03669ccb 4891
352ec8ff
EZ
4892 * dispnew.c (buffer_posn_from_coords): Account for a possible
4893 presence of header-line. (Bug#4426)
4894
a66cfb1c
SM
48952011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4896
6b02f655
SM
4897 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4898 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4899
7c5ee88e
PE
49002011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4901
4902 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4903 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4904 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4905 this makes Emacs dump core during garbage collection on rare
4906 occasions. sizeof is obviously inferior to offsetof here, so
4907 stick with offsetof.
4908 (GC_POINTER_ALIGNMENT): New macro.
4909 (mark_memory): Omit 3rd (offset) arg; caller changed.
4910 Don't assume EMACS_INT alignment is the same as pointer alignment.
4911
df1bbe5b
SM
49122011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4913
4914 * keyboard.c (read_key_sequence_remapped): New var.
4915 (read_key_sequence): Compute remapping in the right buffer.
4916 (command_loop_1): Use read_key_sequence's remapping directly.
4917
51553db6
SM
49182011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4919
32c1fffd
SM
4920 * dired.c (file_name_completion): Don't expand file name.
4921 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4922 before checking file name handler.
4923
51553db6
SM
4924 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4925 they've been requested explicitly (bug#9591).
4926
b6bd1599 49272011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4928
4929 * keymap.c (Fsingle_key_description): Use make_specified_string
4930 instead of build_string to build string from push_key_description.
4931 (Bug#5193)
4932
f701dc2a
PE
49332011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4934
4222c55d
PE
4935 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4936 This fixes a Y2038 bug on 64-bit hosts.
4937 * buffer.c (reset_buffer):
4938 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4939 (Fclear_buffer_auto_save_failure):
4940 Use 0, not -1, to represent an unset failure time, since time_t
4941 might not be signed.
4942
f701dc2a
PE
4943 Remove dependency on glibc malloc internals.
4944 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4945 Move back here from lisp.h, but with their new implementations.
4946 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4947 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4948 * charset.c (charset_table_init): New static var.
4949 (syms_of_charset): Use it instead of xmalloc. This removes a
4950 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4951 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4952 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4953 Move back to alloc.c.
4954 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4955 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4956
9ceebf39
JD
49572011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4958
4959 * nsterm.m (windowDidResize): Call x_set_window_size only when
4960 ns_in_resize is true. Otherwise set pixelwidth/height and
4961 call change_frame_size (Bug#9628).
4962
cb993c58
PE
49632011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4964
3930c88b
PE
4965 Port --enable-checking=all to Fedora 14 x86-64.
4966 * charset.c (syms_of_charset): Also account for glibc malloc's
4967 internal overhead when calculating the initial malloc maximum.
4968
cb993c58
PE
4969 Port --enable-checking=all to Fedora 14 x86.
4970 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4971 Move to lisp.h.
4972 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4973 (overrun_check_realloc, overrun_check_free):
4974 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4975 That way, xmalloc returns a properly-aligned pointer even if
4976 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4977 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4978 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4979 into account when calculating the initial malloc maximum.
4980 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4981 Move here from alloc.c, so that charset.c can use it too.
4982 Properly align; the old code wasn't right for common 32-bit hosts
4983 when configured with --enable-checking=all.
4984 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4985 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4986
31bed486
EZ
49872011-09-29 Eli Zaretskii <eliz@gnu.org>
4988
04c70788 4989 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4990 use EDOM.
4991
fbcaa2f3
EZ
49922011-09-28 Eli Zaretskii <eliz@gnu.org>
4993
4994 * xdisp.c (compute_display_string_end): If there's no display
4995 string at CHARPOS, return -1.
4996
4997 * bidi.c (bidi_fetch_char): When compute_display_string_end
4998 returns a negative value, treat the character as a normal
4999 character not covered by a display string. (Bug#9624)
5000
a239d4e9
JB
50012011-09-28 Juanma Barranquero <lekktu@gmail.com>
5002
5003 * lread.c (Fread_from_string): Fix typo in docstring.
5004
88652fd5
EZ
50052011-09-27 Eli Zaretskii <eliz@gnu.org>
5006
5007 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5008 newline, reseat the iterator instead of bidi-iterating there one
5009 character at a time. (Bug#9610)
32c1fffd
SM
5010 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5011 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5012
ed497dd4
AS
50132011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5014
5015 * lread.c (readevalloop): Use correct code for NBSP.
5016 (read1): Likewise. (Bug#9608)
5017
b2bf61aa
MA
50182011-09-25 Michael Albinus <michael.albinus@gmx.de>
5019
5020 * dbusbind.c (Fdbus_register_signal): When service is not
5021 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5022
32bbb17c
GM
50232011-09-25 Glenn Morris <rgm@gnu.org>
5024
5025 * buffer.c (truncate-lines): Doc fix.
5026
94e0933e
CY
50272011-09-24 Chong Yidong <cyd@stupidchicken.com>
5028
5029 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5030 (Fset_window_next_buffers): Doc fix.
5031
cddde921
GM
50322011-09-24 Glenn Morris <rgm@gnu.org>
5033
5034 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5035
1260aef1
PE
50362011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5037
25b4bfa0
PE
5038 Fix minor problems found by static checking.
5039 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5040 * indent.c (Fvertical_motion): Fix == vs = typo.
5041
e3cbd34b
EZ
50422011-09-24 Eli Zaretskii <eliz@gnu.org>
5043
a66cfb1c
SM
5044 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5045 Default value is now t. Doc fix.
6bf7006f 5046
e3cbd34b 5047 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5048 logic when moving up, not only when moving down. Fix the
e3cbd34b 5049 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5050 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5051
5052 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5053 CHARPOS is covered by a display string which includes newlines.
5054 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5055 is covered by a display string with embedded newlines.
5056
a3de0cbd
MA
50572011-09-24 Michael Albinus <michael.albinus@gmx.de>
5058
5059 * dbusbind.c (Fdbus_register_signal): Add match rule to
5060 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5061 (Fdbus_register_method, Vdbus_registered_objects_table):
5062 Fix docstring.
a3de0cbd 5063
b260039d
JM
50642011-09-24 Jim Meyering <meyering@redhat.com>
5065
32c1fffd 5066 do not ignore write error for any output size
b260039d
JM
5067 The previous change was incomplete.
5068 While it makes emacs --batch detect the vast majority of stdout
5069 write failures, errors were still ignored whenever the output size is
5070 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5071 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5072 && echo FAIL: ignored write error
5073 FAIL: ignored write error
5074 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5075 && echo FAIL: ignored write error
5076 FAIL: ignored write error
5077 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5078
8eca8a7c
AS
50792011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5080
5081 * emacs.c (Fkill_emacs): In noninteractive mode exit
5082 non-successfully if a write error occurred on stdout. (Bug#9574)
5083
3341db62
EZ
50842011-09-21 Eli Zaretskii <eliz@gnu.org>
5085
5086 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5087 the xassert test.
5088
5089 * dispextern.h (struct it): Update the comment documenting what
5090 can it->OBJECT be.
5091
8c203dbf
EZ
50922011-09-20 Eli Zaretskii <eliz@gnu.org>
5093
5094 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5095 a display string, extend search for cursor position to end of row.
5096 (find_row_edges): If the row ends in a newline from a display
5097 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5098 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5099 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5100 non-empty line. Fixes confusing cursor motion with arrow keys at
5101 the beginning of a line that starts with whitespace.
8c203dbf 5102
a4824228
LMI
51032011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5104
5105 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5106 (bug#9493).
5107
33ed493b
CY
51082011-09-18 Chong Yidong <cyd@stupidchicken.com>
5109
5110 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5111 boolean (Bug#9154).
5112
56cd55c8
EZ
51132011-09-18 Eli Zaretskii <eliz@gnu.org>
5114
5115 * xdisp.c (display_line): Record maximum and minimum buffer
5116 positions even if no glyphs were produced (e.g., by a zero-width
5117 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5118 buffer positions that will be removed from the glyph row because
5119 they don't fit.
c02dcedf
EZ
5120 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5121 column is beyond frame width: don't subtract 1 "pixel" when
5122 computing width of the stretch.
3e62b7e0
EZ
5123 (reseat_at_next_visible_line_start): Undo the change made on
5124 2011-09-17 that saved paragraph information and restored it after
5125 the call to `reseat'. (Bug#9545)
56cd55c8 5126
5ed99d36 51272011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5128
5129 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5130 and turn window cursor on if cleared (Bug#9415).
5131
5ed99d36 51322011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5133
5134 * search.c (boyer_moore): Take unibyte characters from pattern
5135 literally. (Bug#9458)
5136
9bade7b2
EZ
51372011-09-18 Eli Zaretskii <eliz@gnu.org>
5138
5139 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5140
e5e9d610
PE
51412011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5142
87e4427a
PE
5143 Fix minor problem found by static checking.
5144 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5145 initialized, to pacify gcc -Wuninitialized.
5146
e5e9d610
PE
5147 * fileio.c: Report proper errno when syscall falls.
5148 (Finsert_file_contents): Save and restore errno,
5149 so that report_file_error outputs the correct diagnostic.
5150 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5151
a1674f0b
EZ
51522011-09-18 Eli Zaretskii <eliz@gnu.org>
5153
5154 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5155
fbfb6dd4
EZ
51562011-09-17 Eli Zaretskii <eliz@gnu.org>
5157
5158 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5159 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5160
bb187662
EZ
51612011-09-17 Eli Zaretskii <eliz@gnu.org>
5162
1137e8b8 5163 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5164 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5165
5166 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5167 (bidi_find_paragraph_start): Search back for paragraph beginning
5168 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5169 (bidi_move_to_visually_next): Only trigger paragraph-related
5170 computations when the last character is a newline or at EOB, not
5171 just any NEUTRAL_B. (Bug#9470)
5172
bb187662
EZ
5173 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5174 truncated lines if point is covered by a display string. (Bug#9524)
5175
2e621251
PE
51762011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5177
5178 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5179 (cons_to_x_long): New function.
5180 (lisp_data_to_selection_data): Use it. Correct the test for
5181 short-versus-long data; it was negated. Break out of vector
5182 loop, for efficiency, when a long datum is discovered.
5183
91a15bc6
SM
51842011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5185
5186 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5187
b41c3a35
EZ
51882011-09-16 Eli Zaretskii <eliz@gnu.org>
5189
5190 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5191 GCC PR/17406) by declaring this function with external scope.
5192
7812ba2d
PE
51932011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5194
5195 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5196 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5197
cf7edc2a
AS
51982011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5199
5200 * editfns.c (Fformat): Correctly handle text properties on "%%".
5201
bd01620e
EZ
52022011-09-15 Eli Zaretskii <eliz@gnu.org>
5203
5204 * xterm.c (x_draw_composite_glyph_string_foreground):
5205 * w32term.c (x_draw_composite_glyph_string_foreground):
5206 * term.c (encode_terminal_code):
5207 * composite.c (composition_update_it, get_composition_id):
5208 * xdisp.c (get_next_display_element)
5209 (fill_composite_glyph_string): Add comments about special meaning
5210 of TAB characters in a composition.
5211
a02719a3
PE
52122011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5213
5214 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5215 This occurs when processing a multibyte format.
5216 Problem reported by Wolfgang Jenker.
a02719a3 5217
72589a3c
JB
52182011-09-15 Johan Bockgård <bojohan@gnu.org>
5219
5220 * xdisp.c (try_cursor_movement): Only check for exact match if
5221 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5222
1c14176c
PE
52232011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5224
5225 Remove unused external symbols.
5226 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5227 * xdisp.c (calc_pixel_width_or_height): Now static.
5228 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5229 * indent.c (check_display_width):
5230 * w32term.c: Fix comment to match code.
5231 * xterm.c, xterm.h (x_catching_errors): Remove.
5232
d2eea5b5
PE
52332011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5234
5235 * xselect.c: Use signed conversions more consistently (Bug#9498).
5236 (selection_data_to_lisp_data): Assume incoming selection data are
5237 signed integers, not unsigned. This is to be consistent with
5238 outgoing selection data, which was modified to use signed integers
5239 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5240 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5241 expects long, not unsigned long.
5242
46888499
EZ
52432011-09-14 Eli Zaretskii <eliz@gnu.org>
5244
5245 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5246 computation of loop end. Reported by Johan Bockgård
5247 <bojohan@gnu.org>.
5248
ef8ef9fb
CY
52492011-09-13 Chong Yidong <cyd@stupidchicken.com>
5250
5251 * frame.c (Fother_visible_frames_p): Function deleted.
5252
fa819fed
EZ
52532011-09-12 Eli Zaretskii <eliz@gnu.org>
5254
5255 * indent.c (compute_motion): Process display vector front to back
5256 rather than the other way around. (Bug#2496)
5257
2ba8e008
SM
52582011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5259
5260 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5261
20f53c69
CY
52622011-09-11 Chong Yidong <cyd@stupidchicken.com>
5263
5264 * minibuf.c (Fread_from_minibuffer): Doc fix.
5265
d562d7a4
EZ
52662011-09-11 Eli Zaretskii <eliz@gnu.org>
5267
5268 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5269 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5270
1c4d7f3d
LMI
52712011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5272
5273 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5274 value for non-existent files.
5275
b885bf36
EZ
52762011-09-11 Eli Zaretskii <eliz@gnu.org>
5277
5278 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5279 set its "size" to -1. This will set the modtime_size field of
5280 the corresponding buffer to -1, which is what
5281 verify-visited-file-modtime expects for files that do not exist.
5282 (Bug#9139)
5283
6612f0bf
PE
52842011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5285
5286 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5287 here ...
5288 * lisp.h: ... from here. push_key_description is no longer
5289 defined in keyboard.c, so its declaration should not be in
5290 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5291 logically belongs with push_key_description.
5292
dfb3f755
PE
52932011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5294
5295 * buffer.h: Include <sys/types.h> instead of <time.h>.
5296 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5297 Problem reported by Herbert J. Skuhra.
5298
3134906c
LMI
52992011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5300
5301 * xml.c (parse_region): Make the parsing work for
5302 non-comment-starting XML files again (bug#9144).
5303
8d903f4e
AS
53042011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5305
5306 * image.c (gif_load): Fix calculation of bottom and right corner.
5307 (Bug#9468)
5308
80ad64f4
EZ
53092011-09-10 Eli Zaretskii <eliz@gnu.org>
5310
5311 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5312 redisplay in small windows.
5313
208a048d
EZ
53142011-09-09 Eli Zaretskii <eliz@gnu.org>
5315
5316 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5317
9b1c252e
MR
53182011-09-08 Martin Rudalics <rudalics@gmx.at>
5319
5320 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5321 Operate on live windows only.
5322
2949f33b
JB
53232011-09-08 Juanma Barranquero <lekktu@gmail.com>
5324
5325 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5326
e08dcafd
EZ
53272011-09-07 Eli Zaretskii <eliz@gnu.org>
5328
5329 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5330 only under bidi iteration.
5331
115b96bd
JD
53322011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5333
5334 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5335
c8199d0f
PE
53362011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5337
5338 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5339 Without this fix, the command to link temacs failed due to an
5340 undefined symbol __builtin_isnan. This is because
5341 /usr/include/iso/math_c99.h #defines isnan(x) to
5342 __builtin_isnan(x), but the bundled gcc, which identifies itself
5343 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5344 a __builtin_isnan.
5345 * floatfns.c (isnan): #undef, and then #define to a clone of
5346 what's in data.c.
5347 (Fisnan): Always define, since it's always available now.
5348 (syms_of_floatfns): Always define isnan at the Lisp level.
5349
e39b275c 53502011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
5351
5352 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5353
b2db44d9 53542011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 5355
f4af5137 5356 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
5357 The previous code assumed that file offsets (off_t values) fit in
5358 EMACS_INT variables, which is not true on typical 32-bit hosts.
5359 The code messed up by falsely reporting buffer overflow in cases
5360 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5361 when "big" contains more than 2**29 bytes, even though this
5362 inserts just one byte and does not overflow the buffer.
5363 (Finsert_file_contents): Store file offsets as off_t
5364 values, not as EMACS_INT values. Check for overflow when
5365 converting between EMACS_INT and off_t. When checking for
5366 buffer overflow or for overlap, take the offsets into account.
5367 Don't use EMACS_INT for small values where int suffices.
5368 When checking for overlap, fix a typo: ZV was used where
5369 ZV_BYTE was intended.
5370 (Fwrite_region): Don't assume off_t fits into 'long'.
5371 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5372
ecfc0a49
MA
53732011-09-05 Michael Albinus <michael.albinus@gmx.de>
5374
5375 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5376
6511acf2 53772011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 5378
0999621a 5379 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
5380
5381 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 5382 (esprintf, exprintf, evxprintf): New functions.
62f19c19 5383 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 5384 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
5385 (modify_event_symbol): Do not assume that the length of
5386 name_alist_or_stem is safe to alloca and fits in int.
5387 (Fexecute_extended_command): Likewise for function name and binding.
5388 (Frecursion_depth): Wrap around reliably on integer overflow.
5389 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5390 since some callers pass EMACS_INT values.
5391 (Fsingle_key_description): Don't crash if symbol name contains more
5392 than MAX_ALLOCA bytes.
5393 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5394 (get_minibuffer): Arg is now EMACS_INT, not int.
5395 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 5396 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
5397 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5398
2be7d702
PE
5399 * dbusbind.c (signature_cat): New function.
5400 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
5401 Do not overrun buffer; instead, report string overflow.
5402
9d1df220
PE
5403 * dispnew.c (add_window_display_history): Don't overrun buffer.
5404 Truncate instead; this is OK since it's just a log.
5405
33ef5c64
PE
5406 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5407 even if the time zone offset is outlandishly large.
5408 Don't mishandle offset == INT_MIN.
5409
66c6fdd5
PE
5410 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5411 when creating daemon; the previous buffer-overflow check was incorrect.
5412
d749b01b
PE
5413 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5414 which has the guts of the old verror function.
5415
b5cd1905
PE
5416 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5417 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5418
6e1a67fb
PE
5419 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5420 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 5421 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 5422 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
5423 length of string rather than counting it via multiple sprintfs;
5424 that's simpler and more reliable.
c21721cc
PE
5425 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5426 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5427 sprintf, in case result does not fit in int.
5428
c57b67fc
PE
5429 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5430 (fontset_from_font): Print it.
5431
8a401434
PE
5432 * frame.c (tty_frame_count): Now printmax_t, not int.
5433 (make_terminal_frame, set_term_frame_name): Print it.
5434 (x_report_frame_params): In X, window IDs are unsigned long,
5435 not signed long, so print them as unsigned.
5436 (validate_x_resource_name): Check for implausibly long names,
5437 and don't assume name length fits in 'int'.
5438 (x_get_resource_string): Don't blindly alloca invocation name;
5439 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5440 not fit in int.
5441
6e1a67fb
PE
5442 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5443 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5444 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5445
0df02bf3
PE
5446 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5447 Use esprintf, not sprintf, in case result does not fit in int.
5448
48e30793
PE
5449 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5450 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5451 it as a large positive number.
5452 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5453 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5454
a66ff6d8
PE
5455 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5456 in case result does not fit in int.
5457
aca216ff
PE
5458 * print.c (float_to_string): Detect width overflow more reliably.
5459 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5460 buffer overrun. Don't assume list length fits in 'int'. Treat
5461 print length of 0 as 0, not as infinity; to be consistent with other
5462 uses of print length in this function. Don't overflow print length
5463 index. Don't assume hash table size fits in 'long', or that
5464 vectorlike size fits in 'unsigned long'.
5465
31c286f7
PE
5466 * process.c (make_process): Use printmax_t, not int, to format
5467 process-name gensyms.
5468
55e5faa1
PE
5469 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5470
80f2e268
PE
5471 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5472 to avoid potential buffer overrun.
5473
670741ab
PE
5474 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5475 if X resource line is longer than 512 bytes.
5476
b7163a50
PE
5477 * xfns.c (x_window): Make sprintf buffer a bit bigger
5478 to avoid potential buffer overrun.
5479
ae58ff1f
PE
5480 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5481
c43c8a6a
PE
5482 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5483
3f8236f4
PE
54842011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5485
53e9fe90 5486 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5487 Without these, Emacs silently mishandles large integers sometimes.
5488 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5489 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5490
6511acf2
PE
5491 * xdisp.c (try_window_id): Check Emacs fixnum range before
5492 converting to 'int'.
806add1d 5493
6511acf2 5494 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5495 Check that an Emacs fixnum is in range before assigning it to 'int'.
5496 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5497 values converted from Emacs fixnums.
5498 (Frecenter): Don't wrap around a line count if it is out of 'int'
5499 range; instead, treat it as an extreme value.
5500 (Fset_window_configuration, compare_window_configurations):
5501 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5502
6511acf2
PE
5503 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5504 that can exceed INT_MAX. Check that EMACS_INT value is in range
5505 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5506 (match_limit): Don't assume that a fixnum can fit in 'int'.
5507
6511acf2 5508 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5509 exceed INT_MAX.
5510
6511acf2 5511 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
5512 (Fvertical_motion): Don't wrap around LINES values that don't fit
5513 in 'int'. Instead, treat them as extreme values. This is good
5514 enough for windows, which can't have more than INT_MAX lines anyway.
5515
fcb901a7
LMI
55162011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5517
0f2f6b6d
LMI
5518 * Require libxml/parser.h to avoid compilation warning.
5519
fcb901a7
LMI
5520 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5521
5522 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5523 since this reportedly can destroy thread storage.
5524
6e20a0d4
CY
55252011-08-30 Chong Yidong <cyd@stupidchicken.com>
5526
5527 * syntax.c (find_defun_start): Update all cache variables if
5528 exiting early (Bug#9401).
5529
148ae00e
EZ
55302011-08-30 Eli Zaretskii <eliz@gnu.org>
5531
f6cfbd8f
EZ
5532 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5533
148ae00e
EZ
5534 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5535 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5536 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5537
5538 * term.c (tty_append_glyph): New function.
5539 (produce_stretch_glyph): Static function and its prototype deleted.
5540
a66cfb1c
SM
5541 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5542 Add prototypes.
148ae00e 5543
c4a07a4c
PE
55442011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5545
5546 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5547 when checking :margin (Bug#9390).
5548 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5549 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5550 so that the name doesn't mislead. All uses changed.
5551
6bc8cd65
JB
55522011-08-28 Johan Bockgård <bojohan@gnu.org>
5553
5554 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5555 set_tty_hooks.
5556
dca4927e
EZ
55572011-08-27 Eli Zaretskii <eliz@gnu.org>
5558
5559 * xdisp.c (move_it_to): Don't bail out early when reaching
5560 position beyond to_charpos, if we are scanning backwards.
5561 (move_it_vertically_backward): When DY == 0, make sure we get to
5562 the first character in the line after the newline.
5563
f2cad773
PE
55642011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5565
5566 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5567 (ccl_driver): Do not generate an out-of-range pointer.
5568 (Fccl_execute_on_string): Remove unnecessary check for
5569 integer overflow, noted by Stefan Monnier in
5570 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5571 Remove a FIXME that didn't need fixing.
5572 Simplify the newly-introduced buffer reallocation code.
5573
0cae2cdb
JB
55742011-08-27 Juanma Barranquero <lekktu@gmail.com>
5575
5576 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5577
5fc295a4 55782011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5579
70c60eb2 5580 Integer and memory overflow issues (Bug#9196).
726e0ab1 5581
d31850da
PE
5582 * doc.c (get_doc_string): Rework so that
5583 get_doc_string_buffer_size is the actual buffer size, rather than
5584 being 1 less than the actual buffer size; this makes xpalloc more
5585 convenient.
5586
a69fbedb
PE
5587 * image.c (x_allocate_bitmap_record, cache_image):
5588 * xselect.c (Fx_register_dnd_atom):
5589 Simplify previous changes by using xpalloc.
5590
fe5c5d37
PE
5591 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5592 since either will do and ptrdiff_t is convenient with xpalloc.
5593
0065d054
PE
5594 * charset.c (charset_table_size)
5595 (struct charset_sort_data.priority): Now ptrdiff_t.
5596 (charset_compare): Don't overflow if priorities differ greatly.
5597 (Fsort_charsets): Don't assume list length fits in int.
5598 Check for size-calculation overflow when allocating sort data.
5599 (syms_of_charset): Allocate an initial charset table that is
5600 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5601
5602 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5603
5604 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5605 The actual value is always <= INT_MAX, and leaving it unsigned made
5606 overflow checking harder.
5607
5608 * dispextern.h (struct glyph_matrix.rows_allocated)
5609 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5610 with xpalloc. The values are still always <= INT_MAX.
5611
5612 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5613
5614 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5615 (SAFE_NALLOCA): New macro.
5616
5617 * region-cache.c (struct boundary.pos, find_cache_boundary)
5618 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5619 (set_cache_region, invalidate_region_cache)
5620 (revalidate_region_cache, know_region_cache, region_cache_forward)
5621 (region_cache_backward, pp_cache):
5622 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5623 so that ptrdiff_t * can be passed to xpalloc.
5624 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5625 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5626 (pp_cache): Don't assume cache_len fits in int.
5627 * region-cache.h: Adjust extern decls to match.
5628
5629 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5630 EMACS_INT, since either will do, for xpalloc.
5631
5632 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5633 (xnmalloc, xnrealloc, xpalloc): New functions.
5634
726e0ab1
PE
5635 * bidi.c (bidi_shelve_header_size): New constant.
5636 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5637 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5638
51f30bc5 5639 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5640 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5641 (overlay_strings):
5642 Don't update size of array until after memory allocation succeeds,
5643 because xmalloc/xrealloc may not return.
0065d054
PE
5644 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5645 now that we have proper integer overflow checking.
5646 (record_overlay_string, overlay_strings): Catch overflows when
5647 calculating size of overlay_str_buf.
726e0ab1 5648
0065d054
PE
5649 * callproc.c (Fcall_process): Check for size overflow when
5650 calculating size of args2.
5651 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5652 Normally we prefer signed values, but sticking with ptrdiff_t would
5653 require adding more-complicated checks.
726e0ab1
PE
5654
5655 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5656 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5657 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5658 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5659
5660 * character.c (Fstring): Check for size-calculation overflow.
5661
5662 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5663 unnecessary integer overflow. Check for size overflow.
5664 (encode_coding_object): Don't update size until xmalloc succeeds.
5665
5666 * composite.c (get_composition_id): Check for overflow in glyph
5667 length calculations.
5668
5669 Integer and memory overflow fixes for display code.
5670 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5671 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5672 (scrolling_window): Check for overflow in size calculations.
5673 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5674 Don't assume glyph table len fits in int.
5675 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5676 (row_table_size): Now ptrdiff_t, not int.
5677 (scrolling_window): Avoid overflow in size calculations.
5678 Don't update size until allocation succeeds.
5679 * fns.c (concat): Check for overflow in size calculations.
5680 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5681 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5682 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5683
5684 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5685 (get_doc_string): Check for size calculation overflow.
5686 Don't update size until allocation succeeds.
5687 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5688 EMACS_INT, where ptrdiff_t will do.
5689 (Fsubstitute_command_keys): Check for string overflow.
5690
5691 * editfns.c (set_time_zone_rule): Don't assume environment length
5692 fits in int.
5693 (message_length): Now ptrdiff_t, not int.
5694 (Fmessage_box): Don't update size until allocation succeeds.
5695 Don't assume message length fits in int.
5696 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5697
0065d054
PE
5698 * emacs.c (main): Do not reallocate argv, since there is a null at
5699 the end that can be overwritten, and this way there's no need to
5700 worry about size-calculation overflow.
5701 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
5702
5703 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5704 alloc succeeds.
5705 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5706
5707 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5708 (x_set_scroll_bar_width, x_figure_window_size):
5709 Check for integer overflow.
5710 (x_set_alpha): Do not assume XINT fits in int.
5711
5712 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5713 This is for the members text_lines, text_cols, total_lines, total_cols,
5714 where the system imposes an 'int' limit.
5715
5716 * fringe.c (Fdefine_fringe_bitmap):
5717 Don't update size until alloc works.
5718
5719 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5720 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5721
5722 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5723 Check for size-calculation overflow.
5724 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5725 do, as we prefer signed integers.
5726 (id_to_widget.max_size, id_to_widget.used)
5727 (xg_store_widget_in_map, xg_remove_widget_from_map)
5728 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5729 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5730 Use and return ptrdiff_t, not int.
5731 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5732 * gtkutil.h: Change prototypes to match the above.
5733
5734 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5735 are duplicate now that they've been promoted to lisp.h.
5736 (x_allocate_bitmap_record, x_alloc_image_color)
5737 (make_image_cache, cache_image, xpm_load):
5738 Don't update size until alloc is done.
5739 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5740 (x_detect_edges):
3256efce 5741 Check for size calculation overflow.
726e0ab1
PE
5742 (ct_colors_allocated_max): New constant.
5743 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5744 overflow.
3256efce 5745
726e0ab1
PE
5746 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5747 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5748 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5749 Use ptrdiff_t, not int, to count maps.
5750 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
5751 calculations. Don't update size until allocation succeeds.
5752 Redo calculations to avoid overflow.
726e0ab1
PE
5753 * keyboard.h: Change prototypes to match the above.
5754
5755 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5756 to count maps.
5757 (current_minor_maps): Check for size calculation overflow.
5758 * keymap.h: Change prototypes to match the above.
5759
5760 * lread.c (read1, init_obarray): Don't update size until alloc done.
5761
5762 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5763 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5764
726e0ab1
PE
5765 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5766 Now ptrdiff_t, not int.
5767 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5768 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5769
5770 * process.c (Fnetwork_interface_list): Check for overflow
5771 in size calculation.
5772
5773 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5774
5775 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5776 overflow. Don't bother calling xmalloc when xrealloc will do.
5777
5778 * search.c (Freplace_match): Check for size calculation overflow.
5779 (Fset_match_data): Don't assume list lengths fit in 'int'.
5780
5781 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5782 for command line length. Do not attempt to address one before the
5783 beginning of an array, as that's not portable.
5784
5785 * term.c (max_frame_lines): Remove; unused.
5786 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5787 not int.
5788 (encode_terminal_code, calculate_costs): Check for size
5789 calculation overflow.
5790 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5791 table lengths and related sizes. Don't update size until alloc
5792 done. Redo calculations to avoid overflow.
5793 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5794
5795 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5796 subtracting pointers.
5797 (gobble_line): Check for overflow more carefully. Don't update size
5798 until alloc done.
5799
5800 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5801 Don't update size until alloc done.
5802 Redo size calculations to avoid overflow.
5803 Check for size calculation overflow.
0065d054 5804 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5805
5806 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5807 Use ptrdiff_t, not int, for sizes.
5808 (store_mode_line_noprop_char): Don't update size until alloc done.
5809
0065d054
PE
5810 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5811 Use ptrdiff_t, not int, for sizes.
5812 (Finternal_make_lisp_face, cache_face):
5813 Check for size calculation overflow.
5814 (cache_face): Treat size calculation overflows as if they were
5815 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5816
5817 * xfns.c (x_encode_text, x_set_name_internal)
5818 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5819 sizes, since they can exceed INT_MAX in size. Check for size
5820 calculation overflow.
5821
0065d054
PE
5822 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5823 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5824 Don't update size until alloc done.
5825
0065d054 5826 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5827 as sprintf is limited to int lengths.
1d526e2f 5828
252c5ee1
PE
5829 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5830 (X_LONG_MIN): New macros.
864d7ce7
PE
5831 Use them to make the following changes clearer.
5832 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5833 This change doesn't affect the value now, but it may help remind
5834 future maintainers not to raise the value too much later.
5835 (SELECTION_QUANTUM): Remove, replacing with ...
5836 (selection_quantum): ... new function, which avoids overflow.
5837 All uses changed.
5838 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5839 assumption that selection length fits in 'int'.
5840 (x_reply_selection_request, x_handle_selection_request)
5841 (x_get_window_property, receive_incremental_selection)
5842 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5843 (lisp_data_to_selection_data, clean_local_selection_data):
5844 Use ptrdiff_t, not int, to record length of selection.
5845 (x_reply_selection_request, x_get_window_property)
5846 (receive_incremental_selection, x_property_data_to_lisp):
5847 Redo calculations to avoid overflow.
5848 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5849 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5850 something.
5851 (x_get_window_property, receive_incremental_selection)
5852 (lisp_data_to_selection_data, x_property_data_to_lisp):
5853 Check for size-calculation overflow.
5854 (x_get_window_property, receive_incremental_selection)
5855 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5856 Don't store size until memory allocation succeeds.
5857 (x_get_window_property): Plug memory leak on memory exhaustion.
5858 Don't double-block input; malloc is safe here. Don't assume 2**34
5859 - 4 fits in unsigned long. Add an xassert to check
5860 XGetWindowProperty overflow. Be more careful about overflow
5861 calculations, and distinguish size from memory overflow better.
5862 (receive_incremental_selection): When tracing, don't assume
5863 unsigned int is less than INT_MAX.
5864 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5865 harmful) conversions of unsigned short to int.
5866 (lisp_data_to_selection_data): Don't assume that integers
5867 in the range -65535 through -1 fit in an X unsigned short.
5868 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5869 result parameters unless successful. Rely on cons_to_unsigned
5870 to report problems with elements; the old code wasn't right anyway.
5871 (x_check_property_data): Check for int overflow; we cannot use
5872 a wider type due to X limits.
5873 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5874
726e0ab1 5875 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5876
0065d054
PE
5877 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5878 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5879 (x_color_cells): Don't store size until memory allocation succeeds.
5880 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5881 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5882 (x_term_init): Don't assume length fits in int (sprintf is limited
5883 to int size).
bc18e09d 5884
ebfa62c0
PE
5885 Use ptrdiff_t for composition IDs.
5886 * character.c (lisp_string_width):
5887 * composite.c (composition_table_size, n_compositions)
5888 (get_composition_id, composition_gstring_from_id):
5889 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5890 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5891 * window.c (Frecenter):
5892 Use ptrdiff_t, not int, for composition IDs.
5893 * composite.c (get_composition_id): Check for integer overflow.
5894 * composite.h: Adjust prototypes to match the above changes.
5895
d3411f89
PE
5896 Use ptrdiff_t for hash table indexes.
5897 * category.c (hash_get_category_set):
5898 * ccl.c (ccl_driver):
5899 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5900 * coding.c (coding_system_charset_list, detect_coding_system):
5901 * coding.h (struct coding_system.id):
5902 * composite.c (get_composition_id, gstring_lookup_cache):
5903 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5904 * image.c (xpm_get_color_table_h):
5905 * lisp.h (hash_lookup, hash_put):
5906 * minibuf.c (Ftest_completion):
5907 Use ptrdiff_t for hash table indexes, not int (which is too
5908 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5909 32-bit --with-wide-int hosts).
5910
e097a6fa
PE
5911 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5912 Add a FIXME comment about memory leaks.
5913 (syms_of_charset): Don't assume xmalloc returns.
5914
5637687f
PE
5915 Don't assume that stated character widths fit in int.
5916 * character.c (Fchar_width, c_string_width, lisp_string_width):
5917 * character.h (CHAR_WIDTH):
5918 * indent.c (MULTIBYTE_BYTES_WIDTH):
5919 Use sanitize_char_width to avoid undefined and/or bad behavior
5920 with outlandish widths.
a66cfb1c 5921 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5922 now that we have two such functions. All uses changed.
5923 (sanitize_char_width): New inline function.
5924
a2271ba2
PE
5925 Don't assume that tab-width fits in int.
5926 * character.h (sanitize_width): New inline function.
5927 (SANE_TAB_WIDTH): New macro.
5928 (ASCII_CHAR_WIDTH): Use it.
5929 * indent.c (sane_tab_width): Remove. All uses replaced by
5930 SANE_TAB_WIDTH (current_buffer).
5931 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5932
18c52557
PE
5933 * fileio.c: Integer overflow issues with file modes.
5934 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5935
caeeedc1
PE
5936 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5937 Remove unreachable code.
5938 (read_hex, load_charset_map_from_file): Check for integer overflow.
5939
6df6ae42 5940 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5941 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5942 (x_send_scroll_bar_event): Likewise. Check that the size does not
5943 exceed limits imposed by XClientMessageEvent, as well as the usual
5944 ptrdiff_t and size_t limits.
5945
b13995db
PE
5946 * keyboard.c: Overflow, signedness and related fixes.
5947 (make_lispy_movement): Use same integer type in forward decl
5948 that is used in the definition.
5949 (read_key_sequence, keyremap_step):
5950 Change bufsize argument back to int, undoing my 2011-03-30 change.
5951 We prefer signed types, and int is wide enough here.
5952 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5953 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5954 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5955 length, not size_t. Use ptrdiff_t for index, not int.
5956 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5957 possibility of integer overflow.
5958
13464394
PE
5959 Overflow, signedness and related fixes for images.
5960
5961 * dispextern.h (struct it.stack[0].u.image.image_id)
5962 (struct_it.image_id, struct image.id, struct image_cache.size)
5963 (struct image_cache.used, struct image_cache.ref_count):
5964 * gtkutil.c (update_frame_tool_bar):
5965 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5966 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5967 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5968 * nsmenu.m (update_frame_tool_bar):
5969 * xdisp.c (calc_pixel_width_or_height):
5970 * xfns.c (image_cache_refcount):
5971 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5972 on typical 64-bit hosts.
5973
5974 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5975 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5976 Omit unnecessary casts to int.
5977 (parse_image_spec): Check that integers fall into 'int' range
5978 when the callers expect that.
5979 (image_ascent): Redo ascent calculation to avoid int overflow.
5980 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5981 (lookup_image): Remove unnecessary tests.
5982 (xbm_image_p): Locals are now of int, not EMACS_INT,
5983 since parse_image_check makes sure they fit into int.
5984 (png_load, gif_load, svg_load_image):
5985 Prefer int to unsigned where either will do.
5986 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5987 old tiff_error_handler and tiff_warning_handler.
5988 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5989 stack buffer overflows. It uses only the features of vsnprintf
5990 that are common to both POSIX and native Microsoft.
5991 (tiff_error_handler, tiff_warning_handler): Use it.
5992 (tiff_load, gif_load, imagemagick_load_image):
5993 Don't assume :index value fits in 'int'.
5994 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5995 (imagemagick_load_image): Check that crop parameters fit into
5996 the integer types that MagickCropImage accepts. Don't assume
5997 Vimagemagick_render_type has a nonnegative value. Don't assume
5998 size_t fits in 'long'.
5999 (gs_load): Use printmax_t to print the widest integers possible.
6000 Check for integer overflow when computing image height and width.
6001
c11821d4
EZ
60022011-08-26 Eli Zaretskii <eliz@gnu.org>
6003
6004 * xdisp.c (redisplay_window): Don't force window start if point
6005 will be invisible in the resulting window. (Bug#9324)
6006
0c95fcf7
EZ
60072011-08-25 Eli Zaretskii <eliz@gnu.org>
6008
6009 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6010 the display spec is of the form `(space ...)'.
6011 (handle_display_spec): Return the value returned by
6012 handle_single_display_spec, not just 1 or zero.
6013 (handle_single_display_spec): If the display spec is of the form
6014 `(space ...)', and specifies display in the text area, return 2
6015 rather than 1.
fee65a97 6016 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6017 accurately, and prefer exact match for point under bidi.
6018 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6019
6020 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6021 into disp_prop; all users changed.
6022
6023 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6024 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6025 for the text covered by the display property.
6026
e4ed06f1
CY
60272011-08-25 Chong Yidong <cyd@stupidchicken.com>
6028
6029 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6030 Change return value to nil.
6031 (Frecord_buffer): Delete unused function.
6032
f67cdd7f
EZ
60332011-08-24 Eli Zaretskii <eliz@gnu.org>
6034
5980d4c6
EZ
6035 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6036 buffers, return left-to-right.
8610fe8b
EZ
6037 (set_cursor_from_row): Consider candidate row a win if its glyph
6038 represents a newline and point is on that newline. Fixes cursor
6039 positioning on the newline at EOL of R2L text within L2R
6040 paragraph, and vice versa.
6041 (try_cursor_movement): Check continued rows, in addition to
6042 continuation rows. Fixes unwarranted scroll when point enters a
6043 continued line of R2L text within an L2R paragraph, or vice versa.
6044 (cursor_row_p): Consider the case of point being equal to
6045 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6046 from the end of a short line to the beginning of a continued line
6047 of R2L text within L2R paragraph.
6048 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6049 composed characters.
5980d4c6 6050
f67cdd7f
EZ
6051 * bidi.c (bidi_check_type): Use xassert.
6052 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6053 members.
6054
bca633fb
EZ
60552011-08-23 Eli Zaretskii <eliz@gnu.org>
6056
6057 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6058 a character.
6059
4a5885a7
CY
60602011-08-23 Chong Yidong <cyd@stupidchicken.com>
6061
6062 * nsfont.m (ns_otf_to_script): Fix typo.
6063
0902a04e
KH
60642011-08-22 Kenichi Handa <handa@m17n.org>
6065
6066 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6067 extra slot even if the purpose is char-code-property-table.
6068
1a2e6670
EZ
60692011-08-23 Eli Zaretskii <eliz@gnu.org>
6070
8ddde651
EZ
6071 * xdisp.c (redisplay_window): When computing centering_position,
6072 account for the height of the header line. (Bug#8874)
6073
425cc014
EZ
6074 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6075 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6076 candidate is selected by the mouse, and that candidate has a
6077 composed character under the mouse.
6078
1a2e6670
EZ
6079 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6080 coordinates reported by pos-visible-in-window-p for a composed
6081 character in column zero.
6082
8b76d6f8
SM
60832011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6084
6085 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6086
dac347dd
EZ
60872011-08-22 Eli Zaretskii <eliz@gnu.org>
6088
6089 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6090 consider it a hit if to_charpos is anywhere in the range of the
6091 composed buffer positions.
6092
e013fb34
CY
60932011-08-22 Chong Yidong <cyd@stupidchicken.com>
6094
6095 * image.c (gif_load): Don't assume that each subimage has the same
6096 dimensions as the base image. Handle disposal method that is
6097 "undefined" by the gif spec (Bug#9335).
6098
bd1ba3e8
CY
60992011-08-20 Chong Yidong <cyd@stupidchicken.com>
6100
6101 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6102 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6103
54a1215b
EZ
61042011-08-19 Eli Zaretskii <eliz@gnu.org>
6105
823564e5
EZ
6106 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6107 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6108 from an Org mode buffer to a Speedbar frame.
6109
54a1215b
EZ
6110 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6111 a composition, take its buffer position from IT->cmp_it.charpos.
6112 Fixes cursor positioning at the beginning of a line that begins
6113 with a composed character.
6114
9778ebcc
EZ
61152011-08-18 Eli Zaretskii <eliz@gnu.org>
6116
0be6ee06
EZ
6117 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6118 character bidirectional type, use STRONG_L instead. Fixes crashes
6119 in a buffer produced by `describe-categories'.
6120
9778ebcc
EZ
6121 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6122 members before the level stack, so they would be saved and
6123 restored when copying iterator state. Fixes incorrect reordering
6124 around TABs covered by display properties.
6125
156bffbe
AS
61262011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6127
6b02f655 6128 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6129
72ad093b
CY
61302011-08-17 Chong Yidong <cyd@stupidchicken.com>
6131
6132 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6133 (internal_condition_case_2, internal_condition_case_n):
6134 Remove unnecessary aborts (Bug#9081).
72ad093b 6135
35774242
EZ
61362011-08-17 Eli Zaretskii <eliz@gnu.org>
6137
6138 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6139 has no `load' handler, try opening the file locally. (Bug#9311)
6140
db76dd85
KB
61412011-08-16 Ken Brown <kbrown@cornell.edu>
6142
6143 * gmalloc.c: Expand comment.
6144
b215eee5
EZ
61452011-08-16 Eli Zaretskii <eliz@gnu.org>
6146
6147 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6148 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6149
a4579d33
KB
61502011-08-16 Ken Brown <kbrown@cornell.edu>
6151
6152 Fix memory allocation problems in Cygwin build (Bug#9273).
6153
6154 * unexcw.c ( __malloc_initialized): Declare external variable.
6155 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6156
8b76d6f8
SM
6157 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6158 New variables.
a4579d33
KB
6159 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6160 dumped emacs.
6161 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6162 in the static heap.
6163 [CYGWIN] (special_realloc): New function.
6164 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6165 requests to realloc storage in the static heap.
6166
3ebec551
PE
61672011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6168
6169 * bidi.c (bidi_initialize): Remove unused local.
6170
9fd8be00
EZ
61712011-08-15 Eli Zaretskii <eliz@gnu.org>
6172
6b02f655
SM
6173 * bidimirror.h:
6174 * biditype.h: Remove file.
6175 * makefile.w32-in ($(BLD)/bidi.$(O)):
6176 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6177
6178 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6179
6180 * chartab.c: Improve commentary for the uniprop_table API.
6181
32413314
EZ
6182 * bidi.c (bidi_paragraph_init): Support zero value of
6183 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6184 (bidi_initialize): Use uniprop_table instead of including
6185 biditype.h and bidimirror.h.
32413314 6186
9fd8be00
EZ
6187 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6188 coordinates of the iterator when restoring from ppos_it.
6189 (Bug#9296)
6190
5cf2b69b
KH
61912011-08-14 Kenichi Handa <handa@m17n.org>
6192
6193 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6194 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6195
daf17d00
EZ
61962011-08-14 Eli Zaretskii <eliz@gnu.org>
6197
6198 * xdisp.c (move_it_in_display_line_to): Don't invoke
6199 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6200 ppos_it. Fixes vertical cursor motion when line beginning is
6201 covered by an image. (Bug#9296)
6202
08e3161a
JD
62032011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6204
6205 * nsterm.h (ns_run_ascript): Declare.
6206 (NSAPP_DATA2_RUNASSCRIPT): Define.
6207
6208 * nsfns.m (as_script, as_result, as_status): New static variables.
6209 (ns_run_ascript): New function.
5e617bc2 6210 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6211 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6212 the event loop. Get status from as_status (Bug#7276).
6213
6214 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6215 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6216 the event loop (Bug#7276).
6217
a3720aa2
AS
62182011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6219
6220 * gnutls.c (QCgnutls_bootprop_priority)
6221 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6222 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6223 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6224 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6225 (QCgnutls_bootprop_verify_hostname_error)
6226 (QCgnutls_bootprop_callbacks_verify): Rename from
6227 Qgnutls_bootprop_..., all uses changed.
6228
6229 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6230 uses changed.
6231
0a0d27fb
PE
62322011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6233
19d5c50c
PE
6234 * xfaces.c (Qframe_set_background_mode): Now static.
6235 * dispextern.h (Qframe_set_background_mode): Remove decl.
6236
0a0d27fb
PE
6237 * process.c (Fnetwork_interface_info): Declare local only if needed.
6238
377538cb
JD
62392011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6240
6241 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6242 (Fnetwork_interface_list): Allocate in increments of bytes instead
6243 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6244 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6245 sockaddr.
6246 (struct ifflag_def): notrailers is smart on OSX.
6247 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6248 Get hardware address with getifaddrs if available.
6249
08fff70c
EZ
62502011-08-12 Eli Zaretskii <eliz@gnu.org>
6251
6252 * xdisp.c (iterate_out_of_display_property): xassert that
6253 IT->position is set to within IT->object's boundaries. Break from
6254 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6255 when IT->position is set up wrongly due to some bug.
6256 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6257 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6258 entry. Force push_it to save on the stack the current
6259 buffer/string position, to be restored by pop_it. Fix flags in
6260 the iterator structure wrt the object coming from a display
6261 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6262 properties. (Bug#9284)
6263
7be1c708 62642011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6265
7be1c708
CY
6266 * fontset.c (fontset_get_font_group): Add proper type checks.
6267 (Bug#9172)
aac0c6e3 6268
7be1c708 62692011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6270
7be1c708
CY
6271 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6272 and LC_VERSION_MIN_MACOSX.
6273 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6274 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6275
97bb72a6
EZ
62762011-08-08 Eli Zaretskii <eliz@gnu.org>
6277
6278 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6279 no-display-properties-and-no-overlays under bidi display.
6280 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6281 properties and overlays.
97bb72a6 6282
d5617611
CY
62832011-08-08 Chong Yidong <cyd@stupidchicken.com>
6284
37e11a63
CY
6285 * editfns.c (Fset_time_zone_rule): Document relationship with the
6286 setenv function.
6287
d5617611
CY
6288 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6289 the font entity extracted from the cache (Bug#8109).
6290
58872834
CY
62912011-08-07 Chong Yidong <cyd@stupidchicken.com>
6292
6293 * composite.c (autocmp_chars): Don't reset point. That is done by
6294 restore_point_unwind (Bug#5984).
6295
75bfc667
JL
62962011-08-07 Juri Linkov <juri@jurta.org>
6297
6298 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6299 to show the arg `TIME' instead of `TIMEVAL'.
6300
d1410150
EZ
63012011-08-06 Eli Zaretskii <eliz@gnu.org>
6302
6303 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6304 display property strides EOL and includes a newline, as in
6305 longlines-mode. (Bug#9254)
75b771e4
EZ
6306 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6307 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6308
6309 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6310 is non-zero, even if the data buffer is NULL. Fixes a crash in
6311 vertical-motion with longlines-mode. (Bug#9254)
6312
35928349
EZ
63132011-08-05 Eli Zaretskii <eliz@gnu.org>
6314
ec7cc85b
EZ
6315 * bidi.c <bidi_cache_total_alloc>: Now static.
6316 (bidi_initialize): Initialize bidi_cache_total_alloc.
6317
8b76d6f8 6318 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6319 cache. (Bug#9221)
6320
6321 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6322 amount allocated this far in `bidi_cache_total_alloc'.
6323 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6324 non-zero, only free the data buffer without restoring the cache
6325 contents. All callers changed.
6326
6327 * dispextern.h (bidi_unshelve_cache): Update prototype.
6328
6329 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6330 (move_it_in_display_line, move_it_to)
6331 (move_it_vertically_backward, move_it_by_lines): Replace the call
6332 to xfree to an equivalent call to bidi_unshelve_cache.
6333 (move_it_in_display_line_to): Fix logic of returning
412b6358 6334 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 6335
e2e2423b
EZ
63362011-08-05 Eli Zaretskii <eliz@gnu.org>
6337
6338 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6339 came from a string character with a `cursor' property. (Bug#9229)
6340
ae9e757a
JD
63412011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6342
6343 * Makefile.in (LIB_PTHREAD): New variable.
6344 (LIBES): Add LIB_PTHREAD (Bug#9216).
6345
6346 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6347 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6348
213bd7f2
AS
63492011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6350
6b02f655 6351 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 6352
99aaf75f
JD
63532011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6354
6355 * xterm.c (x_find_topmost_parent): New function.
6356 (x_set_frame_alpha): Find topmost parent window with
6357 x_find_topmost_parent and set the property there also (bug#9181).
6358 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6359
c74e9d86
PE
63602011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6361
6362 * callproc.c (Fcall_process): Avoid vfork clobbering
6363 the local vars buffer, coding_systems, current_dir.
6364
640c8776
SM
63652011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6366
6367 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6368
f26d0e4c
PE
63692011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6370
8a10d76c
PE
6371 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6372 so that it is not optimized away.
6373
f26d0e4c
PE
6374 * xdisp.c (compute_display_string_pos): Remove unused local.
6375
55439c61
EZ
63762011-08-02 Eli Zaretskii <eliz@gnu.org>
6377
6378 Fix slow cursor motion and scrolling in large buffers with
6379 selective display, like Org Mode buffers. (Bug#9218)
6380
6381 * dispextern.h (struct bidi_it): New member disp_prop_p.
6382
6383 * xdisp.c: Remove one-slot cache of display string positions.
6384 (compute_display_string_pos): Accept an additional argument
5e617bc2 6385 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
6386 for a display string or property. If found, set DISP_PROP_P
6387 non-zero.
6388
6389 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
6390 DISP_PROP_P, and pass it to compute_display_string_pos.
6391 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
6392 non-zero. All callers of bidi_fetch_char changed.
6393
fb33fa43
SM
63942011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6395
6396 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6397
b099e063
DM
63982010-12-03 Don March <don@ohspite.net>
6399
6400 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6401 last character M-[char] is translated to ESC [char] (bug#7541).
6402
5cc7f7af
KH
64032011-08-02 Kenichi Handa <handa@m17n.org>
6404
d0fffa3f 6405 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
6406
6407 * chartab.c (uniprop_table): Make it non-static.
6408
525d5e6e
EZ
64092011-08-01 Eli Zaretskii <eliz@gnu.org>
6410
6411 * xdisp.c (forward_to_next_line_start): Accept additional argument
6412 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6413 on the newline.
6414 (reseat_at_next_visible_line_start): Use the bidi iterator state
6415 returned by forward_to_next_line_start to restore the state of
6416 it->bidi_it after backing up to previous newline. (Bug#9212)
6417
31011111
AS
64182011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6419
6420 * regex.c (re_comp): Protoize.
6421 (re_exec): Fix return type.
6422 (regexec): Fix type of `ret'. (Bug#9203)
6423
476371c4
PE
64242011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6425
e5d76069
PE
6426 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6427 This is needed if max-image-size is a floating-point number.
6428
9a79b20c
AS
64292011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6430
6431 * print.c (print_object): Print empty symbol as ##.
6432
6433 * lread.c (read1): Read ## as empty symbol.
6434
d8c2fa78
AA
64352011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6436
6437 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6438 setting frame foreground color (Bug#9175).
6439 (x_set_background_color): Likewise.
6440
ffe57a7a
AA
6441 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6442 contents (Bug#9176).
6443 (EmacsTooltip -init): Remove bezels and add shadows to
6444 tooltip windows.
6445
bf3492a5
AA
6446 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6447 or scroll bar (Bug#8470).
6448
d55e9c53
AA
6449 * nsfont.m (nsfont_open): Remove assignment to voffset and
6450 unnecessary vars hshink, expand, hd, full_height, min_height.
6451 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6452
6453 * nsterm.h (nsfont_info): Remove voffset field.
6454
d8c2fa78 64552011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6456
6457 Implement strike-through and overline on NextStep (Bug#8863).
6458
6459 * nsfont.m (nsfont_open): Use underline position provided by font,
6460 instead of hard-coded value of 2.
6461 (nsfont_draw): Call ns_draw_text_decoration instead.
6462
6463 * nsterm.h: Add declaration for ns_draw_text_decoration.
6464
6465 * nsterm.m (ns_draw_text_decoration): New function for drawing
6466 underline, overline, and strike-through.
6467 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6468 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6469 accommodate underlining, etc.
4843aac3 6470
4cc60b9b
EZ
64712011-07-28 Eli Zaretskii <eliz@gnu.org>
6472
bc7ece87
EZ
6473 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6474 default.
4cc60b9b 6475
476371c4
PE
64762011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6477
66606eea
PE
6478 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6479 Without this fix, if a signal arrives just after memory fills up,
6480 'malloc' might be invoked reentrantly.
6481
476371c4
PE
6482 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6483 In other words, assume that every image size is allowed, on non-X
6484 hosts. This assumption is probably wrong, but it lets Emacs compile.
6485
f3fcc40d
AS
64862011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6487
6488 * regex.c (re_iswctype): Convert return values to boolean.
6489
350c992f
EZ
64902011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6491
6492 * xdisp.c (compute_display_string_pos): Don't use cached display
6493 string position if the buffer had its restriction changed.
6494 (Bug#9184)
6495
5266b4bb
PE
64962011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6497
6498 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6499
2573a837 65002011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6501
41f55ccd 6502 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6503
39e378da
PE
6504 * bidi.c: Integer size and overflow fixes.
6505 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6506 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6507 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6508 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6509 (bidi_find_other_level_edge):
6510 Use ptrdiff_t instead of EMACS_INT where either will do.
6511 This works better on 32-bit hosts configured --with-wide-int.
6512 (bidi_cache_ensure_space): Check for size-calculation overflow.
6513 Use % rather than repeated addition, for better worst-case speed.
6514 Don't set bidi_cache_size until after xrealloc returns, because it
6515 might not return.
6516 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
6517 (bidi_cache_ensure_space): Also check that the bidi cache size
6518 does not exceed that of the largest Lisp string or buffer. See Eli
6519 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 6520
5e927815
PE
6521 * alloc.c (__malloc_size_t): Remove.
6522 All uses replaced by size_t. See Andreas Schwab's note
6523 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6524
ca4aa935
PE
6525 * image.c: Improve checking for integer overflow.
6526 (check_image_size): Assume that f is nonnull, since
6527 it is always nonnull in practice. This is one less thing to
6528 worry about when checking for integer overflow later.
6529 (x_check_image_size): New function, which checks for integer
6530 overflow issues inside X.
6531 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6532 This removes the need for a memory_full check.
6533 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6534 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6535 (xbm_read_bitmap_data): Change locals back to 'int', since
6536 their values must fit in 'int'.
6537 (xpm_load_image, png_load, tiff_load):
6538 Invoke x_create_x_image_and_pixmap earlier,
6539 to avoid much needless work if the image is too large.
6540 (tiff_load): Treat overly large images as if
6541 x_create_x_image_and_pixmap failed, not as malloc failures.
6542 (gs_load): Use x_check_image_size.
6543
5f8f9cc2
PE
6544 * gtkutil.c: Omit integer casts.
6545 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6546 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6547
5adf60bc
PE
6548 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6549
c8907a93
PE
6550 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6551 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6552 would wrongly return t on a 64-bit host.
6553
e3c25c68
PE
6554 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6555 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6556 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6557 and therefore cause GCC to emit a bogus diagnostic in some cases.
6558
3f791afe
PE
6559 * image.c: Integer signedness and overflow and related fixes.
6560 This is not an exhaustive set of fixes, but it's time to
6561 record what I've got.
6562 (lookup_pixel_color, check_image_size): Remove redundant decls.
6563 (check_image_size): Don't assume that arbitrary EMACS_INT values
6564 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6565 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6566 (tiff_load, imagemagick_load_image):
6567 Check for overflow in size calculations.
6568 (x_create_x_image_and_pixmap): Remove unnecessary test for
6569 xmalloc returning NULL; that can't happen.
6570 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6571 (xpm_color_bucket): Use better integer hashing function.
6572 (xpm_cache_color): Don't possibly over-allocate memory.
6573 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6574 (gif_memory_source):
6575 Use ptrdiff_t, not int or size_t, to record sizes.
6576 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6577 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6578 either works, as we prefer signed integers.
6579 (tiff_read_from_memory, tiff_write_from_memory):
6580 Return tsize_t, not size_t, since that's what the TIFF API wants.
6581 (tiff_read_from_memory): Don't fail simply because the read would
6582 go past EOF; instead, return a short read.
6583 (tiff_load): Omit no-longer-needed casts.
6584 (Fimagemagick_types): Don't assume size fits into 'int'.
6585
3cc5a532
PE
6586 Improve hashing quality when configured --with-wide-int.
6587 * fns.c (hash_string): New function, taken from sxhash_string.
6588 Do not discard information about ASCII character case; this
6589 discarding is no longer needed.
6590 (sxhash-string): Use it. Change sig to match it. Caller changed.
6591 * lisp.h: Declare it.
6592 * lread.c (hash_string): Remove, since we now use fns.c's version.
6593 The fns.c version returns a wider integer if --with-wide-int is
6594 specified, so this should help the quality of the hashing a bit.
6595
b312a492
PE
6596 * emacs.c: Integer overflow minor fix.
6597 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6598 Define only if GNU_LINUX.
6599 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6600
dfd153ae
PE
6601 * dispnew.c: Integer signedness and overflow fixes.
6602 Remove unnecessary forward decls, that were a maintenance hassle.
6603 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6604 All uses changed.
6605 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6606 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6607 (prepare_desired_row, line_draw_cost):
6608 Use int, not unsigned, where either works.
6609 (save_current_matrix, restore_current_matrix):
6610 Use ptrdiff_t, not size_t, where either works.
6611 (init_display): Check for overflow more accurately, and without
6612 relying on undefined behavior.
6613
a81d11a3
PE
6614 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6615 Remove, replacing with the new symbols in lisp.h. All uses changed.
6616 * fileio.c (make_temp_name):
6617 * filelock.c (lock_file_1, lock_file):
6618 * xdisp.c (message_dolog):
6619 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6620 Use pMd etc. instead.
6621 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6622 replacing the pWIDE etc. symbols removed from editfns.c.
6623
3300e6fd
PE
6624 * keyboard.h (num_input_events): Now uintmax_t.
6625 This is (very slightly) less likely to mess up due to wraparound.
6626 All uses changed.
6627
fd05c7e9
PE
6628 * buffer.c: Integer signedness fixes.
6629 (alloc_buffer_text, enlarge_buffer_text):
6630 Use ptrdiff_t rather than size_t when either will do, as we prefer
6631 signed integers.
6632
903fe15d
PE
6633 * alloc.c: Integer signedness and overflow fixes.
6634 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6635 (__malloc_size_t): Default to size_t, not to int.
6636 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6637 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6638 Prefer ptrdiff_t to size_t when either would do, as we prefer
6639 signed integers.
6640 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6641 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6642 Now const. Initialize with values that are in range even if char
6643 is signed.
6644 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6645 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6646 These functions do the right thing with sizes > 2**32.
6647 (check_depth): Now ptrdiff_t, not int.
6648 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6649 Adjust to new way of storing sizes. Check for size overflow bugs
6650 in rest of code.
6651 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6652 slightly wrong anyway, as it missed one instance of
6653 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6654 (refill_memory_reserve): Omit needless cast to size_t.
6655 (mark_object_loop_halt): Mark as externally visible.
6656
ac82cc6a
PE
6657 * xselect.c: Integer signedness and overflow fixes.
6658 (Fx_register_dnd_atom, x_handle_dnd_message):
6659 Use ptrdiff_t, not size_t, since we prefer signed.
6660 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6661 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6662 x_dnd_atoms_size and x_dnd_atoms_length.
6663
c2d1e36d
PE
6664 * doprnt.c: Prefer signed to unsigned when either works.
6665 * eval.c (verror):
6666 * doprnt.c (doprnt):
6667 * lisp.h (doprnt):
6668 * xdisp.c (vmessage):
6669 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6670 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6671 prefer signed arithmetic to avoid comparison confusion.
6672 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6673 but is a bit tricky.
6674
0e926e56
PE
6675 Assume freestanding C89 headers, string.h, stdlib.h.
6676 * data.c, doprnt.c, floatfns.c, print.c:
6677 Include float.h unconditionally.
6678 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6679 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6680 * regex.c: Likewise for stddef.h, string.h.
6681 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6682 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6683 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6684 (STDC_HEADERS): Remove obsolete defines.
6685 * sysdep.c: Include limits.h unconditionally.
6686
9cfdb3ec
PE
6687 Assume support for memcmp, memcpy, memmove, memset.
6688 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6689 * regex.c (memcmp, memcpy):
6690 Remove; we assume C89 now.
6691
6692 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6693 (__malloc_safe_bcopy): Remove; no longer needed.
6694
cf950e6b 6695 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
6696 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6697 well either way, and we prefer signed to unsigned.
6698
dbf38e02
LMI
66992011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6700
6701 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6702 closes the connection while we're reading (bug#9182).
6703
d6f0886c 67042011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 6705
d6f0886c
JD
6706 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6707 are specified (Bug#9168).
24e0f6b1 6708
2eb1f9e6
PE
67092011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6710
6711 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6712 Found by GCC static checking and --with-wide-int on a 32-bit host.
6713
22381272 67142011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
6715
6716 * xdisp.c (compute_display_string_pos): Fix logic of caching
6717 previous display string position. Initialize cached_prev_pos to
6718 -1. Fixes slow-down at the beginning of a buffer.
6719
f25e39b4
EZ
67202011-07-24 Eli Zaretskii <eliz@gnu.org>
6721
6722 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6723 for attrs[LFACE_FONTSET_INDEX].
6724
04c4b52e
PE
67252011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6726
6727 * xml.c (parse_region): Remove unused local
6728 that was recently introduced.
6729
c1734fbd
EZ
67302011-07-23 Eli Zaretskii <eliz@gnu.org>
6731
be18c5a5
EZ
6732 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6733 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6734
c1734fbd
EZ
6735 * xdisp.c (move_it_in_display_line_to): Record the best matching
6736 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
6737 exit if none of the characters scanned was an exact match.
6738 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
6739 when exact match is impossible due to invisible text, and the
6740 lines are truncated.
6741
a258d627
JD
67422011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6743
6744 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6745 for OSX >= 10.7.
6746
b6d5a689
EZ
67472011-07-22 Eli Zaretskii <eliz@gnu.org>
6748
0f74f785
EZ
6749 Fix a significant slow-down of cursor motion with C-n, C-p,
6750 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6751 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 6752 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
6753 (next_element_from_buffer): Call compute_stop_pos_backwards to
6754 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
6755 base_level_stop.
6756 (reseat): Don't look for prev_stop, as that could mean a very long
6757 run.
6758 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6759 <cached_disp_overlay_modiff>: Cache for last found display string
6760 position.
551918c1 6761 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
6762 about the same buffer in the same area of character positions, and
6763 the buffer wasn't changed since the time the display string
6764 position was cached.
551918c1 6765
b2d0c91a
EZ
67662011-07-22 Eli Zaretskii <eliz@gnu.org>
6767
6768 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6769 is an integer, which is important for empty lines. (Bug#9149)
6770
043604ee
CY
67712011-07-22 Chong Yidong <cyd@stupidchicken.com>
6772
6773 * frame.c (Fmodify_frame_parameters): In tty case, update the
6774 default face if necessary (Bug#4238).
6775
da4adb04
CY
67762011-07-21 Chong Yidong <cyd@stupidchicken.com>
6777
6778 * editfns.c (Fstring_to_char): No need to explain what a character
6779 is in the docstring (Bug#6576).
6780
9abd0532
LMI
67812011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6782
6783 * xml.c (parse_region): Make sure we always return a tree.
6784
36881d16
HK
67852011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6786
6787 * xml.c (parse_region): If a document contains only comments,
6788 return that, too.
6789
1e98674d
LMI
67902011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6791
6792 * xml.c (make_dom): Return comments, too.
6793
590bd467
PE
67942011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6795
6796 Port to OpenBSD.
6797 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6798 and the surrounding thread.
6799 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6800 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6801 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6802 timer goes off.
6803 * s/openbsd.h (BROKEN_SIGIO): Define.
6804 * unexelf.c (unexec) [__OpenBSD__]:
6805 Don't update the .mdebug section of the Alpha COFF symbol table.
6806
f41628b2
LMI
68072011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6808
6809 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6810 (bug#8460).
6811
b59b67c5
PE
68122011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6813
15e3a074
PE
6814 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6815 This fixes some race conditions on the permissions of any newly
6816 created file.
6817
41bed37d
PE
6818 * alloc.c (valid_pointer_p): Use pipe, not open.
6819 This fixes some permissions issues when debugging.
6820
b59b67c5
PE
6821 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6822 If fchown fails to set both uid and gid, try to set just gid,
6823 as that is sometimes allowed. Adjust the file's mode to eliminate
6824 setuid or setgid bits that are inappropriate if fchown fails.
6825
925a6be7
SM
68262011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6827
6828 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6829 to compare Lisp_Objects.
6830 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6831 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6832 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6833
52968808
AS
68342011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6835
0a6a104b
AS
6836 * lread.c (read_integer): Unread even EOF character.
6837 (read1): Likewise. Properly record start position of symbol.
6838
52968808
AS
6839 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6840 symbol character follows.
6841
9e381cdd
PE
68422011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6843
6844 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6845 This works around a problem with the previous change to Fcopy_file.
6846 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6847 and without this change, GCC might complain about discarding
6848 fchown's return value.
6849
b5641435
JB
68502011-07-16 Juanma Barranquero <lekktu@gmail.com>
6851
6852 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6853
a8031457
PE
68542011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6855
6856 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6857
dd889327
LMI
68582011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6859
750c33f7
LMI
6860 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6861 it's used from the C level.
6862
dd889327
LMI
6863 * process.c: Use the same condition for POLL_FOR_INPUT in both
6864 keyboard.c and process.c (bug#1858).
6865
87e86684
LM
68662011-07-09 Lawrence Mitchell <wence@gmx.li>
6867
6868 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6869 (Fgnutls_boot): Use it.
6870
64348f40
AS
68712011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6872
6873 * doc.c (Fsubstitute_command_keys): Revert last change.
6874
1d698799
LMI
68752011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6876
f863868c
LMI
6877 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6878 quotes the next character, and doesn't affect other longer
6879 sequences (bug#8935).
6880
1d698799
LMI
6881 * lread.c (syms_of_lread): Clarify that is isn't only
6882 `eval-buffer' and `eval-defun' that's affected by
6883 `lexical-binding' (bug#8460).
6884
aa4b6df6
EZ
68852011-07-15 Eli Zaretskii <eliz@gnu.org>
6886
6887 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6888 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6889
5d856da6
PE
68902011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6891
ad6042bb
PE
6892 Fix minor problems found by static checking.
6893 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6894 (elsz): Now a signed constant, not a size_t var. We prefer signed
6895 types to unsigned, to avoid integer comparison confusion. Without
6896 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6897 "cannot optimize loop, the loop counter may overflow", a symptom
6898 of the confusion.
f00bbb22 6899 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6900 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6901
6468f31c
LMI
69022011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6903
49080b10
LMI
6904 * search.c (Fre_search_backward): Mention `case-fold-search' in
6905 all the re_search_* functions (bug#8138).
6906
6468f31c
LMI
6907 * keyboard.c (Fopen_dribble_file): Document when the file is
6908 closed (bug#8056).
6909
c965adc5
EZ
69102011-07-14 Eli Zaretskii <eliz@gnu.org>
6911
df9733bf
EZ
6912 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6913 bidi_cache_idx.
6914
0bb23927
EZ
6915 Support bidi reordering of display and overlay strings.
6916 * xdisp.c (compute_display_string_pos)
6917 (compute_display_string_end): Accept additional argument STRING.
6918 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6919 (reseat_to_string): Initialize bidi_it->string.s and
6920 bidi_it->string.schars.
6921 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6922 NULL (avoids a crash in bidi_paragraph_init).
6923 Initialize itb.string.lstring.
0bb23927
EZ
6924 (init_iterator): Call bidi_init_it only of a valid
6925 buffer position was specified. Initialize paragraph_embedding to
6926 L2R.
6927 (reseat_to_string): Initialize the bidi iterator.
6928 (display_string): If we need to ignore text properties of
6929 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6930 original value of -1 will not work with bidi.)
6931 (compute_display_string_pos): First arg is now struct
6932 `text_pos *'; all callers changed. Support display properties on
6933 Lisp strings.
6934 (compute_display_string_end): Support display properties on Lisp
6935 strings.
6936 (init_iterator, reseat_1, reseat_to_string): Initialize the
6937 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6938 when iterating on a string not from display properties).
640c8776
SM
6939 (compute_display_string_pos, compute_display_string_end):
6940 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6941 arrow keys.
6942 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6943 base_level_stop; instead, set base_level_stop to BEGV.
6944 Fixes crashes in vertical-motion.
0bb23927
EZ
6945 (next_element_from_buffer): Improve commentary for when
6946 the iterator is before prev_stop.
6947 (init_iterator): Initialize bidi_p from the default value of
6948 bidi-display-reordering, not from buffer-local value. Use the
6949 buffer-local value only if initializing for buffer iteration.
6950 (handle_invisible_prop): Support invisible properties on strings
6951 that are being bidi-reordered.
6952 (set_iterator_to_next): Support bidi reordering of C strings and
6953 Lisp strings.
6954 (next_element_from_string): Support bidi reordering of Lisp
6955 strings.
6956 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6957 (display_string): Support display of R2L glyph rows.
6958 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6959 (init_iterator): Don't initialize it->bidi_p for strings
6960 here.
6961 (reseat_to_string): Initialize it->bidi_p for strings here.
6962 (next_element_from_string, next_element_from_c_string)
6963 (next_element_from_buffer): Add xassert's for correspondence
6964 between IT's object being iterated and it->bidi_it.string
6965 structure.
6966 (face_before_or_after_it_pos): Support bidi iteration.
6967 (next_element_from_c_string): Handle the case of the first string
6968 character that is not the first one in the visual order.
6969 (get_visually_first_element): New function, refactored from common
6970 parts of next_element_from_buffer, next_element_from_string, and
6971 next_element_from_c_string.
6972 (tool_bar_lines_needed, redisplay_tool_bar)
6973 (display_menu_bar): Force left-to-right direction. Add a FIXME
6974 comment for making that be controlled by a user option.
6975 (push_it, pop_it): Save and restore the state of the
6976 bidi iterator. Save and restore the bidi_p flag.
6977 (pop_it): Iterate out of display property for string iteration as
6978 well.
6979 (iterate_out_of_display_property): Support iteration over strings.
6980 (handle_single_display_spec): Set up it->bidi_it for iteration
6981 over a display string, and call bidi_init_it.
6982 (handle_single_display_spec, next_overlay_string)
6983 (get_overlay_strings_1, push_display_prop): Set up the bidi
6984 iterator for displaying display or overlay strings.
6985 (forward_to_next_line_start): Don't use the shortcut if
6986 bidi-iterating.
6987 (back_to_previous_visible_line_start): If handle_display_prop
6988 pushed the iterator stack, restore the internal state of the bidi
6989 iterator by calling bidi_pop_it same number of times.
6990 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6991 and we are bidi-iterating, don't decrement the iterator position;
6992 instead, set the first_elt flag in the bidi iterator, to produce
6993 the same effect.
6994 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6995 (push_display_prop): xassert that we are iterating a buffer.
6996 (push_it, pop_it): Save and restore paragraph_embedding member.
6997 (handle_single_display_spec, next_overlay_string)
6998 (get_overlay_strings_1, reseat_1, reseat_to_string)
6999 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7000 correctly. Don't assume unibyte strings are not bidi-reordered.
7001 (compute_display_string_pos)
7002 (compute_display_string_end): Fix handling the case of C string.
7003 (push_it, pop_it): Save and restore from_disp_prop_p.
7004 (handle_single_display_spec, push_display_prop): Set the
7005 from_disp_prop_p flag.
7006 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7007 (pop_it): Call iterate_out_of_display_property only if we are
7008 popping after iteration over a string that came from a display
7009 property. Fix a typo in popping stretch info. Add an assertion
7010 for verifying that the iterator position is in sync with the bidi
7011 iterator.
7012 (handle_single_display_spec, get_overlay_strings_1)
7013 (push_display_prop): Fix initialization of paragraph direction for
7014 string when that of the parent object is not yet determined.
7015 (reseat_1): Call bidi_init_it to resync the bidi
7016 iterator with IT's position. (Bug#7616)
7017 (find_row_edges): If ROW->start.pos gives position
7018 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7019 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7020 Reset the from_disp_prop_p flag.
7021 (SAVE_IT, RESTORE_IT): New macros.
7022 (pos_visible_p, face_before_or_after_it_pos)
7023 (back_to_previous_visible_line_start)
7024 (move_it_in_display_line_to, move_it_in_display_line)
7025 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7026 (try_scrolling, redisplay_window, display_line): Use them when
7027 saving a temporary copy of the iterator and restoring it back.
7028 (back_to_previous_visible_line_start, reseat_1)
7029 (init_iterator): Empty the bidi cache "stack".
7030 (move_it_in_display_line_to): If iterator ended up at
7031 EOL, but we never saw any buffer positions smaller than
7032 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7033 motion in bidi-reordered lines.
7034 (move_it_in_display_line_to): Record prev_method and prev_pos
7035 immediately before the call to set_iterator_to_next. Fixes cursor
7036 motion in bidi-reordered lines with stretch glyphs and strings
7037 displayed in margins. (Bug#8133) (Bug#8867)
7038 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7039 TO_CHARPOS.
640c8776
SM
7040 (pos_visible_p): Support positions in bidi-reordered lines.
7041 Save and restore bidi cache.
0bb23927
EZ
7042
7043 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7044 (bidi_paragraph_info): Delete unused struct.
7045 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7046 (bidi_cache_start): New variable.
7047 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7048 to zero.
7049 (bidi_cache_fetch_state, bidi_cache_search)
7050 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7051 (bidi_cache_find, bidi_peek_at_next_level)
7052 (bidi_level_of_next_char, bidi_find_other_level_edge)
7053 (bidi_move_to_visually_next): Compare cache index with
7054 bidi_cache_start rather than with zero.
7055 (bidi_fetch_char): Accept new argument STRING; all callers
7056 changed. Support iteration over a string. Support strings with
7057 display properties. Support unibyte strings. Fix the type of
7058 `len' according to what STRING_CHAR_AND_LENGTH expects.
7059 (bidi_paragraph_init, bidi_resolve_explicit_1)
7060 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7061 (bidi_level_of_next_char, bidi_move_to_visually_next):
7062 Support iteration over a string.
0bb23927
EZ
7063 (bidi_set_sor_type, bidi_resolve_explicit_1)
7064 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7065 can now be zero (for strings); special values 0 and -1 were
7066 changed to -1 and -2, respectively.
7067 (bidi_char_at_pos): New function.
7068 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7069 Call it instead of FETCH_MULTIBYTE_CHAR.
7070 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7071 initialized to valid values.
7072 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7073 values.
7074 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7075 the test for valid cached positions. Fix the logic for looking up
7076 the sentinel state in the cache. GCPRO the Lisp string we are
7077 iterating.
7078 (bidi_push_it, bidi_pop_it): New functions.
7079 (bidi_initialize): Initialize the bidi cache start stack pointer.
7080 (bidi_cache_ensure_space): New function, refactored from part of
7081 bidi_cache_iterator_state. Don't assume the required size is just
7082 one BIDI_CACHE_CHUNK away.
7083 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7084 (bidi_count_bytes, bidi_char_at_pos): New functions.
7085 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7086 always valid if bidi_cache_idx is valid.
7087 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7088 is valid if it's going to be used.
7089 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7090 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7091 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7092 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7093 (bidi_find_other_level_edge, bidi_cache_start_stack):
7094 All variables related to cache indices are now EMACS_INT.
c965adc5 7095
0bb23927
EZ
7096 * dispextern.h (struct bidi_string_data): New structure.
7097 (struct bidi_it): New member `string'. Make flag members be 1-bit
7098 fields, and put them last in the struct.
640c8776
SM
7099 (compute_display_string_pos, compute_display_string_end):
7100 Update prototypes.
0bb23927
EZ
7101 (bidi_push_it, bidi_pop_it): Add prototypes.
7102 (struct iterator_stack_entry): New members bidi_p,
7103 paragraph_embedding, and from_disp_prop_p.
7104 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7105 (bidi_shelve_cache, bidi_unshelve_cache):
7106 Declare prototypes.
0bb23927
EZ
7107
7108 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7109 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7110 and vector-like objects.
7111
7112 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7113 cache around display iteration.
7114
7115 * window.c (Fwindow_end, window_scroll_pixel_based)
7116 (displayed_window_lines, Frecenter): Save and restore the bidi
7117 cache around display iteration.
7118
3bbd2265
LMI
71192011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7120
7121 * editfns.c (Fdelete_region): Clarify the use of the named
7122 parameters (bug#6788).
7123
adc47434
MR
71242011-07-14 Martin Rudalics <rudalics@gmx.at>
7125
7126 * indent.c (Fvertical_motion): Set and restore w->pointm when
7127 saving and restoring the window's buffer (Bug#9006).
7128
837c31f8
LMI
71292011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7130
7131 * editfns.c (Fstring_to_char): Clarify just what is returned
7132 (bug#6576). Text by Eli Zaretskii.
7133
ac389d0c
JB
71342011-07-13 Juanma Barranquero <lekktu@gmail.com>
7135
7136 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7137
0be0ce47
EZ
71382011-07-13 Eli Zaretskii <eliz@gnu.org>
7139
7140 * buffer.c (mmap_find): Fix a typo.
7141
cd18e7e3
JB
71422011-07-13 Johan Bockgård <bojohan@gnu.org>
7143
7144 Fix execution of x selection hooks.
7145 * xselect.c (Qx_lost_selection_functions)
7146 (Qx_sent_selection_functions): New vars.
7147 (syms_of_xselect): DEFSYM them.
7148 (x_handle_selection_request): Pass Qx_sent_selection_functions
7149 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7150 (x_handle_selection_clear,x_clear_frame_selections):
7151 Pass Qx_lost_selection_functions rather than
7152 Vx_lost_selection_functions to Frun_hook_with_args.
7153
47ea7f44
PE
71542011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7155
ac389d0c 7156 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7157 The old code sometimes used this field without initializing it.
7158
47ea7f44
PE
7159 * alloc.c (gc_sweep): Don't read past end of array.
7160 In theory, the old code could also have corrupted Emacs internals,
7161 though it'd be very unlikely.
7162
bc985c87
AS
71632011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7164
7165 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7166 argument. (Bug#4026)
bc985c87 7167
0cf34688
LMI
71682011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7169
b3dadd76
LMI
7170 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7171 key" (bug#4257).
7172
0cf34688
LMI
7173 * window.c (Fset_window_start): Doc fix (bug#4199).
7174 (Fset_window_hscroll): Ditto.
7175
270768cd
PE
71762011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7177
077e3dda 7178 Fix minor new problems caught by GCC 4.6.1.
270768cd 7179 * term.c (init_tty): Remove unused local.
490011a6 7180 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7181 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7182 not used otherwise.
270768cd 7183
b1f58454
CY
71842011-07-12 Chong Yidong <cyd@stupidchicken.com>
7185
7186 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7187
22b9578d
LMI
71882011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7189
6e70ab07
LMI
7190 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7191 are the mini-buffer and the echo area (bug#3320).
7192
22b9578d
LMI
7193 * term.c (init_tty): Remove support for supdup, c10 and perq
7194 terminals, which are no longer supported (bug#1482).
7195
8974cc9f
JB
71962011-07-10 Johan Bockgård <bojohan@gnu.org>
7197
7198 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7199
a560d974
JD
72002011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7201
7202 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7203 for non-popups (Bug#3642).
7204
1dae0f0a
AS
72052011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7206
268c2c36 7207 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7208 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7209 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7210 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7211 * data.c (fmod): Likewise.
7212 * dispnew.c (swap_glyphs_in_rows): Likewise.
7213 * emacs.c (memory_warning_signal): Likewise.
7214 * floatfns.c (float_error): Likewise.
7215 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7216 (otf_open, font_otf_capability, generate_otf_features)
7217 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7218 Likewise.
7219 * image.c (pbm_read_file): Likewise.
7220 * indent.c (string_display_width): Likewise.
7221 * intervals.c (check_for_interval, search_for_interval)
7222 (inc_interval_count, count_intervals, root_interval)
7223 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7224 * lread.c (defalias): Likewise.
268c2c36 7225 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7226 * regex.c (set_image_of_range_1, set_image_of_range)
7227 (regex_grow_registers): Likewise.
7228 * sysdep.c (strerror): Likewise.
7229 * termcap.c (valid_filename_p, tprint, main): Likewise.
7230 * tparam.c (main): Likewise.
7231 * unexhp9k800.c (run_time_remap, save_data_space)
7232 (update_file_ptrs, read_header, write_header, calculate_checksum)
7233 (copy_file, copy_rest, display_header): Likewise.
7234 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7235 Likewise.
7236 * xdisp.c (check_it): Likewise.
7237 * xfaces.c (register_color, unregister_color, unregister_colors):
7238 Likewise.
7239 * xfns.c (print_fontset_result): Likewise.
7240 * xrdb.c (member, fatal, main): Likewise.
7241
99033785
PE
72422011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7243
7244 Fix minor problems found by static checking (Bug#9031).
7245 * chartab.c (char_table_set_range, map_sub_char_table):
7246 Remove unused locals.
7247 (uniprop_table): Now static.
7248 * composite.c (_work_char): Remove unused static var.
7249
9cb2ac56
JB
72502011-07-09 Juanma Barranquero <lekktu@gmail.com>
7251
7252 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7253
f25661f0
JD
72542011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7255
7256 * gtkutil.c (qttip_cb): Remove code without function.
7257
8278c4fe
EZ
72582011-07-09 Eli Zaretskii <eliz@gnu.org>
7259
7260 * w32.c (pthread_sigmask): New stub.
7261
1692ae2d 72622011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7263
8a6ebd58 7264 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7265 sigprocmask is portable only for single-threaded applications, and
7266 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7267 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7268 (LIBES): Use it.
7269 * callproc.c (Fcall_process):
7270 * process.c (create_process):
7271 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7272 Use pthread_sigmask, not sigprocmask.
123403e4 7273
1b854618
JD
72742011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7275
7276 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7277 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7278 wrong (Bug#8591).
7279
3fe4b549
JD
72802011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7281
0ce7e563
JD
7282 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7283 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7284 (xg_hide_tooltip): Fix comment.
7285
3fe4b549
JD
7286 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7287 in registerServicesMenuSendTypes.
7288 (validRequestorForSendType): Don't check ns_return_types.
7289
7290 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7291 ns_return_type.
7292
5df75e47
JR
72932011-07-08 Jason Rumney <jasonr@gnu.org>
7294
22610910
JR
7295 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7296 SH_SHOW for hidden windows (Bug#5482).
7297
5df75e47
JR
7298 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7299 frame struct members of non-existent frames (Bug#6284).
7300
699c10bd
JD
73012011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7302
4393663b
JD
7303 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7304 variable firstTime not needed on OSX >= 10.6.
7305 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7306 >= 10.5. Use setKnobProportion, setDoubleValue.
7307
7308 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7309 (MAC_OS_X_VERSION_10_5): Define if not defined.
7310 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7311 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7312 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7313
7314 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7315 cString and lossyCString on OSX >= 10.4
7316
58179cce 7317 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7318 sizeToFit on OSX >= 10.2.
7319
7320 * nsimage.m (allocInitFromFile): Don't use deprecated method
7321 bestRepresentationForDevice on OSX >= 10.6.
7322
7323 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7324 to avoid warning.
7325
7326 * emacs.c: Declare unexec_init_emacs_zone.
7327
a63e0781
JD
7328 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7329
699c10bd
JD
7330 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7331
7332 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7333 on svcsMenu (Bug#8842).
7334
7335 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7336 ns_return_types.
7337 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7338
7339 * nsterm.m (QUTF8_STRING): Declare.
7340 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7341 (validRequestorForSendType): Return type is (id).
7342 Change indexOfObjectIdenticalTo to indexOfObject.
7343 Check if we have local selection before returning self (Bug#8842).
7344 (writeSelectionToPasteboard): Put local selection into paste board
7345 if we have a local selection (Bug#8842).
7346 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7347
7348 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7349 (ns_get_local_selection): Declare.
7350
54e10184
LMI
73512011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7352
9888ff71
LMI
7353 * keymap.c (describe_map_tree): Don't insert a double newline at
7354 the end of the buffer (bug#1169) and return whether we inserted
7355 something.
7356
54e10184
LMI
7357 * callint.c (Fcall_interactively): Change "reading args" to
7358 "providing args" to try to clarify what it does (bug#1010).
7359
15fa4783
KH
73602011-07-07 Kenichi Handa <handa@m17n.org>
7361
7362 * composite.c (composition_compute_stop_pos): Ignore a static
7363 composition starting before CHARPOS (Bug#8915).
7364
7365 * xdisp.c (handle_composition_prop): Likewise.
7366
a8815b00
EZ
73672011-07-07 Eli Zaretskii <eliz@gnu.org>
7368
7369 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7370 (Bug#9015)
7371
ef7b981d 73722011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
7373
7374 * character.h (unicode_category_t): New enum type.
7375
7376 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7377 (Qchar_code_property_table): New variable.
7378 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7379 (UNIPROP_COMPRESSED_FORM_P): New macros.
7380 (char_table_ascii): Uncompress the compressed values.
7381 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7382 Uncompress the compressed values.
ac389d0c 7383 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
7384 (char_table_ref_and_range): Uncompress the compressed values.
7385 (sub_char_table_set): New arg is_uniprop. Callers changed.
7386 Uncompress the compressed values.
7387 (sub_char_table_set_range): Args changed. Callers changed.
7388 (char_table_set_range): Adjuted for the above change.
7389 (map_sub_char_table): Delete args default_val and parent. Add arg
7390 top. Give decoded values to a Lisp function.
640c8776 7391 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
7392 values to a Lisp function. Gcpro more variables.
7393 (uniprop_table_uncompress)
7394 (uniprop_decode_value_run_length): New functions.
7395 (uniprop_decoder, uniprop_decoder_count): New variables.
7396 (uniprop_get_decoder, uniprop_encode_value_character)
7397 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7398 New functions.
7399 (uniprop_encoder, uniprop_encoder_count): New variables.
7400 (uniprop_get_encoder, uniprop_table)
7401 (Funicode_property_table_internal, Fget_unicode_property_internal)
7402 (Fput_unicode_property_internal): New functions.
7403 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7404 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 7405 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
7406 char-code-property-alist.
7407
640c8776 7408 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
7409 Vunicode_category_table.
7410
640c8776 7411 * font.c (font_range): Adjust for the change of
c805dec0
KH
7412 Vunicode_category_table.
7413
76b397fb
DN
74142011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7415
7416 * m/iris4d.h: Remove file, move contents ...
7417 * s/irix6-5.h: ... here.
7418
22b4128e
PE
74192011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7420
7421 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
7422 * alloc.c (mark_buffer):
7423 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7424 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7425 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7426 This isn't true in general, and it's particularly not true
7427 if Emacs is configured with --with-wide-int.
7428 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7429 New macros, used in the buffer.c change.
7430
869795d6
JD
74312011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7432
7433 * xsettings.c: Use both GConf and GSettings if both are available.
7434 (store_config_changed_event): Add comment.
7435 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7436 (store_tool_bar_style_changed): New functions.
5e617bc2 7437 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7438 (struct xsettings): Move font inside HAVE_XFT.
7439 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7440 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7441 Move inside HAVE_XFT.
640c8776 7442 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7443 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7444 also.
7445 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7446 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7447 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7448 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7449 (parse_settings): Move check for font inside HAVE_XFT.
7450 (read_settings, apply_xft_settings): Add comment.
7451 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7452 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7453 call store_font_name_changed.
7454 (xft_settings_event): Add comment.
7455 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7456 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7457 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7458 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7459 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7460 (xsettings_get_system_font, xsettings_get_system_normal_font):
7461 Add comment.
869795d6 7462
d8ed26bd
PE
74632011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7464
7465 Random fixes. E.g., (random) never returned negative values.
7466 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7467 subseconds part to the entropy, as that's a bit more random.
7468 Prefer signed to unsigned, since the signedness doesn't matter and
7469 in general we prefer signed. When given a limit, use a
7470 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7471 latter isn't right if USE_2_TAGS_FOR_INTS.
7472 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7473 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7474
cabf1cac
SM
74752011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7476
7477 * textprop.c (text_property_stickiness):
7478 Obey Vtext_property_default_nonsticky.
7479 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7480 * w32fns.c (syms_of_w32fns):
7481 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7482
6e9b2be9
PE
74832011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7484
7485 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7486 This is more efficient than Ffile_directory_p and avoids a minor race.
7487
90186c68
LMI
74882011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7489
7c301272
LMI
7490 * buffer.c (Foverlay_put): Say what the return value is
7491 (bug#7835).
7492
c4f2d8d4
LMI
7493 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7494 is a directory before asking whether to use the file name
7495 (bug#7564).
ad637907
LMI
7496 (barf_or_query_if_file_exists): Make the "File is a directory"
7497 error be more correct.
c4f2d8d4 7498
90186c68
LMI
7499 * fns.c (Frequire): Remove the mention of the .gz files, since
7500 that's installation-specific, but keep the mention of
7501 `get-load-suffixes'.
7502
da64016e
PE
75032011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7504
7505 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7506 Report string overflow if the output is too long.
7507
7d47b580
JB
75082011-07-04 Juanma Barranquero <lekktu@gmail.com>
7509
a555cb87
JB
7510 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7511 (syms_of_gnutls): Remove duplicate DEFSYM for
7512 Qgnutls_bootprop_verify_hostname_error, an error for
7513 Qgnutls_bootprop_verify_error (which is no longer used).
7514
7d47b580
JB
7515 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7516 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7517 Also (re)move comments that are misplaced or no longer relevant.
7518
1e49bfab
LMI
75192011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7520
7521 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7522
1485f4c0
CY
75232011-07-03 Chong Yidong <cyd@stupidchicken.com>
7524
7525 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7526 and background color parameters if they have been changed.
7527
a9ab721e
LMI
75282011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7529
7530 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7531
cf7cff57
PE
75322011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7533
2e13213d
PE
7534 * xsettings.c (SYSTEM_FONT): Define only when used.
7535 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7536
cf7cff57
PE
7537 * keymap.c (access_keymap_1): Now static.
7538
7a8e04f7
CY
75392011-07-02 Chong Yidong <cyd@stupidchicken.com>
7540
7541 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7542 leave any prefix arg for the up event (Bug#1586).
7543
61352f62
LMI
75442011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7545
69bb1ef7
LMI
7546 * lread.c (syms_of_lread): Mention single symbols defined by
7547 `defvar' or `defconst' (bug#7154).
7548
61352f62 7549 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7550 (Frequire): Mention get-load-suffixes.
61352f62 7551
28545e04
MR
75522011-07-02 Martin Rudalics <rudalics@gmx.at>
7553
7554 * window.h (window): Remove clone_number slot.
7555 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7556 Remove.
7557 (make_parent_window, make_window, saved_window)
7558 (Fset_window_configuration, save_window_save): Don't deal with
7559 clone numbers.
7560 * buffer.c (Qclone_number): Remove declaration.
7561 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7562
3349e122
SM
75632011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7564
7565 Add multiple inheritance to keymaps.
7566 * keymap.c (Fmake_composed_keymap): New function.
7567 (Fset_keymap_parent): Simplify.
7568 (fix_submap_inheritance): Remove.
7569 (access_keymap_1): New function extracted from access_keymap to handle
7570 embedded parents and handle lists of maps.
7571 (access_keymap): Use it.
7572 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7573 (Fcopy_keymap): Handle embedded parents.
7574 (Fcommand_remapping, define_as_prefix): Simplify.
7575 (Fkey_binding): Simplify.
7576 (syms_of_keymap): Move minibuffer-local-completion-map,
7577 minibuffer-local-filename-completion-map,
7578 minibuffer-local-must-match-map, and
7579 minibuffer-local-filename-must-match-map to Elisp.
7580 (syms_of_keymap): Defsubr make-composed-keymap.
7581 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7582 (parse_menu_item): Trivial simplification.
7583
3279eb87
GM
75842011-07-01 Glenn Morris <rgm@gnu.org>
7585
7586 * Makefile.in (SETTINGS_LIBS): Fix typo.
7587
4550efdf
KI
75882011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7589
7590 * coding.c (Fencode_coding_string): Record the last coding system
7591 used, as the function doc string says (bug#8738).
7592
0949d2b6
JD
75932011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7594
7595 * xsettings.c (store_monospaced_changed): Take new font as arg and
7596 check for change against current_mono_font.
7597 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7598 (emacs_settings_constructor, emacs_settings_get_property)
7599 (emacs_settings_set_property, emacs_settings_class_init)
7600 (emacs_settings_init, gsettings_obj): Remove.
7601 (something_changedCB): New function for HAVE_GSETTINGS.
7602 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7603 with value as argument.
7604 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7605 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7606 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7607 "changed".
7608
7609 * xgselect.c: Add defined (HAVE_GSETTINGS).
7610 (xgselect_initialize): Ditto.
7611
7612 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7613 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7614 xg_select.
7615
bbc6b304
PE
76162011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7617
7618 * eval.c (struct backtrace): Simplify and port the data structure.
7619 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7620 signed bit field, as this assumption is not portable and it makes
7621 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7622 "char debug_on_exit : 1" as this is not portable either; instead,
7623 use the portable "unsigned int debug_on_exit : 1". Remove unused
7624 member evalargs. Remove obsolete comments about cc bombing out.
7625
9851bfc5
JD
76262011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7627
51bb811f 7628 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7629 Let HAVE_GSETTINGS override HAVE_GCONF.
7630 (store_monospaced_changed): New function.
7631 (EMACS_SETTINGS): A new type derived from GObject to handle
7632 GSettings notifications.
7633 (emacs_settings_constructor, emacs_settings_get_property)
7634 (emacs_settings_set_property, emacs_settings_class_init):
7635 New functions.
7636 (gsettings_client, gsettings_obj): New variables.
7637 (GSETTINGS_SCHEMA): New define.
7638 (something_changedCB): Call store_monospaced_changed.
7639 (init_gsettings): New function.
7640 (xsettings_initialize): Call init_gsettings.
7641 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7642 to NULL.
7643
640c8776 7644 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7645 GCONF_CFLAGS/LIBS.
7646
5386012d
MR
76472011-06-29 Martin Rudalics <rudalics@gmx.at>
7648
7649 * window.c (resize_root_window, grow_mini_window)
7650 (shrink_mini_window): Rename Qresize_root_window to
7651 Qwindow_resize_root_window and Qresize_root_window_vertically to
7652 Qwindow_resize_root_window_vertically.
7653
f13e0b08
PE
76542011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7655
7656 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7657
94515237
JB
76582011-06-27 Juanma Barranquero <lekktu@gmail.com>
7659
7660 * makefile.w32-in: Redesign dependencies so they reflect more
7661 clearly which files are directly included by each source file,
7662 and not through other includes.
7663
e43b6e43
MR
76642011-06-27 Martin Rudalics <rudalics@gmx.at>
7665
7666 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7667 (sort_overlays, overlay_strings): When an overlay's clone number
7668 matches the window's clone number process the overlay even if
7669 the overlay's window property doesn't match the current window.
7670
d68443dc
MR
7671 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7672 (Fwindow_hchild): Rename to Fwindow_left_child.
7673 (Fwindow_next): Rename to Fwindow_next_sibling.
7674 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7675 (resize_window_check): Rename to window_resize_check.
7676 (resize_window_apply): Rename to window_resize_apply.
7677 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7678 (Fdelete_other_windows_internal, resize_frame_windows)
7679 (Fsplit_window_internal, Fdelete_window_internal)
7680 (grow_mini_window, shrink_mini_window)
7681 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7682
c7e73be5
JD
76832011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7684
7685 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7686 (emacs_fixed_set_min_size): Remove.
7687 (emacs_fixed_new): Take frame as argument.
7688
7689 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7690 (_EmacsFixedPrivate): Remove minwidth/height.
7691 Add struct frame *f.
7692 (emacs_fixed_init): Initialize priv->f.
7693 (get_parent_class, emacs_fixed_set_min_size): Remove.
7694 (emacs_fixed_new): Set priv->f to argument.
7695 (emacs_fixed_get_preferred_width)
7696 (emacs_fixed_get_preferred_height): Use min_width/height from
7697 frames size_hint to set minimum and natural (Bug#8919).
7698 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7699 and use min_width/height from frames size_hint to set
7700 min_width/height (Bug#8919).
7701
7702 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
7703 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7704 Fix indentation.
c7e73be5 7705
cf99dcf8
EZ
77062011-06-26 Eli Zaretskii <eliz@gnu.org>
7707
7708 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7709 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7710 called at ZV.
7711
029529ac
CY
77122011-06-26 Chong Yidong <cyd@stupidchicken.com>
7713
7714 * process.c (wait_reading_process_output): Bypass select if
7715 waiting for a cell while ignoring keyboard input, and input is
7716 pending. Suggested by Jan Djärv (Bug#8869).
7717
7a7ef429
PE
77182011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7719
7720 Use gnulib's dup2 module instead of rolling our own.
7721 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7722
11fdef7d 77232011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7724
7725 * dispnew.c (scrolling_window): Before scrolling, turn off a
7726 mouse-highlight in the window being scrolled.
7727
cd3520a4
JB
77282011-06-24 Juanma Barranquero <lekktu@gmail.com>
7729
7730 Move DEFSYM to lisp.h and use everywhere.
7731
7732 * character.h (DEFSYM): Move declaration...
7733 * lisp.h (DEFSYM): ...here.
7734
7735 * gnutls.c:
7736 * minibuf.c:
7737 * w32menu.c:
7738 * w32proc.c:
7739 * w32select.c: Don't include character.h.
7740
7741 * alloc.c (syms_of_alloc):
7742 * buffer.c (syms_of_buffer):
7743 * bytecode.c (syms_of_bytecode):
7744 * callint.c (syms_of_callint):
7745 * casefiddle.c (syms_of_casefiddle):
7746 * casetab.c (init_casetab_once):
7747 * category.c (init_category_once, syms_of_category):
7748 * ccl.c (syms_of_ccl):
7749 * cmds.c (syms_of_cmds):
7750 * composite.c (syms_of_composite):
7751 * dbusbind.c (syms_of_dbusbind):
7752 * dired.c (syms_of_dired):
7753 * dispnew.c (syms_of_display):
7754 * doc.c (syms_of_doc):
7755 * editfns.c (syms_of_editfns):
7756 * emacs.c (syms_of_emacs):
7757 * eval.c (syms_of_eval):
7758 * fileio.c (syms_of_fileio):
7759 * fns.c (syms_of_fns):
7760 * frame.c (syms_of_frame):
7761 * fringe.c (syms_of_fringe):
7762 * insdel.c (syms_of_insdel):
7763 * keymap.c (syms_of_keymap):
7764 * lread.c (init_obarray, syms_of_lread):
7765 * macros.c (syms_of_macros):
7766 * msdos.c (syms_of_msdos):
7767 * print.c (syms_of_print):
7768 * process.c (syms_of_process):
7769 * search.c (syms_of_search):
7770 * sound.c (syms_of_sound):
7771 * syntax.c (init_syntax_once, syms_of_syntax):
7772 * terminal.c (syms_of_terminal):
7773 * textprop.c (syms_of_textprop):
7774 * undo.c (syms_of_undo):
7775 * w32.c (globals_of_w32):
7776 * window.c (syms_of_window):
7777 * xdisp.c (syms_of_xdisp):
7778 * xfaces.c (syms_of_xfaces):
7779 * xfns.c (syms_of_xfns):
7780 * xmenu.c (syms_of_xmenu):
7781 * xsettings.c (syms_of_xsettings):
7782 * xterm.c (syms_of_xterm): Use DEFSYM.
7783
4228cf16
TZ
77842011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7785
cd3520a4 7786 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7787
7fcccf1e
PE
77882011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7789
7efb4e0e
PE
7790 Integer and buffer overflow fixes (Bug#8873).
7791
ff5844ad
PE
7792 * print.c (printchar, strout): Check for string overflow.
7793 (PRINTPREPARE, printchar, strout):
7794 Don't set size unless allocation succeeds.
7795
90532f02
PE
7796 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7797 for sizes. Check for string overflow more accurately.
7798 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7799
6d84508d
PE
7800 * macros.c: Integer and buffer overflow fixes.
7801 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7802 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7803 Use ptrdiff_t, not int, for sizes.
7804 Don't increment bufsize until after realloc succeeds.
7805 Check for size-calculation overflow.
7806 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7807
437b2cb4
PE
7808 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7809
8b9ac8b4
PE
7810 * lread.c: Integer overflow fixes.
7811 (read_integer): Radix is now EMACS_INT, not int,
7812 to improve quality of diagnostics for out-of-range radices.
7813 Calculate buffer size correctly for out-of-range radices.
7814 (read1): Check for integer overflow in radices, and in
7815 read-circle numbers.
82cb60d3
PE
7816 (read_escape): Avoid int overflow.
7817 (Fload, openp, read_buffer_size, read1)
7818 (substitute_object_recurse, read_vector, read_list, map_obarray):
7819 Use ptrdiff_t, not int, for sizes.
7820 (read1): Use EMACS_INT, not int, for sizes.
20270765 7821 Check for size overflow.
8b9ac8b4 7822
7fcccf1e
PE
7823 * image.c (cache_image): Check for size arithmetic overflow.
7824
bfbbd7e7
PE
7825 * lread.c: Integer overflow issues.
7826 (saved_doc_string_size, saved_doc_string_length)
7827 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7828 Now ptrdiff_t, not int.
7829 (read1): Don't assume doc string length fits in int. Check for
7830 out-of-range doc string lengths.
7831 (read_list): Don't assume file position fits in int.
39019e54 7832 (read_escape): Check for hex character overflow.
bfbbd7e7 7833
4e323265
LL
78342011-06-22 Leo Liu <sdl.web@gmail.com>
7835
7836 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7837 Move to minibuffer.el.
7838
85fece3e
PE
78392011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7840
20b84ce9 7841 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7842 The following patches are for when GLYPH_DEBUG && !XASSERT.
7843 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7844 * dispnew.c (flush_stdout):
7845 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7846 Mark as externally visible.
7847 * dispnew.c (check_window_matrix_pointers): Now static.
7848 * dispnew.c (window_to_frame_vpos):
7849 * xfns.c (unwind_create_frame):
7850 * xterm.c (x_check_font): Remove unused local.
7851 * scroll.c (CHECK_BOUNDS):
7852 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7853 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7854 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7855 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7856 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7857 Now static.
7858 (debug_method_add): Use va_list and vsprintf rather than relying
7859 on undefined behavior with wrong number of arguments.
7860 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7861 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7862 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7863 since we're not interested in debugging glyphs with old libraries.
7864 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7865 GCC 4.6.0's static checking.
7866
0766b489
PE
78672011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7868
31fd4b32
PE
7869 Integer overflow and signedness fixes (Bug#8873).
7870 A few related buffer overrun fixes, too.
7871
b79e8648
PE
7872 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7873
0766b489
PE
7874 * dispextern.h (struct face.stipple):
7875 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7876 (x_bitmap_mask, x_allocate_bitmap_record)
7877 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7878 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7879 (x_create_bitmap_from_xpm_data):
7880 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7881 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7882 (.bitmaps_last):
7883 * xfaces.c (load_pixmap):
7884 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7885 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7886 (.bitmaps_last, struct x_output.icon_bitmap):
7887 Use ptrdiff_t, not int, for bitmap indexes.
7888 (x_allocate_bitmap_record): Check for size overflow.
7889 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7890
b081724f
PE
7891 Use ptrdiff_t, not int, for overlay counts.
7892 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7893 * editfns.c (overlays_around, get_pos_property):
7894 * textprop.c (get_char_property_and_overlay):
7895 * xdisp.c (next_overlay_change, note_mouse_highlight):
7896 * xfaces.c (face_at_buffer_position):
21514da7
PE
7897 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7898 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7899 (Fnext_overlay_change, Fprevious_overlay_change)
7900 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7901 Use ptrdiff_t, not int, for sizes.
21514da7 7902 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7903
3de73e5e
PE
7904 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7905
2606c57b
PE
7906 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7907 (x_session_initialize): Do not assume string length fits in int.
7908
aaafe47a
PE
7909 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7910 This is unlikely, but can occur if DPI is outlandish.
7911
2674ddc8 7912 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7913 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7914
28154962
PE
7915 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7916 * xrdb.c (magic_file_p, search_magic_path):
7917 Omit last arg SUFFIX; it was always 0. All callers changed.
7918 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7919
7de51af5
PE
7920 * xfont.c (xfont_match): Avoid need for strlen.
7921
25ed6cc3
PE
7922 * xfns.c: Don't assume strlen fits in int.
7923 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7924
4eab31dd
PE
7925 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7926 not unsigned long, as we prefer signed integers. All callers changed.
7927 Detect integer overflow in repeat count.
7928 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7929 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7930
171e2a58
PE
7931 * termcap.c: Don't assume sizes fit in int and never overflow.
7932 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7933 (gobble_line): Check for size-calculation overflow.
7934
ad39faca 7935 * minibuf.c (Fread_buffer):
6e5bb2dc 7936 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7937 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7938 Don't assume string length fits in int.
7939
52c61c22 7940 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7941 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7942
b5b8c9e5
PE
7943 * font.c: Don't assume string length fits in int.
7944 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7945 Use ptrdiff_t, not int.
ccd6111c
PE
7946 (font_intern_prop): Don't assume string length fits in int.
7947 Don't assume integer property fits in fixnum.
7948 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7949
882f0d81 7950 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7951 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7952 Reformulate so as not to need the command string.
7953 Invoke gzip -cd rather than gunzip, as it's more portable.
7954 (lock_info_type, lock_file_1, lock_file):
7955 Don't assume pid_t and time_t fit in unsigned long.
7956 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7957 (current_lock_owner): Prefer signed type for sizes.
7958 Use memcpy, not strncpy, where memcpy is what is really wanted.
7959 Don't assume (via atoi) that time_t and pid_t fit in int.
7960 Check for time_t and/or pid_t out of range, e.g., via a network share.
7961 Don't alloca where an auto var works fine.
7962
93f4cf88
PE
7963 * fileio.c: Fix some integer overflow issues.
7964 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7965 Don't assume string length fits in int.
7966 (directory_file_name): Don't assume string length fits in long.
7967 (make_temp_name): Don't assume pid fits in int, or that its print
7968 length is less than 20.
7969
f3e92b69
PE
7970 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7971
1bfdaf10
PE
7972 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7973
35016e9a
PE
7974 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7975
3d1e65a1
PE
7976 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7977 We prefer signed integers, even for size calculations.
7978
0b963a93
PE
7979 * emacs.c: Don't assume string length fits in 'int'.
7980 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7981 (main): Don't invoke strlen when not needed.
7982
573f4b54
PE
7983 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7984 (XD_DEBUG_MESSAGE): Don't waste a byte.
7985
989f33ba
PE
7986 * callproc.c (getenv_internal_1, getenv_internal)
7987 (Fgetenv_internal):
965d34eb
PE
7988 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7989
e4d29b33
PE
7990 * lread.c (invalid_syntax): Omit length argument.
7991 All uses changed. This doesn't fix a bug, but it simplifies the
7992 code away from its former Hollerith-constant appearance, and it's
7993 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7994 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7995
eb49b136
PE
7996 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7997 This didn't break anything, but it didn't help either.
7998 It's confusing to put a bogus integer in a place where the actual
7999 value does not matter.
9f62aeb1 8000 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8001 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8002
15375a22
PE
8003 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8004 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8005 implementation.
b61cc01c
PE
8006 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8007 We prefer signed types, and the value cannot exceed the EMACS_INT
8008 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8009 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8010 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8011 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8012
53b2623d
PE
8013 * indent.c (sane_tab_width): New function.
8014 (current_column, scan_for_column, Findent_to, position_indentation)
8015 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8016 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8017
51cab52b 8018 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8019
f2ed8a70
PE
8020 * lisp.h (lint_assume): New macro.
8021 * composite.c (composition_gstring_put_cache):
8022 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8023
abe80cc6
PE
8024 * editfns.c, insdel.c:
8025 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8026
b02c740e
PE
8027 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8028
ebc96716
PE
8029 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8030
b4e50fa0 8031 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8032 Use much-faster test for byte-length change.
311d5d7c 8033 Don't assume string byte-length fits in 'int'.
a4cf38e4 8034 Check that character arg fits in 'int'.
85461888 8035 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8036
c0c1ee9f
PE
8037 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8038
a498d7f4
PE
8039 * fns.c (concat): Catch string overflow earlier.
8040 Do not rely on integer wraparound.
8041
51cab52b
PE
8042 * dispextern.h (struct it.overlay_strings_charpos)
8043 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8044 * xdisp.c (forward_to_next_line_start)
8045 (back_to_previous_visible_line_start)
8046 (reseat_at_next_visible_line_start, next_element_from_buffer):
8047 Don't arbitrarily truncate the value of 'selective' to int.
8048
76031fad
PE
8049 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8050
5eb55db9
PE
8051 * composite.c: Don't truncate sizes to 'int'.
8052 (composition_gstring_p, composition_reseat_it)
8053 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8054 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8055 not EMACS_UINT, for indexes.
5eb55db9 8056
0703a717
PE
8057 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8058
d6202519
PE
8059 * buffer.c: Include <verify.h>.
8060 (struct sortvec.priority, struct sortstr.priority):
8961a454 8061 Now EMACS_INT, not int.
c20998a7 8062 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8063 (struct sortstr.size, record_overlay_string)
8064 (struct sortstrlist.size, struct sortlist.used):
8065 Don't truncate size to int.
8066 (record_overlay_string): Check for size-calculation overflow.
d6202519 8067 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8068
d5a19415
JM
80692011-06-22 Jim Meyering <meyering@redhat.com>
8070
029529ac 8071 Don't leak an XBM-image-sized buffer
d5a19415
JM
8072 * image.c (xbm_load): Free the image buffer after using it.
8073
a9041e6c
PE
80742011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8075
8076 Port to Sun C.
8077 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8078 that Sun C diagnosed.
8079 * fns.c (secure_hash): Fix pointer signedness issue.
8080 * intervals.c (static_offset_intervals): New function.
8081 (offset_intervals): Use it.
8082
7f3f739f
LL
80832011-06-21 Leo Liu <sdl.web@gmail.com>
8084
8085 * deps.mk (fns.o):
8086 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8087 sha512.h.
8088
8089 * fns.c (secure_hash): Rename from crypto_hash_function and change
8090 the first arg to accept symbols.
5b66d427 8091 (Fsecure_hash): New primitive.
7f3f739f
LL
8092 (syms_of_fns): New symbols.
8093
76147d94
DD
80942011-06-20 Deniz Dogan <deniz@dogan.se>
8095
8096 * process.c (Fset_process_buffer): Clarify return value in
8097 docstring.
8098
7d7d0045
CY
80992011-06-18 Chong Yidong <cyd@stupidchicken.com>
8100
8101 * dispnew.c (add_window_display_history): Use BVAR.
8102
8103 * xdisp.c (debug_method_add): Use BVAR.
8104 (check_window_end, dump_glyph_matrix, dump_glyph)
8105 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8106
8107 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8108 Likewise.
8109
8110 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8111 check till after the cache is created in init_frame_faces.
8112
ff2bc410
SM
81132011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8114
8115 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8116
28177add
PE
81172011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8118
dd3482fe
PE
8119 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8120 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8121 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8122
393d71f3 8123 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8124 * fileio.c (Finsert_file_contents):
8125 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8126 Remove the old (too-loose) buffer overflow checks.
8127 They weren't needed, since make_gap checks for buffer overflow.
8128 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8129 The old code merely checked for Emacs fixnum overflow, and relied
8130 on undefined (wraparound) behavior. The new code avoids undefined
8131 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8132
2e6813b0 8133 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8134 Tune. Don't use wider integers than needed. Don't use alloca.
8135 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8136
599a9e4f
PE
8137 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8138
99561444
PE
8139 * insdel.c, lisp.h (buffer_overflow): New function.
8140 (insert_from_buffer_1, replace_range, replace_range_2):
8141 * insdel.c (make_gap_larger):
8142 * editfns.c (Finsert_char):
8143 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8144
28177add
PE
8145 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8146
e69dafad
PE
81472011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8148
4baa020d 8149 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8150
b1c46f02
PE
8151 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8152 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8153
e69dafad
PE
8154 * fileio.c: Don't assume EMACS_INT fits in off_t.
8155 (emacs_lseek): New static function.
8156 (Finsert_file_contents, Fwrite_region): Use it.
8157 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8158
566684ea
PE
8159 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8160
e6966cd6
PE
8161 * fns.c: Don't overflow int when computing a list length.
8162 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8163 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8164 truncation on 64-bit hosts. Check for QUIT every
8165 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8166 faster and is responsive enough.
8167 (Flength): Report an error instead of overflowing an integer.
8168 (Fsafe_length): Return a float if the value is not representable
8169 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8170 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8171 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8172
dd0b0efb
PE
8173 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8174 (header_size, word_size): New constants.
8175 (allocate_vectorlike): Don't check size overflow here.
8176 (allocate_vector): Check it here instead, since this is the only
8177 caller of allocate_vectorlike that could cause overflow.
8178 Check that the new vector's length is representable as a fixnum.
8179
86fe5cfe
PE
8180 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8181 The previous code was bogus. For example, next_almost_prime (32)
8182 returned 39, which is undesirable as it is a multiple of 3; and
8183 next_almost_prime (24) returned 25, which is a multiple of 5 so
8184 why was the code bothering to check for multiples of 7?
8185
80e88859
PE
8186 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8187
4a2f0ad6
PE
8188 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8189
f66c7cf8
PE
8190 Variadic C functions now count arguments with ptrdiff_t.
8191 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8192 Back then I didn't know that the Emacs coding style prefers signed int.
8193 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8194 were being counted with int, which may truncate counts on 64-bit
8195 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8196 * lisp.h (struct Lisp_Subr.function.aMANY)
8197 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8198 Arg counts are now ptrdiff_t, not size_t.
8199 All variadic functions and their callers changed accordingly.
8200 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8201 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8202 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8203 * callint.c (Fcall_interactively): Check arg count for overflow,
8204 to avoid potential buffer overrun. Use signed char, not 'int',
8205 for 'varies' array, so that we needn't bother to check its size
8206 calculation for overflow.
8207 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8208 * eval.c (apply_lambda):
8209 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8210 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8211 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8212
a1759b76
PE
8213 * callint.c (Fcall_interactively): Don't use index var as event count.
8214
d96be9fc
PE
8215 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8216 * mem-limits.h (SIZE): Remove; no longer used.
8217
a690a978 8218 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8219
578c21e6
PE
8220 Remove unnecessary casts.
8221 * xterm.c (x_term_init):
8222 * xfns.c (x_set_border_pixel):
8223 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8224 These aren't needed now that we assume ANSI C.
8225
96f53c6c
PE
8226 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8227 It's more likely to cause problems (due to unsigned overflow)
8228 than to cure them.
8229
83c77d31
PE
8230 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8231
ee2079f1
PE
8232 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8233
6da65536
PE
8234 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8235
7147c4a4
PE
8236 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8237
193e32d9
PE
8238 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8239
e5533da6
PE
8240 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8241
9910e595
PE
8242 GLYPH_CODE_FACE returns EMACS_INT, not int.
8243 * dispextern.h (merge_faces):
8244 * xfaces.c (merge_faces):
01103c44
PE
8245 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8246 Don't assume EMACS_INT fits in int.
9910e595 8247
2638320e
PE
8248 * character.h (CHAR_VALID_P): Remove unused parameter.
8249 * fontset.c, lisp.h, xdisp.c: All uses changed.
8250
045eb8d9
PE
8251 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8252
c1f134b5
PE
8253 * fns.c (concat): Minor tuning based on overflow analysis.
8254 This doesn't fix any bugs. Use int to hold character, instead
8255 of constantly refetching from Emacs object. Use XFASTINT, not
8256 XINT, for value known to be a character. Don't bother comparing
8257 a single byte to 0400, as it's always less.
8258
395fcb93 8259 * floatfns.c (Fexpt):
327eeec8
PE
8260 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8261
abbd3d23
PE
8262 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8263 for characters.
8264
684a03ef
PE
8265 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8266
0fed43f3
PE
8267 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8268 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8269 incorrectly succeed when S was a string, because 4294967386 was
8270 truncated before it was used.
8271
8fd02eb7
PE
8272 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8273 Otherwise, an out-of-range integer could cause undefined behavior
8274 on a 64-bit host.
8275
f8c86b69
PE
8276 * composite.c: Use int, not EMACS_INT, for characters.
8277 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8278 EMACS_INT, for values that are known to be in character range.
8279 This doesn't fix any bugs but is the usual style inside Emacs and
8280 may generate better code on 32-bit machines.
8281
34206dd2
PE
8282 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8283 This is for reasons similar to the recent CHAR_STRING fix.
8284 * charset.c (Fencode_char): Check that character arg is actually
8285 a character. Pass an int to ENCODE_CHAR.
8286 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8287 wider than 'int', as a compile-time check to prevent future regressions
8288 in this area.
8289
c5958d4c 8290 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8291
8292 Make sure a 64-bit char is never passed to CHAR_STRING.
8293 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8294 by silently ignoring the top 32 bits, allowing some values
8295 that were far too large to be valid characters.
8296 * character.h: Include <verify.h>.
8297 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8298 arguments are no wider than unsigned, as a compile-time check
8299 to prevent future regressions in this area.
8300 * data.c (Faset):
01103c44 8301 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8302 (Fsubst_char_in_region):
8303 * fns.c (concat):
8304 * xdisp.c (decode_mode_spec_coding):
8305 Adjust to CHAR_STRING's new requirement.
8306 * editfns.c (Finsert_char, Fsubst_char_in_region):
8307 * fns.c (concat): Check that character args are actually
8308 characters. Without this test, these functions did the wrong
8309 thing with wildly out-of-range values on 64-bit hosts.
8310
d37ca623
PE
8311 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8312 These casts should not be needed on 32-bit hosts, either.
8313 * keyboard.c (read_char):
8314 * lread.c (Fload): Remove casts to unsigned.
8315
ea204efb
PE
8316 * lisp.h (UNSIGNED_CMP): New macro.
8317 This fixes comparison bugs on 64-bit hosts.
8318 (ASCII_CHAR_P): Use it.
8319 * casefiddle.c (casify_object):
01103c44 8320 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8321 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8322 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8323 * dispextern.h (FACE_FROM_ID):
8324 * keyboard.c (read_char): Use UNSIGNED_CMP.
8325
41cb286c
PE
8326 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8327 not to EMACS_INT, to avoid GCC warning.
8328
4a1b9832
PE
8329 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8330
55daad71
PE
8331 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8332 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8333 isn't needed on 32-bit machines.
8f95c75c 8334
01103c44
PE
8335 * buffer.c (Fgenerate_new_buffer_name):
8336 Use EMACS_INT for count, not int.
0ceccced 8337 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
8338
8339 * data.c (Qcompiled_function): Now static.
8340
c6f072e7
PE
8341 * window.c (window_body_lines): Now static.
8342
20ce5912
PE
8343 * image.c (gif_load): Rename local to avoid shadowing.
8344
9c4c5f81
PE
8345 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8346 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8347 * alloc.c (make_save_value): Integer argument is now of type
8348 ptrdiff_t, not int.
8349 (mark_object): Use ptrdiff_t, not int.
8350 * lisp.h (pD): New macro.
8351 * print.c (print_object): Use it.
8352
c0c5c8ae
PE
8353 * alloc.c: Use EMACS_INT, not int, to count objects.
8354 (total_conses, total_markers, total_symbols, total_vector_size)
8355 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
8356 (total_free_floats, total_floats, total_free_intervals)
8357 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
8358 Now EMACS_INT, not int. All uses changed.
8359 (Fgarbage_collect): Compute overall total using a double, so that
8360 integer overflow is less likely to be a problem. Check for overflow
8361 when converting back to an integer.
5a25e253
PE
8362 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8363 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8364 These were 'int' variables that could overflow on 64-bit hosts;
8365 they were never used, so remove them instead of repairing them.
211a0b2a 8366 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
8367 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8368 Previously, this ceilinged at INT_MAX, but that doesn't work on
8369 64-bit machines.
e46bb31a 8370 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 8371
c78baabf 8372 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 8373 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
8374 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8375 when a (possibly-narrower) signed value would do just as well.
8376 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 8377
c9d624c6
PE
8378 * alloc.c: Catch some string size overflows that we were missing.
8379 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8380 for convenience in STRING_BYTES_MAX.
8381 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8382 The definition here is exact; the one in lisp.h was approximate.
8383 (allocate_string_data): Check for string overflow. This catches
8384 some instances we weren't catching before. Also, it catches
8385 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8386 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8387 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 8388
c9d624c6
PE
8389 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8390 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 8391 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 8392
353032ce
PE
8393 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8394
2bccce07
PE
8395 * alloc.c (Fmake_string): Check for out-of-range init.
8396
0ac30604
SM
83972011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8398
8399 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8400
c195f2de
JD
84012011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8402
8403 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8404 xg_get_default_scrollbar_width.
8405
8406 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8407 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8408 (style_changed_cb): Call update_theme_scrollbar_width and call
8409 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8410 all frames (Bug#8505).
8411 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8412 Call gtk_window_set_resizable if HAVE_GTK3.
8413 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8414 and height if HAVE_GTK3 (Bug#8505).
8415 (scroll_bar_width_for_theme): New variable.
8416 (update_theme_scrollbar_width): New function.
8417 (xg_get_default_scrollbar_width): Move code to
8418 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8419 (xg_initialize): Call update_theme_scrollbar_width.
8420
8421 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8422
8423 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8424
e10ac9f1
MR
84252011-06-12 Martin Rudalics <rudalics@gmx.at>
8426
8427 * frame.c (make_frame): Call other_buffer_safely instead of
8428 other_buffer.
8429
8430 * window.c (temp_output_buffer_show): Call display_buffer with
8431 second argument Vtemp_buffer_show_specifiers and reset latter
8432 immediately after the call.
8433 (Vtemp_buffer_show_specifiers): New variable.
8434 (auto_window_vscroll_p, next_screen_context_lines)
8435 (Vscroll_preserve_screen_position): Remove leading asterisks from
8436 doc-strings.
8437
2d3c217e 84382011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8439
7b7f97e8 8440 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8441 * buffer.c (Qclone_number): Remove for now, as it's unused.
8442 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8443 (record_buffer): Remove unused local.
8444 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8445 (set_frame_buffer_list): Remove; unused.
8446 * frame.h (other_visible_frames): Remove decl.
8447 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8448 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8449 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8450 if HAVE_GPM.
8451 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8452 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8453 Define only if HAVE_GPM.
8454 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8455 (update_hints_inhibit): Remove; never set. All uses removed.
8456 * widgetprv.h (emacsFrameClassRec): Remove decl.
8457 * window.c (delete_deletable_window): Now returns void, since it
8458 wasn't returning anything.
8459 (compare_window_configurations): Remove unused locals.
8460 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8461 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8462 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8463 the same widths as pointers. This follows up on the 2011-05-06 patch.
8464 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8465 * xterm.h: Likewise.
8466 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8467
1384b89e
JB
84682011-06-12 Juanma Barranquero <lekktu@gmail.com>
8469
8470 * makefile.w32-in: Update dependencies.
8471 (LISP_H): Add lib/intprops.h.
8472
1100a63c
CY
84732011-06-11 Chong Yidong <cyd@stupidchicken.com>
8474
8475 * image.c (gif_load): Add animation frame delay to the metadata.
8476 (syms_of_image): Use DEFSYM. New symbol `delay'.
8477
6198ccd0
MR
84782011-06-11 Martin Rudalics <rudalics@gmx.at>
8479
8480 * window.c (delete_deletable_window): Re-add.
8481 (Fset_window_configuration): Rewrite to handle dead buffers and
8482 consequently deletable windows.
8483 (window_tree, Fwindow_tree): Remove. Supply functionality in
8484 window.el.
8485 (compare_window_configurations): Simplify code.
8486
b6e3633c
AS
84872011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8488
1ab0dee5
AS
8489 * image.c (imagemagick_load_image): Fix type mismatch.
8490 (Fimagemagick_types): Likewise.
8491
b6e3633c
AS
8492 * window.h (replace_buffer_in_windows): Declare.
8493
9397e56f
MR
84942011-06-11 Martin Rudalics <rudalics@gmx.at>
8495
8496 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8497 Qclone_number. Remove external declaration of Qdelete_window.
8498 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8499 code.
640c8776
SM
8500 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8501 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8502 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8503 buffer list implementation.
8504 (other_buffer_safely): New function.
8505 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8506 calls to replace_buffer_in_windows and
8507 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8508 if allowed.
8509 (record_buffer): Inhibit quitting and rewrite using quittable
8510 functions. Run Qbuffer_list_update_hook if allowed.
8511 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
8512 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8513 Move switch-to-buffer to window.el.
9397e56f
MR
8514 (bury-buffer): Move to window.el.
8515 (Vbuffer_list_update_hook): New variable.
8516
8517 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8518 section.
8519
8520 * window.h (resize_frame_windows): Move up in code.
8521 (Fwindow_frame): Remove EXFUN.
8522 (replace_buffer_in_all_windows): Remove prototype.
8523 (replace_buffer_in_windows_safely): Add prototype.
8524
8525 * window.c: Declare Qdelete_window static again. Move down
8526 declaration of select_count.
8527 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8528 (Fother_window): Move to window.el.
8529 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8530 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8531 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8532 window.el.
8533 (replace_buffer_in_windows): Implement by calling
8534 Qreplace_buffer_in_windows.
8535 (replace_buffer_in_all_windows): Remove with some functionality
8536 moved into replace_buffer_in_windows_safely.
8537 (replace_buffer_in_windows_safely): New function.
8538 (select_window_norecord, select_frame_norecord): Move in front
8539 of run_window_configuration_change_hook. Remove now obsolete
8540 declarations.
640c8776
SM
8541 (Fset_window_buffer): Rewrite doc-string.
8542 Call Qrecord_window_buffer.
9397e56f
MR
8543 (keys_of_window): Move binding for other-window to window.el.
8544
b50691aa
CY
85452011-06-11 Chong Yidong <cyd@stupidchicken.com>
8546
8547 * dispextern.h (struct image): Replace data member, whose int_val
8548 and ptr_val fields were not used by anything, with a single
8549 lisp_val object.
8550
8551 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8552 (gif_clear_image, gif_load, imagemagick_load_image)
8553 (gs_clear_image, gs_load): Callers changed.
8554
3f754b86
PE
85552011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8556
cca69397
PE
8557 * buffer.h: Include <time.h>, for time_t.
8558 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8559
109e28d0
PE
8560 Fix minor problems found by static checking.
8561
60737f02
PE
8562 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8563
4b66faf3
PE
8564 Make identifiers static if they are not used in other modules.
8565 * data.c (Qcompiled_function, Qframe, Qvector):
8566 * image.c (QimageMagick, Qsvg):
8567 * minibuf.c (Qmetadata):
8568 * window.c (resize_window_check, resize_root_window): Now static.
8569 * window.h (resize_window_check, resize_root_window): Remove decls.
8570
109e28d0
PE
8571 * window.c (window_deletion_count, delete_deletable_window):
8572 Remove; unused.
46a4ce9e
PE
8573 (window_body_lines): Now static.
8574 (Fdelete_other_windows_internal): Mark vars as initialized.
8575 Make sure 'resize_failed' is initialized.
8576 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8577 (resize_window_apply): Remove unused local.
8578 * window.h (delete_deletable_window): Remove decl.
8579
109e28d0 8580 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8581 (imagemagick_load_image): Fix pointer signedness problem by changing
8582 last arg from unsigned char * to char *. All uses changed.
8583 Also, fix a local for similar reasons.
8584 Remove unused locals. Remove locals to avoid shadowing.
8585 (fn_rsvg_handle_free): Remove; unused.
8586 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8587 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8588
3f754b86
PE
8589 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8590
2547adb1
CY
85912011-06-10 Chong Yidong <cyd@stupidchicken.com>
8592
8593 * image.c (gif_load): Fix omitted cast error introduced by
8594 2011-06-06 change.
8595
2c8e37d4
MR
85962011-06-10 Martin Rudalics <rudalics@gmx.at>
8597
8598 * window.h (resize_proportionally, orig_total_lines)
8599 (orig_top_line): Remove from window structure.
8600 (set_window_height, set_window_width, change_window_heights)
8601 (Fdelete_window): Remove prototypes.
8602 (resize_frame_windows): Remove duplicate declaration.
8603
440a42e3
EZ
86042011-06-10 Eli Zaretskii <eliz@gnu.org>
8605
8606 * window.h (resize_frame_windows, resize_window_check)
8607 (delete_deletable_window, resize_root_window)
8608 (resize_frame_windows): Declare prototypes.
8609
8610 * window.c (resize_window_apply): Make definition be "static" to
8611 match the prototype.
8612
562dd5e9
MR
86132011-06-10 Martin Rudalics <rudalics@gmx.at>
8614
8615 * window.c: Remove declarations of Qwindow_size_fixed,
8616 window_min_size_1, window_min_size_2, window_min_size,
8617 size_window, window_fixed_size_p, enlarge_window, delete_window.
8618 Remove static from declaration of Qdelete_window, it's
8619 temporarily needed by Fbury_buffer.
8620 (replace_window): Don't assign orig_top_line and
8621 orig_total_lines.
8622 (Fdelete_window, delete_window): Remove. Window deletion is
8623 handled by window.el.
640c8776
SM
8624 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8625 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8626 (Fdelete_other_windows): Remove. Deleting other windows is
8627 handled by window.el.
8628 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8629 handled in window.el.
8630 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8631 Window minimum sizes are handled in window.el.
8632 (shrink_windows, size_window, set_window_height)
8633 (set_window_width, change_window_heights, window_height)
8634 (window_width, CURBEG, CURSIZE, enlarge_window)
8635 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8636 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8637 handled in window.el.
8638 (make_dummy_parent): Rename to make_parent_window and give it a
8639 second argument horflag.
8640 (make_window): Don't set resize_proportionally any more.
8641 (Fsplit_window): Remove. Windows are split in window.el.
8642 (save_restore_action, save_restore_orig_size)
8643 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8644 Resize mini windows in window.el.
8645 (grow_mini_window, shrink_mini_window): Implement by calling
8646 Qresize_root_window_vertically, resize_window_check and
8647 resize_window_apply.
640c8776
SM
8648 (saved_window, Fset_window_configuration, save_window_save):
8649 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8650 resize_proportionally.
8651 (window_min_height, window_min_width): Move to window.el.
8652 (keys_of_window): Move bindings for delete-other-windows,
8653 split-window, delete-window and enlarge-window to window.el.
8654
8655 * buffer.c: Temporarily extern Qdelete_window.
8656 (Fbury_buffer): Temporarily call Qdelete_window instead of
8657 Fdelete_window (Fbury_buffer will move to window.el soon).
8658
8659 * frame.c (set_menu_bar_lines_1): Remove code handling
8660 orig_top_line and orig_total_lines.
8661
8662 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8663 set_window_height but set heights directly.
8664 (change_frame_size_1): Use resize_frame_windows.
8665
8666 * xdisp.c (init_xdisp): Don't use set_window_height but set
8667 heights directly.
8668
640c8776
SM
8669 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8670 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8671 run_window_configuration_change_hook.
8672
8673 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8674 instead of change_window_heights and run
8675 run_window_configuration_change_hook.
8676
1a13852e
MR
86772011-06-09 Martin Rudalics <rudalics@gmx.at>
8678
8679 * window.c (replace_window): Rename second argument REPLACEMENT to
8680 NEW. New third argument SETFLAG. Rewrite.
8681 (delete_window, make_dummy_parent): Call replace_window with
8682 third argument 1.
8683 (window_list_1): Move down in code.
8684 (run_window_configuration_change_hook): Move set_buffer part
8685 before select_frame_norecord part in order to unwind correctly.
8686 Rename count1 to count.
8687 (recombine_windows, delete_deletable_window, resize_root_window)
8688 (Fdelete_other_windows_internal)
8689 (Frun_window_configuration_change_hook, make_parent_window)
8690 (resize_window_check, resize_window_apply, Fresize_window_apply)
8691 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8692 (Fdelete_window_internal, Fresize_mini_window_internal):
8693 New functions.
1a13852e
MR
8694 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8695
f3d1777e
MR
86962011-06-08 Martin Rudalics <rudalics@gmx.at>
8697
496e208e
MR
8698 * window.h (window): Add some new members to window structure -
8699 normal_lines, normal_cols, new_total, new_normal, clone_number,
8700 splits, nest, prev_buffers, next_buffers.
8701 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 8702 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 8703
f3d1777e
MR
8704 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8705 Remove.
496e208e
MR
8706 (make_dummy_parent): Set new members of windows structure.
8707 (make_window): Move down in code. Handle new members of window
8708 structure.
8709 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8710 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8711 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8712 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
8713 (Fset_window_next_buffers, Fset_window_clone_number):
8714 New functions.
496e208e
MR
8715 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8716 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8717 Doc-string fixes.
8718 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8719 Argument WINDOW can be now internal window too.
8720 (Fwindow_use_time): Move up in code.
8721 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8722 Rewrite doc-string.
8723 (Fset_window_configuration, saved_window)
8724 (Fcurrent_window_configuration, save_window_save): Handle new
8725 members of window structure.
b9e809c2
MR
8726 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8727 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8728 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8729 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8730 Qget_mru_window, Qresize_root_window,
8731 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8732 Qauto_buffer_name; staticpro them.
f3d1777e 8733
abde8f8c
MR
87342011-06-07 Martin Rudalics <rudalics@gmx.at>
8735
8736 * window.c (Fwindow_total_size, Fwindow_left_column)
8737 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8738 (Fwindow_list_1): New functions.
8739 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
8740 (Fwindow_width, Fscroll_left, Fscroll_right):
8741 Use window_body_cols instead of window_box_text_cols.
8742 (delete_window, Fset_window_configuration):
8743 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
8744 (delete_all_subwindows): Take a window as argument and not a
8745 structure. Rewrite.
190b47e6
MR
8746 (window_loop): Remove handling of GET_LRU_WINDOW and
8747 GET_LARGEST_WINDOW.
8748 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
8749
8750 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
8751 window_box_text_cols. delete_all_subwindows now takes a
8752 Lisp_Object as argument.
abde8f8c 8753
640c8776
SM
8754 * indent.c (compute_motion, Fcompute_motion):
8755 Use window_body_cols instead of window_box_text_cols.
abde8f8c 8756
fa8a67e6
MR
8757 * frame.c (delete_frame): Call delete_all_subwindows with root
8758 window as argument.
8759
a54e3482
DC
87602011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8761
8762 * fns.c (Fputhash): Document return value.
8763
60002bf5
CY
87642011-06-06 Chong Yidong <cyd@stupidchicken.com>
8765
8766 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8767
0c671da6 87682011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8769
b862a52a 8770 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8771
be44ca6c
PE
8772 Check for overflow when converting integer to cons and back.
8773 * charset.c (Fdefine_charset_internal, Fdecode_char):
8774 Use cons_to_unsigned to catch overflow.
8775 (Fencode_char): Use INTEGER_TO_CONS.
8776 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8777 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8778 * data.c (long_to_cons, cons_to_long): Remove.
8779 (cons_to_unsigned, cons_to_signed): New functions.
8780 These signal an error for invalid or out-of-range values.
8781 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8782 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8783 * font.c (Ffont_variation_glyphs):
8784 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8785 * lisp.h: Include <intprops.h>.
8786 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8787 (cons_to_signed, cons_to_unsigned): New decls.
8788 (long_to_cons, cons_to_long): Remove decls.
8789 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8790 (Fprimitive_undo): Use CONS_TO_INTEGER.
8791 * xfns.c (Fx_window_property): Likewise.
8792 * xselect.c: Include <limits.h>.
8793 (x_own_selection, selection_data_to_lisp_data):
8794 Use INTEGER_TO_CONS.
8795 (x_handle_selection_request, x_handle_selection_clear)
8796 (x_get_foreign_selection, Fx_disown_selection_internal)
8797 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8798 (lisp_data_to_selection_data): Use cons_to_unsigned.
8799 (x_fill_property_data): Use cons_to_signed.
8800 Report values out of range.
8801
d1f3d2af
PE
8802 Check for buffer and string overflow more precisely.
8803 * buffer.h (BUF_BYTES_MAX): New macro.
8804 * lisp.h (STRING_BYTES_MAX): New macro.
8805 * alloc.c (Fmake_string):
8806 * character.c (string_escape_byte8):
8807 * coding.c (coding_alloc_by_realloc):
8808 * doprnt.c (doprnt):
8809 * editfns.c (Fformat):
8810 * eval.c (verror):
8811 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8812 since they may not be the same number.
8813 * editfns.c (Finsert_char):
8814 * fileio.c (Finsert_file_contents):
8815 Likewise for BUF_BYTES_MAX.
8816
dd52fcea
PE
8817 * image.c: Use ptrdiff_t, not int, for sizes.
8818 (slurp_file): Switch from int to ptrdiff_t.
8819 All uses changed.
8820 (slurp_file): Check that file size fits in both size_t (for
8821 malloc) and ptrdiff_t (for sanity and safety).
8822
7f9bbdbb
PE
8823 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8824 if b->modtime has its maximal value.
8825
dfe18f82
PE
8826 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8827
84acfcf0
PE
8828 Don't assume time_t can fit into int.
8829 * buffer.h (struct buffer.modtime): Now time_t, not int.
8830 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8831 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8832
ccd9a01a
PE
8833 Minor fixes for signed vs unsigned integers.
8834 * character.h (MAYBE_UNIFY_CHAR):
8835 * charset.c (maybe_unify_char):
8836 * keyboard.c (read_char, reorder_modifiers):
8837 XINT -> XFASTINT, since the integer must be nonnegative.
8838 * ftfont.c (ftfont_spec_pattern):
8839 * keymap.c (access_keymap, silly_event_symbol_error):
8840 XUINT -> XFASTINT, since the integer must be nonnegative.
8841 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8842 since it makes no difference and we prefer signed.
8843 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8844 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8845 nonnegative.
8846
d6d100dd
SM
88472011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8848
8849 * window.h (Fwindow_frame): Declare.
8850
2b6148e4
PE
88512011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8852
8853 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8854 (SPARE_MEMORY): Always define.
8855 (LARGE_REQUEST): Remove.
8856 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8857
f230ecc9
MR
88582011-06-06 Martin Rudalics <rudalics@gmx.at>
8859
727e958e
MR
8860 * lisp.h: Move EXFUNS for Fframe_root_window,
8861 Fframe_first_window and Fset_frame_selected_window to window.h.
8862
8863 * window.h: Move EXFUNS for Fframe_root_window,
8864 Fframe_first_window and Fset_frame_selected_window here from
8865 lisp.h.
8866
8867 * frame.c (Fwindow_frame, Fframe_first_window)
8868 (Fframe_root_window, Fframe_selected_window)
8869 (Fset_frame_selected_window): Move to window.c.
8870 (Factive_minibuffer_window): Move to minibuf.c.
8871 (Fother_visible_frames_p): New function.
8872
8873 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8874
f230ecc9
MR
8875 * window.c (decode_window, decode_any_window): Move up in code.
8876 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8877 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8878 (Fwindow_buffer): Move up and rewrite doc-string.
8879 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8880 (Fwindow_prev): New functions.
727e958e
MR
8881 (Fwindow_frame): Move here from frame.c. Accept any window as
8882 argument.
8883 (Fframe_root_window, Fframe_first_window)
8884 (Fframe_selected_window): Move here from frame.c. Accept frame
8885 or arbitrary window as argument. Update doc-strings.
8886 (Fminibuffer_window): Move up in code.
8887 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8888 (Fset_frame_selected_window): Move here from frame.c.
8889 Marginal rewrite.
727e958e
MR
8890 (Fselected_window, select_window, Fselect_window): Move up in
8891 code. Minor doc-string fixes.
f230ecc9 8892
4d09bcf6
PE
88932011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8894
8895 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8896 Do not assume that spare memory exists; that assumption is valid
8897 only if SYSTEM_MALLOC.
8898 (LARGE_REQUEST): New macro, so that the issue of large requests
8899 is separated from the issue of spare memory.
8900
810928a2
AS
89012011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8902
172418ad
AS
8903 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8904 format. (Bug#8806)
8905
43f862f7
AS
8906 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8907
810928a2
AS
8908 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8909 before statements.
8910
a059fe24
JD
89112011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8912
8913 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8914
8915 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8916
8917 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8918 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8919
989bf368
JB
89202011-06-05 Juanma Barranquero <lekktu@gmail.com>
8921
8922 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8923
4b80f674
CY
89242011-06-04 Chong Yidong <cyd@stupidchicken.com>
8925
8926 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8927 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8928 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8929 New error handlers.
4b80f674
CY
8930 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8931 Obey Vx_select_enable_clipboard_manager. Catch errors in
8932 x_clipboard_manager_save (Bug#8779).
8933 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8934 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8935
99a33b77 89362011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8937
8938 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8939
99a33b77 89402011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8941
8942 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8943 in the current matrix if keep_current_p is non-zero.
8944
8264569d
EZ
89452011-06-04 Eli Zaretskii <eliz@gnu.org>
8946
8947 * bidi.c (bidi_level_of_next_char): Fix last change.
8948
57f97249
EZ
89492011-06-03 Eli Zaretskii <eliz@gnu.org>
8950
fec2107c 8951 Support bidi reordering of text covered by display properties.
57f97249 8952
fec2107c
EZ
8953 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8954 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8955 (bidi_cache_search, bidi_cache_iterator_state)
8956 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8957 (bidi_level_of_next_char, bidi_move_to_visually_next):
8958 Support character positions inside a run of characters covered by a
fec2107c
EZ
8959 display string.
8960 (bidi_paragraph_init, bidi_resolve_explicit_1)
8961 (bidi_level_of_next_char): Call bidi_fetch_char and
8962 bidi_fetch_char_advance instead of FETCH_CHAR and
8963 FETCH_CHAR_ADVANCE.
8964 (bidi_init_it): Initialize new members.
8965 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8966 definitions.
8967 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8968 instead of using explicit *_CHAR codes.
d6d100dd
SM
8969 (bidi_resolve_explicit, bidi_resolve_weak):
8970 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8971 bidirectional text is supported only in multibyte buffers.
8972 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8973 it to initialize the frame_window_p member of struct bidi_it.
8974 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8975 (bidi_resolve_explicit, bidi_resolve_weak)
8976 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8977 bidi_it->nchars is non-positive.
8978 (bidi_level_of_next_char): Don't try to lookup the cache for the
8979 next/previous character if nothing is cached there yet, or if we
8980 were just reseat()'ed to a new position.
c40e2fb2 8981
0e14fe90
EZ
8982 * xdisp.c (set_cursor_from_row): Set start and stop points
8983 according to the row's direction when priming the loop that looks
8984 for the glyph on which to display cursor.
8985 (single_display_spec_intangible_p): Function deleted.
8986 (display_prop_intangible_p): Reimplement to call
8987 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8988 Accept 3 additional arguments needed by handle_display_spec.
8989 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8990 values: lists, `(when COND...)' forms, etc.
8991 (single_display_spec_string_p): Support property values that are
8992 lists with the argument STRING its top-level element.
8993 (display_prop_string_p): Fix the condition for processing a
8994 property that is a list to be consistent with handle_display_spec.
fec2107c 8995 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8996 last portion of handle_display_prop.
8997 (compute_display_string_pos): Accept additional argument
8998 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8999 value of a `display' property is a "replacing spec".
9000 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9001 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9002 the display property, but just return a value indicating whether
9003 the display property will replace the characters it covers.
9004 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9005 frame_window_p members of struct bidi_it.
d6d100dd
SM
9006 (compute_display_string_pos, compute_display_string_end):
9007 New functions.
fec2107c
EZ
9008 (push_it): Accept second argument POSITION, where pop_it should
9009 jump to continue iteration.
9010 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9011
fec2107c
EZ
9012 * keyboard.c (adjust_point_for_property): Adjust the call to
9013 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9014
9015 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9016 (bidi_init_it): Update prototypes.
9017 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9018 (compute_display_string_pos, compute_display_string_end):
9019 Declare prototypes.
fec2107c
EZ
9020 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9021 EMACS_INT.
fc6f18ce 9022
40087514 90232011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9024
57f53182
PE
9025 Malloc failure behavior now depends on size of allocation.
9026 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9027 * lisp.h: Change signatures accordingly.
9028 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9029 All callers changed. (Bug#8762)
9030
9031 * gnutls.c: Use Emacs's memory allocators.
9032 Without this change, the gnutls library would invoke malloc etc.
9033 directly, which causes problems on non-SYNC_INPUT hosts, and which
9034 runs afoul of improving memory_full behavior. (Bug#8761)
9035 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9036 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9037 xfree instead of the default malloc, realloc, free.
9038 (Fgnutls_boot): No need to check for memory allocation failure,
9039 since xmalloc does that for us.
9040
ac32cd99 9041 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9042 * category.c (hash_get_category_set):
9043 * ccl.c (ccl_driver):
9044 * charset.c (Fdefine_charset_internal):
9045 * charset.h (struct charset.hash_index):
9046 * composite.c (get_composition_id, gstring_lookup_cache)
9047 (composition_gstring_put_cache):
9048 * composite.h (struct composition.hash_index):
9049 * dispextern.h (struct image.hash):
9050 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9051 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9052 (hashfn_equal, hashfn_user_defined, make_hash_table)
9053 (maybe_resize_hash_table, hash_lookup, hash_put)
9054 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9055 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9056 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9057 * image.c (make_image, search_image_cache, lookup_image)
9058 (xpm_put_color_table_h):
9059 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9060 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9061 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9062 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9063 * alloc.c (allocate_vectorlike):
9064 Check for overflow in vector size calculations.
9065 * ccl.c (ccl_driver):
9066 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9067 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9068 need to be updated by these changes.
40087514
PE
9069 * fns.c (make_hash_table, maybe_resize_hash_table):
9070 Check for integer overflow with large hash tables.
0de4bb68
PE
9071 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9072 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9073 (SXHASH_REDUCE): New macro.
9074 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9075 Use it instead of discarding useful hash info with large hash values.
9076 (sxhash_float): New function.
9077 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9078 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9079 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9080 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9081 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9082 Adjust signatures to match updated version of code.
9083 (consing_since_gc): Now EMACS_INT, since a single hash table can
9084 use more than INT_MAX bytes.
9085
698d32e2
DN
90862011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9087
9088 Make it possible to build with GCC-4.6+ -O2 -flto.
9089
9090 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9091
fd6fa53f
SM
90922011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9093
9094 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9095 Call minibuffer-inactive-mode.
9096
864db017
JB
90972011-05-31 Juanma Barranquero <lekktu@gmail.com>
9098
9099 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9100 Update dependencies.
9101
2ad0baf4
DN
91022011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9103
9104 * data.c (init_data): Remove code for UTS, this system is not
9105 supported anymore.
9106
4fcc2638
DN
91072011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9108
9109 Don't force ./temacs to start in terminal mode.
9110
9111 * frame.c (make_initial_frame): Initialize faces in all cases, not
9112 only when CANNOT_DUMP is defined.
9113 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9114
c56e0fd5
DN
91152011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9116
9117 * dispnew.c (add_window_display_history): Use const for the string
9118 pointer. Remove declaration, not needed.
9119
333d54da 91202011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9121
55d4c1b2 9122 Use 'inline', not 'INLINE'.
333d54da 9123 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9124 * alloc.c, fontset.c (INLINE): Remove.
9125 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9126 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9127 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9128 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9129 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9130
738db178
DN
91312011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9132
9133 Make it possible to run ./temacs.
9134
9135 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9136 syms_of_callproc does the same thing. Remove test for
9137 "initialized", do it in the caller.
9138 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9139
620c53a6
SM
91402011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9141
9142 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9143 (read_minibuf): Use get_minibuffer.
9144 (syms_of_minibuf): Use DEFSYM.
9145 (Qmetadata): New var.
9146 * data.c (Qbuffer): Don't make it static.
9147 (syms_of_data): Use DEFSYM.
9148
e003a292
PE
91492011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9150
9151 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9152 (CCL_CODE_MIN): New macro.
9153
ed008a6d
PE
91542011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9155
3687c2ef
PE
9156 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9157
ed008a6d
PE
9158 * eval.c (Qdebug): Now static.
9159 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9160 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9161 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9162
d66c4c7c
CY
91632011-05-29 Chong Yidong <cyd@stupidchicken.com>
9164
9165 * image.c: Various fixes to ImageMagick code comments.
9166 (Fimagemagick_types): Doc fix.
9167
5fbc2025
PE
91682011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9169
0196f88a
PE
9170 Minor fixes prompted by GCC 4.6.0 warnings.
9171
9172 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9173
5fbc2025
PE
9174 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9175 (x_clipboard_manager_save_all): Move extern decl to ...
9176 * xterm.h: ... here, so that it can be checked for consistency.
9177
1dd3c2d9
CY
91782011-05-29 Chong Yidong <cyd@stupidchicken.com>
9179
9180 * xselect.c (x_clipboard_manager_save_frame)
9181 (x_clipboard_manager_save_all): New functions.
9182 (Fx_clipboard_manager_save): Lisp function deleted.
9183
9184 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9185 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9186
9187 * xterm.h: Update prototype.
9188
5ba6571d
WX
91892011-05-28 William Xu <william.xwl@gmail.com>
9190
9191 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9192 exiting (Bug#8239).
9193
3eaff834
JM
91942011-05-28 Jim Meyering <meyering@redhat.com>
9195
e1900994 9196 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9197 * fns.c (to_uchar): Define.
9198 (crypto_hash_function): Use it to convert some newly-signed
9199 variables to unsigned, to avoid sign-extension bugs. For example,
9200 without this change, (md5 "truc") would evaluate to
9201 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9202 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9203 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9204
0f6990a7
PE
92052011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9206
9207 Integer overflow fixes.
c8a9ca5a 9208
08686060
PE
9209 * dbusbind.c: Serial number integer overflow fixes.
9210 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9211 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9212 to hold a serial number that is too large for a fixnum.
9213 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9214 Check for serial numbers out of range. Decode any serial number
59568bf0 9215 that was so large that it became a float. (Bug#8722)
08686060 9216
2d1fc3c7
PE
9217 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9218 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9219 Use XFASTINT rather than XUINT when numbers are nonnegative.
9220 (xd_append_arg, Fdbus_method_return_internal):
9221 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9222 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9223 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9224 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9225 (Bug#8722)
2d1fc3c7 9226
c8a9ca5a
PE
9227 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9228
519e1d69
PE
9229 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9230
6df6ae42 9231 ccl: Add integer overflow checks.
30569699
PE
9232 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9233 (IN_INT_RANGE): New macros.
9234 (ccl_driver): Use them to check for integer overflow when
9235 decoding a CCL program. Many of the new checks are whether XINT (x)
9236 fits in int; it doesn't always, on 64-bit hosts. The new version
9237 doesn't catch all possible integer overflows, but it's an
847044ea 9238 improvement. (Bug#8719)
30569699 9239
c11285dc
PE
9240 * alloc.c (make_event_array): Use XINT, not XUINT.
9241 There's no need for unsigned here.
9242
fdccd48e
PE
9243 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9244 This follows up to the 2011-05-06 change that substituted uintptr_t
9245 for EMACS_INT. This case wasn't caught back then.
9246
37910ab2
PE
9247 Rework Fformat to avoid integer overflow issues.
9248 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9249 now (part of C89). Include <verify.h>.
9250 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9251 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9252 (Fformat): Avoid the prepass trying to compute sizes; it was only
9253 approximate and thus did not catch overflow reliably. Instead, walk
9254 through the format just once, formatting and computing sizes as we go,
9255 checking for integer overflow at every step, and allocating a larger
9256 buffer as needed. Keep track separately whether the format is
9257 multibyte. Keep only the most-recently calculated precision, rather
9258 than them all. Record whether each argument has been converted to
9259 string. Use EMACS_INT, not int, for byte and char and arg counts.
9260 Support field widths and precisions larger than INT_MAX. Avoid
9261 sprintf's undefined behavior with conversion specifications such as %#d
9262 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9263 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9264 formatting out-of-range floating point numbers with int
9173deec 9265 formats. (Bug#8668)
37910ab2 9266
2e6578fb
PE
9267 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9268
0ae6bdee
PE
9269 * data.c: Avoid integer truncation in expressions involving floats.
9270 * data.c: Include <intprops.h>.
9271 (arith_driver): When there's an integer overflow in an expression
9272 involving floating point, convert the integers to floating point
9273 so that the resulting value does not suffer from catastrophic
9274 integer truncation. For example, on a 64-bit host (* 4
9275 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9276 Do not rely on undefined behavior after integer overflow.
9277
de883a70
PE
9278 merge count_size_as_multibyte, parse_str_to_multibyte
9279 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9280 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9281 Check for integer overflow.
9282 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9283 since it's now a duplicate of the other. This is more of
9284 a character than a buffer op, so better that it's in character.c.
9285 * fns.c, print.c: Adjust to above changes.
9286
2ff916cb
PE
92872011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9288
9289 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9290
f1b54466
PE
92912011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9292
fb1ac845
PE
9293 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9294 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9295 (x_clipboard_manager_save): Now static.
9296 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9297
f1b54466
PE
9298 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9299 (crypto_hash_function): Now static.
9300 Fix pointer signedness problems. Avoid unnecessary initializations.
9301
a9f737ee
CY
93022011-05-27 Chong Yidong <cyd@stupidchicken.com>
9303
9304 * termhooks.h (Vselection_alist): Make it terminal-local.
9305
9306 * terminal.c (create_terminal): Initialize it.
9307
9308 * xselect.c: Support for clipboard managers.
9309 (Vselection_alist): Move to termhooks.h as terminal-local var.
9310 (LOCAL_SELECTION): New macro.
9311 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9312 (symbol_to_x_atom): Remove gratuitous arg.
9313 (x_handle_selection_request, lisp_data_to_selection_data)
9314 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9315 (x_own_selection, x_get_local_selection, x_convert_selection):
9316 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9317 (some_frame_on_display): Delete unused function.
9318 (Fx_own_selection_internal, Fx_get_selection_internal)
9319 (Fx_disown_selection_internal, Fx_selection_owner_p)
9320 (Fx_selection_exists_p): New optional frame arg.
9321 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9322 (x_handle_selection_clear): Don't treat other terminals with the
9323 same keyboard specially. Use the terminal-local Vselection_alist.
9324 (x_clear_frame_selections): Use Frun_hook_with_args.
9325
9326 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9327
9328 * xterm.h: Add support for those atoms.
9329
e067f0c1
CY
93302011-05-26 Chong Yidong <cyd@stupidchicken.com>
9331
9332 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9333 (converted_selections, conversion_fail_tag): New global variables.
9334 (x_selection_request_lisp_error): Free the above.
9335 (x_get_local_selection): Remove unnecessary code.
9336 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
9337 of converted selections stored in converted_selections.
9338 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
9339 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9340 (x_convert_selection): New function.
9341 (x_handle_selection_event): Simplify.
9342 (x_get_foreign_selection): Don't ignore incoming requests while
9343 waiting for an answer; this will fail when we implement
9344 SAVE_TARGETS, and seems unnecessary anyway.
9345 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9346 (Vx_sent_selection_functions): Doc fix.
9347
0f4aebc0
LL
93482011-05-26 Leo Liu <sdl.web@gmail.com>
9349
9350 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9351
e61124cd
YM
93522011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9353
9354 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9355
9356 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9357 for fringe update if it has periodic bitmap.
ac389d0c 9358 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
9359 and fringe_bitmap_periodic_p.
9360
9361 * fringe.c (get_fringe_bitmap_data): New function.
9362 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9363 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9364 row. Mark glyph row for fringe update if periodicity changed.
9365
9366 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9367 for fringe update unless it has periodic bitmap.
9368
f16d9837
KH
93692011-05-25 Kenichi Handa <handa@m17n.org>
9370
9371 * xdisp.c (get_next_display_element): Set correct it->face_id for
9372 a static composition.
9373
e1b90ef6
LL
93742011-05-24 Leo Liu <sdl.web@gmail.com>
9375
9376 * deps.mk (fns.o):
9377 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9378
9379 * fns.c (crypto_hash_function, Fsha1): New function.
9380 (Fmd5): Use crypto_hash_function.
9381 (syms_of_fns): Add Ssha1.
9382
7400048f
PE
93832011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9384
9385 * gnutls.c: Remove unused macros.
9386 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9387 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9388 Remove macros that are defined and never used.
9389 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9390
abb71cf4
CY
93912011-05-22 Chong Yidong <cyd@stupidchicken.com>
9392
9393 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9394 (Fx_get_selection_internal): Minor cleanup.
9395 (Fx_own_selection_internal): Rename arguments for consistency with
9396 select.el.
9397
6307db39
PE
93982011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9399
9400 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9401
f3d4e0a4
CY
94022011-05-22 Chong Yidong <cyd@stupidchicken.com>
9403
9404 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9405
4d8ade89
YM
94062011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9407
9408 * dispnew.c (scrolling_window): Don't exclude the case that the
9409 last enabled row in the desired matrix touches the bottom boundary.
9410
32078c8d
GM
94112011-05-21 Glenn Morris <rgm@gnu.org>
9412
9413 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
9414 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9415 and add some more files.
32078c8d 9416
7285dc67
EZ
94172011-05-20 Eli Zaretskii <eliz@gnu.org>
9418
9419 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9420 report_file_error introduced by the change from 2011-05-07.
9421
89d1bd22
PE
94222011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9423
9424 * systime.h (Time): Define only if emacs is defined.
9425 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9426 where the include path doesn't have X11/X.h by default. See
9427 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9428
cd394be1 94292011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9430
9431 * composite.c (find_automatic_composition): Fix previous change.
9432
b9704ad9
GM
94332011-05-20 Glenn Morris <rgm@gnu.org>
9434
9435 * lisp.mk: New file, split from Makefile.in.
9436 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9437 (shortlisp): Remove.
9438 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9439
4a720484
GM
94402011-05-19 Glenn Morris <rgm@gnu.org>
9441
9442 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9443 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9444 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9445 (lisp): Set the order to that of loadup.el.
9446 (shortlisp): Make it a copy of $lisp.
9447 (SOME_MACHINE_LISP): Remove.
9448 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9449 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9450
a28d4396
KH
94512011-05-18 Kenichi Handa <handa@m17n.org>
9452
9453 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9454 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9455 (find_automatic_composition): Mostly rewrite for efficiency.
9456
a2b1fa8e
JB
94572011-05-18 Juanma Barranquero <lekktu@gmail.com>
9458
9459 * makefile.w32-in: Update dependencies.
9460
8e1f5610
CS
94612011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9462
9463 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9464 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9465
7025ee00 94662011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9467
cdfa6eab
PE
9468 Fix some integer overflow issues, such as string length overflow.
9469
06d6db33
PE
9470 * insdel.c (count_size_as_multibyte): Check for string overflow.
9471
2b4560a8
PE
9472 * character.c (lisp_string_width): Check for string overflow.
9473 Use EMACS_INT, not int, for string indexes and lengths; in
9474 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9475 the resulting string length overflows an EMACS_INT; instead,
9476 report a string overflow if no precision given. When checking for
9477 precision exhaustion, use a check that cannot possibly have
9478 integer overflow. (Bug#8675)
9479 * character.h (lisp_string_width): Adjust to new signature.
9480
cb93f9be
PE
9481 * alloc.c (string_overflow): New function.
9482 (Fmake_string): Use it. This doesn't change behavior, but saves
9483 a few bytes and will simplify future changes.
9484 * character.c (string_escape_byte8): Likewise.
9485 * lisp.h (string_overflow): New decl.
9486
1a1f3366
PE
9487 Fixups, following up to the user-interface timestamp change.
9488 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9489 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9490 * msdos.c (mouse_get_pos): Likewise.
9491 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9492 * w32gui.h (Time): Define by including "systime.h" rather than by
9493 declaring it ourselves. (Bug#8664)
9494
d4e3e4d3
PE
9495 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9496 * image.c (clear_image_cache): Likewise.
9497
f6a24d19
PE
9498 * term.c (term_mouse_position): Don't assume time_t wraparound.
9499
08dc5ae6
PE
9500 Be more systematic about user-interface timestamps.
9501 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9502 and sometimes 'EMACS_UINT', to represent these timestamps.
9503 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9504 This makes the code easier to follow, and makes it easier to catch
9505 integer overflow bugs such as Bug#8664.
9506 * frame.c (Fmouse_position, Fmouse_pixel_position):
9507 Use Time, not unsigned long, for user-interface timestamps.
9508 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9509 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9510 * keyboard.h (last_event_timestamp): Likewise.
9511 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9512 * menu.h (xmenu_show): Likewise.
9513 * term.c (term_mouse_position): Likewise.
9514 * termhooks.h (struct input_event.timestamp): Likewise.
9515 (struct terminal.mouse_position_hook): Likewise.
9516 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9517 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9518 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9519 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9520 what it was before.
9521 * menu.h, termhooks.h: Include "systime.h", for Time.
9522
8e55734a
PE
9523 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9524 Don't assume that the difference between two unsigned long values
9525 can fit into an integer. At this point, we know button_down_time
9526 <= event->timestamp, so the difference must be nonnegative, so
9527 there's no need to cast the result if double-click-time is
9528 nonnegative, as it should be; check that it's nonnegative, just in
9529 case. This bug is triggered when events are more than 2**31 ms
86db42d2 9530 apart (about 25 days). (Bug#8664)
8e55734a 9531
841f1b75 9532 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9533 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9534
3e26f69c
PE
9535 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9536 that always fit in int. Use a sentinel instead of a counter, to
9537 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
9538 * frame.h (struct frame): Use int for menu_bar_items_used
9539 instead of EMACS_INT, since it always fits in int.
3e26f69c 9540
5cc152c0
PE
9541 * menu.c (grow_menu_items): Check for int overflow.
9542
d89eb65e
PE
9543 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9544
5235bd3e
PE
9545 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9546 Before, the code was not consistent. These values cannot exceed
9547 2**31 - 1 so there's no need to make them unsigned.
9548 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9549 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9550 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9551 as modifiers.
9552 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9553
bc827e23
PE
9554 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9555 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9556 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9557 presumably because the widths might not match.
9558
78eb494e
PE
9559 * window.c (size_window): Avoid needless test at loop start.
9560
04f2d78b
CB
95612011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9562
9563 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9564
d2fc7e3d 95652011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9566
9567 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9568
d2fc7e3d 95692011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9570
9571 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9572 `width' to `bar_area_x' and `bar_area_width', respectively.
9573 (x_scroll_run): Take account of fringe background extension.
9574
04f2d78b
CB
9575 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9576 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9577 `bar_area_width', respectively.
9578 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9579 background extension.
9580
79b70037
GM
95812011-05-10 Jim Meyering <meyering@redhat.com>
9582
9583 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9584
2f142cc5
JB
95852011-05-10 Juanma Barranquero <lekktu@gmail.com>
9586
9587 * image.c (Finit_image_library): Return t for built-in image types,
9588 like pbm and xbm. (Bug#8640)
9589
57679c86
AS
95902011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9591
9592 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9593
888c9e86
EZ
95942011-05-07 Eli Zaretskii <eliz@gnu.org>
9595
b0512a1d
EZ
9596 * w32console.c (Fset_screen_color): Doc fix.
9597 (Fget_screen_color): New function.
9598 (syms_of_ntterm): Defsubr it.
9599
7285dc67
EZ
9600 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9601 unlink the temporary file if Fcall_process didn't create it in the
9602 first place.
9603 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9604 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9605 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9606 cue to call_process_cleanup not to close that handle.
9607
4d3fcc8e
BK
96082011-05-07 Ben Key <bkey76@gmail.com>
9609
9610 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9611 one of two shell specific rules, either bootstrap-temacs-CMD or
9612 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9613 to the previous implementation of the bootstrap-temacs rule.
9614 The bootstrap-temacs-CMD rule is similar to the previous
9615 implementation of the bootstrap-temacs rule except that it
9616 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9617 variable.
9618
9619 These changes, along with some changes to nt/configure.bat,
9620 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9621 earlier fix to add support for --cflags and --ldflags options
9622 that include quotes so that it works whether make uses cmd or
9623 sh as the shell.
9624
b4289b64
MA
96252011-05-06 Michael Albinus <michael.albinus@gmx.de>
9626
9627 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9628 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9629 is a constant.
9630 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9631 a string. Handle both cases.
9632 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9633 (Fdbus_register_method): Use Qinvalid_function.
9634
af4c0e28
JB
96352011-05-06 Juanma Barranquero <lekktu@gmail.com>
9636
9637 * makefile.w32-in: Update dependencies.
9638 (LISP_H): Add inttypes.h and stdin.h.
9639 (PROCESS_H): Add unistd.h.
9640
c51453d9
EZ
96412011-05-06 Eli Zaretskii <eliz@gnu.org>
9642
9643 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9644 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9645
8ff0ac3c 96462011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9647
4c4b566b
PE
9648 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9649
aab2b9b5
PE
9650 * term.c (vfatal): Remove stray call to va_end.
9651 It's not needed and the C Standard doesn't allow it here anyway.
9652
c378da0b
PE
9653 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9654 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9655
288b08c7
PE
9656 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9657 bytes.
9658
e3601888
PE
9659 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9660
db6c0e74
PE
9661 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9662
dd5963ea
PE
9663 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9664
88c9450f
PE
9665 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9666
2f9442b8
PE
9667 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9668
c032b5f8
PE
9669 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9670 * charset.c (Fdefine_charset_internal): Don't initialize
9671 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9672 32-bit int (Bug#8600).
a108c10b
PE
9673
9674 * lread.c (read_integer): Be more consistent with string-to-number.
9675 Use string_to_number to do the actual conversion; this avoids
9676 rounding errors and fixes some other screwups. Without this fix,
9677 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9678 (digit_to_number): Move earlier, for benefit of read_integer.
9679 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9680 not a digit in any supported base. (Bug#8602)
a108c10b 9681
ad5f9eea
PE
9682 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9683
aec1708a
PE
9684 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9685 to match comment at start of function. This also removes a
9686 GCC warning about overflow in a 32+64-bit port.
9687
47be4ab5
PE
9688 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9689
371cac43
PE
9690 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9691 Reported by Stefan Monnier in
9692 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9693 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9694 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 9695
d01a7826
PE
9696 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9697 (EMACS_UINTPTR): Likewise, with uintptr_t.
9698
7fd47d5c
PE
9699 * lisp.h: Prefer 64-bit EMACS_INT if available.
9700 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9701 on 32-bit hosts that have 64-bit int, so that they can access
9702 large files.
122b0c86
PE
9703 However, temporarily disable this change unless the temporary
9704 symbol WIDE_EMACS_INT is defined.
7fd47d5c 9705
8727937b
PE
9706 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9707
8ac068ac
PE
9708 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9709 This removes an assumption that EMACS_INT and long are the same
9710 width as pointers. The assumption is true for Emacs porting targets
9711 now, but we want to make other targets possible.
9712 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9713 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9714 In the rest of the code, change types of integers that hold casted
9715 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9716 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9717 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9718 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9719 No need to cast type when ORing.
9720 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9721 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9722 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9723 assume EMACS_INT is the same width as char *.
9724 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9725 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9726 Remove no-longer-needed casts.
9727 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9728 (xg_tool_bar_help_callback, xg_make_tool_item):
9729 Use EMACS_INTPTR to hold an integer
9730 that will be cast to void *; this can avoid a GCC warning
9731 if EMACS_INT is not the same width as void *.
9732 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9733 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9734 (current_message_1, set_message_1):
9735 Use a local to convert to proper width without a cast.
9736 * xmenu.c (dialog_selection_callback): Likewise.
9737
ede49d71
PE
9738 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9739 Also, don't assume VALBITS / RAND_BITS is less than 5,
9740 and don't rely on undefined behavior when shifting a 1 left into
9741 the sign bit.
9742 * lisp.h (get_random): Change signature to match.
9743
2f30ecd0
PE
9744 * lread.c (hash_string): Use size_t, not int, for hash computation.
9745 Normally we prefer signed values; but hashing is special, because
9746 it's better to use unsigned division on hash table sizes so that
9747 the remainder is nonnegative. Also, size_t is the natural width
9748 for hashing into memory. The previous code used 'int', which doesn't
9749 retain enough info to hash well into very large tables.
9750 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9751
2a866e7b
PE
9752 * dbusbind.c: Don't possibly lose pointer info when converting.
9753 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9754 Use XPNTR rather than XHASH, so that the high-order bits of
9755 the pointer aren't lost when converting through void *.
9756
51639eac
PE
9757 * eval.c (Fautoload): Don't double-shift a pointer.
9758
92394119
PE
9759 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9760
dbdb9a7c
JB
97612011-05-06 Juanma Barranquero <lekktu@gmail.com>
9762
9763 * gnutls.c (DEF_GNUTLS_FN):
9764 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9765
db7a0b4f
AS
97662011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9767
9768 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9769 marker. (Bug#8610)
9770
cd394be1 97712011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9772
9773 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9774 New version that can reserve upto 2GB of heap space.
9775
f7ff1b0f 97762011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9777
9778 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9779
639c109b
TZ
97802011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9781
9782 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9783 `gnutls_certificate_set_x509_key_file'.
9784
d2127135
JB
97852011-05-05 Juanma Barranquero <lekktu@gmail.com>
9786
9787 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9788 Update dependencies.
9789
e968f4f3
JB
97902011-05-04 Juanma Barranquero <lekktu@gmail.com>
9791
9792 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9793 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9794 Remove unused parameter `fildes'.
9795 * process.c (read_process_output, send_process): Don't pass it.
9796
84d358f0
JB
97972011-05-04 Juanma Barranquero <lekktu@gmail.com>
9798
9799 Fix previous change: the library cache is defined in w32.c.
9800 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9801 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9802
0898ca10
JB
98032011-05-04 Juanma Barranquero <lekktu@gmail.com>
9804
9805 Implement dynamic loading of GnuTLS on Windows.
9806
9807 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9808 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9809 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9810 Declare.
9811
9812 * gnutls.c (Qgnutls_dll): Define.
9813 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9814 (gnutls_*): Declare function pointers.
9815 (init_gnutls_functions): New function to initialize function pointers.
9816 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9817 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9818 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9819 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9820 (emacs_gnutls_write, emacs_gnutls_read)
9821 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9822 (Fgnutls_available_p): New function.
9823 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9824 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9825 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9826
9827 * image.c: Include w32.h.
9828 (Vimage_type_cache): Delete.
9829 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9830 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9831 (w32_delayed_load): Move to w32.c.
9832
9833 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9834
9835 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9836 (w32_delayed_load): Move from image.c. When loading a library, record
9837 its filename in the :loaded-from property of the library id.
9838 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9839 Initialize and staticpro them.
9840 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9841
9842 * process.c: Include lisp.h before w32.h, not after.
9843 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9844 instead of gnutls_record_check_pending.
9845
9846 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9847
ff4de4aa
TZ
98482011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9849
9850 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9851 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9852 as passed in.
9853
abe95abb
JD
98542011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9855
9856 * xterm.c (x_set_frame_alpha): Do not set property on anything
9857 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9858
e16e55d4
JB
98592011-05-02 Juanma Barranquero <lekktu@gmail.com>
9860
9861 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9862
bafcf6a5
JB
98632011-05-02 Juanma Barranquero <lekktu@gmail.com>
9864
9865 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9866 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9867 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9868 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9869 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9870 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9871 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9872 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9873 (Qgnutls_bootprop_callbacks_verify): Make static.
9874
e7a6747f
AS
98752011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9876
19ed11ba
AS
9877 * callproc.c: Indentation fixup.
9878
e7a6747f 9879 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9880 (wait_for_termination, interruptible_wait_for_termination):
9881 Move after wait_for_termination_1.
e7a6747f 9882
1ef14cb4
LMI
98832011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9884
9885 * sysdep.c (interruptible_wait_for_termination): New function
9886 which is like wait_for_termination, but allows keyboard
9887 interruptions.
9888
9889 * callproc.c (Fcall_process): Add (:file "file") as an option for
9890 the STDOUT buffer.
9891 (Fcall_process_region): Ditto.
9892
330d880c
EZ
98932011-04-30 Eli Zaretskii <eliz@gnu.org>
9894
8db90b73
EZ
9895 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9896 rather than `XVECTOR (FOO)->size'.
9897
330d880c
EZ
9898 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9899 inttypes.h, as a gnulib replacement is used if it not available in
9900 system headers.
9901
15cbd324
EZ
99022011-04-21 Eli Zaretskii <eliz@gnu.org>
9903
9904 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9905 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9906 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9907
9908 * coding.c (coding_alloc_by_realloc): Error out if destination
9909 will grow beyond MOST_POSITIVE_FIXNUM.
9910 (decode_coding_emacs_mule): Abort if there isn't enough place in
9911 charbuf for the composition carryover bytes. Reserve an extra
9912 space for up to 2 characters produced in a loop.
9913 (decode_coding_iso_2022): Abort if there isn't enough place in
9914 charbuf for the composition carryover bytes.
9915
99162011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9917
ae940cca
EZ
9918 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9919 aborting when %lld or %lll format is passed.
9920 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9921 %llo or %llx format is passed. (Bug#8545)
9922
03ab8921
EZ
9923 * window.c (window_scroll_line_based): Use a marker instead of
9924 simple variables to record original value of point. (Bug#7952)
9925
afda1437
EZ
9926 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9927 produced by %s or %c overflows available buffer space. (Bug#8545)
9928
f76dee0c
PE
99292011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9930
9931 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9932 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9933
fdc5744d
JB
99342011-04-28 Juanma Barranquero <lekktu@gmail.com>
9935
9936 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9937
638f053a
JB
99382011-04-28 Juanma Barranquero <lekktu@gmail.com>
9939
9940 * keyboard.c (Qdelayed_warnings_hook): Define.
9941 (command_loop_1): Run `delayed-warnings-hook'
9942 if Vdelayed_warnings_list is non-nil.
9943 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9944 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9945
d178f871
EZ
99462011-04-28 Eli Zaretskii <eliz@gnu.org>
9947
9948 * doprnt.c (doprnt): Don't return value smaller than the buffer
9949 size if the message was truncated. (Bug#8545).
9950
b124fd93
JB
99512011-04-28 Juanma Barranquero <lekktu@gmail.com>
9952
9953 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9954 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9955
e810457d
PE
99562011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9957
9958 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9959
ea51cceb
JB
99602011-04-27 Juanma Barranquero <lekktu@gmail.com>
9961
9962 * makefile.w32-in: Update dependencies.
9963
94dcfacf
EZ
99642011-04-27 Eli Zaretskii <eliz@gnu.org>
9965
9966 Improve `doprnt' and its usage. (Bug#8545)
9967 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9968 `format_end'. Remove support for %l as a conversion specifier.
9969 Don't use xrealloc. Improve diagnostics when the %l size modifier
9970 is used. Update the commentary.
9971
9972 * eval.c (verror): Simplify calculation of size_t.
9973
9974 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9975 messages.
9976
f61f41d7
PE
99772011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9978
9979 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9980 change.
9981
96fb4434
PE
99822011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9983
9984 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9985 This makes this file independent of the recent pseudovector change.
9986
671875da 99872011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9988
69e9b5a3
PE
9989 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9990
b5f869a7 9991 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9992 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9993 Remove unused local.
c8926152 9994 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9995
841a1577 9996 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9997 GCC 4.6.0 optimizes based on type-based alias analysis.
9998 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9999 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10000 != &v->size, and therefore "v->size = 1; b->size = 2; return
10001 v->size;" must therefore return 1. This assumption is incorrect
10002 for Emacs, since it type-puns struct Lisp_Vector * with many other
10003 types. To fix this problem, this patch adds a new type struct
f904488f 10004 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10005 and pseudovectors, and helps optimizing compilers not get fooled
10006 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10007 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10008 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10009 the size member.
eab3844f
PE
10010 (XSETPVECTYPE): Rewrite in terms of new macro.
10011 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10012 This is a bit clearer, and further avoids the possibility of
10013 undesirable aliasing.
10014 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10015 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10016 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10017 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10018 (ASIZE): Now uses header.size rather than size.
10019 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10020 to avoid the hassle of writing XVECTOR (foo)->header.size.
10021 (struct vectorlike_header): New type.
eab3844f
PE
10022 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10023 object, to help avoid aliasing.
10024 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10025 (SUBRP): Likewise, since Lisp_Subr is a special case.
10026 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10027 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10028 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10029 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10030 changed to be "header.size" and "header.next".
10031 * buffer.h (struct buffer): Likewise.
10032 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10033 * frame.h (struct frame): Likewise.
10034 * process.h (struct Lisp_Process): Likewise.
10035 * termhooks.h (struct terminal): Likewise.
10036 * window.c (struct save_window_data, struct saved_window): Likewise.
10037 * window.h (struct window): Likewise.
10038 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10039 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10040 * buffer.c (init_buffer_once): Likewise.
10041 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10042 special case.
10043 * process.c (Fformat_network_address): Use local var for size,
10044 for brevity.
10045
0df1eac5
PE
10046 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10047
847ab9d1 10048 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10049 * data.c (atof): Remove decl; no longer used or needed.
10050 (digit_to_number): Move to lread.c.
10051 (Fstring_to_number): Use new string_to_number function, to be
10052 consistent with how the Lisp reader treats infinities and NaNs.
10053 Do not assume that floating-point numbers represent EMACS_INT
10054 without losing information; this is not true on most 64-bit hosts.
10055 Avoid double-rounding errors, by insisting on integers when
10056 parsing non-base-10 numbers, as the documentation specifies.
10057 * lisp.h (string_to_number): New decl, replacing ...
10058 (isfloat_string): Remove.
bc0a5c13 10059 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10060 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10061 appears to have been a coding error. Similarly, do not accept
10062 strings like +-1e0 as floating point numbers. Do not report
10063 overflow for integer overflows unless the base is not 10 which
10064 means we have no simple and reliable way to continue.
10065 Break out the floating-point parsing into a new
10066 function string_to_number, so that Fstring_to_number parses
10067 floating point numbers consistently with the Lisp reader.
04f2d78b 10068 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10069 (E_CHAR, EXP_INT): Remove, replacing with ...
10070 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10071 (string_to_number): New function, replacing isfloat_string.
10072 This function checks for valid syntax and produces the resulting
10073 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10074 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10075 so that overflow for non-base-10 numbers is reported only when
10076 there's no portable and simple way to convert to floating point.
452f4150 10077
67769ffc
PE
10078 * textprop.c (set_text_properties_1): Rewrite for clarity,
10079 and to avoid GCC warning about integer overflow.
10080
c20db43f
PE
10081 * intervals.h (struct interval): Use EMACS_INT for members
10082 where EMACS_UINT might cause problems. See
10083 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10084 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10085 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10086 All uses changed.
37aa2f85
PE
10087 (offset_intervals): Tell GCC not to worry about length overflow
10088 when negating a negative length.
c20db43f 10089
2538aa2f
PE
10090 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10091 (overrun_check_free): Likewise.
10092
f2d3008d
PE
10093 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10094 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10095 word size.
10096
ec8df744
PE
10097 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10098 (gnutls_make_error): Rename local to avoid shadowing.
10099 (gnutls_emacs_global_deinit): ifdef out; not used.
10100 (Fgnutls_boot): Use const for pointer to readonly storage.
10101 Comment out unused local. Fix pointer signedness problems.
10102
640ee02d
PE
10103 * lread.c (openp): Don't stuff size_t into an 'int'.
10104 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10105 about possible signed overflow.
10106
6048fb2a
PE
10107 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10108 (GDK_KEY_g): Don't define if already defined.
10109 (xg_prepare_tooltip): Avoid pointer signedness problem.
10110 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10111
fa3c87e1
PE
10112 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10113 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10114
2172544b
PE
10115 * xfns.c (Fx_window_property): Simplify a bit,
10116 to make a bit faster and to avoid GCC 4.6.0 warning.
10117 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10118
9b821a21
PE
10119 * fns.c (internal_equal): Don't assume size_t fits in int.
10120
3c616cfa
PE
10121 * alloc.c (compact_small_strings): Tighten assertion a little.
10122
c2982e87
PE
10123 Replace pEd with more-general pI, and fix some printf arg casts.
10124 * lisp.h (pI): New macro, generalizing old pEd macro to other
10125 conversion specifiers. For example, use "...%"pI"d..." rather
10126 than "...%"pEd"...".
10127 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10128 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10129 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10130 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10131 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10132 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10133 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10134 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10135 64-bit hosts.
10136 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10137 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10138 * print.c (safe_debug_print, print_object): Likewise.
10139 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10140 to int.
6f04d126
PE
10141 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10142 avoiding the 0 flag, which is not portable.
c2982e87
PE
10143 * process.c (Fmake_network_process): Use pI to avoid cast.
10144 * region-cache.c (pp_cache): Likewise.
10145 * xdisp.c (decode_mode_spec): Likewise.
10146 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10147 behavior on 64-bit hosts with printf arg.
6f04d126 10148 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10149 (x_stop_queuing_selection_requests): Likewise.
10150 (x_get_window_property): Don't truncate byte count to an 'int'
10151 when tracing.
0b432f21 10152
5e073ec7
PE
10153 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10154 here, since it parses constructs like leading '-' and spaces,
10155 which are not wanted; and it overflows with large numbers.
10156 Instead, simply match F[0-9]+, which is what is wanted anyway.
10157
36372bf9
PE
10158 * alloc.c: Remove unportable assumptions about struct layout.
10159 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10160 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10161 (allocate_vectorlike, make_pure_vector): Use the new macros,
10162 plus offsetof, to remove unportable assumptions about struct layout.
10163 These assumptions hold on all porting targets that I know of, but
10164 they are not guaranteed, they're easy to remove, and removing them
10165 makes further changes easier.
10166
0b432f21
PE
10167 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10168 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10169 (string_overrun_cookie): Now const. Use initializers that
10170 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10171 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10172 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10173 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10174 multiple of sizeof (EMACS_INT); it need not be, if
10175 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10176 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10177
895009e1
JB
101782011-04-26 Juanma Barranquero <lekktu@gmail.com>
10179
10180 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10181
6a7a1b0b
TZ
101822011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10183
10184 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10185 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10186 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10187
841a1577 101882011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10189
10190 * lisp.h (Qdebug): List symbol.
895009e1 10191 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10192 * keyboard.c (debug-on-event): New variable.
10193 (handle_user_signal): Break into debugger when debug-on-event
10194 matches the current signal symbol.
10195
f2d3ba6f
DN
101962011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10197
10198 * alloc.c (check_sblock, check_string_bytes)
10199 (check_string_free_list): Convert to standard C.
10200
42ce4c63
TZ
102012011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10202
10203 * w32.c (emacs_gnutls_push): Fix typo.
10204
825cd63c
EZ
102052011-04-25 Eli Zaretskii <eliz@gnu.org>
10206
fb11d64d
EZ
10207 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10208 "cast to pointer from integer of different size".
10209
825cd63c
EZ
10210 Improve doprnt and its use in verror. (Bug#8545)
10211 * doprnt.c (doprnt): Document the set of format control sequences
10212 supported by the function. Use SAFE_ALLOCA instead of always
10213 using `alloca'.
10214
10215 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10216 is one byte too soon. Don't use xrealloc; instead xfree and
10217 xmalloc anew.
10218
e061a11b
TZ
102192011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10220
10221 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10222 callbacks stage.
10223
10224 * gnutls.c: Renamed global_initialized to
10225 gnutls_global_initialized. Added internals for the
10226 :verify-hostname-error, :verify-error, and :verify-flags
10227 parameters of `gnutls-boot' and documented those parameters in the
10228 docstring. Start callback support.
9173deec
JB
10229 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10230 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10231 on error. Return error code.
e061a11b
TZ
10232 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10233 (emacs_gnutls_read): Likewise.
10234 (Fgnutls_boot): Return handshake error code.
10235 (emacs_gnutls_handle_error): New function.
10236 (wsaerror_to_errno): Likewise.
10237
10238 * w32.h (emacs_gnutls_pull): Add prototype.
10239 (emacs_gnutls_push): Likewise.
10240
10241 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10242 (emacs_gnutls_push): Likewise.
10243
102442011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10245
10246 * process.c (wait_reading_process_output): Check if GnuTLS
10247 buffered some data internally if no FDs are set for TLS
10248 connections.
10249
10250 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10251 (LIBS): Link to USER_LIBS.
10252 ($(BLD)/gnutls.$(0)): New target.
10253
fa6996bc
EZ
102542011-04-24 Eli Zaretskii <eliz@gnu.org>
10255
eb35682e
EZ
10256 * xdisp.c (handle_single_display_spec): Rename the
10257 display_replaced_before_p argument into display_replaced_p, to
10258 make it consistent with the commentary. Fix typos in the
10259 commentary.
10260
e2ad650c
EZ
10261 * textprop.c (syms_of_textprop): Remove dead code.
10262 (copy_text_properties): Delete obsolete commentary about an
10263 interface that was deleted long ago. Fix typos in the description
10264 of arguments.
10265
1b2de274
EZ
10266 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10267 to changes in oldXMenu/XMenu.h from 2011-04-16.
10268 <menu_help_message, prev_menu_help_message>: Constify.
10269 (IT_menu_make_room): menu->help_text is now `const char **';
10270 adjust.
10271
10272 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10273 to changes in oldXMenu/XMenu.h from 2011-04-16.
10274 (struct XMenu): Declare `help_text' `const char **'.
10275
10276 * xfaces.c <Qunspecified>: Make extern again.
10277
10278 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10279 required by POSIX.
1b2de274 10280
762b15be
EZ
10281 * doc.c (get_doc_string): Improve the format passed to `error'.
10282
10283 * doprnt.c (doprnt): Improve commentary.
10284
10285 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10286
10287 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10288 them with etags.
10289
f1052e5d
EZ
10290 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10291 changes in globals.h immediately force recompilation.
762b15be
EZ
10292 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10293 $(CURDIR)/s/ms-w32.h.
10294 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10295
fa6996bc
EZ
10296 * character.c (Fchar_direction): Function deleted.
10297 (syms_of_character): Don't defsubr it.
10298 <char-direction-table>: Deleted.
10299
e6c3da20
EZ
103002011-04-23 Eli Zaretskii <eliz@gnu.org>
10301
10302 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10303 * doprnt.c: Include limits.h.
10304 (SIZE_MAX): New macro.
04f2d78b
CB
10305 (doprnt): Return a size_t value. 2nd arg is now size_t.
10306 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10307 Improve overflow protection. Support `l' modifier for integer
10308 conversions. Support %l conversion. Don't assume an EMACS_INT
10309 argument for integer conversions and for %c.
10310
10311 * lisp.h (doprnt): Restore prototype.
10312
10313 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10314 $(SRC)/character.h.
10315
10316 * Makefile.in (base_obj): Add back doprnt.o.
10317
10318 * deps.mk (doprnt.o): Add back prerequisites.
10319 (callint.o): Depend on character.h.
10320
10321 * eval.c (internal_lisp_condition_case): Include the handler
10322 representation in the error message.
10323 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10324 when breaking from the loop.
10325
10326 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10327
10328 * callint.c (Fcall_interactively): When displaying error message
10329 about invalid control letter, pass the character's codepoint, not
10330 a pointer to its multibyte form. Improve display of the character
10331 in octal and display also its hex code.
10332
10333 * character.c (char_string): Use %x to display the (unsigned)
10334 codepoint of an invalid character, to avoid displaying a bogus
10335 negative value.
10336
10337 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10338 `error', not SYMBOL_NAME itself.
10339
10340 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10341 character arguments to `error'.
10342
10343 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10344 to `error' in error message about FINAL_CHAR argument. Make sure
10345 FINAL_CHAR is a character, and use %c when it is passed as
10346 argument to `error'.
10347
4ffd0d6b 103482011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
10349
10350 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10351
10352 * w32.c: Include <time.h>.
10353 (sys_localtime): New function.
10354
4ffd0d6b 103552011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
10356
10357 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10358
4ffd0d6b 10359 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 10360
4ffd0d6b 103612011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 10362
4ffd0d6b
GM
10363 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10364 zombies (Bug#8467).
aac0c6e3 10365
04c56954
EZ
103662011-04-19 Eli Zaretskii <eliz@gnu.org>
10367
10368 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10369 gl_state.e_property when gl_state.object is Qt.
10370
10371 * insdel.c (make_gap_larger): Remove limitation of buffer size
10372 to <= INT_MAX.
10373
16a43933
CY
103742011-04-18 Chong Yidong <cyd@stupidchicken.com>
10375
10376 * xdisp.c (lookup_glyphless_char_display)
10377 (produce_glyphless_glyph): Handle cons cell entry in
10378 glyphless-char-display.
10379 (Vglyphless_char_display): Document it.
10380
10381 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10382 glyphless-char-display.
10383
4581706e
CY
103842011-04-17 Chong Yidong <cyd@stupidchicken.com>
10385
10386 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10387
10388 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10389
10390 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10391 definition for no-X builds.
10392
4887c6e2 103932011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 10394
fd35b6f9
PE
10395 Static checks with GCC 4.6.0 and non-default toolkits.
10396
5c1ccb01
PE
10397 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10398
006c5daa
PE
10399 * process.c (keyboard_bit_set): Define only if SIGIO.
10400 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10401 (send_process): Repair possible setjmp clobbering.
10402
efc736d3
PE
10403 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10404
4e2fe2e6
PE
10405 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10406
f97334a2
PE
10407 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10408
4e75f29d
PE
10409 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10410 Define only if needed.
10411
90efadd1
PE
10412 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10413 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 10414 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 10415
3c647824
PE
10416 * dispextern.h (struct redisplay_interface): Rename param
10417 to avoid shadowing.
e264f262 10418 * termhooks.h (struct terminal): Likewise.
761383f4 10419 * xterm.c (xembed_send_message): Likewise.
3c647824 10420
b58c5c4a
PE
10421 * insdel.c (make_gap_smaller): Define only if
10422 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10423
cad59032
PE
10424 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10425 it.
10426
c339dc2e
PE
10427 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10428 so that we aren't warned about unused symbols.
10429
91a3e27b
PE
10430 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10431
399c71d3 10432 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10433
8ffc96f5
PE
10434 * xfns.c (x_real_positions): Mark locals as initialized.
10435
eef9bc79
PE
10436 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10437
098db9dd
PE
10438 * xterm.c: Fix problems found by static analysis with other toolkits.
10439 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10440 (x_dispatch_event): Declare static if USE_GTK, and
10441 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10442 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10443 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10444 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10445 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10446
eb18f6cc
PE
10447 * xmenu.c (menu_help_callback): Pointer type fixes.
10448 Use const pointers when pointing at readonly data. Avoid pointer
10449 signedness clashes.
10450 (FALSE): Remove unused macro.
10451 (update_frame_menubar): Remove unused decl.
10452
1fe72bf8
PE
10453 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10454
60d9e1db
PE
10455 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10456 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10457 (single_menu_item): Rename local to avoid shadowing.
10458
39261c26
PE
10459 * keyboard.c (make_lispy_event): Remove unused local var.
10460
018c5e19
PE
10461 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10462 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10463
63d2b86e
PE
10464 * bitmaps: Change bitmaps from unsigned char back to the X11
10465 compatible char. Avoid the old compiler warnings about
10466 out-of-range initializers by using, for example, '\xab' rather
10467 than 0xab.
10468
aefd87e1
PE
10469 * xgselect.c (xgselect_initialize): Check vs interface
10470 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10471
bf501fb9
PE
10472 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10473
e9829fdf
PE
10474 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10475 to read-only memory.
10476
1086c095
PE
10477 * fns.c (vector): Remove; this old hack is no longer needed.
10478
2baccd04 10479 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10480 Remove unused var.
dde42981 10481 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10482
72391843 10483 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10484
436c16df 10485 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10486 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10487 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10488
92bb796d 10489 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10490 (x_term_init): Remove local to avoid shadowing.
92bb796d 10491
764430a3 10492 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10493
10494 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10495 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10496
d1dfb56c
EZ
104972011-04-16 Eli Zaretskii <eliz@gnu.org>
10498
c4354cb4
EZ
10499 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10500
d1dfb56c
EZ
10501 Fix regex.c, syntax.c and friends for buffers > 2GB.
10502 * syntax.h (struct gl_state_s): Declare character position members
10503 EMACS_INT.
10504
10505 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10506
04f2d78b
CB
10507 * textprop.c (verify_interval_modification, interval_of):
10508 Declare arguments EMACS_INT.
d1dfb56c
EZ
10509
10510 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10511 EMACS_INT.
10512
10513 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10514
10515 * indent.c (Fvertical_motion): Local variable it_start is now
10516 EMACS_INT.
10517
10518 * regex.c (re_match, re_match_2, re_match_2_internal)
10519 (bcmp_translate, regcomp, regexec, print_double_string)
10520 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10521 (re_compile_pattern, re_exec): Declare arguments and local
10522 variables `size_t' and `ssize_t' and return values `regoff_t', as
10523 appropriate.
10524 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10525 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10526 <compile_stack_type>: `size' and `avail' are now `size_t'.
10527
10528 * regex.h <regoff_t>: Use ssize_t, not int.
10529 (re_search, re_search_2, re_match, re_match_2): Arguments that
10530 specify buffer/string position and length are now ssize_t and
10531 size_t. Return type is regoff_t.
10532
613052cd
BK
105332011-04-16 Ben Key <bkey76@gmail.com>
10534
10535 * nsfont.m: Fixed bugs in ns_get_family and
10536 ns_descriptor_to_entity that were caused by using free to
10537 deallocate memory blocks that were allocated by xmalloc (via
10538 xstrdup). This caused Emacs to crash when compiled with
10539 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10540 --enable-checking=xmallocoverrun). xfree is now used to
10541 deallocate these memory blocks.
10542
4170f62f 105432011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10544
71b41406
PE
10545 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10546
9587a89d
PE
10547 emacs_write: Accept and return EMACS_INT for sizes.
10548 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10549 et seq.
10550 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10551 Accept and return EMACS_INT.
10552 (emacs_gnutls_write): Return the number of bytes written on
10553 partial writes.
10554 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10555 (emacs_read, emacs_write): Remove check for negative size, as the
10556 Emacs source code has been audited now.
9587a89d
PE
10557 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10558 (emacs_read, emacs_write): Use it.
273a5f82
PE
10559 * process.c (send_process): Adjust to the new signatures of
10560 emacs_write and emacs_gnutls_write. Do not attempt to store
10561 a byte offset into an 'int'; it might overflow.
9587a89d 10562 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10563
3e047f51
PE
10564 * sound.c: Don't assume sizes fit in 'int'.
10565 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10566 Return EMACS_INT, not int.
3e047f51 10567 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10568 Accept EMACS_INT, not int.
10569 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10570 record read return values.
10571
cc39a9db
BK
105722011-04-15 Ben Key <bkey76@gmail.com>
10573
c9d0ec6d
JB
10574 * keyboard.c (Qundefined): Don't declare static since it is used
10575 in nsfns.m.
10576 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10577 static since they are used in nsfont.m.
cc39a9db 10578
6c60eb9f
SM
105792011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10580
10581 * process.c (Qprocessp): Don't declare static.
10582 * lisp.h (Qprocessp): Declare again.
10583
7990b61a
JB
105842011-04-15 Juanma Barranquero <lekktu@gmail.com>
10585
10586 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10587
5d4cb038
PE
105882011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10589
8bd7b830 10590 Improve C-level modularity by making more things 'static'.
cd64ea1d 10591
e3b27b31
PE
10592 Don't publish debugger-only interfaces to other modules.
10593 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10594 (verify_bytepos, count_markers): Move decls to the only modules
10595 that need them.
10596 * region-cache.h (pp_cache): Likewise.
10597 * window.h (check_all_windows): Likewise.
10598 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10599
5d4cb038
PE
10600 * sysdep.c (croak): Now static, if
10601 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10602 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10603
10604 * alloc.c (refill_memory_reserve): Now static if
10605 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10606 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10607
e87b6180
PE
10608 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10609 Define only if USE_LUCID.
10610
ac64929e
PE
10611 * xrdb.c (x_customization_string, x_rm_string): Now static.
10612
6f37259d
PE
10613 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10614 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10615
1683e3ab
PE
10616 * xdisp.c (draw_row_with_mouse_face): Now static.
10617 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10618
de9c2632
PE
10619 * window.h (check_all_windows): Mark externally visible.
10620
2b96acb7
PE
10621 * window.c (window_deletion_count): Now static.
10622
10623 * undo.c: Make symbols static if they're not exported.
10624 (last_undo_buffer, last_boundary_position, pending_boundary):
10625 Now static.
10626
50436f33
PE
10627 * textprop.c (interval_insert_behind_hooks): Now static.
10628 (interval_insert_in_front_hooks): Likewise.
10629
64520e5c
PE
10630 * term.c: Make symbols static if they're not exported.
10631 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10632 (max_frame_lines, tty_set_terminal_modes):
10633 (tty_reset_terminal_modes, tty_turn_off_highlight):
10634 (get_tty_terminal): Now static.
10635 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10636 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10637 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10638 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10639 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10640
1fa53021
PE
10641 * sysdep.c: Make symbols static if they're not exported.
10642 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10643 Now static.
10644 (sigprocmask_set, full_mask): Remove; unused.
10645 (wait_debugging): Mark as visible.
10646 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10647 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10648
d4b43b22
PE
10649 * syntax.c (syntax_temp): Define only if !__GNUC__.
10650
b7c513d0
PE
10651 * sound.c (current_sound_device, current_sound): Now static.
10652
989b29ad
PE
10653 * search.c (searchbufs, searchbuf_head): Now static.
10654
13a55a78
PE
10655 * scroll.c (scroll_cost): Remove; unused.
10656 * dispextern.h (scroll_cost): Remove decl.
10657
de68a1fc
PE
10658 * region-cache.h (pp_cache): Mark as externally visible.
10659
40ccffa6
PE
10660 * process.c: Make symbols static if they're not exported.
10661 (process_tick, update_tick, create_process, chan_process):
10662 (Vprocess_alist, proc_buffered_char, datagram_access):
10663 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10664 (deactivate_process): Mark defn as static, as well as decl.
10665 * lisp.h (create_process): Remove decl.
10666 * process.h (chan_process, Vprocess_alist): Remove decls.
10667
ad64fc97
PE
10668 * print.c: Make symbols static if they're not exported.
10669 (print_depth, new_backquote_output, being_printed, print_buffer):
10670 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10671 (print_interval, print_number_index, initial_stderr_stream):
10672 Now static.
10673 * lisp.h (Fprinc): Remove decl.
10674 (debug_output_compilation_hack): Mark as externally visible.
10675
adddb265
PE
10676 * sysdep.c (croak): Move decl from here to syssignal.h.
10677 * syssignal.h (croak): Put it here, so the API can be checked when
10678 'croak' is called from dissociate_if_controlling_tty.
10679
1717ede2
PE
10680 * minibuf.c: Make symbols static if they're not exported.
10681 (minibuf_save_list, choose_minibuf_frame): Now static.
10682 * lisp.h (choose_minibuf_frame): Remove decl.
10683
fa5fb2bc
PE
10684 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10685
1e3890d1
PE
10686 * lread.c: Make symbols static if they're not exported.
10687 (read_objects, initial_obarray, oblookup_last_bucket_number):
10688 Now static.
10689 (make_symbol): Remove; unused.
10690 * lisp.h (initial_obarray, make_symbol): Remove decls.
10691
8a1414fa
PE
10692 * keyboard.c: Make symbols static if they're not exported.
10693 (single_kboard, recent_keys_index, total_keys, recent_keys):
10694 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10695 (this_single_command_key_start, echoing, last_auto_save):
10696 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10697 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10698 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10699 (Vlispy_mouse_stem, double_click_count):
10700 Now static.
10701 (force_auto_save_soon): Define only if SIGDANGER.
10702 (ignore_mouse_drag_p): Now static if
10703 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10704 (print_help): Remove; unused.
10705 (stop_character, last_timer_event): Mark as externally visible.
10706 * keyboard.h (ignore_mouse_drag_p): Declare only if
10707 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10708 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10709 * lisp.h (echoing): Remove decl.
10710 (force_auto_save_soon): Declare only if SIGDANGER.
10711 * xdisp.c (redisplay_window): Simplify code, to make it more
10712 obvious that ignore_mouse_drag_p is not accessed if !defined
10713 USE_GTK && !defined HAVE_NS.
10714
93ea6e8f
PE
10715 * intervals.c: Make symbols static if they're not exported.
10716 (merge_properties_sticky, merge_interval_right, delete_interval):
10717 Now static.
10718 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10719
77382fcc
PE
10720 * insdel.c: Make symbols static if they're not exported.
10721 However, leave prepare_to_modify_buffer alone. It's never
10722 called from outside this function, but that appears to be a bug.
10723 (combine_after_change_list, combine_after_change_buffer):
4889fc82 10724 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
10725 (adjust_after_replace_noundo): Remove; unused.
10726 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 10727 (signal_before_change): Remove decls.
77382fcc 10728
9306c32e
PE
10729 * indent.c (val_compute_motion, val_vmotion): Now static.
10730
cd44d2eb
PE
10731 * image.c: Make symbols static if they're not exported.
10732 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10733 if USE_GTK.
10734 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10735 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10736
ad9a7a06
PE
10737 * fringe.c (standard_bitmaps): Now static.
10738 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10739
81626931
PE
10740 * frame.c: Make symbols static if they're not exported.
10741 (x_report_frame_params, make_terminal_frame): Now static.
10742 (get_frame_param): Now static, unless HAVE_NS.
10743 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10744 (x_get_resource_string): Remove; not used.
10745 * frame.h (make_terminal_frame, x_report_frame_params):
10746 (x_get_resource_string); Remove decls.
10747 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10748 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10749
239f9db9
PE
10750 * font.c, fontset.c: Make symbols static if they're not exported.
10751 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10752 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10753 * font.c (font_close_object): Now static.
10754 * font.h (font_close_object): Remove.
10755 * fontset.c (FONTSET_OBJLIST): Remove.
10756 (free_realized_fontset) #if-0 the body, which does nothing.
10757 (face_suitable_for_char_p): #if-0, as it's never called.
10758 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
10759 * xfaces.c (face_at_string_position):
10760 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
10761 since 0 is always ASCII.
10762
dfcf3579
PE
10763 * fns.c (weak_hash_tables): Now static.
10764
5045092b
PE
10765 * fileio.c: Make symbols static if they're not exported.
10766 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10767 (Vwrite_region_annotation_buffers): Now static.
10768
57a96f5c
PE
10769 * eval.c: Make symbols static if they're not exported.
10770 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10771 * lisp.h (backtrace_list): Remove decl.
10772
35f08c38
PE
10773 * emacs.c: Make symbols static if they're not exported.
10774 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10775 (fatal_error_code, fatal_error_signal_hook, standard_args):
10776 Now static.
10777 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10778 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10779 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10780 * lisp.h (fatal_error_signal_hook): Remove decl.
10781 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10782
f44bd759
PE
10783 * editfns.c: Move a (normally-unused) function to its only use.
10784 * editfns.c, lisp.h (get_operating_system_release): Remove.
10785 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10786 worth the hassle of breaking this out.
10787
b532497d
PE
10788 * xterm.c: Make symbols static if they're not exported.
10789 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10790 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10791 (x_destroy_window, x_delete_display):
10792 Now static.
10793 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10794 (x_mouse_leave): Remove; unused.
10795 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10796 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10797 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10798 Remove decls.
10799 (x_mouse_leave): Declare only if WINDOWSNT.
10800 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10801 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10802 USE_X_TOOLKIT.
10803
1675728f
PE
10804 * ftxfont.c: Make symbols static if they're not exported.
10805 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10806 HAVE_FREETYPE.
10807 * font.h (ftxfont_driver): Likewise.
10808
e4cebfca
PE
10809 * xfns.c: Make symbols static if they're not exported.
10810 (x_last_font_name, x_display_info_for_name):
10811 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10812 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10813 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10814 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10815 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10816 (last_show_tip_args): Now static.
10817 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10818 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10819 (x_screen_planes): Remove; unused.
10820 * dispextern.h (x_screen_planes): Remove decl.
10821
5bf46f05
PE
10822 * dispnew.c: Make symbols static if they're not exported.
10823 * dispextern.h (redraw_garbaged_frames, scrolling):
10824 (increment_row_positions): Remove.
10825 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10826 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10827 Now static.
10828 (redraw_garbaged_frames): Remove; unused.
10829
435f4c28
PE
10830 * xfaces.c: Make symbols static if they're not exported.
10831 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10832 Remove decls.
10833 * xterm.h (defined_color): Remove decls.
10834 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10835 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10836 (menu_face_changed_default, defined_color, free_realized_face):
10837 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10838 (ascii_face_of_lisp_face): Remove; unused.
10839
8524aef3
PE
10840 * xdisp.c: Make symbols static if they're not exported.
10841 * dispextern.h (scratch_glyph_row, window_box_edges):
10842 (glyph_to_pixel_coords, set_cursor_from_row):
10843 (get_next_display_element, set_iterator_to_next):
10844 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10845 (show_mouse_face): Remove decls
10846 * frame.h (message_buf_print): Likewise.
10847 * lisp.h (pop_message, set_message, check_point_in_composition):
10848 Likewise.
10849 * xterm.h (set_vertical_scroll_bar): Likewise.
10850 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10851 (message_buf_print, scratch_glyph_row, displayed_buffer):
10852 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10853 (get_next_display_element, show_mouse_face, window_box_edges):
10854 (frame_to_window_pixel_xy, check_point_in_composition):
10855 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10856 (glyph_to_pixel_coords): Remove; unused.
10857
16390cd2
PE
10858 * dired.c (file_name_completion): Now static.
10859
10860 * dbusbind.c (xd_in_read_queued_messages): Now static.
10861
a25f4dfa
PE
10862 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10863 * data.c (circular_list_error): Remove.
10864
14a9c8df
PE
10865 * commands.h (last_point_position, last_point_position_buffer):
10866 (last_point_position_window): Remove decls.
10867 * keyboard.c: Make these variables static.
10868
04f2d78b
CB
10869 * coding.h (coding, code_convert_region, encode_coding_gap):
10870 Remove decls.
74ab6df5
PE
10871 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10872 (iso_code_class, detect_coding, code_convert_region): Now static.
10873 (encode_coding_gap): Remove; unused.
10874
38dfbee1
PE
10875 * chartab.c (chartab_chars, chartab_bits): Now static.
10876
a2cb4e63
PE
10877 * charset.h (charset_iso_8859_1): Remove decl.
10878 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10879 Now static.
10880
127198fd
PE
10881 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10882 * ccl.c (Vccl_program_table): Now static.
10883 (check_ccl_update): Remove; unused.
10884
d85b608f
PE
10885 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10886 * category.h: ... from here.
10887 * category.c (check_category_table, set_category_set): Now static.
10888
31cd66f3
PE
10889 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10890 * lisp.h: Remove these decls.
10891
c358e587
PE
10892 * buffer.c (buffer_count): Remove unused var.
10893
e78aecca
PE
10894 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10895 so that it's not optimized away.
10896 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10897 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10898 exported only to the debugger.
10899
e192d7d3 10900 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10901 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10902
92470028
PE
10903 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10904 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10905 was inaccessible from Lisp.
10906 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10907 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10908
244ed907
PE
10909 alloc.c: Import and export fewer symbols, and remove unused items.
10910 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10911 is defined.
10912 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10913 it's not optimized away by whole-program optimization.
10914 (message_enable_multibyte, free_misc): Remove.
10915 (catchlist, handlerlist, mark_backtrace):
10916 Declare only if BYTE_MARK_STACK.
10917 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10918 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10919 (message_enable_multibyte): Remove decl.
10920 (free_misc, interval_free_list, float_block, float_block_index):
10921 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10922 (cons_free_list, last_marked_index):
10923 Now static.
10924 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10925 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10926 (mark_backtrace): Define only if BYTE_MARK_STACK.
10927 * xdisp.c (message_enable_multibyte): Now static.
10928
61c2b50e 10929 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10930 This makes it easier for human readers (and static analyzers)
10931 to see whether these variables are used from other modules.
10932 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10933 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10934 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10935 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10936 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10937 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10938 * xmenu.c, xselect.c:
10939 Declare Q* vars static if they are not used in other modules.
10940 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10941 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10942 Remove decls of unexported vars.
10943 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10944
95c82688
PE
10945 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10946
16a97296
PE
10947 Make Emacs functions such as Fatom 'static' by default.
10948 This makes it easier for human readers (and static analyzers)
10949 to see whether these functions can be called from other modules.
10950 DEFUN now defines a static function. To make the function external
10951 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10952 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10953 (Finit_image_library):
16a97296
PE
10954 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10955 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10956 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10957 Remove decls, since these functions are now static.
10958 (Funintern, Fget_internal_run_time): New decls, since these functions
10959 were already external.
95c82688 10960
16a97296
PE
10961 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10962 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10963 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10964 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10965 * keyboard.c, keymap.c, lread.c:
10966 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10967 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10968 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10969 Mark functions with DEFUE instead of DEFUN,
10970 if they are used in other modules.
10971 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10972 decls for now-static functions.
10973 * buffer.h (Fdelete_overlay): Remove decl.
10974 * callproc.c (Fgetenv_internal): Mark as internal.
10975 * composite.c (Fremove_list_of_text_properties): Remove decl.
10976 (Fcomposition_get_gstring): New forward static decl.
10977 * composite.h (Fcomposite_get_gstring): Remove decl.
10978 * dired.c (Ffile_attributes): New forward static decl.
10979 * doc.c (Fdocumntation_property): New forward static decl.
10980 * eval.c (Ffetch_bytecode): New forward static decl.
10981 (Funintern): Remove extern decl; now in .h file where it belongs.
10982 * fileio.c (Fmake_symbolic_link): New forward static decl.
10983 * image.c (Finit_image_library): New forward static decl.
10984 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10985 * intervals.h (Fprevious_property_change):
10986 (Fremove_list_of_text_properties): Remove decls.
10987 * keyboard.c (Fthis_command_keys): Remove decl.
10988 (Fcommand_execute): New forward static decl.
10989 * keymap.c (Flookup_key): New forward static decl.
10990 (Fcopy_keymap): Now static.
10991 * keymap.h (Flookup_key): Remove decl.
10992 * process.c (Fget_process): New forward static decl.
10993 (Fprocess_datagram_address): Mark as internal.
10994 * syntax.c (Fsyntax_table_p): New forward static decl.
10995 (skip_chars): Remove duplicate decl.
10996 * textprop.c (Fprevious_property_change): New forward static decl.
10997 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10998 Now internal.
10999 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11000 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11001
785bbd42
PE
11002 * editfns.c (Fformat): Remove unreachable code.
11003
8b913b57
AS
110042011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11005
11006 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11007 change. (Bug#8496)
11008
a6744a35
EZ
110092011-04-13 Eli Zaretskii <eliz@gnu.org>
11010
11011 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11012 when at ZV. (Bug#8487)
11013
e7974947
AS
110142011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11015
baad03f0
AS
11016 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11017 (Bug#8437)
11018 * keyboard.c (parse_tool_bar_item): Likewise.
11019 * sound.c (sound_cleanup, alsa_close): Likewise.
11020 * termcap.c (tgetent): Likewise.
11021 * xfns.c (x_default_font_parameter): Likewise.
11022 * xsettings.c (read_and_apply_settings): Likewise.
11023
e7974947
AS
11024 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11025 (overrun_check_free): Protoize.
11026
28272684
PE
110272011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11028
11029 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11030 since callers should never pass a negative size.
11031 Change the signature to match that of plain 'read' and 'write'; see
11032 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11033 * lisp.h: Update prototypes of emacs_write and emacs_read.
11034
11997c76
EZ
110352011-04-11 Eli Zaretskii <eliz@gnu.org>
11036
11037 * xdisp.c (redisplay_window): Don't try to determine the character
11038 position of the scroll margin if the window start point w->startp
e896f03c 11039 is outside the buffer's accessible region. (Bug#8468)
11997c76 11040
8a2cbd72
EZ
110412011-04-10 Eli Zaretskii <eliz@gnu.org>
11042
11043 Fix write-region and its subroutines for buffers > 2GB.
11044 * fileio.c (a_write, e_write): Modify declaration of arguments and
11045 local variables to support buffers larger than 2GB.
11046 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11047
11048 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11049 argument, local variables, and return value.
11050
11051 * lisp.h: Update prototypes of emacs_write and emacs_read.
11052
11053 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11054
4073e537 110552011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11056
1ebfdcb6
PE
11057 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11058
b2ded58d
PE
11059 Fix more problems found by GCC 4.6.0's static checks.
11060
7d66342c
PE
11061 * xdisp.c (vmessage): Use a better test for character truncation.
11062
bbf47d44
PE
11063 * charset.c (load_charset_map): <, not <=, for optimization,
11064 and to avoid potential problems with integer overflow.
9248994d 11065 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11066 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11067 * editfns.c (Fformat): Likewise.
1e69125e 11068 * syntax.c (skip_chars): Likewise.
3befa583 11069
e3019616
PE
11070 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11071 This also lets GCC 4.6.0 generate slightly better loop code.
11072
becfa255
PE
11073 * callint.c (Fcall_interactively): <, not <=, for optimization.
11074 (Fcall_interactively): Count the number of arguments produced,
11075 not the number of arguments given. This is simpler and lets GCC
11076 4.6.0 generate slightly better code.
11077
dae0cd48
PE
11078 * ftfont.c: Distingish more carefully between FcChar8 and char.
11079 The previous code passed unsigned char * to a functions like
11080 strlen and xstrcasecmp that expect char *, which does not
11081 conform to the C standard.
11082 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11083 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11084 char * when the C standard requires it.
11085
76032d70
PE
11086 * keyboard.c (read_char): Remove unused var.
11087
eb3f1cc8
PE
11088 * eval.c: Port to Windows vsnprintf (Bug#8435).
11089 Include <limits.h>.
11090 (SIZE_MAX): Define if the headers do not.
11091 (verror): Do not give up if vsnprintf returns a negative count.
11092 Instead, grow the buffer. This ports to Windows vsnprintf, which
11093 does not conform to C99. Problem reported by Eli Zaretskii.
11094 Also, simplify the allocation scheme, by avoiding the need for
11095 calling realloc, and removing the ALLOCATED variable.
11096
70476b54
PE
11097 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11098
12020a9e
PE
11099 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11100 But keep the doprint source code for now, as we might revamp it
11101 and use it again (Bug#8435).
ea6c7ae6
PE
11102 * lisp.h (doprnt): Remove.
11103 * Makefile.in (base_obj): Remove doprnt.o.
11104 * deps.mk (doprnt.o): Remove.
11105
5fdb398c
PE
11106 error: Print 32- and 64-bit integers portably (Bug#8435).
11107 Without this change, on typical 64-bit hosts error ("...%d...", N)
11108 was used to print both 32- and 64-bit integers N, which relied on
11109 undefined behavior.
61bdb816 11110 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11111 * lisp.h (error, verror): Mark as printf-like functions.
11112 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11113 Report overflow in size calculations when allocating printf buffer.
11114 Do not truncate output string at its first null byte.
11115 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11116 Truncate the output at a character boundary, since vsnprintf does not
11117 do that.
11118 * charset.c (check_iso_charset_parameter): Convert internal
11119 character to string before calling 'error', since %c now has the
11120 printf meaning.
11121 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11122 overflow when computing char to be passed to 'error'. Do not
11123 pass Lisp_Object to 'error'; pass the integer instead.
11124 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11125 formatted with plain %d.
11126
b189fa66
PE
11127 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11128
bff87ef0
PE
11129 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11130
7e2cac20
PE
11131 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11132
ce4d90b5
PE
11133 * xterm.c (x_catch_errors): Remove duplicate declaration.
11134
266c9547
PE
11135 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11136
79c49ad2
PE
11137 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11138
368f4090
JM
111392011-04-10 Jim Meyering <meyering@redhat.com>
11140
11141 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11142 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11143 return ssize_t not "int", and use size_t as the buffer length.
11144 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11145 * gnutls.h: Update declarations.
11146 * process.c (read_process_output): Use ssize_t, to match.
11147 (send_process): Likewise.
11148
a32d4040
CY
111492011-04-09 Chong Yidong <cyd@stupidchicken.com>
11150
11151 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11152
8546720e 111532011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11154
04f2d78b
CB
11155 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11156 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11157
8546720e
GM
11158 * xterm.c (handle_one_xevent):
11159 * xmenu.c (create_and_show_popup_menu):
11160 * xselect.c (x_decline_selection_request)
11161 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11162
0a2f5c1a 111632011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11164
11165 Fix some uses of `int' instead of EMACS_INT.
11166 * search.c (string_match_1, fast_string_match)
11167 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11168 (scan_buffer, find_next_newline_no_quit)
11169 (find_before_next_newline, search_command, Freplace_match)
11170 (Fmatch_data): Make some `int' variables be EMACS_INT.
11171
11172 * xdisp.c (display_count_lines): 3rd argument and return value now
11173 EMACS_INT. All callers changed.
11174 (pint2hrstr): Last argument is now EMACS_INT.
11175
11176 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11177 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11178 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11179 (decode_coding_utf_16, decode_coding_emacs_mule)
11180 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11181 (decode_coding_ccl, decode_coding_charset)
11182 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11183 (decode_coding_iso_2022, decode_coding_emacs_mule)
11184 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11185 <char_offset, last_offset>: Declare EMACS_INT.
11186 (encode_coding_utf_8, encode_coding_utf_16)
11187 (encode_coding_emacs_mule, encode_invocation_designation)
11188 (encode_designation_at_bol, encode_coding_iso_2022)
11189 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11190 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11191 Declare EMACS_INT.
11192 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11193 (encode_invocation_designation): Last argument P_NCHARS is now
11194 EMACS_INT.
11195 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11196 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11197
11198 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11199 All users changed.
11200
11201 * ccl.c (Fccl_execute_on_string): Declare some variables
11202 EMACS_INT.
11203
8546720e 112042011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11205
11206 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11207
4e19a977
CS
112082011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11209
11210 * process.c (Fformat_network_address): Doc fix.
11211
87302331
R
112122011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11213
ee7683eb 11214 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11215
cbb59342
CY
112162011-04-08 Chong Yidong <cyd@stupidchicken.com>
11217
11218 * keyboard.c (read_char): Call Lisp function help-form-show,
11219 instead of using internal_with_output_to_temp_buffer.
11220 (Qhelp_form_show): New var.
e0d38eeb 11221 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11222
11223 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11224
11225 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11226
e67a13ab
CY
112272011-04-06 Chong Yidong <cyd@stupidchicken.com>
11228
04f2d78b
CB
11229 * process.c (Flist_processes): Remove to Lisp.
11230 (list_processes_1): Delete.
e67a13ab 11231
973f782d
EZ
112322011-04-06 Eli Zaretskii <eliz@gnu.org>
11233
7c106b1e
EZ
11234 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11235
973f782d
EZ
11236 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11237
41cf7d1a 112382011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11239
ca23cc88
PE
11240 Fix more problems found by GCC 4.6.0's static checks.
11241
f390e2d5
PE
11242 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11243
42eea0d0
PE
11244 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11245
b69769da 11246 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11247
f9541e84
PE
11248 * xdisp.c (vmessage): Mark as a printf-like function.
11249
13841b55
PE
11250 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11251
c136c10f
PE
11252 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11253
5e2d4a30
PE
11254 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11255 printf-like functions.
11256 (tiff_load): Add casts to remove these marks before passing them
11257 to system-supplied API.
11258
583f48b9
PE
11259 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11260
b25d760e
PE
11261 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11262 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11263 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11264 directly, rather than having caller test rule sign. This avoids
11265 some unnecessary tests.
11266 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11267 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11268 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11269
bc7b6697 11270 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11271 (xfont_open): Avoid unnecessary tests.
bc7b6697 11272
27ccc379
PE
11273 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11274
dcd5c89a
PE
11275 * composite.h, composite.c (composition_gstring_put_cache):
11276 Use EMACS_INT, not int, for length.
11277
b13a45c6
PE
11278 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11279 breaking out part of COMPOSITION_DECODE_RULE.
11280 (COMPOSITION_DECODE_RULE): Use it.
11281 * composite.c (get_composition_id): Remove unused local vars,
11282 by using the new macro.
11283
1e792e4d
PE
11284 * textprop.c (set_text_properties_1): Change while to do-while,
11285 since the condition is always true at first.
11286
dc6c6455 11287 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11288 (interval_deletion_adjustment): Return unsigned value.
11289 All uses changed.
dc6c6455 11290
aba7731a
PE
11291 * process.c (list_processes_1, create_pty, read_process_output):
11292 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11293 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11294 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11295 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11296 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11297
fdfc4bf3
PE
11298 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11299
fca8fe46 11300 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11301 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11302
06a0259a 11303 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11304 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11305 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11306
e7b9e80f
PE
11307 * print.c (print_error_message): Avoid int overflow.
11308
56201685
PE
11309 * font.c (font_list_entities): Redo for clarity,
11310 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11311
78834453 11312 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11313 (font_score): Avoid potential overflow in diff calculation.
78834453 11314
0bc0b309 11315 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11316 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11317
e610eaca
PE
11318 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11319
b895abce
PE
11320 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11321 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11322 can always succeed if overflow has undefined behavior.
11323
1f1d9321 11324 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11325 (wordify): Omit three unnecessary tests.
1f1d9321 11326
c59478bc
PE
11327 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11328 All callers changed. This avoids the need for an unused var.
11329
79b73827
PE
11330 * casefiddle.c (casify_region): Remove var that is set but not used.
11331
a4db5dfe
PE
11332 * dired.c (file_name_completion): Remove var that is set but not used.
11333
43aae36e
PE
11334 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11335
2a47c44d 11336 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 11337 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 11338
a37c69bf
PE
11339 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11340 Check for integer overflow on size calculations.
11341
328ab8e7
PE
11342 * buffer.c (Fprevious_overlay_change): Remove var that is set
11343 but not used.
11344
e5a2a5cb
PE
11345 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11346 Remove vars that are set but not used.
8d84a6eb 11347 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 11348 (timer_check_2): Mark vars as initialized.
e5a2a5cb 11349
a60e5f68
PE
11350 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11351
f661cb61 11352 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 11353 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 11354
f0397f5a
PE
11355 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11356 that are set but not used.
11357
8664db06 11358 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 11359 if XCreateBitmapFromData fails (Bug#8410).
8664db06 11360
6abdaa4a
PE
11361 * xselect.c (x_get_local_selection, x_handle_property_notify):
11362 Remove vars that are set but not used.
11363
0ce7538d 11364 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 11365 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 11366
9ae848fc
PE
11367 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11368 Remove var that is set but not used.
0b918413
PE
11369 (scroll_bar_windows_size): Now size_t, not int.
11370 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11371 Check for overflow.
9ae848fc 11372
a5a62657
PE
11373 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11374 (map_tty_color) [!defined MSDOS]: Likewise.
11375
5c5cdd39
PE
11376 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11377
66ebf983
PE
11378 * coding.c: Remove vars that are set but not used.
11379 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11380 All callers changed.
11381 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11382 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11383 (decode_coding_charset): Remove vars that are set but not used.
11384
1be4d761
PE
11385 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11386 that is set but not used.
11387
47553fa8
PE
11388 * print.c (print_object): Remove var that is set but not used.
11389
1f7196bf 11390 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
11391 The gnulib version avoids calling malloc in the usual case,
11392 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11393 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11394 * filelock.c (current_lock_owner): Likewise.
11395 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11396 * sysdep.c: Include allocator.h, careadlinkat.h.
11397 (emacs_no_realloc_allocator): New static constant.
11398 (emacs_readlink): New function.
fdb61804
PE
11399 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11400 ../lib/careadlinkat.h.
d1fdcab7 11401
f84c17c7
SM
114022011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11403
11404 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11405 first non-nil return value).
11406
ef3862ad
JD
114072011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11408
11409 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11410 if not defined (Bug#8403).
11411
376a7006
JB
114122011-04-02 Juanma Barranquero <lekktu@gmail.com>
11413
11414 * xdisp.c (display_count_lines): Remove parameter `start',
11415 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11416 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11417 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11418 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11419 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11420 and thereabouts. All callers changed.
11421 (get_per_char_metric): Remove parameter `f', unused since
11422 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11423
6ca3801d
JM
114242011-04-02 Jim Meyering <meyering@redhat.com>
11425
11426 do not dereference NULL upon failed strdup
11427 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11428 (ns_get_family): Likewise.
11429
d8e2b5ba
JB
114302011-04-02 Juanma Barranquero <lekktu@gmail.com>
11431
11432 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11433
8c74fcbd
JD
114342011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11435
11436 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11437 later (Bug#8403).
11438
7200d79c
SM
114392011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11440
03408648 11441 Add lexical binding.
7200d79c 11442
03408648
SM
11443 * window.c (Ftemp_output_buffer_show): New fun.
11444 (Fsave_window_excursion):
11445 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11446
11447 * lread.c (lisp_file_lexically_bound_p): New function.
11448 (Fload): Bind Qlexical_binding.
11449 (readevalloop): Remove `evalfun' arg.
11450 Bind Qinternal_interpreter_environment.
11451 (Feval_buffer): Bind Qlexical_binding.
11452 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11453 Mark as dynamic.
11454 (syms_of_lread): Declare `lexical-binding'.
11455
11456 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11457
11458 * keyboard.c (eval_dyn): New fun.
11459 (menu_item_eval_property): Use it.
ca105506
SM
11460
11461 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11462
03408648
SM
11463 * fns.c (concat, mapcar1): Accept byte-code-functions.
11464
11465 * eval.c (Fsetq): Handle lexical vars.
11466 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11467 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11468 (FletX, Flet): Obey lexical binding.
11469 (Fcommandp): Handle closures.
11470 (Feval): New `lexical' arg.
11471 (eval_sub): New function extracted from Feval. Use it almost
11472 everywhere where Feval was used. Look up vars in lexical env.
11473 Handle closures.
11474 (Ffunctionp): Move from subr.el.
11475 (Ffuncall): Handle closures.
11476 (apply_lambda): Remove `eval_flags'.
11477 (funcall_lambda): Handle closures and new byte-code-functions.
11478 (Fspecial_variable_p): New function.
11479 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11480 but without exporting it to Lisp.
23aba0ea 11481
23aba0ea 11482 * doc.c (Fdocumentation, store_function_docstring):
03408648 11483 * data.c (Finteractive_form): Handle closures.
23aba0ea 11484
03408648
SM
11485 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11486 interactive spec.
ba83908c 11487
04f2d78b
CB
11488 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11489 New byte-codes.
03408648
SM
11490 (exec_byte_code): New function extracted from Fbyte_code to handle new
11491 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11492
03408648 11493 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11494
03408648 11495 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11496
e2abce01
JB
114972011-03-31 Juanma Barranquero <lekktu@gmail.com>
11498
11499 * xdisp.c (redisplay_internal): Fix prototype.
11500
63696a73 115012011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11502
63696a73 11503 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11504 (try_scrolling): Use it when setting scroll_limit.
11505 Limit scrolling to 100 screen lines.
63696a73
EZ
11506 (redisplay_window): Even when falling back on "recentering",
11507 position point in the window according to scroll-conservatively,
11508 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11509
11510 (try_scrolling): When point is above the window, allow searching
11511 as far as scroll_max, or one screenful, to compute vertical
11512 distance from PT to the scroll margin position. This prevents
11513 try_scrolling from unnecessarily failing when
11514 scroll-conservatively is set to a value slightly larger than the
11515 window height. Clean up the case of PT below the margin at bottom
11516 of window: scroll_max can no longer be INT_MAX. When aggressive
11517 scrolling is in use, don't let point enter the opposite scroll
11518 margin as result of the scroll.
11519 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
11520 threshold of 100 lines for never-recentering scrolling.
11521
e4cc2dfc
JB
115222011-03-31 Juanma Barranquero <lekktu@gmail.com>
11523
11524 * dispextern.h (move_it_by_lines):
11525 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11526 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11527 (message_log_check_duplicate): Remove parameters `prev_bol' and
11528 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11529 (redisplay_internal): Remove parameter `preserve_echo_area',
11530 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11531
11532 * indent.c (Fvertical_motion):
11533 * window.c (window_scroll_pixel_based, Frecenter):
11534 Don't pass `need_y_p' to `move_it_by_lines'.
11535
1c470562
SM
115362011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11537
44f230aa
SM
11538 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11539 steal a few bits to be more compact.
11540 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11541 Remove unneeded casts.
11542
1c470562
SM
11543 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11544
888adce9
ZK
115452011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11546
11547 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11548 binding" message (bug#7967).
11549
f838ed7b
PE
115502011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11551
77861b95
PE
11552 Fix more problems found by GCC 4.6.0's static checks.
11553
de6dbc14
PE
11554 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11555 Remove unused local var.
11556
f838ed7b
PE
11557 * editfns.c (Fmessage_box): Remove unused local var.
11558
792c7b2b
PE
11559 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11560 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11561 Omit unused local vars.
c499e557 11562 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11563 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11564 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11565 Omit unused local var.
11566
ba0165e1
PE
11567 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11568 Don't assume string length fits in int.
32ad8845 11569 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11570 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11571
3c59b4c9
PE
11572 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11573 instead of alloca (Bug#8344).
11574
a3eed478 11575 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11576 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11577
eb4d412d
PE
11578 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11579
1658b401
PE
11580 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11581 concerns.
11582
11583 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11584
11585 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11586
9a2c6e05
PE
11587 * keyboard.c (syms_of_keyboard): Use the same style as later
11588 in this function when indexing through an array. This also
11589 works around GCC bug 48267.
11590
03d0a109
PE
11591 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11592
44f730c8
PE
11593 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11594
fe75f926
PE
11595 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11596 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11597
ffa8c828
PE
11598 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11599 This avoids undefined behavior on integer overflow, and is a bit
11600 more convenient anyway since it is compared to a size_t variable.
11601
c5101a77
PE
11602 Variadic C functions now count arguments with size_t, not int.
11603 This avoids an unnecessary limitation on 64-bit machines, which
11604 caused (substring ...) to crash on large vectors (Bug#8344).
11605 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11606 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11607 All variadic functions and their callers changed accordingly.
c5101a77
PE
11608 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11609 * data.c (arith_driver, float_arith_driver): Likewise.
11610 * editfns.c (general_insert_function): Likewise.
11611 * eval.c (struct backtrace.nargs, interactive_p)
11612 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11613 (funcall_lambda, mark_backtrace): Likewise.
11614 * fns.c (concat): Likewise.
11615 * frame.c (x_set_frame_parameters): Likewise.
11616 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11617 0 if not found, not -1. All callers changed.
11618
dd3f25f7
PE
11619 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11620 (stack_copy_size): Now size_t, not int.
11621 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11622
461c2ab9
JB
116232011-03-28 Juanma Barranquero <lekktu@gmail.com>
11624
11625 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11626 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11627 All callers changed.
11628
11629 * lisp.h (multibyte_char_to_unibyte):
11630 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11631 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11632 * character.h (CHAR_TO_BYTE8):
11633 * cmds.c (internal_self_insert):
11634 * editfns.c (general_insert_function):
11635 * keymap.c (push_key_description):
11636 * search.c (Freplace_match):
11637 * xdisp.c (message_dolog, set_message_1): All callers changed.
11638
f6d62986
SM
116392011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11640
11641 * keyboard.c (safe_run_hook_funcall): New function.
11642 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11643 don't set the hook to nil, but remove the offending function instead.
11644 (Qcommand_hook_internal): Remove, unused.
11645 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11646 Vcommand_hook_internal.
11647
11648 * eval.c (enum run_hooks_condition): Remove.
11649 (funcall_nil, funcall_not): New functions.
11650 (run_hook_with_args): Call each function through a `funcall' argument.
11651 Remove `cond' argument, now redundant.
11652 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11653 (Frun_hook_with_args_until_failure): Adjust accordingly.
11654 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11655
1db5b1ad
JB
116562011-03-28 Juanma Barranquero <lekktu@gmail.com>
11657
11658 * dispextern.h (string_buffer_position): Remove declaration.
11659
11660 * print.c (strout): Remove parameter `multibyte', unused since
11661 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11662
11663 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11664 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11665 All callers changed.
11666
11667 * w32.c (_wsa_errlist): Use braces for struct initializers.
11668
11669 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11670 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11671 All callers changed.
11672 (string_buffer_position): Likewise. Also, make static (it's never
11673 used outside xdisp.c).
11674 (cursor_row_p): Remove parameter `w', unused since
11675 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11676 (decode_mode_spec): Remove parameter `precision', introduced during
11677 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11678 All callers changed.
11679
5ffb62aa
JD
116802011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11681
11682 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11683
461c2ab9 116842011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11685
11686 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11687 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11688 (ns_update_auto_hide_menu_bar): New functions.
11689 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11690 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11691 ns_constrain_all_frames.
11692 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11693 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11694
5c380ffb
JD
116952011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11696
11697 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11698
9af30bdf
GM
116992011-03-27 Glenn Morris <rgm@gnu.org>
11700
11701 * syssignal.h: Replace RETSIGTYPE with void.
11702 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11703 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11704 Replace SIGTYPE with void everywhere.
11705 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11706 * s/template.h (SIGTYPE): Remove commented out definition.
11707
e2abce01
JB
117082011-03-26 Eli Zaretskii <eliz@gnu.org>
11709
11710 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11711 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11712
f868cd8a
JB
117132011-03-26 Juanma Barranquero <lekktu@gmail.com>
11714
59eb0929
JB
11715 * w32.c (read_unc_volume): Use parameter `henum', instead of
11716 global variable `wget_enum_handle'.
11717
11718 * keymap.c (describe_vector): Remove parameters `indices' and
11719 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11720 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11721
f868cd8a
JB
11722 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11723
11724 * keyboard.c (timer_check): Remove parameter `do_it_now',
11725 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11726 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11727 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11728
11729 * keyboard.c (read_char):
11730 * w32menu.c (w32_menu_display_help):
11731 * xmenu.c (show_help_event, menu_help_callback):
11732 Adjust calls to `show_help_echo'.
11733
11734 * gtkutil.c (xg_maybe_add_timer):
11735 * keyboard.c (readable_events):
11736 * process.c (wait_reading_process_output):
11737 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11738
11739 * insdel.c (adjust_markers_gap_motion):
11740 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11741 (gap_left, gap_right): Don't call it.
11742
2ecf6fdb
CY
117432011-03-25 Chong Yidong <cyd@stupidchicken.com>
11744
11745 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11746 incurred during fontification.
11747
6b1f9ba4
JB
117482011-03-25 Juanma Barranquero <lekktu@gmail.com>
11749
11750 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11751 (DEFVAR_PER_BUFFER): Don't pass it.
11752
11753 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11754 (scrolling_window): Don't pass it.
11755
0f4a96b5
JB
117562011-03-25 Juanma Barranquero <lekktu@gmail.com>
11757
11758 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11759
11760 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11761 and `suffix'.
11762 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11763 of variables specific to SELinux and computation of `encoded_absname'.
11764
11765 * image.c (XPutPixel): Remove unused variable `height'.
11766
11767 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11768
11769 * unexw32.c (get_section_info): Remove unused variable `section'.
11770
11771 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11772 (system_process_attributes): Remove unused variable `sess'.
11773 (sys_read): Remove unused variable `err'.
11774
11775 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11776 (w32_wnd_proc): Remove unused variable `isdead'.
11777 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11778 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11779 (x_create_tip_frame): Remove unused variable `tem'.
11780
11781 * w32inevt.c (w32_console_read_socket):
11782 Remove unused variable `no_events'.
11783
11784 * w32term.c (x_draw_composite_glyph_string_foreground):
11785 Remove unused variable `width'.
11786
1149507c
JB
117872011-03-24 Juanma Barranquero <lekktu@gmail.com>
11788
11789 * w32term.c (x_set_glyph_string_clipping):
11790 Don't pass uninitialized region to CombineRgn.
11791
9c88f339
JB
117922011-03-23 Juanma Barranquero <lekktu@gmail.com>
11793
11794 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11795 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11796 (Fx_close_connection): Remove unused variable `i'.
11797
11798 * w32font.c (w32font_draw): Return number of glyphs.
11799 (w32font_open_internal): Remove unused variable `i'.
11800 (w32font_driver): Add missing initializer.
11801
11802 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11803 (fill_in_menu): Remove unused variable `items_added'.
11804
11805 * w32term.c (last_mouse_press_frame): Remove static global variable.
11806 (w32_clip_to_row): Remove unused variable `f'.
11807 (x_delete_terminal): Remove unused variable `i'.
11808
11809 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11810 (NOTHING): Remove unused static global variable.
11811 (uniscribe_check_otf): Remove unused variable `table'.
11812 (uniscribe_font_driver): Add missing initializers.
11813
dee091a3
JD
118142011-03-23 Julien Danjou <julien@danjou.info>
11815
11816 * term.c (Fsuspend_tty, Fresume_tty):
11817 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11818 * window.c (temp_output_buffer_show):
11819 * insdel.c (signal_before_change):
11820 * frame.c (Fhandle_switch_frame):
11821 * fileio.c (Fdo_auto_save):
11822 * emacs.c (Fkill_emacs):
11823 * editfns.c (save_excursion_restore):
11824 * cmds.c (internal_self_insert):
11825 * callint.c (Fcall_interactively):
11826 * buffer.c (Fkill_all_local_variables):
11827 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11828 Use Frun_hooks.
0f4a96b5 11829 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11830 unconditionally since it does the check itself.
dee091a3 11831
2c520ab5 118322011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11833
c9c49752
PE
11834 Fix more problems found by GCC 4.5.2's static checks.
11835
8abc3f12
PE
11836 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11837 the first time through the loop, since we know p0 < p1 then.
11838 This also avoids a gcc -Wstrict-overflow warning.
11839
a2d26660
PE
11840 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11841 leading to a memory leak, possible in functions like
11842 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11843 of objects (Bug#8318).
a2d26660 11844
916c72e9
PE
11845 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11846 that could (at least in theory) be that large.
11847
19ab8a18
PE
11848 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11849 This is less likely to overflow, and avoids undefined behavior if
11850 overflow does occur. All callers changed. Use strtoul to scan
11851 for the unsigned long integer.
b7cbbd6f
PE
11852 (pint2hrstr): Simplify and tune code slightly.
11853 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11854
f0641eff
PE
11855 * scroll.c (do_scrolling): Work around GCC bug 48228.
11856 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11857
7f650bb9
PE
11858 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11859 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11860 (validate_x_resource_name): Simplify count usage.
11861 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11862
37dd57d1
PE
11863 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11864 fail (Bug#8306).
81e56e61 11865
699979fc 11866 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11867
401bf9b4
PE
11868 * process.c (Fmake_network_process): Use socklen_t, not int,
11869 where POSIX says socklen_t is required in portable programs.
11870 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11871 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11872 (Fmake_network_process, server_accept_connection):
11873 (wait_reading_process_output, read_process_output):
11874 Likewise.
11875
b93aacde
PE
11876 * process.c: Rename or move locals to avoid shadowing.
11877 (list_processes_1, Fmake_network_process):
11878 (read_process_output_error_handler, exec_sentinel_error_handler):
11879 Rename or move locals.
4dc343ee 11880 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11881 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11882 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11883 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11884 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11885
af8a867c 11886 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11887 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11888 Include tparam.h instead, since it declares them.
af8a867c
PE
11889 * cm.h (PC): Remove extern decl; tparam.h now does this.
11890 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11891 * terminfo.c: Include tparam.h, to check interfaces.
11892 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11893 (tparam): Adjust signature to match interface in tparam.h;
11894 this removes some undefined behavior. Check that outstring and len
11895 are zero, which they always are with Emacs.
11896 * tparam.h (PC, BC, UP): New extern decls.
11897
0248044d 11898 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11899 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11900
8ff096c1 11901 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11902 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11903 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11904 (ftfont_list): Remove unused local.
49eaafba
PE
11905 (get_adstyle_property, ftfont_pattern_entity):
11906 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11907 Rename locals to avoid shadowing.
8ff096c1 11908
e2be39f6
PE
11909 * xfont.c (xfont_list_family): Mark var as initialized.
11910
c9735e30
PE
11911 * xml.c (make_dom): Now static.
11912
8f5201ae
PE
11913 * composite.c (composition_compute_stop_pos): Rename local to
11914 avoid shadowing.
b246f932
PE
11915 (composition_reseat_it): Remove unused locals.
11916 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11917 (composition_update_it): Mark var as initialized.
11b61122
PE
11918 (find_automatic_composition): Mark vars as initialized,
11919 with a FIXME (Bug#8290).
8f5201ae 11920
760fbc2c
PE
11921 character.h: Rename locals to avoid shadowing.
11922 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11923 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11924 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11925 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11926 to avoid shadowing.
11927
ff08eb85
PE
11928 * textprop.c (property_change_between_p): Remove; unused.
11929
fc7bf025
PE
11930 * intervals.c (interval_start_pos): Now static.
11931
235d7abc
PE
11932 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11933
44f230aa
SM
11934 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11935 Rename locals to avoid shadowing.
3e7d6594 11936
50060332
PE
11937 * sound.c (wav_play, au_play, Fplay_sound_internal):
11938 Fix pointer signedness.
d01f234b 11939 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11940 (wav_play): Initialize a variable to 0, to prevent undefined
11941 behavior (Bug#8278).
50060332 11942
c4fc4e30
PE
11943 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11944
918436ed
PE
11945 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11946
c939f91b
PE
11947 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11948 clobbering (Bug#8298).
b9c7f648
PE
11949 * sysdep.c (sys_subshell): Likewise.
11950 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11951
6bd8c144
PE
11952 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11953 This should get cleaned up, so that child_setup has the
11954 same signature on all platforms.
11955
7710357c 11956 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11957 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11958
c59da222
CY
119592011-03-22 Chong Yidong <cyd@stupidchicken.com>
11960
11961 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11962 not to be necessary, and produces flickering.
11963
66b87493
GM
119642011-03-20 Glenn Morris <rgm@gnu.org>
11965
11966 * config.in: Remove file.
11967
45b6f6d5
JB
119682011-03-20 Juanma Barranquero <lekktu@gmail.com>
11969
11970 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11971 are now in src/globals.h.
11972 (syms_of_minibuf): Remove spurious & from previous change.
11973
cd394be1 119742011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11975
11976 * minibuf.c (completing-read-function): New variable.
11977 (completing-read-default): Rename from completing-read.
11978 (completing-read): Call completing-read-function.
11979
b14e3e21
CY
119802011-03-19 Juanma Barranquero <lekktu@gmail.com>
11981
11982 * xfaces.c (Fx_load_color_file):
11983 Read color file from absolute filename (bug#8250).
11984
f2b726e6
JB
119852011-03-19 Juanma Barranquero <lekktu@gmail.com>
11986
11987 * makefile.w32-in: Update dependencies.
11988
09f6ff02
EZ
119892011-03-17 Eli Zaretskii <eliz@gnu.org>
11990
11991 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11992
29a6015a
PE
119932011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11994
a3a6c54e
PE
11995 Fix more problems found by GCC 4.5.2's static checks.
11996
b766f867
PE
11997 * process.c (make_serial_process_unwind, send_process_trap):
11998 (sigchld_handler): Now static.
11999
be02381c
PE
12000 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12001 That way, the code declares only the vars that it needs.
12002 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12003 * s/cygwin.h (PTY_ITERATION): Likewise.
12004 * s/darwin.h (PTY_ITERATION): Likewise.
12005 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12006
57048744
PE
12007 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12008 * process.c (allocate_pty): Don't declare stb unless it's needed.
12009
7914961c 12010 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12011 (CONSTANTLIM): Remove; unused.
12012 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12013 Define only if needed.
7914961c 12014
b3967b18
PE
12015 * unexelf.c (unexec): Name an expression,
12016 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12017 Use a different way to cause a compilation error if anyone uses
12018 n rather than nn, a way that does not involve shadowing.
73366a00 12019 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12020
29a6015a
PE
12021 * deps.mk (unexalpha.o): Remove; unused.
12022
43cfc33e 12023 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12024 * unexec.h: New file.
ce701a33
PE
12025 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12026 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12027 Depend on unexec.h.
12028 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12029 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12030 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12031 Change as necessary to match prototype in unexec.h.
ce701a33 12032
01f44d5a
PE
12033 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12034 shadowing.
4f63c6bb 12035 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12036
a6670b0b
PE
12037 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12038 Rename locals to avoid shadowing.
12039
cef2010d 12040 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12041 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12042
d4d7173a
PE
12043 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12044
f08b802a
PE
12045 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12046 warning when compiling print.c.
12047
3ddb0639
PE
12048 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12049 instead of using an uninitialized var.
5ad03b97 12050 (font_sort_entities): Mark var as initialized.
3ddb0639 12051
170a2692
PE
12052 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12053
e663c700
PE
12054 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12055 pointers to constants.
89bc529a 12056 (font_parse_fcname): Remove unused vars.
7b81e2d0 12057 (font_delete_unmatched): Now static.
ea838e10 12058 (font_get_spec): Remove; unused.
13a547c6
PE
12059 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12060 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12061 Rename or move locals to avoid shadowing.
e663c700 12062
2a80c887 12063 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12064 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12065
1384fa33 12066 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12067 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12068
8b2c52e9
PE
12069 * alloc.c (mark_backtrace): Move decl from here ...
12070 * lisp.h: ... to here, so that it can be checked.
12071
475545b5 12072 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12073 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12074 (lisp_indirect_variable): Name an expression,
12075 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12076 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12077
b1349114 12078 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12079 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12080 Use const pointer when appropriate.
b1349114 12081
a2928364
PE
12082 * lisp.h (get_system_name, get_operating_system_release):
12083 Move decls here, to check interfaces.
12084 * process.c (get_operating_system_release): Move decl to lisp.h.
12085 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12086 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12087 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12088 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12089 (Fformat_time_string, Fencode_time, Finsert_char):
12090 (Ftranslate_region_internal, Fformat):
12091 Rename or remove local vars to avoid shadowing.
9710023e 12092 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12093
a415e694
PE
12094 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12095 avoid shadowing.
12096
8ef4622d
PE
12097 * lisp.h (eassert): Check that the argument compiles, even if
12098 ENABLE_CHECKING is not defined.
12099
946f9a5b
PE
12100 * data.c (Findirect_variable): Name an expression, to avoid
12101 gcc -Wbad-function-cast warning.
112396d6 12102 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12103 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12104 (Fmake_variable_buffer_local, Fmake_local_variable):
12105 Mark variables as initialized.
52746918 12106 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12107
e5aab7e7 12108 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12109 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12110 Rename locals to avoid shadowing.
dff45157
PE
12111 (mark_stack): Move local variables into the #ifdef region where
12112 they're used.
7bc26fdb
PE
12113 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12114 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12115 needed otherwise.
12116 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12117 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12118 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12119
e5aab7e7
PE
12120 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12121 avoids undefined behavior in theory.
12122
4da60324
PE
12123 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12124
88043301
PE
12125 Use functions, not macros, for up- and down-casing (Bug#8254).
12126 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12127 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12128 to use the following functions instead of these macros.
12129 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12130 EMACS_INT, since callers assume the returned value fits in int.
12131 (upcase1): Likewise, for UPCASE_TABLE.
12132 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12133 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12134 the race-condition problem in the old DOWNCASE.
88043301 12135
19ed5445
PE
12136 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12137 Rename locals to avoid shadowing.
12138 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12139 (regex_compile, re_search_2, re_match_2_internal):
12140 Remove unused local vars.
952db0d7
PE
12141 (FREE_VAR): Rewrite so as not to use empty "else",
12142 which gcc can warn about.
da053e48 12143 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12144 (RETALLOC_IF): Define only if needed.
12145 (WORDCHAR_P): Likewise. This one is never needed, but is used
12146 only in a comment talking about a compiler bug, so put inside
12147 the #if 0 of that comment.
12148 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12149 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12150 Remove; unused.
19ed5445 12151
1f3561e4 12152 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12153 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12154 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12155
ded6f8f7
PE
12156 * search.c (simple_search): Remove unused var.
12157
dbd37a95
PE
12158 * dired.c (compile_pattern): Move decl from here ...
12159 * lisp.h: ... to here, so that it can be checked.
12160 (struct re_registers): New forward decl.
12161
7e47afad
PE
12162 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12163
85f24f61
PE
12164 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12165 All uses changed.
12166 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12167 Rename locals to avoid shadowing.
5671df8f 12168 (Fvertical_motion): Mark locals as initialized.
85f24f61 12169
181aa2be 12170 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12171 (casify_region): Mark local as initialized.
181aa2be 12172
930d429c
PE
12173 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12174
7082eac6
PE
12175 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12176 New macros, so that the caller can use some names other than
12177 gcpro1, gcpro2, etc.
12178 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12179 of the new macros.
12180 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12181 argument, for consistency with GCPRO2_VAR, etc: it is now the
12182 prefix of the variable, not the variable itself. All uses
12183 changed.
38b2c076
PE
12184 * dired.c (directory_files_internal, file_name_completion):
12185 Rename locals to avoid shadowing.
12186
15206ed9
PE
12187 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12188 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12189 dired.c's scmp function, had undefined behavior.
12190 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12191 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12192 * buffer.h: ... to here, because these macros use current_buffer,
12193 and the new implementation with inline functions needs to have
12194 current_buffer in scope now, rather than later when the macros
12195 are used.
12196 (downcase, upcase1): New static inline functions.
12197 (DOWNCASE, UPCASE1): Reimplement using these functions.
12198 This avoids undefined behavior in expressions like
12199 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12200 from race conditions in accessing the global variables
12201 case_temp1 and case_temp2.
12202 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12203 * lisp.h (case_temp1, case_temp2): Remove their decls.
12204 * character.h (ASCII_CHAR_P): Move from here ...
12205 * lisp.h: ... to here, so that the inline functions mentioned
12206 above can use them.
12207
4a6bea26
PE
12208 * dired.c (directory_files_internal_unwind): Now static.
12209
f14b7e14
PE
12210 * fileio.c (file_name_as_directory, directory_file_name):
12211 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12212 Now static.
2893f146
PE
12213 (file_name_as_directory): Use const pointers when appropriate.
12214 (Fexpand_file_name): Likewise. In particular, newdir might
12215 point at constant storage, so make it a const pointer.
fd4ead52 12216 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12217 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12218 signedness issues.
f839df0c
PE
12219 (Fset_file_times, Finsert_file_contents, auto_save_error):
12220 Rename locals to avoid shadowing.
f14b7e14 12221
5716756e 12222 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12223 (Ftry_completion, Fall_completions): Rename or remove locals
12224 to avoid shadowing.
5716756e 12225
b4c3046a
PE
12226 * marker.c (bytepos_to_charpos): Remove; unused.
12227
b45db522
PE
12228 * lisp.h (verify_bytepos, count_markers): New decls,
12229 so that gcc does not warn that these functions aren't declared.
12230
85876d07
PE
12231 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12232 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12233 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12234 (copy_text): Remove unused local var.
85876d07 12235
03d78a21 12236 * filelock.c (within_one_second): Now static.
b3dd38ab 12237 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12238
5df8f01b
PE
12239 * buffer.c (fix_overlays_before): Mark locals as initialized.
12240 (fix_start_end_in_overlays): Likewise. This function should be
12241 simplified by using pointers-to-pointers, but that's a different
12242 matter.
b1d876f1 12243 (switch_to_buffer_1): Now static.
8f54f30a
PE
12244 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12245 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12246
a70072c9 12247 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12248 Fix pointer signedness issue.
edced198
PE
12249 (sys_subshell): Mark local as volatile if checking for lint,
12250 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12251 (MAXPATHLEN): Define only if needed.
a70072c9 12252
a0977c44
PE
12253 * process.c (serial_open, serial_configure): Move decls from here ...
12254 * systty.h: ... to here, so that they can be checked.
12255
a884fdcc
PE
12256 * fns.c (get_random, seed_random): Move extern decls from here ...
12257 * lisp.h: ... to here, so that they can be checked.
12258
604efe86 12259 * sysdep.c (reset_io): Now static.
b8950c94 12260 (wait_for_termination_signal): Remove; unused.
604efe86 12261
38fc62d9
PE
12262 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12263 (copy_keymap_item, append_key, push_text_char_description):
12264 Now static.
1004a21a 12265 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12266 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12267 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12268 (describe_map_tree):
12269 Rename locals to avoid shadowing.
38fc62d9 12270
2f2650da
PE
12271 * keyboard.c: Declare functions static if they are not used elsewhere.
12272 (echo_char, echo_dash, cmd_error, top_level_2):
12273 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12274 (read_char, kbd_buffer_get_event, make_lispy_position):
12275 (make_lispy_event, make_lispy_movement, apply_modifiers):
12276 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12277 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12278 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12279 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12280 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12281
a053e86c 12282 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12283 (mark_kboards): Move decl here ...
12284 * alloc.c (mark_kboards): ... from here.
a053e86c 12285
4752793e
PE
12286 * lisp.h (force_auto_save_soon): New decl.
12287
74f10ca7 12288 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12289 (DEFINE_DUMMY_FUNCTION): New macro.
12290 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12291 Use it.
c03cd23f
PE
12292 (main): Add casts to avoid warnings
12293 if GCC considers string literals to be constants.
74f10ca7 12294
022e70d4
PE
12295 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12296
59d6fe83
PE
12297 * dbusbind.c: Pointer signedness fixes.
12298 (xd_signature, xd_append_arg, xd_initialize):
12299 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12300 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12301 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12302 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12303
78320123
PE
12304 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12305 if GCC considers string literals to be constants.
49cebcca 12306 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12307
35ac2a97
SM
123082011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12309
fb103ca9
SM
12310 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12311 (print_preprocess, print_object): New macro to fix last change.
12312
35ac2a97
SM
12313 * print.c (print_preprocess): Don't forget font objects.
12314
62973b41
JB
123152011-03-16 Juanma Barranquero <lekktu@gmail.com>
12316
12317 * emacs.c (USAGE3): Doc fixes.
12318
0e48bb22
AS
123192011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12320
12321 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12322 structure.
12323
7684e57b
JB
123242011-03-14 Juanma Barranquero <lekktu@gmail.com>
12325
12326 * lisp.h (VWindow_system, Qfile_name_history):
12327 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12328 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12329 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12330
12331 * w32select.c: Don't #include "keyboard.h".
c96bbc66 12332 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
12333
12334 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12335 * w32console.c (detect_input_pending, read_input_pending)
12336 (encode_terminal_code):
12337 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12338 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12339 (w32_system_caret_y, Qfile_name_history):
12340 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12341 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12342 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12343 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12344 * w32proc.c (Qlocal, report_file_error):
12345 * w32term.c (Vwindow_system, updating_frame):
12346 * w32uniscribe.c (initialized, uniscribe_font_driver):
12347 Remove unneeded extern declarations.
12348
2aa46d6c
CY
123492011-03-14 Chong Yidong <cyd@stupidchicken.com>
12350
c96bbc66 12351 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 12352
cffc6f3b
CY
123532011-03-13 Chong Yidong <cyd@stupidchicken.com>
12354
12355 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12356 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12357 These macros can no longer be used for assignment.
12358
44f230aa
SM
12359 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12360 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
12361 (record_buffer_markers, fetch_buffer_markers): New functions for
12362 recording and fetching special buffer markers.
12363 (set_buffer_internal_1, set_buffer_temp): Use them.
12364
12365 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12366
12367 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12368
12369 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12370 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12371
12372 * xdisp.c (hscroll_window_tree):
12373 (reconsider_clip_changes): Use PT instead of BUF_PT.
12374
d251f04b
EZ
123752011-03-13 Eli Zaretskii <eliz@gnu.org>
12376
12377 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12378 $(EMACS_ROOT)/lib/intprops.h.
12379
f0c77cd1
PE
123802011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12381
3eca4629
PE
12382 Fix more problems found by GCC 4.5.2's static checks.
12383
7c86ee98
PE
12384 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12385 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
12386 (xg_free_frame_widgets): Make it clear that a local variable is
12387 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
12388 (gdk_window_get_screen): Make it clear that this macro is needed
12389 only if USE_GTK_TOOLTIP.
1e5524e7
PE
12390 (int_gtk_range_get_value): New function, which avoids a diagnostic
12391 from gcc -Wbad-function-cast.
12392 (xg_set_toolkit_scroll_bar_thumb): Use it.
12393 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12394 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
12395 (get_utf8_string, xg_get_file_with_chooser):
12396 Rename locals to avoid shadowing.
12397 (create_dialog): Move locals to avoid shadowing.
7c86ee98 12398
41729b81
PE
12399 * xgselect.c (xg_select): Remove unused var.
12400
f0c77cd1
PE
12401 * image.c (four_corners_best): Mark locals as initialized.
12402 (gif_load): Initialize transparent_p to zero (Bug#8238).
12403 Mark another local as initialized.
ec6cf4c6 12404 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 12405
ce0ad53d 12406 * image.c (clear_image_cache): Now static.
d5d5a617 12407 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 12408 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
12409 (x_edge_detection): Remove unnecessary cast that
12410 gcc -Wbad-function-cast diagnoses.
2037898d 12411 (gif_load): Fix pointer signedness.
6ae141d6
PE
12412 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12413 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 12414
33383987 124152011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 12416
d32df629
PE
12417 Improve quality of tests for time stamp overflow.
12418 For example, without this patch (encode-time 0 0 0 1 1
12419 1152921504606846976) returns the obviously-bogus value (-948597
12420 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12421 reports time overflow. See
12422 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
12423 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12424 * editfns.c: Include limits.h and intprops.h.
12425 (TIME_T_MIN, TIME_T_MAX): New macros.
12426 (time_overflow): Move earlier, to before first use.
12427 (hi_time, lo_time): New functions, for an accurate test for
12428 out-of-range times.
12429 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12430 (Fget_internal_run_time): Don't assume time_t fits in int.
12431 (make_time): Use list2 instead of Fcons twice.
12432 (Fdecode_time): More accurate test for out-of-range times.
12433 (check_tm_member): New function.
12434 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12435 (lisp_time_argument): Don't rely on undefined left-shift and
12436 right-shift behavior when checking for time stamp overflow.
8be6f318 12437
fe31d94c
PE
12438 * editfns.c (time_overflow): New function, refactoring common code.
12439 (Fformat_time_string, Fdecode_time, Fencode_time):
12440 (Fcurrent_time_string): Use it.
12441
8be6f318
PE
12442 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12443 * dired.c (make_time): Move to ...
12444 * editfns.c (make_time): ... here.
12445 * systime.h: Note the move.
12446
09d9db2c 124472011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12448
126bc0dc
YM
12449 * fringe.c (update_window_fringes): Remove unused variables.
12450
c47cbdfd
YM
12451 * unexmacosx.c (copy_data_segment): Also copy __got section.
12452 (Bug#8223)
12453
7ac80be9
EZ
124542011-03-12 Eli Zaretskii <eliz@gnu.org>
12455
c96bbc66 12456 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12457 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12458 Constify `char *' arguments and their references according to
12459 prototypes in tparam.h.
12460
ecb0f94d 12461 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12462
7ac80be9
EZ
12463 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12464 Adapt all references accordingly.
12465
12466 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12467
ef1fd07e
TT
124682011-03-11 Tom Tromey <tromey@redhat.com>
12469
12470 * buffer.c (syms_of_buffer): Remove obsolete comment.
12471
7ef4b50c
EZ
124722011-03-11 Eli Zaretskii <eliz@gnu.org>
12473
12474 * termhooks.h (encode_terminal_code): Declare prototype.
12475
12476 * msdos.c (encode_terminal_code): Don't declare prototype.
12477
12478 * term.c (encode_terminal_code): Now external again, used by
12479 w32console.c and msdos.c.
12480
44f230aa
SM
12481 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12482 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12483
4b1ec863 124842011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12485
1714f52b 12486 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12487
4b1ec863
PE
12488 * fringe.c (update_window_fringes): Mark locals as initialized
12489 (Bug#8227).
12490 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12491
524c7aa6
PE
12492 * alloc.c (mark_fringe_data): Move decl from here ...
12493 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12494 to check its interface.
12495 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12496
a5c0af81 12497 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12498 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12499 (fontset_font): Mark local as initialized.
a9a06e0b 12500 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12501
b4716021
PE
12502 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12503
811e9bac 12504 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12505 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12506 (x_own_selection, Fx_disown_selection_internal): Rename locals
12507 to avoid shadowing.
12508 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12509
7e3ab302
PE
12510 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12511 so that the caller can use some name other than gcpro1.
12512 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
12513 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12514 (Fx_backspace_delete_keys_p):
12515 Use them to avoid shadowing, and rename vars to avoid shadowing.
12516 (x_decode_color, x_set_name, x_window): Now static.
6b437900 12517 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 12518 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
12519 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12520 Remove unused locals.
7e3ab302
PE
12521 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12522 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12523 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12524 macros.
f78faa98 12525
e2b13473
PE
12526 * xterm.h (x_mouse_leave): New decl.
12527
77f23912
PE
12528 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12529 Remove unused functions.
cdf4ba58
PE
12530 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12531 (x_calc_absolute_position): Now static.
7411c686 12532 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12533 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12534 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12535 unless they are used.
38d0b34a
PE
12536 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12537 (x_fatal_error_signal): Remove; not used.
a6067996
PE
12538 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12539 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12540 (x_error_catcher, x_connection_closed, x_error_handler):
12541 (x_error_quitter, xembed_send_message, x_iconify_frame):
12542 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12543 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12544 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12545
44f230aa
SM
12546 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12547 Rename or move locals to avoid shadowing.
6b463e58 12548 (tty_defined_color, merge_face_heights): Now static.
5967d051 12549 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12550 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12551 does not deduce is never used uninitialized.
73719eba
PE
12552 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12553 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12554
426994c3 12555 * terminal.c (store_terminal_param): Now static.
5489860b 12556
032f1620 12557 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12558 (set_frame_menubar): Remove unused local.
d4323972 12559 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12560 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12561 since they might point to immutable storage.
281585b0
PE
12562 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12563 since it's unused otherwise.
032f1620 12564
367c19e5 12565 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12566 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12567 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12568 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12569 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12570 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12571 does not deduce are never used uninitialized.
70739cbe 12572
07b48fa9
PE
12573 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12574
8868a238 12575 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12576 * window.c (window_loop, size_window):
12577 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12578
7e5cf297 12579 * window.c (display_buffer): Now static.
d6550a9f
PE
12580 (size_window): Mark variables that gcc -Wuninitialized
12581 does not deduce are never used uninitialized.
a586633d
PE
12582 * window.h (check_all_windows): New decl, to forestall
12583 gcc -Wmissing-prototypes diagnostic.
5b555da1 12584 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12585
f6095868
PE
12586 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12587 shadowing.
12588 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12589 Include <limits.h>.
12590 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12591 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12592 (load_charset_map): Mark variables that gcc -Wuninitialized
12593 does not deduce are never used uninitialized.
53df7c11 12594 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12595
f38b440c
PE
12596 * coding.c (coding_set_source, coding_set_destination):
12597 Use "else { /* comment */ }" rather than "else /* comment */;"
12598 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12599 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12600 a block, when the outer 'i' will do.
12601 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12602 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12603 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12604 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12605 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12606 Rename locals to avoid shadowing.
12607 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12608 * coding.c (emacs_mule_char, encode_invocation_designation):
12609 Now static, since they're not used elsewhere.
413bb2db 12610 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12611 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12612 (decode_coding_emacs_mule): Mark variables that gcc
12613 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12614 (detect_coding_iso_2022): Initialize a local variable that might
12615 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12616 this initialization is needed. (Bug#8211)
5f58e762
PE
12617 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12618 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12619 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12620 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12621 Remove unused macros.
f38b440c 12622
232b38b9 12623 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12624 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12625 * character.c (string_count_byte8): Likewise.
232b38b9 12626
fb90da1b
PE
12627 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12628 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12629
fb93dbc2
PE
12630 * chartab.c (copy_sub_char_table): Now static, since it's not used
12631 elsewhere.
5c156ace
PE
12632 (sub_char_table_ref_and_range, char_table_ref_and_range):
12633 Rename locals to avoid shadowing.
bbcd0949 12634 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12635
7d3b3862 12636 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12637 (BIDI_BOB): Remove unused macro.
7d3b3862 12638
6be7d3da
PE
12639 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12640 deduce are never used uninitialized.
c2ed9c8b 12641 * term.c (encode_terminal_code): Likewise.
6be7d3da 12642
75f8807f 12643 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12644
50938595
PE
12645 * tparam.h: New file.
12646 * term.c, tparam.h: Include it.
12647 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12648 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12649 Move these decls to tparam.h, and make them agree with what
12650 is actually in tparam.c. The previous trick of using incompatible
12651 decls in different modules does not conform to the C standard.
12652 All callers of tparam changed to use tparam's actual API.
12653 * tparam.c (tparam1, tparam, tgoto):
12654 Use const pointers where appropriate.
12655
fbceeba2
PE
12656 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12657 * cm.h (struct cm): Likewise.
12658 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12659 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12660 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12661 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12662 (turn_on_face, init_tty): Likewise.
12663 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12664
7f3f1250
PE
12665 * term.c (term_mouse_position): Rename local to avoid shadowing.
12666
e6ca6543
PE
12667 * alloc.c (mark_ttys): Move decl from here ...
12668 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12669
c40f8d15
AS
126702011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12671
12672 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12673
cfe0661d
JB
126742011-03-09 Juanma Barranquero <lekktu@gmail.com>
12675
12676 * search.c (compile_pattern_1): Remove argument regp, unused since
12677 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12678 (compile_pattern): Don't pass it.
12679
0afb4571
J
126802011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12681
12682 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12683 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12684 for ! HAVE_GTK3.
12685 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12686
12687 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12688
12689 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12690 gdk_window_get_screen, gdk_window_get_geometry,
12691 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12692 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12693 (xg_get_pixbuf_from_pixmap): New function.
12694 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12695 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12696 Call xg_get_pixbuf_from_pixmap instead of
12697 gdk_pixbuf_get_from_drawable.
12698 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12699 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12700 (xg_check_special_colors): Use GtkStyleContext and its functions
12701 for HAVE_GTK3.
12702 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12703 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12704 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
12705 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12706 Call gtk_widget_get_preferred_size.
0afb4571
J
12707 (xg_frame_resized): gdk_window_get_geometry only takes 5
12708 parameters.
44f230aa
SM
12709 (xg_win_to_widget, xg_event_is_for_menubar):
12710 Call gdk_x11_window_lookup_for_display.
0afb4571
J
12711 (xg_set_widget_bg): New function.
12712 (delete_cb): New function.
895009e1 12713 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 12714 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
12715 (xg_set_background_color): Call xg_set_widget_bg.
12716 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12717 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12718 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12719 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12720 if ! HAVE_GTK3.
12721 (update_frame_tool_bar): Call gtk_widget_hide.
12722 (xg_initialize): Use GDK_KEY_g.
12723
12724 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12725 if ! HAVE_GTK3
12726 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12727
12728 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12729 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12730 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12731
1c2cc4ef
JB
127322011-03-08 Juanma Barranquero <lekktu@gmail.com>
12733
12734 * w32xfns.c (select_palette): Check success of RealizePalette against
12735 GDI_ERROR, not zero.
12736
33383987 12737See ChangeLog.11 for earlier changes.
aac0c6e3
MR
12738
12739;; Local Variables:
12740;; coding: utf-8
aac0c6e3
MR
12741;; End:
12742
2f097256 12743 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
12744
12745 This file is part of GNU Emacs.
12746
12747 GNU Emacs is free software: you can redistribute it and/or modify
12748 it under the terms of the GNU General Public License as published by
12749 the Free Software Foundation, either version 3 of the License, or
12750 (at your option) any later version.
12751
12752 GNU Emacs is distributed in the hope that it will be useful,
12753 but WITHOUT ANY WARRANTY; without even the implied warranty of
12754 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12755 GNU General Public License for more details.
12756
12757 You should have received a copy of the GNU General Public License
12758 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.