* doc/misc/sem-user.texi (Semantic mode user commands): Typo fix.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
0992bd9c
CY
12012-02-07 Chong Yidong <cyd@gnu.org>
2
3 * buffer.c (Fbuffer_local_variables)
4 (buffer_lisp_local_variables): Handle unbound vars correctly;
5 don't let Qunbound leak into Lisp.
6
af008560
GM
72012-02-07 Glenn Morris <rgm@gnu.org>
8
dd605cc4
GM
9 * image.c (Fimagemagick_types): Doc fix.
10
af008560
GM
11 * image.c (imagemagick-render-type): Change it from a lisp object
12 to an integer. Move the doc here from the lisp manual.
13 Treat all values not equal to 0 the same.
14
1449fa1d
CY
152012-02-06 Chong Yidong <cyd@gnu.org>
16
17 * doc.c (store_function_docstring): Avoid applying docstring of
18 alias to base function (Bug#2603).
19
3723ec07
AS
202012-02-04 Andreas Schwab <schwab@linux-m68k.org>
21
22 * .gdbinit (pp1, pv1): Remove redundant defines.
23 (pr): Use pp.
24
79c1cc1e
CY
252012-02-04 Chong Yidong <cyd@gnu.org>
26
27 * nsterm.m: Declare a global (Bug#10694).
28
d7f29f8e
EZ
292012-02-04 Eli Zaretskii <eliz@gnu.org>
30
31 * w32.c (get_emacs_configuration_options): Include
32 --enable-checking, if specified, in the return value.
33
3b95a6f9
MR
342012-02-04 Martin Rudalics <rudalics@gmx.at>
35
36 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
37 after rounding frame sizes. (Bug#9723)
38
d6fa96a6
EZ
392012-02-04 Eli Zaretskii <eliz@gnu.org>
40
41 * keyboard.c (adjust_point_for_property): Don't position point
42 before BEGV. (Bug#10696)
43
df0b2940
PE
442012-02-03 Paul Eggert <eggert@cs.ucla.edu>
45
46 Handle overflow when computing char display width (Bug#9496).
47 * character.c (char_width): Return EMACS_INT, not int.
48 (char_width, c_string_width): Check for overflow when
49 computing the width; this is possible now that individual
50 characters can have unbounded width. Problem introduced
51 by merge from Emacs 23 on 2012-01-19.
52
6bee44d6
MA
532012-02-02 Michael Albinus <michael.albinus@gmx.de>
54
55 * dbusbind.c (Fdbus_register_method): Mention the return value
56 :ignore in the docstring.
57
44f92739
GM
582012-02-02 Glenn Morris <rgm@gnu.org>
59
1b9f60cc
GM
60 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
61
44f92739
GM
62 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
63 Unconditionally set to t. (Bug#10673)
64 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
65 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
66 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
67
c5d3843c
KH
682012-02-02 Kenichi Handa <handa@m17n.org>
69
70 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
71 0, do not call append_composite_glyph.
72
159462d4 732012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
74
75 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
76 NULL (Bug#6988).
77 (x_produce_glyphs): If the component of a composition is a null
78 string, set it->pixel_width to 1 to avoid zero-width glyph.
79
78cef877
EZ
802012-02-01 Eli Zaretskii <eliz@gnu.org>
81
82 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
83 first 2 arguments are identical. This makes inserting large
84 output from a subprocess an order of magnitude faster on
85 MS-Windows, where all sbrk'ed memory is always contiguous.
86
97897668
GM
872012-01-31 Glenn Morris <rgm@gnu.org>
88
89 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 90 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
91 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
92
31fd3586
GM
932012-01-29 Glenn Morris <rgm@gnu.org>
94
95 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
96
0e24a8b2
CY
972012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
98
99 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
100
cc0adcb0
CY
1012012-01-28 Chong Yidong <cyd@gnu.org>
102
103 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
104
acc28cb9
CY
1052012-01-26 Chong Yidong <cyd@gnu.org>
106
9c69cfb7
CY
107 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
108
acc28cb9
CY
109 * search.c (Fsearch_forward, Fsearch_backward): Document negative
110 repeat counts (Bug#10507).
111
48da7392
GM
1122012-01-26 Glenn Morris <rgm@gnu.org>
113
114 * lread.c (syms_of_lread): Doc fix.
115
14af5f7f
CY
1162012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
117
118 * coding.c (encode_designation_at_bol): Change return value to
119 EMACS_INT.
120
0b21c100
CY
1212012-01-25 Chong Yidong <cyd@gnu.org>
122
123 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
124
3c2907f7
CY
1252012-01-21 Chong Yidong <cyd@gnu.org>
126
127 * floatfns.c (Fcopysign): Make the second argument non-optional,
128 since nil is not allowed anyway.
129
959ad23f
AS
1302012-01-21 Andreas Schwab <schwab@linux-m68k.org>
131
132 * process.c (read_process_output): Use p instead of XPROCESS (proc).
133 (send_process): Likewise.
134
34a02f46
MR
1352012-01-19 Martin Rudalics <rudalics@gmx.at>
136
137 * window.c (save_window_save, Fcurrent_window_configuration)
138 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
139 doc-strings.
140
1259009a 1412012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
142
143 * character.c (char_width): New function.
70d4fdf6
GM
144 (Fchar_width, c_string_width, lisp_string_width):
145 Use char_width (Bug#9496).
25ed9e61 146
6a6ee00d
MR
1472012-01-16 Martin Rudalics <rudalics@gmx.at>
148
149 * window.c (Vwindow_persistent_parameters): New variable.
150 (Fset_window_configuration, save_window_save): Handle persistent
151 window parameters.
152
c85efaf7
EZ
1532012-01-14 Eli Zaretskii <eliz@gnu.org>
154
155 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
156 thrashing the stack of the thread. (Bug#9087)
157
5944709e
PE
1582012-01-12 Paul Eggert <eggert@cs.ucla.edu>
159
160 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
161
e71f5d99
EZ
1622012-01-11 Eli Zaretskii <eliz@gnu.org>
163
164 * xdisp.c (rows_from_pos_range): Handle the case where the
165 highlight ends on a newline. (Bug#10464)
166 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
167 he end column for display of highlight that ends on a newline
168 before a R2L line.
169
ce316182
GM
1702012-01-11 Glenn Morris <rgm@gnu.org>
171
172 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
173 from load-path also when installation-directory is nil. (Bug#10208)
174
5b43da69
GM
1752012-01-10 Glenn Morris <rgm@gnu.org>
176
74cc8ff9
GM
177 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
178
7d8d6e4e
GM
179 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
180 Update template values to be closer to their typical values these days.
5b43da69 181
a0db8d43
EZ
1822012-01-09 Eli Zaretskii <eliz@gnu.org>
183
184 * xdisp.c (rows_from_pos_range): Accept additional argument
185 DISP_STRING, and accept any glyph in a row whose object is that
186 string as eligible for mouse highlight. Fixes mouse highlight of
187 display strings from overlays. (Bug#10464)
188
9a0115ab 1892012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 190
b9110d6a 191 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
192 * fileio.c (auto_saving_dir_umask): New static var.
193 (Fmake_directory_internal): Use it.
194 (do_auto_save_make_dir): Set it, instead of invoking chmod after
195 creating the directory. The old code temporarily assigns
196 too-generous permissions to the directory.
197 (do_auto_save_eh): Clear it.
b9110d6a 198 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
199 that the var is always cleared.
200
6c1bd3f3
EZ
2012012-01-07 Eli Zaretskii <eliz@gnu.org>
202
203 * search.c (scan_buffer): Pass character positions to
204 know_region_cache, not byte positions. (Bug#6540)
205
069d2b50
L
2062012-01-07 LynX <_LynX@bk.ru> (tiny change)
207
208 * w32.c (sys_rename): Report EXDEV when rename of a directory
209 fails because the target is on another logical disk. (Bug#10284)
210
75bf0d33
DB
2112012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
212
213 * xterm.c (x_embed_request_focus): New function.
214
215 * xterm.h: Add prototype.
216
217 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
218
1c6e5a32
GM
2192012-01-05 Glenn Morris <rgm@gnu.org>
220
221 * emacs.c (emacs_copyright): Update short copyright year to 2012.
222
651e947e
EZ
2232012-01-01 Eli Zaretskii <eliz@gnu.org>
224
225 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
226 Load gnutls_transport_set_lowat only if GnuTLS version is below
227 2.11.1.
228 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
229 GnuTLS versions below 2.11.1.
230
3778cdd8
AL
2312011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
232
233 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
234 to the doc string advising against its use for altering the way
235 windows are scrolled.
236
0e5317f7
KH
2372011-12-28 Kenichi Handa <handa@m17n.org>
238
239 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
240 coding-system ASCII compatible only when it does not produce BOM
241 on encoding (Bug#10383).
242
93d5ca1f
JD
2432011-12-26 Jan Djärv <jan.h.d@swipnet.se>
244
245 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
246 can scroll.
247 (create_and_show_popup_menu): Always use menu_position_func for
248 Gtk3 (Bug#10361).
249
ca22b785
AS
2502011-12-24 Andreas Schwab <schwab@linux-m68k.org>
251
252 * callint.c (Fcall_interactively): Don't truncate prompt string.
253
d048e1e6
EZ
2542011-12-23 Eli Zaretskii <eliz@gnu.org>
255
256 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
257 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 258 resumed from there (after widening). (Bug#10360)
d048e1e6 259
5ccaba1f
JD
2602011-12-22 Jan Djärv <jan.h.d@swipnet.se>
261
262 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
263
204ee57f
JD
2642011-12-21 Jan Djärv <jan.h.d@swipnet.se>
265
b81d40f0
JB
266 * nsterm.m (x_free_frame_resources):
267 Release f->output_data.ns->miniimage.
204ee57f
JD
268 (ns_index_color): Fix indentation. Do not retain
269 color_table->colors[i].
270
271 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
272 before returning.
273
274 * nsfns.m (x_set_background_color): Assign return value from
275 ns_index_color to face-background instead of NSColor*.
276 (ns_implicitly_set_icon_type): Fix indentation.
277 Change assignment in for loop to comparison.
278
279 * emacs.c (ns_pool): New variable.
280 (main): Assign ns_pool.
281 (Fkill_emacs): Call ns_release_autorelease_pool.
282
283 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
284 autorelease fdesc, release fdAttrs and tdict.
285 (ns_get_covering_families): Release charset.
286 (ns_findfonts): Release NSFontDescriptor created with new.
287 (ns_uni_to_glyphs): Fix indentation.
288 (setString): Release attrStr before assigning new value.
289
c803b2b7
JD
2902011-12-18 Jan Djärv <jan.h.d@swipnet.se>
291
678f4426
JD
292 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
293 and NS_IMPL_COCOA.
294 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
295 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
296
cd394be1 2972011-12-18 David Reitter <reitter@cmu.edu>
678f4426 298
5fecd5fc
JD
299 * nsterm.m (ns_term_init): Subscribe for notifications
300 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
301 to method trackingNotification in EmacsMenu.
302
303 * nsmenu.m (trackingMenu): New variable.
3771cb17 304 (trackingNotification): New method (from Aquamacs).
5fecd5fc 305 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 306 from Aquamacs (Bug#7030).
678f4426
JD
307
3082011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 309
c803b2b7
JD
310 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
311 (symbol_to_nsstring): Fix indentation.
312 (ns_symbol_to_pb): New function.
313 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
314 (Fns_rotate_cut_buffers_internal): Removed.
315 (Fns_store_selection_internal): Renamed from
316 Fns_store_cut_buffer_internal.
317 (ns_get_foreign_selection, Fx_own_selection_internal)
318 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
319 (Fns_get_selection_internal, Fns_store_selection_internal):
320 Use ns_symbol_to_pb and check if return value is nil.
321 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
322 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
323 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
324 renamed to Sns_store_selection_internal.
325 (ns_handle_selection_request): Move code to Fx_own_selection_internal
326 and remove this function.
327 (ns_handle_selection_clear): Remove, never used.
328 (Fx_own_selection_internal): Move code from ns_handle_selection_request
329 here.
330
e1b01a3a
KB
3312011-12-17 Ken Brown <kbrown@cornell.edu>
332
333 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
334 GID is unknown (Bug#10257).
335
2adb6e85
PE
3362011-12-17 Paul Eggert <eggert@cs.ucla.edu>
337
338 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
339 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
340 which caused a build failure on GNU/Linux IA-64. This problem was
341 introduced by my 2011-10-07 patch.
342
d1d7b339
JL
3432011-12-15 Juri Linkov <juri@jurta.org>
344
345 * image.c (imagemagick_error): New function. (Bug#10112)
346 (imagemagick_load_image): Comment out `MagickSetResolution' call.
347 Use `imagemagick_error' where ImageMagick functions return
348 `MagickFalse'.
349 (Fimagemagick_types): Add `Fnreverse' to return the list in the
350 proper order.
351
100d5755
KH
3522011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
353
354 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
355 fill background (Bug#8992).
356
454592a6
MR
3572011-12-13 Martin Rudalics <rudalics@gmx.at>
358
359 * window.c (Vwindow_combination_resize)
360 (Vwindow_combination_limit): Use t instead of non-nil in
361 doc-strings.
61d4b438
MR
362 (Vrecenter_redisplay): Add first sentence of doc-string on
363 separate line.
53524d93 364 (Frecenter): Fix doc-string typo.
454592a6 365
3633e3aa
KH
3662011-12-11 Kenichi Handa <handa@m17n.org>
367
368 * coding.c (Funencodable_char_position): Pay attention to the
369 buffer text relocation (Bug#9389).
370
7b9d523a
JD
3712011-12-10 Jan Djärv <jan.h.d@swipnet.se>
372
373 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
374 gtk_init (Bug#10100).
375
b73189c6
EZ
3762011-12-10 Eli Zaretskii <eliz@gnu.org>
377
378 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
379 IT->string is nil. (Bug#10263)
380
f7dfe5d6
JD
3812011-12-10 Jan Djärv <jan.h.d@swipnet.se>
382
83faebb4
JD
383 * nsterm.h (x_free_frame_resources): Declare.
384
f7dfe5d6
JD
385 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
386 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
387
388 * nsterm.h (ns_get_defaults_value): Declare.
389
390 * nsterm.m (ns_default): Call ns_get_defaults_value.
391
7cd4e72c
EZ
3922011-12-09 Eli Zaretskii <eliz@gnu.org>
393
394 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
395 (Bug#10170)
396
b34d7317
YM
3972011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
398
399 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
400 that where the value of an _OBJC_* symbol points to is in the .bss
401 section (Bug#10240).
402
76470ad1
KH
4032011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
404
405 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 406 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 407
745fff94
KH
4082011-12-08 Kenichi Handa <handa@m17n.org>
409
410 * ftfont.c (get_adstyle_property): Fix previous change
411 (Bug#10233).
412
6e44397c
JB
4132011-12-07 Juanma Barranquero <lekktu@gmail.com>
414
415 * w32.c (init_environment): If no_site_lisp, remove site-lisp
416 dirs from the default value of EMACSLOADPATH (bug#10208).
417
7efa6272
GM
4182011-12-07 Glenn Morris <rgm@gnu.org>
419
420 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
421 installation and source directories as well. (Bug#10208)
422
f6fc4d87
CY
4232011-12-06 Chong Yidong <cyd@gnu.org>
424
425 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
426
2bf26180
GM
4272011-12-06 Glenn Morris <rgm@gnu.org>
428
429 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
430 as an error, not just -1. (Bug#10217)
431
3a6ad4f0
CY
4322011-12-05 Chong Yidong <cyd@gnu.org>
433
434 * keyboard.c (process_special_events): New function.
435 (swallow_events, Finput_pending_p): Use it (Bug#10195).
436
75a3b399
PE
4372011-12-05 Paul Eggert <eggert@cs.ucla.edu>
438
439 * coding.c (encode_designation_at_bol): Don't use uninitialized
440 local variable (Bug#9318).
441
c3c9e25e
KH
4422011-12-05 Kenichi Handa <handa@m17n.org>
443
444 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
445 return Qnil (Bug#8046, Bug#10193).
446
5eb05ea3
KH
4472011-12-05 Kenichi Handa <handa@m17n.org>
448
449 * coding.c (encode_designation_at_bol): New args charbuf_end and
450 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
451 (coding_set_source): Return how many bytes coding->source was
452 relocated.
453 (coding_set_destination): Return how many bytes
454 coding->destination was relocated.
455 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
456 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
457
4582011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
459
460 * coding.c (CODING_CHAR_CHARSET_P): New macro.
461 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
462 macro (Bug#9318).
463
4642011-12-05 Andreas Schwab <schwab@linux-m68k.org>
465
466 The following changes are to fix Bug#9318.
467
a79703f5 468 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
469 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
470 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 471 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 472
7dbda6df
JB
4732011-12-05 Juanma Barranquero <lekktu@gmail.com>
474
475 * lisp.h (process_quit_flag): Fix external declaration.
476
6d5eb5b0
SM
4772011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
478
479 Don't macro-inline non-performance-critical code.
480 * eval.c (process_quit_flag): New function.
481 * lisp.h (QUIT): Use it.
482
a0c3fad0
JD
4832011-12-04 Jan Djärv <jan.h.d@swipnet.se>
484
485 * nsfns.m (get_geometry_from_preferences): New function.
486 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
487
6c07aac2
AS
4882011-12-04 Andreas Schwab <schwab@linux-m68k.org>
489
490 * emacs.c (Qkill_emacs): Define.
491 (syms_of_emacs): Initialize it.
492 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
493 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
494 (quit_throw_to_read_char): Add parameter `from_signal'.
495 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
496 * lisp.h (QUIT): Call Fkill_emacs if requested.
497
c052ead4
JD
4982011-12-03 Jan Djärv <jan.h.d@swipnet.se>
499
500 * widget.c (update_wm_hints): Return if wmshell is null.
501 (widget_update_wm_size_hints): New function.
502
503 * widget.h (widget_update_wm_size_hints): Declare.
504
505 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
506 widget_update_wm_size_hints (Bug#10104).
507
9e49252b
EZ
5082011-12-03 Eli Zaretskii <eliz@gnu.org>
509
510 * xdisp.c (handle_invisible_prop): If the invisible text ends just
511 before a newline, prepare the bidi iterator for consuming the
512 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 513 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 514
02b16839
JL
5152011-12-02 Juri Linkov <juri@jurta.org>
516
517 * search.c (Fword_search_regexp): New Lisp function created from
518 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
519 (Fword_search_backward, Fword_search_forward)
520 (Fword_search_backward_lax, Fword_search_forward_lax):
521 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
522 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
523
0068070e
SM
5242011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
525
526 * fileio.c (Finsert_file_contents): Move after-change-function call
527 to before the "handled:" label, since all "goto handled" appear in
528 cases where the *-change-functions have already been properly called
529 (bug#10117).
530
3360a3fc
AS
5312011-12-01 Andreas Schwab <schwab@linux-m68k.org>
532
533 * keyboard.c (interrupt_signal): Don't call kill-emacs when
534 waiting for input. (Bug#10169)
535
73d6c093
EZ
5362011-11-30 Eli Zaretskii <eliz@gnu.org>
537
538 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
539 verifies glyph row's hash code--we have just reallocated the
540 glyphs, so their contents can be complete garbage. (Bug#10164)
541
febe6bea
JB
5422011-11-30 Juanma Barranquero <lekktu@gmail.com>
543
544 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
545
801a4313
EZ
5462011-11-30 Eli Zaretskii <eliz@gnu.org>
547
548 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
549 attributes are tested _before_ calling verify_row_hash, to protect
550 against GCC re-ordering of the tests. (Bug#10164)
551
2b56b87e
JD
5522011-11-29 Jan Djärv <jan.h.d@swipnet.se>
553
554 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
555
556 * xterm.c (handle_one_xevent): Only set async_visible and friends
557 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 558 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
559 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
560
dbf31225
PE
5612011-11-28 Paul Eggert <eggert@cs.ucla.edu>
562
563 Remove GCPRO-related macros that exist only to avoid shadowing locals.
564 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
565 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
566 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
567 All uses changed to use GCPRO1 etc.
568 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
569 Revert to old implementation (i.e., before 2011-03-11).
570
1305621b
YM
5712011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
572
573 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
574 of scroll runs so as to avoid assigning disabled bogus rows and
575 unnecessary graphics copy operations.
576
8c9afb46
EZ
5772011-11-27 Eli Zaretskii <eliz@gnu.org>
578
579 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
580 (snprintf) [_MSC_VER]: Redirect to _snprintf.
581 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
582 (malloc, free, realloc, calloc): Redirect to e_* only when
583 compiling Emacs.
584
585 * lisp.h (GCTYPEBITS): Move before first use.
586 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
587 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
588 this macro definition.
589
590 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
591 _MSC_VER.
592
54e9e3bf
JD
5932011-11-27 Jan Djärv <jan.h.d@swipnet.se>
594
6d5eb5b0
SM
595 * gtkutil.c (xg_create_frame_widgets):
596 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
597 present with Gtk+ 2.0.
598
83aca1cb
PE
5992011-11-26 Paul Eggert <eggert@cs.ucla.edu>
600
601 * fileio.c (Finsert_file_contents): Undo previous change; see
602 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
603
5b76caa4
PE
6042011-11-26 Paul Eggert <eggert@cs.ucla.edu>
605
606 Rename locals to avoid shadowing.
607 * fileio.c (Finsert_file_contents):
608 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
609 * process.c (wait_reading_process_output):
610 Rename inner 'proc' to 'p' to avoid shadowing.
611 Indent for consistency with usual Emacs style.
612
8c535114
EZ
6132011-11-25 Eli Zaretskii <eliz@gnu.org>
614
615 * xdisp.c (redisplay_window): If cursor row is not fully visible
616 after recentering, and scroll-conservatively is set to a large
617 number, scroll window by a few more lines to make the cursor fully
618 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
619 (start_display): Don't move to the next line if the display should
620 start at a newline that is part of a display vector or an overlay
621 string. (Bug#10119)
8c535114 622
fa4fdb5c
JL
6232011-11-24 Juri Linkov <juri@jurta.org>
624
625 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
626 after the `MagickPingImage' call. (Bug#10112)
627
90ec88df
CY
6282011-11-23 Chong Yidong <cyd@gnu.org>
629
630 * window.c (Fcoordinates_in_window_p): Accept only live windows.
631
56e2e794
MR
6322011-11-23 Martin Rudalics <rudalics@gmx.at>
633
634 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
635 making another buffer current. (Bug#10114)
636
b6e64c41
GM
6372011-11-23 Glenn Morris <rgm@gnu.org>
638
639 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
640
6b21de18
CY
6412011-11-23 Chong Yidong <cyd@gnu.org>
642
643 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
644 using it (Bug#5984).
645
b12cd789
EZ
6462011-11-22 Eli Zaretskii <eliz@gnu.org>
647
648 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
649 and header-lines, as they don't have one computed for them.
650 (Bug#10098)
651
652 * .gdbinit (prow): Make displayed values more self-explaining.
653 Add row's hash code.
654
261b6fd4
LMI
6552011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
656
657 * process.c (wait_reading_process_output): Fix asynchrounous
658 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 659 (wait_reading_process_output): Add comment and URL.
261b6fd4 660
e7cfd277
JD
6612011-11-21 Jan Djärv <jan.h.d@swipnet.se>
662
663 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
664
a9b9b7f5
CY
6652011-11-21 Chong Yidong <cyd@gnu.org>
666
667 * window.c (Fnext_window, Fprevious_window): Doc fix.
668
b0d15b4f
SM
6692011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
670
671 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
672
fe7a3057
JB
6732011-11-20 Juanma Barranquero <lekktu@gmail.com>
674
675 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
676
d2999b1a
MR
6772011-11-20 Martin Rudalics <rudalics@gmx.at>
678
679 * window.c (Fset_window_combination_limit): Rename argument
680 STATUS to LIMIT.
681 (Vwindow_combination_limit): Remove "status" from doc-string.
682
d5ff9cd0
AS
6832011-11-20 Andreas Schwab <schwab@linux-m68k.org>
684
685 * m/ibms390.h: Remove.
686 * m/ibms390x.h: Don't include "ibms390.h".
687
a5bb9bd3
SM
6882011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
689
690 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
691 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
692
cd1181db
JB
6932011-11-20 Juanma Barranquero <lekktu@gmail.com>
694
695 * casetab.c (Fset_case_table):
696 * charset.c (Fcharset_after): Fix typos.
697
615a3b8d 6982011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 699
17e845af
PE
700 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
701 Otherwise, valgrind does not work on some platforms.
702 Problem reported by Andreas Schwab in
6a0bf43d
PE
703 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
704 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
705 is set, removing the need for VIRT_ADDRESS_VARIES.
706 (PURE_P): Use a more-efficient implementation that needs just one
707 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
708 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
709 to 4 (xorl, subq, cmpq, setbe).
710 * alloc.c (pure): Always extern now, since that's the
711 VIRT_ADDR_VARIES behavior.
712 (PURE_POINTER_P): Use a single comparison, not two, for
713 consistency with the new puresize.h.
714 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
715 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
716 Remove VIRT_ADDR_VARIES no longer needed.
717
f8fe6f96
EZ
7182011-11-19 Eli Zaretskii <eliz@gnu.org>
719
720 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
721 (erase_phys_cursor, update_window_cursor, show_mouse_face)
722 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
723 behave as if the cursor position were at the window margin.
724
725 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
726 and the cursor position is out of bounds, behave as if the cursor
727 position were at the window margin. (Bug#10075)
728
df05a53c
CY
7292011-11-18 Chong Yidong <cyd@gnu.org>
730
731 * window.c (Fwindow_combination_limit): Make first argument
732 non-optional, since it is meaningless for live windows like the
733 selected window.
734
2071918e
DA
7352011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
736
737 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
738
b50a28de
SM
7392011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
740
741 * intervals.c: Fix grafting over the whole buffer (bug#10071).
742 (graft_intervals_into_buffer): Simplify.
743
015137db
EZ
7442011-11-18 Eli Zaretskii <eliz@gnu.org>
745
746 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
747 hash values of the two rows.
748 (copy_row_except_pointers): Preserve the used[] arrays and the
749 hash values of the two rows. (Bug#10035)
68c95424 750 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
751
752 * xdisp.c (row_hash): New function, body extracted from
753 compute_line_metrics.
754 (compute_line_metrics): Call row_hash, instead of computing the
755 hash code inline.
756
757 * dispnew.c (verify_row_hash): Call row_hash for computing the
758 hash code of a row, instead of duplicating code from xdisp.c.
759
760 * dispextern.h (row_hash): Add prototype.
761
a2addb04
TH
7622011-11-18 Tassilo Horn <tassilo@member.fsf.org>
763
764 * frame.c (delete_frame): Don't delete the terminal when the last
765 X frame is closed if emacs is built with GTK toolkit.
766
df85d315
JB
7672011-11-17 Juanma Barranquero <lekktu@gmail.com>
768
769 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
770
a0c2d0ae
MR
7712011-11-17 Martin Rudalics <rudalics@gmx.at>
772
773 * window.c (Vwindow_splits): Rename to
774 Vwindow_combination_resize. Suggested by Juri Linkov.
775 (Fsplit_window_internal): Use Vwindow_combination_resize instead
776 of Vwindow_splits.
777
58179cce
JB
7782011-11-16 Juanma Barranquero <lekktu@gmail.com>
779
7877f373
JB
780 * nsfns.m (Fns_font_name):
781 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 782
b6f67890
MR
7832011-11-16 Martin Rudalics <rudalics@gmx.at>
784
785 * window.h (window): Rename slot "nest" to "combination_limit".
786 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
787 (Fset_window_nest): Rename to Fset_window_combination_limit.
788 (Vwindow_nest): Rename to Vwindow_combination_limit.
789 (recombine_windows, make_parent_window, make_window)
790 (Fsplit_window_internal, saved_window)
791 (Fset_window_configuration, save_window_save): Rename all
792 occurrences of window_nest to window_combination_limit.
793
c7015153
JB
7942011-11-15 Juanma Barranquero <lekktu@gmail.com>
795
796 * image.c (imagemagick_load_image): Fix typo.
797
322ad6ec
EZ
7982011-11-14 Eli Zaretskii <eliz@gnu.org>
799
800 * xdisp.c (display_line): Move the call to
801 highlight_trailing_whitespace before the call to
802 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
803 faces of all the glyphs to compute ROW's hash value.
804 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 805
f067b8ec
JB
8062011-11-14 Juanma Barranquero <lekktu@gmail.com>
807
808 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
809 just return (bug#10044).
810
1e5b2111
EZ
8112011-11-12 Eli Zaretskii <eliz@gnu.org>
812
7ef3cbd5
EZ
813 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
814 with user-defined heap size. Bump the default size of the temacs
815 heap to 27MB, to avoid memory warning when running temacs.
816 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
817
1e5b2111
EZ
818 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
819 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
820 (verify_row_hash) [XASSERTS]: New function.
821 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
822 that the hash value of glyph rows is correct.
1e5b2111 823
89d61221
MR
8242011-11-12 Martin Rudalics <rudalics@gmx.at>
825
826 * window.h (window): Remove splits slot.
827 * window.c (Fwindow_splits, Fset_window_splits): Remove.
828 (Fdelete_other_windows_internal, make_parent_window)
829 (make_window, Fsplit_window_internal, Fdelete_window_internal)
830 (Fset_window_configuration, save_window_save): Don't deal with
831 split status of windows.
832 (saved_window): Remove splits slot.
833 (Vwindow_splits): Rewrite doc-string.
834
97f18cc8
JD
8352011-11-11 Jan Djärv <jan.h.d@swipnet.se>
836
837 * xfns.c (unwind_create_frame):
838 * nsfns.m (unwind_create_frame):
839 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
840 Vframe_list (Bug#9999).
841
22a648b4
DA
8422011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
843
0b381c7e 844 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 845
659afede
KH
8462011-11-11 Kenichi Handa <handa@m17n.org>
847
848 * callproc.c (Fcall_process): Set the member dst_multibyte of
849 process_coding.
850
9ac0394b
KH
8512011-11-11 Johan Bockgård <bojohan@gnu.org>
852
853 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
854 avoid a crash (bug#9496).
855
2fbdc249
CY
8562011-11-09 Chong Yidong <cyd@gnu.org>
857
858 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
859 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
860
ac6b1f81
PE
8612011-11-08 Paul Eggert <eggert@cs.ucla.edu>
862
863 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
864
09db192c
PE
8652011-11-08 Paul Eggert <eggert@cs.ucla.edu>
866
867 Avoid some portability problems by eschewing 'extern inline' functions.
868 The trivial performance wins aren't worth the portability hassles; see
869 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
870 et seq.
871 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
872 (window_box_width, window_box_left, window_box_left_offset)
873 (window_box_right, window_box_right_offset): Undo previous change,
874 by removing the "extern"s.
875 * intervals.c (adjust_intervals_for_insertion)
876 (adjust_intervals_for_deletion): Undo previous change,
877 making these static again.
878 (offset_intervals, temp_set_point_both, temp_set_point)
879 (copy_intervals_to_string): No longer inline.
880 * xdisp.c (window_text_bottom_y, window_box_width)
881 (window_box_height, window_box_left_offset)
882 (window_box_right_offset, window_box_left, window_box_right)
883 (window_box): No longer inline.
884
105216ed
CY
8852011-11-08 Chong Yidong <cyd@gnu.org>
886
887 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
888 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
889 Signal an error if not a live window.
105216ed
CY
890 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
891 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
892
ae9e237f
JB
8932011-11-07 Juanma Barranquero <lekktu@gmail.com>
894
895 * lisp.h (syms_of_abbrev): Remove declaration.
896 Reported by CHENG Gao <chenggao@royau.me>.
897
c7aa8333
EZ
8982011-11-07 Eli Zaretskii <eliz@gnu.org>
899
900 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
901 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
902 of temacs in GUI mode.
903
be7f5545
MR
9042011-11-07 Martin Rudalics <rudalics@gmx.at>
905
906 * window.h: Declare delete_all_child_windows instead of
907 delete_all_subwindows.
908 * window.c (Fwindow_nest, Fset_window_nest)
909 (Fset_window_new_total, Fset_window_new_normal)
910 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
911 (delete_all_subwindows): Rename to delete_all_child_windows.
912 (Fdelete_other_windows_internal, Fset_window_configuration):
913 Call delete_all_child_windows instead of delete_all_subwindows.
914 * frame.c (delete_frame): Call delete_all_child_windows instead
915 of delete_all_subwindows.
916
ca78dc43
PE
9172011-11-07 Paul Eggert <eggert@cs.ucla.edu>
918
919 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
920 This is also needed for porting to any host where GC_MARK_STACK is
921 not GC_MAKE_GCPROS_NOOPS.
922 (which_symbols): Use it.
923
a0241d01
KH
9242011-11-07 Kenichi Handa <handa@m17n.org>
925
926 * coding.c (coding_set_destination): Check coding->src_pos only
927 when coding->src_object is a buffer (bug#9910).
928
929 * process.c (send_process): Set the member src_multibyte of coding
930 to 0 (bug#9911) when sending a unibyte text.
931
932 * callproc.c (Fcall_process): Set the member src_multibyte of
933 process_coding to 0 (bug#9912).
934
a64bfdfa 9352011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
936
937 * xmenu.c (cleanup_widget_value_tree): New function.
938 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
939 calling free_menubar_widget_value_tree directly (Bug#9830).
940
cb41b32a
PE
9412011-11-06 Paul Eggert <eggert@cs.ucla.edu>
942
943 Fix some portability problems with 'inline'.
944 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
945 (window_box_width, window_box_left, window_box_left_offset)
946 (window_box_right, window_box_right_offset): Declare extern.
947 Otherwise, these inline functions do not conform to C99 and
948 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
949 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
950 * intervals.c (adjust_intervals_for_insertion)
951 (adjust_intervals_for_deletion): Now extern, because otherwise the
952 extern inline functions 'offset_intervals' couldn't refer to it.
953 (static_offset_intervals): Remove.
954 (offset_intervals): Rewrite using the old contents of
955 static_offset_intervals. The old version didn't conform to C99
956 because an extern inline function contained a reference to an
957 identifier with static linkage.
958
b7041366
AS
9592011-11-06 Andreas Schwab <schwab@linux-m68k.org>
960
961 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
962 GC.
963
88a37c4d
EZ
9642011-11-06 Eli Zaretskii <eliz@gnu.org>
965
966 * xdisp.c (init_iterator, reseat_to_string): Don't set the
967 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
968 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
969 return Qleft_to_right.
970
49745b39
CY
9712011-11-06 Chong Yidong <cyd@gnu.org>
972
973 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
974 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
975 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
976 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
977 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
978 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
979 (Fwindow_vscroll): Doc fix.
980 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
981 argument, since it makes no sense to pass a live window and for
982 consistency with window-child.
983
1f05cd82
CS
9842011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
985
986 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
987 support MSVC.
988
22610910
JR
9892011-11-05 Jason Rumney <jasonr@gnu.org>
990
991 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
992 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
993 fonts (Bug#6029).
994 (add_font_entity_to_list): Fix logic errors in mixed boolean and
995 bitwise arithmetic preventing use of unicode-sip and non-truetype
996 opentype fonts.
997
a06776b2
EZ
9982011-11-05 Eli Zaretskii <eliz@gnu.org>
999
3ad924ba
EZ
1000 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1001 "emacs"-only part.
1002
a06776b2
EZ
1003 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1004 initialization code to keep similarity to xfns.c after changes
1005 from 2011-11-05.
1006
c9e7db78
JD
10072011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1008
a97f8f3f
JD
1009 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1010 (unwind_create_frame): New function (Bug#9943).
1011 (Fx_create_frame): Restructure code to be more similar to the one in
1012 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1013 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1014 Move terminal->reference_count++ just before making the frame official
1015 (Bug#9943).
1016
1017 * nsterm.m (x_free_frame_resources): New function.
1018 (x_destroy_window): Move code to x_free_frame_resources.
1019
c9e7db78 1020 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1021 (Fx_create_frame, x_create_tip_frame):
1022 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1023 official. Move initialization of image_cache_refcount and
1024 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1025
a6fc3b5c
EZ
10262011-11-05 Eli Zaretskii <eliz@gnu.org>
1027
1028 Support MSVC build with newer versions of Visual Studio.
1029 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1030 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1031 nt/gmake.defs.
1032
1033 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1034 which are not supported by MSVC.
1035 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1036 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1037 bitfields.
1038 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1039 types in bitfields.
1040 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1041
1042 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1043
58179cce 10442011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1045
1046 Support MSVC build with newer versions of Visual Studio.
1047 * w32.c: Don't include w32api.h for MSVC.
1048 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1049
1050 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1051 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1052 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1053 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1054 e_* cousins.
1055 (alloca) [_MSC_VER]: Define to _alloca.
1056
1057 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1058
1059 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1060
a58c13ed
EZ
10612011-11-04 Eli Zaretskii <eliz@gnu.org>
1062
1063 * xdisp.c (note_mouse_highlight): If either of
1064 previous/next-single-property-change returns nil, treat that as
1065 the beginning or the end of the buffer. (Bug#9955)
1066
fe0b6370
JD
10672011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1068
a58c13ed 1069 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1070 label is not null (Bug#9951).
1071 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1072 may be NULL.
1073
89bd5ee1
EZ
10742011-11-04 Eli Zaretskii <eliz@gnu.org>
1075
1076 * window.c (Fwindow_body_size): Mention in the doc string that the
1077 return value is in frame's canonical units. (Bug#9949)
1078
84c3edb9
EZ
10792011-11-03 Eli Zaretskii <eliz@gnu.org>
1080
4e2fb5c7
EZ
1081 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1082
84c3edb9 1083 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1084 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1085 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1086
bc17a887
EZ
10872011-11-01 Eli Zaretskii <eliz@gnu.org>
1088
1089 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1090 Don't stop backward scan on the continuation glyph, even though
1091 its CHARPOS is positive.
6d5eb5b0
SM
1092 (mouse_face_from_buffer_pos, note_mouse_highlight):
1093 Rename cover_string to disp_string.
bc17a887 1094
4ee88440
MR
10952011-11-01 Martin Rudalics <rudalics@gmx.at>
1096
1097 * window.c (temp_output_buffer_show): Don't use
1098 Vtemp_buffer_show_specifiers.
1099 (Vtemp_buffer_show_specifiers): Remove unused variable.
1100
c2ff3c02
EZ
11012011-10-30 Eli Zaretskii <eliz@gnu.org>
1102
1103 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1104 past the beginning of the current glyph matrix.
1105
58179cce 11062011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1107
1108 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1109 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1110 HAVE_GTK3 (Bug#9869).
b77a6a7f 1111
3b574623
JD
1112 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1113 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1114
b77a6a7f
JD
1115 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1116
1117 * xterm.c: Declare x_handle_net_wm_state to return int.
1118 (handle_one_xevent): Check if we are iconified but don't have
1119 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1120 (get_current_wm_state): Return non-zero if not hidden,
1121 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1122 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1123 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1124 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1125
196e41e4
PE
11262011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1127
1128 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1129 so that this new function doesn't get optimized away by a
1130 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1131
021f2e1a
AS
11322011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1133
1134 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1135
8b058d44
EZ
11362011-10-29 Eli Zaretskii <eliz@gnu.org>
1137
1138 Fix the `xbytecode' command.
1139 * .gdbinit (xprintbytestr): New command.
b50a28de 1140 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1141 (xbytecode): Print the byte-code string as well.
1142
4452fb80
EZ
11432011-10-29 Kim Storm <storm@cua.dk>
1144
8b058d44
EZ
1145 * alloc.c (which_symbols): New function.
1146
21b72067
AS
11472011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1148
1149 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1150 line. (Bug#9903)
1151
83ed7b5c
GM
11522011-10-29 Glenn Morris <rgm@gnu.org>
1153
1154 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1155 Not clear what it was for, and it causes various bugs. (Bug#9839)
1156
5a7a728b
EZ
11572011-10-28 Eli Zaretskii <eliz@gnu.org>
1158
1159 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1160 possible random value that matches one of those tested as
1161 condition to clear the mouse face.
1162
d3d0842f
CY
11632011-10-28 Chong Yidong <cyd@gnu.org>
1164
1165 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1166
31b39d13
DN
11672011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1168
1169 * window.c (make_window): Initialize phys_cursor_on_p.
1170
9aba6043
SM
11712011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1172
1173 * lisp.h (struct Lisp_Symbol): Update comments.
1174
c20992f4
JB
11752011-10-28 Juanma Barranquero <lekktu@gmail.com>
1176
1177 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1178
db4f02f2
EZ
11792011-10-28 Eli Zaretskii <eliz@gnu.org>
1180
1181 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1182 <oslsachem@gmail.com> for helping to debug this.
1183
1184 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1185 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1186 (g_b_init_get_glyph_outline_w): New static variables.
1187 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1188 (GetGlyphOutlineW_Proc): New typedefs.
1189 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1190 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1191 New functions.
1192 (w32font_open_internal, compute_metrics):
1193 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1194 instead of calling the "wide" APIs directly.
1195
1196 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1197
1198 * w32.h (syms_of_w32font): Add prototype.
1199
87e68db4
JB
12002011-10-27 Juanma Barranquero <lekktu@gmail.com>
1201
1202 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1203 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1204 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1205 (Fmove_to_window_line): Doc fix.
1206
435c1d67
CY
12072011-10-27 Chong Yidong <cyd@gnu.org>
1208
1209 * process.c (make_process): Set gnutls_state to NULL.
1210
1211 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1212 non-NULL, regardless of GNUTLS_INITSTAGE.
1213 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1214 an error. Set process slots as soon as we allocate them.
1215
1216 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1217
9c6c6f49
CY
12182011-10-27 Chong Yidong <cyd@gnu.org>
1219
9aba6043
SM
1220 * gnutls.c (emacs_gnutls_deinit): New function.
1221 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1222 (Fgnutls_deinit, Fgnutls_boot): Use it.
1223
1224 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1225 (deactivate_process): Call emacs_gnutls_deinit.
1226
657d08d3
JB
12272011-10-27 Juanma Barranquero <lekktu@gmail.com>
1228
1229 * image.c (x_create_x_image_and_pixmap):
1230 * w32.c (sys_rename, w32_delayed_load):
1231 * w32font.c (fill_in_logfont):
1232 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1233
5430d399
JB
12342011-10-26 Juanma Barranquero <lekktu@gmail.com>
1235
1236 * w32fns.c (w32_default_color_map): New function,
1237 extracted from Fw32_default_color_map.
a7ef684b 1238 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1239
fe0055fa
PE
12402011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1241
1242 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1243
e6346438
SM
12442011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1245
1246 * keyboard.c (test_undefined): New function (bug#9751).
1247 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1248
e112cc37
ET
12492011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1250
1251 * sysdep.c (init_sys_modes): Fix the check for the controlling
1252 terminal (Bug#6649).
1253
7b5d6677
EZ
12542011-10-20 Eli Zaretskii <eliz@gnu.org>
1255
1256 * dispextern.h (struct bidi_it): New member next_en_type.
1257
1258 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1259 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1260 current character, check also for next_en_type being WEAK_EN.
1261 (bidi_resolve_weak): Don't enter the expensive loop if the current
1262 position is before next_en_pos. Record the bidi type of the first
1263 non-ET, non-BN character we find, in addition to its position.
1264 (bidi_level_of_next_char): Invalidate next_en_type when
1265 next_en_pos is over-stepped.
1266
7da0b018
PE
12672011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1268
1269 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1270 * editfns.c: Rewrite current-time-zone so that it invokes
1271 the equivalent of (format-time-string "%Z") to get the time zone name.
1272 This fixes a bug when the time zone name contains characters that
1273 need converting from the system time locale to Emacs internal format.
1274 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1275 that patch fixed format-time-string to do the conversion, but
1276 I forgot to fix current-time-zone.
1277 (format_time_string): New function, containing most of
1278 what Fformat_time_string used to contain.
1279 (Fformat_time_string): Rewrite in terms of format_time_string.
1280 This doesn't change this function's behavior.
1281 (current-time-zone): Rewrite to use format_time_string.
1282 This fixes the bug reported by Michael Schierl in
1283 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1284 Jason Rumney's 2007-06-07 change worked around this bug, but
1285 didn't fix it.
1286 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1287
8547b010
EZ
12882011-10-19 Eli Zaretskii <eliz@gnu.org>
1289
1290 * xdisp.c (start_display): If the character at POS is displayed
1291 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1292 (try_window_reusing_current_matrix): If a line ends in a display
1293 vector or the next line starts in a display vector, continue
1294 redrawing the window even though the character position of
1295 start_row was reached.
8547b010
EZ
1296 (Bug#9771, part 2)
1297
4e948d15
CY
12982011-10-18 Chong Yidong <cyd@gnu.org>
1299
1300 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1301 with nobreak-char-display too.
1302
4787455f
EZ
13032011-10-18 Eli Zaretskii <eliz@gnu.org>
1304
1305 Fix part 3 of bug#9771.
1306 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1307 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1308 non-neutral characters if the current character is a paragraph
1309 separator (a.k.a. Newline). This avoids running the same
1310 expensive loop twice, once when we consume the preceding newline
1311 and the other time when the line actually needs to be displayed.
1312 Avoid the loop when we see neutrals on the base embedding level
1313 following a character whose directionality is the same as the
1314 paragraph's. This avoids running the expensive loop when a line
1315 ends in a long sequence of neutrals, like control characters.
1316 Add assertion against STRONG_AL type. Slightly rearrange code
1317 that determines the type of a neutral given the first non-neutral
1318 that follows it.
1319 (bidi_level_of_next_char): Set next_en_pos to zero when
1320 invalidating its info.
1321
2c91f553
EZ
13222011-10-17 Eli Zaretskii <eliz@gnu.org>
1323
1324 * xdisp.c (push_display_prop): Determine whether to record string
1325 or buffer position by IT->string, not by IT->method. Allow
1326 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1327 (move_it_vertically_backward): Don't look for character position
1328 immediately after the newline when in a continuation line.
1329 (Bug#9771, part 1)
2c91f553 1330
c7b08b0d
MR
13312011-10-15 Martin Rudalics <rudalics@gmx.at>
1332
1333 * window.c (coordinates_in_window): Rewrite and delabelize
1334 vertical border check. (Bug#5357) (Bug#9618)
1335
6b02f655
SM
13362011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1337
1338 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1339 errors in XSetWindowBorder (bug#9310).
1340
81d40c92
DA
13412011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1342
1343 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1344 avoid crash when xmalloc overrun checking is enabled.
1345
d4172c3b
EZ
13462011-10-13 Eli Zaretskii <eliz@gnu.org>
1347
1348 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1349 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1350 cursor motion with <left> and <right> arrow keys.
1351
1352 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1353 some callers set that themselves.
1354
b00eea75
EZ
13552011-10-12 Eli Zaretskii <eliz@gnu.org>
1356
1357 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1358 display string and the previous row comes from the same string and
1359 is empty. (Bug#9739) (Bug#9738)
1360
8fe012c4
SM
13612011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1362
1363 * doc.c (get_doc_string): Encode file name (bug#9735).
1364
0074aef2
EZ
13652011-10-12 Eli Zaretskii <eliz@gnu.org>
1366
79beb178
EZ
1367 * bidi.c (bidi_level_of_next_char):
1368 * xdisp.c (get_visually_first_element): Remove old incorrect
1369 comments regarding the Unicode Line Separator character.
1370
0074aef2
EZ
1371 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1372
6e4b3fbe
DA
13732011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1374
1375 * alloc.c (Fgc_status): Do not access beyond zombies array
1376 boundary if nzombies > MAX_ZOMBIES.
1377 * alloc.c (dump_zombies): Add missing format specifier.
1378
0324f3af
PE
13792011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1380
b5525cac
PE
1381 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1382 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1383
0324f3af
PE
1384 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1385 Some packages use them to denote characters with modifiers.
1386
e9b5f888
AS
13872011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1388
1389 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1390 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1391 matching a pp-number. Rename parameter var to var1.
1392
127827c0
SM
13932011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1394
1395 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1396
c8fd3bd0
GM
13972011-10-08 Glenn Morris <rgm@gnu.org>
1398
1399 * callint.c (Fcall_interactively): Give a more explicit error for the
1400 'c' case with a non-character input. (Bug#8479)
1401
352ec8ff
EZ
14022011-10-08 Eli Zaretskii <eliz@gnu.org>
1403
03669ccb
EZ
1404 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1405 lines.
7061c986
EZ
1406 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1407 lines that are hscrolled on the left.
03669ccb 1408
352ec8ff
EZ
1409 * dispnew.c (buffer_posn_from_coords): Account for a possible
1410 presence of header-line. (Bug#4426)
1411
a66cfb1c
SM
14122011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1413
6b02f655
SM
1414 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1415 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1416
7c5ee88e
PE
14172011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1418
1419 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1420 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1421 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1422 this makes Emacs dump core during garbage collection on rare
1423 occasions. sizeof is obviously inferior to offsetof here, so
1424 stick with offsetof.
1425 (GC_POINTER_ALIGNMENT): New macro.
1426 (mark_memory): Omit 3rd (offset) arg; caller changed.
1427 Don't assume EMACS_INT alignment is the same as pointer alignment.
1428
df1bbe5b
SM
14292011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1430
1431 * keyboard.c (read_key_sequence_remapped): New var.
1432 (read_key_sequence): Compute remapping in the right buffer.
1433 (command_loop_1): Use read_key_sequence's remapping directly.
1434
51553db6
SM
14352011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1436
32c1fffd
SM
1437 * dired.c (file_name_completion): Don't expand file name.
1438 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1439 before checking file name handler.
1440
51553db6
SM
1441 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1442 they've been requested explicitly (bug#9591).
1443
b6bd1599 14442011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1445
1446 * keymap.c (Fsingle_key_description): Use make_specified_string
1447 instead of build_string to build string from push_key_description.
1448 (Bug#5193)
1449
f701dc2a
PE
14502011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1451
4222c55d
PE
1452 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1453 This fixes a Y2038 bug on 64-bit hosts.
1454 * buffer.c (reset_buffer):
1455 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1456 (Fclear_buffer_auto_save_failure):
1457 Use 0, not -1, to represent an unset failure time, since time_t
1458 might not be signed.
1459
f701dc2a
PE
1460 Remove dependency on glibc malloc internals.
1461 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1462 Move back here from lisp.h, but with their new implementations.
1463 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1464 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1465 * charset.c (charset_table_init): New static var.
1466 (syms_of_charset): Use it instead of xmalloc. This removes a
1467 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1468 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1469 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1470 Move back to alloc.c.
1471 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1472 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1473
9ceebf39
JD
14742011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1475
1476 * nsterm.m (windowDidResize): Call x_set_window_size only when
1477 ns_in_resize is true. Otherwise set pixelwidth/height and
1478 call change_frame_size (Bug#9628).
1479
cb993c58
PE
14802011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1481
3930c88b
PE
1482 Port --enable-checking=all to Fedora 14 x86-64.
1483 * charset.c (syms_of_charset): Also account for glibc malloc's
1484 internal overhead when calculating the initial malloc maximum.
1485
cb993c58
PE
1486 Port --enable-checking=all to Fedora 14 x86.
1487 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1488 Move to lisp.h.
1489 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1490 (overrun_check_realloc, overrun_check_free):
1491 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1492 That way, xmalloc returns a properly-aligned pointer even if
1493 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1494 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1495 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1496 into account when calculating the initial malloc maximum.
1497 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1498 Move here from alloc.c, so that charset.c can use it too.
1499 Properly align; the old code wasn't right for common 32-bit hosts
1500 when configured with --enable-checking=all.
1501 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1502 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1503
31bed486
EZ
15042011-09-29 Eli Zaretskii <eliz@gnu.org>
1505
04c70788 1506 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1507 use EDOM.
1508
fbcaa2f3
EZ
15092011-09-28 Eli Zaretskii <eliz@gnu.org>
1510
1511 * xdisp.c (compute_display_string_end): If there's no display
1512 string at CHARPOS, return -1.
1513
1514 * bidi.c (bidi_fetch_char): When compute_display_string_end
1515 returns a negative value, treat the character as a normal
1516 character not covered by a display string. (Bug#9624)
1517
a239d4e9
JB
15182011-09-28 Juanma Barranquero <lekktu@gmail.com>
1519
1520 * lread.c (Fread_from_string): Fix typo in docstring.
1521
88652fd5
EZ
15222011-09-27 Eli Zaretskii <eliz@gnu.org>
1523
1524 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1525 newline, reseat the iterator instead of bidi-iterating there one
1526 character at a time. (Bug#9610)
32c1fffd
SM
1527 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1528 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1529
ed497dd4
AS
15302011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1531
1532 * lread.c (readevalloop): Use correct code for NBSP.
1533 (read1): Likewise. (Bug#9608)
1534
b2bf61aa
MA
15352011-09-25 Michael Albinus <michael.albinus@gmx.de>
1536
1537 * dbusbind.c (Fdbus_register_signal): When service is not
1538 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1539
32bbb17c
GM
15402011-09-25 Glenn Morris <rgm@gnu.org>
1541
1542 * buffer.c (truncate-lines): Doc fix.
1543
94e0933e
CY
15442011-09-24 Chong Yidong <cyd@stupidchicken.com>
1545
1546 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1547 (Fset_window_next_buffers): Doc fix.
1548
cddde921
GM
15492011-09-24 Glenn Morris <rgm@gnu.org>
1550
1551 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1552
1260aef1
PE
15532011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1554
25b4bfa0
PE
1555 Fix minor problems found by static checking.
1556 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1557 * indent.c (Fvertical_motion): Fix == vs = typo.
1558
e3cbd34b
EZ
15592011-09-24 Eli Zaretskii <eliz@gnu.org>
1560
a66cfb1c
SM
1561 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1562 Default value is now t. Doc fix.
6bf7006f 1563
e3cbd34b 1564 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1565 logic when moving up, not only when moving down. Fix the
e3cbd34b 1566 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1567 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1568
1569 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1570 CHARPOS is covered by a display string which includes newlines.
1571 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1572 is covered by a display string with embedded newlines.
1573
a3de0cbd
MA
15742011-09-24 Michael Albinus <michael.albinus@gmx.de>
1575
1576 * dbusbind.c (Fdbus_register_signal): Add match rule to
1577 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1578 (Fdbus_register_method, Vdbus_registered_objects_table):
1579 Fix docstring.
a3de0cbd 1580
b260039d
JM
15812011-09-24 Jim Meyering <meyering@redhat.com>
1582
32c1fffd 1583 do not ignore write error for any output size
b260039d
JM
1584 The previous change was incomplete.
1585 While it makes emacs --batch detect the vast majority of stdout
1586 write failures, errors were still ignored whenever the output size is
1587 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1588 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1589 && echo FAIL: ignored write error
1590 FAIL: ignored write error
1591 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1592 && echo FAIL: ignored write error
1593 FAIL: ignored write error
1594 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1595
8eca8a7c
AS
15962011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1597
1598 * emacs.c (Fkill_emacs): In noninteractive mode exit
1599 non-successfully if a write error occurred on stdout. (Bug#9574)
1600
3341db62
EZ
16012011-09-21 Eli Zaretskii <eliz@gnu.org>
1602
1603 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1604 the xassert test.
1605
1606 * dispextern.h (struct it): Update the comment documenting what
1607 can it->OBJECT be.
1608
8c203dbf
EZ
16092011-09-20 Eli Zaretskii <eliz@gnu.org>
1610
1611 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1612 a display string, extend search for cursor position to end of row.
1613 (find_row_edges): If the row ends in a newline from a display
1614 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1615 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1616 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1617 non-empty line. Fixes confusing cursor motion with arrow keys at
1618 the beginning of a line that starts with whitespace.
8c203dbf 1619
a4824228
LMI
16202011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1621
1622 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1623 (bug#9493).
1624
33ed493b
CY
16252011-09-18 Chong Yidong <cyd@stupidchicken.com>
1626
1627 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1628 boolean (Bug#9154).
1629
56cd55c8
EZ
16302011-09-18 Eli Zaretskii <eliz@gnu.org>
1631
1632 * xdisp.c (display_line): Record maximum and minimum buffer
1633 positions even if no glyphs were produced (e.g., by a zero-width
1634 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1635 buffer positions that will be removed from the glyph row because
1636 they don't fit.
c02dcedf
EZ
1637 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1638 column is beyond frame width: don't subtract 1 "pixel" when
1639 computing width of the stretch.
3e62b7e0
EZ
1640 (reseat_at_next_visible_line_start): Undo the change made on
1641 2011-09-17 that saved paragraph information and restored it after
1642 the call to `reseat'. (Bug#9545)
56cd55c8 1643
5ed99d36 16442011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1645
1646 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1647 and turn window cursor on if cleared (Bug#9415).
1648
5ed99d36 16492011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1650
1651 * search.c (boyer_moore): Take unibyte characters from pattern
1652 literally. (Bug#9458)
1653
9bade7b2
EZ
16542011-09-18 Eli Zaretskii <eliz@gnu.org>
1655
1656 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1657
e5e9d610
PE
16582011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1659
87e4427a
PE
1660 Fix minor problem found by static checking.
1661 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1662 initialized, to pacify gcc -Wuninitialized.
1663
e5e9d610
PE
1664 * fileio.c: Report proper errno when syscall falls.
1665 (Finsert_file_contents): Save and restore errno,
1666 so that report_file_error outputs the correct diagnostic.
1667 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1668
a1674f0b
EZ
16692011-09-18 Eli Zaretskii <eliz@gnu.org>
1670
1671 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1672
fbfb6dd4
EZ
16732011-09-17 Eli Zaretskii <eliz@gnu.org>
1674
1675 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1676 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1677
bb187662
EZ
16782011-09-17 Eli Zaretskii <eliz@gnu.org>
1679
1137e8b8 1680 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1681 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1682
1683 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1684 (bidi_find_paragraph_start): Search back for paragraph beginning
1685 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1686 (bidi_move_to_visually_next): Only trigger paragraph-related
1687 computations when the last character is a newline or at EOB, not
1688 just any NEUTRAL_B. (Bug#9470)
1689
bb187662
EZ
1690 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1691 truncated lines if point is covered by a display string. (Bug#9524)
1692
2e621251
PE
16932011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1694
1695 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1696 (cons_to_x_long): New function.
1697 (lisp_data_to_selection_data): Use it. Correct the test for
1698 short-versus-long data; it was negated. Break out of vector
1699 loop, for efficiency, when a long datum is discovered.
1700
91a15bc6
SM
17012011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1702
1703 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1704
b41c3a35
EZ
17052011-09-16 Eli Zaretskii <eliz@gnu.org>
1706
1707 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1708 GCC PR/17406) by declaring this function with external scope.
1709
7812ba2d
PE
17102011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1711
1712 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1713 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1714
cf7edc2a
AS
17152011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1716
1717 * editfns.c (Fformat): Correctly handle text properties on "%%".
1718
bd01620e
EZ
17192011-09-15 Eli Zaretskii <eliz@gnu.org>
1720
1721 * xterm.c (x_draw_composite_glyph_string_foreground):
1722 * w32term.c (x_draw_composite_glyph_string_foreground):
1723 * term.c (encode_terminal_code):
1724 * composite.c (composition_update_it, get_composition_id):
1725 * xdisp.c (get_next_display_element)
1726 (fill_composite_glyph_string): Add comments about special meaning
1727 of TAB characters in a composition.
1728
a02719a3
PE
17292011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1730
1731 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1732 This occurs when processing a multibyte format.
1733 Problem reported by Wolfgang Jenker.
a02719a3 1734
72589a3c
JB
17352011-09-15 Johan Bockgård <bojohan@gnu.org>
1736
1737 * xdisp.c (try_cursor_movement): Only check for exact match if
1738 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1739
1c14176c
PE
17402011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1741
1742 Remove unused external symbols.
1743 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1744 * xdisp.c (calc_pixel_width_or_height): Now static.
1745 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1746 * indent.c (check_display_width):
1747 * w32term.c: Fix comment to match code.
1748 * xterm.c, xterm.h (x_catching_errors): Remove.
1749
d2eea5b5
PE
17502011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1751
1752 * xselect.c: Use signed conversions more consistently (Bug#9498).
1753 (selection_data_to_lisp_data): Assume incoming selection data are
1754 signed integers, not unsigned. This is to be consistent with
1755 outgoing selection data, which was modified to use signed integers
1756 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1757 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1758 expects long, not unsigned long.
1759
46888499
EZ
17602011-09-14 Eli Zaretskii <eliz@gnu.org>
1761
1762 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1763 computation of loop end. Reported by Johan Bockgård
1764 <bojohan@gnu.org>.
1765
ef8ef9fb
CY
17662011-09-13 Chong Yidong <cyd@stupidchicken.com>
1767
1768 * frame.c (Fother_visible_frames_p): Function deleted.
1769
fa819fed
EZ
17702011-09-12 Eli Zaretskii <eliz@gnu.org>
1771
1772 * indent.c (compute_motion): Process display vector front to back
1773 rather than the other way around. (Bug#2496)
1774
2ba8e008
SM
17752011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1776
1777 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1778
20f53c69
CY
17792011-09-11 Chong Yidong <cyd@stupidchicken.com>
1780
1781 * minibuf.c (Fread_from_minibuffer): Doc fix.
1782
d562d7a4
EZ
17832011-09-11 Eli Zaretskii <eliz@gnu.org>
1784
1785 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1786 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1787
1c4d7f3d
LMI
17882011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1789
1790 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1791 value for non-existent files.
1792
b885bf36
EZ
17932011-09-11 Eli Zaretskii <eliz@gnu.org>
1794
1795 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1796 set its "size" to -1. This will set the modtime_size field of
1797 the corresponding buffer to -1, which is what
1798 verify-visited-file-modtime expects for files that do not exist.
1799 (Bug#9139)
1800
6612f0bf
PE
18012011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1802
1803 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1804 here ...
1805 * lisp.h: ... from here. push_key_description is no longer
1806 defined in keyboard.c, so its declaration should not be in
1807 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1808 logically belongs with push_key_description.
1809
dfb3f755
PE
18102011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1811
1812 * buffer.h: Include <sys/types.h> instead of <time.h>.
1813 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1814 Problem reported by Herbert J. Skuhra.
1815
3134906c
LMI
18162011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1817
1818 * xml.c (parse_region): Make the parsing work for
1819 non-comment-starting XML files again (bug#9144).
1820
8d903f4e
AS
18212011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1822
1823 * image.c (gif_load): Fix calculation of bottom and right corner.
1824 (Bug#9468)
1825
80ad64f4
EZ
18262011-09-10 Eli Zaretskii <eliz@gnu.org>
1827
1828 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1829 redisplay in small windows.
1830
208a048d
EZ
18312011-09-09 Eli Zaretskii <eliz@gnu.org>
1832
1833 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1834
9b1c252e
MR
18352011-09-08 Martin Rudalics <rudalics@gmx.at>
1836
1837 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1838 Operate on live windows only.
1839
2949f33b
JB
18402011-09-08 Juanma Barranquero <lekktu@gmail.com>
1841
1842 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1843
e08dcafd
EZ
18442011-09-07 Eli Zaretskii <eliz@gnu.org>
1845
1846 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1847 only under bidi iteration.
1848
115b96bd
JD
18492011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1850
1851 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1852
c8199d0f
PE
18532011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1854
1855 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1856 Without this fix, the command to link temacs failed due to an
1857 undefined symbol __builtin_isnan. This is because
1858 /usr/include/iso/math_c99.h #defines isnan(x) to
1859 __builtin_isnan(x), but the bundled gcc, which identifies itself
1860 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1861 a __builtin_isnan.
1862 * floatfns.c (isnan): #undef, and then #define to a clone of
1863 what's in data.c.
1864 (Fisnan): Always define, since it's always available now.
1865 (syms_of_floatfns): Always define isnan at the Lisp level.
1866
e39b275c 18672011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1868
1869 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1870
b2db44d9 18712011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1872
f4af5137 1873 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1874 The previous code assumed that file offsets (off_t values) fit in
1875 EMACS_INT variables, which is not true on typical 32-bit hosts.
1876 The code messed up by falsely reporting buffer overflow in cases
1877 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1878 when "big" contains more than 2**29 bytes, even though this
1879 inserts just one byte and does not overflow the buffer.
1880 (Finsert_file_contents): Store file offsets as off_t
1881 values, not as EMACS_INT values. Check for overflow when
1882 converting between EMACS_INT and off_t. When checking for
1883 buffer overflow or for overlap, take the offsets into account.
1884 Don't use EMACS_INT for small values where int suffices.
1885 When checking for overlap, fix a typo: ZV was used where
1886 ZV_BYTE was intended.
1887 (Fwrite_region): Don't assume off_t fits into 'long'.
1888 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1889
ecfc0a49
MA
18902011-09-05 Michael Albinus <michael.albinus@gmx.de>
1891
1892 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1893
6511acf2 18942011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1895
0999621a 1896 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1897
1898 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1899 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1900 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1901 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1902 (modify_event_symbol): Do not assume that the length of
1903 name_alist_or_stem is safe to alloca and fits in int.
1904 (Fexecute_extended_command): Likewise for function name and binding.
1905 (Frecursion_depth): Wrap around reliably on integer overflow.
1906 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1907 since some callers pass EMACS_INT values.
1908 (Fsingle_key_description): Don't crash if symbol name contains more
1909 than MAX_ALLOCA bytes.
1910 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1911 (get_minibuffer): Arg is now EMACS_INT, not int.
1912 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1913 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1914 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1915
2be7d702
PE
1916 * dbusbind.c (signature_cat): New function.
1917 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1918 Do not overrun buffer; instead, report string overflow.
1919
9d1df220
PE
1920 * dispnew.c (add_window_display_history): Don't overrun buffer.
1921 Truncate instead; this is OK since it's just a log.
1922
33ef5c64
PE
1923 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1924 even if the time zone offset is outlandishly large.
1925 Don't mishandle offset == INT_MIN.
1926
66c6fdd5
PE
1927 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1928 when creating daemon; the previous buffer-overflow check was incorrect.
1929
d749b01b
PE
1930 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1931 which has the guts of the old verror function.
1932
b5cd1905
PE
1933 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1934 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1935
6e1a67fb
PE
1936 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1937 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1938 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1939 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1940 length of string rather than counting it via multiple sprintfs;
1941 that's simpler and more reliable.
c21721cc
PE
1942 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1943 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1944 sprintf, in case result does not fit in int.
1945
c57b67fc
PE
1946 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1947 (fontset_from_font): Print it.
1948
8a401434
PE
1949 * frame.c (tty_frame_count): Now printmax_t, not int.
1950 (make_terminal_frame, set_term_frame_name): Print it.
1951 (x_report_frame_params): In X, window IDs are unsigned long,
1952 not signed long, so print them as unsigned.
1953 (validate_x_resource_name): Check for implausibly long names,
1954 and don't assume name length fits in 'int'.
1955 (x_get_resource_string): Don't blindly alloca invocation name;
1956 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1957 not fit in int.
1958
6e1a67fb
PE
1959 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1960 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1961 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1962
0df02bf3
PE
1963 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1964 Use esprintf, not sprintf, in case result does not fit in int.
1965
48e30793
PE
1966 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1967 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1968 it as a large positive number.
1969 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1970 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1971
a66ff6d8
PE
1972 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1973 in case result does not fit in int.
1974
aca216ff
PE
1975 * print.c (float_to_string): Detect width overflow more reliably.
1976 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1977 buffer overrun. Don't assume list length fits in 'int'. Treat
1978 print length of 0 as 0, not as infinity; to be consistent with other
1979 uses of print length in this function. Don't overflow print length
1980 index. Don't assume hash table size fits in 'long', or that
1981 vectorlike size fits in 'unsigned long'.
1982
31c286f7
PE
1983 * process.c (make_process): Use printmax_t, not int, to format
1984 process-name gensyms.
1985
55e5faa1
PE
1986 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1987
80f2e268
PE
1988 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1989 to avoid potential buffer overrun.
1990
670741ab
PE
1991 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1992 if X resource line is longer than 512 bytes.
1993
b7163a50
PE
1994 * xfns.c (x_window): Make sprintf buffer a bit bigger
1995 to avoid potential buffer overrun.
1996
ae58ff1f
PE
1997 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1998
c43c8a6a
PE
1999 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2000
3f8236f4
PE
20012011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2002
53e9fe90 2003 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2004 Without these, Emacs silently mishandles large integers sometimes.
2005 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2006 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2007
6511acf2
PE
2008 * xdisp.c (try_window_id): Check Emacs fixnum range before
2009 converting to 'int'.
806add1d 2010
6511acf2 2011 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2012 Check that an Emacs fixnum is in range before assigning it to 'int'.
2013 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2014 values converted from Emacs fixnums.
2015 (Frecenter): Don't wrap around a line count if it is out of 'int'
2016 range; instead, treat it as an extreme value.
2017 (Fset_window_configuration, compare_window_configurations):
2018 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2019
6511acf2
PE
2020 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2021 that can exceed INT_MAX. Check that EMACS_INT value is in range
2022 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2023 (match_limit): Don't assume that a fixnum can fit in 'int'.
2024
6511acf2 2025 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2026 exceed INT_MAX.
2027
6511acf2 2028 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2029 (Fvertical_motion): Don't wrap around LINES values that don't fit
2030 in 'int'. Instead, treat them as extreme values. This is good
2031 enough for windows, which can't have more than INT_MAX lines anyway.
2032
fcb901a7
LMI
20332011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2034
0f2f6b6d
LMI
2035 * Require libxml/parser.h to avoid compilation warning.
2036
fcb901a7
LMI
2037 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2038
2039 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2040 since this reportedly can destroy thread storage.
2041
6e20a0d4
CY
20422011-08-30 Chong Yidong <cyd@stupidchicken.com>
2043
2044 * syntax.c (find_defun_start): Update all cache variables if
2045 exiting early (Bug#9401).
2046
148ae00e
EZ
20472011-08-30 Eli Zaretskii <eliz@gnu.org>
2048
f6cfbd8f
EZ
2049 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2050
148ae00e
EZ
2051 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2052 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2053 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2054
2055 * term.c (tty_append_glyph): New function.
2056 (produce_stretch_glyph): Static function and its prototype deleted.
2057
a66cfb1c
SM
2058 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2059 Add prototypes.
148ae00e 2060
c4a07a4c
PE
20612011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2062
2063 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2064 when checking :margin (Bug#9390).
2065 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2066 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2067 so that the name doesn't mislead. All uses changed.
2068
6bc8cd65
JB
20692011-08-28 Johan Bockgård <bojohan@gnu.org>
2070
2071 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2072 set_tty_hooks.
2073
dca4927e
EZ
20742011-08-27 Eli Zaretskii <eliz@gnu.org>
2075
2076 * xdisp.c (move_it_to): Don't bail out early when reaching
2077 position beyond to_charpos, if we are scanning backwards.
2078 (move_it_vertically_backward): When DY == 0, make sure we get to
2079 the first character in the line after the newline.
2080
f2cad773
PE
20812011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2082
2083 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2084 (ccl_driver): Do not generate an out-of-range pointer.
2085 (Fccl_execute_on_string): Remove unnecessary check for
2086 integer overflow, noted by Stefan Monnier in
2087 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2088 Remove a FIXME that didn't need fixing.
2089 Simplify the newly-introduced buffer reallocation code.
2090
0cae2cdb
JB
20912011-08-27 Juanma Barranquero <lekktu@gmail.com>
2092
2093 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2094
5fc295a4 20952011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2096
70c60eb2 2097 Integer and memory overflow issues (Bug#9196).
726e0ab1 2098
d31850da
PE
2099 * doc.c (get_doc_string): Rework so that
2100 get_doc_string_buffer_size is the actual buffer size, rather than
2101 being 1 less than the actual buffer size; this makes xpalloc more
2102 convenient.
2103
a69fbedb
PE
2104 * image.c (x_allocate_bitmap_record, cache_image):
2105 * xselect.c (Fx_register_dnd_atom):
2106 Simplify previous changes by using xpalloc.
2107
fe5c5d37
PE
2108 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2109 since either will do and ptrdiff_t is convenient with xpalloc.
2110
0065d054
PE
2111 * charset.c (charset_table_size)
2112 (struct charset_sort_data.priority): Now ptrdiff_t.
2113 (charset_compare): Don't overflow if priorities differ greatly.
2114 (Fsort_charsets): Don't assume list length fits in int.
2115 Check for size-calculation overflow when allocating sort data.
2116 (syms_of_charset): Allocate an initial charset table that is
2117 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2118
2119 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2120
2121 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2122 The actual value is always <= INT_MAX, and leaving it unsigned made
2123 overflow checking harder.
2124
2125 * dispextern.h (struct glyph_matrix.rows_allocated)
2126 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2127 with xpalloc. The values are still always <= INT_MAX.
2128
2129 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2130
2131 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2132 (SAFE_NALLOCA): New macro.
2133
2134 * region-cache.c (struct boundary.pos, find_cache_boundary)
2135 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2136 (set_cache_region, invalidate_region_cache)
2137 (revalidate_region_cache, know_region_cache, region_cache_forward)
2138 (region_cache_backward, pp_cache):
2139 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2140 so that ptrdiff_t * can be passed to xpalloc.
2141 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2142 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2143 (pp_cache): Don't assume cache_len fits in int.
2144 * region-cache.h: Adjust extern decls to match.
2145
2146 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2147 EMACS_INT, since either will do, for xpalloc.
2148
2149 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2150 (xnmalloc, xnrealloc, xpalloc): New functions.
2151
726e0ab1
PE
2152 * bidi.c (bidi_shelve_header_size): New constant.
2153 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2154 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2155
51f30bc5 2156 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2157 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2158 (overlay_strings):
2159 Don't update size of array until after memory allocation succeeds,
2160 because xmalloc/xrealloc may not return.
0065d054
PE
2161 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2162 now that we have proper integer overflow checking.
2163 (record_overlay_string, overlay_strings): Catch overflows when
2164 calculating size of overlay_str_buf.
726e0ab1 2165
0065d054
PE
2166 * callproc.c (Fcall_process): Check for size overflow when
2167 calculating size of args2.
2168 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2169 Normally we prefer signed values, but sticking with ptrdiff_t would
2170 require adding more-complicated checks.
726e0ab1
PE
2171
2172 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2173 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2174 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2175 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2176
2177 * character.c (Fstring): Check for size-calculation overflow.
2178
2179 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2180 unnecessary integer overflow. Check for size overflow.
2181 (encode_coding_object): Don't update size until xmalloc succeeds.
2182
2183 * composite.c (get_composition_id): Check for overflow in glyph
2184 length calculations.
2185
2186 Integer and memory overflow fixes for display code.
2187 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2188 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2189 (scrolling_window): Check for overflow in size calculations.
2190 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2191 Don't assume glyph table len fits in int.
2192 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2193 (row_table_size): Now ptrdiff_t, not int.
2194 (scrolling_window): Avoid overflow in size calculations.
2195 Don't update size until allocation succeeds.
2196 * fns.c (concat): Check for overflow in size calculations.
2197 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2198 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2199 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2200
2201 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2202 (get_doc_string): Check for size calculation overflow.
2203 Don't update size until allocation succeeds.
2204 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2205 EMACS_INT, where ptrdiff_t will do.
2206 (Fsubstitute_command_keys): Check for string overflow.
2207
2208 * editfns.c (set_time_zone_rule): Don't assume environment length
2209 fits in int.
2210 (message_length): Now ptrdiff_t, not int.
2211 (Fmessage_box): Don't update size until allocation succeeds.
2212 Don't assume message length fits in int.
2213 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2214
0065d054
PE
2215 * emacs.c (main): Do not reallocate argv, since there is a null at
2216 the end that can be overwritten, and this way there's no need to
2217 worry about size-calculation overflow.
2218 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2219
2220 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2221 alloc succeeds.
2222 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2223
2224 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2225 (x_set_scroll_bar_width, x_figure_window_size):
2226 Check for integer overflow.
2227 (x_set_alpha): Do not assume XINT fits in int.
2228
2229 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2230 This is for the members text_lines, text_cols, total_lines, total_cols,
2231 where the system imposes an 'int' limit.
2232
2233 * fringe.c (Fdefine_fringe_bitmap):
2234 Don't update size until alloc works.
2235
2236 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2237 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2238
2239 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2240 Check for size-calculation overflow.
2241 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2242 do, as we prefer signed integers.
2243 (id_to_widget.max_size, id_to_widget.used)
2244 (xg_store_widget_in_map, xg_remove_widget_from_map)
2245 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2246 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2247 Use and return ptrdiff_t, not int.
2248 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2249 * gtkutil.h: Change prototypes to match the above.
2250
2251 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2252 are duplicate now that they've been promoted to lisp.h.
2253 (x_allocate_bitmap_record, x_alloc_image_color)
2254 (make_image_cache, cache_image, xpm_load):
2255 Don't update size until alloc is done.
2256 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2257 (x_detect_edges):
3256efce 2258 Check for size calculation overflow.
726e0ab1
PE
2259 (ct_colors_allocated_max): New constant.
2260 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2261 overflow.
3256efce 2262
726e0ab1
PE
2263 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2264 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2265 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2266 Use ptrdiff_t, not int, to count maps.
2267 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2268 calculations. Don't update size until allocation succeeds.
2269 Redo calculations to avoid overflow.
726e0ab1
PE
2270 * keyboard.h: Change prototypes to match the above.
2271
2272 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2273 to count maps.
2274 (current_minor_maps): Check for size calculation overflow.
2275 * keymap.h: Change prototypes to match the above.
2276
2277 * lread.c (read1, init_obarray): Don't update size until alloc done.
2278
2279 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2280 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2281
726e0ab1
PE
2282 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2283 Now ptrdiff_t, not int.
2284 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2285 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2286
2287 * process.c (Fnetwork_interface_list): Check for overflow
2288 in size calculation.
2289
2290 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2291
2292 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2293 overflow. Don't bother calling xmalloc when xrealloc will do.
2294
2295 * search.c (Freplace_match): Check for size calculation overflow.
2296 (Fset_match_data): Don't assume list lengths fit in 'int'.
2297
2298 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2299 for command line length. Do not attempt to address one before the
2300 beginning of an array, as that's not portable.
2301
2302 * term.c (max_frame_lines): Remove; unused.
2303 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2304 not int.
2305 (encode_terminal_code, calculate_costs): Check for size
2306 calculation overflow.
2307 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2308 table lengths and related sizes. Don't update size until alloc
2309 done. Redo calculations to avoid overflow.
2310 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2311
2312 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2313 subtracting pointers.
2314 (gobble_line): Check for overflow more carefully. Don't update size
2315 until alloc done.
2316
2317 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2318 Don't update size until alloc done.
2319 Redo size calculations to avoid overflow.
2320 Check for size calculation overflow.
0065d054 2321 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2322
2323 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2324 Use ptrdiff_t, not int, for sizes.
2325 (store_mode_line_noprop_char): Don't update size until alloc done.
2326
0065d054
PE
2327 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2328 Use ptrdiff_t, not int, for sizes.
2329 (Finternal_make_lisp_face, cache_face):
2330 Check for size calculation overflow.
2331 (cache_face): Treat size calculation overflows as if they were
2332 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2333
2334 * xfns.c (x_encode_text, x_set_name_internal)
2335 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2336 sizes, since they can exceed INT_MAX in size. Check for size
2337 calculation overflow.
2338
0065d054
PE
2339 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2340 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2341 Don't update size until alloc done.
2342
0065d054 2343 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2344 as sprintf is limited to int lengths.
1d526e2f 2345
252c5ee1
PE
2346 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2347 (X_LONG_MIN): New macros.
864d7ce7
PE
2348 Use them to make the following changes clearer.
2349 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2350 This change doesn't affect the value now, but it may help remind
2351 future maintainers not to raise the value too much later.
2352 (SELECTION_QUANTUM): Remove, replacing with ...
2353 (selection_quantum): ... new function, which avoids overflow.
2354 All uses changed.
2355 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2356 assumption that selection length fits in 'int'.
2357 (x_reply_selection_request, x_handle_selection_request)
2358 (x_get_window_property, receive_incremental_selection)
2359 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2360 (lisp_data_to_selection_data, clean_local_selection_data):
2361 Use ptrdiff_t, not int, to record length of selection.
2362 (x_reply_selection_request, x_get_window_property)
2363 (receive_incremental_selection, x_property_data_to_lisp):
2364 Redo calculations to avoid overflow.
2365 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2366 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2367 something.
2368 (x_get_window_property, receive_incremental_selection)
2369 (lisp_data_to_selection_data, x_property_data_to_lisp):
2370 Check for size-calculation overflow.
2371 (x_get_window_property, receive_incremental_selection)
2372 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2373 Don't store size until memory allocation succeeds.
2374 (x_get_window_property): Plug memory leak on memory exhaustion.
2375 Don't double-block input; malloc is safe here. Don't assume 2**34
2376 - 4 fits in unsigned long. Add an xassert to check
2377 XGetWindowProperty overflow. Be more careful about overflow
2378 calculations, and distinguish size from memory overflow better.
2379 (receive_incremental_selection): When tracing, don't assume
2380 unsigned int is less than INT_MAX.
2381 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2382 harmful) conversions of unsigned short to int.
2383 (lisp_data_to_selection_data): Don't assume that integers
2384 in the range -65535 through -1 fit in an X unsigned short.
2385 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2386 result parameters unless successful. Rely on cons_to_unsigned
2387 to report problems with elements; the old code wasn't right anyway.
2388 (x_check_property_data): Check for int overflow; we cannot use
2389 a wider type due to X limits.
2390 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2391
726e0ab1 2392 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2393
0065d054
PE
2394 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2395 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2396 (x_color_cells): Don't store size until memory allocation succeeds.
2397 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2398 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2399 (x_term_init): Don't assume length fits in int (sprintf is limited
2400 to int size).
bc18e09d 2401
ebfa62c0
PE
2402 Use ptrdiff_t for composition IDs.
2403 * character.c (lisp_string_width):
2404 * composite.c (composition_table_size, n_compositions)
2405 (get_composition_id, composition_gstring_from_id):
2406 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2407 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2408 * window.c (Frecenter):
2409 Use ptrdiff_t, not int, for composition IDs.
2410 * composite.c (get_composition_id): Check for integer overflow.
2411 * composite.h: Adjust prototypes to match the above changes.
2412
d3411f89
PE
2413 Use ptrdiff_t for hash table indexes.
2414 * category.c (hash_get_category_set):
2415 * ccl.c (ccl_driver):
2416 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2417 * coding.c (coding_system_charset_list, detect_coding_system):
2418 * coding.h (struct coding_system.id):
2419 * composite.c (get_composition_id, gstring_lookup_cache):
2420 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2421 * image.c (xpm_get_color_table_h):
2422 * lisp.h (hash_lookup, hash_put):
2423 * minibuf.c (Ftest_completion):
2424 Use ptrdiff_t for hash table indexes, not int (which is too
2425 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2426 32-bit --with-wide-int hosts).
2427
e097a6fa
PE
2428 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2429 Add a FIXME comment about memory leaks.
2430 (syms_of_charset): Don't assume xmalloc returns.
2431
5637687f
PE
2432 Don't assume that stated character widths fit in int.
2433 * character.c (Fchar_width, c_string_width, lisp_string_width):
2434 * character.h (CHAR_WIDTH):
2435 * indent.c (MULTIBYTE_BYTES_WIDTH):
2436 Use sanitize_char_width to avoid undefined and/or bad behavior
2437 with outlandish widths.
a66cfb1c 2438 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2439 now that we have two such functions. All uses changed.
2440 (sanitize_char_width): New inline function.
2441
a2271ba2
PE
2442 Don't assume that tab-width fits in int.
2443 * character.h (sanitize_width): New inline function.
2444 (SANE_TAB_WIDTH): New macro.
2445 (ASCII_CHAR_WIDTH): Use it.
2446 * indent.c (sane_tab_width): Remove. All uses replaced by
2447 SANE_TAB_WIDTH (current_buffer).
2448 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2449
18c52557
PE
2450 * fileio.c: Integer overflow issues with file modes.
2451 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2452
caeeedc1
PE
2453 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2454 Remove unreachable code.
2455 (read_hex, load_charset_map_from_file): Check for integer overflow.
2456
6df6ae42 2457 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2458 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2459 (x_send_scroll_bar_event): Likewise. Check that the size does not
2460 exceed limits imposed by XClientMessageEvent, as well as the usual
2461 ptrdiff_t and size_t limits.
2462
b13995db
PE
2463 * keyboard.c: Overflow, signedness and related fixes.
2464 (make_lispy_movement): Use same integer type in forward decl
2465 that is used in the definition.
2466 (read_key_sequence, keyremap_step):
2467 Change bufsize argument back to int, undoing my 2011-03-30 change.
2468 We prefer signed types, and int is wide enough here.
2469 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2470 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2471 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2472 length, not size_t. Use ptrdiff_t for index, not int.
2473 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2474 possibility of integer overflow.
2475
13464394
PE
2476 Overflow, signedness and related fixes for images.
2477
2478 * dispextern.h (struct it.stack[0].u.image.image_id)
2479 (struct_it.image_id, struct image.id, struct image_cache.size)
2480 (struct image_cache.used, struct image_cache.ref_count):
2481 * gtkutil.c (update_frame_tool_bar):
2482 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2483 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2484 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2485 * nsmenu.m (update_frame_tool_bar):
2486 * xdisp.c (calc_pixel_width_or_height):
2487 * xfns.c (image_cache_refcount):
2488 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2489 on typical 64-bit hosts.
2490
2491 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2492 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2493 Omit unnecessary casts to int.
2494 (parse_image_spec): Check that integers fall into 'int' range
2495 when the callers expect that.
2496 (image_ascent): Redo ascent calculation to avoid int overflow.
2497 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2498 (lookup_image): Remove unnecessary tests.
2499 (xbm_image_p): Locals are now of int, not EMACS_INT,
2500 since parse_image_check makes sure they fit into int.
2501 (png_load, gif_load, svg_load_image):
2502 Prefer int to unsigned where either will do.
2503 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2504 old tiff_error_handler and tiff_warning_handler.
2505 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2506 stack buffer overflows. It uses only the features of vsnprintf
2507 that are common to both POSIX and native Microsoft.
2508 (tiff_error_handler, tiff_warning_handler): Use it.
2509 (tiff_load, gif_load, imagemagick_load_image):
2510 Don't assume :index value fits in 'int'.
2511 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2512 (imagemagick_load_image): Check that crop parameters fit into
2513 the integer types that MagickCropImage accepts. Don't assume
2514 Vimagemagick_render_type has a nonnegative value. Don't assume
2515 size_t fits in 'long'.
2516 (gs_load): Use printmax_t to print the widest integers possible.
2517 Check for integer overflow when computing image height and width.
2518
c11821d4
EZ
25192011-08-26 Eli Zaretskii <eliz@gnu.org>
2520
2521 * xdisp.c (redisplay_window): Don't force window start if point
2522 will be invisible in the resulting window. (Bug#9324)
2523
0c95fcf7
EZ
25242011-08-25 Eli Zaretskii <eliz@gnu.org>
2525
2526 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2527 the display spec is of the form `(space ...)'.
2528 (handle_display_spec): Return the value returned by
2529 handle_single_display_spec, not just 1 or zero.
2530 (handle_single_display_spec): If the display spec is of the form
2531 `(space ...)', and specifies display in the text area, return 2
2532 rather than 1.
fee65a97 2533 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2534 accurately, and prefer exact match for point under bidi.
2535 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2536
2537 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2538 into disp_prop; all users changed.
2539
2540 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2541 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2542 for the text covered by the display property.
2543
e4ed06f1
CY
25442011-08-25 Chong Yidong <cyd@stupidchicken.com>
2545
2546 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2547 Change return value to nil.
2548 (Frecord_buffer): Delete unused function.
2549
f67cdd7f
EZ
25502011-08-24 Eli Zaretskii <eliz@gnu.org>
2551
5980d4c6
EZ
2552 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2553 buffers, return left-to-right.
8610fe8b
EZ
2554 (set_cursor_from_row): Consider candidate row a win if its glyph
2555 represents a newline and point is on that newline. Fixes cursor
2556 positioning on the newline at EOL of R2L text within L2R
2557 paragraph, and vice versa.
2558 (try_cursor_movement): Check continued rows, in addition to
2559 continuation rows. Fixes unwarranted scroll when point enters a
2560 continued line of R2L text within an L2R paragraph, or vice versa.
2561 (cursor_row_p): Consider the case of point being equal to
2562 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2563 from the end of a short line to the beginning of a continued line
2564 of R2L text within L2R paragraph.
2565 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2566 composed characters.
5980d4c6 2567
f67cdd7f
EZ
2568 * bidi.c (bidi_check_type): Use xassert.
2569 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2570 members.
2571
bca633fb
EZ
25722011-08-23 Eli Zaretskii <eliz@gnu.org>
2573
2574 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2575 a character.
2576
4a5885a7
CY
25772011-08-23 Chong Yidong <cyd@stupidchicken.com>
2578
2579 * nsfont.m (ns_otf_to_script): Fix typo.
2580
0902a04e
KH
25812011-08-22 Kenichi Handa <handa@m17n.org>
2582
2583 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2584 extra slot even if the purpose is char-code-property-table.
2585
1a2e6670
EZ
25862011-08-23 Eli Zaretskii <eliz@gnu.org>
2587
8ddde651
EZ
2588 * xdisp.c (redisplay_window): When computing centering_position,
2589 account for the height of the header line. (Bug#8874)
2590
425cc014
EZ
2591 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2592 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2593 candidate is selected by the mouse, and that candidate has a
2594 composed character under the mouse.
2595
1a2e6670
EZ
2596 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2597 coordinates reported by pos-visible-in-window-p for a composed
2598 character in column zero.
2599
8b76d6f8
SM
26002011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2601
2602 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2603
dac347dd
EZ
26042011-08-22 Eli Zaretskii <eliz@gnu.org>
2605
2606 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2607 consider it a hit if to_charpos is anywhere in the range of the
2608 composed buffer positions.
2609
e013fb34
CY
26102011-08-22 Chong Yidong <cyd@stupidchicken.com>
2611
2612 * image.c (gif_load): Don't assume that each subimage has the same
2613 dimensions as the base image. Handle disposal method that is
2614 "undefined" by the gif spec (Bug#9335).
2615
bd1ba3e8
CY
26162011-08-20 Chong Yidong <cyd@stupidchicken.com>
2617
2618 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2619 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2620
54a1215b
EZ
26212011-08-19 Eli Zaretskii <eliz@gnu.org>
2622
823564e5
EZ
2623 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2624 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2625 from an Org mode buffer to a Speedbar frame.
2626
54a1215b
EZ
2627 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2628 a composition, take its buffer position from IT->cmp_it.charpos.
2629 Fixes cursor positioning at the beginning of a line that begins
2630 with a composed character.
2631
9778ebcc
EZ
26322011-08-18 Eli Zaretskii <eliz@gnu.org>
2633
0be6ee06
EZ
2634 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2635 character bidirectional type, use STRONG_L instead. Fixes crashes
2636 in a buffer produced by `describe-categories'.
2637
9778ebcc
EZ
2638 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2639 members before the level stack, so they would be saved and
2640 restored when copying iterator state. Fixes incorrect reordering
2641 around TABs covered by display properties.
2642
156bffbe
AS
26432011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2644
6b02f655 2645 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2646
72ad093b
CY
26472011-08-17 Chong Yidong <cyd@stupidchicken.com>
2648
2649 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2650 (internal_condition_case_2, internal_condition_case_n):
2651 Remove unnecessary aborts (Bug#9081).
72ad093b 2652
35774242
EZ
26532011-08-17 Eli Zaretskii <eliz@gnu.org>
2654
2655 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2656 has no `load' handler, try opening the file locally. (Bug#9311)
2657
db76dd85
KB
26582011-08-16 Ken Brown <kbrown@cornell.edu>
2659
2660 * gmalloc.c: Expand comment.
2661
b215eee5
EZ
26622011-08-16 Eli Zaretskii <eliz@gnu.org>
2663
2664 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2665 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2666
a4579d33
KB
26672011-08-16 Ken Brown <kbrown@cornell.edu>
2668
2669 Fix memory allocation problems in Cygwin build (Bug#9273).
2670
2671 * unexcw.c ( __malloc_initialized): Declare external variable.
2672 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2673
8b76d6f8
SM
2674 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2675 New variables.
a4579d33
KB
2676 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2677 dumped emacs.
2678 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2679 in the static heap.
2680 [CYGWIN] (special_realloc): New function.
2681 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2682 requests to realloc storage in the static heap.
2683
3ebec551
PE
26842011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2685
2686 * bidi.c (bidi_initialize): Remove unused local.
2687
9fd8be00
EZ
26882011-08-15 Eli Zaretskii <eliz@gnu.org>
2689
6b02f655
SM
2690 * bidimirror.h:
2691 * biditype.h: Remove file.
2692 * makefile.w32-in ($(BLD)/bidi.$(O)):
2693 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2694
2695 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2696
2697 * chartab.c: Improve commentary for the uniprop_table API.
2698
32413314
EZ
2699 * bidi.c (bidi_paragraph_init): Support zero value of
2700 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2701 (bidi_initialize): Use uniprop_table instead of including
2702 biditype.h and bidimirror.h.
32413314 2703
9fd8be00
EZ
2704 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2705 coordinates of the iterator when restoring from ppos_it.
2706 (Bug#9296)
2707
5cf2b69b
KH
27082011-08-14 Kenichi Handa <handa@m17n.org>
2709
2710 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2711 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2712
daf17d00
EZ
27132011-08-14 Eli Zaretskii <eliz@gnu.org>
2714
2715 * xdisp.c (move_it_in_display_line_to): Don't invoke
2716 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2717 ppos_it. Fixes vertical cursor motion when line beginning is
2718 covered by an image. (Bug#9296)
2719
08e3161a
JD
27202011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2721
2722 * nsterm.h (ns_run_ascript): Declare.
2723 (NSAPP_DATA2_RUNASSCRIPT): Define.
2724
2725 * nsfns.m (as_script, as_result, as_status): New static variables.
2726 (ns_run_ascript): New function.
5e617bc2 2727 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2728 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2729 the event loop. Get status from as_status (Bug#7276).
2730
2731 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2732 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2733 the event loop (Bug#7276).
2734
a3720aa2
AS
27352011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2736
2737 * gnutls.c (QCgnutls_bootprop_priority)
2738 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2739 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2740 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2741 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2742 (QCgnutls_bootprop_verify_hostname_error)
2743 (QCgnutls_bootprop_callbacks_verify): Rename from
2744 Qgnutls_bootprop_..., all uses changed.
2745
2746 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2747 uses changed.
2748
0a0d27fb
PE
27492011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2750
19d5c50c
PE
2751 * xfaces.c (Qframe_set_background_mode): Now static.
2752 * dispextern.h (Qframe_set_background_mode): Remove decl.
2753
0a0d27fb
PE
2754 * process.c (Fnetwork_interface_info): Declare local only if needed.
2755
377538cb
JD
27562011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2757
2758 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2759 (Fnetwork_interface_list): Allocate in increments of bytes instead
2760 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2761 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2762 sockaddr.
2763 (struct ifflag_def): notrailers is smart on OSX.
2764 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2765 Get hardware address with getifaddrs if available.
2766
08fff70c
EZ
27672011-08-12 Eli Zaretskii <eliz@gnu.org>
2768
2769 * xdisp.c (iterate_out_of_display_property): xassert that
2770 IT->position is set to within IT->object's boundaries. Break from
2771 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2772 when IT->position is set up wrongly due to some bug.
2773 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2774 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2775 entry. Force push_it to save on the stack the current
2776 buffer/string position, to be restored by pop_it. Fix flags in
2777 the iterator structure wrt the object coming from a display
2778 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2779 properties. (Bug#9284)
2780
7be1c708 27812011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2782
7be1c708
CY
2783 * fontset.c (fontset_get_font_group): Add proper type checks.
2784 (Bug#9172)
aac0c6e3 2785
7be1c708 27862011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2787
7be1c708
CY
2788 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2789 and LC_VERSION_MIN_MACOSX.
2790 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2791 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2792
97bb72a6
EZ
27932011-08-08 Eli Zaretskii <eliz@gnu.org>
2794
2795 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2796 no-display-properties-and-no-overlays under bidi display.
2797 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2798 properties and overlays.
97bb72a6 2799
d5617611
CY
28002011-08-08 Chong Yidong <cyd@stupidchicken.com>
2801
37e11a63
CY
2802 * editfns.c (Fset_time_zone_rule): Document relationship with the
2803 setenv function.
2804
d5617611
CY
2805 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2806 the font entity extracted from the cache (Bug#8109).
2807
58872834
CY
28082011-08-07 Chong Yidong <cyd@stupidchicken.com>
2809
2810 * composite.c (autocmp_chars): Don't reset point. That is done by
2811 restore_point_unwind (Bug#5984).
2812
75bfc667
JL
28132011-08-07 Juri Linkov <juri@jurta.org>
2814
2815 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2816 to show the arg `TIME' instead of `TIMEVAL'.
2817
d1410150
EZ
28182011-08-06 Eli Zaretskii <eliz@gnu.org>
2819
2820 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2821 display property strides EOL and includes a newline, as in
2822 longlines-mode. (Bug#9254)
75b771e4
EZ
2823 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2824 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2825
2826 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2827 is non-zero, even if the data buffer is NULL. Fixes a crash in
2828 vertical-motion with longlines-mode. (Bug#9254)
2829
35928349
EZ
28302011-08-05 Eli Zaretskii <eliz@gnu.org>
2831
ec7cc85b
EZ
2832 * bidi.c <bidi_cache_total_alloc>: Now static.
2833 (bidi_initialize): Initialize bidi_cache_total_alloc.
2834
8b76d6f8 2835 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2836 cache. (Bug#9221)
2837
2838 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2839 amount allocated this far in `bidi_cache_total_alloc'.
2840 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2841 non-zero, only free the data buffer without restoring the cache
2842 contents. All callers changed.
2843
2844 * dispextern.h (bidi_unshelve_cache): Update prototype.
2845
2846 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2847 (move_it_in_display_line, move_it_to)
2848 (move_it_vertically_backward, move_it_by_lines): Replace the call
2849 to xfree to an equivalent call to bidi_unshelve_cache.
2850 (move_it_in_display_line_to): Fix logic of returning
412b6358 2851 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2852
e2e2423b
EZ
28532011-08-05 Eli Zaretskii <eliz@gnu.org>
2854
2855 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2856 came from a string character with a `cursor' property. (Bug#9229)
2857
ae9e757a
JD
28582011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2859
2860 * Makefile.in (LIB_PTHREAD): New variable.
2861 (LIBES): Add LIB_PTHREAD (Bug#9216).
2862
2863 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2864 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2865
213bd7f2
AS
28662011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2867
6b02f655 2868 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2869
99aaf75f
JD
28702011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2871
2872 * xterm.c (x_find_topmost_parent): New function.
2873 (x_set_frame_alpha): Find topmost parent window with
2874 x_find_topmost_parent and set the property there also (bug#9181).
2875 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2876
c74e9d86
PE
28772011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2878
2879 * callproc.c (Fcall_process): Avoid vfork clobbering
2880 the local vars buffer, coding_systems, current_dir.
2881
640c8776
SM
28822011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2883
2884 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2885
f26d0e4c
PE
28862011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2887
8a10d76c
PE
2888 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2889 so that it is not optimized away.
2890
f26d0e4c
PE
2891 * xdisp.c (compute_display_string_pos): Remove unused local.
2892
55439c61
EZ
28932011-08-02 Eli Zaretskii <eliz@gnu.org>
2894
2895 Fix slow cursor motion and scrolling in large buffers with
2896 selective display, like Org Mode buffers. (Bug#9218)
2897
2898 * dispextern.h (struct bidi_it): New member disp_prop_p.
2899
2900 * xdisp.c: Remove one-slot cache of display string positions.
2901 (compute_display_string_pos): Accept an additional argument
5e617bc2 2902 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2903 for a display string or property. If found, set DISP_PROP_P
2904 non-zero.
2905
2906 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2907 DISP_PROP_P, and pass it to compute_display_string_pos.
2908 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2909 non-zero. All callers of bidi_fetch_char changed.
2910
fb33fa43
SM
29112011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2912
2913 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2914
b099e063
DM
29152010-12-03 Don March <don@ohspite.net>
2916
2917 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2918 last character M-[char] is translated to ESC [char] (bug#7541).
2919
5cc7f7af
KH
29202011-08-02 Kenichi Handa <handa@m17n.org>
2921
d0fffa3f 2922 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2923
2924 * chartab.c (uniprop_table): Make it non-static.
2925
525d5e6e
EZ
29262011-08-01 Eli Zaretskii <eliz@gnu.org>
2927
2928 * xdisp.c (forward_to_next_line_start): Accept additional argument
2929 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2930 on the newline.
2931 (reseat_at_next_visible_line_start): Use the bidi iterator state
2932 returned by forward_to_next_line_start to restore the state of
2933 it->bidi_it after backing up to previous newline. (Bug#9212)
2934
31011111
AS
29352011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2936
2937 * regex.c (re_comp): Protoize.
2938 (re_exec): Fix return type.
2939 (regexec): Fix type of `ret'. (Bug#9203)
2940
476371c4
PE
29412011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2942
e5d76069
PE
2943 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2944 This is needed if max-image-size is a floating-point number.
2945
9a79b20c
AS
29462011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2947
2948 * print.c (print_object): Print empty symbol as ##.
2949
2950 * lread.c (read1): Read ## as empty symbol.
2951
d8c2fa78
AA
29522011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2953
2954 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2955 setting frame foreground color (Bug#9175).
2956 (x_set_background_color): Likewise.
2957
ffe57a7a
AA
2958 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2959 contents (Bug#9176).
2960 (EmacsTooltip -init): Remove bezels and add shadows to
2961 tooltip windows.
2962
bf3492a5
AA
2963 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2964 or scroll bar (Bug#8470).
2965
d55e9c53
AA
2966 * nsfont.m (nsfont_open): Remove assignment to voffset and
2967 unnecessary vars hshink, expand, hd, full_height, min_height.
2968 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2969
2970 * nsterm.h (nsfont_info): Remove voffset field.
2971
d8c2fa78 29722011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2973
2974 Implement strike-through and overline on NextStep (Bug#8863).
2975
2976 * nsfont.m (nsfont_open): Use underline position provided by font,
2977 instead of hard-coded value of 2.
2978 (nsfont_draw): Call ns_draw_text_decoration instead.
2979
2980 * nsterm.h: Add declaration for ns_draw_text_decoration.
2981
2982 * nsterm.m (ns_draw_text_decoration): New function for drawing
2983 underline, overline, and strike-through.
2984 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2985 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2986 accommodate underlining, etc.
4843aac3 2987
4cc60b9b
EZ
29882011-07-28 Eli Zaretskii <eliz@gnu.org>
2989
bc7ece87
EZ
2990 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2991 default.
4cc60b9b 2992
476371c4
PE
29932011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2994
66606eea
PE
2995 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2996 Without this fix, if a signal arrives just after memory fills up,
2997 'malloc' might be invoked reentrantly.
2998
476371c4
PE
2999 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3000 In other words, assume that every image size is allowed, on non-X
3001 hosts. This assumption is probably wrong, but it lets Emacs compile.
3002
f3fcc40d
AS
30032011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3004
3005 * regex.c (re_iswctype): Convert return values to boolean.
3006
350c992f
EZ
30072011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3008
3009 * xdisp.c (compute_display_string_pos): Don't use cached display
3010 string position if the buffer had its restriction changed.
3011 (Bug#9184)
3012
5266b4bb
PE
30132011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3014
3015 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3016
2573a837 30172011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3018
41f55ccd 3019 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3020
39e378da
PE
3021 * bidi.c: Integer size and overflow fixes.
3022 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3023 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3024 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3025 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3026 (bidi_find_other_level_edge):
3027 Use ptrdiff_t instead of EMACS_INT where either will do.
3028 This works better on 32-bit hosts configured --with-wide-int.
3029 (bidi_cache_ensure_space): Check for size-calculation overflow.
3030 Use % rather than repeated addition, for better worst-case speed.
3031 Don't set bidi_cache_size until after xrealloc returns, because it
3032 might not return.
3033 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3034 (bidi_cache_ensure_space): Also check that the bidi cache size
3035 does not exceed that of the largest Lisp string or buffer. See Eli
3036 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3037
5e927815
PE
3038 * alloc.c (__malloc_size_t): Remove.
3039 All uses replaced by size_t. See Andreas Schwab's note
3040 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3041
ca4aa935
PE
3042 * image.c: Improve checking for integer overflow.
3043 (check_image_size): Assume that f is nonnull, since
3044 it is always nonnull in practice. This is one less thing to
3045 worry about when checking for integer overflow later.
3046 (x_check_image_size): New function, which checks for integer
3047 overflow issues inside X.
3048 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3049 This removes the need for a memory_full check.
3050 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3051 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3052 (xbm_read_bitmap_data): Change locals back to 'int', since
3053 their values must fit in 'int'.
3054 (xpm_load_image, png_load, tiff_load):
3055 Invoke x_create_x_image_and_pixmap earlier,
3056 to avoid much needless work if the image is too large.
3057 (tiff_load): Treat overly large images as if
3058 x_create_x_image_and_pixmap failed, not as malloc failures.
3059 (gs_load): Use x_check_image_size.
3060
5f8f9cc2
PE
3061 * gtkutil.c: Omit integer casts.
3062 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3063 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3064
5adf60bc
PE
3065 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3066
c8907a93
PE
3067 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3068 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3069 would wrongly return t on a 64-bit host.
3070
e3c25c68
PE
3071 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3072 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3073 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3074 and therefore cause GCC to emit a bogus diagnostic in some cases.
3075
3f791afe
PE
3076 * image.c: Integer signedness and overflow and related fixes.
3077 This is not an exhaustive set of fixes, but it's time to
3078 record what I've got.
3079 (lookup_pixel_color, check_image_size): Remove redundant decls.
3080 (check_image_size): Don't assume that arbitrary EMACS_INT values
3081 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3082 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3083 (tiff_load, imagemagick_load_image):
3084 Check for overflow in size calculations.
3085 (x_create_x_image_and_pixmap): Remove unnecessary test for
3086 xmalloc returning NULL; that can't happen.
3087 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3088 (xpm_color_bucket): Use better integer hashing function.
3089 (xpm_cache_color): Don't possibly over-allocate memory.
3090 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3091 (gif_memory_source):
3092 Use ptrdiff_t, not int or size_t, to record sizes.
3093 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3094 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3095 either works, as we prefer signed integers.
3096 (tiff_read_from_memory, tiff_write_from_memory):
3097 Return tsize_t, not size_t, since that's what the TIFF API wants.
3098 (tiff_read_from_memory): Don't fail simply because the read would
3099 go past EOF; instead, return a short read.
3100 (tiff_load): Omit no-longer-needed casts.
3101 (Fimagemagick_types): Don't assume size fits into 'int'.
3102
3cc5a532
PE
3103 Improve hashing quality when configured --with-wide-int.
3104 * fns.c (hash_string): New function, taken from sxhash_string.
3105 Do not discard information about ASCII character case; this
3106 discarding is no longer needed.
3107 (sxhash-string): Use it. Change sig to match it. Caller changed.
3108 * lisp.h: Declare it.
3109 * lread.c (hash_string): Remove, since we now use fns.c's version.
3110 The fns.c version returns a wider integer if --with-wide-int is
3111 specified, so this should help the quality of the hashing a bit.
3112
b312a492
PE
3113 * emacs.c: Integer overflow minor fix.
3114 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3115 Define only if GNU_LINUX.
3116 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3117
dfd153ae
PE
3118 * dispnew.c: Integer signedness and overflow fixes.
3119 Remove unnecessary forward decls, that were a maintenance hassle.
3120 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3121 All uses changed.
3122 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3123 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3124 (prepare_desired_row, line_draw_cost):
3125 Use int, not unsigned, where either works.
3126 (save_current_matrix, restore_current_matrix):
3127 Use ptrdiff_t, not size_t, where either works.
3128 (init_display): Check for overflow more accurately, and without
3129 relying on undefined behavior.
3130
a81d11a3
PE
3131 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3132 Remove, replacing with the new symbols in lisp.h. All uses changed.
3133 * fileio.c (make_temp_name):
3134 * filelock.c (lock_file_1, lock_file):
3135 * xdisp.c (message_dolog):
3136 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3137 Use pMd etc. instead.
3138 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3139 replacing the pWIDE etc. symbols removed from editfns.c.
3140
3300e6fd
PE
3141 * keyboard.h (num_input_events): Now uintmax_t.
3142 This is (very slightly) less likely to mess up due to wraparound.
3143 All uses changed.
3144
fd05c7e9
PE
3145 * buffer.c: Integer signedness fixes.
3146 (alloc_buffer_text, enlarge_buffer_text):
3147 Use ptrdiff_t rather than size_t when either will do, as we prefer
3148 signed integers.
3149
903fe15d
PE
3150 * alloc.c: Integer signedness and overflow fixes.
3151 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3152 (__malloc_size_t): Default to size_t, not to int.
3153 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3154 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3155 Prefer ptrdiff_t to size_t when either would do, as we prefer
3156 signed integers.
3157 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3158 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3159 Now const. Initialize with values that are in range even if char
3160 is signed.
3161 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3162 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3163 These functions do the right thing with sizes > 2**32.
3164 (check_depth): Now ptrdiff_t, not int.
3165 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3166 Adjust to new way of storing sizes. Check for size overflow bugs
3167 in rest of code.
3168 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3169 slightly wrong anyway, as it missed one instance of
3170 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3171 (refill_memory_reserve): Omit needless cast to size_t.
3172 (mark_object_loop_halt): Mark as externally visible.
3173
ac82cc6a
PE
3174 * xselect.c: Integer signedness and overflow fixes.
3175 (Fx_register_dnd_atom, x_handle_dnd_message):
3176 Use ptrdiff_t, not size_t, since we prefer signed.
3177 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3178 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3179 x_dnd_atoms_size and x_dnd_atoms_length.
3180
c2d1e36d
PE
3181 * doprnt.c: Prefer signed to unsigned when either works.
3182 * eval.c (verror):
3183 * doprnt.c (doprnt):
3184 * lisp.h (doprnt):
3185 * xdisp.c (vmessage):
3186 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3187 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3188 prefer signed arithmetic to avoid comparison confusion.
3189 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3190 but is a bit tricky.
3191
0e926e56
PE
3192 Assume freestanding C89 headers, string.h, stdlib.h.
3193 * data.c, doprnt.c, floatfns.c, print.c:
3194 Include float.h unconditionally.
3195 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3196 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3197 * regex.c: Likewise for stddef.h, string.h.
3198 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3199 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3200 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3201 (STDC_HEADERS): Remove obsolete defines.
3202 * sysdep.c: Include limits.h unconditionally.
3203
9cfdb3ec
PE
3204 Assume support for memcmp, memcpy, memmove, memset.
3205 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3206 * regex.c (memcmp, memcpy):
3207 Remove; we assume C89 now.
3208
3209 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3210 (__malloc_safe_bcopy): Remove; no longer needed.
3211
cf950e6b 3212 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3213 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3214 well either way, and we prefer signed to unsigned.
3215
dbf38e02
LMI
32162011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3217
3218 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3219 closes the connection while we're reading (bug#9182).
3220
d6f0886c 32212011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3222
d6f0886c
JD
3223 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3224 are specified (Bug#9168).
24e0f6b1 3225
2eb1f9e6
PE
32262011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3227
3228 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3229 Found by GCC static checking and --with-wide-int on a 32-bit host.
3230
22381272 32312011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3232
3233 * xdisp.c (compute_display_string_pos): Fix logic of caching
3234 previous display string position. Initialize cached_prev_pos to
3235 -1. Fixes slow-down at the beginning of a buffer.
3236
f25e39b4
EZ
32372011-07-24 Eli Zaretskii <eliz@gnu.org>
3238
3239 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3240 for attrs[LFACE_FONTSET_INDEX].
3241
04c4b52e
PE
32422011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3243
3244 * xml.c (parse_region): Remove unused local
3245 that was recently introduced.
3246
c1734fbd
EZ
32472011-07-23 Eli Zaretskii <eliz@gnu.org>
3248
be18c5a5
EZ
3249 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3250 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3251
c1734fbd
EZ
3252 * xdisp.c (move_it_in_display_line_to): Record the best matching
3253 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3254 exit if none of the characters scanned was an exact match.
3255 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3256 when exact match is impossible due to invisible text, and the
3257 lines are truncated.
3258
a258d627
JD
32592011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3260
3261 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3262 for OSX >= 10.7.
3263
b6d5a689
EZ
32642011-07-22 Eli Zaretskii <eliz@gnu.org>
3265
0f74f785
EZ
3266 Fix a significant slow-down of cursor motion with C-n, C-p,
3267 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3268 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3269 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3270 (next_element_from_buffer): Call compute_stop_pos_backwards to
3271 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3272 base_level_stop.
3273 (reseat): Don't look for prev_stop, as that could mean a very long
3274 run.
3275 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3276 <cached_disp_overlay_modiff>: Cache for last found display string
3277 position.
551918c1 3278 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3279 about the same buffer in the same area of character positions, and
3280 the buffer wasn't changed since the time the display string
3281 position was cached.
551918c1 3282
b2d0c91a
EZ
32832011-07-22 Eli Zaretskii <eliz@gnu.org>
3284
3285 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3286 is an integer, which is important for empty lines. (Bug#9149)
3287
043604ee
CY
32882011-07-22 Chong Yidong <cyd@stupidchicken.com>
3289
3290 * frame.c (Fmodify_frame_parameters): In tty case, update the
3291 default face if necessary (Bug#4238).
3292
da4adb04
CY
32932011-07-21 Chong Yidong <cyd@stupidchicken.com>
3294
3295 * editfns.c (Fstring_to_char): No need to explain what a character
3296 is in the docstring (Bug#6576).
3297
9abd0532
LMI
32982011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3299
3300 * xml.c (parse_region): Make sure we always return a tree.
3301
36881d16
HK
33022011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3303
3304 * xml.c (parse_region): If a document contains only comments,
3305 return that, too.
3306
1e98674d
LMI
33072011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3308
3309 * xml.c (make_dom): Return comments, too.
3310
590bd467
PE
33112011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3312
3313 Port to OpenBSD.
3314 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3315 and the surrounding thread.
3316 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3317 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3318 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3319 timer goes off.
3320 * s/openbsd.h (BROKEN_SIGIO): Define.
3321 * unexelf.c (unexec) [__OpenBSD__]:
3322 Don't update the .mdebug section of the Alpha COFF symbol table.
3323
f41628b2
LMI
33242011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3325
3326 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3327 (bug#8460).
3328
b59b67c5
PE
33292011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3330
15e3a074
PE
3331 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3332 This fixes some race conditions on the permissions of any newly
3333 created file.
3334
41bed37d
PE
3335 * alloc.c (valid_pointer_p): Use pipe, not open.
3336 This fixes some permissions issues when debugging.
3337
b59b67c5
PE
3338 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3339 If fchown fails to set both uid and gid, try to set just gid,
3340 as that is sometimes allowed. Adjust the file's mode to eliminate
3341 setuid or setgid bits that are inappropriate if fchown fails.
3342
925a6be7
SM
33432011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3344
3345 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3346 to compare Lisp_Objects.
3347 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3348 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3349 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3350
52968808
AS
33512011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3352
0a6a104b
AS
3353 * lread.c (read_integer): Unread even EOF character.
3354 (read1): Likewise. Properly record start position of symbol.
3355
52968808
AS
3356 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3357 symbol character follows.
3358
9e381cdd
PE
33592011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3360
3361 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3362 This works around a problem with the previous change to Fcopy_file.
3363 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3364 and without this change, GCC might complain about discarding
3365 fchown's return value.
3366
b5641435
JB
33672011-07-16 Juanma Barranquero <lekktu@gmail.com>
3368
3369 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3370
a8031457
PE
33712011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3372
3373 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3374
dd889327
LMI
33752011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3376
750c33f7
LMI
3377 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3378 it's used from the C level.
3379
dd889327
LMI
3380 * process.c: Use the same condition for POLL_FOR_INPUT in both
3381 keyboard.c and process.c (bug#1858).
3382
87e86684
LM
33832011-07-09 Lawrence Mitchell <wence@gmx.li>
3384
3385 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3386 (Fgnutls_boot): Use it.
3387
64348f40
AS
33882011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3389
3390 * doc.c (Fsubstitute_command_keys): Revert last change.
3391
1d698799
LMI
33922011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3393
f863868c
LMI
3394 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3395 quotes the next character, and doesn't affect other longer
3396 sequences (bug#8935).
3397
1d698799
LMI
3398 * lread.c (syms_of_lread): Clarify that is isn't only
3399 `eval-buffer' and `eval-defun' that's affected by
3400 `lexical-binding' (bug#8460).
3401
aa4b6df6
EZ
34022011-07-15 Eli Zaretskii <eliz@gnu.org>
3403
3404 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3405 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3406
5d856da6
PE
34072011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3408
ad6042bb
PE
3409 Fix minor problems found by static checking.
3410 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3411 (elsz): Now a signed constant, not a size_t var. We prefer signed
3412 types to unsigned, to avoid integer comparison confusion. Without
3413 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3414 "cannot optimize loop, the loop counter may overflow", a symptom
3415 of the confusion.
f00bbb22 3416 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3417 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3418
6468f31c
LMI
34192011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3420
49080b10
LMI
3421 * search.c (Fre_search_backward): Mention `case-fold-search' in
3422 all the re_search_* functions (bug#8138).
3423
6468f31c
LMI
3424 * keyboard.c (Fopen_dribble_file): Document when the file is
3425 closed (bug#8056).
3426
c965adc5
EZ
34272011-07-14 Eli Zaretskii <eliz@gnu.org>
3428
df9733bf
EZ
3429 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3430 bidi_cache_idx.
3431
0bb23927
EZ
3432 Support bidi reordering of display and overlay strings.
3433 * xdisp.c (compute_display_string_pos)
3434 (compute_display_string_end): Accept additional argument STRING.
3435 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3436 (reseat_to_string): Initialize bidi_it->string.s and
3437 bidi_it->string.schars.
3438 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3439 NULL (avoids a crash in bidi_paragraph_init).
3440 Initialize itb.string.lstring.
0bb23927
EZ
3441 (init_iterator): Call bidi_init_it only of a valid
3442 buffer position was specified. Initialize paragraph_embedding to
3443 L2R.
3444 (reseat_to_string): Initialize the bidi iterator.
3445 (display_string): If we need to ignore text properties of
3446 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3447 original value of -1 will not work with bidi.)
3448 (compute_display_string_pos): First arg is now struct
3449 `text_pos *'; all callers changed. Support display properties on
3450 Lisp strings.
3451 (compute_display_string_end): Support display properties on Lisp
3452 strings.
3453 (init_iterator, reseat_1, reseat_to_string): Initialize the
3454 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3455 when iterating on a string not from display properties).
640c8776
SM
3456 (compute_display_string_pos, compute_display_string_end):
3457 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3458 arrow keys.
3459 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3460 base_level_stop; instead, set base_level_stop to BEGV.
3461 Fixes crashes in vertical-motion.
0bb23927
EZ
3462 (next_element_from_buffer): Improve commentary for when
3463 the iterator is before prev_stop.
3464 (init_iterator): Initialize bidi_p from the default value of
3465 bidi-display-reordering, not from buffer-local value. Use the
3466 buffer-local value only if initializing for buffer iteration.
3467 (handle_invisible_prop): Support invisible properties on strings
3468 that are being bidi-reordered.
3469 (set_iterator_to_next): Support bidi reordering of C strings and
3470 Lisp strings.
3471 (next_element_from_string): Support bidi reordering of Lisp
3472 strings.
3473 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3474 (display_string): Support display of R2L glyph rows.
3475 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3476 (init_iterator): Don't initialize it->bidi_p for strings
3477 here.
3478 (reseat_to_string): Initialize it->bidi_p for strings here.
3479 (next_element_from_string, next_element_from_c_string)
3480 (next_element_from_buffer): Add xassert's for correspondence
3481 between IT's object being iterated and it->bidi_it.string
3482 structure.
3483 (face_before_or_after_it_pos): Support bidi iteration.
3484 (next_element_from_c_string): Handle the case of the first string
3485 character that is not the first one in the visual order.
3486 (get_visually_first_element): New function, refactored from common
3487 parts of next_element_from_buffer, next_element_from_string, and
3488 next_element_from_c_string.
3489 (tool_bar_lines_needed, redisplay_tool_bar)
3490 (display_menu_bar): Force left-to-right direction. Add a FIXME
3491 comment for making that be controlled by a user option.
3492 (push_it, pop_it): Save and restore the state of the
3493 bidi iterator. Save and restore the bidi_p flag.
3494 (pop_it): Iterate out of display property for string iteration as
3495 well.
3496 (iterate_out_of_display_property): Support iteration over strings.
3497 (handle_single_display_spec): Set up it->bidi_it for iteration
3498 over a display string, and call bidi_init_it.
3499 (handle_single_display_spec, next_overlay_string)
3500 (get_overlay_strings_1, push_display_prop): Set up the bidi
3501 iterator for displaying display or overlay strings.
3502 (forward_to_next_line_start): Don't use the shortcut if
3503 bidi-iterating.
3504 (back_to_previous_visible_line_start): If handle_display_prop
3505 pushed the iterator stack, restore the internal state of the bidi
3506 iterator by calling bidi_pop_it same number of times.
3507 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3508 and we are bidi-iterating, don't decrement the iterator position;
3509 instead, set the first_elt flag in the bidi iterator, to produce
3510 the same effect.
3511 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3512 (push_display_prop): xassert that we are iterating a buffer.
3513 (push_it, pop_it): Save and restore paragraph_embedding member.
3514 (handle_single_display_spec, next_overlay_string)
3515 (get_overlay_strings_1, reseat_1, reseat_to_string)
3516 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3517 correctly. Don't assume unibyte strings are not bidi-reordered.
3518 (compute_display_string_pos)
3519 (compute_display_string_end): Fix handling the case of C string.
3520 (push_it, pop_it): Save and restore from_disp_prop_p.
3521 (handle_single_display_spec, push_display_prop): Set the
3522 from_disp_prop_p flag.
3523 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3524 (pop_it): Call iterate_out_of_display_property only if we are
3525 popping after iteration over a string that came from a display
3526 property. Fix a typo in popping stretch info. Add an assertion
3527 for verifying that the iterator position is in sync with the bidi
3528 iterator.
3529 (handle_single_display_spec, get_overlay_strings_1)
3530 (push_display_prop): Fix initialization of paragraph direction for
3531 string when that of the parent object is not yet determined.
3532 (reseat_1): Call bidi_init_it to resync the bidi
3533 iterator with IT's position. (Bug#7616)
3534 (find_row_edges): If ROW->start.pos gives position
3535 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3536 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3537 Reset the from_disp_prop_p flag.
3538 (SAVE_IT, RESTORE_IT): New macros.
3539 (pos_visible_p, face_before_or_after_it_pos)
3540 (back_to_previous_visible_line_start)
3541 (move_it_in_display_line_to, move_it_in_display_line)
3542 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3543 (try_scrolling, redisplay_window, display_line): Use them when
3544 saving a temporary copy of the iterator and restoring it back.
3545 (back_to_previous_visible_line_start, reseat_1)
3546 (init_iterator): Empty the bidi cache "stack".
3547 (move_it_in_display_line_to): If iterator ended up at
3548 EOL, but we never saw any buffer positions smaller than
3549 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3550 motion in bidi-reordered lines.
3551 (move_it_in_display_line_to): Record prev_method and prev_pos
3552 immediately before the call to set_iterator_to_next. Fixes cursor
3553 motion in bidi-reordered lines with stretch glyphs and strings
3554 displayed in margins. (Bug#8133) (Bug#8867)
3555 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3556 TO_CHARPOS.
640c8776
SM
3557 (pos_visible_p): Support positions in bidi-reordered lines.
3558 Save and restore bidi cache.
0bb23927
EZ
3559
3560 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3561 (bidi_paragraph_info): Delete unused struct.
3562 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3563 (bidi_cache_start): New variable.
3564 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3565 to zero.
3566 (bidi_cache_fetch_state, bidi_cache_search)
3567 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3568 (bidi_cache_find, bidi_peek_at_next_level)
3569 (bidi_level_of_next_char, bidi_find_other_level_edge)
3570 (bidi_move_to_visually_next): Compare cache index with
3571 bidi_cache_start rather than with zero.
3572 (bidi_fetch_char): Accept new argument STRING; all callers
3573 changed. Support iteration over a string. Support strings with
3574 display properties. Support unibyte strings. Fix the type of
3575 `len' according to what STRING_CHAR_AND_LENGTH expects.
3576 (bidi_paragraph_init, bidi_resolve_explicit_1)
3577 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3578 (bidi_level_of_next_char, bidi_move_to_visually_next):
3579 Support iteration over a string.
0bb23927
EZ
3580 (bidi_set_sor_type, bidi_resolve_explicit_1)
3581 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3582 can now be zero (for strings); special values 0 and -1 were
3583 changed to -1 and -2, respectively.
3584 (bidi_char_at_pos): New function.
3585 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3586 Call it instead of FETCH_MULTIBYTE_CHAR.
3587 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3588 initialized to valid values.
3589 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3590 values.
3591 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3592 the test for valid cached positions. Fix the logic for looking up
3593 the sentinel state in the cache. GCPRO the Lisp string we are
3594 iterating.
3595 (bidi_push_it, bidi_pop_it): New functions.
3596 (bidi_initialize): Initialize the bidi cache start stack pointer.
3597 (bidi_cache_ensure_space): New function, refactored from part of
3598 bidi_cache_iterator_state. Don't assume the required size is just
3599 one BIDI_CACHE_CHUNK away.
3600 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3601 (bidi_count_bytes, bidi_char_at_pos): New functions.
3602 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3603 always valid if bidi_cache_idx is valid.
3604 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3605 is valid if it's going to be used.
3606 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3607 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3608 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3609 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3610 (bidi_find_other_level_edge, bidi_cache_start_stack):
3611 All variables related to cache indices are now EMACS_INT.
c965adc5 3612
0bb23927
EZ
3613 * dispextern.h (struct bidi_string_data): New structure.
3614 (struct bidi_it): New member `string'. Make flag members be 1-bit
3615 fields, and put them last in the struct.
640c8776
SM
3616 (compute_display_string_pos, compute_display_string_end):
3617 Update prototypes.
0bb23927
EZ
3618 (bidi_push_it, bidi_pop_it): Add prototypes.
3619 (struct iterator_stack_entry): New members bidi_p,
3620 paragraph_embedding, and from_disp_prop_p.
3621 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3622 (bidi_shelve_cache, bidi_unshelve_cache):
3623 Declare prototypes.
0bb23927
EZ
3624
3625 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3626 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3627 and vector-like objects.
3628
3629 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3630 cache around display iteration.
3631
3632 * window.c (Fwindow_end, window_scroll_pixel_based)
3633 (displayed_window_lines, Frecenter): Save and restore the bidi
3634 cache around display iteration.
3635
3bbd2265
LMI
36362011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3637
3638 * editfns.c (Fdelete_region): Clarify the use of the named
3639 parameters (bug#6788).
3640
adc47434
MR
36412011-07-14 Martin Rudalics <rudalics@gmx.at>
3642
3643 * indent.c (Fvertical_motion): Set and restore w->pointm when
3644 saving and restoring the window's buffer (Bug#9006).
3645
837c31f8
LMI
36462011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3647
3648 * editfns.c (Fstring_to_char): Clarify just what is returned
3649 (bug#6576). Text by Eli Zaretskii.
3650
ac389d0c
JB
36512011-07-13 Juanma Barranquero <lekktu@gmail.com>
3652
3653 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3654
0be0ce47
EZ
36552011-07-13 Eli Zaretskii <eliz@gnu.org>
3656
3657 * buffer.c (mmap_find): Fix a typo.
3658
cd18e7e3
JB
36592011-07-13 Johan Bockgård <bojohan@gnu.org>
3660
3661 Fix execution of x selection hooks.
3662 * xselect.c (Qx_lost_selection_functions)
3663 (Qx_sent_selection_functions): New vars.
3664 (syms_of_xselect): DEFSYM them.
3665 (x_handle_selection_request): Pass Qx_sent_selection_functions
3666 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3667 (x_handle_selection_clear,x_clear_frame_selections):
3668 Pass Qx_lost_selection_functions rather than
3669 Vx_lost_selection_functions to Frun_hook_with_args.
3670
47ea7f44
PE
36712011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3672
ac389d0c 3673 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3674 The old code sometimes used this field without initializing it.
3675
47ea7f44
PE
3676 * alloc.c (gc_sweep): Don't read past end of array.
3677 In theory, the old code could also have corrupted Emacs internals,
3678 though it'd be very unlikely.
3679
bc985c87
AS
36802011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3681
3682 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3683 argument. (Bug#4026)
bc985c87 3684
0cf34688
LMI
36852011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3686
b3dadd76
LMI
3687 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3688 key" (bug#4257).
3689
0cf34688
LMI
3690 * window.c (Fset_window_start): Doc fix (bug#4199).
3691 (Fset_window_hscroll): Ditto.
3692
270768cd
PE
36932011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3694
077e3dda 3695 Fix minor new problems caught by GCC 4.6.1.
270768cd 3696 * term.c (init_tty): Remove unused local.
490011a6 3697 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3698 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3699 not used otherwise.
270768cd 3700
b1f58454
CY
37012011-07-12 Chong Yidong <cyd@stupidchicken.com>
3702
3703 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3704
22b9578d
LMI
37052011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3706
6e70ab07
LMI
3707 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3708 are the mini-buffer and the echo area (bug#3320).
3709
22b9578d
LMI
3710 * term.c (init_tty): Remove support for supdup, c10 and perq
3711 terminals, which are no longer supported (bug#1482).
3712
8974cc9f
JB
37132011-07-10 Johan Bockgård <bojohan@gnu.org>
3714
3715 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3716
a560d974
JD
37172011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3718
3719 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3720 for non-popups (Bug#3642).
3721
1dae0f0a
AS
37222011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3723
268c2c36 3724 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3725 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3726 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3727 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3728 * data.c (fmod): Likewise.
3729 * dispnew.c (swap_glyphs_in_rows): Likewise.
3730 * emacs.c (memory_warning_signal): Likewise.
3731 * floatfns.c (float_error): Likewise.
3732 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3733 (otf_open, font_otf_capability, generate_otf_features)
3734 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3735 Likewise.
3736 * image.c (pbm_read_file): Likewise.
3737 * indent.c (string_display_width): Likewise.
3738 * intervals.c (check_for_interval, search_for_interval)
3739 (inc_interval_count, count_intervals, root_interval)
3740 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3741 * lread.c (defalias): Likewise.
268c2c36 3742 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3743 * regex.c (set_image_of_range_1, set_image_of_range)
3744 (regex_grow_registers): Likewise.
3745 * sysdep.c (strerror): Likewise.
3746 * termcap.c (valid_filename_p, tprint, main): Likewise.
3747 * tparam.c (main): Likewise.
3748 * unexhp9k800.c (run_time_remap, save_data_space)
3749 (update_file_ptrs, read_header, write_header, calculate_checksum)
3750 (copy_file, copy_rest, display_header): Likewise.
3751 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3752 Likewise.
3753 * xdisp.c (check_it): Likewise.
3754 * xfaces.c (register_color, unregister_color, unregister_colors):
3755 Likewise.
3756 * xfns.c (print_fontset_result): Likewise.
3757 * xrdb.c (member, fatal, main): Likewise.
3758
99033785
PE
37592011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3760
3761 Fix minor problems found by static checking (Bug#9031).
3762 * chartab.c (char_table_set_range, map_sub_char_table):
3763 Remove unused locals.
3764 (uniprop_table): Now static.
3765 * composite.c (_work_char): Remove unused static var.
3766
9cb2ac56
JB
37672011-07-09 Juanma Barranquero <lekktu@gmail.com>
3768
3769 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3770
f25661f0
JD
37712011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3772
3773 * gtkutil.c (qttip_cb): Remove code without function.
3774
8278c4fe
EZ
37752011-07-09 Eli Zaretskii <eliz@gnu.org>
3776
3777 * w32.c (pthread_sigmask): New stub.
3778
1692ae2d 37792011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3780
8a6ebd58 3781 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3782 sigprocmask is portable only for single-threaded applications, and
3783 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3784 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3785 (LIBES): Use it.
3786 * callproc.c (Fcall_process):
3787 * process.c (create_process):
3788 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3789 Use pthread_sigmask, not sigprocmask.
123403e4 3790
1b854618
JD
37912011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3792
3793 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3794 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3795 wrong (Bug#8591).
3796
3fe4b549
JD
37972011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3798
0ce7e563
JD
3799 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3800 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3801 (xg_hide_tooltip): Fix comment.
3802
3fe4b549
JD
3803 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3804 in registerServicesMenuSendTypes.
3805 (validRequestorForSendType): Don't check ns_return_types.
3806
3807 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3808 ns_return_type.
3809
5df75e47
JR
38102011-07-08 Jason Rumney <jasonr@gnu.org>
3811
22610910
JR
3812 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3813 SH_SHOW for hidden windows (Bug#5482).
3814
5df75e47
JR
3815 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3816 frame struct members of non-existent frames (Bug#6284).
3817
699c10bd
JD
38182011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3819
4393663b
JD
3820 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3821 variable firstTime not needed on OSX >= 10.6.
3822 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3823 >= 10.5. Use setKnobProportion, setDoubleValue.
3824
3825 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3826 (MAC_OS_X_VERSION_10_5): Define if not defined.
3827 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3828 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3829 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3830
3831 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3832 cString and lossyCString on OSX >= 10.4
3833
58179cce 3834 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3835 sizeToFit on OSX >= 10.2.
3836
3837 * nsimage.m (allocInitFromFile): Don't use deprecated method
3838 bestRepresentationForDevice on OSX >= 10.6.
3839
3840 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3841 to avoid warning.
3842
3843 * emacs.c: Declare unexec_init_emacs_zone.
3844
a63e0781
JD
3845 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3846
699c10bd
JD
3847 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3848
3849 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3850 on svcsMenu (Bug#8842).
3851
3852 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3853 ns_return_types.
3854 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3855
3856 * nsterm.m (QUTF8_STRING): Declare.
3857 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3858 (validRequestorForSendType): Return type is (id).
3859 Change indexOfObjectIdenticalTo to indexOfObject.
3860 Check if we have local selection before returning self (Bug#8842).
3861 (writeSelectionToPasteboard): Put local selection into paste board
3862 if we have a local selection (Bug#8842).
3863 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3864
3865 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3866 (ns_get_local_selection): Declare.
3867
54e10184
LMI
38682011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3869
9888ff71
LMI
3870 * keymap.c (describe_map_tree): Don't insert a double newline at
3871 the end of the buffer (bug#1169) and return whether we inserted
3872 something.
3873
54e10184
LMI
3874 * callint.c (Fcall_interactively): Change "reading args" to
3875 "providing args" to try to clarify what it does (bug#1010).
3876
15fa4783
KH
38772011-07-07 Kenichi Handa <handa@m17n.org>
3878
3879 * composite.c (composition_compute_stop_pos): Ignore a static
3880 composition starting before CHARPOS (Bug#8915).
3881
3882 * xdisp.c (handle_composition_prop): Likewise.
3883
a8815b00
EZ
38842011-07-07 Eli Zaretskii <eliz@gnu.org>
3885
3886 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3887 (Bug#9015)
3888
ef7b981d 38892011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3890
3891 * character.h (unicode_category_t): New enum type.
3892
3893 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3894 (Qchar_code_property_table): New variable.
3895 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3896 (UNIPROP_COMPRESSED_FORM_P): New macros.
3897 (char_table_ascii): Uncompress the compressed values.
3898 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3899 Uncompress the compressed values.
ac389d0c 3900 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3901 (char_table_ref_and_range): Uncompress the compressed values.
3902 (sub_char_table_set): New arg is_uniprop. Callers changed.
3903 Uncompress the compressed values.
3904 (sub_char_table_set_range): Args changed. Callers changed.
3905 (char_table_set_range): Adjuted for the above change.
3906 (map_sub_char_table): Delete args default_val and parent. Add arg
3907 top. Give decoded values to a Lisp function.
640c8776 3908 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3909 values to a Lisp function. Gcpro more variables.
3910 (uniprop_table_uncompress)
3911 (uniprop_decode_value_run_length): New functions.
3912 (uniprop_decoder, uniprop_decoder_count): New variables.
3913 (uniprop_get_decoder, uniprop_encode_value_character)
3914 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3915 New functions.
3916 (uniprop_encoder, uniprop_encoder_count): New variables.
3917 (uniprop_get_encoder, uniprop_table)
3918 (Funicode_property_table_internal, Fget_unicode_property_internal)
3919 (Fput_unicode_property_internal): New functions.
3920 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3921 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3922 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3923 char-code-property-alist.
3924
640c8776 3925 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3926 Vunicode_category_table.
3927
640c8776 3928 * font.c (font_range): Adjust for the change of
c805dec0
KH
3929 Vunicode_category_table.
3930
76b397fb
DN
39312011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3932
3933 * m/iris4d.h: Remove file, move contents ...
3934 * s/irix6-5.h: ... here.
3935
22b4128e
PE
39362011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3937
3938 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3939 * alloc.c (mark_buffer):
3940 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3941 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3942 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3943 This isn't true in general, and it's particularly not true
3944 if Emacs is configured with --with-wide-int.
3945 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3946 New macros, used in the buffer.c change.
3947
869795d6
JD
39482011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3949
3950 * xsettings.c: Use both GConf and GSettings if both are available.
3951 (store_config_changed_event): Add comment.
3952 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3953 (store_tool_bar_style_changed): New functions.
5e617bc2 3954 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3955 (struct xsettings): Move font inside HAVE_XFT.
3956 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3957 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3958 Move inside HAVE_XFT.
640c8776 3959 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3960 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3961 also.
3962 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3963 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3964 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3965 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3966 (parse_settings): Move check for font inside HAVE_XFT.
3967 (read_settings, apply_xft_settings): Add comment.
3968 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3969 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3970 call store_font_name_changed.
3971 (xft_settings_event): Add comment.
3972 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3973 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3974 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3975 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3976 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3977 (xsettings_get_system_font, xsettings_get_system_normal_font):
3978 Add comment.
869795d6 3979
d8ed26bd
PE
39802011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3981
3982 Random fixes. E.g., (random) never returned negative values.
3983 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3984 subseconds part to the entropy, as that's a bit more random.
3985 Prefer signed to unsigned, since the signedness doesn't matter and
3986 in general we prefer signed. When given a limit, use a
3987 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3988 latter isn't right if USE_2_TAGS_FOR_INTS.
3989 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3990 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3991
cabf1cac
SM
39922011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3993
3994 * textprop.c (text_property_stickiness):
3995 Obey Vtext_property_default_nonsticky.
3996 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3997 * w32fns.c (syms_of_w32fns):
3998 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3999
6e9b2be9
PE
40002011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4001
4002 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4003 This is more efficient than Ffile_directory_p and avoids a minor race.
4004
90186c68
LMI
40052011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4006
7c301272
LMI
4007 * buffer.c (Foverlay_put): Say what the return value is
4008 (bug#7835).
4009
c4f2d8d4
LMI
4010 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4011 is a directory before asking whether to use the file name
4012 (bug#7564).
ad637907
LMI
4013 (barf_or_query_if_file_exists): Make the "File is a directory"
4014 error be more correct.
c4f2d8d4 4015
90186c68
LMI
4016 * fns.c (Frequire): Remove the mention of the .gz files, since
4017 that's installation-specific, but keep the mention of
4018 `get-load-suffixes'.
4019
da64016e
PE
40202011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4021
4022 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4023 Report string overflow if the output is too long.
4024
7d47b580
JB
40252011-07-04 Juanma Barranquero <lekktu@gmail.com>
4026
a555cb87
JB
4027 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4028 (syms_of_gnutls): Remove duplicate DEFSYM for
4029 Qgnutls_bootprop_verify_hostname_error, an error for
4030 Qgnutls_bootprop_verify_error (which is no longer used).
4031
7d47b580
JB
4032 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4033 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4034 Also (re)move comments that are misplaced or no longer relevant.
4035
1e49bfab
LMI
40362011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4037
4038 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4039
1485f4c0
CY
40402011-07-03 Chong Yidong <cyd@stupidchicken.com>
4041
4042 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4043 and background color parameters if they have been changed.
4044
a9ab721e
LMI
40452011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4046
4047 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4048
cf7cff57
PE
40492011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4050
2e13213d
PE
4051 * xsettings.c (SYSTEM_FONT): Define only when used.
4052 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4053
cf7cff57
PE
4054 * keymap.c (access_keymap_1): Now static.
4055
7a8e04f7
CY
40562011-07-02 Chong Yidong <cyd@stupidchicken.com>
4057
4058 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4059 leave any prefix arg for the up event (Bug#1586).
4060
61352f62
LMI
40612011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4062
69bb1ef7
LMI
4063 * lread.c (syms_of_lread): Mention single symbols defined by
4064 `defvar' or `defconst' (bug#7154).
4065
61352f62 4066 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4067 (Frequire): Mention get-load-suffixes.
61352f62 4068
28545e04
MR
40692011-07-02 Martin Rudalics <rudalics@gmx.at>
4070
4071 * window.h (window): Remove clone_number slot.
4072 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4073 Remove.
4074 (make_parent_window, make_window, saved_window)
4075 (Fset_window_configuration, save_window_save): Don't deal with
4076 clone numbers.
4077 * buffer.c (Qclone_number): Remove declaration.
4078 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4079
3349e122
SM
40802011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4081
4082 Add multiple inheritance to keymaps.
4083 * keymap.c (Fmake_composed_keymap): New function.
4084 (Fset_keymap_parent): Simplify.
4085 (fix_submap_inheritance): Remove.
4086 (access_keymap_1): New function extracted from access_keymap to handle
4087 embedded parents and handle lists of maps.
4088 (access_keymap): Use it.
4089 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4090 (Fcopy_keymap): Handle embedded parents.
4091 (Fcommand_remapping, define_as_prefix): Simplify.
4092 (Fkey_binding): Simplify.
4093 (syms_of_keymap): Move minibuffer-local-completion-map,
4094 minibuffer-local-filename-completion-map,
4095 minibuffer-local-must-match-map, and
4096 minibuffer-local-filename-must-match-map to Elisp.
4097 (syms_of_keymap): Defsubr make-composed-keymap.
4098 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4099 (parse_menu_item): Trivial simplification.
4100
3279eb87
GM
41012011-07-01 Glenn Morris <rgm@gnu.org>
4102
4103 * Makefile.in (SETTINGS_LIBS): Fix typo.
4104
4550efdf
KI
41052011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4106
4107 * coding.c (Fencode_coding_string): Record the last coding system
4108 used, as the function doc string says (bug#8738).
4109
0949d2b6
JD
41102011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4111
4112 * xsettings.c (store_monospaced_changed): Take new font as arg and
4113 check for change against current_mono_font.
4114 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4115 (emacs_settings_constructor, emacs_settings_get_property)
4116 (emacs_settings_set_property, emacs_settings_class_init)
4117 (emacs_settings_init, gsettings_obj): Remove.
4118 (something_changedCB): New function for HAVE_GSETTINGS.
4119 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4120 with value as argument.
4121 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4122 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4123 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4124 "changed".
4125
4126 * xgselect.c: Add defined (HAVE_GSETTINGS).
4127 (xgselect_initialize): Ditto.
4128
4129 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4130 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4131 xg_select.
4132
bbc6b304
PE
41332011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4134
4135 * eval.c (struct backtrace): Simplify and port the data structure.
4136 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4137 signed bit field, as this assumption is not portable and it makes
4138 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4139 "char debug_on_exit : 1" as this is not portable either; instead,
4140 use the portable "unsigned int debug_on_exit : 1". Remove unused
4141 member evalargs. Remove obsolete comments about cc bombing out.
4142
9851bfc5
JD
41432011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4144
51bb811f 4145 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4146 Let HAVE_GSETTINGS override HAVE_GCONF.
4147 (store_monospaced_changed): New function.
4148 (EMACS_SETTINGS): A new type derived from GObject to handle
4149 GSettings notifications.
4150 (emacs_settings_constructor, emacs_settings_get_property)
4151 (emacs_settings_set_property, emacs_settings_class_init):
4152 New functions.
4153 (gsettings_client, gsettings_obj): New variables.
4154 (GSETTINGS_SCHEMA): New define.
4155 (something_changedCB): Call store_monospaced_changed.
4156 (init_gsettings): New function.
4157 (xsettings_initialize): Call init_gsettings.
4158 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4159 to NULL.
4160
640c8776 4161 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4162 GCONF_CFLAGS/LIBS.
4163
5386012d
MR
41642011-06-29 Martin Rudalics <rudalics@gmx.at>
4165
4166 * window.c (resize_root_window, grow_mini_window)
4167 (shrink_mini_window): Rename Qresize_root_window to
4168 Qwindow_resize_root_window and Qresize_root_window_vertically to
4169 Qwindow_resize_root_window_vertically.
4170
f13e0b08
PE
41712011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4172
4173 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4174
94515237
JB
41752011-06-27 Juanma Barranquero <lekktu@gmail.com>
4176
4177 * makefile.w32-in: Redesign dependencies so they reflect more
4178 clearly which files are directly included by each source file,
4179 and not through other includes.
4180
e43b6e43
MR
41812011-06-27 Martin Rudalics <rudalics@gmx.at>
4182
4183 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4184 (sort_overlays, overlay_strings): When an overlay's clone number
4185 matches the window's clone number process the overlay even if
4186 the overlay's window property doesn't match the current window.
4187
d68443dc
MR
4188 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4189 (Fwindow_hchild): Rename to Fwindow_left_child.
4190 (Fwindow_next): Rename to Fwindow_next_sibling.
4191 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4192 (resize_window_check): Rename to window_resize_check.
4193 (resize_window_apply): Rename to window_resize_apply.
4194 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4195 (Fdelete_other_windows_internal, resize_frame_windows)
4196 (Fsplit_window_internal, Fdelete_window_internal)
4197 (grow_mini_window, shrink_mini_window)
4198 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4199
c7e73be5
JD
42002011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4201
4202 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4203 (emacs_fixed_set_min_size): Remove.
4204 (emacs_fixed_new): Take frame as argument.
4205
4206 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4207 (_EmacsFixedPrivate): Remove minwidth/height.
4208 Add struct frame *f.
4209 (emacs_fixed_init): Initialize priv->f.
4210 (get_parent_class, emacs_fixed_set_min_size): Remove.
4211 (emacs_fixed_new): Set priv->f to argument.
4212 (emacs_fixed_get_preferred_width)
4213 (emacs_fixed_get_preferred_height): Use min_width/height from
4214 frames size_hint to set minimum and natural (Bug#8919).
4215 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4216 and use min_width/height from frames size_hint to set
4217 min_width/height (Bug#8919).
4218
4219 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4220 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4221 Fix indentation.
c7e73be5 4222
cf99dcf8
EZ
42232011-06-26 Eli Zaretskii <eliz@gnu.org>
4224
4225 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4226 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4227 called at ZV.
4228
029529ac
CY
42292011-06-26 Chong Yidong <cyd@stupidchicken.com>
4230
4231 * process.c (wait_reading_process_output): Bypass select if
4232 waiting for a cell while ignoring keyboard input, and input is
4233 pending. Suggested by Jan Djärv (Bug#8869).
4234
7a7ef429
PE
42352011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4236
4237 Use gnulib's dup2 module instead of rolling our own.
4238 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4239
11fdef7d 42402011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4241
4242 * dispnew.c (scrolling_window): Before scrolling, turn off a
4243 mouse-highlight in the window being scrolled.
4244
cd3520a4
JB
42452011-06-24 Juanma Barranquero <lekktu@gmail.com>
4246
4247 Move DEFSYM to lisp.h and use everywhere.
4248
4249 * character.h (DEFSYM): Move declaration...
4250 * lisp.h (DEFSYM): ...here.
4251
4252 * gnutls.c:
4253 * minibuf.c:
4254 * w32menu.c:
4255 * w32proc.c:
4256 * w32select.c: Don't include character.h.
4257
4258 * alloc.c (syms_of_alloc):
4259 * buffer.c (syms_of_buffer):
4260 * bytecode.c (syms_of_bytecode):
4261 * callint.c (syms_of_callint):
4262 * casefiddle.c (syms_of_casefiddle):
4263 * casetab.c (init_casetab_once):
4264 * category.c (init_category_once, syms_of_category):
4265 * ccl.c (syms_of_ccl):
4266 * cmds.c (syms_of_cmds):
4267 * composite.c (syms_of_composite):
4268 * dbusbind.c (syms_of_dbusbind):
4269 * dired.c (syms_of_dired):
4270 * dispnew.c (syms_of_display):
4271 * doc.c (syms_of_doc):
4272 * editfns.c (syms_of_editfns):
4273 * emacs.c (syms_of_emacs):
4274 * eval.c (syms_of_eval):
4275 * fileio.c (syms_of_fileio):
4276 * fns.c (syms_of_fns):
4277 * frame.c (syms_of_frame):
4278 * fringe.c (syms_of_fringe):
4279 * insdel.c (syms_of_insdel):
4280 * keymap.c (syms_of_keymap):
4281 * lread.c (init_obarray, syms_of_lread):
4282 * macros.c (syms_of_macros):
4283 * msdos.c (syms_of_msdos):
4284 * print.c (syms_of_print):
4285 * process.c (syms_of_process):
4286 * search.c (syms_of_search):
4287 * sound.c (syms_of_sound):
4288 * syntax.c (init_syntax_once, syms_of_syntax):
4289 * terminal.c (syms_of_terminal):
4290 * textprop.c (syms_of_textprop):
4291 * undo.c (syms_of_undo):
4292 * w32.c (globals_of_w32):
4293 * window.c (syms_of_window):
4294 * xdisp.c (syms_of_xdisp):
4295 * xfaces.c (syms_of_xfaces):
4296 * xfns.c (syms_of_xfns):
4297 * xmenu.c (syms_of_xmenu):
4298 * xsettings.c (syms_of_xsettings):
4299 * xterm.c (syms_of_xterm): Use DEFSYM.
4300
4228cf16
TZ
43012011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4302
cd3520a4 4303 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4304
7fcccf1e
PE
43052011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4306
7efb4e0e
PE
4307 Integer and buffer overflow fixes (Bug#8873).
4308
ff5844ad
PE
4309 * print.c (printchar, strout): Check for string overflow.
4310 (PRINTPREPARE, printchar, strout):
4311 Don't set size unless allocation succeeds.
4312
90532f02
PE
4313 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4314 for sizes. Check for string overflow more accurately.
4315 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4316
6d84508d
PE
4317 * macros.c: Integer and buffer overflow fixes.
4318 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4319 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4320 Use ptrdiff_t, not int, for sizes.
4321 Don't increment bufsize until after realloc succeeds.
4322 Check for size-calculation overflow.
4323 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4324
437b2cb4
PE
4325 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4326
8b9ac8b4
PE
4327 * lread.c: Integer overflow fixes.
4328 (read_integer): Radix is now EMACS_INT, not int,
4329 to improve quality of diagnostics for out-of-range radices.
4330 Calculate buffer size correctly for out-of-range radices.
4331 (read1): Check for integer overflow in radices, and in
4332 read-circle numbers.
82cb60d3
PE
4333 (read_escape): Avoid int overflow.
4334 (Fload, openp, read_buffer_size, read1)
4335 (substitute_object_recurse, read_vector, read_list, map_obarray):
4336 Use ptrdiff_t, not int, for sizes.
4337 (read1): Use EMACS_INT, not int, for sizes.
20270765 4338 Check for size overflow.
8b9ac8b4 4339
7fcccf1e
PE
4340 * image.c (cache_image): Check for size arithmetic overflow.
4341
bfbbd7e7
PE
4342 * lread.c: Integer overflow issues.
4343 (saved_doc_string_size, saved_doc_string_length)
4344 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4345 Now ptrdiff_t, not int.
4346 (read1): Don't assume doc string length fits in int. Check for
4347 out-of-range doc string lengths.
4348 (read_list): Don't assume file position fits in int.
39019e54 4349 (read_escape): Check for hex character overflow.
bfbbd7e7 4350
4e323265
LL
43512011-06-22 Leo Liu <sdl.web@gmail.com>
4352
4353 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4354 Move to minibuffer.el.
4355
85fece3e
PE
43562011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4357
20b84ce9 4358 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4359 The following patches are for when GLYPH_DEBUG && !XASSERT.
4360 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4361 * dispnew.c (flush_stdout):
4362 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4363 Mark as externally visible.
4364 * dispnew.c (check_window_matrix_pointers): Now static.
4365 * dispnew.c (window_to_frame_vpos):
4366 * xfns.c (unwind_create_frame):
4367 * xterm.c (x_check_font): Remove unused local.
4368 * scroll.c (CHECK_BOUNDS):
4369 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4370 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4371 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4372 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4373 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4374 Now static.
4375 (debug_method_add): Use va_list and vsprintf rather than relying
4376 on undefined behavior with wrong number of arguments.
4377 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4378 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4379 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4380 since we're not interested in debugging glyphs with old libraries.
4381 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4382 GCC 4.6.0's static checking.
4383
0766b489
PE
43842011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4385
31fd4b32
PE
4386 Integer overflow and signedness fixes (Bug#8873).
4387 A few related buffer overrun fixes, too.
4388
b79e8648
PE
4389 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4390
0766b489
PE
4391 * dispextern.h (struct face.stipple):
4392 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4393 (x_bitmap_mask, x_allocate_bitmap_record)
4394 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4395 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4396 (x_create_bitmap_from_xpm_data):
4397 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4398 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4399 (.bitmaps_last):
4400 * xfaces.c (load_pixmap):
4401 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4402 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4403 (.bitmaps_last, struct x_output.icon_bitmap):
4404 Use ptrdiff_t, not int, for bitmap indexes.
4405 (x_allocate_bitmap_record): Check for size overflow.
4406 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4407
b081724f
PE
4408 Use ptrdiff_t, not int, for overlay counts.
4409 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4410 * editfns.c (overlays_around, get_pos_property):
4411 * textprop.c (get_char_property_and_overlay):
4412 * xdisp.c (next_overlay_change, note_mouse_highlight):
4413 * xfaces.c (face_at_buffer_position):
21514da7
PE
4414 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4415 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4416 (Fnext_overlay_change, Fprevious_overlay_change)
4417 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4418 Use ptrdiff_t, not int, for sizes.
21514da7 4419 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4420
3de73e5e
PE
4421 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4422
2606c57b
PE
4423 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4424 (x_session_initialize): Do not assume string length fits in int.
4425
aaafe47a
PE
4426 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4427 This is unlikely, but can occur if DPI is outlandish.
4428
2674ddc8 4429 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4430 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4431
28154962
PE
4432 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4433 * xrdb.c (magic_file_p, search_magic_path):
4434 Omit last arg SUFFIX; it was always 0. All callers changed.
4435 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4436
7de51af5
PE
4437 * xfont.c (xfont_match): Avoid need for strlen.
4438
25ed6cc3
PE
4439 * xfns.c: Don't assume strlen fits in int.
4440 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4441
4eab31dd
PE
4442 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4443 not unsigned long, as we prefer signed integers. All callers changed.
4444 Detect integer overflow in repeat count.
4445 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4446 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4447
171e2a58
PE
4448 * termcap.c: Don't assume sizes fit in int and never overflow.
4449 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4450 (gobble_line): Check for size-calculation overflow.
4451
ad39faca 4452 * minibuf.c (Fread_buffer):
6e5bb2dc 4453 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4454 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4455 Don't assume string length fits in int.
4456
52c61c22 4457 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4458 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4459
b5b8c9e5
PE
4460 * font.c: Don't assume string length fits in int.
4461 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4462 Use ptrdiff_t, not int.
ccd6111c
PE
4463 (font_intern_prop): Don't assume string length fits in int.
4464 Don't assume integer property fits in fixnum.
4465 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4466
882f0d81 4467 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4468 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4469 Reformulate so as not to need the command string.
4470 Invoke gzip -cd rather than gunzip, as it's more portable.
4471 (lock_info_type, lock_file_1, lock_file):
4472 Don't assume pid_t and time_t fit in unsigned long.
4473 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4474 (current_lock_owner): Prefer signed type for sizes.
4475 Use memcpy, not strncpy, where memcpy is what is really wanted.
4476 Don't assume (via atoi) that time_t and pid_t fit in int.
4477 Check for time_t and/or pid_t out of range, e.g., via a network share.
4478 Don't alloca where an auto var works fine.
4479
93f4cf88
PE
4480 * fileio.c: Fix some integer overflow issues.
4481 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4482 Don't assume string length fits in int.
4483 (directory_file_name): Don't assume string length fits in long.
4484 (make_temp_name): Don't assume pid fits in int, or that its print
4485 length is less than 20.
4486
f3e92b69
PE
4487 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4488
1bfdaf10
PE
4489 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4490
35016e9a
PE
4491 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4492
3d1e65a1
PE
4493 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4494 We prefer signed integers, even for size calculations.
4495
0b963a93
PE
4496 * emacs.c: Don't assume string length fits in 'int'.
4497 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4498 (main): Don't invoke strlen when not needed.
4499
573f4b54
PE
4500 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4501 (XD_DEBUG_MESSAGE): Don't waste a byte.
4502
989f33ba
PE
4503 * callproc.c (getenv_internal_1, getenv_internal)
4504 (Fgetenv_internal):
965d34eb
PE
4505 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4506
e4d29b33
PE
4507 * lread.c (invalid_syntax): Omit length argument.
4508 All uses changed. This doesn't fix a bug, but it simplifies the
4509 code away from its former Hollerith-constant appearance, and it's
4510 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4511 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4512
eb49b136
PE
4513 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4514 This didn't break anything, but it didn't help either.
4515 It's confusing to put a bogus integer in a place where the actual
4516 value does not matter.
9f62aeb1 4517 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4518 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4519
15375a22
PE
4520 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4521 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4522 implementation.
b61cc01c
PE
4523 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4524 We prefer signed types, and the value cannot exceed the EMACS_INT
4525 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4526 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4527 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4528 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4529
53b2623d
PE
4530 * indent.c (sane_tab_width): New function.
4531 (current_column, scan_for_column, Findent_to, position_indentation)
4532 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4533 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4534
51cab52b 4535 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4536
f2ed8a70
PE
4537 * lisp.h (lint_assume): New macro.
4538 * composite.c (composition_gstring_put_cache):
4539 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4540
abe80cc6
PE
4541 * editfns.c, insdel.c:
4542 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4543
b02c740e
PE
4544 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4545
ebc96716
PE
4546 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4547
b4e50fa0 4548 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4549 Use much-faster test for byte-length change.
311d5d7c 4550 Don't assume string byte-length fits in 'int'.
a4cf38e4 4551 Check that character arg fits in 'int'.
85461888 4552 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4553
c0c1ee9f
PE
4554 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4555
a498d7f4
PE
4556 * fns.c (concat): Catch string overflow earlier.
4557 Do not rely on integer wraparound.
4558
51cab52b
PE
4559 * dispextern.h (struct it.overlay_strings_charpos)
4560 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4561 * xdisp.c (forward_to_next_line_start)
4562 (back_to_previous_visible_line_start)
4563 (reseat_at_next_visible_line_start, next_element_from_buffer):
4564 Don't arbitrarily truncate the value of 'selective' to int.
4565
76031fad
PE
4566 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4567
5eb55db9
PE
4568 * composite.c: Don't truncate sizes to 'int'.
4569 (composition_gstring_p, composition_reseat_it)
4570 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4571 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4572 not EMACS_UINT, for indexes.
5eb55db9 4573
0703a717
PE
4574 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4575
d6202519
PE
4576 * buffer.c: Include <verify.h>.
4577 (struct sortvec.priority, struct sortstr.priority):
8961a454 4578 Now EMACS_INT, not int.
c20998a7 4579 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4580 (struct sortstr.size, record_overlay_string)
4581 (struct sortstrlist.size, struct sortlist.used):
4582 Don't truncate size to int.
4583 (record_overlay_string): Check for size-calculation overflow.
d6202519 4584 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4585
d5a19415
JM
45862011-06-22 Jim Meyering <meyering@redhat.com>
4587
029529ac 4588 Don't leak an XBM-image-sized buffer
d5a19415
JM
4589 * image.c (xbm_load): Free the image buffer after using it.
4590
a9041e6c
PE
45912011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4592
4593 Port to Sun C.
4594 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4595 that Sun C diagnosed.
4596 * fns.c (secure_hash): Fix pointer signedness issue.
4597 * intervals.c (static_offset_intervals): New function.
4598 (offset_intervals): Use it.
4599
7f3f739f
LL
46002011-06-21 Leo Liu <sdl.web@gmail.com>
4601
4602 * deps.mk (fns.o):
4603 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4604 sha512.h.
4605
4606 * fns.c (secure_hash): Rename from crypto_hash_function and change
4607 the first arg to accept symbols.
5b66d427 4608 (Fsecure_hash): New primitive.
7f3f739f
LL
4609 (syms_of_fns): New symbols.
4610
76147d94
DD
46112011-06-20 Deniz Dogan <deniz@dogan.se>
4612
4613 * process.c (Fset_process_buffer): Clarify return value in
4614 docstring.
4615
7d7d0045
CY
46162011-06-18 Chong Yidong <cyd@stupidchicken.com>
4617
4618 * dispnew.c (add_window_display_history): Use BVAR.
4619
4620 * xdisp.c (debug_method_add): Use BVAR.
4621 (check_window_end, dump_glyph_matrix, dump_glyph)
4622 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4623
4624 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4625 Likewise.
4626
4627 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4628 check till after the cache is created in init_frame_faces.
4629
ff2bc410
SM
46302011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4631
4632 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4633
28177add
PE
46342011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4635
dd3482fe
PE
4636 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4637 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4638 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4639
393d71f3 4640 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4641 * fileio.c (Finsert_file_contents):
4642 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4643 Remove the old (too-loose) buffer overflow checks.
4644 They weren't needed, since make_gap checks for buffer overflow.
4645 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4646 The old code merely checked for Emacs fixnum overflow, and relied
4647 on undefined (wraparound) behavior. The new code avoids undefined
4648 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4649
2e6813b0 4650 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4651 Tune. Don't use wider integers than needed. Don't use alloca.
4652 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4653
599a9e4f
PE
4654 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4655
99561444
PE
4656 * insdel.c, lisp.h (buffer_overflow): New function.
4657 (insert_from_buffer_1, replace_range, replace_range_2):
4658 * insdel.c (make_gap_larger):
4659 * editfns.c (Finsert_char):
4660 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4661
28177add
PE
4662 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4663
e69dafad
PE
46642011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4665
4baa020d 4666 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 4667
b1c46f02
PE
4668 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4669 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4670
e69dafad
PE
4671 * fileio.c: Don't assume EMACS_INT fits in off_t.
4672 (emacs_lseek): New static function.
4673 (Finsert_file_contents, Fwrite_region): Use it.
4674 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4675
566684ea
PE
4676 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4677
e6966cd6
PE
4678 * fns.c: Don't overflow int when computing a list length.
4679 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4680 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4681 truncation on 64-bit hosts. Check for QUIT every
4682 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4683 faster and is responsive enough.
4684 (Flength): Report an error instead of overflowing an integer.
4685 (Fsafe_length): Return a float if the value is not representable
4686 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4687 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4688 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4689
dd0b0efb
PE
4690 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4691 (header_size, word_size): New constants.
4692 (allocate_vectorlike): Don't check size overflow here.
4693 (allocate_vector): Check it here instead, since this is the only
4694 caller of allocate_vectorlike that could cause overflow.
4695 Check that the new vector's length is representable as a fixnum.
4696
86fe5cfe
PE
4697 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4698 The previous code was bogus. For example, next_almost_prime (32)
4699 returned 39, which is undesirable as it is a multiple of 3; and
4700 next_almost_prime (24) returned 25, which is a multiple of 5 so
4701 why was the code bothering to check for multiples of 7?
4702
80e88859
PE
4703 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4704
4a2f0ad6
PE
4705 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4706
f66c7cf8
PE
4707 Variadic C functions now count arguments with ptrdiff_t.
4708 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4709 Back then I didn't know that the Emacs coding style prefers signed int.
4710 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4711 were being counted with int, which may truncate counts on 64-bit
4712 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4713 * lisp.h (struct Lisp_Subr.function.aMANY)
4714 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4715 Arg counts are now ptrdiff_t, not size_t.
4716 All variadic functions and their callers changed accordingly.
4717 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4718 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4719 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4720 * callint.c (Fcall_interactively): Check arg count for overflow,
4721 to avoid potential buffer overrun. Use signed char, not 'int',
4722 for 'varies' array, so that we needn't bother to check its size
4723 calculation for overflow.
4724 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4725 * eval.c (apply_lambda):
4726 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4727 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4728 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4729
a1759b76
PE
4730 * callint.c (Fcall_interactively): Don't use index var as event count.
4731
d96be9fc
PE
4732 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4733 * mem-limits.h (SIZE): Remove; no longer used.
4734
a690a978 4735 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4736
578c21e6
PE
4737 Remove unnecessary casts.
4738 * xterm.c (x_term_init):
4739 * xfns.c (x_set_border_pixel):
4740 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4741 These aren't needed now that we assume ANSI C.
4742
96f53c6c
PE
4743 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4744 It's more likely to cause problems (due to unsigned overflow)
4745 than to cure them.
4746
83c77d31
PE
4747 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4748
ee2079f1
PE
4749 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4750
6da65536
PE
4751 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4752
7147c4a4
PE
4753 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4754
193e32d9
PE
4755 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4756
e5533da6
PE
4757 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4758
9910e595
PE
4759 GLYPH_CODE_FACE returns EMACS_INT, not int.
4760 * dispextern.h (merge_faces):
4761 * xfaces.c (merge_faces):
01103c44
PE
4762 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4763 Don't assume EMACS_INT fits in int.
9910e595 4764
2638320e
PE
4765 * character.h (CHAR_VALID_P): Remove unused parameter.
4766 * fontset.c, lisp.h, xdisp.c: All uses changed.
4767
045eb8d9
PE
4768 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4769
c1f134b5
PE
4770 * fns.c (concat): Minor tuning based on overflow analysis.
4771 This doesn't fix any bugs. Use int to hold character, instead
4772 of constantly refetching from Emacs object. Use XFASTINT, not
4773 XINT, for value known to be a character. Don't bother comparing
4774 a single byte to 0400, as it's always less.
4775
395fcb93 4776 * floatfns.c (Fexpt):
327eeec8
PE
4777 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4778
abbd3d23
PE
4779 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4780 for characters.
4781
684a03ef
PE
4782 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4783
0fed43f3
PE
4784 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4785 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4786 incorrectly succeed when S was a string, because 4294967386 was
4787 truncated before it was used.
4788
8fd02eb7
PE
4789 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4790 Otherwise, an out-of-range integer could cause undefined behavior
4791 on a 64-bit host.
4792
f8c86b69
PE
4793 * composite.c: Use int, not EMACS_INT, for characters.
4794 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4795 EMACS_INT, for values that are known to be in character range.
4796 This doesn't fix any bugs but is the usual style inside Emacs and
4797 may generate better code on 32-bit machines.
4798
34206dd2
PE
4799 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4800 This is for reasons similar to the recent CHAR_STRING fix.
4801 * charset.c (Fencode_char): Check that character arg is actually
4802 a character. Pass an int to ENCODE_CHAR.
4803 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4804 wider than 'int', as a compile-time check to prevent future regressions
4805 in this area.
4806
c5958d4c 4807 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4808
4809 Make sure a 64-bit char is never passed to CHAR_STRING.
4810 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4811 by silently ignoring the top 32 bits, allowing some values
4812 that were far too large to be valid characters.
4813 * character.h: Include <verify.h>.
4814 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4815 arguments are no wider than unsigned, as a compile-time check
4816 to prevent future regressions in this area.
4817 * data.c (Faset):
01103c44 4818 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4819 (Fsubst_char_in_region):
4820 * fns.c (concat):
4821 * xdisp.c (decode_mode_spec_coding):
4822 Adjust to CHAR_STRING's new requirement.
4823 * editfns.c (Finsert_char, Fsubst_char_in_region):
4824 * fns.c (concat): Check that character args are actually
4825 characters. Without this test, these functions did the wrong
4826 thing with wildly out-of-range values on 64-bit hosts.
4827
d37ca623
PE
4828 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4829 These casts should not be needed on 32-bit hosts, either.
4830 * keyboard.c (read_char):
4831 * lread.c (Fload): Remove casts to unsigned.
4832
ea204efb
PE
4833 * lisp.h (UNSIGNED_CMP): New macro.
4834 This fixes comparison bugs on 64-bit hosts.
4835 (ASCII_CHAR_P): Use it.
4836 * casefiddle.c (casify_object):
01103c44 4837 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4838 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4839 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4840 * dispextern.h (FACE_FROM_ID):
4841 * keyboard.c (read_char): Use UNSIGNED_CMP.
4842
41cb286c
PE
4843 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4844 not to EMACS_INT, to avoid GCC warning.
4845
4a1b9832
PE
4846 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4847
55daad71
PE
4848 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4849 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4850 isn't needed on 32-bit machines.
8f95c75c 4851
01103c44
PE
4852 * buffer.c (Fgenerate_new_buffer_name):
4853 Use EMACS_INT for count, not int.
0ceccced 4854 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4855
4856 * data.c (Qcompiled_function): Now static.
4857
c6f072e7
PE
4858 * window.c (window_body_lines): Now static.
4859
20ce5912
PE
4860 * image.c (gif_load): Rename local to avoid shadowing.
4861
9c4c5f81
PE
4862 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4863 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4864 * alloc.c (make_save_value): Integer argument is now of type
4865 ptrdiff_t, not int.
4866 (mark_object): Use ptrdiff_t, not int.
4867 * lisp.h (pD): New macro.
4868 * print.c (print_object): Use it.
4869
c0c5c8ae
PE
4870 * alloc.c: Use EMACS_INT, not int, to count objects.
4871 (total_conses, total_markers, total_symbols, total_vector_size)
4872 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4873 (total_free_floats, total_floats, total_free_intervals)
4874 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4875 Now EMACS_INT, not int. All uses changed.
4876 (Fgarbage_collect): Compute overall total using a double, so that
4877 integer overflow is less likely to be a problem. Check for overflow
4878 when converting back to an integer.
5a25e253
PE
4879 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4880 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4881 These were 'int' variables that could overflow on 64-bit hosts;
4882 they were never used, so remove them instead of repairing them.
211a0b2a 4883 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4884 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4885 Previously, this ceilinged at INT_MAX, but that doesn't work on
4886 64-bit machines.
e46bb31a 4887 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4888
c78baabf 4889 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4890 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4891 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4892 when a (possibly-narrower) signed value would do just as well.
4893 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4894
c9d624c6
PE
4895 * alloc.c: Catch some string size overflows that we were missing.
4896 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4897 for convenience in STRING_BYTES_MAX.
4898 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4899 The definition here is exact; the one in lisp.h was approximate.
4900 (allocate_string_data): Check for string overflow. This catches
4901 some instances we weren't catching before. Also, it catches
4902 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4903 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4904 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4905
c9d624c6
PE
4906 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4907 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4908 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4909
353032ce
PE
4910 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4911
2bccce07
PE
4912 * alloc.c (Fmake_string): Check for out-of-range init.
4913
0ac30604
SM
49142011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4915
4916 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4917
c195f2de
JD
49182011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4919
4920 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4921 xg_get_default_scrollbar_width.
4922
4923 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4924 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4925 (style_changed_cb): Call update_theme_scrollbar_width and call
4926 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4927 all frames (Bug#8505).
4928 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4929 Call gtk_window_set_resizable if HAVE_GTK3.
4930 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4931 and height if HAVE_GTK3 (Bug#8505).
4932 (scroll_bar_width_for_theme): New variable.
4933 (update_theme_scrollbar_width): New function.
4934 (xg_get_default_scrollbar_width): Move code to
4935 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4936 (xg_initialize): Call update_theme_scrollbar_width.
4937
4938 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4939
4940 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4941
e10ac9f1
MR
49422011-06-12 Martin Rudalics <rudalics@gmx.at>
4943
4944 * frame.c (make_frame): Call other_buffer_safely instead of
4945 other_buffer.
4946
4947 * window.c (temp_output_buffer_show): Call display_buffer with
4948 second argument Vtemp_buffer_show_specifiers and reset latter
4949 immediately after the call.
4950 (Vtemp_buffer_show_specifiers): New variable.
4951 (auto_window_vscroll_p, next_screen_context_lines)
4952 (Vscroll_preserve_screen_position): Remove leading asterisks from
4953 doc-strings.
4954
2d3c217e 49552011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4956
7b7f97e8 4957 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4958 * buffer.c (Qclone_number): Remove for now, as it's unused.
4959 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4960 (record_buffer): Remove unused local.
4961 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4962 (set_frame_buffer_list): Remove; unused.
4963 * frame.h (other_visible_frames): Remove decl.
4964 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4965 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4966 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4967 if HAVE_GPM.
4968 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4969 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4970 Define only if HAVE_GPM.
4971 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4972 (update_hints_inhibit): Remove; never set. All uses removed.
4973 * widgetprv.h (emacsFrameClassRec): Remove decl.
4974 * window.c (delete_deletable_window): Now returns void, since it
4975 wasn't returning anything.
4976 (compare_window_configurations): Remove unused locals.
4977 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4978 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4979 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4980 the same widths as pointers. This follows up on the 2011-05-06 patch.
4981 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4982 * xterm.h: Likewise.
4983 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4984
1384b89e
JB
49852011-06-12 Juanma Barranquero <lekktu@gmail.com>
4986
4987 * makefile.w32-in: Update dependencies.
4988 (LISP_H): Add lib/intprops.h.
4989
1100a63c
CY
49902011-06-11 Chong Yidong <cyd@stupidchicken.com>
4991
4992 * image.c (gif_load): Add animation frame delay to the metadata.
4993 (syms_of_image): Use DEFSYM. New symbol `delay'.
4994
6198ccd0
MR
49952011-06-11 Martin Rudalics <rudalics@gmx.at>
4996
4997 * window.c (delete_deletable_window): Re-add.
4998 (Fset_window_configuration): Rewrite to handle dead buffers and
4999 consequently deletable windows.
5000 (window_tree, Fwindow_tree): Remove. Supply functionality in
5001 window.el.
5002 (compare_window_configurations): Simplify code.
5003
b6e3633c
AS
50042011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5005
1ab0dee5
AS
5006 * image.c (imagemagick_load_image): Fix type mismatch.
5007 (Fimagemagick_types): Likewise.
5008
b6e3633c
AS
5009 * window.h (replace_buffer_in_windows): Declare.
5010
9397e56f
MR
50112011-06-11 Martin Rudalics <rudalics@gmx.at>
5012
5013 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5014 Qclone_number. Remove external declaration of Qdelete_window.
5015 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5016 code.
640c8776
SM
5017 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5018 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5019 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5020 buffer list implementation.
5021 (other_buffer_safely): New function.
5022 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5023 calls to replace_buffer_in_windows and
5024 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5025 if allowed.
5026 (record_buffer): Inhibit quitting and rewrite using quittable
5027 functions. Run Qbuffer_list_update_hook if allowed.
5028 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5029 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5030 Move switch-to-buffer to window.el.
9397e56f
MR
5031 (bury-buffer): Move to window.el.
5032 (Vbuffer_list_update_hook): New variable.
5033
5034 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5035 section.
5036
5037 * window.h (resize_frame_windows): Move up in code.
5038 (Fwindow_frame): Remove EXFUN.
5039 (replace_buffer_in_all_windows): Remove prototype.
5040 (replace_buffer_in_windows_safely): Add prototype.
5041
5042 * window.c: Declare Qdelete_window static again. Move down
5043 declaration of select_count.
5044 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5045 (Fother_window): Move to window.el.
5046 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5047 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5048 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5049 window.el.
5050 (replace_buffer_in_windows): Implement by calling
5051 Qreplace_buffer_in_windows.
5052 (replace_buffer_in_all_windows): Remove with some functionality
5053 moved into replace_buffer_in_windows_safely.
5054 (replace_buffer_in_windows_safely): New function.
5055 (select_window_norecord, select_frame_norecord): Move in front
5056 of run_window_configuration_change_hook. Remove now obsolete
5057 declarations.
640c8776
SM
5058 (Fset_window_buffer): Rewrite doc-string.
5059 Call Qrecord_window_buffer.
9397e56f
MR
5060 (keys_of_window): Move binding for other-window to window.el.
5061
b50691aa
CY
50622011-06-11 Chong Yidong <cyd@stupidchicken.com>
5063
5064 * dispextern.h (struct image): Replace data member, whose int_val
5065 and ptr_val fields were not used by anything, with a single
5066 lisp_val object.
5067
5068 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5069 (gif_clear_image, gif_load, imagemagick_load_image)
5070 (gs_clear_image, gs_load): Callers changed.
5071
3f754b86
PE
50722011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5073
cca69397
PE
5074 * buffer.h: Include <time.h>, for time_t.
5075 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5076
109e28d0
PE
5077 Fix minor problems found by static checking.
5078
60737f02
PE
5079 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5080
4b66faf3
PE
5081 Make identifiers static if they are not used in other modules.
5082 * data.c (Qcompiled_function, Qframe, Qvector):
5083 * image.c (QimageMagick, Qsvg):
5084 * minibuf.c (Qmetadata):
5085 * window.c (resize_window_check, resize_root_window): Now static.
5086 * window.h (resize_window_check, resize_root_window): Remove decls.
5087
109e28d0
PE
5088 * window.c (window_deletion_count, delete_deletable_window):
5089 Remove; unused.
46a4ce9e
PE
5090 (window_body_lines): Now static.
5091 (Fdelete_other_windows_internal): Mark vars as initialized.
5092 Make sure 'resize_failed' is initialized.
5093 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5094 (resize_window_apply): Remove unused local.
5095 * window.h (delete_deletable_window): Remove decl.
5096
109e28d0 5097 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5098 (imagemagick_load_image): Fix pointer signedness problem by changing
5099 last arg from unsigned char * to char *. All uses changed.
5100 Also, fix a local for similar reasons.
5101 Remove unused locals. Remove locals to avoid shadowing.
5102 (fn_rsvg_handle_free): Remove; unused.
5103 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5104 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5105
3f754b86
PE
5106 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5107
2547adb1
CY
51082011-06-10 Chong Yidong <cyd@stupidchicken.com>
5109
5110 * image.c (gif_load): Fix omitted cast error introduced by
5111 2011-06-06 change.
5112
2c8e37d4
MR
51132011-06-10 Martin Rudalics <rudalics@gmx.at>
5114
5115 * window.h (resize_proportionally, orig_total_lines)
5116 (orig_top_line): Remove from window structure.
5117 (set_window_height, set_window_width, change_window_heights)
5118 (Fdelete_window): Remove prototypes.
5119 (resize_frame_windows): Remove duplicate declaration.
5120
440a42e3
EZ
51212011-06-10 Eli Zaretskii <eliz@gnu.org>
5122
5123 * window.h (resize_frame_windows, resize_window_check)
5124 (delete_deletable_window, resize_root_window)
5125 (resize_frame_windows): Declare prototypes.
5126
5127 * window.c (resize_window_apply): Make definition be "static" to
5128 match the prototype.
5129
562dd5e9
MR
51302011-06-10 Martin Rudalics <rudalics@gmx.at>
5131
5132 * window.c: Remove declarations of Qwindow_size_fixed,
5133 window_min_size_1, window_min_size_2, window_min_size,
5134 size_window, window_fixed_size_p, enlarge_window, delete_window.
5135 Remove static from declaration of Qdelete_window, it's
5136 temporarily needed by Fbury_buffer.
5137 (replace_window): Don't assign orig_top_line and
5138 orig_total_lines.
5139 (Fdelete_window, delete_window): Remove. Window deletion is
5140 handled by window.el.
640c8776
SM
5141 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5142 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5143 (Fdelete_other_windows): Remove. Deleting other windows is
5144 handled by window.el.
5145 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5146 handled in window.el.
5147 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5148 Window minimum sizes are handled in window.el.
5149 (shrink_windows, size_window, set_window_height)
5150 (set_window_width, change_window_heights, window_height)
5151 (window_width, CURBEG, CURSIZE, enlarge_window)
5152 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5153 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5154 handled in window.el.
5155 (make_dummy_parent): Rename to make_parent_window and give it a
5156 second argument horflag.
5157 (make_window): Don't set resize_proportionally any more.
5158 (Fsplit_window): Remove. Windows are split in window.el.
5159 (save_restore_action, save_restore_orig_size)
5160 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5161 Resize mini windows in window.el.
5162 (grow_mini_window, shrink_mini_window): Implement by calling
5163 Qresize_root_window_vertically, resize_window_check and
5164 resize_window_apply.
640c8776
SM
5165 (saved_window, Fset_window_configuration, save_window_save):
5166 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5167 resize_proportionally.
5168 (window_min_height, window_min_width): Move to window.el.
5169 (keys_of_window): Move bindings for delete-other-windows,
5170 split-window, delete-window and enlarge-window to window.el.
5171
5172 * buffer.c: Temporarily extern Qdelete_window.
5173 (Fbury_buffer): Temporarily call Qdelete_window instead of
5174 Fdelete_window (Fbury_buffer will move to window.el soon).
5175
5176 * frame.c (set_menu_bar_lines_1): Remove code handling
5177 orig_top_line and orig_total_lines.
5178
5179 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5180 set_window_height but set heights directly.
5181 (change_frame_size_1): Use resize_frame_windows.
5182
5183 * xdisp.c (init_xdisp): Don't use set_window_height but set
5184 heights directly.
5185
640c8776
SM
5186 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5187 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5188 run_window_configuration_change_hook.
5189
5190 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5191 instead of change_window_heights and run
5192 run_window_configuration_change_hook.
5193
1a13852e
MR
51942011-06-09 Martin Rudalics <rudalics@gmx.at>
5195
5196 * window.c (replace_window): Rename second argument REPLACEMENT to
5197 NEW. New third argument SETFLAG. Rewrite.
5198 (delete_window, make_dummy_parent): Call replace_window with
5199 third argument 1.
5200 (window_list_1): Move down in code.
5201 (run_window_configuration_change_hook): Move set_buffer part
5202 before select_frame_norecord part in order to unwind correctly.
5203 Rename count1 to count.
5204 (recombine_windows, delete_deletable_window, resize_root_window)
5205 (Fdelete_other_windows_internal)
5206 (Frun_window_configuration_change_hook, make_parent_window)
5207 (resize_window_check, resize_window_apply, Fresize_window_apply)
5208 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5209 (Fdelete_window_internal, Fresize_mini_window_internal):
5210 New functions.
1a13852e
MR
5211 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5212
f3d1777e
MR
52132011-06-08 Martin Rudalics <rudalics@gmx.at>
5214
496e208e
MR
5215 * window.h (window): Add some new members to window structure -
5216 normal_lines, normal_cols, new_total, new_normal, clone_number,
5217 splits, nest, prev_buffers, next_buffers.
5218 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5219 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5220
f3d1777e
MR
5221 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5222 Remove.
496e208e
MR
5223 (make_dummy_parent): Set new members of windows structure.
5224 (make_window): Move down in code. Handle new members of window
5225 structure.
5226 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5227 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5228 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5229 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5230 (Fset_window_next_buffers, Fset_window_clone_number):
5231 New functions.
496e208e
MR
5232 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5233 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5234 Doc-string fixes.
5235 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5236 Argument WINDOW can be now internal window too.
5237 (Fwindow_use_time): Move up in code.
5238 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5239 Rewrite doc-string.
5240 (Fset_window_configuration, saved_window)
5241 (Fcurrent_window_configuration, save_window_save): Handle new
5242 members of window structure.
b9e809c2
MR
5243 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5244 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5245 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5246 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5247 Qget_mru_window, Qresize_root_window,
5248 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5249 Qauto_buffer_name; staticpro them.
f3d1777e 5250
abde8f8c
MR
52512011-06-07 Martin Rudalics <rudalics@gmx.at>
5252
5253 * window.c (Fwindow_total_size, Fwindow_left_column)
5254 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5255 (Fwindow_list_1): New functions.
5256 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5257 (Fwindow_width, Fscroll_left, Fscroll_right):
5258 Use window_body_cols instead of window_box_text_cols.
5259 (delete_window, Fset_window_configuration):
5260 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5261 (delete_all_subwindows): Take a window as argument and not a
5262 structure. Rewrite.
190b47e6
MR
5263 (window_loop): Remove handling of GET_LRU_WINDOW and
5264 GET_LARGEST_WINDOW.
5265 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5266
5267 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5268 window_box_text_cols. delete_all_subwindows now takes a
5269 Lisp_Object as argument.
abde8f8c 5270
640c8776
SM
5271 * indent.c (compute_motion, Fcompute_motion):
5272 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5273
fa8a67e6
MR
5274 * frame.c (delete_frame): Call delete_all_subwindows with root
5275 window as argument.
5276
a54e3482
DC
52772011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5278
5279 * fns.c (Fputhash): Document return value.
5280
60002bf5
CY
52812011-06-06 Chong Yidong <cyd@stupidchicken.com>
5282
5283 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5284
0c671da6 52852011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5286
b862a52a 5287 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5288
be44ca6c
PE
5289 Check for overflow when converting integer to cons and back.
5290 * charset.c (Fdefine_charset_internal, Fdecode_char):
5291 Use cons_to_unsigned to catch overflow.
5292 (Fencode_char): Use INTEGER_TO_CONS.
5293 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5294 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5295 * data.c (long_to_cons, cons_to_long): Remove.
5296 (cons_to_unsigned, cons_to_signed): New functions.
5297 These signal an error for invalid or out-of-range values.
5298 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5299 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5300 * font.c (Ffont_variation_glyphs):
5301 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5302 * lisp.h: Include <intprops.h>.
5303 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5304 (cons_to_signed, cons_to_unsigned): New decls.
5305 (long_to_cons, cons_to_long): Remove decls.
5306 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5307 (Fprimitive_undo): Use CONS_TO_INTEGER.
5308 * xfns.c (Fx_window_property): Likewise.
5309 * xselect.c: Include <limits.h>.
5310 (x_own_selection, selection_data_to_lisp_data):
5311 Use INTEGER_TO_CONS.
5312 (x_handle_selection_request, x_handle_selection_clear)
5313 (x_get_foreign_selection, Fx_disown_selection_internal)
5314 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5315 (lisp_data_to_selection_data): Use cons_to_unsigned.
5316 (x_fill_property_data): Use cons_to_signed.
5317 Report values out of range.
5318
d1f3d2af
PE
5319 Check for buffer and string overflow more precisely.
5320 * buffer.h (BUF_BYTES_MAX): New macro.
5321 * lisp.h (STRING_BYTES_MAX): New macro.
5322 * alloc.c (Fmake_string):
5323 * character.c (string_escape_byte8):
5324 * coding.c (coding_alloc_by_realloc):
5325 * doprnt.c (doprnt):
5326 * editfns.c (Fformat):
5327 * eval.c (verror):
5328 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5329 since they may not be the same number.
5330 * editfns.c (Finsert_char):
5331 * fileio.c (Finsert_file_contents):
5332 Likewise for BUF_BYTES_MAX.
5333
dd52fcea
PE
5334 * image.c: Use ptrdiff_t, not int, for sizes.
5335 (slurp_file): Switch from int to ptrdiff_t.
5336 All uses changed.
5337 (slurp_file): Check that file size fits in both size_t (for
5338 malloc) and ptrdiff_t (for sanity and safety).
5339
7f9bbdbb
PE
5340 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5341 if b->modtime has its maximal value.
5342
dfe18f82
PE
5343 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5344
84acfcf0
PE
5345 Don't assume time_t can fit into int.
5346 * buffer.h (struct buffer.modtime): Now time_t, not int.
5347 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5348 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5349
ccd9a01a
PE
5350 Minor fixes for signed vs unsigned integers.
5351 * character.h (MAYBE_UNIFY_CHAR):
5352 * charset.c (maybe_unify_char):
5353 * keyboard.c (read_char, reorder_modifiers):
5354 XINT -> XFASTINT, since the integer must be nonnegative.
5355 * ftfont.c (ftfont_spec_pattern):
5356 * keymap.c (access_keymap, silly_event_symbol_error):
5357 XUINT -> XFASTINT, since the integer must be nonnegative.
5358 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5359 since it makes no difference and we prefer signed.
5360 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5361 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5362 nonnegative.
5363
d6d100dd
SM
53642011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5365
5366 * window.h (Fwindow_frame): Declare.
5367
2b6148e4
PE
53682011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5369
5370 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5371 (SPARE_MEMORY): Always define.
5372 (LARGE_REQUEST): Remove.
5373 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5374
f230ecc9
MR
53752011-06-06 Martin Rudalics <rudalics@gmx.at>
5376
727e958e
MR
5377 * lisp.h: Move EXFUNS for Fframe_root_window,
5378 Fframe_first_window and Fset_frame_selected_window to window.h.
5379
5380 * window.h: Move EXFUNS for Fframe_root_window,
5381 Fframe_first_window and Fset_frame_selected_window here from
5382 lisp.h.
5383
5384 * frame.c (Fwindow_frame, Fframe_first_window)
5385 (Fframe_root_window, Fframe_selected_window)
5386 (Fset_frame_selected_window): Move to window.c.
5387 (Factive_minibuffer_window): Move to minibuf.c.
5388 (Fother_visible_frames_p): New function.
5389
5390 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5391
f230ecc9
MR
5392 * window.c (decode_window, decode_any_window): Move up in code.
5393 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5394 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5395 (Fwindow_buffer): Move up and rewrite doc-string.
5396 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5397 (Fwindow_prev): New functions.
727e958e
MR
5398 (Fwindow_frame): Move here from frame.c. Accept any window as
5399 argument.
5400 (Fframe_root_window, Fframe_first_window)
5401 (Fframe_selected_window): Move here from frame.c. Accept frame
5402 or arbitrary window as argument. Update doc-strings.
5403 (Fminibuffer_window): Move up in code.
5404 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5405 (Fset_frame_selected_window): Move here from frame.c.
5406 Marginal rewrite.
727e958e
MR
5407 (Fselected_window, select_window, Fselect_window): Move up in
5408 code. Minor doc-string fixes.
f230ecc9 5409
4d09bcf6
PE
54102011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5411
5412 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5413 Do not assume that spare memory exists; that assumption is valid
5414 only if SYSTEM_MALLOC.
5415 (LARGE_REQUEST): New macro, so that the issue of large requests
5416 is separated from the issue of spare memory.
5417
810928a2
AS
54182011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5419
172418ad
AS
5420 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5421 format. (Bug#8806)
5422
43f862f7
AS
5423 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5424
810928a2
AS
5425 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5426 before statements.
5427
a059fe24
JD
54282011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5429
5430 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5431
5432 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5433
5434 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5435 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5436
989bf368
JB
54372011-06-05 Juanma Barranquero <lekktu@gmail.com>
5438
5439 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5440
4b80f674
CY
54412011-06-04 Chong Yidong <cyd@stupidchicken.com>
5442
5443 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5444 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5445 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5446 New error handlers.
4b80f674
CY
5447 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5448 Obey Vx_select_enable_clipboard_manager. Catch errors in
5449 x_clipboard_manager_save (Bug#8779).
5450 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5451 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5452
99a33b77 54532011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5454
5455 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5456
99a33b77 54572011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5458
5459 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5460 in the current matrix if keep_current_p is non-zero.
5461
8264569d
EZ
54622011-06-04 Eli Zaretskii <eliz@gnu.org>
5463
5464 * bidi.c (bidi_level_of_next_char): Fix last change.
5465
57f97249
EZ
54662011-06-03 Eli Zaretskii <eliz@gnu.org>
5467
fec2107c 5468 Support bidi reordering of text covered by display properties.
57f97249 5469
fec2107c
EZ
5470 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5471 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5472 (bidi_cache_search, bidi_cache_iterator_state)
5473 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5474 (bidi_level_of_next_char, bidi_move_to_visually_next):
5475 Support character positions inside a run of characters covered by a
fec2107c
EZ
5476 display string.
5477 (bidi_paragraph_init, bidi_resolve_explicit_1)
5478 (bidi_level_of_next_char): Call bidi_fetch_char and
5479 bidi_fetch_char_advance instead of FETCH_CHAR and
5480 FETCH_CHAR_ADVANCE.
5481 (bidi_init_it): Initialize new members.
5482 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5483 definitions.
5484 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5485 instead of using explicit *_CHAR codes.
d6d100dd
SM
5486 (bidi_resolve_explicit, bidi_resolve_weak):
5487 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5488 bidirectional text is supported only in multibyte buffers.
5489 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5490 it to initialize the frame_window_p member of struct bidi_it.
5491 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5492 (bidi_resolve_explicit, bidi_resolve_weak)
5493 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5494 bidi_it->nchars is non-positive.
5495 (bidi_level_of_next_char): Don't try to lookup the cache for the
5496 next/previous character if nothing is cached there yet, or if we
5497 were just reseat()'ed to a new position.
c40e2fb2 5498
0e14fe90
EZ
5499 * xdisp.c (set_cursor_from_row): Set start and stop points
5500 according to the row's direction when priming the loop that looks
5501 for the glyph on which to display cursor.
5502 (single_display_spec_intangible_p): Function deleted.
5503 (display_prop_intangible_p): Reimplement to call
5504 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5505 Accept 3 additional arguments needed by handle_display_spec.
5506 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5507 values: lists, `(when COND...)' forms, etc.
5508 (single_display_spec_string_p): Support property values that are
5509 lists with the argument STRING its top-level element.
5510 (display_prop_string_p): Fix the condition for processing a
5511 property that is a list to be consistent with handle_display_spec.
fec2107c 5512 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5513 last portion of handle_display_prop.
5514 (compute_display_string_pos): Accept additional argument
5515 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5516 value of a `display' property is a "replacing spec".
5517 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5518 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5519 the display property, but just return a value indicating whether
5520 the display property will replace the characters it covers.
5521 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5522 frame_window_p members of struct bidi_it.
d6d100dd
SM
5523 (compute_display_string_pos, compute_display_string_end):
5524 New functions.
fec2107c
EZ
5525 (push_it): Accept second argument POSITION, where pop_it should
5526 jump to continue iteration.
5527 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5528
fec2107c
EZ
5529 * keyboard.c (adjust_point_for_property): Adjust the call to
5530 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5531
5532 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5533 (bidi_init_it): Update prototypes.
5534 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5535 (compute_display_string_pos, compute_display_string_end):
5536 Declare prototypes.
fec2107c
EZ
5537 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5538 EMACS_INT.
fc6f18ce 5539
40087514 55402011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5541
57f53182
PE
5542 Malloc failure behavior now depends on size of allocation.
5543 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5544 * lisp.h: Change signatures accordingly.
5545 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5546 All callers changed. (Bug#8762)
5547
5548 * gnutls.c: Use Emacs's memory allocators.
5549 Without this change, the gnutls library would invoke malloc etc.
5550 directly, which causes problems on non-SYNC_INPUT hosts, and which
5551 runs afoul of improving memory_full behavior. (Bug#8761)
5552 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5553 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5554 xfree instead of the default malloc, realloc, free.
5555 (Fgnutls_boot): No need to check for memory allocation failure,
5556 since xmalloc does that for us.
5557
ac32cd99 5558 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5559 * category.c (hash_get_category_set):
5560 * ccl.c (ccl_driver):
5561 * charset.c (Fdefine_charset_internal):
5562 * charset.h (struct charset.hash_index):
5563 * composite.c (get_composition_id, gstring_lookup_cache)
5564 (composition_gstring_put_cache):
5565 * composite.h (struct composition.hash_index):
5566 * dispextern.h (struct image.hash):
5567 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5568 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5569 (hashfn_equal, hashfn_user_defined, make_hash_table)
5570 (maybe_resize_hash_table, hash_lookup, hash_put)
5571 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5572 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5573 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5574 * image.c (make_image, search_image_cache, lookup_image)
5575 (xpm_put_color_table_h):
5576 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5577 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5578 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5579 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5580 * alloc.c (allocate_vectorlike):
5581 Check for overflow in vector size calculations.
5582 * ccl.c (ccl_driver):
5583 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5584 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5585 need to be updated by these changes.
40087514
PE
5586 * fns.c (make_hash_table, maybe_resize_hash_table):
5587 Check for integer overflow with large hash tables.
0de4bb68
PE
5588 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5589 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5590 (SXHASH_REDUCE): New macro.
5591 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5592 Use it instead of discarding useful hash info with large hash values.
5593 (sxhash_float): New function.
5594 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5595 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5596 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5597 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5598 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5599 Adjust signatures to match updated version of code.
5600 (consing_since_gc): Now EMACS_INT, since a single hash table can
5601 use more than INT_MAX bytes.
5602
698d32e2
DN
56032011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5604
5605 Make it possible to build with GCC-4.6+ -O2 -flto.
5606
5607 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5608
fd6fa53f
SM
56092011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5610
5611 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5612 Call minibuffer-inactive-mode.
5613
864db017
JB
56142011-05-31 Juanma Barranquero <lekktu@gmail.com>
5615
5616 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5617 Update dependencies.
5618
2ad0baf4
DN
56192011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5620
5621 * data.c (init_data): Remove code for UTS, this system is not
5622 supported anymore.
5623
4fcc2638
DN
56242011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5625
5626 Don't force ./temacs to start in terminal mode.
5627
5628 * frame.c (make_initial_frame): Initialize faces in all cases, not
5629 only when CANNOT_DUMP is defined.
5630 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5631
c56e0fd5
DN
56322011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5633
5634 * dispnew.c (add_window_display_history): Use const for the string
5635 pointer. Remove declaration, not needed.
5636
333d54da 56372011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5638
55d4c1b2 5639 Use 'inline', not 'INLINE'.
333d54da 5640 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5641 * alloc.c, fontset.c (INLINE): Remove.
5642 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5643 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5644 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5645 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5646 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5647
738db178
DN
56482011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5649
5650 Make it possible to run ./temacs.
5651
5652 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5653 syms_of_callproc does the same thing. Remove test for
5654 "initialized", do it in the caller.
5655 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5656
620c53a6
SM
56572011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5658
5659 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5660 (read_minibuf): Use get_minibuffer.
5661 (syms_of_minibuf): Use DEFSYM.
5662 (Qmetadata): New var.
5663 * data.c (Qbuffer): Don't make it static.
5664 (syms_of_data): Use DEFSYM.
5665
e003a292
PE
56662011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5667
5668 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5669 (CCL_CODE_MIN): New macro.
5670
ed008a6d
PE
56712011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5672
3687c2ef
PE
5673 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5674
ed008a6d
PE
5675 * eval.c (Qdebug): Now static.
5676 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5677 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5678 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5679
d66c4c7c
CY
56802011-05-29 Chong Yidong <cyd@stupidchicken.com>
5681
5682 * image.c: Various fixes to ImageMagick code comments.
5683 (Fimagemagick_types): Doc fix.
5684
5fbc2025
PE
56852011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5686
0196f88a
PE
5687 Minor fixes prompted by GCC 4.6.0 warnings.
5688
5689 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5690
5fbc2025
PE
5691 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5692 (x_clipboard_manager_save_all): Move extern decl to ...
5693 * xterm.h: ... here, so that it can be checked for consistency.
5694
1dd3c2d9
CY
56952011-05-29 Chong Yidong <cyd@stupidchicken.com>
5696
5697 * xselect.c (x_clipboard_manager_save_frame)
5698 (x_clipboard_manager_save_all): New functions.
5699 (Fx_clipboard_manager_save): Lisp function deleted.
5700
5701 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5702 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5703
5704 * xterm.h: Update prototype.
5705
5ba6571d
WX
57062011-05-28 William Xu <william.xwl@gmail.com>
5707
5708 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5709 exiting (Bug#8239).
5710
3eaff834
JM
57112011-05-28 Jim Meyering <meyering@redhat.com>
5712
e1900994 5713 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5714 * fns.c (to_uchar): Define.
5715 (crypto_hash_function): Use it to convert some newly-signed
5716 variables to unsigned, to avoid sign-extension bugs. For example,
5717 without this change, (md5 "truc") would evaluate to
5718 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5719 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5720 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5721
0f6990a7
PE
57222011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5723
5724 Integer overflow fixes.
c8a9ca5a 5725
08686060
PE
5726 * dbusbind.c: Serial number integer overflow fixes.
5727 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5728 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5729 to hold a serial number that is too large for a fixnum.
5730 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5731 Check for serial numbers out of range. Decode any serial number
59568bf0 5732 that was so large that it became a float. (Bug#8722)
08686060 5733
2d1fc3c7
PE
5734 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5735 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5736 Use XFASTINT rather than XUINT when numbers are nonnegative.
5737 (xd_append_arg, Fdbus_method_return_internal):
5738 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5739 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5740 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5741 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5742 (Bug#8722)
2d1fc3c7 5743
c8a9ca5a
PE
5744 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5745
519e1d69
PE
5746 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5747
6df6ae42 5748 ccl: Add integer overflow checks.
30569699
PE
5749 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5750 (IN_INT_RANGE): New macros.
5751 (ccl_driver): Use them to check for integer overflow when
5752 decoding a CCL program. Many of the new checks are whether XINT (x)
5753 fits in int; it doesn't always, on 64-bit hosts. The new version
5754 doesn't catch all possible integer overflows, but it's an
847044ea 5755 improvement. (Bug#8719)
30569699 5756
c11285dc
PE
5757 * alloc.c (make_event_array): Use XINT, not XUINT.
5758 There's no need for unsigned here.
5759
fdccd48e
PE
5760 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5761 This follows up to the 2011-05-06 change that substituted uintptr_t
5762 for EMACS_INT. This case wasn't caught back then.
5763
37910ab2
PE
5764 Rework Fformat to avoid integer overflow issues.
5765 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5766 now (part of C89). Include <verify.h>.
5767 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5768 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5769 (Fformat): Avoid the prepass trying to compute sizes; it was only
5770 approximate and thus did not catch overflow reliably. Instead, walk
5771 through the format just once, formatting and computing sizes as we go,
5772 checking for integer overflow at every step, and allocating a larger
5773 buffer as needed. Keep track separately whether the format is
5774 multibyte. Keep only the most-recently calculated precision, rather
5775 than them all. Record whether each argument has been converted to
5776 string. Use EMACS_INT, not int, for byte and char and arg counts.
5777 Support field widths and precisions larger than INT_MAX. Avoid
5778 sprintf's undefined behavior with conversion specifications such as %#d
5779 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5780 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5781 formatting out-of-range floating point numbers with int
9173deec 5782 formats. (Bug#8668)
37910ab2 5783
2e6578fb
PE
5784 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5785
0ae6bdee
PE
5786 * data.c: Avoid integer truncation in expressions involving floats.
5787 * data.c: Include <intprops.h>.
5788 (arith_driver): When there's an integer overflow in an expression
5789 involving floating point, convert the integers to floating point
5790 so that the resulting value does not suffer from catastrophic
5791 integer truncation. For example, on a 64-bit host (* 4
5792 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5793 Do not rely on undefined behavior after integer overflow.
5794
de883a70
PE
5795 merge count_size_as_multibyte, parse_str_to_multibyte
5796 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5797 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5798 Check for integer overflow.
5799 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5800 since it's now a duplicate of the other. This is more of
5801 a character than a buffer op, so better that it's in character.c.
5802 * fns.c, print.c: Adjust to above changes.
5803
2ff916cb
PE
58042011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5805
5806 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5807
f1b54466
PE
58082011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5809
fb1ac845
PE
5810 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5811 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5812 (x_clipboard_manager_save): Now static.
5813 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5814
f1b54466
PE
5815 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5816 (crypto_hash_function): Now static.
5817 Fix pointer signedness problems. Avoid unnecessary initializations.
5818
a9f737ee
CY
58192011-05-27 Chong Yidong <cyd@stupidchicken.com>
5820
5821 * termhooks.h (Vselection_alist): Make it terminal-local.
5822
5823 * terminal.c (create_terminal): Initialize it.
5824
5825 * xselect.c: Support for clipboard managers.
5826 (Vselection_alist): Move to termhooks.h as terminal-local var.
5827 (LOCAL_SELECTION): New macro.
5828 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5829 (symbol_to_x_atom): Remove gratuitous arg.
5830 (x_handle_selection_request, lisp_data_to_selection_data)
5831 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5832 (x_own_selection, x_get_local_selection, x_convert_selection):
5833 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5834 (some_frame_on_display): Delete unused function.
5835 (Fx_own_selection_internal, Fx_get_selection_internal)
5836 (Fx_disown_selection_internal, Fx_selection_owner_p)
5837 (Fx_selection_exists_p): New optional frame arg.
5838 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5839 (x_handle_selection_clear): Don't treat other terminals with the
5840 same keyboard specially. Use the terminal-local Vselection_alist.
5841 (x_clear_frame_selections): Use Frun_hook_with_args.
5842
5843 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5844
5845 * xterm.h: Add support for those atoms.
5846
e067f0c1
CY
58472011-05-26 Chong Yidong <cyd@stupidchicken.com>
5848
5849 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5850 (converted_selections, conversion_fail_tag): New global variables.
5851 (x_selection_request_lisp_error): Free the above.
5852 (x_get_local_selection): Remove unnecessary code.
5853 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5854 of converted selections stored in converted_selections.
5855 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5856 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5857 (x_convert_selection): New function.
5858 (x_handle_selection_event): Simplify.
5859 (x_get_foreign_selection): Don't ignore incoming requests while
5860 waiting for an answer; this will fail when we implement
5861 SAVE_TARGETS, and seems unnecessary anyway.
5862 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5863 (Vx_sent_selection_functions): Doc fix.
5864
0f4aebc0
LL
58652011-05-26 Leo Liu <sdl.web@gmail.com>
5866
5867 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5868
e61124cd
YM
58692011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5870
5871 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5872
5873 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5874 for fringe update if it has periodic bitmap.
ac389d0c 5875 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5876 and fringe_bitmap_periodic_p.
5877
5878 * fringe.c (get_fringe_bitmap_data): New function.
5879 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5880 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5881 row. Mark glyph row for fringe update if periodicity changed.
5882
5883 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5884 for fringe update unless it has periodic bitmap.
5885
f16d9837
KH
58862011-05-25 Kenichi Handa <handa@m17n.org>
5887
5888 * xdisp.c (get_next_display_element): Set correct it->face_id for
5889 a static composition.
5890
e1b90ef6
LL
58912011-05-24 Leo Liu <sdl.web@gmail.com>
5892
5893 * deps.mk (fns.o):
5894 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5895
5896 * fns.c (crypto_hash_function, Fsha1): New function.
5897 (Fmd5): Use crypto_hash_function.
5898 (syms_of_fns): Add Ssha1.
5899
7400048f
PE
59002011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5901
5902 * gnutls.c: Remove unused macros.
5903 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5904 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5905 Remove macros that are defined and never used.
5906 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5907
abb71cf4
CY
59082011-05-22 Chong Yidong <cyd@stupidchicken.com>
5909
5910 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5911 (Fx_get_selection_internal): Minor cleanup.
5912 (Fx_own_selection_internal): Rename arguments for consistency with
5913 select.el.
5914
6307db39
PE
59152011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5916
5917 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5918
f3d4e0a4
CY
59192011-05-22 Chong Yidong <cyd@stupidchicken.com>
5920
5921 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5922
4d8ade89
YM
59232011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5924
5925 * dispnew.c (scrolling_window): Don't exclude the case that the
5926 last enabled row in the desired matrix touches the bottom boundary.
5927
32078c8d
GM
59282011-05-21 Glenn Morris <rgm@gnu.org>
5929
5930 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5931 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5932 and add some more files.
32078c8d 5933
7285dc67
EZ
59342011-05-20 Eli Zaretskii <eliz@gnu.org>
5935
5936 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5937 report_file_error introduced by the change from 2011-05-07.
5938
89d1bd22
PE
59392011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5940
5941 * systime.h (Time): Define only if emacs is defined.
5942 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5943 where the include path doesn't have X11/X.h by default. See
5944 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5945
cd394be1 59462011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5947
5948 * composite.c (find_automatic_composition): Fix previous change.
5949
b9704ad9
GM
59502011-05-20 Glenn Morris <rgm@gnu.org>
5951
5952 * lisp.mk: New file, split from Makefile.in.
5953 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5954 (shortlisp): Remove.
5955 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5956
4a720484
GM
59572011-05-19 Glenn Morris <rgm@gnu.org>
5958
5959 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5960 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5961 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5962 (lisp): Set the order to that of loadup.el.
5963 (shortlisp): Make it a copy of $lisp.
5964 (SOME_MACHINE_LISP): Remove.
5965 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5966 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5967
a28d4396
KH
59682011-05-18 Kenichi Handa <handa@m17n.org>
5969
5970 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5971 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5972 (find_automatic_composition): Mostly rewrite for efficiency.
5973
a2b1fa8e
JB
59742011-05-18 Juanma Barranquero <lekktu@gmail.com>
5975
5976 * makefile.w32-in: Update dependencies.
5977
8e1f5610
CS
59782011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5979
5980 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5981 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5982
7025ee00 59832011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5984
cdfa6eab
PE
5985 Fix some integer overflow issues, such as string length overflow.
5986
06d6db33
PE
5987 * insdel.c (count_size_as_multibyte): Check for string overflow.
5988
2b4560a8
PE
5989 * character.c (lisp_string_width): Check for string overflow.
5990 Use EMACS_INT, not int, for string indexes and lengths; in
5991 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5992 the resulting string length overflows an EMACS_INT; instead,
5993 report a string overflow if no precision given. When checking for
5994 precision exhaustion, use a check that cannot possibly have
5995 integer overflow. (Bug#8675)
5996 * character.h (lisp_string_width): Adjust to new signature.
5997
cb93f9be
PE
5998 * alloc.c (string_overflow): New function.
5999 (Fmake_string): Use it. This doesn't change behavior, but saves
6000 a few bytes and will simplify future changes.
6001 * character.c (string_escape_byte8): Likewise.
6002 * lisp.h (string_overflow): New decl.
6003
1a1f3366
PE
6004 Fixups, following up to the user-interface timestamp change.
6005 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6006 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6007 * msdos.c (mouse_get_pos): Likewise.
6008 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6009 * w32gui.h (Time): Define by including "systime.h" rather than by
6010 declaring it ourselves. (Bug#8664)
6011
d4e3e4d3
PE
6012 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6013 * image.c (clear_image_cache): Likewise.
6014
f6a24d19
PE
6015 * term.c (term_mouse_position): Don't assume time_t wraparound.
6016
08dc5ae6
PE
6017 Be more systematic about user-interface timestamps.
6018 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6019 and sometimes 'EMACS_UINT', to represent these timestamps.
6020 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6021 This makes the code easier to follow, and makes it easier to catch
6022 integer overflow bugs such as Bug#8664.
6023 * frame.c (Fmouse_position, Fmouse_pixel_position):
6024 Use Time, not unsigned long, for user-interface timestamps.
6025 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6026 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6027 * keyboard.h (last_event_timestamp): Likewise.
6028 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6029 * menu.h (xmenu_show): Likewise.
6030 * term.c (term_mouse_position): Likewise.
6031 * termhooks.h (struct input_event.timestamp): Likewise.
6032 (struct terminal.mouse_position_hook): Likewise.
6033 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6034 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6035 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6036 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6037 what it was before.
6038 * menu.h, termhooks.h: Include "systime.h", for Time.
6039
8e55734a
PE
6040 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6041 Don't assume that the difference between two unsigned long values
6042 can fit into an integer. At this point, we know button_down_time
6043 <= event->timestamp, so the difference must be nonnegative, so
6044 there's no need to cast the result if double-click-time is
6045 nonnegative, as it should be; check that it's nonnegative, just in
6046 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6047 apart (about 25 days). (Bug#8664)
8e55734a 6048
841f1b75 6049 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6050 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6051
3e26f69c
PE
6052 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6053 that always fit in int. Use a sentinel instead of a counter, to
6054 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6055 * frame.h (struct frame): Use int for menu_bar_items_used
6056 instead of EMACS_INT, since it always fits in int.
3e26f69c 6057
5cc152c0
PE
6058 * menu.c (grow_menu_items): Check for int overflow.
6059
d89eb65e
PE
6060 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6061
5235bd3e
PE
6062 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6063 Before, the code was not consistent. These values cannot exceed
6064 2**31 - 1 so there's no need to make them unsigned.
6065 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6066 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6067 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6068 as modifiers.
6069 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6070
bc827e23
PE
6071 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6072 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6073 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6074 presumably because the widths might not match.
6075
78eb494e
PE
6076 * window.c (size_window): Avoid needless test at loop start.
6077
04f2d78b
CB
60782011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6079
6080 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6081
d2fc7e3d 60822011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6083
6084 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6085
d2fc7e3d 60862011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6087
6088 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6089 `width' to `bar_area_x' and `bar_area_width', respectively.
6090 (x_scroll_run): Take account of fringe background extension.
6091
04f2d78b
CB
6092 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6093 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6094 `bar_area_width', respectively.
6095 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6096 background extension.
6097
79b70037
GM
60982011-05-10 Jim Meyering <meyering@redhat.com>
6099
6100 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6101
2f142cc5
JB
61022011-05-10 Juanma Barranquero <lekktu@gmail.com>
6103
6104 * image.c (Finit_image_library): Return t for built-in image types,
6105 like pbm and xbm. (Bug#8640)
6106
57679c86
AS
61072011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6108
6109 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6110
888c9e86
EZ
61112011-05-07 Eli Zaretskii <eliz@gnu.org>
6112
b0512a1d
EZ
6113 * w32console.c (Fset_screen_color): Doc fix.
6114 (Fget_screen_color): New function.
6115 (syms_of_ntterm): Defsubr it.
6116
7285dc67
EZ
6117 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6118 unlink the temporary file if Fcall_process didn't create it in the
6119 first place.
6120 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6121 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6122 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6123 cue to call_process_cleanup not to close that handle.
6124
4d3fcc8e
BK
61252011-05-07 Ben Key <bkey76@gmail.com>
6126
6127 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6128 one of two shell specific rules, either bootstrap-temacs-CMD or
6129 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6130 to the previous implementation of the bootstrap-temacs rule.
6131 The bootstrap-temacs-CMD rule is similar to the previous
6132 implementation of the bootstrap-temacs rule except that it
6133 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6134 variable.
6135
6136 These changes, along with some changes to nt/configure.bat,
6137 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6138 earlier fix to add support for --cflags and --ldflags options
6139 that include quotes so that it works whether make uses cmd or
6140 sh as the shell.
6141
b4289b64
MA
61422011-05-06 Michael Albinus <michael.albinus@gmx.de>
6143
6144 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6145 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6146 is a constant.
6147 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6148 a string. Handle both cases.
6149 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6150 (Fdbus_register_method): Use Qinvalid_function.
6151
af4c0e28
JB
61522011-05-06 Juanma Barranquero <lekktu@gmail.com>
6153
6154 * makefile.w32-in: Update dependencies.
6155 (LISP_H): Add inttypes.h and stdin.h.
6156 (PROCESS_H): Add unistd.h.
6157
c51453d9
EZ
61582011-05-06 Eli Zaretskii <eliz@gnu.org>
6159
6160 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6161 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6162
8ff0ac3c 61632011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6164
4c4b566b
PE
6165 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6166
aab2b9b5
PE
6167 * term.c (vfatal): Remove stray call to va_end.
6168 It's not needed and the C Standard doesn't allow it here anyway.
6169
c378da0b
PE
6170 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6171 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6172
288b08c7
PE
6173 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6174 bytes.
6175
e3601888
PE
6176 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6177
db6c0e74
PE
6178 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6179
dd5963ea
PE
6180 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6181
88c9450f
PE
6182 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6183
2f9442b8
PE
6184 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6185
c032b5f8
PE
6186 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6187 * charset.c (Fdefine_charset_internal): Don't initialize
6188 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6189 32-bit int (Bug#8600).
a108c10b
PE
6190
6191 * lread.c (read_integer): Be more consistent with string-to-number.
6192 Use string_to_number to do the actual conversion; this avoids
6193 rounding errors and fixes some other screwups. Without this fix,
6194 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6195 (digit_to_number): Move earlier, for benefit of read_integer.
6196 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6197 not a digit in any supported base. (Bug#8602)
a108c10b 6198
ad5f9eea
PE
6199 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6200
aec1708a
PE
6201 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6202 to match comment at start of function. This also removes a
6203 GCC warning about overflow in a 32+64-bit port.
6204
47be4ab5
PE
6205 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6206
371cac43
PE
6207 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6208 Reported by Stefan Monnier in
6209 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6210 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6211 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6212
d01a7826
PE
6213 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6214 (EMACS_UINTPTR): Likewise, with uintptr_t.
6215
7fd47d5c
PE
6216 * lisp.h: Prefer 64-bit EMACS_INT if available.
6217 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6218 on 32-bit hosts that have 64-bit int, so that they can access
6219 large files.
122b0c86
PE
6220 However, temporarily disable this change unless the temporary
6221 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6222
8727937b
PE
6223 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6224
8ac068ac
PE
6225 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6226 This removes an assumption that EMACS_INT and long are the same
6227 width as pointers. The assumption is true for Emacs porting targets
6228 now, but we want to make other targets possible.
6229 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6230 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6231 In the rest of the code, change types of integers that hold casted
6232 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6233 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6234 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6235 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6236 No need to cast type when ORing.
6237 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6238 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6239 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6240 assume EMACS_INT is the same width as char *.
6241 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6242 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6243 Remove no-longer-needed casts.
6244 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6245 (xg_tool_bar_help_callback, xg_make_tool_item):
6246 Use EMACS_INTPTR to hold an integer
6247 that will be cast to void *; this can avoid a GCC warning
6248 if EMACS_INT is not the same width as void *.
6249 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6250 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6251 (current_message_1, set_message_1):
6252 Use a local to convert to proper width without a cast.
6253 * xmenu.c (dialog_selection_callback): Likewise.
6254
ede49d71
PE
6255 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6256 Also, don't assume VALBITS / RAND_BITS is less than 5,
6257 and don't rely on undefined behavior when shifting a 1 left into
6258 the sign bit.
6259 * lisp.h (get_random): Change signature to match.
6260
2f30ecd0
PE
6261 * lread.c (hash_string): Use size_t, not int, for hash computation.
6262 Normally we prefer signed values; but hashing is special, because
6263 it's better to use unsigned division on hash table sizes so that
6264 the remainder is nonnegative. Also, size_t is the natural width
6265 for hashing into memory. The previous code used 'int', which doesn't
6266 retain enough info to hash well into very large tables.
6267 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6268
2a866e7b
PE
6269 * dbusbind.c: Don't possibly lose pointer info when converting.
6270 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6271 Use XPNTR rather than XHASH, so that the high-order bits of
6272 the pointer aren't lost when converting through void *.
6273
51639eac
PE
6274 * eval.c (Fautoload): Don't double-shift a pointer.
6275
92394119
PE
6276 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6277
dbdb9a7c
JB
62782011-05-06 Juanma Barranquero <lekktu@gmail.com>
6279
6280 * gnutls.c (DEF_GNUTLS_FN):
6281 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6282
db7a0b4f
AS
62832011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6284
6285 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6286 marker. (Bug#8610)
6287
cd394be1 62882011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6289
6290 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6291 New version that can reserve upto 2GB of heap space.
6292
f7ff1b0f 62932011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6294
6295 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6296
639c109b
TZ
62972011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6298
6299 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6300 `gnutls_certificate_set_x509_key_file'.
6301
d2127135
JB
63022011-05-05 Juanma Barranquero <lekktu@gmail.com>
6303
6304 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6305 Update dependencies.
6306
e968f4f3
JB
63072011-05-04 Juanma Barranquero <lekktu@gmail.com>
6308
6309 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6310 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6311 Remove unused parameter `fildes'.
6312 * process.c (read_process_output, send_process): Don't pass it.
6313
84d358f0
JB
63142011-05-04 Juanma Barranquero <lekktu@gmail.com>
6315
6316 Fix previous change: the library cache is defined in w32.c.
6317 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6318 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6319
0898ca10
JB
63202011-05-04 Juanma Barranquero <lekktu@gmail.com>
6321
6322 Implement dynamic loading of GnuTLS on Windows.
6323
6324 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6325 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6326 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6327 Declare.
6328
6329 * gnutls.c (Qgnutls_dll): Define.
6330 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6331 (gnutls_*): Declare function pointers.
6332 (init_gnutls_functions): New function to initialize function pointers.
6333 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6334 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6335 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6336 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6337 (emacs_gnutls_write, emacs_gnutls_read)
6338 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6339 (Fgnutls_available_p): New function.
6340 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6341 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6342 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6343
6344 * image.c: Include w32.h.
6345 (Vimage_type_cache): Delete.
6346 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6347 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6348 (w32_delayed_load): Move to w32.c.
6349
6350 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6351
6352 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6353 (w32_delayed_load): Move from image.c. When loading a library, record
6354 its filename in the :loaded-from property of the library id.
6355 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6356 Initialize and staticpro them.
6357 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6358
6359 * process.c: Include lisp.h before w32.h, not after.
6360 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6361 instead of gnutls_record_check_pending.
6362
6363 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6364
ff4de4aa
TZ
63652011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6366
6367 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6368 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6369 as passed in.
6370
abe95abb
JD
63712011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6372
6373 * xterm.c (x_set_frame_alpha): Do not set property on anything
6374 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6375
e16e55d4
JB
63762011-05-02 Juanma Barranquero <lekktu@gmail.com>
6377
6378 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6379
bafcf6a5
JB
63802011-05-02 Juanma Barranquero <lekktu@gmail.com>
6381
6382 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6383 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6384 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6385 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6386 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6387 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6388 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6389 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6390 (Qgnutls_bootprop_callbacks_verify): Make static.
6391
e7a6747f
AS
63922011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6393
19ed11ba
AS
6394 * callproc.c: Indentation fixup.
6395
e7a6747f 6396 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6397 (wait_for_termination, interruptible_wait_for_termination):
6398 Move after wait_for_termination_1.
e7a6747f 6399
1ef14cb4
LMI
64002011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6401
6402 * sysdep.c (interruptible_wait_for_termination): New function
6403 which is like wait_for_termination, but allows keyboard
6404 interruptions.
6405
6406 * callproc.c (Fcall_process): Add (:file "file") as an option for
6407 the STDOUT buffer.
6408 (Fcall_process_region): Ditto.
6409
330d880c
EZ
64102011-04-30 Eli Zaretskii <eliz@gnu.org>
6411
8db90b73
EZ
6412 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6413 rather than `XVECTOR (FOO)->size'.
6414
330d880c
EZ
6415 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6416 inttypes.h, as a gnulib replacement is used if it not available in
6417 system headers.
6418
15cbd324
EZ
64192011-04-21 Eli Zaretskii <eliz@gnu.org>
6420
6421 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6422 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6423 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6424
6425 * coding.c (coding_alloc_by_realloc): Error out if destination
6426 will grow beyond MOST_POSITIVE_FIXNUM.
6427 (decode_coding_emacs_mule): Abort if there isn't enough place in
6428 charbuf for the composition carryover bytes. Reserve an extra
6429 space for up to 2 characters produced in a loop.
6430 (decode_coding_iso_2022): Abort if there isn't enough place in
6431 charbuf for the composition carryover bytes.
6432
64332011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6434
ae940cca
EZ
6435 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6436 aborting when %lld or %lll format is passed.
6437 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6438 %llo or %llx format is passed. (Bug#8545)
6439
03ab8921
EZ
6440 * window.c (window_scroll_line_based): Use a marker instead of
6441 simple variables to record original value of point. (Bug#7952)
6442
afda1437
EZ
6443 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6444 produced by %s or %c overflows available buffer space. (Bug#8545)
6445
f76dee0c
PE
64462011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6447
6448 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6449 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6450
fdc5744d
JB
64512011-04-28 Juanma Barranquero <lekktu@gmail.com>
6452
6453 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6454
638f053a
JB
64552011-04-28 Juanma Barranquero <lekktu@gmail.com>
6456
6457 * keyboard.c (Qdelayed_warnings_hook): Define.
6458 (command_loop_1): Run `delayed-warnings-hook'
6459 if Vdelayed_warnings_list is non-nil.
6460 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6461 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6462
d178f871
EZ
64632011-04-28 Eli Zaretskii <eliz@gnu.org>
6464
6465 * doprnt.c (doprnt): Don't return value smaller than the buffer
6466 size if the message was truncated. (Bug#8545).
6467
b124fd93
JB
64682011-04-28 Juanma Barranquero <lekktu@gmail.com>
6469
6470 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6471 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6472
e810457d
PE
64732011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6474
6475 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6476
ea51cceb
JB
64772011-04-27 Juanma Barranquero <lekktu@gmail.com>
6478
6479 * makefile.w32-in: Update dependencies.
6480
94dcfacf
EZ
64812011-04-27 Eli Zaretskii <eliz@gnu.org>
6482
6483 Improve `doprnt' and its usage. (Bug#8545)
6484 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6485 `format_end'. Remove support for %l as a conversion specifier.
6486 Don't use xrealloc. Improve diagnostics when the %l size modifier
6487 is used. Update the commentary.
6488
6489 * eval.c (verror): Simplify calculation of size_t.
6490
6491 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6492 messages.
6493
f61f41d7
PE
64942011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6495
6496 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6497 change.
6498
96fb4434
PE
64992011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6500
6501 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6502 This makes this file independent of the recent pseudovector change.
6503
671875da 65042011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6505
69e9b5a3
PE
6506 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6507
b5f869a7 6508 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6509 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6510 Remove unused local.
c8926152 6511 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6512
841a1577 6513 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6514 GCC 4.6.0 optimizes based on type-based alias analysis.
6515 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6516 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6517 != &v->size, and therefore "v->size = 1; b->size = 2; return
6518 v->size;" must therefore return 1. This assumption is incorrect
6519 for Emacs, since it type-puns struct Lisp_Vector * with many other
6520 types. To fix this problem, this patch adds a new type struct
f904488f 6521 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6522 and pseudovectors, and helps optimizing compilers not get fooled
6523 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6524 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6525 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6526 the size member.
eab3844f
PE
6527 (XSETPVECTYPE): Rewrite in terms of new macro.
6528 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6529 This is a bit clearer, and further avoids the possibility of
6530 undesirable aliasing.
6531 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6532 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6533 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6534 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6535 (ASIZE): Now uses header.size rather than size.
6536 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6537 to avoid the hassle of writing XVECTOR (foo)->header.size.
6538 (struct vectorlike_header): New type.
eab3844f
PE
6539 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6540 object, to help avoid aliasing.
6541 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6542 (SUBRP): Likewise, since Lisp_Subr is a special case.
6543 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6544 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6545 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6546 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6547 changed to be "header.size" and "header.next".
6548 * buffer.h (struct buffer): Likewise.
6549 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6550 * frame.h (struct frame): Likewise.
6551 * process.h (struct Lisp_Process): Likewise.
6552 * termhooks.h (struct terminal): Likewise.
6553 * window.c (struct save_window_data, struct saved_window): Likewise.
6554 * window.h (struct window): Likewise.
6555 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6556 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6557 * buffer.c (init_buffer_once): Likewise.
6558 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6559 special case.
6560 * process.c (Fformat_network_address): Use local var for size,
6561 for brevity.
6562
0df1eac5
PE
6563 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6564
847ab9d1 6565 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6566 * data.c (atof): Remove decl; no longer used or needed.
6567 (digit_to_number): Move to lread.c.
6568 (Fstring_to_number): Use new string_to_number function, to be
6569 consistent with how the Lisp reader treats infinities and NaNs.
6570 Do not assume that floating-point numbers represent EMACS_INT
6571 without losing information; this is not true on most 64-bit hosts.
6572 Avoid double-rounding errors, by insisting on integers when
6573 parsing non-base-10 numbers, as the documentation specifies.
6574 * lisp.h (string_to_number): New decl, replacing ...
6575 (isfloat_string): Remove.
bc0a5c13 6576 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6577 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6578 appears to have been a coding error. Similarly, do not accept
6579 strings like +-1e0 as floating point numbers. Do not report
6580 overflow for integer overflows unless the base is not 10 which
6581 means we have no simple and reliable way to continue.
6582 Break out the floating-point parsing into a new
6583 function string_to_number, so that Fstring_to_number parses
6584 floating point numbers consistently with the Lisp reader.
04f2d78b 6585 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6586 (E_CHAR, EXP_INT): Remove, replacing with ...
6587 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6588 (string_to_number): New function, replacing isfloat_string.
6589 This function checks for valid syntax and produces the resulting
6590 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6591 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6592 so that overflow for non-base-10 numbers is reported only when
6593 there's no portable and simple way to convert to floating point.
452f4150 6594
67769ffc
PE
6595 * textprop.c (set_text_properties_1): Rewrite for clarity,
6596 and to avoid GCC warning about integer overflow.
6597
c20db43f
PE
6598 * intervals.h (struct interval): Use EMACS_INT for members
6599 where EMACS_UINT might cause problems. See
6600 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6601 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6602 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6603 All uses changed.
37aa2f85
PE
6604 (offset_intervals): Tell GCC not to worry about length overflow
6605 when negating a negative length.
c20db43f 6606
2538aa2f
PE
6607 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6608 (overrun_check_free): Likewise.
6609
f2d3008d
PE
6610 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6611 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6612 word size.
6613
ec8df744
PE
6614 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6615 (gnutls_make_error): Rename local to avoid shadowing.
6616 (gnutls_emacs_global_deinit): ifdef out; not used.
6617 (Fgnutls_boot): Use const for pointer to readonly storage.
6618 Comment out unused local. Fix pointer signedness problems.
6619
640ee02d
PE
6620 * lread.c (openp): Don't stuff size_t into an 'int'.
6621 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6622 about possible signed overflow.
6623
6048fb2a
PE
6624 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6625 (GDK_KEY_g): Don't define if already defined.
6626 (xg_prepare_tooltip): Avoid pointer signedness problem.
6627 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6628
fa3c87e1
PE
6629 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6630 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6631
2172544b
PE
6632 * xfns.c (Fx_window_property): Simplify a bit,
6633 to make a bit faster and to avoid GCC 4.6.0 warning.
6634 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6635
9b821a21
PE
6636 * fns.c (internal_equal): Don't assume size_t fits in int.
6637
3c616cfa
PE
6638 * alloc.c (compact_small_strings): Tighten assertion a little.
6639
c2982e87
PE
6640 Replace pEd with more-general pI, and fix some printf arg casts.
6641 * lisp.h (pI): New macro, generalizing old pEd macro to other
6642 conversion specifiers. For example, use "...%"pI"d..." rather
6643 than "...%"pEd"...".
6644 (pEd): Remove. All uses replaced with similar uses of pI.
6645 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6646 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6647 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6648 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6649 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6650 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6651 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6652 64-bit hosts.
6653 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6654 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6655 * print.c (safe_debug_print, print_object): Likewise.
6656 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6657 to int.
6f04d126
PE
6658 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6659 avoiding the 0 flag, which is not portable.
c2982e87
PE
6660 * process.c (Fmake_network_process): Use pI to avoid cast.
6661 * region-cache.c (pp_cache): Likewise.
6662 * xdisp.c (decode_mode_spec): Likewise.
6663 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6664 behavior on 64-bit hosts with printf arg.
6f04d126 6665 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6666 (x_stop_queuing_selection_requests): Likewise.
6667 (x_get_window_property): Don't truncate byte count to an 'int'
6668 when tracing.
0b432f21 6669
5e073ec7
PE
6670 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6671 here, since it parses constructs like leading '-' and spaces,
6672 which are not wanted; and it overflows with large numbers.
6673 Instead, simply match F[0-9]+, which is what is wanted anyway.
6674
36372bf9
PE
6675 * alloc.c: Remove unportable assumptions about struct layout.
6676 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6677 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6678 (allocate_vectorlike, make_pure_vector): Use the new macros,
6679 plus offsetof, to remove unportable assumptions about struct layout.
6680 These assumptions hold on all porting targets that I know of, but
6681 they are not guaranteed, they're easy to remove, and removing them
6682 makes further changes easier.
6683
0b432f21
PE
6684 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6685 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6686 (string_overrun_cookie): Now const. Use initializers that
6687 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6688 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6689 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6690 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6691 multiple of sizeof (EMACS_INT); it need not be, if
6692 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6693 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6694
895009e1
JB
66952011-04-26 Juanma Barranquero <lekktu@gmail.com>
6696
6697 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6698
6a7a1b0b
TZ
66992011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6700
6701 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6702 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6703 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6704
841a1577 67052011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6706
6707 * lisp.h (Qdebug): List symbol.
895009e1 6708 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6709 * keyboard.c (debug-on-event): New variable.
6710 (handle_user_signal): Break into debugger when debug-on-event
6711 matches the current signal symbol.
6712
f2d3ba6f
DN
67132011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6714
6715 * alloc.c (check_sblock, check_string_bytes)
6716 (check_string_free_list): Convert to standard C.
6717
42ce4c63
TZ
67182011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6719
6720 * w32.c (emacs_gnutls_push): Fix typo.
6721
825cd63c
EZ
67222011-04-25 Eli Zaretskii <eliz@gnu.org>
6723
fb11d64d
EZ
6724 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6725 "cast to pointer from integer of different size".
6726
825cd63c
EZ
6727 Improve doprnt and its use in verror. (Bug#8545)
6728 * doprnt.c (doprnt): Document the set of format control sequences
6729 supported by the function. Use SAFE_ALLOCA instead of always
6730 using `alloca'.
6731
6732 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6733 is one byte too soon. Don't use xrealloc; instead xfree and
6734 xmalloc anew.
6735
e061a11b
TZ
67362011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6737
6738 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6739 callbacks stage.
6740
6741 * gnutls.c: Renamed global_initialized to
6742 gnutls_global_initialized. Added internals for the
6743 :verify-hostname-error, :verify-error, and :verify-flags
6744 parameters of `gnutls-boot' and documented those parameters in the
6745 docstring. Start callback support.
9173deec
JB
6746 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6747 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6748 on error. Return error code.
e061a11b
TZ
6749 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6750 (emacs_gnutls_read): Likewise.
6751 (Fgnutls_boot): Return handshake error code.
6752 (emacs_gnutls_handle_error): New function.
6753 (wsaerror_to_errno): Likewise.
6754
6755 * w32.h (emacs_gnutls_pull): Add prototype.
6756 (emacs_gnutls_push): Likewise.
6757
6758 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6759 (emacs_gnutls_push): Likewise.
6760
67612011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6762
6763 * process.c (wait_reading_process_output): Check if GnuTLS
6764 buffered some data internally if no FDs are set for TLS
6765 connections.
6766
6767 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6768 (LIBS): Link to USER_LIBS.
6769 ($(BLD)/gnutls.$(0)): New target.
6770
fa6996bc
EZ
67712011-04-24 Eli Zaretskii <eliz@gnu.org>
6772
eb35682e
EZ
6773 * xdisp.c (handle_single_display_spec): Rename the
6774 display_replaced_before_p argument into display_replaced_p, to
6775 make it consistent with the commentary. Fix typos in the
6776 commentary.
6777
e2ad650c
EZ
6778 * textprop.c (syms_of_textprop): Remove dead code.
6779 (copy_text_properties): Delete obsolete commentary about an
6780 interface that was deleted long ago. Fix typos in the description
6781 of arguments.
6782
1b2de274
EZ
6783 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6784 to changes in oldXMenu/XMenu.h from 2011-04-16.
6785 <menu_help_message, prev_menu_help_message>: Constify.
6786 (IT_menu_make_room): menu->help_text is now `const char **';
6787 adjust.
6788
6789 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6790 to changes in oldXMenu/XMenu.h from 2011-04-16.
6791 (struct XMenu): Declare `help_text' `const char **'.
6792
6793 * xfaces.c <Qunspecified>: Make extern again.
6794
6795 * syntax.c: Include sys/types.h before including regex.h, as
6796 required by Posix.
6797
762b15be
EZ
6798 * doc.c (get_doc_string): Improve the format passed to `error'.
6799
6800 * doprnt.c (doprnt): Improve commentary.
6801
6802 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6803
6804 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6805 them with etags.
6806
f1052e5d
EZ
6807 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6808 changes in globals.h immediately force recompilation.
762b15be
EZ
6809 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6810 $(CURDIR)/s/ms-w32.h.
6811 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6812
fa6996bc
EZ
6813 * character.c (Fchar_direction): Function deleted.
6814 (syms_of_character): Don't defsubr it.
6815 <char-direction-table>: Deleted.
6816
e6c3da20
EZ
68172011-04-23 Eli Zaretskii <eliz@gnu.org>
6818
6819 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6820 * doprnt.c: Include limits.h.
6821 (SIZE_MAX): New macro.
04f2d78b
CB
6822 (doprnt): Return a size_t value. 2nd arg is now size_t.
6823 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6824 Improve overflow protection. Support `l' modifier for integer
6825 conversions. Support %l conversion. Don't assume an EMACS_INT
6826 argument for integer conversions and for %c.
6827
6828 * lisp.h (doprnt): Restore prototype.
6829
6830 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6831 $(SRC)/character.h.
6832
6833 * Makefile.in (base_obj): Add back doprnt.o.
6834
6835 * deps.mk (doprnt.o): Add back prerequisites.
6836 (callint.o): Depend on character.h.
6837
6838 * eval.c (internal_lisp_condition_case): Include the handler
6839 representation in the error message.
6840 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6841 when breaking from the loop.
6842
6843 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6844
6845 * callint.c (Fcall_interactively): When displaying error message
6846 about invalid control letter, pass the character's codepoint, not
6847 a pointer to its multibyte form. Improve display of the character
6848 in octal and display also its hex code.
6849
6850 * character.c (char_string): Use %x to display the (unsigned)
6851 codepoint of an invalid character, to avoid displaying a bogus
6852 negative value.
6853
6854 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6855 `error', not SYMBOL_NAME itself.
6856
6857 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6858 character arguments to `error'.
6859
6860 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6861 to `error' in error message about FINAL_CHAR argument. Make sure
6862 FINAL_CHAR is a character, and use %c when it is passed as
6863 argument to `error'.
6864
4ffd0d6b 68652011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6866
6867 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6868
6869 * w32.c: Include <time.h>.
6870 (sys_localtime): New function.
6871
4ffd0d6b 68722011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6873
6874 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6875
4ffd0d6b 6876 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6877
4ffd0d6b 68782011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6879
4ffd0d6b
GM
6880 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6881 zombies (Bug#8467).
aac0c6e3 6882
04c56954
EZ
68832011-04-19 Eli Zaretskii <eliz@gnu.org>
6884
6885 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6886 gl_state.e_property when gl_state.object is Qt.
6887
6888 * insdel.c (make_gap_larger): Remove limitation of buffer size
6889 to <= INT_MAX.
6890
16a43933
CY
68912011-04-18 Chong Yidong <cyd@stupidchicken.com>
6892
6893 * xdisp.c (lookup_glyphless_char_display)
6894 (produce_glyphless_glyph): Handle cons cell entry in
6895 glyphless-char-display.
6896 (Vglyphless_char_display): Document it.
6897
6898 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6899 glyphless-char-display.
6900
4581706e
CY
69012011-04-17 Chong Yidong <cyd@stupidchicken.com>
6902
6903 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6904
6905 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6906
6907 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6908 definition for no-X builds.
6909
4887c6e2 69102011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6911
fd35b6f9
PE
6912 Static checks with GCC 4.6.0 and non-default toolkits.
6913
5c1ccb01
PE
6914 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6915
006c5daa
PE
6916 * process.c (keyboard_bit_set): Define only if SIGIO.
6917 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6918 (send_process): Repair possible setjmp clobbering.
6919
efc736d3
PE
6920 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6921
4e2fe2e6
PE
6922 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6923
f97334a2
PE
6924 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6925
4e75f29d
PE
6926 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6927 Define only if needed.
6928
90efadd1
PE
6929 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6930 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6931 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6932
3c647824
PE
6933 * dispextern.h (struct redisplay_interface): Rename param
6934 to avoid shadowing.
e264f262 6935 * termhooks.h (struct terminal): Likewise.
761383f4 6936 * xterm.c (xembed_send_message): Likewise.
3c647824 6937
b58c5c4a
PE
6938 * insdel.c (make_gap_smaller): Define only if
6939 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6940
cad59032
PE
6941 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6942 it.
6943
c339dc2e
PE
6944 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6945 so that we aren't warned about unused symbols.
6946
91a3e27b
PE
6947 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6948
399c71d3 6949 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6950
8ffc96f5
PE
6951 * xfns.c (x_real_positions): Mark locals as initialized.
6952
eef9bc79
PE
6953 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6954
098db9dd
PE
6955 * xterm.c: Fix problems found by static analysis with other toolkits.
6956 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6957 (x_dispatch_event): Declare static if USE_GTK, and
6958 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6959 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6960 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6961 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6962 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6963
eb18f6cc
PE
6964 * xmenu.c (menu_help_callback): Pointer type fixes.
6965 Use const pointers when pointing at readonly data. Avoid pointer
6966 signedness clashes.
6967 (FALSE): Remove unused macro.
6968 (update_frame_menubar): Remove unused decl.
6969
1fe72bf8
PE
6970 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6971
60d9e1db
PE
6972 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6973 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6974 (single_menu_item): Rename local to avoid shadowing.
6975
39261c26
PE
6976 * keyboard.c (make_lispy_event): Remove unused local var.
6977
018c5e19
PE
6978 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6979 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6980
63d2b86e
PE
6981 * bitmaps: Change bitmaps from unsigned char back to the X11
6982 compatible char. Avoid the old compiler warnings about
6983 out-of-range initializers by using, for example, '\xab' rather
6984 than 0xab.
6985
aefd87e1
PE
6986 * xgselect.c (xgselect_initialize): Check vs interface
6987 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6988
bf501fb9
PE
6989 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6990
e9829fdf
PE
6991 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6992 to read-only memory.
6993
1086c095
PE
6994 * fns.c (vector): Remove; this old hack is no longer needed.
6995
2baccd04 6996 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6997 Remove unused var.
dde42981 6998 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6999
72391843 7000 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7001
436c16df 7002 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7003 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7004 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7005
92bb796d 7006 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7007 (x_term_init): Remove local to avoid shadowing.
92bb796d 7008
764430a3 7009 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7010
7011 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7012 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7013
d1dfb56c
EZ
70142011-04-16 Eli Zaretskii <eliz@gnu.org>
7015
c4354cb4
EZ
7016 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7017
d1dfb56c
EZ
7018 Fix regex.c, syntax.c and friends for buffers > 2GB.
7019 * syntax.h (struct gl_state_s): Declare character position members
7020 EMACS_INT.
7021
7022 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7023
04f2d78b
CB
7024 * textprop.c (verify_interval_modification, interval_of):
7025 Declare arguments EMACS_INT.
d1dfb56c
EZ
7026
7027 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7028 EMACS_INT.
7029
7030 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7031
7032 * indent.c (Fvertical_motion): Local variable it_start is now
7033 EMACS_INT.
7034
7035 * regex.c (re_match, re_match_2, re_match_2_internal)
7036 (bcmp_translate, regcomp, regexec, print_double_string)
7037 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7038 (re_compile_pattern, re_exec): Declare arguments and local
7039 variables `size_t' and `ssize_t' and return values `regoff_t', as
7040 appropriate.
7041 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7042 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7043 <compile_stack_type>: `size' and `avail' are now `size_t'.
7044
7045 * regex.h <regoff_t>: Use ssize_t, not int.
7046 (re_search, re_search_2, re_match, re_match_2): Arguments that
7047 specify buffer/string position and length are now ssize_t and
7048 size_t. Return type is regoff_t.
7049
613052cd
BK
70502011-04-16 Ben Key <bkey76@gmail.com>
7051
7052 * nsfont.m: Fixed bugs in ns_get_family and
7053 ns_descriptor_to_entity that were caused by using free to
7054 deallocate memory blocks that were allocated by xmalloc (via
7055 xstrdup). This caused Emacs to crash when compiled with
7056 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7057 --enable-checking=xmallocoverrun). xfree is now used to
7058 deallocate these memory blocks.
7059
4170f62f 70602011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7061
71b41406
PE
7062 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7063
9587a89d
PE
7064 emacs_write: Accept and return EMACS_INT for sizes.
7065 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7066 et seq.
7067 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7068 Accept and return EMACS_INT.
7069 (emacs_gnutls_write): Return the number of bytes written on
7070 partial writes.
7071 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7072 (emacs_read, emacs_write): Remove check for negative size, as the
7073 Emacs source code has been audited now.
9587a89d
PE
7074 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7075 (emacs_read, emacs_write): Use it.
273a5f82
PE
7076 * process.c (send_process): Adjust to the new signatures of
7077 emacs_write and emacs_gnutls_write. Do not attempt to store
7078 a byte offset into an 'int'; it might overflow.
9587a89d 7079 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7080
3e047f51
PE
7081 * sound.c: Don't assume sizes fit in 'int'.
7082 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7083 Return EMACS_INT, not int.
3e047f51 7084 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7085 Accept EMACS_INT, not int.
7086 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7087 record read return values.
7088
cc39a9db
BK
70892011-04-15 Ben Key <bkey76@gmail.com>
7090
c9d0ec6d
JB
7091 * keyboard.c (Qundefined): Don't declare static since it is used
7092 in nsfns.m.
7093 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7094 static since they are used in nsfont.m.
cc39a9db 7095
6c60eb9f
SM
70962011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7097
7098 * process.c (Qprocessp): Don't declare static.
7099 * lisp.h (Qprocessp): Declare again.
7100
7990b61a
JB
71012011-04-15 Juanma Barranquero <lekktu@gmail.com>
7102
7103 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7104
5d4cb038
PE
71052011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7106
8bd7b830 7107 Improve C-level modularity by making more things 'static'.
cd64ea1d 7108
e3b27b31
PE
7109 Don't publish debugger-only interfaces to other modules.
7110 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7111 (verify_bytepos, count_markers): Move decls to the only modules
7112 that need them.
7113 * region-cache.h (pp_cache): Likewise.
7114 * window.h (check_all_windows): Likewise.
7115 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7116
5d4cb038
PE
7117 * sysdep.c (croak): Now static, if
7118 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7119 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7120
7121 * alloc.c (refill_memory_reserve): Now static if
7122 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7123 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7124
e87b6180
PE
7125 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7126 Define only if USE_LUCID.
7127
ac64929e
PE
7128 * xrdb.c (x_customization_string, x_rm_string): Now static.
7129
6f37259d
PE
7130 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7131 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7132
1683e3ab
PE
7133 * xdisp.c (draw_row_with_mouse_face): Now static.
7134 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7135
de9c2632
PE
7136 * window.h (check_all_windows): Mark externally visible.
7137
2b96acb7
PE
7138 * window.c (window_deletion_count): Now static.
7139
7140 * undo.c: Make symbols static if they're not exported.
7141 (last_undo_buffer, last_boundary_position, pending_boundary):
7142 Now static.
7143
50436f33
PE
7144 * textprop.c (interval_insert_behind_hooks): Now static.
7145 (interval_insert_in_front_hooks): Likewise.
7146
64520e5c
PE
7147 * term.c: Make symbols static if they're not exported.
7148 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7149 (max_frame_lines, tty_set_terminal_modes):
7150 (tty_reset_terminal_modes, tty_turn_off_highlight):
7151 (get_tty_terminal): Now static.
7152 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7153 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7154 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7155 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7156 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7157
1fa53021
PE
7158 * sysdep.c: Make symbols static if they're not exported.
7159 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7160 Now static.
7161 (sigprocmask_set, full_mask): Remove; unused.
7162 (wait_debugging): Mark as visible.
7163 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7164 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7165
d4b43b22
PE
7166 * syntax.c (syntax_temp): Define only if !__GNUC__.
7167
b7c513d0
PE
7168 * sound.c (current_sound_device, current_sound): Now static.
7169
989b29ad
PE
7170 * search.c (searchbufs, searchbuf_head): Now static.
7171
13a55a78
PE
7172 * scroll.c (scroll_cost): Remove; unused.
7173 * dispextern.h (scroll_cost): Remove decl.
7174
de68a1fc
PE
7175 * region-cache.h (pp_cache): Mark as externally visible.
7176
40ccffa6
PE
7177 * process.c: Make symbols static if they're not exported.
7178 (process_tick, update_tick, create_process, chan_process):
7179 (Vprocess_alist, proc_buffered_char, datagram_access):
7180 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7181 (deactivate_process): Mark defn as static, as well as decl.
7182 * lisp.h (create_process): Remove decl.
7183 * process.h (chan_process, Vprocess_alist): Remove decls.
7184
ad64fc97
PE
7185 * print.c: Make symbols static if they're not exported.
7186 (print_depth, new_backquote_output, being_printed, print_buffer):
7187 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7188 (print_interval, print_number_index, initial_stderr_stream):
7189 Now static.
7190 * lisp.h (Fprinc): Remove decl.
7191 (debug_output_compilation_hack): Mark as externally visible.
7192
adddb265
PE
7193 * sysdep.c (croak): Move decl from here to syssignal.h.
7194 * syssignal.h (croak): Put it here, so the API can be checked when
7195 'croak' is called from dissociate_if_controlling_tty.
7196
1717ede2
PE
7197 * minibuf.c: Make symbols static if they're not exported.
7198 (minibuf_save_list, choose_minibuf_frame): Now static.
7199 * lisp.h (choose_minibuf_frame): Remove decl.
7200
fa5fb2bc
PE
7201 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7202
1e3890d1
PE
7203 * lread.c: Make symbols static if they're not exported.
7204 (read_objects, initial_obarray, oblookup_last_bucket_number):
7205 Now static.
7206 (make_symbol): Remove; unused.
7207 * lisp.h (initial_obarray, make_symbol): Remove decls.
7208
8a1414fa
PE
7209 * keyboard.c: Make symbols static if they're not exported.
7210 (single_kboard, recent_keys_index, total_keys, recent_keys):
7211 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7212 (this_single_command_key_start, echoing, last_auto_save):
7213 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7214 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7215 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7216 (Vlispy_mouse_stem, double_click_count):
7217 Now static.
7218 (force_auto_save_soon): Define only if SIGDANGER.
7219 (ignore_mouse_drag_p): Now static if
7220 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7221 (print_help): Remove; unused.
7222 (stop_character, last_timer_event): Mark as externally visible.
7223 * keyboard.h (ignore_mouse_drag_p): Declare only if
7224 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7225 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7226 * lisp.h (echoing): Remove decl.
7227 (force_auto_save_soon): Declare only if SIGDANGER.
7228 * xdisp.c (redisplay_window): Simplify code, to make it more
7229 obvious that ignore_mouse_drag_p is not accessed if !defined
7230 USE_GTK && !defined HAVE_NS.
7231
93ea6e8f
PE
7232 * intervals.c: Make symbols static if they're not exported.
7233 (merge_properties_sticky, merge_interval_right, delete_interval):
7234 Now static.
7235 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7236
77382fcc
PE
7237 * insdel.c: Make symbols static if they're not exported.
7238 However, leave prepare_to_modify_buffer alone. It's never
7239 called from outside this function, but that appears to be a bug.
7240 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7241 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7242 (adjust_after_replace_noundo): Remove; unused.
7243 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7244 (signal_before_change): Remove decls.
77382fcc 7245
9306c32e
PE
7246 * indent.c (val_compute_motion, val_vmotion): Now static.
7247
cd44d2eb
PE
7248 * image.c: Make symbols static if they're not exported.
7249 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7250 if USE_GTK.
7251 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7252 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7253
ad9a7a06
PE
7254 * fringe.c (standard_bitmaps): Now static.
7255 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7256
81626931
PE
7257 * frame.c: Make symbols static if they're not exported.
7258 (x_report_frame_params, make_terminal_frame): Now static.
7259 (get_frame_param): Now static, unless HAVE_NS.
7260 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7261 (x_get_resource_string): Remove; not used.
7262 * frame.h (make_terminal_frame, x_report_frame_params):
7263 (x_get_resource_string); Remove decls.
7264 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7265 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7266
239f9db9
PE
7267 * font.c, fontset.c: Make symbols static if they're not exported.
7268 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7269 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7270 * font.c (font_close_object): Now static.
7271 * font.h (font_close_object): Remove.
7272 * fontset.c (FONTSET_OBJLIST): Remove.
7273 (free_realized_fontset) #if-0 the body, which does nothing.
7274 (face_suitable_for_char_p): #if-0, as it's never called.
7275 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7276 * xfaces.c (face_at_string_position):
7277 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7278 since 0 is always ASCII.
7279
dfcf3579
PE
7280 * fns.c (weak_hash_tables): Now static.
7281
5045092b
PE
7282 * fileio.c: Make symbols static if they're not exported.
7283 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7284 (Vwrite_region_annotation_buffers): Now static.
7285
57a96f5c
PE
7286 * eval.c: Make symbols static if they're not exported.
7287 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7288 * lisp.h (backtrace_list): Remove decl.
7289
35f08c38
PE
7290 * emacs.c: Make symbols static if they're not exported.
7291 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7292 (fatal_error_code, fatal_error_signal_hook, standard_args):
7293 Now static.
7294 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7295 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7296 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7297 * lisp.h (fatal_error_signal_hook): Remove decl.
7298 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7299
f44bd759
PE
7300 * editfns.c: Move a (normally-unused) function to its only use.
7301 * editfns.c, lisp.h (get_operating_system_release): Remove.
7302 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7303 worth the hassle of breaking this out.
7304
b532497d
PE
7305 * xterm.c: Make symbols static if they're not exported.
7306 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7307 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7308 (x_destroy_window, x_delete_display):
7309 Now static.
7310 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7311 (x_mouse_leave): Remove; unused.
7312 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7313 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7314 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7315 Remove decls.
7316 (x_mouse_leave): Declare only if WINDOWSNT.
7317 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7318 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7319 USE_X_TOOLKIT.
7320
1675728f
PE
7321 * ftxfont.c: Make symbols static if they're not exported.
7322 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7323 HAVE_FREETYPE.
7324 * font.h (ftxfont_driver): Likewise.
7325
e4cebfca
PE
7326 * xfns.c: Make symbols static if they're not exported.
7327 (x_last_font_name, x_display_info_for_name):
7328 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7329 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7330 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7331 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7332 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7333 (last_show_tip_args): Now static.
7334 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7335 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7336 (x_screen_planes): Remove; unused.
7337 * dispextern.h (x_screen_planes): Remove decl.
7338
5bf46f05
PE
7339 * dispnew.c: Make symbols static if they're not exported.
7340 * dispextern.h (redraw_garbaged_frames, scrolling):
7341 (increment_row_positions): Remove.
7342 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7343 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7344 Now static.
7345 (redraw_garbaged_frames): Remove; unused.
7346
435f4c28
PE
7347 * xfaces.c: Make symbols static if they're not exported.
7348 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7349 Remove decls.
7350 * xterm.h (defined_color): Remove decls.
7351 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7352 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7353 (menu_face_changed_default, defined_color, free_realized_face):
7354 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7355 (ascii_face_of_lisp_face): Remove; unused.
7356
8524aef3
PE
7357 * xdisp.c: Make symbols static if they're not exported.
7358 * dispextern.h (scratch_glyph_row, window_box_edges):
7359 (glyph_to_pixel_coords, set_cursor_from_row):
7360 (get_next_display_element, set_iterator_to_next):
7361 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7362 (show_mouse_face): Remove decls
7363 * frame.h (message_buf_print): Likewise.
7364 * lisp.h (pop_message, set_message, check_point_in_composition):
7365 Likewise.
7366 * xterm.h (set_vertical_scroll_bar): Likewise.
7367 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7368 (message_buf_print, scratch_glyph_row, displayed_buffer):
7369 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7370 (get_next_display_element, show_mouse_face, window_box_edges):
7371 (frame_to_window_pixel_xy, check_point_in_composition):
7372 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7373 (glyph_to_pixel_coords): Remove; unused.
7374
16390cd2
PE
7375 * dired.c (file_name_completion): Now static.
7376
7377 * dbusbind.c (xd_in_read_queued_messages): Now static.
7378
a25f4dfa
PE
7379 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7380 * data.c (circular_list_error): Remove.
7381
14a9c8df
PE
7382 * commands.h (last_point_position, last_point_position_buffer):
7383 (last_point_position_window): Remove decls.
7384 * keyboard.c: Make these variables static.
7385
04f2d78b
CB
7386 * coding.h (coding, code_convert_region, encode_coding_gap):
7387 Remove decls.
74ab6df5
PE
7388 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7389 (iso_code_class, detect_coding, code_convert_region): Now static.
7390 (encode_coding_gap): Remove; unused.
7391
38dfbee1
PE
7392 * chartab.c (chartab_chars, chartab_bits): Now static.
7393
a2cb4e63
PE
7394 * charset.h (charset_iso_8859_1): Remove decl.
7395 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7396 Now static.
7397
127198fd
PE
7398 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7399 * ccl.c (Vccl_program_table): Now static.
7400 (check_ccl_update): Remove; unused.
7401
d85b608f
PE
7402 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7403 * category.h: ... from here.
7404 * category.c (check_category_table, set_category_set): Now static.
7405
31cd66f3
PE
7406 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7407 * lisp.h: Remove these decls.
7408
c358e587
PE
7409 * buffer.c (buffer_count): Remove unused var.
7410
e78aecca
PE
7411 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7412 so that it's not optimized away.
7413 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7414 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7415 exported only to the debugger.
7416
e192d7d3 7417 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7418 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7419
92470028
PE
7420 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7421 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7422 was inaccessible from Lisp.
7423 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7424 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7425
244ed907
PE
7426 alloc.c: Import and export fewer symbols, and remove unused items.
7427 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7428 is defined.
7429 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7430 it's not optimized away by whole-program optimization.
7431 (message_enable_multibyte, free_misc): Remove.
7432 (catchlist, handlerlist, mark_backtrace):
7433 Declare only if BYTE_MARK_STACK.
7434 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7435 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7436 (message_enable_multibyte): Remove decl.
7437 (free_misc, interval_free_list, float_block, float_block_index):
7438 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7439 (cons_free_list, last_marked_index):
7440 Now static.
7441 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7442 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7443 (mark_backtrace): Define only if BYTE_MARK_STACK.
7444 * xdisp.c (message_enable_multibyte): Now static.
7445
61c2b50e 7446 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7447 This makes it easier for human readers (and static analyzers)
7448 to see whether these variables are used from other modules.
7449 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7450 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7451 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7452 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7453 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7454 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7455 * xmenu.c, xselect.c:
7456 Declare Q* vars static if they are not used in other modules.
7457 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7458 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7459 Remove decls of unexported vars.
7460 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7461
95c82688
PE
7462 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7463
16a97296
PE
7464 Make Emacs functions such as Fatom 'static' by default.
7465 This makes it easier for human readers (and static analyzers)
7466 to see whether these functions can be called from other modules.
7467 DEFUN now defines a static function. To make the function external
7468 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7469 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7470 (Finit_image_library):
16a97296
PE
7471 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7472 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7473 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7474 Remove decls, since these functions are now static.
7475 (Funintern, Fget_internal_run_time): New decls, since these functions
7476 were already external.
95c82688 7477
16a97296
PE
7478 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7479 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7480 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7481 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7482 * keyboard.c, keymap.c, lread.c:
7483 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7484 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7485 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7486 Mark functions with DEFUE instead of DEFUN,
7487 if they are used in other modules.
7488 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7489 decls for now-static functions.
7490 * buffer.h (Fdelete_overlay): Remove decl.
7491 * callproc.c (Fgetenv_internal): Mark as internal.
7492 * composite.c (Fremove_list_of_text_properties): Remove decl.
7493 (Fcomposition_get_gstring): New forward static decl.
7494 * composite.h (Fcomposite_get_gstring): Remove decl.
7495 * dired.c (Ffile_attributes): New forward static decl.
7496 * doc.c (Fdocumntation_property): New forward static decl.
7497 * eval.c (Ffetch_bytecode): New forward static decl.
7498 (Funintern): Remove extern decl; now in .h file where it belongs.
7499 * fileio.c (Fmake_symbolic_link): New forward static decl.
7500 * image.c (Finit_image_library): New forward static decl.
7501 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7502 * intervals.h (Fprevious_property_change):
7503 (Fremove_list_of_text_properties): Remove decls.
7504 * keyboard.c (Fthis_command_keys): Remove decl.
7505 (Fcommand_execute): New forward static decl.
7506 * keymap.c (Flookup_key): New forward static decl.
7507 (Fcopy_keymap): Now static.
7508 * keymap.h (Flookup_key): Remove decl.
7509 * process.c (Fget_process): New forward static decl.
7510 (Fprocess_datagram_address): Mark as internal.
7511 * syntax.c (Fsyntax_table_p): New forward static decl.
7512 (skip_chars): Remove duplicate decl.
7513 * textprop.c (Fprevious_property_change): New forward static decl.
7514 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7515 Now internal.
7516 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7517 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7518
785bbd42
PE
7519 * editfns.c (Fformat): Remove unreachable code.
7520
8b913b57
AS
75212011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7522
7523 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7524 change. (Bug#8496)
7525
a6744a35
EZ
75262011-04-13 Eli Zaretskii <eliz@gnu.org>
7527
7528 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7529 when at ZV. (Bug#8487)
7530
e7974947
AS
75312011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7532
baad03f0
AS
7533 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7534 (Bug#8437)
7535 * keyboard.c (parse_tool_bar_item): Likewise.
7536 * sound.c (sound_cleanup, alsa_close): Likewise.
7537 * termcap.c (tgetent): Likewise.
7538 * xfns.c (x_default_font_parameter): Likewise.
7539 * xsettings.c (read_and_apply_settings): Likewise.
7540
e7974947
AS
7541 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7542 (overrun_check_free): Protoize.
7543
28272684
PE
75442011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7545
7546 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7547 since callers should never pass a negative size.
7548 Change the signature to match that of plain 'read' and 'write'; see
7549 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7550 * lisp.h: Update prototypes of emacs_write and emacs_read.
7551
11997c76
EZ
75522011-04-11 Eli Zaretskii <eliz@gnu.org>
7553
7554 * xdisp.c (redisplay_window): Don't try to determine the character
7555 position of the scroll margin if the window start point w->startp
e896f03c 7556 is outside the buffer's accessible region. (Bug#8468)
11997c76 7557
8a2cbd72
EZ
75582011-04-10 Eli Zaretskii <eliz@gnu.org>
7559
7560 Fix write-region and its subroutines for buffers > 2GB.
7561 * fileio.c (a_write, e_write): Modify declaration of arguments and
7562 local variables to support buffers larger than 2GB.
7563 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7564
7565 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7566 argument, local variables, and return value.
7567
7568 * lisp.h: Update prototypes of emacs_write and emacs_read.
7569
7570 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7571
4073e537 75722011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7573
1ebfdcb6
PE
7574 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7575
b2ded58d
PE
7576 Fix more problems found by GCC 4.6.0's static checks.
7577
7d66342c
PE
7578 * xdisp.c (vmessage): Use a better test for character truncation.
7579
bbf47d44
PE
7580 * charset.c (load_charset_map): <, not <=, for optimization,
7581 and to avoid potential problems with integer overflow.
9248994d 7582 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7583 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7584 * editfns.c (Fformat): Likewise.
1e69125e 7585 * syntax.c (skip_chars): Likewise.
3befa583 7586
e3019616
PE
7587 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7588 This also lets GCC 4.6.0 generate slightly better loop code.
7589
becfa255
PE
7590 * callint.c (Fcall_interactively): <, not <=, for optimization.
7591 (Fcall_interactively): Count the number of arguments produced,
7592 not the number of arguments given. This is simpler and lets GCC
7593 4.6.0 generate slightly better code.
7594
dae0cd48
PE
7595 * ftfont.c: Distingish more carefully between FcChar8 and char.
7596 The previous code passed unsigned char * to a functions like
7597 strlen and xstrcasecmp that expect char *, which does not
7598 conform to the C standard.
7599 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7600 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7601 char * when the C standard requires it.
7602
76032d70
PE
7603 * keyboard.c (read_char): Remove unused var.
7604
eb3f1cc8
PE
7605 * eval.c: Port to Windows vsnprintf (Bug#8435).
7606 Include <limits.h>.
7607 (SIZE_MAX): Define if the headers do not.
7608 (verror): Do not give up if vsnprintf returns a negative count.
7609 Instead, grow the buffer. This ports to Windows vsnprintf, which
7610 does not conform to C99. Problem reported by Eli Zaretskii.
7611 Also, simplify the allocation scheme, by avoiding the need for
7612 calling realloc, and removing the ALLOCATED variable.
7613
70476b54
PE
7614 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7615
12020a9e
PE
7616 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7617 But keep the doprint source code for now, as we might revamp it
7618 and use it again (Bug#8435).
ea6c7ae6
PE
7619 * lisp.h (doprnt): Remove.
7620 * Makefile.in (base_obj): Remove doprnt.o.
7621 * deps.mk (doprnt.o): Remove.
7622
5fdb398c
PE
7623 error: Print 32- and 64-bit integers portably (Bug#8435).
7624 Without this change, on typical 64-bit hosts error ("...%d...", N)
7625 was used to print both 32- and 64-bit integers N, which relied on
7626 undefined behavior.
7627 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7628 New macro.
7629 * lisp.h (error, verror): Mark as printf-like functions.
7630 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7631 Report overflow in size calculations when allocating printf buffer.
7632 Do not truncate output string at its first null byte.
7633 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7634 Truncate the output at a character boundary, since vsnprintf does not
7635 do that.
7636 * charset.c (check_iso_charset_parameter): Convert internal
7637 character to string before calling 'error', since %c now has the
7638 printf meaning.
7639 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7640 overflow when computing char to be passed to 'error'. Do not
7641 pass Lisp_Object to 'error'; pass the integer instead.
7642 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7643 formatted with plain %d.
7644
b189fa66
PE
7645 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7646
bff87ef0
PE
7647 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7648
7e2cac20
PE
7649 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7650
ce4d90b5
PE
7651 * xterm.c (x_catch_errors): Remove duplicate declaration.
7652
266c9547
PE
7653 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7654
79c49ad2
PE
7655 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7656
368f4090
JM
76572011-04-10 Jim Meyering <meyering@redhat.com>
7658
7659 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7660 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7661 return ssize_t not "int", and use size_t as the buffer length.
7662 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7663 * gnutls.h: Update declarations.
7664 * process.c (read_process_output): Use ssize_t, to match.
7665 (send_process): Likewise.
7666
a32d4040
CY
76672011-04-09 Chong Yidong <cyd@stupidchicken.com>
7668
7669 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7670
8546720e 76712011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7672
04f2d78b
CB
7673 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7674 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7675
8546720e
GM
7676 * xterm.c (handle_one_xevent):
7677 * xmenu.c (create_and_show_popup_menu):
7678 * xselect.c (x_decline_selection_request)
7679 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7680
0a2f5c1a 76812011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7682
7683 Fix some uses of `int' instead of EMACS_INT.
7684 * search.c (string_match_1, fast_string_match)
7685 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7686 (scan_buffer, find_next_newline_no_quit)
7687 (find_before_next_newline, search_command, Freplace_match)
7688 (Fmatch_data): Make some `int' variables be EMACS_INT.
7689
7690 * xdisp.c (display_count_lines): 3rd argument and return value now
7691 EMACS_INT. All callers changed.
7692 (pint2hrstr): Last argument is now EMACS_INT.
7693
7694 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7695 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7696 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7697 (decode_coding_utf_16, decode_coding_emacs_mule)
7698 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7699 (decode_coding_ccl, decode_coding_charset)
7700 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7701 (decode_coding_iso_2022, decode_coding_emacs_mule)
7702 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7703 <char_offset, last_offset>: Declare EMACS_INT.
7704 (encode_coding_utf_8, encode_coding_utf_16)
7705 (encode_coding_emacs_mule, encode_invocation_designation)
7706 (encode_designation_at_bol, encode_coding_iso_2022)
7707 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7708 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7709 Declare EMACS_INT.
7710 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7711 (encode_invocation_designation): Last argument P_NCHARS is now
7712 EMACS_INT.
7713 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7714 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7715
7716 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7717 All users changed.
7718
7719 * ccl.c (Fccl_execute_on_string): Declare some variables
7720 EMACS_INT.
7721
8546720e 77222011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7723
7724 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7725
4e19a977
CS
77262011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7727
7728 * process.c (Fformat_network_address): Doc fix.
7729
87302331
R
77302011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7731
ee7683eb 7732 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7733
cbb59342
CY
77342011-04-08 Chong Yidong <cyd@stupidchicken.com>
7735
7736 * keyboard.c (read_char): Call Lisp function help-form-show,
7737 instead of using internal_with_output_to_temp_buffer.
7738 (Qhelp_form_show): New var.
e0d38eeb 7739 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7740
7741 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7742
7743 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7744
e67a13ab
CY
77452011-04-06 Chong Yidong <cyd@stupidchicken.com>
7746
04f2d78b
CB
7747 * process.c (Flist_processes): Remove to Lisp.
7748 (list_processes_1): Delete.
e67a13ab 7749
973f782d
EZ
77502011-04-06 Eli Zaretskii <eliz@gnu.org>
7751
7c106b1e
EZ
7752 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7753
973f782d
EZ
7754 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7755
41cf7d1a 77562011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7757
ca23cc88
PE
7758 Fix more problems found by GCC 4.6.0's static checks.
7759
f390e2d5
PE
7760 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7761
42eea0d0
PE
7762 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7763
b69769da 7764 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7765
f9541e84
PE
7766 * xdisp.c (vmessage): Mark as a printf-like function.
7767
13841b55
PE
7768 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7769
c136c10f
PE
7770 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7771
5e2d4a30
PE
7772 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7773 printf-like functions.
7774 (tiff_load): Add casts to remove these marks before passing them
7775 to system-supplied API.
7776
583f48b9
PE
7777 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7778
b25d760e
PE
7779 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7780 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7781 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7782 directly, rather than having caller test rule sign. This avoids
7783 some unnecessary tests.
7784 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7785 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7786 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7787
bc7b6697 7788 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7789 (xfont_open): Avoid unnecessary tests.
bc7b6697 7790
27ccc379
PE
7791 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7792
dcd5c89a
PE
7793 * composite.h, composite.c (composition_gstring_put_cache):
7794 Use EMACS_INT, not int, for length.
7795
b13a45c6
PE
7796 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7797 breaking out part of COMPOSITION_DECODE_RULE.
7798 (COMPOSITION_DECODE_RULE): Use it.
7799 * composite.c (get_composition_id): Remove unused local vars,
7800 by using the new macro.
7801
1e792e4d
PE
7802 * textprop.c (set_text_properties_1): Change while to do-while,
7803 since the condition is always true at first.
7804
dc6c6455 7805 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7806 (interval_deletion_adjustment): Return unsigned value.
7807 All uses changed.
dc6c6455 7808
aba7731a
PE
7809 * process.c (list_processes_1, create_pty, read_process_output):
7810 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7811 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7812 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7813 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7814 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7815
fdfc4bf3
PE
7816 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7817
fca8fe46 7818 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7819 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7820
06a0259a 7821 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7822 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7823 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7824
e7b9e80f
PE
7825 * print.c (print_error_message): Avoid int overflow.
7826
56201685
PE
7827 * font.c (font_list_entities): Redo for clarity,
7828 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7829
78834453 7830 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7831 (font_score): Avoid potential overflow in diff calculation.
78834453 7832
0bc0b309 7833 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7834 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7835
e610eaca
PE
7836 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7837
b895abce
PE
7838 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7839 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7840 can always succeed if overflow has undefined behavior.
7841
1f1d9321 7842 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7843 (wordify): Omit three unnecessary tests.
1f1d9321 7844
c59478bc
PE
7845 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7846 All callers changed. This avoids the need for an unused var.
7847
79b73827
PE
7848 * casefiddle.c (casify_region): Remove var that is set but not used.
7849
a4db5dfe
PE
7850 * dired.c (file_name_completion): Remove var that is set but not used.
7851
43aae36e
PE
7852 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7853
2a47c44d 7854 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7855 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7856
a37c69bf
PE
7857 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7858 Check for integer overflow on size calculations.
7859
328ab8e7
PE
7860 * buffer.c (Fprevious_overlay_change): Remove var that is set
7861 but not used.
7862
e5a2a5cb
PE
7863 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7864 Remove vars that are set but not used.
8d84a6eb 7865 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7866 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7867
a60e5f68
PE
7868 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7869
f661cb61 7870 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7871 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7872
f0397f5a
PE
7873 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7874 that are set but not used.
7875
8664db06 7876 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7877 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7878
6abdaa4a
PE
7879 * xselect.c (x_get_local_selection, x_handle_property_notify):
7880 Remove vars that are set but not used.
7881
0ce7538d 7882 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7883 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7884
9ae848fc
PE
7885 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7886 Remove var that is set but not used.
0b918413
PE
7887 (scroll_bar_windows_size): Now size_t, not int.
7888 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7889 Check for overflow.
9ae848fc 7890
a5a62657
PE
7891 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7892 (map_tty_color) [!defined MSDOS]: Likewise.
7893
5c5cdd39
PE
7894 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7895
66ebf983
PE
7896 * coding.c: Remove vars that are set but not used.
7897 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7898 All callers changed.
7899 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7900 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7901 (decode_coding_charset): Remove vars that are set but not used.
7902
1be4d761
PE
7903 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7904 that is set but not used.
7905
47553fa8
PE
7906 * print.c (print_object): Remove var that is set but not used.
7907
1f7196bf 7908 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7909 The gnulib version avoids calling malloc in the usual case,
7910 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7911 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7912 * filelock.c (current_lock_owner): Likewise.
7913 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7914 * sysdep.c: Include allocator.h, careadlinkat.h.
7915 (emacs_no_realloc_allocator): New static constant.
7916 (emacs_readlink): New function.
fdb61804
PE
7917 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7918 ../lib/careadlinkat.h.
d1fdcab7 7919
f84c17c7
SM
79202011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7921
7922 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7923 first non-nil return value).
7924
ef3862ad
JD
79252011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7926
7927 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7928 if not defined (Bug#8403).
7929
376a7006
JB
79302011-04-02 Juanma Barranquero <lekktu@gmail.com>
7931
7932 * xdisp.c (display_count_lines): Remove parameter `start',
7933 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7934 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7935 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7936 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7937 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7938 and thereabouts. All callers changed.
7939 (get_per_char_metric): Remove parameter `f', unused since
7940 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7941
6ca3801d
JM
79422011-04-02 Jim Meyering <meyering@redhat.com>
7943
7944 do not dereference NULL upon failed strdup
7945 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7946 (ns_get_family): Likewise.
7947
d8e2b5ba
JB
79482011-04-02 Juanma Barranquero <lekktu@gmail.com>
7949
7950 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7951
8c74fcbd
JD
79522011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7953
7954 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7955 later (Bug#8403).
7956
7200d79c
SM
79572011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7958
03408648 7959 Add lexical binding.
7200d79c 7960
03408648
SM
7961 * window.c (Ftemp_output_buffer_show): New fun.
7962 (Fsave_window_excursion):
7963 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7964
7965 * lread.c (lisp_file_lexically_bound_p): New function.
7966 (Fload): Bind Qlexical_binding.
7967 (readevalloop): Remove `evalfun' arg.
7968 Bind Qinternal_interpreter_environment.
7969 (Feval_buffer): Bind Qlexical_binding.
7970 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7971 Mark as dynamic.
7972 (syms_of_lread): Declare `lexical-binding'.
7973
7974 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7975
7976 * keyboard.c (eval_dyn): New fun.
7977 (menu_item_eval_property): Use it.
ca105506
SM
7978
7979 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7980
03408648
SM
7981 * fns.c (concat, mapcar1): Accept byte-code-functions.
7982
7983 * eval.c (Fsetq): Handle lexical vars.
7984 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7985 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7986 (FletX, Flet): Obey lexical binding.
7987 (Fcommandp): Handle closures.
7988 (Feval): New `lexical' arg.
7989 (eval_sub): New function extracted from Feval. Use it almost
7990 everywhere where Feval was used. Look up vars in lexical env.
7991 Handle closures.
7992 (Ffunctionp): Move from subr.el.
7993 (Ffuncall): Handle closures.
7994 (apply_lambda): Remove `eval_flags'.
7995 (funcall_lambda): Handle closures and new byte-code-functions.
7996 (Fspecial_variable_p): New function.
7997 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7998 but without exporting it to Lisp.
23aba0ea 7999
23aba0ea 8000 * doc.c (Fdocumentation, store_function_docstring):
03408648 8001 * data.c (Finteractive_form): Handle closures.
23aba0ea 8002
03408648
SM
8003 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8004 interactive spec.
ba83908c 8005
04f2d78b
CB
8006 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8007 New byte-codes.
03408648
SM
8008 (exec_byte_code): New function extracted from Fbyte_code to handle new
8009 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8010
03408648 8011 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8012
03408648 8013 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8014
e2abce01
JB
80152011-03-31 Juanma Barranquero <lekktu@gmail.com>
8016
8017 * xdisp.c (redisplay_internal): Fix prototype.
8018
63696a73 80192011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8020
63696a73 8021 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8022 (try_scrolling): Use it when setting scroll_limit.
8023 Limit scrolling to 100 screen lines.
63696a73
EZ
8024 (redisplay_window): Even when falling back on "recentering",
8025 position point in the window according to scroll-conservatively,
8026 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8027
8028 (try_scrolling): When point is above the window, allow searching
8029 as far as scroll_max, or one screenful, to compute vertical
8030 distance from PT to the scroll margin position. This prevents
8031 try_scrolling from unnecessarily failing when
8032 scroll-conservatively is set to a value slightly larger than the
8033 window height. Clean up the case of PT below the margin at bottom
8034 of window: scroll_max can no longer be INT_MAX. When aggressive
8035 scrolling is in use, don't let point enter the opposite scroll
8036 margin as result of the scroll.
8037 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8038 threshold of 100 lines for never-recentering scrolling.
8039
e4cc2dfc
JB
80402011-03-31 Juanma Barranquero <lekktu@gmail.com>
8041
8042 * dispextern.h (move_it_by_lines):
8043 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8044 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8045 (message_log_check_duplicate): Remove parameters `prev_bol' and
8046 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8047 (redisplay_internal): Remove parameter `preserve_echo_area',
8048 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8049
8050 * indent.c (Fvertical_motion):
8051 * window.c (window_scroll_pixel_based, Frecenter):
8052 Don't pass `need_y_p' to `move_it_by_lines'.
8053
1c470562
SM
80542011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8055
44f230aa
SM
8056 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8057 steal a few bits to be more compact.
8058 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8059 Remove unneeded casts.
8060
1c470562
SM
8061 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8062
888adce9
ZK
80632011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8064
8065 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8066 binding" message (bug#7967).
8067
f838ed7b
PE
80682011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8069
77861b95
PE
8070 Fix more problems found by GCC 4.6.0's static checks.
8071
de6dbc14
PE
8072 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8073 Remove unused local var.
8074
f838ed7b
PE
8075 * editfns.c (Fmessage_box): Remove unused local var.
8076
792c7b2b
PE
8077 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8078 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8079 Omit unused local vars.
c499e557 8080 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8081 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8082 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8083 Omit unused local var.
8084
ba0165e1
PE
8085 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8086 Don't assume string length fits in int.
32ad8845 8087 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8088 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8089
3c59b4c9
PE
8090 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8091 instead of alloca (Bug#8344).
8092
a3eed478 8093 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8094 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8095
eb4d412d
PE
8096 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8097
1658b401
PE
8098 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8099 concerns.
8100
8101 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8102
8103 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8104
9a2c6e05
PE
8105 * keyboard.c (syms_of_keyboard): Use the same style as later
8106 in this function when indexing through an array. This also
8107 works around GCC bug 48267.
8108
03d0a109
PE
8109 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8110
44f730c8
PE
8111 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8112
fe75f926
PE
8113 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8114 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8115
ffa8c828
PE
8116 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8117 This avoids undefined behavior on integer overflow, and is a bit
8118 more convenient anyway since it is compared to a size_t variable.
8119
c5101a77
PE
8120 Variadic C functions now count arguments with size_t, not int.
8121 This avoids an unnecessary limitation on 64-bit machines, which
8122 caused (substring ...) to crash on large vectors (Bug#8344).
8123 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8124 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8125 All variadic functions and their callers changed accordingly.
c5101a77
PE
8126 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8127 * data.c (arith_driver, float_arith_driver): Likewise.
8128 * editfns.c (general_insert_function): Likewise.
8129 * eval.c (struct backtrace.nargs, interactive_p)
8130 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8131 (funcall_lambda, mark_backtrace): Likewise.
8132 * fns.c (concat): Likewise.
8133 * frame.c (x_set_frame_parameters): Likewise.
8134 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8135 0 if not found, not -1. All callers changed.
8136
dd3f25f7
PE
8137 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8138 (stack_copy_size): Now size_t, not int.
8139 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8140
461c2ab9
JB
81412011-03-28 Juanma Barranquero <lekktu@gmail.com>
8142
8143 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8144 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8145 All callers changed.
8146
8147 * lisp.h (multibyte_char_to_unibyte):
8148 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8149 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8150 * character.h (CHAR_TO_BYTE8):
8151 * cmds.c (internal_self_insert):
8152 * editfns.c (general_insert_function):
8153 * keymap.c (push_key_description):
8154 * search.c (Freplace_match):
8155 * xdisp.c (message_dolog, set_message_1): All callers changed.
8156
f6d62986
SM
81572011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8158
8159 * keyboard.c (safe_run_hook_funcall): New function.
8160 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8161 don't set the hook to nil, but remove the offending function instead.
8162 (Qcommand_hook_internal): Remove, unused.
8163 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8164 Vcommand_hook_internal.
8165
8166 * eval.c (enum run_hooks_condition): Remove.
8167 (funcall_nil, funcall_not): New functions.
8168 (run_hook_with_args): Call each function through a `funcall' argument.
8169 Remove `cond' argument, now redundant.
8170 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8171 (Frun_hook_with_args_until_failure): Adjust accordingly.
8172 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8173
1db5b1ad
JB
81742011-03-28 Juanma Barranquero <lekktu@gmail.com>
8175
8176 * dispextern.h (string_buffer_position): Remove declaration.
8177
8178 * print.c (strout): Remove parameter `multibyte', unused since
8179 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8180
8181 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8182 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8183 All callers changed.
8184
8185 * w32.c (_wsa_errlist): Use braces for struct initializers.
8186
8187 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8188 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8189 All callers changed.
8190 (string_buffer_position): Likewise. Also, make static (it's never
8191 used outside xdisp.c).
8192 (cursor_row_p): Remove parameter `w', unused since
8193 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8194 (decode_mode_spec): Remove parameter `precision', introduced during
8195 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8196 All callers changed.
8197
5ffb62aa
JD
81982011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8199
8200 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8201
461c2ab9 82022011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8203
8204 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8205 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8206 (ns_update_auto_hide_menu_bar): New functions.
8207 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8208 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8209 ns_constrain_all_frames.
8210 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8211 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8212
5c380ffb
JD
82132011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8214
8215 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8216
9af30bdf
GM
82172011-03-27 Glenn Morris <rgm@gnu.org>
8218
8219 * syssignal.h: Replace RETSIGTYPE with void.
8220 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8221 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8222 Replace SIGTYPE with void everywhere.
8223 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8224 * s/template.h (SIGTYPE): Remove commented out definition.
8225
e2abce01
JB
82262011-03-26 Eli Zaretskii <eliz@gnu.org>
8227
8228 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8229 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8230
f868cd8a
JB
82312011-03-26 Juanma Barranquero <lekktu@gmail.com>
8232
59eb0929
JB
8233 * w32.c (read_unc_volume): Use parameter `henum', instead of
8234 global variable `wget_enum_handle'.
8235
8236 * keymap.c (describe_vector): Remove parameters `indices' and
8237 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8238 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8239
f868cd8a
JB
8240 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8241
8242 * keyboard.c (timer_check): Remove parameter `do_it_now',
8243 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8244 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8245 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8246
8247 * keyboard.c (read_char):
8248 * w32menu.c (w32_menu_display_help):
8249 * xmenu.c (show_help_event, menu_help_callback):
8250 Adjust calls to `show_help_echo'.
8251
8252 * gtkutil.c (xg_maybe_add_timer):
8253 * keyboard.c (readable_events):
8254 * process.c (wait_reading_process_output):
8255 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8256
8257 * insdel.c (adjust_markers_gap_motion):
8258 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8259 (gap_left, gap_right): Don't call it.
8260
2ecf6fdb
CY
82612011-03-25 Chong Yidong <cyd@stupidchicken.com>
8262
8263 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8264 incurred during fontification.
8265
6b1f9ba4
JB
82662011-03-25 Juanma Barranquero <lekktu@gmail.com>
8267
8268 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8269 (DEFVAR_PER_BUFFER): Don't pass it.
8270
8271 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8272 (scrolling_window): Don't pass it.
8273
0f4a96b5
JB
82742011-03-25 Juanma Barranquero <lekktu@gmail.com>
8275
8276 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8277
8278 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8279 and `suffix'.
8280 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8281 of variables specific to SELinux and computation of `encoded_absname'.
8282
8283 * image.c (XPutPixel): Remove unused variable `height'.
8284
8285 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8286
8287 * unexw32.c (get_section_info): Remove unused variable `section'.
8288
8289 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8290 (system_process_attributes): Remove unused variable `sess'.
8291 (sys_read): Remove unused variable `err'.
8292
8293 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8294 (w32_wnd_proc): Remove unused variable `isdead'.
8295 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8296 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8297 (x_create_tip_frame): Remove unused variable `tem'.
8298
8299 * w32inevt.c (w32_console_read_socket):
8300 Remove unused variable `no_events'.
8301
8302 * w32term.c (x_draw_composite_glyph_string_foreground):
8303 Remove unused variable `width'.
8304
1149507c
JB
83052011-03-24 Juanma Barranquero <lekktu@gmail.com>
8306
8307 * w32term.c (x_set_glyph_string_clipping):
8308 Don't pass uninitialized region to CombineRgn.
8309
9c88f339
JB
83102011-03-23 Juanma Barranquero <lekktu@gmail.com>
8311
8312 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8313 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8314 (Fx_close_connection): Remove unused variable `i'.
8315
8316 * w32font.c (w32font_draw): Return number of glyphs.
8317 (w32font_open_internal): Remove unused variable `i'.
8318 (w32font_driver): Add missing initializer.
8319
8320 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8321 (fill_in_menu): Remove unused variable `items_added'.
8322
8323 * w32term.c (last_mouse_press_frame): Remove static global variable.
8324 (w32_clip_to_row): Remove unused variable `f'.
8325 (x_delete_terminal): Remove unused variable `i'.
8326
8327 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8328 (NOTHING): Remove unused static global variable.
8329 (uniscribe_check_otf): Remove unused variable `table'.
8330 (uniscribe_font_driver): Add missing initializers.
8331
dee091a3
JD
83322011-03-23 Julien Danjou <julien@danjou.info>
8333
8334 * term.c (Fsuspend_tty, Fresume_tty):
8335 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8336 * window.c (temp_output_buffer_show):
8337 * insdel.c (signal_before_change):
8338 * frame.c (Fhandle_switch_frame):
8339 * fileio.c (Fdo_auto_save):
8340 * emacs.c (Fkill_emacs):
8341 * editfns.c (save_excursion_restore):
8342 * cmds.c (internal_self_insert):
8343 * callint.c (Fcall_interactively):
8344 * buffer.c (Fkill_all_local_variables):
8345 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8346 Use Frun_hooks.
0f4a96b5 8347 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8348 unconditionally since it does the check itself.
dee091a3 8349
2c520ab5 83502011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8351
c9c49752
PE
8352 Fix more problems found by GCC 4.5.2's static checks.
8353
8abc3f12
PE
8354 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8355 the first time through the loop, since we know p0 < p1 then.
8356 This also avoids a gcc -Wstrict-overflow warning.
8357
a2d26660
PE
8358 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8359 leading to a memory leak, possible in functions like
8360 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8361 of objects (Bug#8318).
a2d26660 8362
916c72e9
PE
8363 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8364 that could (at least in theory) be that large.
8365
19ab8a18
PE
8366 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8367 This is less likely to overflow, and avoids undefined behavior if
8368 overflow does occur. All callers changed. Use strtoul to scan
8369 for the unsigned long integer.
b7cbbd6f
PE
8370 (pint2hrstr): Simplify and tune code slightly.
8371 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8372
f0641eff
PE
8373 * scroll.c (do_scrolling): Work around GCC bug 48228.
8374 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8375
7f650bb9
PE
8376 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8377 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8378 (validate_x_resource_name): Simplify count usage.
8379 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8380
37dd57d1
PE
8381 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8382 fail (Bug#8306).
81e56e61 8383
699979fc 8384 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8385
401bf9b4
PE
8386 * process.c (Fmake_network_process): Use socklen_t, not int,
8387 where POSIX says socklen_t is required in portable programs.
8388 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8389 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8390 (Fmake_network_process, server_accept_connection):
8391 (wait_reading_process_output, read_process_output):
8392 Likewise.
8393
b93aacde
PE
8394 * process.c: Rename or move locals to avoid shadowing.
8395 (list_processes_1, Fmake_network_process):
8396 (read_process_output_error_handler, exec_sentinel_error_handler):
8397 Rename or move locals.
4dc343ee 8398 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8399 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8400 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8401 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8402 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8403
af8a867c 8404 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8405 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8406 Include tparam.h instead, since it declares them.
af8a867c
PE
8407 * cm.h (PC): Remove extern decl; tparam.h now does this.
8408 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8409 * terminfo.c: Include tparam.h, to check interfaces.
8410 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8411 (tparam): Adjust signature to match interface in tparam.h;
8412 this removes some undefined behavior. Check that outstring and len
8413 are zero, which they always are with Emacs.
8414 * tparam.h (PC, BC, UP): New extern decls.
8415
0248044d 8416 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8417 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8418
8ff096c1 8419 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8420 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8421 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8422 (ftfont_list): Remove unused local.
49eaafba
PE
8423 (get_adstyle_property, ftfont_pattern_entity):
8424 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8425 Rename locals to avoid shadowing.
8ff096c1 8426
e2be39f6
PE
8427 * xfont.c (xfont_list_family): Mark var as initialized.
8428
c9735e30
PE
8429 * xml.c (make_dom): Now static.
8430
8f5201ae
PE
8431 * composite.c (composition_compute_stop_pos): Rename local to
8432 avoid shadowing.
b246f932
PE
8433 (composition_reseat_it): Remove unused locals.
8434 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8435 (composition_update_it): Mark var as initialized.
11b61122
PE
8436 (find_automatic_composition): Mark vars as initialized,
8437 with a FIXME (Bug#8290).
8f5201ae 8438
760fbc2c
PE
8439 character.h: Rename locals to avoid shadowing.
8440 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8441 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8442 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8443 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8444 to avoid shadowing.
8445
ff08eb85
PE
8446 * textprop.c (property_change_between_p): Remove; unused.
8447
fc7bf025
PE
8448 * intervals.c (interval_start_pos): Now static.
8449
235d7abc
PE
8450 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8451
44f230aa
SM
8452 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8453 Rename locals to avoid shadowing.
3e7d6594 8454
50060332
PE
8455 * sound.c (wav_play, au_play, Fplay_sound_internal):
8456 Fix pointer signedness.
d01f234b 8457 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8458 (wav_play): Initialize a variable to 0, to prevent undefined
8459 behavior (Bug#8278).
50060332 8460
c4fc4e30
PE
8461 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8462
918436ed
PE
8463 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8464
c939f91b
PE
8465 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8466 clobbering (Bug#8298).
b9c7f648
PE
8467 * sysdep.c (sys_subshell): Likewise.
8468 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8469
6bd8c144
PE
8470 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8471 This should get cleaned up, so that child_setup has the
8472 same signature on all platforms.
8473
7710357c 8474 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8475 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8476
c59da222
CY
84772011-03-22 Chong Yidong <cyd@stupidchicken.com>
8478
8479 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8480 not to be necessary, and produces flickering.
8481
66b87493
GM
84822011-03-20 Glenn Morris <rgm@gnu.org>
8483
8484 * config.in: Remove file.
8485
45b6f6d5
JB
84862011-03-20 Juanma Barranquero <lekktu@gmail.com>
8487
8488 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8489 are now in src/globals.h.
8490 (syms_of_minibuf): Remove spurious & from previous change.
8491
cd394be1 84922011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8493
8494 * minibuf.c (completing-read-function): New variable.
8495 (completing-read-default): Rename from completing-read.
8496 (completing-read): Call completing-read-function.
8497
b14e3e21
CY
84982011-03-19 Juanma Barranquero <lekktu@gmail.com>
8499
8500 * xfaces.c (Fx_load_color_file):
8501 Read color file from absolute filename (bug#8250).
8502
f2b726e6
JB
85032011-03-19 Juanma Barranquero <lekktu@gmail.com>
8504
8505 * makefile.w32-in: Update dependencies.
8506
09f6ff02
EZ
85072011-03-17 Eli Zaretskii <eliz@gnu.org>
8508
8509 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8510
29a6015a
PE
85112011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8512
a3a6c54e
PE
8513 Fix more problems found by GCC 4.5.2's static checks.
8514
b766f867
PE
8515 * process.c (make_serial_process_unwind, send_process_trap):
8516 (sigchld_handler): Now static.
8517
be02381c
PE
8518 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8519 That way, the code declares only the vars that it needs.
8520 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8521 * s/cygwin.h (PTY_ITERATION): Likewise.
8522 * s/darwin.h (PTY_ITERATION): Likewise.
8523 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8524
57048744
PE
8525 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8526 * process.c (allocate_pty): Don't declare stb unless it's needed.
8527
7914961c 8528 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8529 (CONSTANTLIM): Remove; unused.
8530 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8531 Define only if needed.
7914961c 8532
b3967b18
PE
8533 * unexelf.c (unexec): Name an expression,
8534 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8535 Use a different way to cause a compilation error if anyone uses
8536 n rather than nn, a way that does not involve shadowing.
73366a00 8537 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8538
29a6015a
PE
8539 * deps.mk (unexalpha.o): Remove; unused.
8540
43cfc33e 8541 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8542 * unexec.h: New file.
ce701a33
PE
8543 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8544 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8545 Depend on unexec.h.
8546 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8547 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8548 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8549 Change as necessary to match prototype in unexec.h.
ce701a33 8550
01f44d5a
PE
8551 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8552 shadowing.
4f63c6bb 8553 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8554
a6670b0b
PE
8555 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8556 Rename locals to avoid shadowing.
8557
cef2010d 8558 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8559 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8560
d4d7173a
PE
8561 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8562
f08b802a
PE
8563 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8564 warning when compiling print.c.
8565
3ddb0639
PE
8566 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8567 instead of using an uninitialized var.
5ad03b97 8568 (font_sort_entities): Mark var as initialized.
3ddb0639 8569
170a2692
PE
8570 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8571
e663c700
PE
8572 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8573 pointers to constants.
89bc529a 8574 (font_parse_fcname): Remove unused vars.
7b81e2d0 8575 (font_delete_unmatched): Now static.
ea838e10 8576 (font_get_spec): Remove; unused.
13a547c6
PE
8577 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8578 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8579 Rename or move locals to avoid shadowing.
e663c700 8580
2a80c887 8581 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8582 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8583
1384fa33 8584 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8585 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8586
8b2c52e9
PE
8587 * alloc.c (mark_backtrace): Move decl from here ...
8588 * lisp.h: ... to here, so that it can be checked.
8589
475545b5 8590 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8591 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8592 (lisp_indirect_variable): Name an expression,
8593 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8594 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8595
b1349114 8596 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8597 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8598 Use const pointer when appropriate.
b1349114 8599
a2928364
PE
8600 * lisp.h (get_system_name, get_operating_system_release):
8601 Move decls here, to check interfaces.
8602 * process.c (get_operating_system_release): Move decl to lisp.h.
8603 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8604 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8605 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8606 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8607 (Fformat_time_string, Fencode_time, Finsert_char):
8608 (Ftranslate_region_internal, Fformat):
8609 Rename or remove local vars to avoid shadowing.
9710023e 8610 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8611
a415e694
PE
8612 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8613 avoid shadowing.
8614
8ef4622d
PE
8615 * lisp.h (eassert): Check that the argument compiles, even if
8616 ENABLE_CHECKING is not defined.
8617
946f9a5b
PE
8618 * data.c (Findirect_variable): Name an expression, to avoid
8619 gcc -Wbad-function-cast warning.
112396d6 8620 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8621 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8622 (Fmake_variable_buffer_local, Fmake_local_variable):
8623 Mark variables as initialized.
52746918 8624 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8625
e5aab7e7 8626 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8627 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8628 Rename locals to avoid shadowing.
dff45157
PE
8629 (mark_stack): Move local variables into the #ifdef region where
8630 they're used.
7bc26fdb
PE
8631 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8632 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8633 needed otherwise.
8634 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8635 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8636 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8637
e5aab7e7
PE
8638 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8639 avoids undefined behavior in theory.
8640
4da60324
PE
8641 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8642
88043301
PE
8643 Use functions, not macros, for up- and down-casing (Bug#8254).
8644 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8645 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8646 to use the following functions instead of these macros.
8647 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8648 EMACS_INT, since callers assume the returned value fits in int.
8649 (upcase1): Likewise, for UPCASE_TABLE.
8650 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8651 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8652 the race-condition problem in the old DOWNCASE.
88043301 8653
19ed5445
PE
8654 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8655 Rename locals to avoid shadowing.
8656 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8657 (regex_compile, re_search_2, re_match_2_internal):
8658 Remove unused local vars.
952db0d7
PE
8659 (FREE_VAR): Rewrite so as not to use empty "else",
8660 which gcc can warn about.
da053e48 8661 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8662 (RETALLOC_IF): Define only if needed.
8663 (WORDCHAR_P): Likewise. This one is never needed, but is used
8664 only in a comment talking about a compiler bug, so put inside
8665 the #if 0 of that comment.
8666 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8667 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8668 Remove; unused.
19ed5445 8669
1f3561e4 8670 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8671 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8672 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8673
ded6f8f7
PE
8674 * search.c (simple_search): Remove unused var.
8675
dbd37a95
PE
8676 * dired.c (compile_pattern): Move decl from here ...
8677 * lisp.h: ... to here, so that it can be checked.
8678 (struct re_registers): New forward decl.
8679
7e47afad
PE
8680 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8681
85f24f61
PE
8682 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8683 All uses changed.
8684 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8685 Rename locals to avoid shadowing.
5671df8f 8686 (Fvertical_motion): Mark locals as initialized.
85f24f61 8687
181aa2be 8688 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8689 (casify_region): Mark local as initialized.
181aa2be 8690
930d429c
PE
8691 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8692
7082eac6
PE
8693 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8694 New macros, so that the caller can use some names other than
8695 gcpro1, gcpro2, etc.
8696 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8697 of the new macros.
8698 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8699 argument, for consistency with GCPRO2_VAR, etc: it is now the
8700 prefix of the variable, not the variable itself. All uses
8701 changed.
38b2c076
PE
8702 * dired.c (directory_files_internal, file_name_completion):
8703 Rename locals to avoid shadowing.
8704
15206ed9
PE
8705 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8706 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8707 dired.c's scmp function, had undefined behavior.
8708 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8709 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8710 * buffer.h: ... to here, because these macros use current_buffer,
8711 and the new implementation with inline functions needs to have
8712 current_buffer in scope now, rather than later when the macros
8713 are used.
8714 (downcase, upcase1): New static inline functions.
8715 (DOWNCASE, UPCASE1): Reimplement using these functions.
8716 This avoids undefined behavior in expressions like
8717 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8718 from race conditions in accessing the global variables
8719 case_temp1 and case_temp2.
8720 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8721 * lisp.h (case_temp1, case_temp2): Remove their decls.
8722 * character.h (ASCII_CHAR_P): Move from here ...
8723 * lisp.h: ... to here, so that the inline functions mentioned
8724 above can use them.
8725
4a6bea26
PE
8726 * dired.c (directory_files_internal_unwind): Now static.
8727
f14b7e14
PE
8728 * fileio.c (file_name_as_directory, directory_file_name):
8729 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8730 Now static.
2893f146
PE
8731 (file_name_as_directory): Use const pointers when appropriate.
8732 (Fexpand_file_name): Likewise. In particular, newdir might
8733 point at constant storage, so make it a const pointer.
fd4ead52 8734 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8735 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8736 signedness issues.
f839df0c
PE
8737 (Fset_file_times, Finsert_file_contents, auto_save_error):
8738 Rename locals to avoid shadowing.
f14b7e14 8739
5716756e 8740 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8741 (Ftry_completion, Fall_completions): Rename or remove locals
8742 to avoid shadowing.
5716756e 8743
b4c3046a
PE
8744 * marker.c (bytepos_to_charpos): Remove; unused.
8745
b45db522
PE
8746 * lisp.h (verify_bytepos, count_markers): New decls,
8747 so that gcc does not warn that these functions aren't declared.
8748
85876d07
PE
8749 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8750 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8751 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8752 (copy_text): Remove unused local var.
85876d07 8753
03d78a21 8754 * filelock.c (within_one_second): Now static.
b3dd38ab 8755 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8756
5df8f01b
PE
8757 * buffer.c (fix_overlays_before): Mark locals as initialized.
8758 (fix_start_end_in_overlays): Likewise. This function should be
8759 simplified by using pointers-to-pointers, but that's a different
8760 matter.
b1d876f1 8761 (switch_to_buffer_1): Now static.
8f54f30a
PE
8762 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8763 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8764
a70072c9 8765 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8766 Fix pointer signedness issue.
edced198
PE
8767 (sys_subshell): Mark local as volatile if checking for lint,
8768 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8769 (MAXPATHLEN): Define only if needed.
a70072c9 8770
a0977c44
PE
8771 * process.c (serial_open, serial_configure): Move decls from here ...
8772 * systty.h: ... to here, so that they can be checked.
8773
a884fdcc
PE
8774 * fns.c (get_random, seed_random): Move extern decls from here ...
8775 * lisp.h: ... to here, so that they can be checked.
8776
604efe86 8777 * sysdep.c (reset_io): Now static.
b8950c94 8778 (wait_for_termination_signal): Remove; unused.
604efe86 8779
38fc62d9
PE
8780 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8781 (copy_keymap_item, append_key, push_text_char_description):
8782 Now static.
1004a21a 8783 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8784 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8785 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8786 (describe_map_tree):
8787 Rename locals to avoid shadowing.
38fc62d9 8788
2f2650da
PE
8789 * keyboard.c: Declare functions static if they are not used elsewhere.
8790 (echo_char, echo_dash, cmd_error, top_level_2):
8791 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8792 (read_char, kbd_buffer_get_event, make_lispy_position):
8793 (make_lispy_event, make_lispy_movement, apply_modifiers):
8794 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8795 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8796 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8797 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8798 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8799
a053e86c 8800 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8801 (mark_kboards): Move decl here ...
8802 * alloc.c (mark_kboards): ... from here.
a053e86c 8803
4752793e
PE
8804 * lisp.h (force_auto_save_soon): New decl.
8805
74f10ca7 8806 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8807 (DEFINE_DUMMY_FUNCTION): New macro.
8808 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8809 Use it.
c03cd23f
PE
8810 (main): Add casts to avoid warnings
8811 if GCC considers string literals to be constants.
74f10ca7 8812
022e70d4
PE
8813 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8814
59d6fe83
PE
8815 * dbusbind.c: Pointer signedness fixes.
8816 (xd_signature, xd_append_arg, xd_initialize):
8817 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8818 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8819 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8820 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8821
78320123
PE
8822 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8823 if GCC considers string literals to be constants.
49cebcca 8824 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8825
35ac2a97
SM
88262011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8827
fb103ca9
SM
8828 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8829 (print_preprocess, print_object): New macro to fix last change.
8830
35ac2a97
SM
8831 * print.c (print_preprocess): Don't forget font objects.
8832
62973b41
JB
88332011-03-16 Juanma Barranquero <lekktu@gmail.com>
8834
8835 * emacs.c (USAGE3): Doc fixes.
8836
0e48bb22
AS
88372011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8838
8839 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8840 structure.
8841
7684e57b
JB
88422011-03-14 Juanma Barranquero <lekktu@gmail.com>
8843
8844 * lisp.h (VWindow_system, Qfile_name_history):
8845 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8846 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8847 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8848
8849 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8850 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8851
8852 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8853 * w32console.c (detect_input_pending, read_input_pending)
8854 (encode_terminal_code):
8855 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8856 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8857 (w32_system_caret_y, Qfile_name_history):
8858 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8859 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8860 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8861 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8862 * w32proc.c (Qlocal, report_file_error):
8863 * w32term.c (Vwindow_system, updating_frame):
8864 * w32uniscribe.c (initialized, uniscribe_font_driver):
8865 Remove unneeded extern declarations.
8866
2aa46d6c
CY
88672011-03-14 Chong Yidong <cyd@stupidchicken.com>
8868
c96bbc66 8869 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8870
cffc6f3b
CY
88712011-03-13 Chong Yidong <cyd@stupidchicken.com>
8872
8873 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8874 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8875 These macros can no longer be used for assignment.
8876
44f230aa
SM
8877 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8878 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8879 (record_buffer_markers, fetch_buffer_markers): New functions for
8880 recording and fetching special buffer markers.
8881 (set_buffer_internal_1, set_buffer_temp): Use them.
8882
8883 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8884
8885 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8886
8887 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8888 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8889
8890 * xdisp.c (hscroll_window_tree):
8891 (reconsider_clip_changes): Use PT instead of BUF_PT.
8892
d251f04b
EZ
88932011-03-13 Eli Zaretskii <eliz@gnu.org>
8894
8895 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8896 $(EMACS_ROOT)/lib/intprops.h.
8897
f0c77cd1
PE
88982011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8899
3eca4629
PE
8900 Fix more problems found by GCC 4.5.2's static checks.
8901
7c86ee98
PE
8902 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8903 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8904 (xg_free_frame_widgets): Make it clear that a local variable is
8905 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8906 (gdk_window_get_screen): Make it clear that this macro is needed
8907 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8908 (int_gtk_range_get_value): New function, which avoids a diagnostic
8909 from gcc -Wbad-function-cast.
8910 (xg_set_toolkit_scroll_bar_thumb): Use it.
8911 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8912 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8913 (get_utf8_string, xg_get_file_with_chooser):
8914 Rename locals to avoid shadowing.
8915 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8916
41729b81
PE
8917 * xgselect.c (xg_select): Remove unused var.
8918
f0c77cd1
PE
8919 * image.c (four_corners_best): Mark locals as initialized.
8920 (gif_load): Initialize transparent_p to zero (Bug#8238).
8921 Mark another local as initialized.
ec6cf4c6 8922 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8923
ce0ad53d 8924 * image.c (clear_image_cache): Now static.
d5d5a617 8925 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8926 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8927 (x_edge_detection): Remove unnecessary cast that
8928 gcc -Wbad-function-cast diagnoses.
2037898d 8929 (gif_load): Fix pointer signedness.
6ae141d6
PE
8930 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8931 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8932
33383987 89332011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8934
d32df629
PE
8935 Improve quality of tests for time stamp overflow.
8936 For example, without this patch (encode-time 0 0 0 1 1
8937 1152921504606846976) returns the obviously-bogus value (-948597
8938 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8939 reports time overflow. See
8940 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8941 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8942 * editfns.c: Include limits.h and intprops.h.
8943 (TIME_T_MIN, TIME_T_MAX): New macros.
8944 (time_overflow): Move earlier, to before first use.
8945 (hi_time, lo_time): New functions, for an accurate test for
8946 out-of-range times.
8947 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8948 (Fget_internal_run_time): Don't assume time_t fits in int.
8949 (make_time): Use list2 instead of Fcons twice.
8950 (Fdecode_time): More accurate test for out-of-range times.
8951 (check_tm_member): New function.
8952 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8953 (lisp_time_argument): Don't rely on undefined left-shift and
8954 right-shift behavior when checking for time stamp overflow.
8be6f318 8955
fe31d94c
PE
8956 * editfns.c (time_overflow): New function, refactoring common code.
8957 (Fformat_time_string, Fdecode_time, Fencode_time):
8958 (Fcurrent_time_string): Use it.
8959
8be6f318
PE
8960 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8961 * dired.c (make_time): Move to ...
8962 * editfns.c (make_time): ... here.
8963 * systime.h: Note the move.
8964
09d9db2c 89652011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8966
126bc0dc
YM
8967 * fringe.c (update_window_fringes): Remove unused variables.
8968
c47cbdfd
YM
8969 * unexmacosx.c (copy_data_segment): Also copy __got section.
8970 (Bug#8223)
8971
7ac80be9
EZ
89722011-03-12 Eli Zaretskii <eliz@gnu.org>
8973
c96bbc66 8974 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8975 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8976 Constify `char *' arguments and their references according to
8977 prototypes in tparam.h.
8978
ecb0f94d 8979 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8980
7ac80be9
EZ
8981 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8982 Adapt all references accordingly.
8983
8984 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8985
ef1fd07e
TT
89862011-03-11 Tom Tromey <tromey@redhat.com>
8987
8988 * buffer.c (syms_of_buffer): Remove obsolete comment.
8989
7ef4b50c
EZ
89902011-03-11 Eli Zaretskii <eliz@gnu.org>
8991
8992 * termhooks.h (encode_terminal_code): Declare prototype.
8993
8994 * msdos.c (encode_terminal_code): Don't declare prototype.
8995
8996 * term.c (encode_terminal_code): Now external again, used by
8997 w32console.c and msdos.c.
8998
44f230aa
SM
8999 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9000 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9001
4b1ec863 90022011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9003
1714f52b 9004 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9005
4b1ec863
PE
9006 * fringe.c (update_window_fringes): Mark locals as initialized
9007 (Bug#8227).
9008 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9009
524c7aa6
PE
9010 * alloc.c (mark_fringe_data): Move decl from here ...
9011 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9012 to check its interface.
9013 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9014
a5c0af81 9015 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9016 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9017 (fontset_font): Mark local as initialized.
a9a06e0b 9018 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9019
b4716021
PE
9020 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9021
811e9bac 9022 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9023 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9024 (x_own_selection, Fx_disown_selection_internal): Rename locals
9025 to avoid shadowing.
9026 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9027
7e3ab302
PE
9028 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9029 so that the caller can use some name other than gcpro1.
9030 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9031 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9032 (Fx_backspace_delete_keys_p):
9033 Use them to avoid shadowing, and rename vars to avoid shadowing.
9034 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9035 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9036 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9037 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9038 Remove unused locals.
7e3ab302
PE
9039 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9040 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9041 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9042 macros.
f78faa98 9043
e2b13473
PE
9044 * xterm.h (x_mouse_leave): New decl.
9045
77f23912
PE
9046 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9047 Remove unused functions.
cdf4ba58
PE
9048 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9049 (x_calc_absolute_position): Now static.
7411c686 9050 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9051 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9052 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9053 unless they are used.
38d0b34a
PE
9054 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9055 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9056 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9057 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9058 (x_error_catcher, x_connection_closed, x_error_handler):
9059 (x_error_quitter, xembed_send_message, x_iconify_frame):
9060 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9061 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9062 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9063
44f230aa
SM
9064 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9065 Rename or move locals to avoid shadowing.
6b463e58 9066 (tty_defined_color, merge_face_heights): Now static.
5967d051 9067 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9068 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9069 does not deduce is never used uninitialized.
73719eba
PE
9070 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9071 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9072
426994c3 9073 * terminal.c (store_terminal_param): Now static.
5489860b 9074
032f1620 9075 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9076 (set_frame_menubar): Remove unused local.
d4323972 9077 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9078 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9079 since they might point to immutable storage.
281585b0
PE
9080 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9081 since it's unused otherwise.
032f1620 9082
367c19e5 9083 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9084 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9085 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9086 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9087 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9088 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9089 does not deduce are never used uninitialized.
70739cbe 9090
07b48fa9
PE
9091 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9092
8868a238 9093 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9094 * window.c (window_loop, size_window):
9095 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9096
7e5cf297 9097 * window.c (display_buffer): Now static.
d6550a9f
PE
9098 (size_window): Mark variables that gcc -Wuninitialized
9099 does not deduce are never used uninitialized.
a586633d
PE
9100 * window.h (check_all_windows): New decl, to forestall
9101 gcc -Wmissing-prototypes diagnostic.
5b555da1 9102 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9103
f6095868
PE
9104 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9105 shadowing.
9106 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9107 Include <limits.h>.
9108 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9109 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9110 (load_charset_map): Mark variables that gcc -Wuninitialized
9111 does not deduce are never used uninitialized.
53df7c11 9112 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9113
f38b440c
PE
9114 * coding.c (coding_set_source, coding_set_destination):
9115 Use "else { /* comment */ }" rather than "else /* comment */;"
9116 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9117 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9118 a block, when the outer 'i' will do.
9119 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9120 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9121 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9122 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9123 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9124 Rename locals to avoid shadowing.
9125 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9126 * coding.c (emacs_mule_char, encode_invocation_designation):
9127 Now static, since they're not used elsewhere.
413bb2db 9128 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9129 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9130 (decode_coding_emacs_mule): Mark variables that gcc
9131 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9132 (detect_coding_iso_2022): Initialize a local variable that might
9133 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9134 this initialization is needed. (Bug#8211)
5f58e762
PE
9135 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9136 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9137 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9138 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9139 Remove unused macros.
f38b440c 9140
232b38b9 9141 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9142 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9143 * character.c (string_count_byte8): Likewise.
232b38b9 9144
fb90da1b
PE
9145 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9146 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9147
fb93dbc2
PE
9148 * chartab.c (copy_sub_char_table): Now static, since it's not used
9149 elsewhere.
5c156ace
PE
9150 (sub_char_table_ref_and_range, char_table_ref_and_range):
9151 Rename locals to avoid shadowing.
bbcd0949 9152 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9153
7d3b3862 9154 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9155 (BIDI_BOB): Remove unused macro.
7d3b3862 9156
6be7d3da
PE
9157 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9158 deduce are never used uninitialized.
c2ed9c8b 9159 * term.c (encode_terminal_code): Likewise.
6be7d3da 9160
75f8807f 9161 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9162
50938595
PE
9163 * tparam.h: New file.
9164 * term.c, tparam.h: Include it.
9165 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9166 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9167 Move these decls to tparam.h, and make them agree with what
9168 is actually in tparam.c. The previous trick of using incompatible
9169 decls in different modules does not conform to the C standard.
9170 All callers of tparam changed to use tparam's actual API.
9171 * tparam.c (tparam1, tparam, tgoto):
9172 Use const pointers where appropriate.
9173
fbceeba2
PE
9174 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9175 * cm.h (struct cm): Likewise.
9176 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9177 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9178 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9179 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9180 (turn_on_face, init_tty): Likewise.
9181 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9182
7f3f1250
PE
9183 * term.c (term_mouse_position): Rename local to avoid shadowing.
9184
e6ca6543
PE
9185 * alloc.c (mark_ttys): Move decl from here ...
9186 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9187
c40f8d15
AS
91882011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9189
9190 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9191
cfe0661d
JB
91922011-03-09 Juanma Barranquero <lekktu@gmail.com>
9193
9194 * search.c (compile_pattern_1): Remove argument regp, unused since
9195 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9196 (compile_pattern): Don't pass it.
9197
0afb4571
J
91982011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9199
9200 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9201 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9202 for ! HAVE_GTK3.
9203 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9204
9205 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9206
9207 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9208 gdk_window_get_screen, gdk_window_get_geometry,
9209 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9210 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9211 (xg_get_pixbuf_from_pixmap): New function.
9212 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9213 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9214 Call xg_get_pixbuf_from_pixmap instead of
9215 gdk_pixbuf_get_from_drawable.
9216 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9217 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9218 (xg_check_special_colors): Use GtkStyleContext and its functions
9219 for HAVE_GTK3.
9220 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9221 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9222 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9223 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9224 Call gtk_widget_get_preferred_size.
0afb4571
J
9225 (xg_frame_resized): gdk_window_get_geometry only takes 5
9226 parameters.
44f230aa
SM
9227 (xg_win_to_widget, xg_event_is_for_menubar):
9228 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9229 (xg_set_widget_bg): New function.
9230 (delete_cb): New function.
895009e1 9231 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9232 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9233 (xg_set_background_color): Call xg_set_widget_bg.
9234 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9235 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9236 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9237 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9238 if ! HAVE_GTK3.
9239 (update_frame_tool_bar): Call gtk_widget_hide.
9240 (xg_initialize): Use GDK_KEY_g.
9241
9242 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9243 if ! HAVE_GTK3
9244 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9245
9246 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9247 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9248 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9249
1c2cc4ef
JB
92502011-03-08 Juanma Barranquero <lekktu@gmail.com>
9251
9252 * w32xfns.c (select_palette): Check success of RealizePalette against
9253 GDI_ERROR, not zero.
9254
33383987 9255See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9256
9257;; Local Variables:
9258;; coding: utf-8
aac0c6e3
MR
9259;; End:
9260
acaf905b 9261 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9262
9263 This file is part of GNU Emacs.
9264
9265 GNU Emacs is free software: you can redistribute it and/or modify
9266 it under the terms of the GNU General Public License as published by
9267 the Free Software Foundation, either version 3 of the License, or
9268 (at your option) any later version.
9269
9270 GNU Emacs is distributed in the hope that it will be useful,
9271 but WITHOUT ANY WARRANTY; without even the implied warranty of
9272 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9273 GNU General Public License for more details.
9274
9275 You should have received a copy of the GNU General Public License
9276 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.