* callproc.c (child_setup): Rewrite to avoid two strlen calls.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
eb49b136
PE
12011-06-19 Paul Eggert <eggert@cs.ucla.edu>
2
35016e9a
PE
3 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4
3d1e65a1
PE
5 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6 We prefer signed integers, even for size calculations.
7
0b963a93
PE
8 * emacs.c: Don't assume string length fits in 'int'.
9 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
10 (main): Don't invoke strlen when not needed.
11
573f4b54
PE
12 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
13 (XD_DEBUG_MESSAGE): Don't waste a byte.
14
989f33ba
PE
15 * callproc.c (getenv_internal_1, getenv_internal)
16 (Fgetenv_internal):
965d34eb
PE
17 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
18
e4d29b33
PE
19 * lread.c (invalid_syntax): Omit length argument.
20 All uses changed. This doesn't fix a bug, but it simplifies the
21 code away from its former Hollerith-constant appearance, and it's
22 one less 'int' to worry about when looking at integer-overflow issues.
f14ed477 23 (string_to_number): Simplify the 2011-04-26 change by invoking xsignal1.
e4d29b33 24
eb49b136
PE
25 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
26 This didn't break anything, but it didn't help either.
27 It's confusing to put a bogus integer in a place where the actual
28 value does not matter.
9f62aeb1 29 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 30 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 31
e39e811e
PE
322011-06-18 Paul Eggert <eggert@cs.ucla.edu>
33
15375a22
PE
34 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
35 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
36 implementation.
b61cc01c
PE
37 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
38 We prefer signed types, and the value cannot exceed the EMACS_INT
39 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
40 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
41 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
42 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 43
53b2623d
PE
44 * indent.c (sane_tab_width): New function.
45 (current_column, scan_for_column, Findent_to, position_indentation)
46 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 47 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 48
45aebb64
PE
49 * image.c (xbm_image_p): Don't assume stated width and height fit in int.
50
f2ed8a70
PE
51 * lisp.h (lint_assume): New macro.
52 * composite.c (composition_gstring_put_cache):
53 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
54
abe80cc6
PE
55 * editfns.c, insdel.c:
56 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 57
b02c740e
PE
58 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
59
ebc96716
PE
60 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
61
b4e50fa0 62 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 63 Use much-faster test for byte-length change.
311d5d7c 64 Don't assume string byte-length fits in 'int'.
a4cf38e4 65 Check that character arg fits in 'int'.
85461888 66 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 67
c0c1ee9f
PE
68 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
69
a498d7f4
PE
70 * fns.c (concat): Catch string overflow earlier.
71 Do not rely on integer wraparound.
72
e39e811e
PE
73 * dispextern.h (struct it.overlay_strings_charpos): EMACS_INT, not int.
74
fadf4e30
PE
752011-06-17 Paul Eggert <eggert@cs.ucla.edu>
76
87830974
PE
77 * dispextern.h (struct it.selective): Now EMACS_INT, not int.
78 * xdisp.c (forward_to_next_line_start)
79 (back_to_previous_visible_line_start)
80 (reseat_at_next_visible_line_start, next_element_from_buffer):
81 Don't arbitrarily truncate the value of 'selective' to int.
82
76031fad
PE
83 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
84
5eb55db9
PE
85 * composite.c: Don't truncate sizes to 'int'.
86 (composition_gstring_p, composition_reseat_it)
87 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
88 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
89 not EMACS_UINT, for indexes.
5eb55db9 90
0703a717
PE
91 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
92
d6202519
PE
93 * buffer.c: Include <verify.h>.
94 (struct sortvec.priority, struct sortstr.priority):
8961a454 95 Now EMACS_INT, not int.
c20998a7 96 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
97 (struct sortstr.size, record_overlay_string)
98 (struct sortstrlist.size, struct sortlist.used):
99 Don't truncate size to int.
100 (record_overlay_string): Check for size-calculation overflow.
d6202519 101 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 102
28177add
PE
1032011-06-16 Paul Eggert <eggert@cs.ucla.edu>
104
dd3482fe
PE
105 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
106 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
107 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
108
393d71f3 109 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
110 * fileio.c (Finsert_file_contents):
111 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
112 Remove the old (too-loose) buffer overflow checks.
113 They weren't needed, since make_gap checks for buffer overflow.
114 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
115 The old code merely checked for Emacs fixnum overflow, and relied
116 on undefined (wraparound) behavior. The new code avoids undefined
117 behavior, and also checks for ptrdiff_t and/or size_t overflow.
118
2e6813b0 119 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
120 Tune. Don't use wider integers than needed. Don't use alloca.
121 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 122
599a9e4f
PE
123 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
124
99561444
PE
125 * insdel.c, lisp.h (buffer_overflow): New function.
126 (insert_from_buffer_1, replace_range, replace_range_2):
127 * insdel.c (make_gap_larger):
128 * editfns.c (Finsert_char):
129 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
130
28177add
PE
131 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
132
e69dafad
PE
1332011-06-15 Paul Eggert <eggert@cs.ucla.edu>
134
a7af7fde 135 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 136
b1c46f02
PE
137 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
138 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
139
e69dafad
PE
140 * fileio.c: Don't assume EMACS_INT fits in off_t.
141 (emacs_lseek): New static function.
142 (Finsert_file_contents, Fwrite_region): Use it.
143 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
144
566684ea
PE
145 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
146
e6966cd6
PE
147 * fns.c: Don't overflow int when computing a list length.
148 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
149 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
150 truncation on 64-bit hosts. Check for QUIT every
151 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
152 faster and is responsive enough.
153 (Flength): Report an error instead of overflowing an integer.
154 (Fsafe_length): Return a float if the value is not representable
155 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 156 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 157 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 158
dd0b0efb
PE
159 * alloc.c: Check that resized vectors' lengths fit in fixnums.
160 (header_size, word_size): New constants.
161 (allocate_vectorlike): Don't check size overflow here.
162 (allocate_vector): Check it here instead, since this is the only
163 caller of allocate_vectorlike that could cause overflow.
164 Check that the new vector's length is representable as a fixnum.
165
86fe5cfe
PE
166 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
167 The previous code was bogus. For example, next_almost_prime (32)
168 returned 39, which is undesirable as it is a multiple of 3; and
169 next_almost_prime (24) returned 25, which is a multiple of 5 so
170 why was the code bothering to check for multiples of 7?
171
80e88859
PE
172 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
173
4a2f0ad6
PE
174 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
175
f66c7cf8
PE
176 Variadic C functions now count arguments with ptrdiff_t.
177 This partly undoes my 2011-03-30 change, which replaced int with size_t.
178 Back then I didn't know that the Emacs coding style prefers signed int.
179 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
180 were being counted with int, which may truncate counts on 64-bit
181 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
182 * lisp.h (struct Lisp_Subr.function.aMANY)
183 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
184 Arg counts are now ptrdiff_t, not size_t.
185 All variadic functions and their callers changed accordingly.
186 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
187 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
188 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
189 * callint.c (Fcall_interactively): Check arg count for overflow,
190 to avoid potential buffer overrun. Use signed char, not 'int',
191 for 'varies' array, so that we needn't bother to check its size
192 calculation for overflow.
193 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
194 * eval.c (apply_lambda):
195 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
196 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
197 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
198
a1759b76
PE
199 * callint.c (Fcall_interactively): Don't use index var as event count.
200
d96be9fc
PE
201 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
202 * mem-limits.h (SIZE): Remove; no longer used.
203
a690a978 204 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 205
578c21e6
PE
206 Remove unnecessary casts.
207 * xterm.c (x_term_init):
208 * xfns.c (x_set_border_pixel):
209 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
210 These aren't needed now that we assume ANSI C.
211
96f53c6c
PE
212 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
213 It's more likely to cause problems (due to unsigned overflow)
214 than to cure them.
215
83c77d31
PE
216 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
217
ee2079f1
PE
218 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
219
6da65536
PE
220 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
221
7147c4a4
PE
222 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
223
193e32d9
PE
224 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
225
e5533da6
PE
226 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
227
9910e595
PE
228 GLYPH_CODE_FACE returns EMACS_INT, not int.
229 * dispextern.h (merge_faces):
230 * xfaces.c (merge_faces):
01103c44
PE
231 * xdisp.c (get_next_display_element, next_element_from_display_vector):
232 Don't assume EMACS_INT fits in int.
9910e595 233
2638320e
PE
234 * character.h (CHAR_VALID_P): Remove unused parameter.
235 * fontset.c, lisp.h, xdisp.c: All uses changed.
236
045eb8d9
PE
237 * editfns.c (Ftranslate_region_internal): Omit redundant test.
238
c1f134b5
PE
239 * fns.c (concat): Minor tuning based on overflow analysis.
240 This doesn't fix any bugs. Use int to hold character, instead
241 of constantly refetching from Emacs object. Use XFASTINT, not
242 XINT, for value known to be a character. Don't bother comparing
243 a single byte to 0400, as it's always less.
244
395fcb93 245 * floatfns.c (Fexpt):
327eeec8
PE
246 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
247
abbd3d23
PE
248 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
249 for characters.
250
684a03ef
PE
251 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
252
0fed43f3
PE
253 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
254 Without this fix, on a 64-bit host (aset S 0 4294967386) would
255 incorrectly succeed when S was a string, because 4294967386 was
256 truncated before it was used.
257
8fd02eb7
PE
258 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
259 Otherwise, an out-of-range integer could cause undefined behavior
260 on a 64-bit host.
261
f8c86b69
PE
262 * composite.c: Use int, not EMACS_INT, for characters.
263 (fill_gstring_body, composition_compute_stop_pos): Use int, not
264 EMACS_INT, for values that are known to be in character range.
265 This doesn't fix any bugs but is the usual style inside Emacs and
266 may generate better code on 32-bit machines.
267
34206dd2
PE
268 Make sure a 64-bit char is never passed to ENCODE_CHAR.
269 This is for reasons similar to the recent CHAR_STRING fix.
270 * charset.c (Fencode_char): Check that character arg is actually
271 a character. Pass an int to ENCODE_CHAR.
272 * charset.h (ENCODE_CHAR): Verify that the character argument is no
273 wider than 'int', as a compile-time check to prevent future regressions
274 in this area.
275
c5958d4c 276 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
277
278 Make sure a 64-bit char is never passed to CHAR_STRING.
279 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
280 by silently ignoring the top 32 bits, allowing some values
281 that were far too large to be valid characters.
282 * character.h: Include <verify.h>.
283 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
284 arguments are no wider than unsigned, as a compile-time check
285 to prevent future regressions in this area.
286 * data.c (Faset):
01103c44 287 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
288 (Fsubst_char_in_region):
289 * fns.c (concat):
290 * xdisp.c (decode_mode_spec_coding):
291 Adjust to CHAR_STRING's new requirement.
292 * editfns.c (Finsert_char, Fsubst_char_in_region):
293 * fns.c (concat): Check that character args are actually
294 characters. Without this test, these functions did the wrong
295 thing with wildly out-of-range values on 64-bit hosts.
296
d37ca623
PE
297 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
298 These casts should not be needed on 32-bit hosts, either.
299 * keyboard.c (read_char):
300 * lread.c (Fload): Remove casts to unsigned.
301
ea204efb
PE
302 * lisp.h (UNSIGNED_CMP): New macro.
303 This fixes comparison bugs on 64-bit hosts.
304 (ASCII_CHAR_P): Use it.
305 * casefiddle.c (casify_object):
01103c44 306 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
307 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
308 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
309 * dispextern.h (FACE_FROM_ID):
310 * keyboard.c (read_char): Use UNSIGNED_CMP.
311
41cb286c
PE
312 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
313 not to EMACS_INT, to avoid GCC warning.
314
4a1b9832
PE
315 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
316
55daad71
PE
317 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
318 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
319 isn't needed on 32-bit machines.
8f95c75c 320
01103c44
PE
321 * buffer.c (Fgenerate_new_buffer_name):
322 Use EMACS_INT for count, not int.
0ceccced 323 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
324
325 * data.c (Qcompiled_function): Now static.
326
c6f072e7
PE
327 * window.c (window_body_lines): Now static.
328
20ce5912
PE
329 * image.c (gif_load): Rename local to avoid shadowing.
330
9c4c5f81
PE
331 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
332 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
333 * alloc.c (make_save_value): Integer argument is now of type
334 ptrdiff_t, not int.
335 (mark_object): Use ptrdiff_t, not int.
336 * lisp.h (pD): New macro.
337 * print.c (print_object): Use it.
338
c0c5c8ae
PE
339 * alloc.c: Use EMACS_INT, not int, to count objects.
340 (total_conses, total_markers, total_symbols, total_vector_size)
341 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
342 (total_free_floats, total_floats, total_free_intervals)
343 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
344 Now EMACS_INT, not int. All uses changed.
345 (Fgarbage_collect): Compute overall total using a double, so that
346 integer overflow is less likely to be a problem. Check for overflow
347 when converting back to an integer.
5a25e253
PE
348 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
349 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
350 These were 'int' variables that could overflow on 64-bit hosts;
351 they were never used, so remove them instead of repairing them.
211a0b2a 352 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
353 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
354 Previously, this ceilinged at INT_MAX, but that doesn't work on
355 64-bit machines.
e46bb31a 356 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 357
c78baabf 358 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 359 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
360 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
361 when a (possibly-narrower) signed value would do just as well.
362 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 363
c9d624c6
PE
364 * alloc.c: Catch some string size overflows that we were missing.
365 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
366 for convenience in STRING_BYTES_MAX.
367 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
368 The definition here is exact; the one in lisp.h was approximate.
369 (allocate_string_data): Check for string overflow. This catches
370 some instances we weren't catching before. Also, it catches
371 size_t overflow on (unusual) hosts where SIZE_MAX <= min
372 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
373 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 374
c9d624c6
PE
375 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
376 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
377 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
378
353032ce
PE
379 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
380
2bccce07
PE
381 * alloc.c (Fmake_string): Check for out-of-range init.
382
0ac30604
SM
3832011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
384
385 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
386
c195f2de
JD
3872011-06-14 Jan Djärv <jan.h.d@swipnet.se>
388
389 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
390 xg_get_default_scrollbar_width.
391
392 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
393 (int_gtk_range_get_value): Move to the scroll bar part of the file.
394 (style_changed_cb): Call update_theme_scrollbar_width and call
395 x_set_scroll_bar_default_width and xg_frame_set_char_size for
396 all frames (Bug#8505).
397 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
398 Call gtk_window_set_resizable if HAVE_GTK3.
399 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
400 and height if HAVE_GTK3 (Bug#8505).
401 (scroll_bar_width_for_theme): New variable.
402 (update_theme_scrollbar_width): New function.
403 (xg_get_default_scrollbar_width): Move code to
404 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
405 (xg_initialize): Call update_theme_scrollbar_width.
406
407 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
408
409 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
410
e10ac9f1
MR
4112011-06-12 Martin Rudalics <rudalics@gmx.at>
412
413 * frame.c (make_frame): Call other_buffer_safely instead of
414 other_buffer.
415
416 * window.c (temp_output_buffer_show): Call display_buffer with
417 second argument Vtemp_buffer_show_specifiers and reset latter
418 immediately after the call.
419 (Vtemp_buffer_show_specifiers): New variable.
420 (auto_window_vscroll_p, next_screen_context_lines)
421 (Vscroll_preserve_screen_position): Remove leading asterisks from
422 doc-strings.
423
2d3c217e 4242011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 425
7b7f97e8 426 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
427 * buffer.c (Qclone_number): Remove for now, as it's unused.
428 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
429 (record_buffer): Remove unused local.
430 * frame.c (other_visible_frames, frame_buffer_list): Now static.
431 (set_frame_buffer_list): Remove; unused.
432 * frame.h (other_visible_frames): Remove decl.
433 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
434 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
435 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
436 if HAVE_GPM.
437 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
438 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
439 Define only if HAVE_GPM.
440 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
441 (update_hints_inhibit): Remove; never set. All uses removed.
442 * widgetprv.h (emacsFrameClassRec): Remove decl.
443 * window.c (delete_deletable_window): Now returns void, since it
444 wasn't returning anything.
445 (compare_window_configurations): Remove unused locals.
446 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
447 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
448 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
449 the same widths as pointers. This follows up on the 2011-05-06 patch.
450 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
451 * xterm.h: Likewise.
452 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
453
1384b89e
JB
4542011-06-12 Juanma Barranquero <lekktu@gmail.com>
455
456 * makefile.w32-in: Update dependencies.
457 (LISP_H): Add lib/intprops.h.
458
1100a63c
CY
4592011-06-11 Chong Yidong <cyd@stupidchicken.com>
460
461 * image.c (gif_load): Add animation frame delay to the metadata.
462 (syms_of_image): Use DEFSYM. New symbol `delay'.
463
6198ccd0
MR
4642011-06-11 Martin Rudalics <rudalics@gmx.at>
465
466 * window.c (delete_deletable_window): Re-add.
467 (Fset_window_configuration): Rewrite to handle dead buffers and
468 consequently deletable windows.
469 (window_tree, Fwindow_tree): Remove. Supply functionality in
470 window.el.
471 (compare_window_configurations): Simplify code.
472
b6e3633c
AS
4732011-06-11 Andreas Schwab <schwab@linux-m68k.org>
474
1ab0dee5
AS
475 * image.c (imagemagick_load_image): Fix type mismatch.
476 (Fimagemagick_types): Likewise.
477
b6e3633c
AS
478 * window.h (replace_buffer_in_windows): Declare.
479
9397e56f
MR
4802011-06-11 Martin Rudalics <rudalics@gmx.at>
481
482 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
483 Qclone_number. Remove external declaration of Qdelete_window.
484 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
485 code.
486 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
487 Qbuffer_list_update_hook if allowed.
488 (Fother_buffer): Rewrite doc-string. Major rewrite for new
489 buffer list implementation.
490 (other_buffer_safely): New function.
491 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
492 calls to replace_buffer_in_windows and
493 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
494 if allowed.
495 (record_buffer): Inhibit quitting and rewrite using quittable
496 functions. Run Qbuffer_list_update_hook if allowed.
497 (Frecord_buffer, Funrecord_buffer): New functions.
498 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
499 switch-to-buffer to window.el.
500 (bury-buffer): Move to window.el.
501 (Vbuffer_list_update_hook): New variable.
502
503 * lisp.h (other_buffer_safely): Add prototype in buffer.c
504 section.
505
506 * window.h (resize_frame_windows): Move up in code.
507 (Fwindow_frame): Remove EXFUN.
508 (replace_buffer_in_all_windows): Remove prototype.
509 (replace_buffer_in_windows_safely): Add prototype.
510
511 * window.c: Declare Qdelete_window static again. Move down
512 declaration of select_count.
513 (Fnext_window, Fprevious_window): Rewrite doc-strings.
514 (Fother_window): Move to window.el.
515 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
516 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
517 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
518 window.el.
519 (replace_buffer_in_windows): Implement by calling
520 Qreplace_buffer_in_windows.
521 (replace_buffer_in_all_windows): Remove with some functionality
522 moved into replace_buffer_in_windows_safely.
523 (replace_buffer_in_windows_safely): New function.
524 (select_window_norecord, select_frame_norecord): Move in front
525 of run_window_configuration_change_hook. Remove now obsolete
526 declarations.
527 (Fset_window_buffer): Rewrite doc-string. Call
528 Qrecord_window_buffer.
529 (keys_of_window): Move binding for other-window to window.el.
530
b50691aa
CY
5312011-06-11 Chong Yidong <cyd@stupidchicken.com>
532
533 * dispextern.h (struct image): Replace data member, whose int_val
534 and ptr_val fields were not used by anything, with a single
535 lisp_val object.
536
537 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
538 (gif_clear_image, gif_load, imagemagick_load_image)
539 (gs_clear_image, gs_load): Callers changed.
540
3f754b86
PE
5412011-06-10 Paul Eggert <eggert@cs.ucla.edu>
542
cca69397
PE
543 * buffer.h: Include <time.h>, for time_t.
544 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
545
109e28d0
PE
546 Fix minor problems found by static checking.
547
60737f02
PE
548 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
549
4b66faf3
PE
550 Make identifiers static if they are not used in other modules.
551 * data.c (Qcompiled_function, Qframe, Qvector):
552 * image.c (QimageMagick, Qsvg):
553 * minibuf.c (Qmetadata):
554 * window.c (resize_window_check, resize_root_window): Now static.
555 * window.h (resize_window_check, resize_root_window): Remove decls.
556
109e28d0
PE
557 * window.c (window_deletion_count, delete_deletable_window):
558 Remove; unused.
46a4ce9e
PE
559 (window_body_lines): Now static.
560 (Fdelete_other_windows_internal): Mark vars as initialized.
561 Make sure 'resize_failed' is initialized.
562 (run_window_configuration_change_hook): Rename local to avoid shadowing.
563 (resize_window_apply): Remove unused local.
564 * window.h (delete_deletable_window): Remove decl.
565
109e28d0 566 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
567 (imagemagick_load_image): Fix pointer signedness problem by changing
568 last arg from unsigned char * to char *. All uses changed.
569 Also, fix a local for similar reasons.
570 Remove unused locals. Remove locals to avoid shadowing.
571 (fn_rsvg_handle_free): Remove; unused.
572 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 573 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 574
3f754b86
PE
575 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
576
2547adb1
CY
5772011-06-10 Chong Yidong <cyd@stupidchicken.com>
578
579 * image.c (gif_load): Fix omitted cast error introduced by
580 2011-06-06 change.
581
2c8e37d4
MR
5822011-06-10 Martin Rudalics <rudalics@gmx.at>
583
584 * window.h (resize_proportionally, orig_total_lines)
585 (orig_top_line): Remove from window structure.
586 (set_window_height, set_window_width, change_window_heights)
587 (Fdelete_window): Remove prototypes.
588 (resize_frame_windows): Remove duplicate declaration.
589
440a42e3
EZ
5902011-06-10 Eli Zaretskii <eliz@gnu.org>
591
592 * window.h (resize_frame_windows, resize_window_check)
593 (delete_deletable_window, resize_root_window)
594 (resize_frame_windows): Declare prototypes.
595
596 * window.c (resize_window_apply): Make definition be "static" to
597 match the prototype.
598
562dd5e9
MR
5992011-06-10 Martin Rudalics <rudalics@gmx.at>
600
601 * window.c: Remove declarations of Qwindow_size_fixed,
602 window_min_size_1, window_min_size_2, window_min_size,
603 size_window, window_fixed_size_p, enlarge_window, delete_window.
604 Remove static from declaration of Qdelete_window, it's
605 temporarily needed by Fbury_buffer.
606 (replace_window): Don't assign orig_top_line and
607 orig_total_lines.
608 (Fdelete_window, delete_window): Remove. Window deletion is
609 handled by window.el.
610 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
611 Fdelete_window calls with calls to Qdelete_window.
612 (Fdelete_other_windows): Remove. Deleting other windows is
613 handled by window.el.
614 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
615 handled in window.el.
616 (window_min_size_2, window_min_size_1, window_min_size): Remove.
617 Window minimum sizes are handled in window.el.
618 (shrink_windows, size_window, set_window_height)
619 (set_window_width, change_window_heights, window_height)
620 (window_width, CURBEG, CURSIZE, enlarge_window)
621 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
622 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
623 handled in window.el.
624 (make_dummy_parent): Rename to make_parent_window and give it a
625 second argument horflag.
626 (make_window): Don't set resize_proportionally any more.
627 (Fsplit_window): Remove. Windows are split in window.el.
628 (save_restore_action, save_restore_orig_size)
629 (shrink_window_lowest_first, save_restore_orig_size): Remove.
630 Resize mini windows in window.el.
631 (grow_mini_window, shrink_mini_window): Implement by calling
632 Qresize_root_window_vertically, resize_window_check and
633 resize_window_apply.
634 (saved_window, Fset_window_configuration, save_window_save): Do
635 not handle orig_top_line, orig_total_lines, and
636 resize_proportionally.
637 (window_min_height, window_min_width): Move to window.el.
638 (keys_of_window): Move bindings for delete-other-windows,
639 split-window, delete-window and enlarge-window to window.el.
640
641 * buffer.c: Temporarily extern Qdelete_window.
642 (Fbury_buffer): Temporarily call Qdelete_window instead of
643 Fdelete_window (Fbury_buffer will move to window.el soon).
644
645 * frame.c (set_menu_bar_lines_1): Remove code handling
646 orig_top_line and orig_total_lines.
647
648 * dispnew.c (adjust_frame_glyphs_initially): Don't use
649 set_window_height but set heights directly.
650 (change_frame_size_1): Use resize_frame_windows.
651
652 * xdisp.c (init_xdisp): Don't use set_window_height but set
653 heights directly.
654
655 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
656 resize_frame_windows instead of change_window_heights and run
657 run_window_configuration_change_hook.
658
659 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
660 instead of change_window_heights and run
661 run_window_configuration_change_hook.
662
1a13852e
MR
6632011-06-09 Martin Rudalics <rudalics@gmx.at>
664
665 * window.c (replace_window): Rename second argument REPLACEMENT to
666 NEW. New third argument SETFLAG. Rewrite.
667 (delete_window, make_dummy_parent): Call replace_window with
668 third argument 1.
669 (window_list_1): Move down in code.
670 (run_window_configuration_change_hook): Move set_buffer part
671 before select_frame_norecord part in order to unwind correctly.
672 Rename count1 to count.
673 (recombine_windows, delete_deletable_window, resize_root_window)
674 (Fdelete_other_windows_internal)
675 (Frun_window_configuration_change_hook, make_parent_window)
676 (resize_window_check, resize_window_apply, Fresize_window_apply)
677 (resize_frame_windows, Fsplit_window_internal)
678 (Fdelete_window_internal, Fresize_mini_window_internal): New
679 functions.
680 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
681
f3d1777e
MR
6822011-06-08 Martin Rudalics <rudalics@gmx.at>
683
496e208e
MR
684 * window.h (window): Add some new members to window structure -
685 normal_lines, normal_cols, new_total, new_normal, clone_number,
686 splits, nest, prev_buffers, next_buffers.
687 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 688 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 689
f3d1777e
MR
690 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
691 Remove.
496e208e
MR
692 (make_dummy_parent): Set new members of windows structure.
693 (make_window): Move down in code. Handle new members of window
694 structure.
695 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
696 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
697 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
698 (Fset_window_prev_buffers, Fwindow_next_buffers)
699 (Fset_window_next_buffers, Fset_window_clone_number): New
700 functions.
701 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
702 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
703 Doc-string fixes.
704 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
705 Argument WINDOW can be now internal window too.
706 (Fwindow_use_time): Move up in code.
707 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
708 Rewrite doc-string.
709 (Fset_window_configuration, saved_window)
710 (Fcurrent_window_configuration, save_window_save): Handle new
711 members of window structure.
b9e809c2
MR
712 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
713 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
714 (syms_of_window): New Lisp objects Qrecord_window_buffer,
715 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
716 Qget_mru_window, Qresize_root_window,
717 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
718 Qauto_buffer_name; staticpro them.
f3d1777e 719
abde8f8c
MR
7202011-06-07 Martin Rudalics <rudalics@gmx.at>
721
722 * window.c (Fwindow_total_size, Fwindow_left_column)
723 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
724 (Fwindow_list_1): New functions.
725 (window_box_text_cols): Replace with window_body_cols.
726 (Fwindow_width, Fscroll_left, Fscroll_right): Use
727 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
728 (delete_window, Fset_window_configuration): Call
729 delete_all_subwindows with window as argument.
730 (delete_all_subwindows): Take a window as argument and not a
731 structure. Rewrite.
190b47e6
MR
732 (window_loop): Remove handling of GET_LRU_WINDOW and
733 GET_LARGEST_WINDOW.
734 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
735
736 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
737 window_box_text_cols. delete_all_subwindows now takes a
738 Lisp_Object as argument.
abde8f8c
MR
739
740 * indent.c (compute_motion, Fcompute_motion): Use
741 window_body_cols instead of window_box_text_cols.
742
fa8a67e6
MR
743 * frame.c (delete_frame): Call delete_all_subwindows with root
744 window as argument.
745
a54e3482
DC
7462011-06-07 Daniel Colascione <dan.colascione@gmail.com>
747
748 * fns.c (Fputhash): Document return value.
749
60002bf5
CY
7502011-06-06 Chong Yidong <cyd@stupidchicken.com>
751
752 * image.c (gif_load): Implement gif89a spec "no disposal" method.
753
0c671da6 7542011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 755
b862a52a 756 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 757
be44ca6c
PE
758 Check for overflow when converting integer to cons and back.
759 * charset.c (Fdefine_charset_internal, Fdecode_char):
760 Use cons_to_unsigned to catch overflow.
761 (Fencode_char): Use INTEGER_TO_CONS.
762 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
763 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
764 * data.c (long_to_cons, cons_to_long): Remove.
765 (cons_to_unsigned, cons_to_signed): New functions.
766 These signal an error for invalid or out-of-range values.
767 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
768 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
769 * font.c (Ffont_variation_glyphs):
770 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
771 * lisp.h: Include <intprops.h>.
772 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
773 (cons_to_signed, cons_to_unsigned): New decls.
774 (long_to_cons, cons_to_long): Remove decls.
775 * undo.c (record_first_change): Use INTEGER_TO_CONS.
776 (Fprimitive_undo): Use CONS_TO_INTEGER.
777 * xfns.c (Fx_window_property): Likewise.
778 * xselect.c: Include <limits.h>.
779 (x_own_selection, selection_data_to_lisp_data):
780 Use INTEGER_TO_CONS.
781 (x_handle_selection_request, x_handle_selection_clear)
782 (x_get_foreign_selection, Fx_disown_selection_internal)
783 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
784 (lisp_data_to_selection_data): Use cons_to_unsigned.
785 (x_fill_property_data): Use cons_to_signed.
786 Report values out of range.
787
d1f3d2af
PE
788 Check for buffer and string overflow more precisely.
789 * buffer.h (BUF_BYTES_MAX): New macro.
790 * lisp.h (STRING_BYTES_MAX): New macro.
791 * alloc.c (Fmake_string):
792 * character.c (string_escape_byte8):
793 * coding.c (coding_alloc_by_realloc):
794 * doprnt.c (doprnt):
795 * editfns.c (Fformat):
796 * eval.c (verror):
797 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
798 since they may not be the same number.
799 * editfns.c (Finsert_char):
800 * fileio.c (Finsert_file_contents):
801 Likewise for BUF_BYTES_MAX.
802
dd52fcea
PE
803 * image.c: Use ptrdiff_t, not int, for sizes.
804 (slurp_file): Switch from int to ptrdiff_t.
805 All uses changed.
806 (slurp_file): Check that file size fits in both size_t (for
807 malloc) and ptrdiff_t (for sanity and safety).
808
7f9bbdbb
PE
809 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
810 if b->modtime has its maximal value.
811
dfe18f82
PE
812 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
813
84acfcf0
PE
814 Don't assume time_t can fit into int.
815 * buffer.h (struct buffer.modtime): Now time_t, not int.
816 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
817 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
818
ccd9a01a
PE
819 Minor fixes for signed vs unsigned integers.
820 * character.h (MAYBE_UNIFY_CHAR):
821 * charset.c (maybe_unify_char):
822 * keyboard.c (read_char, reorder_modifiers):
823 XINT -> XFASTINT, since the integer must be nonnegative.
824 * ftfont.c (ftfont_spec_pattern):
825 * keymap.c (access_keymap, silly_event_symbol_error):
826 XUINT -> XFASTINT, since the integer must be nonnegative.
827 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
828 since it makes no difference and we prefer signed.
829 * keyboard.c (record_char): Use XUINT when all the neighbors do.
830 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
831 nonnegative.
832
d6d100dd
SM
8332011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
834
835 * window.h (Fwindow_frame): Declare.
836
2b6148e4
PE
8372011-06-06 Paul Eggert <eggert@cs.ucla.edu>
838
839 * alloc.c: Simplify handling of large-request failures (Bug#8800).
840 (SPARE_MEMORY): Always define.
841 (LARGE_REQUEST): Remove.
842 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
843
f230ecc9
MR
8442011-06-06 Martin Rudalics <rudalics@gmx.at>
845
727e958e
MR
846 * lisp.h: Move EXFUNS for Fframe_root_window,
847 Fframe_first_window and Fset_frame_selected_window to window.h.
848
849 * window.h: Move EXFUNS for Fframe_root_window,
850 Fframe_first_window and Fset_frame_selected_window here from
851 lisp.h.
852
853 * frame.c (Fwindow_frame, Fframe_first_window)
854 (Fframe_root_window, Fframe_selected_window)
855 (Fset_frame_selected_window): Move to window.c.
856 (Factive_minibuffer_window): Move to minibuf.c.
857 (Fother_visible_frames_p): New function.
858
859 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
860
f230ecc9
MR
861 * window.c (decode_window, decode_any_window): Move up in code.
862 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
863 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
864 (Fwindow_buffer): Move up and rewrite doc-string.
865 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
866 (Fwindow_prev): New functions.
727e958e
MR
867 (Fwindow_frame): Move here from frame.c. Accept any window as
868 argument.
869 (Fframe_root_window, Fframe_first_window)
870 (Fframe_selected_window): Move here from frame.c. Accept frame
871 or arbitrary window as argument. Update doc-strings.
872 (Fminibuffer_window): Move up in code.
873 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
874 (Fset_frame_selected_window): Move here from frame.c.
875 Marginal rewrite.
727e958e
MR
876 (Fselected_window, select_window, Fselect_window): Move up in
877 code. Minor doc-string fixes.
f230ecc9 878
4d09bcf6
PE
8792011-06-06 Paul Eggert <eggert@cs.ucla.edu>
880
881 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
882 Do not assume that spare memory exists; that assumption is valid
883 only if SYSTEM_MALLOC.
884 (LARGE_REQUEST): New macro, so that the issue of large requests
885 is separated from the issue of spare memory.
886
810928a2
AS
8872011-06-05 Andreas Schwab <schwab@linux-m68k.org>
888
172418ad
AS
889 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
890 format. (Bug#8806)
891
43f862f7
AS
892 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
893
810928a2
AS
894 * xfns.c (x_set_scroll_bar_default_width): Move declarations
895 before statements.
896
a059fe24
JD
8972011-06-05 Jan Djärv <jan.h.d@swipnet.se>
898
899 * gtkutil.c (xg_get_default_scrollbar_width): New function.
900
901 * gtkutil.h: Declare xg_get_default_scrollbar_width.
902
903 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
904 min width by calling x_set_scroll_bar_default_width (Bug#8505).
905
989bf368
JB
9062011-06-05 Juanma Barranquero <lekktu@gmail.com>
907
908 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
909
4b80f674
CY
9102011-06-04 Chong Yidong <cyd@stupidchicken.com>
911
912 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
913 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
914 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
915 New error handlers.
4b80f674
CY
916 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
917 Obey Vx_select_enable_clipboard_manager. Catch errors in
918 x_clipboard_manager_save (Bug#8779).
919 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 920 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 921
99a33b77 9222011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
923
924 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
925
99a33b77 9262011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
927
928 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
929 in the current matrix if keep_current_p is non-zero.
930
8264569d
EZ
9312011-06-04 Eli Zaretskii <eliz@gnu.org>
932
933 * bidi.c (bidi_level_of_next_char): Fix last change.
934
57f97249
EZ
9352011-06-03 Eli Zaretskii <eliz@gnu.org>
936
fec2107c 937 Support bidi reordering of text covered by display properties.
57f97249 938
fec2107c
EZ
939 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
940 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
941 (bidi_cache_search, bidi_cache_iterator_state)
942 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
943 (bidi_level_of_next_char, bidi_move_to_visually_next):
944 Support character positions inside a run of characters covered by a
fec2107c
EZ
945 display string.
946 (bidi_paragraph_init, bidi_resolve_explicit_1)
947 (bidi_level_of_next_char): Call bidi_fetch_char and
948 bidi_fetch_char_advance instead of FETCH_CHAR and
949 FETCH_CHAR_ADVANCE.
950 (bidi_init_it): Initialize new members.
951 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
952 definitions.
953 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
954 instead of using explicit *_CHAR codes.
d6d100dd
SM
955 (bidi_resolve_explicit, bidi_resolve_weak):
956 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
957 bidirectional text is supported only in multibyte buffers.
958 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
959 it to initialize the frame_window_p member of struct bidi_it.
960 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
961 (bidi_resolve_explicit, bidi_resolve_weak)
962 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
963 bidi_it->nchars is non-positive.
964 (bidi_level_of_next_char): Don't try to lookup the cache for the
965 next/previous character if nothing is cached there yet, or if we
966 were just reseat()'ed to a new position.
c40e2fb2 967
0e14fe90
EZ
968 * xdisp.c (set_cursor_from_row): Set start and stop points
969 according to the row's direction when priming the loop that looks
970 for the glyph on which to display cursor.
971 (single_display_spec_intangible_p): Function deleted.
972 (display_prop_intangible_p): Reimplement to call
973 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
974 Accept 3 additional arguments needed by handle_display_spec.
975 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
976 values: lists, `(when COND...)' forms, etc.
977 (single_display_spec_string_p): Support property values that are
978 lists with the argument STRING its top-level element.
979 (display_prop_string_p): Fix the condition for processing a
980 property that is a list to be consistent with handle_display_spec.
fec2107c 981 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
982 last portion of handle_display_prop.
983 (compute_display_string_pos): Accept additional argument
984 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
985 value of a `display' property is a "replacing spec".
986 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
987 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
988 the display property, but just return a value indicating whether
989 the display property will replace the characters it covers.
990 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
991 frame_window_p members of struct bidi_it.
d6d100dd
SM
992 (compute_display_string_pos, compute_display_string_end):
993 New functions.
fec2107c
EZ
994 (push_it): Accept second argument POSITION, where pop_it should
995 jump to continue iteration.
996 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 997
fec2107c
EZ
998 * keyboard.c (adjust_point_for_property): Adjust the call to
999 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1000
1001 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1002 (bidi_init_it): Update prototypes.
1003 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1004 (compute_display_string_pos, compute_display_string_end):
1005 Declare prototypes.
fec2107c
EZ
1006 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1007 EMACS_INT.
fc6f18ce 1008
40087514 10092011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1010
57f53182
PE
1011 Malloc failure behavior now depends on size of allocation.
1012 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1013 * lisp.h: Change signatures accordingly.
1014 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1015 All callers changed. (Bug#8762)
1016
1017 * gnutls.c: Use Emacs's memory allocators.
1018 Without this change, the gnutls library would invoke malloc etc.
1019 directly, which causes problems on non-SYNC_INPUT hosts, and which
1020 runs afoul of improving memory_full behavior. (Bug#8761)
1021 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1022 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1023 xfree instead of the default malloc, realloc, free.
1024 (Fgnutls_boot): No need to check for memory allocation failure,
1025 since xmalloc does that for us.
1026
ac32cd99 1027 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1028 * category.c (hash_get_category_set):
1029 * ccl.c (ccl_driver):
1030 * charset.c (Fdefine_charset_internal):
1031 * charset.h (struct charset.hash_index):
1032 * composite.c (get_composition_id, gstring_lookup_cache)
1033 (composition_gstring_put_cache):
1034 * composite.h (struct composition.hash_index):
1035 * dispextern.h (struct image.hash):
1036 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1037 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1038 (hashfn_equal, hashfn_user_defined, make_hash_table)
1039 (maybe_resize_hash_table, hash_lookup, hash_put)
1040 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1041 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1042 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1043 * image.c (make_image, search_image_cache, lookup_image)
1044 (xpm_put_color_table_h):
1045 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1046 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1047 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1048 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1049 * alloc.c (allocate_vectorlike):
1050 Check for overflow in vector size calculations.
1051 * ccl.c (ccl_driver):
1052 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1053 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1054 need to be updated by these changes.
40087514
PE
1055 * fns.c (make_hash_table, maybe_resize_hash_table):
1056 Check for integer overflow with large hash tables.
0de4bb68
PE
1057 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1058 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1059 (SXHASH_REDUCE): New macro.
1060 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1061 Use it instead of discarding useful hash info with large hash values.
1062 (sxhash_float): New function.
1063 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1064 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1065 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1066 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1067 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1068 Adjust signatures to match updated version of code.
1069 (consing_since_gc): Now EMACS_INT, since a single hash table can
1070 use more than INT_MAX bytes.
1071
698d32e2
DN
10722011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1073
1074 Make it possible to build with GCC-4.6+ -O2 -flto.
1075
1076 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1077
fd6fa53f
SM
10782011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1079
1080 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1081 Call minibuffer-inactive-mode.
1082
864db017
JB
10832011-05-31 Juanma Barranquero <lekktu@gmail.com>
1084
1085 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1086 Update dependencies.
1087
2ad0baf4
DN
10882011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1089
1090 * data.c (init_data): Remove code for UTS, this system is not
1091 supported anymore.
1092
4fcc2638
DN
10932011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1094
1095 Don't force ./temacs to start in terminal mode.
1096
1097 * frame.c (make_initial_frame): Initialize faces in all cases, not
1098 only when CANNOT_DUMP is defined.
1099 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1100
c56e0fd5
DN
11012011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1102
1103 * dispnew.c (add_window_display_history): Use const for the string
1104 pointer. Remove declaration, not needed.
1105
333d54da 11062011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1107
55d4c1b2 1108 Use 'inline', not 'INLINE'.
333d54da 1109 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1110 * alloc.c, fontset.c (INLINE): Remove.
1111 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1112 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1113 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1114 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1115 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1116
738db178
DN
11172011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1118
1119 Make it possible to run ./temacs.
1120
1121 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1122 syms_of_callproc does the same thing. Remove test for
1123 "initialized", do it in the caller.
1124 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1125
620c53a6
SM
11262011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1127
1128 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1129 (read_minibuf): Use get_minibuffer.
1130 (syms_of_minibuf): Use DEFSYM.
1131 (Qmetadata): New var.
1132 * data.c (Qbuffer): Don't make it static.
1133 (syms_of_data): Use DEFSYM.
1134
e003a292
PE
11352011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1136
1137 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1138 (CCL_CODE_MIN): New macro.
1139
ed008a6d
PE
11402011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1141
3687c2ef
PE
1142 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1143
ed008a6d
PE
1144 * eval.c (Qdebug): Now static.
1145 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1146 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1147 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1148
d66c4c7c
CY
11492011-05-29 Chong Yidong <cyd@stupidchicken.com>
1150
1151 * image.c: Various fixes to ImageMagick code comments.
1152 (Fimagemagick_types): Doc fix.
1153
5fbc2025
PE
11542011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1155
0196f88a
PE
1156 Minor fixes prompted by GCC 4.6.0 warnings.
1157
1158 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1159
5fbc2025
PE
1160 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1161 (x_clipboard_manager_save_all): Move extern decl to ...
1162 * xterm.h: ... here, so that it can be checked for consistency.
1163
1dd3c2d9
CY
11642011-05-29 Chong Yidong <cyd@stupidchicken.com>
1165
1166 * xselect.c (x_clipboard_manager_save_frame)
1167 (x_clipboard_manager_save_all): New functions.
1168 (Fx_clipboard_manager_save): Lisp function deleted.
1169
1170 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1171 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1172
1173 * xterm.h: Update prototype.
1174
5ba6571d
WX
11752011-05-28 William Xu <william.xwl@gmail.com>
1176
1177 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1178 exiting (Bug#8239).
1179
3eaff834
JM
11802011-05-28 Jim Meyering <meyering@redhat.com>
1181
e1900994 1182 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1183 * fns.c (to_uchar): Define.
1184 (crypto_hash_function): Use it to convert some newly-signed
1185 variables to unsigned, to avoid sign-extension bugs. For example,
1186 without this change, (md5 "truc") would evaluate to
1187 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1188 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1189 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1190
0f6990a7
PE
11912011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1192
1193 Integer overflow fixes.
c8a9ca5a 1194
08686060
PE
1195 * dbusbind.c: Serial number integer overflow fixes.
1196 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1197 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1198 to hold a serial number that is too large for a fixnum.
1199 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1200 Check for serial numbers out of range. Decode any serial number
59568bf0 1201 that was so large that it became a float. (Bug#8722)
08686060 1202
2d1fc3c7
PE
1203 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1204 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1205 Use XFASTINT rather than XUINT when numbers are nonnegative.
1206 (xd_append_arg, Fdbus_method_return_internal):
1207 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1208 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1209 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1210 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1211 (Bug#8722)
2d1fc3c7 1212
c8a9ca5a
PE
1213 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1214
519e1d69
PE
1215 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1216
30569699
PE
1217 ccl: add integer overflow checks
1218 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1219 (IN_INT_RANGE): New macros.
1220 (ccl_driver): Use them to check for integer overflow when
1221 decoding a CCL program. Many of the new checks are whether XINT (x)
1222 fits in int; it doesn't always, on 64-bit hosts. The new version
1223 doesn't catch all possible integer overflows, but it's an
847044ea 1224 improvement. (Bug#8719)
30569699 1225
c11285dc
PE
1226 * alloc.c (make_event_array): Use XINT, not XUINT.
1227 There's no need for unsigned here.
1228
fdccd48e
PE
1229 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1230 This follows up to the 2011-05-06 change that substituted uintptr_t
1231 for EMACS_INT. This case wasn't caught back then.
1232
37910ab2
PE
1233 Rework Fformat to avoid integer overflow issues.
1234 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1235 now (part of C89). Include <verify.h>.
1236 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1237 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1238 (Fformat): Avoid the prepass trying to compute sizes; it was only
1239 approximate and thus did not catch overflow reliably. Instead, walk
1240 through the format just once, formatting and computing sizes as we go,
1241 checking for integer overflow at every step, and allocating a larger
1242 buffer as needed. Keep track separately whether the format is
1243 multibyte. Keep only the most-recently calculated precision, rather
1244 than them all. Record whether each argument has been converted to
1245 string. Use EMACS_INT, not int, for byte and char and arg counts.
1246 Support field widths and precisions larger than INT_MAX. Avoid
1247 sprintf's undefined behavior with conversion specifications such as %#d
1248 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1249 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1250 formatting out-of-range floating point numbers with int
1251 formats. (Bug#8668)
1252
2e6578fb
PE
1253 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1254
0ae6bdee
PE
1255 * data.c: Avoid integer truncation in expressions involving floats.
1256 * data.c: Include <intprops.h>.
1257 (arith_driver): When there's an integer overflow in an expression
1258 involving floating point, convert the integers to floating point
1259 so that the resulting value does not suffer from catastrophic
1260 integer truncation. For example, on a 64-bit host (* 4
1261 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1262 Do not rely on undefined behavior after integer overflow.
1263
de883a70
PE
1264 merge count_size_as_multibyte, parse_str_to_multibyte
1265 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1266 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1267 Check for integer overflow.
1268 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1269 since it's now a duplicate of the other. This is more of
1270 a character than a buffer op, so better that it's in character.c.
1271 * fns.c, print.c: Adjust to above changes.
1272
2ff916cb
PE
12732011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1274
1275 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1276
f1b54466
PE
12772011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1278
fb1ac845
PE
1279 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1280 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1281 (x_clipboard_manager_save): Now static.
1282 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1283
f1b54466
PE
1284 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1285 (crypto_hash_function): Now static.
1286 Fix pointer signedness problems. Avoid unnecessary initializations.
1287
a9f737ee
CY
12882011-05-27 Chong Yidong <cyd@stupidchicken.com>
1289
1290 * termhooks.h (Vselection_alist): Make it terminal-local.
1291
1292 * terminal.c (create_terminal): Initialize it.
1293
1294 * xselect.c: Support for clipboard managers.
1295 (Vselection_alist): Move to termhooks.h as terminal-local var.
1296 (LOCAL_SELECTION): New macro.
1297 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1298 (symbol_to_x_atom): Remove gratuitous arg.
1299 (x_handle_selection_request, lisp_data_to_selection_data)
1300 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1301 (x_own_selection, x_get_local_selection, x_convert_selection):
1302 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1303 (some_frame_on_display): Delete unused function.
1304 (Fx_own_selection_internal, Fx_get_selection_internal)
1305 (Fx_disown_selection_internal, Fx_selection_owner_p)
1306 (Fx_selection_exists_p): New optional frame arg.
1307 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1308 (x_handle_selection_clear): Don't treat other terminals with the
1309 same keyboard specially. Use the terminal-local Vselection_alist.
1310 (x_clear_frame_selections): Use Frun_hook_with_args.
1311
1312 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1313
1314 * xterm.h: Add support for those atoms.
1315
e067f0c1
CY
13162011-05-26 Chong Yidong <cyd@stupidchicken.com>
1317
1318 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1319 (converted_selections, conversion_fail_tag): New global variables.
1320 (x_selection_request_lisp_error): Free the above.
1321 (x_get_local_selection): Remove unnecessary code.
1322 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1323 of converted selections stored in converted_selections.
1324 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1325 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1326 (x_convert_selection): New function.
1327 (x_handle_selection_event): Simplify.
1328 (x_get_foreign_selection): Don't ignore incoming requests while
1329 waiting for an answer; this will fail when we implement
1330 SAVE_TARGETS, and seems unnecessary anyway.
1331 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1332 (Vx_sent_selection_functions): Doc fix.
1333
0f4aebc0
LL
13342011-05-26 Leo Liu <sdl.web@gmail.com>
1335
1336 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1337
e61124cd
YM
13382011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1339
1340 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1341
1342 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1343 for fringe update if it has periodic bitmap.
1344 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1345 and fringe_bitmap_periodic_p.
1346
1347 * fringe.c (get_fringe_bitmap_data): New function.
1348 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1349 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1350 row. Mark glyph row for fringe update if periodicity changed.
1351
1352 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1353 for fringe update unless it has periodic bitmap.
1354
f16d9837
KH
13552011-05-25 Kenichi Handa <handa@m17n.org>
1356
1357 * xdisp.c (get_next_display_element): Set correct it->face_id for
1358 a static composition.
1359
e1b90ef6
LL
13602011-05-24 Leo Liu <sdl.web@gmail.com>
1361
1362 * deps.mk (fns.o):
1363 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1364
1365 * fns.c (crypto_hash_function, Fsha1): New function.
1366 (Fmd5): Use crypto_hash_function.
1367 (syms_of_fns): Add Ssha1.
1368
7400048f
PE
13692011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1370
1371 * gnutls.c: Remove unused macros.
1372 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1373 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1374 Remove macros that are defined and never used.
1375 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1376
abb71cf4
CY
13772011-05-22 Chong Yidong <cyd@stupidchicken.com>
1378
1379 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1380 (Fx_get_selection_internal): Minor cleanup.
1381 (Fx_own_selection_internal): Rename arguments for consistency with
1382 select.el.
1383
6307db39
PE
13842011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1385
1386 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1387
f3d4e0a4
CY
13882011-05-22 Chong Yidong <cyd@stupidchicken.com>
1389
1390 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1391
4d8ade89
YM
13922011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1393
1394 * dispnew.c (scrolling_window): Don't exclude the case that the
1395 last enabled row in the desired matrix touches the bottom boundary.
1396
32078c8d
GM
13972011-05-21 Glenn Morris <rgm@gnu.org>
1398
1399 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1400 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1401 and add some more files.
32078c8d 1402
7285dc67
EZ
14032011-05-20 Eli Zaretskii <eliz@gnu.org>
1404
1405 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1406 report_file_error introduced by the change from 2011-05-07.
1407
89d1bd22
PE
14082011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1409
1410 * systime.h (Time): Define only if emacs is defined.
1411 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1412 where the include path doesn't have X11/X.h by default. See
1413 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1414
e23640bb 14152011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1416
1417 * composite.c (find_automatic_composition): Fix previous change.
1418
b9704ad9
GM
14192011-05-20 Glenn Morris <rgm@gnu.org>
1420
1421 * lisp.mk: New file, split from Makefile.in.
1422 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1423 (shortlisp): Remove.
1424 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1425
4a720484
GM
14262011-05-19 Glenn Morris <rgm@gnu.org>
1427
1428 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1429 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1430 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1431 (lisp): Set the order to that of loadup.el.
1432 (shortlisp): Make it a copy of $lisp.
1433 (SOME_MACHINE_LISP): Remove.
1434 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1435 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1436
a28d4396
KH
14372011-05-18 Kenichi Handa <handa@m17n.org>
1438
1439 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1440 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1441 (find_automatic_composition): Mostly rewrite for efficiency.
1442
a2b1fa8e
JB
14432011-05-18 Juanma Barranquero <lekktu@gmail.com>
1444
1445 * makefile.w32-in: Update dependencies.
1446
8e1f5610
CS
14472011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1448
1449 * menu.c: Include limits.h (fixes the MS-Windows build broken by
fadf4e30 1450 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 1451
7025ee00 14522011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1453
cdfa6eab
PE
1454 Fix some integer overflow issues, such as string length overflow.
1455
06d6db33
PE
1456 * insdel.c (count_size_as_multibyte): Check for string overflow.
1457
2b4560a8
PE
1458 * character.c (lisp_string_width): Check for string overflow.
1459 Use EMACS_INT, not int, for string indexes and lengths; in
1460 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1461 the resulting string length overflows an EMACS_INT; instead,
1462 report a string overflow if no precision given. When checking for
1463 precision exhaustion, use a check that cannot possibly have
1464 integer overflow. (Bug#8675)
1465 * character.h (lisp_string_width): Adjust to new signature.
1466
cb93f9be
PE
1467 * alloc.c (string_overflow): New function.
1468 (Fmake_string): Use it. This doesn't change behavior, but saves
1469 a few bytes and will simplify future changes.
1470 * character.c (string_escape_byte8): Likewise.
1471 * lisp.h (string_overflow): New decl.
1472
1a1f3366
PE
1473 Fixups, following up to the user-interface timestamp change.
1474 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1475 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1476 * msdos.c (mouse_get_pos): Likewise.
1477 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1478 * w32gui.h (Time): Define by including "systime.h" rather than by
1479 declaring it ourselves. (Bug#8664)
1480
d4e3e4d3
PE
1481 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1482 * image.c (clear_image_cache): Likewise.
1483
f6a24d19
PE
1484 * term.c (term_mouse_position): Don't assume time_t wraparound.
1485
08dc5ae6
PE
1486 Be more systematic about user-interface timestamps.
1487 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1488 and sometimes 'EMACS_UINT', to represent these timestamps.
1489 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1490 This makes the code easier to follow, and makes it easier to catch
1491 integer overflow bugs such as Bug#8664.
1492 * frame.c (Fmouse_position, Fmouse_pixel_position):
1493 Use Time, not unsigned long, for user-interface timestamps.
1494 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1495 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1496 * keyboard.h (last_event_timestamp): Likewise.
1497 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1498 * menu.h (xmenu_show): Likewise.
1499 * term.c (term_mouse_position): Likewise.
1500 * termhooks.h (struct input_event.timestamp): Likewise.
1501 (struct terminal.mouse_position_hook): Likewise.
1502 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1503 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1504 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1505 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1506 what it was before.
1507 * menu.h, termhooks.h: Include "systime.h", for Time.
1508
8e55734a
PE
1509 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1510 Don't assume that the difference between two unsigned long values
1511 can fit into an integer. At this point, we know button_down_time
1512 <= event->timestamp, so the difference must be nonnegative, so
1513 there's no need to cast the result if double-click-time is
1514 nonnegative, as it should be; check that it's nonnegative, just in
1515 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1516 apart (about 25 days). (Bug#8664)
8e55734a 1517
841f1b75 1518 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1519 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1520
3e26f69c
PE
1521 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1522 that always fit in int. Use a sentinel instead of a counter, to
1523 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1524 * frame.h (struct frame): Use int for menu_bar_items_used
1525 instead of EMACS_INT, since it always fits in int.
3e26f69c 1526
5cc152c0
PE
1527 * menu.c (grow_menu_items): Check for int overflow.
1528
d89eb65e
PE
1529 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1530
5235bd3e
PE
1531 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1532 Before, the code was not consistent. These values cannot exceed
1533 2**31 - 1 so there's no need to make them unsigned.
1534 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1535 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1536 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1537 as modifiers.
1538 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1539
bc827e23
PE
1540 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1541 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1542 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1543 presumably because the widths might not match.
1544
78eb494e
PE
1545 * window.c (size_window): Avoid needless test at loop start.
1546
04f2d78b
CB
15472011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1548
1549 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1550
d2fc7e3d 15512011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1552
1553 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1554
d2fc7e3d 15552011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1556
1557 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1558 `width' to `bar_area_x' and `bar_area_width', respectively.
1559 (x_scroll_run): Take account of fringe background extension.
1560
04f2d78b
CB
1561 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1562 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1563 `bar_area_width', respectively.
1564 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1565 background extension.
1566
79b70037
GM
15672011-05-10 Jim Meyering <meyering@redhat.com>
1568
1569 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1570
2f142cc5
JB
15712011-05-10 Juanma Barranquero <lekktu@gmail.com>
1572
1573 * image.c (Finit_image_library): Return t for built-in image types,
1574 like pbm and xbm. (Bug#8640)
1575
57679c86
AS
15762011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1577
1578 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1579
888c9e86
EZ
15802011-05-07 Eli Zaretskii <eliz@gnu.org>
1581
b0512a1d
EZ
1582 * w32console.c (Fset_screen_color): Doc fix.
1583 (Fget_screen_color): New function.
1584 (syms_of_ntterm): Defsubr it.
1585
7285dc67
EZ
1586 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1587 unlink the temporary file if Fcall_process didn't create it in the
1588 first place.
1589 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1590 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1591 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1592 cue to call_process_cleanup not to close that handle.
1593
4d3fcc8e
BK
15942011-05-07 Ben Key <bkey76@gmail.com>
1595
1596 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1597 one of two shell specific rules, either bootstrap-temacs-CMD or
1598 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1599 to the previous implementation of the bootstrap-temacs rule.
1600 The bootstrap-temacs-CMD rule is similar to the previous
1601 implementation of the bootstrap-temacs rule except that it
1602 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1603 variable.
1604
1605 These changes, along with some changes to nt/configure.bat,
1606 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1607 earlier fix to add support for --cflags and --ldflags options
1608 that include quotes so that it works whether make uses cmd or
1609 sh as the shell.
1610
b4289b64
MA
16112011-05-06 Michael Albinus <michael.albinus@gmx.de>
1612
1613 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1614 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1615 is a constant.
1616 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1617 a string. Handle both cases.
1618 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1619 (Fdbus_register_method): Use Qinvalid_function.
1620
af4c0e28
JB
16212011-05-06 Juanma Barranquero <lekktu@gmail.com>
1622
1623 * makefile.w32-in: Update dependencies.
1624 (LISP_H): Add inttypes.h and stdin.h.
1625 (PROCESS_H): Add unistd.h.
1626
c51453d9
EZ
16272011-05-06 Eli Zaretskii <eliz@gnu.org>
1628
1629 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1630 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1631
8ff0ac3c 16322011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1633
4c4b566b
PE
1634 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1635
aab2b9b5
PE
1636 * term.c (vfatal): Remove stray call to va_end.
1637 It's not needed and the C Standard doesn't allow it here anyway.
1638
c378da0b
PE
1639 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1640 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1641
288b08c7
PE
1642 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1643 bytes.
1644
e3601888
PE
1645 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1646
db6c0e74
PE
1647 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1648
dd5963ea
PE
1649 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1650
88c9450f
PE
1651 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1652
2f9442b8
PE
1653 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1654
c032b5f8
PE
1655 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1656 * charset.c (Fdefine_charset_internal): Don't initialize
1657 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1658 32-bit int (Bug#8600).
a108c10b
PE
1659
1660 * lread.c (read_integer): Be more consistent with string-to-number.
1661 Use string_to_number to do the actual conversion; this avoids
1662 rounding errors and fixes some other screwups. Without this fix,
1663 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1664 (digit_to_number): Move earlier, for benefit of read_integer.
1665 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1666 not a digit in any supported base. (Bug#8602)
a108c10b 1667
ad5f9eea
PE
1668 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1669
aec1708a
PE
1670 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1671 to match comment at start of function. This also removes a
1672 GCC warning about overflow in a 32+64-bit port.
1673
47be4ab5
PE
1674 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1675
371cac43
PE
1676 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1677 Reported by Stefan Monnier in
1678 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1679 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1680 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1681
d01a7826
PE
1682 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1683 (EMACS_UINTPTR): Likewise, with uintptr_t.
1684
7fd47d5c
PE
1685 * lisp.h: Prefer 64-bit EMACS_INT if available.
1686 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1687 on 32-bit hosts that have 64-bit int, so that they can access
1688 large files.
122b0c86
PE
1689 However, temporarily disable this change unless the temporary
1690 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1691
8727937b
PE
1692 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1693
8ac068ac
PE
1694 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1695 This removes an assumption that EMACS_INT and long are the same
1696 width as pointers. The assumption is true for Emacs porting targets
1697 now, but we want to make other targets possible.
1698 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1699 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1700 In the rest of the code, change types of integers that hold casted
1701 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1702 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1703 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1704 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1705 No need to cast type when ORing.
1706 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1707 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1708 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1709 assume EMACS_INT is the same width as char *.
1710 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1711 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1712 Remove no-longer-needed casts.
1713 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1714 (xg_tool_bar_help_callback, xg_make_tool_item):
1715 Use EMACS_INTPTR to hold an integer
1716 that will be cast to void *; this can avoid a GCC warning
1717 if EMACS_INT is not the same width as void *.
1718 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1719 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1720 (current_message_1, set_message_1):
1721 Use a local to convert to proper width without a cast.
1722 * xmenu.c (dialog_selection_callback): Likewise.
1723
ede49d71
PE
1724 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1725 Also, don't assume VALBITS / RAND_BITS is less than 5,
1726 and don't rely on undefined behavior when shifting a 1 left into
1727 the sign bit.
1728 * lisp.h (get_random): Change signature to match.
1729
2f30ecd0
PE
1730 * lread.c (hash_string): Use size_t, not int, for hash computation.
1731 Normally we prefer signed values; but hashing is special, because
1732 it's better to use unsigned division on hash table sizes so that
1733 the remainder is nonnegative. Also, size_t is the natural width
1734 for hashing into memory. The previous code used 'int', which doesn't
1735 retain enough info to hash well into very large tables.
1736 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1737
2a866e7b
PE
1738 * dbusbind.c: Don't possibly lose pointer info when converting.
1739 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1740 Use XPNTR rather than XHASH, so that the high-order bits of
1741 the pointer aren't lost when converting through void *.
1742
51639eac
PE
1743 * eval.c (Fautoload): Don't double-shift a pointer.
1744
92394119
PE
1745 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1746
dbdb9a7c
JB
17472011-05-06 Juanma Barranquero <lekktu@gmail.com>
1748
1749 * gnutls.c (DEF_GNUTLS_FN):
1750 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1751
db7a0b4f
AS
17522011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1753
1754 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1755 marker. (Bug#8610)
1756
f7ff1b0f 17572011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1758
1759 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1760 New version that can reserve upto 2GB of heap space.
1761
f7ff1b0f 17622011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1763
1764 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1765
639c109b
TZ
17662011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1767
1768 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1769 `gnutls_certificate_set_x509_key_file'.
1770
d2127135
JB
17712011-05-05 Juanma Barranquero <lekktu@gmail.com>
1772
1773 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1774 Update dependencies.
1775
e968f4f3
JB
17762011-05-04 Juanma Barranquero <lekktu@gmail.com>
1777
1778 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1779 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1780 Remove unused parameter `fildes'.
1781 * process.c (read_process_output, send_process): Don't pass it.
1782
84d358f0
JB
17832011-05-04 Juanma Barranquero <lekktu@gmail.com>
1784
1785 Fix previous change: the library cache is defined in w32.c.
1786 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1787 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1788
0898ca10
JB
17892011-05-04 Juanma Barranquero <lekktu@gmail.com>
1790
1791 Implement dynamic loading of GnuTLS on Windows.
1792
1793 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1794 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1795 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1796 Declare.
1797
1798 * gnutls.c (Qgnutls_dll): Define.
1799 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1800 (gnutls_*): Declare function pointers.
1801 (init_gnutls_functions): New function to initialize function pointers.
1802 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1803 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1804 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1805 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1806 (emacs_gnutls_write, emacs_gnutls_read)
1807 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1808 (Fgnutls_available_p): New function.
1809 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1810 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1811 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1812
1813 * image.c: Include w32.h.
1814 (Vimage_type_cache): Delete.
1815 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1816 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1817 (w32_delayed_load): Move to w32.c.
1818
1819 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1820
1821 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1822 (w32_delayed_load): Move from image.c. When loading a library, record
1823 its filename in the :loaded-from property of the library id.
1824 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1825 Initialize and staticpro them.
1826 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1827
1828 * process.c: Include lisp.h before w32.h, not after.
1829 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1830 instead of gnutls_record_check_pending.
1831
1832 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1833
ff4de4aa
TZ
18342011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1835
1836 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1837 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1838 as passed in.
1839
abe95abb
JD
18402011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1841
1842 * xterm.c (x_set_frame_alpha): Do not set property on anything
1843 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1844
e16e55d4
JB
18452011-05-02 Juanma Barranquero <lekktu@gmail.com>
1846
1847 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1848
bafcf6a5
JB
18492011-05-02 Juanma Barranquero <lekktu@gmail.com>
1850
1851 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1852 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1853 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1854 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1855 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1856 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1857 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1858 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1859 (Qgnutls_bootprop_callbacks_verify): Make static.
1860
e7a6747f
AS
18612011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1862
19ed11ba
AS
1863 * callproc.c: Indentation fixup.
1864
e7a6747f 1865 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1866 (wait_for_termination, interruptible_wait_for_termination):
1867 Move after wait_for_termination_1.
e7a6747f 1868
1ef14cb4
LMI
18692011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1870
1871 * sysdep.c (interruptible_wait_for_termination): New function
1872 which is like wait_for_termination, but allows keyboard
1873 interruptions.
1874
1875 * callproc.c (Fcall_process): Add (:file "file") as an option for
1876 the STDOUT buffer.
1877 (Fcall_process_region): Ditto.
1878
330d880c
EZ
18792011-04-30 Eli Zaretskii <eliz@gnu.org>
1880
8db90b73
EZ
1881 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1882 rather than `XVECTOR (FOO)->size'.
1883
330d880c
EZ
1884 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1885 inttypes.h, as a gnulib replacement is used if it not available in
1886 system headers.
1887
15cbd324
EZ
18882011-04-21 Eli Zaretskii <eliz@gnu.org>
1889
1890 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1891 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1892 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1893
1894 * coding.c (coding_alloc_by_realloc): Error out if destination
1895 will grow beyond MOST_POSITIVE_FIXNUM.
1896 (decode_coding_emacs_mule): Abort if there isn't enough place in
1897 charbuf for the composition carryover bytes. Reserve an extra
1898 space for up to 2 characters produced in a loop.
1899 (decode_coding_iso_2022): Abort if there isn't enough place in
1900 charbuf for the composition carryover bytes.
1901
19022011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1903
ae940cca
EZ
1904 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1905 aborting when %lld or %lll format is passed.
1906 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1907 %llo or %llx format is passed. (Bug#8545)
1908
03ab8921
EZ
1909 * window.c (window_scroll_line_based): Use a marker instead of
1910 simple variables to record original value of point. (Bug#7952)
1911
afda1437
EZ
1912 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1913 produced by %s or %c overflows available buffer space. (Bug#8545)
1914
f76dee0c
PE
19152011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1916
1917 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1918 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1919
fdc5744d
JB
19202011-04-28 Juanma Barranquero <lekktu@gmail.com>
1921
1922 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1923
638f053a
JB
19242011-04-28 Juanma Barranquero <lekktu@gmail.com>
1925
1926 * keyboard.c (Qdelayed_warnings_hook): Define.
1927 (command_loop_1): Run `delayed-warnings-hook'
1928 if Vdelayed_warnings_list is non-nil.
1929 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1930 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1931
d178f871
EZ
19322011-04-28 Eli Zaretskii <eliz@gnu.org>
1933
1934 * doprnt.c (doprnt): Don't return value smaller than the buffer
1935 size if the message was truncated. (Bug#8545).
1936
b124fd93
JB
19372011-04-28 Juanma Barranquero <lekktu@gmail.com>
1938
1939 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1940 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1941
e810457d
PE
19422011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1943
1944 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1945
ea51cceb
JB
19462011-04-27 Juanma Barranquero <lekktu@gmail.com>
1947
1948 * makefile.w32-in: Update dependencies.
1949
94dcfacf
EZ
19502011-04-27 Eli Zaretskii <eliz@gnu.org>
1951
1952 Improve `doprnt' and its usage. (Bug#8545)
1953 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1954 `format_end'. Remove support for %l as a conversion specifier.
1955 Don't use xrealloc. Improve diagnostics when the %l size modifier
1956 is used. Update the commentary.
1957
1958 * eval.c (verror): Simplify calculation of size_t.
1959
1960 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1961 messages.
1962
f61f41d7
PE
19632011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1964
1965 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1966 change.
1967
96fb4434
PE
19682011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1969
1970 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1971 This makes this file independent of the recent pseudovector change.
1972
671875da 19732011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1974
69e9b5a3
PE
1975 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1976
b5f869a7 1977 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1978 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1979 Remove unused local.
c8926152 1980 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1981
841a1577 1982 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1983 GCC 4.6.0 optimizes based on type-based alias analysis.
1984 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1985 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1986 != &v->size, and therefore "v->size = 1; b->size = 2; return
1987 v->size;" must therefore return 1. This assumption is incorrect
1988 for Emacs, since it type-puns struct Lisp_Vector * with many other
1989 types. To fix this problem, this patch adds a new type struct
f904488f 1990 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1991 and pseudovectors, and helps optimizing compilers not get fooled
1992 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1993 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1994 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1995 the size member.
eab3844f
PE
1996 (XSETPVECTYPE): Rewrite in terms of new macro.
1997 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1998 This is a bit clearer, and further avoids the possibility of
1999 undesirable aliasing.
2000 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2001 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2002 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2003 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2004 (ASIZE): Now uses header.size rather than size.
2005 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2006 to avoid the hassle of writing XVECTOR (foo)->header.size.
2007 (struct vectorlike_header): New type.
eab3844f
PE
2008 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2009 object, to help avoid aliasing.
2010 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2011 (SUBRP): Likewise, since Lisp_Subr is a special case.
2012 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2013 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2014 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2015 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2016 changed to be "header.size" and "header.next".
2017 * buffer.h (struct buffer): Likewise.
2018 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2019 * frame.h (struct frame): Likewise.
2020 * process.h (struct Lisp_Process): Likewise.
2021 * termhooks.h (struct terminal): Likewise.
2022 * window.c (struct save_window_data, struct saved_window): Likewise.
2023 * window.h (struct window): Likewise.
2024 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2025 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2026 * buffer.c (init_buffer_once): Likewise.
2027 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2028 special case.
2029 * process.c (Fformat_network_address): Use local var for size,
2030 for brevity.
2031
0df1eac5
PE
2032 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2033
847ab9d1 2034 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2035 * data.c (atof): Remove decl; no longer used or needed.
2036 (digit_to_number): Move to lread.c.
2037 (Fstring_to_number): Use new string_to_number function, to be
2038 consistent with how the Lisp reader treats infinities and NaNs.
2039 Do not assume that floating-point numbers represent EMACS_INT
2040 without losing information; this is not true on most 64-bit hosts.
2041 Avoid double-rounding errors, by insisting on integers when
2042 parsing non-base-10 numbers, as the documentation specifies.
2043 * lisp.h (string_to_number): New decl, replacing ...
2044 (isfloat_string): Remove.
bc0a5c13 2045 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2046 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2047 appears to have been a coding error. Similarly, do not accept
2048 strings like +-1e0 as floating point numbers. Do not report
2049 overflow for integer overflows unless the base is not 10 which
2050 means we have no simple and reliable way to continue.
2051 Break out the floating-point parsing into a new
2052 function string_to_number, so that Fstring_to_number parses
2053 floating point numbers consistently with the Lisp reader.
04f2d78b 2054 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2055 (E_CHAR, EXP_INT): Remove, replacing with ...
2056 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2057 (string_to_number): New function, replacing isfloat_string.
2058 This function checks for valid syntax and produces the resulting
2059 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2060 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2061 so that overflow for non-base-10 numbers is reported only when
2062 there's no portable and simple way to convert to floating point.
452f4150 2063
67769ffc
PE
2064 * textprop.c (set_text_properties_1): Rewrite for clarity,
2065 and to avoid GCC warning about integer overflow.
2066
c20db43f
PE
2067 * intervals.h (struct interval): Use EMACS_INT for members
2068 where EMACS_UINT might cause problems. See
2069 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2070 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2071 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2072 All uses changed.
37aa2f85
PE
2073 (offset_intervals): Tell GCC not to worry about length overflow
2074 when negating a negative length.
c20db43f 2075
2538aa2f
PE
2076 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2077 (overrun_check_free): Likewise.
2078
f2d3008d
PE
2079 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2080 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2081 word size.
2082
ec8df744
PE
2083 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2084 (gnutls_make_error): Rename local to avoid shadowing.
2085 (gnutls_emacs_global_deinit): ifdef out; not used.
2086 (Fgnutls_boot): Use const for pointer to readonly storage.
2087 Comment out unused local. Fix pointer signedness problems.
2088
640ee02d
PE
2089 * lread.c (openp): Don't stuff size_t into an 'int'.
2090 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2091 about possible signed overflow.
2092
6048fb2a
PE
2093 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2094 (GDK_KEY_g): Don't define if already defined.
2095 (xg_prepare_tooltip): Avoid pointer signedness problem.
2096 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2097
fa3c87e1
PE
2098 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2099 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2100
2172544b
PE
2101 * xfns.c (Fx_window_property): Simplify a bit,
2102 to make a bit faster and to avoid GCC 4.6.0 warning.
2103 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2104
9b821a21
PE
2105 * fns.c (internal_equal): Don't assume size_t fits in int.
2106
3c616cfa
PE
2107 * alloc.c (compact_small_strings): Tighten assertion a little.
2108
c2982e87
PE
2109 Replace pEd with more-general pI, and fix some printf arg casts.
2110 * lisp.h (pI): New macro, generalizing old pEd macro to other
2111 conversion specifiers. For example, use "...%"pI"d..." rather
2112 than "...%"pEd"...".
2113 (pEd): Remove. All uses replaced with similar uses of pI.
2114 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2115 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2116 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2117 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2118 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2119 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2120 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2121 64-bit hosts.
2122 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2123 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2124 * print.c (safe_debug_print, print_object): Likewise.
2125 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2126 to int.
6f04d126
PE
2127 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2128 avoiding the 0 flag, which is not portable.
c2982e87
PE
2129 * process.c (Fmake_network_process): Use pI to avoid cast.
2130 * region-cache.c (pp_cache): Likewise.
2131 * xdisp.c (decode_mode_spec): Likewise.
2132 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2133 behavior on 64-bit hosts with printf arg.
6f04d126 2134 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2135 (x_stop_queuing_selection_requests): Likewise.
2136 (x_get_window_property): Don't truncate byte count to an 'int'
2137 when tracing.
0b432f21 2138
5e073ec7
PE
2139 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2140 here, since it parses constructs like leading '-' and spaces,
2141 which are not wanted; and it overflows with large numbers.
2142 Instead, simply match F[0-9]+, which is what is wanted anyway.
2143
36372bf9
PE
2144 * alloc.c: Remove unportable assumptions about struct layout.
2145 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2146 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2147 (allocate_vectorlike, make_pure_vector): Use the new macros,
2148 plus offsetof, to remove unportable assumptions about struct layout.
2149 These assumptions hold on all porting targets that I know of, but
2150 they are not guaranteed, they're easy to remove, and removing them
2151 makes further changes easier.
2152
0b432f21
PE
2153 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2154 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2155 (string_overrun_cookie): Now const. Use initializers that
2156 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2157 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2158 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2159 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2160 multiple of sizeof (EMACS_INT); it need not be, if
2161 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2162 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2163
895009e1
JB
21642011-04-26 Juanma Barranquero <lekktu@gmail.com>
2165
2166 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2167
6a7a1b0b
TZ
21682011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2169
2170 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2171 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2172 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2173
841a1577 21742011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2175
2176 * lisp.h (Qdebug): List symbol.
895009e1 2177 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2178 * keyboard.c (debug-on-event): New variable.
2179 (handle_user_signal): Break into debugger when debug-on-event
2180 matches the current signal symbol.
2181
f2d3ba6f
DN
21822011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2183
2184 * alloc.c (check_sblock, check_string_bytes)
2185 (check_string_free_list): Convert to standard C.
2186
42ce4c63
TZ
21872011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2188
2189 * w32.c (emacs_gnutls_push): Fix typo.
2190
825cd63c
EZ
21912011-04-25 Eli Zaretskii <eliz@gnu.org>
2192
fb11d64d
EZ
2193 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2194 "cast to pointer from integer of different size".
2195
825cd63c
EZ
2196 Improve doprnt and its use in verror. (Bug#8545)
2197 * doprnt.c (doprnt): Document the set of format control sequences
2198 supported by the function. Use SAFE_ALLOCA instead of always
2199 using `alloca'.
2200
2201 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2202 is one byte too soon. Don't use xrealloc; instead xfree and
2203 xmalloc anew.
2204
e061a11b
TZ
22052011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2206
2207 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2208 callbacks stage.
2209
2210 * gnutls.c: Renamed global_initialized to
2211 gnutls_global_initialized. Added internals for the
2212 :verify-hostname-error, :verify-error, and :verify-flags
2213 parameters of `gnutls-boot' and documented those parameters in the
2214 docstring. Start callback support.
2215 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2216 unless a fatal error occured. Call gnutls_alert_send_appropriate
2217 on error. Return error code.
2218 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2219 (emacs_gnutls_read): Likewise.
2220 (Fgnutls_boot): Return handshake error code.
2221 (emacs_gnutls_handle_error): New function.
2222 (wsaerror_to_errno): Likewise.
2223
2224 * w32.h (emacs_gnutls_pull): Add prototype.
2225 (emacs_gnutls_push): Likewise.
2226
2227 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2228 (emacs_gnutls_push): Likewise.
2229
22302011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2231
2232 * process.c (wait_reading_process_output): Check if GnuTLS
2233 buffered some data internally if no FDs are set for TLS
2234 connections.
2235
2236 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2237 (LIBS): Link to USER_LIBS.
2238 ($(BLD)/gnutls.$(0)): New target.
2239
fa6996bc
EZ
22402011-04-24 Eli Zaretskii <eliz@gnu.org>
2241
eb35682e
EZ
2242 * xdisp.c (handle_single_display_spec): Rename the
2243 display_replaced_before_p argument into display_replaced_p, to
2244 make it consistent with the commentary. Fix typos in the
2245 commentary.
2246
e2ad650c
EZ
2247 * textprop.c (syms_of_textprop): Remove dead code.
2248 (copy_text_properties): Delete obsolete commentary about an
2249 interface that was deleted long ago. Fix typos in the description
2250 of arguments.
2251
1b2de274
EZ
2252 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2253 to changes in oldXMenu/XMenu.h from 2011-04-16.
2254 <menu_help_message, prev_menu_help_message>: Constify.
2255 (IT_menu_make_room): menu->help_text is now `const char **';
2256 adjust.
2257
2258 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2259 to changes in oldXMenu/XMenu.h from 2011-04-16.
2260 (struct XMenu): Declare `help_text' `const char **'.
2261
2262 * xfaces.c <Qunspecified>: Make extern again.
2263
2264 * syntax.c: Include sys/types.h before including regex.h, as
2265 required by Posix.
2266
762b15be
EZ
2267 * doc.c (get_doc_string): Improve the format passed to `error'.
2268
2269 * doprnt.c (doprnt): Improve commentary.
2270
2271 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2272
2273 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2274 them with etags.
2275
f1052e5d
EZ
2276 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2277 changes in globals.h immediately force recompilation.
762b15be
EZ
2278 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2279 $(CURDIR)/s/ms-w32.h.
2280 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2281
fa6996bc
EZ
2282 * character.c (Fchar_direction): Function deleted.
2283 (syms_of_character): Don't defsubr it.
2284 <char-direction-table>: Deleted.
2285
e6c3da20
EZ
22862011-04-23 Eli Zaretskii <eliz@gnu.org>
2287
2288 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2289 * doprnt.c: Include limits.h.
2290 (SIZE_MAX): New macro.
04f2d78b
CB
2291 (doprnt): Return a size_t value. 2nd arg is now size_t.
2292 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2293 Improve overflow protection. Support `l' modifier for integer
2294 conversions. Support %l conversion. Don't assume an EMACS_INT
2295 argument for integer conversions and for %c.
2296
2297 * lisp.h (doprnt): Restore prototype.
2298
2299 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2300 $(SRC)/character.h.
2301
2302 * Makefile.in (base_obj): Add back doprnt.o.
2303
2304 * deps.mk (doprnt.o): Add back prerequisites.
2305 (callint.o): Depend on character.h.
2306
2307 * eval.c (internal_lisp_condition_case): Include the handler
2308 representation in the error message.
2309 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2310 when breaking from the loop.
2311
2312 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2313
2314 * callint.c (Fcall_interactively): When displaying error message
2315 about invalid control letter, pass the character's codepoint, not
2316 a pointer to its multibyte form. Improve display of the character
2317 in octal and display also its hex code.
2318
2319 * character.c (char_string): Use %x to display the (unsigned)
2320 codepoint of an invalid character, to avoid displaying a bogus
2321 negative value.
2322
2323 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2324 `error', not SYMBOL_NAME itself.
2325
2326 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2327 character arguments to `error'.
2328
2329 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2330 to `error' in error message about FINAL_CHAR argument. Make sure
2331 FINAL_CHAR is a character, and use %c when it is passed as
2332 argument to `error'.
2333
4ffd0d6b 23342011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2335
2336 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2337
2338 * w32.c: Include <time.h>.
2339 (sys_localtime): New function.
2340
4ffd0d6b 23412011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2342
2343 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2344
4ffd0d6b 2345 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2346
4ffd0d6b 23472011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2348
4ffd0d6b
GM
2349 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2350 zombies (Bug#8467).
aac0c6e3 2351
04c56954
EZ
23522011-04-19 Eli Zaretskii <eliz@gnu.org>
2353
2354 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2355 gl_state.e_property when gl_state.object is Qt.
2356
2357 * insdel.c (make_gap_larger): Remove limitation of buffer size
2358 to <= INT_MAX.
2359
16a43933
CY
23602011-04-18 Chong Yidong <cyd@stupidchicken.com>
2361
2362 * xdisp.c (lookup_glyphless_char_display)
2363 (produce_glyphless_glyph): Handle cons cell entry in
2364 glyphless-char-display.
2365 (Vglyphless_char_display): Document it.
2366
2367 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2368 glyphless-char-display.
2369
4581706e
CY
23702011-04-17 Chong Yidong <cyd@stupidchicken.com>
2371
2372 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2373
2374 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2375
2376 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2377 definition for no-X builds.
2378
4887c6e2 23792011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2380
fd35b6f9
PE
2381 Static checks with GCC 4.6.0 and non-default toolkits.
2382
5c1ccb01
PE
2383 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2384
006c5daa
PE
2385 * process.c (keyboard_bit_set): Define only if SIGIO.
2386 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2387 (send_process): Repair possible setjmp clobbering.
2388
efc736d3
PE
2389 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2390
4e2fe2e6
PE
2391 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2392
f97334a2
PE
2393 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2394
4e75f29d
PE
2395 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2396 Define only if needed.
2397
90efadd1
PE
2398 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2399 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2400 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2401
3c647824
PE
2402 * dispextern.h (struct redisplay_interface): Rename param
2403 to avoid shadowing.
e264f262 2404 * termhooks.h (struct terminal): Likewise.
761383f4 2405 * xterm.c (xembed_send_message): Likewise.
3c647824 2406
b58c5c4a
PE
2407 * insdel.c (make_gap_smaller): Define only if
2408 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2409
cad59032
PE
2410 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2411 it.
2412
c339dc2e
PE
2413 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2414 so that we aren't warned about unused symbols.
2415
91a3e27b
PE
2416 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2417
399c71d3 2418 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2419
8ffc96f5
PE
2420 * xfns.c (x_real_positions): Mark locals as initialized.
2421
eef9bc79
PE
2422 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2423
098db9dd
PE
2424 * xterm.c: Fix problems found by static analysis with other toolkits.
2425 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2426 (x_dispatch_event): Declare static if USE_GTK, and
2427 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2428 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2429 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2430 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2431 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2432
eb18f6cc
PE
2433 * xmenu.c (menu_help_callback): Pointer type fixes.
2434 Use const pointers when pointing at readonly data. Avoid pointer
2435 signedness clashes.
2436 (FALSE): Remove unused macro.
2437 (update_frame_menubar): Remove unused decl.
2438
1fe72bf8
PE
2439 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2440
60d9e1db
PE
2441 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2442 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2443 (single_menu_item): Rename local to avoid shadowing.
2444
39261c26
PE
2445 * keyboard.c (make_lispy_event): Remove unused local var.
2446
018c5e19
PE
2447 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2448 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2449
63d2b86e
PE
2450 * bitmaps: Change bitmaps from unsigned char back to the X11
2451 compatible char. Avoid the old compiler warnings about
2452 out-of-range initializers by using, for example, '\xab' rather
2453 than 0xab.
2454
aefd87e1
PE
2455 * xgselect.c (xgselect_initialize): Check vs interface
2456 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2457
bf501fb9
PE
2458 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2459
e9829fdf
PE
2460 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2461 to read-only memory.
2462
1086c095
PE
2463 * fns.c (vector): Remove; this old hack is no longer needed.
2464
2baccd04 2465 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2466 Remove unused var.
dde42981 2467 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2468
72391843 2469 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2470
436c16df 2471 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2472 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2473 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2474
92bb796d 2475 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2476 (x_term_init): Remove local to avoid shadowing.
92bb796d 2477
764430a3 2478 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2479
2480 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2481 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2482
d1dfb56c
EZ
24832011-04-16 Eli Zaretskii <eliz@gnu.org>
2484
c4354cb4
EZ
2485 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2486
d1dfb56c
EZ
2487 Fix regex.c, syntax.c and friends for buffers > 2GB.
2488 * syntax.h (struct gl_state_s): Declare character position members
2489 EMACS_INT.
2490
2491 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2492
04f2d78b
CB
2493 * textprop.c (verify_interval_modification, interval_of):
2494 Declare arguments EMACS_INT.
d1dfb56c
EZ
2495
2496 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2497 EMACS_INT.
2498
2499 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2500
2501 * indent.c (Fvertical_motion): Local variable it_start is now
2502 EMACS_INT.
2503
2504 * regex.c (re_match, re_match_2, re_match_2_internal)
2505 (bcmp_translate, regcomp, regexec, print_double_string)
2506 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2507 (re_compile_pattern, re_exec): Declare arguments and local
2508 variables `size_t' and `ssize_t' and return values `regoff_t', as
2509 appropriate.
2510 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2511 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2512 <compile_stack_type>: `size' and `avail' are now `size_t'.
2513
2514 * regex.h <regoff_t>: Use ssize_t, not int.
2515 (re_search, re_search_2, re_match, re_match_2): Arguments that
2516 specify buffer/string position and length are now ssize_t and
2517 size_t. Return type is regoff_t.
2518
613052cd
BK
25192011-04-16 Ben Key <bkey76@gmail.com>
2520
2521 * nsfont.m: Fixed bugs in ns_get_family and
2522 ns_descriptor_to_entity that were caused by using free to
2523 deallocate memory blocks that were allocated by xmalloc (via
2524 xstrdup). This caused Emacs to crash when compiled with
2525 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2526 --enable-checking=xmallocoverrun). xfree is now used to
2527 deallocate these memory blocks.
2528
4170f62f 25292011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2530
71b41406
PE
2531 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2532
9587a89d
PE
2533 emacs_write: Accept and return EMACS_INT for sizes.
2534 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2535 et seq.
2536 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2537 Accept and return EMACS_INT.
2538 (emacs_gnutls_write): Return the number of bytes written on
2539 partial writes.
2540 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2541 (emacs_read, emacs_write): Remove check for negative size, as the
2542 Emacs source code has been audited now.
9587a89d
PE
2543 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2544 (emacs_read, emacs_write): Use it.
273a5f82
PE
2545 * process.c (send_process): Adjust to the new signatures of
2546 emacs_write and emacs_gnutls_write. Do not attempt to store
2547 a byte offset into an 'int'; it might overflow.
9587a89d 2548 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2549
3e047f51
PE
2550 * sound.c: Don't assume sizes fit in 'int'.
2551 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2552 Return EMACS_INT, not int.
3e047f51 2553 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2554 Accept EMACS_INT, not int.
2555 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2556 record read return values.
2557
cc39a9db
BK
25582011-04-15 Ben Key <bkey76@gmail.com>
2559
c9d0ec6d
JB
2560 * keyboard.c (Qundefined): Don't declare static since it is used
2561 in nsfns.m.
2562 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2563 static since they are used in nsfont.m.
cc39a9db 2564
6c60eb9f
SM
25652011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2566
2567 * process.c (Qprocessp): Don't declare static.
2568 * lisp.h (Qprocessp): Declare again.
2569
7990b61a
JB
25702011-04-15 Juanma Barranquero <lekktu@gmail.com>
2571
2572 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2573
5d4cb038
PE
25742011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2575
8bd7b830 2576 Improve C-level modularity by making more things 'static'.
cd64ea1d 2577
e3b27b31
PE
2578 Don't publish debugger-only interfaces to other modules.
2579 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2580 (verify_bytepos, count_markers): Move decls to the only modules
2581 that need them.
2582 * region-cache.h (pp_cache): Likewise.
2583 * window.h (check_all_windows): Likewise.
2584 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2585
5d4cb038
PE
2586 * sysdep.c (croak): Now static, if
2587 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2588 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2589
2590 * alloc.c (refill_memory_reserve): Now static if
2591 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2592 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2593
e87b6180
PE
2594 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2595 Define only if USE_LUCID.
2596
ac64929e
PE
2597 * xrdb.c (x_customization_string, x_rm_string): Now static.
2598
6f37259d
PE
2599 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2600 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2601
1683e3ab
PE
2602 * xdisp.c (draw_row_with_mouse_face): Now static.
2603 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2604
de9c2632
PE
2605 * window.h (check_all_windows): Mark externally visible.
2606
2b96acb7
PE
2607 * window.c (window_deletion_count): Now static.
2608
2609 * undo.c: Make symbols static if they're not exported.
2610 (last_undo_buffer, last_boundary_position, pending_boundary):
2611 Now static.
2612
50436f33
PE
2613 * textprop.c (interval_insert_behind_hooks): Now static.
2614 (interval_insert_in_front_hooks): Likewise.
2615
64520e5c
PE
2616 * term.c: Make symbols static if they're not exported.
2617 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2618 (max_frame_lines, tty_set_terminal_modes):
2619 (tty_reset_terminal_modes, tty_turn_off_highlight):
2620 (get_tty_terminal): Now static.
2621 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2622 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2623 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2624 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2625 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2626
1fa53021
PE
2627 * sysdep.c: Make symbols static if they're not exported.
2628 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2629 Now static.
2630 (sigprocmask_set, full_mask): Remove; unused.
2631 (wait_debugging): Mark as visible.
2632 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2633 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2634
d4b43b22
PE
2635 * syntax.c (syntax_temp): Define only if !__GNUC__.
2636
b7c513d0
PE
2637 * sound.c (current_sound_device, current_sound): Now static.
2638
989b29ad
PE
2639 * search.c (searchbufs, searchbuf_head): Now static.
2640
13a55a78
PE
2641 * scroll.c (scroll_cost): Remove; unused.
2642 * dispextern.h (scroll_cost): Remove decl.
2643
de68a1fc
PE
2644 * region-cache.h (pp_cache): Mark as externally visible.
2645
40ccffa6
PE
2646 * process.c: Make symbols static if they're not exported.
2647 (process_tick, update_tick, create_process, chan_process):
2648 (Vprocess_alist, proc_buffered_char, datagram_access):
2649 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2650 (deactivate_process): Mark defn as static, as well as decl.
2651 * lisp.h (create_process): Remove decl.
2652 * process.h (chan_process, Vprocess_alist): Remove decls.
2653
ad64fc97
PE
2654 * print.c: Make symbols static if they're not exported.
2655 (print_depth, new_backquote_output, being_printed, print_buffer):
2656 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2657 (print_interval, print_number_index, initial_stderr_stream):
2658 Now static.
2659 * lisp.h (Fprinc): Remove decl.
2660 (debug_output_compilation_hack): Mark as externally visible.
2661
adddb265
PE
2662 * sysdep.c (croak): Move decl from here to syssignal.h.
2663 * syssignal.h (croak): Put it here, so the API can be checked when
2664 'croak' is called from dissociate_if_controlling_tty.
2665
1717ede2
PE
2666 * minibuf.c: Make symbols static if they're not exported.
2667 (minibuf_save_list, choose_minibuf_frame): Now static.
2668 * lisp.h (choose_minibuf_frame): Remove decl.
2669
fa5fb2bc
PE
2670 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2671
1e3890d1
PE
2672 * lread.c: Make symbols static if they're not exported.
2673 (read_objects, initial_obarray, oblookup_last_bucket_number):
2674 Now static.
2675 (make_symbol): Remove; unused.
2676 * lisp.h (initial_obarray, make_symbol): Remove decls.
2677
8a1414fa
PE
2678 * keyboard.c: Make symbols static if they're not exported.
2679 (single_kboard, recent_keys_index, total_keys, recent_keys):
2680 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2681 (this_single_command_key_start, echoing, last_auto_save):
2682 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2683 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2684 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2685 (Vlispy_mouse_stem, double_click_count):
2686 Now static.
2687 (force_auto_save_soon): Define only if SIGDANGER.
2688 (ignore_mouse_drag_p): Now static if
2689 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2690 (print_help): Remove; unused.
2691 (stop_character, last_timer_event): Mark as externally visible.
2692 * keyboard.h (ignore_mouse_drag_p): Declare only if
2693 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2694 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2695 * lisp.h (echoing): Remove decl.
2696 (force_auto_save_soon): Declare only if SIGDANGER.
2697 * xdisp.c (redisplay_window): Simplify code, to make it more
2698 obvious that ignore_mouse_drag_p is not accessed if !defined
2699 USE_GTK && !defined HAVE_NS.
2700
93ea6e8f
PE
2701 * intervals.c: Make symbols static if they're not exported.
2702 (merge_properties_sticky, merge_interval_right, delete_interval):
2703 Now static.
2704 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2705
77382fcc
PE
2706 * insdel.c: Make symbols static if they're not exported.
2707 However, leave prepare_to_modify_buffer alone. It's never
2708 called from outside this function, but that appears to be a bug.
2709 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2710 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2711 (adjust_after_replace_noundo): Remove; unused.
2712 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2713 (signal_before_change): Remove decls.
77382fcc 2714
9306c32e
PE
2715 * indent.c (val_compute_motion, val_vmotion): Now static.
2716
cd44d2eb
PE
2717 * image.c: Make symbols static if they're not exported.
2718 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2719 if USE_GTK.
2720 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2721 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2722
ad9a7a06
PE
2723 * fringe.c (standard_bitmaps): Now static.
2724 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2725
81626931
PE
2726 * frame.c: Make symbols static if they're not exported.
2727 (x_report_frame_params, make_terminal_frame): Now static.
2728 (get_frame_param): Now static, unless HAVE_NS.
2729 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2730 (x_get_resource_string): Remove; not used.
2731 * frame.h (make_terminal_frame, x_report_frame_params):
2732 (x_get_resource_string); Remove decls.
2733 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2734 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2735
239f9db9
PE
2736 * font.c, fontset.c: Make symbols static if they're not exported.
2737 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2738 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2739 * font.c (font_close_object): Now static.
2740 * font.h (font_close_object): Remove.
2741 * fontset.c (FONTSET_OBJLIST): Remove.
2742 (free_realized_fontset) #if-0 the body, which does nothing.
2743 (face_suitable_for_char_p): #if-0, as it's never called.
2744 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2745 * xfaces.c (face_at_string_position):
2746 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2747 since 0 is always ASCII.
2748
dfcf3579
PE
2749 * fns.c (weak_hash_tables): Now static.
2750
5045092b
PE
2751 * fileio.c: Make symbols static if they're not exported.
2752 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2753 (Vwrite_region_annotation_buffers): Now static.
2754
57a96f5c
PE
2755 * eval.c: Make symbols static if they're not exported.
2756 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2757 * lisp.h (backtrace_list): Remove decl.
2758
35f08c38
PE
2759 * emacs.c: Make symbols static if they're not exported.
2760 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2761 (fatal_error_code, fatal_error_signal_hook, standard_args):
2762 Now static.
2763 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2764 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2765 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2766 * lisp.h (fatal_error_signal_hook): Remove decl.
2767 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2768
f44bd759
PE
2769 * editfns.c: Move a (normally-unused) function to its only use.
2770 * editfns.c, lisp.h (get_operating_system_release): Remove.
2771 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2772 worth the hassle of breaking this out.
2773
b532497d
PE
2774 * xterm.c: Make symbols static if they're not exported.
2775 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2776 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2777 (x_destroy_window, x_delete_display):
2778 Now static.
2779 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2780 (x_mouse_leave): Remove; unused.
2781 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2782 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2783 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2784 Remove decls.
2785 (x_mouse_leave): Declare only if WINDOWSNT.
2786 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2787 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2788 USE_X_TOOLKIT.
2789
1675728f
PE
2790 * ftxfont.c: Make symbols static if they're not exported.
2791 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2792 HAVE_FREETYPE.
2793 * font.h (ftxfont_driver): Likewise.
2794
e4cebfca
PE
2795 * xfns.c: Make symbols static if they're not exported.
2796 (x_last_font_name, x_display_info_for_name):
2797 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2798 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2799 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2800 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2801 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2802 (last_show_tip_args): Now static.
2803 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2804 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2805 (x_screen_planes): Remove; unused.
2806 * dispextern.h (x_screen_planes): Remove decl.
2807
5bf46f05
PE
2808 * dispnew.c: Make symbols static if they're not exported.
2809 * dispextern.h (redraw_garbaged_frames, scrolling):
2810 (increment_row_positions): Remove.
2811 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2812 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2813 Now static.
2814 (redraw_garbaged_frames): Remove; unused.
2815
435f4c28
PE
2816 * xfaces.c: Make symbols static if they're not exported.
2817 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2818 Remove decls.
2819 * xterm.h (defined_color): Remove decls.
2820 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2821 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2822 (menu_face_changed_default, defined_color, free_realized_face):
2823 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2824 (ascii_face_of_lisp_face): Remove; unused.
2825
8524aef3
PE
2826 * xdisp.c: Make symbols static if they're not exported.
2827 * dispextern.h (scratch_glyph_row, window_box_edges):
2828 (glyph_to_pixel_coords, set_cursor_from_row):
2829 (get_next_display_element, set_iterator_to_next):
2830 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2831 (show_mouse_face): Remove decls
2832 * frame.h (message_buf_print): Likewise.
2833 * lisp.h (pop_message, set_message, check_point_in_composition):
2834 Likewise.
2835 * xterm.h (set_vertical_scroll_bar): Likewise.
2836 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2837 (message_buf_print, scratch_glyph_row, displayed_buffer):
2838 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2839 (get_next_display_element, show_mouse_face, window_box_edges):
2840 (frame_to_window_pixel_xy, check_point_in_composition):
2841 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2842 (glyph_to_pixel_coords): Remove; unused.
2843
16390cd2
PE
2844 * dired.c (file_name_completion): Now static.
2845
2846 * dbusbind.c (xd_in_read_queued_messages): Now static.
2847
a25f4dfa
PE
2848 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2849 * data.c (circular_list_error): Remove.
2850
14a9c8df
PE
2851 * commands.h (last_point_position, last_point_position_buffer):
2852 (last_point_position_window): Remove decls.
2853 * keyboard.c: Make these variables static.
2854
04f2d78b
CB
2855 * coding.h (coding, code_convert_region, encode_coding_gap):
2856 Remove decls.
74ab6df5
PE
2857 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2858 (iso_code_class, detect_coding, code_convert_region): Now static.
2859 (encode_coding_gap): Remove; unused.
2860
38dfbee1
PE
2861 * chartab.c (chartab_chars, chartab_bits): Now static.
2862
a2cb4e63
PE
2863 * charset.h (charset_iso_8859_1): Remove decl.
2864 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2865 Now static.
2866
127198fd
PE
2867 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2868 * ccl.c (Vccl_program_table): Now static.
2869 (check_ccl_update): Remove; unused.
2870
d85b608f
PE
2871 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2872 * category.h: ... from here.
2873 * category.c (check_category_table, set_category_set): Now static.
2874
31cd66f3
PE
2875 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2876 * lisp.h: Remove these decls.
2877
c358e587
PE
2878 * buffer.c (buffer_count): Remove unused var.
2879
e78aecca
PE
2880 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2881 so that it's not optimized away.
2882 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2883 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2884 exported only to the debugger.
2885
e192d7d3 2886 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2887 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2888
92470028
PE
2889 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2890 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2891 was inaccessible from Lisp.
2892 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2893 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2894
244ed907
PE
2895 alloc.c: Import and export fewer symbols, and remove unused items.
2896 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2897 is defined.
2898 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2899 it's not optimized away by whole-program optimization.
2900 (message_enable_multibyte, free_misc): Remove.
2901 (catchlist, handlerlist, mark_backtrace):
2902 Declare only if BYTE_MARK_STACK.
2903 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2904 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2905 (message_enable_multibyte): Remove decl.
2906 (free_misc, interval_free_list, float_block, float_block_index):
2907 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2908 (cons_free_list, last_marked_index):
2909 Now static.
2910 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2911 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2912 (mark_backtrace): Define only if BYTE_MARK_STACK.
2913 * xdisp.c (message_enable_multibyte): Now static.
2914
61c2b50e 2915 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2916 This makes it easier for human readers (and static analyzers)
2917 to see whether these variables are used from other modules.
2918 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2919 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2920 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2921 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2922 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2923 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2924 * xmenu.c, xselect.c:
2925 Declare Q* vars static if they are not used in other modules.
2926 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2927 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2928 Remove decls of unexported vars.
2929 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2930
95c82688
PE
2931 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2932
16a97296
PE
2933 Make Emacs functions such as Fatom 'static' by default.
2934 This makes it easier for human readers (and static analyzers)
2935 to see whether these functions can be called from other modules.
2936 DEFUN now defines a static function. To make the function external
2937 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2938 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2939 (Finit_image_library):
16a97296
PE
2940 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2941 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2942 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2943 Remove decls, since these functions are now static.
2944 (Funintern, Fget_internal_run_time): New decls, since these functions
2945 were already external.
95c82688 2946
16a97296
PE
2947 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2948 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2949 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2950 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2951 * keyboard.c, keymap.c, lread.c:
2952 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2953 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2954 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2955 Mark functions with DEFUE instead of DEFUN,
2956 if they are used in other modules.
2957 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2958 decls for now-static functions.
2959 * buffer.h (Fdelete_overlay): Remove decl.
2960 * callproc.c (Fgetenv_internal): Mark as internal.
2961 * composite.c (Fremove_list_of_text_properties): Remove decl.
2962 (Fcomposition_get_gstring): New forward static decl.
2963 * composite.h (Fcomposite_get_gstring): Remove decl.
2964 * dired.c (Ffile_attributes): New forward static decl.
2965 * doc.c (Fdocumntation_property): New forward static decl.
2966 * eval.c (Ffetch_bytecode): New forward static decl.
2967 (Funintern): Remove extern decl; now in .h file where it belongs.
2968 * fileio.c (Fmake_symbolic_link): New forward static decl.
2969 * image.c (Finit_image_library): New forward static decl.
2970 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2971 * intervals.h (Fprevious_property_change):
2972 (Fremove_list_of_text_properties): Remove decls.
2973 * keyboard.c (Fthis_command_keys): Remove decl.
2974 (Fcommand_execute): New forward static decl.
2975 * keymap.c (Flookup_key): New forward static decl.
2976 (Fcopy_keymap): Now static.
2977 * keymap.h (Flookup_key): Remove decl.
2978 * process.c (Fget_process): New forward static decl.
2979 (Fprocess_datagram_address): Mark as internal.
2980 * syntax.c (Fsyntax_table_p): New forward static decl.
2981 (skip_chars): Remove duplicate decl.
2982 * textprop.c (Fprevious_property_change): New forward static decl.
2983 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2984 Now internal.
2985 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2986 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2987
785bbd42
PE
2988 * editfns.c (Fformat): Remove unreachable code.
2989
8b913b57
AS
29902011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2991
2992 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2993 change. (Bug#8496)
2994
a6744a35
EZ
29952011-04-13 Eli Zaretskii <eliz@gnu.org>
2996
2997 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2998 when at ZV. (Bug#8487)
2999
e7974947
AS
30002011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3001
baad03f0
AS
3002 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3003 (Bug#8437)
3004 * keyboard.c (parse_tool_bar_item): Likewise.
3005 * sound.c (sound_cleanup, alsa_close): Likewise.
3006 * termcap.c (tgetent): Likewise.
3007 * xfns.c (x_default_font_parameter): Likewise.
3008 * xsettings.c (read_and_apply_settings): Likewise.
3009
e7974947
AS
3010 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3011 (overrun_check_free): Protoize.
3012
28272684
PE
30132011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3014
3015 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3016 since callers should never pass a negative size.
3017 Change the signature to match that of plain 'read' and 'write'; see
3018 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3019 * lisp.h: Update prototypes of emacs_write and emacs_read.
3020
11997c76
EZ
30212011-04-11 Eli Zaretskii <eliz@gnu.org>
3022
3023 * xdisp.c (redisplay_window): Don't try to determine the character
3024 position of the scroll margin if the window start point w->startp
e896f03c 3025 is outside the buffer's accessible region. (Bug#8468)
11997c76 3026
8a2cbd72
EZ
30272011-04-10 Eli Zaretskii <eliz@gnu.org>
3028
3029 Fix write-region and its subroutines for buffers > 2GB.
3030 * fileio.c (a_write, e_write): Modify declaration of arguments and
3031 local variables to support buffers larger than 2GB.
3032 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3033
3034 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3035 argument, local variables, and return value.
3036
3037 * lisp.h: Update prototypes of emacs_write and emacs_read.
3038
3039 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3040
4073e537 30412011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3042
1ebfdcb6
PE
3043 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3044
b2ded58d
PE
3045 Fix more problems found by GCC 4.6.0's static checks.
3046
7d66342c
PE
3047 * xdisp.c (vmessage): Use a better test for character truncation.
3048
bbf47d44
PE
3049 * charset.c (load_charset_map): <, not <=, for optimization,
3050 and to avoid potential problems with integer overflow.
9248994d 3051 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3052 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3053 * editfns.c (Fformat): Likewise.
1e69125e 3054 * syntax.c (skip_chars): Likewise.
3befa583 3055
e3019616
PE
3056 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3057 This also lets GCC 4.6.0 generate slightly better loop code.
3058
becfa255
PE
3059 * callint.c (Fcall_interactively): <, not <=, for optimization.
3060 (Fcall_interactively): Count the number of arguments produced,
3061 not the number of arguments given. This is simpler and lets GCC
3062 4.6.0 generate slightly better code.
3063
dae0cd48
PE
3064 * ftfont.c: Distingish more carefully between FcChar8 and char.
3065 The previous code passed unsigned char * to a functions like
3066 strlen and xstrcasecmp that expect char *, which does not
3067 conform to the C standard.
3068 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3069 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3070 char * when the C standard requires it.
3071
76032d70
PE
3072 * keyboard.c (read_char): Remove unused var.
3073
eb3f1cc8
PE
3074 * eval.c: Port to Windows vsnprintf (Bug#8435).
3075 Include <limits.h>.
3076 (SIZE_MAX): Define if the headers do not.
3077 (verror): Do not give up if vsnprintf returns a negative count.
3078 Instead, grow the buffer. This ports to Windows vsnprintf, which
3079 does not conform to C99. Problem reported by Eli Zaretskii.
3080 Also, simplify the allocation scheme, by avoiding the need for
3081 calling realloc, and removing the ALLOCATED variable.
3082
70476b54
PE
3083 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3084
12020a9e
PE
3085 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3086 But keep the doprint source code for now, as we might revamp it
3087 and use it again (Bug#8435).
ea6c7ae6
PE
3088 * lisp.h (doprnt): Remove.
3089 * Makefile.in (base_obj): Remove doprnt.o.
3090 * deps.mk (doprnt.o): Remove.
3091
5fdb398c
PE
3092 error: Print 32- and 64-bit integers portably (Bug#8435).
3093 Without this change, on typical 64-bit hosts error ("...%d...", N)
3094 was used to print both 32- and 64-bit integers N, which relied on
3095 undefined behavior.
3096 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3097 New macro.
3098 * lisp.h (error, verror): Mark as printf-like functions.
3099 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3100 Report overflow in size calculations when allocating printf buffer.
3101 Do not truncate output string at its first null byte.
3102 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3103 Truncate the output at a character boundary, since vsnprintf does not
3104 do that.
3105 * charset.c (check_iso_charset_parameter): Convert internal
3106 character to string before calling 'error', since %c now has the
3107 printf meaning.
3108 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3109 overflow when computing char to be passed to 'error'. Do not
3110 pass Lisp_Object to 'error'; pass the integer instead.
3111 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3112 formatted with plain %d.
3113
b189fa66
PE
3114 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3115
bff87ef0
PE
3116 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3117
7e2cac20
PE
3118 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3119
ce4d90b5
PE
3120 * xterm.c (x_catch_errors): Remove duplicate declaration.
3121
266c9547
PE
3122 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3123
79c49ad2
PE
3124 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3125
368f4090
JM
31262011-04-10 Jim Meyering <meyering@redhat.com>
3127
3128 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3129 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3130 return ssize_t not "int", and use size_t as the buffer length.
3131 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3132 * gnutls.h: Update declarations.
3133 * process.c (read_process_output): Use ssize_t, to match.
3134 (send_process): Likewise.
3135
a32d4040
CY
31362011-04-09 Chong Yidong <cyd@stupidchicken.com>
3137
3138 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3139
8546720e 31402011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3141
04f2d78b
CB
3142 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3143 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3144
8546720e
GM
3145 * xterm.c (handle_one_xevent):
3146 * xmenu.c (create_and_show_popup_menu):
3147 * xselect.c (x_decline_selection_request)
3148 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3149
0a2f5c1a 31502011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3151
3152 Fix some uses of `int' instead of EMACS_INT.
3153 * search.c (string_match_1, fast_string_match)
3154 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3155 (scan_buffer, find_next_newline_no_quit)
3156 (find_before_next_newline, search_command, Freplace_match)
3157 (Fmatch_data): Make some `int' variables be EMACS_INT.
3158
3159 * xdisp.c (display_count_lines): 3rd argument and return value now
3160 EMACS_INT. All callers changed.
3161 (pint2hrstr): Last argument is now EMACS_INT.
3162
3163 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3164 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3165 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3166 (decode_coding_utf_16, decode_coding_emacs_mule)
3167 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3168 (decode_coding_ccl, decode_coding_charset)
3169 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3170 (decode_coding_iso_2022, decode_coding_emacs_mule)
3171 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3172 <char_offset, last_offset>: Declare EMACS_INT.
3173 (encode_coding_utf_8, encode_coding_utf_16)
3174 (encode_coding_emacs_mule, encode_invocation_designation)
3175 (encode_designation_at_bol, encode_coding_iso_2022)
3176 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3177 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3178 Declare EMACS_INT.
3179 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3180 (encode_invocation_designation): Last argument P_NCHARS is now
3181 EMACS_INT.
3182 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3183 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3184
3185 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3186 All users changed.
3187
3188 * ccl.c (Fccl_execute_on_string): Declare some variables
3189 EMACS_INT.
3190
8546720e 31912011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3192
3193 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3194
4e19a977
CS
31952011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3196
3197 * process.c (Fformat_network_address): Doc fix.
3198
87302331
R
31992011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3200
3201 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3202
cbb59342
CY
32032011-04-08 Chong Yidong <cyd@stupidchicken.com>
3204
3205 * keyboard.c (read_char): Call Lisp function help-form-show,
3206 instead of using internal_with_output_to_temp_buffer.
3207 (Qhelp_form_show): New var.
e0d38eeb 3208 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3209
3210 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3211
3212 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3213
e67a13ab
CY
32142011-04-06 Chong Yidong <cyd@stupidchicken.com>
3215
04f2d78b
CB
3216 * process.c (Flist_processes): Remove to Lisp.
3217 (list_processes_1): Delete.
e67a13ab 3218
973f782d
EZ
32192011-04-06 Eli Zaretskii <eliz@gnu.org>
3220
7c106b1e
EZ
3221 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3222
973f782d
EZ
3223 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3224
41cf7d1a 32252011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3226
ca23cc88
PE
3227 Fix more problems found by GCC 4.6.0's static checks.
3228
f390e2d5
PE
3229 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3230
42eea0d0
PE
3231 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3232
b69769da 3233 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3234
f9541e84
PE
3235 * xdisp.c (vmessage): Mark as a printf-like function.
3236
13841b55
PE
3237 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3238
c136c10f
PE
3239 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3240
5e2d4a30
PE
3241 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3242 printf-like functions.
3243 (tiff_load): Add casts to remove these marks before passing them
3244 to system-supplied API.
3245
583f48b9
PE
3246 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3247
b25d760e
PE
3248 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3249 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3250 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3251 directly, rather than having caller test rule sign. This avoids
3252 some unnecessary tests.
3253 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3254 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3255 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3256
bc7b6697 3257 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3258 (xfont_open): Avoid unnecessary tests.
bc7b6697 3259
27ccc379
PE
3260 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3261
dcd5c89a
PE
3262 * composite.h, composite.c (composition_gstring_put_cache):
3263 Use EMACS_INT, not int, for length.
3264
b13a45c6
PE
3265 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3266 breaking out part of COMPOSITION_DECODE_RULE.
3267 (COMPOSITION_DECODE_RULE): Use it.
3268 * composite.c (get_composition_id): Remove unused local vars,
3269 by using the new macro.
3270
1e792e4d
PE
3271 * textprop.c (set_text_properties_1): Change while to do-while,
3272 since the condition is always true at first.
3273
dc6c6455 3274 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3275 (interval_deletion_adjustment): Return unsigned value.
3276 All uses changed.
dc6c6455 3277
aba7731a
PE
3278 * process.c (list_processes_1, create_pty, read_process_output):
3279 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3280 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3281 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3282 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3283 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3284
fdfc4bf3
PE
3285 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3286
fca8fe46 3287 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3288 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3289
06a0259a 3290 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3291 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3292 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3293
e7b9e80f
PE
3294 * print.c (print_error_message): Avoid int overflow.
3295
56201685
PE
3296 * font.c (font_list_entities): Redo for clarity,
3297 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3298
78834453 3299 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3300 (font_score): Avoid potential overflow in diff calculation.
78834453 3301
0bc0b309 3302 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3303 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3304
e610eaca
PE
3305 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3306
b895abce
PE
3307 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3308 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3309 can always succeed if overflow has undefined behavior.
3310
1f1d9321 3311 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3312 (wordify): Omit three unnecessary tests.
1f1d9321 3313
c59478bc
PE
3314 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3315 All callers changed. This avoids the need for an unused var.
3316
79b73827
PE
3317 * casefiddle.c (casify_region): Remove var that is set but not used.
3318
a4db5dfe
PE
3319 * dired.c (file_name_completion): Remove var that is set but not used.
3320
43aae36e
PE
3321 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3322
2a47c44d 3323 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3324 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3325
a37c69bf
PE
3326 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3327 Check for integer overflow on size calculations.
3328
328ab8e7
PE
3329 * buffer.c (Fprevious_overlay_change): Remove var that is set
3330 but not used.
3331
e5a2a5cb
PE
3332 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3333 Remove vars that are set but not used.
8d84a6eb 3334 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3335 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3336
a60e5f68
PE
3337 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3338
f661cb61 3339 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3340 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3341
f0397f5a
PE
3342 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3343 that are set but not used.
3344
8664db06 3345 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3346 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3347
6abdaa4a
PE
3348 * xselect.c (x_get_local_selection, x_handle_property_notify):
3349 Remove vars that are set but not used.
3350
0ce7538d 3351 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3352 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3353
9ae848fc
PE
3354 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3355 Remove var that is set but not used.
0b918413
PE
3356 (scroll_bar_windows_size): Now size_t, not int.
3357 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3358 Check for overflow.
9ae848fc 3359
a5a62657
PE
3360 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3361 (map_tty_color) [!defined MSDOS]: Likewise.
3362
5c5cdd39
PE
3363 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3364
66ebf983
PE
3365 * coding.c: Remove vars that are set but not used.
3366 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3367 All callers changed.
3368 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3369 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3370 (decode_coding_charset): Remove vars that are set but not used.
3371
1be4d761
PE
3372 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3373 that is set but not used.
3374
47553fa8
PE
3375 * print.c (print_object): Remove var that is set but not used.
3376
1f7196bf 3377 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3378 The gnulib version avoids calling malloc in the usual case,
3379 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3380 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3381 * filelock.c (current_lock_owner): Likewise.
3382 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3383 * sysdep.c: Include allocator.h, careadlinkat.h.
3384 (emacs_no_realloc_allocator): New static constant.
3385 (emacs_readlink): New function.
fdb61804
PE
3386 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3387 ../lib/careadlinkat.h.
d1fdcab7 3388
f84c17c7
SM
33892011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3390
3391 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3392 first non-nil return value).
3393
ef3862ad
JD
33942011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3395
3396 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3397 if not defined (Bug#8403).
3398
376a7006
JB
33992011-04-02 Juanma Barranquero <lekktu@gmail.com>
3400
3401 * xdisp.c (display_count_lines): Remove parameter `start',
3402 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3403 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3404 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3405 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3406 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3407 and thereabouts. All callers changed.
3408 (get_per_char_metric): Remove parameter `f', unused since
3409 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3410
6ca3801d
JM
34112011-04-02 Jim Meyering <meyering@redhat.com>
3412
3413 do not dereference NULL upon failed strdup
3414 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3415 (ns_get_family): Likewise.
3416
d8e2b5ba
JB
34172011-04-02 Juanma Barranquero <lekktu@gmail.com>
3418
3419 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3420
8c74fcbd
JD
34212011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3422
3423 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3424 later (Bug#8403).
3425
7200d79c
SM
34262011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3427
03408648 3428 Add lexical binding.
7200d79c 3429
03408648
SM
3430 * window.c (Ftemp_output_buffer_show): New fun.
3431 (Fsave_window_excursion):
3432 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3433
3434 * lread.c (lisp_file_lexically_bound_p): New function.
3435 (Fload): Bind Qlexical_binding.
3436 (readevalloop): Remove `evalfun' arg.
3437 Bind Qinternal_interpreter_environment.
3438 (Feval_buffer): Bind Qlexical_binding.
3439 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3440 Mark as dynamic.
3441 (syms_of_lread): Declare `lexical-binding'.
3442
3443 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3444
3445 * keyboard.c (eval_dyn): New fun.
3446 (menu_item_eval_property): Use it.
ca105506
SM
3447
3448 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3449
03408648
SM
3450 * fns.c (concat, mapcar1): Accept byte-code-functions.
3451
3452 * eval.c (Fsetq): Handle lexical vars.
3453 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3454 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3455 (FletX, Flet): Obey lexical binding.
3456 (Fcommandp): Handle closures.
3457 (Feval): New `lexical' arg.
3458 (eval_sub): New function extracted from Feval. Use it almost
3459 everywhere where Feval was used. Look up vars in lexical env.
3460 Handle closures.
3461 (Ffunctionp): Move from subr.el.
3462 (Ffuncall): Handle closures.
3463 (apply_lambda): Remove `eval_flags'.
3464 (funcall_lambda): Handle closures and new byte-code-functions.
3465 (Fspecial_variable_p): New function.
3466 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3467 but without exporting it to Lisp.
23aba0ea 3468
23aba0ea 3469 * doc.c (Fdocumentation, store_function_docstring):
03408648 3470 * data.c (Finteractive_form): Handle closures.
23aba0ea 3471
03408648
SM
3472 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3473 interactive spec.
ba83908c 3474
04f2d78b
CB
3475 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3476 New byte-codes.
03408648
SM
3477 (exec_byte_code): New function extracted from Fbyte_code to handle new
3478 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3479
03408648 3480 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3481
03408648 3482 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3483
e2abce01
JB
34842011-03-31 Juanma Barranquero <lekktu@gmail.com>
3485
3486 * xdisp.c (redisplay_internal): Fix prototype.
3487
63696a73 34882011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3489
63696a73 3490 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3491 (try_scrolling): Use it when setting scroll_limit.
3492 Limit scrolling to 100 screen lines.
63696a73
EZ
3493 (redisplay_window): Even when falling back on "recentering",
3494 position point in the window according to scroll-conservatively,
3495 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3496
3497 (try_scrolling): When point is above the window, allow searching
3498 as far as scroll_max, or one screenful, to compute vertical
3499 distance from PT to the scroll margin position. This prevents
3500 try_scrolling from unnecessarily failing when
3501 scroll-conservatively is set to a value slightly larger than the
3502 window height. Clean up the case of PT below the margin at bottom
3503 of window: scroll_max can no longer be INT_MAX. When aggressive
3504 scrolling is in use, don't let point enter the opposite scroll
3505 margin as result of the scroll.
3506 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3507 threshold of 100 lines for never-recentering scrolling.
3508
e4cc2dfc
JB
35092011-03-31 Juanma Barranquero <lekktu@gmail.com>
3510
3511 * dispextern.h (move_it_by_lines):
3512 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3513 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3514 (message_log_check_duplicate): Remove parameters `prev_bol' and
3515 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3516 (redisplay_internal): Remove parameter `preserve_echo_area',
3517 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3518
3519 * indent.c (Fvertical_motion):
3520 * window.c (window_scroll_pixel_based, Frecenter):
3521 Don't pass `need_y_p' to `move_it_by_lines'.
3522
1c470562
SM
35232011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3524
44f230aa
SM
3525 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3526 steal a few bits to be more compact.
3527 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3528 Remove unneeded casts.
3529
1c470562
SM
3530 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3531
888adce9
ZK
35322011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3533
3534 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3535 binding" message (bug#7967).
3536
f838ed7b
PE
35372011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3538
77861b95
PE
3539 Fix more problems found by GCC 4.6.0's static checks.
3540
de6dbc14
PE
3541 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3542 Remove unused local var.
3543
f838ed7b
PE
3544 * editfns.c (Fmessage_box): Remove unused local var.
3545
792c7b2b
PE
3546 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3547 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3548 Omit unused local vars.
c499e557 3549 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3550 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3551 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3552 Omit unused local var.
3553
ba0165e1
PE
3554 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3555 Don't assume string length fits in int.
32ad8845 3556 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3557 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3558
3c59b4c9
PE
3559 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3560 instead of alloca (Bug#8344).
3561
a3eed478 3562 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3563 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3564
eb4d412d
PE
3565 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3566
1658b401
PE
3567 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3568 concerns.
3569
3570 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3571
3572 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3573
9a2c6e05
PE
3574 * keyboard.c (syms_of_keyboard): Use the same style as later
3575 in this function when indexing through an array. This also
3576 works around GCC bug 48267.
3577
03d0a109
PE
3578 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3579
44f730c8
PE
3580 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3581
fe75f926
PE
3582 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3583 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3584
ffa8c828
PE
3585 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3586 This avoids undefined behavior on integer overflow, and is a bit
3587 more convenient anyway since it is compared to a size_t variable.
3588
c5101a77
PE
3589 Variadic C functions now count arguments with size_t, not int.
3590 This avoids an unnecessary limitation on 64-bit machines, which
3591 caused (substring ...) to crash on large vectors (Bug#8344).
3592 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3593 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3594 All variadic functions and their callers changed accordingly.
c5101a77
PE
3595 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3596 * data.c (arith_driver, float_arith_driver): Likewise.
3597 * editfns.c (general_insert_function): Likewise.
3598 * eval.c (struct backtrace.nargs, interactive_p)
3599 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3600 (funcall_lambda, mark_backtrace): Likewise.
3601 * fns.c (concat): Likewise.
3602 * frame.c (x_set_frame_parameters): Likewise.
3603 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3604 0 if not found, not -1. All callers changed.
3605
dd3f25f7
PE
3606 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3607 (stack_copy_size): Now size_t, not int.
3608 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3609
461c2ab9
JB
36102011-03-28 Juanma Barranquero <lekktu@gmail.com>
3611
3612 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3613 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3614 All callers changed.
3615
3616 * lisp.h (multibyte_char_to_unibyte):
3617 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3618 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3619 * character.h (CHAR_TO_BYTE8):
3620 * cmds.c (internal_self_insert):
3621 * editfns.c (general_insert_function):
3622 * keymap.c (push_key_description):
3623 * search.c (Freplace_match):
3624 * xdisp.c (message_dolog, set_message_1): All callers changed.
3625
f6d62986
SM
36262011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3627
3628 * keyboard.c (safe_run_hook_funcall): New function.
3629 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3630 don't set the hook to nil, but remove the offending function instead.
3631 (Qcommand_hook_internal): Remove, unused.
3632 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3633 Vcommand_hook_internal.
3634
3635 * eval.c (enum run_hooks_condition): Remove.
3636 (funcall_nil, funcall_not): New functions.
3637 (run_hook_with_args): Call each function through a `funcall' argument.
3638 Remove `cond' argument, now redundant.
3639 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3640 (Frun_hook_with_args_until_failure): Adjust accordingly.
3641 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3642
1db5b1ad
JB
36432011-03-28 Juanma Barranquero <lekktu@gmail.com>
3644
3645 * dispextern.h (string_buffer_position): Remove declaration.
3646
3647 * print.c (strout): Remove parameter `multibyte', unused since
3648 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3649
3650 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3651 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3652 All callers changed.
3653
3654 * w32.c (_wsa_errlist): Use braces for struct initializers.
3655
3656 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3657 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3658 All callers changed.
3659 (string_buffer_position): Likewise. Also, make static (it's never
3660 used outside xdisp.c).
3661 (cursor_row_p): Remove parameter `w', unused since
3662 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3663 (decode_mode_spec): Remove parameter `precision', introduced during
3664 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3665 All callers changed.
3666
5ffb62aa
JD
36672011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3668
3669 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3670
461c2ab9 36712011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3672
3673 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3674 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3675 (ns_update_auto_hide_menu_bar): New functions.
3676 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3677 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3678 ns_constrain_all_frames.
3679 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3680 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3681
5c380ffb
JD
36822011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3683
3684 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3685
9af30bdf
GM
36862011-03-27 Glenn Morris <rgm@gnu.org>
3687
3688 * syssignal.h: Replace RETSIGTYPE with void.
3689 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3690 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3691 Replace SIGTYPE with void everywhere.
3692 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3693 * s/template.h (SIGTYPE): Remove commented out definition.
3694
e2abce01
JB
36952011-03-26 Eli Zaretskii <eliz@gnu.org>
3696
3697 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3698 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3699
f868cd8a
JB
37002011-03-26 Juanma Barranquero <lekktu@gmail.com>
3701
59eb0929
JB
3702 * w32.c (read_unc_volume): Use parameter `henum', instead of
3703 global variable `wget_enum_handle'.
3704
3705 * keymap.c (describe_vector): Remove parameters `indices' and
3706 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3707 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3708
f868cd8a
JB
3709 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3710
3711 * keyboard.c (timer_check): Remove parameter `do_it_now',
3712 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3713 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3714 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3715
3716 * keyboard.c (read_char):
3717 * w32menu.c (w32_menu_display_help):
3718 * xmenu.c (show_help_event, menu_help_callback):
3719 Adjust calls to `show_help_echo'.
3720
3721 * gtkutil.c (xg_maybe_add_timer):
3722 * keyboard.c (readable_events):
3723 * process.c (wait_reading_process_output):
3724 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3725
3726 * insdel.c (adjust_markers_gap_motion):
3727 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3728 (gap_left, gap_right): Don't call it.
3729
2ecf6fdb
CY
37302011-03-25 Chong Yidong <cyd@stupidchicken.com>
3731
3732 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3733 incurred during fontification.
3734
6b1f9ba4
JB
37352011-03-25 Juanma Barranquero <lekktu@gmail.com>
3736
3737 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3738 (DEFVAR_PER_BUFFER): Don't pass it.
3739
3740 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3741 (scrolling_window): Don't pass it.
3742
0f4a96b5
JB
37432011-03-25 Juanma Barranquero <lekktu@gmail.com>
3744
3745 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3746
3747 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3748 and `suffix'.
3749 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3750 of variables specific to SELinux and computation of `encoded_absname'.
3751
3752 * image.c (XPutPixel): Remove unused variable `height'.
3753
3754 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3755
3756 * unexw32.c (get_section_info): Remove unused variable `section'.
3757
3758 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3759 (system_process_attributes): Remove unused variable `sess'.
3760 (sys_read): Remove unused variable `err'.
3761
3762 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3763 (w32_wnd_proc): Remove unused variable `isdead'.
3764 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3765 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3766 (x_create_tip_frame): Remove unused variable `tem'.
3767
3768 * w32inevt.c (w32_console_read_socket):
3769 Remove unused variable `no_events'.
3770
3771 * w32term.c (x_draw_composite_glyph_string_foreground):
3772 Remove unused variable `width'.
3773
1149507c
JB
37742011-03-24 Juanma Barranquero <lekktu@gmail.com>
3775
3776 * w32term.c (x_set_glyph_string_clipping):
3777 Don't pass uninitialized region to CombineRgn.
3778
9c88f339
JB
37792011-03-23 Juanma Barranquero <lekktu@gmail.com>
3780
3781 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3782 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3783 (Fx_close_connection): Remove unused variable `i'.
3784
3785 * w32font.c (w32font_draw): Return number of glyphs.
3786 (w32font_open_internal): Remove unused variable `i'.
3787 (w32font_driver): Add missing initializer.
3788
3789 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3790 (fill_in_menu): Remove unused variable `items_added'.
3791
3792 * w32term.c (last_mouse_press_frame): Remove static global variable.
3793 (w32_clip_to_row): Remove unused variable `f'.
3794 (x_delete_terminal): Remove unused variable `i'.
3795
3796 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3797 (NOTHING): Remove unused static global variable.
3798 (uniscribe_check_otf): Remove unused variable `table'.
3799 (uniscribe_font_driver): Add missing initializers.
3800
dee091a3
JD
38012011-03-23 Julien Danjou <julien@danjou.info>
3802
3803 * term.c (Fsuspend_tty, Fresume_tty):
3804 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3805 * window.c (temp_output_buffer_show):
3806 * insdel.c (signal_before_change):
3807 * frame.c (Fhandle_switch_frame):
3808 * fileio.c (Fdo_auto_save):
3809 * emacs.c (Fkill_emacs):
3810 * editfns.c (save_excursion_restore):
3811 * cmds.c (internal_self_insert):
3812 * callint.c (Fcall_interactively):
3813 * buffer.c (Fkill_all_local_variables):
3814 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3815 Use Frun_hooks.
0f4a96b5 3816 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3817 unconditionnaly since it does the check itself.
3818
2c520ab5 38192011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3820
c9c49752
PE
3821 Fix more problems found by GCC 4.5.2's static checks.
3822
8abc3f12
PE
3823 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3824 the first time through the loop, since we know p0 < p1 then.
3825 This also avoids a gcc -Wstrict-overflow warning.
3826
a2d26660
PE
3827 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3828 leading to a memory leak, possible in functions like
3829 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3830 of objects (Bug#8318).
a2d26660 3831
916c72e9
PE
3832 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3833 that could (at least in theory) be that large.
3834
19ab8a18
PE
3835 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3836 This is less likely to overflow, and avoids undefined behavior if
3837 overflow does occur. All callers changed. Use strtoul to scan
3838 for the unsigned long integer.
b7cbbd6f
PE
3839 (pint2hrstr): Simplify and tune code slightly.
3840 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3841
f0641eff
PE
3842 * scroll.c (do_scrolling): Work around GCC bug 48228.
3843 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3844
7f650bb9
PE
3845 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3846 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3847 (validate_x_resource_name): Simplify count usage.
3848 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3849
37dd57d1
PE
3850 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3851 fail (Bug#8306).
81e56e61 3852
699979fc 3853 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3854
401bf9b4
PE
3855 * process.c (Fmake_network_process): Use socklen_t, not int,
3856 where POSIX says socklen_t is required in portable programs.
3857 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3858 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3859 (Fmake_network_process, server_accept_connection):
3860 (wait_reading_process_output, read_process_output):
3861 Likewise.
3862
b93aacde
PE
3863 * process.c: Rename or move locals to avoid shadowing.
3864 (list_processes_1, Fmake_network_process):
3865 (read_process_output_error_handler, exec_sentinel_error_handler):
3866 Rename or move locals.
4dc343ee 3867 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3868 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3869 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3870 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3871 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3872
af8a867c 3873 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3874 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3875 Include tparam.h instead, since it declares them.
af8a867c
PE
3876 * cm.h (PC): Remove extern decl; tparam.h now does this.
3877 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3878 * terminfo.c: Include tparam.h, to check interfaces.
3879 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3880 (tparam): Adjust signature to match interface in tparam.h;
3881 this removes some undefined behavior. Check that outstring and len
3882 are zero, which they always are with Emacs.
3883 * tparam.h (PC, BC, UP): New extern decls.
3884
0248044d 3885 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3886 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3887
8ff096c1 3888 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3889 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3890 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3891 (ftfont_list): Remove unused local.
49eaafba
PE
3892 (get_adstyle_property, ftfont_pattern_entity):
3893 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3894 Rename locals to avoid shadowing.
8ff096c1 3895
e2be39f6
PE
3896 * xfont.c (xfont_list_family): Mark var as initialized.
3897
c9735e30
PE
3898 * xml.c (make_dom): Now static.
3899
8f5201ae
PE
3900 * composite.c (composition_compute_stop_pos): Rename local to
3901 avoid shadowing.
b246f932
PE
3902 (composition_reseat_it): Remove unused locals.
3903 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3904 (composition_update_it): Mark var as initialized.
11b61122
PE
3905 (find_automatic_composition): Mark vars as initialized,
3906 with a FIXME (Bug#8290).
8f5201ae 3907
760fbc2c
PE
3908 character.h: Rename locals to avoid shadowing.
3909 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3910 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3911 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3912 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3913 to avoid shadowing.
3914
ff08eb85
PE
3915 * textprop.c (property_change_between_p): Remove; unused.
3916
fc7bf025
PE
3917 * intervals.c (interval_start_pos): Now static.
3918
235d7abc
PE
3919 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3920
44f230aa
SM
3921 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3922 Rename locals to avoid shadowing.
3e7d6594 3923
50060332
PE
3924 * sound.c (wav_play, au_play, Fplay_sound_internal):
3925 Fix pointer signedness.
d01f234b 3926 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3927 (wav_play): Initialize a variable to 0, to prevent undefined
3928 behavior (Bug#8278).
50060332 3929
c4fc4e30
PE
3930 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3931
918436ed
PE
3932 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3933
c939f91b
PE
3934 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3935 clobbering (Bug#8298).
b9c7f648
PE
3936 * sysdep.c (sys_subshell): Likewise.
3937 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3938
6bd8c144
PE
3939 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3940 This should get cleaned up, so that child_setup has the
3941 same signature on all platforms.
3942
7710357c 3943 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3944 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3945
c59da222
CY
39462011-03-22 Chong Yidong <cyd@stupidchicken.com>
3947
3948 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3949 not to be necessary, and produces flickering.
3950
66b87493
GM
39512011-03-20 Glenn Morris <rgm@gnu.org>
3952
3953 * config.in: Remove file.
3954
45b6f6d5
JB
39552011-03-20 Juanma Barranquero <lekktu@gmail.com>
3956
3957 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3958 are now in src/globals.h.
3959 (syms_of_minibuf): Remove spurious & from previous change.
3960
3ec03f7e
LL
39612011-03-20 Leo <sdl.web@gmail.com>
3962
3963 * minibuf.c (completing-read-function): New variable.
3964 (completing-read-default): Rename from completing-read.
3965 (completing-read): Call completing-read-function.
3966
b14e3e21
CY
39672011-03-19 Juanma Barranquero <lekktu@gmail.com>
3968
3969 * xfaces.c (Fx_load_color_file):
3970 Read color file from absolute filename (bug#8250).
3971
f2b726e6
JB
39722011-03-19 Juanma Barranquero <lekktu@gmail.com>
3973
3974 * makefile.w32-in: Update dependencies.
3975
09f6ff02
EZ
39762011-03-17 Eli Zaretskii <eliz@gnu.org>
3977
3978 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3979
29a6015a
PE
39802011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3981
a3a6c54e
PE
3982 Fix more problems found by GCC 4.5.2's static checks.
3983
b766f867
PE
3984 * process.c (make_serial_process_unwind, send_process_trap):
3985 (sigchld_handler): Now static.
3986
be02381c
PE
3987 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3988 That way, the code declares only the vars that it needs.
3989 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3990 * s/cygwin.h (PTY_ITERATION): Likewise.
3991 * s/darwin.h (PTY_ITERATION): Likewise.
3992 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3993
57048744
PE
3994 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3995 * process.c (allocate_pty): Don't declare stb unless it's needed.
3996
7914961c 3997 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3998 (CONSTANTLIM): Remove; unused.
3999 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4000 Define only if needed.
7914961c 4001
b3967b18
PE
4002 * unexelf.c (unexec): Name an expression,
4003 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4004 Use a different way to cause a compilation error if anyone uses
4005 n rather than nn, a way that does not involve shadowing.
73366a00 4006 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4007
29a6015a
PE
4008 * deps.mk (unexalpha.o): Remove; unused.
4009
43cfc33e 4010 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4011 * unexec.h: New file.
ce701a33
PE
4012 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4013 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4014 Depend on unexec.h.
4015 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4016 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4017 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4018 Change as necessary to match prototype in unexec.h.
ce701a33 4019
01f44d5a
PE
4020 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4021 shadowing.
4f63c6bb 4022 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4023
a6670b0b
PE
4024 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4025 Rename locals to avoid shadowing.
4026
cef2010d 4027 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4028 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4029
d4d7173a
PE
4030 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4031
f08b802a
PE
4032 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4033 warning when compiling print.c.
4034
3ddb0639
PE
4035 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4036 instead of using an uninitialized var.
5ad03b97 4037 (font_sort_entities): Mark var as initialized.
3ddb0639 4038
170a2692
PE
4039 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4040
e663c700
PE
4041 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4042 pointers to constants.
89bc529a 4043 (font_parse_fcname): Remove unused vars.
7b81e2d0 4044 (font_delete_unmatched): Now static.
ea838e10 4045 (font_get_spec): Remove; unused.
13a547c6
PE
4046 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4047 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4048 Rename or move locals to avoid shadowing.
e663c700 4049
2a80c887 4050 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4051 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4052
1384fa33 4053 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4054 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4055
8b2c52e9
PE
4056 * alloc.c (mark_backtrace): Move decl from here ...
4057 * lisp.h: ... to here, so that it can be checked.
4058
475545b5 4059 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4060 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4061 (lisp_indirect_variable): Name an expression,
4062 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4063 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4064
b1349114 4065 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4066 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4067 Use const pointer when appropriate.
b1349114 4068
a2928364
PE
4069 * lisp.h (get_system_name, get_operating_system_release):
4070 Move decls here, to check interfaces.
4071 * process.c (get_operating_system_release): Move decl to lisp.h.
4072 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4073 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4074 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4075 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4076 (Fformat_time_string, Fencode_time, Finsert_char):
4077 (Ftranslate_region_internal, Fformat):
4078 Rename or remove local vars to avoid shadowing.
9710023e 4079 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4080
a415e694
PE
4081 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4082 avoid shadowing.
4083
8ef4622d
PE
4084 * lisp.h (eassert): Check that the argument compiles, even if
4085 ENABLE_CHECKING is not defined.
4086
946f9a5b
PE
4087 * data.c (Findirect_variable): Name an expression, to avoid
4088 gcc -Wbad-function-cast warning.
112396d6 4089 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4090 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4091 (Fmake_variable_buffer_local, Fmake_local_variable):
4092 Mark variables as initialized.
52746918 4093 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4094
e5aab7e7 4095 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4096 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4097 Rename locals to avoid shadowing.
dff45157
PE
4098 (mark_stack): Move local variables into the #ifdef region where
4099 they're used.
7bc26fdb
PE
4100 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4101 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4102 needed otherwise.
4103 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4104 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4105 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4106
e5aab7e7
PE
4107 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4108 avoids undefined behavior in theory.
4109
4da60324
PE
4110 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4111
88043301
PE
4112 Use functions, not macros, for up- and down-casing (Bug#8254).
4113 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4114 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4115 to use the following functions instead of these macros.
4116 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4117 EMACS_INT, since callers assume the returned value fits in int.
4118 (upcase1): Likewise, for UPCASE_TABLE.
4119 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4120 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4121 the race-condition problem in the old DOWNCASE.
88043301 4122
19ed5445
PE
4123 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4124 Rename locals to avoid shadowing.
4125 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4126 (regex_compile, re_search_2, re_match_2_internal):
4127 Remove unused local vars.
952db0d7
PE
4128 (FREE_VAR): Rewrite so as not to use empty "else",
4129 which gcc can warn about.
da053e48 4130 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4131 (RETALLOC_IF): Define only if needed.
4132 (WORDCHAR_P): Likewise. This one is never needed, but is used
4133 only in a comment talking about a compiler bug, so put inside
4134 the #if 0 of that comment.
4135 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4136 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4137 Remove; unused.
19ed5445 4138
1f3561e4 4139 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4140 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4141 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4142
ded6f8f7
PE
4143 * search.c (simple_search): Remove unused var.
4144
dbd37a95
PE
4145 * dired.c (compile_pattern): Move decl from here ...
4146 * lisp.h: ... to here, so that it can be checked.
4147 (struct re_registers): New forward decl.
4148
7e47afad
PE
4149 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4150
85f24f61
PE
4151 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4152 All uses changed.
4153 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4154 Rename locals to avoid shadowing.
5671df8f 4155 (Fvertical_motion): Mark locals as initialized.
85f24f61 4156
181aa2be 4157 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4158 (casify_region): Mark local as initialized.
181aa2be 4159
930d429c
PE
4160 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4161
7082eac6
PE
4162 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4163 New macros, so that the caller can use some names other than
4164 gcpro1, gcpro2, etc.
4165 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4166 of the new macros.
4167 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4168 argument, for consistency with GCPRO2_VAR, etc: it is now the
4169 prefix of the variable, not the variable itself. All uses
4170 changed.
38b2c076
PE
4171 * dired.c (directory_files_internal, file_name_completion):
4172 Rename locals to avoid shadowing.
4173
15206ed9
PE
4174 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4175 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4176 dired.c's scmp function, had undefined behavior.
4177 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4178 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4179 * buffer.h: ... to here, because these macros use current_buffer,
4180 and the new implementation with inline functions needs to have
4181 current_buffer in scope now, rather than later when the macros
4182 are used.
4183 (downcase, upcase1): New static inline functions.
4184 (DOWNCASE, UPCASE1): Reimplement using these functions.
4185 This avoids undefined behavior in expressions like
4186 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4187 from race conditions in accessing the global variables
4188 case_temp1 and case_temp2.
4189 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4190 * lisp.h (case_temp1, case_temp2): Remove their decls.
4191 * character.h (ASCII_CHAR_P): Move from here ...
4192 * lisp.h: ... to here, so that the inline functions mentioned
4193 above can use them.
4194
4a6bea26
PE
4195 * dired.c (directory_files_internal_unwind): Now static.
4196
f14b7e14
PE
4197 * fileio.c (file_name_as_directory, directory_file_name):
4198 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4199 Now static.
2893f146
PE
4200 (file_name_as_directory): Use const pointers when appropriate.
4201 (Fexpand_file_name): Likewise. In particular, newdir might
4202 point at constant storage, so make it a const pointer.
fd4ead52 4203 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4204 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4205 signedness issues.
f839df0c
PE
4206 (Fset_file_times, Finsert_file_contents, auto_save_error):
4207 Rename locals to avoid shadowing.
f14b7e14 4208
5716756e 4209 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4210 (Ftry_completion, Fall_completions): Rename or remove locals
4211 to avoid shadowing.
5716756e 4212
b4c3046a
PE
4213 * marker.c (bytepos_to_charpos): Remove; unused.
4214
b45db522
PE
4215 * lisp.h (verify_bytepos, count_markers): New decls,
4216 so that gcc does not warn that these functions aren't declared.
4217
85876d07
PE
4218 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4219 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4220 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4221 (copy_text): Remove unused local var.
85876d07 4222
03d78a21 4223 * filelock.c (within_one_second): Now static.
b3dd38ab 4224 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4225
5df8f01b
PE
4226 * buffer.c (fix_overlays_before): Mark locals as initialized.
4227 (fix_start_end_in_overlays): Likewise. This function should be
4228 simplified by using pointers-to-pointers, but that's a different
4229 matter.
b1d876f1 4230 (switch_to_buffer_1): Now static.
8f54f30a
PE
4231 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4232 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4233
a70072c9 4234 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4235 Fix pointer signedness issue.
edced198
PE
4236 (sys_subshell): Mark local as volatile if checking for lint,
4237 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4238 (MAXPATHLEN): Define only if needed.
a70072c9 4239
a0977c44
PE
4240 * process.c (serial_open, serial_configure): Move decls from here ...
4241 * systty.h: ... to here, so that they can be checked.
4242
a884fdcc
PE
4243 * fns.c (get_random, seed_random): Move extern decls from here ...
4244 * lisp.h: ... to here, so that they can be checked.
4245
604efe86 4246 * sysdep.c (reset_io): Now static.
b8950c94 4247 (wait_for_termination_signal): Remove; unused.
604efe86 4248
38fc62d9
PE
4249 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4250 (copy_keymap_item, append_key, push_text_char_description):
4251 Now static.
1004a21a 4252 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4253 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4254 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4255 (describe_map_tree):
4256 Rename locals to avoid shadowing.
38fc62d9 4257
2f2650da
PE
4258 * keyboard.c: Declare functions static if they are not used elsewhere.
4259 (echo_char, echo_dash, cmd_error, top_level_2):
4260 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4261 (read_char, kbd_buffer_get_event, make_lispy_position):
4262 (make_lispy_event, make_lispy_movement, apply_modifiers):
4263 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4264 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4265 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4266 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4267 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4268
a053e86c 4269 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4270 (mark_kboards): Move decl here ...
4271 * alloc.c (mark_kboards): ... from here.
a053e86c 4272
4752793e
PE
4273 * lisp.h (force_auto_save_soon): New decl.
4274
74f10ca7 4275 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4276 (DEFINE_DUMMY_FUNCTION): New macro.
4277 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4278 Use it.
c03cd23f
PE
4279 (main): Add casts to avoid warnings
4280 if GCC considers string literals to be constants.
74f10ca7 4281
022e70d4
PE
4282 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4283
59d6fe83
PE
4284 * dbusbind.c: Pointer signedness fixes.
4285 (xd_signature, xd_append_arg, xd_initialize):
4286 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4287 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4288 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4289 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4290
78320123
PE
4291 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4292 if GCC considers string literals to be constants.
49cebcca 4293 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4294
35ac2a97
SM
42952011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4296
fb103ca9
SM
4297 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4298 (print_preprocess, print_object): New macro to fix last change.
4299
35ac2a97
SM
4300 * print.c (print_preprocess): Don't forget font objects.
4301
62973b41
JB
43022011-03-16 Juanma Barranquero <lekktu@gmail.com>
4303
4304 * emacs.c (USAGE3): Doc fixes.
4305
0e48bb22
AS
43062011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4307
4308 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4309 structure.
4310
7684e57b
JB
43112011-03-14 Juanma Barranquero <lekktu@gmail.com>
4312
4313 * lisp.h (VWindow_system, Qfile_name_history):
4314 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4315 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4316 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4317
4318 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4319 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4320
4321 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4322 * w32console.c (detect_input_pending, read_input_pending)
4323 (encode_terminal_code):
4324 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4325 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4326 (w32_system_caret_y, Qfile_name_history):
4327 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4328 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4329 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4330 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4331 * w32proc.c (Qlocal, report_file_error):
4332 * w32term.c (Vwindow_system, updating_frame):
4333 * w32uniscribe.c (initialized, uniscribe_font_driver):
4334 Remove unneeded extern declarations.
4335
2aa46d6c
CY
43362011-03-14 Chong Yidong <cyd@stupidchicken.com>
4337
c96bbc66 4338 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4339
cffc6f3b
CY
43402011-03-13 Chong Yidong <cyd@stupidchicken.com>
4341
4342 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4343 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4344 These macros can no longer be used for assignment.
4345
44f230aa
SM
4346 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4347 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4348 (record_buffer_markers, fetch_buffer_markers): New functions for
4349 recording and fetching special buffer markers.
4350 (set_buffer_internal_1, set_buffer_temp): Use them.
4351
4352 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4353
4354 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4355
4356 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4357 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4358
4359 * xdisp.c (hscroll_window_tree):
4360 (reconsider_clip_changes): Use PT instead of BUF_PT.
4361
d251f04b
EZ
43622011-03-13 Eli Zaretskii <eliz@gnu.org>
4363
4364 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4365 $(EMACS_ROOT)/lib/intprops.h.
4366
f0c77cd1
PE
43672011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4368
3eca4629
PE
4369 Fix more problems found by GCC 4.5.2's static checks.
4370
7c86ee98
PE
4371 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4372 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4373 (xg_free_frame_widgets): Make it clear that a local variable is
4374 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4375 (gdk_window_get_screen): Make it clear that this macro is needed
4376 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4377 (int_gtk_range_get_value): New function, which avoids a diagnostic
4378 from gcc -Wbad-function-cast.
4379 (xg_set_toolkit_scroll_bar_thumb): Use it.
4380 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4381 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4382 (get_utf8_string, xg_get_file_with_chooser):
4383 Rename locals to avoid shadowing.
4384 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4385
41729b81
PE
4386 * xgselect.c (xg_select): Remove unused var.
4387
f0c77cd1
PE
4388 * image.c (four_corners_best): Mark locals as initialized.
4389 (gif_load): Initialize transparent_p to zero (Bug#8238).
4390 Mark another local as initialized.
ec6cf4c6 4391 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4392
ce0ad53d 4393 * image.c (clear_image_cache): Now static.
d5d5a617 4394 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4395 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4396 (x_edge_detection): Remove unnecessary cast that
4397 gcc -Wbad-function-cast diagnoses.
2037898d 4398 (gif_load): Fix pointer signedness.
6ae141d6
PE
4399 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4400 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4401
33383987 44022011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4403
d32df629
PE
4404 Improve quality of tests for time stamp overflow.
4405 For example, without this patch (encode-time 0 0 0 1 1
4406 1152921504606846976) returns the obviously-bogus value (-948597
4407 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4408 reports time overflow. See
4409 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4410 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4411 * editfns.c: Include limits.h and intprops.h.
4412 (TIME_T_MIN, TIME_T_MAX): New macros.
4413 (time_overflow): Move earlier, to before first use.
4414 (hi_time, lo_time): New functions, for an accurate test for
4415 out-of-range times.
4416 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4417 (Fget_internal_run_time): Don't assume time_t fits in int.
4418 (make_time): Use list2 instead of Fcons twice.
4419 (Fdecode_time): More accurate test for out-of-range times.
4420 (check_tm_member): New function.
4421 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4422 (lisp_time_argument): Don't rely on undefined left-shift and
4423 right-shift behavior when checking for time stamp overflow.
8be6f318 4424
fe31d94c
PE
4425 * editfns.c (time_overflow): New function, refactoring common code.
4426 (Fformat_time_string, Fdecode_time, Fencode_time):
4427 (Fcurrent_time_string): Use it.
4428
8be6f318
PE
4429 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4430 * dired.c (make_time): Move to ...
4431 * editfns.c (make_time): ... here.
4432 * systime.h: Note the move.
4433
09d9db2c 44342011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4435
126bc0dc
YM
4436 * fringe.c (update_window_fringes): Remove unused variables.
4437
c47cbdfd
YM
4438 * unexmacosx.c (copy_data_segment): Also copy __got section.
4439 (Bug#8223)
4440
7ac80be9
EZ
44412011-03-12 Eli Zaretskii <eliz@gnu.org>
4442
c96bbc66 4443 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4444 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4445 Constify `char *' arguments and their references according to
4446 prototypes in tparam.h.
4447
ecb0f94d 4448 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4449
7ac80be9
EZ
4450 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4451 Adapt all references accordingly.
4452
4453 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4454
ef1fd07e
TT
44552011-03-11 Tom Tromey <tromey@redhat.com>
4456
4457 * buffer.c (syms_of_buffer): Remove obsolete comment.
4458
7ef4b50c
EZ
44592011-03-11 Eli Zaretskii <eliz@gnu.org>
4460
4461 * termhooks.h (encode_terminal_code): Declare prototype.
4462
4463 * msdos.c (encode_terminal_code): Don't declare prototype.
4464
4465 * term.c (encode_terminal_code): Now external again, used by
4466 w32console.c and msdos.c.
4467
44f230aa
SM
4468 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4469 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4470
4b1ec863 44712011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4472
1714f52b 4473 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4474
4b1ec863
PE
4475 * fringe.c (update_window_fringes): Mark locals as initialized
4476 (Bug#8227).
4477 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4478
524c7aa6
PE
4479 * alloc.c (mark_fringe_data): Move decl from here ...
4480 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4481 to check its interface.
4482 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4483
a5c0af81 4484 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4485 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4486 (fontset_font): Mark local as initialized.
a9a06e0b 4487 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4488
b4716021
PE
4489 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4490
811e9bac 4491 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4492 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4493 (x_own_selection, Fx_disown_selection_internal): Rename locals
4494 to avoid shadowing.
4495 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4496
7e3ab302
PE
4497 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4498 so that the caller can use some name other than gcpro1.
4499 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4500 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4501 (Fx_backspace_delete_keys_p):
4502 Use them to avoid shadowing, and rename vars to avoid shadowing.
4503 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4504 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4505 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4506 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4507 Remove unused locals.
7e3ab302
PE
4508 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4509 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4510 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4511 macros.
f78faa98 4512
e2b13473
PE
4513 * xterm.h (x_mouse_leave): New decl.
4514
77f23912
PE
4515 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4516 Remove unused functions.
cdf4ba58
PE
4517 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4518 (x_calc_absolute_position): Now static.
7411c686 4519 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4520 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4521 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4522 unless they are used.
38d0b34a
PE
4523 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4524 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4525 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4526 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4527 (x_error_catcher, x_connection_closed, x_error_handler):
4528 (x_error_quitter, xembed_send_message, x_iconify_frame):
4529 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4530 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4531 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4532
44f230aa
SM
4533 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4534 Rename or move locals to avoid shadowing.
6b463e58 4535 (tty_defined_color, merge_face_heights): Now static.
5967d051 4536 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4537 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4538 does not deduce is never used uninitialized.
73719eba
PE
4539 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4540 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4541
426994c3 4542 * terminal.c (store_terminal_param): Now static.
5489860b 4543
032f1620 4544 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4545 (set_frame_menubar): Remove unused local.
d4323972 4546 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4547 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4548 since they might point to immutable storage.
281585b0
PE
4549 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4550 since it's unused otherwise.
032f1620 4551
367c19e5 4552 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4553 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4554 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4555 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4556 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4557 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4558 does not deduce are never used uninitialized.
70739cbe 4559
07b48fa9
PE
4560 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4561
8868a238 4562 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4563 * window.c (window_loop, size_window):
4564 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4565
7e5cf297 4566 * window.c (display_buffer): Now static.
d6550a9f
PE
4567 (size_window): Mark variables that gcc -Wuninitialized
4568 does not deduce are never used uninitialized.
a586633d
PE
4569 * window.h (check_all_windows): New decl, to forestall
4570 gcc -Wmissing-prototypes diagnostic.
5b555da1 4571 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4572
f6095868
PE
4573 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4574 shadowing.
4575 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4576 Include <limits.h>.
4577 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4578 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4579 (load_charset_map): Mark variables that gcc -Wuninitialized
4580 does not deduce are never used uninitialized.
53df7c11 4581 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4582
f38b440c
PE
4583 * coding.c (coding_set_source, coding_set_destination):
4584 Use "else { /* comment */ }" rather than "else /* comment */;"
4585 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4586 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4587 a block, when the outer 'i' will do.
4588 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4589 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4590 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4591 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4592 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4593 Rename locals to avoid shadowing.
4594 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4595 * coding.c (emacs_mule_char, encode_invocation_designation):
4596 Now static, since they're not used elsewhere.
413bb2db 4597 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4598 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4599 (decode_coding_emacs_mule): Mark variables that gcc
4600 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4601 (detect_coding_iso_2022): Initialize a local variable that might
4602 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4603 this initialization is needed. (Bug#8211)
5f58e762
PE
4604 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4605 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4606 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4607 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4608 Remove unused macros.
f38b440c 4609
232b38b9 4610 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4611 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4612 * character.c (string_count_byte8): Likewise.
232b38b9 4613
fb90da1b
PE
4614 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4615 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4616
fb93dbc2
PE
4617 * chartab.c (copy_sub_char_table): Now static, since it's not used
4618 elsewhere.
5c156ace
PE
4619 (sub_char_table_ref_and_range, char_table_ref_and_range):
4620 Rename locals to avoid shadowing.
bbcd0949 4621 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4622
7d3b3862 4623 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4624 (BIDI_BOB): Remove unused macro.
7d3b3862 4625
6be7d3da
PE
4626 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4627 deduce are never used uninitialized.
c2ed9c8b 4628 * term.c (encode_terminal_code): Likewise.
6be7d3da 4629
75f8807f 4630 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4631
50938595
PE
4632 * tparam.h: New file.
4633 * term.c, tparam.h: Include it.
4634 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4635 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4636 Move these decls to tparam.h, and make them agree with what
4637 is actually in tparam.c. The previous trick of using incompatible
4638 decls in different modules does not conform to the C standard.
4639 All callers of tparam changed to use tparam's actual API.
4640 * tparam.c (tparam1, tparam, tgoto):
4641 Use const pointers where appropriate.
4642
fbceeba2
PE
4643 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4644 * cm.h (struct cm): Likewise.
4645 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4646 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4647 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4648 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4649 (turn_on_face, init_tty): Likewise.
4650 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4651
7f3f1250
PE
4652 * term.c (term_mouse_position): Rename local to avoid shadowing.
4653
e6ca6543
PE
4654 * alloc.c (mark_ttys): Move decl from here ...
4655 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4656
c40f8d15
AS
46572011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4658
4659 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4660
cfe0661d
JB
46612011-03-09 Juanma Barranquero <lekktu@gmail.com>
4662
4663 * search.c (compile_pattern_1): Remove argument regp, unused since
4664 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4665 (compile_pattern): Don't pass it.
4666
0afb4571
J
46672011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4668
4669 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4670 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4671 for ! HAVE_GTK3.
4672 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4673
4674 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4675
4676 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4677 gdk_window_get_screen, gdk_window_get_geometry,
4678 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4679 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4680 (xg_get_pixbuf_from_pixmap): New function.
4681 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4682 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4683 Call xg_get_pixbuf_from_pixmap instead of
4684 gdk_pixbuf_get_from_drawable.
4685 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4686 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4687 (xg_check_special_colors): Use GtkStyleContext and its functions
4688 for HAVE_GTK3.
4689 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4690 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4691 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4692 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4693 Call gtk_widget_get_preferred_size.
0afb4571
J
4694 (xg_frame_resized): gdk_window_get_geometry only takes 5
4695 parameters.
44f230aa
SM
4696 (xg_win_to_widget, xg_event_is_for_menubar):
4697 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4698 (xg_set_widget_bg): New function.
4699 (delete_cb): New function.
895009e1 4700 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4701 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4702 (xg_set_background_color): Call xg_set_widget_bg.
4703 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4704 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4705 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4706 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4707 if ! HAVE_GTK3.
4708 (update_frame_tool_bar): Call gtk_widget_hide.
4709 (xg_initialize): Use GDK_KEY_g.
4710
4711 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4712 if ! HAVE_GTK3
4713 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4714
4715 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4716 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4717 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4718
1c2cc4ef
JB
47192011-03-08 Juanma Barranquero <lekktu@gmail.com>
4720
4721 * w32xfns.c (select_palette): Check success of RealizePalette against
4722 GDI_ERROR, not zero.
4723
33383987 4724See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4725
4726;; Local Variables:
4727;; coding: utf-8
aac0c6e3
MR
4728;; End:
4729
33383987 4730 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4731
4732 This file is part of GNU Emacs.
4733
4734 GNU Emacs is free software: you can redistribute it and/or modify
4735 it under the terms of the GNU General Public License as published by
4736 the Free Software Foundation, either version 3 of the License, or
4737 (at your option) any later version.
4738
4739 GNU Emacs is distributed in the hope that it will be useful,
4740 but WITHOUT ANY WARRANTY; without even the implied warranty of
4741 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4742 GNU General Public License for more details.
4743
4744 You should have received a copy of the GNU General Public License
4745 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.