Remove LD_SWITCH_X_SITE_AUX, which is no longer used
[bpt/emacs.git] / src / ChangeLog
CommitLineData
4737362e
GM
12012-05-01 Glenn Morris <rgm@gnu.org>
2
3 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4
74dd3a6b
AS
52012-04-30 Andreas Schwab <schwab@linux-m68k.org>
6
7 * .gdbinit (xpr): Remove checks for no longer existing misc types.
8 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
9 Remove.
10
13c379ee
PE
112012-04-28 Paul Eggert <eggert@cs.ucla.edu>
12
13 Do not avoid creating empty evaporating overlays (Bug#9642).
14 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
15 That is, do not delete an evaporating overlay if it becomes
16 empty after its bounds are adjusted to fit within its buffer.
17 This fix caused other problems, and I'm reverting it until we get
18 to the bottom of them.
19
a8e7d6d7 202012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
21
22 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
23
a8e7d6d7 242012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
25
26 * xdisp.c (pos_visible_p): If the window start position is beyond
27 ZV, start the display from buffer beginning. Prevents assertion
28 violation in init_iterator when the minibuffer window is scrolled
29 via the scroll bar.
30
31 * window.c (window_scroll_pixel_based): Likewise.
32
a8e7d6d7 332012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
34
35 * keymap.c (where_is_internal): Doc fix (Bug#10872).
36
a8e7d6d7 372012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
38
39 * fileio.c (Fcopy_file, Fset_file_selinux_context):
40 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
41
a8e7d6d7 422012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685
EZ
43
44 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers): Don't
45 overrun array limits of glyph row's used[] array. (Bug#11288)
46
1c6900d9
EZ
472012-04-26 Eli Zaretskii <eliz@gnu.org>
48
4c3fa1d9
EZ
49 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
50 display element, check also the underlying string or buffer
51 character. (Bug#11341)
52
1c6900d9
EZ
53 * w32menu.c: Include w32heap.h.
54 (add_menu_item): If the call to AppendMenuW (via
55 unicode_append_menu) fails, disable Unicode menus only if we are
56 running on Windows 9X/Me.
57
42bf8205
AS
582012-04-24 Andreas Schwab <schwab@linux-m68k.org>
59
60 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
61 (xgetint): Add missing shift for LSB tags.
62
b1bac16e
MR
632012-04-24 Martin Rudalics <rudalics@gmx.at>
64
65 * keyboard.c (read_char): Don't wipe echo area for select window
66 events: These might get delayed via `mouse-autoselect-window'
67 (Bug#11304).
68
d69621cc
JB
692012-04-24 Juanma Barranquero <lekktu@gmail.com>
70
71 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
72 manipulation of :loaded-from data.
73
02fd101b
JB
742012-04-23 Juanma Barranquero <lekktu@gmail.com>
75
76 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
77 now a cons (bug#11311).
78
888bec30
PE
792012-04-23 Paul Eggert <eggert@cs.ucla.edu>
80
89a438bd
PE
81 Do not create empty overlays with the evaporate property (Bug#9642).
82 * buffer.c (Fmove_overlay): Delete an evaporating overlay
83 if it becomes empty after its bounds are adjusted to fit within
84 its buffer. Without this fix, in a nonempty buffer (let ((o
85 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
86 yields an empty overlay that has the evaporate property, which is
87 not supposed to happen.
88
1068fe4d
PE
89 Fix minor GTK3 problems found by static checking.
90 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
91 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
92 (struct _EmacsFixedClass, emacs_fixed_get_type):
93 Move decls here from emacsgtkfixed.h, since they needn't be public.
94 (emacs_fixed_get_type): Now static.
95 (emacs_fixed_class_init): Omit unused local.
96 (emacs_fixed_child_type): Remove; unused.
97 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
98 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
99 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
100 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
101 (EMACS_FIXED_GET_CLASS): Remove; unused.
102 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
103
888bec30
PE
104 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
105 Problem reported by Juanma Barranquero for Windows -Wunused-function.
106
de85e130
PE
1072012-04-22 Paul Eggert <eggert@cs.ucla.edu>
108
d0baac98
PE
109 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
110 * gmalloc.c: (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
111 (__malloc_size_t, __malloc_ptrdiff_t):
112 Remove. All uses removed, replaced by the definiens if needed,
113 since we can assume C89 or better now.
114 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
115 (protect_malloc_state, align, get_contiguous_space)
116 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
117 (malloc_atfork_handler_child, malloc_enable_thread)
118 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
119 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
120 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
121 (special_realloc, _realloc_internal_nolock, _realloc_internal)
122 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
123 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
124 Define using prototypes, not old style.
125 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
126 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
127 (align): Don't assume that signed integer overflow wraps around.
128 Omit unused local var.
129 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
130 (_free_internal_nolock, memalign, mallochook, reallochook):
131 Omit no-longer-needed casts.
132 (valloc): Use getpagesize, not __getpagesize.
133 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
134 (struct hdr): The 'magic' member is now size_t, not unsigned long.
135
de85e130
PE
136 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
137
dcbf5805
MA
1382012-04-22 Michael Albinus <michael.albinus@gmx.de>
139
140 Move functions from C to Lisp. Make non-blocking method calls
141 the default. Implement further D-Bus standard interfaces.
142
143 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
144 (QCdbus_request_name_allow_replacement)
145 (QCdbus_request_name_replace_existing)
146 (QCdbus_request_name_do_not_queue)
147 (QCdbus_request_name_reply_primary_owner)
148 (QCdbus_request_name_reply_in_queue)
149 (QCdbus_request_name_reply_exists)
150 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
151 (QCdbus_registered_serial, QCdbus_registered_method)
152 (QCdbus_registered_signal): New Lisp objects.
153 (XD_DEBUG_MESSAGE): Use sizeof.
154 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
155 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
156 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
157 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
158 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
159 (xd_signature, xd_append_arg): Allow float for integer types.
160 (xd_get_connection_references): New function.
161 (xd_get_connection_address): Rename from xd_initialize. Return
162 cached address.
163 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
164 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
165 level.
166 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
167 Return number of recounts.
168 (Fdbus_get_unique_name): Make stronger parameter check.
169 (Fdbus_message_internal): New defun.
170 (Fdbus_call_method, Fdbus_call_method_asynchronously)
171 (Fdbus_method_return_internal, Fdbus_method_error_internal)
172 (Fdbus_send_signal, Fdbus_register_service)
173 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
174 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
175 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
176 (Vdbus_compiled_version, Vdbus_runtime_version)
177 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
178 (Vdbus_message_type_method_return, Vdbus_message_type_error)
179 (Vdbus_message_type_signal): New defvars.
180 (Vdbus_registered_buses, Vdbus_registered_objects_table): Adapt
181 docstring.
182
52828e02
PE
1832012-04-22 Paul Eggert <eggert@cs.ucla.edu>
184
da05bc4c
PE
185 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
186 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
187 Do not assume ptrdiff_t is the same width as 'int'.
188
52828e02
PE
189 * alloc.c: Handle unusual debugging option combinations.
190 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
191 since the two debugging options are incompatible.
192 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
193 is defined.
194 (mem_init, mem_insert, mem_insert_fixup):
195 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
196 (NEED_MEM_INSERT): Remove; no longer needed.
197
f01769f9
LL
1982012-04-22 Leo Liu <sdl.web@gmail.com>
199
200 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
201
5790543d
PE
2022012-04-22 Paul Eggert <eggert@cs.ucla.edu>
203
204 * sysdep.c [__FreeBSD__]: Minor cleanups.
205 (list_system_processes, system_process_attributes) [__FreeBSD__]:
206 Use Emacs indenting style more consistently. Avoid some casts.
207 Use 'double' consistently rather than mixing 'float' and 'double'.
208
b91b7e4d
EW
2092012-04-21 Eduard Wiebe <usenet@pusto.de>
210
211 * sysdep.c (list_system_processes, system_process_attributes): Add
212 implementation for FreeBSD (Bug#5243).
213
6114eb15
AS
2142012-04-21 Andreas Schwab <schwab@linux-m68k.org>
215
216 * lisp.mk (lisp): Update.
217
2f38dff7
PE
2182012-04-20 Paul Eggert <eggert@cs.ucla.edu>
219
220 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
221 It is never used otherwise.
222
4ae29f89
SM
2232012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
224
225 * print.c (print_preprocess): Only check print_depth if print-circle
226 is nil.
227 (print_object): Check for cycles even when print-circle is nil and
228 print-gensym is t, but only check print_depth if print-circle is nil.
229
f30d612a
CY
2302012-04-20 Chong Yidong <cyd@gnu.org>
231
232 * process.c (wait_reading_process_output): If EIO occurs on a pty,
233 set the status to "failed" and ensure that sentinel is run.
234
c07a4c0b 2352012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
236
237 * process.c (Fset_process_inherit_coding_system_flag)
238 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 239 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 240
c07a4c0b 2412012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
242
243 * xdisp.c (string_buffer_position_lim): Limit starting position to
244 BEGV.
245 (set_cursor_from_row): If called for a mode-line or header-line
246 row, return zero immediately.
247 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
248 farther than the first row after the header line, if any.
249 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
250 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
251
c07a4c0b 2522012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 253
4ae29f89
SM
254 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
255 (bug#11238).
ad3a2b41 256
c07a4c0b 2572012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 2582012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
259
260 configure: new option --enable-gcc-warnings (Bug#11207)
261 * Makefile.in (C_WARNINGS_SWITCH): Remove.
262 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
263 (ALL_CFLAGS): Use new macros rather than old.
264 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
265 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
266 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
267 -Wunused-result, -Wunused-variable. This should go away once
268 the Emacs and Gnulib regex code is merged.
269 (xmalloc, xrealloc): Now static.
270
aba027e8
PE
2712012-04-17 Paul Eggert <eggert@cs.ucla.edu>
272
273 * dired.c (Fsystem_groups): Remove unused local.
274
e5a36063
GM
2752012-04-17 Glenn Morris <rgm@gnu.org>
276
277 * dired.c (Fsystem_users): Doc fix.
278
316411f0
DA
2792012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
280
281 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
282 (syms_of_dired): Add them.
283
9426aba4
PE
2842012-04-16 Paul Eggert <eggert@cs.ucla.edu>
285
b62a57be
PE
286 Fix minor alloc.c problems found by static checking.
287 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
288 New extern decls, to avoid calling undeclared functions.
289 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
290 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
291 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
292 (NEED_MEM_INSERT): New macro.
293 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 294 Remove one incorrect comment and fix another.
b62a57be 295
3539f31f
PE
296 Fix minor ralloc.c problems found by static checking.
297 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
298 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
299 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
300 (r_alloc_sbrk): Now static.
301
a041960a
PE
302 Improve ralloc.c interface checking.
303 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
304 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
305 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
306 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
307 [REL_ALLOC]: ... to here, to check interface.
308 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
309 Remove decls. This fixes an "It stinks!".
310
9426aba4
PE
311 * alloc.c (which_symbols): Fix alignment issue / type clash.
312
d55c12ed
AS
3132012-04-15 Andreas Schwab <schwab@linux-m68k.org>
314
315 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
316 (struct Lisp_Misc_Any): Likewise.
317 (struct Lisp_Free): Likewise.
318 * alloc.c (union aligned_Lisp_Symbol): Define.
319 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
320 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
321 (union aligned_Lisp_Misc): Define.
322 (MARKER_BLOCK_SIZE, struct marker_block): Use union
323 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 324 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 325
b948ce8b
PE
3262012-04-14 Paul Eggert <eggert@cs.ucla.edu>
327
328 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
329 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
330 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
331 * s/netbsd.h, s/sol2-6.h:
332 Remove definition of GC_MARK_STACK, since the default now works.
333 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
334 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
335 no longer the default.
336 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
337
35dc09a1 3382012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 339
35dc09a1
GM
340 * lread.c (lisp_file_lexically_bound_p):
341 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 342
35dc09a1
GM
3432012-04-14 Eli Zaretskii <eliz@gnu.org>
344
345 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
346 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
347
3482012-04-14 Jan Djärv <jan.h.d@swipnet.se>
349
350 * nsterm.m (constrainFrameRect): Always constrain when there is only
351 one screen (Bug#10962).
352
bcd86815
KB
3532012-04-13 Ken Brown <kbrown@cornell.edu>
354
355 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
356
c25df26e
RT
3572012-04-13 Reuben Thomas <rrt@sc3d.org>
358
359 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
360
0fc59f1e
DC
3612012-04-11 Daniel Colascione <dancol@dancol.org>
362
363 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
364 against is gone. It's better to use vfork now so that when Cygwin
365 gains a new, working vfork, we use it automatically (bug#10398).
366
de8c03dc
SM
3672012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
368
369 * window.c (save_window_save): Obey window-point-insertion-type.
370
2f097256
GM
3712012-04-11 Glenn Morris <rgm@gnu.org>
372
373 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
374
453b951e
SM
3752012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
376
377 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
378
75f1671a 3792012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
380
381 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
382 (force_quit_count): New var.
383 (handle_interrupt): Use it.
384
2a8ce227
JB
3852012-04-10 Juanma Barranquero <lekktu@gmail.com>
386
387 * w32.c (w32_delayed_load): Record the full path of the library
388 being loaded (bug#10424).
389
935396c0
GM
3902012-04-09 Glenn Morris <rgm@gnu.org>
391
05920a43
GM
392 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
393 not just in the obarray, before snarfing them. (Bug#11036)
394
935396c0
GM
395 * Makefile.in ($(leimdir)/leim-list.el):
396 Pass EMACS rather than BUILT_EMACS.
397
a18ecafa
TZ
3982012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
399
400 * process.c (make_process):
401 * process.h: Add integer `gnutls_handshakes_tried' member to
402 process struct.
403
6bbef4e5
JC
404 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
405 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
406
407 * gnutls.c (gnutls_log_function2i): Convenience log function.
408 (emacs_gnutls_read): Use new log functions,
409 `gnutls_handshakes_tried' process member, and
410 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
411 attempts per process (connection).
412
b4d3bc10
CY
4132012-04-09 Chong Yidong <cyd@gnu.org>
414
415 * eval.c (Fuser_variable_p, user_variable_p_eh)
416 (lisp_indirect_variable): Functions deleted.
417 (Fdefvar): Caller changed.
418
419 * callint.c (Finteractive, Fcall_interactively):
420 * minibuf.c (Fread_variable): Callers changed.
421
70f4d973
EZ
4222012-04-09 Eli Zaretskii <eliz@gnu.org>
423
424 * xdisp.c (set_cursor_from_row): If the display string appears in
425 the buffer at position that is closer to point than the position
426 after the display string, display the cursor on the first glyph of
427 the display string. Fixes cursor display when a 'display' text
428 property immediately follows invisible text. (Bug#11094)
429
cb3c2e3e
PE
4302012-04-09 Paul Eggert <eggert@cs.ucla.edu>
431
432 composite.c: use 'double' consistently
433 * composite.c (get_composition_id): Use 'double' consistently
434 instead of converting 'float' to 'double' and vice versa; this is
435 easier to understand and avoids a GCC warning.
436
fd06db5d
GM
4372012-04-09 Glenn Morris <rgm@gnu.org>
438
50fe702a
GM
439 * Makefile.in: Generate leim-list with bootstrap-emacs, in
440 preparation for dumping it with emacs. (Bug#4789)
441 (leimdir): New variable.
442 ($(leimdir)/leim-list.el): New rule.
443 (emacs$(EXEEXT)): Depend on leim-list.el.
444
fd06db5d
GM
445 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
446 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
447 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
448
55c131ee
AS
4492012-04-08 Andreas Schwab <schwab@linux-m68k.org>
450
451 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
452 proper alignment.
453
9209588f
JB
4542012-04-07 Juanma Barranquero <lekktu@gmail.com>
455
456 * xml.c (init_libxml2_functions) [WINDOWSNT]:
457 Remove unused local variable.
458
e3fb2efb
PE
4592012-04-07 Paul Eggert <eggert@cs.ucla.edu>
460
461 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
462 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
463 (mark_memory): Mark Lisp_Objects only if pointers might hide in
464 objects, as mark_maybe_pointer will catch them otherwise.
465 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
466 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
467
b5385551
PE
4682012-04-07 Paul Eggert <eggert@cs.ucla.edu>
469
470 Fix typo that broke non-Windows builds.
471 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
472
9078ead6
EZ
4732012-04-07 Eli Zaretskii <eliz@gnu.org>
474
475 Support building on MS-Windows with libxml2.
476
477 * makefile.w32-in (OBJ2): Add xml.$(O).
478 (GLOBAL_SOURCES): Add xml.c.
479 ($(BLD)/xml.$(O)): New dependency list.
480
481 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
482 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
483 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
484 [!WINDOWSNT]: New macros.
485 (init_libxml2_functions, libxml2_loaded_p): New functions.
486 (parse_region): Call fn_xmlCheckVersion instead of using the macro
487 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
488 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
489 Calls xmlCleanupParser only if libxml2 was loaded (or statically
490 linked in).
6bbef4e5
JC
491 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
492 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
493 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
494
495 * emacs.c: Don't include libxml/parser.h.
496 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
497 xmlCleanupParser directly.
498
499 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
500
3811fdf3
EZ
5012012-04-07 Eli Zaretskii <eliz@gnu.org>
502
503 * indent.c (Fvertical_motion): If there is a display string at
504 point, use it.vpos to compute how many lines to backtrack after
505 move_it_to point. (Bug#11133)
506
2f8e16b2
EZ
5072012-04-06 Eli Zaretskii <eliz@gnu.org>
508
509 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
510 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
511 about subtle differences between FETCH_CHAR* and STRING_CHAR*
512 macros related to unification of CJK characters. For the details,
513 see the discussion following the message here:
514 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
515
3d439cd1
CY
5162012-04-04 Chong Yidong <cyd@gnu.org>
517
518 * keyboard.c (Vdelayed_warnings_list): Doc fix.
519
8bc53d00
EZ
5202012-04-01 Eli Zaretskii <eliz@gnu.org>
521
522 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
523 instead of alloca. (Bug#11138)
524
3b0512a3
AS
5252012-04-01 Andreas Schwab <schwab@linux-m68k.org>
526
527 * w32menu.c (is_simple_dialog): Properly check lisp types.
528 (Bug#11141)
529
8427ddd2
EZ
5302012-03-31 Eli Zaretskii <eliz@gnu.org>
531
979022ef
EZ
532 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
533 position we get to after a call to move_it_to fails the
534 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
535 only if we wind up in a string from display property. (Bug#11063)
536
a6b1c7cc
EZ
537 * window.c (Fdelete_other_windows_internal): Invalidate the row
538 and column information about mouse highlight, so that redisplay
539 restores it after reallocating the glyph matrices. (Bug#7464)
540
8427ddd2
EZ
541 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
542 string comes from a `display' text property, use the buffer
543 position of that property as if we actually saw that position in
544 the row's glyphs.
697ba24b
EZ
545 (move_it_by_lines): Remove the assertion that
546 "it->current_x == 0 && it->hpos == 0" which can be legitimately
547 violated when there's a before-string at the beginning of a line.
548 (Bug#11063)
8427ddd2 549
65a0a738
EZ
5502012-03-30 Eli Zaretskii <eliz@gnu.org>
551
552 * xdisp.c (append_space_for_newline): If the default face was
553 remapped, use the remapped face for the appended newline.
554 (extend_face_to_end_of_line): Use the remapped default face for
555 extending the face to the end of the line.
556 (display_line): Call extend_face_to_end_of_line when the default
557 face was remapped. (Bug#11068)
558
581355cc
EZ
5592012-03-29 Eli Zaretskii <eliz@gnu.org>
560
561 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
562
e8fc049f
SM
5632012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
564
565 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
566
4fb9a543
GM
5672012-03-27 Glenn Morris <rgm@gnu.org>
568
569 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
570 Doc fixes.
571
679910f1
KH
5722012-03-26 Kenichi Handa <handa@m17n.org>
573
574 * dispextern.h (struct glyph): Fix previous change. Change the
575 bit length of glyphless.ch to 25 (Bug#11082).
576
90d49b7f
CY
5772012-03-26 Chong Yidong <cyd@gnu.org>
578
579 * keyboard.c (Vselection_inhibit_update_commands): New variable.
580 (command_loop_1): Use it; inhibit selection update for
581 handle-select-window too (Bug#8996).
582
f514f6f0
FP
5832012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
584
e8fc049f 585 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 586
bf43fa51
KH
5872012-03-25 Kenichi Handa <handa@m17n.org>
588
589 * dispextern.h (struct glyph): Change the bit length of
590 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
591
8a0c01dd
EZ
5922012-03-24 Eli Zaretskii <eliz@gnu.org>
593
594 * s/ms-w32.h (tzname): Include time.h before redirecting to
595 _tzname. Fixes the MSVC build. (Bug#9960)
596
7d1c3a76
AS
5972012-03-24 Andreas Schwab <schwab@linux-m68k.org>
598
8ed79523
AS
599 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
600 characters.
601
7d1c3a76
AS
602 * xterm.c (XTread_socket): Only modify handling_signal if
603 !SYNC_INPUT. (Bug#11080)
604
e99a9b8b
EZ
6052012-03-23 Eli Zaretskii <eliz@gnu.org>
606
607 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
608 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
609 when fetching a multibyte character consumes more bytes than
610 CHAR_BYTES returns, due to unification of CJK characters in
611 string_char. (Bug#11073)
612
5063c0e1
TN
6132012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
614
615 * process.c (wait_reading_process_output): Handle pty disconnect
616 by refraining from sending oneself a SIGCHLD (bug#10933).
617
9f851fbd
CY
6182012-03-22 Chong Yidong <cyd@gnu.org>
619
620 * dispextern.h (struct it): New member string_from_prefix_prop_p.
621
5063c0e1 622 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
623 Mark string as coming from a prefix property.
624 (handle_face_prop): Use default face for prefix strings (Bug#4281).
625 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
626
fb5b8aca
CY
6272012-03-21 Chong Yidong <cyd@gnu.org>
628
629 * xfaces.c (Vface_remapping_alist): Doc fix.
630
62356a1b
EZ
6312012-03-20 Eli Zaretskii <eliz@gnu.org>
632
633 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
634 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
635 Doc fixes.
62356a1b 636
025de85b
CY
6372012-03-20 Chong Yidong <cyd@gnu.org>
638
639 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
640 to reflect default non-nil value of redisplay-dont-pause.
641
4827f94e
KH
6422012-03-19 Kenichi Handa <handa@m17n.org>
643
644 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
645 it fit in a valid range (Bug#11003).
646
e50a24a2
EZ
6472012-03-18 Eli Zaretskii <eliz@gnu.org>
648
649 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
650 that is not from display property, accept the row as a "cursor
651 row" if one of the string's character has a non-nil `cursor'
652 property. Fixes cursor positioning when there are newlines in
653 overlay strings, e.g. in icomplete.el. (Bug#11035)
654
9af5ed87
PE
6552012-03-12 Paul Eggert <eggert@cs.ucla.edu>
656
657 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
658
d1f55f16
CY
6592012-03-12 Chong Yidong <cyd@gnu.org>
660
661 * eval.c (inhibit_lisp_code): Rename from
662 inhibit_window_configuration_change_hook; move from window.c.
663
664 * xfns.c (unwind_create_frame_1, Fx_create_frame):
665 * window.c (run_window_configuration_change_hook)
666 (syms_of_window): Callers changed.
667
66c5eebd
CY
6682012-03-11 Chong Yidong <cyd@gnu.org>
669
413df973
CY
670 * keymap.c (Fkey_description): Doc fix (Bug#9700).
671
66c5eebd
CY
672 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
673
1de11f56
CY
6742012-03-10 Chong Yidong <cyd@gnu.org>
675
676 * frame.c (other_visible_frames): Don't assume the selected frame
677 is visible (Bug#10955).
678
cae07000
SM
6792012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
680
681 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
682
89c94350
JD
6832012-03-08 Jan Djärv <jan.h.d@swipnet.se>
684
685 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
686 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
687 zero (Bug#10954).
688
999dd333
GM
6892012-03-03 Glenn Morris <rgm@gnu.org>
690
01a6dcc8 691 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 692
de0100f2
EZ
6932012-03-02 Eli Zaretskii <eliz@gnu.org>
694
695 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
696 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
697 (redisplay_window, next_element_from_string): Fix typos in
698 comments.
3e441275
EZ
699 (redisplay_window): Pass to move_it_vertically the margin in
700 pixels, not in screen lines.
de0100f2 701
96a72ee9
GM
7022012-03-02 Glenn Morris <rgm@gnu.org>
703
704 * buffer.c (buffer-list-update-hook): Doc fix.
705
312508d7
EZ
7062012-02-29 Eli Zaretskii <eliz@gnu.org>
707
708 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
709 push_it before setting up the iterator for the first overlay
710 string, even if we have an empty string loaded.
711 (next_overlay_string): If there's an empty string on the iterator
712 stack, pop the stack. (Bug#10903)
713
27f3c637
PE
7142012-02-25 Paul Eggert <eggert@cs.ucla.edu>
715
716 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
717 Suggested by Stefan Monnier in
718 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
719 * alloc.c (widen_to_Lisp_Object): New static function.
720 (mark_memory): Also mark Lisp_Objects by fetching pointer words
721 and widening them to Lisp_Objects. This would work even if
722 USE_LSB_TAG is defined and wide integers are used, which might
723 happen in a future version of Emacs.
724
3c9dfce6
CY
7252012-02-25 Chong Yidong <cyd@gnu.org>
726
fa74b241
CY
727 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
728 Doc fix.
729
3c9dfce6
CY
730 * xselect.c (Fx_selection_exists_p): Doc fix.
731 (x_clipboard_manager_save_all): Print an informative message
732 before saving to clipboard manager.
733
9486df08
CY
7342012-02-24 Chong Yidong <cyd@gnu.org>
735
736 * keyboard.c (process_special_events): Handle all X selection
737 requests in kbd_buffer, not just the next one (Bug#8869).
738
f01d3321
CY
7392012-02-23 Chong Yidong <cyd@gnu.org>
740
741 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
742 call when setting menu-bar-lines and tool-bar-lines parameters.
743 (unwind_create_frame_1): New helper function.
744
745 * window.c (inhibit_window_configuration_change_hook): New var.
746 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 747 (syms_of_window): Initialize it.
f01d3321 748
86b847b6
CY
7492012-02-22 Chong Yidong <cyd@gnu.org>
750
751 * xterm.c (x_draw_image_relief): Add missing type check for
752 Vtool_bar_button_margin (Bug#10743).
753
a59225b1
CY
7542012-02-21 Chong Yidong <cyd@gnu.org>
755
756 * fileio.c (Vfile_name_handler_alist): Doc fix.
757
758 * buffer.c (Fget_file_buffer): Protect against invalid file
759 handler return value.
760
310f5bd4
PE
7612012-02-20 Paul Eggert <eggert@cs.ucla.edu>
762
cb3a28cc
PE
763 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
764 when computing $valmask.
765
310f5bd4
PE
766 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
767 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
768 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
769 It's useless in that case, and it can cause problems on hosts
770 that allocate halves of EMACS_INT values separately.
771 Reported by Dan Horák. Diagnosed by Andreas Schwab in
772 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
773 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
774 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
775 it avoids undefined behavior on hosts where shifting right by more
776 than the word width has undefined behavior.
777
2375c96a
CY
7782012-02-19 Chong Yidong <cyd@gnu.org>
779
780 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
781 (Funhandled_file_name_directory, Ffile_name_as_directory)
782 (Fdirectory_file_name, Fexpand_file_name)
783 (Fsubstitute_in_file_name): Protect against invalid file handler
784 return values (Bug#10845).
785
3eb49e71
EZ
7862012-02-18 Eli Zaretskii <eliz@gnu.org>
787
788 * .gdbinit (pitx): Fix incorrect references to fields of the
789 iterator stack.
790
7b926f3f
CY
7912012-02-17 Chong Yidong <cyd@gnu.org>
792
793 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
794
11273115
PE
7952012-02-15 Paul Eggert <eggert@cs.ucla.edu>
796
797 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
798 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
799
c3a70e2b
CY
8002012-02-15 Chong Yidong <cyd@gnu.org>
801
802 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
803 marked as special. Also, starting docstrings with * is obsolete.
804
0ca43699
AS
8052012-02-13 Andreas Schwab <schwab@linux-m68k.org>
806
807 * gnutls.c (emacs_gnutls_write): Fix last change.
808
2e8f3c56
LI
8092012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
810
811 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
812 send_process.
813
af70074f
SM
8142012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
815
816 * keymap.c (Fsingle_key_description): Handle char ranges.
817
95986d52
CY
8182012-02-12 Chong Yidong <cyd@gnu.org>
819
afd83bd1
CY
820 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
821 as that creates a dangerous corner case.
822
95986d52
CY
823 * window.c (Fdelete_window_internal): Invalidate the mouse
824 highlight (Bug#9904).
825
bd7da63e
GM
8262012-02-12 Glenn Morris <rgm@gnu.org>
827
828 * xselect.c (Fx_own_selection_internal)
829 (Fx_get_selection_internal, Fx_disown_selection_internal)
830 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
831 * nsselect.m (Fx_own_selection_internal)
832 (Fx_disown_selection_internal, Fx_selection_exists_p)
833 (Fx_selection_owner_p, Fx_get_selection_internal):
834 Sync docs and argument specs with the xselect.c versions.
835
77abcbc2
LI
8362012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
837
838 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
839
90b671e2
EZ
8402012-02-11 Eli Zaretskii <eliz@gnu.org>
841
1c0ca0b7
EZ
842 * w32select.c (Fx_selection_exists_p): Sync doc string and
843 argument list with xselect.c. (Bug#10783)
844
845 * w16select.c (Fx_selection_exists_p): Sync doc string and
846 argument list with xselect.c. (Bug#10783)
90b671e2 847
49241268
GM
8482012-02-10 Glenn Morris <rgm@gnu.org>
849
850 * fns.c (Fsecure_hash): Doc fix.
851
f998bbe7 8522012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
853
854 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
855
0992bd9c
CY
8562012-02-07 Chong Yidong <cyd@gnu.org>
857
858 * buffer.c (Fbuffer_local_variables)
859 (buffer_lisp_local_variables): Handle unbound vars correctly;
860 don't let Qunbound leak into Lisp.
861
af008560
GM
8622012-02-07 Glenn Morris <rgm@gnu.org>
863
dd605cc4
GM
864 * image.c (Fimagemagick_types): Doc fix.
865
af008560
GM
866 * image.c (imagemagick-render-type): Change it from a lisp object
867 to an integer. Move the doc here from the lisp manual.
868 Treat all values not equal to 0 the same.
869
1449fa1d
CY
8702012-02-06 Chong Yidong <cyd@gnu.org>
871
872 * doc.c (store_function_docstring): Avoid applying docstring of
873 alias to base function (Bug#2603).
874
3723ec07
AS
8752012-02-04 Andreas Schwab <schwab@linux-m68k.org>
876
877 * .gdbinit (pp1, pv1): Remove redundant defines.
878 (pr): Use pp.
879
79c1cc1e
CY
8802012-02-04 Chong Yidong <cyd@gnu.org>
881
882 * nsterm.m: Declare a global (Bug#10694).
883
d7f29f8e
EZ
8842012-02-04 Eli Zaretskii <eliz@gnu.org>
885
cae07000
SM
886 * w32.c (get_emacs_configuration_options):
887 Include --enable-checking, if specified, in the return value.
d7f29f8e 888
3b95a6f9
MR
8892012-02-04 Martin Rudalics <rudalics@gmx.at>
890
891 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
892 after rounding frame sizes. (Bug#9723)
893
d6fa96a6
EZ
8942012-02-04 Eli Zaretskii <eliz@gnu.org>
895
896 * keyboard.c (adjust_point_for_property): Don't position point
897 before BEGV. (Bug#10696)
898
df0b2940
PE
8992012-02-03 Paul Eggert <eggert@cs.ucla.edu>
900
901 Handle overflow when computing char display width (Bug#9496).
902 * character.c (char_width): Return EMACS_INT, not int.
903 (char_width, c_string_width): Check for overflow when
904 computing the width; this is possible now that individual
905 characters can have unbounded width. Problem introduced
906 by merge from Emacs 23 on 2012-01-19.
907
6bee44d6
MA
9082012-02-02 Michael Albinus <michael.albinus@gmx.de>
909
910 * dbusbind.c (Fdbus_register_method): Mention the return value
911 :ignore in the docstring.
912
44f92739
GM
9132012-02-02 Glenn Morris <rgm@gnu.org>
914
1b9f60cc
GM
915 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
916
44f92739
GM
917 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
918 Unconditionally set to t. (Bug#10673)
919 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
920 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
921 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
922
c5d3843c
KH
9232012-02-02 Kenichi Handa <handa@m17n.org>
924
925 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
926 0, do not call append_composite_glyph.
927
159462d4 9282012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
929
930 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
931 NULL (Bug#6988).
932 (x_produce_glyphs): If the component of a composition is a null
933 string, set it->pixel_width to 1 to avoid zero-width glyph.
934
78cef877
EZ
9352012-02-01 Eli Zaretskii <eliz@gnu.org>
936
937 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
938 first 2 arguments are identical. This makes inserting large
939 output from a subprocess an order of magnitude faster on
940 MS-Windows, where all sbrk'ed memory is always contiguous.
941
97897668
GM
9422012-01-31 Glenn Morris <rgm@gnu.org>
943
944 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 945 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
946 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
947
31fd3586
GM
9482012-01-29 Glenn Morris <rgm@gnu.org>
949
950 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
951
0e24a8b2
CY
9522012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
953
954 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
955
cc0adcb0
CY
9562012-01-28 Chong Yidong <cyd@gnu.org>
957
958 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
959
acc28cb9
CY
9602012-01-26 Chong Yidong <cyd@gnu.org>
961
9c69cfb7
CY
962 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
963
acc28cb9
CY
964 * search.c (Fsearch_forward, Fsearch_backward): Document negative
965 repeat counts (Bug#10507).
966
48da7392
GM
9672012-01-26 Glenn Morris <rgm@gnu.org>
968
969 * lread.c (syms_of_lread): Doc fix.
970
14af5f7f
CY
9712012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
972
973 * coding.c (encode_designation_at_bol): Change return value to
974 EMACS_INT.
975
0b21c100
CY
9762012-01-25 Chong Yidong <cyd@gnu.org>
977
978 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
979
3c2907f7
CY
9802012-01-21 Chong Yidong <cyd@gnu.org>
981
982 * floatfns.c (Fcopysign): Make the second argument non-optional,
983 since nil is not allowed anyway.
984
959ad23f
AS
9852012-01-21 Andreas Schwab <schwab@linux-m68k.org>
986
987 * process.c (read_process_output): Use p instead of XPROCESS (proc).
988 (send_process): Likewise.
989
34a02f46
MR
9902012-01-19 Martin Rudalics <rudalics@gmx.at>
991
992 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
993 (Vwindow_persistent_parameters): Do not use Qstate.
994 Rewrite doc-strings.
34a02f46 995
1259009a 9962012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
997
998 * character.c (char_width): New function.
70d4fdf6
GM
999 (Fchar_width, c_string_width, lisp_string_width):
1000 Use char_width (Bug#9496).
25ed9e61 1001
6a6ee00d
MR
10022012-01-16 Martin Rudalics <rudalics@gmx.at>
1003
1004 * window.c (Vwindow_persistent_parameters): New variable.
1005 (Fset_window_configuration, save_window_save): Handle persistent
1006 window parameters.
1007
c85efaf7
EZ
10082012-01-14 Eli Zaretskii <eliz@gnu.org>
1009
1010 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
1011 thrashing the stack of the thread. (Bug#9087)
1012
5944709e
PE
10132012-01-12 Paul Eggert <eggert@cs.ucla.edu>
1014
1015 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
1016
e71f5d99
EZ
10172012-01-11 Eli Zaretskii <eliz@gnu.org>
1018
1019 * xdisp.c (rows_from_pos_range): Handle the case where the
1020 highlight ends on a newline. (Bug#10464)
1021 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
1022 he end column for display of highlight that ends on a newline
1023 before a R2L line.
1024
ce316182
GM
10252012-01-11 Glenn Morris <rgm@gnu.org>
1026
1027 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
1028 from load-path also when installation-directory is nil. (Bug#10208)
1029
5b43da69
GM
10302012-01-10 Glenn Morris <rgm@gnu.org>
1031
74cc8ff9
GM
1032 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
1033
7d8d6e4e
GM
1034 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
1035 Update template values to be closer to their typical values these days.
5b43da69 1036
a0db8d43
EZ
10372012-01-09 Eli Zaretskii <eliz@gnu.org>
1038
1039 * xdisp.c (rows_from_pos_range): Accept additional argument
1040 DISP_STRING, and accept any glyph in a row whose object is that
1041 string as eligible for mouse highlight. Fixes mouse highlight of
1042 display strings from overlays. (Bug#10464)
1043
9a0115ab 10442012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 1045
b9110d6a 1046 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
1047 * fileio.c (auto_saving_dir_umask): New static var.
1048 (Fmake_directory_internal): Use it.
1049 (do_auto_save_make_dir): Set it, instead of invoking chmod after
1050 creating the directory. The old code temporarily assigns
1051 too-generous permissions to the directory.
1052 (do_auto_save_eh): Clear it.
b9110d6a 1053 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
1054 that the var is always cleared.
1055
6c1bd3f3
EZ
10562012-01-07 Eli Zaretskii <eliz@gnu.org>
1057
1058 * search.c (scan_buffer): Pass character positions to
1059 know_region_cache, not byte positions. (Bug#6540)
1060
069d2b50
L
10612012-01-07 LynX <_LynX@bk.ru> (tiny change)
1062
1063 * w32.c (sys_rename): Report EXDEV when rename of a directory
1064 fails because the target is on another logical disk. (Bug#10284)
1065
75bf0d33
DB
10662012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
1067
1068 * xterm.c (x_embed_request_focus): New function.
1069
1070 * xterm.h: Add prototype.
1071
1072 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
1073
1c6e5a32
GM
10742012-01-05 Glenn Morris <rgm@gnu.org>
1075
1076 * emacs.c (emacs_copyright): Update short copyright year to 2012.
1077
651e947e
EZ
10782012-01-01 Eli Zaretskii <eliz@gnu.org>
1079
1080 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1081 Load gnutls_transport_set_lowat only if GnuTLS version is below
1082 2.11.1.
1083 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1084 GnuTLS versions below 2.11.1.
1085
3778cdd8
AL
10862011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1087
1088 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1089 to the doc string advising against its use for altering the way
1090 windows are scrolled.
1091
0e5317f7
KH
10922011-12-28 Kenichi Handa <handa@m17n.org>
1093
1094 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1095 coding-system ASCII compatible only when it does not produce BOM
1096 on encoding (Bug#10383).
1097
93d5ca1f
JD
10982011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1099
1100 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1101 can scroll.
1102 (create_and_show_popup_menu): Always use menu_position_func for
1103 Gtk3 (Bug#10361).
1104
ca22b785
AS
11052011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1106
1107 * callint.c (Fcall_interactively): Don't truncate prompt string.
1108
d048e1e6
EZ
11092011-12-23 Eli Zaretskii <eliz@gnu.org>
1110
1111 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1112 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 1113 resumed from there (after widening). (Bug#10360)
d048e1e6 1114
5ccaba1f
JD
11152011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1116
1117 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1118
204ee57f
JD
11192011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1120
b81d40f0
JB
1121 * nsterm.m (x_free_frame_resources):
1122 Release f->output_data.ns->miniimage.
204ee57f
JD
1123 (ns_index_color): Fix indentation. Do not retain
1124 color_table->colors[i].
1125
1126 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1127 before returning.
1128
1129 * nsfns.m (x_set_background_color): Assign return value from
1130 ns_index_color to face-background instead of NSColor*.
1131 (ns_implicitly_set_icon_type): Fix indentation.
1132 Change assignment in for loop to comparison.
1133
1134 * emacs.c (ns_pool): New variable.
1135 (main): Assign ns_pool.
1136 (Fkill_emacs): Call ns_release_autorelease_pool.
1137
1138 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1139 autorelease fdesc, release fdAttrs and tdict.
1140 (ns_get_covering_families): Release charset.
1141 (ns_findfonts): Release NSFontDescriptor created with new.
1142 (ns_uni_to_glyphs): Fix indentation.
1143 (setString): Release attrStr before assigning new value.
1144
c803b2b7
JD
11452011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1146
678f4426
JD
1147 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1148 and NS_IMPL_COCOA.
1149 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1150 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1151
cd394be1 11522011-12-18 David Reitter <reitter@cmu.edu>
678f4426 1153
5fecd5fc
JD
1154 * nsterm.m (ns_term_init): Subscribe for notifications
1155 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1156 to method trackingNotification in EmacsMenu.
1157
1158 * nsmenu.m (trackingMenu): New variable.
3771cb17 1159 (trackingNotification): New method (from Aquamacs).
5fecd5fc 1160 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 1161 from Aquamacs (Bug#7030).
678f4426
JD
1162
11632011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 1164
c803b2b7
JD
1165 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1166 (symbol_to_nsstring): Fix indentation.
1167 (ns_symbol_to_pb): New function.
cae07000
SM
1168 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1169 (Fns_rotate_cut_buffers_internal): Remove.
1170 (Fns_store_selection_internal): Rename from
c803b2b7
JD
1171 Fns_store_cut_buffer_internal.
1172 (ns_get_foreign_selection, Fx_own_selection_internal)
1173 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
1174 (Fns_get_selection_internal, Fns_store_selection_internal):
1175 Use ns_symbol_to_pb and check if return value is nil.
1176 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1177 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
1178 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1179 renamed to Sns_store_selection_internal.
1180 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1181 and remove this function.
1182 (ns_handle_selection_clear): Remove, never used.
1183 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1184 here.
1185
e1b01a3a
KB
11862011-12-17 Ken Brown <kbrown@cornell.edu>
1187
1188 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1189 GID is unknown (Bug#10257).
1190
2adb6e85
PE
11912011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1192
1193 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1194 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1195 which caused a build failure on GNU/Linux IA-64. This problem was
1196 introduced by my 2011-10-07 patch.
1197
d1d7b339
JL
11982011-12-15 Juri Linkov <juri@jurta.org>
1199
1200 * image.c (imagemagick_error): New function. (Bug#10112)
1201 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1202 Use `imagemagick_error' where ImageMagick functions return
1203 `MagickFalse'.
1204 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1205 proper order.
1206
100d5755
KH
12072011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1208
1209 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1210 fill background (Bug#8992).
1211
454592a6
MR
12122011-12-13 Martin Rudalics <rudalics@gmx.at>
1213
1214 * window.c (Vwindow_combination_resize)
1215 (Vwindow_combination_limit): Use t instead of non-nil in
1216 doc-strings.
61d4b438
MR
1217 (Vrecenter_redisplay): Add first sentence of doc-string on
1218 separate line.
53524d93 1219 (Frecenter): Fix doc-string typo.
454592a6 1220
3633e3aa
KH
12212011-12-11 Kenichi Handa <handa@m17n.org>
1222
1223 * coding.c (Funencodable_char_position): Pay attention to the
1224 buffer text relocation (Bug#9389).
1225
7b9d523a
JD
12262011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1227
1228 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1229 gtk_init (Bug#10100).
1230
b73189c6
EZ
12312011-12-10 Eli Zaretskii <eliz@gnu.org>
1232
1233 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1234 IT->string is nil. (Bug#10263)
1235
f7dfe5d6
JD
12362011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1237
83faebb4
JD
1238 * nsterm.h (x_free_frame_resources): Declare.
1239
f7dfe5d6
JD
1240 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1241 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1242
1243 * nsterm.h (ns_get_defaults_value): Declare.
1244
1245 * nsterm.m (ns_default): Call ns_get_defaults_value.
1246
7cd4e72c
EZ
12472011-12-09 Eli Zaretskii <eliz@gnu.org>
1248
1249 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1250 (Bug#10170)
1251
b34d7317
YM
12522011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1253
1254 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1255 that where the value of an _OBJC_* symbol points to is in the .bss
1256 section (Bug#10240).
1257
76470ad1
KH
12582011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1259
1260 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 1261 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 1262
745fff94
KH
12632011-12-08 Kenichi Handa <handa@m17n.org>
1264
1265 * ftfont.c (get_adstyle_property): Fix previous change
1266 (Bug#10233).
1267
6e44397c
JB
12682011-12-07 Juanma Barranquero <lekktu@gmail.com>
1269
1270 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1271 dirs from the default value of EMACSLOADPATH (bug#10208).
1272
7efa6272
GM
12732011-12-07 Glenn Morris <rgm@gnu.org>
1274
1275 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1276 installation and source directories as well. (Bug#10208)
1277
f6fc4d87
CY
12782011-12-06 Chong Yidong <cyd@gnu.org>
1279
1280 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1281
2bf26180
GM
12822011-12-06 Glenn Morris <rgm@gnu.org>
1283
1284 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1285 as an error, not just -1. (Bug#10217)
1286
3a6ad4f0
CY
12872011-12-05 Chong Yidong <cyd@gnu.org>
1288
1289 * keyboard.c (process_special_events): New function.
1290 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1291
75a3b399
PE
12922011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1293
1294 * coding.c (encode_designation_at_bol): Don't use uninitialized
1295 local variable (Bug#9318).
1296
c3c9e25e
KH
12972011-12-05 Kenichi Handa <handa@m17n.org>
1298
1299 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1300 return Qnil (Bug#8046, Bug#10193).
1301
5eb05ea3
KH
13022011-12-05 Kenichi Handa <handa@m17n.org>
1303
1304 * coding.c (encode_designation_at_bol): New args charbuf_end and
1305 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
1306 (coding_set_source): Return how many bytes coding->source was
1307 relocated.
1308 (coding_set_destination): Return how many bytes
1309 coding->destination was relocated.
1310 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 1311 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
1312
13132011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1314
1315 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1316 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1317 macro (Bug#9318).
1318
13192011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1320
1321 The following changes are to fix Bug#9318.
1322
a79703f5 1323 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
1324 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1325 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 1326 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 1327
7dbda6df
JB
13282011-12-05 Juanma Barranquero <lekktu@gmail.com>
1329
1330 * lisp.h (process_quit_flag): Fix external declaration.
1331
6d5eb5b0
SM
13322011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1333
1334 Don't macro-inline non-performance-critical code.
1335 * eval.c (process_quit_flag): New function.
1336 * lisp.h (QUIT): Use it.
1337
a0c3fad0
JD
13382011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1339
1340 * nsfns.m (get_geometry_from_preferences): New function.
1341 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1342
6c07aac2
AS
13432011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1344
1345 * emacs.c (Qkill_emacs): Define.
1346 (syms_of_emacs): Initialize it.
1347 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1348 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
1349 (quit_throw_to_read_char): Add parameter `from_signal'.
1350 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
1351 * lisp.h (QUIT): Call Fkill_emacs if requested.
1352
c052ead4
JD
13532011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1354
1355 * widget.c (update_wm_hints): Return if wmshell is null.
1356 (widget_update_wm_size_hints): New function.
1357
1358 * widget.h (widget_update_wm_size_hints): Declare.
1359
1360 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1361 widget_update_wm_size_hints (Bug#10104).
1362
9e49252b
EZ
13632011-12-03 Eli Zaretskii <eliz@gnu.org>
1364
1365 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1366 before a newline, prepare the bidi iterator for consuming the
1367 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 1368 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 1369
02b16839
JL
13702011-12-02 Juri Linkov <juri@jurta.org>
1371
1372 * search.c (Fword_search_regexp): New Lisp function created from
1373 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1374 (Fword_search_backward, Fword_search_forward)
1375 (Fword_search_backward_lax, Fword_search_forward_lax):
1376 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1377 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1378
0068070e
SM
13792011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1380
1381 * fileio.c (Finsert_file_contents): Move after-change-function call
1382 to before the "handled:" label, since all "goto handled" appear in
1383 cases where the *-change-functions have already been properly called
1384 (bug#10117).
1385
3360a3fc
AS
13862011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1387
1388 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1389 waiting for input. (Bug#10169)
1390
73d6c093
EZ
13912011-11-30 Eli Zaretskii <eliz@gnu.org>
1392
1393 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1394 verifies glyph row's hash code--we have just reallocated the
1395 glyphs, so their contents can be complete garbage. (Bug#10164)
1396
febe6bea
JB
13972011-11-30 Juanma Barranquero <lekktu@gmail.com>
1398
1399 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1400
801a4313
EZ
14012011-11-30 Eli Zaretskii <eliz@gnu.org>
1402
1403 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1404 attributes are tested _before_ calling verify_row_hash, to protect
1405 against GCC re-ordering of the tests. (Bug#10164)
1406
2b56b87e
JD
14072011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1408
1409 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1410
1411 * xterm.c (handle_one_xevent): Only set async_visible and friends
1412 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1413 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1414 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1415
dbf31225
PE
14162011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1417
1418 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1419 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1420 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1421 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1422 All uses changed to use GCPRO1 etc.
1423 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1424 Revert to old implementation (i.e., before 2011-03-11).
1425
1305621b
YM
14262011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1427
1428 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1429 of scroll runs so as to avoid assigning disabled bogus rows and
1430 unnecessary graphics copy operations.
1431
8c9afb46
EZ
14322011-11-27 Eli Zaretskii <eliz@gnu.org>
1433
1434 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1435 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1436 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1437 (malloc, free, realloc, calloc): Redirect to e_* only when
1438 compiling Emacs.
1439
1440 * lisp.h (GCTYPEBITS): Move before first use.
1441 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1442 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1443 this macro definition.
1444
1445 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1446 _MSC_VER.
1447
54e9e3bf
JD
14482011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1449
6d5eb5b0
SM
1450 * gtkutil.c (xg_create_frame_widgets):
1451 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1452 present with Gtk+ 2.0.
1453
83aca1cb
PE
14542011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1455
1456 * fileio.c (Finsert_file_contents): Undo previous change; see
1457 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1458
5b76caa4
PE
14592011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1460
1461 Rename locals to avoid shadowing.
1462 * fileio.c (Finsert_file_contents):
1463 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1464 * process.c (wait_reading_process_output):
1465 Rename inner 'proc' to 'p' to avoid shadowing.
1466 Indent for consistency with usual Emacs style.
1467
8c535114
EZ
14682011-11-25 Eli Zaretskii <eliz@gnu.org>
1469
1470 * xdisp.c (redisplay_window): If cursor row is not fully visible
1471 after recentering, and scroll-conservatively is set to a large
1472 number, scroll window by a few more lines to make the cursor fully
1473 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1474 (start_display): Don't move to the next line if the display should
1475 start at a newline that is part of a display vector or an overlay
1476 string. (Bug#10119)
8c535114 1477
fa4fdb5c
JL
14782011-11-24 Juri Linkov <juri@jurta.org>
1479
1480 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1481 after the `MagickPingImage' call. (Bug#10112)
1482
90ec88df
CY
14832011-11-23 Chong Yidong <cyd@gnu.org>
1484
1485 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1486
56e2e794
MR
14872011-11-23 Martin Rudalics <rudalics@gmx.at>
1488
1489 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1490 making another buffer current. (Bug#10114)
1491
b6e64c41
GM
14922011-11-23 Glenn Morris <rgm@gnu.org>
1493
1494 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1495
6b21de18
CY
14962011-11-23 Chong Yidong <cyd@gnu.org>
1497
1498 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1499 using it (Bug#5984).
1500
b12cd789
EZ
15012011-11-22 Eli Zaretskii <eliz@gnu.org>
1502
1503 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1504 and header-lines, as they don't have one computed for them.
1505 (Bug#10098)
1506
1507 * .gdbinit (prow): Make displayed values more self-explaining.
1508 Add row's hash code.
1509
261b6fd4
LMI
15102011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1511
1512 * process.c (wait_reading_process_output): Fix asynchrounous
1513 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1514 (wait_reading_process_output): Add comment and URL.
261b6fd4 1515
e7cfd277
JD
15162011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1517
1518 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1519
a9b9b7f5
CY
15202011-11-21 Chong Yidong <cyd@gnu.org>
1521
1522 * window.c (Fnext_window, Fprevious_window): Doc fix.
1523
b0d15b4f
SM
15242011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1525
1526 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1527
fe7a3057
JB
15282011-11-20 Juanma Barranquero <lekktu@gmail.com>
1529
1530 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1531
d2999b1a
MR
15322011-11-20 Martin Rudalics <rudalics@gmx.at>
1533
1534 * window.c (Fset_window_combination_limit): Rename argument
1535 STATUS to LIMIT.
1536 (Vwindow_combination_limit): Remove "status" from doc-string.
1537
d5ff9cd0
AS
15382011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1539
1540 * m/ibms390.h: Remove.
1541 * m/ibms390x.h: Don't include "ibms390.h".
1542
a5bb9bd3
SM
15432011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1544
1545 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1546 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1547
cd1181db
JB
15482011-11-20 Juanma Barranquero <lekktu@gmail.com>
1549
1550 * casetab.c (Fset_case_table):
1551 * charset.c (Fcharset_after): Fix typos.
1552
615a3b8d 15532011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1554
17e845af
PE
1555 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1556 Otherwise, valgrind does not work on some platforms.
1557 Problem reported by Andreas Schwab in
6a0bf43d
PE
1558 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1559 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1560 is set, removing the need for VIRT_ADDRESS_VARIES.
1561 (PURE_P): Use a more-efficient implementation that needs just one
1562 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1563 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1564 to 4 (xorl, subq, cmpq, setbe).
1565 * alloc.c (pure): Always extern now, since that's the
1566 VIRT_ADDR_VARIES behavior.
1567 (PURE_POINTER_P): Use a single comparison, not two, for
1568 consistency with the new puresize.h.
1569 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1570 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1571 Remove VIRT_ADDR_VARIES no longer needed.
1572
f8fe6f96
EZ
15732011-11-19 Eli Zaretskii <eliz@gnu.org>
1574
1575 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1576 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1577 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1578 behave as if the cursor position were at the window margin.
1579
1580 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1581 and the cursor position is out of bounds, behave as if the cursor
1582 position were at the window margin. (Bug#10075)
1583
df05a53c
CY
15842011-11-18 Chong Yidong <cyd@gnu.org>
1585
1586 * window.c (Fwindow_combination_limit): Make first argument
1587 non-optional, since it is meaningless for live windows like the
1588 selected window.
1589
2071918e
DA
15902011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1591
1592 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1593
b50a28de
SM
15942011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1595
1596 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1597 (graft_intervals_into_buffer): Simplify.
1598
015137db
EZ
15992011-11-18 Eli Zaretskii <eliz@gnu.org>
1600
1601 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1602 hash values of the two rows.
1603 (copy_row_except_pointers): Preserve the used[] arrays and the
1604 hash values of the two rows. (Bug#10035)
68c95424 1605 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1606
1607 * xdisp.c (row_hash): New function, body extracted from
1608 compute_line_metrics.
1609 (compute_line_metrics): Call row_hash, instead of computing the
1610 hash code inline.
1611
1612 * dispnew.c (verify_row_hash): Call row_hash for computing the
1613 hash code of a row, instead of duplicating code from xdisp.c.
1614
1615 * dispextern.h (row_hash): Add prototype.
1616
a2addb04
TH
16172011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1618
1619 * frame.c (delete_frame): Don't delete the terminal when the last
1620 X frame is closed if emacs is built with GTK toolkit.
1621
df85d315
JB
16222011-11-17 Juanma Barranquero <lekktu@gmail.com>
1623
1624 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1625
a0c2d0ae
MR
16262011-11-17 Martin Rudalics <rudalics@gmx.at>
1627
1628 * window.c (Vwindow_splits): Rename to
1629 Vwindow_combination_resize. Suggested by Juri Linkov.
1630 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1631 of Vwindow_splits.
1632
58179cce
JB
16332011-11-16 Juanma Barranquero <lekktu@gmail.com>
1634
7877f373
JB
1635 * nsfns.m (Fns_font_name):
1636 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1637
b6f67890
MR
16382011-11-16 Martin Rudalics <rudalics@gmx.at>
1639
1640 * window.h (window): Rename slot "nest" to "combination_limit".
1641 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1642 (Fset_window_nest): Rename to Fset_window_combination_limit.
1643 (Vwindow_nest): Rename to Vwindow_combination_limit.
1644 (recombine_windows, make_parent_window, make_window)
1645 (Fsplit_window_internal, saved_window)
1646 (Fset_window_configuration, save_window_save): Rename all
1647 occurrences of window_nest to window_combination_limit.
1648
c7015153
JB
16492011-11-15 Juanma Barranquero <lekktu@gmail.com>
1650
1651 * image.c (imagemagick_load_image): Fix typo.
1652
322ad6ec
EZ
16532011-11-14 Eli Zaretskii <eliz@gnu.org>
1654
1655 * xdisp.c (display_line): Move the call to
1656 highlight_trailing_whitespace before the call to
1657 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1658 faces of all the glyphs to compute ROW's hash value.
1659 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1660
f067b8ec
JB
16612011-11-14 Juanma Barranquero <lekktu@gmail.com>
1662
1663 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1664 just return (bug#10044).
1665
1e5b2111
EZ
16662011-11-12 Eli Zaretskii <eliz@gnu.org>
1667
7ef3cbd5
EZ
1668 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1669 with user-defined heap size. Bump the default size of the temacs
1670 heap to 27MB, to avoid memory warning when running temacs.
1671 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1672
1e5b2111
EZ
1673 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1674 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1675 (verify_row_hash) [XASSERTS]: New function.
1676 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1677 that the hash value of glyph rows is correct.
1e5b2111 1678
89d61221
MR
16792011-11-12 Martin Rudalics <rudalics@gmx.at>
1680
1681 * window.h (window): Remove splits slot.
1682 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1683 (Fdelete_other_windows_internal, make_parent_window)
1684 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1685 (Fset_window_configuration, save_window_save): Don't deal with
1686 split status of windows.
1687 (saved_window): Remove splits slot.
1688 (Vwindow_splits): Rewrite doc-string.
1689
97f18cc8
JD
16902011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1691
1692 * xfns.c (unwind_create_frame):
1693 * nsfns.m (unwind_create_frame):
1694 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1695 Vframe_list (Bug#9999).
1696
22a648b4
DA
16972011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1698
0b381c7e 1699 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1700
659afede
KH
17012011-11-11 Kenichi Handa <handa@m17n.org>
1702
1703 * callproc.c (Fcall_process): Set the member dst_multibyte of
1704 process_coding.
1705
9ac0394b
KH
17062011-11-11 Johan Bockgård <bojohan@gnu.org>
1707
1708 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1709 avoid a crash (bug#9496).
1710
2fbdc249
CY
17112011-11-09 Chong Yidong <cyd@gnu.org>
1712
1713 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1714 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1715
ac6b1f81
PE
17162011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1717
1718 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1719
09db192c
PE
17202011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1721
1722 Avoid some portability problems by eschewing 'extern inline' functions.
1723 The trivial performance wins aren't worth the portability hassles; see
1724 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1725 et seq.
1726 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1727 (window_box_width, window_box_left, window_box_left_offset)
1728 (window_box_right, window_box_right_offset): Undo previous change,
1729 by removing the "extern"s.
1730 * intervals.c (adjust_intervals_for_insertion)
1731 (adjust_intervals_for_deletion): Undo previous change,
1732 making these static again.
1733 (offset_intervals, temp_set_point_both, temp_set_point)
1734 (copy_intervals_to_string): No longer inline.
1735 * xdisp.c (window_text_bottom_y, window_box_width)
1736 (window_box_height, window_box_left_offset)
1737 (window_box_right_offset, window_box_left, window_box_right)
1738 (window_box): No longer inline.
1739
105216ed
CY
17402011-11-08 Chong Yidong <cyd@gnu.org>
1741
1742 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1743 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1744 Signal an error if not a live window.
105216ed
CY
1745 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1746 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1747
ae9e237f
JB
17482011-11-07 Juanma Barranquero <lekktu@gmail.com>
1749
1750 * lisp.h (syms_of_abbrev): Remove declaration.
1751 Reported by CHENG Gao <chenggao@royau.me>.
1752
c7aa8333
EZ
17532011-11-07 Eli Zaretskii <eliz@gnu.org>
1754
1755 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1756 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1757 of temacs in GUI mode.
1758
be7f5545
MR
17592011-11-07 Martin Rudalics <rudalics@gmx.at>
1760
1761 * window.h: Declare delete_all_child_windows instead of
1762 delete_all_subwindows.
1763 * window.c (Fwindow_nest, Fset_window_nest)
1764 (Fset_window_new_total, Fset_window_new_normal)
1765 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1766 (delete_all_subwindows): Rename to delete_all_child_windows.
1767 (Fdelete_other_windows_internal, Fset_window_configuration):
1768 Call delete_all_child_windows instead of delete_all_subwindows.
1769 * frame.c (delete_frame): Call delete_all_child_windows instead
1770 of delete_all_subwindows.
1771
ca78dc43
PE
17722011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1773
1774 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1775 This is also needed for porting to any host where GC_MARK_STACK is
1776 not GC_MAKE_GCPROS_NOOPS.
1777 (which_symbols): Use it.
1778
a0241d01
KH
17792011-11-07 Kenichi Handa <handa@m17n.org>
1780
1781 * coding.c (coding_set_destination): Check coding->src_pos only
1782 when coding->src_object is a buffer (bug#9910).
1783
1784 * process.c (send_process): Set the member src_multibyte of coding
1785 to 0 (bug#9911) when sending a unibyte text.
1786
1787 * callproc.c (Fcall_process): Set the member src_multibyte of
1788 process_coding to 0 (bug#9912).
1789
a64bfdfa 17902011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1791
1792 * xmenu.c (cleanup_widget_value_tree): New function.
1793 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1794 calling free_menubar_widget_value_tree directly (Bug#9830).
1795
cb41b32a
PE
17962011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1797
1798 Fix some portability problems with 'inline'.
1799 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1800 (window_box_width, window_box_left, window_box_left_offset)
1801 (window_box_right, window_box_right_offset): Declare extern.
1802 Otherwise, these inline functions do not conform to C99 and
1803 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1804 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1805 * intervals.c (adjust_intervals_for_insertion)
1806 (adjust_intervals_for_deletion): Now extern, because otherwise the
1807 extern inline functions 'offset_intervals' couldn't refer to it.
1808 (static_offset_intervals): Remove.
1809 (offset_intervals): Rewrite using the old contents of
1810 static_offset_intervals. The old version didn't conform to C99
1811 because an extern inline function contained a reference to an
1812 identifier with static linkage.
1813
b7041366
AS
18142011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1815
1816 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1817 GC.
1818
88a37c4d
EZ
18192011-11-06 Eli Zaretskii <eliz@gnu.org>
1820
1821 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1822 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1823 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1824 return Qleft_to_right.
1825
49745b39
CY
18262011-11-06 Chong Yidong <cyd@gnu.org>
1827
1828 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1829 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1830 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1831 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1832 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1833 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1834 (Fwindow_vscroll): Doc fix.
1835 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1836 argument, since it makes no sense to pass a live window and for
1837 consistency with window-child.
1838
1f05cd82
CS
18392011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1840
1841 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1842 support MSVC.
1843
22610910
JR
18442011-11-05 Jason Rumney <jasonr@gnu.org>
1845
1846 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1847 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1848 fonts (Bug#6029).
1849 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1850 bitwise arithmetic preventing use of unicode-sip and non-truetype
1851 opentype fonts.
1852
a06776b2
EZ
18532011-11-05 Eli Zaretskii <eliz@gnu.org>
1854
3ad924ba
EZ
1855 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1856 "emacs"-only part.
1857
a06776b2
EZ
1858 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1859 initialization code to keep similarity to xfns.c after changes
1860 from 2011-11-05.
1861
c9e7db78
JD
18622011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1863
a97f8f3f
JD
1864 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1865 (unwind_create_frame): New function (Bug#9943).
1866 (Fx_create_frame): Restructure code to be more similar to the one in
1867 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1868 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1869 Move terminal->reference_count++ just before making the frame official
1870 (Bug#9943).
1871
1872 * nsterm.m (x_free_frame_resources): New function.
1873 (x_destroy_window): Move code to x_free_frame_resources.
1874
c9e7db78 1875 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1876 (Fx_create_frame, x_create_tip_frame):
1877 Move terminal->reference_count++ just before making the frame
75f1671a 1878 official. Move initialization of image_cache_refcount and
c9e7db78
JD
1879 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1880
a6fc3b5c
EZ
18812011-11-05 Eli Zaretskii <eliz@gnu.org>
1882
1883 Support MSVC build with newer versions of Visual Studio.
1884 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1885 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1886 nt/gmake.defs.
1887
1888 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1889 which are not supported by MSVC.
1890 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1891 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1892 bitfields.
1893 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1894 types in bitfields.
1895 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1896
1897 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1898
58179cce 18992011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1900
1901 Support MSVC build with newer versions of Visual Studio.
1902 * w32.c: Don't include w32api.h for MSVC.
1903 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1904
1905 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1906 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1907 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1908 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1909 e_* cousins.
1910 (alloca) [_MSC_VER]: Define to _alloca.
1911
1912 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1913
1914 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1915
a58c13ed
EZ
19162011-11-04 Eli Zaretskii <eliz@gnu.org>
1917
1918 * xdisp.c (note_mouse_highlight): If either of
1919 previous/next-single-property-change returns nil, treat that as
1920 the beginning or the end of the buffer. (Bug#9955)
1921
fe0b6370
JD
19222011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1923
a58c13ed 1924 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1925 label is not null (Bug#9951).
1926 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1927 may be NULL.
1928
89bd5ee1
EZ
19292011-11-04 Eli Zaretskii <eliz@gnu.org>
1930
1931 * window.c (Fwindow_body_size): Mention in the doc string that the
1932 return value is in frame's canonical units. (Bug#9949)
1933
84c3edb9
EZ
19342011-11-03 Eli Zaretskii <eliz@gnu.org>
1935
4e2fb5c7
EZ
1936 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1937
84c3edb9 1938 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1939 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1940 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1941
bc17a887
EZ
19422011-11-01 Eli Zaretskii <eliz@gnu.org>
1943
1944 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1945 Don't stop backward scan on the continuation glyph, even though
1946 its CHARPOS is positive.
6d5eb5b0
SM
1947 (mouse_face_from_buffer_pos, note_mouse_highlight):
1948 Rename cover_string to disp_string.
bc17a887 1949
4ee88440
MR
19502011-11-01 Martin Rudalics <rudalics@gmx.at>
1951
1952 * window.c (temp_output_buffer_show): Don't use
1953 Vtemp_buffer_show_specifiers.
1954 (Vtemp_buffer_show_specifiers): Remove unused variable.
1955
c2ff3c02
EZ
19562011-10-30 Eli Zaretskii <eliz@gnu.org>
1957
1958 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1959 past the beginning of the current glyph matrix.
1960
58179cce 19612011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1962
1963 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1964 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1965 HAVE_GTK3 (Bug#9869).
b77a6a7f 1966
3b574623
JD
1967 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1968 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1969
b77a6a7f
JD
1970 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1971
1972 * xterm.c: Declare x_handle_net_wm_state to return int.
1973 (handle_one_xevent): Check if we are iconified but don't have
1974 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1975 (get_current_wm_state): Return non-zero if not hidden,
1976 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1977 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1978 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1979 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1980
196e41e4
PE
19812011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1982
1983 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1984 so that this new function doesn't get optimized away by a
1985 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1986
021f2e1a
AS
19872011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1988
1989 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1990
8b058d44
EZ
19912011-10-29 Eli Zaretskii <eliz@gnu.org>
1992
1993 Fix the `xbytecode' command.
1994 * .gdbinit (xprintbytestr): New command.
b50a28de 1995 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1996 (xbytecode): Print the byte-code string as well.
1997
4452fb80
EZ
19982011-10-29 Kim Storm <storm@cua.dk>
1999
8b058d44
EZ
2000 * alloc.c (which_symbols): New function.
2001
21b72067
AS
20022011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2003
2004 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
2005 line. (Bug#9903)
2006
83ed7b5c
GM
20072011-10-29 Glenn Morris <rgm@gnu.org>
2008
2009 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
2010 Not clear what it was for, and it causes various bugs. (Bug#9839)
2011
5a7a728b
EZ
20122011-10-28 Eli Zaretskii <eliz@gnu.org>
2013
2014 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
2015 possible random value that matches one of those tested as
2016 condition to clear the mouse face.
2017
d3d0842f
CY
20182011-10-28 Chong Yidong <cyd@gnu.org>
2019
2020 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
2021
31b39d13
DN
20222011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
2023
2024 * window.c (make_window): Initialize phys_cursor_on_p.
2025
9aba6043
SM
20262011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
2027
2028 * lisp.h (struct Lisp_Symbol): Update comments.
2029
c20992f4
JB
20302011-10-28 Juanma Barranquero <lekktu@gmail.com>
2031
2032 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
2033
db4f02f2
EZ
20342011-10-28 Eli Zaretskii <eliz@gnu.org>
2035
2036 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
2037 <oslsachem@gmail.com> for helping to debug this.
2038
2039 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
2040 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
2041 (g_b_init_get_glyph_outline_w): New static variables.
2042 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
2043 (GetGlyphOutlineW_Proc): New typedefs.
2044 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
2045 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
2046 New functions.
2047 (w32font_open_internal, compute_metrics):
2048 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
2049 instead of calling the "wide" APIs directly.
2050
2051 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
2052
2053 * w32.h (syms_of_w32font): Add prototype.
2054
87e68db4
JB
20552011-10-27 Juanma Barranquero <lekktu@gmail.com>
2056
2057 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
2058 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
2059 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
2060 (Fmove_to_window_line): Doc fix.
2061
435c1d67
CY
20622011-10-27 Chong Yidong <cyd@gnu.org>
2063
2064 * process.c (make_process): Set gnutls_state to NULL.
2065
2066 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
2067 non-NULL, regardless of GNUTLS_INITSTAGE.
2068 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
2069 an error. Set process slots as soon as we allocate them.
2070
2071 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
2072
9c6c6f49
CY
20732011-10-27 Chong Yidong <cyd@gnu.org>
2074
9aba6043
SM
2075 * gnutls.c (emacs_gnutls_deinit): New function.
2076 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
2077 (Fgnutls_deinit, Fgnutls_boot): Use it.
2078
2079 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2080 (deactivate_process): Call emacs_gnutls_deinit.
2081
657d08d3
JB
20822011-10-27 Juanma Barranquero <lekktu@gmail.com>
2083
2084 * image.c (x_create_x_image_and_pixmap):
2085 * w32.c (sys_rename, w32_delayed_load):
2086 * w32font.c (fill_in_logfont):
2087 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2088
5430d399
JB
20892011-10-26 Juanma Barranquero <lekktu@gmail.com>
2090
2091 * w32fns.c (w32_default_color_map): New function,
2092 extracted from Fw32_default_color_map.
a7ef684b 2093 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 2094
fe0055fa
PE
20952011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2096
2097 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2098
e6346438
SM
20992011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2100
2101 * keyboard.c (test_undefined): New function (bug#9751).
2102 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2103
e112cc37
ET
21042011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2105
2106 * sysdep.c (init_sys_modes): Fix the check for the controlling
2107 terminal (Bug#6649).
2108
7b5d6677
EZ
21092011-10-20 Eli Zaretskii <eliz@gnu.org>
2110
2111 * dispextern.h (struct bidi_it): New member next_en_type.
2112
2113 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2114 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2115 current character, check also for next_en_type being WEAK_EN.
2116 (bidi_resolve_weak): Don't enter the expensive loop if the current
2117 position is before next_en_pos. Record the bidi type of the first
2118 non-ET, non-BN character we find, in addition to its position.
2119 (bidi_level_of_next_char): Invalidate next_en_type when
2120 next_en_pos is over-stepped.
2121
7da0b018
PE
21222011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2123
2124 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2125 * editfns.c: Rewrite current-time-zone so that it invokes
2126 the equivalent of (format-time-string "%Z") to get the time zone name.
2127 This fixes a bug when the time zone name contains characters that
2128 need converting from the system time locale to Emacs internal format.
2129 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2130 that patch fixed format-time-string to do the conversion, but
2131 I forgot to fix current-time-zone.
2132 (format_time_string): New function, containing most of
2133 what Fformat_time_string used to contain.
2134 (Fformat_time_string): Rewrite in terms of format_time_string.
2135 This doesn't change this function's behavior.
2136 (current-time-zone): Rewrite to use format_time_string.
2137 This fixes the bug reported by Michael Schierl in
2138 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2139 Jason Rumney's 2007-06-07 change worked around this bug, but
2140 didn't fix it.
2141 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2142
8547b010
EZ
21432011-10-19 Eli Zaretskii <eliz@gnu.org>
2144
2145 * xdisp.c (start_display): If the character at POS is displayed
2146 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
2147 (try_window_reusing_current_matrix): If a line ends in a display
2148 vector or the next line starts in a display vector, continue
2149 redrawing the window even though the character position of
2150 start_row was reached.
8547b010
EZ
2151 (Bug#9771, part 2)
2152
4e948d15
CY
21532011-10-18 Chong Yidong <cyd@gnu.org>
2154
2155 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2156 with nobreak-char-display too.
2157
4787455f
EZ
21582011-10-18 Eli Zaretskii <eliz@gnu.org>
2159
2160 Fix part 3 of bug#9771.
2161 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2162 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2163 non-neutral characters if the current character is a paragraph
2164 separator (a.k.a. Newline). This avoids running the same
2165 expensive loop twice, once when we consume the preceding newline
2166 and the other time when the line actually needs to be displayed.
2167 Avoid the loop when we see neutrals on the base embedding level
2168 following a character whose directionality is the same as the
2169 paragraph's. This avoids running the expensive loop when a line
2170 ends in a long sequence of neutrals, like control characters.
2171 Add assertion against STRONG_AL type. Slightly rearrange code
2172 that determines the type of a neutral given the first non-neutral
2173 that follows it.
2174 (bidi_level_of_next_char): Set next_en_pos to zero when
2175 invalidating its info.
2176
2c91f553
EZ
21772011-10-17 Eli Zaretskii <eliz@gnu.org>
2178
2179 * xdisp.c (push_display_prop): Determine whether to record string
2180 or buffer position by IT->string, not by IT->method. Allow
2181 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
2182 (move_it_vertically_backward): Don't look for character position
2183 immediately after the newline when in a continuation line.
2184 (Bug#9771, part 1)
2c91f553 2185
c7b08b0d
MR
21862011-10-15 Martin Rudalics <rudalics@gmx.at>
2187
2188 * window.c (coordinates_in_window): Rewrite and delabelize
2189 vertical border check. (Bug#5357) (Bug#9618)
2190
6b02f655
SM
21912011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2192
2193 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2194 errors in XSetWindowBorder (bug#9310).
2195
81d40c92
DA
21962011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2197
2198 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2199 avoid crash when xmalloc overrun checking is enabled.
2200
d4172c3b
EZ
22012011-10-13 Eli Zaretskii <eliz@gnu.org>
2202
2203 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2204 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2205 cursor motion with <left> and <right> arrow keys.
2206
2207 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2208 some callers set that themselves.
2209
b00eea75
EZ
22102011-10-12 Eli Zaretskii <eliz@gnu.org>
2211
2212 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2213 display string and the previous row comes from the same string and
2214 is empty. (Bug#9739) (Bug#9738)
2215
8fe012c4
SM
22162011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2217
2218 * doc.c (get_doc_string): Encode file name (bug#9735).
2219
0074aef2
EZ
22202011-10-12 Eli Zaretskii <eliz@gnu.org>
2221
79beb178
EZ
2222 * bidi.c (bidi_level_of_next_char):
2223 * xdisp.c (get_visually_first_element): Remove old incorrect
2224 comments regarding the Unicode Line Separator character.
2225
0074aef2
EZ
2226 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2227
6e4b3fbe
DA
22282011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2229
2230 * alloc.c (Fgc_status): Do not access beyond zombies array
2231 boundary if nzombies > MAX_ZOMBIES.
2232 * alloc.c (dump_zombies): Add missing format specifier.
2233
0324f3af
PE
22342011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2235
b5525cac
PE
2236 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2237 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2238
0324f3af
PE
2239 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2240 Some packages use them to denote characters with modifiers.
2241
e9b5f888
AS
22422011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2243
2244 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2245 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2246 matching a pp-number. Rename parameter var to var1.
2247
127827c0
SM
22482011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2249
2250 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2251
c8fd3bd0
GM
22522011-10-08 Glenn Morris <rgm@gnu.org>
2253
2254 * callint.c (Fcall_interactively): Give a more explicit error for the
2255 'c' case with a non-character input. (Bug#8479)
2256
352ec8ff
EZ
22572011-10-08 Eli Zaretskii <eliz@gnu.org>
2258
03669ccb
EZ
2259 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2260 lines.
7061c986
EZ
2261 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2262 lines that are hscrolled on the left.
03669ccb 2263
352ec8ff
EZ
2264 * dispnew.c (buffer_posn_from_coords): Account for a possible
2265 presence of header-line. (Bug#4426)
2266
a66cfb1c
SM
22672011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2268
6b02f655
SM
2269 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2270 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 2271
7c5ee88e
PE
22722011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2273
2274 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2275 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2276 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2277 this makes Emacs dump core during garbage collection on rare
2278 occasions. sizeof is obviously inferior to offsetof here, so
2279 stick with offsetof.
2280 (GC_POINTER_ALIGNMENT): New macro.
2281 (mark_memory): Omit 3rd (offset) arg; caller changed.
2282 Don't assume EMACS_INT alignment is the same as pointer alignment.
2283
df1bbe5b
SM
22842011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2285
2286 * keyboard.c (read_key_sequence_remapped): New var.
2287 (read_key_sequence): Compute remapping in the right buffer.
2288 (command_loop_1): Use read_key_sequence's remapping directly.
2289
51553db6
SM
22902011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2291
32c1fffd
SM
2292 * dired.c (file_name_completion): Don't expand file name.
2293 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2294 before checking file name handler.
2295
51553db6
SM
2296 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2297 they've been requested explicitly (bug#9591).
2298
b6bd1599 22992011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
2300
2301 * keymap.c (Fsingle_key_description): Use make_specified_string
2302 instead of build_string to build string from push_key_description.
2303 (Bug#5193)
2304
f701dc2a
PE
23052011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2306
4222c55d
PE
2307 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2308 This fixes a Y2038 bug on 64-bit hosts.
2309 * buffer.c (reset_buffer):
2310 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2311 (Fclear_buffer_auto_save_failure):
2312 Use 0, not -1, to represent an unset failure time, since time_t
2313 might not be signed.
2314
f701dc2a
PE
2315 Remove dependency on glibc malloc internals.
2316 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2317 Move back here from lisp.h, but with their new implementations.
2318 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2319 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2320 * charset.c (charset_table_init): New static var.
2321 (syms_of_charset): Use it instead of xmalloc. This removes a
2322 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2323 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2324 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2325 Move back to alloc.c.
2326 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2327 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2328
9ceebf39
JD
23292011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2330
2331 * nsterm.m (windowDidResize): Call x_set_window_size only when
2332 ns_in_resize is true. Otherwise set pixelwidth/height and
2333 call change_frame_size (Bug#9628).
2334
cb993c58
PE
23352011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2336
3930c88b
PE
2337 Port --enable-checking=all to Fedora 14 x86-64.
2338 * charset.c (syms_of_charset): Also account for glibc malloc's
2339 internal overhead when calculating the initial malloc maximum.
2340
cb993c58
PE
2341 Port --enable-checking=all to Fedora 14 x86.
2342 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2343 Move to lisp.h.
2344 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2345 (overrun_check_realloc, overrun_check_free):
2346 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2347 That way, xmalloc returns a properly-aligned pointer even if
2348 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2349 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2350 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2351 into account when calculating the initial malloc maximum.
2352 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2353 Move here from alloc.c, so that charset.c can use it too.
2354 Properly align; the old code wasn't right for common 32-bit hosts
2355 when configured with --enable-checking=all.
2356 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2357 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2358
31bed486
EZ
23592011-09-29 Eli Zaretskii <eliz@gnu.org>
2360
04c70788 2361 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
2362 use EDOM.
2363
fbcaa2f3
EZ
23642011-09-28 Eli Zaretskii <eliz@gnu.org>
2365
2366 * xdisp.c (compute_display_string_end): If there's no display
2367 string at CHARPOS, return -1.
2368
2369 * bidi.c (bidi_fetch_char): When compute_display_string_end
2370 returns a negative value, treat the character as a normal
2371 character not covered by a display string. (Bug#9624)
2372
a239d4e9
JB
23732011-09-28 Juanma Barranquero <lekktu@gmail.com>
2374
2375 * lread.c (Fread_from_string): Fix typo in docstring.
2376
88652fd5
EZ
23772011-09-27 Eli Zaretskii <eliz@gnu.org>
2378
2379 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2380 newline, reseat the iterator instead of bidi-iterating there one
2381 character at a time. (Bug#9610)
32c1fffd
SM
2382 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2383 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 2384
ed497dd4
AS
23852011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2386
2387 * lread.c (readevalloop): Use correct code for NBSP.
2388 (read1): Likewise. (Bug#9608)
2389
b2bf61aa
MA
23902011-09-25 Michael Albinus <michael.albinus@gmx.de>
2391
2392 * dbusbind.c (Fdbus_register_signal): When service is not
2393 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2394
32bbb17c
GM
23952011-09-25 Glenn Morris <rgm@gnu.org>
2396
2397 * buffer.c (truncate-lines): Doc fix.
2398
94e0933e
CY
23992011-09-24 Chong Yidong <cyd@stupidchicken.com>
2400
2401 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2402 (Fset_window_next_buffers): Doc fix.
2403
cddde921
GM
24042011-09-24 Glenn Morris <rgm@gnu.org>
2405
2406 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2407
1260aef1
PE
24082011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2409
25b4bfa0
PE
2410 Fix minor problems found by static checking.
2411 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2412 * indent.c (Fvertical_motion): Fix == vs = typo.
2413
e3cbd34b
EZ
24142011-09-24 Eli Zaretskii <eliz@gnu.org>
2415
a66cfb1c
SM
2416 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2417 Default value is now t. Doc fix.
6bf7006f 2418
e3cbd34b 2419 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2420 logic when moving up, not only when moving down. Fix the
e3cbd34b 2421 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2422 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2423
2424 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2425 CHARPOS is covered by a display string which includes newlines.
2426 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2427 is covered by a display string with embedded newlines.
2428
a3de0cbd
MA
24292011-09-24 Michael Albinus <michael.albinus@gmx.de>
2430
2431 * dbusbind.c (Fdbus_register_signal): Add match rule to
2432 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2433 (Fdbus_register_method, Vdbus_registered_objects_table):
2434 Fix docstring.
a3de0cbd 2435
b260039d
JM
24362011-09-24 Jim Meyering <meyering@redhat.com>
2437
32c1fffd 2438 do not ignore write error for any output size
b260039d
JM
2439 The previous change was incomplete.
2440 While it makes emacs --batch detect the vast majority of stdout
2441 write failures, errors were still ignored whenever the output size is
2442 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2443 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2444 && echo FAIL: ignored write error
2445 FAIL: ignored write error
2446 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2447 && echo FAIL: ignored write error
2448 FAIL: ignored write error
2449 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2450
8eca8a7c
AS
24512011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2452
2453 * emacs.c (Fkill_emacs): In noninteractive mode exit
2454 non-successfully if a write error occurred on stdout. (Bug#9574)
2455
3341db62
EZ
24562011-09-21 Eli Zaretskii <eliz@gnu.org>
2457
2458 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2459 the xassert test.
2460
2461 * dispextern.h (struct it): Update the comment documenting what
2462 can it->OBJECT be.
2463
8c203dbf
EZ
24642011-09-20 Eli Zaretskii <eliz@gnu.org>
2465
2466 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2467 a display string, extend search for cursor position to end of row.
2468 (find_row_edges): If the row ends in a newline from a display
2469 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2470 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2471 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2472 non-empty line. Fixes confusing cursor motion with arrow keys at
2473 the beginning of a line that starts with whitespace.
8c203dbf 2474
a4824228
LMI
24752011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2476
2477 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2478 (bug#9493).
2479
33ed493b
CY
24802011-09-18 Chong Yidong <cyd@stupidchicken.com>
2481
2482 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2483 boolean (Bug#9154).
2484
56cd55c8
EZ
24852011-09-18 Eli Zaretskii <eliz@gnu.org>
2486
2487 * xdisp.c (display_line): Record maximum and minimum buffer
2488 positions even if no glyphs were produced (e.g., by a zero-width
2489 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2490 buffer positions that will be removed from the glyph row because
2491 they don't fit.
c02dcedf
EZ
2492 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2493 column is beyond frame width: don't subtract 1 "pixel" when
2494 computing width of the stretch.
3e62b7e0
EZ
2495 (reseat_at_next_visible_line_start): Undo the change made on
2496 2011-09-17 that saved paragraph information and restored it after
2497 the call to `reseat'. (Bug#9545)
56cd55c8 2498
5ed99d36 24992011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2500
2501 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2502 and turn window cursor on if cleared (Bug#9415).
2503
5ed99d36 25042011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2505
2506 * search.c (boyer_moore): Take unibyte characters from pattern
2507 literally. (Bug#9458)
2508
9bade7b2
EZ
25092011-09-18 Eli Zaretskii <eliz@gnu.org>
2510
2511 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2512
e5e9d610
PE
25132011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2514
87e4427a
PE
2515 Fix minor problem found by static checking.
2516 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2517 initialized, to pacify gcc -Wuninitialized.
2518
e5e9d610
PE
2519 * fileio.c: Report proper errno when syscall falls.
2520 (Finsert_file_contents): Save and restore errno,
2521 so that report_file_error outputs the correct diagnostic.
2522 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2523
a1674f0b
EZ
25242011-09-18 Eli Zaretskii <eliz@gnu.org>
2525
2526 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2527
fbfb6dd4
EZ
25282011-09-17 Eli Zaretskii <eliz@gnu.org>
2529
2530 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2531 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2532
bb187662
EZ
25332011-09-17 Eli Zaretskii <eliz@gnu.org>
2534
1137e8b8 2535 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2536 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2537
2538 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2539 (bidi_find_paragraph_start): Search back for paragraph beginning
2540 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2541 (bidi_move_to_visually_next): Only trigger paragraph-related
2542 computations when the last character is a newline or at EOB, not
2543 just any NEUTRAL_B. (Bug#9470)
2544
bb187662
EZ
2545 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2546 truncated lines if point is covered by a display string. (Bug#9524)
2547
2e621251
PE
25482011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2549
2550 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2551 (cons_to_x_long): New function.
2552 (lisp_data_to_selection_data): Use it. Correct the test for
2553 short-versus-long data; it was negated. Break out of vector
2554 loop, for efficiency, when a long datum is discovered.
2555
91a15bc6
SM
25562011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2557
2558 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2559
b41c3a35
EZ
25602011-09-16 Eli Zaretskii <eliz@gnu.org>
2561
2562 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2563 GCC PR/17406) by declaring this function with external scope.
2564
7812ba2d
PE
25652011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2566
2567 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2568 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2569
cf7edc2a
AS
25702011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2571
2572 * editfns.c (Fformat): Correctly handle text properties on "%%".
2573
bd01620e
EZ
25742011-09-15 Eli Zaretskii <eliz@gnu.org>
2575
2576 * xterm.c (x_draw_composite_glyph_string_foreground):
2577 * w32term.c (x_draw_composite_glyph_string_foreground):
2578 * term.c (encode_terminal_code):
2579 * composite.c (composition_update_it, get_composition_id):
2580 * xdisp.c (get_next_display_element)
2581 (fill_composite_glyph_string): Add comments about special meaning
2582 of TAB characters in a composition.
2583
a02719a3
PE
25842011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2585
2586 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2587 This occurs when processing a multibyte format.
2588 Problem reported by Wolfgang Jenker.
a02719a3 2589
72589a3c
JB
25902011-09-15 Johan Bockgård <bojohan@gnu.org>
2591
2592 * xdisp.c (try_cursor_movement): Only check for exact match if
2593 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2594
1c14176c
PE
25952011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2596
2597 Remove unused external symbols.
2598 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2599 * xdisp.c (calc_pixel_width_or_height): Now static.
2600 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2601 * indent.c (check_display_width):
2602 * w32term.c: Fix comment to match code.
2603 * xterm.c, xterm.h (x_catching_errors): Remove.
2604
d2eea5b5
PE
26052011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2606
2607 * xselect.c: Use signed conversions more consistently (Bug#9498).
2608 (selection_data_to_lisp_data): Assume incoming selection data are
2609 signed integers, not unsigned. This is to be consistent with
2610 outgoing selection data, which was modified to use signed integers
2611 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2612 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2613 expects long, not unsigned long.
2614
46888499
EZ
26152011-09-14 Eli Zaretskii <eliz@gnu.org>
2616
2617 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2618 computation of loop end. Reported by Johan Bockgård
2619 <bojohan@gnu.org>.
2620
ef8ef9fb
CY
26212011-09-13 Chong Yidong <cyd@stupidchicken.com>
2622
2623 * frame.c (Fother_visible_frames_p): Function deleted.
2624
fa819fed
EZ
26252011-09-12 Eli Zaretskii <eliz@gnu.org>
2626
2627 * indent.c (compute_motion): Process display vector front to back
2628 rather than the other way around. (Bug#2496)
2629
2ba8e008
SM
26302011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2631
2632 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2633
20f53c69
CY
26342011-09-11 Chong Yidong <cyd@stupidchicken.com>
2635
2636 * minibuf.c (Fread_from_minibuffer): Doc fix.
2637
d562d7a4
EZ
26382011-09-11 Eli Zaretskii <eliz@gnu.org>
2639
2640 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2641 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2642
1c4d7f3d
LMI
26432011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2644
2645 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2646 value for non-existent files.
2647
b885bf36
EZ
26482011-09-11 Eli Zaretskii <eliz@gnu.org>
2649
2650 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2651 set its "size" to -1. This will set the modtime_size field of
2652 the corresponding buffer to -1, which is what
2653 verify-visited-file-modtime expects for files that do not exist.
2654 (Bug#9139)
2655
6612f0bf
PE
26562011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2657
2658 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2659 here ...
2660 * lisp.h: ... from here. push_key_description is no longer
2661 defined in keyboard.c, so its declaration should not be in
2662 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2663 logically belongs with push_key_description.
2664
dfb3f755
PE
26652011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2666
2667 * buffer.h: Include <sys/types.h> instead of <time.h>.
2668 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2669 Problem reported by Herbert J. Skuhra.
2670
3134906c
LMI
26712011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2672
2673 * xml.c (parse_region): Make the parsing work for
2674 non-comment-starting XML files again (bug#9144).
2675
8d903f4e
AS
26762011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2677
2678 * image.c (gif_load): Fix calculation of bottom and right corner.
2679 (Bug#9468)
2680
80ad64f4
EZ
26812011-09-10 Eli Zaretskii <eliz@gnu.org>
2682
2683 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2684 redisplay in small windows.
2685
208a048d
EZ
26862011-09-09 Eli Zaretskii <eliz@gnu.org>
2687
2688 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2689
9b1c252e
MR
26902011-09-08 Martin Rudalics <rudalics@gmx.at>
2691
2692 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2693 Operate on live windows only.
2694
2949f33b
JB
26952011-09-08 Juanma Barranquero <lekktu@gmail.com>
2696
2697 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2698
e08dcafd
EZ
26992011-09-07 Eli Zaretskii <eliz@gnu.org>
2700
2701 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2702 only under bidi iteration.
2703
115b96bd
JD
27042011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2705
2706 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2707
c8199d0f
PE
27082011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2709
2710 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2711 Without this fix, the command to link temacs failed due to an
2712 undefined symbol __builtin_isnan. This is because
2713 /usr/include/iso/math_c99.h #defines isnan(x) to
2714 __builtin_isnan(x), but the bundled gcc, which identifies itself
2715 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2716 a __builtin_isnan.
2717 * floatfns.c (isnan): #undef, and then #define to a clone of
2718 what's in data.c.
2719 (Fisnan): Always define, since it's always available now.
2720 (syms_of_floatfns): Always define isnan at the Lisp level.
2721
e39b275c 27222011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2723
2724 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2725
b2db44d9 27262011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2727
f4af5137 2728 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2729 The previous code assumed that file offsets (off_t values) fit in
2730 EMACS_INT variables, which is not true on typical 32-bit hosts.
2731 The code messed up by falsely reporting buffer overflow in cases
2732 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2733 when "big" contains more than 2**29 bytes, even though this
2734 inserts just one byte and does not overflow the buffer.
2735 (Finsert_file_contents): Store file offsets as off_t
2736 values, not as EMACS_INT values. Check for overflow when
2737 converting between EMACS_INT and off_t. When checking for
2738 buffer overflow or for overlap, take the offsets into account.
2739 Don't use EMACS_INT for small values where int suffices.
2740 When checking for overlap, fix a typo: ZV was used where
2741 ZV_BYTE was intended.
2742 (Fwrite_region): Don't assume off_t fits into 'long'.
2743 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2744
ecfc0a49
MA
27452011-09-05 Michael Albinus <michael.albinus@gmx.de>
2746
2747 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2748
6511acf2 27492011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2750
0999621a 2751 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2752
2753 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2754 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2755 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2756 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2757 (modify_event_symbol): Do not assume that the length of
2758 name_alist_or_stem is safe to alloca and fits in int.
2759 (Fexecute_extended_command): Likewise for function name and binding.
2760 (Frecursion_depth): Wrap around reliably on integer overflow.
2761 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2762 since some callers pass EMACS_INT values.
2763 (Fsingle_key_description): Don't crash if symbol name contains more
2764 than MAX_ALLOCA bytes.
2765 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2766 (get_minibuffer): Arg is now EMACS_INT, not int.
2767 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2768 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2769 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2770
2be7d702
PE
2771 * dbusbind.c (signature_cat): New function.
2772 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2773 Do not overrun buffer; instead, report string overflow.
2774
9d1df220
PE
2775 * dispnew.c (add_window_display_history): Don't overrun buffer.
2776 Truncate instead; this is OK since it's just a log.
2777
33ef5c64
PE
2778 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2779 even if the time zone offset is outlandishly large.
2780 Don't mishandle offset == INT_MIN.
2781
66c6fdd5
PE
2782 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2783 when creating daemon; the previous buffer-overflow check was incorrect.
2784
d749b01b
PE
2785 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2786 which has the guts of the old verror function.
2787
b5cd1905
PE
2788 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2789 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2790
6e1a67fb
PE
2791 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2792 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2793 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2794 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2795 length of string rather than counting it via multiple sprintfs;
2796 that's simpler and more reliable.
c21721cc
PE
2797 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2798 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2799 sprintf, in case result does not fit in int.
2800
c57b67fc
PE
2801 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2802 (fontset_from_font): Print it.
2803
8a401434
PE
2804 * frame.c (tty_frame_count): Now printmax_t, not int.
2805 (make_terminal_frame, set_term_frame_name): Print it.
2806 (x_report_frame_params): In X, window IDs are unsigned long,
2807 not signed long, so print them as unsigned.
2808 (validate_x_resource_name): Check for implausibly long names,
2809 and don't assume name length fits in 'int'.
2810 (x_get_resource_string): Don't blindly alloca invocation name;
2811 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2812 not fit in int.
2813
6e1a67fb
PE
2814 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2815 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2816 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2817
0df02bf3
PE
2818 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2819 Use esprintf, not sprintf, in case result does not fit in int.
2820
48e30793
PE
2821 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2822 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2823 it as a large positive number.
2824 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2825 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2826
a66ff6d8
PE
2827 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2828 in case result does not fit in int.
2829
aca216ff
PE
2830 * print.c (float_to_string): Detect width overflow more reliably.
2831 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2832 buffer overrun. Don't assume list length fits in 'int'. Treat
2833 print length of 0 as 0, not as infinity; to be consistent with other
2834 uses of print length in this function. Don't overflow print length
2835 index. Don't assume hash table size fits in 'long', or that
2836 vectorlike size fits in 'unsigned long'.
2837
31c286f7
PE
2838 * process.c (make_process): Use printmax_t, not int, to format
2839 process-name gensyms.
2840
55e5faa1
PE
2841 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2842
80f2e268
PE
2843 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2844 to avoid potential buffer overrun.
2845
670741ab
PE
2846 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2847 if X resource line is longer than 512 bytes.
2848
b7163a50
PE
2849 * xfns.c (x_window): Make sprintf buffer a bit bigger
2850 to avoid potential buffer overrun.
2851
ae58ff1f
PE
2852 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2853
c43c8a6a
PE
2854 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2855
3f8236f4
PE
28562011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2857
53e9fe90 2858 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2859 Without these, Emacs silently mishandles large integers sometimes.
2860 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2861 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2862
6511acf2
PE
2863 * xdisp.c (try_window_id): Check Emacs fixnum range before
2864 converting to 'int'.
806add1d 2865
6511acf2 2866 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2867 Check that an Emacs fixnum is in range before assigning it to 'int'.
2868 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2869 values converted from Emacs fixnums.
2870 (Frecenter): Don't wrap around a line count if it is out of 'int'
2871 range; instead, treat it as an extreme value.
2872 (Fset_window_configuration, compare_window_configurations):
2873 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2874
6511acf2
PE
2875 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2876 that can exceed INT_MAX. Check that EMACS_INT value is in range
2877 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2878 (match_limit): Don't assume that a fixnum can fit in 'int'.
2879
6511acf2 2880 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2881 exceed INT_MAX.
2882
6511acf2 2883 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2884 (Fvertical_motion): Don't wrap around LINES values that don't fit
2885 in 'int'. Instead, treat them as extreme values. This is good
2886 enough for windows, which can't have more than INT_MAX lines anyway.
2887
fcb901a7
LMI
28882011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2889
0f2f6b6d
LMI
2890 * Require libxml/parser.h to avoid compilation warning.
2891
fcb901a7
LMI
2892 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2893
2894 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2895 since this reportedly can destroy thread storage.
2896
6e20a0d4
CY
28972011-08-30 Chong Yidong <cyd@stupidchicken.com>
2898
2899 * syntax.c (find_defun_start): Update all cache variables if
2900 exiting early (Bug#9401).
2901
148ae00e
EZ
29022011-08-30 Eli Zaretskii <eliz@gnu.org>
2903
f6cfbd8f
EZ
2904 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2905
148ae00e
EZ
2906 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2907 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2908 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2909
2910 * term.c (tty_append_glyph): New function.
2911 (produce_stretch_glyph): Static function and its prototype deleted.
2912
a66cfb1c
SM
2913 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2914 Add prototypes.
148ae00e 2915
c4a07a4c
PE
29162011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2917
2918 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2919 when checking :margin (Bug#9390).
2920 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2921 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2922 so that the name doesn't mislead. All uses changed.
2923
6bc8cd65
JB
29242011-08-28 Johan Bockgård <bojohan@gnu.org>
2925
2926 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2927 set_tty_hooks.
2928
dca4927e
EZ
29292011-08-27 Eli Zaretskii <eliz@gnu.org>
2930
2931 * xdisp.c (move_it_to): Don't bail out early when reaching
2932 position beyond to_charpos, if we are scanning backwards.
2933 (move_it_vertically_backward): When DY == 0, make sure we get to
2934 the first character in the line after the newline.
2935
f2cad773
PE
29362011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2937
2938 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2939 (ccl_driver): Do not generate an out-of-range pointer.
2940 (Fccl_execute_on_string): Remove unnecessary check for
2941 integer overflow, noted by Stefan Monnier in
2942 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2943 Remove a FIXME that didn't need fixing.
2944 Simplify the newly-introduced buffer reallocation code.
2945
0cae2cdb
JB
29462011-08-27 Juanma Barranquero <lekktu@gmail.com>
2947
2948 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2949
5fc295a4 29502011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2951
70c60eb2 2952 Integer and memory overflow issues (Bug#9196).
726e0ab1 2953
d31850da
PE
2954 * doc.c (get_doc_string): Rework so that
2955 get_doc_string_buffer_size is the actual buffer size, rather than
2956 being 1 less than the actual buffer size; this makes xpalloc more
2957 convenient.
2958
a69fbedb
PE
2959 * image.c (x_allocate_bitmap_record, cache_image):
2960 * xselect.c (Fx_register_dnd_atom):
2961 Simplify previous changes by using xpalloc.
2962
fe5c5d37
PE
2963 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2964 since either will do and ptrdiff_t is convenient with xpalloc.
2965
0065d054
PE
2966 * charset.c (charset_table_size)
2967 (struct charset_sort_data.priority): Now ptrdiff_t.
2968 (charset_compare): Don't overflow if priorities differ greatly.
2969 (Fsort_charsets): Don't assume list length fits in int.
2970 Check for size-calculation overflow when allocating sort data.
2971 (syms_of_charset): Allocate an initial charset table that is
2972 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2973
2974 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2975
2976 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2977 The actual value is always <= INT_MAX, and leaving it unsigned made
2978 overflow checking harder.
2979
2980 * dispextern.h (struct glyph_matrix.rows_allocated)
2981 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2982 with xpalloc. The values are still always <= INT_MAX.
2983
2984 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2985
2986 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2987 (SAFE_NALLOCA): New macro.
2988
2989 * region-cache.c (struct boundary.pos, find_cache_boundary)
2990 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2991 (set_cache_region, invalidate_region_cache)
2992 (revalidate_region_cache, know_region_cache, region_cache_forward)
2993 (region_cache_backward, pp_cache):
2994 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2995 so that ptrdiff_t * can be passed to xpalloc.
2996 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2997 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2998 (pp_cache): Don't assume cache_len fits in int.
2999 * region-cache.h: Adjust extern decls to match.
3000
3001 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
3002 EMACS_INT, since either will do, for xpalloc.
3003
3004 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
3005 (xnmalloc, xnrealloc, xpalloc): New functions.
3006
726e0ab1
PE
3007 * bidi.c (bidi_shelve_header_size): New constant.
3008 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
3009 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
3010
51f30bc5 3011 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
3012 * buffer.c (overlays_at, overlays_in, record_overlay_string)
3013 (overlay_strings):
3014 Don't update size of array until after memory allocation succeeds,
3015 because xmalloc/xrealloc may not return.
0065d054
PE
3016 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
3017 now that we have proper integer overflow checking.
3018 (record_overlay_string, overlay_strings): Catch overflows when
3019 calculating size of overlay_str_buf.
726e0ab1 3020
0065d054
PE
3021 * callproc.c (Fcall_process): Check for size overflow when
3022 calculating size of args2.
3023 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
3024 Normally we prefer signed values, but sticking with ptrdiff_t would
3025 require adding more-complicated checks.
726e0ab1
PE
3026
3027 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
3028 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
3029 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 3030 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
3031
3032 * character.c (Fstring): Check for size-calculation overflow.
3033
3034 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
3035 unnecessary integer overflow. Check for size overflow.
3036 (encode_coding_object): Don't update size until xmalloc succeeds.
3037
3038 * composite.c (get_composition_id): Check for overflow in glyph
3039 length calculations.
3040
3041 Integer and memory overflow fixes for display code.
3042 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
3043 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
3044 (scrolling_window): Check for overflow in size calculations.
3045 (line_draw_cost, realloc_glyph_pool, add_row_entry):
3046 Don't assume glyph table len fits in int.
3047 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
3048 (row_table_size): Now ptrdiff_t, not int.
3049 (scrolling_window): Avoid overflow in size calculations.
3050 Don't update size until allocation succeeds.
3051 * fns.c (concat): Check for overflow in size calculations.
3052 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
3053 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3054 (NEXT_ALMOST_PRIME_LIMIT): New constant.
3055
3056 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
3057 (get_doc_string): Check for size calculation overflow.
3058 Don't update size until allocation succeeds.
3059 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
3060 EMACS_INT, where ptrdiff_t will do.
3061 (Fsubstitute_command_keys): Check for string overflow.
3062
3063 * editfns.c (set_time_zone_rule): Don't assume environment length
3064 fits in int.
3065 (message_length): Now ptrdiff_t, not int.
3066 (Fmessage_box): Don't update size until allocation succeeds.
3067 Don't assume message length fits in int.
3068 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
3069
0065d054
PE
3070 * emacs.c (main): Do not reallocate argv, since there is a null at
3071 the end that can be overwritten, and this way there's no need to
3072 worry about size-calculation overflow.
3073 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
3074
3075 * eval.c (init_eval_once, grow_specpdl): Don't update size until
3076 alloc succeeds.
3077 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3078
3079 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3080 (x_set_scroll_bar_width, x_figure_window_size):
3081 Check for integer overflow.
3082 (x_set_alpha): Do not assume XINT fits in int.
3083
3084 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3085 This is for the members text_lines, text_cols, total_lines, total_cols,
3086 where the system imposes an 'int' limit.
3087
3088 * fringe.c (Fdefine_fringe_bitmap):
3089 Don't update size until alloc works.
3090
3091 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3092 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3093
3094 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3095 Check for size-calculation overflow.
3096 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3097 do, as we prefer signed integers.
3098 (id_to_widget.max_size, id_to_widget.used)
3099 (xg_store_widget_in_map, xg_remove_widget_from_map)
3100 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3101 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3102 Use and return ptrdiff_t, not int.
3103 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3104 * gtkutil.h: Change prototypes to match the above.
3105
3106 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3107 are duplicate now that they've been promoted to lisp.h.
3108 (x_allocate_bitmap_record, x_alloc_image_color)
3109 (make_image_cache, cache_image, xpm_load):
3110 Don't update size until alloc is done.
3111 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3112 (x_detect_edges):
3256efce 3113 Check for size calculation overflow.
726e0ab1
PE
3114 (ct_colors_allocated_max): New constant.
3115 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3116 overflow.
3256efce 3117
726e0ab1
PE
3118 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3119 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3120 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3121 Use ptrdiff_t, not int, to count maps.
3122 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
3123 calculations. Don't update size until allocation succeeds.
3124 Redo calculations to avoid overflow.
726e0ab1
PE
3125 * keyboard.h: Change prototypes to match the above.
3126
3127 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3128 to count maps.
3129 (current_minor_maps): Check for size calculation overflow.
3130 * keymap.h: Change prototypes to match the above.
3131
3132 * lread.c (read1, init_obarray): Don't update size until alloc done.
3133
3134 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3135 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3136
726e0ab1
PE
3137 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3138 Now ptrdiff_t, not int.
3139 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3140 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3141
3142 * process.c (Fnetwork_interface_list): Check for overflow
3143 in size calculation.
3144
3145 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3146
3147 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3148 overflow. Don't bother calling xmalloc when xrealloc will do.
3149
3150 * search.c (Freplace_match): Check for size calculation overflow.
3151 (Fset_match_data): Don't assume list lengths fit in 'int'.
3152
3153 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3154 for command line length. Do not attempt to address one before the
3155 beginning of an array, as that's not portable.
3156
3157 * term.c (max_frame_lines): Remove; unused.
3158 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3159 not int.
3160 (encode_terminal_code, calculate_costs): Check for size
3161 calculation overflow.
3162 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3163 table lengths and related sizes. Don't update size until alloc
3164 done. Redo calculations to avoid overflow.
3165 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3166
3167 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3168 subtracting pointers.
3169 (gobble_line): Check for overflow more carefully. Don't update size
3170 until alloc done.
3171
3172 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3173 Don't update size until alloc done.
3174 Redo size calculations to avoid overflow.
3175 Check for size calculation overflow.
0065d054 3176 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
3177
3178 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3179 Use ptrdiff_t, not int, for sizes.
3180 (store_mode_line_noprop_char): Don't update size until alloc done.
3181
0065d054
PE
3182 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3183 Use ptrdiff_t, not int, for sizes.
3184 (Finternal_make_lisp_face, cache_face):
3185 Check for size calculation overflow.
3186 (cache_face): Treat size calculation overflows as if they were
3187 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
3188
3189 * xfns.c (x_encode_text, x_set_name_internal)
3190 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3191 sizes, since they can exceed INT_MAX in size. Check for size
3192 calculation overflow.
3193
0065d054
PE
3194 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3195 (xg_select): Check for size calculation overflow.
726e0ab1
PE
3196 Don't update size until alloc done.
3197
0065d054 3198 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 3199 as sprintf is limited to int lengths.
1d526e2f 3200
252c5ee1
PE
3201 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3202 (X_LONG_MIN): New macros.
864d7ce7
PE
3203 Use them to make the following changes clearer.
3204 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3205 This change doesn't affect the value now, but it may help remind
3206 future maintainers not to raise the value too much later.
3207 (SELECTION_QUANTUM): Remove, replacing with ...
3208 (selection_quantum): ... new function, which avoids overflow.
3209 All uses changed.
3210 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3211 assumption that selection length fits in 'int'.
3212 (x_reply_selection_request, x_handle_selection_request)
3213 (x_get_window_property, receive_incremental_selection)
3214 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3215 (lisp_data_to_selection_data, clean_local_selection_data):
3216 Use ptrdiff_t, not int, to record length of selection.
3217 (x_reply_selection_request, x_get_window_property)
3218 (receive_incremental_selection, x_property_data_to_lisp):
3219 Redo calculations to avoid overflow.
3220 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 3221 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
3222 something.
3223 (x_get_window_property, receive_incremental_selection)
3224 (lisp_data_to_selection_data, x_property_data_to_lisp):
3225 Check for size-calculation overflow.
3226 (x_get_window_property, receive_incremental_selection)
3227 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3228 Don't store size until memory allocation succeeds.
3229 (x_get_window_property): Plug memory leak on memory exhaustion.
3230 Don't double-block input; malloc is safe here. Don't assume 2**34
3231 - 4 fits in unsigned long. Add an xassert to check
3232 XGetWindowProperty overflow. Be more careful about overflow
3233 calculations, and distinguish size from memory overflow better.
3234 (receive_incremental_selection): When tracing, don't assume
3235 unsigned int is less than INT_MAX.
3236 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3237 harmful) conversions of unsigned short to int.
3238 (lisp_data_to_selection_data): Don't assume that integers
3239 in the range -65535 through -1 fit in an X unsigned short.
3240 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3241 result parameters unless successful. Rely on cons_to_unsigned
3242 to report problems with elements; the old code wasn't right anyway.
3243 (x_check_property_data): Check for int overflow; we cannot use
3244 a wider type due to X limits.
3245 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3246
726e0ab1 3247 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 3248
0065d054
PE
3249 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3250 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
3251 (x_color_cells): Don't store size until memory allocation succeeds.
3252 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 3253 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
3254 (x_term_init): Don't assume length fits in int (sprintf is limited
3255 to int size).
bc18e09d 3256
ebfa62c0
PE
3257 Use ptrdiff_t for composition IDs.
3258 * character.c (lisp_string_width):
3259 * composite.c (composition_table_size, n_compositions)
3260 (get_composition_id, composition_gstring_from_id):
3261 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3262 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3263 * window.c (Frecenter):
3264 Use ptrdiff_t, not int, for composition IDs.
3265 * composite.c (get_composition_id): Check for integer overflow.
3266 * composite.h: Adjust prototypes to match the above changes.
3267
d3411f89
PE
3268 Use ptrdiff_t for hash table indexes.
3269 * category.c (hash_get_category_set):
3270 * ccl.c (ccl_driver):
3271 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3272 * coding.c (coding_system_charset_list, detect_coding_system):
3273 * coding.h (struct coding_system.id):
3274 * composite.c (get_composition_id, gstring_lookup_cache):
3275 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3276 * image.c (xpm_get_color_table_h):
3277 * lisp.h (hash_lookup, hash_put):
3278 * minibuf.c (Ftest_completion):
3279 Use ptrdiff_t for hash table indexes, not int (which is too
3280 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3281 32-bit --with-wide-int hosts).
3282
e097a6fa
PE
3283 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3284 Add a FIXME comment about memory leaks.
3285 (syms_of_charset): Don't assume xmalloc returns.
3286
5637687f
PE
3287 Don't assume that stated character widths fit in int.
3288 * character.c (Fchar_width, c_string_width, lisp_string_width):
3289 * character.h (CHAR_WIDTH):
3290 * indent.c (MULTIBYTE_BYTES_WIDTH):
3291 Use sanitize_char_width to avoid undefined and/or bad behavior
3292 with outlandish widths.
a66cfb1c 3293 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
3294 now that we have two such functions. All uses changed.
3295 (sanitize_char_width): New inline function.
3296
a2271ba2
PE
3297 Don't assume that tab-width fits in int.
3298 * character.h (sanitize_width): New inline function.
3299 (SANE_TAB_WIDTH): New macro.
3300 (ASCII_CHAR_WIDTH): Use it.
3301 * indent.c (sane_tab_width): Remove. All uses replaced by
3302 SANE_TAB_WIDTH (current_buffer).
3303 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3304
18c52557
PE
3305 * fileio.c: Integer overflow issues with file modes.
3306 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3307
caeeedc1
PE
3308 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3309 Remove unreachable code.
3310 (read_hex, load_charset_map_from_file): Check for integer overflow.
3311
6df6ae42 3312 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
3313 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3314 (x_send_scroll_bar_event): Likewise. Check that the size does not
3315 exceed limits imposed by XClientMessageEvent, as well as the usual
3316 ptrdiff_t and size_t limits.
3317
b13995db
PE
3318 * keyboard.c: Overflow, signedness and related fixes.
3319 (make_lispy_movement): Use same integer type in forward decl
3320 that is used in the definition.
3321 (read_key_sequence, keyremap_step):
3322 Change bufsize argument back to int, undoing my 2011-03-30 change.
3323 We prefer signed types, and int is wide enough here.
3324 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3325 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3326 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3327 length, not size_t. Use ptrdiff_t for index, not int.
3328 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3329 possibility of integer overflow.
3330
13464394
PE
3331 Overflow, signedness and related fixes for images.
3332
3333 * dispextern.h (struct it.stack[0].u.image.image_id)
3334 (struct_it.image_id, struct image.id, struct image_cache.size)
3335 (struct image_cache.used, struct image_cache.ref_count):
3336 * gtkutil.c (update_frame_tool_bar):
3337 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3338 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3339 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3340 * nsmenu.m (update_frame_tool_bar):
3341 * xdisp.c (calc_pixel_width_or_height):
3342 * xfns.c (image_cache_refcount):
3343 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3344 on typical 64-bit hosts.
3345
3346 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3347 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3348 Omit unnecessary casts to int.
3349 (parse_image_spec): Check that integers fall into 'int' range
3350 when the callers expect that.
3351 (image_ascent): Redo ascent calculation to avoid int overflow.
3352 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3353 (lookup_image): Remove unnecessary tests.
3354 (xbm_image_p): Locals are now of int, not EMACS_INT,
3355 since parse_image_check makes sure they fit into int.
3356 (png_load, gif_load, svg_load_image):
3357 Prefer int to unsigned where either will do.
3358 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
3359 old tiff_error_handler and tiff_warning_handler.
3360 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
3361 stack buffer overflows. It uses only the features of vsnprintf
3362 that are common to both POSIX and native Microsoft.
3363 (tiff_error_handler, tiff_warning_handler): Use it.
3364 (tiff_load, gif_load, imagemagick_load_image):
3365 Don't assume :index value fits in 'int'.
3366 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3367 (imagemagick_load_image): Check that crop parameters fit into
3368 the integer types that MagickCropImage accepts. Don't assume
3369 Vimagemagick_render_type has a nonnegative value. Don't assume
3370 size_t fits in 'long'.
3371 (gs_load): Use printmax_t to print the widest integers possible.
3372 Check for integer overflow when computing image height and width.
3373
c11821d4
EZ
33742011-08-26 Eli Zaretskii <eliz@gnu.org>
3375
3376 * xdisp.c (redisplay_window): Don't force window start if point
3377 will be invisible in the resulting window. (Bug#9324)
3378
0c95fcf7
EZ
33792011-08-25 Eli Zaretskii <eliz@gnu.org>
3380
3381 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3382 the display spec is of the form `(space ...)'.
3383 (handle_display_spec): Return the value returned by
3384 handle_single_display_spec, not just 1 or zero.
3385 (handle_single_display_spec): If the display spec is of the form
3386 `(space ...)', and specifies display in the text area, return 2
3387 rather than 1.
fee65a97 3388 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
3389 accurately, and prefer exact match for point under bidi.
3390 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
3391
3392 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3393 into disp_prop; all users changed.
3394
3395 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3396 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3397 for the text covered by the display property.
3398
e4ed06f1
CY
33992011-08-25 Chong Yidong <cyd@stupidchicken.com>
3400
3401 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3402 Change return value to nil.
3403 (Frecord_buffer): Delete unused function.
3404
f67cdd7f
EZ
34052011-08-24 Eli Zaretskii <eliz@gnu.org>
3406
5980d4c6
EZ
3407 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3408 buffers, return left-to-right.
8610fe8b
EZ
3409 (set_cursor_from_row): Consider candidate row a win if its glyph
3410 represents a newline and point is on that newline. Fixes cursor
3411 positioning on the newline at EOL of R2L text within L2R
3412 paragraph, and vice versa.
3413 (try_cursor_movement): Check continued rows, in addition to
3414 continuation rows. Fixes unwarranted scroll when point enters a
3415 continued line of R2L text within an L2R paragraph, or vice versa.
3416 (cursor_row_p): Consider the case of point being equal to
3417 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3418 from the end of a short line to the beginning of a continued line
3419 of R2L text within L2R paragraph.
3420 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3421 composed characters.
5980d4c6 3422
f67cdd7f
EZ
3423 * bidi.c (bidi_check_type): Use xassert.
3424 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3425 members.
3426
bca633fb
EZ
34272011-08-23 Eli Zaretskii <eliz@gnu.org>
3428
3429 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3430 a character.
3431
4a5885a7
CY
34322011-08-23 Chong Yidong <cyd@stupidchicken.com>
3433
3434 * nsfont.m (ns_otf_to_script): Fix typo.
3435
0902a04e
KH
34362011-08-22 Kenichi Handa <handa@m17n.org>
3437
3438 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3439 extra slot even if the purpose is char-code-property-table.
3440
1a2e6670
EZ
34412011-08-23 Eli Zaretskii <eliz@gnu.org>
3442
8ddde651
EZ
3443 * xdisp.c (redisplay_window): When computing centering_position,
3444 account for the height of the header line. (Bug#8874)
3445
425cc014
EZ
3446 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3447 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3448 candidate is selected by the mouse, and that candidate has a
3449 composed character under the mouse.
3450
1a2e6670
EZ
3451 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3452 coordinates reported by pos-visible-in-window-p for a composed
3453 character in column zero.
3454
8b76d6f8
SM
34552011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3456
3457 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3458
dac347dd
EZ
34592011-08-22 Eli Zaretskii <eliz@gnu.org>
3460
3461 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3462 consider it a hit if to_charpos is anywhere in the range of the
3463 composed buffer positions.
3464
e013fb34
CY
34652011-08-22 Chong Yidong <cyd@stupidchicken.com>
3466
3467 * image.c (gif_load): Don't assume that each subimage has the same
3468 dimensions as the base image. Handle disposal method that is
3469 "undefined" by the gif spec (Bug#9335).
3470
bd1ba3e8
CY
34712011-08-20 Chong Yidong <cyd@stupidchicken.com>
3472
3473 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3474 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3475
54a1215b
EZ
34762011-08-19 Eli Zaretskii <eliz@gnu.org>
3477
823564e5
EZ
3478 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3479 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3480 from an Org mode buffer to a Speedbar frame.
3481
54a1215b
EZ
3482 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3483 a composition, take its buffer position from IT->cmp_it.charpos.
3484 Fixes cursor positioning at the beginning of a line that begins
3485 with a composed character.
3486
9778ebcc
EZ
34872011-08-18 Eli Zaretskii <eliz@gnu.org>
3488
0be6ee06
EZ
3489 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3490 character bidirectional type, use STRONG_L instead. Fixes crashes
3491 in a buffer produced by `describe-categories'.
3492
9778ebcc
EZ
3493 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3494 members before the level stack, so they would be saved and
3495 restored when copying iterator state. Fixes incorrect reordering
3496 around TABs covered by display properties.
3497
156bffbe
AS
34982011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3499
6b02f655 3500 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3501
72ad093b
CY
35022011-08-17 Chong Yidong <cyd@stupidchicken.com>
3503
3504 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3505 (internal_condition_case_2, internal_condition_case_n):
3506 Remove unnecessary aborts (Bug#9081).
72ad093b 3507
35774242
EZ
35082011-08-17 Eli Zaretskii <eliz@gnu.org>
3509
3510 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3511 has no `load' handler, try opening the file locally. (Bug#9311)
3512
db76dd85
KB
35132011-08-16 Ken Brown <kbrown@cornell.edu>
3514
3515 * gmalloc.c: Expand comment.
3516
b215eee5
EZ
35172011-08-16 Eli Zaretskii <eliz@gnu.org>
3518
3519 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3520 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3521
a4579d33
KB
35222011-08-16 Ken Brown <kbrown@cornell.edu>
3523
3524 Fix memory allocation problems in Cygwin build (Bug#9273).
3525
3526 * unexcw.c ( __malloc_initialized): Declare external variable.
3527 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3528
8b76d6f8
SM
3529 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3530 New variables.
a4579d33
KB
3531 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3532 dumped emacs.
3533 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3534 in the static heap.
3535 [CYGWIN] (special_realloc): New function.
3536 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3537 requests to realloc storage in the static heap.
3538
3ebec551
PE
35392011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3540
3541 * bidi.c (bidi_initialize): Remove unused local.
3542
9fd8be00
EZ
35432011-08-15 Eli Zaretskii <eliz@gnu.org>
3544
6b02f655
SM
3545 * bidimirror.h:
3546 * biditype.h: Remove file.
3547 * makefile.w32-in ($(BLD)/bidi.$(O)):
3548 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3549
3550 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3551
3552 * chartab.c: Improve commentary for the uniprop_table API.
3553
32413314
EZ
3554 * bidi.c (bidi_paragraph_init): Support zero value of
3555 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3556 (bidi_initialize): Use uniprop_table instead of including
3557 biditype.h and bidimirror.h.
32413314 3558
9fd8be00
EZ
3559 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3560 coordinates of the iterator when restoring from ppos_it.
3561 (Bug#9296)
3562
5cf2b69b
KH
35632011-08-14 Kenichi Handa <handa@m17n.org>
3564
3565 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3566 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3567
daf17d00
EZ
35682011-08-14 Eli Zaretskii <eliz@gnu.org>
3569
3570 * xdisp.c (move_it_in_display_line_to): Don't invoke
3571 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3572 ppos_it. Fixes vertical cursor motion when line beginning is
3573 covered by an image. (Bug#9296)
3574
08e3161a
JD
35752011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3576
3577 * nsterm.h (ns_run_ascript): Declare.
3578 (NSAPP_DATA2_RUNASSCRIPT): Define.
3579
3580 * nsfns.m (as_script, as_result, as_status): New static variables.
3581 (ns_run_ascript): New function.
5e617bc2 3582 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3583 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3584 the event loop. Get status from as_status (Bug#7276).
3585
3586 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3587 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3588 the event loop (Bug#7276).
3589
a3720aa2
AS
35902011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3591
3592 * gnutls.c (QCgnutls_bootprop_priority)
3593 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3594 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3595 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3596 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3597 (QCgnutls_bootprop_verify_hostname_error)
3598 (QCgnutls_bootprop_callbacks_verify): Rename from
3599 Qgnutls_bootprop_..., all uses changed.
3600
3601 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3602 uses changed.
3603
0a0d27fb
PE
36042011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3605
19d5c50c
PE
3606 * xfaces.c (Qframe_set_background_mode): Now static.
3607 * dispextern.h (Qframe_set_background_mode): Remove decl.
3608
0a0d27fb
PE
3609 * process.c (Fnetwork_interface_info): Declare local only if needed.
3610
377538cb
JD
36112011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3612
3613 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3614 (Fnetwork_interface_list): Allocate in increments of bytes instead
3615 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3616 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3617 sockaddr.
3618 (struct ifflag_def): notrailers is smart on OSX.
3619 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3620 Get hardware address with getifaddrs if available.
3621
08fff70c
EZ
36222011-08-12 Eli Zaretskii <eliz@gnu.org>
3623
3624 * xdisp.c (iterate_out_of_display_property): xassert that
3625 IT->position is set to within IT->object's boundaries. Break from
3626 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3627 when IT->position is set up wrongly due to some bug.
3628 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3629 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3630 entry. Force push_it to save on the stack the current
3631 buffer/string position, to be restored by pop_it. Fix flags in
3632 the iterator structure wrt the object coming from a display
3633 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3634 properties. (Bug#9284)
3635
7be1c708 36362011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3637
7be1c708
CY
3638 * fontset.c (fontset_get_font_group): Add proper type checks.
3639 (Bug#9172)
aac0c6e3 3640
7be1c708 36412011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3642
7be1c708
CY
3643 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3644 and LC_VERSION_MIN_MACOSX.
3645 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3646 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3647
97bb72a6
EZ
36482011-08-08 Eli Zaretskii <eliz@gnu.org>
3649
3650 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3651 no-display-properties-and-no-overlays under bidi display.
3652 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3653 properties and overlays.
97bb72a6 3654
d5617611
CY
36552011-08-08 Chong Yidong <cyd@stupidchicken.com>
3656
37e11a63
CY
3657 * editfns.c (Fset_time_zone_rule): Document relationship with the
3658 setenv function.
3659
d5617611
CY
3660 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3661 the font entity extracted from the cache (Bug#8109).
3662
58872834
CY
36632011-08-07 Chong Yidong <cyd@stupidchicken.com>
3664
3665 * composite.c (autocmp_chars): Don't reset point. That is done by
3666 restore_point_unwind (Bug#5984).
3667
75bfc667
JL
36682011-08-07 Juri Linkov <juri@jurta.org>
3669
3670 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3671 to show the arg `TIME' instead of `TIMEVAL'.
3672
d1410150
EZ
36732011-08-06 Eli Zaretskii <eliz@gnu.org>
3674
3675 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3676 display property strides EOL and includes a newline, as in
3677 longlines-mode. (Bug#9254)
75b771e4
EZ
3678 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3679 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3680
3681 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3682 is non-zero, even if the data buffer is NULL. Fixes a crash in
3683 vertical-motion with longlines-mode. (Bug#9254)
3684
35928349
EZ
36852011-08-05 Eli Zaretskii <eliz@gnu.org>
3686
ec7cc85b
EZ
3687 * bidi.c <bidi_cache_total_alloc>: Now static.
3688 (bidi_initialize): Initialize bidi_cache_total_alloc.
3689
8b76d6f8 3690 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3691 cache. (Bug#9221)
3692
3693 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3694 amount allocated this far in `bidi_cache_total_alloc'.
3695 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3696 non-zero, only free the data buffer without restoring the cache
3697 contents. All callers changed.
3698
3699 * dispextern.h (bidi_unshelve_cache): Update prototype.
3700
3701 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3702 (move_it_in_display_line, move_it_to)
3703 (move_it_vertically_backward, move_it_by_lines): Replace the call
3704 to xfree to an equivalent call to bidi_unshelve_cache.
3705 (move_it_in_display_line_to): Fix logic of returning
412b6358 3706 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3707
e2e2423b
EZ
37082011-08-05 Eli Zaretskii <eliz@gnu.org>
3709
3710 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3711 came from a string character with a `cursor' property. (Bug#9229)
3712
ae9e757a
JD
37132011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3714
3715 * Makefile.in (LIB_PTHREAD): New variable.
3716 (LIBES): Add LIB_PTHREAD (Bug#9216).
3717
3718 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3719 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3720
213bd7f2
AS
37212011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3722
6b02f655 3723 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3724
99aaf75f
JD
37252011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3726
3727 * xterm.c (x_find_topmost_parent): New function.
3728 (x_set_frame_alpha): Find topmost parent window with
3729 x_find_topmost_parent and set the property there also (bug#9181).
3730 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3731
c74e9d86
PE
37322011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3733
3734 * callproc.c (Fcall_process): Avoid vfork clobbering
3735 the local vars buffer, coding_systems, current_dir.
3736
640c8776
SM
37372011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3738
3739 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3740
f26d0e4c
PE
37412011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3742
8a10d76c
PE
3743 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3744 so that it is not optimized away.
3745
f26d0e4c
PE
3746 * xdisp.c (compute_display_string_pos): Remove unused local.
3747
55439c61
EZ
37482011-08-02 Eli Zaretskii <eliz@gnu.org>
3749
3750 Fix slow cursor motion and scrolling in large buffers with
3751 selective display, like Org Mode buffers. (Bug#9218)
3752
3753 * dispextern.h (struct bidi_it): New member disp_prop_p.
3754
3755 * xdisp.c: Remove one-slot cache of display string positions.
3756 (compute_display_string_pos): Accept an additional argument
5e617bc2 3757 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3758 for a display string or property. If found, set DISP_PROP_P
3759 non-zero.
3760
3761 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3762 DISP_PROP_P, and pass it to compute_display_string_pos.
3763 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3764 non-zero. All callers of bidi_fetch_char changed.
3765
fb33fa43
SM
37662011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3767
3768 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3769
b099e063
DM
37702010-12-03 Don March <don@ohspite.net>
3771
3772 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3773 last character M-[char] is translated to ESC [char] (bug#7541).
3774
5cc7f7af
KH
37752011-08-02 Kenichi Handa <handa@m17n.org>
3776
d0fffa3f 3777 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3778
3779 * chartab.c (uniprop_table): Make it non-static.
3780
525d5e6e
EZ
37812011-08-01 Eli Zaretskii <eliz@gnu.org>
3782
3783 * xdisp.c (forward_to_next_line_start): Accept additional argument
3784 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3785 on the newline.
3786 (reseat_at_next_visible_line_start): Use the bidi iterator state
3787 returned by forward_to_next_line_start to restore the state of
3788 it->bidi_it after backing up to previous newline. (Bug#9212)
3789
31011111
AS
37902011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3791
3792 * regex.c (re_comp): Protoize.
3793 (re_exec): Fix return type.
3794 (regexec): Fix type of `ret'. (Bug#9203)
3795
476371c4
PE
37962011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3797
e5d76069
PE
3798 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3799 This is needed if max-image-size is a floating-point number.
3800
9a79b20c
AS
38012011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3802
3803 * print.c (print_object): Print empty symbol as ##.
3804
3805 * lread.c (read1): Read ## as empty symbol.
3806
d8c2fa78
AA
38072011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3808
3809 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3810 setting frame foreground color (Bug#9175).
3811 (x_set_background_color): Likewise.
3812
ffe57a7a
AA
3813 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3814 contents (Bug#9176).
3815 (EmacsTooltip -init): Remove bezels and add shadows to
3816 tooltip windows.
3817
bf3492a5
AA
3818 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3819 or scroll bar (Bug#8470).
3820
d55e9c53
AA
3821 * nsfont.m (nsfont_open): Remove assignment to voffset and
3822 unnecessary vars hshink, expand, hd, full_height, min_height.
3823 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3824
3825 * nsterm.h (nsfont_info): Remove voffset field.
3826
d8c2fa78 38272011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3828
3829 Implement strike-through and overline on NextStep (Bug#8863).
3830
3831 * nsfont.m (nsfont_open): Use underline position provided by font,
3832 instead of hard-coded value of 2.
3833 (nsfont_draw): Call ns_draw_text_decoration instead.
3834
3835 * nsterm.h: Add declaration for ns_draw_text_decoration.
3836
3837 * nsterm.m (ns_draw_text_decoration): New function for drawing
3838 underline, overline, and strike-through.
3839 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3840 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3841 accommodate underlining, etc.
4843aac3 3842
4cc60b9b
EZ
38432011-07-28 Eli Zaretskii <eliz@gnu.org>
3844
bc7ece87
EZ
3845 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3846 default.
4cc60b9b 3847
476371c4
PE
38482011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3849
66606eea
PE
3850 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3851 Without this fix, if a signal arrives just after memory fills up,
3852 'malloc' might be invoked reentrantly.
3853
476371c4
PE
3854 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3855 In other words, assume that every image size is allowed, on non-X
3856 hosts. This assumption is probably wrong, but it lets Emacs compile.
3857
f3fcc40d
AS
38582011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3859
3860 * regex.c (re_iswctype): Convert return values to boolean.
3861
350c992f
EZ
38622011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3863
3864 * xdisp.c (compute_display_string_pos): Don't use cached display
3865 string position if the buffer had its restriction changed.
3866 (Bug#9184)
3867
5266b4bb
PE
38682011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3869
3870 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3871
2573a837 38722011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3873
41f55ccd 3874 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3875
39e378da
PE
3876 * bidi.c: Integer size and overflow fixes.
3877 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3878 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3879 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3880 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3881 (bidi_find_other_level_edge):
3882 Use ptrdiff_t instead of EMACS_INT where either will do.
3883 This works better on 32-bit hosts configured --with-wide-int.
3884 (bidi_cache_ensure_space): Check for size-calculation overflow.
3885 Use % rather than repeated addition, for better worst-case speed.
3886 Don't set bidi_cache_size until after xrealloc returns, because it
3887 might not return.
3888 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3889 (bidi_cache_ensure_space): Also check that the bidi cache size
3890 does not exceed that of the largest Lisp string or buffer. See Eli
3891 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3892
5e927815
PE
3893 * alloc.c (__malloc_size_t): Remove.
3894 All uses replaced by size_t. See Andreas Schwab's note
3895 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3896
ca4aa935
PE
3897 * image.c: Improve checking for integer overflow.
3898 (check_image_size): Assume that f is nonnull, since
3899 it is always nonnull in practice. This is one less thing to
3900 worry about when checking for integer overflow later.
3901 (x_check_image_size): New function, which checks for integer
3902 overflow issues inside X.
3903 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3904 This removes the need for a memory_full check.
3905 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3906 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3907 (xbm_read_bitmap_data): Change locals back to 'int', since
3908 their values must fit in 'int'.
3909 (xpm_load_image, png_load, tiff_load):
3910 Invoke x_create_x_image_and_pixmap earlier,
3911 to avoid much needless work if the image is too large.
3912 (tiff_load): Treat overly large images as if
3913 x_create_x_image_and_pixmap failed, not as malloc failures.
3914 (gs_load): Use x_check_image_size.
3915
5f8f9cc2
PE
3916 * gtkutil.c: Omit integer casts.
3917 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3918 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3919
5adf60bc
PE
3920 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3921
c8907a93
PE
3922 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3923 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3924 would wrongly return t on a 64-bit host.
3925
e3c25c68
PE
3926 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3927 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3928 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3929 and therefore cause GCC to emit a bogus diagnostic in some cases.
3930
3f791afe
PE
3931 * image.c: Integer signedness and overflow and related fixes.
3932 This is not an exhaustive set of fixes, but it's time to
3933 record what I've got.
3934 (lookup_pixel_color, check_image_size): Remove redundant decls.
3935 (check_image_size): Don't assume that arbitrary EMACS_INT values
3936 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3937 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3938 (tiff_load, imagemagick_load_image):
3939 Check for overflow in size calculations.
3940 (x_create_x_image_and_pixmap): Remove unnecessary test for
3941 xmalloc returning NULL; that can't happen.
3942 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3943 (xpm_color_bucket): Use better integer hashing function.
3944 (xpm_cache_color): Don't possibly over-allocate memory.
3945 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3946 (gif_memory_source):
3947 Use ptrdiff_t, not int or size_t, to record sizes.
3948 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3949 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3950 either works, as we prefer signed integers.
3951 (tiff_read_from_memory, tiff_write_from_memory):
3952 Return tsize_t, not size_t, since that's what the TIFF API wants.
3953 (tiff_read_from_memory): Don't fail simply because the read would
3954 go past EOF; instead, return a short read.
3955 (tiff_load): Omit no-longer-needed casts.
3956 (Fimagemagick_types): Don't assume size fits into 'int'.
3957
3cc5a532
PE
3958 Improve hashing quality when configured --with-wide-int.
3959 * fns.c (hash_string): New function, taken from sxhash_string.
3960 Do not discard information about ASCII character case; this
3961 discarding is no longer needed.
3962 (sxhash-string): Use it. Change sig to match it. Caller changed.
3963 * lisp.h: Declare it.
3964 * lread.c (hash_string): Remove, since we now use fns.c's version.
3965 The fns.c version returns a wider integer if --with-wide-int is
3966 specified, so this should help the quality of the hashing a bit.
3967
b312a492
PE
3968 * emacs.c: Integer overflow minor fix.
3969 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3970 Define only if GNU_LINUX.
3971 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3972
dfd153ae
PE
3973 * dispnew.c: Integer signedness and overflow fixes.
3974 Remove unnecessary forward decls, that were a maintenance hassle.
3975 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3976 All uses changed.
3977 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3978 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3979 (prepare_desired_row, line_draw_cost):
3980 Use int, not unsigned, where either works.
3981 (save_current_matrix, restore_current_matrix):
3982 Use ptrdiff_t, not size_t, where either works.
3983 (init_display): Check for overflow more accurately, and without
3984 relying on undefined behavior.
3985
a81d11a3
PE
3986 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3987 Remove, replacing with the new symbols in lisp.h. All uses changed.
3988 * fileio.c (make_temp_name):
3989 * filelock.c (lock_file_1, lock_file):
3990 * xdisp.c (message_dolog):
3991 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3992 Use pMd etc. instead.
3993 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3994 replacing the pWIDE etc. symbols removed from editfns.c.
3995
3300e6fd
PE
3996 * keyboard.h (num_input_events): Now uintmax_t.
3997 This is (very slightly) less likely to mess up due to wraparound.
3998 All uses changed.
3999
fd05c7e9
PE
4000 * buffer.c: Integer signedness fixes.
4001 (alloc_buffer_text, enlarge_buffer_text):
4002 Use ptrdiff_t rather than size_t when either will do, as we prefer
4003 signed integers.
4004
903fe15d
PE
4005 * alloc.c: Integer signedness and overflow fixes.
4006 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
4007 (__malloc_size_t): Default to size_t, not to int.
4008 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
4009 (Fgarbage_collect, mark_object_loop_halt, mark_object):
4010 Prefer ptrdiff_t to size_t when either would do, as we prefer
4011 signed integers.
4012 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
4013 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
4014 Now const. Initialize with values that are in range even if char
4015 is signed.
4016 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
4017 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
4018 These functions do the right thing with sizes > 2**32.
4019 (check_depth): Now ptrdiff_t, not int.
4020 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
4021 Adjust to new way of storing sizes. Check for size overflow bugs
4022 in rest of code.
4023 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
4024 slightly wrong anyway, as it missed one instance of
4025 XMALLOC_OVERRUN_CHECK_OVERHEAD.
4026 (refill_memory_reserve): Omit needless cast to size_t.
4027 (mark_object_loop_halt): Mark as externally visible.
4028
ac82cc6a
PE
4029 * xselect.c: Integer signedness and overflow fixes.
4030 (Fx_register_dnd_atom, x_handle_dnd_message):
4031 Use ptrdiff_t, not size_t, since we prefer signed.
4032 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
4033 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
4034 x_dnd_atoms_size and x_dnd_atoms_length.
4035
c2d1e36d
PE
4036 * doprnt.c: Prefer signed to unsigned when either works.
4037 * eval.c (verror):
4038 * doprnt.c (doprnt):
4039 * lisp.h (doprnt):
4040 * xdisp.c (vmessage):
4041 Use ptrdiff_t, not size_t, when using or implementing doprnt,
4042 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
4043 prefer signed arithmetic to avoid comparison confusion.
4044 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
4045 but is a bit tricky.
4046
0e926e56
PE
4047 Assume freestanding C89 headers, string.h, stdlib.h.
4048 * data.c, doprnt.c, floatfns.c, print.c:
4049 Include float.h unconditionally.
4050 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
4051 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
4052 * regex.c: Likewise for stddef.h, string.h.
4053 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
4054 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
4055 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
4056 (STDC_HEADERS): Remove obsolete defines.
4057 * sysdep.c: Include limits.h unconditionally.
4058
9cfdb3ec
PE
4059 Assume support for memcmp, memcpy, memmove, memset.
4060 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
4061 * regex.c (memcmp, memcpy):
4062 Remove; we assume C89 now.
4063
4064 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
4065 (__malloc_safe_bcopy): Remove; no longer needed.
4066
cf950e6b 4067 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
4068 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
4069 well either way, and we prefer signed to unsigned.
4070
dbf38e02
LMI
40712011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
4072
4073 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
4074 closes the connection while we're reading (bug#9182).
4075
d6f0886c 40762011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 4077
d6f0886c
JD
4078 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4079 are specified (Bug#9168).
24e0f6b1 4080
2eb1f9e6
PE
40812011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4082
4083 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4084 Found by GCC static checking and --with-wide-int on a 32-bit host.
4085
22381272 40862011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
4087
4088 * xdisp.c (compute_display_string_pos): Fix logic of caching
4089 previous display string position. Initialize cached_prev_pos to
4090 -1. Fixes slow-down at the beginning of a buffer.
4091
f25e39b4
EZ
40922011-07-24 Eli Zaretskii <eliz@gnu.org>
4093
4094 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4095 for attrs[LFACE_FONTSET_INDEX].
4096
04c4b52e
PE
40972011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4098
4099 * xml.c (parse_region): Remove unused local
4100 that was recently introduced.
4101
c1734fbd
EZ
41022011-07-23 Eli Zaretskii <eliz@gnu.org>
4103
be18c5a5
EZ
4104 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4105 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4106
c1734fbd
EZ
4107 * xdisp.c (move_it_in_display_line_to): Record the best matching
4108 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
4109 exit if none of the characters scanned was an exact match.
4110 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
4111 when exact match is impossible due to invisible text, and the
4112 lines are truncated.
4113
a258d627
JD
41142011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4115
4116 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4117 for OSX >= 10.7.
4118
b6d5a689
EZ
41192011-07-22 Eli Zaretskii <eliz@gnu.org>
4120
0f74f785
EZ
4121 Fix a significant slow-down of cursor motion with C-n, C-p,
4122 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4123 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 4124 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
4125 (next_element_from_buffer): Call compute_stop_pos_backwards to
4126 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
4127 base_level_stop.
4128 (reseat): Don't look for prev_stop, as that could mean a very long
4129 run.
4130 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4131 <cached_disp_overlay_modiff>: Cache for last found display string
4132 position.
551918c1 4133 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
4134 about the same buffer in the same area of character positions, and
4135 the buffer wasn't changed since the time the display string
4136 position was cached.
551918c1 4137
b2d0c91a
EZ
41382011-07-22 Eli Zaretskii <eliz@gnu.org>
4139
4140 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4141 is an integer, which is important for empty lines. (Bug#9149)
4142
043604ee
CY
41432011-07-22 Chong Yidong <cyd@stupidchicken.com>
4144
4145 * frame.c (Fmodify_frame_parameters): In tty case, update the
4146 default face if necessary (Bug#4238).
4147
da4adb04
CY
41482011-07-21 Chong Yidong <cyd@stupidchicken.com>
4149
4150 * editfns.c (Fstring_to_char): No need to explain what a character
4151 is in the docstring (Bug#6576).
4152
9abd0532
LMI
41532011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4154
4155 * xml.c (parse_region): Make sure we always return a tree.
4156
36881d16
HK
41572011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4158
4159 * xml.c (parse_region): If a document contains only comments,
4160 return that, too.
4161
1e98674d
LMI
41622011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4163
4164 * xml.c (make_dom): Return comments, too.
4165
590bd467
PE
41662011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4167
4168 Port to OpenBSD.
4169 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4170 and the surrounding thread.
4171 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4172 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4173 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4174 timer goes off.
4175 * s/openbsd.h (BROKEN_SIGIO): Define.
4176 * unexelf.c (unexec) [__OpenBSD__]:
4177 Don't update the .mdebug section of the Alpha COFF symbol table.
4178
f41628b2
LMI
41792011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4180
4181 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4182 (bug#8460).
4183
b59b67c5
PE
41842011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4185
15e3a074
PE
4186 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4187 This fixes some race conditions on the permissions of any newly
4188 created file.
4189
41bed37d
PE
4190 * alloc.c (valid_pointer_p): Use pipe, not open.
4191 This fixes some permissions issues when debugging.
4192
b59b67c5
PE
4193 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4194 If fchown fails to set both uid and gid, try to set just gid,
4195 as that is sometimes allowed. Adjust the file's mode to eliminate
4196 setuid or setgid bits that are inappropriate if fchown fails.
4197
925a6be7
SM
41982011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4199
4200 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4201 to compare Lisp_Objects.
4202 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4203 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4204 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4205
52968808
AS
42062011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4207
0a6a104b
AS
4208 * lread.c (read_integer): Unread even EOF character.
4209 (read1): Likewise. Properly record start position of symbol.
4210
52968808
AS
4211 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4212 symbol character follows.
4213
9e381cdd
PE
42142011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4215
4216 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4217 This works around a problem with the previous change to Fcopy_file.
4218 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4219 and without this change, GCC might complain about discarding
4220 fchown's return value.
4221
b5641435
JB
42222011-07-16 Juanma Barranquero <lekktu@gmail.com>
4223
4224 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4225
a8031457
PE
42262011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4227
4228 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4229
dd889327
LMI
42302011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4231
750c33f7
LMI
4232 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4233 it's used from the C level.
4234
dd889327
LMI
4235 * process.c: Use the same condition for POLL_FOR_INPUT in both
4236 keyboard.c and process.c (bug#1858).
4237
87e86684
LM
42382011-07-09 Lawrence Mitchell <wence@gmx.li>
4239
4240 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4241 (Fgnutls_boot): Use it.
4242
64348f40
AS
42432011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4244
4245 * doc.c (Fsubstitute_command_keys): Revert last change.
4246
1d698799
LMI
42472011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4248
f863868c
LMI
4249 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4250 quotes the next character, and doesn't affect other longer
4251 sequences (bug#8935).
4252
1d698799
LMI
4253 * lread.c (syms_of_lread): Clarify that is isn't only
4254 `eval-buffer' and `eval-defun' that's affected by
4255 `lexical-binding' (bug#8460).
4256
aa4b6df6
EZ
42572011-07-15 Eli Zaretskii <eliz@gnu.org>
4258
4259 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 4260 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 4261
5d856da6
PE
42622011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4263
ad6042bb
PE
4264 Fix minor problems found by static checking.
4265 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4266 (elsz): Now a signed constant, not a size_t var. We prefer signed
4267 types to unsigned, to avoid integer comparison confusion. Without
4268 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4269 "cannot optimize loop, the loop counter may overflow", a symptom
4270 of the confusion.
f00bbb22 4271 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
4272 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4273
6468f31c
LMI
42742011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4275
49080b10
LMI
4276 * search.c (Fre_search_backward): Mention `case-fold-search' in
4277 all the re_search_* functions (bug#8138).
4278
6468f31c
LMI
4279 * keyboard.c (Fopen_dribble_file): Document when the file is
4280 closed (bug#8056).
4281
c965adc5
EZ
42822011-07-14 Eli Zaretskii <eliz@gnu.org>
4283
df9733bf
EZ
4284 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4285 bidi_cache_idx.
4286
0bb23927
EZ
4287 Support bidi reordering of display and overlay strings.
4288 * xdisp.c (compute_display_string_pos)
4289 (compute_display_string_end): Accept additional argument STRING.
4290 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4291 (reseat_to_string): Initialize bidi_it->string.s and
4292 bidi_it->string.schars.
4293 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
4294 NULL (avoids a crash in bidi_paragraph_init).
4295 Initialize itb.string.lstring.
0bb23927
EZ
4296 (init_iterator): Call bidi_init_it only of a valid
4297 buffer position was specified. Initialize paragraph_embedding to
4298 L2R.
4299 (reseat_to_string): Initialize the bidi iterator.
4300 (display_string): If we need to ignore text properties of
4301 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4302 original value of -1 will not work with bidi.)
4303 (compute_display_string_pos): First arg is now struct
4304 `text_pos *'; all callers changed. Support display properties on
4305 Lisp strings.
4306 (compute_display_string_end): Support display properties on Lisp
4307 strings.
4308 (init_iterator, reseat_1, reseat_to_string): Initialize the
4309 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4310 when iterating on a string not from display properties).
640c8776
SM
4311 (compute_display_string_pos, compute_display_string_end):
4312 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
4313 arrow keys.
4314 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
4315 base_level_stop; instead, set base_level_stop to BEGV.
4316 Fixes crashes in vertical-motion.
0bb23927
EZ
4317 (next_element_from_buffer): Improve commentary for when
4318 the iterator is before prev_stop.
4319 (init_iterator): Initialize bidi_p from the default value of
4320 bidi-display-reordering, not from buffer-local value. Use the
4321 buffer-local value only if initializing for buffer iteration.
4322 (handle_invisible_prop): Support invisible properties on strings
4323 that are being bidi-reordered.
4324 (set_iterator_to_next): Support bidi reordering of C strings and
4325 Lisp strings.
4326 (next_element_from_string): Support bidi reordering of Lisp
4327 strings.
4328 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
4329 (display_string): Support display of R2L glyph rows.
4330 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
4331 (init_iterator): Don't initialize it->bidi_p for strings
4332 here.
4333 (reseat_to_string): Initialize it->bidi_p for strings here.
4334 (next_element_from_string, next_element_from_c_string)
4335 (next_element_from_buffer): Add xassert's for correspondence
4336 between IT's object being iterated and it->bidi_it.string
4337 structure.
4338 (face_before_or_after_it_pos): Support bidi iteration.
4339 (next_element_from_c_string): Handle the case of the first string
4340 character that is not the first one in the visual order.
4341 (get_visually_first_element): New function, refactored from common
4342 parts of next_element_from_buffer, next_element_from_string, and
4343 next_element_from_c_string.
4344 (tool_bar_lines_needed, redisplay_tool_bar)
4345 (display_menu_bar): Force left-to-right direction. Add a FIXME
4346 comment for making that be controlled by a user option.
4347 (push_it, pop_it): Save and restore the state of the
4348 bidi iterator. Save and restore the bidi_p flag.
4349 (pop_it): Iterate out of display property for string iteration as
4350 well.
4351 (iterate_out_of_display_property): Support iteration over strings.
4352 (handle_single_display_spec): Set up it->bidi_it for iteration
4353 over a display string, and call bidi_init_it.
4354 (handle_single_display_spec, next_overlay_string)
4355 (get_overlay_strings_1, push_display_prop): Set up the bidi
4356 iterator for displaying display or overlay strings.
4357 (forward_to_next_line_start): Don't use the shortcut if
4358 bidi-iterating.
4359 (back_to_previous_visible_line_start): If handle_display_prop
4360 pushed the iterator stack, restore the internal state of the bidi
4361 iterator by calling bidi_pop_it same number of times.
4362 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4363 and we are bidi-iterating, don't decrement the iterator position;
4364 instead, set the first_elt flag in the bidi iterator, to produce
4365 the same effect.
4366 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4367 (push_display_prop): xassert that we are iterating a buffer.
4368 (push_it, pop_it): Save and restore paragraph_embedding member.
4369 (handle_single_display_spec, next_overlay_string)
4370 (get_overlay_strings_1, reseat_1, reseat_to_string)
4371 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4372 correctly. Don't assume unibyte strings are not bidi-reordered.
4373 (compute_display_string_pos)
4374 (compute_display_string_end): Fix handling the case of C string.
4375 (push_it, pop_it): Save and restore from_disp_prop_p.
4376 (handle_single_display_spec, push_display_prop): Set the
4377 from_disp_prop_p flag.
4378 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4379 (pop_it): Call iterate_out_of_display_property only if we are
4380 popping after iteration over a string that came from a display
4381 property. Fix a typo in popping stretch info. Add an assertion
4382 for verifying that the iterator position is in sync with the bidi
4383 iterator.
4384 (handle_single_display_spec, get_overlay_strings_1)
4385 (push_display_prop): Fix initialization of paragraph direction for
4386 string when that of the parent object is not yet determined.
4387 (reseat_1): Call bidi_init_it to resync the bidi
4388 iterator with IT's position. (Bug#7616)
4389 (find_row_edges): If ROW->start.pos gives position
4390 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4391 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4392 Reset the from_disp_prop_p flag.
4393 (SAVE_IT, RESTORE_IT): New macros.
4394 (pos_visible_p, face_before_or_after_it_pos)
4395 (back_to_previous_visible_line_start)
4396 (move_it_in_display_line_to, move_it_in_display_line)
4397 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4398 (try_scrolling, redisplay_window, display_line): Use them when
4399 saving a temporary copy of the iterator and restoring it back.
4400 (back_to_previous_visible_line_start, reseat_1)
4401 (init_iterator): Empty the bidi cache "stack".
4402 (move_it_in_display_line_to): If iterator ended up at
4403 EOL, but we never saw any buffer positions smaller than
4404 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4405 motion in bidi-reordered lines.
4406 (move_it_in_display_line_to): Record prev_method and prev_pos
4407 immediately before the call to set_iterator_to_next. Fixes cursor
4408 motion in bidi-reordered lines with stretch glyphs and strings
4409 displayed in margins. (Bug#8133) (Bug#8867)
4410 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4411 TO_CHARPOS.
640c8776
SM
4412 (pos_visible_p): Support positions in bidi-reordered lines.
4413 Save and restore bidi cache.
0bb23927
EZ
4414
4415 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4416 (bidi_paragraph_info): Delete unused struct.
4417 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4418 (bidi_cache_start): New variable.
4419 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4420 to zero.
4421 (bidi_cache_fetch_state, bidi_cache_search)
4422 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4423 (bidi_cache_find, bidi_peek_at_next_level)
4424 (bidi_level_of_next_char, bidi_find_other_level_edge)
4425 (bidi_move_to_visually_next): Compare cache index with
4426 bidi_cache_start rather than with zero.
4427 (bidi_fetch_char): Accept new argument STRING; all callers
4428 changed. Support iteration over a string. Support strings with
4429 display properties. Support unibyte strings. Fix the type of
4430 `len' according to what STRING_CHAR_AND_LENGTH expects.
4431 (bidi_paragraph_init, bidi_resolve_explicit_1)
4432 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4433 (bidi_level_of_next_char, bidi_move_to_visually_next):
4434 Support iteration over a string.
0bb23927
EZ
4435 (bidi_set_sor_type, bidi_resolve_explicit_1)
4436 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4437 can now be zero (for strings); special values 0 and -1 were
4438 changed to -1 and -2, respectively.
4439 (bidi_char_at_pos): New function.
4440 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4441 Call it instead of FETCH_MULTIBYTE_CHAR.
4442 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4443 initialized to valid values.
4444 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4445 values.
4446 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4447 the test for valid cached positions. Fix the logic for looking up
4448 the sentinel state in the cache. GCPRO the Lisp string we are
4449 iterating.
4450 (bidi_push_it, bidi_pop_it): New functions.
4451 (bidi_initialize): Initialize the bidi cache start stack pointer.
4452 (bidi_cache_ensure_space): New function, refactored from part of
4453 bidi_cache_iterator_state. Don't assume the required size is just
4454 one BIDI_CACHE_CHUNK away.
4455 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4456 (bidi_count_bytes, bidi_char_at_pos): New functions.
4457 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4458 always valid if bidi_cache_idx is valid.
4459 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4460 is valid if it's going to be used.
4461 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4462 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4463 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4464 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4465 (bidi_find_other_level_edge, bidi_cache_start_stack):
4466 All variables related to cache indices are now EMACS_INT.
c965adc5 4467
0bb23927
EZ
4468 * dispextern.h (struct bidi_string_data): New structure.
4469 (struct bidi_it): New member `string'. Make flag members be 1-bit
4470 fields, and put them last in the struct.
640c8776
SM
4471 (compute_display_string_pos, compute_display_string_end):
4472 Update prototypes.
0bb23927
EZ
4473 (bidi_push_it, bidi_pop_it): Add prototypes.
4474 (struct iterator_stack_entry): New members bidi_p,
4475 paragraph_embedding, and from_disp_prop_p.
4476 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4477 (bidi_shelve_cache, bidi_unshelve_cache):
4478 Declare prototypes.
0bb23927
EZ
4479
4480 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4481 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4482 and vector-like objects.
4483
4484 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4485 cache around display iteration.
4486
4487 * window.c (Fwindow_end, window_scroll_pixel_based)
4488 (displayed_window_lines, Frecenter): Save and restore the bidi
4489 cache around display iteration.
4490
3bbd2265
LMI
44912011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4492
4493 * editfns.c (Fdelete_region): Clarify the use of the named
4494 parameters (bug#6788).
4495
adc47434
MR
44962011-07-14 Martin Rudalics <rudalics@gmx.at>
4497
4498 * indent.c (Fvertical_motion): Set and restore w->pointm when
4499 saving and restoring the window's buffer (Bug#9006).
4500
837c31f8
LMI
45012011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4502
4503 * editfns.c (Fstring_to_char): Clarify just what is returned
4504 (bug#6576). Text by Eli Zaretskii.
4505
ac389d0c
JB
45062011-07-13 Juanma Barranquero <lekktu@gmail.com>
4507
4508 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4509
0be0ce47
EZ
45102011-07-13 Eli Zaretskii <eliz@gnu.org>
4511
4512 * buffer.c (mmap_find): Fix a typo.
4513
cd18e7e3
JB
45142011-07-13 Johan Bockgård <bojohan@gnu.org>
4515
4516 Fix execution of x selection hooks.
4517 * xselect.c (Qx_lost_selection_functions)
4518 (Qx_sent_selection_functions): New vars.
4519 (syms_of_xselect): DEFSYM them.
4520 (x_handle_selection_request): Pass Qx_sent_selection_functions
4521 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4522 (x_handle_selection_clear,x_clear_frame_selections):
4523 Pass Qx_lost_selection_functions rather than
4524 Vx_lost_selection_functions to Frun_hook_with_args.
4525
47ea7f44
PE
45262011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4527
ac389d0c 4528 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4529 The old code sometimes used this field without initializing it.
4530
47ea7f44
PE
4531 * alloc.c (gc_sweep): Don't read past end of array.
4532 In theory, the old code could also have corrupted Emacs internals,
4533 though it'd be very unlikely.
4534
bc985c87
AS
45352011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4536
4537 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4538 argument. (Bug#4026)
bc985c87 4539
0cf34688
LMI
45402011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4541
b3dadd76
LMI
4542 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4543 key" (bug#4257).
4544
0cf34688
LMI
4545 * window.c (Fset_window_start): Doc fix (bug#4199).
4546 (Fset_window_hscroll): Ditto.
4547
270768cd
PE
45482011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4549
077e3dda 4550 Fix minor new problems caught by GCC 4.6.1.
270768cd 4551 * term.c (init_tty): Remove unused local.
490011a6 4552 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4553 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4554 not used otherwise.
270768cd 4555
b1f58454
CY
45562011-07-12 Chong Yidong <cyd@stupidchicken.com>
4557
4558 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4559
22b9578d
LMI
45602011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4561
6e70ab07
LMI
4562 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4563 are the mini-buffer and the echo area (bug#3320).
4564
22b9578d
LMI
4565 * term.c (init_tty): Remove support for supdup, c10 and perq
4566 terminals, which are no longer supported (bug#1482).
4567
8974cc9f
JB
45682011-07-10 Johan Bockgård <bojohan@gnu.org>
4569
4570 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4571
a560d974
JD
45722011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4573
4574 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4575 for non-popups (Bug#3642).
4576
1dae0f0a
AS
45772011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4578
268c2c36 4579 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4580 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4581 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4582 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4583 * data.c (fmod): Likewise.
4584 * dispnew.c (swap_glyphs_in_rows): Likewise.
4585 * emacs.c (memory_warning_signal): Likewise.
4586 * floatfns.c (float_error): Likewise.
4587 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4588 (otf_open, font_otf_capability, generate_otf_features)
4589 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4590 Likewise.
4591 * image.c (pbm_read_file): Likewise.
4592 * indent.c (string_display_width): Likewise.
4593 * intervals.c (check_for_interval, search_for_interval)
4594 (inc_interval_count, count_intervals, root_interval)
4595 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4596 * lread.c (defalias): Likewise.
268c2c36 4597 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4598 * regex.c (set_image_of_range_1, set_image_of_range)
4599 (regex_grow_registers): Likewise.
4600 * sysdep.c (strerror): Likewise.
4601 * termcap.c (valid_filename_p, tprint, main): Likewise.
4602 * tparam.c (main): Likewise.
4603 * unexhp9k800.c (run_time_remap, save_data_space)
4604 (update_file_ptrs, read_header, write_header, calculate_checksum)
4605 (copy_file, copy_rest, display_header): Likewise.
4606 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4607 Likewise.
4608 * xdisp.c (check_it): Likewise.
4609 * xfaces.c (register_color, unregister_color, unregister_colors):
4610 Likewise.
4611 * xfns.c (print_fontset_result): Likewise.
4612 * xrdb.c (member, fatal, main): Likewise.
4613
99033785
PE
46142011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4615
4616 Fix minor problems found by static checking (Bug#9031).
4617 * chartab.c (char_table_set_range, map_sub_char_table):
4618 Remove unused locals.
4619 (uniprop_table): Now static.
4620 * composite.c (_work_char): Remove unused static var.
4621
9cb2ac56
JB
46222011-07-09 Juanma Barranquero <lekktu@gmail.com>
4623
4624 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4625
f25661f0
JD
46262011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4627
4628 * gtkutil.c (qttip_cb): Remove code without function.
4629
8278c4fe
EZ
46302011-07-09 Eli Zaretskii <eliz@gnu.org>
4631
4632 * w32.c (pthread_sigmask): New stub.
4633
1692ae2d 46342011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4635
8a6ebd58 4636 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4637 sigprocmask is portable only for single-threaded applications, and
4638 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4639 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4640 (LIBES): Use it.
4641 * callproc.c (Fcall_process):
4642 * process.c (create_process):
4643 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4644 Use pthread_sigmask, not sigprocmask.
123403e4 4645
1b854618
JD
46462011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4647
4648 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4649 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4650 wrong (Bug#8591).
4651
3fe4b549
JD
46522011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4653
0ce7e563
JD
4654 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4655 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4656 (xg_hide_tooltip): Fix comment.
4657
3fe4b549
JD
4658 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4659 in registerServicesMenuSendTypes.
4660 (validRequestorForSendType): Don't check ns_return_types.
4661
4662 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4663 ns_return_type.
4664
5df75e47
JR
46652011-07-08 Jason Rumney <jasonr@gnu.org>
4666
22610910
JR
4667 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4668 SH_SHOW for hidden windows (Bug#5482).
4669
5df75e47
JR
4670 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4671 frame struct members of non-existent frames (Bug#6284).
4672
699c10bd
JD
46732011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4674
4393663b
JD
4675 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4676 variable firstTime not needed on OSX >= 10.6.
4677 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4678 >= 10.5. Use setKnobProportion, setDoubleValue.
4679
4680 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4681 (MAC_OS_X_VERSION_10_5): Define if not defined.
4682 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4683 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4684 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4685
4686 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4687 cString and lossyCString on OSX >= 10.4
4688
58179cce 4689 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4690 sizeToFit on OSX >= 10.2.
4691
4692 * nsimage.m (allocInitFromFile): Don't use deprecated method
4693 bestRepresentationForDevice on OSX >= 10.6.
4694
4695 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4696 to avoid warning.
4697
4698 * emacs.c: Declare unexec_init_emacs_zone.
4699
a63e0781
JD
4700 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4701
699c10bd
JD
4702 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4703
4704 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4705 on svcsMenu (Bug#8842).
4706
4707 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4708 ns_return_types.
4709 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4710
4711 * nsterm.m (QUTF8_STRING): Declare.
4712 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4713 (validRequestorForSendType): Return type is (id).
4714 Change indexOfObjectIdenticalTo to indexOfObject.
4715 Check if we have local selection before returning self (Bug#8842).
4716 (writeSelectionToPasteboard): Put local selection into paste board
4717 if we have a local selection (Bug#8842).
4718 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4719
4720 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4721 (ns_get_local_selection): Declare.
4722
54e10184
LMI
47232011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4724
9888ff71
LMI
4725 * keymap.c (describe_map_tree): Don't insert a double newline at
4726 the end of the buffer (bug#1169) and return whether we inserted
4727 something.
4728
54e10184
LMI
4729 * callint.c (Fcall_interactively): Change "reading args" to
4730 "providing args" to try to clarify what it does (bug#1010).
4731
15fa4783
KH
47322011-07-07 Kenichi Handa <handa@m17n.org>
4733
4734 * composite.c (composition_compute_stop_pos): Ignore a static
4735 composition starting before CHARPOS (Bug#8915).
4736
4737 * xdisp.c (handle_composition_prop): Likewise.
4738
a8815b00
EZ
47392011-07-07 Eli Zaretskii <eliz@gnu.org>
4740
4741 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4742 (Bug#9015)
4743
ef7b981d 47442011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4745
4746 * character.h (unicode_category_t): New enum type.
4747
4748 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4749 (Qchar_code_property_table): New variable.
4750 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4751 (UNIPROP_COMPRESSED_FORM_P): New macros.
4752 (char_table_ascii): Uncompress the compressed values.
4753 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4754 Uncompress the compressed values.
ac389d0c 4755 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4756 (char_table_ref_and_range): Uncompress the compressed values.
4757 (sub_char_table_set): New arg is_uniprop. Callers changed.
4758 Uncompress the compressed values.
4759 (sub_char_table_set_range): Args changed. Callers changed.
4760 (char_table_set_range): Adjuted for the above change.
4761 (map_sub_char_table): Delete args default_val and parent. Add arg
4762 top. Give decoded values to a Lisp function.
640c8776 4763 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4764 values to a Lisp function. Gcpro more variables.
4765 (uniprop_table_uncompress)
4766 (uniprop_decode_value_run_length): New functions.
4767 (uniprop_decoder, uniprop_decoder_count): New variables.
4768 (uniprop_get_decoder, uniprop_encode_value_character)
4769 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4770 New functions.
4771 (uniprop_encoder, uniprop_encoder_count): New variables.
4772 (uniprop_get_encoder, uniprop_table)
4773 (Funicode_property_table_internal, Fget_unicode_property_internal)
4774 (Fput_unicode_property_internal): New functions.
4775 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4776 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4777 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4778 char-code-property-alist.
4779
640c8776 4780 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4781 Vunicode_category_table.
4782
640c8776 4783 * font.c (font_range): Adjust for the change of
c805dec0
KH
4784 Vunicode_category_table.
4785
76b397fb
DN
47862011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4787
4788 * m/iris4d.h: Remove file, move contents ...
4789 * s/irix6-5.h: ... here.
4790
22b4128e
PE
47912011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4792
4793 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4794 * alloc.c (mark_buffer):
4795 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4796 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4797 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4798 This isn't true in general, and it's particularly not true
4799 if Emacs is configured with --with-wide-int.
4800 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4801 New macros, used in the buffer.c change.
4802
869795d6
JD
48032011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4804
4805 * xsettings.c: Use both GConf and GSettings if both are available.
4806 (store_config_changed_event): Add comment.
4807 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4808 (store_tool_bar_style_changed): New functions.
5e617bc2 4809 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4810 (struct xsettings): Move font inside HAVE_XFT.
4811 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4812 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4813 Move inside HAVE_XFT.
640c8776 4814 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4815 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4816 also.
4817 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4818 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4819 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4820 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4821 (parse_settings): Move check for font inside HAVE_XFT.
4822 (read_settings, apply_xft_settings): Add comment.
4823 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4824 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4825 call store_font_name_changed.
4826 (xft_settings_event): Add comment.
4827 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4828 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4829 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4830 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4831 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4832 (xsettings_get_system_font, xsettings_get_system_normal_font):
4833 Add comment.
869795d6 4834
d8ed26bd
PE
48352011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4836
4837 Random fixes. E.g., (random) never returned negative values.
4838 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4839 subseconds part to the entropy, as that's a bit more random.
4840 Prefer signed to unsigned, since the signedness doesn't matter and
4841 in general we prefer signed. When given a limit, use a
4842 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4843 latter isn't right if USE_2_TAGS_FOR_INTS.
4844 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4845 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4846
cabf1cac
SM
48472011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4848
4849 * textprop.c (text_property_stickiness):
4850 Obey Vtext_property_default_nonsticky.
4851 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4852 * w32fns.c (syms_of_w32fns):
4853 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4854
6e9b2be9
PE
48552011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4856
4857 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4858 This is more efficient than Ffile_directory_p and avoids a minor race.
4859
90186c68
LMI
48602011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4861
7c301272
LMI
4862 * buffer.c (Foverlay_put): Say what the return value is
4863 (bug#7835).
4864
c4f2d8d4
LMI
4865 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4866 is a directory before asking whether to use the file name
4867 (bug#7564).
ad637907
LMI
4868 (barf_or_query_if_file_exists): Make the "File is a directory"
4869 error be more correct.
c4f2d8d4 4870
90186c68
LMI
4871 * fns.c (Frequire): Remove the mention of the .gz files, since
4872 that's installation-specific, but keep the mention of
4873 `get-load-suffixes'.
4874
da64016e
PE
48752011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4876
4877 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4878 Report string overflow if the output is too long.
4879
7d47b580
JB
48802011-07-04 Juanma Barranquero <lekktu@gmail.com>
4881
a555cb87
JB
4882 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4883 (syms_of_gnutls): Remove duplicate DEFSYM for
4884 Qgnutls_bootprop_verify_hostname_error, an error for
4885 Qgnutls_bootprop_verify_error (which is no longer used).
4886
7d47b580
JB
4887 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4888 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4889 Also (re)move comments that are misplaced or no longer relevant.
4890
1e49bfab
LMI
48912011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4892
4893 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4894
1485f4c0
CY
48952011-07-03 Chong Yidong <cyd@stupidchicken.com>
4896
4897 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4898 and background color parameters if they have been changed.
4899
a9ab721e
LMI
49002011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4901
4902 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4903
cf7cff57
PE
49042011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4905
2e13213d
PE
4906 * xsettings.c (SYSTEM_FONT): Define only when used.
4907 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4908
cf7cff57
PE
4909 * keymap.c (access_keymap_1): Now static.
4910
7a8e04f7
CY
49112011-07-02 Chong Yidong <cyd@stupidchicken.com>
4912
4913 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4914 leave any prefix arg for the up event (Bug#1586).
4915
61352f62
LMI
49162011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4917
69bb1ef7
LMI
4918 * lread.c (syms_of_lread): Mention single symbols defined by
4919 `defvar' or `defconst' (bug#7154).
4920
61352f62 4921 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4922 (Frequire): Mention get-load-suffixes.
61352f62 4923
28545e04
MR
49242011-07-02 Martin Rudalics <rudalics@gmx.at>
4925
4926 * window.h (window): Remove clone_number slot.
4927 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4928 Remove.
4929 (make_parent_window, make_window, saved_window)
4930 (Fset_window_configuration, save_window_save): Don't deal with
4931 clone numbers.
4932 * buffer.c (Qclone_number): Remove declaration.
4933 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4934
3349e122
SM
49352011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4936
4937 Add multiple inheritance to keymaps.
4938 * keymap.c (Fmake_composed_keymap): New function.
4939 (Fset_keymap_parent): Simplify.
4940 (fix_submap_inheritance): Remove.
4941 (access_keymap_1): New function extracted from access_keymap to handle
4942 embedded parents and handle lists of maps.
4943 (access_keymap): Use it.
4944 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4945 (Fcopy_keymap): Handle embedded parents.
4946 (Fcommand_remapping, define_as_prefix): Simplify.
4947 (Fkey_binding): Simplify.
4948 (syms_of_keymap): Move minibuffer-local-completion-map,
4949 minibuffer-local-filename-completion-map,
4950 minibuffer-local-must-match-map, and
4951 minibuffer-local-filename-must-match-map to Elisp.
4952 (syms_of_keymap): Defsubr make-composed-keymap.
4953 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4954 (parse_menu_item): Trivial simplification.
4955
3279eb87
GM
49562011-07-01 Glenn Morris <rgm@gnu.org>
4957
4958 * Makefile.in (SETTINGS_LIBS): Fix typo.
4959
4550efdf
KI
49602011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4961
4962 * coding.c (Fencode_coding_string): Record the last coding system
4963 used, as the function doc string says (bug#8738).
4964
0949d2b6
JD
49652011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4966
4967 * xsettings.c (store_monospaced_changed): Take new font as arg and
4968 check for change against current_mono_font.
4969 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4970 (emacs_settings_constructor, emacs_settings_get_property)
4971 (emacs_settings_set_property, emacs_settings_class_init)
4972 (emacs_settings_init, gsettings_obj): Remove.
4973 (something_changedCB): New function for HAVE_GSETTINGS.
4974 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4975 with value as argument.
4976 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4977 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4978 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4979 "changed".
4980
4981 * xgselect.c: Add defined (HAVE_GSETTINGS).
4982 (xgselect_initialize): Ditto.
4983
4984 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4985 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4986 xg_select.
4987
bbc6b304
PE
49882011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4989
4990 * eval.c (struct backtrace): Simplify and port the data structure.
4991 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4992 signed bit field, as this assumption is not portable and it makes
4993 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4994 "char debug_on_exit : 1" as this is not portable either; instead,
4995 use the portable "unsigned int debug_on_exit : 1". Remove unused
4996 member evalargs. Remove obsolete comments about cc bombing out.
4997
9851bfc5
JD
49982011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4999
51bb811f 5000 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
5001 Let HAVE_GSETTINGS override HAVE_GCONF.
5002 (store_monospaced_changed): New function.
5003 (EMACS_SETTINGS): A new type derived from GObject to handle
5004 GSettings notifications.
5005 (emacs_settings_constructor, emacs_settings_get_property)
5006 (emacs_settings_set_property, emacs_settings_class_init):
5007 New functions.
5008 (gsettings_client, gsettings_obj): New variables.
5009 (GSETTINGS_SCHEMA): New define.
5010 (something_changedCB): Call store_monospaced_changed.
5011 (init_gsettings): New function.
5012 (xsettings_initialize): Call init_gsettings.
5013 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
5014 to NULL.
5015
640c8776 5016 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
5017 GCONF_CFLAGS/LIBS.
5018
5386012d
MR
50192011-06-29 Martin Rudalics <rudalics@gmx.at>
5020
5021 * window.c (resize_root_window, grow_mini_window)
5022 (shrink_mini_window): Rename Qresize_root_window to
5023 Qwindow_resize_root_window and Qresize_root_window_vertically to
5024 Qwindow_resize_root_window_vertically.
5025
f13e0b08
PE
50262011-06-28 Paul Eggert <eggert@cs.ucla.edu>
5027
5028 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
5029
94515237
JB
50302011-06-27 Juanma Barranquero <lekktu@gmail.com>
5031
5032 * makefile.w32-in: Redesign dependencies so they reflect more
5033 clearly which files are directly included by each source file,
5034 and not through other includes.
5035
e43b6e43
MR
50362011-06-27 Martin Rudalics <rudalics@gmx.at>
5037
5038 * buffer.c (Qclone_number): Declare static and DEFSYM it.
5039 (sort_overlays, overlay_strings): When an overlay's clone number
5040 matches the window's clone number process the overlay even if
5041 the overlay's window property doesn't match the current window.
5042
d68443dc
MR
5043 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
5044 (Fwindow_hchild): Rename to Fwindow_left_child.
5045 (Fwindow_next): Rename to Fwindow_next_sibling.
5046 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
5047 (resize_window_check): Rename to window_resize_check.
5048 (resize_window_apply): Rename to window_resize_apply.
5049 (Fresize_window_apply): Rename to Fwindow_resize_apply.
5050 (Fdelete_other_windows_internal, resize_frame_windows)
5051 (Fsplit_window_internal, Fdelete_window_internal)
5052 (grow_mini_window, shrink_mini_window)
5053 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 5054
c7e73be5
JD
50552011-06-26 Jan Djärv <jan.h.d@swipnet.se>
5056
5057 * emacsgtkfixed.h: State that this is only used with Gtk+3.
5058 (emacs_fixed_set_min_size): Remove.
5059 (emacs_fixed_new): Take frame as argument.
5060
5061 * emacsgtkfixed.c: State that this is only used with Gtk+3.
5062 (_EmacsFixedPrivate): Remove minwidth/height.
5063 Add struct frame *f.
5064 (emacs_fixed_init): Initialize priv->f.
5065 (get_parent_class, emacs_fixed_set_min_size): Remove.
5066 (emacs_fixed_new): Set priv->f to argument.
5067 (emacs_fixed_get_preferred_width)
5068 (emacs_fixed_get_preferred_height): Use min_width/height from
5069 frames size_hint to set minimum and natural (Bug#8919).
5070 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
5071 and use min_width/height from frames size_hint to set
5072 min_width/height (Bug#8919).
5073
5074 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
5075 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
5076 Fix indentation.
c7e73be5 5077
cf99dcf8
EZ
50782011-06-26 Eli Zaretskii <eliz@gnu.org>
5079
5080 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5081 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5082 called at ZV.
5083
029529ac
CY
50842011-06-26 Chong Yidong <cyd@stupidchicken.com>
5085
5086 * process.c (wait_reading_process_output): Bypass select if
5087 waiting for a cell while ignoring keyboard input, and input is
5088 pending. Suggested by Jan Djärv (Bug#8869).
5089
7a7ef429
PE
50902011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5091
5092 Use gnulib's dup2 module instead of rolling our own.
5093 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5094
11fdef7d 50952011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
5096
5097 * dispnew.c (scrolling_window): Before scrolling, turn off a
5098 mouse-highlight in the window being scrolled.
5099
cd3520a4
JB
51002011-06-24 Juanma Barranquero <lekktu@gmail.com>
5101
5102 Move DEFSYM to lisp.h and use everywhere.
5103
5104 * character.h (DEFSYM): Move declaration...
5105 * lisp.h (DEFSYM): ...here.
5106
5107 * gnutls.c:
5108 * minibuf.c:
5109 * w32menu.c:
5110 * w32proc.c:
5111 * w32select.c: Don't include character.h.
5112
5113 * alloc.c (syms_of_alloc):
5114 * buffer.c (syms_of_buffer):
5115 * bytecode.c (syms_of_bytecode):
5116 * callint.c (syms_of_callint):
5117 * casefiddle.c (syms_of_casefiddle):
5118 * casetab.c (init_casetab_once):
5119 * category.c (init_category_once, syms_of_category):
5120 * ccl.c (syms_of_ccl):
5121 * cmds.c (syms_of_cmds):
5122 * composite.c (syms_of_composite):
5123 * dbusbind.c (syms_of_dbusbind):
5124 * dired.c (syms_of_dired):
5125 * dispnew.c (syms_of_display):
5126 * doc.c (syms_of_doc):
5127 * editfns.c (syms_of_editfns):
5128 * emacs.c (syms_of_emacs):
5129 * eval.c (syms_of_eval):
5130 * fileio.c (syms_of_fileio):
5131 * fns.c (syms_of_fns):
5132 * frame.c (syms_of_frame):
5133 * fringe.c (syms_of_fringe):
5134 * insdel.c (syms_of_insdel):
5135 * keymap.c (syms_of_keymap):
5136 * lread.c (init_obarray, syms_of_lread):
5137 * macros.c (syms_of_macros):
5138 * msdos.c (syms_of_msdos):
5139 * print.c (syms_of_print):
5140 * process.c (syms_of_process):
5141 * search.c (syms_of_search):
5142 * sound.c (syms_of_sound):
5143 * syntax.c (init_syntax_once, syms_of_syntax):
5144 * terminal.c (syms_of_terminal):
5145 * textprop.c (syms_of_textprop):
5146 * undo.c (syms_of_undo):
5147 * w32.c (globals_of_w32):
5148 * window.c (syms_of_window):
5149 * xdisp.c (syms_of_xdisp):
5150 * xfaces.c (syms_of_xfaces):
5151 * xfns.c (syms_of_xfns):
5152 * xmenu.c (syms_of_xmenu):
5153 * xsettings.c (syms_of_xsettings):
5154 * xterm.c (syms_of_xterm): Use DEFSYM.
5155
4228cf16
TZ
51562011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5157
cd3520a4 5158 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 5159
7fcccf1e
PE
51602011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5161
7efb4e0e
PE
5162 Integer and buffer overflow fixes (Bug#8873).
5163
ff5844ad
PE
5164 * print.c (printchar, strout): Check for string overflow.
5165 (PRINTPREPARE, printchar, strout):
5166 Don't set size unless allocation succeeds.
5167
90532f02
PE
5168 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5169 for sizes. Check for string overflow more accurately.
5170 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5171
6d84508d
PE
5172 * macros.c: Integer and buffer overflow fixes.
5173 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5174 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5175 Use ptrdiff_t, not int, for sizes.
5176 Don't increment bufsize until after realloc succeeds.
5177 Check for size-calculation overflow.
5178 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5179
437b2cb4
PE
5180 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5181
8b9ac8b4
PE
5182 * lread.c: Integer overflow fixes.
5183 (read_integer): Radix is now EMACS_INT, not int,
5184 to improve quality of diagnostics for out-of-range radices.
5185 Calculate buffer size correctly for out-of-range radices.
5186 (read1): Check for integer overflow in radices, and in
5187 read-circle numbers.
82cb60d3
PE
5188 (read_escape): Avoid int overflow.
5189 (Fload, openp, read_buffer_size, read1)
5190 (substitute_object_recurse, read_vector, read_list, map_obarray):
5191 Use ptrdiff_t, not int, for sizes.
5192 (read1): Use EMACS_INT, not int, for sizes.
20270765 5193 Check for size overflow.
8b9ac8b4 5194
7fcccf1e
PE
5195 * image.c (cache_image): Check for size arithmetic overflow.
5196
bfbbd7e7
PE
5197 * lread.c: Integer overflow issues.
5198 (saved_doc_string_size, saved_doc_string_length)
5199 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5200 Now ptrdiff_t, not int.
5201 (read1): Don't assume doc string length fits in int. Check for
5202 out-of-range doc string lengths.
5203 (read_list): Don't assume file position fits in int.
39019e54 5204 (read_escape): Check for hex character overflow.
bfbbd7e7 5205
4e323265
LL
52062011-06-22 Leo Liu <sdl.web@gmail.com>
5207
5208 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5209 Move to minibuffer.el.
5210
85fece3e
PE
52112011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5212
20b84ce9 5213 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
5214 The following patches are for when GLYPH_DEBUG && !XASSERT.
5215 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5216 * dispnew.c (flush_stdout):
5217 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5218 Mark as externally visible.
5219 * dispnew.c (check_window_matrix_pointers): Now static.
5220 * dispnew.c (window_to_frame_vpos):
5221 * xfns.c (unwind_create_frame):
5222 * xterm.c (x_check_font): Remove unused local.
5223 * scroll.c (CHECK_BOUNDS):
5224 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5225 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5226 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5227 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5228 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5229 Now static.
5230 (debug_method_add): Use va_list and vsprintf rather than relying
5231 on undefined behavior with wrong number of arguments.
5232 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5233 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5234 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5235 since we're not interested in debugging glyphs with old libraries.
5236 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5237 GCC 4.6.0's static checking.
5238
0766b489
PE
52392011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5240
31fd4b32
PE
5241 Integer overflow and signedness fixes (Bug#8873).
5242 A few related buffer overrun fixes, too.
5243
b79e8648
PE
5244 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5245
0766b489
PE
5246 * dispextern.h (struct face.stipple):
5247 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5248 (x_bitmap_mask, x_allocate_bitmap_record)
5249 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5250 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5251 (x_create_bitmap_from_xpm_data):
5252 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5253 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5254 (.bitmaps_last):
5255 * xfaces.c (load_pixmap):
5256 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5257 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5258 (.bitmaps_last, struct x_output.icon_bitmap):
5259 Use ptrdiff_t, not int, for bitmap indexes.
5260 (x_allocate_bitmap_record): Check for size overflow.
5261 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5262
b081724f
PE
5263 Use ptrdiff_t, not int, for overlay counts.
5264 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5265 * editfns.c (overlays_around, get_pos_property):
5266 * textprop.c (get_char_property_and_overlay):
5267 * xdisp.c (next_overlay_change, note_mouse_highlight):
5268 * xfaces.c (face_at_buffer_position):
21514da7
PE
5269 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5270 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5271 (Fnext_overlay_change, Fprevious_overlay_change)
5272 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 5273 Use ptrdiff_t, not int, for sizes.
21514da7 5274 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 5275
3de73e5e
PE
5276 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5277
2606c57b
PE
5278 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5279 (x_session_initialize): Do not assume string length fits in int.
5280
aaafe47a
PE
5281 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5282 This is unlikely, but can occur if DPI is outlandish.
5283
2674ddc8 5284 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
5285 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5286
28154962
PE
5287 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5288 * xrdb.c (magic_file_p, search_magic_path):
5289 Omit last arg SUFFIX; it was always 0. All callers changed.
5290 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5291
7de51af5
PE
5292 * xfont.c (xfont_match): Avoid need for strlen.
5293
25ed6cc3
PE
5294 * xfns.c: Don't assume strlen fits in int.
5295 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5296
4eab31dd
PE
5297 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5298 not unsigned long, as we prefer signed integers. All callers changed.
5299 Detect integer overflow in repeat count.
5300 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 5301 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 5302
171e2a58
PE
5303 * termcap.c: Don't assume sizes fit in int and never overflow.
5304 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5305 (gobble_line): Check for size-calculation overflow.
5306
ad39faca 5307 * minibuf.c (Fread_buffer):
6e5bb2dc 5308 * lread.c (intern, intern_c_string):
74ca2eb3
PE
5309 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5310 Don't assume string length fits in int.
5311
52c61c22 5312 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
5313 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5314
b5b8c9e5
PE
5315 * font.c: Don't assume string length fits in int.
5316 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5317 Use ptrdiff_t, not int.
ccd6111c
PE
5318 (font_intern_prop): Don't assume string length fits in int.
5319 Don't assume integer property fits in fixnum.
5320 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 5321
882f0d81 5322 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 5323 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
5324 Reformulate so as not to need the command string.
5325 Invoke gzip -cd rather than gunzip, as it's more portable.
5326 (lock_info_type, lock_file_1, lock_file):
5327 Don't assume pid_t and time_t fit in unsigned long.
5328 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5329 (current_lock_owner): Prefer signed type for sizes.
5330 Use memcpy, not strncpy, where memcpy is what is really wanted.
5331 Don't assume (via atoi) that time_t and pid_t fit in int.
5332 Check for time_t and/or pid_t out of range, e.g., via a network share.
5333 Don't alloca where an auto var works fine.
5334
93f4cf88
PE
5335 * fileio.c: Fix some integer overflow issues.
5336 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5337 Don't assume string length fits in int.
5338 (directory_file_name): Don't assume string length fits in long.
5339 (make_temp_name): Don't assume pid fits in int, or that its print
5340 length is less than 20.
5341
f3e92b69
PE
5342 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5343
1bfdaf10
PE
5344 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5345
35016e9a
PE
5346 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5347
3d1e65a1
PE
5348 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5349 We prefer signed integers, even for size calculations.
5350
0b963a93
PE
5351 * emacs.c: Don't assume string length fits in 'int'.
5352 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5353 (main): Don't invoke strlen when not needed.
5354
573f4b54
PE
5355 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5356 (XD_DEBUG_MESSAGE): Don't waste a byte.
5357
989f33ba
PE
5358 * callproc.c (getenv_internal_1, getenv_internal)
5359 (Fgetenv_internal):
965d34eb
PE
5360 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5361
e4d29b33
PE
5362 * lread.c (invalid_syntax): Omit length argument.
5363 All uses changed. This doesn't fix a bug, but it simplifies the
5364 code away from its former Hollerith-constant appearance, and it's
5365 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 5366 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 5367
eb49b136
PE
5368 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5369 This didn't break anything, but it didn't help either.
5370 It's confusing to put a bogus integer in a place where the actual
5371 value does not matter.
9f62aeb1 5372 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 5373 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 5374
15375a22
PE
5375 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5376 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5377 implementation.
b61cc01c
PE
5378 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5379 We prefer signed types, and the value cannot exceed the EMACS_INT
5380 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
5381 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5382 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5383 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 5384
53b2623d
PE
5385 * indent.c (sane_tab_width): New function.
5386 (current_column, scan_for_column, Findent_to, position_indentation)
5387 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 5388 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 5389
51cab52b 5390 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 5391
f2ed8a70
PE
5392 * lisp.h (lint_assume): New macro.
5393 * composite.c (composition_gstring_put_cache):
5394 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5395
abe80cc6
PE
5396 * editfns.c, insdel.c:
5397 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5398
b02c740e
PE
5399 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5400
ebc96716
PE
5401 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5402
b4e50fa0 5403 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5404 Use much-faster test for byte-length change.
311d5d7c 5405 Don't assume string byte-length fits in 'int'.
a4cf38e4 5406 Check that character arg fits in 'int'.
85461888 5407 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5408
c0c1ee9f
PE
5409 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5410
a498d7f4
PE
5411 * fns.c (concat): Catch string overflow earlier.
5412 Do not rely on integer wraparound.
5413
51cab52b
PE
5414 * dispextern.h (struct it.overlay_strings_charpos)
5415 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5416 * xdisp.c (forward_to_next_line_start)
5417 (back_to_previous_visible_line_start)
5418 (reseat_at_next_visible_line_start, next_element_from_buffer):
5419 Don't arbitrarily truncate the value of 'selective' to int.
5420
76031fad
PE
5421 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5422
5eb55db9
PE
5423 * composite.c: Don't truncate sizes to 'int'.
5424 (composition_gstring_p, composition_reseat_it)
5425 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5426 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5427 not EMACS_UINT, for indexes.
5eb55db9 5428
0703a717
PE
5429 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5430
d6202519
PE
5431 * buffer.c: Include <verify.h>.
5432 (struct sortvec.priority, struct sortstr.priority):
8961a454 5433 Now EMACS_INT, not int.
c20998a7 5434 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5435 (struct sortstr.size, record_overlay_string)
5436 (struct sortstrlist.size, struct sortlist.used):
5437 Don't truncate size to int.
5438 (record_overlay_string): Check for size-calculation overflow.
d6202519 5439 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5440
d5a19415
JM
54412011-06-22 Jim Meyering <meyering@redhat.com>
5442
029529ac 5443 Don't leak an XBM-image-sized buffer
d5a19415
JM
5444 * image.c (xbm_load): Free the image buffer after using it.
5445
a9041e6c
PE
54462011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5447
5448 Port to Sun C.
5449 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5450 that Sun C diagnosed.
5451 * fns.c (secure_hash): Fix pointer signedness issue.
5452 * intervals.c (static_offset_intervals): New function.
5453 (offset_intervals): Use it.
5454
7f3f739f
LL
54552011-06-21 Leo Liu <sdl.web@gmail.com>
5456
5457 * deps.mk (fns.o):
5458 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5459 sha512.h.
5460
5461 * fns.c (secure_hash): Rename from crypto_hash_function and change
5462 the first arg to accept symbols.
5b66d427 5463 (Fsecure_hash): New primitive.
7f3f739f
LL
5464 (syms_of_fns): New symbols.
5465
76147d94
DD
54662011-06-20 Deniz Dogan <deniz@dogan.se>
5467
5468 * process.c (Fset_process_buffer): Clarify return value in
5469 docstring.
5470
7d7d0045
CY
54712011-06-18 Chong Yidong <cyd@stupidchicken.com>
5472
5473 * dispnew.c (add_window_display_history): Use BVAR.
5474
5475 * xdisp.c (debug_method_add): Use BVAR.
5476 (check_window_end, dump_glyph_matrix, dump_glyph)
5477 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5478
5479 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5480 Likewise.
5481
5482 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5483 check till after the cache is created in init_frame_faces.
5484
ff2bc410
SM
54852011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5486
5487 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5488
28177add
PE
54892011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5490
dd3482fe
PE
5491 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5492 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5493 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5494
393d71f3 5495 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5496 * fileio.c (Finsert_file_contents):
5497 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5498 Remove the old (too-loose) buffer overflow checks.
5499 They weren't needed, since make_gap checks for buffer overflow.
5500 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5501 The old code merely checked for Emacs fixnum overflow, and relied
5502 on undefined (wraparound) behavior. The new code avoids undefined
5503 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5504
2e6813b0 5505 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5506 Tune. Don't use wider integers than needed. Don't use alloca.
5507 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5508
599a9e4f
PE
5509 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5510
99561444
PE
5511 * insdel.c, lisp.h (buffer_overflow): New function.
5512 (insert_from_buffer_1, replace_range, replace_range_2):
5513 * insdel.c (make_gap_larger):
5514 * editfns.c (Finsert_char):
5515 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5516
28177add
PE
5517 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5518
e69dafad
PE
55192011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5520
4baa020d 5521 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5522
b1c46f02
PE
5523 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5524 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5525
e69dafad
PE
5526 * fileio.c: Don't assume EMACS_INT fits in off_t.
5527 (emacs_lseek): New static function.
5528 (Finsert_file_contents, Fwrite_region): Use it.
5529 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5530
566684ea
PE
5531 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5532
e6966cd6
PE
5533 * fns.c: Don't overflow int when computing a list length.
5534 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5535 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5536 truncation on 64-bit hosts. Check for QUIT every
5537 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5538 faster and is responsive enough.
5539 (Flength): Report an error instead of overflowing an integer.
5540 (Fsafe_length): Return a float if the value is not representable
5541 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5542 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5543 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5544
dd0b0efb
PE
5545 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5546 (header_size, word_size): New constants.
5547 (allocate_vectorlike): Don't check size overflow here.
5548 (allocate_vector): Check it here instead, since this is the only
5549 caller of allocate_vectorlike that could cause overflow.
5550 Check that the new vector's length is representable as a fixnum.
5551
86fe5cfe
PE
5552 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5553 The previous code was bogus. For example, next_almost_prime (32)
5554 returned 39, which is undesirable as it is a multiple of 3; and
5555 next_almost_prime (24) returned 25, which is a multiple of 5 so
5556 why was the code bothering to check for multiples of 7?
5557
80e88859
PE
5558 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5559
4a2f0ad6
PE
5560 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5561
f66c7cf8
PE
5562 Variadic C functions now count arguments with ptrdiff_t.
5563 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5564 Back then I didn't know that the Emacs coding style prefers signed int.
5565 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5566 were being counted with int, which may truncate counts on 64-bit
5567 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5568 * lisp.h (struct Lisp_Subr.function.aMANY)
5569 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5570 Arg counts are now ptrdiff_t, not size_t.
5571 All variadic functions and their callers changed accordingly.
5572 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5573 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5574 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5575 * callint.c (Fcall_interactively): Check arg count for overflow,
5576 to avoid potential buffer overrun. Use signed char, not 'int',
5577 for 'varies' array, so that we needn't bother to check its size
5578 calculation for overflow.
5579 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5580 * eval.c (apply_lambda):
5581 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5582 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5583 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5584
a1759b76
PE
5585 * callint.c (Fcall_interactively): Don't use index var as event count.
5586
d96be9fc
PE
5587 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5588 * mem-limits.h (SIZE): Remove; no longer used.
5589
a690a978 5590 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5591
578c21e6
PE
5592 Remove unnecessary casts.
5593 * xterm.c (x_term_init):
5594 * xfns.c (x_set_border_pixel):
5595 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5596 These aren't needed now that we assume ANSI C.
5597
96f53c6c
PE
5598 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5599 It's more likely to cause problems (due to unsigned overflow)
5600 than to cure them.
5601
83c77d31
PE
5602 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5603
ee2079f1
PE
5604 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5605
6da65536
PE
5606 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5607
7147c4a4
PE
5608 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5609
193e32d9
PE
5610 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5611
e5533da6
PE
5612 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5613
9910e595
PE
5614 GLYPH_CODE_FACE returns EMACS_INT, not int.
5615 * dispextern.h (merge_faces):
5616 * xfaces.c (merge_faces):
01103c44
PE
5617 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5618 Don't assume EMACS_INT fits in int.
9910e595 5619
2638320e
PE
5620 * character.h (CHAR_VALID_P): Remove unused parameter.
5621 * fontset.c, lisp.h, xdisp.c: All uses changed.
5622
045eb8d9
PE
5623 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5624
c1f134b5
PE
5625 * fns.c (concat): Minor tuning based on overflow analysis.
5626 This doesn't fix any bugs. Use int to hold character, instead
5627 of constantly refetching from Emacs object. Use XFASTINT, not
5628 XINT, for value known to be a character. Don't bother comparing
5629 a single byte to 0400, as it's always less.
5630
395fcb93 5631 * floatfns.c (Fexpt):
327eeec8
PE
5632 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5633
abbd3d23
PE
5634 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5635 for characters.
5636
684a03ef
PE
5637 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5638
0fed43f3
PE
5639 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5640 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5641 incorrectly succeed when S was a string, because 4294967386 was
5642 truncated before it was used.
5643
8fd02eb7
PE
5644 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5645 Otherwise, an out-of-range integer could cause undefined behavior
5646 on a 64-bit host.
5647
f8c86b69
PE
5648 * composite.c: Use int, not EMACS_INT, for characters.
5649 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5650 EMACS_INT, for values that are known to be in character range.
5651 This doesn't fix any bugs but is the usual style inside Emacs and
5652 may generate better code on 32-bit machines.
5653
34206dd2
PE
5654 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5655 This is for reasons similar to the recent CHAR_STRING fix.
5656 * charset.c (Fencode_char): Check that character arg is actually
5657 a character. Pass an int to ENCODE_CHAR.
5658 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5659 wider than 'int', as a compile-time check to prevent future regressions
5660 in this area.
5661
c5958d4c 5662 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5663
5664 Make sure a 64-bit char is never passed to CHAR_STRING.
5665 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5666 by silently ignoring the top 32 bits, allowing some values
5667 that were far too large to be valid characters.
5668 * character.h: Include <verify.h>.
5669 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5670 arguments are no wider than unsigned, as a compile-time check
5671 to prevent future regressions in this area.
5672 * data.c (Faset):
01103c44 5673 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5674 (Fsubst_char_in_region):
5675 * fns.c (concat):
5676 * xdisp.c (decode_mode_spec_coding):
5677 Adjust to CHAR_STRING's new requirement.
5678 * editfns.c (Finsert_char, Fsubst_char_in_region):
5679 * fns.c (concat): Check that character args are actually
5680 characters. Without this test, these functions did the wrong
5681 thing with wildly out-of-range values on 64-bit hosts.
5682
d37ca623
PE
5683 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5684 These casts should not be needed on 32-bit hosts, either.
5685 * keyboard.c (read_char):
5686 * lread.c (Fload): Remove casts to unsigned.
5687
ea204efb
PE
5688 * lisp.h (UNSIGNED_CMP): New macro.
5689 This fixes comparison bugs on 64-bit hosts.
5690 (ASCII_CHAR_P): Use it.
5691 * casefiddle.c (casify_object):
01103c44 5692 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5693 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5694 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5695 * dispextern.h (FACE_FROM_ID):
5696 * keyboard.c (read_char): Use UNSIGNED_CMP.
5697
41cb286c
PE
5698 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5699 not to EMACS_INT, to avoid GCC warning.
5700
4a1b9832
PE
5701 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5702
55daad71
PE
5703 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5704 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5705 isn't needed on 32-bit machines.
8f95c75c 5706
01103c44
PE
5707 * buffer.c (Fgenerate_new_buffer_name):
5708 Use EMACS_INT for count, not int.
0ceccced 5709 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5710
5711 * data.c (Qcompiled_function): Now static.
5712
c6f072e7
PE
5713 * window.c (window_body_lines): Now static.
5714
20ce5912
PE
5715 * image.c (gif_load): Rename local to avoid shadowing.
5716
9c4c5f81
PE
5717 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5718 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5719 * alloc.c (make_save_value): Integer argument is now of type
5720 ptrdiff_t, not int.
5721 (mark_object): Use ptrdiff_t, not int.
5722 * lisp.h (pD): New macro.
5723 * print.c (print_object): Use it.
5724
c0c5c8ae
PE
5725 * alloc.c: Use EMACS_INT, not int, to count objects.
5726 (total_conses, total_markers, total_symbols, total_vector_size)
5727 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5728 (total_free_floats, total_floats, total_free_intervals)
5729 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5730 Now EMACS_INT, not int. All uses changed.
5731 (Fgarbage_collect): Compute overall total using a double, so that
5732 integer overflow is less likely to be a problem. Check for overflow
5733 when converting back to an integer.
5a25e253
PE
5734 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5735 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5736 These were 'int' variables that could overflow on 64-bit hosts;
5737 they were never used, so remove them instead of repairing them.
211a0b2a 5738 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5739 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5740 Previously, this ceilinged at INT_MAX, but that doesn't work on
5741 64-bit machines.
e46bb31a 5742 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5743
c78baabf 5744 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5745 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5746 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5747 when a (possibly-narrower) signed value would do just as well.
5748 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5749
c9d624c6
PE
5750 * alloc.c: Catch some string size overflows that we were missing.
5751 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5752 for convenience in STRING_BYTES_MAX.
5753 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5754 The definition here is exact; the one in lisp.h was approximate.
5755 (allocate_string_data): Check for string overflow. This catches
5756 some instances we weren't catching before. Also, it catches
5757 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5758 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5759 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5760
c9d624c6
PE
5761 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5762 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5763 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5764
353032ce
PE
5765 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5766
2bccce07
PE
5767 * alloc.c (Fmake_string): Check for out-of-range init.
5768
0ac30604
SM
57692011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5770
5771 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5772
c195f2de
JD
57732011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5774
5775 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5776 xg_get_default_scrollbar_width.
5777
5778 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5779 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5780 (style_changed_cb): Call update_theme_scrollbar_width and call
5781 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5782 all frames (Bug#8505).
5783 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5784 Call gtk_window_set_resizable if HAVE_GTK3.
5785 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5786 and height if HAVE_GTK3 (Bug#8505).
5787 (scroll_bar_width_for_theme): New variable.
5788 (update_theme_scrollbar_width): New function.
5789 (xg_get_default_scrollbar_width): Move code to
5790 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5791 (xg_initialize): Call update_theme_scrollbar_width.
5792
5793 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5794
5795 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5796
e10ac9f1
MR
57972011-06-12 Martin Rudalics <rudalics@gmx.at>
5798
5799 * frame.c (make_frame): Call other_buffer_safely instead of
5800 other_buffer.
5801
5802 * window.c (temp_output_buffer_show): Call display_buffer with
5803 second argument Vtemp_buffer_show_specifiers and reset latter
5804 immediately after the call.
5805 (Vtemp_buffer_show_specifiers): New variable.
5806 (auto_window_vscroll_p, next_screen_context_lines)
5807 (Vscroll_preserve_screen_position): Remove leading asterisks from
5808 doc-strings.
5809
2d3c217e 58102011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5811
7b7f97e8 5812 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5813 * buffer.c (Qclone_number): Remove for now, as it's unused.
5814 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5815 (record_buffer): Remove unused local.
5816 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5817 (set_frame_buffer_list): Remove; unused.
5818 * frame.h (other_visible_frames): Remove decl.
5819 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5820 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5821 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5822 if HAVE_GPM.
5823 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5824 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5825 Define only if HAVE_GPM.
5826 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5827 (update_hints_inhibit): Remove; never set. All uses removed.
5828 * widgetprv.h (emacsFrameClassRec): Remove decl.
5829 * window.c (delete_deletable_window): Now returns void, since it
5830 wasn't returning anything.
5831 (compare_window_configurations): Remove unused locals.
5832 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5833 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5834 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5835 the same widths as pointers. This follows up on the 2011-05-06 patch.
5836 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5837 * xterm.h: Likewise.
5838 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5839
1384b89e
JB
58402011-06-12 Juanma Barranquero <lekktu@gmail.com>
5841
5842 * makefile.w32-in: Update dependencies.
5843 (LISP_H): Add lib/intprops.h.
5844
1100a63c
CY
58452011-06-11 Chong Yidong <cyd@stupidchicken.com>
5846
5847 * image.c (gif_load): Add animation frame delay to the metadata.
5848 (syms_of_image): Use DEFSYM. New symbol `delay'.
5849
6198ccd0
MR
58502011-06-11 Martin Rudalics <rudalics@gmx.at>
5851
5852 * window.c (delete_deletable_window): Re-add.
5853 (Fset_window_configuration): Rewrite to handle dead buffers and
5854 consequently deletable windows.
5855 (window_tree, Fwindow_tree): Remove. Supply functionality in
5856 window.el.
5857 (compare_window_configurations): Simplify code.
5858
b6e3633c
AS
58592011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5860
1ab0dee5
AS
5861 * image.c (imagemagick_load_image): Fix type mismatch.
5862 (Fimagemagick_types): Likewise.
5863
b6e3633c
AS
5864 * window.h (replace_buffer_in_windows): Declare.
5865
9397e56f
MR
58662011-06-11 Martin Rudalics <rudalics@gmx.at>
5867
5868 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5869 Qclone_number. Remove external declaration of Qdelete_window.
5870 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5871 code.
640c8776
SM
5872 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5873 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5874 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5875 buffer list implementation.
5876 (other_buffer_safely): New function.
5877 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5878 calls to replace_buffer_in_windows and
5879 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5880 if allowed.
5881 (record_buffer): Inhibit quitting and rewrite using quittable
5882 functions. Run Qbuffer_list_update_hook if allowed.
5883 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5884 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5885 Move switch-to-buffer to window.el.
9397e56f
MR
5886 (bury-buffer): Move to window.el.
5887 (Vbuffer_list_update_hook): New variable.
5888
5889 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5890 section.
5891
5892 * window.h (resize_frame_windows): Move up in code.
5893 (Fwindow_frame): Remove EXFUN.
5894 (replace_buffer_in_all_windows): Remove prototype.
5895 (replace_buffer_in_windows_safely): Add prototype.
5896
5897 * window.c: Declare Qdelete_window static again. Move down
5898 declaration of select_count.
5899 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5900 (Fother_window): Move to window.el.
5901 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5902 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5903 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5904 window.el.
5905 (replace_buffer_in_windows): Implement by calling
5906 Qreplace_buffer_in_windows.
5907 (replace_buffer_in_all_windows): Remove with some functionality
5908 moved into replace_buffer_in_windows_safely.
5909 (replace_buffer_in_windows_safely): New function.
5910 (select_window_norecord, select_frame_norecord): Move in front
5911 of run_window_configuration_change_hook. Remove now obsolete
5912 declarations.
640c8776
SM
5913 (Fset_window_buffer): Rewrite doc-string.
5914 Call Qrecord_window_buffer.
9397e56f
MR
5915 (keys_of_window): Move binding for other-window to window.el.
5916
b50691aa
CY
59172011-06-11 Chong Yidong <cyd@stupidchicken.com>
5918
5919 * dispextern.h (struct image): Replace data member, whose int_val
5920 and ptr_val fields were not used by anything, with a single
5921 lisp_val object.
5922
5923 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5924 (gif_clear_image, gif_load, imagemagick_load_image)
5925 (gs_clear_image, gs_load): Callers changed.
5926
3f754b86
PE
59272011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5928
cca69397
PE
5929 * buffer.h: Include <time.h>, for time_t.
5930 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5931
109e28d0
PE
5932 Fix minor problems found by static checking.
5933
60737f02
PE
5934 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5935
4b66faf3
PE
5936 Make identifiers static if they are not used in other modules.
5937 * data.c (Qcompiled_function, Qframe, Qvector):
5938 * image.c (QimageMagick, Qsvg):
5939 * minibuf.c (Qmetadata):
5940 * window.c (resize_window_check, resize_root_window): Now static.
5941 * window.h (resize_window_check, resize_root_window): Remove decls.
5942
109e28d0
PE
5943 * window.c (window_deletion_count, delete_deletable_window):
5944 Remove; unused.
46a4ce9e
PE
5945 (window_body_lines): Now static.
5946 (Fdelete_other_windows_internal): Mark vars as initialized.
5947 Make sure 'resize_failed' is initialized.
5948 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5949 (resize_window_apply): Remove unused local.
5950 * window.h (delete_deletable_window): Remove decl.
5951
109e28d0 5952 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5953 (imagemagick_load_image): Fix pointer signedness problem by changing
5954 last arg from unsigned char * to char *. All uses changed.
5955 Also, fix a local for similar reasons.
5956 Remove unused locals. Remove locals to avoid shadowing.
5957 (fn_rsvg_handle_free): Remove; unused.
5958 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5959 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5960
3f754b86
PE
5961 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5962
2547adb1
CY
59632011-06-10 Chong Yidong <cyd@stupidchicken.com>
5964
5965 * image.c (gif_load): Fix omitted cast error introduced by
5966 2011-06-06 change.
5967
2c8e37d4
MR
59682011-06-10 Martin Rudalics <rudalics@gmx.at>
5969
5970 * window.h (resize_proportionally, orig_total_lines)
5971 (orig_top_line): Remove from window structure.
5972 (set_window_height, set_window_width, change_window_heights)
5973 (Fdelete_window): Remove prototypes.
5974 (resize_frame_windows): Remove duplicate declaration.
5975
440a42e3
EZ
59762011-06-10 Eli Zaretskii <eliz@gnu.org>
5977
5978 * window.h (resize_frame_windows, resize_window_check)
5979 (delete_deletable_window, resize_root_window)
5980 (resize_frame_windows): Declare prototypes.
5981
5982 * window.c (resize_window_apply): Make definition be "static" to
5983 match the prototype.
5984
562dd5e9
MR
59852011-06-10 Martin Rudalics <rudalics@gmx.at>
5986
5987 * window.c: Remove declarations of Qwindow_size_fixed,
5988 window_min_size_1, window_min_size_2, window_min_size,
5989 size_window, window_fixed_size_p, enlarge_window, delete_window.
5990 Remove static from declaration of Qdelete_window, it's
5991 temporarily needed by Fbury_buffer.
5992 (replace_window): Don't assign orig_top_line and
5993 orig_total_lines.
5994 (Fdelete_window, delete_window): Remove. Window deletion is
5995 handled by window.el.
640c8776
SM
5996 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5997 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5998 (Fdelete_other_windows): Remove. Deleting other windows is
5999 handled by window.el.
6000 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
6001 handled in window.el.
6002 (window_min_size_2, window_min_size_1, window_min_size): Remove.
6003 Window minimum sizes are handled in window.el.
6004 (shrink_windows, size_window, set_window_height)
6005 (set_window_width, change_window_heights, window_height)
6006 (window_width, CURBEG, CURSIZE, enlarge_window)
6007 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
6008 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
6009 handled in window.el.
6010 (make_dummy_parent): Rename to make_parent_window and give it a
6011 second argument horflag.
6012 (make_window): Don't set resize_proportionally any more.
6013 (Fsplit_window): Remove. Windows are split in window.el.
6014 (save_restore_action, save_restore_orig_size)
6015 (shrink_window_lowest_first, save_restore_orig_size): Remove.
6016 Resize mini windows in window.el.
6017 (grow_mini_window, shrink_mini_window): Implement by calling
6018 Qresize_root_window_vertically, resize_window_check and
6019 resize_window_apply.
640c8776
SM
6020 (saved_window, Fset_window_configuration, save_window_save):
6021 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
6022 resize_proportionally.
6023 (window_min_height, window_min_width): Move to window.el.
6024 (keys_of_window): Move bindings for delete-other-windows,
6025 split-window, delete-window and enlarge-window to window.el.
6026
6027 * buffer.c: Temporarily extern Qdelete_window.
6028 (Fbury_buffer): Temporarily call Qdelete_window instead of
6029 Fdelete_window (Fbury_buffer will move to window.el soon).
6030
6031 * frame.c (set_menu_bar_lines_1): Remove code handling
6032 orig_top_line and orig_total_lines.
6033
6034 * dispnew.c (adjust_frame_glyphs_initially): Don't use
6035 set_window_height but set heights directly.
6036 (change_frame_size_1): Use resize_frame_windows.
6037
6038 * xdisp.c (init_xdisp): Don't use set_window_height but set
6039 heights directly.
6040
640c8776
SM
6041 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
6042 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
6043 run_window_configuration_change_hook.
6044
6045 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
6046 instead of change_window_heights and run
6047 run_window_configuration_change_hook.
6048
1a13852e
MR
60492011-06-09 Martin Rudalics <rudalics@gmx.at>
6050
6051 * window.c (replace_window): Rename second argument REPLACEMENT to
6052 NEW. New third argument SETFLAG. Rewrite.
6053 (delete_window, make_dummy_parent): Call replace_window with
6054 third argument 1.
6055 (window_list_1): Move down in code.
6056 (run_window_configuration_change_hook): Move set_buffer part
6057 before select_frame_norecord part in order to unwind correctly.
6058 Rename count1 to count.
6059 (recombine_windows, delete_deletable_window, resize_root_window)
6060 (Fdelete_other_windows_internal)
6061 (Frun_window_configuration_change_hook, make_parent_window)
6062 (resize_window_check, resize_window_apply, Fresize_window_apply)
6063 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
6064 (Fdelete_window_internal, Fresize_mini_window_internal):
6065 New functions.
1a13852e
MR
6066 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
6067
f3d1777e
MR
60682011-06-08 Martin Rudalics <rudalics@gmx.at>
6069
496e208e
MR
6070 * window.h (window): Add some new members to window structure -
6071 normal_lines, normal_cols, new_total, new_normal, clone_number,
6072 splits, nest, prev_buffers, next_buffers.
6073 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 6074 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 6075
f3d1777e
MR
6076 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
6077 Remove.
496e208e
MR
6078 (make_dummy_parent): Set new members of windows structure.
6079 (make_window): Move down in code. Handle new members of window
6080 structure.
6081 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6082 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6083 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6084 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
6085 (Fset_window_next_buffers, Fset_window_clone_number):
6086 New functions.
496e208e
MR
6087 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6088 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6089 Doc-string fixes.
6090 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6091 Argument WINDOW can be now internal window too.
6092 (Fwindow_use_time): Move up in code.
6093 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6094 Rewrite doc-string.
6095 (Fset_window_configuration, saved_window)
6096 (Fcurrent_window_configuration, save_window_save): Handle new
6097 members of window structure.
b9e809c2
MR
6098 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6099 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6100 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6101 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6102 Qget_mru_window, Qresize_root_window,
6103 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6104 Qauto_buffer_name; staticpro them.
f3d1777e 6105
abde8f8c
MR
61062011-06-07 Martin Rudalics <rudalics@gmx.at>
6107
6108 * window.c (Fwindow_total_size, Fwindow_left_column)
6109 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6110 (Fwindow_list_1): New functions.
6111 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
6112 (Fwindow_width, Fscroll_left, Fscroll_right):
6113 Use window_body_cols instead of window_box_text_cols.
6114 (delete_window, Fset_window_configuration):
6115 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
6116 (delete_all_subwindows): Take a window as argument and not a
6117 structure. Rewrite.
190b47e6
MR
6118 (window_loop): Remove handling of GET_LRU_WINDOW and
6119 GET_LARGEST_WINDOW.
6120 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
6121
6122 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
6123 window_box_text_cols. delete_all_subwindows now takes a
6124 Lisp_Object as argument.
abde8f8c 6125
640c8776
SM
6126 * indent.c (compute_motion, Fcompute_motion):
6127 Use window_body_cols instead of window_box_text_cols.
abde8f8c 6128
fa8a67e6
MR
6129 * frame.c (delete_frame): Call delete_all_subwindows with root
6130 window as argument.
6131
a54e3482
DC
61322011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6133
6134 * fns.c (Fputhash): Document return value.
6135
60002bf5
CY
61362011-06-06 Chong Yidong <cyd@stupidchicken.com>
6137
6138 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6139
0c671da6 61402011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 6141
b862a52a 6142 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 6143
be44ca6c
PE
6144 Check for overflow when converting integer to cons and back.
6145 * charset.c (Fdefine_charset_internal, Fdecode_char):
6146 Use cons_to_unsigned to catch overflow.
6147 (Fencode_char): Use INTEGER_TO_CONS.
6148 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6149 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6150 * data.c (long_to_cons, cons_to_long): Remove.
6151 (cons_to_unsigned, cons_to_signed): New functions.
6152 These signal an error for invalid or out-of-range values.
6153 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6154 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6155 * font.c (Ffont_variation_glyphs):
6156 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6157 * lisp.h: Include <intprops.h>.
6158 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6159 (cons_to_signed, cons_to_unsigned): New decls.
6160 (long_to_cons, cons_to_long): Remove decls.
6161 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6162 (Fprimitive_undo): Use CONS_TO_INTEGER.
6163 * xfns.c (Fx_window_property): Likewise.
6164 * xselect.c: Include <limits.h>.
6165 (x_own_selection, selection_data_to_lisp_data):
6166 Use INTEGER_TO_CONS.
6167 (x_handle_selection_request, x_handle_selection_clear)
6168 (x_get_foreign_selection, Fx_disown_selection_internal)
6169 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6170 (lisp_data_to_selection_data): Use cons_to_unsigned.
6171 (x_fill_property_data): Use cons_to_signed.
6172 Report values out of range.
6173
d1f3d2af
PE
6174 Check for buffer and string overflow more precisely.
6175 * buffer.h (BUF_BYTES_MAX): New macro.
6176 * lisp.h (STRING_BYTES_MAX): New macro.
6177 * alloc.c (Fmake_string):
6178 * character.c (string_escape_byte8):
6179 * coding.c (coding_alloc_by_realloc):
6180 * doprnt.c (doprnt):
6181 * editfns.c (Fformat):
6182 * eval.c (verror):
6183 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6184 since they may not be the same number.
6185 * editfns.c (Finsert_char):
6186 * fileio.c (Finsert_file_contents):
6187 Likewise for BUF_BYTES_MAX.
6188
dd52fcea
PE
6189 * image.c: Use ptrdiff_t, not int, for sizes.
6190 (slurp_file): Switch from int to ptrdiff_t.
6191 All uses changed.
6192 (slurp_file): Check that file size fits in both size_t (for
6193 malloc) and ptrdiff_t (for sanity and safety).
6194
7f9bbdbb
PE
6195 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6196 if b->modtime has its maximal value.
6197
dfe18f82
PE
6198 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6199
84acfcf0
PE
6200 Don't assume time_t can fit into int.
6201 * buffer.h (struct buffer.modtime): Now time_t, not int.
6202 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6203 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6204
ccd9a01a
PE
6205 Minor fixes for signed vs unsigned integers.
6206 * character.h (MAYBE_UNIFY_CHAR):
6207 * charset.c (maybe_unify_char):
6208 * keyboard.c (read_char, reorder_modifiers):
6209 XINT -> XFASTINT, since the integer must be nonnegative.
6210 * ftfont.c (ftfont_spec_pattern):
6211 * keymap.c (access_keymap, silly_event_symbol_error):
6212 XUINT -> XFASTINT, since the integer must be nonnegative.
6213 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6214 since it makes no difference and we prefer signed.
6215 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6216 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6217 nonnegative.
6218
d6d100dd
SM
62192011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6220
6221 * window.h (Fwindow_frame): Declare.
6222
2b6148e4
PE
62232011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6224
6225 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6226 (SPARE_MEMORY): Always define.
6227 (LARGE_REQUEST): Remove.
6228 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6229
f230ecc9
MR
62302011-06-06 Martin Rudalics <rudalics@gmx.at>
6231
727e958e
MR
6232 * lisp.h: Move EXFUNS for Fframe_root_window,
6233 Fframe_first_window and Fset_frame_selected_window to window.h.
6234
6235 * window.h: Move EXFUNS for Fframe_root_window,
6236 Fframe_first_window and Fset_frame_selected_window here from
6237 lisp.h.
6238
6239 * frame.c (Fwindow_frame, Fframe_first_window)
6240 (Fframe_root_window, Fframe_selected_window)
6241 (Fset_frame_selected_window): Move to window.c.
6242 (Factive_minibuffer_window): Move to minibuf.c.
6243 (Fother_visible_frames_p): New function.
6244
6245 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6246
f230ecc9
MR
6247 * window.c (decode_window, decode_any_window): Move up in code.
6248 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6249 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
6250 (Fwindow_buffer): Move up and rewrite doc-string.
6251 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6252 (Fwindow_prev): New functions.
727e958e
MR
6253 (Fwindow_frame): Move here from frame.c. Accept any window as
6254 argument.
6255 (Fframe_root_window, Fframe_first_window)
6256 (Fframe_selected_window): Move here from frame.c. Accept frame
6257 or arbitrary window as argument. Update doc-strings.
6258 (Fminibuffer_window): Move up in code.
6259 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
6260 (Fset_frame_selected_window): Move here from frame.c.
6261 Marginal rewrite.
727e958e
MR
6262 (Fselected_window, select_window, Fselect_window): Move up in
6263 code. Minor doc-string fixes.
f230ecc9 6264
4d09bcf6
PE
62652011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6266
6267 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6268 Do not assume that spare memory exists; that assumption is valid
6269 only if SYSTEM_MALLOC.
6270 (LARGE_REQUEST): New macro, so that the issue of large requests
6271 is separated from the issue of spare memory.
6272
810928a2
AS
62732011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6274
172418ad
AS
6275 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6276 format. (Bug#8806)
6277
43f862f7
AS
6278 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6279
810928a2
AS
6280 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6281 before statements.
6282
a059fe24
JD
62832011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6284
6285 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6286
6287 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6288
6289 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6290 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6291
989bf368
JB
62922011-06-05 Juanma Barranquero <lekktu@gmail.com>
6293
6294 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6295
4b80f674
CY
62962011-06-04 Chong Yidong <cyd@stupidchicken.com>
6297
6298 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6299 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
6300 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6301 New error handlers.
4b80f674
CY
6302 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6303 Obey Vx_select_enable_clipboard_manager. Catch errors in
6304 x_clipboard_manager_save (Bug#8779).
6305 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 6306 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 6307
99a33b77 63082011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
6309
6310 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6311
99a33b77 63122011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
6313
6314 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6315 in the current matrix if keep_current_p is non-zero.
6316
8264569d
EZ
63172011-06-04 Eli Zaretskii <eliz@gnu.org>
6318
6319 * bidi.c (bidi_level_of_next_char): Fix last change.
6320
57f97249
EZ
63212011-06-03 Eli Zaretskii <eliz@gnu.org>
6322
fec2107c 6323 Support bidi reordering of text covered by display properties.
57f97249 6324
fec2107c
EZ
6325 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6326 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6327 (bidi_cache_search, bidi_cache_iterator_state)
6328 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
6329 (bidi_level_of_next_char, bidi_move_to_visually_next):
6330 Support character positions inside a run of characters covered by a
fec2107c
EZ
6331 display string.
6332 (bidi_paragraph_init, bidi_resolve_explicit_1)
6333 (bidi_level_of_next_char): Call bidi_fetch_char and
6334 bidi_fetch_char_advance instead of FETCH_CHAR and
6335 FETCH_CHAR_ADVANCE.
6336 (bidi_init_it): Initialize new members.
6337 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6338 definitions.
6339 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6340 instead of using explicit *_CHAR codes.
d6d100dd
SM
6341 (bidi_resolve_explicit, bidi_resolve_weak):
6342 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
6343 bidirectional text is supported only in multibyte buffers.
6344 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6345 it to initialize the frame_window_p member of struct bidi_it.
6346 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6347 (bidi_resolve_explicit, bidi_resolve_weak)
6348 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6349 bidi_it->nchars is non-positive.
6350 (bidi_level_of_next_char): Don't try to lookup the cache for the
6351 next/previous character if nothing is cached there yet, or if we
6352 were just reseat()'ed to a new position.
c40e2fb2 6353
0e14fe90
EZ
6354 * xdisp.c (set_cursor_from_row): Set start and stop points
6355 according to the row's direction when priming the loop that looks
6356 for the glyph on which to display cursor.
6357 (single_display_spec_intangible_p): Function deleted.
6358 (display_prop_intangible_p): Reimplement to call
6359 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
6360 Accept 3 additional arguments needed by handle_display_spec.
6361 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
6362 values: lists, `(when COND...)' forms, etc.
6363 (single_display_spec_string_p): Support property values that are
6364 lists with the argument STRING its top-level element.
6365 (display_prop_string_p): Fix the condition for processing a
6366 property that is a list to be consistent with handle_display_spec.
fec2107c 6367 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
6368 last portion of handle_display_prop.
6369 (compute_display_string_pos): Accept additional argument
6370 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6371 value of a `display' property is a "replacing spec".
6372 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6373 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6374 the display property, but just return a value indicating whether
6375 the display property will replace the characters it covers.
6376 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6377 frame_window_p members of struct bidi_it.
d6d100dd
SM
6378 (compute_display_string_pos, compute_display_string_end):
6379 New functions.
fec2107c
EZ
6380 (push_it): Accept second argument POSITION, where pop_it should
6381 jump to continue iteration.
6382 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 6383
fec2107c
EZ
6384 * keyboard.c (adjust_point_for_property): Adjust the call to
6385 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
6386
6387 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
6388 (bidi_init_it): Update prototypes.
6389 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
6390 (compute_display_string_pos, compute_display_string_end):
6391 Declare prototypes.
fec2107c
EZ
6392 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6393 EMACS_INT.
fc6f18ce 6394
40087514 63952011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6396
57f53182
PE
6397 Malloc failure behavior now depends on size of allocation.
6398 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6399 * lisp.h: Change signatures accordingly.
6400 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6401 All callers changed. (Bug#8762)
6402
6403 * gnutls.c: Use Emacs's memory allocators.
6404 Without this change, the gnutls library would invoke malloc etc.
6405 directly, which causes problems on non-SYNC_INPUT hosts, and which
6406 runs afoul of improving memory_full behavior. (Bug#8761)
6407 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6408 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6409 xfree instead of the default malloc, realloc, free.
6410 (Fgnutls_boot): No need to check for memory allocation failure,
6411 since xmalloc does that for us.
6412
ac32cd99 6413 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6414 * category.c (hash_get_category_set):
6415 * ccl.c (ccl_driver):
6416 * charset.c (Fdefine_charset_internal):
6417 * charset.h (struct charset.hash_index):
6418 * composite.c (get_composition_id, gstring_lookup_cache)
6419 (composition_gstring_put_cache):
6420 * composite.h (struct composition.hash_index):
6421 * dispextern.h (struct image.hash):
6422 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6423 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6424 (hashfn_equal, hashfn_user_defined, make_hash_table)
6425 (maybe_resize_hash_table, hash_lookup, hash_put)
6426 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6427 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6428 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6429 * image.c (make_image, search_image_cache, lookup_image)
6430 (xpm_put_color_table_h):
6431 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6432 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6433 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6434 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6435 * alloc.c (allocate_vectorlike):
6436 Check for overflow in vector size calculations.
6437 * ccl.c (ccl_driver):
6438 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6439 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6440 need to be updated by these changes.
40087514
PE
6441 * fns.c (make_hash_table, maybe_resize_hash_table):
6442 Check for integer overflow with large hash tables.
0de4bb68
PE
6443 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6444 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6445 (SXHASH_REDUCE): New macro.
6446 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6447 Use it instead of discarding useful hash info with large hash values.
6448 (sxhash_float): New function.
6449 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6450 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6451 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6452 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6453 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6454 Adjust signatures to match updated version of code.
6455 (consing_since_gc): Now EMACS_INT, since a single hash table can
6456 use more than INT_MAX bytes.
6457
698d32e2
DN
64582011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6459
6460 Make it possible to build with GCC-4.6+ -O2 -flto.
6461
6462 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6463
fd6fa53f
SM
64642011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6465
6466 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6467 Call minibuffer-inactive-mode.
6468
864db017
JB
64692011-05-31 Juanma Barranquero <lekktu@gmail.com>
6470
6471 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6472 Update dependencies.
6473
2ad0baf4
DN
64742011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6475
6476 * data.c (init_data): Remove code for UTS, this system is not
6477 supported anymore.
6478
4fcc2638
DN
64792011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6480
6481 Don't force ./temacs to start in terminal mode.
6482
6483 * frame.c (make_initial_frame): Initialize faces in all cases, not
6484 only when CANNOT_DUMP is defined.
6485 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6486
c56e0fd5
DN
64872011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6488
6489 * dispnew.c (add_window_display_history): Use const for the string
6490 pointer. Remove declaration, not needed.
6491
333d54da 64922011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6493
55d4c1b2 6494 Use 'inline', not 'INLINE'.
333d54da 6495 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6496 * alloc.c, fontset.c (INLINE): Remove.
6497 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6498 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6499 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6500 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6501 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6502
738db178
DN
65032011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6504
6505 Make it possible to run ./temacs.
6506
6507 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6508 syms_of_callproc does the same thing. Remove test for
6509 "initialized", do it in the caller.
6510 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6511
620c53a6
SM
65122011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6513
6514 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6515 (read_minibuf): Use get_minibuffer.
6516 (syms_of_minibuf): Use DEFSYM.
6517 (Qmetadata): New var.
6518 * data.c (Qbuffer): Don't make it static.
6519 (syms_of_data): Use DEFSYM.
6520
e003a292
PE
65212011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6522
6523 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6524 (CCL_CODE_MIN): New macro.
6525
ed008a6d
PE
65262011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6527
3687c2ef
PE
6528 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6529
ed008a6d
PE
6530 * eval.c (Qdebug): Now static.
6531 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6532 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6533 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6534
d66c4c7c
CY
65352011-05-29 Chong Yidong <cyd@stupidchicken.com>
6536
6537 * image.c: Various fixes to ImageMagick code comments.
6538 (Fimagemagick_types): Doc fix.
6539
5fbc2025
PE
65402011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6541
0196f88a
PE
6542 Minor fixes prompted by GCC 4.6.0 warnings.
6543
6544 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6545
5fbc2025
PE
6546 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6547 (x_clipboard_manager_save_all): Move extern decl to ...
6548 * xterm.h: ... here, so that it can be checked for consistency.
6549
1dd3c2d9
CY
65502011-05-29 Chong Yidong <cyd@stupidchicken.com>
6551
6552 * xselect.c (x_clipboard_manager_save_frame)
6553 (x_clipboard_manager_save_all): New functions.
6554 (Fx_clipboard_manager_save): Lisp function deleted.
6555
6556 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6557 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6558
6559 * xterm.h: Update prototype.
6560
5ba6571d
WX
65612011-05-28 William Xu <william.xwl@gmail.com>
6562
6563 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6564 exiting (Bug#8239).
6565
3eaff834
JM
65662011-05-28 Jim Meyering <meyering@redhat.com>
6567
e1900994 6568 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6569 * fns.c (to_uchar): Define.
6570 (crypto_hash_function): Use it to convert some newly-signed
6571 variables to unsigned, to avoid sign-extension bugs. For example,
6572 without this change, (md5 "truc") would evaluate to
6573 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6574 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6575 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6576
0f6990a7
PE
65772011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6578
6579 Integer overflow fixes.
c8a9ca5a 6580
08686060
PE
6581 * dbusbind.c: Serial number integer overflow fixes.
6582 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6583 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6584 to hold a serial number that is too large for a fixnum.
6585 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6586 Check for serial numbers out of range. Decode any serial number
59568bf0 6587 that was so large that it became a float. (Bug#8722)
08686060 6588
2d1fc3c7
PE
6589 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6590 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6591 Use XFASTINT rather than XUINT when numbers are nonnegative.
6592 (xd_append_arg, Fdbus_method_return_internal):
6593 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6594 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6595 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6596 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6597 (Bug#8722)
2d1fc3c7 6598
c8a9ca5a
PE
6599 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6600
519e1d69
PE
6601 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6602
6df6ae42 6603 ccl: Add integer overflow checks.
30569699
PE
6604 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6605 (IN_INT_RANGE): New macros.
6606 (ccl_driver): Use them to check for integer overflow when
6607 decoding a CCL program. Many of the new checks are whether XINT (x)
6608 fits in int; it doesn't always, on 64-bit hosts. The new version
6609 doesn't catch all possible integer overflows, but it's an
847044ea 6610 improvement. (Bug#8719)
30569699 6611
c11285dc
PE
6612 * alloc.c (make_event_array): Use XINT, not XUINT.
6613 There's no need for unsigned here.
6614
fdccd48e
PE
6615 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6616 This follows up to the 2011-05-06 change that substituted uintptr_t
6617 for EMACS_INT. This case wasn't caught back then.
6618
37910ab2
PE
6619 Rework Fformat to avoid integer overflow issues.
6620 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6621 now (part of C89). Include <verify.h>.
6622 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6623 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6624 (Fformat): Avoid the prepass trying to compute sizes; it was only
6625 approximate and thus did not catch overflow reliably. Instead, walk
6626 through the format just once, formatting and computing sizes as we go,
6627 checking for integer overflow at every step, and allocating a larger
6628 buffer as needed. Keep track separately whether the format is
6629 multibyte. Keep only the most-recently calculated precision, rather
6630 than them all. Record whether each argument has been converted to
6631 string. Use EMACS_INT, not int, for byte and char and arg counts.
6632 Support field widths and precisions larger than INT_MAX. Avoid
6633 sprintf's undefined behavior with conversion specifications such as %#d
6634 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6635 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6636 formatting out-of-range floating point numbers with int
9173deec 6637 formats. (Bug#8668)
37910ab2 6638
2e6578fb
PE
6639 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6640
0ae6bdee
PE
6641 * data.c: Avoid integer truncation in expressions involving floats.
6642 * data.c: Include <intprops.h>.
6643 (arith_driver): When there's an integer overflow in an expression
6644 involving floating point, convert the integers to floating point
6645 so that the resulting value does not suffer from catastrophic
6646 integer truncation. For example, on a 64-bit host (* 4
6647 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6648 Do not rely on undefined behavior after integer overflow.
6649
de883a70
PE
6650 merge count_size_as_multibyte, parse_str_to_multibyte
6651 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6652 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6653 Check for integer overflow.
6654 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6655 since it's now a duplicate of the other. This is more of
6656 a character than a buffer op, so better that it's in character.c.
6657 * fns.c, print.c: Adjust to above changes.
6658
2ff916cb
PE
66592011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6660
6661 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6662
f1b54466
PE
66632011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6664
fb1ac845
PE
6665 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6666 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6667 (x_clipboard_manager_save): Now static.
6668 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6669
f1b54466
PE
6670 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6671 (crypto_hash_function): Now static.
6672 Fix pointer signedness problems. Avoid unnecessary initializations.
6673
a9f737ee
CY
66742011-05-27 Chong Yidong <cyd@stupidchicken.com>
6675
6676 * termhooks.h (Vselection_alist): Make it terminal-local.
6677
6678 * terminal.c (create_terminal): Initialize it.
6679
6680 * xselect.c: Support for clipboard managers.
6681 (Vselection_alist): Move to termhooks.h as terminal-local var.
6682 (LOCAL_SELECTION): New macro.
6683 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6684 (symbol_to_x_atom): Remove gratuitous arg.
6685 (x_handle_selection_request, lisp_data_to_selection_data)
6686 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6687 (x_own_selection, x_get_local_selection, x_convert_selection):
6688 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6689 (some_frame_on_display): Delete unused function.
6690 (Fx_own_selection_internal, Fx_get_selection_internal)
6691 (Fx_disown_selection_internal, Fx_selection_owner_p)
6692 (Fx_selection_exists_p): New optional frame arg.
6693 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6694 (x_handle_selection_clear): Don't treat other terminals with the
6695 same keyboard specially. Use the terminal-local Vselection_alist.
6696 (x_clear_frame_selections): Use Frun_hook_with_args.
6697
6698 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6699
6700 * xterm.h: Add support for those atoms.
6701
e067f0c1
CY
67022011-05-26 Chong Yidong <cyd@stupidchicken.com>
6703
6704 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6705 (converted_selections, conversion_fail_tag): New global variables.
6706 (x_selection_request_lisp_error): Free the above.
6707 (x_get_local_selection): Remove unnecessary code.
6708 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6709 of converted selections stored in converted_selections.
6710 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6711 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6712 (x_convert_selection): New function.
6713 (x_handle_selection_event): Simplify.
6714 (x_get_foreign_selection): Don't ignore incoming requests while
6715 waiting for an answer; this will fail when we implement
6716 SAVE_TARGETS, and seems unnecessary anyway.
6717 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6718 (Vx_sent_selection_functions): Doc fix.
6719
0f4aebc0
LL
67202011-05-26 Leo Liu <sdl.web@gmail.com>
6721
6722 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6723
e61124cd
YM
67242011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6725
6726 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6727
6728 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6729 for fringe update if it has periodic bitmap.
ac389d0c 6730 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6731 and fringe_bitmap_periodic_p.
6732
6733 * fringe.c (get_fringe_bitmap_data): New function.
6734 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6735 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6736 row. Mark glyph row for fringe update if periodicity changed.
6737
6738 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6739 for fringe update unless it has periodic bitmap.
6740
f16d9837
KH
67412011-05-25 Kenichi Handa <handa@m17n.org>
6742
6743 * xdisp.c (get_next_display_element): Set correct it->face_id for
6744 a static composition.
6745
e1b90ef6
LL
67462011-05-24 Leo Liu <sdl.web@gmail.com>
6747
6748 * deps.mk (fns.o):
6749 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6750
6751 * fns.c (crypto_hash_function, Fsha1): New function.
6752 (Fmd5): Use crypto_hash_function.
6753 (syms_of_fns): Add Ssha1.
6754
7400048f
PE
67552011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6756
6757 * gnutls.c: Remove unused macros.
6758 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6759 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6760 Remove macros that are defined and never used.
6761 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6762
abb71cf4
CY
67632011-05-22 Chong Yidong <cyd@stupidchicken.com>
6764
6765 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6766 (Fx_get_selection_internal): Minor cleanup.
6767 (Fx_own_selection_internal): Rename arguments for consistency with
6768 select.el.
6769
6307db39
PE
67702011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6771
6772 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6773
f3d4e0a4
CY
67742011-05-22 Chong Yidong <cyd@stupidchicken.com>
6775
6776 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6777
4d8ade89
YM
67782011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6779
6780 * dispnew.c (scrolling_window): Don't exclude the case that the
6781 last enabled row in the desired matrix touches the bottom boundary.
6782
32078c8d
GM
67832011-05-21 Glenn Morris <rgm@gnu.org>
6784
6785 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6786 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6787 and add some more files.
32078c8d 6788
7285dc67
EZ
67892011-05-20 Eli Zaretskii <eliz@gnu.org>
6790
6791 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6792 report_file_error introduced by the change from 2011-05-07.
6793
89d1bd22
PE
67942011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6795
6796 * systime.h (Time): Define only if emacs is defined.
6797 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6798 where the include path doesn't have X11/X.h by default. See
6799 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6800
cd394be1 68012011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6802
6803 * composite.c (find_automatic_composition): Fix previous change.
6804
b9704ad9
GM
68052011-05-20 Glenn Morris <rgm@gnu.org>
6806
6807 * lisp.mk: New file, split from Makefile.in.
6808 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6809 (shortlisp): Remove.
6810 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6811
4a720484
GM
68122011-05-19 Glenn Morris <rgm@gnu.org>
6813
6814 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6815 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6816 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6817 (lisp): Set the order to that of loadup.el.
6818 (shortlisp): Make it a copy of $lisp.
6819 (SOME_MACHINE_LISP): Remove.
6820 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6821 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6822
a28d4396
KH
68232011-05-18 Kenichi Handa <handa@m17n.org>
6824
6825 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6826 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6827 (find_automatic_composition): Mostly rewrite for efficiency.
6828
a2b1fa8e
JB
68292011-05-18 Juanma Barranquero <lekktu@gmail.com>
6830
6831 * makefile.w32-in: Update dependencies.
6832
8e1f5610
CS
68332011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6834
6835 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6836 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6837
7025ee00 68382011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6839
cdfa6eab
PE
6840 Fix some integer overflow issues, such as string length overflow.
6841
06d6db33
PE
6842 * insdel.c (count_size_as_multibyte): Check for string overflow.
6843
2b4560a8
PE
6844 * character.c (lisp_string_width): Check for string overflow.
6845 Use EMACS_INT, not int, for string indexes and lengths; in
6846 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6847 the resulting string length overflows an EMACS_INT; instead,
6848 report a string overflow if no precision given. When checking for
6849 precision exhaustion, use a check that cannot possibly have
6850 integer overflow. (Bug#8675)
6851 * character.h (lisp_string_width): Adjust to new signature.
6852
cb93f9be
PE
6853 * alloc.c (string_overflow): New function.
6854 (Fmake_string): Use it. This doesn't change behavior, but saves
6855 a few bytes and will simplify future changes.
6856 * character.c (string_escape_byte8): Likewise.
6857 * lisp.h (string_overflow): New decl.
6858
1a1f3366
PE
6859 Fixups, following up to the user-interface timestamp change.
6860 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6861 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6862 * msdos.c (mouse_get_pos): Likewise.
6863 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6864 * w32gui.h (Time): Define by including "systime.h" rather than by
6865 declaring it ourselves. (Bug#8664)
6866
d4e3e4d3
PE
6867 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6868 * image.c (clear_image_cache): Likewise.
6869
f6a24d19
PE
6870 * term.c (term_mouse_position): Don't assume time_t wraparound.
6871
08dc5ae6
PE
6872 Be more systematic about user-interface timestamps.
6873 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6874 and sometimes 'EMACS_UINT', to represent these timestamps.
6875 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6876 This makes the code easier to follow, and makes it easier to catch
6877 integer overflow bugs such as Bug#8664.
6878 * frame.c (Fmouse_position, Fmouse_pixel_position):
6879 Use Time, not unsigned long, for user-interface timestamps.
6880 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6881 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6882 * keyboard.h (last_event_timestamp): Likewise.
6883 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6884 * menu.h (xmenu_show): Likewise.
6885 * term.c (term_mouse_position): Likewise.
6886 * termhooks.h (struct input_event.timestamp): Likewise.
6887 (struct terminal.mouse_position_hook): Likewise.
6888 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6889 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6890 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6891 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6892 what it was before.
6893 * menu.h, termhooks.h: Include "systime.h", for Time.
6894
8e55734a
PE
6895 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6896 Don't assume that the difference between two unsigned long values
6897 can fit into an integer. At this point, we know button_down_time
6898 <= event->timestamp, so the difference must be nonnegative, so
6899 there's no need to cast the result if double-click-time is
6900 nonnegative, as it should be; check that it's nonnegative, just in
6901 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6902 apart (about 25 days). (Bug#8664)
8e55734a 6903
841f1b75 6904 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6905 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6906
3e26f69c
PE
6907 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6908 that always fit in int. Use a sentinel instead of a counter, to
6909 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6910 * frame.h (struct frame): Use int for menu_bar_items_used
6911 instead of EMACS_INT, since it always fits in int.
3e26f69c 6912
5cc152c0
PE
6913 * menu.c (grow_menu_items): Check for int overflow.
6914
d89eb65e
PE
6915 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6916
5235bd3e
PE
6917 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6918 Before, the code was not consistent. These values cannot exceed
6919 2**31 - 1 so there's no need to make them unsigned.
6920 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6921 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6922 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6923 as modifiers.
6924 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6925
bc827e23
PE
6926 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6927 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6928 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6929 presumably because the widths might not match.
6930
78eb494e
PE
6931 * window.c (size_window): Avoid needless test at loop start.
6932
04f2d78b
CB
69332011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6934
6935 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6936
d2fc7e3d 69372011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6938
6939 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6940
d2fc7e3d 69412011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6942
6943 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6944 `width' to `bar_area_x' and `bar_area_width', respectively.
6945 (x_scroll_run): Take account of fringe background extension.
6946
04f2d78b
CB
6947 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6948 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6949 `bar_area_width', respectively.
6950 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6951 background extension.
6952
79b70037
GM
69532011-05-10 Jim Meyering <meyering@redhat.com>
6954
6955 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6956
2f142cc5
JB
69572011-05-10 Juanma Barranquero <lekktu@gmail.com>
6958
6959 * image.c (Finit_image_library): Return t for built-in image types,
6960 like pbm and xbm. (Bug#8640)
6961
57679c86
AS
69622011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6963
6964 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6965
888c9e86
EZ
69662011-05-07 Eli Zaretskii <eliz@gnu.org>
6967
b0512a1d
EZ
6968 * w32console.c (Fset_screen_color): Doc fix.
6969 (Fget_screen_color): New function.
6970 (syms_of_ntterm): Defsubr it.
6971
7285dc67
EZ
6972 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6973 unlink the temporary file if Fcall_process didn't create it in the
6974 first place.
6975 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6976 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6977 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6978 cue to call_process_cleanup not to close that handle.
6979
4d3fcc8e
BK
69802011-05-07 Ben Key <bkey76@gmail.com>
6981
6982 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6983 one of two shell specific rules, either bootstrap-temacs-CMD or
6984 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6985 to the previous implementation of the bootstrap-temacs rule.
6986 The bootstrap-temacs-CMD rule is similar to the previous
6987 implementation of the bootstrap-temacs rule except that it
6988 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6989 variable.
6990
6991 These changes, along with some changes to nt/configure.bat,
6992 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6993 earlier fix to add support for --cflags and --ldflags options
6994 that include quotes so that it works whether make uses cmd or
6995 sh as the shell.
6996
b4289b64
MA
69972011-05-06 Michael Albinus <michael.albinus@gmx.de>
6998
6999 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
7000 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
7001 is a constant.
7002 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
7003 a string. Handle both cases.
7004 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
7005 (Fdbus_register_method): Use Qinvalid_function.
7006
af4c0e28
JB
70072011-05-06 Juanma Barranquero <lekktu@gmail.com>
7008
7009 * makefile.w32-in: Update dependencies.
7010 (LISP_H): Add inttypes.h and stdin.h.
7011 (PROCESS_H): Add unistd.h.
7012
c51453d9
EZ
70132011-05-06 Eli Zaretskii <eliz@gnu.org>
7014
7015 * lread.c: Include limits.h (fixes the MS-Windows build broken by
7016 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
7017
8ff0ac3c 70182011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 7019
4c4b566b
PE
7020 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
7021
aab2b9b5
PE
7022 * term.c (vfatal): Remove stray call to va_end.
7023 It's not needed and the C Standard doesn't allow it here anyway.
7024
c378da0b
PE
7025 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
7026 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
7027
288b08c7
PE
7028 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
7029 bytes.
7030
e3601888
PE
7031 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
7032
db6c0e74
PE
7033 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7034
dd5963ea
PE
7035 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
7036
88c9450f
PE
7037 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
7038
2f9442b8
PE
7039 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
7040
c032b5f8
PE
7041 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
7042 * charset.c (Fdefine_charset_internal): Don't initialize
7043 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 7044 32-bit int (Bug#8600).
a108c10b
PE
7045
7046 * lread.c (read_integer): Be more consistent with string-to-number.
7047 Use string_to_number to do the actual conversion; this avoids
7048 rounding errors and fixes some other screwups. Without this fix,
7049 for example, #x1fffffffffffffff was misread as -2305843009213693952.
7050 (digit_to_number): Move earlier, for benefit of read_integer.
7051 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 7052 not a digit in any supported base. (Bug#8602)
a108c10b 7053
ad5f9eea
PE
7054 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
7055
aec1708a
PE
7056 * dispnew.c (scrolling_window): Return 1 if we scrolled,
7057 to match comment at start of function. This also removes a
7058 GCC warning about overflow in a 32+64-bit port.
7059
47be4ab5
PE
7060 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
7061
371cac43
PE
7062 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
7063 Reported by Stefan Monnier in
7064 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
7065 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7066 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 7067
d01a7826
PE
7068 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
7069 (EMACS_UINTPTR): Likewise, with uintptr_t.
7070
7fd47d5c
PE
7071 * lisp.h: Prefer 64-bit EMACS_INT if available.
7072 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
7073 on 32-bit hosts that have 64-bit int, so that they can access
7074 large files.
122b0c86
PE
7075 However, temporarily disable this change unless the temporary
7076 symbol WIDE_EMACS_INT is defined.
7fd47d5c 7077
8727937b
PE
7078 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7079
8ac068ac
PE
7080 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7081 This removes an assumption that EMACS_INT and long are the same
7082 width as pointers. The assumption is true for Emacs porting targets
7083 now, but we want to make other targets possible.
7084 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7085 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7086 In the rest of the code, change types of integers that hold casted
7087 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7088 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7089 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7090 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7091 No need to cast type when ORing.
7092 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7093 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7094 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7095 assume EMACS_INT is the same width as char *.
7096 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7097 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7098 Remove no-longer-needed casts.
7099 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7100 (xg_tool_bar_help_callback, xg_make_tool_item):
7101 Use EMACS_INTPTR to hold an integer
7102 that will be cast to void *; this can avoid a GCC warning
7103 if EMACS_INT is not the same width as void *.
7104 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7105 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7106 (current_message_1, set_message_1):
7107 Use a local to convert to proper width without a cast.
7108 * xmenu.c (dialog_selection_callback): Likewise.
7109
ede49d71
PE
7110 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7111 Also, don't assume VALBITS / RAND_BITS is less than 5,
7112 and don't rely on undefined behavior when shifting a 1 left into
7113 the sign bit.
7114 * lisp.h (get_random): Change signature to match.
7115
2f30ecd0
PE
7116 * lread.c (hash_string): Use size_t, not int, for hash computation.
7117 Normally we prefer signed values; but hashing is special, because
7118 it's better to use unsigned division on hash table sizes so that
7119 the remainder is nonnegative. Also, size_t is the natural width
7120 for hashing into memory. The previous code used 'int', which doesn't
7121 retain enough info to hash well into very large tables.
7122 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7123
2a866e7b
PE
7124 * dbusbind.c: Don't possibly lose pointer info when converting.
7125 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7126 Use XPNTR rather than XHASH, so that the high-order bits of
7127 the pointer aren't lost when converting through void *.
7128
51639eac
PE
7129 * eval.c (Fautoload): Don't double-shift a pointer.
7130
92394119
PE
7131 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7132
dbdb9a7c
JB
71332011-05-06 Juanma Barranquero <lekktu@gmail.com>
7134
7135 * gnutls.c (DEF_GNUTLS_FN):
7136 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7137
db7a0b4f
AS
71382011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7139
7140 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7141 marker. (Bug#8610)
7142
cd394be1 71432011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
7144
7145 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7146 New version that can reserve upto 2GB of heap space.
7147
f7ff1b0f 71482011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
7149
7150 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7151
639c109b
TZ
71522011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7153
7154 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7155 `gnutls_certificate_set_x509_key_file'.
7156
d2127135
JB
71572011-05-05 Juanma Barranquero <lekktu@gmail.com>
7158
7159 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7160 Update dependencies.
7161
e968f4f3
JB
71622011-05-04 Juanma Barranquero <lekktu@gmail.com>
7163
7164 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7165 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7166 Remove unused parameter `fildes'.
7167 * process.c (read_process_output, send_process): Don't pass it.
7168
84d358f0
JB
71692011-05-04 Juanma Barranquero <lekktu@gmail.com>
7170
7171 Fix previous change: the library cache is defined in w32.c.
7172 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7173 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7174
0898ca10
JB
71752011-05-04 Juanma Barranquero <lekktu@gmail.com>
7176
7177 Implement dynamic loading of GnuTLS on Windows.
7178
7179 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7180 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7181 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7182 Declare.
7183
7184 * gnutls.c (Qgnutls_dll): Define.
7185 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7186 (gnutls_*): Declare function pointers.
7187 (init_gnutls_functions): New function to initialize function pointers.
7188 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7189 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7190 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7191 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7192 (emacs_gnutls_write, emacs_gnutls_read)
7193 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7194 (Fgnutls_available_p): New function.
7195 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7196 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7197 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7198
7199 * image.c: Include w32.h.
7200 (Vimage_type_cache): Delete.
7201 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7202 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7203 (w32_delayed_load): Move to w32.c.
7204
7205 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7206
7207 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7208 (w32_delayed_load): Move from image.c. When loading a library, record
7209 its filename in the :loaded-from property of the library id.
7210 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7211 Initialize and staticpro them.
7212 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7213
7214 * process.c: Include lisp.h before w32.h, not after.
7215 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7216 instead of gnutls_record_check_pending.
7217
7218 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7219
ff4de4aa
TZ
72202011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7221
7222 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7223 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7224 as passed in.
7225
abe95abb
JD
72262011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7227
7228 * xterm.c (x_set_frame_alpha): Do not set property on anything
7229 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7230
e16e55d4
JB
72312011-05-02 Juanma Barranquero <lekktu@gmail.com>
7232
7233 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7234
bafcf6a5
JB
72352011-05-02 Juanma Barranquero <lekktu@gmail.com>
7236
7237 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7238 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7239 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7240 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7241 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7242 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7243 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7244 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7245 (Qgnutls_bootprop_callbacks_verify): Make static.
7246
e7a6747f
AS
72472011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7248
19ed11ba
AS
7249 * callproc.c: Indentation fixup.
7250
e7a6747f 7251 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
7252 (wait_for_termination, interruptible_wait_for_termination):
7253 Move after wait_for_termination_1.
e7a6747f 7254
1ef14cb4
LMI
72552011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7256
7257 * sysdep.c (interruptible_wait_for_termination): New function
7258 which is like wait_for_termination, but allows keyboard
7259 interruptions.
7260
7261 * callproc.c (Fcall_process): Add (:file "file") as an option for
7262 the STDOUT buffer.
7263 (Fcall_process_region): Ditto.
7264
330d880c
EZ
72652011-04-30 Eli Zaretskii <eliz@gnu.org>
7266
8db90b73
EZ
7267 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7268 rather than `XVECTOR (FOO)->size'.
7269
330d880c
EZ
7270 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7271 inttypes.h, as a gnulib replacement is used if it not available in
7272 system headers.
7273
15cbd324
EZ
72742011-04-21 Eli Zaretskii <eliz@gnu.org>
7275
7276 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7277 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7278 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7279
7280 * coding.c (coding_alloc_by_realloc): Error out if destination
7281 will grow beyond MOST_POSITIVE_FIXNUM.
7282 (decode_coding_emacs_mule): Abort if there isn't enough place in
7283 charbuf for the composition carryover bytes. Reserve an extra
7284 space for up to 2 characters produced in a loop.
7285 (decode_coding_iso_2022): Abort if there isn't enough place in
7286 charbuf for the composition carryover bytes.
7287
72882011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 7289
ae940cca
EZ
7290 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7291 aborting when %lld or %lll format is passed.
7292 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7293 %llo or %llx format is passed. (Bug#8545)
7294
03ab8921
EZ
7295 * window.c (window_scroll_line_based): Use a marker instead of
7296 simple variables to record original value of point. (Bug#7952)
7297
afda1437
EZ
7298 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7299 produced by %s or %c overflows available buffer space. (Bug#8545)
7300
f76dee0c
PE
73012011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7302
7303 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 7304 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 7305
fdc5744d
JB
73062011-04-28 Juanma Barranquero <lekktu@gmail.com>
7307
7308 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7309
638f053a
JB
73102011-04-28 Juanma Barranquero <lekktu@gmail.com>
7311
7312 * keyboard.c (Qdelayed_warnings_hook): Define.
7313 (command_loop_1): Run `delayed-warnings-hook'
7314 if Vdelayed_warnings_list is non-nil.
7315 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7316 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7317
d178f871
EZ
73182011-04-28 Eli Zaretskii <eliz@gnu.org>
7319
7320 * doprnt.c (doprnt): Don't return value smaller than the buffer
7321 size if the message was truncated. (Bug#8545).
7322
b124fd93
JB
73232011-04-28 Juanma Barranquero <lekktu@gmail.com>
7324
7325 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7326 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7327
e810457d
PE
73282011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7329
7330 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7331
ea51cceb
JB
73322011-04-27 Juanma Barranquero <lekktu@gmail.com>
7333
7334 * makefile.w32-in: Update dependencies.
7335
94dcfacf
EZ
73362011-04-27 Eli Zaretskii <eliz@gnu.org>
7337
7338 Improve `doprnt' and its usage. (Bug#8545)
7339 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7340 `format_end'. Remove support for %l as a conversion specifier.
7341 Don't use xrealloc. Improve diagnostics when the %l size modifier
7342 is used. Update the commentary.
7343
7344 * eval.c (verror): Simplify calculation of size_t.
7345
7346 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7347 messages.
7348
f61f41d7
PE
73492011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7350
7351 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7352 change.
7353
96fb4434
PE
73542011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7355
7356 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7357 This makes this file independent of the recent pseudovector change.
7358
671875da 73592011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 7360
69e9b5a3
PE
7361 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7362
b5f869a7 7363 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 7364 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 7365 Remove unused local.
c8926152 7366 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 7367
841a1577 7368 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
7369 GCC 4.6.0 optimizes based on type-based alias analysis.
7370 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
7371 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7372 != &v->size, and therefore "v->size = 1; b->size = 2; return
7373 v->size;" must therefore return 1. This assumption is incorrect
7374 for Emacs, since it type-puns struct Lisp_Vector * with many other
7375 types. To fix this problem, this patch adds a new type struct
f904488f 7376 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
7377 and pseudovectors, and helps optimizing compilers not get fooled
7378 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7379 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
7380 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7381 the size member.
eab3844f
PE
7382 (XSETPVECTYPE): Rewrite in terms of new macro.
7383 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7384 This is a bit clearer, and further avoids the possibility of
7385 undesirable aliasing.
7386 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 7387 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
7388 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7389 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
7390 (ASIZE): Now uses header.size rather than size.
7391 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7392 to avoid the hassle of writing XVECTOR (foo)->header.size.
7393 (struct vectorlike_header): New type.
eab3844f
PE
7394 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7395 object, to help avoid aliasing.
7396 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7397 (SUBRP): Likewise, since Lisp_Subr is a special case.
7398 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7399 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7400 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7401 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7402 changed to be "header.size" and "header.next".
7403 * buffer.h (struct buffer): Likewise.
7404 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7405 * frame.h (struct frame): Likewise.
7406 * process.h (struct Lisp_Process): Likewise.
7407 * termhooks.h (struct terminal): Likewise.
7408 * window.c (struct save_window_data, struct saved_window): Likewise.
7409 * window.h (struct window): Likewise.
7410 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7411 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7412 * buffer.c (init_buffer_once): Likewise.
7413 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7414 special case.
7415 * process.c (Fformat_network_address): Use local var for size,
7416 for brevity.
7417
0df1eac5
PE
7418 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7419
847ab9d1 7420 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7421 * data.c (atof): Remove decl; no longer used or needed.
7422 (digit_to_number): Move to lread.c.
7423 (Fstring_to_number): Use new string_to_number function, to be
7424 consistent with how the Lisp reader treats infinities and NaNs.
7425 Do not assume that floating-point numbers represent EMACS_INT
7426 without losing information; this is not true on most 64-bit hosts.
7427 Avoid double-rounding errors, by insisting on integers when
7428 parsing non-base-10 numbers, as the documentation specifies.
7429 * lisp.h (string_to_number): New decl, replacing ...
7430 (isfloat_string): Remove.
bc0a5c13 7431 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7432 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7433 appears to have been a coding error. Similarly, do not accept
7434 strings like +-1e0 as floating point numbers. Do not report
7435 overflow for integer overflows unless the base is not 10 which
7436 means we have no simple and reliable way to continue.
7437 Break out the floating-point parsing into a new
7438 function string_to_number, so that Fstring_to_number parses
7439 floating point numbers consistently with the Lisp reader.
04f2d78b 7440 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7441 (E_CHAR, EXP_INT): Remove, replacing with ...
7442 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7443 (string_to_number): New function, replacing isfloat_string.
7444 This function checks for valid syntax and produces the resulting
7445 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7446 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7447 so that overflow for non-base-10 numbers is reported only when
7448 there's no portable and simple way to convert to floating point.
452f4150 7449
67769ffc
PE
7450 * textprop.c (set_text_properties_1): Rewrite for clarity,
7451 and to avoid GCC warning about integer overflow.
7452
c20db43f
PE
7453 * intervals.h (struct interval): Use EMACS_INT for members
7454 where EMACS_UINT might cause problems. See
7455 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7456 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7457 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7458 All uses changed.
37aa2f85
PE
7459 (offset_intervals): Tell GCC not to worry about length overflow
7460 when negating a negative length.
c20db43f 7461
2538aa2f
PE
7462 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7463 (overrun_check_free): Likewise.
7464
f2d3008d
PE
7465 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7466 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7467 word size.
7468
ec8df744
PE
7469 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7470 (gnutls_make_error): Rename local to avoid shadowing.
7471 (gnutls_emacs_global_deinit): ifdef out; not used.
7472 (Fgnutls_boot): Use const for pointer to readonly storage.
7473 Comment out unused local. Fix pointer signedness problems.
7474
640ee02d
PE
7475 * lread.c (openp): Don't stuff size_t into an 'int'.
7476 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7477 about possible signed overflow.
7478
6048fb2a
PE
7479 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7480 (GDK_KEY_g): Don't define if already defined.
7481 (xg_prepare_tooltip): Avoid pointer signedness problem.
7482 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7483
fa3c87e1
PE
7484 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7485 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7486
2172544b
PE
7487 * xfns.c (Fx_window_property): Simplify a bit,
7488 to make a bit faster and to avoid GCC 4.6.0 warning.
7489 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7490
9b821a21
PE
7491 * fns.c (internal_equal): Don't assume size_t fits in int.
7492
3c616cfa
PE
7493 * alloc.c (compact_small_strings): Tighten assertion a little.
7494
c2982e87
PE
7495 Replace pEd with more-general pI, and fix some printf arg casts.
7496 * lisp.h (pI): New macro, generalizing old pEd macro to other
7497 conversion specifiers. For example, use "...%"pI"d..." rather
7498 than "...%"pEd"...".
7499 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7500 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7501 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7502 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7503 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7504 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7505 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7506 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7507 64-bit hosts.
7508 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7509 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7510 * print.c (safe_debug_print, print_object): Likewise.
7511 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7512 to int.
6f04d126
PE
7513 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7514 avoiding the 0 flag, which is not portable.
c2982e87
PE
7515 * process.c (Fmake_network_process): Use pI to avoid cast.
7516 * region-cache.c (pp_cache): Likewise.
7517 * xdisp.c (decode_mode_spec): Likewise.
7518 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7519 behavior on 64-bit hosts with printf arg.
6f04d126 7520 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7521 (x_stop_queuing_selection_requests): Likewise.
7522 (x_get_window_property): Don't truncate byte count to an 'int'
7523 when tracing.
0b432f21 7524
5e073ec7
PE
7525 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7526 here, since it parses constructs like leading '-' and spaces,
7527 which are not wanted; and it overflows with large numbers.
7528 Instead, simply match F[0-9]+, which is what is wanted anyway.
7529
36372bf9
PE
7530 * alloc.c: Remove unportable assumptions about struct layout.
7531 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7532 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7533 (allocate_vectorlike, make_pure_vector): Use the new macros,
7534 plus offsetof, to remove unportable assumptions about struct layout.
7535 These assumptions hold on all porting targets that I know of, but
7536 they are not guaranteed, they're easy to remove, and removing them
7537 makes further changes easier.
7538
0b432f21
PE
7539 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7540 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7541 (string_overrun_cookie): Now const. Use initializers that
7542 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7543 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7544 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7545 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7546 multiple of sizeof (EMACS_INT); it need not be, if
7547 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7548 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7549
895009e1
JB
75502011-04-26 Juanma Barranquero <lekktu@gmail.com>
7551
7552 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7553
6a7a1b0b
TZ
75542011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7555
7556 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7557 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7558 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7559
841a1577 75602011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7561
7562 * lisp.h (Qdebug): List symbol.
895009e1 7563 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7564 * keyboard.c (debug-on-event): New variable.
7565 (handle_user_signal): Break into debugger when debug-on-event
7566 matches the current signal symbol.
7567
f2d3ba6f
DN
75682011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7569
7570 * alloc.c (check_sblock, check_string_bytes)
7571 (check_string_free_list): Convert to standard C.
7572
42ce4c63
TZ
75732011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7574
7575 * w32.c (emacs_gnutls_push): Fix typo.
7576
825cd63c
EZ
75772011-04-25 Eli Zaretskii <eliz@gnu.org>
7578
fb11d64d
EZ
7579 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7580 "cast to pointer from integer of different size".
7581
825cd63c
EZ
7582 Improve doprnt and its use in verror. (Bug#8545)
7583 * doprnt.c (doprnt): Document the set of format control sequences
7584 supported by the function. Use SAFE_ALLOCA instead of always
7585 using `alloca'.
7586
7587 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7588 is one byte too soon. Don't use xrealloc; instead xfree and
7589 xmalloc anew.
7590
e061a11b
TZ
75912011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7592
7593 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7594 callbacks stage.
7595
7596 * gnutls.c: Renamed global_initialized to
7597 gnutls_global_initialized. Added internals for the
7598 :verify-hostname-error, :verify-error, and :verify-flags
7599 parameters of `gnutls-boot' and documented those parameters in the
7600 docstring. Start callback support.
9173deec
JB
7601 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7602 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7603 on error. Return error code.
e061a11b
TZ
7604 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7605 (emacs_gnutls_read): Likewise.
7606 (Fgnutls_boot): Return handshake error code.
7607 (emacs_gnutls_handle_error): New function.
7608 (wsaerror_to_errno): Likewise.
7609
7610 * w32.h (emacs_gnutls_pull): Add prototype.
7611 (emacs_gnutls_push): Likewise.
7612
7613 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7614 (emacs_gnutls_push): Likewise.
7615
76162011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7617
7618 * process.c (wait_reading_process_output): Check if GnuTLS
7619 buffered some data internally if no FDs are set for TLS
7620 connections.
7621
7622 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7623 (LIBS): Link to USER_LIBS.
7624 ($(BLD)/gnutls.$(0)): New target.
7625
fa6996bc
EZ
76262011-04-24 Eli Zaretskii <eliz@gnu.org>
7627
eb35682e
EZ
7628 * xdisp.c (handle_single_display_spec): Rename the
7629 display_replaced_before_p argument into display_replaced_p, to
7630 make it consistent with the commentary. Fix typos in the
7631 commentary.
7632
e2ad650c
EZ
7633 * textprop.c (syms_of_textprop): Remove dead code.
7634 (copy_text_properties): Delete obsolete commentary about an
7635 interface that was deleted long ago. Fix typos in the description
7636 of arguments.
7637
1b2de274
EZ
7638 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7639 to changes in oldXMenu/XMenu.h from 2011-04-16.
7640 <menu_help_message, prev_menu_help_message>: Constify.
7641 (IT_menu_make_room): menu->help_text is now `const char **';
7642 adjust.
7643
7644 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7645 to changes in oldXMenu/XMenu.h from 2011-04-16.
7646 (struct XMenu): Declare `help_text' `const char **'.
7647
7648 * xfaces.c <Qunspecified>: Make extern again.
7649
7650 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 7651 required by POSIX.
1b2de274 7652
762b15be
EZ
7653 * doc.c (get_doc_string): Improve the format passed to `error'.
7654
7655 * doprnt.c (doprnt): Improve commentary.
7656
7657 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7658
7659 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7660 them with etags.
7661
f1052e5d
EZ
7662 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7663 changes in globals.h immediately force recompilation.
762b15be
EZ
7664 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7665 $(CURDIR)/s/ms-w32.h.
7666 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7667
fa6996bc
EZ
7668 * character.c (Fchar_direction): Function deleted.
7669 (syms_of_character): Don't defsubr it.
7670 <char-direction-table>: Deleted.
7671
e6c3da20
EZ
76722011-04-23 Eli Zaretskii <eliz@gnu.org>
7673
7674 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7675 * doprnt.c: Include limits.h.
7676 (SIZE_MAX): New macro.
04f2d78b
CB
7677 (doprnt): Return a size_t value. 2nd arg is now size_t.
7678 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7679 Improve overflow protection. Support `l' modifier for integer
7680 conversions. Support %l conversion. Don't assume an EMACS_INT
7681 argument for integer conversions and for %c.
7682
7683 * lisp.h (doprnt): Restore prototype.
7684
7685 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7686 $(SRC)/character.h.
7687
7688 * Makefile.in (base_obj): Add back doprnt.o.
7689
7690 * deps.mk (doprnt.o): Add back prerequisites.
7691 (callint.o): Depend on character.h.
7692
7693 * eval.c (internal_lisp_condition_case): Include the handler
7694 representation in the error message.
7695 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7696 when breaking from the loop.
7697
7698 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7699
7700 * callint.c (Fcall_interactively): When displaying error message
7701 about invalid control letter, pass the character's codepoint, not
7702 a pointer to its multibyte form. Improve display of the character
7703 in octal and display also its hex code.
7704
7705 * character.c (char_string): Use %x to display the (unsigned)
7706 codepoint of an invalid character, to avoid displaying a bogus
7707 negative value.
7708
7709 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7710 `error', not SYMBOL_NAME itself.
7711
7712 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7713 character arguments to `error'.
7714
7715 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7716 to `error' in error message about FINAL_CHAR argument. Make sure
7717 FINAL_CHAR is a character, and use %c when it is passed as
7718 argument to `error'.
7719
4ffd0d6b 77202011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7721
7722 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7723
7724 * w32.c: Include <time.h>.
7725 (sys_localtime): New function.
7726
4ffd0d6b 77272011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7728
7729 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7730
4ffd0d6b 7731 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7732
4ffd0d6b 77332011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7734
4ffd0d6b
GM
7735 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7736 zombies (Bug#8467).
aac0c6e3 7737
04c56954
EZ
77382011-04-19 Eli Zaretskii <eliz@gnu.org>
7739
7740 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7741 gl_state.e_property when gl_state.object is Qt.
7742
7743 * insdel.c (make_gap_larger): Remove limitation of buffer size
7744 to <= INT_MAX.
7745
16a43933
CY
77462011-04-18 Chong Yidong <cyd@stupidchicken.com>
7747
7748 * xdisp.c (lookup_glyphless_char_display)
7749 (produce_glyphless_glyph): Handle cons cell entry in
7750 glyphless-char-display.
7751 (Vglyphless_char_display): Document it.
7752
7753 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7754 glyphless-char-display.
7755
4581706e
CY
77562011-04-17 Chong Yidong <cyd@stupidchicken.com>
7757
7758 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7759
7760 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7761
7762 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7763 definition for no-X builds.
7764
4887c6e2 77652011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7766
fd35b6f9
PE
7767 Static checks with GCC 4.6.0 and non-default toolkits.
7768
5c1ccb01
PE
7769 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7770
006c5daa
PE
7771 * process.c (keyboard_bit_set): Define only if SIGIO.
7772 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7773 (send_process): Repair possible setjmp clobbering.
7774
efc736d3
PE
7775 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7776
4e2fe2e6
PE
7777 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7778
f97334a2
PE
7779 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7780
4e75f29d
PE
7781 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7782 Define only if needed.
7783
90efadd1
PE
7784 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7785 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7786 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7787
3c647824
PE
7788 * dispextern.h (struct redisplay_interface): Rename param
7789 to avoid shadowing.
e264f262 7790 * termhooks.h (struct terminal): Likewise.
761383f4 7791 * xterm.c (xembed_send_message): Likewise.
3c647824 7792
b58c5c4a
PE
7793 * insdel.c (make_gap_smaller): Define only if
7794 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7795
cad59032
PE
7796 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7797 it.
7798
c339dc2e
PE
7799 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7800 so that we aren't warned about unused symbols.
7801
91a3e27b
PE
7802 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7803
399c71d3 7804 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7805
8ffc96f5
PE
7806 * xfns.c (x_real_positions): Mark locals as initialized.
7807
eef9bc79
PE
7808 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7809
098db9dd
PE
7810 * xterm.c: Fix problems found by static analysis with other toolkits.
7811 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7812 (x_dispatch_event): Declare static if USE_GTK, and
7813 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7814 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7815 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7816 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7817 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7818
eb18f6cc
PE
7819 * xmenu.c (menu_help_callback): Pointer type fixes.
7820 Use const pointers when pointing at readonly data. Avoid pointer
7821 signedness clashes.
7822 (FALSE): Remove unused macro.
7823 (update_frame_menubar): Remove unused decl.
7824
1fe72bf8
PE
7825 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7826
60d9e1db
PE
7827 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7828 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7829 (single_menu_item): Rename local to avoid shadowing.
7830
39261c26
PE
7831 * keyboard.c (make_lispy_event): Remove unused local var.
7832
018c5e19
PE
7833 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7834 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7835
63d2b86e
PE
7836 * bitmaps: Change bitmaps from unsigned char back to the X11
7837 compatible char. Avoid the old compiler warnings about
7838 out-of-range initializers by using, for example, '\xab' rather
7839 than 0xab.
7840
aefd87e1
PE
7841 * xgselect.c (xgselect_initialize): Check vs interface
7842 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7843
bf501fb9
PE
7844 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7845
e9829fdf
PE
7846 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7847 to read-only memory.
7848
1086c095
PE
7849 * fns.c (vector): Remove; this old hack is no longer needed.
7850
2baccd04 7851 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7852 Remove unused var.
dde42981 7853 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7854
72391843 7855 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7856
436c16df 7857 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7858 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7859 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7860
92bb796d 7861 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7862 (x_term_init): Remove local to avoid shadowing.
92bb796d 7863
764430a3 7864 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7865
7866 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7867 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7868
d1dfb56c
EZ
78692011-04-16 Eli Zaretskii <eliz@gnu.org>
7870
c4354cb4
EZ
7871 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7872
d1dfb56c
EZ
7873 Fix regex.c, syntax.c and friends for buffers > 2GB.
7874 * syntax.h (struct gl_state_s): Declare character position members
7875 EMACS_INT.
7876
7877 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7878
04f2d78b
CB
7879 * textprop.c (verify_interval_modification, interval_of):
7880 Declare arguments EMACS_INT.
d1dfb56c
EZ
7881
7882 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7883 EMACS_INT.
7884
7885 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7886
7887 * indent.c (Fvertical_motion): Local variable it_start is now
7888 EMACS_INT.
7889
7890 * regex.c (re_match, re_match_2, re_match_2_internal)
7891 (bcmp_translate, regcomp, regexec, print_double_string)
7892 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7893 (re_compile_pattern, re_exec): Declare arguments and local
7894 variables `size_t' and `ssize_t' and return values `regoff_t', as
7895 appropriate.
7896 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7897 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7898 <compile_stack_type>: `size' and `avail' are now `size_t'.
7899
7900 * regex.h <regoff_t>: Use ssize_t, not int.
7901 (re_search, re_search_2, re_match, re_match_2): Arguments that
7902 specify buffer/string position and length are now ssize_t and
7903 size_t. Return type is regoff_t.
7904
613052cd
BK
79052011-04-16 Ben Key <bkey76@gmail.com>
7906
7907 * nsfont.m: Fixed bugs in ns_get_family and
7908 ns_descriptor_to_entity that were caused by using free to
7909 deallocate memory blocks that were allocated by xmalloc (via
7910 xstrdup). This caused Emacs to crash when compiled with
7911 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7912 --enable-checking=xmallocoverrun). xfree is now used to
7913 deallocate these memory blocks.
7914
4170f62f 79152011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7916
71b41406
PE
7917 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7918
9587a89d
PE
7919 emacs_write: Accept and return EMACS_INT for sizes.
7920 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7921 et seq.
7922 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7923 Accept and return EMACS_INT.
7924 (emacs_gnutls_write): Return the number of bytes written on
7925 partial writes.
7926 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7927 (emacs_read, emacs_write): Remove check for negative size, as the
7928 Emacs source code has been audited now.
9587a89d
PE
7929 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7930 (emacs_read, emacs_write): Use it.
273a5f82
PE
7931 * process.c (send_process): Adjust to the new signatures of
7932 emacs_write and emacs_gnutls_write. Do not attempt to store
7933 a byte offset into an 'int'; it might overflow.
9587a89d 7934 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7935
3e047f51
PE
7936 * sound.c: Don't assume sizes fit in 'int'.
7937 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7938 Return EMACS_INT, not int.
3e047f51 7939 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7940 Accept EMACS_INT, not int.
7941 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7942 record read return values.
7943
cc39a9db
BK
79442011-04-15 Ben Key <bkey76@gmail.com>
7945
c9d0ec6d
JB
7946 * keyboard.c (Qundefined): Don't declare static since it is used
7947 in nsfns.m.
7948 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7949 static since they are used in nsfont.m.
cc39a9db 7950
6c60eb9f
SM
79512011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7952
7953 * process.c (Qprocessp): Don't declare static.
7954 * lisp.h (Qprocessp): Declare again.
7955
7990b61a
JB
79562011-04-15 Juanma Barranquero <lekktu@gmail.com>
7957
7958 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7959
5d4cb038
PE
79602011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7961
8bd7b830 7962 Improve C-level modularity by making more things 'static'.
cd64ea1d 7963
e3b27b31
PE
7964 Don't publish debugger-only interfaces to other modules.
7965 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7966 (verify_bytepos, count_markers): Move decls to the only modules
7967 that need them.
7968 * region-cache.h (pp_cache): Likewise.
7969 * window.h (check_all_windows): Likewise.
7970 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7971
5d4cb038
PE
7972 * sysdep.c (croak): Now static, if
7973 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7974 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7975
7976 * alloc.c (refill_memory_reserve): Now static if
7977 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7978 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7979
e87b6180
PE
7980 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7981 Define only if USE_LUCID.
7982
ac64929e
PE
7983 * xrdb.c (x_customization_string, x_rm_string): Now static.
7984
6f37259d
PE
7985 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7986 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7987
1683e3ab
PE
7988 * xdisp.c (draw_row_with_mouse_face): Now static.
7989 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7990
de9c2632
PE
7991 * window.h (check_all_windows): Mark externally visible.
7992
2b96acb7
PE
7993 * window.c (window_deletion_count): Now static.
7994
7995 * undo.c: Make symbols static if they're not exported.
7996 (last_undo_buffer, last_boundary_position, pending_boundary):
7997 Now static.
7998
50436f33
PE
7999 * textprop.c (interval_insert_behind_hooks): Now static.
8000 (interval_insert_in_front_hooks): Likewise.
8001
64520e5c
PE
8002 * term.c: Make symbols static if they're not exported.
8003 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
8004 (max_frame_lines, tty_set_terminal_modes):
8005 (tty_reset_terminal_modes, tty_turn_off_highlight):
8006 (get_tty_terminal): Now static.
8007 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
8008 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 8009 HAVE_WINDOW_SYSTEM.
64520e5c
PE
8010 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
8011 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
8012
1fa53021
PE
8013 * sysdep.c: Make symbols static if they're not exported.
8014 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
8015 Now static.
8016 (sigprocmask_set, full_mask): Remove; unused.
8017 (wait_debugging): Mark as visible.
8018 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
8019 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
8020
d4b43b22
PE
8021 * syntax.c (syntax_temp): Define only if !__GNUC__.
8022
b7c513d0
PE
8023 * sound.c (current_sound_device, current_sound): Now static.
8024
989b29ad
PE
8025 * search.c (searchbufs, searchbuf_head): Now static.
8026
13a55a78
PE
8027 * scroll.c (scroll_cost): Remove; unused.
8028 * dispextern.h (scroll_cost): Remove decl.
8029
de68a1fc
PE
8030 * region-cache.h (pp_cache): Mark as externally visible.
8031
40ccffa6
PE
8032 * process.c: Make symbols static if they're not exported.
8033 (process_tick, update_tick, create_process, chan_process):
8034 (Vprocess_alist, proc_buffered_char, datagram_access):
8035 (fd_callback_data, send_process_frame, process_sent_to): Now static.
8036 (deactivate_process): Mark defn as static, as well as decl.
8037 * lisp.h (create_process): Remove decl.
8038 * process.h (chan_process, Vprocess_alist): Remove decls.
8039
ad64fc97
PE
8040 * print.c: Make symbols static if they're not exported.
8041 (print_depth, new_backquote_output, being_printed, print_buffer):
8042 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
8043 (print_interval, print_number_index, initial_stderr_stream):
8044 Now static.
8045 * lisp.h (Fprinc): Remove decl.
8046 (debug_output_compilation_hack): Mark as externally visible.
8047
adddb265
PE
8048 * sysdep.c (croak): Move decl from here to syssignal.h.
8049 * syssignal.h (croak): Put it here, so the API can be checked when
8050 'croak' is called from dissociate_if_controlling_tty.
8051
1717ede2
PE
8052 * minibuf.c: Make symbols static if they're not exported.
8053 (minibuf_save_list, choose_minibuf_frame): Now static.
8054 * lisp.h (choose_minibuf_frame): Remove decl.
8055
fa5fb2bc
PE
8056 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
8057
1e3890d1
PE
8058 * lread.c: Make symbols static if they're not exported.
8059 (read_objects, initial_obarray, oblookup_last_bucket_number):
8060 Now static.
8061 (make_symbol): Remove; unused.
8062 * lisp.h (initial_obarray, make_symbol): Remove decls.
8063
8a1414fa
PE
8064 * keyboard.c: Make symbols static if they're not exported.
8065 (single_kboard, recent_keys_index, total_keys, recent_keys):
8066 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
8067 (this_single_command_key_start, echoing, last_auto_save):
8068 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
8069 (command_loop, echo_now, keyboard_init_hook, help_char_p):
8070 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
8071 (Vlispy_mouse_stem, double_click_count):
8072 Now static.
8073 (force_auto_save_soon): Define only if SIGDANGER.
8074 (ignore_mouse_drag_p): Now static if
8075 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
8076 (print_help): Remove; unused.
8077 (stop_character, last_timer_event): Mark as externally visible.
8078 * keyboard.h (ignore_mouse_drag_p): Declare only if
8079 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8080 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8081 * lisp.h (echoing): Remove decl.
8082 (force_auto_save_soon): Declare only if SIGDANGER.
8083 * xdisp.c (redisplay_window): Simplify code, to make it more
8084 obvious that ignore_mouse_drag_p is not accessed if !defined
8085 USE_GTK && !defined HAVE_NS.
8086
93ea6e8f
PE
8087 * intervals.c: Make symbols static if they're not exported.
8088 (merge_properties_sticky, merge_interval_right, delete_interval):
8089 Now static.
8090 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8091
77382fcc
PE
8092 * insdel.c: Make symbols static if they're not exported.
8093 However, leave prepare_to_modify_buffer alone. It's never
8094 called from outside this function, but that appears to be a bug.
8095 (combine_after_change_list, combine_after_change_buffer):
4889fc82 8096 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
8097 (adjust_after_replace_noundo): Remove; unused.
8098 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 8099 (signal_before_change): Remove decls.
77382fcc 8100
9306c32e
PE
8101 * indent.c (val_compute_motion, val_vmotion): Now static.
8102
cd44d2eb
PE
8103 * image.c: Make symbols static if they're not exported.
8104 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8105 if USE_GTK.
8106 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8107 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8108
ad9a7a06
PE
8109 * fringe.c (standard_bitmaps): Now static.
8110 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8111
81626931
PE
8112 * frame.c: Make symbols static if they're not exported.
8113 (x_report_frame_params, make_terminal_frame): Now static.
8114 (get_frame_param): Now static, unless HAVE_NS.
8115 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8116 (x_get_resource_string): Remove; not used.
8117 * frame.h (make_terminal_frame, x_report_frame_params):
8118 (x_get_resource_string); Remove decls.
8119 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8120 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8121
239f9db9
PE
8122 * font.c, fontset.c: Make symbols static if they're not exported.
8123 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8124 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8125 * font.c (font_close_object): Now static.
8126 * font.h (font_close_object): Remove.
8127 * fontset.c (FONTSET_OBJLIST): Remove.
8128 (free_realized_fontset) #if-0 the body, which does nothing.
8129 (face_suitable_for_char_p): #if-0, as it's never called.
8130 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
8131 * xfaces.c (face_at_string_position):
8132 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
8133 since 0 is always ASCII.
8134
dfcf3579
PE
8135 * fns.c (weak_hash_tables): Now static.
8136
5045092b
PE
8137 * fileio.c: Make symbols static if they're not exported.
8138 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8139 (Vwrite_region_annotation_buffers): Now static.
8140
57a96f5c
PE
8141 * eval.c: Make symbols static if they're not exported.
8142 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8143 * lisp.h (backtrace_list): Remove decl.
8144
35f08c38
PE
8145 * emacs.c: Make symbols static if they're not exported.
8146 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8147 (fatal_error_code, fatal_error_signal_hook, standard_args):
8148 Now static.
8149 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8150 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8151 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8152 * lisp.h (fatal_error_signal_hook): Remove decl.
8153 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8154
f44bd759
PE
8155 * editfns.c: Move a (normally-unused) function to its only use.
8156 * editfns.c, lisp.h (get_operating_system_release): Remove.
8157 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8158 worth the hassle of breaking this out.
8159
b532497d
PE
8160 * xterm.c: Make symbols static if they're not exported.
8161 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8162 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8163 (x_destroy_window, x_delete_display):
8164 Now static.
8165 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8166 (x_mouse_leave): Remove; unused.
8167 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8168 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8169 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8170 Remove decls.
8171 (x_mouse_leave): Declare only if WINDOWSNT.
8172 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8173 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8174 USE_X_TOOLKIT.
8175
1675728f
PE
8176 * ftxfont.c: Make symbols static if they're not exported.
8177 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8178 HAVE_FREETYPE.
8179 * font.h (ftxfont_driver): Likewise.
8180
e4cebfca
PE
8181 * xfns.c: Make symbols static if they're not exported.
8182 (x_last_font_name, x_display_info_for_name):
8183 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8184 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8185 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8186 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8187 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8188 (last_show_tip_args): Now static.
8189 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8190 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8191 (x_screen_planes): Remove; unused.
8192 * dispextern.h (x_screen_planes): Remove decl.
8193
5bf46f05
PE
8194 * dispnew.c: Make symbols static if they're not exported.
8195 * dispextern.h (redraw_garbaged_frames, scrolling):
8196 (increment_row_positions): Remove.
8197 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8198 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8199 Now static.
8200 (redraw_garbaged_frames): Remove; unused.
8201
435f4c28
PE
8202 * xfaces.c: Make symbols static if they're not exported.
8203 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8204 Remove decls.
8205 * xterm.h (defined_color): Remove decls.
8206 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8207 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8208 (menu_face_changed_default, defined_color, free_realized_face):
8209 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8210 (ascii_face_of_lisp_face): Remove; unused.
8211
8524aef3
PE
8212 * xdisp.c: Make symbols static if they're not exported.
8213 * dispextern.h (scratch_glyph_row, window_box_edges):
8214 (glyph_to_pixel_coords, set_cursor_from_row):
8215 (get_next_display_element, set_iterator_to_next):
8216 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8217 (show_mouse_face): Remove decls
8218 * frame.h (message_buf_print): Likewise.
8219 * lisp.h (pop_message, set_message, check_point_in_composition):
8220 Likewise.
8221 * xterm.h (set_vertical_scroll_bar): Likewise.
8222 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8223 (message_buf_print, scratch_glyph_row, displayed_buffer):
8224 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8225 (get_next_display_element, show_mouse_face, window_box_edges):
8226 (frame_to_window_pixel_xy, check_point_in_composition):
8227 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8228 (glyph_to_pixel_coords): Remove; unused.
8229
16390cd2
PE
8230 * dired.c (file_name_completion): Now static.
8231
8232 * dbusbind.c (xd_in_read_queued_messages): Now static.
8233
a25f4dfa
PE
8234 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8235 * data.c (circular_list_error): Remove.
8236
14a9c8df
PE
8237 * commands.h (last_point_position, last_point_position_buffer):
8238 (last_point_position_window): Remove decls.
8239 * keyboard.c: Make these variables static.
8240
04f2d78b
CB
8241 * coding.h (coding, code_convert_region, encode_coding_gap):
8242 Remove decls.
74ab6df5
PE
8243 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8244 (iso_code_class, detect_coding, code_convert_region): Now static.
8245 (encode_coding_gap): Remove; unused.
8246
38dfbee1
PE
8247 * chartab.c (chartab_chars, chartab_bits): Now static.
8248
a2cb4e63
PE
8249 * charset.h (charset_iso_8859_1): Remove decl.
8250 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8251 Now static.
8252
127198fd
PE
8253 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8254 * ccl.c (Vccl_program_table): Now static.
8255 (check_ccl_update): Remove; unused.
8256
d85b608f
PE
8257 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8258 * category.h: ... from here.
8259 * category.c (check_category_table, set_category_set): Now static.
8260
31cd66f3
PE
8261 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8262 * lisp.h: Remove these decls.
8263
c358e587
PE
8264 * buffer.c (buffer_count): Remove unused var.
8265
e78aecca
PE
8266 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8267 so that it's not optimized away.
8268 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8269 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8270 exported only to the debugger.
8271
e192d7d3 8272 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 8273 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 8274
92470028
PE
8275 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8276 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8277 was inaccessible from Lisp.
8278 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8279 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8280
244ed907
PE
8281 alloc.c: Import and export fewer symbols, and remove unused items.
8282 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8283 is defined.
8284 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8285 it's not optimized away by whole-program optimization.
8286 (message_enable_multibyte, free_misc): Remove.
8287 (catchlist, handlerlist, mark_backtrace):
8288 Declare only if BYTE_MARK_STACK.
8289 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8290 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8291 (message_enable_multibyte): Remove decl.
8292 (free_misc, interval_free_list, float_block, float_block_index):
8293 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8294 (cons_free_list, last_marked_index):
8295 Now static.
8296 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8297 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8298 (mark_backtrace): Define only if BYTE_MARK_STACK.
8299 * xdisp.c (message_enable_multibyte): Now static.
8300
61c2b50e 8301 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
8302 This makes it easier for human readers (and static analyzers)
8303 to see whether these variables are used from other modules.
8304 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8305 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8306 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8307 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8308 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8309 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8310 * xmenu.c, xselect.c:
8311 Declare Q* vars static if they are not used in other modules.
8312 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8313 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8314 Remove decls of unexported vars.
8315 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8316
95c82688
PE
8317 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8318
16a97296
PE
8319 Make Emacs functions such as Fatom 'static' by default.
8320 This makes it easier for human readers (and static analyzers)
8321 to see whether these functions can be called from other modules.
8322 DEFUN now defines a static function. To make the function external
8323 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
8324 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8325 (Finit_image_library):
16a97296
PE
8326 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8327 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8328 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8329 Remove decls, since these functions are now static.
8330 (Funintern, Fget_internal_run_time): New decls, since these functions
8331 were already external.
95c82688 8332
16a97296
PE
8333 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8334 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8335 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8336 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8337 * keyboard.c, keymap.c, lread.c:
8338 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8339 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8340 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8341 Mark functions with DEFUE instead of DEFUN,
8342 if they are used in other modules.
8343 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8344 decls for now-static functions.
8345 * buffer.h (Fdelete_overlay): Remove decl.
8346 * callproc.c (Fgetenv_internal): Mark as internal.
8347 * composite.c (Fremove_list_of_text_properties): Remove decl.
8348 (Fcomposition_get_gstring): New forward static decl.
8349 * composite.h (Fcomposite_get_gstring): Remove decl.
8350 * dired.c (Ffile_attributes): New forward static decl.
8351 * doc.c (Fdocumntation_property): New forward static decl.
8352 * eval.c (Ffetch_bytecode): New forward static decl.
8353 (Funintern): Remove extern decl; now in .h file where it belongs.
8354 * fileio.c (Fmake_symbolic_link): New forward static decl.
8355 * image.c (Finit_image_library): New forward static decl.
8356 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8357 * intervals.h (Fprevious_property_change):
8358 (Fremove_list_of_text_properties): Remove decls.
8359 * keyboard.c (Fthis_command_keys): Remove decl.
8360 (Fcommand_execute): New forward static decl.
8361 * keymap.c (Flookup_key): New forward static decl.
8362 (Fcopy_keymap): Now static.
8363 * keymap.h (Flookup_key): Remove decl.
8364 * process.c (Fget_process): New forward static decl.
8365 (Fprocess_datagram_address): Mark as internal.
8366 * syntax.c (Fsyntax_table_p): New forward static decl.
8367 (skip_chars): Remove duplicate decl.
8368 * textprop.c (Fprevious_property_change): New forward static decl.
8369 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8370 Now internal.
8371 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8372 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8373
785bbd42
PE
8374 * editfns.c (Fformat): Remove unreachable code.
8375
8b913b57
AS
83762011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8377
8378 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8379 change. (Bug#8496)
8380
a6744a35
EZ
83812011-04-13 Eli Zaretskii <eliz@gnu.org>
8382
8383 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8384 when at ZV. (Bug#8487)
8385
e7974947
AS
83862011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8387
baad03f0
AS
8388 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8389 (Bug#8437)
8390 * keyboard.c (parse_tool_bar_item): Likewise.
8391 * sound.c (sound_cleanup, alsa_close): Likewise.
8392 * termcap.c (tgetent): Likewise.
8393 * xfns.c (x_default_font_parameter): Likewise.
8394 * xsettings.c (read_and_apply_settings): Likewise.
8395
e7974947
AS
8396 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8397 (overrun_check_free): Protoize.
8398
28272684
PE
83992011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8400
8401 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8402 since callers should never pass a negative size.
8403 Change the signature to match that of plain 'read' and 'write'; see
8404 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8405 * lisp.h: Update prototypes of emacs_write and emacs_read.
8406
11997c76
EZ
84072011-04-11 Eli Zaretskii <eliz@gnu.org>
8408
8409 * xdisp.c (redisplay_window): Don't try to determine the character
8410 position of the scroll margin if the window start point w->startp
e896f03c 8411 is outside the buffer's accessible region. (Bug#8468)
11997c76 8412
8a2cbd72
EZ
84132011-04-10 Eli Zaretskii <eliz@gnu.org>
8414
8415 Fix write-region and its subroutines for buffers > 2GB.
8416 * fileio.c (a_write, e_write): Modify declaration of arguments and
8417 local variables to support buffers larger than 2GB.
8418 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8419
8420 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8421 argument, local variables, and return value.
8422
8423 * lisp.h: Update prototypes of emacs_write and emacs_read.
8424
8425 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8426
4073e537 84272011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8428
1ebfdcb6
PE
8429 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8430
b2ded58d
PE
8431 Fix more problems found by GCC 4.6.0's static checks.
8432
7d66342c
PE
8433 * xdisp.c (vmessage): Use a better test for character truncation.
8434
bbf47d44
PE
8435 * charset.c (load_charset_map): <, not <=, for optimization,
8436 and to avoid potential problems with integer overflow.
9248994d 8437 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8438 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8439 * editfns.c (Fformat): Likewise.
1e69125e 8440 * syntax.c (skip_chars): Likewise.
3befa583 8441
e3019616
PE
8442 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8443 This also lets GCC 4.6.0 generate slightly better loop code.
8444
becfa255
PE
8445 * callint.c (Fcall_interactively): <, not <=, for optimization.
8446 (Fcall_interactively): Count the number of arguments produced,
8447 not the number of arguments given. This is simpler and lets GCC
8448 4.6.0 generate slightly better code.
8449
dae0cd48
PE
8450 * ftfont.c: Distingish more carefully between FcChar8 and char.
8451 The previous code passed unsigned char * to a functions like
8452 strlen and xstrcasecmp that expect char *, which does not
8453 conform to the C standard.
8454 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8455 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8456 char * when the C standard requires it.
8457
76032d70
PE
8458 * keyboard.c (read_char): Remove unused var.
8459
eb3f1cc8
PE
8460 * eval.c: Port to Windows vsnprintf (Bug#8435).
8461 Include <limits.h>.
8462 (SIZE_MAX): Define if the headers do not.
8463 (verror): Do not give up if vsnprintf returns a negative count.
8464 Instead, grow the buffer. This ports to Windows vsnprintf, which
8465 does not conform to C99. Problem reported by Eli Zaretskii.
8466 Also, simplify the allocation scheme, by avoiding the need for
8467 calling realloc, and removing the ALLOCATED variable.
8468
70476b54
PE
8469 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8470
12020a9e
PE
8471 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8472 But keep the doprint source code for now, as we might revamp it
8473 and use it again (Bug#8435).
ea6c7ae6
PE
8474 * lisp.h (doprnt): Remove.
8475 * Makefile.in (base_obj): Remove doprnt.o.
8476 * deps.mk (doprnt.o): Remove.
8477
5fdb398c
PE
8478 error: Print 32- and 64-bit integers portably (Bug#8435).
8479 Without this change, on typical 64-bit hosts error ("...%d...", N)
8480 was used to print both 32- and 64-bit integers N, which relied on
8481 undefined behavior.
61bdb816 8482 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8483 * lisp.h (error, verror): Mark as printf-like functions.
8484 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8485 Report overflow in size calculations when allocating printf buffer.
8486 Do not truncate output string at its first null byte.
8487 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8488 Truncate the output at a character boundary, since vsnprintf does not
8489 do that.
8490 * charset.c (check_iso_charset_parameter): Convert internal
8491 character to string before calling 'error', since %c now has the
8492 printf meaning.
8493 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8494 overflow when computing char to be passed to 'error'. Do not
8495 pass Lisp_Object to 'error'; pass the integer instead.
8496 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8497 formatted with plain %d.
8498
b189fa66
PE
8499 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8500
bff87ef0
PE
8501 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8502
7e2cac20
PE
8503 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8504
ce4d90b5
PE
8505 * xterm.c (x_catch_errors): Remove duplicate declaration.
8506
266c9547
PE
8507 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8508
79c49ad2
PE
8509 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8510
368f4090
JM
85112011-04-10 Jim Meyering <meyering@redhat.com>
8512
8513 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8514 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8515 return ssize_t not "int", and use size_t as the buffer length.
8516 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8517 * gnutls.h: Update declarations.
8518 * process.c (read_process_output): Use ssize_t, to match.
8519 (send_process): Likewise.
8520
a32d4040
CY
85212011-04-09 Chong Yidong <cyd@stupidchicken.com>
8522
8523 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8524
8546720e 85252011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8526
04f2d78b
CB
8527 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8528 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8529
8546720e
GM
8530 * xterm.c (handle_one_xevent):
8531 * xmenu.c (create_and_show_popup_menu):
8532 * xselect.c (x_decline_selection_request)
8533 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8534
0a2f5c1a 85352011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8536
8537 Fix some uses of `int' instead of EMACS_INT.
8538 * search.c (string_match_1, fast_string_match)
8539 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8540 (scan_buffer, find_next_newline_no_quit)
8541 (find_before_next_newline, search_command, Freplace_match)
8542 (Fmatch_data): Make some `int' variables be EMACS_INT.
8543
8544 * xdisp.c (display_count_lines): 3rd argument and return value now
8545 EMACS_INT. All callers changed.
8546 (pint2hrstr): Last argument is now EMACS_INT.
8547
8548 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8549 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8550 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8551 (decode_coding_utf_16, decode_coding_emacs_mule)
8552 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8553 (decode_coding_ccl, decode_coding_charset)
8554 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8555 (decode_coding_iso_2022, decode_coding_emacs_mule)
8556 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8557 <char_offset, last_offset>: Declare EMACS_INT.
8558 (encode_coding_utf_8, encode_coding_utf_16)
8559 (encode_coding_emacs_mule, encode_invocation_designation)
8560 (encode_designation_at_bol, encode_coding_iso_2022)
8561 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8562 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8563 Declare EMACS_INT.
8564 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8565 (encode_invocation_designation): Last argument P_NCHARS is now
8566 EMACS_INT.
8567 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8568 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8569
8570 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8571 All users changed.
8572
8573 * ccl.c (Fccl_execute_on_string): Declare some variables
8574 EMACS_INT.
8575
8546720e 85762011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8577
8578 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8579
4e19a977
CS
85802011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8581
8582 * process.c (Fformat_network_address): Doc fix.
8583
87302331
R
85842011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8585
ee7683eb 8586 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8587
cbb59342
CY
85882011-04-08 Chong Yidong <cyd@stupidchicken.com>
8589
8590 * keyboard.c (read_char): Call Lisp function help-form-show,
8591 instead of using internal_with_output_to_temp_buffer.
8592 (Qhelp_form_show): New var.
e0d38eeb 8593 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8594
8595 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8596
8597 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8598
e67a13ab
CY
85992011-04-06 Chong Yidong <cyd@stupidchicken.com>
8600
04f2d78b
CB
8601 * process.c (Flist_processes): Remove to Lisp.
8602 (list_processes_1): Delete.
e67a13ab 8603
973f782d
EZ
86042011-04-06 Eli Zaretskii <eliz@gnu.org>
8605
7c106b1e
EZ
8606 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8607
973f782d
EZ
8608 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8609
41cf7d1a 86102011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8611
ca23cc88
PE
8612 Fix more problems found by GCC 4.6.0's static checks.
8613
f390e2d5
PE
8614 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8615
42eea0d0
PE
8616 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8617
b69769da 8618 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8619
f9541e84
PE
8620 * xdisp.c (vmessage): Mark as a printf-like function.
8621
13841b55
PE
8622 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8623
c136c10f
PE
8624 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8625
5e2d4a30
PE
8626 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8627 printf-like functions.
8628 (tiff_load): Add casts to remove these marks before passing them
8629 to system-supplied API.
8630
583f48b9
PE
8631 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8632
b25d760e
PE
8633 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8634 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8635 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8636 directly, rather than having caller test rule sign. This avoids
8637 some unnecessary tests.
8638 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8639 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8640 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8641
bc7b6697 8642 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8643 (xfont_open): Avoid unnecessary tests.
bc7b6697 8644
27ccc379
PE
8645 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8646
dcd5c89a
PE
8647 * composite.h, composite.c (composition_gstring_put_cache):
8648 Use EMACS_INT, not int, for length.
8649
b13a45c6
PE
8650 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8651 breaking out part of COMPOSITION_DECODE_RULE.
8652 (COMPOSITION_DECODE_RULE): Use it.
8653 * composite.c (get_composition_id): Remove unused local vars,
8654 by using the new macro.
8655
1e792e4d
PE
8656 * textprop.c (set_text_properties_1): Change while to do-while,
8657 since the condition is always true at first.
8658
dc6c6455 8659 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8660 (interval_deletion_adjustment): Return unsigned value.
8661 All uses changed.
dc6c6455 8662
aba7731a
PE
8663 * process.c (list_processes_1, create_pty, read_process_output):
8664 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8665 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8666 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8667 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8668 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8669
fdfc4bf3
PE
8670 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8671
fca8fe46 8672 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8673 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8674
06a0259a 8675 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8676 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8677 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8678
e7b9e80f
PE
8679 * print.c (print_error_message): Avoid int overflow.
8680
56201685
PE
8681 * font.c (font_list_entities): Redo for clarity,
8682 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8683
78834453 8684 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8685 (font_score): Avoid potential overflow in diff calculation.
78834453 8686
0bc0b309 8687 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8688 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8689
e610eaca
PE
8690 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8691
b895abce
PE
8692 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8693 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8694 can always succeed if overflow has undefined behavior.
8695
1f1d9321 8696 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8697 (wordify): Omit three unnecessary tests.
1f1d9321 8698
c59478bc
PE
8699 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8700 All callers changed. This avoids the need for an unused var.
8701
79b73827
PE
8702 * casefiddle.c (casify_region): Remove var that is set but not used.
8703
a4db5dfe
PE
8704 * dired.c (file_name_completion): Remove var that is set but not used.
8705
43aae36e
PE
8706 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8707
2a47c44d 8708 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8709 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8710
a37c69bf
PE
8711 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8712 Check for integer overflow on size calculations.
8713
328ab8e7
PE
8714 * buffer.c (Fprevious_overlay_change): Remove var that is set
8715 but not used.
8716
e5a2a5cb
PE
8717 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8718 Remove vars that are set but not used.
8d84a6eb 8719 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8720 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8721
a60e5f68
PE
8722 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8723
f661cb61 8724 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8725 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8726
f0397f5a
PE
8727 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8728 that are set but not used.
8729
8664db06 8730 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8731 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8732
6abdaa4a
PE
8733 * xselect.c (x_get_local_selection, x_handle_property_notify):
8734 Remove vars that are set but not used.
8735
0ce7538d 8736 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8737 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8738
9ae848fc
PE
8739 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8740 Remove var that is set but not used.
0b918413
PE
8741 (scroll_bar_windows_size): Now size_t, not int.
8742 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8743 Check for overflow.
9ae848fc 8744
a5a62657
PE
8745 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8746 (map_tty_color) [!defined MSDOS]: Likewise.
8747
5c5cdd39
PE
8748 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8749
66ebf983
PE
8750 * coding.c: Remove vars that are set but not used.
8751 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8752 All callers changed.
8753 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8754 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8755 (decode_coding_charset): Remove vars that are set but not used.
8756
1be4d761
PE
8757 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8758 that is set but not used.
8759
47553fa8
PE
8760 * print.c (print_object): Remove var that is set but not used.
8761
1f7196bf 8762 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8763 The gnulib version avoids calling malloc in the usual case,
8764 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8765 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8766 * filelock.c (current_lock_owner): Likewise.
8767 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8768 * sysdep.c: Include allocator.h, careadlinkat.h.
8769 (emacs_no_realloc_allocator): New static constant.
8770 (emacs_readlink): New function.
fdb61804
PE
8771 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8772 ../lib/careadlinkat.h.
d1fdcab7 8773
f84c17c7
SM
87742011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8775
8776 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8777 first non-nil return value).
8778
ef3862ad
JD
87792011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8780
8781 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8782 if not defined (Bug#8403).
8783
376a7006
JB
87842011-04-02 Juanma Barranquero <lekktu@gmail.com>
8785
8786 * xdisp.c (display_count_lines): Remove parameter `start',
8787 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8788 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8789 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8790 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8791 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8792 and thereabouts. All callers changed.
8793 (get_per_char_metric): Remove parameter `f', unused since
8794 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8795
6ca3801d
JM
87962011-04-02 Jim Meyering <meyering@redhat.com>
8797
8798 do not dereference NULL upon failed strdup
8799 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8800 (ns_get_family): Likewise.
8801
d8e2b5ba
JB
88022011-04-02 Juanma Barranquero <lekktu@gmail.com>
8803
8804 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8805
8c74fcbd
JD
88062011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8807
8808 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8809 later (Bug#8403).
8810
7200d79c
SM
88112011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8812
03408648 8813 Add lexical binding.
7200d79c 8814
03408648
SM
8815 * window.c (Ftemp_output_buffer_show): New fun.
8816 (Fsave_window_excursion):
8817 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8818
8819 * lread.c (lisp_file_lexically_bound_p): New function.
8820 (Fload): Bind Qlexical_binding.
8821 (readevalloop): Remove `evalfun' arg.
8822 Bind Qinternal_interpreter_environment.
8823 (Feval_buffer): Bind Qlexical_binding.
8824 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8825 Mark as dynamic.
8826 (syms_of_lread): Declare `lexical-binding'.
8827
8828 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8829
8830 * keyboard.c (eval_dyn): New fun.
8831 (menu_item_eval_property): Use it.
ca105506
SM
8832
8833 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8834
03408648
SM
8835 * fns.c (concat, mapcar1): Accept byte-code-functions.
8836
8837 * eval.c (Fsetq): Handle lexical vars.
8838 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8839 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8840 (FletX, Flet): Obey lexical binding.
8841 (Fcommandp): Handle closures.
8842 (Feval): New `lexical' arg.
8843 (eval_sub): New function extracted from Feval. Use it almost
8844 everywhere where Feval was used. Look up vars in lexical env.
8845 Handle closures.
8846 (Ffunctionp): Move from subr.el.
8847 (Ffuncall): Handle closures.
8848 (apply_lambda): Remove `eval_flags'.
8849 (funcall_lambda): Handle closures and new byte-code-functions.
8850 (Fspecial_variable_p): New function.
8851 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8852 but without exporting it to Lisp.
23aba0ea 8853
23aba0ea 8854 * doc.c (Fdocumentation, store_function_docstring):
03408648 8855 * data.c (Finteractive_form): Handle closures.
23aba0ea 8856
03408648
SM
8857 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8858 interactive spec.
ba83908c 8859
04f2d78b
CB
8860 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8861 New byte-codes.
03408648
SM
8862 (exec_byte_code): New function extracted from Fbyte_code to handle new
8863 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8864
03408648 8865 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8866
03408648 8867 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8868
e2abce01
JB
88692011-03-31 Juanma Barranquero <lekktu@gmail.com>
8870
8871 * xdisp.c (redisplay_internal): Fix prototype.
8872
63696a73 88732011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8874
63696a73 8875 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8876 (try_scrolling): Use it when setting scroll_limit.
8877 Limit scrolling to 100 screen lines.
63696a73
EZ
8878 (redisplay_window): Even when falling back on "recentering",
8879 position point in the window according to scroll-conservatively,
8880 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8881
8882 (try_scrolling): When point is above the window, allow searching
8883 as far as scroll_max, or one screenful, to compute vertical
8884 distance from PT to the scroll margin position. This prevents
8885 try_scrolling from unnecessarily failing when
8886 scroll-conservatively is set to a value slightly larger than the
8887 window height. Clean up the case of PT below the margin at bottom
8888 of window: scroll_max can no longer be INT_MAX. When aggressive
8889 scrolling is in use, don't let point enter the opposite scroll
8890 margin as result of the scroll.
8891 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8892 threshold of 100 lines for never-recentering scrolling.
8893
e4cc2dfc
JB
88942011-03-31 Juanma Barranquero <lekktu@gmail.com>
8895
8896 * dispextern.h (move_it_by_lines):
8897 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8898 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8899 (message_log_check_duplicate): Remove parameters `prev_bol' and
8900 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8901 (redisplay_internal): Remove parameter `preserve_echo_area',
8902 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8903
8904 * indent.c (Fvertical_motion):
8905 * window.c (window_scroll_pixel_based, Frecenter):
8906 Don't pass `need_y_p' to `move_it_by_lines'.
8907
1c470562
SM
89082011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8909
44f230aa
SM
8910 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8911 steal a few bits to be more compact.
8912 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8913 Remove unneeded casts.
8914
1c470562
SM
8915 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8916
888adce9
ZK
89172011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8918
8919 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8920 binding" message (bug#7967).
8921
f838ed7b
PE
89222011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8923
77861b95
PE
8924 Fix more problems found by GCC 4.6.0's static checks.
8925
de6dbc14
PE
8926 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8927 Remove unused local var.
8928
f838ed7b
PE
8929 * editfns.c (Fmessage_box): Remove unused local var.
8930
792c7b2b
PE
8931 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8932 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8933 Omit unused local vars.
c499e557 8934 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8935 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8936 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8937 Omit unused local var.
8938
ba0165e1
PE
8939 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8940 Don't assume string length fits in int.
32ad8845 8941 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8942 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8943
3c59b4c9
PE
8944 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8945 instead of alloca (Bug#8344).
8946
a3eed478 8947 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8948 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8949
eb4d412d
PE
8950 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8951
1658b401
PE
8952 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8953 concerns.
8954
8955 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8956
8957 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8958
9a2c6e05
PE
8959 * keyboard.c (syms_of_keyboard): Use the same style as later
8960 in this function when indexing through an array. This also
8961 works around GCC bug 48267.
8962
03d0a109
PE
8963 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8964
44f730c8
PE
8965 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8966
fe75f926
PE
8967 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8968 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8969
ffa8c828
PE
8970 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8971 This avoids undefined behavior on integer overflow, and is a bit
8972 more convenient anyway since it is compared to a size_t variable.
8973
c5101a77
PE
8974 Variadic C functions now count arguments with size_t, not int.
8975 This avoids an unnecessary limitation on 64-bit machines, which
8976 caused (substring ...) to crash on large vectors (Bug#8344).
8977 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8978 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8979 All variadic functions and their callers changed accordingly.
c5101a77
PE
8980 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8981 * data.c (arith_driver, float_arith_driver): Likewise.
8982 * editfns.c (general_insert_function): Likewise.
8983 * eval.c (struct backtrace.nargs, interactive_p)
8984 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8985 (funcall_lambda, mark_backtrace): Likewise.
8986 * fns.c (concat): Likewise.
8987 * frame.c (x_set_frame_parameters): Likewise.
8988 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8989 0 if not found, not -1. All callers changed.
8990
dd3f25f7
PE
8991 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8992 (stack_copy_size): Now size_t, not int.
8993 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8994
461c2ab9
JB
89952011-03-28 Juanma Barranquero <lekktu@gmail.com>
8996
8997 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8998 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8999 All callers changed.
9000
9001 * lisp.h (multibyte_char_to_unibyte):
9002 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
9003 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9004 * character.h (CHAR_TO_BYTE8):
9005 * cmds.c (internal_self_insert):
9006 * editfns.c (general_insert_function):
9007 * keymap.c (push_key_description):
9008 * search.c (Freplace_match):
9009 * xdisp.c (message_dolog, set_message_1): All callers changed.
9010
f6d62986
SM
90112011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
9012
9013 * keyboard.c (safe_run_hook_funcall): New function.
9014 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
9015 don't set the hook to nil, but remove the offending function instead.
9016 (Qcommand_hook_internal): Remove, unused.
9017 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
9018 Vcommand_hook_internal.
9019
9020 * eval.c (enum run_hooks_condition): Remove.
9021 (funcall_nil, funcall_not): New functions.
9022 (run_hook_with_args): Call each function through a `funcall' argument.
9023 Remove `cond' argument, now redundant.
9024 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
9025 (Frun_hook_with_args_until_failure): Adjust accordingly.
9026 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
9027
1db5b1ad
JB
90282011-03-28 Juanma Barranquero <lekktu@gmail.com>
9029
9030 * dispextern.h (string_buffer_position): Remove declaration.
9031
9032 * print.c (strout): Remove parameter `multibyte', unused since
9033 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
9034
9035 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
9036 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
9037 All callers changed.
9038
9039 * w32.c (_wsa_errlist): Use braces for struct initializers.
9040
9041 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
9042 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
9043 All callers changed.
9044 (string_buffer_position): Likewise. Also, make static (it's never
9045 used outside xdisp.c).
9046 (cursor_row_p): Remove parameter `w', unused since
9047 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
9048 (decode_mode_spec): Remove parameter `precision', introduced during
9049 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
9050 All callers changed.
9051
5ffb62aa
JD
90522011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9053
9054 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
9055
461c2ab9 90562011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
9057
9058 * nsterm.m (ns_menu_bar_is_hidden): New variable.
9059 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
9060 (ns_update_auto_hide_menu_bar): New functions.
9061 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
9062 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
9063 ns_constrain_all_frames.
9064 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
9065 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
9066
5c380ffb
JD
90672011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9068
9069 * nsmenu.m (runDialogAt): Remove argument to timer_check.
9070
9af30bdf
GM
90712011-03-27 Glenn Morris <rgm@gnu.org>
9072
9073 * syssignal.h: Replace RETSIGTYPE with void.
9074 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
9075 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
9076 Replace SIGTYPE with void everywhere.
9077 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9078 * s/template.h (SIGTYPE): Remove commented out definition.
9079
e2abce01
JB
90802011-03-26 Eli Zaretskii <eliz@gnu.org>
9081
9082 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9083 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9084
f868cd8a
JB
90852011-03-26 Juanma Barranquero <lekktu@gmail.com>
9086
59eb0929
JB
9087 * w32.c (read_unc_volume): Use parameter `henum', instead of
9088 global variable `wget_enum_handle'.
9089
9090 * keymap.c (describe_vector): Remove parameters `indices' and
9091 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9092 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9093
f868cd8a
JB
9094 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9095
9096 * keyboard.c (timer_check): Remove parameter `do_it_now',
9097 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9098 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9099 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9100
9101 * keyboard.c (read_char):
9102 * w32menu.c (w32_menu_display_help):
9103 * xmenu.c (show_help_event, menu_help_callback):
9104 Adjust calls to `show_help_echo'.
9105
9106 * gtkutil.c (xg_maybe_add_timer):
9107 * keyboard.c (readable_events):
9108 * process.c (wait_reading_process_output):
9109 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9110
9111 * insdel.c (adjust_markers_gap_motion):
9112 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9113 (gap_left, gap_right): Don't call it.
9114
2ecf6fdb
CY
91152011-03-25 Chong Yidong <cyd@stupidchicken.com>
9116
9117 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9118 incurred during fontification.
9119
6b1f9ba4
JB
91202011-03-25 Juanma Barranquero <lekktu@gmail.com>
9121
9122 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9123 (DEFVAR_PER_BUFFER): Don't pass it.
9124
9125 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9126 (scrolling_window): Don't pass it.
9127
0f4a96b5
JB
91282011-03-25 Juanma Barranquero <lekktu@gmail.com>
9129
9130 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9131
9132 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9133 and `suffix'.
9134 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9135 of variables specific to SELinux and computation of `encoded_absname'.
9136
9137 * image.c (XPutPixel): Remove unused variable `height'.
9138
9139 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9140
9141 * unexw32.c (get_section_info): Remove unused variable `section'.
9142
9143 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9144 (system_process_attributes): Remove unused variable `sess'.
9145 (sys_read): Remove unused variable `err'.
9146
9147 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9148 (w32_wnd_proc): Remove unused variable `isdead'.
9149 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9150 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9151 (x_create_tip_frame): Remove unused variable `tem'.
9152
9153 * w32inevt.c (w32_console_read_socket):
9154 Remove unused variable `no_events'.
9155
9156 * w32term.c (x_draw_composite_glyph_string_foreground):
9157 Remove unused variable `width'.
9158
1149507c
JB
91592011-03-24 Juanma Barranquero <lekktu@gmail.com>
9160
9161 * w32term.c (x_set_glyph_string_clipping):
9162 Don't pass uninitialized region to CombineRgn.
9163
9c88f339
JB
91642011-03-23 Juanma Barranquero <lekktu@gmail.com>
9165
9166 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9167 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9168 (Fx_close_connection): Remove unused variable `i'.
9169
9170 * w32font.c (w32font_draw): Return number of glyphs.
9171 (w32font_open_internal): Remove unused variable `i'.
9172 (w32font_driver): Add missing initializer.
9173
9174 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9175 (fill_in_menu): Remove unused variable `items_added'.
9176
9177 * w32term.c (last_mouse_press_frame): Remove static global variable.
9178 (w32_clip_to_row): Remove unused variable `f'.
9179 (x_delete_terminal): Remove unused variable `i'.
9180
9181 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9182 (NOTHING): Remove unused static global variable.
9183 (uniscribe_check_otf): Remove unused variable `table'.
9184 (uniscribe_font_driver): Add missing initializers.
9185
dee091a3
JD
91862011-03-23 Julien Danjou <julien@danjou.info>
9187
9188 * term.c (Fsuspend_tty, Fresume_tty):
9189 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9190 * window.c (temp_output_buffer_show):
9191 * insdel.c (signal_before_change):
9192 * frame.c (Fhandle_switch_frame):
9193 * fileio.c (Fdo_auto_save):
9194 * emacs.c (Fkill_emacs):
9195 * editfns.c (save_excursion_restore):
9196 * cmds.c (internal_self_insert):
9197 * callint.c (Fcall_interactively):
9198 * buffer.c (Fkill_all_local_variables):
9199 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9200 Use Frun_hooks.
0f4a96b5 9201 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 9202 unconditionally since it does the check itself.
dee091a3 9203
2c520ab5 92042011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 9205
c9c49752
PE
9206 Fix more problems found by GCC 4.5.2's static checks.
9207
8abc3f12
PE
9208 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9209 the first time through the loop, since we know p0 < p1 then.
9210 This also avoids a gcc -Wstrict-overflow warning.
9211
a2d26660
PE
9212 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9213 leading to a memory leak, possible in functions like
9214 load_charset_map_from_file that can allocate an unbounded number
b12ef411 9215 of objects (Bug#8318).
a2d26660 9216
916c72e9
PE
9217 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9218 that could (at least in theory) be that large.
9219
19ab8a18
PE
9220 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9221 This is less likely to overflow, and avoids undefined behavior if
9222 overflow does occur. All callers changed. Use strtoul to scan
9223 for the unsigned long integer.
b7cbbd6f
PE
9224 (pint2hrstr): Simplify and tune code slightly.
9225 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 9226
f0641eff
PE
9227 * scroll.c (do_scrolling): Work around GCC bug 48228.
9228 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9229
7f650bb9
PE
9230 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9231 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
9232 (validate_x_resource_name): Simplify count usage.
9233 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 9234
37dd57d1
PE
9235 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9236 fail (Bug#8306).
81e56e61 9237
699979fc 9238 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 9239
401bf9b4
PE
9240 * process.c (Fmake_network_process): Use socklen_t, not int,
9241 where POSIX says socklen_t is required in portable programs.
9242 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 9243 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
9244 (Fmake_network_process, server_accept_connection):
9245 (wait_reading_process_output, read_process_output):
9246 Likewise.
9247
b93aacde
PE
9248 * process.c: Rename or move locals to avoid shadowing.
9249 (list_processes_1, Fmake_network_process):
9250 (read_process_output_error_handler, exec_sentinel_error_handler):
9251 Rename or move locals.
4dc343ee 9252 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 9253 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 9254 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 9255 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 9256 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 9257
af8a867c 9258 Make tparam.h and terminfo.c consistent.
44f230aa
SM
9259 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9260 Include tparam.h instead, since it declares them.
af8a867c
PE
9261 * cm.h (PC): Remove extern decl; tparam.h now does this.
9262 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9263 * terminfo.c: Include tparam.h, to check interfaces.
9264 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9265 (tparam): Adjust signature to match interface in tparam.h;
9266 this removes some undefined behavior. Check that outstring and len
9267 are zero, which they always are with Emacs.
9268 * tparam.h (PC, BC, UP): New extern decls.
9269
0248044d 9270 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 9271 (xftfont_open): Rename locals to avoid shadowing.
0248044d 9272
8ff096c1 9273 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
9274 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9275 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 9276 (ftfont_list): Remove unused local.
49eaafba
PE
9277 (get_adstyle_property, ftfont_pattern_entity):
9278 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9279 Rename locals to avoid shadowing.
8ff096c1 9280
e2be39f6
PE
9281 * xfont.c (xfont_list_family): Mark var as initialized.
9282
c9735e30
PE
9283 * xml.c (make_dom): Now static.
9284
8f5201ae
PE
9285 * composite.c (composition_compute_stop_pos): Rename local to
9286 avoid shadowing.
b246f932
PE
9287 (composition_reseat_it): Remove unused locals.
9288 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 9289 (composition_update_it): Mark var as initialized.
11b61122
PE
9290 (find_automatic_composition): Mark vars as initialized,
9291 with a FIXME (Bug#8290).
8f5201ae 9292
760fbc2c
PE
9293 character.h: Rename locals to avoid shadowing.
9294 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9295 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9296 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9297 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9298 to avoid shadowing.
9299
ff08eb85
PE
9300 * textprop.c (property_change_between_p): Remove; unused.
9301
fc7bf025
PE
9302 * intervals.c (interval_start_pos): Now static.
9303
235d7abc
PE
9304 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9305
44f230aa
SM
9306 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9307 Rename locals to avoid shadowing.
3e7d6594 9308
50060332
PE
9309 * sound.c (wav_play, au_play, Fplay_sound_internal):
9310 Fix pointer signedness.
d01f234b 9311 (alsa_choose_format): Remove unused local var.
c83b8872
PE
9312 (wav_play): Initialize a variable to 0, to prevent undefined
9313 behavior (Bug#8278).
50060332 9314
c4fc4e30
PE
9315 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9316
918436ed
PE
9317 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9318
c939f91b
PE
9319 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9320 clobbering (Bug#8298).
b9c7f648
PE
9321 * sysdep.c (sys_subshell): Likewise.
9322 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 9323
6bd8c144
PE
9324 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9325 This should get cleaned up, so that child_setup has the
9326 same signature on all platforms.
9327
7710357c 9328 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 9329 (relocate_fd): Rename locals to avoid shadowing.
7710357c 9330
c59da222
CY
93312011-03-22 Chong Yidong <cyd@stupidchicken.com>
9332
9333 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9334 not to be necessary, and produces flickering.
9335
66b87493
GM
93362011-03-20 Glenn Morris <rgm@gnu.org>
9337
9338 * config.in: Remove file.
9339
45b6f6d5
JB
93402011-03-20 Juanma Barranquero <lekktu@gmail.com>
9341
9342 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9343 are now in src/globals.h.
9344 (syms_of_minibuf): Remove spurious & from previous change.
9345
cd394be1 93462011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
9347
9348 * minibuf.c (completing-read-function): New variable.
9349 (completing-read-default): Rename from completing-read.
9350 (completing-read): Call completing-read-function.
9351
b14e3e21
CY
93522011-03-19 Juanma Barranquero <lekktu@gmail.com>
9353
9354 * xfaces.c (Fx_load_color_file):
9355 Read color file from absolute filename (bug#8250).
9356
f2b726e6
JB
93572011-03-19 Juanma Barranquero <lekktu@gmail.com>
9358
9359 * makefile.w32-in: Update dependencies.
9360
09f6ff02
EZ
93612011-03-17 Eli Zaretskii <eliz@gnu.org>
9362
9363 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9364
29a6015a
PE
93652011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9366
a3a6c54e
PE
9367 Fix more problems found by GCC 4.5.2's static checks.
9368
b766f867
PE
9369 * process.c (make_serial_process_unwind, send_process_trap):
9370 (sigchld_handler): Now static.
9371
be02381c
PE
9372 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9373 That way, the code declares only the vars that it needs.
9374 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9375 * s/cygwin.h (PTY_ITERATION): Likewise.
9376 * s/darwin.h (PTY_ITERATION): Likewise.
9377 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9378
57048744
PE
9379 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9380 * process.c (allocate_pty): Don't declare stb unless it's needed.
9381
7914961c 9382 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
9383 (CONSTANTLIM): Remove; unused.
9384 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9385 Define only if needed.
7914961c 9386
b3967b18
PE
9387 * unexelf.c (unexec): Name an expression,
9388 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
9389 Use a different way to cause a compilation error if anyone uses
9390 n rather than nn, a way that does not involve shadowing.
73366a00 9391 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9392
29a6015a
PE
9393 * deps.mk (unexalpha.o): Remove; unused.
9394
43cfc33e 9395 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9396 * unexec.h: New file.
ce701a33
PE
9397 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9398 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9399 Depend on unexec.h.
9400 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9401 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9402 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9403 Change as necessary to match prototype in unexec.h.
ce701a33 9404
01f44d5a
PE
9405 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9406 shadowing.
4f63c6bb 9407 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9408
a6670b0b
PE
9409 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9410 Rename locals to avoid shadowing.
9411
cef2010d 9412 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9413 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9414
d4d7173a
PE
9415 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9416
f08b802a
PE
9417 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9418 warning when compiling print.c.
9419
3ddb0639
PE
9420 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9421 instead of using an uninitialized var.
5ad03b97 9422 (font_sort_entities): Mark var as initialized.
3ddb0639 9423
170a2692
PE
9424 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9425
e663c700
PE
9426 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9427 pointers to constants.
89bc529a 9428 (font_parse_fcname): Remove unused vars.
7b81e2d0 9429 (font_delete_unmatched): Now static.
ea838e10 9430 (font_get_spec): Remove; unused.
13a547c6
PE
9431 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9432 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9433 Rename or move locals to avoid shadowing.
e663c700 9434
2a80c887 9435 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9436 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9437
1384fa33 9438 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9439 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9440
8b2c52e9
PE
9441 * alloc.c (mark_backtrace): Move decl from here ...
9442 * lisp.h: ... to here, so that it can be checked.
9443
475545b5 9444 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9445 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9446 (lisp_indirect_variable): Name an expression,
9447 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9448 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9449
b1349114 9450 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9451 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9452 Use const pointer when appropriate.
b1349114 9453
a2928364
PE
9454 * lisp.h (get_system_name, get_operating_system_release):
9455 Move decls here, to check interfaces.
9456 * process.c (get_operating_system_release): Move decl to lisp.h.
9457 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9458 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9459 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9460 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9461 (Fformat_time_string, Fencode_time, Finsert_char):
9462 (Ftranslate_region_internal, Fformat):
9463 Rename or remove local vars to avoid shadowing.
9710023e 9464 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9465
a415e694
PE
9466 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9467 avoid shadowing.
9468
8ef4622d
PE
9469 * lisp.h (eassert): Check that the argument compiles, even if
9470 ENABLE_CHECKING is not defined.
9471
946f9a5b
PE
9472 * data.c (Findirect_variable): Name an expression, to avoid
9473 gcc -Wbad-function-cast warning.
112396d6 9474 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9475 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9476 (Fmake_variable_buffer_local, Fmake_local_variable):
9477 Mark variables as initialized.
52746918 9478 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9479
e5aab7e7 9480 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9481 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9482 Rename locals to avoid shadowing.
dff45157
PE
9483 (mark_stack): Move local variables into the #ifdef region where
9484 they're used.
7bc26fdb
PE
9485 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9486 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9487 needed otherwise.
9488 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9489 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9490 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9491
e5aab7e7
PE
9492 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9493 avoids undefined behavior in theory.
9494
4da60324
PE
9495 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9496
88043301
PE
9497 Use functions, not macros, for up- and down-casing (Bug#8254).
9498 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9499 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9500 to use the following functions instead of these macros.
9501 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9502 EMACS_INT, since callers assume the returned value fits in int.
9503 (upcase1): Likewise, for UPCASE_TABLE.
9504 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9505 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9506 the race-condition problem in the old DOWNCASE.
88043301 9507
19ed5445
PE
9508 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9509 Rename locals to avoid shadowing.
9510 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9511 (regex_compile, re_search_2, re_match_2_internal):
9512 Remove unused local vars.
952db0d7
PE
9513 (FREE_VAR): Rewrite so as not to use empty "else",
9514 which gcc can warn about.
da053e48 9515 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9516 (RETALLOC_IF): Define only if needed.
9517 (WORDCHAR_P): Likewise. This one is never needed, but is used
9518 only in a comment talking about a compiler bug, so put inside
9519 the #if 0 of that comment.
9520 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9521 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9522 Remove; unused.
19ed5445 9523
1f3561e4 9524 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9525 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9526 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9527
ded6f8f7
PE
9528 * search.c (simple_search): Remove unused var.
9529
dbd37a95
PE
9530 * dired.c (compile_pattern): Move decl from here ...
9531 * lisp.h: ... to here, so that it can be checked.
9532 (struct re_registers): New forward decl.
9533
7e47afad
PE
9534 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9535
85f24f61
PE
9536 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9537 All uses changed.
9538 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9539 Rename locals to avoid shadowing.
5671df8f 9540 (Fvertical_motion): Mark locals as initialized.
85f24f61 9541
181aa2be 9542 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9543 (casify_region): Mark local as initialized.
181aa2be 9544
930d429c
PE
9545 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9546
7082eac6
PE
9547 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9548 New macros, so that the caller can use some names other than
9549 gcpro1, gcpro2, etc.
9550 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9551 of the new macros.
9552 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9553 argument, for consistency with GCPRO2_VAR, etc: it is now the
9554 prefix of the variable, not the variable itself. All uses
9555 changed.
38b2c076
PE
9556 * dired.c (directory_files_internal, file_name_completion):
9557 Rename locals to avoid shadowing.
9558
15206ed9
PE
9559 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9560 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9561 dired.c's scmp function, had undefined behavior.
9562 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9563 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9564 * buffer.h: ... to here, because these macros use current_buffer,
9565 and the new implementation with inline functions needs to have
9566 current_buffer in scope now, rather than later when the macros
9567 are used.
9568 (downcase, upcase1): New static inline functions.
9569 (DOWNCASE, UPCASE1): Reimplement using these functions.
9570 This avoids undefined behavior in expressions like
9571 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9572 from race conditions in accessing the global variables
9573 case_temp1 and case_temp2.
9574 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9575 * lisp.h (case_temp1, case_temp2): Remove their decls.
9576 * character.h (ASCII_CHAR_P): Move from here ...
9577 * lisp.h: ... to here, so that the inline functions mentioned
9578 above can use them.
9579
4a6bea26
PE
9580 * dired.c (directory_files_internal_unwind): Now static.
9581
f14b7e14
PE
9582 * fileio.c (file_name_as_directory, directory_file_name):
9583 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9584 Now static.
2893f146
PE
9585 (file_name_as_directory): Use const pointers when appropriate.
9586 (Fexpand_file_name): Likewise. In particular, newdir might
9587 point at constant storage, so make it a const pointer.
fd4ead52 9588 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9589 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9590 signedness issues.
f839df0c
PE
9591 (Fset_file_times, Finsert_file_contents, auto_save_error):
9592 Rename locals to avoid shadowing.
f14b7e14 9593
5716756e 9594 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9595 (Ftry_completion, Fall_completions): Rename or remove locals
9596 to avoid shadowing.
5716756e 9597
b4c3046a
PE
9598 * marker.c (bytepos_to_charpos): Remove; unused.
9599
b45db522
PE
9600 * lisp.h (verify_bytepos, count_markers): New decls,
9601 so that gcc does not warn that these functions aren't declared.
9602
85876d07
PE
9603 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9604 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9605 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9606 (copy_text): Remove unused local var.
85876d07 9607
03d78a21 9608 * filelock.c (within_one_second): Now static.
b3dd38ab 9609 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9610
5df8f01b
PE
9611 * buffer.c (fix_overlays_before): Mark locals as initialized.
9612 (fix_start_end_in_overlays): Likewise. This function should be
9613 simplified by using pointers-to-pointers, but that's a different
9614 matter.
b1d876f1 9615 (switch_to_buffer_1): Now static.
8f54f30a
PE
9616 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9617 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9618
a70072c9 9619 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9620 Fix pointer signedness issue.
edced198
PE
9621 (sys_subshell): Mark local as volatile if checking for lint,
9622 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9623 (MAXPATHLEN): Define only if needed.
a70072c9 9624
a0977c44
PE
9625 * process.c (serial_open, serial_configure): Move decls from here ...
9626 * systty.h: ... to here, so that they can be checked.
9627
a884fdcc
PE
9628 * fns.c (get_random, seed_random): Move extern decls from here ...
9629 * lisp.h: ... to here, so that they can be checked.
9630
604efe86 9631 * sysdep.c (reset_io): Now static.
b8950c94 9632 (wait_for_termination_signal): Remove; unused.
604efe86 9633
38fc62d9
PE
9634 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9635 (copy_keymap_item, append_key, push_text_char_description):
9636 Now static.
1004a21a 9637 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9638 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9639 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9640 (describe_map_tree):
9641 Rename locals to avoid shadowing.
38fc62d9 9642
2f2650da
PE
9643 * keyboard.c: Declare functions static if they are not used elsewhere.
9644 (echo_char, echo_dash, cmd_error, top_level_2):
9645 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9646 (read_char, kbd_buffer_get_event, make_lispy_position):
9647 (make_lispy_event, make_lispy_movement, apply_modifiers):
9648 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9649 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9650 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9651 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9652 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9653
a053e86c 9654 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9655 (mark_kboards): Move decl here ...
9656 * alloc.c (mark_kboards): ... from here.
a053e86c 9657
4752793e
PE
9658 * lisp.h (force_auto_save_soon): New decl.
9659
74f10ca7 9660 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9661 (DEFINE_DUMMY_FUNCTION): New macro.
9662 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9663 Use it.
c03cd23f
PE
9664 (main): Add casts to avoid warnings
9665 if GCC considers string literals to be constants.
74f10ca7 9666
022e70d4
PE
9667 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9668
59d6fe83
PE
9669 * dbusbind.c: Pointer signedness fixes.
9670 (xd_signature, xd_append_arg, xd_initialize):
9671 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9672 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9673 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9674 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9675
78320123
PE
9676 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9677 if GCC considers string literals to be constants.
49cebcca 9678 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9679
35ac2a97
SM
96802011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9681
fb103ca9
SM
9682 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9683 (print_preprocess, print_object): New macro to fix last change.
9684
35ac2a97
SM
9685 * print.c (print_preprocess): Don't forget font objects.
9686
62973b41
JB
96872011-03-16 Juanma Barranquero <lekktu@gmail.com>
9688
9689 * emacs.c (USAGE3): Doc fixes.
9690
0e48bb22
AS
96912011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9692
9693 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9694 structure.
9695
7684e57b
JB
96962011-03-14 Juanma Barranquero <lekktu@gmail.com>
9697
9698 * lisp.h (VWindow_system, Qfile_name_history):
9699 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9700 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9701 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9702
9703 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9704 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9705
9706 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9707 * w32console.c (detect_input_pending, read_input_pending)
9708 (encode_terminal_code):
9709 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9710 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9711 (w32_system_caret_y, Qfile_name_history):
9712 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9713 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9714 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9715 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9716 * w32proc.c (Qlocal, report_file_error):
9717 * w32term.c (Vwindow_system, updating_frame):
9718 * w32uniscribe.c (initialized, uniscribe_font_driver):
9719 Remove unneeded extern declarations.
9720
2aa46d6c
CY
97212011-03-14 Chong Yidong <cyd@stupidchicken.com>
9722
c96bbc66 9723 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9724
cffc6f3b
CY
97252011-03-13 Chong Yidong <cyd@stupidchicken.com>
9726
9727 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9728 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9729 These macros can no longer be used for assignment.
9730
44f230aa
SM
9731 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9732 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9733 (record_buffer_markers, fetch_buffer_markers): New functions for
9734 recording and fetching special buffer markers.
9735 (set_buffer_internal_1, set_buffer_temp): Use them.
9736
9737 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9738
9739 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9740
9741 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9742 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9743
9744 * xdisp.c (hscroll_window_tree):
9745 (reconsider_clip_changes): Use PT instead of BUF_PT.
9746
d251f04b
EZ
97472011-03-13 Eli Zaretskii <eliz@gnu.org>
9748
9749 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9750 $(EMACS_ROOT)/lib/intprops.h.
9751
f0c77cd1
PE
97522011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9753
3eca4629
PE
9754 Fix more problems found by GCC 4.5.2's static checks.
9755
7c86ee98
PE
9756 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9757 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9758 (xg_free_frame_widgets): Make it clear that a local variable is
9759 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9760 (gdk_window_get_screen): Make it clear that this macro is needed
9761 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9762 (int_gtk_range_get_value): New function, which avoids a diagnostic
9763 from gcc -Wbad-function-cast.
9764 (xg_set_toolkit_scroll_bar_thumb): Use it.
9765 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9766 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9767 (get_utf8_string, xg_get_file_with_chooser):
9768 Rename locals to avoid shadowing.
9769 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9770
41729b81
PE
9771 * xgselect.c (xg_select): Remove unused var.
9772
f0c77cd1
PE
9773 * image.c (four_corners_best): Mark locals as initialized.
9774 (gif_load): Initialize transparent_p to zero (Bug#8238).
9775 Mark another local as initialized.
ec6cf4c6 9776 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9777
ce0ad53d 9778 * image.c (clear_image_cache): Now static.
d5d5a617 9779 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9780 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9781 (x_edge_detection): Remove unnecessary cast that
9782 gcc -Wbad-function-cast diagnoses.
2037898d 9783 (gif_load): Fix pointer signedness.
6ae141d6
PE
9784 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9785 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9786
33383987 97872011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9788
d32df629
PE
9789 Improve quality of tests for time stamp overflow.
9790 For example, without this patch (encode-time 0 0 0 1 1
9791 1152921504606846976) returns the obviously-bogus value (-948597
9792 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9793 reports time overflow. See
9794 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9795 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9796 * editfns.c: Include limits.h and intprops.h.
9797 (TIME_T_MIN, TIME_T_MAX): New macros.
9798 (time_overflow): Move earlier, to before first use.
9799 (hi_time, lo_time): New functions, for an accurate test for
9800 out-of-range times.
9801 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9802 (Fget_internal_run_time): Don't assume time_t fits in int.
9803 (make_time): Use list2 instead of Fcons twice.
9804 (Fdecode_time): More accurate test for out-of-range times.
9805 (check_tm_member): New function.
9806 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9807 (lisp_time_argument): Don't rely on undefined left-shift and
9808 right-shift behavior when checking for time stamp overflow.
8be6f318 9809
fe31d94c
PE
9810 * editfns.c (time_overflow): New function, refactoring common code.
9811 (Fformat_time_string, Fdecode_time, Fencode_time):
9812 (Fcurrent_time_string): Use it.
9813
8be6f318
PE
9814 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9815 * dired.c (make_time): Move to ...
9816 * editfns.c (make_time): ... here.
9817 * systime.h: Note the move.
9818
09d9db2c 98192011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9820
126bc0dc
YM
9821 * fringe.c (update_window_fringes): Remove unused variables.
9822
c47cbdfd
YM
9823 * unexmacosx.c (copy_data_segment): Also copy __got section.
9824 (Bug#8223)
9825
7ac80be9
EZ
98262011-03-12 Eli Zaretskii <eliz@gnu.org>
9827
c96bbc66 9828 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9829 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9830 Constify `char *' arguments and their references according to
9831 prototypes in tparam.h.
9832
ecb0f94d 9833 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9834
7ac80be9
EZ
9835 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9836 Adapt all references accordingly.
9837
9838 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9839
ef1fd07e
TT
98402011-03-11 Tom Tromey <tromey@redhat.com>
9841
9842 * buffer.c (syms_of_buffer): Remove obsolete comment.
9843
7ef4b50c
EZ
98442011-03-11 Eli Zaretskii <eliz@gnu.org>
9845
9846 * termhooks.h (encode_terminal_code): Declare prototype.
9847
9848 * msdos.c (encode_terminal_code): Don't declare prototype.
9849
9850 * term.c (encode_terminal_code): Now external again, used by
9851 w32console.c and msdos.c.
9852
44f230aa
SM
9853 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9854 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9855
4b1ec863 98562011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9857
1714f52b 9858 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9859
4b1ec863
PE
9860 * fringe.c (update_window_fringes): Mark locals as initialized
9861 (Bug#8227).
9862 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9863
524c7aa6
PE
9864 * alloc.c (mark_fringe_data): Move decl from here ...
9865 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9866 to check its interface.
9867 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9868
a5c0af81 9869 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9870 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9871 (fontset_font): Mark local as initialized.
a9a06e0b 9872 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9873
b4716021
PE
9874 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9875
811e9bac 9876 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9877 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9878 (x_own_selection, Fx_disown_selection_internal): Rename locals
9879 to avoid shadowing.
9880 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9881
7e3ab302
PE
9882 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9883 so that the caller can use some name other than gcpro1.
9884 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9885 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9886 (Fx_backspace_delete_keys_p):
9887 Use them to avoid shadowing, and rename vars to avoid shadowing.
9888 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9889 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9890 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9891 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9892 Remove unused locals.
7e3ab302
PE
9893 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9894 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9895 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9896 macros.
f78faa98 9897
e2b13473
PE
9898 * xterm.h (x_mouse_leave): New decl.
9899
77f23912
PE
9900 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9901 Remove unused functions.
cdf4ba58
PE
9902 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9903 (x_calc_absolute_position): Now static.
7411c686 9904 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9905 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9906 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9907 unless they are used.
38d0b34a
PE
9908 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9909 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9910 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9911 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9912 (x_error_catcher, x_connection_closed, x_error_handler):
9913 (x_error_quitter, xembed_send_message, x_iconify_frame):
9914 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9915 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9916 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9917
44f230aa
SM
9918 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9919 Rename or move locals to avoid shadowing.
6b463e58 9920 (tty_defined_color, merge_face_heights): Now static.
5967d051 9921 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9922 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9923 does not deduce is never used uninitialized.
73719eba
PE
9924 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9925 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9926
426994c3 9927 * terminal.c (store_terminal_param): Now static.
5489860b 9928
032f1620 9929 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9930 (set_frame_menubar): Remove unused local.
d4323972 9931 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9932 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9933 since they might point to immutable storage.
281585b0
PE
9934 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9935 since it's unused otherwise.
032f1620 9936
367c19e5 9937 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9938 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9939 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9940 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9941 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9942 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9943 does not deduce are never used uninitialized.
70739cbe 9944
07b48fa9
PE
9945 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9946
8868a238 9947 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9948 * window.c (window_loop, size_window):
9949 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9950
7e5cf297 9951 * window.c (display_buffer): Now static.
d6550a9f
PE
9952 (size_window): Mark variables that gcc -Wuninitialized
9953 does not deduce are never used uninitialized.
a586633d
PE
9954 * window.h (check_all_windows): New decl, to forestall
9955 gcc -Wmissing-prototypes diagnostic.
5b555da1 9956 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9957
f6095868
PE
9958 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9959 shadowing.
9960 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9961 Include <limits.h>.
9962 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9963 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9964 (load_charset_map): Mark variables that gcc -Wuninitialized
9965 does not deduce are never used uninitialized.
53df7c11 9966 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9967
f38b440c
PE
9968 * coding.c (coding_set_source, coding_set_destination):
9969 Use "else { /* comment */ }" rather than "else /* comment */;"
9970 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9971 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9972 a block, when the outer 'i' will do.
9973 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9974 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9975 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9976 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9977 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9978 Rename locals to avoid shadowing.
9979 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9980 * coding.c (emacs_mule_char, encode_invocation_designation):
9981 Now static, since they're not used elsewhere.
413bb2db 9982 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9983 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9984 (decode_coding_emacs_mule): Mark variables that gcc
9985 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9986 (detect_coding_iso_2022): Initialize a local variable that might
9987 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9988 this initialization is needed. (Bug#8211)
5f58e762
PE
9989 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9990 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9991 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9992 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9993 Remove unused macros.
f38b440c 9994
232b38b9 9995 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9996 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9997 * character.c (string_count_byte8): Likewise.
232b38b9 9998
fb90da1b
PE
9999 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
10000 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
10001
fb93dbc2
PE
10002 * chartab.c (copy_sub_char_table): Now static, since it's not used
10003 elsewhere.
5c156ace
PE
10004 (sub_char_table_ref_and_range, char_table_ref_and_range):
10005 Rename locals to avoid shadowing.
bbcd0949 10006 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 10007
7d3b3862 10008 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 10009 (BIDI_BOB): Remove unused macro.
7d3b3862 10010
6be7d3da
PE
10011 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
10012 deduce are never used uninitialized.
c2ed9c8b 10013 * term.c (encode_terminal_code): Likewise.
6be7d3da 10014
75f8807f 10015 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 10016
50938595
PE
10017 * tparam.h: New file.
10018 * term.c, tparam.h: Include it.
10019 * deps.mk (term.o, tparam.o): Depend on tparam.h.
10020 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
10021 Move these decls to tparam.h, and make them agree with what
10022 is actually in tparam.c. The previous trick of using incompatible
10023 decls in different modules does not conform to the C standard.
10024 All callers of tparam changed to use tparam's actual API.
10025 * tparam.c (tparam1, tparam, tgoto):
10026 Use const pointers where appropriate.
10027
fbceeba2
PE
10028 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
10029 * cm.h (struct cm): Likewise.
10030 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
10031 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
10032 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
10033 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
10034 (turn_on_face, init_tty): Likewise.
10035 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 10036
7f3f1250
PE
10037 * term.c (term_mouse_position): Rename local to avoid shadowing.
10038
e6ca6543
PE
10039 * alloc.c (mark_ttys): Move decl from here ...
10040 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
10041
c40f8d15
AS
100422011-03-11 Andreas Schwab <schwab@linux-m68k.org>
10043
10044 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
10045
cfe0661d
JB
100462011-03-09 Juanma Barranquero <lekktu@gmail.com>
10047
10048 * search.c (compile_pattern_1): Remove argument regp, unused since
10049 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
10050 (compile_pattern): Don't pass it.
10051
0afb4571
J
100522011-03-08 Jan Djärv <jan.h.d@swipnet.se>
10053
10054 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
10055 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
10056 for ! HAVE_GTK3.
10057 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
10058
10059 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
10060
10061 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
10062 gdk_window_get_screen, gdk_window_get_geometry,
10063 gdk_x11_window_lookup_for_display and GDK_KEY_g.
10064 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
10065 (xg_get_pixbuf_from_pixmap): New function.
10066 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
10067 to Pixmap, take frame as parameter, remove GdkColormap parameter.
10068 Call xg_get_pixbuf_from_pixmap instead of
10069 gdk_pixbuf_get_from_drawable.
10070 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
10071 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
10072 (xg_check_special_colors): Use GtkStyleContext and its functions
10073 for HAVE_GTK3.
10074 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
10075 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
10076 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
10077 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10078 Call gtk_widget_get_preferred_size.
0afb4571
J
10079 (xg_frame_resized): gdk_window_get_geometry only takes 5
10080 parameters.
44f230aa
SM
10081 (xg_win_to_widget, xg_event_is_for_menubar):
10082 Call gdk_x11_window_lookup_for_display.
0afb4571
J
10083 (xg_set_widget_bg): New function.
10084 (delete_cb): New function.
895009e1 10085 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 10086 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
10087 (xg_set_background_color): Call xg_set_widget_bg.
10088 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10089 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10090 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10091 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10092 if ! HAVE_GTK3.
10093 (update_frame_tool_bar): Call gtk_widget_hide.
10094 (xg_initialize): Use GDK_KEY_g.
10095
10096 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10097 if ! HAVE_GTK3
10098 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10099
10100 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10101 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10102 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10103
1c2cc4ef
JB
101042011-03-08 Juanma Barranquero <lekktu@gmail.com>
10105
10106 * w32xfns.c (select_palette): Check success of RealizePalette against
10107 GDI_ERROR, not zero.
10108
33383987 10109See ChangeLog.11 for earlier changes.
aac0c6e3
MR
10110
10111;; Local Variables:
10112;; coding: utf-8
aac0c6e3
MR
10113;; End:
10114
2f097256 10115 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
10116
10117 This file is part of GNU Emacs.
10118
10119 GNU Emacs is free software: you can redistribute it and/or modify
10120 it under the terms of the GNU General Public License as published by
10121 the Free Software Foundation, either version 3 of the License, or
10122 (at your option) any later version.
10123
10124 GNU Emacs is distributed in the hope that it will be useful,
10125 but WITHOUT ANY WARRANTY; without even the implied warranty of
10126 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10127 GNU General Public License for more details.
10128
10129 You should have received a copy of the GNU General Public License
10130 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.