gnus-uu.el (gnus-uu-grab-articles): Require gnus-async so that `gnus-asynchronous...
[bpt/emacs.git] / src / ChangeLog
CommitLineData
a239d4e9
JB
12011-09-28 Juanma Barranquero <lekktu@gmail.com>
2
3 * lread.c (Fread_from_string): Fix typo in docstring.
4
88652fd5
EZ
52011-09-27 Eli Zaretskii <eliz@gnu.org>
6
7 * xdisp.c (handle_invisible_prop): If invisible text ends on a
8 newline, reseat the iterator instead of bidi-iterating there one
9 character at a time. (Bug#9610)
10 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
11 TO_CHARPOS if the bidi iterator is at base embedding level.
12
ed497dd4
AS
132011-09-27 Andreas Schwab <schwab@linux-m68k.org>
14
15 * lread.c (readevalloop): Use correct code for NBSP.
16 (read1): Likewise. (Bug#9608)
17
b2bf61aa
MA
182011-09-25 Michael Albinus <michael.albinus@gmx.de>
19
20 * dbusbind.c (Fdbus_register_signal): When service is not
21 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
22
32bbb17c
GM
232011-09-25 Glenn Morris <rgm@gnu.org>
24
25 * buffer.c (truncate-lines): Doc fix.
26
94e0933e
CY
272011-09-24 Chong Yidong <cyd@stupidchicken.com>
28
29 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
30 (Fset_window_next_buffers): Doc fix.
31
cddde921
GM
322011-09-24 Glenn Morris <rgm@gnu.org>
33
34 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
35
1260aef1
PE
362011-09-24 Paul Eggert <eggert@cs.ucla.edu>
37
25b4bfa0
PE
38 Fix minor problems found by static checking.
39 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
40 * indent.c (Fvertical_motion): Fix == vs = typo.
41
e3cbd34b
EZ
422011-09-24 Eli Zaretskii <eliz@gnu.org>
43
6bf7006f
EZ
44 * dispnew.c (syms_of_display) <redisplay-dont-pause>: Default
45 value is now t. Doc fix.
46
e3cbd34b
EZ
47 * indent.c (Fvertical_motion): Compute and apply the overshoot
48 logic when moving up, not only when moving down. Fix the
49 confusing name and values of the it_overshoot_expected variable;
50 logic changes accordingly. (Bug#9254) (Bug#9549)
51
52 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
53 CHARPOS is covered by a display string which includes newlines.
54 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
55 is covered by a display string with embedded newlines.
56
a3de0cbd
MA
572011-09-24 Michael Albinus <michael.albinus@gmx.de>
58
59 * dbusbind.c (Fdbus_register_signal): Add match rule to
60 Vdbus_registered_objects_table. (Bug#9581)
61 (Fdbus_register_method, Vdbus_registered_objects_table): Fix
62 docstring.
63
b260039d
JM
642011-09-24 Jim Meyering <meyering@redhat.com>
65
66 do not ignore write error for any output size
67 The previous change was incomplete.
68 While it makes emacs --batch detect the vast majority of stdout
69 write failures, errors were still ignored whenever the output size is
70 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
71 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
72 && echo FAIL: ignored write error
73 FAIL: ignored write error
74 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
75 && echo FAIL: ignored write error
76 FAIL: ignored write error
77 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
78
8eca8a7c
AS
792011-09-23 Andreas Schwab <schwab@linux-m68k.org>
80
81 * emacs.c (Fkill_emacs): In noninteractive mode exit
82 non-successfully if a write error occurred on stdout. (Bug#9574)
83
3341db62
EZ
842011-09-21 Eli Zaretskii <eliz@gnu.org>
85
86 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
87 the xassert test.
88
89 * dispextern.h (struct it): Update the comment documenting what
90 can it->OBJECT be.
91
8c203dbf
EZ
922011-09-20 Eli Zaretskii <eliz@gnu.org>
93
94 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
95 a display string, extend search for cursor position to end of row.
96 (find_row_edges): If the row ends in a newline from a display
97 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
98 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
99 (Fcurrent_bidi_paragraph_direction): Fix search for previous
100 non-empty line. Fixes confusing cursor motion with arrow keys at
101 the beginning of a line that starts with whitespace.
8c203dbf 102
a4824228
LMI
1032011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
104
105 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
106 (bug#9493).
107
33ed493b
CY
1082011-09-18 Chong Yidong <cyd@stupidchicken.com>
109
110 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
111 boolean (Bug#9154).
112
56cd55c8
EZ
1132011-09-18 Eli Zaretskii <eliz@gnu.org>
114
115 * xdisp.c (display_line): Record maximum and minimum buffer
116 positions even if no glyphs were produced (e.g., by a zero-width
117 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
118 buffer positions that will be removed from the glyph row because
119 they don't fit.
c02dcedf
EZ
120 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
121 column is beyond frame width: don't subtract 1 "pixel" when
122 computing width of the stretch.
3e62b7e0
EZ
123 (reseat_at_next_visible_line_start): Undo the change made on
124 2011-09-17 that saved paragraph information and restored it after
125 the call to `reseat'. (Bug#9545)
56cd55c8 126
5ed99d36 1272011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
128
129 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
130 and turn window cursor on if cleared (Bug#9415).
131
5ed99d36 1322011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
133
134 * search.c (boyer_moore): Take unibyte characters from pattern
135 literally. (Bug#9458)
136
9bade7b2
EZ
1372011-09-18 Eli Zaretskii <eliz@gnu.org>
138
139 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
140
e5e9d610
PE
1412011-09-18 Paul Eggert <eggert@cs.ucla.edu>
142
87e4427a
PE
143 Fix minor problem found by static checking.
144 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
145 initialized, to pacify gcc -Wuninitialized.
146
e5e9d610
PE
147 * fileio.c: Report proper errno when syscall falls.
148 (Finsert_file_contents): Save and restore errno,
149 so that report_file_error outputs the correct diagnostic.
150 (Fwrite_region) [CLASH_DETECTION]: Likewise.
151
a1674f0b
EZ
1522011-09-18 Eli Zaretskii <eliz@gnu.org>
153
154 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
155
fbfb6dd4
EZ
1562011-09-17 Eli Zaretskii <eliz@gnu.org>
157
158 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
159 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
160
bb187662
EZ
1612011-09-17 Eli Zaretskii <eliz@gnu.org>
162
1137e8b8
EZ
163 * xdisp.c (reseat_at_next_visible_line_start): Keep information
164 about the current paragraph and restore it after the call to
165 reseat.
166
167 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
168 (bidi_find_paragraph_start): Search back for paragraph beginning
169 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
170 (bidi_move_to_visually_next): Only trigger paragraph-related
171 computations when the last character is a newline or at EOB, not
172 just any NEUTRAL_B. (Bug#9470)
173
bb187662
EZ
174 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
175 truncated lines if point is covered by a display string. (Bug#9524)
176
2e621251
PE
1772011-09-16 Paul Eggert <eggert@cs.ucla.edu>
178
179 * xselect.c: Relax test for outgoing X longs (Bug#9498).
180 (cons_to_x_long): New function.
181 (lisp_data_to_selection_data): Use it. Correct the test for
182 short-versus-long data; it was negated. Break out of vector
183 loop, for efficiency, when a long datum is discovered.
184
91a15bc6
SM
1852011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
186
187 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
188
b41c3a35
EZ
1892011-09-16 Eli Zaretskii <eliz@gnu.org>
190
191 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
192 GCC PR/17406) by declaring this function with external scope.
193
7812ba2d
PE
1942011-09-15 Paul Eggert <eggert@cs.ucla.edu>
195
196 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
197 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
198
cf7edc2a
AS
1992011-09-15 Andreas Schwab <schwab@linux-m68k.org>
200
201 * editfns.c (Fformat): Correctly handle text properties on "%%".
202
bd01620e
EZ
2032011-09-15 Eli Zaretskii <eliz@gnu.org>
204
205 * xterm.c (x_draw_composite_glyph_string_foreground):
206 * w32term.c (x_draw_composite_glyph_string_foreground):
207 * term.c (encode_terminal_code):
208 * composite.c (composition_update_it, get_composition_id):
209 * xdisp.c (get_next_display_element)
210 (fill_composite_glyph_string): Add comments about special meaning
211 of TAB characters in a composition.
212
a02719a3
PE
2132011-09-15 Paul Eggert <eggert@cs.ucla.edu>
214
215 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
216 This occurs when processing a multibyte format.
217 Problem reported by Wolfgang Jenker.
a02719a3 218
72589a3c
JB
2192011-09-15 Johan Bockgård <bojohan@gnu.org>
220
221 * xdisp.c (try_cursor_movement): Only check for exact match if
222 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
223
1c14176c
PE
2242011-09-14 Paul Eggert <eggert@cs.ucla.edu>
225
226 Remove unused external symbols.
227 * dispextern.h (calc_pixel_width_or_height): Remove decl.
228 * xdisp.c (calc_pixel_width_or_height): Now static.
229 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
230 * indent.c (check_display_width):
231 * w32term.c: Fix comment to match code.
232 * xterm.c, xterm.h (x_catching_errors): Remove.
233
d2eea5b5
PE
2342011-09-14 Paul Eggert <eggert@cs.ucla.edu>
235
236 * xselect.c: Use signed conversions more consistently (Bug#9498).
237 (selection_data_to_lisp_data): Assume incoming selection data are
238 signed integers, not unsigned. This is to be consistent with
239 outgoing selection data, which was modified to use signed integers
240 in as part of the fix to Bug#9196 in response to Jan D.'s comment
241 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
242 expects long, not unsigned long.
243
46888499
EZ
2442011-09-14 Eli Zaretskii <eliz@gnu.org>
245
246 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
247 computation of loop end. Reported by Johan Bockgård
248 <bojohan@gnu.org>.
249
ef8ef9fb
CY
2502011-09-13 Chong Yidong <cyd@stupidchicken.com>
251
252 * frame.c (Fother_visible_frames_p): Function deleted.
253
fa819fed
EZ
2542011-09-12 Eli Zaretskii <eliz@gnu.org>
255
256 * indent.c (compute_motion): Process display vector front to back
257 rather than the other way around. (Bug#2496)
258
2ba8e008
SM
2592011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
260
261 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
262
20f53c69
CY
2632011-09-11 Chong Yidong <cyd@stupidchicken.com>
264
265 * minibuf.c (Fread_from_minibuffer): Doc fix.
266
d562d7a4
EZ
2672011-09-11 Eli Zaretskii <eliz@gnu.org>
268
269 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
270 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
271
1c4d7f3d
LMI
2722011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
273
274 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
275 value for non-existent files.
276
b885bf36
EZ
2772011-09-11 Eli Zaretskii <eliz@gnu.org>
278
279 * fileio.c (Finsert_file_contents): If the file cannot be opened,
280 set its "size" to -1. This will set the modtime_size field of
281 the corresponding buffer to -1, which is what
282 verify-visited-file-modtime expects for files that do not exist.
283 (Bug#9139)
284
6612f0bf
PE
2852011-09-11 Paul Eggert <eggert@cs.ucla.edu>
286
287 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
288 here ...
289 * lisp.h: ... from here. push_key_description is no longer
290 defined in keyboard.c, so its declaration should not be in
291 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
292 logically belongs with push_key_description.
293
dfb3f755
PE
2942011-09-10 Paul Eggert <eggert@cs.ucla.edu>
295
296 * buffer.h: Include <sys/types.h> instead of <time.h>.
297 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
298 Problem reported by Herbert J. Skuhra.
299
3134906c
LMI
3002011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
301
302 * xml.c (parse_region): Make the parsing work for
303 non-comment-starting XML files again (bug#9144).
304
8d903f4e
AS
3052011-09-10 Andreas Schwab <schwab@linux-m68k.org>
306
307 * image.c (gif_load): Fix calculation of bottom and right corner.
308 (Bug#9468)
309
80ad64f4
EZ
3102011-09-10 Eli Zaretskii <eliz@gnu.org>
311
312 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
313 redisplay in small windows.
314
208a048d
EZ
3152011-09-09 Eli Zaretskii <eliz@gnu.org>
316
317 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
318
9b1c252e
MR
3192011-09-08 Martin Rudalics <rudalics@gmx.at>
320
321 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
322 Operate on live windows only.
323
2949f33b
JB
3242011-09-08 Juanma Barranquero <lekktu@gmail.com>
325
326 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
327
e08dcafd
EZ
3282011-09-07 Eli Zaretskii <eliz@gnu.org>
329
330 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
331 only under bidi iteration.
332
115b96bd
JD
3332011-09-07 Jan Djärv <jan.h.d@swipnet.se>
334
335 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
336
c8199d0f
PE
3372011-09-06 Paul Eggert <eggert@cs.ucla.edu>
338
339 isnan: Fix porting problem to Solaris 10 with bundled gcc.
340 Without this fix, the command to link temacs failed due to an
341 undefined symbol __builtin_isnan. This is because
342 /usr/include/iso/math_c99.h #defines isnan(x) to
343 __builtin_isnan(x), but the bundled gcc, which identifies itself
344 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
345 a __builtin_isnan.
346 * floatfns.c (isnan): #undef, and then #define to a clone of
347 what's in data.c.
348 (Fisnan): Always define, since it's always available now.
349 (syms_of_floatfns): Always define isnan at the Lisp level.
350
e39b275c 3512011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
352
353 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
354
b2db44d9 3552011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 356
f4af5137 357 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
358 The previous code assumed that file offsets (off_t values) fit in
359 EMACS_INT variables, which is not true on typical 32-bit hosts.
360 The code messed up by falsely reporting buffer overflow in cases
361 such as (insert-file-contents "big" nil 1 2) into an empty buffer
362 when "big" contains more than 2**29 bytes, even though this
363 inserts just one byte and does not overflow the buffer.
364 (Finsert_file_contents): Store file offsets as off_t
365 values, not as EMACS_INT values. Check for overflow when
366 converting between EMACS_INT and off_t. When checking for
367 buffer overflow or for overlap, take the offsets into account.
368 Don't use EMACS_INT for small values where int suffices.
369 When checking for overlap, fix a typo: ZV was used where
370 ZV_BYTE was intended.
371 (Fwrite_region): Don't assume off_t fits into 'long'.
372 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
373
ecfc0a49
MA
3742011-09-05 Michael Albinus <michael.albinus@gmx.de>
375
376 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
377
6511acf2 3782011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 379
0999621a 380 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
381
382 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 383 (esprintf, exprintf, evxprintf): New functions.
62f19c19
PE
384 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
385 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
386 (modify_event_symbol): Do not assume that the length of
387 name_alist_or_stem is safe to alloca and fits in int.
388 (Fexecute_extended_command): Likewise for function name and binding.
389 (Frecursion_depth): Wrap around reliably on integer overflow.
390 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
391 since some callers pass EMACS_INT values.
392 (Fsingle_key_description): Don't crash if symbol name contains more
393 than MAX_ALLOCA bytes.
394 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
395 (get_minibuffer): Arg is now EMACS_INT, not int.
396 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 397 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
398 * window.h (command_loop_level, minibuf_level): Reflect API changes.
399
2be7d702
PE
400 * dbusbind.c (signature_cat): New function.
401 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
402 Do not overrun buffer; instead, report string overflow.
403
9d1df220
PE
404 * dispnew.c (add_window_display_history): Don't overrun buffer.
405 Truncate instead; this is OK since it's just a log.
406
33ef5c64
PE
407 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
408 even if the time zone offset is outlandishly large.
409 Don't mishandle offset == INT_MIN.
410
66c6fdd5
PE
411 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
412 when creating daemon; the previous buffer-overflow check was incorrect.
413
d749b01b
PE
414 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
415 which has the guts of the old verror function.
416
b5cd1905
PE
417 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
418 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
419
6e1a67fb
PE
420 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
421 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 422 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 423 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
424 length of string rather than counting it via multiple sprintfs;
425 that's simpler and more reliable.
c21721cc
PE
426 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
427 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
428 sprintf, in case result does not fit in int.
429
c57b67fc
PE
430 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
431 (fontset_from_font): Print it.
432
8a401434
PE
433 * frame.c (tty_frame_count): Now printmax_t, not int.
434 (make_terminal_frame, set_term_frame_name): Print it.
435 (x_report_frame_params): In X, window IDs are unsigned long,
436 not signed long, so print them as unsigned.
437 (validate_x_resource_name): Check for implausibly long names,
438 and don't assume name length fits in 'int'.
439 (x_get_resource_string): Don't blindly alloca invocation name;
440 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
441 not fit in int.
442
6e1a67fb
PE
443 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
444 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
445 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
446
0df02bf3
PE
447 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
448 Use esprintf, not sprintf, in case result does not fit in int.
449
48e30793
PE
450 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
451 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
452 it as a large positive number.
453 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
454 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
455
a66ff6d8
PE
456 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
457 in case result does not fit in int.
458
aca216ff
PE
459 * print.c (float_to_string): Detect width overflow more reliably.
460 (print_object): Make sprintf buffer a bit bigger, to avoid potential
461 buffer overrun. Don't assume list length fits in 'int'. Treat
462 print length of 0 as 0, not as infinity; to be consistent with other
463 uses of print length in this function. Don't overflow print length
464 index. Don't assume hash table size fits in 'long', or that
465 vectorlike size fits in 'unsigned long'.
466
31c286f7
PE
467 * process.c (make_process): Use printmax_t, not int, to format
468 process-name gensyms.
469
55e5faa1
PE
470 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
471
80f2e268
PE
472 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
473 to avoid potential buffer overrun.
474
670741ab
PE
475 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
476 if X resource line is longer than 512 bytes.
477
b7163a50
PE
478 * xfns.c (x_window): Make sprintf buffer a bit bigger
479 to avoid potential buffer overrun.
480
ae58ff1f
PE
481 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
482
c43c8a6a
PE
483 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
484
3f8236f4
PE
4852011-09-04 Paul Eggert <eggert@cs.ucla.edu>
486
53e9fe90 487 Integer overflow fixes for scrolling, etc.
6511acf2
PE
488 Without these, Emacs silently mishandles large integers sometimes.
489 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
490 it were "C-u 1 M-x recenter" on a typical 64-bit host.
491
6511acf2
PE
492 * xdisp.c (try_window_id): Check Emacs fixnum range before
493 converting to 'int'.
806add1d 494
6511acf2 495 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
496 Check that an Emacs fixnum is in range before assigning it to 'int'.
497 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
498 values converted from Emacs fixnums.
499 (Frecenter): Don't wrap around a line count if it is out of 'int'
500 range; instead, treat it as an extreme value.
501 (Fset_window_configuration, compare_window_configurations):
502 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
503
6511acf2
PE
504 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
505 that can exceed INT_MAX. Check that EMACS_INT value is in range
506 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
507 (match_limit): Don't assume that a fixnum can fit in 'int'.
508
6511acf2 509 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
510 exceed INT_MAX.
511
6511acf2 512 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
513 (Fvertical_motion): Don't wrap around LINES values that don't fit
514 in 'int'. Instead, treat them as extreme values. This is good
515 enough for windows, which can't have more than INT_MAX lines anyway.
516
fcb901a7
LMI
5172011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
518
0f2f6b6d
LMI
519 * Require libxml/parser.h to avoid compilation warning.
520
fcb901a7
LMI
521 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
522
523 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
524 since this reportedly can destroy thread storage.
525
6e20a0d4
CY
5262011-08-30 Chong Yidong <cyd@stupidchicken.com>
527
528 * syntax.c (find_defun_start): Update all cache variables if
529 exiting early (Bug#9401).
530
148ae00e
EZ
5312011-08-30 Eli Zaretskii <eliz@gnu.org>
532
f6cfbd8f
EZ
533 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
534
148ae00e
EZ
535 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
536 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
537 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
538
539 * term.c (tty_append_glyph): New function.
540 (produce_stretch_glyph): Static function and its prototype deleted.
541
542 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
543 prototypes.
544
c4a07a4c
PE
5452011-08-29 Paul Eggert <eggert@cs.ucla.edu>
546
547 * image.c (parse_image_spec): Check for nonnegative, not for positive,
548 when checking :margin (Bug#9390).
549 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
550 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
551 so that the name doesn't mislead. All uses changed.
552
6bc8cd65
JB
5532011-08-28 Johan Bockgård <bojohan@gnu.org>
554
555 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
556 set_tty_hooks.
557
dca4927e
EZ
5582011-08-27 Eli Zaretskii <eliz@gnu.org>
559
560 * xdisp.c (move_it_to): Don't bail out early when reaching
561 position beyond to_charpos, if we are scanning backwards.
562 (move_it_vertically_backward): When DY == 0, make sure we get to
563 the first character in the line after the newline.
564
f2cad773
PE
5652011-08-27 Paul Eggert <eggert@cs.ucla.edu>
566
567 * ccl.c: Improve and simplify overflow checking (Bug#9196).
568 (ccl_driver): Do not generate an out-of-range pointer.
569 (Fccl_execute_on_string): Remove unnecessary check for
570 integer overflow, noted by Stefan Monnier in
571 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
572 Remove a FIXME that didn't need fixing.
573 Simplify the newly-introduced buffer reallocation code.
574
0cae2cdb
JB
5752011-08-27 Juanma Barranquero <lekktu@gmail.com>
576
577 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
578
5fc295a4 5792011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 580
70c60eb2 581 Integer and memory overflow issues (Bug#9196).
726e0ab1 582
d31850da
PE
583 * doc.c (get_doc_string): Rework so that
584 get_doc_string_buffer_size is the actual buffer size, rather than
585 being 1 less than the actual buffer size; this makes xpalloc more
586 convenient.
587
a69fbedb
PE
588 * image.c (x_allocate_bitmap_record, cache_image):
589 * xselect.c (Fx_register_dnd_atom):
590 Simplify previous changes by using xpalloc.
591
fe5c5d37
PE
592 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
593 since either will do and ptrdiff_t is convenient with xpalloc.
594
0065d054
PE
595 * charset.c (charset_table_size)
596 (struct charset_sort_data.priority): Now ptrdiff_t.
597 (charset_compare): Don't overflow if priorities differ greatly.
598 (Fsort_charsets): Don't assume list length fits in int.
599 Check for size-calculation overflow when allocating sort data.
600 (syms_of_charset): Allocate an initial charset table that is
601 just under 64 KiB, to avoid problems with glibc malloc and mmap.
602
603 * cmds.c (internal_self_insert): Check for size-calculation overflow.
604
605 * composite.h (struct composition.glyph_len): Now int, not unsigned.
606 The actual value is always <= INT_MAX, and leaving it unsigned made
607 overflow checking harder.
608
609 * dispextern.h (struct glyph_matrix.rows_allocated)
610 (struct face_cache.size): Now ptrdiff_t, for convenience in use
611 with xpalloc. The values are still always <= INT_MAX.
612
613 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
614
615 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
616 (SAFE_NALLOCA): New macro.
617
618 * region-cache.c (struct boundary.pos, find_cache_boundary)
619 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
620 (set_cache_region, invalidate_region_cache)
621 (revalidate_region_cache, know_region_cache, region_cache_forward)
622 (region_cache_backward, pp_cache):
623 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
624 so that ptrdiff_t * can be passed to xpalloc.
625 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
626 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
627 (pp_cache): Don't assume cache_len fits in int.
628 * region-cache.h: Adjust extern decls to match.
629
630 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
631 EMACS_INT, since either will do, for xpalloc.
632
633 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
634 (xnmalloc, xnrealloc, xpalloc): New functions.
635
726e0ab1
PE
636 * bidi.c (bidi_shelve_header_size): New constant.
637 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
638 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
639
51f30bc5 640 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
641 * buffer.c (overlays_at, overlays_in, record_overlay_string)
642 (overlay_strings):
643 Don't update size of array until after memory allocation succeeds,
644 because xmalloc/xrealloc may not return.
0065d054
PE
645 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
646 now that we have proper integer overflow checking.
647 (record_overlay_string, overlay_strings): Catch overflows when
648 calculating size of overlay_str_buf.
726e0ab1 649
0065d054
PE
650 * callproc.c (Fcall_process): Check for size overflow when
651 calculating size of args2.
652 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
653 Normally we prefer signed values, but sticking with ptrdiff_t would
654 require adding more-complicated checks.
726e0ab1
PE
655
656 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
657 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
658 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 659 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
660
661 * character.c (Fstring): Check for size-calculation overflow.
662
663 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
664 unnecessary integer overflow. Check for size overflow.
665 (encode_coding_object): Don't update size until xmalloc succeeds.
666
667 * composite.c (get_composition_id): Check for overflow in glyph
668 length calculations.
669
670 Integer and memory overflow fixes for display code.
671 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
672 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
673 (scrolling_window): Check for overflow in size calculations.
674 (line_draw_cost, realloc_glyph_pool, add_row_entry):
675 Don't assume glyph table len fits in int.
676 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
677 (row_table_size): Now ptrdiff_t, not int.
678 (scrolling_window): Avoid overflow in size calculations.
679 Don't update size until allocation succeeds.
680 * fns.c (concat): Check for overflow in size calculations.
681 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
682 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
683 (NEXT_ALMOST_PRIME_LIMIT): New constant.
684
685 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
686 (get_doc_string): Check for size calculation overflow.
687 Don't update size until allocation succeeds.
688 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
689 EMACS_INT, where ptrdiff_t will do.
690 (Fsubstitute_command_keys): Check for string overflow.
691
692 * editfns.c (set_time_zone_rule): Don't assume environment length
693 fits in int.
694 (message_length): Now ptrdiff_t, not int.
695 (Fmessage_box): Don't update size until allocation succeeds.
696 Don't assume message length fits in int.
697 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
698
0065d054
PE
699 * emacs.c (main): Do not reallocate argv, since there is a null at
700 the end that can be overwritten, and this way there's no need to
701 worry about size-calculation overflow.
702 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
703
704 * eval.c (init_eval_once, grow_specpdl): Don't update size until
705 alloc succeeds.
706 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
707
708 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
709 (x_set_scroll_bar_width, x_figure_window_size):
710 Check for integer overflow.
711 (x_set_alpha): Do not assume XINT fits in int.
712
713 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
714 This is for the members text_lines, text_cols, total_lines, total_cols,
715 where the system imposes an 'int' limit.
716
717 * fringe.c (Fdefine_fringe_bitmap):
718 Don't update size until alloc works.
719
720 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
721 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
722
723 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
724 Check for size-calculation overflow.
725 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
726 do, as we prefer signed integers.
727 (id_to_widget.max_size, id_to_widget.used)
728 (xg_store_widget_in_map, xg_remove_widget_from_map)
729 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
730 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
731 Use and return ptrdiff_t, not int.
732 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
733 * gtkutil.h: Change prototypes to match the above.
734
735 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
736 are duplicate now that they've been promoted to lisp.h.
737 (x_allocate_bitmap_record, x_alloc_image_color)
738 (make_image_cache, cache_image, xpm_load):
739 Don't update size until alloc is done.
740 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
741 (x_detect_edges):
3256efce 742 Check for size calculation overflow.
726e0ab1
PE
743 (ct_colors_allocated_max): New constant.
744 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
745 overflow.
3256efce 746
726e0ab1
PE
747 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
748 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
749 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
750 Use ptrdiff_t, not int, to count maps.
751 (read_char_minibuf_menu_prompt): Check for overflow in size
752 calculations. Don't update size until allocation succeeds. Redo
753 calculations to avoid overflow.
754 * keyboard.h: Change prototypes to match the above.
755
756 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
757 to count maps.
758 (current_minor_maps): Check for size calculation overflow.
759 * keymap.h: Change prototypes to match the above.
760
761 * lread.c (read1, init_obarray): Don't update size until alloc done.
762
763 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
764 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
765
726e0ab1
PE
766 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
767 Now ptrdiff_t, not int.
768 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
769 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
770
771 * process.c (Fnetwork_interface_list): Check for overflow
772 in size calculation.
773
774 * region-cache.c (move_cache_gap): Check for size calculation overflow.
775
776 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
777 overflow. Don't bother calling xmalloc when xrealloc will do.
778
779 * search.c (Freplace_match): Check for size calculation overflow.
780 (Fset_match_data): Don't assume list lengths fit in 'int'.
781
782 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
783 for command line length. Do not attempt to address one before the
784 beginning of an array, as that's not portable.
785
786 * term.c (max_frame_lines): Remove; unused.
787 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
788 not int.
789 (encode_terminal_code, calculate_costs): Check for size
790 calculation overflow.
791 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
792 table lengths and related sizes. Don't update size until alloc
793 done. Redo calculations to avoid overflow.
794 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
795
796 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
797 subtracting pointers.
798 (gobble_line): Check for overflow more carefully. Don't update size
799 until alloc done.
800
801 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
802 Don't update size until alloc done.
803 Redo size calculations to avoid overflow.
804 Check for size calculation overflow.
0065d054 805 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
806
807 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
808 Use ptrdiff_t, not int, for sizes.
809 (store_mode_line_noprop_char): Don't update size until alloc done.
810
0065d054
PE
811 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
812 Use ptrdiff_t, not int, for sizes.
813 (Finternal_make_lisp_face, cache_face):
814 Check for size calculation overflow.
815 (cache_face): Treat size calculation overflows as if they were
816 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
817
818 * xfns.c (x_encode_text, x_set_name_internal)
819 (Fx_change_window_property): Use ptrdiff_t, not int, to count
820 sizes, since they can exceed INT_MAX in size. Check for size
821 calculation overflow.
822
0065d054
PE
823 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
824 (xg_select): Check for size calculation overflow.
726e0ab1
PE
825 Don't update size until alloc done.
826
0065d054 827 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 828 as sprintf is limited to int lengths.
1d526e2f 829
252c5ee1
PE
830 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
831 (X_LONG_MIN): New macros.
864d7ce7
PE
832 Use them to make the following changes clearer.
833 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
834 This change doesn't affect the value now, but it may help remind
835 future maintainers not to raise the value too much later.
836 (SELECTION_QUANTUM): Remove, replacing with ...
837 (selection_quantum): ... new function, which avoids overflow.
838 All uses changed.
839 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
840 assumption that selection length fits in 'int'.
841 (x_reply_selection_request, x_handle_selection_request)
842 (x_get_window_property, receive_incremental_selection)
843 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
844 (lisp_data_to_selection_data, clean_local_selection_data):
845 Use ptrdiff_t, not int, to record length of selection.
846 (x_reply_selection_request, x_get_window_property)
847 (receive_incremental_selection, x_property_data_to_lisp):
848 Redo calculations to avoid overflow.
849 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 850 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
851 something.
852 (x_get_window_property, receive_incremental_selection)
853 (lisp_data_to_selection_data, x_property_data_to_lisp):
854 Check for size-calculation overflow.
855 (x_get_window_property, receive_incremental_selection)
856 (lisp_data_to_selection_data, Fx_register_dnd_atom):
857 Don't store size until memory allocation succeeds.
858 (x_get_window_property): Plug memory leak on memory exhaustion.
859 Don't double-block input; malloc is safe here. Don't assume 2**34
860 - 4 fits in unsigned long. Add an xassert to check
861 XGetWindowProperty overflow. Be more careful about overflow
862 calculations, and distinguish size from memory overflow better.
863 (receive_incremental_selection): When tracing, don't assume
864 unsigned int is less than INT_MAX.
865 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
866 harmful) conversions of unsigned short to int.
867 (lisp_data_to_selection_data): Don't assume that integers
868 in the range -65535 through -1 fit in an X unsigned short.
869 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
870 result parameters unless successful. Rely on cons_to_unsigned
871 to report problems with elements; the old code wasn't right anyway.
872 (x_check_property_data): Check for int overflow; we cannot use
873 a wider type due to X limits.
874 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
875
726e0ab1 876 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 877
0065d054
PE
878 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
879 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
880 (x_color_cells): Don't store size until memory allocation succeeds.
881 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 882 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
883 (x_term_init): Don't assume length fits in int (sprintf is limited
884 to int size).
bc18e09d 885
ebfa62c0
PE
886 Use ptrdiff_t for composition IDs.
887 * character.c (lisp_string_width):
888 * composite.c (composition_table_size, n_compositions)
889 (get_composition_id, composition_gstring_from_id):
890 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
891 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
892 * window.c (Frecenter):
893 Use ptrdiff_t, not int, for composition IDs.
894 * composite.c (get_composition_id): Check for integer overflow.
895 * composite.h: Adjust prototypes to match the above changes.
896
d3411f89
PE
897 Use ptrdiff_t for hash table indexes.
898 * category.c (hash_get_category_set):
899 * ccl.c (ccl_driver):
900 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
901 * coding.c (coding_system_charset_list, detect_coding_system):
902 * coding.h (struct coding_system.id):
903 * composite.c (get_composition_id, gstring_lookup_cache):
904 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
905 * image.c (xpm_get_color_table_h):
906 * lisp.h (hash_lookup, hash_put):
907 * minibuf.c (Ftest_completion):
908 Use ptrdiff_t for hash table indexes, not int (which is too
909 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
910 32-bit --with-wide-int hosts).
911
e097a6fa
PE
912 * charset.c (Fdefine_charset_internal): Check for integer overflow.
913 Add a FIXME comment about memory leaks.
914 (syms_of_charset): Don't assume xmalloc returns.
915
5637687f
PE
916 Don't assume that stated character widths fit in int.
917 * character.c (Fchar_width, c_string_width, lisp_string_width):
918 * character.h (CHAR_WIDTH):
919 * indent.c (MULTIBYTE_BYTES_WIDTH):
920 Use sanitize_char_width to avoid undefined and/or bad behavior
921 with outlandish widths.
922 * character.h (sanitize_tab_width): Renamed from sanitize_width,
923 now that we have two such functions. All uses changed.
924 (sanitize_char_width): New inline function.
925
a2271ba2
PE
926 Don't assume that tab-width fits in int.
927 * character.h (sanitize_width): New inline function.
928 (SANE_TAB_WIDTH): New macro.
929 (ASCII_CHAR_WIDTH): Use it.
930 * indent.c (sane_tab_width): Remove. All uses replaced by
931 SANE_TAB_WIDTH (current_buffer).
932 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
933
18c52557
PE
934 * fileio.c: Integer overflow issues with file modes.
935 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
936
caeeedc1
PE
937 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
938 Remove unreachable code.
939 (read_hex, load_charset_map_from_file): Check for integer overflow.
940
50849c52
PE
941 * xterm.c: don't go over XClientMessageEvent limit
942 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
943 (x_send_scroll_bar_event): Likewise. Check that the size does not
944 exceed limits imposed by XClientMessageEvent, as well as the usual
945 ptrdiff_t and size_t limits.
946
b13995db
PE
947 * keyboard.c: Overflow, signedness and related fixes.
948 (make_lispy_movement): Use same integer type in forward decl
949 that is used in the definition.
950 (read_key_sequence, keyremap_step):
951 Change bufsize argument back to int, undoing my 2011-03-30 change.
952 We prefer signed types, and int is wide enough here.
953 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
954 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
955 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
956 length, not size_t. Use ptrdiff_t for index, not int.
957 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
958 possibility of integer overflow.
959
13464394
PE
960 Overflow, signedness and related fixes for images.
961
962 * dispextern.h (struct it.stack[0].u.image.image_id)
963 (struct_it.image_id, struct image.id, struct image_cache.size)
964 (struct image_cache.used, struct image_cache.ref_count):
965 * gtkutil.c (update_frame_tool_bar):
966 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
967 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
968 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
969 * nsmenu.m (update_frame_tool_bar):
970 * xdisp.c (calc_pixel_width_or_height):
971 * xfns.c (image_cache_refcount):
972 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
973 on typical 64-bit hosts.
974
975 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
976 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
977 Omit unnecessary casts to int.
978 (parse_image_spec): Check that integers fall into 'int' range
979 when the callers expect that.
980 (image_ascent): Redo ascent calculation to avoid int overflow.
981 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
982 (lookup_image): Remove unnecessary tests.
983 (xbm_image_p): Locals are now of int, not EMACS_INT,
984 since parse_image_check makes sure they fit into int.
985 (png_load, gif_load, svg_load_image):
986 Prefer int to unsigned where either will do.
987 (tiff_handler): New function, combining the cores of the
988 old tiff_error_handler and tiff_warning_handler. This
989 function is rewritten to use vsnprintf and thereby avoid
990 stack buffer overflows. It uses only the features of vsnprintf
991 that are common to both POSIX and native Microsoft.
992 (tiff_error_handler, tiff_warning_handler): Use it.
993 (tiff_load, gif_load, imagemagick_load_image):
994 Don't assume :index value fits in 'int'.
995 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
996 (imagemagick_load_image): Check that crop parameters fit into
997 the integer types that MagickCropImage accepts. Don't assume
998 Vimagemagick_render_type has a nonnegative value. Don't assume
999 size_t fits in 'long'.
1000 (gs_load): Use printmax_t to print the widest integers possible.
1001 Check for integer overflow when computing image height and width.
1002
c11821d4
EZ
10032011-08-26 Eli Zaretskii <eliz@gnu.org>
1004
1005 * xdisp.c (redisplay_window): Don't force window start if point
1006 will be invisible in the resulting window. (Bug#9324)
1007
0c95fcf7
EZ
10082011-08-25 Eli Zaretskii <eliz@gnu.org>
1009
1010 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1011 the display spec is of the form `(space ...)'.
1012 (handle_display_spec): Return the value returned by
1013 handle_single_display_spec, not just 1 or zero.
1014 (handle_single_display_spec): If the display spec is of the form
1015 `(space ...)', and specifies display in the text area, return 2
1016 rather than 1.
fee65a97 1017 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
1018 accurately, and prefer exact match for point under bidi. Don't
1019 advance `row' beyond the last row of the window.
0c95fcf7
EZ
1020
1021 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1022 into disp_prop; all users changed.
1023
1024 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1025 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1026 for the text covered by the display property.
1027
e4ed06f1
CY
10282011-08-25 Chong Yidong <cyd@stupidchicken.com>
1029
1030 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1031 Change return value to nil.
1032 (Frecord_buffer): Delete unused function.
1033
f67cdd7f
EZ
10342011-08-24 Eli Zaretskii <eliz@gnu.org>
1035
5980d4c6
EZ
1036 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1037 buffers, return left-to-right.
8610fe8b
EZ
1038 (set_cursor_from_row): Consider candidate row a win if its glyph
1039 represents a newline and point is on that newline. Fixes cursor
1040 positioning on the newline at EOL of R2L text within L2R
1041 paragraph, and vice versa.
1042 (try_cursor_movement): Check continued rows, in addition to
1043 continuation rows. Fixes unwarranted scroll when point enters a
1044 continued line of R2L text within an L2R paragraph, or vice versa.
1045 (cursor_row_p): Consider the case of point being equal to
1046 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1047 from the end of a short line to the beginning of a continued line
1048 of R2L text within L2R paragraph.
1049 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1050 composed characters.
5980d4c6 1051
f67cdd7f
EZ
1052 * bidi.c (bidi_check_type): Use xassert.
1053 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1054 members.
1055
bca633fb
EZ
10562011-08-23 Eli Zaretskii <eliz@gnu.org>
1057
1058 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1059 a character.
1060
4a5885a7
CY
10612011-08-23 Chong Yidong <cyd@stupidchicken.com>
1062
1063 * nsfont.m (ns_otf_to_script): Fix typo.
1064
0902a04e
KH
10652011-08-22 Kenichi Handa <handa@m17n.org>
1066
1067 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1068 extra slot even if the purpose is char-code-property-table.
1069
1a2e6670
EZ
10702011-08-23 Eli Zaretskii <eliz@gnu.org>
1071
8ddde651
EZ
1072 * xdisp.c (redisplay_window): When computing centering_position,
1073 account for the height of the header line. (Bug#8874)
1074
425cc014
EZ
1075 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1076 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1077 candidate is selected by the mouse, and that candidate has a
1078 composed character under the mouse.
1079
1a2e6670
EZ
1080 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1081 coordinates reported by pos-visible-in-window-p for a composed
1082 character in column zero.
1083
8b76d6f8
SM
10842011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1085
1086 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1087
dac347dd
EZ
10882011-08-22 Eli Zaretskii <eliz@gnu.org>
1089
1090 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1091 consider it a hit if to_charpos is anywhere in the range of the
1092 composed buffer positions.
1093
e013fb34
CY
10942011-08-22 Chong Yidong <cyd@stupidchicken.com>
1095
1096 * image.c (gif_load): Don't assume that each subimage has the same
1097 dimensions as the base image. Handle disposal method that is
1098 "undefined" by the gif spec (Bug#9335).
1099
bd1ba3e8
CY
11002011-08-20 Chong Yidong <cyd@stupidchicken.com>
1101
1102 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1103 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1104
54a1215b
EZ
11052011-08-19 Eli Zaretskii <eliz@gnu.org>
1106
823564e5
EZ
1107 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1108 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1109 from an Org mode buffer to a Speedbar frame.
1110
54a1215b
EZ
1111 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1112 a composition, take its buffer position from IT->cmp_it.charpos.
1113 Fixes cursor positioning at the beginning of a line that begins
1114 with a composed character.
1115
9778ebcc
EZ
11162011-08-18 Eli Zaretskii <eliz@gnu.org>
1117
0be6ee06
EZ
1118 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1119 character bidirectional type, use STRONG_L instead. Fixes crashes
1120 in a buffer produced by `describe-categories'.
1121
9778ebcc
EZ
1122 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1123 members before the level stack, so they would be saved and
1124 restored when copying iterator state. Fixes incorrect reordering
1125 around TABs covered by display properties.
1126
156bffbe
AS
11272011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1128
1129 * process.c (Fnetwork_interface_list): Correctly determine buffer
1130 size.
1131
72ad093b
CY
11322011-08-17 Chong Yidong <cyd@stupidchicken.com>
1133
1134 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1135 (internal_condition_case_2, internal_condition_case_n):
1136 Remove unnecessary aborts (Bug#9081).
72ad093b 1137
35774242
EZ
11382011-08-17 Eli Zaretskii <eliz@gnu.org>
1139
1140 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1141 has no `load' handler, try opening the file locally. (Bug#9311)
1142
db76dd85
KB
11432011-08-16 Ken Brown <kbrown@cornell.edu>
1144
1145 * gmalloc.c: Expand comment.
1146
b215eee5
EZ
11472011-08-16 Eli Zaretskii <eliz@gnu.org>
1148
1149 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1150 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1151
a4579d33
KB
11522011-08-16 Ken Brown <kbrown@cornell.edu>
1153
1154 Fix memory allocation problems in Cygwin build (Bug#9273).
1155
1156 * unexcw.c ( __malloc_initialized): Declare external variable.
1157 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1158
8b76d6f8
SM
1159 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1160 New variables.
a4579d33
KB
1161 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1162 dumped emacs.
1163 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1164 in the static heap.
1165 [CYGWIN] (special_realloc): New function.
1166 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1167 requests to realloc storage in the static heap.
1168
3ebec551
PE
11692011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1170
1171 * bidi.c (bidi_initialize): Remove unused local.
1172
9fd8be00
EZ
11732011-08-15 Eli Zaretskii <eliz@gnu.org>
1174
474a8465
EZ
1175 * biditype.h: File removed.
1176
1177 * bidimirror.h: File removed.
1178
1179 * deps.mk (bidi.o): Remove biditype.h and
1180 bidimirror.h.
1181
1182 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1183 bidimirror.h.
1184
1185 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1186
1187 * chartab.c: Improve commentary for the uniprop_table API.
1188
32413314
EZ
1189 * bidi.c (bidi_paragraph_init): Support zero value of
1190 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1191 (bidi_initialize): Use uniprop_table instead of including
1192 biditype.h and bidimirror.h.
32413314 1193
9fd8be00
EZ
1194 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1195 coordinates of the iterator when restoring from ppos_it.
1196 (Bug#9296)
1197
5cf2b69b
KH
11982011-08-14 Kenichi Handa <handa@m17n.org>
1199
1200 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1201 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1202
daf17d00
EZ
12032011-08-14 Eli Zaretskii <eliz@gnu.org>
1204
1205 * xdisp.c (move_it_in_display_line_to): Don't invoke
1206 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1207 ppos_it. Fixes vertical cursor motion when line beginning is
1208 covered by an image. (Bug#9296)
1209
08e3161a
JD
12102011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1211
1212 * nsterm.h (ns_run_ascript): Declare.
1213 (NSAPP_DATA2_RUNASSCRIPT): Define.
1214
1215 * nsfns.m (as_script, as_result, as_status): New static variables.
1216 (ns_run_ascript): New function.
5e617bc2 1217 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1218 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1219 the event loop. Get status from as_status (Bug#7276).
1220
1221 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1222 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1223 the event loop (Bug#7276).
1224
a3720aa2
AS
12252011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1226
1227 * gnutls.c (QCgnutls_bootprop_priority)
1228 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1229 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1230 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1231 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1232 (QCgnutls_bootprop_verify_hostname_error)
1233 (QCgnutls_bootprop_callbacks_verify): Rename from
1234 Qgnutls_bootprop_..., all uses changed.
1235
1236 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1237 uses changed.
1238
0a0d27fb
PE
12392011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1240
19d5c50c
PE
1241 * xfaces.c (Qframe_set_background_mode): Now static.
1242 * dispextern.h (Qframe_set_background_mode): Remove decl.
1243
0a0d27fb
PE
1244 * process.c (Fnetwork_interface_info): Declare local only if needed.
1245
377538cb
JD
12462011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1247
1248 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1249 (Fnetwork_interface_list): Allocate in increments of bytes instead
1250 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1251 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1252 sockaddr.
1253 (struct ifflag_def): notrailers is smart on OSX.
1254 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1255 Get hardware address with getifaddrs if available.
1256
08fff70c
EZ
12572011-08-12 Eli Zaretskii <eliz@gnu.org>
1258
1259 * xdisp.c (iterate_out_of_display_property): xassert that
1260 IT->position is set to within IT->object's boundaries. Break from
1261 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1262 when IT->position is set up wrongly due to some bug.
1263 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1264 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1265 entry. Force push_it to save on the stack the current
1266 buffer/string position, to be restored by pop_it. Fix flags in
1267 the iterator structure wrt the object coming from a display
1268 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1269 properties. (Bug#9284)
1270
7be1c708 12712011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1272
7be1c708
CY
1273 * fontset.c (fontset_get_font_group): Add proper type checks.
1274 (Bug#9172)
aac0c6e3 1275
7be1c708 12762011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1277
7be1c708
CY
1278 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1279 and LC_VERSION_MIN_MACOSX.
1280 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1281 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1282
97bb72a6
EZ
12832011-08-08 Eli Zaretskii <eliz@gnu.org>
1284
1285 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1286 no-display-properties-and-no-overlays under bidi display.
1287 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1288 properties and overlays.
97bb72a6 1289
d5617611
CY
12902011-08-08 Chong Yidong <cyd@stupidchicken.com>
1291
37e11a63
CY
1292 * editfns.c (Fset_time_zone_rule): Document relationship with the
1293 setenv function.
1294
d5617611
CY
1295 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1296 the font entity extracted from the cache (Bug#8109).
1297
58872834
CY
12982011-08-07 Chong Yidong <cyd@stupidchicken.com>
1299
1300 * composite.c (autocmp_chars): Don't reset point. That is done by
1301 restore_point_unwind (Bug#5984).
1302
75bfc667
JL
13032011-08-07 Juri Linkov <juri@jurta.org>
1304
1305 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1306 to show the arg `TIME' instead of `TIMEVAL'.
1307
d1410150
EZ
13082011-08-06 Eli Zaretskii <eliz@gnu.org>
1309
1310 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1311 display property strides EOL and includes a newline, as in
1312 longlines-mode. (Bug#9254)
75b771e4
EZ
1313 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1314 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1315
1316 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1317 is non-zero, even if the data buffer is NULL. Fixes a crash in
1318 vertical-motion with longlines-mode. (Bug#9254)
1319
35928349
EZ
13202011-08-05 Eli Zaretskii <eliz@gnu.org>
1321
ec7cc85b
EZ
1322 * bidi.c <bidi_cache_total_alloc>: Now static.
1323 (bidi_initialize): Initialize bidi_cache_total_alloc.
1324
8b76d6f8 1325 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1326 cache. (Bug#9221)
1327
1328 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1329 amount allocated this far in `bidi_cache_total_alloc'.
1330 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1331 non-zero, only free the data buffer without restoring the cache
1332 contents. All callers changed.
1333
1334 * dispextern.h (bidi_unshelve_cache): Update prototype.
1335
1336 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1337 (move_it_in_display_line, move_it_to)
1338 (move_it_vertically_backward, move_it_by_lines): Replace the call
1339 to xfree to an equivalent call to bidi_unshelve_cache.
1340 (move_it_in_display_line_to): Fix logic of returning
412b6358 1341 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1342
e2e2423b
EZ
13432011-08-05 Eli Zaretskii <eliz@gnu.org>
1344
1345 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1346 came from a string character with a `cursor' property. (Bug#9229)
1347
ae9e757a
JD
13482011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1349
1350 * Makefile.in (LIB_PTHREAD): New variable.
1351 (LIBES): Add LIB_PTHREAD (Bug#9216).
1352
1353 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1354 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1355
213bd7f2
AS
13562011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1357
1358 * regex.c (re_iswctype): Remove some redundant boolean
1359 conversions.
1360
99aaf75f
JD
13612011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1362
1363 * xterm.c (x_find_topmost_parent): New function.
1364 (x_set_frame_alpha): Find topmost parent window with
1365 x_find_topmost_parent and set the property there also (bug#9181).
1366 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1367
c74e9d86
PE
13682011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1369
1370 * callproc.c (Fcall_process): Avoid vfork clobbering
1371 the local vars buffer, coding_systems, current_dir.
1372
640c8776
SM
13732011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1374
1375 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1376
f26d0e4c
PE
13772011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1378
8a10d76c
PE
1379 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1380 so that it is not optimized away.
1381
f26d0e4c
PE
1382 * xdisp.c (compute_display_string_pos): Remove unused local.
1383
55439c61
EZ
13842011-08-02 Eli Zaretskii <eliz@gnu.org>
1385
1386 Fix slow cursor motion and scrolling in large buffers with
1387 selective display, like Org Mode buffers. (Bug#9218)
1388
1389 * dispextern.h (struct bidi_it): New member disp_prop_p.
1390
1391 * xdisp.c: Remove one-slot cache of display string positions.
1392 (compute_display_string_pos): Accept an additional argument
5e617bc2 1393 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1394 for a display string or property. If found, set DISP_PROP_P
1395 non-zero.
1396
1397 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1398 DISP_PROP_P, and pass it to compute_display_string_pos.
1399 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1400 non-zero. All callers of bidi_fetch_char changed.
1401
fb33fa43
SM
14022011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1403
1404 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1405
b099e063
DM
14062010-12-03 Don March <don@ohspite.net>
1407
1408 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1409 last character M-[char] is translated to ESC [char] (bug#7541).
1410
5cc7f7af
KH
14112011-08-02 Kenichi Handa <handa@m17n.org>
1412
d0fffa3f 1413 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1414
1415 * chartab.c (uniprop_table): Make it non-static.
1416
525d5e6e
EZ
14172011-08-01 Eli Zaretskii <eliz@gnu.org>
1418
1419 * xdisp.c (forward_to_next_line_start): Accept additional argument
1420 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1421 on the newline.
1422 (reseat_at_next_visible_line_start): Use the bidi iterator state
1423 returned by forward_to_next_line_start to restore the state of
1424 it->bidi_it after backing up to previous newline. (Bug#9212)
1425
31011111
AS
14262011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1427
1428 * regex.c (re_comp): Protoize.
1429 (re_exec): Fix return type.
1430 (regexec): Fix type of `ret'. (Bug#9203)
1431
476371c4
PE
14322011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1433
e5d76069
PE
1434 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1435 This is needed if max-image-size is a floating-point number.
1436
9a79b20c
AS
14372011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1438
1439 * print.c (print_object): Print empty symbol as ##.
1440
1441 * lread.c (read1): Read ## as empty symbol.
1442
d8c2fa78
AA
14432011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1444
1445 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1446 setting frame foreground color (Bug#9175).
1447 (x_set_background_color): Likewise.
1448
ffe57a7a
AA
1449 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1450 contents (Bug#9176).
1451 (EmacsTooltip -init): Remove bezels and add shadows to
1452 tooltip windows.
1453
bf3492a5
AA
1454 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1455 or scroll bar (Bug#8470).
1456
d55e9c53
AA
1457 * nsfont.m (nsfont_open): Remove assignment to voffset and
1458 unnecessary vars hshink, expand, hd, full_height, min_height.
1459 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1460
1461 * nsterm.h (nsfont_info): Remove voffset field.
1462
d8c2fa78 14632011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1464
1465 Implement strike-through and overline on NextStep (Bug#8863).
1466
1467 * nsfont.m (nsfont_open): Use underline position provided by font,
1468 instead of hard-coded value of 2.
1469 (nsfont_draw): Call ns_draw_text_decoration instead.
1470
1471 * nsterm.h: Add declaration for ns_draw_text_decoration.
1472
1473 * nsterm.m (ns_draw_text_decoration): New function for drawing
1474 underline, overline, and strike-through.
1475 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1476 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 1477 accommodate underlining, etc.
4843aac3 1478
4cc60b9b
EZ
14792011-07-28 Eli Zaretskii <eliz@gnu.org>
1480
bc7ece87
EZ
1481 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1482 default.
4cc60b9b 1483
476371c4
PE
14842011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1485
66606eea
PE
1486 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1487 Without this fix, if a signal arrives just after memory fills up,
1488 'malloc' might be invoked reentrantly.
1489
476371c4
PE
1490 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1491 In other words, assume that every image size is allowed, on non-X
1492 hosts. This assumption is probably wrong, but it lets Emacs compile.
1493
f3fcc40d
AS
14942011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1495
1496 * regex.c (re_iswctype): Convert return values to boolean.
1497
350c992f
EZ
14982011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1499
1500 * xdisp.c (compute_display_string_pos): Don't use cached display
1501 string position if the buffer had its restriction changed.
1502 (Bug#9184)
1503
5266b4bb
PE
15042011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1505
1506 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1507
2573a837 15082011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1509
41f55ccd 1510 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1511
39e378da
PE
1512 * bidi.c: Integer size and overflow fixes.
1513 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1514 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1515 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1516 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1517 (bidi_find_other_level_edge):
1518 Use ptrdiff_t instead of EMACS_INT where either will do.
1519 This works better on 32-bit hosts configured --with-wide-int.
1520 (bidi_cache_ensure_space): Check for size-calculation overflow.
1521 Use % rather than repeated addition, for better worst-case speed.
1522 Don't set bidi_cache_size until after xrealloc returns, because it
1523 might not return.
1524 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1525 (bidi_cache_ensure_space): Also check that the bidi cache size
1526 does not exceed that of the largest Lisp string or buffer. See Eli
1527 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1528
5e927815
PE
1529 * alloc.c (__malloc_size_t): Remove.
1530 All uses replaced by size_t. See Andreas Schwab's note
1531 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1532
ca4aa935
PE
1533 * image.c: Improve checking for integer overflow.
1534 (check_image_size): Assume that f is nonnull, since
1535 it is always nonnull in practice. This is one less thing to
1536 worry about when checking for integer overflow later.
1537 (x_check_image_size): New function, which checks for integer
1538 overflow issues inside X.
1539 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1540 This removes the need for a memory_full check.
1541 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1542 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1543 (xbm_read_bitmap_data): Change locals back to 'int', since
1544 their values must fit in 'int'.
1545 (xpm_load_image, png_load, tiff_load):
1546 Invoke x_create_x_image_and_pixmap earlier,
1547 to avoid much needless work if the image is too large.
1548 (tiff_load): Treat overly large images as if
1549 x_create_x_image_and_pixmap failed, not as malloc failures.
1550 (gs_load): Use x_check_image_size.
1551
5f8f9cc2
PE
1552 * gtkutil.c: Omit integer casts.
1553 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1554 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1555
5adf60bc
PE
1556 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1557
c8907a93
PE
1558 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1559 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1560 would wrongly return t on a 64-bit host.
1561
e3c25c68
PE
1562 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1563 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1564 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1565 and therefore cause GCC to emit a bogus diagnostic in some cases.
1566
3f791afe
PE
1567 * image.c: Integer signedness and overflow and related fixes.
1568 This is not an exhaustive set of fixes, but it's time to
1569 record what I've got.
1570 (lookup_pixel_color, check_image_size): Remove redundant decls.
1571 (check_image_size): Don't assume that arbitrary EMACS_INT values
1572 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1573 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1574 (tiff_load, imagemagick_load_image):
1575 Check for overflow in size calculations.
1576 (x_create_x_image_and_pixmap): Remove unnecessary test for
1577 xmalloc returning NULL; that can't happen.
1578 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1579 (xpm_color_bucket): Use better integer hashing function.
1580 (xpm_cache_color): Don't possibly over-allocate memory.
1581 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1582 (gif_memory_source):
1583 Use ptrdiff_t, not int or size_t, to record sizes.
1584 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1585 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1586 either works, as we prefer signed integers.
1587 (tiff_read_from_memory, tiff_write_from_memory):
1588 Return tsize_t, not size_t, since that's what the TIFF API wants.
1589 (tiff_read_from_memory): Don't fail simply because the read would
1590 go past EOF; instead, return a short read.
1591 (tiff_load): Omit no-longer-needed casts.
1592 (Fimagemagick_types): Don't assume size fits into 'int'.
1593
3cc5a532
PE
1594 Improve hashing quality when configured --with-wide-int.
1595 * fns.c (hash_string): New function, taken from sxhash_string.
1596 Do not discard information about ASCII character case; this
1597 discarding is no longer needed.
1598 (sxhash-string): Use it. Change sig to match it. Caller changed.
1599 * lisp.h: Declare it.
1600 * lread.c (hash_string): Remove, since we now use fns.c's version.
1601 The fns.c version returns a wider integer if --with-wide-int is
1602 specified, so this should help the quality of the hashing a bit.
1603
b312a492
PE
1604 * emacs.c: Integer overflow minor fix.
1605 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1606 Define only if GNU_LINUX.
1607 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1608
dfd153ae
PE
1609 * dispnew.c: Integer signedness and overflow fixes.
1610 Remove unnecessary forward decls, that were a maintenance hassle.
1611 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1612 All uses changed.
1613 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1614 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1615 (prepare_desired_row, line_draw_cost):
1616 Use int, not unsigned, where either works.
1617 (save_current_matrix, restore_current_matrix):
1618 Use ptrdiff_t, not size_t, where either works.
1619 (init_display): Check for overflow more accurately, and without
1620 relying on undefined behavior.
1621
a81d11a3
PE
1622 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1623 Remove, replacing with the new symbols in lisp.h. All uses changed.
1624 * fileio.c (make_temp_name):
1625 * filelock.c (lock_file_1, lock_file):
1626 * xdisp.c (message_dolog):
1627 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1628 Use pMd etc. instead.
1629 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1630 replacing the pWIDE etc. symbols removed from editfns.c.
1631
3300e6fd
PE
1632 * keyboard.h (num_input_events): Now uintmax_t.
1633 This is (very slightly) less likely to mess up due to wraparound.
1634 All uses changed.
1635
fd05c7e9
PE
1636 * buffer.c: Integer signedness fixes.
1637 (alloc_buffer_text, enlarge_buffer_text):
1638 Use ptrdiff_t rather than size_t when either will do, as we prefer
1639 signed integers.
1640
903fe15d
PE
1641 * alloc.c: Integer signedness and overflow fixes.
1642 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1643 (__malloc_size_t): Default to size_t, not to int.
1644 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1645 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1646 Prefer ptrdiff_t to size_t when either would do, as we prefer
1647 signed integers.
1648 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1649 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1650 Now const. Initialize with values that are in range even if char
1651 is signed.
1652 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1653 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1654 These functions do the right thing with sizes > 2**32.
1655 (check_depth): Now ptrdiff_t, not int.
1656 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1657 Adjust to new way of storing sizes. Check for size overflow bugs
1658 in rest of code.
1659 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1660 slightly wrong anyway, as it missed one instance of
1661 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1662 (refill_memory_reserve): Omit needless cast to size_t.
1663 (mark_object_loop_halt): Mark as externally visible.
1664
ac82cc6a
PE
1665 * xselect.c: Integer signedness and overflow fixes.
1666 (Fx_register_dnd_atom, x_handle_dnd_message):
1667 Use ptrdiff_t, not size_t, since we prefer signed.
1668 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1669 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1670 x_dnd_atoms_size and x_dnd_atoms_length.
1671
c2d1e36d
PE
1672 * doprnt.c: Prefer signed to unsigned when either works.
1673 * eval.c (verror):
1674 * doprnt.c (doprnt):
1675 * lisp.h (doprnt):
1676 * xdisp.c (vmessage):
1677 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1678 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1679 prefer signed arithmetic to avoid comparison confusion.
1680 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1681 but is a bit tricky.
1682
0e926e56
PE
1683 Assume freestanding C89 headers, string.h, stdlib.h.
1684 * data.c, doprnt.c, floatfns.c, print.c:
1685 Include float.h unconditionally.
1686 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1687 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1688 * regex.c: Likewise for stddef.h, string.h.
1689 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1690 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1691 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1692 (STDC_HEADERS): Remove obsolete defines.
1693 * sysdep.c: Include limits.h unconditionally.
1694
9cfdb3ec
PE
1695 Assume support for memcmp, memcpy, memmove, memset.
1696 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1697 * regex.c (memcmp, memcpy):
1698 Remove; we assume C89 now.
1699
1700 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1701 (__malloc_safe_bcopy): Remove; no longer needed.
1702
cf950e6b 1703 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1704 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1705 well either way, and we prefer signed to unsigned.
1706
dbf38e02
LMI
17072011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1708
1709 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1710 closes the connection while we're reading (bug#9182).
1711
d6f0886c 17122011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 1713
d6f0886c
JD
1714 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1715 are specified (Bug#9168).
24e0f6b1 1716
2eb1f9e6
PE
17172011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1718
1719 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1720 Found by GCC static checking and --with-wide-int on a 32-bit host.
1721
22381272 17222011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1723
1724 * xdisp.c (compute_display_string_pos): Fix logic of caching
1725 previous display string position. Initialize cached_prev_pos to
1726 -1. Fixes slow-down at the beginning of a buffer.
1727
f25e39b4
EZ
17282011-07-24 Eli Zaretskii <eliz@gnu.org>
1729
1730 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1731 for attrs[LFACE_FONTSET_INDEX].
1732
04c4b52e
PE
17332011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1734
1735 * xml.c (parse_region): Remove unused local
1736 that was recently introduced.
1737
c1734fbd
EZ
17382011-07-23 Eli Zaretskii <eliz@gnu.org>
1739
be18c5a5
EZ
1740 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1741 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1742
c1734fbd
EZ
1743 * xdisp.c (move_it_in_display_line_to): Record the best matching
1744 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1745 exit if none of the characters scanned was an exact match.
1746 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1747 when exact match is impossible due to invisible text, and the
1748 lines are truncated.
1749
a258d627
JD
17502011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1751
1752 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1753 for OSX >= 10.7.
1754
b6d5a689
EZ
17552011-07-22 Eli Zaretskii <eliz@gnu.org>
1756
0f74f785
EZ
1757 Fix a significant slow-down of cursor motion with C-n, C-p,
1758 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1759 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1760 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1761 (next_element_from_buffer): Call compute_stop_pos_backwards to
1762 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1763 base_level_stop.
1764 (reseat): Don't look for prev_stop, as that could mean a very long
1765 run.
1766 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1767 <cached_disp_overlay_modiff>: Cache for last found display string
1768 position.
551918c1 1769 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1770 about the same buffer in the same area of character positions, and
1771 the buffer wasn't changed since the time the display string
1772 position was cached.
551918c1 1773
b2d0c91a
EZ
17742011-07-22 Eli Zaretskii <eliz@gnu.org>
1775
1776 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1777 is an integer, which is important for empty lines. (Bug#9149)
1778
043604ee
CY
17792011-07-22 Chong Yidong <cyd@stupidchicken.com>
1780
1781 * frame.c (Fmodify_frame_parameters): In tty case, update the
1782 default face if necessary (Bug#4238).
1783
da4adb04
CY
17842011-07-21 Chong Yidong <cyd@stupidchicken.com>
1785
1786 * editfns.c (Fstring_to_char): No need to explain what a character
1787 is in the docstring (Bug#6576).
1788
9abd0532
LMI
17892011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1790
1791 * xml.c (parse_region): Make sure we always return a tree.
1792
36881d16
HK
17932011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1794
1795 * xml.c (parse_region): If a document contains only comments,
1796 return that, too.
1797
1e98674d
LMI
17982011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1799
1800 * xml.c (make_dom): Return comments, too.
1801
590bd467
PE
18022011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1803
1804 Port to OpenBSD.
1805 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1806 and the surrounding thread.
1807 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1808 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1809 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1810 timer goes off.
1811 * s/openbsd.h (BROKEN_SIGIO): Define.
1812 * unexelf.c (unexec) [__OpenBSD__]:
1813 Don't update the .mdebug section of the Alpha COFF symbol table.
1814
f41628b2
LMI
18152011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1816
1817 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1818 (bug#8460).
1819
b59b67c5
PE
18202011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1821
15e3a074
PE
1822 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1823 This fixes some race conditions on the permissions of any newly
1824 created file.
1825
41bed37d
PE
1826 * alloc.c (valid_pointer_p): Use pipe, not open.
1827 This fixes some permissions issues when debugging.
1828
b59b67c5
PE
1829 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1830 If fchown fails to set both uid and gid, try to set just gid,
1831 as that is sometimes allowed. Adjust the file's mode to eliminate
1832 setuid or setgid bits that are inappropriate if fchown fails.
1833
925a6be7
SM
18342011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1835
1836 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1837 to compare Lisp_Objects.
1838 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1839 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1840 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1841
52968808
AS
18422011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1843
0a6a104b
AS
1844 * lread.c (read_integer): Unread even EOF character.
1845 (read1): Likewise. Properly record start position of symbol.
1846
52968808
AS
1847 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1848 symbol character follows.
1849
9e381cdd
PE
18502011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1851
1852 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1853 This works around a problem with the previous change to Fcopy_file.
1854 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1855 and without this change, GCC might complain about discarding
1856 fchown's return value.
1857
b5641435
JB
18582011-07-16 Juanma Barranquero <lekktu@gmail.com>
1859
1860 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1861
a8031457
PE
18622011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1863
1864 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1865
dd889327
LMI
18662011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1867
750c33f7
LMI
1868 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1869 it's used from the C level.
1870
dd889327
LMI
1871 * process.c: Use the same condition for POLL_FOR_INPUT in both
1872 keyboard.c and process.c (bug#1858).
1873
87e86684
LM
18742011-07-09 Lawrence Mitchell <wence@gmx.li>
1875
1876 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1877 (Fgnutls_boot): Use it.
1878
64348f40
AS
18792011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1880
1881 * doc.c (Fsubstitute_command_keys): Revert last change.
1882
1d698799
LMI
18832011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1884
f863868c
LMI
1885 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1886 quotes the next character, and doesn't affect other longer
1887 sequences (bug#8935).
1888
1d698799
LMI
1889 * lread.c (syms_of_lread): Clarify that is isn't only
1890 `eval-buffer' and `eval-defun' that's affected by
1891 `lexical-binding' (bug#8460).
1892
aa4b6df6
EZ
18932011-07-15 Eli Zaretskii <eliz@gnu.org>
1894
1895 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1896 bidi redisplay when a line includes both an image and is
1897 truncated.
1898
5d856da6
PE
18992011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1900
ad6042bb
PE
1901 Fix minor problems found by static checking.
1902 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1903 (elsz): Now a signed constant, not a size_t var. We prefer signed
1904 types to unsigned, to avoid integer comparison confusion. Without
1905 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1906 "cannot optimize loop, the loop counter may overflow", a symptom
1907 of the confusion.
f00bbb22 1908 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1909 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1910
6468f31c
LMI
19112011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1912
49080b10
LMI
1913 * search.c (Fre_search_backward): Mention `case-fold-search' in
1914 all the re_search_* functions (bug#8138).
1915
6468f31c
LMI
1916 * keyboard.c (Fopen_dribble_file): Document when the file is
1917 closed (bug#8056).
1918
c965adc5
EZ
19192011-07-14 Eli Zaretskii <eliz@gnu.org>
1920
df9733bf
EZ
1921 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1922 bidi_cache_idx.
1923
0bb23927
EZ
1924 Support bidi reordering of display and overlay strings.
1925 * xdisp.c (compute_display_string_pos)
1926 (compute_display_string_end): Accept additional argument STRING.
1927 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1928 (reseat_to_string): Initialize bidi_it->string.s and
1929 bidi_it->string.schars.
1930 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1931 NULL (avoids a crash in bidi_paragraph_init).
1932 Initialize itb.string.lstring.
0bb23927
EZ
1933 (init_iterator): Call bidi_init_it only of a valid
1934 buffer position was specified. Initialize paragraph_embedding to
1935 L2R.
1936 (reseat_to_string): Initialize the bidi iterator.
1937 (display_string): If we need to ignore text properties of
1938 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1939 original value of -1 will not work with bidi.)
1940 (compute_display_string_pos): First arg is now struct
1941 `text_pos *'; all callers changed. Support display properties on
1942 Lisp strings.
1943 (compute_display_string_end): Support display properties on Lisp
1944 strings.
1945 (init_iterator, reseat_1, reseat_to_string): Initialize the
1946 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1947 when iterating on a string not from display properties).
640c8776
SM
1948 (compute_display_string_pos, compute_display_string_end):
1949 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1950 arrow keys.
1951 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1952 base_level_stop; instead, set base_level_stop to BEGV.
1953 Fixes crashes in vertical-motion.
0bb23927
EZ
1954 (next_element_from_buffer): Improve commentary for when
1955 the iterator is before prev_stop.
1956 (init_iterator): Initialize bidi_p from the default value of
1957 bidi-display-reordering, not from buffer-local value. Use the
1958 buffer-local value only if initializing for buffer iteration.
1959 (handle_invisible_prop): Support invisible properties on strings
1960 that are being bidi-reordered.
1961 (set_iterator_to_next): Support bidi reordering of C strings and
1962 Lisp strings.
1963 (next_element_from_string): Support bidi reordering of Lisp
1964 strings.
1965 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
1966 (display_string): Support display of R2L glyph rows.
1967 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
1968 (init_iterator): Don't initialize it->bidi_p for strings
1969 here.
1970 (reseat_to_string): Initialize it->bidi_p for strings here.
1971 (next_element_from_string, next_element_from_c_string)
1972 (next_element_from_buffer): Add xassert's for correspondence
1973 between IT's object being iterated and it->bidi_it.string
1974 structure.
1975 (face_before_or_after_it_pos): Support bidi iteration.
1976 (next_element_from_c_string): Handle the case of the first string
1977 character that is not the first one in the visual order.
1978 (get_visually_first_element): New function, refactored from common
1979 parts of next_element_from_buffer, next_element_from_string, and
1980 next_element_from_c_string.
1981 (tool_bar_lines_needed, redisplay_tool_bar)
1982 (display_menu_bar): Force left-to-right direction. Add a FIXME
1983 comment for making that be controlled by a user option.
1984 (push_it, pop_it): Save and restore the state of the
1985 bidi iterator. Save and restore the bidi_p flag.
1986 (pop_it): Iterate out of display property for string iteration as
1987 well.
1988 (iterate_out_of_display_property): Support iteration over strings.
1989 (handle_single_display_spec): Set up it->bidi_it for iteration
1990 over a display string, and call bidi_init_it.
1991 (handle_single_display_spec, next_overlay_string)
1992 (get_overlay_strings_1, push_display_prop): Set up the bidi
1993 iterator for displaying display or overlay strings.
1994 (forward_to_next_line_start): Don't use the shortcut if
1995 bidi-iterating.
1996 (back_to_previous_visible_line_start): If handle_display_prop
1997 pushed the iterator stack, restore the internal state of the bidi
1998 iterator by calling bidi_pop_it same number of times.
1999 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2000 and we are bidi-iterating, don't decrement the iterator position;
2001 instead, set the first_elt flag in the bidi iterator, to produce
2002 the same effect.
2003 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2004 (push_display_prop): xassert that we are iterating a buffer.
2005 (push_it, pop_it): Save and restore paragraph_embedding member.
2006 (handle_single_display_spec, next_overlay_string)
2007 (get_overlay_strings_1, reseat_1, reseat_to_string)
2008 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2009 correctly. Don't assume unibyte strings are not bidi-reordered.
2010 (compute_display_string_pos)
2011 (compute_display_string_end): Fix handling the case of C string.
2012 (push_it, pop_it): Save and restore from_disp_prop_p.
2013 (handle_single_display_spec, push_display_prop): Set the
2014 from_disp_prop_p flag.
2015 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2016 (pop_it): Call iterate_out_of_display_property only if we are
2017 popping after iteration over a string that came from a display
2018 property. Fix a typo in popping stretch info. Add an assertion
2019 for verifying that the iterator position is in sync with the bidi
2020 iterator.
2021 (handle_single_display_spec, get_overlay_strings_1)
2022 (push_display_prop): Fix initialization of paragraph direction for
2023 string when that of the parent object is not yet determined.
2024 (reseat_1): Call bidi_init_it to resync the bidi
2025 iterator with IT's position. (Bug#7616)
2026 (find_row_edges): If ROW->start.pos gives position
2027 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2028 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2029 Reset the from_disp_prop_p flag.
2030 (SAVE_IT, RESTORE_IT): New macros.
2031 (pos_visible_p, face_before_or_after_it_pos)
2032 (back_to_previous_visible_line_start)
2033 (move_it_in_display_line_to, move_it_in_display_line)
2034 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2035 (try_scrolling, redisplay_window, display_line): Use them when
2036 saving a temporary copy of the iterator and restoring it back.
2037 (back_to_previous_visible_line_start, reseat_1)
2038 (init_iterator): Empty the bidi cache "stack".
2039 (move_it_in_display_line_to): If iterator ended up at
2040 EOL, but we never saw any buffer positions smaller than
2041 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2042 motion in bidi-reordered lines.
2043 (move_it_in_display_line_to): Record prev_method and prev_pos
2044 immediately before the call to set_iterator_to_next. Fixes cursor
2045 motion in bidi-reordered lines with stretch glyphs and strings
2046 displayed in margins. (Bug#8133) (Bug#8867)
2047 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2048 TO_CHARPOS.
640c8776
SM
2049 (pos_visible_p): Support positions in bidi-reordered lines.
2050 Save and restore bidi cache.
0bb23927
EZ
2051
2052 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2053 (bidi_paragraph_info): Delete unused struct.
2054 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2055 (bidi_cache_start): New variable.
2056 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2057 to zero.
2058 (bidi_cache_fetch_state, bidi_cache_search)
2059 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2060 (bidi_cache_find, bidi_peek_at_next_level)
2061 (bidi_level_of_next_char, bidi_find_other_level_edge)
2062 (bidi_move_to_visually_next): Compare cache index with
2063 bidi_cache_start rather than with zero.
2064 (bidi_fetch_char): Accept new argument STRING; all callers
2065 changed. Support iteration over a string. Support strings with
2066 display properties. Support unibyte strings. Fix the type of
2067 `len' according to what STRING_CHAR_AND_LENGTH expects.
2068 (bidi_paragraph_init, bidi_resolve_explicit_1)
2069 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2070 (bidi_level_of_next_char, bidi_move_to_visually_next):
2071 Support iteration over a string.
0bb23927
EZ
2072 (bidi_set_sor_type, bidi_resolve_explicit_1)
2073 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2074 can now be zero (for strings); special values 0 and -1 were
2075 changed to -1 and -2, respectively.
2076 (bidi_char_at_pos): New function.
2077 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2078 Call it instead of FETCH_MULTIBYTE_CHAR.
2079 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2080 initialized to valid values.
2081 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2082 values.
2083 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2084 the test for valid cached positions. Fix the logic for looking up
2085 the sentinel state in the cache. GCPRO the Lisp string we are
2086 iterating.
2087 (bidi_push_it, bidi_pop_it): New functions.
2088 (bidi_initialize): Initialize the bidi cache start stack pointer.
2089 (bidi_cache_ensure_space): New function, refactored from part of
2090 bidi_cache_iterator_state. Don't assume the required size is just
2091 one BIDI_CACHE_CHUNK away.
2092 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2093 (bidi_count_bytes, bidi_char_at_pos): New functions.
2094 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2095 always valid if bidi_cache_idx is valid.
2096 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2097 is valid if it's going to be used.
2098 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2099 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2100 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2101 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2102 (bidi_find_other_level_edge, bidi_cache_start_stack):
2103 All variables related to cache indices are now EMACS_INT.
c965adc5 2104
0bb23927
EZ
2105 * dispextern.h (struct bidi_string_data): New structure.
2106 (struct bidi_it): New member `string'. Make flag members be 1-bit
2107 fields, and put them last in the struct.
640c8776
SM
2108 (compute_display_string_pos, compute_display_string_end):
2109 Update prototypes.
0bb23927
EZ
2110 (bidi_push_it, bidi_pop_it): Add prototypes.
2111 (struct iterator_stack_entry): New members bidi_p,
2112 paragraph_embedding, and from_disp_prop_p.
2113 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2114 (bidi_shelve_cache, bidi_unshelve_cache):
2115 Declare prototypes.
0bb23927
EZ
2116
2117 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2118 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2119 and vector-like objects.
2120
2121 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2122 cache around display iteration.
2123
2124 * window.c (Fwindow_end, window_scroll_pixel_based)
2125 (displayed_window_lines, Frecenter): Save and restore the bidi
2126 cache around display iteration.
2127
3bbd2265
LMI
21282011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2129
2130 * editfns.c (Fdelete_region): Clarify the use of the named
2131 parameters (bug#6788).
2132
adc47434
MR
21332011-07-14 Martin Rudalics <rudalics@gmx.at>
2134
2135 * indent.c (Fvertical_motion): Set and restore w->pointm when
2136 saving and restoring the window's buffer (Bug#9006).
2137
837c31f8
LMI
21382011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2139
2140 * editfns.c (Fstring_to_char): Clarify just what is returned
2141 (bug#6576). Text by Eli Zaretskii.
2142
ac389d0c
JB
21432011-07-13 Juanma Barranquero <lekktu@gmail.com>
2144
2145 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2146
0be0ce47
EZ
21472011-07-13 Eli Zaretskii <eliz@gnu.org>
2148
2149 * buffer.c (mmap_find): Fix a typo.
2150
cd18e7e3
JB
21512011-07-13 Johan Bockgård <bojohan@gnu.org>
2152
2153 Fix execution of x selection hooks.
2154 * xselect.c (Qx_lost_selection_functions)
2155 (Qx_sent_selection_functions): New vars.
2156 (syms_of_xselect): DEFSYM them.
2157 (x_handle_selection_request): Pass Qx_sent_selection_functions
2158 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2159 (x_handle_selection_clear,x_clear_frame_selections):
2160 Pass Qx_lost_selection_functions rather than
2161 Vx_lost_selection_functions to Frun_hook_with_args.
2162
47ea7f44
PE
21632011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2164
ac389d0c 2165 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2166 The old code sometimes used this field without initializing it.
2167
47ea7f44
PE
2168 * alloc.c (gc_sweep): Don't read past end of array.
2169 In theory, the old code could also have corrupted Emacs internals,
2170 though it'd be very unlikely.
2171
bc985c87
AS
21722011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2173
2174 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2175 argument. (Bug#4026)
bc985c87 2176
0cf34688
LMI
21772011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2178
b3dadd76
LMI
2179 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2180 key" (bug#4257).
2181
0cf34688
LMI
2182 * window.c (Fset_window_start): Doc fix (bug#4199).
2183 (Fset_window_hscroll): Ditto.
2184
270768cd
PE
21852011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2186
077e3dda 2187 Fix minor new problems caught by GCC 4.6.1.
270768cd 2188 * term.c (init_tty): Remove unused local.
490011a6 2189 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2190 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2191 not used otherwise.
270768cd 2192
b1f58454
CY
21932011-07-12 Chong Yidong <cyd@stupidchicken.com>
2194
2195 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2196
22b9578d
LMI
21972011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2198
6e70ab07
LMI
2199 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2200 are the mini-buffer and the echo area (bug#3320).
2201
22b9578d
LMI
2202 * term.c (init_tty): Remove support for supdup, c10 and perq
2203 terminals, which are no longer supported (bug#1482).
2204
8974cc9f
JB
22052011-07-10 Johan Bockgård <bojohan@gnu.org>
2206
2207 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2208
a560d974
JD
22092011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2210
2211 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2212 for non-popups (Bug#3642).
2213
1dae0f0a
AS
22142011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2215
268c2c36 2216 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2217 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2218 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2219 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2220 * data.c (fmod): Likewise.
2221 * dispnew.c (swap_glyphs_in_rows): Likewise.
2222 * emacs.c (memory_warning_signal): Likewise.
2223 * floatfns.c (float_error): Likewise.
2224 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2225 (otf_open, font_otf_capability, generate_otf_features)
2226 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2227 Likewise.
2228 * image.c (pbm_read_file): Likewise.
2229 * indent.c (string_display_width): Likewise.
2230 * intervals.c (check_for_interval, search_for_interval)
2231 (inc_interval_count, count_intervals, root_interval)
2232 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2233 * lread.c (defalias): Likewise.
268c2c36 2234 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2235 * regex.c (set_image_of_range_1, set_image_of_range)
2236 (regex_grow_registers): Likewise.
2237 * sysdep.c (strerror): Likewise.
2238 * termcap.c (valid_filename_p, tprint, main): Likewise.
2239 * tparam.c (main): Likewise.
2240 * unexhp9k800.c (run_time_remap, save_data_space)
2241 (update_file_ptrs, read_header, write_header, calculate_checksum)
2242 (copy_file, copy_rest, display_header): Likewise.
2243 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2244 Likewise.
2245 * xdisp.c (check_it): Likewise.
2246 * xfaces.c (register_color, unregister_color, unregister_colors):
2247 Likewise.
2248 * xfns.c (print_fontset_result): Likewise.
2249 * xrdb.c (member, fatal, main): Likewise.
2250
99033785
PE
22512011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2252
2253 Fix minor problems found by static checking (Bug#9031).
2254 * chartab.c (char_table_set_range, map_sub_char_table):
2255 Remove unused locals.
2256 (uniprop_table): Now static.
2257 * composite.c (_work_char): Remove unused static var.
2258
9cb2ac56
JB
22592011-07-09 Juanma Barranquero <lekktu@gmail.com>
2260
2261 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2262
f25661f0
JD
22632011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2264
2265 * gtkutil.c (qttip_cb): Remove code without function.
2266
8278c4fe
EZ
22672011-07-09 Eli Zaretskii <eliz@gnu.org>
2268
2269 * w32.c (pthread_sigmask): New stub.
2270
1692ae2d 22712011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2272
8a6ebd58 2273 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2274 sigprocmask is portable only for single-threaded applications, and
2275 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2276 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2277 (LIBES): Use it.
2278 * callproc.c (Fcall_process):
2279 * process.c (create_process):
2280 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2281 Use pthread_sigmask, not sigprocmask.
123403e4 2282
1b854618
JD
22832011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2284
2285 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2286 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2287 wrong (Bug#8591).
2288
3fe4b549
JD
22892011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2290
0ce7e563
JD
2291 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2292 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2293 (xg_hide_tooltip): Fix comment.
2294
3fe4b549
JD
2295 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2296 in registerServicesMenuSendTypes.
2297 (validRequestorForSendType): Don't check ns_return_types.
2298
2299 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2300 ns_return_type.
2301
5df75e47
JR
23022011-07-08 Jason Rumney <jasonr@gnu.org>
2303
2304 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2305 frame struct members of non-existent frames (Bug#6284).
2306
699c10bd
JD
23072011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2308
4393663b
JD
2309 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2310 variable firstTime not needed on OSX >= 10.6.
2311 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2312 >= 10.5. Use setKnobProportion, setDoubleValue.
2313
2314 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2315 (MAC_OS_X_VERSION_10_5): Define if not defined.
2316 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2317 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2318 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2319
2320 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2321 cString and lossyCString on OSX >= 10.4
2322
2323 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2324 sizeToFit on OSX >= 10.2.
2325
2326 * nsimage.m (allocInitFromFile): Don't use deprecated method
2327 bestRepresentationForDevice on OSX >= 10.6.
2328
2329 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2330 to avoid warning.
2331
2332 * emacs.c: Declare unexec_init_emacs_zone.
2333
a63e0781
JD
2334 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2335
699c10bd
JD
2336 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2337
2338 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2339 on svcsMenu (Bug#8842).
2340
2341 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2342 ns_return_types.
2343 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2344
2345 * nsterm.m (QUTF8_STRING): Declare.
2346 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2347 (validRequestorForSendType): Return type is (id).
2348 Change indexOfObjectIdenticalTo to indexOfObject.
2349 Check if we have local selection before returning self (Bug#8842).
2350 (writeSelectionToPasteboard): Put local selection into paste board
2351 if we have a local selection (Bug#8842).
2352 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2353
2354 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2355 (ns_get_local_selection): Declare.
2356
54e10184
LMI
23572011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2358
9888ff71
LMI
2359 * keymap.c (describe_map_tree): Don't insert a double newline at
2360 the end of the buffer (bug#1169) and return whether we inserted
2361 something.
2362
54e10184
LMI
2363 * callint.c (Fcall_interactively): Change "reading args" to
2364 "providing args" to try to clarify what it does (bug#1010).
2365
15fa4783
KH
23662011-07-07 Kenichi Handa <handa@m17n.org>
2367
2368 * composite.c (composition_compute_stop_pos): Ignore a static
2369 composition starting before CHARPOS (Bug#8915).
2370
2371 * xdisp.c (handle_composition_prop): Likewise.
2372
a8815b00
EZ
23732011-07-07 Eli Zaretskii <eliz@gnu.org>
2374
2375 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2376 (Bug#9015)
2377
ef7b981d 23782011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2379
2380 * character.h (unicode_category_t): New enum type.
2381
2382 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2383 (Qchar_code_property_table): New variable.
2384 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2385 (UNIPROP_COMPRESSED_FORM_P): New macros.
2386 (char_table_ascii): Uncompress the compressed values.
2387 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2388 Uncompress the compressed values.
ac389d0c 2389 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2390 (char_table_ref_and_range): Uncompress the compressed values.
2391 (sub_char_table_set): New arg is_uniprop. Callers changed.
2392 Uncompress the compressed values.
2393 (sub_char_table_set_range): Args changed. Callers changed.
2394 (char_table_set_range): Adjuted for the above change.
2395 (map_sub_char_table): Delete args default_val and parent. Add arg
2396 top. Give decoded values to a Lisp function.
640c8776 2397 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2398 values to a Lisp function. Gcpro more variables.
2399 (uniprop_table_uncompress)
2400 (uniprop_decode_value_run_length): New functions.
2401 (uniprop_decoder, uniprop_decoder_count): New variables.
2402 (uniprop_get_decoder, uniprop_encode_value_character)
2403 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2404 New functions.
2405 (uniprop_encoder, uniprop_encoder_count): New variables.
2406 (uniprop_get_encoder, uniprop_table)
2407 (Funicode_property_table_internal, Fget_unicode_property_internal)
2408 (Fput_unicode_property_internal): New functions.
2409 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2410 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2411 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2412 char-code-property-alist.
2413
640c8776 2414 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2415 Vunicode_category_table.
2416
640c8776 2417 * font.c (font_range): Adjust for the change of
c805dec0
KH
2418 Vunicode_category_table.
2419
76b397fb
DN
24202011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2421
2422 * m/iris4d.h: Remove file, move contents ...
2423 * s/irix6-5.h: ... here.
2424
22b4128e
PE
24252011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2426
2427 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2428 * alloc.c (mark_buffer):
2429 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2430 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2431 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2432 This isn't true in general, and it's particularly not true
2433 if Emacs is configured with --with-wide-int.
2434 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2435 New macros, used in the buffer.c change.
2436
869795d6
JD
24372011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2438
2439 * xsettings.c: Use both GConf and GSettings if both are available.
2440 (store_config_changed_event): Add comment.
2441 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2442 (store_tool_bar_style_changed): New functions.
5e617bc2 2443 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2444 (struct xsettings): Move font inside HAVE_XFT.
2445 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2446 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2447 Move inside HAVE_XFT.
640c8776 2448 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2449 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2450 also.
2451 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2452 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2453 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2454 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2455 (parse_settings): Move check for font inside HAVE_XFT.
2456 (read_settings, apply_xft_settings): Add comment.
2457 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2458 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2459 call store_font_name_changed.
2460 (xft_settings_event): Add comment.
2461 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2462 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2463 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2464 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2465 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2466 (xsettings_get_system_font, xsettings_get_system_normal_font):
2467 Add comment.
869795d6 2468
d8ed26bd
PE
24692011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2470
2471 Random fixes. E.g., (random) never returned negative values.
2472 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2473 subseconds part to the entropy, as that's a bit more random.
2474 Prefer signed to unsigned, since the signedness doesn't matter and
2475 in general we prefer signed. When given a limit, use a
2476 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2477 latter isn't right if USE_2_TAGS_FOR_INTS.
2478 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2479 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2480
cabf1cac
SM
24812011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2482
2483 * textprop.c (text_property_stickiness):
2484 Obey Vtext_property_default_nonsticky.
2485 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2486 * w32fns.c (syms_of_w32fns):
2487 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2488
6e9b2be9
PE
24892011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2490
2491 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2492 This is more efficient than Ffile_directory_p and avoids a minor race.
2493
90186c68
LMI
24942011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2495
7c301272
LMI
2496 * buffer.c (Foverlay_put): Say what the return value is
2497 (bug#7835).
2498
c4f2d8d4
LMI
2499 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2500 is a directory before asking whether to use the file name
2501 (bug#7564).
ad637907
LMI
2502 (barf_or_query_if_file_exists): Make the "File is a directory"
2503 error be more correct.
c4f2d8d4 2504
90186c68
LMI
2505 * fns.c (Frequire): Remove the mention of the .gz files, since
2506 that's installation-specific, but keep the mention of
2507 `get-load-suffixes'.
2508
da64016e
PE
25092011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2510
2511 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2512 Report string overflow if the output is too long.
2513
7d47b580
JB
25142011-07-04 Juanma Barranquero <lekktu@gmail.com>
2515
a555cb87
JB
2516 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2517 (syms_of_gnutls): Remove duplicate DEFSYM for
2518 Qgnutls_bootprop_verify_hostname_error, an error for
2519 Qgnutls_bootprop_verify_error (which is no longer used).
2520
7d47b580
JB
2521 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2522 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2523 Also (re)move comments that are misplaced or no longer relevant.
2524
1e49bfab
LMI
25252011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2526
2527 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2528
1485f4c0
CY
25292011-07-03 Chong Yidong <cyd@stupidchicken.com>
2530
2531 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2532 and background color parameters if they have been changed.
2533
a9ab721e
LMI
25342011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2535
2536 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2537
cf7cff57
PE
25382011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2539
2e13213d
PE
2540 * xsettings.c (SYSTEM_FONT): Define only when used.
2541 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2542
cf7cff57
PE
2543 * keymap.c (access_keymap_1): Now static.
2544
7a8e04f7
CY
25452011-07-02 Chong Yidong <cyd@stupidchicken.com>
2546
2547 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2548 leave any prefix arg for the up event (Bug#1586).
2549
61352f62
LMI
25502011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2551
69bb1ef7
LMI
2552 * lread.c (syms_of_lread): Mention single symbols defined by
2553 `defvar' or `defconst' (bug#7154).
2554
61352f62 2555 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2556 (Frequire): Mention get-load-suffixes.
61352f62 2557
28545e04
MR
25582011-07-02 Martin Rudalics <rudalics@gmx.at>
2559
2560 * window.h (window): Remove clone_number slot.
2561 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2562 Remove.
2563 (make_parent_window, make_window, saved_window)
2564 (Fset_window_configuration, save_window_save): Don't deal with
2565 clone numbers.
2566 * buffer.c (Qclone_number): Remove declaration.
2567 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2568
3349e122
SM
25692011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2570
2571 Add multiple inheritance to keymaps.
2572 * keymap.c (Fmake_composed_keymap): New function.
2573 (Fset_keymap_parent): Simplify.
2574 (fix_submap_inheritance): Remove.
2575 (access_keymap_1): New function extracted from access_keymap to handle
2576 embedded parents and handle lists of maps.
2577 (access_keymap): Use it.
2578 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2579 (Fcopy_keymap): Handle embedded parents.
2580 (Fcommand_remapping, define_as_prefix): Simplify.
2581 (Fkey_binding): Simplify.
2582 (syms_of_keymap): Move minibuffer-local-completion-map,
2583 minibuffer-local-filename-completion-map,
2584 minibuffer-local-must-match-map, and
2585 minibuffer-local-filename-must-match-map to Elisp.
2586 (syms_of_keymap): Defsubr make-composed-keymap.
2587 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2588 (parse_menu_item): Trivial simplification.
2589
3279eb87
GM
25902011-07-01 Glenn Morris <rgm@gnu.org>
2591
2592 * Makefile.in (SETTINGS_LIBS): Fix typo.
2593
4550efdf
KI
25942011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2595
2596 * coding.c (Fencode_coding_string): Record the last coding system
2597 used, as the function doc string says (bug#8738).
2598
0949d2b6
JD
25992011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2600
2601 * xsettings.c (store_monospaced_changed): Take new font as arg and
2602 check for change against current_mono_font.
2603 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2604 (emacs_settings_constructor, emacs_settings_get_property)
2605 (emacs_settings_set_property, emacs_settings_class_init)
2606 (emacs_settings_init, gsettings_obj): Remove.
2607 (something_changedCB): New function for HAVE_GSETTINGS.
2608 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2609 with value as argument.
2610 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2611 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2612 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2613 "changed".
2614
2615 * xgselect.c: Add defined (HAVE_GSETTINGS).
2616 (xgselect_initialize): Ditto.
2617
2618 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2619 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2620 xg_select.
2621
bbc6b304
PE
26222011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2623
2624 * eval.c (struct backtrace): Simplify and port the data structure.
2625 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2626 signed bit field, as this assumption is not portable and it makes
2627 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2628 "char debug_on_exit : 1" as this is not portable either; instead,
2629 use the portable "unsigned int debug_on_exit : 1". Remove unused
2630 member evalargs. Remove obsolete comments about cc bombing out.
2631
9851bfc5
JD
26322011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2633
51bb811f 2634 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2635 Let HAVE_GSETTINGS override HAVE_GCONF.
2636 (store_monospaced_changed): New function.
2637 (EMACS_SETTINGS): A new type derived from GObject to handle
2638 GSettings notifications.
2639 (emacs_settings_constructor, emacs_settings_get_property)
2640 (emacs_settings_set_property, emacs_settings_class_init):
2641 New functions.
2642 (gsettings_client, gsettings_obj): New variables.
2643 (GSETTINGS_SCHEMA): New define.
2644 (something_changedCB): Call store_monospaced_changed.
2645 (init_gsettings): New function.
2646 (xsettings_initialize): Call init_gsettings.
2647 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2648 to NULL.
2649
640c8776 2650 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2651 GCONF_CFLAGS/LIBS.
2652
5386012d
MR
26532011-06-29 Martin Rudalics <rudalics@gmx.at>
2654
2655 * window.c (resize_root_window, grow_mini_window)
2656 (shrink_mini_window): Rename Qresize_root_window to
2657 Qwindow_resize_root_window and Qresize_root_window_vertically to
2658 Qwindow_resize_root_window_vertically.
2659
f13e0b08
PE
26602011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2661
2662 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2663
94515237
JB
26642011-06-27 Juanma Barranquero <lekktu@gmail.com>
2665
2666 * makefile.w32-in: Redesign dependencies so they reflect more
2667 clearly which files are directly included by each source file,
2668 and not through other includes.
2669
e43b6e43
MR
26702011-06-27 Martin Rudalics <rudalics@gmx.at>
2671
2672 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2673 (sort_overlays, overlay_strings): When an overlay's clone number
2674 matches the window's clone number process the overlay even if
2675 the overlay's window property doesn't match the current window.
2676
d68443dc
MR
2677 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2678 (Fwindow_hchild): Rename to Fwindow_left_child.
2679 (Fwindow_next): Rename to Fwindow_next_sibling.
2680 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2681 (resize_window_check): Rename to window_resize_check.
2682 (resize_window_apply): Rename to window_resize_apply.
2683 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2684 (Fdelete_other_windows_internal, resize_frame_windows)
2685 (Fsplit_window_internal, Fdelete_window_internal)
2686 (grow_mini_window, shrink_mini_window)
2687 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2688
c7e73be5
JD
26892011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2690
2691 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2692 (emacs_fixed_set_min_size): Remove.
2693 (emacs_fixed_new): Take frame as argument.
2694
2695 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2696 (_EmacsFixedPrivate): Remove minwidth/height.
2697 Add struct frame *f.
2698 (emacs_fixed_init): Initialize priv->f.
2699 (get_parent_class, emacs_fixed_set_min_size): Remove.
2700 (emacs_fixed_new): Set priv->f to argument.
2701 (emacs_fixed_get_preferred_width)
2702 (emacs_fixed_get_preferred_height): Use min_width/height from
2703 frames size_hint to set minimum and natural (Bug#8919).
2704 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2705 and use min_width/height from frames size_hint to set
2706 min_width/height (Bug#8919).
2707
2708 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2709 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2710 Fix indentation.
c7e73be5 2711
cf99dcf8
EZ
27122011-06-26 Eli Zaretskii <eliz@gnu.org>
2713
2714 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2715 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2716 called at ZV.
2717
029529ac
CY
27182011-06-26 Chong Yidong <cyd@stupidchicken.com>
2719
2720 * process.c (wait_reading_process_output): Bypass select if
2721 waiting for a cell while ignoring keyboard input, and input is
2722 pending. Suggested by Jan Djärv (Bug#8869).
2723
7a7ef429
PE
27242011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2725
2726 Use gnulib's dup2 module instead of rolling our own.
2727 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2728
11fdef7d 27292011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2730
2731 * dispnew.c (scrolling_window): Before scrolling, turn off a
2732 mouse-highlight in the window being scrolled.
2733
cd3520a4
JB
27342011-06-24 Juanma Barranquero <lekktu@gmail.com>
2735
2736 Move DEFSYM to lisp.h and use everywhere.
2737
2738 * character.h (DEFSYM): Move declaration...
2739 * lisp.h (DEFSYM): ...here.
2740
2741 * gnutls.c:
2742 * minibuf.c:
2743 * w32menu.c:
2744 * w32proc.c:
2745 * w32select.c: Don't include character.h.
2746
2747 * alloc.c (syms_of_alloc):
2748 * buffer.c (syms_of_buffer):
2749 * bytecode.c (syms_of_bytecode):
2750 * callint.c (syms_of_callint):
2751 * casefiddle.c (syms_of_casefiddle):
2752 * casetab.c (init_casetab_once):
2753 * category.c (init_category_once, syms_of_category):
2754 * ccl.c (syms_of_ccl):
2755 * cmds.c (syms_of_cmds):
2756 * composite.c (syms_of_composite):
2757 * dbusbind.c (syms_of_dbusbind):
2758 * dired.c (syms_of_dired):
2759 * dispnew.c (syms_of_display):
2760 * doc.c (syms_of_doc):
2761 * editfns.c (syms_of_editfns):
2762 * emacs.c (syms_of_emacs):
2763 * eval.c (syms_of_eval):
2764 * fileio.c (syms_of_fileio):
2765 * fns.c (syms_of_fns):
2766 * frame.c (syms_of_frame):
2767 * fringe.c (syms_of_fringe):
2768 * insdel.c (syms_of_insdel):
2769 * keymap.c (syms_of_keymap):
2770 * lread.c (init_obarray, syms_of_lread):
2771 * macros.c (syms_of_macros):
2772 * msdos.c (syms_of_msdos):
2773 * print.c (syms_of_print):
2774 * process.c (syms_of_process):
2775 * search.c (syms_of_search):
2776 * sound.c (syms_of_sound):
2777 * syntax.c (init_syntax_once, syms_of_syntax):
2778 * terminal.c (syms_of_terminal):
2779 * textprop.c (syms_of_textprop):
2780 * undo.c (syms_of_undo):
2781 * w32.c (globals_of_w32):
2782 * window.c (syms_of_window):
2783 * xdisp.c (syms_of_xdisp):
2784 * xfaces.c (syms_of_xfaces):
2785 * xfns.c (syms_of_xfns):
2786 * xmenu.c (syms_of_xmenu):
2787 * xsettings.c (syms_of_xsettings):
2788 * xterm.c (syms_of_xterm): Use DEFSYM.
2789
4228cf16
TZ
27902011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2791
cd3520a4 2792 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2793
7fcccf1e
PE
27942011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2795
7efb4e0e
PE
2796 Integer and buffer overflow fixes (Bug#8873).
2797
ff5844ad
PE
2798 * print.c (printchar, strout): Check for string overflow.
2799 (PRINTPREPARE, printchar, strout):
2800 Don't set size unless allocation succeeds.
2801
90532f02
PE
2802 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2803 for sizes. Check for string overflow more accurately.
2804 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2805
6d84508d
PE
2806 * macros.c: Integer and buffer overflow fixes.
2807 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2808 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2809 Use ptrdiff_t, not int, for sizes.
2810 Don't increment bufsize until after realloc succeeds.
2811 Check for size-calculation overflow.
2812 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2813
437b2cb4
PE
2814 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2815
8b9ac8b4
PE
2816 * lread.c: Integer overflow fixes.
2817 (read_integer): Radix is now EMACS_INT, not int,
2818 to improve quality of diagnostics for out-of-range radices.
2819 Calculate buffer size correctly for out-of-range radices.
2820 (read1): Check for integer overflow in radices, and in
2821 read-circle numbers.
82cb60d3
PE
2822 (read_escape): Avoid int overflow.
2823 (Fload, openp, read_buffer_size, read1)
2824 (substitute_object_recurse, read_vector, read_list, map_obarray):
2825 Use ptrdiff_t, not int, for sizes.
2826 (read1): Use EMACS_INT, not int, for sizes.
20270765 2827 Check for size overflow.
8b9ac8b4 2828
7fcccf1e
PE
2829 * image.c (cache_image): Check for size arithmetic overflow.
2830
bfbbd7e7
PE
2831 * lread.c: Integer overflow issues.
2832 (saved_doc_string_size, saved_doc_string_length)
2833 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2834 Now ptrdiff_t, not int.
2835 (read1): Don't assume doc string length fits in int. Check for
2836 out-of-range doc string lengths.
2837 (read_list): Don't assume file position fits in int.
39019e54 2838 (read_escape): Check for hex character overflow.
bfbbd7e7 2839
4e323265
LL
28402011-06-22 Leo Liu <sdl.web@gmail.com>
2841
2842 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2843 Move to minibuffer.el.
2844
85fece3e
PE
28452011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2846
20b84ce9 2847 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2848 The following patches are for when GLYPH_DEBUG && !XASSERT.
2849 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2850 * dispnew.c (flush_stdout):
2851 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2852 Mark as externally visible.
2853 * dispnew.c (check_window_matrix_pointers): Now static.
2854 * dispnew.c (window_to_frame_vpos):
2855 * xfns.c (unwind_create_frame):
2856 * xterm.c (x_check_font): Remove unused local.
2857 * scroll.c (CHECK_BOUNDS):
2858 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2859 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2860 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2861 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2862 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2863 Now static.
2864 (debug_method_add): Use va_list and vsprintf rather than relying
2865 on undefined behavior with wrong number of arguments.
2866 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2867 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2868 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2869 since we're not interested in debugging glyphs with old libraries.
2870 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2871 GCC 4.6.0's static checking.
2872
0766b489
PE
28732011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2874
31fd4b32
PE
2875 Integer overflow and signedness fixes (Bug#8873).
2876 A few related buffer overrun fixes, too.
2877
b79e8648
PE
2878 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2879
0766b489
PE
2880 * dispextern.h (struct face.stipple):
2881 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2882 (x_bitmap_mask, x_allocate_bitmap_record)
2883 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2884 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2885 (x_create_bitmap_from_xpm_data):
2886 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2887 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2888 (.bitmaps_last):
2889 * xfaces.c (load_pixmap):
2890 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2891 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2892 (.bitmaps_last, struct x_output.icon_bitmap):
2893 Use ptrdiff_t, not int, for bitmap indexes.
2894 (x_allocate_bitmap_record): Check for size overflow.
2895 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2896
b081724f
PE
2897 Use ptrdiff_t, not int, for overlay counts.
2898 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2899 * editfns.c (overlays_around, get_pos_property):
2900 * textprop.c (get_char_property_and_overlay):
2901 * xdisp.c (next_overlay_change, note_mouse_highlight):
2902 * xfaces.c (face_at_buffer_position):
21514da7
PE
2903 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2904 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2905 (Fnext_overlay_change, Fprevious_overlay_change)
2906 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2907 Use ptrdiff_t, not int, for sizes.
21514da7 2908 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2909
3de73e5e
PE
2910 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2911
2606c57b
PE
2912 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2913 (x_session_initialize): Do not assume string length fits in int.
2914
aaafe47a
PE
2915 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2916 This is unlikely, but can occur if DPI is outlandish.
2917
2674ddc8 2918 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2919 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2920
28154962
PE
2921 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2922 * xrdb.c (magic_file_p, search_magic_path):
2923 Omit last arg SUFFIX; it was always 0. All callers changed.
2924 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2925
7de51af5
PE
2926 * xfont.c (xfont_match): Avoid need for strlen.
2927
25ed6cc3
PE
2928 * xfns.c: Don't assume strlen fits in int.
2929 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2930
4eab31dd
PE
2931 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2932 not unsigned long, as we prefer signed integers. All callers changed.
2933 Detect integer overflow in repeat count.
2934 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2935 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2936
171e2a58
PE
2937 * termcap.c: Don't assume sizes fit in int and never overflow.
2938 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2939 (gobble_line): Check for size-calculation overflow.
2940
ad39faca 2941 * minibuf.c (Fread_buffer):
6e5bb2dc 2942 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2943 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2944 Don't assume string length fits in int.
2945
52c61c22 2946 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2947 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2948
b5b8c9e5
PE
2949 * font.c: Don't assume string length fits in int.
2950 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2951 Use ptrdiff_t, not int.
ccd6111c
PE
2952 (font_intern_prop): Don't assume string length fits in int.
2953 Don't assume integer property fits in fixnum.
2954 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2955
882f0d81 2956 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2957 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2958 Reformulate so as not to need the command string.
2959 Invoke gzip -cd rather than gunzip, as it's more portable.
2960 (lock_info_type, lock_file_1, lock_file):
2961 Don't assume pid_t and time_t fit in unsigned long.
2962 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2963 (current_lock_owner): Prefer signed type for sizes.
2964 Use memcpy, not strncpy, where memcpy is what is really wanted.
2965 Don't assume (via atoi) that time_t and pid_t fit in int.
2966 Check for time_t and/or pid_t out of range, e.g., via a network share.
2967 Don't alloca where an auto var works fine.
2968
93f4cf88
PE
2969 * fileio.c: Fix some integer overflow issues.
2970 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2971 Don't assume string length fits in int.
2972 (directory_file_name): Don't assume string length fits in long.
2973 (make_temp_name): Don't assume pid fits in int, or that its print
2974 length is less than 20.
2975
f3e92b69
PE
2976 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2977
1bfdaf10
PE
2978 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2979
35016e9a
PE
2980 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2981
3d1e65a1
PE
2982 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2983 We prefer signed integers, even for size calculations.
2984
0b963a93
PE
2985 * emacs.c: Don't assume string length fits in 'int'.
2986 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2987 (main): Don't invoke strlen when not needed.
2988
573f4b54
PE
2989 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2990 (XD_DEBUG_MESSAGE): Don't waste a byte.
2991
989f33ba
PE
2992 * callproc.c (getenv_internal_1, getenv_internal)
2993 (Fgetenv_internal):
965d34eb
PE
2994 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2995
e4d29b33
PE
2996 * lread.c (invalid_syntax): Omit length argument.
2997 All uses changed. This doesn't fix a bug, but it simplifies the
2998 code away from its former Hollerith-constant appearance, and it's
2999 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3000 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3001
eb49b136
PE
3002 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3003 This didn't break anything, but it didn't help either.
3004 It's confusing to put a bogus integer in a place where the actual
3005 value does not matter.
9f62aeb1 3006 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3007 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3008
15375a22
PE
3009 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3010 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3011 implementation.
b61cc01c
PE
3012 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3013 We prefer signed types, and the value cannot exceed the EMACS_INT
3014 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3015 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3016 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3017 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3018
53b2623d
PE
3019 * indent.c (sane_tab_width): New function.
3020 (current_column, scan_for_column, Findent_to, position_indentation)
3021 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3022 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3023
51cab52b 3024 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3025
f2ed8a70
PE
3026 * lisp.h (lint_assume): New macro.
3027 * composite.c (composition_gstring_put_cache):
3028 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3029
abe80cc6
PE
3030 * editfns.c, insdel.c:
3031 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3032
b02c740e
PE
3033 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3034
ebc96716
PE
3035 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3036
b4e50fa0 3037 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3038 Use much-faster test for byte-length change.
311d5d7c 3039 Don't assume string byte-length fits in 'int'.
a4cf38e4 3040 Check that character arg fits in 'int'.
85461888 3041 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3042
c0c1ee9f
PE
3043 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3044
a498d7f4
PE
3045 * fns.c (concat): Catch string overflow earlier.
3046 Do not rely on integer wraparound.
3047
51cab52b
PE
3048 * dispextern.h (struct it.overlay_strings_charpos)
3049 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3050 * xdisp.c (forward_to_next_line_start)
3051 (back_to_previous_visible_line_start)
3052 (reseat_at_next_visible_line_start, next_element_from_buffer):
3053 Don't arbitrarily truncate the value of 'selective' to int.
3054
76031fad
PE
3055 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3056
5eb55db9
PE
3057 * composite.c: Don't truncate sizes to 'int'.
3058 (composition_gstring_p, composition_reseat_it)
3059 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3060 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3061 not EMACS_UINT, for indexes.
5eb55db9 3062
0703a717
PE
3063 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3064
d6202519
PE
3065 * buffer.c: Include <verify.h>.
3066 (struct sortvec.priority, struct sortstr.priority):
8961a454 3067 Now EMACS_INT, not int.
c20998a7 3068 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3069 (struct sortstr.size, record_overlay_string)
3070 (struct sortstrlist.size, struct sortlist.used):
3071 Don't truncate size to int.
3072 (record_overlay_string): Check for size-calculation overflow.
d6202519 3073 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3074
d5a19415
JM
30752011-06-22 Jim Meyering <meyering@redhat.com>
3076
029529ac 3077 Don't leak an XBM-image-sized buffer
d5a19415
JM
3078 * image.c (xbm_load): Free the image buffer after using it.
3079
a9041e6c
PE
30802011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3081
3082 Port to Sun C.
3083 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3084 that Sun C diagnosed.
3085 * fns.c (secure_hash): Fix pointer signedness issue.
3086 * intervals.c (static_offset_intervals): New function.
3087 (offset_intervals): Use it.
3088
7f3f739f
LL
30892011-06-21 Leo Liu <sdl.web@gmail.com>
3090
3091 * deps.mk (fns.o):
3092 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3093 sha512.h.
3094
3095 * fns.c (secure_hash): Rename from crypto_hash_function and change
3096 the first arg to accept symbols.
5b66d427 3097 (Fsecure_hash): New primitive.
7f3f739f
LL
3098 (syms_of_fns): New symbols.
3099
76147d94
DD
31002011-06-20 Deniz Dogan <deniz@dogan.se>
3101
3102 * process.c (Fset_process_buffer): Clarify return value in
3103 docstring.
3104
7d7d0045
CY
31052011-06-18 Chong Yidong <cyd@stupidchicken.com>
3106
3107 * dispnew.c (add_window_display_history): Use BVAR.
3108
3109 * xdisp.c (debug_method_add): Use BVAR.
3110 (check_window_end, dump_glyph_matrix, dump_glyph)
3111 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3112
3113 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3114 Likewise.
3115
3116 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3117 check till after the cache is created in init_frame_faces.
3118
ff2bc410
SM
31192011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3120
3121 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3122
28177add
PE
31232011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3124
dd3482fe
PE
3125 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3126 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3127 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3128
393d71f3 3129 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3130 * fileio.c (Finsert_file_contents):
3131 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3132 Remove the old (too-loose) buffer overflow checks.
3133 They weren't needed, since make_gap checks for buffer overflow.
3134 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3135 The old code merely checked for Emacs fixnum overflow, and relied
3136 on undefined (wraparound) behavior. The new code avoids undefined
3137 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3138
2e6813b0 3139 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3140 Tune. Don't use wider integers than needed. Don't use alloca.
3141 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3142
599a9e4f
PE
3143 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3144
99561444
PE
3145 * insdel.c, lisp.h (buffer_overflow): New function.
3146 (insert_from_buffer_1, replace_range, replace_range_2):
3147 * insdel.c (make_gap_larger):
3148 * editfns.c (Finsert_char):
3149 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3150
28177add
PE
3151 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3152
e69dafad
PE
31532011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3154
a7af7fde 3155 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3156
b1c46f02
PE
3157 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3158 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3159
e69dafad
PE
3160 * fileio.c: Don't assume EMACS_INT fits in off_t.
3161 (emacs_lseek): New static function.
3162 (Finsert_file_contents, Fwrite_region): Use it.
3163 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3164
566684ea
PE
3165 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3166
e6966cd6
PE
3167 * fns.c: Don't overflow int when computing a list length.
3168 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3169 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3170 truncation on 64-bit hosts. Check for QUIT every
3171 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3172 faster and is responsive enough.
3173 (Flength): Report an error instead of overflowing an integer.
3174 (Fsafe_length): Return a float if the value is not representable
3175 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3176 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3177 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3178
dd0b0efb
PE
3179 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3180 (header_size, word_size): New constants.
3181 (allocate_vectorlike): Don't check size overflow here.
3182 (allocate_vector): Check it here instead, since this is the only
3183 caller of allocate_vectorlike that could cause overflow.
3184 Check that the new vector's length is representable as a fixnum.
3185
86fe5cfe
PE
3186 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3187 The previous code was bogus. For example, next_almost_prime (32)
3188 returned 39, which is undesirable as it is a multiple of 3; and
3189 next_almost_prime (24) returned 25, which is a multiple of 5 so
3190 why was the code bothering to check for multiples of 7?
3191
80e88859
PE
3192 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3193
4a2f0ad6
PE
3194 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3195
f66c7cf8
PE
3196 Variadic C functions now count arguments with ptrdiff_t.
3197 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3198 Back then I didn't know that the Emacs coding style prefers signed int.
3199 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3200 were being counted with int, which may truncate counts on 64-bit
3201 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3202 * lisp.h (struct Lisp_Subr.function.aMANY)
3203 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3204 Arg counts are now ptrdiff_t, not size_t.
3205 All variadic functions and their callers changed accordingly.
3206 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3207 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3208 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3209 * callint.c (Fcall_interactively): Check arg count for overflow,
3210 to avoid potential buffer overrun. Use signed char, not 'int',
3211 for 'varies' array, so that we needn't bother to check its size
3212 calculation for overflow.
3213 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3214 * eval.c (apply_lambda):
3215 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3216 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3217 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3218
a1759b76
PE
3219 * callint.c (Fcall_interactively): Don't use index var as event count.
3220
d96be9fc
PE
3221 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3222 * mem-limits.h (SIZE): Remove; no longer used.
3223
a690a978 3224 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3225
578c21e6
PE
3226 Remove unnecessary casts.
3227 * xterm.c (x_term_init):
3228 * xfns.c (x_set_border_pixel):
3229 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3230 These aren't needed now that we assume ANSI C.
3231
96f53c6c
PE
3232 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3233 It's more likely to cause problems (due to unsigned overflow)
3234 than to cure them.
3235
83c77d31
PE
3236 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3237
ee2079f1
PE
3238 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3239
6da65536
PE
3240 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3241
7147c4a4
PE
3242 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3243
193e32d9
PE
3244 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3245
e5533da6
PE
3246 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3247
9910e595
PE
3248 GLYPH_CODE_FACE returns EMACS_INT, not int.
3249 * dispextern.h (merge_faces):
3250 * xfaces.c (merge_faces):
01103c44
PE
3251 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3252 Don't assume EMACS_INT fits in int.
9910e595 3253
2638320e
PE
3254 * character.h (CHAR_VALID_P): Remove unused parameter.
3255 * fontset.c, lisp.h, xdisp.c: All uses changed.
3256
045eb8d9
PE
3257 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3258
c1f134b5
PE
3259 * fns.c (concat): Minor tuning based on overflow analysis.
3260 This doesn't fix any bugs. Use int to hold character, instead
3261 of constantly refetching from Emacs object. Use XFASTINT, not
3262 XINT, for value known to be a character. Don't bother comparing
3263 a single byte to 0400, as it's always less.
3264
395fcb93 3265 * floatfns.c (Fexpt):
327eeec8
PE
3266 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3267
abbd3d23
PE
3268 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3269 for characters.
3270
684a03ef
PE
3271 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3272
0fed43f3
PE
3273 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3274 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3275 incorrectly succeed when S was a string, because 4294967386 was
3276 truncated before it was used.
3277
8fd02eb7
PE
3278 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3279 Otherwise, an out-of-range integer could cause undefined behavior
3280 on a 64-bit host.
3281
f8c86b69
PE
3282 * composite.c: Use int, not EMACS_INT, for characters.
3283 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3284 EMACS_INT, for values that are known to be in character range.
3285 This doesn't fix any bugs but is the usual style inside Emacs and
3286 may generate better code on 32-bit machines.
3287
34206dd2
PE
3288 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3289 This is for reasons similar to the recent CHAR_STRING fix.
3290 * charset.c (Fencode_char): Check that character arg is actually
3291 a character. Pass an int to ENCODE_CHAR.
3292 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3293 wider than 'int', as a compile-time check to prevent future regressions
3294 in this area.
3295
c5958d4c 3296 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3297
3298 Make sure a 64-bit char is never passed to CHAR_STRING.
3299 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3300 by silently ignoring the top 32 bits, allowing some values
3301 that were far too large to be valid characters.
3302 * character.h: Include <verify.h>.
3303 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3304 arguments are no wider than unsigned, as a compile-time check
3305 to prevent future regressions in this area.
3306 * data.c (Faset):
01103c44 3307 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3308 (Fsubst_char_in_region):
3309 * fns.c (concat):
3310 * xdisp.c (decode_mode_spec_coding):
3311 Adjust to CHAR_STRING's new requirement.
3312 * editfns.c (Finsert_char, Fsubst_char_in_region):
3313 * fns.c (concat): Check that character args are actually
3314 characters. Without this test, these functions did the wrong
3315 thing with wildly out-of-range values on 64-bit hosts.
3316
d37ca623
PE
3317 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3318 These casts should not be needed on 32-bit hosts, either.
3319 * keyboard.c (read_char):
3320 * lread.c (Fload): Remove casts to unsigned.
3321
ea204efb
PE
3322 * lisp.h (UNSIGNED_CMP): New macro.
3323 This fixes comparison bugs on 64-bit hosts.
3324 (ASCII_CHAR_P): Use it.
3325 * casefiddle.c (casify_object):
01103c44 3326 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3327 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3328 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3329 * dispextern.h (FACE_FROM_ID):
3330 * keyboard.c (read_char): Use UNSIGNED_CMP.
3331
41cb286c
PE
3332 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3333 not to EMACS_INT, to avoid GCC warning.
3334
4a1b9832
PE
3335 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3336
55daad71
PE
3337 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3338 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3339 isn't needed on 32-bit machines.
8f95c75c 3340
01103c44
PE
3341 * buffer.c (Fgenerate_new_buffer_name):
3342 Use EMACS_INT for count, not int.
0ceccced 3343 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3344
3345 * data.c (Qcompiled_function): Now static.
3346
c6f072e7
PE
3347 * window.c (window_body_lines): Now static.
3348
20ce5912
PE
3349 * image.c (gif_load): Rename local to avoid shadowing.
3350
9c4c5f81
PE
3351 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3352 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3353 * alloc.c (make_save_value): Integer argument is now of type
3354 ptrdiff_t, not int.
3355 (mark_object): Use ptrdiff_t, not int.
3356 * lisp.h (pD): New macro.
3357 * print.c (print_object): Use it.
3358
c0c5c8ae
PE
3359 * alloc.c: Use EMACS_INT, not int, to count objects.
3360 (total_conses, total_markers, total_symbols, total_vector_size)
3361 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3362 (total_free_floats, total_floats, total_free_intervals)
3363 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3364 Now EMACS_INT, not int. All uses changed.
3365 (Fgarbage_collect): Compute overall total using a double, so that
3366 integer overflow is less likely to be a problem. Check for overflow
3367 when converting back to an integer.
5a25e253
PE
3368 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3369 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3370 These were 'int' variables that could overflow on 64-bit hosts;
3371 they were never used, so remove them instead of repairing them.
211a0b2a 3372 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3373 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3374 Previously, this ceilinged at INT_MAX, but that doesn't work on
3375 64-bit machines.
e46bb31a 3376 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3377
c78baabf 3378 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3379 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3380 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3381 when a (possibly-narrower) signed value would do just as well.
3382 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3383
c9d624c6
PE
3384 * alloc.c: Catch some string size overflows that we were missing.
3385 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3386 for convenience in STRING_BYTES_MAX.
3387 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3388 The definition here is exact; the one in lisp.h was approximate.
3389 (allocate_string_data): Check for string overflow. This catches
3390 some instances we weren't catching before. Also, it catches
3391 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3392 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3393 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3394
c9d624c6
PE
3395 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3396 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3397 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3398
353032ce
PE
3399 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3400
2bccce07
PE
3401 * alloc.c (Fmake_string): Check for out-of-range init.
3402
0ac30604
SM
34032011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3404
3405 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3406
c195f2de
JD
34072011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3408
3409 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3410 xg_get_default_scrollbar_width.
3411
3412 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3413 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3414 (style_changed_cb): Call update_theme_scrollbar_width and call
3415 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3416 all frames (Bug#8505).
3417 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3418 Call gtk_window_set_resizable if HAVE_GTK3.
3419 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3420 and height if HAVE_GTK3 (Bug#8505).
3421 (scroll_bar_width_for_theme): New variable.
3422 (update_theme_scrollbar_width): New function.
3423 (xg_get_default_scrollbar_width): Move code to
3424 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3425 (xg_initialize): Call update_theme_scrollbar_width.
3426
3427 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3428
3429 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3430
e10ac9f1
MR
34312011-06-12 Martin Rudalics <rudalics@gmx.at>
3432
3433 * frame.c (make_frame): Call other_buffer_safely instead of
3434 other_buffer.
3435
3436 * window.c (temp_output_buffer_show): Call display_buffer with
3437 second argument Vtemp_buffer_show_specifiers and reset latter
3438 immediately after the call.
3439 (Vtemp_buffer_show_specifiers): New variable.
3440 (auto_window_vscroll_p, next_screen_context_lines)
3441 (Vscroll_preserve_screen_position): Remove leading asterisks from
3442 doc-strings.
3443
2d3c217e 34442011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3445
7b7f97e8 3446 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3447 * buffer.c (Qclone_number): Remove for now, as it's unused.
3448 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3449 (record_buffer): Remove unused local.
3450 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3451 (set_frame_buffer_list): Remove; unused.
3452 * frame.h (other_visible_frames): Remove decl.
3453 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3454 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3455 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3456 if HAVE_GPM.
3457 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3458 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3459 Define only if HAVE_GPM.
3460 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3461 (update_hints_inhibit): Remove; never set. All uses removed.
3462 * widgetprv.h (emacsFrameClassRec): Remove decl.
3463 * window.c (delete_deletable_window): Now returns void, since it
3464 wasn't returning anything.
3465 (compare_window_configurations): Remove unused locals.
3466 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3467 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3468 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3469 the same widths as pointers. This follows up on the 2011-05-06 patch.
3470 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3471 * xterm.h: Likewise.
3472 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3473
1384b89e
JB
34742011-06-12 Juanma Barranquero <lekktu@gmail.com>
3475
3476 * makefile.w32-in: Update dependencies.
3477 (LISP_H): Add lib/intprops.h.
3478
1100a63c
CY
34792011-06-11 Chong Yidong <cyd@stupidchicken.com>
3480
3481 * image.c (gif_load): Add animation frame delay to the metadata.
3482 (syms_of_image): Use DEFSYM. New symbol `delay'.
3483
6198ccd0
MR
34842011-06-11 Martin Rudalics <rudalics@gmx.at>
3485
3486 * window.c (delete_deletable_window): Re-add.
3487 (Fset_window_configuration): Rewrite to handle dead buffers and
3488 consequently deletable windows.
3489 (window_tree, Fwindow_tree): Remove. Supply functionality in
3490 window.el.
3491 (compare_window_configurations): Simplify code.
3492
b6e3633c
AS
34932011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3494
1ab0dee5
AS
3495 * image.c (imagemagick_load_image): Fix type mismatch.
3496 (Fimagemagick_types): Likewise.
3497
b6e3633c
AS
3498 * window.h (replace_buffer_in_windows): Declare.
3499
9397e56f
MR
35002011-06-11 Martin Rudalics <rudalics@gmx.at>
3501
3502 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3503 Qclone_number. Remove external declaration of Qdelete_window.
3504 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3505 code.
640c8776
SM
3506 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3507 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3508 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3509 buffer list implementation.
3510 (other_buffer_safely): New function.
3511 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3512 calls to replace_buffer_in_windows and
3513 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3514 if allowed.
3515 (record_buffer): Inhibit quitting and rewrite using quittable
3516 functions. Run Qbuffer_list_update_hook if allowed.
3517 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3518 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3519 Move switch-to-buffer to window.el.
9397e56f
MR
3520 (bury-buffer): Move to window.el.
3521 (Vbuffer_list_update_hook): New variable.
3522
3523 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3524 section.
3525
3526 * window.h (resize_frame_windows): Move up in code.
3527 (Fwindow_frame): Remove EXFUN.
3528 (replace_buffer_in_all_windows): Remove prototype.
3529 (replace_buffer_in_windows_safely): Add prototype.
3530
3531 * window.c: Declare Qdelete_window static again. Move down
3532 declaration of select_count.
3533 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3534 (Fother_window): Move to window.el.
3535 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3536 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3537 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3538 window.el.
3539 (replace_buffer_in_windows): Implement by calling
3540 Qreplace_buffer_in_windows.
3541 (replace_buffer_in_all_windows): Remove with some functionality
3542 moved into replace_buffer_in_windows_safely.
3543 (replace_buffer_in_windows_safely): New function.
3544 (select_window_norecord, select_frame_norecord): Move in front
3545 of run_window_configuration_change_hook. Remove now obsolete
3546 declarations.
640c8776
SM
3547 (Fset_window_buffer): Rewrite doc-string.
3548 Call Qrecord_window_buffer.
9397e56f
MR
3549 (keys_of_window): Move binding for other-window to window.el.
3550
b50691aa
CY
35512011-06-11 Chong Yidong <cyd@stupidchicken.com>
3552
3553 * dispextern.h (struct image): Replace data member, whose int_val
3554 and ptr_val fields were not used by anything, with a single
3555 lisp_val object.
3556
3557 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3558 (gif_clear_image, gif_load, imagemagick_load_image)
3559 (gs_clear_image, gs_load): Callers changed.
3560
3f754b86
PE
35612011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3562
cca69397
PE
3563 * buffer.h: Include <time.h>, for time_t.
3564 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3565
109e28d0
PE
3566 Fix minor problems found by static checking.
3567
60737f02
PE
3568 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3569
4b66faf3
PE
3570 Make identifiers static if they are not used in other modules.
3571 * data.c (Qcompiled_function, Qframe, Qvector):
3572 * image.c (QimageMagick, Qsvg):
3573 * minibuf.c (Qmetadata):
3574 * window.c (resize_window_check, resize_root_window): Now static.
3575 * window.h (resize_window_check, resize_root_window): Remove decls.
3576
109e28d0
PE
3577 * window.c (window_deletion_count, delete_deletable_window):
3578 Remove; unused.
46a4ce9e
PE
3579 (window_body_lines): Now static.
3580 (Fdelete_other_windows_internal): Mark vars as initialized.
3581 Make sure 'resize_failed' is initialized.
3582 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3583 (resize_window_apply): Remove unused local.
3584 * window.h (delete_deletable_window): Remove decl.
3585
109e28d0 3586 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3587 (imagemagick_load_image): Fix pointer signedness problem by changing
3588 last arg from unsigned char * to char *. All uses changed.
3589 Also, fix a local for similar reasons.
3590 Remove unused locals. Remove locals to avoid shadowing.
3591 (fn_rsvg_handle_free): Remove; unused.
3592 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3593 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3594
3f754b86
PE
3595 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3596
2547adb1
CY
35972011-06-10 Chong Yidong <cyd@stupidchicken.com>
3598
3599 * image.c (gif_load): Fix omitted cast error introduced by
3600 2011-06-06 change.
3601
2c8e37d4
MR
36022011-06-10 Martin Rudalics <rudalics@gmx.at>
3603
3604 * window.h (resize_proportionally, orig_total_lines)
3605 (orig_top_line): Remove from window structure.
3606 (set_window_height, set_window_width, change_window_heights)
3607 (Fdelete_window): Remove prototypes.
3608 (resize_frame_windows): Remove duplicate declaration.
3609
440a42e3
EZ
36102011-06-10 Eli Zaretskii <eliz@gnu.org>
3611
3612 * window.h (resize_frame_windows, resize_window_check)
3613 (delete_deletable_window, resize_root_window)
3614 (resize_frame_windows): Declare prototypes.
3615
3616 * window.c (resize_window_apply): Make definition be "static" to
3617 match the prototype.
3618
562dd5e9
MR
36192011-06-10 Martin Rudalics <rudalics@gmx.at>
3620
3621 * window.c: Remove declarations of Qwindow_size_fixed,
3622 window_min_size_1, window_min_size_2, window_min_size,
3623 size_window, window_fixed_size_p, enlarge_window, delete_window.
3624 Remove static from declaration of Qdelete_window, it's
3625 temporarily needed by Fbury_buffer.
3626 (replace_window): Don't assign orig_top_line and
3627 orig_total_lines.
3628 (Fdelete_window, delete_window): Remove. Window deletion is
3629 handled by window.el.
640c8776
SM
3630 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3631 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3632 (Fdelete_other_windows): Remove. Deleting other windows is
3633 handled by window.el.
3634 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3635 handled in window.el.
3636 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3637 Window minimum sizes are handled in window.el.
3638 (shrink_windows, size_window, set_window_height)
3639 (set_window_width, change_window_heights, window_height)
3640 (window_width, CURBEG, CURSIZE, enlarge_window)
3641 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3642 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3643 handled in window.el.
3644 (make_dummy_parent): Rename to make_parent_window and give it a
3645 second argument horflag.
3646 (make_window): Don't set resize_proportionally any more.
3647 (Fsplit_window): Remove. Windows are split in window.el.
3648 (save_restore_action, save_restore_orig_size)
3649 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3650 Resize mini windows in window.el.
3651 (grow_mini_window, shrink_mini_window): Implement by calling
3652 Qresize_root_window_vertically, resize_window_check and
3653 resize_window_apply.
640c8776
SM
3654 (saved_window, Fset_window_configuration, save_window_save):
3655 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3656 resize_proportionally.
3657 (window_min_height, window_min_width): Move to window.el.
3658 (keys_of_window): Move bindings for delete-other-windows,
3659 split-window, delete-window and enlarge-window to window.el.
3660
3661 * buffer.c: Temporarily extern Qdelete_window.
3662 (Fbury_buffer): Temporarily call Qdelete_window instead of
3663 Fdelete_window (Fbury_buffer will move to window.el soon).
3664
3665 * frame.c (set_menu_bar_lines_1): Remove code handling
3666 orig_top_line and orig_total_lines.
3667
3668 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3669 set_window_height but set heights directly.
3670 (change_frame_size_1): Use resize_frame_windows.
3671
3672 * xdisp.c (init_xdisp): Don't use set_window_height but set
3673 heights directly.
3674
640c8776
SM
3675 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3676 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3677 run_window_configuration_change_hook.
3678
3679 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3680 instead of change_window_heights and run
3681 run_window_configuration_change_hook.
3682
1a13852e
MR
36832011-06-09 Martin Rudalics <rudalics@gmx.at>
3684
3685 * window.c (replace_window): Rename second argument REPLACEMENT to
3686 NEW. New third argument SETFLAG. Rewrite.
3687 (delete_window, make_dummy_parent): Call replace_window with
3688 third argument 1.
3689 (window_list_1): Move down in code.
3690 (run_window_configuration_change_hook): Move set_buffer part
3691 before select_frame_norecord part in order to unwind correctly.
3692 Rename count1 to count.
3693 (recombine_windows, delete_deletable_window, resize_root_window)
3694 (Fdelete_other_windows_internal)
3695 (Frun_window_configuration_change_hook, make_parent_window)
3696 (resize_window_check, resize_window_apply, Fresize_window_apply)
3697 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3698 (Fdelete_window_internal, Fresize_mini_window_internal):
3699 New functions.
1a13852e
MR
3700 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3701
f3d1777e
MR
37022011-06-08 Martin Rudalics <rudalics@gmx.at>
3703
496e208e
MR
3704 * window.h (window): Add some new members to window structure -
3705 normal_lines, normal_cols, new_total, new_normal, clone_number,
3706 splits, nest, prev_buffers, next_buffers.
3707 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3708 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3709
f3d1777e
MR
3710 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3711 Remove.
496e208e
MR
3712 (make_dummy_parent): Set new members of windows structure.
3713 (make_window): Move down in code. Handle new members of window
3714 structure.
3715 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3716 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3717 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3718 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3719 (Fset_window_next_buffers, Fset_window_clone_number):
3720 New functions.
496e208e
MR
3721 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3722 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3723 Doc-string fixes.
3724 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3725 Argument WINDOW can be now internal window too.
3726 (Fwindow_use_time): Move up in code.
3727 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3728 Rewrite doc-string.
3729 (Fset_window_configuration, saved_window)
3730 (Fcurrent_window_configuration, save_window_save): Handle new
3731 members of window structure.
b9e809c2
MR
3732 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3733 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3734 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3735 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3736 Qget_mru_window, Qresize_root_window,
3737 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3738 Qauto_buffer_name; staticpro them.
f3d1777e 3739
abde8f8c
MR
37402011-06-07 Martin Rudalics <rudalics@gmx.at>
3741
3742 * window.c (Fwindow_total_size, Fwindow_left_column)
3743 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3744 (Fwindow_list_1): New functions.
3745 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3746 (Fwindow_width, Fscroll_left, Fscroll_right):
3747 Use window_body_cols instead of window_box_text_cols.
3748 (delete_window, Fset_window_configuration):
3749 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3750 (delete_all_subwindows): Take a window as argument and not a
3751 structure. Rewrite.
190b47e6
MR
3752 (window_loop): Remove handling of GET_LRU_WINDOW and
3753 GET_LARGEST_WINDOW.
3754 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3755
3756 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3757 window_box_text_cols. delete_all_subwindows now takes a
3758 Lisp_Object as argument.
abde8f8c 3759
640c8776
SM
3760 * indent.c (compute_motion, Fcompute_motion):
3761 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3762
fa8a67e6
MR
3763 * frame.c (delete_frame): Call delete_all_subwindows with root
3764 window as argument.
3765
a54e3482
DC
37662011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3767
3768 * fns.c (Fputhash): Document return value.
3769
60002bf5
CY
37702011-06-06 Chong Yidong <cyd@stupidchicken.com>
3771
3772 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3773
0c671da6 37742011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3775
b862a52a 3776 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3777
be44ca6c
PE
3778 Check for overflow when converting integer to cons and back.
3779 * charset.c (Fdefine_charset_internal, Fdecode_char):
3780 Use cons_to_unsigned to catch overflow.
3781 (Fencode_char): Use INTEGER_TO_CONS.
3782 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3783 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3784 * data.c (long_to_cons, cons_to_long): Remove.
3785 (cons_to_unsigned, cons_to_signed): New functions.
3786 These signal an error for invalid or out-of-range values.
3787 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3788 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3789 * font.c (Ffont_variation_glyphs):
3790 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3791 * lisp.h: Include <intprops.h>.
3792 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3793 (cons_to_signed, cons_to_unsigned): New decls.
3794 (long_to_cons, cons_to_long): Remove decls.
3795 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3796 (Fprimitive_undo): Use CONS_TO_INTEGER.
3797 * xfns.c (Fx_window_property): Likewise.
3798 * xselect.c: Include <limits.h>.
3799 (x_own_selection, selection_data_to_lisp_data):
3800 Use INTEGER_TO_CONS.
3801 (x_handle_selection_request, x_handle_selection_clear)
3802 (x_get_foreign_selection, Fx_disown_selection_internal)
3803 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3804 (lisp_data_to_selection_data): Use cons_to_unsigned.
3805 (x_fill_property_data): Use cons_to_signed.
3806 Report values out of range.
3807
d1f3d2af
PE
3808 Check for buffer and string overflow more precisely.
3809 * buffer.h (BUF_BYTES_MAX): New macro.
3810 * lisp.h (STRING_BYTES_MAX): New macro.
3811 * alloc.c (Fmake_string):
3812 * character.c (string_escape_byte8):
3813 * coding.c (coding_alloc_by_realloc):
3814 * doprnt.c (doprnt):
3815 * editfns.c (Fformat):
3816 * eval.c (verror):
3817 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3818 since they may not be the same number.
3819 * editfns.c (Finsert_char):
3820 * fileio.c (Finsert_file_contents):
3821 Likewise for BUF_BYTES_MAX.
3822
dd52fcea
PE
3823 * image.c: Use ptrdiff_t, not int, for sizes.
3824 (slurp_file): Switch from int to ptrdiff_t.
3825 All uses changed.
3826 (slurp_file): Check that file size fits in both size_t (for
3827 malloc) and ptrdiff_t (for sanity and safety).
3828
7f9bbdbb
PE
3829 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3830 if b->modtime has its maximal value.
3831
dfe18f82
PE
3832 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3833
84acfcf0
PE
3834 Don't assume time_t can fit into int.
3835 * buffer.h (struct buffer.modtime): Now time_t, not int.
3836 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3837 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3838
ccd9a01a
PE
3839 Minor fixes for signed vs unsigned integers.
3840 * character.h (MAYBE_UNIFY_CHAR):
3841 * charset.c (maybe_unify_char):
3842 * keyboard.c (read_char, reorder_modifiers):
3843 XINT -> XFASTINT, since the integer must be nonnegative.
3844 * ftfont.c (ftfont_spec_pattern):
3845 * keymap.c (access_keymap, silly_event_symbol_error):
3846 XUINT -> XFASTINT, since the integer must be nonnegative.
3847 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3848 since it makes no difference and we prefer signed.
3849 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3850 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3851 nonnegative.
3852
d6d100dd
SM
38532011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3854
3855 * window.h (Fwindow_frame): Declare.
3856
2b6148e4
PE
38572011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3858
3859 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3860 (SPARE_MEMORY): Always define.
3861 (LARGE_REQUEST): Remove.
3862 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3863
f230ecc9
MR
38642011-06-06 Martin Rudalics <rudalics@gmx.at>
3865
727e958e
MR
3866 * lisp.h: Move EXFUNS for Fframe_root_window,
3867 Fframe_first_window and Fset_frame_selected_window to window.h.
3868
3869 * window.h: Move EXFUNS for Fframe_root_window,
3870 Fframe_first_window and Fset_frame_selected_window here from
3871 lisp.h.
3872
3873 * frame.c (Fwindow_frame, Fframe_first_window)
3874 (Fframe_root_window, Fframe_selected_window)
3875 (Fset_frame_selected_window): Move to window.c.
3876 (Factive_minibuffer_window): Move to minibuf.c.
3877 (Fother_visible_frames_p): New function.
3878
3879 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3880
f230ecc9
MR
3881 * window.c (decode_window, decode_any_window): Move up in code.
3882 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3883 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3884 (Fwindow_buffer): Move up and rewrite doc-string.
3885 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3886 (Fwindow_prev): New functions.
727e958e
MR
3887 (Fwindow_frame): Move here from frame.c. Accept any window as
3888 argument.
3889 (Fframe_root_window, Fframe_first_window)
3890 (Fframe_selected_window): Move here from frame.c. Accept frame
3891 or arbitrary window as argument. Update doc-strings.
3892 (Fminibuffer_window): Move up in code.
3893 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3894 (Fset_frame_selected_window): Move here from frame.c.
3895 Marginal rewrite.
727e958e
MR
3896 (Fselected_window, select_window, Fselect_window): Move up in
3897 code. Minor doc-string fixes.
f230ecc9 3898
4d09bcf6
PE
38992011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3900
3901 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3902 Do not assume that spare memory exists; that assumption is valid
3903 only if SYSTEM_MALLOC.
3904 (LARGE_REQUEST): New macro, so that the issue of large requests
3905 is separated from the issue of spare memory.
3906
810928a2
AS
39072011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3908
172418ad
AS
3909 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3910 format. (Bug#8806)
3911
43f862f7
AS
3912 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3913
810928a2
AS
3914 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3915 before statements.
3916
a059fe24
JD
39172011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3918
3919 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3920
3921 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3922
3923 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3924 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3925
989bf368
JB
39262011-06-05 Juanma Barranquero <lekktu@gmail.com>
3927
3928 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3929
4b80f674
CY
39302011-06-04 Chong Yidong <cyd@stupidchicken.com>
3931
3932 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3933 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3934 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3935 New error handlers.
4b80f674
CY
3936 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3937 Obey Vx_select_enable_clipboard_manager. Catch errors in
3938 x_clipboard_manager_save (Bug#8779).
3939 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3940 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3941
99a33b77 39422011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3943
3944 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3945
99a33b77 39462011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3947
3948 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3949 in the current matrix if keep_current_p is non-zero.
3950
8264569d
EZ
39512011-06-04 Eli Zaretskii <eliz@gnu.org>
3952
3953 * bidi.c (bidi_level_of_next_char): Fix last change.
3954
57f97249
EZ
39552011-06-03 Eli Zaretskii <eliz@gnu.org>
3956
fec2107c 3957 Support bidi reordering of text covered by display properties.
57f97249 3958
fec2107c
EZ
3959 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3960 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3961 (bidi_cache_search, bidi_cache_iterator_state)
3962 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3963 (bidi_level_of_next_char, bidi_move_to_visually_next):
3964 Support character positions inside a run of characters covered by a
fec2107c
EZ
3965 display string.
3966 (bidi_paragraph_init, bidi_resolve_explicit_1)
3967 (bidi_level_of_next_char): Call bidi_fetch_char and
3968 bidi_fetch_char_advance instead of FETCH_CHAR and
3969 FETCH_CHAR_ADVANCE.
3970 (bidi_init_it): Initialize new members.
3971 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3972 definitions.
3973 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3974 instead of using explicit *_CHAR codes.
d6d100dd
SM
3975 (bidi_resolve_explicit, bidi_resolve_weak):
3976 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
3977 bidirectional text is supported only in multibyte buffers.
3978 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3979 it to initialize the frame_window_p member of struct bidi_it.
3980 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3981 (bidi_resolve_explicit, bidi_resolve_weak)
3982 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3983 bidi_it->nchars is non-positive.
3984 (bidi_level_of_next_char): Don't try to lookup the cache for the
3985 next/previous character if nothing is cached there yet, or if we
3986 were just reseat()'ed to a new position.
c40e2fb2 3987
0e14fe90
EZ
3988 * xdisp.c (set_cursor_from_row): Set start and stop points
3989 according to the row's direction when priming the loop that looks
3990 for the glyph on which to display cursor.
3991 (single_display_spec_intangible_p): Function deleted.
3992 (display_prop_intangible_p): Reimplement to call
3993 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
3994 Accept 3 additional arguments needed by handle_display_spec.
3995 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
3996 values: lists, `(when COND...)' forms, etc.
3997 (single_display_spec_string_p): Support property values that are
3998 lists with the argument STRING its top-level element.
3999 (display_prop_string_p): Fix the condition for processing a
4000 property that is a list to be consistent with handle_display_spec.
fec2107c 4001 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4002 last portion of handle_display_prop.
4003 (compute_display_string_pos): Accept additional argument
4004 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4005 value of a `display' property is a "replacing spec".
4006 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4007 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4008 the display property, but just return a value indicating whether
4009 the display property will replace the characters it covers.
4010 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4011 frame_window_p members of struct bidi_it.
d6d100dd
SM
4012 (compute_display_string_pos, compute_display_string_end):
4013 New functions.
fec2107c
EZ
4014 (push_it): Accept second argument POSITION, where pop_it should
4015 jump to continue iteration.
4016 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4017
fec2107c
EZ
4018 * keyboard.c (adjust_point_for_property): Adjust the call to
4019 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4020
4021 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4022 (bidi_init_it): Update prototypes.
4023 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4024 (compute_display_string_pos, compute_display_string_end):
4025 Declare prototypes.
fec2107c
EZ
4026 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4027 EMACS_INT.
fc6f18ce 4028
40087514 40292011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4030
57f53182
PE
4031 Malloc failure behavior now depends on size of allocation.
4032 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4033 * lisp.h: Change signatures accordingly.
4034 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4035 All callers changed. (Bug#8762)
4036
4037 * gnutls.c: Use Emacs's memory allocators.
4038 Without this change, the gnutls library would invoke malloc etc.
4039 directly, which causes problems on non-SYNC_INPUT hosts, and which
4040 runs afoul of improving memory_full behavior. (Bug#8761)
4041 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4042 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4043 xfree instead of the default malloc, realloc, free.
4044 (Fgnutls_boot): No need to check for memory allocation failure,
4045 since xmalloc does that for us.
4046
ac32cd99 4047 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4048 * category.c (hash_get_category_set):
4049 * ccl.c (ccl_driver):
4050 * charset.c (Fdefine_charset_internal):
4051 * charset.h (struct charset.hash_index):
4052 * composite.c (get_composition_id, gstring_lookup_cache)
4053 (composition_gstring_put_cache):
4054 * composite.h (struct composition.hash_index):
4055 * dispextern.h (struct image.hash):
4056 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4057 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4058 (hashfn_equal, hashfn_user_defined, make_hash_table)
4059 (maybe_resize_hash_table, hash_lookup, hash_put)
4060 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4061 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4062 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4063 * image.c (make_image, search_image_cache, lookup_image)
4064 (xpm_put_color_table_h):
4065 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4066 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4067 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4068 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4069 * alloc.c (allocate_vectorlike):
4070 Check for overflow in vector size calculations.
4071 * ccl.c (ccl_driver):
4072 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4073 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4074 need to be updated by these changes.
40087514
PE
4075 * fns.c (make_hash_table, maybe_resize_hash_table):
4076 Check for integer overflow with large hash tables.
0de4bb68
PE
4077 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4078 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4079 (SXHASH_REDUCE): New macro.
4080 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4081 Use it instead of discarding useful hash info with large hash values.
4082 (sxhash_float): New function.
4083 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4084 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4085 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4086 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4087 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4088 Adjust signatures to match updated version of code.
4089 (consing_since_gc): Now EMACS_INT, since a single hash table can
4090 use more than INT_MAX bytes.
4091
698d32e2
DN
40922011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4093
4094 Make it possible to build with GCC-4.6+ -O2 -flto.
4095
4096 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4097
fd6fa53f
SM
40982011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4099
4100 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4101 Call minibuffer-inactive-mode.
4102
864db017
JB
41032011-05-31 Juanma Barranquero <lekktu@gmail.com>
4104
4105 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4106 Update dependencies.
4107
2ad0baf4
DN
41082011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4109
4110 * data.c (init_data): Remove code for UTS, this system is not
4111 supported anymore.
4112
4fcc2638
DN
41132011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4114
4115 Don't force ./temacs to start in terminal mode.
4116
4117 * frame.c (make_initial_frame): Initialize faces in all cases, not
4118 only when CANNOT_DUMP is defined.
4119 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4120
c56e0fd5
DN
41212011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4122
4123 * dispnew.c (add_window_display_history): Use const for the string
4124 pointer. Remove declaration, not needed.
4125
333d54da 41262011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4127
55d4c1b2 4128 Use 'inline', not 'INLINE'.
333d54da 4129 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4130 * alloc.c, fontset.c (INLINE): Remove.
4131 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4132 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4133 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4134 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4135 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4136
738db178
DN
41372011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4138
4139 Make it possible to run ./temacs.
4140
4141 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4142 syms_of_callproc does the same thing. Remove test for
4143 "initialized", do it in the caller.
4144 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4145
620c53a6
SM
41462011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4147
4148 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4149 (read_minibuf): Use get_minibuffer.
4150 (syms_of_minibuf): Use DEFSYM.
4151 (Qmetadata): New var.
4152 * data.c (Qbuffer): Don't make it static.
4153 (syms_of_data): Use DEFSYM.
4154
e003a292
PE
41552011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4156
4157 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4158 (CCL_CODE_MIN): New macro.
4159
ed008a6d
PE
41602011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4161
3687c2ef
PE
4162 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4163
ed008a6d
PE
4164 * eval.c (Qdebug): Now static.
4165 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4166 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4167 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4168
d66c4c7c
CY
41692011-05-29 Chong Yidong <cyd@stupidchicken.com>
4170
4171 * image.c: Various fixes to ImageMagick code comments.
4172 (Fimagemagick_types): Doc fix.
4173
5fbc2025
PE
41742011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4175
0196f88a
PE
4176 Minor fixes prompted by GCC 4.6.0 warnings.
4177
4178 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4179
5fbc2025
PE
4180 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4181 (x_clipboard_manager_save_all): Move extern decl to ...
4182 * xterm.h: ... here, so that it can be checked for consistency.
4183
1dd3c2d9
CY
41842011-05-29 Chong Yidong <cyd@stupidchicken.com>
4185
4186 * xselect.c (x_clipboard_manager_save_frame)
4187 (x_clipboard_manager_save_all): New functions.
4188 (Fx_clipboard_manager_save): Lisp function deleted.
4189
4190 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4191 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4192
4193 * xterm.h: Update prototype.
4194
5ba6571d
WX
41952011-05-28 William Xu <william.xwl@gmail.com>
4196
4197 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4198 exiting (Bug#8239).
4199
3eaff834
JM
42002011-05-28 Jim Meyering <meyering@redhat.com>
4201
e1900994 4202 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4203 * fns.c (to_uchar): Define.
4204 (crypto_hash_function): Use it to convert some newly-signed
4205 variables to unsigned, to avoid sign-extension bugs. For example,
4206 without this change, (md5 "truc") would evaluate to
4207 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4208 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4209 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4210
0f6990a7
PE
42112011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4212
4213 Integer overflow fixes.
c8a9ca5a 4214
08686060
PE
4215 * dbusbind.c: Serial number integer overflow fixes.
4216 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4217 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4218 to hold a serial number that is too large for a fixnum.
4219 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4220 Check for serial numbers out of range. Decode any serial number
59568bf0 4221 that was so large that it became a float. (Bug#8722)
08686060 4222
2d1fc3c7
PE
4223 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4224 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4225 Use XFASTINT rather than XUINT when numbers are nonnegative.
4226 (xd_append_arg, Fdbus_method_return_internal):
4227 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4228 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4229 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4230 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4231 (Bug#8722)
2d1fc3c7 4232
c8a9ca5a
PE
4233 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4234
519e1d69
PE
4235 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4236
30569699
PE
4237 ccl: add integer overflow checks
4238 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4239 (IN_INT_RANGE): New macros.
4240 (ccl_driver): Use them to check for integer overflow when
4241 decoding a CCL program. Many of the new checks are whether XINT (x)
4242 fits in int; it doesn't always, on 64-bit hosts. The new version
4243 doesn't catch all possible integer overflows, but it's an
847044ea 4244 improvement. (Bug#8719)
30569699 4245
c11285dc
PE
4246 * alloc.c (make_event_array): Use XINT, not XUINT.
4247 There's no need for unsigned here.
4248
fdccd48e
PE
4249 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4250 This follows up to the 2011-05-06 change that substituted uintptr_t
4251 for EMACS_INT. This case wasn't caught back then.
4252
37910ab2
PE
4253 Rework Fformat to avoid integer overflow issues.
4254 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4255 now (part of C89). Include <verify.h>.
4256 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4257 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4258 (Fformat): Avoid the prepass trying to compute sizes; it was only
4259 approximate and thus did not catch overflow reliably. Instead, walk
4260 through the format just once, formatting and computing sizes as we go,
4261 checking for integer overflow at every step, and allocating a larger
4262 buffer as needed. Keep track separately whether the format is
4263 multibyte. Keep only the most-recently calculated precision, rather
4264 than them all. Record whether each argument has been converted to
4265 string. Use EMACS_INT, not int, for byte and char and arg counts.
4266 Support field widths and precisions larger than INT_MAX. Avoid
4267 sprintf's undefined behavior with conversion specifications such as %#d
4268 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4269 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4270 formatting out-of-range floating point numbers with int
9173deec 4271 formats. (Bug#8668)
37910ab2 4272
2e6578fb
PE
4273 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4274
0ae6bdee
PE
4275 * data.c: Avoid integer truncation in expressions involving floats.
4276 * data.c: Include <intprops.h>.
4277 (arith_driver): When there's an integer overflow in an expression
4278 involving floating point, convert the integers to floating point
4279 so that the resulting value does not suffer from catastrophic
4280 integer truncation. For example, on a 64-bit host (* 4
4281 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4282 Do not rely on undefined behavior after integer overflow.
4283
de883a70
PE
4284 merge count_size_as_multibyte, parse_str_to_multibyte
4285 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4286 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4287 Check for integer overflow.
4288 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4289 since it's now a duplicate of the other. This is more of
4290 a character than a buffer op, so better that it's in character.c.
4291 * fns.c, print.c: Adjust to above changes.
4292
2ff916cb
PE
42932011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4294
4295 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4296
f1b54466
PE
42972011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4298
fb1ac845
PE
4299 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4300 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4301 (x_clipboard_manager_save): Now static.
4302 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4303
f1b54466
PE
4304 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4305 (crypto_hash_function): Now static.
4306 Fix pointer signedness problems. Avoid unnecessary initializations.
4307
a9f737ee
CY
43082011-05-27 Chong Yidong <cyd@stupidchicken.com>
4309
4310 * termhooks.h (Vselection_alist): Make it terminal-local.
4311
4312 * terminal.c (create_terminal): Initialize it.
4313
4314 * xselect.c: Support for clipboard managers.
4315 (Vselection_alist): Move to termhooks.h as terminal-local var.
4316 (LOCAL_SELECTION): New macro.
4317 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4318 (symbol_to_x_atom): Remove gratuitous arg.
4319 (x_handle_selection_request, lisp_data_to_selection_data)
4320 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4321 (x_own_selection, x_get_local_selection, x_convert_selection):
4322 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4323 (some_frame_on_display): Delete unused function.
4324 (Fx_own_selection_internal, Fx_get_selection_internal)
4325 (Fx_disown_selection_internal, Fx_selection_owner_p)
4326 (Fx_selection_exists_p): New optional frame arg.
4327 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4328 (x_handle_selection_clear): Don't treat other terminals with the
4329 same keyboard specially. Use the terminal-local Vselection_alist.
4330 (x_clear_frame_selections): Use Frun_hook_with_args.
4331
4332 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4333
4334 * xterm.h: Add support for those atoms.
4335
e067f0c1
CY
43362011-05-26 Chong Yidong <cyd@stupidchicken.com>
4337
4338 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4339 (converted_selections, conversion_fail_tag): New global variables.
4340 (x_selection_request_lisp_error): Free the above.
4341 (x_get_local_selection): Remove unnecessary code.
4342 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4343 of converted selections stored in converted_selections.
4344 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4345 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4346 (x_convert_selection): New function.
4347 (x_handle_selection_event): Simplify.
4348 (x_get_foreign_selection): Don't ignore incoming requests while
4349 waiting for an answer; this will fail when we implement
4350 SAVE_TARGETS, and seems unnecessary anyway.
4351 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4352 (Vx_sent_selection_functions): Doc fix.
4353
0f4aebc0
LL
43542011-05-26 Leo Liu <sdl.web@gmail.com>
4355
4356 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4357
e61124cd
YM
43582011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4359
4360 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4361
4362 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4363 for fringe update if it has periodic bitmap.
ac389d0c 4364 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4365 and fringe_bitmap_periodic_p.
4366
4367 * fringe.c (get_fringe_bitmap_data): New function.
4368 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4369 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4370 row. Mark glyph row for fringe update if periodicity changed.
4371
4372 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4373 for fringe update unless it has periodic bitmap.
4374
f16d9837
KH
43752011-05-25 Kenichi Handa <handa@m17n.org>
4376
4377 * xdisp.c (get_next_display_element): Set correct it->face_id for
4378 a static composition.
4379
e1b90ef6
LL
43802011-05-24 Leo Liu <sdl.web@gmail.com>
4381
4382 * deps.mk (fns.o):
4383 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4384
4385 * fns.c (crypto_hash_function, Fsha1): New function.
4386 (Fmd5): Use crypto_hash_function.
4387 (syms_of_fns): Add Ssha1.
4388
7400048f
PE
43892011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4390
4391 * gnutls.c: Remove unused macros.
4392 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4393 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4394 Remove macros that are defined and never used.
4395 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4396
abb71cf4
CY
43972011-05-22 Chong Yidong <cyd@stupidchicken.com>
4398
4399 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4400 (Fx_get_selection_internal): Minor cleanup.
4401 (Fx_own_selection_internal): Rename arguments for consistency with
4402 select.el.
4403
6307db39
PE
44042011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4405
4406 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4407
f3d4e0a4
CY
44082011-05-22 Chong Yidong <cyd@stupidchicken.com>
4409
4410 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4411
4d8ade89
YM
44122011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4413
4414 * dispnew.c (scrolling_window): Don't exclude the case that the
4415 last enabled row in the desired matrix touches the bottom boundary.
4416
32078c8d
GM
44172011-05-21 Glenn Morris <rgm@gnu.org>
4418
4419 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4420 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4421 and add some more files.
32078c8d 4422
7285dc67
EZ
44232011-05-20 Eli Zaretskii <eliz@gnu.org>
4424
4425 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4426 report_file_error introduced by the change from 2011-05-07.
4427
89d1bd22
PE
44282011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4429
4430 * systime.h (Time): Define only if emacs is defined.
4431 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4432 where the include path doesn't have X11/X.h by default. See
4433 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4434
e23640bb 44352011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4436
4437 * composite.c (find_automatic_composition): Fix previous change.
4438
b9704ad9
GM
44392011-05-20 Glenn Morris <rgm@gnu.org>
4440
4441 * lisp.mk: New file, split from Makefile.in.
4442 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4443 (shortlisp): Remove.
4444 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4445
4a720484
GM
44462011-05-19 Glenn Morris <rgm@gnu.org>
4447
4448 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4449 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4450 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4451 (lisp): Set the order to that of loadup.el.
4452 (shortlisp): Make it a copy of $lisp.
4453 (SOME_MACHINE_LISP): Remove.
4454 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4455 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4456
a28d4396
KH
44572011-05-18 Kenichi Handa <handa@m17n.org>
4458
4459 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4460 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4461 (find_automatic_composition): Mostly rewrite for efficiency.
4462
a2b1fa8e
JB
44632011-05-18 Juanma Barranquero <lekktu@gmail.com>
4464
4465 * makefile.w32-in: Update dependencies.
4466
8e1f5610
CS
44672011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4468
4469 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4470 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4471
7025ee00 44722011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4473
cdfa6eab
PE
4474 Fix some integer overflow issues, such as string length overflow.
4475
06d6db33
PE
4476 * insdel.c (count_size_as_multibyte): Check for string overflow.
4477
2b4560a8
PE
4478 * character.c (lisp_string_width): Check for string overflow.
4479 Use EMACS_INT, not int, for string indexes and lengths; in
4480 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4481 the resulting string length overflows an EMACS_INT; instead,
4482 report a string overflow if no precision given. When checking for
4483 precision exhaustion, use a check that cannot possibly have
4484 integer overflow. (Bug#8675)
4485 * character.h (lisp_string_width): Adjust to new signature.
4486
cb93f9be
PE
4487 * alloc.c (string_overflow): New function.
4488 (Fmake_string): Use it. This doesn't change behavior, but saves
4489 a few bytes and will simplify future changes.
4490 * character.c (string_escape_byte8): Likewise.
4491 * lisp.h (string_overflow): New decl.
4492
1a1f3366
PE
4493 Fixups, following up to the user-interface timestamp change.
4494 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4495 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4496 * msdos.c (mouse_get_pos): Likewise.
4497 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4498 * w32gui.h (Time): Define by including "systime.h" rather than by
4499 declaring it ourselves. (Bug#8664)
4500
d4e3e4d3
PE
4501 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4502 * image.c (clear_image_cache): Likewise.
4503
f6a24d19
PE
4504 * term.c (term_mouse_position): Don't assume time_t wraparound.
4505
08dc5ae6
PE
4506 Be more systematic about user-interface timestamps.
4507 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4508 and sometimes 'EMACS_UINT', to represent these timestamps.
4509 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4510 This makes the code easier to follow, and makes it easier to catch
4511 integer overflow bugs such as Bug#8664.
4512 * frame.c (Fmouse_position, Fmouse_pixel_position):
4513 Use Time, not unsigned long, for user-interface timestamps.
4514 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4515 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4516 * keyboard.h (last_event_timestamp): Likewise.
4517 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4518 * menu.h (xmenu_show): Likewise.
4519 * term.c (term_mouse_position): Likewise.
4520 * termhooks.h (struct input_event.timestamp): Likewise.
4521 (struct terminal.mouse_position_hook): Likewise.
4522 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4523 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4524 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4525 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4526 what it was before.
4527 * menu.h, termhooks.h: Include "systime.h", for Time.
4528
8e55734a
PE
4529 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4530 Don't assume that the difference between two unsigned long values
4531 can fit into an integer. At this point, we know button_down_time
4532 <= event->timestamp, so the difference must be nonnegative, so
4533 there's no need to cast the result if double-click-time is
4534 nonnegative, as it should be; check that it's nonnegative, just in
4535 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4536 apart (about 25 days). (Bug#8664)
8e55734a 4537
841f1b75 4538 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4539 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4540
3e26f69c
PE
4541 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4542 that always fit in int. Use a sentinel instead of a counter, to
4543 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4544 * frame.h (struct frame): Use int for menu_bar_items_used
4545 instead of EMACS_INT, since it always fits in int.
3e26f69c 4546
5cc152c0
PE
4547 * menu.c (grow_menu_items): Check for int overflow.
4548
d89eb65e
PE
4549 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4550
5235bd3e
PE
4551 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4552 Before, the code was not consistent. These values cannot exceed
4553 2**31 - 1 so there's no need to make them unsigned.
4554 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4555 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4556 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4557 as modifiers.
4558 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4559
bc827e23
PE
4560 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4561 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4562 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4563 presumably because the widths might not match.
4564
78eb494e
PE
4565 * window.c (size_window): Avoid needless test at loop start.
4566
04f2d78b
CB
45672011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4568
4569 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4570
d2fc7e3d 45712011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4572
4573 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4574
d2fc7e3d 45752011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4576
4577 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4578 `width' to `bar_area_x' and `bar_area_width', respectively.
4579 (x_scroll_run): Take account of fringe background extension.
4580
04f2d78b
CB
4581 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4582 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4583 `bar_area_width', respectively.
4584 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4585 background extension.
4586
79b70037
GM
45872011-05-10 Jim Meyering <meyering@redhat.com>
4588
4589 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4590
2f142cc5
JB
45912011-05-10 Juanma Barranquero <lekktu@gmail.com>
4592
4593 * image.c (Finit_image_library): Return t for built-in image types,
4594 like pbm and xbm. (Bug#8640)
4595
57679c86
AS
45962011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4597
4598 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4599
888c9e86
EZ
46002011-05-07 Eli Zaretskii <eliz@gnu.org>
4601
b0512a1d
EZ
4602 * w32console.c (Fset_screen_color): Doc fix.
4603 (Fget_screen_color): New function.
4604 (syms_of_ntterm): Defsubr it.
4605
7285dc67
EZ
4606 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4607 unlink the temporary file if Fcall_process didn't create it in the
4608 first place.
4609 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4610 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4611 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4612 cue to call_process_cleanup not to close that handle.
4613
4d3fcc8e
BK
46142011-05-07 Ben Key <bkey76@gmail.com>
4615
4616 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4617 one of two shell specific rules, either bootstrap-temacs-CMD or
4618 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4619 to the previous implementation of the bootstrap-temacs rule.
4620 The bootstrap-temacs-CMD rule is similar to the previous
4621 implementation of the bootstrap-temacs rule except that it
4622 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4623 variable.
4624
4625 These changes, along with some changes to nt/configure.bat,
4626 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4627 earlier fix to add support for --cflags and --ldflags options
4628 that include quotes so that it works whether make uses cmd or
4629 sh as the shell.
4630
b4289b64
MA
46312011-05-06 Michael Albinus <michael.albinus@gmx.de>
4632
4633 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4634 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4635 is a constant.
4636 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4637 a string. Handle both cases.
4638 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4639 (Fdbus_register_method): Use Qinvalid_function.
4640
af4c0e28
JB
46412011-05-06 Juanma Barranquero <lekktu@gmail.com>
4642
4643 * makefile.w32-in: Update dependencies.
4644 (LISP_H): Add inttypes.h and stdin.h.
4645 (PROCESS_H): Add unistd.h.
4646
c51453d9
EZ
46472011-05-06 Eli Zaretskii <eliz@gnu.org>
4648
4649 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4650 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4651
8ff0ac3c 46522011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4653
4c4b566b
PE
4654 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4655
aab2b9b5
PE
4656 * term.c (vfatal): Remove stray call to va_end.
4657 It's not needed and the C Standard doesn't allow it here anyway.
4658
c378da0b
PE
4659 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4660 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4661
288b08c7
PE
4662 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4663 bytes.
4664
e3601888
PE
4665 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4666
db6c0e74
PE
4667 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4668
dd5963ea
PE
4669 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4670
88c9450f
PE
4671 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4672
2f9442b8
PE
4673 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4674
c032b5f8
PE
4675 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4676 * charset.c (Fdefine_charset_internal): Don't initialize
4677 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4678 32-bit int (Bug#8600).
a108c10b
PE
4679
4680 * lread.c (read_integer): Be more consistent with string-to-number.
4681 Use string_to_number to do the actual conversion; this avoids
4682 rounding errors and fixes some other screwups. Without this fix,
4683 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4684 (digit_to_number): Move earlier, for benefit of read_integer.
4685 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4686 not a digit in any supported base. (Bug#8602)
a108c10b 4687
ad5f9eea
PE
4688 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4689
aec1708a
PE
4690 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4691 to match comment at start of function. This also removes a
4692 GCC warning about overflow in a 32+64-bit port.
4693
47be4ab5
PE
4694 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4695
371cac43
PE
4696 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4697 Reported by Stefan Monnier in
4698 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4699 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4700 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4701
d01a7826
PE
4702 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4703 (EMACS_UINTPTR): Likewise, with uintptr_t.
4704
7fd47d5c
PE
4705 * lisp.h: Prefer 64-bit EMACS_INT if available.
4706 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4707 on 32-bit hosts that have 64-bit int, so that they can access
4708 large files.
122b0c86
PE
4709 However, temporarily disable this change unless the temporary
4710 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4711
8727937b
PE
4712 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4713
8ac068ac
PE
4714 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4715 This removes an assumption that EMACS_INT and long are the same
4716 width as pointers. The assumption is true for Emacs porting targets
4717 now, but we want to make other targets possible.
4718 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4719 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4720 In the rest of the code, change types of integers that hold casted
4721 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4722 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4723 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4724 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4725 No need to cast type when ORing.
4726 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4727 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4728 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4729 assume EMACS_INT is the same width as char *.
4730 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4731 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4732 Remove no-longer-needed casts.
4733 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4734 (xg_tool_bar_help_callback, xg_make_tool_item):
4735 Use EMACS_INTPTR to hold an integer
4736 that will be cast to void *; this can avoid a GCC warning
4737 if EMACS_INT is not the same width as void *.
4738 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4739 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4740 (current_message_1, set_message_1):
4741 Use a local to convert to proper width without a cast.
4742 * xmenu.c (dialog_selection_callback): Likewise.
4743
ede49d71
PE
4744 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4745 Also, don't assume VALBITS / RAND_BITS is less than 5,
4746 and don't rely on undefined behavior when shifting a 1 left into
4747 the sign bit.
4748 * lisp.h (get_random): Change signature to match.
4749
2f30ecd0
PE
4750 * lread.c (hash_string): Use size_t, not int, for hash computation.
4751 Normally we prefer signed values; but hashing is special, because
4752 it's better to use unsigned division on hash table sizes so that
4753 the remainder is nonnegative. Also, size_t is the natural width
4754 for hashing into memory. The previous code used 'int', which doesn't
4755 retain enough info to hash well into very large tables.
4756 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4757
2a866e7b
PE
4758 * dbusbind.c: Don't possibly lose pointer info when converting.
4759 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4760 Use XPNTR rather than XHASH, so that the high-order bits of
4761 the pointer aren't lost when converting through void *.
4762
51639eac
PE
4763 * eval.c (Fautoload): Don't double-shift a pointer.
4764
92394119
PE
4765 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4766
dbdb9a7c
JB
47672011-05-06 Juanma Barranquero <lekktu@gmail.com>
4768
4769 * gnutls.c (DEF_GNUTLS_FN):
4770 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4771
db7a0b4f
AS
47722011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4773
4774 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4775 marker. (Bug#8610)
4776
f7ff1b0f 47772011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4778
4779 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4780 New version that can reserve upto 2GB of heap space.
4781
f7ff1b0f 47822011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4783
4784 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4785
639c109b
TZ
47862011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4787
4788 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4789 `gnutls_certificate_set_x509_key_file'.
4790
d2127135
JB
47912011-05-05 Juanma Barranquero <lekktu@gmail.com>
4792
4793 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4794 Update dependencies.
4795
e968f4f3
JB
47962011-05-04 Juanma Barranquero <lekktu@gmail.com>
4797
4798 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4799 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4800 Remove unused parameter `fildes'.
4801 * process.c (read_process_output, send_process): Don't pass it.
4802
84d358f0
JB
48032011-05-04 Juanma Barranquero <lekktu@gmail.com>
4804
4805 Fix previous change: the library cache is defined in w32.c.
4806 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4807 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4808
0898ca10
JB
48092011-05-04 Juanma Barranquero <lekktu@gmail.com>
4810
4811 Implement dynamic loading of GnuTLS on Windows.
4812
4813 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4814 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4815 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4816 Declare.
4817
4818 * gnutls.c (Qgnutls_dll): Define.
4819 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4820 (gnutls_*): Declare function pointers.
4821 (init_gnutls_functions): New function to initialize function pointers.
4822 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4823 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4824 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4825 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4826 (emacs_gnutls_write, emacs_gnutls_read)
4827 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4828 (Fgnutls_available_p): New function.
4829 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4830 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4831 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4832
4833 * image.c: Include w32.h.
4834 (Vimage_type_cache): Delete.
4835 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4836 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4837 (w32_delayed_load): Move to w32.c.
4838
4839 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4840
4841 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4842 (w32_delayed_load): Move from image.c. When loading a library, record
4843 its filename in the :loaded-from property of the library id.
4844 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4845 Initialize and staticpro them.
4846 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4847
4848 * process.c: Include lisp.h before w32.h, not after.
4849 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4850 instead of gnutls_record_check_pending.
4851
4852 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4853
ff4de4aa
TZ
48542011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4855
4856 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4857 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4858 as passed in.
4859
abe95abb
JD
48602011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4861
4862 * xterm.c (x_set_frame_alpha): Do not set property on anything
4863 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4864
e16e55d4
JB
48652011-05-02 Juanma Barranquero <lekktu@gmail.com>
4866
4867 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4868
bafcf6a5
JB
48692011-05-02 Juanma Barranquero <lekktu@gmail.com>
4870
4871 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4872 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4873 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4874 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4875 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4876 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4877 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4878 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4879 (Qgnutls_bootprop_callbacks_verify): Make static.
4880
e7a6747f
AS
48812011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4882
19ed11ba
AS
4883 * callproc.c: Indentation fixup.
4884
e7a6747f 4885 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4886 (wait_for_termination, interruptible_wait_for_termination):
4887 Move after wait_for_termination_1.
e7a6747f 4888
1ef14cb4
LMI
48892011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4890
4891 * sysdep.c (interruptible_wait_for_termination): New function
4892 which is like wait_for_termination, but allows keyboard
4893 interruptions.
4894
4895 * callproc.c (Fcall_process): Add (:file "file") as an option for
4896 the STDOUT buffer.
4897 (Fcall_process_region): Ditto.
4898
330d880c
EZ
48992011-04-30 Eli Zaretskii <eliz@gnu.org>
4900
8db90b73
EZ
4901 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4902 rather than `XVECTOR (FOO)->size'.
4903
330d880c
EZ
4904 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4905 inttypes.h, as a gnulib replacement is used if it not available in
4906 system headers.
4907
15cbd324
EZ
49082011-04-21 Eli Zaretskii <eliz@gnu.org>
4909
4910 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4911 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4912 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4913
4914 * coding.c (coding_alloc_by_realloc): Error out if destination
4915 will grow beyond MOST_POSITIVE_FIXNUM.
4916 (decode_coding_emacs_mule): Abort if there isn't enough place in
4917 charbuf for the composition carryover bytes. Reserve an extra
4918 space for up to 2 characters produced in a loop.
4919 (decode_coding_iso_2022): Abort if there isn't enough place in
4920 charbuf for the composition carryover bytes.
4921
49222011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4923
ae940cca
EZ
4924 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4925 aborting when %lld or %lll format is passed.
4926 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4927 %llo or %llx format is passed. (Bug#8545)
4928
03ab8921
EZ
4929 * window.c (window_scroll_line_based): Use a marker instead of
4930 simple variables to record original value of point. (Bug#7952)
4931
afda1437
EZ
4932 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4933 produced by %s or %c overflows available buffer space. (Bug#8545)
4934
f76dee0c
PE
49352011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4936
4937 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4938 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4939
fdc5744d
JB
49402011-04-28 Juanma Barranquero <lekktu@gmail.com>
4941
4942 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4943
638f053a
JB
49442011-04-28 Juanma Barranquero <lekktu@gmail.com>
4945
4946 * keyboard.c (Qdelayed_warnings_hook): Define.
4947 (command_loop_1): Run `delayed-warnings-hook'
4948 if Vdelayed_warnings_list is non-nil.
4949 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4950 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4951
d178f871
EZ
49522011-04-28 Eli Zaretskii <eliz@gnu.org>
4953
4954 * doprnt.c (doprnt): Don't return value smaller than the buffer
4955 size if the message was truncated. (Bug#8545).
4956
b124fd93
JB
49572011-04-28 Juanma Barranquero <lekktu@gmail.com>
4958
4959 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4960 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4961
e810457d
PE
49622011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4963
4964 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4965
ea51cceb
JB
49662011-04-27 Juanma Barranquero <lekktu@gmail.com>
4967
4968 * makefile.w32-in: Update dependencies.
4969
94dcfacf
EZ
49702011-04-27 Eli Zaretskii <eliz@gnu.org>
4971
4972 Improve `doprnt' and its usage. (Bug#8545)
4973 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4974 `format_end'. Remove support for %l as a conversion specifier.
4975 Don't use xrealloc. Improve diagnostics when the %l size modifier
4976 is used. Update the commentary.
4977
4978 * eval.c (verror): Simplify calculation of size_t.
4979
4980 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4981 messages.
4982
f61f41d7
PE
49832011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4984
4985 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4986 change.
4987
96fb4434
PE
49882011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4989
4990 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4991 This makes this file independent of the recent pseudovector change.
4992
671875da 49932011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 4994
69e9b5a3
PE
4995 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4996
b5f869a7 4997 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 4998 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 4999 Remove unused local.
c8926152 5000 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5001
841a1577 5002 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5003 GCC 4.6.0 optimizes based on type-based alias analysis.
5004 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5005 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5006 != &v->size, and therefore "v->size = 1; b->size = 2; return
5007 v->size;" must therefore return 1. This assumption is incorrect
5008 for Emacs, since it type-puns struct Lisp_Vector * with many other
5009 types. To fix this problem, this patch adds a new type struct
f904488f 5010 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5011 and pseudovectors, and helps optimizing compilers not get fooled
5012 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5013 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5014 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5015 the size member.
eab3844f
PE
5016 (XSETPVECTYPE): Rewrite in terms of new macro.
5017 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5018 This is a bit clearer, and further avoids the possibility of
5019 undesirable aliasing.
5020 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5021 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5022 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5023 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5024 (ASIZE): Now uses header.size rather than size.
5025 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5026 to avoid the hassle of writing XVECTOR (foo)->header.size.
5027 (struct vectorlike_header): New type.
eab3844f
PE
5028 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5029 object, to help avoid aliasing.
5030 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5031 (SUBRP): Likewise, since Lisp_Subr is a special case.
5032 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5033 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5034 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5035 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5036 changed to be "header.size" and "header.next".
5037 * buffer.h (struct buffer): Likewise.
5038 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5039 * frame.h (struct frame): Likewise.
5040 * process.h (struct Lisp_Process): Likewise.
5041 * termhooks.h (struct terminal): Likewise.
5042 * window.c (struct save_window_data, struct saved_window): Likewise.
5043 * window.h (struct window): Likewise.
5044 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5045 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5046 * buffer.c (init_buffer_once): Likewise.
5047 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5048 special case.
5049 * process.c (Fformat_network_address): Use local var for size,
5050 for brevity.
5051
0df1eac5
PE
5052 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5053
847ab9d1 5054 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5055 * data.c (atof): Remove decl; no longer used or needed.
5056 (digit_to_number): Move to lread.c.
5057 (Fstring_to_number): Use new string_to_number function, to be
5058 consistent with how the Lisp reader treats infinities and NaNs.
5059 Do not assume that floating-point numbers represent EMACS_INT
5060 without losing information; this is not true on most 64-bit hosts.
5061 Avoid double-rounding errors, by insisting on integers when
5062 parsing non-base-10 numbers, as the documentation specifies.
5063 * lisp.h (string_to_number): New decl, replacing ...
5064 (isfloat_string): Remove.
bc0a5c13 5065 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5066 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5067 appears to have been a coding error. Similarly, do not accept
5068 strings like +-1e0 as floating point numbers. Do not report
5069 overflow for integer overflows unless the base is not 10 which
5070 means we have no simple and reliable way to continue.
5071 Break out the floating-point parsing into a new
5072 function string_to_number, so that Fstring_to_number parses
5073 floating point numbers consistently with the Lisp reader.
04f2d78b 5074 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5075 (E_CHAR, EXP_INT): Remove, replacing with ...
5076 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5077 (string_to_number): New function, replacing isfloat_string.
5078 This function checks for valid syntax and produces the resulting
5079 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5080 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5081 so that overflow for non-base-10 numbers is reported only when
5082 there's no portable and simple way to convert to floating point.
452f4150 5083
67769ffc
PE
5084 * textprop.c (set_text_properties_1): Rewrite for clarity,
5085 and to avoid GCC warning about integer overflow.
5086
c20db43f
PE
5087 * intervals.h (struct interval): Use EMACS_INT for members
5088 where EMACS_UINT might cause problems. See
5089 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5090 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5091 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5092 All uses changed.
37aa2f85
PE
5093 (offset_intervals): Tell GCC not to worry about length overflow
5094 when negating a negative length.
c20db43f 5095
2538aa2f
PE
5096 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5097 (overrun_check_free): Likewise.
5098
f2d3008d
PE
5099 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5100 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5101 word size.
5102
ec8df744
PE
5103 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5104 (gnutls_make_error): Rename local to avoid shadowing.
5105 (gnutls_emacs_global_deinit): ifdef out; not used.
5106 (Fgnutls_boot): Use const for pointer to readonly storage.
5107 Comment out unused local. Fix pointer signedness problems.
5108
640ee02d
PE
5109 * lread.c (openp): Don't stuff size_t into an 'int'.
5110 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5111 about possible signed overflow.
5112
6048fb2a
PE
5113 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5114 (GDK_KEY_g): Don't define if already defined.
5115 (xg_prepare_tooltip): Avoid pointer signedness problem.
5116 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5117
fa3c87e1
PE
5118 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5119 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5120
2172544b
PE
5121 * xfns.c (Fx_window_property): Simplify a bit,
5122 to make a bit faster and to avoid GCC 4.6.0 warning.
5123 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5124
9b821a21
PE
5125 * fns.c (internal_equal): Don't assume size_t fits in int.
5126
3c616cfa
PE
5127 * alloc.c (compact_small_strings): Tighten assertion a little.
5128
c2982e87
PE
5129 Replace pEd with more-general pI, and fix some printf arg casts.
5130 * lisp.h (pI): New macro, generalizing old pEd macro to other
5131 conversion specifiers. For example, use "...%"pI"d..." rather
5132 than "...%"pEd"...".
5133 (pEd): Remove. All uses replaced with similar uses of pI.
5134 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5135 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5136 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5137 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5138 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5139 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5140 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5141 64-bit hosts.
5142 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5143 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5144 * print.c (safe_debug_print, print_object): Likewise.
5145 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5146 to int.
6f04d126
PE
5147 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5148 avoiding the 0 flag, which is not portable.
c2982e87
PE
5149 * process.c (Fmake_network_process): Use pI to avoid cast.
5150 * region-cache.c (pp_cache): Likewise.
5151 * xdisp.c (decode_mode_spec): Likewise.
5152 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5153 behavior on 64-bit hosts with printf arg.
6f04d126 5154 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5155 (x_stop_queuing_selection_requests): Likewise.
5156 (x_get_window_property): Don't truncate byte count to an 'int'
5157 when tracing.
0b432f21 5158
5e073ec7
PE
5159 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5160 here, since it parses constructs like leading '-' and spaces,
5161 which are not wanted; and it overflows with large numbers.
5162 Instead, simply match F[0-9]+, which is what is wanted anyway.
5163
36372bf9
PE
5164 * alloc.c: Remove unportable assumptions about struct layout.
5165 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5166 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5167 (allocate_vectorlike, make_pure_vector): Use the new macros,
5168 plus offsetof, to remove unportable assumptions about struct layout.
5169 These assumptions hold on all porting targets that I know of, but
5170 they are not guaranteed, they're easy to remove, and removing them
5171 makes further changes easier.
5172
0b432f21
PE
5173 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5174 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5175 (string_overrun_cookie): Now const. Use initializers that
5176 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5177 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5178 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5179 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5180 multiple of sizeof (EMACS_INT); it need not be, if
5181 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5182 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5183
895009e1
JB
51842011-04-26 Juanma Barranquero <lekktu@gmail.com>
5185
5186 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5187
6a7a1b0b
TZ
51882011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5189
5190 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5191 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5192 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5193
841a1577 51942011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5195
5196 * lisp.h (Qdebug): List symbol.
895009e1 5197 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5198 * keyboard.c (debug-on-event): New variable.
5199 (handle_user_signal): Break into debugger when debug-on-event
5200 matches the current signal symbol.
5201
f2d3ba6f
DN
52022011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5203
5204 * alloc.c (check_sblock, check_string_bytes)
5205 (check_string_free_list): Convert to standard C.
5206
42ce4c63
TZ
52072011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5208
5209 * w32.c (emacs_gnutls_push): Fix typo.
5210
825cd63c
EZ
52112011-04-25 Eli Zaretskii <eliz@gnu.org>
5212
fb11d64d
EZ
5213 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5214 "cast to pointer from integer of different size".
5215
825cd63c
EZ
5216 Improve doprnt and its use in verror. (Bug#8545)
5217 * doprnt.c (doprnt): Document the set of format control sequences
5218 supported by the function. Use SAFE_ALLOCA instead of always
5219 using `alloca'.
5220
5221 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5222 is one byte too soon. Don't use xrealloc; instead xfree and
5223 xmalloc anew.
5224
e061a11b
TZ
52252011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5226
5227 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5228 callbacks stage.
5229
5230 * gnutls.c: Renamed global_initialized to
5231 gnutls_global_initialized. Added internals for the
5232 :verify-hostname-error, :verify-error, and :verify-flags
5233 parameters of `gnutls-boot' and documented those parameters in the
5234 docstring. Start callback support.
9173deec
JB
5235 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5236 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5237 on error. Return error code.
e061a11b
TZ
5238 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5239 (emacs_gnutls_read): Likewise.
5240 (Fgnutls_boot): Return handshake error code.
5241 (emacs_gnutls_handle_error): New function.
5242 (wsaerror_to_errno): Likewise.
5243
5244 * w32.h (emacs_gnutls_pull): Add prototype.
5245 (emacs_gnutls_push): Likewise.
5246
5247 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5248 (emacs_gnutls_push): Likewise.
5249
52502011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5251
5252 * process.c (wait_reading_process_output): Check if GnuTLS
5253 buffered some data internally if no FDs are set for TLS
5254 connections.
5255
5256 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5257 (LIBS): Link to USER_LIBS.
5258 ($(BLD)/gnutls.$(0)): New target.
5259
fa6996bc
EZ
52602011-04-24 Eli Zaretskii <eliz@gnu.org>
5261
eb35682e
EZ
5262 * xdisp.c (handle_single_display_spec): Rename the
5263 display_replaced_before_p argument into display_replaced_p, to
5264 make it consistent with the commentary. Fix typos in the
5265 commentary.
5266
e2ad650c
EZ
5267 * textprop.c (syms_of_textprop): Remove dead code.
5268 (copy_text_properties): Delete obsolete commentary about an
5269 interface that was deleted long ago. Fix typos in the description
5270 of arguments.
5271
1b2de274
EZ
5272 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5273 to changes in oldXMenu/XMenu.h from 2011-04-16.
5274 <menu_help_message, prev_menu_help_message>: Constify.
5275 (IT_menu_make_room): menu->help_text is now `const char **';
5276 adjust.
5277
5278 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5279 to changes in oldXMenu/XMenu.h from 2011-04-16.
5280 (struct XMenu): Declare `help_text' `const char **'.
5281
5282 * xfaces.c <Qunspecified>: Make extern again.
5283
5284 * syntax.c: Include sys/types.h before including regex.h, as
5285 required by Posix.
5286
762b15be
EZ
5287 * doc.c (get_doc_string): Improve the format passed to `error'.
5288
5289 * doprnt.c (doprnt): Improve commentary.
5290
5291 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5292
5293 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5294 them with etags.
5295
f1052e5d
EZ
5296 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5297 changes in globals.h immediately force recompilation.
762b15be
EZ
5298 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5299 $(CURDIR)/s/ms-w32.h.
5300 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5301
fa6996bc
EZ
5302 * character.c (Fchar_direction): Function deleted.
5303 (syms_of_character): Don't defsubr it.
5304 <char-direction-table>: Deleted.
5305
e6c3da20
EZ
53062011-04-23 Eli Zaretskii <eliz@gnu.org>
5307
5308 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5309 * doprnt.c: Include limits.h.
5310 (SIZE_MAX): New macro.
04f2d78b
CB
5311 (doprnt): Return a size_t value. 2nd arg is now size_t.
5312 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5313 Improve overflow protection. Support `l' modifier for integer
5314 conversions. Support %l conversion. Don't assume an EMACS_INT
5315 argument for integer conversions and for %c.
5316
5317 * lisp.h (doprnt): Restore prototype.
5318
5319 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5320 $(SRC)/character.h.
5321
5322 * Makefile.in (base_obj): Add back doprnt.o.
5323
5324 * deps.mk (doprnt.o): Add back prerequisites.
5325 (callint.o): Depend on character.h.
5326
5327 * eval.c (internal_lisp_condition_case): Include the handler
5328 representation in the error message.
5329 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5330 when breaking from the loop.
5331
5332 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5333
5334 * callint.c (Fcall_interactively): When displaying error message
5335 about invalid control letter, pass the character's codepoint, not
5336 a pointer to its multibyte form. Improve display of the character
5337 in octal and display also its hex code.
5338
5339 * character.c (char_string): Use %x to display the (unsigned)
5340 codepoint of an invalid character, to avoid displaying a bogus
5341 negative value.
5342
5343 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5344 `error', not SYMBOL_NAME itself.
5345
5346 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5347 character arguments to `error'.
5348
5349 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5350 to `error' in error message about FINAL_CHAR argument. Make sure
5351 FINAL_CHAR is a character, and use %c when it is passed as
5352 argument to `error'.
5353
4ffd0d6b 53542011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5355
5356 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5357
5358 * w32.c: Include <time.h>.
5359 (sys_localtime): New function.
5360
4ffd0d6b 53612011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5362
5363 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5364
4ffd0d6b 5365 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5366
4ffd0d6b 53672011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5368
4ffd0d6b
GM
5369 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5370 zombies (Bug#8467).
aac0c6e3 5371
04c56954
EZ
53722011-04-19 Eli Zaretskii <eliz@gnu.org>
5373
5374 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5375 gl_state.e_property when gl_state.object is Qt.
5376
5377 * insdel.c (make_gap_larger): Remove limitation of buffer size
5378 to <= INT_MAX.
5379
16a43933
CY
53802011-04-18 Chong Yidong <cyd@stupidchicken.com>
5381
5382 * xdisp.c (lookup_glyphless_char_display)
5383 (produce_glyphless_glyph): Handle cons cell entry in
5384 glyphless-char-display.
5385 (Vglyphless_char_display): Document it.
5386
5387 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5388 glyphless-char-display.
5389
4581706e
CY
53902011-04-17 Chong Yidong <cyd@stupidchicken.com>
5391
5392 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5393
5394 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5395
5396 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5397 definition for no-X builds.
5398
4887c6e2 53992011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5400
fd35b6f9
PE
5401 Static checks with GCC 4.6.0 and non-default toolkits.
5402
5c1ccb01
PE
5403 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5404
006c5daa
PE
5405 * process.c (keyboard_bit_set): Define only if SIGIO.
5406 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5407 (send_process): Repair possible setjmp clobbering.
5408
efc736d3
PE
5409 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5410
4e2fe2e6
PE
5411 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5412
f97334a2
PE
5413 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5414
4e75f29d
PE
5415 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5416 Define only if needed.
5417
90efadd1
PE
5418 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5419 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5420 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5421
3c647824
PE
5422 * dispextern.h (struct redisplay_interface): Rename param
5423 to avoid shadowing.
e264f262 5424 * termhooks.h (struct terminal): Likewise.
761383f4 5425 * xterm.c (xembed_send_message): Likewise.
3c647824 5426
b58c5c4a
PE
5427 * insdel.c (make_gap_smaller): Define only if
5428 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5429
cad59032
PE
5430 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5431 it.
5432
c339dc2e
PE
5433 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5434 so that we aren't warned about unused symbols.
5435
91a3e27b
PE
5436 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5437
399c71d3 5438 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5439
8ffc96f5
PE
5440 * xfns.c (x_real_positions): Mark locals as initialized.
5441
eef9bc79
PE
5442 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5443
098db9dd
PE
5444 * xterm.c: Fix problems found by static analysis with other toolkits.
5445 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5446 (x_dispatch_event): Declare static if USE_GTK, and
5447 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5448 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5449 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5450 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5451 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5452
eb18f6cc
PE
5453 * xmenu.c (menu_help_callback): Pointer type fixes.
5454 Use const pointers when pointing at readonly data. Avoid pointer
5455 signedness clashes.
5456 (FALSE): Remove unused macro.
5457 (update_frame_menubar): Remove unused decl.
5458
1fe72bf8
PE
5459 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5460
60d9e1db
PE
5461 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5462 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5463 (single_menu_item): Rename local to avoid shadowing.
5464
39261c26
PE
5465 * keyboard.c (make_lispy_event): Remove unused local var.
5466
018c5e19
PE
5467 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5468 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5469
63d2b86e
PE
5470 * bitmaps: Change bitmaps from unsigned char back to the X11
5471 compatible char. Avoid the old compiler warnings about
5472 out-of-range initializers by using, for example, '\xab' rather
5473 than 0xab.
5474
aefd87e1
PE
5475 * xgselect.c (xgselect_initialize): Check vs interface
5476 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5477
bf501fb9
PE
5478 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5479
e9829fdf
PE
5480 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5481 to read-only memory.
5482
1086c095
PE
5483 * fns.c (vector): Remove; this old hack is no longer needed.
5484
2baccd04 5485 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5486 Remove unused var.
dde42981 5487 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5488
72391843 5489 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5490
436c16df 5491 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5492 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5493 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5494
92bb796d 5495 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5496 (x_term_init): Remove local to avoid shadowing.
92bb796d 5497
764430a3 5498 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5499
5500 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5501 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5502
d1dfb56c
EZ
55032011-04-16 Eli Zaretskii <eliz@gnu.org>
5504
c4354cb4
EZ
5505 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5506
d1dfb56c
EZ
5507 Fix regex.c, syntax.c and friends for buffers > 2GB.
5508 * syntax.h (struct gl_state_s): Declare character position members
5509 EMACS_INT.
5510
5511 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5512
04f2d78b
CB
5513 * textprop.c (verify_interval_modification, interval_of):
5514 Declare arguments EMACS_INT.
d1dfb56c
EZ
5515
5516 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5517 EMACS_INT.
5518
5519 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5520
5521 * indent.c (Fvertical_motion): Local variable it_start is now
5522 EMACS_INT.
5523
5524 * regex.c (re_match, re_match_2, re_match_2_internal)
5525 (bcmp_translate, regcomp, regexec, print_double_string)
5526 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5527 (re_compile_pattern, re_exec): Declare arguments and local
5528 variables `size_t' and `ssize_t' and return values `regoff_t', as
5529 appropriate.
5530 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5531 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5532 <compile_stack_type>: `size' and `avail' are now `size_t'.
5533
5534 * regex.h <regoff_t>: Use ssize_t, not int.
5535 (re_search, re_search_2, re_match, re_match_2): Arguments that
5536 specify buffer/string position and length are now ssize_t and
5537 size_t. Return type is regoff_t.
5538
613052cd
BK
55392011-04-16 Ben Key <bkey76@gmail.com>
5540
5541 * nsfont.m: Fixed bugs in ns_get_family and
5542 ns_descriptor_to_entity that were caused by using free to
5543 deallocate memory blocks that were allocated by xmalloc (via
5544 xstrdup). This caused Emacs to crash when compiled with
5545 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5546 --enable-checking=xmallocoverrun). xfree is now used to
5547 deallocate these memory blocks.
5548
4170f62f 55492011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5550
71b41406
PE
5551 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5552
9587a89d
PE
5553 emacs_write: Accept and return EMACS_INT for sizes.
5554 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5555 et seq.
5556 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5557 Accept and return EMACS_INT.
5558 (emacs_gnutls_write): Return the number of bytes written on
5559 partial writes.
5560 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5561 (emacs_read, emacs_write): Remove check for negative size, as the
5562 Emacs source code has been audited now.
9587a89d
PE
5563 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5564 (emacs_read, emacs_write): Use it.
273a5f82
PE
5565 * process.c (send_process): Adjust to the new signatures of
5566 emacs_write and emacs_gnutls_write. Do not attempt to store
5567 a byte offset into an 'int'; it might overflow.
9587a89d 5568 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5569
3e047f51
PE
5570 * sound.c: Don't assume sizes fit in 'int'.
5571 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5572 Return EMACS_INT, not int.
3e047f51 5573 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5574 Accept EMACS_INT, not int.
5575 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5576 record read return values.
5577
cc39a9db
BK
55782011-04-15 Ben Key <bkey76@gmail.com>
5579
c9d0ec6d
JB
5580 * keyboard.c (Qundefined): Don't declare static since it is used
5581 in nsfns.m.
5582 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5583 static since they are used in nsfont.m.
cc39a9db 5584
6c60eb9f
SM
55852011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5586
5587 * process.c (Qprocessp): Don't declare static.
5588 * lisp.h (Qprocessp): Declare again.
5589
7990b61a
JB
55902011-04-15 Juanma Barranquero <lekktu@gmail.com>
5591
5592 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5593
5d4cb038
PE
55942011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5595
8bd7b830 5596 Improve C-level modularity by making more things 'static'.
cd64ea1d 5597
e3b27b31
PE
5598 Don't publish debugger-only interfaces to other modules.
5599 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5600 (verify_bytepos, count_markers): Move decls to the only modules
5601 that need them.
5602 * region-cache.h (pp_cache): Likewise.
5603 * window.h (check_all_windows): Likewise.
5604 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5605
5d4cb038
PE
5606 * sysdep.c (croak): Now static, if
5607 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5608 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5609
5610 * alloc.c (refill_memory_reserve): Now static if
5611 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5612 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5613
e87b6180
PE
5614 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5615 Define only if USE_LUCID.
5616
ac64929e
PE
5617 * xrdb.c (x_customization_string, x_rm_string): Now static.
5618
6f37259d
PE
5619 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5620 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5621
1683e3ab
PE
5622 * xdisp.c (draw_row_with_mouse_face): Now static.
5623 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5624
de9c2632
PE
5625 * window.h (check_all_windows): Mark externally visible.
5626
2b96acb7
PE
5627 * window.c (window_deletion_count): Now static.
5628
5629 * undo.c: Make symbols static if they're not exported.
5630 (last_undo_buffer, last_boundary_position, pending_boundary):
5631 Now static.
5632
50436f33
PE
5633 * textprop.c (interval_insert_behind_hooks): Now static.
5634 (interval_insert_in_front_hooks): Likewise.
5635
64520e5c
PE
5636 * term.c: Make symbols static if they're not exported.
5637 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5638 (max_frame_lines, tty_set_terminal_modes):
5639 (tty_reset_terminal_modes, tty_turn_off_highlight):
5640 (get_tty_terminal): Now static.
5641 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5642 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5643 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5644 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5645 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5646
1fa53021
PE
5647 * sysdep.c: Make symbols static if they're not exported.
5648 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5649 Now static.
5650 (sigprocmask_set, full_mask): Remove; unused.
5651 (wait_debugging): Mark as visible.
5652 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5653 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5654
d4b43b22
PE
5655 * syntax.c (syntax_temp): Define only if !__GNUC__.
5656
b7c513d0
PE
5657 * sound.c (current_sound_device, current_sound): Now static.
5658
989b29ad
PE
5659 * search.c (searchbufs, searchbuf_head): Now static.
5660
13a55a78
PE
5661 * scroll.c (scroll_cost): Remove; unused.
5662 * dispextern.h (scroll_cost): Remove decl.
5663
de68a1fc
PE
5664 * region-cache.h (pp_cache): Mark as externally visible.
5665
40ccffa6
PE
5666 * process.c: Make symbols static if they're not exported.
5667 (process_tick, update_tick, create_process, chan_process):
5668 (Vprocess_alist, proc_buffered_char, datagram_access):
5669 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5670 (deactivate_process): Mark defn as static, as well as decl.
5671 * lisp.h (create_process): Remove decl.
5672 * process.h (chan_process, Vprocess_alist): Remove decls.
5673
ad64fc97
PE
5674 * print.c: Make symbols static if they're not exported.
5675 (print_depth, new_backquote_output, being_printed, print_buffer):
5676 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5677 (print_interval, print_number_index, initial_stderr_stream):
5678 Now static.
5679 * lisp.h (Fprinc): Remove decl.
5680 (debug_output_compilation_hack): Mark as externally visible.
5681
adddb265
PE
5682 * sysdep.c (croak): Move decl from here to syssignal.h.
5683 * syssignal.h (croak): Put it here, so the API can be checked when
5684 'croak' is called from dissociate_if_controlling_tty.
5685
1717ede2
PE
5686 * minibuf.c: Make symbols static if they're not exported.
5687 (minibuf_save_list, choose_minibuf_frame): Now static.
5688 * lisp.h (choose_minibuf_frame): Remove decl.
5689
fa5fb2bc
PE
5690 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5691
1e3890d1
PE
5692 * lread.c: Make symbols static if they're not exported.
5693 (read_objects, initial_obarray, oblookup_last_bucket_number):
5694 Now static.
5695 (make_symbol): Remove; unused.
5696 * lisp.h (initial_obarray, make_symbol): Remove decls.
5697
8a1414fa
PE
5698 * keyboard.c: Make symbols static if they're not exported.
5699 (single_kboard, recent_keys_index, total_keys, recent_keys):
5700 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5701 (this_single_command_key_start, echoing, last_auto_save):
5702 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5703 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5704 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5705 (Vlispy_mouse_stem, double_click_count):
5706 Now static.
5707 (force_auto_save_soon): Define only if SIGDANGER.
5708 (ignore_mouse_drag_p): Now static if
5709 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5710 (print_help): Remove; unused.
5711 (stop_character, last_timer_event): Mark as externally visible.
5712 * keyboard.h (ignore_mouse_drag_p): Declare only if
5713 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5714 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5715 * lisp.h (echoing): Remove decl.
5716 (force_auto_save_soon): Declare only if SIGDANGER.
5717 * xdisp.c (redisplay_window): Simplify code, to make it more
5718 obvious that ignore_mouse_drag_p is not accessed if !defined
5719 USE_GTK && !defined HAVE_NS.
5720
93ea6e8f
PE
5721 * intervals.c: Make symbols static if they're not exported.
5722 (merge_properties_sticky, merge_interval_right, delete_interval):
5723 Now static.
5724 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5725
77382fcc
PE
5726 * insdel.c: Make symbols static if they're not exported.
5727 However, leave prepare_to_modify_buffer alone. It's never
5728 called from outside this function, but that appears to be a bug.
5729 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5730 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5731 (adjust_after_replace_noundo): Remove; unused.
5732 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5733 (signal_before_change): Remove decls.
77382fcc 5734
9306c32e
PE
5735 * indent.c (val_compute_motion, val_vmotion): Now static.
5736
cd44d2eb
PE
5737 * image.c: Make symbols static if they're not exported.
5738 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5739 if USE_GTK.
5740 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5741 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5742
ad9a7a06
PE
5743 * fringe.c (standard_bitmaps): Now static.
5744 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5745
81626931
PE
5746 * frame.c: Make symbols static if they're not exported.
5747 (x_report_frame_params, make_terminal_frame): Now static.
5748 (get_frame_param): Now static, unless HAVE_NS.
5749 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5750 (x_get_resource_string): Remove; not used.
5751 * frame.h (make_terminal_frame, x_report_frame_params):
5752 (x_get_resource_string); Remove decls.
5753 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5754 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5755
239f9db9
PE
5756 * font.c, fontset.c: Make symbols static if they're not exported.
5757 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5758 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5759 * font.c (font_close_object): Now static.
5760 * font.h (font_close_object): Remove.
5761 * fontset.c (FONTSET_OBJLIST): Remove.
5762 (free_realized_fontset) #if-0 the body, which does nothing.
5763 (face_suitable_for_char_p): #if-0, as it's never called.
5764 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5765 * xfaces.c (face_at_string_position):
5766 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5767 since 0 is always ASCII.
5768
dfcf3579
PE
5769 * fns.c (weak_hash_tables): Now static.
5770
5045092b
PE
5771 * fileio.c: Make symbols static if they're not exported.
5772 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5773 (Vwrite_region_annotation_buffers): Now static.
5774
57a96f5c
PE
5775 * eval.c: Make symbols static if they're not exported.
5776 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5777 * lisp.h (backtrace_list): Remove decl.
5778
35f08c38
PE
5779 * emacs.c: Make symbols static if they're not exported.
5780 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5781 (fatal_error_code, fatal_error_signal_hook, standard_args):
5782 Now static.
5783 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5784 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5785 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5786 * lisp.h (fatal_error_signal_hook): Remove decl.
5787 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5788
f44bd759
PE
5789 * editfns.c: Move a (normally-unused) function to its only use.
5790 * editfns.c, lisp.h (get_operating_system_release): Remove.
5791 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5792 worth the hassle of breaking this out.
5793
b532497d
PE
5794 * xterm.c: Make symbols static if they're not exported.
5795 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5796 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5797 (x_destroy_window, x_delete_display):
5798 Now static.
5799 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5800 (x_mouse_leave): Remove; unused.
5801 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5802 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5803 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5804 Remove decls.
5805 (x_mouse_leave): Declare only if WINDOWSNT.
5806 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5807 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5808 USE_X_TOOLKIT.
5809
1675728f
PE
5810 * ftxfont.c: Make symbols static if they're not exported.
5811 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5812 HAVE_FREETYPE.
5813 * font.h (ftxfont_driver): Likewise.
5814
e4cebfca
PE
5815 * xfns.c: Make symbols static if they're not exported.
5816 (x_last_font_name, x_display_info_for_name):
5817 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5818 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5819 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5820 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5821 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5822 (last_show_tip_args): Now static.
5823 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5824 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5825 (x_screen_planes): Remove; unused.
5826 * dispextern.h (x_screen_planes): Remove decl.
5827
5bf46f05
PE
5828 * dispnew.c: Make symbols static if they're not exported.
5829 * dispextern.h (redraw_garbaged_frames, scrolling):
5830 (increment_row_positions): Remove.
5831 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5832 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5833 Now static.
5834 (redraw_garbaged_frames): Remove; unused.
5835
435f4c28
PE
5836 * xfaces.c: Make symbols static if they're not exported.
5837 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5838 Remove decls.
5839 * xterm.h (defined_color): Remove decls.
5840 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5841 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5842 (menu_face_changed_default, defined_color, free_realized_face):
5843 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5844 (ascii_face_of_lisp_face): Remove; unused.
5845
8524aef3
PE
5846 * xdisp.c: Make symbols static if they're not exported.
5847 * dispextern.h (scratch_glyph_row, window_box_edges):
5848 (glyph_to_pixel_coords, set_cursor_from_row):
5849 (get_next_display_element, set_iterator_to_next):
5850 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5851 (show_mouse_face): Remove decls
5852 * frame.h (message_buf_print): Likewise.
5853 * lisp.h (pop_message, set_message, check_point_in_composition):
5854 Likewise.
5855 * xterm.h (set_vertical_scroll_bar): Likewise.
5856 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5857 (message_buf_print, scratch_glyph_row, displayed_buffer):
5858 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5859 (get_next_display_element, show_mouse_face, window_box_edges):
5860 (frame_to_window_pixel_xy, check_point_in_composition):
5861 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5862 (glyph_to_pixel_coords): Remove; unused.
5863
16390cd2
PE
5864 * dired.c (file_name_completion): Now static.
5865
5866 * dbusbind.c (xd_in_read_queued_messages): Now static.
5867
a25f4dfa
PE
5868 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5869 * data.c (circular_list_error): Remove.
5870
14a9c8df
PE
5871 * commands.h (last_point_position, last_point_position_buffer):
5872 (last_point_position_window): Remove decls.
5873 * keyboard.c: Make these variables static.
5874
04f2d78b
CB
5875 * coding.h (coding, code_convert_region, encode_coding_gap):
5876 Remove decls.
74ab6df5
PE
5877 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5878 (iso_code_class, detect_coding, code_convert_region): Now static.
5879 (encode_coding_gap): Remove; unused.
5880
38dfbee1
PE
5881 * chartab.c (chartab_chars, chartab_bits): Now static.
5882
a2cb4e63
PE
5883 * charset.h (charset_iso_8859_1): Remove decl.
5884 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5885 Now static.
5886
127198fd
PE
5887 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5888 * ccl.c (Vccl_program_table): Now static.
5889 (check_ccl_update): Remove; unused.
5890
d85b608f
PE
5891 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5892 * category.h: ... from here.
5893 * category.c (check_category_table, set_category_set): Now static.
5894
31cd66f3
PE
5895 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5896 * lisp.h: Remove these decls.
5897
c358e587
PE
5898 * buffer.c (buffer_count): Remove unused var.
5899
e78aecca
PE
5900 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5901 so that it's not optimized away.
5902 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5903 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5904 exported only to the debugger.
5905
e192d7d3 5906 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5907 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5908
92470028
PE
5909 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5910 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5911 was inaccessible from Lisp.
5912 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5913 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5914
244ed907
PE
5915 alloc.c: Import and export fewer symbols, and remove unused items.
5916 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5917 is defined.
5918 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5919 it's not optimized away by whole-program optimization.
5920 (message_enable_multibyte, free_misc): Remove.
5921 (catchlist, handlerlist, mark_backtrace):
5922 Declare only if BYTE_MARK_STACK.
5923 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5924 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5925 (message_enable_multibyte): Remove decl.
5926 (free_misc, interval_free_list, float_block, float_block_index):
5927 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5928 (cons_free_list, last_marked_index):
5929 Now static.
5930 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5931 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5932 (mark_backtrace): Define only if BYTE_MARK_STACK.
5933 * xdisp.c (message_enable_multibyte): Now static.
5934
61c2b50e 5935 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5936 This makes it easier for human readers (and static analyzers)
5937 to see whether these variables are used from other modules.
5938 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5939 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5940 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5941 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5942 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5943 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5944 * xmenu.c, xselect.c:
5945 Declare Q* vars static if they are not used in other modules.
5946 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5947 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5948 Remove decls of unexported vars.
5949 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5950
95c82688
PE
5951 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5952
16a97296
PE
5953 Make Emacs functions such as Fatom 'static' by default.
5954 This makes it easier for human readers (and static analyzers)
5955 to see whether these functions can be called from other modules.
5956 DEFUN now defines a static function. To make the function external
5957 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5958 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5959 (Finit_image_library):
16a97296
PE
5960 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5961 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5962 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5963 Remove decls, since these functions are now static.
5964 (Funintern, Fget_internal_run_time): New decls, since these functions
5965 were already external.
95c82688 5966
16a97296
PE
5967 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5968 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5969 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5970 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5971 * keyboard.c, keymap.c, lread.c:
5972 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5973 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5974 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5975 Mark functions with DEFUE instead of DEFUN,
5976 if they are used in other modules.
5977 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5978 decls for now-static functions.
5979 * buffer.h (Fdelete_overlay): Remove decl.
5980 * callproc.c (Fgetenv_internal): Mark as internal.
5981 * composite.c (Fremove_list_of_text_properties): Remove decl.
5982 (Fcomposition_get_gstring): New forward static decl.
5983 * composite.h (Fcomposite_get_gstring): Remove decl.
5984 * dired.c (Ffile_attributes): New forward static decl.
5985 * doc.c (Fdocumntation_property): New forward static decl.
5986 * eval.c (Ffetch_bytecode): New forward static decl.
5987 (Funintern): Remove extern decl; now in .h file where it belongs.
5988 * fileio.c (Fmake_symbolic_link): New forward static decl.
5989 * image.c (Finit_image_library): New forward static decl.
5990 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5991 * intervals.h (Fprevious_property_change):
5992 (Fremove_list_of_text_properties): Remove decls.
5993 * keyboard.c (Fthis_command_keys): Remove decl.
5994 (Fcommand_execute): New forward static decl.
5995 * keymap.c (Flookup_key): New forward static decl.
5996 (Fcopy_keymap): Now static.
5997 * keymap.h (Flookup_key): Remove decl.
5998 * process.c (Fget_process): New forward static decl.
5999 (Fprocess_datagram_address): Mark as internal.
6000 * syntax.c (Fsyntax_table_p): New forward static decl.
6001 (skip_chars): Remove duplicate decl.
6002 * textprop.c (Fprevious_property_change): New forward static decl.
6003 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6004 Now internal.
6005 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6006 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6007
785bbd42
PE
6008 * editfns.c (Fformat): Remove unreachable code.
6009
8b913b57
AS
60102011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6011
6012 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6013 change. (Bug#8496)
6014
a6744a35
EZ
60152011-04-13 Eli Zaretskii <eliz@gnu.org>
6016
6017 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6018 when at ZV. (Bug#8487)
6019
e7974947
AS
60202011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6021
baad03f0
AS
6022 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6023 (Bug#8437)
6024 * keyboard.c (parse_tool_bar_item): Likewise.
6025 * sound.c (sound_cleanup, alsa_close): Likewise.
6026 * termcap.c (tgetent): Likewise.
6027 * xfns.c (x_default_font_parameter): Likewise.
6028 * xsettings.c (read_and_apply_settings): Likewise.
6029
e7974947
AS
6030 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6031 (overrun_check_free): Protoize.
6032
28272684
PE
60332011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6034
6035 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6036 since callers should never pass a negative size.
6037 Change the signature to match that of plain 'read' and 'write'; see
6038 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6039 * lisp.h: Update prototypes of emacs_write and emacs_read.
6040
11997c76
EZ
60412011-04-11 Eli Zaretskii <eliz@gnu.org>
6042
6043 * xdisp.c (redisplay_window): Don't try to determine the character
6044 position of the scroll margin if the window start point w->startp
e896f03c 6045 is outside the buffer's accessible region. (Bug#8468)
11997c76 6046
8a2cbd72
EZ
60472011-04-10 Eli Zaretskii <eliz@gnu.org>
6048
6049 Fix write-region and its subroutines for buffers > 2GB.
6050 * fileio.c (a_write, e_write): Modify declaration of arguments and
6051 local variables to support buffers larger than 2GB.
6052 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6053
6054 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6055 argument, local variables, and return value.
6056
6057 * lisp.h: Update prototypes of emacs_write and emacs_read.
6058
6059 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6060
4073e537 60612011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6062
1ebfdcb6
PE
6063 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6064
b2ded58d
PE
6065 Fix more problems found by GCC 4.6.0's static checks.
6066
7d66342c
PE
6067 * xdisp.c (vmessage): Use a better test for character truncation.
6068
bbf47d44
PE
6069 * charset.c (load_charset_map): <, not <=, for optimization,
6070 and to avoid potential problems with integer overflow.
9248994d 6071 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6072 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6073 * editfns.c (Fformat): Likewise.
1e69125e 6074 * syntax.c (skip_chars): Likewise.
3befa583 6075
e3019616
PE
6076 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6077 This also lets GCC 4.6.0 generate slightly better loop code.
6078
becfa255
PE
6079 * callint.c (Fcall_interactively): <, not <=, for optimization.
6080 (Fcall_interactively): Count the number of arguments produced,
6081 not the number of arguments given. This is simpler and lets GCC
6082 4.6.0 generate slightly better code.
6083
dae0cd48
PE
6084 * ftfont.c: Distingish more carefully between FcChar8 and char.
6085 The previous code passed unsigned char * to a functions like
6086 strlen and xstrcasecmp that expect char *, which does not
6087 conform to the C standard.
6088 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6089 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6090 char * when the C standard requires it.
6091
76032d70
PE
6092 * keyboard.c (read_char): Remove unused var.
6093
eb3f1cc8
PE
6094 * eval.c: Port to Windows vsnprintf (Bug#8435).
6095 Include <limits.h>.
6096 (SIZE_MAX): Define if the headers do not.
6097 (verror): Do not give up if vsnprintf returns a negative count.
6098 Instead, grow the buffer. This ports to Windows vsnprintf, which
6099 does not conform to C99. Problem reported by Eli Zaretskii.
6100 Also, simplify the allocation scheme, by avoiding the need for
6101 calling realloc, and removing the ALLOCATED variable.
6102
70476b54
PE
6103 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6104
12020a9e
PE
6105 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6106 But keep the doprint source code for now, as we might revamp it
6107 and use it again (Bug#8435).
ea6c7ae6
PE
6108 * lisp.h (doprnt): Remove.
6109 * Makefile.in (base_obj): Remove doprnt.o.
6110 * deps.mk (doprnt.o): Remove.
6111
5fdb398c
PE
6112 error: Print 32- and 64-bit integers portably (Bug#8435).
6113 Without this change, on typical 64-bit hosts error ("...%d...", N)
6114 was used to print both 32- and 64-bit integers N, which relied on
6115 undefined behavior.
6116 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6117 New macro.
6118 * lisp.h (error, verror): Mark as printf-like functions.
6119 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6120 Report overflow in size calculations when allocating printf buffer.
6121 Do not truncate output string at its first null byte.
6122 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6123 Truncate the output at a character boundary, since vsnprintf does not
6124 do that.
6125 * charset.c (check_iso_charset_parameter): Convert internal
6126 character to string before calling 'error', since %c now has the
6127 printf meaning.
6128 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6129 overflow when computing char to be passed to 'error'. Do not
6130 pass Lisp_Object to 'error'; pass the integer instead.
6131 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6132 formatted with plain %d.
6133
b189fa66
PE
6134 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6135
bff87ef0
PE
6136 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6137
7e2cac20
PE
6138 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6139
ce4d90b5
PE
6140 * xterm.c (x_catch_errors): Remove duplicate declaration.
6141
266c9547
PE
6142 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6143
79c49ad2
PE
6144 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6145
368f4090
JM
61462011-04-10 Jim Meyering <meyering@redhat.com>
6147
6148 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6149 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6150 return ssize_t not "int", and use size_t as the buffer length.
6151 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6152 * gnutls.h: Update declarations.
6153 * process.c (read_process_output): Use ssize_t, to match.
6154 (send_process): Likewise.
6155
a32d4040
CY
61562011-04-09 Chong Yidong <cyd@stupidchicken.com>
6157
6158 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6159
8546720e 61602011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6161
04f2d78b
CB
6162 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6163 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6164
8546720e
GM
6165 * xterm.c (handle_one_xevent):
6166 * xmenu.c (create_and_show_popup_menu):
6167 * xselect.c (x_decline_selection_request)
6168 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6169
0a2f5c1a 61702011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6171
6172 Fix some uses of `int' instead of EMACS_INT.
6173 * search.c (string_match_1, fast_string_match)
6174 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6175 (scan_buffer, find_next_newline_no_quit)
6176 (find_before_next_newline, search_command, Freplace_match)
6177 (Fmatch_data): Make some `int' variables be EMACS_INT.
6178
6179 * xdisp.c (display_count_lines): 3rd argument and return value now
6180 EMACS_INT. All callers changed.
6181 (pint2hrstr): Last argument is now EMACS_INT.
6182
6183 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6184 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6185 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6186 (decode_coding_utf_16, decode_coding_emacs_mule)
6187 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6188 (decode_coding_ccl, decode_coding_charset)
6189 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6190 (decode_coding_iso_2022, decode_coding_emacs_mule)
6191 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6192 <char_offset, last_offset>: Declare EMACS_INT.
6193 (encode_coding_utf_8, encode_coding_utf_16)
6194 (encode_coding_emacs_mule, encode_invocation_designation)
6195 (encode_designation_at_bol, encode_coding_iso_2022)
6196 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6197 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6198 Declare EMACS_INT.
6199 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6200 (encode_invocation_designation): Last argument P_NCHARS is now
6201 EMACS_INT.
6202 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6203 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6204
6205 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6206 All users changed.
6207
6208 * ccl.c (Fccl_execute_on_string): Declare some variables
6209 EMACS_INT.
6210
8546720e 62112011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6212
6213 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6214
4e19a977
CS
62152011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6216
6217 * process.c (Fformat_network_address): Doc fix.
6218
87302331
R
62192011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6220
6221 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6222
cbb59342
CY
62232011-04-08 Chong Yidong <cyd@stupidchicken.com>
6224
6225 * keyboard.c (read_char): Call Lisp function help-form-show,
6226 instead of using internal_with_output_to_temp_buffer.
6227 (Qhelp_form_show): New var.
e0d38eeb 6228 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6229
6230 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6231
6232 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6233
e67a13ab
CY
62342011-04-06 Chong Yidong <cyd@stupidchicken.com>
6235
04f2d78b
CB
6236 * process.c (Flist_processes): Remove to Lisp.
6237 (list_processes_1): Delete.
e67a13ab 6238
973f782d
EZ
62392011-04-06 Eli Zaretskii <eliz@gnu.org>
6240
7c106b1e
EZ
6241 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6242
973f782d
EZ
6243 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6244
41cf7d1a 62452011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6246
ca23cc88
PE
6247 Fix more problems found by GCC 4.6.0's static checks.
6248
f390e2d5
PE
6249 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6250
42eea0d0
PE
6251 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6252
b69769da 6253 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6254
f9541e84
PE
6255 * xdisp.c (vmessage): Mark as a printf-like function.
6256
13841b55
PE
6257 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6258
c136c10f
PE
6259 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6260
5e2d4a30
PE
6261 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6262 printf-like functions.
6263 (tiff_load): Add casts to remove these marks before passing them
6264 to system-supplied API.
6265
583f48b9
PE
6266 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6267
b25d760e
PE
6268 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6269 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6270 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6271 directly, rather than having caller test rule sign. This avoids
6272 some unnecessary tests.
6273 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6274 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6275 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6276
bc7b6697 6277 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6278 (xfont_open): Avoid unnecessary tests.
bc7b6697 6279
27ccc379
PE
6280 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6281
dcd5c89a
PE
6282 * composite.h, composite.c (composition_gstring_put_cache):
6283 Use EMACS_INT, not int, for length.
6284
b13a45c6
PE
6285 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6286 breaking out part of COMPOSITION_DECODE_RULE.
6287 (COMPOSITION_DECODE_RULE): Use it.
6288 * composite.c (get_composition_id): Remove unused local vars,
6289 by using the new macro.
6290
1e792e4d
PE
6291 * textprop.c (set_text_properties_1): Change while to do-while,
6292 since the condition is always true at first.
6293
dc6c6455 6294 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6295 (interval_deletion_adjustment): Return unsigned value.
6296 All uses changed.
dc6c6455 6297
aba7731a
PE
6298 * process.c (list_processes_1, create_pty, read_process_output):
6299 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6300 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6301 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6302 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6303 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6304
fdfc4bf3
PE
6305 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6306
fca8fe46 6307 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6308 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6309
06a0259a 6310 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6311 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6312 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6313
e7b9e80f
PE
6314 * print.c (print_error_message): Avoid int overflow.
6315
56201685
PE
6316 * font.c (font_list_entities): Redo for clarity,
6317 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6318
78834453 6319 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6320 (font_score): Avoid potential overflow in diff calculation.
78834453 6321
0bc0b309 6322 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6323 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6324
e610eaca
PE
6325 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6326
b895abce
PE
6327 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6328 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6329 can always succeed if overflow has undefined behavior.
6330
1f1d9321 6331 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6332 (wordify): Omit three unnecessary tests.
1f1d9321 6333
c59478bc
PE
6334 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6335 All callers changed. This avoids the need for an unused var.
6336
79b73827
PE
6337 * casefiddle.c (casify_region): Remove var that is set but not used.
6338
a4db5dfe
PE
6339 * dired.c (file_name_completion): Remove var that is set but not used.
6340
43aae36e
PE
6341 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6342
2a47c44d 6343 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6344 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6345
a37c69bf
PE
6346 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6347 Check for integer overflow on size calculations.
6348
328ab8e7
PE
6349 * buffer.c (Fprevious_overlay_change): Remove var that is set
6350 but not used.
6351
e5a2a5cb
PE
6352 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6353 Remove vars that are set but not used.
8d84a6eb 6354 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6355 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6356
a60e5f68
PE
6357 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6358
f661cb61 6359 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6360 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6361
f0397f5a
PE
6362 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6363 that are set but not used.
6364
8664db06 6365 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6366 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6367
6abdaa4a
PE
6368 * xselect.c (x_get_local_selection, x_handle_property_notify):
6369 Remove vars that are set but not used.
6370
0ce7538d 6371 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6372 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6373
9ae848fc
PE
6374 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6375 Remove var that is set but not used.
0b918413
PE
6376 (scroll_bar_windows_size): Now size_t, not int.
6377 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6378 Check for overflow.
9ae848fc 6379
a5a62657
PE
6380 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6381 (map_tty_color) [!defined MSDOS]: Likewise.
6382
5c5cdd39
PE
6383 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6384
66ebf983
PE
6385 * coding.c: Remove vars that are set but not used.
6386 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6387 All callers changed.
6388 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6389 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6390 (decode_coding_charset): Remove vars that are set but not used.
6391
1be4d761
PE
6392 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6393 that is set but not used.
6394
47553fa8
PE
6395 * print.c (print_object): Remove var that is set but not used.
6396
1f7196bf 6397 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6398 The gnulib version avoids calling malloc in the usual case,
6399 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6400 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6401 * filelock.c (current_lock_owner): Likewise.
6402 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6403 * sysdep.c: Include allocator.h, careadlinkat.h.
6404 (emacs_no_realloc_allocator): New static constant.
6405 (emacs_readlink): New function.
fdb61804
PE
6406 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6407 ../lib/careadlinkat.h.
d1fdcab7 6408
f84c17c7
SM
64092011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6410
6411 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6412 first non-nil return value).
6413
ef3862ad
JD
64142011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6415
6416 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6417 if not defined (Bug#8403).
6418
376a7006
JB
64192011-04-02 Juanma Barranquero <lekktu@gmail.com>
6420
6421 * xdisp.c (display_count_lines): Remove parameter `start',
6422 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6423 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6424 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6425 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6426 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6427 and thereabouts. All callers changed.
6428 (get_per_char_metric): Remove parameter `f', unused since
6429 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6430
6ca3801d
JM
64312011-04-02 Jim Meyering <meyering@redhat.com>
6432
6433 do not dereference NULL upon failed strdup
6434 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6435 (ns_get_family): Likewise.
6436
d8e2b5ba
JB
64372011-04-02 Juanma Barranquero <lekktu@gmail.com>
6438
6439 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6440
8c74fcbd
JD
64412011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6442
6443 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6444 later (Bug#8403).
6445
7200d79c
SM
64462011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6447
03408648 6448 Add lexical binding.
7200d79c 6449
03408648
SM
6450 * window.c (Ftemp_output_buffer_show): New fun.
6451 (Fsave_window_excursion):
6452 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6453
6454 * lread.c (lisp_file_lexically_bound_p): New function.
6455 (Fload): Bind Qlexical_binding.
6456 (readevalloop): Remove `evalfun' arg.
6457 Bind Qinternal_interpreter_environment.
6458 (Feval_buffer): Bind Qlexical_binding.
6459 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6460 Mark as dynamic.
6461 (syms_of_lread): Declare `lexical-binding'.
6462
6463 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6464
6465 * keyboard.c (eval_dyn): New fun.
6466 (menu_item_eval_property): Use it.
ca105506
SM
6467
6468 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6469
03408648
SM
6470 * fns.c (concat, mapcar1): Accept byte-code-functions.
6471
6472 * eval.c (Fsetq): Handle lexical vars.
6473 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6474 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6475 (FletX, Flet): Obey lexical binding.
6476 (Fcommandp): Handle closures.
6477 (Feval): New `lexical' arg.
6478 (eval_sub): New function extracted from Feval. Use it almost
6479 everywhere where Feval was used. Look up vars in lexical env.
6480 Handle closures.
6481 (Ffunctionp): Move from subr.el.
6482 (Ffuncall): Handle closures.
6483 (apply_lambda): Remove `eval_flags'.
6484 (funcall_lambda): Handle closures and new byte-code-functions.
6485 (Fspecial_variable_p): New function.
6486 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6487 but without exporting it to Lisp.
23aba0ea 6488
23aba0ea 6489 * doc.c (Fdocumentation, store_function_docstring):
03408648 6490 * data.c (Finteractive_form): Handle closures.
23aba0ea 6491
03408648
SM
6492 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6493 interactive spec.
ba83908c 6494
04f2d78b
CB
6495 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6496 New byte-codes.
03408648
SM
6497 (exec_byte_code): New function extracted from Fbyte_code to handle new
6498 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6499
03408648 6500 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6501
03408648 6502 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6503
e2abce01
JB
65042011-03-31 Juanma Barranquero <lekktu@gmail.com>
6505
6506 * xdisp.c (redisplay_internal): Fix prototype.
6507
63696a73 65082011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6509
63696a73 6510 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6511 (try_scrolling): Use it when setting scroll_limit.
6512 Limit scrolling to 100 screen lines.
63696a73
EZ
6513 (redisplay_window): Even when falling back on "recentering",
6514 position point in the window according to scroll-conservatively,
6515 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6516
6517 (try_scrolling): When point is above the window, allow searching
6518 as far as scroll_max, or one screenful, to compute vertical
6519 distance from PT to the scroll margin position. This prevents
6520 try_scrolling from unnecessarily failing when
6521 scroll-conservatively is set to a value slightly larger than the
6522 window height. Clean up the case of PT below the margin at bottom
6523 of window: scroll_max can no longer be INT_MAX. When aggressive
6524 scrolling is in use, don't let point enter the opposite scroll
6525 margin as result of the scroll.
6526 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6527 threshold of 100 lines for never-recentering scrolling.
6528
e4cc2dfc
JB
65292011-03-31 Juanma Barranquero <lekktu@gmail.com>
6530
6531 * dispextern.h (move_it_by_lines):
6532 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6533 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6534 (message_log_check_duplicate): Remove parameters `prev_bol' and
6535 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6536 (redisplay_internal): Remove parameter `preserve_echo_area',
6537 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6538
6539 * indent.c (Fvertical_motion):
6540 * window.c (window_scroll_pixel_based, Frecenter):
6541 Don't pass `need_y_p' to `move_it_by_lines'.
6542
1c470562
SM
65432011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6544
44f230aa
SM
6545 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6546 steal a few bits to be more compact.
6547 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6548 Remove unneeded casts.
6549
1c470562
SM
6550 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6551
888adce9
ZK
65522011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6553
6554 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6555 binding" message (bug#7967).
6556
f838ed7b
PE
65572011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6558
77861b95
PE
6559 Fix more problems found by GCC 4.6.0's static checks.
6560
de6dbc14
PE
6561 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6562 Remove unused local var.
6563
f838ed7b
PE
6564 * editfns.c (Fmessage_box): Remove unused local var.
6565
792c7b2b
PE
6566 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6567 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6568 Omit unused local vars.
c499e557 6569 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6570 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6571 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6572 Omit unused local var.
6573
ba0165e1
PE
6574 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6575 Don't assume string length fits in int.
32ad8845 6576 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6577 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6578
3c59b4c9
PE
6579 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6580 instead of alloca (Bug#8344).
6581
a3eed478 6582 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6583 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6584
eb4d412d
PE
6585 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6586
1658b401
PE
6587 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6588 concerns.
6589
6590 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6591
6592 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6593
9a2c6e05
PE
6594 * keyboard.c (syms_of_keyboard): Use the same style as later
6595 in this function when indexing through an array. This also
6596 works around GCC bug 48267.
6597
03d0a109
PE
6598 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6599
44f730c8
PE
6600 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6601
fe75f926
PE
6602 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6603 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6604
ffa8c828
PE
6605 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6606 This avoids undefined behavior on integer overflow, and is a bit
6607 more convenient anyway since it is compared to a size_t variable.
6608
c5101a77
PE
6609 Variadic C functions now count arguments with size_t, not int.
6610 This avoids an unnecessary limitation on 64-bit machines, which
6611 caused (substring ...) to crash on large vectors (Bug#8344).
6612 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6613 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6614 All variadic functions and their callers changed accordingly.
c5101a77
PE
6615 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6616 * data.c (arith_driver, float_arith_driver): Likewise.
6617 * editfns.c (general_insert_function): Likewise.
6618 * eval.c (struct backtrace.nargs, interactive_p)
6619 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6620 (funcall_lambda, mark_backtrace): Likewise.
6621 * fns.c (concat): Likewise.
6622 * frame.c (x_set_frame_parameters): Likewise.
6623 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6624 0 if not found, not -1. All callers changed.
6625
dd3f25f7
PE
6626 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6627 (stack_copy_size): Now size_t, not int.
6628 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6629
461c2ab9
JB
66302011-03-28 Juanma Barranquero <lekktu@gmail.com>
6631
6632 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6633 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6634 All callers changed.
6635
6636 * lisp.h (multibyte_char_to_unibyte):
6637 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6638 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6639 * character.h (CHAR_TO_BYTE8):
6640 * cmds.c (internal_self_insert):
6641 * editfns.c (general_insert_function):
6642 * keymap.c (push_key_description):
6643 * search.c (Freplace_match):
6644 * xdisp.c (message_dolog, set_message_1): All callers changed.
6645
f6d62986
SM
66462011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6647
6648 * keyboard.c (safe_run_hook_funcall): New function.
6649 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6650 don't set the hook to nil, but remove the offending function instead.
6651 (Qcommand_hook_internal): Remove, unused.
6652 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6653 Vcommand_hook_internal.
6654
6655 * eval.c (enum run_hooks_condition): Remove.
6656 (funcall_nil, funcall_not): New functions.
6657 (run_hook_with_args): Call each function through a `funcall' argument.
6658 Remove `cond' argument, now redundant.
6659 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6660 (Frun_hook_with_args_until_failure): Adjust accordingly.
6661 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6662
1db5b1ad
JB
66632011-03-28 Juanma Barranquero <lekktu@gmail.com>
6664
6665 * dispextern.h (string_buffer_position): Remove declaration.
6666
6667 * print.c (strout): Remove parameter `multibyte', unused since
6668 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6669
6670 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6671 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6672 All callers changed.
6673
6674 * w32.c (_wsa_errlist): Use braces for struct initializers.
6675
6676 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6677 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6678 All callers changed.
6679 (string_buffer_position): Likewise. Also, make static (it's never
6680 used outside xdisp.c).
6681 (cursor_row_p): Remove parameter `w', unused since
6682 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6683 (decode_mode_spec): Remove parameter `precision', introduced during
6684 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6685 All callers changed.
6686
5ffb62aa
JD
66872011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6688
6689 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6690
461c2ab9 66912011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6692
6693 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6694 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6695 (ns_update_auto_hide_menu_bar): New functions.
6696 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6697 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6698 ns_constrain_all_frames.
6699 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6700 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6701
5c380ffb
JD
67022011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6703
6704 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6705
9af30bdf
GM
67062011-03-27 Glenn Morris <rgm@gnu.org>
6707
6708 * syssignal.h: Replace RETSIGTYPE with void.
6709 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6710 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6711 Replace SIGTYPE with void everywhere.
6712 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6713 * s/template.h (SIGTYPE): Remove commented out definition.
6714
e2abce01
JB
67152011-03-26 Eli Zaretskii <eliz@gnu.org>
6716
6717 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6718 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6719
f868cd8a
JB
67202011-03-26 Juanma Barranquero <lekktu@gmail.com>
6721
59eb0929
JB
6722 * w32.c (read_unc_volume): Use parameter `henum', instead of
6723 global variable `wget_enum_handle'.
6724
6725 * keymap.c (describe_vector): Remove parameters `indices' and
6726 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6727 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6728
f868cd8a
JB
6729 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6730
6731 * keyboard.c (timer_check): Remove parameter `do_it_now',
6732 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6733 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6734 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6735
6736 * keyboard.c (read_char):
6737 * w32menu.c (w32_menu_display_help):
6738 * xmenu.c (show_help_event, menu_help_callback):
6739 Adjust calls to `show_help_echo'.
6740
6741 * gtkutil.c (xg_maybe_add_timer):
6742 * keyboard.c (readable_events):
6743 * process.c (wait_reading_process_output):
6744 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6745
6746 * insdel.c (adjust_markers_gap_motion):
6747 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6748 (gap_left, gap_right): Don't call it.
6749
2ecf6fdb
CY
67502011-03-25 Chong Yidong <cyd@stupidchicken.com>
6751
6752 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6753 incurred during fontification.
6754
6b1f9ba4
JB
67552011-03-25 Juanma Barranquero <lekktu@gmail.com>
6756
6757 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6758 (DEFVAR_PER_BUFFER): Don't pass it.
6759
6760 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6761 (scrolling_window): Don't pass it.
6762
0f4a96b5
JB
67632011-03-25 Juanma Barranquero <lekktu@gmail.com>
6764
6765 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6766
6767 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6768 and `suffix'.
6769 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6770 of variables specific to SELinux and computation of `encoded_absname'.
6771
6772 * image.c (XPutPixel): Remove unused variable `height'.
6773
6774 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6775
6776 * unexw32.c (get_section_info): Remove unused variable `section'.
6777
6778 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6779 (system_process_attributes): Remove unused variable `sess'.
6780 (sys_read): Remove unused variable `err'.
6781
6782 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6783 (w32_wnd_proc): Remove unused variable `isdead'.
6784 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6785 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6786 (x_create_tip_frame): Remove unused variable `tem'.
6787
6788 * w32inevt.c (w32_console_read_socket):
6789 Remove unused variable `no_events'.
6790
6791 * w32term.c (x_draw_composite_glyph_string_foreground):
6792 Remove unused variable `width'.
6793
1149507c
JB
67942011-03-24 Juanma Barranquero <lekktu@gmail.com>
6795
6796 * w32term.c (x_set_glyph_string_clipping):
6797 Don't pass uninitialized region to CombineRgn.
6798
9c88f339
JB
67992011-03-23 Juanma Barranquero <lekktu@gmail.com>
6800
6801 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6802 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6803 (Fx_close_connection): Remove unused variable `i'.
6804
6805 * w32font.c (w32font_draw): Return number of glyphs.
6806 (w32font_open_internal): Remove unused variable `i'.
6807 (w32font_driver): Add missing initializer.
6808
6809 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6810 (fill_in_menu): Remove unused variable `items_added'.
6811
6812 * w32term.c (last_mouse_press_frame): Remove static global variable.
6813 (w32_clip_to_row): Remove unused variable `f'.
6814 (x_delete_terminal): Remove unused variable `i'.
6815
6816 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6817 (NOTHING): Remove unused static global variable.
6818 (uniscribe_check_otf): Remove unused variable `table'.
6819 (uniscribe_font_driver): Add missing initializers.
6820
dee091a3
JD
68212011-03-23 Julien Danjou <julien@danjou.info>
6822
6823 * term.c (Fsuspend_tty, Fresume_tty):
6824 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6825 * window.c (temp_output_buffer_show):
6826 * insdel.c (signal_before_change):
6827 * frame.c (Fhandle_switch_frame):
6828 * fileio.c (Fdo_auto_save):
6829 * emacs.c (Fkill_emacs):
6830 * editfns.c (save_excursion_restore):
6831 * cmds.c (internal_self_insert):
6832 * callint.c (Fcall_interactively):
6833 * buffer.c (Fkill_all_local_variables):
6834 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6835 Use Frun_hooks.
0f4a96b5 6836 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6837 unconditionnaly since it does the check itself.
6838
2c520ab5 68392011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6840
c9c49752
PE
6841 Fix more problems found by GCC 4.5.2's static checks.
6842
8abc3f12
PE
6843 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6844 the first time through the loop, since we know p0 < p1 then.
6845 This also avoids a gcc -Wstrict-overflow warning.
6846
a2d26660
PE
6847 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6848 leading to a memory leak, possible in functions like
6849 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6850 of objects (Bug#8318).
a2d26660 6851
916c72e9
PE
6852 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6853 that could (at least in theory) be that large.
6854
19ab8a18
PE
6855 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6856 This is less likely to overflow, and avoids undefined behavior if
6857 overflow does occur. All callers changed. Use strtoul to scan
6858 for the unsigned long integer.
b7cbbd6f
PE
6859 (pint2hrstr): Simplify and tune code slightly.
6860 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6861
f0641eff
PE
6862 * scroll.c (do_scrolling): Work around GCC bug 48228.
6863 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6864
7f650bb9
PE
6865 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6866 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6867 (validate_x_resource_name): Simplify count usage.
6868 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6869
37dd57d1
PE
6870 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6871 fail (Bug#8306).
81e56e61 6872
699979fc 6873 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6874
401bf9b4
PE
6875 * process.c (Fmake_network_process): Use socklen_t, not int,
6876 where POSIX says socklen_t is required in portable programs.
6877 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6878 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6879 (Fmake_network_process, server_accept_connection):
6880 (wait_reading_process_output, read_process_output):
6881 Likewise.
6882
b93aacde
PE
6883 * process.c: Rename or move locals to avoid shadowing.
6884 (list_processes_1, Fmake_network_process):
6885 (read_process_output_error_handler, exec_sentinel_error_handler):
6886 Rename or move locals.
4dc343ee 6887 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6888 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6889 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6890 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6891 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6892
af8a867c 6893 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6894 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6895 Include tparam.h instead, since it declares them.
af8a867c
PE
6896 * cm.h (PC): Remove extern decl; tparam.h now does this.
6897 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6898 * terminfo.c: Include tparam.h, to check interfaces.
6899 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6900 (tparam): Adjust signature to match interface in tparam.h;
6901 this removes some undefined behavior. Check that outstring and len
6902 are zero, which they always are with Emacs.
6903 * tparam.h (PC, BC, UP): New extern decls.
6904
0248044d 6905 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6906 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6907
8ff096c1 6908 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6909 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6910 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6911 (ftfont_list): Remove unused local.
49eaafba
PE
6912 (get_adstyle_property, ftfont_pattern_entity):
6913 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6914 Rename locals to avoid shadowing.
8ff096c1 6915
e2be39f6
PE
6916 * xfont.c (xfont_list_family): Mark var as initialized.
6917
c9735e30
PE
6918 * xml.c (make_dom): Now static.
6919
8f5201ae
PE
6920 * composite.c (composition_compute_stop_pos): Rename local to
6921 avoid shadowing.
b246f932
PE
6922 (composition_reseat_it): Remove unused locals.
6923 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6924 (composition_update_it): Mark var as initialized.
11b61122
PE
6925 (find_automatic_composition): Mark vars as initialized,
6926 with a FIXME (Bug#8290).
8f5201ae 6927
760fbc2c
PE
6928 character.h: Rename locals to avoid shadowing.
6929 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6930 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6931 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6932 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6933 to avoid shadowing.
6934
ff08eb85
PE
6935 * textprop.c (property_change_between_p): Remove; unused.
6936
fc7bf025
PE
6937 * intervals.c (interval_start_pos): Now static.
6938
235d7abc
PE
6939 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6940
44f230aa
SM
6941 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6942 Rename locals to avoid shadowing.
3e7d6594 6943
50060332
PE
6944 * sound.c (wav_play, au_play, Fplay_sound_internal):
6945 Fix pointer signedness.
d01f234b 6946 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6947 (wav_play): Initialize a variable to 0, to prevent undefined
6948 behavior (Bug#8278).
50060332 6949
c4fc4e30
PE
6950 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6951
918436ed
PE
6952 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6953
c939f91b
PE
6954 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6955 clobbering (Bug#8298).
b9c7f648
PE
6956 * sysdep.c (sys_subshell): Likewise.
6957 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6958
6bd8c144
PE
6959 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6960 This should get cleaned up, so that child_setup has the
6961 same signature on all platforms.
6962
7710357c 6963 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6964 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6965
c59da222
CY
69662011-03-22 Chong Yidong <cyd@stupidchicken.com>
6967
6968 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6969 not to be necessary, and produces flickering.
6970
66b87493
GM
69712011-03-20 Glenn Morris <rgm@gnu.org>
6972
6973 * config.in: Remove file.
6974
45b6f6d5
JB
69752011-03-20 Juanma Barranquero <lekktu@gmail.com>
6976
6977 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6978 are now in src/globals.h.
6979 (syms_of_minibuf): Remove spurious & from previous change.
6980
3ec03f7e
LL
69812011-03-20 Leo <sdl.web@gmail.com>
6982
6983 * minibuf.c (completing-read-function): New variable.
6984 (completing-read-default): Rename from completing-read.
6985 (completing-read): Call completing-read-function.
6986
b14e3e21
CY
69872011-03-19 Juanma Barranquero <lekktu@gmail.com>
6988
6989 * xfaces.c (Fx_load_color_file):
6990 Read color file from absolute filename (bug#8250).
6991
f2b726e6
JB
69922011-03-19 Juanma Barranquero <lekktu@gmail.com>
6993
6994 * makefile.w32-in: Update dependencies.
6995
09f6ff02
EZ
69962011-03-17 Eli Zaretskii <eliz@gnu.org>
6997
6998 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6999
29a6015a
PE
70002011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7001
a3a6c54e
PE
7002 Fix more problems found by GCC 4.5.2's static checks.
7003
b766f867
PE
7004 * process.c (make_serial_process_unwind, send_process_trap):
7005 (sigchld_handler): Now static.
7006
be02381c
PE
7007 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7008 That way, the code declares only the vars that it needs.
7009 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7010 * s/cygwin.h (PTY_ITERATION): Likewise.
7011 * s/darwin.h (PTY_ITERATION): Likewise.
7012 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7013
57048744
PE
7014 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7015 * process.c (allocate_pty): Don't declare stb unless it's needed.
7016
7914961c 7017 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7018 (CONSTANTLIM): Remove; unused.
7019 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7020 Define only if needed.
7914961c 7021
b3967b18
PE
7022 * unexelf.c (unexec): Name an expression,
7023 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7024 Use a different way to cause a compilation error if anyone uses
7025 n rather than nn, a way that does not involve shadowing.
73366a00 7026 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7027
29a6015a
PE
7028 * deps.mk (unexalpha.o): Remove; unused.
7029
43cfc33e 7030 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7031 * unexec.h: New file.
ce701a33
PE
7032 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7033 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7034 Depend on unexec.h.
7035 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7036 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7037 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7038 Change as necessary to match prototype in unexec.h.
ce701a33 7039
01f44d5a
PE
7040 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7041 shadowing.
4f63c6bb 7042 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7043
a6670b0b
PE
7044 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7045 Rename locals to avoid shadowing.
7046
cef2010d 7047 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7048 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7049
d4d7173a
PE
7050 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7051
f08b802a
PE
7052 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7053 warning when compiling print.c.
7054
3ddb0639
PE
7055 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7056 instead of using an uninitialized var.
5ad03b97 7057 (font_sort_entities): Mark var as initialized.
3ddb0639 7058
170a2692
PE
7059 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7060
e663c700
PE
7061 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7062 pointers to constants.
89bc529a 7063 (font_parse_fcname): Remove unused vars.
7b81e2d0 7064 (font_delete_unmatched): Now static.
ea838e10 7065 (font_get_spec): Remove; unused.
13a547c6
PE
7066 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7067 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7068 Rename or move locals to avoid shadowing.
e663c700 7069
2a80c887 7070 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7071 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7072
1384fa33 7073 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7074 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7075
8b2c52e9
PE
7076 * alloc.c (mark_backtrace): Move decl from here ...
7077 * lisp.h: ... to here, so that it can be checked.
7078
475545b5 7079 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7080 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7081 (lisp_indirect_variable): Name an expression,
7082 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7083 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7084
b1349114 7085 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7086 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7087 Use const pointer when appropriate.
b1349114 7088
a2928364
PE
7089 * lisp.h (get_system_name, get_operating_system_release):
7090 Move decls here, to check interfaces.
7091 * process.c (get_operating_system_release): Move decl to lisp.h.
7092 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7093 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7094 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7095 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7096 (Fformat_time_string, Fencode_time, Finsert_char):
7097 (Ftranslate_region_internal, Fformat):
7098 Rename or remove local vars to avoid shadowing.
9710023e 7099 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7100
a415e694
PE
7101 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7102 avoid shadowing.
7103
8ef4622d
PE
7104 * lisp.h (eassert): Check that the argument compiles, even if
7105 ENABLE_CHECKING is not defined.
7106
946f9a5b
PE
7107 * data.c (Findirect_variable): Name an expression, to avoid
7108 gcc -Wbad-function-cast warning.
112396d6 7109 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7110 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7111 (Fmake_variable_buffer_local, Fmake_local_variable):
7112 Mark variables as initialized.
52746918 7113 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7114
e5aab7e7 7115 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7116 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7117 Rename locals to avoid shadowing.
dff45157
PE
7118 (mark_stack): Move local variables into the #ifdef region where
7119 they're used.
7bc26fdb
PE
7120 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7121 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7122 needed otherwise.
7123 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7124 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7125 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7126
e5aab7e7
PE
7127 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7128 avoids undefined behavior in theory.
7129
4da60324
PE
7130 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7131
88043301
PE
7132 Use functions, not macros, for up- and down-casing (Bug#8254).
7133 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7134 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7135 to use the following functions instead of these macros.
7136 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7137 EMACS_INT, since callers assume the returned value fits in int.
7138 (upcase1): Likewise, for UPCASE_TABLE.
7139 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7140 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7141 the race-condition problem in the old DOWNCASE.
88043301 7142
19ed5445
PE
7143 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7144 Rename locals to avoid shadowing.
7145 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7146 (regex_compile, re_search_2, re_match_2_internal):
7147 Remove unused local vars.
952db0d7
PE
7148 (FREE_VAR): Rewrite so as not to use empty "else",
7149 which gcc can warn about.
da053e48 7150 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7151 (RETALLOC_IF): Define only if needed.
7152 (WORDCHAR_P): Likewise. This one is never needed, but is used
7153 only in a comment talking about a compiler bug, so put inside
7154 the #if 0 of that comment.
7155 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7156 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7157 Remove; unused.
19ed5445 7158
1f3561e4 7159 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7160 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7161 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7162
ded6f8f7
PE
7163 * search.c (simple_search): Remove unused var.
7164
dbd37a95
PE
7165 * dired.c (compile_pattern): Move decl from here ...
7166 * lisp.h: ... to here, so that it can be checked.
7167 (struct re_registers): New forward decl.
7168
7e47afad
PE
7169 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7170
85f24f61
PE
7171 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7172 All uses changed.
7173 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7174 Rename locals to avoid shadowing.
5671df8f 7175 (Fvertical_motion): Mark locals as initialized.
85f24f61 7176
181aa2be 7177 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7178 (casify_region): Mark local as initialized.
181aa2be 7179
930d429c
PE
7180 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7181
7082eac6
PE
7182 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7183 New macros, so that the caller can use some names other than
7184 gcpro1, gcpro2, etc.
7185 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7186 of the new macros.
7187 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7188 argument, for consistency with GCPRO2_VAR, etc: it is now the
7189 prefix of the variable, not the variable itself. All uses
7190 changed.
38b2c076
PE
7191 * dired.c (directory_files_internal, file_name_completion):
7192 Rename locals to avoid shadowing.
7193
15206ed9
PE
7194 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7195 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7196 dired.c's scmp function, had undefined behavior.
7197 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7198 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7199 * buffer.h: ... to here, because these macros use current_buffer,
7200 and the new implementation with inline functions needs to have
7201 current_buffer in scope now, rather than later when the macros
7202 are used.
7203 (downcase, upcase1): New static inline functions.
7204 (DOWNCASE, UPCASE1): Reimplement using these functions.
7205 This avoids undefined behavior in expressions like
7206 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7207 from race conditions in accessing the global variables
7208 case_temp1 and case_temp2.
7209 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7210 * lisp.h (case_temp1, case_temp2): Remove their decls.
7211 * character.h (ASCII_CHAR_P): Move from here ...
7212 * lisp.h: ... to here, so that the inline functions mentioned
7213 above can use them.
7214
4a6bea26
PE
7215 * dired.c (directory_files_internal_unwind): Now static.
7216
f14b7e14
PE
7217 * fileio.c (file_name_as_directory, directory_file_name):
7218 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7219 Now static.
2893f146
PE
7220 (file_name_as_directory): Use const pointers when appropriate.
7221 (Fexpand_file_name): Likewise. In particular, newdir might
7222 point at constant storage, so make it a const pointer.
fd4ead52 7223 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7224 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7225 signedness issues.
f839df0c
PE
7226 (Fset_file_times, Finsert_file_contents, auto_save_error):
7227 Rename locals to avoid shadowing.
f14b7e14 7228
5716756e 7229 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7230 (Ftry_completion, Fall_completions): Rename or remove locals
7231 to avoid shadowing.
5716756e 7232
b4c3046a
PE
7233 * marker.c (bytepos_to_charpos): Remove; unused.
7234
b45db522
PE
7235 * lisp.h (verify_bytepos, count_markers): New decls,
7236 so that gcc does not warn that these functions aren't declared.
7237
85876d07
PE
7238 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7239 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7240 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7241 (copy_text): Remove unused local var.
85876d07 7242
03d78a21 7243 * filelock.c (within_one_second): Now static.
b3dd38ab 7244 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7245
5df8f01b
PE
7246 * buffer.c (fix_overlays_before): Mark locals as initialized.
7247 (fix_start_end_in_overlays): Likewise. This function should be
7248 simplified by using pointers-to-pointers, but that's a different
7249 matter.
b1d876f1 7250 (switch_to_buffer_1): Now static.
8f54f30a
PE
7251 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7252 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7253
a70072c9 7254 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7255 Fix pointer signedness issue.
edced198
PE
7256 (sys_subshell): Mark local as volatile if checking for lint,
7257 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7258 (MAXPATHLEN): Define only if needed.
a70072c9 7259
a0977c44
PE
7260 * process.c (serial_open, serial_configure): Move decls from here ...
7261 * systty.h: ... to here, so that they can be checked.
7262
a884fdcc
PE
7263 * fns.c (get_random, seed_random): Move extern decls from here ...
7264 * lisp.h: ... to here, so that they can be checked.
7265
604efe86 7266 * sysdep.c (reset_io): Now static.
b8950c94 7267 (wait_for_termination_signal): Remove; unused.
604efe86 7268
38fc62d9
PE
7269 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7270 (copy_keymap_item, append_key, push_text_char_description):
7271 Now static.
1004a21a 7272 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7273 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7274 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7275 (describe_map_tree):
7276 Rename locals to avoid shadowing.
38fc62d9 7277
2f2650da
PE
7278 * keyboard.c: Declare functions static if they are not used elsewhere.
7279 (echo_char, echo_dash, cmd_error, top_level_2):
7280 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7281 (read_char, kbd_buffer_get_event, make_lispy_position):
7282 (make_lispy_event, make_lispy_movement, apply_modifiers):
7283 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7284 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7285 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7286 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7287 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7288
a053e86c 7289 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7290 (mark_kboards): Move decl here ...
7291 * alloc.c (mark_kboards): ... from here.
a053e86c 7292
4752793e
PE
7293 * lisp.h (force_auto_save_soon): New decl.
7294
74f10ca7 7295 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7296 (DEFINE_DUMMY_FUNCTION): New macro.
7297 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7298 Use it.
c03cd23f
PE
7299 (main): Add casts to avoid warnings
7300 if GCC considers string literals to be constants.
74f10ca7 7301
022e70d4
PE
7302 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7303
59d6fe83
PE
7304 * dbusbind.c: Pointer signedness fixes.
7305 (xd_signature, xd_append_arg, xd_initialize):
7306 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7307 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7308 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7309 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7310
78320123
PE
7311 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7312 if GCC considers string literals to be constants.
49cebcca 7313 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7314
35ac2a97
SM
73152011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7316
fb103ca9
SM
7317 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7318 (print_preprocess, print_object): New macro to fix last change.
7319
35ac2a97
SM
7320 * print.c (print_preprocess): Don't forget font objects.
7321
62973b41
JB
73222011-03-16 Juanma Barranquero <lekktu@gmail.com>
7323
7324 * emacs.c (USAGE3): Doc fixes.
7325
0e48bb22
AS
73262011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7327
7328 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7329 structure.
7330
7684e57b
JB
73312011-03-14 Juanma Barranquero <lekktu@gmail.com>
7332
7333 * lisp.h (VWindow_system, Qfile_name_history):
7334 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7335 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7336 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7337
7338 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7339 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7340
7341 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7342 * w32console.c (detect_input_pending, read_input_pending)
7343 (encode_terminal_code):
7344 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7345 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7346 (w32_system_caret_y, Qfile_name_history):
7347 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7348 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7349 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7350 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7351 * w32proc.c (Qlocal, report_file_error):
7352 * w32term.c (Vwindow_system, updating_frame):
7353 * w32uniscribe.c (initialized, uniscribe_font_driver):
7354 Remove unneeded extern declarations.
7355
2aa46d6c
CY
73562011-03-14 Chong Yidong <cyd@stupidchicken.com>
7357
c96bbc66 7358 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7359
cffc6f3b
CY
73602011-03-13 Chong Yidong <cyd@stupidchicken.com>
7361
7362 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7363 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7364 These macros can no longer be used for assignment.
7365
44f230aa
SM
7366 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7367 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7368 (record_buffer_markers, fetch_buffer_markers): New functions for
7369 recording and fetching special buffer markers.
7370 (set_buffer_internal_1, set_buffer_temp): Use them.
7371
7372 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7373
7374 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7375
7376 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7377 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7378
7379 * xdisp.c (hscroll_window_tree):
7380 (reconsider_clip_changes): Use PT instead of BUF_PT.
7381
d251f04b
EZ
73822011-03-13 Eli Zaretskii <eliz@gnu.org>
7383
7384 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7385 $(EMACS_ROOT)/lib/intprops.h.
7386
f0c77cd1
PE
73872011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7388
3eca4629
PE
7389 Fix more problems found by GCC 4.5.2's static checks.
7390
7c86ee98
PE
7391 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7392 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7393 (xg_free_frame_widgets): Make it clear that a local variable is
7394 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7395 (gdk_window_get_screen): Make it clear that this macro is needed
7396 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7397 (int_gtk_range_get_value): New function, which avoids a diagnostic
7398 from gcc -Wbad-function-cast.
7399 (xg_set_toolkit_scroll_bar_thumb): Use it.
7400 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7401 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7402 (get_utf8_string, xg_get_file_with_chooser):
7403 Rename locals to avoid shadowing.
7404 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7405
41729b81
PE
7406 * xgselect.c (xg_select): Remove unused var.
7407
f0c77cd1
PE
7408 * image.c (four_corners_best): Mark locals as initialized.
7409 (gif_load): Initialize transparent_p to zero (Bug#8238).
7410 Mark another local as initialized.
ec6cf4c6 7411 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7412
ce0ad53d 7413 * image.c (clear_image_cache): Now static.
d5d5a617 7414 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7415 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7416 (x_edge_detection): Remove unnecessary cast that
7417 gcc -Wbad-function-cast diagnoses.
2037898d 7418 (gif_load): Fix pointer signedness.
6ae141d6
PE
7419 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7420 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7421
33383987 74222011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7423
d32df629
PE
7424 Improve quality of tests for time stamp overflow.
7425 For example, without this patch (encode-time 0 0 0 1 1
7426 1152921504606846976) returns the obviously-bogus value (-948597
7427 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7428 reports time overflow. See
7429 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7430 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7431 * editfns.c: Include limits.h and intprops.h.
7432 (TIME_T_MIN, TIME_T_MAX): New macros.
7433 (time_overflow): Move earlier, to before first use.
7434 (hi_time, lo_time): New functions, for an accurate test for
7435 out-of-range times.
7436 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7437 (Fget_internal_run_time): Don't assume time_t fits in int.
7438 (make_time): Use list2 instead of Fcons twice.
7439 (Fdecode_time): More accurate test for out-of-range times.
7440 (check_tm_member): New function.
7441 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7442 (lisp_time_argument): Don't rely on undefined left-shift and
7443 right-shift behavior when checking for time stamp overflow.
8be6f318 7444
fe31d94c
PE
7445 * editfns.c (time_overflow): New function, refactoring common code.
7446 (Fformat_time_string, Fdecode_time, Fencode_time):
7447 (Fcurrent_time_string): Use it.
7448
8be6f318
PE
7449 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7450 * dired.c (make_time): Move to ...
7451 * editfns.c (make_time): ... here.
7452 * systime.h: Note the move.
7453
09d9db2c 74542011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7455
126bc0dc
YM
7456 * fringe.c (update_window_fringes): Remove unused variables.
7457
c47cbdfd
YM
7458 * unexmacosx.c (copy_data_segment): Also copy __got section.
7459 (Bug#8223)
7460
7ac80be9
EZ
74612011-03-12 Eli Zaretskii <eliz@gnu.org>
7462
c96bbc66 7463 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7464 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7465 Constify `char *' arguments and their references according to
7466 prototypes in tparam.h.
7467
ecb0f94d 7468 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7469
7ac80be9
EZ
7470 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7471 Adapt all references accordingly.
7472
7473 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7474
ef1fd07e
TT
74752011-03-11 Tom Tromey <tromey@redhat.com>
7476
7477 * buffer.c (syms_of_buffer): Remove obsolete comment.
7478
7ef4b50c
EZ
74792011-03-11 Eli Zaretskii <eliz@gnu.org>
7480
7481 * termhooks.h (encode_terminal_code): Declare prototype.
7482
7483 * msdos.c (encode_terminal_code): Don't declare prototype.
7484
7485 * term.c (encode_terminal_code): Now external again, used by
7486 w32console.c and msdos.c.
7487
44f230aa
SM
7488 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7489 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7490
4b1ec863 74912011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7492
1714f52b 7493 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7494
4b1ec863
PE
7495 * fringe.c (update_window_fringes): Mark locals as initialized
7496 (Bug#8227).
7497 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7498
524c7aa6
PE
7499 * alloc.c (mark_fringe_data): Move decl from here ...
7500 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7501 to check its interface.
7502 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7503
a5c0af81 7504 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7505 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7506 (fontset_font): Mark local as initialized.
a9a06e0b 7507 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7508
b4716021
PE
7509 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7510
811e9bac 7511 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7512 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7513 (x_own_selection, Fx_disown_selection_internal): Rename locals
7514 to avoid shadowing.
7515 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7516
7e3ab302
PE
7517 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7518 so that the caller can use some name other than gcpro1.
7519 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7520 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7521 (Fx_backspace_delete_keys_p):
7522 Use them to avoid shadowing, and rename vars to avoid shadowing.
7523 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7524 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7525 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7526 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7527 Remove unused locals.
7e3ab302
PE
7528 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7529 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7530 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7531 macros.
f78faa98 7532
e2b13473
PE
7533 * xterm.h (x_mouse_leave): New decl.
7534
77f23912
PE
7535 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7536 Remove unused functions.
cdf4ba58
PE
7537 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7538 (x_calc_absolute_position): Now static.
7411c686 7539 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7540 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7541 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7542 unless they are used.
38d0b34a
PE
7543 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7544 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7545 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7546 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7547 (x_error_catcher, x_connection_closed, x_error_handler):
7548 (x_error_quitter, xembed_send_message, x_iconify_frame):
7549 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7550 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7551 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7552
44f230aa
SM
7553 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7554 Rename or move locals to avoid shadowing.
6b463e58 7555 (tty_defined_color, merge_face_heights): Now static.
5967d051 7556 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7557 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7558 does not deduce is never used uninitialized.
73719eba
PE
7559 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7560 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7561
426994c3 7562 * terminal.c (store_terminal_param): Now static.
5489860b 7563
032f1620 7564 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7565 (set_frame_menubar): Remove unused local.
d4323972 7566 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7567 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7568 since they might point to immutable storage.
281585b0
PE
7569 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7570 since it's unused otherwise.
032f1620 7571
367c19e5 7572 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7573 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7574 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7575 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7576 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7577 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7578 does not deduce are never used uninitialized.
70739cbe 7579
07b48fa9
PE
7580 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7581
8868a238 7582 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7583 * window.c (window_loop, size_window):
7584 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7585
7e5cf297 7586 * window.c (display_buffer): Now static.
d6550a9f
PE
7587 (size_window): Mark variables that gcc -Wuninitialized
7588 does not deduce are never used uninitialized.
a586633d
PE
7589 * window.h (check_all_windows): New decl, to forestall
7590 gcc -Wmissing-prototypes diagnostic.
5b555da1 7591 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7592
f6095868
PE
7593 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7594 shadowing.
7595 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7596 Include <limits.h>.
7597 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7598 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7599 (load_charset_map): Mark variables that gcc -Wuninitialized
7600 does not deduce are never used uninitialized.
53df7c11 7601 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7602
f38b440c
PE
7603 * coding.c (coding_set_source, coding_set_destination):
7604 Use "else { /* comment */ }" rather than "else /* comment */;"
7605 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7606 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7607 a block, when the outer 'i' will do.
7608 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7609 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7610 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7611 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7612 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7613 Rename locals to avoid shadowing.
7614 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7615 * coding.c (emacs_mule_char, encode_invocation_designation):
7616 Now static, since they're not used elsewhere.
413bb2db 7617 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7618 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7619 (decode_coding_emacs_mule): Mark variables that gcc
7620 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7621 (detect_coding_iso_2022): Initialize a local variable that might
7622 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7623 this initialization is needed. (Bug#8211)
5f58e762
PE
7624 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7625 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7626 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7627 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7628 Remove unused macros.
f38b440c 7629
232b38b9 7630 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7631 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7632 * character.c (string_count_byte8): Likewise.
232b38b9 7633
fb90da1b
PE
7634 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7635 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7636
fb93dbc2
PE
7637 * chartab.c (copy_sub_char_table): Now static, since it's not used
7638 elsewhere.
5c156ace
PE
7639 (sub_char_table_ref_and_range, char_table_ref_and_range):
7640 Rename locals to avoid shadowing.
bbcd0949 7641 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7642
7d3b3862 7643 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7644 (BIDI_BOB): Remove unused macro.
7d3b3862 7645
6be7d3da
PE
7646 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7647 deduce are never used uninitialized.
c2ed9c8b 7648 * term.c (encode_terminal_code): Likewise.
6be7d3da 7649
75f8807f 7650 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7651
50938595
PE
7652 * tparam.h: New file.
7653 * term.c, tparam.h: Include it.
7654 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7655 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7656 Move these decls to tparam.h, and make them agree with what
7657 is actually in tparam.c. The previous trick of using incompatible
7658 decls in different modules does not conform to the C standard.
7659 All callers of tparam changed to use tparam's actual API.
7660 * tparam.c (tparam1, tparam, tgoto):
7661 Use const pointers where appropriate.
7662
fbceeba2
PE
7663 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7664 * cm.h (struct cm): Likewise.
7665 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7666 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7667 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7668 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7669 (turn_on_face, init_tty): Likewise.
7670 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7671
7f3f1250
PE
7672 * term.c (term_mouse_position): Rename local to avoid shadowing.
7673
e6ca6543
PE
7674 * alloc.c (mark_ttys): Move decl from here ...
7675 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7676
c40f8d15
AS
76772011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7678
7679 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7680
cfe0661d
JB
76812011-03-09 Juanma Barranquero <lekktu@gmail.com>
7682
7683 * search.c (compile_pattern_1): Remove argument regp, unused since
7684 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7685 (compile_pattern): Don't pass it.
7686
0afb4571
J
76872011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7688
7689 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7690 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7691 for ! HAVE_GTK3.
7692 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7693
7694 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7695
7696 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7697 gdk_window_get_screen, gdk_window_get_geometry,
7698 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7699 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7700 (xg_get_pixbuf_from_pixmap): New function.
7701 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7702 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7703 Call xg_get_pixbuf_from_pixmap instead of
7704 gdk_pixbuf_get_from_drawable.
7705 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7706 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7707 (xg_check_special_colors): Use GtkStyleContext and its functions
7708 for HAVE_GTK3.
7709 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7710 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7711 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7712 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7713 Call gtk_widget_get_preferred_size.
0afb4571
J
7714 (xg_frame_resized): gdk_window_get_geometry only takes 5
7715 parameters.
44f230aa
SM
7716 (xg_win_to_widget, xg_event_is_for_menubar):
7717 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7718 (xg_set_widget_bg): New function.
7719 (delete_cb): New function.
895009e1 7720 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7721 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7722 (xg_set_background_color): Call xg_set_widget_bg.
7723 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7724 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7725 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7726 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7727 if ! HAVE_GTK3.
7728 (update_frame_tool_bar): Call gtk_widget_hide.
7729 (xg_initialize): Use GDK_KEY_g.
7730
7731 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7732 if ! HAVE_GTK3
7733 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7734
7735 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7736 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7737 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7738
1c2cc4ef
JB
77392011-03-08 Juanma Barranquero <lekktu@gmail.com>
7740
7741 * w32xfns.c (select_palette): Check success of RealizePalette against
7742 GDI_ERROR, not zero.
7743
33383987 7744See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7745
7746;; Local Variables:
7747;; coding: utf-8
aac0c6e3
MR
7748;; End:
7749
33383987 7750 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7751
7752 This file is part of GNU Emacs.
7753
7754 GNU Emacs is free software: you can redistribute it and/or modify
7755 it under the terms of the GNU General Public License as published by
7756 the Free Software Foundation, either version 3 of the License, or
7757 (at your option) any later version.
7758
7759 GNU Emacs is distributed in the hope that it will be useful,
7760 but WITHOUT ANY WARRANTY; without even the implied warranty of
7761 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7762 GNU General Public License for more details.
7763
7764 You should have received a copy of the GNU General Public License
7765 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.