* gtkutil.c (style_changed_cb): Avoid need for strlen.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
882f0d81
PE
12011-06-20 Paul Eggert <eggert@cs.ucla.edu>
2
9bda3520
PE
3 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4
b5b8c9e5
PE
5 * font.c: Don't assume string length fits in int.
6 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7 Use ptrdiff_t, not int.
ccd6111c
PE
8 (font_intern_prop): Don't assume string length fits in int.
9 Don't assume integer property fits in fixnum.
10 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 11
882f0d81
PE
12 * filelock.c: Fix some buffer overrun and integer overflow issues.
13 (get_boot_time): Don't assume that gzip command string fits in 100 bytes.
14 Reformulate so as not to need the command string.
15 Invoke gzip -cd rather than gunzip, as it's more portable.
16 (lock_info_type, lock_file_1, lock_file):
17 Don't assume pid_t and time_t fit in unsigned long.
18 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
19 (current_lock_owner): Prefer signed type for sizes.
20 Use memcpy, not strncpy, where memcpy is what is really wanted.
21 Don't assume (via atoi) that time_t and pid_t fit in int.
22 Check for time_t and/or pid_t out of range, e.g., via a network share.
23 Don't alloca where an auto var works fine.
24
eb49b136
PE
252011-06-19 Paul Eggert <eggert@cs.ucla.edu>
26
93f4cf88
PE
27 * fileio.c: Fix some integer overflow issues.
28 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
29 Don't assume string length fits in int.
30 (directory_file_name): Don't assume string length fits in long.
31 (make_temp_name): Don't assume pid fits in int, or that its print
32 length is less than 20.
33
f3e92b69
PE
34 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
35
1bfdaf10
PE
36 * coding.c (make_subsidiaries): Don't assume string length fits in int.
37
35016e9a
PE
38 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
39
3d1e65a1
PE
40 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
41 We prefer signed integers, even for size calculations.
42
0b963a93
PE
43 * emacs.c: Don't assume string length fits in 'int'.
44 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
45 (main): Don't invoke strlen when not needed.
46
573f4b54
PE
47 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
48 (XD_DEBUG_MESSAGE): Don't waste a byte.
49
989f33ba
PE
50 * callproc.c (getenv_internal_1, getenv_internal)
51 (Fgetenv_internal):
965d34eb
PE
52 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
53
e4d29b33
PE
54 * lread.c (invalid_syntax): Omit length argument.
55 All uses changed. This doesn't fix a bug, but it simplifies the
56 code away from its former Hollerith-constant appearance, and it's
57 one less 'int' to worry about when looking at integer-overflow issues.
f14ed477 58 (string_to_number): Simplify the 2011-04-26 change by invoking xsignal1.
e4d29b33 59
eb49b136
PE
60 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
61 This didn't break anything, but it didn't help either.
62 It's confusing to put a bogus integer in a place where the actual
63 value does not matter.
9f62aeb1 64 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 65 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 66
e39e811e
PE
672011-06-18 Paul Eggert <eggert@cs.ucla.edu>
68
15375a22
PE
69 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
70 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
71 implementation.
b61cc01c
PE
72 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
73 We prefer signed types, and the value cannot exceed the EMACS_INT
74 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
75 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
76 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
77 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 78
53b2623d
PE
79 * indent.c (sane_tab_width): New function.
80 (current_column, scan_for_column, Findent_to, position_indentation)
81 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 82 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 83
45aebb64
PE
84 * image.c (xbm_image_p): Don't assume stated width and height fit in int.
85
f2ed8a70
PE
86 * lisp.h (lint_assume): New macro.
87 * composite.c (composition_gstring_put_cache):
88 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
89
abe80cc6
PE
90 * editfns.c, insdel.c:
91 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 92
b02c740e
PE
93 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
94
ebc96716
PE
95 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
96
b4e50fa0 97 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 98 Use much-faster test for byte-length change.
311d5d7c 99 Don't assume string byte-length fits in 'int'.
a4cf38e4 100 Check that character arg fits in 'int'.
85461888 101 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 102
c0c1ee9f
PE
103 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
104
a498d7f4
PE
105 * fns.c (concat): Catch string overflow earlier.
106 Do not rely on integer wraparound.
107
e39e811e
PE
108 * dispextern.h (struct it.overlay_strings_charpos): EMACS_INT, not int.
109
fadf4e30
PE
1102011-06-17 Paul Eggert <eggert@cs.ucla.edu>
111
87830974
PE
112 * dispextern.h (struct it.selective): Now EMACS_INT, not int.
113 * xdisp.c (forward_to_next_line_start)
114 (back_to_previous_visible_line_start)
115 (reseat_at_next_visible_line_start, next_element_from_buffer):
116 Don't arbitrarily truncate the value of 'selective' to int.
117
76031fad
PE
118 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
119
5eb55db9
PE
120 * composite.c: Don't truncate sizes to 'int'.
121 (composition_gstring_p, composition_reseat_it)
122 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
123 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
124 not EMACS_UINT, for indexes.
5eb55db9 125
0703a717
PE
126 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
127
d6202519
PE
128 * buffer.c: Include <verify.h>.
129 (struct sortvec.priority, struct sortstr.priority):
8961a454 130 Now EMACS_INT, not int.
c20998a7 131 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
132 (struct sortstr.size, record_overlay_string)
133 (struct sortstrlist.size, struct sortlist.used):
134 Don't truncate size to int.
135 (record_overlay_string): Check for size-calculation overflow.
d6202519 136 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 137
28177add
PE
1382011-06-16 Paul Eggert <eggert@cs.ucla.edu>
139
dd3482fe
PE
140 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
141 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
142 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
143
393d71f3 144 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
145 * fileio.c (Finsert_file_contents):
146 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
147 Remove the old (too-loose) buffer overflow checks.
148 They weren't needed, since make_gap checks for buffer overflow.
149 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
150 The old code merely checked for Emacs fixnum overflow, and relied
151 on undefined (wraparound) behavior. The new code avoids undefined
152 behavior, and also checks for ptrdiff_t and/or size_t overflow.
153
2e6813b0 154 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
155 Tune. Don't use wider integers than needed. Don't use alloca.
156 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 157
599a9e4f
PE
158 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
159
99561444
PE
160 * insdel.c, lisp.h (buffer_overflow): New function.
161 (insert_from_buffer_1, replace_range, replace_range_2):
162 * insdel.c (make_gap_larger):
163 * editfns.c (Finsert_char):
164 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
165
28177add
PE
166 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
167
e69dafad
PE
1682011-06-15 Paul Eggert <eggert@cs.ucla.edu>
169
a7af7fde 170 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 171
b1c46f02
PE
172 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
173 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
174
e69dafad
PE
175 * fileio.c: Don't assume EMACS_INT fits in off_t.
176 (emacs_lseek): New static function.
177 (Finsert_file_contents, Fwrite_region): Use it.
178 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
179
566684ea
PE
180 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
181
e6966cd6
PE
182 * fns.c: Don't overflow int when computing a list length.
183 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
184 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
185 truncation on 64-bit hosts. Check for QUIT every
186 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
187 faster and is responsive enough.
188 (Flength): Report an error instead of overflowing an integer.
189 (Fsafe_length): Return a float if the value is not representable
190 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 191 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 192 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 193
dd0b0efb
PE
194 * alloc.c: Check that resized vectors' lengths fit in fixnums.
195 (header_size, word_size): New constants.
196 (allocate_vectorlike): Don't check size overflow here.
197 (allocate_vector): Check it here instead, since this is the only
198 caller of allocate_vectorlike that could cause overflow.
199 Check that the new vector's length is representable as a fixnum.
200
86fe5cfe
PE
201 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
202 The previous code was bogus. For example, next_almost_prime (32)
203 returned 39, which is undesirable as it is a multiple of 3; and
204 next_almost_prime (24) returned 25, which is a multiple of 5 so
205 why was the code bothering to check for multiples of 7?
206
80e88859
PE
207 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
208
4a2f0ad6
PE
209 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
210
f66c7cf8
PE
211 Variadic C functions now count arguments with ptrdiff_t.
212 This partly undoes my 2011-03-30 change, which replaced int with size_t.
213 Back then I didn't know that the Emacs coding style prefers signed int.
214 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
215 were being counted with int, which may truncate counts on 64-bit
216 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
217 * lisp.h (struct Lisp_Subr.function.aMANY)
218 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
219 Arg counts are now ptrdiff_t, not size_t.
220 All variadic functions and their callers changed accordingly.
221 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
222 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
223 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
224 * callint.c (Fcall_interactively): Check arg count for overflow,
225 to avoid potential buffer overrun. Use signed char, not 'int',
226 for 'varies' array, so that we needn't bother to check its size
227 calculation for overflow.
228 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
229 * eval.c (apply_lambda):
230 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
231 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
232 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
233
a1759b76
PE
234 * callint.c (Fcall_interactively): Don't use index var as event count.
235
d96be9fc
PE
236 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
237 * mem-limits.h (SIZE): Remove; no longer used.
238
a690a978 239 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 240
578c21e6
PE
241 Remove unnecessary casts.
242 * xterm.c (x_term_init):
243 * xfns.c (x_set_border_pixel):
244 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
245 These aren't needed now that we assume ANSI C.
246
96f53c6c
PE
247 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
248 It's more likely to cause problems (due to unsigned overflow)
249 than to cure them.
250
83c77d31
PE
251 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
252
ee2079f1
PE
253 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
254
6da65536
PE
255 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
256
7147c4a4
PE
257 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
258
193e32d9
PE
259 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
260
e5533da6
PE
261 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
262
9910e595
PE
263 GLYPH_CODE_FACE returns EMACS_INT, not int.
264 * dispextern.h (merge_faces):
265 * xfaces.c (merge_faces):
01103c44
PE
266 * xdisp.c (get_next_display_element, next_element_from_display_vector):
267 Don't assume EMACS_INT fits in int.
9910e595 268
2638320e
PE
269 * character.h (CHAR_VALID_P): Remove unused parameter.
270 * fontset.c, lisp.h, xdisp.c: All uses changed.
271
045eb8d9
PE
272 * editfns.c (Ftranslate_region_internal): Omit redundant test.
273
c1f134b5
PE
274 * fns.c (concat): Minor tuning based on overflow analysis.
275 This doesn't fix any bugs. Use int to hold character, instead
276 of constantly refetching from Emacs object. Use XFASTINT, not
277 XINT, for value known to be a character. Don't bother comparing
278 a single byte to 0400, as it's always less.
279
395fcb93 280 * floatfns.c (Fexpt):
327eeec8
PE
281 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
282
abbd3d23
PE
283 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
284 for characters.
285
684a03ef
PE
286 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
287
0fed43f3
PE
288 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
289 Without this fix, on a 64-bit host (aset S 0 4294967386) would
290 incorrectly succeed when S was a string, because 4294967386 was
291 truncated before it was used.
292
8fd02eb7
PE
293 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
294 Otherwise, an out-of-range integer could cause undefined behavior
295 on a 64-bit host.
296
f8c86b69
PE
297 * composite.c: Use int, not EMACS_INT, for characters.
298 (fill_gstring_body, composition_compute_stop_pos): Use int, not
299 EMACS_INT, for values that are known to be in character range.
300 This doesn't fix any bugs but is the usual style inside Emacs and
301 may generate better code on 32-bit machines.
302
34206dd2
PE
303 Make sure a 64-bit char is never passed to ENCODE_CHAR.
304 This is for reasons similar to the recent CHAR_STRING fix.
305 * charset.c (Fencode_char): Check that character arg is actually
306 a character. Pass an int to ENCODE_CHAR.
307 * charset.h (ENCODE_CHAR): Verify that the character argument is no
308 wider than 'int', as a compile-time check to prevent future regressions
309 in this area.
310
c5958d4c 311 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
312
313 Make sure a 64-bit char is never passed to CHAR_STRING.
314 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
315 by silently ignoring the top 32 bits, allowing some values
316 that were far too large to be valid characters.
317 * character.h: Include <verify.h>.
318 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
319 arguments are no wider than unsigned, as a compile-time check
320 to prevent future regressions in this area.
321 * data.c (Faset):
01103c44 322 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
323 (Fsubst_char_in_region):
324 * fns.c (concat):
325 * xdisp.c (decode_mode_spec_coding):
326 Adjust to CHAR_STRING's new requirement.
327 * editfns.c (Finsert_char, Fsubst_char_in_region):
328 * fns.c (concat): Check that character args are actually
329 characters. Without this test, these functions did the wrong
330 thing with wildly out-of-range values on 64-bit hosts.
331
d37ca623
PE
332 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
333 These casts should not be needed on 32-bit hosts, either.
334 * keyboard.c (read_char):
335 * lread.c (Fload): Remove casts to unsigned.
336
ea204efb
PE
337 * lisp.h (UNSIGNED_CMP): New macro.
338 This fixes comparison bugs on 64-bit hosts.
339 (ASCII_CHAR_P): Use it.
340 * casefiddle.c (casify_object):
01103c44 341 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
342 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
343 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
344 * dispextern.h (FACE_FROM_ID):
345 * keyboard.c (read_char): Use UNSIGNED_CMP.
346
41cb286c
PE
347 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
348 not to EMACS_INT, to avoid GCC warning.
349
4a1b9832
PE
350 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
351
55daad71
PE
352 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
353 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
354 isn't needed on 32-bit machines.
8f95c75c 355
01103c44
PE
356 * buffer.c (Fgenerate_new_buffer_name):
357 Use EMACS_INT for count, not int.
0ceccced 358 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
359
360 * data.c (Qcompiled_function): Now static.
361
c6f072e7
PE
362 * window.c (window_body_lines): Now static.
363
20ce5912
PE
364 * image.c (gif_load): Rename local to avoid shadowing.
365
9c4c5f81
PE
366 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
367 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
368 * alloc.c (make_save_value): Integer argument is now of type
369 ptrdiff_t, not int.
370 (mark_object): Use ptrdiff_t, not int.
371 * lisp.h (pD): New macro.
372 * print.c (print_object): Use it.
373
c0c5c8ae
PE
374 * alloc.c: Use EMACS_INT, not int, to count objects.
375 (total_conses, total_markers, total_symbols, total_vector_size)
376 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
377 (total_free_floats, total_floats, total_free_intervals)
378 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
379 Now EMACS_INT, not int. All uses changed.
380 (Fgarbage_collect): Compute overall total using a double, so that
381 integer overflow is less likely to be a problem. Check for overflow
382 when converting back to an integer.
5a25e253
PE
383 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
384 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
385 These were 'int' variables that could overflow on 64-bit hosts;
386 they were never used, so remove them instead of repairing them.
211a0b2a 387 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
388 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
389 Previously, this ceilinged at INT_MAX, but that doesn't work on
390 64-bit machines.
e46bb31a 391 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 392
c78baabf 393 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 394 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
395 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
396 when a (possibly-narrower) signed value would do just as well.
397 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 398
c9d624c6
PE
399 * alloc.c: Catch some string size overflows that we were missing.
400 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
401 for convenience in STRING_BYTES_MAX.
402 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
403 The definition here is exact; the one in lisp.h was approximate.
404 (allocate_string_data): Check for string overflow. This catches
405 some instances we weren't catching before. Also, it catches
406 size_t overflow on (unusual) hosts where SIZE_MAX <= min
407 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
408 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 409
c9d624c6
PE
410 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
411 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
412 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
413
353032ce
PE
414 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
415
2bccce07
PE
416 * alloc.c (Fmake_string): Check for out-of-range init.
417
0ac30604
SM
4182011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
419
420 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
421
c195f2de
JD
4222011-06-14 Jan Djärv <jan.h.d@swipnet.se>
423
424 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
425 xg_get_default_scrollbar_width.
426
427 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
428 (int_gtk_range_get_value): Move to the scroll bar part of the file.
429 (style_changed_cb): Call update_theme_scrollbar_width and call
430 x_set_scroll_bar_default_width and xg_frame_set_char_size for
431 all frames (Bug#8505).
432 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
433 Call gtk_window_set_resizable if HAVE_GTK3.
434 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
435 and height if HAVE_GTK3 (Bug#8505).
436 (scroll_bar_width_for_theme): New variable.
437 (update_theme_scrollbar_width): New function.
438 (xg_get_default_scrollbar_width): Move code to
439 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
440 (xg_initialize): Call update_theme_scrollbar_width.
441
442 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
443
444 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
445
e10ac9f1
MR
4462011-06-12 Martin Rudalics <rudalics@gmx.at>
447
448 * frame.c (make_frame): Call other_buffer_safely instead of
449 other_buffer.
450
451 * window.c (temp_output_buffer_show): Call display_buffer with
452 second argument Vtemp_buffer_show_specifiers and reset latter
453 immediately after the call.
454 (Vtemp_buffer_show_specifiers): New variable.
455 (auto_window_vscroll_p, next_screen_context_lines)
456 (Vscroll_preserve_screen_position): Remove leading asterisks from
457 doc-strings.
458
2d3c217e 4592011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 460
7b7f97e8 461 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
462 * buffer.c (Qclone_number): Remove for now, as it's unused.
463 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
464 (record_buffer): Remove unused local.
465 * frame.c (other_visible_frames, frame_buffer_list): Now static.
466 (set_frame_buffer_list): Remove; unused.
467 * frame.h (other_visible_frames): Remove decl.
468 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
469 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
470 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
471 if HAVE_GPM.
472 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
473 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
474 Define only if HAVE_GPM.
475 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
476 (update_hints_inhibit): Remove; never set. All uses removed.
477 * widgetprv.h (emacsFrameClassRec): Remove decl.
478 * window.c (delete_deletable_window): Now returns void, since it
479 wasn't returning anything.
480 (compare_window_configurations): Remove unused locals.
481 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
482 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
483 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
484 the same widths as pointers. This follows up on the 2011-05-06 patch.
485 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
486 * xterm.h: Likewise.
487 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
488
1384b89e
JB
4892011-06-12 Juanma Barranquero <lekktu@gmail.com>
490
491 * makefile.w32-in: Update dependencies.
492 (LISP_H): Add lib/intprops.h.
493
1100a63c
CY
4942011-06-11 Chong Yidong <cyd@stupidchicken.com>
495
496 * image.c (gif_load): Add animation frame delay to the metadata.
497 (syms_of_image): Use DEFSYM. New symbol `delay'.
498
6198ccd0
MR
4992011-06-11 Martin Rudalics <rudalics@gmx.at>
500
501 * window.c (delete_deletable_window): Re-add.
502 (Fset_window_configuration): Rewrite to handle dead buffers and
503 consequently deletable windows.
504 (window_tree, Fwindow_tree): Remove. Supply functionality in
505 window.el.
506 (compare_window_configurations): Simplify code.
507
b6e3633c
AS
5082011-06-11 Andreas Schwab <schwab@linux-m68k.org>
509
1ab0dee5
AS
510 * image.c (imagemagick_load_image): Fix type mismatch.
511 (Fimagemagick_types): Likewise.
512
b6e3633c
AS
513 * window.h (replace_buffer_in_windows): Declare.
514
9397e56f
MR
5152011-06-11 Martin Rudalics <rudalics@gmx.at>
516
517 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
518 Qclone_number. Remove external declaration of Qdelete_window.
519 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
520 code.
521 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
522 Qbuffer_list_update_hook if allowed.
523 (Fother_buffer): Rewrite doc-string. Major rewrite for new
524 buffer list implementation.
525 (other_buffer_safely): New function.
526 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
527 calls to replace_buffer_in_windows and
528 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
529 if allowed.
530 (record_buffer): Inhibit quitting and rewrite using quittable
531 functions. Run Qbuffer_list_update_hook if allowed.
532 (Frecord_buffer, Funrecord_buffer): New functions.
533 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
534 switch-to-buffer to window.el.
535 (bury-buffer): Move to window.el.
536 (Vbuffer_list_update_hook): New variable.
537
538 * lisp.h (other_buffer_safely): Add prototype in buffer.c
539 section.
540
541 * window.h (resize_frame_windows): Move up in code.
542 (Fwindow_frame): Remove EXFUN.
543 (replace_buffer_in_all_windows): Remove prototype.
544 (replace_buffer_in_windows_safely): Add prototype.
545
546 * window.c: Declare Qdelete_window static again. Move down
547 declaration of select_count.
548 (Fnext_window, Fprevious_window): Rewrite doc-strings.
549 (Fother_window): Move to window.el.
550 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
551 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
552 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
553 window.el.
554 (replace_buffer_in_windows): Implement by calling
555 Qreplace_buffer_in_windows.
556 (replace_buffer_in_all_windows): Remove with some functionality
557 moved into replace_buffer_in_windows_safely.
558 (replace_buffer_in_windows_safely): New function.
559 (select_window_norecord, select_frame_norecord): Move in front
560 of run_window_configuration_change_hook. Remove now obsolete
561 declarations.
562 (Fset_window_buffer): Rewrite doc-string. Call
563 Qrecord_window_buffer.
564 (keys_of_window): Move binding for other-window to window.el.
565
b50691aa
CY
5662011-06-11 Chong Yidong <cyd@stupidchicken.com>
567
568 * dispextern.h (struct image): Replace data member, whose int_val
569 and ptr_val fields were not used by anything, with a single
570 lisp_val object.
571
572 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
573 (gif_clear_image, gif_load, imagemagick_load_image)
574 (gs_clear_image, gs_load): Callers changed.
575
3f754b86
PE
5762011-06-10 Paul Eggert <eggert@cs.ucla.edu>
577
cca69397
PE
578 * buffer.h: Include <time.h>, for time_t.
579 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
580
109e28d0
PE
581 Fix minor problems found by static checking.
582
60737f02
PE
583 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
584
4b66faf3
PE
585 Make identifiers static if they are not used in other modules.
586 * data.c (Qcompiled_function, Qframe, Qvector):
587 * image.c (QimageMagick, Qsvg):
588 * minibuf.c (Qmetadata):
589 * window.c (resize_window_check, resize_root_window): Now static.
590 * window.h (resize_window_check, resize_root_window): Remove decls.
591
109e28d0
PE
592 * window.c (window_deletion_count, delete_deletable_window):
593 Remove; unused.
46a4ce9e
PE
594 (window_body_lines): Now static.
595 (Fdelete_other_windows_internal): Mark vars as initialized.
596 Make sure 'resize_failed' is initialized.
597 (run_window_configuration_change_hook): Rename local to avoid shadowing.
598 (resize_window_apply): Remove unused local.
599 * window.h (delete_deletable_window): Remove decl.
600
109e28d0 601 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
602 (imagemagick_load_image): Fix pointer signedness problem by changing
603 last arg from unsigned char * to char *. All uses changed.
604 Also, fix a local for similar reasons.
605 Remove unused locals. Remove locals to avoid shadowing.
606 (fn_rsvg_handle_free): Remove; unused.
607 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 608 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 609
3f754b86
PE
610 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
611
2547adb1
CY
6122011-06-10 Chong Yidong <cyd@stupidchicken.com>
613
614 * image.c (gif_load): Fix omitted cast error introduced by
615 2011-06-06 change.
616
2c8e37d4
MR
6172011-06-10 Martin Rudalics <rudalics@gmx.at>
618
619 * window.h (resize_proportionally, orig_total_lines)
620 (orig_top_line): Remove from window structure.
621 (set_window_height, set_window_width, change_window_heights)
622 (Fdelete_window): Remove prototypes.
623 (resize_frame_windows): Remove duplicate declaration.
624
440a42e3
EZ
6252011-06-10 Eli Zaretskii <eliz@gnu.org>
626
627 * window.h (resize_frame_windows, resize_window_check)
628 (delete_deletable_window, resize_root_window)
629 (resize_frame_windows): Declare prototypes.
630
631 * window.c (resize_window_apply): Make definition be "static" to
632 match the prototype.
633
562dd5e9
MR
6342011-06-10 Martin Rudalics <rudalics@gmx.at>
635
636 * window.c: Remove declarations of Qwindow_size_fixed,
637 window_min_size_1, window_min_size_2, window_min_size,
638 size_window, window_fixed_size_p, enlarge_window, delete_window.
639 Remove static from declaration of Qdelete_window, it's
640 temporarily needed by Fbury_buffer.
641 (replace_window): Don't assign orig_top_line and
642 orig_total_lines.
643 (Fdelete_window, delete_window): Remove. Window deletion is
644 handled by window.el.
645 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
646 Fdelete_window calls with calls to Qdelete_window.
647 (Fdelete_other_windows): Remove. Deleting other windows is
648 handled by window.el.
649 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
650 handled in window.el.
651 (window_min_size_2, window_min_size_1, window_min_size): Remove.
652 Window minimum sizes are handled in window.el.
653 (shrink_windows, size_window, set_window_height)
654 (set_window_width, change_window_heights, window_height)
655 (window_width, CURBEG, CURSIZE, enlarge_window)
656 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
657 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
658 handled in window.el.
659 (make_dummy_parent): Rename to make_parent_window and give it a
660 second argument horflag.
661 (make_window): Don't set resize_proportionally any more.
662 (Fsplit_window): Remove. Windows are split in window.el.
663 (save_restore_action, save_restore_orig_size)
664 (shrink_window_lowest_first, save_restore_orig_size): Remove.
665 Resize mini windows in window.el.
666 (grow_mini_window, shrink_mini_window): Implement by calling
667 Qresize_root_window_vertically, resize_window_check and
668 resize_window_apply.
669 (saved_window, Fset_window_configuration, save_window_save): Do
670 not handle orig_top_line, orig_total_lines, and
671 resize_proportionally.
672 (window_min_height, window_min_width): Move to window.el.
673 (keys_of_window): Move bindings for delete-other-windows,
674 split-window, delete-window and enlarge-window to window.el.
675
676 * buffer.c: Temporarily extern Qdelete_window.
677 (Fbury_buffer): Temporarily call Qdelete_window instead of
678 Fdelete_window (Fbury_buffer will move to window.el soon).
679
680 * frame.c (set_menu_bar_lines_1): Remove code handling
681 orig_top_line and orig_total_lines.
682
683 * dispnew.c (adjust_frame_glyphs_initially): Don't use
684 set_window_height but set heights directly.
685 (change_frame_size_1): Use resize_frame_windows.
686
687 * xdisp.c (init_xdisp): Don't use set_window_height but set
688 heights directly.
689
690 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
691 resize_frame_windows instead of change_window_heights and run
692 run_window_configuration_change_hook.
693
694 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
695 instead of change_window_heights and run
696 run_window_configuration_change_hook.
697
1a13852e
MR
6982011-06-09 Martin Rudalics <rudalics@gmx.at>
699
700 * window.c (replace_window): Rename second argument REPLACEMENT to
701 NEW. New third argument SETFLAG. Rewrite.
702 (delete_window, make_dummy_parent): Call replace_window with
703 third argument 1.
704 (window_list_1): Move down in code.
705 (run_window_configuration_change_hook): Move set_buffer part
706 before select_frame_norecord part in order to unwind correctly.
707 Rename count1 to count.
708 (recombine_windows, delete_deletable_window, resize_root_window)
709 (Fdelete_other_windows_internal)
710 (Frun_window_configuration_change_hook, make_parent_window)
711 (resize_window_check, resize_window_apply, Fresize_window_apply)
712 (resize_frame_windows, Fsplit_window_internal)
713 (Fdelete_window_internal, Fresize_mini_window_internal): New
714 functions.
715 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
716
f3d1777e
MR
7172011-06-08 Martin Rudalics <rudalics@gmx.at>
718
496e208e
MR
719 * window.h (window): Add some new members to window structure -
720 normal_lines, normal_cols, new_total, new_normal, clone_number,
721 splits, nest, prev_buffers, next_buffers.
722 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 723 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 724
f3d1777e
MR
725 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
726 Remove.
496e208e
MR
727 (make_dummy_parent): Set new members of windows structure.
728 (make_window): Move down in code. Handle new members of window
729 structure.
730 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
731 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
732 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
733 (Fset_window_prev_buffers, Fwindow_next_buffers)
734 (Fset_window_next_buffers, Fset_window_clone_number): New
735 functions.
736 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
737 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
738 Doc-string fixes.
739 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
740 Argument WINDOW can be now internal window too.
741 (Fwindow_use_time): Move up in code.
742 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
743 Rewrite doc-string.
744 (Fset_window_configuration, saved_window)
745 (Fcurrent_window_configuration, save_window_save): Handle new
746 members of window structure.
b9e809c2
MR
747 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
748 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
749 (syms_of_window): New Lisp objects Qrecord_window_buffer,
750 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
751 Qget_mru_window, Qresize_root_window,
752 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
753 Qauto_buffer_name; staticpro them.
f3d1777e 754
abde8f8c
MR
7552011-06-07 Martin Rudalics <rudalics@gmx.at>
756
757 * window.c (Fwindow_total_size, Fwindow_left_column)
758 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
759 (Fwindow_list_1): New functions.
760 (window_box_text_cols): Replace with window_body_cols.
761 (Fwindow_width, Fscroll_left, Fscroll_right): Use
762 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
763 (delete_window, Fset_window_configuration): Call
764 delete_all_subwindows with window as argument.
765 (delete_all_subwindows): Take a window as argument and not a
766 structure. Rewrite.
190b47e6
MR
767 (window_loop): Remove handling of GET_LRU_WINDOW and
768 GET_LARGEST_WINDOW.
769 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
770
771 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
772 window_box_text_cols. delete_all_subwindows now takes a
773 Lisp_Object as argument.
abde8f8c
MR
774
775 * indent.c (compute_motion, Fcompute_motion): Use
776 window_body_cols instead of window_box_text_cols.
777
fa8a67e6
MR
778 * frame.c (delete_frame): Call delete_all_subwindows with root
779 window as argument.
780
a54e3482
DC
7812011-06-07 Daniel Colascione <dan.colascione@gmail.com>
782
783 * fns.c (Fputhash): Document return value.
784
60002bf5
CY
7852011-06-06 Chong Yidong <cyd@stupidchicken.com>
786
787 * image.c (gif_load): Implement gif89a spec "no disposal" method.
788
0c671da6 7892011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 790
b862a52a 791 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 792
be44ca6c
PE
793 Check for overflow when converting integer to cons and back.
794 * charset.c (Fdefine_charset_internal, Fdecode_char):
795 Use cons_to_unsigned to catch overflow.
796 (Fencode_char): Use INTEGER_TO_CONS.
797 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
798 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
799 * data.c (long_to_cons, cons_to_long): Remove.
800 (cons_to_unsigned, cons_to_signed): New functions.
801 These signal an error for invalid or out-of-range values.
802 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
803 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
804 * font.c (Ffont_variation_glyphs):
805 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
806 * lisp.h: Include <intprops.h>.
807 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
808 (cons_to_signed, cons_to_unsigned): New decls.
809 (long_to_cons, cons_to_long): Remove decls.
810 * undo.c (record_first_change): Use INTEGER_TO_CONS.
811 (Fprimitive_undo): Use CONS_TO_INTEGER.
812 * xfns.c (Fx_window_property): Likewise.
813 * xselect.c: Include <limits.h>.
814 (x_own_selection, selection_data_to_lisp_data):
815 Use INTEGER_TO_CONS.
816 (x_handle_selection_request, x_handle_selection_clear)
817 (x_get_foreign_selection, Fx_disown_selection_internal)
818 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
819 (lisp_data_to_selection_data): Use cons_to_unsigned.
820 (x_fill_property_data): Use cons_to_signed.
821 Report values out of range.
822
d1f3d2af
PE
823 Check for buffer and string overflow more precisely.
824 * buffer.h (BUF_BYTES_MAX): New macro.
825 * lisp.h (STRING_BYTES_MAX): New macro.
826 * alloc.c (Fmake_string):
827 * character.c (string_escape_byte8):
828 * coding.c (coding_alloc_by_realloc):
829 * doprnt.c (doprnt):
830 * editfns.c (Fformat):
831 * eval.c (verror):
832 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
833 since they may not be the same number.
834 * editfns.c (Finsert_char):
835 * fileio.c (Finsert_file_contents):
836 Likewise for BUF_BYTES_MAX.
837
dd52fcea
PE
838 * image.c: Use ptrdiff_t, not int, for sizes.
839 (slurp_file): Switch from int to ptrdiff_t.
840 All uses changed.
841 (slurp_file): Check that file size fits in both size_t (for
842 malloc) and ptrdiff_t (for sanity and safety).
843
7f9bbdbb
PE
844 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
845 if b->modtime has its maximal value.
846
dfe18f82
PE
847 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
848
84acfcf0
PE
849 Don't assume time_t can fit into int.
850 * buffer.h (struct buffer.modtime): Now time_t, not int.
851 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
852 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
853
ccd9a01a
PE
854 Minor fixes for signed vs unsigned integers.
855 * character.h (MAYBE_UNIFY_CHAR):
856 * charset.c (maybe_unify_char):
857 * keyboard.c (read_char, reorder_modifiers):
858 XINT -> XFASTINT, since the integer must be nonnegative.
859 * ftfont.c (ftfont_spec_pattern):
860 * keymap.c (access_keymap, silly_event_symbol_error):
861 XUINT -> XFASTINT, since the integer must be nonnegative.
862 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
863 since it makes no difference and we prefer signed.
864 * keyboard.c (record_char): Use XUINT when all the neighbors do.
865 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
866 nonnegative.
867
d6d100dd
SM
8682011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
869
870 * window.h (Fwindow_frame): Declare.
871
2b6148e4
PE
8722011-06-06 Paul Eggert <eggert@cs.ucla.edu>
873
874 * alloc.c: Simplify handling of large-request failures (Bug#8800).
875 (SPARE_MEMORY): Always define.
876 (LARGE_REQUEST): Remove.
877 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
878
f230ecc9
MR
8792011-06-06 Martin Rudalics <rudalics@gmx.at>
880
727e958e
MR
881 * lisp.h: Move EXFUNS for Fframe_root_window,
882 Fframe_first_window and Fset_frame_selected_window to window.h.
883
884 * window.h: Move EXFUNS for Fframe_root_window,
885 Fframe_first_window and Fset_frame_selected_window here from
886 lisp.h.
887
888 * frame.c (Fwindow_frame, Fframe_first_window)
889 (Fframe_root_window, Fframe_selected_window)
890 (Fset_frame_selected_window): Move to window.c.
891 (Factive_minibuffer_window): Move to minibuf.c.
892 (Fother_visible_frames_p): New function.
893
894 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
895
f230ecc9
MR
896 * window.c (decode_window, decode_any_window): Move up in code.
897 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
898 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
899 (Fwindow_buffer): Move up and rewrite doc-string.
900 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
901 (Fwindow_prev): New functions.
727e958e
MR
902 (Fwindow_frame): Move here from frame.c. Accept any window as
903 argument.
904 (Fframe_root_window, Fframe_first_window)
905 (Fframe_selected_window): Move here from frame.c. Accept frame
906 or arbitrary window as argument. Update doc-strings.
907 (Fminibuffer_window): Move up in code.
908 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
909 (Fset_frame_selected_window): Move here from frame.c.
910 Marginal rewrite.
727e958e
MR
911 (Fselected_window, select_window, Fselect_window): Move up in
912 code. Minor doc-string fixes.
f230ecc9 913
4d09bcf6
PE
9142011-06-06 Paul Eggert <eggert@cs.ucla.edu>
915
916 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
917 Do not assume that spare memory exists; that assumption is valid
918 only if SYSTEM_MALLOC.
919 (LARGE_REQUEST): New macro, so that the issue of large requests
920 is separated from the issue of spare memory.
921
810928a2
AS
9222011-06-05 Andreas Schwab <schwab@linux-m68k.org>
923
172418ad
AS
924 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
925 format. (Bug#8806)
926
43f862f7
AS
927 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
928
810928a2
AS
929 * xfns.c (x_set_scroll_bar_default_width): Move declarations
930 before statements.
931
a059fe24
JD
9322011-06-05 Jan Djärv <jan.h.d@swipnet.se>
933
934 * gtkutil.c (xg_get_default_scrollbar_width): New function.
935
936 * gtkutil.h: Declare xg_get_default_scrollbar_width.
937
938 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
939 min width by calling x_set_scroll_bar_default_width (Bug#8505).
940
989bf368
JB
9412011-06-05 Juanma Barranquero <lekktu@gmail.com>
942
943 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
944
4b80f674
CY
9452011-06-04 Chong Yidong <cyd@stupidchicken.com>
946
947 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
948 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
949 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
950 New error handlers.
4b80f674
CY
951 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
952 Obey Vx_select_enable_clipboard_manager. Catch errors in
953 x_clipboard_manager_save (Bug#8779).
954 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 955 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 956
99a33b77 9572011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
958
959 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
960
99a33b77 9612011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
962
963 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
964 in the current matrix if keep_current_p is non-zero.
965
8264569d
EZ
9662011-06-04 Eli Zaretskii <eliz@gnu.org>
967
968 * bidi.c (bidi_level_of_next_char): Fix last change.
969
57f97249
EZ
9702011-06-03 Eli Zaretskii <eliz@gnu.org>
971
fec2107c 972 Support bidi reordering of text covered by display properties.
57f97249 973
fec2107c
EZ
974 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
975 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
976 (bidi_cache_search, bidi_cache_iterator_state)
977 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
978 (bidi_level_of_next_char, bidi_move_to_visually_next):
979 Support character positions inside a run of characters covered by a
fec2107c
EZ
980 display string.
981 (bidi_paragraph_init, bidi_resolve_explicit_1)
982 (bidi_level_of_next_char): Call bidi_fetch_char and
983 bidi_fetch_char_advance instead of FETCH_CHAR and
984 FETCH_CHAR_ADVANCE.
985 (bidi_init_it): Initialize new members.
986 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
987 definitions.
988 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
989 instead of using explicit *_CHAR codes.
d6d100dd
SM
990 (bidi_resolve_explicit, bidi_resolve_weak):
991 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
992 bidirectional text is supported only in multibyte buffers.
993 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
994 it to initialize the frame_window_p member of struct bidi_it.
995 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
996 (bidi_resolve_explicit, bidi_resolve_weak)
997 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
998 bidi_it->nchars is non-positive.
999 (bidi_level_of_next_char): Don't try to lookup the cache for the
1000 next/previous character if nothing is cached there yet, or if we
1001 were just reseat()'ed to a new position.
c40e2fb2 1002
0e14fe90
EZ
1003 * xdisp.c (set_cursor_from_row): Set start and stop points
1004 according to the row's direction when priming the loop that looks
1005 for the glyph on which to display cursor.
1006 (single_display_spec_intangible_p): Function deleted.
1007 (display_prop_intangible_p): Reimplement to call
1008 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1009 Accept 3 additional arguments needed by handle_display_spec.
1010 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1011 values: lists, `(when COND...)' forms, etc.
1012 (single_display_spec_string_p): Support property values that are
1013 lists with the argument STRING its top-level element.
1014 (display_prop_string_p): Fix the condition for processing a
1015 property that is a list to be consistent with handle_display_spec.
fec2107c 1016 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1017 last portion of handle_display_prop.
1018 (compute_display_string_pos): Accept additional argument
1019 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1020 value of a `display' property is a "replacing spec".
1021 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1022 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1023 the display property, but just return a value indicating whether
1024 the display property will replace the characters it covers.
1025 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1026 frame_window_p members of struct bidi_it.
d6d100dd
SM
1027 (compute_display_string_pos, compute_display_string_end):
1028 New functions.
fec2107c
EZ
1029 (push_it): Accept second argument POSITION, where pop_it should
1030 jump to continue iteration.
1031 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1032
fec2107c
EZ
1033 * keyboard.c (adjust_point_for_property): Adjust the call to
1034 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1035
1036 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1037 (bidi_init_it): Update prototypes.
1038 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1039 (compute_display_string_pos, compute_display_string_end):
1040 Declare prototypes.
fec2107c
EZ
1041 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1042 EMACS_INT.
fc6f18ce 1043
40087514 10442011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1045
57f53182
PE
1046 Malloc failure behavior now depends on size of allocation.
1047 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1048 * lisp.h: Change signatures accordingly.
1049 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1050 All callers changed. (Bug#8762)
1051
1052 * gnutls.c: Use Emacs's memory allocators.
1053 Without this change, the gnutls library would invoke malloc etc.
1054 directly, which causes problems on non-SYNC_INPUT hosts, and which
1055 runs afoul of improving memory_full behavior. (Bug#8761)
1056 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1057 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1058 xfree instead of the default malloc, realloc, free.
1059 (Fgnutls_boot): No need to check for memory allocation failure,
1060 since xmalloc does that for us.
1061
ac32cd99 1062 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1063 * category.c (hash_get_category_set):
1064 * ccl.c (ccl_driver):
1065 * charset.c (Fdefine_charset_internal):
1066 * charset.h (struct charset.hash_index):
1067 * composite.c (get_composition_id, gstring_lookup_cache)
1068 (composition_gstring_put_cache):
1069 * composite.h (struct composition.hash_index):
1070 * dispextern.h (struct image.hash):
1071 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1072 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1073 (hashfn_equal, hashfn_user_defined, make_hash_table)
1074 (maybe_resize_hash_table, hash_lookup, hash_put)
1075 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1076 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1077 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1078 * image.c (make_image, search_image_cache, lookup_image)
1079 (xpm_put_color_table_h):
1080 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1081 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1082 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1083 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1084 * alloc.c (allocate_vectorlike):
1085 Check for overflow in vector size calculations.
1086 * ccl.c (ccl_driver):
1087 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1088 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1089 need to be updated by these changes.
40087514
PE
1090 * fns.c (make_hash_table, maybe_resize_hash_table):
1091 Check for integer overflow with large hash tables.
0de4bb68
PE
1092 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1093 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1094 (SXHASH_REDUCE): New macro.
1095 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1096 Use it instead of discarding useful hash info with large hash values.
1097 (sxhash_float): New function.
1098 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1099 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1100 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1101 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1102 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1103 Adjust signatures to match updated version of code.
1104 (consing_since_gc): Now EMACS_INT, since a single hash table can
1105 use more than INT_MAX bytes.
1106
698d32e2
DN
11072011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1108
1109 Make it possible to build with GCC-4.6+ -O2 -flto.
1110
1111 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1112
fd6fa53f
SM
11132011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1114
1115 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1116 Call minibuffer-inactive-mode.
1117
864db017
JB
11182011-05-31 Juanma Barranquero <lekktu@gmail.com>
1119
1120 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1121 Update dependencies.
1122
2ad0baf4
DN
11232011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1124
1125 * data.c (init_data): Remove code for UTS, this system is not
1126 supported anymore.
1127
4fcc2638
DN
11282011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1129
1130 Don't force ./temacs to start in terminal mode.
1131
1132 * frame.c (make_initial_frame): Initialize faces in all cases, not
1133 only when CANNOT_DUMP is defined.
1134 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1135
c56e0fd5
DN
11362011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1137
1138 * dispnew.c (add_window_display_history): Use const for the string
1139 pointer. Remove declaration, not needed.
1140
333d54da 11412011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1142
55d4c1b2 1143 Use 'inline', not 'INLINE'.
333d54da 1144 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1145 * alloc.c, fontset.c (INLINE): Remove.
1146 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1147 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1148 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1149 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1150 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1151
738db178
DN
11522011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1153
1154 Make it possible to run ./temacs.
1155
1156 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1157 syms_of_callproc does the same thing. Remove test for
1158 "initialized", do it in the caller.
1159 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1160
620c53a6
SM
11612011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1162
1163 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1164 (read_minibuf): Use get_minibuffer.
1165 (syms_of_minibuf): Use DEFSYM.
1166 (Qmetadata): New var.
1167 * data.c (Qbuffer): Don't make it static.
1168 (syms_of_data): Use DEFSYM.
1169
e003a292
PE
11702011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1171
1172 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1173 (CCL_CODE_MIN): New macro.
1174
ed008a6d
PE
11752011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1176
3687c2ef
PE
1177 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1178
ed008a6d
PE
1179 * eval.c (Qdebug): Now static.
1180 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1181 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1182 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1183
d66c4c7c
CY
11842011-05-29 Chong Yidong <cyd@stupidchicken.com>
1185
1186 * image.c: Various fixes to ImageMagick code comments.
1187 (Fimagemagick_types): Doc fix.
1188
5fbc2025
PE
11892011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1190
0196f88a
PE
1191 Minor fixes prompted by GCC 4.6.0 warnings.
1192
1193 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1194
5fbc2025
PE
1195 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1196 (x_clipboard_manager_save_all): Move extern decl to ...
1197 * xterm.h: ... here, so that it can be checked for consistency.
1198
1dd3c2d9
CY
11992011-05-29 Chong Yidong <cyd@stupidchicken.com>
1200
1201 * xselect.c (x_clipboard_manager_save_frame)
1202 (x_clipboard_manager_save_all): New functions.
1203 (Fx_clipboard_manager_save): Lisp function deleted.
1204
1205 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1206 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1207
1208 * xterm.h: Update prototype.
1209
5ba6571d
WX
12102011-05-28 William Xu <william.xwl@gmail.com>
1211
1212 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1213 exiting (Bug#8239).
1214
3eaff834
JM
12152011-05-28 Jim Meyering <meyering@redhat.com>
1216
e1900994 1217 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1218 * fns.c (to_uchar): Define.
1219 (crypto_hash_function): Use it to convert some newly-signed
1220 variables to unsigned, to avoid sign-extension bugs. For example,
1221 without this change, (md5 "truc") would evaluate to
1222 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1223 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1224 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1225
0f6990a7
PE
12262011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1227
1228 Integer overflow fixes.
c8a9ca5a 1229
08686060
PE
1230 * dbusbind.c: Serial number integer overflow fixes.
1231 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1232 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1233 to hold a serial number that is too large for a fixnum.
1234 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1235 Check for serial numbers out of range. Decode any serial number
59568bf0 1236 that was so large that it became a float. (Bug#8722)
08686060 1237
2d1fc3c7
PE
1238 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1239 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1240 Use XFASTINT rather than XUINT when numbers are nonnegative.
1241 (xd_append_arg, Fdbus_method_return_internal):
1242 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1243 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1244 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1245 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1246 (Bug#8722)
2d1fc3c7 1247
c8a9ca5a
PE
1248 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1249
519e1d69
PE
1250 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1251
30569699
PE
1252 ccl: add integer overflow checks
1253 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1254 (IN_INT_RANGE): New macros.
1255 (ccl_driver): Use them to check for integer overflow when
1256 decoding a CCL program. Many of the new checks are whether XINT (x)
1257 fits in int; it doesn't always, on 64-bit hosts. The new version
1258 doesn't catch all possible integer overflows, but it's an
847044ea 1259 improvement. (Bug#8719)
30569699 1260
c11285dc
PE
1261 * alloc.c (make_event_array): Use XINT, not XUINT.
1262 There's no need for unsigned here.
1263
fdccd48e
PE
1264 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1265 This follows up to the 2011-05-06 change that substituted uintptr_t
1266 for EMACS_INT. This case wasn't caught back then.
1267
37910ab2
PE
1268 Rework Fformat to avoid integer overflow issues.
1269 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1270 now (part of C89). Include <verify.h>.
1271 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1272 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1273 (Fformat): Avoid the prepass trying to compute sizes; it was only
1274 approximate and thus did not catch overflow reliably. Instead, walk
1275 through the format just once, formatting and computing sizes as we go,
1276 checking for integer overflow at every step, and allocating a larger
1277 buffer as needed. Keep track separately whether the format is
1278 multibyte. Keep only the most-recently calculated precision, rather
1279 than them all. Record whether each argument has been converted to
1280 string. Use EMACS_INT, not int, for byte and char and arg counts.
1281 Support field widths and precisions larger than INT_MAX. Avoid
1282 sprintf's undefined behavior with conversion specifications such as %#d
1283 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1284 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1285 formatting out-of-range floating point numbers with int
1286 formats. (Bug#8668)
1287
2e6578fb
PE
1288 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1289
0ae6bdee
PE
1290 * data.c: Avoid integer truncation in expressions involving floats.
1291 * data.c: Include <intprops.h>.
1292 (arith_driver): When there's an integer overflow in an expression
1293 involving floating point, convert the integers to floating point
1294 so that the resulting value does not suffer from catastrophic
1295 integer truncation. For example, on a 64-bit host (* 4
1296 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1297 Do not rely on undefined behavior after integer overflow.
1298
de883a70
PE
1299 merge count_size_as_multibyte, parse_str_to_multibyte
1300 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1301 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1302 Check for integer overflow.
1303 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1304 since it's now a duplicate of the other. This is more of
1305 a character than a buffer op, so better that it's in character.c.
1306 * fns.c, print.c: Adjust to above changes.
1307
2ff916cb
PE
13082011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1309
1310 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1311
f1b54466
PE
13122011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1313
fb1ac845
PE
1314 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1315 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1316 (x_clipboard_manager_save): Now static.
1317 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1318
f1b54466
PE
1319 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1320 (crypto_hash_function): Now static.
1321 Fix pointer signedness problems. Avoid unnecessary initializations.
1322
a9f737ee
CY
13232011-05-27 Chong Yidong <cyd@stupidchicken.com>
1324
1325 * termhooks.h (Vselection_alist): Make it terminal-local.
1326
1327 * terminal.c (create_terminal): Initialize it.
1328
1329 * xselect.c: Support for clipboard managers.
1330 (Vselection_alist): Move to termhooks.h as terminal-local var.
1331 (LOCAL_SELECTION): New macro.
1332 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1333 (symbol_to_x_atom): Remove gratuitous arg.
1334 (x_handle_selection_request, lisp_data_to_selection_data)
1335 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1336 (x_own_selection, x_get_local_selection, x_convert_selection):
1337 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1338 (some_frame_on_display): Delete unused function.
1339 (Fx_own_selection_internal, Fx_get_selection_internal)
1340 (Fx_disown_selection_internal, Fx_selection_owner_p)
1341 (Fx_selection_exists_p): New optional frame arg.
1342 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1343 (x_handle_selection_clear): Don't treat other terminals with the
1344 same keyboard specially. Use the terminal-local Vselection_alist.
1345 (x_clear_frame_selections): Use Frun_hook_with_args.
1346
1347 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1348
1349 * xterm.h: Add support for those atoms.
1350
e067f0c1
CY
13512011-05-26 Chong Yidong <cyd@stupidchicken.com>
1352
1353 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1354 (converted_selections, conversion_fail_tag): New global variables.
1355 (x_selection_request_lisp_error): Free the above.
1356 (x_get_local_selection): Remove unnecessary code.
1357 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1358 of converted selections stored in converted_selections.
1359 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1360 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1361 (x_convert_selection): New function.
1362 (x_handle_selection_event): Simplify.
1363 (x_get_foreign_selection): Don't ignore incoming requests while
1364 waiting for an answer; this will fail when we implement
1365 SAVE_TARGETS, and seems unnecessary anyway.
1366 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1367 (Vx_sent_selection_functions): Doc fix.
1368
0f4aebc0
LL
13692011-05-26 Leo Liu <sdl.web@gmail.com>
1370
1371 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1372
e61124cd
YM
13732011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1374
1375 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1376
1377 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1378 for fringe update if it has periodic bitmap.
1379 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1380 and fringe_bitmap_periodic_p.
1381
1382 * fringe.c (get_fringe_bitmap_data): New function.
1383 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1384 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1385 row. Mark glyph row for fringe update if periodicity changed.
1386
1387 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1388 for fringe update unless it has periodic bitmap.
1389
f16d9837
KH
13902011-05-25 Kenichi Handa <handa@m17n.org>
1391
1392 * xdisp.c (get_next_display_element): Set correct it->face_id for
1393 a static composition.
1394
e1b90ef6
LL
13952011-05-24 Leo Liu <sdl.web@gmail.com>
1396
1397 * deps.mk (fns.o):
1398 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1399
1400 * fns.c (crypto_hash_function, Fsha1): New function.
1401 (Fmd5): Use crypto_hash_function.
1402 (syms_of_fns): Add Ssha1.
1403
7400048f
PE
14042011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1405
1406 * gnutls.c: Remove unused macros.
1407 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1408 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1409 Remove macros that are defined and never used.
1410 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1411
abb71cf4
CY
14122011-05-22 Chong Yidong <cyd@stupidchicken.com>
1413
1414 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1415 (Fx_get_selection_internal): Minor cleanup.
1416 (Fx_own_selection_internal): Rename arguments for consistency with
1417 select.el.
1418
6307db39
PE
14192011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1420
1421 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1422
f3d4e0a4
CY
14232011-05-22 Chong Yidong <cyd@stupidchicken.com>
1424
1425 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1426
4d8ade89
YM
14272011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1428
1429 * dispnew.c (scrolling_window): Don't exclude the case that the
1430 last enabled row in the desired matrix touches the bottom boundary.
1431
32078c8d
GM
14322011-05-21 Glenn Morris <rgm@gnu.org>
1433
1434 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1435 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1436 and add some more files.
32078c8d 1437
7285dc67
EZ
14382011-05-20 Eli Zaretskii <eliz@gnu.org>
1439
1440 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1441 report_file_error introduced by the change from 2011-05-07.
1442
89d1bd22
PE
14432011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1444
1445 * systime.h (Time): Define only if emacs is defined.
1446 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1447 where the include path doesn't have X11/X.h by default. See
1448 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1449
e23640bb 14502011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1451
1452 * composite.c (find_automatic_composition): Fix previous change.
1453
b9704ad9
GM
14542011-05-20 Glenn Morris <rgm@gnu.org>
1455
1456 * lisp.mk: New file, split from Makefile.in.
1457 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1458 (shortlisp): Remove.
1459 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1460
4a720484
GM
14612011-05-19 Glenn Morris <rgm@gnu.org>
1462
1463 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1464 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1465 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1466 (lisp): Set the order to that of loadup.el.
1467 (shortlisp): Make it a copy of $lisp.
1468 (SOME_MACHINE_LISP): Remove.
1469 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1470 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1471
a28d4396
KH
14722011-05-18 Kenichi Handa <handa@m17n.org>
1473
1474 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1475 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1476 (find_automatic_composition): Mostly rewrite for efficiency.
1477
a2b1fa8e
JB
14782011-05-18 Juanma Barranquero <lekktu@gmail.com>
1479
1480 * makefile.w32-in: Update dependencies.
1481
8e1f5610
CS
14822011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1483
1484 * menu.c: Include limits.h (fixes the MS-Windows build broken by
fadf4e30 1485 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 1486
7025ee00 14872011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1488
cdfa6eab
PE
1489 Fix some integer overflow issues, such as string length overflow.
1490
06d6db33
PE
1491 * insdel.c (count_size_as_multibyte): Check for string overflow.
1492
2b4560a8
PE
1493 * character.c (lisp_string_width): Check for string overflow.
1494 Use EMACS_INT, not int, for string indexes and lengths; in
1495 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1496 the resulting string length overflows an EMACS_INT; instead,
1497 report a string overflow if no precision given. When checking for
1498 precision exhaustion, use a check that cannot possibly have
1499 integer overflow. (Bug#8675)
1500 * character.h (lisp_string_width): Adjust to new signature.
1501
cb93f9be
PE
1502 * alloc.c (string_overflow): New function.
1503 (Fmake_string): Use it. This doesn't change behavior, but saves
1504 a few bytes and will simplify future changes.
1505 * character.c (string_escape_byte8): Likewise.
1506 * lisp.h (string_overflow): New decl.
1507
1a1f3366
PE
1508 Fixups, following up to the user-interface timestamp change.
1509 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1510 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1511 * msdos.c (mouse_get_pos): Likewise.
1512 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1513 * w32gui.h (Time): Define by including "systime.h" rather than by
1514 declaring it ourselves. (Bug#8664)
1515
d4e3e4d3
PE
1516 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1517 * image.c (clear_image_cache): Likewise.
1518
f6a24d19
PE
1519 * term.c (term_mouse_position): Don't assume time_t wraparound.
1520
08dc5ae6
PE
1521 Be more systematic about user-interface timestamps.
1522 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1523 and sometimes 'EMACS_UINT', to represent these timestamps.
1524 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1525 This makes the code easier to follow, and makes it easier to catch
1526 integer overflow bugs such as Bug#8664.
1527 * frame.c (Fmouse_position, Fmouse_pixel_position):
1528 Use Time, not unsigned long, for user-interface timestamps.
1529 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1530 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1531 * keyboard.h (last_event_timestamp): Likewise.
1532 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1533 * menu.h (xmenu_show): Likewise.
1534 * term.c (term_mouse_position): Likewise.
1535 * termhooks.h (struct input_event.timestamp): Likewise.
1536 (struct terminal.mouse_position_hook): Likewise.
1537 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1538 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1539 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1540 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1541 what it was before.
1542 * menu.h, termhooks.h: Include "systime.h", for Time.
1543
8e55734a
PE
1544 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1545 Don't assume that the difference between two unsigned long values
1546 can fit into an integer. At this point, we know button_down_time
1547 <= event->timestamp, so the difference must be nonnegative, so
1548 there's no need to cast the result if double-click-time is
1549 nonnegative, as it should be; check that it's nonnegative, just in
1550 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1551 apart (about 25 days). (Bug#8664)
8e55734a 1552
841f1b75 1553 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1554 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1555
3e26f69c
PE
1556 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1557 that always fit in int. Use a sentinel instead of a counter, to
1558 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1559 * frame.h (struct frame): Use int for menu_bar_items_used
1560 instead of EMACS_INT, since it always fits in int.
3e26f69c 1561
5cc152c0
PE
1562 * menu.c (grow_menu_items): Check for int overflow.
1563
d89eb65e
PE
1564 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1565
5235bd3e
PE
1566 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1567 Before, the code was not consistent. These values cannot exceed
1568 2**31 - 1 so there's no need to make them unsigned.
1569 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1570 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1571 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1572 as modifiers.
1573 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1574
bc827e23
PE
1575 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1576 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1577 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1578 presumably because the widths might not match.
1579
78eb494e
PE
1580 * window.c (size_window): Avoid needless test at loop start.
1581
04f2d78b
CB
15822011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1583
1584 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1585
d2fc7e3d 15862011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1587
1588 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1589
d2fc7e3d 15902011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1591
1592 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1593 `width' to `bar_area_x' and `bar_area_width', respectively.
1594 (x_scroll_run): Take account of fringe background extension.
1595
04f2d78b
CB
1596 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1597 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1598 `bar_area_width', respectively.
1599 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1600 background extension.
1601
79b70037
GM
16022011-05-10 Jim Meyering <meyering@redhat.com>
1603
1604 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1605
2f142cc5
JB
16062011-05-10 Juanma Barranquero <lekktu@gmail.com>
1607
1608 * image.c (Finit_image_library): Return t for built-in image types,
1609 like pbm and xbm. (Bug#8640)
1610
57679c86
AS
16112011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1612
1613 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1614
888c9e86
EZ
16152011-05-07 Eli Zaretskii <eliz@gnu.org>
1616
b0512a1d
EZ
1617 * w32console.c (Fset_screen_color): Doc fix.
1618 (Fget_screen_color): New function.
1619 (syms_of_ntterm): Defsubr it.
1620
7285dc67
EZ
1621 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1622 unlink the temporary file if Fcall_process didn't create it in the
1623 first place.
1624 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1625 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1626 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1627 cue to call_process_cleanup not to close that handle.
1628
4d3fcc8e
BK
16292011-05-07 Ben Key <bkey76@gmail.com>
1630
1631 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1632 one of two shell specific rules, either bootstrap-temacs-CMD or
1633 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1634 to the previous implementation of the bootstrap-temacs rule.
1635 The bootstrap-temacs-CMD rule is similar to the previous
1636 implementation of the bootstrap-temacs rule except that it
1637 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1638 variable.
1639
1640 These changes, along with some changes to nt/configure.bat,
1641 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1642 earlier fix to add support for --cflags and --ldflags options
1643 that include quotes so that it works whether make uses cmd or
1644 sh as the shell.
1645
b4289b64
MA
16462011-05-06 Michael Albinus <michael.albinus@gmx.de>
1647
1648 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1649 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1650 is a constant.
1651 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1652 a string. Handle both cases.
1653 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1654 (Fdbus_register_method): Use Qinvalid_function.
1655
af4c0e28
JB
16562011-05-06 Juanma Barranquero <lekktu@gmail.com>
1657
1658 * makefile.w32-in: Update dependencies.
1659 (LISP_H): Add inttypes.h and stdin.h.
1660 (PROCESS_H): Add unistd.h.
1661
c51453d9
EZ
16622011-05-06 Eli Zaretskii <eliz@gnu.org>
1663
1664 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1665 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1666
8ff0ac3c 16672011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1668
4c4b566b
PE
1669 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1670
aab2b9b5
PE
1671 * term.c (vfatal): Remove stray call to va_end.
1672 It's not needed and the C Standard doesn't allow it here anyway.
1673
c378da0b
PE
1674 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1675 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1676
288b08c7
PE
1677 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1678 bytes.
1679
e3601888
PE
1680 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1681
db6c0e74
PE
1682 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1683
dd5963ea
PE
1684 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1685
88c9450f
PE
1686 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1687
2f9442b8
PE
1688 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1689
c032b5f8
PE
1690 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1691 * charset.c (Fdefine_charset_internal): Don't initialize
1692 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1693 32-bit int (Bug#8600).
a108c10b
PE
1694
1695 * lread.c (read_integer): Be more consistent with string-to-number.
1696 Use string_to_number to do the actual conversion; this avoids
1697 rounding errors and fixes some other screwups. Without this fix,
1698 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1699 (digit_to_number): Move earlier, for benefit of read_integer.
1700 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1701 not a digit in any supported base. (Bug#8602)
a108c10b 1702
ad5f9eea
PE
1703 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1704
aec1708a
PE
1705 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1706 to match comment at start of function. This also removes a
1707 GCC warning about overflow in a 32+64-bit port.
1708
47be4ab5
PE
1709 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1710
371cac43
PE
1711 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1712 Reported by Stefan Monnier in
1713 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1714 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1715 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1716
d01a7826
PE
1717 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1718 (EMACS_UINTPTR): Likewise, with uintptr_t.
1719
7fd47d5c
PE
1720 * lisp.h: Prefer 64-bit EMACS_INT if available.
1721 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1722 on 32-bit hosts that have 64-bit int, so that they can access
1723 large files.
122b0c86
PE
1724 However, temporarily disable this change unless the temporary
1725 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1726
8727937b
PE
1727 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1728
8ac068ac
PE
1729 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1730 This removes an assumption that EMACS_INT and long are the same
1731 width as pointers. The assumption is true for Emacs porting targets
1732 now, but we want to make other targets possible.
1733 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1734 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1735 In the rest of the code, change types of integers that hold casted
1736 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1737 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1738 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1739 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1740 No need to cast type when ORing.
1741 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1742 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1743 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1744 assume EMACS_INT is the same width as char *.
1745 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1746 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1747 Remove no-longer-needed casts.
1748 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1749 (xg_tool_bar_help_callback, xg_make_tool_item):
1750 Use EMACS_INTPTR to hold an integer
1751 that will be cast to void *; this can avoid a GCC warning
1752 if EMACS_INT is not the same width as void *.
1753 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1754 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1755 (current_message_1, set_message_1):
1756 Use a local to convert to proper width without a cast.
1757 * xmenu.c (dialog_selection_callback): Likewise.
1758
ede49d71
PE
1759 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1760 Also, don't assume VALBITS / RAND_BITS is less than 5,
1761 and don't rely on undefined behavior when shifting a 1 left into
1762 the sign bit.
1763 * lisp.h (get_random): Change signature to match.
1764
2f30ecd0
PE
1765 * lread.c (hash_string): Use size_t, not int, for hash computation.
1766 Normally we prefer signed values; but hashing is special, because
1767 it's better to use unsigned division on hash table sizes so that
1768 the remainder is nonnegative. Also, size_t is the natural width
1769 for hashing into memory. The previous code used 'int', which doesn't
1770 retain enough info to hash well into very large tables.
1771 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1772
2a866e7b
PE
1773 * dbusbind.c: Don't possibly lose pointer info when converting.
1774 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1775 Use XPNTR rather than XHASH, so that the high-order bits of
1776 the pointer aren't lost when converting through void *.
1777
51639eac
PE
1778 * eval.c (Fautoload): Don't double-shift a pointer.
1779
92394119
PE
1780 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1781
dbdb9a7c
JB
17822011-05-06 Juanma Barranquero <lekktu@gmail.com>
1783
1784 * gnutls.c (DEF_GNUTLS_FN):
1785 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1786
db7a0b4f
AS
17872011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1788
1789 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1790 marker. (Bug#8610)
1791
f7ff1b0f 17922011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1793
1794 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1795 New version that can reserve upto 2GB of heap space.
1796
f7ff1b0f 17972011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1798
1799 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1800
639c109b
TZ
18012011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1802
1803 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1804 `gnutls_certificate_set_x509_key_file'.
1805
d2127135
JB
18062011-05-05 Juanma Barranquero <lekktu@gmail.com>
1807
1808 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1809 Update dependencies.
1810
e968f4f3
JB
18112011-05-04 Juanma Barranquero <lekktu@gmail.com>
1812
1813 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1814 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1815 Remove unused parameter `fildes'.
1816 * process.c (read_process_output, send_process): Don't pass it.
1817
84d358f0
JB
18182011-05-04 Juanma Barranquero <lekktu@gmail.com>
1819
1820 Fix previous change: the library cache is defined in w32.c.
1821 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1822 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1823
0898ca10
JB
18242011-05-04 Juanma Barranquero <lekktu@gmail.com>
1825
1826 Implement dynamic loading of GnuTLS on Windows.
1827
1828 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1829 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1830 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1831 Declare.
1832
1833 * gnutls.c (Qgnutls_dll): Define.
1834 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1835 (gnutls_*): Declare function pointers.
1836 (init_gnutls_functions): New function to initialize function pointers.
1837 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1838 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1839 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1840 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1841 (emacs_gnutls_write, emacs_gnutls_read)
1842 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1843 (Fgnutls_available_p): New function.
1844 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1845 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1846 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1847
1848 * image.c: Include w32.h.
1849 (Vimage_type_cache): Delete.
1850 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1851 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1852 (w32_delayed_load): Move to w32.c.
1853
1854 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1855
1856 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1857 (w32_delayed_load): Move from image.c. When loading a library, record
1858 its filename in the :loaded-from property of the library id.
1859 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1860 Initialize and staticpro them.
1861 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1862
1863 * process.c: Include lisp.h before w32.h, not after.
1864 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1865 instead of gnutls_record_check_pending.
1866
1867 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1868
ff4de4aa
TZ
18692011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1870
1871 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1872 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1873 as passed in.
1874
abe95abb
JD
18752011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1876
1877 * xterm.c (x_set_frame_alpha): Do not set property on anything
1878 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1879
e16e55d4
JB
18802011-05-02 Juanma Barranquero <lekktu@gmail.com>
1881
1882 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1883
bafcf6a5
JB
18842011-05-02 Juanma Barranquero <lekktu@gmail.com>
1885
1886 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1887 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1888 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1889 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1890 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1891 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1892 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1893 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1894 (Qgnutls_bootprop_callbacks_verify): Make static.
1895
e7a6747f
AS
18962011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1897
19ed11ba
AS
1898 * callproc.c: Indentation fixup.
1899
e7a6747f 1900 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1901 (wait_for_termination, interruptible_wait_for_termination):
1902 Move after wait_for_termination_1.
e7a6747f 1903
1ef14cb4
LMI
19042011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1905
1906 * sysdep.c (interruptible_wait_for_termination): New function
1907 which is like wait_for_termination, but allows keyboard
1908 interruptions.
1909
1910 * callproc.c (Fcall_process): Add (:file "file") as an option for
1911 the STDOUT buffer.
1912 (Fcall_process_region): Ditto.
1913
330d880c
EZ
19142011-04-30 Eli Zaretskii <eliz@gnu.org>
1915
8db90b73
EZ
1916 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1917 rather than `XVECTOR (FOO)->size'.
1918
330d880c
EZ
1919 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1920 inttypes.h, as a gnulib replacement is used if it not available in
1921 system headers.
1922
15cbd324
EZ
19232011-04-21 Eli Zaretskii <eliz@gnu.org>
1924
1925 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1926 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1927 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1928
1929 * coding.c (coding_alloc_by_realloc): Error out if destination
1930 will grow beyond MOST_POSITIVE_FIXNUM.
1931 (decode_coding_emacs_mule): Abort if there isn't enough place in
1932 charbuf for the composition carryover bytes. Reserve an extra
1933 space for up to 2 characters produced in a loop.
1934 (decode_coding_iso_2022): Abort if there isn't enough place in
1935 charbuf for the composition carryover bytes.
1936
19372011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1938
ae940cca
EZ
1939 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1940 aborting when %lld or %lll format is passed.
1941 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1942 %llo or %llx format is passed. (Bug#8545)
1943
03ab8921
EZ
1944 * window.c (window_scroll_line_based): Use a marker instead of
1945 simple variables to record original value of point. (Bug#7952)
1946
afda1437
EZ
1947 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1948 produced by %s or %c overflows available buffer space. (Bug#8545)
1949
f76dee0c
PE
19502011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1951
1952 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1953 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1954
fdc5744d
JB
19552011-04-28 Juanma Barranquero <lekktu@gmail.com>
1956
1957 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1958
638f053a
JB
19592011-04-28 Juanma Barranquero <lekktu@gmail.com>
1960
1961 * keyboard.c (Qdelayed_warnings_hook): Define.
1962 (command_loop_1): Run `delayed-warnings-hook'
1963 if Vdelayed_warnings_list is non-nil.
1964 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1965 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1966
d178f871
EZ
19672011-04-28 Eli Zaretskii <eliz@gnu.org>
1968
1969 * doprnt.c (doprnt): Don't return value smaller than the buffer
1970 size if the message was truncated. (Bug#8545).
1971
b124fd93
JB
19722011-04-28 Juanma Barranquero <lekktu@gmail.com>
1973
1974 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1975 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1976
e810457d
PE
19772011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1978
1979 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1980
ea51cceb
JB
19812011-04-27 Juanma Barranquero <lekktu@gmail.com>
1982
1983 * makefile.w32-in: Update dependencies.
1984
94dcfacf
EZ
19852011-04-27 Eli Zaretskii <eliz@gnu.org>
1986
1987 Improve `doprnt' and its usage. (Bug#8545)
1988 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1989 `format_end'. Remove support for %l as a conversion specifier.
1990 Don't use xrealloc. Improve diagnostics when the %l size modifier
1991 is used. Update the commentary.
1992
1993 * eval.c (verror): Simplify calculation of size_t.
1994
1995 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1996 messages.
1997
f61f41d7
PE
19982011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1999
2000 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2001 change.
2002
96fb4434
PE
20032011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2004
2005 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2006 This makes this file independent of the recent pseudovector change.
2007
671875da 20082011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2009
69e9b5a3
PE
2010 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2011
b5f869a7 2012 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2013 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2014 Remove unused local.
c8926152 2015 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2016
841a1577 2017 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2018 GCC 4.6.0 optimizes based on type-based alias analysis.
2019 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2020 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2021 != &v->size, and therefore "v->size = 1; b->size = 2; return
2022 v->size;" must therefore return 1. This assumption is incorrect
2023 for Emacs, since it type-puns struct Lisp_Vector * with many other
2024 types. To fix this problem, this patch adds a new type struct
f904488f 2025 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2026 and pseudovectors, and helps optimizing compilers not get fooled
2027 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2028 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2029 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2030 the size member.
eab3844f
PE
2031 (XSETPVECTYPE): Rewrite in terms of new macro.
2032 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2033 This is a bit clearer, and further avoids the possibility of
2034 undesirable aliasing.
2035 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2036 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2037 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2038 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2039 (ASIZE): Now uses header.size rather than size.
2040 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2041 to avoid the hassle of writing XVECTOR (foo)->header.size.
2042 (struct vectorlike_header): New type.
eab3844f
PE
2043 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2044 object, to help avoid aliasing.
2045 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2046 (SUBRP): Likewise, since Lisp_Subr is a special case.
2047 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2048 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2049 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2050 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2051 changed to be "header.size" and "header.next".
2052 * buffer.h (struct buffer): Likewise.
2053 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2054 * frame.h (struct frame): Likewise.
2055 * process.h (struct Lisp_Process): Likewise.
2056 * termhooks.h (struct terminal): Likewise.
2057 * window.c (struct save_window_data, struct saved_window): Likewise.
2058 * window.h (struct window): Likewise.
2059 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2060 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2061 * buffer.c (init_buffer_once): Likewise.
2062 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2063 special case.
2064 * process.c (Fformat_network_address): Use local var for size,
2065 for brevity.
2066
0df1eac5
PE
2067 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2068
847ab9d1 2069 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2070 * data.c (atof): Remove decl; no longer used or needed.
2071 (digit_to_number): Move to lread.c.
2072 (Fstring_to_number): Use new string_to_number function, to be
2073 consistent with how the Lisp reader treats infinities and NaNs.
2074 Do not assume that floating-point numbers represent EMACS_INT
2075 without losing information; this is not true on most 64-bit hosts.
2076 Avoid double-rounding errors, by insisting on integers when
2077 parsing non-base-10 numbers, as the documentation specifies.
2078 * lisp.h (string_to_number): New decl, replacing ...
2079 (isfloat_string): Remove.
bc0a5c13 2080 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2081 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2082 appears to have been a coding error. Similarly, do not accept
2083 strings like +-1e0 as floating point numbers. Do not report
2084 overflow for integer overflows unless the base is not 10 which
2085 means we have no simple and reliable way to continue.
2086 Break out the floating-point parsing into a new
2087 function string_to_number, so that Fstring_to_number parses
2088 floating point numbers consistently with the Lisp reader.
04f2d78b 2089 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2090 (E_CHAR, EXP_INT): Remove, replacing with ...
2091 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2092 (string_to_number): New function, replacing isfloat_string.
2093 This function checks for valid syntax and produces the resulting
2094 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2095 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2096 so that overflow for non-base-10 numbers is reported only when
2097 there's no portable and simple way to convert to floating point.
452f4150 2098
67769ffc
PE
2099 * textprop.c (set_text_properties_1): Rewrite for clarity,
2100 and to avoid GCC warning about integer overflow.
2101
c20db43f
PE
2102 * intervals.h (struct interval): Use EMACS_INT for members
2103 where EMACS_UINT might cause problems. See
2104 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2105 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2106 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2107 All uses changed.
37aa2f85
PE
2108 (offset_intervals): Tell GCC not to worry about length overflow
2109 when negating a negative length.
c20db43f 2110
2538aa2f
PE
2111 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2112 (overrun_check_free): Likewise.
2113
f2d3008d
PE
2114 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2115 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2116 word size.
2117
ec8df744
PE
2118 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2119 (gnutls_make_error): Rename local to avoid shadowing.
2120 (gnutls_emacs_global_deinit): ifdef out; not used.
2121 (Fgnutls_boot): Use const for pointer to readonly storage.
2122 Comment out unused local. Fix pointer signedness problems.
2123
640ee02d
PE
2124 * lread.c (openp): Don't stuff size_t into an 'int'.
2125 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2126 about possible signed overflow.
2127
6048fb2a
PE
2128 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2129 (GDK_KEY_g): Don't define if already defined.
2130 (xg_prepare_tooltip): Avoid pointer signedness problem.
2131 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2132
fa3c87e1
PE
2133 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2134 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2135
2172544b
PE
2136 * xfns.c (Fx_window_property): Simplify a bit,
2137 to make a bit faster and to avoid GCC 4.6.0 warning.
2138 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2139
9b821a21
PE
2140 * fns.c (internal_equal): Don't assume size_t fits in int.
2141
3c616cfa
PE
2142 * alloc.c (compact_small_strings): Tighten assertion a little.
2143
c2982e87
PE
2144 Replace pEd with more-general pI, and fix some printf arg casts.
2145 * lisp.h (pI): New macro, generalizing old pEd macro to other
2146 conversion specifiers. For example, use "...%"pI"d..." rather
2147 than "...%"pEd"...".
2148 (pEd): Remove. All uses replaced with similar uses of pI.
2149 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2150 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2151 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2152 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2153 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2154 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2155 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2156 64-bit hosts.
2157 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2158 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2159 * print.c (safe_debug_print, print_object): Likewise.
2160 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2161 to int.
6f04d126
PE
2162 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2163 avoiding the 0 flag, which is not portable.
c2982e87
PE
2164 * process.c (Fmake_network_process): Use pI to avoid cast.
2165 * region-cache.c (pp_cache): Likewise.
2166 * xdisp.c (decode_mode_spec): Likewise.
2167 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2168 behavior on 64-bit hosts with printf arg.
6f04d126 2169 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2170 (x_stop_queuing_selection_requests): Likewise.
2171 (x_get_window_property): Don't truncate byte count to an 'int'
2172 when tracing.
0b432f21 2173
5e073ec7
PE
2174 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2175 here, since it parses constructs like leading '-' and spaces,
2176 which are not wanted; and it overflows with large numbers.
2177 Instead, simply match F[0-9]+, which is what is wanted anyway.
2178
36372bf9
PE
2179 * alloc.c: Remove unportable assumptions about struct layout.
2180 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2181 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2182 (allocate_vectorlike, make_pure_vector): Use the new macros,
2183 plus offsetof, to remove unportable assumptions about struct layout.
2184 These assumptions hold on all porting targets that I know of, but
2185 they are not guaranteed, they're easy to remove, and removing them
2186 makes further changes easier.
2187
0b432f21
PE
2188 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2189 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2190 (string_overrun_cookie): Now const. Use initializers that
2191 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2192 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2193 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2194 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2195 multiple of sizeof (EMACS_INT); it need not be, if
2196 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2197 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2198
895009e1
JB
21992011-04-26 Juanma Barranquero <lekktu@gmail.com>
2200
2201 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2202
6a7a1b0b
TZ
22032011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2204
2205 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2206 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2207 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2208
841a1577 22092011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2210
2211 * lisp.h (Qdebug): List symbol.
895009e1 2212 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2213 * keyboard.c (debug-on-event): New variable.
2214 (handle_user_signal): Break into debugger when debug-on-event
2215 matches the current signal symbol.
2216
f2d3ba6f
DN
22172011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2218
2219 * alloc.c (check_sblock, check_string_bytes)
2220 (check_string_free_list): Convert to standard C.
2221
42ce4c63
TZ
22222011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2223
2224 * w32.c (emacs_gnutls_push): Fix typo.
2225
825cd63c
EZ
22262011-04-25 Eli Zaretskii <eliz@gnu.org>
2227
fb11d64d
EZ
2228 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2229 "cast to pointer from integer of different size".
2230
825cd63c
EZ
2231 Improve doprnt and its use in verror. (Bug#8545)
2232 * doprnt.c (doprnt): Document the set of format control sequences
2233 supported by the function. Use SAFE_ALLOCA instead of always
2234 using `alloca'.
2235
2236 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2237 is one byte too soon. Don't use xrealloc; instead xfree and
2238 xmalloc anew.
2239
e061a11b
TZ
22402011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2241
2242 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2243 callbacks stage.
2244
2245 * gnutls.c: Renamed global_initialized to
2246 gnutls_global_initialized. Added internals for the
2247 :verify-hostname-error, :verify-error, and :verify-flags
2248 parameters of `gnutls-boot' and documented those parameters in the
2249 docstring. Start callback support.
2250 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2251 unless a fatal error occured. Call gnutls_alert_send_appropriate
2252 on error. Return error code.
2253 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2254 (emacs_gnutls_read): Likewise.
2255 (Fgnutls_boot): Return handshake error code.
2256 (emacs_gnutls_handle_error): New function.
2257 (wsaerror_to_errno): Likewise.
2258
2259 * w32.h (emacs_gnutls_pull): Add prototype.
2260 (emacs_gnutls_push): Likewise.
2261
2262 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2263 (emacs_gnutls_push): Likewise.
2264
22652011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2266
2267 * process.c (wait_reading_process_output): Check if GnuTLS
2268 buffered some data internally if no FDs are set for TLS
2269 connections.
2270
2271 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2272 (LIBS): Link to USER_LIBS.
2273 ($(BLD)/gnutls.$(0)): New target.
2274
fa6996bc
EZ
22752011-04-24 Eli Zaretskii <eliz@gnu.org>
2276
eb35682e
EZ
2277 * xdisp.c (handle_single_display_spec): Rename the
2278 display_replaced_before_p argument into display_replaced_p, to
2279 make it consistent with the commentary. Fix typos in the
2280 commentary.
2281
e2ad650c
EZ
2282 * textprop.c (syms_of_textprop): Remove dead code.
2283 (copy_text_properties): Delete obsolete commentary about an
2284 interface that was deleted long ago. Fix typos in the description
2285 of arguments.
2286
1b2de274
EZ
2287 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2288 to changes in oldXMenu/XMenu.h from 2011-04-16.
2289 <menu_help_message, prev_menu_help_message>: Constify.
2290 (IT_menu_make_room): menu->help_text is now `const char **';
2291 adjust.
2292
2293 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2294 to changes in oldXMenu/XMenu.h from 2011-04-16.
2295 (struct XMenu): Declare `help_text' `const char **'.
2296
2297 * xfaces.c <Qunspecified>: Make extern again.
2298
2299 * syntax.c: Include sys/types.h before including regex.h, as
2300 required by Posix.
2301
762b15be
EZ
2302 * doc.c (get_doc_string): Improve the format passed to `error'.
2303
2304 * doprnt.c (doprnt): Improve commentary.
2305
2306 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2307
2308 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2309 them with etags.
2310
f1052e5d
EZ
2311 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2312 changes in globals.h immediately force recompilation.
762b15be
EZ
2313 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2314 $(CURDIR)/s/ms-w32.h.
2315 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2316
fa6996bc
EZ
2317 * character.c (Fchar_direction): Function deleted.
2318 (syms_of_character): Don't defsubr it.
2319 <char-direction-table>: Deleted.
2320
e6c3da20
EZ
23212011-04-23 Eli Zaretskii <eliz@gnu.org>
2322
2323 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2324 * doprnt.c: Include limits.h.
2325 (SIZE_MAX): New macro.
04f2d78b
CB
2326 (doprnt): Return a size_t value. 2nd arg is now size_t.
2327 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2328 Improve overflow protection. Support `l' modifier for integer
2329 conversions. Support %l conversion. Don't assume an EMACS_INT
2330 argument for integer conversions and for %c.
2331
2332 * lisp.h (doprnt): Restore prototype.
2333
2334 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2335 $(SRC)/character.h.
2336
2337 * Makefile.in (base_obj): Add back doprnt.o.
2338
2339 * deps.mk (doprnt.o): Add back prerequisites.
2340 (callint.o): Depend on character.h.
2341
2342 * eval.c (internal_lisp_condition_case): Include the handler
2343 representation in the error message.
2344 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2345 when breaking from the loop.
2346
2347 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2348
2349 * callint.c (Fcall_interactively): When displaying error message
2350 about invalid control letter, pass the character's codepoint, not
2351 a pointer to its multibyte form. Improve display of the character
2352 in octal and display also its hex code.
2353
2354 * character.c (char_string): Use %x to display the (unsigned)
2355 codepoint of an invalid character, to avoid displaying a bogus
2356 negative value.
2357
2358 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2359 `error', not SYMBOL_NAME itself.
2360
2361 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2362 character arguments to `error'.
2363
2364 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2365 to `error' in error message about FINAL_CHAR argument. Make sure
2366 FINAL_CHAR is a character, and use %c when it is passed as
2367 argument to `error'.
2368
4ffd0d6b 23692011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2370
2371 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2372
2373 * w32.c: Include <time.h>.
2374 (sys_localtime): New function.
2375
4ffd0d6b 23762011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2377
2378 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2379
4ffd0d6b 2380 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2381
4ffd0d6b 23822011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2383
4ffd0d6b
GM
2384 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2385 zombies (Bug#8467).
aac0c6e3 2386
04c56954
EZ
23872011-04-19 Eli Zaretskii <eliz@gnu.org>
2388
2389 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2390 gl_state.e_property when gl_state.object is Qt.
2391
2392 * insdel.c (make_gap_larger): Remove limitation of buffer size
2393 to <= INT_MAX.
2394
16a43933
CY
23952011-04-18 Chong Yidong <cyd@stupidchicken.com>
2396
2397 * xdisp.c (lookup_glyphless_char_display)
2398 (produce_glyphless_glyph): Handle cons cell entry in
2399 glyphless-char-display.
2400 (Vglyphless_char_display): Document it.
2401
2402 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2403 glyphless-char-display.
2404
4581706e
CY
24052011-04-17 Chong Yidong <cyd@stupidchicken.com>
2406
2407 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2408
2409 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2410
2411 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2412 definition for no-X builds.
2413
4887c6e2 24142011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2415
fd35b6f9
PE
2416 Static checks with GCC 4.6.0 and non-default toolkits.
2417
5c1ccb01
PE
2418 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2419
006c5daa
PE
2420 * process.c (keyboard_bit_set): Define only if SIGIO.
2421 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2422 (send_process): Repair possible setjmp clobbering.
2423
efc736d3
PE
2424 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2425
4e2fe2e6
PE
2426 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2427
f97334a2
PE
2428 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2429
4e75f29d
PE
2430 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2431 Define only if needed.
2432
90efadd1
PE
2433 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2434 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2435 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2436
3c647824
PE
2437 * dispextern.h (struct redisplay_interface): Rename param
2438 to avoid shadowing.
e264f262 2439 * termhooks.h (struct terminal): Likewise.
761383f4 2440 * xterm.c (xembed_send_message): Likewise.
3c647824 2441
b58c5c4a
PE
2442 * insdel.c (make_gap_smaller): Define only if
2443 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2444
cad59032
PE
2445 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2446 it.
2447
c339dc2e
PE
2448 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2449 so that we aren't warned about unused symbols.
2450
91a3e27b
PE
2451 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2452
399c71d3 2453 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2454
8ffc96f5
PE
2455 * xfns.c (x_real_positions): Mark locals as initialized.
2456
eef9bc79
PE
2457 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2458
098db9dd
PE
2459 * xterm.c: Fix problems found by static analysis with other toolkits.
2460 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2461 (x_dispatch_event): Declare static if USE_GTK, and
2462 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2463 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2464 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2465 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2466 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2467
eb18f6cc
PE
2468 * xmenu.c (menu_help_callback): Pointer type fixes.
2469 Use const pointers when pointing at readonly data. Avoid pointer
2470 signedness clashes.
2471 (FALSE): Remove unused macro.
2472 (update_frame_menubar): Remove unused decl.
2473
1fe72bf8
PE
2474 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2475
60d9e1db
PE
2476 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2477 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2478 (single_menu_item): Rename local to avoid shadowing.
2479
39261c26
PE
2480 * keyboard.c (make_lispy_event): Remove unused local var.
2481
018c5e19
PE
2482 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2483 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2484
63d2b86e
PE
2485 * bitmaps: Change bitmaps from unsigned char back to the X11
2486 compatible char. Avoid the old compiler warnings about
2487 out-of-range initializers by using, for example, '\xab' rather
2488 than 0xab.
2489
aefd87e1
PE
2490 * xgselect.c (xgselect_initialize): Check vs interface
2491 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2492
bf501fb9
PE
2493 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2494
e9829fdf
PE
2495 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2496 to read-only memory.
2497
1086c095
PE
2498 * fns.c (vector): Remove; this old hack is no longer needed.
2499
2baccd04 2500 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2501 Remove unused var.
dde42981 2502 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2503
72391843 2504 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2505
436c16df 2506 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2507 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2508 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2509
92bb796d 2510 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2511 (x_term_init): Remove local to avoid shadowing.
92bb796d 2512
764430a3 2513 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2514
2515 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2516 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2517
d1dfb56c
EZ
25182011-04-16 Eli Zaretskii <eliz@gnu.org>
2519
c4354cb4
EZ
2520 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2521
d1dfb56c
EZ
2522 Fix regex.c, syntax.c and friends for buffers > 2GB.
2523 * syntax.h (struct gl_state_s): Declare character position members
2524 EMACS_INT.
2525
2526 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2527
04f2d78b
CB
2528 * textprop.c (verify_interval_modification, interval_of):
2529 Declare arguments EMACS_INT.
d1dfb56c
EZ
2530
2531 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2532 EMACS_INT.
2533
2534 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2535
2536 * indent.c (Fvertical_motion): Local variable it_start is now
2537 EMACS_INT.
2538
2539 * regex.c (re_match, re_match_2, re_match_2_internal)
2540 (bcmp_translate, regcomp, regexec, print_double_string)
2541 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2542 (re_compile_pattern, re_exec): Declare arguments and local
2543 variables `size_t' and `ssize_t' and return values `regoff_t', as
2544 appropriate.
2545 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2546 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2547 <compile_stack_type>: `size' and `avail' are now `size_t'.
2548
2549 * regex.h <regoff_t>: Use ssize_t, not int.
2550 (re_search, re_search_2, re_match, re_match_2): Arguments that
2551 specify buffer/string position and length are now ssize_t and
2552 size_t. Return type is regoff_t.
2553
613052cd
BK
25542011-04-16 Ben Key <bkey76@gmail.com>
2555
2556 * nsfont.m: Fixed bugs in ns_get_family and
2557 ns_descriptor_to_entity that were caused by using free to
2558 deallocate memory blocks that were allocated by xmalloc (via
2559 xstrdup). This caused Emacs to crash when compiled with
2560 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2561 --enable-checking=xmallocoverrun). xfree is now used to
2562 deallocate these memory blocks.
2563
4170f62f 25642011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2565
71b41406
PE
2566 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2567
9587a89d
PE
2568 emacs_write: Accept and return EMACS_INT for sizes.
2569 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2570 et seq.
2571 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2572 Accept and return EMACS_INT.
2573 (emacs_gnutls_write): Return the number of bytes written on
2574 partial writes.
2575 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2576 (emacs_read, emacs_write): Remove check for negative size, as the
2577 Emacs source code has been audited now.
9587a89d
PE
2578 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2579 (emacs_read, emacs_write): Use it.
273a5f82
PE
2580 * process.c (send_process): Adjust to the new signatures of
2581 emacs_write and emacs_gnutls_write. Do not attempt to store
2582 a byte offset into an 'int'; it might overflow.
9587a89d 2583 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2584
3e047f51
PE
2585 * sound.c: Don't assume sizes fit in 'int'.
2586 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2587 Return EMACS_INT, not int.
3e047f51 2588 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2589 Accept EMACS_INT, not int.
2590 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2591 record read return values.
2592
cc39a9db
BK
25932011-04-15 Ben Key <bkey76@gmail.com>
2594
c9d0ec6d
JB
2595 * keyboard.c (Qundefined): Don't declare static since it is used
2596 in nsfns.m.
2597 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2598 static since they are used in nsfont.m.
cc39a9db 2599
6c60eb9f
SM
26002011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2601
2602 * process.c (Qprocessp): Don't declare static.
2603 * lisp.h (Qprocessp): Declare again.
2604
7990b61a
JB
26052011-04-15 Juanma Barranquero <lekktu@gmail.com>
2606
2607 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2608
5d4cb038
PE
26092011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2610
8bd7b830 2611 Improve C-level modularity by making more things 'static'.
cd64ea1d 2612
e3b27b31
PE
2613 Don't publish debugger-only interfaces to other modules.
2614 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2615 (verify_bytepos, count_markers): Move decls to the only modules
2616 that need them.
2617 * region-cache.h (pp_cache): Likewise.
2618 * window.h (check_all_windows): Likewise.
2619 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2620
5d4cb038
PE
2621 * sysdep.c (croak): Now static, if
2622 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2623 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2624
2625 * alloc.c (refill_memory_reserve): Now static if
2626 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2627 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2628
e87b6180
PE
2629 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2630 Define only if USE_LUCID.
2631
ac64929e
PE
2632 * xrdb.c (x_customization_string, x_rm_string): Now static.
2633
6f37259d
PE
2634 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2635 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2636
1683e3ab
PE
2637 * xdisp.c (draw_row_with_mouse_face): Now static.
2638 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2639
de9c2632
PE
2640 * window.h (check_all_windows): Mark externally visible.
2641
2b96acb7
PE
2642 * window.c (window_deletion_count): Now static.
2643
2644 * undo.c: Make symbols static if they're not exported.
2645 (last_undo_buffer, last_boundary_position, pending_boundary):
2646 Now static.
2647
50436f33
PE
2648 * textprop.c (interval_insert_behind_hooks): Now static.
2649 (interval_insert_in_front_hooks): Likewise.
2650
64520e5c
PE
2651 * term.c: Make symbols static if they're not exported.
2652 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2653 (max_frame_lines, tty_set_terminal_modes):
2654 (tty_reset_terminal_modes, tty_turn_off_highlight):
2655 (get_tty_terminal): Now static.
2656 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2657 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2658 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2659 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2660 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2661
1fa53021
PE
2662 * sysdep.c: Make symbols static if they're not exported.
2663 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2664 Now static.
2665 (sigprocmask_set, full_mask): Remove; unused.
2666 (wait_debugging): Mark as visible.
2667 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2668 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2669
d4b43b22
PE
2670 * syntax.c (syntax_temp): Define only if !__GNUC__.
2671
b7c513d0
PE
2672 * sound.c (current_sound_device, current_sound): Now static.
2673
989b29ad
PE
2674 * search.c (searchbufs, searchbuf_head): Now static.
2675
13a55a78
PE
2676 * scroll.c (scroll_cost): Remove; unused.
2677 * dispextern.h (scroll_cost): Remove decl.
2678
de68a1fc
PE
2679 * region-cache.h (pp_cache): Mark as externally visible.
2680
40ccffa6
PE
2681 * process.c: Make symbols static if they're not exported.
2682 (process_tick, update_tick, create_process, chan_process):
2683 (Vprocess_alist, proc_buffered_char, datagram_access):
2684 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2685 (deactivate_process): Mark defn as static, as well as decl.
2686 * lisp.h (create_process): Remove decl.
2687 * process.h (chan_process, Vprocess_alist): Remove decls.
2688
ad64fc97
PE
2689 * print.c: Make symbols static if they're not exported.
2690 (print_depth, new_backquote_output, being_printed, print_buffer):
2691 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2692 (print_interval, print_number_index, initial_stderr_stream):
2693 Now static.
2694 * lisp.h (Fprinc): Remove decl.
2695 (debug_output_compilation_hack): Mark as externally visible.
2696
adddb265
PE
2697 * sysdep.c (croak): Move decl from here to syssignal.h.
2698 * syssignal.h (croak): Put it here, so the API can be checked when
2699 'croak' is called from dissociate_if_controlling_tty.
2700
1717ede2
PE
2701 * minibuf.c: Make symbols static if they're not exported.
2702 (minibuf_save_list, choose_minibuf_frame): Now static.
2703 * lisp.h (choose_minibuf_frame): Remove decl.
2704
fa5fb2bc
PE
2705 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2706
1e3890d1
PE
2707 * lread.c: Make symbols static if they're not exported.
2708 (read_objects, initial_obarray, oblookup_last_bucket_number):
2709 Now static.
2710 (make_symbol): Remove; unused.
2711 * lisp.h (initial_obarray, make_symbol): Remove decls.
2712
8a1414fa
PE
2713 * keyboard.c: Make symbols static if they're not exported.
2714 (single_kboard, recent_keys_index, total_keys, recent_keys):
2715 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2716 (this_single_command_key_start, echoing, last_auto_save):
2717 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2718 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2719 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2720 (Vlispy_mouse_stem, double_click_count):
2721 Now static.
2722 (force_auto_save_soon): Define only if SIGDANGER.
2723 (ignore_mouse_drag_p): Now static if
2724 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2725 (print_help): Remove; unused.
2726 (stop_character, last_timer_event): Mark as externally visible.
2727 * keyboard.h (ignore_mouse_drag_p): Declare only if
2728 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2729 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2730 * lisp.h (echoing): Remove decl.
2731 (force_auto_save_soon): Declare only if SIGDANGER.
2732 * xdisp.c (redisplay_window): Simplify code, to make it more
2733 obvious that ignore_mouse_drag_p is not accessed if !defined
2734 USE_GTK && !defined HAVE_NS.
2735
93ea6e8f
PE
2736 * intervals.c: Make symbols static if they're not exported.
2737 (merge_properties_sticky, merge_interval_right, delete_interval):
2738 Now static.
2739 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2740
77382fcc
PE
2741 * insdel.c: Make symbols static if they're not exported.
2742 However, leave prepare_to_modify_buffer alone. It's never
2743 called from outside this function, but that appears to be a bug.
2744 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2745 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2746 (adjust_after_replace_noundo): Remove; unused.
2747 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2748 (signal_before_change): Remove decls.
77382fcc 2749
9306c32e
PE
2750 * indent.c (val_compute_motion, val_vmotion): Now static.
2751
cd44d2eb
PE
2752 * image.c: Make symbols static if they're not exported.
2753 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2754 if USE_GTK.
2755 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2756 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2757
ad9a7a06
PE
2758 * fringe.c (standard_bitmaps): Now static.
2759 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2760
81626931
PE
2761 * frame.c: Make symbols static if they're not exported.
2762 (x_report_frame_params, make_terminal_frame): Now static.
2763 (get_frame_param): Now static, unless HAVE_NS.
2764 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2765 (x_get_resource_string): Remove; not used.
2766 * frame.h (make_terminal_frame, x_report_frame_params):
2767 (x_get_resource_string); Remove decls.
2768 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2769 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2770
239f9db9
PE
2771 * font.c, fontset.c: Make symbols static if they're not exported.
2772 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2773 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2774 * font.c (font_close_object): Now static.
2775 * font.h (font_close_object): Remove.
2776 * fontset.c (FONTSET_OBJLIST): Remove.
2777 (free_realized_fontset) #if-0 the body, which does nothing.
2778 (face_suitable_for_char_p): #if-0, as it's never called.
2779 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2780 * xfaces.c (face_at_string_position):
2781 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2782 since 0 is always ASCII.
2783
dfcf3579
PE
2784 * fns.c (weak_hash_tables): Now static.
2785
5045092b
PE
2786 * fileio.c: Make symbols static if they're not exported.
2787 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2788 (Vwrite_region_annotation_buffers): Now static.
2789
57a96f5c
PE
2790 * eval.c: Make symbols static if they're not exported.
2791 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2792 * lisp.h (backtrace_list): Remove decl.
2793
35f08c38
PE
2794 * emacs.c: Make symbols static if they're not exported.
2795 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2796 (fatal_error_code, fatal_error_signal_hook, standard_args):
2797 Now static.
2798 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2799 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2800 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2801 * lisp.h (fatal_error_signal_hook): Remove decl.
2802 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2803
f44bd759
PE
2804 * editfns.c: Move a (normally-unused) function to its only use.
2805 * editfns.c, lisp.h (get_operating_system_release): Remove.
2806 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2807 worth the hassle of breaking this out.
2808
b532497d
PE
2809 * xterm.c: Make symbols static if they're not exported.
2810 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2811 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2812 (x_destroy_window, x_delete_display):
2813 Now static.
2814 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2815 (x_mouse_leave): Remove; unused.
2816 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2817 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2818 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2819 Remove decls.
2820 (x_mouse_leave): Declare only if WINDOWSNT.
2821 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2822 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2823 USE_X_TOOLKIT.
2824
1675728f
PE
2825 * ftxfont.c: Make symbols static if they're not exported.
2826 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2827 HAVE_FREETYPE.
2828 * font.h (ftxfont_driver): Likewise.
2829
e4cebfca
PE
2830 * xfns.c: Make symbols static if they're not exported.
2831 (x_last_font_name, x_display_info_for_name):
2832 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2833 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2834 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2835 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2836 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2837 (last_show_tip_args): Now static.
2838 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2839 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2840 (x_screen_planes): Remove; unused.
2841 * dispextern.h (x_screen_planes): Remove decl.
2842
5bf46f05
PE
2843 * dispnew.c: Make symbols static if they're not exported.
2844 * dispextern.h (redraw_garbaged_frames, scrolling):
2845 (increment_row_positions): Remove.
2846 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2847 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2848 Now static.
2849 (redraw_garbaged_frames): Remove; unused.
2850
435f4c28
PE
2851 * xfaces.c: Make symbols static if they're not exported.
2852 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2853 Remove decls.
2854 * xterm.h (defined_color): Remove decls.
2855 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2856 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2857 (menu_face_changed_default, defined_color, free_realized_face):
2858 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2859 (ascii_face_of_lisp_face): Remove; unused.
2860
8524aef3
PE
2861 * xdisp.c: Make symbols static if they're not exported.
2862 * dispextern.h (scratch_glyph_row, window_box_edges):
2863 (glyph_to_pixel_coords, set_cursor_from_row):
2864 (get_next_display_element, set_iterator_to_next):
2865 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2866 (show_mouse_face): Remove decls
2867 * frame.h (message_buf_print): Likewise.
2868 * lisp.h (pop_message, set_message, check_point_in_composition):
2869 Likewise.
2870 * xterm.h (set_vertical_scroll_bar): Likewise.
2871 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2872 (message_buf_print, scratch_glyph_row, displayed_buffer):
2873 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2874 (get_next_display_element, show_mouse_face, window_box_edges):
2875 (frame_to_window_pixel_xy, check_point_in_composition):
2876 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2877 (glyph_to_pixel_coords): Remove; unused.
2878
16390cd2
PE
2879 * dired.c (file_name_completion): Now static.
2880
2881 * dbusbind.c (xd_in_read_queued_messages): Now static.
2882
a25f4dfa
PE
2883 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2884 * data.c (circular_list_error): Remove.
2885
14a9c8df
PE
2886 * commands.h (last_point_position, last_point_position_buffer):
2887 (last_point_position_window): Remove decls.
2888 * keyboard.c: Make these variables static.
2889
04f2d78b
CB
2890 * coding.h (coding, code_convert_region, encode_coding_gap):
2891 Remove decls.
74ab6df5
PE
2892 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2893 (iso_code_class, detect_coding, code_convert_region): Now static.
2894 (encode_coding_gap): Remove; unused.
2895
38dfbee1
PE
2896 * chartab.c (chartab_chars, chartab_bits): Now static.
2897
a2cb4e63
PE
2898 * charset.h (charset_iso_8859_1): Remove decl.
2899 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2900 Now static.
2901
127198fd
PE
2902 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2903 * ccl.c (Vccl_program_table): Now static.
2904 (check_ccl_update): Remove; unused.
2905
d85b608f
PE
2906 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2907 * category.h: ... from here.
2908 * category.c (check_category_table, set_category_set): Now static.
2909
31cd66f3
PE
2910 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2911 * lisp.h: Remove these decls.
2912
c358e587
PE
2913 * buffer.c (buffer_count): Remove unused var.
2914
e78aecca
PE
2915 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2916 so that it's not optimized away.
2917 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2918 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2919 exported only to the debugger.
2920
e192d7d3 2921 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2922 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2923
92470028
PE
2924 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2925 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2926 was inaccessible from Lisp.
2927 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2928 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2929
244ed907
PE
2930 alloc.c: Import and export fewer symbols, and remove unused items.
2931 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2932 is defined.
2933 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2934 it's not optimized away by whole-program optimization.
2935 (message_enable_multibyte, free_misc): Remove.
2936 (catchlist, handlerlist, mark_backtrace):
2937 Declare only if BYTE_MARK_STACK.
2938 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2939 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2940 (message_enable_multibyte): Remove decl.
2941 (free_misc, interval_free_list, float_block, float_block_index):
2942 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2943 (cons_free_list, last_marked_index):
2944 Now static.
2945 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2946 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2947 (mark_backtrace): Define only if BYTE_MARK_STACK.
2948 * xdisp.c (message_enable_multibyte): Now static.
2949
61c2b50e 2950 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2951 This makes it easier for human readers (and static analyzers)
2952 to see whether these variables are used from other modules.
2953 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2954 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2955 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2956 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2957 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2958 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2959 * xmenu.c, xselect.c:
2960 Declare Q* vars static if they are not used in other modules.
2961 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2962 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2963 Remove decls of unexported vars.
2964 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2965
95c82688
PE
2966 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2967
16a97296
PE
2968 Make Emacs functions such as Fatom 'static' by default.
2969 This makes it easier for human readers (and static analyzers)
2970 to see whether these functions can be called from other modules.
2971 DEFUN now defines a static function. To make the function external
2972 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2973 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2974 (Finit_image_library):
16a97296
PE
2975 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2976 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2977 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2978 Remove decls, since these functions are now static.
2979 (Funintern, Fget_internal_run_time): New decls, since these functions
2980 were already external.
95c82688 2981
16a97296
PE
2982 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2983 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2984 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2985 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2986 * keyboard.c, keymap.c, lread.c:
2987 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2988 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2989 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2990 Mark functions with DEFUE instead of DEFUN,
2991 if they are used in other modules.
2992 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2993 decls for now-static functions.
2994 * buffer.h (Fdelete_overlay): Remove decl.
2995 * callproc.c (Fgetenv_internal): Mark as internal.
2996 * composite.c (Fremove_list_of_text_properties): Remove decl.
2997 (Fcomposition_get_gstring): New forward static decl.
2998 * composite.h (Fcomposite_get_gstring): Remove decl.
2999 * dired.c (Ffile_attributes): New forward static decl.
3000 * doc.c (Fdocumntation_property): New forward static decl.
3001 * eval.c (Ffetch_bytecode): New forward static decl.
3002 (Funintern): Remove extern decl; now in .h file where it belongs.
3003 * fileio.c (Fmake_symbolic_link): New forward static decl.
3004 * image.c (Finit_image_library): New forward static decl.
3005 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3006 * intervals.h (Fprevious_property_change):
3007 (Fremove_list_of_text_properties): Remove decls.
3008 * keyboard.c (Fthis_command_keys): Remove decl.
3009 (Fcommand_execute): New forward static decl.
3010 * keymap.c (Flookup_key): New forward static decl.
3011 (Fcopy_keymap): Now static.
3012 * keymap.h (Flookup_key): Remove decl.
3013 * process.c (Fget_process): New forward static decl.
3014 (Fprocess_datagram_address): Mark as internal.
3015 * syntax.c (Fsyntax_table_p): New forward static decl.
3016 (skip_chars): Remove duplicate decl.
3017 * textprop.c (Fprevious_property_change): New forward static decl.
3018 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3019 Now internal.
3020 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3021 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3022
785bbd42
PE
3023 * editfns.c (Fformat): Remove unreachable code.
3024
8b913b57
AS
30252011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3026
3027 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3028 change. (Bug#8496)
3029
a6744a35
EZ
30302011-04-13 Eli Zaretskii <eliz@gnu.org>
3031
3032 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3033 when at ZV. (Bug#8487)
3034
e7974947
AS
30352011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3036
baad03f0
AS
3037 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3038 (Bug#8437)
3039 * keyboard.c (parse_tool_bar_item): Likewise.
3040 * sound.c (sound_cleanup, alsa_close): Likewise.
3041 * termcap.c (tgetent): Likewise.
3042 * xfns.c (x_default_font_parameter): Likewise.
3043 * xsettings.c (read_and_apply_settings): Likewise.
3044
e7974947
AS
3045 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3046 (overrun_check_free): Protoize.
3047
28272684
PE
30482011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3049
3050 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3051 since callers should never pass a negative size.
3052 Change the signature to match that of plain 'read' and 'write'; see
3053 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3054 * lisp.h: Update prototypes of emacs_write and emacs_read.
3055
11997c76
EZ
30562011-04-11 Eli Zaretskii <eliz@gnu.org>
3057
3058 * xdisp.c (redisplay_window): Don't try to determine the character
3059 position of the scroll margin if the window start point w->startp
e896f03c 3060 is outside the buffer's accessible region. (Bug#8468)
11997c76 3061
8a2cbd72
EZ
30622011-04-10 Eli Zaretskii <eliz@gnu.org>
3063
3064 Fix write-region and its subroutines for buffers > 2GB.
3065 * fileio.c (a_write, e_write): Modify declaration of arguments and
3066 local variables to support buffers larger than 2GB.
3067 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3068
3069 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3070 argument, local variables, and return value.
3071
3072 * lisp.h: Update prototypes of emacs_write and emacs_read.
3073
3074 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3075
4073e537 30762011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3077
1ebfdcb6
PE
3078 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3079
b2ded58d
PE
3080 Fix more problems found by GCC 4.6.0's static checks.
3081
7d66342c
PE
3082 * xdisp.c (vmessage): Use a better test for character truncation.
3083
bbf47d44
PE
3084 * charset.c (load_charset_map): <, not <=, for optimization,
3085 and to avoid potential problems with integer overflow.
9248994d 3086 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3087 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3088 * editfns.c (Fformat): Likewise.
1e69125e 3089 * syntax.c (skip_chars): Likewise.
3befa583 3090
e3019616
PE
3091 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3092 This also lets GCC 4.6.0 generate slightly better loop code.
3093
becfa255
PE
3094 * callint.c (Fcall_interactively): <, not <=, for optimization.
3095 (Fcall_interactively): Count the number of arguments produced,
3096 not the number of arguments given. This is simpler and lets GCC
3097 4.6.0 generate slightly better code.
3098
dae0cd48
PE
3099 * ftfont.c: Distingish more carefully between FcChar8 and char.
3100 The previous code passed unsigned char * to a functions like
3101 strlen and xstrcasecmp that expect char *, which does not
3102 conform to the C standard.
3103 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3104 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3105 char * when the C standard requires it.
3106
76032d70
PE
3107 * keyboard.c (read_char): Remove unused var.
3108
eb3f1cc8
PE
3109 * eval.c: Port to Windows vsnprintf (Bug#8435).
3110 Include <limits.h>.
3111 (SIZE_MAX): Define if the headers do not.
3112 (verror): Do not give up if vsnprintf returns a negative count.
3113 Instead, grow the buffer. This ports to Windows vsnprintf, which
3114 does not conform to C99. Problem reported by Eli Zaretskii.
3115 Also, simplify the allocation scheme, by avoiding the need for
3116 calling realloc, and removing the ALLOCATED variable.
3117
70476b54
PE
3118 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3119
12020a9e
PE
3120 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3121 But keep the doprint source code for now, as we might revamp it
3122 and use it again (Bug#8435).
ea6c7ae6
PE
3123 * lisp.h (doprnt): Remove.
3124 * Makefile.in (base_obj): Remove doprnt.o.
3125 * deps.mk (doprnt.o): Remove.
3126
5fdb398c
PE
3127 error: Print 32- and 64-bit integers portably (Bug#8435).
3128 Without this change, on typical 64-bit hosts error ("...%d...", N)
3129 was used to print both 32- and 64-bit integers N, which relied on
3130 undefined behavior.
3131 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3132 New macro.
3133 * lisp.h (error, verror): Mark as printf-like functions.
3134 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3135 Report overflow in size calculations when allocating printf buffer.
3136 Do not truncate output string at its first null byte.
3137 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3138 Truncate the output at a character boundary, since vsnprintf does not
3139 do that.
3140 * charset.c (check_iso_charset_parameter): Convert internal
3141 character to string before calling 'error', since %c now has the
3142 printf meaning.
3143 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3144 overflow when computing char to be passed to 'error'. Do not
3145 pass Lisp_Object to 'error'; pass the integer instead.
3146 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3147 formatted with plain %d.
3148
b189fa66
PE
3149 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3150
bff87ef0
PE
3151 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3152
7e2cac20
PE
3153 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3154
ce4d90b5
PE
3155 * xterm.c (x_catch_errors): Remove duplicate declaration.
3156
266c9547
PE
3157 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3158
79c49ad2
PE
3159 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3160
368f4090
JM
31612011-04-10 Jim Meyering <meyering@redhat.com>
3162
3163 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3164 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3165 return ssize_t not "int", and use size_t as the buffer length.
3166 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3167 * gnutls.h: Update declarations.
3168 * process.c (read_process_output): Use ssize_t, to match.
3169 (send_process): Likewise.
3170
a32d4040
CY
31712011-04-09 Chong Yidong <cyd@stupidchicken.com>
3172
3173 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3174
8546720e 31752011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3176
04f2d78b
CB
3177 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3178 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3179
8546720e
GM
3180 * xterm.c (handle_one_xevent):
3181 * xmenu.c (create_and_show_popup_menu):
3182 * xselect.c (x_decline_selection_request)
3183 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3184
0a2f5c1a 31852011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3186
3187 Fix some uses of `int' instead of EMACS_INT.
3188 * search.c (string_match_1, fast_string_match)
3189 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3190 (scan_buffer, find_next_newline_no_quit)
3191 (find_before_next_newline, search_command, Freplace_match)
3192 (Fmatch_data): Make some `int' variables be EMACS_INT.
3193
3194 * xdisp.c (display_count_lines): 3rd argument and return value now
3195 EMACS_INT. All callers changed.
3196 (pint2hrstr): Last argument is now EMACS_INT.
3197
3198 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3199 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3200 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3201 (decode_coding_utf_16, decode_coding_emacs_mule)
3202 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3203 (decode_coding_ccl, decode_coding_charset)
3204 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3205 (decode_coding_iso_2022, decode_coding_emacs_mule)
3206 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3207 <char_offset, last_offset>: Declare EMACS_INT.
3208 (encode_coding_utf_8, encode_coding_utf_16)
3209 (encode_coding_emacs_mule, encode_invocation_designation)
3210 (encode_designation_at_bol, encode_coding_iso_2022)
3211 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3212 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3213 Declare EMACS_INT.
3214 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3215 (encode_invocation_designation): Last argument P_NCHARS is now
3216 EMACS_INT.
3217 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3218 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3219
3220 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3221 All users changed.
3222
3223 * ccl.c (Fccl_execute_on_string): Declare some variables
3224 EMACS_INT.
3225
8546720e 32262011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3227
3228 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3229
4e19a977
CS
32302011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3231
3232 * process.c (Fformat_network_address): Doc fix.
3233
87302331
R
32342011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3235
3236 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3237
cbb59342
CY
32382011-04-08 Chong Yidong <cyd@stupidchicken.com>
3239
3240 * keyboard.c (read_char): Call Lisp function help-form-show,
3241 instead of using internal_with_output_to_temp_buffer.
3242 (Qhelp_form_show): New var.
e0d38eeb 3243 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3244
3245 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3246
3247 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3248
e67a13ab
CY
32492011-04-06 Chong Yidong <cyd@stupidchicken.com>
3250
04f2d78b
CB
3251 * process.c (Flist_processes): Remove to Lisp.
3252 (list_processes_1): Delete.
e67a13ab 3253
973f782d
EZ
32542011-04-06 Eli Zaretskii <eliz@gnu.org>
3255
7c106b1e
EZ
3256 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3257
973f782d
EZ
3258 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3259
41cf7d1a 32602011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3261
ca23cc88
PE
3262 Fix more problems found by GCC 4.6.0's static checks.
3263
f390e2d5
PE
3264 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3265
42eea0d0
PE
3266 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3267
b69769da 3268 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3269
f9541e84
PE
3270 * xdisp.c (vmessage): Mark as a printf-like function.
3271
13841b55
PE
3272 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3273
c136c10f
PE
3274 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3275
5e2d4a30
PE
3276 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3277 printf-like functions.
3278 (tiff_load): Add casts to remove these marks before passing them
3279 to system-supplied API.
3280
583f48b9
PE
3281 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3282
b25d760e
PE
3283 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3284 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3285 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3286 directly, rather than having caller test rule sign. This avoids
3287 some unnecessary tests.
3288 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3289 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3290 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3291
bc7b6697 3292 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3293 (xfont_open): Avoid unnecessary tests.
bc7b6697 3294
27ccc379
PE
3295 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3296
dcd5c89a
PE
3297 * composite.h, composite.c (composition_gstring_put_cache):
3298 Use EMACS_INT, not int, for length.
3299
b13a45c6
PE
3300 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3301 breaking out part of COMPOSITION_DECODE_RULE.
3302 (COMPOSITION_DECODE_RULE): Use it.
3303 * composite.c (get_composition_id): Remove unused local vars,
3304 by using the new macro.
3305
1e792e4d
PE
3306 * textprop.c (set_text_properties_1): Change while to do-while,
3307 since the condition is always true at first.
3308
dc6c6455 3309 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3310 (interval_deletion_adjustment): Return unsigned value.
3311 All uses changed.
dc6c6455 3312
aba7731a
PE
3313 * process.c (list_processes_1, create_pty, read_process_output):
3314 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3315 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3316 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3317 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3318 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3319
fdfc4bf3
PE
3320 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3321
fca8fe46 3322 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3323 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3324
06a0259a 3325 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3326 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3327 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3328
e7b9e80f
PE
3329 * print.c (print_error_message): Avoid int overflow.
3330
56201685
PE
3331 * font.c (font_list_entities): Redo for clarity,
3332 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3333
78834453 3334 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3335 (font_score): Avoid potential overflow in diff calculation.
78834453 3336
0bc0b309 3337 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3338 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3339
e610eaca
PE
3340 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3341
b895abce
PE
3342 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3343 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3344 can always succeed if overflow has undefined behavior.
3345
1f1d9321 3346 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3347 (wordify): Omit three unnecessary tests.
1f1d9321 3348
c59478bc
PE
3349 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3350 All callers changed. This avoids the need for an unused var.
3351
79b73827
PE
3352 * casefiddle.c (casify_region): Remove var that is set but not used.
3353
a4db5dfe
PE
3354 * dired.c (file_name_completion): Remove var that is set but not used.
3355
43aae36e
PE
3356 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3357
2a47c44d 3358 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3359 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3360
a37c69bf
PE
3361 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3362 Check for integer overflow on size calculations.
3363
328ab8e7
PE
3364 * buffer.c (Fprevious_overlay_change): Remove var that is set
3365 but not used.
3366
e5a2a5cb
PE
3367 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3368 Remove vars that are set but not used.
8d84a6eb 3369 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3370 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3371
a60e5f68
PE
3372 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3373
f661cb61 3374 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3375 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3376
f0397f5a
PE
3377 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3378 that are set but not used.
3379
8664db06 3380 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3381 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3382
6abdaa4a
PE
3383 * xselect.c (x_get_local_selection, x_handle_property_notify):
3384 Remove vars that are set but not used.
3385
0ce7538d 3386 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3387 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3388
9ae848fc
PE
3389 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3390 Remove var that is set but not used.
0b918413
PE
3391 (scroll_bar_windows_size): Now size_t, not int.
3392 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3393 Check for overflow.
9ae848fc 3394
a5a62657
PE
3395 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3396 (map_tty_color) [!defined MSDOS]: Likewise.
3397
5c5cdd39
PE
3398 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3399
66ebf983
PE
3400 * coding.c: Remove vars that are set but not used.
3401 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3402 All callers changed.
3403 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3404 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3405 (decode_coding_charset): Remove vars that are set but not used.
3406
1be4d761
PE
3407 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3408 that is set but not used.
3409
47553fa8
PE
3410 * print.c (print_object): Remove var that is set but not used.
3411
1f7196bf 3412 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3413 The gnulib version avoids calling malloc in the usual case,
3414 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3415 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3416 * filelock.c (current_lock_owner): Likewise.
3417 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3418 * sysdep.c: Include allocator.h, careadlinkat.h.
3419 (emacs_no_realloc_allocator): New static constant.
3420 (emacs_readlink): New function.
fdb61804
PE
3421 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3422 ../lib/careadlinkat.h.
d1fdcab7 3423
f84c17c7
SM
34242011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3425
3426 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3427 first non-nil return value).
3428
ef3862ad
JD
34292011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3430
3431 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3432 if not defined (Bug#8403).
3433
376a7006
JB
34342011-04-02 Juanma Barranquero <lekktu@gmail.com>
3435
3436 * xdisp.c (display_count_lines): Remove parameter `start',
3437 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3438 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3439 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3440 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3441 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3442 and thereabouts. All callers changed.
3443 (get_per_char_metric): Remove parameter `f', unused since
3444 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3445
6ca3801d
JM
34462011-04-02 Jim Meyering <meyering@redhat.com>
3447
3448 do not dereference NULL upon failed strdup
3449 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3450 (ns_get_family): Likewise.
3451
d8e2b5ba
JB
34522011-04-02 Juanma Barranquero <lekktu@gmail.com>
3453
3454 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3455
8c74fcbd
JD
34562011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3457
3458 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3459 later (Bug#8403).
3460
7200d79c
SM
34612011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3462
03408648 3463 Add lexical binding.
7200d79c 3464
03408648
SM
3465 * window.c (Ftemp_output_buffer_show): New fun.
3466 (Fsave_window_excursion):
3467 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3468
3469 * lread.c (lisp_file_lexically_bound_p): New function.
3470 (Fload): Bind Qlexical_binding.
3471 (readevalloop): Remove `evalfun' arg.
3472 Bind Qinternal_interpreter_environment.
3473 (Feval_buffer): Bind Qlexical_binding.
3474 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3475 Mark as dynamic.
3476 (syms_of_lread): Declare `lexical-binding'.
3477
3478 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3479
3480 * keyboard.c (eval_dyn): New fun.
3481 (menu_item_eval_property): Use it.
ca105506
SM
3482
3483 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3484
03408648
SM
3485 * fns.c (concat, mapcar1): Accept byte-code-functions.
3486
3487 * eval.c (Fsetq): Handle lexical vars.
3488 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3489 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3490 (FletX, Flet): Obey lexical binding.
3491 (Fcommandp): Handle closures.
3492 (Feval): New `lexical' arg.
3493 (eval_sub): New function extracted from Feval. Use it almost
3494 everywhere where Feval was used. Look up vars in lexical env.
3495 Handle closures.
3496 (Ffunctionp): Move from subr.el.
3497 (Ffuncall): Handle closures.
3498 (apply_lambda): Remove `eval_flags'.
3499 (funcall_lambda): Handle closures and new byte-code-functions.
3500 (Fspecial_variable_p): New function.
3501 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3502 but without exporting it to Lisp.
23aba0ea 3503
23aba0ea 3504 * doc.c (Fdocumentation, store_function_docstring):
03408648 3505 * data.c (Finteractive_form): Handle closures.
23aba0ea 3506
03408648
SM
3507 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3508 interactive spec.
ba83908c 3509
04f2d78b
CB
3510 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3511 New byte-codes.
03408648
SM
3512 (exec_byte_code): New function extracted from Fbyte_code to handle new
3513 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3514
03408648 3515 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3516
03408648 3517 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3518
e2abce01
JB
35192011-03-31 Juanma Barranquero <lekktu@gmail.com>
3520
3521 * xdisp.c (redisplay_internal): Fix prototype.
3522
63696a73 35232011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3524
63696a73 3525 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3526 (try_scrolling): Use it when setting scroll_limit.
3527 Limit scrolling to 100 screen lines.
63696a73
EZ
3528 (redisplay_window): Even when falling back on "recentering",
3529 position point in the window according to scroll-conservatively,
3530 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3531
3532 (try_scrolling): When point is above the window, allow searching
3533 as far as scroll_max, or one screenful, to compute vertical
3534 distance from PT to the scroll margin position. This prevents
3535 try_scrolling from unnecessarily failing when
3536 scroll-conservatively is set to a value slightly larger than the
3537 window height. Clean up the case of PT below the margin at bottom
3538 of window: scroll_max can no longer be INT_MAX. When aggressive
3539 scrolling is in use, don't let point enter the opposite scroll
3540 margin as result of the scroll.
3541 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3542 threshold of 100 lines for never-recentering scrolling.
3543
e4cc2dfc
JB
35442011-03-31 Juanma Barranquero <lekktu@gmail.com>
3545
3546 * dispextern.h (move_it_by_lines):
3547 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3548 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3549 (message_log_check_duplicate): Remove parameters `prev_bol' and
3550 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3551 (redisplay_internal): Remove parameter `preserve_echo_area',
3552 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3553
3554 * indent.c (Fvertical_motion):
3555 * window.c (window_scroll_pixel_based, Frecenter):
3556 Don't pass `need_y_p' to `move_it_by_lines'.
3557
1c470562
SM
35582011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3559
44f230aa
SM
3560 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3561 steal a few bits to be more compact.
3562 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3563 Remove unneeded casts.
3564
1c470562
SM
3565 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3566
888adce9
ZK
35672011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3568
3569 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3570 binding" message (bug#7967).
3571
f838ed7b
PE
35722011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3573
77861b95
PE
3574 Fix more problems found by GCC 4.6.0's static checks.
3575
de6dbc14
PE
3576 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3577 Remove unused local var.
3578
f838ed7b
PE
3579 * editfns.c (Fmessage_box): Remove unused local var.
3580
792c7b2b
PE
3581 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3582 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3583 Omit unused local vars.
c499e557 3584 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3585 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3586 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3587 Omit unused local var.
3588
ba0165e1
PE
3589 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3590 Don't assume string length fits in int.
32ad8845 3591 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3592 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3593
3c59b4c9
PE
3594 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3595 instead of alloca (Bug#8344).
3596
a3eed478 3597 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3598 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3599
eb4d412d
PE
3600 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3601
1658b401
PE
3602 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3603 concerns.
3604
3605 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3606
3607 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3608
9a2c6e05
PE
3609 * keyboard.c (syms_of_keyboard): Use the same style as later
3610 in this function when indexing through an array. This also
3611 works around GCC bug 48267.
3612
03d0a109
PE
3613 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3614
44f730c8
PE
3615 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3616
fe75f926
PE
3617 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3618 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3619
ffa8c828
PE
3620 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3621 This avoids undefined behavior on integer overflow, and is a bit
3622 more convenient anyway since it is compared to a size_t variable.
3623
c5101a77
PE
3624 Variadic C functions now count arguments with size_t, not int.
3625 This avoids an unnecessary limitation on 64-bit machines, which
3626 caused (substring ...) to crash on large vectors (Bug#8344).
3627 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3628 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3629 All variadic functions and their callers changed accordingly.
c5101a77
PE
3630 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3631 * data.c (arith_driver, float_arith_driver): Likewise.
3632 * editfns.c (general_insert_function): Likewise.
3633 * eval.c (struct backtrace.nargs, interactive_p)
3634 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3635 (funcall_lambda, mark_backtrace): Likewise.
3636 * fns.c (concat): Likewise.
3637 * frame.c (x_set_frame_parameters): Likewise.
3638 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3639 0 if not found, not -1. All callers changed.
3640
dd3f25f7
PE
3641 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3642 (stack_copy_size): Now size_t, not int.
3643 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3644
461c2ab9
JB
36452011-03-28 Juanma Barranquero <lekktu@gmail.com>
3646
3647 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3648 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3649 All callers changed.
3650
3651 * lisp.h (multibyte_char_to_unibyte):
3652 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3653 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3654 * character.h (CHAR_TO_BYTE8):
3655 * cmds.c (internal_self_insert):
3656 * editfns.c (general_insert_function):
3657 * keymap.c (push_key_description):
3658 * search.c (Freplace_match):
3659 * xdisp.c (message_dolog, set_message_1): All callers changed.
3660
f6d62986
SM
36612011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3662
3663 * keyboard.c (safe_run_hook_funcall): New function.
3664 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3665 don't set the hook to nil, but remove the offending function instead.
3666 (Qcommand_hook_internal): Remove, unused.
3667 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3668 Vcommand_hook_internal.
3669
3670 * eval.c (enum run_hooks_condition): Remove.
3671 (funcall_nil, funcall_not): New functions.
3672 (run_hook_with_args): Call each function through a `funcall' argument.
3673 Remove `cond' argument, now redundant.
3674 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3675 (Frun_hook_with_args_until_failure): Adjust accordingly.
3676 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3677
1db5b1ad
JB
36782011-03-28 Juanma Barranquero <lekktu@gmail.com>
3679
3680 * dispextern.h (string_buffer_position): Remove declaration.
3681
3682 * print.c (strout): Remove parameter `multibyte', unused since
3683 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3684
3685 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3686 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3687 All callers changed.
3688
3689 * w32.c (_wsa_errlist): Use braces for struct initializers.
3690
3691 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3692 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3693 All callers changed.
3694 (string_buffer_position): Likewise. Also, make static (it's never
3695 used outside xdisp.c).
3696 (cursor_row_p): Remove parameter `w', unused since
3697 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3698 (decode_mode_spec): Remove parameter `precision', introduced during
3699 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3700 All callers changed.
3701
5ffb62aa
JD
37022011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3703
3704 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3705
461c2ab9 37062011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3707
3708 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3709 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3710 (ns_update_auto_hide_menu_bar): New functions.
3711 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3712 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3713 ns_constrain_all_frames.
3714 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3715 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3716
5c380ffb
JD
37172011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3718
3719 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3720
9af30bdf
GM
37212011-03-27 Glenn Morris <rgm@gnu.org>
3722
3723 * syssignal.h: Replace RETSIGTYPE with void.
3724 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3725 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3726 Replace SIGTYPE with void everywhere.
3727 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3728 * s/template.h (SIGTYPE): Remove commented out definition.
3729
e2abce01
JB
37302011-03-26 Eli Zaretskii <eliz@gnu.org>
3731
3732 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3733 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3734
f868cd8a
JB
37352011-03-26 Juanma Barranquero <lekktu@gmail.com>
3736
59eb0929
JB
3737 * w32.c (read_unc_volume): Use parameter `henum', instead of
3738 global variable `wget_enum_handle'.
3739
3740 * keymap.c (describe_vector): Remove parameters `indices' and
3741 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3742 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3743
f868cd8a
JB
3744 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3745
3746 * keyboard.c (timer_check): Remove parameter `do_it_now',
3747 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3748 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3749 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3750
3751 * keyboard.c (read_char):
3752 * w32menu.c (w32_menu_display_help):
3753 * xmenu.c (show_help_event, menu_help_callback):
3754 Adjust calls to `show_help_echo'.
3755
3756 * gtkutil.c (xg_maybe_add_timer):
3757 * keyboard.c (readable_events):
3758 * process.c (wait_reading_process_output):
3759 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3760
3761 * insdel.c (adjust_markers_gap_motion):
3762 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3763 (gap_left, gap_right): Don't call it.
3764
2ecf6fdb
CY
37652011-03-25 Chong Yidong <cyd@stupidchicken.com>
3766
3767 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3768 incurred during fontification.
3769
6b1f9ba4
JB
37702011-03-25 Juanma Barranquero <lekktu@gmail.com>
3771
3772 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3773 (DEFVAR_PER_BUFFER): Don't pass it.
3774
3775 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3776 (scrolling_window): Don't pass it.
3777
0f4a96b5
JB
37782011-03-25 Juanma Barranquero <lekktu@gmail.com>
3779
3780 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3781
3782 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3783 and `suffix'.
3784 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3785 of variables specific to SELinux and computation of `encoded_absname'.
3786
3787 * image.c (XPutPixel): Remove unused variable `height'.
3788
3789 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3790
3791 * unexw32.c (get_section_info): Remove unused variable `section'.
3792
3793 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3794 (system_process_attributes): Remove unused variable `sess'.
3795 (sys_read): Remove unused variable `err'.
3796
3797 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3798 (w32_wnd_proc): Remove unused variable `isdead'.
3799 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3800 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3801 (x_create_tip_frame): Remove unused variable `tem'.
3802
3803 * w32inevt.c (w32_console_read_socket):
3804 Remove unused variable `no_events'.
3805
3806 * w32term.c (x_draw_composite_glyph_string_foreground):
3807 Remove unused variable `width'.
3808
1149507c
JB
38092011-03-24 Juanma Barranquero <lekktu@gmail.com>
3810
3811 * w32term.c (x_set_glyph_string_clipping):
3812 Don't pass uninitialized region to CombineRgn.
3813
9c88f339
JB
38142011-03-23 Juanma Barranquero <lekktu@gmail.com>
3815
3816 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3817 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3818 (Fx_close_connection): Remove unused variable `i'.
3819
3820 * w32font.c (w32font_draw): Return number of glyphs.
3821 (w32font_open_internal): Remove unused variable `i'.
3822 (w32font_driver): Add missing initializer.
3823
3824 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3825 (fill_in_menu): Remove unused variable `items_added'.
3826
3827 * w32term.c (last_mouse_press_frame): Remove static global variable.
3828 (w32_clip_to_row): Remove unused variable `f'.
3829 (x_delete_terminal): Remove unused variable `i'.
3830
3831 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3832 (NOTHING): Remove unused static global variable.
3833 (uniscribe_check_otf): Remove unused variable `table'.
3834 (uniscribe_font_driver): Add missing initializers.
3835
dee091a3
JD
38362011-03-23 Julien Danjou <julien@danjou.info>
3837
3838 * term.c (Fsuspend_tty, Fresume_tty):
3839 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3840 * window.c (temp_output_buffer_show):
3841 * insdel.c (signal_before_change):
3842 * frame.c (Fhandle_switch_frame):
3843 * fileio.c (Fdo_auto_save):
3844 * emacs.c (Fkill_emacs):
3845 * editfns.c (save_excursion_restore):
3846 * cmds.c (internal_self_insert):
3847 * callint.c (Fcall_interactively):
3848 * buffer.c (Fkill_all_local_variables):
3849 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3850 Use Frun_hooks.
0f4a96b5 3851 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3852 unconditionnaly since it does the check itself.
3853
2c520ab5 38542011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3855
c9c49752
PE
3856 Fix more problems found by GCC 4.5.2's static checks.
3857
8abc3f12
PE
3858 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3859 the first time through the loop, since we know p0 < p1 then.
3860 This also avoids a gcc -Wstrict-overflow warning.
3861
a2d26660
PE
3862 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3863 leading to a memory leak, possible in functions like
3864 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3865 of objects (Bug#8318).
a2d26660 3866
916c72e9
PE
3867 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3868 that could (at least in theory) be that large.
3869
19ab8a18
PE
3870 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3871 This is less likely to overflow, and avoids undefined behavior if
3872 overflow does occur. All callers changed. Use strtoul to scan
3873 for the unsigned long integer.
b7cbbd6f
PE
3874 (pint2hrstr): Simplify and tune code slightly.
3875 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3876
f0641eff
PE
3877 * scroll.c (do_scrolling): Work around GCC bug 48228.
3878 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3879
7f650bb9
PE
3880 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3881 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3882 (validate_x_resource_name): Simplify count usage.
3883 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3884
37dd57d1
PE
3885 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3886 fail (Bug#8306).
81e56e61 3887
699979fc 3888 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3889
401bf9b4
PE
3890 * process.c (Fmake_network_process): Use socklen_t, not int,
3891 where POSIX says socklen_t is required in portable programs.
3892 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3893 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3894 (Fmake_network_process, server_accept_connection):
3895 (wait_reading_process_output, read_process_output):
3896 Likewise.
3897
b93aacde
PE
3898 * process.c: Rename or move locals to avoid shadowing.
3899 (list_processes_1, Fmake_network_process):
3900 (read_process_output_error_handler, exec_sentinel_error_handler):
3901 Rename or move locals.
4dc343ee 3902 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3903 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3904 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3905 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3906 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3907
af8a867c 3908 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3909 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3910 Include tparam.h instead, since it declares them.
af8a867c
PE
3911 * cm.h (PC): Remove extern decl; tparam.h now does this.
3912 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3913 * terminfo.c: Include tparam.h, to check interfaces.
3914 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3915 (tparam): Adjust signature to match interface in tparam.h;
3916 this removes some undefined behavior. Check that outstring and len
3917 are zero, which they always are with Emacs.
3918 * tparam.h (PC, BC, UP): New extern decls.
3919
0248044d 3920 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3921 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3922
8ff096c1 3923 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3924 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3925 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3926 (ftfont_list): Remove unused local.
49eaafba
PE
3927 (get_adstyle_property, ftfont_pattern_entity):
3928 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3929 Rename locals to avoid shadowing.
8ff096c1 3930
e2be39f6
PE
3931 * xfont.c (xfont_list_family): Mark var as initialized.
3932
c9735e30
PE
3933 * xml.c (make_dom): Now static.
3934
8f5201ae
PE
3935 * composite.c (composition_compute_stop_pos): Rename local to
3936 avoid shadowing.
b246f932
PE
3937 (composition_reseat_it): Remove unused locals.
3938 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3939 (composition_update_it): Mark var as initialized.
11b61122
PE
3940 (find_automatic_composition): Mark vars as initialized,
3941 with a FIXME (Bug#8290).
8f5201ae 3942
760fbc2c
PE
3943 character.h: Rename locals to avoid shadowing.
3944 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3945 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3946 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3947 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3948 to avoid shadowing.
3949
ff08eb85
PE
3950 * textprop.c (property_change_between_p): Remove; unused.
3951
fc7bf025
PE
3952 * intervals.c (interval_start_pos): Now static.
3953
235d7abc
PE
3954 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3955
44f230aa
SM
3956 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3957 Rename locals to avoid shadowing.
3e7d6594 3958
50060332
PE
3959 * sound.c (wav_play, au_play, Fplay_sound_internal):
3960 Fix pointer signedness.
d01f234b 3961 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3962 (wav_play): Initialize a variable to 0, to prevent undefined
3963 behavior (Bug#8278).
50060332 3964
c4fc4e30
PE
3965 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3966
918436ed
PE
3967 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3968
c939f91b
PE
3969 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3970 clobbering (Bug#8298).
b9c7f648
PE
3971 * sysdep.c (sys_subshell): Likewise.
3972 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3973
6bd8c144
PE
3974 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3975 This should get cleaned up, so that child_setup has the
3976 same signature on all platforms.
3977
7710357c 3978 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3979 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3980
c59da222
CY
39812011-03-22 Chong Yidong <cyd@stupidchicken.com>
3982
3983 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3984 not to be necessary, and produces flickering.
3985
66b87493
GM
39862011-03-20 Glenn Morris <rgm@gnu.org>
3987
3988 * config.in: Remove file.
3989
45b6f6d5
JB
39902011-03-20 Juanma Barranquero <lekktu@gmail.com>
3991
3992 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3993 are now in src/globals.h.
3994 (syms_of_minibuf): Remove spurious & from previous change.
3995
3ec03f7e
LL
39962011-03-20 Leo <sdl.web@gmail.com>
3997
3998 * minibuf.c (completing-read-function): New variable.
3999 (completing-read-default): Rename from completing-read.
4000 (completing-read): Call completing-read-function.
4001
b14e3e21
CY
40022011-03-19 Juanma Barranquero <lekktu@gmail.com>
4003
4004 * xfaces.c (Fx_load_color_file):
4005 Read color file from absolute filename (bug#8250).
4006
f2b726e6
JB
40072011-03-19 Juanma Barranquero <lekktu@gmail.com>
4008
4009 * makefile.w32-in: Update dependencies.
4010
09f6ff02
EZ
40112011-03-17 Eli Zaretskii <eliz@gnu.org>
4012
4013 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4014
29a6015a
PE
40152011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4016
a3a6c54e
PE
4017 Fix more problems found by GCC 4.5.2's static checks.
4018
b766f867
PE
4019 * process.c (make_serial_process_unwind, send_process_trap):
4020 (sigchld_handler): Now static.
4021
be02381c
PE
4022 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4023 That way, the code declares only the vars that it needs.
4024 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4025 * s/cygwin.h (PTY_ITERATION): Likewise.
4026 * s/darwin.h (PTY_ITERATION): Likewise.
4027 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4028
57048744
PE
4029 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4030 * process.c (allocate_pty): Don't declare stb unless it's needed.
4031
7914961c 4032 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4033 (CONSTANTLIM): Remove; unused.
4034 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4035 Define only if needed.
7914961c 4036
b3967b18
PE
4037 * unexelf.c (unexec): Name an expression,
4038 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4039 Use a different way to cause a compilation error if anyone uses
4040 n rather than nn, a way that does not involve shadowing.
73366a00 4041 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4042
29a6015a
PE
4043 * deps.mk (unexalpha.o): Remove; unused.
4044
43cfc33e 4045 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4046 * unexec.h: New file.
ce701a33
PE
4047 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4048 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4049 Depend on unexec.h.
4050 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4051 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4052 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4053 Change as necessary to match prototype in unexec.h.
ce701a33 4054
01f44d5a
PE
4055 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4056 shadowing.
4f63c6bb 4057 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4058
a6670b0b
PE
4059 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4060 Rename locals to avoid shadowing.
4061
cef2010d 4062 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4063 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4064
d4d7173a
PE
4065 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4066
f08b802a
PE
4067 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4068 warning when compiling print.c.
4069
3ddb0639
PE
4070 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4071 instead of using an uninitialized var.
5ad03b97 4072 (font_sort_entities): Mark var as initialized.
3ddb0639 4073
170a2692
PE
4074 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4075
e663c700
PE
4076 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4077 pointers to constants.
89bc529a 4078 (font_parse_fcname): Remove unused vars.
7b81e2d0 4079 (font_delete_unmatched): Now static.
ea838e10 4080 (font_get_spec): Remove; unused.
13a547c6
PE
4081 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4082 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4083 Rename or move locals to avoid shadowing.
e663c700 4084
2a80c887 4085 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4086 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4087
1384fa33 4088 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4089 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4090
8b2c52e9
PE
4091 * alloc.c (mark_backtrace): Move decl from here ...
4092 * lisp.h: ... to here, so that it can be checked.
4093
475545b5 4094 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4095 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4096 (lisp_indirect_variable): Name an expression,
4097 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4098 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4099
b1349114 4100 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4101 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4102 Use const pointer when appropriate.
b1349114 4103
a2928364
PE
4104 * lisp.h (get_system_name, get_operating_system_release):
4105 Move decls here, to check interfaces.
4106 * process.c (get_operating_system_release): Move decl to lisp.h.
4107 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4108 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4109 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4110 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4111 (Fformat_time_string, Fencode_time, Finsert_char):
4112 (Ftranslate_region_internal, Fformat):
4113 Rename or remove local vars to avoid shadowing.
9710023e 4114 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4115
a415e694
PE
4116 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4117 avoid shadowing.
4118
8ef4622d
PE
4119 * lisp.h (eassert): Check that the argument compiles, even if
4120 ENABLE_CHECKING is not defined.
4121
946f9a5b
PE
4122 * data.c (Findirect_variable): Name an expression, to avoid
4123 gcc -Wbad-function-cast warning.
112396d6 4124 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4125 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4126 (Fmake_variable_buffer_local, Fmake_local_variable):
4127 Mark variables as initialized.
52746918 4128 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4129
e5aab7e7 4130 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4131 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4132 Rename locals to avoid shadowing.
dff45157
PE
4133 (mark_stack): Move local variables into the #ifdef region where
4134 they're used.
7bc26fdb
PE
4135 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4136 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4137 needed otherwise.
4138 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4139 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4140 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4141
e5aab7e7
PE
4142 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4143 avoids undefined behavior in theory.
4144
4da60324
PE
4145 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4146
88043301
PE
4147 Use functions, not macros, for up- and down-casing (Bug#8254).
4148 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4149 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4150 to use the following functions instead of these macros.
4151 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4152 EMACS_INT, since callers assume the returned value fits in int.
4153 (upcase1): Likewise, for UPCASE_TABLE.
4154 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4155 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4156 the race-condition problem in the old DOWNCASE.
88043301 4157
19ed5445
PE
4158 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4159 Rename locals to avoid shadowing.
4160 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4161 (regex_compile, re_search_2, re_match_2_internal):
4162 Remove unused local vars.
952db0d7
PE
4163 (FREE_VAR): Rewrite so as not to use empty "else",
4164 which gcc can warn about.
da053e48 4165 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4166 (RETALLOC_IF): Define only if needed.
4167 (WORDCHAR_P): Likewise. This one is never needed, but is used
4168 only in a comment talking about a compiler bug, so put inside
4169 the #if 0 of that comment.
4170 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4171 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4172 Remove; unused.
19ed5445 4173
1f3561e4 4174 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4175 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4176 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4177
ded6f8f7
PE
4178 * search.c (simple_search): Remove unused var.
4179
dbd37a95
PE
4180 * dired.c (compile_pattern): Move decl from here ...
4181 * lisp.h: ... to here, so that it can be checked.
4182 (struct re_registers): New forward decl.
4183
7e47afad
PE
4184 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4185
85f24f61
PE
4186 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4187 All uses changed.
4188 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4189 Rename locals to avoid shadowing.
5671df8f 4190 (Fvertical_motion): Mark locals as initialized.
85f24f61 4191
181aa2be 4192 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4193 (casify_region): Mark local as initialized.
181aa2be 4194
930d429c
PE
4195 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4196
7082eac6
PE
4197 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4198 New macros, so that the caller can use some names other than
4199 gcpro1, gcpro2, etc.
4200 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4201 of the new macros.
4202 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4203 argument, for consistency with GCPRO2_VAR, etc: it is now the
4204 prefix of the variable, not the variable itself. All uses
4205 changed.
38b2c076
PE
4206 * dired.c (directory_files_internal, file_name_completion):
4207 Rename locals to avoid shadowing.
4208
15206ed9
PE
4209 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4210 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4211 dired.c's scmp function, had undefined behavior.
4212 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4213 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4214 * buffer.h: ... to here, because these macros use current_buffer,
4215 and the new implementation with inline functions needs to have
4216 current_buffer in scope now, rather than later when the macros
4217 are used.
4218 (downcase, upcase1): New static inline functions.
4219 (DOWNCASE, UPCASE1): Reimplement using these functions.
4220 This avoids undefined behavior in expressions like
4221 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4222 from race conditions in accessing the global variables
4223 case_temp1 and case_temp2.
4224 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4225 * lisp.h (case_temp1, case_temp2): Remove their decls.
4226 * character.h (ASCII_CHAR_P): Move from here ...
4227 * lisp.h: ... to here, so that the inline functions mentioned
4228 above can use them.
4229
4a6bea26
PE
4230 * dired.c (directory_files_internal_unwind): Now static.
4231
f14b7e14
PE
4232 * fileio.c (file_name_as_directory, directory_file_name):
4233 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4234 Now static.
2893f146
PE
4235 (file_name_as_directory): Use const pointers when appropriate.
4236 (Fexpand_file_name): Likewise. In particular, newdir might
4237 point at constant storage, so make it a const pointer.
fd4ead52 4238 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4239 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4240 signedness issues.
f839df0c
PE
4241 (Fset_file_times, Finsert_file_contents, auto_save_error):
4242 Rename locals to avoid shadowing.
f14b7e14 4243
5716756e 4244 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4245 (Ftry_completion, Fall_completions): Rename or remove locals
4246 to avoid shadowing.
5716756e 4247
b4c3046a
PE
4248 * marker.c (bytepos_to_charpos): Remove; unused.
4249
b45db522
PE
4250 * lisp.h (verify_bytepos, count_markers): New decls,
4251 so that gcc does not warn that these functions aren't declared.
4252
85876d07
PE
4253 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4254 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4255 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4256 (copy_text): Remove unused local var.
85876d07 4257
03d78a21 4258 * filelock.c (within_one_second): Now static.
b3dd38ab 4259 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4260
5df8f01b
PE
4261 * buffer.c (fix_overlays_before): Mark locals as initialized.
4262 (fix_start_end_in_overlays): Likewise. This function should be
4263 simplified by using pointers-to-pointers, but that's a different
4264 matter.
b1d876f1 4265 (switch_to_buffer_1): Now static.
8f54f30a
PE
4266 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4267 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4268
a70072c9 4269 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4270 Fix pointer signedness issue.
edced198
PE
4271 (sys_subshell): Mark local as volatile if checking for lint,
4272 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4273 (MAXPATHLEN): Define only if needed.
a70072c9 4274
a0977c44
PE
4275 * process.c (serial_open, serial_configure): Move decls from here ...
4276 * systty.h: ... to here, so that they can be checked.
4277
a884fdcc
PE
4278 * fns.c (get_random, seed_random): Move extern decls from here ...
4279 * lisp.h: ... to here, so that they can be checked.
4280
604efe86 4281 * sysdep.c (reset_io): Now static.
b8950c94 4282 (wait_for_termination_signal): Remove; unused.
604efe86 4283
38fc62d9
PE
4284 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4285 (copy_keymap_item, append_key, push_text_char_description):
4286 Now static.
1004a21a 4287 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4288 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4289 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4290 (describe_map_tree):
4291 Rename locals to avoid shadowing.
38fc62d9 4292
2f2650da
PE
4293 * keyboard.c: Declare functions static if they are not used elsewhere.
4294 (echo_char, echo_dash, cmd_error, top_level_2):
4295 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4296 (read_char, kbd_buffer_get_event, make_lispy_position):
4297 (make_lispy_event, make_lispy_movement, apply_modifiers):
4298 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4299 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4300 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4301 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4302 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4303
a053e86c 4304 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4305 (mark_kboards): Move decl here ...
4306 * alloc.c (mark_kboards): ... from here.
a053e86c 4307
4752793e
PE
4308 * lisp.h (force_auto_save_soon): New decl.
4309
74f10ca7 4310 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4311 (DEFINE_DUMMY_FUNCTION): New macro.
4312 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4313 Use it.
c03cd23f
PE
4314 (main): Add casts to avoid warnings
4315 if GCC considers string literals to be constants.
74f10ca7 4316
022e70d4
PE
4317 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4318
59d6fe83
PE
4319 * dbusbind.c: Pointer signedness fixes.
4320 (xd_signature, xd_append_arg, xd_initialize):
4321 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4322 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4323 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4324 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4325
78320123
PE
4326 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4327 if GCC considers string literals to be constants.
49cebcca 4328 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4329
35ac2a97
SM
43302011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4331
fb103ca9
SM
4332 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4333 (print_preprocess, print_object): New macro to fix last change.
4334
35ac2a97
SM
4335 * print.c (print_preprocess): Don't forget font objects.
4336
62973b41
JB
43372011-03-16 Juanma Barranquero <lekktu@gmail.com>
4338
4339 * emacs.c (USAGE3): Doc fixes.
4340
0e48bb22
AS
43412011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4342
4343 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4344 structure.
4345
7684e57b
JB
43462011-03-14 Juanma Barranquero <lekktu@gmail.com>
4347
4348 * lisp.h (VWindow_system, Qfile_name_history):
4349 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4350 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4351 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4352
4353 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4354 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4355
4356 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4357 * w32console.c (detect_input_pending, read_input_pending)
4358 (encode_terminal_code):
4359 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4360 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4361 (w32_system_caret_y, Qfile_name_history):
4362 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4363 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4364 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4365 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4366 * w32proc.c (Qlocal, report_file_error):
4367 * w32term.c (Vwindow_system, updating_frame):
4368 * w32uniscribe.c (initialized, uniscribe_font_driver):
4369 Remove unneeded extern declarations.
4370
2aa46d6c
CY
43712011-03-14 Chong Yidong <cyd@stupidchicken.com>
4372
c96bbc66 4373 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4374
cffc6f3b
CY
43752011-03-13 Chong Yidong <cyd@stupidchicken.com>
4376
4377 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4378 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4379 These macros can no longer be used for assignment.
4380
44f230aa
SM
4381 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4382 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4383 (record_buffer_markers, fetch_buffer_markers): New functions for
4384 recording and fetching special buffer markers.
4385 (set_buffer_internal_1, set_buffer_temp): Use them.
4386
4387 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4388
4389 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4390
4391 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4392 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4393
4394 * xdisp.c (hscroll_window_tree):
4395 (reconsider_clip_changes): Use PT instead of BUF_PT.
4396
d251f04b
EZ
43972011-03-13 Eli Zaretskii <eliz@gnu.org>
4398
4399 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4400 $(EMACS_ROOT)/lib/intprops.h.
4401
f0c77cd1
PE
44022011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4403
3eca4629
PE
4404 Fix more problems found by GCC 4.5.2's static checks.
4405
7c86ee98
PE
4406 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4407 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4408 (xg_free_frame_widgets): Make it clear that a local variable is
4409 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4410 (gdk_window_get_screen): Make it clear that this macro is needed
4411 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4412 (int_gtk_range_get_value): New function, which avoids a diagnostic
4413 from gcc -Wbad-function-cast.
4414 (xg_set_toolkit_scroll_bar_thumb): Use it.
4415 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4416 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4417 (get_utf8_string, xg_get_file_with_chooser):
4418 Rename locals to avoid shadowing.
4419 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4420
41729b81
PE
4421 * xgselect.c (xg_select): Remove unused var.
4422
f0c77cd1
PE
4423 * image.c (four_corners_best): Mark locals as initialized.
4424 (gif_load): Initialize transparent_p to zero (Bug#8238).
4425 Mark another local as initialized.
ec6cf4c6 4426 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4427
ce0ad53d 4428 * image.c (clear_image_cache): Now static.
d5d5a617 4429 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4430 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4431 (x_edge_detection): Remove unnecessary cast that
4432 gcc -Wbad-function-cast diagnoses.
2037898d 4433 (gif_load): Fix pointer signedness.
6ae141d6
PE
4434 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4435 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4436
33383987 44372011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4438
d32df629
PE
4439 Improve quality of tests for time stamp overflow.
4440 For example, without this patch (encode-time 0 0 0 1 1
4441 1152921504606846976) returns the obviously-bogus value (-948597
4442 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4443 reports time overflow. See
4444 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4445 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4446 * editfns.c: Include limits.h and intprops.h.
4447 (TIME_T_MIN, TIME_T_MAX): New macros.
4448 (time_overflow): Move earlier, to before first use.
4449 (hi_time, lo_time): New functions, for an accurate test for
4450 out-of-range times.
4451 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4452 (Fget_internal_run_time): Don't assume time_t fits in int.
4453 (make_time): Use list2 instead of Fcons twice.
4454 (Fdecode_time): More accurate test for out-of-range times.
4455 (check_tm_member): New function.
4456 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4457 (lisp_time_argument): Don't rely on undefined left-shift and
4458 right-shift behavior when checking for time stamp overflow.
8be6f318 4459
fe31d94c
PE
4460 * editfns.c (time_overflow): New function, refactoring common code.
4461 (Fformat_time_string, Fdecode_time, Fencode_time):
4462 (Fcurrent_time_string): Use it.
4463
8be6f318
PE
4464 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4465 * dired.c (make_time): Move to ...
4466 * editfns.c (make_time): ... here.
4467 * systime.h: Note the move.
4468
09d9db2c 44692011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4470
126bc0dc
YM
4471 * fringe.c (update_window_fringes): Remove unused variables.
4472
c47cbdfd
YM
4473 * unexmacosx.c (copy_data_segment): Also copy __got section.
4474 (Bug#8223)
4475
7ac80be9
EZ
44762011-03-12 Eli Zaretskii <eliz@gnu.org>
4477
c96bbc66 4478 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4479 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4480 Constify `char *' arguments and their references according to
4481 prototypes in tparam.h.
4482
ecb0f94d 4483 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4484
7ac80be9
EZ
4485 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4486 Adapt all references accordingly.
4487
4488 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4489
ef1fd07e
TT
44902011-03-11 Tom Tromey <tromey@redhat.com>
4491
4492 * buffer.c (syms_of_buffer): Remove obsolete comment.
4493
7ef4b50c
EZ
44942011-03-11 Eli Zaretskii <eliz@gnu.org>
4495
4496 * termhooks.h (encode_terminal_code): Declare prototype.
4497
4498 * msdos.c (encode_terminal_code): Don't declare prototype.
4499
4500 * term.c (encode_terminal_code): Now external again, used by
4501 w32console.c and msdos.c.
4502
44f230aa
SM
4503 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4504 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4505
4b1ec863 45062011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4507
1714f52b 4508 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4509
4b1ec863
PE
4510 * fringe.c (update_window_fringes): Mark locals as initialized
4511 (Bug#8227).
4512 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4513
524c7aa6
PE
4514 * alloc.c (mark_fringe_data): Move decl from here ...
4515 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4516 to check its interface.
4517 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4518
a5c0af81 4519 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4520 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4521 (fontset_font): Mark local as initialized.
a9a06e0b 4522 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4523
b4716021
PE
4524 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4525
811e9bac 4526 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4527 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4528 (x_own_selection, Fx_disown_selection_internal): Rename locals
4529 to avoid shadowing.
4530 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4531
7e3ab302
PE
4532 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4533 so that the caller can use some name other than gcpro1.
4534 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4535 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4536 (Fx_backspace_delete_keys_p):
4537 Use them to avoid shadowing, and rename vars to avoid shadowing.
4538 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4539 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4540 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4541 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4542 Remove unused locals.
7e3ab302
PE
4543 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4544 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4545 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4546 macros.
f78faa98 4547
e2b13473
PE
4548 * xterm.h (x_mouse_leave): New decl.
4549
77f23912
PE
4550 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4551 Remove unused functions.
cdf4ba58
PE
4552 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4553 (x_calc_absolute_position): Now static.
7411c686 4554 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4555 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4556 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4557 unless they are used.
38d0b34a
PE
4558 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4559 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4560 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4561 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4562 (x_error_catcher, x_connection_closed, x_error_handler):
4563 (x_error_quitter, xembed_send_message, x_iconify_frame):
4564 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4565 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4566 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4567
44f230aa
SM
4568 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4569 Rename or move locals to avoid shadowing.
6b463e58 4570 (tty_defined_color, merge_face_heights): Now static.
5967d051 4571 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4572 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4573 does not deduce is never used uninitialized.
73719eba
PE
4574 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4575 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4576
426994c3 4577 * terminal.c (store_terminal_param): Now static.
5489860b 4578
032f1620 4579 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4580 (set_frame_menubar): Remove unused local.
d4323972 4581 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4582 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4583 since they might point to immutable storage.
281585b0
PE
4584 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4585 since it's unused otherwise.
032f1620 4586
367c19e5 4587 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4588 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4589 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4590 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4591 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4592 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4593 does not deduce are never used uninitialized.
70739cbe 4594
07b48fa9
PE
4595 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4596
8868a238 4597 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4598 * window.c (window_loop, size_window):
4599 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4600
7e5cf297 4601 * window.c (display_buffer): Now static.
d6550a9f
PE
4602 (size_window): Mark variables that gcc -Wuninitialized
4603 does not deduce are never used uninitialized.
a586633d
PE
4604 * window.h (check_all_windows): New decl, to forestall
4605 gcc -Wmissing-prototypes diagnostic.
5b555da1 4606 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4607
f6095868
PE
4608 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4609 shadowing.
4610 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4611 Include <limits.h>.
4612 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4613 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4614 (load_charset_map): Mark variables that gcc -Wuninitialized
4615 does not deduce are never used uninitialized.
53df7c11 4616 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4617
f38b440c
PE
4618 * coding.c (coding_set_source, coding_set_destination):
4619 Use "else { /* comment */ }" rather than "else /* comment */;"
4620 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4621 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4622 a block, when the outer 'i' will do.
4623 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4624 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4625 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4626 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4627 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4628 Rename locals to avoid shadowing.
4629 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4630 * coding.c (emacs_mule_char, encode_invocation_designation):
4631 Now static, since they're not used elsewhere.
413bb2db 4632 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4633 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4634 (decode_coding_emacs_mule): Mark variables that gcc
4635 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4636 (detect_coding_iso_2022): Initialize a local variable that might
4637 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4638 this initialization is needed. (Bug#8211)
5f58e762
PE
4639 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4640 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4641 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4642 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4643 Remove unused macros.
f38b440c 4644
232b38b9 4645 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4646 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4647 * character.c (string_count_byte8): Likewise.
232b38b9 4648
fb90da1b
PE
4649 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4650 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4651
fb93dbc2
PE
4652 * chartab.c (copy_sub_char_table): Now static, since it's not used
4653 elsewhere.
5c156ace
PE
4654 (sub_char_table_ref_and_range, char_table_ref_and_range):
4655 Rename locals to avoid shadowing.
bbcd0949 4656 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4657
7d3b3862 4658 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4659 (BIDI_BOB): Remove unused macro.
7d3b3862 4660
6be7d3da
PE
4661 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4662 deduce are never used uninitialized.
c2ed9c8b 4663 * term.c (encode_terminal_code): Likewise.
6be7d3da 4664
75f8807f 4665 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4666
50938595
PE
4667 * tparam.h: New file.
4668 * term.c, tparam.h: Include it.
4669 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4670 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4671 Move these decls to tparam.h, and make them agree with what
4672 is actually in tparam.c. The previous trick of using incompatible
4673 decls in different modules does not conform to the C standard.
4674 All callers of tparam changed to use tparam's actual API.
4675 * tparam.c (tparam1, tparam, tgoto):
4676 Use const pointers where appropriate.
4677
fbceeba2
PE
4678 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4679 * cm.h (struct cm): Likewise.
4680 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4681 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4682 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4683 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4684 (turn_on_face, init_tty): Likewise.
4685 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4686
7f3f1250
PE
4687 * term.c (term_mouse_position): Rename local to avoid shadowing.
4688
e6ca6543
PE
4689 * alloc.c (mark_ttys): Move decl from here ...
4690 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4691
c40f8d15
AS
46922011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4693
4694 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4695
cfe0661d
JB
46962011-03-09 Juanma Barranquero <lekktu@gmail.com>
4697
4698 * search.c (compile_pattern_1): Remove argument regp, unused since
4699 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4700 (compile_pattern): Don't pass it.
4701
0afb4571
J
47022011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4703
4704 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4705 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4706 for ! HAVE_GTK3.
4707 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4708
4709 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4710
4711 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4712 gdk_window_get_screen, gdk_window_get_geometry,
4713 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4714 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4715 (xg_get_pixbuf_from_pixmap): New function.
4716 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4717 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4718 Call xg_get_pixbuf_from_pixmap instead of
4719 gdk_pixbuf_get_from_drawable.
4720 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4721 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4722 (xg_check_special_colors): Use GtkStyleContext and its functions
4723 for HAVE_GTK3.
4724 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4725 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4726 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4727 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4728 Call gtk_widget_get_preferred_size.
0afb4571
J
4729 (xg_frame_resized): gdk_window_get_geometry only takes 5
4730 parameters.
44f230aa
SM
4731 (xg_win_to_widget, xg_event_is_for_menubar):
4732 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4733 (xg_set_widget_bg): New function.
4734 (delete_cb): New function.
895009e1 4735 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4736 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4737 (xg_set_background_color): Call xg_set_widget_bg.
4738 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4739 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4740 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4741 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4742 if ! HAVE_GTK3.
4743 (update_frame_tool_bar): Call gtk_widget_hide.
4744 (xg_initialize): Use GDK_KEY_g.
4745
4746 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4747 if ! HAVE_GTK3
4748 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4749
4750 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4751 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4752 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4753
1c2cc4ef
JB
47542011-03-08 Juanma Barranquero <lekktu@gmail.com>
4755
4756 * w32xfns.c (select_palette): Check success of RealizePalette against
4757 GDI_ERROR, not zero.
4758
33383987 4759See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4760
4761;; Local Variables:
4762;; coding: utf-8
aac0c6e3
MR
4763;; End:
4764
33383987 4765 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4766
4767 This file is part of GNU Emacs.
4768
4769 GNU Emacs is free software: you can redistribute it and/or modify
4770 it under the terms of the GNU General Public License as published by
4771 the Free Software Foundation, either version 3 of the License, or
4772 (at your option) any later version.
4773
4774 GNU Emacs is distributed in the hope that it will be useful,
4775 but WITHOUT ANY WARRANTY; without even the implied warranty of
4776 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4777 GNU General Public License for more details.
4778
4779 You should have received a copy of the GNU General Public License
4780 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.