* systime.h (Time): Define only if emacs is defined.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
89d1bd22
PE
12011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2
3 * systime.h (Time): Define only if emacs is defined.
4 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5 where the include path doesn't have X11/X.h by default. See
6 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
7
e23640bb 82011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9
10 * composite.c (find_automatic_composition): Fix previous change.
11
b9704ad9
GM
122011-05-20 Glenn Morris <rgm@gnu.org>
13
14 * lisp.mk: New file, split from Makefile.in.
15 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
16 (shortlisp): Remove.
17 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
18
4a720484
GM
192011-05-19 Glenn Morris <rgm@gnu.org>
20
21 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
22 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
23 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
24 (lisp): Set the order to that of loadup.el.
25 (shortlisp): Make it a copy of $lisp.
26 (SOME_MACHINE_LISP): Remove.
27 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
28 Use just $shortlisp, not $SOME_MACHINE_LISP too.
29
a28d4396
KH
302011-05-18 Kenichi Handa <handa@m17n.org>
31
32 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
33 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
34 (find_automatic_composition): Mostly rewrite for efficiency.
35
a2b1fa8e
JB
362011-05-18 Juanma Barranquero <lekktu@gmail.com>
37
38 * makefile.w32-in: Update dependencies.
39
8e1f5610
CS
402011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
41
42 * menu.c: Include limits.h (fixes the MS-Windows build broken by
43 revision 104625).
44
7025ee00 452011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 46
cdfa6eab
PE
47 Fix some integer overflow issues, such as string length overflow.
48
06d6db33
PE
49 * insdel.c (count_size_as_multibyte): Check for string overflow.
50
2b4560a8
PE
51 * character.c (lisp_string_width): Check for string overflow.
52 Use EMACS_INT, not int, for string indexes and lengths; in
53 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
54 the resulting string length overflows an EMACS_INT; instead,
55 report a string overflow if no precision given. When checking for
56 precision exhaustion, use a check that cannot possibly have
57 integer overflow. (Bug#8675)
58 * character.h (lisp_string_width): Adjust to new signature.
59
cb93f9be
PE
60 * alloc.c (string_overflow): New function.
61 (Fmake_string): Use it. This doesn't change behavior, but saves
62 a few bytes and will simplify future changes.
63 * character.c (string_escape_byte8): Likewise.
64 * lisp.h (string_overflow): New decl.
65
1a1f3366
PE
66 Fixups, following up to the user-interface timestamp change.
67 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
68 for UI timestamps, instead of unsigned long.
9fbd6841
PE
69 * msdos.c (mouse_get_pos): Likewise.
70 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
71 * w32gui.h (Time): Define by including "systime.h" rather than by
72 declaring it ourselves. (Bug#8664)
73
d4e3e4d3
PE
74 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
75 * image.c (clear_image_cache): Likewise.
76
f6a24d19
PE
77 * term.c (term_mouse_position): Don't assume time_t wraparound.
78
08dc5ae6
PE
79 Be more systematic about user-interface timestamps.
80 Before, the code sometimes used 'Time', sometimes 'unsigned long',
81 and sometimes 'EMACS_UINT', to represent these timestamps. This
82 change causes it to use 'Time' uniformly, as that's what X uses.
83 This makes the code easier to follow, and makes it easier to catch
84 integer overflow bugs such as Bug#8664.
85 * frame.c (Fmouse_position, Fmouse_pixel_position):
86 Use Time, not unsigned long, for user-interface timestamps.
87 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
88 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
89 * keyboard.h (last_event_timestamp): Likewise.
90 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
91 * menu.h (xmenu_show): Likewise.
92 * term.c (term_mouse_position): Likewise.
93 * termhooks.h (struct input_event.timestamp): Likewise.
94 (struct terminal.mouse_position_hook): Likewise.
95 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
96 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
97 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
98 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
99 what it was before.
100 * menu.h, termhooks.h: Include "systime.h", for Time.
101
8e55734a
PE
102 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
103 Don't assume that the difference between two unsigned long values
104 can fit into an integer. At this point, we know button_down_time
105 <= event->timestamp, so the difference must be nonnegative, so
106 there's no need to cast the result if double-click-time is
107 nonnegative, as it should be; check that it's nonnegative, just in
108 case. This bug is triggered when events are more than 2**31 ms
86db42d2 109 apart (about 25 days). (Bug#8664)
8e55734a 110
841f1b75 111 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 112 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 113
3e26f69c
PE
114 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
115 that always fit in int. Use a sentinel instead of a counter, to
116 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
117 * frame.h (struct frame): Use int for menu_bar_items_used
118 instead of EMACS_INT, since it always fits in int.
3e26f69c 119
5cc152c0
PE
120 * menu.c (grow_menu_items): Check for int overflow.
121
d89eb65e
PE
122 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
123
5235bd3e
PE
124 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
125 Before, the code was not consistent. These values cannot exceed
126 2**31 - 1 so there's no need to make them unsigned.
127 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
128 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
129 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
130 as modifiers.
131 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
132
bc827e23
PE
133 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
134 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
135 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
136 presumably because the widths might not match.
137
78eb494e
PE
138 * window.c (size_window): Avoid needless test at loop start.
139
04f2d78b
CB
1402011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
141
142 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
143
d2fc7e3d 1442011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
145
146 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
147
d2fc7e3d 1482011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
149
150 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
151 `width' to `bar_area_x' and `bar_area_width', respectively.
152 (x_scroll_run): Take account of fringe background extension.
153
04f2d78b
CB
154 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
155 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
156 `bar_area_width', respectively.
157 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
158 background extension.
159
79b70037
GM
1602011-05-10 Jim Meyering <meyering@redhat.com>
161
162 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
163
2f142cc5
JB
1642011-05-10 Juanma Barranquero <lekktu@gmail.com>
165
166 * image.c (Finit_image_library): Return t for built-in image types,
167 like pbm and xbm. (Bug#8640)
168
57679c86
AS
1692011-05-09 Andreas Schwab <schwab@linux-m68k.org>
170
171 * w32menu.c (set_frame_menubar): Fix submenu allocation.
172
888c9e86
EZ
1732011-05-07 Eli Zaretskii <eliz@gnu.org>
174
b0512a1d
EZ
175 * w32console.c (Fset_screen_color): Doc fix.
176 (Fget_screen_color): New function.
177 (syms_of_ntterm): Defsubr it.
178
888c9e86
EZ
179 * callproc.c (call_process_cleanup): Don't close and unlink the
180 temporary file if Fcall_process didn't create it in the first
181 place.
182 (Fcall_process): Don't create tempfile if stdout of the child
183 process will be redirected to a file specified with `:file'.
184 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
185 cue to call_process_cleanup not to close that handle.
186
4d3fcc8e
BK
1872011-05-07 Ben Key <bkey76@gmail.com>
188
189 * makefile.w32-in: The bootstrap-temacs rule now makes use of
190 one of two shell specific rules, either bootstrap-temacs-CMD or
191 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
192 to the previous implementation of the bootstrap-temacs rule.
193 The bootstrap-temacs-CMD rule is similar to the previous
194 implementation of the bootstrap-temacs rule except that it
195 makes use of the ESC_CFLAGS variable instead of the CFLAGS
196 variable.
197
198 These changes, along with some changes to nt/configure.bat,
199 nt/gmake.defs, and nt/nmake.defs, are required to extend my
200 earlier fix to add support for --cflags and --ldflags options
201 that include quotes so that it works whether make uses cmd or
202 sh as the shell.
203
b4289b64
MA
2042011-05-06 Michael Albinus <michael.albinus@gmx.de>
205
206 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
207 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
208 is a constant.
209 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
210 a string. Handle both cases.
211 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
212 (Fdbus_register_method): Use Qinvalid_function.
213
af4c0e28
JB
2142011-05-06 Juanma Barranquero <lekktu@gmail.com>
215
216 * makefile.w32-in: Update dependencies.
217 (LISP_H): Add inttypes.h and stdin.h.
218 (PROCESS_H): Add unistd.h.
219
c51453d9
EZ
2202011-05-06 Eli Zaretskii <eliz@gnu.org>
221
222 * lread.c: Include limits.h (fixes the MS-Windows build broken by
223 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
224
8ff0ac3c 2252011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 226
4c4b566b
PE
227 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
228
aab2b9b5
PE
229 * term.c (vfatal): Remove stray call to va_end.
230 It's not needed and the C Standard doesn't allow it here anyway.
231
c378da0b
PE
232 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
233 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
234
288b08c7
PE
235 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
236 bytes.
237
e3601888
PE
238 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
239
db6c0e74
PE
240 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
241
dd5963ea
PE
242 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
243
88c9450f
PE
244 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
245
2f9442b8
PE
246 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
247
c032b5f8
PE
248 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
249 * charset.c (Fdefine_charset_internal): Don't initialize
250 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 251 32-bit int (Bug#8600).
a108c10b
PE
252
253 * lread.c (read_integer): Be more consistent with string-to-number.
254 Use string_to_number to do the actual conversion; this avoids
255 rounding errors and fixes some other screwups. Without this fix,
256 for example, #x1fffffffffffffff was misread as -2305843009213693952.
257 (digit_to_number): Move earlier, for benefit of read_integer.
258 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 259 not a digit in any supported base. (Bug#8602)
a108c10b 260
ad5f9eea
PE
261 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
262
aec1708a
PE
263 * dispnew.c (scrolling_window): Return 1 if we scrolled,
264 to match comment at start of function. This also removes a
265 GCC warning about overflow in a 32+64-bit port.
266
47be4ab5
PE
267 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
268
371cac43
PE
269 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
270 Reported by Stefan Monnier in
271 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
272 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
273 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 274
d01a7826
PE
275 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
276 (EMACS_UINTPTR): Likewise, with uintptr_t.
277
7fd47d5c
PE
278 * lisp.h: Prefer 64-bit EMACS_INT if available.
279 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
280 on 32-bit hosts that have 64-bit int, so that they can access
281 large files.
122b0c86
PE
282 However, temporarily disable this change unless the temporary
283 symbol WIDE_EMACS_INT is defined.
7fd47d5c 284
8727937b
PE
285 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
286
8ac068ac
PE
287 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
288 This removes an assumption that EMACS_INT and long are the same
289 width as pointers. The assumption is true for Emacs porting targets
290 now, but we want to make other targets possible.
291 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
292 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
293 In the rest of the code, change types of integers that hold casted
294 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
295 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
296 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
297 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
298 No need to cast type when ORing.
299 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
300 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
301 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
302 assume EMACS_INT is the same width as char *.
303 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
304 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
305 Remove no-longer-needed casts.
306 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
307 (xg_tool_bar_help_callback, xg_make_tool_item):
308 Use EMACS_INTPTR to hold an integer
309 that will be cast to void *; this can avoid a GCC warning
310 if EMACS_INT is not the same width as void *.
311 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
312 * xdisp.c (display_echo_area_1, resize_mini_window_1):
313 (current_message_1, set_message_1):
314 Use a local to convert to proper width without a cast.
315 * xmenu.c (dialog_selection_callback): Likewise.
316
ede49d71
PE
317 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
318 Also, don't assume VALBITS / RAND_BITS is less than 5,
319 and don't rely on undefined behavior when shifting a 1 left into
320 the sign bit.
321 * lisp.h (get_random): Change signature to match.
322
2f30ecd0
PE
323 * lread.c (hash_string): Use size_t, not int, for hash computation.
324 Normally we prefer signed values; but hashing is special, because
325 it's better to use unsigned division on hash table sizes so that
326 the remainder is nonnegative. Also, size_t is the natural width
327 for hashing into memory. The previous code used 'int', which doesn't
328 retain enough info to hash well into very large tables.
329 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
330
2a866e7b
PE
331 * dbusbind.c: Don't possibly lose pointer info when converting.
332 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
333 Use XPNTR rather than XHASH, so that the high-order bits of
334 the pointer aren't lost when converting through void *.
335
51639eac
PE
336 * eval.c (Fautoload): Don't double-shift a pointer.
337
92394119
PE
338 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
339
dbdb9a7c
JB
3402011-05-06 Juanma Barranquero <lekktu@gmail.com>
341
342 * gnutls.c (DEF_GNUTLS_FN):
343 * image.c (DEF_IMGLIB_FN): Make function pointers static.
344
db7a0b4f
AS
3452011-05-05 Andreas Schwab <schwab@linux-m68k.org>
346
347 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
348 marker. (Bug#8610)
349
f7ff1b0f 3502011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
351
352 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
353 New version that can reserve upto 2GB of heap space.
354
f7ff1b0f 3552011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
356
357 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
358
639c109b
TZ
3592011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
360
361 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
362 `gnutls_certificate_set_x509_key_file'.
363
d2127135
JB
3642011-05-05 Juanma Barranquero <lekktu@gmail.com>
365
366 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
367 Update dependencies.
368
e968f4f3
JB
3692011-05-04 Juanma Barranquero <lekktu@gmail.com>
370
371 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
372 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
373 Remove unused parameter `fildes'.
374 * process.c (read_process_output, send_process): Don't pass it.
375
84d358f0
JB
3762011-05-04 Juanma Barranquero <lekktu@gmail.com>
377
378 Fix previous change: the library cache is defined in w32.c.
379 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
380 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
381
0898ca10
JB
3822011-05-04 Juanma Barranquero <lekktu@gmail.com>
383
384 Implement dynamic loading of GnuTLS on Windows.
385
386 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
387 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
388 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
389 Declare.
390
391 * gnutls.c (Qgnutls_dll): Define.
392 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
393 (gnutls_*): Declare function pointers.
394 (init_gnutls_functions): New function to initialize function pointers.
395 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
396 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
397 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
398 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
399 (emacs_gnutls_write, emacs_gnutls_read)
400 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
401 (Fgnutls_available_p): New function.
402 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
403 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
404 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
405
406 * image.c: Include w32.h.
407 (Vimage_type_cache): Delete.
408 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
409 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
410 (w32_delayed_load): Move to w32.c.
411
412 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
413
414 * w32.c (QCloaded_from, Vlibrary_cache): Define.
415 (w32_delayed_load): Move from image.c. When loading a library, record
416 its filename in the :loaded-from property of the library id.
417 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
418 Initialize and staticpro them.
419 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
420
421 * process.c: Include lisp.h before w32.h, not after.
422 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
423 instead of gnutls_record_check_pending.
424
425 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
426
ff4de4aa
TZ
4272011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
428
429 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
430 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
431 as passed in.
432
abe95abb
JD
4332011-05-03 Jan Djärv <jan.h.d@swipnet.se>
434
435 * xterm.c (x_set_frame_alpha): Do not set property on anything
436 else than FRAME_X_OUTER_WINDOW (Bug#8608).
437
e16e55d4
JB
4382011-05-02 Juanma Barranquero <lekktu@gmail.com>
439
440 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
441
bafcf6a5
JB
4422011-05-02 Juanma Barranquero <lekktu@gmail.com>
443
444 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
445 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
446 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
447 (gnutls_global_initialized, Qgnutls_bootprop_priority)
448 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
449 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
450 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
451 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
452 (Qgnutls_bootprop_callbacks_verify): Make static.
453
e7a6747f
AS
4542011-05-01 Andreas Schwab <schwab@linux-m68k.org>
455
19ed11ba
AS
456 * callproc.c: Indentation fixup.
457
e7a6747f 458 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
459 (wait_for_termination, interruptible_wait_for_termination):
460 Move after wait_for_termination_1.
e7a6747f 461
1ef14cb4
LMI
4622011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
463
464 * sysdep.c (interruptible_wait_for_termination): New function
465 which is like wait_for_termination, but allows keyboard
466 interruptions.
467
468 * callproc.c (Fcall_process): Add (:file "file") as an option for
469 the STDOUT buffer.
470 (Fcall_process_region): Ditto.
471
330d880c
EZ
4722011-04-30 Eli Zaretskii <eliz@gnu.org>
473
8db90b73
EZ
474 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
475 rather than `XVECTOR (FOO)->size'.
476
330d880c
EZ
477 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
478 inttypes.h, as a gnulib replacement is used if it not available in
479 system headers.
480
15cbd324
EZ
4812011-04-21 Eli Zaretskii <eliz@gnu.org>
482
483 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
484 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
485 of MOST_POSITIVE_FIXNUM. (Bug#8528)
486
487 * coding.c (coding_alloc_by_realloc): Error out if destination
488 will grow beyond MOST_POSITIVE_FIXNUM.
489 (decode_coding_emacs_mule): Abort if there isn't enough place in
490 charbuf for the composition carryover bytes. Reserve an extra
491 space for up to 2 characters produced in a loop.
492 (decode_coding_iso_2022): Abort if there isn't enough place in
493 charbuf for the composition carryover bytes.
494
4952011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 496
ae940cca
EZ
497 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
498 aborting when %lld or %lll format is passed.
499 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
500 %llo or %llx format is passed. (Bug#8545)
501
03ab8921
EZ
502 * window.c (window_scroll_line_based): Use a marker instead of
503 simple variables to record original value of point. (Bug#7952)
504
afda1437
EZ
505 * doprnt.c (doprnt): Fix the case where a multibyte sequence
506 produced by %s or %c overflows available buffer space. (Bug#8545)
507
f76dee0c
PE
5082011-04-28 Paul Eggert <eggert@cs.ucla.edu>
509
510 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 511 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 512
fdc5744d
JB
5132011-04-28 Juanma Barranquero <lekktu@gmail.com>
514
515 * w32.c (init_environment): Warn about defaulting HOME to C:\.
516
638f053a
JB
5172011-04-28 Juanma Barranquero <lekktu@gmail.com>
518
519 * keyboard.c (Qdelayed_warnings_hook): Define.
520 (command_loop_1): Run `delayed-warnings-hook'
521 if Vdelayed_warnings_list is non-nil.
522 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
523 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
524
d178f871
EZ
5252011-04-28 Eli Zaretskii <eliz@gnu.org>
526
527 * doprnt.c (doprnt): Don't return value smaller than the buffer
528 size if the message was truncated. (Bug#8545).
529
b124fd93
JB
5302011-04-28 Juanma Barranquero <lekktu@gmail.com>
531
532 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
533 (Fx_window_property): #if-0 the whole functions, not just the bodies.
534
e810457d
PE
5352011-04-27 Paul Eggert <eggert@cs.ucla.edu>
536
537 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
538
ea51cceb
JB
5392011-04-27 Juanma Barranquero <lekktu@gmail.com>
540
541 * makefile.w32-in: Update dependencies.
542
94dcfacf
EZ
5432011-04-27 Eli Zaretskii <eliz@gnu.org>
544
545 Improve `doprnt' and its usage. (Bug#8545)
546 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
547 `format_end'. Remove support for %l as a conversion specifier.
548 Don't use xrealloc. Improve diagnostics when the %l size modifier
549 is used. Update the commentary.
550
551 * eval.c (verror): Simplify calculation of size_t.
552
553 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
554 messages.
555
f61f41d7
PE
5562011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
557
558 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
559 change.
560
96fb4434
PE
5612011-04-27 Paul Eggert <eggert@cs.ucla.edu>
562
563 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
564 This makes this file independent of the recent pseudovector change.
565
671875da 5662011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 567
69e9b5a3
PE
568 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
569
b5f869a7 570 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 571 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 572 Remove unused local.
c8926152 573 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 574
841a1577 575 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
576 GCC 4.6.0 optimizes based on type-based alias analysis.
577 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
578 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
579 != &v->size, and therefore "v->size = 1; b->size = 2; return
580 v->size;" must therefore return 1. This assumption is incorrect
581 for Emacs, since it type-puns struct Lisp_Vector * with many other
582 types. To fix this problem, this patch adds a new type struct
f904488f 583 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
584 and pseudovectors, and helps optimizing compilers not get fooled
585 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
586 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
587 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
588 the size member.
eab3844f
PE
589 (XSETPVECTYPE): Rewrite in terms of new macro.
590 (XSETPVECTYPESIZE): New macro, specifying both type and size.
591 This is a bit clearer, and further avoids the possibility of
592 undesirable aliasing.
593 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 594 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
595 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
596 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
597 (ASIZE): Now uses header.size rather than size.
598 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
599 to avoid the hassle of writing XVECTOR (foo)->header.size.
600 (struct vectorlike_header): New type.
eab3844f
PE
601 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
602 object, to help avoid aliasing.
603 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
604 (SUBRP): Likewise, since Lisp_Subr is a special case.
605 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
606 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
607 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 608 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
609 changed to be "header.size" and "header.next".
610 * buffer.h (struct buffer): Likewise.
611 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
612 * frame.h (struct frame): Likewise.
613 * process.h (struct Lisp_Process): Likewise.
614 * termhooks.h (struct terminal): Likewise.
615 * window.c (struct save_window_data, struct saved_window): Likewise.
616 * window.h (struct window): Likewise.
617 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
618 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
619 * buffer.c (init_buffer_once): Likewise.
620 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
621 special case.
622 * process.c (Fformat_network_address): Use local var for size,
623 for brevity.
624
0df1eac5
PE
625 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
626
847ab9d1 627 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
628 * data.c (atof): Remove decl; no longer used or needed.
629 (digit_to_number): Move to lread.c.
630 (Fstring_to_number): Use new string_to_number function, to be
631 consistent with how the Lisp reader treats infinities and NaNs.
632 Do not assume that floating-point numbers represent EMACS_INT
633 without losing information; this is not true on most 64-bit hosts.
634 Avoid double-rounding errors, by insisting on integers when
635 parsing non-base-10 numbers, as the documentation specifies.
636 * lisp.h (string_to_number): New decl, replacing ...
637 (isfloat_string): Remove.
bc0a5c13 638 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 639 (read1): Do not accept +. and -. as integers; this
452f4150
PE
640 appears to have been a coding error. Similarly, do not accept
641 strings like +-1e0 as floating point numbers. Do not report
642 overflow for integer overflows unless the base is not 10 which
643 means we have no simple and reliable way to continue.
644 Break out the floating-point parsing into a new
645 function string_to_number, so that Fstring_to_number parses
646 floating point numbers consistently with the Lisp reader.
04f2d78b 647 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
648 (E_CHAR, EXP_INT): Remove, replacing with ...
649 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
650 (string_to_number): New function, replacing isfloat_string.
651 This function checks for valid syntax and produces the resulting
652 Lisp float number too. Rework it so that string-to-number
bc0a5c13 653 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
654 so that overflow for non-base-10 numbers is reported only when
655 there's no portable and simple way to convert to floating point.
452f4150 656
67769ffc
PE
657 * textprop.c (set_text_properties_1): Rewrite for clarity,
658 and to avoid GCC warning about integer overflow.
659
c20db43f
PE
660 * intervals.h (struct interval): Use EMACS_INT for members
661 where EMACS_UINT might cause problems. See
662 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
663 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
664 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
665 All uses changed.
37aa2f85
PE
666 (offset_intervals): Tell GCC not to worry about length overflow
667 when negating a negative length.
c20db43f 668
2538aa2f
PE
669 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
670 (overrun_check_free): Likewise.
671
f2d3008d
PE
672 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
673 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
674 word size.
675
ec8df744
PE
676 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
677 (gnutls_make_error): Rename local to avoid shadowing.
678 (gnutls_emacs_global_deinit): ifdef out; not used.
679 (Fgnutls_boot): Use const for pointer to readonly storage.
680 Comment out unused local. Fix pointer signedness problems.
681
640ee02d
PE
682 * lread.c (openp): Don't stuff size_t into an 'int'.
683 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
684 about possible signed overflow.
685
6048fb2a
PE
686 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
687 (GDK_KEY_g): Don't define if already defined.
688 (xg_prepare_tooltip): Avoid pointer signedness problem.
689 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
690
fa3c87e1
PE
691 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
692 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
693
2172544b
PE
694 * xfns.c (Fx_window_property): Simplify a bit,
695 to make a bit faster and to avoid GCC 4.6.0 warning.
696 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
697
9b821a21
PE
698 * fns.c (internal_equal): Don't assume size_t fits in int.
699
3c616cfa
PE
700 * alloc.c (compact_small_strings): Tighten assertion a little.
701
c2982e87
PE
702 Replace pEd with more-general pI, and fix some printf arg casts.
703 * lisp.h (pI): New macro, generalizing old pEd macro to other
704 conversion specifiers. For example, use "...%"pI"d..." rather
705 than "...%"pEd"...".
706 (pEd): Remove. All uses replaced with similar uses of pI.
707 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
708 * alloc.c (check_pure_size): Don't overflow by converting size to int.
709 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
710 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
711 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
712 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
713 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
714 64-bit hosts.
715 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
716 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
717 * print.c (safe_debug_print, print_object): Likewise.
718 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
719 to int.
6f04d126
PE
720 Use pI instead of if-then-else-abort. Use %p to avoid casts,
721 avoiding the 0 flag, which is not portable.
c2982e87
PE
722 * process.c (Fmake_network_process): Use pI to avoid cast.
723 * region-cache.c (pp_cache): Likewise.
724 * xdisp.c (decode_mode_spec): Likewise.
725 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
726 behavior on 64-bit hosts with printf arg.
6f04d126 727 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
728 (x_stop_queuing_selection_requests): Likewise.
729 (x_get_window_property): Don't truncate byte count to an 'int'
730 when tracing.
0b432f21 731
5e073ec7
PE
732 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
733 here, since it parses constructs like leading '-' and spaces,
734 which are not wanted; and it overflows with large numbers.
735 Instead, simply match F[0-9]+, which is what is wanted anyway.
736
36372bf9
PE
737 * alloc.c: Remove unportable assumptions about struct layout.
738 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
739 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
740 (allocate_vectorlike, make_pure_vector): Use the new macros,
741 plus offsetof, to remove unportable assumptions about struct layout.
742 These assumptions hold on all porting targets that I know of, but
743 they are not guaranteed, they're easy to remove, and removing them
744 makes further changes easier.
745
0b432f21
PE
746 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
747 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
748 (string_overrun_cookie): Now const. Use initializers that
749 don't formally overflow signed char, to avoid warnings.
000098c1
PE
750 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
751 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
752 (allocate_buffer): Don't assume sizeof (struct buffer) is a
753 multiple of sizeof (EMACS_INT); it need not be, if
754 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 755 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 756
895009e1
JB
7572011-04-26 Juanma Barranquero <lekktu@gmail.com>
758
759 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
760
6a7a1b0b
TZ
7612011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
762
763 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 764 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
765 Reported by Paul Eggert <eggert@cs.ucla.edu>.
766
841a1577 7672011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
768
769 * lisp.h (Qdebug): List symbol.
895009e1 770 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
771 * keyboard.c (debug-on-event): New variable.
772 (handle_user_signal): Break into debugger when debug-on-event
773 matches the current signal symbol.
774
f2d3ba6f
DN
7752011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
776
777 * alloc.c (check_sblock, check_string_bytes)
778 (check_string_free_list): Convert to standard C.
779
42ce4c63
TZ
7802011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
781
782 * w32.c (emacs_gnutls_push): Fix typo.
783
825cd63c
EZ
7842011-04-25 Eli Zaretskii <eliz@gnu.org>
785
fb11d64d
EZ
786 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
787 "cast to pointer from integer of different size".
788
825cd63c
EZ
789 Improve doprnt and its use in verror. (Bug#8545)
790 * doprnt.c (doprnt): Document the set of format control sequences
791 supported by the function. Use SAFE_ALLOCA instead of always
792 using `alloca'.
793
794 * eval.c (verror): Don't limit the buffer size at size_max-1, that
795 is one byte too soon. Don't use xrealloc; instead xfree and
796 xmalloc anew.
797
e061a11b
TZ
7982011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
799
800 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
801 callbacks stage.
802
803 * gnutls.c: Renamed global_initialized to
804 gnutls_global_initialized. Added internals for the
805 :verify-hostname-error, :verify-error, and :verify-flags
806 parameters of `gnutls-boot' and documented those parameters in the
807 docstring. Start callback support.
808 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
809 unless a fatal error occured. Call gnutls_alert_send_appropriate
810 on error. Return error code.
811 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
812 (emacs_gnutls_read): Likewise.
813 (Fgnutls_boot): Return handshake error code.
814 (emacs_gnutls_handle_error): New function.
815 (wsaerror_to_errno): Likewise.
816
817 * w32.h (emacs_gnutls_pull): Add prototype.
818 (emacs_gnutls_push): Likewise.
819
820 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
821 (emacs_gnutls_push): Likewise.
822
8232011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
824
825 * process.c (wait_reading_process_output): Check if GnuTLS
826 buffered some data internally if no FDs are set for TLS
827 connections.
828
829 * makefile.w32-in (OBJ2): Add gnutls.$(O).
830 (LIBS): Link to USER_LIBS.
831 ($(BLD)/gnutls.$(0)): New target.
832
fa6996bc
EZ
8332011-04-24 Eli Zaretskii <eliz@gnu.org>
834
eb35682e
EZ
835 * xdisp.c (handle_single_display_spec): Rename the
836 display_replaced_before_p argument into display_replaced_p, to
837 make it consistent with the commentary. Fix typos in the
838 commentary.
839
e2ad650c
EZ
840 * textprop.c (syms_of_textprop): Remove dead code.
841 (copy_text_properties): Delete obsolete commentary about an
842 interface that was deleted long ago. Fix typos in the description
843 of arguments.
844
1b2de274
EZ
845 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
846 to changes in oldXMenu/XMenu.h from 2011-04-16.
847 <menu_help_message, prev_menu_help_message>: Constify.
848 (IT_menu_make_room): menu->help_text is now `const char **';
849 adjust.
850
851 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
852 to changes in oldXMenu/XMenu.h from 2011-04-16.
853 (struct XMenu): Declare `help_text' `const char **'.
854
855 * xfaces.c <Qunspecified>: Make extern again.
856
857 * syntax.c: Include sys/types.h before including regex.h, as
858 required by Posix.
859
762b15be
EZ
860 * doc.c (get_doc_string): Improve the format passed to `error'.
861
862 * doprnt.c (doprnt): Improve commentary.
863
864 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
865
866 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
867 them with etags.
868
f1052e5d
EZ
869 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
870 changes in globals.h immediately force recompilation.
762b15be
EZ
871 (TAGS): Depend on $(CURDIR)/m/intel386.h and
872 $(CURDIR)/s/ms-w32.h.
873 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 874
fa6996bc
EZ
875 * character.c (Fchar_direction): Function deleted.
876 (syms_of_character): Don't defsubr it.
877 <char-direction-table>: Deleted.
878
e6c3da20
EZ
8792011-04-23 Eli Zaretskii <eliz@gnu.org>
880
881 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
882 * doprnt.c: Include limits.h.
883 (SIZE_MAX): New macro.
04f2d78b
CB
884 (doprnt): Return a size_t value. 2nd arg is now size_t.
885 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
886 Improve overflow protection. Support `l' modifier for integer
887 conversions. Support %l conversion. Don't assume an EMACS_INT
888 argument for integer conversions and for %c.
889
890 * lisp.h (doprnt): Restore prototype.
891
892 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
893 $(SRC)/character.h.
894
895 * Makefile.in (base_obj): Add back doprnt.o.
896
897 * deps.mk (doprnt.o): Add back prerequisites.
898 (callint.o): Depend on character.h.
899
900 * eval.c (internal_lisp_condition_case): Include the handler
901 representation in the error message.
902 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
903 when breaking from the loop.
904
905 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
906
907 * callint.c (Fcall_interactively): When displaying error message
908 about invalid control letter, pass the character's codepoint, not
909 a pointer to its multibyte form. Improve display of the character
910 in octal and display also its hex code.
911
912 * character.c (char_string): Use %x to display the (unsigned)
913 codepoint of an invalid character, to avoid displaying a bogus
914 negative value.
915
916 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
917 `error', not SYMBOL_NAME itself.
918
919 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
920 character arguments to `error'.
921
922 * charset.c (check_iso_charset_parameter): Fix incorrect argument
923 to `error' in error message about FINAL_CHAR argument. Make sure
924 FINAL_CHAR is a character, and use %c when it is passed as
925 argument to `error'.
926
4ffd0d6b 9272011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
928
929 * s/ms-w32.h (localtime): Redirect to sys_localtime.
930
931 * w32.c: Include <time.h>.
932 (sys_localtime): New function.
933
4ffd0d6b 9342011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
935
936 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
937
4ffd0d6b 938 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 939
4ffd0d6b 9402011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 941
4ffd0d6b
GM
942 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
943 zombies (Bug#8467).
aac0c6e3 944
04c56954
EZ
9452011-04-19 Eli Zaretskii <eliz@gnu.org>
946
947 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
948 gl_state.e_property when gl_state.object is Qt.
949
950 * insdel.c (make_gap_larger): Remove limitation of buffer size
951 to <= INT_MAX.
952
16a43933
CY
9532011-04-18 Chong Yidong <cyd@stupidchicken.com>
954
955 * xdisp.c (lookup_glyphless_char_display)
956 (produce_glyphless_glyph): Handle cons cell entry in
957 glyphless-char-display.
958 (Vglyphless_char_display): Document it.
959
960 * term.c (produce_glyphless_glyph): Handle cons cell entry in
961 glyphless-char-display.
962
4581706e
CY
9632011-04-17 Chong Yidong <cyd@stupidchicken.com>
964
965 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
966
967 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
968
969 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
970 definition for no-X builds.
971
4887c6e2 9722011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 973
fd35b6f9
PE
974 Static checks with GCC 4.6.0 and non-default toolkits.
975
5c1ccb01
PE
976 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
977
006c5daa
PE
978 * process.c (keyboard_bit_set): Define only if SIGIO.
979 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
980 (send_process): Repair possible setjmp clobbering.
981
efc736d3
PE
982 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
983
4e2fe2e6
PE
984 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
985
f97334a2
PE
986 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
987
4e75f29d
PE
988 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
989 Define only if needed.
990
90efadd1
PE
991 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
992 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 993 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 994
3c647824
PE
995 * dispextern.h (struct redisplay_interface): Rename param
996 to avoid shadowing.
e264f262 997 * termhooks.h (struct terminal): Likewise.
761383f4 998 * xterm.c (xembed_send_message): Likewise.
3c647824 999
b58c5c4a
PE
1000 * insdel.c (make_gap_smaller): Define only if
1001 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1002
cad59032
PE
1003 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1004 it.
1005
c339dc2e
PE
1006 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1007 so that we aren't warned about unused symbols.
1008
91a3e27b
PE
1009 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1010
399c71d3 1011 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1012
8ffc96f5
PE
1013 * xfns.c (x_real_positions): Mark locals as initialized.
1014
eef9bc79
PE
1015 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1016
098db9dd
PE
1017 * xterm.c: Fix problems found by static analysis with other toolkits.
1018 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1019 (x_dispatch_event): Declare static if USE_GTK, and
1020 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1021 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1022 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1023 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1024 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1025
eb18f6cc
PE
1026 * xmenu.c (menu_help_callback): Pointer type fixes.
1027 Use const pointers when pointing at readonly data. Avoid pointer
1028 signedness clashes.
1029 (FALSE): Remove unused macro.
1030 (update_frame_menubar): Remove unused decl.
1031
1fe72bf8
PE
1032 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1033
60d9e1db
PE
1034 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1035 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1036 (single_menu_item): Rename local to avoid shadowing.
1037
39261c26
PE
1038 * keyboard.c (make_lispy_event): Remove unused local var.
1039
018c5e19
PE
1040 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1041 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1042
63d2b86e
PE
1043 * bitmaps: Change bitmaps from unsigned char back to the X11
1044 compatible char. Avoid the old compiler warnings about
1045 out-of-range initializers by using, for example, '\xab' rather
1046 than 0xab.
1047
aefd87e1
PE
1048 * xgselect.c (xgselect_initialize): Check vs interface
1049 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1050
bf501fb9
PE
1051 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1052
e9829fdf
PE
1053 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1054 to read-only memory.
1055
1086c095
PE
1056 * fns.c (vector): Remove; this old hack is no longer needed.
1057
2baccd04 1058 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1059 Remove unused var.
dde42981 1060 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1061
72391843 1062 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1063
436c16df 1064 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1065 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1066 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1067
92bb796d 1068 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1069 (x_term_init): Remove local to avoid shadowing.
92bb796d 1070
764430a3 1071 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1072
1073 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1074 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1075
d1dfb56c
EZ
10762011-04-16 Eli Zaretskii <eliz@gnu.org>
1077
c4354cb4
EZ
1078 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1079
d1dfb56c
EZ
1080 Fix regex.c, syntax.c and friends for buffers > 2GB.
1081 * syntax.h (struct gl_state_s): Declare character position members
1082 EMACS_INT.
1083
1084 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1085
04f2d78b
CB
1086 * textprop.c (verify_interval_modification, interval_of):
1087 Declare arguments EMACS_INT.
d1dfb56c
EZ
1088
1089 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1090 EMACS_INT.
1091
1092 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1093
1094 * indent.c (Fvertical_motion): Local variable it_start is now
1095 EMACS_INT.
1096
1097 * regex.c (re_match, re_match_2, re_match_2_internal)
1098 (bcmp_translate, regcomp, regexec, print_double_string)
1099 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1100 (re_compile_pattern, re_exec): Declare arguments and local
1101 variables `size_t' and `ssize_t' and return values `regoff_t', as
1102 appropriate.
1103 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1104 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1105 <compile_stack_type>: `size' and `avail' are now `size_t'.
1106
1107 * regex.h <regoff_t>: Use ssize_t, not int.
1108 (re_search, re_search_2, re_match, re_match_2): Arguments that
1109 specify buffer/string position and length are now ssize_t and
1110 size_t. Return type is regoff_t.
1111
613052cd
BK
11122011-04-16 Ben Key <bkey76@gmail.com>
1113
1114 * nsfont.m: Fixed bugs in ns_get_family and
1115 ns_descriptor_to_entity that were caused by using free to
1116 deallocate memory blocks that were allocated by xmalloc (via
1117 xstrdup). This caused Emacs to crash when compiled with
1118 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1119 --enable-checking=xmallocoverrun). xfree is now used to
1120 deallocate these memory blocks.
1121
4170f62f 11222011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1123
71b41406
PE
1124 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1125
9587a89d
PE
1126 emacs_write: Accept and return EMACS_INT for sizes.
1127 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1128 et seq.
1129 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1130 Accept and return EMACS_INT.
1131 (emacs_gnutls_write): Return the number of bytes written on
1132 partial writes.
1133 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1134 (emacs_read, emacs_write): Remove check for negative size, as the
1135 Emacs source code has been audited now.
9587a89d
PE
1136 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1137 (emacs_read, emacs_write): Use it.
273a5f82
PE
1138 * process.c (send_process): Adjust to the new signatures of
1139 emacs_write and emacs_gnutls_write. Do not attempt to store
1140 a byte offset into an 'int'; it might overflow.
9587a89d 1141 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1142
3e047f51
PE
1143 * sound.c: Don't assume sizes fit in 'int'.
1144 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1145 Return EMACS_INT, not int.
3e047f51 1146 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1147 Accept EMACS_INT, not int.
1148 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1149 record read return values.
1150
cc39a9db
BK
11512011-04-15 Ben Key <bkey76@gmail.com>
1152
c9d0ec6d
JB
1153 * keyboard.c (Qundefined): Don't declare static since it is used
1154 in nsfns.m.
1155 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1156 static since they are used in nsfont.m.
cc39a9db 1157
6c60eb9f
SM
11582011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1159
1160 * process.c (Qprocessp): Don't declare static.
1161 * lisp.h (Qprocessp): Declare again.
1162
7990b61a
JB
11632011-04-15 Juanma Barranquero <lekktu@gmail.com>
1164
1165 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1166
5d4cb038
PE
11672011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1168
8bd7b830 1169 Improve C-level modularity by making more things 'static'.
cd64ea1d 1170
e3b27b31
PE
1171 Don't publish debugger-only interfaces to other modules.
1172 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1173 (verify_bytepos, count_markers): Move decls to the only modules
1174 that need them.
1175 * region-cache.h (pp_cache): Likewise.
1176 * window.h (check_all_windows): Likewise.
1177 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1178
5d4cb038
PE
1179 * sysdep.c (croak): Now static, if
1180 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1181 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1182
1183 * alloc.c (refill_memory_reserve): Now static if
1184 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1185 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1186
e87b6180
PE
1187 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1188 Define only if USE_LUCID.
1189
ac64929e
PE
1190 * xrdb.c (x_customization_string, x_rm_string): Now static.
1191
6f37259d
PE
1192 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1193 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1194
1683e3ab
PE
1195 * xdisp.c (draw_row_with_mouse_face): Now static.
1196 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1197
de9c2632
PE
1198 * window.h (check_all_windows): Mark externally visible.
1199
2b96acb7
PE
1200 * window.c (window_deletion_count): Now static.
1201
1202 * undo.c: Make symbols static if they're not exported.
1203 (last_undo_buffer, last_boundary_position, pending_boundary):
1204 Now static.
1205
50436f33
PE
1206 * textprop.c (interval_insert_behind_hooks): Now static.
1207 (interval_insert_in_front_hooks): Likewise.
1208
64520e5c
PE
1209 * term.c: Make symbols static if they're not exported.
1210 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1211 (max_frame_lines, tty_set_terminal_modes):
1212 (tty_reset_terminal_modes, tty_turn_off_highlight):
1213 (get_tty_terminal): Now static.
1214 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1215 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1216 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1217 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1218 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1219
1fa53021
PE
1220 * sysdep.c: Make symbols static if they're not exported.
1221 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1222 Now static.
1223 (sigprocmask_set, full_mask): Remove; unused.
1224 (wait_debugging): Mark as visible.
1225 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1226 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1227
d4b43b22
PE
1228 * syntax.c (syntax_temp): Define only if !__GNUC__.
1229
b7c513d0
PE
1230 * sound.c (current_sound_device, current_sound): Now static.
1231
989b29ad
PE
1232 * search.c (searchbufs, searchbuf_head): Now static.
1233
13a55a78
PE
1234 * scroll.c (scroll_cost): Remove; unused.
1235 * dispextern.h (scroll_cost): Remove decl.
1236
de68a1fc
PE
1237 * region-cache.h (pp_cache): Mark as externally visible.
1238
40ccffa6
PE
1239 * process.c: Make symbols static if they're not exported.
1240 (process_tick, update_tick, create_process, chan_process):
1241 (Vprocess_alist, proc_buffered_char, datagram_access):
1242 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1243 (deactivate_process): Mark defn as static, as well as decl.
1244 * lisp.h (create_process): Remove decl.
1245 * process.h (chan_process, Vprocess_alist): Remove decls.
1246
ad64fc97
PE
1247 * print.c: Make symbols static if they're not exported.
1248 (print_depth, new_backquote_output, being_printed, print_buffer):
1249 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1250 (print_interval, print_number_index, initial_stderr_stream):
1251 Now static.
1252 * lisp.h (Fprinc): Remove decl.
1253 (debug_output_compilation_hack): Mark as externally visible.
1254
adddb265
PE
1255 * sysdep.c (croak): Move decl from here to syssignal.h.
1256 * syssignal.h (croak): Put it here, so the API can be checked when
1257 'croak' is called from dissociate_if_controlling_tty.
1258
1717ede2
PE
1259 * minibuf.c: Make symbols static if they're not exported.
1260 (minibuf_save_list, choose_minibuf_frame): Now static.
1261 * lisp.h (choose_minibuf_frame): Remove decl.
1262
fa5fb2bc
PE
1263 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1264
1e3890d1
PE
1265 * lread.c: Make symbols static if they're not exported.
1266 (read_objects, initial_obarray, oblookup_last_bucket_number):
1267 Now static.
1268 (make_symbol): Remove; unused.
1269 * lisp.h (initial_obarray, make_symbol): Remove decls.
1270
8a1414fa
PE
1271 * keyboard.c: Make symbols static if they're not exported.
1272 (single_kboard, recent_keys_index, total_keys, recent_keys):
1273 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1274 (this_single_command_key_start, echoing, last_auto_save):
1275 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1276 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1277 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1278 (Vlispy_mouse_stem, double_click_count):
1279 Now static.
1280 (force_auto_save_soon): Define only if SIGDANGER.
1281 (ignore_mouse_drag_p): Now static if
1282 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1283 (print_help): Remove; unused.
1284 (stop_character, last_timer_event): Mark as externally visible.
1285 * keyboard.h (ignore_mouse_drag_p): Declare only if
1286 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1287 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1288 * lisp.h (echoing): Remove decl.
1289 (force_auto_save_soon): Declare only if SIGDANGER.
1290 * xdisp.c (redisplay_window): Simplify code, to make it more
1291 obvious that ignore_mouse_drag_p is not accessed if !defined
1292 USE_GTK && !defined HAVE_NS.
1293
93ea6e8f
PE
1294 * intervals.c: Make symbols static if they're not exported.
1295 (merge_properties_sticky, merge_interval_right, delete_interval):
1296 Now static.
1297 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1298
77382fcc
PE
1299 * insdel.c: Make symbols static if they're not exported.
1300 However, leave prepare_to_modify_buffer alone. It's never
1301 called from outside this function, but that appears to be a bug.
1302 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1303 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1304 (adjust_after_replace_noundo): Remove; unused.
1305 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1306 (signal_before_change): Remove decls.
77382fcc 1307
9306c32e
PE
1308 * indent.c (val_compute_motion, val_vmotion): Now static.
1309
cd44d2eb
PE
1310 * image.c: Make symbols static if they're not exported.
1311 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1312 if USE_GTK.
1313 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1314 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1315
ad9a7a06
PE
1316 * fringe.c (standard_bitmaps): Now static.
1317 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1318
81626931
PE
1319 * frame.c: Make symbols static if they're not exported.
1320 (x_report_frame_params, make_terminal_frame): Now static.
1321 (get_frame_param): Now static, unless HAVE_NS.
1322 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1323 (x_get_resource_string): Remove; not used.
1324 * frame.h (make_terminal_frame, x_report_frame_params):
1325 (x_get_resource_string); Remove decls.
1326 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1327 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1328
239f9db9
PE
1329 * font.c, fontset.c: Make symbols static if they're not exported.
1330 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1331 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1332 * font.c (font_close_object): Now static.
1333 * font.h (font_close_object): Remove.
1334 * fontset.c (FONTSET_OBJLIST): Remove.
1335 (free_realized_fontset) #if-0 the body, which does nothing.
1336 (face_suitable_for_char_p): #if-0, as it's never called.
1337 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
1338 * xfaces.c (face_at_string_position):
1339 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
1340 since 0 is always ASCII.
1341
dfcf3579
PE
1342 * fns.c (weak_hash_tables): Now static.
1343
5045092b
PE
1344 * fileio.c: Make symbols static if they're not exported.
1345 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1346 (Vwrite_region_annotation_buffers): Now static.
1347
57a96f5c
PE
1348 * eval.c: Make symbols static if they're not exported.
1349 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1350 * lisp.h (backtrace_list): Remove decl.
1351
35f08c38
PE
1352 * emacs.c: Make symbols static if they're not exported.
1353 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1354 (fatal_error_code, fatal_error_signal_hook, standard_args):
1355 Now static.
1356 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1357 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1358 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1359 * lisp.h (fatal_error_signal_hook): Remove decl.
1360 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1361
f44bd759
PE
1362 * editfns.c: Move a (normally-unused) function to its only use.
1363 * editfns.c, lisp.h (get_operating_system_release): Remove.
1364 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1365 worth the hassle of breaking this out.
1366
b532497d
PE
1367 * xterm.c: Make symbols static if they're not exported.
1368 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1369 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1370 (x_destroy_window, x_delete_display):
1371 Now static.
1372 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1373 (x_mouse_leave): Remove; unused.
1374 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1375 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1376 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1377 Remove decls.
1378 (x_mouse_leave): Declare only if WINDOWSNT.
1379 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1380 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1381 USE_X_TOOLKIT.
1382
1675728f
PE
1383 * ftxfont.c: Make symbols static if they're not exported.
1384 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1385 HAVE_FREETYPE.
1386 * font.h (ftxfont_driver): Likewise.
1387
e4cebfca
PE
1388 * xfns.c: Make symbols static if they're not exported.
1389 (x_last_font_name, x_display_info_for_name):
1390 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1391 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1392 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1393 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1394 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1395 (last_show_tip_args): Now static.
1396 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1397 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1398 (x_screen_planes): Remove; unused.
1399 * dispextern.h (x_screen_planes): Remove decl.
1400
5bf46f05
PE
1401 * dispnew.c: Make symbols static if they're not exported.
1402 * dispextern.h (redraw_garbaged_frames, scrolling):
1403 (increment_row_positions): Remove.
1404 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1405 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1406 Now static.
1407 (redraw_garbaged_frames): Remove; unused.
1408
435f4c28
PE
1409 * xfaces.c: Make symbols static if they're not exported.
1410 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1411 Remove decls.
1412 * xterm.h (defined_color): Remove decls.
1413 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1414 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1415 (menu_face_changed_default, defined_color, free_realized_face):
1416 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1417 (ascii_face_of_lisp_face): Remove; unused.
1418
8524aef3
PE
1419 * xdisp.c: Make symbols static if they're not exported.
1420 * dispextern.h (scratch_glyph_row, window_box_edges):
1421 (glyph_to_pixel_coords, set_cursor_from_row):
1422 (get_next_display_element, set_iterator_to_next):
1423 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1424 (show_mouse_face): Remove decls
1425 * frame.h (message_buf_print): Likewise.
1426 * lisp.h (pop_message, set_message, check_point_in_composition):
1427 Likewise.
1428 * xterm.h (set_vertical_scroll_bar): Likewise.
1429 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1430 (message_buf_print, scratch_glyph_row, displayed_buffer):
1431 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1432 (get_next_display_element, show_mouse_face, window_box_edges):
1433 (frame_to_window_pixel_xy, check_point_in_composition):
1434 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1435 (glyph_to_pixel_coords): Remove; unused.
1436
16390cd2
PE
1437 * dired.c (file_name_completion): Now static.
1438
1439 * dbusbind.c (xd_in_read_queued_messages): Now static.
1440
a25f4dfa
PE
1441 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1442 * data.c (circular_list_error): Remove.
1443
14a9c8df
PE
1444 * commands.h (last_point_position, last_point_position_buffer):
1445 (last_point_position_window): Remove decls.
1446 * keyboard.c: Make these variables static.
1447
04f2d78b
CB
1448 * coding.h (coding, code_convert_region, encode_coding_gap):
1449 Remove decls.
74ab6df5
PE
1450 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1451 (iso_code_class, detect_coding, code_convert_region): Now static.
1452 (encode_coding_gap): Remove; unused.
1453
38dfbee1
PE
1454 * chartab.c (chartab_chars, chartab_bits): Now static.
1455
a2cb4e63
PE
1456 * charset.h (charset_iso_8859_1): Remove decl.
1457 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1458 Now static.
1459
127198fd
PE
1460 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1461 * ccl.c (Vccl_program_table): Now static.
1462 (check_ccl_update): Remove; unused.
1463
d85b608f
PE
1464 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1465 * category.h: ... from here.
1466 * category.c (check_category_table, set_category_set): Now static.
1467
31cd66f3
PE
1468 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1469 * lisp.h: Remove these decls.
1470
c358e587
PE
1471 * buffer.c (buffer_count): Remove unused var.
1472
e78aecca
PE
1473 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1474 so that it's not optimized away.
1475 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1476 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1477 exported only to the debugger.
1478
e192d7d3 1479 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 1480 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 1481
92470028
PE
1482 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1483 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1484 was inaccessible from Lisp.
1485 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1486 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1487
244ed907
PE
1488 alloc.c: Import and export fewer symbols, and remove unused items.
1489 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1490 is defined.
1491 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1492 it's not optimized away by whole-program optimization.
1493 (message_enable_multibyte, free_misc): Remove.
1494 (catchlist, handlerlist, mark_backtrace):
1495 Declare only if BYTE_MARK_STACK.
1496 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1497 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1498 (message_enable_multibyte): Remove decl.
1499 (free_misc, interval_free_list, float_block, float_block_index):
1500 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1501 (cons_free_list, last_marked_index):
1502 Now static.
1503 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1504 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1505 (mark_backtrace): Define only if BYTE_MARK_STACK.
1506 * xdisp.c (message_enable_multibyte): Now static.
1507
61c2b50e 1508 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1509 This makes it easier for human readers (and static analyzers)
1510 to see whether these variables are used from other modules.
1511 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1512 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1513 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1514 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1515 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1516 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1517 * xmenu.c, xselect.c:
1518 Declare Q* vars static if they are not used in other modules.
1519 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1520 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1521 Remove decls of unexported vars.
1522 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1523
95c82688
PE
1524 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1525
16a97296
PE
1526 Make Emacs functions such as Fatom 'static' by default.
1527 This makes it easier for human readers (and static analyzers)
1528 to see whether these functions can be called from other modules.
1529 DEFUN now defines a static function. To make the function external
1530 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1531 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1532 (Finit_image_library):
16a97296
PE
1533 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1534 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1535 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1536 Remove decls, since these functions are now static.
1537 (Funintern, Fget_internal_run_time): New decls, since these functions
1538 were already external.
95c82688 1539
16a97296
PE
1540 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1541 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1542 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1543 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1544 * keyboard.c, keymap.c, lread.c:
1545 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1546 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1547 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1548 Mark functions with DEFUE instead of DEFUN,
1549 if they are used in other modules.
1550 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1551 decls for now-static functions.
1552 * buffer.h (Fdelete_overlay): Remove decl.
1553 * callproc.c (Fgetenv_internal): Mark as internal.
1554 * composite.c (Fremove_list_of_text_properties): Remove decl.
1555 (Fcomposition_get_gstring): New forward static decl.
1556 * composite.h (Fcomposite_get_gstring): Remove decl.
1557 * dired.c (Ffile_attributes): New forward static decl.
1558 * doc.c (Fdocumntation_property): New forward static decl.
1559 * eval.c (Ffetch_bytecode): New forward static decl.
1560 (Funintern): Remove extern decl; now in .h file where it belongs.
1561 * fileio.c (Fmake_symbolic_link): New forward static decl.
1562 * image.c (Finit_image_library): New forward static decl.
1563 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1564 * intervals.h (Fprevious_property_change):
1565 (Fremove_list_of_text_properties): Remove decls.
1566 * keyboard.c (Fthis_command_keys): Remove decl.
1567 (Fcommand_execute): New forward static decl.
1568 * keymap.c (Flookup_key): New forward static decl.
1569 (Fcopy_keymap): Now static.
1570 * keymap.h (Flookup_key): Remove decl.
1571 * process.c (Fget_process): New forward static decl.
1572 (Fprocess_datagram_address): Mark as internal.
1573 * syntax.c (Fsyntax_table_p): New forward static decl.
1574 (skip_chars): Remove duplicate decl.
1575 * textprop.c (Fprevious_property_change): New forward static decl.
1576 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1577 Now internal.
1578 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1579 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1580
785bbd42
PE
1581 * editfns.c (Fformat): Remove unreachable code.
1582
8b913b57
AS
15832011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1584
1585 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1586 change. (Bug#8496)
1587
a6744a35
EZ
15882011-04-13 Eli Zaretskii <eliz@gnu.org>
1589
1590 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1591 when at ZV. (Bug#8487)
1592
e7974947
AS
15932011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1594
baad03f0
AS
1595 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1596 (Bug#8437)
1597 * keyboard.c (parse_tool_bar_item): Likewise.
1598 * sound.c (sound_cleanup, alsa_close): Likewise.
1599 * termcap.c (tgetent): Likewise.
1600 * xfns.c (x_default_font_parameter): Likewise.
1601 * xsettings.c (read_and_apply_settings): Likewise.
1602
e7974947
AS
1603 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1604 (overrun_check_free): Protoize.
1605
28272684
PE
16062011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1607
1608 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1609 since callers should never pass a negative size.
1610 Change the signature to match that of plain 'read' and 'write'; see
1611 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1612 * lisp.h: Update prototypes of emacs_write and emacs_read.
1613
11997c76
EZ
16142011-04-11 Eli Zaretskii <eliz@gnu.org>
1615
1616 * xdisp.c (redisplay_window): Don't try to determine the character
1617 position of the scroll margin if the window start point w->startp
e896f03c 1618 is outside the buffer's accessible region. (Bug#8468)
11997c76 1619
8a2cbd72
EZ
16202011-04-10 Eli Zaretskii <eliz@gnu.org>
1621
1622 Fix write-region and its subroutines for buffers > 2GB.
1623 * fileio.c (a_write, e_write): Modify declaration of arguments and
1624 local variables to support buffers larger than 2GB.
1625 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1626
1627 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1628 argument, local variables, and return value.
1629
1630 * lisp.h: Update prototypes of emacs_write and emacs_read.
1631
1632 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1633
4073e537 16342011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1635
1ebfdcb6
PE
1636 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1637
b2ded58d
PE
1638 Fix more problems found by GCC 4.6.0's static checks.
1639
7d66342c
PE
1640 * xdisp.c (vmessage): Use a better test for character truncation.
1641
bbf47d44
PE
1642 * charset.c (load_charset_map): <, not <=, for optimization,
1643 and to avoid potential problems with integer overflow.
9248994d 1644 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1645 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1646 * editfns.c (Fformat): Likewise.
1e69125e 1647 * syntax.c (skip_chars): Likewise.
3befa583 1648
e3019616
PE
1649 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1650 This also lets GCC 4.6.0 generate slightly better loop code.
1651
becfa255
PE
1652 * callint.c (Fcall_interactively): <, not <=, for optimization.
1653 (Fcall_interactively): Count the number of arguments produced,
1654 not the number of arguments given. This is simpler and lets GCC
1655 4.6.0 generate slightly better code.
1656
dae0cd48
PE
1657 * ftfont.c: Distingish more carefully between FcChar8 and char.
1658 The previous code passed unsigned char * to a functions like
1659 strlen and xstrcasecmp that expect char *, which does not
1660 conform to the C standard.
1661 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1662 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1663 char * when the C standard requires it.
1664
76032d70
PE
1665 * keyboard.c (read_char): Remove unused var.
1666
eb3f1cc8
PE
1667 * eval.c: Port to Windows vsnprintf (Bug#8435).
1668 Include <limits.h>.
1669 (SIZE_MAX): Define if the headers do not.
1670 (verror): Do not give up if vsnprintf returns a negative count.
1671 Instead, grow the buffer. This ports to Windows vsnprintf, which
1672 does not conform to C99. Problem reported by Eli Zaretskii.
1673 Also, simplify the allocation scheme, by avoiding the need for
1674 calling realloc, and removing the ALLOCATED variable.
1675
70476b54
PE
1676 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1677
12020a9e
PE
1678 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1679 But keep the doprint source code for now, as we might revamp it
1680 and use it again (Bug#8435).
ea6c7ae6
PE
1681 * lisp.h (doprnt): Remove.
1682 * Makefile.in (base_obj): Remove doprnt.o.
1683 * deps.mk (doprnt.o): Remove.
1684
5fdb398c
PE
1685 error: Print 32- and 64-bit integers portably (Bug#8435).
1686 Without this change, on typical 64-bit hosts error ("...%d...", N)
1687 was used to print both 32- and 64-bit integers N, which relied on
1688 undefined behavior.
1689 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1690 New macro.
1691 * lisp.h (error, verror): Mark as printf-like functions.
1692 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1693 Report overflow in size calculations when allocating printf buffer.
1694 Do not truncate output string at its first null byte.
1695 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1696 Truncate the output at a character boundary, since vsnprintf does not
1697 do that.
1698 * charset.c (check_iso_charset_parameter): Convert internal
1699 character to string before calling 'error', since %c now has the
1700 printf meaning.
1701 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1702 overflow when computing char to be passed to 'error'. Do not
1703 pass Lisp_Object to 'error'; pass the integer instead.
1704 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1705 formatted with plain %d.
1706
b189fa66
PE
1707 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1708
bff87ef0
PE
1709 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1710
7e2cac20
PE
1711 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1712
ce4d90b5
PE
1713 * xterm.c (x_catch_errors): Remove duplicate declaration.
1714
266c9547
PE
1715 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1716
79c49ad2
PE
1717 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1718
368f4090
JM
17192011-04-10 Jim Meyering <meyering@redhat.com>
1720
1721 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1722 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1723 return ssize_t not "int", and use size_t as the buffer length.
1724 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1725 * gnutls.h: Update declarations.
1726 * process.c (read_process_output): Use ssize_t, to match.
1727 (send_process): Likewise.
1728
a32d4040
CY
17292011-04-09 Chong Yidong <cyd@stupidchicken.com>
1730
1731 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1732
8546720e 17332011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1734
04f2d78b
CB
1735 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
1736 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 1737
8546720e
GM
1738 * xterm.c (handle_one_xevent):
1739 * xmenu.c (create_and_show_popup_menu):
1740 * xselect.c (x_decline_selection_request)
1741 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1742
0a2f5c1a 17432011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1744
1745 Fix some uses of `int' instead of EMACS_INT.
1746 * search.c (string_match_1, fast_string_match)
1747 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1748 (scan_buffer, find_next_newline_no_quit)
1749 (find_before_next_newline, search_command, Freplace_match)
1750 (Fmatch_data): Make some `int' variables be EMACS_INT.
1751
1752 * xdisp.c (display_count_lines): 3rd argument and return value now
1753 EMACS_INT. All callers changed.
1754 (pint2hrstr): Last argument is now EMACS_INT.
1755
1756 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1757 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1758 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1759 (decode_coding_utf_16, decode_coding_emacs_mule)
1760 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1761 (decode_coding_ccl, decode_coding_charset)
1762 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1763 (decode_coding_iso_2022, decode_coding_emacs_mule)
1764 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1765 <char_offset, last_offset>: Declare EMACS_INT.
1766 (encode_coding_utf_8, encode_coding_utf_16)
1767 (encode_coding_emacs_mule, encode_invocation_designation)
1768 (encode_designation_at_bol, encode_coding_iso_2022)
1769 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1770 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1771 Declare EMACS_INT.
1772 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1773 (encode_invocation_designation): Last argument P_NCHARS is now
1774 EMACS_INT.
1775 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1776 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1777
1778 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1779 All users changed.
1780
1781 * ccl.c (Fccl_execute_on_string): Declare some variables
1782 EMACS_INT.
1783
8546720e 17842011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
1785
1786 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1787
4e19a977
CS
17882011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1789
1790 * process.c (Fformat_network_address): Doc fix.
1791
87302331
R
17922011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1793
1794 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1795
cbb59342
CY
17962011-04-08 Chong Yidong <cyd@stupidchicken.com>
1797
1798 * keyboard.c (read_char): Call Lisp function help-form-show,
1799 instead of using internal_with_output_to_temp_buffer.
1800 (Qhelp_form_show): New var.
e0d38eeb 1801 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1802
1803 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1804
1805 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1806
e67a13ab
CY
18072011-04-06 Chong Yidong <cyd@stupidchicken.com>
1808
04f2d78b
CB
1809 * process.c (Flist_processes): Remove to Lisp.
1810 (list_processes_1): Delete.
e67a13ab 1811
973f782d
EZ
18122011-04-06 Eli Zaretskii <eliz@gnu.org>
1813
7c106b1e
EZ
1814 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1815
973f782d
EZ
1816 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1817
41cf7d1a 18182011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1819
ca23cc88
PE
1820 Fix more problems found by GCC 4.6.0's static checks.
1821
f390e2d5
PE
1822 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1823
42eea0d0
PE
1824 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1825
b69769da 1826 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1827
f9541e84
PE
1828 * xdisp.c (vmessage): Mark as a printf-like function.
1829
13841b55
PE
1830 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1831
c136c10f
PE
1832 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1833
5e2d4a30
PE
1834 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1835 printf-like functions.
1836 (tiff_load): Add casts to remove these marks before passing them
1837 to system-supplied API.
1838
583f48b9
PE
1839 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1840
b25d760e
PE
1841 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1842 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1843 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1844 directly, rather than having caller test rule sign. This avoids
1845 some unnecessary tests.
1846 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1847 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1848 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1849
bc7b6697 1850 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1851 (xfont_open): Avoid unnecessary tests.
bc7b6697 1852
27ccc379
PE
1853 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1854
dcd5c89a
PE
1855 * composite.h, composite.c (composition_gstring_put_cache):
1856 Use EMACS_INT, not int, for length.
1857
b13a45c6
PE
1858 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1859 breaking out part of COMPOSITION_DECODE_RULE.
1860 (COMPOSITION_DECODE_RULE): Use it.
1861 * composite.c (get_composition_id): Remove unused local vars,
1862 by using the new macro.
1863
1e792e4d
PE
1864 * textprop.c (set_text_properties_1): Change while to do-while,
1865 since the condition is always true at first.
1866
dc6c6455 1867 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1868 (interval_deletion_adjustment): Return unsigned value.
1869 All uses changed.
dc6c6455 1870
aba7731a
PE
1871 * process.c (list_processes_1, create_pty, read_process_output):
1872 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1873 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1874 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1875 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1876 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1877
fdfc4bf3
PE
1878 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1879
fca8fe46 1880 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1881 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1882
06a0259a 1883 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1884 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1885 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1886
e7b9e80f
PE
1887 * print.c (print_error_message): Avoid int overflow.
1888
56201685
PE
1889 * font.c (font_list_entities): Redo for clarity,
1890 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1891
78834453 1892 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1893 (font_score): Avoid potential overflow in diff calculation.
78834453 1894
0bc0b309 1895 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1896 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1897
e610eaca
PE
1898 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1899
b895abce
PE
1900 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1901 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1902 can always succeed if overflow has undefined behavior.
1903
1f1d9321 1904 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1905 (wordify): Omit three unnecessary tests.
1f1d9321 1906
c59478bc
PE
1907 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1908 All callers changed. This avoids the need for an unused var.
1909
79b73827
PE
1910 * casefiddle.c (casify_region): Remove var that is set but not used.
1911
a4db5dfe
PE
1912 * dired.c (file_name_completion): Remove var that is set but not used.
1913
43aae36e
PE
1914 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1915
2a47c44d 1916 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1917 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1918
a37c69bf
PE
1919 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1920 Check for integer overflow on size calculations.
1921
328ab8e7
PE
1922 * buffer.c (Fprevious_overlay_change): Remove var that is set
1923 but not used.
1924
e5a2a5cb
PE
1925 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1926 Remove vars that are set but not used.
8d84a6eb 1927 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 1928 (timer_check_2): Mark vars as initialized.
e5a2a5cb 1929
a60e5f68
PE
1930 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1931
f661cb61 1932 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 1933 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 1934
f0397f5a
PE
1935 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1936 that are set but not used.
1937
8664db06 1938 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 1939 if XCreateBitmapFromData fails (Bug#8410).
8664db06 1940
6abdaa4a
PE
1941 * xselect.c (x_get_local_selection, x_handle_property_notify):
1942 Remove vars that are set but not used.
1943
0ce7538d 1944 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1945 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1946
9ae848fc
PE
1947 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1948 Remove var that is set but not used.
0b918413
PE
1949 (scroll_bar_windows_size): Now size_t, not int.
1950 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1951 Check for overflow.
9ae848fc 1952
a5a62657
PE
1953 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1954 (map_tty_color) [!defined MSDOS]: Likewise.
1955
5c5cdd39
PE
1956 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1957
66ebf983
PE
1958 * coding.c: Remove vars that are set but not used.
1959 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1960 All callers changed.
1961 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1962 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1963 (decode_coding_charset): Remove vars that are set but not used.
1964
1be4d761
PE
1965 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1966 that is set but not used.
1967
47553fa8
PE
1968 * print.c (print_object): Remove var that is set but not used.
1969
1f7196bf 1970 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1971 The gnulib version avoids calling malloc in the usual case,
1972 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1973 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1974 * filelock.c (current_lock_owner): Likewise.
1975 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1976 * sysdep.c: Include allocator.h, careadlinkat.h.
1977 (emacs_no_realloc_allocator): New static constant.
1978 (emacs_readlink): New function.
fdb61804
PE
1979 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1980 ../lib/careadlinkat.h.
d1fdcab7 1981
f84c17c7
SM
19822011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1983
1984 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1985 first non-nil return value).
1986
ef3862ad
JD
19872011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1988
1989 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1990 if not defined (Bug#8403).
1991
376a7006
JB
19922011-04-02 Juanma Barranquero <lekktu@gmail.com>
1993
1994 * xdisp.c (display_count_lines): Remove parameter `start',
1995 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1996 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1997 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1998 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1999 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2000 and thereabouts. All callers changed.
2001 (get_per_char_metric): Remove parameter `f', unused since
2002 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2003
6ca3801d
JM
20042011-04-02 Jim Meyering <meyering@redhat.com>
2005
2006 do not dereference NULL upon failed strdup
2007 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2008 (ns_get_family): Likewise.
2009
d8e2b5ba
JB
20102011-04-02 Juanma Barranquero <lekktu@gmail.com>
2011
2012 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2013
8c74fcbd
JD
20142011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2015
2016 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2017 later (Bug#8403).
2018
7200d79c
SM
20192011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2020
03408648 2021 Add lexical binding.
7200d79c 2022
03408648
SM
2023 * window.c (Ftemp_output_buffer_show): New fun.
2024 (Fsave_window_excursion):
2025 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2026
2027 * lread.c (lisp_file_lexically_bound_p): New function.
2028 (Fload): Bind Qlexical_binding.
2029 (readevalloop): Remove `evalfun' arg.
2030 Bind Qinternal_interpreter_environment.
2031 (Feval_buffer): Bind Qlexical_binding.
2032 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2033 Mark as dynamic.
2034 (syms_of_lread): Declare `lexical-binding'.
2035
2036 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2037
2038 * keyboard.c (eval_dyn): New fun.
2039 (menu_item_eval_property): Use it.
ca105506
SM
2040
2041 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2042
03408648
SM
2043 * fns.c (concat, mapcar1): Accept byte-code-functions.
2044
2045 * eval.c (Fsetq): Handle lexical vars.
2046 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2047 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2048 (FletX, Flet): Obey lexical binding.
2049 (Fcommandp): Handle closures.
2050 (Feval): New `lexical' arg.
2051 (eval_sub): New function extracted from Feval. Use it almost
2052 everywhere where Feval was used. Look up vars in lexical env.
2053 Handle closures.
2054 (Ffunctionp): Move from subr.el.
2055 (Ffuncall): Handle closures.
2056 (apply_lambda): Remove `eval_flags'.
2057 (funcall_lambda): Handle closures and new byte-code-functions.
2058 (Fspecial_variable_p): New function.
2059 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2060 but without exporting it to Lisp.
23aba0ea 2061
23aba0ea 2062 * doc.c (Fdocumentation, store_function_docstring):
03408648 2063 * data.c (Finteractive_form): Handle closures.
23aba0ea 2064
03408648
SM
2065 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2066 interactive spec.
ba83908c 2067
04f2d78b
CB
2068 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2069 New byte-codes.
03408648
SM
2070 (exec_byte_code): New function extracted from Fbyte_code to handle new
2071 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2072
03408648 2073 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2074
03408648 2075 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2076
e2abce01
JB
20772011-03-31 Juanma Barranquero <lekktu@gmail.com>
2078
2079 * xdisp.c (redisplay_internal): Fix prototype.
2080
63696a73 20812011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2082
63696a73 2083 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
2084 (try_scrolling): Use it when setting scroll_limit.
2085 Limit scrolling to 100 screen lines.
63696a73
EZ
2086 (redisplay_window): Even when falling back on "recentering",
2087 position point in the window according to scroll-conservatively,
2088 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2089
2090 (try_scrolling): When point is above the window, allow searching
2091 as far as scroll_max, or one screenful, to compute vertical
2092 distance from PT to the scroll margin position. This prevents
2093 try_scrolling from unnecessarily failing when
2094 scroll-conservatively is set to a value slightly larger than the
2095 window height. Clean up the case of PT below the margin at bottom
2096 of window: scroll_max can no longer be INT_MAX. When aggressive
2097 scrolling is in use, don't let point enter the opposite scroll
2098 margin as result of the scroll.
2099 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2100 threshold of 100 lines for never-recentering scrolling.
2101
e4cc2dfc
JB
21022011-03-31 Juanma Barranquero <lekktu@gmail.com>
2103
2104 * dispextern.h (move_it_by_lines):
2105 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2106 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2107 (message_log_check_duplicate): Remove parameters `prev_bol' and
2108 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2109 (redisplay_internal): Remove parameter `preserve_echo_area',
2110 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2111
2112 * indent.c (Fvertical_motion):
2113 * window.c (window_scroll_pixel_based, Frecenter):
2114 Don't pass `need_y_p' to `move_it_by_lines'.
2115
1c470562
SM
21162011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2117
44f230aa
SM
2118 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2119 steal a few bits to be more compact.
2120 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2121 Remove unneeded casts.
2122
1c470562
SM
2123 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2124
888adce9
ZK
21252011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2126
2127 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2128 binding" message (bug#7967).
2129
f838ed7b
PE
21302011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2131
77861b95
PE
2132 Fix more problems found by GCC 4.6.0's static checks.
2133
de6dbc14
PE
2134 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2135 Remove unused local var.
2136
f838ed7b
PE
2137 * editfns.c (Fmessage_box): Remove unused local var.
2138
792c7b2b
PE
2139 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2140 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2141 Omit unused local vars.
c499e557 2142 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2143 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2144 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2145 Omit unused local var.
2146
ba0165e1
PE
2147 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2148 Don't assume string length fits in int.
32ad8845 2149 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2150 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2151
3c59b4c9
PE
2152 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2153 instead of alloca (Bug#8344).
2154
a3eed478 2155 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2156 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2157
eb4d412d
PE
2158 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2159
1658b401
PE
2160 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2161 concerns.
2162
2163 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2164
2165 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2166
9a2c6e05
PE
2167 * keyboard.c (syms_of_keyboard): Use the same style as later
2168 in this function when indexing through an array. This also
2169 works around GCC bug 48267.
2170
03d0a109
PE
2171 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2172
44f730c8
PE
2173 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2174
fe75f926
PE
2175 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2176 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2177
ffa8c828
PE
2178 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2179 This avoids undefined behavior on integer overflow, and is a bit
2180 more convenient anyway since it is compared to a size_t variable.
2181
c5101a77
PE
2182 Variadic C functions now count arguments with size_t, not int.
2183 This avoids an unnecessary limitation on 64-bit machines, which
2184 caused (substring ...) to crash on large vectors (Bug#8344).
2185 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2186 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2187 All variadic functions and their callers changed accordingly.
c5101a77
PE
2188 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2189 * data.c (arith_driver, float_arith_driver): Likewise.
2190 * editfns.c (general_insert_function): Likewise.
2191 * eval.c (struct backtrace.nargs, interactive_p)
2192 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2193 (funcall_lambda, mark_backtrace): Likewise.
2194 * fns.c (concat): Likewise.
2195 * frame.c (x_set_frame_parameters): Likewise.
2196 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2197 0 if not found, not -1. All callers changed.
2198
dd3f25f7
PE
2199 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2200 (stack_copy_size): Now size_t, not int.
2201 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2202
461c2ab9
JB
22032011-03-28 Juanma Barranquero <lekktu@gmail.com>
2204
2205 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2206 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2207 All callers changed.
2208
2209 * lisp.h (multibyte_char_to_unibyte):
2210 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2211 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2212 * character.h (CHAR_TO_BYTE8):
2213 * cmds.c (internal_self_insert):
2214 * editfns.c (general_insert_function):
2215 * keymap.c (push_key_description):
2216 * search.c (Freplace_match):
2217 * xdisp.c (message_dolog, set_message_1): All callers changed.
2218
f6d62986
SM
22192011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2220
2221 * keyboard.c (safe_run_hook_funcall): New function.
2222 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2223 don't set the hook to nil, but remove the offending function instead.
2224 (Qcommand_hook_internal): Remove, unused.
2225 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2226 Vcommand_hook_internal.
2227
2228 * eval.c (enum run_hooks_condition): Remove.
2229 (funcall_nil, funcall_not): New functions.
2230 (run_hook_with_args): Call each function through a `funcall' argument.
2231 Remove `cond' argument, now redundant.
2232 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2233 (Frun_hook_with_args_until_failure): Adjust accordingly.
2234 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2235
1db5b1ad
JB
22362011-03-28 Juanma Barranquero <lekktu@gmail.com>
2237
2238 * dispextern.h (string_buffer_position): Remove declaration.
2239
2240 * print.c (strout): Remove parameter `multibyte', unused since
2241 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2242
2243 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2244 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2245 All callers changed.
2246
2247 * w32.c (_wsa_errlist): Use braces for struct initializers.
2248
2249 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2250 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2251 All callers changed.
2252 (string_buffer_position): Likewise. Also, make static (it's never
2253 used outside xdisp.c).
2254 (cursor_row_p): Remove parameter `w', unused since
2255 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2256 (decode_mode_spec): Remove parameter `precision', introduced during
2257 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2258 All callers changed.
2259
5ffb62aa
JD
22602011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2261
2262 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2263
461c2ab9 22642011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2265
2266 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2267 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2268 (ns_update_auto_hide_menu_bar): New functions.
2269 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2270 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2271 ns_constrain_all_frames.
2272 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2273 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2274
5c380ffb
JD
22752011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2276
2277 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2278
9af30bdf
GM
22792011-03-27 Glenn Morris <rgm@gnu.org>
2280
2281 * syssignal.h: Replace RETSIGTYPE with void.
2282 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2283 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2284 Replace SIGTYPE with void everywhere.
2285 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2286 * s/template.h (SIGTYPE): Remove commented out definition.
2287
e2abce01
JB
22882011-03-26 Eli Zaretskii <eliz@gnu.org>
2289
2290 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2291 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2292
f868cd8a
JB
22932011-03-26 Juanma Barranquero <lekktu@gmail.com>
2294
59eb0929
JB
2295 * w32.c (read_unc_volume): Use parameter `henum', instead of
2296 global variable `wget_enum_handle'.
2297
2298 * keymap.c (describe_vector): Remove parameters `indices' and
2299 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2300 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2301
f868cd8a
JB
2302 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2303
2304 * keyboard.c (timer_check): Remove parameter `do_it_now',
2305 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2306 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2307 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2308
2309 * keyboard.c (read_char):
2310 * w32menu.c (w32_menu_display_help):
2311 * xmenu.c (show_help_event, menu_help_callback):
2312 Adjust calls to `show_help_echo'.
2313
2314 * gtkutil.c (xg_maybe_add_timer):
2315 * keyboard.c (readable_events):
2316 * process.c (wait_reading_process_output):
2317 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2318
2319 * insdel.c (adjust_markers_gap_motion):
2320 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2321 (gap_left, gap_right): Don't call it.
2322
2ecf6fdb
CY
23232011-03-25 Chong Yidong <cyd@stupidchicken.com>
2324
2325 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2326 incurred during fontification.
2327
6b1f9ba4
JB
23282011-03-25 Juanma Barranquero <lekktu@gmail.com>
2329
2330 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2331 (DEFVAR_PER_BUFFER): Don't pass it.
2332
2333 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2334 (scrolling_window): Don't pass it.
2335
0f4a96b5
JB
23362011-03-25 Juanma Barranquero <lekktu@gmail.com>
2337
2338 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2339
2340 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2341 and `suffix'.
2342 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2343 of variables specific to SELinux and computation of `encoded_absname'.
2344
2345 * image.c (XPutPixel): Remove unused variable `height'.
2346
2347 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2348
2349 * unexw32.c (get_section_info): Remove unused variable `section'.
2350
2351 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2352 (system_process_attributes): Remove unused variable `sess'.
2353 (sys_read): Remove unused variable `err'.
2354
2355 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2356 (w32_wnd_proc): Remove unused variable `isdead'.
2357 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2358 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2359 (x_create_tip_frame): Remove unused variable `tem'.
2360
2361 * w32inevt.c (w32_console_read_socket):
2362 Remove unused variable `no_events'.
2363
2364 * w32term.c (x_draw_composite_glyph_string_foreground):
2365 Remove unused variable `width'.
2366
1149507c
JB
23672011-03-24 Juanma Barranquero <lekktu@gmail.com>
2368
2369 * w32term.c (x_set_glyph_string_clipping):
2370 Don't pass uninitialized region to CombineRgn.
2371
9c88f339
JB
23722011-03-23 Juanma Barranquero <lekktu@gmail.com>
2373
2374 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2375 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2376 (Fx_close_connection): Remove unused variable `i'.
2377
2378 * w32font.c (w32font_draw): Return number of glyphs.
2379 (w32font_open_internal): Remove unused variable `i'.
2380 (w32font_driver): Add missing initializer.
2381
2382 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2383 (fill_in_menu): Remove unused variable `items_added'.
2384
2385 * w32term.c (last_mouse_press_frame): Remove static global variable.
2386 (w32_clip_to_row): Remove unused variable `f'.
2387 (x_delete_terminal): Remove unused variable `i'.
2388
2389 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2390 (NOTHING): Remove unused static global variable.
2391 (uniscribe_check_otf): Remove unused variable `table'.
2392 (uniscribe_font_driver): Add missing initializers.
2393
dee091a3
JD
23942011-03-23 Julien Danjou <julien@danjou.info>
2395
2396 * term.c (Fsuspend_tty, Fresume_tty):
2397 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2398 * window.c (temp_output_buffer_show):
2399 * insdel.c (signal_before_change):
2400 * frame.c (Fhandle_switch_frame):
2401 * fileio.c (Fdo_auto_save):
2402 * emacs.c (Fkill_emacs):
2403 * editfns.c (save_excursion_restore):
2404 * cmds.c (internal_self_insert):
2405 * callint.c (Fcall_interactively):
2406 * buffer.c (Fkill_all_local_variables):
2407 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2408 Use Frun_hooks.
0f4a96b5 2409 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2410 unconditionnaly since it does the check itself.
2411
2c520ab5 24122011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2413
c9c49752
PE
2414 Fix more problems found by GCC 4.5.2's static checks.
2415
8abc3f12
PE
2416 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2417 the first time through the loop, since we know p0 < p1 then.
2418 This also avoids a gcc -Wstrict-overflow warning.
2419
a2d26660
PE
2420 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2421 leading to a memory leak, possible in functions like
2422 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2423 of objects (Bug#8318).
a2d26660 2424
916c72e9
PE
2425 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2426 that could (at least in theory) be that large.
2427
19ab8a18
PE
2428 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2429 This is less likely to overflow, and avoids undefined behavior if
2430 overflow does occur. All callers changed. Use strtoul to scan
2431 for the unsigned long integer.
b7cbbd6f
PE
2432 (pint2hrstr): Simplify and tune code slightly.
2433 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2434
f0641eff
PE
2435 * scroll.c (do_scrolling): Work around GCC bug 48228.
2436 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2437
7f650bb9
PE
2438 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2439 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2440 (validate_x_resource_name): Simplify count usage.
2441 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2442
37dd57d1
PE
2443 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2444 fail (Bug#8306).
81e56e61 2445
699979fc 2446 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2447
401bf9b4
PE
2448 * process.c (Fmake_network_process): Use socklen_t, not int,
2449 where POSIX says socklen_t is required in portable programs.
2450 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2451 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2452 (Fmake_network_process, server_accept_connection):
2453 (wait_reading_process_output, read_process_output):
2454 Likewise.
2455
b93aacde
PE
2456 * process.c: Rename or move locals to avoid shadowing.
2457 (list_processes_1, Fmake_network_process):
2458 (read_process_output_error_handler, exec_sentinel_error_handler):
2459 Rename or move locals.
4dc343ee 2460 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2461 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2462 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2463 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2464 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2465
af8a867c 2466 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2467 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2468 Include tparam.h instead, since it declares them.
af8a867c
PE
2469 * cm.h (PC): Remove extern decl; tparam.h now does this.
2470 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2471 * terminfo.c: Include tparam.h, to check interfaces.
2472 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2473 (tparam): Adjust signature to match interface in tparam.h;
2474 this removes some undefined behavior. Check that outstring and len
2475 are zero, which they always are with Emacs.
2476 * tparam.h (PC, BC, UP): New extern decls.
2477
0248044d 2478 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2479 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2480
8ff096c1 2481 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2482 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2483 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2484 (ftfont_list): Remove unused local.
49eaafba
PE
2485 (get_adstyle_property, ftfont_pattern_entity):
2486 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2487 Rename locals to avoid shadowing.
8ff096c1 2488
e2be39f6
PE
2489 * xfont.c (xfont_list_family): Mark var as initialized.
2490
c9735e30
PE
2491 * xml.c (make_dom): Now static.
2492
8f5201ae
PE
2493 * composite.c (composition_compute_stop_pos): Rename local to
2494 avoid shadowing.
b246f932
PE
2495 (composition_reseat_it): Remove unused locals.
2496 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2497 (composition_update_it): Mark var as initialized.
11b61122
PE
2498 (find_automatic_composition): Mark vars as initialized,
2499 with a FIXME (Bug#8290).
8f5201ae 2500
760fbc2c
PE
2501 character.h: Rename locals to avoid shadowing.
2502 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2503 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2504 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2505 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2506 to avoid shadowing.
2507
ff08eb85
PE
2508 * textprop.c (property_change_between_p): Remove; unused.
2509
fc7bf025
PE
2510 * intervals.c (interval_start_pos): Now static.
2511
235d7abc
PE
2512 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2513
44f230aa
SM
2514 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2515 Rename locals to avoid shadowing.
3e7d6594 2516
50060332
PE
2517 * sound.c (wav_play, au_play, Fplay_sound_internal):
2518 Fix pointer signedness.
d01f234b 2519 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2520 (wav_play): Initialize a variable to 0, to prevent undefined
2521 behavior (Bug#8278).
50060332 2522
c4fc4e30
PE
2523 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2524
918436ed
PE
2525 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2526
c939f91b
PE
2527 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2528 clobbering (Bug#8298).
b9c7f648
PE
2529 * sysdep.c (sys_subshell): Likewise.
2530 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2531
6bd8c144
PE
2532 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2533 This should get cleaned up, so that child_setup has the
2534 same signature on all platforms.
2535
7710357c 2536 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2537 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2538
c59da222
CY
25392011-03-22 Chong Yidong <cyd@stupidchicken.com>
2540
2541 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2542 not to be necessary, and produces flickering.
2543
66b87493
GM
25442011-03-20 Glenn Morris <rgm@gnu.org>
2545
2546 * config.in: Remove file.
2547
45b6f6d5
JB
25482011-03-20 Juanma Barranquero <lekktu@gmail.com>
2549
2550 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2551 are now in src/globals.h.
2552 (syms_of_minibuf): Remove spurious & from previous change.
2553
3ec03f7e
LL
25542011-03-20 Leo <sdl.web@gmail.com>
2555
2556 * minibuf.c (completing-read-function): New variable.
2557 (completing-read-default): Rename from completing-read.
2558 (completing-read): Call completing-read-function.
2559
b14e3e21
CY
25602011-03-19 Juanma Barranquero <lekktu@gmail.com>
2561
2562 * xfaces.c (Fx_load_color_file):
2563 Read color file from absolute filename (bug#8250).
2564
f2b726e6
JB
25652011-03-19 Juanma Barranquero <lekktu@gmail.com>
2566
2567 * makefile.w32-in: Update dependencies.
2568
09f6ff02
EZ
25692011-03-17 Eli Zaretskii <eliz@gnu.org>
2570
2571 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2572
29a6015a
PE
25732011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2574
a3a6c54e
PE
2575 Fix more problems found by GCC 4.5.2's static checks.
2576
b766f867
PE
2577 * process.c (make_serial_process_unwind, send_process_trap):
2578 (sigchld_handler): Now static.
2579
be02381c
PE
2580 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2581 That way, the code declares only the vars that it needs.
2582 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2583 * s/cygwin.h (PTY_ITERATION): Likewise.
2584 * s/darwin.h (PTY_ITERATION): Likewise.
2585 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2586
57048744
PE
2587 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2588 * process.c (allocate_pty): Don't declare stb unless it's needed.
2589
7914961c 2590 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2591 (CONSTANTLIM): Remove; unused.
2592 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2593 Define only if needed.
7914961c 2594
b3967b18
PE
2595 * unexelf.c (unexec): Name an expression,
2596 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2597 Use a different way to cause a compilation error if anyone uses
2598 n rather than nn, a way that does not involve shadowing.
73366a00 2599 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2600
29a6015a
PE
2601 * deps.mk (unexalpha.o): Remove; unused.
2602
43cfc33e 2603 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2604 * unexec.h: New file.
ce701a33
PE
2605 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2606 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2607 Depend on unexec.h.
2608 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2609 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2610 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2611 Change as necessary to match prototype in unexec.h.
ce701a33 2612
01f44d5a
PE
2613 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2614 shadowing.
4f63c6bb 2615 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2616
a6670b0b
PE
2617 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2618 Rename locals to avoid shadowing.
2619
cef2010d 2620 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2621 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2622
d4d7173a
PE
2623 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2624
f08b802a
PE
2625 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2626 warning when compiling print.c.
2627
3ddb0639
PE
2628 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2629 instead of using an uninitialized var.
5ad03b97 2630 (font_sort_entities): Mark var as initialized.
3ddb0639 2631
170a2692
PE
2632 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2633
e663c700
PE
2634 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2635 pointers to constants.
89bc529a 2636 (font_parse_fcname): Remove unused vars.
7b81e2d0 2637 (font_delete_unmatched): Now static.
ea838e10 2638 (font_get_spec): Remove; unused.
13a547c6
PE
2639 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2640 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2641 Rename or move locals to avoid shadowing.
e663c700 2642
2a80c887 2643 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2644 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2645
1384fa33 2646 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2647 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2648
8b2c52e9
PE
2649 * alloc.c (mark_backtrace): Move decl from here ...
2650 * lisp.h: ... to here, so that it can be checked.
2651
475545b5 2652 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2653 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2654 (lisp_indirect_variable): Name an expression,
2655 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2656 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2657
b1349114 2658 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2659 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2660 Use const pointer when appropriate.
b1349114 2661
a2928364
PE
2662 * lisp.h (get_system_name, get_operating_system_release):
2663 Move decls here, to check interfaces.
2664 * process.c (get_operating_system_release): Move decl to lisp.h.
2665 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2666 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2667 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2668 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2669 (Fformat_time_string, Fencode_time, Finsert_char):
2670 (Ftranslate_region_internal, Fformat):
2671 Rename or remove local vars to avoid shadowing.
9710023e 2672 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2673
a415e694
PE
2674 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2675 avoid shadowing.
2676
8ef4622d
PE
2677 * lisp.h (eassert): Check that the argument compiles, even if
2678 ENABLE_CHECKING is not defined.
2679
946f9a5b
PE
2680 * data.c (Findirect_variable): Name an expression, to avoid
2681 gcc -Wbad-function-cast warning.
112396d6 2682 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2683 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2684 (Fmake_variable_buffer_local, Fmake_local_variable):
2685 Mark variables as initialized.
52746918 2686 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2687
e5aab7e7 2688 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2689 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2690 Rename locals to avoid shadowing.
dff45157
PE
2691 (mark_stack): Move local variables into the #ifdef region where
2692 they're used.
7bc26fdb
PE
2693 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2694 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2695 needed otherwise.
2696 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2697 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2698 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2699
e5aab7e7
PE
2700 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2701 avoids undefined behavior in theory.
2702
4da60324
PE
2703 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2704
88043301
PE
2705 Use functions, not macros, for up- and down-casing (Bug#8254).
2706 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2707 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2708 to use the following functions instead of these macros.
2709 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2710 EMACS_INT, since callers assume the returned value fits in int.
2711 (upcase1): Likewise, for UPCASE_TABLE.
2712 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2713 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2714 the race-condition problem in the old DOWNCASE.
88043301 2715
19ed5445
PE
2716 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2717 Rename locals to avoid shadowing.
2718 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2719 (regex_compile, re_search_2, re_match_2_internal):
2720 Remove unused local vars.
952db0d7
PE
2721 (FREE_VAR): Rewrite so as not to use empty "else",
2722 which gcc can warn about.
da053e48 2723 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2724 (RETALLOC_IF): Define only if needed.
2725 (WORDCHAR_P): Likewise. This one is never needed, but is used
2726 only in a comment talking about a compiler bug, so put inside
2727 the #if 0 of that comment.
2728 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2729 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2730 Remove; unused.
19ed5445 2731
1f3561e4 2732 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2733 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2734 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2735
ded6f8f7
PE
2736 * search.c (simple_search): Remove unused var.
2737
dbd37a95
PE
2738 * dired.c (compile_pattern): Move decl from here ...
2739 * lisp.h: ... to here, so that it can be checked.
2740 (struct re_registers): New forward decl.
2741
7e47afad
PE
2742 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2743
85f24f61
PE
2744 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2745 All uses changed.
2746 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2747 Rename locals to avoid shadowing.
5671df8f 2748 (Fvertical_motion): Mark locals as initialized.
85f24f61 2749
181aa2be 2750 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2751 (casify_region): Mark local as initialized.
181aa2be 2752
930d429c
PE
2753 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2754
7082eac6
PE
2755 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2756 New macros, so that the caller can use some names other than
2757 gcpro1, gcpro2, etc.
2758 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2759 of the new macros.
2760 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2761 argument, for consistency with GCPRO2_VAR, etc: it is now the
2762 prefix of the variable, not the variable itself. All uses
2763 changed.
38b2c076
PE
2764 * dired.c (directory_files_internal, file_name_completion):
2765 Rename locals to avoid shadowing.
2766
15206ed9
PE
2767 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2768 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2769 dired.c's scmp function, had undefined behavior.
2770 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2771 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2772 * buffer.h: ... to here, because these macros use current_buffer,
2773 and the new implementation with inline functions needs to have
2774 current_buffer in scope now, rather than later when the macros
2775 are used.
2776 (downcase, upcase1): New static inline functions.
2777 (DOWNCASE, UPCASE1): Reimplement using these functions.
2778 This avoids undefined behavior in expressions like
2779 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2780 from race conditions in accessing the global variables
2781 case_temp1 and case_temp2.
2782 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2783 * lisp.h (case_temp1, case_temp2): Remove their decls.
2784 * character.h (ASCII_CHAR_P): Move from here ...
2785 * lisp.h: ... to here, so that the inline functions mentioned
2786 above can use them.
2787
4a6bea26
PE
2788 * dired.c (directory_files_internal_unwind): Now static.
2789
f14b7e14
PE
2790 * fileio.c (file_name_as_directory, directory_file_name):
2791 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2792 Now static.
2893f146
PE
2793 (file_name_as_directory): Use const pointers when appropriate.
2794 (Fexpand_file_name): Likewise. In particular, newdir might
2795 point at constant storage, so make it a const pointer.
fd4ead52 2796 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2797 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2798 signedness issues.
f839df0c
PE
2799 (Fset_file_times, Finsert_file_contents, auto_save_error):
2800 Rename locals to avoid shadowing.
f14b7e14 2801
5716756e 2802 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2803 (Ftry_completion, Fall_completions): Rename or remove locals
2804 to avoid shadowing.
5716756e 2805
b4c3046a
PE
2806 * marker.c (bytepos_to_charpos): Remove; unused.
2807
b45db522
PE
2808 * lisp.h (verify_bytepos, count_markers): New decls,
2809 so that gcc does not warn that these functions aren't declared.
2810
85876d07
PE
2811 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2812 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2813 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2814 (copy_text): Remove unused local var.
85876d07 2815
03d78a21 2816 * filelock.c (within_one_second): Now static.
b3dd38ab 2817 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2818
5df8f01b
PE
2819 * buffer.c (fix_overlays_before): Mark locals as initialized.
2820 (fix_start_end_in_overlays): Likewise. This function should be
2821 simplified by using pointers-to-pointers, but that's a different
2822 matter.
b1d876f1 2823 (switch_to_buffer_1): Now static.
8f54f30a
PE
2824 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2825 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2826
a70072c9 2827 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2828 Fix pointer signedness issue.
edced198
PE
2829 (sys_subshell): Mark local as volatile if checking for lint,
2830 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2831 (MAXPATHLEN): Define only if needed.
a70072c9 2832
a0977c44
PE
2833 * process.c (serial_open, serial_configure): Move decls from here ...
2834 * systty.h: ... to here, so that they can be checked.
2835
a884fdcc
PE
2836 * fns.c (get_random, seed_random): Move extern decls from here ...
2837 * lisp.h: ... to here, so that they can be checked.
2838
604efe86 2839 * sysdep.c (reset_io): Now static.
b8950c94 2840 (wait_for_termination_signal): Remove; unused.
604efe86 2841
38fc62d9
PE
2842 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2843 (copy_keymap_item, append_key, push_text_char_description):
2844 Now static.
1004a21a 2845 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2846 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2847 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2848 (describe_map_tree):
2849 Rename locals to avoid shadowing.
38fc62d9 2850
2f2650da
PE
2851 * keyboard.c: Declare functions static if they are not used elsewhere.
2852 (echo_char, echo_dash, cmd_error, top_level_2):
2853 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2854 (read_char, kbd_buffer_get_event, make_lispy_position):
2855 (make_lispy_event, make_lispy_movement, apply_modifiers):
2856 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2857 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2858 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2859 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2860 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2861
a053e86c 2862 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2863 (mark_kboards): Move decl here ...
2864 * alloc.c (mark_kboards): ... from here.
a053e86c 2865
4752793e
PE
2866 * lisp.h (force_auto_save_soon): New decl.
2867
74f10ca7 2868 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2869 (DEFINE_DUMMY_FUNCTION): New macro.
2870 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2871 Use it.
c03cd23f
PE
2872 (main): Add casts to avoid warnings
2873 if GCC considers string literals to be constants.
74f10ca7 2874
022e70d4
PE
2875 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2876
59d6fe83
PE
2877 * dbusbind.c: Pointer signedness fixes.
2878 (xd_signature, xd_append_arg, xd_initialize):
2879 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2880 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2881 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2882 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2883
78320123
PE
2884 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2885 if GCC considers string literals to be constants.
49cebcca 2886 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2887
35ac2a97
SM
28882011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2889
fb103ca9
SM
2890 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2891 (print_preprocess, print_object): New macro to fix last change.
2892
35ac2a97
SM
2893 * print.c (print_preprocess): Don't forget font objects.
2894
62973b41
JB
28952011-03-16 Juanma Barranquero <lekktu@gmail.com>
2896
2897 * emacs.c (USAGE3): Doc fixes.
2898
0e48bb22
AS
28992011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2900
2901 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2902 structure.
2903
7684e57b
JB
29042011-03-14 Juanma Barranquero <lekktu@gmail.com>
2905
2906 * lisp.h (VWindow_system, Qfile_name_history):
2907 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2908 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2909 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2910
2911 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2912 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2913
2914 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2915 * w32console.c (detect_input_pending, read_input_pending)
2916 (encode_terminal_code):
2917 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2918 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2919 (w32_system_caret_y, Qfile_name_history):
2920 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2921 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2922 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2923 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2924 * w32proc.c (Qlocal, report_file_error):
2925 * w32term.c (Vwindow_system, updating_frame):
2926 * w32uniscribe.c (initialized, uniscribe_font_driver):
2927 Remove unneeded extern declarations.
2928
2aa46d6c
CY
29292011-03-14 Chong Yidong <cyd@stupidchicken.com>
2930
c96bbc66 2931 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 2932
cffc6f3b
CY
29332011-03-13 Chong Yidong <cyd@stupidchicken.com>
2934
2935 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2936 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2937 These macros can no longer be used for assignment.
2938
44f230aa
SM
2939 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2940 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
2941 (record_buffer_markers, fetch_buffer_markers): New functions for
2942 recording and fetching special buffer markers.
2943 (set_buffer_internal_1, set_buffer_temp): Use them.
2944
2945 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2946
2947 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2948
2949 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2950 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2951
2952 * xdisp.c (hscroll_window_tree):
2953 (reconsider_clip_changes): Use PT instead of BUF_PT.
2954
d251f04b
EZ
29552011-03-13 Eli Zaretskii <eliz@gnu.org>
2956
2957 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2958 $(EMACS_ROOT)/lib/intprops.h.
2959
f0c77cd1
PE
29602011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2961
3eca4629
PE
2962 Fix more problems found by GCC 4.5.2's static checks.
2963
7c86ee98
PE
2964 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2965 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2966 (xg_free_frame_widgets): Make it clear that a local variable is
2967 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2968 (gdk_window_get_screen): Make it clear that this macro is needed
2969 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2970 (int_gtk_range_get_value): New function, which avoids a diagnostic
2971 from gcc -Wbad-function-cast.
2972 (xg_set_toolkit_scroll_bar_thumb): Use it.
2973 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2974 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
2975 (get_utf8_string, xg_get_file_with_chooser):
2976 Rename locals to avoid shadowing.
2977 (create_dialog): Move locals to avoid shadowing.
7c86ee98 2978
41729b81
PE
2979 * xgselect.c (xg_select): Remove unused var.
2980
f0c77cd1
PE
2981 * image.c (four_corners_best): Mark locals as initialized.
2982 (gif_load): Initialize transparent_p to zero (Bug#8238).
2983 Mark another local as initialized.
ec6cf4c6 2984 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 2985
ce0ad53d 2986 * image.c (clear_image_cache): Now static.
d5d5a617 2987 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 2988 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
2989 (x_edge_detection): Remove unnecessary cast that
2990 gcc -Wbad-function-cast diagnoses.
2037898d 2991 (gif_load): Fix pointer signedness.
6ae141d6
PE
2992 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2993 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 2994
33383987 29952011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 2996
d32df629
PE
2997 Improve quality of tests for time stamp overflow.
2998 For example, without this patch (encode-time 0 0 0 1 1
2999 1152921504606846976) returns the obviously-bogus value (-948597
3000 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3001 reports time overflow. See
3002 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3003 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3004 * editfns.c: Include limits.h and intprops.h.
3005 (TIME_T_MIN, TIME_T_MAX): New macros.
3006 (time_overflow): Move earlier, to before first use.
3007 (hi_time, lo_time): New functions, for an accurate test for
3008 out-of-range times.
3009 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3010 (Fget_internal_run_time): Don't assume time_t fits in int.
3011 (make_time): Use list2 instead of Fcons twice.
3012 (Fdecode_time): More accurate test for out-of-range times.
3013 (check_tm_member): New function.
3014 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3015 (lisp_time_argument): Don't rely on undefined left-shift and
3016 right-shift behavior when checking for time stamp overflow.
8be6f318 3017
fe31d94c
PE
3018 * editfns.c (time_overflow): New function, refactoring common code.
3019 (Fformat_time_string, Fdecode_time, Fencode_time):
3020 (Fcurrent_time_string): Use it.
3021
8be6f318
PE
3022 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3023 * dired.c (make_time): Move to ...
3024 * editfns.c (make_time): ... here.
3025 * systime.h: Note the move.
3026
09d9db2c 30272011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3028
126bc0dc
YM
3029 * fringe.c (update_window_fringes): Remove unused variables.
3030
c47cbdfd
YM
3031 * unexmacosx.c (copy_data_segment): Also copy __got section.
3032 (Bug#8223)
3033
7ac80be9
EZ
30342011-03-12 Eli Zaretskii <eliz@gnu.org>
3035
c96bbc66 3036 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3037 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3038 Constify `char *' arguments and their references according to
3039 prototypes in tparam.h.
3040
ecb0f94d 3041 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3042
7ac80be9
EZ
3043 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3044 Adapt all references accordingly.
3045
3046 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3047
ef1fd07e
TT
30482011-03-11 Tom Tromey <tromey@redhat.com>
3049
3050 * buffer.c (syms_of_buffer): Remove obsolete comment.
3051
7ef4b50c
EZ
30522011-03-11 Eli Zaretskii <eliz@gnu.org>
3053
3054 * termhooks.h (encode_terminal_code): Declare prototype.
3055
3056 * msdos.c (encode_terminal_code): Don't declare prototype.
3057
3058 * term.c (encode_terminal_code): Now external again, used by
3059 w32console.c and msdos.c.
3060
44f230aa
SM
3061 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3062 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3063
4b1ec863 30642011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3065
1714f52b 3066 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3067
4b1ec863
PE
3068 * fringe.c (update_window_fringes): Mark locals as initialized
3069 (Bug#8227).
3070 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3071
524c7aa6
PE
3072 * alloc.c (mark_fringe_data): Move decl from here ...
3073 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3074 to check its interface.
3075 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3076
a5c0af81 3077 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3078 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3079 (fontset_font): Mark local as initialized.
a9a06e0b 3080 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3081
b4716021
PE
3082 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3083
811e9bac 3084 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3085 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3086 (x_own_selection, Fx_disown_selection_internal): Rename locals
3087 to avoid shadowing.
3088 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3089
7e3ab302
PE
3090 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3091 so that the caller can use some name other than gcpro1.
3092 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3093 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3094 (Fx_backspace_delete_keys_p):
3095 Use them to avoid shadowing, and rename vars to avoid shadowing.
3096 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3097 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3098 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3099 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3100 Remove unused locals.
7e3ab302
PE
3101 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3102 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3103 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3104 macros.
f78faa98 3105
e2b13473
PE
3106 * xterm.h (x_mouse_leave): New decl.
3107
77f23912
PE
3108 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3109 Remove unused functions.
cdf4ba58
PE
3110 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3111 (x_calc_absolute_position): Now static.
7411c686 3112 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3113 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3114 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3115 unless they are used.
38d0b34a
PE
3116 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3117 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3118 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3119 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3120 (x_error_catcher, x_connection_closed, x_error_handler):
3121 (x_error_quitter, xembed_send_message, x_iconify_frame):
3122 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3123 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3124 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3125
44f230aa
SM
3126 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3127 Rename or move locals to avoid shadowing.
6b463e58 3128 (tty_defined_color, merge_face_heights): Now static.
5967d051 3129 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3130 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3131 does not deduce is never used uninitialized.
73719eba
PE
3132 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3133 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3134
426994c3 3135 * terminal.c (store_terminal_param): Now static.
5489860b 3136
032f1620 3137 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3138 (set_frame_menubar): Remove unused local.
d4323972 3139 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3140 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3141 since they might point to immutable storage.
281585b0
PE
3142 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3143 since it's unused otherwise.
032f1620 3144
367c19e5 3145 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3146 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3147 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3148 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3149 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3150 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3151 does not deduce are never used uninitialized.
70739cbe 3152
07b48fa9
PE
3153 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3154
8868a238 3155 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3156 * window.c (window_loop, size_window):
3157 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3158
7e5cf297 3159 * window.c (display_buffer): Now static.
d6550a9f
PE
3160 (size_window): Mark variables that gcc -Wuninitialized
3161 does not deduce are never used uninitialized.
a586633d
PE
3162 * window.h (check_all_windows): New decl, to forestall
3163 gcc -Wmissing-prototypes diagnostic.
5b555da1 3164 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3165
f6095868
PE
3166 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3167 shadowing.
3168 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3169 Include <limits.h>.
3170 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3171 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3172 (load_charset_map): Mark variables that gcc -Wuninitialized
3173 does not deduce are never used uninitialized.
53df7c11 3174 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3175
f38b440c
PE
3176 * coding.c (coding_set_source, coding_set_destination):
3177 Use "else { /* comment */ }" rather than "else /* comment */;"
3178 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3179 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3180 a block, when the outer 'i' will do.
3181 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3182 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3183 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3184 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3185 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3186 Rename locals to avoid shadowing.
3187 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3188 * coding.c (emacs_mule_char, encode_invocation_designation):
3189 Now static, since they're not used elsewhere.
413bb2db 3190 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3191 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3192 (decode_coding_emacs_mule): Mark variables that gcc
3193 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3194 (detect_coding_iso_2022): Initialize a local variable that might
3195 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3196 this initialization is needed. (Bug#8211)
5f58e762
PE
3197 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3198 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3199 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3200 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3201 Remove unused macros.
f38b440c 3202
232b38b9 3203 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3204 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3205 * character.c (string_count_byte8): Likewise.
232b38b9 3206
fb90da1b
PE
3207 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3208 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3209
fb93dbc2
PE
3210 * chartab.c (copy_sub_char_table): Now static, since it's not used
3211 elsewhere.
5c156ace
PE
3212 (sub_char_table_ref_and_range, char_table_ref_and_range):
3213 Rename locals to avoid shadowing.
bbcd0949 3214 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3215
7d3b3862 3216 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3217 (BIDI_BOB): Remove unused macro.
7d3b3862 3218
6be7d3da
PE
3219 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3220 deduce are never used uninitialized.
c2ed9c8b 3221 * term.c (encode_terminal_code): Likewise.
6be7d3da 3222
75f8807f 3223 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3224
50938595
PE
3225 * tparam.h: New file.
3226 * term.c, tparam.h: Include it.
3227 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3228 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3229 Move these decls to tparam.h, and make them agree with what
3230 is actually in tparam.c. The previous trick of using incompatible
3231 decls in different modules does not conform to the C standard.
3232 All callers of tparam changed to use tparam's actual API.
3233 * tparam.c (tparam1, tparam, tgoto):
3234 Use const pointers where appropriate.
3235
fbceeba2
PE
3236 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3237 * cm.h (struct cm): Likewise.
3238 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3239 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3240 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3241 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3242 (turn_on_face, init_tty): Likewise.
3243 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3244
7f3f1250
PE
3245 * term.c (term_mouse_position): Rename local to avoid shadowing.
3246
e6ca6543
PE
3247 * alloc.c (mark_ttys): Move decl from here ...
3248 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3249
c40f8d15
AS
32502011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3251
3252 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3253
cfe0661d
JB
32542011-03-09 Juanma Barranquero <lekktu@gmail.com>
3255
3256 * search.c (compile_pattern_1): Remove argument regp, unused since
3257 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3258 (compile_pattern): Don't pass it.
3259
0afb4571
J
32602011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3261
3262 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3263 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3264 for ! HAVE_GTK3.
3265 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3266
3267 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3268
3269 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3270 gdk_window_get_screen, gdk_window_get_geometry,
3271 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3272 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3273 (xg_get_pixbuf_from_pixmap): New function.
3274 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3275 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3276 Call xg_get_pixbuf_from_pixmap instead of
3277 gdk_pixbuf_get_from_drawable.
3278 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3279 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3280 (xg_check_special_colors): Use GtkStyleContext and its functions
3281 for HAVE_GTK3.
3282 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3283 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3284 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3285 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3286 Call gtk_widget_get_preferred_size.
0afb4571
J
3287 (xg_frame_resized): gdk_window_get_geometry only takes 5
3288 parameters.
44f230aa
SM
3289 (xg_win_to_widget, xg_event_is_for_menubar):
3290 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3291 (xg_set_widget_bg): New function.
3292 (delete_cb): New function.
895009e1 3293 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3294 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3295 (xg_set_background_color): Call xg_set_widget_bg.
3296 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3297 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3298 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3299 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3300 if ! HAVE_GTK3.
3301 (update_frame_tool_bar): Call gtk_widget_hide.
3302 (xg_initialize): Use GDK_KEY_g.
3303
3304 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3305 if ! HAVE_GTK3
3306 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3307
3308 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3309 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3310 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3311
1c2cc4ef
JB
33122011-03-08 Juanma Barranquero <lekktu@gmail.com>
3313
3314 * w32xfns.c (select_palette): Check success of RealizePalette against
3315 GDI_ERROR, not zero.
3316
33383987 3317See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3318
3319;; Local Variables:
3320;; coding: utf-8
aac0c6e3
MR
3321;; End:
3322
33383987 3323 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3324
3325 This file is part of GNU Emacs.
3326
3327 GNU Emacs is free software: you can redistribute it and/or modify
3328 it under the terms of the GNU General Public License as published by
3329 the Free Software Foundation, either version 3 of the License, or
3330 (at your option) any later version.
3331
3332 GNU Emacs is distributed in the hope that it will be useful,
3333 but WITHOUT ANY WARRANTY; without even the implied warranty of
3334 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3335 GNU General Public License for more details.
3336
3337 You should have received a copy of the GNU General Public License
3338 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.