Merge from gnulib.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
32bd4250
PE
12012-08-19 Paul Eggert <eggert@cs.ucla.edu>
2
b69a6d22
PE
3 Rely on <unistd.h> to declare 'environ',
4 as gnulib does this if the system doesn't.
5 * callproc.c, editfns.c, process.c (environ) [!USE_CRT_DLL]:
6 * emacs.c (environ) [DOUG_LEA_MALLOC]:
7 * vm-limit.c (environ) [ORDINARY_LINK]: Remove decl.
8 * vm-limit.c: Include <unistd.h>, for 'environ'.
9
22d7feb2
PE
10 * unexaix.c, unexcoff.c: Include "mem-limits.h".
11 (start_of_data): Remove decl; mem-limits.h provides it.
12
32bd4250
PE
13 * xdisp.c (handle_invisible_prop): Make it a bit faster
14 and avoid a gcc -Wmaybe-uninitialized diagnostic.
15
450809af
CY
162012-08-19 Chong Yidong <cyd@gnu.org>
17
18 * xdisp.c (handle_invisible_prop): Fix ellipses at overlay string
19 ends (Bug#3874).
20
9e677988
AS
212012-08-19 Andreas Schwab <schwab@linux-m68k.org>
22
6b1319ce
AS
23 * .gdbinit: Use call instead of set when calling a function in the
24 inferior.
25
9e677988
AS
26 * data.c (set_internal): Don't use set_blv_found.
27 (Fkill_local_variable): Likewise.
28
d7191076
AA
292012-08-18 Alp Aker <alp.tekin.aker@gmail.com>
30
31 * nsfont.m (ns_ascii_average_width): Ensure the string
32 ascii_printable is initialized with a null-terminated character
33 array. Otherwise, it can contain undesired extra characters.
34
e757f1c6
PE
352012-08-18 Paul Eggert <eggert@cs.ucla.edu>
36
37 port new setting code to Sun C 5.8 2005/10/13
38 * chartab.c, lisp.h (char_table_set, char_table_set_range):
39 Return void, not Lisp_Object. Otherwise, the compiler
40 complains about (A?B:C) where B is void and C is Lisp_Object
41 when compiling CHAR_TABLE_SET, due to the recent change to
42 the API of sub_char_table_set_contents.
43
a999ce26
CY
442012-08-18 Chong Yidong <cyd@gnu.org>
45
46 * xdisp.c (handle_invisible_prop): Obey TEXT_PROP_MEANS_INVISIBLE
47 for the string case (Bug#3874).
48
3f22b86f
PE
492012-08-18 Paul Eggert <eggert@cs.ucla.edu>
50
39eb03f1
PE
51 * buffer.h (BSET): Remove (Bug#12215).
52 Replace all uses with calls to new setter functions.
53 (bset_bidi_paragraph_direction, bset_case_canon_table)
54 (bset_case_eqv_table, bset_directory, bset_display_count)
55 (bset_display_time, bset_downcase_table)
56 (bset_enable_multibyte_characters, bset_filename, bset_keymap)
57 (bset_last_selected_window, bset_local_var_alist)
58 (bset_mark_active, bset_point_before_scroll, bset_read_only)
59 (bset_truncate_lines, bset_undo_list, bset_upcase_table)
60 (bset_width_table):
61 * buffer.c (bset_abbrev_mode, bset_abbrev_table)
62 (bset_auto_fill_function, bset_auto_save_file_format)
63 (bset_auto_save_file_name, bset_backed_up, bset_begv_marker)
64 (bset_bidi_display_reordering, bset_buffer_file_coding_system)
65 (bset_cache_long_line_scans, bset_case_fold_search)
66 (bset_ctl_arrow, bset_cursor_in_non_selected_windows)
67 (bset_cursor_type, bset_display_table, bset_extra_line_spacing)
68 (bset_file_format, bset_file_truename, bset_fringe_cursor_alist)
69 (bset_fringe_indicator_alist, bset_fringes_outside_margins)
70 (bset_header_line_format, bset_indicate_buffer_boundaries)
71 (bset_indicate_empty_lines, bset_invisibility_spec)
72 (bset_left_fringe_width, bset_major_mode, bset_mark)
73 (bset_minor_modes, bset_mode_line_format, bset_mode_name)
74 (bset_name, bset_overwrite_mode, bset_pt_marker)
75 (bset_right_fringe_width, bset_save_length)
76 (bset_scroll_bar_width, bset_scroll_down_aggressively)
77 (bset_scroll_up_aggressively, bset_selective_display)
78 (bset_selective_display_ellipses, bset_vertical_scroll_bar_type)
79 (bset_word_wrap, bset_zv_marker):
80 * category.c (bset_category_table):
81 * syntax.c (bset_syntax_table):
82 New setter functions.
83
6a09a33b
PE
84 * process.h (PSET): Remove (Bug#12215).
85 Replace all uses with calls to new setter functions.
86 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
87 (PROCESS_INLINE): New macro.
88 (pset_childp): New setter function.
89 (pset_gnutls_cred_type) [HAVE_GNUTLS]: New setter function.
90 * process.c (PROCESS_INLINE):
91 Define to EXTERN_INLINE, so that the corresponding functions
92 are compiled into code.
93 (pset_buffer, pset_command, pset_decode_coding_system)
94 (pset_decoding_buf, pset_encode_coding_system)
95 (pset_encoding_buf, pset_filter, pset_log, pset_mark, pset_name)
96 (pset_plist, pset_sentinel, pset_status, pset_tty_name)
97 (pset_type, pset_write_queue): New setter functions.
98
e8c17b81
PE
99 * window.h (WSET): Remove (Bug#12215).
100 Replace all uses with calls to new setter functions.
101 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
102 (WINDOW_INLINE): New macro.
103 (wset_buffer, wset_frame, wset_left_col, wset_next, wset_prev)
104 (wset_redisplay_end_trigger, wset_top_line, wset_total_cols)
105 (wset_total_lines, wset_vertical_scroll_bar)
106 (wset_window_end_pos, wset_window_end_valid)
107 (wset_window_end_vpos): New setter functions.
108 * window.c (WINDOW_INLINE):
109 Define to EXTERN_INLINE, so that the corresponding functions
110 are compiled into code.
111 (wset_combination_limit, wset_dedicated, wset_display_table)
112 (wset_hchild, wset_left_fringe_width, wset_left_margin_cols)
113 (wset_new_normal, wset_new_total, wset_next_buffers)
114 (wset_normal_cols, wset_normal_lines, wset_parent, wset_pointm)
115 (wset_prev_buffers, wset_right_fringe_width)
116 (wset_right_margin_cols, wset_scroll_bar_width, wset_start)
117 (wset_temslot, wset_vchild, wset_vertical_scroll_bar_type)
118 (wset_window_parameters):
119 * xdisp.c (wset_base_line_number, wset_base_line_pos)
120 (wset_column_number_displayed, wset_region_showing):
121 New setter functions.
122
3f22b86f
PE
123 * termhooks.h (TSET): Remove (Bug#12215).
124 Replace all uses with calls to new setter functions.
125 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
126 (TERMHOOKS_INLINE): New macro.
127 (tset_charset_list, tset_selection_alist): New setter functions.
128 * terminal.c (TERMHOOKS_INLINE):
129 Define to EXTERN_INLINE, so that the corresponding functions
130 are compiled into code.
131 (tset_param_alist): New setter function.
132
742af32f
PE
1332012-08-17 Paul Eggert <eggert@cs.ucla.edu>
134
15dbb4d6
PE
135 * keyboard.h (KSET): Remove (Bug#12215).
136 Replace all uses with calls to new setter functions.
137 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
138 (KEYBOARD_INLINE): New macro.
139 (kset_default_minibuffer_frame, kset_defining_kbd_macro)
140 (kset_input_decode_map, kset_last_command, kset_last_kbd_macro)
141 (kset_prefix_arg, kset_system_key_alist, kset_window_system):
142 New setter functions.
143 * keyboard.c (KEYBOARD_INLINE):
144 Define to EXTERN_INLINE, so that the corresponding functions
145 are compiled into code.
146 (kset_echo_string, kset_kbd_queue)
147 (kset_keyboard_translate_table, kset_last_prefix_arg)
148 (kset_last_repeatable_command, kset_local_function_key_map)
149 (kset_overriding_terminal_local_map, kset_real_last_command)
150 (kset_system_key_syms): New setter functions.
151
f00af5b1
PE
152 * frame.h (FSET): Remove (Bug#12215).
153 Replace all uses with calls to new setter functions.
154 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
155 (FRAME_INLINE): New macro.
156 (fset_buffer_list, fset_buried_buffer_list, fset_condemned_scroll_bars)
157 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
158 (fset_face_alist, fset_focus_frame, fset_icon_name, fset_menu_bar_items)
159 (fset_menu_bar_vector, fset_menu_bar_window, fset_name)
160 (fset_param_alist, fset_root_window, fset_scroll_bars)
161 (fset_selected_window, fset_title, fset_tool_bar_items)
162 (fset_tool_bar_position, fset_tool_bar_window): New functions.
163 * frame.c (FRAME_INLINE):
164 Define to EXTERN_INLINE, so that the corresponding functions
165 are compiled into code.
166 (fset_buffer_predicate, fset_minibuffer_window): New setter functions.
167
0c94c8d6
PE
168 A few more naming-convention fixes for getters and setters.
169 * buffer.c (set_buffer_overlays_before): Move here from buffer.h,
170 and rename from buffer_overlays_set_before.
171 (set_buffer_overlays_after): Move here from buffer.h, and rename
172 from buffer_overlays_set_after.
173 * buffer.h (buffer_intervals): Rename from buffer_get_intervals.
174 All uses changed.
175 (set_buffer_intervals): Rename from buffer_set_intervals.
176 * intervals.c (set_interval_object): Move here from intervals.h,
177 and rename from interval_set_object.
178 (set_interval_left): Move here from intervals.h, and rename from
179 interval_set_left.
180 (set_interval_right): Move here from intervals.h, and rename from
181 interval_set_right.
182 (copy_interval_parent): Move here from intervals.h, and rename from
183 interval_copy_parent.
184 * intervals.h (set_interval_parent): Rename from interval_set_parent.
185 (set_interval_plist): Rename from interval_set_plist.
186 Return void, not Lisp_Object, since no caller uses the result.
187 * lisp.h (string_intervals): Rename from string_get_intervals.
188 (set_string_intervals): Rename from string_set_intervals.
189
34dabdb7
PE
190 * lisp.h (set_char_table_extras): Rename from char_table_set_extras.
191 (set_char_table_contents): Rename from char_table_set_contents.
0b390a9d 192 (set_sub_char_table_contents): Rename from sub_char_table_set_contents.
34dabdb7
PE
193 All uses changed. See the end of
194 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00549.html>.
195
742af32f
PE
196 * lisp.h (CSET): Remove (Bug#12215).
197 (set_char_table_ascii, set_char_table_defalt, set_char_table_parent)
198 (set_char_table_purpose): New functions,
199 replacing CSET. All uses changed. For example, replace
200 "CSET (XCHAR_TABLE (char_table), parent, parent);" with
c24eb18a 201 "set_char_table_parent (char_table, parent);".
742af32f
PE
202 The old version was confusing because it used the same name
203 'parent' for two different things.
204
a04e2c62
DA
2052012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
206
207 Functions to get and set Lisp_Object fields of buffer-local variables.
208 * lisp.h (blv_found, set_blv_found, blv_value, set_blv_value)
209 (set_blv_where, set_blv_defcell, set_blv_valcell): New functions.
210 (BLV_FOUND, SET_BLV_FOUND, BLV_VALUE, SET_BLV_VALUE): Remove.
211 * data.c, eval.c, frame.c: Adjust users.
212
383dcbf9
CY
2132012-08-17 Chong Yidong <cyd@gnu.org>
214
215 * xfaces.c (merge_face_vectors): If the target font specfies a
216 font spec, make the font's attributes take precedence over
217 directly-specified attributes.
218 (merge_face_ref): Recognize :font.
219
44386687
DA
2202012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
221
222 Do not use memcpy for copying intervals.
223 * intervals.c (reproduce_interval): New function.
224 (reproduce_tree, reproduce_tree_obj): Use it.
225 (reproduce_tree_obj): Remove prototype.
226
927c7216
PE
2272012-08-17 Paul Eggert <eggert@cs.ucla.edu>
228
229 * lisp.h (duration_to_sec_usec): Remove unused decl.
230
93044f7b
AA
2312012-08-17 Alp Aker <alp.tekin.aker@gmail.com>
232
233 * nsfont.m (ns_ascii_average_width): Send initWithFormat selector
234 to an allocated instance of NSString, not to the class itself.
235
9851e4a5
JB
2362012-08-17 Juanma Barranquero <lekktu@gmail.com>
237
238 * makefile.w32-in (C_CTYPE_H): New macro.
239 (LISP_H, $(BLD)/ccl.$(O), $(BLD)/doc.$(O), $(BLD)/w32console.$(O)):
240 ($(BLD)/fontset.$(O), $(BLD)/frame.$(O), $(BLD)/composite.$(O)):
241 ($(BLD)/sysdep.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
242
620f13b0
PE
2432012-08-16 Paul Eggert <eggert@cs.ucla.edu>
244
245 Use ASCII tests for character types.
246 * category.c, dispnew.c, doprnt.c, editfns.c, syntax.c, term.c:
247 * xfns.c, xterm.c:
248 Don't include <ctype.h>; was not needed.
249 * charset.c, doc.c, fileio.c, font.c, frame.c, gtkutil.c, image.c:
250 * sysdep.c, xfaces.c:
251 Include <c-ctype.h> instead of <ctype.h>.
252 * nsterm.m: Include <c-ctype.h>.
253 * charset.c (read_hex):
254 * doc.c (Fsnarf_documentation):
255 * fileio.c (IS_DRIVE) [WINDOWSNT]:
256 (DRIVE_LETTER) [DOS_NT]:
257 (Ffile_name_directory, Fexpand_file_name)
258 (Fsubstitute_in_file_name):
259 * font.c (font_parse_xlfd, font_parse_fcname):
260 * frame.c (x_set_font_backend):
261 * gtkutil.c (xg_get_font):
262 * image.c (xbm_scan, xpm_scan, pbm_scan_number):
263 * nsimage.m (hexchar):
264 * nsterm.m (ns_xlfd_to_fontname):
265 * sysdep.c (system_process_attributes):
266 * xfaces.c (hash_string_case_insensitive):
267 Use C-locale tests instead of locale-specific tests for character
268 types, since we want the ASCII interpretation here, not the
269 interpretation suitable for whatever happens to be the current locale.
270
52162052
MR
2712012-08-16 Martin Rudalics <rudalics@gmx.at>
272
273 Consistently check windows for validity/liveness
274 (Bug#11984, Bug#12025, Bug#12026).
275 * lisp.h (CHECK_VALID_WINDOW): New macro.
276 * window.c (decode_window): Rename to decode_live_window.
277 (decode_valid_window, Fwindow_valid_p): New functions.
278 (Fwindow_frame, Fframe_root_window, Fwindow_minibuffer_p)
279 (Fframe_first_window, Fframe_selected_window, Fwindow_parent)
280 (Fwindow_top_child, Fwindow_left_child, Fwindow_next_sibling)
281 (Fwindow_prev_sibling, Fwindow_combination_limit)
282 (Fset_window_combination_limit, Fwindow_use_time)
283 (Fwindow_total_height, Fwindow_total_width, Fwindow_new_total)
284 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_left_column)
285 (Fwindow_top_line, Fwindow_body_height, Fwindow_body_width)
286 (Fwindow_hscroll, Fset_window_hscroll)
287 (Fwindow_redisplay_end_trigger)
288 (Fset_window_redisplay_end_trigger, Fwindow_edges)
289 (Fwindow_pixel_edges, Fwindow_absolute_pixel_edges)
290 (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
291 (Fcoordinates_in_window_p, Fwindow_point, Fwindow_start)
292 (Fwindow_end, Fset_window_point, Fset_window_start)
293 (Fpos_visible_in_window_p, Fwindow_line_height)
294 (Fwindow_dedicated_p, Fset_window_dedicated_p)
295 (Fwindow_prev_buffers, Fset_window_prev_buffers)
296 (Fwindow_next_buffers, Fwindow_parameters, Fwindow_parameter)
297 (Fset_window_parameter, Fwindow_display_table)
298 (Fset_window_display_table, Fdelete_other_windows_internal)
299 (Fset_window_buffer, Fset_window_new_total)
300 (Fset_window_new_normal, Fdelete_window_internal)
301 (Fwindow_text_height, Fset_window_margins, Fwindow_margins)
302 (Fset_window_fringes, Fwindow_fringes, Fset_window_scroll_bars)
303 (Fwindow_scroll_bars): Check whether argument window is a valid or
304 live window. Update doc-strings.
305 (syms_of_window): New symbol Qwindow_valid_p.
306 * keyboard.c (Fposn_at_x_y): Check whether argument
307 frame_or_window denotes a valid window.
308
2751c80f
DA
3092012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
310
311 Fix previous char table change.
312 * lisp.h (CHAR_TABLE_SET): Use sub_char_table_set_contents.
313 * chartab.c (optimize_sub_char_table): Likewise.
314
032a42c8
CY
3152012-08-16 Chong Yidong <cyd@gnu.org>
316
a2d19368
CY
317 * gtkutil.c (xg_get_font): Demand an Xft font (Bug#3228).
318
032a42c8
CY
319 * xfont.c (xfont_open):
320 * xftfont.c (xftfont_open): Set the font's max_width field.
321
322 * nsfont.m (nsfont_open): Similar to the Xft backend, set
323 min_width to space_width and average_width to the average over
324 printable ASCII characters.
325 (ns_char_width): Code cleanup.
326 (ns_ascii_average_width): New utility function.
327
328 * font.h (struct font): Update comments.
329
a098c930
DA
3302012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
331
032a42c8 332 Simple interface to set Lisp_Object fields of character tables.
a098c930
DA
333 * lisp.h (CSET): New macro.
334 (char_table_set_extras, char_table_set_contents)
335 (sub_char_table_set_contents): New function.
336 * casetab.c, category.c, chartab.c, fns.c, fontset.c, search.c:
337 * syntax.c: Adjust users.
338
8be3a09c
SM
3392012-08-16 Stefan Monnier <monnier@iro.umontreal.ca>
340
341 * eval.c (eval_sub): Bind lexical-binding.
342 * lread.c (Qlexical_binding): Make non-static.
343
ac4845a6
JD
3442012-08-15 Jan Djärv <jan.h.d@swipnet.se>
345
ddee6515
JD
346 * nsmenu.m (popupSession): Remove.
347 (pop_down_menu): Remove endModalSession.
348 (timeout_handler:): New method.
349 (runDialogAt:): Get next timeout. Start a NSTimer with that timeout.
350 Call runModalForWindow. Check timer_fired when it returns.
351 If not set, cancel timer and break out of loop.
352 Otherwise loop again, with a new timeout.
353
354 * nsterm.m: Include fcntl.h if present.
355 (fd_entry, t_readfds, inNsSelect): Remove.
356 (select_writefds, select_valid, select_timeout, selfds)
357 (select_mutex, apploopnr): Add.
358 (EV_TRAILER): Call kbd_buffer_store_event_hold only if q_event_ptr.
359 Otherwise call kbd_buffer_store_event.
360 (ns_send_appdefined): Remove release of fd_entry.
361 (ns_read_socket): Always send appdefined. Remove inNsSelect check.
362 Increment and decrement apploopnr.
363 (ns_select): If no file descriptors, just do a NSTimer.
364 Otherwise copy read/write masks and start select thread (fd_handler).
365 Start main loop and wait for application defined event.
366 Inform select thread to stop selecting after main loop is exited.
367 (ns_term_init): Create selfds pipe and set non-blocking.
368 Initialize select_mutex. Start the select thread (fd_handler).
369 (fd_handler:): Loop forever, wait for info from the main thread
370 to either start or stop selecting. When select returns, send
371 and appdefined event.
372 (sendScrollEventAtLoc:fromEvent:): Check if q_event_ptr is set.
373 If not call kbd_buffer_store_event.
374
375 * nsterm.h (EmacsApp): fd_handler takes id argument.
376 (EmacsDialogPanel): Add timer_fired and timeout_handler.
377
ac4845a6
JD
378 * gtkutil.c (xg_mark_data): Use FRAME_X_P.
379
eb424fe3
EZ
3802012-08-15 Eli Zaretskii <eliz@gnu.org>
381
382 * region-cache.c (move_cache_gap): Update gap_len using the actual
383 growth of the boundaries array. Do not change cache_len.
384 (Bug#12196)
385
4e6a86c6
DA
3862012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
387
388 Generalize and cleanup font subsystem checks.
389 * font.h (FONT_DEBUG, font_assert): Remove.
8be3a09c
SM
390 * font.c, fontset.c, w32font.c, xfont.c, xftfont.c:
391 Change font_assert to eassert. Use eassert where appropriate.
4e6a86c6 392
5bf192ca
DA
3932012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
394
395 * gtkutil.c (xg_get_font): Use pango_units_to_double.
396
f2045622
CY
3972012-08-15 Chong Yidong <cyd@gnu.org>
398
8be3a09c
SM
399 * gtkutil.c (xg_get_font): Rename from xg_get_font_name.
400 When using the new font chooser, use gtk_font_chooser_get_font_desc to
401 extract the font descriptor instead of just the font name.
402 In that case, return a font spec instead of a string.
f2045622
CY
403 (x_last_font_name): Move to this file from xfns.c.
404
405 * xfns.c (Fx_select_font): The return value can also be a font
406 spec. Move x_last_font_name management to gtkutil.c.
407
408 * xfaces.c: Make font weight and style symbols non-static.
409
7f6feb56
SM
4102012-08-15 Stefan Monnier <monnier@iro.umontreal.ca>
411
412 * minibuf.c (read_minibuf): Ignore caller's inhibit-read-only
413 (bug#12117).
414
fecbd8ff
SM
4152012-08-14 Stefan Monnier <monnier@iro.umontreal.ca>
416
417 * alloc.c (Fgarbage_collect): Use plural form consistently.
418
9b8d5165
EZ
4192012-08-14 Eli Zaretskii <eliz@gnu.org>
420
421 * keyboard.c (command_loop_1): Reset ignore_mouse_drag_p flag each
422 iteration through the command loop. Fixes a problem whereby mouse
423 movements are ignored until the first mouse click.
424
f5d9e83a
PE
4252012-08-14 Paul Eggert <eggert@cs.ucla.edu>
426
427 Use bool, not int, for Lisp booleans.
428 This is more natural, and on my platform (GCC 4.7.1 x86-64) it
429 makes Emacs a bit smaller and presumably a bit faster.
430 * lisp.h: Include <stdbool.h>.
431 (struct Lisp_Boolfwd, defvar_bool):
432 * lread.c (defvar_bool): Use bool, not int, for Lisp booleans.
433 * regex.c [!emacs]: Include <stdbool.h>.
434 (false, true): Remove; <stdbool.h> does this for us now.
435
55802e4a
CY
4362012-08-14 Chong Yidong <cyd@gnu.org>
437
4abcdac8
CY
438 * character.c (Fcharacterp): Doc fix (Bug#12076).
439
440 * data.c (Findirect_variable): Doc fix (Bug#11040).
441
55802e4a
CY
442 * chartab.c (Fmap_char_table): Doc fix (Bug#12061).
443
444 * editfns.c (Fformat): Doc fix (Bug#12059).
4abcdac8 445 (Fsave_current_buffer): Doc fix (Bug#11542).
55802e4a 446
8e99d072
BR
4472012-08-14 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
448
449 * keyboard.c (access_keymap_keyremap): Accept anonymous functions
450 (bug#12022).
451
08908aca
MR
4522012-08-14 Martin Rudalics <rudalics@gmx.at>
453
454 * frame.c (make_frame_without_minibuffer, make_minibuffer_frame)
455 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
456 * minibuf.c (choose_minibuf_frame, read_minibuf):
457 * w32fns.c (x_create_tip_frame):
458 * xfns.c (x_create_tip_frame): Call set_window_buffer instead of
459 Fset_window_buffer (Bug#11984, Bug#12025, Bug#12026).
460
56120d6f
PE
4612012-08-14 Paul Eggert <eggert@cs.ucla.edu>
462
463 * intervals.c (offset_intervals): Remove obsolete comment.
464
67b77c0b
AS
4652012-08-14 Andreas Schwab <schwab@linux-m68k.org>
466
467 * gtkutil.c (find_rtl_image, update_frame_tool_bar): Use NILP.
468
f48b82fd
GR
4692012-08-14 Gergely Risko <gergely@risko.hu>
470
471 * coding.c (decode_coding): Record buffer modification before
472 disabling undo_list (Bug#11773).
473
fd318b54
DA
4742012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
475
476 Revert and cleanup some recent overlay changes.
477 * buffer.h (enum overlay_type): Remove.
478 (buffer_get_overlays, buffer_set_overlays): Likewise.
479 (buffer_set_overlays_before, buffer_set_overlays_after):
480 New function. Adjust users.
481 (unchain_both): Add eassert.
482
41a62dd9
DA
4832012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
484
485 * gtkutil.c (update_frame_tool_bar): Use EQ where appropriate.
486
5884c324
PE
4872012-08-14 Paul Eggert <eggert@cs.ucla.edu>
488
489 * gtkutil.c (xg_mark_data): Don't assume C99.
490
ca06f160
JD
4912012-08-13 Jan Djärv <jan.h.d@swipnet.se>
492
493 * gtkutil.c (xg_frame_tb_info): New struct.
494 (TB_INFO_KEY): New define.
495 (xg_free_frame_widgets): Free xg_frame_tb_info for frame if present.
496 (xg_mark_data): Mark Lisp_Objects in xg_frame_tb_info.
497 (xg_create_tool_bar): Allocate and initialize a xg_frame_tb_info
498 if not present.
499 (update_frame_tool_bar): Return early if data in xg_frame_tb_info
500 is up to date. Otherwise store new data.
501 (free_frame_tool_bar): Free xg_frame_tb_info if present.
502
7864a3f7
DA
5032012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
504
505 Use KSET for write access to Lisp_Object members of struct kboard.
506 * keyboard.h (KSET): New macro.
507 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
508 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
509 * xterm.c: Adjust users.
510
4c31be61
DA
5112012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
512
513 Use BSET for write access to Lisp_Object members of struct buffer.
514 * buffer.h (BSET): New macro.
515 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
516 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
517 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
518 * window.c, xdisp.c, xfns.c: Adjust users.
519
14ae4239
BT
5202012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
521
522 * lread.c (syms_of_lread): Initialize Vlexical_binding.
523
32bcadb4
JD
5242012-08-11 Jan Djärv <jan.h.d@swipnet.se>
525
3d29b2ce
JD
526 * nsterm.m (not_in_argv): New function.
527 (application:openFile, application:openTempFile:):
528 (application:openFileWithoutUI:, application:openFiles:): Open file
529 if not_in_argv returns non-zero (bug#12171).
530
32bcadb4 531 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
532 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
533 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
534 (xg_get_font_name): Use those functions/macros here.
535 Reported by Frans Oilinki <moilinki@gmail.com>.
536
9ff9402d 5372012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
538
539 * unexmacosx.c (copy_data_segment): Copy initialized data in
540 statically linked libraries from input file rather than memory.
541
db74a5fc
YM
542 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
543 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
544 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
545
25e65510
GM
5462012-08-10 Glenn Morris <rgm@gnu.org>
547
548 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
549 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
550
7961135c
DA
5512012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
552
553 Fix last change to allow compilation with low optimization levels.
554 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
555 Reported by Jan Djärv <jan.h.d@swipnet.se>.
556
42b3a444
DA
5572012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
558
559 Use common inline syntax in intervals.h.
560 * intervals.h (INTERVALS_INLINE): New macro.
561 Change all users from LISP_INLINE.
562
9fb0c957
DA
5632012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
564
565 Define Qnone once for all platforms.
566 * frame.c (Qnone): Define here.
567 (syms_of_frame): DEFSYM it.
568 * lisp.h (Qnone): New declaration.
569 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
570 * xfns.c: Remove duplication. Adjust users.
571
65e8ee52
DA
5722012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
573
574 Remove unused macros from intervals.h.
575 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
576 * intervals.c: Adjust comment.
577
9b855fd6
EZ
5782012-08-10 Eli Zaretskii <eliz@gnu.org>
579
580 * w32fns.c <w32_unicode_gui>: New static variable.
581 (globals_of_w32fns): Initialize it according to os_subtype.
582 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
583 testing os_subtype.
584
39cb9e56 5852012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
586 Eli Zaretskii <eliz@gnu.org>
587
588 Fix bug #10299 with Unicode characters sent by customized
589 keyboards created by MSKLC.
590 * w32fns.c (INIT_WINDOW_CLASS): New macro.
591 (w32_init_class): Use it to initialize the Emacs class with either
592 ANSI or Unicode API calls.
593 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
594 later.
595 (w32_wnd_proc): If the character code sent by WM_CHAR or
596 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
597 original message. Call DefWindowProcW on NT and later.
598
9374581a
GM
5992012-08-10 Glenn Morris <rgm@gnu.org>
600
4b94e8cf
GM
601 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
602
9374581a
GM
603 * lisp.h (DIRECTORY_SEP): Let configure set it.
604
a2752828
DA
6052012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
606
607 Use TSET for write access to Lisp_Object slots of struct terminal.
608 * termhooks.h (TSET): New macro.
609 * coding.c, terminal.c, xselect.c: Adjust users.
610
cc92c454
SM
6112012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
612
613 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
614 the failing expression, include them in the error message.
615 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
616 * lisp.h (internal_condition_case_n): Update declaration.
617
4cb3e6b3
DA
6182012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
619
620 Inline functions to examine and change buffer overlays.
621 * buffer.c (unchain_both): New function.
622 * buffer.h (buffer_get_overlays, buffer_set_overlays):
623 (buffer_has_overlays): New function.
624 (enum overlay_type): New enum.
625 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
626 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
627
8707c1e5
DA
6282012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
629
630 Inline functions to examine and change buffer intervals.
631 * alloc.c (mark_interval_tree): Remove.
632 (MARK_INTERVAL_TREE): Simplify.
633 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
634 * intervals.c (buffer_balance_intervals): New function.
635 (graft_intervals_into_buffer): Adjust indentation.
636 (set_intervals_multibyte): Simplify.
637 * buffer.h (BUF_INTERVALS): Remove.
638 (buffer_get_intervals, buffer_set_intervals): New function.
639 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
640 * intervals.c, textprop.c: Adjust users.
641
ad8c997f
DA
6422012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
643
644 Inline functions to examine and change string intervals.
645 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
646 (string_get_intervals, string_set_intervals): New function.
647 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
648 * lread.c, print.c, textprop.c: Adjust users.
649
32ac3a6b
GM
6502012-08-08 Glenn Morris <rgm@gnu.org>
651
652 * lisp.mk (lisp): Remove language/persian.elc.
653
77c7bcb1
DA
6542012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
655
656 Cleanup intervals.
657 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
658 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
659 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
660 Adjust comment. Move under #if 0.
77c7bcb1
DA
661 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
662 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
663
9c08a8d4
DA
6642012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
665
666 Check total length of intervals with eassert.
667 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
668 * intervals.c: Change all users to eassert.
669
26d16b35
EZ
6702012-08-07 Eli Zaretskii <eliz@gnu.org>
671
14ae4239
BT
672 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
673 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
674 INTERNAL_FIELD in Lisp_Cons.
675
c644523b
DA
6762012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
677
678 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
679 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
680 name since all xname users are fixed long time ago. Do not
681 use INTERNAL_FIELD.
682 (set_symbol_name, set_symbol_function, set_symbol_plist):
683 (set_symbol_next, set_overlay_plist): New function.
684 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
685 (struct Lisp_Overlay): Likewise.
686 (CVAR, MVAR, SVAR): Remove.
687 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
688 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
689 * xterm.c: Adjust users.
690 * .gdbinit: Change to use name field of struct Lisp_Symbol
691 where appropriate.
692
6a3d20cc
DA
6932012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
694
695 Basic functions to set Lisp_Object and pointer slots of intervals.
696 * intervals.h (interval_set_parent, interval_set_object):
697 (interval_set_left, interval_set_right, interval_set_plist):
698 (interval_copy_parent): New function.
699 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
700 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
701 Adjust indentation.
6a3d20cc
DA
702 (INTERVAL_SIZE): Remove. Adjust users.
703 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
704
4d2b044c
DA
7052012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
706
707 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
708 * process.h (PGET): Remove.
709 (struct Lisp_Process): Do not use INTERNAL_FIELD.
710 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
711
d3d50620
DA
7122012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
713
714 Drop WGET and revert read access to Lisp_Objects slots of struct window.
715 * window.h (WGET): Remove.
716 (struct window): Do not use INTERNAL_FIELD.
717 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
718 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
719 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
720 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
721 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
722 Adjust users.
723
d10a51dc
CY
7242012-08-07 Chong Yidong <cyd@gnu.org>
725
726 * window.c (Fwindow_edges, Fwindow_pixel_edges)
727 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
728 (Fdelete_window_internal): Signal an error if the window is not on
729 a live frame (Bug#12025).
730
e69b0960
DA
7312012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
732
733 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
734 * frame.h (FGET): Remove.
735 (struct frame): Do not use INTERNAL_FIELD.
736 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
737 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
738 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
739 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
740
25a20a3a
JB
7412012-08-06 Juanma Barranquero <lekktu@gmail.com>
742
743 * w32.c: Silence compiler warnings.
744 (map_w32_filename): Remove unused variable `is_fat'.
745 (chase_symlinks): Add parentheses around expression.
746
1c6f11f4
GM
7472012-08-06 Glenn Morris <rgm@gnu.org>
748
1db4583a
GM
749 * sysdep.c: Respect BROKEN_GETWD.
750
1c6f11f4
GM
751 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
752 Let configure handle it.
753 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
754
2b90362b
DA
7552012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
756
757 Use GCALIGNMENT where appropriate.
758 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
759 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
760 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
761
5f50daf2
EZ
7622012-08-06 Eli Zaretskii <eliz@gnu.org>
763
14ae4239
BT
764 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
765 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 766
cbcc7007
SM
7672012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
768
769 * buffer.h (struct buffer): Revert `indirections' to a simple int;
770 that should be sufficient for everyone.
771
4d365fa4
JD
7722012-08-06 Jan Djärv <jan.h.d@swipnet.se>
773
774 * keyboard.c (timer_check_2): Add break so timer_check returns next
775 timeout.
776
dd86bd82
DA
7772012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
778
779 Fix Windows build errors introduced after converting to WGET and WSET.
780 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
781 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
782
054e1668
JD
7832012-08-06 Jan Djärv <jan.h.d@swipnet.se>
784
785 * nsterm.m (ns_frame_rehighlight): Use FSET.
786
787 * nsmenu.m (ns_update_menubar): Use FSET.
788
21238f11
DA
7892012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
790
791 Separate read and write access to Lisp_Object slots of Lisp_Process.
792 * process.h (PGET, PSET): New macros similar to AREF and ASET.
793 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
794
077288cf
DA
7952012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
796
797 Separate read and write access to Lisp_Object slots of struct window.
798 * window.h (WGET, WSET): New macros similar to AREF and ASET.
799 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
800 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
801 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
802 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
803 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
804 Adjust users.
805
71688bd7
DA
8062012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
807
808 Fix Windows build errors introduced after converting to FGET and FSET.
809 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
810 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
811 (w32_judge_scroll_bars): Change to use FSET.
812 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
813
f99bac93
DA
8142012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
815
816 Fix replacement typo.
817 * window.c (replace_window): Set root_window instead of
818 selected_window. This fixes a total window subsystem
819 malfunction reported by Bastien Guerry <bzg@gnu.org>.
820
8c2a0f2d
GM
8212012-08-06 Glenn Morris <rgm@gnu.org>
822
823 * lisp.mk (lisp): Add language/persian.elc.
824
edd74c35
DA
8252012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
826
827 Separate read and write access to Lisp_Object slots of struct frame.
828 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
829 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
830 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
831 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
832 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
833
8671676c
AS
8342012-08-05 Andreas Schwab <schwab@linux-m68k.org>
835
836 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
837
663e2b3f
DA
8382012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
839
840 Generalize common compile-time constants.
841 * lisp.h (header_size, bool_header_size, word_size): Now here.
842 (struct Lisp_Vector): Add comment.
843 (struct Lisp_Bool_Vector): Move up to define handy constants.
844 (VECSIZE, PSEUDOVECSIZE): Simplify.
845 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
846 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
847 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
848 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
849 * xfont.c, xmenu.c: Use word_size where appropriate.
850
d32e47af
LM
8512012-08-05 Lawrence Mitchell <wence@gmx.li>
852
853 * search.c (Freplace_match): Treat \? in the replacement text
854 literally (Bug#8161).
855
e5d9c0d1
CY
8562012-08-05 Chong Yidong <cyd@gnu.org>
857
858 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
859 * frame.c (Vdelete_frame_functions):
860 * emacs.c (Vkill_emacs_hook): Doc fix.
861
8da0576b
EZ
8622012-08-04 Eli Zaretskii <eliz@gnu.org>
863
864 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
865 --with-x-toolkit=no builds.
866 Reported by Carsten Mattner <carstenmattner@gmail.com>.
867
02676e5d
CY
8682012-08-04 Chong Yidong <cyd@gnu.org>
869
870 * syntax.c (Fmodify_syntax_entry): Doc fix.
871
97147da9
EZ
8722012-08-04 Eli Zaretskii <eliz@gnu.org>
873
76151e2c
EZ
874 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
875 * w32.c (init_environment): Change the default values of many
876 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
877 them into environment when they were not already defined.
878 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 879 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
880 (check_windows_init_file): Now external, not static.
881 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
882 called when Vload_path is already set up.
883
884 * w32.h (check_windows_init_file): Add prototype.
885
886 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
887 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
888 compatibility with Posix platforms.
889 (main): Move the call to check_windows_init_file to here from
890 w32.c.
891 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
892 any, in the DEFALT argument into the root of the Emacs build or
893 installation tree, as appropriate.
894
895 * callproc.c (init_callproc_1): Call decode_env_path instead of
896 doing its equivalent by hand.
897 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
898 the code that sets Vexec_path run on MS-Windows.
899
900 * lread.c (init_lread): Add comments to #ifdef's.
901
97147da9
EZ
902 * msdos.c (dos_set_window_size, IT_update_begin)
903 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
904 instead of direct references.
905
185ee146
PE
9062012-08-04 Paul Eggert <eggert@cs.ucla.edu>
907
908 Export DEFAULT_REHASH_* to GDB.
909 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
910 Now constants, not macros.
911
8834c57a
PE
9122012-08-03 Paul Eggert <eggert@cs.ucla.edu>
913
98c6f1e3
PE
914 Remove unnecessary casts involving pointers.
915 These casts are no longer needed now that we assume C89 or later,
916 since they involve casting to or from void *.
917 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
918 (make_pure_float, make_pure_vector):
919 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
920 * macros.c (Fstart_kbd_macro):
921 * menu.c (find_and_return_menu_selection):
922 * minibuf.c (read_minibuf_noninteractive):
923 * sysdep.c (closedir):
924 * xdisp.c (x_produce_glyphs):
925 * xfaces.c (compare_fonts_by_sort_order):
926 * xfns.c (x_real_positions, select_visual):
927 * xselect.c (x_stop_queuing_selection_requests)
928 (x_get_window_property, x_get_window_property_as_lisp_data):
929 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
930 Remove unnecessary pointer casts.
931 * alloc.c (record_xmalloc): New function.
932 * lisp.h (record_xmalloc): New decl.
933 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
934 more like a function. This is because the pointer cast is not
935 needed. All uses changed.
936 * print.c (print_string, print_error_message): Avoid length recalc.
937
8834c57a
PE
938 Improve fix for macroexp crash with debugging (Bug#12118).
939 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
940 ARRAY_MARK_FLAG when checking subscripts, because ASET is
941 not supposed to be invoked from the garbage collector.
942 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
943 (gc_aset): New function, which is like ASET but can be
944 used in the garbage collector.
945 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
946 (set_hash_index): Use it instead of ASET.
947
6dad7178
EZ
9482012-08-03 Eli Zaretskii <eliz@gnu.org>
949
950 Support symlinks on latest versions of MS-Windows.
951 * w32.c: Include winioctl.h and aclapi.h.
952 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
953 (revert_to_self): Forward declarations of static functions.
954 <static BOOL g_b_init_get_security_info>:
955 <g_b_init_create_symbolic_link>: New static flags.
956 (globals_of_w32): Initialize them to zero.
957 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
958 (map_w32_filename): Improve commentary. Simplify switch.
959 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
960 headers (most versions of MinGW w32api don't).
961 (get_security_info, create_symbolic_link)
962 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
963 New functions.
964 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
965 in the argument file name.
966 (sys_access): Call unc_volume_file_attributes only if
967 GetFileAttributes fails with network-related error codes.
968 (sys_rename): Diagnose renaming of a symlink when the user doesn't
969 have the required privileges.
14ae4239 970 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
971 get_file_security_desc.
972 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
973 with addition of handling of symlinks and support for 'lstat'.
974 If possible, get file's attributes and security information by
6dad7178
EZ
975 handle, not by name. Produce S_IFLNK bit for symlinks, when
976 called from 'lstat'.
977 (stat, lstat): New functions, call 'stat_worker'.
978 (symlink, readlink, careadlinkat): Rewritten to create and resolve
979 symlinks when the underlying filesystem supports them.
980
f162bcc3
PE
9812012-08-02 Paul Eggert <eggert@cs.ucla.edu>
982
79ea6c20
PE
983 Fix macroexp crash on Windows with debugging (Bug#12118).
984 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
985 checking subscripts; problem introduced with the recent
986 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
987 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
988 since it's used in non-static inline functions now.
989
c0ce93fd
PE
990 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
991 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 992
f162bcc3
PE
993 Use C99-style 'extern inline' if available.
994 * buffer.h (BUFFER_INLINE):
995 * category.h (CATEGORY_INLINE):
996 * character.h (CHARACTER_INLINE):
997 * charset.h (CHARSET_INLINE):
998 * composite.h (COMPOSITE_INLINE):
999 * dispextern.h (DISPEXTERN_INLINE):
1000 * lisp.h (LISP_INLINE):
1001 * systime.h (SYSTIME_INLINE):
1002 New macro, replacing 'static inline' in this header.
1003 * buffer.h, category.h, character.h, charset.h, composite.h:
1004 * dispextern.h, lisp.h, systime.h:
1005 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1006 * alloc.c (LISP_INLINE):
1007 * buffer.c (BUFFER_INLINE):
1008 * category.c (CATEGORY_INLINE):
1009 * character.c (CHARACTER_INLINE):
1010 * charset.c (CHARSET_INLINE):
1011 * composite.c (COMPOSITE_INLINE):
1012 * dispnew.c (DISPEXTERN_INLINE):
1013 * sysdep.c (SYSTIME_INLINE):
1014 Define to EXTERN_INLINE, so that the corresponding functions
1015 are compiled into code.
1016 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
1017 (INLINE_HEADER_END): New macros.
1018 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
1019 since it's used in non-static inline functions now.
a8333d03 1020 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 1021
837b365b
GM
10222012-08-02 Glenn Morris <rgm@gnu.org>
1023
d66b744d
GM
1024 * s/: Remove empty directory.
1025
837b365b
GM
1026 * s/ms-w32.h: Move to ../nt/inc.
1027 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
1028 Update for new ms-w32.h location.
1029
13294f95
PE
10302012-08-02 Paul Eggert <eggert@cs.ucla.edu>
1031
1032 Port to Solaris 8.
1033 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
1034
90df0db3
GM
10352012-08-02 Glenn Morris <rgm@gnu.org>
1036
1037 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
1038 hard-coding the path separator.
1039
4939150c
PE
10402012-08-01 Paul Eggert <eggert@cs.ucla.edu>
1041
1042 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
1043 This how ASET and AREF are supposed to work, and makes
1044 it easier to think about future improvements. See
1045 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
1046 * charset.h (set_charset_attr): New function.
1047 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
1048 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
1049 (aref_addr): New function. All uses of &AREF(...) changed.
1050 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
1051 (set_hash_index): New functions. All lvalue-style uses of
1052 HASH_KEY etc. changed.
1053 * keyboard.c (set_prop): New function. All lvalue-style uses
1054 of PROP changed.
1055
947b2afd
AA
10562012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
1057
1058 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
1059 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
1060 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
1061 * nsfns.m (ns_set_name_as_filename): Likewise.
1062 * nsmenu.m (ns_update_menubar): Likewise.
1063 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
1064
4f5d0325
EZ
10652012-08-01 Eli Zaretskii <eliz@gnu.org>
1066
2008beae
EZ
1067 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
1068 Adapt to latest changes in field names of the corresponding Lisp
288479f6 1069 objects.
2008beae 1070
4f5d0325
EZ
1071 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
1072
fe3cc771
GM
10732012-08-01 Glenn Morris <rgm@gnu.org>
1074
1075 * s/msdos.h: Remove file.
1076 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
1077 * Makefile.in (S_FILE): Remove.
1078 (config_h): Remove S_FILE.
1079
c90acc54
JB
10802012-08-01 Juanma Barranquero <lekktu@gmail.com>
1081
1082 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
1083 Remove; moved to nt/config.nt.
1084
d8a05828
DA
10852012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1086
1087 Use INTERNAL_FIELD for conses and overlays.
1088 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
1089 Remove obsolete comment.
1090 (MVAR): New macro.
1091 (struct Lisp_Overlay): Use INTERNAL_FIELD.
1092 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
1093
8271d590
DA
10942012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1095
1096 Use INTERNAL_FIELD for symbols.
1097 * lisp.h (SVAR): New macro. Adjust users.
1098 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
1099 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
1100
3193acd2
DA
11012012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1102
1103 Use INTERNAL_FIELD for processes.
1104 * process.h (PVAR): New macro. Adjust style.
1105 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
1106 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
1107
3a45383a
DA
11082012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1109
1110 Use INTERNAL_FIELD for windows.
1111 * window.h (WVAR): New macro.
1112 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
1113 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
1114 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
1115 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
1116 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
1117 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
1118
c1dbc63c
PE
11192012-08-01 Paul Eggert <eggert@cs.ucla.edu>
1120
1121 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
1122
5c0c0e8a
GM
11232012-08-01 Glenn Morris <rgm@gnu.org>
1124
1125 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
1126 Move to configure.ac.
1127
552a99b4
JB
11282012-08-01 Juanma Barranquero <lekktu@gmail.com>
1129
1130 * makefile.w32-in (CONFIG_H): Update dependencies.
1131 (CONF_POST_H): New macro.
1132
1133 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
1134
8d8e2dfe
GM
11352012-07-31 Glenn Morris <rgm@gnu.org>
1136
bc96620a
GM
1137 * Makefile.in (S_FILE): No longer set by configure.
1138
476b1b2d
GM
1139 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
1140 is available.
1141 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
1142
b2c7a106
GM
1143 * process.h (NULL_DEVICE):
1144 * emacs.c (SEPCHAR):
1145 * editfns.c (USER_FULL_NAME): Let configure set them.
1146
d53d062a
GM
1147 * s/README, s/template.h: Remove files.
1148
4515017f
GM
1149 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
1150
8d8e2dfe
GM
1151 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
1152 Move to configure.ac.
1153
5b20b3cc
EZ
11542012-07-31 Eli Zaretskii <eliz@gnu.org>
1155
1e0afd9a
EZ
1156 * .gdbinit (xframe): Adapt to introduction of FVAR and the
1157 resulting renaming of 'struct frame' members.
1158
5b20b3cc
EZ
1159 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
1160
1161 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
1162 after introduction of FVAR.
1163
f1310128
JD
11642012-07-31 Jan Djärv <jan.h.d@swipnet.se>
1165
79e721e0
JD
1166 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
1167
1168 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
1169 instead of compositeToPoint.
1170 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
1171
8d7c7eed 1172 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 1173
e34f7f79
DA
11742012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1175
1176 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
1177 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 1178 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
1179 (BVAR): Change to use INTERNAL_FIELD.
1180 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
1181 (KVAR): Change to use INTERNAL_FIELD.
1182 * frame.h (FVAR): New macro.
1183 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
1184 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
1185 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
1186 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
1187 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
1188
c09bfb2f
DA
11892012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1190
1191 Miscellaneous fixes for non-default X toolkits.
1192 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
1193 * xterm.c (x_frame_of_widget): Remove redundant prototype.
1194 Move under #ifdef USE_LUCID.
1195 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
1196 definition and usage to avoid warnings.
1197
14c114ae
JD
11982012-07-31 Jan Djärv <jan.h.d@swipnet.se>
1199
1200 * nsterm.m (openFiles): Fix previous checkin.
1201
3bd21e82
PE
12022012-07-31 Paul Eggert <eggert@cs.ucla.edu>
1203
1204 * indent.c (compute_motion): Remove unused local.
1205
c1529ded
GM
12062012-07-31 Glenn Morris <rgm@gnu.org>
1207
400d5621
GM
1208 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
1209
268e2432
GM
1210 * conf_post.h [USG5_4]:
1211 Move remaining contents of s/usg5-4-common.h here.
1212 * s/usg5-4-common.h: Remove file.
1213
7552f3ee
GM
1214 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
1215 * s/irix6-5.h: Remove file.
1216
6a381852
GM
1217 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
1218 * s/darwin.h: Remove file.
1219
c1529ded
GM
1220 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
1221 * s/hpux10-20.h: Remove file, which is now empty.
1222
b429a4ee
GM
12232012-07-30 Glenn Morris <rgm@gnu.org>
1224
1225 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
1226 * Makefile.in (config_h): Add conf_post.h.
1227 * makefile.w32-in (CONFIG_H): Add conf_post.h.
1228
adff3182
JD
12292012-07-30 Jan Djärv <jan.h.d@swipnet.se>
1230
1231 * nsterm.m (ns_do_open_file): New variable.
b9031d69 1232 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
1233 (openFile, openTempFile, openFileWithoutUI, openFiles):
1234 Open files only if ns_do_open_file.
adff3182 1235
c32af1e4
PE
12362012-07-30 Paul Eggert <eggert@cs.ucla.edu>
1237
7393bcbb
PE
1238 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
1239 This no-op macro hasn't been needed for many years.
1240 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
1241
c32af1e4
PE
1242 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
1243 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
1244 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
1245 gdb_make_enums_visible.
1246 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
1247 (DIRECTORY_SEP): Now a constant, not a macro.
1248
302fc036
EZ
12492012-07-30 Eli Zaretskii <eliz@gnu.org>
1250
1251 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
1252 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
1253
1254 * w32term.c <w32_keyboard_codepage>: Renamed from
1255 keyboard_codepage and now external. All users changed.
1256
1257 * w32term.h: Add declaration of w32_keyboard_codepage.
1258
1259 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
1260 the codepage to translate keys to Unicode. If this argument is
1261 -1, use the value returned by GetConsoleCP. All callers changed.
1262
88fb40b4
PE
12632012-07-30 Paul Eggert <eggert@cs.ucla.edu>
1264
0aee6912
PE
1265 Update .PHONY listings in makefiles.
1266 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
1267 bootstrap-clean, distclean, maintainer-clean, versioclean,
1268 extraclean, frc.
1269
88fb40b4
PE
1270 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
1271 This is a bit clearer. Fix some commentary typos.
1272
0a763bd1
GM
12732012-07-30 Glenn Morris <rgm@gnu.org>
1274
32bac6d6
GM
1275 * s/netbsd.h: Let configure include signal.h if needed.
1276 Remove file, which is now empty.
1277
b65e7c46
GM
1278 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
1279 Let configure set them.
1280 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
1281 No more need to undefine.
0a763bd1 1282
169304bd
AS
12832012-07-30 Andreas Schwab <schwab@linux-m68k.org>
1284
1285 * keymap.c (Fkey_description): Don't remove 0x80 bit from
1286 non-single-byte char when adding meta modifier. (Bug#12090)
1287
6cd7a139
DA
12882012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1289
1290 Convert safe_call to use variable number of arguments.
1291 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
1292 (safe_call2): Fix comment.
1293 * lisp.h (safe_call): Adjust prototype.
1294 * coding.c (encode_coding_object): Change to use safe_call2.
1295 * xfaces.c (merge_face_heights): Change to use safe_call1.
1296
d34d6ffc
GM
12972012-07-30 Glenn Morris <rgm@gnu.org>
1298
7b8a48e4 1299 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 1300 does that unconditionally. Remove file, which is now empty.
7b8a48e4 1301
d34d6ffc
GM
1302 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
1303 Remove empty files.
1304
03a660a6
PE
13052012-07-30 Paul Eggert <eggert@cs.ucla.edu>
1306
1307 Export to GDB most of lisp.h's remaining object-like macros.
1308 * lisp.h (min, max): Move earlier, because they're used earlier now.
1309 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
1310 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
1311 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
1312 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
1313 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
1314 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
1315 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
1316 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
1317 Now constants, for GDB. They need not be macros.
1318 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
1319 Now constants, for GDB, as well as macros, for static initializers.
1320 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
1321 Move to after the definition of struct Lisp_Char_Table,
1322 since the former now needs that type defined.
1323 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
1324 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
1325 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
1326 New enums, for gdb_make_enums_visible.
1327 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 1328 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
1329 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
1330 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
1331 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
1332 enum maxargs, enum MAX_ALLOCA.
1333 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
1334 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
1335 no longer needed, now that they are done in lisp.h.
1336
e499d0ee
DA
13372012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1338
1339 Cleanup string bytes checking.
1340 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
1341 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
1342 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
1343 (check_sblock, compact_small_strings): Simplify.
1344
d5040d2d
PE
13452012-07-29 Paul Eggert <eggert@cs.ucla.edu>
1346
1347 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
1348 These macros are confusing and no longer need to be defined, as
1349 the enum values now suffice. All uses replaced with definiens.
1350 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
1351
7f259ae6
JB
13522012-07-29 Juanma Barranquero <lekktu@gmail.com>
1353
1354 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
1355 ($(BLD)/w32console.$(O)): Update dependencies.
1356
7e63e0c3
DA
13572012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1358
1359 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
1360 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
1361 time. Adjust users.
1362 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
1363
ffd817eb
JD
13642012-07-29 Jan Djärv <jan.h.d@swipnet.se>
1365
1366 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
1367 setting sitelisp (Bug#12010).
1368
417a7a0e
EZ
13692012-07-29 Eli Zaretskii <eliz@gnu.org>
1370
14ae4239 1371 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
1372
1373 * w32heap.c (cache_system_info):
1374 * w32.c (sys_rename):
1375 * w32proc.c (find_child_console, sys_kill): All users changed.
1376
387d4d92
PE
13772012-07-29 Paul Eggert <eggert@cs.ucla.edu>
1378
1379 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
1380
55a6cca6
EZ
13812012-07-29 Eli Zaretskii <eliz@gnu.org>
1382
1383 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
1384
dbcf001c
DA
13852012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1386
1387 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
1388 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
1389 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 1390
e2688e4a
DA
13912012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1392
1393 Generalize marker debugging code under MARKER_DEBUG and use eassert.
1394 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
1395 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
1396 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
1397 (replace_range, replace_range_2, del_range_2): Change to eassert.
1398 * marker.c (byte_char_debug_check): Adjust style.
1399
b46a6a83
PE
14002012-07-29 Paul Eggert <eggert@cs.ucla.edu>
1401
1402 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
1403 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
1404 long-ago-commented-out code that talks about "WIN32".
1405 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
1406 All uses changed.
1407
e32a5799
PE
14082012-07-28 Paul Eggert <eggert@cs.ucla.edu>
1409
1410 Use Gnulib stdalign module (Bug#9772, Bug#9960).
1411 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
1412 Simplify by using alignof.
1413 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
1414 * lisp.h: Include <stdalign.h>.
1415 (GCALIGNMENT): New macro and constant.
1416 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
1417 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
1418 (stdalign): New macro, if not already defined.
1419
df81cd29
EZ
14202012-07-28 Eli Zaretskii <eliz@gnu.org>
1421
01bd1b0d
EZ
1422 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
1423 * w32inevt.c: Include w32inevt.h.
1424 (w32_read_console_input): New inline function, calls either
1425 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
1426 w32_console_unicode_input.
1427 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
1428 (w32_kbd_patch_key, key_event): Use the codepage returned by
1429 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
1430 (key_event): use uChar.UnicodeChar only if
1431 w32_console_unicode_input is non-zero.
1432
1433 * w32console.c: Include w32heap.h.
1434 <w32_console_unicode_input>: New global variable.
1435 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
1436 family of Windows, zero otherwise.
1437
1438 * w32inevt.h: Declare w32_console_unicode_input.
1439
df81cd29
EZ
1440 * xdisp.c (init_iterator): Don't reference tip_frame in a build
1441 --without-x. (Bug#11742)
1442
c20fdd9e
PE
14432012-07-27 Paul Eggert <eggert@cs.ucla.edu>
1444
1445 Adjust GDB to reflect pvec_type changes (Bug#12036).
1446 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
1447 2012-07-04 changes to pseudovector representation.
1448 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 1449
32770973 14502012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
1451
1452 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
1453 bus address.
1454 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
1455
3438fe21
EZ
14562012-07-27 Eli Zaretskii <eliz@gnu.org>
1457
bcfbc9de
EZ
1458 * alloc.c (listn): Fix the order the arguments are consed onto the
1459 list.
1460
3438fe21
EZ
1461 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
1462 enumeration constants, as PURE and HEAP are too general, and clash
1463 with other headers and sources, such as gmalloc.c and the
1464 MS-Windows system headers. All users changed.
1465
eeaea515
DA
14662012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1467
1468 Revert last save_excursion_save and save_excursion_restore changes.
1469 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
1470 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
1471
073c88c2
DA
14722012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1473
1474 Fix recently-introduced typos in Windows port.
1475 Reported by Martin Rudalics <rudalics@gmx.at>.
1476 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 1477 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 1478
4706125e
PE
14792012-07-27 Paul Eggert <eggert@cs.ucla.edu>
1480
1481 Improve GDB symbol export (Bug#12036).
1482 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
1483 arms of an 'if', not using conditional expressions; otherwise GDB
1484 complains about the types in the unevaluated arm when the argument
1485 is an integer literal.
1486 (xgetint): Simplify expression.
1487 * alloc.c (gdb_make_enums_visible): New constant. This ports to
1488 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
1489 Zaretskii in <http://bugs.gnu.org/12036#13>.
1490 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
1491 needed now that we have gdb_make_enums_visible.
1492 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
1493 (enum enum_USE_LSB_TAG):
1494 New enum types, packaging up enums that need to be exported to GDB.
1495
694b6c97
DA
14962012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1497
1498 Utility function to make a list from specified amount of objects.
1499 * lisp.h (enum constype): New datatype.
1500 (listn): New prototype.
1501 * alloc.c (listn): New function.
1502 (Fmemory_use_count, syms_of_alloc): Use it.
1503 * buffer.c (syms_of_buffer): Likewise.
1504 * callint.c (syms_of_callint): Likewise.
1505 * charset.c (define_charset_internal): Likewise.
1506 * coding.c (syms_of_coding): Likewise.
1507 * keymap.c (syms_of_keymap): Likewise.
1508 * search.c (syms_of_search): Likewise.
1509 * syntax.c (syms_of_syntax): Likewise.
1510 * w32.c (init_environment): Likewise.
1511 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
1512 * xdisp.c (syms_of_xdisp): Likewise.
1513 * xfns.c (syms_of_xfns): Likewise.
1514
6195f384
DA
15152012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1516
1517 Fast save_excursion_save and save_excursion_restore.
1518 * lisp.h (struct Lisp_Excursion): New data type.
1519 (PVEC_EXCURSION): New pseudovector type.
1520 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
1521 to deal with it. Adjust comments.
1522 (init_marker, attach_marker): New prototype.
1523 (unchain_marker): Adjust prototype.
1524 * marker.c (attach_marker): Change to global.
1525 (init_marker): New function.
1526 * alloc.c (Fmake_marker, build_marker): Use it.
1527 (build_marker): More easserts.
1528 (mark_object): Handle struct Lisp_Excursion.
1529 * editfns.c (save_excursion_save, save_excursion_restore):
1530 Reimplement to use struct Lisp_Excursion. Add comments.
1531
5eceb8fb
PE
15322012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1533
1534 Fix export of symbols to GDB (Bug#12036).
1535 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
1536 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
1537 emacs.c, as this is a more-suitable home. Had this been done earlier
1538 the fix for 12036 would have avoided some of the problems noted in
1539 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
1540 would have been more obvious.
562157c8
PE
1541 * emacs.c: Do not include <verify.h>; no longer needed.
1542 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
1543 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
1544 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1545 Remove; now done in lisp.h.
1546 * lisp.h (PUBLISH_TO_GDB): New macro.
1547 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
1548 (DATA_SEG_BITS): Use it.
1549 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
1550 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
1551 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
1552 not be usable in #if. This simplifies things.
1553
d6749401
JB
15542012-07-26 Juanma Barranquero <lekktu@gmail.com>
1555
1556 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
1557
1781b9e9
PE
15582012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1559
d89518db 1560 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
1561 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
1562 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
1563 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
1564 Adjust to changes in lisp.h and emacs.c, by using
1565 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
1566 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
1567 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
1568 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
1569 instead of gdb_valbits.
1570 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
1571 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
1572 instead of gdb_array_mark_flag.
1573 (xboolvector): Get size from $->size, not $->header.size.
1574 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
1575 (xreload, hook-run, hookpost-run): Remove.
1576 * emacs.c: Include <verify.h>.
1577 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
1578 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
1579 Remove.
1580 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
1581 (gdb_USE_LSB_TAG): New enum constants.
1582 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1583 Also define these as enum constants, so they're visible to GDB.
1584 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
1585 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
1586 as constants, so they're visible to GDB.
1587 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
1588 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
1589 Now enum constants, not macros, so they're visible to GDB.
1590 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
1591 more convenient now. All uses changed.
1592 (VALMASK) [USE_LSB_TAG]: Also define in this case.
1593 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
1594
3628596a
DA
15952012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
1596
1597 Explicitly free restriction data that are not needed anymore.
1598 * editfns.c (save_restriction_restore): Free restriction data.
1599
7abaf5cc
SM
16002012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1601
1602 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
1603 add argument, tune behavior, and adjust all callers.
1604
71f88e00
PE
16052012-07-25 Paul Eggert <eggert@cs.ucla.edu>
1606
1607 Use typedef for EMACS_INT, EMACS_UINT.
1608 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
1609 than macros. This simplifies debugging in the usual case, since
1610 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
1611 and it allows expressions involving EMACS_INT casts.
1612 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
1613
57ec3034
JD
16142012-07-25 Jan Djärv <jan.h.d@swipnet.se>
1615
1616 * nsterm.m (ns_read_socket): Return early if there is a modal
1617 window (Bug#12043).
1618
8137e7b3
MR
16192012-07-25 Martin Rudalics <rudalics@gmx.at>
1620
1621 * frame.c (Fredirect_frame_focus): In doc-string don't mention
1622 that FOCUS-FRAME can be omitted.
1623
04e9897c
DA
16242012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
1625
1626 Adjust buffer text indirection counters at the end of Fkill_buffer.
1627 * buffer.c (Fkill_buffer): Adjust indirection counters when the
1628 buffer is definitely dead. This should really fix an issue reported
1629 by Christoph Scholtes again. (Bug#12007).
1630 (init_buffer_once): Initialize indirection counters of
1631 buffer_defaults and buffer_local_symbols (for sanity and safety).
1632
8a0484e1
EZ
16332012-07-24 Eli Zaretskii <eliz@gnu.org>
1634
1635 * xdisp.c (init_iterator): Don't compute dimensions of truncation
1636 and continuation glyphs on tooltip frames, leave them at zero.
1637 Avoids continued lines in tooltips. (Bug#11832)
1638
fa691a83
DA
16392012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
1640
1641 Simplify copy_overlay.
04e9897c 1642 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
1643 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
1644
436bc8e0
EZ
16452012-07-23 Eli Zaretskii <eliz@gnu.org>
1646
1647 * print.c (print_object): Don't crash when a frame's name is nil
1648 or invalid. (Bug#12025)
1649
1650 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
1651 it signals an error when a tooltip frame is being created.
1652
d7a7fda3
DA
16532012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
1654
1655 Cleanup miscellaneous objects allocation and initialization.
1656 * alloc.c (allocate_misc): Change to static. Add argument to
1657 specify the subtype. Adjust comment and users.
1658 (build_overlay): New function.
1659 * buffer.c (copy_overlays, Fmake_overlay): Use it.
1660 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
1661 (allocate_misc): Remove prototype.
1662 (build_overlay): Add prototype.
1663
16642012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
1665
1666 Swap buffer text indirection counters in Fbuffer_swap_text.
1667 * buffer.c (Fbuffer_swap_text): Swap indirections too.
1668 This avoids crash reported by Christoph Scholtes at
1669 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
1670
9d7fa573
JD
16712012-07-22 Jan Djärv <jan.h.d@swipnet.se>
1672
1673 * nsmenu.m (Popdown_data): New struct.
1674 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
1675 free Popdown_data.
1676 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
1677 (initWithContentRect): Make imgView and contentView non-static
1678 and autorelease them. Also autorelease img and matrix (Bug#12005).
1679 (dealloc): Remove (Bug#12005).
1680
0dd6d66d
DA
16812012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1682
1683 Adjust consing_since_gc when objects are explicitly freed.
1684 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
1685 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
1686 (free_cons, free_misc): Subtract object size from consing_since_gc.
1687
d36d71df
DA
16882012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1689
1690 Simplify and cleanup markers positioning code.
1691 * marker.c (attach_marker): More useful eassert.
1692 (live_buffer, set_marker_internal): New function.
1693 (Fset_marker, set_marker_restricted): Use set_marker_internal.
1694 (set_marker_both, set_marker_restricted_both): Use live_buffer.
1695
fb9ea40f
PE
16962012-07-22 Paul Eggert <eggert@cs.ucla.edu>
1697
1698 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
1699 as it's limited by the amount of memory, not by INT_MAX.
1700
2d5c5f7d
EZ
17012012-07-21 Eli Zaretskii <eliz@gnu.org>
1702
07fb592e
EZ
1703 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
1704 in special-event-map. See the discussion at
1705 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
1706 for the reasons.
1707
37a9eac8 1708 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
1709 info.dwItemData. Fixes crashes on 64-bit Windows.
1710 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 1711
c4328746
JD
17122012-07-21 Jan Djärv <jan.h.d@swipnet.se>
1713
1714 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 1715 (conversationIdentifier): Return value is NSInteger.
784051c4 1716 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 1717
6e5d1c12
CY
17182012-07-21 Chong Yidong <cyd@gnu.org>
1719
1720 * window.c (decode_any_window): Signal an error if the window is
1721 on a dead frame (Bug#11984).
1722
9928463d
DA
17232012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1724
1725 Add indirection counting to speed up Fkill_buffer.
1726 * buffer.h (struct buffer): New member.
1727 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
1728 (Fmake_indirect_buffer): Set indirection counter to -1, increment
1729 base buffer indirection counter.
1730 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
1731 (Fkill_buffer): Adjust indirection counters as needed, don't walk
1732 through buffer list if indirection counter is 0.
1733
f8643a6b
DA
17342012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1735
1736 Extend the value returned by Fgarbage_collect with heap statistics.
1737 * alloc.c (Qheap): New symbol.
1738 (syms_of_alloc): DEFSYM it.
1739 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
1740 (Fmemory_free): Remove.
1741 (syms_of_alloc): Don't defsubr it.
1742 * buffer.c (Fcompact_buffer): Remove.
1743 (syms_of_buffer): Don't defsubr it.
1744
dac616ff
DA
17452012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1746
1747 Make maybe_gc inline.
1748 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
1749 * lisp.h (consing_since_gc, gc_relative_threshold)
1750 (memory_full_cons_threshold): Revert declaration.
1751 (maybe_gc): Remove prototype, define as inline.
1752 * alloc.c: Remove old commented-out code.
1753 (consing_since_gc, gc_relative_threshold)
1754 (memory_full_cons_threshold): Revert to global.
1755 (maybe_gc): Remove.
1756
d7ea76b4
DA
17572012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1758
1759 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
1760 * lisp.h (build_unibyte_string): New function.
1761 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
1762 * sysdep.c, w32fns.c, xfns.c: Use it.
1763 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
1764 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
1765 Adjust users accordingly.
1766 * font.h (font_open_by_name): Adjust prototype.
1767
765e61e3
DA
17682012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1769
1770 Cleanup calls to Fgarbage_collect.
1771 * lisp.h (maybe_gc): New prototype.
1772 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1773 Remove declarations.
1774 * alloc.c (maybe_gc): New function.
1775 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1776 Make them static.
1777 * bytecode.c (MAYBE_GC): Use maybe_gc.
1778 * eval.c (eval_sub, Ffuncall): Likewise.
1779 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
1780 to avoid dependency from auto-save feature.
1781
52b852c7
PE
17822012-07-19 Paul Eggert <eggert@cs.ucla.edu>
1783
1784 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
1785 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
1786 'for_each_per_buffer_object_at'.
1787 All uses changed. It's better to use upper-case for macros that
1788 cannot be implemented as functions, to give the reader a clue
1789 that they're special.
1790
5db81e33
SM
17912012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
1792
1793 * alloc.c (Fgarbage_collect): Tweak docstring.
1794
5b835e1d
DA
17952012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1796
1797 Tweak the value returned from Fgarbage_collect again.
1798 * alloc.c (Fgarbage_collect): New return value, as confirmed in
1799 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
1800 Adjust documentation.
1801 (total_vector_bytes): Rename to total_vector_slots, adjust
1802 accounting.
1803 (total_free_vector_bytes): Rename to total_free_vector_slots,
1804 adjust accounting.
1805 (Qstring_bytes, Qvector_slots): New symbols.
1806 (syms_of_alloc): DEFSYM them.
1807
9cd47b72
DA
18082012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1809
1810 Buffer compaction primitive which may be used from Lisp.
1811 * buffer.c (compact_buffer, Fcompact_buffer): New function.
1812 (syms_of_buffer): Register Fcompact_buffer.
1813 * alloc.c (Fgarbage_collect): Use compact_buffer.
1814 * buffer.h (compact_buffer): New prototype.
1815 (struct buffer_text): New member.
1816
d17337e5
DA
18172012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1818
1819 New macro to iterate over all buffers, miscellaneous cleanups.
1820 * lisp.h (all_buffers): Remove declaration.
1821 * buffer.h (all_buffers): Add declaration, with comment.
1822 (for_each_buffer): New macro.
1823 * alloc.c (Fgarbage_collect, mark_object): Use it.
1824 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
1825 (init_buffer): Likewise.
1826 * data.c (Fset_default): Likewise.
1827 * coding.c (code_conversion_restore): Remove redundant check
1828 for dead buffer.
1829 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
1830
60cfd278
AS
18312012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1832
1833 Fix bug that created negative-length intervals.
1834 * intervals.c (merge_interval_right, merge_interval_left):
1835 Do not zero out this interval if it is absorbed by its children,
1836 as this interval's total length doesn't change in that case. See
1837 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
1838
d06714cb
PE
18392012-07-18 Paul Eggert <eggert@cs.ucla.edu>
1840
83713154
PE
1841 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
1842 when invoking (make-bool-vector N t) and N is a positive
1843 multiple of 8 -- the last 8 bits were mistakenly cleared.
1844
d06714cb
PE
1845 Remove some struct layout assumptions in bool vectors.
1846 * alloc.c (bool_header_size): New constant.
1847 (header_size, word_size): Move earlier, as they're now used earlier.
1848 Use 'word_size' in a few more places, where it's appropriate.
1849 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
1850 padding before the data member of a bool vector.
1851 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
1852 than doing the check by hand with an abort ().
1853
464d5a5e
SM
18542012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1855
5fbc0409
SM
1856 * eval.c (Fdefvar): Don't check constants since we only set the var if
1857 it's not yet defined anyway (bug#11904).
1858
464d5a5e
SM
1859 * lisp.h (last_undo_boundary): Declare new var.
1860 * keyboard.c (command_loop_1): Set it.
1861 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
1862 were auto-added by the command loop (bug#11774).
1863
8dc2e44a
AS
18642012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1865
1866 * w32font.c (Qsymbol): Remove local definition.
1867 (syms_of_w32font): Don't DEFSYM it.
1868
169925ec
DA
18692012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1870
1871 Fix sweep_vectors to handle large bool vectors correctly.
1872 * alloc.c (sweep_vectors): Account total_vector_bytes for
1873 bool vectors larger than VBLOCK_BYTES_MAX.
1874
5fbfb018
CY
18752012-07-18 Chong Yidong <cyd@gnu.org>
1876
1877 * frame.c (x_set_frame_parameters): Revert bogus change introduced
1878 in 2012-05-25 commit by Paul Eggert (Bug#11738).
1879
3ab6e069
DA
18802012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1881
1882 Return more descriptive data from Fgarbage_collect.
1883 Suggested by Stefan Monnier in
1884 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
1885 * alloc.c (bounded_number): New function.
1886 (total_buffers, total_vectors): New variable.
1887 (total_string_size): Rename to total_string_bytes, adjust users.
1888 (total_vector_size): Rename to total_vector_bytes, adjust users.
1889 (sweep_vectors): Account total_vectors and total_vector_bytes.
1890 (Fgarbage_collect): New return value. Adjust documentation.
1891 (gc_sweep): Account total_buffers.
1892 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
1893 (VECTOR_SIZE): Remove.
1894 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
1895 (Qinterval, Qmisc): New symbols.
1896 (syms_of_data): Initialize them.
1897 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
1898 (Qcons, Qbuffer): New declarations.
1899
6d02fe5b
PE
19002012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1901
1902 * alloc.c (Fmemory_free): Account for memory-free's own storage.
1903 Round up, not down. Improve doc.
1904
b7ffe040
DA
19052012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1906
1907 Restore old code in allocate_string_data to avoid Faset breakage.
1908 Reported by Julien Danjou <julien@danjou.info> in
1909 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
1910 * alloc.c (allocate_string_data): Restore old code with minor
1911 adjustments, fix comment to explain this subtle issue.
1912
4dc7c8d5
SM
19132012-07-17 Eli Zaretskii <eliz@gnu.org>
1914
1915 Remove FILE_SYSTEM_CASE.
1916 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
1917
1918 * fileio.c (FILE_SYSTEM_CASE): Don't define.
1919 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
1920 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
1921 call-process-region passes it through expand-file-name.
1922
1923 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
1924
19252012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1926
1927 Fix crash when creating indirect buffer (Bug#11917)
1928 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
1929 Don't handle unbound variables specially if non-zero.
1930 (Fbuffer_local_variables): Pass zero.
1931 (clone_per_buffer_values): Pass non-zero.
1932
19332012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1934
1935 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
1936 to make the loop interruptible.
1937
19382012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1939
1940 * gnutls.c (emacs_gnutls_handshake): Only retry if
1941 GNUTLS_E_INTERRUPTED.
1942
cce7fefc
DA
19432012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1944
1945 Cleanup and convert miscellaneous checks to eassert.
1946 * alloc.c (mark_interval): Fix comment, partially rephrase
1947 old comment from intervals.h (see below).
1948 * intervals.c (find_interval, adjust_intervals_for_insertion)
1949 (delete_interval, adjust_intervals_for_deletion)
1950 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
1951 Convert to eassert.
1952 (adjust_intervals_for_insertion, make_new_interval):
1953 Remove obsolete and unused code.
1954 * intervals.h (struct interval): Remove obsolete comment.
1955 * textprotp.c (erase_properties): Remove unused code.
1956 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
1957 (Fremove_list_of_text_properties): Convert to eassert.
1958
9ea10cc3
CY
19592012-07-17 Chong Yidong <cyd@gnu.org>
1960
1961 * editfns.c (Finsert_char): Doc fix.
1962
3900d5de
DA
19632012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1964
1965 Fix previous change to make Fmemory_free always accurate.
1966 * alloc.c (make_interval): Update total_free_intervals.
1967 (make_float): Likewise for total_free_floats.
1968 (free_cons, Fcons): Likewise for total_free_conses.
1969 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
1970 Likewise for total_free_vector_bytes.
1971 (Fmake_symbol): Likewise for total_free_symbols.
1972 (bytes_free): Remove.
1973
7098646f
DA
19742012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1975
1976 Simple free memory accounting feature.
1977 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
1978 (sweep_vectors): Accumulate size of free vectors.
1979 (Fgarbage_collect): Setup bytes_free.
1980 (Fmemory_free): New function.
1981 (syms_of_alloc): Register it.
1982
22657b40
DA
19832012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1984
1985 Cleanup overlays checking.
1986 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
1987 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
1988 eassert and OVERLAYP.
1989 (sort_overlays): Change to use OVERLAYP.
1990
ddfc8813
RK
19912012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
1992
1993 * editfns.c (Finsert_char): Make it interactive, and make the
1994 second arg optional. Copy interactive spec and docstring from
1995 ucs-insert.
1996
7c26cf3c
PE
19972012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1998
1999 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
2000 Unlike the other wrapped functions, fabs has an unspecified
2001 effect on errno.
2002
5d127af9
JD
20032012-07-16 Jan Djärv <jan.h.d@swipnet.se>
2004
2005 * nsterm.m (keyDown): Interpret flags without left/right bits
2006 as the left key (Bug#11670).
2007
6a0dd1d7
DA
20082012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
2009
2010 Remove empty and useless init functions.
2011 * lisp.h (init_character_once, init_fns, init_image)
2012 (init_filelock, init_sound): Remove prototype.
2013 * character.c (init_character_once): Remove.
2014 * filelock.c (init_filelock): Likewise.
2015 * fns.c (init_fns): Likewise.
2016 * image.c (init_image): Likewise.
2017 * sound.c (init_sound): Likewise.
2018 * emacs.c (main): Adjust accordingly.
2019
7a6136fd
DA
20202012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
2021
2022 * gtkutil.h: Tiny cleanups.
2023 (use_old_gtk_file_dialog): Remove useless declaration.
2024 (xg_uses_old_file_dialog): Add suggested const attribute.
2025
ce811ad9
EZ
20262012-07-15 Eli Zaretskii <eliz@gnu.org>
2027
2028 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
2029 (bidi_paragraph_init): Use it to limit search forward for a strong
2030 directional character in abnormally large paragraphs full of
2031 neutral or weak characters. (Bug#11943)
2032
c9adfeaa
SF
20332012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
2034
2035 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
2036 the toolbar (Bug#9451).
2037 (xg_make_tool_item): Give the widget event box a transparent
2038 background.
2039
fff62aa9
DA
20402012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
2041
2042 Cleanup basic allocation variables and functions.
2043 * alloc.c (ignore_warnings, init_intervals, init_float)
2044 (init_cons, init_symbol, init_marker): Remove.
2045 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
2046 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
2047 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
2048 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
2049 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
2050 (staticidx, init_alloc_once, init_strings, free_ablock):
2051 Remove redundant initialization.
2052 * fns.c (init_weak_hash_tables): Remove.
2053 * lisp.h (init_weak_hash_tables): Remove prototype.
2054
9730daca
DA
20552012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
2056
2057 Use zero_vector where appropriate.
2058 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
2059 accordingly.
2060 * lisp.h (zero_vector): New declaration.
2061 * font.c (null_vector): Remove.
2062 (syms_of_font): Remove initialization and staticpro.
2063 (font_list_entities, font_find_for_lface): Change to use zero_vector.
2064 * keymap.c (Faccessible_keymaps): Likewise.
2065
2e2d2a13
LL
20662012-07-15 Leo Liu <sdl.web@gmail.com>
2067
2068 * fringe.c: Fix typo in comments.
2069
cd276f6e
LL
20702012-07-14 Leo Liu <sdl.web@gmail.com>
2071
2072 * fringe.c: Add a new bitmap exclamation-mark.
2073
5a1131d9
EZ
20742012-07-14 Eli Zaretskii <eliz@gnu.org>
2075
2076 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
2077
2078 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
2079 (HAVE_MENUS): Don't define, defined by editing config.in with
2080 msdos/sed2v2.inp.
2081 (GMALLOC_INHIBIT_VALLOC): Don't define.
2082 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
2083
22e983b7
JB
20842012-07-14 Juanma Barranquero <lekktu@gmail.com>
2085
2086 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
2087
5b3f250f
GM
20882012-07-14 Glenn Morris <rgm@gnu.org>
2089
2090 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
2091 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
2092 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
2093
33d63ff4
GM
20942012-07-13 Glenn Morris <rgm@gnu.org>
2095
5b633342
GM
2096 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
2097
33d63ff4
GM
2098 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
2099 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
2100
b55b9f85
JD
21012012-07-13 Jan Djärv <jan.h.d@swipnet.se>
2102
0dc8cf50
JD
2103 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
2104 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
2105 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
2106 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
2107 where appropriate.
2108 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
2109 as boolean expression.
2110 (x_set_window_size): Remove unused variable toolbar.
2111 (ns_get_color_default, ns_mod_to_lisp): Remove.
2112 (ns_mouse_position): Remove unused variables xchar and ychar.
2113 (ns_compute_glyph_string_overhangs): Remove unused variable face.
2114 (ns_set_vertical_scroll_bar): Remove unused variable count.
2115 (ns_delete_terminal): Remove unused variable i.
2116 (ns_term_init): Remove unused variables r, g and b.
2117 (mouseDown): Remove unused variable window.
2118 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
2119 (initFrameFromEmacs): Remove unused variable vbextra.
2120 (mouseEntered): Remove unused variables p and dpyinfo.
2121 (mouseExited): Remove unused variables p and r.
2122 (ns_define_frame_cursor, ns_clear_frame_area)
2123 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
2124 (menuDown): Assign [sender tag] to variable and cast the variable.
2125
2126 * nsterm.h (menuDown): Add id as type to argument sender.
2127 (ns_display_info_for_name): Add Lisp_Object argument.
2128 (ns_term_init): Add Lisp_Object argument.
2129 (ns_map_event_to_object): Add void argument.
2130 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
2131 prototype with arguments and only declare if __OBJC__.
2132 (nxatoms_of_nsselect): Add void argument.
2133 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
2134 (ns_alloc_autorelease_pool): Add void argument.
2135 (ns_release_autorelease_pool): Add void* argument.
2136 (ns_get_defaults_value): Add const char* argument.
2137
2138 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
2139 (initFromContents): Use SSDATA where appropriate.
2140 (ns_update_menubar): Add braces to ambigous if-else.
2141 (initWithTitle): Put () around assignment in if statement.
2142 (ns_menu_show): Remove unused variables window and keymap.
2143 (update_frame_tool_bar): Remove unused variable selected_p.
2144 (initWithContentRect): Remove unused variable this_cmd_name.
2145
2146 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
2147 appropriate.
2148 (setXBMColor): Remove unused variable len.
2149 (setPixmapData): Put () around assignment in loop statement.
2150
2151 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
2152 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
2153 where appropriate.
2154 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
2155 around assignment in loop statement.
2156 (nsfont_open): Remove unused variable i.
2157 (nsfont_open): Remove unused variable len.
2158 (nsfont_draw): Remove unused variable cs.
2159
2160 * nsfns.m (x_set_icon_name, ns_set_name_internal)
2161 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
2162 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
2163 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
2164 (Fns_font_name, Fns_perform_service)
2165 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
2166 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
2167 (ns_set_name): Remove unused variable view.
2168 (x_set_menu_bar_lines): Remove unused variable olines.
2169 (x_set_tool_bar_lines): Remove unused variable root_window.
2170 (Fns_list_colors): Put () around assignment in while statement.
2171 (Fns_perform_service): Remove unused variable len.
2172 (Fns_display_usable_bounds): Remove unused variable top.
2173 (syms_of_nsfns): Remove unused variable i.
2174
b55b9f85
JD
2175 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
2176 memcpy (Bug#11907).
2177
ed9265fc 21782012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
2179
2180 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
2181 and free it with DestroyExceptionInfo (Bug#11558).
2182
ef099b57
JB
21832012-07-13 Juanma Barranquero <lekktu@gmail.com>
2184
2185 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
2186 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
2187 Set here, not in nt/config.nt.
2188
ea814a5d
EZ
21892012-07-13 Eli Zaretskii <eliz@gnu.org>
2190
2191 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
2192 cursor overflow into the last glyph on display line when the right
2193 fringe is off. (Bug#11832)
2194
1a952767
PE
21952012-07-13 Paul Eggert <eggert@cs.ucla.edu>
2196
2197 * xdisp.c (produce_special_glyphs): Now static.
2198 * dispextern.h (produce_special_glyphs): Remove decl.
2199
983188fd
GM
22002012-07-13 Glenn Morris <rgm@gnu.org>
2201
8d7c7eed 2202 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
2203 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
2204
983188fd
GM
2205 * s/usg5-4-common.h (USG, USG5):
2206 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
2207 * s/sol2-6.h (SOLARIS2):
2208 * s/irix6-5.h (IRIX6_5):
2209 * s/hpux10-20.h (USG, USG5, HPUX):
2210 * s/gnu-linux.h (USG, GNU_LINUX):
2211 * s/freebsd.h (BSD_SYSTEM):
2212 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
2213 * s/cygwin.h (CYGWIN):
2214 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
2215 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
2216
d1e68667 22172012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
2218
2219 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 2220
6de0e799
GM
22212012-07-13 Glenn Morris <rgm@gnu.org>
2222
739ae010
GM
2223 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
2224
dbee5793
GM
2225 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
2226
6de0e799
GM
2227 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
2228 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
2229
b82da769
GM
22302012-07-12 Glenn Morris <rgm@gnu.org>
2231
4fae5a7a 2232 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
2233
2234 * process.c (init_process_emacs): Rename from init_process.
2235 The old name is also the name of a Mach system call.
2236 * lisp.h, emacs.c: Update for this name change.
2237 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
2238 longer needed.
2239
5a979817
EZ
22402012-07-12 Eli Zaretskii <eliz@gnu.org>
2241
2242 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
2243 memmove call that removes glyphs covered by the left truncation
2244 glyph. Improve commentary.
2245 (display_line): Fix display of continuation glyphs on GUI frames
2246 when the right fringe is turned off and variable-size fonts are
2247 used in the window. Move the code that appends a stretch glyph to
2248 produce_special_glyphs, so that it could be used for truncation
2249 and continuation glyphs alike.
2250 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
2251 glyph of a suitably computed width, to align the special glyphs at
2252 the window margin. Code moved from display_line. (Bug#11832)
2253
3e91a053
GM
22542012-07-12 Glenn Morris <rgm@gnu.org>
2255
ba9e4b84
GM
2256 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
2257
2258 * s/gnu-linux.h, s/hpux10-20.h:
2259 Do not unconditionally define HAVE_XRMSETDATABASE.
2260
3e91a053
GM
2261 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
2262
b300b1f4
PE
22632012-07-12 Paul Eggert <eggert@cs.ucla.edu>
2264
2265 Fix typos that broke OS X build.
2266 Reported by Randal L. Schwartz in
2267 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
2268 * nsterm.m (ns_timeout): Add missing local decl.
2269 (ns_get_color): snprintf -> sprintf, to fix typo.
2270
6e777848
GM
22712012-07-12 Glenn Morris <rgm@gnu.org>
2272
3f922c37
GM
2273 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
2274 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
2275 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
2276 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
2277
0ab7b23a
GM
2278 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
2279 Move PTY_OPEN to configure.
2280
6e777848
GM
2281 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2282 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
2283 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
2284
4a7edc24
DA
22852012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
2286
2287 Use empty_unibyte_string where applicable.
2288 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
2289 * lread.c (read1): Likewise.
2290 * xsettings.c (syms_of_xsettings): Likewise.
2291
308aab79
GM
22922012-07-12 Glenn Morris <rgm@gnu.org>
2293
42bd1719
GM
2294 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
2295 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
2296 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
2297 * s/hpux10-20.h (RUN_TIME_REMAP):
2298 * s/bsd-common.h (TABDLY): Move to configure.
2299
2300 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
2301
2302 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
2303
ea0bbd17 2304 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 2305 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
2306
2307 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 2308
308aab79
GM
2309 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
2310 * s/template.h: Move NARROWPROTO to configure.
2311
ee1cf5cf
GM
23122012-07-11 Glenn Morris <rgm@gnu.org>
2313
30fe9bf4
GM
2314 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
2315 unused since 2011-01-17 change to systty.h.
2316
ee1cf5cf
GM
2317 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
2318 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
2319 Move HAVE_PTYS and HAVE_SOCKETS to configure.
2320
63e47e07
PE
23212012-07-11 Paul Eggert <eggert@cs.ucla.edu>
2322
2323 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
2324
c43fb4c3
GM
23252012-07-11 Glenn Morris <rgm@gnu.org>
2326
2327 * s/darwin.h, s/gnu-linux.h, s/template.h:
2328 Move INTERRUPT_INPUT to configure.
2329
e8df9267
DA
23302012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
2331
2332 Minor adjustments to interning code.
2333 * lisp.h (intern, intern_c_string): Redefine as static inline
2334 wrappers for intern_1 and intern_c_string_1, respectively.
2335 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
2336 * lread.c (intern_1, intern_c_string_1, oblookup):
2337 Simplify Vobarray checking.
e8df9267
DA
2338 * font.c (font_intern_prop): Likewise. Adjust comment.
2339 * w32font.c (intern_font_name): Likewise.
2340
34348bd4
AS
23412012-07-11 Andreas Schwab <schwab@linux-m68k.org>
2342
d96a1e0c
AS
2343 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
2344
34348bd4
AS
2345 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
2346 of Fcar/Fcdr if possible.
2347 * font.c (check_otf_features): Likewise.
2348 * fontset.c (Fnew_fontset): Likewise.
2349 * gnutls.c (Fgnutls_boot): Likewise.
2350 * minibuf.c (read_minibuf): Likewise.
2351 * msdos.c (IT_set_frame_parameters): Likewise.
2352 * xmenu.c (Fx_popup_dialog): Likewise.
2353 * w32menu.c (Fx_popup_dialog): Likewise.
2354
c8add24e
GM
23552012-07-11 Glenn Morris <rgm@gnu.org>
2356
4b575b3c
GM
2357 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
2358 since nothing has defined it on these platforms.
2359
09f4e3b0
GM
2360 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
2361 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
2362
172bedef
GM
2363 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2364 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
2365 Move CLASH_DETECTION to configure.
2366
249685df
GM
2367 * s/gnu.h: Remove file, which is now empty.
2368
c8add24e
GM
2369 * s/gnu.h, s/gnu-linux.h:
2370 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
2371
b41253a3
JW
23722012-07-11 John Wiegley <johnw@newartisans.com>
2373
2374 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
2375 function attribute, so we only use it if it exists in the
2376 compiler.
2377
d923b542
DA
23782012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
2379
2380 Avoid call to strlen in fast_c_string_match_ignore_case.
2381 * search.c (fast_c_string_match_ignore_case): Change to use
2382 length argument. Adjust users accordingly.
2383 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
2384
5ebbef1d
PE
23852012-07-11 Paul Eggert <eggert@cs.ucla.edu>
2386
bb352260
PE
2387 Assume mkdir, rmdir.
2388 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
2389 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
2390
57054ddd
PE
2391 Assume rename.
2392 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
2393
b747d3f7
PE
2394 Assume perror.
2395 * s/hpux10-20.h (HAVE_PERROR): Remove.
2396 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
2397 Remove dummy definition, as this problem was obsolete long ago.
2398
5ebbef1d
PE
2399 Assume strerror.
2400 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
2401
984e7f30
DA
24022012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
2403
2404 Avoid calls to strlen in font processing functions.
2405 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
2406 (font_open_by_name): Change to use length argument.
2407 Adjust users accordingly.
d923b542
DA
2408 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
2409 Adjust prototypes.
2410 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
2411 Change to return ptrdiff_t.
984e7f30
DA
2412 (xfont_list_pattern, xfont_match): Use length returned by
2413 xfont_decode_coding_xlfd.
2414 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
2415
20e94fdd
GM
24162012-07-11 Glenn Morris <rgm@gnu.org>
2417
9d596af3
GM
2418 * s/darwin.h, s/freebsd.h, s/netbsd.h:
2419 Move DONT_REOPEN_PTY to configure.
2420
20e94fdd
GM
2421 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
2422 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
2423
e99a530f
PE
24242012-07-10 Paul Eggert <eggert@cs.ucla.edu>
2425
22ffb973
PE
2426 Remove "#define unix" that is no longer needed (Bug#11905).
2427 * s/aix4-2.h (unix): Remove; no longer needed.
2428
e9a9ae03
PE
2429 EMACS_TIME simplification (Bug#11875).
2430 This replaces macros (which typically do not work in GDB)
2431 with functions, typedefs and enums, making the code easier to debug.
2432 The functional style also makes code easier to read and maintain.
2433 * systime.h: Include <sys/time.h> on all hosts, not just if
2434 WINDOWSNT, since 'struct timeval' is needed in general.
2435 (EMACS_TIME): Now a typedef, not a macro.
2436 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
2437 not macros.
2438 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
2439 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
2440 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
2441 (EMACS_TIME_LE): Now functions, not macros.
2442 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
2443 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
2444 which are not functions. All uses rewritten to use:
2445 (make_emacs_time): New function.
2446 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
2447 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
2448 not functions. All uses rewritten to use the following, respectively:
2449 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
2450 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 2451 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
2452 * fileio.c (Fcopy_file):
2453 * xterm.c (XTflash): Get the current time closer to when it's used.
2454 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
2455
ffacb126
PE
2456 * bytecode.c (targets): Suppress -Woverride-init warnings.
2457
e99a530f
PE
2458 Simplify by avoiding confusing use of strncpy etc.
2459 * doc.c (Fsnarf_documentation):
2460 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
2461 * frame.c (Fmake_terminal_frame):
2462 * gtkutil.c (get_utf8_string):
2463 * lread.c (openp):
2464 * nsmenu.m (ns_update_menubar):
2465 * regex.c (regerror):
2466 Prefer memcpy to strncpy and strncat when either will do.
2467 * fileio.c (Fsubstitute_in_file_name):
2468 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
2469 (menu_separator_name_p):
2470 * nsmenu.m (ns_update_menubar):
2471 Prefer memcmp to strncmp when either will do.
2472 * nsterm.m: Include <ftoastr.h>.
2473 (ns_get_color):
2474 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
2475 Prefer snprintf to strncpy.
2476 * nsterm.m (ns_term_init):
2477 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
2478 * nsterm.m (ns_term_init):
2479 Avoid the need for strncpy, by using build_string or
2480 make_unibyte_string directly. Use dtoastr, not snprintf.
2481 * process.c (Fmake_network_process): Diagnose service names that
2482 are too long, rather than silently truncating them or creating
2483 non-null-terminated names.
2484 (Fnetwork_interface_info): Likewise, for interface names.
2485 * sysdep.c (system_process_attributes) [GNU_LINUX]:
2486 Prefer sprintf to strncat.
2487 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
2488 Prefer vsnprintf to vsprintf + strncpy.
2489
c59592b3
GM
24902012-07-10 Glenn Morris <rgm@gnu.org>
2491
2492 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
2493 Clarify fallback case.
2494
7d7bbefd
DA
24952012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2496
2497 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
2498 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
2499 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 2500 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
2501 where argument type is known to be a Lisp_Cons.
2502
3a4c8000
TT
25032012-07-10 Tom Tromey <tromey@redhat.com>
2504
2505 * bytecode.c (BYTE_CODE_THREADED): New macro.
2506 (BYTE_CODES): New macro. Replaces all old byte-code defines.
2507 (enum byte_code_op): New type.
2508 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
2509 (exec_byte_code): Use them. Use token threading when applicable.
2510
2a0213a6
DA
25112012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2512
2513 Optimize pure C strings initialization.
2514 * lisp.h (make_pure_string): Fix prototype.
2515 (build_pure_c_string): New function, defined as static inline. This
2516 provides a better opportunity to optimize away calls to strlen when
2517 the function is called with compile-time constant argument.
2518 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
2519 argument, adjust users accordingly. Use build_pure_c_string where
2520 appropriate.
2521 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
2522 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
2523 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
2524
cb1caeaf
DA
25252012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2526
2527 Avoid calls to strlen in miscellaneous functions.
2528 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
2529 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
2530 * lread.c (openp): Likewise.
2531
c293e30c
DA
25322012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2533
2534 Avoid calls to strlen in path processing functions.
2535 * fileio.c (file_name_as_directory): Add comment. Change to add
2536 srclen argument and return the length of result. Adjust users
2537 accordingly.
2538 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
2539 swap 1st and 2nd arguments to obey the common convention.
2540 Adjust users accordingly.
c293e30c
DA
2541 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
2542
9e059e3f
GM
25432012-07-10 Glenn Morris <rgm@gnu.org>
2544
d02eb359
GM
2545 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
2546 Move PENDING_OUTPUT_COUNT definition to configure.
2547
882cf227
GM
2548 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
2549 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
2550 * s/gnu.h (DATA_START): Move definitions to configure.
2551
af6e839f
GM
2552 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
2553 We include usg5-4-common.h, which defines them both.
2554
40289a12
GM
2555 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
2556 O_RDONLY already includes it).
2557
9e059e3f
GM
2558 Stop ns builds setting the EMACSLOADPATH environment variable.
2559 * nsterm.m (ns_load_path): Rename from ns_init_paths.
2560 Now it does not set EMACSLOADPATH, just returns the load-path string.
2561 * nsterm.h: Update accordingly.
2562 * lread.c [HAVE_NS]: Include nsterm.h.
2563 (init_lread) [HAVE_NS]: Use ns_load_path.
2564 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
2565
7c4e8ec0
GM
25662012-07-09 Glenn Morris <rgm@gnu.org>
2567
d4f600ff
GM
2568 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
2569 since the included bsd-common.h does so.
2570
cbb31951
GM
2571 Stop ns builds setting the EMACSPATH environment variable.
2572 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
2573 (ns_init_paths): Do not set EMACSPATH.
2574 * nsterm.h (ns_exec_path): Add it.
2575 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
2576 Use ns_exec_path.
2577
7c4e8ec0
GM
2578 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
2579
26bccfae
PE
25802012-07-09 Paul Eggert <eggert@cs.ucla.edu>
2581
a0bee46f
PE
2582 * process.c (wait_reading_process_output): 'waitchannels' was unset
2583 when read_kbd || !NILP (wait_for_cell); fix this.
2584
5994c183
PE
2585 Add GCC-style 'const' attribute to functions that can use it.
2586 * character.h (char_resolve_modifier_mask):
2587 * keyboard.h (make_ctrl_char):
2588 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
2589 (init_character_once, next_almost_prime, init_fns, init_image)
2590 (flush_pending_output, init_sound):
2591 * mem-limits.h (start_of_data):
2592 * menu.h (finish_menu_items):
2593 Add ATTRIBUTE_CONST.
2594 * emacs.c (DEFINE_DUMMY_FUNCTION):
2595 Declare the dummy function with ATTRIBUTE_CONST.
2596 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
2597 Add decls with ATTRIBUTE_CONST.
2598
26bccfae
PE
2599 Minor improvements to make_formatted_string.
2600 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
2601 where int is good enough, as vsprintf returns an int.
2602 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
2603
a8290ec3
DA
26042012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2605
2606 Use make_formatted_string to avoid double length calculation.
2607 * lisp.h (make_formatted_string): New prototype.
2608 * alloc.c (make_formatted_string): New function.
2609 * buffer.c (Fgenerate_new_buffer_name): Use it.
2610 * dbus.c (syms_of_dbusbind): Likewise.
2611 * editfns.c (Fcurrent_time_zone): Likewise.
2612 * filelock.c (get_boot_time): Likewise.
2613 * frame.c (make_terminal_frame, set_term_frame_name)
2614 (x_report_frame_params): Likewise.
2615 * image.c (gs_load): Likewise.
2616 * minibuf.c (get_minibuffer): Likewise.
2617 * msdos.c (dos_set_window_size): Likewise.
2618 * process.c (make_process): Likewise.
2619 * xdisp.c (ensure_echo_area_buffers): Likewise.
2620 * xsettings.c (apply_xft_settings): Likewise.
2621
d01ba2f1
GM
26222012-07-09 Glenn Morris <rgm@gnu.org>
2623
2624 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
2625 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
2626 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
2627 * nsterm.h (ns_etc_directory): Add it.
2628 * callproc.c [HAVE_NS]: Include nsterm.h.
2629 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
2630
f1f924b6
DA
26312012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2632
2633 Move marker debugging code under MARKER_DEBUG.
2634 * marker.c (MARKER_DEBUG): Move marker debugging code under
2635 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
2636 for bootstrap with --enable-checking (~3x slowdown reported
2637 by Juanma Barranquero <lekktu@gmail.com>).
2638 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
2639
ab531b66
PE
26402012-07-08 Paul Eggert <eggert@cs.ucla.edu>
2641
2642 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
2643 See <http://bugs.gnu.org/11825#29>.
2644
c4b3bc8a
EZ
26452012-07-08 Eli Zaretskii <eliz@gnu.org>
2646
2647 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
2648 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
2649 (display_line): Add commentary about displaying truncation glyphs
2650 on GUI frames.
2651 (produce_special_glyphs): Move here from term.c.
2652
2653 * term.c (produce_special_glyphs): Move to xdisp.c.
2654
2655 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
2656 section.
c4b3bc8a 2657
b676b881
AS
26582012-07-07 Andreas Schwab <schwab@linux-m68k.org>
2659
f17c5273
AS
2660 * xdisp.c (display_line): Avoid warning about implicit declaration
2661 of FRAME_FONT.
2662
298819b9
AS
2663 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
2664
b676b881
AS
2665 * lisp.h: Remove empty conditional.
2666
6045c4fd
PE
26672012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2668
b3350bf9
PE
2669 * lread.c (load_path_check): Now static.
2670
6045c4fd
PE
2671 Fix some minor --with-ns problems found by static checking.
2672 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
2673 (x_set_font) [!HAVE_X_WINDOWS]:
2674 * image.c (xpm_load_image) [HAVE_NS]:
2675 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
2676 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
2677 Remove unused local.
2678 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
2679 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
2680 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
2681 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
2682 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
2683 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
2684 Fix pointer signedness problem.
2685 * xfaces.c (FRAME_X_FONT_TABLE):
2686 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
2687
929e7845
GM
26882012-07-07 Glenn Morris <rgm@gnu.org>
2689
2690 * lread.c (load_path_check): New function, split from init_lread.
2691 (init_lread): Reorganize. Motivation:
2692 If EMACSLOADPATH is set, check/warn about that rather than the
2693 defaults, which we are not going to use. Hence we can remove
2694 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
2695 Don't warn if site-lisp directories are missing.
2696 If not installed, start from a blank load-path, since
2697 PATH_LOADSEARCH refers to the eventual installation directories.
2698
58dd0aa4
EZ
26992012-07-07 Eli Zaretskii <eliz@gnu.org>
2700
2701 Support truncation and continuation glyphs on GUI frames, when
2702 fringes are disabled. (Bug#11832)
2703 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
2704 continuation glyphs even if on GUI frames.
2705 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
2706 or both, are absent.
2707 (start_display, move_it_in_display_line_to): Handle the case of a
2708 GUI frame without a fringe to display continuation or truncation
2709 glyphs.
2710 (insert_left_trunc_glyphs): Support GUI frames: make sure
2711 truncation glyphs overwrite enough glyphs from the current line to
2712 have sufficient space in pixels.
2713 (display_line): Support truncation and continuation glyphs on GUI
2714 frames. If some spare pixels are left on the line after inserting
2715 the truncation glyphs, fill that space with a stretch glyph of a
2716 suitably computed width.
2717
2718 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
2719 produce_glyphs, to support GUI sessions.
2720
31571fd7
PE
27212012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2722
5a16b9bc
PE
2723 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
2724
f3047c75
PE
2725 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
2726
31571fd7
PE
2727 Do not require float-time's arg to fit in time_t (Bug#11825).
2728 This works better on hosts where time_t is unsigned, and where
2729 float-time is applied to the (negative) difference between two times.
2730 * editfns.c (decode_time_components): Last arg is now double *,
2731 not int *, and means to store all the result as a double, without
2732 worrying about whether the seconds part fits in time_t.
2733 All callers changed.
2734 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
2735 All callers changed.
2736 (Ffloat_time): Do not fail merely because the specified time falls
2737 outside of time_t range.
2738
4516fbef
GM
27392012-07-07 Glenn Morris <rgm@gnu.org>
2740
2741 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
2742 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
2743 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
2744
07adc2c6
JB
27452012-07-07 Juanma Barranquero <lekktu@gmail.com>
2746
2747 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
2748 Update dependencies.
2749
2750 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
2751
fd573f31
PE
27522012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2753
fee5959d
PE
2754 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
2755 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
2756 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
2757 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
2758 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
2759 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
2760
fd573f31
PE
2761 * xfont.c (compare_font_names): Redo to omit the need for casts.
2762
ddadbc0e
AS
27632012-07-06 Andreas Schwab <schwab@linux-m68k.org>
2764
fca8d6b6
AS
2765 * xfns.c (Fx_change_window_property): Doc fix.
2766 * w32fns.c (Fx_change_window_property): Doc fix.
2767
ddadbc0e
AS
2768 * w32fns.c (Fx_window_property): Accept the same arguments as the
2769 X Windows version. Doc fix.
2770 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
2771
ed9265fc 27722012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
2773 Eli Zaretskii <eliz@gnu.org>
2774
2775 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
2776 Windows-specific code from nt/config.nt moved here.
2777 Obsolete settings removed.
2778
216ee680
PE
27792012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2780
2781 * process.c: Avoid unnecessary calls to gettime.
2782 (wait_reading_process_output): Don't get the time of day
2783 when gobbling data immediately and not waiting, as there's no need
2784 for it in that case. This removes a FIXME.
2785
bdd091e4
JD
27862012-07-06 Jan Djärv <jan.h.d@swipnet.se>
2787
2788 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
2789 is defined (Bug#11768).
2790
9d44f8ce
DA
27912012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2792
2793 Fix marker debugging code.
2794 * marker.c (byte_char_debug_check): Do not perform the check
2795 if buffer is not multibyte.
090bd7cb
JB
2796 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2797 Call byte_char_debug_check with correct arguments.
9d44f8ce 2798
90fc4786
DA
27992012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2800
2801 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
2802 * marker.c (byte_char_debug_check, count_markers):
2803 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
2804 (byte_debug_flag): Remove.
2805 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2806 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
2807
7b7ae965
DA
28082012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2809
4e57b342
DA
2810 Avoid code repetition in marker-related functions.
2811 * marker.c (attach_marker): New function.
2812 (Fset_marker, set_marker_restricted, set_marker_both)
2813 (set_marker_restricted_both): Use it.
2814 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
2815 Consistently rename charno to charpos.
2816 (marker_position): Add eassert.
2817 (marker_byte_position): Convert to eassert.
2818
28192012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2820
2821 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 2822 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 2823 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 2824
657924ff
DA
28252012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2826
2827 Introduce fast path for the widely used marker operation.
2828 * alloc.c (build_marker): New function.
2829 * lisp.h (build_marker): New prototype.
2830 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
2831 * composite.c (autocmp_chars): Likewise.
2832 * editfns.c (buildmark): Remove.
2833 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
2834 (save_restriction_save): Use build_marker.
2835 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
2836 * window.c (save_window_save): Likewise.
2837
041a49a6
DA
28382012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2839
2840 Do not use Fdelete_overlay in delete_all_overlays
2841 to avoid redundant calls to unchain_overlay.
2842 * buffer.c (drop_overlay): New function.
2843 (delete_all_overlays, Fdelete_overlay): Use it.
2844 * minibuf.c (get_minibuffer): Fix comment.
2845
7dca65a4
PE
28462012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2847
2848 Port to OpenBSD 5.1 amd64.
2849 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
2850 This is needed for OpenBSD, and should be harmless on all BSD systems.
2851 Also, include <sys/sysctl.h>, as it should be available on all
2852 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
2853 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
2854 use p_pid member, not kp_proc.pid.
2855
8eb876e2
GM
28562012-07-06 Glenn Morris <rgm@gnu.org>
2857
2858 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
2859
38182d90
PE
28602012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2861
2862 More xmalloc and related cleanup.
2863 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
2864 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
2865 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
2866 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
2867 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
2868 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
2869 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
2870 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
2871 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
2872 * xterm.c:
2873 Omit needless casts involving void * pointers and allocation.
2874 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
2875 as the former is more robust if P's type is changed.
2876 Prefer xzalloc to xmalloc + memset 0.
2877 Simplify malloc-or-realloc to realloc.
2878 Don't worry about xmalloc returning a null pointer.
2879 Prefer xstrdup to xmalloc + strcpy.
2880 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
2881 growing it.
2882 * keyboard.c (apply_modifiers_uncached): Prefer local array to
2883 alloca of a constant.
2884
6dd5a677
EZ
28852012-07-05 Eli Zaretskii <eliz@gnu.org>
2886
2887 * xdisp.c (display_line): Fix horizontal pixel coordinates when
2888 hscroll is larger than the line width. Fixes long and futile
2889 looping inside extend_face_to_end_of_line (on a TTY) producing
2890 glyphs that are not needed and thrown away.
2891
6b312f0f
DA
28922012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2893
2894 * marker.c (set_marker_restricted_both): Simplify by using
2895 clip_to_bounds.
2896
f520ef9b
PE
28972012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2898
2899 * editfns.c (region_limit): Simplify by using clip_to_bounds.
2900
383b7c95
JD
29012012-07-05 Jan Djärv <jan.h.d@swipnet.se>
2902
2903 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
2904 not defined (Bug#11768).
2905 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
2906 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
2907 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
2908 followed by gtk_box_set_homogeneous (Bug#11768).
2909 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
2910 (update_theme_scrollbar_width, xg_create_scroll_bar):
2911 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
2912 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
2913 (is_box_type): New function (Bug#11768).
2914 (xg_tool_item_stale_p): Call is_box_type.
5293d758 2915 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
2916 with default display (Bug#11768).
2917
d6e7bf45
EZ
29182012-07-05 Eli Zaretskii <eliz@gnu.org>
2919
2920 * xdisp.c (window_hscroll_limited): New function.
2921 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
2922 coordinates when window's hscroll is set to insanely large
2923 values. (Bug#11857)
2924
431391ec
JB
29252012-07-05 Juanma Barranquero <lekktu@gmail.com>
2926
2927 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
2928 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
2929
23f86fce
DA
29302012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2931
2932 Cleanup xmalloc.
2933 * lisp.h (xzalloc): New prototype. Omit needless casts.
2934 * alloc.c (xzalloc): New function. Omit needless casts.
2935 * charset.c: Omit needless casts. Convert all calls to
2936 xmalloc with following memset to xzalloc.
2937 * dispnew.c: Likewise.
2938 * fringe.c: Likewise.
2939 * image.c: Likewise.
2940 * sound.c: Likewise.
2941 * term.c: Likewise.
2942 * w32fns.c: Likewise.
2943 * w32font.c: Likewise.
2944 * w32term.c: Likewise.
2945 * xfaces.c: Likewise.
2946 * xfns.c: Likewise.
2947 * xterm.c: Likewise.
2948 * atimer.c: Omit needless casts.
2949 * buffer.c: Likewise.
2950 * callproc.c: Likewise.
2951 * ccl.c: Likewise.
2952 * coding.c: Likewise.
2953 * composite.c: Likewise.
2954 * doc.c: Likewise.
2955 * doprnt.c: Likewise.
2956 * editfns.c: Likewise.
2957 * emacs.c: Likewise.
2958 * eval.c: Likewise.
2959 * filelock.c: Likewise.
2960 * fns.c: Likewise.
2961 * gtkutil.c: Likewise.
2962 * keyboard.c: Likewise.
2963 * lisp.h: Likewise.
2964 * lread.c: Likewise.
2965 * minibuf.c: Likewise.
2966 * msdos.c: Likewise.
2967 * print.c: Likewise.
2968 * process.c: Likewise.
2969 * region-cache.c: Likewise.
2970 * search.c: Likewise.
2971 * sysdep.c: Likewise.
2972 * termcap.c: Likewise.
2973 * terminal.c: Likewise.
2974 * tparam.c: Likewise.
2975 * w16select.c: Likewise.
2976 * w32.c: Likewise.
2977 * w32reg.c: Likewise.
2978 * w32select.c: Likewise.
2979 * w32uniscribe.c: Likewise.
2980 * widget.c: Likewise.
2981 * xdisp.c: Likewise.
2982 * xmenu.c: Likewise.
2983 * xrdb.c: Likewise.
2984 * xselect.c: Likewise.
2985
0497dc44
PE
29862012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2987
2988 * fileio.c (time_error_value): Check the right error number.
2989 Problem reported by Troels Nielsen in
2990 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
2991
356e7178
PE
29922012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2993
4e71fd89
PE
2994 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
2995 This should be fixed in a better way; see Eli Zaretskii in
2996 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
2997 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
2998
f0941253
PE
2999 * fileio.c (time_error_value): Rename from special_mtime.
3000 The old name's problems were noted by Eli Zaretskii in
3001 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
3002
065c9eb4
PE
3003 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
3004 This variable's comment says Emacs needs at least one GDB-visible
3005 symbol of type enum pvec_type, to work around GDB problems.
3006 The symbol's value doesn't matter.
3007
356e7178
PE
3008 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
3009 that causes compilation to fail on pre-C99 compilers.
3010
ed9265fc 30112012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
3012
3013 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
3014 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
3015
3884d954
DA
30162012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
3017
d209e2fb 3018 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
3019 headers for buffer_defaults and buffer_local_symbols.
3020 Reported by Juanma Barranquero <lekktu@gmail.com>.
3021
ee28be33
SM
30222012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3023
3024 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
3025 * lisp.h (enum pvec_type): Use fewer bits.
3026 (PSEUDOVECTOR_SIZE_BITS): New constant.
3027 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
3028 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
3029 change in pvec_type.
3030 (PSEUDOVECTOR_TYPEP): New macro.
3031 (TYPED_PSEUDOVECTORP): Use it.
3032 * fns.c (internal_equal): Adapt code to extract pvectype.
3033 * emacs.c (gdb_pvec_type): Update type.
3034 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
3035 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
3036 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
3037 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
3038 (sweep_vectors): Use it. Use local var `total_bytes' instead of
3039 abusing vector->header.next.nbytes.
3040 (live_vector_p): Use PVEC_TYPE.
3041 (mark_object): Adapt code to extract pvectype. Use switch.
3042
c7f2cd7f
PE
30432012-07-04 Paul Eggert <eggert@cs.ucla.edu>
3044
3045 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
3046 Tighten new eassert a bit.
3047
8ce70ed2
DA
30482012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
3049
3050 Fix compilation with --enable-gcc-warnings and -O1
3051 optimization level.
3052 * doprnt.c (doprnt): Change type of tem to int, initialize
3053 to avoid compiler warning. Add eassert.
3054 * search.c (simple_search): Initialize match_byte to avoid
3055 compiler warning. Add eassert.
3056
dea7f1e5
PE
30572012-07-04 Paul Eggert <eggert@cs.ucla.edu>
3058
24a212eb
PE
3059 Avoid weird behavior with large horizontal scrolls.
3060 Without this change, for example, large hscroll values would
3061 mess up Emacs's display on Fedora 15 x86, presumably due to
3062 overflows in int calculations in the display code.
3063 Also, if buffers had long lines, Emacs would freeze.
3064 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
3065 (set_window_hscroll): New function, containing the old guts of
3066 Fset_window_hscroll. Return the clipped value.
3067 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
3068 This avoids the need to check against PTRDIFF_MAX.
3069
dea7f1e5
PE
3070 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
3071
76046526
DA
30722012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
3073
3074 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
3075
39adff0d
PE
30762012-07-04 Paul Eggert <eggert@cs.ucla.edu>
3077
63807d47
PE
3078 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
3079 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
3080 since GCC 4.4.6 issues a bogus warning for them.
3081
39adff0d
PE
3082 Fix bugs in file timestamp newness comparisons.
3083 * fileio.c (Ffile_newer_than_file_p):
3084 * lread.c (Fload): Use full timestamp resolution of files,
3085 not just the 1-second resolution, so that files that are only
3086 slightly newer still count as newer.
3087 * fileio.c (Ffile_newer_than_file_p): Don't assume file
3088 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
3089
dbeed9a6
PE
30902012-07-03 Paul Eggert <eggert@cs.ucla.edu>
3091
3092 * fileio.c: Improve handling of file time marker. (Bug#11852)
3093 (special_mtime): New function.
3094 (Finsert_file_contents, Fverify_visited_file_modtime):
3095 Use it to set special mtime values consistently.
3096
636334d6
AS
30972012-07-03 Andreas Schwab <schwab@linux-m68k.org>
3098
3099 * fileio.c (Finsert_file_contents): Properly handle st_mtime
3100 marker for non-existing file. (Bug#11852)
3101
e2017fe2
GM
31022012-07-03 Glenn Morris <rgm@gnu.org>
3103
3104 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
3105 and did not make it into globals.h).
3106
404dbd37
TT
31072012-07-03 Tom Tromey <tromey@redhat.com>
3108
3109 * window.c (Fset_window_margins, Fset_window_fringes)
3110 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
3111 * textprop.c (Fprevious_property_change): No longer static.
3112 * syntax.c (Fsyntax_table_p): No longer static.
3113 * process.c (Fget_process, Fprocess_datagram_address): No longer
3114 static.
3115 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
3116 * keyboard.c (Fcommand_execute): No longer static.
3117 Remove EXFUN.
3118 * insdel.c (Fcombine_after_change_execute): No longer static.
3119 * image.c (Finit_image_library): No longer static.
3120 * fileio.c (Fmake_symbolic_link): No longer static.
3121 * eval.c (Ffetch_bytecode): No longer static.
3122 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
3123 * doc.c (Fdocumentation_property, Fsnarf_documentation):
3124 No longer static.
404dbd37
TT
3125 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
3126 static.
3127 * dired.c (Ffile_attributes): No longer static.
3128 * composite.c (Fcomposition_get_gstring): No longer static.
3129 * callproc.c (Fgetenv_internal): No longer static.
3130
3131 * ccl.h: Remove EXFUNs.
3132 * buffer.h: Remove EXFUNs.
3133 * dispextern.h: Remove EXFUNs.
3134 * intervals.h: Remove EXFUNs.
3135 * fontset.h: Remove EXFUN.
3136 * font.h: Remove EXFUNs.
3137 * dosfns.c (system_process_attributes): Remove EXFUN.
3138 * keymap.h: Remove EXFUNs.
3139 * lisp.h: Remove EXFUNs.
3140 * w32term.h: Remove EXFUNs.
3141 * window.h: Remove EXFUNs.
3142 * xsettings.h: Remove EXFUN.
3143 * xterm.h: Remove EXFUN.
3144
8e4fd1e1
GM
31452012-07-03 Glenn Morris <rgm@gnu.org>
3146
3147 * lisp.h (Frandom): Make it visible to C.
3148 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
3149 buffer for invisible buffers. (Bug#1229)
3150
ca95b3eb
DA
31512012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
3152
3153 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
3154 values which aren't power of 2.
14ae4239
BT
3155 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
3156 Verify it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
3157 accordingly.
3158
7555c33f
SM
31592012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
3160
3161 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
3162
3163 * alloc.c (mark_object): Revert part of last patch to use `switch'.
3164
d12e8f5a
DA
31652012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
3166
3167 * alloc.c (allocate_vector_block): Remove redundant
3168 calls to mallopt if DOUG_LEA_MALLOC is defined.
3169 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
3170 avoid calls to mallopt if zero_vector is returned.
3171
296094c3
DA
31722012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
3173
3174 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
3175 is enabled, avoid dereferencing NULL current_sblock if
3176 running undumped.
3177
36429c89
DA
31782012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
3179
3180 Cleanup basic buffer management.
3181 * buffer.h (struct buffer): Change layout to use generic vector
3182 marking code. Fix some comments. Change type of 'clip_changed'
3183 to bitfield. Remove unused #ifndef old.
3184 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
3185 (GET_OVERLAYS_AT): Fix indentation.
3186 (for_each_per_buffer_object_at): New macro.
3187 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
3188 (Fbuffer_local_variables): Use it.
3189 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
3190 * alloc.c (allocate_buffer): Adjust to match new layout of
3191 struct buffer. Fix comment.
3192 (mark_overlay): New function.
3193 (mark_buffer): Use it. Use mark_vectorlike to mark normal
3194 Lisp area of struct buffer.
3195 (mark_object): Use it. Adjust marking of misc objects
3196 and related comments.
3197
3b3e4cac
PE
31982012-07-02 Paul Eggert <eggert@cs.ucla.edu>
3199
3200 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
3201 wrapper that is not needed because the wrapped code is a no-op (zero
3202 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
3203 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
3204
cf5c0175
DA
32052012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
3206
3207 * alloc.c (mark_buffer): Simplify. Remove prototype.
3208 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 3209 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
3210 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
3211 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 3212
ca26824c
GM
32132012-06-30 Glenn Morris <rgm@gnu.org>
3214
2e4c5312
GM
3215 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
3216
ca26824c
GM
3217 * epaths.in (PATH_SITELOADSEARCH): New.
3218 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
3219 This is rather than relying on --enable-locallisppath elements
3220 having "site-lisp" in their names. (Bug#10208#25, 11658)
3221
0d23c240
EZ
32222012-06-30 Eli Zaretskii <eliz@gnu.org>
3223
c9240d7a
EZ
3224 * w32proc.c (sys_select): Accept and ignore one more argument.
3225
3226 * w32.c (emacs_gnutls_pull): Call select with one more argument.
3227
0d23c240 3228 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 3229 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
3230
3231 * sysdep.c: Don't include dos.h and dosfns.h.
3232
3233 * process.c (sys_select):
3234 * msdos.c (sys_select): Accept one more argument and ignore it.
3235
3236 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
3237 adapt data types and code to that.
3238
3239 * dosfns.c:
3240 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
3241 which clashes with the gnulib function of the same name.
3242
af5a5a98
AS
32432012-06-30 Andreas Schwab <schwab@linux-m68k.org>
3244
c5e4379c
AS
3245 * font.c (font_style_to_value, font_style_symbolic)
3246 (font_prop_validate_style): Add type checks for values in
3247 font_style_table.
3248
af5a5a98
AS
3249 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
3250 argument.
3251 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
3252 uses.
3253
8d38f461
EZ
32542012-06-29 Eli Zaretskii <eliz@gnu.org>
3255
2e5a6631
EZ
3256 * xdisp.c (try_window_id): Undo last change.
3257
8d38f461
EZ
3258 * w32.c (getwd): Adjust commentary about startup_dir.
3259 (init_environment): Always call sys_access, even in non-MSVC
3260 builds. Don't chdir to the directory of the Emacs executable.
3261 This undoes code from 1997 which was justified by the need to
3262 "avoid conflicts when removing and renaming directories". But its
3263 downside was that every relative file name was being interpreted
3264 relative to the directory of the Emacs executable, which can never
3265 be TRT. In particular, it broke sys_access when called with
3266 relative file names.
3267 (sys_access): Map GetLastError to errno.
3268
2af3565e
DA
32692012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
3270
3271 * window.h (struct window): Change type of 'fringes_outside_margins'
3272 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 3273 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
3274 Adjust comment.
3275 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
3276 to ptrdiff_t.
3277
c8d3a25c 32782012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 3279
c8d3a25c
GM
3280 * gnutls.c (emacs_gnutls_handshake):
3281 Add QUIT to make the loop interruptible.
57570cd3 3282
c8d3a25c 32832012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 3284
c8d3a25c
GM
3285 * charset.c (init_charset): Make lack of etc/charsets fatal.
3286
3e984ee8
DA
32872012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
3288
3289 * editfns.c (region_limit): Fix type mismatch.
3290
ef884f23
DA
32912012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
3292
3293 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
3294 undefined. Convert from xassert to eassert.
3295 * nsmenu.m: Convert from xassert to eassert.
3296 * nsterm.m: Likewise.
3297
7d7e0027
SM
32982012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
3299
3300 * editfns.c (region_limit): Clip to narrowing (bug#11770).
3301
aa754e6a
PE
33022012-06-28 Paul Eggert <eggert@cs.ucla.edu>
3303
3304 Avoid integer overflow on scroll-left and scroll-right.
3305 * window.c (HSCROLL_MAX): New macro.
3306 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
3307 overflow when requested scroll falls outside ptrdiff_t range.
3308
80b00b08
DA
33092012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
3310
3311 * window.h (struct window): Change type of 'hscroll',
3312 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
3313 'last_modified' and 'last_overlay_modified' to EMACS_INT.
3314 Adjust users accordingly.
3315 * xdisp.c (try_cursor_movement): Replace type check with eassert.
3316 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
3317 from EMACS_INT to ptrdiff_t.
3318 (make_window): Omit redundant initialization.
3319
62b2bcf6
JB
33202012-06-28 Juanma Barranquero <lekktu@gmail.com>
3321
3322 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
3323
45942c7d
DA
33242012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
3325
3326 * window.h (struct window): Change type of 'use_time' and
3327 'sequence_number' from Lisp_Object to int.
3328 * frame.c (make_frame): Adjust users accordingly.
3329 * print.c (print_object): Likewise.
3330 * window.c (select_window, Fwindow_use_time, make_parent_window)
3331 (make_window): Likewise.
3332
e509cfa6
DA
33332012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
3334
3335 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
3336 enabled with --enable-checking=[all,glyphs] configure option.
3337 Fix GLYPH_DEBUG usage assuming that it may be undefined,
3338 adjust comments accordingly.
3339 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
3340 undefined, adjust comments accordingly.
3341 * image.c: Likewise.
3342 * scroll.c: Likewise.
3343 * w32fns.c: Likewise.
3344 * w32term.c: Likewise.
3345 * xdisp.c: Likewise.
3346 * xfaces.c: Likewise.
3347 * xfns.c: Likewise.
3348 * xterm.c: Likewise.
3349
a54e2c05
DA
33502012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
3351
3352 Generalize run-time debugging checks.
3353 * dispextern.h (XASSERTS): Remove.
3354 * fontset.c (xassert): Remove.
3355 Convert from xassert to eassert.
3356 * alloc.c: Convert from xassert to eassert.
3357 * bidi.c: Likewise.
3358 * dispnew.c: Likewise.
3359 * fns.c: Likewise.
3360 * fringe.c: Likewise.
3361 * ftfont.c: Likewise.
3362 * gtkutil.c: Likewise.
3363 * image.c: Likewise.
3364 * keyboard.c: Likewise.
3365 * menu.c: Likewise.
3366 * process.c: Likewise.
3367 * scroll.c: Likewise.
3368 * sound.c: Likewise.
3369 * term.c: Likewise.
3370 * w32console.c: Likewise.
3371 * w32fns.c: Likewise.
3372 * w32term.c: Likewise.
3373 * window.c: Likewise.
3374 * xdisp.c: Likewise.
3375 * xfaces.c: Likewise.
3376 * xfns.c: Likewise.
3377 * xselect.c: Likewise.
3378 * xterm.c: Likewise.
3379
1ec4b7b2
SM
33802012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
3381
3382 * fns.c (maybe_resize_hash_table): Output message when growing the
3383 purify-hashtable.
3384
2014308a
DA
33852012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3386
3387 * alloc.c (allocate_string_data): Remove dead code.
3388 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
3389 avoid GCC warning about unused macro.
3390
246155eb
DA
33912012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3392
3393 * alloc.c (allocate_string): Omit intervals initialization.
3394 * alloc.c (make_uninit_multibyte_string): Initialize intervals
3395 as in make_pure_string and make_pure_c_string.
3396
43184b7b
DA
33972012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3398
d209e2fb 3399 * alloc.c (allocate_string): Fix last change.
43184b7b 3400
3fe6dd74
DA
34012012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3402
d209e2fb 3403 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
3404 to memset, add explicit initialization where appropriate.
3405
1ba6038a
GM
34062012-06-27 Glenn Morris <rgm@gnu.org>
3407
3408 * lisp.mk (lisp): Remove paths.elc.
3409
c89926a5
CY
34102012-06-27 Chong Yidong <cyd@gnu.org>
3411
3412 * doc.c (Fsubstitute_command_keys): Fix punctuation.
3413
ed6b3510
JW
34142012-06-26 John Wiegley <johnw@newartisans.com>
3415
1ec4b7b2 3416 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
3417 on Mac OS X Lion: __mod_init_func and __mod_term_func.
3418
ed6b3510
JW
3419 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
3420 when building with Clang.
3421
8edd4a2b
SM
34222012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
3423
3424 * eval.c (Fapply): Allow calling it with a single argument.
3425
f6f62d1b
EZ
34262012-06-26 Eli Zaretskii <eliz@gnu.org>
3427
3428 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
3429 _stricmp and _strnicmp.
3430 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
3431
62efea5e
DA
34322012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3433
3434 * alloc.c (allocate_window): Zero out non-Lisp part of newly
3435 allocated window.
3436 (allocate_process): Likewise for new process.
8edd4a2b 3437 (allocate_terminal): Change to use offsetof.
62efea5e
DA
3438 (allocate_frame): Likewise.
3439 * frame.c (make_frame): Omit redundant initialization.
3440 * window.c (make_parent_window): Use memset.
3441 (make_window): Omit redundant initialization.
3442 * process.c (make_process): Omit redundant initialization.
3443 * terminal.c (create_terminal): Likewise.
3444
42997f4d
DA
34452012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3446
3447 * term.c (delete_tty): Remove redundant call to memset.
3448
1130ecfc
DA
34492012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3450
3451 * alloc.c: Remove build_string.
3452 * lisp.h: Define build_string as static inline. This provides
3453 a better opportunity to optimize away calls to strlen when the
3454 function is called with compile-time constant argument.
3455 * image.c (imagemagick_error): Convert to build_string.
3456 * w32proc.c (sys_spawnve): Likewise.
3457 * xterm.c (x_term_init): Likewise.
3458
cf38a720
PE
34592012-06-26 Paul Eggert <eggert@cs.ucla.edu>
3460
99027bdd
PE
3461 Use sprintf return value instead of invoking strlen on result.
3462 In the old days this wasn't portable, since some sprintf
3463 implementations returned char *. But they died out years ago and
3464 Emacs already assumes sprintf returns int.
3465 Similarly for float_to_string.
3466 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
3467 * ccl.c (ccl_driver):
3468 * character.c (string_escape_byte8):
3469 * data.c (Fnumber_to_string):
3470 * doprnt.c (doprnt):
3471 * print.c (print_object):
3472 * xdisp.c (message_dolog):
3473 * xfns.c (syms_of_xfns):
3474 Use sprintf or float_to_string result to avoid need to call strlen.
3475 * data.c (Fnumber_to_string):
3476 Use make_unibyte_string, since the string must be ASCII.
3477 * lisp.h, print.c (float_to_string): Now returns int length.
3478 * term.c (produce_glyphless_glyph):
3479 Use sprintf result rather than recomputing it.
3480
cf38a720
PE
3481 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
3482 * Makefile.in (ALL_CFLAGS):
3483 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
3484 * gmalloc.c, regex.c: Include <config.h> unconditionally.
3485
3511c784
DA
34862012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3487
0a08eb21 3488 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
3489 strcasecmp if available.
3490 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
3491
fb7da12e
AS
34922012-06-25 Andreas Schwab <schwab@linux-m68k.org>
3493
3494 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
3495 Avoid comma operator.
3496 * menu.c (push_submenu_start, push_submenu_end)
3497 (push_left_right_boundary, push_menu_pane): Likewise.
3498 * msdos.c (dos_rawgetc): Likewise.
3499
afa2ffd8
DA
35002012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3501
3502 * xfns.c (xic_create_fontsetname): Remove redundant calls
3503 to memset.
3504
b3b4476b
PE
35052012-06-25 Paul Eggert <eggert@cs.ucla.edu>
3506
4495ff38
PE
3507 * gtkutil.c (get_utf8_string): Remove redundant assignment.
3508 sprintf already null-terminates its output.
3509
b3b4476b
PE
3510 * xfns.c (x_window): Remove redundant cast.
3511
b00876c9
DA
35122012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3513
3514 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
3515 `const char *' to `char *' to avoid compiler warning.
3516
d188e26b
PE
35172012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3518
885d1d74
PE
3519 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
3520 instead of truncating it to 63 (admittedly a generous limit).
3521
d188e26b
PE
3522 * process.c: Fix spelling and caps in comments.
3523
e2f560b1
DN
35242012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
3525
e86db54b 3526 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
3527 * sysdep.c (setpgrp): Remove definition, not used in this file.
3528
7583a3a1
JB
35292012-06-24 Juanma Barranquero <lekktu@gmail.com>
3530
3531 * makefile.w32-in: Update dependencies.
3532
696056c2
EZ
35332012-06-24 Eli Zaretskii <eliz@gnu.org>
3534
3535 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
3536 (SYSTIME_H): Add nt/inc/sys/time.h.
3537
3538 * systime.h [WINDOWSNT]: Include sys/time.h.
3539
3540 * s/ms-w32.h (struct timespec): Definition moved from
3541 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
3542
845ca893
PE
35432012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3544
3545 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
3546 * buffer.h (buffer_slot_type_mismatch):
3547 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3548 * eval.c (unwind_to_catch):
3549 * image.c (my_png_error, my_error_exit):
3550 * keyboard.c (quit_throw_to_read_char, user_error)
3551 (Fexit_recursive_edit, Fabort_recursive_edit):
3552 * lisp.h (die, args_out_of_range, args_out_of_range_3)
3553 (wrong_type_argument, buffer_overflow, __executable_start)
3554 (memory_full, buffer_memory_full, string_overflow, Fthrow)
3555 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
3556 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
3557 (fatal):
3558 (child_setup) [!DOS_NT]:
3559 * lread.c (end_of_file_error, invalid_syntax):
3560 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3561 * puresize.h (pure_write_error):
3562 * search.c (matcher_overflow):
3563 * sound.c (sound_perror, alsa_sound_perror):
3564 * sysdep.c, syssignal.h (croak):
3565 * term.c (maybe_fatal, vfatal):
3566 * textprop.c (text_read_only):
3567 * undo.c (user_error):
3568 * unexmacosx.c (unexec_error):
3569 * xterm.c (x_ins_del_lines, x_delete_glyphs):
3570 Use _Noreturn rather than NO_RETURN.
3571 No need for separate decl merely because of _Noreturn.
3572 * sound.c (sound_warning, parse_sound):
3573 Remove unnecessary forward decls.
3574
f1dd8073
PE
35752012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3576
3577 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
3578 * lisp.h (WAIT_READING_MAX): New macro.
3579 * dispnew.c (Fsleep_for, sit_for):
3580 * keyboard.c (kbd_buffer_get_event):
3581 * process.c (Faccept_process_output):
3582 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
3583 This improves on the previous patch, which introduced a bug
3584 when time_t is unsigned and as wide as intmax_t.
3585 See <http://bugs.gnu.org/9000#51>.
3586
b82c1755
EZ
35872012-06-23 Eli Zaretskii <eliz@gnu.org>
3588
3589 * dispnew.c (sit_for, Fsleep_for):
3590 * keyboard.c (kbd_buffer_get_event):
3591 * process.c (Faccept_process_output): Avoid compiler warnings when
3592 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
3593
ca300656
JB
35942012-06-23 Juanma Barranquero <lekktu@gmail.com>
3595
049ec95b
JB
3596 * makefile.w32-in: Update dependencies.
3597
ca300656
JB
3598 * w32.c (ltime): Add return type and declare static.
3599 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
3600
db7b8d06
PE
36012012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3602
3603 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
3604 Privately reported by Herbert J. Skuhra.
3605 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
3606 All uses changed.
3607 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
3608 not make_lisp_timeval, when the argument is of type EMACS_TIME.
3609
0bd8297f
EZ
36102012-06-23 Eli Zaretskii <eliz@gnu.org>
3611
96512555
EZ
3612 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
3613 last argument of make_unibyte_string.
3614
0bd8297f
EZ
3615 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
3616 language ID in the event parameters.
3617
3618 * w32term.c (w32_read_socket): Put the new keyboard codepage into
3619 event.code, not the obscure "character set ID".
3620
63def6b6
CY
36212012-06-23 Chong Yidong <cyd@gnu.org>
3622
3623 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
3624
e8a02204
EZ
36252012-06-23 Eli Zaretskii <eliz@gnu.org>
3626
388cdec0
EZ
3627 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
3628 * w32.c (fdutimens): New function.
3629
3630 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
3631
3632 * s/ms-w32.h (pselect): Redirect to sys_select.
3633
3634 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
3635
e8a02204
EZ
3636 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
3637 in the logic of incrementing and decrementing the value of
3638 use_relocatable_buffers.
3639
d054f3fb
PE
36402012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3641
3642 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
3643 Privately reported by Herbert J. Skuhra.
3644 [__FreeBSD__]: Remove "*/" typo after "#include".
3645 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
3646 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
3647 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
3648 Don't assume EMACS_TIME and struct timeval are the same type.
3649
d35af63c
PE
36502012-06-22 Paul Eggert <eggert@cs.ucla.edu>
3651
3652 Support higher-resolution time stamps (Bug#9000).
3653 The time stamps are only nanosecond-resolution at the C level,
3654 since that's the best that any real-world system supports now.
3655 But they are picosecond-resolution at the Lisp level, as that's
3656 easy, and leaves room for future OS improvements.
3657
3658 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
3659 (LIBES): Use it.
3660
3661 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
3662 Don't get current time unless it's needed.
3663
3664 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
3665 now provides it if it's absent.
3666 (start_atimer): Port to higher-res time stamps.
3667 Check for time stamp overflow. Don't get current time more
3668 often than is needed.
3669
3670 * buffer.h (struct buffer): Buffer modtime now has high resolution.
3671 Include systime.h, not time.h.
3672 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
3673
3674 * dired.c: Include stat-time.h.
3675 (Ffile-attributes): File times now have higher resolution.
3676
3677 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
3678 (struct image): Timestamp now has higher resolution.
3679
3680 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
3681 has at least microseconds now. All uses removed.
3682 (update_frame, update_single_window, update_window, update_frame_1)
3683 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
927c7216 3684 (duration_to_sec_usec): Remove; no longer needed.
d35af63c
PE
3685
3686 * editfns.c (time_overflow): Now extern.
3687 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
3688 (float-time, Fformat_time_string, Fcurrent_time_string)
3689 (Fcurrent_time_zone): Accept and generate higher-resolution
3690 time stamps.
3691 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
3692 (decode_time_components, lisp_seconds_argument): New functions.
3693 (make_time): Now static.
3694 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
3695 Report an error if the time is invalid, rather than having the caller
3696 do that.
3697
3698 * fileio.c: Include <stat-time.h>
3699 (Fcopy_file): Copy higher-resolution time stamps.
3700 Prefer to set the time stamp via a file descriptor if that works.
3701 (Fset_file_times, Finsert_file_contents, Fwrite_region)
3702 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
3703 (Fvisited_file_modtime, Fset_visited_file_modtime):
3704 Support higher-resolution time stamps.
3705
3706 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
3707
3708 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
3709
3710 * image.c (prepare_image_for_display, clear_image_cache)
3711 (lookup_image): Port to higer-resolution time stamps.
3712
3713 * keyboard.c (start_polling, bind_polling_period):
3714 Check for time stamp overflow.
3715 (read_char, kbd_buffer_get_event, timer_start_idle)
3716 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
3717 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
3718 Port to higher-resolution time stamps. Do not assume time_t is signed.
3719 (decode_timer): New function. Timers are now vectors of length 9,
3720 not 8, to accommodate the picosecond component.
3721 (timer_check_2): Use it.
3722
3723 * nsterm.m (select_timeout, timeval_subtract): Remove.
3724 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
3725 as they're a bit more accurate and handle overflow better.
3726 (ns_select): Change prototype to be compatible with pselect.
3727 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
3728 * nsterm.h (ns_select): Adjust prototype.
3729
3730 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
3731 us-resolution time stamps.
3732 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
3733
3734 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
3735
3736 * lisp.h (time_overflow): New decl.
3737 (wait_reading_process_output): First arg is now intmax_t, not int,
3738 to accommodate larger waits.
3739
3740 * process.h (struct Lisp_Process.read_output_delay):
3741 Now counts nanoseconds, not microseconds.
3742 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
3743 EMACS_HAS_USECS.
3744 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
3745 (wait_reading_process_output):
3746 Port to ns-resolution time stamps.
3747 (Faccept_process_output, wait_reading_process_output):
3748 Check for time stamp overflow. Do not assume time_t is signed.
3749 (select_wrapper): Remove; we now use pselect.
3750 (Fprocess_attributes): Now generates ns-resolution time stamps.
3751
3752 * sysdep.c: Include utimens.h. Don't include utime.h
3753 or worry about struct utimbuf; gnulib does that for us now.
3754 (gettimeofday): Remove; gnulib provides a substitute.
3755 (make_timeval): New function.
3756 (set_file_times): Now sets ns-resolution time stamps.
3757 New arg FD; all uses changed.
3758 (time_from_jiffies, ltime_from_jiffies, get_up_time)
3759 (system_process_attributes):
3760 Now returns ns-resolution time stamp. All uses changed.
3761 Check for time stamp overflow.
3762
3763 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
3764 provides a substitute now.
3765
3766 * systime.h: Include timespec.h rather than sys/time.h and time.h,
3767 since it guarantees struct timespec.
3768 (EMACS_TIME): Now struct timespec, so that we can support
3769 ns-resolution time stamps.
3770 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
3771 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
3772 (EMACS_USECS): Remove.
3773 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
3774 so multiply the arg by 1000 before storing it.
3775 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
3776 New macros.
3777 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
3778 Port to ns-resolution time stamps.
3779 (EMACS_TIME_NEG_P): Remove; replaced by....
3780 (EMACS_TIME_SIGN): New macro.
3781 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
3782 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
3783 (set_file_times, make_time, lisp_time_argument): Adjust signature.
3784 (make_timeval, make_lisp_time, decode_time_components): New decls.
3785 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
3786 that it mishandled time_t overflow. You can't compare by subtracting!
3787 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
3788 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
3789
3790 * term.c: Include <sys/time.h>.
3791 (timeval_to_Time): New function, for proper overflow wraparound.
3792 (term_mouse_position, term_mouse_click): Use it.
3793
3794 * undo.c (record_first_change): Support higher-resolution time stamps
3795 in the undo buffer.
3796 (Fprimitive_undo): Use them when restoring time stamps.
3797
3798 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
3799 (w32_get_internal_run_time):
3800 Port to higher-resolution Emacs time stamps.
3801 (ltime): Now accepts single 64-bit integer, as that's more convenient
3802 for callers.
3803
3804 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
3805
3806 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
3807 for compatibility with pselect. Support ns-resolution time stamps.
3808
3809 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
3810
3811 * xselect.c (wait_for_property_change, x_get_foreign_selection):
3812 Check for time stamp overflow, and support ns-resolution time stamps.
3813
3814 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
3815 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
3816 (timeval_subtract): Remove; no longer needed.
3817 (XTflash, XTring_bell, x_wait_for_event):
3818 Port to ns-resolution time stamps. Don't assume time_t is signed.
3819
b6a92dfe
CY
38202012-06-22 Chong Yidong <cyd@gnu.org>
3821
3822 * xdisp.c (x_consider_frame_title): Revert last change.
3823
d251c37c
EZ
38242012-06-22 Eli Zaretskii <eliz@gnu.org>
3825
3826 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
3827 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
3828 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
3829 staticidx goes up to 1597 out of 1600 = 0x640.)
3830
f10deafb
PE
38312012-06-20 Paul Eggert <eggert@cs.ucla.edu>
3832
3833 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
3834 Otherwise, the umask might be mistakenly 0 while handling input signals.
3835
ec6de1e2
SM
38362012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
3837
3838 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
3839
28be1ada
DA
38402012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
3841
3842 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
3843 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
3844 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
3845 access to `contents' member of Lisp_Vector objects with AREF and ASET
3846 where appropriate.
3847
c6bf3022
CY
38482012-06-19 Chong Yidong <cyd@gnu.org>
3849
3850 * frame.c (delete_frame): When selecting a frame on a different
3851 text terminal, do not alter the terminal's top-frame.
3852
3853 * xdisp.c (format_mode_line_unwind_data): Record the target
3854 frame's selected window and its terminal's top-frame.
3855 (unwind_format_mode_line): Restore them.
3856 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
3857 Callers changed.
3858 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
3859 since tty frames can be explicitly named.
3860 (prepare_menu_bars): Likewise.
3861
3862 * term.c (Ftty_top_frame): New function.
3863
defd4196
PE
38642012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3865
3866 Port byte-code-meter to modern targets.
3867 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
3868 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 3869 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
3870 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
3871 (METER_1, METER_2): Simplify.
3872
1053a871
SM
38732012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
3874
3875 * data.c (Fdefalias): Return `symbol' (bug#11686).
3876
b7e8d081
MR
38772012-06-18 Martin Rudalics <rudalics@gmx.at>
3878
3879 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
3880 gets killed during executing of this function (Bug#11665).
3881 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
3882 (Vkill_buffer_query_functions): In doc-string say that functions
3883 run by this hook should not change the current buffer.
3884
7ea2b339
PE
38852012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3886
3887 Fix recently-introduced process.c problems found by static checking.
3888 * process.c (write_queue_push, write_queue_pop, send_process):
3889 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
3890 (write_queue_pop): Fix pointer signedness problem.
3891 (send_process): Remove unused local.
3892
96a313a1
CY
38932012-06-17 Chong Yidong <cyd@gnu.org>
3894
3895 * xdisp.c (redisplay_internal): No need to redisplay terminal
3896 frames that are not on top.
3897
20ca2e94
TN
38982012-06-17 Troels Nielsen <bn.troels@gmail.com>
3899
3900 * process.c (make_process): Initialize write_queue.
3901 (write_queue_push, write_queue_pop): New functions.
3902 (send_process): Use them to maintain correct ordering of process
3903 writes (Bug#10815).
3904
9a900ca9
PE
39052012-06-17 Paul Eggert <eggert@cs.ucla.edu>
3906
310fbfa8
PE
3907 * lisp.h (eassert): Assume C89 or later.
3908 This removes the need for CHECK.
3909 (CHECK): Remove. Its comments about always evaluating its
3910 argument were confusing, as 'eassert' typically does not evaluate
3911 its argument.
3912
27bb1ca4
PE
3913 * coding.c (produce_chars): Use ptrdiff_t, not int.
3914
9a900ca9
PE
3915 * xterm.c (x_draw_underwave): Check for integer overflow.
3916 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
3917
41b7f8bc 39182012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
3919
3920 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
3921 referenced (Bug#11583).
3922
9b0e3eba
AA
39232012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
3924
3925 Implement wave-style variant of underlining.
3926 * dispextern.h (face_underline_type): New enum.
3927 (face): Add field for underline type.
3928 * nsterm.m (ns_draw_underwave): New function.
3929 (ns_draw_text_decoration): Use it.
3930 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
3931 New functions.
3932 (x_draw_glyph_string): Use them.
3933 * xfaces.c (Qline, Qwave): New Lisp objects.
3934 (check_lface_attrs, merge_face_ref)
1053a871
SM
3935 (Finternal_set_lisp_face_attribute, realize_x_face):
3936 Handle wave-style underline face attributes.
9b0e3eba
AA
3937 * xterm.c (x_draw_underwave): New function.
3938 (x_draw_glyph_string): Use it.
3939
0fb52f11
JB
39402012-06-16 Juanma Barranquero <lekktu@gmail.com>
3941
3942 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
3943 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
3944 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
3945 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
3946 ($(BLD)/w32select.$(O)): Update dependencies.
3947
e5560ff7
AS
39482012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3949
3950 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
3951 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
3952 * character.c (_fetch_multibyte_char_p): Remove.
3953 * alloc.c: Include "character.h" before "buffer.h".
3954 * bidi.c: Likewise.
3955 * buffer.c: Likewise.
3956 * bytecode.c: Likewise.
3957 * callint.c: Likewise.
3958 * callproc.c: Likewise.
3959 * casefiddle.c: Likewise.
3960 * casetab.c: Likewise.
3961 * category.c: Likewise.
3962 * cmds.c: Likewise.
3963 * coding.c: Likewise.
3964 * composite.c: Likewise.
3965 * dired.c: Likewise.
3966 * dispnew.c: Likewise.
3967 * doc.c: Likewise.
3968 * dosfns.c: Likewise.
3969 * editfns.c: Likewise.
3970 * emacs.c: Likewise.
3971 * fileio.c: Likewise.
3972 * filelock.c: Likewise.
3973 * font.c: Likewise.
3974 * fontset.c: Likewise.
3975 * fringe.c: Likewise.
3976 * indent.c: Likewise.
3977 * insdel.c: Likewise.
3978 * intervals.c: Likewise.
3979 * keyboard.c: Likewise.
3980 * keymap.c: Likewise.
3981 * lread.c: Likewise.
3982 * macros.c: Likewise.
3983 * marker.c: Likewise.
3984 * minibuf.c: Likewise.
3985 * nsfns.m: Likewise.
3986 * nsmenu.m: Likewise.
3987 * print.c: Likewise.
3988 * process.c: Likewise.
3989 * regex.c: Likewise.
3990 * region-cache.c: Likewise.
3991 * search.c: Likewise.
3992 * syntax.c: Likewise.
3993 * term.c: Likewise.
3994 * textprop.c: Likewise.
3995 * undo.c: Likewise.
3996 * unexsol.c: Likewise.
3997 * w16select.c: Likewise.
3998 * w32fns.c: Likewise.
3999 * w32menu.c: Likewise.
4000 * window.c: Likewise.
4001 * xdisp.c: Likewise.
4002 * xfns.c: Likewise.
4003 * xmenu.c: Likewise.
4004 * xml.c: Likewise.
4005 * xselect.c: Likewise.
4006
2f07e6af
EZ
40072012-06-16 Eli Zaretskii <eliz@gnu.org>
4008
1053a871
SM
4009 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
4010 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 4011 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
4012 row.
4013 (handle_face_prop): Use chunk-relative overlay string index when
4014 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
4015 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
4016 the rightmost. (Bug#11720)
2f07e6af 4017
29b83cec
AS
40182012-06-16 Andreas Schwab <schwab@linux-m68k.org>
4019
4020 * category.h (CHAR_HAS_CATEGORY): Define as inline.
4021 (CATEGORY_MEMBER): Enforce 1/0 value.
4022 * category.c (_temp_category_set): Remove.
4023
4c5501e9
EZ
40242012-06-16 Eli Zaretskii <eliz@gnu.org>
4025
4026 * window.c (Fdelete_other_windows_internal)
4027 (Fdelete_window_internal): Don't access frame's mouse highlight
4028 info of the initial frame. (Bug#11677)
4029
2b570124
PE
40302012-06-14 Paul Eggert <eggert@cs.ucla.edu>
4031
e93864f9
PE
4032 * .gdbinit (xgetint): Fix recently-introduced paren typo.
4033 Assume USE_2_TAGS_FOR_INTS.
4034 (xreload): Adjust $tagmask width to match recent lisp.h change.
4035
2b570124
PE
4036 Simplify lisp.h in minor ways that should not affect code.
4037 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
4038 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
4039 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
4040 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
4041 (INTTYPEBITS): New macro, for clarity.
4042 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
4043 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
4044 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
4045 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
4046 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
4047
81755f69
JB
40482012-06-13 Juanma Barranquero <lekktu@gmail.com>
4049
4050 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
4051
16192a57
GM
40522012-06-13 Glenn Morris <rgm@gnu.org>
4053
4054 * s/bsd-common.h (BSD4_3):
4055 * s/usg5-4-common.h (USG5_4): No longer define; unused.
4056
646b5f55
AS
40572012-06-13 Andreas Schwab <schwab@linux-m68k.org>
4058
4059 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
4060 instead of union.
4061 (XLI, XIL): Define.
1053a871
SM
4062 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
4063 Use them.
4064 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 4065 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 4066 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
4067 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
4068 * frame.c (delete_frame): Remove outdated comment.
4069 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
4070 USE_LISP_UNION_TYPE.
4071 (Fw32_unregister_hot_key): Likewise.
4072 (Fw32_toggle_lock_key): Likewise.
4073 * w32menu.c (add_menu_item): Likewise.
4074 (w32_menu_display_help): Use XIL instead of checking
4075 USE_LISP_UNION_TYPE.
4076 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
4077 (init_heap): Likewise.
4078 * w32term.c (w32_read_socket): Update comment.
4079
1d3823c9
GM
40802012-06-13 Glenn Morris <rgm@gnu.org>
4081
c62ff706
GM
4082 * s/usg5-4-common.h, src/s/unixware.h:
4083 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
4084
1d3823c9
GM
4085 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
4086
bfe3e0a2
PE
40872012-06-13 Paul Eggert <eggert@cs.ucla.edu>
4088
4089 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
4090 * alloc.c (make_number) [!defined make_number]:
4091 Remove, as lisp.h always defines this now.
4092 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
4093 (roundup_size): Verify that it is a power of 2.
4094 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
4095 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
4096 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
4097 -DUSE_LSB_TAG=0, to override the automatically-selected default.
4098 USE_LSB_TAG now is always defined to be either 0 or 1.
4099 All uses changed.
4100 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
4101 code works fine either way, and efficiency is not a concern here,
4102 as the union type is for debugging, not for production.
4103 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
4104 Use an inline function on all platforms when using the union type,
4105 since this is simpler and 'static inline' can be used portably
4106 within Emacs now.
4107 (LISP_INITIALLY_ZERO): New macro.
4108 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
4109 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
4110
45fa9c0f
GM
41112012-06-12 Glenn Morris <rgm@gnu.org>
4112
b4492cba
GM
4113 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
4114
4115 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 4116
45fa9c0f
GM
4117 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
4118 Move BROKEN_SIGIO to configure.
4119
4120 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
4121 Move NO_TERMIO to configure.
4122
0e25d334
CY
41232012-06-12 Chong Yidong <cyd@gnu.org>
4124
4125 * image.c (imagemagick_load_image): Use MagickFlattenImage if
4126 MagickMergeImageLayers is undefined. Use pixel pusher loop if
4127 MagickExportImagePixels is undefined.
4128
43682bb6
PE
41292012-06-12 Paul Eggert <eggert@cs.ucla.edu>
4130
4131 * image.c (imagemagick_load_image): Remove unused label.
4132
a9be7d2b
GM
41332012-06-11 Glenn Morris <rgm@gnu.org>
4134
4135 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
4136 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
4137 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
4138 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
4139
3017f87f
SM
41402012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
4141
4142 * alloc.c (make_byte_code): New function.
4143 (Fmake_byte_code): Use it. Don't purify here.
4144 * lread.c (read1): Use it as well to avoid extra allocation.
4145
1b9b4cf4
CY
41462012-06-11 Chong Yidong <cyd@gnu.org>
4147
4148 * image.c (imagemagick_load_image): Implement transparency.
4149
95988fcf
AS
41502012-06-10 Andreas Schwab <schwab@linux-m68k.org>
4151
4152 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
4153 account for preceding backslashes. (Bug#11663)
4154
cd4eb164
CY
41552012-06-09 Chong Yidong <cyd@gnu.org>
4156
4157 * term.c: Support italics in capable terminals (Bug#9652).
4158 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
4159 (turn_on_face): Output using TS_enter_italic_mode if available.
4160 Don't handle unused blinking and alt-charset cases.
4161 (turn_off_face): Handle italic case; discard unused tty_blinking_p
4162 and tty_alt_charset_p cases.
4163 (tty_capable_p, init_tty): Support italics.
4164
4165 * termchar.h (struct tty_display_info): Add field for italics.
4166 Remove unused blink field.
4167
4168 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
4169 Handle slant.
4170
4171 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
4172 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
4173 tty_alt_charset_p. Add tty_italic_p.
4174
ff88beb8
MA
41752012-06-09 Michael Albinus <michael.albinus@gmx.de>
4176
4177 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
4178 dbus_type_is_basic if available.
4179 (xd_extract_signed, xd_extract_unsigned): Rename from
4180 extract_signed and extract_unsigned, respectively. Adapt callers.
4181
44286096
CY
41822012-06-09 Chong Yidong <cyd@gnu.org>
4183
1682701f
CY
4184 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
4185
44286096
CY
4186 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
4187 case (Bug#9752).
4188
d86feb17
PE
41892012-06-08 Paul Eggert <eggert@cs.ucla.edu>
4190
4191 * xdisp.c (vmessage): Treat frame message as multibyte.
4192 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
4193 would generate the diagnostic "Making \302\247 buffer-local while
4194 let-bound!".
4195
d5c20fe8
EZ
41962012-06-08 Eli Zaretskii <eliz@gnu.org>
4197
4198 * dispnew.c (showing_window_margins_p): Undo last change, which
4199 was done due to an inadvertent commit.
4200 (adjust_frame_glyphs_for_frame_redisplay): Do call
4201 showing_window_margins_p.
4202
513749ee
SM
42032012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
4204
4205 * eval.c (Fmake_var_non_special): New primitive.
4206 (syms_of_eval): Defsubr it.
4207 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
4208
d4a8f5c1
JB
42092012-06-08 Juanma Barranquero <lekktu@gmail.com>
4210
4211 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
4212 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
4213
8bbbc977
EZ
42142012-06-08 Eli Zaretskii <eliz@gnu.org>
4215
4216 * alloc.c (allocate_vectorlike): Fix last change.
4217
f3372c87
DA
42182012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
4219
4220 Block-based vector allocation of small vectors.
4221 * lisp.h (struct vectorlike_header): New field `nbytes',
4222 adjust comment accordingly.
4223 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
4224 to denote vector blocks. Adjust users (live_vector_p,
4225 mark_maybe_pointer, valid_lisp_object_p) accordingly.
4226 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
4227 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
4228 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
4229 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
4230 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
4231 (roundup_size): New constant.
4232 (struct vector_block): New data type.
4233 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 4234 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
4235 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
4236 (sweep_vectors): New functions.
4237 (allocate_vectorlike): Return `zero_vector' as the only vector of
4238 0 items. Allocate new vector from block if vector size is less than
4239 or equal to VBLOCK_BYTES_MAX.
4240 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
4241 (init_alloc_once): Add call to init_vectors.
4242
4f18a4ed
SM
42432012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
4244
4245 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
4246
86f158bc
PE
42472012-06-07 Paul Eggert <eggert@cs.ucla.edu>
4248
4249 * doprnt.c (doprnt): Truncate multibyte char correctly.
4250 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
4251 would mishandle a string argument "Xc" if X was a multibyte
4252 character of length 2: it would truncate after X's first byte
4253 rather than including all of X.
4254
c5cfcbe0
CY
42552012-06-06 Chong Yidong <cyd@gnu.org>
4256
4257 * buffer.c (word_wrap): Doc fix.
4258
c05cf390
PE
42592012-06-04 Paul Eggert <eggert@cs.ucla.edu>
4260
4261 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
4262
0c3461de
GM
42632012-06-03 Glenn Morris <rgm@gnu.org>
4264
4265 * xdisp.c (tool-bar-style): Doc fix.
4266
c71232db
UM
42672012-06-03 Ulrich Müller <ulm@gentoo.org>
4268
4269 * Makefile.in (PAXCTL): Define.
4270 (temacs$(EXEEXT)): Disable memory randomization for the temacs
4271 binary via PaX flags if the paxctl utility is available.
4272 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
4273 Restore PaX flags to their default. (Bug#11398)
4274
383f7350
CY
42752012-06-03 Chong Yidong <cyd@gnu.org>
4276
4277 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
4278 buffer (Bug#11226).
4279
5f2c76c6
CY
42802012-06-03 Chong Yidong <cyd@gnu.org>
4281
4282 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
4283 (note_mode_line_or_margin_highlight): If there is no help echo,
4284 use mode-line-default-help-echo. Handle the case where the mouse
4285 position is past the end of the mode line string.
4286
4287 * buffer.c (buffer_local_value_1): New function, split from
4288 Fbuffer_local_value; can return Qunbound.
4289 (Fbuffer_local_value): Use it.
4290 (Vmode_line_format): Docstring tweaks.
4291
773d47f6
PE
42922012-06-02 Paul Eggert <eggert@cs.ucla.edu>
4293
4294 * sysdep.c (system_process_attributes): Improve comment.
4295
f2d6a3df
SM
42962012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
4297
4298 * keyboard.c: Export real-this-command to Elisp.
4299 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
4300 and DEFVAR it. Update all users.
4301
63810350
PE
43022012-06-02 Paul Eggert <eggert@cs.ucla.edu>
4303
7bd5c1f4
PE
4304 * minibuf.c (Fassoc_string): Remove duplicate declaration.
4305
63810350
PE
4306 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
4307 Convert pctcpu and pctmem to Lisp float properly.
4308 Let the compiler fold better, as 100.0/0x8000 is exact.
4309
a2821611
AS
43102012-06-02 Andreas Schwab <schwab@linux-m68k.org>
4311
4312 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
4313 cons_block.
4314
5fceba1d
PE
43152012-06-01 Paul Eggert <eggert@cs.ucla.edu>
4316
4317 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
4318
c98ff5dd
DA
43192012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
4320
4321 For a 'struct window', replace some Lisp_Object fields to
4322 bitfields where appropriate, remove unused fields.
4323 * window.h (struct window): Remove unused 'last_mark_x' and
4324 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
4325 change it's type from Lisp_Object to bitfield.
4326 Change type of 'force_start', 'optional_new_start',
4327 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
4328 fields from Lisp_Object to bitfield. Adjust users accordingly.
4329
ca34e0be
PE
43302012-05-31 Paul Eggert <eggert@cs.ucla.edu>
4331
4332 Pacify gcc -Wdouble-precision when using Xaw.
4333 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
4334 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
4335 Use 'float' consistently, rather than 'float' in most places
4336 and 'double' in a couple of places.
4337
efc00ab1 43382012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
4339
4340 * xdisp.c (handle_stop): Detect whether we have overlay strings
4341 loaded by testing it->current.overlay_string_index to be
4342 non-negative, instead of checking whether n_overlay_strings is
4343 positive. (Bug#11587)
4344
efc00ab1 43452012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
4346
4347 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
4348
4349 * doc.c (Fsubstitute_command_keys): Doc fix.
4350
efc00ab1 43512012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
4352
4353 * search.c (search_buffer): Remove calls to
4354 r_alloc_inhibit_buffer_relocation, as it is now called by
4355 maybe_unify_char, which was the cause of relocation of buffer text
4356 in bug#11519.
4357
efc00ab1 43582012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
4359
4360 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
4361 for the duration of call to load_charset, to avoid problems with
4362 callers of maybe_unify_char that access buffer text through C
4363 pointers.
4364
4365 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
4366 decrement the inhibition flag, instead of just setting or
4367 resetting it.
4368
ba93a187
PE
43692012-05-31 Paul Eggert <eggert@cs.ucla.edu>
4370
4371 Remove obsolete '#define static' cruft.
4372 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
4373 This #undef was "temporary" in 2000; it is no longer needed
4374 now that '#define static' has gone away.
4375 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
4376 (gray_bitmap_bits): Remove; no longer needed.
4377 All uses replaced with definiens.
4378 * xterm.c: Include "bitmaps/gray.xbm".
4379
9e4bf381
PE
43802012-05-30 Paul Eggert <eggert@cs.ucla.edu>
4381
4382 Clean up __executable_start, monstartup when --enable-profiling.
4383 The following changes affect the code only when profiling.
4384 * dispnew.c (__executable_start): Rename from safe_bcopy.
4385 Define only on platforms that need it.
4386 * emacs.c: Include <sys/gmon.h> when profiling.
4387 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
4388 (__executable_start): Remove decl, since lisp.h does it now.
4389 (safe_bcopy): Remove decl; no longer has that name.
4390 (main): Coalesce #if into single bit of code, for simplicity.
4391 Cast pointers to uintptr_t, since standard libraries want integers
4392 and not pointers.
4393 * lisp.h (__executable_start): New decl.
4394
32d72c2f
GM
43952012-05-31 Glenn Morris <rgm@gnu.org>
4396
4397 * image.c (Fimagemagick_types): Doc fix.
4398
baac5bc7
JM
43992012-05-30 Jim Meyering <meyering@redhat.com>
4400
4401 * callproc.c (Fcall_process_region): Include directory component
4402 in mkstemp error message (Bug#11586).
4403
72cb32cf
PE
44042012-05-30 Paul Eggert <eggert@cs.ucla.edu>
4405
4406 * alloc.c, lisp.h (make_pure_vector): Now static.
4407
61b108cc
SM
44082012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
4409
4410 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
4411 Move to byte-run.el.
4412 (Fautoload): Do the hash-doc more carefully.
4413 * data.c (Fdefalias): Purify definition, except for keymaps.
4414 (Qdefun): Move from eval.c.
4415 * lisp.h (Qdefun): Remove.
4416 * lread.c (read1): Tiny simplification.
4417
471fe23d
TN
44182012-05-29 Troels Nielsen <bn.troels@gmail.com>
4419
934f3f58 4420 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
4421 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
4422 Bug#9642, but explicitly check that the buffer the overlay would
4423 be moved to is live and rearrange lines to make sure that errors
4424 will not put the overlay in an inconsistent state.
4425 (Fdelete_overlay): Cosmetics.
4426
85d0efd1
EZ
44272012-05-28 Eli Zaretskii <eliz@gnu.org>
4428
4429 * w32term.c (my_bring_window_to_top): New function.
4430 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
4431 could be different from the original one.
4432 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
4433 (Bug#11513)
4434
4435 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
4436 by calling BringWindowToTop.
4437
4438 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
4439 (WM_EMACS_END): Increase by one.
4440
da92a98c
PE
44412012-05-28 Paul Eggert <eggert@cs.ucla.edu>
4442
4443 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
4444 This avoids undefined behavior that might cause the eassert
4445 to not catch an out-of-range value.
4446
74d1f848
JB
44472012-05-28 Juanma Barranquero <lekktu@gmail.com>
4448
4449 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
4450 Update dependencies.
4451
9e1a06fc
EZ
44522012-05-27 Eli Zaretskii <eliz@gnu.org>
4453
4454 * bidi.c (bidi_mirror_char): Fix last change.
4455
f3dd7312
AS
44562012-05-27 Andreas Schwab <schwab@linux-m68k.org>
4457
4458 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
4459 when referring to sectname field in printf format.
4460
81899c91
PE
44612012-05-27 Paul Eggert <eggert@cs.ucla.edu>
4462
57b81a9f
PE
4463 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
4464 Only r_alloc_inhibit_buffer_relocation needed to be added;
4465 the others were already declared.
4466
81899c91
PE
4467 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
4468 before checking whether it's out of range. Put the check inside
4469 eassert. See
4470 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
4471
33017faf 44722012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
4473
4474 * callproc.c (Fcall_process): Restore a line that was accidentally
4475 commented out in the 2011-02-13 change (bug#11547).
4476
33017faf 44772012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
4478
4479 * lisp.h [REL_ALLOC]: Add prototypes for external functions
4480 defined on ralloc.c.
4481
4482 * buffer.c [REL_ALLOC]: Remove prototypes of
4483 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
4484 they are now on lisp.h.
4485
4486 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
4487
4488 * search.c (search_buffer): Use it to inhibit relocation of buffer
4489 text while re_search_2 is doing its job, because re_search_2 is
4490 passed C pointers to buffer text. (Bug#11519)
4491
23415acf
EZ
4492 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
4493 Update value to 24.
4494
44e27368
EZ
4495 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
4496 state after an additional call to move_it_in_display_line_to, keep
4497 the values of it->max_ascent and it->max_descent found for the
4498 entire line.
4499 (pos_visible_p): Revert the comparison against bottom_y to what it
4500 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
4501 (Bug#11464)
4502
c1892f11
PE
45032012-05-26 Paul Eggert <eggert@cs.ucla.edu>
4504
4505 Fix coding-related core dumps with gcc -ftrapv.
4506 The code was computing A - B, where A and B are pointers, and B is
4507 random garbage. This can lead to core dumps on platforms that
4508 have special pointer registers, and it also leads to core dumps on
4509 x86-64 when compiled with gcc -ftrapv. The fix is to compute
4510 A - B only when B is initialized properly.
4511 * coding.c (coding_set_source, coding_set_destination): Return void.
4512 (coding_change_source, coding_change_destinations): New functions,
4513 with the old behaviors of coding_set_source and coding_set_destination.
4514 All callers that need an offset changed to use these new functions.
4515
eb7afdad
GM
45162012-05-26 Glenn Morris <rgm@gnu.org>
4517
4518 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
4519
f12fdf02
EZ
45202012-05-26 Eli Zaretskii <eliz@gnu.org>
4521
53a63be6 4522 Extend mouse support on W32 text-mode console.
61b108cc
SM
4523 * xdisp.c (draw_row_with_mouse_face):
4524 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 4525
eb3f6f01 4526 * w32console.c: Include window.h.
61b108cc
SM
4527 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
4528 New functions.
eb3f6f01
EZ
4529 (initialize_w32_display): Initialize mouse-highlight data.
4530
53a63be6
EZ
4531 * w32inevt.c: Include termchar.h and window.h.
4532 (do_mouse_event): Support mouse-autoselect-window. When the mouse
4533 moves, call note_mouse_highlight. If help_echo changed, call
4534 gen_help_event to produce help-echo message in the echo area.
4535 Call clear_mouse_face if mouse_face_hidden is set in the mouse
4536 highlight info.
4537
4cfd81f6
PE
45382012-05-26 Paul Eggert <eggert@cs.ucla.edu>
4539
4540 * lread.c (read1): Simplify slightly to avoid an overflow warning
4541 with GCC 4.7.0 on x86-64.
4542
4446092a
EZ
45432012-05-26 Eli Zaretskii <eliz@gnu.org>
4544
4545 * bidi.c (bidi_mirror_char): Revert last change: an int is
4546 definitely wide enough here.
4547
42b2a986 45482012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 4549
42b2a986 4550 Fix integer width and related bugs (Bug#9874).
eb106a49 4551 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
4552 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
4553 (string_bytes, check_sblock, allocate_string_data):
4554 (compact_small_strings, Fmake_bool_vector, make_string)
4555 (make_unibyte_string, make_multibyte_string)
4556 (make_string_from_bytes, make_specified_string)
4557 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
4558 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
4559 (mark_vectorlike):
4560 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4561 (allocate_pseudovector):
4562 Use int, not EMACS_INT, where int is wide enough.
4563 (inhibit_garbage_collection, Fgarbage_collect):
4564 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4565 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
4566 int might not be wide enough.
4567 (bidi_cache_search, bidi_cache_find, bidi_init_it)
4568 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
4569 (bidi_at_paragraph_end, bidi_find_paragraph_start)
4570 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4571 (bidi_level_of_next_char, bidi_move_to_visually_next):
4572 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4573 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
4574 (Fkill_buffer, Fset_buffer_major_mode)
4575 (advance_to_char_boundary, Fbuffer_swap_text)
4576 (Fset_buffer_multibyte, overlays_at, overlays_in)
4577 (overlay_touches_p, struct sortvec, record_overlay_string)
4578 (overlay_strings, recenter_overlay_lists)
4579 (adjust_overlays_for_insert, adjust_overlays_for_delete)
4580 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
4581 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
4582 (Foverlay_recenter, last_overlay_modification_hooks_used)
4583 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
4584 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
4585 (validate_region): Omit unnecessary test for b <= e,
4586 since that's guaranteed by the previous test.
d311d28c
PE
4587 (adjust_overlays_for_delete): Avoid pos + length overflow.
4588 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
4589 (report_overlay_modification):
4590 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4591 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
4592 Omit pointer cast, which isn't needed anyway, and doesn't work
4593 after the EMACS_INT -> ptrdiff_t change.
02481186 4594 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
4595 * buffer.h: Adjust decls to match defn changes elsewhere.
4596 (struct buffer_text, struct buffer):
4597 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4598 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
4599 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
4600 not int, to avoid needless 32-bit limit on 64-bit hosts.
4601 (exec_byte_code): Use tighter memory-full test, one that checks
4602 for alloca overflow. Don't compute the address of the object just
4603 before an array, as that's not portable. Use EMACS_INT, not
4604 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
4605 * callint.c (Fcall_interactively):
4606 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4607 * callproc.c (call_process_kill, Fcall_process):
4608 Don't assume pid_t fits into an Emacs fixnum.
4609 (call_process_cleanup, Fcall_process, child_setup):
4610 Don't assume pid_t fits into int.
4611 (call_process_cleanup, Fcall_process, delete_temp_file)
4612 (Fcall_process_region):
4613 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4614 (Fcall_process): Simplify handling of volatile integers.
4615 Use int, not EMACS_INT, where int will do.
4616 * casefiddle.c (casify_object, casify_region, operate_on_word)
4617 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
4618 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4619 (casify_object): Avoid integer overflow when overallocating buffer.
4620 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 4621 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
4622 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
4623 * category.h (CATEGORYP): Don't assume arg is nonnegative.
4624 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
4625 integers are now checked earlier. All uses replaced with XINT.
4626 (ccl_driver):
4627 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4628 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
4629 (ccl_driver, Fregister_code_conversion_map):
4630 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
4631 (resolve_symbol_ccl_program): Check that vector header is in range.
4632 Always copy the vector, so that we can check its contents reliably
4633 now rather than having to recheck each instruction as it's being
4634 executed. Check that vector words fit in 'int'.
4635 (ccl_get_compiled_code, Fregister_ccl_program)
4636 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
4637 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
4638 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
4639 contents are in range.
4640 (Fccl_execute_on_string): Check that status is in range.
4641 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
4642 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
4643 Accept and return EMACS_INT, not int, because callers can pass values
4644 out of 'int' range.
4645 (c_string_width, strwidth, lisp_string_width, chars_in_text)
4646 (multibyte_chars_in_text, parse_str_as_multibyte)
4647 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
4648 (str_as_unibyte, str_to_unibyte, string_count_byte8)
4649 (string_escape_byte8, Fget_byte):
4650 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 4651 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
4652 avoid mishandling large integers.
4653 * character.h: Adjust decls to match defn changes elsewhere.
4654 * charset.c (load_charset_map_from_file, find_charsets_in_text)
4655 (Ffind_charset_region):
4656 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4657 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
4658 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 4659 Don't assume fixnum fits in int.
d311d28c
PE
4660 (load_charset_map_from_vector, Fmap_charset_chars):
4661 Remove now-unnecessary CHECK_NATNUMs.
4662 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
4663 Don't rely on undefined behavior with signed left shift overflow.
4664 Don't assume unsigned int fits into fixnum, or that fixnum fits
4665 into unsigned int. Don't require max_code to be a valid fixnum;
4666 that's not true for gb10830 4-byte on a 32-bit host. Allow
4667 invalid_code to be a cons, for the same reason. Require code_offset
4668 to be a character. Avoid int overflow if max_char is close
4669 to INT_MAX.
4670 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
4671 this is intended anyway and avoids some undefined behavior.
4672 (load_charset_map): Pass unsigned, not int, as 2nd arg of
4673 INDEX_TO_CODE_POINT, as that's what it expects.
4674 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
4675 * charset.h (DECODE_CHAR): Return int, not unsigned;
4676 this is what was intended anyway, and it avoids undefined behavior.
4677 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
4678 integer-overflow issues.
4679 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
4680 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
4681 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
4682 * chartab.c (Fmake_char_table, Fset_char_table_range)
4683 (uniprop_get_decoder, uniprop_get_encoder):
4684 Don't assume fixnum fits in int.
4685 * cmds.c (move_point): New function, that does the gist of
4686 Fforward_char and Fbackward_char, but does so while checking
4687 for integer overflow more accurately.
c96e5d6a 4688 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
4689 (Fforward_line, Fend_of_line, internal_self_insert)
4690 (internal_self_insert):
4691 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4692 Fix a FIXME, by checking for integer overflow when calculating
4693 target_clm and actual_clm.
4694 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 4695 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
4696 (ASSURE_DESTINATION, coding_alloc_by_realloc)
4697 (coding_alloc_by_making_gap, alloc_destination)
4698 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
4699 (encode_coding_utf_16, detect_coding_emacs_mule)
4700 (decode_coding_emacs_mule, encode_coding_emacs_mule)
4701 (detect_coding_iso_2022, decode_coding_iso_2022)
4702 (encode_invocation_designation, encode_designation_at_bol)
4703 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4704 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
4705 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
4706 (encode_coding_ccl, encode_coding_raw_text)
4707 (detect_coding_charset, decode_coding_charset)
4708 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
4709 (produce_composition, produce_charset, produce_annotation)
4710 (decode_coding, handle_composition_annotation)
4711 (handle_charset_annotation, consume_chars, decode_coding_gap)
4712 (decode_coding_object, encode_coding_object, detect_coding_system)
4713 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
4714 (code_convert_region, code_convert_string)
8f50130c
PE
4715 (Fdefine_coding_system_internal)
4716 (coding_set_source, coding_set_destination):
d311d28c
PE
4717 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4718 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
4719 (Fdefine_coding_system_internal):
4720 Don't assume fixnums fit in int.
4721 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 4722 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
4723 (Funencodable_char_position, Fcheck_coding_systems_region)
4724 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 4725 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 4726 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 4727 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 4728 Don't access memory outside of the args array.
d311d28c 4729 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
4730 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
4731 result of ENCODE_CHAR.
d311d28c
PE
4732 * coding.h: Adjust decls to match defn changes elsewhere.
4733 (struct coding_system):
4734 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4735 * composite.c (get_composition_id, find_composition)
4736 (run_composition_function, update_compositions)
4737 (compose_text, composition_gstring_put_cache)
4738 (composition_gstring_p, composition_gstring_width)
4739 (fill_gstring_header, fill_gstring_body, autocmp_chars)
4740 (composition_compute_stop_pos, composition_reseat_it)
4741 (composition_update_it, struct position_record)
4742 (find_automatic_composition, composition_adjust_point)
4743 (Fcomposition_get_gstring, Ffind_composition_internal):
4744 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4745 (update_compositions):
4746 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4747 * composite.h: Adjust decls to match defn changes elsewhere.
4748 (struct composition):
4749 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4750 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4751 Do not attempt to compute the address of the object just before a
4752 buffer; this is not portable.
4753 (Faref, Faset):
4754 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4755 (Faset): Use int, not EMACS_INT, where int is wide enough.
4756 (Fstring_to_number): Don't assume fixnums fit in int.
4757 (Frem): Don't assume arg is nonnegative.
4758 * dbusbind.c (xd_append_arg): Check for integers out of range.
4759 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 4760 (extract_signed, extract_unsigned): New functions.
243e0530
PE
4761 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
4762 (xd_get_connection_references): Return ptrdiff_t, not int.
4763 All uses changed.
4764 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
4765 (xd_read_message_1):
4766 Use int, not unsigned, where the dbus API uses int.
4767 (Fdbus_message_internal): Don't overflow mtype.
4768 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
4769 * dired.c (directory_files_internal, file_name_completion, scmp)
4770 (file_name_completion_stat):
4771 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4772 (file_name_completion): Don't overflow matchcount.
4773 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
4774 * dispextern.h: Adjust decls to match defn changes elsewhere.
4775 (struct text_pos, struct glyph, struct bidi_saved_info)
4776 (struct bidi_string_data, struct bidi_it, struct composition_it)
4777 (struct it):
4778 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4779 (struct display_pos, struct composition_it, struct it):
4780 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4781 * dispnew.c (increment_matrix_positions)
4782 (increment_row_positions, mode_line_string)
4783 (marginal_area_string):
4784 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 4785 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
4786 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4787 (duration_to_sec_usec): New function, to check for overflow better.
4788 (Fsleep_for, sit_for): Use it.
4789 * doc.c (get_doc_string, store_function_docstring):
4790 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4791 (get_doc_string, Fsnarf_documentation):
4792 Use int, not EMACS_INT, where int is wide enough.
4793 (get_doc_string):
4794 Use SAFE_ALLOCA, not alloca.
4795 Check for overflow when converting EMACS_INT to off_t.
4796 * doprnt.c (doprnt):
4797 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4798 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
4799 Don't assume uid_t fits into fixnum.
4800 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
4801 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
4802 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
4803 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
4804 (general_insert_function)
4805 (Finsert_char, make_buffer_string, make_buffer_string_both)
4806 (update_buffer_properties, Fbuffer_substring)
4807 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
4808 (Fsubst_char_in_region, check_translation)
4809 (Ftranslate_region_internal, save_restriction_restore, Fformat)
4810 (transpose_markers, Ftranspose_regions):
4811 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4812 (clip_to_bounds): Move to lisp.h as an inline function).
4813 (Fconstrain_to_field): Don't assume integers are nonnegative.
4814 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
4815 (Fsubst_char_in_region, Fsave_restriction):
4816 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4817 (Femacs_pid): Don't assume pid_t fits into fixnum.
4818 (lo_time): Use int, not EMACS_INT, when int suffices.
4819 (lisp_time_argument): Check for usec out of range.
4820 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
4821 (Fuser_login_name, Fuser_full_name): Signal an error
4822 if a uid argument is out of range, rather than relying on
4823 undefined behavior.
c8d5c857
PE
4824 (Fformat_time_string): Remove now-unnecessary check.
4825 lisp_time_argument checks for out-of-range usec now.
243e0530 4826 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
4827 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
4828 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
4829 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
4830 (init_cmdargs, Fdump_emacs):
4831 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4832 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
4833 the bottom (typically) 32 bits of the fixnum.
4834 * eval.c (specpdl_size, call_debugger):
4835 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4836 (when_entered_debugger, Fbacktrace_debug):
4837 Don't assume fixnum can fit in int.
4838 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
4839 the object just before a buffer; this is not portable.
4840 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
4841 (grow_specpdl, unbind_to):
4842 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4843 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
4844 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 4845 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
4846 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
4847 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
4848 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4849 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
4850 (a_write, e_write):
4851 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4852 (Fcopy_file, non_regular_nbytes, read_non_regular)
4853 (Finsert_file_contents):
4854 Use int, not EMACS_INT, where int is wide enough.
4855 (READ_BUF_SIZE): Verify that it fits in int.
4856 (Finsert_file_contents): Check that counts are in proper range,
4857 rather than assuming fixnums fit into ptrdiff_t etc.
4858 Don't assume fixnums fit into int.
125b3835 4859 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
4860 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
4861 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
4862 (string_char_to_byte, string_byte_to_char)
4863 (string_make_multibyte, string_to_multibyte)
4864 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
4865 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
4866 (substring_both, Fdelete, internal_equal, Ffillarray)
4867 (Fclear_string, mapcar1)
4868 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
4869 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
4870 (larger_vector, make_hash_table, maybe_resize_hash_table)
4871 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
4872 (Fmaphash, secure_hash):
4873 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4874 (concat): Check for string index and length overflow.
4875 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
4876 (Frequire):
4877 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4878 (larger_vector): New API (vec, incr_min, size_max) replaces old
4879 one (vec, new_size, init). This catches size overflow.
4880 INIT was removed because it was always Qnil.
4881 All callers changed.
4882 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
4883 the upper bound on a hash table index size.
4884 (make_hash_table, maybe_resize_hash_table): Use it.
4885 (secure_hash): Computer start_byte and end_byte only after
4886 they're known to be in ptrdiff_t range.
4887 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
4888 (Ffont_get_glyphs, Ffont_at):
4889 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4890 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
4891 (Flist_fonts, Fopen_font):
4892 Don't assume fixnum can fit in int.
4893 (check_gstring): Don't assume index can fit in int.
4894 (font_match_p): Check that fixnum is a character, not a nonnegative
4895 fixnum, since the later code needs to stuff it into an int.
4896 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
4897 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
4898 conversion overflow issues.
4899 (Fopen_font): Check for integer out of range.
4900 (Ffont_get_glyphs): Don't assume index can fit in int.
4901 * font.h: Adjust decls to match defn changes elsewhere.
4902 * fontset.c (reorder_font_vector): Redo score calculation to avoid
4903 integer overflow.
4904 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
4905 printmax_t, where ptrdiff_t is wide enough.
4906 (Finternal_char_font):
4907 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4908 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
4909 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
4910 (Fset_frame_position, x_set_frame_parameters)
4911 (x_set_line_spacing, x_set_border_width)
4912 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
4913 Check that fixnums are in proper range for system types.
4914 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
4915 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4916 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
4917 Use SAFE_ALLOCA_LISP, not alloca.
4918 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
4919 intptr_t is wide enough.
4920 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
4921 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
4922 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
4923 Check for fixnum out of range.
4924 * ftfont.c (ftfont_list): Don't assume index fits in int.
4925 Check that fixnums are in proper range for system types.
4926 (ftfont_shape_by_flt):
4927 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
4928 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4929 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4930 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
4931 Check that fixnums are in proper range for system types.
4932 * gnutls.h: Adjust decls to match defn changes elsewhere.
4933 * gtkutil.c (xg_dialog_run):
4934 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4935 (update_frame_tool_bar):
4936 Check that fixnums are in proper range for system types.
4937 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 4938 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
4939 * indent.c (last_known_column, last_known_column_point):
4940 (current_column_bol_cache):
4941 (skip_invisible, current_column, check_display_width):
4942 (check_display_width, scan_for_column, current_column_1)
4943 (Findent_to, Fcurrent_indentation, position_indentation)
4944 (indented_beyond_p, Fmove_to_column, compute_motion):
4945 (Fcompute_motion, Fvertical_motion):
4946 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4947 (last_known_column_modified): Use EMACS_INT, not int.
4948 (check_display_width):
4949 (Fcompute_motion):
4950 Check that fixnums and floats are in proper range for system types.
4951 (compute_motion): Don't assume index or fixnum fits in int.
4952 (compute_motion, Fcompute_motion):
4953 Use int, not EMACS_INT, when it is wide enough.
4954 (vmotion): Omit local var start_hpos that is always 0; that way
4955 we don't need to worry about overflow in expressions involving it.
4956 * indent.h: Adjust decls to match defn changes elsewhere.
4957 (struct position):
4958 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4959 Use int, not EMACS_INT, where int is wide enough.
4960 Remove unused members ovstring_chars_done and tab_offset;
4961 all uses removed.
4962 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
4963 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
4964 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
4965 (make_gap, copy_text, insert, insert_and_inherit)
4966 (insert_before_markers, insert_before_markers_and_inherit)
4967 (insert_1, count_combining_before, count_combining_after)
4968 (insert_1_both, insert_from_string)
4969 (insert_from_string_before_markers, insert_from_string_1)
4970 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
4971 (adjust_after_replace, adjust_after_insert, replace_range)
4972 (replace_range_2, del_range, del_range_1, del_range_byte)
4973 (del_range_both, del_range_2, modify_region)
4974 (prepare_to_modify_buffer, signal_before_change)
4975 (signal_after_change, Fcombine_after_change_execute):
4976 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4977 * intervals.c (traverse_intervals, rotate_right, rotate_left)
4978 (balance_an_interval, split_interval_right, split_interval_left)
4979 (find_interval, next_interval, update_interval)
4980 (adjust_intervals_for_insertion, delete_node, delete_interval)
4981 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4982 (static_offset_intervals, offset_intervals)
4983 (merge_interval_right, merge_interval_left, make_new_interval)
4984 (graft_intervals_into_buffer, temp_set_point_both)
4985 (temp_set_point, set_point, adjust_for_invis_intang)
4986 (set_point_both, move_if_not_intangible, get_property_and_range)
4987 (get_local_map, copy_intervals, copy_intervals_to_string)
4988 (compare_string_intervals, set_intervals_multibyte_1):
4989 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4990 * intervals.h: Adjust decls to match defn changes elsewhere.
4991 (struct interval):
4992 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4993 * keyboard.c (this_command_key_count, this_single_command_key_start)
4994 (before_command_key_count, before_command_echo_length, echo_now)
4995 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
4996 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
4997 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
4998 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
4999 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5000 (last_non_minibuf_size, last_point_position, echo_truncate)
5001 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
5002 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
5003 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
5004 (stuff_buffered_input):
5005 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5006 (last_auto_save, command_loop_1, read_char):
5007 Use EMACS_INT, not int, to avoid integer overflow.
5008 (record_char): Avoid overflow in total_keys computation.
5009 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
5010 * keyboard.h: Adjust decls to match defn changes elsewhere.
5011 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
5012 (Fkey_description, Fdescribe_vector, Flookup_key):
5013 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5014 (click_position): New function, to check that positions are in range.
5015 (Fcurrent_active_maps):
5016 (describe_command):
5017 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5018 (Faccessible_keymaps, Fkey_description):
5019 (preferred_sequence_p):
5020 Don't assume fixnum can fit into int.
5021 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
5022 Check for integer overflow in size calculations.
5023 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
5024 avoid mishandling large integers.
5025 * lisp.h: Adjust decls to match defn changes elsewhere.
5026 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
5027 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
5028 (struct Lisp_Marker):
5029 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5030 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
5031 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
5032 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
5033 All callers changed.
5034 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
5035 Assume the arg has valid form, since it always does.
5036 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
5037 unsigned integer system type.
5038 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
5039 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
5040 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5041 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
5042 (duration_to_sec_usec): New decl.
5043 * lread.c (read_from_string_index, read_from_string_index_byte)
5044 (read_from_string_limit, readchar, unreadchar, openp)
5045 (read_internal_start, read1, oblookup):
5046 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5047 (Fload, readevalloop, Feval_buffer, Feval_region):
5048 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5049 (openp): Check for out-of-range argument to 'access'.
5050 (read1): Use int, not EMACS_INT, where int is wide enough.
5051 Don't assume fixnum fits into int.
6efdadfd 5052 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
5053 (read_filtered_event): Use duration_to_sec_usec
5054 to do proper overflow checking on durations.
d311d28c
PE
5055 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
5056 in size calculation.
5057 (Fexecute_kbd_macro):
5058 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5059 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
5060 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
5061 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
5062 (set_marker_both, set_marker_restricted_both, marker_position)
5063 (marker_byte_position, Fbuffer_has_markers_at):
5064 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5065 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 5066 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
5067 It now merely ensures that the menu is large enough, without
5068 necessarily growing it, as this avoids some integer overflow issues.
5069 All callers changed.
5070 (keymap_panes, parse_single_submenu, Fx_popup_menu):
5071 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5072 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
5073 Use SAFE_ALLOCA_LISP, not alloca.
5074 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
5075 to EMACS_INT. Check that fixnums are in proper range for system types.
5076 * minibuf.c (minibuf_prompt_width, string_to_object)
5077 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
5078 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
5079 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5080 (get_minibuffer, read_minibuf_unwind):
5081 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5082 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
5083 this simplifies overflow checking. All callers changed.
5084 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
5085 (Ftest_completion):
5086 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5087 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
5088 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
5089 Check that fixnums are in proper range for system types.
5090 (Fx_create_frame, Fx_show_tip):
5091 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5092 * nsfont.m (ns_findfonts, nsfont_list_family):
5093 Don't assume fixnum fits in long.
5094 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
5095 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5096 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
5097 wide enough.
17fdb222 5098 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
5099 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5100 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
5101 (PRINTDECLARE, PRINTPREPARE):
5102 (strout, print_string):
5103 (print, print_preprocess, print_check_string_charset_prop)
5104 (print_object):
5105 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5106 (PRINTDECLARE):
5107 (temp_output_buffer_setup, Fprin1_to_string, print_object):
5108 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5109 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 5110 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 5111 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
5112 (print_error_message): Use SAFE_ALLOCA, not alloca.
5113 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
5114 (print_depth, new_backquote_output, print_number_index):
5115 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
5116 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
5117 (Fset_process_window_size, Fformat_network_address)
5118 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 5119 (sigchld_handler):
d311d28c 5120 Check that fixnums are in proper range for system types.
d44287d4 5121 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
5122 Check for process-ids out of pid_t range rather than relying on
5123 undefined behavior.
e4d81efc 5124 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
5125 (Fformat_network_address, read_process_output, send_process)
5126 (Fprocess_send_region, status_notify):
5127 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5128 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
5129 (wait_reading_process_output, read_process_output, exec_sentinel):
5130 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5131 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
5132 (Faccept_process_output): Use duration_to_sec_usec to do proper
5133 overflow checking on durations.
dde14581
PE
5134 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
5135 Don't assume pid_t fits in int.
02481186
PE
5136 * process.h (struct Lisp_Process): Members tick and update_tick
5137 are now of type EMACS_INT, not int.
b62b53e8
PE
5138 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
5139 configured --with-wide-int.
d311d28c
PE
5140 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
5141 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
5142 * search.c (looking_at_1, string_match_1):
5143 (fast_string_match, fast_c_string_match_ignore_case)
5144 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
5145 (scan_newline, find_before_next_newline, search_command)
5146 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
5147 (set_search_regs, wordify):
5148 (Freplace_match):
5149 (Fmatch_data):
5150 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5151 (string_match_1, search_buffer, set_search_regs):
5152 (Fmatch_data):
5153 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5154 (wordify): Check for overflow in size calculation.
5155 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
5156 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
5157 Check that fixnums are in proper range for system types.
5158 * sound.c (struct sound_device)
5159 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
5160 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5161 (Fplay_sound_internal):
5162 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 5163 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
5164 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
5165 (Fparse_partial_sexp):
5166 Don't assume fixnums can fit in int.
5167 (struct lisp_parse_state, find_start_pos, find_start_value)
5168 (find_start_value_byte, find_start_begv)
5169 (update_syntax_table, char_quoted, dec_bytepos)
5170 (find_defun_start, prev_char_comend_first, back_comment):
5171 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
5172 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
5173 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5174 (Finternal_describe_syntax_value): Check that match_lisp is a
5175 character, not an integer, since the code stuffs it into int.
5176 (scan_words, scan_sexps_forward):
5177 Check that fixnums are in proper range for system types.
5178 (Fforward_word):
5179 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5180 (scan_sexps_forward):
5181 Use CHARACTERP, not INTEGERP, since the value must fit into int.
5182 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
5183 * syntax.h: Adjust decls to match defn changes elsewhere.
5184 (struct gl_state_s):
5185 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
5186 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
5187 MOST_POSITIVE_FIXNUM.
d311d28c
PE
5188 * sysdep.c (wait_for_termination_1, wait_for_termination)
5189 (interruptible_wait_for_termination, mkdir):
5190 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
5191 (emacs_read, emacs_write):
5192 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
5193 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
5194 and double all fit in int.
d311d28c
PE
5195 * term.c (set_tty_color_mode):
5196 Check that fixnums are in proper range for system types.
5197 * termhooks.h (struct input_event):
5198 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5199 * textprop.c (validate_interval_range, interval_of)
5200 (Fadd_text_properties, set_text_properties_1)
5201 (Fremove_text_properties, Fremove_list_of_text_properties)
5202 (Ftext_property_any, Ftext_property_not_all)
5203 (copy_text_properties, text_property_list, extend_property_ranges)
5204 (verify_interval_modification):
5205 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5206 (Fnext_single_char_property_change)
5207 (Fprevious_single_char_property_change):
5208 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
5209 (copy_text_properties):
5210 Check for integer overflow in index calculation.
d311d28c
PE
5211 * undo.c (last_boundary_position, record_point, record_insert)
5212 (record_delete, record_marker_adjustment, record_change)
5213 (record_property_change):
5214 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5215 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
5216 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5217 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
5218 (Fx_hide_tip, Fx_file_dialog):
5219 * w32menu.c (set_frame_menubar):
5220 Use ptrdiff_t, not int, for consistency with rest of code.
5221 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
5222 (select_window, Fdelete_other_windows_internal)
5223 (window_scroll_pixel_based, window_scroll_line_based)
5224 (Frecenter, Fset_window_configuration):
5225 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5226 (Fset_window_hscroll, run_window_configuration_change_hook)
5227 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 5228 (Fscroll_other_window, Frecenter):
d311d28c
PE
5229 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5230 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
5231 Don't assume fixnum fits in int.
5232 (Fset_window_scroll_bars):
5233 Check that fixnums are in proper range for system types.
5234 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
5235 (string_pos, c_string_pos, number_of_chars, init_iterator)
5236 (in_ellipses_for_invisible_text_p, init_from_display_pos)
5237 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
5238 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
5239 (face_before_or_after_it_pos, handle_invisible_prop)
5240 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
5241 (display_prop_intangible_p, string_buffer_position_lim)
5242 (string_buffer_position, handle_composition_prop, load_overlay_strings)
5243 (get_overlay_strings_1, get_overlay_strings)
5244 (iterate_out_of_display_property, forward_to_next_line_start)
5245 (back_to_previous_visible_line_start, reseat, reseat_to_string)
5246 (get_next_display_element, set_iterator_to_next)
5247 (get_visually_first_element, compute_stop_pos_backwards)
5248 (handle_stop_backwards, next_element_from_buffer)
5249 (move_it_in_display_line_to, move_it_in_display_line)
5250 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5251 (add_to_log, message_dolog, message_log_check_duplicate)
5252 (message2, message2_nolog, message3, message3_nolog
5253 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
5254 (current_message_1, truncate_echo_area, truncate_message_1)
5255 (set_message, set_message_1, store_mode_line_noprop)
5256 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
5257 (text_outside_line_unchanged_p, check_point_in_composition)
5258 (reconsider_clip_changes)
5259 (redisplay_internal, set_cursor_from_row, try_scrolling)
5260 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
5261 (redisplay_window, find_last_unchanged_at_beg_row)
5262 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
5263 (trailing_whitespace_p, find_row_edges, display_line)
5264 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
5265 (display_mode_element, store_mode_line_string)
5266 (pint2str, pint2hrstr, decode_mode_spec)
5267 (display_count_lines, display_string, draw_glyphs)
5268 (x_produce_glyphs, x_insert_glyphs)
5269 (rows_from_pos_range, mouse_face_from_buffer_pos)
5270 (fast_find_string_pos, mouse_face_from_string_pos)
5271 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5272 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5273 (safe_call, init_from_display_pos, handle_fontified_prop)
5274 (handle_single_display_spec, load_overlay_strings)
5275 (with_echo_area_buffer, setup_echo_area_for_printing)
5276 (display_echo_area, echo_area_display)
5277 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
5278 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
5279 (redisplay_window, dump_glyph_row, display_mode_line)
5280 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 5281 (handle_display_spec, display_prop_string_p):
d311d28c
PE
5282 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5283 (handle_single_display_spec, build_desired_tool_bar_string)
5284 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
5285 (get_specified_cursor_type):
5286 Check that fixnums are in proper range for system types.
5287 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
5288 (Flookup_image_map):
5289 Don't assume fixnums fit in int.
5290 (compare_overlay_entries):
5291 Avoid mishandling comparisons due to subtraction overflow.
5292 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
5293 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
5294 (handle_tool_bar_click):
5295 Use int, not unsigned, since we prefer signed and the signedness
5296 doesn't matter here.
5297 (get_next_display_element, next_element_from_display_vector):
5298 Use int, not EMACS_INT, when int is wide enough.
5299 (start_hourglass): Use duration_to_sec_usec to do proper
5300 overflow checking on durations.
5301 * xfaces.c (Fbitmap_spec_p):
5302 Check that fixnums are in proper range for system types.
5303 (compare_fonts_by_sort_order):
5304 Avoid mishandling comparisons due to subtraction overflow.
5305 (Fx_family_fonts, realize_basic_faces):
5306 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5307 (Fx_family_fonts):
5308 Don't assume fixnum fits in int.
5309 Use SAFE_ALLOCA_LISP, not alloca.
5310 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
5311 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
5312 (face_at_buffer_position, face_for_overlay_string)
5313 (face_at_string_position):
5314 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5315 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
5316 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
5317 (Fx_show_tip):
5318 Check that fixnums are in proper range for system types.
5319 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
5320 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
5321 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5322 (Fx_change_window_property): Don't assume fixnums fit in int.
5323 * xfont.c (xfont_chars_supported):
5324 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5325 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
5326 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
5327 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5328 * xml.c (parse_region):
5329 * xrdb.c (magic_file_p):
5330 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5331 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
5332 (x_get_local_selection, x_reply_selection_request)
5333 (x_handle_selection_request, wait_for_property_change):
5334 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5335 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
5336 short is wide enough.
5337 (x_send_client_event): Don't assume fixnum fits in int.
5338 * xterm.c (x_x_to_emacs_modifiers):
5339 Don't assume EMACS_INT overflows nicely into int.
5340 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
5341 may come from Lisp.
5342 (handle_one_xevent): NATNUMP can eval its arg twice.
5343 (x_connection_closed):
5344 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5345 * xterm.h: Adjust decls to match defn changes elsewhere.
5346 (struct scroll_bar): Use struct vectorlike_header
5347 rather than rolling our own approximation.
5348 (SCROLL_BAR_VEC_SIZE): Remove; not used.
5349
c6574eb5
GM
53502012-05-25 Glenn Morris <rgm@gnu.org>
5351
5352 * lisp.mk (lisp): Update for more files being compiled now.
5353
e8d32c7e
SM
53542012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
5355
48def666
SM
5356 * lread.c: Remove `read_pure' which makes no difference.
5357 (read_pure): Remove var.
5358 (unreadpure): Remove function.
5359 (readevalloop): Don't call read_list with -1 flag.
5360 (read1, read_vector): Don't test read_pure any more.
5361 (read_list): Simplify.
5362
e8d32c7e
SM
5363 * fileio.c, character.h: Minor style tweaks.
5364
4b2addb7
DA
53652012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
5366
5367 * window.h (clip_changed): Remove useless declaration.
5368
584461b2
JB
53692012-05-22 Juanma Barranquero <lekktu@gmail.com>
5370
5371 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
5372 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
5373
34374650
PE
53742012-05-22 Paul Eggert <eggert@cs.ucla.edu>
5375
5376 Remove src/m/*.
5377 This directory predates autoconf and is no longer needed nowadays.
5378 Move its few remaining bits of functionality to where they're needed.
5379 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
5380 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
5381 * m/template.h: Remove.
5382 * Makefile.in (M_FILE): Remove. All uses removed.
5383 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
5384 * lisp.h (USE_LSB_TAG):
5385 * mem-limits.h (EXCEEDS_LISP_PTR):
5386 Use VAL_MAX, not VALBITS, in #if.
5387 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
5388 (EMACS_UINT): Define unconditionally now.
5389 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
5390 (BITS_PER_EMACS_INT): New constants, replacing
5391 what used to be in config.h, but not useful in #if.
5392 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
5393 define them any more.
5394 (VAL_MAX): New macro.
5395 (VALMASK): Use it.
5396 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
5397 BITS_PER_EMACS_INT, in #if.
5398 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
5399 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
5400 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
5401 * s/ms-w32.h (DATA_START):
5402 Move here from removed file m/intel386.h.
5403 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
5404 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
5405
261cb4bb
PE
54062012-05-21 Paul Eggert <eggert@cs.ucla.edu>
5407
5408 Assume C89 or later.
5409 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
5410 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
5411 (xrealloc):
5412 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
5413 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
5414 * textprop.c, tparam.c (NULL): Remove.
5415 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
5416 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
5417 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
5418 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
5419 * xterm.c (input_signal_count): Assume volatile works.
5420
ff23cd9f
KB
54212012-05-21 Ken Brown <kbrown@cornell.edu>
5422
5423 * xgselect.c (xg_select): Fix first argument in call to 'select'
5424 (bug#11508).
5425
1b170bc6
KB
54262012-05-20 Ken Brown <kbrown@cornell.edu>
5427
5428 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 5429 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 5430
b2f4d39f
KB
54312012-05-19 Ken Brown <kbrown@cornell.edu>
5432
5433 * xfns.c (x_in_use): Remove `static' qualifier.
5434 * xterm.h (x_in_use): Declare.
5435 * xgselect.c: Include xterm.h.
5436 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
5437 and `display_arg' (bug#9754).
5438
003fdae2
PE
54392012-05-19 Paul Eggert <eggert@cs.ucla.edu>
5440
9232a6d9
PE
5441 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
5442
003fdae2
PE
5443 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
5444 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
5445
784b56e2
EZ
54462012-05-18 Eli Zaretskii <eliz@gnu.org>
5447
5448 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
5449
5450 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 5451 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
5452
5453 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
5454 reference to image_cache->refcount.
5455 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
5456
a0a79cde
JL
54572012-05-17 Juri Linkov <juri@jurta.org>
5458
5459 * search.c (Fword_search_regexp, Fword_search_backward)
5460 (Fword_search_forward, Fword_search_backward_lax)
5461 (Fword_search_forward_lax): Move functions to isearch.el
5462 (bug#10145, bug#11381).
5463
b0572523
PE
54642012-05-16 Paul Eggert <eggert@cs.ucla.edu>
5465
5466 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
5467
9660f5fc
SM
54682012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
5469
5470 * lread.c (init_obarray): Declare Qt and Qnil as special.
5471
4374de83
GM
54722012-05-14 Glenn Morris <rgm@gnu.org>
5473
5474 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 5475 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 5476
dc44c39a
PE
54772012-05-14 Paul Eggert <eggert@cs.ucla.edu>
5478
078c97cb
PE
5479 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
5480
dc44c39a
PE
5481 * unexaix.c: Port to more-recent AIX compilers.
5482 (report_error, report_error_1, make_hdr, copy_sym)
5483 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
5484 Make arguments const char *, not char *, to avoid violations of C
5485 standard and to fix some AIX warnings reported by Gilles Pion.
5486
e18afed7 54872012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
5488
5489 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
5490 already have overlays loaded.
5491 (handle_single_display_spec): Before returning without displaying
5492 fringe bitmap, synchronize the bidi iterator with the main display
5493 iterator, by calling iterate_out_of_display_property.
5494 (iterate_out_of_display_property): Detect buffer iteration by
5495 testing that it->string is a Lisp string.
5496 (get_next_display_element): When the current object is exhausted,
5497 and there's something on it->stack, call set_iterator_to_next to
5498 proceed with what's on the stack, instead of returning zero.
5499 (set_iterator_to_next): If called at the end of a Lisp string,
5500 proceed to consider_string_end without incrementing string
5501 position. Don't increment display vector index past the end of
5502 the display vector. (Bug#11417)
c8fb9dc6
EZ
5503 (pos_visible_p): Don't report a position visible when move_it_to
5504 stopped at the last line of window, which happens to be scanned
5505 backwards by the bidi iteration. (Bug#11464)
ac268e67 5506
e18afed7 55072012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
5508
5509 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
5510 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
5511 are on a TTY, and thus unable to display on the fringes.
5512 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
5513 so we need to signal to the caller that this is a "replacing"
5514 display spec. This fixes display when the spec is invalid or we
5515 are on a TTY.
5516
e18afed7 55172012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
5518
5519 * unexaix.c (make_hdr): Fix typo in prototype.
5520 This bug broke the build on AIX. Problem reported by Gilles Pion.
5521
9d0a235a
MA
55222012-05-14 Michael Albinus <michael.albinus@gmx.de>
5523
5524 * keyboard.c (kbd_buffer_get_event): Read special events also in
5525 batch mode. (Bug#11415)
5526
9e6b06ed
GM
55272012-05-12 Glenn Morris <rgm@gnu.org>
5528
5529 * ns.mk: Update for ns_appbindir no longer having trailing "/".
5530
c1a1d7a3
EZ
55312012-05-12 Eli Zaretskii <eliz@gnu.org>
5532
5533 * lisp.mk (lisp): Add newcomment.elc.
5534
3fe7cdc8
GM
55352012-05-12 Glenn Morris <rgm@gnu.org>
5536
5537 * Makefile.in (MKDIR_P): New, set by configure.
5538 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
5539
53f7d2c0
PE
55402012-05-11 Paul Eggert <eggert@cs.ucla.edu>
5541
5542 Remove unused function hourglass_started.
5543 * dispextern.h (hourglass_started):
5544 * w32fns.c (hourglass_started):
5545 * xdisp.c (hourglass_started): Remove.
5546
75aafb17
JB
55472012-05-10 Juanma Barranquero <lekktu@gmail.com>
5548
5549 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
5550 Update dependencies.
5551
12959e8e
PE
55522012-05-10 Paul Eggert <eggert@cs.ucla.edu>
5553
97107e2e
PE
5554 * xgselect.c (xg_select): Put maxfds+1 into a var.
5555 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
5556
12959e8e
PE
5557 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
5558
836d29b3
DA
55592012-05-10 Dave Abrahams <dave@boostpro.com>
5560
5561 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
5562 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
5563
5cb67954
MA
55642012-05-09 Michael Albinus <michael.albinus@gmx.de>
5565
5566 * dbusbind.c (xd_registered_buses): New internal Lisp object.
5567 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
5568 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
5569 Initialize xd_registered_buses.
5570
3478ec45
PE
55712012-05-09 Paul Eggert <eggert@cs.ucla.edu>
5572
b263a6b0
PE
5573 Untag more efficiently if USE_LSB_TAG.
5574 This is based on a proposal by YAMAMOTO Mitsuharu in
5575 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
5576 For an admittedly artificial (nth 8000 longlist) benchmark on
5577 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
5578 Emacs's overall text size by 1%.
5579 * lisp.h (XUNTAG): New macro.
5580 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
5581 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
5582 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
5583 * eval.c (Fautoload):
5584 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
5585 * frame.h (XFRAME): Use XUNTAG.
5586
3478ec45
PE
5587 Port recent dbusbind.c changes to 32-bit --with-wide-int.
5588 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
5589 Remove unportable assumptions about print widths of types like
5590 dbus_uint32_t.
5591 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
5592 intptr_t when converting between pointer and integer, to avoid GCC
5593 warnings about wrong width.
5594
666b903b 55952012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
5596
5597 * w32proc.c (new_child): Force Windows to reserve only 64KB of
5598 stack for each reader_thread, instead of defaulting to 8MB
5599 determined by the linker. This avoids failures in creating
5600 subprocesses on Windows 7, see the discussion in this thread:
5601 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
5602
b120cc17
JC
56032012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
5604
5605 Fix up display of the *Minibuf-0* buffer in the mini window.
5606 * keyboard.c (read_char): Don't clear the echo area if there's no
5607 message to clear.
5608 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 5609 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 5610
9a4b36f8
MA
56112012-05-07 Michael Albinus <michael.albinus@gmx.de>
5612
5613 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
5614 batch mode.
5615
e5f9458f
CY
56162012-05-06 Chong Yidong <cyd@gnu.org>
5617
5618 * lisp.mk (lisp): Update.
5619
eceeb5fc 56202012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
5621
5622 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
5623
71873e2b
SM
56242012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
5625
5626 * data.c (PUT_ERROR): New macro.
5627 (syms_of_data): Use it. Add new error type `user-error'.
5628 * undo.c (user_error): New function.
5629 (Fprimitive_undo): Use it.
5630 * print.c (print_error_message): Adjust print style for `user-error'.
5631 * keyboard.c (user_error): New function.
5632 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
5633
ab0fa4e4
PE
56342012-05-03 Paul Eggert <eggert@cs.ucla.edu>
5635
5636 Do not limit current-time-string to years 1000..9999.
5637 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
5638 (Fcurrent_time_string): Support any year that is supported by the
5639 underlying localtime representation. Don't use asctime, as it
5640 has undefined behavior for years outside the range -999..9999.
5641
7ed806a7
PE
56422012-05-02 Paul Eggert <eggert@cs.ucla.edu>
5643
5644 Fix race conditions involving setenv, gmtime, localtime, asctime.
5645 Without this fix, interrupts could mess up code that uses these
5646 nonreentrant functions, since setting TZ invalidates existing
5647 tm_zone or tzname values, and since most of these functions return
5648 pointers to static storage.
5649 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
5650 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
5651 Grow the critical sections to include not just invoking
5652 localtime/gmtime, but also accessing these functions' results
5653 including their tm_zone values if any, and any related TZ setting.
5654 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
5655 so that the struct tm is saved in the critical section.
5656 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
5657 motivated by the fact that memory allocation needs to be outside
5658 the critical section.
5659
0c16dfed
DA
56602012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
5661
5662 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
5663 with RESET_INTERVAL.
5664
5665 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5666 Remove duplicated buffer name initialization.
5667
3f83ace8
JM
56682012-05-02 Jim Meyering <jim@meyering.net>
5669
5670 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
5671
c7b8541e
JM
5672 * xfns.c (x_window): Use xstrdup (Bug#11375).
5673
90207a15 56742012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
5675
5676 * xdisp.c (pos_visible_p): If already at a newline from the
5677 display string before the 'while' loop, don't walk back the glyphs
5678 from it3.glyph_row. Solves assertion violation when the display
5679 string begins with a newline (egg.el). (Bug#11367)
5680
b593d6a9
AH
56812012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
5682
5683 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
5684 Move to simple.el.
5685
4737362e
GM
56862012-05-01 Glenn Morris <rgm@gnu.org>
5687
99cf43f9
GM
5688 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
5689 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
5690 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
5691 All were removed before 23.1.
5692
9311dcff
GM
5693 * dispnew.c: Remove HAVE_LIBNCURSES test;
5694 it is always true on relevant platforms.
5695
4d5c6349
GM
5696 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
5697 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
5698
4737362e
GM
5699 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
5700
74dd3a6b
AS
57012012-04-30 Andreas Schwab <schwab@linux-m68k.org>
5702
5703 * .gdbinit (xpr): Remove checks for no longer existing misc types.
5704 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
5705 Remove.
5706
13c379ee
PE
57072012-04-28 Paul Eggert <eggert@cs.ucla.edu>
5708
5709 Do not avoid creating empty evaporating overlays (Bug#9642).
5710 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
5711 That is, do not delete an evaporating overlay if it becomes
5712 empty after its bounds are adjusted to fit within its buffer.
5713 This fix caused other problems, and I'm reverting it until we get
5714 to the bottom of them.
5715
a8e7d6d7 57162012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
5717
5718 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
5719
a8e7d6d7 57202012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
5721
5722 * xdisp.c (pos_visible_p): If the window start position is beyond
5723 ZV, start the display from buffer beginning. Prevents assertion
5724 violation in init_iterator when the minibuffer window is scrolled
5725 via the scroll bar.
5726
5727 * window.c (window_scroll_pixel_based): Likewise.
5728
a8e7d6d7 57292012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
5730
5731 * keymap.c (where_is_internal): Doc fix (Bug#10872).
5732
a8e7d6d7 57332012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
5734
5735 * fileio.c (Fcopy_file, Fset_file_selinux_context):
5736 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
5737
a8e7d6d7 57382012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 5739
b593d6a9
AH
5740 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
5741 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 5742
1c6900d9
EZ
57432012-04-26 Eli Zaretskii <eliz@gnu.org>
5744
4c3fa1d9
EZ
5745 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
5746 display element, check also the underlying string or buffer
5747 character. (Bug#11341)
5748
1c6900d9
EZ
5749 * w32menu.c: Include w32heap.h.
5750 (add_menu_item): If the call to AppendMenuW (via
5751 unicode_append_menu) fails, disable Unicode menus only if we are
5752 running on Windows 9X/Me.
5753
42bf8205
AS
57542012-04-24 Andreas Schwab <schwab@linux-m68k.org>
5755
5756 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
5757 (xgetint): Add missing shift for LSB tags.
5758
b1bac16e
MR
57592012-04-24 Martin Rudalics <rudalics@gmx.at>
5760
5761 * keyboard.c (read_char): Don't wipe echo area for select window
5762 events: These might get delayed via `mouse-autoselect-window'
5763 (Bug#11304).
5764
d69621cc
JB
57652012-04-24 Juanma Barranquero <lekktu@gmail.com>
5766
5767 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
5768 manipulation of :loaded-from data.
5769
02fd101b
JB
57702012-04-23 Juanma Barranquero <lekktu@gmail.com>
5771
5772 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
5773 now a cons (bug#11311).
5774
888bec30
PE
57752012-04-23 Paul Eggert <eggert@cs.ucla.edu>
5776
89a438bd
PE
5777 Do not create empty overlays with the evaporate property (Bug#9642).
5778 * buffer.c (Fmove_overlay): Delete an evaporating overlay
5779 if it becomes empty after its bounds are adjusted to fit within
5780 its buffer. Without this fix, in a nonempty buffer (let ((o
5781 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
5782 yields an empty overlay that has the evaporate property, which is
5783 not supposed to happen.
5784
1068fe4d
PE
5785 Fix minor GTK3 problems found by static checking.
5786 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5787 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5788 (struct _EmacsFixedClass, emacs_fixed_get_type):
5789 Move decls here from emacsgtkfixed.h, since they needn't be public.
5790 (emacs_fixed_get_type): Now static.
5791 (emacs_fixed_class_init): Omit unused local.
5792 (emacs_fixed_child_type): Remove; unused.
5793 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5794 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5795 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
5796 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
5797 (EMACS_FIXED_GET_CLASS): Remove; unused.
5798 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
5799
888bec30
PE
5800 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
5801 Problem reported by Juanma Barranquero for Windows -Wunused-function.
5802
de85e130
PE
58032012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5804
d0baac98 5805 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 5806 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
5807 (__malloc_size_t, __malloc_ptrdiff_t):
5808 Remove. All uses removed, replaced by the definiens if needed,
5809 since we can assume C89 or better now.
5810 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
5811 (protect_malloc_state, align, get_contiguous_space)
5812 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
5813 (malloc_atfork_handler_child, malloc_enable_thread)
5814 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
5815 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
5816 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
5817 (special_realloc, _realloc_internal_nolock, _realloc_internal)
5818 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
5819 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
5820 Define using prototypes, not old style.
5821 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
5822 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
5823 (align): Don't assume that signed integer overflow wraps around.
5824 Omit unused local var.
5825 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
5826 (_free_internal_nolock, memalign, mallochook, reallochook):
5827 Omit no-longer-needed casts.
5828 (valloc): Use getpagesize, not __getpagesize.
5829 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
5830 (struct hdr): The 'magic' member is now size_t, not unsigned long.
5831
de85e130
PE
5832 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
5833
dcbf5805
MA
58342012-04-22 Michael Albinus <michael.albinus@gmx.de>
5835
5836 Move functions from C to Lisp. Make non-blocking method calls
5837 the default. Implement further D-Bus standard interfaces.
5838
5839 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
5840 (QCdbus_request_name_allow_replacement)
5841 (QCdbus_request_name_replace_existing)
5842 (QCdbus_request_name_do_not_queue)
5843 (QCdbus_request_name_reply_primary_owner)
5844 (QCdbus_request_name_reply_in_queue)
5845 (QCdbus_request_name_reply_exists)
5846 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
5847 (QCdbus_registered_serial, QCdbus_registered_method)
5848 (QCdbus_registered_signal): New Lisp objects.
5849 (XD_DEBUG_MESSAGE): Use sizeof.
5850 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
5851 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
5852 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
5853 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
5854 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
5855 (xd_signature, xd_append_arg): Allow float for integer types.
5856 (xd_get_connection_references): New function.
b593d6a9
AH
5857 (xd_get_connection_address): Rename from xd_initialize.
5858 Return cached address.
dcbf5805
MA
5859 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
5860 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
5861 level.
5862 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 5863 Return number of refcounts.
dcbf5805
MA
5864 (Fdbus_get_unique_name): Make stronger parameter check.
5865 (Fdbus_message_internal): New defun.
5866 (Fdbus_call_method, Fdbus_call_method_asynchronously)
5867 (Fdbus_method_return_internal, Fdbus_method_error_internal)
5868 (Fdbus_send_signal, Fdbus_register_service)
5869 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
5870 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
5871 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
5872 (Vdbus_compiled_version, Vdbus_runtime_version)
5873 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
5874 (Vdbus_message_type_method_return, Vdbus_message_type_error)
5875 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
5876 (Vdbus_registered_buses, Vdbus_registered_objects_table):
5877 Adapt docstring.
dcbf5805 5878
52828e02
PE
58792012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5880
da05bc4c
PE
5881 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
5882 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
5883 Do not assume ptrdiff_t is the same width as 'int'.
5884
52828e02
PE
5885 * alloc.c: Handle unusual debugging option combinations.
5886 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
5887 since the two debugging options are incompatible.
5888 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
5889 is defined.
5890 (mem_init, mem_insert, mem_insert_fixup):
5891 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
5892 (NEED_MEM_INSERT): Remove; no longer needed.
5893
f01769f9
LL
58942012-04-22 Leo Liu <sdl.web@gmail.com>
5895
5896 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
5897
5790543d
PE
58982012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5899
5900 * sysdep.c [__FreeBSD__]: Minor cleanups.
5901 (list_system_processes, system_process_attributes) [__FreeBSD__]:
5902 Use Emacs indenting style more consistently. Avoid some casts.
5903 Use 'double' consistently rather than mixing 'float' and 'double'.
5904
b91b7e4d
EW
59052012-04-21 Eduard Wiebe <usenet@pusto.de>
5906
b593d6a9
AH
5907 * sysdep.c (list_system_processes, system_process_attributes):
5908 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 5909
6114eb15
AS
59102012-04-21 Andreas Schwab <schwab@linux-m68k.org>
5911
5912 * lisp.mk (lisp): Update.
5913
2f38dff7
PE
59142012-04-20 Paul Eggert <eggert@cs.ucla.edu>
5915
5916 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
5917 It is never used otherwise.
5918
4ae29f89
SM
59192012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
5920
5921 * print.c (print_preprocess): Only check print_depth if print-circle
5922 is nil.
5923 (print_object): Check for cycles even when print-circle is nil and
5924 print-gensym is t, but only check print_depth if print-circle is nil.
5925
f30d612a
CY
59262012-04-20 Chong Yidong <cyd@gnu.org>
5927
5928 * process.c (wait_reading_process_output): If EIO occurs on a pty,
5929 set the status to "failed" and ensure that sentinel is run.
5930
c07a4c0b 59312012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
5932
5933 * process.c (Fset_process_inherit_coding_system_flag)
5934 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 5935 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 5936
c07a4c0b 59372012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
5938
5939 * xdisp.c (string_buffer_position_lim): Limit starting position to
5940 BEGV.
5941 (set_cursor_from_row): If called for a mode-line or header-line
5942 row, return zero immediately.
5943 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
5944 farther than the first row after the header line, if any.
5945 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
5946 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
5947
c07a4c0b 59482012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5949
4ae29f89
SM
5950 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
5951 (bug#11238).
ad3a2b41 5952
c07a4c0b 59532012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 59542012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
5955
5956 configure: new option --enable-gcc-warnings (Bug#11207)
5957 * Makefile.in (C_WARNINGS_SWITCH): Remove.
5958 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
5959 (ALL_CFLAGS): Use new macros rather than old.
5960 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
5961 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
5962 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
5963 -Wunused-result, -Wunused-variable. This should go away once
5964 the Emacs and Gnulib regex code is merged.
5965 (xmalloc, xrealloc): Now static.
5966
aba027e8
PE
59672012-04-17 Paul Eggert <eggert@cs.ucla.edu>
5968
5969 * dired.c (Fsystem_groups): Remove unused local.
5970
e5a36063
GM
59712012-04-17 Glenn Morris <rgm@gnu.org>
5972
5973 * dired.c (Fsystem_users): Doc fix.
5974
316411f0
DA
59752012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
5976
5977 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
5978 (syms_of_dired): Add them.
5979
9426aba4
PE
59802012-04-16 Paul Eggert <eggert@cs.ucla.edu>
5981
b62a57be
PE
5982 Fix minor alloc.c problems found by static checking.
5983 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
5984 New extern decls, to avoid calling undeclared functions.
5985 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
5986 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
5987 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
5988 (NEED_MEM_INSERT): New macro.
5989 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 5990 Remove one incorrect comment and fix another.
b62a57be 5991
3539f31f
PE
5992 Fix minor ralloc.c problems found by static checking.
5993 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5994 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
5995 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
5996 (r_alloc_sbrk): Now static.
5997
a041960a
PE
5998 Improve ralloc.c interface checking.
5999 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
6000 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
6001 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
6002 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
6003 [REL_ALLOC]: ... to here, to check interface.
6004 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
6005 Remove decls. This fixes an "It stinks!".
6006
9426aba4
PE
6007 * alloc.c (which_symbols): Fix alignment issue / type clash.
6008
d55c12ed
AS
60092012-04-15 Andreas Schwab <schwab@linux-m68k.org>
6010
6011 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
6012 (struct Lisp_Misc_Any): Likewise.
6013 (struct Lisp_Free): Likewise.
6014 * alloc.c (union aligned_Lisp_Symbol): Define.
6015 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
6016 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
6017 (union aligned_Lisp_Misc): Define.
6018 (MARKER_BLOCK_SIZE, struct marker_block): Use union
6019 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 6020 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 6021
b948ce8b
PE
60222012-04-14 Paul Eggert <eggert@cs.ucla.edu>
6023
6024 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
6025 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
6026 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
6027 * s/netbsd.h, s/sol2-6.h:
6028 Remove definition of GC_MARK_STACK, since the default now works.
6029 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
6030 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
6031 no longer the default.
6032 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
6033
35dc09a1 60342012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 6035
35dc09a1
GM
6036 * lread.c (lisp_file_lexically_bound_p):
6037 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 6038
35dc09a1
GM
60392012-04-14 Eli Zaretskii <eliz@gnu.org>
6040
6041 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
6042 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
6043
60442012-04-14 Jan Djärv <jan.h.d@swipnet.se>
6045
6046 * nsterm.m (constrainFrameRect): Always constrain when there is only
6047 one screen (Bug#10962).
6048
bcd86815
KB
60492012-04-13 Ken Brown <kbrown@cornell.edu>
6050
6051 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
6052
c25df26e
RT
60532012-04-13 Reuben Thomas <rrt@sc3d.org>
6054
6055 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
6056
0fc59f1e
DC
60572012-04-11 Daniel Colascione <dancol@dancol.org>
6058
6059 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
6060 against is gone. It's better to use vfork now so that when Cygwin
6061 gains a new, working vfork, we use it automatically (bug#10398).
6062
de8c03dc
SM
60632012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
6064
6065 * window.c (save_window_save): Obey window-point-insertion-type.
6066
2f097256
GM
60672012-04-11 Glenn Morris <rgm@gnu.org>
6068
6069 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
6070
453b951e
SM
60712012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
6072
6073 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
6074
75f1671a 60752012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
6076
6077 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
6078 (force_quit_count): New var.
6079 (handle_interrupt): Use it.
6080
2a8ce227
JB
60812012-04-10 Juanma Barranquero <lekktu@gmail.com>
6082
6083 * w32.c (w32_delayed_load): Record the full path of the library
6084 being loaded (bug#10424).
6085
935396c0
GM
60862012-04-09 Glenn Morris <rgm@gnu.org>
6087
05920a43
GM
6088 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
6089 not just in the obarray, before snarfing them. (Bug#11036)
6090
935396c0
GM
6091 * Makefile.in ($(leimdir)/leim-list.el):
6092 Pass EMACS rather than BUILT_EMACS.
6093
a18ecafa
TZ
60942012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
6095
6096 * process.c (make_process):
6097 * process.h: Add integer `gnutls_handshakes_tried' member to
6098 process struct.
6099
6bbef4e5
JC
6100 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
6101 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
6102
6103 * gnutls.c (gnutls_log_function2i): Convenience log function.
6104 (emacs_gnutls_read): Use new log functions,
6105 `gnutls_handshakes_tried' process member, and
6106 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
6107 attempts per process (connection).
6108
b4d3bc10
CY
61092012-04-09 Chong Yidong <cyd@gnu.org>
6110
6111 * eval.c (Fuser_variable_p, user_variable_p_eh)
6112 (lisp_indirect_variable): Functions deleted.
6113 (Fdefvar): Caller changed.
6114
6115 * callint.c (Finteractive, Fcall_interactively):
6116 * minibuf.c (Fread_variable): Callers changed.
6117
70f4d973
EZ
61182012-04-09 Eli Zaretskii <eliz@gnu.org>
6119
6120 * xdisp.c (set_cursor_from_row): If the display string appears in
6121 the buffer at position that is closer to point than the position
6122 after the display string, display the cursor on the first glyph of
6123 the display string. Fixes cursor display when a 'display' text
6124 property immediately follows invisible text. (Bug#11094)
6125
cb3c2e3e
PE
61262012-04-09 Paul Eggert <eggert@cs.ucla.edu>
6127
6128 composite.c: use 'double' consistently
6129 * composite.c (get_composition_id): Use 'double' consistently
6130 instead of converting 'float' to 'double' and vice versa; this is
6131 easier to understand and avoids a GCC warning.
6132
fd06db5d
GM
61332012-04-09 Glenn Morris <rgm@gnu.org>
6134
50fe702a
GM
6135 * Makefile.in: Generate leim-list with bootstrap-emacs, in
6136 preparation for dumping it with emacs. (Bug#4789)
6137 (leimdir): New variable.
6138 ($(leimdir)/leim-list.el): New rule.
6139 (emacs$(EXEEXT)): Depend on leim-list.el.
6140
fd06db5d
GM
6141 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
6142 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
6143 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
6144
55c131ee
AS
61452012-04-08 Andreas Schwab <schwab@linux-m68k.org>
6146
6147 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
6148 proper alignment.
6149
9209588f
JB
61502012-04-07 Juanma Barranquero <lekktu@gmail.com>
6151
6152 * xml.c (init_libxml2_functions) [WINDOWSNT]:
6153 Remove unused local variable.
6154
e3fb2efb
PE
61552012-04-07 Paul Eggert <eggert@cs.ucla.edu>
6156
6157 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
6158 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
6159 (mark_memory): Mark Lisp_Objects only if pointers might hide in
6160 objects, as mark_maybe_pointer will catch them otherwise.
6161 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
6162 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
6163
b5385551
PE
61642012-04-07 Paul Eggert <eggert@cs.ucla.edu>
6165
6166 Fix typo that broke non-Windows builds.
6167 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
6168
9078ead6
EZ
61692012-04-07 Eli Zaretskii <eliz@gnu.org>
6170
6171 Support building on MS-Windows with libxml2.
6172
6173 * makefile.w32-in (OBJ2): Add xml.$(O).
6174 (GLOBAL_SOURCES): Add xml.c.
6175 ($(BLD)/xml.$(O)): New dependency list.
6176
6177 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
6178 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
6179 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
6180 [!WINDOWSNT]: New macros.
6181 (init_libxml2_functions, libxml2_loaded_p): New functions.
6182 (parse_region): Call fn_xmlCheckVersion instead of using the macro
6183 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
6184 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
6185 Calls xmlCleanupParser only if libxml2 was loaded (or statically
6186 linked in).
6bbef4e5
JC
6187 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
6188 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
6189 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
6190
6191 * emacs.c: Don't include libxml/parser.h.
6192 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
6193 xmlCleanupParser directly.
6194
6195 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
6196
3811fdf3
EZ
61972012-04-07 Eli Zaretskii <eliz@gnu.org>
6198
6199 * indent.c (Fvertical_motion): If there is a display string at
6200 point, use it.vpos to compute how many lines to backtrack after
6201 move_it_to point. (Bug#11133)
6202
2f8e16b2
EZ
62032012-04-06 Eli Zaretskii <eliz@gnu.org>
6204
6205 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
6206 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
6207 about subtle differences between FETCH_CHAR* and STRING_CHAR*
6208 macros related to unification of CJK characters. For the details,
6209 see the discussion following the message here:
6210 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
6211
3d439cd1
CY
62122012-04-04 Chong Yidong <cyd@gnu.org>
6213
6214 * keyboard.c (Vdelayed_warnings_list): Doc fix.
6215
8bc53d00
EZ
62162012-04-01 Eli Zaretskii <eliz@gnu.org>
6217
6218 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
6219 instead of alloca. (Bug#11138)
6220
3b0512a3
AS
62212012-04-01 Andreas Schwab <schwab@linux-m68k.org>
6222
6223 * w32menu.c (is_simple_dialog): Properly check lisp types.
6224 (Bug#11141)
6225
8427ddd2
EZ
62262012-03-31 Eli Zaretskii <eliz@gnu.org>
6227
979022ef
EZ
6228 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
6229 position we get to after a call to move_it_to fails the
6230 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
6231 only if we wind up in a string from display property. (Bug#11063)
6232
a6b1c7cc
EZ
6233 * window.c (Fdelete_other_windows_internal): Invalidate the row
6234 and column information about mouse highlight, so that redisplay
6235 restores it after reallocating the glyph matrices. (Bug#7464)
6236
8427ddd2
EZ
6237 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
6238 string comes from a `display' text property, use the buffer
6239 position of that property as if we actually saw that position in
6240 the row's glyphs.
697ba24b
EZ
6241 (move_it_by_lines): Remove the assertion that
6242 "it->current_x == 0 && it->hpos == 0" which can be legitimately
6243 violated when there's a before-string at the beginning of a line.
6244 (Bug#11063)
8427ddd2 6245
65a0a738
EZ
62462012-03-30 Eli Zaretskii <eliz@gnu.org>
6247
6248 * xdisp.c (append_space_for_newline): If the default face was
6249 remapped, use the remapped face for the appended newline.
6250 (extend_face_to_end_of_line): Use the remapped default face for
6251 extending the face to the end of the line.
6252 (display_line): Call extend_face_to_end_of_line when the default
6253 face was remapped. (Bug#11068)
6254
581355cc
EZ
62552012-03-29 Eli Zaretskii <eliz@gnu.org>
6256
6257 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
6258
e8fc049f
SM
62592012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6260
6261 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
6262
4fb9a543
GM
62632012-03-27 Glenn Morris <rgm@gnu.org>
6264
6265 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
6266 Doc fixes.
6267
679910f1
KH
62682012-03-26 Kenichi Handa <handa@m17n.org>
6269
6270 * dispextern.h (struct glyph): Fix previous change. Change the
6271 bit length of glyphless.ch to 25 (Bug#11082).
6272
90d49b7f
CY
62732012-03-26 Chong Yidong <cyd@gnu.org>
6274
6275 * keyboard.c (Vselection_inhibit_update_commands): New variable.
6276 (command_loop_1): Use it; inhibit selection update for
6277 handle-select-window too (Bug#8996).
6278
f514f6f0
FP
62792012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
6280
e8fc049f 6281 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 6282
bf43fa51
KH
62832012-03-25 Kenichi Handa <handa@m17n.org>
6284
6285 * dispextern.h (struct glyph): Change the bit length of
6286 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
6287
8a0c01dd
EZ
62882012-03-24 Eli Zaretskii <eliz@gnu.org>
6289
6290 * s/ms-w32.h (tzname): Include time.h before redirecting to
6291 _tzname. Fixes the MSVC build. (Bug#9960)
6292
7d1c3a76
AS
62932012-03-24 Andreas Schwab <schwab@linux-m68k.org>
6294
8ed79523
AS
6295 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
6296 characters.
6297
7d1c3a76
AS
6298 * xterm.c (XTread_socket): Only modify handling_signal if
6299 !SYNC_INPUT. (Bug#11080)
6300
e99a9b8b
EZ
63012012-03-23 Eli Zaretskii <eliz@gnu.org>
6302
6303 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
6304 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
6305 when fetching a multibyte character consumes more bytes than
6306 CHAR_BYTES returns, due to unification of CJK characters in
6307 string_char. (Bug#11073)
6308
5063c0e1
TN
63092012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
6310
6311 * process.c (wait_reading_process_output): Handle pty disconnect
6312 by refraining from sending oneself a SIGCHLD (bug#10933).
6313
9f851fbd
CY
63142012-03-22 Chong Yidong <cyd@gnu.org>
6315
6316 * dispextern.h (struct it): New member string_from_prefix_prop_p.
6317
5063c0e1 6318 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
6319 Mark string as coming from a prefix property.
6320 (handle_face_prop): Use default face for prefix strings (Bug#4281).
6321 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
6322
fb5b8aca
CY
63232012-03-21 Chong Yidong <cyd@gnu.org>
6324
6325 * xfaces.c (Vface_remapping_alist): Doc fix.
6326
62356a1b
EZ
63272012-03-20 Eli Zaretskii <eliz@gnu.org>
6328
6329 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
6330 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
6331 Doc fixes.
62356a1b 6332
025de85b
CY
63332012-03-20 Chong Yidong <cyd@gnu.org>
6334
6335 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
6336 to reflect default non-nil value of redisplay-dont-pause.
6337
4827f94e
KH
63382012-03-19 Kenichi Handa <handa@m17n.org>
6339
6340 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
6341 it fit in a valid range (Bug#11003).
6342
e50a24a2
EZ
63432012-03-18 Eli Zaretskii <eliz@gnu.org>
6344
6345 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
6346 that is not from display property, accept the row as a "cursor
6347 row" if one of the string's character has a non-nil `cursor'
6348 property. Fixes cursor positioning when there are newlines in
6349 overlay strings, e.g. in icomplete.el. (Bug#11035)
6350
9af5ed87
PE
63512012-03-12 Paul Eggert <eggert@cs.ucla.edu>
6352
6353 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
6354
d1f55f16
CY
63552012-03-12 Chong Yidong <cyd@gnu.org>
6356
6357 * eval.c (inhibit_lisp_code): Rename from
6358 inhibit_window_configuration_change_hook; move from window.c.
6359
6360 * xfns.c (unwind_create_frame_1, Fx_create_frame):
6361 * window.c (run_window_configuration_change_hook)
6362 (syms_of_window): Callers changed.
6363
66c5eebd
CY
63642012-03-11 Chong Yidong <cyd@gnu.org>
6365
413df973
CY
6366 * keymap.c (Fkey_description): Doc fix (Bug#9700).
6367
66c5eebd
CY
6368 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
6369
1de11f56
CY
63702012-03-10 Chong Yidong <cyd@gnu.org>
6371
6372 * frame.c (other_visible_frames): Don't assume the selected frame
6373 is visible (Bug#10955).
6374
cae07000
SM
63752012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
6376
6377 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
6378
89c94350
JD
63792012-03-08 Jan Djärv <jan.h.d@swipnet.se>
6380
6381 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
6382 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
6383 zero (Bug#10954).
6384
999dd333
GM
63852012-03-03 Glenn Morris <rgm@gnu.org>
6386
01a6dcc8 6387 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 6388
de0100f2
EZ
63892012-03-02 Eli Zaretskii <eliz@gnu.org>
6390
6391 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
6392 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
6393 (redisplay_window, next_element_from_string): Fix typos in
6394 comments.
3e441275
EZ
6395 (redisplay_window): Pass to move_it_vertically the margin in
6396 pixels, not in screen lines.
de0100f2 6397
96a72ee9
GM
63982012-03-02 Glenn Morris <rgm@gnu.org>
6399
6400 * buffer.c (buffer-list-update-hook): Doc fix.
6401
312508d7
EZ
64022012-02-29 Eli Zaretskii <eliz@gnu.org>
6403
6404 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
6405 push_it before setting up the iterator for the first overlay
6406 string, even if we have an empty string loaded.
6407 (next_overlay_string): If there's an empty string on the iterator
6408 stack, pop the stack. (Bug#10903)
6409
27f3c637
PE
64102012-02-25 Paul Eggert <eggert@cs.ucla.edu>
6411
6412 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
6413 Suggested by Stefan Monnier in
6414 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
6415 * alloc.c (widen_to_Lisp_Object): New static function.
6416 (mark_memory): Also mark Lisp_Objects by fetching pointer words
6417 and widening them to Lisp_Objects. This would work even if
6418 USE_LSB_TAG is defined and wide integers are used, which might
6419 happen in a future version of Emacs.
6420
3c9dfce6
CY
64212012-02-25 Chong Yidong <cyd@gnu.org>
6422
fa74b241
CY
6423 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
6424 Doc fix.
6425
3c9dfce6
CY
6426 * xselect.c (Fx_selection_exists_p): Doc fix.
6427 (x_clipboard_manager_save_all): Print an informative message
6428 before saving to clipboard manager.
6429
9486df08
CY
64302012-02-24 Chong Yidong <cyd@gnu.org>
6431
6432 * keyboard.c (process_special_events): Handle all X selection
6433 requests in kbd_buffer, not just the next one (Bug#8869).
6434
f01d3321
CY
64352012-02-23 Chong Yidong <cyd@gnu.org>
6436
6437 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
6438 call when setting menu-bar-lines and tool-bar-lines parameters.
6439 (unwind_create_frame_1): New helper function.
6440
6441 * window.c (inhibit_window_configuration_change_hook): New var.
6442 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 6443 (syms_of_window): Initialize it.
f01d3321 6444
86b847b6
CY
64452012-02-22 Chong Yidong <cyd@gnu.org>
6446
6447 * xterm.c (x_draw_image_relief): Add missing type check for
6448 Vtool_bar_button_margin (Bug#10743).
6449
a59225b1
CY
64502012-02-21 Chong Yidong <cyd@gnu.org>
6451
6452 * fileio.c (Vfile_name_handler_alist): Doc fix.
6453
6454 * buffer.c (Fget_file_buffer): Protect against invalid file
6455 handler return value.
6456
310f5bd4
PE
64572012-02-20 Paul Eggert <eggert@cs.ucla.edu>
6458
cb3a28cc
PE
6459 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
6460 when computing $valmask.
6461
310f5bd4
PE
6462 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
6463 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
6464 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
6465 It's useless in that case, and it can cause problems on hosts
6466 that allocate halves of EMACS_INT values separately.
6467 Reported by Dan Horák. Diagnosed by Andreas Schwab in
6468 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
6469 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
6470 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
6471 it avoids undefined behavior on hosts where shifting right by more
6472 than the word width has undefined behavior.
6473
2375c96a
CY
64742012-02-19 Chong Yidong <cyd@gnu.org>
6475
6476 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
6477 (Funhandled_file_name_directory, Ffile_name_as_directory)
6478 (Fdirectory_file_name, Fexpand_file_name)
6479 (Fsubstitute_in_file_name): Protect against invalid file handler
6480 return values (Bug#10845).
6481
3eb49e71
EZ
64822012-02-18 Eli Zaretskii <eliz@gnu.org>
6483
6484 * .gdbinit (pitx): Fix incorrect references to fields of the
6485 iterator stack.
6486
7b926f3f
CY
64872012-02-17 Chong Yidong <cyd@gnu.org>
6488
6489 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
6490
11273115
PE
64912012-02-15 Paul Eggert <eggert@cs.ucla.edu>
6492
6493 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
6494 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
6495
c3a70e2b
CY
64962012-02-15 Chong Yidong <cyd@gnu.org>
6497
6498 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
6499 marked as special. Also, starting docstrings with * is obsolete.
6500
0ca43699
AS
65012012-02-13 Andreas Schwab <schwab@linux-m68k.org>
6502
6503 * gnutls.c (emacs_gnutls_write): Fix last change.
6504
2e8f3c56
LI
65052012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
6506
6507 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
6508 send_process.
6509
af70074f
SM
65102012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
6511
6512 * keymap.c (Fsingle_key_description): Handle char ranges.
6513
95986d52
CY
65142012-02-12 Chong Yidong <cyd@gnu.org>
6515
afd83bd1
CY
6516 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
6517 as that creates a dangerous corner case.
6518
95986d52
CY
6519 * window.c (Fdelete_window_internal): Invalidate the mouse
6520 highlight (Bug#9904).
6521
bd7da63e
GM
65222012-02-12 Glenn Morris <rgm@gnu.org>
6523
6524 * xselect.c (Fx_own_selection_internal)
6525 (Fx_get_selection_internal, Fx_disown_selection_internal)
6526 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
6527 * nsselect.m (Fx_own_selection_internal)
6528 (Fx_disown_selection_internal, Fx_selection_exists_p)
6529 (Fx_selection_owner_p, Fx_get_selection_internal):
6530 Sync docs and argument specs with the xselect.c versions.
6531
77abcbc2
LI
65322012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
6533
6534 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
6535
90b671e2
EZ
65362012-02-11 Eli Zaretskii <eliz@gnu.org>
6537
1c0ca0b7
EZ
6538 * w32select.c (Fx_selection_exists_p): Sync doc string and
6539 argument list with xselect.c. (Bug#10783)
6540
6541 * w16select.c (Fx_selection_exists_p): Sync doc string and
6542 argument list with xselect.c. (Bug#10783)
90b671e2 6543
49241268
GM
65442012-02-10 Glenn Morris <rgm@gnu.org>
6545
6546 * fns.c (Fsecure_hash): Doc fix.
6547
f998bbe7 65482012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
6549
6550 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
6551
0992bd9c
CY
65522012-02-07 Chong Yidong <cyd@gnu.org>
6553
6554 * buffer.c (Fbuffer_local_variables)
6555 (buffer_lisp_local_variables): Handle unbound vars correctly;
6556 don't let Qunbound leak into Lisp.
6557
af008560
GM
65582012-02-07 Glenn Morris <rgm@gnu.org>
6559
dd605cc4
GM
6560 * image.c (Fimagemagick_types): Doc fix.
6561
af008560
GM
6562 * image.c (imagemagick-render-type): Change it from a lisp object
6563 to an integer. Move the doc here from the lisp manual.
6564 Treat all values not equal to 0 the same.
6565
1449fa1d
CY
65662012-02-06 Chong Yidong <cyd@gnu.org>
6567
6568 * doc.c (store_function_docstring): Avoid applying docstring of
6569 alias to base function (Bug#2603).
6570
3723ec07
AS
65712012-02-04 Andreas Schwab <schwab@linux-m68k.org>
6572
6573 * .gdbinit (pp1, pv1): Remove redundant defines.
6574 (pr): Use pp.
6575
79c1cc1e
CY
65762012-02-04 Chong Yidong <cyd@gnu.org>
6577
6578 * nsterm.m: Declare a global (Bug#10694).
6579
d7f29f8e
EZ
65802012-02-04 Eli Zaretskii <eliz@gnu.org>
6581
cae07000
SM
6582 * w32.c (get_emacs_configuration_options):
6583 Include --enable-checking, if specified, in the return value.
d7f29f8e 6584
3b95a6f9
MR
65852012-02-04 Martin Rudalics <rudalics@gmx.at>
6586
6587 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
6588 after rounding frame sizes. (Bug#9723)
6589
d6fa96a6
EZ
65902012-02-04 Eli Zaretskii <eliz@gnu.org>
6591
6592 * keyboard.c (adjust_point_for_property): Don't position point
6593 before BEGV. (Bug#10696)
6594
df0b2940
PE
65952012-02-03 Paul Eggert <eggert@cs.ucla.edu>
6596
6597 Handle overflow when computing char display width (Bug#9496).
6598 * character.c (char_width): Return EMACS_INT, not int.
6599 (char_width, c_string_width): Check for overflow when
6600 computing the width; this is possible now that individual
6601 characters can have unbounded width. Problem introduced
6602 by merge from Emacs 23 on 2012-01-19.
6603
6bee44d6
MA
66042012-02-02 Michael Albinus <michael.albinus@gmx.de>
6605
6606 * dbusbind.c (Fdbus_register_method): Mention the return value
6607 :ignore in the docstring.
6608
44f92739
GM
66092012-02-02 Glenn Morris <rgm@gnu.org>
6610
1b9f60cc
GM
6611 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
6612
44f92739
GM
6613 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6614 Unconditionally set to t. (Bug#10673)
6615 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6616 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
6617 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
6618
c5d3843c
KH
66192012-02-02 Kenichi Handa <handa@m17n.org>
6620
6621 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
6622 0, do not call append_composite_glyph.
6623
159462d4 66242012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
6625
6626 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
6627 NULL (Bug#6988).
6628 (x_produce_glyphs): If the component of a composition is a null
6629 string, set it->pixel_width to 1 to avoid zero-width glyph.
6630
78cef877
EZ
66312012-02-01 Eli Zaretskii <eliz@gnu.org>
6632
6633 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
6634 first 2 arguments are identical. This makes inserting large
6635 output from a subprocess an order of magnitude faster on
6636 MS-Windows, where all sbrk'ed memory is always contiguous.
6637
97897668
GM
66382012-01-31 Glenn Morris <rgm@gnu.org>
6639
6640 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 6641 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
6642 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
6643
31fd3586
GM
66442012-01-29 Glenn Morris <rgm@gnu.org>
6645
6646 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
6647
0e24a8b2
CY
66482012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
6649
6650 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
6651
cc0adcb0
CY
66522012-01-28 Chong Yidong <cyd@gnu.org>
6653
6654 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
6655
acc28cb9
CY
66562012-01-26 Chong Yidong <cyd@gnu.org>
6657
9c69cfb7
CY
6658 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
6659
acc28cb9
CY
6660 * search.c (Fsearch_forward, Fsearch_backward): Document negative
6661 repeat counts (Bug#10507).
6662
48da7392
GM
66632012-01-26 Glenn Morris <rgm@gnu.org>
6664
6665 * lread.c (syms_of_lread): Doc fix.
6666
14af5f7f
CY
66672012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
6668
6669 * coding.c (encode_designation_at_bol): Change return value to
6670 EMACS_INT.
6671
0b21c100
CY
66722012-01-25 Chong Yidong <cyd@gnu.org>
6673
6674 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
6675
3c2907f7
CY
66762012-01-21 Chong Yidong <cyd@gnu.org>
6677
6678 * floatfns.c (Fcopysign): Make the second argument non-optional,
6679 since nil is not allowed anyway.
6680
959ad23f
AS
66812012-01-21 Andreas Schwab <schwab@linux-m68k.org>
6682
6683 * process.c (read_process_output): Use p instead of XPROCESS (proc).
6684 (send_process): Likewise.
6685
34a02f46
MR
66862012-01-19 Martin Rudalics <rudalics@gmx.at>
6687
6688 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
6689 (Vwindow_persistent_parameters): Do not use Qstate.
6690 Rewrite doc-strings.
34a02f46 6691
1259009a 66922012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
6693
6694 * character.c (char_width): New function.
70d4fdf6
GM
6695 (Fchar_width, c_string_width, lisp_string_width):
6696 Use char_width (Bug#9496).
25ed9e61 6697
6a6ee00d
MR
66982012-01-16 Martin Rudalics <rudalics@gmx.at>
6699
6700 * window.c (Vwindow_persistent_parameters): New variable.
6701 (Fset_window_configuration, save_window_save): Handle persistent
6702 window parameters.
6703
c85efaf7
EZ
67042012-01-14 Eli Zaretskii <eliz@gnu.org>
6705
6706 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
6707 thrashing the stack of the thread. (Bug#9087)
6708
5944709e
PE
67092012-01-12 Paul Eggert <eggert@cs.ucla.edu>
6710
6711 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
6712
e71f5d99
EZ
67132012-01-11 Eli Zaretskii <eliz@gnu.org>
6714
6715 * xdisp.c (rows_from_pos_range): Handle the case where the
6716 highlight ends on a newline. (Bug#10464)
6717 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
6718 he end column for display of highlight that ends on a newline
6719 before a R2L line.
6720
ce316182
GM
67212012-01-11 Glenn Morris <rgm@gnu.org>
6722
6723 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
6724 from load-path also when installation-directory is nil. (Bug#10208)
6725
5b43da69
GM
67262012-01-10 Glenn Morris <rgm@gnu.org>
6727
74cc8ff9
GM
6728 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
6729
7d8d6e4e
GM
6730 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
6731 Update template values to be closer to their typical values these days.
5b43da69 6732
a0db8d43
EZ
67332012-01-09 Eli Zaretskii <eliz@gnu.org>
6734
6735 * xdisp.c (rows_from_pos_range): Accept additional argument
6736 DISP_STRING, and accept any glyph in a row whose object is that
6737 string as eligible for mouse highlight. Fixes mouse highlight of
6738 display strings from overlays. (Bug#10464)
6739
9a0115ab 67402012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 6741
b9110d6a 6742 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
6743 * fileio.c (auto_saving_dir_umask): New static var.
6744 (Fmake_directory_internal): Use it.
6745 (do_auto_save_make_dir): Set it, instead of invoking chmod after
6746 creating the directory. The old code temporarily assigns
6747 too-generous permissions to the directory.
6748 (do_auto_save_eh): Clear it.
b9110d6a 6749 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
6750 that the var is always cleared.
6751
6c1bd3f3
EZ
67522012-01-07 Eli Zaretskii <eliz@gnu.org>
6753
6754 * search.c (scan_buffer): Pass character positions to
6755 know_region_cache, not byte positions. (Bug#6540)
6756
069d2b50
L
67572012-01-07 LynX <_LynX@bk.ru> (tiny change)
6758
6759 * w32.c (sys_rename): Report EXDEV when rename of a directory
6760 fails because the target is on another logical disk. (Bug#10284)
6761
75bf0d33
DB
67622012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
6763
6764 * xterm.c (x_embed_request_focus): New function.
6765
6766 * xterm.h: Add prototype.
6767
6768 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
6769
1c6e5a32
GM
67702012-01-05 Glenn Morris <rgm@gnu.org>
6771
6772 * emacs.c (emacs_copyright): Update short copyright year to 2012.
6773
651e947e
EZ
67742012-01-01 Eli Zaretskii <eliz@gnu.org>
6775
6776 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
6777 Load gnutls_transport_set_lowat only if GnuTLS version is below
6778 2.11.1.
6779 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
6780 GnuTLS versions below 2.11.1.
6781
3778cdd8
AL
67822011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
6783
6784 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
6785 to the doc string advising against its use for altering the way
6786 windows are scrolled.
6787
0e5317f7
KH
67882011-12-28 Kenichi Handa <handa@m17n.org>
6789
6790 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
6791 coding-system ASCII compatible only when it does not produce BOM
6792 on encoding (Bug#10383).
6793
93d5ca1f
JD
67942011-12-26 Jan Djärv <jan.h.d@swipnet.se>
6795
6796 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
6797 can scroll.
6798 (create_and_show_popup_menu): Always use menu_position_func for
6799 Gtk3 (Bug#10361).
6800
ca22b785
AS
68012011-12-24 Andreas Schwab <schwab@linux-m68k.org>
6802
6803 * callint.c (Fcall_interactively): Don't truncate prompt string.
6804
d048e1e6
EZ
68052011-12-23 Eli Zaretskii <eliz@gnu.org>
6806
6807 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
6808 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 6809 resumed from there (after widening). (Bug#10360)
d048e1e6 6810
5ccaba1f
JD
68112011-12-22 Jan Djärv <jan.h.d@swipnet.se>
6812
6813 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
6814
204ee57f
JD
68152011-12-21 Jan Djärv <jan.h.d@swipnet.se>
6816
b81d40f0
JB
6817 * nsterm.m (x_free_frame_resources):
6818 Release f->output_data.ns->miniimage.
204ee57f
JD
6819 (ns_index_color): Fix indentation. Do not retain
6820 color_table->colors[i].
6821
6822 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
6823 before returning.
6824
6825 * nsfns.m (x_set_background_color): Assign return value from
6826 ns_index_color to face-background instead of NSColor*.
6827 (ns_implicitly_set_icon_type): Fix indentation.
6828 Change assignment in for loop to comparison.
6829
6830 * emacs.c (ns_pool): New variable.
6831 (main): Assign ns_pool.
6832 (Fkill_emacs): Call ns_release_autorelease_pool.
6833
6834 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
6835 autorelease fdesc, release fdAttrs and tdict.
6836 (ns_get_covering_families): Release charset.
6837 (ns_findfonts): Release NSFontDescriptor created with new.
6838 (ns_uni_to_glyphs): Fix indentation.
6839 (setString): Release attrStr before assigning new value.
6840
c803b2b7
JD
68412011-12-18 Jan Djärv <jan.h.d@swipnet.se>
6842
678f4426
JD
6843 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
6844 and NS_IMPL_COCOA.
6845 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
6846 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
6847
cd394be1 68482011-12-18 David Reitter <reitter@cmu.edu>
678f4426 6849
5fecd5fc
JD
6850 * nsterm.m (ns_term_init): Subscribe for notifications
6851 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
6852 to method trackingNotification in EmacsMenu.
6853
6854 * nsmenu.m (trackingMenu): New variable.
3771cb17 6855 (trackingNotification): New method (from Aquamacs).
5fecd5fc 6856 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 6857 from Aquamacs (Bug#7030).
678f4426
JD
6858
68592011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 6860
c803b2b7
JD
6861 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
6862 (symbol_to_nsstring): Fix indentation.
6863 (ns_symbol_to_pb): New function.
cae07000
SM
6864 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
6865 (Fns_rotate_cut_buffers_internal): Remove.
6866 (Fns_store_selection_internal): Rename from
c803b2b7
JD
6867 Fns_store_cut_buffer_internal.
6868 (ns_get_foreign_selection, Fx_own_selection_internal)
6869 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
6870 (Fns_get_selection_internal, Fns_store_selection_internal):
6871 Use ns_symbol_to_pb and check if return value is nil.
6872 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
6873 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
6874 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
6875 renamed to Sns_store_selection_internal.
6876 (ns_handle_selection_request): Move code to Fx_own_selection_internal
6877 and remove this function.
6878 (ns_handle_selection_clear): Remove, never used.
6879 (Fx_own_selection_internal): Move code from ns_handle_selection_request
6880 here.
6881
e1b01a3a
KB
68822011-12-17 Ken Brown <kbrown@cornell.edu>
6883
6884 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
6885 GID is unknown (Bug#10257).
6886
2adb6e85
PE
68872011-12-17 Paul Eggert <eggert@cs.ucla.edu>
6888
6889 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
6890 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
6891 which caused a build failure on GNU/Linux IA-64. This problem was
6892 introduced by my 2011-10-07 patch.
6893
d1d7b339
JL
68942011-12-15 Juri Linkov <juri@jurta.org>
6895
6896 * image.c (imagemagick_error): New function. (Bug#10112)
6897 (imagemagick_load_image): Comment out `MagickSetResolution' call.
6898 Use `imagemagick_error' where ImageMagick functions return
6899 `MagickFalse'.
6900 (Fimagemagick_types): Add `Fnreverse' to return the list in the
6901 proper order.
6902
100d5755
KH
69032011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6904
6905 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
6906 fill background (Bug#8992).
6907
454592a6
MR
69082011-12-13 Martin Rudalics <rudalics@gmx.at>
6909
6910 * window.c (Vwindow_combination_resize)
6911 (Vwindow_combination_limit): Use t instead of non-nil in
6912 doc-strings.
61d4b438
MR
6913 (Vrecenter_redisplay): Add first sentence of doc-string on
6914 separate line.
53524d93 6915 (Frecenter): Fix doc-string typo.
454592a6 6916
3633e3aa
KH
69172011-12-11 Kenichi Handa <handa@m17n.org>
6918
6919 * coding.c (Funencodable_char_position): Pay attention to the
6920 buffer text relocation (Bug#9389).
6921
7b9d523a 69222011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 6923
7b9d523a
JD
6924 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
6925 gtk_init (Bug#10100).
6926
b73189c6
EZ
69272011-12-10 Eli Zaretskii <eliz@gnu.org>
6928
6929 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
6930 IT->string is nil. (Bug#10263)
6931
f7dfe5d6
JD
69322011-12-10 Jan Djärv <jan.h.d@swipnet.se>
6933
83faebb4
JD
6934 * nsterm.h (x_free_frame_resources): Declare.
6935
f7dfe5d6
JD
6936 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
6937 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
6938
6939 * nsterm.h (ns_get_defaults_value): Declare.
6940
6941 * nsterm.m (ns_default): Call ns_get_defaults_value.
6942
7cd4e72c
EZ
69432011-12-09 Eli Zaretskii <eliz@gnu.org>
6944
6945 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
6946 (Bug#10170)
6947
b34d7317
YM
69482011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6949
6950 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
6951 that where the value of an _OBJC_* symbol points to is in the .bss
6952 section (Bug#10240).
6953
76470ad1
KH
69542011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6955
6956 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 6957 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 6958
745fff94
KH
69592011-12-08 Kenichi Handa <handa@m17n.org>
6960
6961 * ftfont.c (get_adstyle_property): Fix previous change
6962 (Bug#10233).
6963
6e44397c
JB
69642011-12-07 Juanma Barranquero <lekktu@gmail.com>
6965
6966 * w32.c (init_environment): If no_site_lisp, remove site-lisp
6967 dirs from the default value of EMACSLOADPATH (bug#10208).
6968
7efa6272
GM
69692011-12-07 Glenn Morris <rgm@gnu.org>
6970
6971 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
6972 installation and source directories as well. (Bug#10208)
6973
f6fc4d87
CY
69742011-12-06 Chong Yidong <cyd@gnu.org>
6975
6976 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
6977
2bf26180
GM
69782011-12-06 Glenn Morris <rgm@gnu.org>
6979
6980 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
6981 as an error, not just -1. (Bug#10217)
6982
3a6ad4f0
CY
69832011-12-05 Chong Yidong <cyd@gnu.org>
6984
6985 * keyboard.c (process_special_events): New function.
6986 (swallow_events, Finput_pending_p): Use it (Bug#10195).
6987
75a3b399
PE
69882011-12-05 Paul Eggert <eggert@cs.ucla.edu>
6989
6990 * coding.c (encode_designation_at_bol): Don't use uninitialized
6991 local variable (Bug#9318).
6992
c3c9e25e
KH
69932011-12-05 Kenichi Handa <handa@m17n.org>
6994
6995 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
6996 return Qnil (Bug#8046, Bug#10193).
6997
5eb05ea3
KH
69982011-12-05 Kenichi Handa <handa@m17n.org>
6999
7000 * coding.c (encode_designation_at_bol): New args charbuf_end and
7001 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
7002 (coding_set_source): Return how many bytes coding->source was
7003 relocated.
7004 (coding_set_destination): Return how many bytes
7005 coding->destination was relocated.
7006 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 7007 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
7008
70092011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
7010
7011 * coding.c (CODING_CHAR_CHARSET_P): New macro.
7012 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
7013 macro (Bug#9318).
7014
70152011-12-05 Andreas Schwab <schwab@linux-m68k.org>
7016
7017 The following changes are to fix Bug#9318.
7018
a79703f5 7019 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
7020 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
7021 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 7022 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 7023
7dbda6df
JB
70242011-12-05 Juanma Barranquero <lekktu@gmail.com>
7025
7026 * lisp.h (process_quit_flag): Fix external declaration.
7027
6d5eb5b0
SM
70282011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
7029
7030 Don't macro-inline non-performance-critical code.
7031 * eval.c (process_quit_flag): New function.
7032 * lisp.h (QUIT): Use it.
7033
a0c3fad0
JD
70342011-12-04 Jan Djärv <jan.h.d@swipnet.se>
7035
7036 * nsfns.m (get_geometry_from_preferences): New function.
7037 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
7038
6c07aac2
AS
70392011-12-04 Andreas Schwab <schwab@linux-m68k.org>
7040
7041 * emacs.c (Qkill_emacs): Define.
7042 (syms_of_emacs): Initialize it.
7043 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
7044 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
7045 (quit_throw_to_read_char): Add parameter `from_signal'.
7046 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
7047 * lisp.h (QUIT): Call Fkill_emacs if requested.
7048
c052ead4
JD
70492011-12-03 Jan Djärv <jan.h.d@swipnet.se>
7050
7051 * widget.c (update_wm_hints): Return if wmshell is null.
7052 (widget_update_wm_size_hints): New function.
7053
7054 * widget.h (widget_update_wm_size_hints): Declare.
7055
7056 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
7057 widget_update_wm_size_hints (Bug#10104).
7058
9e49252b
EZ
70592011-12-03 Eli Zaretskii <eliz@gnu.org>
7060
7061 * xdisp.c (handle_invisible_prop): If the invisible text ends just
7062 before a newline, prepare the bidi iterator for consuming the
7063 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 7064 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 7065
02b16839
JL
70662011-12-02 Juri Linkov <juri@jurta.org>
7067
7068 * search.c (Fword_search_regexp): New Lisp function created from
7069 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
7070 (Fword_search_backward, Fword_search_forward)
7071 (Fword_search_backward_lax, Fword_search_forward_lax):
7072 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
7073 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
7074
0068070e
SM
70752011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
7076
7077 * fileio.c (Finsert_file_contents): Move after-change-function call
7078 to before the "handled:" label, since all "goto handled" appear in
7079 cases where the *-change-functions have already been properly called
7080 (bug#10117).
7081
3360a3fc
AS
70822011-12-01 Andreas Schwab <schwab@linux-m68k.org>
7083
7084 * keyboard.c (interrupt_signal): Don't call kill-emacs when
7085 waiting for input. (Bug#10169)
7086
73d6c093
EZ
70872011-11-30 Eli Zaretskii <eliz@gnu.org>
7088
7089 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
7090 verifies glyph row's hash code--we have just reallocated the
7091 glyphs, so their contents can be complete garbage. (Bug#10164)
7092
febe6bea
JB
70932011-11-30 Juanma Barranquero <lekktu@gmail.com>
7094
7095 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
7096
801a4313
EZ
70972011-11-30 Eli Zaretskii <eliz@gnu.org>
7098
7099 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
7100 attributes are tested _before_ calling verify_row_hash, to protect
7101 against GCC re-ordering of the tests. (Bug#10164)
7102
2b56b87e
JD
71032011-11-29 Jan Djärv <jan.h.d@swipnet.se>
7104
7105 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
7106
7107 * xterm.c (handle_one_xevent): Only set async_visible and friends
7108 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 7109 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
7110 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
7111
dbf31225
PE
71122011-11-28 Paul Eggert <eggert@cs.ucla.edu>
7113
7114 Remove GCPRO-related macros that exist only to avoid shadowing locals.
7115 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
7116 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
7117 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
7118 All uses changed to use GCPRO1 etc.
7119 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
7120 Revert to old implementation (i.e., before 2011-03-11).
7121
1305621b
YM
71222011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7123
7124 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
7125 of scroll runs so as to avoid assigning disabled bogus rows and
7126 unnecessary graphics copy operations.
7127
8c9afb46
EZ
71282011-11-27 Eli Zaretskii <eliz@gnu.org>
7129
7130 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
7131 (snprintf) [_MSC_VER]: Redirect to _snprintf.
7132 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
7133 (malloc, free, realloc, calloc): Redirect to e_* only when
7134 compiling Emacs.
7135
7136 * lisp.h (GCTYPEBITS): Move before first use.
7137 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
7138 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
7139 this macro definition.
7140
7141 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
7142 _MSC_VER.
7143
54e9e3bf
JD
71442011-11-27 Jan Djärv <jan.h.d@swipnet.se>
7145
6d5eb5b0
SM
7146 * gtkutil.c (xg_create_frame_widgets):
7147 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
7148 present with Gtk+ 2.0.
7149
83aca1cb
PE
71502011-11-26 Paul Eggert <eggert@cs.ucla.edu>
7151
7152 * fileio.c (Finsert_file_contents): Undo previous change; see
7153 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
7154
5b76caa4
PE
71552011-11-26 Paul Eggert <eggert@cs.ucla.edu>
7156
7157 Rename locals to avoid shadowing.
7158 * fileio.c (Finsert_file_contents):
7159 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
7160 * process.c (wait_reading_process_output):
7161 Rename inner 'proc' to 'p' to avoid shadowing.
7162 Indent for consistency with usual Emacs style.
7163
8c535114
EZ
71642011-11-25 Eli Zaretskii <eliz@gnu.org>
7165
7166 * xdisp.c (redisplay_window): If cursor row is not fully visible
7167 after recentering, and scroll-conservatively is set to a large
7168 number, scroll window by a few more lines to make the cursor fully
7169 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
7170 (start_display): Don't move to the next line if the display should
7171 start at a newline that is part of a display vector or an overlay
7172 string. (Bug#10119)
8c535114 7173
fa4fdb5c
JL
71742011-11-24 Juri Linkov <juri@jurta.org>
7175
7176 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
7177 after the `MagickPingImage' call. (Bug#10112)
7178
90ec88df
CY
71792011-11-23 Chong Yidong <cyd@gnu.org>
7180
7181 * window.c (Fcoordinates_in_window_p): Accept only live windows.
7182
56e2e794
MR
71832011-11-23 Martin Rudalics <rudalics@gmx.at>
7184
7185 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
7186 making another buffer current. (Bug#10114)
7187
b6e64c41
GM
71882011-11-23 Glenn Morris <rgm@gnu.org>
7189
7190 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
7191
6b21de18
CY
71922011-11-23 Chong Yidong <cyd@gnu.org>
7193
7194 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
7195 using it (Bug#5984).
7196
b12cd789
EZ
71972011-11-22 Eli Zaretskii <eliz@gnu.org>
7198
7199 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
7200 and header-lines, as they don't have one computed for them.
7201 (Bug#10098)
7202
7203 * .gdbinit (prow): Make displayed values more self-explaining.
7204 Add row's hash code.
7205
261b6fd4
LMI
72062011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
7207
7208 * process.c (wait_reading_process_output): Fix asynchrounous
7209 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 7210 (wait_reading_process_output): Add comment and URL.
261b6fd4 7211
e7cfd277
JD
72122011-11-21 Jan Djärv <jan.h.d@swipnet.se>
7213
7214 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
7215
a9b9b7f5
CY
72162011-11-21 Chong Yidong <cyd@gnu.org>
7217
7218 * window.c (Fnext_window, Fprevious_window): Doc fix.
7219
b0d15b4f
SM
72202011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
7221
7222 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
7223
fe7a3057
JB
72242011-11-20 Juanma Barranquero <lekktu@gmail.com>
7225
7226 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
7227
d2999b1a
MR
72282011-11-20 Martin Rudalics <rudalics@gmx.at>
7229
7230 * window.c (Fset_window_combination_limit): Rename argument
7231 STATUS to LIMIT.
7232 (Vwindow_combination_limit): Remove "status" from doc-string.
7233
d5ff9cd0
AS
72342011-11-20 Andreas Schwab <schwab@linux-m68k.org>
7235
7236 * m/ibms390.h: Remove.
7237 * m/ibms390x.h: Don't include "ibms390.h".
7238
a5bb9bd3
SM
72392011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
7240
7241 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
7242 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
7243
cd1181db
JB
72442011-11-20 Juanma Barranquero <lekktu@gmail.com>
7245
7246 * casetab.c (Fset_case_table):
7247 * charset.c (Fcharset_after): Fix typos.
7248
615a3b8d 72492011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 7250
17e845af
PE
7251 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
7252 Otherwise, valgrind does not work on some platforms.
7253 Problem reported by Andreas Schwab in
6a0bf43d
PE
7254 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
7255 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
7256 is set, removing the need for VIRT_ADDRESS_VARIES.
7257 (PURE_P): Use a more-efficient implementation that needs just one
7258 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
7259 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
7260 to 4 (xorl, subq, cmpq, setbe).
7261 * alloc.c (pure): Always extern now, since that's the
7262 VIRT_ADDR_VARIES behavior.
7263 (PURE_POINTER_P): Use a single comparison, not two, for
7264 consistency with the new puresize.h.
7265 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
7266 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
7267 Remove VIRT_ADDR_VARIES no longer needed.
7268
f8fe6f96
EZ
72692011-11-19 Eli Zaretskii <eliz@gnu.org>
7270
7271 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
7272 (erase_phys_cursor, update_window_cursor, show_mouse_face)
7273 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
7274 behave as if the cursor position were at the window margin.
7275
7276 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
7277 and the cursor position is out of bounds, behave as if the cursor
7278 position were at the window margin. (Bug#10075)
7279
df05a53c
CY
72802011-11-18 Chong Yidong <cyd@gnu.org>
7281
7282 * window.c (Fwindow_combination_limit): Make first argument
7283 non-optional, since it is meaningless for live windows like the
7284 selected window.
61ccba97 7285
2071918e
DA
72862011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
7287
7288 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
7289
b50a28de
SM
72902011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
7291
7292 * intervals.c: Fix grafting over the whole buffer (bug#10071).
7293 (graft_intervals_into_buffer): Simplify.
7294
015137db
EZ
72952011-11-18 Eli Zaretskii <eliz@gnu.org>
7296
7297 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
7298 hash values of the two rows.
7299 (copy_row_except_pointers): Preserve the used[] arrays and the
7300 hash values of the two rows. (Bug#10035)
68c95424 7301 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
7302
7303 * xdisp.c (row_hash): New function, body extracted from
7304 compute_line_metrics.
7305 (compute_line_metrics): Call row_hash, instead of computing the
7306 hash code inline.
7307
7308 * dispnew.c (verify_row_hash): Call row_hash for computing the
7309 hash code of a row, instead of duplicating code from xdisp.c.
7310
7311 * dispextern.h (row_hash): Add prototype.
7312
a2addb04
TH
73132011-11-18 Tassilo Horn <tassilo@member.fsf.org>
7314
7315 * frame.c (delete_frame): Don't delete the terminal when the last
7316 X frame is closed if emacs is built with GTK toolkit.
7317
df85d315
JB
73182011-11-17 Juanma Barranquero <lekktu@gmail.com>
7319
7320 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
7321
a0c2d0ae
MR
73222011-11-17 Martin Rudalics <rudalics@gmx.at>
7323
7324 * window.c (Vwindow_splits): Rename to
7325 Vwindow_combination_resize. Suggested by Juri Linkov.
7326 (Fsplit_window_internal): Use Vwindow_combination_resize instead
7327 of Vwindow_splits.
7328
58179cce
JB
73292011-11-16 Juanma Barranquero <lekktu@gmail.com>
7330
7877f373
JB
7331 * nsfns.m (Fns_font_name):
7332 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 7333
b6f67890
MR
73342011-11-16 Martin Rudalics <rudalics@gmx.at>
7335
7336 * window.h (window): Rename slot "nest" to "combination_limit".
7337 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
7338 (Fset_window_nest): Rename to Fset_window_combination_limit.
7339 (Vwindow_nest): Rename to Vwindow_combination_limit.
7340 (recombine_windows, make_parent_window, make_window)
7341 (Fsplit_window_internal, saved_window)
7342 (Fset_window_configuration, save_window_save): Rename all
7343 occurrences of window_nest to window_combination_limit.
7344
c7015153
JB
73452011-11-15 Juanma Barranquero <lekktu@gmail.com>
7346
7347 * image.c (imagemagick_load_image): Fix typo.
7348
322ad6ec
EZ
73492011-11-14 Eli Zaretskii <eliz@gnu.org>
7350
7351 * xdisp.c (display_line): Move the call to
7352 highlight_trailing_whitespace before the call to
7353 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
7354 faces of all the glyphs to compute ROW's hash value.
7355 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 7356
f067b8ec
JB
73572011-11-14 Juanma Barranquero <lekktu@gmail.com>
7358
7359 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
7360 just return (bug#10044).
7361
1e5b2111
EZ
73622011-11-12 Eli Zaretskii <eliz@gnu.org>
7363
7ef3cbd5
EZ
7364 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
7365 with user-defined heap size. Bump the default size of the temacs
7366 heap to 27MB, to avoid memory warning when running temacs.
7367 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
7368
1e5b2111
EZ
7369 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
7370 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
7371 (verify_row_hash) [XASSERTS]: New function.
7372 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
7373 that the hash value of glyph rows is correct.
1e5b2111 7374
89d61221
MR
73752011-11-12 Martin Rudalics <rudalics@gmx.at>
7376
7377 * window.h (window): Remove splits slot.
7378 * window.c (Fwindow_splits, Fset_window_splits): Remove.
7379 (Fdelete_other_windows_internal, make_parent_window)
7380 (make_window, Fsplit_window_internal, Fdelete_window_internal)
7381 (Fset_window_configuration, save_window_save): Don't deal with
7382 split status of windows.
7383 (saved_window): Remove splits slot.
7384 (Vwindow_splits): Rewrite doc-string.
7385
97f18cc8
JD
73862011-11-11 Jan Djärv <jan.h.d@swipnet.se>
7387
7388 * xfns.c (unwind_create_frame):
7389 * nsfns.m (unwind_create_frame):
7390 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
7391 Vframe_list (Bug#9999).
7392
22a648b4
DA
73932011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
7394
0b381c7e 7395 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 7396
659afede
KH
73972011-11-11 Kenichi Handa <handa@m17n.org>
7398
7399 * callproc.c (Fcall_process): Set the member dst_multibyte of
7400 process_coding.
7401
9ac0394b
KH
74022011-11-11 Johan Bockgård <bojohan@gnu.org>
7403
7404 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
7405 avoid a crash (bug#9496).
7406
2fbdc249
CY
74072011-11-09 Chong Yidong <cyd@gnu.org>
7408
7409 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
7410 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
7411
ac6b1f81
PE
74122011-11-08 Paul Eggert <eggert@cs.ucla.edu>
7413
7414 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
7415
09db192c
PE
74162011-11-08 Paul Eggert <eggert@cs.ucla.edu>
7417
7418 Avoid some portability problems by eschewing 'extern inline' functions.
7419 The trivial performance wins aren't worth the portability hassles; see
7420 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
7421 et seq.
7422 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
7423 (window_box_width, window_box_left, window_box_left_offset)
7424 (window_box_right, window_box_right_offset): Undo previous change,
7425 by removing the "extern"s.
7426 * intervals.c (adjust_intervals_for_insertion)
7427 (adjust_intervals_for_deletion): Undo previous change,
7428 making these static again.
7429 (offset_intervals, temp_set_point_both, temp_set_point)
7430 (copy_intervals_to_string): No longer inline.
7431 * xdisp.c (window_text_bottom_y, window_box_width)
7432 (window_box_height, window_box_left_offset)
7433 (window_box_right_offset, window_box_left, window_box_right)
7434 (window_box): No longer inline.
7435
105216ed
CY
74362011-11-08 Chong Yidong <cyd@gnu.org>
7437
7438 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
7439 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
7440 Signal an error if not a live window.
105216ed
CY
7441 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
7442 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
7443
ae9e237f
JB
74442011-11-07 Juanma Barranquero <lekktu@gmail.com>
7445
7446 * lisp.h (syms_of_abbrev): Remove declaration.
7447 Reported by CHENG Gao <chenggao@royau.me>.
7448
c7aa8333
EZ
74492011-11-07 Eli Zaretskii <eliz@gnu.org>
7450
7451 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
7452 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
7453 of temacs in GUI mode.
7454
be7f5545
MR
74552011-11-07 Martin Rudalics <rudalics@gmx.at>
7456
7457 * window.h: Declare delete_all_child_windows instead of
7458 delete_all_subwindows.
7459 * window.c (Fwindow_nest, Fset_window_nest)
7460 (Fset_window_new_total, Fset_window_new_normal)
7461 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
7462 (delete_all_subwindows): Rename to delete_all_child_windows.
7463 (Fdelete_other_windows_internal, Fset_window_configuration):
7464 Call delete_all_child_windows instead of delete_all_subwindows.
7465 * frame.c (delete_frame): Call delete_all_child_windows instead
7466 of delete_all_subwindows.
7467
ca78dc43
PE
74682011-11-07 Paul Eggert <eggert@cs.ucla.edu>
7469
7470 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
7471 This is also needed for porting to any host where GC_MARK_STACK is
7472 not GC_MAKE_GCPROS_NOOPS.
7473 (which_symbols): Use it.
7474
a0241d01
KH
74752011-11-07 Kenichi Handa <handa@m17n.org>
7476
7477 * coding.c (coding_set_destination): Check coding->src_pos only
7478 when coding->src_object is a buffer (bug#9910).
7479
7480 * process.c (send_process): Set the member src_multibyte of coding
7481 to 0 (bug#9911) when sending a unibyte text.
7482
7483 * callproc.c (Fcall_process): Set the member src_multibyte of
7484 process_coding to 0 (bug#9912).
7485
a64bfdfa 74862011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
7487
7488 * xmenu.c (cleanup_widget_value_tree): New function.
7489 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
7490 calling free_menubar_widget_value_tree directly (Bug#9830).
7491
cb41b32a
PE
74922011-11-06 Paul Eggert <eggert@cs.ucla.edu>
7493
7494 Fix some portability problems with 'inline'.
7495 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
7496 (window_box_width, window_box_left, window_box_left_offset)
7497 (window_box_right, window_box_right_offset): Declare extern.
7498 Otherwise, these inline functions do not conform to C99 and
7499 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
7500 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
7501 * intervals.c (adjust_intervals_for_insertion)
7502 (adjust_intervals_for_deletion): Now extern, because otherwise the
7503 extern inline functions 'offset_intervals' couldn't refer to it.
7504 (static_offset_intervals): Remove.
7505 (offset_intervals): Rewrite using the old contents of
7506 static_offset_intervals. The old version didn't conform to C99
7507 because an extern inline function contained a reference to an
7508 identifier with static linkage.
7509
b7041366
AS
75102011-11-06 Andreas Schwab <schwab@linux-m68k.org>
7511
7512 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
7513 GC.
7514
88a37c4d
EZ
75152011-11-06 Eli Zaretskii <eliz@gnu.org>
7516
7517 * xdisp.c (init_iterator, reseat_to_string): Don't set the
7518 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
7519 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
7520 return Qleft_to_right.
7521
49745b39
CY
75222011-11-06 Chong Yidong <cyd@gnu.org>
7523
7524 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
7525 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
7526 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
7527 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
7528 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
7529 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
7530 (Fwindow_vscroll): Doc fix.
7531 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
7532 argument, since it makes no sense to pass a live window and for
7533 consistency with window-child.
7534
1f05cd82
CS
75352011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
7536
7537 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
7538 support MSVC.
7539
22610910
JR
75402011-11-05 Jason Rumney <jasonr@gnu.org>
7541
7542 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
7543 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
7544 fonts (Bug#6029).
7545 (add_font_entity_to_list): Fix logic errors in mixed boolean and
7546 bitwise arithmetic preventing use of unicode-sip and non-truetype
7547 opentype fonts.
7548
a06776b2
EZ
75492011-11-05 Eli Zaretskii <eliz@gnu.org>
7550
3ad924ba
EZ
7551 * s/ms-w32.h (fstat, stat, utime): Move redirections to
7552 "emacs"-only part.
7553
a06776b2
EZ
7554 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
7555 initialization code to keep similarity to xfns.c after changes
7556 from 2011-11-05.
7557
c9e7db78
JD
75582011-11-05 Jan Djärv <jan.h.d@swipnet.se>
7559
a97f8f3f
JD
7560 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
7561 (unwind_create_frame): New function (Bug#9943).
7562 (Fx_create_frame): Restructure code to be more similar to the one in
7563 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
7564 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
7565 Move terminal->reference_count++ just before making the frame official
7566 (Bug#9943).
7567
7568 * nsterm.m (x_free_frame_resources): New function.
7569 (x_destroy_window): Move code to x_free_frame_resources.
7570
c9e7db78 7571 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
7572 (Fx_create_frame, x_create_tip_frame):
7573 Move terminal->reference_count++ just before making the frame
75f1671a 7574 official. Move initialization of image_cache_refcount and
c9e7db78
JD
7575 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
7576
a6fc3b5c
EZ
75772011-11-05 Eli Zaretskii <eliz@gnu.org>
7578
7579 Support MSVC build with newer versions of Visual Studio.
7580 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
7581 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
7582 nt/gmake.defs.
7583
7584 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
7585 which are not supported by MSVC.
7586 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
7587 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
7588 bitfields.
7589 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
7590 types in bitfields.
7591 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
7592
7593 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
7594
58179cce 75952011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
7596
7597 Support MSVC build with newer versions of Visual Studio.
7598 * w32.c: Don't include w32api.h for MSVC.
7599 (init_environment) [_MSC_VER]: Call sys_access, not _access.
7600
7601 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
7602 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
7603 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
7604 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
7605 e_* cousins.
7606 (alloca) [_MSC_VER]: Define to _alloca.
7607
7608 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
7609
7610 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
7611
a58c13ed
EZ
76122011-11-04 Eli Zaretskii <eliz@gnu.org>
7613
7614 * xdisp.c (note_mouse_highlight): If either of
7615 previous/next-single-property-change returns nil, treat that as
7616 the beginning or the end of the buffer. (Bug#9955)
7617
fe0b6370
JD
76182011-11-04 Jan Djärv <jan.h.d@swipnet.se>
7619
a58c13ed 7620 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
7621 label is not null (Bug#9951).
7622 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
7623 may be NULL.
7624
89bd5ee1
EZ
76252011-11-04 Eli Zaretskii <eliz@gnu.org>
7626
7627 * window.c (Fwindow_body_size): Mention in the doc string that the
7628 return value is in frame's canonical units. (Bug#9949)
7629
84c3edb9
EZ
76302011-11-03 Eli Zaretskii <eliz@gnu.org>
7631
4e2fb5c7
EZ
7632 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
7633
84c3edb9 7634 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 7635 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 7636 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 7637
bc17a887
EZ
76382011-11-01 Eli Zaretskii <eliz@gnu.org>
7639
7640 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
7641 Don't stop backward scan on the continuation glyph, even though
7642 its CHARPOS is positive.
6d5eb5b0
SM
7643 (mouse_face_from_buffer_pos, note_mouse_highlight):
7644 Rename cover_string to disp_string.
bc17a887 7645
4ee88440
MR
76462011-11-01 Martin Rudalics <rudalics@gmx.at>
7647
7648 * window.c (temp_output_buffer_show): Don't use
7649 Vtemp_buffer_show_specifiers.
7650 (Vtemp_buffer_show_specifiers): Remove unused variable.
7651
c2ff3c02
EZ
76522011-10-30 Eli Zaretskii <eliz@gnu.org>
7653
7654 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
7655 past the beginning of the current glyph matrix.
7656
58179cce 76572011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
7658
7659 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
7660 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
7661 HAVE_GTK3 (Bug#9869).
b77a6a7f 7662
3b574623
JD
7663 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
7664 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
7665
b77a6a7f
JD
7666 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
7667
7668 * xterm.c: Declare x_handle_net_wm_state to return int.
7669 (handle_one_xevent): Check if we are iconified but don't have
7670 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
7671 (get_current_wm_state): Return non-zero if not hidden,
7672 check for _NET_WM_STATE_HIDDEN (Bug#9893).
7673 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
7674 (x_handle_net_wm_state): Return what get_current_wm_state returns.
7675 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
7676
196e41e4
PE
76772011-10-29 Paul Eggert <eggert@cs.ucla.edu>
7678
7679 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
7680 so that this new function doesn't get optimized away by a
7681 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
7682
021f2e1a
AS
76832011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7684
7685 * frame.h (MOUSE_HL_INFO): Remove excess parens.
7686
8b058d44
EZ
76872011-10-29 Eli Zaretskii <eliz@gnu.org>
7688
7689 Fix the `xbytecode' command.
7690 * .gdbinit (xprintbytestr): New command.
b50a28de 7691 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
7692 (xbytecode): Print the byte-code string as well.
7693
4452fb80
EZ
76942011-10-29 Kim Storm <storm@cua.dk>
7695
8b058d44
EZ
7696 * alloc.c (which_symbols): New function.
7697
21b72067
AS
76982011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7699
7700 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
7701 line. (Bug#9903)
7702
83ed7b5c
GM
77032011-10-29 Glenn Morris <rgm@gnu.org>
7704
7705 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
7706 Not clear what it was for, and it causes various bugs. (Bug#9839)
7707
5a7a728b
EZ
77082011-10-28 Eli Zaretskii <eliz@gnu.org>
7709
7710 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
7711 possible random value that matches one of those tested as
7712 condition to clear the mouse face.
7713
d3d0842f
CY
77142011-10-28 Chong Yidong <cyd@gnu.org>
7715
7716 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
7717
31b39d13
DN
77182011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
7719
7720 * window.c (make_window): Initialize phys_cursor_on_p.
7721
9aba6043
SM
77222011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
7723
7724 * lisp.h (struct Lisp_Symbol): Update comments.
7725
c20992f4
JB
77262011-10-28 Juanma Barranquero <lekktu@gmail.com>
7727
7728 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
7729
db4f02f2
EZ
77302011-10-28 Eli Zaretskii <eliz@gnu.org>
7731
7732 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
7733 <oslsachem@gmail.com> for helping to debug this.
7734
7735 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
7736 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
7737 (g_b_init_get_glyph_outline_w): New static variables.
7738 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
7739 (GetGlyphOutlineW_Proc): New typedefs.
7740 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
7741 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
7742 New functions.
7743 (w32font_open_internal, compute_metrics):
7744 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
7745 instead of calling the "wide" APIs directly.
7746
7747 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
7748
7749 * w32.h (syms_of_w32font): Add prototype.
7750
87e68db4
JB
77512011-10-27 Juanma Barranquero <lekktu@gmail.com>
7752
7753 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
7754 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
7755 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
7756 (Fmove_to_window_line): Doc fix.
7757
435c1d67
CY
77582011-10-27 Chong Yidong <cyd@gnu.org>
7759
7760 * process.c (make_process): Set gnutls_state to NULL.
7761
7762 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
7763 non-NULL, regardless of GNUTLS_INITSTAGE.
7764 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
7765 an error. Set process slots as soon as we allocate them.
7766
7767 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
7768
9c6c6f49
CY
77692011-10-27 Chong Yidong <cyd@gnu.org>
7770
9aba6043
SM
7771 * gnutls.c (emacs_gnutls_deinit): New function.
7772 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
7773 (Fgnutls_deinit, Fgnutls_boot): Use it.
7774
7775 * process.c (make_process): Initialize GnuTLS credentials to NULL.
7776 (deactivate_process): Call emacs_gnutls_deinit.
7777
657d08d3
JB
77782011-10-27 Juanma Barranquero <lekktu@gmail.com>
7779
7780 * image.c (x_create_x_image_and_pixmap):
7781 * w32.c (sys_rename, w32_delayed_load):
7782 * w32font.c (fill_in_logfont):
7783 * w32reg.c (x_get_string_resource): Silence compiler warnings.
7784
5430d399
JB
77852011-10-26 Juanma Barranquero <lekktu@gmail.com>
7786
7787 * w32fns.c (w32_default_color_map): New function,
7788 extracted from Fw32_default_color_map.
a7ef684b 7789 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 7790
fe0055fa
PE
77912011-10-25 Paul Eggert <eggert@cs.ucla.edu>
7792
7793 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
7794
e6346438
SM
77952011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
7796
7797 * keyboard.c (test_undefined): New function (bug#9751).
7798 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
7799
e112cc37
ET
78002011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
7801
7802 * sysdep.c (init_sys_modes): Fix the check for the controlling
7803 terminal (Bug#6649).
7804
7b5d6677
EZ
78052011-10-20 Eli Zaretskii <eliz@gnu.org>
7806
7807 * dispextern.h (struct bidi_it): New member next_en_type.
7808
7809 * bidi.c (bidi_line_init): Initialize the next_en_type member.
7810 (bidi_resolve_explicit_1): When next_en_pos is valid for the
7811 current character, check also for next_en_type being WEAK_EN.
7812 (bidi_resolve_weak): Don't enter the expensive loop if the current
7813 position is before next_en_pos. Record the bidi type of the first
7814 non-ET, non-BN character we find, in addition to its position.
7815 (bidi_level_of_next_char): Invalidate next_en_type when
7816 next_en_pos is over-stepped.
7817
7da0b018
PE
78182011-10-20 Paul Eggert <eggert@cs.ucla.edu>
7819
7820 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
7821 * editfns.c: Rewrite current-time-zone so that it invokes
7822 the equivalent of (format-time-string "%Z") to get the time zone name.
7823 This fixes a bug when the time zone name contains characters that
7824 need converting from the system time locale to Emacs internal format.
7825 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
7826 that patch fixed format-time-string to do the conversion, but
7827 I forgot to fix current-time-zone.
7828 (format_time_string): New function, containing most of
7829 what Fformat_time_string used to contain.
7830 (Fformat_time_string): Rewrite in terms of format_time_string.
7831 This doesn't change this function's behavior.
7832 (current-time-zone): Rewrite to use format_time_string.
7833 This fixes the bug reported by Michael Schierl in
7834 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
7835 Jason Rumney's 2007-06-07 change worked around this bug, but
7836 didn't fix it.
7837 * systime.h (tzname, timezone): Remove no-longer-used declarations.
7838
8547b010
EZ
78392011-10-19 Eli Zaretskii <eliz@gnu.org>
7840
7841 * xdisp.c (start_display): If the character at POS is displayed
7842 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
7843 (try_window_reusing_current_matrix): If a line ends in a display
7844 vector or the next line starts in a display vector, continue
7845 redrawing the window even though the character position of
7846 start_row was reached.
8547b010
EZ
7847 (Bug#9771, part 2)
7848
4e948d15
CY
78492011-10-18 Chong Yidong <cyd@gnu.org>
7850
7851 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
7852 with nobreak-char-display too.
7853
4787455f
EZ
78542011-10-18 Eli Zaretskii <eliz@gnu.org>
7855
7856 Fix part 3 of bug#9771.
7857 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
7858 (bidi_resolve_neutral): Don't enter the expensive loop looking for
7859 non-neutral characters if the current character is a paragraph
7860 separator (a.k.a. Newline). This avoids running the same
7861 expensive loop twice, once when we consume the preceding newline
7862 and the other time when the line actually needs to be displayed.
7863 Avoid the loop when we see neutrals on the base embedding level
7864 following a character whose directionality is the same as the
7865 paragraph's. This avoids running the expensive loop when a line
7866 ends in a long sequence of neutrals, like control characters.
7867 Add assertion against STRONG_AL type. Slightly rearrange code
7868 that determines the type of a neutral given the first non-neutral
7869 that follows it.
7870 (bidi_level_of_next_char): Set next_en_pos to zero when
7871 invalidating its info.
7872
2c91f553
EZ
78732011-10-17 Eli Zaretskii <eliz@gnu.org>
7874
7875 * xdisp.c (push_display_prop): Determine whether to record string
7876 or buffer position by IT->string, not by IT->method. Allow
7877 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
7878 (move_it_vertically_backward): Don't look for character position
7879 immediately after the newline when in a continuation line.
7880 (Bug#9771, part 1)
2c91f553 7881
c7b08b0d
MR
78822011-10-15 Martin Rudalics <rudalics@gmx.at>
7883
7884 * window.c (coordinates_in_window): Rewrite and delabelize
7885 vertical border check. (Bug#5357) (Bug#9618)
7886
6b02f655
SM
78872011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
7888
7889 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
7890 errors in XSetWindowBorder (bug#9310).
7891
81d40c92
DA
78922011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
7893
7894 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
7895 avoid crash when xmalloc overrun checking is enabled.
7896
d4172c3b
EZ
78972011-10-13 Eli Zaretskii <eliz@gnu.org>
7898
7899 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
7900 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
7901 cursor motion with <left> and <right> arrow keys.
7902
7903 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
7904 some callers set that themselves.
7905
b00eea75
EZ
79062011-10-12 Eli Zaretskii <eliz@gnu.org>
7907
7908 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
7909 display string and the previous row comes from the same string and
7910 is empty. (Bug#9739) (Bug#9738)
7911
8fe012c4
SM
79122011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
7913
7914 * doc.c (get_doc_string): Encode file name (bug#9735).
7915
0074aef2
EZ
79162011-10-12 Eli Zaretskii <eliz@gnu.org>
7917
79beb178
EZ
7918 * bidi.c (bidi_level_of_next_char):
7919 * xdisp.c (get_visually_first_element): Remove old incorrect
7920 comments regarding the Unicode Line Separator character.
7921
0074aef2
EZ
7922 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
7923
6e4b3fbe
DA
79242011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
7925
7926 * alloc.c (Fgc_status): Do not access beyond zombies array
7927 boundary if nzombies > MAX_ZOMBIES.
7928 * alloc.c (dump_zombies): Add missing format specifier.
7929
0324f3af
PE
79302011-10-12 Paul Eggert <eggert@cs.ucla.edu>
7931
b5525cac
PE
7932 * xdisp.c (set_cursor_from_row): Simplify conditionals,
7933 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
7934
0324f3af
PE
7935 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
7936 Some packages use them to denote characters with modifiers.
7937
e9b5f888
AS
79382011-10-11 Andreas Schwab <schwab@linux-m68k.org>
7939
7940 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
7941 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
7942 matching a pp-number. Rename parameter var to var1.
7943
127827c0
SM
79442011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
7945
7946 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
7947
c8fd3bd0
GM
79482011-10-08 Glenn Morris <rgm@gnu.org>
7949
7950 * callint.c (Fcall_interactively): Give a more explicit error for the
7951 'c' case with a non-character input. (Bug#8479)
7952
352ec8ff
EZ
79532011-10-08 Eli Zaretskii <eliz@gnu.org>
7954
03669ccb
EZ
7955 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
7956 lines.
7061c986
EZ
7957 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
7958 lines that are hscrolled on the left.
03669ccb 7959
352ec8ff
EZ
7960 * dispnew.c (buffer_posn_from_coords): Account for a possible
7961 presence of header-line. (Bug#4426)
7962
a66cfb1c
SM
79632011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
7964
6b02f655
SM
7965 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
7966 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 7967
7c5ee88e
PE
79682011-10-07 Paul Eggert <eggert@cs.ucla.edu>
7969
7970 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
7971 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
7972 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
7973 this makes Emacs dump core during garbage collection on rare
7974 occasions. sizeof is obviously inferior to offsetof here, so
7975 stick with offsetof.
7976 (GC_POINTER_ALIGNMENT): New macro.
7977 (mark_memory): Omit 3rd (offset) arg; caller changed.
7978 Don't assume EMACS_INT alignment is the same as pointer alignment.
7979
df1bbe5b
SM
79802011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
7981
7982 * keyboard.c (read_key_sequence_remapped): New var.
7983 (read_key_sequence): Compute remapping in the right buffer.
7984 (command_loop_1): Use read_key_sequence's remapping directly.
7985
51553db6
SM
79862011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
7987
32c1fffd
SM
7988 * dired.c (file_name_completion): Don't expand file name.
7989 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
7990 before checking file name handler.
7991
51553db6
SM
7992 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
7993 they've been requested explicitly (bug#9591).
7994
b6bd1599 79952011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
7996
7997 * keymap.c (Fsingle_key_description): Use make_specified_string
7998 instead of build_string to build string from push_key_description.
7999 (Bug#5193)
8000
f701dc2a
PE
80012011-09-30 Paul Eggert <eggert@cs.ucla.edu>
8002
4222c55d
PE
8003 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
8004 This fixes a Y2038 bug on 64-bit hosts.
8005 * buffer.c (reset_buffer):
8006 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
8007 (Fclear_buffer_auto_save_failure):
8008 Use 0, not -1, to represent an unset failure time, since time_t
8009 might not be signed.
8010
f701dc2a
PE
8011 Remove dependency on glibc malloc internals.
8012 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
8013 Move back here from lisp.h, but with their new implementations.
8014 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
8015 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
8016 * charset.c (charset_table_init): New static var.
8017 (syms_of_charset): Use it instead of xmalloc. This removes a
8018 dependency on glibc malloc internals. See Eli Zaretskii's comment in
8019 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
8020 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
8021 Move back to alloc.c.
8022 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
8023 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
8024
9ceebf39
JD
80252011-09-30 Jan Djärv <jan.h.d@swipnet.se>
8026
8027 * nsterm.m (windowDidResize): Call x_set_window_size only when
8028 ns_in_resize is true. Otherwise set pixelwidth/height and
8029 call change_frame_size (Bug#9628).
8030
cb993c58
PE
80312011-09-30 Paul Eggert <eggert@cs.ucla.edu>
8032
3930c88b
PE
8033 Port --enable-checking=all to Fedora 14 x86-64.
8034 * charset.c (syms_of_charset): Also account for glibc malloc's
8035 internal overhead when calculating the initial malloc maximum.
8036
cb993c58
PE
8037 Port --enable-checking=all to Fedora 14 x86.
8038 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
8039 Move to lisp.h.
8040 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
8041 (overrun_check_realloc, overrun_check_free):
8042 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
8043 That way, xmalloc returns a properly-aligned pointer even if
8044 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
8045 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
8046 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
8047 into account when calculating the initial malloc maximum.
8048 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
8049 Move here from alloc.c, so that charset.c can use it too.
8050 Properly align; the old code wasn't right for common 32-bit hosts
8051 when configured with --enable-checking=all.
8052 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
8053 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
8054
31bed486
EZ
80552011-09-29 Eli Zaretskii <eliz@gnu.org>
8056
04c70788 8057 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
8058 use EDOM.
8059
fbcaa2f3
EZ
80602011-09-28 Eli Zaretskii <eliz@gnu.org>
8061
8062 * xdisp.c (compute_display_string_end): If there's no display
8063 string at CHARPOS, return -1.
8064
8065 * bidi.c (bidi_fetch_char): When compute_display_string_end
8066 returns a negative value, treat the character as a normal
8067 character not covered by a display string. (Bug#9624)
8068
a239d4e9
JB
80692011-09-28 Juanma Barranquero <lekktu@gmail.com>
8070
8071 * lread.c (Fread_from_string): Fix typo in docstring.
8072
88652fd5
EZ
80732011-09-27 Eli Zaretskii <eliz@gnu.org>
8074
8075 * xdisp.c (handle_invisible_prop): If invisible text ends on a
8076 newline, reseat the iterator instead of bidi-iterating there one
8077 character at a time. (Bug#9610)
32c1fffd
SM
8078 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
8079 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 8080
ed497dd4
AS
80812011-09-27 Andreas Schwab <schwab@linux-m68k.org>
8082
8083 * lread.c (readevalloop): Use correct code for NBSP.
8084 (read1): Likewise. (Bug#9608)
8085
b2bf61aa
MA
80862011-09-25 Michael Albinus <michael.albinus@gmx.de>
8087
8088 * dbusbind.c (Fdbus_register_signal): When service is not
8089 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
8090
32bbb17c
GM
80912011-09-25 Glenn Morris <rgm@gnu.org>
8092
8093 * buffer.c (truncate-lines): Doc fix.
8094
94e0933e
CY
80952011-09-24 Chong Yidong <cyd@stupidchicken.com>
8096
8097 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
8098 (Fset_window_next_buffers): Doc fix.
8099
cddde921
GM
81002011-09-24 Glenn Morris <rgm@gnu.org>
8101
8102 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
8103
1260aef1
PE
81042011-09-24 Paul Eggert <eggert@cs.ucla.edu>
8105
25b4bfa0
PE
8106 Fix minor problems found by static checking.
8107 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
8108 * indent.c (Fvertical_motion): Fix == vs = typo.
8109
e3cbd34b
EZ
81102011-09-24 Eli Zaretskii <eliz@gnu.org>
8111
a66cfb1c
SM
8112 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
8113 Default value is now t. Doc fix.
6bf7006f 8114
e3cbd34b 8115 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 8116 logic when moving up, not only when moving down. Fix the
e3cbd34b 8117 confusing name and values of the it_overshoot_expected variable;
32c1fffd 8118 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
8119
8120 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
8121 CHARPOS is covered by a display string which includes newlines.
8122 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
8123 is covered by a display string with embedded newlines.
8124
a3de0cbd
MA
81252011-09-24 Michael Albinus <michael.albinus@gmx.de>
8126
8127 * dbusbind.c (Fdbus_register_signal): Add match rule to
8128 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
8129 (Fdbus_register_method, Vdbus_registered_objects_table):
8130 Fix docstring.
a3de0cbd 8131
b260039d
JM
81322011-09-24 Jim Meyering <meyering@redhat.com>
8133
32c1fffd 8134 do not ignore write error for any output size
b260039d
JM
8135 The previous change was incomplete.
8136 While it makes emacs --batch detect the vast majority of stdout
8137 write failures, errors were still ignored whenever the output size is
8138 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
8139 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
8140 && echo FAIL: ignored write error
8141 FAIL: ignored write error
8142 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
8143 && echo FAIL: ignored write error
8144 FAIL: ignored write error
8145 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
8146
8eca8a7c
AS
81472011-09-23 Andreas Schwab <schwab@linux-m68k.org>
8148
8149 * emacs.c (Fkill_emacs): In noninteractive mode exit
8150 non-successfully if a write error occurred on stdout. (Bug#9574)
8151
3341db62
EZ
81522011-09-21 Eli Zaretskii <eliz@gnu.org>
8153
8154 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
8155 the xassert test.
8156
8157 * dispextern.h (struct it): Update the comment documenting what
8158 can it->OBJECT be.
8159
8c203dbf
EZ
81602011-09-20 Eli Zaretskii <eliz@gnu.org>
8161
8162 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
8163 a display string, extend search for cursor position to end of row.
8164 (find_row_edges): If the row ends in a newline from a display
8165 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
8166 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
8167 (Fcurrent_bidi_paragraph_direction): Fix search for previous
8168 non-empty line. Fixes confusing cursor motion with arrow keys at
8169 the beginning of a line that starts with whitespace.
8c203dbf 8170
a4824228
LMI
81712011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8172
8173 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
8174 (bug#9493).
8175
33ed493b
CY
81762011-09-18 Chong Yidong <cyd@stupidchicken.com>
8177
8178 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
8179 boolean (Bug#9154).
8180
56cd55c8
EZ
81812011-09-18 Eli Zaretskii <eliz@gnu.org>
8182
8183 * xdisp.c (display_line): Record maximum and minimum buffer
8184 positions even if no glyphs were produced (e.g., by a zero-width
8185 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
8186 buffer positions that will be removed from the glyph row because
8187 they don't fit.
c02dcedf
EZ
8188 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
8189 column is beyond frame width: don't subtract 1 "pixel" when
8190 computing width of the stretch.
3e62b7e0
EZ
8191 (reseat_at_next_visible_line_start): Undo the change made on
8192 2011-09-17 that saved paragraph information and restored it after
8193 the call to `reseat'. (Bug#9545)
56cd55c8 8194
5ed99d36 81952011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
8196
8197 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
8198 and turn window cursor on if cleared (Bug#9415).
8199
5ed99d36 82002011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
8201
8202 * search.c (boyer_moore): Take unibyte characters from pattern
8203 literally. (Bug#9458)
8204
9bade7b2
EZ
82052011-09-18 Eli Zaretskii <eliz@gnu.org>
8206
8207 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
8208
e5e9d610
PE
82092011-09-18 Paul Eggert <eggert@cs.ucla.edu>
8210
87e4427a
PE
8211 Fix minor problem found by static checking.
8212 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
8213 initialized, to pacify gcc -Wuninitialized.
8214
e5e9d610
PE
8215 * fileio.c: Report proper errno when syscall falls.
8216 (Finsert_file_contents): Save and restore errno,
8217 so that report_file_error outputs the correct diagnostic.
8218 (Fwrite_region) [CLASH_DETECTION]: Likewise.
8219
a1674f0b
EZ
82202011-09-18 Eli Zaretskii <eliz@gnu.org>
8221
8222 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
8223
fbfb6dd4
EZ
82242011-09-17 Eli Zaretskii <eliz@gnu.org>
8225
8226 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
8227 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
8228
bb187662
EZ
82292011-09-17 Eli Zaretskii <eliz@gnu.org>
8230
1137e8b8 8231 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 8232 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
8233
8234 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
8235 (bidi_find_paragraph_start): Search back for paragraph beginning
8236 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
8237 (bidi_move_to_visually_next): Only trigger paragraph-related
8238 computations when the last character is a newline or at EOB, not
8239 just any NEUTRAL_B. (Bug#9470)
8240
bb187662
EZ
8241 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
8242 truncated lines if point is covered by a display string. (Bug#9524)
8243
2e621251
PE
82442011-09-16 Paul Eggert <eggert@cs.ucla.edu>
8245
8246 * xselect.c: Relax test for outgoing X longs (Bug#9498).
8247 (cons_to_x_long): New function.
8248 (lisp_data_to_selection_data): Use it. Correct the test for
8249 short-versus-long data; it was negated. Break out of vector
8250 loop, for efficiency, when a long datum is discovered.
8251
91a15bc6
SM
82522011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
8253
8254 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
8255
b41c3a35
EZ
82562011-09-16 Eli Zaretskii <eliz@gnu.org>
8257
8258 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
8259 GCC PR/17406) by declaring this function with external scope.
8260
7812ba2d
PE
82612011-09-15 Paul Eggert <eggert@cs.ucla.edu>
8262
8263 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
8264 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
8265
cf7edc2a
AS
82662011-09-15 Andreas Schwab <schwab@linux-m68k.org>
8267
8268 * editfns.c (Fformat): Correctly handle text properties on "%%".
8269
bd01620e
EZ
82702011-09-15 Eli Zaretskii <eliz@gnu.org>
8271
8272 * xterm.c (x_draw_composite_glyph_string_foreground):
8273 * w32term.c (x_draw_composite_glyph_string_foreground):
8274 * term.c (encode_terminal_code):
8275 * composite.c (composition_update_it, get_composition_id):
8276 * xdisp.c (get_next_display_element)
8277 (fill_composite_glyph_string): Add comments about special meaning
8278 of TAB characters in a composition.
8279
a02719a3
PE
82802011-09-15 Paul Eggert <eggert@cs.ucla.edu>
8281
8282 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
8283 This occurs when processing a multibyte format.
8284 Problem reported by Wolfgang Jenker.
a02719a3 8285
72589a3c
JB
82862011-09-15 Johan Bockgård <bojohan@gnu.org>
8287
8288 * xdisp.c (try_cursor_movement): Only check for exact match if
8289 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
8290
1c14176c
PE
82912011-09-14 Paul Eggert <eggert@cs.ucla.edu>
8292
8293 Remove unused external symbols.
8294 * dispextern.h (calc_pixel_width_or_height): Remove decl.
8295 * xdisp.c (calc_pixel_width_or_height): Now static.
8296 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
8297 * indent.c (check_display_width):
8298 * w32term.c: Fix comment to match code.
8299 * xterm.c, xterm.h (x_catching_errors): Remove.
8300
d2eea5b5
PE
83012011-09-14 Paul Eggert <eggert@cs.ucla.edu>
8302
8303 * xselect.c: Use signed conversions more consistently (Bug#9498).
8304 (selection_data_to_lisp_data): Assume incoming selection data are
8305 signed integers, not unsigned. This is to be consistent with
8306 outgoing selection data, which was modified to use signed integers
8307 in as part of the fix to Bug#9196 in response to Jan D.'s comment
8308 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
8309 expects long, not unsigned long.
8310
46888499
EZ
83112011-09-14 Eli Zaretskii <eliz@gnu.org>
8312
8313 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
8314 computation of loop end. Reported by Johan Bockgård
8315 <bojohan@gnu.org>.
8316
ef8ef9fb
CY
83172011-09-13 Chong Yidong <cyd@stupidchicken.com>
8318
8319 * frame.c (Fother_visible_frames_p): Function deleted.
8320
fa819fed
EZ
83212011-09-12 Eli Zaretskii <eliz@gnu.org>
8322
8323 * indent.c (compute_motion): Process display vector front to back
8324 rather than the other way around. (Bug#2496)
8325
2ba8e008
SM
83262011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
8327
8328 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
8329
20f53c69
CY
83302011-09-11 Chong Yidong <cyd@stupidchicken.com>
8331
8332 * minibuf.c (Fread_from_minibuffer): Doc fix.
8333
d562d7a4
EZ
83342011-09-11 Eli Zaretskii <eliz@gnu.org>
8335
8336 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
8337 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
8338
1c4d7f3d
LMI
83392011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8340
8341 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
8342 value for non-existent files.
8343
b885bf36
EZ
83442011-09-11 Eli Zaretskii <eliz@gnu.org>
8345
8346 * fileio.c (Finsert_file_contents): If the file cannot be opened,
8347 set its "size" to -1. This will set the modtime_size field of
8348 the corresponding buffer to -1, which is what
8349 verify-visited-file-modtime expects for files that do not exist.
8350 (Bug#9139)
8351
6612f0bf
PE
83522011-09-11 Paul Eggert <eggert@cs.ucla.edu>
8353
8354 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
8355 here ...
8356 * lisp.h: ... from here. push_key_description is no longer
8357 defined in keyboard.c, so its declaration should not be in
8358 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
8359 logically belongs with push_key_description.
8360
dfb3f755
PE
83612011-09-10 Paul Eggert <eggert@cs.ucla.edu>
8362
8363 * buffer.h: Include <sys/types.h> instead of <time.h>.
8364 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
8365 Problem reported by Herbert J. Skuhra.
8366
3134906c
LMI
83672011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
8368
8369 * xml.c (parse_region): Make the parsing work for
8370 non-comment-starting XML files again (bug#9144).
8371
8d903f4e
AS
83722011-09-10 Andreas Schwab <schwab@linux-m68k.org>
8373
8374 * image.c (gif_load): Fix calculation of bottom and right corner.
8375 (Bug#9468)
8376
80ad64f4
EZ
83772011-09-10 Eli Zaretskii <eliz@gnu.org>
8378
8379 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
8380 redisplay in small windows.
8381
208a048d
EZ
83822011-09-09 Eli Zaretskii <eliz@gnu.org>
8383
8384 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
8385
9b1c252e
MR
83862011-09-08 Martin Rudalics <rudalics@gmx.at>
8387
8388 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
8389 Operate on live windows only.
8390
2949f33b
JB
83912011-09-08 Juanma Barranquero <lekktu@gmail.com>
8392
8393 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
8394
e08dcafd
EZ
83952011-09-07 Eli Zaretskii <eliz@gnu.org>
8396
8397 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
8398 only under bidi iteration.
8399
115b96bd
JD
84002011-09-07 Jan Djärv <jan.h.d@swipnet.se>
8401
8402 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
8403
c8199d0f
PE
84042011-09-06 Paul Eggert <eggert@cs.ucla.edu>
8405
8406 isnan: Fix porting problem to Solaris 10 with bundled gcc.
8407 Without this fix, the command to link temacs failed due to an
8408 undefined symbol __builtin_isnan. This is because
8409 /usr/include/iso/math_c99.h #defines isnan(x) to
8410 __builtin_isnan(x), but the bundled gcc, which identifies itself
8411 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
8412 a __builtin_isnan.
8413 * floatfns.c (isnan): #undef, and then #define to a clone of
8414 what's in data.c.
8415 (Fisnan): Always define, since it's always available now.
8416 (syms_of_floatfns): Always define isnan at the Lisp level.
8417
e39b275c 84182011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
8419
8420 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
8421
b2db44d9 84222011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 8423
f4af5137 8424 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
8425 The previous code assumed that file offsets (off_t values) fit in
8426 EMACS_INT variables, which is not true on typical 32-bit hosts.
8427 The code messed up by falsely reporting buffer overflow in cases
8428 such as (insert-file-contents "big" nil 1 2) into an empty buffer
8429 when "big" contains more than 2**29 bytes, even though this
8430 inserts just one byte and does not overflow the buffer.
8431 (Finsert_file_contents): Store file offsets as off_t
8432 values, not as EMACS_INT values. Check for overflow when
8433 converting between EMACS_INT and off_t. When checking for
8434 buffer overflow or for overlap, take the offsets into account.
8435 Don't use EMACS_INT for small values where int suffices.
8436 When checking for overlap, fix a typo: ZV was used where
8437 ZV_BYTE was intended.
8438 (Fwrite_region): Don't assume off_t fits into 'long'.
8439 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
8440
ecfc0a49
MA
84412011-09-05 Michael Albinus <michael.albinus@gmx.de>
8442
8443 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
8444
6511acf2 84452011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 8446
0999621a 8447 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
8448
8449 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 8450 (esprintf, exprintf, evxprintf): New functions.
62f19c19 8451 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 8452 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
8453 (modify_event_symbol): Do not assume that the length of
8454 name_alist_or_stem is safe to alloca and fits in int.
8455 (Fexecute_extended_command): Likewise for function name and binding.
8456 (Frecursion_depth): Wrap around reliably on integer overflow.
8457 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
8458 since some callers pass EMACS_INT values.
8459 (Fsingle_key_description): Don't crash if symbol name contains more
8460 than MAX_ALLOCA bytes.
8461 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
8462 (get_minibuffer): Arg is now EMACS_INT, not int.
8463 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 8464 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
8465 * window.h (command_loop_level, minibuf_level): Reflect API changes.
8466
2be7d702
PE
8467 * dbusbind.c (signature_cat): New function.
8468 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
8469 Do not overrun buffer; instead, report string overflow.
8470
9d1df220
PE
8471 * dispnew.c (add_window_display_history): Don't overrun buffer.
8472 Truncate instead; this is OK since it's just a log.
8473
33ef5c64
PE
8474 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
8475 even if the time zone offset is outlandishly large.
8476 Don't mishandle offset == INT_MIN.
8477
66c6fdd5
PE
8478 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
8479 when creating daemon; the previous buffer-overflow check was incorrect.
8480
d749b01b
PE
8481 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
8482 which has the guts of the old verror function.
8483
b5cd1905
PE
8484 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
8485 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
8486
6e1a67fb
PE
8487 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
8488 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 8489 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 8490 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
8491 length of string rather than counting it via multiple sprintfs;
8492 that's simpler and more reliable.
c21721cc
PE
8493 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
8494 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
8495 sprintf, in case result does not fit in int.
8496
c57b67fc
PE
8497 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
8498 (fontset_from_font): Print it.
8499
8a401434
PE
8500 * frame.c (tty_frame_count): Now printmax_t, not int.
8501 (make_terminal_frame, set_term_frame_name): Print it.
8502 (x_report_frame_params): In X, window IDs are unsigned long,
8503 not signed long, so print them as unsigned.
8504 (validate_x_resource_name): Check for implausibly long names,
8505 and don't assume name length fits in 'int'.
8506 (x_get_resource_string): Don't blindly alloca invocation name;
8507 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
8508 not fit in int.
8509
6e1a67fb
PE
8510 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
8511 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
8512 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
8513
0df02bf3
PE
8514 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
8515 Use esprintf, not sprintf, in case result does not fit in int.
8516
48e30793
PE
8517 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
8518 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
8519 it as a large positive number.
8520 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
8521 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
8522
a66ff6d8
PE
8523 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
8524 in case result does not fit in int.
8525
aca216ff
PE
8526 * print.c (float_to_string): Detect width overflow more reliably.
8527 (print_object): Make sprintf buffer a bit bigger, to avoid potential
8528 buffer overrun. Don't assume list length fits in 'int'. Treat
8529 print length of 0 as 0, not as infinity; to be consistent with other
8530 uses of print length in this function. Don't overflow print length
8531 index. Don't assume hash table size fits in 'long', or that
8532 vectorlike size fits in 'unsigned long'.
8533
31c286f7
PE
8534 * process.c (make_process): Use printmax_t, not int, to format
8535 process-name gensyms.
8536
55e5faa1
PE
8537 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
8538
80f2e268
PE
8539 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
8540 to avoid potential buffer overrun.
8541
670741ab
PE
8542 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
8543 if X resource line is longer than 512 bytes.
8544
b7163a50
PE
8545 * xfns.c (x_window): Make sprintf buffer a bit bigger
8546 to avoid potential buffer overrun.
8547
ae58ff1f
PE
8548 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
8549
c43c8a6a
PE
8550 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
8551
3f8236f4
PE
85522011-09-04 Paul Eggert <eggert@cs.ucla.edu>
8553
53e9fe90 8554 Integer overflow fixes for scrolling, etc.
6511acf2
PE
8555 Without these, Emacs silently mishandles large integers sometimes.
8556 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
8557 it were "C-u 1 M-x recenter" on a typical 64-bit host.
8558
6511acf2
PE
8559 * xdisp.c (try_window_id): Check Emacs fixnum range before
8560 converting to 'int'.
806add1d 8561
6511acf2 8562 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
8563 Check that an Emacs fixnum is in range before assigning it to 'int'.
8564 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
8565 values converted from Emacs fixnums.
8566 (Frecenter): Don't wrap around a line count if it is out of 'int'
8567 range; instead, treat it as an extreme value.
8568 (Fset_window_configuration, compare_window_configurations):
8569 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
8570
6511acf2
PE
8571 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
8572 that can exceed INT_MAX. Check that EMACS_INT value is in range
8573 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
8574 (match_limit): Don't assume that a fixnum can fit in 'int'.
8575
6511acf2 8576 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
8577 exceed INT_MAX.
8578
6511acf2 8579 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
8580 (Fvertical_motion): Don't wrap around LINES values that don't fit
8581 in 'int'. Instead, treat them as extreme values. This is good
8582 enough for windows, which can't have more than INT_MAX lines anyway.
8583
fcb901a7
LMI
85842011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8585
0f2f6b6d
LMI
8586 * Require libxml/parser.h to avoid compilation warning.
8587
fcb901a7
LMI
8588 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
8589
8590 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
8591 since this reportedly can destroy thread storage.
8592
6e20a0d4
CY
85932011-08-30 Chong Yidong <cyd@stupidchicken.com>
8594
8595 * syntax.c (find_defun_start): Update all cache variables if
8596 exiting early (Bug#9401).
8597
148ae00e
EZ
85982011-08-30 Eli Zaretskii <eliz@gnu.org>
8599
f6cfbd8f
EZ
8600 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
8601
148ae00e
EZ
8602 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
8603 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
8604 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
8605
8606 * term.c (tty_append_glyph): New function.
8607 (produce_stretch_glyph): Static function and its prototype deleted.
8608
a66cfb1c
SM
8609 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
8610 Add prototypes.
148ae00e 8611
c4a07a4c
PE
86122011-08-29 Paul Eggert <eggert@cs.ucla.edu>
8613
8614 * image.c (parse_image_spec): Check for nonnegative, not for positive,
8615 when checking :margin (Bug#9390).
8616 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 8617 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
8618 so that the name doesn't mislead. All uses changed.
8619
6bc8cd65
JB
86202011-08-28 Johan Bockgård <bojohan@gnu.org>
8621
8622 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
8623 set_tty_hooks.
8624
dca4927e
EZ
86252011-08-27 Eli Zaretskii <eliz@gnu.org>
8626
8627 * xdisp.c (move_it_to): Don't bail out early when reaching
8628 position beyond to_charpos, if we are scanning backwards.
8629 (move_it_vertically_backward): When DY == 0, make sure we get to
8630 the first character in the line after the newline.
8631
f2cad773
PE
86322011-08-27 Paul Eggert <eggert@cs.ucla.edu>
8633
8634 * ccl.c: Improve and simplify overflow checking (Bug#9196).
8635 (ccl_driver): Do not generate an out-of-range pointer.
8636 (Fccl_execute_on_string): Remove unnecessary check for
8637 integer overflow, noted by Stefan Monnier in
8638 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
8639 Remove a FIXME that didn't need fixing.
8640 Simplify the newly-introduced buffer reallocation code.
8641
0cae2cdb
JB
86422011-08-27 Juanma Barranquero <lekktu@gmail.com>
8643
8644 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
8645
5fc295a4 86462011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 8647
70c60eb2 8648 Integer and memory overflow issues (Bug#9196).
726e0ab1 8649
d31850da
PE
8650 * doc.c (get_doc_string): Rework so that
8651 get_doc_string_buffer_size is the actual buffer size, rather than
8652 being 1 less than the actual buffer size; this makes xpalloc more
8653 convenient.
8654
a69fbedb
PE
8655 * image.c (x_allocate_bitmap_record, cache_image):
8656 * xselect.c (Fx_register_dnd_atom):
8657 Simplify previous changes by using xpalloc.
8658
fe5c5d37
PE
8659 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
8660 since either will do and ptrdiff_t is convenient with xpalloc.
8661
0065d054
PE
8662 * charset.c (charset_table_size)
8663 (struct charset_sort_data.priority): Now ptrdiff_t.
8664 (charset_compare): Don't overflow if priorities differ greatly.
8665 (Fsort_charsets): Don't assume list length fits in int.
8666 Check for size-calculation overflow when allocating sort data.
8667 (syms_of_charset): Allocate an initial charset table that is
8668 just under 64 KiB, to avoid problems with glibc malloc and mmap.
8669
8670 * cmds.c (internal_self_insert): Check for size-calculation overflow.
8671
8672 * composite.h (struct composition.glyph_len): Now int, not unsigned.
8673 The actual value is always <= INT_MAX, and leaving it unsigned made
8674 overflow checking harder.
8675
8676 * dispextern.h (struct glyph_matrix.rows_allocated)
8677 (struct face_cache.size): Now ptrdiff_t, for convenience in use
8678 with xpalloc. The values are still always <= INT_MAX.
8679
8680 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
8681
8682 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
8683 (SAFE_NALLOCA): New macro.
8684
8685 * region-cache.c (struct boundary.pos, find_cache_boundary)
8686 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
8687 (set_cache_region, invalidate_region_cache)
8688 (revalidate_region_cache, know_region_cache, region_cache_forward)
8689 (region_cache_backward, pp_cache):
8690 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
8691 so that ptrdiff_t * can be passed to xpalloc.
8692 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
8693 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
8694 (pp_cache): Don't assume cache_len fits in int.
8695 * region-cache.h: Adjust extern decls to match.
8696
8697 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
8698 EMACS_INT, since either will do, for xpalloc.
8699
8700 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
8701 (xnmalloc, xnrealloc, xpalloc): New functions.
8702
726e0ab1
PE
8703 * bidi.c (bidi_shelve_header_size): New constant.
8704 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
8705 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
8706
51f30bc5 8707 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
8708 * buffer.c (overlays_at, overlays_in, record_overlay_string)
8709 (overlay_strings):
8710 Don't update size of array until after memory allocation succeeds,
8711 because xmalloc/xrealloc may not return.
0065d054
PE
8712 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
8713 now that we have proper integer overflow checking.
8714 (record_overlay_string, overlay_strings): Catch overflows when
8715 calculating size of overlay_str_buf.
726e0ab1 8716
0065d054
PE
8717 * callproc.c (Fcall_process): Check for size overflow when
8718 calculating size of args2.
8719 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
8720 Normally we prefer signed values, but sticking with ptrdiff_t would
8721 require adding more-complicated checks.
726e0ab1
PE
8722
8723 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
8724 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
8725 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 8726 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
8727
8728 * character.c (Fstring): Check for size-calculation overflow.
8729
8730 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
8731 unnecessary integer overflow. Check for size overflow.
8732 (encode_coding_object): Don't update size until xmalloc succeeds.
8733
8734 * composite.c (get_composition_id): Check for overflow in glyph
8735 length calculations.
8736
8737 Integer and memory overflow fixes for display code.
8738 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
8739 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
8740 (scrolling_window): Check for overflow in size calculations.
8741 (line_draw_cost, realloc_glyph_pool, add_row_entry):
8742 Don't assume glyph table len fits in int.
8743 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
8744 (row_table_size): Now ptrdiff_t, not int.
8745 (scrolling_window): Avoid overflow in size calculations.
8746 Don't update size until allocation succeeds.
8747 * fns.c (concat): Check for overflow in size calculations.
8748 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
8749 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8750 (NEXT_ALMOST_PRIME_LIMIT): New constant.
8751
8752 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
8753 (get_doc_string): Check for size calculation overflow.
8754 Don't update size until allocation succeeds.
8755 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
8756 EMACS_INT, where ptrdiff_t will do.
8757 (Fsubstitute_command_keys): Check for string overflow.
8758
8759 * editfns.c (set_time_zone_rule): Don't assume environment length
8760 fits in int.
8761 (message_length): Now ptrdiff_t, not int.
8762 (Fmessage_box): Don't update size until allocation succeeds.
8763 Don't assume message length fits in int.
8764 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
8765
0065d054
PE
8766 * emacs.c (main): Do not reallocate argv, since there is a null at
8767 the end that can be overwritten, and this way there's no need to
8768 worry about size-calculation overflow.
8769 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
8770
8771 * eval.c (init_eval_once, grow_specpdl): Don't update size until
8772 alloc succeeds.
8773 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
8774
8775 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
8776 (x_set_scroll_bar_width, x_figure_window_size):
8777 Check for integer overflow.
8778 (x_set_alpha): Do not assume XINT fits in int.
8779
8780 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
8781 This is for the members text_lines, text_cols, total_lines, total_cols,
8782 where the system imposes an 'int' limit.
8783
8784 * fringe.c (Fdefine_fringe_bitmap):
8785 Don't update size until alloc works.
8786
8787 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
8788 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
8789
8790 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
8791 Check for size-calculation overflow.
8792 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
8793 do, as we prefer signed integers.
8794 (id_to_widget.max_size, id_to_widget.used)
8795 (xg_store_widget_in_map, xg_remove_widget_from_map)
8796 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
8797 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
8798 Use and return ptrdiff_t, not int.
8799 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
8800 * gtkutil.h: Change prototypes to match the above.
8801
8802 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
8803 are duplicate now that they've been promoted to lisp.h.
8804 (x_allocate_bitmap_record, x_alloc_image_color)
8805 (make_image_cache, cache_image, xpm_load):
8806 Don't update size until alloc is done.
8807 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
8808 (x_detect_edges):
3256efce 8809 Check for size calculation overflow.
726e0ab1
PE
8810 (ct_colors_allocated_max): New constant.
8811 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
8812 overflow.
3256efce 8813
726e0ab1
PE
8814 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
8815 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
8816 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
8817 Use ptrdiff_t, not int, to count maps.
8818 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
8819 calculations. Don't update size until allocation succeeds.
8820 Redo calculations to avoid overflow.
726e0ab1
PE
8821 * keyboard.h: Change prototypes to match the above.
8822
8823 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
8824 to count maps.
8825 (current_minor_maps): Check for size calculation overflow.
8826 * keymap.h: Change prototypes to match the above.
8827
8828 * lread.c (read1, init_obarray): Don't update size until alloc done.
8829
8830 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
8831 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
8832
726e0ab1
PE
8833 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
8834 Now ptrdiff_t, not int.
8835 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
8836 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
8837
8838 * process.c (Fnetwork_interface_list): Check for overflow
8839 in size calculation.
8840
8841 * region-cache.c (move_cache_gap): Check for size calculation overflow.
8842
8843 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
8844 overflow. Don't bother calling xmalloc when xrealloc will do.
8845
8846 * search.c (Freplace_match): Check for size calculation overflow.
8847 (Fset_match_data): Don't assume list lengths fit in 'int'.
8848
8849 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
8850 for command line length. Do not attempt to address one before the
8851 beginning of an array, as that's not portable.
8852
8853 * term.c (max_frame_lines): Remove; unused.
8854 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
8855 not int.
8856 (encode_terminal_code, calculate_costs): Check for size
8857 calculation overflow.
8858 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
8859 table lengths and related sizes. Don't update size until alloc
8860 done. Redo calculations to avoid overflow.
8861 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
8862
8863 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
8864 subtracting pointers.
8865 (gobble_line): Check for overflow more carefully. Don't update size
8866 until alloc done.
8867
8868 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
8869 Don't update size until alloc done.
8870 Redo size calculations to avoid overflow.
8871 Check for size calculation overflow.
0065d054 8872 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
8873
8874 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
8875 Use ptrdiff_t, not int, for sizes.
8876 (store_mode_line_noprop_char): Don't update size until alloc done.
8877
0065d054
PE
8878 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
8879 Use ptrdiff_t, not int, for sizes.
8880 (Finternal_make_lisp_face, cache_face):
8881 Check for size calculation overflow.
8882 (cache_face): Treat size calculation overflows as if they were
8883 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
8884
8885 * xfns.c (x_encode_text, x_set_name_internal)
8886 (Fx_change_window_property): Use ptrdiff_t, not int, to count
8887 sizes, since they can exceed INT_MAX in size. Check for size
8888 calculation overflow.
8889
0065d054
PE
8890 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
8891 (xg_select): Check for size calculation overflow.
726e0ab1
PE
8892 Don't update size until alloc done.
8893
0065d054 8894 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 8895 as sprintf is limited to int lengths.
1d526e2f 8896
252c5ee1
PE
8897 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
8898 (X_LONG_MIN): New macros.
864d7ce7
PE
8899 Use them to make the following changes clearer.
8900 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
8901 This change doesn't affect the value now, but it may help remind
8902 future maintainers not to raise the value too much later.
8903 (SELECTION_QUANTUM): Remove, replacing with ...
8904 (selection_quantum): ... new function, which avoids overflow.
8905 All uses changed.
8906 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
8907 assumption that selection length fits in 'int'.
8908 (x_reply_selection_request, x_handle_selection_request)
8909 (x_get_window_property, receive_incremental_selection)
8910 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
8911 (lisp_data_to_selection_data, clean_local_selection_data):
8912 Use ptrdiff_t, not int, to record length of selection.
8913 (x_reply_selection_request, x_get_window_property)
8914 (receive_incremental_selection, x_property_data_to_lisp):
8915 Redo calculations to avoid overflow.
8916 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 8917 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
8918 something.
8919 (x_get_window_property, receive_incremental_selection)
8920 (lisp_data_to_selection_data, x_property_data_to_lisp):
8921 Check for size-calculation overflow.
8922 (x_get_window_property, receive_incremental_selection)
8923 (lisp_data_to_selection_data, Fx_register_dnd_atom):
8924 Don't store size until memory allocation succeeds.
8925 (x_get_window_property): Plug memory leak on memory exhaustion.
8926 Don't double-block input; malloc is safe here. Don't assume 2**34
8927 - 4 fits in unsigned long. Add an xassert to check
8928 XGetWindowProperty overflow. Be more careful about overflow
8929 calculations, and distinguish size from memory overflow better.
8930 (receive_incremental_selection): When tracing, don't assume
8931 unsigned int is less than INT_MAX.
8932 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
8933 harmful) conversions of unsigned short to int.
8934 (lisp_data_to_selection_data): Don't assume that integers
8935 in the range -65535 through -1 fit in an X unsigned short.
8936 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
8937 result parameters unless successful. Rely on cons_to_unsigned
8938 to report problems with elements; the old code wasn't right anyway.
8939 (x_check_property_data): Check for int overflow; we cannot use
8940 a wider type due to X limits.
8941 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
8942
726e0ab1 8943 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 8944
0065d054
PE
8945 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
8946 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
8947 (x_color_cells): Don't store size until memory allocation succeeds.
8948 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 8949 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
8950 (x_term_init): Don't assume length fits in int (sprintf is limited
8951 to int size).
bc18e09d 8952
ebfa62c0
PE
8953 Use ptrdiff_t for composition IDs.
8954 * character.c (lisp_string_width):
8955 * composite.c (composition_table_size, n_compositions)
8956 (get_composition_id, composition_gstring_from_id):
8957 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
8958 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
8959 * window.c (Frecenter):
8960 Use ptrdiff_t, not int, for composition IDs.
8961 * composite.c (get_composition_id): Check for integer overflow.
8962 * composite.h: Adjust prototypes to match the above changes.
8963
d3411f89
PE
8964 Use ptrdiff_t for hash table indexes.
8965 * category.c (hash_get_category_set):
8966 * ccl.c (ccl_driver):
8967 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
8968 * coding.c (coding_system_charset_list, detect_coding_system):
8969 * coding.h (struct coding_system.id):
8970 * composite.c (get_composition_id, gstring_lookup_cache):
8971 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
8972 * image.c (xpm_get_color_table_h):
8973 * lisp.h (hash_lookup, hash_put):
8974 * minibuf.c (Ftest_completion):
8975 Use ptrdiff_t for hash table indexes, not int (which is too
8976 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
8977 32-bit --with-wide-int hosts).
8978
e097a6fa
PE
8979 * charset.c (Fdefine_charset_internal): Check for integer overflow.
8980 Add a FIXME comment about memory leaks.
8981 (syms_of_charset): Don't assume xmalloc returns.
8982
5637687f
PE
8983 Don't assume that stated character widths fit in int.
8984 * character.c (Fchar_width, c_string_width, lisp_string_width):
8985 * character.h (CHAR_WIDTH):
8986 * indent.c (MULTIBYTE_BYTES_WIDTH):
8987 Use sanitize_char_width to avoid undefined and/or bad behavior
8988 with outlandish widths.
a66cfb1c 8989 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
8990 now that we have two such functions. All uses changed.
8991 (sanitize_char_width): New inline function.
8992
a2271ba2
PE
8993 Don't assume that tab-width fits in int.
8994 * character.h (sanitize_width): New inline function.
8995 (SANE_TAB_WIDTH): New macro.
8996 (ASCII_CHAR_WIDTH): Use it.
8997 * indent.c (sane_tab_width): Remove. All uses replaced by
8998 SANE_TAB_WIDTH (current_buffer).
8999 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
9000
18c52557
PE
9001 * fileio.c: Integer overflow issues with file modes.
9002 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
9003
caeeedc1
PE
9004 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
9005 Remove unreachable code.
9006 (read_hex, load_charset_map_from_file): Check for integer overflow.
9007
6df6ae42 9008 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
9009 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
9010 (x_send_scroll_bar_event): Likewise. Check that the size does not
9011 exceed limits imposed by XClientMessageEvent, as well as the usual
9012 ptrdiff_t and size_t limits.
9013
b13995db
PE
9014 * keyboard.c: Overflow, signedness and related fixes.
9015 (make_lispy_movement): Use same integer type in forward decl
9016 that is used in the definition.
9017 (read_key_sequence, keyremap_step):
9018 Change bufsize argument back to int, undoing my 2011-03-30 change.
9019 We prefer signed types, and int is wide enough here.
9020 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
9021 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
9022 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
9023 length, not size_t. Use ptrdiff_t for index, not int.
9024 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
9025 possibility of integer overflow.
9026
13464394
PE
9027 Overflow, signedness and related fixes for images.
9028
9029 * dispextern.h (struct it.stack[0].u.image.image_id)
9030 (struct_it.image_id, struct image.id, struct image_cache.size)
9031 (struct image_cache.used, struct image_cache.ref_count):
9032 * gtkutil.c (update_frame_tool_bar):
9033 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
9034 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
9035 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
9036 * nsmenu.m (update_frame_tool_bar):
9037 * xdisp.c (calc_pixel_width_or_height):
9038 * xfns.c (image_cache_refcount):
9039 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
9040 on typical 64-bit hosts.
9041
9042 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
9043 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
9044 Omit unnecessary casts to int.
9045 (parse_image_spec): Check that integers fall into 'int' range
9046 when the callers expect that.
9047 (image_ascent): Redo ascent calculation to avoid int overflow.
9048 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
9049 (lookup_image): Remove unnecessary tests.
9050 (xbm_image_p): Locals are now of int, not EMACS_INT,
9051 since parse_image_check makes sure they fit into int.
9052 (png_load, gif_load, svg_load_image):
9053 Prefer int to unsigned where either will do.
9054 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
9055 old tiff_error_handler and tiff_warning_handler.
9056 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
9057 stack buffer overflows. It uses only the features of vsnprintf
9058 that are common to both POSIX and native Microsoft.
9059 (tiff_error_handler, tiff_warning_handler): Use it.
9060 (tiff_load, gif_load, imagemagick_load_image):
9061 Don't assume :index value fits in 'int'.
9062 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
9063 (imagemagick_load_image): Check that crop parameters fit into
9064 the integer types that MagickCropImage accepts. Don't assume
9065 Vimagemagick_render_type has a nonnegative value. Don't assume
9066 size_t fits in 'long'.
9067 (gs_load): Use printmax_t to print the widest integers possible.
9068 Check for integer overflow when computing image height and width.
9069
c11821d4
EZ
90702011-08-26 Eli Zaretskii <eliz@gnu.org>
9071
9072 * xdisp.c (redisplay_window): Don't force window start if point
9073 will be invisible in the resulting window. (Bug#9324)
9074
0c95fcf7
EZ
90752011-08-25 Eli Zaretskii <eliz@gnu.org>
9076
9077 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
9078 the display spec is of the form `(space ...)'.
9079 (handle_display_spec): Return the value returned by
9080 handle_single_display_spec, not just 1 or zero.
9081 (handle_single_display_spec): If the display spec is of the form
9082 `(space ...)', and specifies display in the text area, return 2
9083 rather than 1.
fee65a97 9084 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
9085 accurately, and prefer exact match for point under bidi.
9086 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
9087
9088 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
9089 into disp_prop; all users changed.
9090
9091 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
9092 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
9093 for the text covered by the display property.
9094
e4ed06f1
CY
90952011-08-25 Chong Yidong <cyd@stupidchicken.com>
9096
9097 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
9098 Change return value to nil.
9099 (Frecord_buffer): Delete unused function.
9100
f67cdd7f
EZ
91012011-08-24 Eli Zaretskii <eliz@gnu.org>
9102
5980d4c6
EZ
9103 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
9104 buffers, return left-to-right.
8610fe8b
EZ
9105 (set_cursor_from_row): Consider candidate row a win if its glyph
9106 represents a newline and point is on that newline. Fixes cursor
9107 positioning on the newline at EOL of R2L text within L2R
9108 paragraph, and vice versa.
9109 (try_cursor_movement): Check continued rows, in addition to
9110 continuation rows. Fixes unwarranted scroll when point enters a
9111 continued line of R2L text within an L2R paragraph, or vice versa.
9112 (cursor_row_p): Consider the case of point being equal to
9113 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
9114 from the end of a short line to the beginning of a continued line
9115 of R2L text within L2R paragraph.
9116 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
9117 composed characters.
5980d4c6 9118
f67cdd7f
EZ
9119 * bidi.c (bidi_check_type): Use xassert.
9120 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
9121 members.
9122
bca633fb
EZ
91232011-08-23 Eli Zaretskii <eliz@gnu.org>
9124
9125 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
9126 a character.
9127
4a5885a7
CY
91282011-08-23 Chong Yidong <cyd@stupidchicken.com>
9129
9130 * nsfont.m (ns_otf_to_script): Fix typo.
9131
0902a04e
KH
91322011-08-22 Kenichi Handa <handa@m17n.org>
9133
9134 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
9135 extra slot even if the purpose is char-code-property-table.
9136
1a2e6670
EZ
91372011-08-23 Eli Zaretskii <eliz@gnu.org>
9138
8ddde651
EZ
9139 * xdisp.c (redisplay_window): When computing centering_position,
9140 account for the height of the header line. (Bug#8874)
9141
425cc014
EZ
9142 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
9143 instead of CHAR_TO_BYTE. Fixes a crash when a completion
9144 candidate is selected by the mouse, and that candidate has a
9145 composed character under the mouse.
9146
1a2e6670
EZ
9147 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
9148 coordinates reported by pos-visible-in-window-p for a composed
9149 character in column zero.
9150
8b76d6f8
SM
91512011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
9152
9153 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
9154
dac347dd
EZ
91552011-08-22 Eli Zaretskii <eliz@gnu.org>
9156
9157 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
9158 consider it a hit if to_charpos is anywhere in the range of the
9159 composed buffer positions.
9160
e013fb34
CY
91612011-08-22 Chong Yidong <cyd@stupidchicken.com>
9162
9163 * image.c (gif_load): Don't assume that each subimage has the same
9164 dimensions as the base image. Handle disposal method that is
9165 "undefined" by the gif spec (Bug#9335).
9166
bd1ba3e8
CY
91672011-08-20 Chong Yidong <cyd@stupidchicken.com>
9168
9169 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 9170 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 9171
54a1215b
EZ
91722011-08-19 Eli Zaretskii <eliz@gnu.org>
9173
823564e5
EZ
9174 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
9175 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
9176 from an Org mode buffer to a Speedbar frame.
9177
54a1215b
EZ
9178 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
9179 a composition, take its buffer position from IT->cmp_it.charpos.
9180 Fixes cursor positioning at the beginning of a line that begins
9181 with a composed character.
9182
9778ebcc
EZ
91832011-08-18 Eli Zaretskii <eliz@gnu.org>
9184
0be6ee06
EZ
9185 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
9186 character bidirectional type, use STRONG_L instead. Fixes crashes
9187 in a buffer produced by `describe-categories'.
9188
9778ebcc
EZ
9189 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
9190 members before the level stack, so they would be saved and
9191 restored when copying iterator state. Fixes incorrect reordering
9192 around TABs covered by display properties.
9193
156bffbe
AS
91942011-08-18 Andreas Schwab <schwab@linux-m68k.org>
9195
6b02f655 9196 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 9197
72ad093b
CY
91982011-08-17 Chong Yidong <cyd@stupidchicken.com>
9199
9200 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
9201 (internal_condition_case_2, internal_condition_case_n):
9202 Remove unnecessary aborts (Bug#9081).
72ad093b 9203
35774242
EZ
92042011-08-17 Eli Zaretskii <eliz@gnu.org>
9205
9206 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
9207 has no `load' handler, try opening the file locally. (Bug#9311)
9208
db76dd85
KB
92092011-08-16 Ken Brown <kbrown@cornell.edu>
9210
9211 * gmalloc.c: Expand comment.
9212
b215eee5
EZ
92132011-08-16 Eli Zaretskii <eliz@gnu.org>
9214
9215 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
9216 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
9217
a4579d33
KB
92182011-08-16 Ken Brown <kbrown@cornell.edu>
9219
9220 Fix memory allocation problems in Cygwin build (Bug#9273).
9221
9222 * unexcw.c ( __malloc_initialized): Declare external variable.
9223 (fixup_executable): Force the dumped emacs to reinitialize malloc.
9224
8b76d6f8
SM
9225 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
9226 New variables.
a4579d33
KB
9227 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
9228 dumped emacs.
9229 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
9230 in the static heap.
9231 [CYGWIN] (special_realloc): New function.
9232 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
9233 requests to realloc storage in the static heap.
9234
3ebec551
PE
92352011-08-15 Paul Eggert <eggert@cs.ucla.edu>
9236
9237 * bidi.c (bidi_initialize): Remove unused local.
9238
9fd8be00
EZ
92392011-08-15 Eli Zaretskii <eliz@gnu.org>
9240
6b02f655
SM
9241 * bidimirror.h:
9242 * biditype.h: Remove file.
9243 * makefile.w32-in ($(BLD)/bidi.$(O)):
9244 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
9245
9246 * dispextern.h: Fix a typo in the comment to bidi_type_t.
9247
9248 * chartab.c: Improve commentary for the uniprop_table API.
9249
32413314
EZ
9250 * bidi.c (bidi_paragraph_init): Support zero value of
9251 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
9252 (bidi_initialize): Use uniprop_table instead of including
9253 biditype.h and bidimirror.h.
32413314 9254
9fd8be00
EZ
9255 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
9256 coordinates of the iterator when restoring from ppos_it.
9257 (Bug#9296)
9258
5cf2b69b
KH
92592011-08-14 Kenichi Handa <handa@m17n.org>
9260
9261 * process.c (create_process): Call setup_process_coding_systems
72ad093b 9262 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 9263
daf17d00
EZ
92642011-08-14 Eli Zaretskii <eliz@gnu.org>
9265
9266 * xdisp.c (move_it_in_display_line_to): Don't invoke
9267 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
9268 ppos_it. Fixes vertical cursor motion when line beginning is
9269 covered by an image. (Bug#9296)
9270
08e3161a
JD
92712011-08-14 Jan Djärv <jan.h.d@swipnet.se>
9272
9273 * nsterm.h (ns_run_ascript): Declare.
9274 (NSAPP_DATA2_RUNASSCRIPT): Define.
9275
9276 * nsfns.m (as_script, as_result, as_status): New static variables.
9277 (ns_run_ascript): New function.
5e617bc2 9278 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
9279 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
9280 the event loop. Get status from as_status (Bug#7276).
9281
9282 * nsterm.m (sendEvent): If event is NSApplicationDefined and
9283 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
9284 the event loop (Bug#7276).
9285
a3720aa2
AS
92862011-08-14 Andreas Schwab <schwab@linux-m68k.org>
9287
9288 * gnutls.c (QCgnutls_bootprop_priority)
9289 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
9290 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
9291 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
9292 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
9293 (QCgnutls_bootprop_verify_hostname_error)
9294 (QCgnutls_bootprop_callbacks_verify): Rename from
9295 Qgnutls_bootprop_..., all uses changed.
9296
9297 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
9298 uses changed.
9299
0a0d27fb
PE
93002011-08-14 Paul Eggert <eggert@cs.ucla.edu>
9301
19d5c50c
PE
9302 * xfaces.c (Qframe_set_background_mode): Now static.
9303 * dispextern.h (Qframe_set_background_mode): Remove decl.
9304
0a0d27fb
PE
9305 * process.c (Fnetwork_interface_info): Declare local only if needed.
9306
377538cb
JD
93072011-08-13 Jan Djärv <jan.h.d@swipnet.se>
9308
9309 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
9310 (Fnetwork_interface_list): Allocate in increments of bytes instead
9311 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
9312 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
9313 sockaddr.
9314 (struct ifflag_def): notrailers is smart on OSX.
9315 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
9316 Get hardware address with getifaddrs if available.
9317
08fff70c
EZ
93182011-08-12 Eli Zaretskii <eliz@gnu.org>
9319
9320 * xdisp.c (iterate_out_of_display_property): xassert that
9321 IT->position is set to within IT->object's boundaries. Break from
9322 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
9323 when IT->position is set up wrongly due to some bug.
9324 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
9325 (push_display_prop): Allow GET_FROM_STRING as IT->method on
9326 entry. Force push_it to save on the stack the current
9327 buffer/string position, to be restored by pop_it. Fix flags in
9328 the iterator structure wrt the object coming from a display
9329 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
9330 properties. (Bug#9284)
9331
7be1c708 93322011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 9333
7be1c708
CY
9334 * fontset.c (fontset_get_font_group): Add proper type checks.
9335 (Bug#9172)
aac0c6e3 9336
7be1c708 93372011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 9338
7be1c708
CY
9339 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
9340 and LC_VERSION_MIN_MACOSX.
9341 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
9342 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 9343
97bb72a6
EZ
93442011-08-08 Eli Zaretskii <eliz@gnu.org>
9345
9346 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
9347 no-display-properties-and-no-overlays under bidi display.
9348 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 9349 properties and overlays.
97bb72a6 9350
d5617611
CY
93512011-08-08 Chong Yidong <cyd@stupidchicken.com>
9352
37e11a63
CY
9353 * editfns.c (Fset_time_zone_rule): Document relationship with the
9354 setenv function.
9355
d5617611
CY
9356 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
9357 the font entity extracted from the cache (Bug#8109).
9358
58872834
CY
93592011-08-07 Chong Yidong <cyd@stupidchicken.com>
9360
9361 * composite.c (autocmp_chars): Don't reset point. That is done by
9362 restore_point_unwind (Bug#5984).
9363
75bfc667
JL
93642011-08-07 Juri Linkov <juri@jurta.org>
9365
9366 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
9367 to show the arg `TIME' instead of `TIMEVAL'.
9368
d1410150
EZ
93692011-08-06 Eli Zaretskii <eliz@gnu.org>
9370
9371 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
9372 display property strides EOL and includes a newline, as in
9373 longlines-mode. (Bug#9254)
75b771e4
EZ
9374 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
9375 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
9376
9377 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
9378 is non-zero, even if the data buffer is NULL. Fixes a crash in
9379 vertical-motion with longlines-mode. (Bug#9254)
9380
35928349
EZ
93812011-08-05 Eli Zaretskii <eliz@gnu.org>
9382
ec7cc85b
EZ
9383 * bidi.c <bidi_cache_total_alloc>: Now static.
9384 (bidi_initialize): Initialize bidi_cache_total_alloc.
9385
8b76d6f8 9386 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
9387 cache. (Bug#9221)
9388
9389 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
9390 amount allocated this far in `bidi_cache_total_alloc'.
9391 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
9392 non-zero, only free the data buffer without restoring the cache
9393 contents. All callers changed.
9394
9395 * dispextern.h (bidi_unshelve_cache): Update prototype.
9396
9397 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
9398 (move_it_in_display_line, move_it_to)
9399 (move_it_vertically_backward, move_it_by_lines): Replace the call
9400 to xfree to an equivalent call to bidi_unshelve_cache.
9401 (move_it_in_display_line_to): Fix logic of returning
412b6358 9402 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 9403
e2e2423b
EZ
94042011-08-05 Eli Zaretskii <eliz@gnu.org>
9405
9406 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
9407 came from a string character with a `cursor' property. (Bug#9229)
9408
ae9e757a
JD
94092011-08-04 Jan Djärv <jan.h.d@swipnet.se>
9410
9411 * Makefile.in (LIB_PTHREAD): New variable.
9412 (LIBES): Add LIB_PTHREAD (Bug#9216).
9413
9414 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
9415 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
9416
213bd7f2
AS
94172011-08-04 Andreas Schwab <schwab@linux-m68k.org>
9418
6b02f655 9419 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 9420
99aaf75f
JD
94212011-08-04 Jan Djärv <jan.h.d@swipnet.se>
9422
9423 * xterm.c (x_find_topmost_parent): New function.
9424 (x_set_frame_alpha): Find topmost parent window with
9425 x_find_topmost_parent and set the property there also (bug#9181).
9426 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
9427
c74e9d86
PE
94282011-08-04 Paul Eggert <eggert@cs.ucla.edu>
9429
9430 * callproc.c (Fcall_process): Avoid vfork clobbering
9431 the local vars buffer, coding_systems, current_dir.
9432
640c8776
SM
94332011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
9434
9435 * keymap.c (Fmake_composed_keymap): Move to subr.el.
9436
f26d0e4c
PE
94372011-08-03 Paul Eggert <eggert@cs.ucla.edu>
9438
8a10d76c
PE
9439 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
9440 so that it is not optimized away.
9441
f26d0e4c
PE
9442 * xdisp.c (compute_display_string_pos): Remove unused local.
9443
55439c61
EZ
94442011-08-02 Eli Zaretskii <eliz@gnu.org>
9445
9446 Fix slow cursor motion and scrolling in large buffers with
9447 selective display, like Org Mode buffers. (Bug#9218)
9448
9449 * dispextern.h (struct bidi_it): New member disp_prop_p.
9450
9451 * xdisp.c: Remove one-slot cache of display string positions.
9452 (compute_display_string_pos): Accept an additional argument
5e617bc2 9453 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
9454 for a display string or property. If found, set DISP_PROP_P
9455 non-zero.
9456
9457 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
9458 DISP_PROP_P, and pass it to compute_display_string_pos.
9459 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
9460 non-zero. All callers of bidi_fetch_char changed.
9461
fb33fa43
SM
94622011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
9463
9464 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
9465
b099e063
DM
94662010-12-03 Don March <don@ohspite.net>
9467
9468 * keymap.c (Fdefine_key): Fix non-prefix key error message when
9469 last character M-[char] is translated to ESC [char] (bug#7541).
9470
5cc7f7af
KH
94712011-08-02 Kenichi Handa <handa@m17n.org>
9472
d0fffa3f 9473 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
9474
9475 * chartab.c (uniprop_table): Make it non-static.
9476
525d5e6e
EZ
94772011-08-01 Eli Zaretskii <eliz@gnu.org>
9478
9479 * xdisp.c (forward_to_next_line_start): Accept additional argument
9480 BIDI_IT_PREV, and store into it the state of the bidi iterator had
9481 on the newline.
9482 (reseat_at_next_visible_line_start): Use the bidi iterator state
9483 returned by forward_to_next_line_start to restore the state of
9484 it->bidi_it after backing up to previous newline. (Bug#9212)
9485
31011111
AS
94862011-07-30 Andreas Schwab <schwab@linux-m68k.org>
9487
9488 * regex.c (re_comp): Protoize.
9489 (re_exec): Fix return type.
9490 (regexec): Fix type of `ret'. (Bug#9203)
9491
476371c4
PE
94922011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9493
e5d76069
PE
9494 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
9495 This is needed if max-image-size is a floating-point number.
9496
9a79b20c
AS
94972011-07-28 Andreas Schwab <schwab@linux-m68k.org>
9498
9499 * print.c (print_object): Print empty symbol as ##.
9500
9501 * lread.c (read1): Read ## as empty symbol.
9502
d8c2fa78
AA
95032011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
9504
9505 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
9506 setting frame foreground color (Bug#9175).
9507 (x_set_background_color): Likewise.
9508
ffe57a7a
AA
9509 * nsmenu.m (-setText): Size tooltip dimensions precisely to
9510 contents (Bug#9176).
9511 (EmacsTooltip -init): Remove bezels and add shadows to
9512 tooltip windows.
9513
bf3492a5
AA
9514 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
9515 or scroll bar (Bug#8470).
9516
d55e9c53
AA
9517 * nsfont.m (nsfont_open): Remove assignment to voffset and
9518 unnecessary vars hshink, expand, hd, full_height, min_height.
9519 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
9520
9521 * nsterm.h (nsfont_info): Remove voffset field.
9522
d8c2fa78 95232011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
9524
9525 Implement strike-through and overline on NextStep (Bug#8863).
9526
9527 * nsfont.m (nsfont_open): Use underline position provided by font,
9528 instead of hard-coded value of 2.
9529 (nsfont_draw): Call ns_draw_text_decoration instead.
9530
9531 * nsterm.h: Add declaration for ns_draw_text_decoration.
9532
9533 * nsterm.m (ns_draw_text_decoration): New function for drawing
9534 underline, overline, and strike-through.
9535 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
9536 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 9537 accommodate underlining, etc.
4843aac3 9538
4cc60b9b
EZ
95392011-07-28 Eli Zaretskii <eliz@gnu.org>
9540
bc7ece87
EZ
9541 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
9542 default.
4cc60b9b 9543
476371c4
PE
95442011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9545
66606eea
PE
9546 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
9547 Without this fix, if a signal arrives just after memory fills up,
9548 'malloc' might be invoked reentrantly.
9549
476371c4
PE
9550 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
9551 In other words, assume that every image size is allowed, on non-X
9552 hosts. This assumption is probably wrong, but it lets Emacs compile.
9553
f3fcc40d
AS
95542011-07-28 Andreas Schwab <schwab@linux-m68k.org>
9555
9556 * regex.c (re_iswctype): Convert return values to boolean.
9557
350c992f
EZ
95582011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
9559
9560 * xdisp.c (compute_display_string_pos): Don't use cached display
9561 string position if the buffer had its restriction changed.
9562 (Bug#9184)
9563
5266b4bb
PE
95642011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9565
9566 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9567
2573a837 95682011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 9569
41f55ccd 9570 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 9571
39e378da
PE
9572 * bidi.c: Integer size and overflow fixes.
9573 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
9574 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
9575 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9576 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
9577 (bidi_find_other_level_edge):
9578 Use ptrdiff_t instead of EMACS_INT where either will do.
9579 This works better on 32-bit hosts configured --with-wide-int.
9580 (bidi_cache_ensure_space): Check for size-calculation overflow.
9581 Use % rather than repeated addition, for better worst-case speed.
9582 Don't set bidi_cache_size until after xrealloc returns, because it
9583 might not return.
9584 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
9585 (bidi_cache_ensure_space): Also check that the bidi cache size
9586 does not exceed that of the largest Lisp string or buffer. See Eli
9587 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 9588
5e927815
PE
9589 * alloc.c (__malloc_size_t): Remove.
9590 All uses replaced by size_t. See Andreas Schwab's note
9591 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
9592
ca4aa935
PE
9593 * image.c: Improve checking for integer overflow.
9594 (check_image_size): Assume that f is nonnull, since
9595 it is always nonnull in practice. This is one less thing to
9596 worry about when checking for integer overflow later.
9597 (x_check_image_size): New function, which checks for integer
9598 overflow issues inside X.
9599 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
9600 This removes the need for a memory_full check.
9601 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
9602 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
9603 (xbm_read_bitmap_data): Change locals back to 'int', since
9604 their values must fit in 'int'.
9605 (xpm_load_image, png_load, tiff_load):
9606 Invoke x_create_x_image_and_pixmap earlier,
9607 to avoid much needless work if the image is too large.
9608 (tiff_load): Treat overly large images as if
9609 x_create_x_image_and_pixmap failed, not as malloc failures.
9610 (gs_load): Use x_check_image_size.
9611
5f8f9cc2
PE
9612 * gtkutil.c: Omit integer casts.
9613 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
9614 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
9615
5adf60bc
PE
9616 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
9617
c8907a93
PE
9618 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
9619 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
9620 would wrongly return t on a 64-bit host.
9621
e3c25c68
PE
9622 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
9623 The plain *_OVERFLOW macros run afoul of GCC bug 49705
9624 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
9625 and therefore cause GCC to emit a bogus diagnostic in some cases.
9626
3f791afe
PE
9627 * image.c: Integer signedness and overflow and related fixes.
9628 This is not an exhaustive set of fixes, but it's time to
9629 record what I've got.
9630 (lookup_pixel_color, check_image_size): Remove redundant decls.
9631 (check_image_size): Don't assume that arbitrary EMACS_INT values
9632 fit in 'int', or that arbitrary 'double' values fit in 'int'.
9633 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
9634 (tiff_load, imagemagick_load_image):
9635 Check for overflow in size calculations.
9636 (x_create_x_image_and_pixmap): Remove unnecessary test for
9637 xmalloc returning NULL; that can't happen.
9638 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
9639 (xpm_color_bucket): Use better integer hashing function.
9640 (xpm_cache_color): Don't possibly over-allocate memory.
9641 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
9642 (gif_memory_source):
9643 Use ptrdiff_t, not int or size_t, to record sizes.
9644 (png_load): Don't assume values greater than 2**31 fit in 'int'.
9645 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
9646 either works, as we prefer signed integers.
9647 (tiff_read_from_memory, tiff_write_from_memory):
9648 Return tsize_t, not size_t, since that's what the TIFF API wants.
9649 (tiff_read_from_memory): Don't fail simply because the read would
9650 go past EOF; instead, return a short read.
9651 (tiff_load): Omit no-longer-needed casts.
9652 (Fimagemagick_types): Don't assume size fits into 'int'.
9653
3cc5a532
PE
9654 Improve hashing quality when configured --with-wide-int.
9655 * fns.c (hash_string): New function, taken from sxhash_string.
9656 Do not discard information about ASCII character case; this
9657 discarding is no longer needed.
9658 (sxhash-string): Use it. Change sig to match it. Caller changed.
9659 * lisp.h: Declare it.
9660 * lread.c (hash_string): Remove, since we now use fns.c's version.
9661 The fns.c version returns a wider integer if --with-wide-int is
9662 specified, so this should help the quality of the hashing a bit.
9663
b312a492
PE
9664 * emacs.c: Integer overflow minor fix.
9665 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
9666 Define only if GNU_LINUX.
9667 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
9668
dfd153ae
PE
9669 * dispnew.c: Integer signedness and overflow fixes.
9670 Remove unnecessary forward decls, that were a maintenance hassle.
9671 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
9672 All uses changed.
9673 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
9674 (scrolling_window): Use ptrdiff_t, not int, for byte count.
9675 (prepare_desired_row, line_draw_cost):
9676 Use int, not unsigned, where either works.
9677 (save_current_matrix, restore_current_matrix):
9678 Use ptrdiff_t, not size_t, where either works.
9679 (init_display): Check for overflow more accurately, and without
9680 relying on undefined behavior.
9681
a81d11a3
PE
9682 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
9683 Remove, replacing with the new symbols in lisp.h. All uses changed.
9684 * fileio.c (make_temp_name):
9685 * filelock.c (lock_file_1, lock_file):
9686 * xdisp.c (message_dolog):
9687 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
9688 Use pMd etc. instead.
9689 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
9690 replacing the pWIDE etc. symbols removed from editfns.c.
9691
3300e6fd
PE
9692 * keyboard.h (num_input_events): Now uintmax_t.
9693 This is (very slightly) less likely to mess up due to wraparound.
9694 All uses changed.
9695
fd05c7e9
PE
9696 * buffer.c: Integer signedness fixes.
9697 (alloc_buffer_text, enlarge_buffer_text):
9698 Use ptrdiff_t rather than size_t when either will do, as we prefer
9699 signed integers.
9700
903fe15d
PE
9701 * alloc.c: Integer signedness and overflow fixes.
9702 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
9703 (__malloc_size_t): Default to size_t, not to int.
9704 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
9705 (Fgarbage_collect, mark_object_loop_halt, mark_object):
9706 Prefer ptrdiff_t to size_t when either would do, as we prefer
9707 signed integers.
9708 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
9709 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
9710 Now const. Initialize with values that are in range even if char
9711 is signed.
9712 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
9713 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
9714 These functions do the right thing with sizes > 2**32.
9715 (check_depth): Now ptrdiff_t, not int.
9716 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
9717 Adjust to new way of storing sizes. Check for size overflow bugs
9718 in rest of code.
9719 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
9720 slightly wrong anyway, as it missed one instance of
9721 XMALLOC_OVERRUN_CHECK_OVERHEAD.
9722 (refill_memory_reserve): Omit needless cast to size_t.
9723 (mark_object_loop_halt): Mark as externally visible.
9724
ac82cc6a
PE
9725 * xselect.c: Integer signedness and overflow fixes.
9726 (Fx_register_dnd_atom, x_handle_dnd_message):
9727 Use ptrdiff_t, not size_t, since we prefer signed.
9728 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
9729 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
9730 x_dnd_atoms_size and x_dnd_atoms_length.
9731
c2d1e36d
PE
9732 * doprnt.c: Prefer signed to unsigned when either works.
9733 * eval.c (verror):
9734 * doprnt.c (doprnt):
9735 * lisp.h (doprnt):
9736 * xdisp.c (vmessage):
9737 Use ptrdiff_t, not size_t, when using or implementing doprnt,
9738 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
9739 prefer signed arithmetic to avoid comparison confusion.
9740 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
9741 but is a bit tricky.
9742
0e926e56
PE
9743 Assume freestanding C89 headers, string.h, stdlib.h.
9744 * data.c, doprnt.c, floatfns.c, print.c:
9745 Include float.h unconditionally.
9746 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
9747 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
9748 * regex.c: Likewise for stddef.h, string.h.
9749 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
9750 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
9751 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
9752 (STDC_HEADERS): Remove obsolete defines.
9753 * sysdep.c: Include limits.h unconditionally.
9754
9cfdb3ec
PE
9755 Assume support for memcmp, memcpy, memmove, memset.
9756 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
9757 * regex.c (memcmp, memcpy):
9758 Remove; we assume C89 now.
9759
9760 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
9761 (__malloc_safe_bcopy): Remove; no longer needed.
9762
cf950e6b 9763 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
9764 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
9765 well either way, and we prefer signed to unsigned.
9766
dbf38e02
LMI
97672011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
9768
9769 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
9770 closes the connection while we're reading (bug#9182).
9771
d6f0886c 97722011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 9773
d6f0886c
JD
9774 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
9775 are specified (Bug#9168).
24e0f6b1 9776
2eb1f9e6
PE
97772011-07-25 Paul Eggert <eggert@cs.ucla.edu>
9778
9779 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
9780 Found by GCC static checking and --with-wide-int on a 32-bit host.
9781
22381272 97822011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
9783
9784 * xdisp.c (compute_display_string_pos): Fix logic of caching
9785 previous display string position. Initialize cached_prev_pos to
9786 -1. Fixes slow-down at the beginning of a buffer.
9787
f25e39b4
EZ
97882011-07-24 Eli Zaretskii <eliz@gnu.org>
9789
9790 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
9791 for attrs[LFACE_FONTSET_INDEX].
9792
04c4b52e
PE
97932011-07-23 Paul Eggert <eggert@cs.ucla.edu>
9794
9795 * xml.c (parse_region): Remove unused local
9796 that was recently introduced.
9797
c1734fbd
EZ
97982011-07-23 Eli Zaretskii <eliz@gnu.org>
9799
be18c5a5
EZ
9800 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
9801 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
9802
c1734fbd
EZ
9803 * xdisp.c (move_it_in_display_line_to): Record the best matching
9804 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
9805 exit if none of the characters scanned was an exact match.
9806 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
9807 when exact match is impossible due to invisible text, and the
9808 lines are truncated.
9809
a258d627
JD
98102011-07-23 Jan Djärv <jan.h.d@swipnet.se>
9811
9812 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
9813 for OSX >= 10.7.
9814
b6d5a689
EZ
98152011-07-22 Eli Zaretskii <eliz@gnu.org>
9816
0f74f785
EZ
9817 Fix a significant slow-down of cursor motion with C-n, C-p,
9818 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
9819 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 9820 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
9821 (next_element_from_buffer): Call compute_stop_pos_backwards to
9822 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
9823 base_level_stop.
9824 (reseat): Don't look for prev_stop, as that could mean a very long
9825 run.
9826 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
9827 <cached_disp_overlay_modiff>: Cache for last found display string
9828 position.
551918c1 9829 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
9830 about the same buffer in the same area of character positions, and
9831 the buffer wasn't changed since the time the display string
9832 position was cached.
551918c1 9833
b2d0c91a
EZ
98342011-07-22 Eli Zaretskii <eliz@gnu.org>
9835
9836 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
9837 is an integer, which is important for empty lines. (Bug#9149)
9838
043604ee
CY
98392011-07-22 Chong Yidong <cyd@stupidchicken.com>
9840
9841 * frame.c (Fmodify_frame_parameters): In tty case, update the
9842 default face if necessary (Bug#4238).
9843
da4adb04
CY
98442011-07-21 Chong Yidong <cyd@stupidchicken.com>
9845
9846 * editfns.c (Fstring_to_char): No need to explain what a character
9847 is in the docstring (Bug#6576).
9848
9abd0532
LMI
98492011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9850
9851 * xml.c (parse_region): Make sure we always return a tree.
9852
36881d16
HK
98532011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
9854
9855 * xml.c (parse_region): If a document contains only comments,
9856 return that, too.
9857
1e98674d
LMI
98582011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9859
9860 * xml.c (make_dom): Return comments, too.
9861
590bd467
PE
98622011-07-19 Paul Eggert <eggert@cs.ucla.edu>
9863
9864 Port to OpenBSD.
9865 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
9866 and the surrounding thread.
9867 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
9868 rather than fgets, and retry after EINTR. Otherwise, 'emacs
9869 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
9870 timer goes off.
9871 * s/openbsd.h (BROKEN_SIGIO): Define.
9872 * unexelf.c (unexec) [__OpenBSD__]:
9873 Don't update the .mdebug section of the Alpha COFF symbol table.
9874
f41628b2
LMI
98752011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
9876
9877 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
9878 (bug#8460).
9879
b59b67c5
PE
98802011-07-18 Paul Eggert <eggert@cs.ucla.edu>
9881
15e3a074
PE
9882 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
9883 This fixes some race conditions on the permissions of any newly
9884 created file.
9885
41bed37d
PE
9886 * alloc.c (valid_pointer_p): Use pipe, not open.
9887 This fixes some permissions issues when debugging.
9888
b59b67c5
PE
9889 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
9890 If fchown fails to set both uid and gid, try to set just gid,
9891 as that is sometimes allowed. Adjust the file's mode to eliminate
9892 setuid or setgid bits that are inappropriate if fchown fails.
9893
925a6be7
SM
98942011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
9895
9896 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
9897 to compare Lisp_Objects.
9898 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
9899 global_gnutls_log_level, don't mistake it for a Lisp_Object.
9900 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
9901
52968808
AS
99022011-07-17 Andreas Schwab <schwab@linux-m68k.org>
9903
0a6a104b
AS
9904 * lread.c (read_integer): Unread even EOF character.
9905 (read1): Likewise. Properly record start position of symbol.
9906
52968808
AS
9907 * lread.c (read1): Read `#:' as empty uninterned symbol if no
9908 symbol character follows.
9909
9e381cdd
PE
99102011-07-17 Paul Eggert <eggert@cs.ucla.edu>
9911
9912 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
9913 This works around a problem with the previous change to Fcopy_file.
9914 Recent glibc declares fchown with __attribute__((warn_unused_result)),
9915 and without this change, GCC might complain about discarding
9916 fchown's return value.
9917
b5641435
JB
99182011-07-16 Juanma Barranquero <lekktu@gmail.com>
9919
9920 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
9921
a8031457
PE
99222011-07-16 Paul Eggert <eggert@cs.ucla.edu>
9923
9924 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
9925
dd889327
LMI
99262011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
9927
750c33f7
LMI
9928 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
9929 it's used from the C level.
9930
dd889327
LMI
9931 * process.c: Use the same condition for POLL_FOR_INPUT in both
9932 keyboard.c and process.c (bug#1858).
9933
87e86684
LM
99342011-07-09 Lawrence Mitchell <wence@gmx.li>
9935
9936 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
9937 (Fgnutls_boot): Use it.
9938
64348f40
AS
99392011-07-15 Andreas Schwab <schwab@linux-m68k.org>
9940
9941 * doc.c (Fsubstitute_command_keys): Revert last change.
9942
1d698799
LMI
99432011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
9944
f863868c
LMI
9945 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
9946 quotes the next character, and doesn't affect other longer
9947 sequences (bug#8935).
9948
1d698799
LMI
9949 * lread.c (syms_of_lread): Clarify that is isn't only
9950 `eval-buffer' and `eval-defun' that's affected by
9951 `lexical-binding' (bug#8460).
9952
aa4b6df6
EZ
99532011-07-15 Eli Zaretskii <eliz@gnu.org>
9954
9955 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 9956 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 9957
5d856da6
PE
99582011-07-14 Paul Eggert <eggert@cs.ucla.edu>
9959
ad6042bb
PE
9960 Fix minor problems found by static checking.
9961 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
9962 (elsz): Now a signed constant, not a size_t var. We prefer signed
9963 types to unsigned, to avoid integer comparison confusion. Without
9964 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
9965 "cannot optimize loop, the loop counter may overflow", a symptom
9966 of the confusion.
f00bbb22 9967 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
9968 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
9969
6468f31c
LMI
99702011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9971
49080b10
LMI
9972 * search.c (Fre_search_backward): Mention `case-fold-search' in
9973 all the re_search_* functions (bug#8138).
9974
6468f31c
LMI
9975 * keyboard.c (Fopen_dribble_file): Document when the file is
9976 closed (bug#8056).
9977
c965adc5
EZ
99782011-07-14 Eli Zaretskii <eliz@gnu.org>
9979
df9733bf
EZ
9980 * bidi.c (bidi_dump_cached_states): Fix format of displaying
9981 bidi_cache_idx.
9982
0bb23927
EZ
9983 Support bidi reordering of display and overlay strings.
9984 * xdisp.c (compute_display_string_pos)
9985 (compute_display_string_end): Accept additional argument STRING.
9986 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
9987 (reseat_to_string): Initialize bidi_it->string.s and
9988 bidi_it->string.schars.
9989 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
9990 NULL (avoids a crash in bidi_paragraph_init).
9991 Initialize itb.string.lstring.
0bb23927
EZ
9992 (init_iterator): Call bidi_init_it only of a valid
9993 buffer position was specified. Initialize paragraph_embedding to
9994 L2R.
9995 (reseat_to_string): Initialize the bidi iterator.
9996 (display_string): If we need to ignore text properties of
9997 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
9998 original value of -1 will not work with bidi.)
9999 (compute_display_string_pos): First arg is now struct
10000 `text_pos *'; all callers changed. Support display properties on
10001 Lisp strings.
10002 (compute_display_string_end): Support display properties on Lisp
10003 strings.
10004 (init_iterator, reseat_1, reseat_to_string): Initialize the
10005 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
10006 when iterating on a string not from display properties).
640c8776
SM
10007 (compute_display_string_pos, compute_display_string_end):
10008 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
10009 arrow keys.
10010 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
10011 base_level_stop; instead, set base_level_stop to BEGV.
10012 Fixes crashes in vertical-motion.
0bb23927
EZ
10013 (next_element_from_buffer): Improve commentary for when
10014 the iterator is before prev_stop.
10015 (init_iterator): Initialize bidi_p from the default value of
10016 bidi-display-reordering, not from buffer-local value. Use the
10017 buffer-local value only if initializing for buffer iteration.
10018 (handle_invisible_prop): Support invisible properties on strings
10019 that are being bidi-reordered.
10020 (set_iterator_to_next): Support bidi reordering of C strings and
10021 Lisp strings.
10022 (next_element_from_string): Support bidi reordering of Lisp
10023 strings.
10024 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
10025 (display_string): Support display of R2L glyph rows.
10026 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
10027 (init_iterator): Don't initialize it->bidi_p for strings
10028 here.
10029 (reseat_to_string): Initialize it->bidi_p for strings here.
10030 (next_element_from_string, next_element_from_c_string)
10031 (next_element_from_buffer): Add xassert's for correspondence
10032 between IT's object being iterated and it->bidi_it.string
10033 structure.
10034 (face_before_or_after_it_pos): Support bidi iteration.
10035 (next_element_from_c_string): Handle the case of the first string
10036 character that is not the first one in the visual order.
10037 (get_visually_first_element): New function, refactored from common
10038 parts of next_element_from_buffer, next_element_from_string, and
10039 next_element_from_c_string.
10040 (tool_bar_lines_needed, redisplay_tool_bar)
10041 (display_menu_bar): Force left-to-right direction. Add a FIXME
10042 comment for making that be controlled by a user option.
10043 (push_it, pop_it): Save and restore the state of the
10044 bidi iterator. Save and restore the bidi_p flag.
10045 (pop_it): Iterate out of display property for string iteration as
10046 well.
10047 (iterate_out_of_display_property): Support iteration over strings.
10048 (handle_single_display_spec): Set up it->bidi_it for iteration
10049 over a display string, and call bidi_init_it.
10050 (handle_single_display_spec, next_overlay_string)
10051 (get_overlay_strings_1, push_display_prop): Set up the bidi
10052 iterator for displaying display or overlay strings.
10053 (forward_to_next_line_start): Don't use the shortcut if
10054 bidi-iterating.
10055 (back_to_previous_visible_line_start): If handle_display_prop
10056 pushed the iterator stack, restore the internal state of the bidi
10057 iterator by calling bidi_pop_it same number of times.
10058 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
10059 and we are bidi-iterating, don't decrement the iterator position;
10060 instead, set the first_elt flag in the bidi iterator, to produce
10061 the same effect.
10062 (reseat_1): Remove redundant setting of string_from_display_prop_p.
10063 (push_display_prop): xassert that we are iterating a buffer.
10064 (push_it, pop_it): Save and restore paragraph_embedding member.
10065 (handle_single_display_spec, next_overlay_string)
10066 (get_overlay_strings_1, reseat_1, reseat_to_string)
10067 (push_display_prop): Set up the `unibyte' member of bidi_it.string
10068 correctly. Don't assume unibyte strings are not bidi-reordered.
10069 (compute_display_string_pos)
10070 (compute_display_string_end): Fix handling the case of C string.
10071 (push_it, pop_it): Save and restore from_disp_prop_p.
10072 (handle_single_display_spec, push_display_prop): Set the
10073 from_disp_prop_p flag.
10074 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
10075 (pop_it): Call iterate_out_of_display_property only if we are
10076 popping after iteration over a string that came from a display
10077 property. Fix a typo in popping stretch info. Add an assertion
10078 for verifying that the iterator position is in sync with the bidi
10079 iterator.
10080 (handle_single_display_spec, get_overlay_strings_1)
10081 (push_display_prop): Fix initialization of paragraph direction for
10082 string when that of the parent object is not yet determined.
10083 (reseat_1): Call bidi_init_it to resync the bidi
10084 iterator with IT's position. (Bug#7616)
10085 (find_row_edges): If ROW->start.pos gives position
10086 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
10087 (handle_stop, back_to_previous_visible_line_start, reseat_1):
10088 Reset the from_disp_prop_p flag.
10089 (SAVE_IT, RESTORE_IT): New macros.
10090 (pos_visible_p, face_before_or_after_it_pos)
10091 (back_to_previous_visible_line_start)
10092 (move_it_in_display_line_to, move_it_in_display_line)
10093 (move_it_to, move_it_vertically_backward, move_it_by_lines)
10094 (try_scrolling, redisplay_window, display_line): Use them when
10095 saving a temporary copy of the iterator and restoring it back.
10096 (back_to_previous_visible_line_start, reseat_1)
10097 (init_iterator): Empty the bidi cache "stack".
10098 (move_it_in_display_line_to): If iterator ended up at
10099 EOL, but we never saw any buffer positions smaller than
10100 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
10101 motion in bidi-reordered lines.
10102 (move_it_in_display_line_to): Record prev_method and prev_pos
10103 immediately before the call to set_iterator_to_next. Fixes cursor
10104 motion in bidi-reordered lines with stretch glyphs and strings
10105 displayed in margins. (Bug#8133) (Bug#8867)
10106 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
10107 TO_CHARPOS.
640c8776
SM
10108 (pos_visible_p): Support positions in bidi-reordered lines.
10109 Save and restore bidi cache.
0bb23927
EZ
10110
10111 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
10112 (bidi_paragraph_info): Delete unused struct.
10113 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
10114 (bidi_cache_start): New variable.
10115 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
10116 to zero.
10117 (bidi_cache_fetch_state, bidi_cache_search)
10118 (bidi_cache_find_level_change, bidi_cache_iterator_state)
10119 (bidi_cache_find, bidi_peek_at_next_level)
10120 (bidi_level_of_next_char, bidi_find_other_level_edge)
10121 (bidi_move_to_visually_next): Compare cache index with
10122 bidi_cache_start rather than with zero.
10123 (bidi_fetch_char): Accept new argument STRING; all callers
10124 changed. Support iteration over a string. Support strings with
10125 display properties. Support unibyte strings. Fix the type of
10126 `len' according to what STRING_CHAR_AND_LENGTH expects.
10127 (bidi_paragraph_init, bidi_resolve_explicit_1)
10128 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
10129 (bidi_level_of_next_char, bidi_move_to_visually_next):
10130 Support iteration over a string.
0bb23927
EZ
10131 (bidi_set_sor_type, bidi_resolve_explicit_1)
10132 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
10133 can now be zero (for strings); special values 0 and -1 were
10134 changed to -1 and -2, respectively.
10135 (bidi_char_at_pos): New function.
10136 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
10137 Call it instead of FETCH_MULTIBYTE_CHAR.
10138 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
10139 initialized to valid values.
10140 (bidi_init_it): Don't initialize charpos and bytepos with invalid
10141 values.
10142 (bidi_level_of_next_char): Allow the sentinel "position" to pass
10143 the test for valid cached positions. Fix the logic for looking up
10144 the sentinel state in the cache. GCPRO the Lisp string we are
10145 iterating.
10146 (bidi_push_it, bidi_pop_it): New functions.
10147 (bidi_initialize): Initialize the bidi cache start stack pointer.
10148 (bidi_cache_ensure_space): New function, refactored from part of
10149 bidi_cache_iterator_state. Don't assume the required size is just
10150 one BIDI_CACHE_CHUNK away.
10151 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
10152 (bidi_count_bytes, bidi_char_at_pos): New functions.
10153 (bidi_cache_search): Don't assume bidi_cache_last_idx is
10154 always valid if bidi_cache_idx is valid.
10155 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
10156 is valid if it's going to be used.
10157 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
10158 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
10159 (bidi_cache_find_level_change, bidi_cache_ensure_space)
10160 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
10161 (bidi_find_other_level_edge, bidi_cache_start_stack):
10162 All variables related to cache indices are now EMACS_INT.
c965adc5 10163
0bb23927
EZ
10164 * dispextern.h (struct bidi_string_data): New structure.
10165 (struct bidi_it): New member `string'. Make flag members be 1-bit
10166 fields, and put them last in the struct.
640c8776
SM
10167 (compute_display_string_pos, compute_display_string_end):
10168 Update prototypes.
0bb23927
EZ
10169 (bidi_push_it, bidi_pop_it): Add prototypes.
10170 (struct iterator_stack_entry): New members bidi_p,
10171 paragraph_embedding, and from_disp_prop_p.
10172 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
10173 (bidi_shelve_cache, bidi_unshelve_cache):
10174 Declare prototypes.
0bb23927
EZ
10175
10176 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
10177 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
10178 and vector-like objects.
10179
10180 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
10181 cache around display iteration.
10182
10183 * window.c (Fwindow_end, window_scroll_pixel_based)
10184 (displayed_window_lines, Frecenter): Save and restore the bidi
10185 cache around display iteration.
10186
3bbd2265
LMI
101872011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
10188
10189 * editfns.c (Fdelete_region): Clarify the use of the named
10190 parameters (bug#6788).
10191
adc47434
MR
101922011-07-14 Martin Rudalics <rudalics@gmx.at>
10193
10194 * indent.c (Fvertical_motion): Set and restore w->pointm when
10195 saving and restoring the window's buffer (Bug#9006).
10196
837c31f8
LMI
101972011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
10198
10199 * editfns.c (Fstring_to_char): Clarify just what is returned
10200 (bug#6576). Text by Eli Zaretskii.
10201
ac389d0c
JB
102022011-07-13 Juanma Barranquero <lekktu@gmail.com>
10203
10204 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
10205
0be0ce47
EZ
102062011-07-13 Eli Zaretskii <eliz@gnu.org>
10207
10208 * buffer.c (mmap_find): Fix a typo.
10209
cd18e7e3
JB
102102011-07-13 Johan Bockgård <bojohan@gnu.org>
10211
10212 Fix execution of x selection hooks.
10213 * xselect.c (Qx_lost_selection_functions)
10214 (Qx_sent_selection_functions): New vars.
10215 (syms_of_xselect): DEFSYM them.
10216 (x_handle_selection_request): Pass Qx_sent_selection_functions
10217 rather than Vx_sent_selection_functions to Frun_hook_with_args.
10218 (x_handle_selection_clear,x_clear_frame_selections):
10219 Pass Qx_lost_selection_functions rather than
10220 Vx_lost_selection_functions to Frun_hook_with_args.
10221
47ea7f44
PE
102222011-07-13 Paul Eggert <eggert@cs.ucla.edu>
10223
ac389d0c 10224 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
10225 The old code sometimes used this field without initializing it.
10226
47ea7f44
PE
10227 * alloc.c (gc_sweep): Don't read past end of array.
10228 In theory, the old code could also have corrupted Emacs internals,
10229 though it'd be very unlikely.
10230
bc985c87
AS
102312011-07-12 Andreas Schwab <schwab@linux-m68k.org>
10232
10233 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 10234 argument. (Bug#4026)
bc985c87 10235
0cf34688
LMI
102362011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
10237
b3dadd76
LMI
10238 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
10239 key" (bug#4257).
10240
0cf34688
LMI
10241 * window.c (Fset_window_start): Doc fix (bug#4199).
10242 (Fset_window_hscroll): Ditto.
10243
270768cd
PE
102442011-07-12 Paul Eggert <eggert@cs.ucla.edu>
10245
077e3dda 10246 Fix minor new problems caught by GCC 4.6.1.
270768cd 10247 * term.c (init_tty): Remove unused local.
490011a6 10248 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 10249 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 10250 not used otherwise.
270768cd 10251
b1f58454
CY
102522011-07-12 Chong Yidong <cyd@stupidchicken.com>
10253
10254 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
10255
22b9578d
LMI
102562011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
10257
6e70ab07
LMI
10258 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
10259 are the mini-buffer and the echo area (bug#3320).
10260
22b9578d
LMI
10261 * term.c (init_tty): Remove support for supdup, c10 and perq
10262 terminals, which are no longer supported (bug#1482).
10263
8974cc9f
JB
102642011-07-10 Johan Bockgård <bojohan@gnu.org>
10265
10266 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
10267
a560d974
JD
102682011-07-10 Jan Djärv <jan.h.d@swipnet.se>
10269
10270 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
10271 for non-popups (Bug#3642).
10272
1dae0f0a
AS
102732011-07-10 Andreas Schwab <schwab@linux-m68k.org>
10274
268c2c36 10275 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 10276 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
10277 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
10278 * cm.c (losecursor): Likewise.
1dae0f0a
AS
10279 * data.c (fmod): Likewise.
10280 * dispnew.c (swap_glyphs_in_rows): Likewise.
10281 * emacs.c (memory_warning_signal): Likewise.
10282 * floatfns.c (float_error): Likewise.
10283 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
10284 (otf_open, font_otf_capability, generate_otf_features)
10285 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
10286 Likewise.
10287 * image.c (pbm_read_file): Likewise.
10288 * indent.c (string_display_width): Likewise.
10289 * intervals.c (check_for_interval, search_for_interval)
10290 (inc_interval_count, count_intervals, root_interval)
10291 (adjust_intervals_for_insertion, make_new_interval): Likewise.
10292 * lread.c (defalias): Likewise.
268c2c36 10293 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
10294 * regex.c (set_image_of_range_1, set_image_of_range)
10295 (regex_grow_registers): Likewise.
10296 * sysdep.c (strerror): Likewise.
10297 * termcap.c (valid_filename_p, tprint, main): Likewise.
10298 * tparam.c (main): Likewise.
10299 * unexhp9k800.c (run_time_remap, save_data_space)
10300 (update_file_ptrs, read_header, write_header, calculate_checksum)
10301 (copy_file, copy_rest, display_header): Likewise.
10302 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
10303 Likewise.
10304 * xdisp.c (check_it): Likewise.
10305 * xfaces.c (register_color, unregister_color, unregister_colors):
10306 Likewise.
10307 * xfns.c (print_fontset_result): Likewise.
10308 * xrdb.c (member, fatal, main): Likewise.
10309
99033785
PE
103102011-07-10 Paul Eggert <eggert@cs.ucla.edu>
10311
10312 Fix minor problems found by static checking (Bug#9031).
10313 * chartab.c (char_table_set_range, map_sub_char_table):
10314 Remove unused locals.
10315 (uniprop_table): Now static.
10316 * composite.c (_work_char): Remove unused static var.
10317
9cb2ac56
JB
103182011-07-09 Juanma Barranquero <lekktu@gmail.com>
10319
10320 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
10321
f25661f0
JD
103222011-07-09 Jan Djärv <jan.h.d@swipnet.se>
10323
10324 * gtkutil.c (qttip_cb): Remove code without function.
10325
8278c4fe
EZ
103262011-07-09 Eli Zaretskii <eliz@gnu.org>
10327
10328 * w32.c (pthread_sigmask): New stub.
10329
1692ae2d 103302011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 10331
8a6ebd58 10332 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
10333 sigprocmask is portable only for single-threaded applications, and
10334 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
10335 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
10336 (LIBES): Use it.
10337 * callproc.c (Fcall_process):
10338 * process.c (create_process):
10339 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
10340 Use pthread_sigmask, not sigprocmask.
123403e4 10341
1b854618
JD
103422011-07-08 Jan Djärv <jan.h.d@swipnet.se>
10343
10344 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
10345 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
10346 wrong (Bug#8591).
10347
3fe4b549
JD
103482011-07-08 Jan Djärv <jan.h.d@swipnet.se>
10349
0ce7e563
JD
10350 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
10351 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
10352 (xg_hide_tooltip): Fix comment.
10353
3fe4b549
JD
10354 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
10355 in registerServicesMenuSendTypes.
10356 (validRequestorForSendType): Don't check ns_return_types.
10357
10358 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
10359 ns_return_type.
10360
5df75e47
JR
103612011-07-08 Jason Rumney <jasonr@gnu.org>
10362
22610910
JR
10363 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
10364 SH_SHOW for hidden windows (Bug#5482).
10365
5df75e47
JR
10366 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
10367 frame struct members of non-existent frames (Bug#6284).
10368
699c10bd
JD
103692011-07-08 Jan Djärv <jan.h.d@swipnet.se>
10370
4393663b
JD
10371 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
10372 variable firstTime not needed on OSX >= 10.6.
10373 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
10374 >= 10.5. Use setKnobProportion, setDoubleValue.
10375
10376 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
10377 (MAC_OS_X_VERSION_10_5): Define if not defined.
10378 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
10379 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
10380 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
10381
10382 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 10383 cString and lossyCString on OSX >= 10.4.
4393663b 10384
58179cce 10385 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
10386 sizeToFit on OSX >= 10.2.
10387
10388 * nsimage.m (allocInitFromFile): Don't use deprecated method
10389 bestRepresentationForDevice on OSX >= 10.6.
10390
10391 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
10392 to avoid warning.
10393
10394 * emacs.c: Declare unexec_init_emacs_zone.
10395
a63e0781
JD
10396 * nsgui.h: Fix compiler warning about gnulib redefining verify.
10397
699c10bd
JD
10398 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
10399
10400 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
10401 on svcsMenu (Bug#8842).
10402
10403 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
10404 ns_return_types.
10405 (Fns_list_services): Just return Qnil on 10.6, code not working there.
10406
10407 * nsterm.m (QUTF8_STRING): Declare.
10408 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
10409 (validRequestorForSendType): Return type is (id).
10410 Change indexOfObjectIdenticalTo to indexOfObject.
10411 Check if we have local selection before returning self (Bug#8842).
10412 (writeSelectionToPasteboard): Put local selection into paste board
10413 if we have a local selection (Bug#8842).
10414 (syms_of_nsterm): DEFSYM QUTF8_STRING.
10415
10416 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
10417 (ns_get_local_selection): Declare.
10418
54e10184
LMI
104192011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
10420
9888ff71
LMI
10421 * keymap.c (describe_map_tree): Don't insert a double newline at
10422 the end of the buffer (bug#1169) and return whether we inserted
10423 something.
10424
54e10184
LMI
10425 * callint.c (Fcall_interactively): Change "reading args" to
10426 "providing args" to try to clarify what it does (bug#1010).
10427
15fa4783
KH
104282011-07-07 Kenichi Handa <handa@m17n.org>
10429
10430 * composite.c (composition_compute_stop_pos): Ignore a static
10431 composition starting before CHARPOS (Bug#8915).
10432
10433 * xdisp.c (handle_composition_prop): Likewise.
10434
a8815b00
EZ
104352011-07-07 Eli Zaretskii <eliz@gnu.org>
10436
10437 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
10438 (Bug#9015)
10439
ef7b981d 104402011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
10441
10442 * character.h (unicode_category_t): New enum type.
10443
10444 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
10445 (Qchar_code_property_table): New variable.
10446 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
10447 (UNIPROP_COMPRESSED_FORM_P): New macros.
10448 (char_table_ascii): Uncompress the compressed values.
10449 (sub_char_table_ref): New arg is_uniprop. Callers changed.
10450 Uncompress the compressed values.
ac389d0c 10451 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
10452 (char_table_ref_and_range): Uncompress the compressed values.
10453 (sub_char_table_set): New arg is_uniprop. Callers changed.
10454 Uncompress the compressed values.
10455 (sub_char_table_set_range): Args changed. Callers changed.
10456 (char_table_set_range): Adjuted for the above change.
10457 (map_sub_char_table): Delete args default_val and parent. Add arg
10458 top. Give decoded values to a Lisp function.
640c8776 10459 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
10460 values to a Lisp function. Gcpro more variables.
10461 (uniprop_table_uncompress)
10462 (uniprop_decode_value_run_length): New functions.
10463 (uniprop_decoder, uniprop_decoder_count): New variables.
10464 (uniprop_get_decoder, uniprop_encode_value_character)
10465 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
10466 New functions.
10467 (uniprop_encoder, uniprop_encoder_count): New variables.
10468 (uniprop_get_encoder, uniprop_table)
10469 (Funicode_property_table_internal, Fget_unicode_property_internal)
10470 (Fput_unicode_property_internal): New functions.
10471 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
10472 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 10473 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
10474 char-code-property-alist.
10475
640c8776 10476 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
10477 Vunicode_category_table.
10478
640c8776 10479 * font.c (font_range): Adjust for the change of
c805dec0
KH
10480 Vunicode_category_table.
10481
76b397fb
DN
104822011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
10483
10484 * m/iris4d.h: Remove file, move contents ...
10485 * s/irix6-5.h: ... here.
10486
22b4128e
PE
104872011-07-06 Paul Eggert <eggert@cs.ucla.edu>
10488
10489 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
10490 * alloc.c (mark_buffer):
10491 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
10492 (clone_per_buffer_values): Don't assume that
22b4128e
PE
10493 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
10494 This isn't true in general, and it's particularly not true
10495 if Emacs is configured with --with-wide-int.
10496 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
10497 New macros, used in the buffer.c change.
10498
869795d6
JD
104992011-07-05 Jan Djärv <jan.h.d@swipnet.se>
10500
10501 * xsettings.c: Use both GConf and GSettings if both are available.
10502 (store_config_changed_event): Add comment.
10503 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
10504 (store_tool_bar_style_changed): New functions.
5e617bc2 10505 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
10506 (struct xsettings): Move font inside HAVE_XFT.
10507 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 10508 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 10509 Move inside HAVE_XFT.
640c8776 10510 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
10511 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
10512 also.
10513 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 10514 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 10515 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
10516 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
10517 (parse_settings): Move check for font inside HAVE_XFT.
10518 (read_settings, apply_xft_settings): Add comment.
10519 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
10520 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
10521 call store_font_name_changed.
10522 (xft_settings_event): Add comment.
10523 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
10524 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
10525 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
10526 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
10527 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
10528 (xsettings_get_system_font, xsettings_get_system_normal_font):
10529 Add comment.
869795d6 10530
d8ed26bd
PE
105312011-07-05 Paul Eggert <eggert@cs.ucla.edu>
10532
10533 Random fixes. E.g., (random) never returned negative values.
10534 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
10535 subseconds part to the entropy, as that's a bit more random.
10536 Prefer signed to unsigned, since the signedness doesn't matter and
10537 in general we prefer signed. When given a limit, use a
10538 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
10539 latter isn't right if USE_2_TAGS_FOR_INTS.
10540 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
10541 not 0..VALMASK. Don't discard "excess" bits that random () returns.
10542
cabf1cac
SM
105432011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
10544
10545 * textprop.c (text_property_stickiness):
10546 Obey Vtext_property_default_nonsticky.
10547 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
10548 * w32fns.c (syms_of_w32fns):
10549 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
10550
6e9b2be9
PE
105512011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10552
10553 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
10554 This is more efficient than Ffile_directory_p and avoids a minor race.
10555
90186c68
LMI
105562011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
10557
7c301272
LMI
10558 * buffer.c (Foverlay_put): Say what the return value is
10559 (bug#7835).
10560
c4f2d8d4
LMI
10561 * fileio.c (barf_or_query_if_file_exists): Check first if the file
10562 is a directory before asking whether to use the file name
10563 (bug#7564).
ad637907
LMI
10564 (barf_or_query_if_file_exists): Make the "File is a directory"
10565 error be more correct.
c4f2d8d4 10566
90186c68
LMI
10567 * fns.c (Frequire): Remove the mention of the .gz files, since
10568 that's installation-specific, but keep the mention of
10569 `get-load-suffixes'.
10570
da64016e
PE
105712011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10572
10573 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
10574 Report string overflow if the output is too long.
10575
7d47b580
JB
105762011-07-04 Juanma Barranquero <lekktu@gmail.com>
10577
a555cb87
JB
10578 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
10579 (syms_of_gnutls): Remove duplicate DEFSYM for
10580 Qgnutls_bootprop_verify_hostname_error, an error for
10581 Qgnutls_bootprop_verify_error (which is no longer used).
10582
7d47b580
JB
10583 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
10584 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
10585 Also (re)move comments that are misplaced or no longer relevant.
10586
1e49bfab
LMI
105872011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10588
10589 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
10590
1485f4c0
CY
105912011-07-03 Chong Yidong <cyd@stupidchicken.com>
10592
10593 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
10594 and background color parameters if they have been changed.
10595
a9ab721e
LMI
105962011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10597
10598 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
10599
cf7cff57
PE
106002011-07-03 Paul Eggert <eggert@cs.ucla.edu>
10601
2e13213d
PE
10602 * xsettings.c (SYSTEM_FONT): Define only when used.
10603 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
10604
cf7cff57
PE
10605 * keymap.c (access_keymap_1): Now static.
10606
7a8e04f7
CY
106072011-07-02 Chong Yidong <cyd@stupidchicken.com>
10608
10609 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
10610 leave any prefix arg for the up event (Bug#1586).
10611
61352f62
LMI
106122011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
10613
69bb1ef7
LMI
10614 * lread.c (syms_of_lread): Mention single symbols defined by
10615 `defvar' or `defconst' (bug#7154).
10616
61352f62 10617 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 10618 (Frequire): Mention get-load-suffixes.
61352f62 10619
28545e04
MR
106202011-07-02 Martin Rudalics <rudalics@gmx.at>
10621
10622 * window.h (window): Remove clone_number slot.
10623 * window.c (Fwindow_clone_number, Fset_window_clone_number):
10624 Remove.
10625 (make_parent_window, make_window, saved_window)
10626 (Fset_window_configuration, save_window_save): Don't deal with
10627 clone numbers.
10628 * buffer.c (Qclone_number): Remove declaration.
10629 (sort_overlays, overlay_strings): Don't deal with clone numbers.
10630
3349e122
SM
106312011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
10632
10633 Add multiple inheritance to keymaps.
10634 * keymap.c (Fmake_composed_keymap): New function.
10635 (Fset_keymap_parent): Simplify.
10636 (fix_submap_inheritance): Remove.
10637 (access_keymap_1): New function extracted from access_keymap to handle
10638 embedded parents and handle lists of maps.
10639 (access_keymap): Use it.
10640 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
10641 (Fcopy_keymap): Handle embedded parents.
10642 (Fcommand_remapping, define_as_prefix): Simplify.
10643 (Fkey_binding): Simplify.
10644 (syms_of_keymap): Move minibuffer-local-completion-map,
10645 minibuffer-local-filename-completion-map,
10646 minibuffer-local-must-match-map, and
10647 minibuffer-local-filename-must-match-map to Elisp.
10648 (syms_of_keymap): Defsubr make-composed-keymap.
10649 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
10650 (parse_menu_item): Trivial simplification.
10651
3279eb87
GM
106522011-07-01 Glenn Morris <rgm@gnu.org>
10653
10654 * Makefile.in (SETTINGS_LIBS): Fix typo.
10655
39cb9e56 106562011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
10657
10658 * coding.c (Fencode_coding_string): Record the last coding system
10659 used, as the function doc string says (bug#8738).
10660
0949d2b6
JD
106612011-07-01 Jan Djärv <jan.h.d@swipnet.se>
10662
10663 * xsettings.c (store_monospaced_changed): Take new font as arg and
10664 check for change against current_mono_font.
10665 (EMACS_TYPE_SETTINGS): Remove this and related defines.
10666 (emacs_settings_constructor, emacs_settings_get_property)
10667 (emacs_settings_set_property, emacs_settings_class_init)
10668 (emacs_settings_init, gsettings_obj): Remove.
10669 (something_changedCB): New function for HAVE_GSETTINGS.
10670 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
10671 with value as argument.
10672 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
10673 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 10674 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
10675 "changed".
10676
10677 * xgselect.c: Add defined (HAVE_GSETTINGS).
10678 (xgselect_initialize): Ditto.
10679
10680 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
10681 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
10682 xg_select.
10683
bbc6b304
PE
106842011-07-01 Paul Eggert <eggert@cs.ucla.edu>
10685
10686 * eval.c (struct backtrace): Simplify and port the data structure.
10687 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
10688 signed bit field, as this assumption is not portable and it makes
10689 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
10690 "char debug_on_exit : 1" as this is not portable either; instead,
10691 use the portable "unsigned int debug_on_exit : 1". Remove unused
10692 member evalargs. Remove obsolete comments about cc bombing out.
10693
9851bfc5
JD
106942011-06-30 Jan Djärv <jan.h.d@swipnet.se>
10695
51bb811f 10696 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
10697 Let HAVE_GSETTINGS override HAVE_GCONF.
10698 (store_monospaced_changed): New function.
10699 (EMACS_SETTINGS): A new type derived from GObject to handle
10700 GSettings notifications.
10701 (emacs_settings_constructor, emacs_settings_get_property)
10702 (emacs_settings_set_property, emacs_settings_class_init):
10703 New functions.
10704 (gsettings_client, gsettings_obj): New variables.
10705 (GSETTINGS_SCHEMA): New define.
10706 (something_changedCB): Call store_monospaced_changed.
10707 (init_gsettings): New function.
10708 (xsettings_initialize): Call init_gsettings.
10709 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
10710 to NULL.
10711
640c8776 10712 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
10713 GCONF_CFLAGS/LIBS.
10714
5386012d
MR
107152011-06-29 Martin Rudalics <rudalics@gmx.at>
10716
10717 * window.c (resize_root_window, grow_mini_window)
10718 (shrink_mini_window): Rename Qresize_root_window to
10719 Qwindow_resize_root_window and Qresize_root_window_vertically to
10720 Qwindow_resize_root_window_vertically.
10721
f13e0b08
PE
107222011-06-28 Paul Eggert <eggert@cs.ucla.edu>
10723
10724 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
10725
94515237
JB
107262011-06-27 Juanma Barranquero <lekktu@gmail.com>
10727
10728 * makefile.w32-in: Redesign dependencies so they reflect more
10729 clearly which files are directly included by each source file,
10730 and not through other includes.
10731
e43b6e43
MR
107322011-06-27 Martin Rudalics <rudalics@gmx.at>
10733
10734 * buffer.c (Qclone_number): Declare static and DEFSYM it.
10735 (sort_overlays, overlay_strings): When an overlay's clone number
10736 matches the window's clone number process the overlay even if
10737 the overlay's window property doesn't match the current window.
10738
d68443dc
MR
10739 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
10740 (Fwindow_hchild): Rename to Fwindow_left_child.
10741 (Fwindow_next): Rename to Fwindow_next_sibling.
10742 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
10743 (resize_window_check): Rename to window_resize_check.
10744 (resize_window_apply): Rename to window_resize_apply.
10745 (Fresize_window_apply): Rename to Fwindow_resize_apply.
10746 (Fdelete_other_windows_internal, resize_frame_windows)
10747 (Fsplit_window_internal, Fdelete_window_internal)
10748 (grow_mini_window, shrink_mini_window)
10749 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 10750
c7e73be5
JD
107512011-06-26 Jan Djärv <jan.h.d@swipnet.se>
10752
10753 * emacsgtkfixed.h: State that this is only used with Gtk+3.
10754 (emacs_fixed_set_min_size): Remove.
10755 (emacs_fixed_new): Take frame as argument.
10756
10757 * emacsgtkfixed.c: State that this is only used with Gtk+3.
10758 (_EmacsFixedPrivate): Remove minwidth/height.
10759 Add struct frame *f.
10760 (emacs_fixed_init): Initialize priv->f.
10761 (get_parent_class, emacs_fixed_set_min_size): Remove.
10762 (emacs_fixed_new): Set priv->f to argument.
10763 (emacs_fixed_get_preferred_width)
10764 (emacs_fixed_get_preferred_height): Use min_width/height from
10765 frames size_hint to set minimum and natural (Bug#8919).
10766 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
10767 and use min_width/height from frames size_hint to set
10768 min_width/height (Bug#8919).
10769
10770 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
10771 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
10772 Fix indentation.
c7e73be5 10773
cf99dcf8
EZ
107742011-06-26 Eli Zaretskii <eliz@gnu.org>
10775
10776 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
10777 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
10778 called at ZV.
10779
029529ac
CY
107802011-06-26 Chong Yidong <cyd@stupidchicken.com>
10781
10782 * process.c (wait_reading_process_output): Bypass select if
10783 waiting for a cell while ignoring keyboard input, and input is
10784 pending. Suggested by Jan Djärv (Bug#8869).
10785
7a7ef429
PE
107862011-06-25 Paul Eggert <eggert@cs.ucla.edu>
10787
10788 Use gnulib's dup2 module instead of rolling our own.
10789 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
10790
11fdef7d 107912011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
10792
10793 * dispnew.c (scrolling_window): Before scrolling, turn off a
10794 mouse-highlight in the window being scrolled.
10795
cd3520a4
JB
107962011-06-24 Juanma Barranquero <lekktu@gmail.com>
10797
10798 Move DEFSYM to lisp.h and use everywhere.
10799
10800 * character.h (DEFSYM): Move declaration...
10801 * lisp.h (DEFSYM): ...here.
10802
10803 * gnutls.c:
10804 * minibuf.c:
10805 * w32menu.c:
10806 * w32proc.c:
10807 * w32select.c: Don't include character.h.
10808
10809 * alloc.c (syms_of_alloc):
10810 * buffer.c (syms_of_buffer):
10811 * bytecode.c (syms_of_bytecode):
10812 * callint.c (syms_of_callint):
10813 * casefiddle.c (syms_of_casefiddle):
10814 * casetab.c (init_casetab_once):
10815 * category.c (init_category_once, syms_of_category):
10816 * ccl.c (syms_of_ccl):
10817 * cmds.c (syms_of_cmds):
10818 * composite.c (syms_of_composite):
10819 * dbusbind.c (syms_of_dbusbind):
10820 * dired.c (syms_of_dired):
10821 * dispnew.c (syms_of_display):
10822 * doc.c (syms_of_doc):
10823 * editfns.c (syms_of_editfns):
10824 * emacs.c (syms_of_emacs):
10825 * eval.c (syms_of_eval):
10826 * fileio.c (syms_of_fileio):
10827 * fns.c (syms_of_fns):
10828 * frame.c (syms_of_frame):
10829 * fringe.c (syms_of_fringe):
10830 * insdel.c (syms_of_insdel):
10831 * keymap.c (syms_of_keymap):
10832 * lread.c (init_obarray, syms_of_lread):
10833 * macros.c (syms_of_macros):
10834 * msdos.c (syms_of_msdos):
10835 * print.c (syms_of_print):
10836 * process.c (syms_of_process):
10837 * search.c (syms_of_search):
10838 * sound.c (syms_of_sound):
10839 * syntax.c (init_syntax_once, syms_of_syntax):
10840 * terminal.c (syms_of_terminal):
10841 * textprop.c (syms_of_textprop):
10842 * undo.c (syms_of_undo):
10843 * w32.c (globals_of_w32):
10844 * window.c (syms_of_window):
10845 * xdisp.c (syms_of_xdisp):
10846 * xfaces.c (syms_of_xfaces):
10847 * xfns.c (syms_of_xfns):
10848 * xmenu.c (syms_of_xmenu):
10849 * xsettings.c (syms_of_xsettings):
10850 * xterm.c (syms_of_xterm): Use DEFSYM.
10851
4228cf16
TZ
108522011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
10853
cd3520a4 10854 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 10855
7fcccf1e
PE
108562011-06-23 Paul Eggert <eggert@cs.ucla.edu>
10857
7efb4e0e
PE
10858 Integer and buffer overflow fixes (Bug#8873).
10859
ff5844ad
PE
10860 * print.c (printchar, strout): Check for string overflow.
10861 (PRINTPREPARE, printchar, strout):
10862 Don't set size unless allocation succeeds.
10863
90532f02
PE
10864 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
10865 for sizes. Check for string overflow more accurately.
10866 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
10867
6d84508d
PE
10868 * macros.c: Integer and buffer overflow fixes.
10869 * keyboard.h (struct keyboard.kbd_macro_bufsize):
10870 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
10871 Use ptrdiff_t, not int, for sizes.
10872 Don't increment bufsize until after realloc succeeds.
10873 Check for size-calculation overflow.
10874 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
10875
437b2cb4
PE
10876 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
10877
8b9ac8b4
PE
10878 * lread.c: Integer overflow fixes.
10879 (read_integer): Radix is now EMACS_INT, not int,
10880 to improve quality of diagnostics for out-of-range radices.
10881 Calculate buffer size correctly for out-of-range radices.
10882 (read1): Check for integer overflow in radices, and in
10883 read-circle numbers.
82cb60d3
PE
10884 (read_escape): Avoid int overflow.
10885 (Fload, openp, read_buffer_size, read1)
10886 (substitute_object_recurse, read_vector, read_list, map_obarray):
10887 Use ptrdiff_t, not int, for sizes.
10888 (read1): Use EMACS_INT, not int, for sizes.
20270765 10889 Check for size overflow.
8b9ac8b4 10890
7fcccf1e
PE
10891 * image.c (cache_image): Check for size arithmetic overflow.
10892
bfbbd7e7
PE
10893 * lread.c: Integer overflow issues.
10894 (saved_doc_string_size, saved_doc_string_length)
10895 (prev_saved_doc_string_size, prev_saved_doc_string_length):
10896 Now ptrdiff_t, not int.
10897 (read1): Don't assume doc string length fits in int. Check for
10898 out-of-range doc string lengths.
10899 (read_list): Don't assume file position fits in int.
39019e54 10900 (read_escape): Check for hex character overflow.
bfbbd7e7 10901
4e323265
LL
109022011-06-22 Leo Liu <sdl.web@gmail.com>
10903
10904 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
10905 Move to minibuffer.el.
10906
85fece3e
PE
109072011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10908
20b84ce9 10909 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
10910 The following patches are for when GLYPH_DEBUG && !XASSERT.
10911 * dispextern.h (trace_redisplay_p, dump_glyph_string):
10912 * dispnew.c (flush_stdout):
10913 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
10914 Mark as externally visible.
10915 * dispnew.c (check_window_matrix_pointers): Now static.
10916 * dispnew.c (window_to_frame_vpos):
10917 * xfns.c (unwind_create_frame):
10918 * xterm.c (x_check_font): Remove unused local.
10919 * scroll.c (CHECK_BOUNDS):
10920 * xfaces.c (cache_fache): Rename local to avoid shadowing.
10921 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
10922 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
10923 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
10924 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
10925 Now static.
10926 (debug_method_add): Use va_list and vsprintf rather than relying
10927 on undefined behavior with wrong number of arguments.
10928 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
10929 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
10930 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
10931 since we're not interested in debugging glyphs with old libraries.
10932 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
10933 GCC 4.6.0's static checking.
10934
0766b489
PE
109352011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10936
31fd4b32
PE
10937 Integer overflow and signedness fixes (Bug#8873).
10938 A few related buffer overrun fixes, too.
10939
b79e8648
PE
10940 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
10941
0766b489
PE
10942 * dispextern.h (struct face.stipple):
10943 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
10944 (x_bitmap_mask, x_allocate_bitmap_record)
10945 (x_create_bitmap_from_data, x_create_bitmap_from_file)
10946 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
10947 (x_create_bitmap_from_xpm_data):
10948 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
10949 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
10950 (.bitmaps_last):
10951 * xfaces.c (load_pixmap):
10952 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
10953 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
10954 (.bitmaps_last, struct x_output.icon_bitmap):
10955 Use ptrdiff_t, not int, for bitmap indexes.
10956 (x_allocate_bitmap_record): Check for size overflow.
10957 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
10958
b081724f
PE
10959 Use ptrdiff_t, not int, for overlay counts.
10960 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
10961 * editfns.c (overlays_around, get_pos_property):
10962 * textprop.c (get_char_property_and_overlay):
10963 * xdisp.c (next_overlay_change, note_mouse_highlight):
10964 * xfaces.c (face_at_buffer_position):
21514da7
PE
10965 * buffer.c (OVERLAY_COUNT_MAX): New macro.
10966 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
10967 (Fnext_overlay_change, Fprevious_overlay_change)
10968 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 10969 Use ptrdiff_t, not int, for sizes.
21514da7 10970 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 10971
3de73e5e
PE
10972 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
10973
2606c57b
PE
10974 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
10975 (x_session_initialize): Do not assume string length fits in int.
10976
aaafe47a
PE
10977 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
10978 This is unlikely, but can occur if DPI is outlandish.
10979
2674ddc8 10980 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
10981 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
10982
28154962
PE
10983 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
10984 * xrdb.c (magic_file_p, search_magic_path):
10985 Omit last arg SUFFIX; it was always 0. All callers changed.
10986 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
10987
7de51af5
PE
10988 * xfont.c (xfont_match): Avoid need for strlen.
10989
25ed6cc3
PE
10990 * xfns.c: Don't assume strlen fits in int.
10991 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
10992
4eab31dd
PE
10993 * xdisp.c (message_log_check_duplicate): Return intmax_t,
10994 not unsigned long, as we prefer signed integers. All callers changed.
10995 Detect integer overflow in repeat count.
10996 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 10997 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 10998
171e2a58
PE
10999 * termcap.c: Don't assume sizes fit in int and never overflow.
11000 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
11001 (gobble_line): Check for size-calculation overflow.
11002
ad39faca 11003 * minibuf.c (Fread_buffer):
6e5bb2dc 11004 * lread.c (intern, intern_c_string):
74ca2eb3
PE
11005 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
11006 Don't assume string length fits in int.
11007
52c61c22 11008 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
11009 * gtkutil.c (style_changed_cb): Avoid need for strlen.
11010
b5b8c9e5
PE
11011 * font.c: Don't assume string length fits in int.
11012 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
11013 Use ptrdiff_t, not int.
ccd6111c
PE
11014 (font_intern_prop): Don't assume string length fits in int.
11015 Don't assume integer property fits in fixnum.
11016 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 11017
882f0d81 11018 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 11019 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
11020 Reformulate so as not to need the command string.
11021 Invoke gzip -cd rather than gunzip, as it's more portable.
11022 (lock_info_type, lock_file_1, lock_file):
11023 Don't assume pid_t and time_t fit in unsigned long.
11024 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
11025 (current_lock_owner): Prefer signed type for sizes.
11026 Use memcpy, not strncpy, where memcpy is what is really wanted.
11027 Don't assume (via atoi) that time_t and pid_t fit in int.
11028 Check for time_t and/or pid_t out of range, e.g., via a network share.
11029 Don't alloca where an auto var works fine.
11030
93f4cf88
PE
11031 * fileio.c: Fix some integer overflow issues.
11032 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
11033 Don't assume string length fits in int.
11034 (directory_file_name): Don't assume string length fits in long.
11035 (make_temp_name): Don't assume pid fits in int, or that its print
11036 length is less than 20.
11037
f3e92b69
PE
11038 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
11039
1bfdaf10
PE
11040 * coding.c (make_subsidiaries): Don't assume string length fits in int.
11041
35016e9a
PE
11042 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
11043
3d1e65a1
PE
11044 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
11045 We prefer signed integers, even for size calculations.
11046
0b963a93
PE
11047 * emacs.c: Don't assume string length fits in 'int'.
11048 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
11049 (main): Don't invoke strlen when not needed.
11050
573f4b54
PE
11051 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
11052 (XD_DEBUG_MESSAGE): Don't waste a byte.
11053
989f33ba
PE
11054 * callproc.c (getenv_internal_1, getenv_internal)
11055 (Fgetenv_internal):
965d34eb
PE
11056 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
11057
e4d29b33
PE
11058 * lread.c (invalid_syntax): Omit length argument.
11059 All uses changed. This doesn't fix a bug, but it simplifies the
11060 code away from its former Hollerith-constant appearance, and it's
11061 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 11062 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 11063
eb49b136
PE
11064 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
11065 This didn't break anything, but it didn't help either.
11066 It's confusing to put a bogus integer in a place where the actual
11067 value does not matter.
9f62aeb1 11068 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 11069 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 11070
15375a22
PE
11071 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
11072 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
11073 implementation.
b61cc01c
PE
11074 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
11075 We prefer signed types, and the value cannot exceed the EMACS_INT
11076 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
11077 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
11078 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
11079 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 11080
53b2623d
PE
11081 * indent.c (sane_tab_width): New function.
11082 (current_column, scan_for_column, Findent_to, position_indentation)
11083 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 11084 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 11085
51cab52b 11086 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 11087
f2ed8a70
PE
11088 * lisp.h (lint_assume): New macro.
11089 * composite.c (composition_gstring_put_cache):
11090 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
11091
abe80cc6
PE
11092 * editfns.c, insdel.c:
11093 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 11094
b02c740e
PE
11095 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
11096
ebc96716
PE
11097 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
11098
b4e50fa0 11099 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 11100 Use much-faster test for byte-length change.
311d5d7c 11101 Don't assume string byte-length fits in 'int'.
a4cf38e4 11102 Check that character arg fits in 'int'.
85461888 11103 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 11104
c0c1ee9f
PE
11105 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
11106
a498d7f4
PE
11107 * fns.c (concat): Catch string overflow earlier.
11108 Do not rely on integer wraparound.
11109
51cab52b
PE
11110 * dispextern.h (struct it.overlay_strings_charpos)
11111 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
11112 * xdisp.c (forward_to_next_line_start)
11113 (back_to_previous_visible_line_start)
11114 (reseat_at_next_visible_line_start, next_element_from_buffer):
11115 Don't arbitrarily truncate the value of 'selective' to int.
11116
76031fad
PE
11117 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
11118
5eb55db9
PE
11119 * composite.c: Don't truncate sizes to 'int'.
11120 (composition_gstring_p, composition_reseat_it)
11121 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
11122 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
11123 not EMACS_UINT, for indexes.
5eb55db9 11124
0703a717
PE
11125 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
11126
d6202519
PE
11127 * buffer.c: Include <verify.h>.
11128 (struct sortvec.priority, struct sortstr.priority):
8961a454 11129 Now EMACS_INT, not int.
c20998a7 11130 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
11131 (struct sortstr.size, record_overlay_string)
11132 (struct sortstrlist.size, struct sortlist.used):
11133 Don't truncate size to int.
11134 (record_overlay_string): Check for size-calculation overflow.
d6202519 11135 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 11136
d5a19415
JM
111372011-06-22 Jim Meyering <meyering@redhat.com>
11138
029529ac 11139 Don't leak an XBM-image-sized buffer
d5a19415
JM
11140 * image.c (xbm_load): Free the image buffer after using it.
11141
a9041e6c
PE
111422011-06-21 Paul Eggert <eggert@cs.ucla.edu>
11143
11144 Port to Sun C.
11145 * composite.c (find_automatic_composition): Omit needless 'return 0;'
11146 that Sun C diagnosed.
11147 * fns.c (secure_hash): Fix pointer signedness issue.
11148 * intervals.c (static_offset_intervals): New function.
11149 (offset_intervals): Use it.
11150
7f3f739f
LL
111512011-06-21 Leo Liu <sdl.web@gmail.com>
11152
11153 * deps.mk (fns.o):
11154 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
11155 sha512.h.
11156
11157 * fns.c (secure_hash): Rename from crypto_hash_function and change
11158 the first arg to accept symbols.
5b66d427 11159 (Fsecure_hash): New primitive.
7f3f739f
LL
11160 (syms_of_fns): New symbols.
11161
76147d94
DD
111622011-06-20 Deniz Dogan <deniz@dogan.se>
11163
11164 * process.c (Fset_process_buffer): Clarify return value in
11165 docstring.
11166
7d7d0045
CY
111672011-06-18 Chong Yidong <cyd@stupidchicken.com>
11168
11169 * dispnew.c (add_window_display_history): Use BVAR.
11170
11171 * xdisp.c (debug_method_add): Use BVAR.
11172 (check_window_end, dump_glyph_matrix, dump_glyph)
11173 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
11174
11175 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
11176 Likewise.
11177
11178 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
11179 check till after the cache is created in init_frame_faces.
11180
ff2bc410
SM
111812011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
11182
11183 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
11184
28177add
PE
111852011-06-16 Paul Eggert <eggert@cs.ucla.edu>
11186
dd3482fe
PE
11187 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
11188 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
11189 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
11190
393d71f3 11191 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
11192 * fileio.c (Finsert_file_contents):
11193 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
11194 Remove the old (too-loose) buffer overflow checks.
11195 They weren't needed, since make_gap checks for buffer overflow.
11196 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
11197 The old code merely checked for Emacs fixnum overflow, and relied
11198 on undefined (wraparound) behavior. The new code avoids undefined
11199 behavior, and also checks for ptrdiff_t and/or size_t overflow.
11200
2e6813b0 11201 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
11202 Tune. Don't use wider integers than needed. Don't use alloca.
11203 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 11204
599a9e4f
PE
11205 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
11206
99561444
PE
11207 * insdel.c, lisp.h (buffer_overflow): New function.
11208 (insert_from_buffer_1, replace_range, replace_range_2):
11209 * insdel.c (make_gap_larger):
11210 * editfns.c (Finsert_char):
11211 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
11212
28177add
PE
11213 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
11214
e69dafad
PE
112152011-06-15 Paul Eggert <eggert@cs.ucla.edu>
11216
4baa020d 11217 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 11218
b1c46f02
PE
11219 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
11220 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
11221
e69dafad
PE
11222 * fileio.c: Don't assume EMACS_INT fits in off_t.
11223 (emacs_lseek): New static function.
11224 (Finsert_file_contents, Fwrite_region): Use it.
11225 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
11226
566684ea
PE
11227 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
11228
e6966cd6
PE
11229 * fns.c: Don't overflow int when computing a list length.
11230 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
11231 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
11232 truncation on 64-bit hosts. Check for QUIT every
11233 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
11234 faster and is responsive enough.
11235 (Flength): Report an error instead of overflowing an integer.
11236 (Fsafe_length): Return a float if the value is not representable
11237 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 11238 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 11239 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 11240
dd0b0efb
PE
11241 * alloc.c: Check that resized vectors' lengths fit in fixnums.
11242 (header_size, word_size): New constants.
11243 (allocate_vectorlike): Don't check size overflow here.
11244 (allocate_vector): Check it here instead, since this is the only
11245 caller of allocate_vectorlike that could cause overflow.
11246 Check that the new vector's length is representable as a fixnum.
11247
86fe5cfe
PE
11248 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
11249 The previous code was bogus. For example, next_almost_prime (32)
11250 returned 39, which is undesirable as it is a multiple of 3; and
11251 next_almost_prime (24) returned 25, which is a multiple of 5 so
11252 why was the code bothering to check for multiples of 7?
11253
80e88859
PE
11254 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
11255
4a2f0ad6
PE
11256 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
11257
f66c7cf8
PE
11258 Variadic C functions now count arguments with ptrdiff_t.
11259 This partly undoes my 2011-03-30 change, which replaced int with size_t.
11260 Back then I didn't know that the Emacs coding style prefers signed int.
11261 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
11262 were being counted with int, which may truncate counts on 64-bit
11263 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
11264 * lisp.h (struct Lisp_Subr.function.aMANY)
11265 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
11266 Arg counts are now ptrdiff_t, not size_t.
11267 All variadic functions and their callers changed accordingly.
11268 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
11269 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
11270 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
11271 * callint.c (Fcall_interactively): Check arg count for overflow,
11272 to avoid potential buffer overrun. Use signed char, not 'int',
11273 for 'varies' array, so that we needn't bother to check its size
11274 calculation for overflow.
11275 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
11276 * eval.c (apply_lambda):
11277 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
11278 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
11279 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
11280
a1759b76
PE
11281 * callint.c (Fcall_interactively): Don't use index var as event count.
11282
d96be9fc
PE
11283 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
11284 * mem-limits.h (SIZE): Remove; no longer used.
11285
a690a978 11286 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 11287
578c21e6
PE
11288 Remove unnecessary casts.
11289 * xterm.c (x_term_init):
11290 * xfns.c (x_set_border_pixel):
11291 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
11292 These aren't needed now that we assume ANSI C.
11293
96f53c6c
PE
11294 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
11295 It's more likely to cause problems (due to unsigned overflow)
11296 than to cure them.
11297
83c77d31
PE
11298 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
11299
ee2079f1
PE
11300 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
11301
6da65536
PE
11302 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
11303
7147c4a4
PE
11304 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
11305
193e32d9
PE
11306 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
11307
e5533da6
PE
11308 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
11309
9910e595
PE
11310 GLYPH_CODE_FACE returns EMACS_INT, not int.
11311 * dispextern.h (merge_faces):
11312 * xfaces.c (merge_faces):
01103c44
PE
11313 * xdisp.c (get_next_display_element, next_element_from_display_vector):
11314 Don't assume EMACS_INT fits in int.
9910e595 11315
2638320e
PE
11316 * character.h (CHAR_VALID_P): Remove unused parameter.
11317 * fontset.c, lisp.h, xdisp.c: All uses changed.
11318
045eb8d9
PE
11319 * editfns.c (Ftranslate_region_internal): Omit redundant test.
11320
c1f134b5
PE
11321 * fns.c (concat): Minor tuning based on overflow analysis.
11322 This doesn't fix any bugs. Use int to hold character, instead
11323 of constantly refetching from Emacs object. Use XFASTINT, not
11324 XINT, for value known to be a character. Don't bother comparing
11325 a single byte to 0400, as it's always less.
11326
395fcb93 11327 * floatfns.c (Fexpt):
327eeec8
PE
11328 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
11329
abbd3d23
PE
11330 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
11331 for characters.
11332
684a03ef
PE
11333 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
11334
0fed43f3
PE
11335 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
11336 Without this fix, on a 64-bit host (aset S 0 4294967386) would
11337 incorrectly succeed when S was a string, because 4294967386 was
11338 truncated before it was used.
11339
8fd02eb7
PE
11340 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
11341 Otherwise, an out-of-range integer could cause undefined behavior
11342 on a 64-bit host.
11343
f8c86b69
PE
11344 * composite.c: Use int, not EMACS_INT, for characters.
11345 (fill_gstring_body, composition_compute_stop_pos): Use int, not
11346 EMACS_INT, for values that are known to be in character range.
11347 This doesn't fix any bugs but is the usual style inside Emacs and
11348 may generate better code on 32-bit machines.
11349
34206dd2
PE
11350 Make sure a 64-bit char is never passed to ENCODE_CHAR.
11351 This is for reasons similar to the recent CHAR_STRING fix.
11352 * charset.c (Fencode_char): Check that character arg is actually
11353 a character. Pass an int to ENCODE_CHAR.
11354 * charset.h (ENCODE_CHAR): Verify that the character argument is no
11355 wider than 'int', as a compile-time check to prevent future regressions
11356 in this area.
11357
c5958d4c 11358 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
11359
11360 Make sure a 64-bit char is never passed to CHAR_STRING.
11361 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
11362 by silently ignoring the top 32 bits, allowing some values
11363 that were far too large to be valid characters.
11364 * character.h: Include <verify.h>.
11365 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
11366 arguments are no wider than unsigned, as a compile-time check
11367 to prevent future regressions in this area.
11368 * data.c (Faset):
01103c44 11369 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
11370 (Fsubst_char_in_region):
11371 * fns.c (concat):
11372 * xdisp.c (decode_mode_spec_coding):
11373 Adjust to CHAR_STRING's new requirement.
11374 * editfns.c (Finsert_char, Fsubst_char_in_region):
11375 * fns.c (concat): Check that character args are actually
11376 characters. Without this test, these functions did the wrong
11377 thing with wildly out-of-range values on 64-bit hosts.
11378
d37ca623
PE
11379 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
11380 These casts should not be needed on 32-bit hosts, either.
11381 * keyboard.c (read_char):
11382 * lread.c (Fload): Remove casts to unsigned.
11383
ea204efb
PE
11384 * lisp.h (UNSIGNED_CMP): New macro.
11385 This fixes comparison bugs on 64-bit hosts.
11386 (ASCII_CHAR_P): Use it.
11387 * casefiddle.c (casify_object):
01103c44 11388 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
11389 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
11390 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
11391 * dispextern.h (FACE_FROM_ID):
11392 * keyboard.c (read_char): Use UNSIGNED_CMP.
11393
41cb286c
PE
11394 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
11395 not to EMACS_INT, to avoid GCC warning.
11396
4a1b9832
PE
11397 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
11398
55daad71
PE
11399 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
11400 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
11401 isn't needed on 32-bit machines.
8f95c75c 11402
01103c44
PE
11403 * buffer.c (Fgenerate_new_buffer_name):
11404 Use EMACS_INT for count, not int.
0ceccced 11405 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
11406
11407 * data.c (Qcompiled_function): Now static.
11408
c6f072e7
PE
11409 * window.c (window_body_lines): Now static.
11410
20ce5912
PE
11411 * image.c (gif_load): Rename local to avoid shadowing.
11412
9c4c5f81
PE
11413 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
11414 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
11415 * alloc.c (make_save_value): Integer argument is now of type
11416 ptrdiff_t, not int.
11417 (mark_object): Use ptrdiff_t, not int.
11418 * lisp.h (pD): New macro.
11419 * print.c (print_object): Use it.
11420
c0c5c8ae
PE
11421 * alloc.c: Use EMACS_INT, not int, to count objects.
11422 (total_conses, total_markers, total_symbols, total_vector_size)
11423 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
11424 (total_free_floats, total_floats, total_free_intervals)
11425 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
11426 Now EMACS_INT, not int. All uses changed.
11427 (Fgarbage_collect): Compute overall total using a double, so that
11428 integer overflow is less likely to be a problem. Check for overflow
11429 when converting back to an integer.
5a25e253
PE
11430 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
11431 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
11432 These were 'int' variables that could overflow on 64-bit hosts;
11433 they were never used, so remove them instead of repairing them.
211a0b2a 11434 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
11435 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
11436 Previously, this ceilinged at INT_MAX, but that doesn't work on
11437 64-bit machines.
e46bb31a 11438 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 11439
c78baabf 11440 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 11441 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
11442 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
11443 when a (possibly-narrower) signed value would do just as well.
11444 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 11445
c9d624c6
PE
11446 * alloc.c: Catch some string size overflows that we were missing.
11447 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
11448 for convenience in STRING_BYTES_MAX.
11449 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
11450 The definition here is exact; the one in lisp.h was approximate.
11451 (allocate_string_data): Check for string overflow. This catches
11452 some instances we weren't catching before. Also, it catches
11453 size_t overflow on (unusual) hosts where SIZE_MAX <= min
11454 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
11455 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 11456
c9d624c6
PE
11457 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
11458 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 11459 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 11460
353032ce
PE
11461 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
11462
2bccce07
PE
11463 * alloc.c (Fmake_string): Check for out-of-range init.
11464
0ac30604
SM
114652011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
11466
11467 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
11468
c195f2de
JD
114692011-06-14 Jan Djärv <jan.h.d@swipnet.se>
11470
11471 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
11472 xg_get_default_scrollbar_width.
11473
11474 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
11475 (int_gtk_range_get_value): Move to the scroll bar part of the file.
11476 (style_changed_cb): Call update_theme_scrollbar_width and call
11477 x_set_scroll_bar_default_width and xg_frame_set_char_size for
11478 all frames (Bug#8505).
11479 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
11480 Call gtk_window_set_resizable if HAVE_GTK3.
11481 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
11482 and height if HAVE_GTK3 (Bug#8505).
11483 (scroll_bar_width_for_theme): New variable.
11484 (update_theme_scrollbar_width): New function.
11485 (xg_get_default_scrollbar_width): Move code to
11486 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
11487 (xg_initialize): Call update_theme_scrollbar_width.
11488
11489 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
11490
11491 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
11492
e10ac9f1
MR
114932011-06-12 Martin Rudalics <rudalics@gmx.at>
11494
11495 * frame.c (make_frame): Call other_buffer_safely instead of
11496 other_buffer.
11497
11498 * window.c (temp_output_buffer_show): Call display_buffer with
11499 second argument Vtemp_buffer_show_specifiers and reset latter
11500 immediately after the call.
11501 (Vtemp_buffer_show_specifiers): New variable.
11502 (auto_window_vscroll_p, next_screen_context_lines)
11503 (Vscroll_preserve_screen_position): Remove leading asterisks from
11504 doc-strings.
11505
2d3c217e 115062011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 11507
7b7f97e8 11508 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
11509 * buffer.c (Qclone_number): Remove for now, as it's unused.
11510 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
11511 (record_buffer): Remove unused local.
11512 * frame.c (other_visible_frames, frame_buffer_list): Now static.
11513 (set_frame_buffer_list): Remove; unused.
11514 * frame.h (other_visible_frames): Remove decl.
11515 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
11516 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
11517 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
11518 if HAVE_GPM.
11519 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
11520 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
11521 Define only if HAVE_GPM.
11522 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
11523 (update_hints_inhibit): Remove; never set. All uses removed.
11524 * widgetprv.h (emacsFrameClassRec): Remove decl.
11525 * window.c (delete_deletable_window): Now returns void, since it
11526 wasn't returning anything.
11527 (compare_window_configurations): Remove unused locals.
11528 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
11529 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
11530 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
11531 the same widths as pointers. This follows up on the 2011-05-06 patch.
11532 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
11533 * xterm.h: Likewise.
11534 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
11535
1384b89e
JB
115362011-06-12 Juanma Barranquero <lekktu@gmail.com>
11537
11538 * makefile.w32-in: Update dependencies.
11539 (LISP_H): Add lib/intprops.h.
11540
1100a63c
CY
115412011-06-11 Chong Yidong <cyd@stupidchicken.com>
11542
11543 * image.c (gif_load): Add animation frame delay to the metadata.
11544 (syms_of_image): Use DEFSYM. New symbol `delay'.
11545
6198ccd0
MR
115462011-06-11 Martin Rudalics <rudalics@gmx.at>
11547
11548 * window.c (delete_deletable_window): Re-add.
11549 (Fset_window_configuration): Rewrite to handle dead buffers and
11550 consequently deletable windows.
11551 (window_tree, Fwindow_tree): Remove. Supply functionality in
11552 window.el.
11553 (compare_window_configurations): Simplify code.
11554
b6e3633c
AS
115552011-06-11 Andreas Schwab <schwab@linux-m68k.org>
11556
1ab0dee5
AS
11557 * image.c (imagemagick_load_image): Fix type mismatch.
11558 (Fimagemagick_types): Likewise.
11559
b6e3633c
AS
11560 * window.h (replace_buffer_in_windows): Declare.
11561
9397e56f
MR
115622011-06-11 Martin Rudalics <rudalics@gmx.at>
11563
11564 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
11565 Qclone_number. Remove external declaration of Qdelete_window.
11566 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
11567 code.
640c8776
SM
11568 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
11569 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
11570 (Fother_buffer): Rewrite doc-string. Major rewrite for new
11571 buffer list implementation.
11572 (other_buffer_safely): New function.
11573 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
11574 calls to replace_buffer_in_windows and
11575 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
11576 if allowed.
11577 (record_buffer): Inhibit quitting and rewrite using quittable
11578 functions. Run Qbuffer_list_update_hook if allowed.
11579 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
11580 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
11581 Move switch-to-buffer to window.el.
9397e56f
MR
11582 (bury-buffer): Move to window.el.
11583 (Vbuffer_list_update_hook): New variable.
11584
11585 * lisp.h (other_buffer_safely): Add prototype in buffer.c
11586 section.
11587
11588 * window.h (resize_frame_windows): Move up in code.
11589 (Fwindow_frame): Remove EXFUN.
11590 (replace_buffer_in_all_windows): Remove prototype.
11591 (replace_buffer_in_windows_safely): Add prototype.
11592
11593 * window.c: Declare Qdelete_window static again. Move down
11594 declaration of select_count.
11595 (Fnext_window, Fprevious_window): Rewrite doc-strings.
11596 (Fother_window): Move to window.el.
11597 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
11598 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
11599 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
11600 window.el.
11601 (replace_buffer_in_windows): Implement by calling
11602 Qreplace_buffer_in_windows.
11603 (replace_buffer_in_all_windows): Remove with some functionality
11604 moved into replace_buffer_in_windows_safely.
11605 (replace_buffer_in_windows_safely): New function.
11606 (select_window_norecord, select_frame_norecord): Move in front
11607 of run_window_configuration_change_hook. Remove now obsolete
11608 declarations.
640c8776
SM
11609 (Fset_window_buffer): Rewrite doc-string.
11610 Call Qrecord_window_buffer.
9397e56f
MR
11611 (keys_of_window): Move binding for other-window to window.el.
11612
b50691aa
CY
116132011-06-11 Chong Yidong <cyd@stupidchicken.com>
11614
11615 * dispextern.h (struct image): Replace data member, whose int_val
11616 and ptr_val fields were not used by anything, with a single
11617 lisp_val object.
11618
11619 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
11620 (gif_clear_image, gif_load, imagemagick_load_image)
11621 (gs_clear_image, gs_load): Callers changed.
11622
3f754b86
PE
116232011-06-10 Paul Eggert <eggert@cs.ucla.edu>
11624
cca69397
PE
11625 * buffer.h: Include <time.h>, for time_t.
11626 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
11627
109e28d0
PE
11628 Fix minor problems found by static checking.
11629
60737f02
PE
11630 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
11631
4b66faf3
PE
11632 Make identifiers static if they are not used in other modules.
11633 * data.c (Qcompiled_function, Qframe, Qvector):
11634 * image.c (QimageMagick, Qsvg):
11635 * minibuf.c (Qmetadata):
11636 * window.c (resize_window_check, resize_root_window): Now static.
11637 * window.h (resize_window_check, resize_root_window): Remove decls.
11638
109e28d0
PE
11639 * window.c (window_deletion_count, delete_deletable_window):
11640 Remove; unused.
46a4ce9e
PE
11641 (window_body_lines): Now static.
11642 (Fdelete_other_windows_internal): Mark vars as initialized.
11643 Make sure 'resize_failed' is initialized.
11644 (run_window_configuration_change_hook): Rename local to avoid shadowing.
11645 (resize_window_apply): Remove unused local.
11646 * window.h (delete_deletable_window): Remove decl.
11647
109e28d0 11648 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
11649 (imagemagick_load_image): Fix pointer signedness problem by changing
11650 last arg from unsigned char * to char *. All uses changed.
11651 Also, fix a local for similar reasons.
11652 Remove unused locals. Remove locals to avoid shadowing.
11653 (fn_rsvg_handle_free): Remove; unused.
11654 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 11655 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 11656
3f754b86
PE
11657 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
11658
2547adb1
CY
116592011-06-10 Chong Yidong <cyd@stupidchicken.com>
11660
11661 * image.c (gif_load): Fix omitted cast error introduced by
11662 2011-06-06 change.
11663
2c8e37d4
MR
116642011-06-10 Martin Rudalics <rudalics@gmx.at>
11665
11666 * window.h (resize_proportionally, orig_total_lines)
11667 (orig_top_line): Remove from window structure.
11668 (set_window_height, set_window_width, change_window_heights)
11669 (Fdelete_window): Remove prototypes.
11670 (resize_frame_windows): Remove duplicate declaration.
11671
440a42e3
EZ
116722011-06-10 Eli Zaretskii <eliz@gnu.org>
11673
11674 * window.h (resize_frame_windows, resize_window_check)
11675 (delete_deletable_window, resize_root_window)
11676 (resize_frame_windows): Declare prototypes.
11677
11678 * window.c (resize_window_apply): Make definition be "static" to
11679 match the prototype.
11680
562dd5e9
MR
116812011-06-10 Martin Rudalics <rudalics@gmx.at>
11682
11683 * window.c: Remove declarations of Qwindow_size_fixed,
11684 window_min_size_1, window_min_size_2, window_min_size,
11685 size_window, window_fixed_size_p, enlarge_window, delete_window.
11686 Remove static from declaration of Qdelete_window, it's
11687 temporarily needed by Fbury_buffer.
11688 (replace_window): Don't assign orig_top_line and
11689 orig_total_lines.
11690 (Fdelete_window, delete_window): Remove. Window deletion is
11691 handled by window.el.
640c8776
SM
11692 (window_loop): Remove DELETE_OTHER_WINDOWS case.
11693 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
11694 (Fdelete_other_windows): Remove. Deleting other windows is
11695 handled by window.el.
11696 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
11697 handled in window.el.
11698 (window_min_size_2, window_min_size_1, window_min_size): Remove.
11699 Window minimum sizes are handled in window.el.
11700 (shrink_windows, size_window, set_window_height)
11701 (set_window_width, change_window_heights, window_height)
11702 (window_width, CURBEG, CURSIZE, enlarge_window)
11703 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
11704 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
11705 handled in window.el.
11706 (make_dummy_parent): Rename to make_parent_window and give it a
11707 second argument horflag.
11708 (make_window): Don't set resize_proportionally any more.
11709 (Fsplit_window): Remove. Windows are split in window.el.
11710 (save_restore_action, save_restore_orig_size)
11711 (shrink_window_lowest_first, save_restore_orig_size): Remove.
11712 Resize mini windows in window.el.
11713 (grow_mini_window, shrink_mini_window): Implement by calling
11714 Qresize_root_window_vertically, resize_window_check and
11715 resize_window_apply.
640c8776
SM
11716 (saved_window, Fset_window_configuration, save_window_save):
11717 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
11718 resize_proportionally.
11719 (window_min_height, window_min_width): Move to window.el.
11720 (keys_of_window): Move bindings for delete-other-windows,
11721 split-window, delete-window and enlarge-window to window.el.
11722
11723 * buffer.c: Temporarily extern Qdelete_window.
11724 (Fbury_buffer): Temporarily call Qdelete_window instead of
11725 Fdelete_window (Fbury_buffer will move to window.el soon).
11726
11727 * frame.c (set_menu_bar_lines_1): Remove code handling
11728 orig_top_line and orig_total_lines.
11729
11730 * dispnew.c (adjust_frame_glyphs_initially): Don't use
11731 set_window_height but set heights directly.
11732 (change_frame_size_1): Use resize_frame_windows.
11733
11734 * xdisp.c (init_xdisp): Don't use set_window_height but set
11735 heights directly.
11736
640c8776
SM
11737 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
11738 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
11739 run_window_configuration_change_hook.
11740
11741 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
11742 instead of change_window_heights and run
11743 run_window_configuration_change_hook.
11744
1a13852e
MR
117452011-06-09 Martin Rudalics <rudalics@gmx.at>
11746
11747 * window.c (replace_window): Rename second argument REPLACEMENT to
11748 NEW. New third argument SETFLAG. Rewrite.
11749 (delete_window, make_dummy_parent): Call replace_window with
11750 third argument 1.
11751 (window_list_1): Move down in code.
11752 (run_window_configuration_change_hook): Move set_buffer part
11753 before select_frame_norecord part in order to unwind correctly.
11754 Rename count1 to count.
11755 (recombine_windows, delete_deletable_window, resize_root_window)
11756 (Fdelete_other_windows_internal)
11757 (Frun_window_configuration_change_hook, make_parent_window)
11758 (resize_window_check, resize_window_apply, Fresize_window_apply)
11759 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
11760 (Fdelete_window_internal, Fresize_mini_window_internal):
11761 New functions.
1a13852e
MR
11762 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
11763
f3d1777e
MR
117642011-06-08 Martin Rudalics <rudalics@gmx.at>
11765
496e208e
MR
11766 * window.h (window): Add some new members to window structure -
11767 normal_lines, normal_cols, new_total, new_normal, clone_number,
11768 splits, nest, prev_buffers, next_buffers.
11769 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 11770 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 11771
f3d1777e
MR
11772 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
11773 Remove.
496e208e
MR
11774 (make_dummy_parent): Set new members of windows structure.
11775 (make_window): Move down in code. Handle new members of window
11776 structure.
11777 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
11778 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
11779 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
11780 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
11781 (Fset_window_next_buffers, Fset_window_clone_number):
11782 New functions.
496e208e
MR
11783 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
11784 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
11785 Doc-string fixes.
11786 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
11787 Argument WINDOW can be now internal window too.
11788 (Fwindow_use_time): Move up in code.
11789 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
11790 Rewrite doc-string.
11791 (Fset_window_configuration, saved_window)
11792 (Fcurrent_window_configuration, save_window_save): Handle new
11793 members of window structure.
b9e809c2
MR
11794 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
11795 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
11796 (syms_of_window): New Lisp objects Qrecord_window_buffer,
11797 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
11798 Qget_mru_window, Qresize_root_window,
11799 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
11800 Qauto_buffer_name; staticpro them.
f3d1777e 11801
abde8f8c
MR
118022011-06-07 Martin Rudalics <rudalics@gmx.at>
11803
11804 * window.c (Fwindow_total_size, Fwindow_left_column)
11805 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
11806 (Fwindow_list_1): New functions.
11807 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
11808 (Fwindow_width, Fscroll_left, Fscroll_right):
11809 Use window_body_cols instead of window_box_text_cols.
11810 (delete_window, Fset_window_configuration):
11811 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
11812 (delete_all_subwindows): Take a window as argument and not a
11813 structure. Rewrite.
190b47e6
MR
11814 (window_loop): Remove handling of GET_LRU_WINDOW and
11815 GET_LARGEST_WINDOW.
11816 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
11817
11818 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
11819 window_box_text_cols. delete_all_subwindows now takes a
11820 Lisp_Object as argument.
abde8f8c 11821
640c8776
SM
11822 * indent.c (compute_motion, Fcompute_motion):
11823 Use window_body_cols instead of window_box_text_cols.
abde8f8c 11824
fa8a67e6
MR
11825 * frame.c (delete_frame): Call delete_all_subwindows with root
11826 window as argument.
11827
a54e3482
DC
118282011-06-07 Daniel Colascione <dan.colascione@gmail.com>
11829
11830 * fns.c (Fputhash): Document return value.
11831
60002bf5
CY
118322011-06-06 Chong Yidong <cyd@stupidchicken.com>
11833
11834 * image.c (gif_load): Implement gif89a spec "no disposal" method.
11835
0c671da6 118362011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 11837
b862a52a 11838 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 11839
be44ca6c
PE
11840 Check for overflow when converting integer to cons and back.
11841 * charset.c (Fdefine_charset_internal, Fdecode_char):
11842 Use cons_to_unsigned to catch overflow.
11843 (Fencode_char): Use INTEGER_TO_CONS.
11844 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
11845 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
11846 * data.c (long_to_cons, cons_to_long): Remove.
11847 (cons_to_unsigned, cons_to_signed): New functions.
11848 These signal an error for invalid or out-of-range values.
11849 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
11850 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
11851 * font.c (Ffont_variation_glyphs):
11852 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
11853 * lisp.h: Include <intprops.h>.
11854 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
11855 (cons_to_signed, cons_to_unsigned): New decls.
11856 (long_to_cons, cons_to_long): Remove decls.
11857 * undo.c (record_first_change): Use INTEGER_TO_CONS.
11858 (Fprimitive_undo): Use CONS_TO_INTEGER.
11859 * xfns.c (Fx_window_property): Likewise.
11860 * xselect.c: Include <limits.h>.
11861 (x_own_selection, selection_data_to_lisp_data):
11862 Use INTEGER_TO_CONS.
11863 (x_handle_selection_request, x_handle_selection_clear)
11864 (x_get_foreign_selection, Fx_disown_selection_internal)
11865 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
11866 (lisp_data_to_selection_data): Use cons_to_unsigned.
11867 (x_fill_property_data): Use cons_to_signed.
11868 Report values out of range.
11869
d1f3d2af
PE
11870 Check for buffer and string overflow more precisely.
11871 * buffer.h (BUF_BYTES_MAX): New macro.
11872 * lisp.h (STRING_BYTES_MAX): New macro.
11873 * alloc.c (Fmake_string):
11874 * character.c (string_escape_byte8):
11875 * coding.c (coding_alloc_by_realloc):
11876 * doprnt.c (doprnt):
11877 * editfns.c (Fformat):
11878 * eval.c (verror):
11879 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
11880 since they may not be the same number.
11881 * editfns.c (Finsert_char):
11882 * fileio.c (Finsert_file_contents):
11883 Likewise for BUF_BYTES_MAX.
11884
dd52fcea
PE
11885 * image.c: Use ptrdiff_t, not int, for sizes.
11886 (slurp_file): Switch from int to ptrdiff_t.
11887 All uses changed.
11888 (slurp_file): Check that file size fits in both size_t (for
11889 malloc) and ptrdiff_t (for sanity and safety).
11890
7f9bbdbb
PE
11891 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
11892 if b->modtime has its maximal value.
11893
dfe18f82
PE
11894 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
11895
84acfcf0
PE
11896 Don't assume time_t can fit into int.
11897 * buffer.h (struct buffer.modtime): Now time_t, not int.
11898 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
11899 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
11900
ccd9a01a
PE
11901 Minor fixes for signed vs unsigned integers.
11902 * character.h (MAYBE_UNIFY_CHAR):
11903 * charset.c (maybe_unify_char):
11904 * keyboard.c (read_char, reorder_modifiers):
11905 XINT -> XFASTINT, since the integer must be nonnegative.
11906 * ftfont.c (ftfont_spec_pattern):
11907 * keymap.c (access_keymap, silly_event_symbol_error):
11908 XUINT -> XFASTINT, since the integer must be nonnegative.
11909 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
11910 since it makes no difference and we prefer signed.
11911 * keyboard.c (record_char): Use XUINT when all the neighbors do.
11912 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
11913 nonnegative.
11914
d6d100dd
SM
119152011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
11916
11917 * window.h (Fwindow_frame): Declare.
11918
2b6148e4
PE
119192011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11920
11921 * alloc.c: Simplify handling of large-request failures (Bug#8800).
11922 (SPARE_MEMORY): Always define.
11923 (LARGE_REQUEST): Remove.
11924 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
11925
f230ecc9
MR
119262011-06-06 Martin Rudalics <rudalics@gmx.at>
11927
727e958e
MR
11928 * lisp.h: Move EXFUNS for Fframe_root_window,
11929 Fframe_first_window and Fset_frame_selected_window to window.h.
11930
11931 * window.h: Move EXFUNS for Fframe_root_window,
11932 Fframe_first_window and Fset_frame_selected_window here from
11933 lisp.h.
11934
11935 * frame.c (Fwindow_frame, Fframe_first_window)
11936 (Fframe_root_window, Fframe_selected_window)
11937 (Fset_frame_selected_window): Move to window.c.
11938 (Factive_minibuffer_window): Move to minibuf.c.
11939 (Fother_visible_frames_p): New function.
11940
11941 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
11942
f230ecc9
MR
11943 * window.c (decode_window, decode_any_window): Move up in code.
11944 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
11945 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
11946 (Fwindow_buffer): Move up and rewrite doc-string.
11947 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
11948 (Fwindow_prev): New functions.
727e958e
MR
11949 (Fwindow_frame): Move here from frame.c. Accept any window as
11950 argument.
11951 (Fframe_root_window, Fframe_first_window)
11952 (Fframe_selected_window): Move here from frame.c. Accept frame
11953 or arbitrary window as argument. Update doc-strings.
11954 (Fminibuffer_window): Move up in code.
11955 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
11956 (Fset_frame_selected_window): Move here from frame.c.
11957 Marginal rewrite.
727e958e
MR
11958 (Fselected_window, select_window, Fselect_window): Move up in
11959 code. Minor doc-string fixes.
f230ecc9 11960
4d09bcf6
PE
119612011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11962
11963 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
11964 Do not assume that spare memory exists; that assumption is valid
11965 only if SYSTEM_MALLOC.
11966 (LARGE_REQUEST): New macro, so that the issue of large requests
11967 is separated from the issue of spare memory.
11968
810928a2
AS
119692011-06-05 Andreas Schwab <schwab@linux-m68k.org>
11970
172418ad
AS
11971 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
11972 format. (Bug#8806)
11973
43f862f7
AS
11974 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
11975
810928a2
AS
11976 * xfns.c (x_set_scroll_bar_default_width): Move declarations
11977 before statements.
11978
a059fe24
JD
119792011-06-05 Jan Djärv <jan.h.d@swipnet.se>
11980
11981 * gtkutil.c (xg_get_default_scrollbar_width): New function.
11982
11983 * gtkutil.h: Declare xg_get_default_scrollbar_width.
11984
11985 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
11986 min width by calling x_set_scroll_bar_default_width (Bug#8505).
11987
989bf368
JB
119882011-06-05 Juanma Barranquero <lekktu@gmail.com>
11989
11990 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
11991
4b80f674
CY
119922011-06-04 Chong Yidong <cyd@stupidchicken.com>
11993
11994 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
11995 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
11996 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
11997 New error handlers.
4b80f674
CY
11998 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
11999 Obey Vx_select_enable_clipboard_manager. Catch errors in
12000 x_clipboard_manager_save (Bug#8779).
12001 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 12002 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 12003
99a33b77 120042011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
12005
12006 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
12007
99a33b77 120082011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
12009
12010 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
12011 in the current matrix if keep_current_p is non-zero.
12012
8264569d
EZ
120132011-06-04 Eli Zaretskii <eliz@gnu.org>
12014
12015 * bidi.c (bidi_level_of_next_char): Fix last change.
12016
57f97249
EZ
120172011-06-03 Eli Zaretskii <eliz@gnu.org>
12018
fec2107c 12019 Support bidi reordering of text covered by display properties.
57f97249 12020
fec2107c
EZ
12021 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
12022 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
12023 (bidi_cache_search, bidi_cache_iterator_state)
12024 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
12025 (bidi_level_of_next_char, bidi_move_to_visually_next):
12026 Support character positions inside a run of characters covered by a
fec2107c
EZ
12027 display string.
12028 (bidi_paragraph_init, bidi_resolve_explicit_1)
12029 (bidi_level_of_next_char): Call bidi_fetch_char and
12030 bidi_fetch_char_advance instead of FETCH_CHAR and
12031 FETCH_CHAR_ADVANCE.
12032 (bidi_init_it): Initialize new members.
12033 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
12034 definitions.
12035 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
12036 instead of using explicit *_CHAR codes.
d6d100dd
SM
12037 (bidi_resolve_explicit, bidi_resolve_weak):
12038 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
12039 bidirectional text is supported only in multibyte buffers.
12040 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
12041 it to initialize the frame_window_p member of struct bidi_it.
12042 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
12043 (bidi_resolve_explicit, bidi_resolve_weak)
12044 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
12045 bidi_it->nchars is non-positive.
12046 (bidi_level_of_next_char): Don't try to lookup the cache for the
12047 next/previous character if nothing is cached there yet, or if we
12048 were just reseat()'ed to a new position.
c40e2fb2 12049
0e14fe90
EZ
12050 * xdisp.c (set_cursor_from_row): Set start and stop points
12051 according to the row's direction when priming the loop that looks
12052 for the glyph on which to display cursor.
12053 (single_display_spec_intangible_p): Function deleted.
12054 (display_prop_intangible_p): Reimplement to call
12055 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
12056 Accept 3 additional arguments needed by handle_display_spec.
12057 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
12058 values: lists, `(when COND...)' forms, etc.
12059 (single_display_spec_string_p): Support property values that are
12060 lists with the argument STRING its top-level element.
12061 (display_prop_string_p): Fix the condition for processing a
12062 property that is a list to be consistent with handle_display_spec.
fec2107c 12063 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
12064 last portion of handle_display_prop.
12065 (compute_display_string_pos): Accept additional argument
12066 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
12067 value of a `display' property is a "replacing spec".
12068 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
12069 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
12070 the display property, but just return a value indicating whether
12071 the display property will replace the characters it covers.
12072 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
12073 frame_window_p members of struct bidi_it.
d6d100dd
SM
12074 (compute_display_string_pos, compute_display_string_end):
12075 New functions.
fec2107c
EZ
12076 (push_it): Accept second argument POSITION, where pop_it should
12077 jump to continue iteration.
12078 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 12079
fec2107c
EZ
12080 * keyboard.c (adjust_point_for_property): Adjust the call to
12081 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
12082
12083 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
12084 (bidi_init_it): Update prototypes.
12085 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
12086 (compute_display_string_pos, compute_display_string_end):
12087 Declare prototypes.
fec2107c
EZ
12088 (struct bidi_it): New members nchars and disp_pos. ch_len is now
12089 EMACS_INT.
fc6f18ce 12090
40087514 120912011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 12092
57f53182
PE
12093 Malloc failure behavior now depends on size of allocation.
12094 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
12095 * lisp.h: Change signatures accordingly.
12096 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
12097 All callers changed. (Bug#8762)
12098
12099 * gnutls.c: Use Emacs's memory allocators.
12100 Without this change, the gnutls library would invoke malloc etc.
12101 directly, which causes problems on non-SYNC_INPUT hosts, and which
12102 runs afoul of improving memory_full behavior. (Bug#8761)
12103 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
12104 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
12105 xfree instead of the default malloc, realloc, free.
12106 (Fgnutls_boot): No need to check for memory allocation failure,
12107 since xmalloc does that for us.
12108
ac32cd99 12109 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
12110 * category.c (hash_get_category_set):
12111 * ccl.c (ccl_driver):
12112 * charset.c (Fdefine_charset_internal):
12113 * charset.h (struct charset.hash_index):
12114 * composite.c (get_composition_id, gstring_lookup_cache)
12115 (composition_gstring_put_cache):
12116 * composite.h (struct composition.hash_index):
12117 * dispextern.h (struct image.hash):
12118 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
12119 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
12120 (hashfn_equal, hashfn_user_defined, make_hash_table)
12121 (maybe_resize_hash_table, hash_lookup, hash_put)
12122 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
12123 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
12124 (Fsxhash, Fgethash, Fputhash, Fmaphash):
12125 * image.c (make_image, search_image_cache, lookup_image)
12126 (xpm_put_color_table_h):
12127 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 12128 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 12129 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 12130 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
12131 * alloc.c (allocate_vectorlike):
12132 Check for overflow in vector size calculations.
12133 * ccl.c (ccl_driver):
12134 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
12135 * fns.c, image.c: Remove unnecessary static decls that would otherwise
12136 need to be updated by these changes.
40087514
PE
12137 * fns.c (make_hash_table, maybe_resize_hash_table):
12138 Check for integer overflow with large hash tables.
0de4bb68
PE
12139 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
12140 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
12141 (SXHASH_REDUCE): New macro.
12142 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
12143 Use it instead of discarding useful hash info with large hash values.
12144 (sxhash_float): New function.
12145 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
12146 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
12147 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
12148 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
12149 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
12150 Adjust signatures to match updated version of code.
12151 (consing_since_gc): Now EMACS_INT, since a single hash table can
12152 use more than INT_MAX bytes.
12153
698d32e2
DN
121542011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
12155
12156 Make it possible to build with GCC-4.6+ -O2 -flto.
12157
12158 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
12159
fd6fa53f
SM
121602011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
12161
12162 * minibuf.c (get_minibuffer, read_minibuf_unwind):
12163 Call minibuffer-inactive-mode.
12164
864db017
JB
121652011-05-31 Juanma Barranquero <lekktu@gmail.com>
12166
12167 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
12168 Update dependencies.
12169
2ad0baf4
DN
121702011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
12171
12172 * data.c (init_data): Remove code for UTS, this system is not
12173 supported anymore.
12174
4fcc2638
DN
121752011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
12176
12177 Don't force ./temacs to start in terminal mode.
12178
12179 * frame.c (make_initial_frame): Initialize faces in all cases, not
12180 only when CANNOT_DUMP is defined.
12181 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
12182
c56e0fd5
DN
121832011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
12184
12185 * dispnew.c (add_window_display_history): Use const for the string
12186 pointer. Remove declaration, not needed.
12187
333d54da 121882011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 12189
55d4c1b2 12190 Use 'inline', not 'INLINE'.
333d54da 12191 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
12192 * alloc.c, fontset.c (INLINE): Remove.
12193 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
12194 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
12195 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
12196 * gmalloc.c (register_heapinfo): Use inline unconditionally.
12197 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
12198
738db178
DN
121992011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
12200
12201 Make it possible to run ./temacs.
12202
12203 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
12204 syms_of_callproc does the same thing. Remove test for
12205 "initialized", do it in the caller.
12206 * emacs.c (main): Avoid calling set_initial_environment when dumping.
12207
620c53a6
SM
122082011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
12209
12210 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
12211 (read_minibuf): Use get_minibuffer.
12212 (syms_of_minibuf): Use DEFSYM.
12213 (Qmetadata): New var.
12214 * data.c (Qbuffer): Don't make it static.
12215 (syms_of_data): Use DEFSYM.
12216
e003a292
PE
122172011-05-31 Paul Eggert <eggert@cs.ucla.edu>
12218
12219 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
12220 (CCL_CODE_MIN): New macro.
12221
ed008a6d
PE
122222011-05-30 Paul Eggert <eggert@cs.ucla.edu>
12223
3687c2ef
PE
12224 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
12225
ed008a6d
PE
12226 * eval.c (Qdebug): Now static.
12227 * lisp.h (Qdebug): Remove decl. This reverts a part of the
12228 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
12229 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
12230
d66c4c7c
CY
122312011-05-29 Chong Yidong <cyd@stupidchicken.com>
12232
12233 * image.c: Various fixes to ImageMagick code comments.
12234 (Fimagemagick_types): Doc fix.
12235
5fbc2025
PE
122362011-05-29 Paul Eggert <eggert@cs.ucla.edu>
12237
0196f88a
PE
12238 Minor fixes prompted by GCC 4.6.0 warnings.
12239
12240 * xselect.c (converted_selections, conversion_fail_tag): Now static.
12241
5fbc2025
PE
12242 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
12243 (x_clipboard_manager_save_all): Move extern decl to ...
12244 * xterm.h: ... here, so that it can be checked for consistency.
12245
1dd3c2d9
CY
122462011-05-29 Chong Yidong <cyd@stupidchicken.com>
12247
12248 * xselect.c (x_clipboard_manager_save_frame)
12249 (x_clipboard_manager_save_all): New functions.
12250 (Fx_clipboard_manager_save): Lisp function deleted.
12251
12252 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
12253 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
12254
12255 * xterm.h: Update prototype.
12256
5ba6571d
WX
122572011-05-28 William Xu <william.xwl@gmail.com>
12258
12259 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
12260 exiting (Bug#8239).
12261
3eaff834
JM
122622011-05-28 Jim Meyering <meyering@redhat.com>
12263
e1900994 12264 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
12265 * fns.c (to_uchar): Define.
12266 (crypto_hash_function): Use it to convert some newly-signed
12267 variables to unsigned, to avoid sign-extension bugs. For example,
12268 without this change, (md5 "truc") would evaluate to
12269 45723a2aff78ff4fff7fff1114760e62 rather than the expected
12270 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 12271 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 12272
0f6990a7
PE
122732011-05-27 Paul Eggert <eggert@cs.ucla.edu>
12274
12275 Integer overflow fixes.
c8a9ca5a 12276
08686060
PE
12277 * dbusbind.c: Serial number integer overflow fixes.
12278 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
12279 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
12280 to hold a serial number that is too large for a fixnum.
12281 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12282 Check for serial numbers out of range. Decode any serial number
59568bf0 12283 that was so large that it became a float. (Bug#8722)
08686060 12284
2d1fc3c7
PE
12285 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
12286 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12287 Use XFASTINT rather than XUINT when numbers are nonnegative.
12288 (xd_append_arg, Fdbus_method_return_internal):
12289 (Fdbus_method_error_internal): Likewise. Also, for unsigned
12290 arguments, check that Lisp number is nonnegative, rather than
59568bf0 12291 silently wrapping negative numbers around. (Bug#8722)
30217ff0 12292 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 12293 (Bug#8722)
2d1fc3c7 12294
c8a9ca5a
PE
12295 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
12296
519e1d69
PE
12297 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
12298
6df6ae42 12299 ccl: Add integer overflow checks.
30569699
PE
12300 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
12301 (IN_INT_RANGE): New macros.
12302 (ccl_driver): Use them to check for integer overflow when
12303 decoding a CCL program. Many of the new checks are whether XINT (x)
12304 fits in int; it doesn't always, on 64-bit hosts. The new version
12305 doesn't catch all possible integer overflows, but it's an
847044ea 12306 improvement. (Bug#8719)
30569699 12307
c11285dc
PE
12308 * alloc.c (make_event_array): Use XINT, not XUINT.
12309 There's no need for unsigned here.
12310
fdccd48e
PE
12311 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
12312 This follows up to the 2011-05-06 change that substituted uintptr_t
12313 for EMACS_INT. This case wasn't caught back then.
12314
37910ab2
PE
12315 Rework Fformat to avoid integer overflow issues.
12316 * editfns.c: Include <float.h> unconditionally, as it's everywhere
12317 now (part of C89). Include <verify.h>.
12318 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
12319 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
12320 (Fformat): Avoid the prepass trying to compute sizes; it was only
12321 approximate and thus did not catch overflow reliably. Instead, walk
12322 through the format just once, formatting and computing sizes as we go,
12323 checking for integer overflow at every step, and allocating a larger
12324 buffer as needed. Keep track separately whether the format is
12325 multibyte. Keep only the most-recently calculated precision, rather
12326 than them all. Record whether each argument has been converted to
12327 string. Use EMACS_INT, not int, for byte and char and arg counts.
12328 Support field widths and precisions larger than INT_MAX. Avoid
12329 sprintf's undefined behavior with conversion specifications such as %#d
12330 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
12331 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
12332 formatting out-of-range floating point numbers with int
9173deec 12333 formats. (Bug#8668)
37910ab2 12334
2e6578fb
PE
12335 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
12336
0ae6bdee
PE
12337 * data.c: Avoid integer truncation in expressions involving floats.
12338 * data.c: Include <intprops.h>.
12339 (arith_driver): When there's an integer overflow in an expression
12340 involving floating point, convert the integers to floating point
12341 so that the resulting value does not suffer from catastrophic
12342 integer truncation. For example, on a 64-bit host (* 4
12343 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
12344 Do not rely on undefined behavior after integer overflow.
12345
de883a70
PE
12346 merge count_size_as_multibyte, parse_str_to_multibyte
12347 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 12348 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
12349 Check for integer overflow.
12350 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
12351 since it's now a duplicate of the other. This is more of
12352 a character than a buffer op, so better that it's in character.c.
12353 * fns.c, print.c: Adjust to above changes.
12354
2ff916cb
PE
123552011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
12356
12357 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
12358
f1b54466
PE
123592011-05-27 Paul Eggert <eggert@cs.ucla.edu>
12360
fb1ac845
PE
12361 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
12362 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
12363 (x_clipboard_manager_save): Now static.
12364 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
12365
f1b54466
PE
12366 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
12367 (crypto_hash_function): Now static.
12368 Fix pointer signedness problems. Avoid unnecessary initializations.
12369
a9f737ee
CY
123702011-05-27 Chong Yidong <cyd@stupidchicken.com>
12371
12372 * termhooks.h (Vselection_alist): Make it terminal-local.
12373
12374 * terminal.c (create_terminal): Initialize it.
12375
12376 * xselect.c: Support for clipboard managers.
12377 (Vselection_alist): Move to termhooks.h as terminal-local var.
12378 (LOCAL_SELECTION): New macro.
12379 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
12380 (symbol_to_x_atom): Remove gratuitous arg.
12381 (x_handle_selection_request, lisp_data_to_selection_data)
12382 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
12383 (x_own_selection, x_get_local_selection, x_convert_selection):
12384 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
12385 (some_frame_on_display): Delete unused function.
12386 (Fx_own_selection_internal, Fx_get_selection_internal)
12387 (Fx_disown_selection_internal, Fx_selection_owner_p)
12388 (Fx_selection_exists_p): New optional frame arg.
12389 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
12390 (x_handle_selection_clear): Don't treat other terminals with the
12391 same keyboard specially. Use the terminal-local Vselection_alist.
12392 (x_clear_frame_selections): Use Frun_hook_with_args.
12393
12394 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
12395
12396 * xterm.h: Add support for those atoms.
12397
e067f0c1
CY
123982011-05-26 Chong Yidong <cyd@stupidchicken.com>
12399
12400 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
12401 (converted_selections, conversion_fail_tag): New global variables.
12402 (x_selection_request_lisp_error): Free the above.
12403 (x_get_local_selection): Remove unnecessary code.
12404 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
12405 of converted selections stored in converted_selections.
12406 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
12407 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
12408 (x_convert_selection): New function.
12409 (x_handle_selection_event): Simplify.
12410 (x_get_foreign_selection): Don't ignore incoming requests while
12411 waiting for an answer; this will fail when we implement
12412 SAVE_TARGETS, and seems unnecessary anyway.
12413 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
12414 (Vx_sent_selection_functions): Doc fix.
12415
0f4aebc0
LL
124162011-05-26 Leo Liu <sdl.web@gmail.com>
12417
12418 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
12419
e61124cd
YM
124202011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12421
12422 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
12423
12424 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
12425 for fringe update if it has periodic bitmap.
ac389d0c 12426 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
12427 and fringe_bitmap_periodic_p.
12428
12429 * fringe.c (get_fringe_bitmap_data): New function.
12430 (draw_fringe_bitmap_1, update_window_fringes): Use it.
12431 (update_window_fringes): Record periodicity of fringe bitmap in glyph
12432 row. Mark glyph row for fringe update if periodicity changed.
12433
12434 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
12435 for fringe update unless it has periodic bitmap.
12436
f16d9837
KH
124372011-05-25 Kenichi Handa <handa@m17n.org>
12438
12439 * xdisp.c (get_next_display_element): Set correct it->face_id for
12440 a static composition.
12441
e1b90ef6
LL
124422011-05-24 Leo Liu <sdl.web@gmail.com>
12443
12444 * deps.mk (fns.o):
12445 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
12446
12447 * fns.c (crypto_hash_function, Fsha1): New function.
12448 (Fmd5): Use crypto_hash_function.
12449 (syms_of_fns): Add Ssha1.
12450
7400048f
PE
124512011-05-22 Paul Eggert <eggert@cs.ucla.edu>
12452
12453 * gnutls.c: Remove unused macros.
12454 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
12455 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
12456 Remove macros that are defined and never used.
12457 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
12458
abb71cf4
CY
124592011-05-22 Chong Yidong <cyd@stupidchicken.com>
12460
12461 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
12462 (Fx_get_selection_internal): Minor cleanup.
12463 (Fx_own_selection_internal): Rename arguments for consistency with
12464 select.el.
12465
6307db39
PE
124662011-05-22 Paul Eggert <eggert@cs.ucla.edu>
12467
12468 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
12469
f3d4e0a4
CY
124702011-05-22 Chong Yidong <cyd@stupidchicken.com>
12471
12472 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
12473
4d8ade89
YM
124742011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12475
12476 * dispnew.c (scrolling_window): Don't exclude the case that the
12477 last enabled row in the desired matrix touches the bottom boundary.
12478
32078c8d
GM
124792011-05-21 Glenn Morris <rgm@gnu.org>
12480
12481 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
12482 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
12483 and add some more files.
32078c8d 12484
7285dc67
EZ
124852011-05-20 Eli Zaretskii <eliz@gnu.org>
12486
12487 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
12488 report_file_error introduced by the change from 2011-05-07.
12489
89d1bd22
PE
124902011-05-20 Paul Eggert <eggert@cs.ucla.edu>
12491
12492 * systime.h (Time): Define only if emacs is defined.
12493 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
12494 where the include path doesn't have X11/X.h by default. See
12495 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
12496
cd394be1 124972011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
12498
12499 * composite.c (find_automatic_composition): Fix previous change.
12500
b9704ad9
GM
125012011-05-20 Glenn Morris <rgm@gnu.org>
12502
12503 * lisp.mk: New file, split from Makefile.in.
12504 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
12505 (shortlisp): Remove.
12506 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
12507
4a720484
GM
125082011-05-19 Glenn Morris <rgm@gnu.org>
12509
12510 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
12511 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
12512 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
12513 (lisp): Set the order to that of loadup.el.
12514 (shortlisp): Make it a copy of $lisp.
12515 (SOME_MACHINE_LISP): Remove.
12516 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
12517 Use just $shortlisp, not $SOME_MACHINE_LISP too.
12518
a28d4396
KH
125192011-05-18 Kenichi Handa <handa@m17n.org>
12520
12521 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
12522 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
12523 (find_automatic_composition): Mostly rewrite for efficiency.
12524
a2b1fa8e
JB
125252011-05-18 Juanma Barranquero <lekktu@gmail.com>
12526
12527 * makefile.w32-in: Update dependencies.
12528
8e1f5610
CS
125292011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
12530
12531 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 12532 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 12533
7025ee00 125342011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 12535
cdfa6eab
PE
12536 Fix some integer overflow issues, such as string length overflow.
12537
06d6db33
PE
12538 * insdel.c (count_size_as_multibyte): Check for string overflow.
12539
2b4560a8
PE
12540 * character.c (lisp_string_width): Check for string overflow.
12541 Use EMACS_INT, not int, for string indexes and lengths; in
12542 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
12543 the resulting string length overflows an EMACS_INT; instead,
12544 report a string overflow if no precision given. When checking for
12545 precision exhaustion, use a check that cannot possibly have
12546 integer overflow. (Bug#8675)
12547 * character.h (lisp_string_width): Adjust to new signature.
12548
cb93f9be
PE
12549 * alloc.c (string_overflow): New function.
12550 (Fmake_string): Use it. This doesn't change behavior, but saves
12551 a few bytes and will simplify future changes.
12552 * character.c (string_escape_byte8): Likewise.
12553 * lisp.h (string_overflow): New decl.
12554
1a1f3366
PE
12555 Fixups, following up to the user-interface timestamp change.
12556 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
12557 for UI timestamps, instead of unsigned long.
9fbd6841
PE
12558 * msdos.c (mouse_get_pos): Likewise.
12559 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
12560 * w32gui.h (Time): Define by including "systime.h" rather than by
12561 declaring it ourselves. (Bug#8664)
12562
d4e3e4d3
PE
12563 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
12564 * image.c (clear_image_cache): Likewise.
12565
f6a24d19
PE
12566 * term.c (term_mouse_position): Don't assume time_t wraparound.
12567
08dc5ae6
PE
12568 Be more systematic about user-interface timestamps.
12569 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
12570 and sometimes 'EMACS_UINT', to represent these timestamps.
12571 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
12572 This makes the code easier to follow, and makes it easier to catch
12573 integer overflow bugs such as Bug#8664.
12574 * frame.c (Fmouse_position, Fmouse_pixel_position):
12575 Use Time, not unsigned long, for user-interface timestamps.
12576 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
12577 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
12578 * keyboard.h (last_event_timestamp): Likewise.
12579 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
12580 * menu.h (xmenu_show): Likewise.
12581 * term.c (term_mouse_position): Likewise.
12582 * termhooks.h (struct input_event.timestamp): Likewise.
12583 (struct terminal.mouse_position_hook): Likewise.
12584 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
12585 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
12586 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
12587 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
12588 what it was before.
12589 * menu.h, termhooks.h: Include "systime.h", for Time.
12590
8e55734a
PE
12591 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
12592 Don't assume that the difference between two unsigned long values
12593 can fit into an integer. At this point, we know button_down_time
12594 <= event->timestamp, so the difference must be nonnegative, so
12595 there's no need to cast the result if double-click-time is
12596 nonnegative, as it should be; check that it's nonnegative, just in
12597 case. This bug is triggered when events are more than 2**31 ms
86db42d2 12598 apart (about 25 days). (Bug#8664)
8e55734a 12599
841f1b75 12600 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 12601 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 12602
3e26f69c
PE
12603 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
12604 that always fit in int. Use a sentinel instead of a counter, to
12605 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
12606 * frame.h (struct frame): Use int for menu_bar_items_used
12607 instead of EMACS_INT, since it always fits in int.
3e26f69c 12608
5cc152c0
PE
12609 * menu.c (grow_menu_items): Check for int overflow.
12610
d89eb65e
PE
12611 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
12612
5235bd3e
PE
12613 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
12614 Before, the code was not consistent. These values cannot exceed
12615 2**31 - 1 so there's no need to make them unsigned.
12616 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
12617 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
12618 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
12619 as modifiers.
12620 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
12621
bc827e23
PE
12622 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
12623 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
12624 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
12625 presumably because the widths might not match.
12626
78eb494e
PE
12627 * window.c (size_window): Avoid needless test at loop start.
12628
04f2d78b
CB
126292011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
12630
12631 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
12632
d2fc7e3d 126332011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
12634
12635 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
12636
d2fc7e3d 126372011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
12638
12639 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
12640 `width' to `bar_area_x' and `bar_area_width', respectively.
12641 (x_scroll_run): Take account of fringe background extension.
12642
04f2d78b
CB
12643 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
12644 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
12645 `bar_area_width', respectively.
12646 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
12647 background extension.
12648
79b70037
GM
126492011-05-10 Jim Meyering <meyering@redhat.com>
12650
12651 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
12652
2f142cc5
JB
126532011-05-10 Juanma Barranquero <lekktu@gmail.com>
12654
12655 * image.c (Finit_image_library): Return t for built-in image types,
12656 like pbm and xbm. (Bug#8640)
12657
57679c86
AS
126582011-05-09 Andreas Schwab <schwab@linux-m68k.org>
12659
12660 * w32menu.c (set_frame_menubar): Fix submenu allocation.
12661
888c9e86
EZ
126622011-05-07 Eli Zaretskii <eliz@gnu.org>
12663
b0512a1d
EZ
12664 * w32console.c (Fset_screen_color): Doc fix.
12665 (Fget_screen_color): New function.
12666 (syms_of_ntterm): Defsubr it.
12667
7285dc67
EZ
12668 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
12669 unlink the temporary file if Fcall_process didn't create it in the
12670 first place.
12671 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
12672 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
12673 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
12674 cue to call_process_cleanup not to close that handle.
12675
4d3fcc8e
BK
126762011-05-07 Ben Key <bkey76@gmail.com>
12677
12678 * makefile.w32-in: The bootstrap-temacs rule now makes use of
12679 one of two shell specific rules, either bootstrap-temacs-CMD or
12680 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
12681 to the previous implementation of the bootstrap-temacs rule.
12682 The bootstrap-temacs-CMD rule is similar to the previous
12683 implementation of the bootstrap-temacs rule except that it
12684 makes use of the ESC_CFLAGS variable instead of the CFLAGS
12685 variable.
12686
12687 These changes, along with some changes to nt/configure.bat,
12688 nt/gmake.defs, and nt/nmake.defs, are required to extend my
12689 earlier fix to add support for --cflags and --ldflags options
12690 that include quotes so that it works whether make uses cmd or
12691 sh as the shell.
12692
b4289b64
MA
126932011-05-06 Michael Albinus <michael.albinus@gmx.de>
12694
12695 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
12696 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
12697 is a constant.
12698 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
12699 a string. Handle both cases.
12700 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
12701 (Fdbus_register_method): Use Qinvalid_function.
12702
af4c0e28
JB
127032011-05-06 Juanma Barranquero <lekktu@gmail.com>
12704
12705 * makefile.w32-in: Update dependencies.
12706 (LISP_H): Add inttypes.h and stdin.h.
12707 (PROCESS_H): Add unistd.h.
12708
c51453d9
EZ
127092011-05-06 Eli Zaretskii <eliz@gnu.org>
12710
12711 * lread.c: Include limits.h (fixes the MS-Windows build broken by
12712 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
12713
8ff0ac3c 127142011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 12715
4c4b566b
PE
12716 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
12717
aab2b9b5
PE
12718 * term.c (vfatal): Remove stray call to va_end.
12719 It's not needed and the C Standard doesn't allow it here anyway.
12720
c378da0b
PE
12721 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
12722 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
12723
288b08c7
PE
12724 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
12725 bytes.
12726
e3601888
PE
12727 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
12728
db6c0e74
PE
12729 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
12730
dd5963ea
PE
12731 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
12732
88c9450f
PE
12733 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
12734
2f9442b8
PE
12735 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
12736
c032b5f8
PE
12737 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
12738 * charset.c (Fdefine_charset_internal): Don't initialize
12739 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 12740 32-bit int (Bug#8600).
a108c10b
PE
12741
12742 * lread.c (read_integer): Be more consistent with string-to-number.
12743 Use string_to_number to do the actual conversion; this avoids
12744 rounding errors and fixes some other screwups. Without this fix,
12745 for example, #x1fffffffffffffff was misread as -2305843009213693952.
12746 (digit_to_number): Move earlier, for benefit of read_integer.
12747 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 12748 not a digit in any supported base. (Bug#8602)
a108c10b 12749
ad5f9eea
PE
12750 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
12751
aec1708a
PE
12752 * dispnew.c (scrolling_window): Return 1 if we scrolled,
12753 to match comment at start of function. This also removes a
12754 GCC warning about overflow in a 32+64-bit port.
12755
47be4ab5
PE
12756 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
12757
371cac43
PE
12758 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
12759 Reported by Stefan Monnier in
12760 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
12761 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12762 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 12763
d01a7826
PE
12764 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
12765 (EMACS_UINTPTR): Likewise, with uintptr_t.
12766
7fd47d5c
PE
12767 * lisp.h: Prefer 64-bit EMACS_INT if available.
12768 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
12769 on 32-bit hosts that have 64-bit int, so that they can access
12770 large files.
122b0c86
PE
12771 However, temporarily disable this change unless the temporary
12772 symbol WIDE_EMACS_INT is defined.
7fd47d5c 12773
8727937b
PE
12774 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
12775
8ac068ac
PE
12776 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
12777 This removes an assumption that EMACS_INT and long are the same
12778 width as pointers. The assumption is true for Emacs porting targets
12779 now, but we want to make other targets possible.
12780 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
12781 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
12782 In the rest of the code, change types of integers that hold casted
12783 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
12784 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
12785 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
12786 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
12787 No need to cast type when ORing.
12788 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
12789 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
12790 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
12791 assume EMACS_INT is the same width as char *.
12792 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
12793 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
12794 Remove no-longer-needed casts.
12795 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
12796 (xg_tool_bar_help_callback, xg_make_tool_item):
12797 Use EMACS_INTPTR to hold an integer
12798 that will be cast to void *; this can avoid a GCC warning
12799 if EMACS_INT is not the same width as void *.
12800 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
12801 * xdisp.c (display_echo_area_1, resize_mini_window_1):
12802 (current_message_1, set_message_1):
12803 Use a local to convert to proper width without a cast.
12804 * xmenu.c (dialog_selection_callback): Likewise.
12805
ede49d71
PE
12806 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
12807 Also, don't assume VALBITS / RAND_BITS is less than 5,
12808 and don't rely on undefined behavior when shifting a 1 left into
12809 the sign bit.
12810 * lisp.h (get_random): Change signature to match.
12811
2f30ecd0
PE
12812 * lread.c (hash_string): Use size_t, not int, for hash computation.
12813 Normally we prefer signed values; but hashing is special, because
12814 it's better to use unsigned division on hash table sizes so that
12815 the remainder is nonnegative. Also, size_t is the natural width
12816 for hashing into memory. The previous code used 'int', which doesn't
12817 retain enough info to hash well into very large tables.
12818 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
12819
2a866e7b
PE
12820 * dbusbind.c: Don't possibly lose pointer info when converting.
12821 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12822 Use XPNTR rather than XHASH, so that the high-order bits of
12823 the pointer aren't lost when converting through void *.
12824
51639eac
PE
12825 * eval.c (Fautoload): Don't double-shift a pointer.
12826
92394119
PE
12827 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
12828
dbdb9a7c
JB
128292011-05-06 Juanma Barranquero <lekktu@gmail.com>
12830
12831 * gnutls.c (DEF_GNUTLS_FN):
12832 * image.c (DEF_IMGLIB_FN): Make function pointers static.
12833
db7a0b4f
AS
128342011-05-05 Andreas Schwab <schwab@linux-m68k.org>
12835
12836 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
12837 marker. (Bug#8610)
12838
cd394be1 128392011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
12840
12841 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
12842 New version that can reserve upto 2GB of heap space.
12843
f7ff1b0f 128442011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
12845
12846 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
12847
639c109b
TZ
128482011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
12849
12850 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
12851 `gnutls_certificate_set_x509_key_file'.
12852
d2127135
JB
128532011-05-05 Juanma Barranquero <lekktu@gmail.com>
12854
12855 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
12856 Update dependencies.
12857
e968f4f3
JB
128582011-05-04 Juanma Barranquero <lekktu@gmail.com>
12859
12860 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
12861 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
12862 Remove unused parameter `fildes'.
12863 * process.c (read_process_output, send_process): Don't pass it.
12864
84d358f0
JB
128652011-05-04 Juanma Barranquero <lekktu@gmail.com>
12866
12867 Fix previous change: the library cache is defined in w32.c.
12868 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
12869 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
12870
0898ca10
JB
128712011-05-04 Juanma Barranquero <lekktu@gmail.com>
12872
12873 Implement dynamic loading of GnuTLS on Windows.
12874
12875 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
12876 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
12877 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12878 Declare.
12879
12880 * gnutls.c (Qgnutls_dll): Define.
12881 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
12882 (gnutls_*): Declare function pointers.
12883 (init_gnutls_functions): New function to initialize function pointers.
12884 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
12885 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
12886 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12887 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
12888 (emacs_gnutls_write, emacs_gnutls_read)
12889 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
12890 (Fgnutls_available_p): New function.
12891 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
12892 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
12893 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
12894
12895 * image.c: Include w32.h.
12896 (Vimage_type_cache): Delete.
12897 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
12898 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
12899 (w32_delayed_load): Move to w32.c.
12900
12901 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
12902
12903 * w32.c (QCloaded_from, Vlibrary_cache): Define.
12904 (w32_delayed_load): Move from image.c. When loading a library, record
12905 its filename in the :loaded-from property of the library id.
12906 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
12907 Initialize and staticpro them.
12908 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
12909
12910 * process.c: Include lisp.h before w32.h, not after.
12911 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
12912 instead of gnutls_record_check_pending.
12913
12914 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
12915
ff4de4aa
TZ
129162011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
12917
12918 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
12919 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
12920 as passed in.
12921
abe95abb
JD
129222011-05-03 Jan Djärv <jan.h.d@swipnet.se>
12923
12924 * xterm.c (x_set_frame_alpha): Do not set property on anything
12925 else than FRAME_X_OUTER_WINDOW (Bug#8608).
12926
e16e55d4
JB
129272011-05-02 Juanma Barranquero <lekktu@gmail.com>
12928
12929 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
12930
bafcf6a5
JB
129312011-05-02 Juanma Barranquero <lekktu@gmail.com>
12932
12933 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
12934 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
12935 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
12936 (gnutls_global_initialized, Qgnutls_bootprop_priority)
12937 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
12938 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
12939 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
12940 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
12941 (Qgnutls_bootprop_callbacks_verify): Make static.
12942
e7a6747f
AS
129432011-05-01 Andreas Schwab <schwab@linux-m68k.org>
12944
19ed11ba
AS
12945 * callproc.c: Indentation fixup.
12946
e7a6747f 12947 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
12948 (wait_for_termination, interruptible_wait_for_termination):
12949 Move after wait_for_termination_1.
e7a6747f 12950
1ef14cb4
LMI
129512011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
12952
12953 * sysdep.c (interruptible_wait_for_termination): New function
12954 which is like wait_for_termination, but allows keyboard
12955 interruptions.
12956
12957 * callproc.c (Fcall_process): Add (:file "file") as an option for
12958 the STDOUT buffer.
12959 (Fcall_process_region): Ditto.
12960
330d880c
EZ
129612011-04-30 Eli Zaretskii <eliz@gnu.org>
12962
8db90b73
EZ
12963 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
12964 rather than `XVECTOR (FOO)->size'.
12965
330d880c
EZ
12966 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
12967 inttypes.h, as a gnulib replacement is used if it not available in
12968 system headers.
12969
15cbd324
EZ
129702011-04-21 Eli Zaretskii <eliz@gnu.org>
12971
12972 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
12973 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
12974 of MOST_POSITIVE_FIXNUM. (Bug#8528)
12975
12976 * coding.c (coding_alloc_by_realloc): Error out if destination
12977 will grow beyond MOST_POSITIVE_FIXNUM.
12978 (decode_coding_emacs_mule): Abort if there isn't enough place in
12979 charbuf for the composition carryover bytes. Reserve an extra
12980 space for up to 2 characters produced in a loop.
12981 (decode_coding_iso_2022): Abort if there isn't enough place in
12982 charbuf for the composition carryover bytes.
12983
129842011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 12985
ae940cca
EZ
12986 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
12987 aborting when %lld or %lll format is passed.
12988 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
12989 %llo or %llx format is passed. (Bug#8545)
12990
03ab8921
EZ
12991 * window.c (window_scroll_line_based): Use a marker instead of
12992 simple variables to record original value of point. (Bug#7952)
12993
afda1437
EZ
12994 * doprnt.c (doprnt): Fix the case where a multibyte sequence
12995 produced by %s or %c overflows available buffer space. (Bug#8545)
12996
f76dee0c
PE
129972011-04-28 Paul Eggert <eggert@cs.ucla.edu>
12998
12999 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 13000 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 13001
fdc5744d
JB
130022011-04-28 Juanma Barranquero <lekktu@gmail.com>
13003
13004 * w32.c (init_environment): Warn about defaulting HOME to C:\.
13005
638f053a
JB
130062011-04-28 Juanma Barranquero <lekktu@gmail.com>
13007
13008 * keyboard.c (Qdelayed_warnings_hook): Define.
13009 (command_loop_1): Run `delayed-warnings-hook'
13010 if Vdelayed_warnings_list is non-nil.
13011 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
13012 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
13013
d178f871
EZ
130142011-04-28 Eli Zaretskii <eliz@gnu.org>
13015
13016 * doprnt.c (doprnt): Don't return value smaller than the buffer
13017 size if the message was truncated. (Bug#8545).
13018
b124fd93
JB
130192011-04-28 Juanma Barranquero <lekktu@gmail.com>
13020
13021 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
13022 (Fx_window_property): #if-0 the whole functions, not just the bodies.
13023
e810457d
PE
130242011-04-27 Paul Eggert <eggert@cs.ucla.edu>
13025
13026 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
13027
ea51cceb
JB
130282011-04-27 Juanma Barranquero <lekktu@gmail.com>
13029
13030 * makefile.w32-in: Update dependencies.
13031
94dcfacf
EZ
130322011-04-27 Eli Zaretskii <eliz@gnu.org>
13033
13034 Improve `doprnt' and its usage. (Bug#8545)
13035 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
13036 `format_end'. Remove support for %l as a conversion specifier.
13037 Don't use xrealloc. Improve diagnostics when the %l size modifier
13038 is used. Update the commentary.
13039
13040 * eval.c (verror): Simplify calculation of size_t.
13041
13042 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
13043 messages.
13044
f61f41d7
PE
130452011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
13046
13047 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
13048 change.
13049
96fb4434
PE
130502011-04-27 Paul Eggert <eggert@cs.ucla.edu>
13051
13052 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
13053 This makes this file independent of the recent pseudovector change.
13054
671875da 130552011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 13056
69e9b5a3
PE
13057 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
13058
b5f869a7 13059 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 13060 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 13061 Remove unused local.
c8926152 13062 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 13063
841a1577 13064 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
13065 GCC 4.6.0 optimizes based on type-based alias analysis.
13066 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
13067 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
13068 != &v->size, and therefore "v->size = 1; b->size = 2; return
13069 v->size;" must therefore return 1. This assumption is incorrect
13070 for Emacs, since it type-puns struct Lisp_Vector * with many other
13071 types. To fix this problem, this patch adds a new type struct
f904488f 13072 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
13073 and pseudovectors, and helps optimizing compilers not get fooled
13074 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
13075 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
13076 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
13077 the size member.
eab3844f
PE
13078 (XSETPVECTYPE): Rewrite in terms of new macro.
13079 (XSETPVECTYPESIZE): New macro, specifying both type and size.
13080 This is a bit clearer, and further avoids the possibility of
13081 undesirable aliasing.
13082 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 13083 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
13084 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
13085 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
13086 (ASIZE): Now uses header.size rather than size.
13087 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
13088 to avoid the hassle of writing XVECTOR (foo)->header.size.
13089 (struct vectorlike_header): New type.
eab3844f
PE
13090 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
13091 object, to help avoid aliasing.
13092 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
13093 (SUBRP): Likewise, since Lisp_Subr is a special case.
13094 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
13095 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
13096 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 13097 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
13098 changed to be "header.size" and "header.next".
13099 * buffer.h (struct buffer): Likewise.
13100 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
13101 * frame.h (struct frame): Likewise.
13102 * process.h (struct Lisp_Process): Likewise.
13103 * termhooks.h (struct terminal): Likewise.
13104 * window.c (struct save_window_data, struct saved_window): Likewise.
13105 * window.h (struct window): Likewise.
13106 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
13107 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
13108 * buffer.c (init_buffer_once): Likewise.
13109 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
13110 special case.
13111 * process.c (Fformat_network_address): Use local var for size,
13112 for brevity.
13113
0df1eac5
PE
13114 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
13115
847ab9d1 13116 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
13117 * data.c (atof): Remove decl; no longer used or needed.
13118 (digit_to_number): Move to lread.c.
13119 (Fstring_to_number): Use new string_to_number function, to be
13120 consistent with how the Lisp reader treats infinities and NaNs.
13121 Do not assume that floating-point numbers represent EMACS_INT
13122 without losing information; this is not true on most 64-bit hosts.
13123 Avoid double-rounding errors, by insisting on integers when
13124 parsing non-base-10 numbers, as the documentation specifies.
13125 * lisp.h (string_to_number): New decl, replacing ...
13126 (isfloat_string): Remove.
bc0a5c13 13127 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 13128 (read1): Do not accept +. and -. as integers; this
452f4150
PE
13129 appears to have been a coding error. Similarly, do not accept
13130 strings like +-1e0 as floating point numbers. Do not report
13131 overflow for integer overflows unless the base is not 10 which
13132 means we have no simple and reliable way to continue.
13133 Break out the floating-point parsing into a new
13134 function string_to_number, so that Fstring_to_number parses
13135 floating point numbers consistently with the Lisp reader.
04f2d78b 13136 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
13137 (E_CHAR, EXP_INT): Remove, replacing with ...
13138 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
13139 (string_to_number): New function, replacing isfloat_string.
13140 This function checks for valid syntax and produces the resulting
13141 Lisp float number too. Rework it so that string-to-number
bc0a5c13 13142 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
13143 so that overflow for non-base-10 numbers is reported only when
13144 there's no portable and simple way to convert to floating point.
452f4150 13145
67769ffc
PE
13146 * textprop.c (set_text_properties_1): Rewrite for clarity,
13147 and to avoid GCC warning about integer overflow.
13148
c20db43f
PE
13149 * intervals.h (struct interval): Use EMACS_INT for members
13150 where EMACS_UINT might cause problems. See
13151 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
13152 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
13153 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
13154 All uses changed.
37aa2f85
PE
13155 (offset_intervals): Tell GCC not to worry about length overflow
13156 when negating a negative length.
c20db43f 13157
2538aa2f
PE
13158 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
13159 (overrun_check_free): Likewise.
13160
f2d3008d
PE
13161 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
13162 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
13163 word size.
13164
ec8df744
PE
13165 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
13166 (gnutls_make_error): Rename local to avoid shadowing.
13167 (gnutls_emacs_global_deinit): ifdef out; not used.
13168 (Fgnutls_boot): Use const for pointer to readonly storage.
13169 Comment out unused local. Fix pointer signedness problems.
13170
640ee02d
PE
13171 * lread.c (openp): Don't stuff size_t into an 'int'.
13172 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
13173 about possible signed overflow.
13174
6048fb2a
PE
13175 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
13176 (GDK_KEY_g): Don't define if already defined.
13177 (xg_prepare_tooltip): Avoid pointer signedness problem.
13178 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
13179
fa3c87e1
PE
13180 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
13181 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
13182
2172544b
PE
13183 * xfns.c (Fx_window_property): Simplify a bit,
13184 to make a bit faster and to avoid GCC 4.6.0 warning.
13185 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
13186
9b821a21
PE
13187 * fns.c (internal_equal): Don't assume size_t fits in int.
13188
3c616cfa
PE
13189 * alloc.c (compact_small_strings): Tighten assertion a little.
13190
c2982e87
PE
13191 Replace pEd with more-general pI, and fix some printf arg casts.
13192 * lisp.h (pI): New macro, generalizing old pEd macro to other
13193 conversion specifiers. For example, use "...%"pI"d..." rather
13194 than "...%"pEd"...".
13195 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 13196 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
13197 * alloc.c (check_pure_size): Don't overflow by converting size to int.
13198 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
13199 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
13200 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
13201 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
13202 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
13203 64-bit hosts.
13204 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
13205 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
13206 * print.c (safe_debug_print, print_object): Likewise.
13207 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
13208 to int.
6f04d126
PE
13209 Use pI instead of if-then-else-abort. Use %p to avoid casts,
13210 avoiding the 0 flag, which is not portable.
c2982e87
PE
13211 * process.c (Fmake_network_process): Use pI to avoid cast.
13212 * region-cache.c (pp_cache): Likewise.
13213 * xdisp.c (decode_mode_spec): Likewise.
13214 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
13215 behavior on 64-bit hosts with printf arg.
6f04d126 13216 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
13217 (x_stop_queuing_selection_requests): Likewise.
13218 (x_get_window_property): Don't truncate byte count to an 'int'
13219 when tracing.
0b432f21 13220
5e073ec7
PE
13221 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
13222 here, since it parses constructs like leading '-' and spaces,
13223 which are not wanted; and it overflows with large numbers.
13224 Instead, simply match F[0-9]+, which is what is wanted anyway.
13225
36372bf9
PE
13226 * alloc.c: Remove unportable assumptions about struct layout.
13227 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
13228 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
13229 (allocate_vectorlike, make_pure_vector): Use the new macros,
13230 plus offsetof, to remove unportable assumptions about struct layout.
13231 These assumptions hold on all porting targets that I know of, but
13232 they are not guaranteed, they're easy to remove, and removing them
13233 makes further changes easier.
13234
0b432f21
PE
13235 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
13236 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
13237 (string_overrun_cookie): Now const. Use initializers that
13238 don't formally overflow signed char, to avoid warnings.
000098c1
PE
13239 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
13240 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
13241 (allocate_buffer): Don't assume sizeof (struct buffer) is a
13242 multiple of sizeof (EMACS_INT); it need not be, if
13243 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 13244 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 13245
895009e1
JB
132462011-04-26 Juanma Barranquero <lekktu@gmail.com>
13247
13248 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
13249
6a7a1b0b
TZ
132502011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
13251
13252 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 13253 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
13254 Reported by Paul Eggert <eggert@cs.ucla.edu>.
13255
841a1577 132562011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
13257
13258 * lisp.h (Qdebug): List symbol.
895009e1 13259 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
13260 * keyboard.c (debug-on-event): New variable.
13261 (handle_user_signal): Break into debugger when debug-on-event
13262 matches the current signal symbol.
13263
f2d3ba6f
DN
132642011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
13265
13266 * alloc.c (check_sblock, check_string_bytes)
13267 (check_string_free_list): Convert to standard C.
13268
42ce4c63
TZ
132692011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
13270
13271 * w32.c (emacs_gnutls_push): Fix typo.
13272
825cd63c
EZ
132732011-04-25 Eli Zaretskii <eliz@gnu.org>
13274
fb11d64d
EZ
13275 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
13276 "cast to pointer from integer of different size".
13277
825cd63c
EZ
13278 Improve doprnt and its use in verror. (Bug#8545)
13279 * doprnt.c (doprnt): Document the set of format control sequences
13280 supported by the function. Use SAFE_ALLOCA instead of always
13281 using `alloca'.
13282
13283 * eval.c (verror): Don't limit the buffer size at size_max-1, that
13284 is one byte too soon. Don't use xrealloc; instead xfree and
13285 xmalloc anew.
13286
e061a11b
TZ
132872011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
13288
13289 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
13290 callbacks stage.
13291
13292 * gnutls.c: Renamed global_initialized to
13293 gnutls_global_initialized. Added internals for the
13294 :verify-hostname-error, :verify-error, and :verify-flags
13295 parameters of `gnutls-boot' and documented those parameters in the
13296 docstring. Start callback support.
9173deec
JB
13297 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
13298 unless a fatal error occurred. Call gnutls_alert_send_appropriate
13299 on error. Return error code.
e061a11b
TZ
13300 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
13301 (emacs_gnutls_read): Likewise.
13302 (Fgnutls_boot): Return handshake error code.
13303 (emacs_gnutls_handle_error): New function.
13304 (wsaerror_to_errno): Likewise.
13305
13306 * w32.h (emacs_gnutls_pull): Add prototype.
13307 (emacs_gnutls_push): Likewise.
13308
13309 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
13310 (emacs_gnutls_push): Likewise.
13311
133122011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
13313
13314 * process.c (wait_reading_process_output): Check if GnuTLS
13315 buffered some data internally if no FDs are set for TLS
13316 connections.
13317
13318 * makefile.w32-in (OBJ2): Add gnutls.$(O).
13319 (LIBS): Link to USER_LIBS.
13320 ($(BLD)/gnutls.$(0)): New target.
13321
fa6996bc
EZ
133222011-04-24 Eli Zaretskii <eliz@gnu.org>
13323
eb35682e
EZ
13324 * xdisp.c (handle_single_display_spec): Rename the
13325 display_replaced_before_p argument into display_replaced_p, to
13326 make it consistent with the commentary. Fix typos in the
13327 commentary.
13328
e2ad650c
EZ
13329 * textprop.c (syms_of_textprop): Remove dead code.
13330 (copy_text_properties): Delete obsolete commentary about an
13331 interface that was deleted long ago. Fix typos in the description
13332 of arguments.
13333
1b2de274
EZ
13334 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
13335 to changes in oldXMenu/XMenu.h from 2011-04-16.
13336 <menu_help_message, prev_menu_help_message>: Constify.
13337 (IT_menu_make_room): menu->help_text is now `const char **';
13338 adjust.
13339
13340 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
13341 to changes in oldXMenu/XMenu.h from 2011-04-16.
13342 (struct XMenu): Declare `help_text' `const char **'.
13343
13344 * xfaces.c <Qunspecified>: Make extern again.
13345
13346 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 13347 required by POSIX.
1b2de274 13348
762b15be
EZ
13349 * doc.c (get_doc_string): Improve the format passed to `error'.
13350
13351 * doprnt.c (doprnt): Improve commentary.
13352
13353 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
13354
13355 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
13356 them with etags.
13357
f1052e5d
EZ
13358 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
13359 changes in globals.h immediately force recompilation.
762b15be
EZ
13360 (TAGS): Depend on $(CURDIR)/m/intel386.h and
13361 $(CURDIR)/s/ms-w32.h.
13362 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 13363
fa6996bc
EZ
13364 * character.c (Fchar_direction): Function deleted.
13365 (syms_of_character): Don't defsubr it.
13366 <char-direction-table>: Deleted.
13367
e6c3da20
EZ
133682011-04-23 Eli Zaretskii <eliz@gnu.org>
13369
13370 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
13371 * doprnt.c: Include limits.h.
13372 (SIZE_MAX): New macro.
04f2d78b
CB
13373 (doprnt): Return a size_t value. 2nd arg is now size_t.
13374 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
13375 Improve overflow protection. Support `l' modifier for integer
13376 conversions. Support %l conversion. Don't assume an EMACS_INT
13377 argument for integer conversions and for %c.
13378
13379 * lisp.h (doprnt): Restore prototype.
13380
13381 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
13382 $(SRC)/character.h.
13383
13384 * Makefile.in (base_obj): Add back doprnt.o.
13385
13386 * deps.mk (doprnt.o): Add back prerequisites.
13387 (callint.o): Depend on character.h.
13388
13389 * eval.c (internal_lisp_condition_case): Include the handler
13390 representation in the error message.
13391 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
13392 when breaking from the loop.
13393
13394 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
13395
13396 * callint.c (Fcall_interactively): When displaying error message
13397 about invalid control letter, pass the character's codepoint, not
13398 a pointer to its multibyte form. Improve display of the character
13399 in octal and display also its hex code.
13400
13401 * character.c (char_string): Use %x to display the (unsigned)
13402 codepoint of an invalid character, to avoid displaying a bogus
13403 negative value.
13404
13405 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
13406 `error', not SYMBOL_NAME itself.
13407
13408 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
13409 character arguments to `error'.
13410
13411 * charset.c (check_iso_charset_parameter): Fix incorrect argument
13412 to `error' in error message about FINAL_CHAR argument. Make sure
13413 FINAL_CHAR is a character, and use %c when it is passed as
13414 argument to `error'.
13415
4ffd0d6b 134162011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
13417
13418 * s/ms-w32.h (localtime): Redirect to sys_localtime.
13419
13420 * w32.c: Include <time.h>.
13421 (sys_localtime): New function.
13422
4ffd0d6b 134232011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
13424
13425 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
13426
4ffd0d6b 13427 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 13428
4ffd0d6b 134292011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 13430
4ffd0d6b
GM
13431 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
13432 zombies (Bug#8467).
aac0c6e3 13433
04c56954
EZ
134342011-04-19 Eli Zaretskii <eliz@gnu.org>
13435
13436 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
13437 gl_state.e_property when gl_state.object is Qt.
13438
13439 * insdel.c (make_gap_larger): Remove limitation of buffer size
13440 to <= INT_MAX.
13441
16a43933
CY
134422011-04-18 Chong Yidong <cyd@stupidchicken.com>
13443
13444 * xdisp.c (lookup_glyphless_char_display)
13445 (produce_glyphless_glyph): Handle cons cell entry in
13446 glyphless-char-display.
13447 (Vglyphless_char_display): Document it.
13448
13449 * term.c (produce_glyphless_glyph): Handle cons cell entry in
13450 glyphless-char-display.
13451
4581706e
CY
134522011-04-17 Chong Yidong <cyd@stupidchicken.com>
13453
13454 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
13455
13456 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
13457
13458 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
13459 definition for no-X builds.
13460
4887c6e2 134612011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 13462
fd35b6f9
PE
13463 Static checks with GCC 4.6.0 and non-default toolkits.
13464
5c1ccb01
PE
13465 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
13466
006c5daa
PE
13467 * process.c (keyboard_bit_set): Define only if SIGIO.
13468 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
13469 (send_process): Repair possible setjmp clobbering.
13470
efc736d3
PE
13471 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
13472
4e2fe2e6
PE
13473 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
13474
f97334a2
PE
13475 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
13476
4e75f29d
PE
13477 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
13478 Define only if needed.
13479
90efadd1
PE
13480 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
13481 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 13482 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 13483
3c647824
PE
13484 * dispextern.h (struct redisplay_interface): Rename param
13485 to avoid shadowing.
e264f262 13486 * termhooks.h (struct terminal): Likewise.
761383f4 13487 * xterm.c (xembed_send_message): Likewise.
3c647824 13488
b58c5c4a
PE
13489 * insdel.c (make_gap_smaller): Define only if
13490 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
13491
cad59032
PE
13492 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
13493 it.
13494
c339dc2e
PE
13495 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
13496 so that we aren't warned about unused symbols.
13497
91a3e27b
PE
13498 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
13499
399c71d3 13500 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 13501
8ffc96f5
PE
13502 * xfns.c (x_real_positions): Mark locals as initialized.
13503
eef9bc79
PE
13504 * xmenu.c (xmenu_show): Don't use uninitialized vars.
13505
098db9dd
PE
13506 * xterm.c: Fix problems found by static analysis with other toolkits.
13507 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
13508 (x_dispatch_event): Declare static if USE_GTK, and
13509 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 13510 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 13511 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
13512 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
13513 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 13514
eb18f6cc
PE
13515 * xmenu.c (menu_help_callback): Pointer type fixes.
13516 Use const pointers when pointing at readonly data. Avoid pointer
13517 signedness clashes.
13518 (FALSE): Remove unused macro.
13519 (update_frame_menubar): Remove unused decl.
13520
1fe72bf8
PE
13521 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
13522
60d9e1db
PE
13523 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
13524 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
13525 (single_menu_item): Rename local to avoid shadowing.
13526
39261c26
PE
13527 * keyboard.c (make_lispy_event): Remove unused local var.
13528
018c5e19
PE
13529 * frame.c, frame.h (x_get_resource_string): Bring this back, but
13530 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
13531
63d2b86e
PE
13532 * bitmaps: Change bitmaps from unsigned char back to the X11
13533 compatible char. Avoid the old compiler warnings about
13534 out-of-range initializers by using, for example, '\xab' rather
13535 than 0xab.
13536
aefd87e1
PE
13537 * xgselect.c (xgselect_initialize): Check vs interface
13538 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
13539
bf501fb9
PE
13540 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
13541
e9829fdf
PE
13542 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
13543 to read-only memory.
13544
1086c095
PE
13545 * fns.c (vector): Remove; this old hack is no longer needed.
13546
2baccd04 13547 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 13548 Remove unused var.
dde42981 13549 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 13550
72391843 13551 * xrdb.c (x_load_resources): Omit unused local.
3565b346 13552
436c16df 13553 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 13554 (x_window): Rename locals to avoid shadowing.
dc5ddd85 13555 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 13556
92bb796d 13557 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 13558 (x_term_init): Remove local to avoid shadowing.
92bb796d 13559
764430a3 13560 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
13561
13562 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
13563 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
13564
d1dfb56c
EZ
135652011-04-16 Eli Zaretskii <eliz@gnu.org>
13566
c4354cb4
EZ
13567 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
13568
d1dfb56c
EZ
13569 Fix regex.c, syntax.c and friends for buffers > 2GB.
13570 * syntax.h (struct gl_state_s): Declare character position members
13571 EMACS_INT.
13572
13573 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
13574
04f2d78b
CB
13575 * textprop.c (verify_interval_modification, interval_of):
13576 Declare arguments EMACS_INT.
d1dfb56c
EZ
13577
13578 * intervals.c (adjust_intervals_for_insertion): Declare arguments
13579 EMACS_INT.
13580
13581 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
13582
13583 * indent.c (Fvertical_motion): Local variable it_start is now
13584 EMACS_INT.
13585
13586 * regex.c (re_match, re_match_2, re_match_2_internal)
13587 (bcmp_translate, regcomp, regexec, print_double_string)
13588 (group_in_compile_stack, re_search, re_search_2, regex_compile)
13589 (re_compile_pattern, re_exec): Declare arguments and local
13590 variables `size_t' and `ssize_t' and return values `regoff_t', as
13591 appropriate.
13592 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
13593 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
13594 <compile_stack_type>: `size' and `avail' are now `size_t'.
13595
13596 * regex.h <regoff_t>: Use ssize_t, not int.
13597 (re_search, re_search_2, re_match, re_match_2): Arguments that
13598 specify buffer/string position and length are now ssize_t and
13599 size_t. Return type is regoff_t.
13600
613052cd
BK
136012011-04-16 Ben Key <bkey76@gmail.com>
13602
13603 * nsfont.m: Fixed bugs in ns_get_family and
13604 ns_descriptor_to_entity that were caused by using free to
13605 deallocate memory blocks that were allocated by xmalloc (via
13606 xstrdup). This caused Emacs to crash when compiled with
13607 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
13608 --enable-checking=xmallocoverrun). xfree is now used to
13609 deallocate these memory blocks.
13610
4170f62f 136112011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 13612
71b41406
PE
13613 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
13614
9587a89d
PE
13615 emacs_write: Accept and return EMACS_INT for sizes.
13616 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
13617 et seq.
13618 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
13619 Accept and return EMACS_INT.
13620 (emacs_gnutls_write): Return the number of bytes written on
13621 partial writes.
13622 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
13623 (emacs_read, emacs_write): Remove check for negative size, as the
13624 Emacs source code has been audited now.
9587a89d
PE
13625 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
13626 (emacs_read, emacs_write): Use it.
273a5f82
PE
13627 * process.c (send_process): Adjust to the new signatures of
13628 emacs_write and emacs_gnutls_write. Do not attempt to store
13629 a byte offset into an 'int'; it might overflow.
9587a89d 13630 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 13631
3e047f51
PE
13632 * sound.c: Don't assume sizes fit in 'int'.
13633 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 13634 Return EMACS_INT, not int.
3e047f51 13635 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
13636 Accept EMACS_INT, not int.
13637 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
13638 record read return values.
13639
cc39a9db
BK
136402011-04-15 Ben Key <bkey76@gmail.com>
13641
c9d0ec6d
JB
13642 * keyboard.c (Qundefined): Don't declare static since it is used
13643 in nsfns.m.
13644 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
13645 static since they are used in nsfont.m.
cc39a9db 13646
6c60eb9f
SM
136472011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
13648
13649 * process.c (Qprocessp): Don't declare static.
13650 * lisp.h (Qprocessp): Declare again.
13651
7990b61a
JB
136522011-04-15 Juanma Barranquero <lekktu@gmail.com>
13653
13654 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
13655
5d4cb038
PE
136562011-04-14 Paul Eggert <eggert@cs.ucla.edu>
13657
8bd7b830 13658 Improve C-level modularity by making more things 'static'.
cd64ea1d 13659
e3b27b31
PE
13660 Don't publish debugger-only interfaces to other modules.
13661 * lisp.h (safe_debug_print, debug_output_compilation_hack):
13662 (verify_bytepos, count_markers): Move decls to the only modules
13663 that need them.
13664 * region-cache.h (pp_cache): Likewise.
13665 * window.h (check_all_windows): Likewise.
13666 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
13667
5d4cb038
PE
13668 * sysdep.c (croak): Now static, if
13669 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
13670 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
13671
13672 * alloc.c (refill_memory_reserve): Now static if
13673 !defined REL_ALLOC || defined SYSTEM_MALLOC.
13674 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 13675
e87b6180
PE
13676 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
13677 Define only if USE_LUCID.
13678
ac64929e
PE
13679 * xrdb.c (x_customization_string, x_rm_string): Now static.
13680
6f37259d
PE
13681 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
13682 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
13683
1683e3ab
PE
13684 * xdisp.c (draw_row_with_mouse_face): Now static.
13685 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
13686
de9c2632
PE
13687 * window.h (check_all_windows): Mark externally visible.
13688
2b96acb7
PE
13689 * window.c (window_deletion_count): Now static.
13690
13691 * undo.c: Make symbols static if they're not exported.
13692 (last_undo_buffer, last_boundary_position, pending_boundary):
13693 Now static.
13694
50436f33
PE
13695 * textprop.c (interval_insert_behind_hooks): Now static.
13696 (interval_insert_in_front_hooks): Likewise.
13697
64520e5c
PE
13698 * term.c: Make symbols static if they're not exported.
13699 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
13700 (max_frame_lines, tty_set_terminal_modes):
13701 (tty_reset_terminal_modes, tty_turn_off_highlight):
13702 (get_tty_terminal): Now static.
13703 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
13704 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 13705 HAVE_WINDOW_SYSTEM.
64520e5c
PE
13706 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
13707 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
13708
1fa53021
PE
13709 * sysdep.c: Make symbols static if they're not exported.
13710 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
13711 Now static.
13712 (sigprocmask_set, full_mask): Remove; unused.
13713 (wait_debugging): Mark as visible.
13714 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
13715 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
13716
d4b43b22
PE
13717 * syntax.c (syntax_temp): Define only if !__GNUC__.
13718
b7c513d0
PE
13719 * sound.c (current_sound_device, current_sound): Now static.
13720
989b29ad
PE
13721 * search.c (searchbufs, searchbuf_head): Now static.
13722
13a55a78
PE
13723 * scroll.c (scroll_cost): Remove; unused.
13724 * dispextern.h (scroll_cost): Remove decl.
13725
de68a1fc
PE
13726 * region-cache.h (pp_cache): Mark as externally visible.
13727
40ccffa6
PE
13728 * process.c: Make symbols static if they're not exported.
13729 (process_tick, update_tick, create_process, chan_process):
13730 (Vprocess_alist, proc_buffered_char, datagram_access):
13731 (fd_callback_data, send_process_frame, process_sent_to): Now static.
13732 (deactivate_process): Mark defn as static, as well as decl.
13733 * lisp.h (create_process): Remove decl.
13734 * process.h (chan_process, Vprocess_alist): Remove decls.
13735
ad64fc97
PE
13736 * print.c: Make symbols static if they're not exported.
13737 (print_depth, new_backquote_output, being_printed, print_buffer):
13738 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
13739 (print_interval, print_number_index, initial_stderr_stream):
13740 Now static.
13741 * lisp.h (Fprinc): Remove decl.
13742 (debug_output_compilation_hack): Mark as externally visible.
13743
adddb265
PE
13744 * sysdep.c (croak): Move decl from here to syssignal.h.
13745 * syssignal.h (croak): Put it here, so the API can be checked when
13746 'croak' is called from dissociate_if_controlling_tty.
13747
1717ede2
PE
13748 * minibuf.c: Make symbols static if they're not exported.
13749 (minibuf_save_list, choose_minibuf_frame): Now static.
13750 * lisp.h (choose_minibuf_frame): Remove decl.
13751
fa5fb2bc
PE
13752 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
13753
1e3890d1
PE
13754 * lread.c: Make symbols static if they're not exported.
13755 (read_objects, initial_obarray, oblookup_last_bucket_number):
13756 Now static.
13757 (make_symbol): Remove; unused.
13758 * lisp.h (initial_obarray, make_symbol): Remove decls.
13759
8a1414fa
PE
13760 * keyboard.c: Make symbols static if they're not exported.
13761 (single_kboard, recent_keys_index, total_keys, recent_keys):
13762 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
13763 (this_single_command_key_start, echoing, last_auto_save):
13764 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
13765 (command_loop, echo_now, keyboard_init_hook, help_char_p):
13766 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
13767 (Vlispy_mouse_stem, double_click_count):
13768 Now static.
13769 (force_auto_save_soon): Define only if SIGDANGER.
13770 (ignore_mouse_drag_p): Now static if
13771 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
13772 (print_help): Remove; unused.
13773 (stop_character, last_timer_event): Mark as externally visible.
13774 * keyboard.h (ignore_mouse_drag_p): Declare only if
13775 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
13776 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
13777 * lisp.h (echoing): Remove decl.
13778 (force_auto_save_soon): Declare only if SIGDANGER.
13779 * xdisp.c (redisplay_window): Simplify code, to make it more
13780 obvious that ignore_mouse_drag_p is not accessed if !defined
13781 USE_GTK && !defined HAVE_NS.
13782
93ea6e8f
PE
13783 * intervals.c: Make symbols static if they're not exported.
13784 (merge_properties_sticky, merge_interval_right, delete_interval):
13785 Now static.
13786 * intervals.h (merge_interval_right, delete_interval): Remove decls.
13787
77382fcc
PE
13788 * insdel.c: Make symbols static if they're not exported.
13789 However, leave prepare_to_modify_buffer alone. It's never
13790 called from outside this function, but that appears to be a bug.
13791 (combine_after_change_list, combine_after_change_buffer):
4889fc82 13792 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
13793 (adjust_after_replace_noundo): Remove; unused.
13794 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 13795 (signal_before_change): Remove decls.
77382fcc 13796
9306c32e
PE
13797 * indent.c (val_compute_motion, val_vmotion): Now static.
13798
cd44d2eb
PE
13799 * image.c: Make symbols static if they're not exported.
13800 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
13801 if USE_GTK.
13802 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
13803 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
13804
ad9a7a06
PE
13805 * fringe.c (standard_bitmaps): Now static.
13806 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
13807
81626931
PE
13808 * frame.c: Make symbols static if they're not exported.
13809 (x_report_frame_params, make_terminal_frame): Now static.
13810 (get_frame_param): Now static, unless HAVE_NS.
13811 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
13812 (x_get_resource_string): Remove; not used.
13813 * frame.h (make_terminal_frame, x_report_frame_params):
13814 (x_get_resource_string); Remove decls.
13815 (x_fullscreen_adjust): Declare only if WINDOWSNT.
13816 * lisp.h (get_frame_param): Declare only if HAVE_NS.
13817
239f9db9
PE
13818 * font.c, fontset.c: Make symbols static if they're not exported.
13819 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
13820 (FACE_SUITABLE_FOR_CHAR_P): Use it.
13821 * font.c (font_close_object): Now static.
13822 * font.h (font_close_object): Remove.
13823 * fontset.c (FONTSET_OBJLIST): Remove.
13824 (free_realized_fontset) #if-0 the body, which does nothing.
13825 (face_suitable_for_char_p): #if-0, as it's never called.
13826 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
13827 * xfaces.c (face_at_string_position):
13828 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
13829 since 0 is always ASCII.
13830
dfcf3579
PE
13831 * fns.c (weak_hash_tables): Now static.
13832
5045092b
PE
13833 * fileio.c: Make symbols static if they're not exported.
13834 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
13835 (Vwrite_region_annotation_buffers): Now static.
13836
57a96f5c
PE
13837 * eval.c: Make symbols static if they're not exported.
13838 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
13839 * lisp.h (backtrace_list): Remove decl.
13840
35f08c38
PE
13841 * emacs.c: Make symbols static if they're not exported.
13842 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
13843 (fatal_error_code, fatal_error_signal_hook, standard_args):
13844 Now static.
13845 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
13846 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
13847 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
13848 * lisp.h (fatal_error_signal_hook): Remove decl.
13849 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
13850
f44bd759
PE
13851 * editfns.c: Move a (normally-unused) function to its only use.
13852 * editfns.c, lisp.h (get_operating_system_release): Remove.
13853 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
13854 worth the hassle of breaking this out.
13855
b532497d
PE
13856 * xterm.c: Make symbols static if they're not exported.
13857 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
13858 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
13859 (x_destroy_window, x_delete_display):
13860 Now static.
13861 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
13862 (x_mouse_leave): Remove; unused.
13863 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
13864 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
13865 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
13866 Remove decls.
13867 (x_mouse_leave): Declare only if WINDOWSNT.
13868 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
13869 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
13870 USE_X_TOOLKIT.
13871
1675728f
PE
13872 * ftxfont.c: Make symbols static if they're not exported.
13873 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
13874 HAVE_FREETYPE.
13875 * font.h (ftxfont_driver): Likewise.
13876
e4cebfca
PE
13877 * xfns.c: Make symbols static if they're not exported.
13878 (x_last_font_name, x_display_info_for_name):
13879 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
13880 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
13881 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
13882 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
13883 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
13884 (last_show_tip_args): Now static.
13885 (xic_defaut_fontset, xic_create_fontsetname): Define only if
13886 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
13887 (x_screen_planes): Remove; unused.
13888 * dispextern.h (x_screen_planes): Remove decl.
13889
5bf46f05
PE
13890 * dispnew.c: Make symbols static if they're not exported.
13891 * dispextern.h (redraw_garbaged_frames, scrolling):
13892 (increment_row_positions): Remove.
13893 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
13894 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
13895 Now static.
13896 (redraw_garbaged_frames): Remove; unused.
13897
435f4c28
PE
13898 * xfaces.c: Make symbols static if they're not exported.
13899 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
13900 Remove decls.
13901 * xterm.h (defined_color): Remove decls.
13902 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
13903 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
13904 (menu_face_changed_default, defined_color, free_realized_face):
13905 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
13906 (ascii_face_of_lisp_face): Remove; unused.
13907
8524aef3
PE
13908 * xdisp.c: Make symbols static if they're not exported.
13909 * dispextern.h (scratch_glyph_row, window_box_edges):
13910 (glyph_to_pixel_coords, set_cursor_from_row):
13911 (get_next_display_element, set_iterator_to_next):
13912 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
13913 (show_mouse_face): Remove decls
13914 * frame.h (message_buf_print): Likewise.
13915 * lisp.h (pop_message, set_message, check_point_in_composition):
13916 Likewise.
13917 * xterm.h (set_vertical_scroll_bar): Likewise.
13918 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
13919 (message_buf_print, scratch_glyph_row, displayed_buffer):
13920 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
13921 (get_next_display_element, show_mouse_face, window_box_edges):
13922 (frame_to_window_pixel_xy, check_point_in_composition):
13923 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
13924 (glyph_to_pixel_coords): Remove; unused.
13925
16390cd2
PE
13926 * dired.c (file_name_completion): Now static.
13927
13928 * dbusbind.c (xd_in_read_queued_messages): Now static.
13929
a25f4dfa
PE
13930 * lisp.h (circular_list_error, FOREACH): Remove; unused.
13931 * data.c (circular_list_error): Remove.
13932
14a9c8df
PE
13933 * commands.h (last_point_position, last_point_position_buffer):
13934 (last_point_position_window): Remove decls.
13935 * keyboard.c: Make these variables static.
13936
04f2d78b
CB
13937 * coding.h (coding, code_convert_region, encode_coding_gap):
13938 Remove decls.
74ab6df5
PE
13939 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
13940 (iso_code_class, detect_coding, code_convert_region): Now static.
13941 (encode_coding_gap): Remove; unused.
13942
38dfbee1
PE
13943 * chartab.c (chartab_chars, chartab_bits): Now static.
13944
a2cb4e63
PE
13945 * charset.h (charset_iso_8859_1): Remove decl.
13946 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
13947 Now static.
13948
127198fd
PE
13949 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
13950 * ccl.c (Vccl_program_table): Now static.
13951 (check_ccl_update): Remove; unused.
13952
d85b608f
PE
13953 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
13954 * category.h: ... from here.
13955 * category.c (check_category_table, set_category_set): Now static.
13956
31cd66f3
PE
13957 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
13958 * lisp.h: Remove these decls.
13959
c358e587
PE
13960 * buffer.c (buffer_count): Remove unused var.
13961
e78aecca
PE
13962 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
13963 so that it's not optimized away.
13964 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
13965 * dispextern.h (bidi_dump_cached_states): Remove, since it's
13966 exported only to the debugger.
13967
e192d7d3 13968 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 13969 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 13970
92470028
PE
13971 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
13972 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
13973 was inaccessible from Lisp.
13974 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
13975 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
13976
244ed907
PE
13977 alloc.c: Import and export fewer symbols, and remove unused items.
13978 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
13979 is defined.
13980 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
13981 it's not optimized away by whole-program optimization.
13982 (message_enable_multibyte, free_misc): Remove.
13983 (catchlist, handlerlist, mark_backtrace):
13984 Declare only if BYTE_MARK_STACK.
13985 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
13986 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
13987 (message_enable_multibyte): Remove decl.
13988 (free_misc, interval_free_list, float_block, float_block_index):
13989 (n_float_blocks, float_free_list, cons_block, cons_block_index):
13990 (cons_free_list, last_marked_index):
13991 Now static.
13992 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
13993 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
13994 (mark_backtrace): Define only if BYTE_MARK_STACK.
13995 * xdisp.c (message_enable_multibyte): Now static.
13996
61c2b50e 13997 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
13998 This makes it easier for human readers (and static analyzers)
13999 to see whether these variables are used from other modules.
14000 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
14001 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
14002 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
14003 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
14004 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
14005 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
14006 * xmenu.c, xselect.c:
14007 Declare Q* vars static if they are not used in other modules.
14008 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
14009 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
14010 Remove decls of unexported vars.
14011 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
14012
95c82688
PE
14013 * lisp.h (DEFINE_FUNC): Make sname 'static'.
14014
16a97296
PE
14015 Make Emacs functions such as Fatom 'static' by default.
14016 This makes it easier for human readers (and static analyzers)
14017 to see whether these functions can be called from other modules.
14018 DEFUN now defines a static function. To make the function external
14019 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
14020 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
14021 (Finit_image_library):
16a97296
PE
14022 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
14023 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
14024 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
14025 Remove decls, since these functions are now static.
14026 (Funintern, Fget_internal_run_time): New decls, since these functions
14027 were already external.
95c82688 14028
16a97296
PE
14029 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
14030 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
14031 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
14032 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
14033 * keyboard.c, keymap.c, lread.c:
14034 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
14035 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
14036 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
14037 Mark functions with DEFUE instead of DEFUN,
14038 if they are used in other modules.
14039 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
14040 decls for now-static functions.
14041 * buffer.h (Fdelete_overlay): Remove decl.
14042 * callproc.c (Fgetenv_internal): Mark as internal.
14043 * composite.c (Fremove_list_of_text_properties): Remove decl.
14044 (Fcomposition_get_gstring): New forward static decl.
14045 * composite.h (Fcomposite_get_gstring): Remove decl.
14046 * dired.c (Ffile_attributes): New forward static decl.
14047 * doc.c (Fdocumntation_property): New forward static decl.
14048 * eval.c (Ffetch_bytecode): New forward static decl.
14049 (Funintern): Remove extern decl; now in .h file where it belongs.
14050 * fileio.c (Fmake_symbolic_link): New forward static decl.
14051 * image.c (Finit_image_library): New forward static decl.
14052 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
14053 * intervals.h (Fprevious_property_change):
14054 (Fremove_list_of_text_properties): Remove decls.
14055 * keyboard.c (Fthis_command_keys): Remove decl.
14056 (Fcommand_execute): New forward static decl.
14057 * keymap.c (Flookup_key): New forward static decl.
14058 (Fcopy_keymap): Now static.
14059 * keymap.h (Flookup_key): Remove decl.
14060 * process.c (Fget_process): New forward static decl.
14061 (Fprocess_datagram_address): Mark as internal.
14062 * syntax.c (Fsyntax_table_p): New forward static decl.
14063 (skip_chars): Remove duplicate decl.
14064 * textprop.c (Fprevious_property_change): New forward static decl.
14065 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
14066 Now internal.
14067 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
14068 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
14069
785bbd42
PE
14070 * editfns.c (Fformat): Remove unreachable code.
14071
8b913b57
AS
140722011-04-14 Andreas Schwab <schwab@linux-m68k.org>
14073
14074 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
14075 change. (Bug#8496)
14076
a6744a35
EZ
140772011-04-13 Eli Zaretskii <eliz@gnu.org>
14078
14079 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
14080 when at ZV. (Bug#8487)
14081
e7974947
AS
140822011-04-12 Andreas Schwab <schwab@linux-m68k.org>
14083
baad03f0
AS
14084 * charset.c (Fclear_charset_maps): Use xfree instead of free.
14085 (Bug#8437)
14086 * keyboard.c (parse_tool_bar_item): Likewise.
14087 * sound.c (sound_cleanup, alsa_close): Likewise.
14088 * termcap.c (tgetent): Likewise.
14089 * xfns.c (x_default_font_parameter): Likewise.
14090 * xsettings.c (read_and_apply_settings): Likewise.
14091
e7974947
AS
14092 * alloc.c (overrun_check_malloc, overrun_check_realloc)
14093 (overrun_check_free): Protoize.
14094
28272684
PE
140952011-04-12 Paul Eggert <eggert@cs.ucla.edu>
14096
14097 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
14098 since callers should never pass a negative size.
14099 Change the signature to match that of plain 'read' and 'write'; see
14100 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
14101 * lisp.h: Update prototypes of emacs_write and emacs_read.
14102
11997c76
EZ
141032011-04-11 Eli Zaretskii <eliz@gnu.org>
14104
14105 * xdisp.c (redisplay_window): Don't try to determine the character
14106 position of the scroll margin if the window start point w->startp
e896f03c 14107 is outside the buffer's accessible region. (Bug#8468)
11997c76 14108
8a2cbd72
EZ
141092011-04-10 Eli Zaretskii <eliz@gnu.org>
14110
14111 Fix write-region and its subroutines for buffers > 2GB.
14112 * fileio.c (a_write, e_write): Modify declaration of arguments and
14113 local variables to support buffers larger than 2GB.
14114 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
14115
14116 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
14117 argument, local variables, and return value.
14118
14119 * lisp.h: Update prototypes of emacs_write and emacs_read.
14120
14121 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
14122
4073e537 141232011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 14124
1ebfdcb6
PE
14125 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
14126
b2ded58d
PE
14127 Fix more problems found by GCC 4.6.0's static checks.
14128
7d66342c
PE
14129 * xdisp.c (vmessage): Use a better test for character truncation.
14130
bbf47d44
PE
14131 * charset.c (load_charset_map): <, not <=, for optimization,
14132 and to avoid potential problems with integer overflow.
9248994d 14133 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 14134 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 14135 * editfns.c (Fformat): Likewise.
1e69125e 14136 * syntax.c (skip_chars): Likewise.
3befa583 14137
e3019616
PE
14138 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
14139 This also lets GCC 4.6.0 generate slightly better loop code.
14140
becfa255
PE
14141 * callint.c (Fcall_interactively): <, not <=, for optimization.
14142 (Fcall_interactively): Count the number of arguments produced,
14143 not the number of arguments given. This is simpler and lets GCC
14144 4.6.0 generate slightly better code.
14145
dae0cd48
PE
14146 * ftfont.c: Distingish more carefully between FcChar8 and char.
14147 The previous code passed unsigned char * to a functions like
14148 strlen and xstrcasecmp that expect char *, which does not
14149 conform to the C standard.
14150 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
14151 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
14152 char * when the C standard requires it.
14153
76032d70
PE
14154 * keyboard.c (read_char): Remove unused var.
14155
eb3f1cc8
PE
14156 * eval.c: Port to Windows vsnprintf (Bug#8435).
14157 Include <limits.h>.
14158 (SIZE_MAX): Define if the headers do not.
14159 (verror): Do not give up if vsnprintf returns a negative count.
14160 Instead, grow the buffer. This ports to Windows vsnprintf, which
14161 does not conform to C99. Problem reported by Eli Zaretskii.
14162 Also, simplify the allocation scheme, by avoiding the need for
14163 calling realloc, and removing the ALLOCATED variable.
14164
70476b54
PE
14165 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
14166
12020a9e
PE
14167 Remove invocations of doprnt, as Emacs now uses vsnprintf.
14168 But keep the doprint source code for now, as we might revamp it
14169 and use it again (Bug#8435).
ea6c7ae6
PE
14170 * lisp.h (doprnt): Remove.
14171 * Makefile.in (base_obj): Remove doprnt.o.
14172 * deps.mk (doprnt.o): Remove.
14173
5fdb398c
PE
14174 error: Print 32- and 64-bit integers portably (Bug#8435).
14175 Without this change, on typical 64-bit hosts error ("...%d...", N)
14176 was used to print both 32- and 64-bit integers N, which relied on
14177 undefined behavior.
61bdb816 14178 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
14179 * lisp.h (error, verror): Mark as printf-like functions.
14180 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
14181 Report overflow in size calculations when allocating printf buffer.
14182 Do not truncate output string at its first null byte.
14183 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
14184 Truncate the output at a character boundary, since vsnprintf does not
14185 do that.
14186 * charset.c (check_iso_charset_parameter): Convert internal
14187 character to string before calling 'error', since %c now has the
14188 printf meaning.
14189 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
14190 overflow when computing char to be passed to 'error'. Do not
14191 pass Lisp_Object to 'error'; pass the integer instead.
14192 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
14193 formatted with plain %d.
14194
b189fa66
PE
14195 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
14196
bff87ef0
PE
14197 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
14198
7e2cac20
PE
14199 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
14200
ce4d90b5
PE
14201 * xterm.c (x_catch_errors): Remove duplicate declaration.
14202
266c9547
PE
14203 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
14204
79c49ad2
PE
14205 * xdisp.c, lisp.h (message_nolog): Remove; unused.
14206
368f4090
JM
142072011-04-10 Jim Meyering <meyering@redhat.com>
14208
14209 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
14210 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
14211 return ssize_t not "int", and use size_t as the buffer length.
14212 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
14213 * gnutls.h: Update declarations.
14214 * process.c (read_process_output): Use ssize_t, to match.
14215 (send_process): Likewise.
14216
a32d4040
CY
142172011-04-09 Chong Yidong <cyd@stupidchicken.com>
14218
14219 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
14220
8546720e 142212011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 14222
04f2d78b
CB
14223 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
14224 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 14225
8546720e
GM
14226 * xterm.c (handle_one_xevent):
14227 * xmenu.c (create_and_show_popup_menu):
14228 * xselect.c (x_decline_selection_request)
14229 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 14230
0a2f5c1a 142312011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
14232
14233 Fix some uses of `int' instead of EMACS_INT.
14234 * search.c (string_match_1, fast_string_match)
14235 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
14236 (scan_buffer, find_next_newline_no_quit)
14237 (find_before_next_newline, search_command, Freplace_match)
14238 (Fmatch_data): Make some `int' variables be EMACS_INT.
14239
14240 * xdisp.c (display_count_lines): 3rd argument and return value now
14241 EMACS_INT. All callers changed.
14242 (pint2hrstr): Last argument is now EMACS_INT.
14243
14244 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
14245 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
14246 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
14247 (decode_coding_utf_16, decode_coding_emacs_mule)
14248 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
14249 (decode_coding_ccl, decode_coding_charset)
14250 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
14251 (decode_coding_iso_2022, decode_coding_emacs_mule)
14252 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
14253 <char_offset, last_offset>: Declare EMACS_INT.
14254 (encode_coding_utf_8, encode_coding_utf_16)
14255 (encode_coding_emacs_mule, encode_invocation_designation)
14256 (encode_designation_at_bol, encode_coding_iso_2022)
14257 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
14258 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
14259 Declare EMACS_INT.
14260 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
14261 (encode_invocation_designation): Last argument P_NCHARS is now
14262 EMACS_INT.
14263 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
14264 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
14265
14266 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
14267 All users changed.
14268
14269 * ccl.c (Fccl_execute_on_string): Declare some variables
14270 EMACS_INT.
14271
8546720e 142722011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
14273
14274 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
14275
4e19a977
CS
142762011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
14277
14278 * process.c (Fformat_network_address): Doc fix.
14279
87302331
R
142802011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
14281
ee7683eb 14282 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 14283
cbb59342
CY
142842011-04-08 Chong Yidong <cyd@stupidchicken.com>
14285
14286 * keyboard.c (read_char): Call Lisp function help-form-show,
14287 instead of using internal_with_output_to_temp_buffer.
14288 (Qhelp_form_show): New var.
e0d38eeb 14289 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
14290
14291 * print.c (internal_with_output_to_temp_buffer): Function deleted.
14292
14293 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
14294
e67a13ab
CY
142952011-04-06 Chong Yidong <cyd@stupidchicken.com>
14296
04f2d78b
CB
14297 * process.c (Flist_processes): Remove to Lisp.
14298 (list_processes_1): Delete.
e67a13ab 14299
973f782d
EZ
143002011-04-06 Eli Zaretskii <eliz@gnu.org>
14301
7c106b1e
EZ
14302 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
14303
973f782d
EZ
14304 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
14305
41cf7d1a 143062011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 14307
ca23cc88
PE
14308 Fix more problems found by GCC 4.6.0's static checks.
14309
f390e2d5
PE
14310 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
14311
42eea0d0
PE
14312 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
14313
b69769da 14314 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 14315
f9541e84
PE
14316 * xdisp.c (vmessage): Mark as a printf-like function.
14317
13841b55
PE
14318 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
14319
c136c10f
PE
14320 * sound.c (sound_warning): Don't crash if arg contains a printf format.
14321
5e2d4a30
PE
14322 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
14323 printf-like functions.
14324 (tiff_load): Add casts to remove these marks before passing them
14325 to system-supplied API.
14326
583f48b9
PE
14327 * eval.c (Fsignal): Remove excess argument to 'fatal'.
14328
b25d760e
PE
14329 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
14330 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
14331 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
14332 directly, rather than having caller test rule sign. This avoids
14333 some unnecessary tests.
14334 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
14335 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
14336 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 14337
bc7b6697 14338 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 14339 (xfont_open): Avoid unnecessary tests.
bc7b6697 14340
27ccc379
PE
14341 * composite.c (composition_gstring_put_cache): Use unsigned integer.
14342
dcd5c89a
PE
14343 * composite.h, composite.c (composition_gstring_put_cache):
14344 Use EMACS_INT, not int, for length.
14345
b13a45c6
PE
14346 * composite.h (COMPOSITION_DECODE_REFS): New macro,
14347 breaking out part of COMPOSITION_DECODE_RULE.
14348 (COMPOSITION_DECODE_RULE): Use it.
14349 * composite.c (get_composition_id): Remove unused local vars,
14350 by using the new macro.
14351
1e792e4d
PE
14352 * textprop.c (set_text_properties_1): Change while to do-while,
14353 since the condition is always true at first.
14354
dc6c6455 14355 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
14356 (interval_deletion_adjustment): Return unsigned value.
14357 All uses changed.
dc6c6455 14358
aba7731a
PE
14359 * process.c (list_processes_1, create_pty, read_process_output):
14360 (exec_sentinel): Remove vars that were set but not used.
afd4052b 14361 (create_pty): Remove unnecessary "volatile"s.
bc57d757 14362 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 14363 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 14364 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 14365
fdfc4bf3
PE
14366 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
14367
fca8fe46 14368 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 14369 (update_syntax_table): Use unsigned instead of int.
fca8fe46 14370
06a0259a 14371 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 14372 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 14373 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 14374
e7b9e80f
PE
14375 * print.c (print_error_message): Avoid int overflow.
14376
56201685
PE
14377 * font.c (font_list_entities): Redo for clarity,
14378 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
14379
78834453 14380 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 14381 (font_score): Avoid potential overflow in diff calculation.
78834453 14382
0bc0b309 14383 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 14384 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 14385
e610eaca
PE
14386 * eval.c (funcall_lambda): Rename local to avoid shadowing.
14387
b895abce
PE
14388 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
14389 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
14390 can always succeed if overflow has undefined behavior.
14391
1f1d9321 14392 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 14393 (wordify): Omit three unnecessary tests.
1f1d9321 14394
c59478bc
PE
14395 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
14396 All callers changed. This avoids the need for an unused var.
14397
79b73827
PE
14398 * casefiddle.c (casify_region): Remove var that is set but not used.
14399
a4db5dfe
PE
14400 * dired.c (file_name_completion): Remove var that is set but not used.
14401
43aae36e
PE
14402 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
14403
2a47c44d 14404 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 14405 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 14406
a37c69bf
PE
14407 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
14408 Check for integer overflow on size calculations.
14409
328ab8e7
PE
14410 * buffer.c (Fprevious_overlay_change): Remove var that is set
14411 but not used.
14412
e5a2a5cb
PE
14413 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
14414 Remove vars that are set but not used.
8d84a6eb 14415 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 14416 (timer_check_2): Mark vars as initialized.
e5a2a5cb 14417
a60e5f68
PE
14418 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
14419
f661cb61 14420 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 14421 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 14422
f0397f5a
PE
14423 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
14424 that are set but not used.
14425
8664db06 14426 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 14427 if XCreateBitmapFromData fails (Bug#8410).
8664db06 14428
6abdaa4a
PE
14429 * xselect.c (x_get_local_selection, x_handle_property_notify):
14430 Remove vars that are set but not used.
14431
0ce7538d 14432 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 14433 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 14434
9ae848fc
PE
14435 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
14436 Remove var that is set but not used.
0b918413
PE
14437 (scroll_bar_windows_size): Now size_t, not int.
14438 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
14439 Check for overflow.
9ae848fc 14440
a5a62657
PE
14441 * xfaces.c (realize_named_face): Remove vars that are set but not used.
14442 (map_tty_color) [!defined MSDOS]: Likewise.
14443
5c5cdd39
PE
14444 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
14445
66ebf983
PE
14446 * coding.c: Remove vars that are set but not used.
14447 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
14448 All callers changed.
14449 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
14450 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
14451 (decode_coding_charset): Remove vars that are set but not used.
14452
1be4d761
PE
14453 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
14454 that is set but not used.
14455
47553fa8
PE
14456 * print.c (print_object): Remove var that is set but not used.
14457
1f7196bf 14458 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
14459 The gnulib version avoids calling malloc in the usual case,
14460 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
14461 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
14462 * filelock.c (current_lock_owner): Likewise.
14463 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
14464 * sysdep.c: Include allocator.h, careadlinkat.h.
14465 (emacs_no_realloc_allocator): New static constant.
14466 (emacs_readlink): New function.
fdb61804
PE
14467 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
14468 ../lib/careadlinkat.h.
d1fdcab7 14469
f84c17c7
SM
144702011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
14471
14472 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
14473 first non-nil return value).
14474
ef3862ad
JD
144752011-04-03 Jan Djärv <jan.h.d@swipnet.se>
14476
14477 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
14478 if not defined (Bug#8403).
14479
376a7006
JB
144802011-04-02 Juanma Barranquero <lekktu@gmail.com>
14481
14482 * xdisp.c (display_count_lines): Remove parameter `start',
14483 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
14484 (get_char_face_and_encoding): Remove parameter `multibyte_p',
14485 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
14486 (fill_stretch_glyph_string): Remove parameters `row' and `area',
14487 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
14488 and thereabouts. All callers changed.
14489 (get_per_char_metric): Remove parameter `f', unused since
14490 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
14491
6ca3801d
JM
144922011-04-02 Jim Meyering <meyering@redhat.com>
14493
14494 do not dereference NULL upon failed strdup
14495 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
14496 (ns_get_family): Likewise.
14497
d8e2b5ba
JB
144982011-04-02 Juanma Barranquero <lekktu@gmail.com>
14499
14500 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
14501
8c74fcbd
JD
145022011-04-02 Jan Djärv <jan.h.d@swipnet.se>
14503
14504 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
14505 later (Bug#8403).
14506
7200d79c
SM
145072011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
14508
03408648 14509 Add lexical binding.
7200d79c 14510
03408648
SM
14511 * window.c (Ftemp_output_buffer_show): New fun.
14512 (Fsave_window_excursion):
14513 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
14514
14515 * lread.c (lisp_file_lexically_bound_p): New function.
14516 (Fload): Bind Qlexical_binding.
14517 (readevalloop): Remove `evalfun' arg.
14518 Bind Qinternal_interpreter_environment.
14519 (Feval_buffer): Bind Qlexical_binding.
14520 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
14521 Mark as dynamic.
14522 (syms_of_lread): Declare `lexical-binding'.
14523
14524 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
14525
14526 * keyboard.c (eval_dyn): New fun.
14527 (menu_item_eval_property): Use it.
ca105506
SM
14528
14529 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 14530
03408648
SM
14531 * fns.c (concat, mapcar1): Accept byte-code-functions.
14532
14533 * eval.c (Fsetq): Handle lexical vars.
14534 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
14535 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
14536 (FletX, Flet): Obey lexical binding.
14537 (Fcommandp): Handle closures.
14538 (Feval): New `lexical' arg.
14539 (eval_sub): New function extracted from Feval. Use it almost
14540 everywhere where Feval was used. Look up vars in lexical env.
14541 Handle closures.
14542 (Ffunctionp): Move from subr.el.
14543 (Ffuncall): Handle closures.
14544 (apply_lambda): Remove `eval_flags'.
14545 (funcall_lambda): Handle closures and new byte-code-functions.
14546 (Fspecial_variable_p): New function.
14547 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
14548 but without exporting it to Lisp.
23aba0ea 14549
23aba0ea 14550 * doc.c (Fdocumentation, store_function_docstring):
03408648 14551 * data.c (Finteractive_form): Handle closures.
23aba0ea 14552
03408648
SM
14553 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
14554 interactive spec.
ba83908c 14555
04f2d78b
CB
14556 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
14557 New byte-codes.
03408648
SM
14558 (exec_byte_code): New function extracted from Fbyte_code to handle new
14559 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 14560
03408648 14561 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 14562
03408648 14563 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 14564
e2abce01
JB
145652011-03-31 Juanma Barranquero <lekktu@gmail.com>
14566
14567 * xdisp.c (redisplay_internal): Fix prototype.
14568
63696a73 145692011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 14570
63696a73 14571 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
14572 (try_scrolling): Use it when setting scroll_limit.
14573 Limit scrolling to 100 screen lines.
63696a73
EZ
14574 (redisplay_window): Even when falling back on "recentering",
14575 position point in the window according to scroll-conservatively,
14576 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
14577
14578 (try_scrolling): When point is above the window, allow searching
14579 as far as scroll_max, or one screenful, to compute vertical
14580 distance from PT to the scroll margin position. This prevents
14581 try_scrolling from unnecessarily failing when
14582 scroll-conservatively is set to a value slightly larger than the
14583 window height. Clean up the case of PT below the margin at bottom
14584 of window: scroll_max can no longer be INT_MAX. When aggressive
14585 scrolling is in use, don't let point enter the opposite scroll
14586 margin as result of the scroll.
14587 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
14588 threshold of 100 lines for never-recentering scrolling.
14589
e4cc2dfc
JB
145902011-03-31 Juanma Barranquero <lekktu@gmail.com>
14591
14592 * dispextern.h (move_it_by_lines):
14593 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
14594 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
14595 (message_log_check_duplicate): Remove parameters `prev_bol' and
14596 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
14597 (redisplay_internal): Remove parameter `preserve_echo_area',
14598 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
14599
14600 * indent.c (Fvertical_motion):
14601 * window.c (window_scroll_pixel_based, Frecenter):
14602 Don't pass `need_y_p' to `move_it_by_lines'.
14603
1c470562
SM
146042011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
14605
44f230aa
SM
14606 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
14607 steal a few bits to be more compact.
14608 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
14609 Remove unneeded casts.
14610
1c470562
SM
14611 * bytecode.c (Fbyte_code): CAR and CDR can GC.
14612
888adce9
ZK
146132011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
14614
14615 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
14616 binding" message (bug#7967).
14617
f838ed7b
PE
146182011-03-30 Paul Eggert <eggert@cs.ucla.edu>
14619
77861b95
PE
14620 Fix more problems found by GCC 4.6.0's static checks.
14621
de6dbc14
PE
14622 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
14623 Remove unused local var.
14624
f838ed7b
PE
14625 * editfns.c (Fmessage_box): Remove unused local var.
14626
792c7b2b
PE
14627 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
14628 (note_mode_line_or_margin_highlight, note_mouse_highlight):
14629 Omit unused local vars.
c499e557 14630 * window.c (shrink_windows): Omit unused local var.
b01a1c29 14631 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
14632 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
14633 Omit unused local var.
14634
ba0165e1
PE
14635 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
14636 Don't assume string length fits in int.
32ad8845 14637 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 14638 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 14639
3c59b4c9
PE
14640 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
14641 instead of alloca (Bug#8344).
14642
a3eed478 14643 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 14644 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 14645
eb4d412d
PE
14646 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
14647
1658b401
PE
14648 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
14649 concerns.
14650
14651 * term.c (produce_glyphless_glyph): Remove unnecessary test.
14652
14653 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 14654
9a2c6e05
PE
14655 * keyboard.c (syms_of_keyboard): Use the same style as later
14656 in this function when indexing through an array. This also
14657 works around GCC bug 48267.
14658
03d0a109
PE
14659 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
14660
44f730c8
PE
14661 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
14662
fe75f926
PE
14663 * chartab.c (sub_char_table_ref_and_range): Redo for slight
14664 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
14665
ffa8c828
PE
14666 * keyboard.c, keyboard.h (num_input_events): Now size_t.
14667 This avoids undefined behavior on integer overflow, and is a bit
14668 more convenient anyway since it is compared to a size_t variable.
14669
c5101a77
PE
14670 Variadic C functions now count arguments with size_t, not int.
14671 This avoids an unnecessary limitation on 64-bit machines, which
14672 caused (substring ...) to crash on large vectors (Bug#8344).
14673 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
14674 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 14675 All variadic functions and their callers changed accordingly.
c5101a77
PE
14676 (struct gcpro.nvars): Now size_t, not int. All uses changed.
14677 * data.c (arith_driver, float_arith_driver): Likewise.
14678 * editfns.c (general_insert_function): Likewise.
14679 * eval.c (struct backtrace.nargs, interactive_p)
14680 (internal_condition_case_n, run_hook_with_args, apply_lambda)
14681 (funcall_lambda, mark_backtrace): Likewise.
14682 * fns.c (concat): Likewise.
14683 * frame.c (x_set_frame_parameters): Likewise.
14684 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
14685 0 if not found, not -1. All callers changed.
14686
dd3f25f7
PE
14687 * alloc.c (garbage_collect): Don't assume stack size fits in int.
14688 (stack_copy_size): Now size_t, not int.
14689 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
14690
461c2ab9
JB
146912011-03-28 Juanma Barranquero <lekktu@gmail.com>
14692
14693 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
14694 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14695 All callers changed.
14696
14697 * lisp.h (multibyte_char_to_unibyte):
14698 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
14699 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14700 * character.h (CHAR_TO_BYTE8):
14701 * cmds.c (internal_self_insert):
14702 * editfns.c (general_insert_function):
14703 * keymap.c (push_key_description):
14704 * search.c (Freplace_match):
14705 * xdisp.c (message_dolog, set_message_1): All callers changed.
14706
f6d62986
SM
147072011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
14708
14709 * keyboard.c (safe_run_hook_funcall): New function.
14710 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
14711 don't set the hook to nil, but remove the offending function instead.
14712 (Qcommand_hook_internal): Remove, unused.
14713 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
14714 Vcommand_hook_internal.
14715
14716 * eval.c (enum run_hooks_condition): Remove.
14717 (funcall_nil, funcall_not): New functions.
14718 (run_hook_with_args): Call each function through a `funcall' argument.
14719 Remove `cond' argument, now redundant.
14720 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
14721 (Frun_hook_with_args_until_failure): Adjust accordingly.
14722 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
14723
1db5b1ad
JB
147242011-03-28 Juanma Barranquero <lekktu@gmail.com>
14725
14726 * dispextern.h (string_buffer_position): Remove declaration.
14727
14728 * print.c (strout): Remove parameter `multibyte', unused since
14729 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
14730
14731 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
14732 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
14733 All callers changed.
14734
14735 * w32.c (_wsa_errlist): Use braces for struct initializers.
14736
14737 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
14738 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
14739 All callers changed.
14740 (string_buffer_position): Likewise. Also, make static (it's never
14741 used outside xdisp.c).
14742 (cursor_row_p): Remove parameter `w', unused since
14743 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
14744 (decode_mode_spec): Remove parameter `precision', introduced during
14745 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
14746 All callers changed.
14747
5ffb62aa
JD
147482011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14749
14750 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
14751
461c2ab9 147522011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
14753
14754 * nsterm.m (ns_menu_bar_is_hidden): New variable.
14755 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
14756 (ns_update_auto_hide_menu_bar): New functions.
14757 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
14758 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
14759 ns_constrain_all_frames.
14760 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
14761 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
14762
5c380ffb
JD
147632011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14764
14765 * nsmenu.m (runDialogAt): Remove argument to timer_check.
14766
9af30bdf
GM
147672011-03-27 Glenn Morris <rgm@gnu.org>
14768
14769 * syssignal.h: Replace RETSIGTYPE with void.
14770 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
14771 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
14772 Replace SIGTYPE with void everywhere.
14773 * s/usg5-4-common.h (SIGTYPE): Remove definition.
14774 * s/template.h (SIGTYPE): Remove commented out definition.
14775
e2abce01
JB
147762011-03-26 Eli Zaretskii <eliz@gnu.org>
14777
14778 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
14779 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
14780
f868cd8a
JB
147812011-03-26 Juanma Barranquero <lekktu@gmail.com>
14782
59eb0929
JB
14783 * w32.c (read_unc_volume): Use parameter `henum', instead of
14784 global variable `wget_enum_handle'.
14785
14786 * keymap.c (describe_vector): Remove parameters `indices' and
14787 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
14788 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
14789
f868cd8a
JB
14790 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
14791
14792 * keyboard.c (timer_check): Remove parameter `do_it_now',
14793 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
14794 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
14795 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
14796
14797 * keyboard.c (read_char):
14798 * w32menu.c (w32_menu_display_help):
14799 * xmenu.c (show_help_event, menu_help_callback):
14800 Adjust calls to `show_help_echo'.
14801
14802 * gtkutil.c (xg_maybe_add_timer):
14803 * keyboard.c (readable_events):
14804 * process.c (wait_reading_process_output):
14805 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
14806
14807 * insdel.c (adjust_markers_gap_motion):
14808 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
14809 (gap_left, gap_right): Don't call it.
14810
2ecf6fdb
CY
148112011-03-25 Chong Yidong <cyd@stupidchicken.com>
14812
14813 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
14814 incurred during fontification.
14815
6b1f9ba4
JB
148162011-03-25 Juanma Barranquero <lekktu@gmail.com>
14817
14818 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
14819 (DEFVAR_PER_BUFFER): Don't pass it.
14820
14821 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
14822 (scrolling_window): Don't pass it.
14823
0f4a96b5
JB
148242011-03-25 Juanma Barranquero <lekktu@gmail.com>
14825
14826 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
14827
14828 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
14829 and `suffix'.
14830 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
14831 of variables specific to SELinux and computation of `encoded_absname'.
14832
14833 * image.c (XPutPixel): Remove unused variable `height'.
14834
14835 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
14836
14837 * unexw32.c (get_section_info): Remove unused variable `section'.
14838
14839 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
14840 (system_process_attributes): Remove unused variable `sess'.
14841 (sys_read): Remove unused variable `err'.
14842
14843 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
14844 (w32_wnd_proc): Remove unused variable `isdead'.
14845 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
14846 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
14847 (x_create_tip_frame): Remove unused variable `tem'.
14848
14849 * w32inevt.c (w32_console_read_socket):
14850 Remove unused variable `no_events'.
14851
14852 * w32term.c (x_draw_composite_glyph_string_foreground):
14853 Remove unused variable `width'.
14854
1149507c
JB
148552011-03-24 Juanma Barranquero <lekktu@gmail.com>
14856
14857 * w32term.c (x_set_glyph_string_clipping):
14858 Don't pass uninitialized region to CombineRgn.
14859
9c88f339
JB
148602011-03-23 Juanma Barranquero <lekktu@gmail.com>
14861
14862 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
14863 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
14864 (Fx_close_connection): Remove unused variable `i'.
14865
14866 * w32font.c (w32font_draw): Return number of glyphs.
14867 (w32font_open_internal): Remove unused variable `i'.
14868 (w32font_driver): Add missing initializer.
14869
14870 * w32menu.c (utf8to16): Remove unused variable `utf16'.
14871 (fill_in_menu): Remove unused variable `items_added'.
14872
14873 * w32term.c (last_mouse_press_frame): Remove static global variable.
14874 (w32_clip_to_row): Remove unused variable `f'.
14875 (x_delete_terminal): Remove unused variable `i'.
14876
14877 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
14878 (NOTHING): Remove unused static global variable.
14879 (uniscribe_check_otf): Remove unused variable `table'.
14880 (uniscribe_font_driver): Add missing initializers.
14881
dee091a3
JD
148822011-03-23 Julien Danjou <julien@danjou.info>
14883
14884 * term.c (Fsuspend_tty, Fresume_tty):
14885 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
14886 * window.c (temp_output_buffer_show):
14887 * insdel.c (signal_before_change):
14888 * frame.c (Fhandle_switch_frame):
14889 * fileio.c (Fdo_auto_save):
14890 * emacs.c (Fkill_emacs):
14891 * editfns.c (save_excursion_restore):
14892 * cmds.c (internal_self_insert):
14893 * callint.c (Fcall_interactively):
14894 * buffer.c (Fkill_all_local_variables):
14895 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
14896 Use Frun_hooks.
0f4a96b5 14897 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 14898 unconditionally since it does the check itself.
dee091a3 14899
2c520ab5 149002011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 14901
c9c49752
PE
14902 Fix more problems found by GCC 4.5.2's static checks.
14903
8abc3f12
PE
14904 * coding.c (encode_coding_raw_text): Avoid unnecessary test
14905 the first time through the loop, since we know p0 < p1 then.
14906 This also avoids a gcc -Wstrict-overflow warning.
14907
a2d26660
PE
14908 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
14909 leading to a memory leak, possible in functions like
14910 load_charset_map_from_file that can allocate an unbounded number
b12ef411 14911 of objects (Bug#8318).
a2d26660 14912
916c72e9
PE
14913 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
14914 that could (at least in theory) be that large.
14915
19ab8a18
PE
14916 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
14917 This is less likely to overflow, and avoids undefined behavior if
14918 overflow does occur. All callers changed. Use strtoul to scan
14919 for the unsigned long integer.
b7cbbd6f
PE
14920 (pint2hrstr): Simplify and tune code slightly.
14921 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 14922
f0641eff
PE
14923 * scroll.c (do_scrolling): Work around GCC bug 48228.
14924 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
14925
7f650bb9
PE
14926 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
14927 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
14928 (validate_x_resource_name): Simplify count usage.
14929 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 14930
37dd57d1
PE
14931 * fileio.c (Fcopy_file): Report error if fchown or fchmod
14932 fail (Bug#8306).
81e56e61 14933
699979fc 14934 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 14935
401bf9b4
PE
14936 * process.c (Fmake_network_process): Use socklen_t, not int,
14937 where POSIX says socklen_t is required in portable programs.
14938 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 14939 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
14940 (Fmake_network_process, server_accept_connection):
14941 (wait_reading_process_output, read_process_output):
14942 Likewise.
14943
b93aacde
PE
14944 * process.c: Rename or move locals to avoid shadowing.
14945 (list_processes_1, Fmake_network_process):
14946 (read_process_output_error_handler, exec_sentinel_error_handler):
14947 Rename or move locals.
4dc343ee 14948 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 14949 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 14950 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 14951 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 14952 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 14953
af8a867c 14954 Make tparam.h and terminfo.c consistent.
44f230aa
SM
14955 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
14956 Include tparam.h instead, since it declares them.
af8a867c
PE
14957 * cm.h (PC): Remove extern decl; tparam.h now does this.
14958 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
14959 * terminfo.c: Include tparam.h, to check interfaces.
14960 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
14961 (tparam): Adjust signature to match interface in tparam.h;
14962 this removes some undefined behavior. Check that outstring and len
14963 are zero, which they always are with Emacs.
14964 * tparam.h (PC, BC, UP): New extern decls.
14965
0248044d 14966 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 14967 (xftfont_open): Rename locals to avoid shadowing.
0248044d 14968
8ff096c1 14969 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
14970 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
14971 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 14972 (ftfont_list): Remove unused local.
49eaafba
PE
14973 (get_adstyle_property, ftfont_pattern_entity):
14974 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
14975 Rename locals to avoid shadowing.
8ff096c1 14976
e2be39f6
PE
14977 * xfont.c (xfont_list_family): Mark var as initialized.
14978
c9735e30
PE
14979 * xml.c (make_dom): Now static.
14980
8f5201ae
PE
14981 * composite.c (composition_compute_stop_pos): Rename local to
14982 avoid shadowing.
b246f932
PE
14983 (composition_reseat_it): Remove unused locals.
14984 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 14985 (composition_update_it): Mark var as initialized.
11b61122
PE
14986 (find_automatic_composition): Mark vars as initialized,
14987 with a FIXME (Bug#8290).
8f5201ae 14988
760fbc2c
PE
14989 character.h: Rename locals to avoid shadowing.
14990 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
14991 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
14992 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
14993 (BUF_DEC_POS): Be more systematic about renaming local temporaries
14994 to avoid shadowing.
14995
ff08eb85
PE
14996 * textprop.c (property_change_between_p): Remove; unused.
14997
fc7bf025
PE
14998 * intervals.c (interval_start_pos): Now static.
14999
235d7abc
PE
15000 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
15001
44f230aa
SM
15002 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
15003 Rename locals to avoid shadowing.
3e7d6594 15004
50060332
PE
15005 * sound.c (wav_play, au_play, Fplay_sound_internal):
15006 Fix pointer signedness.
d01f234b 15007 (alsa_choose_format): Remove unused local var.
c83b8872
PE
15008 (wav_play): Initialize a variable to 0, to prevent undefined
15009 behavior (Bug#8278).
50060332 15010
c4fc4e30
PE
15011 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
15012
918436ed
PE
15013 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
15014
c939f91b
PE
15015 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
15016 clobbering (Bug#8298).
b9c7f648
PE
15017 * sysdep.c (sys_subshell): Likewise.
15018 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 15019
6bd8c144
PE
15020 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
15021 This should get cleaned up, so that child_setup has the
15022 same signature on all platforms.
15023
7710357c 15024 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 15025 (relocate_fd): Rename locals to avoid shadowing.
7710357c 15026
c59da222
CY
150272011-03-22 Chong Yidong <cyd@stupidchicken.com>
15028
15029 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
15030 not to be necessary, and produces flickering.
15031
66b87493
GM
150322011-03-20 Glenn Morris <rgm@gnu.org>
15033
15034 * config.in: Remove file.
15035
45b6f6d5
JB
150362011-03-20 Juanma Barranquero <lekktu@gmail.com>
15037
15038 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
15039 are now in src/globals.h.
15040 (syms_of_minibuf): Remove spurious & from previous change.
15041
cd394be1 150422011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
15043
15044 * minibuf.c (completing-read-function): New variable.
15045 (completing-read-default): Rename from completing-read.
15046 (completing-read): Call completing-read-function.
15047
b14e3e21
CY
150482011-03-19 Juanma Barranquero <lekktu@gmail.com>
15049
15050 * xfaces.c (Fx_load_color_file):
15051 Read color file from absolute filename (bug#8250).
15052
f2b726e6
JB
150532011-03-19 Juanma Barranquero <lekktu@gmail.com>
15054
15055 * makefile.w32-in: Update dependencies.
15056
09f6ff02
EZ
150572011-03-17 Eli Zaretskii <eliz@gnu.org>
15058
15059 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
15060
29a6015a
PE
150612011-03-17 Paul Eggert <eggert@cs.ucla.edu>
15062
a3a6c54e
PE
15063 Fix more problems found by GCC 4.5.2's static checks.
15064
b766f867
PE
15065 * process.c (make_serial_process_unwind, send_process_trap):
15066 (sigchld_handler): Now static.
15067
be02381c
PE
15068 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
15069 That way, the code declares only the vars that it needs.
15070 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
15071 * s/cygwin.h (PTY_ITERATION): Likewise.
15072 * s/darwin.h (PTY_ITERATION): Likewise.
15073 * s/gnu-linux.h (PTY_ITERATION): Likewise.
15074
57048744
PE
15075 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
15076 * process.c (allocate_pty): Don't declare stb unless it's needed.
15077
7914961c 15078 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
15079 (CONSTANTLIM): Remove; unused.
15080 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
15081 Define only if needed.
7914961c 15082
b3967b18
PE
15083 * unexelf.c (unexec): Name an expression,
15084 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
15085 Use a different way to cause a compilation error if anyone uses
15086 n rather than nn, a way that does not involve shadowing.
73366a00 15087 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 15088
29a6015a
PE
15089 * deps.mk (unexalpha.o): Remove; unused.
15090
43cfc33e 15091 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 15092 * unexec.h: New file.
ce701a33
PE
15093 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
15094 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
15095 Depend on unexec.h.
15096 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
15097 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
15098 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 15099 Change as necessary to match prototype in unexec.h.
ce701a33 15100
01f44d5a
PE
15101 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
15102 shadowing.
4f63c6bb 15103 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 15104
a6670b0b
PE
15105 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
15106 Rename locals to avoid shadowing.
15107
cef2010d 15108 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 15109 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 15110
d4d7173a
PE
15111 * print.c (Fredirect_debugging_output): Fix pointer signedess.
15112
f08b802a
PE
15113 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
15114 warning when compiling print.c.
15115
3ddb0639
PE
15116 * font.c (font_unparse_fcname): Abort in an "impossible" situation
15117 instead of using an uninitialized var.
5ad03b97 15118 (font_sort_entities): Mark var as initialized.
3ddb0639 15119
170a2692
PE
15120 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
15121
e663c700
PE
15122 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
15123 pointers to constants.
89bc529a 15124 (font_parse_fcname): Remove unused vars.
7b81e2d0 15125 (font_delete_unmatched): Now static.
ea838e10 15126 (font_get_spec): Remove; unused.
13a547c6
PE
15127 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
15128 (font_update_drivers, Ffont_get_glyphs, font_add_log):
15129 Rename or move locals to avoid shadowing.
e663c700 15130
2a80c887 15131 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 15132 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 15133
1384fa33 15134 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 15135 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 15136
8b2c52e9
PE
15137 * alloc.c (mark_backtrace): Move decl from here ...
15138 * lisp.h: ... to here, so that it can be checked.
15139
475545b5 15140 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 15141 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
15142 (lisp_indirect_variable): Name an expression,
15143 to avoid gcc -Wbad-function-cast warning.
1faed8ae 15144 (Fdefvar): Rename locals to avoid shadowing.
475545b5 15145
b1349114 15146 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 15147 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 15148 Use const pointer when appropriate.
b1349114 15149
a2928364
PE
15150 * lisp.h (get_system_name, get_operating_system_release):
15151 Move decls here, to check interfaces.
15152 * process.c (get_operating_system_release): Move decl to lisp.h.
15153 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
15154 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
15155 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
15156 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
15157 (Fformat_time_string, Fencode_time, Finsert_char):
15158 (Ftranslate_region_internal, Fformat):
15159 Rename or remove local vars to avoid shadowing.
9710023e 15160 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 15161
a415e694
PE
15162 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
15163 avoid shadowing.
15164
8ef4622d
PE
15165 * lisp.h (eassert): Check that the argument compiles, even if
15166 ENABLE_CHECKING is not defined.
15167
946f9a5b
PE
15168 * data.c (Findirect_variable): Name an expression, to avoid
15169 gcc -Wbad-function-cast warning.
112396d6 15170 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 15171 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
15172 (Fmake_variable_buffer_local, Fmake_local_variable):
15173 Mark variables as initialized.
52746918 15174 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 15175
e5aab7e7 15176 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
15177 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
15178 Rename locals to avoid shadowing.
dff45157
PE
15179 (mark_stack): Move local variables into the #ifdef region where
15180 they're used.
7bc26fdb
PE
15181 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
15182 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
15183 needed otherwise.
15184 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
15185 (GC_STRING_CHARS): Remove; not used.
d40d4be1 15186 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 15187
e5aab7e7
PE
15188 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
15189 avoids undefined behavior in theory.
15190
4da60324
PE
15191 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
15192
88043301
PE
15193 Use functions, not macros, for up- and down-casing (Bug#8254).
15194 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
15195 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
15196 to use the following functions instead of these macros.
15197 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
15198 EMACS_INT, since callers assume the returned value fits in int.
15199 (upcase1): Likewise, for UPCASE_TABLE.
15200 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 15201 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 15202 the race-condition problem in the old DOWNCASE.
88043301 15203
19ed5445
PE
15204 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
15205 Rename locals to avoid shadowing.
15206 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
15207 (regex_compile, re_search_2, re_match_2_internal):
15208 Remove unused local vars.
952db0d7
PE
15209 (FREE_VAR): Rewrite so as not to use empty "else",
15210 which gcc can warn about.
da053e48 15211 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
15212 (RETALLOC_IF): Define only if needed.
15213 (WORDCHAR_P): Likewise. This one is never needed, but is used
15214 only in a comment talking about a compiler bug, so put inside
15215 the #if 0 of that comment.
15216 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
15217 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
15218 Remove; unused.
19ed5445 15219
1f3561e4 15220 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
15221 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
15222 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 15223
ded6f8f7
PE
15224 * search.c (simple_search): Remove unused var.
15225
dbd37a95
PE
15226 * dired.c (compile_pattern): Move decl from here ...
15227 * lisp.h: ... to here, so that it can be checked.
15228 (struct re_registers): New forward decl.
15229
7e47afad
PE
15230 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
15231
85f24f61
PE
15232 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
15233 All uses changed.
15234 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
15235 Rename locals to avoid shadowing.
5671df8f 15236 (Fvertical_motion): Mark locals as initialized.
85f24f61 15237
181aa2be 15238 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 15239 (casify_region): Mark local as initialized.
181aa2be 15240
930d429c
PE
15241 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
15242
7082eac6
PE
15243 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
15244 New macros, so that the caller can use some names other than
15245 gcpro1, gcpro2, etc.
15246 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
15247 of the new macros.
15248 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
15249 argument, for consistency with GCPRO2_VAR, etc: it is now the
15250 prefix of the variable, not the variable itself. All uses
15251 changed.
38b2c076
PE
15252 * dired.c (directory_files_internal, file_name_completion):
15253 Rename locals to avoid shadowing.
15254
15206ed9
PE
15255 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
15256 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
15257 dired.c's scmp function, had undefined behavior.
15258 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
15259 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
15260 * buffer.h: ... to here, because these macros use current_buffer,
15261 and the new implementation with inline functions needs to have
15262 current_buffer in scope now, rather than later when the macros
15263 are used.
15264 (downcase, upcase1): New static inline functions.
15265 (DOWNCASE, UPCASE1): Reimplement using these functions.
15266 This avoids undefined behavior in expressions like
15267 DOWNCASE (x) == DOWNCASE (y), which previously suffered
15268 from race conditions in accessing the global variables
15269 case_temp1 and case_temp2.
15270 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
15271 * lisp.h (case_temp1, case_temp2): Remove their decls.
15272 * character.h (ASCII_CHAR_P): Move from here ...
15273 * lisp.h: ... to here, so that the inline functions mentioned
15274 above can use them.
15275
4a6bea26
PE
15276 * dired.c (directory_files_internal_unwind): Now static.
15277
f14b7e14
PE
15278 * fileio.c (file_name_as_directory, directory_file_name):
15279 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
15280 Now static.
2893f146
PE
15281 (file_name_as_directory): Use const pointers when appropriate.
15282 (Fexpand_file_name): Likewise. In particular, newdir might
15283 point at constant storage, so make it a const pointer.
fd4ead52 15284 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
15285 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
15286 signedness issues.
f839df0c
PE
15287 (Fset_file_times, Finsert_file_contents, auto_save_error):
15288 Rename locals to avoid shadowing.
f14b7e14 15289
5716756e 15290 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
15291 (Ftry_completion, Fall_completions): Rename or remove locals
15292 to avoid shadowing.
5716756e 15293
b4c3046a
PE
15294 * marker.c (bytepos_to_charpos): Remove; unused.
15295
b45db522
PE
15296 * lisp.h (verify_bytepos, count_markers): New decls,
15297 so that gcc does not warn that these functions aren't declared.
15298
85876d07
PE
15299 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
15300 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 15301 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 15302 (copy_text): Remove unused local var.
85876d07 15303
03d78a21 15304 * filelock.c (within_one_second): Now static.
b3dd38ab 15305 (lock_file_1): Rename local to avoid shadowing.
03d78a21 15306
5df8f01b
PE
15307 * buffer.c (fix_overlays_before): Mark locals as initialized.
15308 (fix_start_end_in_overlays): Likewise. This function should be
15309 simplified by using pointers-to-pointers, but that's a different
15310 matter.
b1d876f1 15311 (switch_to_buffer_1): Now static.
8f54f30a
PE
15312 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
15313 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 15314
a70072c9 15315 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 15316 Fix pointer signedness issue.
edced198
PE
15317 (sys_subshell): Mark local as volatile if checking for lint,
15318 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 15319 (MAXPATHLEN): Define only if needed.
a70072c9 15320
a0977c44
PE
15321 * process.c (serial_open, serial_configure): Move decls from here ...
15322 * systty.h: ... to here, so that they can be checked.
15323
a884fdcc
PE
15324 * fns.c (get_random, seed_random): Move extern decls from here ...
15325 * lisp.h: ... to here, so that they can be checked.
15326
604efe86 15327 * sysdep.c (reset_io): Now static.
b8950c94 15328 (wait_for_termination_signal): Remove; unused.
604efe86 15329
38fc62d9
PE
15330 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
15331 (copy_keymap_item, append_key, push_text_char_description):
15332 Now static.
1004a21a 15333 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 15334 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
15335 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
15336 (describe_map_tree):
15337 Rename locals to avoid shadowing.
38fc62d9 15338
2f2650da
PE
15339 * keyboard.c: Declare functions static if they are not used elsewhere.
15340 (echo_char, echo_dash, cmd_error, top_level_2):
15341 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
15342 (read_char, kbd_buffer_get_event, make_lispy_position):
15343 (make_lispy_event, make_lispy_movement, apply_modifiers):
15344 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
15345 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
15346 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 15347 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 15348 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 15349
a053e86c 15350 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
15351 (mark_kboards): Move decl here ...
15352 * alloc.c (mark_kboards): ... from here.
a053e86c 15353
4752793e
PE
15354 * lisp.h (force_auto_save_soon): New decl.
15355
74f10ca7 15356 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
15357 (DEFINE_DUMMY_FUNCTION): New macro.
15358 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
15359 Use it.
c03cd23f
PE
15360 (main): Add casts to avoid warnings
15361 if GCC considers string literals to be constants.
74f10ca7 15362
022e70d4
PE
15363 * lisp.h (fatal_error_signal): Add decl, since it's exported.
15364
59d6fe83
PE
15365 * dbusbind.c: Pointer signedness fixes.
15366 (xd_signature, xd_append_arg, xd_initialize):
15367 (Fdbus_call_method, Fdbus_call_method_asynchronously):
15368 (Fdbus_method_return_internal, Fdbus_method_error_internal):
15369 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
15370 (Fdbus_register_signal): Use SSDATA when the context wants char *.
15371
78320123
PE
15372 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
15373 if GCC considers string literals to be constants.
49cebcca 15374 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 15375
35ac2a97
SM
153762011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
15377
fb103ca9
SM
15378 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
15379 (print_preprocess, print_object): New macro to fix last change.
15380
35ac2a97
SM
15381 * print.c (print_preprocess): Don't forget font objects.
15382
62973b41
JB
153832011-03-16 Juanma Barranquero <lekktu@gmail.com>
15384
15385 * emacs.c (USAGE3): Doc fixes.
15386
0e48bb22
AS
153872011-03-15 Andreas Schwab <schwab@linux-m68k.org>
15388
15389 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
15390 structure.
15391
7684e57b
JB
153922011-03-14 Juanma Barranquero <lekktu@gmail.com>
15393
15394 * lisp.h (VWindow_system, Qfile_name_history):
15395 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
15396 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
15397 (w32_system_caret_x, w32_system_caret_y): Declare extern.
15398
15399 * w32select.c: Don't #include "keyboard.h".
c96bbc66 15400 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
15401
15402 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
15403 * w32console.c (detect_input_pending, read_input_pending)
15404 (encode_terminal_code):
15405 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
15406 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
15407 (w32_system_caret_y, Qfile_name_history):
15408 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
15409 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
15410 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
15411 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
15412 * w32proc.c (Qlocal, report_file_error):
15413 * w32term.c (Vwindow_system, updating_frame):
15414 * w32uniscribe.c (initialized, uniscribe_font_driver):
15415 Remove unneeded extern declarations.
15416
2aa46d6c
CY
154172011-03-14 Chong Yidong <cyd@stupidchicken.com>
15418
c96bbc66 15419 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 15420
cffc6f3b
CY
154212011-03-13 Chong Yidong <cyd@stupidchicken.com>
15422
15423 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
15424 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
15425 These macros can no longer be used for assignment.
15426
44f230aa
SM
15427 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
15428 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
15429 (record_buffer_markers, fetch_buffer_markers): New functions for
15430 recording and fetching special buffer markers.
15431 (set_buffer_internal_1, set_buffer_temp): Use them.
15432
15433 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
15434
15435 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
15436
15437 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
15438 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
15439
15440 * xdisp.c (hscroll_window_tree):
15441 (reconsider_clip_changes): Use PT instead of BUF_PT.
15442
d251f04b
EZ
154432011-03-13 Eli Zaretskii <eliz@gnu.org>
15444
15445 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
15446 $(EMACS_ROOT)/lib/intprops.h.
15447
f0c77cd1
PE
154482011-03-13 Paul Eggert <eggert@cs.ucla.edu>
15449
3eca4629
PE
15450 Fix more problems found by GCC 4.5.2's static checks.
15451
7c86ee98
PE
15452 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
15453 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
15454 (xg_free_frame_widgets): Make it clear that a local variable is
15455 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
15456 (gdk_window_get_screen): Make it clear that this macro is needed
15457 only if USE_GTK_TOOLTIP.
1e5524e7
PE
15458 (int_gtk_range_get_value): New function, which avoids a diagnostic
15459 from gcc -Wbad-function-cast.
15460 (xg_set_toolkit_scroll_bar_thumb): Use it.
15461 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
15462 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
15463 (get_utf8_string, xg_get_file_with_chooser):
15464 Rename locals to avoid shadowing.
15465 (create_dialog): Move locals to avoid shadowing.
7c86ee98 15466
41729b81
PE
15467 * xgselect.c (xg_select): Remove unused var.
15468
f0c77cd1
PE
15469 * image.c (four_corners_best): Mark locals as initialized.
15470 (gif_load): Initialize transparent_p to zero (Bug#8238).
15471 Mark another local as initialized.
ec6cf4c6 15472 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 15473
ce0ad53d 15474 * image.c (clear_image_cache): Now static.
d5d5a617 15475 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 15476 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
15477 (x_edge_detection): Remove unnecessary cast that
15478 gcc -Wbad-function-cast diagnoses.
2037898d 15479 (gif_load): Fix pointer signedness.
6ae141d6
PE
15480 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
15481 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 15482
33383987 154832011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 15484
d32df629
PE
15485 Improve quality of tests for time stamp overflow.
15486 For example, without this patch (encode-time 0 0 0 1 1
15487 1152921504606846976) returns the obviously-bogus value (-948597
15488 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
15489 reports time overflow. See
15490 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
15491 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
15492 * editfns.c: Include limits.h and intprops.h.
15493 (TIME_T_MIN, TIME_T_MAX): New macros.
15494 (time_overflow): Move earlier, to before first use.
15495 (hi_time, lo_time): New functions, for an accurate test for
15496 out-of-range times.
15497 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
15498 (Fget_internal_run_time): Don't assume time_t fits in int.
15499 (make_time): Use list2 instead of Fcons twice.
15500 (Fdecode_time): More accurate test for out-of-range times.
15501 (check_tm_member): New function.
15502 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
15503 (lisp_time_argument): Don't rely on undefined left-shift and
15504 right-shift behavior when checking for time stamp overflow.
8be6f318 15505
fe31d94c
PE
15506 * editfns.c (time_overflow): New function, refactoring common code.
15507 (Fformat_time_string, Fdecode_time, Fencode_time):
15508 (Fcurrent_time_string): Use it.
15509
8be6f318
PE
15510 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
15511 * dired.c (make_time): Move to ...
15512 * editfns.c (make_time): ... here.
15513 * systime.h: Note the move.
15514
09d9db2c 155152011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 15516
126bc0dc
YM
15517 * fringe.c (update_window_fringes): Remove unused variables.
15518
c47cbdfd
YM
15519 * unexmacosx.c (copy_data_segment): Also copy __got section.
15520 (Bug#8223)
15521
7ac80be9
EZ
155222011-03-12 Eli Zaretskii <eliz@gnu.org>
15523
c96bbc66 15524 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
15525 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
15526 Constify `char *' arguments and their references according to
15527 prototypes in tparam.h.
15528
ecb0f94d 15529 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 15530
7ac80be9
EZ
15531 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
15532 Adapt all references accordingly.
15533
15534 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
15535
ef1fd07e
TT
155362011-03-11 Tom Tromey <tromey@redhat.com>
15537
15538 * buffer.c (syms_of_buffer): Remove obsolete comment.
15539
7ef4b50c
EZ
155402011-03-11 Eli Zaretskii <eliz@gnu.org>
15541
15542 * termhooks.h (encode_terminal_code): Declare prototype.
15543
15544 * msdos.c (encode_terminal_code): Don't declare prototype.
15545
15546 * term.c (encode_terminal_code): Now external again, used by
15547 w32console.c and msdos.c.
15548
44f230aa
SM
15549 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
15550 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 15551
4b1ec863 155522011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 15553
1714f52b 15554 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 15555
4b1ec863
PE
15556 * fringe.c (update_window_fringes): Mark locals as initialized
15557 (Bug#8227).
15558 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 15559
524c7aa6
PE
15560 * alloc.c (mark_fringe_data): Move decl from here ...
15561 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
15562 to check its interface.
15563 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
15564
a5c0af81 15565 * fontset.c (free_realized_fontset): Now static.
7519b8cd 15566 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 15567 (fontset_font): Mark local as initialized.
a9a06e0b 15568 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 15569
b4716021
PE
15570 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
15571
811e9bac 15572 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 15573 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
15574 (x_own_selection, Fx_disown_selection_internal): Rename locals
15575 to avoid shadowing.
15576 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 15577
7e3ab302
PE
15578 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
15579 so that the caller can use some name other than gcpro1.
15580 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
15581 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15582 (Fx_backspace_delete_keys_p):
15583 Use them to avoid shadowing, and rename vars to avoid shadowing.
15584 (x_decode_color, x_set_name, x_window): Now static.
6b437900 15585 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 15586 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
15587 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
15588 Remove unused locals.
7e3ab302
PE
15589 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15590 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
15591 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
15592 macros.
f78faa98 15593
e2b13473
PE
15594 * xterm.h (x_mouse_leave): New decl.
15595
77f23912
PE
15596 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
15597 Remove unused functions.
cdf4ba58
PE
15598 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
15599 (x_calc_absolute_position): Now static.
7411c686 15600 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 15601 Don't declare local "event" unless it's used.
ed7bf3a5
PE
15602 (x_iconify_frame, x_free_frame_resources): Don't declare locals
15603 unless they are used.
38d0b34a
PE
15604 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
15605 (x_fatal_error_signal): Remove; not used.
a6067996
PE
15606 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
15607 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
15608 (x_error_catcher, x_connection_closed, x_error_handler):
15609 (x_error_quitter, xembed_send_message, x_iconify_frame):
15610 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 15611 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 15612 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 15613
44f230aa
SM
15614 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
15615 Rename or move locals to avoid shadowing.
6b463e58 15616 (tty_defined_color, merge_face_heights): Now static.
5967d051 15617 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
15618 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
15619 does not deduce is never used uninitialized.
73719eba
PE
15620 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
15621 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 15622
426994c3 15623 * terminal.c (store_terminal_param): Now static.
5489860b 15624
032f1620 15625 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 15626 (set_frame_menubar): Remove unused local.
d4323972 15627 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
15628 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
15629 since they might point to immutable storage.
281585b0
PE
15630 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
15631 since it's unused otherwise.
032f1620 15632
367c19e5 15633 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 15634 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
15635 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
15636 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 15637 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
15638 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
15639 does not deduce are never used uninitialized.
70739cbe 15640
07b48fa9
PE
15641 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
15642
8868a238 15643 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
15644 * window.c (window_loop, size_window):
15645 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 15646
7e5cf297 15647 * window.c (display_buffer): Now static.
d6550a9f
PE
15648 (size_window): Mark variables that gcc -Wuninitialized
15649 does not deduce are never used uninitialized.
a586633d
PE
15650 * window.h (check_all_windows): New decl, to forestall
15651 gcc -Wmissing-prototypes diagnostic.
5b555da1 15652 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 15653
f6095868
PE
15654 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
15655 shadowing.
15656 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
15657 Include <limits.h>.
15658 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
15659 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
15660 (load_charset_map): Mark variables that gcc -Wuninitialized
15661 does not deduce are never used uninitialized.
53df7c11 15662 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 15663
f38b440c
PE
15664 * coding.c (coding_set_source, coding_set_destination):
15665 Use "else { /* comment */ }" rather than "else /* comment */;"
15666 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
15667 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
15668 a block, when the outer 'i' will do.
15669 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
15670 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
15671 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
15672 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
15673 (Fdecode_sjis_char, Fdefine_coding_system_internal):
15674 Rename locals to avoid shadowing.
15675 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
15676 * coding.c (emacs_mule_char, encode_invocation_designation):
15677 Now static, since they're not used elsewhere.
413bb2db 15678 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 15679 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
15680 (decode_coding_emacs_mule): Mark variables that gcc
15681 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
15682 (detect_coding_iso_2022): Initialize a local variable that might
15683 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 15684 this initialization is needed. (Bug#8211)
5f58e762
PE
15685 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
15686 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
15687 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
15688 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
15689 Remove unused macros.
f38b440c 15690
232b38b9 15691 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 15692 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 15693 * character.c (string_count_byte8): Likewise.
232b38b9 15694
fb90da1b
PE
15695 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
15696 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
15697
fb93dbc2
PE
15698 * chartab.c (copy_sub_char_table): Now static, since it's not used
15699 elsewhere.
5c156ace
PE
15700 (sub_char_table_ref_and_range, char_table_ref_and_range):
15701 Rename locals to avoid shadowing.
bbcd0949 15702 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 15703
7d3b3862 15704 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 15705 (BIDI_BOB): Remove unused macro.
7d3b3862 15706
6be7d3da
PE
15707 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
15708 deduce are never used uninitialized.
c2ed9c8b 15709 * term.c (encode_terminal_code): Likewise.
6be7d3da 15710
75f8807f 15711 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 15712
50938595
PE
15713 * tparam.h: New file.
15714 * term.c, tparam.h: Include it.
15715 * deps.mk (term.o, tparam.o): Depend on tparam.h.
15716 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
15717 Move these decls to tparam.h, and make them agree with what
15718 is actually in tparam.c. The previous trick of using incompatible
15719 decls in different modules does not conform to the C standard.
15720 All callers of tparam changed to use tparam's actual API.
15721 * tparam.c (tparam1, tparam, tgoto):
15722 Use const pointers where appropriate.
15723
fbceeba2
PE
15724 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
15725 * cm.h (struct cm): Likewise.
15726 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
15727 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
15728 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
15729 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
15730 (turn_on_face, init_tty): Likewise.
15731 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 15732
7f3f1250
PE
15733 * term.c (term_mouse_position): Rename local to avoid shadowing.
15734
e6ca6543
PE
15735 * alloc.c (mark_ttys): Move decl from here ...
15736 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
15737
c40f8d15
AS
157382011-03-11 Andreas Schwab <schwab@linux-m68k.org>
15739
15740 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
15741
cfe0661d
JB
157422011-03-09 Juanma Barranquero <lekktu@gmail.com>
15743
15744 * search.c (compile_pattern_1): Remove argument regp, unused since
15745 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
15746 (compile_pattern): Don't pass it.
15747
0afb4571
J
157482011-03-08 Jan Djärv <jan.h.d@swipnet.se>
15749
15750 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
15751 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
15752 for ! HAVE_GTK3.
15753 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
15754
15755 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
15756
15757 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
15758 gdk_window_get_screen, gdk_window_get_geometry,
15759 gdk_x11_window_lookup_for_display and GDK_KEY_g.
15760 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
15761 (xg_get_pixbuf_from_pixmap): New function.
15762 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
15763 to Pixmap, take frame as parameter, remove GdkColormap parameter.
15764 Call xg_get_pixbuf_from_pixmap instead of
15765 gdk_pixbuf_get_from_drawable.
15766 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
15767 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
15768 (xg_check_special_colors): Use GtkStyleContext and its functions
15769 for HAVE_GTK3.
15770 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
15771 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
15772 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
15773 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
15774 Call gtk_widget_get_preferred_size.
0afb4571
J
15775 (xg_frame_resized): gdk_window_get_geometry only takes 5
15776 parameters.
44f230aa
SM
15777 (xg_win_to_widget, xg_event_is_for_menubar):
15778 Call gdk_x11_window_lookup_for_display.
0afb4571
J
15779 (xg_set_widget_bg): New function.
15780 (delete_cb): New function.
895009e1 15781 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 15782 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
15783 (xg_set_background_color): Call xg_set_widget_bg.
15784 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
15785 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
15786 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
15787 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
15788 if ! HAVE_GTK3.
15789 (update_frame_tool_bar): Call gtk_widget_hide.
15790 (xg_initialize): Use GDK_KEY_g.
15791
15792 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
15793 if ! HAVE_GTK3
15794 (x_session_initialize): Call gdk_x11_set_sm_client_id.
15795
15796 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
15797 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
15798 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
15799
1c2cc4ef
JB
158002011-03-08 Juanma Barranquero <lekktu@gmail.com>
15801
15802 * w32xfns.c (select_palette): Check success of RealizePalette against
15803 GDI_ERROR, not zero.
15804
33383987 15805See ChangeLog.11 for earlier changes.
aac0c6e3
MR
15806
15807;; Local Variables:
15808;; coding: utf-8
aac0c6e3
MR
15809;; End:
15810
2f097256 15811 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
15812
15813 This file is part of GNU Emacs.
15814
15815 GNU Emacs is free software: you can redistribute it and/or modify
15816 it under the terms of the GNU General Public License as published by
15817 the Free Software Foundation, either version 3 of the License, or
15818 (at your option) any later version.
15819
15820 GNU Emacs is distributed in the hope that it will be useful,
15821 but WITHOUT ANY WARRANTY; without even the implied warranty of
15822 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15823 GNU General Public License for more details.
15824
15825 You should have received a copy of the GNU General Public License
15826 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.