* insdel.c: Omit unnecessary forward decls, to simplify future changes.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
e39e811e
PE
12011-06-18 Paul Eggert <eggert@cs.ucla.edu>
2
53b2623d
PE
3 * indent.c (sane_tab_width): New function.
4 (current_column, scan_for_column, Findent_to, position_indentation)
5 (compute_motion): Use it. This is just for clarity.
6
45aebb64
PE
7 * image.c (xbm_image_p): Don't assume stated width and height fit in int.
8
f2ed8a70
PE
9 * lisp.h (lint_assume): New macro.
10 * composite.c (composition_gstring_put_cache):
11 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
12
abe80cc6
PE
13 * editfns.c, insdel.c:
14 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 15
b02c740e
PE
16 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
17
ebc96716
PE
18 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
19
b4e50fa0 20 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 21 Use much-faster test for byte-length change.
311d5d7c 22 Don't assume string byte-length fits in 'int'.
a4cf38e4 23 Check that character arg fits in 'int'.
85461888 24 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 25
c0c1ee9f
PE
26 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
27
a498d7f4
PE
28 * fns.c (concat): Catch string overflow earlier.
29 Do not rely on integer wraparound.
30
e39e811e
PE
31 * dispextern.h (struct it.overlay_strings_charpos): EMACS_INT, not int.
32
fadf4e30
PE
332011-06-17 Paul Eggert <eggert@cs.ucla.edu>
34
87830974
PE
35 * dispextern.h (struct it.selective): Now EMACS_INT, not int.
36 * xdisp.c (forward_to_next_line_start)
37 (back_to_previous_visible_line_start)
38 (reseat_at_next_visible_line_start, next_element_from_buffer):
39 Don't arbitrarily truncate the value of 'selective' to int.
40
76031fad
PE
41 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
42
5eb55db9
PE
43 * composite.c: Don't truncate sizes to 'int'.
44 (composition_gstring_p, composition_reseat_it)
45 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
46 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
47 not EMACS_UINT, for indexes.
5eb55db9 48
0703a717
PE
49 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
50
d6202519
PE
51 * buffer.c: Include <verify.h>.
52 (struct sortvec.priority, struct sortstr.priority):
8961a454 53 Now EMACS_INT, not int.
c20998a7 54 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
55 (struct sortstr.size, record_overlay_string)
56 (struct sortstrlist.size, struct sortlist.used):
57 Don't truncate size to int.
58 (record_overlay_string): Check for size-calculation overflow.
d6202519 59 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 60
28177add
PE
612011-06-16 Paul Eggert <eggert@cs.ucla.edu>
62
dd3482fe
PE
63 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
64 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
65 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
66
393d71f3 67 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
68 * fileio.c (Finsert_file_contents):
69 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
70 Remove the old (too-loose) buffer overflow checks.
71 They weren't needed, since make_gap checks for buffer overflow.
72 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
73 The old code merely checked for Emacs fixnum overflow, and relied
74 on undefined (wraparound) behavior. The new code avoids undefined
75 behavior, and also checks for ptrdiff_t and/or size_t overflow.
76
2e6813b0 77 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
78 Tune. Don't use wider integers than needed. Don't use alloca.
79 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 80
599a9e4f
PE
81 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
82
99561444
PE
83 * insdel.c, lisp.h (buffer_overflow): New function.
84 (insert_from_buffer_1, replace_range, replace_range_2):
85 * insdel.c (make_gap_larger):
86 * editfns.c (Finsert_char):
87 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
88
28177add
PE
89 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
90
e69dafad
PE
912011-06-15 Paul Eggert <eggert@cs.ucla.edu>
92
a7af7fde 93 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 94
b1c46f02
PE
95 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
96 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
97
e69dafad
PE
98 * fileio.c: Don't assume EMACS_INT fits in off_t.
99 (emacs_lseek): New static function.
100 (Finsert_file_contents, Fwrite_region): Use it.
101 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
102
566684ea
PE
103 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
104
e6966cd6
PE
105 * fns.c: Don't overflow int when computing a list length.
106 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
107 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
108 truncation on 64-bit hosts. Check for QUIT every
109 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
110 faster and is responsive enough.
111 (Flength): Report an error instead of overflowing an integer.
112 (Fsafe_length): Return a float if the value is not representable
113 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 114 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 115 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 116
dd0b0efb
PE
117 * alloc.c: Check that resized vectors' lengths fit in fixnums.
118 (header_size, word_size): New constants.
119 (allocate_vectorlike): Don't check size overflow here.
120 (allocate_vector): Check it here instead, since this is the only
121 caller of allocate_vectorlike that could cause overflow.
122 Check that the new vector's length is representable as a fixnum.
123
86fe5cfe
PE
124 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
125 The previous code was bogus. For example, next_almost_prime (32)
126 returned 39, which is undesirable as it is a multiple of 3; and
127 next_almost_prime (24) returned 25, which is a multiple of 5 so
128 why was the code bothering to check for multiples of 7?
129
80e88859
PE
130 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
131
4a2f0ad6
PE
132 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
133
f66c7cf8
PE
134 Variadic C functions now count arguments with ptrdiff_t.
135 This partly undoes my 2011-03-30 change, which replaced int with size_t.
136 Back then I didn't know that the Emacs coding style prefers signed int.
137 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
138 were being counted with int, which may truncate counts on 64-bit
139 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
140 * lisp.h (struct Lisp_Subr.function.aMANY)
141 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
142 Arg counts are now ptrdiff_t, not size_t.
143 All variadic functions and their callers changed accordingly.
144 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
145 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
146 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
147 * callint.c (Fcall_interactively): Check arg count for overflow,
148 to avoid potential buffer overrun. Use signed char, not 'int',
149 for 'varies' array, so that we needn't bother to check its size
150 calculation for overflow.
151 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
152 * eval.c (apply_lambda):
153 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
154 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
155 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
156
a1759b76
PE
157 * callint.c (Fcall_interactively): Don't use index var as event count.
158
d96be9fc
PE
159 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
160 * mem-limits.h (SIZE): Remove; no longer used.
161
a690a978 162 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 163
578c21e6
PE
164 Remove unnecessary casts.
165 * xterm.c (x_term_init):
166 * xfns.c (x_set_border_pixel):
167 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
168 These aren't needed now that we assume ANSI C.
169
96f53c6c
PE
170 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
171 It's more likely to cause problems (due to unsigned overflow)
172 than to cure them.
173
83c77d31
PE
174 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
175
ee2079f1
PE
176 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
177
6da65536
PE
178 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
179
7147c4a4
PE
180 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
181
193e32d9
PE
182 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
183
e5533da6
PE
184 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
185
9910e595
PE
186 GLYPH_CODE_FACE returns EMACS_INT, not int.
187 * dispextern.h (merge_faces):
188 * xfaces.c (merge_faces):
01103c44
PE
189 * xdisp.c (get_next_display_element, next_element_from_display_vector):
190 Don't assume EMACS_INT fits in int.
9910e595 191
2638320e
PE
192 * character.h (CHAR_VALID_P): Remove unused parameter.
193 * fontset.c, lisp.h, xdisp.c: All uses changed.
194
045eb8d9
PE
195 * editfns.c (Ftranslate_region_internal): Omit redundant test.
196
c1f134b5
PE
197 * fns.c (concat): Minor tuning based on overflow analysis.
198 This doesn't fix any bugs. Use int to hold character, instead
199 of constantly refetching from Emacs object. Use XFASTINT, not
200 XINT, for value known to be a character. Don't bother comparing
201 a single byte to 0400, as it's always less.
202
395fcb93 203 * floatfns.c (Fexpt):
327eeec8
PE
204 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
205
abbd3d23
PE
206 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
207 for characters.
208
684a03ef
PE
209 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
210
0fed43f3
PE
211 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
212 Without this fix, on a 64-bit host (aset S 0 4294967386) would
213 incorrectly succeed when S was a string, because 4294967386 was
214 truncated before it was used.
215
8fd02eb7
PE
216 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
217 Otherwise, an out-of-range integer could cause undefined behavior
218 on a 64-bit host.
219
f8c86b69
PE
220 * composite.c: Use int, not EMACS_INT, for characters.
221 (fill_gstring_body, composition_compute_stop_pos): Use int, not
222 EMACS_INT, for values that are known to be in character range.
223 This doesn't fix any bugs but is the usual style inside Emacs and
224 may generate better code on 32-bit machines.
225
34206dd2
PE
226 Make sure a 64-bit char is never passed to ENCODE_CHAR.
227 This is for reasons similar to the recent CHAR_STRING fix.
228 * charset.c (Fencode_char): Check that character arg is actually
229 a character. Pass an int to ENCODE_CHAR.
230 * charset.h (ENCODE_CHAR): Verify that the character argument is no
231 wider than 'int', as a compile-time check to prevent future regressions
232 in this area.
233
c5958d4c 234 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
235
236 Make sure a 64-bit char is never passed to CHAR_STRING.
237 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
238 by silently ignoring the top 32 bits, allowing some values
239 that were far too large to be valid characters.
240 * character.h: Include <verify.h>.
241 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
242 arguments are no wider than unsigned, as a compile-time check
243 to prevent future regressions in this area.
244 * data.c (Faset):
01103c44 245 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
246 (Fsubst_char_in_region):
247 * fns.c (concat):
248 * xdisp.c (decode_mode_spec_coding):
249 Adjust to CHAR_STRING's new requirement.
250 * editfns.c (Finsert_char, Fsubst_char_in_region):
251 * fns.c (concat): Check that character args are actually
252 characters. Without this test, these functions did the wrong
253 thing with wildly out-of-range values on 64-bit hosts.
254
d37ca623
PE
255 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
256 These casts should not be needed on 32-bit hosts, either.
257 * keyboard.c (read_char):
258 * lread.c (Fload): Remove casts to unsigned.
259
ea204efb
PE
260 * lisp.h (UNSIGNED_CMP): New macro.
261 This fixes comparison bugs on 64-bit hosts.
262 (ASCII_CHAR_P): Use it.
263 * casefiddle.c (casify_object):
01103c44 264 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
265 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
266 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
267 * dispextern.h (FACE_FROM_ID):
268 * keyboard.c (read_char): Use UNSIGNED_CMP.
269
41cb286c
PE
270 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
271 not to EMACS_INT, to avoid GCC warning.
272
4a1b9832
PE
273 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
274
55daad71
PE
275 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
276 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
277 isn't needed on 32-bit machines.
8f95c75c 278
01103c44
PE
279 * buffer.c (Fgenerate_new_buffer_name):
280 Use EMACS_INT for count, not int.
0ceccced 281 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
282
283 * data.c (Qcompiled_function): Now static.
284
c6f072e7
PE
285 * window.c (window_body_lines): Now static.
286
20ce5912
PE
287 * image.c (gif_load): Rename local to avoid shadowing.
288
9c4c5f81
PE
289 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
290 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
291 * alloc.c (make_save_value): Integer argument is now of type
292 ptrdiff_t, not int.
293 (mark_object): Use ptrdiff_t, not int.
294 * lisp.h (pD): New macro.
295 * print.c (print_object): Use it.
296
c0c5c8ae
PE
297 * alloc.c: Use EMACS_INT, not int, to count objects.
298 (total_conses, total_markers, total_symbols, total_vector_size)
299 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
300 (total_free_floats, total_floats, total_free_intervals)
301 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
302 Now EMACS_INT, not int. All uses changed.
303 (Fgarbage_collect): Compute overall total using a double, so that
304 integer overflow is less likely to be a problem. Check for overflow
305 when converting back to an integer.
5a25e253
PE
306 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
307 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
308 These were 'int' variables that could overflow on 64-bit hosts;
309 they were never used, so remove them instead of repairing them.
211a0b2a 310 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
311 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
312 Previously, this ceilinged at INT_MAX, but that doesn't work on
313 64-bit machines.
e46bb31a 314 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 315
c78baabf 316 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 317 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
318 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
319 when a (possibly-narrower) signed value would do just as well.
320 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 321
c9d624c6
PE
322 * alloc.c: Catch some string size overflows that we were missing.
323 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
324 for convenience in STRING_BYTES_MAX.
325 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
326 The definition here is exact; the one in lisp.h was approximate.
327 (allocate_string_data): Check for string overflow. This catches
328 some instances we weren't catching before. Also, it catches
329 size_t overflow on (unusual) hosts where SIZE_MAX <= min
330 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
331 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 332
c9d624c6
PE
333 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
334 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
335 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
336
353032ce
PE
337 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
338
2bccce07
PE
339 * alloc.c (Fmake_string): Check for out-of-range init.
340
0ac30604
SM
3412011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
342
343 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
344
c195f2de
JD
3452011-06-14 Jan Djärv <jan.h.d@swipnet.se>
346
347 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
348 xg_get_default_scrollbar_width.
349
350 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
351 (int_gtk_range_get_value): Move to the scroll bar part of the file.
352 (style_changed_cb): Call update_theme_scrollbar_width and call
353 x_set_scroll_bar_default_width and xg_frame_set_char_size for
354 all frames (Bug#8505).
355 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
356 Call gtk_window_set_resizable if HAVE_GTK3.
357 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
358 and height if HAVE_GTK3 (Bug#8505).
359 (scroll_bar_width_for_theme): New variable.
360 (update_theme_scrollbar_width): New function.
361 (xg_get_default_scrollbar_width): Move code to
362 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
363 (xg_initialize): Call update_theme_scrollbar_width.
364
365 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
366
367 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
368
e10ac9f1
MR
3692011-06-12 Martin Rudalics <rudalics@gmx.at>
370
371 * frame.c (make_frame): Call other_buffer_safely instead of
372 other_buffer.
373
374 * window.c (temp_output_buffer_show): Call display_buffer with
375 second argument Vtemp_buffer_show_specifiers and reset latter
376 immediately after the call.
377 (Vtemp_buffer_show_specifiers): New variable.
378 (auto_window_vscroll_p, next_screen_context_lines)
379 (Vscroll_preserve_screen_position): Remove leading asterisks from
380 doc-strings.
381
2d3c217e 3822011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 383
7b7f97e8 384 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
385 * buffer.c (Qclone_number): Remove for now, as it's unused.
386 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
387 (record_buffer): Remove unused local.
388 * frame.c (other_visible_frames, frame_buffer_list): Now static.
389 (set_frame_buffer_list): Remove; unused.
390 * frame.h (other_visible_frames): Remove decl.
391 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
392 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
393 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
394 if HAVE_GPM.
395 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
396 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
397 Define only if HAVE_GPM.
398 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
399 (update_hints_inhibit): Remove; never set. All uses removed.
400 * widgetprv.h (emacsFrameClassRec): Remove decl.
401 * window.c (delete_deletable_window): Now returns void, since it
402 wasn't returning anything.
403 (compare_window_configurations): Remove unused locals.
404 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
405 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
406 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
407 the same widths as pointers. This follows up on the 2011-05-06 patch.
408 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
409 * xterm.h: Likewise.
410 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
411
1384b89e
JB
4122011-06-12 Juanma Barranquero <lekktu@gmail.com>
413
414 * makefile.w32-in: Update dependencies.
415 (LISP_H): Add lib/intprops.h.
416
1100a63c
CY
4172011-06-11 Chong Yidong <cyd@stupidchicken.com>
418
419 * image.c (gif_load): Add animation frame delay to the metadata.
420 (syms_of_image): Use DEFSYM. New symbol `delay'.
421
6198ccd0
MR
4222011-06-11 Martin Rudalics <rudalics@gmx.at>
423
424 * window.c (delete_deletable_window): Re-add.
425 (Fset_window_configuration): Rewrite to handle dead buffers and
426 consequently deletable windows.
427 (window_tree, Fwindow_tree): Remove. Supply functionality in
428 window.el.
429 (compare_window_configurations): Simplify code.
430
b6e3633c
AS
4312011-06-11 Andreas Schwab <schwab@linux-m68k.org>
432
1ab0dee5
AS
433 * image.c (imagemagick_load_image): Fix type mismatch.
434 (Fimagemagick_types): Likewise.
435
b6e3633c
AS
436 * window.h (replace_buffer_in_windows): Declare.
437
9397e56f
MR
4382011-06-11 Martin Rudalics <rudalics@gmx.at>
439
440 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
441 Qclone_number. Remove external declaration of Qdelete_window.
442 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
443 code.
444 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
445 Qbuffer_list_update_hook if allowed.
446 (Fother_buffer): Rewrite doc-string. Major rewrite for new
447 buffer list implementation.
448 (other_buffer_safely): New function.
449 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
450 calls to replace_buffer_in_windows and
451 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
452 if allowed.
453 (record_buffer): Inhibit quitting and rewrite using quittable
454 functions. Run Qbuffer_list_update_hook if allowed.
455 (Frecord_buffer, Funrecord_buffer): New functions.
456 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
457 switch-to-buffer to window.el.
458 (bury-buffer): Move to window.el.
459 (Vbuffer_list_update_hook): New variable.
460
461 * lisp.h (other_buffer_safely): Add prototype in buffer.c
462 section.
463
464 * window.h (resize_frame_windows): Move up in code.
465 (Fwindow_frame): Remove EXFUN.
466 (replace_buffer_in_all_windows): Remove prototype.
467 (replace_buffer_in_windows_safely): Add prototype.
468
469 * window.c: Declare Qdelete_window static again. Move down
470 declaration of select_count.
471 (Fnext_window, Fprevious_window): Rewrite doc-strings.
472 (Fother_window): Move to window.el.
473 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
474 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
475 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
476 window.el.
477 (replace_buffer_in_windows): Implement by calling
478 Qreplace_buffer_in_windows.
479 (replace_buffer_in_all_windows): Remove with some functionality
480 moved into replace_buffer_in_windows_safely.
481 (replace_buffer_in_windows_safely): New function.
482 (select_window_norecord, select_frame_norecord): Move in front
483 of run_window_configuration_change_hook. Remove now obsolete
484 declarations.
485 (Fset_window_buffer): Rewrite doc-string. Call
486 Qrecord_window_buffer.
487 (keys_of_window): Move binding for other-window to window.el.
488
b50691aa
CY
4892011-06-11 Chong Yidong <cyd@stupidchicken.com>
490
491 * dispextern.h (struct image): Replace data member, whose int_val
492 and ptr_val fields were not used by anything, with a single
493 lisp_val object.
494
495 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
496 (gif_clear_image, gif_load, imagemagick_load_image)
497 (gs_clear_image, gs_load): Callers changed.
498
3f754b86
PE
4992011-06-10 Paul Eggert <eggert@cs.ucla.edu>
500
cca69397
PE
501 * buffer.h: Include <time.h>, for time_t.
502 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
503
109e28d0
PE
504 Fix minor problems found by static checking.
505
60737f02
PE
506 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
507
4b66faf3
PE
508 Make identifiers static if they are not used in other modules.
509 * data.c (Qcompiled_function, Qframe, Qvector):
510 * image.c (QimageMagick, Qsvg):
511 * minibuf.c (Qmetadata):
512 * window.c (resize_window_check, resize_root_window): Now static.
513 * window.h (resize_window_check, resize_root_window): Remove decls.
514
109e28d0
PE
515 * window.c (window_deletion_count, delete_deletable_window):
516 Remove; unused.
46a4ce9e
PE
517 (window_body_lines): Now static.
518 (Fdelete_other_windows_internal): Mark vars as initialized.
519 Make sure 'resize_failed' is initialized.
520 (run_window_configuration_change_hook): Rename local to avoid shadowing.
521 (resize_window_apply): Remove unused local.
522 * window.h (delete_deletable_window): Remove decl.
523
109e28d0 524 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
525 (imagemagick_load_image): Fix pointer signedness problem by changing
526 last arg from unsigned char * to char *. All uses changed.
527 Also, fix a local for similar reasons.
528 Remove unused locals. Remove locals to avoid shadowing.
529 (fn_rsvg_handle_free): Remove; unused.
530 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 531 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 532
3f754b86
PE
533 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
534
2547adb1
CY
5352011-06-10 Chong Yidong <cyd@stupidchicken.com>
536
537 * image.c (gif_load): Fix omitted cast error introduced by
538 2011-06-06 change.
539
2c8e37d4
MR
5402011-06-10 Martin Rudalics <rudalics@gmx.at>
541
542 * window.h (resize_proportionally, orig_total_lines)
543 (orig_top_line): Remove from window structure.
544 (set_window_height, set_window_width, change_window_heights)
545 (Fdelete_window): Remove prototypes.
546 (resize_frame_windows): Remove duplicate declaration.
547
440a42e3
EZ
5482011-06-10 Eli Zaretskii <eliz@gnu.org>
549
550 * window.h (resize_frame_windows, resize_window_check)
551 (delete_deletable_window, resize_root_window)
552 (resize_frame_windows): Declare prototypes.
553
554 * window.c (resize_window_apply): Make definition be "static" to
555 match the prototype.
556
562dd5e9
MR
5572011-06-10 Martin Rudalics <rudalics@gmx.at>
558
559 * window.c: Remove declarations of Qwindow_size_fixed,
560 window_min_size_1, window_min_size_2, window_min_size,
561 size_window, window_fixed_size_p, enlarge_window, delete_window.
562 Remove static from declaration of Qdelete_window, it's
563 temporarily needed by Fbury_buffer.
564 (replace_window): Don't assign orig_top_line and
565 orig_total_lines.
566 (Fdelete_window, delete_window): Remove. Window deletion is
567 handled by window.el.
568 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
569 Fdelete_window calls with calls to Qdelete_window.
570 (Fdelete_other_windows): Remove. Deleting other windows is
571 handled by window.el.
572 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
573 handled in window.el.
574 (window_min_size_2, window_min_size_1, window_min_size): Remove.
575 Window minimum sizes are handled in window.el.
576 (shrink_windows, size_window, set_window_height)
577 (set_window_width, change_window_heights, window_height)
578 (window_width, CURBEG, CURSIZE, enlarge_window)
579 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
580 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
581 handled in window.el.
582 (make_dummy_parent): Rename to make_parent_window and give it a
583 second argument horflag.
584 (make_window): Don't set resize_proportionally any more.
585 (Fsplit_window): Remove. Windows are split in window.el.
586 (save_restore_action, save_restore_orig_size)
587 (shrink_window_lowest_first, save_restore_orig_size): Remove.
588 Resize mini windows in window.el.
589 (grow_mini_window, shrink_mini_window): Implement by calling
590 Qresize_root_window_vertically, resize_window_check and
591 resize_window_apply.
592 (saved_window, Fset_window_configuration, save_window_save): Do
593 not handle orig_top_line, orig_total_lines, and
594 resize_proportionally.
595 (window_min_height, window_min_width): Move to window.el.
596 (keys_of_window): Move bindings for delete-other-windows,
597 split-window, delete-window and enlarge-window to window.el.
598
599 * buffer.c: Temporarily extern Qdelete_window.
600 (Fbury_buffer): Temporarily call Qdelete_window instead of
601 Fdelete_window (Fbury_buffer will move to window.el soon).
602
603 * frame.c (set_menu_bar_lines_1): Remove code handling
604 orig_top_line and orig_total_lines.
605
606 * dispnew.c (adjust_frame_glyphs_initially): Don't use
607 set_window_height but set heights directly.
608 (change_frame_size_1): Use resize_frame_windows.
609
610 * xdisp.c (init_xdisp): Don't use set_window_height but set
611 heights directly.
612
613 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
614 resize_frame_windows instead of change_window_heights and run
615 run_window_configuration_change_hook.
616
617 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
618 instead of change_window_heights and run
619 run_window_configuration_change_hook.
620
1a13852e
MR
6212011-06-09 Martin Rudalics <rudalics@gmx.at>
622
623 * window.c (replace_window): Rename second argument REPLACEMENT to
624 NEW. New third argument SETFLAG. Rewrite.
625 (delete_window, make_dummy_parent): Call replace_window with
626 third argument 1.
627 (window_list_1): Move down in code.
628 (run_window_configuration_change_hook): Move set_buffer part
629 before select_frame_norecord part in order to unwind correctly.
630 Rename count1 to count.
631 (recombine_windows, delete_deletable_window, resize_root_window)
632 (Fdelete_other_windows_internal)
633 (Frun_window_configuration_change_hook, make_parent_window)
634 (resize_window_check, resize_window_apply, Fresize_window_apply)
635 (resize_frame_windows, Fsplit_window_internal)
636 (Fdelete_window_internal, Fresize_mini_window_internal): New
637 functions.
638 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
639
f3d1777e
MR
6402011-06-08 Martin Rudalics <rudalics@gmx.at>
641
496e208e
MR
642 * window.h (window): Add some new members to window structure -
643 normal_lines, normal_cols, new_total, new_normal, clone_number,
644 splits, nest, prev_buffers, next_buffers.
645 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 646 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 647
f3d1777e
MR
648 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
649 Remove.
496e208e
MR
650 (make_dummy_parent): Set new members of windows structure.
651 (make_window): Move down in code. Handle new members of window
652 structure.
653 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
654 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
655 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
656 (Fset_window_prev_buffers, Fwindow_next_buffers)
657 (Fset_window_next_buffers, Fset_window_clone_number): New
658 functions.
659 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
660 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
661 Doc-string fixes.
662 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
663 Argument WINDOW can be now internal window too.
664 (Fwindow_use_time): Move up in code.
665 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
666 Rewrite doc-string.
667 (Fset_window_configuration, saved_window)
668 (Fcurrent_window_configuration, save_window_save): Handle new
669 members of window structure.
b9e809c2
MR
670 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
671 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
672 (syms_of_window): New Lisp objects Qrecord_window_buffer,
673 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
674 Qget_mru_window, Qresize_root_window,
675 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
676 Qauto_buffer_name; staticpro them.
f3d1777e 677
abde8f8c
MR
6782011-06-07 Martin Rudalics <rudalics@gmx.at>
679
680 * window.c (Fwindow_total_size, Fwindow_left_column)
681 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
682 (Fwindow_list_1): New functions.
683 (window_box_text_cols): Replace with window_body_cols.
684 (Fwindow_width, Fscroll_left, Fscroll_right): Use
685 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
686 (delete_window, Fset_window_configuration): Call
687 delete_all_subwindows with window as argument.
688 (delete_all_subwindows): Take a window as argument and not a
689 structure. Rewrite.
190b47e6
MR
690 (window_loop): Remove handling of GET_LRU_WINDOW and
691 GET_LARGEST_WINDOW.
692 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
693
694 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
695 window_box_text_cols. delete_all_subwindows now takes a
696 Lisp_Object as argument.
abde8f8c
MR
697
698 * indent.c (compute_motion, Fcompute_motion): Use
699 window_body_cols instead of window_box_text_cols.
700
fa8a67e6
MR
701 * frame.c (delete_frame): Call delete_all_subwindows with root
702 window as argument.
703
a54e3482
DC
7042011-06-07 Daniel Colascione <dan.colascione@gmail.com>
705
706 * fns.c (Fputhash): Document return value.
707
60002bf5
CY
7082011-06-06 Chong Yidong <cyd@stupidchicken.com>
709
710 * image.c (gif_load): Implement gif89a spec "no disposal" method.
711
0c671da6 7122011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 713
b862a52a 714 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 715
be44ca6c
PE
716 Check for overflow when converting integer to cons and back.
717 * charset.c (Fdefine_charset_internal, Fdecode_char):
718 Use cons_to_unsigned to catch overflow.
719 (Fencode_char): Use INTEGER_TO_CONS.
720 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
721 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
722 * data.c (long_to_cons, cons_to_long): Remove.
723 (cons_to_unsigned, cons_to_signed): New functions.
724 These signal an error for invalid or out-of-range values.
725 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
726 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
727 * font.c (Ffont_variation_glyphs):
728 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
729 * lisp.h: Include <intprops.h>.
730 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
731 (cons_to_signed, cons_to_unsigned): New decls.
732 (long_to_cons, cons_to_long): Remove decls.
733 * undo.c (record_first_change): Use INTEGER_TO_CONS.
734 (Fprimitive_undo): Use CONS_TO_INTEGER.
735 * xfns.c (Fx_window_property): Likewise.
736 * xselect.c: Include <limits.h>.
737 (x_own_selection, selection_data_to_lisp_data):
738 Use INTEGER_TO_CONS.
739 (x_handle_selection_request, x_handle_selection_clear)
740 (x_get_foreign_selection, Fx_disown_selection_internal)
741 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
742 (lisp_data_to_selection_data): Use cons_to_unsigned.
743 (x_fill_property_data): Use cons_to_signed.
744 Report values out of range.
745
d1f3d2af
PE
746 Check for buffer and string overflow more precisely.
747 * buffer.h (BUF_BYTES_MAX): New macro.
748 * lisp.h (STRING_BYTES_MAX): New macro.
749 * alloc.c (Fmake_string):
750 * character.c (string_escape_byte8):
751 * coding.c (coding_alloc_by_realloc):
752 * doprnt.c (doprnt):
753 * editfns.c (Fformat):
754 * eval.c (verror):
755 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
756 since they may not be the same number.
757 * editfns.c (Finsert_char):
758 * fileio.c (Finsert_file_contents):
759 Likewise for BUF_BYTES_MAX.
760
dd52fcea
PE
761 * image.c: Use ptrdiff_t, not int, for sizes.
762 (slurp_file): Switch from int to ptrdiff_t.
763 All uses changed.
764 (slurp_file): Check that file size fits in both size_t (for
765 malloc) and ptrdiff_t (for sanity and safety).
766
7f9bbdbb
PE
767 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
768 if b->modtime has its maximal value.
769
dfe18f82
PE
770 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
771
84acfcf0
PE
772 Don't assume time_t can fit into int.
773 * buffer.h (struct buffer.modtime): Now time_t, not int.
774 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
775 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
776
ccd9a01a
PE
777 Minor fixes for signed vs unsigned integers.
778 * character.h (MAYBE_UNIFY_CHAR):
779 * charset.c (maybe_unify_char):
780 * keyboard.c (read_char, reorder_modifiers):
781 XINT -> XFASTINT, since the integer must be nonnegative.
782 * ftfont.c (ftfont_spec_pattern):
783 * keymap.c (access_keymap, silly_event_symbol_error):
784 XUINT -> XFASTINT, since the integer must be nonnegative.
785 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
786 since it makes no difference and we prefer signed.
787 * keyboard.c (record_char): Use XUINT when all the neighbors do.
788 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
789 nonnegative.
790
d6d100dd
SM
7912011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
792
793 * window.h (Fwindow_frame): Declare.
794
2b6148e4
PE
7952011-06-06 Paul Eggert <eggert@cs.ucla.edu>
796
797 * alloc.c: Simplify handling of large-request failures (Bug#8800).
798 (SPARE_MEMORY): Always define.
799 (LARGE_REQUEST): Remove.
800 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
801
f230ecc9
MR
8022011-06-06 Martin Rudalics <rudalics@gmx.at>
803
727e958e
MR
804 * lisp.h: Move EXFUNS for Fframe_root_window,
805 Fframe_first_window and Fset_frame_selected_window to window.h.
806
807 * window.h: Move EXFUNS for Fframe_root_window,
808 Fframe_first_window and Fset_frame_selected_window here from
809 lisp.h.
810
811 * frame.c (Fwindow_frame, Fframe_first_window)
812 (Fframe_root_window, Fframe_selected_window)
813 (Fset_frame_selected_window): Move to window.c.
814 (Factive_minibuffer_window): Move to minibuf.c.
815 (Fother_visible_frames_p): New function.
816
817 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
818
f230ecc9
MR
819 * window.c (decode_window, decode_any_window): Move up in code.
820 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
821 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
822 (Fwindow_buffer): Move up and rewrite doc-string.
823 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
824 (Fwindow_prev): New functions.
727e958e
MR
825 (Fwindow_frame): Move here from frame.c. Accept any window as
826 argument.
827 (Fframe_root_window, Fframe_first_window)
828 (Fframe_selected_window): Move here from frame.c. Accept frame
829 or arbitrary window as argument. Update doc-strings.
830 (Fminibuffer_window): Move up in code.
831 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
832 (Fset_frame_selected_window): Move here from frame.c.
833 Marginal rewrite.
727e958e
MR
834 (Fselected_window, select_window, Fselect_window): Move up in
835 code. Minor doc-string fixes.
f230ecc9 836
4d09bcf6
PE
8372011-06-06 Paul Eggert <eggert@cs.ucla.edu>
838
839 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
840 Do not assume that spare memory exists; that assumption is valid
841 only if SYSTEM_MALLOC.
842 (LARGE_REQUEST): New macro, so that the issue of large requests
843 is separated from the issue of spare memory.
844
810928a2
AS
8452011-06-05 Andreas Schwab <schwab@linux-m68k.org>
846
172418ad
AS
847 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
848 format. (Bug#8806)
849
43f862f7
AS
850 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
851
810928a2
AS
852 * xfns.c (x_set_scroll_bar_default_width): Move declarations
853 before statements.
854
a059fe24
JD
8552011-06-05 Jan Djärv <jan.h.d@swipnet.se>
856
857 * gtkutil.c (xg_get_default_scrollbar_width): New function.
858
859 * gtkutil.h: Declare xg_get_default_scrollbar_width.
860
861 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
862 min width by calling x_set_scroll_bar_default_width (Bug#8505).
863
989bf368
JB
8642011-06-05 Juanma Barranquero <lekktu@gmail.com>
865
866 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
867
4b80f674
CY
8682011-06-04 Chong Yidong <cyd@stupidchicken.com>
869
870 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
871 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
872 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
873 New error handlers.
4b80f674
CY
874 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
875 Obey Vx_select_enable_clipboard_manager. Catch errors in
876 x_clipboard_manager_save (Bug#8779).
877 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 878 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 879
99a33b77 8802011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
881
882 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
883
99a33b77 8842011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
885
886 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
887 in the current matrix if keep_current_p is non-zero.
888
8264569d
EZ
8892011-06-04 Eli Zaretskii <eliz@gnu.org>
890
891 * bidi.c (bidi_level_of_next_char): Fix last change.
892
57f97249
EZ
8932011-06-03 Eli Zaretskii <eliz@gnu.org>
894
fec2107c 895 Support bidi reordering of text covered by display properties.
57f97249 896
fec2107c
EZ
897 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
898 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
899 (bidi_cache_search, bidi_cache_iterator_state)
900 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
901 (bidi_level_of_next_char, bidi_move_to_visually_next):
902 Support character positions inside a run of characters covered by a
fec2107c
EZ
903 display string.
904 (bidi_paragraph_init, bidi_resolve_explicit_1)
905 (bidi_level_of_next_char): Call bidi_fetch_char and
906 bidi_fetch_char_advance instead of FETCH_CHAR and
907 FETCH_CHAR_ADVANCE.
908 (bidi_init_it): Initialize new members.
909 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
910 definitions.
911 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
912 instead of using explicit *_CHAR codes.
d6d100dd
SM
913 (bidi_resolve_explicit, bidi_resolve_weak):
914 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
915 bidirectional text is supported only in multibyte buffers.
916 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
917 it to initialize the frame_window_p member of struct bidi_it.
918 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
919 (bidi_resolve_explicit, bidi_resolve_weak)
920 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
921 bidi_it->nchars is non-positive.
922 (bidi_level_of_next_char): Don't try to lookup the cache for the
923 next/previous character if nothing is cached there yet, or if we
924 were just reseat()'ed to a new position.
c40e2fb2 925
0e14fe90
EZ
926 * xdisp.c (set_cursor_from_row): Set start and stop points
927 according to the row's direction when priming the loop that looks
928 for the glyph on which to display cursor.
929 (single_display_spec_intangible_p): Function deleted.
930 (display_prop_intangible_p): Reimplement to call
931 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
932 Accept 3 additional arguments needed by handle_display_spec.
933 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
934 values: lists, `(when COND...)' forms, etc.
935 (single_display_spec_string_p): Support property values that are
936 lists with the argument STRING its top-level element.
937 (display_prop_string_p): Fix the condition for processing a
938 property that is a list to be consistent with handle_display_spec.
fec2107c 939 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
940 last portion of handle_display_prop.
941 (compute_display_string_pos): Accept additional argument
942 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
943 value of a `display' property is a "replacing spec".
944 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
945 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
946 the display property, but just return a value indicating whether
947 the display property will replace the characters it covers.
948 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
949 frame_window_p members of struct bidi_it.
d6d100dd
SM
950 (compute_display_string_pos, compute_display_string_end):
951 New functions.
fec2107c
EZ
952 (push_it): Accept second argument POSITION, where pop_it should
953 jump to continue iteration.
954 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 955
fec2107c
EZ
956 * keyboard.c (adjust_point_for_property): Adjust the call to
957 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
958
959 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
960 (bidi_init_it): Update prototypes.
961 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
962 (compute_display_string_pos, compute_display_string_end):
963 Declare prototypes.
fec2107c
EZ
964 (struct bidi_it): New members nchars and disp_pos. ch_len is now
965 EMACS_INT.
fc6f18ce 966
40087514 9672011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 968
57f53182
PE
969 Malloc failure behavior now depends on size of allocation.
970 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
971 * lisp.h: Change signatures accordingly.
972 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
973 All callers changed. (Bug#8762)
974
975 * gnutls.c: Use Emacs's memory allocators.
976 Without this change, the gnutls library would invoke malloc etc.
977 directly, which causes problems on non-SYNC_INPUT hosts, and which
978 runs afoul of improving memory_full behavior. (Bug#8761)
979 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
980 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
981 xfree instead of the default malloc, realloc, free.
982 (Fgnutls_boot): No need to check for memory allocation failure,
983 since xmalloc does that for us.
984
ac32cd99 985 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
986 * category.c (hash_get_category_set):
987 * ccl.c (ccl_driver):
988 * charset.c (Fdefine_charset_internal):
989 * charset.h (struct charset.hash_index):
990 * composite.c (get_composition_id, gstring_lookup_cache)
991 (composition_gstring_put_cache):
992 * composite.h (struct composition.hash_index):
993 * dispextern.h (struct image.hash):
994 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
995 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
996 (hashfn_equal, hashfn_user_defined, make_hash_table)
997 (maybe_resize_hash_table, hash_lookup, hash_put)
998 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
999 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1000 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1001 * image.c (make_image, search_image_cache, lookup_image)
1002 (xpm_put_color_table_h):
1003 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1004 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1005 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1006 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1007 * alloc.c (allocate_vectorlike):
1008 Check for overflow in vector size calculations.
1009 * ccl.c (ccl_driver):
1010 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1011 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1012 need to be updated by these changes.
40087514
PE
1013 * fns.c (make_hash_table, maybe_resize_hash_table):
1014 Check for integer overflow with large hash tables.
0de4bb68
PE
1015 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1016 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1017 (SXHASH_REDUCE): New macro.
1018 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1019 Use it instead of discarding useful hash info with large hash values.
1020 (sxhash_float): New function.
1021 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1022 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1023 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1024 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1025 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1026 Adjust signatures to match updated version of code.
1027 (consing_since_gc): Now EMACS_INT, since a single hash table can
1028 use more than INT_MAX bytes.
1029
698d32e2
DN
10302011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1031
1032 Make it possible to build with GCC-4.6+ -O2 -flto.
1033
1034 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1035
fd6fa53f
SM
10362011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1037
1038 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1039 Call minibuffer-inactive-mode.
1040
864db017
JB
10412011-05-31 Juanma Barranquero <lekktu@gmail.com>
1042
1043 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1044 Update dependencies.
1045
2ad0baf4
DN
10462011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1047
1048 * data.c (init_data): Remove code for UTS, this system is not
1049 supported anymore.
1050
4fcc2638
DN
10512011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1052
1053 Don't force ./temacs to start in terminal mode.
1054
1055 * frame.c (make_initial_frame): Initialize faces in all cases, not
1056 only when CANNOT_DUMP is defined.
1057 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1058
c56e0fd5
DN
10592011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1060
1061 * dispnew.c (add_window_display_history): Use const for the string
1062 pointer. Remove declaration, not needed.
1063
333d54da 10642011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1065
55d4c1b2 1066 Use 'inline', not 'INLINE'.
333d54da 1067 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1068 * alloc.c, fontset.c (INLINE): Remove.
1069 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1070 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1071 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1072 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1073 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1074
738db178
DN
10752011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1076
1077 Make it possible to run ./temacs.
1078
1079 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1080 syms_of_callproc does the same thing. Remove test for
1081 "initialized", do it in the caller.
1082 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1083
620c53a6
SM
10842011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1085
1086 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1087 (read_minibuf): Use get_minibuffer.
1088 (syms_of_minibuf): Use DEFSYM.
1089 (Qmetadata): New var.
1090 * data.c (Qbuffer): Don't make it static.
1091 (syms_of_data): Use DEFSYM.
1092
e003a292
PE
10932011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1094
1095 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1096 (CCL_CODE_MIN): New macro.
1097
ed008a6d
PE
10982011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1099
3687c2ef
PE
1100 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1101
ed008a6d
PE
1102 * eval.c (Qdebug): Now static.
1103 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1104 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1105 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1106
d66c4c7c
CY
11072011-05-29 Chong Yidong <cyd@stupidchicken.com>
1108
1109 * image.c: Various fixes to ImageMagick code comments.
1110 (Fimagemagick_types): Doc fix.
1111
5fbc2025
PE
11122011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1113
0196f88a
PE
1114 Minor fixes prompted by GCC 4.6.0 warnings.
1115
1116 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1117
5fbc2025
PE
1118 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1119 (x_clipboard_manager_save_all): Move extern decl to ...
1120 * xterm.h: ... here, so that it can be checked for consistency.
1121
1dd3c2d9
CY
11222011-05-29 Chong Yidong <cyd@stupidchicken.com>
1123
1124 * xselect.c (x_clipboard_manager_save_frame)
1125 (x_clipboard_manager_save_all): New functions.
1126 (Fx_clipboard_manager_save): Lisp function deleted.
1127
1128 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1129 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1130
1131 * xterm.h: Update prototype.
1132
5ba6571d
WX
11332011-05-28 William Xu <william.xwl@gmail.com>
1134
1135 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1136 exiting (Bug#8239).
1137
3eaff834
JM
11382011-05-28 Jim Meyering <meyering@redhat.com>
1139
e1900994 1140 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1141 * fns.c (to_uchar): Define.
1142 (crypto_hash_function): Use it to convert some newly-signed
1143 variables to unsigned, to avoid sign-extension bugs. For example,
1144 without this change, (md5 "truc") would evaluate to
1145 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1146 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1147 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1148
0f6990a7
PE
11492011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1150
1151 Integer overflow fixes.
c8a9ca5a 1152
08686060
PE
1153 * dbusbind.c: Serial number integer overflow fixes.
1154 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1155 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1156 to hold a serial number that is too large for a fixnum.
1157 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1158 Check for serial numbers out of range. Decode any serial number
59568bf0 1159 that was so large that it became a float. (Bug#8722)
08686060 1160
2d1fc3c7
PE
1161 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1162 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1163 Use XFASTINT rather than XUINT when numbers are nonnegative.
1164 (xd_append_arg, Fdbus_method_return_internal):
1165 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1166 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1167 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1168 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1169 (Bug#8722)
2d1fc3c7 1170
c8a9ca5a
PE
1171 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1172
519e1d69
PE
1173 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1174
30569699
PE
1175 ccl: add integer overflow checks
1176 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1177 (IN_INT_RANGE): New macros.
1178 (ccl_driver): Use them to check for integer overflow when
1179 decoding a CCL program. Many of the new checks are whether XINT (x)
1180 fits in int; it doesn't always, on 64-bit hosts. The new version
1181 doesn't catch all possible integer overflows, but it's an
847044ea 1182 improvement. (Bug#8719)
30569699 1183
c11285dc
PE
1184 * alloc.c (make_event_array): Use XINT, not XUINT.
1185 There's no need for unsigned here.
1186
fdccd48e
PE
1187 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1188 This follows up to the 2011-05-06 change that substituted uintptr_t
1189 for EMACS_INT. This case wasn't caught back then.
1190
37910ab2
PE
1191 Rework Fformat to avoid integer overflow issues.
1192 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1193 now (part of C89). Include <verify.h>.
1194 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1195 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1196 (Fformat): Avoid the prepass trying to compute sizes; it was only
1197 approximate and thus did not catch overflow reliably. Instead, walk
1198 through the format just once, formatting and computing sizes as we go,
1199 checking for integer overflow at every step, and allocating a larger
1200 buffer as needed. Keep track separately whether the format is
1201 multibyte. Keep only the most-recently calculated precision, rather
1202 than them all. Record whether each argument has been converted to
1203 string. Use EMACS_INT, not int, for byte and char and arg counts.
1204 Support field widths and precisions larger than INT_MAX. Avoid
1205 sprintf's undefined behavior with conversion specifications such as %#d
1206 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1207 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1208 formatting out-of-range floating point numbers with int
1209 formats. (Bug#8668)
1210
2e6578fb
PE
1211 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1212
0ae6bdee
PE
1213 * data.c: Avoid integer truncation in expressions involving floats.
1214 * data.c: Include <intprops.h>.
1215 (arith_driver): When there's an integer overflow in an expression
1216 involving floating point, convert the integers to floating point
1217 so that the resulting value does not suffer from catastrophic
1218 integer truncation. For example, on a 64-bit host (* 4
1219 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1220 Do not rely on undefined behavior after integer overflow.
1221
de883a70
PE
1222 merge count_size_as_multibyte, parse_str_to_multibyte
1223 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1224 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1225 Check for integer overflow.
1226 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1227 since it's now a duplicate of the other. This is more of
1228 a character than a buffer op, so better that it's in character.c.
1229 * fns.c, print.c: Adjust to above changes.
1230
2ff916cb
PE
12312011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1232
1233 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1234
f1b54466
PE
12352011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1236
fb1ac845
PE
1237 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1238 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1239 (x_clipboard_manager_save): Now static.
1240 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1241
f1b54466
PE
1242 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1243 (crypto_hash_function): Now static.
1244 Fix pointer signedness problems. Avoid unnecessary initializations.
1245
a9f737ee
CY
12462011-05-27 Chong Yidong <cyd@stupidchicken.com>
1247
1248 * termhooks.h (Vselection_alist): Make it terminal-local.
1249
1250 * terminal.c (create_terminal): Initialize it.
1251
1252 * xselect.c: Support for clipboard managers.
1253 (Vselection_alist): Move to termhooks.h as terminal-local var.
1254 (LOCAL_SELECTION): New macro.
1255 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1256 (symbol_to_x_atom): Remove gratuitous arg.
1257 (x_handle_selection_request, lisp_data_to_selection_data)
1258 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1259 (x_own_selection, x_get_local_selection, x_convert_selection):
1260 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1261 (some_frame_on_display): Delete unused function.
1262 (Fx_own_selection_internal, Fx_get_selection_internal)
1263 (Fx_disown_selection_internal, Fx_selection_owner_p)
1264 (Fx_selection_exists_p): New optional frame arg.
1265 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1266 (x_handle_selection_clear): Don't treat other terminals with the
1267 same keyboard specially. Use the terminal-local Vselection_alist.
1268 (x_clear_frame_selections): Use Frun_hook_with_args.
1269
1270 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1271
1272 * xterm.h: Add support for those atoms.
1273
e067f0c1
CY
12742011-05-26 Chong Yidong <cyd@stupidchicken.com>
1275
1276 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1277 (converted_selections, conversion_fail_tag): New global variables.
1278 (x_selection_request_lisp_error): Free the above.
1279 (x_get_local_selection): Remove unnecessary code.
1280 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1281 of converted selections stored in converted_selections.
1282 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1283 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1284 (x_convert_selection): New function.
1285 (x_handle_selection_event): Simplify.
1286 (x_get_foreign_selection): Don't ignore incoming requests while
1287 waiting for an answer; this will fail when we implement
1288 SAVE_TARGETS, and seems unnecessary anyway.
1289 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1290 (Vx_sent_selection_functions): Doc fix.
1291
0f4aebc0
LL
12922011-05-26 Leo Liu <sdl.web@gmail.com>
1293
1294 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1295
e61124cd
YM
12962011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1297
1298 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1299
1300 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1301 for fringe update if it has periodic bitmap.
1302 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1303 and fringe_bitmap_periodic_p.
1304
1305 * fringe.c (get_fringe_bitmap_data): New function.
1306 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1307 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1308 row. Mark glyph row for fringe update if periodicity changed.
1309
1310 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1311 for fringe update unless it has periodic bitmap.
1312
f16d9837
KH
13132011-05-25 Kenichi Handa <handa@m17n.org>
1314
1315 * xdisp.c (get_next_display_element): Set correct it->face_id for
1316 a static composition.
1317
e1b90ef6
LL
13182011-05-24 Leo Liu <sdl.web@gmail.com>
1319
1320 * deps.mk (fns.o):
1321 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1322
1323 * fns.c (crypto_hash_function, Fsha1): New function.
1324 (Fmd5): Use crypto_hash_function.
1325 (syms_of_fns): Add Ssha1.
1326
7400048f
PE
13272011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1328
1329 * gnutls.c: Remove unused macros.
1330 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1331 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1332 Remove macros that are defined and never used.
1333 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1334
abb71cf4
CY
13352011-05-22 Chong Yidong <cyd@stupidchicken.com>
1336
1337 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1338 (Fx_get_selection_internal): Minor cleanup.
1339 (Fx_own_selection_internal): Rename arguments for consistency with
1340 select.el.
1341
6307db39
PE
13422011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1343
1344 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1345
f3d4e0a4
CY
13462011-05-22 Chong Yidong <cyd@stupidchicken.com>
1347
1348 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1349
4d8ade89
YM
13502011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1351
1352 * dispnew.c (scrolling_window): Don't exclude the case that the
1353 last enabled row in the desired matrix touches the bottom boundary.
1354
32078c8d
GM
13552011-05-21 Glenn Morris <rgm@gnu.org>
1356
1357 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1358 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1359 and add some more files.
32078c8d 1360
7285dc67
EZ
13612011-05-20 Eli Zaretskii <eliz@gnu.org>
1362
1363 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1364 report_file_error introduced by the change from 2011-05-07.
1365
89d1bd22
PE
13662011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1367
1368 * systime.h (Time): Define only if emacs is defined.
1369 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1370 where the include path doesn't have X11/X.h by default. See
1371 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1372
e23640bb 13732011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1374
1375 * composite.c (find_automatic_composition): Fix previous change.
1376
b9704ad9
GM
13772011-05-20 Glenn Morris <rgm@gnu.org>
1378
1379 * lisp.mk: New file, split from Makefile.in.
1380 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1381 (shortlisp): Remove.
1382 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1383
4a720484
GM
13842011-05-19 Glenn Morris <rgm@gnu.org>
1385
1386 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1387 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1388 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1389 (lisp): Set the order to that of loadup.el.
1390 (shortlisp): Make it a copy of $lisp.
1391 (SOME_MACHINE_LISP): Remove.
1392 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1393 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1394
a28d4396
KH
13952011-05-18 Kenichi Handa <handa@m17n.org>
1396
1397 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1398 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1399 (find_automatic_composition): Mostly rewrite for efficiency.
1400
a2b1fa8e
JB
14012011-05-18 Juanma Barranquero <lekktu@gmail.com>
1402
1403 * makefile.w32-in: Update dependencies.
1404
8e1f5610
CS
14052011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1406
1407 * menu.c: Include limits.h (fixes the MS-Windows build broken by
fadf4e30 1408 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 1409
7025ee00 14102011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1411
cdfa6eab
PE
1412 Fix some integer overflow issues, such as string length overflow.
1413
06d6db33
PE
1414 * insdel.c (count_size_as_multibyte): Check for string overflow.
1415
2b4560a8
PE
1416 * character.c (lisp_string_width): Check for string overflow.
1417 Use EMACS_INT, not int, for string indexes and lengths; in
1418 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1419 the resulting string length overflows an EMACS_INT; instead,
1420 report a string overflow if no precision given. When checking for
1421 precision exhaustion, use a check that cannot possibly have
1422 integer overflow. (Bug#8675)
1423 * character.h (lisp_string_width): Adjust to new signature.
1424
cb93f9be
PE
1425 * alloc.c (string_overflow): New function.
1426 (Fmake_string): Use it. This doesn't change behavior, but saves
1427 a few bytes and will simplify future changes.
1428 * character.c (string_escape_byte8): Likewise.
1429 * lisp.h (string_overflow): New decl.
1430
1a1f3366
PE
1431 Fixups, following up to the user-interface timestamp change.
1432 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1433 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1434 * msdos.c (mouse_get_pos): Likewise.
1435 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1436 * w32gui.h (Time): Define by including "systime.h" rather than by
1437 declaring it ourselves. (Bug#8664)
1438
d4e3e4d3
PE
1439 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1440 * image.c (clear_image_cache): Likewise.
1441
f6a24d19
PE
1442 * term.c (term_mouse_position): Don't assume time_t wraparound.
1443
08dc5ae6
PE
1444 Be more systematic about user-interface timestamps.
1445 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1446 and sometimes 'EMACS_UINT', to represent these timestamps.
1447 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1448 This makes the code easier to follow, and makes it easier to catch
1449 integer overflow bugs such as Bug#8664.
1450 * frame.c (Fmouse_position, Fmouse_pixel_position):
1451 Use Time, not unsigned long, for user-interface timestamps.
1452 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1453 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1454 * keyboard.h (last_event_timestamp): Likewise.
1455 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1456 * menu.h (xmenu_show): Likewise.
1457 * term.c (term_mouse_position): Likewise.
1458 * termhooks.h (struct input_event.timestamp): Likewise.
1459 (struct terminal.mouse_position_hook): Likewise.
1460 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1461 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1462 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1463 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1464 what it was before.
1465 * menu.h, termhooks.h: Include "systime.h", for Time.
1466
8e55734a
PE
1467 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1468 Don't assume that the difference between two unsigned long values
1469 can fit into an integer. At this point, we know button_down_time
1470 <= event->timestamp, so the difference must be nonnegative, so
1471 there's no need to cast the result if double-click-time is
1472 nonnegative, as it should be; check that it's nonnegative, just in
1473 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1474 apart (about 25 days). (Bug#8664)
8e55734a 1475
841f1b75 1476 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1477 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1478
3e26f69c
PE
1479 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1480 that always fit in int. Use a sentinel instead of a counter, to
1481 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1482 * frame.h (struct frame): Use int for menu_bar_items_used
1483 instead of EMACS_INT, since it always fits in int.
3e26f69c 1484
5cc152c0
PE
1485 * menu.c (grow_menu_items): Check for int overflow.
1486
d89eb65e
PE
1487 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1488
5235bd3e
PE
1489 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1490 Before, the code was not consistent. These values cannot exceed
1491 2**31 - 1 so there's no need to make them unsigned.
1492 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1493 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1494 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1495 as modifiers.
1496 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1497
bc827e23
PE
1498 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1499 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1500 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1501 presumably because the widths might not match.
1502
78eb494e
PE
1503 * window.c (size_window): Avoid needless test at loop start.
1504
04f2d78b
CB
15052011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1506
1507 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1508
d2fc7e3d 15092011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1510
1511 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1512
d2fc7e3d 15132011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1514
1515 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1516 `width' to `bar_area_x' and `bar_area_width', respectively.
1517 (x_scroll_run): Take account of fringe background extension.
1518
04f2d78b
CB
1519 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1520 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1521 `bar_area_width', respectively.
1522 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1523 background extension.
1524
79b70037
GM
15252011-05-10 Jim Meyering <meyering@redhat.com>
1526
1527 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1528
2f142cc5
JB
15292011-05-10 Juanma Barranquero <lekktu@gmail.com>
1530
1531 * image.c (Finit_image_library): Return t for built-in image types,
1532 like pbm and xbm. (Bug#8640)
1533
57679c86
AS
15342011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1535
1536 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1537
888c9e86
EZ
15382011-05-07 Eli Zaretskii <eliz@gnu.org>
1539
b0512a1d
EZ
1540 * w32console.c (Fset_screen_color): Doc fix.
1541 (Fget_screen_color): New function.
1542 (syms_of_ntterm): Defsubr it.
1543
7285dc67
EZ
1544 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1545 unlink the temporary file if Fcall_process didn't create it in the
1546 first place.
1547 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1548 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1549 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1550 cue to call_process_cleanup not to close that handle.
1551
4d3fcc8e
BK
15522011-05-07 Ben Key <bkey76@gmail.com>
1553
1554 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1555 one of two shell specific rules, either bootstrap-temacs-CMD or
1556 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1557 to the previous implementation of the bootstrap-temacs rule.
1558 The bootstrap-temacs-CMD rule is similar to the previous
1559 implementation of the bootstrap-temacs rule except that it
1560 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1561 variable.
1562
1563 These changes, along with some changes to nt/configure.bat,
1564 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1565 earlier fix to add support for --cflags and --ldflags options
1566 that include quotes so that it works whether make uses cmd or
1567 sh as the shell.
1568
b4289b64
MA
15692011-05-06 Michael Albinus <michael.albinus@gmx.de>
1570
1571 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1572 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1573 is a constant.
1574 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1575 a string. Handle both cases.
1576 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1577 (Fdbus_register_method): Use Qinvalid_function.
1578
af4c0e28
JB
15792011-05-06 Juanma Barranquero <lekktu@gmail.com>
1580
1581 * makefile.w32-in: Update dependencies.
1582 (LISP_H): Add inttypes.h and stdin.h.
1583 (PROCESS_H): Add unistd.h.
1584
c51453d9
EZ
15852011-05-06 Eli Zaretskii <eliz@gnu.org>
1586
1587 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1588 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1589
8ff0ac3c 15902011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1591
4c4b566b
PE
1592 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1593
aab2b9b5
PE
1594 * term.c (vfatal): Remove stray call to va_end.
1595 It's not needed and the C Standard doesn't allow it here anyway.
1596
c378da0b
PE
1597 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1598 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1599
288b08c7
PE
1600 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1601 bytes.
1602
e3601888
PE
1603 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1604
db6c0e74
PE
1605 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1606
dd5963ea
PE
1607 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1608
88c9450f
PE
1609 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1610
2f9442b8
PE
1611 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1612
c032b5f8
PE
1613 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1614 * charset.c (Fdefine_charset_internal): Don't initialize
1615 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1616 32-bit int (Bug#8600).
a108c10b
PE
1617
1618 * lread.c (read_integer): Be more consistent with string-to-number.
1619 Use string_to_number to do the actual conversion; this avoids
1620 rounding errors and fixes some other screwups. Without this fix,
1621 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1622 (digit_to_number): Move earlier, for benefit of read_integer.
1623 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1624 not a digit in any supported base. (Bug#8602)
a108c10b 1625
ad5f9eea
PE
1626 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1627
aec1708a
PE
1628 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1629 to match comment at start of function. This also removes a
1630 GCC warning about overflow in a 32+64-bit port.
1631
47be4ab5
PE
1632 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1633
371cac43
PE
1634 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1635 Reported by Stefan Monnier in
1636 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1637 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1638 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1639
d01a7826
PE
1640 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1641 (EMACS_UINTPTR): Likewise, with uintptr_t.
1642
7fd47d5c
PE
1643 * lisp.h: Prefer 64-bit EMACS_INT if available.
1644 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1645 on 32-bit hosts that have 64-bit int, so that they can access
1646 large files.
122b0c86
PE
1647 However, temporarily disable this change unless the temporary
1648 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1649
8727937b
PE
1650 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1651
8ac068ac
PE
1652 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1653 This removes an assumption that EMACS_INT and long are the same
1654 width as pointers. The assumption is true for Emacs porting targets
1655 now, but we want to make other targets possible.
1656 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1657 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1658 In the rest of the code, change types of integers that hold casted
1659 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1660 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1661 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1662 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1663 No need to cast type when ORing.
1664 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1665 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1666 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1667 assume EMACS_INT is the same width as char *.
1668 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1669 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1670 Remove no-longer-needed casts.
1671 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1672 (xg_tool_bar_help_callback, xg_make_tool_item):
1673 Use EMACS_INTPTR to hold an integer
1674 that will be cast to void *; this can avoid a GCC warning
1675 if EMACS_INT is not the same width as void *.
1676 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1677 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1678 (current_message_1, set_message_1):
1679 Use a local to convert to proper width without a cast.
1680 * xmenu.c (dialog_selection_callback): Likewise.
1681
ede49d71
PE
1682 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1683 Also, don't assume VALBITS / RAND_BITS is less than 5,
1684 and don't rely on undefined behavior when shifting a 1 left into
1685 the sign bit.
1686 * lisp.h (get_random): Change signature to match.
1687
2f30ecd0
PE
1688 * lread.c (hash_string): Use size_t, not int, for hash computation.
1689 Normally we prefer signed values; but hashing is special, because
1690 it's better to use unsigned division on hash table sizes so that
1691 the remainder is nonnegative. Also, size_t is the natural width
1692 for hashing into memory. The previous code used 'int', which doesn't
1693 retain enough info to hash well into very large tables.
1694 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1695
2a866e7b
PE
1696 * dbusbind.c: Don't possibly lose pointer info when converting.
1697 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1698 Use XPNTR rather than XHASH, so that the high-order bits of
1699 the pointer aren't lost when converting through void *.
1700
51639eac
PE
1701 * eval.c (Fautoload): Don't double-shift a pointer.
1702
92394119
PE
1703 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1704
dbdb9a7c
JB
17052011-05-06 Juanma Barranquero <lekktu@gmail.com>
1706
1707 * gnutls.c (DEF_GNUTLS_FN):
1708 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1709
db7a0b4f
AS
17102011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1711
1712 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1713 marker. (Bug#8610)
1714
f7ff1b0f 17152011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1716
1717 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1718 New version that can reserve upto 2GB of heap space.
1719
f7ff1b0f 17202011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1721
1722 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1723
639c109b
TZ
17242011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1725
1726 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1727 `gnutls_certificate_set_x509_key_file'.
1728
d2127135
JB
17292011-05-05 Juanma Barranquero <lekktu@gmail.com>
1730
1731 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1732 Update dependencies.
1733
e968f4f3
JB
17342011-05-04 Juanma Barranquero <lekktu@gmail.com>
1735
1736 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1737 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1738 Remove unused parameter `fildes'.
1739 * process.c (read_process_output, send_process): Don't pass it.
1740
84d358f0
JB
17412011-05-04 Juanma Barranquero <lekktu@gmail.com>
1742
1743 Fix previous change: the library cache is defined in w32.c.
1744 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1745 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1746
0898ca10
JB
17472011-05-04 Juanma Barranquero <lekktu@gmail.com>
1748
1749 Implement dynamic loading of GnuTLS on Windows.
1750
1751 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1752 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1753 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1754 Declare.
1755
1756 * gnutls.c (Qgnutls_dll): Define.
1757 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1758 (gnutls_*): Declare function pointers.
1759 (init_gnutls_functions): New function to initialize function pointers.
1760 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1761 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1762 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1763 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1764 (emacs_gnutls_write, emacs_gnutls_read)
1765 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1766 (Fgnutls_available_p): New function.
1767 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1768 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1769 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1770
1771 * image.c: Include w32.h.
1772 (Vimage_type_cache): Delete.
1773 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1774 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1775 (w32_delayed_load): Move to w32.c.
1776
1777 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1778
1779 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1780 (w32_delayed_load): Move from image.c. When loading a library, record
1781 its filename in the :loaded-from property of the library id.
1782 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1783 Initialize and staticpro them.
1784 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1785
1786 * process.c: Include lisp.h before w32.h, not after.
1787 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1788 instead of gnutls_record_check_pending.
1789
1790 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1791
ff4de4aa
TZ
17922011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1793
1794 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1795 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1796 as passed in.
1797
abe95abb
JD
17982011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1799
1800 * xterm.c (x_set_frame_alpha): Do not set property on anything
1801 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1802
e16e55d4
JB
18032011-05-02 Juanma Barranquero <lekktu@gmail.com>
1804
1805 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1806
bafcf6a5
JB
18072011-05-02 Juanma Barranquero <lekktu@gmail.com>
1808
1809 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1810 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1811 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1812 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1813 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1814 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1815 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1816 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1817 (Qgnutls_bootprop_callbacks_verify): Make static.
1818
e7a6747f
AS
18192011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1820
19ed11ba
AS
1821 * callproc.c: Indentation fixup.
1822
e7a6747f 1823 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1824 (wait_for_termination, interruptible_wait_for_termination):
1825 Move after wait_for_termination_1.
e7a6747f 1826
1ef14cb4
LMI
18272011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1828
1829 * sysdep.c (interruptible_wait_for_termination): New function
1830 which is like wait_for_termination, but allows keyboard
1831 interruptions.
1832
1833 * callproc.c (Fcall_process): Add (:file "file") as an option for
1834 the STDOUT buffer.
1835 (Fcall_process_region): Ditto.
1836
330d880c
EZ
18372011-04-30 Eli Zaretskii <eliz@gnu.org>
1838
8db90b73
EZ
1839 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1840 rather than `XVECTOR (FOO)->size'.
1841
330d880c
EZ
1842 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1843 inttypes.h, as a gnulib replacement is used if it not available in
1844 system headers.
1845
15cbd324
EZ
18462011-04-21 Eli Zaretskii <eliz@gnu.org>
1847
1848 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1849 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1850 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1851
1852 * coding.c (coding_alloc_by_realloc): Error out if destination
1853 will grow beyond MOST_POSITIVE_FIXNUM.
1854 (decode_coding_emacs_mule): Abort if there isn't enough place in
1855 charbuf for the composition carryover bytes. Reserve an extra
1856 space for up to 2 characters produced in a loop.
1857 (decode_coding_iso_2022): Abort if there isn't enough place in
1858 charbuf for the composition carryover bytes.
1859
18602011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1861
ae940cca
EZ
1862 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1863 aborting when %lld or %lll format is passed.
1864 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1865 %llo or %llx format is passed. (Bug#8545)
1866
03ab8921
EZ
1867 * window.c (window_scroll_line_based): Use a marker instead of
1868 simple variables to record original value of point. (Bug#7952)
1869
afda1437
EZ
1870 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1871 produced by %s or %c overflows available buffer space. (Bug#8545)
1872
f76dee0c
PE
18732011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1874
1875 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1876 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1877
fdc5744d
JB
18782011-04-28 Juanma Barranquero <lekktu@gmail.com>
1879
1880 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1881
638f053a
JB
18822011-04-28 Juanma Barranquero <lekktu@gmail.com>
1883
1884 * keyboard.c (Qdelayed_warnings_hook): Define.
1885 (command_loop_1): Run `delayed-warnings-hook'
1886 if Vdelayed_warnings_list is non-nil.
1887 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1888 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1889
d178f871
EZ
18902011-04-28 Eli Zaretskii <eliz@gnu.org>
1891
1892 * doprnt.c (doprnt): Don't return value smaller than the buffer
1893 size if the message was truncated. (Bug#8545).
1894
b124fd93
JB
18952011-04-28 Juanma Barranquero <lekktu@gmail.com>
1896
1897 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1898 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1899
e810457d
PE
19002011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1901
1902 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1903
ea51cceb
JB
19042011-04-27 Juanma Barranquero <lekktu@gmail.com>
1905
1906 * makefile.w32-in: Update dependencies.
1907
94dcfacf
EZ
19082011-04-27 Eli Zaretskii <eliz@gnu.org>
1909
1910 Improve `doprnt' and its usage. (Bug#8545)
1911 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1912 `format_end'. Remove support for %l as a conversion specifier.
1913 Don't use xrealloc. Improve diagnostics when the %l size modifier
1914 is used. Update the commentary.
1915
1916 * eval.c (verror): Simplify calculation of size_t.
1917
1918 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1919 messages.
1920
f61f41d7
PE
19212011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1922
1923 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1924 change.
1925
96fb4434
PE
19262011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1927
1928 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1929 This makes this file independent of the recent pseudovector change.
1930
671875da 19312011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1932
69e9b5a3
PE
1933 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1934
b5f869a7 1935 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1936 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1937 Remove unused local.
c8926152 1938 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1939
841a1577 1940 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1941 GCC 4.6.0 optimizes based on type-based alias analysis.
1942 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1943 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1944 != &v->size, and therefore "v->size = 1; b->size = 2; return
1945 v->size;" must therefore return 1. This assumption is incorrect
1946 for Emacs, since it type-puns struct Lisp_Vector * with many other
1947 types. To fix this problem, this patch adds a new type struct
f904488f 1948 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1949 and pseudovectors, and helps optimizing compilers not get fooled
1950 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1951 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1952 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1953 the size member.
eab3844f
PE
1954 (XSETPVECTYPE): Rewrite in terms of new macro.
1955 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1956 This is a bit clearer, and further avoids the possibility of
1957 undesirable aliasing.
1958 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1959 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1960 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1961 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1962 (ASIZE): Now uses header.size rather than size.
1963 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1964 to avoid the hassle of writing XVECTOR (foo)->header.size.
1965 (struct vectorlike_header): New type.
eab3844f
PE
1966 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1967 object, to help avoid aliasing.
1968 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1969 (SUBRP): Likewise, since Lisp_Subr is a special case.
1970 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1971 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1972 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1973 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1974 changed to be "header.size" and "header.next".
1975 * buffer.h (struct buffer): Likewise.
1976 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1977 * frame.h (struct frame): Likewise.
1978 * process.h (struct Lisp_Process): Likewise.
1979 * termhooks.h (struct terminal): Likewise.
1980 * window.c (struct save_window_data, struct saved_window): Likewise.
1981 * window.h (struct window): Likewise.
1982 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1983 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1984 * buffer.c (init_buffer_once): Likewise.
1985 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1986 special case.
1987 * process.c (Fformat_network_address): Use local var for size,
1988 for brevity.
1989
0df1eac5
PE
1990 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1991
847ab9d1 1992 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1993 * data.c (atof): Remove decl; no longer used or needed.
1994 (digit_to_number): Move to lread.c.
1995 (Fstring_to_number): Use new string_to_number function, to be
1996 consistent with how the Lisp reader treats infinities and NaNs.
1997 Do not assume that floating-point numbers represent EMACS_INT
1998 without losing information; this is not true on most 64-bit hosts.
1999 Avoid double-rounding errors, by insisting on integers when
2000 parsing non-base-10 numbers, as the documentation specifies.
2001 * lisp.h (string_to_number): New decl, replacing ...
2002 (isfloat_string): Remove.
bc0a5c13 2003 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2004 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2005 appears to have been a coding error. Similarly, do not accept
2006 strings like +-1e0 as floating point numbers. Do not report
2007 overflow for integer overflows unless the base is not 10 which
2008 means we have no simple and reliable way to continue.
2009 Break out the floating-point parsing into a new
2010 function string_to_number, so that Fstring_to_number parses
2011 floating point numbers consistently with the Lisp reader.
04f2d78b 2012 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2013 (E_CHAR, EXP_INT): Remove, replacing with ...
2014 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2015 (string_to_number): New function, replacing isfloat_string.
2016 This function checks for valid syntax and produces the resulting
2017 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2018 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2019 so that overflow for non-base-10 numbers is reported only when
2020 there's no portable and simple way to convert to floating point.
452f4150 2021
67769ffc
PE
2022 * textprop.c (set_text_properties_1): Rewrite for clarity,
2023 and to avoid GCC warning about integer overflow.
2024
c20db43f
PE
2025 * intervals.h (struct interval): Use EMACS_INT for members
2026 where EMACS_UINT might cause problems. See
2027 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2028 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2029 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2030 All uses changed.
37aa2f85
PE
2031 (offset_intervals): Tell GCC not to worry about length overflow
2032 when negating a negative length.
c20db43f 2033
2538aa2f
PE
2034 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2035 (overrun_check_free): Likewise.
2036
f2d3008d
PE
2037 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2038 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2039 word size.
2040
ec8df744
PE
2041 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2042 (gnutls_make_error): Rename local to avoid shadowing.
2043 (gnutls_emacs_global_deinit): ifdef out; not used.
2044 (Fgnutls_boot): Use const for pointer to readonly storage.
2045 Comment out unused local. Fix pointer signedness problems.
2046
640ee02d
PE
2047 * lread.c (openp): Don't stuff size_t into an 'int'.
2048 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2049 about possible signed overflow.
2050
6048fb2a
PE
2051 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2052 (GDK_KEY_g): Don't define if already defined.
2053 (xg_prepare_tooltip): Avoid pointer signedness problem.
2054 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2055
fa3c87e1
PE
2056 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2057 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2058
2172544b
PE
2059 * xfns.c (Fx_window_property): Simplify a bit,
2060 to make a bit faster and to avoid GCC 4.6.0 warning.
2061 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2062
9b821a21
PE
2063 * fns.c (internal_equal): Don't assume size_t fits in int.
2064
3c616cfa
PE
2065 * alloc.c (compact_small_strings): Tighten assertion a little.
2066
c2982e87
PE
2067 Replace pEd with more-general pI, and fix some printf arg casts.
2068 * lisp.h (pI): New macro, generalizing old pEd macro to other
2069 conversion specifiers. For example, use "...%"pI"d..." rather
2070 than "...%"pEd"...".
2071 (pEd): Remove. All uses replaced with similar uses of pI.
2072 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2073 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2074 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2075 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2076 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2077 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2078 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2079 64-bit hosts.
2080 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2081 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2082 * print.c (safe_debug_print, print_object): Likewise.
2083 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2084 to int.
6f04d126
PE
2085 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2086 avoiding the 0 flag, which is not portable.
c2982e87
PE
2087 * process.c (Fmake_network_process): Use pI to avoid cast.
2088 * region-cache.c (pp_cache): Likewise.
2089 * xdisp.c (decode_mode_spec): Likewise.
2090 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2091 behavior on 64-bit hosts with printf arg.
6f04d126 2092 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2093 (x_stop_queuing_selection_requests): Likewise.
2094 (x_get_window_property): Don't truncate byte count to an 'int'
2095 when tracing.
0b432f21 2096
5e073ec7
PE
2097 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2098 here, since it parses constructs like leading '-' and spaces,
2099 which are not wanted; and it overflows with large numbers.
2100 Instead, simply match F[0-9]+, which is what is wanted anyway.
2101
36372bf9
PE
2102 * alloc.c: Remove unportable assumptions about struct layout.
2103 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2104 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2105 (allocate_vectorlike, make_pure_vector): Use the new macros,
2106 plus offsetof, to remove unportable assumptions about struct layout.
2107 These assumptions hold on all porting targets that I know of, but
2108 they are not guaranteed, they're easy to remove, and removing them
2109 makes further changes easier.
2110
0b432f21
PE
2111 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2112 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2113 (string_overrun_cookie): Now const. Use initializers that
2114 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2115 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2116 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2117 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2118 multiple of sizeof (EMACS_INT); it need not be, if
2119 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2120 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2121
895009e1
JB
21222011-04-26 Juanma Barranquero <lekktu@gmail.com>
2123
2124 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2125
6a7a1b0b
TZ
21262011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2127
2128 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2129 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2130 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2131
841a1577 21322011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2133
2134 * lisp.h (Qdebug): List symbol.
895009e1 2135 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2136 * keyboard.c (debug-on-event): New variable.
2137 (handle_user_signal): Break into debugger when debug-on-event
2138 matches the current signal symbol.
2139
f2d3ba6f
DN
21402011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2141
2142 * alloc.c (check_sblock, check_string_bytes)
2143 (check_string_free_list): Convert to standard C.
2144
42ce4c63
TZ
21452011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2146
2147 * w32.c (emacs_gnutls_push): Fix typo.
2148
825cd63c
EZ
21492011-04-25 Eli Zaretskii <eliz@gnu.org>
2150
fb11d64d
EZ
2151 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2152 "cast to pointer from integer of different size".
2153
825cd63c
EZ
2154 Improve doprnt and its use in verror. (Bug#8545)
2155 * doprnt.c (doprnt): Document the set of format control sequences
2156 supported by the function. Use SAFE_ALLOCA instead of always
2157 using `alloca'.
2158
2159 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2160 is one byte too soon. Don't use xrealloc; instead xfree and
2161 xmalloc anew.
2162
e061a11b
TZ
21632011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2164
2165 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2166 callbacks stage.
2167
2168 * gnutls.c: Renamed global_initialized to
2169 gnutls_global_initialized. Added internals for the
2170 :verify-hostname-error, :verify-error, and :verify-flags
2171 parameters of `gnutls-boot' and documented those parameters in the
2172 docstring. Start callback support.
2173 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2174 unless a fatal error occured. Call gnutls_alert_send_appropriate
2175 on error. Return error code.
2176 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2177 (emacs_gnutls_read): Likewise.
2178 (Fgnutls_boot): Return handshake error code.
2179 (emacs_gnutls_handle_error): New function.
2180 (wsaerror_to_errno): Likewise.
2181
2182 * w32.h (emacs_gnutls_pull): Add prototype.
2183 (emacs_gnutls_push): Likewise.
2184
2185 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2186 (emacs_gnutls_push): Likewise.
2187
21882011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2189
2190 * process.c (wait_reading_process_output): Check if GnuTLS
2191 buffered some data internally if no FDs are set for TLS
2192 connections.
2193
2194 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2195 (LIBS): Link to USER_LIBS.
2196 ($(BLD)/gnutls.$(0)): New target.
2197
fa6996bc
EZ
21982011-04-24 Eli Zaretskii <eliz@gnu.org>
2199
eb35682e
EZ
2200 * xdisp.c (handle_single_display_spec): Rename the
2201 display_replaced_before_p argument into display_replaced_p, to
2202 make it consistent with the commentary. Fix typos in the
2203 commentary.
2204
e2ad650c
EZ
2205 * textprop.c (syms_of_textprop): Remove dead code.
2206 (copy_text_properties): Delete obsolete commentary about an
2207 interface that was deleted long ago. Fix typos in the description
2208 of arguments.
2209
1b2de274
EZ
2210 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2211 to changes in oldXMenu/XMenu.h from 2011-04-16.
2212 <menu_help_message, prev_menu_help_message>: Constify.
2213 (IT_menu_make_room): menu->help_text is now `const char **';
2214 adjust.
2215
2216 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2217 to changes in oldXMenu/XMenu.h from 2011-04-16.
2218 (struct XMenu): Declare `help_text' `const char **'.
2219
2220 * xfaces.c <Qunspecified>: Make extern again.
2221
2222 * syntax.c: Include sys/types.h before including regex.h, as
2223 required by Posix.
2224
762b15be
EZ
2225 * doc.c (get_doc_string): Improve the format passed to `error'.
2226
2227 * doprnt.c (doprnt): Improve commentary.
2228
2229 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2230
2231 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2232 them with etags.
2233
f1052e5d
EZ
2234 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2235 changes in globals.h immediately force recompilation.
762b15be
EZ
2236 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2237 $(CURDIR)/s/ms-w32.h.
2238 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2239
fa6996bc
EZ
2240 * character.c (Fchar_direction): Function deleted.
2241 (syms_of_character): Don't defsubr it.
2242 <char-direction-table>: Deleted.
2243
e6c3da20
EZ
22442011-04-23 Eli Zaretskii <eliz@gnu.org>
2245
2246 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2247 * doprnt.c: Include limits.h.
2248 (SIZE_MAX): New macro.
04f2d78b
CB
2249 (doprnt): Return a size_t value. 2nd arg is now size_t.
2250 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2251 Improve overflow protection. Support `l' modifier for integer
2252 conversions. Support %l conversion. Don't assume an EMACS_INT
2253 argument for integer conversions and for %c.
2254
2255 * lisp.h (doprnt): Restore prototype.
2256
2257 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2258 $(SRC)/character.h.
2259
2260 * Makefile.in (base_obj): Add back doprnt.o.
2261
2262 * deps.mk (doprnt.o): Add back prerequisites.
2263 (callint.o): Depend on character.h.
2264
2265 * eval.c (internal_lisp_condition_case): Include the handler
2266 representation in the error message.
2267 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2268 when breaking from the loop.
2269
2270 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2271
2272 * callint.c (Fcall_interactively): When displaying error message
2273 about invalid control letter, pass the character's codepoint, not
2274 a pointer to its multibyte form. Improve display of the character
2275 in octal and display also its hex code.
2276
2277 * character.c (char_string): Use %x to display the (unsigned)
2278 codepoint of an invalid character, to avoid displaying a bogus
2279 negative value.
2280
2281 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2282 `error', not SYMBOL_NAME itself.
2283
2284 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2285 character arguments to `error'.
2286
2287 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2288 to `error' in error message about FINAL_CHAR argument. Make sure
2289 FINAL_CHAR is a character, and use %c when it is passed as
2290 argument to `error'.
2291
4ffd0d6b 22922011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2293
2294 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2295
2296 * w32.c: Include <time.h>.
2297 (sys_localtime): New function.
2298
4ffd0d6b 22992011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2300
2301 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2302
4ffd0d6b 2303 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2304
4ffd0d6b 23052011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2306
4ffd0d6b
GM
2307 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2308 zombies (Bug#8467).
aac0c6e3 2309
04c56954
EZ
23102011-04-19 Eli Zaretskii <eliz@gnu.org>
2311
2312 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2313 gl_state.e_property when gl_state.object is Qt.
2314
2315 * insdel.c (make_gap_larger): Remove limitation of buffer size
2316 to <= INT_MAX.
2317
16a43933
CY
23182011-04-18 Chong Yidong <cyd@stupidchicken.com>
2319
2320 * xdisp.c (lookup_glyphless_char_display)
2321 (produce_glyphless_glyph): Handle cons cell entry in
2322 glyphless-char-display.
2323 (Vglyphless_char_display): Document it.
2324
2325 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2326 glyphless-char-display.
2327
4581706e
CY
23282011-04-17 Chong Yidong <cyd@stupidchicken.com>
2329
2330 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2331
2332 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2333
2334 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2335 definition for no-X builds.
2336
4887c6e2 23372011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2338
fd35b6f9
PE
2339 Static checks with GCC 4.6.0 and non-default toolkits.
2340
5c1ccb01
PE
2341 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2342
006c5daa
PE
2343 * process.c (keyboard_bit_set): Define only if SIGIO.
2344 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2345 (send_process): Repair possible setjmp clobbering.
2346
efc736d3
PE
2347 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2348
4e2fe2e6
PE
2349 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2350
f97334a2
PE
2351 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2352
4e75f29d
PE
2353 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2354 Define only if needed.
2355
90efadd1
PE
2356 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2357 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2358 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2359
3c647824
PE
2360 * dispextern.h (struct redisplay_interface): Rename param
2361 to avoid shadowing.
e264f262 2362 * termhooks.h (struct terminal): Likewise.
761383f4 2363 * xterm.c (xembed_send_message): Likewise.
3c647824 2364
b58c5c4a
PE
2365 * insdel.c (make_gap_smaller): Define only if
2366 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2367
cad59032
PE
2368 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2369 it.
2370
c339dc2e
PE
2371 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2372 so that we aren't warned about unused symbols.
2373
91a3e27b
PE
2374 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2375
399c71d3 2376 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2377
8ffc96f5
PE
2378 * xfns.c (x_real_positions): Mark locals as initialized.
2379
eef9bc79
PE
2380 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2381
098db9dd
PE
2382 * xterm.c: Fix problems found by static analysis with other toolkits.
2383 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2384 (x_dispatch_event): Declare static if USE_GTK, and
2385 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2386 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2387 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2388 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2389 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2390
eb18f6cc
PE
2391 * xmenu.c (menu_help_callback): Pointer type fixes.
2392 Use const pointers when pointing at readonly data. Avoid pointer
2393 signedness clashes.
2394 (FALSE): Remove unused macro.
2395 (update_frame_menubar): Remove unused decl.
2396
1fe72bf8
PE
2397 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2398
60d9e1db
PE
2399 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2400 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2401 (single_menu_item): Rename local to avoid shadowing.
2402
39261c26
PE
2403 * keyboard.c (make_lispy_event): Remove unused local var.
2404
018c5e19
PE
2405 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2406 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2407
63d2b86e
PE
2408 * bitmaps: Change bitmaps from unsigned char back to the X11
2409 compatible char. Avoid the old compiler warnings about
2410 out-of-range initializers by using, for example, '\xab' rather
2411 than 0xab.
2412
aefd87e1
PE
2413 * xgselect.c (xgselect_initialize): Check vs interface
2414 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2415
bf501fb9
PE
2416 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2417
e9829fdf
PE
2418 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2419 to read-only memory.
2420
1086c095
PE
2421 * fns.c (vector): Remove; this old hack is no longer needed.
2422
2baccd04 2423 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2424 Remove unused var.
dde42981 2425 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2426
72391843 2427 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2428
436c16df 2429 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2430 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2431 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2432
92bb796d 2433 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2434 (x_term_init): Remove local to avoid shadowing.
92bb796d 2435
764430a3 2436 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2437
2438 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2439 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2440
d1dfb56c
EZ
24412011-04-16 Eli Zaretskii <eliz@gnu.org>
2442
c4354cb4
EZ
2443 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2444
d1dfb56c
EZ
2445 Fix regex.c, syntax.c and friends for buffers > 2GB.
2446 * syntax.h (struct gl_state_s): Declare character position members
2447 EMACS_INT.
2448
2449 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2450
04f2d78b
CB
2451 * textprop.c (verify_interval_modification, interval_of):
2452 Declare arguments EMACS_INT.
d1dfb56c
EZ
2453
2454 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2455 EMACS_INT.
2456
2457 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2458
2459 * indent.c (Fvertical_motion): Local variable it_start is now
2460 EMACS_INT.
2461
2462 * regex.c (re_match, re_match_2, re_match_2_internal)
2463 (bcmp_translate, regcomp, regexec, print_double_string)
2464 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2465 (re_compile_pattern, re_exec): Declare arguments and local
2466 variables `size_t' and `ssize_t' and return values `regoff_t', as
2467 appropriate.
2468 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2469 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2470 <compile_stack_type>: `size' and `avail' are now `size_t'.
2471
2472 * regex.h <regoff_t>: Use ssize_t, not int.
2473 (re_search, re_search_2, re_match, re_match_2): Arguments that
2474 specify buffer/string position and length are now ssize_t and
2475 size_t. Return type is regoff_t.
2476
613052cd
BK
24772011-04-16 Ben Key <bkey76@gmail.com>
2478
2479 * nsfont.m: Fixed bugs in ns_get_family and
2480 ns_descriptor_to_entity that were caused by using free to
2481 deallocate memory blocks that were allocated by xmalloc (via
2482 xstrdup). This caused Emacs to crash when compiled with
2483 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2484 --enable-checking=xmallocoverrun). xfree is now used to
2485 deallocate these memory blocks.
2486
4170f62f 24872011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2488
71b41406
PE
2489 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2490
9587a89d
PE
2491 emacs_write: Accept and return EMACS_INT for sizes.
2492 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2493 et seq.
2494 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2495 Accept and return EMACS_INT.
2496 (emacs_gnutls_write): Return the number of bytes written on
2497 partial writes.
2498 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2499 (emacs_read, emacs_write): Remove check for negative size, as the
2500 Emacs source code has been audited now.
9587a89d
PE
2501 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2502 (emacs_read, emacs_write): Use it.
273a5f82
PE
2503 * process.c (send_process): Adjust to the new signatures of
2504 emacs_write and emacs_gnutls_write. Do not attempt to store
2505 a byte offset into an 'int'; it might overflow.
9587a89d 2506 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2507
3e047f51
PE
2508 * sound.c: Don't assume sizes fit in 'int'.
2509 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2510 Return EMACS_INT, not int.
3e047f51 2511 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2512 Accept EMACS_INT, not int.
2513 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2514 record read return values.
2515
cc39a9db
BK
25162011-04-15 Ben Key <bkey76@gmail.com>
2517
c9d0ec6d
JB
2518 * keyboard.c (Qundefined): Don't declare static since it is used
2519 in nsfns.m.
2520 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2521 static since they are used in nsfont.m.
cc39a9db 2522
6c60eb9f
SM
25232011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2524
2525 * process.c (Qprocessp): Don't declare static.
2526 * lisp.h (Qprocessp): Declare again.
2527
7990b61a
JB
25282011-04-15 Juanma Barranquero <lekktu@gmail.com>
2529
2530 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2531
5d4cb038
PE
25322011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2533
8bd7b830 2534 Improve C-level modularity by making more things 'static'.
cd64ea1d 2535
e3b27b31
PE
2536 Don't publish debugger-only interfaces to other modules.
2537 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2538 (verify_bytepos, count_markers): Move decls to the only modules
2539 that need them.
2540 * region-cache.h (pp_cache): Likewise.
2541 * window.h (check_all_windows): Likewise.
2542 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2543
5d4cb038
PE
2544 * sysdep.c (croak): Now static, if
2545 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2546 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2547
2548 * alloc.c (refill_memory_reserve): Now static if
2549 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2550 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2551
e87b6180
PE
2552 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2553 Define only if USE_LUCID.
2554
ac64929e
PE
2555 * xrdb.c (x_customization_string, x_rm_string): Now static.
2556
6f37259d
PE
2557 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2558 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2559
1683e3ab
PE
2560 * xdisp.c (draw_row_with_mouse_face): Now static.
2561 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2562
de9c2632
PE
2563 * window.h (check_all_windows): Mark externally visible.
2564
2b96acb7
PE
2565 * window.c (window_deletion_count): Now static.
2566
2567 * undo.c: Make symbols static if they're not exported.
2568 (last_undo_buffer, last_boundary_position, pending_boundary):
2569 Now static.
2570
50436f33
PE
2571 * textprop.c (interval_insert_behind_hooks): Now static.
2572 (interval_insert_in_front_hooks): Likewise.
2573
64520e5c
PE
2574 * term.c: Make symbols static if they're not exported.
2575 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2576 (max_frame_lines, tty_set_terminal_modes):
2577 (tty_reset_terminal_modes, tty_turn_off_highlight):
2578 (get_tty_terminal): Now static.
2579 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2580 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2581 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2582 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2583 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2584
1fa53021
PE
2585 * sysdep.c: Make symbols static if they're not exported.
2586 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2587 Now static.
2588 (sigprocmask_set, full_mask): Remove; unused.
2589 (wait_debugging): Mark as visible.
2590 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2591 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2592
d4b43b22
PE
2593 * syntax.c (syntax_temp): Define only if !__GNUC__.
2594
b7c513d0
PE
2595 * sound.c (current_sound_device, current_sound): Now static.
2596
989b29ad
PE
2597 * search.c (searchbufs, searchbuf_head): Now static.
2598
13a55a78
PE
2599 * scroll.c (scroll_cost): Remove; unused.
2600 * dispextern.h (scroll_cost): Remove decl.
2601
de68a1fc
PE
2602 * region-cache.h (pp_cache): Mark as externally visible.
2603
40ccffa6
PE
2604 * process.c: Make symbols static if they're not exported.
2605 (process_tick, update_tick, create_process, chan_process):
2606 (Vprocess_alist, proc_buffered_char, datagram_access):
2607 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2608 (deactivate_process): Mark defn as static, as well as decl.
2609 * lisp.h (create_process): Remove decl.
2610 * process.h (chan_process, Vprocess_alist): Remove decls.
2611
ad64fc97
PE
2612 * print.c: Make symbols static if they're not exported.
2613 (print_depth, new_backquote_output, being_printed, print_buffer):
2614 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2615 (print_interval, print_number_index, initial_stderr_stream):
2616 Now static.
2617 * lisp.h (Fprinc): Remove decl.
2618 (debug_output_compilation_hack): Mark as externally visible.
2619
adddb265
PE
2620 * sysdep.c (croak): Move decl from here to syssignal.h.
2621 * syssignal.h (croak): Put it here, so the API can be checked when
2622 'croak' is called from dissociate_if_controlling_tty.
2623
1717ede2
PE
2624 * minibuf.c: Make symbols static if they're not exported.
2625 (minibuf_save_list, choose_minibuf_frame): Now static.
2626 * lisp.h (choose_minibuf_frame): Remove decl.
2627
fa5fb2bc
PE
2628 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2629
1e3890d1
PE
2630 * lread.c: Make symbols static if they're not exported.
2631 (read_objects, initial_obarray, oblookup_last_bucket_number):
2632 Now static.
2633 (make_symbol): Remove; unused.
2634 * lisp.h (initial_obarray, make_symbol): Remove decls.
2635
8a1414fa
PE
2636 * keyboard.c: Make symbols static if they're not exported.
2637 (single_kboard, recent_keys_index, total_keys, recent_keys):
2638 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2639 (this_single_command_key_start, echoing, last_auto_save):
2640 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2641 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2642 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2643 (Vlispy_mouse_stem, double_click_count):
2644 Now static.
2645 (force_auto_save_soon): Define only if SIGDANGER.
2646 (ignore_mouse_drag_p): Now static if
2647 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2648 (print_help): Remove; unused.
2649 (stop_character, last_timer_event): Mark as externally visible.
2650 * keyboard.h (ignore_mouse_drag_p): Declare only if
2651 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2652 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2653 * lisp.h (echoing): Remove decl.
2654 (force_auto_save_soon): Declare only if SIGDANGER.
2655 * xdisp.c (redisplay_window): Simplify code, to make it more
2656 obvious that ignore_mouse_drag_p is not accessed if !defined
2657 USE_GTK && !defined HAVE_NS.
2658
93ea6e8f
PE
2659 * intervals.c: Make symbols static if they're not exported.
2660 (merge_properties_sticky, merge_interval_right, delete_interval):
2661 Now static.
2662 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2663
77382fcc
PE
2664 * insdel.c: Make symbols static if they're not exported.
2665 However, leave prepare_to_modify_buffer alone. It's never
2666 called from outside this function, but that appears to be a bug.
2667 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2668 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2669 (adjust_after_replace_noundo): Remove; unused.
2670 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2671 (signal_before_change): Remove decls.
77382fcc 2672
9306c32e
PE
2673 * indent.c (val_compute_motion, val_vmotion): Now static.
2674
cd44d2eb
PE
2675 * image.c: Make symbols static if they're not exported.
2676 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2677 if USE_GTK.
2678 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2679 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2680
ad9a7a06
PE
2681 * fringe.c (standard_bitmaps): Now static.
2682 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2683
81626931
PE
2684 * frame.c: Make symbols static if they're not exported.
2685 (x_report_frame_params, make_terminal_frame): Now static.
2686 (get_frame_param): Now static, unless HAVE_NS.
2687 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2688 (x_get_resource_string): Remove; not used.
2689 * frame.h (make_terminal_frame, x_report_frame_params):
2690 (x_get_resource_string); Remove decls.
2691 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2692 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2693
239f9db9
PE
2694 * font.c, fontset.c: Make symbols static if they're not exported.
2695 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2696 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2697 * font.c (font_close_object): Now static.
2698 * font.h (font_close_object): Remove.
2699 * fontset.c (FONTSET_OBJLIST): Remove.
2700 (free_realized_fontset) #if-0 the body, which does nothing.
2701 (face_suitable_for_char_p): #if-0, as it's never called.
2702 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2703 * xfaces.c (face_at_string_position):
2704 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2705 since 0 is always ASCII.
2706
dfcf3579
PE
2707 * fns.c (weak_hash_tables): Now static.
2708
5045092b
PE
2709 * fileio.c: Make symbols static if they're not exported.
2710 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2711 (Vwrite_region_annotation_buffers): Now static.
2712
57a96f5c
PE
2713 * eval.c: Make symbols static if they're not exported.
2714 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2715 * lisp.h (backtrace_list): Remove decl.
2716
35f08c38
PE
2717 * emacs.c: Make symbols static if they're not exported.
2718 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2719 (fatal_error_code, fatal_error_signal_hook, standard_args):
2720 Now static.
2721 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2722 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2723 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2724 * lisp.h (fatal_error_signal_hook): Remove decl.
2725 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2726
f44bd759
PE
2727 * editfns.c: Move a (normally-unused) function to its only use.
2728 * editfns.c, lisp.h (get_operating_system_release): Remove.
2729 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2730 worth the hassle of breaking this out.
2731
b532497d
PE
2732 * xterm.c: Make symbols static if they're not exported.
2733 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2734 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2735 (x_destroy_window, x_delete_display):
2736 Now static.
2737 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2738 (x_mouse_leave): Remove; unused.
2739 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2740 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2741 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2742 Remove decls.
2743 (x_mouse_leave): Declare only if WINDOWSNT.
2744 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2745 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2746 USE_X_TOOLKIT.
2747
1675728f
PE
2748 * ftxfont.c: Make symbols static if they're not exported.
2749 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2750 HAVE_FREETYPE.
2751 * font.h (ftxfont_driver): Likewise.
2752
e4cebfca
PE
2753 * xfns.c: Make symbols static if they're not exported.
2754 (x_last_font_name, x_display_info_for_name):
2755 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2756 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2757 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2758 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2759 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2760 (last_show_tip_args): Now static.
2761 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2762 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2763 (x_screen_planes): Remove; unused.
2764 * dispextern.h (x_screen_planes): Remove decl.
2765
5bf46f05
PE
2766 * dispnew.c: Make symbols static if they're not exported.
2767 * dispextern.h (redraw_garbaged_frames, scrolling):
2768 (increment_row_positions): Remove.
2769 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2770 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2771 Now static.
2772 (redraw_garbaged_frames): Remove; unused.
2773
435f4c28
PE
2774 * xfaces.c: Make symbols static if they're not exported.
2775 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2776 Remove decls.
2777 * xterm.h (defined_color): Remove decls.
2778 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2779 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2780 (menu_face_changed_default, defined_color, free_realized_face):
2781 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2782 (ascii_face_of_lisp_face): Remove; unused.
2783
8524aef3
PE
2784 * xdisp.c: Make symbols static if they're not exported.
2785 * dispextern.h (scratch_glyph_row, window_box_edges):
2786 (glyph_to_pixel_coords, set_cursor_from_row):
2787 (get_next_display_element, set_iterator_to_next):
2788 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2789 (show_mouse_face): Remove decls
2790 * frame.h (message_buf_print): Likewise.
2791 * lisp.h (pop_message, set_message, check_point_in_composition):
2792 Likewise.
2793 * xterm.h (set_vertical_scroll_bar): Likewise.
2794 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2795 (message_buf_print, scratch_glyph_row, displayed_buffer):
2796 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2797 (get_next_display_element, show_mouse_face, window_box_edges):
2798 (frame_to_window_pixel_xy, check_point_in_composition):
2799 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2800 (glyph_to_pixel_coords): Remove; unused.
2801
16390cd2
PE
2802 * dired.c (file_name_completion): Now static.
2803
2804 * dbusbind.c (xd_in_read_queued_messages): Now static.
2805
a25f4dfa
PE
2806 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2807 * data.c (circular_list_error): Remove.
2808
14a9c8df
PE
2809 * commands.h (last_point_position, last_point_position_buffer):
2810 (last_point_position_window): Remove decls.
2811 * keyboard.c: Make these variables static.
2812
04f2d78b
CB
2813 * coding.h (coding, code_convert_region, encode_coding_gap):
2814 Remove decls.
74ab6df5
PE
2815 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2816 (iso_code_class, detect_coding, code_convert_region): Now static.
2817 (encode_coding_gap): Remove; unused.
2818
38dfbee1
PE
2819 * chartab.c (chartab_chars, chartab_bits): Now static.
2820
a2cb4e63
PE
2821 * charset.h (charset_iso_8859_1): Remove decl.
2822 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2823 Now static.
2824
127198fd
PE
2825 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2826 * ccl.c (Vccl_program_table): Now static.
2827 (check_ccl_update): Remove; unused.
2828
d85b608f
PE
2829 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2830 * category.h: ... from here.
2831 * category.c (check_category_table, set_category_set): Now static.
2832
31cd66f3
PE
2833 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2834 * lisp.h: Remove these decls.
2835
c358e587
PE
2836 * buffer.c (buffer_count): Remove unused var.
2837
e78aecca
PE
2838 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2839 so that it's not optimized away.
2840 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2841 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2842 exported only to the debugger.
2843
e192d7d3 2844 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2845 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2846
92470028
PE
2847 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2848 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2849 was inaccessible from Lisp.
2850 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2851 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2852
244ed907
PE
2853 alloc.c: Import and export fewer symbols, and remove unused items.
2854 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2855 is defined.
2856 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2857 it's not optimized away by whole-program optimization.
2858 (message_enable_multibyte, free_misc): Remove.
2859 (catchlist, handlerlist, mark_backtrace):
2860 Declare only if BYTE_MARK_STACK.
2861 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2862 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2863 (message_enable_multibyte): Remove decl.
2864 (free_misc, interval_free_list, float_block, float_block_index):
2865 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2866 (cons_free_list, last_marked_index):
2867 Now static.
2868 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2869 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2870 (mark_backtrace): Define only if BYTE_MARK_STACK.
2871 * xdisp.c (message_enable_multibyte): Now static.
2872
61c2b50e 2873 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2874 This makes it easier for human readers (and static analyzers)
2875 to see whether these variables are used from other modules.
2876 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2877 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2878 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2879 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2880 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2881 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2882 * xmenu.c, xselect.c:
2883 Declare Q* vars static if they are not used in other modules.
2884 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2885 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2886 Remove decls of unexported vars.
2887 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2888
95c82688
PE
2889 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2890
16a97296
PE
2891 Make Emacs functions such as Fatom 'static' by default.
2892 This makes it easier for human readers (and static analyzers)
2893 to see whether these functions can be called from other modules.
2894 DEFUN now defines a static function. To make the function external
2895 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2896 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2897 (Finit_image_library):
16a97296
PE
2898 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2899 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2900 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2901 Remove decls, since these functions are now static.
2902 (Funintern, Fget_internal_run_time): New decls, since these functions
2903 were already external.
95c82688 2904
16a97296
PE
2905 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2906 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2907 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2908 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2909 * keyboard.c, keymap.c, lread.c:
2910 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2911 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2912 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2913 Mark functions with DEFUE instead of DEFUN,
2914 if they are used in other modules.
2915 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2916 decls for now-static functions.
2917 * buffer.h (Fdelete_overlay): Remove decl.
2918 * callproc.c (Fgetenv_internal): Mark as internal.
2919 * composite.c (Fremove_list_of_text_properties): Remove decl.
2920 (Fcomposition_get_gstring): New forward static decl.
2921 * composite.h (Fcomposite_get_gstring): Remove decl.
2922 * dired.c (Ffile_attributes): New forward static decl.
2923 * doc.c (Fdocumntation_property): New forward static decl.
2924 * eval.c (Ffetch_bytecode): New forward static decl.
2925 (Funintern): Remove extern decl; now in .h file where it belongs.
2926 * fileio.c (Fmake_symbolic_link): New forward static decl.
2927 * image.c (Finit_image_library): New forward static decl.
2928 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2929 * intervals.h (Fprevious_property_change):
2930 (Fremove_list_of_text_properties): Remove decls.
2931 * keyboard.c (Fthis_command_keys): Remove decl.
2932 (Fcommand_execute): New forward static decl.
2933 * keymap.c (Flookup_key): New forward static decl.
2934 (Fcopy_keymap): Now static.
2935 * keymap.h (Flookup_key): Remove decl.
2936 * process.c (Fget_process): New forward static decl.
2937 (Fprocess_datagram_address): Mark as internal.
2938 * syntax.c (Fsyntax_table_p): New forward static decl.
2939 (skip_chars): Remove duplicate decl.
2940 * textprop.c (Fprevious_property_change): New forward static decl.
2941 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2942 Now internal.
2943 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2944 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2945
785bbd42
PE
2946 * editfns.c (Fformat): Remove unreachable code.
2947
8b913b57
AS
29482011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2949
2950 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2951 change. (Bug#8496)
2952
a6744a35
EZ
29532011-04-13 Eli Zaretskii <eliz@gnu.org>
2954
2955 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2956 when at ZV. (Bug#8487)
2957
e7974947
AS
29582011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2959
baad03f0
AS
2960 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2961 (Bug#8437)
2962 * keyboard.c (parse_tool_bar_item): Likewise.
2963 * sound.c (sound_cleanup, alsa_close): Likewise.
2964 * termcap.c (tgetent): Likewise.
2965 * xfns.c (x_default_font_parameter): Likewise.
2966 * xsettings.c (read_and_apply_settings): Likewise.
2967
e7974947
AS
2968 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2969 (overrun_check_free): Protoize.
2970
28272684
PE
29712011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2972
2973 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2974 since callers should never pass a negative size.
2975 Change the signature to match that of plain 'read' and 'write'; see
2976 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2977 * lisp.h: Update prototypes of emacs_write and emacs_read.
2978
11997c76
EZ
29792011-04-11 Eli Zaretskii <eliz@gnu.org>
2980
2981 * xdisp.c (redisplay_window): Don't try to determine the character
2982 position of the scroll margin if the window start point w->startp
e896f03c 2983 is outside the buffer's accessible region. (Bug#8468)
11997c76 2984
8a2cbd72
EZ
29852011-04-10 Eli Zaretskii <eliz@gnu.org>
2986
2987 Fix write-region and its subroutines for buffers > 2GB.
2988 * fileio.c (a_write, e_write): Modify declaration of arguments and
2989 local variables to support buffers larger than 2GB.
2990 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2991
2992 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2993 argument, local variables, and return value.
2994
2995 * lisp.h: Update prototypes of emacs_write and emacs_read.
2996
2997 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2998
4073e537 29992011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3000
1ebfdcb6
PE
3001 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3002
b2ded58d
PE
3003 Fix more problems found by GCC 4.6.0's static checks.
3004
7d66342c
PE
3005 * xdisp.c (vmessage): Use a better test for character truncation.
3006
bbf47d44
PE
3007 * charset.c (load_charset_map): <, not <=, for optimization,
3008 and to avoid potential problems with integer overflow.
9248994d 3009 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3010 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3011 * editfns.c (Fformat): Likewise.
1e69125e 3012 * syntax.c (skip_chars): Likewise.
3befa583 3013
e3019616
PE
3014 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3015 This also lets GCC 4.6.0 generate slightly better loop code.
3016
becfa255
PE
3017 * callint.c (Fcall_interactively): <, not <=, for optimization.
3018 (Fcall_interactively): Count the number of arguments produced,
3019 not the number of arguments given. This is simpler and lets GCC
3020 4.6.0 generate slightly better code.
3021
dae0cd48
PE
3022 * ftfont.c: Distingish more carefully between FcChar8 and char.
3023 The previous code passed unsigned char * to a functions like
3024 strlen and xstrcasecmp that expect char *, which does not
3025 conform to the C standard.
3026 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3027 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3028 char * when the C standard requires it.
3029
76032d70
PE
3030 * keyboard.c (read_char): Remove unused var.
3031
eb3f1cc8
PE
3032 * eval.c: Port to Windows vsnprintf (Bug#8435).
3033 Include <limits.h>.
3034 (SIZE_MAX): Define if the headers do not.
3035 (verror): Do not give up if vsnprintf returns a negative count.
3036 Instead, grow the buffer. This ports to Windows vsnprintf, which
3037 does not conform to C99. Problem reported by Eli Zaretskii.
3038 Also, simplify the allocation scheme, by avoiding the need for
3039 calling realloc, and removing the ALLOCATED variable.
3040
70476b54
PE
3041 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3042
12020a9e
PE
3043 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3044 But keep the doprint source code for now, as we might revamp it
3045 and use it again (Bug#8435).
ea6c7ae6
PE
3046 * lisp.h (doprnt): Remove.
3047 * Makefile.in (base_obj): Remove doprnt.o.
3048 * deps.mk (doprnt.o): Remove.
3049
5fdb398c
PE
3050 error: Print 32- and 64-bit integers portably (Bug#8435).
3051 Without this change, on typical 64-bit hosts error ("...%d...", N)
3052 was used to print both 32- and 64-bit integers N, which relied on
3053 undefined behavior.
3054 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3055 New macro.
3056 * lisp.h (error, verror): Mark as printf-like functions.
3057 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3058 Report overflow in size calculations when allocating printf buffer.
3059 Do not truncate output string at its first null byte.
3060 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3061 Truncate the output at a character boundary, since vsnprintf does not
3062 do that.
3063 * charset.c (check_iso_charset_parameter): Convert internal
3064 character to string before calling 'error', since %c now has the
3065 printf meaning.
3066 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3067 overflow when computing char to be passed to 'error'. Do not
3068 pass Lisp_Object to 'error'; pass the integer instead.
3069 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3070 formatted with plain %d.
3071
b189fa66
PE
3072 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3073
bff87ef0
PE
3074 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3075
7e2cac20
PE
3076 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3077
ce4d90b5
PE
3078 * xterm.c (x_catch_errors): Remove duplicate declaration.
3079
266c9547
PE
3080 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3081
79c49ad2
PE
3082 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3083
368f4090
JM
30842011-04-10 Jim Meyering <meyering@redhat.com>
3085
3086 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3087 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3088 return ssize_t not "int", and use size_t as the buffer length.
3089 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3090 * gnutls.h: Update declarations.
3091 * process.c (read_process_output): Use ssize_t, to match.
3092 (send_process): Likewise.
3093
a32d4040
CY
30942011-04-09 Chong Yidong <cyd@stupidchicken.com>
3095
3096 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3097
8546720e 30982011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3099
04f2d78b
CB
3100 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3101 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3102
8546720e
GM
3103 * xterm.c (handle_one_xevent):
3104 * xmenu.c (create_and_show_popup_menu):
3105 * xselect.c (x_decline_selection_request)
3106 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3107
0a2f5c1a 31082011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3109
3110 Fix some uses of `int' instead of EMACS_INT.
3111 * search.c (string_match_1, fast_string_match)
3112 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3113 (scan_buffer, find_next_newline_no_quit)
3114 (find_before_next_newline, search_command, Freplace_match)
3115 (Fmatch_data): Make some `int' variables be EMACS_INT.
3116
3117 * xdisp.c (display_count_lines): 3rd argument and return value now
3118 EMACS_INT. All callers changed.
3119 (pint2hrstr): Last argument is now EMACS_INT.
3120
3121 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3122 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3123 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3124 (decode_coding_utf_16, decode_coding_emacs_mule)
3125 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3126 (decode_coding_ccl, decode_coding_charset)
3127 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3128 (decode_coding_iso_2022, decode_coding_emacs_mule)
3129 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3130 <char_offset, last_offset>: Declare EMACS_INT.
3131 (encode_coding_utf_8, encode_coding_utf_16)
3132 (encode_coding_emacs_mule, encode_invocation_designation)
3133 (encode_designation_at_bol, encode_coding_iso_2022)
3134 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3135 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3136 Declare EMACS_INT.
3137 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3138 (encode_invocation_designation): Last argument P_NCHARS is now
3139 EMACS_INT.
3140 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3141 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3142
3143 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3144 All users changed.
3145
3146 * ccl.c (Fccl_execute_on_string): Declare some variables
3147 EMACS_INT.
3148
8546720e 31492011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3150
3151 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3152
4e19a977
CS
31532011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3154
3155 * process.c (Fformat_network_address): Doc fix.
3156
87302331
R
31572011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3158
3159 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3160
cbb59342
CY
31612011-04-08 Chong Yidong <cyd@stupidchicken.com>
3162
3163 * keyboard.c (read_char): Call Lisp function help-form-show,
3164 instead of using internal_with_output_to_temp_buffer.
3165 (Qhelp_form_show): New var.
e0d38eeb 3166 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3167
3168 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3169
3170 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3171
e67a13ab
CY
31722011-04-06 Chong Yidong <cyd@stupidchicken.com>
3173
04f2d78b
CB
3174 * process.c (Flist_processes): Remove to Lisp.
3175 (list_processes_1): Delete.
e67a13ab 3176
973f782d
EZ
31772011-04-06 Eli Zaretskii <eliz@gnu.org>
3178
7c106b1e
EZ
3179 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3180
973f782d
EZ
3181 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3182
41cf7d1a 31832011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3184
ca23cc88
PE
3185 Fix more problems found by GCC 4.6.0's static checks.
3186
f390e2d5
PE
3187 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3188
42eea0d0
PE
3189 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3190
b69769da 3191 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3192
f9541e84
PE
3193 * xdisp.c (vmessage): Mark as a printf-like function.
3194
13841b55
PE
3195 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3196
c136c10f
PE
3197 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3198
5e2d4a30
PE
3199 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3200 printf-like functions.
3201 (tiff_load): Add casts to remove these marks before passing them
3202 to system-supplied API.
3203
583f48b9
PE
3204 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3205
b25d760e
PE
3206 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3207 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3208 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3209 directly, rather than having caller test rule sign. This avoids
3210 some unnecessary tests.
3211 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3212 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3213 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3214
bc7b6697 3215 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3216 (xfont_open): Avoid unnecessary tests.
bc7b6697 3217
27ccc379
PE
3218 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3219
dcd5c89a
PE
3220 * composite.h, composite.c (composition_gstring_put_cache):
3221 Use EMACS_INT, not int, for length.
3222
b13a45c6
PE
3223 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3224 breaking out part of COMPOSITION_DECODE_RULE.
3225 (COMPOSITION_DECODE_RULE): Use it.
3226 * composite.c (get_composition_id): Remove unused local vars,
3227 by using the new macro.
3228
1e792e4d
PE
3229 * textprop.c (set_text_properties_1): Change while to do-while,
3230 since the condition is always true at first.
3231
dc6c6455 3232 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3233 (interval_deletion_adjustment): Return unsigned value.
3234 All uses changed.
dc6c6455 3235
aba7731a
PE
3236 * process.c (list_processes_1, create_pty, read_process_output):
3237 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3238 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3239 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3240 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3241 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3242
fdfc4bf3
PE
3243 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3244
fca8fe46 3245 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3246 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3247
06a0259a 3248 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3249 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3250 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3251
e7b9e80f
PE
3252 * print.c (print_error_message): Avoid int overflow.
3253
56201685
PE
3254 * font.c (font_list_entities): Redo for clarity,
3255 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3256
78834453 3257 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3258 (font_score): Avoid potential overflow in diff calculation.
78834453 3259
0bc0b309 3260 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3261 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3262
e610eaca
PE
3263 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3264
b895abce
PE
3265 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3266 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3267 can always succeed if overflow has undefined behavior.
3268
1f1d9321 3269 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3270 (wordify): Omit three unnecessary tests.
1f1d9321 3271
c59478bc
PE
3272 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3273 All callers changed. This avoids the need for an unused var.
3274
79b73827
PE
3275 * casefiddle.c (casify_region): Remove var that is set but not used.
3276
a4db5dfe
PE
3277 * dired.c (file_name_completion): Remove var that is set but not used.
3278
43aae36e
PE
3279 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3280
2a47c44d 3281 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3282 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3283
a37c69bf
PE
3284 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3285 Check for integer overflow on size calculations.
3286
328ab8e7
PE
3287 * buffer.c (Fprevious_overlay_change): Remove var that is set
3288 but not used.
3289
e5a2a5cb
PE
3290 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3291 Remove vars that are set but not used.
8d84a6eb 3292 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3293 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3294
a60e5f68
PE
3295 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3296
f661cb61 3297 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3298 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3299
f0397f5a
PE
3300 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3301 that are set but not used.
3302
8664db06 3303 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3304 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3305
6abdaa4a
PE
3306 * xselect.c (x_get_local_selection, x_handle_property_notify):
3307 Remove vars that are set but not used.
3308
0ce7538d 3309 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3310 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3311
9ae848fc
PE
3312 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3313 Remove var that is set but not used.
0b918413
PE
3314 (scroll_bar_windows_size): Now size_t, not int.
3315 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3316 Check for overflow.
9ae848fc 3317
a5a62657
PE
3318 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3319 (map_tty_color) [!defined MSDOS]: Likewise.
3320
5c5cdd39
PE
3321 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3322
66ebf983
PE
3323 * coding.c: Remove vars that are set but not used.
3324 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3325 All callers changed.
3326 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3327 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3328 (decode_coding_charset): Remove vars that are set but not used.
3329
1be4d761
PE
3330 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3331 that is set but not used.
3332
47553fa8
PE
3333 * print.c (print_object): Remove var that is set but not used.
3334
1f7196bf 3335 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3336 The gnulib version avoids calling malloc in the usual case,
3337 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3338 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3339 * filelock.c (current_lock_owner): Likewise.
3340 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3341 * sysdep.c: Include allocator.h, careadlinkat.h.
3342 (emacs_no_realloc_allocator): New static constant.
3343 (emacs_readlink): New function.
fdb61804
PE
3344 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3345 ../lib/careadlinkat.h.
d1fdcab7 3346
f84c17c7
SM
33472011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3348
3349 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3350 first non-nil return value).
3351
ef3862ad
JD
33522011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3353
3354 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3355 if not defined (Bug#8403).
3356
376a7006
JB
33572011-04-02 Juanma Barranquero <lekktu@gmail.com>
3358
3359 * xdisp.c (display_count_lines): Remove parameter `start',
3360 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3361 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3362 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3363 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3364 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3365 and thereabouts. All callers changed.
3366 (get_per_char_metric): Remove parameter `f', unused since
3367 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3368
6ca3801d
JM
33692011-04-02 Jim Meyering <meyering@redhat.com>
3370
3371 do not dereference NULL upon failed strdup
3372 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3373 (ns_get_family): Likewise.
3374
d8e2b5ba
JB
33752011-04-02 Juanma Barranquero <lekktu@gmail.com>
3376
3377 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3378
8c74fcbd
JD
33792011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3380
3381 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3382 later (Bug#8403).
3383
7200d79c
SM
33842011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3385
03408648 3386 Add lexical binding.
7200d79c 3387
03408648
SM
3388 * window.c (Ftemp_output_buffer_show): New fun.
3389 (Fsave_window_excursion):
3390 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3391
3392 * lread.c (lisp_file_lexically_bound_p): New function.
3393 (Fload): Bind Qlexical_binding.
3394 (readevalloop): Remove `evalfun' arg.
3395 Bind Qinternal_interpreter_environment.
3396 (Feval_buffer): Bind Qlexical_binding.
3397 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3398 Mark as dynamic.
3399 (syms_of_lread): Declare `lexical-binding'.
3400
3401 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3402
3403 * keyboard.c (eval_dyn): New fun.
3404 (menu_item_eval_property): Use it.
ca105506
SM
3405
3406 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3407
03408648
SM
3408 * fns.c (concat, mapcar1): Accept byte-code-functions.
3409
3410 * eval.c (Fsetq): Handle lexical vars.
3411 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3412 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3413 (FletX, Flet): Obey lexical binding.
3414 (Fcommandp): Handle closures.
3415 (Feval): New `lexical' arg.
3416 (eval_sub): New function extracted from Feval. Use it almost
3417 everywhere where Feval was used. Look up vars in lexical env.
3418 Handle closures.
3419 (Ffunctionp): Move from subr.el.
3420 (Ffuncall): Handle closures.
3421 (apply_lambda): Remove `eval_flags'.
3422 (funcall_lambda): Handle closures and new byte-code-functions.
3423 (Fspecial_variable_p): New function.
3424 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3425 but without exporting it to Lisp.
23aba0ea 3426
23aba0ea 3427 * doc.c (Fdocumentation, store_function_docstring):
03408648 3428 * data.c (Finteractive_form): Handle closures.
23aba0ea 3429
03408648
SM
3430 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3431 interactive spec.
ba83908c 3432
04f2d78b
CB
3433 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3434 New byte-codes.
03408648
SM
3435 (exec_byte_code): New function extracted from Fbyte_code to handle new
3436 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3437
03408648 3438 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3439
03408648 3440 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3441
e2abce01
JB
34422011-03-31 Juanma Barranquero <lekktu@gmail.com>
3443
3444 * xdisp.c (redisplay_internal): Fix prototype.
3445
63696a73 34462011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3447
63696a73 3448 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3449 (try_scrolling): Use it when setting scroll_limit.
3450 Limit scrolling to 100 screen lines.
63696a73
EZ
3451 (redisplay_window): Even when falling back on "recentering",
3452 position point in the window according to scroll-conservatively,
3453 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3454
3455 (try_scrolling): When point is above the window, allow searching
3456 as far as scroll_max, or one screenful, to compute vertical
3457 distance from PT to the scroll margin position. This prevents
3458 try_scrolling from unnecessarily failing when
3459 scroll-conservatively is set to a value slightly larger than the
3460 window height. Clean up the case of PT below the margin at bottom
3461 of window: scroll_max can no longer be INT_MAX. When aggressive
3462 scrolling is in use, don't let point enter the opposite scroll
3463 margin as result of the scroll.
3464 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3465 threshold of 100 lines for never-recentering scrolling.
3466
e4cc2dfc
JB
34672011-03-31 Juanma Barranquero <lekktu@gmail.com>
3468
3469 * dispextern.h (move_it_by_lines):
3470 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3471 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3472 (message_log_check_duplicate): Remove parameters `prev_bol' and
3473 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3474 (redisplay_internal): Remove parameter `preserve_echo_area',
3475 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3476
3477 * indent.c (Fvertical_motion):
3478 * window.c (window_scroll_pixel_based, Frecenter):
3479 Don't pass `need_y_p' to `move_it_by_lines'.
3480
1c470562
SM
34812011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3482
44f230aa
SM
3483 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3484 steal a few bits to be more compact.
3485 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3486 Remove unneeded casts.
3487
1c470562
SM
3488 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3489
888adce9
ZK
34902011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3491
3492 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3493 binding" message (bug#7967).
3494
f838ed7b
PE
34952011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3496
77861b95
PE
3497 Fix more problems found by GCC 4.6.0's static checks.
3498
de6dbc14
PE
3499 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3500 Remove unused local var.
3501
f838ed7b
PE
3502 * editfns.c (Fmessage_box): Remove unused local var.
3503
792c7b2b
PE
3504 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3505 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3506 Omit unused local vars.
c499e557 3507 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3508 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3509 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3510 Omit unused local var.
3511
ba0165e1
PE
3512 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3513 Don't assume string length fits in int.
32ad8845 3514 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3515 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3516
3c59b4c9
PE
3517 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3518 instead of alloca (Bug#8344).
3519
a3eed478 3520 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3521 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3522
eb4d412d
PE
3523 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3524
1658b401
PE
3525 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3526 concerns.
3527
3528 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3529
3530 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3531
9a2c6e05
PE
3532 * keyboard.c (syms_of_keyboard): Use the same style as later
3533 in this function when indexing through an array. This also
3534 works around GCC bug 48267.
3535
03d0a109
PE
3536 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3537
44f730c8
PE
3538 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3539
fe75f926
PE
3540 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3541 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3542
ffa8c828
PE
3543 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3544 This avoids undefined behavior on integer overflow, and is a bit
3545 more convenient anyway since it is compared to a size_t variable.
3546
c5101a77
PE
3547 Variadic C functions now count arguments with size_t, not int.
3548 This avoids an unnecessary limitation on 64-bit machines, which
3549 caused (substring ...) to crash on large vectors (Bug#8344).
3550 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3551 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3552 All variadic functions and their callers changed accordingly.
c5101a77
PE
3553 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3554 * data.c (arith_driver, float_arith_driver): Likewise.
3555 * editfns.c (general_insert_function): Likewise.
3556 * eval.c (struct backtrace.nargs, interactive_p)
3557 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3558 (funcall_lambda, mark_backtrace): Likewise.
3559 * fns.c (concat): Likewise.
3560 * frame.c (x_set_frame_parameters): Likewise.
3561 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3562 0 if not found, not -1. All callers changed.
3563
dd3f25f7
PE
3564 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3565 (stack_copy_size): Now size_t, not int.
3566 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3567
461c2ab9
JB
35682011-03-28 Juanma Barranquero <lekktu@gmail.com>
3569
3570 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3571 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3572 All callers changed.
3573
3574 * lisp.h (multibyte_char_to_unibyte):
3575 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3576 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3577 * character.h (CHAR_TO_BYTE8):
3578 * cmds.c (internal_self_insert):
3579 * editfns.c (general_insert_function):
3580 * keymap.c (push_key_description):
3581 * search.c (Freplace_match):
3582 * xdisp.c (message_dolog, set_message_1): All callers changed.
3583
f6d62986
SM
35842011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3585
3586 * keyboard.c (safe_run_hook_funcall): New function.
3587 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3588 don't set the hook to nil, but remove the offending function instead.
3589 (Qcommand_hook_internal): Remove, unused.
3590 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3591 Vcommand_hook_internal.
3592
3593 * eval.c (enum run_hooks_condition): Remove.
3594 (funcall_nil, funcall_not): New functions.
3595 (run_hook_with_args): Call each function through a `funcall' argument.
3596 Remove `cond' argument, now redundant.
3597 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3598 (Frun_hook_with_args_until_failure): Adjust accordingly.
3599 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3600
1db5b1ad
JB
36012011-03-28 Juanma Barranquero <lekktu@gmail.com>
3602
3603 * dispextern.h (string_buffer_position): Remove declaration.
3604
3605 * print.c (strout): Remove parameter `multibyte', unused since
3606 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3607
3608 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3609 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3610 All callers changed.
3611
3612 * w32.c (_wsa_errlist): Use braces for struct initializers.
3613
3614 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3615 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3616 All callers changed.
3617 (string_buffer_position): Likewise. Also, make static (it's never
3618 used outside xdisp.c).
3619 (cursor_row_p): Remove parameter `w', unused since
3620 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3621 (decode_mode_spec): Remove parameter `precision', introduced during
3622 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3623 All callers changed.
3624
5ffb62aa
JD
36252011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3626
3627 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3628
461c2ab9 36292011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3630
3631 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3632 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3633 (ns_update_auto_hide_menu_bar): New functions.
3634 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3635 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3636 ns_constrain_all_frames.
3637 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3638 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3639
5c380ffb
JD
36402011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3641
3642 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3643
9af30bdf
GM
36442011-03-27 Glenn Morris <rgm@gnu.org>
3645
3646 * syssignal.h: Replace RETSIGTYPE with void.
3647 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3648 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3649 Replace SIGTYPE with void everywhere.
3650 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3651 * s/template.h (SIGTYPE): Remove commented out definition.
3652
e2abce01
JB
36532011-03-26 Eli Zaretskii <eliz@gnu.org>
3654
3655 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3656 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3657
f868cd8a
JB
36582011-03-26 Juanma Barranquero <lekktu@gmail.com>
3659
59eb0929
JB
3660 * w32.c (read_unc_volume): Use parameter `henum', instead of
3661 global variable `wget_enum_handle'.
3662
3663 * keymap.c (describe_vector): Remove parameters `indices' and
3664 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3665 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3666
f868cd8a
JB
3667 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3668
3669 * keyboard.c (timer_check): Remove parameter `do_it_now',
3670 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3671 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3672 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3673
3674 * keyboard.c (read_char):
3675 * w32menu.c (w32_menu_display_help):
3676 * xmenu.c (show_help_event, menu_help_callback):
3677 Adjust calls to `show_help_echo'.
3678
3679 * gtkutil.c (xg_maybe_add_timer):
3680 * keyboard.c (readable_events):
3681 * process.c (wait_reading_process_output):
3682 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3683
3684 * insdel.c (adjust_markers_gap_motion):
3685 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3686 (gap_left, gap_right): Don't call it.
3687
2ecf6fdb
CY
36882011-03-25 Chong Yidong <cyd@stupidchicken.com>
3689
3690 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3691 incurred during fontification.
3692
6b1f9ba4
JB
36932011-03-25 Juanma Barranquero <lekktu@gmail.com>
3694
3695 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3696 (DEFVAR_PER_BUFFER): Don't pass it.
3697
3698 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3699 (scrolling_window): Don't pass it.
3700
0f4a96b5
JB
37012011-03-25 Juanma Barranquero <lekktu@gmail.com>
3702
3703 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3704
3705 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3706 and `suffix'.
3707 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3708 of variables specific to SELinux and computation of `encoded_absname'.
3709
3710 * image.c (XPutPixel): Remove unused variable `height'.
3711
3712 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3713
3714 * unexw32.c (get_section_info): Remove unused variable `section'.
3715
3716 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3717 (system_process_attributes): Remove unused variable `sess'.
3718 (sys_read): Remove unused variable `err'.
3719
3720 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3721 (w32_wnd_proc): Remove unused variable `isdead'.
3722 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3723 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3724 (x_create_tip_frame): Remove unused variable `tem'.
3725
3726 * w32inevt.c (w32_console_read_socket):
3727 Remove unused variable `no_events'.
3728
3729 * w32term.c (x_draw_composite_glyph_string_foreground):
3730 Remove unused variable `width'.
3731
1149507c
JB
37322011-03-24 Juanma Barranquero <lekktu@gmail.com>
3733
3734 * w32term.c (x_set_glyph_string_clipping):
3735 Don't pass uninitialized region to CombineRgn.
3736
9c88f339
JB
37372011-03-23 Juanma Barranquero <lekktu@gmail.com>
3738
3739 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3740 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3741 (Fx_close_connection): Remove unused variable `i'.
3742
3743 * w32font.c (w32font_draw): Return number of glyphs.
3744 (w32font_open_internal): Remove unused variable `i'.
3745 (w32font_driver): Add missing initializer.
3746
3747 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3748 (fill_in_menu): Remove unused variable `items_added'.
3749
3750 * w32term.c (last_mouse_press_frame): Remove static global variable.
3751 (w32_clip_to_row): Remove unused variable `f'.
3752 (x_delete_terminal): Remove unused variable `i'.
3753
3754 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3755 (NOTHING): Remove unused static global variable.
3756 (uniscribe_check_otf): Remove unused variable `table'.
3757 (uniscribe_font_driver): Add missing initializers.
3758
dee091a3
JD
37592011-03-23 Julien Danjou <julien@danjou.info>
3760
3761 * term.c (Fsuspend_tty, Fresume_tty):
3762 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3763 * window.c (temp_output_buffer_show):
3764 * insdel.c (signal_before_change):
3765 * frame.c (Fhandle_switch_frame):
3766 * fileio.c (Fdo_auto_save):
3767 * emacs.c (Fkill_emacs):
3768 * editfns.c (save_excursion_restore):
3769 * cmds.c (internal_self_insert):
3770 * callint.c (Fcall_interactively):
3771 * buffer.c (Fkill_all_local_variables):
3772 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3773 Use Frun_hooks.
0f4a96b5 3774 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3775 unconditionnaly since it does the check itself.
3776
2c520ab5 37772011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3778
c9c49752
PE
3779 Fix more problems found by GCC 4.5.2's static checks.
3780
8abc3f12
PE
3781 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3782 the first time through the loop, since we know p0 < p1 then.
3783 This also avoids a gcc -Wstrict-overflow warning.
3784
a2d26660
PE
3785 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3786 leading to a memory leak, possible in functions like
3787 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3788 of objects (Bug#8318).
a2d26660 3789
916c72e9
PE
3790 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3791 that could (at least in theory) be that large.
3792
19ab8a18
PE
3793 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3794 This is less likely to overflow, and avoids undefined behavior if
3795 overflow does occur. All callers changed. Use strtoul to scan
3796 for the unsigned long integer.
b7cbbd6f
PE
3797 (pint2hrstr): Simplify and tune code slightly.
3798 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3799
f0641eff
PE
3800 * scroll.c (do_scrolling): Work around GCC bug 48228.
3801 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3802
7f650bb9
PE
3803 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3804 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3805 (validate_x_resource_name): Simplify count usage.
3806 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3807
37dd57d1
PE
3808 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3809 fail (Bug#8306).
81e56e61 3810
699979fc 3811 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3812
401bf9b4
PE
3813 * process.c (Fmake_network_process): Use socklen_t, not int,
3814 where POSIX says socklen_t is required in portable programs.
3815 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3816 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3817 (Fmake_network_process, server_accept_connection):
3818 (wait_reading_process_output, read_process_output):
3819 Likewise.
3820
b93aacde
PE
3821 * process.c: Rename or move locals to avoid shadowing.
3822 (list_processes_1, Fmake_network_process):
3823 (read_process_output_error_handler, exec_sentinel_error_handler):
3824 Rename or move locals.
4dc343ee 3825 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3826 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3827 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3828 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3829 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3830
af8a867c 3831 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3832 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3833 Include tparam.h instead, since it declares them.
af8a867c
PE
3834 * cm.h (PC): Remove extern decl; tparam.h now does this.
3835 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3836 * terminfo.c: Include tparam.h, to check interfaces.
3837 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3838 (tparam): Adjust signature to match interface in tparam.h;
3839 this removes some undefined behavior. Check that outstring and len
3840 are zero, which they always are with Emacs.
3841 * tparam.h (PC, BC, UP): New extern decls.
3842
0248044d 3843 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3844 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3845
8ff096c1 3846 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3847 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3848 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3849 (ftfont_list): Remove unused local.
49eaafba
PE
3850 (get_adstyle_property, ftfont_pattern_entity):
3851 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3852 Rename locals to avoid shadowing.
8ff096c1 3853
e2be39f6
PE
3854 * xfont.c (xfont_list_family): Mark var as initialized.
3855
c9735e30
PE
3856 * xml.c (make_dom): Now static.
3857
8f5201ae
PE
3858 * composite.c (composition_compute_stop_pos): Rename local to
3859 avoid shadowing.
b246f932
PE
3860 (composition_reseat_it): Remove unused locals.
3861 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3862 (composition_update_it): Mark var as initialized.
11b61122
PE
3863 (find_automatic_composition): Mark vars as initialized,
3864 with a FIXME (Bug#8290).
8f5201ae 3865
760fbc2c
PE
3866 character.h: Rename locals to avoid shadowing.
3867 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3868 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3869 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3870 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3871 to avoid shadowing.
3872
ff08eb85
PE
3873 * textprop.c (property_change_between_p): Remove; unused.
3874
fc7bf025
PE
3875 * intervals.c (interval_start_pos): Now static.
3876
235d7abc
PE
3877 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3878
44f230aa
SM
3879 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3880 Rename locals to avoid shadowing.
3e7d6594 3881
50060332
PE
3882 * sound.c (wav_play, au_play, Fplay_sound_internal):
3883 Fix pointer signedness.
d01f234b 3884 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3885 (wav_play): Initialize a variable to 0, to prevent undefined
3886 behavior (Bug#8278).
50060332 3887
c4fc4e30
PE
3888 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3889
918436ed
PE
3890 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3891
c939f91b
PE
3892 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3893 clobbering (Bug#8298).
b9c7f648
PE
3894 * sysdep.c (sys_subshell): Likewise.
3895 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3896
6bd8c144
PE
3897 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3898 This should get cleaned up, so that child_setup has the
3899 same signature on all platforms.
3900
7710357c 3901 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3902 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3903
c59da222
CY
39042011-03-22 Chong Yidong <cyd@stupidchicken.com>
3905
3906 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3907 not to be necessary, and produces flickering.
3908
66b87493
GM
39092011-03-20 Glenn Morris <rgm@gnu.org>
3910
3911 * config.in: Remove file.
3912
45b6f6d5
JB
39132011-03-20 Juanma Barranquero <lekktu@gmail.com>
3914
3915 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3916 are now in src/globals.h.
3917 (syms_of_minibuf): Remove spurious & from previous change.
3918
3ec03f7e
LL
39192011-03-20 Leo <sdl.web@gmail.com>
3920
3921 * minibuf.c (completing-read-function): New variable.
3922 (completing-read-default): Rename from completing-read.
3923 (completing-read): Call completing-read-function.
3924
b14e3e21
CY
39252011-03-19 Juanma Barranquero <lekktu@gmail.com>
3926
3927 * xfaces.c (Fx_load_color_file):
3928 Read color file from absolute filename (bug#8250).
3929
f2b726e6
JB
39302011-03-19 Juanma Barranquero <lekktu@gmail.com>
3931
3932 * makefile.w32-in: Update dependencies.
3933
09f6ff02
EZ
39342011-03-17 Eli Zaretskii <eliz@gnu.org>
3935
3936 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3937
29a6015a
PE
39382011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3939
a3a6c54e
PE
3940 Fix more problems found by GCC 4.5.2's static checks.
3941
b766f867
PE
3942 * process.c (make_serial_process_unwind, send_process_trap):
3943 (sigchld_handler): Now static.
3944
be02381c
PE
3945 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3946 That way, the code declares only the vars that it needs.
3947 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3948 * s/cygwin.h (PTY_ITERATION): Likewise.
3949 * s/darwin.h (PTY_ITERATION): Likewise.
3950 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3951
57048744
PE
3952 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3953 * process.c (allocate_pty): Don't declare stb unless it's needed.
3954
7914961c 3955 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3956 (CONSTANTLIM): Remove; unused.
3957 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3958 Define only if needed.
7914961c 3959
b3967b18
PE
3960 * unexelf.c (unexec): Name an expression,
3961 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3962 Use a different way to cause a compilation error if anyone uses
3963 n rather than nn, a way that does not involve shadowing.
73366a00 3964 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3965
29a6015a
PE
3966 * deps.mk (unexalpha.o): Remove; unused.
3967
43cfc33e 3968 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3969 * unexec.h: New file.
ce701a33
PE
3970 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3971 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3972 Depend on unexec.h.
3973 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3974 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3975 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3976 Change as necessary to match prototype in unexec.h.
ce701a33 3977
01f44d5a
PE
3978 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3979 shadowing.
4f63c6bb 3980 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3981
a6670b0b
PE
3982 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3983 Rename locals to avoid shadowing.
3984
cef2010d 3985 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3986 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3987
d4d7173a
PE
3988 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3989
f08b802a
PE
3990 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3991 warning when compiling print.c.
3992
3ddb0639
PE
3993 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3994 instead of using an uninitialized var.
5ad03b97 3995 (font_sort_entities): Mark var as initialized.
3ddb0639 3996
170a2692
PE
3997 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3998
e663c700
PE
3999 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4000 pointers to constants.
89bc529a 4001 (font_parse_fcname): Remove unused vars.
7b81e2d0 4002 (font_delete_unmatched): Now static.
ea838e10 4003 (font_get_spec): Remove; unused.
13a547c6
PE
4004 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4005 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4006 Rename or move locals to avoid shadowing.
e663c700 4007
2a80c887 4008 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4009 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4010
1384fa33 4011 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4012 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4013
8b2c52e9
PE
4014 * alloc.c (mark_backtrace): Move decl from here ...
4015 * lisp.h: ... to here, so that it can be checked.
4016
475545b5 4017 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4018 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4019 (lisp_indirect_variable): Name an expression,
4020 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4021 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4022
b1349114 4023 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4024 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4025 Use const pointer when appropriate.
b1349114 4026
a2928364
PE
4027 * lisp.h (get_system_name, get_operating_system_release):
4028 Move decls here, to check interfaces.
4029 * process.c (get_operating_system_release): Move decl to lisp.h.
4030 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4031 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4032 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4033 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4034 (Fformat_time_string, Fencode_time, Finsert_char):
4035 (Ftranslate_region_internal, Fformat):
4036 Rename or remove local vars to avoid shadowing.
9710023e 4037 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4038
a415e694
PE
4039 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4040 avoid shadowing.
4041
8ef4622d
PE
4042 * lisp.h (eassert): Check that the argument compiles, even if
4043 ENABLE_CHECKING is not defined.
4044
946f9a5b
PE
4045 * data.c (Findirect_variable): Name an expression, to avoid
4046 gcc -Wbad-function-cast warning.
112396d6 4047 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4048 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4049 (Fmake_variable_buffer_local, Fmake_local_variable):
4050 Mark variables as initialized.
52746918 4051 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4052
e5aab7e7 4053 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4054 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4055 Rename locals to avoid shadowing.
dff45157
PE
4056 (mark_stack): Move local variables into the #ifdef region where
4057 they're used.
7bc26fdb
PE
4058 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4059 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4060 needed otherwise.
4061 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4062 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4063 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4064
e5aab7e7
PE
4065 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4066 avoids undefined behavior in theory.
4067
4da60324
PE
4068 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4069
88043301
PE
4070 Use functions, not macros, for up- and down-casing (Bug#8254).
4071 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4072 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4073 to use the following functions instead of these macros.
4074 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4075 EMACS_INT, since callers assume the returned value fits in int.
4076 (upcase1): Likewise, for UPCASE_TABLE.
4077 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4078 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4079 the race-condition problem in the old DOWNCASE.
88043301 4080
19ed5445
PE
4081 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4082 Rename locals to avoid shadowing.
4083 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4084 (regex_compile, re_search_2, re_match_2_internal):
4085 Remove unused local vars.
952db0d7
PE
4086 (FREE_VAR): Rewrite so as not to use empty "else",
4087 which gcc can warn about.
da053e48 4088 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4089 (RETALLOC_IF): Define only if needed.
4090 (WORDCHAR_P): Likewise. This one is never needed, but is used
4091 only in a comment talking about a compiler bug, so put inside
4092 the #if 0 of that comment.
4093 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4094 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4095 Remove; unused.
19ed5445 4096
1f3561e4 4097 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4098 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4099 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4100
ded6f8f7
PE
4101 * search.c (simple_search): Remove unused var.
4102
dbd37a95
PE
4103 * dired.c (compile_pattern): Move decl from here ...
4104 * lisp.h: ... to here, so that it can be checked.
4105 (struct re_registers): New forward decl.
4106
7e47afad
PE
4107 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4108
85f24f61
PE
4109 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4110 All uses changed.
4111 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4112 Rename locals to avoid shadowing.
5671df8f 4113 (Fvertical_motion): Mark locals as initialized.
85f24f61 4114
181aa2be 4115 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4116 (casify_region): Mark local as initialized.
181aa2be 4117
930d429c
PE
4118 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4119
7082eac6
PE
4120 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4121 New macros, so that the caller can use some names other than
4122 gcpro1, gcpro2, etc.
4123 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4124 of the new macros.
4125 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4126 argument, for consistency with GCPRO2_VAR, etc: it is now the
4127 prefix of the variable, not the variable itself. All uses
4128 changed.
38b2c076
PE
4129 * dired.c (directory_files_internal, file_name_completion):
4130 Rename locals to avoid shadowing.
4131
15206ed9
PE
4132 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4133 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4134 dired.c's scmp function, had undefined behavior.
4135 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4136 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4137 * buffer.h: ... to here, because these macros use current_buffer,
4138 and the new implementation with inline functions needs to have
4139 current_buffer in scope now, rather than later when the macros
4140 are used.
4141 (downcase, upcase1): New static inline functions.
4142 (DOWNCASE, UPCASE1): Reimplement using these functions.
4143 This avoids undefined behavior in expressions like
4144 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4145 from race conditions in accessing the global variables
4146 case_temp1 and case_temp2.
4147 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4148 * lisp.h (case_temp1, case_temp2): Remove their decls.
4149 * character.h (ASCII_CHAR_P): Move from here ...
4150 * lisp.h: ... to here, so that the inline functions mentioned
4151 above can use them.
4152
4a6bea26
PE
4153 * dired.c (directory_files_internal_unwind): Now static.
4154
f14b7e14
PE
4155 * fileio.c (file_name_as_directory, directory_file_name):
4156 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4157 Now static.
2893f146
PE
4158 (file_name_as_directory): Use const pointers when appropriate.
4159 (Fexpand_file_name): Likewise. In particular, newdir might
4160 point at constant storage, so make it a const pointer.
fd4ead52 4161 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4162 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4163 signedness issues.
f839df0c
PE
4164 (Fset_file_times, Finsert_file_contents, auto_save_error):
4165 Rename locals to avoid shadowing.
f14b7e14 4166
5716756e 4167 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4168 (Ftry_completion, Fall_completions): Rename or remove locals
4169 to avoid shadowing.
5716756e 4170
b4c3046a
PE
4171 * marker.c (bytepos_to_charpos): Remove; unused.
4172
b45db522
PE
4173 * lisp.h (verify_bytepos, count_markers): New decls,
4174 so that gcc does not warn that these functions aren't declared.
4175
85876d07
PE
4176 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4177 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4178 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4179 (copy_text): Remove unused local var.
85876d07 4180
03d78a21 4181 * filelock.c (within_one_second): Now static.
b3dd38ab 4182 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4183
5df8f01b
PE
4184 * buffer.c (fix_overlays_before): Mark locals as initialized.
4185 (fix_start_end_in_overlays): Likewise. This function should be
4186 simplified by using pointers-to-pointers, but that's a different
4187 matter.
b1d876f1 4188 (switch_to_buffer_1): Now static.
8f54f30a
PE
4189 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4190 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4191
a70072c9 4192 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4193 Fix pointer signedness issue.
edced198
PE
4194 (sys_subshell): Mark local as volatile if checking for lint,
4195 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4196 (MAXPATHLEN): Define only if needed.
a70072c9 4197
a0977c44
PE
4198 * process.c (serial_open, serial_configure): Move decls from here ...
4199 * systty.h: ... to here, so that they can be checked.
4200
a884fdcc
PE
4201 * fns.c (get_random, seed_random): Move extern decls from here ...
4202 * lisp.h: ... to here, so that they can be checked.
4203
604efe86 4204 * sysdep.c (reset_io): Now static.
b8950c94 4205 (wait_for_termination_signal): Remove; unused.
604efe86 4206
38fc62d9
PE
4207 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4208 (copy_keymap_item, append_key, push_text_char_description):
4209 Now static.
1004a21a 4210 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4211 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4212 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4213 (describe_map_tree):
4214 Rename locals to avoid shadowing.
38fc62d9 4215
2f2650da
PE
4216 * keyboard.c: Declare functions static if they are not used elsewhere.
4217 (echo_char, echo_dash, cmd_error, top_level_2):
4218 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4219 (read_char, kbd_buffer_get_event, make_lispy_position):
4220 (make_lispy_event, make_lispy_movement, apply_modifiers):
4221 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4222 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4223 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4224 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4225 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4226
a053e86c 4227 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4228 (mark_kboards): Move decl here ...
4229 * alloc.c (mark_kboards): ... from here.
a053e86c 4230
4752793e
PE
4231 * lisp.h (force_auto_save_soon): New decl.
4232
74f10ca7 4233 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4234 (DEFINE_DUMMY_FUNCTION): New macro.
4235 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4236 Use it.
c03cd23f
PE
4237 (main): Add casts to avoid warnings
4238 if GCC considers string literals to be constants.
74f10ca7 4239
022e70d4
PE
4240 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4241
59d6fe83
PE
4242 * dbusbind.c: Pointer signedness fixes.
4243 (xd_signature, xd_append_arg, xd_initialize):
4244 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4245 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4246 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4247 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4248
78320123
PE
4249 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4250 if GCC considers string literals to be constants.
49cebcca 4251 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4252
35ac2a97
SM
42532011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4254
fb103ca9
SM
4255 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4256 (print_preprocess, print_object): New macro to fix last change.
4257
35ac2a97
SM
4258 * print.c (print_preprocess): Don't forget font objects.
4259
62973b41
JB
42602011-03-16 Juanma Barranquero <lekktu@gmail.com>
4261
4262 * emacs.c (USAGE3): Doc fixes.
4263
0e48bb22
AS
42642011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4265
4266 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4267 structure.
4268
7684e57b
JB
42692011-03-14 Juanma Barranquero <lekktu@gmail.com>
4270
4271 * lisp.h (VWindow_system, Qfile_name_history):
4272 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4273 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4274 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4275
4276 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4277 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4278
4279 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4280 * w32console.c (detect_input_pending, read_input_pending)
4281 (encode_terminal_code):
4282 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4283 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4284 (w32_system_caret_y, Qfile_name_history):
4285 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4286 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4287 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4288 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4289 * w32proc.c (Qlocal, report_file_error):
4290 * w32term.c (Vwindow_system, updating_frame):
4291 * w32uniscribe.c (initialized, uniscribe_font_driver):
4292 Remove unneeded extern declarations.
4293
2aa46d6c
CY
42942011-03-14 Chong Yidong <cyd@stupidchicken.com>
4295
c96bbc66 4296 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4297
cffc6f3b
CY
42982011-03-13 Chong Yidong <cyd@stupidchicken.com>
4299
4300 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4301 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4302 These macros can no longer be used for assignment.
4303
44f230aa
SM
4304 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4305 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4306 (record_buffer_markers, fetch_buffer_markers): New functions for
4307 recording and fetching special buffer markers.
4308 (set_buffer_internal_1, set_buffer_temp): Use them.
4309
4310 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4311
4312 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4313
4314 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4315 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4316
4317 * xdisp.c (hscroll_window_tree):
4318 (reconsider_clip_changes): Use PT instead of BUF_PT.
4319
d251f04b
EZ
43202011-03-13 Eli Zaretskii <eliz@gnu.org>
4321
4322 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4323 $(EMACS_ROOT)/lib/intprops.h.
4324
f0c77cd1
PE
43252011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4326
3eca4629
PE
4327 Fix more problems found by GCC 4.5.2's static checks.
4328
7c86ee98
PE
4329 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4330 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4331 (xg_free_frame_widgets): Make it clear that a local variable is
4332 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4333 (gdk_window_get_screen): Make it clear that this macro is needed
4334 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4335 (int_gtk_range_get_value): New function, which avoids a diagnostic
4336 from gcc -Wbad-function-cast.
4337 (xg_set_toolkit_scroll_bar_thumb): Use it.
4338 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4339 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4340 (get_utf8_string, xg_get_file_with_chooser):
4341 Rename locals to avoid shadowing.
4342 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4343
41729b81
PE
4344 * xgselect.c (xg_select): Remove unused var.
4345
f0c77cd1
PE
4346 * image.c (four_corners_best): Mark locals as initialized.
4347 (gif_load): Initialize transparent_p to zero (Bug#8238).
4348 Mark another local as initialized.
ec6cf4c6 4349 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4350
ce0ad53d 4351 * image.c (clear_image_cache): Now static.
d5d5a617 4352 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4353 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4354 (x_edge_detection): Remove unnecessary cast that
4355 gcc -Wbad-function-cast diagnoses.
2037898d 4356 (gif_load): Fix pointer signedness.
6ae141d6
PE
4357 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4358 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4359
33383987 43602011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4361
d32df629
PE
4362 Improve quality of tests for time stamp overflow.
4363 For example, without this patch (encode-time 0 0 0 1 1
4364 1152921504606846976) returns the obviously-bogus value (-948597
4365 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4366 reports time overflow. See
4367 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4368 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4369 * editfns.c: Include limits.h and intprops.h.
4370 (TIME_T_MIN, TIME_T_MAX): New macros.
4371 (time_overflow): Move earlier, to before first use.
4372 (hi_time, lo_time): New functions, for an accurate test for
4373 out-of-range times.
4374 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4375 (Fget_internal_run_time): Don't assume time_t fits in int.
4376 (make_time): Use list2 instead of Fcons twice.
4377 (Fdecode_time): More accurate test for out-of-range times.
4378 (check_tm_member): New function.
4379 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4380 (lisp_time_argument): Don't rely on undefined left-shift and
4381 right-shift behavior when checking for time stamp overflow.
8be6f318 4382
fe31d94c
PE
4383 * editfns.c (time_overflow): New function, refactoring common code.
4384 (Fformat_time_string, Fdecode_time, Fencode_time):
4385 (Fcurrent_time_string): Use it.
4386
8be6f318
PE
4387 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4388 * dired.c (make_time): Move to ...
4389 * editfns.c (make_time): ... here.
4390 * systime.h: Note the move.
4391
09d9db2c 43922011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4393
126bc0dc
YM
4394 * fringe.c (update_window_fringes): Remove unused variables.
4395
c47cbdfd
YM
4396 * unexmacosx.c (copy_data_segment): Also copy __got section.
4397 (Bug#8223)
4398
7ac80be9
EZ
43992011-03-12 Eli Zaretskii <eliz@gnu.org>
4400
c96bbc66 4401 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4402 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4403 Constify `char *' arguments and their references according to
4404 prototypes in tparam.h.
4405
ecb0f94d 4406 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4407
7ac80be9
EZ
4408 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4409 Adapt all references accordingly.
4410
4411 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4412
ef1fd07e
TT
44132011-03-11 Tom Tromey <tromey@redhat.com>
4414
4415 * buffer.c (syms_of_buffer): Remove obsolete comment.
4416
7ef4b50c
EZ
44172011-03-11 Eli Zaretskii <eliz@gnu.org>
4418
4419 * termhooks.h (encode_terminal_code): Declare prototype.
4420
4421 * msdos.c (encode_terminal_code): Don't declare prototype.
4422
4423 * term.c (encode_terminal_code): Now external again, used by
4424 w32console.c and msdos.c.
4425
44f230aa
SM
4426 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4427 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4428
4b1ec863 44292011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4430
1714f52b 4431 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4432
4b1ec863
PE
4433 * fringe.c (update_window_fringes): Mark locals as initialized
4434 (Bug#8227).
4435 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4436
524c7aa6
PE
4437 * alloc.c (mark_fringe_data): Move decl from here ...
4438 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4439 to check its interface.
4440 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4441
a5c0af81 4442 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4443 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4444 (fontset_font): Mark local as initialized.
a9a06e0b 4445 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4446
b4716021
PE
4447 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4448
811e9bac 4449 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4450 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4451 (x_own_selection, Fx_disown_selection_internal): Rename locals
4452 to avoid shadowing.
4453 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4454
7e3ab302
PE
4455 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4456 so that the caller can use some name other than gcpro1.
4457 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4458 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4459 (Fx_backspace_delete_keys_p):
4460 Use them to avoid shadowing, and rename vars to avoid shadowing.
4461 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4462 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4463 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4464 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4465 Remove unused locals.
7e3ab302
PE
4466 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4467 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4468 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4469 macros.
f78faa98 4470
e2b13473
PE
4471 * xterm.h (x_mouse_leave): New decl.
4472
77f23912
PE
4473 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4474 Remove unused functions.
cdf4ba58
PE
4475 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4476 (x_calc_absolute_position): Now static.
7411c686 4477 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4478 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4479 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4480 unless they are used.
38d0b34a
PE
4481 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4482 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4483 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4484 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4485 (x_error_catcher, x_connection_closed, x_error_handler):
4486 (x_error_quitter, xembed_send_message, x_iconify_frame):
4487 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4488 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4489 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4490
44f230aa
SM
4491 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4492 Rename or move locals to avoid shadowing.
6b463e58 4493 (tty_defined_color, merge_face_heights): Now static.
5967d051 4494 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4495 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4496 does not deduce is never used uninitialized.
73719eba
PE
4497 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4498 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4499
426994c3 4500 * terminal.c (store_terminal_param): Now static.
5489860b 4501
032f1620 4502 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4503 (set_frame_menubar): Remove unused local.
d4323972 4504 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4505 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4506 since they might point to immutable storage.
281585b0
PE
4507 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4508 since it's unused otherwise.
032f1620 4509
367c19e5 4510 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4511 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4512 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4513 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4514 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4515 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4516 does not deduce are never used uninitialized.
70739cbe 4517
07b48fa9
PE
4518 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4519
8868a238 4520 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4521 * window.c (window_loop, size_window):
4522 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4523
7e5cf297 4524 * window.c (display_buffer): Now static.
d6550a9f
PE
4525 (size_window): Mark variables that gcc -Wuninitialized
4526 does not deduce are never used uninitialized.
a586633d
PE
4527 * window.h (check_all_windows): New decl, to forestall
4528 gcc -Wmissing-prototypes diagnostic.
5b555da1 4529 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4530
f6095868
PE
4531 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4532 shadowing.
4533 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4534 Include <limits.h>.
4535 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4536 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4537 (load_charset_map): Mark variables that gcc -Wuninitialized
4538 does not deduce are never used uninitialized.
53df7c11 4539 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4540
f38b440c
PE
4541 * coding.c (coding_set_source, coding_set_destination):
4542 Use "else { /* comment */ }" rather than "else /* comment */;"
4543 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4544 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4545 a block, when the outer 'i' will do.
4546 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4547 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4548 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4549 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4550 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4551 Rename locals to avoid shadowing.
4552 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4553 * coding.c (emacs_mule_char, encode_invocation_designation):
4554 Now static, since they're not used elsewhere.
413bb2db 4555 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4556 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4557 (decode_coding_emacs_mule): Mark variables that gcc
4558 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4559 (detect_coding_iso_2022): Initialize a local variable that might
4560 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4561 this initialization is needed. (Bug#8211)
5f58e762
PE
4562 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4563 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4564 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4565 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4566 Remove unused macros.
f38b440c 4567
232b38b9 4568 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4569 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4570 * character.c (string_count_byte8): Likewise.
232b38b9 4571
fb90da1b
PE
4572 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4573 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4574
fb93dbc2
PE
4575 * chartab.c (copy_sub_char_table): Now static, since it's not used
4576 elsewhere.
5c156ace
PE
4577 (sub_char_table_ref_and_range, char_table_ref_and_range):
4578 Rename locals to avoid shadowing.
bbcd0949 4579 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4580
7d3b3862 4581 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4582 (BIDI_BOB): Remove unused macro.
7d3b3862 4583
6be7d3da
PE
4584 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4585 deduce are never used uninitialized.
c2ed9c8b 4586 * term.c (encode_terminal_code): Likewise.
6be7d3da 4587
75f8807f 4588 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4589
50938595
PE
4590 * tparam.h: New file.
4591 * term.c, tparam.h: Include it.
4592 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4593 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4594 Move these decls to tparam.h, and make them agree with what
4595 is actually in tparam.c. The previous trick of using incompatible
4596 decls in different modules does not conform to the C standard.
4597 All callers of tparam changed to use tparam's actual API.
4598 * tparam.c (tparam1, tparam, tgoto):
4599 Use const pointers where appropriate.
4600
fbceeba2
PE
4601 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4602 * cm.h (struct cm): Likewise.
4603 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4604 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4605 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4606 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4607 (turn_on_face, init_tty): Likewise.
4608 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4609
7f3f1250
PE
4610 * term.c (term_mouse_position): Rename local to avoid shadowing.
4611
e6ca6543
PE
4612 * alloc.c (mark_ttys): Move decl from here ...
4613 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4614
c40f8d15
AS
46152011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4616
4617 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4618
cfe0661d
JB
46192011-03-09 Juanma Barranquero <lekktu@gmail.com>
4620
4621 * search.c (compile_pattern_1): Remove argument regp, unused since
4622 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4623 (compile_pattern): Don't pass it.
4624
0afb4571
J
46252011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4626
4627 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4628 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4629 for ! HAVE_GTK3.
4630 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4631
4632 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4633
4634 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4635 gdk_window_get_screen, gdk_window_get_geometry,
4636 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4637 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4638 (xg_get_pixbuf_from_pixmap): New function.
4639 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4640 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4641 Call xg_get_pixbuf_from_pixmap instead of
4642 gdk_pixbuf_get_from_drawable.
4643 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4644 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4645 (xg_check_special_colors): Use GtkStyleContext and its functions
4646 for HAVE_GTK3.
4647 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4648 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4649 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4650 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4651 Call gtk_widget_get_preferred_size.
0afb4571
J
4652 (xg_frame_resized): gdk_window_get_geometry only takes 5
4653 parameters.
44f230aa
SM
4654 (xg_win_to_widget, xg_event_is_for_menubar):
4655 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4656 (xg_set_widget_bg): New function.
4657 (delete_cb): New function.
895009e1 4658 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4659 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4660 (xg_set_background_color): Call xg_set_widget_bg.
4661 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4662 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4663 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4664 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4665 if ! HAVE_GTK3.
4666 (update_frame_tool_bar): Call gtk_widget_hide.
4667 (xg_initialize): Use GDK_KEY_g.
4668
4669 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4670 if ! HAVE_GTK3
4671 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4672
4673 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4674 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4675 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4676
1c2cc4ef
JB
46772011-03-08 Juanma Barranquero <lekktu@gmail.com>
4678
4679 * w32xfns.c (select_palette): Check success of RealizePalette against
4680 GDI_ERROR, not zero.
4681
33383987 4682See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4683
4684;; Local Variables:
4685;; coding: utf-8
aac0c6e3
MR
4686;; End:
4687
33383987 4688 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4689
4690 This file is part of GNU Emacs.
4691
4692 GNU Emacs is free software: you can redistribute it and/or modify
4693 it under the terms of the GNU General Public License as published by
4694 the Free Software Foundation, either version 3 of the License, or
4695 (at your option) any later version.
4696
4697 GNU Emacs is distributed in the hope that it will be useful,
4698 but WITHOUT ANY WARRANTY; without even the implied warranty of
4699 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4700 GNU General Public License for more details.
4701
4702 You should have received a copy of the GNU General Public License
4703 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.