port new setting code to Sun C 5.8 2005/10/13
[bpt/emacs.git] / src / ChangeLog
CommitLineData
e757f1c6
PE
12012-08-18 Paul Eggert <eggert@cs.ucla.edu>
2
3 port new setting code to Sun C 5.8 2005/10/13
4 * chartab.c, lisp.h (char_table_set, char_table_set_range):
5 Return void, not Lisp_Object. Otherwise, the compiler
6 complains about (A?B:C) where B is void and C is Lisp_Object
7 when compiling CHAR_TABLE_SET, due to the recent change to
8 the API of sub_char_table_set_contents.
9
a999ce26
CY
102012-08-18 Chong Yidong <cyd@gnu.org>
11
12 * xdisp.c (handle_invisible_prop): Obey TEXT_PROP_MEANS_INVISIBLE
13 for the string case (Bug#3874).
14
3f22b86f
PE
152012-08-18 Paul Eggert <eggert@cs.ucla.edu>
16
39eb03f1
PE
17 * buffer.h (BSET): Remove (Bug#12215).
18 Replace all uses with calls to new setter functions.
19 (bset_bidi_paragraph_direction, bset_case_canon_table)
20 (bset_case_eqv_table, bset_directory, bset_display_count)
21 (bset_display_time, bset_downcase_table)
22 (bset_enable_multibyte_characters, bset_filename, bset_keymap)
23 (bset_last_selected_window, bset_local_var_alist)
24 (bset_mark_active, bset_point_before_scroll, bset_read_only)
25 (bset_truncate_lines, bset_undo_list, bset_upcase_table)
26 (bset_width_table):
27 * buffer.c (bset_abbrev_mode, bset_abbrev_table)
28 (bset_auto_fill_function, bset_auto_save_file_format)
29 (bset_auto_save_file_name, bset_backed_up, bset_begv_marker)
30 (bset_bidi_display_reordering, bset_buffer_file_coding_system)
31 (bset_cache_long_line_scans, bset_case_fold_search)
32 (bset_ctl_arrow, bset_cursor_in_non_selected_windows)
33 (bset_cursor_type, bset_display_table, bset_extra_line_spacing)
34 (bset_file_format, bset_file_truename, bset_fringe_cursor_alist)
35 (bset_fringe_indicator_alist, bset_fringes_outside_margins)
36 (bset_header_line_format, bset_indicate_buffer_boundaries)
37 (bset_indicate_empty_lines, bset_invisibility_spec)
38 (bset_left_fringe_width, bset_major_mode, bset_mark)
39 (bset_minor_modes, bset_mode_line_format, bset_mode_name)
40 (bset_name, bset_overwrite_mode, bset_pt_marker)
41 (bset_right_fringe_width, bset_save_length)
42 (bset_scroll_bar_width, bset_scroll_down_aggressively)
43 (bset_scroll_up_aggressively, bset_selective_display)
44 (bset_selective_display_ellipses, bset_vertical_scroll_bar_type)
45 (bset_word_wrap, bset_zv_marker):
46 * category.c (bset_category_table):
47 * syntax.c (bset_syntax_table):
48 New setter functions.
49
6a09a33b
PE
50 * process.h (PSET): Remove (Bug#12215).
51 Replace all uses with calls to new setter functions.
52 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
53 (PROCESS_INLINE): New macro.
54 (pset_childp): New setter function.
55 (pset_gnutls_cred_type) [HAVE_GNUTLS]: New setter function.
56 * process.c (PROCESS_INLINE):
57 Define to EXTERN_INLINE, so that the corresponding functions
58 are compiled into code.
59 (pset_buffer, pset_command, pset_decode_coding_system)
60 (pset_decoding_buf, pset_encode_coding_system)
61 (pset_encoding_buf, pset_filter, pset_log, pset_mark, pset_name)
62 (pset_plist, pset_sentinel, pset_status, pset_tty_name)
63 (pset_type, pset_write_queue): New setter functions.
64
e8c17b81
PE
65 * window.h (WSET): Remove (Bug#12215).
66 Replace all uses with calls to new setter functions.
67 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
68 (WINDOW_INLINE): New macro.
69 (wset_buffer, wset_frame, wset_left_col, wset_next, wset_prev)
70 (wset_redisplay_end_trigger, wset_top_line, wset_total_cols)
71 (wset_total_lines, wset_vertical_scroll_bar)
72 (wset_window_end_pos, wset_window_end_valid)
73 (wset_window_end_vpos): New setter functions.
74 * window.c (WINDOW_INLINE):
75 Define to EXTERN_INLINE, so that the corresponding functions
76 are compiled into code.
77 (wset_combination_limit, wset_dedicated, wset_display_table)
78 (wset_hchild, wset_left_fringe_width, wset_left_margin_cols)
79 (wset_new_normal, wset_new_total, wset_next_buffers)
80 (wset_normal_cols, wset_normal_lines, wset_parent, wset_pointm)
81 (wset_prev_buffers, wset_right_fringe_width)
82 (wset_right_margin_cols, wset_scroll_bar_width, wset_start)
83 (wset_temslot, wset_vchild, wset_vertical_scroll_bar_type)
84 (wset_window_parameters):
85 * xdisp.c (wset_base_line_number, wset_base_line_pos)
86 (wset_column_number_displayed, wset_region_showing):
87 New setter functions.
88
3f22b86f
PE
89 * termhooks.h (TSET): Remove (Bug#12215).
90 Replace all uses with calls to new setter functions.
91 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
92 (TERMHOOKS_INLINE): New macro.
93 (tset_charset_list, tset_selection_alist): New setter functions.
94 * terminal.c (TERMHOOKS_INLINE):
95 Define to EXTERN_INLINE, so that the corresponding functions
96 are compiled into code.
97 (tset_param_alist): New setter function.
98
742af32f
PE
992012-08-17 Paul Eggert <eggert@cs.ucla.edu>
100
15dbb4d6
PE
101 * keyboard.h (KSET): Remove (Bug#12215).
102 Replace all uses with calls to new setter functions.
103 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
104 (KEYBOARD_INLINE): New macro.
105 (kset_default_minibuffer_frame, kset_defining_kbd_macro)
106 (kset_input_decode_map, kset_last_command, kset_last_kbd_macro)
107 (kset_prefix_arg, kset_system_key_alist, kset_window_system):
108 New setter functions.
109 * keyboard.c (KEYBOARD_INLINE):
110 Define to EXTERN_INLINE, so that the corresponding functions
111 are compiled into code.
112 (kset_echo_string, kset_kbd_queue)
113 (kset_keyboard_translate_table, kset_last_prefix_arg)
114 (kset_last_repeatable_command, kset_local_function_key_map)
115 (kset_overriding_terminal_local_map, kset_real_last_command)
116 (kset_system_key_syms): New setter functions.
117
f00af5b1
PE
118 * frame.h (FSET): Remove (Bug#12215).
119 Replace all uses with calls to new setter functions.
120 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
121 (FRAME_INLINE): New macro.
122 (fset_buffer_list, fset_buried_buffer_list, fset_condemned_scroll_bars)
123 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
124 (fset_face_alist, fset_focus_frame, fset_icon_name, fset_menu_bar_items)
125 (fset_menu_bar_vector, fset_menu_bar_window, fset_name)
126 (fset_param_alist, fset_root_window, fset_scroll_bars)
127 (fset_selected_window, fset_title, fset_tool_bar_items)
128 (fset_tool_bar_position, fset_tool_bar_window): New functions.
129 * frame.c (FRAME_INLINE):
130 Define to EXTERN_INLINE, so that the corresponding functions
131 are compiled into code.
132 (fset_buffer_predicate, fset_minibuffer_window): New setter functions.
133
0c94c8d6
PE
134 A few more naming-convention fixes for getters and setters.
135 * buffer.c (set_buffer_overlays_before): Move here from buffer.h,
136 and rename from buffer_overlays_set_before.
137 (set_buffer_overlays_after): Move here from buffer.h, and rename
138 from buffer_overlays_set_after.
139 * buffer.h (buffer_intervals): Rename from buffer_get_intervals.
140 All uses changed.
141 (set_buffer_intervals): Rename from buffer_set_intervals.
142 * intervals.c (set_interval_object): Move here from intervals.h,
143 and rename from interval_set_object.
144 (set_interval_left): Move here from intervals.h, and rename from
145 interval_set_left.
146 (set_interval_right): Move here from intervals.h, and rename from
147 interval_set_right.
148 (copy_interval_parent): Move here from intervals.h, and rename from
149 interval_copy_parent.
150 * intervals.h (set_interval_parent): Rename from interval_set_parent.
151 (set_interval_plist): Rename from interval_set_plist.
152 Return void, not Lisp_Object, since no caller uses the result.
153 * lisp.h (string_intervals): Rename from string_get_intervals.
154 (set_string_intervals): Rename from string_set_intervals.
155
34dabdb7
PE
156 * lisp.h (set_char_table_extras): Rename from char_table_set_extras.
157 (set_char_table_contents): Rename from char_table_set_contents.
0b390a9d 158 (set_sub_char_table_contents): Rename from sub_char_table_set_contents.
34dabdb7
PE
159 All uses changed. See the end of
160 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00549.html>.
161
742af32f
PE
162 * lisp.h (CSET): Remove (Bug#12215).
163 (set_char_table_ascii, set_char_table_defalt, set_char_table_parent)
164 (set_char_table_purpose): New functions,
165 replacing CSET. All uses changed. For example, replace
166 "CSET (XCHAR_TABLE (char_table), parent, parent);" with
c24eb18a 167 "set_char_table_parent (char_table, parent);".
742af32f
PE
168 The old version was confusing because it used the same name
169 'parent' for two different things.
170
a04e2c62
DA
1712012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
172
173 Functions to get and set Lisp_Object fields of buffer-local variables.
174 * lisp.h (blv_found, set_blv_found, blv_value, set_blv_value)
175 (set_blv_where, set_blv_defcell, set_blv_valcell): New functions.
176 (BLV_FOUND, SET_BLV_FOUND, BLV_VALUE, SET_BLV_VALUE): Remove.
177 * data.c, eval.c, frame.c: Adjust users.
178
383dcbf9
CY
1792012-08-17 Chong Yidong <cyd@gnu.org>
180
181 * xfaces.c (merge_face_vectors): If the target font specfies a
182 font spec, make the font's attributes take precedence over
183 directly-specified attributes.
184 (merge_face_ref): Recognize :font.
185
44386687
DA
1862012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
187
188 Do not use memcpy for copying intervals.
189 * intervals.c (reproduce_interval): New function.
190 (reproduce_tree, reproduce_tree_obj): Use it.
191 (reproduce_tree_obj): Remove prototype.
192
927c7216
PE
1932012-08-17 Paul Eggert <eggert@cs.ucla.edu>
194
195 * lisp.h (duration_to_sec_usec): Remove unused decl.
196
93044f7b
AA
1972012-08-17 Alp Aker <alp.tekin.aker@gmail.com>
198
199 * nsfont.m (ns_ascii_average_width): Send initWithFormat selector
200 to an allocated instance of NSString, not to the class itself.
201
9851e4a5
JB
2022012-08-17 Juanma Barranquero <lekktu@gmail.com>
203
204 * makefile.w32-in (C_CTYPE_H): New macro.
205 (LISP_H, $(BLD)/ccl.$(O), $(BLD)/doc.$(O), $(BLD)/w32console.$(O)):
206 ($(BLD)/fontset.$(O), $(BLD)/frame.$(O), $(BLD)/composite.$(O)):
207 ($(BLD)/sysdep.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
208
620f13b0
PE
2092012-08-16 Paul Eggert <eggert@cs.ucla.edu>
210
211 Use ASCII tests for character types.
212 * category.c, dispnew.c, doprnt.c, editfns.c, syntax.c, term.c:
213 * xfns.c, xterm.c:
214 Don't include <ctype.h>; was not needed.
215 * charset.c, doc.c, fileio.c, font.c, frame.c, gtkutil.c, image.c:
216 * sysdep.c, xfaces.c:
217 Include <c-ctype.h> instead of <ctype.h>.
218 * nsterm.m: Include <c-ctype.h>.
219 * charset.c (read_hex):
220 * doc.c (Fsnarf_documentation):
221 * fileio.c (IS_DRIVE) [WINDOWSNT]:
222 (DRIVE_LETTER) [DOS_NT]:
223 (Ffile_name_directory, Fexpand_file_name)
224 (Fsubstitute_in_file_name):
225 * font.c (font_parse_xlfd, font_parse_fcname):
226 * frame.c (x_set_font_backend):
227 * gtkutil.c (xg_get_font):
228 * image.c (xbm_scan, xpm_scan, pbm_scan_number):
229 * nsimage.m (hexchar):
230 * nsterm.m (ns_xlfd_to_fontname):
231 * sysdep.c (system_process_attributes):
232 * xfaces.c (hash_string_case_insensitive):
233 Use C-locale tests instead of locale-specific tests for character
234 types, since we want the ASCII interpretation here, not the
235 interpretation suitable for whatever happens to be the current locale.
236
52162052
MR
2372012-08-16 Martin Rudalics <rudalics@gmx.at>
238
239 Consistently check windows for validity/liveness
240 (Bug#11984, Bug#12025, Bug#12026).
241 * lisp.h (CHECK_VALID_WINDOW): New macro.
242 * window.c (decode_window): Rename to decode_live_window.
243 (decode_valid_window, Fwindow_valid_p): New functions.
244 (Fwindow_frame, Fframe_root_window, Fwindow_minibuffer_p)
245 (Fframe_first_window, Fframe_selected_window, Fwindow_parent)
246 (Fwindow_top_child, Fwindow_left_child, Fwindow_next_sibling)
247 (Fwindow_prev_sibling, Fwindow_combination_limit)
248 (Fset_window_combination_limit, Fwindow_use_time)
249 (Fwindow_total_height, Fwindow_total_width, Fwindow_new_total)
250 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_left_column)
251 (Fwindow_top_line, Fwindow_body_height, Fwindow_body_width)
252 (Fwindow_hscroll, Fset_window_hscroll)
253 (Fwindow_redisplay_end_trigger)
254 (Fset_window_redisplay_end_trigger, Fwindow_edges)
255 (Fwindow_pixel_edges, Fwindow_absolute_pixel_edges)
256 (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
257 (Fcoordinates_in_window_p, Fwindow_point, Fwindow_start)
258 (Fwindow_end, Fset_window_point, Fset_window_start)
259 (Fpos_visible_in_window_p, Fwindow_line_height)
260 (Fwindow_dedicated_p, Fset_window_dedicated_p)
261 (Fwindow_prev_buffers, Fset_window_prev_buffers)
262 (Fwindow_next_buffers, Fwindow_parameters, Fwindow_parameter)
263 (Fset_window_parameter, Fwindow_display_table)
264 (Fset_window_display_table, Fdelete_other_windows_internal)
265 (Fset_window_buffer, Fset_window_new_total)
266 (Fset_window_new_normal, Fdelete_window_internal)
267 (Fwindow_text_height, Fset_window_margins, Fwindow_margins)
268 (Fset_window_fringes, Fwindow_fringes, Fset_window_scroll_bars)
269 (Fwindow_scroll_bars): Check whether argument window is a valid or
270 live window. Update doc-strings.
271 (syms_of_window): New symbol Qwindow_valid_p.
272 * keyboard.c (Fposn_at_x_y): Check whether argument
273 frame_or_window denotes a valid window.
274
2751c80f
DA
2752012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
276
277 Fix previous char table change.
278 * lisp.h (CHAR_TABLE_SET): Use sub_char_table_set_contents.
279 * chartab.c (optimize_sub_char_table): Likewise.
280
032a42c8
CY
2812012-08-16 Chong Yidong <cyd@gnu.org>
282
a2d19368
CY
283 * gtkutil.c (xg_get_font): Demand an Xft font (Bug#3228).
284
032a42c8
CY
285 * xfont.c (xfont_open):
286 * xftfont.c (xftfont_open): Set the font's max_width field.
287
288 * nsfont.m (nsfont_open): Similar to the Xft backend, set
289 min_width to space_width and average_width to the average over
290 printable ASCII characters.
291 (ns_char_width): Code cleanup.
292 (ns_ascii_average_width): New utility function.
293
294 * font.h (struct font): Update comments.
295
a098c930
DA
2962012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
297
032a42c8 298 Simple interface to set Lisp_Object fields of character tables.
a098c930
DA
299 * lisp.h (CSET): New macro.
300 (char_table_set_extras, char_table_set_contents)
301 (sub_char_table_set_contents): New function.
302 * casetab.c, category.c, chartab.c, fns.c, fontset.c, search.c:
303 * syntax.c: Adjust users.
304
8be3a09c
SM
3052012-08-16 Stefan Monnier <monnier@iro.umontreal.ca>
306
307 * eval.c (eval_sub): Bind lexical-binding.
308 * lread.c (Qlexical_binding): Make non-static.
309
ac4845a6
JD
3102012-08-15 Jan Djärv <jan.h.d@swipnet.se>
311
ddee6515
JD
312 * nsmenu.m (popupSession): Remove.
313 (pop_down_menu): Remove endModalSession.
314 (timeout_handler:): New method.
315 (runDialogAt:): Get next timeout. Start a NSTimer with that timeout.
316 Call runModalForWindow. Check timer_fired when it returns.
317 If not set, cancel timer and break out of loop.
318 Otherwise loop again, with a new timeout.
319
320 * nsterm.m: Include fcntl.h if present.
321 (fd_entry, t_readfds, inNsSelect): Remove.
322 (select_writefds, select_valid, select_timeout, selfds)
323 (select_mutex, apploopnr): Add.
324 (EV_TRAILER): Call kbd_buffer_store_event_hold only if q_event_ptr.
325 Otherwise call kbd_buffer_store_event.
326 (ns_send_appdefined): Remove release of fd_entry.
327 (ns_read_socket): Always send appdefined. Remove inNsSelect check.
328 Increment and decrement apploopnr.
329 (ns_select): If no file descriptors, just do a NSTimer.
330 Otherwise copy read/write masks and start select thread (fd_handler).
331 Start main loop and wait for application defined event.
332 Inform select thread to stop selecting after main loop is exited.
333 (ns_term_init): Create selfds pipe and set non-blocking.
334 Initialize select_mutex. Start the select thread (fd_handler).
335 (fd_handler:): Loop forever, wait for info from the main thread
336 to either start or stop selecting. When select returns, send
337 and appdefined event.
338 (sendScrollEventAtLoc:fromEvent:): Check if q_event_ptr is set.
339 If not call kbd_buffer_store_event.
340
341 * nsterm.h (EmacsApp): fd_handler takes id argument.
342 (EmacsDialogPanel): Add timer_fired and timeout_handler.
343
ac4845a6
JD
344 * gtkutil.c (xg_mark_data): Use FRAME_X_P.
345
eb424fe3
EZ
3462012-08-15 Eli Zaretskii <eliz@gnu.org>
347
348 * region-cache.c (move_cache_gap): Update gap_len using the actual
349 growth of the boundaries array. Do not change cache_len.
350 (Bug#12196)
351
4e6a86c6
DA
3522012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
353
354 Generalize and cleanup font subsystem checks.
355 * font.h (FONT_DEBUG, font_assert): Remove.
8be3a09c
SM
356 * font.c, fontset.c, w32font.c, xfont.c, xftfont.c:
357 Change font_assert to eassert. Use eassert where appropriate.
4e6a86c6 358
5bf192ca
DA
3592012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
360
361 * gtkutil.c (xg_get_font): Use pango_units_to_double.
362
f2045622
CY
3632012-08-15 Chong Yidong <cyd@gnu.org>
364
8be3a09c
SM
365 * gtkutil.c (xg_get_font): Rename from xg_get_font_name.
366 When using the new font chooser, use gtk_font_chooser_get_font_desc to
367 extract the font descriptor instead of just the font name.
368 In that case, return a font spec instead of a string.
f2045622
CY
369 (x_last_font_name): Move to this file from xfns.c.
370
371 * xfns.c (Fx_select_font): The return value can also be a font
372 spec. Move x_last_font_name management to gtkutil.c.
373
374 * xfaces.c: Make font weight and style symbols non-static.
375
7f6feb56
SM
3762012-08-15 Stefan Monnier <monnier@iro.umontreal.ca>
377
378 * minibuf.c (read_minibuf): Ignore caller's inhibit-read-only
379 (bug#12117).
380
fecbd8ff
SM
3812012-08-14 Stefan Monnier <monnier@iro.umontreal.ca>
382
383 * alloc.c (Fgarbage_collect): Use plural form consistently.
384
9b8d5165
EZ
3852012-08-14 Eli Zaretskii <eliz@gnu.org>
386
387 * keyboard.c (command_loop_1): Reset ignore_mouse_drag_p flag each
388 iteration through the command loop. Fixes a problem whereby mouse
389 movements are ignored until the first mouse click.
390
f5d9e83a
PE
3912012-08-14 Paul Eggert <eggert@cs.ucla.edu>
392
393 Use bool, not int, for Lisp booleans.
394 This is more natural, and on my platform (GCC 4.7.1 x86-64) it
395 makes Emacs a bit smaller and presumably a bit faster.
396 * lisp.h: Include <stdbool.h>.
397 (struct Lisp_Boolfwd, defvar_bool):
398 * lread.c (defvar_bool): Use bool, not int, for Lisp booleans.
399 * regex.c [!emacs]: Include <stdbool.h>.
400 (false, true): Remove; <stdbool.h> does this for us now.
401
55802e4a
CY
4022012-08-14 Chong Yidong <cyd@gnu.org>
403
4abcdac8
CY
404 * character.c (Fcharacterp): Doc fix (Bug#12076).
405
406 * data.c (Findirect_variable): Doc fix (Bug#11040).
407
55802e4a
CY
408 * chartab.c (Fmap_char_table): Doc fix (Bug#12061).
409
410 * editfns.c (Fformat): Doc fix (Bug#12059).
4abcdac8 411 (Fsave_current_buffer): Doc fix (Bug#11542).
55802e4a 412
8e99d072
BR
4132012-08-14 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
414
415 * keyboard.c (access_keymap_keyremap): Accept anonymous functions
416 (bug#12022).
417
08908aca
MR
4182012-08-14 Martin Rudalics <rudalics@gmx.at>
419
420 * frame.c (make_frame_without_minibuffer, make_minibuffer_frame)
421 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
422 * minibuf.c (choose_minibuf_frame, read_minibuf):
423 * w32fns.c (x_create_tip_frame):
424 * xfns.c (x_create_tip_frame): Call set_window_buffer instead of
425 Fset_window_buffer (Bug#11984, Bug#12025, Bug#12026).
426
56120d6f
PE
4272012-08-14 Paul Eggert <eggert@cs.ucla.edu>
428
429 * intervals.c (offset_intervals): Remove obsolete comment.
430
67b77c0b
AS
4312012-08-14 Andreas Schwab <schwab@linux-m68k.org>
432
433 * gtkutil.c (find_rtl_image, update_frame_tool_bar): Use NILP.
434
f48b82fd
GR
4352012-08-14 Gergely Risko <gergely@risko.hu>
436
437 * coding.c (decode_coding): Record buffer modification before
438 disabling undo_list (Bug#11773).
439
fd318b54
DA
4402012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
441
442 Revert and cleanup some recent overlay changes.
443 * buffer.h (enum overlay_type): Remove.
444 (buffer_get_overlays, buffer_set_overlays): Likewise.
445 (buffer_set_overlays_before, buffer_set_overlays_after):
446 New function. Adjust users.
447 (unchain_both): Add eassert.
448
41a62dd9
DA
4492012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
450
451 * gtkutil.c (update_frame_tool_bar): Use EQ where appropriate.
452
5884c324
PE
4532012-08-14 Paul Eggert <eggert@cs.ucla.edu>
454
455 * gtkutil.c (xg_mark_data): Don't assume C99.
456
ca06f160
JD
4572012-08-13 Jan Djärv <jan.h.d@swipnet.se>
458
459 * gtkutil.c (xg_frame_tb_info): New struct.
460 (TB_INFO_KEY): New define.
461 (xg_free_frame_widgets): Free xg_frame_tb_info for frame if present.
462 (xg_mark_data): Mark Lisp_Objects in xg_frame_tb_info.
463 (xg_create_tool_bar): Allocate and initialize a xg_frame_tb_info
464 if not present.
465 (update_frame_tool_bar): Return early if data in xg_frame_tb_info
466 is up to date. Otherwise store new data.
467 (free_frame_tool_bar): Free xg_frame_tb_info if present.
468
7864a3f7
DA
4692012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
470
471 Use KSET for write access to Lisp_Object members of struct kboard.
472 * keyboard.h (KSET): New macro.
473 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
474 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
475 * xterm.c: Adjust users.
476
4c31be61
DA
4772012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
478
479 Use BSET for write access to Lisp_Object members of struct buffer.
480 * buffer.h (BSET): New macro.
481 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
482 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
483 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
484 * window.c, xdisp.c, xfns.c: Adjust users.
485
14ae4239
BT
4862012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
487
488 * lread.c (syms_of_lread): Initialize Vlexical_binding.
489
32bcadb4
JD
4902012-08-11 Jan Djärv <jan.h.d@swipnet.se>
491
3d29b2ce
JD
492 * nsterm.m (not_in_argv): New function.
493 (application:openFile, application:openTempFile:):
494 (application:openFileWithoutUI:, application:openFiles:): Open file
495 if not_in_argv returns non-zero (bug#12171).
496
32bcadb4 497 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
498 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
499 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
500 (xg_get_font_name): Use those functions/macros here.
501 Reported by Frans Oilinki <moilinki@gmail.com>.
502
9ff9402d 5032012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
504
505 * unexmacosx.c (copy_data_segment): Copy initialized data in
506 statically linked libraries from input file rather than memory.
507
db74a5fc
YM
508 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
509 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
510 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
511
25e65510
GM
5122012-08-10 Glenn Morris <rgm@gnu.org>
513
514 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
515 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
516
7961135c
DA
5172012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
518
519 Fix last change to allow compilation with low optimization levels.
520 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
521 Reported by Jan Djärv <jan.h.d@swipnet.se>.
522
42b3a444
DA
5232012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
524
525 Use common inline syntax in intervals.h.
526 * intervals.h (INTERVALS_INLINE): New macro.
527 Change all users from LISP_INLINE.
528
9fb0c957
DA
5292012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
530
531 Define Qnone once for all platforms.
532 * frame.c (Qnone): Define here.
533 (syms_of_frame): DEFSYM it.
534 * lisp.h (Qnone): New declaration.
535 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
536 * xfns.c: Remove duplication. Adjust users.
537
65e8ee52
DA
5382012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
539
540 Remove unused macros from intervals.h.
541 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
542 * intervals.c: Adjust comment.
543
9b855fd6
EZ
5442012-08-10 Eli Zaretskii <eliz@gnu.org>
545
546 * w32fns.c <w32_unicode_gui>: New static variable.
547 (globals_of_w32fns): Initialize it according to os_subtype.
548 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
549 testing os_subtype.
550
39cb9e56 5512012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
552 Eli Zaretskii <eliz@gnu.org>
553
554 Fix bug #10299 with Unicode characters sent by customized
555 keyboards created by MSKLC.
556 * w32fns.c (INIT_WINDOW_CLASS): New macro.
557 (w32_init_class): Use it to initialize the Emacs class with either
558 ANSI or Unicode API calls.
559 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
560 later.
561 (w32_wnd_proc): If the character code sent by WM_CHAR or
562 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
563 original message. Call DefWindowProcW on NT and later.
564
9374581a
GM
5652012-08-10 Glenn Morris <rgm@gnu.org>
566
4b94e8cf
GM
567 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
568
9374581a
GM
569 * lisp.h (DIRECTORY_SEP): Let configure set it.
570
a2752828
DA
5712012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
572
573 Use TSET for write access to Lisp_Object slots of struct terminal.
574 * termhooks.h (TSET): New macro.
575 * coding.c, terminal.c, xselect.c: Adjust users.
576
cc92c454
SM
5772012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
578
579 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
580 the failing expression, include them in the error message.
581 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
582 * lisp.h (internal_condition_case_n): Update declaration.
583
4cb3e6b3
DA
5842012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
585
586 Inline functions to examine and change buffer overlays.
587 * buffer.c (unchain_both): New function.
588 * buffer.h (buffer_get_overlays, buffer_set_overlays):
589 (buffer_has_overlays): New function.
590 (enum overlay_type): New enum.
591 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
592 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
593
8707c1e5
DA
5942012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
595
596 Inline functions to examine and change buffer intervals.
597 * alloc.c (mark_interval_tree): Remove.
598 (MARK_INTERVAL_TREE): Simplify.
599 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
600 * intervals.c (buffer_balance_intervals): New function.
601 (graft_intervals_into_buffer): Adjust indentation.
602 (set_intervals_multibyte): Simplify.
603 * buffer.h (BUF_INTERVALS): Remove.
604 (buffer_get_intervals, buffer_set_intervals): New function.
605 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
606 * intervals.c, textprop.c: Adjust users.
607
ad8c997f
DA
6082012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
609
610 Inline functions to examine and change string intervals.
611 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
612 (string_get_intervals, string_set_intervals): New function.
613 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
614 * lread.c, print.c, textprop.c: Adjust users.
615
32ac3a6b
GM
6162012-08-08 Glenn Morris <rgm@gnu.org>
617
618 * lisp.mk (lisp): Remove language/persian.elc.
619
77c7bcb1
DA
6202012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
621
622 Cleanup intervals.
623 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
624 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
625 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
626 Adjust comment. Move under #if 0.
77c7bcb1
DA
627 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
628 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
629
9c08a8d4
DA
6302012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
631
632 Check total length of intervals with eassert.
633 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
634 * intervals.c: Change all users to eassert.
635
26d16b35
EZ
6362012-08-07 Eli Zaretskii <eliz@gnu.org>
637
14ae4239
BT
638 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
639 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
640 INTERNAL_FIELD in Lisp_Cons.
641
c644523b
DA
6422012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
643
644 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
645 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
646 name since all xname users are fixed long time ago. Do not
647 use INTERNAL_FIELD.
648 (set_symbol_name, set_symbol_function, set_symbol_plist):
649 (set_symbol_next, set_overlay_plist): New function.
650 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
651 (struct Lisp_Overlay): Likewise.
652 (CVAR, MVAR, SVAR): Remove.
653 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
654 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
655 * xterm.c: Adjust users.
656 * .gdbinit: Change to use name field of struct Lisp_Symbol
657 where appropriate.
658
6a3d20cc
DA
6592012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
660
661 Basic functions to set Lisp_Object and pointer slots of intervals.
662 * intervals.h (interval_set_parent, interval_set_object):
663 (interval_set_left, interval_set_right, interval_set_plist):
664 (interval_copy_parent): New function.
665 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
666 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
667 Adjust indentation.
6a3d20cc
DA
668 (INTERVAL_SIZE): Remove. Adjust users.
669 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
670
4d2b044c
DA
6712012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
672
673 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
674 * process.h (PGET): Remove.
675 (struct Lisp_Process): Do not use INTERNAL_FIELD.
676 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
677
d3d50620
DA
6782012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
679
680 Drop WGET and revert read access to Lisp_Objects slots of struct window.
681 * window.h (WGET): Remove.
682 (struct window): Do not use INTERNAL_FIELD.
683 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
684 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
685 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
686 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
687 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
688 Adjust users.
689
d10a51dc
CY
6902012-08-07 Chong Yidong <cyd@gnu.org>
691
692 * window.c (Fwindow_edges, Fwindow_pixel_edges)
693 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
694 (Fdelete_window_internal): Signal an error if the window is not on
695 a live frame (Bug#12025).
696
e69b0960
DA
6972012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
698
699 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
700 * frame.h (FGET): Remove.
701 (struct frame): Do not use INTERNAL_FIELD.
702 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
703 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
704 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
705 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
706
25a20a3a
JB
7072012-08-06 Juanma Barranquero <lekktu@gmail.com>
708
709 * w32.c: Silence compiler warnings.
710 (map_w32_filename): Remove unused variable `is_fat'.
711 (chase_symlinks): Add parentheses around expression.
712
1c6f11f4
GM
7132012-08-06 Glenn Morris <rgm@gnu.org>
714
1db4583a
GM
715 * sysdep.c: Respect BROKEN_GETWD.
716
1c6f11f4
GM
717 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
718 Let configure handle it.
719 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
720
2b90362b
DA
7212012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
722
723 Use GCALIGNMENT where appropriate.
724 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
725 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
726 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
727
5f50daf2
EZ
7282012-08-06 Eli Zaretskii <eliz@gnu.org>
729
14ae4239
BT
730 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
731 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 732
cbcc7007
SM
7332012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
734
735 * buffer.h (struct buffer): Revert `indirections' to a simple int;
736 that should be sufficient for everyone.
737
4d365fa4
JD
7382012-08-06 Jan Djärv <jan.h.d@swipnet.se>
739
740 * keyboard.c (timer_check_2): Add break so timer_check returns next
741 timeout.
742
dd86bd82
DA
7432012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
744
745 Fix Windows build errors introduced after converting to WGET and WSET.
746 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
747 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
748
054e1668
JD
7492012-08-06 Jan Djärv <jan.h.d@swipnet.se>
750
751 * nsterm.m (ns_frame_rehighlight): Use FSET.
752
753 * nsmenu.m (ns_update_menubar): Use FSET.
754
21238f11
DA
7552012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
756
757 Separate read and write access to Lisp_Object slots of Lisp_Process.
758 * process.h (PGET, PSET): New macros similar to AREF and ASET.
759 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
760
077288cf
DA
7612012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
762
763 Separate read and write access to Lisp_Object slots of struct window.
764 * window.h (WGET, WSET): New macros similar to AREF and ASET.
765 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
766 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
767 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
768 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
769 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
770 Adjust users.
771
71688bd7
DA
7722012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
773
774 Fix Windows build errors introduced after converting to FGET and FSET.
775 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
776 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
777 (w32_judge_scroll_bars): Change to use FSET.
778 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
779
f99bac93
DA
7802012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
781
782 Fix replacement typo.
783 * window.c (replace_window): Set root_window instead of
784 selected_window. This fixes a total window subsystem
785 malfunction reported by Bastien Guerry <bzg@gnu.org>.
786
8c2a0f2d
GM
7872012-08-06 Glenn Morris <rgm@gnu.org>
788
789 * lisp.mk (lisp): Add language/persian.elc.
790
edd74c35
DA
7912012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
792
793 Separate read and write access to Lisp_Object slots of struct frame.
794 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
795 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
796 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
797 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
798 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
799
8671676c
AS
8002012-08-05 Andreas Schwab <schwab@linux-m68k.org>
801
802 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
803
663e2b3f
DA
8042012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
805
806 Generalize common compile-time constants.
807 * lisp.h (header_size, bool_header_size, word_size): Now here.
808 (struct Lisp_Vector): Add comment.
809 (struct Lisp_Bool_Vector): Move up to define handy constants.
810 (VECSIZE, PSEUDOVECSIZE): Simplify.
811 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
812 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
813 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
814 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
815 * xfont.c, xmenu.c: Use word_size where appropriate.
816
d32e47af
LM
8172012-08-05 Lawrence Mitchell <wence@gmx.li>
818
819 * search.c (Freplace_match): Treat \? in the replacement text
820 literally (Bug#8161).
821
e5d9c0d1
CY
8222012-08-05 Chong Yidong <cyd@gnu.org>
823
824 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
825 * frame.c (Vdelete_frame_functions):
826 * emacs.c (Vkill_emacs_hook): Doc fix.
827
8da0576b
EZ
8282012-08-04 Eli Zaretskii <eliz@gnu.org>
829
830 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
831 --with-x-toolkit=no builds.
832 Reported by Carsten Mattner <carstenmattner@gmail.com>.
833
02676e5d
CY
8342012-08-04 Chong Yidong <cyd@gnu.org>
835
836 * syntax.c (Fmodify_syntax_entry): Doc fix.
837
97147da9
EZ
8382012-08-04 Eli Zaretskii <eliz@gnu.org>
839
76151e2c
EZ
840 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
841 * w32.c (init_environment): Change the default values of many
842 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
843 them into environment when they were not already defined.
844 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 845 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
846 (check_windows_init_file): Now external, not static.
847 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
848 called when Vload_path is already set up.
849
850 * w32.h (check_windows_init_file): Add prototype.
851
852 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
853 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
854 compatibility with Posix platforms.
855 (main): Move the call to check_windows_init_file to here from
856 w32.c.
857 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
858 any, in the DEFALT argument into the root of the Emacs build or
859 installation tree, as appropriate.
860
861 * callproc.c (init_callproc_1): Call decode_env_path instead of
862 doing its equivalent by hand.
863 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
864 the code that sets Vexec_path run on MS-Windows.
865
866 * lread.c (init_lread): Add comments to #ifdef's.
867
97147da9
EZ
868 * msdos.c (dos_set_window_size, IT_update_begin)
869 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
870 instead of direct references.
871
185ee146
PE
8722012-08-04 Paul Eggert <eggert@cs.ucla.edu>
873
874 Export DEFAULT_REHASH_* to GDB.
875 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
876 Now constants, not macros.
877
8834c57a
PE
8782012-08-03 Paul Eggert <eggert@cs.ucla.edu>
879
98c6f1e3
PE
880 Remove unnecessary casts involving pointers.
881 These casts are no longer needed now that we assume C89 or later,
882 since they involve casting to or from void *.
883 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
884 (make_pure_float, make_pure_vector):
885 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
886 * macros.c (Fstart_kbd_macro):
887 * menu.c (find_and_return_menu_selection):
888 * minibuf.c (read_minibuf_noninteractive):
889 * sysdep.c (closedir):
890 * xdisp.c (x_produce_glyphs):
891 * xfaces.c (compare_fonts_by_sort_order):
892 * xfns.c (x_real_positions, select_visual):
893 * xselect.c (x_stop_queuing_selection_requests)
894 (x_get_window_property, x_get_window_property_as_lisp_data):
895 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
896 Remove unnecessary pointer casts.
897 * alloc.c (record_xmalloc): New function.
898 * lisp.h (record_xmalloc): New decl.
899 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
900 more like a function. This is because the pointer cast is not
901 needed. All uses changed.
902 * print.c (print_string, print_error_message): Avoid length recalc.
903
8834c57a
PE
904 Improve fix for macroexp crash with debugging (Bug#12118).
905 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
906 ARRAY_MARK_FLAG when checking subscripts, because ASET is
907 not supposed to be invoked from the garbage collector.
908 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
909 (gc_aset): New function, which is like ASET but can be
910 used in the garbage collector.
911 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
912 (set_hash_index): Use it instead of ASET.
913
6dad7178
EZ
9142012-08-03 Eli Zaretskii <eliz@gnu.org>
915
916 Support symlinks on latest versions of MS-Windows.
917 * w32.c: Include winioctl.h and aclapi.h.
918 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
919 (revert_to_self): Forward declarations of static functions.
920 <static BOOL g_b_init_get_security_info>:
921 <g_b_init_create_symbolic_link>: New static flags.
922 (globals_of_w32): Initialize them to zero.
923 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
924 (map_w32_filename): Improve commentary. Simplify switch.
925 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
926 headers (most versions of MinGW w32api don't).
927 (get_security_info, create_symbolic_link)
928 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
929 New functions.
930 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
931 in the argument file name.
932 (sys_access): Call unc_volume_file_attributes only if
933 GetFileAttributes fails with network-related error codes.
934 (sys_rename): Diagnose renaming of a symlink when the user doesn't
935 have the required privileges.
14ae4239 936 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
937 get_file_security_desc.
938 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
939 with addition of handling of symlinks and support for 'lstat'.
940 If possible, get file's attributes and security information by
6dad7178
EZ
941 handle, not by name. Produce S_IFLNK bit for symlinks, when
942 called from 'lstat'.
943 (stat, lstat): New functions, call 'stat_worker'.
944 (symlink, readlink, careadlinkat): Rewritten to create and resolve
945 symlinks when the underlying filesystem supports them.
946
f162bcc3
PE
9472012-08-02 Paul Eggert <eggert@cs.ucla.edu>
948
79ea6c20
PE
949 Fix macroexp crash on Windows with debugging (Bug#12118).
950 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
951 checking subscripts; problem introduced with the recent
952 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
953 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
954 since it's used in non-static inline functions now.
955
c0ce93fd
PE
956 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
957 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 958
f162bcc3
PE
959 Use C99-style 'extern inline' if available.
960 * buffer.h (BUFFER_INLINE):
961 * category.h (CATEGORY_INLINE):
962 * character.h (CHARACTER_INLINE):
963 * charset.h (CHARSET_INLINE):
964 * composite.h (COMPOSITE_INLINE):
965 * dispextern.h (DISPEXTERN_INLINE):
966 * lisp.h (LISP_INLINE):
967 * systime.h (SYSTIME_INLINE):
968 New macro, replacing 'static inline' in this header.
969 * buffer.h, category.h, character.h, charset.h, composite.h:
970 * dispextern.h, lisp.h, systime.h:
971 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
972 * alloc.c (LISP_INLINE):
973 * buffer.c (BUFFER_INLINE):
974 * category.c (CATEGORY_INLINE):
975 * character.c (CHARACTER_INLINE):
976 * charset.c (CHARSET_INLINE):
977 * composite.c (COMPOSITE_INLINE):
978 * dispnew.c (DISPEXTERN_INLINE):
979 * sysdep.c (SYSTIME_INLINE):
980 Define to EXTERN_INLINE, so that the corresponding functions
981 are compiled into code.
982 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
983 (INLINE_HEADER_END): New macros.
984 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
985 since it's used in non-static inline functions now.
a8333d03 986 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 987
837b365b
GM
9882012-08-02 Glenn Morris <rgm@gnu.org>
989
d66b744d
GM
990 * s/: Remove empty directory.
991
837b365b
GM
992 * s/ms-w32.h: Move to ../nt/inc.
993 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
994 Update for new ms-w32.h location.
995
13294f95
PE
9962012-08-02 Paul Eggert <eggert@cs.ucla.edu>
997
998 Port to Solaris 8.
999 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
1000
90df0db3
GM
10012012-08-02 Glenn Morris <rgm@gnu.org>
1002
1003 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
1004 hard-coding the path separator.
1005
4939150c
PE
10062012-08-01 Paul Eggert <eggert@cs.ucla.edu>
1007
1008 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
1009 This how ASET and AREF are supposed to work, and makes
1010 it easier to think about future improvements. See
1011 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
1012 * charset.h (set_charset_attr): New function.
1013 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
1014 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
1015 (aref_addr): New function. All uses of &AREF(...) changed.
1016 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
1017 (set_hash_index): New functions. All lvalue-style uses of
1018 HASH_KEY etc. changed.
1019 * keyboard.c (set_prop): New function. All lvalue-style uses
1020 of PROP changed.
1021
947b2afd
AA
10222012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
1023
1024 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
1025 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
1026 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
1027 * nsfns.m (ns_set_name_as_filename): Likewise.
1028 * nsmenu.m (ns_update_menubar): Likewise.
1029 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
1030
4f5d0325
EZ
10312012-08-01 Eli Zaretskii <eliz@gnu.org>
1032
2008beae
EZ
1033 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
1034 Adapt to latest changes in field names of the corresponding Lisp
288479f6 1035 objects.
2008beae 1036
4f5d0325
EZ
1037 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
1038
fe3cc771
GM
10392012-08-01 Glenn Morris <rgm@gnu.org>
1040
1041 * s/msdos.h: Remove file.
1042 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
1043 * Makefile.in (S_FILE): Remove.
1044 (config_h): Remove S_FILE.
1045
c90acc54
JB
10462012-08-01 Juanma Barranquero <lekktu@gmail.com>
1047
1048 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
1049 Remove; moved to nt/config.nt.
1050
d8a05828
DA
10512012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1052
1053 Use INTERNAL_FIELD for conses and overlays.
1054 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
1055 Remove obsolete comment.
1056 (MVAR): New macro.
1057 (struct Lisp_Overlay): Use INTERNAL_FIELD.
1058 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
1059
8271d590
DA
10602012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1061
1062 Use INTERNAL_FIELD for symbols.
1063 * lisp.h (SVAR): New macro. Adjust users.
1064 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
1065 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
1066
3193acd2
DA
10672012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1068
1069 Use INTERNAL_FIELD for processes.
1070 * process.h (PVAR): New macro. Adjust style.
1071 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
1072 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
1073
3a45383a
DA
10742012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1075
1076 Use INTERNAL_FIELD for windows.
1077 * window.h (WVAR): New macro.
1078 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
1079 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
1080 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
1081 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
1082 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
1083 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
1084
c1dbc63c
PE
10852012-08-01 Paul Eggert <eggert@cs.ucla.edu>
1086
1087 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
1088
5c0c0e8a
GM
10892012-08-01 Glenn Morris <rgm@gnu.org>
1090
1091 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
1092 Move to configure.ac.
1093
552a99b4
JB
10942012-08-01 Juanma Barranquero <lekktu@gmail.com>
1095
1096 * makefile.w32-in (CONFIG_H): Update dependencies.
1097 (CONF_POST_H): New macro.
1098
1099 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
1100
8d8e2dfe
GM
11012012-07-31 Glenn Morris <rgm@gnu.org>
1102
bc96620a
GM
1103 * Makefile.in (S_FILE): No longer set by configure.
1104
476b1b2d
GM
1105 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
1106 is available.
1107 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
1108
b2c7a106
GM
1109 * process.h (NULL_DEVICE):
1110 * emacs.c (SEPCHAR):
1111 * editfns.c (USER_FULL_NAME): Let configure set them.
1112
d53d062a
GM
1113 * s/README, s/template.h: Remove files.
1114
4515017f
GM
1115 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
1116
8d8e2dfe
GM
1117 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
1118 Move to configure.ac.
1119
5b20b3cc
EZ
11202012-07-31 Eli Zaretskii <eliz@gnu.org>
1121
1e0afd9a
EZ
1122 * .gdbinit (xframe): Adapt to introduction of FVAR and the
1123 resulting renaming of 'struct frame' members.
1124
5b20b3cc
EZ
1125 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
1126
1127 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
1128 after introduction of FVAR.
1129
f1310128
JD
11302012-07-31 Jan Djärv <jan.h.d@swipnet.se>
1131
79e721e0
JD
1132 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
1133
1134 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
1135 instead of compositeToPoint.
1136 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
1137
8d7c7eed 1138 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 1139
e34f7f79
DA
11402012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1141
1142 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
1143 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 1144 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
1145 (BVAR): Change to use INTERNAL_FIELD.
1146 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
1147 (KVAR): Change to use INTERNAL_FIELD.
1148 * frame.h (FVAR): New macro.
1149 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
1150 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
1151 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
1152 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
1153 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
1154
c09bfb2f
DA
11552012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1156
1157 Miscellaneous fixes for non-default X toolkits.
1158 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
1159 * xterm.c (x_frame_of_widget): Remove redundant prototype.
1160 Move under #ifdef USE_LUCID.
1161 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
1162 definition and usage to avoid warnings.
1163
14c114ae
JD
11642012-07-31 Jan Djärv <jan.h.d@swipnet.se>
1165
1166 * nsterm.m (openFiles): Fix previous checkin.
1167
3bd21e82
PE
11682012-07-31 Paul Eggert <eggert@cs.ucla.edu>
1169
1170 * indent.c (compute_motion): Remove unused local.
1171
c1529ded
GM
11722012-07-31 Glenn Morris <rgm@gnu.org>
1173
400d5621
GM
1174 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
1175
268e2432
GM
1176 * conf_post.h [USG5_4]:
1177 Move remaining contents of s/usg5-4-common.h here.
1178 * s/usg5-4-common.h: Remove file.
1179
7552f3ee
GM
1180 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
1181 * s/irix6-5.h: Remove file.
1182
6a381852
GM
1183 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
1184 * s/darwin.h: Remove file.
1185
c1529ded
GM
1186 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
1187 * s/hpux10-20.h: Remove file, which is now empty.
1188
b429a4ee
GM
11892012-07-30 Glenn Morris <rgm@gnu.org>
1190
1191 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
1192 * Makefile.in (config_h): Add conf_post.h.
1193 * makefile.w32-in (CONFIG_H): Add conf_post.h.
1194
adff3182
JD
11952012-07-30 Jan Djärv <jan.h.d@swipnet.se>
1196
1197 * nsterm.m (ns_do_open_file): New variable.
b9031d69 1198 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
1199 (openFile, openTempFile, openFileWithoutUI, openFiles):
1200 Open files only if ns_do_open_file.
adff3182 1201
c32af1e4
PE
12022012-07-30 Paul Eggert <eggert@cs.ucla.edu>
1203
7393bcbb
PE
1204 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
1205 This no-op macro hasn't been needed for many years.
1206 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
1207
c32af1e4
PE
1208 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
1209 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
1210 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
1211 gdb_make_enums_visible.
1212 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
1213 (DIRECTORY_SEP): Now a constant, not a macro.
1214
302fc036
EZ
12152012-07-30 Eli Zaretskii <eliz@gnu.org>
1216
1217 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
1218 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
1219
1220 * w32term.c <w32_keyboard_codepage>: Renamed from
1221 keyboard_codepage and now external. All users changed.
1222
1223 * w32term.h: Add declaration of w32_keyboard_codepage.
1224
1225 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
1226 the codepage to translate keys to Unicode. If this argument is
1227 -1, use the value returned by GetConsoleCP. All callers changed.
1228
88fb40b4
PE
12292012-07-30 Paul Eggert <eggert@cs.ucla.edu>
1230
0aee6912
PE
1231 Update .PHONY listings in makefiles.
1232 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
1233 bootstrap-clean, distclean, maintainer-clean, versioclean,
1234 extraclean, frc.
1235
88fb40b4
PE
1236 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
1237 This is a bit clearer. Fix some commentary typos.
1238
0a763bd1
GM
12392012-07-30 Glenn Morris <rgm@gnu.org>
1240
32bac6d6
GM
1241 * s/netbsd.h: Let configure include signal.h if needed.
1242 Remove file, which is now empty.
1243
b65e7c46
GM
1244 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
1245 Let configure set them.
1246 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
1247 No more need to undefine.
0a763bd1 1248
169304bd
AS
12492012-07-30 Andreas Schwab <schwab@linux-m68k.org>
1250
1251 * keymap.c (Fkey_description): Don't remove 0x80 bit from
1252 non-single-byte char when adding meta modifier. (Bug#12090)
1253
6cd7a139
DA
12542012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1255
1256 Convert safe_call to use variable number of arguments.
1257 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
1258 (safe_call2): Fix comment.
1259 * lisp.h (safe_call): Adjust prototype.
1260 * coding.c (encode_coding_object): Change to use safe_call2.
1261 * xfaces.c (merge_face_heights): Change to use safe_call1.
1262
d34d6ffc
GM
12632012-07-30 Glenn Morris <rgm@gnu.org>
1264
7b8a48e4 1265 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 1266 does that unconditionally. Remove file, which is now empty.
7b8a48e4 1267
d34d6ffc
GM
1268 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
1269 Remove empty files.
1270
03a660a6
PE
12712012-07-30 Paul Eggert <eggert@cs.ucla.edu>
1272
1273 Export to GDB most of lisp.h's remaining object-like macros.
1274 * lisp.h (min, max): Move earlier, because they're used earlier now.
1275 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
1276 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
1277 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
1278 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
1279 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
1280 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
1281 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
1282 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
1283 Now constants, for GDB. They need not be macros.
1284 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
1285 Now constants, for GDB, as well as macros, for static initializers.
1286 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
1287 Move to after the definition of struct Lisp_Char_Table,
1288 since the former now needs that type defined.
1289 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
1290 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
1291 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
1292 New enums, for gdb_make_enums_visible.
1293 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 1294 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
1295 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
1296 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
1297 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
1298 enum maxargs, enum MAX_ALLOCA.
1299 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
1300 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
1301 no longer needed, now that they are done in lisp.h.
1302
e499d0ee
DA
13032012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1304
1305 Cleanup string bytes checking.
1306 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
1307 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
1308 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
1309 (check_sblock, compact_small_strings): Simplify.
1310
d5040d2d
PE
13112012-07-29 Paul Eggert <eggert@cs.ucla.edu>
1312
1313 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
1314 These macros are confusing and no longer need to be defined, as
1315 the enum values now suffice. All uses replaced with definiens.
1316 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
1317
7f259ae6
JB
13182012-07-29 Juanma Barranquero <lekktu@gmail.com>
1319
1320 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
1321 ($(BLD)/w32console.$(O)): Update dependencies.
1322
7e63e0c3
DA
13232012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1324
1325 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
1326 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
1327 time. Adjust users.
1328 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
1329
ffd817eb
JD
13302012-07-29 Jan Djärv <jan.h.d@swipnet.se>
1331
1332 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
1333 setting sitelisp (Bug#12010).
1334
417a7a0e
EZ
13352012-07-29 Eli Zaretskii <eliz@gnu.org>
1336
14ae4239 1337 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
1338
1339 * w32heap.c (cache_system_info):
1340 * w32.c (sys_rename):
1341 * w32proc.c (find_child_console, sys_kill): All users changed.
1342
387d4d92
PE
13432012-07-29 Paul Eggert <eggert@cs.ucla.edu>
1344
1345 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
1346
55a6cca6
EZ
13472012-07-29 Eli Zaretskii <eliz@gnu.org>
1348
1349 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
1350
dbcf001c
DA
13512012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1352
1353 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
1354 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
1355 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 1356
e2688e4a
DA
13572012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1358
1359 Generalize marker debugging code under MARKER_DEBUG and use eassert.
1360 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
1361 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
1362 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
1363 (replace_range, replace_range_2, del_range_2): Change to eassert.
1364 * marker.c (byte_char_debug_check): Adjust style.
1365
b46a6a83
PE
13662012-07-29 Paul Eggert <eggert@cs.ucla.edu>
1367
1368 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
1369 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
1370 long-ago-commented-out code that talks about "WIN32".
1371 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
1372 All uses changed.
1373
e32a5799
PE
13742012-07-28 Paul Eggert <eggert@cs.ucla.edu>
1375
1376 Use Gnulib stdalign module (Bug#9772, Bug#9960).
1377 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
1378 Simplify by using alignof.
1379 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
1380 * lisp.h: Include <stdalign.h>.
1381 (GCALIGNMENT): New macro and constant.
1382 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
1383 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
1384 (stdalign): New macro, if not already defined.
1385
df81cd29
EZ
13862012-07-28 Eli Zaretskii <eliz@gnu.org>
1387
01bd1b0d
EZ
1388 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
1389 * w32inevt.c: Include w32inevt.h.
1390 (w32_read_console_input): New inline function, calls either
1391 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
1392 w32_console_unicode_input.
1393 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
1394 (w32_kbd_patch_key, key_event): Use the codepage returned by
1395 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
1396 (key_event): use uChar.UnicodeChar only if
1397 w32_console_unicode_input is non-zero.
1398
1399 * w32console.c: Include w32heap.h.
1400 <w32_console_unicode_input>: New global variable.
1401 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
1402 family of Windows, zero otherwise.
1403
1404 * w32inevt.h: Declare w32_console_unicode_input.
1405
df81cd29
EZ
1406 * xdisp.c (init_iterator): Don't reference tip_frame in a build
1407 --without-x. (Bug#11742)
1408
c20fdd9e
PE
14092012-07-27 Paul Eggert <eggert@cs.ucla.edu>
1410
1411 Adjust GDB to reflect pvec_type changes (Bug#12036).
1412 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
1413 2012-07-04 changes to pseudovector representation.
1414 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 1415
32770973 14162012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
1417
1418 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
1419 bus address.
1420 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
1421
3438fe21
EZ
14222012-07-27 Eli Zaretskii <eliz@gnu.org>
1423
bcfbc9de
EZ
1424 * alloc.c (listn): Fix the order the arguments are consed onto the
1425 list.
1426
3438fe21
EZ
1427 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
1428 enumeration constants, as PURE and HEAP are too general, and clash
1429 with other headers and sources, such as gmalloc.c and the
1430 MS-Windows system headers. All users changed.
1431
eeaea515
DA
14322012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1433
1434 Revert last save_excursion_save and save_excursion_restore changes.
1435 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
1436 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
1437
073c88c2
DA
14382012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1439
1440 Fix recently-introduced typos in Windows port.
1441 Reported by Martin Rudalics <rudalics@gmx.at>.
1442 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 1443 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 1444
4706125e
PE
14452012-07-27 Paul Eggert <eggert@cs.ucla.edu>
1446
1447 Improve GDB symbol export (Bug#12036).
1448 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
1449 arms of an 'if', not using conditional expressions; otherwise GDB
1450 complains about the types in the unevaluated arm when the argument
1451 is an integer literal.
1452 (xgetint): Simplify expression.
1453 * alloc.c (gdb_make_enums_visible): New constant. This ports to
1454 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
1455 Zaretskii in <http://bugs.gnu.org/12036#13>.
1456 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
1457 needed now that we have gdb_make_enums_visible.
1458 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
1459 (enum enum_USE_LSB_TAG):
1460 New enum types, packaging up enums that need to be exported to GDB.
1461
694b6c97
DA
14622012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1463
1464 Utility function to make a list from specified amount of objects.
1465 * lisp.h (enum constype): New datatype.
1466 (listn): New prototype.
1467 * alloc.c (listn): New function.
1468 (Fmemory_use_count, syms_of_alloc): Use it.
1469 * buffer.c (syms_of_buffer): Likewise.
1470 * callint.c (syms_of_callint): Likewise.
1471 * charset.c (define_charset_internal): Likewise.
1472 * coding.c (syms_of_coding): Likewise.
1473 * keymap.c (syms_of_keymap): Likewise.
1474 * search.c (syms_of_search): Likewise.
1475 * syntax.c (syms_of_syntax): Likewise.
1476 * w32.c (init_environment): Likewise.
1477 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
1478 * xdisp.c (syms_of_xdisp): Likewise.
1479 * xfns.c (syms_of_xfns): Likewise.
1480
6195f384
DA
14812012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1482
1483 Fast save_excursion_save and save_excursion_restore.
1484 * lisp.h (struct Lisp_Excursion): New data type.
1485 (PVEC_EXCURSION): New pseudovector type.
1486 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
1487 to deal with it. Adjust comments.
1488 (init_marker, attach_marker): New prototype.
1489 (unchain_marker): Adjust prototype.
1490 * marker.c (attach_marker): Change to global.
1491 (init_marker): New function.
1492 * alloc.c (Fmake_marker, build_marker): Use it.
1493 (build_marker): More easserts.
1494 (mark_object): Handle struct Lisp_Excursion.
1495 * editfns.c (save_excursion_save, save_excursion_restore):
1496 Reimplement to use struct Lisp_Excursion. Add comments.
1497
5eceb8fb
PE
14982012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1499
1500 Fix export of symbols to GDB (Bug#12036).
1501 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
1502 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
1503 emacs.c, as this is a more-suitable home. Had this been done earlier
1504 the fix for 12036 would have avoided some of the problems noted in
1505 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
1506 would have been more obvious.
562157c8
PE
1507 * emacs.c: Do not include <verify.h>; no longer needed.
1508 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
1509 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
1510 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1511 Remove; now done in lisp.h.
1512 * lisp.h (PUBLISH_TO_GDB): New macro.
1513 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
1514 (DATA_SEG_BITS): Use it.
1515 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
1516 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
1517 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
1518 not be usable in #if. This simplifies things.
1519
d6749401
JB
15202012-07-26 Juanma Barranquero <lekktu@gmail.com>
1521
1522 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
1523
1781b9e9
PE
15242012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1525
d89518db 1526 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
1527 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
1528 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
1529 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
1530 Adjust to changes in lisp.h and emacs.c, by using
1531 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
1532 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
1533 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
1534 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
1535 instead of gdb_valbits.
1536 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
1537 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
1538 instead of gdb_array_mark_flag.
1539 (xboolvector): Get size from $->size, not $->header.size.
1540 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
1541 (xreload, hook-run, hookpost-run): Remove.
1542 * emacs.c: Include <verify.h>.
1543 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
1544 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
1545 Remove.
1546 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
1547 (gdb_USE_LSB_TAG): New enum constants.
1548 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1549 Also define these as enum constants, so they're visible to GDB.
1550 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
1551 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
1552 as constants, so they're visible to GDB.
1553 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
1554 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
1555 Now enum constants, not macros, so they're visible to GDB.
1556 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
1557 more convenient now. All uses changed.
1558 (VALMASK) [USE_LSB_TAG]: Also define in this case.
1559 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
1560
3628596a
DA
15612012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
1562
1563 Explicitly free restriction data that are not needed anymore.
1564 * editfns.c (save_restriction_restore): Free restriction data.
1565
7abaf5cc
SM
15662012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1567
1568 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
1569 add argument, tune behavior, and adjust all callers.
1570
71f88e00
PE
15712012-07-25 Paul Eggert <eggert@cs.ucla.edu>
1572
1573 Use typedef for EMACS_INT, EMACS_UINT.
1574 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
1575 than macros. This simplifies debugging in the usual case, since
1576 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
1577 and it allows expressions involving EMACS_INT casts.
1578 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
1579
57ec3034
JD
15802012-07-25 Jan Djärv <jan.h.d@swipnet.se>
1581
1582 * nsterm.m (ns_read_socket): Return early if there is a modal
1583 window (Bug#12043).
1584
8137e7b3
MR
15852012-07-25 Martin Rudalics <rudalics@gmx.at>
1586
1587 * frame.c (Fredirect_frame_focus): In doc-string don't mention
1588 that FOCUS-FRAME can be omitted.
1589
04e9897c
DA
15902012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
1591
1592 Adjust buffer text indirection counters at the end of Fkill_buffer.
1593 * buffer.c (Fkill_buffer): Adjust indirection counters when the
1594 buffer is definitely dead. This should really fix an issue reported
1595 by Christoph Scholtes again. (Bug#12007).
1596 (init_buffer_once): Initialize indirection counters of
1597 buffer_defaults and buffer_local_symbols (for sanity and safety).
1598
8a0484e1
EZ
15992012-07-24 Eli Zaretskii <eliz@gnu.org>
1600
1601 * xdisp.c (init_iterator): Don't compute dimensions of truncation
1602 and continuation glyphs on tooltip frames, leave them at zero.
1603 Avoids continued lines in tooltips. (Bug#11832)
1604
fa691a83
DA
16052012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
1606
1607 Simplify copy_overlay.
04e9897c 1608 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
1609 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
1610
436bc8e0
EZ
16112012-07-23 Eli Zaretskii <eliz@gnu.org>
1612
1613 * print.c (print_object): Don't crash when a frame's name is nil
1614 or invalid. (Bug#12025)
1615
1616 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
1617 it signals an error when a tooltip frame is being created.
1618
d7a7fda3
DA
16192012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
1620
1621 Cleanup miscellaneous objects allocation and initialization.
1622 * alloc.c (allocate_misc): Change to static. Add argument to
1623 specify the subtype. Adjust comment and users.
1624 (build_overlay): New function.
1625 * buffer.c (copy_overlays, Fmake_overlay): Use it.
1626 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
1627 (allocate_misc): Remove prototype.
1628 (build_overlay): Add prototype.
1629
16302012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
1631
1632 Swap buffer text indirection counters in Fbuffer_swap_text.
1633 * buffer.c (Fbuffer_swap_text): Swap indirections too.
1634 This avoids crash reported by Christoph Scholtes at
1635 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
1636
9d7fa573
JD
16372012-07-22 Jan Djärv <jan.h.d@swipnet.se>
1638
1639 * nsmenu.m (Popdown_data): New struct.
1640 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
1641 free Popdown_data.
1642 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
1643 (initWithContentRect): Make imgView and contentView non-static
1644 and autorelease them. Also autorelease img and matrix (Bug#12005).
1645 (dealloc): Remove (Bug#12005).
1646
0dd6d66d
DA
16472012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1648
1649 Adjust consing_since_gc when objects are explicitly freed.
1650 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
1651 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
1652 (free_cons, free_misc): Subtract object size from consing_since_gc.
1653
d36d71df
DA
16542012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1655
1656 Simplify and cleanup markers positioning code.
1657 * marker.c (attach_marker): More useful eassert.
1658 (live_buffer, set_marker_internal): New function.
1659 (Fset_marker, set_marker_restricted): Use set_marker_internal.
1660 (set_marker_both, set_marker_restricted_both): Use live_buffer.
1661
fb9ea40f
PE
16622012-07-22 Paul Eggert <eggert@cs.ucla.edu>
1663
1664 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
1665 as it's limited by the amount of memory, not by INT_MAX.
1666
2d5c5f7d
EZ
16672012-07-21 Eli Zaretskii <eliz@gnu.org>
1668
07fb592e
EZ
1669 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
1670 in special-event-map. See the discussion at
1671 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
1672 for the reasons.
1673
37a9eac8 1674 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
1675 info.dwItemData. Fixes crashes on 64-bit Windows.
1676 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 1677
c4328746
JD
16782012-07-21 Jan Djärv <jan.h.d@swipnet.se>
1679
1680 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 1681 (conversationIdentifier): Return value is NSInteger.
784051c4 1682 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 1683
6e5d1c12
CY
16842012-07-21 Chong Yidong <cyd@gnu.org>
1685
1686 * window.c (decode_any_window): Signal an error if the window is
1687 on a dead frame (Bug#11984).
1688
9928463d
DA
16892012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1690
1691 Add indirection counting to speed up Fkill_buffer.
1692 * buffer.h (struct buffer): New member.
1693 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
1694 (Fmake_indirect_buffer): Set indirection counter to -1, increment
1695 base buffer indirection counter.
1696 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
1697 (Fkill_buffer): Adjust indirection counters as needed, don't walk
1698 through buffer list if indirection counter is 0.
1699
f8643a6b
DA
17002012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1701
1702 Extend the value returned by Fgarbage_collect with heap statistics.
1703 * alloc.c (Qheap): New symbol.
1704 (syms_of_alloc): DEFSYM it.
1705 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
1706 (Fmemory_free): Remove.
1707 (syms_of_alloc): Don't defsubr it.
1708 * buffer.c (Fcompact_buffer): Remove.
1709 (syms_of_buffer): Don't defsubr it.
1710
dac616ff
DA
17112012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1712
1713 Make maybe_gc inline.
1714 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
1715 * lisp.h (consing_since_gc, gc_relative_threshold)
1716 (memory_full_cons_threshold): Revert declaration.
1717 (maybe_gc): Remove prototype, define as inline.
1718 * alloc.c: Remove old commented-out code.
1719 (consing_since_gc, gc_relative_threshold)
1720 (memory_full_cons_threshold): Revert to global.
1721 (maybe_gc): Remove.
1722
d7ea76b4
DA
17232012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1724
1725 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
1726 * lisp.h (build_unibyte_string): New function.
1727 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
1728 * sysdep.c, w32fns.c, xfns.c: Use it.
1729 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
1730 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
1731 Adjust users accordingly.
1732 * font.h (font_open_by_name): Adjust prototype.
1733
765e61e3
DA
17342012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1735
1736 Cleanup calls to Fgarbage_collect.
1737 * lisp.h (maybe_gc): New prototype.
1738 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1739 Remove declarations.
1740 * alloc.c (maybe_gc): New function.
1741 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1742 Make them static.
1743 * bytecode.c (MAYBE_GC): Use maybe_gc.
1744 * eval.c (eval_sub, Ffuncall): Likewise.
1745 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
1746 to avoid dependency from auto-save feature.
1747
52b852c7
PE
17482012-07-19 Paul Eggert <eggert@cs.ucla.edu>
1749
1750 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
1751 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
1752 'for_each_per_buffer_object_at'.
1753 All uses changed. It's better to use upper-case for macros that
1754 cannot be implemented as functions, to give the reader a clue
1755 that they're special.
1756
5db81e33
SM
17572012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
1758
1759 * alloc.c (Fgarbage_collect): Tweak docstring.
1760
5b835e1d
DA
17612012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1762
1763 Tweak the value returned from Fgarbage_collect again.
1764 * alloc.c (Fgarbage_collect): New return value, as confirmed in
1765 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
1766 Adjust documentation.
1767 (total_vector_bytes): Rename to total_vector_slots, adjust
1768 accounting.
1769 (total_free_vector_bytes): Rename to total_free_vector_slots,
1770 adjust accounting.
1771 (Qstring_bytes, Qvector_slots): New symbols.
1772 (syms_of_alloc): DEFSYM them.
1773
9cd47b72
DA
17742012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1775
1776 Buffer compaction primitive which may be used from Lisp.
1777 * buffer.c (compact_buffer, Fcompact_buffer): New function.
1778 (syms_of_buffer): Register Fcompact_buffer.
1779 * alloc.c (Fgarbage_collect): Use compact_buffer.
1780 * buffer.h (compact_buffer): New prototype.
1781 (struct buffer_text): New member.
1782
d17337e5
DA
17832012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1784
1785 New macro to iterate over all buffers, miscellaneous cleanups.
1786 * lisp.h (all_buffers): Remove declaration.
1787 * buffer.h (all_buffers): Add declaration, with comment.
1788 (for_each_buffer): New macro.
1789 * alloc.c (Fgarbage_collect, mark_object): Use it.
1790 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
1791 (init_buffer): Likewise.
1792 * data.c (Fset_default): Likewise.
1793 * coding.c (code_conversion_restore): Remove redundant check
1794 for dead buffer.
1795 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
1796
60cfd278
AS
17972012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1798
1799 Fix bug that created negative-length intervals.
1800 * intervals.c (merge_interval_right, merge_interval_left):
1801 Do not zero out this interval if it is absorbed by its children,
1802 as this interval's total length doesn't change in that case. See
1803 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
1804
d06714cb
PE
18052012-07-18 Paul Eggert <eggert@cs.ucla.edu>
1806
83713154
PE
1807 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
1808 when invoking (make-bool-vector N t) and N is a positive
1809 multiple of 8 -- the last 8 bits were mistakenly cleared.
1810
d06714cb
PE
1811 Remove some struct layout assumptions in bool vectors.
1812 * alloc.c (bool_header_size): New constant.
1813 (header_size, word_size): Move earlier, as they're now used earlier.
1814 Use 'word_size' in a few more places, where it's appropriate.
1815 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
1816 padding before the data member of a bool vector.
1817 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
1818 than doing the check by hand with an abort ().
1819
464d5a5e
SM
18202012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1821
5fbc0409
SM
1822 * eval.c (Fdefvar): Don't check constants since we only set the var if
1823 it's not yet defined anyway (bug#11904).
1824
464d5a5e
SM
1825 * lisp.h (last_undo_boundary): Declare new var.
1826 * keyboard.c (command_loop_1): Set it.
1827 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
1828 were auto-added by the command loop (bug#11774).
1829
8dc2e44a
AS
18302012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1831
1832 * w32font.c (Qsymbol): Remove local definition.
1833 (syms_of_w32font): Don't DEFSYM it.
1834
169925ec
DA
18352012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1836
1837 Fix sweep_vectors to handle large bool vectors correctly.
1838 * alloc.c (sweep_vectors): Account total_vector_bytes for
1839 bool vectors larger than VBLOCK_BYTES_MAX.
1840
5fbfb018
CY
18412012-07-18 Chong Yidong <cyd@gnu.org>
1842
1843 * frame.c (x_set_frame_parameters): Revert bogus change introduced
1844 in 2012-05-25 commit by Paul Eggert (Bug#11738).
1845
3ab6e069
DA
18462012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1847
1848 Return more descriptive data from Fgarbage_collect.
1849 Suggested by Stefan Monnier in
1850 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
1851 * alloc.c (bounded_number): New function.
1852 (total_buffers, total_vectors): New variable.
1853 (total_string_size): Rename to total_string_bytes, adjust users.
1854 (total_vector_size): Rename to total_vector_bytes, adjust users.
1855 (sweep_vectors): Account total_vectors and total_vector_bytes.
1856 (Fgarbage_collect): New return value. Adjust documentation.
1857 (gc_sweep): Account total_buffers.
1858 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
1859 (VECTOR_SIZE): Remove.
1860 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
1861 (Qinterval, Qmisc): New symbols.
1862 (syms_of_data): Initialize them.
1863 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
1864 (Qcons, Qbuffer): New declarations.
1865
6d02fe5b
PE
18662012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1867
1868 * alloc.c (Fmemory_free): Account for memory-free's own storage.
1869 Round up, not down. Improve doc.
1870
b7ffe040
DA
18712012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1872
1873 Restore old code in allocate_string_data to avoid Faset breakage.
1874 Reported by Julien Danjou <julien@danjou.info> in
1875 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
1876 * alloc.c (allocate_string_data): Restore old code with minor
1877 adjustments, fix comment to explain this subtle issue.
1878
4dc7c8d5
SM
18792012-07-17 Eli Zaretskii <eliz@gnu.org>
1880
1881 Remove FILE_SYSTEM_CASE.
1882 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
1883
1884 * fileio.c (FILE_SYSTEM_CASE): Don't define.
1885 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
1886 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
1887 call-process-region passes it through expand-file-name.
1888
1889 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
1890
18912012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1892
1893 Fix crash when creating indirect buffer (Bug#11917)
1894 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
1895 Don't handle unbound variables specially if non-zero.
1896 (Fbuffer_local_variables): Pass zero.
1897 (clone_per_buffer_values): Pass non-zero.
1898
18992012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1900
1901 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
1902 to make the loop interruptible.
1903
19042012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1905
1906 * gnutls.c (emacs_gnutls_handshake): Only retry if
1907 GNUTLS_E_INTERRUPTED.
1908
cce7fefc
DA
19092012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1910
1911 Cleanup and convert miscellaneous checks to eassert.
1912 * alloc.c (mark_interval): Fix comment, partially rephrase
1913 old comment from intervals.h (see below).
1914 * intervals.c (find_interval, adjust_intervals_for_insertion)
1915 (delete_interval, adjust_intervals_for_deletion)
1916 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
1917 Convert to eassert.
1918 (adjust_intervals_for_insertion, make_new_interval):
1919 Remove obsolete and unused code.
1920 * intervals.h (struct interval): Remove obsolete comment.
1921 * textprotp.c (erase_properties): Remove unused code.
1922 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
1923 (Fremove_list_of_text_properties): Convert to eassert.
1924
9ea10cc3
CY
19252012-07-17 Chong Yidong <cyd@gnu.org>
1926
1927 * editfns.c (Finsert_char): Doc fix.
1928
3900d5de
DA
19292012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1930
1931 Fix previous change to make Fmemory_free always accurate.
1932 * alloc.c (make_interval): Update total_free_intervals.
1933 (make_float): Likewise for total_free_floats.
1934 (free_cons, Fcons): Likewise for total_free_conses.
1935 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
1936 Likewise for total_free_vector_bytes.
1937 (Fmake_symbol): Likewise for total_free_symbols.
1938 (bytes_free): Remove.
1939
7098646f
DA
19402012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1941
1942 Simple free memory accounting feature.
1943 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
1944 (sweep_vectors): Accumulate size of free vectors.
1945 (Fgarbage_collect): Setup bytes_free.
1946 (Fmemory_free): New function.
1947 (syms_of_alloc): Register it.
1948
22657b40
DA
19492012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1950
1951 Cleanup overlays checking.
1952 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
1953 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
1954 eassert and OVERLAYP.
1955 (sort_overlays): Change to use OVERLAYP.
1956
ddfc8813
RK
19572012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
1958
1959 * editfns.c (Finsert_char): Make it interactive, and make the
1960 second arg optional. Copy interactive spec and docstring from
1961 ucs-insert.
1962
7c26cf3c
PE
19632012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1964
1965 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
1966 Unlike the other wrapped functions, fabs has an unspecified
1967 effect on errno.
1968
5d127af9
JD
19692012-07-16 Jan Djärv <jan.h.d@swipnet.se>
1970
1971 * nsterm.m (keyDown): Interpret flags without left/right bits
1972 as the left key (Bug#11670).
1973
6a0dd1d7
DA
19742012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1975
1976 Remove empty and useless init functions.
1977 * lisp.h (init_character_once, init_fns, init_image)
1978 (init_filelock, init_sound): Remove prototype.
1979 * character.c (init_character_once): Remove.
1980 * filelock.c (init_filelock): Likewise.
1981 * fns.c (init_fns): Likewise.
1982 * image.c (init_image): Likewise.
1983 * sound.c (init_sound): Likewise.
1984 * emacs.c (main): Adjust accordingly.
1985
7a6136fd
DA
19862012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1987
1988 * gtkutil.h: Tiny cleanups.
1989 (use_old_gtk_file_dialog): Remove useless declaration.
1990 (xg_uses_old_file_dialog): Add suggested const attribute.
1991
ce811ad9
EZ
19922012-07-15 Eli Zaretskii <eliz@gnu.org>
1993
1994 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
1995 (bidi_paragraph_init): Use it to limit search forward for a strong
1996 directional character in abnormally large paragraphs full of
1997 neutral or weak characters. (Bug#11943)
1998
c9adfeaa
SF
19992012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
2000
2001 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
2002 the toolbar (Bug#9451).
2003 (xg_make_tool_item): Give the widget event box a transparent
2004 background.
2005
fff62aa9
DA
20062012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
2007
2008 Cleanup basic allocation variables and functions.
2009 * alloc.c (ignore_warnings, init_intervals, init_float)
2010 (init_cons, init_symbol, init_marker): Remove.
2011 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
2012 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
2013 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
2014 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
2015 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
2016 (staticidx, init_alloc_once, init_strings, free_ablock):
2017 Remove redundant initialization.
2018 * fns.c (init_weak_hash_tables): Remove.
2019 * lisp.h (init_weak_hash_tables): Remove prototype.
2020
9730daca
DA
20212012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
2022
2023 Use zero_vector where appropriate.
2024 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
2025 accordingly.
2026 * lisp.h (zero_vector): New declaration.
2027 * font.c (null_vector): Remove.
2028 (syms_of_font): Remove initialization and staticpro.
2029 (font_list_entities, font_find_for_lface): Change to use zero_vector.
2030 * keymap.c (Faccessible_keymaps): Likewise.
2031
2e2d2a13
LL
20322012-07-15 Leo Liu <sdl.web@gmail.com>
2033
2034 * fringe.c: Fix typo in comments.
2035
cd276f6e
LL
20362012-07-14 Leo Liu <sdl.web@gmail.com>
2037
2038 * fringe.c: Add a new bitmap exclamation-mark.
2039
5a1131d9
EZ
20402012-07-14 Eli Zaretskii <eliz@gnu.org>
2041
2042 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
2043
2044 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
2045 (HAVE_MENUS): Don't define, defined by editing config.in with
2046 msdos/sed2v2.inp.
2047 (GMALLOC_INHIBIT_VALLOC): Don't define.
2048 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
2049
22e983b7
JB
20502012-07-14 Juanma Barranquero <lekktu@gmail.com>
2051
2052 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
2053
5b3f250f
GM
20542012-07-14 Glenn Morris <rgm@gnu.org>
2055
2056 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
2057 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
2058 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
2059
33d63ff4
GM
20602012-07-13 Glenn Morris <rgm@gnu.org>
2061
5b633342
GM
2062 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
2063
33d63ff4
GM
2064 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
2065 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
2066
b55b9f85
JD
20672012-07-13 Jan Djärv <jan.h.d@swipnet.se>
2068
0dc8cf50
JD
2069 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
2070 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
2071 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
2072 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
2073 where appropriate.
2074 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
2075 as boolean expression.
2076 (x_set_window_size): Remove unused variable toolbar.
2077 (ns_get_color_default, ns_mod_to_lisp): Remove.
2078 (ns_mouse_position): Remove unused variables xchar and ychar.
2079 (ns_compute_glyph_string_overhangs): Remove unused variable face.
2080 (ns_set_vertical_scroll_bar): Remove unused variable count.
2081 (ns_delete_terminal): Remove unused variable i.
2082 (ns_term_init): Remove unused variables r, g and b.
2083 (mouseDown): Remove unused variable window.
2084 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
2085 (initFrameFromEmacs): Remove unused variable vbextra.
2086 (mouseEntered): Remove unused variables p and dpyinfo.
2087 (mouseExited): Remove unused variables p and r.
2088 (ns_define_frame_cursor, ns_clear_frame_area)
2089 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
2090 (menuDown): Assign [sender tag] to variable and cast the variable.
2091
2092 * nsterm.h (menuDown): Add id as type to argument sender.
2093 (ns_display_info_for_name): Add Lisp_Object argument.
2094 (ns_term_init): Add Lisp_Object argument.
2095 (ns_map_event_to_object): Add void argument.
2096 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
2097 prototype with arguments and only declare if __OBJC__.
2098 (nxatoms_of_nsselect): Add void argument.
2099 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
2100 (ns_alloc_autorelease_pool): Add void argument.
2101 (ns_release_autorelease_pool): Add void* argument.
2102 (ns_get_defaults_value): Add const char* argument.
2103
2104 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
2105 (initFromContents): Use SSDATA where appropriate.
2106 (ns_update_menubar): Add braces to ambigous if-else.
2107 (initWithTitle): Put () around assignment in if statement.
2108 (ns_menu_show): Remove unused variables window and keymap.
2109 (update_frame_tool_bar): Remove unused variable selected_p.
2110 (initWithContentRect): Remove unused variable this_cmd_name.
2111
2112 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
2113 appropriate.
2114 (setXBMColor): Remove unused variable len.
2115 (setPixmapData): Put () around assignment in loop statement.
2116
2117 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
2118 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
2119 where appropriate.
2120 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
2121 around assignment in loop statement.
2122 (nsfont_open): Remove unused variable i.
2123 (nsfont_open): Remove unused variable len.
2124 (nsfont_draw): Remove unused variable cs.
2125
2126 * nsfns.m (x_set_icon_name, ns_set_name_internal)
2127 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
2128 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
2129 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
2130 (Fns_font_name, Fns_perform_service)
2131 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
2132 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
2133 (ns_set_name): Remove unused variable view.
2134 (x_set_menu_bar_lines): Remove unused variable olines.
2135 (x_set_tool_bar_lines): Remove unused variable root_window.
2136 (Fns_list_colors): Put () around assignment in while statement.
2137 (Fns_perform_service): Remove unused variable len.
2138 (Fns_display_usable_bounds): Remove unused variable top.
2139 (syms_of_nsfns): Remove unused variable i.
2140
b55b9f85
JD
2141 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
2142 memcpy (Bug#11907).
2143
ed9265fc 21442012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
2145
2146 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
2147 and free it with DestroyExceptionInfo (Bug#11558).
2148
ef099b57
JB
21492012-07-13 Juanma Barranquero <lekktu@gmail.com>
2150
2151 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
2152 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
2153 Set here, not in nt/config.nt.
2154
ea814a5d
EZ
21552012-07-13 Eli Zaretskii <eliz@gnu.org>
2156
2157 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
2158 cursor overflow into the last glyph on display line when the right
2159 fringe is off. (Bug#11832)
2160
1a952767
PE
21612012-07-13 Paul Eggert <eggert@cs.ucla.edu>
2162
2163 * xdisp.c (produce_special_glyphs): Now static.
2164 * dispextern.h (produce_special_glyphs): Remove decl.
2165
983188fd
GM
21662012-07-13 Glenn Morris <rgm@gnu.org>
2167
8d7c7eed 2168 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
2169 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
2170
983188fd
GM
2171 * s/usg5-4-common.h (USG, USG5):
2172 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
2173 * s/sol2-6.h (SOLARIS2):
2174 * s/irix6-5.h (IRIX6_5):
2175 * s/hpux10-20.h (USG, USG5, HPUX):
2176 * s/gnu-linux.h (USG, GNU_LINUX):
2177 * s/freebsd.h (BSD_SYSTEM):
2178 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
2179 * s/cygwin.h (CYGWIN):
2180 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
2181 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
2182
d1e68667 21832012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
2184
2185 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 2186
6de0e799
GM
21872012-07-13 Glenn Morris <rgm@gnu.org>
2188
739ae010
GM
2189 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
2190
dbee5793
GM
2191 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
2192
6de0e799
GM
2193 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
2194 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
2195
b82da769
GM
21962012-07-12 Glenn Morris <rgm@gnu.org>
2197
4fae5a7a 2198 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
2199
2200 * process.c (init_process_emacs): Rename from init_process.
2201 The old name is also the name of a Mach system call.
2202 * lisp.h, emacs.c: Update for this name change.
2203 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
2204 longer needed.
2205
5a979817
EZ
22062012-07-12 Eli Zaretskii <eliz@gnu.org>
2207
2208 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
2209 memmove call that removes glyphs covered by the left truncation
2210 glyph. Improve commentary.
2211 (display_line): Fix display of continuation glyphs on GUI frames
2212 when the right fringe is turned off and variable-size fonts are
2213 used in the window. Move the code that appends a stretch glyph to
2214 produce_special_glyphs, so that it could be used for truncation
2215 and continuation glyphs alike.
2216 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
2217 glyph of a suitably computed width, to align the special glyphs at
2218 the window margin. Code moved from display_line. (Bug#11832)
2219
3e91a053
GM
22202012-07-12 Glenn Morris <rgm@gnu.org>
2221
ba9e4b84
GM
2222 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
2223
2224 * s/gnu-linux.h, s/hpux10-20.h:
2225 Do not unconditionally define HAVE_XRMSETDATABASE.
2226
3e91a053
GM
2227 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
2228
b300b1f4
PE
22292012-07-12 Paul Eggert <eggert@cs.ucla.edu>
2230
2231 Fix typos that broke OS X build.
2232 Reported by Randal L. Schwartz in
2233 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
2234 * nsterm.m (ns_timeout): Add missing local decl.
2235 (ns_get_color): snprintf -> sprintf, to fix typo.
2236
6e777848
GM
22372012-07-12 Glenn Morris <rgm@gnu.org>
2238
3f922c37
GM
2239 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
2240 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
2241 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
2242 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
2243
0ab7b23a
GM
2244 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
2245 Move PTY_OPEN to configure.
2246
6e777848
GM
2247 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2248 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
2249 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
2250
4a7edc24
DA
22512012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
2252
2253 Use empty_unibyte_string where applicable.
2254 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
2255 * lread.c (read1): Likewise.
2256 * xsettings.c (syms_of_xsettings): Likewise.
2257
308aab79
GM
22582012-07-12 Glenn Morris <rgm@gnu.org>
2259
42bd1719
GM
2260 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
2261 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
2262 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
2263 * s/hpux10-20.h (RUN_TIME_REMAP):
2264 * s/bsd-common.h (TABDLY): Move to configure.
2265
2266 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
2267
2268 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
2269
ea0bbd17 2270 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 2271 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
2272
2273 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 2274
308aab79
GM
2275 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
2276 * s/template.h: Move NARROWPROTO to configure.
2277
ee1cf5cf
GM
22782012-07-11 Glenn Morris <rgm@gnu.org>
2279
30fe9bf4
GM
2280 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
2281 unused since 2011-01-17 change to systty.h.
2282
ee1cf5cf
GM
2283 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
2284 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
2285 Move HAVE_PTYS and HAVE_SOCKETS to configure.
2286
63e47e07
PE
22872012-07-11 Paul Eggert <eggert@cs.ucla.edu>
2288
2289 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
2290
c43fb4c3
GM
22912012-07-11 Glenn Morris <rgm@gnu.org>
2292
2293 * s/darwin.h, s/gnu-linux.h, s/template.h:
2294 Move INTERRUPT_INPUT to configure.
2295
e8df9267
DA
22962012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
2297
2298 Minor adjustments to interning code.
2299 * lisp.h (intern, intern_c_string): Redefine as static inline
2300 wrappers for intern_1 and intern_c_string_1, respectively.
2301 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
2302 * lread.c (intern_1, intern_c_string_1, oblookup):
2303 Simplify Vobarray checking.
e8df9267
DA
2304 * font.c (font_intern_prop): Likewise. Adjust comment.
2305 * w32font.c (intern_font_name): Likewise.
2306
34348bd4
AS
23072012-07-11 Andreas Schwab <schwab@linux-m68k.org>
2308
d96a1e0c
AS
2309 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
2310
34348bd4
AS
2311 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
2312 of Fcar/Fcdr if possible.
2313 * font.c (check_otf_features): Likewise.
2314 * fontset.c (Fnew_fontset): Likewise.
2315 * gnutls.c (Fgnutls_boot): Likewise.
2316 * minibuf.c (read_minibuf): Likewise.
2317 * msdos.c (IT_set_frame_parameters): Likewise.
2318 * xmenu.c (Fx_popup_dialog): Likewise.
2319 * w32menu.c (Fx_popup_dialog): Likewise.
2320
c8add24e
GM
23212012-07-11 Glenn Morris <rgm@gnu.org>
2322
4b575b3c
GM
2323 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
2324 since nothing has defined it on these platforms.
2325
09f4e3b0
GM
2326 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
2327 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
2328
172bedef
GM
2329 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2330 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
2331 Move CLASH_DETECTION to configure.
2332
249685df
GM
2333 * s/gnu.h: Remove file, which is now empty.
2334
c8add24e
GM
2335 * s/gnu.h, s/gnu-linux.h:
2336 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
2337
b41253a3
JW
23382012-07-11 John Wiegley <johnw@newartisans.com>
2339
2340 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
2341 function attribute, so we only use it if it exists in the
2342 compiler.
2343
d923b542
DA
23442012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
2345
2346 Avoid call to strlen in fast_c_string_match_ignore_case.
2347 * search.c (fast_c_string_match_ignore_case): Change to use
2348 length argument. Adjust users accordingly.
2349 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
2350
5ebbef1d
PE
23512012-07-11 Paul Eggert <eggert@cs.ucla.edu>
2352
bb352260
PE
2353 Assume mkdir, rmdir.
2354 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
2355 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
2356
57054ddd
PE
2357 Assume rename.
2358 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
2359
b747d3f7
PE
2360 Assume perror.
2361 * s/hpux10-20.h (HAVE_PERROR): Remove.
2362 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
2363 Remove dummy definition, as this problem was obsolete long ago.
2364
5ebbef1d
PE
2365 Assume strerror.
2366 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
2367
984e7f30
DA
23682012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
2369
2370 Avoid calls to strlen in font processing functions.
2371 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
2372 (font_open_by_name): Change to use length argument.
2373 Adjust users accordingly.
d923b542
DA
2374 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
2375 Adjust prototypes.
2376 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
2377 Change to return ptrdiff_t.
984e7f30
DA
2378 (xfont_list_pattern, xfont_match): Use length returned by
2379 xfont_decode_coding_xlfd.
2380 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
2381
20e94fdd
GM
23822012-07-11 Glenn Morris <rgm@gnu.org>
2383
9d596af3
GM
2384 * s/darwin.h, s/freebsd.h, s/netbsd.h:
2385 Move DONT_REOPEN_PTY to configure.
2386
20e94fdd
GM
2387 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
2388 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
2389
e99a530f
PE
23902012-07-10 Paul Eggert <eggert@cs.ucla.edu>
2391
22ffb973
PE
2392 Remove "#define unix" that is no longer needed (Bug#11905).
2393 * s/aix4-2.h (unix): Remove; no longer needed.
2394
e9a9ae03
PE
2395 EMACS_TIME simplification (Bug#11875).
2396 This replaces macros (which typically do not work in GDB)
2397 with functions, typedefs and enums, making the code easier to debug.
2398 The functional style also makes code easier to read and maintain.
2399 * systime.h: Include <sys/time.h> on all hosts, not just if
2400 WINDOWSNT, since 'struct timeval' is needed in general.
2401 (EMACS_TIME): Now a typedef, not a macro.
2402 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
2403 not macros.
2404 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
2405 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
2406 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
2407 (EMACS_TIME_LE): Now functions, not macros.
2408 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
2409 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
2410 which are not functions. All uses rewritten to use:
2411 (make_emacs_time): New function.
2412 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
2413 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
2414 not functions. All uses rewritten to use the following, respectively:
2415 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
2416 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 2417 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
2418 * fileio.c (Fcopy_file):
2419 * xterm.c (XTflash): Get the current time closer to when it's used.
2420 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
2421
ffacb126
PE
2422 * bytecode.c (targets): Suppress -Woverride-init warnings.
2423
e99a530f
PE
2424 Simplify by avoiding confusing use of strncpy etc.
2425 * doc.c (Fsnarf_documentation):
2426 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
2427 * frame.c (Fmake_terminal_frame):
2428 * gtkutil.c (get_utf8_string):
2429 * lread.c (openp):
2430 * nsmenu.m (ns_update_menubar):
2431 * regex.c (regerror):
2432 Prefer memcpy to strncpy and strncat when either will do.
2433 * fileio.c (Fsubstitute_in_file_name):
2434 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
2435 (menu_separator_name_p):
2436 * nsmenu.m (ns_update_menubar):
2437 Prefer memcmp to strncmp when either will do.
2438 * nsterm.m: Include <ftoastr.h>.
2439 (ns_get_color):
2440 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
2441 Prefer snprintf to strncpy.
2442 * nsterm.m (ns_term_init):
2443 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
2444 * nsterm.m (ns_term_init):
2445 Avoid the need for strncpy, by using build_string or
2446 make_unibyte_string directly. Use dtoastr, not snprintf.
2447 * process.c (Fmake_network_process): Diagnose service names that
2448 are too long, rather than silently truncating them or creating
2449 non-null-terminated names.
2450 (Fnetwork_interface_info): Likewise, for interface names.
2451 * sysdep.c (system_process_attributes) [GNU_LINUX]:
2452 Prefer sprintf to strncat.
2453 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
2454 Prefer vsnprintf to vsprintf + strncpy.
2455
c59592b3
GM
24562012-07-10 Glenn Morris <rgm@gnu.org>
2457
2458 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
2459 Clarify fallback case.
2460
7d7bbefd
DA
24612012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2462
2463 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
2464 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
2465 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 2466 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
2467 where argument type is known to be a Lisp_Cons.
2468
3a4c8000
TT
24692012-07-10 Tom Tromey <tromey@redhat.com>
2470
2471 * bytecode.c (BYTE_CODE_THREADED): New macro.
2472 (BYTE_CODES): New macro. Replaces all old byte-code defines.
2473 (enum byte_code_op): New type.
2474 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
2475 (exec_byte_code): Use them. Use token threading when applicable.
2476
2a0213a6
DA
24772012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2478
2479 Optimize pure C strings initialization.
2480 * lisp.h (make_pure_string): Fix prototype.
2481 (build_pure_c_string): New function, defined as static inline. This
2482 provides a better opportunity to optimize away calls to strlen when
2483 the function is called with compile-time constant argument.
2484 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
2485 argument, adjust users accordingly. Use build_pure_c_string where
2486 appropriate.
2487 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
2488 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
2489 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
2490
cb1caeaf
DA
24912012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2492
2493 Avoid calls to strlen in miscellaneous functions.
2494 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
2495 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
2496 * lread.c (openp): Likewise.
2497
c293e30c
DA
24982012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2499
2500 Avoid calls to strlen in path processing functions.
2501 * fileio.c (file_name_as_directory): Add comment. Change to add
2502 srclen argument and return the length of result. Adjust users
2503 accordingly.
2504 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
2505 swap 1st and 2nd arguments to obey the common convention.
2506 Adjust users accordingly.
c293e30c
DA
2507 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
2508
9e059e3f
GM
25092012-07-10 Glenn Morris <rgm@gnu.org>
2510
d02eb359
GM
2511 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
2512 Move PENDING_OUTPUT_COUNT definition to configure.
2513
882cf227
GM
2514 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
2515 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
2516 * s/gnu.h (DATA_START): Move definitions to configure.
2517
af6e839f
GM
2518 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
2519 We include usg5-4-common.h, which defines them both.
2520
40289a12
GM
2521 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
2522 O_RDONLY already includes it).
2523
9e059e3f
GM
2524 Stop ns builds setting the EMACSLOADPATH environment variable.
2525 * nsterm.m (ns_load_path): Rename from ns_init_paths.
2526 Now it does not set EMACSLOADPATH, just returns the load-path string.
2527 * nsterm.h: Update accordingly.
2528 * lread.c [HAVE_NS]: Include nsterm.h.
2529 (init_lread) [HAVE_NS]: Use ns_load_path.
2530 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
2531
7c4e8ec0
GM
25322012-07-09 Glenn Morris <rgm@gnu.org>
2533
d4f600ff
GM
2534 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
2535 since the included bsd-common.h does so.
2536
cbb31951
GM
2537 Stop ns builds setting the EMACSPATH environment variable.
2538 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
2539 (ns_init_paths): Do not set EMACSPATH.
2540 * nsterm.h (ns_exec_path): Add it.
2541 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
2542 Use ns_exec_path.
2543
7c4e8ec0
GM
2544 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
2545
26bccfae
PE
25462012-07-09 Paul Eggert <eggert@cs.ucla.edu>
2547
a0bee46f
PE
2548 * process.c (wait_reading_process_output): 'waitchannels' was unset
2549 when read_kbd || !NILP (wait_for_cell); fix this.
2550
5994c183
PE
2551 Add GCC-style 'const' attribute to functions that can use it.
2552 * character.h (char_resolve_modifier_mask):
2553 * keyboard.h (make_ctrl_char):
2554 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
2555 (init_character_once, next_almost_prime, init_fns, init_image)
2556 (flush_pending_output, init_sound):
2557 * mem-limits.h (start_of_data):
2558 * menu.h (finish_menu_items):
2559 Add ATTRIBUTE_CONST.
2560 * emacs.c (DEFINE_DUMMY_FUNCTION):
2561 Declare the dummy function with ATTRIBUTE_CONST.
2562 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
2563 Add decls with ATTRIBUTE_CONST.
2564
26bccfae
PE
2565 Minor improvements to make_formatted_string.
2566 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
2567 where int is good enough, as vsprintf returns an int.
2568 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
2569
a8290ec3
DA
25702012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2571
2572 Use make_formatted_string to avoid double length calculation.
2573 * lisp.h (make_formatted_string): New prototype.
2574 * alloc.c (make_formatted_string): New function.
2575 * buffer.c (Fgenerate_new_buffer_name): Use it.
2576 * dbus.c (syms_of_dbusbind): Likewise.
2577 * editfns.c (Fcurrent_time_zone): Likewise.
2578 * filelock.c (get_boot_time): Likewise.
2579 * frame.c (make_terminal_frame, set_term_frame_name)
2580 (x_report_frame_params): Likewise.
2581 * image.c (gs_load): Likewise.
2582 * minibuf.c (get_minibuffer): Likewise.
2583 * msdos.c (dos_set_window_size): Likewise.
2584 * process.c (make_process): Likewise.
2585 * xdisp.c (ensure_echo_area_buffers): Likewise.
2586 * xsettings.c (apply_xft_settings): Likewise.
2587
d01ba2f1
GM
25882012-07-09 Glenn Morris <rgm@gnu.org>
2589
2590 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
2591 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
2592 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
2593 * nsterm.h (ns_etc_directory): Add it.
2594 * callproc.c [HAVE_NS]: Include nsterm.h.
2595 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
2596
f1f924b6
DA
25972012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2598
2599 Move marker debugging code under MARKER_DEBUG.
2600 * marker.c (MARKER_DEBUG): Move marker debugging code under
2601 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
2602 for bootstrap with --enable-checking (~3x slowdown reported
2603 by Juanma Barranquero <lekktu@gmail.com>).
2604 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
2605
ab531b66
PE
26062012-07-08 Paul Eggert <eggert@cs.ucla.edu>
2607
2608 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
2609 See <http://bugs.gnu.org/11825#29>.
2610
c4b3bc8a
EZ
26112012-07-08 Eli Zaretskii <eliz@gnu.org>
2612
2613 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
2614 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
2615 (display_line): Add commentary about displaying truncation glyphs
2616 on GUI frames.
2617 (produce_special_glyphs): Move here from term.c.
2618
2619 * term.c (produce_special_glyphs): Move to xdisp.c.
2620
2621 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
2622 section.
c4b3bc8a 2623
b676b881
AS
26242012-07-07 Andreas Schwab <schwab@linux-m68k.org>
2625
f17c5273
AS
2626 * xdisp.c (display_line): Avoid warning about implicit declaration
2627 of FRAME_FONT.
2628
298819b9
AS
2629 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
2630
b676b881
AS
2631 * lisp.h: Remove empty conditional.
2632
6045c4fd
PE
26332012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2634
b3350bf9
PE
2635 * lread.c (load_path_check): Now static.
2636
6045c4fd
PE
2637 Fix some minor --with-ns problems found by static checking.
2638 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
2639 (x_set_font) [!HAVE_X_WINDOWS]:
2640 * image.c (xpm_load_image) [HAVE_NS]:
2641 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
2642 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
2643 Remove unused local.
2644 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
2645 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
2646 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
2647 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
2648 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
2649 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
2650 Fix pointer signedness problem.
2651 * xfaces.c (FRAME_X_FONT_TABLE):
2652 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
2653
929e7845
GM
26542012-07-07 Glenn Morris <rgm@gnu.org>
2655
2656 * lread.c (load_path_check): New function, split from init_lread.
2657 (init_lread): Reorganize. Motivation:
2658 If EMACSLOADPATH is set, check/warn about that rather than the
2659 defaults, which we are not going to use. Hence we can remove
2660 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
2661 Don't warn if site-lisp directories are missing.
2662 If not installed, start from a blank load-path, since
2663 PATH_LOADSEARCH refers to the eventual installation directories.
2664
58dd0aa4
EZ
26652012-07-07 Eli Zaretskii <eliz@gnu.org>
2666
2667 Support truncation and continuation glyphs on GUI frames, when
2668 fringes are disabled. (Bug#11832)
2669 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
2670 continuation glyphs even if on GUI frames.
2671 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
2672 or both, are absent.
2673 (start_display, move_it_in_display_line_to): Handle the case of a
2674 GUI frame without a fringe to display continuation or truncation
2675 glyphs.
2676 (insert_left_trunc_glyphs): Support GUI frames: make sure
2677 truncation glyphs overwrite enough glyphs from the current line to
2678 have sufficient space in pixels.
2679 (display_line): Support truncation and continuation glyphs on GUI
2680 frames. If some spare pixels are left on the line after inserting
2681 the truncation glyphs, fill that space with a stretch glyph of a
2682 suitably computed width.
2683
2684 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
2685 produce_glyphs, to support GUI sessions.
2686
31571fd7
PE
26872012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2688
5a16b9bc
PE
2689 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
2690
f3047c75
PE
2691 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
2692
31571fd7
PE
2693 Do not require float-time's arg to fit in time_t (Bug#11825).
2694 This works better on hosts where time_t is unsigned, and where
2695 float-time is applied to the (negative) difference between two times.
2696 * editfns.c (decode_time_components): Last arg is now double *,
2697 not int *, and means to store all the result as a double, without
2698 worrying about whether the seconds part fits in time_t.
2699 All callers changed.
2700 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
2701 All callers changed.
2702 (Ffloat_time): Do not fail merely because the specified time falls
2703 outside of time_t range.
2704
4516fbef
GM
27052012-07-07 Glenn Morris <rgm@gnu.org>
2706
2707 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
2708 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
2709 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
2710
07adc2c6
JB
27112012-07-07 Juanma Barranquero <lekktu@gmail.com>
2712
2713 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
2714 Update dependencies.
2715
2716 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
2717
fd573f31
PE
27182012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2719
fee5959d
PE
2720 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
2721 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
2722 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
2723 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
2724 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
2725 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
2726
fd573f31
PE
2727 * xfont.c (compare_font_names): Redo to omit the need for casts.
2728
ddadbc0e
AS
27292012-07-06 Andreas Schwab <schwab@linux-m68k.org>
2730
fca8d6b6
AS
2731 * xfns.c (Fx_change_window_property): Doc fix.
2732 * w32fns.c (Fx_change_window_property): Doc fix.
2733
ddadbc0e
AS
2734 * w32fns.c (Fx_window_property): Accept the same arguments as the
2735 X Windows version. Doc fix.
2736 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
2737
ed9265fc 27382012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
2739 Eli Zaretskii <eliz@gnu.org>
2740
2741 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
2742 Windows-specific code from nt/config.nt moved here.
2743 Obsolete settings removed.
2744
216ee680
PE
27452012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2746
2747 * process.c: Avoid unnecessary calls to gettime.
2748 (wait_reading_process_output): Don't get the time of day
2749 when gobbling data immediately and not waiting, as there's no need
2750 for it in that case. This removes a FIXME.
2751
bdd091e4
JD
27522012-07-06 Jan Djärv <jan.h.d@swipnet.se>
2753
2754 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
2755 is defined (Bug#11768).
2756
9d44f8ce
DA
27572012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2758
2759 Fix marker debugging code.
2760 * marker.c (byte_char_debug_check): Do not perform the check
2761 if buffer is not multibyte.
090bd7cb
JB
2762 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2763 Call byte_char_debug_check with correct arguments.
9d44f8ce 2764
90fc4786
DA
27652012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2766
2767 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
2768 * marker.c (byte_char_debug_check, count_markers):
2769 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
2770 (byte_debug_flag): Remove.
2771 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2772 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
2773
7b7ae965
DA
27742012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2775
4e57b342
DA
2776 Avoid code repetition in marker-related functions.
2777 * marker.c (attach_marker): New function.
2778 (Fset_marker, set_marker_restricted, set_marker_both)
2779 (set_marker_restricted_both): Use it.
2780 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
2781 Consistently rename charno to charpos.
2782 (marker_position): Add eassert.
2783 (marker_byte_position): Convert to eassert.
2784
27852012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2786
2787 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 2788 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 2789 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 2790
657924ff
DA
27912012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2792
2793 Introduce fast path for the widely used marker operation.
2794 * alloc.c (build_marker): New function.
2795 * lisp.h (build_marker): New prototype.
2796 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
2797 * composite.c (autocmp_chars): Likewise.
2798 * editfns.c (buildmark): Remove.
2799 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
2800 (save_restriction_save): Use build_marker.
2801 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
2802 * window.c (save_window_save): Likewise.
2803
041a49a6
DA
28042012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2805
2806 Do not use Fdelete_overlay in delete_all_overlays
2807 to avoid redundant calls to unchain_overlay.
2808 * buffer.c (drop_overlay): New function.
2809 (delete_all_overlays, Fdelete_overlay): Use it.
2810 * minibuf.c (get_minibuffer): Fix comment.
2811
7dca65a4
PE
28122012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2813
2814 Port to OpenBSD 5.1 amd64.
2815 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
2816 This is needed for OpenBSD, and should be harmless on all BSD systems.
2817 Also, include <sys/sysctl.h>, as it should be available on all
2818 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
2819 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
2820 use p_pid member, not kp_proc.pid.
2821
8eb876e2
GM
28222012-07-06 Glenn Morris <rgm@gnu.org>
2823
2824 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
2825
38182d90
PE
28262012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2827
2828 More xmalloc and related cleanup.
2829 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
2830 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
2831 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
2832 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
2833 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
2834 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
2835 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
2836 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
2837 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
2838 * xterm.c:
2839 Omit needless casts involving void * pointers and allocation.
2840 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
2841 as the former is more robust if P's type is changed.
2842 Prefer xzalloc to xmalloc + memset 0.
2843 Simplify malloc-or-realloc to realloc.
2844 Don't worry about xmalloc returning a null pointer.
2845 Prefer xstrdup to xmalloc + strcpy.
2846 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
2847 growing it.
2848 * keyboard.c (apply_modifiers_uncached): Prefer local array to
2849 alloca of a constant.
2850
6dd5a677
EZ
28512012-07-05 Eli Zaretskii <eliz@gnu.org>
2852
2853 * xdisp.c (display_line): Fix horizontal pixel coordinates when
2854 hscroll is larger than the line width. Fixes long and futile
2855 looping inside extend_face_to_end_of_line (on a TTY) producing
2856 glyphs that are not needed and thrown away.
2857
6b312f0f
DA
28582012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2859
2860 * marker.c (set_marker_restricted_both): Simplify by using
2861 clip_to_bounds.
2862
f520ef9b
PE
28632012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2864
2865 * editfns.c (region_limit): Simplify by using clip_to_bounds.
2866
383b7c95
JD
28672012-07-05 Jan Djärv <jan.h.d@swipnet.se>
2868
2869 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
2870 not defined (Bug#11768).
2871 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
2872 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
2873 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
2874 followed by gtk_box_set_homogeneous (Bug#11768).
2875 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
2876 (update_theme_scrollbar_width, xg_create_scroll_bar):
2877 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
2878 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
2879 (is_box_type): New function (Bug#11768).
2880 (xg_tool_item_stale_p): Call is_box_type.
5293d758 2881 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
2882 with default display (Bug#11768).
2883
d6e7bf45
EZ
28842012-07-05 Eli Zaretskii <eliz@gnu.org>
2885
2886 * xdisp.c (window_hscroll_limited): New function.
2887 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
2888 coordinates when window's hscroll is set to insanely large
2889 values. (Bug#11857)
2890
431391ec
JB
28912012-07-05 Juanma Barranquero <lekktu@gmail.com>
2892
2893 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
2894 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
2895
23f86fce
DA
28962012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2897
2898 Cleanup xmalloc.
2899 * lisp.h (xzalloc): New prototype. Omit needless casts.
2900 * alloc.c (xzalloc): New function. Omit needless casts.
2901 * charset.c: Omit needless casts. Convert all calls to
2902 xmalloc with following memset to xzalloc.
2903 * dispnew.c: Likewise.
2904 * fringe.c: Likewise.
2905 * image.c: Likewise.
2906 * sound.c: Likewise.
2907 * term.c: Likewise.
2908 * w32fns.c: Likewise.
2909 * w32font.c: Likewise.
2910 * w32term.c: Likewise.
2911 * xfaces.c: Likewise.
2912 * xfns.c: Likewise.
2913 * xterm.c: Likewise.
2914 * atimer.c: Omit needless casts.
2915 * buffer.c: Likewise.
2916 * callproc.c: Likewise.
2917 * ccl.c: Likewise.
2918 * coding.c: Likewise.
2919 * composite.c: Likewise.
2920 * doc.c: Likewise.
2921 * doprnt.c: Likewise.
2922 * editfns.c: Likewise.
2923 * emacs.c: Likewise.
2924 * eval.c: Likewise.
2925 * filelock.c: Likewise.
2926 * fns.c: Likewise.
2927 * gtkutil.c: Likewise.
2928 * keyboard.c: Likewise.
2929 * lisp.h: Likewise.
2930 * lread.c: Likewise.
2931 * minibuf.c: Likewise.
2932 * msdos.c: Likewise.
2933 * print.c: Likewise.
2934 * process.c: Likewise.
2935 * region-cache.c: Likewise.
2936 * search.c: Likewise.
2937 * sysdep.c: Likewise.
2938 * termcap.c: Likewise.
2939 * terminal.c: Likewise.
2940 * tparam.c: Likewise.
2941 * w16select.c: Likewise.
2942 * w32.c: Likewise.
2943 * w32reg.c: Likewise.
2944 * w32select.c: Likewise.
2945 * w32uniscribe.c: Likewise.
2946 * widget.c: Likewise.
2947 * xdisp.c: Likewise.
2948 * xmenu.c: Likewise.
2949 * xrdb.c: Likewise.
2950 * xselect.c: Likewise.
2951
0497dc44
PE
29522012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2953
2954 * fileio.c (time_error_value): Check the right error number.
2955 Problem reported by Troels Nielsen in
2956 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
2957
356e7178
PE
29582012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2959
4e71fd89
PE
2960 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
2961 This should be fixed in a better way; see Eli Zaretskii in
2962 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
2963 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
2964
f0941253
PE
2965 * fileio.c (time_error_value): Rename from special_mtime.
2966 The old name's problems were noted by Eli Zaretskii in
2967 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
2968
065c9eb4
PE
2969 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
2970 This variable's comment says Emacs needs at least one GDB-visible
2971 symbol of type enum pvec_type, to work around GDB problems.
2972 The symbol's value doesn't matter.
2973
356e7178
PE
2974 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
2975 that causes compilation to fail on pre-C99 compilers.
2976
ed9265fc 29772012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
2978
2979 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
2980 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
2981
3884d954
DA
29822012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2983
d209e2fb 2984 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
2985 headers for buffer_defaults and buffer_local_symbols.
2986 Reported by Juanma Barranquero <lekktu@gmail.com>.
2987
ee28be33
SM
29882012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2989
2990 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
2991 * lisp.h (enum pvec_type): Use fewer bits.
2992 (PSEUDOVECTOR_SIZE_BITS): New constant.
2993 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
2994 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
2995 change in pvec_type.
2996 (PSEUDOVECTOR_TYPEP): New macro.
2997 (TYPED_PSEUDOVECTORP): Use it.
2998 * fns.c (internal_equal): Adapt code to extract pvectype.
2999 * emacs.c (gdb_pvec_type): Update type.
3000 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
3001 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
3002 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
3003 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
3004 (sweep_vectors): Use it. Use local var `total_bytes' instead of
3005 abusing vector->header.next.nbytes.
3006 (live_vector_p): Use PVEC_TYPE.
3007 (mark_object): Adapt code to extract pvectype. Use switch.
3008
c7f2cd7f
PE
30092012-07-04 Paul Eggert <eggert@cs.ucla.edu>
3010
3011 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
3012 Tighten new eassert a bit.
3013
8ce70ed2
DA
30142012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
3015
3016 Fix compilation with --enable-gcc-warnings and -O1
3017 optimization level.
3018 * doprnt.c (doprnt): Change type of tem to int, initialize
3019 to avoid compiler warning. Add eassert.
3020 * search.c (simple_search): Initialize match_byte to avoid
3021 compiler warning. Add eassert.
3022
dea7f1e5
PE
30232012-07-04 Paul Eggert <eggert@cs.ucla.edu>
3024
24a212eb
PE
3025 Avoid weird behavior with large horizontal scrolls.
3026 Without this change, for example, large hscroll values would
3027 mess up Emacs's display on Fedora 15 x86, presumably due to
3028 overflows in int calculations in the display code.
3029 Also, if buffers had long lines, Emacs would freeze.
3030 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
3031 (set_window_hscroll): New function, containing the old guts of
3032 Fset_window_hscroll. Return the clipped value.
3033 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
3034 This avoids the need to check against PTRDIFF_MAX.
3035
dea7f1e5
PE
3036 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
3037
76046526
DA
30382012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
3039
3040 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
3041
39adff0d
PE
30422012-07-04 Paul Eggert <eggert@cs.ucla.edu>
3043
63807d47
PE
3044 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
3045 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
3046 since GCC 4.4.6 issues a bogus warning for them.
3047
39adff0d
PE
3048 Fix bugs in file timestamp newness comparisons.
3049 * fileio.c (Ffile_newer_than_file_p):
3050 * lread.c (Fload): Use full timestamp resolution of files,
3051 not just the 1-second resolution, so that files that are only
3052 slightly newer still count as newer.
3053 * fileio.c (Ffile_newer_than_file_p): Don't assume file
3054 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
3055
dbeed9a6
PE
30562012-07-03 Paul Eggert <eggert@cs.ucla.edu>
3057
3058 * fileio.c: Improve handling of file time marker. (Bug#11852)
3059 (special_mtime): New function.
3060 (Finsert_file_contents, Fverify_visited_file_modtime):
3061 Use it to set special mtime values consistently.
3062
636334d6
AS
30632012-07-03 Andreas Schwab <schwab@linux-m68k.org>
3064
3065 * fileio.c (Finsert_file_contents): Properly handle st_mtime
3066 marker for non-existing file. (Bug#11852)
3067
e2017fe2
GM
30682012-07-03 Glenn Morris <rgm@gnu.org>
3069
3070 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
3071 and did not make it into globals.h).
3072
404dbd37
TT
30732012-07-03 Tom Tromey <tromey@redhat.com>
3074
3075 * window.c (Fset_window_margins, Fset_window_fringes)
3076 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
3077 * textprop.c (Fprevious_property_change): No longer static.
3078 * syntax.c (Fsyntax_table_p): No longer static.
3079 * process.c (Fget_process, Fprocess_datagram_address): No longer
3080 static.
3081 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
3082 * keyboard.c (Fcommand_execute): No longer static.
3083 Remove EXFUN.
3084 * insdel.c (Fcombine_after_change_execute): No longer static.
3085 * image.c (Finit_image_library): No longer static.
3086 * fileio.c (Fmake_symbolic_link): No longer static.
3087 * eval.c (Ffetch_bytecode): No longer static.
3088 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
3089 * doc.c (Fdocumentation_property, Fsnarf_documentation):
3090 No longer static.
404dbd37
TT
3091 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
3092 static.
3093 * dired.c (Ffile_attributes): No longer static.
3094 * composite.c (Fcomposition_get_gstring): No longer static.
3095 * callproc.c (Fgetenv_internal): No longer static.
3096
3097 * ccl.h: Remove EXFUNs.
3098 * buffer.h: Remove EXFUNs.
3099 * dispextern.h: Remove EXFUNs.
3100 * intervals.h: Remove EXFUNs.
3101 * fontset.h: Remove EXFUN.
3102 * font.h: Remove EXFUNs.
3103 * dosfns.c (system_process_attributes): Remove EXFUN.
3104 * keymap.h: Remove EXFUNs.
3105 * lisp.h: Remove EXFUNs.
3106 * w32term.h: Remove EXFUNs.
3107 * window.h: Remove EXFUNs.
3108 * xsettings.h: Remove EXFUN.
3109 * xterm.h: Remove EXFUN.
3110
8e4fd1e1
GM
31112012-07-03 Glenn Morris <rgm@gnu.org>
3112
3113 * lisp.h (Frandom): Make it visible to C.
3114 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
3115 buffer for invisible buffers. (Bug#1229)
3116
ca95b3eb
DA
31172012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
3118
3119 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
3120 values which aren't power of 2.
14ae4239
BT
3121 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
3122 Verify it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
3123 accordingly.
3124
7555c33f
SM
31252012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
3126
3127 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
3128
3129 * alloc.c (mark_object): Revert part of last patch to use `switch'.
3130
d12e8f5a
DA
31312012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
3132
3133 * alloc.c (allocate_vector_block): Remove redundant
3134 calls to mallopt if DOUG_LEA_MALLOC is defined.
3135 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
3136 avoid calls to mallopt if zero_vector is returned.
3137
296094c3
DA
31382012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
3139
3140 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
3141 is enabled, avoid dereferencing NULL current_sblock if
3142 running undumped.
3143
36429c89
DA
31442012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
3145
3146 Cleanup basic buffer management.
3147 * buffer.h (struct buffer): Change layout to use generic vector
3148 marking code. Fix some comments. Change type of 'clip_changed'
3149 to bitfield. Remove unused #ifndef old.
3150 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
3151 (GET_OVERLAYS_AT): Fix indentation.
3152 (for_each_per_buffer_object_at): New macro.
3153 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
3154 (Fbuffer_local_variables): Use it.
3155 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
3156 * alloc.c (allocate_buffer): Adjust to match new layout of
3157 struct buffer. Fix comment.
3158 (mark_overlay): New function.
3159 (mark_buffer): Use it. Use mark_vectorlike to mark normal
3160 Lisp area of struct buffer.
3161 (mark_object): Use it. Adjust marking of misc objects
3162 and related comments.
3163
3b3e4cac
PE
31642012-07-02 Paul Eggert <eggert@cs.ucla.edu>
3165
3166 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
3167 wrapper that is not needed because the wrapped code is a no-op (zero
3168 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
3169 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
3170
cf5c0175
DA
31712012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
3172
3173 * alloc.c (mark_buffer): Simplify. Remove prototype.
3174 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 3175 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
3176 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
3177 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 3178
ca26824c
GM
31792012-06-30 Glenn Morris <rgm@gnu.org>
3180
2e4c5312
GM
3181 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
3182
ca26824c
GM
3183 * epaths.in (PATH_SITELOADSEARCH): New.
3184 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
3185 This is rather than relying on --enable-locallisppath elements
3186 having "site-lisp" in their names. (Bug#10208#25, 11658)
3187
0d23c240
EZ
31882012-06-30 Eli Zaretskii <eliz@gnu.org>
3189
c9240d7a
EZ
3190 * w32proc.c (sys_select): Accept and ignore one more argument.
3191
3192 * w32.c (emacs_gnutls_pull): Call select with one more argument.
3193
0d23c240 3194 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 3195 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
3196
3197 * sysdep.c: Don't include dos.h and dosfns.h.
3198
3199 * process.c (sys_select):
3200 * msdos.c (sys_select): Accept one more argument and ignore it.
3201
3202 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
3203 adapt data types and code to that.
3204
3205 * dosfns.c:
3206 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
3207 which clashes with the gnulib function of the same name.
3208
af5a5a98
AS
32092012-06-30 Andreas Schwab <schwab@linux-m68k.org>
3210
c5e4379c
AS
3211 * font.c (font_style_to_value, font_style_symbolic)
3212 (font_prop_validate_style): Add type checks for values in
3213 font_style_table.
3214
af5a5a98
AS
3215 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
3216 argument.
3217 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
3218 uses.
3219
8d38f461
EZ
32202012-06-29 Eli Zaretskii <eliz@gnu.org>
3221
2e5a6631
EZ
3222 * xdisp.c (try_window_id): Undo last change.
3223
8d38f461
EZ
3224 * w32.c (getwd): Adjust commentary about startup_dir.
3225 (init_environment): Always call sys_access, even in non-MSVC
3226 builds. Don't chdir to the directory of the Emacs executable.
3227 This undoes code from 1997 which was justified by the need to
3228 "avoid conflicts when removing and renaming directories". But its
3229 downside was that every relative file name was being interpreted
3230 relative to the directory of the Emacs executable, which can never
3231 be TRT. In particular, it broke sys_access when called with
3232 relative file names.
3233 (sys_access): Map GetLastError to errno.
3234
2af3565e
DA
32352012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
3236
3237 * window.h (struct window): Change type of 'fringes_outside_margins'
3238 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 3239 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
3240 Adjust comment.
3241 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
3242 to ptrdiff_t.
3243
c8d3a25c 32442012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 3245
c8d3a25c
GM
3246 * gnutls.c (emacs_gnutls_handshake):
3247 Add QUIT to make the loop interruptible.
57570cd3 3248
c8d3a25c 32492012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 3250
c8d3a25c
GM
3251 * charset.c (init_charset): Make lack of etc/charsets fatal.
3252
3e984ee8
DA
32532012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
3254
3255 * editfns.c (region_limit): Fix type mismatch.
3256
ef884f23
DA
32572012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
3258
3259 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
3260 undefined. Convert from xassert to eassert.
3261 * nsmenu.m: Convert from xassert to eassert.
3262 * nsterm.m: Likewise.
3263
7d7e0027
SM
32642012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
3265
3266 * editfns.c (region_limit): Clip to narrowing (bug#11770).
3267
aa754e6a
PE
32682012-06-28 Paul Eggert <eggert@cs.ucla.edu>
3269
3270 Avoid integer overflow on scroll-left and scroll-right.
3271 * window.c (HSCROLL_MAX): New macro.
3272 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
3273 overflow when requested scroll falls outside ptrdiff_t range.
3274
80b00b08
DA
32752012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
3276
3277 * window.h (struct window): Change type of 'hscroll',
3278 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
3279 'last_modified' and 'last_overlay_modified' to EMACS_INT.
3280 Adjust users accordingly.
3281 * xdisp.c (try_cursor_movement): Replace type check with eassert.
3282 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
3283 from EMACS_INT to ptrdiff_t.
3284 (make_window): Omit redundant initialization.
3285
62b2bcf6
JB
32862012-06-28 Juanma Barranquero <lekktu@gmail.com>
3287
3288 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
3289
45942c7d
DA
32902012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
3291
3292 * window.h (struct window): Change type of 'use_time' and
3293 'sequence_number' from Lisp_Object to int.
3294 * frame.c (make_frame): Adjust users accordingly.
3295 * print.c (print_object): Likewise.
3296 * window.c (select_window, Fwindow_use_time, make_parent_window)
3297 (make_window): Likewise.
3298
e509cfa6
DA
32992012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
3300
3301 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
3302 enabled with --enable-checking=[all,glyphs] configure option.
3303 Fix GLYPH_DEBUG usage assuming that it may be undefined,
3304 adjust comments accordingly.
3305 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
3306 undefined, adjust comments accordingly.
3307 * image.c: Likewise.
3308 * scroll.c: Likewise.
3309 * w32fns.c: Likewise.
3310 * w32term.c: Likewise.
3311 * xdisp.c: Likewise.
3312 * xfaces.c: Likewise.
3313 * xfns.c: Likewise.
3314 * xterm.c: Likewise.
3315
a54e2c05
DA
33162012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
3317
3318 Generalize run-time debugging checks.
3319 * dispextern.h (XASSERTS): Remove.
3320 * fontset.c (xassert): Remove.
3321 Convert from xassert to eassert.
3322 * alloc.c: Convert from xassert to eassert.
3323 * bidi.c: Likewise.
3324 * dispnew.c: Likewise.
3325 * fns.c: Likewise.
3326 * fringe.c: Likewise.
3327 * ftfont.c: Likewise.
3328 * gtkutil.c: Likewise.
3329 * image.c: Likewise.
3330 * keyboard.c: Likewise.
3331 * menu.c: Likewise.
3332 * process.c: Likewise.
3333 * scroll.c: Likewise.
3334 * sound.c: Likewise.
3335 * term.c: Likewise.
3336 * w32console.c: Likewise.
3337 * w32fns.c: Likewise.
3338 * w32term.c: Likewise.
3339 * window.c: Likewise.
3340 * xdisp.c: Likewise.
3341 * xfaces.c: Likewise.
3342 * xfns.c: Likewise.
3343 * xselect.c: Likewise.
3344 * xterm.c: Likewise.
3345
1ec4b7b2
SM
33462012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
3347
3348 * fns.c (maybe_resize_hash_table): Output message when growing the
3349 purify-hashtable.
3350
2014308a
DA
33512012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3352
3353 * alloc.c (allocate_string_data): Remove dead code.
3354 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
3355 avoid GCC warning about unused macro.
3356
246155eb
DA
33572012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3358
3359 * alloc.c (allocate_string): Omit intervals initialization.
3360 * alloc.c (make_uninit_multibyte_string): Initialize intervals
3361 as in make_pure_string and make_pure_c_string.
3362
43184b7b
DA
33632012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3364
d209e2fb 3365 * alloc.c (allocate_string): Fix last change.
43184b7b 3366
3fe6dd74
DA
33672012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3368
d209e2fb 3369 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
3370 to memset, add explicit initialization where appropriate.
3371
1ba6038a
GM
33722012-06-27 Glenn Morris <rgm@gnu.org>
3373
3374 * lisp.mk (lisp): Remove paths.elc.
3375
c89926a5
CY
33762012-06-27 Chong Yidong <cyd@gnu.org>
3377
3378 * doc.c (Fsubstitute_command_keys): Fix punctuation.
3379
ed6b3510
JW
33802012-06-26 John Wiegley <johnw@newartisans.com>
3381
1ec4b7b2 3382 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
3383 on Mac OS X Lion: __mod_init_func and __mod_term_func.
3384
ed6b3510
JW
3385 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
3386 when building with Clang.
3387
8edd4a2b
SM
33882012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
3389
3390 * eval.c (Fapply): Allow calling it with a single argument.
3391
f6f62d1b
EZ
33922012-06-26 Eli Zaretskii <eliz@gnu.org>
3393
3394 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
3395 _stricmp and _strnicmp.
3396 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
3397
62efea5e
DA
33982012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3399
3400 * alloc.c (allocate_window): Zero out non-Lisp part of newly
3401 allocated window.
3402 (allocate_process): Likewise for new process.
8edd4a2b 3403 (allocate_terminal): Change to use offsetof.
62efea5e
DA
3404 (allocate_frame): Likewise.
3405 * frame.c (make_frame): Omit redundant initialization.
3406 * window.c (make_parent_window): Use memset.
3407 (make_window): Omit redundant initialization.
3408 * process.c (make_process): Omit redundant initialization.
3409 * terminal.c (create_terminal): Likewise.
3410
42997f4d
DA
34112012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3412
3413 * term.c (delete_tty): Remove redundant call to memset.
3414
1130ecfc
DA
34152012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3416
3417 * alloc.c: Remove build_string.
3418 * lisp.h: Define build_string as static inline. This provides
3419 a better opportunity to optimize away calls to strlen when the
3420 function is called with compile-time constant argument.
3421 * image.c (imagemagick_error): Convert to build_string.
3422 * w32proc.c (sys_spawnve): Likewise.
3423 * xterm.c (x_term_init): Likewise.
3424
cf38a720
PE
34252012-06-26 Paul Eggert <eggert@cs.ucla.edu>
3426
99027bdd
PE
3427 Use sprintf return value instead of invoking strlen on result.
3428 In the old days this wasn't portable, since some sprintf
3429 implementations returned char *. But they died out years ago and
3430 Emacs already assumes sprintf returns int.
3431 Similarly for float_to_string.
3432 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
3433 * ccl.c (ccl_driver):
3434 * character.c (string_escape_byte8):
3435 * data.c (Fnumber_to_string):
3436 * doprnt.c (doprnt):
3437 * print.c (print_object):
3438 * xdisp.c (message_dolog):
3439 * xfns.c (syms_of_xfns):
3440 Use sprintf or float_to_string result to avoid need to call strlen.
3441 * data.c (Fnumber_to_string):
3442 Use make_unibyte_string, since the string must be ASCII.
3443 * lisp.h, print.c (float_to_string): Now returns int length.
3444 * term.c (produce_glyphless_glyph):
3445 Use sprintf result rather than recomputing it.
3446
cf38a720
PE
3447 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
3448 * Makefile.in (ALL_CFLAGS):
3449 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
3450 * gmalloc.c, regex.c: Include <config.h> unconditionally.
3451
3511c784
DA
34522012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3453
0a08eb21 3454 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
3455 strcasecmp if available.
3456 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
3457
fb7da12e
AS
34582012-06-25 Andreas Schwab <schwab@linux-m68k.org>
3459
3460 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
3461 Avoid comma operator.
3462 * menu.c (push_submenu_start, push_submenu_end)
3463 (push_left_right_boundary, push_menu_pane): Likewise.
3464 * msdos.c (dos_rawgetc): Likewise.
3465
afa2ffd8
DA
34662012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3467
3468 * xfns.c (xic_create_fontsetname): Remove redundant calls
3469 to memset.
3470
b3b4476b
PE
34712012-06-25 Paul Eggert <eggert@cs.ucla.edu>
3472
4495ff38
PE
3473 * gtkutil.c (get_utf8_string): Remove redundant assignment.
3474 sprintf already null-terminates its output.
3475
b3b4476b
PE
3476 * xfns.c (x_window): Remove redundant cast.
3477
b00876c9
DA
34782012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3479
3480 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
3481 `const char *' to `char *' to avoid compiler warning.
3482
d188e26b
PE
34832012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3484
885d1d74
PE
3485 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
3486 instead of truncating it to 63 (admittedly a generous limit).
3487
d188e26b
PE
3488 * process.c: Fix spelling and caps in comments.
3489
e2f560b1
DN
34902012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
3491
e86db54b 3492 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
3493 * sysdep.c (setpgrp): Remove definition, not used in this file.
3494
7583a3a1
JB
34952012-06-24 Juanma Barranquero <lekktu@gmail.com>
3496
3497 * makefile.w32-in: Update dependencies.
3498
696056c2
EZ
34992012-06-24 Eli Zaretskii <eliz@gnu.org>
3500
3501 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
3502 (SYSTIME_H): Add nt/inc/sys/time.h.
3503
3504 * systime.h [WINDOWSNT]: Include sys/time.h.
3505
3506 * s/ms-w32.h (struct timespec): Definition moved from
3507 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
3508
845ca893
PE
35092012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3510
3511 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
3512 * buffer.h (buffer_slot_type_mismatch):
3513 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3514 * eval.c (unwind_to_catch):
3515 * image.c (my_png_error, my_error_exit):
3516 * keyboard.c (quit_throw_to_read_char, user_error)
3517 (Fexit_recursive_edit, Fabort_recursive_edit):
3518 * lisp.h (die, args_out_of_range, args_out_of_range_3)
3519 (wrong_type_argument, buffer_overflow, __executable_start)
3520 (memory_full, buffer_memory_full, string_overflow, Fthrow)
3521 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
3522 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
3523 (fatal):
3524 (child_setup) [!DOS_NT]:
3525 * lread.c (end_of_file_error, invalid_syntax):
3526 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3527 * puresize.h (pure_write_error):
3528 * search.c (matcher_overflow):
3529 * sound.c (sound_perror, alsa_sound_perror):
3530 * sysdep.c, syssignal.h (croak):
3531 * term.c (maybe_fatal, vfatal):
3532 * textprop.c (text_read_only):
3533 * undo.c (user_error):
3534 * unexmacosx.c (unexec_error):
3535 * xterm.c (x_ins_del_lines, x_delete_glyphs):
3536 Use _Noreturn rather than NO_RETURN.
3537 No need for separate decl merely because of _Noreturn.
3538 * sound.c (sound_warning, parse_sound):
3539 Remove unnecessary forward decls.
3540
f1dd8073
PE
35412012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3542
3543 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
3544 * lisp.h (WAIT_READING_MAX): New macro.
3545 * dispnew.c (Fsleep_for, sit_for):
3546 * keyboard.c (kbd_buffer_get_event):
3547 * process.c (Faccept_process_output):
3548 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
3549 This improves on the previous patch, which introduced a bug
3550 when time_t is unsigned and as wide as intmax_t.
3551 See <http://bugs.gnu.org/9000#51>.
3552
b82c1755
EZ
35532012-06-23 Eli Zaretskii <eliz@gnu.org>
3554
3555 * dispnew.c (sit_for, Fsleep_for):
3556 * keyboard.c (kbd_buffer_get_event):
3557 * process.c (Faccept_process_output): Avoid compiler warnings when
3558 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
3559
ca300656
JB
35602012-06-23 Juanma Barranquero <lekktu@gmail.com>
3561
049ec95b
JB
3562 * makefile.w32-in: Update dependencies.
3563
ca300656
JB
3564 * w32.c (ltime): Add return type and declare static.
3565 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
3566
db7b8d06
PE
35672012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3568
3569 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
3570 Privately reported by Herbert J. Skuhra.
3571 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
3572 All uses changed.
3573 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
3574 not make_lisp_timeval, when the argument is of type EMACS_TIME.
3575
0bd8297f
EZ
35762012-06-23 Eli Zaretskii <eliz@gnu.org>
3577
96512555
EZ
3578 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
3579 last argument of make_unibyte_string.
3580
0bd8297f
EZ
3581 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
3582 language ID in the event parameters.
3583
3584 * w32term.c (w32_read_socket): Put the new keyboard codepage into
3585 event.code, not the obscure "character set ID".
3586
63def6b6
CY
35872012-06-23 Chong Yidong <cyd@gnu.org>
3588
3589 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
3590
e8a02204
EZ
35912012-06-23 Eli Zaretskii <eliz@gnu.org>
3592
388cdec0
EZ
3593 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
3594 * w32.c (fdutimens): New function.
3595
3596 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
3597
3598 * s/ms-w32.h (pselect): Redirect to sys_select.
3599
3600 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
3601
e8a02204
EZ
3602 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
3603 in the logic of incrementing and decrementing the value of
3604 use_relocatable_buffers.
3605
d054f3fb
PE
36062012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3607
3608 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
3609 Privately reported by Herbert J. Skuhra.
3610 [__FreeBSD__]: Remove "*/" typo after "#include".
3611 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
3612 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
3613 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
3614 Don't assume EMACS_TIME and struct timeval are the same type.
3615
d35af63c
PE
36162012-06-22 Paul Eggert <eggert@cs.ucla.edu>
3617
3618 Support higher-resolution time stamps (Bug#9000).
3619 The time stamps are only nanosecond-resolution at the C level,
3620 since that's the best that any real-world system supports now.
3621 But they are picosecond-resolution at the Lisp level, as that's
3622 easy, and leaves room for future OS improvements.
3623
3624 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
3625 (LIBES): Use it.
3626
3627 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
3628 Don't get current time unless it's needed.
3629
3630 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
3631 now provides it if it's absent.
3632 (start_atimer): Port to higher-res time stamps.
3633 Check for time stamp overflow. Don't get current time more
3634 often than is needed.
3635
3636 * buffer.h (struct buffer): Buffer modtime now has high resolution.
3637 Include systime.h, not time.h.
3638 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
3639
3640 * dired.c: Include stat-time.h.
3641 (Ffile-attributes): File times now have higher resolution.
3642
3643 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
3644 (struct image): Timestamp now has higher resolution.
3645
3646 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
3647 has at least microseconds now. All uses removed.
3648 (update_frame, update_single_window, update_window, update_frame_1)
3649 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
927c7216 3650 (duration_to_sec_usec): Remove; no longer needed.
d35af63c
PE
3651
3652 * editfns.c (time_overflow): Now extern.
3653 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
3654 (float-time, Fformat_time_string, Fcurrent_time_string)
3655 (Fcurrent_time_zone): Accept and generate higher-resolution
3656 time stamps.
3657 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
3658 (decode_time_components, lisp_seconds_argument): New functions.
3659 (make_time): Now static.
3660 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
3661 Report an error if the time is invalid, rather than having the caller
3662 do that.
3663
3664 * fileio.c: Include <stat-time.h>
3665 (Fcopy_file): Copy higher-resolution time stamps.
3666 Prefer to set the time stamp via a file descriptor if that works.
3667 (Fset_file_times, Finsert_file_contents, Fwrite_region)
3668 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
3669 (Fvisited_file_modtime, Fset_visited_file_modtime):
3670 Support higher-resolution time stamps.
3671
3672 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
3673
3674 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
3675
3676 * image.c (prepare_image_for_display, clear_image_cache)
3677 (lookup_image): Port to higer-resolution time stamps.
3678
3679 * keyboard.c (start_polling, bind_polling_period):
3680 Check for time stamp overflow.
3681 (read_char, kbd_buffer_get_event, timer_start_idle)
3682 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
3683 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
3684 Port to higher-resolution time stamps. Do not assume time_t is signed.
3685 (decode_timer): New function. Timers are now vectors of length 9,
3686 not 8, to accommodate the picosecond component.
3687 (timer_check_2): Use it.
3688
3689 * nsterm.m (select_timeout, timeval_subtract): Remove.
3690 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
3691 as they're a bit more accurate and handle overflow better.
3692 (ns_select): Change prototype to be compatible with pselect.
3693 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
3694 * nsterm.h (ns_select): Adjust prototype.
3695
3696 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
3697 us-resolution time stamps.
3698 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
3699
3700 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
3701
3702 * lisp.h (time_overflow): New decl.
3703 (wait_reading_process_output): First arg is now intmax_t, not int,
3704 to accommodate larger waits.
3705
3706 * process.h (struct Lisp_Process.read_output_delay):
3707 Now counts nanoseconds, not microseconds.
3708 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
3709 EMACS_HAS_USECS.
3710 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
3711 (wait_reading_process_output):
3712 Port to ns-resolution time stamps.
3713 (Faccept_process_output, wait_reading_process_output):
3714 Check for time stamp overflow. Do not assume time_t is signed.
3715 (select_wrapper): Remove; we now use pselect.
3716 (Fprocess_attributes): Now generates ns-resolution time stamps.
3717
3718 * sysdep.c: Include utimens.h. Don't include utime.h
3719 or worry about struct utimbuf; gnulib does that for us now.
3720 (gettimeofday): Remove; gnulib provides a substitute.
3721 (make_timeval): New function.
3722 (set_file_times): Now sets ns-resolution time stamps.
3723 New arg FD; all uses changed.
3724 (time_from_jiffies, ltime_from_jiffies, get_up_time)
3725 (system_process_attributes):
3726 Now returns ns-resolution time stamp. All uses changed.
3727 Check for time stamp overflow.
3728
3729 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
3730 provides a substitute now.
3731
3732 * systime.h: Include timespec.h rather than sys/time.h and time.h,
3733 since it guarantees struct timespec.
3734 (EMACS_TIME): Now struct timespec, so that we can support
3735 ns-resolution time stamps.
3736 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
3737 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
3738 (EMACS_USECS): Remove.
3739 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
3740 so multiply the arg by 1000 before storing it.
3741 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
3742 New macros.
3743 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
3744 Port to ns-resolution time stamps.
3745 (EMACS_TIME_NEG_P): Remove; replaced by....
3746 (EMACS_TIME_SIGN): New macro.
3747 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
3748 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
3749 (set_file_times, make_time, lisp_time_argument): Adjust signature.
3750 (make_timeval, make_lisp_time, decode_time_components): New decls.
3751 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
3752 that it mishandled time_t overflow. You can't compare by subtracting!
3753 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
3754 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
3755
3756 * term.c: Include <sys/time.h>.
3757 (timeval_to_Time): New function, for proper overflow wraparound.
3758 (term_mouse_position, term_mouse_click): Use it.
3759
3760 * undo.c (record_first_change): Support higher-resolution time stamps
3761 in the undo buffer.
3762 (Fprimitive_undo): Use them when restoring time stamps.
3763
3764 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
3765 (w32_get_internal_run_time):
3766 Port to higher-resolution Emacs time stamps.
3767 (ltime): Now accepts single 64-bit integer, as that's more convenient
3768 for callers.
3769
3770 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
3771
3772 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
3773 for compatibility with pselect. Support ns-resolution time stamps.
3774
3775 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
3776
3777 * xselect.c (wait_for_property_change, x_get_foreign_selection):
3778 Check for time stamp overflow, and support ns-resolution time stamps.
3779
3780 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
3781 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
3782 (timeval_subtract): Remove; no longer needed.
3783 (XTflash, XTring_bell, x_wait_for_event):
3784 Port to ns-resolution time stamps. Don't assume time_t is signed.
3785
b6a92dfe
CY
37862012-06-22 Chong Yidong <cyd@gnu.org>
3787
3788 * xdisp.c (x_consider_frame_title): Revert last change.
3789
d251c37c
EZ
37902012-06-22 Eli Zaretskii <eliz@gnu.org>
3791
3792 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
3793 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
3794 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
3795 staticidx goes up to 1597 out of 1600 = 0x640.)
3796
f10deafb
PE
37972012-06-20 Paul Eggert <eggert@cs.ucla.edu>
3798
3799 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
3800 Otherwise, the umask might be mistakenly 0 while handling input signals.
3801
ec6de1e2
SM
38022012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
3803
3804 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
3805
28be1ada
DA
38062012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
3807
3808 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
3809 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
3810 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
3811 access to `contents' member of Lisp_Vector objects with AREF and ASET
3812 where appropriate.
3813
c6bf3022
CY
38142012-06-19 Chong Yidong <cyd@gnu.org>
3815
3816 * frame.c (delete_frame): When selecting a frame on a different
3817 text terminal, do not alter the terminal's top-frame.
3818
3819 * xdisp.c (format_mode_line_unwind_data): Record the target
3820 frame's selected window and its terminal's top-frame.
3821 (unwind_format_mode_line): Restore them.
3822 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
3823 Callers changed.
3824 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
3825 since tty frames can be explicitly named.
3826 (prepare_menu_bars): Likewise.
3827
3828 * term.c (Ftty_top_frame): New function.
3829
defd4196
PE
38302012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3831
3832 Port byte-code-meter to modern targets.
3833 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
3834 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 3835 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
3836 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
3837 (METER_1, METER_2): Simplify.
3838
1053a871
SM
38392012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
3840
3841 * data.c (Fdefalias): Return `symbol' (bug#11686).
3842
b7e8d081
MR
38432012-06-18 Martin Rudalics <rudalics@gmx.at>
3844
3845 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
3846 gets killed during executing of this function (Bug#11665).
3847 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
3848 (Vkill_buffer_query_functions): In doc-string say that functions
3849 run by this hook should not change the current buffer.
3850
7ea2b339
PE
38512012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3852
3853 Fix recently-introduced process.c problems found by static checking.
3854 * process.c (write_queue_push, write_queue_pop, send_process):
3855 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
3856 (write_queue_pop): Fix pointer signedness problem.
3857 (send_process): Remove unused local.
3858
96a313a1
CY
38592012-06-17 Chong Yidong <cyd@gnu.org>
3860
3861 * xdisp.c (redisplay_internal): No need to redisplay terminal
3862 frames that are not on top.
3863
20ca2e94
TN
38642012-06-17 Troels Nielsen <bn.troels@gmail.com>
3865
3866 * process.c (make_process): Initialize write_queue.
3867 (write_queue_push, write_queue_pop): New functions.
3868 (send_process): Use them to maintain correct ordering of process
3869 writes (Bug#10815).
3870
9a900ca9
PE
38712012-06-17 Paul Eggert <eggert@cs.ucla.edu>
3872
310fbfa8
PE
3873 * lisp.h (eassert): Assume C89 or later.
3874 This removes the need for CHECK.
3875 (CHECK): Remove. Its comments about always evaluating its
3876 argument were confusing, as 'eassert' typically does not evaluate
3877 its argument.
3878
27bb1ca4
PE
3879 * coding.c (produce_chars): Use ptrdiff_t, not int.
3880
9a900ca9
PE
3881 * xterm.c (x_draw_underwave): Check for integer overflow.
3882 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
3883
41b7f8bc 38842012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
3885
3886 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
3887 referenced (Bug#11583).
3888
9b0e3eba
AA
38892012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
3890
3891 Implement wave-style variant of underlining.
3892 * dispextern.h (face_underline_type): New enum.
3893 (face): Add field for underline type.
3894 * nsterm.m (ns_draw_underwave): New function.
3895 (ns_draw_text_decoration): Use it.
3896 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
3897 New functions.
3898 (x_draw_glyph_string): Use them.
3899 * xfaces.c (Qline, Qwave): New Lisp objects.
3900 (check_lface_attrs, merge_face_ref)
1053a871
SM
3901 (Finternal_set_lisp_face_attribute, realize_x_face):
3902 Handle wave-style underline face attributes.
9b0e3eba
AA
3903 * xterm.c (x_draw_underwave): New function.
3904 (x_draw_glyph_string): Use it.
3905
0fb52f11
JB
39062012-06-16 Juanma Barranquero <lekktu@gmail.com>
3907
3908 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
3909 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
3910 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
3911 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
3912 ($(BLD)/w32select.$(O)): Update dependencies.
3913
e5560ff7
AS
39142012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3915
3916 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
3917 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
3918 * character.c (_fetch_multibyte_char_p): Remove.
3919 * alloc.c: Include "character.h" before "buffer.h".
3920 * bidi.c: Likewise.
3921 * buffer.c: Likewise.
3922 * bytecode.c: Likewise.
3923 * callint.c: Likewise.
3924 * callproc.c: Likewise.
3925 * casefiddle.c: Likewise.
3926 * casetab.c: Likewise.
3927 * category.c: Likewise.
3928 * cmds.c: Likewise.
3929 * coding.c: Likewise.
3930 * composite.c: Likewise.
3931 * dired.c: Likewise.
3932 * dispnew.c: Likewise.
3933 * doc.c: Likewise.
3934 * dosfns.c: Likewise.
3935 * editfns.c: Likewise.
3936 * emacs.c: Likewise.
3937 * fileio.c: Likewise.
3938 * filelock.c: Likewise.
3939 * font.c: Likewise.
3940 * fontset.c: Likewise.
3941 * fringe.c: Likewise.
3942 * indent.c: Likewise.
3943 * insdel.c: Likewise.
3944 * intervals.c: Likewise.
3945 * keyboard.c: Likewise.
3946 * keymap.c: Likewise.
3947 * lread.c: Likewise.
3948 * macros.c: Likewise.
3949 * marker.c: Likewise.
3950 * minibuf.c: Likewise.
3951 * nsfns.m: Likewise.
3952 * nsmenu.m: Likewise.
3953 * print.c: Likewise.
3954 * process.c: Likewise.
3955 * regex.c: Likewise.
3956 * region-cache.c: Likewise.
3957 * search.c: Likewise.
3958 * syntax.c: Likewise.
3959 * term.c: Likewise.
3960 * textprop.c: Likewise.
3961 * undo.c: Likewise.
3962 * unexsol.c: Likewise.
3963 * w16select.c: Likewise.
3964 * w32fns.c: Likewise.
3965 * w32menu.c: Likewise.
3966 * window.c: Likewise.
3967 * xdisp.c: Likewise.
3968 * xfns.c: Likewise.
3969 * xmenu.c: Likewise.
3970 * xml.c: Likewise.
3971 * xselect.c: Likewise.
3972
2f07e6af
EZ
39732012-06-16 Eli Zaretskii <eliz@gnu.org>
3974
1053a871
SM
3975 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
3976 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 3977 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
3978 row.
3979 (handle_face_prop): Use chunk-relative overlay string index when
3980 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
3981 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
3982 the rightmost. (Bug#11720)
2f07e6af 3983
29b83cec
AS
39842012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3985
3986 * category.h (CHAR_HAS_CATEGORY): Define as inline.
3987 (CATEGORY_MEMBER): Enforce 1/0 value.
3988 * category.c (_temp_category_set): Remove.
3989
4c5501e9
EZ
39902012-06-16 Eli Zaretskii <eliz@gnu.org>
3991
3992 * window.c (Fdelete_other_windows_internal)
3993 (Fdelete_window_internal): Don't access frame's mouse highlight
3994 info of the initial frame. (Bug#11677)
3995
2b570124
PE
39962012-06-14 Paul Eggert <eggert@cs.ucla.edu>
3997
e93864f9
PE
3998 * .gdbinit (xgetint): Fix recently-introduced paren typo.
3999 Assume USE_2_TAGS_FOR_INTS.
4000 (xreload): Adjust $tagmask width to match recent lisp.h change.
4001
2b570124
PE
4002 Simplify lisp.h in minor ways that should not affect code.
4003 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
4004 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
4005 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
4006 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
4007 (INTTYPEBITS): New macro, for clarity.
4008 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
4009 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
4010 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
4011 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
4012 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
4013
81755f69
JB
40142012-06-13 Juanma Barranquero <lekktu@gmail.com>
4015
4016 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
4017
16192a57
GM
40182012-06-13 Glenn Morris <rgm@gnu.org>
4019
4020 * s/bsd-common.h (BSD4_3):
4021 * s/usg5-4-common.h (USG5_4): No longer define; unused.
4022
646b5f55
AS
40232012-06-13 Andreas Schwab <schwab@linux-m68k.org>
4024
4025 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
4026 instead of union.
4027 (XLI, XIL): Define.
1053a871
SM
4028 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
4029 Use them.
4030 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 4031 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 4032 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
4033 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
4034 * frame.c (delete_frame): Remove outdated comment.
4035 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
4036 USE_LISP_UNION_TYPE.
4037 (Fw32_unregister_hot_key): Likewise.
4038 (Fw32_toggle_lock_key): Likewise.
4039 * w32menu.c (add_menu_item): Likewise.
4040 (w32_menu_display_help): Use XIL instead of checking
4041 USE_LISP_UNION_TYPE.
4042 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
4043 (init_heap): Likewise.
4044 * w32term.c (w32_read_socket): Update comment.
4045
1d3823c9
GM
40462012-06-13 Glenn Morris <rgm@gnu.org>
4047
c62ff706
GM
4048 * s/usg5-4-common.h, src/s/unixware.h:
4049 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
4050
1d3823c9
GM
4051 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
4052
bfe3e0a2
PE
40532012-06-13 Paul Eggert <eggert@cs.ucla.edu>
4054
4055 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
4056 * alloc.c (make_number) [!defined make_number]:
4057 Remove, as lisp.h always defines this now.
4058 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
4059 (roundup_size): Verify that it is a power of 2.
4060 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
4061 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
4062 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
4063 -DUSE_LSB_TAG=0, to override the automatically-selected default.
4064 USE_LSB_TAG now is always defined to be either 0 or 1.
4065 All uses changed.
4066 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
4067 code works fine either way, and efficiency is not a concern here,
4068 as the union type is for debugging, not for production.
4069 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
4070 Use an inline function on all platforms when using the union type,
4071 since this is simpler and 'static inline' can be used portably
4072 within Emacs now.
4073 (LISP_INITIALLY_ZERO): New macro.
4074 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
4075 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
4076
45fa9c0f
GM
40772012-06-12 Glenn Morris <rgm@gnu.org>
4078
b4492cba
GM
4079 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
4080
4081 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 4082
45fa9c0f
GM
4083 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
4084 Move BROKEN_SIGIO to configure.
4085
4086 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
4087 Move NO_TERMIO to configure.
4088
0e25d334
CY
40892012-06-12 Chong Yidong <cyd@gnu.org>
4090
4091 * image.c (imagemagick_load_image): Use MagickFlattenImage if
4092 MagickMergeImageLayers is undefined. Use pixel pusher loop if
4093 MagickExportImagePixels is undefined.
4094
43682bb6
PE
40952012-06-12 Paul Eggert <eggert@cs.ucla.edu>
4096
4097 * image.c (imagemagick_load_image): Remove unused label.
4098
a9be7d2b
GM
40992012-06-11 Glenn Morris <rgm@gnu.org>
4100
4101 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
4102 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
4103 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
4104 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
4105
3017f87f
SM
41062012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
4107
4108 * alloc.c (make_byte_code): New function.
4109 (Fmake_byte_code): Use it. Don't purify here.
4110 * lread.c (read1): Use it as well to avoid extra allocation.
4111
1b9b4cf4
CY
41122012-06-11 Chong Yidong <cyd@gnu.org>
4113
4114 * image.c (imagemagick_load_image): Implement transparency.
4115
95988fcf
AS
41162012-06-10 Andreas Schwab <schwab@linux-m68k.org>
4117
4118 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
4119 account for preceding backslashes. (Bug#11663)
4120
cd4eb164
CY
41212012-06-09 Chong Yidong <cyd@gnu.org>
4122
4123 * term.c: Support italics in capable terminals (Bug#9652).
4124 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
4125 (turn_on_face): Output using TS_enter_italic_mode if available.
4126 Don't handle unused blinking and alt-charset cases.
4127 (turn_off_face): Handle italic case; discard unused tty_blinking_p
4128 and tty_alt_charset_p cases.
4129 (tty_capable_p, init_tty): Support italics.
4130
4131 * termchar.h (struct tty_display_info): Add field for italics.
4132 Remove unused blink field.
4133
4134 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
4135 Handle slant.
4136
4137 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
4138 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
4139 tty_alt_charset_p. Add tty_italic_p.
4140
ff88beb8
MA
41412012-06-09 Michael Albinus <michael.albinus@gmx.de>
4142
4143 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
4144 dbus_type_is_basic if available.
4145 (xd_extract_signed, xd_extract_unsigned): Rename from
4146 extract_signed and extract_unsigned, respectively. Adapt callers.
4147
44286096
CY
41482012-06-09 Chong Yidong <cyd@gnu.org>
4149
1682701f
CY
4150 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
4151
44286096
CY
4152 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
4153 case (Bug#9752).
4154
d86feb17
PE
41552012-06-08 Paul Eggert <eggert@cs.ucla.edu>
4156
4157 * xdisp.c (vmessage): Treat frame message as multibyte.
4158 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
4159 would generate the diagnostic "Making \302\247 buffer-local while
4160 let-bound!".
4161
d5c20fe8
EZ
41622012-06-08 Eli Zaretskii <eliz@gnu.org>
4163
4164 * dispnew.c (showing_window_margins_p): Undo last change, which
4165 was done due to an inadvertent commit.
4166 (adjust_frame_glyphs_for_frame_redisplay): Do call
4167 showing_window_margins_p.
4168
513749ee
SM
41692012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
4170
4171 * eval.c (Fmake_var_non_special): New primitive.
4172 (syms_of_eval): Defsubr it.
4173 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
4174
d4a8f5c1
JB
41752012-06-08 Juanma Barranquero <lekktu@gmail.com>
4176
4177 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
4178 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
4179
8bbbc977
EZ
41802012-06-08 Eli Zaretskii <eliz@gnu.org>
4181
4182 * alloc.c (allocate_vectorlike): Fix last change.
4183
f3372c87
DA
41842012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
4185
4186 Block-based vector allocation of small vectors.
4187 * lisp.h (struct vectorlike_header): New field `nbytes',
4188 adjust comment accordingly.
4189 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
4190 to denote vector blocks. Adjust users (live_vector_p,
4191 mark_maybe_pointer, valid_lisp_object_p) accordingly.
4192 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
4193 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
4194 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
4195 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
4196 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
4197 (roundup_size): New constant.
4198 (struct vector_block): New data type.
4199 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 4200 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
4201 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
4202 (sweep_vectors): New functions.
4203 (allocate_vectorlike): Return `zero_vector' as the only vector of
4204 0 items. Allocate new vector from block if vector size is less than
4205 or equal to VBLOCK_BYTES_MAX.
4206 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
4207 (init_alloc_once): Add call to init_vectors.
4208
4f18a4ed
SM
42092012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
4210
4211 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
4212
86f158bc
PE
42132012-06-07 Paul Eggert <eggert@cs.ucla.edu>
4214
4215 * doprnt.c (doprnt): Truncate multibyte char correctly.
4216 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
4217 would mishandle a string argument "Xc" if X was a multibyte
4218 character of length 2: it would truncate after X's first byte
4219 rather than including all of X.
4220
c5cfcbe0
CY
42212012-06-06 Chong Yidong <cyd@gnu.org>
4222
4223 * buffer.c (word_wrap): Doc fix.
4224
c05cf390
PE
42252012-06-04 Paul Eggert <eggert@cs.ucla.edu>
4226
4227 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
4228
0c3461de
GM
42292012-06-03 Glenn Morris <rgm@gnu.org>
4230
4231 * xdisp.c (tool-bar-style): Doc fix.
4232
c71232db
UM
42332012-06-03 Ulrich Müller <ulm@gentoo.org>
4234
4235 * Makefile.in (PAXCTL): Define.
4236 (temacs$(EXEEXT)): Disable memory randomization for the temacs
4237 binary via PaX flags if the paxctl utility is available.
4238 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
4239 Restore PaX flags to their default. (Bug#11398)
4240
383f7350
CY
42412012-06-03 Chong Yidong <cyd@gnu.org>
4242
4243 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
4244 buffer (Bug#11226).
4245
5f2c76c6
CY
42462012-06-03 Chong Yidong <cyd@gnu.org>
4247
4248 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
4249 (note_mode_line_or_margin_highlight): If there is no help echo,
4250 use mode-line-default-help-echo. Handle the case where the mouse
4251 position is past the end of the mode line string.
4252
4253 * buffer.c (buffer_local_value_1): New function, split from
4254 Fbuffer_local_value; can return Qunbound.
4255 (Fbuffer_local_value): Use it.
4256 (Vmode_line_format): Docstring tweaks.
4257
773d47f6
PE
42582012-06-02 Paul Eggert <eggert@cs.ucla.edu>
4259
4260 * sysdep.c (system_process_attributes): Improve comment.
4261
f2d6a3df
SM
42622012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
4263
4264 * keyboard.c: Export real-this-command to Elisp.
4265 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
4266 and DEFVAR it. Update all users.
4267
63810350
PE
42682012-06-02 Paul Eggert <eggert@cs.ucla.edu>
4269
7bd5c1f4
PE
4270 * minibuf.c (Fassoc_string): Remove duplicate declaration.
4271
63810350
PE
4272 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
4273 Convert pctcpu and pctmem to Lisp float properly.
4274 Let the compiler fold better, as 100.0/0x8000 is exact.
4275
a2821611
AS
42762012-06-02 Andreas Schwab <schwab@linux-m68k.org>
4277
4278 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
4279 cons_block.
4280
5fceba1d
PE
42812012-06-01 Paul Eggert <eggert@cs.ucla.edu>
4282
4283 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
4284
c98ff5dd
DA
42852012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
4286
4287 For a 'struct window', replace some Lisp_Object fields to
4288 bitfields where appropriate, remove unused fields.
4289 * window.h (struct window): Remove unused 'last_mark_x' and
4290 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
4291 change it's type from Lisp_Object to bitfield.
4292 Change type of 'force_start', 'optional_new_start',
4293 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
4294 fields from Lisp_Object to bitfield. Adjust users accordingly.
4295
ca34e0be
PE
42962012-05-31 Paul Eggert <eggert@cs.ucla.edu>
4297
4298 Pacify gcc -Wdouble-precision when using Xaw.
4299 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
4300 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
4301 Use 'float' consistently, rather than 'float' in most places
4302 and 'double' in a couple of places.
4303
efc00ab1 43042012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
4305
4306 * xdisp.c (handle_stop): Detect whether we have overlay strings
4307 loaded by testing it->current.overlay_string_index to be
4308 non-negative, instead of checking whether n_overlay_strings is
4309 positive. (Bug#11587)
4310
efc00ab1 43112012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
4312
4313 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
4314
4315 * doc.c (Fsubstitute_command_keys): Doc fix.
4316
efc00ab1 43172012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
4318
4319 * search.c (search_buffer): Remove calls to
4320 r_alloc_inhibit_buffer_relocation, as it is now called by
4321 maybe_unify_char, which was the cause of relocation of buffer text
4322 in bug#11519.
4323
efc00ab1 43242012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
4325
4326 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
4327 for the duration of call to load_charset, to avoid problems with
4328 callers of maybe_unify_char that access buffer text through C
4329 pointers.
4330
4331 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
4332 decrement the inhibition flag, instead of just setting or
4333 resetting it.
4334
ba93a187
PE
43352012-05-31 Paul Eggert <eggert@cs.ucla.edu>
4336
4337 Remove obsolete '#define static' cruft.
4338 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
4339 This #undef was "temporary" in 2000; it is no longer needed
4340 now that '#define static' has gone away.
4341 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
4342 (gray_bitmap_bits): Remove; no longer needed.
4343 All uses replaced with definiens.
4344 * xterm.c: Include "bitmaps/gray.xbm".
4345
9e4bf381
PE
43462012-05-30 Paul Eggert <eggert@cs.ucla.edu>
4347
4348 Clean up __executable_start, monstartup when --enable-profiling.
4349 The following changes affect the code only when profiling.
4350 * dispnew.c (__executable_start): Rename from safe_bcopy.
4351 Define only on platforms that need it.
4352 * emacs.c: Include <sys/gmon.h> when profiling.
4353 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
4354 (__executable_start): Remove decl, since lisp.h does it now.
4355 (safe_bcopy): Remove decl; no longer has that name.
4356 (main): Coalesce #if into single bit of code, for simplicity.
4357 Cast pointers to uintptr_t, since standard libraries want integers
4358 and not pointers.
4359 * lisp.h (__executable_start): New decl.
4360
32d72c2f
GM
43612012-05-31 Glenn Morris <rgm@gnu.org>
4362
4363 * image.c (Fimagemagick_types): Doc fix.
4364
baac5bc7
JM
43652012-05-30 Jim Meyering <meyering@redhat.com>
4366
4367 * callproc.c (Fcall_process_region): Include directory component
4368 in mkstemp error message (Bug#11586).
4369
72cb32cf
PE
43702012-05-30 Paul Eggert <eggert@cs.ucla.edu>
4371
4372 * alloc.c, lisp.h (make_pure_vector): Now static.
4373
61b108cc
SM
43742012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
4375
4376 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
4377 Move to byte-run.el.
4378 (Fautoload): Do the hash-doc more carefully.
4379 * data.c (Fdefalias): Purify definition, except for keymaps.
4380 (Qdefun): Move from eval.c.
4381 * lisp.h (Qdefun): Remove.
4382 * lread.c (read1): Tiny simplification.
4383
471fe23d
TN
43842012-05-29 Troels Nielsen <bn.troels@gmail.com>
4385
934f3f58 4386 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
4387 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
4388 Bug#9642, but explicitly check that the buffer the overlay would
4389 be moved to is live and rearrange lines to make sure that errors
4390 will not put the overlay in an inconsistent state.
4391 (Fdelete_overlay): Cosmetics.
4392
85d0efd1
EZ
43932012-05-28 Eli Zaretskii <eliz@gnu.org>
4394
4395 * w32term.c (my_bring_window_to_top): New function.
4396 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
4397 could be different from the original one.
4398 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
4399 (Bug#11513)
4400
4401 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
4402 by calling BringWindowToTop.
4403
4404 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
4405 (WM_EMACS_END): Increase by one.
4406
da92a98c
PE
44072012-05-28 Paul Eggert <eggert@cs.ucla.edu>
4408
4409 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
4410 This avoids undefined behavior that might cause the eassert
4411 to not catch an out-of-range value.
4412
74d1f848
JB
44132012-05-28 Juanma Barranquero <lekktu@gmail.com>
4414
4415 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
4416 Update dependencies.
4417
9e1a06fc
EZ
44182012-05-27 Eli Zaretskii <eliz@gnu.org>
4419
4420 * bidi.c (bidi_mirror_char): Fix last change.
4421
f3dd7312
AS
44222012-05-27 Andreas Schwab <schwab@linux-m68k.org>
4423
4424 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
4425 when referring to sectname field in printf format.
4426
81899c91
PE
44272012-05-27 Paul Eggert <eggert@cs.ucla.edu>
4428
57b81a9f
PE
4429 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
4430 Only r_alloc_inhibit_buffer_relocation needed to be added;
4431 the others were already declared.
4432
81899c91
PE
4433 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
4434 before checking whether it's out of range. Put the check inside
4435 eassert. See
4436 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
4437
33017faf 44382012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
4439
4440 * callproc.c (Fcall_process): Restore a line that was accidentally
4441 commented out in the 2011-02-13 change (bug#11547).
4442
33017faf 44432012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
4444
4445 * lisp.h [REL_ALLOC]: Add prototypes for external functions
4446 defined on ralloc.c.
4447
4448 * buffer.c [REL_ALLOC]: Remove prototypes of
4449 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
4450 they are now on lisp.h.
4451
4452 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
4453
4454 * search.c (search_buffer): Use it to inhibit relocation of buffer
4455 text while re_search_2 is doing its job, because re_search_2 is
4456 passed C pointers to buffer text. (Bug#11519)
4457
23415acf
EZ
4458 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
4459 Update value to 24.
4460
44e27368
EZ
4461 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
4462 state after an additional call to move_it_in_display_line_to, keep
4463 the values of it->max_ascent and it->max_descent found for the
4464 entire line.
4465 (pos_visible_p): Revert the comparison against bottom_y to what it
4466 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
4467 (Bug#11464)
4468
c1892f11
PE
44692012-05-26 Paul Eggert <eggert@cs.ucla.edu>
4470
4471 Fix coding-related core dumps with gcc -ftrapv.
4472 The code was computing A - B, where A and B are pointers, and B is
4473 random garbage. This can lead to core dumps on platforms that
4474 have special pointer registers, and it also leads to core dumps on
4475 x86-64 when compiled with gcc -ftrapv. The fix is to compute
4476 A - B only when B is initialized properly.
4477 * coding.c (coding_set_source, coding_set_destination): Return void.
4478 (coding_change_source, coding_change_destinations): New functions,
4479 with the old behaviors of coding_set_source and coding_set_destination.
4480 All callers that need an offset changed to use these new functions.
4481
eb7afdad
GM
44822012-05-26 Glenn Morris <rgm@gnu.org>
4483
4484 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
4485
f12fdf02
EZ
44862012-05-26 Eli Zaretskii <eliz@gnu.org>
4487
53a63be6 4488 Extend mouse support on W32 text-mode console.
61b108cc
SM
4489 * xdisp.c (draw_row_with_mouse_face):
4490 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 4491
eb3f6f01 4492 * w32console.c: Include window.h.
61b108cc
SM
4493 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
4494 New functions.
eb3f6f01
EZ
4495 (initialize_w32_display): Initialize mouse-highlight data.
4496
53a63be6
EZ
4497 * w32inevt.c: Include termchar.h and window.h.
4498 (do_mouse_event): Support mouse-autoselect-window. When the mouse
4499 moves, call note_mouse_highlight. If help_echo changed, call
4500 gen_help_event to produce help-echo message in the echo area.
4501 Call clear_mouse_face if mouse_face_hidden is set in the mouse
4502 highlight info.
4503
4cfd81f6
PE
45042012-05-26 Paul Eggert <eggert@cs.ucla.edu>
4505
4506 * lread.c (read1): Simplify slightly to avoid an overflow warning
4507 with GCC 4.7.0 on x86-64.
4508
4446092a
EZ
45092012-05-26 Eli Zaretskii <eliz@gnu.org>
4510
4511 * bidi.c (bidi_mirror_char): Revert last change: an int is
4512 definitely wide enough here.
4513
42b2a986 45142012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 4515
42b2a986 4516 Fix integer width and related bugs (Bug#9874).
eb106a49 4517 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
4518 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
4519 (string_bytes, check_sblock, allocate_string_data):
4520 (compact_small_strings, Fmake_bool_vector, make_string)
4521 (make_unibyte_string, make_multibyte_string)
4522 (make_string_from_bytes, make_specified_string)
4523 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
4524 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
4525 (mark_vectorlike):
4526 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4527 (allocate_pseudovector):
4528 Use int, not EMACS_INT, where int is wide enough.
4529 (inhibit_garbage_collection, Fgarbage_collect):
4530 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4531 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
4532 int might not be wide enough.
4533 (bidi_cache_search, bidi_cache_find, bidi_init_it)
4534 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
4535 (bidi_at_paragraph_end, bidi_find_paragraph_start)
4536 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4537 (bidi_level_of_next_char, bidi_move_to_visually_next):
4538 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4539 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
4540 (Fkill_buffer, Fset_buffer_major_mode)
4541 (advance_to_char_boundary, Fbuffer_swap_text)
4542 (Fset_buffer_multibyte, overlays_at, overlays_in)
4543 (overlay_touches_p, struct sortvec, record_overlay_string)
4544 (overlay_strings, recenter_overlay_lists)
4545 (adjust_overlays_for_insert, adjust_overlays_for_delete)
4546 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
4547 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
4548 (Foverlay_recenter, last_overlay_modification_hooks_used)
4549 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
4550 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
4551 (validate_region): Omit unnecessary test for b <= e,
4552 since that's guaranteed by the previous test.
d311d28c
PE
4553 (adjust_overlays_for_delete): Avoid pos + length overflow.
4554 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
4555 (report_overlay_modification):
4556 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4557 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
4558 Omit pointer cast, which isn't needed anyway, and doesn't work
4559 after the EMACS_INT -> ptrdiff_t change.
02481186 4560 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
4561 * buffer.h: Adjust decls to match defn changes elsewhere.
4562 (struct buffer_text, struct buffer):
4563 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4564 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
4565 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
4566 not int, to avoid needless 32-bit limit on 64-bit hosts.
4567 (exec_byte_code): Use tighter memory-full test, one that checks
4568 for alloca overflow. Don't compute the address of the object just
4569 before an array, as that's not portable. Use EMACS_INT, not
4570 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
4571 * callint.c (Fcall_interactively):
4572 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4573 * callproc.c (call_process_kill, Fcall_process):
4574 Don't assume pid_t fits into an Emacs fixnum.
4575 (call_process_cleanup, Fcall_process, child_setup):
4576 Don't assume pid_t fits into int.
4577 (call_process_cleanup, Fcall_process, delete_temp_file)
4578 (Fcall_process_region):
4579 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4580 (Fcall_process): Simplify handling of volatile integers.
4581 Use int, not EMACS_INT, where int will do.
4582 * casefiddle.c (casify_object, casify_region, operate_on_word)
4583 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
4584 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4585 (casify_object): Avoid integer overflow when overallocating buffer.
4586 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 4587 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
4588 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
4589 * category.h (CATEGORYP): Don't assume arg is nonnegative.
4590 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
4591 integers are now checked earlier. All uses replaced with XINT.
4592 (ccl_driver):
4593 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4594 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
4595 (ccl_driver, Fregister_code_conversion_map):
4596 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
4597 (resolve_symbol_ccl_program): Check that vector header is in range.
4598 Always copy the vector, so that we can check its contents reliably
4599 now rather than having to recheck each instruction as it's being
4600 executed. Check that vector words fit in 'int'.
4601 (ccl_get_compiled_code, Fregister_ccl_program)
4602 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
4603 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
4604 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
4605 contents are in range.
4606 (Fccl_execute_on_string): Check that status is in range.
4607 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
4608 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
4609 Accept and return EMACS_INT, not int, because callers can pass values
4610 out of 'int' range.
4611 (c_string_width, strwidth, lisp_string_width, chars_in_text)
4612 (multibyte_chars_in_text, parse_str_as_multibyte)
4613 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
4614 (str_as_unibyte, str_to_unibyte, string_count_byte8)
4615 (string_escape_byte8, Fget_byte):
4616 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 4617 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
4618 avoid mishandling large integers.
4619 * character.h: Adjust decls to match defn changes elsewhere.
4620 * charset.c (load_charset_map_from_file, find_charsets_in_text)
4621 (Ffind_charset_region):
4622 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4623 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
4624 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 4625 Don't assume fixnum fits in int.
d311d28c
PE
4626 (load_charset_map_from_vector, Fmap_charset_chars):
4627 Remove now-unnecessary CHECK_NATNUMs.
4628 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
4629 Don't rely on undefined behavior with signed left shift overflow.
4630 Don't assume unsigned int fits into fixnum, or that fixnum fits
4631 into unsigned int. Don't require max_code to be a valid fixnum;
4632 that's not true for gb10830 4-byte on a 32-bit host. Allow
4633 invalid_code to be a cons, for the same reason. Require code_offset
4634 to be a character. Avoid int overflow if max_char is close
4635 to INT_MAX.
4636 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
4637 this is intended anyway and avoids some undefined behavior.
4638 (load_charset_map): Pass unsigned, not int, as 2nd arg of
4639 INDEX_TO_CODE_POINT, as that's what it expects.
4640 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
4641 * charset.h (DECODE_CHAR): Return int, not unsigned;
4642 this is what was intended anyway, and it avoids undefined behavior.
4643 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
4644 integer-overflow issues.
4645 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
4646 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
4647 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
4648 * chartab.c (Fmake_char_table, Fset_char_table_range)
4649 (uniprop_get_decoder, uniprop_get_encoder):
4650 Don't assume fixnum fits in int.
4651 * cmds.c (move_point): New function, that does the gist of
4652 Fforward_char and Fbackward_char, but does so while checking
4653 for integer overflow more accurately.
c96e5d6a 4654 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
4655 (Fforward_line, Fend_of_line, internal_self_insert)
4656 (internal_self_insert):
4657 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4658 Fix a FIXME, by checking for integer overflow when calculating
4659 target_clm and actual_clm.
4660 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 4661 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
4662 (ASSURE_DESTINATION, coding_alloc_by_realloc)
4663 (coding_alloc_by_making_gap, alloc_destination)
4664 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
4665 (encode_coding_utf_16, detect_coding_emacs_mule)
4666 (decode_coding_emacs_mule, encode_coding_emacs_mule)
4667 (detect_coding_iso_2022, decode_coding_iso_2022)
4668 (encode_invocation_designation, encode_designation_at_bol)
4669 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4670 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
4671 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
4672 (encode_coding_ccl, encode_coding_raw_text)
4673 (detect_coding_charset, decode_coding_charset)
4674 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
4675 (produce_composition, produce_charset, produce_annotation)
4676 (decode_coding, handle_composition_annotation)
4677 (handle_charset_annotation, consume_chars, decode_coding_gap)
4678 (decode_coding_object, encode_coding_object, detect_coding_system)
4679 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
4680 (code_convert_region, code_convert_string)
8f50130c
PE
4681 (Fdefine_coding_system_internal)
4682 (coding_set_source, coding_set_destination):
d311d28c
PE
4683 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4684 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
4685 (Fdefine_coding_system_internal):
4686 Don't assume fixnums fit in int.
4687 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 4688 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
4689 (Funencodable_char_position, Fcheck_coding_systems_region)
4690 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 4691 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 4692 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 4693 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 4694 Don't access memory outside of the args array.
d311d28c 4695 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
4696 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
4697 result of ENCODE_CHAR.
d311d28c
PE
4698 * coding.h: Adjust decls to match defn changes elsewhere.
4699 (struct coding_system):
4700 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4701 * composite.c (get_composition_id, find_composition)
4702 (run_composition_function, update_compositions)
4703 (compose_text, composition_gstring_put_cache)
4704 (composition_gstring_p, composition_gstring_width)
4705 (fill_gstring_header, fill_gstring_body, autocmp_chars)
4706 (composition_compute_stop_pos, composition_reseat_it)
4707 (composition_update_it, struct position_record)
4708 (find_automatic_composition, composition_adjust_point)
4709 (Fcomposition_get_gstring, Ffind_composition_internal):
4710 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4711 (update_compositions):
4712 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4713 * composite.h: Adjust decls to match defn changes elsewhere.
4714 (struct composition):
4715 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4716 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4717 Do not attempt to compute the address of the object just before a
4718 buffer; this is not portable.
4719 (Faref, Faset):
4720 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4721 (Faset): Use int, not EMACS_INT, where int is wide enough.
4722 (Fstring_to_number): Don't assume fixnums fit in int.
4723 (Frem): Don't assume arg is nonnegative.
4724 * dbusbind.c (xd_append_arg): Check for integers out of range.
4725 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 4726 (extract_signed, extract_unsigned): New functions.
243e0530
PE
4727 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
4728 (xd_get_connection_references): Return ptrdiff_t, not int.
4729 All uses changed.
4730 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
4731 (xd_read_message_1):
4732 Use int, not unsigned, where the dbus API uses int.
4733 (Fdbus_message_internal): Don't overflow mtype.
4734 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
4735 * dired.c (directory_files_internal, file_name_completion, scmp)
4736 (file_name_completion_stat):
4737 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4738 (file_name_completion): Don't overflow matchcount.
4739 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
4740 * dispextern.h: Adjust decls to match defn changes elsewhere.
4741 (struct text_pos, struct glyph, struct bidi_saved_info)
4742 (struct bidi_string_data, struct bidi_it, struct composition_it)
4743 (struct it):
4744 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4745 (struct display_pos, struct composition_it, struct it):
4746 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4747 * dispnew.c (increment_matrix_positions)
4748 (increment_row_positions, mode_line_string)
4749 (marginal_area_string):
4750 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 4751 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
4752 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4753 (duration_to_sec_usec): New function, to check for overflow better.
4754 (Fsleep_for, sit_for): Use it.
4755 * doc.c (get_doc_string, store_function_docstring):
4756 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4757 (get_doc_string, Fsnarf_documentation):
4758 Use int, not EMACS_INT, where int is wide enough.
4759 (get_doc_string):
4760 Use SAFE_ALLOCA, not alloca.
4761 Check for overflow when converting EMACS_INT to off_t.
4762 * doprnt.c (doprnt):
4763 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4764 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
4765 Don't assume uid_t fits into fixnum.
4766 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
4767 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
4768 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
4769 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
4770 (general_insert_function)
4771 (Finsert_char, make_buffer_string, make_buffer_string_both)
4772 (update_buffer_properties, Fbuffer_substring)
4773 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
4774 (Fsubst_char_in_region, check_translation)
4775 (Ftranslate_region_internal, save_restriction_restore, Fformat)
4776 (transpose_markers, Ftranspose_regions):
4777 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4778 (clip_to_bounds): Move to lisp.h as an inline function).
4779 (Fconstrain_to_field): Don't assume integers are nonnegative.
4780 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
4781 (Fsubst_char_in_region, Fsave_restriction):
4782 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4783 (Femacs_pid): Don't assume pid_t fits into fixnum.
4784 (lo_time): Use int, not EMACS_INT, when int suffices.
4785 (lisp_time_argument): Check for usec out of range.
4786 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
4787 (Fuser_login_name, Fuser_full_name): Signal an error
4788 if a uid argument is out of range, rather than relying on
4789 undefined behavior.
c8d5c857
PE
4790 (Fformat_time_string): Remove now-unnecessary check.
4791 lisp_time_argument checks for out-of-range usec now.
243e0530 4792 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
4793 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
4794 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
4795 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
4796 (init_cmdargs, Fdump_emacs):
4797 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4798 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
4799 the bottom (typically) 32 bits of the fixnum.
4800 * eval.c (specpdl_size, call_debugger):
4801 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4802 (when_entered_debugger, Fbacktrace_debug):
4803 Don't assume fixnum can fit in int.
4804 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
4805 the object just before a buffer; this is not portable.
4806 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
4807 (grow_specpdl, unbind_to):
4808 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4809 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
4810 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 4811 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
4812 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
4813 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
4814 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4815 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
4816 (a_write, e_write):
4817 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4818 (Fcopy_file, non_regular_nbytes, read_non_regular)
4819 (Finsert_file_contents):
4820 Use int, not EMACS_INT, where int is wide enough.
4821 (READ_BUF_SIZE): Verify that it fits in int.
4822 (Finsert_file_contents): Check that counts are in proper range,
4823 rather than assuming fixnums fit into ptrdiff_t etc.
4824 Don't assume fixnums fit into int.
125b3835 4825 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
4826 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
4827 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
4828 (string_char_to_byte, string_byte_to_char)
4829 (string_make_multibyte, string_to_multibyte)
4830 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
4831 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
4832 (substring_both, Fdelete, internal_equal, Ffillarray)
4833 (Fclear_string, mapcar1)
4834 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
4835 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
4836 (larger_vector, make_hash_table, maybe_resize_hash_table)
4837 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
4838 (Fmaphash, secure_hash):
4839 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4840 (concat): Check for string index and length overflow.
4841 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
4842 (Frequire):
4843 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4844 (larger_vector): New API (vec, incr_min, size_max) replaces old
4845 one (vec, new_size, init). This catches size overflow.
4846 INIT was removed because it was always Qnil.
4847 All callers changed.
4848 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
4849 the upper bound on a hash table index size.
4850 (make_hash_table, maybe_resize_hash_table): Use it.
4851 (secure_hash): Computer start_byte and end_byte only after
4852 they're known to be in ptrdiff_t range.
4853 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
4854 (Ffont_get_glyphs, Ffont_at):
4855 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4856 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
4857 (Flist_fonts, Fopen_font):
4858 Don't assume fixnum can fit in int.
4859 (check_gstring): Don't assume index can fit in int.
4860 (font_match_p): Check that fixnum is a character, not a nonnegative
4861 fixnum, since the later code needs to stuff it into an int.
4862 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
4863 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
4864 conversion overflow issues.
4865 (Fopen_font): Check for integer out of range.
4866 (Ffont_get_glyphs): Don't assume index can fit in int.
4867 * font.h: Adjust decls to match defn changes elsewhere.
4868 * fontset.c (reorder_font_vector): Redo score calculation to avoid
4869 integer overflow.
4870 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
4871 printmax_t, where ptrdiff_t is wide enough.
4872 (Finternal_char_font):
4873 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4874 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
4875 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
4876 (Fset_frame_position, x_set_frame_parameters)
4877 (x_set_line_spacing, x_set_border_width)
4878 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
4879 Check that fixnums are in proper range for system types.
4880 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
4881 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4882 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
4883 Use SAFE_ALLOCA_LISP, not alloca.
4884 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
4885 intptr_t is wide enough.
4886 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
4887 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
4888 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
4889 Check for fixnum out of range.
4890 * ftfont.c (ftfont_list): Don't assume index fits in int.
4891 Check that fixnums are in proper range for system types.
4892 (ftfont_shape_by_flt):
4893 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
4894 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4895 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4896 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
4897 Check that fixnums are in proper range for system types.
4898 * gnutls.h: Adjust decls to match defn changes elsewhere.
4899 * gtkutil.c (xg_dialog_run):
4900 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4901 (update_frame_tool_bar):
4902 Check that fixnums are in proper range for system types.
4903 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 4904 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
4905 * indent.c (last_known_column, last_known_column_point):
4906 (current_column_bol_cache):
4907 (skip_invisible, current_column, check_display_width):
4908 (check_display_width, scan_for_column, current_column_1)
4909 (Findent_to, Fcurrent_indentation, position_indentation)
4910 (indented_beyond_p, Fmove_to_column, compute_motion):
4911 (Fcompute_motion, Fvertical_motion):
4912 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4913 (last_known_column_modified): Use EMACS_INT, not int.
4914 (check_display_width):
4915 (Fcompute_motion):
4916 Check that fixnums and floats are in proper range for system types.
4917 (compute_motion): Don't assume index or fixnum fits in int.
4918 (compute_motion, Fcompute_motion):
4919 Use int, not EMACS_INT, when it is wide enough.
4920 (vmotion): Omit local var start_hpos that is always 0; that way
4921 we don't need to worry about overflow in expressions involving it.
4922 * indent.h: Adjust decls to match defn changes elsewhere.
4923 (struct position):
4924 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4925 Use int, not EMACS_INT, where int is wide enough.
4926 Remove unused members ovstring_chars_done and tab_offset;
4927 all uses removed.
4928 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
4929 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
4930 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
4931 (make_gap, copy_text, insert, insert_and_inherit)
4932 (insert_before_markers, insert_before_markers_and_inherit)
4933 (insert_1, count_combining_before, count_combining_after)
4934 (insert_1_both, insert_from_string)
4935 (insert_from_string_before_markers, insert_from_string_1)
4936 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
4937 (adjust_after_replace, adjust_after_insert, replace_range)
4938 (replace_range_2, del_range, del_range_1, del_range_byte)
4939 (del_range_both, del_range_2, modify_region)
4940 (prepare_to_modify_buffer, signal_before_change)
4941 (signal_after_change, Fcombine_after_change_execute):
4942 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4943 * intervals.c (traverse_intervals, rotate_right, rotate_left)
4944 (balance_an_interval, split_interval_right, split_interval_left)
4945 (find_interval, next_interval, update_interval)
4946 (adjust_intervals_for_insertion, delete_node, delete_interval)
4947 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4948 (static_offset_intervals, offset_intervals)
4949 (merge_interval_right, merge_interval_left, make_new_interval)
4950 (graft_intervals_into_buffer, temp_set_point_both)
4951 (temp_set_point, set_point, adjust_for_invis_intang)
4952 (set_point_both, move_if_not_intangible, get_property_and_range)
4953 (get_local_map, copy_intervals, copy_intervals_to_string)
4954 (compare_string_intervals, set_intervals_multibyte_1):
4955 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4956 * intervals.h: Adjust decls to match defn changes elsewhere.
4957 (struct interval):
4958 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4959 * keyboard.c (this_command_key_count, this_single_command_key_start)
4960 (before_command_key_count, before_command_echo_length, echo_now)
4961 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
4962 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
4963 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
4964 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
4965 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4966 (last_non_minibuf_size, last_point_position, echo_truncate)
4967 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
4968 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
4969 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
4970 (stuff_buffered_input):
4971 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4972 (last_auto_save, command_loop_1, read_char):
4973 Use EMACS_INT, not int, to avoid integer overflow.
4974 (record_char): Avoid overflow in total_keys computation.
4975 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
4976 * keyboard.h: Adjust decls to match defn changes elsewhere.
4977 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
4978 (Fkey_description, Fdescribe_vector, Flookup_key):
4979 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4980 (click_position): New function, to check that positions are in range.
4981 (Fcurrent_active_maps):
4982 (describe_command):
4983 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4984 (Faccessible_keymaps, Fkey_description):
4985 (preferred_sequence_p):
4986 Don't assume fixnum can fit into int.
4987 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
4988 Check for integer overflow in size calculations.
4989 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
4990 avoid mishandling large integers.
4991 * lisp.h: Adjust decls to match defn changes elsewhere.
4992 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
4993 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
4994 (struct Lisp_Marker):
4995 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4996 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
4997 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
4998 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
4999 All callers changed.
5000 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
5001 Assume the arg has valid form, since it always does.
5002 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
5003 unsigned integer system type.
5004 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
5005 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
5006 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5007 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
5008 (duration_to_sec_usec): New decl.
5009 * lread.c (read_from_string_index, read_from_string_index_byte)
5010 (read_from_string_limit, readchar, unreadchar, openp)
5011 (read_internal_start, read1, oblookup):
5012 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5013 (Fload, readevalloop, Feval_buffer, Feval_region):
5014 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5015 (openp): Check for out-of-range argument to 'access'.
5016 (read1): Use int, not EMACS_INT, where int is wide enough.
5017 Don't assume fixnum fits into int.
6efdadfd 5018 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
5019 (read_filtered_event): Use duration_to_sec_usec
5020 to do proper overflow checking on durations.
d311d28c
PE
5021 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
5022 in size calculation.
5023 (Fexecute_kbd_macro):
5024 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5025 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
5026 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
5027 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
5028 (set_marker_both, set_marker_restricted_both, marker_position)
5029 (marker_byte_position, Fbuffer_has_markers_at):
5030 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5031 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 5032 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
5033 It now merely ensures that the menu is large enough, without
5034 necessarily growing it, as this avoids some integer overflow issues.
5035 All callers changed.
5036 (keymap_panes, parse_single_submenu, Fx_popup_menu):
5037 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5038 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
5039 Use SAFE_ALLOCA_LISP, not alloca.
5040 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
5041 to EMACS_INT. Check that fixnums are in proper range for system types.
5042 * minibuf.c (minibuf_prompt_width, string_to_object)
5043 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
5044 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
5045 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5046 (get_minibuffer, read_minibuf_unwind):
5047 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5048 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
5049 this simplifies overflow checking. All callers changed.
5050 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
5051 (Ftest_completion):
5052 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5053 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
5054 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
5055 Check that fixnums are in proper range for system types.
5056 (Fx_create_frame, Fx_show_tip):
5057 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5058 * nsfont.m (ns_findfonts, nsfont_list_family):
5059 Don't assume fixnum fits in long.
5060 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
5061 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5062 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
5063 wide enough.
17fdb222 5064 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
5065 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5066 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
5067 (PRINTDECLARE, PRINTPREPARE):
5068 (strout, print_string):
5069 (print, print_preprocess, print_check_string_charset_prop)
5070 (print_object):
5071 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5072 (PRINTDECLARE):
5073 (temp_output_buffer_setup, Fprin1_to_string, print_object):
5074 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5075 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 5076 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 5077 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
5078 (print_error_message): Use SAFE_ALLOCA, not alloca.
5079 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
5080 (print_depth, new_backquote_output, print_number_index):
5081 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
5082 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
5083 (Fset_process_window_size, Fformat_network_address)
5084 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 5085 (sigchld_handler):
d311d28c 5086 Check that fixnums are in proper range for system types.
d44287d4 5087 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
5088 Check for process-ids out of pid_t range rather than relying on
5089 undefined behavior.
e4d81efc 5090 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
5091 (Fformat_network_address, read_process_output, send_process)
5092 (Fprocess_send_region, status_notify):
5093 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5094 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
5095 (wait_reading_process_output, read_process_output, exec_sentinel):
5096 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5097 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
5098 (Faccept_process_output): Use duration_to_sec_usec to do proper
5099 overflow checking on durations.
dde14581
PE
5100 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
5101 Don't assume pid_t fits in int.
02481186
PE
5102 * process.h (struct Lisp_Process): Members tick and update_tick
5103 are now of type EMACS_INT, not int.
b62b53e8
PE
5104 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
5105 configured --with-wide-int.
d311d28c
PE
5106 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
5107 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
5108 * search.c (looking_at_1, string_match_1):
5109 (fast_string_match, fast_c_string_match_ignore_case)
5110 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
5111 (scan_newline, find_before_next_newline, search_command)
5112 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
5113 (set_search_regs, wordify):
5114 (Freplace_match):
5115 (Fmatch_data):
5116 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5117 (string_match_1, search_buffer, set_search_regs):
5118 (Fmatch_data):
5119 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5120 (wordify): Check for overflow in size calculation.
5121 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
5122 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
5123 Check that fixnums are in proper range for system types.
5124 * sound.c (struct sound_device)
5125 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
5126 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5127 (Fplay_sound_internal):
5128 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 5129 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
5130 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
5131 (Fparse_partial_sexp):
5132 Don't assume fixnums can fit in int.
5133 (struct lisp_parse_state, find_start_pos, find_start_value)
5134 (find_start_value_byte, find_start_begv)
5135 (update_syntax_table, char_quoted, dec_bytepos)
5136 (find_defun_start, prev_char_comend_first, back_comment):
5137 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
5138 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
5139 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5140 (Finternal_describe_syntax_value): Check that match_lisp is a
5141 character, not an integer, since the code stuffs it into int.
5142 (scan_words, scan_sexps_forward):
5143 Check that fixnums are in proper range for system types.
5144 (Fforward_word):
5145 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5146 (scan_sexps_forward):
5147 Use CHARACTERP, not INTEGERP, since the value must fit into int.
5148 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
5149 * syntax.h: Adjust decls to match defn changes elsewhere.
5150 (struct gl_state_s):
5151 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
5152 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
5153 MOST_POSITIVE_FIXNUM.
d311d28c
PE
5154 * sysdep.c (wait_for_termination_1, wait_for_termination)
5155 (interruptible_wait_for_termination, mkdir):
5156 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
5157 (emacs_read, emacs_write):
5158 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
5159 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
5160 and double all fit in int.
d311d28c
PE
5161 * term.c (set_tty_color_mode):
5162 Check that fixnums are in proper range for system types.
5163 * termhooks.h (struct input_event):
5164 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5165 * textprop.c (validate_interval_range, interval_of)
5166 (Fadd_text_properties, set_text_properties_1)
5167 (Fremove_text_properties, Fremove_list_of_text_properties)
5168 (Ftext_property_any, Ftext_property_not_all)
5169 (copy_text_properties, text_property_list, extend_property_ranges)
5170 (verify_interval_modification):
5171 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5172 (Fnext_single_char_property_change)
5173 (Fprevious_single_char_property_change):
5174 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
5175 (copy_text_properties):
5176 Check for integer overflow in index calculation.
d311d28c
PE
5177 * undo.c (last_boundary_position, record_point, record_insert)
5178 (record_delete, record_marker_adjustment, record_change)
5179 (record_property_change):
5180 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5181 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
5182 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5183 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
5184 (Fx_hide_tip, Fx_file_dialog):
5185 * w32menu.c (set_frame_menubar):
5186 Use ptrdiff_t, not int, for consistency with rest of code.
5187 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
5188 (select_window, Fdelete_other_windows_internal)
5189 (window_scroll_pixel_based, window_scroll_line_based)
5190 (Frecenter, Fset_window_configuration):
5191 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5192 (Fset_window_hscroll, run_window_configuration_change_hook)
5193 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 5194 (Fscroll_other_window, Frecenter):
d311d28c
PE
5195 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5196 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
5197 Don't assume fixnum fits in int.
5198 (Fset_window_scroll_bars):
5199 Check that fixnums are in proper range for system types.
5200 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
5201 (string_pos, c_string_pos, number_of_chars, init_iterator)
5202 (in_ellipses_for_invisible_text_p, init_from_display_pos)
5203 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
5204 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
5205 (face_before_or_after_it_pos, handle_invisible_prop)
5206 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
5207 (display_prop_intangible_p, string_buffer_position_lim)
5208 (string_buffer_position, handle_composition_prop, load_overlay_strings)
5209 (get_overlay_strings_1, get_overlay_strings)
5210 (iterate_out_of_display_property, forward_to_next_line_start)
5211 (back_to_previous_visible_line_start, reseat, reseat_to_string)
5212 (get_next_display_element, set_iterator_to_next)
5213 (get_visually_first_element, compute_stop_pos_backwards)
5214 (handle_stop_backwards, next_element_from_buffer)
5215 (move_it_in_display_line_to, move_it_in_display_line)
5216 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5217 (add_to_log, message_dolog, message_log_check_duplicate)
5218 (message2, message2_nolog, message3, message3_nolog
5219 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
5220 (current_message_1, truncate_echo_area, truncate_message_1)
5221 (set_message, set_message_1, store_mode_line_noprop)
5222 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
5223 (text_outside_line_unchanged_p, check_point_in_composition)
5224 (reconsider_clip_changes)
5225 (redisplay_internal, set_cursor_from_row, try_scrolling)
5226 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
5227 (redisplay_window, find_last_unchanged_at_beg_row)
5228 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
5229 (trailing_whitespace_p, find_row_edges, display_line)
5230 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
5231 (display_mode_element, store_mode_line_string)
5232 (pint2str, pint2hrstr, decode_mode_spec)
5233 (display_count_lines, display_string, draw_glyphs)
5234 (x_produce_glyphs, x_insert_glyphs)
5235 (rows_from_pos_range, mouse_face_from_buffer_pos)
5236 (fast_find_string_pos, mouse_face_from_string_pos)
5237 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5238 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5239 (safe_call, init_from_display_pos, handle_fontified_prop)
5240 (handle_single_display_spec, load_overlay_strings)
5241 (with_echo_area_buffer, setup_echo_area_for_printing)
5242 (display_echo_area, echo_area_display)
5243 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
5244 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
5245 (redisplay_window, dump_glyph_row, display_mode_line)
5246 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 5247 (handle_display_spec, display_prop_string_p):
d311d28c
PE
5248 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5249 (handle_single_display_spec, build_desired_tool_bar_string)
5250 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
5251 (get_specified_cursor_type):
5252 Check that fixnums are in proper range for system types.
5253 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
5254 (Flookup_image_map):
5255 Don't assume fixnums fit in int.
5256 (compare_overlay_entries):
5257 Avoid mishandling comparisons due to subtraction overflow.
5258 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
5259 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
5260 (handle_tool_bar_click):
5261 Use int, not unsigned, since we prefer signed and the signedness
5262 doesn't matter here.
5263 (get_next_display_element, next_element_from_display_vector):
5264 Use int, not EMACS_INT, when int is wide enough.
5265 (start_hourglass): Use duration_to_sec_usec to do proper
5266 overflow checking on durations.
5267 * xfaces.c (Fbitmap_spec_p):
5268 Check that fixnums are in proper range for system types.
5269 (compare_fonts_by_sort_order):
5270 Avoid mishandling comparisons due to subtraction overflow.
5271 (Fx_family_fonts, realize_basic_faces):
5272 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5273 (Fx_family_fonts):
5274 Don't assume fixnum fits in int.
5275 Use SAFE_ALLOCA_LISP, not alloca.
5276 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
5277 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
5278 (face_at_buffer_position, face_for_overlay_string)
5279 (face_at_string_position):
5280 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5281 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
5282 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
5283 (Fx_show_tip):
5284 Check that fixnums are in proper range for system types.
5285 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
5286 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
5287 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5288 (Fx_change_window_property): Don't assume fixnums fit in int.
5289 * xfont.c (xfont_chars_supported):
5290 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5291 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
5292 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
5293 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5294 * xml.c (parse_region):
5295 * xrdb.c (magic_file_p):
5296 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5297 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
5298 (x_get_local_selection, x_reply_selection_request)
5299 (x_handle_selection_request, wait_for_property_change):
5300 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5301 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
5302 short is wide enough.
5303 (x_send_client_event): Don't assume fixnum fits in int.
5304 * xterm.c (x_x_to_emacs_modifiers):
5305 Don't assume EMACS_INT overflows nicely into int.
5306 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
5307 may come from Lisp.
5308 (handle_one_xevent): NATNUMP can eval its arg twice.
5309 (x_connection_closed):
5310 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5311 * xterm.h: Adjust decls to match defn changes elsewhere.
5312 (struct scroll_bar): Use struct vectorlike_header
5313 rather than rolling our own approximation.
5314 (SCROLL_BAR_VEC_SIZE): Remove; not used.
5315
c6574eb5
GM
53162012-05-25 Glenn Morris <rgm@gnu.org>
5317
5318 * lisp.mk (lisp): Update for more files being compiled now.
5319
e8d32c7e
SM
53202012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
5321
48def666
SM
5322 * lread.c: Remove `read_pure' which makes no difference.
5323 (read_pure): Remove var.
5324 (unreadpure): Remove function.
5325 (readevalloop): Don't call read_list with -1 flag.
5326 (read1, read_vector): Don't test read_pure any more.
5327 (read_list): Simplify.
5328
e8d32c7e
SM
5329 * fileio.c, character.h: Minor style tweaks.
5330
4b2addb7
DA
53312012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
5332
5333 * window.h (clip_changed): Remove useless declaration.
5334
584461b2
JB
53352012-05-22 Juanma Barranquero <lekktu@gmail.com>
5336
5337 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
5338 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
5339
34374650
PE
53402012-05-22 Paul Eggert <eggert@cs.ucla.edu>
5341
5342 Remove src/m/*.
5343 This directory predates autoconf and is no longer needed nowadays.
5344 Move its few remaining bits of functionality to where they're needed.
5345 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
5346 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
5347 * m/template.h: Remove.
5348 * Makefile.in (M_FILE): Remove. All uses removed.
5349 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
5350 * lisp.h (USE_LSB_TAG):
5351 * mem-limits.h (EXCEEDS_LISP_PTR):
5352 Use VAL_MAX, not VALBITS, in #if.
5353 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
5354 (EMACS_UINT): Define unconditionally now.
5355 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
5356 (BITS_PER_EMACS_INT): New constants, replacing
5357 what used to be in config.h, but not useful in #if.
5358 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
5359 define them any more.
5360 (VAL_MAX): New macro.
5361 (VALMASK): Use it.
5362 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
5363 BITS_PER_EMACS_INT, in #if.
5364 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
5365 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
5366 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
5367 * s/ms-w32.h (DATA_START):
5368 Move here from removed file m/intel386.h.
5369 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
5370 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
5371
261cb4bb
PE
53722012-05-21 Paul Eggert <eggert@cs.ucla.edu>
5373
5374 Assume C89 or later.
5375 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
5376 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
5377 (xrealloc):
5378 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
5379 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
5380 * textprop.c, tparam.c (NULL): Remove.
5381 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
5382 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
5383 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
5384 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
5385 * xterm.c (input_signal_count): Assume volatile works.
5386
ff23cd9f
KB
53872012-05-21 Ken Brown <kbrown@cornell.edu>
5388
5389 * xgselect.c (xg_select): Fix first argument in call to 'select'
5390 (bug#11508).
5391
1b170bc6
KB
53922012-05-20 Ken Brown <kbrown@cornell.edu>
5393
5394 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 5395 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 5396
b2f4d39f
KB
53972012-05-19 Ken Brown <kbrown@cornell.edu>
5398
5399 * xfns.c (x_in_use): Remove `static' qualifier.
5400 * xterm.h (x_in_use): Declare.
5401 * xgselect.c: Include xterm.h.
5402 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
5403 and `display_arg' (bug#9754).
5404
003fdae2
PE
54052012-05-19 Paul Eggert <eggert@cs.ucla.edu>
5406
9232a6d9
PE
5407 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
5408
003fdae2
PE
5409 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
5410 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
5411
784b56e2
EZ
54122012-05-18 Eli Zaretskii <eliz@gnu.org>
5413
5414 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
5415
5416 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 5417 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
5418
5419 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
5420 reference to image_cache->refcount.
5421 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
5422
a0a79cde
JL
54232012-05-17 Juri Linkov <juri@jurta.org>
5424
5425 * search.c (Fword_search_regexp, Fword_search_backward)
5426 (Fword_search_forward, Fword_search_backward_lax)
5427 (Fword_search_forward_lax): Move functions to isearch.el
5428 (bug#10145, bug#11381).
5429
b0572523
PE
54302012-05-16 Paul Eggert <eggert@cs.ucla.edu>
5431
5432 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
5433
9660f5fc
SM
54342012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
5435
5436 * lread.c (init_obarray): Declare Qt and Qnil as special.
5437
4374de83
GM
54382012-05-14 Glenn Morris <rgm@gnu.org>
5439
5440 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 5441 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 5442
dc44c39a
PE
54432012-05-14 Paul Eggert <eggert@cs.ucla.edu>
5444
078c97cb
PE
5445 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
5446
dc44c39a
PE
5447 * unexaix.c: Port to more-recent AIX compilers.
5448 (report_error, report_error_1, make_hdr, copy_sym)
5449 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
5450 Make arguments const char *, not char *, to avoid violations of C
5451 standard and to fix some AIX warnings reported by Gilles Pion.
5452
e18afed7 54532012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
5454
5455 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
5456 already have overlays loaded.
5457 (handle_single_display_spec): Before returning without displaying
5458 fringe bitmap, synchronize the bidi iterator with the main display
5459 iterator, by calling iterate_out_of_display_property.
5460 (iterate_out_of_display_property): Detect buffer iteration by
5461 testing that it->string is a Lisp string.
5462 (get_next_display_element): When the current object is exhausted,
5463 and there's something on it->stack, call set_iterator_to_next to
5464 proceed with what's on the stack, instead of returning zero.
5465 (set_iterator_to_next): If called at the end of a Lisp string,
5466 proceed to consider_string_end without incrementing string
5467 position. Don't increment display vector index past the end of
5468 the display vector. (Bug#11417)
c8fb9dc6
EZ
5469 (pos_visible_p): Don't report a position visible when move_it_to
5470 stopped at the last line of window, which happens to be scanned
5471 backwards by the bidi iteration. (Bug#11464)
ac268e67 5472
e18afed7 54732012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
5474
5475 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
5476 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
5477 are on a TTY, and thus unable to display on the fringes.
5478 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
5479 so we need to signal to the caller that this is a "replacing"
5480 display spec. This fixes display when the spec is invalid or we
5481 are on a TTY.
5482
e18afed7 54832012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
5484
5485 * unexaix.c (make_hdr): Fix typo in prototype.
5486 This bug broke the build on AIX. Problem reported by Gilles Pion.
5487
9d0a235a
MA
54882012-05-14 Michael Albinus <michael.albinus@gmx.de>
5489
5490 * keyboard.c (kbd_buffer_get_event): Read special events also in
5491 batch mode. (Bug#11415)
5492
9e6b06ed
GM
54932012-05-12 Glenn Morris <rgm@gnu.org>
5494
5495 * ns.mk: Update for ns_appbindir no longer having trailing "/".
5496
c1a1d7a3
EZ
54972012-05-12 Eli Zaretskii <eliz@gnu.org>
5498
5499 * lisp.mk (lisp): Add newcomment.elc.
5500
3fe7cdc8
GM
55012012-05-12 Glenn Morris <rgm@gnu.org>
5502
5503 * Makefile.in (MKDIR_P): New, set by configure.
5504 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
5505
53f7d2c0
PE
55062012-05-11 Paul Eggert <eggert@cs.ucla.edu>
5507
5508 Remove unused function hourglass_started.
5509 * dispextern.h (hourglass_started):
5510 * w32fns.c (hourglass_started):
5511 * xdisp.c (hourglass_started): Remove.
5512
75aafb17
JB
55132012-05-10 Juanma Barranquero <lekktu@gmail.com>
5514
5515 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
5516 Update dependencies.
5517
12959e8e
PE
55182012-05-10 Paul Eggert <eggert@cs.ucla.edu>
5519
97107e2e
PE
5520 * xgselect.c (xg_select): Put maxfds+1 into a var.
5521 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
5522
12959e8e
PE
5523 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
5524
836d29b3
DA
55252012-05-10 Dave Abrahams <dave@boostpro.com>
5526
5527 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
5528 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
5529
5cb67954
MA
55302012-05-09 Michael Albinus <michael.albinus@gmx.de>
5531
5532 * dbusbind.c (xd_registered_buses): New internal Lisp object.
5533 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
5534 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
5535 Initialize xd_registered_buses.
5536
3478ec45
PE
55372012-05-09 Paul Eggert <eggert@cs.ucla.edu>
5538
b263a6b0
PE
5539 Untag more efficiently if USE_LSB_TAG.
5540 This is based on a proposal by YAMAMOTO Mitsuharu in
5541 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
5542 For an admittedly artificial (nth 8000 longlist) benchmark on
5543 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
5544 Emacs's overall text size by 1%.
5545 * lisp.h (XUNTAG): New macro.
5546 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
5547 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
5548 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
5549 * eval.c (Fautoload):
5550 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
5551 * frame.h (XFRAME): Use XUNTAG.
5552
3478ec45
PE
5553 Port recent dbusbind.c changes to 32-bit --with-wide-int.
5554 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
5555 Remove unportable assumptions about print widths of types like
5556 dbus_uint32_t.
5557 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
5558 intptr_t when converting between pointer and integer, to avoid GCC
5559 warnings about wrong width.
5560
666b903b 55612012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
5562
5563 * w32proc.c (new_child): Force Windows to reserve only 64KB of
5564 stack for each reader_thread, instead of defaulting to 8MB
5565 determined by the linker. This avoids failures in creating
5566 subprocesses on Windows 7, see the discussion in this thread:
5567 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
5568
b120cc17
JC
55692012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
5570
5571 Fix up display of the *Minibuf-0* buffer in the mini window.
5572 * keyboard.c (read_char): Don't clear the echo area if there's no
5573 message to clear.
5574 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 5575 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 5576
9a4b36f8
MA
55772012-05-07 Michael Albinus <michael.albinus@gmx.de>
5578
5579 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
5580 batch mode.
5581
e5f9458f
CY
55822012-05-06 Chong Yidong <cyd@gnu.org>
5583
5584 * lisp.mk (lisp): Update.
5585
eceeb5fc 55862012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
5587
5588 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
5589
71873e2b
SM
55902012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
5591
5592 * data.c (PUT_ERROR): New macro.
5593 (syms_of_data): Use it. Add new error type `user-error'.
5594 * undo.c (user_error): New function.
5595 (Fprimitive_undo): Use it.
5596 * print.c (print_error_message): Adjust print style for `user-error'.
5597 * keyboard.c (user_error): New function.
5598 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
5599
ab0fa4e4
PE
56002012-05-03 Paul Eggert <eggert@cs.ucla.edu>
5601
5602 Do not limit current-time-string to years 1000..9999.
5603 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
5604 (Fcurrent_time_string): Support any year that is supported by the
5605 underlying localtime representation. Don't use asctime, as it
5606 has undefined behavior for years outside the range -999..9999.
5607
7ed806a7
PE
56082012-05-02 Paul Eggert <eggert@cs.ucla.edu>
5609
5610 Fix race conditions involving setenv, gmtime, localtime, asctime.
5611 Without this fix, interrupts could mess up code that uses these
5612 nonreentrant functions, since setting TZ invalidates existing
5613 tm_zone or tzname values, and since most of these functions return
5614 pointers to static storage.
5615 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
5616 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
5617 Grow the critical sections to include not just invoking
5618 localtime/gmtime, but also accessing these functions' results
5619 including their tm_zone values if any, and any related TZ setting.
5620 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
5621 so that the struct tm is saved in the critical section.
5622 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
5623 motivated by the fact that memory allocation needs to be outside
5624 the critical section.
5625
0c16dfed
DA
56262012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
5627
5628 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
5629 with RESET_INTERVAL.
5630
5631 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5632 Remove duplicated buffer name initialization.
5633
3f83ace8
JM
56342012-05-02 Jim Meyering <jim@meyering.net>
5635
5636 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
5637
c7b8541e
JM
5638 * xfns.c (x_window): Use xstrdup (Bug#11375).
5639
90207a15 56402012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
5641
5642 * xdisp.c (pos_visible_p): If already at a newline from the
5643 display string before the 'while' loop, don't walk back the glyphs
5644 from it3.glyph_row. Solves assertion violation when the display
5645 string begins with a newline (egg.el). (Bug#11367)
5646
b593d6a9
AH
56472012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
5648
5649 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
5650 Move to simple.el.
5651
4737362e
GM
56522012-05-01 Glenn Morris <rgm@gnu.org>
5653
99cf43f9
GM
5654 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
5655 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
5656 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
5657 All were removed before 23.1.
5658
9311dcff
GM
5659 * dispnew.c: Remove HAVE_LIBNCURSES test;
5660 it is always true on relevant platforms.
5661
4d5c6349
GM
5662 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
5663 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
5664
4737362e
GM
5665 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
5666
74dd3a6b
AS
56672012-04-30 Andreas Schwab <schwab@linux-m68k.org>
5668
5669 * .gdbinit (xpr): Remove checks for no longer existing misc types.
5670 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
5671 Remove.
5672
13c379ee
PE
56732012-04-28 Paul Eggert <eggert@cs.ucla.edu>
5674
5675 Do not avoid creating empty evaporating overlays (Bug#9642).
5676 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
5677 That is, do not delete an evaporating overlay if it becomes
5678 empty after its bounds are adjusted to fit within its buffer.
5679 This fix caused other problems, and I'm reverting it until we get
5680 to the bottom of them.
5681
a8e7d6d7 56822012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
5683
5684 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
5685
a8e7d6d7 56862012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
5687
5688 * xdisp.c (pos_visible_p): If the window start position is beyond
5689 ZV, start the display from buffer beginning. Prevents assertion
5690 violation in init_iterator when the minibuffer window is scrolled
5691 via the scroll bar.
5692
5693 * window.c (window_scroll_pixel_based): Likewise.
5694
a8e7d6d7 56952012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
5696
5697 * keymap.c (where_is_internal): Doc fix (Bug#10872).
5698
a8e7d6d7 56992012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
5700
5701 * fileio.c (Fcopy_file, Fset_file_selinux_context):
5702 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
5703
a8e7d6d7 57042012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 5705
b593d6a9
AH
5706 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
5707 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 5708
1c6900d9
EZ
57092012-04-26 Eli Zaretskii <eliz@gnu.org>
5710
4c3fa1d9
EZ
5711 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
5712 display element, check also the underlying string or buffer
5713 character. (Bug#11341)
5714
1c6900d9
EZ
5715 * w32menu.c: Include w32heap.h.
5716 (add_menu_item): If the call to AppendMenuW (via
5717 unicode_append_menu) fails, disable Unicode menus only if we are
5718 running on Windows 9X/Me.
5719
42bf8205
AS
57202012-04-24 Andreas Schwab <schwab@linux-m68k.org>
5721
5722 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
5723 (xgetint): Add missing shift for LSB tags.
5724
b1bac16e
MR
57252012-04-24 Martin Rudalics <rudalics@gmx.at>
5726
5727 * keyboard.c (read_char): Don't wipe echo area for select window
5728 events: These might get delayed via `mouse-autoselect-window'
5729 (Bug#11304).
5730
d69621cc
JB
57312012-04-24 Juanma Barranquero <lekktu@gmail.com>
5732
5733 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
5734 manipulation of :loaded-from data.
5735
02fd101b
JB
57362012-04-23 Juanma Barranquero <lekktu@gmail.com>
5737
5738 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
5739 now a cons (bug#11311).
5740
888bec30
PE
57412012-04-23 Paul Eggert <eggert@cs.ucla.edu>
5742
89a438bd
PE
5743 Do not create empty overlays with the evaporate property (Bug#9642).
5744 * buffer.c (Fmove_overlay): Delete an evaporating overlay
5745 if it becomes empty after its bounds are adjusted to fit within
5746 its buffer. Without this fix, in a nonempty buffer (let ((o
5747 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
5748 yields an empty overlay that has the evaporate property, which is
5749 not supposed to happen.
5750
1068fe4d
PE
5751 Fix minor GTK3 problems found by static checking.
5752 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5753 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5754 (struct _EmacsFixedClass, emacs_fixed_get_type):
5755 Move decls here from emacsgtkfixed.h, since they needn't be public.
5756 (emacs_fixed_get_type): Now static.
5757 (emacs_fixed_class_init): Omit unused local.
5758 (emacs_fixed_child_type): Remove; unused.
5759 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5760 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5761 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
5762 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
5763 (EMACS_FIXED_GET_CLASS): Remove; unused.
5764 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
5765
888bec30
PE
5766 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
5767 Problem reported by Juanma Barranquero for Windows -Wunused-function.
5768
de85e130
PE
57692012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5770
d0baac98 5771 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 5772 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
5773 (__malloc_size_t, __malloc_ptrdiff_t):
5774 Remove. All uses removed, replaced by the definiens if needed,
5775 since we can assume C89 or better now.
5776 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
5777 (protect_malloc_state, align, get_contiguous_space)
5778 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
5779 (malloc_atfork_handler_child, malloc_enable_thread)
5780 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
5781 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
5782 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
5783 (special_realloc, _realloc_internal_nolock, _realloc_internal)
5784 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
5785 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
5786 Define using prototypes, not old style.
5787 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
5788 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
5789 (align): Don't assume that signed integer overflow wraps around.
5790 Omit unused local var.
5791 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
5792 (_free_internal_nolock, memalign, mallochook, reallochook):
5793 Omit no-longer-needed casts.
5794 (valloc): Use getpagesize, not __getpagesize.
5795 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
5796 (struct hdr): The 'magic' member is now size_t, not unsigned long.
5797
de85e130
PE
5798 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
5799
dcbf5805
MA
58002012-04-22 Michael Albinus <michael.albinus@gmx.de>
5801
5802 Move functions from C to Lisp. Make non-blocking method calls
5803 the default. Implement further D-Bus standard interfaces.
5804
5805 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
5806 (QCdbus_request_name_allow_replacement)
5807 (QCdbus_request_name_replace_existing)
5808 (QCdbus_request_name_do_not_queue)
5809 (QCdbus_request_name_reply_primary_owner)
5810 (QCdbus_request_name_reply_in_queue)
5811 (QCdbus_request_name_reply_exists)
5812 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
5813 (QCdbus_registered_serial, QCdbus_registered_method)
5814 (QCdbus_registered_signal): New Lisp objects.
5815 (XD_DEBUG_MESSAGE): Use sizeof.
5816 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
5817 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
5818 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
5819 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
5820 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
5821 (xd_signature, xd_append_arg): Allow float for integer types.
5822 (xd_get_connection_references): New function.
b593d6a9
AH
5823 (xd_get_connection_address): Rename from xd_initialize.
5824 Return cached address.
dcbf5805
MA
5825 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
5826 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
5827 level.
5828 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 5829 Return number of refcounts.
dcbf5805
MA
5830 (Fdbus_get_unique_name): Make stronger parameter check.
5831 (Fdbus_message_internal): New defun.
5832 (Fdbus_call_method, Fdbus_call_method_asynchronously)
5833 (Fdbus_method_return_internal, Fdbus_method_error_internal)
5834 (Fdbus_send_signal, Fdbus_register_service)
5835 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
5836 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
5837 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
5838 (Vdbus_compiled_version, Vdbus_runtime_version)
5839 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
5840 (Vdbus_message_type_method_return, Vdbus_message_type_error)
5841 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
5842 (Vdbus_registered_buses, Vdbus_registered_objects_table):
5843 Adapt docstring.
dcbf5805 5844
52828e02
PE
58452012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5846
da05bc4c
PE
5847 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
5848 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
5849 Do not assume ptrdiff_t is the same width as 'int'.
5850
52828e02
PE
5851 * alloc.c: Handle unusual debugging option combinations.
5852 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
5853 since the two debugging options are incompatible.
5854 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
5855 is defined.
5856 (mem_init, mem_insert, mem_insert_fixup):
5857 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
5858 (NEED_MEM_INSERT): Remove; no longer needed.
5859
f01769f9
LL
58602012-04-22 Leo Liu <sdl.web@gmail.com>
5861
5862 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
5863
5790543d
PE
58642012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5865
5866 * sysdep.c [__FreeBSD__]: Minor cleanups.
5867 (list_system_processes, system_process_attributes) [__FreeBSD__]:
5868 Use Emacs indenting style more consistently. Avoid some casts.
5869 Use 'double' consistently rather than mixing 'float' and 'double'.
5870
b91b7e4d
EW
58712012-04-21 Eduard Wiebe <usenet@pusto.de>
5872
b593d6a9
AH
5873 * sysdep.c (list_system_processes, system_process_attributes):
5874 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 5875
6114eb15
AS
58762012-04-21 Andreas Schwab <schwab@linux-m68k.org>
5877
5878 * lisp.mk (lisp): Update.
5879
2f38dff7
PE
58802012-04-20 Paul Eggert <eggert@cs.ucla.edu>
5881
5882 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
5883 It is never used otherwise.
5884
4ae29f89
SM
58852012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
5886
5887 * print.c (print_preprocess): Only check print_depth if print-circle
5888 is nil.
5889 (print_object): Check for cycles even when print-circle is nil and
5890 print-gensym is t, but only check print_depth if print-circle is nil.
5891
f30d612a
CY
58922012-04-20 Chong Yidong <cyd@gnu.org>
5893
5894 * process.c (wait_reading_process_output): If EIO occurs on a pty,
5895 set the status to "failed" and ensure that sentinel is run.
5896
c07a4c0b 58972012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
5898
5899 * process.c (Fset_process_inherit_coding_system_flag)
5900 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 5901 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 5902
c07a4c0b 59032012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
5904
5905 * xdisp.c (string_buffer_position_lim): Limit starting position to
5906 BEGV.
5907 (set_cursor_from_row): If called for a mode-line or header-line
5908 row, return zero immediately.
5909 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
5910 farther than the first row after the header line, if any.
5911 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
5912 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
5913
c07a4c0b 59142012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5915
4ae29f89
SM
5916 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
5917 (bug#11238).
ad3a2b41 5918
c07a4c0b 59192012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 59202012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
5921
5922 configure: new option --enable-gcc-warnings (Bug#11207)
5923 * Makefile.in (C_WARNINGS_SWITCH): Remove.
5924 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
5925 (ALL_CFLAGS): Use new macros rather than old.
5926 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
5927 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
5928 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
5929 -Wunused-result, -Wunused-variable. This should go away once
5930 the Emacs and Gnulib regex code is merged.
5931 (xmalloc, xrealloc): Now static.
5932
aba027e8
PE
59332012-04-17 Paul Eggert <eggert@cs.ucla.edu>
5934
5935 * dired.c (Fsystem_groups): Remove unused local.
5936
e5a36063
GM
59372012-04-17 Glenn Morris <rgm@gnu.org>
5938
5939 * dired.c (Fsystem_users): Doc fix.
5940
316411f0
DA
59412012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
5942
5943 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
5944 (syms_of_dired): Add them.
5945
9426aba4
PE
59462012-04-16 Paul Eggert <eggert@cs.ucla.edu>
5947
b62a57be
PE
5948 Fix minor alloc.c problems found by static checking.
5949 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
5950 New extern decls, to avoid calling undeclared functions.
5951 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
5952 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
5953 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
5954 (NEED_MEM_INSERT): New macro.
5955 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 5956 Remove one incorrect comment and fix another.
b62a57be 5957
3539f31f
PE
5958 Fix minor ralloc.c problems found by static checking.
5959 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5960 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
5961 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
5962 (r_alloc_sbrk): Now static.
5963
a041960a
PE
5964 Improve ralloc.c interface checking.
5965 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5966 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
5967 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
5968 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
5969 [REL_ALLOC]: ... to here, to check interface.
5970 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
5971 Remove decls. This fixes an "It stinks!".
5972
9426aba4
PE
5973 * alloc.c (which_symbols): Fix alignment issue / type clash.
5974
d55c12ed
AS
59752012-04-15 Andreas Schwab <schwab@linux-m68k.org>
5976
5977 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
5978 (struct Lisp_Misc_Any): Likewise.
5979 (struct Lisp_Free): Likewise.
5980 * alloc.c (union aligned_Lisp_Symbol): Define.
5981 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
5982 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
5983 (union aligned_Lisp_Misc): Define.
5984 (MARKER_BLOCK_SIZE, struct marker_block): Use union
5985 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 5986 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 5987
b948ce8b
PE
59882012-04-14 Paul Eggert <eggert@cs.ucla.edu>
5989
5990 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
5991 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
5992 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
5993 * s/netbsd.h, s/sol2-6.h:
5994 Remove definition of GC_MARK_STACK, since the default now works.
5995 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
5996 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
5997 no longer the default.
5998 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
5999
35dc09a1 60002012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 6001
35dc09a1
GM
6002 * lread.c (lisp_file_lexically_bound_p):
6003 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 6004
35dc09a1
GM
60052012-04-14 Eli Zaretskii <eliz@gnu.org>
6006
6007 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
6008 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
6009
60102012-04-14 Jan Djärv <jan.h.d@swipnet.se>
6011
6012 * nsterm.m (constrainFrameRect): Always constrain when there is only
6013 one screen (Bug#10962).
6014
bcd86815
KB
60152012-04-13 Ken Brown <kbrown@cornell.edu>
6016
6017 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
6018
c25df26e
RT
60192012-04-13 Reuben Thomas <rrt@sc3d.org>
6020
6021 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
6022
0fc59f1e
DC
60232012-04-11 Daniel Colascione <dancol@dancol.org>
6024
6025 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
6026 against is gone. It's better to use vfork now so that when Cygwin
6027 gains a new, working vfork, we use it automatically (bug#10398).
6028
de8c03dc
SM
60292012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
6030
6031 * window.c (save_window_save): Obey window-point-insertion-type.
6032
2f097256
GM
60332012-04-11 Glenn Morris <rgm@gnu.org>
6034
6035 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
6036
453b951e
SM
60372012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
6038
6039 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
6040
75f1671a 60412012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
6042
6043 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
6044 (force_quit_count): New var.
6045 (handle_interrupt): Use it.
6046
2a8ce227
JB
60472012-04-10 Juanma Barranquero <lekktu@gmail.com>
6048
6049 * w32.c (w32_delayed_load): Record the full path of the library
6050 being loaded (bug#10424).
6051
935396c0
GM
60522012-04-09 Glenn Morris <rgm@gnu.org>
6053
05920a43
GM
6054 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
6055 not just in the obarray, before snarfing them. (Bug#11036)
6056
935396c0
GM
6057 * Makefile.in ($(leimdir)/leim-list.el):
6058 Pass EMACS rather than BUILT_EMACS.
6059
a18ecafa
TZ
60602012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
6061
6062 * process.c (make_process):
6063 * process.h: Add integer `gnutls_handshakes_tried' member to
6064 process struct.
6065
6bbef4e5
JC
6066 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
6067 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
6068
6069 * gnutls.c (gnutls_log_function2i): Convenience log function.
6070 (emacs_gnutls_read): Use new log functions,
6071 `gnutls_handshakes_tried' process member, and
6072 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
6073 attempts per process (connection).
6074
b4d3bc10
CY
60752012-04-09 Chong Yidong <cyd@gnu.org>
6076
6077 * eval.c (Fuser_variable_p, user_variable_p_eh)
6078 (lisp_indirect_variable): Functions deleted.
6079 (Fdefvar): Caller changed.
6080
6081 * callint.c (Finteractive, Fcall_interactively):
6082 * minibuf.c (Fread_variable): Callers changed.
6083
70f4d973
EZ
60842012-04-09 Eli Zaretskii <eliz@gnu.org>
6085
6086 * xdisp.c (set_cursor_from_row): If the display string appears in
6087 the buffer at position that is closer to point than the position
6088 after the display string, display the cursor on the first glyph of
6089 the display string. Fixes cursor display when a 'display' text
6090 property immediately follows invisible text. (Bug#11094)
6091
cb3c2e3e
PE
60922012-04-09 Paul Eggert <eggert@cs.ucla.edu>
6093
6094 composite.c: use 'double' consistently
6095 * composite.c (get_composition_id): Use 'double' consistently
6096 instead of converting 'float' to 'double' and vice versa; this is
6097 easier to understand and avoids a GCC warning.
6098
fd06db5d
GM
60992012-04-09 Glenn Morris <rgm@gnu.org>
6100
50fe702a
GM
6101 * Makefile.in: Generate leim-list with bootstrap-emacs, in
6102 preparation for dumping it with emacs. (Bug#4789)
6103 (leimdir): New variable.
6104 ($(leimdir)/leim-list.el): New rule.
6105 (emacs$(EXEEXT)): Depend on leim-list.el.
6106
fd06db5d
GM
6107 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
6108 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
6109 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
6110
55c131ee
AS
61112012-04-08 Andreas Schwab <schwab@linux-m68k.org>
6112
6113 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
6114 proper alignment.
6115
9209588f
JB
61162012-04-07 Juanma Barranquero <lekktu@gmail.com>
6117
6118 * xml.c (init_libxml2_functions) [WINDOWSNT]:
6119 Remove unused local variable.
6120
e3fb2efb
PE
61212012-04-07 Paul Eggert <eggert@cs.ucla.edu>
6122
6123 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
6124 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
6125 (mark_memory): Mark Lisp_Objects only if pointers might hide in
6126 objects, as mark_maybe_pointer will catch them otherwise.
6127 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
6128 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
6129
b5385551
PE
61302012-04-07 Paul Eggert <eggert@cs.ucla.edu>
6131
6132 Fix typo that broke non-Windows builds.
6133 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
6134
9078ead6
EZ
61352012-04-07 Eli Zaretskii <eliz@gnu.org>
6136
6137 Support building on MS-Windows with libxml2.
6138
6139 * makefile.w32-in (OBJ2): Add xml.$(O).
6140 (GLOBAL_SOURCES): Add xml.c.
6141 ($(BLD)/xml.$(O)): New dependency list.
6142
6143 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
6144 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
6145 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
6146 [!WINDOWSNT]: New macros.
6147 (init_libxml2_functions, libxml2_loaded_p): New functions.
6148 (parse_region): Call fn_xmlCheckVersion instead of using the macro
6149 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
6150 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
6151 Calls xmlCleanupParser only if libxml2 was loaded (or statically
6152 linked in).
6bbef4e5
JC
6153 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
6154 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
6155 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
6156
6157 * emacs.c: Don't include libxml/parser.h.
6158 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
6159 xmlCleanupParser directly.
6160
6161 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
6162
3811fdf3
EZ
61632012-04-07 Eli Zaretskii <eliz@gnu.org>
6164
6165 * indent.c (Fvertical_motion): If there is a display string at
6166 point, use it.vpos to compute how many lines to backtrack after
6167 move_it_to point. (Bug#11133)
6168
2f8e16b2
EZ
61692012-04-06 Eli Zaretskii <eliz@gnu.org>
6170
6171 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
6172 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
6173 about subtle differences between FETCH_CHAR* and STRING_CHAR*
6174 macros related to unification of CJK characters. For the details,
6175 see the discussion following the message here:
6176 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
6177
3d439cd1
CY
61782012-04-04 Chong Yidong <cyd@gnu.org>
6179
6180 * keyboard.c (Vdelayed_warnings_list): Doc fix.
6181
8bc53d00
EZ
61822012-04-01 Eli Zaretskii <eliz@gnu.org>
6183
6184 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
6185 instead of alloca. (Bug#11138)
6186
3b0512a3
AS
61872012-04-01 Andreas Schwab <schwab@linux-m68k.org>
6188
6189 * w32menu.c (is_simple_dialog): Properly check lisp types.
6190 (Bug#11141)
6191
8427ddd2
EZ
61922012-03-31 Eli Zaretskii <eliz@gnu.org>
6193
979022ef
EZ
6194 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
6195 position we get to after a call to move_it_to fails the
6196 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
6197 only if we wind up in a string from display property. (Bug#11063)
6198
a6b1c7cc
EZ
6199 * window.c (Fdelete_other_windows_internal): Invalidate the row
6200 and column information about mouse highlight, so that redisplay
6201 restores it after reallocating the glyph matrices. (Bug#7464)
6202
8427ddd2
EZ
6203 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
6204 string comes from a `display' text property, use the buffer
6205 position of that property as if we actually saw that position in
6206 the row's glyphs.
697ba24b
EZ
6207 (move_it_by_lines): Remove the assertion that
6208 "it->current_x == 0 && it->hpos == 0" which can be legitimately
6209 violated when there's a before-string at the beginning of a line.
6210 (Bug#11063)
8427ddd2 6211
65a0a738
EZ
62122012-03-30 Eli Zaretskii <eliz@gnu.org>
6213
6214 * xdisp.c (append_space_for_newline): If the default face was
6215 remapped, use the remapped face for the appended newline.
6216 (extend_face_to_end_of_line): Use the remapped default face for
6217 extending the face to the end of the line.
6218 (display_line): Call extend_face_to_end_of_line when the default
6219 face was remapped. (Bug#11068)
6220
581355cc
EZ
62212012-03-29 Eli Zaretskii <eliz@gnu.org>
6222
6223 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
6224
e8fc049f
SM
62252012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6226
6227 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
6228
4fb9a543
GM
62292012-03-27 Glenn Morris <rgm@gnu.org>
6230
6231 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
6232 Doc fixes.
6233
679910f1
KH
62342012-03-26 Kenichi Handa <handa@m17n.org>
6235
6236 * dispextern.h (struct glyph): Fix previous change. Change the
6237 bit length of glyphless.ch to 25 (Bug#11082).
6238
90d49b7f
CY
62392012-03-26 Chong Yidong <cyd@gnu.org>
6240
6241 * keyboard.c (Vselection_inhibit_update_commands): New variable.
6242 (command_loop_1): Use it; inhibit selection update for
6243 handle-select-window too (Bug#8996).
6244
f514f6f0
FP
62452012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
6246
e8fc049f 6247 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 6248
bf43fa51
KH
62492012-03-25 Kenichi Handa <handa@m17n.org>
6250
6251 * dispextern.h (struct glyph): Change the bit length of
6252 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
6253
8a0c01dd
EZ
62542012-03-24 Eli Zaretskii <eliz@gnu.org>
6255
6256 * s/ms-w32.h (tzname): Include time.h before redirecting to
6257 _tzname. Fixes the MSVC build. (Bug#9960)
6258
7d1c3a76
AS
62592012-03-24 Andreas Schwab <schwab@linux-m68k.org>
6260
8ed79523
AS
6261 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
6262 characters.
6263
7d1c3a76
AS
6264 * xterm.c (XTread_socket): Only modify handling_signal if
6265 !SYNC_INPUT. (Bug#11080)
6266
e99a9b8b
EZ
62672012-03-23 Eli Zaretskii <eliz@gnu.org>
6268
6269 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
6270 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
6271 when fetching a multibyte character consumes more bytes than
6272 CHAR_BYTES returns, due to unification of CJK characters in
6273 string_char. (Bug#11073)
6274
5063c0e1
TN
62752012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
6276
6277 * process.c (wait_reading_process_output): Handle pty disconnect
6278 by refraining from sending oneself a SIGCHLD (bug#10933).
6279
9f851fbd
CY
62802012-03-22 Chong Yidong <cyd@gnu.org>
6281
6282 * dispextern.h (struct it): New member string_from_prefix_prop_p.
6283
5063c0e1 6284 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
6285 Mark string as coming from a prefix property.
6286 (handle_face_prop): Use default face for prefix strings (Bug#4281).
6287 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
6288
fb5b8aca
CY
62892012-03-21 Chong Yidong <cyd@gnu.org>
6290
6291 * xfaces.c (Vface_remapping_alist): Doc fix.
6292
62356a1b
EZ
62932012-03-20 Eli Zaretskii <eliz@gnu.org>
6294
6295 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
6296 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
6297 Doc fixes.
62356a1b 6298
025de85b
CY
62992012-03-20 Chong Yidong <cyd@gnu.org>
6300
6301 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
6302 to reflect default non-nil value of redisplay-dont-pause.
6303
4827f94e
KH
63042012-03-19 Kenichi Handa <handa@m17n.org>
6305
6306 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
6307 it fit in a valid range (Bug#11003).
6308
e50a24a2
EZ
63092012-03-18 Eli Zaretskii <eliz@gnu.org>
6310
6311 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
6312 that is not from display property, accept the row as a "cursor
6313 row" if one of the string's character has a non-nil `cursor'
6314 property. Fixes cursor positioning when there are newlines in
6315 overlay strings, e.g. in icomplete.el. (Bug#11035)
6316
9af5ed87
PE
63172012-03-12 Paul Eggert <eggert@cs.ucla.edu>
6318
6319 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
6320
d1f55f16
CY
63212012-03-12 Chong Yidong <cyd@gnu.org>
6322
6323 * eval.c (inhibit_lisp_code): Rename from
6324 inhibit_window_configuration_change_hook; move from window.c.
6325
6326 * xfns.c (unwind_create_frame_1, Fx_create_frame):
6327 * window.c (run_window_configuration_change_hook)
6328 (syms_of_window): Callers changed.
6329
66c5eebd
CY
63302012-03-11 Chong Yidong <cyd@gnu.org>
6331
413df973
CY
6332 * keymap.c (Fkey_description): Doc fix (Bug#9700).
6333
66c5eebd
CY
6334 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
6335
1de11f56
CY
63362012-03-10 Chong Yidong <cyd@gnu.org>
6337
6338 * frame.c (other_visible_frames): Don't assume the selected frame
6339 is visible (Bug#10955).
6340
cae07000
SM
63412012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
6342
6343 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
6344
89c94350
JD
63452012-03-08 Jan Djärv <jan.h.d@swipnet.se>
6346
6347 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
6348 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
6349 zero (Bug#10954).
6350
999dd333
GM
63512012-03-03 Glenn Morris <rgm@gnu.org>
6352
01a6dcc8 6353 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 6354
de0100f2
EZ
63552012-03-02 Eli Zaretskii <eliz@gnu.org>
6356
6357 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
6358 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
6359 (redisplay_window, next_element_from_string): Fix typos in
6360 comments.
3e441275
EZ
6361 (redisplay_window): Pass to move_it_vertically the margin in
6362 pixels, not in screen lines.
de0100f2 6363
96a72ee9
GM
63642012-03-02 Glenn Morris <rgm@gnu.org>
6365
6366 * buffer.c (buffer-list-update-hook): Doc fix.
6367
312508d7
EZ
63682012-02-29 Eli Zaretskii <eliz@gnu.org>
6369
6370 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
6371 push_it before setting up the iterator for the first overlay
6372 string, even if we have an empty string loaded.
6373 (next_overlay_string): If there's an empty string on the iterator
6374 stack, pop the stack. (Bug#10903)
6375
27f3c637
PE
63762012-02-25 Paul Eggert <eggert@cs.ucla.edu>
6377
6378 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
6379 Suggested by Stefan Monnier in
6380 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
6381 * alloc.c (widen_to_Lisp_Object): New static function.
6382 (mark_memory): Also mark Lisp_Objects by fetching pointer words
6383 and widening them to Lisp_Objects. This would work even if
6384 USE_LSB_TAG is defined and wide integers are used, which might
6385 happen in a future version of Emacs.
6386
3c9dfce6
CY
63872012-02-25 Chong Yidong <cyd@gnu.org>
6388
fa74b241
CY
6389 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
6390 Doc fix.
6391
3c9dfce6
CY
6392 * xselect.c (Fx_selection_exists_p): Doc fix.
6393 (x_clipboard_manager_save_all): Print an informative message
6394 before saving to clipboard manager.
6395
9486df08
CY
63962012-02-24 Chong Yidong <cyd@gnu.org>
6397
6398 * keyboard.c (process_special_events): Handle all X selection
6399 requests in kbd_buffer, not just the next one (Bug#8869).
6400
f01d3321
CY
64012012-02-23 Chong Yidong <cyd@gnu.org>
6402
6403 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
6404 call when setting menu-bar-lines and tool-bar-lines parameters.
6405 (unwind_create_frame_1): New helper function.
6406
6407 * window.c (inhibit_window_configuration_change_hook): New var.
6408 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 6409 (syms_of_window): Initialize it.
f01d3321 6410
86b847b6
CY
64112012-02-22 Chong Yidong <cyd@gnu.org>
6412
6413 * xterm.c (x_draw_image_relief): Add missing type check for
6414 Vtool_bar_button_margin (Bug#10743).
6415
a59225b1
CY
64162012-02-21 Chong Yidong <cyd@gnu.org>
6417
6418 * fileio.c (Vfile_name_handler_alist): Doc fix.
6419
6420 * buffer.c (Fget_file_buffer): Protect against invalid file
6421 handler return value.
6422
310f5bd4
PE
64232012-02-20 Paul Eggert <eggert@cs.ucla.edu>
6424
cb3a28cc
PE
6425 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
6426 when computing $valmask.
6427
310f5bd4
PE
6428 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
6429 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
6430 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
6431 It's useless in that case, and it can cause problems on hosts
6432 that allocate halves of EMACS_INT values separately.
6433 Reported by Dan Horák. Diagnosed by Andreas Schwab in
6434 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
6435 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
6436 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
6437 it avoids undefined behavior on hosts where shifting right by more
6438 than the word width has undefined behavior.
6439
2375c96a
CY
64402012-02-19 Chong Yidong <cyd@gnu.org>
6441
6442 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
6443 (Funhandled_file_name_directory, Ffile_name_as_directory)
6444 (Fdirectory_file_name, Fexpand_file_name)
6445 (Fsubstitute_in_file_name): Protect against invalid file handler
6446 return values (Bug#10845).
6447
3eb49e71
EZ
64482012-02-18 Eli Zaretskii <eliz@gnu.org>
6449
6450 * .gdbinit (pitx): Fix incorrect references to fields of the
6451 iterator stack.
6452
7b926f3f
CY
64532012-02-17 Chong Yidong <cyd@gnu.org>
6454
6455 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
6456
11273115
PE
64572012-02-15 Paul Eggert <eggert@cs.ucla.edu>
6458
6459 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
6460 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
6461
c3a70e2b
CY
64622012-02-15 Chong Yidong <cyd@gnu.org>
6463
6464 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
6465 marked as special. Also, starting docstrings with * is obsolete.
6466
0ca43699
AS
64672012-02-13 Andreas Schwab <schwab@linux-m68k.org>
6468
6469 * gnutls.c (emacs_gnutls_write): Fix last change.
6470
2e8f3c56
LI
64712012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
6472
6473 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
6474 send_process.
6475
af70074f
SM
64762012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
6477
6478 * keymap.c (Fsingle_key_description): Handle char ranges.
6479
95986d52
CY
64802012-02-12 Chong Yidong <cyd@gnu.org>
6481
afd83bd1
CY
6482 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
6483 as that creates a dangerous corner case.
6484
95986d52
CY
6485 * window.c (Fdelete_window_internal): Invalidate the mouse
6486 highlight (Bug#9904).
6487
bd7da63e
GM
64882012-02-12 Glenn Morris <rgm@gnu.org>
6489
6490 * xselect.c (Fx_own_selection_internal)
6491 (Fx_get_selection_internal, Fx_disown_selection_internal)
6492 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
6493 * nsselect.m (Fx_own_selection_internal)
6494 (Fx_disown_selection_internal, Fx_selection_exists_p)
6495 (Fx_selection_owner_p, Fx_get_selection_internal):
6496 Sync docs and argument specs with the xselect.c versions.
6497
77abcbc2
LI
64982012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
6499
6500 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
6501
90b671e2
EZ
65022012-02-11 Eli Zaretskii <eliz@gnu.org>
6503
1c0ca0b7
EZ
6504 * w32select.c (Fx_selection_exists_p): Sync doc string and
6505 argument list with xselect.c. (Bug#10783)
6506
6507 * w16select.c (Fx_selection_exists_p): Sync doc string and
6508 argument list with xselect.c. (Bug#10783)
90b671e2 6509
49241268
GM
65102012-02-10 Glenn Morris <rgm@gnu.org>
6511
6512 * fns.c (Fsecure_hash): Doc fix.
6513
f998bbe7 65142012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
6515
6516 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
6517
0992bd9c
CY
65182012-02-07 Chong Yidong <cyd@gnu.org>
6519
6520 * buffer.c (Fbuffer_local_variables)
6521 (buffer_lisp_local_variables): Handle unbound vars correctly;
6522 don't let Qunbound leak into Lisp.
6523
af008560
GM
65242012-02-07 Glenn Morris <rgm@gnu.org>
6525
dd605cc4
GM
6526 * image.c (Fimagemagick_types): Doc fix.
6527
af008560
GM
6528 * image.c (imagemagick-render-type): Change it from a lisp object
6529 to an integer. Move the doc here from the lisp manual.
6530 Treat all values not equal to 0 the same.
6531
1449fa1d
CY
65322012-02-06 Chong Yidong <cyd@gnu.org>
6533
6534 * doc.c (store_function_docstring): Avoid applying docstring of
6535 alias to base function (Bug#2603).
6536
3723ec07
AS
65372012-02-04 Andreas Schwab <schwab@linux-m68k.org>
6538
6539 * .gdbinit (pp1, pv1): Remove redundant defines.
6540 (pr): Use pp.
6541
79c1cc1e
CY
65422012-02-04 Chong Yidong <cyd@gnu.org>
6543
6544 * nsterm.m: Declare a global (Bug#10694).
6545
d7f29f8e
EZ
65462012-02-04 Eli Zaretskii <eliz@gnu.org>
6547
cae07000
SM
6548 * w32.c (get_emacs_configuration_options):
6549 Include --enable-checking, if specified, in the return value.
d7f29f8e 6550
3b95a6f9
MR
65512012-02-04 Martin Rudalics <rudalics@gmx.at>
6552
6553 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
6554 after rounding frame sizes. (Bug#9723)
6555
d6fa96a6
EZ
65562012-02-04 Eli Zaretskii <eliz@gnu.org>
6557
6558 * keyboard.c (adjust_point_for_property): Don't position point
6559 before BEGV. (Bug#10696)
6560
df0b2940
PE
65612012-02-03 Paul Eggert <eggert@cs.ucla.edu>
6562
6563 Handle overflow when computing char display width (Bug#9496).
6564 * character.c (char_width): Return EMACS_INT, not int.
6565 (char_width, c_string_width): Check for overflow when
6566 computing the width; this is possible now that individual
6567 characters can have unbounded width. Problem introduced
6568 by merge from Emacs 23 on 2012-01-19.
6569
6bee44d6
MA
65702012-02-02 Michael Albinus <michael.albinus@gmx.de>
6571
6572 * dbusbind.c (Fdbus_register_method): Mention the return value
6573 :ignore in the docstring.
6574
44f92739
GM
65752012-02-02 Glenn Morris <rgm@gnu.org>
6576
1b9f60cc
GM
6577 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
6578
44f92739
GM
6579 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6580 Unconditionally set to t. (Bug#10673)
6581 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6582 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
6583 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
6584
c5d3843c
KH
65852012-02-02 Kenichi Handa <handa@m17n.org>
6586
6587 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
6588 0, do not call append_composite_glyph.
6589
159462d4 65902012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
6591
6592 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
6593 NULL (Bug#6988).
6594 (x_produce_glyphs): If the component of a composition is a null
6595 string, set it->pixel_width to 1 to avoid zero-width glyph.
6596
78cef877
EZ
65972012-02-01 Eli Zaretskii <eliz@gnu.org>
6598
6599 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
6600 first 2 arguments are identical. This makes inserting large
6601 output from a subprocess an order of magnitude faster on
6602 MS-Windows, where all sbrk'ed memory is always contiguous.
6603
97897668
GM
66042012-01-31 Glenn Morris <rgm@gnu.org>
6605
6606 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 6607 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
6608 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
6609
31fd3586
GM
66102012-01-29 Glenn Morris <rgm@gnu.org>
6611
6612 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
6613
0e24a8b2
CY
66142012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
6615
6616 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
6617
cc0adcb0
CY
66182012-01-28 Chong Yidong <cyd@gnu.org>
6619
6620 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
6621
acc28cb9
CY
66222012-01-26 Chong Yidong <cyd@gnu.org>
6623
9c69cfb7
CY
6624 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
6625
acc28cb9
CY
6626 * search.c (Fsearch_forward, Fsearch_backward): Document negative
6627 repeat counts (Bug#10507).
6628
48da7392
GM
66292012-01-26 Glenn Morris <rgm@gnu.org>
6630
6631 * lread.c (syms_of_lread): Doc fix.
6632
14af5f7f
CY
66332012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
6634
6635 * coding.c (encode_designation_at_bol): Change return value to
6636 EMACS_INT.
6637
0b21c100
CY
66382012-01-25 Chong Yidong <cyd@gnu.org>
6639
6640 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
6641
3c2907f7
CY
66422012-01-21 Chong Yidong <cyd@gnu.org>
6643
6644 * floatfns.c (Fcopysign): Make the second argument non-optional,
6645 since nil is not allowed anyway.
6646
959ad23f
AS
66472012-01-21 Andreas Schwab <schwab@linux-m68k.org>
6648
6649 * process.c (read_process_output): Use p instead of XPROCESS (proc).
6650 (send_process): Likewise.
6651
34a02f46
MR
66522012-01-19 Martin Rudalics <rudalics@gmx.at>
6653
6654 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
6655 (Vwindow_persistent_parameters): Do not use Qstate.
6656 Rewrite doc-strings.
34a02f46 6657
1259009a 66582012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
6659
6660 * character.c (char_width): New function.
70d4fdf6
GM
6661 (Fchar_width, c_string_width, lisp_string_width):
6662 Use char_width (Bug#9496).
25ed9e61 6663
6a6ee00d
MR
66642012-01-16 Martin Rudalics <rudalics@gmx.at>
6665
6666 * window.c (Vwindow_persistent_parameters): New variable.
6667 (Fset_window_configuration, save_window_save): Handle persistent
6668 window parameters.
6669
c85efaf7
EZ
66702012-01-14 Eli Zaretskii <eliz@gnu.org>
6671
6672 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
6673 thrashing the stack of the thread. (Bug#9087)
6674
5944709e
PE
66752012-01-12 Paul Eggert <eggert@cs.ucla.edu>
6676
6677 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
6678
e71f5d99
EZ
66792012-01-11 Eli Zaretskii <eliz@gnu.org>
6680
6681 * xdisp.c (rows_from_pos_range): Handle the case where the
6682 highlight ends on a newline. (Bug#10464)
6683 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
6684 he end column for display of highlight that ends on a newline
6685 before a R2L line.
6686
ce316182
GM
66872012-01-11 Glenn Morris <rgm@gnu.org>
6688
6689 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
6690 from load-path also when installation-directory is nil. (Bug#10208)
6691
5b43da69
GM
66922012-01-10 Glenn Morris <rgm@gnu.org>
6693
74cc8ff9
GM
6694 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
6695
7d8d6e4e
GM
6696 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
6697 Update template values to be closer to their typical values these days.
5b43da69 6698
a0db8d43
EZ
66992012-01-09 Eli Zaretskii <eliz@gnu.org>
6700
6701 * xdisp.c (rows_from_pos_range): Accept additional argument
6702 DISP_STRING, and accept any glyph in a row whose object is that
6703 string as eligible for mouse highlight. Fixes mouse highlight of
6704 display strings from overlays. (Bug#10464)
6705
9a0115ab 67062012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 6707
b9110d6a 6708 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
6709 * fileio.c (auto_saving_dir_umask): New static var.
6710 (Fmake_directory_internal): Use it.
6711 (do_auto_save_make_dir): Set it, instead of invoking chmod after
6712 creating the directory. The old code temporarily assigns
6713 too-generous permissions to the directory.
6714 (do_auto_save_eh): Clear it.
b9110d6a 6715 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
6716 that the var is always cleared.
6717
6c1bd3f3
EZ
67182012-01-07 Eli Zaretskii <eliz@gnu.org>
6719
6720 * search.c (scan_buffer): Pass character positions to
6721 know_region_cache, not byte positions. (Bug#6540)
6722
069d2b50
L
67232012-01-07 LynX <_LynX@bk.ru> (tiny change)
6724
6725 * w32.c (sys_rename): Report EXDEV when rename of a directory
6726 fails because the target is on another logical disk. (Bug#10284)
6727
75bf0d33
DB
67282012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
6729
6730 * xterm.c (x_embed_request_focus): New function.
6731
6732 * xterm.h: Add prototype.
6733
6734 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
6735
1c6e5a32
GM
67362012-01-05 Glenn Morris <rgm@gnu.org>
6737
6738 * emacs.c (emacs_copyright): Update short copyright year to 2012.
6739
651e947e
EZ
67402012-01-01 Eli Zaretskii <eliz@gnu.org>
6741
6742 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
6743 Load gnutls_transport_set_lowat only if GnuTLS version is below
6744 2.11.1.
6745 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
6746 GnuTLS versions below 2.11.1.
6747
3778cdd8
AL
67482011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
6749
6750 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
6751 to the doc string advising against its use for altering the way
6752 windows are scrolled.
6753
0e5317f7
KH
67542011-12-28 Kenichi Handa <handa@m17n.org>
6755
6756 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
6757 coding-system ASCII compatible only when it does not produce BOM
6758 on encoding (Bug#10383).
6759
93d5ca1f
JD
67602011-12-26 Jan Djärv <jan.h.d@swipnet.se>
6761
6762 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
6763 can scroll.
6764 (create_and_show_popup_menu): Always use menu_position_func for
6765 Gtk3 (Bug#10361).
6766
ca22b785
AS
67672011-12-24 Andreas Schwab <schwab@linux-m68k.org>
6768
6769 * callint.c (Fcall_interactively): Don't truncate prompt string.
6770
d048e1e6
EZ
67712011-12-23 Eli Zaretskii <eliz@gnu.org>
6772
6773 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
6774 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 6775 resumed from there (after widening). (Bug#10360)
d048e1e6 6776
5ccaba1f
JD
67772011-12-22 Jan Djärv <jan.h.d@swipnet.se>
6778
6779 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
6780
204ee57f
JD
67812011-12-21 Jan Djärv <jan.h.d@swipnet.se>
6782
b81d40f0
JB
6783 * nsterm.m (x_free_frame_resources):
6784 Release f->output_data.ns->miniimage.
204ee57f
JD
6785 (ns_index_color): Fix indentation. Do not retain
6786 color_table->colors[i].
6787
6788 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
6789 before returning.
6790
6791 * nsfns.m (x_set_background_color): Assign return value from
6792 ns_index_color to face-background instead of NSColor*.
6793 (ns_implicitly_set_icon_type): Fix indentation.
6794 Change assignment in for loop to comparison.
6795
6796 * emacs.c (ns_pool): New variable.
6797 (main): Assign ns_pool.
6798 (Fkill_emacs): Call ns_release_autorelease_pool.
6799
6800 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
6801 autorelease fdesc, release fdAttrs and tdict.
6802 (ns_get_covering_families): Release charset.
6803 (ns_findfonts): Release NSFontDescriptor created with new.
6804 (ns_uni_to_glyphs): Fix indentation.
6805 (setString): Release attrStr before assigning new value.
6806
c803b2b7
JD
68072011-12-18 Jan Djärv <jan.h.d@swipnet.se>
6808
678f4426
JD
6809 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
6810 and NS_IMPL_COCOA.
6811 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
6812 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
6813
cd394be1 68142011-12-18 David Reitter <reitter@cmu.edu>
678f4426 6815
5fecd5fc
JD
6816 * nsterm.m (ns_term_init): Subscribe for notifications
6817 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
6818 to method trackingNotification in EmacsMenu.
6819
6820 * nsmenu.m (trackingMenu): New variable.
3771cb17 6821 (trackingNotification): New method (from Aquamacs).
5fecd5fc 6822 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 6823 from Aquamacs (Bug#7030).
678f4426
JD
6824
68252011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 6826
c803b2b7
JD
6827 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
6828 (symbol_to_nsstring): Fix indentation.
6829 (ns_symbol_to_pb): New function.
cae07000
SM
6830 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
6831 (Fns_rotate_cut_buffers_internal): Remove.
6832 (Fns_store_selection_internal): Rename from
c803b2b7
JD
6833 Fns_store_cut_buffer_internal.
6834 (ns_get_foreign_selection, Fx_own_selection_internal)
6835 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
6836 (Fns_get_selection_internal, Fns_store_selection_internal):
6837 Use ns_symbol_to_pb and check if return value is nil.
6838 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
6839 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
6840 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
6841 renamed to Sns_store_selection_internal.
6842 (ns_handle_selection_request): Move code to Fx_own_selection_internal
6843 and remove this function.
6844 (ns_handle_selection_clear): Remove, never used.
6845 (Fx_own_selection_internal): Move code from ns_handle_selection_request
6846 here.
6847
e1b01a3a
KB
68482011-12-17 Ken Brown <kbrown@cornell.edu>
6849
6850 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
6851 GID is unknown (Bug#10257).
6852
2adb6e85
PE
68532011-12-17 Paul Eggert <eggert@cs.ucla.edu>
6854
6855 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
6856 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
6857 which caused a build failure on GNU/Linux IA-64. This problem was
6858 introduced by my 2011-10-07 patch.
6859
d1d7b339
JL
68602011-12-15 Juri Linkov <juri@jurta.org>
6861
6862 * image.c (imagemagick_error): New function. (Bug#10112)
6863 (imagemagick_load_image): Comment out `MagickSetResolution' call.
6864 Use `imagemagick_error' where ImageMagick functions return
6865 `MagickFalse'.
6866 (Fimagemagick_types): Add `Fnreverse' to return the list in the
6867 proper order.
6868
100d5755
KH
68692011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6870
6871 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
6872 fill background (Bug#8992).
6873
454592a6
MR
68742011-12-13 Martin Rudalics <rudalics@gmx.at>
6875
6876 * window.c (Vwindow_combination_resize)
6877 (Vwindow_combination_limit): Use t instead of non-nil in
6878 doc-strings.
61d4b438
MR
6879 (Vrecenter_redisplay): Add first sentence of doc-string on
6880 separate line.
53524d93 6881 (Frecenter): Fix doc-string typo.
454592a6 6882
3633e3aa
KH
68832011-12-11 Kenichi Handa <handa@m17n.org>
6884
6885 * coding.c (Funencodable_char_position): Pay attention to the
6886 buffer text relocation (Bug#9389).
6887
7b9d523a 68882011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 6889
7b9d523a
JD
6890 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
6891 gtk_init (Bug#10100).
6892
b73189c6
EZ
68932011-12-10 Eli Zaretskii <eliz@gnu.org>
6894
6895 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
6896 IT->string is nil. (Bug#10263)
6897
f7dfe5d6
JD
68982011-12-10 Jan Djärv <jan.h.d@swipnet.se>
6899
83faebb4
JD
6900 * nsterm.h (x_free_frame_resources): Declare.
6901
f7dfe5d6
JD
6902 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
6903 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
6904
6905 * nsterm.h (ns_get_defaults_value): Declare.
6906
6907 * nsterm.m (ns_default): Call ns_get_defaults_value.
6908
7cd4e72c
EZ
69092011-12-09 Eli Zaretskii <eliz@gnu.org>
6910
6911 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
6912 (Bug#10170)
6913
b34d7317
YM
69142011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6915
6916 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
6917 that where the value of an _OBJC_* symbol points to is in the .bss
6918 section (Bug#10240).
6919
76470ad1
KH
69202011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6921
6922 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 6923 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 6924
745fff94
KH
69252011-12-08 Kenichi Handa <handa@m17n.org>
6926
6927 * ftfont.c (get_adstyle_property): Fix previous change
6928 (Bug#10233).
6929
6e44397c
JB
69302011-12-07 Juanma Barranquero <lekktu@gmail.com>
6931
6932 * w32.c (init_environment): If no_site_lisp, remove site-lisp
6933 dirs from the default value of EMACSLOADPATH (bug#10208).
6934
7efa6272
GM
69352011-12-07 Glenn Morris <rgm@gnu.org>
6936
6937 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
6938 installation and source directories as well. (Bug#10208)
6939
f6fc4d87
CY
69402011-12-06 Chong Yidong <cyd@gnu.org>
6941
6942 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
6943
2bf26180
GM
69442011-12-06 Glenn Morris <rgm@gnu.org>
6945
6946 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
6947 as an error, not just -1. (Bug#10217)
6948
3a6ad4f0
CY
69492011-12-05 Chong Yidong <cyd@gnu.org>
6950
6951 * keyboard.c (process_special_events): New function.
6952 (swallow_events, Finput_pending_p): Use it (Bug#10195).
6953
75a3b399
PE
69542011-12-05 Paul Eggert <eggert@cs.ucla.edu>
6955
6956 * coding.c (encode_designation_at_bol): Don't use uninitialized
6957 local variable (Bug#9318).
6958
c3c9e25e
KH
69592011-12-05 Kenichi Handa <handa@m17n.org>
6960
6961 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
6962 return Qnil (Bug#8046, Bug#10193).
6963
5eb05ea3
KH
69642011-12-05 Kenichi Handa <handa@m17n.org>
6965
6966 * coding.c (encode_designation_at_bol): New args charbuf_end and
6967 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
6968 (coding_set_source): Return how many bytes coding->source was
6969 relocated.
6970 (coding_set_destination): Return how many bytes
6971 coding->destination was relocated.
6972 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 6973 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
6974
69752011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6976
6977 * coding.c (CODING_CHAR_CHARSET_P): New macro.
6978 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
6979 macro (Bug#9318).
6980
69812011-12-05 Andreas Schwab <schwab@linux-m68k.org>
6982
6983 The following changes are to fix Bug#9318.
6984
a79703f5 6985 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
6986 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
6987 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 6988 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 6989
7dbda6df
JB
69902011-12-05 Juanma Barranquero <lekktu@gmail.com>
6991
6992 * lisp.h (process_quit_flag): Fix external declaration.
6993
6d5eb5b0
SM
69942011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
6995
6996 Don't macro-inline non-performance-critical code.
6997 * eval.c (process_quit_flag): New function.
6998 * lisp.h (QUIT): Use it.
6999
a0c3fad0
JD
70002011-12-04 Jan Djärv <jan.h.d@swipnet.se>
7001
7002 * nsfns.m (get_geometry_from_preferences): New function.
7003 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
7004
6c07aac2
AS
70052011-12-04 Andreas Schwab <schwab@linux-m68k.org>
7006
7007 * emacs.c (Qkill_emacs): Define.
7008 (syms_of_emacs): Initialize it.
7009 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
7010 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
7011 (quit_throw_to_read_char): Add parameter `from_signal'.
7012 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
7013 * lisp.h (QUIT): Call Fkill_emacs if requested.
7014
c052ead4
JD
70152011-12-03 Jan Djärv <jan.h.d@swipnet.se>
7016
7017 * widget.c (update_wm_hints): Return if wmshell is null.
7018 (widget_update_wm_size_hints): New function.
7019
7020 * widget.h (widget_update_wm_size_hints): Declare.
7021
7022 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
7023 widget_update_wm_size_hints (Bug#10104).
7024
9e49252b
EZ
70252011-12-03 Eli Zaretskii <eliz@gnu.org>
7026
7027 * xdisp.c (handle_invisible_prop): If the invisible text ends just
7028 before a newline, prepare the bidi iterator for consuming the
7029 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 7030 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 7031
02b16839
JL
70322011-12-02 Juri Linkov <juri@jurta.org>
7033
7034 * search.c (Fword_search_regexp): New Lisp function created from
7035 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
7036 (Fword_search_backward, Fword_search_forward)
7037 (Fword_search_backward_lax, Fword_search_forward_lax):
7038 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
7039 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
7040
0068070e
SM
70412011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
7042
7043 * fileio.c (Finsert_file_contents): Move after-change-function call
7044 to before the "handled:" label, since all "goto handled" appear in
7045 cases where the *-change-functions have already been properly called
7046 (bug#10117).
7047
3360a3fc
AS
70482011-12-01 Andreas Schwab <schwab@linux-m68k.org>
7049
7050 * keyboard.c (interrupt_signal): Don't call kill-emacs when
7051 waiting for input. (Bug#10169)
7052
73d6c093
EZ
70532011-11-30 Eli Zaretskii <eliz@gnu.org>
7054
7055 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
7056 verifies glyph row's hash code--we have just reallocated the
7057 glyphs, so their contents can be complete garbage. (Bug#10164)
7058
febe6bea
JB
70592011-11-30 Juanma Barranquero <lekktu@gmail.com>
7060
7061 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
7062
801a4313
EZ
70632011-11-30 Eli Zaretskii <eliz@gnu.org>
7064
7065 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
7066 attributes are tested _before_ calling verify_row_hash, to protect
7067 against GCC re-ordering of the tests. (Bug#10164)
7068
2b56b87e
JD
70692011-11-29 Jan Djärv <jan.h.d@swipnet.se>
7070
7071 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
7072
7073 * xterm.c (handle_one_xevent): Only set async_visible and friends
7074 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 7075 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
7076 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
7077
dbf31225
PE
70782011-11-28 Paul Eggert <eggert@cs.ucla.edu>
7079
7080 Remove GCPRO-related macros that exist only to avoid shadowing locals.
7081 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
7082 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
7083 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
7084 All uses changed to use GCPRO1 etc.
7085 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
7086 Revert to old implementation (i.e., before 2011-03-11).
7087
1305621b
YM
70882011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7089
7090 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
7091 of scroll runs so as to avoid assigning disabled bogus rows and
7092 unnecessary graphics copy operations.
7093
8c9afb46
EZ
70942011-11-27 Eli Zaretskii <eliz@gnu.org>
7095
7096 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
7097 (snprintf) [_MSC_VER]: Redirect to _snprintf.
7098 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
7099 (malloc, free, realloc, calloc): Redirect to e_* only when
7100 compiling Emacs.
7101
7102 * lisp.h (GCTYPEBITS): Move before first use.
7103 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
7104 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
7105 this macro definition.
7106
7107 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
7108 _MSC_VER.
7109
54e9e3bf
JD
71102011-11-27 Jan Djärv <jan.h.d@swipnet.se>
7111
6d5eb5b0
SM
7112 * gtkutil.c (xg_create_frame_widgets):
7113 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
7114 present with Gtk+ 2.0.
7115
83aca1cb
PE
71162011-11-26 Paul Eggert <eggert@cs.ucla.edu>
7117
7118 * fileio.c (Finsert_file_contents): Undo previous change; see
7119 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
7120
5b76caa4
PE
71212011-11-26 Paul Eggert <eggert@cs.ucla.edu>
7122
7123 Rename locals to avoid shadowing.
7124 * fileio.c (Finsert_file_contents):
7125 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
7126 * process.c (wait_reading_process_output):
7127 Rename inner 'proc' to 'p' to avoid shadowing.
7128 Indent for consistency with usual Emacs style.
7129
8c535114
EZ
71302011-11-25 Eli Zaretskii <eliz@gnu.org>
7131
7132 * xdisp.c (redisplay_window): If cursor row is not fully visible
7133 after recentering, and scroll-conservatively is set to a large
7134 number, scroll window by a few more lines to make the cursor fully
7135 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
7136 (start_display): Don't move to the next line if the display should
7137 start at a newline that is part of a display vector or an overlay
7138 string. (Bug#10119)
8c535114 7139
fa4fdb5c
JL
71402011-11-24 Juri Linkov <juri@jurta.org>
7141
7142 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
7143 after the `MagickPingImage' call. (Bug#10112)
7144
90ec88df
CY
71452011-11-23 Chong Yidong <cyd@gnu.org>
7146
7147 * window.c (Fcoordinates_in_window_p): Accept only live windows.
7148
56e2e794
MR
71492011-11-23 Martin Rudalics <rudalics@gmx.at>
7150
7151 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
7152 making another buffer current. (Bug#10114)
7153
b6e64c41
GM
71542011-11-23 Glenn Morris <rgm@gnu.org>
7155
7156 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
7157
6b21de18
CY
71582011-11-23 Chong Yidong <cyd@gnu.org>
7159
7160 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
7161 using it (Bug#5984).
7162
b12cd789
EZ
71632011-11-22 Eli Zaretskii <eliz@gnu.org>
7164
7165 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
7166 and header-lines, as they don't have one computed for them.
7167 (Bug#10098)
7168
7169 * .gdbinit (prow): Make displayed values more self-explaining.
7170 Add row's hash code.
7171
261b6fd4
LMI
71722011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
7173
7174 * process.c (wait_reading_process_output): Fix asynchrounous
7175 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 7176 (wait_reading_process_output): Add comment and URL.
261b6fd4 7177
e7cfd277
JD
71782011-11-21 Jan Djärv <jan.h.d@swipnet.se>
7179
7180 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
7181
a9b9b7f5
CY
71822011-11-21 Chong Yidong <cyd@gnu.org>
7183
7184 * window.c (Fnext_window, Fprevious_window): Doc fix.
7185
b0d15b4f
SM
71862011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
7187
7188 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
7189
fe7a3057
JB
71902011-11-20 Juanma Barranquero <lekktu@gmail.com>
7191
7192 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
7193
d2999b1a
MR
71942011-11-20 Martin Rudalics <rudalics@gmx.at>
7195
7196 * window.c (Fset_window_combination_limit): Rename argument
7197 STATUS to LIMIT.
7198 (Vwindow_combination_limit): Remove "status" from doc-string.
7199
d5ff9cd0
AS
72002011-11-20 Andreas Schwab <schwab@linux-m68k.org>
7201
7202 * m/ibms390.h: Remove.
7203 * m/ibms390x.h: Don't include "ibms390.h".
7204
a5bb9bd3
SM
72052011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
7206
7207 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
7208 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
7209
cd1181db
JB
72102011-11-20 Juanma Barranquero <lekktu@gmail.com>
7211
7212 * casetab.c (Fset_case_table):
7213 * charset.c (Fcharset_after): Fix typos.
7214
615a3b8d 72152011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 7216
17e845af
PE
7217 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
7218 Otherwise, valgrind does not work on some platforms.
7219 Problem reported by Andreas Schwab in
6a0bf43d
PE
7220 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
7221 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
7222 is set, removing the need for VIRT_ADDRESS_VARIES.
7223 (PURE_P): Use a more-efficient implementation that needs just one
7224 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
7225 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
7226 to 4 (xorl, subq, cmpq, setbe).
7227 * alloc.c (pure): Always extern now, since that's the
7228 VIRT_ADDR_VARIES behavior.
7229 (PURE_POINTER_P): Use a single comparison, not two, for
7230 consistency with the new puresize.h.
7231 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
7232 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
7233 Remove VIRT_ADDR_VARIES no longer needed.
7234
f8fe6f96
EZ
72352011-11-19 Eli Zaretskii <eliz@gnu.org>
7236
7237 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
7238 (erase_phys_cursor, update_window_cursor, show_mouse_face)
7239 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
7240 behave as if the cursor position were at the window margin.
7241
7242 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
7243 and the cursor position is out of bounds, behave as if the cursor
7244 position were at the window margin. (Bug#10075)
7245
df05a53c
CY
72462011-11-18 Chong Yidong <cyd@gnu.org>
7247
7248 * window.c (Fwindow_combination_limit): Make first argument
7249 non-optional, since it is meaningless for live windows like the
7250 selected window.
61ccba97 7251
2071918e
DA
72522011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
7253
7254 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
7255
b50a28de
SM
72562011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
7257
7258 * intervals.c: Fix grafting over the whole buffer (bug#10071).
7259 (graft_intervals_into_buffer): Simplify.
7260
015137db
EZ
72612011-11-18 Eli Zaretskii <eliz@gnu.org>
7262
7263 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
7264 hash values of the two rows.
7265 (copy_row_except_pointers): Preserve the used[] arrays and the
7266 hash values of the two rows. (Bug#10035)
68c95424 7267 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
7268
7269 * xdisp.c (row_hash): New function, body extracted from
7270 compute_line_metrics.
7271 (compute_line_metrics): Call row_hash, instead of computing the
7272 hash code inline.
7273
7274 * dispnew.c (verify_row_hash): Call row_hash for computing the
7275 hash code of a row, instead of duplicating code from xdisp.c.
7276
7277 * dispextern.h (row_hash): Add prototype.
7278
a2addb04
TH
72792011-11-18 Tassilo Horn <tassilo@member.fsf.org>
7280
7281 * frame.c (delete_frame): Don't delete the terminal when the last
7282 X frame is closed if emacs is built with GTK toolkit.
7283
df85d315
JB
72842011-11-17 Juanma Barranquero <lekktu@gmail.com>
7285
7286 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
7287
a0c2d0ae
MR
72882011-11-17 Martin Rudalics <rudalics@gmx.at>
7289
7290 * window.c (Vwindow_splits): Rename to
7291 Vwindow_combination_resize. Suggested by Juri Linkov.
7292 (Fsplit_window_internal): Use Vwindow_combination_resize instead
7293 of Vwindow_splits.
7294
58179cce
JB
72952011-11-16 Juanma Barranquero <lekktu@gmail.com>
7296
7877f373
JB
7297 * nsfns.m (Fns_font_name):
7298 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 7299
b6f67890
MR
73002011-11-16 Martin Rudalics <rudalics@gmx.at>
7301
7302 * window.h (window): Rename slot "nest" to "combination_limit".
7303 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
7304 (Fset_window_nest): Rename to Fset_window_combination_limit.
7305 (Vwindow_nest): Rename to Vwindow_combination_limit.
7306 (recombine_windows, make_parent_window, make_window)
7307 (Fsplit_window_internal, saved_window)
7308 (Fset_window_configuration, save_window_save): Rename all
7309 occurrences of window_nest to window_combination_limit.
7310
c7015153
JB
73112011-11-15 Juanma Barranquero <lekktu@gmail.com>
7312
7313 * image.c (imagemagick_load_image): Fix typo.
7314
322ad6ec
EZ
73152011-11-14 Eli Zaretskii <eliz@gnu.org>
7316
7317 * xdisp.c (display_line): Move the call to
7318 highlight_trailing_whitespace before the call to
7319 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
7320 faces of all the glyphs to compute ROW's hash value.
7321 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 7322
f067b8ec
JB
73232011-11-14 Juanma Barranquero <lekktu@gmail.com>
7324
7325 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
7326 just return (bug#10044).
7327
1e5b2111
EZ
73282011-11-12 Eli Zaretskii <eliz@gnu.org>
7329
7ef3cbd5
EZ
7330 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
7331 with user-defined heap size. Bump the default size of the temacs
7332 heap to 27MB, to avoid memory warning when running temacs.
7333 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
7334
1e5b2111
EZ
7335 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
7336 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
7337 (verify_row_hash) [XASSERTS]: New function.
7338 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
7339 that the hash value of glyph rows is correct.
1e5b2111 7340
89d61221
MR
73412011-11-12 Martin Rudalics <rudalics@gmx.at>
7342
7343 * window.h (window): Remove splits slot.
7344 * window.c (Fwindow_splits, Fset_window_splits): Remove.
7345 (Fdelete_other_windows_internal, make_parent_window)
7346 (make_window, Fsplit_window_internal, Fdelete_window_internal)
7347 (Fset_window_configuration, save_window_save): Don't deal with
7348 split status of windows.
7349 (saved_window): Remove splits slot.
7350 (Vwindow_splits): Rewrite doc-string.
7351
97f18cc8
JD
73522011-11-11 Jan Djärv <jan.h.d@swipnet.se>
7353
7354 * xfns.c (unwind_create_frame):
7355 * nsfns.m (unwind_create_frame):
7356 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
7357 Vframe_list (Bug#9999).
7358
22a648b4
DA
73592011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
7360
0b381c7e 7361 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 7362
659afede
KH
73632011-11-11 Kenichi Handa <handa@m17n.org>
7364
7365 * callproc.c (Fcall_process): Set the member dst_multibyte of
7366 process_coding.
7367
9ac0394b
KH
73682011-11-11 Johan Bockgård <bojohan@gnu.org>
7369
7370 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
7371 avoid a crash (bug#9496).
7372
2fbdc249
CY
73732011-11-09 Chong Yidong <cyd@gnu.org>
7374
7375 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
7376 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
7377
ac6b1f81
PE
73782011-11-08 Paul Eggert <eggert@cs.ucla.edu>
7379
7380 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
7381
09db192c
PE
73822011-11-08 Paul Eggert <eggert@cs.ucla.edu>
7383
7384 Avoid some portability problems by eschewing 'extern inline' functions.
7385 The trivial performance wins aren't worth the portability hassles; see
7386 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
7387 et seq.
7388 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
7389 (window_box_width, window_box_left, window_box_left_offset)
7390 (window_box_right, window_box_right_offset): Undo previous change,
7391 by removing the "extern"s.
7392 * intervals.c (adjust_intervals_for_insertion)
7393 (adjust_intervals_for_deletion): Undo previous change,
7394 making these static again.
7395 (offset_intervals, temp_set_point_both, temp_set_point)
7396 (copy_intervals_to_string): No longer inline.
7397 * xdisp.c (window_text_bottom_y, window_box_width)
7398 (window_box_height, window_box_left_offset)
7399 (window_box_right_offset, window_box_left, window_box_right)
7400 (window_box): No longer inline.
7401
105216ed
CY
74022011-11-08 Chong Yidong <cyd@gnu.org>
7403
7404 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
7405 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
7406 Signal an error if not a live window.
105216ed
CY
7407 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
7408 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
7409
ae9e237f
JB
74102011-11-07 Juanma Barranquero <lekktu@gmail.com>
7411
7412 * lisp.h (syms_of_abbrev): Remove declaration.
7413 Reported by CHENG Gao <chenggao@royau.me>.
7414
c7aa8333
EZ
74152011-11-07 Eli Zaretskii <eliz@gnu.org>
7416
7417 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
7418 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
7419 of temacs in GUI mode.
7420
be7f5545
MR
74212011-11-07 Martin Rudalics <rudalics@gmx.at>
7422
7423 * window.h: Declare delete_all_child_windows instead of
7424 delete_all_subwindows.
7425 * window.c (Fwindow_nest, Fset_window_nest)
7426 (Fset_window_new_total, Fset_window_new_normal)
7427 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
7428 (delete_all_subwindows): Rename to delete_all_child_windows.
7429 (Fdelete_other_windows_internal, Fset_window_configuration):
7430 Call delete_all_child_windows instead of delete_all_subwindows.
7431 * frame.c (delete_frame): Call delete_all_child_windows instead
7432 of delete_all_subwindows.
7433
ca78dc43
PE
74342011-11-07 Paul Eggert <eggert@cs.ucla.edu>
7435
7436 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
7437 This is also needed for porting to any host where GC_MARK_STACK is
7438 not GC_MAKE_GCPROS_NOOPS.
7439 (which_symbols): Use it.
7440
a0241d01
KH
74412011-11-07 Kenichi Handa <handa@m17n.org>
7442
7443 * coding.c (coding_set_destination): Check coding->src_pos only
7444 when coding->src_object is a buffer (bug#9910).
7445
7446 * process.c (send_process): Set the member src_multibyte of coding
7447 to 0 (bug#9911) when sending a unibyte text.
7448
7449 * callproc.c (Fcall_process): Set the member src_multibyte of
7450 process_coding to 0 (bug#9912).
7451
a64bfdfa 74522011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
7453
7454 * xmenu.c (cleanup_widget_value_tree): New function.
7455 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
7456 calling free_menubar_widget_value_tree directly (Bug#9830).
7457
cb41b32a
PE
74582011-11-06 Paul Eggert <eggert@cs.ucla.edu>
7459
7460 Fix some portability problems with 'inline'.
7461 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
7462 (window_box_width, window_box_left, window_box_left_offset)
7463 (window_box_right, window_box_right_offset): Declare extern.
7464 Otherwise, these inline functions do not conform to C99 and
7465 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
7466 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
7467 * intervals.c (adjust_intervals_for_insertion)
7468 (adjust_intervals_for_deletion): Now extern, because otherwise the
7469 extern inline functions 'offset_intervals' couldn't refer to it.
7470 (static_offset_intervals): Remove.
7471 (offset_intervals): Rewrite using the old contents of
7472 static_offset_intervals. The old version didn't conform to C99
7473 because an extern inline function contained a reference to an
7474 identifier with static linkage.
7475
b7041366
AS
74762011-11-06 Andreas Schwab <schwab@linux-m68k.org>
7477
7478 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
7479 GC.
7480
88a37c4d
EZ
74812011-11-06 Eli Zaretskii <eliz@gnu.org>
7482
7483 * xdisp.c (init_iterator, reseat_to_string): Don't set the
7484 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
7485 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
7486 return Qleft_to_right.
7487
49745b39
CY
74882011-11-06 Chong Yidong <cyd@gnu.org>
7489
7490 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
7491 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
7492 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
7493 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
7494 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
7495 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
7496 (Fwindow_vscroll): Doc fix.
7497 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
7498 argument, since it makes no sense to pass a live window and for
7499 consistency with window-child.
7500
1f05cd82
CS
75012011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
7502
7503 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
7504 support MSVC.
7505
22610910
JR
75062011-11-05 Jason Rumney <jasonr@gnu.org>
7507
7508 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
7509 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
7510 fonts (Bug#6029).
7511 (add_font_entity_to_list): Fix logic errors in mixed boolean and
7512 bitwise arithmetic preventing use of unicode-sip and non-truetype
7513 opentype fonts.
7514
a06776b2
EZ
75152011-11-05 Eli Zaretskii <eliz@gnu.org>
7516
3ad924ba
EZ
7517 * s/ms-w32.h (fstat, stat, utime): Move redirections to
7518 "emacs"-only part.
7519
a06776b2
EZ
7520 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
7521 initialization code to keep similarity to xfns.c after changes
7522 from 2011-11-05.
7523
c9e7db78
JD
75242011-11-05 Jan Djärv <jan.h.d@swipnet.se>
7525
a97f8f3f
JD
7526 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
7527 (unwind_create_frame): New function (Bug#9943).
7528 (Fx_create_frame): Restructure code to be more similar to the one in
7529 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
7530 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
7531 Move terminal->reference_count++ just before making the frame official
7532 (Bug#9943).
7533
7534 * nsterm.m (x_free_frame_resources): New function.
7535 (x_destroy_window): Move code to x_free_frame_resources.
7536
c9e7db78 7537 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
7538 (Fx_create_frame, x_create_tip_frame):
7539 Move terminal->reference_count++ just before making the frame
75f1671a 7540 official. Move initialization of image_cache_refcount and
c9e7db78
JD
7541 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
7542
a6fc3b5c
EZ
75432011-11-05 Eli Zaretskii <eliz@gnu.org>
7544
7545 Support MSVC build with newer versions of Visual Studio.
7546 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
7547 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
7548 nt/gmake.defs.
7549
7550 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
7551 which are not supported by MSVC.
7552 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
7553 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
7554 bitfields.
7555 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
7556 types in bitfields.
7557 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
7558
7559 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
7560
58179cce 75612011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
7562
7563 Support MSVC build with newer versions of Visual Studio.
7564 * w32.c: Don't include w32api.h for MSVC.
7565 (init_environment) [_MSC_VER]: Call sys_access, not _access.
7566
7567 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
7568 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
7569 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
7570 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
7571 e_* cousins.
7572 (alloca) [_MSC_VER]: Define to _alloca.
7573
7574 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
7575
7576 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
7577
a58c13ed
EZ
75782011-11-04 Eli Zaretskii <eliz@gnu.org>
7579
7580 * xdisp.c (note_mouse_highlight): If either of
7581 previous/next-single-property-change returns nil, treat that as
7582 the beginning or the end of the buffer. (Bug#9955)
7583
fe0b6370
JD
75842011-11-04 Jan Djärv <jan.h.d@swipnet.se>
7585
a58c13ed 7586 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
7587 label is not null (Bug#9951).
7588 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
7589 may be NULL.
7590
89bd5ee1
EZ
75912011-11-04 Eli Zaretskii <eliz@gnu.org>
7592
7593 * window.c (Fwindow_body_size): Mention in the doc string that the
7594 return value is in frame's canonical units. (Bug#9949)
7595
84c3edb9
EZ
75962011-11-03 Eli Zaretskii <eliz@gnu.org>
7597
4e2fb5c7
EZ
7598 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
7599
84c3edb9 7600 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 7601 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 7602 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 7603
bc17a887
EZ
76042011-11-01 Eli Zaretskii <eliz@gnu.org>
7605
7606 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
7607 Don't stop backward scan on the continuation glyph, even though
7608 its CHARPOS is positive.
6d5eb5b0
SM
7609 (mouse_face_from_buffer_pos, note_mouse_highlight):
7610 Rename cover_string to disp_string.
bc17a887 7611
4ee88440
MR
76122011-11-01 Martin Rudalics <rudalics@gmx.at>
7613
7614 * window.c (temp_output_buffer_show): Don't use
7615 Vtemp_buffer_show_specifiers.
7616 (Vtemp_buffer_show_specifiers): Remove unused variable.
7617
c2ff3c02
EZ
76182011-10-30 Eli Zaretskii <eliz@gnu.org>
7619
7620 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
7621 past the beginning of the current glyph matrix.
7622
58179cce 76232011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
7624
7625 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
7626 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
7627 HAVE_GTK3 (Bug#9869).
b77a6a7f 7628
3b574623
JD
7629 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
7630 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
7631
b77a6a7f
JD
7632 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
7633
7634 * xterm.c: Declare x_handle_net_wm_state to return int.
7635 (handle_one_xevent): Check if we are iconified but don't have
7636 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
7637 (get_current_wm_state): Return non-zero if not hidden,
7638 check for _NET_WM_STATE_HIDDEN (Bug#9893).
7639 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
7640 (x_handle_net_wm_state): Return what get_current_wm_state returns.
7641 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
7642
196e41e4
PE
76432011-10-29 Paul Eggert <eggert@cs.ucla.edu>
7644
7645 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
7646 so that this new function doesn't get optimized away by a
7647 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
7648
021f2e1a
AS
76492011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7650
7651 * frame.h (MOUSE_HL_INFO): Remove excess parens.
7652
8b058d44
EZ
76532011-10-29 Eli Zaretskii <eliz@gnu.org>
7654
7655 Fix the `xbytecode' command.
7656 * .gdbinit (xprintbytestr): New command.
b50a28de 7657 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
7658 (xbytecode): Print the byte-code string as well.
7659
4452fb80
EZ
76602011-10-29 Kim Storm <storm@cua.dk>
7661
8b058d44
EZ
7662 * alloc.c (which_symbols): New function.
7663
21b72067
AS
76642011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7665
7666 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
7667 line. (Bug#9903)
7668
83ed7b5c
GM
76692011-10-29 Glenn Morris <rgm@gnu.org>
7670
7671 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
7672 Not clear what it was for, and it causes various bugs. (Bug#9839)
7673
5a7a728b
EZ
76742011-10-28 Eli Zaretskii <eliz@gnu.org>
7675
7676 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
7677 possible random value that matches one of those tested as
7678 condition to clear the mouse face.
7679
d3d0842f
CY
76802011-10-28 Chong Yidong <cyd@gnu.org>
7681
7682 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
7683
31b39d13
DN
76842011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
7685
7686 * window.c (make_window): Initialize phys_cursor_on_p.
7687
9aba6043
SM
76882011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
7689
7690 * lisp.h (struct Lisp_Symbol): Update comments.
7691
c20992f4
JB
76922011-10-28 Juanma Barranquero <lekktu@gmail.com>
7693
7694 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
7695
db4f02f2
EZ
76962011-10-28 Eli Zaretskii <eliz@gnu.org>
7697
7698 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
7699 <oslsachem@gmail.com> for helping to debug this.
7700
7701 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
7702 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
7703 (g_b_init_get_glyph_outline_w): New static variables.
7704 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
7705 (GetGlyphOutlineW_Proc): New typedefs.
7706 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
7707 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
7708 New functions.
7709 (w32font_open_internal, compute_metrics):
7710 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
7711 instead of calling the "wide" APIs directly.
7712
7713 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
7714
7715 * w32.h (syms_of_w32font): Add prototype.
7716
87e68db4
JB
77172011-10-27 Juanma Barranquero <lekktu@gmail.com>
7718
7719 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
7720 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
7721 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
7722 (Fmove_to_window_line): Doc fix.
7723
435c1d67
CY
77242011-10-27 Chong Yidong <cyd@gnu.org>
7725
7726 * process.c (make_process): Set gnutls_state to NULL.
7727
7728 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
7729 non-NULL, regardless of GNUTLS_INITSTAGE.
7730 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
7731 an error. Set process slots as soon as we allocate them.
7732
7733 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
7734
9c6c6f49
CY
77352011-10-27 Chong Yidong <cyd@gnu.org>
7736
9aba6043
SM
7737 * gnutls.c (emacs_gnutls_deinit): New function.
7738 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
7739 (Fgnutls_deinit, Fgnutls_boot): Use it.
7740
7741 * process.c (make_process): Initialize GnuTLS credentials to NULL.
7742 (deactivate_process): Call emacs_gnutls_deinit.
7743
657d08d3
JB
77442011-10-27 Juanma Barranquero <lekktu@gmail.com>
7745
7746 * image.c (x_create_x_image_and_pixmap):
7747 * w32.c (sys_rename, w32_delayed_load):
7748 * w32font.c (fill_in_logfont):
7749 * w32reg.c (x_get_string_resource): Silence compiler warnings.
7750
5430d399
JB
77512011-10-26 Juanma Barranquero <lekktu@gmail.com>
7752
7753 * w32fns.c (w32_default_color_map): New function,
7754 extracted from Fw32_default_color_map.
a7ef684b 7755 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 7756
fe0055fa
PE
77572011-10-25 Paul Eggert <eggert@cs.ucla.edu>
7758
7759 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
7760
e6346438
SM
77612011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
7762
7763 * keyboard.c (test_undefined): New function (bug#9751).
7764 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
7765
e112cc37
ET
77662011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
7767
7768 * sysdep.c (init_sys_modes): Fix the check for the controlling
7769 terminal (Bug#6649).
7770
7b5d6677
EZ
77712011-10-20 Eli Zaretskii <eliz@gnu.org>
7772
7773 * dispextern.h (struct bidi_it): New member next_en_type.
7774
7775 * bidi.c (bidi_line_init): Initialize the next_en_type member.
7776 (bidi_resolve_explicit_1): When next_en_pos is valid for the
7777 current character, check also for next_en_type being WEAK_EN.
7778 (bidi_resolve_weak): Don't enter the expensive loop if the current
7779 position is before next_en_pos. Record the bidi type of the first
7780 non-ET, non-BN character we find, in addition to its position.
7781 (bidi_level_of_next_char): Invalidate next_en_type when
7782 next_en_pos is over-stepped.
7783
7da0b018
PE
77842011-10-20 Paul Eggert <eggert@cs.ucla.edu>
7785
7786 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
7787 * editfns.c: Rewrite current-time-zone so that it invokes
7788 the equivalent of (format-time-string "%Z") to get the time zone name.
7789 This fixes a bug when the time zone name contains characters that
7790 need converting from the system time locale to Emacs internal format.
7791 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
7792 that patch fixed format-time-string to do the conversion, but
7793 I forgot to fix current-time-zone.
7794 (format_time_string): New function, containing most of
7795 what Fformat_time_string used to contain.
7796 (Fformat_time_string): Rewrite in terms of format_time_string.
7797 This doesn't change this function's behavior.
7798 (current-time-zone): Rewrite to use format_time_string.
7799 This fixes the bug reported by Michael Schierl in
7800 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
7801 Jason Rumney's 2007-06-07 change worked around this bug, but
7802 didn't fix it.
7803 * systime.h (tzname, timezone): Remove no-longer-used declarations.
7804
8547b010
EZ
78052011-10-19 Eli Zaretskii <eliz@gnu.org>
7806
7807 * xdisp.c (start_display): If the character at POS is displayed
7808 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
7809 (try_window_reusing_current_matrix): If a line ends in a display
7810 vector or the next line starts in a display vector, continue
7811 redrawing the window even though the character position of
7812 start_row was reached.
8547b010
EZ
7813 (Bug#9771, part 2)
7814
4e948d15
CY
78152011-10-18 Chong Yidong <cyd@gnu.org>
7816
7817 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
7818 with nobreak-char-display too.
7819
4787455f
EZ
78202011-10-18 Eli Zaretskii <eliz@gnu.org>
7821
7822 Fix part 3 of bug#9771.
7823 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
7824 (bidi_resolve_neutral): Don't enter the expensive loop looking for
7825 non-neutral characters if the current character is a paragraph
7826 separator (a.k.a. Newline). This avoids running the same
7827 expensive loop twice, once when we consume the preceding newline
7828 and the other time when the line actually needs to be displayed.
7829 Avoid the loop when we see neutrals on the base embedding level
7830 following a character whose directionality is the same as the
7831 paragraph's. This avoids running the expensive loop when a line
7832 ends in a long sequence of neutrals, like control characters.
7833 Add assertion against STRONG_AL type. Slightly rearrange code
7834 that determines the type of a neutral given the first non-neutral
7835 that follows it.
7836 (bidi_level_of_next_char): Set next_en_pos to zero when
7837 invalidating its info.
7838
2c91f553
EZ
78392011-10-17 Eli Zaretskii <eliz@gnu.org>
7840
7841 * xdisp.c (push_display_prop): Determine whether to record string
7842 or buffer position by IT->string, not by IT->method. Allow
7843 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
7844 (move_it_vertically_backward): Don't look for character position
7845 immediately after the newline when in a continuation line.
7846 (Bug#9771, part 1)
2c91f553 7847
c7b08b0d
MR
78482011-10-15 Martin Rudalics <rudalics@gmx.at>
7849
7850 * window.c (coordinates_in_window): Rewrite and delabelize
7851 vertical border check. (Bug#5357) (Bug#9618)
7852
6b02f655
SM
78532011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
7854
7855 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
7856 errors in XSetWindowBorder (bug#9310).
7857
81d40c92
DA
78582011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
7859
7860 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
7861 avoid crash when xmalloc overrun checking is enabled.
7862
d4172c3b
EZ
78632011-10-13 Eli Zaretskii <eliz@gnu.org>
7864
7865 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
7866 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
7867 cursor motion with <left> and <right> arrow keys.
7868
7869 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
7870 some callers set that themselves.
7871
b00eea75
EZ
78722011-10-12 Eli Zaretskii <eliz@gnu.org>
7873
7874 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
7875 display string and the previous row comes from the same string and
7876 is empty. (Bug#9739) (Bug#9738)
7877
8fe012c4
SM
78782011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
7879
7880 * doc.c (get_doc_string): Encode file name (bug#9735).
7881
0074aef2
EZ
78822011-10-12 Eli Zaretskii <eliz@gnu.org>
7883
79beb178
EZ
7884 * bidi.c (bidi_level_of_next_char):
7885 * xdisp.c (get_visually_first_element): Remove old incorrect
7886 comments regarding the Unicode Line Separator character.
7887
0074aef2
EZ
7888 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
7889
6e4b3fbe
DA
78902011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
7891
7892 * alloc.c (Fgc_status): Do not access beyond zombies array
7893 boundary if nzombies > MAX_ZOMBIES.
7894 * alloc.c (dump_zombies): Add missing format specifier.
7895
0324f3af
PE
78962011-10-12 Paul Eggert <eggert@cs.ucla.edu>
7897
b5525cac
PE
7898 * xdisp.c (set_cursor_from_row): Simplify conditionals,
7899 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
7900
0324f3af
PE
7901 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
7902 Some packages use them to denote characters with modifiers.
7903
e9b5f888
AS
79042011-10-11 Andreas Schwab <schwab@linux-m68k.org>
7905
7906 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
7907 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
7908 matching a pp-number. Rename parameter var to var1.
7909
127827c0
SM
79102011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
7911
7912 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
7913
c8fd3bd0
GM
79142011-10-08 Glenn Morris <rgm@gnu.org>
7915
7916 * callint.c (Fcall_interactively): Give a more explicit error for the
7917 'c' case with a non-character input. (Bug#8479)
7918
352ec8ff
EZ
79192011-10-08 Eli Zaretskii <eliz@gnu.org>
7920
03669ccb
EZ
7921 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
7922 lines.
7061c986
EZ
7923 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
7924 lines that are hscrolled on the left.
03669ccb 7925
352ec8ff
EZ
7926 * dispnew.c (buffer_posn_from_coords): Account for a possible
7927 presence of header-line. (Bug#4426)
7928
a66cfb1c
SM
79292011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
7930
6b02f655
SM
7931 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
7932 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 7933
7c5ee88e
PE
79342011-10-07 Paul Eggert <eggert@cs.ucla.edu>
7935
7936 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
7937 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
7938 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
7939 this makes Emacs dump core during garbage collection on rare
7940 occasions. sizeof is obviously inferior to offsetof here, so
7941 stick with offsetof.
7942 (GC_POINTER_ALIGNMENT): New macro.
7943 (mark_memory): Omit 3rd (offset) arg; caller changed.
7944 Don't assume EMACS_INT alignment is the same as pointer alignment.
7945
df1bbe5b
SM
79462011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
7947
7948 * keyboard.c (read_key_sequence_remapped): New var.
7949 (read_key_sequence): Compute remapping in the right buffer.
7950 (command_loop_1): Use read_key_sequence's remapping directly.
7951
51553db6
SM
79522011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
7953
32c1fffd
SM
7954 * dired.c (file_name_completion): Don't expand file name.
7955 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
7956 before checking file name handler.
7957
51553db6
SM
7958 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
7959 they've been requested explicitly (bug#9591).
7960
b6bd1599 79612011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
7962
7963 * keymap.c (Fsingle_key_description): Use make_specified_string
7964 instead of build_string to build string from push_key_description.
7965 (Bug#5193)
7966
f701dc2a
PE
79672011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7968
4222c55d
PE
7969 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
7970 This fixes a Y2038 bug on 64-bit hosts.
7971 * buffer.c (reset_buffer):
7972 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
7973 (Fclear_buffer_auto_save_failure):
7974 Use 0, not -1, to represent an unset failure time, since time_t
7975 might not be signed.
7976
f701dc2a
PE
7977 Remove dependency on glibc malloc internals.
7978 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7979 Move back here from lisp.h, but with their new implementations.
7980 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7981 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
7982 * charset.c (charset_table_init): New static var.
7983 (syms_of_charset): Use it instead of xmalloc. This removes a
7984 dependency on glibc malloc internals. See Eli Zaretskii's comment in
7985 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
7986 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7987 Move back to alloc.c.
7988 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7989 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
7990
9ceebf39
JD
79912011-09-30 Jan Djärv <jan.h.d@swipnet.se>
7992
7993 * nsterm.m (windowDidResize): Call x_set_window_size only when
7994 ns_in_resize is true. Otherwise set pixelwidth/height and
7995 call change_frame_size (Bug#9628).
7996
cb993c58
PE
79972011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7998
3930c88b
PE
7999 Port --enable-checking=all to Fedora 14 x86-64.
8000 * charset.c (syms_of_charset): Also account for glibc malloc's
8001 internal overhead when calculating the initial malloc maximum.
8002
cb993c58
PE
8003 Port --enable-checking=all to Fedora 14 x86.
8004 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
8005 Move to lisp.h.
8006 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
8007 (overrun_check_realloc, overrun_check_free):
8008 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
8009 That way, xmalloc returns a properly-aligned pointer even if
8010 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
8011 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
8012 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
8013 into account when calculating the initial malloc maximum.
8014 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
8015 Move here from alloc.c, so that charset.c can use it too.
8016 Properly align; the old code wasn't right for common 32-bit hosts
8017 when configured with --enable-checking=all.
8018 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
8019 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
8020
31bed486
EZ
80212011-09-29 Eli Zaretskii <eliz@gnu.org>
8022
04c70788 8023 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
8024 use EDOM.
8025
fbcaa2f3
EZ
80262011-09-28 Eli Zaretskii <eliz@gnu.org>
8027
8028 * xdisp.c (compute_display_string_end): If there's no display
8029 string at CHARPOS, return -1.
8030
8031 * bidi.c (bidi_fetch_char): When compute_display_string_end
8032 returns a negative value, treat the character as a normal
8033 character not covered by a display string. (Bug#9624)
8034
a239d4e9
JB
80352011-09-28 Juanma Barranquero <lekktu@gmail.com>
8036
8037 * lread.c (Fread_from_string): Fix typo in docstring.
8038
88652fd5
EZ
80392011-09-27 Eli Zaretskii <eliz@gnu.org>
8040
8041 * xdisp.c (handle_invisible_prop): If invisible text ends on a
8042 newline, reseat the iterator instead of bidi-iterating there one
8043 character at a time. (Bug#9610)
32c1fffd
SM
8044 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
8045 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 8046
ed497dd4
AS
80472011-09-27 Andreas Schwab <schwab@linux-m68k.org>
8048
8049 * lread.c (readevalloop): Use correct code for NBSP.
8050 (read1): Likewise. (Bug#9608)
8051
b2bf61aa
MA
80522011-09-25 Michael Albinus <michael.albinus@gmx.de>
8053
8054 * dbusbind.c (Fdbus_register_signal): When service is not
8055 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
8056
32bbb17c
GM
80572011-09-25 Glenn Morris <rgm@gnu.org>
8058
8059 * buffer.c (truncate-lines): Doc fix.
8060
94e0933e
CY
80612011-09-24 Chong Yidong <cyd@stupidchicken.com>
8062
8063 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
8064 (Fset_window_next_buffers): Doc fix.
8065
cddde921
GM
80662011-09-24 Glenn Morris <rgm@gnu.org>
8067
8068 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
8069
1260aef1
PE
80702011-09-24 Paul Eggert <eggert@cs.ucla.edu>
8071
25b4bfa0
PE
8072 Fix minor problems found by static checking.
8073 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
8074 * indent.c (Fvertical_motion): Fix == vs = typo.
8075
e3cbd34b
EZ
80762011-09-24 Eli Zaretskii <eliz@gnu.org>
8077
a66cfb1c
SM
8078 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
8079 Default value is now t. Doc fix.
6bf7006f 8080
e3cbd34b 8081 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 8082 logic when moving up, not only when moving down. Fix the
e3cbd34b 8083 confusing name and values of the it_overshoot_expected variable;
32c1fffd 8084 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
8085
8086 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
8087 CHARPOS is covered by a display string which includes newlines.
8088 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
8089 is covered by a display string with embedded newlines.
8090
a3de0cbd
MA
80912011-09-24 Michael Albinus <michael.albinus@gmx.de>
8092
8093 * dbusbind.c (Fdbus_register_signal): Add match rule to
8094 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
8095 (Fdbus_register_method, Vdbus_registered_objects_table):
8096 Fix docstring.
a3de0cbd 8097
b260039d
JM
80982011-09-24 Jim Meyering <meyering@redhat.com>
8099
32c1fffd 8100 do not ignore write error for any output size
b260039d
JM
8101 The previous change was incomplete.
8102 While it makes emacs --batch detect the vast majority of stdout
8103 write failures, errors were still ignored whenever the output size is
8104 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
8105 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
8106 && echo FAIL: ignored write error
8107 FAIL: ignored write error
8108 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
8109 && echo FAIL: ignored write error
8110 FAIL: ignored write error
8111 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
8112
8eca8a7c
AS
81132011-09-23 Andreas Schwab <schwab@linux-m68k.org>
8114
8115 * emacs.c (Fkill_emacs): In noninteractive mode exit
8116 non-successfully if a write error occurred on stdout. (Bug#9574)
8117
3341db62
EZ
81182011-09-21 Eli Zaretskii <eliz@gnu.org>
8119
8120 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
8121 the xassert test.
8122
8123 * dispextern.h (struct it): Update the comment documenting what
8124 can it->OBJECT be.
8125
8c203dbf
EZ
81262011-09-20 Eli Zaretskii <eliz@gnu.org>
8127
8128 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
8129 a display string, extend search for cursor position to end of row.
8130 (find_row_edges): If the row ends in a newline from a display
8131 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
8132 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
8133 (Fcurrent_bidi_paragraph_direction): Fix search for previous
8134 non-empty line. Fixes confusing cursor motion with arrow keys at
8135 the beginning of a line that starts with whitespace.
8c203dbf 8136
a4824228
LMI
81372011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8138
8139 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
8140 (bug#9493).
8141
33ed493b
CY
81422011-09-18 Chong Yidong <cyd@stupidchicken.com>
8143
8144 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
8145 boolean (Bug#9154).
8146
56cd55c8
EZ
81472011-09-18 Eli Zaretskii <eliz@gnu.org>
8148
8149 * xdisp.c (display_line): Record maximum and minimum buffer
8150 positions even if no glyphs were produced (e.g., by a zero-width
8151 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
8152 buffer positions that will be removed from the glyph row because
8153 they don't fit.
c02dcedf
EZ
8154 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
8155 column is beyond frame width: don't subtract 1 "pixel" when
8156 computing width of the stretch.
3e62b7e0
EZ
8157 (reseat_at_next_visible_line_start): Undo the change made on
8158 2011-09-17 that saved paragraph information and restored it after
8159 the call to `reseat'. (Bug#9545)
56cd55c8 8160
5ed99d36 81612011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
8162
8163 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
8164 and turn window cursor on if cleared (Bug#9415).
8165
5ed99d36 81662011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
8167
8168 * search.c (boyer_moore): Take unibyte characters from pattern
8169 literally. (Bug#9458)
8170
9bade7b2
EZ
81712011-09-18 Eli Zaretskii <eliz@gnu.org>
8172
8173 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
8174
e5e9d610
PE
81752011-09-18 Paul Eggert <eggert@cs.ucla.edu>
8176
87e4427a
PE
8177 Fix minor problem found by static checking.
8178 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
8179 initialized, to pacify gcc -Wuninitialized.
8180
e5e9d610
PE
8181 * fileio.c: Report proper errno when syscall falls.
8182 (Finsert_file_contents): Save and restore errno,
8183 so that report_file_error outputs the correct diagnostic.
8184 (Fwrite_region) [CLASH_DETECTION]: Likewise.
8185
a1674f0b
EZ
81862011-09-18 Eli Zaretskii <eliz@gnu.org>
8187
8188 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
8189
fbfb6dd4
EZ
81902011-09-17 Eli Zaretskii <eliz@gnu.org>
8191
8192 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
8193 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
8194
bb187662
EZ
81952011-09-17 Eli Zaretskii <eliz@gnu.org>
8196
1137e8b8 8197 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 8198 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
8199
8200 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
8201 (bidi_find_paragraph_start): Search back for paragraph beginning
8202 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
8203 (bidi_move_to_visually_next): Only trigger paragraph-related
8204 computations when the last character is a newline or at EOB, not
8205 just any NEUTRAL_B. (Bug#9470)
8206
bb187662
EZ
8207 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
8208 truncated lines if point is covered by a display string. (Bug#9524)
8209
2e621251
PE
82102011-09-16 Paul Eggert <eggert@cs.ucla.edu>
8211
8212 * xselect.c: Relax test for outgoing X longs (Bug#9498).
8213 (cons_to_x_long): New function.
8214 (lisp_data_to_selection_data): Use it. Correct the test for
8215 short-versus-long data; it was negated. Break out of vector
8216 loop, for efficiency, when a long datum is discovered.
8217
91a15bc6
SM
82182011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
8219
8220 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
8221
b41c3a35
EZ
82222011-09-16 Eli Zaretskii <eliz@gnu.org>
8223
8224 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
8225 GCC PR/17406) by declaring this function with external scope.
8226
7812ba2d
PE
82272011-09-15 Paul Eggert <eggert@cs.ucla.edu>
8228
8229 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
8230 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
8231
cf7edc2a
AS
82322011-09-15 Andreas Schwab <schwab@linux-m68k.org>
8233
8234 * editfns.c (Fformat): Correctly handle text properties on "%%".
8235
bd01620e
EZ
82362011-09-15 Eli Zaretskii <eliz@gnu.org>
8237
8238 * xterm.c (x_draw_composite_glyph_string_foreground):
8239 * w32term.c (x_draw_composite_glyph_string_foreground):
8240 * term.c (encode_terminal_code):
8241 * composite.c (composition_update_it, get_composition_id):
8242 * xdisp.c (get_next_display_element)
8243 (fill_composite_glyph_string): Add comments about special meaning
8244 of TAB characters in a composition.
8245
a02719a3
PE
82462011-09-15 Paul Eggert <eggert@cs.ucla.edu>
8247
8248 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
8249 This occurs when processing a multibyte format.
8250 Problem reported by Wolfgang Jenker.
a02719a3 8251
72589a3c
JB
82522011-09-15 Johan Bockgård <bojohan@gnu.org>
8253
8254 * xdisp.c (try_cursor_movement): Only check for exact match if
8255 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
8256
1c14176c
PE
82572011-09-14 Paul Eggert <eggert@cs.ucla.edu>
8258
8259 Remove unused external symbols.
8260 * dispextern.h (calc_pixel_width_or_height): Remove decl.
8261 * xdisp.c (calc_pixel_width_or_height): Now static.
8262 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
8263 * indent.c (check_display_width):
8264 * w32term.c: Fix comment to match code.
8265 * xterm.c, xterm.h (x_catching_errors): Remove.
8266
d2eea5b5
PE
82672011-09-14 Paul Eggert <eggert@cs.ucla.edu>
8268
8269 * xselect.c: Use signed conversions more consistently (Bug#9498).
8270 (selection_data_to_lisp_data): Assume incoming selection data are
8271 signed integers, not unsigned. This is to be consistent with
8272 outgoing selection data, which was modified to use signed integers
8273 in as part of the fix to Bug#9196 in response to Jan D.'s comment
8274 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
8275 expects long, not unsigned long.
8276
46888499
EZ
82772011-09-14 Eli Zaretskii <eliz@gnu.org>
8278
8279 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
8280 computation of loop end. Reported by Johan Bockgård
8281 <bojohan@gnu.org>.
8282
ef8ef9fb
CY
82832011-09-13 Chong Yidong <cyd@stupidchicken.com>
8284
8285 * frame.c (Fother_visible_frames_p): Function deleted.
8286
fa819fed
EZ
82872011-09-12 Eli Zaretskii <eliz@gnu.org>
8288
8289 * indent.c (compute_motion): Process display vector front to back
8290 rather than the other way around. (Bug#2496)
8291
2ba8e008
SM
82922011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
8293
8294 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
8295
20f53c69
CY
82962011-09-11 Chong Yidong <cyd@stupidchicken.com>
8297
8298 * minibuf.c (Fread_from_minibuffer): Doc fix.
8299
d562d7a4
EZ
83002011-09-11 Eli Zaretskii <eliz@gnu.org>
8301
8302 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
8303 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
8304
1c4d7f3d
LMI
83052011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8306
8307 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
8308 value for non-existent files.
8309
b885bf36
EZ
83102011-09-11 Eli Zaretskii <eliz@gnu.org>
8311
8312 * fileio.c (Finsert_file_contents): If the file cannot be opened,
8313 set its "size" to -1. This will set the modtime_size field of
8314 the corresponding buffer to -1, which is what
8315 verify-visited-file-modtime expects for files that do not exist.
8316 (Bug#9139)
8317
6612f0bf
PE
83182011-09-11 Paul Eggert <eggert@cs.ucla.edu>
8319
8320 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
8321 here ...
8322 * lisp.h: ... from here. push_key_description is no longer
8323 defined in keyboard.c, so its declaration should not be in
8324 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
8325 logically belongs with push_key_description.
8326
dfb3f755
PE
83272011-09-10 Paul Eggert <eggert@cs.ucla.edu>
8328
8329 * buffer.h: Include <sys/types.h> instead of <time.h>.
8330 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
8331 Problem reported by Herbert J. Skuhra.
8332
3134906c
LMI
83332011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
8334
8335 * xml.c (parse_region): Make the parsing work for
8336 non-comment-starting XML files again (bug#9144).
8337
8d903f4e
AS
83382011-09-10 Andreas Schwab <schwab@linux-m68k.org>
8339
8340 * image.c (gif_load): Fix calculation of bottom and right corner.
8341 (Bug#9468)
8342
80ad64f4
EZ
83432011-09-10 Eli Zaretskii <eliz@gnu.org>
8344
8345 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
8346 redisplay in small windows.
8347
208a048d
EZ
83482011-09-09 Eli Zaretskii <eliz@gnu.org>
8349
8350 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
8351
9b1c252e
MR
83522011-09-08 Martin Rudalics <rudalics@gmx.at>
8353
8354 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
8355 Operate on live windows only.
8356
2949f33b
JB
83572011-09-08 Juanma Barranquero <lekktu@gmail.com>
8358
8359 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
8360
e08dcafd
EZ
83612011-09-07 Eli Zaretskii <eliz@gnu.org>
8362
8363 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
8364 only under bidi iteration.
8365
115b96bd
JD
83662011-09-07 Jan Djärv <jan.h.d@swipnet.se>
8367
8368 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
8369
c8199d0f
PE
83702011-09-06 Paul Eggert <eggert@cs.ucla.edu>
8371
8372 isnan: Fix porting problem to Solaris 10 with bundled gcc.
8373 Without this fix, the command to link temacs failed due to an
8374 undefined symbol __builtin_isnan. This is because
8375 /usr/include/iso/math_c99.h #defines isnan(x) to
8376 __builtin_isnan(x), but the bundled gcc, which identifies itself
8377 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
8378 a __builtin_isnan.
8379 * floatfns.c (isnan): #undef, and then #define to a clone of
8380 what's in data.c.
8381 (Fisnan): Always define, since it's always available now.
8382 (syms_of_floatfns): Always define isnan at the Lisp level.
8383
e39b275c 83842011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
8385
8386 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
8387
b2db44d9 83882011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 8389
f4af5137 8390 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
8391 The previous code assumed that file offsets (off_t values) fit in
8392 EMACS_INT variables, which is not true on typical 32-bit hosts.
8393 The code messed up by falsely reporting buffer overflow in cases
8394 such as (insert-file-contents "big" nil 1 2) into an empty buffer
8395 when "big" contains more than 2**29 bytes, even though this
8396 inserts just one byte and does not overflow the buffer.
8397 (Finsert_file_contents): Store file offsets as off_t
8398 values, not as EMACS_INT values. Check for overflow when
8399 converting between EMACS_INT and off_t. When checking for
8400 buffer overflow or for overlap, take the offsets into account.
8401 Don't use EMACS_INT for small values where int suffices.
8402 When checking for overlap, fix a typo: ZV was used where
8403 ZV_BYTE was intended.
8404 (Fwrite_region): Don't assume off_t fits into 'long'.
8405 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
8406
ecfc0a49
MA
84072011-09-05 Michael Albinus <michael.albinus@gmx.de>
8408
8409 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
8410
6511acf2 84112011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 8412
0999621a 8413 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
8414
8415 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 8416 (esprintf, exprintf, evxprintf): New functions.
62f19c19 8417 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 8418 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
8419 (modify_event_symbol): Do not assume that the length of
8420 name_alist_or_stem is safe to alloca and fits in int.
8421 (Fexecute_extended_command): Likewise for function name and binding.
8422 (Frecursion_depth): Wrap around reliably on integer overflow.
8423 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
8424 since some callers pass EMACS_INT values.
8425 (Fsingle_key_description): Don't crash if symbol name contains more
8426 than MAX_ALLOCA bytes.
8427 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
8428 (get_minibuffer): Arg is now EMACS_INT, not int.
8429 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 8430 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
8431 * window.h (command_loop_level, minibuf_level): Reflect API changes.
8432
2be7d702
PE
8433 * dbusbind.c (signature_cat): New function.
8434 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
8435 Do not overrun buffer; instead, report string overflow.
8436
9d1df220
PE
8437 * dispnew.c (add_window_display_history): Don't overrun buffer.
8438 Truncate instead; this is OK since it's just a log.
8439
33ef5c64
PE
8440 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
8441 even if the time zone offset is outlandishly large.
8442 Don't mishandle offset == INT_MIN.
8443
66c6fdd5
PE
8444 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
8445 when creating daemon; the previous buffer-overflow check was incorrect.
8446
d749b01b
PE
8447 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
8448 which has the guts of the old verror function.
8449
b5cd1905
PE
8450 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
8451 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
8452
6e1a67fb
PE
8453 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
8454 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 8455 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 8456 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
8457 length of string rather than counting it via multiple sprintfs;
8458 that's simpler and more reliable.
c21721cc
PE
8459 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
8460 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
8461 sprintf, in case result does not fit in int.
8462
c57b67fc
PE
8463 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
8464 (fontset_from_font): Print it.
8465
8a401434
PE
8466 * frame.c (tty_frame_count): Now printmax_t, not int.
8467 (make_terminal_frame, set_term_frame_name): Print it.
8468 (x_report_frame_params): In X, window IDs are unsigned long,
8469 not signed long, so print them as unsigned.
8470 (validate_x_resource_name): Check for implausibly long names,
8471 and don't assume name length fits in 'int'.
8472 (x_get_resource_string): Don't blindly alloca invocation name;
8473 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
8474 not fit in int.
8475
6e1a67fb
PE
8476 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
8477 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
8478 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
8479
0df02bf3
PE
8480 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
8481 Use esprintf, not sprintf, in case result does not fit in int.
8482
48e30793
PE
8483 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
8484 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
8485 it as a large positive number.
8486 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
8487 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
8488
a66ff6d8
PE
8489 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
8490 in case result does not fit in int.
8491
aca216ff
PE
8492 * print.c (float_to_string): Detect width overflow more reliably.
8493 (print_object): Make sprintf buffer a bit bigger, to avoid potential
8494 buffer overrun. Don't assume list length fits in 'int'. Treat
8495 print length of 0 as 0, not as infinity; to be consistent with other
8496 uses of print length in this function. Don't overflow print length
8497 index. Don't assume hash table size fits in 'long', or that
8498 vectorlike size fits in 'unsigned long'.
8499
31c286f7
PE
8500 * process.c (make_process): Use printmax_t, not int, to format
8501 process-name gensyms.
8502
55e5faa1
PE
8503 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
8504
80f2e268
PE
8505 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
8506 to avoid potential buffer overrun.
8507
670741ab
PE
8508 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
8509 if X resource line is longer than 512 bytes.
8510
b7163a50
PE
8511 * xfns.c (x_window): Make sprintf buffer a bit bigger
8512 to avoid potential buffer overrun.
8513
ae58ff1f
PE
8514 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
8515
c43c8a6a
PE
8516 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
8517
3f8236f4
PE
85182011-09-04 Paul Eggert <eggert@cs.ucla.edu>
8519
53e9fe90 8520 Integer overflow fixes for scrolling, etc.
6511acf2
PE
8521 Without these, Emacs silently mishandles large integers sometimes.
8522 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
8523 it were "C-u 1 M-x recenter" on a typical 64-bit host.
8524
6511acf2
PE
8525 * xdisp.c (try_window_id): Check Emacs fixnum range before
8526 converting to 'int'.
806add1d 8527
6511acf2 8528 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
8529 Check that an Emacs fixnum is in range before assigning it to 'int'.
8530 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
8531 values converted from Emacs fixnums.
8532 (Frecenter): Don't wrap around a line count if it is out of 'int'
8533 range; instead, treat it as an extreme value.
8534 (Fset_window_configuration, compare_window_configurations):
8535 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
8536
6511acf2
PE
8537 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
8538 that can exceed INT_MAX. Check that EMACS_INT value is in range
8539 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
8540 (match_limit): Don't assume that a fixnum can fit in 'int'.
8541
6511acf2 8542 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
8543 exceed INT_MAX.
8544
6511acf2 8545 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
8546 (Fvertical_motion): Don't wrap around LINES values that don't fit
8547 in 'int'. Instead, treat them as extreme values. This is good
8548 enough for windows, which can't have more than INT_MAX lines anyway.
8549
fcb901a7
LMI
85502011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8551
0f2f6b6d
LMI
8552 * Require libxml/parser.h to avoid compilation warning.
8553
fcb901a7
LMI
8554 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
8555
8556 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
8557 since this reportedly can destroy thread storage.
8558
6e20a0d4
CY
85592011-08-30 Chong Yidong <cyd@stupidchicken.com>
8560
8561 * syntax.c (find_defun_start): Update all cache variables if
8562 exiting early (Bug#9401).
8563
148ae00e
EZ
85642011-08-30 Eli Zaretskii <eliz@gnu.org>
8565
f6cfbd8f
EZ
8566 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
8567
148ae00e
EZ
8568 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
8569 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
8570 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
8571
8572 * term.c (tty_append_glyph): New function.
8573 (produce_stretch_glyph): Static function and its prototype deleted.
8574
a66cfb1c
SM
8575 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
8576 Add prototypes.
148ae00e 8577
c4a07a4c
PE
85782011-08-29 Paul Eggert <eggert@cs.ucla.edu>
8579
8580 * image.c (parse_image_spec): Check for nonnegative, not for positive,
8581 when checking :margin (Bug#9390).
8582 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 8583 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
8584 so that the name doesn't mislead. All uses changed.
8585
6bc8cd65
JB
85862011-08-28 Johan Bockgård <bojohan@gnu.org>
8587
8588 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
8589 set_tty_hooks.
8590
dca4927e
EZ
85912011-08-27 Eli Zaretskii <eliz@gnu.org>
8592
8593 * xdisp.c (move_it_to): Don't bail out early when reaching
8594 position beyond to_charpos, if we are scanning backwards.
8595 (move_it_vertically_backward): When DY == 0, make sure we get to
8596 the first character in the line after the newline.
8597
f2cad773
PE
85982011-08-27 Paul Eggert <eggert@cs.ucla.edu>
8599
8600 * ccl.c: Improve and simplify overflow checking (Bug#9196).
8601 (ccl_driver): Do not generate an out-of-range pointer.
8602 (Fccl_execute_on_string): Remove unnecessary check for
8603 integer overflow, noted by Stefan Monnier in
8604 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
8605 Remove a FIXME that didn't need fixing.
8606 Simplify the newly-introduced buffer reallocation code.
8607
0cae2cdb
JB
86082011-08-27 Juanma Barranquero <lekktu@gmail.com>
8609
8610 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
8611
5fc295a4 86122011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 8613
70c60eb2 8614 Integer and memory overflow issues (Bug#9196).
726e0ab1 8615
d31850da
PE
8616 * doc.c (get_doc_string): Rework so that
8617 get_doc_string_buffer_size is the actual buffer size, rather than
8618 being 1 less than the actual buffer size; this makes xpalloc more
8619 convenient.
8620
a69fbedb
PE
8621 * image.c (x_allocate_bitmap_record, cache_image):
8622 * xselect.c (Fx_register_dnd_atom):
8623 Simplify previous changes by using xpalloc.
8624
fe5c5d37
PE
8625 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
8626 since either will do and ptrdiff_t is convenient with xpalloc.
8627
0065d054
PE
8628 * charset.c (charset_table_size)
8629 (struct charset_sort_data.priority): Now ptrdiff_t.
8630 (charset_compare): Don't overflow if priorities differ greatly.
8631 (Fsort_charsets): Don't assume list length fits in int.
8632 Check for size-calculation overflow when allocating sort data.
8633 (syms_of_charset): Allocate an initial charset table that is
8634 just under 64 KiB, to avoid problems with glibc malloc and mmap.
8635
8636 * cmds.c (internal_self_insert): Check for size-calculation overflow.
8637
8638 * composite.h (struct composition.glyph_len): Now int, not unsigned.
8639 The actual value is always <= INT_MAX, and leaving it unsigned made
8640 overflow checking harder.
8641
8642 * dispextern.h (struct glyph_matrix.rows_allocated)
8643 (struct face_cache.size): Now ptrdiff_t, for convenience in use
8644 with xpalloc. The values are still always <= INT_MAX.
8645
8646 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
8647
8648 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
8649 (SAFE_NALLOCA): New macro.
8650
8651 * region-cache.c (struct boundary.pos, find_cache_boundary)
8652 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
8653 (set_cache_region, invalidate_region_cache)
8654 (revalidate_region_cache, know_region_cache, region_cache_forward)
8655 (region_cache_backward, pp_cache):
8656 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
8657 so that ptrdiff_t * can be passed to xpalloc.
8658 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
8659 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
8660 (pp_cache): Don't assume cache_len fits in int.
8661 * region-cache.h: Adjust extern decls to match.
8662
8663 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
8664 EMACS_INT, since either will do, for xpalloc.
8665
8666 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
8667 (xnmalloc, xnrealloc, xpalloc): New functions.
8668
726e0ab1
PE
8669 * bidi.c (bidi_shelve_header_size): New constant.
8670 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
8671 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
8672
51f30bc5 8673 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
8674 * buffer.c (overlays_at, overlays_in, record_overlay_string)
8675 (overlay_strings):
8676 Don't update size of array until after memory allocation succeeds,
8677 because xmalloc/xrealloc may not return.
0065d054
PE
8678 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
8679 now that we have proper integer overflow checking.
8680 (record_overlay_string, overlay_strings): Catch overflows when
8681 calculating size of overlay_str_buf.
726e0ab1 8682
0065d054
PE
8683 * callproc.c (Fcall_process): Check for size overflow when
8684 calculating size of args2.
8685 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
8686 Normally we prefer signed values, but sticking with ptrdiff_t would
8687 require adding more-complicated checks.
726e0ab1
PE
8688
8689 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
8690 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
8691 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 8692 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
8693
8694 * character.c (Fstring): Check for size-calculation overflow.
8695
8696 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
8697 unnecessary integer overflow. Check for size overflow.
8698 (encode_coding_object): Don't update size until xmalloc succeeds.
8699
8700 * composite.c (get_composition_id): Check for overflow in glyph
8701 length calculations.
8702
8703 Integer and memory overflow fixes for display code.
8704 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
8705 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
8706 (scrolling_window): Check for overflow in size calculations.
8707 (line_draw_cost, realloc_glyph_pool, add_row_entry):
8708 Don't assume glyph table len fits in int.
8709 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
8710 (row_table_size): Now ptrdiff_t, not int.
8711 (scrolling_window): Avoid overflow in size calculations.
8712 Don't update size until allocation succeeds.
8713 * fns.c (concat): Check for overflow in size calculations.
8714 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
8715 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8716 (NEXT_ALMOST_PRIME_LIMIT): New constant.
8717
8718 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
8719 (get_doc_string): Check for size calculation overflow.
8720 Don't update size until allocation succeeds.
8721 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
8722 EMACS_INT, where ptrdiff_t will do.
8723 (Fsubstitute_command_keys): Check for string overflow.
8724
8725 * editfns.c (set_time_zone_rule): Don't assume environment length
8726 fits in int.
8727 (message_length): Now ptrdiff_t, not int.
8728 (Fmessage_box): Don't update size until allocation succeeds.
8729 Don't assume message length fits in int.
8730 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
8731
0065d054
PE
8732 * emacs.c (main): Do not reallocate argv, since there is a null at
8733 the end that can be overwritten, and this way there's no need to
8734 worry about size-calculation overflow.
8735 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
8736
8737 * eval.c (init_eval_once, grow_specpdl): Don't update size until
8738 alloc succeeds.
8739 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
8740
8741 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
8742 (x_set_scroll_bar_width, x_figure_window_size):
8743 Check for integer overflow.
8744 (x_set_alpha): Do not assume XINT fits in int.
8745
8746 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
8747 This is for the members text_lines, text_cols, total_lines, total_cols,
8748 where the system imposes an 'int' limit.
8749
8750 * fringe.c (Fdefine_fringe_bitmap):
8751 Don't update size until alloc works.
8752
8753 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
8754 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
8755
8756 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
8757 Check for size-calculation overflow.
8758 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
8759 do, as we prefer signed integers.
8760 (id_to_widget.max_size, id_to_widget.used)
8761 (xg_store_widget_in_map, xg_remove_widget_from_map)
8762 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
8763 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
8764 Use and return ptrdiff_t, not int.
8765 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
8766 * gtkutil.h: Change prototypes to match the above.
8767
8768 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
8769 are duplicate now that they've been promoted to lisp.h.
8770 (x_allocate_bitmap_record, x_alloc_image_color)
8771 (make_image_cache, cache_image, xpm_load):
8772 Don't update size until alloc is done.
8773 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
8774 (x_detect_edges):
3256efce 8775 Check for size calculation overflow.
726e0ab1
PE
8776 (ct_colors_allocated_max): New constant.
8777 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
8778 overflow.
3256efce 8779
726e0ab1
PE
8780 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
8781 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
8782 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
8783 Use ptrdiff_t, not int, to count maps.
8784 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
8785 calculations. Don't update size until allocation succeeds.
8786 Redo calculations to avoid overflow.
726e0ab1
PE
8787 * keyboard.h: Change prototypes to match the above.
8788
8789 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
8790 to count maps.
8791 (current_minor_maps): Check for size calculation overflow.
8792 * keymap.h: Change prototypes to match the above.
8793
8794 * lread.c (read1, init_obarray): Don't update size until alloc done.
8795
8796 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
8797 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
8798
726e0ab1
PE
8799 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
8800 Now ptrdiff_t, not int.
8801 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
8802 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
8803
8804 * process.c (Fnetwork_interface_list): Check for overflow
8805 in size calculation.
8806
8807 * region-cache.c (move_cache_gap): Check for size calculation overflow.
8808
8809 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
8810 overflow. Don't bother calling xmalloc when xrealloc will do.
8811
8812 * search.c (Freplace_match): Check for size calculation overflow.
8813 (Fset_match_data): Don't assume list lengths fit in 'int'.
8814
8815 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
8816 for command line length. Do not attempt to address one before the
8817 beginning of an array, as that's not portable.
8818
8819 * term.c (max_frame_lines): Remove; unused.
8820 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
8821 not int.
8822 (encode_terminal_code, calculate_costs): Check for size
8823 calculation overflow.
8824 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
8825 table lengths and related sizes. Don't update size until alloc
8826 done. Redo calculations to avoid overflow.
8827 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
8828
8829 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
8830 subtracting pointers.
8831 (gobble_line): Check for overflow more carefully. Don't update size
8832 until alloc done.
8833
8834 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
8835 Don't update size until alloc done.
8836 Redo size calculations to avoid overflow.
8837 Check for size calculation overflow.
0065d054 8838 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
8839
8840 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
8841 Use ptrdiff_t, not int, for sizes.
8842 (store_mode_line_noprop_char): Don't update size until alloc done.
8843
0065d054
PE
8844 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
8845 Use ptrdiff_t, not int, for sizes.
8846 (Finternal_make_lisp_face, cache_face):
8847 Check for size calculation overflow.
8848 (cache_face): Treat size calculation overflows as if they were
8849 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
8850
8851 * xfns.c (x_encode_text, x_set_name_internal)
8852 (Fx_change_window_property): Use ptrdiff_t, not int, to count
8853 sizes, since they can exceed INT_MAX in size. Check for size
8854 calculation overflow.
8855
0065d054
PE
8856 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
8857 (xg_select): Check for size calculation overflow.
726e0ab1
PE
8858 Don't update size until alloc done.
8859
0065d054 8860 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 8861 as sprintf is limited to int lengths.
1d526e2f 8862
252c5ee1
PE
8863 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
8864 (X_LONG_MIN): New macros.
864d7ce7
PE
8865 Use them to make the following changes clearer.
8866 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
8867 This change doesn't affect the value now, but it may help remind
8868 future maintainers not to raise the value too much later.
8869 (SELECTION_QUANTUM): Remove, replacing with ...
8870 (selection_quantum): ... new function, which avoids overflow.
8871 All uses changed.
8872 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
8873 assumption that selection length fits in 'int'.
8874 (x_reply_selection_request, x_handle_selection_request)
8875 (x_get_window_property, receive_incremental_selection)
8876 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
8877 (lisp_data_to_selection_data, clean_local_selection_data):
8878 Use ptrdiff_t, not int, to record length of selection.
8879 (x_reply_selection_request, x_get_window_property)
8880 (receive_incremental_selection, x_property_data_to_lisp):
8881 Redo calculations to avoid overflow.
8882 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 8883 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
8884 something.
8885 (x_get_window_property, receive_incremental_selection)
8886 (lisp_data_to_selection_data, x_property_data_to_lisp):
8887 Check for size-calculation overflow.
8888 (x_get_window_property, receive_incremental_selection)
8889 (lisp_data_to_selection_data, Fx_register_dnd_atom):
8890 Don't store size until memory allocation succeeds.
8891 (x_get_window_property): Plug memory leak on memory exhaustion.
8892 Don't double-block input; malloc is safe here. Don't assume 2**34
8893 - 4 fits in unsigned long. Add an xassert to check
8894 XGetWindowProperty overflow. Be more careful about overflow
8895 calculations, and distinguish size from memory overflow better.
8896 (receive_incremental_selection): When tracing, don't assume
8897 unsigned int is less than INT_MAX.
8898 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
8899 harmful) conversions of unsigned short to int.
8900 (lisp_data_to_selection_data): Don't assume that integers
8901 in the range -65535 through -1 fit in an X unsigned short.
8902 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
8903 result parameters unless successful. Rely on cons_to_unsigned
8904 to report problems with elements; the old code wasn't right anyway.
8905 (x_check_property_data): Check for int overflow; we cannot use
8906 a wider type due to X limits.
8907 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
8908
726e0ab1 8909 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 8910
0065d054
PE
8911 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
8912 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
8913 (x_color_cells): Don't store size until memory allocation succeeds.
8914 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 8915 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
8916 (x_term_init): Don't assume length fits in int (sprintf is limited
8917 to int size).
bc18e09d 8918
ebfa62c0
PE
8919 Use ptrdiff_t for composition IDs.
8920 * character.c (lisp_string_width):
8921 * composite.c (composition_table_size, n_compositions)
8922 (get_composition_id, composition_gstring_from_id):
8923 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
8924 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
8925 * window.c (Frecenter):
8926 Use ptrdiff_t, not int, for composition IDs.
8927 * composite.c (get_composition_id): Check for integer overflow.
8928 * composite.h: Adjust prototypes to match the above changes.
8929
d3411f89
PE
8930 Use ptrdiff_t for hash table indexes.
8931 * category.c (hash_get_category_set):
8932 * ccl.c (ccl_driver):
8933 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
8934 * coding.c (coding_system_charset_list, detect_coding_system):
8935 * coding.h (struct coding_system.id):
8936 * composite.c (get_composition_id, gstring_lookup_cache):
8937 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
8938 * image.c (xpm_get_color_table_h):
8939 * lisp.h (hash_lookup, hash_put):
8940 * minibuf.c (Ftest_completion):
8941 Use ptrdiff_t for hash table indexes, not int (which is too
8942 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
8943 32-bit --with-wide-int hosts).
8944
e097a6fa
PE
8945 * charset.c (Fdefine_charset_internal): Check for integer overflow.
8946 Add a FIXME comment about memory leaks.
8947 (syms_of_charset): Don't assume xmalloc returns.
8948
5637687f
PE
8949 Don't assume that stated character widths fit in int.
8950 * character.c (Fchar_width, c_string_width, lisp_string_width):
8951 * character.h (CHAR_WIDTH):
8952 * indent.c (MULTIBYTE_BYTES_WIDTH):
8953 Use sanitize_char_width to avoid undefined and/or bad behavior
8954 with outlandish widths.
a66cfb1c 8955 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
8956 now that we have two such functions. All uses changed.
8957 (sanitize_char_width): New inline function.
8958
a2271ba2
PE
8959 Don't assume that tab-width fits in int.
8960 * character.h (sanitize_width): New inline function.
8961 (SANE_TAB_WIDTH): New macro.
8962 (ASCII_CHAR_WIDTH): Use it.
8963 * indent.c (sane_tab_width): Remove. All uses replaced by
8964 SANE_TAB_WIDTH (current_buffer).
8965 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
8966
18c52557
PE
8967 * fileio.c: Integer overflow issues with file modes.
8968 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
8969
caeeedc1
PE
8970 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
8971 Remove unreachable code.
8972 (read_hex, load_charset_map_from_file): Check for integer overflow.
8973
6df6ae42 8974 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
8975 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
8976 (x_send_scroll_bar_event): Likewise. Check that the size does not
8977 exceed limits imposed by XClientMessageEvent, as well as the usual
8978 ptrdiff_t and size_t limits.
8979
b13995db
PE
8980 * keyboard.c: Overflow, signedness and related fixes.
8981 (make_lispy_movement): Use same integer type in forward decl
8982 that is used in the definition.
8983 (read_key_sequence, keyremap_step):
8984 Change bufsize argument back to int, undoing my 2011-03-30 change.
8985 We prefer signed types, and int is wide enough here.
8986 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
8987 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
8988 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
8989 length, not size_t. Use ptrdiff_t for index, not int.
8990 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
8991 possibility of integer overflow.
8992
13464394
PE
8993 Overflow, signedness and related fixes for images.
8994
8995 * dispextern.h (struct it.stack[0].u.image.image_id)
8996 (struct_it.image_id, struct image.id, struct image_cache.size)
8997 (struct image_cache.used, struct image_cache.ref_count):
8998 * gtkutil.c (update_frame_tool_bar):
8999 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
9000 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
9001 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
9002 * nsmenu.m (update_frame_tool_bar):
9003 * xdisp.c (calc_pixel_width_or_height):
9004 * xfns.c (image_cache_refcount):
9005 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
9006 on typical 64-bit hosts.
9007
9008 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
9009 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
9010 Omit unnecessary casts to int.
9011 (parse_image_spec): Check that integers fall into 'int' range
9012 when the callers expect that.
9013 (image_ascent): Redo ascent calculation to avoid int overflow.
9014 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
9015 (lookup_image): Remove unnecessary tests.
9016 (xbm_image_p): Locals are now of int, not EMACS_INT,
9017 since parse_image_check makes sure they fit into int.
9018 (png_load, gif_load, svg_load_image):
9019 Prefer int to unsigned where either will do.
9020 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
9021 old tiff_error_handler and tiff_warning_handler.
9022 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
9023 stack buffer overflows. It uses only the features of vsnprintf
9024 that are common to both POSIX and native Microsoft.
9025 (tiff_error_handler, tiff_warning_handler): Use it.
9026 (tiff_load, gif_load, imagemagick_load_image):
9027 Don't assume :index value fits in 'int'.
9028 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
9029 (imagemagick_load_image): Check that crop parameters fit into
9030 the integer types that MagickCropImage accepts. Don't assume
9031 Vimagemagick_render_type has a nonnegative value. Don't assume
9032 size_t fits in 'long'.
9033 (gs_load): Use printmax_t to print the widest integers possible.
9034 Check for integer overflow when computing image height and width.
9035
c11821d4
EZ
90362011-08-26 Eli Zaretskii <eliz@gnu.org>
9037
9038 * xdisp.c (redisplay_window): Don't force window start if point
9039 will be invisible in the resulting window. (Bug#9324)
9040
0c95fcf7
EZ
90412011-08-25 Eli Zaretskii <eliz@gnu.org>
9042
9043 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
9044 the display spec is of the form `(space ...)'.
9045 (handle_display_spec): Return the value returned by
9046 handle_single_display_spec, not just 1 or zero.
9047 (handle_single_display_spec): If the display spec is of the form
9048 `(space ...)', and specifies display in the text area, return 2
9049 rather than 1.
fee65a97 9050 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
9051 accurately, and prefer exact match for point under bidi.
9052 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
9053
9054 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
9055 into disp_prop; all users changed.
9056
9057 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
9058 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
9059 for the text covered by the display property.
9060
e4ed06f1
CY
90612011-08-25 Chong Yidong <cyd@stupidchicken.com>
9062
9063 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
9064 Change return value to nil.
9065 (Frecord_buffer): Delete unused function.
9066
f67cdd7f
EZ
90672011-08-24 Eli Zaretskii <eliz@gnu.org>
9068
5980d4c6
EZ
9069 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
9070 buffers, return left-to-right.
8610fe8b
EZ
9071 (set_cursor_from_row): Consider candidate row a win if its glyph
9072 represents a newline and point is on that newline. Fixes cursor
9073 positioning on the newline at EOL of R2L text within L2R
9074 paragraph, and vice versa.
9075 (try_cursor_movement): Check continued rows, in addition to
9076 continuation rows. Fixes unwarranted scroll when point enters a
9077 continued line of R2L text within an L2R paragraph, or vice versa.
9078 (cursor_row_p): Consider the case of point being equal to
9079 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
9080 from the end of a short line to the beginning of a continued line
9081 of R2L text within L2R paragraph.
9082 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
9083 composed characters.
5980d4c6 9084
f67cdd7f
EZ
9085 * bidi.c (bidi_check_type): Use xassert.
9086 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
9087 members.
9088
bca633fb
EZ
90892011-08-23 Eli Zaretskii <eliz@gnu.org>
9090
9091 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
9092 a character.
9093
4a5885a7
CY
90942011-08-23 Chong Yidong <cyd@stupidchicken.com>
9095
9096 * nsfont.m (ns_otf_to_script): Fix typo.
9097
0902a04e
KH
90982011-08-22 Kenichi Handa <handa@m17n.org>
9099
9100 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
9101 extra slot even if the purpose is char-code-property-table.
9102
1a2e6670
EZ
91032011-08-23 Eli Zaretskii <eliz@gnu.org>
9104
8ddde651
EZ
9105 * xdisp.c (redisplay_window): When computing centering_position,
9106 account for the height of the header line. (Bug#8874)
9107
425cc014
EZ
9108 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
9109 instead of CHAR_TO_BYTE. Fixes a crash when a completion
9110 candidate is selected by the mouse, and that candidate has a
9111 composed character under the mouse.
9112
1a2e6670
EZ
9113 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
9114 coordinates reported by pos-visible-in-window-p for a composed
9115 character in column zero.
9116
8b76d6f8
SM
91172011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
9118
9119 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
9120
dac347dd
EZ
91212011-08-22 Eli Zaretskii <eliz@gnu.org>
9122
9123 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
9124 consider it a hit if to_charpos is anywhere in the range of the
9125 composed buffer positions.
9126
e013fb34
CY
91272011-08-22 Chong Yidong <cyd@stupidchicken.com>
9128
9129 * image.c (gif_load): Don't assume that each subimage has the same
9130 dimensions as the base image. Handle disposal method that is
9131 "undefined" by the gif spec (Bug#9335).
9132
bd1ba3e8
CY
91332011-08-20 Chong Yidong <cyd@stupidchicken.com>
9134
9135 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 9136 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 9137
54a1215b
EZ
91382011-08-19 Eli Zaretskii <eliz@gnu.org>
9139
823564e5
EZ
9140 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
9141 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
9142 from an Org mode buffer to a Speedbar frame.
9143
54a1215b
EZ
9144 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
9145 a composition, take its buffer position from IT->cmp_it.charpos.
9146 Fixes cursor positioning at the beginning of a line that begins
9147 with a composed character.
9148
9778ebcc
EZ
91492011-08-18 Eli Zaretskii <eliz@gnu.org>
9150
0be6ee06
EZ
9151 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
9152 character bidirectional type, use STRONG_L instead. Fixes crashes
9153 in a buffer produced by `describe-categories'.
9154
9778ebcc
EZ
9155 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
9156 members before the level stack, so they would be saved and
9157 restored when copying iterator state. Fixes incorrect reordering
9158 around TABs covered by display properties.
9159
156bffbe
AS
91602011-08-18 Andreas Schwab <schwab@linux-m68k.org>
9161
6b02f655 9162 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 9163
72ad093b
CY
91642011-08-17 Chong Yidong <cyd@stupidchicken.com>
9165
9166 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
9167 (internal_condition_case_2, internal_condition_case_n):
9168 Remove unnecessary aborts (Bug#9081).
72ad093b 9169
35774242
EZ
91702011-08-17 Eli Zaretskii <eliz@gnu.org>
9171
9172 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
9173 has no `load' handler, try opening the file locally. (Bug#9311)
9174
db76dd85
KB
91752011-08-16 Ken Brown <kbrown@cornell.edu>
9176
9177 * gmalloc.c: Expand comment.
9178
b215eee5
EZ
91792011-08-16 Eli Zaretskii <eliz@gnu.org>
9180
9181 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
9182 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
9183
a4579d33
KB
91842011-08-16 Ken Brown <kbrown@cornell.edu>
9185
9186 Fix memory allocation problems in Cygwin build (Bug#9273).
9187
9188 * unexcw.c ( __malloc_initialized): Declare external variable.
9189 (fixup_executable): Force the dumped emacs to reinitialize malloc.
9190
8b76d6f8
SM
9191 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
9192 New variables.
a4579d33
KB
9193 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
9194 dumped emacs.
9195 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
9196 in the static heap.
9197 [CYGWIN] (special_realloc): New function.
9198 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
9199 requests to realloc storage in the static heap.
9200
3ebec551
PE
92012011-08-15 Paul Eggert <eggert@cs.ucla.edu>
9202
9203 * bidi.c (bidi_initialize): Remove unused local.
9204
9fd8be00
EZ
92052011-08-15 Eli Zaretskii <eliz@gnu.org>
9206
6b02f655
SM
9207 * bidimirror.h:
9208 * biditype.h: Remove file.
9209 * makefile.w32-in ($(BLD)/bidi.$(O)):
9210 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
9211
9212 * dispextern.h: Fix a typo in the comment to bidi_type_t.
9213
9214 * chartab.c: Improve commentary for the uniprop_table API.
9215
32413314
EZ
9216 * bidi.c (bidi_paragraph_init): Support zero value of
9217 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
9218 (bidi_initialize): Use uniprop_table instead of including
9219 biditype.h and bidimirror.h.
32413314 9220
9fd8be00
EZ
9221 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
9222 coordinates of the iterator when restoring from ppos_it.
9223 (Bug#9296)
9224
5cf2b69b
KH
92252011-08-14 Kenichi Handa <handa@m17n.org>
9226
9227 * process.c (create_process): Call setup_process_coding_systems
72ad093b 9228 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 9229
daf17d00
EZ
92302011-08-14 Eli Zaretskii <eliz@gnu.org>
9231
9232 * xdisp.c (move_it_in_display_line_to): Don't invoke
9233 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
9234 ppos_it. Fixes vertical cursor motion when line beginning is
9235 covered by an image. (Bug#9296)
9236
08e3161a
JD
92372011-08-14 Jan Djärv <jan.h.d@swipnet.se>
9238
9239 * nsterm.h (ns_run_ascript): Declare.
9240 (NSAPP_DATA2_RUNASSCRIPT): Define.
9241
9242 * nsfns.m (as_script, as_result, as_status): New static variables.
9243 (ns_run_ascript): New function.
5e617bc2 9244 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
9245 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
9246 the event loop. Get status from as_status (Bug#7276).
9247
9248 * nsterm.m (sendEvent): If event is NSApplicationDefined and
9249 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
9250 the event loop (Bug#7276).
9251
a3720aa2
AS
92522011-08-14 Andreas Schwab <schwab@linux-m68k.org>
9253
9254 * gnutls.c (QCgnutls_bootprop_priority)
9255 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
9256 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
9257 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
9258 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
9259 (QCgnutls_bootprop_verify_hostname_error)
9260 (QCgnutls_bootprop_callbacks_verify): Rename from
9261 Qgnutls_bootprop_..., all uses changed.
9262
9263 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
9264 uses changed.
9265
0a0d27fb
PE
92662011-08-14 Paul Eggert <eggert@cs.ucla.edu>
9267
19d5c50c
PE
9268 * xfaces.c (Qframe_set_background_mode): Now static.
9269 * dispextern.h (Qframe_set_background_mode): Remove decl.
9270
0a0d27fb
PE
9271 * process.c (Fnetwork_interface_info): Declare local only if needed.
9272
377538cb
JD
92732011-08-13 Jan Djärv <jan.h.d@swipnet.se>
9274
9275 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
9276 (Fnetwork_interface_list): Allocate in increments of bytes instead
9277 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
9278 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
9279 sockaddr.
9280 (struct ifflag_def): notrailers is smart on OSX.
9281 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
9282 Get hardware address with getifaddrs if available.
9283
08fff70c
EZ
92842011-08-12 Eli Zaretskii <eliz@gnu.org>
9285
9286 * xdisp.c (iterate_out_of_display_property): xassert that
9287 IT->position is set to within IT->object's boundaries. Break from
9288 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
9289 when IT->position is set up wrongly due to some bug.
9290 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
9291 (push_display_prop): Allow GET_FROM_STRING as IT->method on
9292 entry. Force push_it to save on the stack the current
9293 buffer/string position, to be restored by pop_it. Fix flags in
9294 the iterator structure wrt the object coming from a display
9295 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
9296 properties. (Bug#9284)
9297
7be1c708 92982011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 9299
7be1c708
CY
9300 * fontset.c (fontset_get_font_group): Add proper type checks.
9301 (Bug#9172)
aac0c6e3 9302
7be1c708 93032011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 9304
7be1c708
CY
9305 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
9306 and LC_VERSION_MIN_MACOSX.
9307 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
9308 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 9309
97bb72a6
EZ
93102011-08-08 Eli Zaretskii <eliz@gnu.org>
9311
9312 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
9313 no-display-properties-and-no-overlays under bidi display.
9314 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 9315 properties and overlays.
97bb72a6 9316
d5617611
CY
93172011-08-08 Chong Yidong <cyd@stupidchicken.com>
9318
37e11a63
CY
9319 * editfns.c (Fset_time_zone_rule): Document relationship with the
9320 setenv function.
9321
d5617611
CY
9322 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
9323 the font entity extracted from the cache (Bug#8109).
9324
58872834
CY
93252011-08-07 Chong Yidong <cyd@stupidchicken.com>
9326
9327 * composite.c (autocmp_chars): Don't reset point. That is done by
9328 restore_point_unwind (Bug#5984).
9329
75bfc667
JL
93302011-08-07 Juri Linkov <juri@jurta.org>
9331
9332 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
9333 to show the arg `TIME' instead of `TIMEVAL'.
9334
d1410150
EZ
93352011-08-06 Eli Zaretskii <eliz@gnu.org>
9336
9337 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
9338 display property strides EOL and includes a newline, as in
9339 longlines-mode. (Bug#9254)
75b771e4
EZ
9340 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
9341 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
9342
9343 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
9344 is non-zero, even if the data buffer is NULL. Fixes a crash in
9345 vertical-motion with longlines-mode. (Bug#9254)
9346
35928349
EZ
93472011-08-05 Eli Zaretskii <eliz@gnu.org>
9348
ec7cc85b
EZ
9349 * bidi.c <bidi_cache_total_alloc>: Now static.
9350 (bidi_initialize): Initialize bidi_cache_total_alloc.
9351
8b76d6f8 9352 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
9353 cache. (Bug#9221)
9354
9355 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
9356 amount allocated this far in `bidi_cache_total_alloc'.
9357 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
9358 non-zero, only free the data buffer without restoring the cache
9359 contents. All callers changed.
9360
9361 * dispextern.h (bidi_unshelve_cache): Update prototype.
9362
9363 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
9364 (move_it_in_display_line, move_it_to)
9365 (move_it_vertically_backward, move_it_by_lines): Replace the call
9366 to xfree to an equivalent call to bidi_unshelve_cache.
9367 (move_it_in_display_line_to): Fix logic of returning
412b6358 9368 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 9369
e2e2423b
EZ
93702011-08-05 Eli Zaretskii <eliz@gnu.org>
9371
9372 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
9373 came from a string character with a `cursor' property. (Bug#9229)
9374
ae9e757a
JD
93752011-08-04 Jan Djärv <jan.h.d@swipnet.se>
9376
9377 * Makefile.in (LIB_PTHREAD): New variable.
9378 (LIBES): Add LIB_PTHREAD (Bug#9216).
9379
9380 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
9381 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
9382
213bd7f2
AS
93832011-08-04 Andreas Schwab <schwab@linux-m68k.org>
9384
6b02f655 9385 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 9386
99aaf75f
JD
93872011-08-04 Jan Djärv <jan.h.d@swipnet.se>
9388
9389 * xterm.c (x_find_topmost_parent): New function.
9390 (x_set_frame_alpha): Find topmost parent window with
9391 x_find_topmost_parent and set the property there also (bug#9181).
9392 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
9393
c74e9d86
PE
93942011-08-04 Paul Eggert <eggert@cs.ucla.edu>
9395
9396 * callproc.c (Fcall_process): Avoid vfork clobbering
9397 the local vars buffer, coding_systems, current_dir.
9398
640c8776
SM
93992011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
9400
9401 * keymap.c (Fmake_composed_keymap): Move to subr.el.
9402
f26d0e4c
PE
94032011-08-03 Paul Eggert <eggert@cs.ucla.edu>
9404
8a10d76c
PE
9405 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
9406 so that it is not optimized away.
9407
f26d0e4c
PE
9408 * xdisp.c (compute_display_string_pos): Remove unused local.
9409
55439c61
EZ
94102011-08-02 Eli Zaretskii <eliz@gnu.org>
9411
9412 Fix slow cursor motion and scrolling in large buffers with
9413 selective display, like Org Mode buffers. (Bug#9218)
9414
9415 * dispextern.h (struct bidi_it): New member disp_prop_p.
9416
9417 * xdisp.c: Remove one-slot cache of display string positions.
9418 (compute_display_string_pos): Accept an additional argument
5e617bc2 9419 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
9420 for a display string or property. If found, set DISP_PROP_P
9421 non-zero.
9422
9423 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
9424 DISP_PROP_P, and pass it to compute_display_string_pos.
9425 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
9426 non-zero. All callers of bidi_fetch_char changed.
9427
fb33fa43
SM
94282011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
9429
9430 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
9431
b099e063
DM
94322010-12-03 Don March <don@ohspite.net>
9433
9434 * keymap.c (Fdefine_key): Fix non-prefix key error message when
9435 last character M-[char] is translated to ESC [char] (bug#7541).
9436
5cc7f7af
KH
94372011-08-02 Kenichi Handa <handa@m17n.org>
9438
d0fffa3f 9439 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
9440
9441 * chartab.c (uniprop_table): Make it non-static.
9442
525d5e6e
EZ
94432011-08-01 Eli Zaretskii <eliz@gnu.org>
9444
9445 * xdisp.c (forward_to_next_line_start): Accept additional argument
9446 BIDI_IT_PREV, and store into it the state of the bidi iterator had
9447 on the newline.
9448 (reseat_at_next_visible_line_start): Use the bidi iterator state
9449 returned by forward_to_next_line_start to restore the state of
9450 it->bidi_it after backing up to previous newline. (Bug#9212)
9451
31011111
AS
94522011-07-30 Andreas Schwab <schwab@linux-m68k.org>
9453
9454 * regex.c (re_comp): Protoize.
9455 (re_exec): Fix return type.
9456 (regexec): Fix type of `ret'. (Bug#9203)
9457
476371c4
PE
94582011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9459
e5d76069
PE
9460 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
9461 This is needed if max-image-size is a floating-point number.
9462
9a79b20c
AS
94632011-07-28 Andreas Schwab <schwab@linux-m68k.org>
9464
9465 * print.c (print_object): Print empty symbol as ##.
9466
9467 * lread.c (read1): Read ## as empty symbol.
9468
d8c2fa78
AA
94692011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
9470
9471 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
9472 setting frame foreground color (Bug#9175).
9473 (x_set_background_color): Likewise.
9474
ffe57a7a
AA
9475 * nsmenu.m (-setText): Size tooltip dimensions precisely to
9476 contents (Bug#9176).
9477 (EmacsTooltip -init): Remove bezels and add shadows to
9478 tooltip windows.
9479
bf3492a5
AA
9480 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
9481 or scroll bar (Bug#8470).
9482
d55e9c53
AA
9483 * nsfont.m (nsfont_open): Remove assignment to voffset and
9484 unnecessary vars hshink, expand, hd, full_height, min_height.
9485 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
9486
9487 * nsterm.h (nsfont_info): Remove voffset field.
9488
d8c2fa78 94892011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
9490
9491 Implement strike-through and overline on NextStep (Bug#8863).
9492
9493 * nsfont.m (nsfont_open): Use underline position provided by font,
9494 instead of hard-coded value of 2.
9495 (nsfont_draw): Call ns_draw_text_decoration instead.
9496
9497 * nsterm.h: Add declaration for ns_draw_text_decoration.
9498
9499 * nsterm.m (ns_draw_text_decoration): New function for drawing
9500 underline, overline, and strike-through.
9501 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
9502 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 9503 accommodate underlining, etc.
4843aac3 9504
4cc60b9b
EZ
95052011-07-28 Eli Zaretskii <eliz@gnu.org>
9506
bc7ece87
EZ
9507 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
9508 default.
4cc60b9b 9509
476371c4
PE
95102011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9511
66606eea
PE
9512 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
9513 Without this fix, if a signal arrives just after memory fills up,
9514 'malloc' might be invoked reentrantly.
9515
476371c4
PE
9516 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
9517 In other words, assume that every image size is allowed, on non-X
9518 hosts. This assumption is probably wrong, but it lets Emacs compile.
9519
f3fcc40d
AS
95202011-07-28 Andreas Schwab <schwab@linux-m68k.org>
9521
9522 * regex.c (re_iswctype): Convert return values to boolean.
9523
350c992f
EZ
95242011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
9525
9526 * xdisp.c (compute_display_string_pos): Don't use cached display
9527 string position if the buffer had its restriction changed.
9528 (Bug#9184)
9529
5266b4bb
PE
95302011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9531
9532 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9533
2573a837 95342011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 9535
41f55ccd 9536 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 9537
39e378da
PE
9538 * bidi.c: Integer size and overflow fixes.
9539 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
9540 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
9541 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9542 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
9543 (bidi_find_other_level_edge):
9544 Use ptrdiff_t instead of EMACS_INT where either will do.
9545 This works better on 32-bit hosts configured --with-wide-int.
9546 (bidi_cache_ensure_space): Check for size-calculation overflow.
9547 Use % rather than repeated addition, for better worst-case speed.
9548 Don't set bidi_cache_size until after xrealloc returns, because it
9549 might not return.
9550 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
9551 (bidi_cache_ensure_space): Also check that the bidi cache size
9552 does not exceed that of the largest Lisp string or buffer. See Eli
9553 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 9554
5e927815
PE
9555 * alloc.c (__malloc_size_t): Remove.
9556 All uses replaced by size_t. See Andreas Schwab's note
9557 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
9558
ca4aa935
PE
9559 * image.c: Improve checking for integer overflow.
9560 (check_image_size): Assume that f is nonnull, since
9561 it is always nonnull in practice. This is one less thing to
9562 worry about when checking for integer overflow later.
9563 (x_check_image_size): New function, which checks for integer
9564 overflow issues inside X.
9565 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
9566 This removes the need for a memory_full check.
9567 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
9568 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
9569 (xbm_read_bitmap_data): Change locals back to 'int', since
9570 their values must fit in 'int'.
9571 (xpm_load_image, png_load, tiff_load):
9572 Invoke x_create_x_image_and_pixmap earlier,
9573 to avoid much needless work if the image is too large.
9574 (tiff_load): Treat overly large images as if
9575 x_create_x_image_and_pixmap failed, not as malloc failures.
9576 (gs_load): Use x_check_image_size.
9577
5f8f9cc2
PE
9578 * gtkutil.c: Omit integer casts.
9579 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
9580 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
9581
5adf60bc
PE
9582 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
9583
c8907a93
PE
9584 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
9585 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
9586 would wrongly return t on a 64-bit host.
9587
e3c25c68
PE
9588 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
9589 The plain *_OVERFLOW macros run afoul of GCC bug 49705
9590 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
9591 and therefore cause GCC to emit a bogus diagnostic in some cases.
9592
3f791afe
PE
9593 * image.c: Integer signedness and overflow and related fixes.
9594 This is not an exhaustive set of fixes, but it's time to
9595 record what I've got.
9596 (lookup_pixel_color, check_image_size): Remove redundant decls.
9597 (check_image_size): Don't assume that arbitrary EMACS_INT values
9598 fit in 'int', or that arbitrary 'double' values fit in 'int'.
9599 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
9600 (tiff_load, imagemagick_load_image):
9601 Check for overflow in size calculations.
9602 (x_create_x_image_and_pixmap): Remove unnecessary test for
9603 xmalloc returning NULL; that can't happen.
9604 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
9605 (xpm_color_bucket): Use better integer hashing function.
9606 (xpm_cache_color): Don't possibly over-allocate memory.
9607 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
9608 (gif_memory_source):
9609 Use ptrdiff_t, not int or size_t, to record sizes.
9610 (png_load): Don't assume values greater than 2**31 fit in 'int'.
9611 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
9612 either works, as we prefer signed integers.
9613 (tiff_read_from_memory, tiff_write_from_memory):
9614 Return tsize_t, not size_t, since that's what the TIFF API wants.
9615 (tiff_read_from_memory): Don't fail simply because the read would
9616 go past EOF; instead, return a short read.
9617 (tiff_load): Omit no-longer-needed casts.
9618 (Fimagemagick_types): Don't assume size fits into 'int'.
9619
3cc5a532
PE
9620 Improve hashing quality when configured --with-wide-int.
9621 * fns.c (hash_string): New function, taken from sxhash_string.
9622 Do not discard information about ASCII character case; this
9623 discarding is no longer needed.
9624 (sxhash-string): Use it. Change sig to match it. Caller changed.
9625 * lisp.h: Declare it.
9626 * lread.c (hash_string): Remove, since we now use fns.c's version.
9627 The fns.c version returns a wider integer if --with-wide-int is
9628 specified, so this should help the quality of the hashing a bit.
9629
b312a492
PE
9630 * emacs.c: Integer overflow minor fix.
9631 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
9632 Define only if GNU_LINUX.
9633 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
9634
dfd153ae
PE
9635 * dispnew.c: Integer signedness and overflow fixes.
9636 Remove unnecessary forward decls, that were a maintenance hassle.
9637 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
9638 All uses changed.
9639 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
9640 (scrolling_window): Use ptrdiff_t, not int, for byte count.
9641 (prepare_desired_row, line_draw_cost):
9642 Use int, not unsigned, where either works.
9643 (save_current_matrix, restore_current_matrix):
9644 Use ptrdiff_t, not size_t, where either works.
9645 (init_display): Check for overflow more accurately, and without
9646 relying on undefined behavior.
9647
a81d11a3
PE
9648 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
9649 Remove, replacing with the new symbols in lisp.h. All uses changed.
9650 * fileio.c (make_temp_name):
9651 * filelock.c (lock_file_1, lock_file):
9652 * xdisp.c (message_dolog):
9653 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
9654 Use pMd etc. instead.
9655 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
9656 replacing the pWIDE etc. symbols removed from editfns.c.
9657
3300e6fd
PE
9658 * keyboard.h (num_input_events): Now uintmax_t.
9659 This is (very slightly) less likely to mess up due to wraparound.
9660 All uses changed.
9661
fd05c7e9
PE
9662 * buffer.c: Integer signedness fixes.
9663 (alloc_buffer_text, enlarge_buffer_text):
9664 Use ptrdiff_t rather than size_t when either will do, as we prefer
9665 signed integers.
9666
903fe15d
PE
9667 * alloc.c: Integer signedness and overflow fixes.
9668 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
9669 (__malloc_size_t): Default to size_t, not to int.
9670 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
9671 (Fgarbage_collect, mark_object_loop_halt, mark_object):
9672 Prefer ptrdiff_t to size_t when either would do, as we prefer
9673 signed integers.
9674 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
9675 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
9676 Now const. Initialize with values that are in range even if char
9677 is signed.
9678 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
9679 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
9680 These functions do the right thing with sizes > 2**32.
9681 (check_depth): Now ptrdiff_t, not int.
9682 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
9683 Adjust to new way of storing sizes. Check for size overflow bugs
9684 in rest of code.
9685 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
9686 slightly wrong anyway, as it missed one instance of
9687 XMALLOC_OVERRUN_CHECK_OVERHEAD.
9688 (refill_memory_reserve): Omit needless cast to size_t.
9689 (mark_object_loop_halt): Mark as externally visible.
9690
ac82cc6a
PE
9691 * xselect.c: Integer signedness and overflow fixes.
9692 (Fx_register_dnd_atom, x_handle_dnd_message):
9693 Use ptrdiff_t, not size_t, since we prefer signed.
9694 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
9695 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
9696 x_dnd_atoms_size and x_dnd_atoms_length.
9697
c2d1e36d
PE
9698 * doprnt.c: Prefer signed to unsigned when either works.
9699 * eval.c (verror):
9700 * doprnt.c (doprnt):
9701 * lisp.h (doprnt):
9702 * xdisp.c (vmessage):
9703 Use ptrdiff_t, not size_t, when using or implementing doprnt,
9704 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
9705 prefer signed arithmetic to avoid comparison confusion.
9706 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
9707 but is a bit tricky.
9708
0e926e56
PE
9709 Assume freestanding C89 headers, string.h, stdlib.h.
9710 * data.c, doprnt.c, floatfns.c, print.c:
9711 Include float.h unconditionally.
9712 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
9713 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
9714 * regex.c: Likewise for stddef.h, string.h.
9715 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
9716 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
9717 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
9718 (STDC_HEADERS): Remove obsolete defines.
9719 * sysdep.c: Include limits.h unconditionally.
9720
9cfdb3ec
PE
9721 Assume support for memcmp, memcpy, memmove, memset.
9722 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
9723 * regex.c (memcmp, memcpy):
9724 Remove; we assume C89 now.
9725
9726 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
9727 (__malloc_safe_bcopy): Remove; no longer needed.
9728
cf950e6b 9729 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
9730 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
9731 well either way, and we prefer signed to unsigned.
9732
dbf38e02
LMI
97332011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
9734
9735 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
9736 closes the connection while we're reading (bug#9182).
9737
d6f0886c 97382011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 9739
d6f0886c
JD
9740 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
9741 are specified (Bug#9168).
24e0f6b1 9742
2eb1f9e6
PE
97432011-07-25 Paul Eggert <eggert@cs.ucla.edu>
9744
9745 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
9746 Found by GCC static checking and --with-wide-int on a 32-bit host.
9747
22381272 97482011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
9749
9750 * xdisp.c (compute_display_string_pos): Fix logic of caching
9751 previous display string position. Initialize cached_prev_pos to
9752 -1. Fixes slow-down at the beginning of a buffer.
9753
f25e39b4
EZ
97542011-07-24 Eli Zaretskii <eliz@gnu.org>
9755
9756 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
9757 for attrs[LFACE_FONTSET_INDEX].
9758
04c4b52e
PE
97592011-07-23 Paul Eggert <eggert@cs.ucla.edu>
9760
9761 * xml.c (parse_region): Remove unused local
9762 that was recently introduced.
9763
c1734fbd
EZ
97642011-07-23 Eli Zaretskii <eliz@gnu.org>
9765
be18c5a5
EZ
9766 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
9767 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
9768
c1734fbd
EZ
9769 * xdisp.c (move_it_in_display_line_to): Record the best matching
9770 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
9771 exit if none of the characters scanned was an exact match.
9772 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
9773 when exact match is impossible due to invisible text, and the
9774 lines are truncated.
9775
a258d627
JD
97762011-07-23 Jan Djärv <jan.h.d@swipnet.se>
9777
9778 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
9779 for OSX >= 10.7.
9780
b6d5a689
EZ
97812011-07-22 Eli Zaretskii <eliz@gnu.org>
9782
0f74f785
EZ
9783 Fix a significant slow-down of cursor motion with C-n, C-p,
9784 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
9785 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 9786 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
9787 (next_element_from_buffer): Call compute_stop_pos_backwards to
9788 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
9789 base_level_stop.
9790 (reseat): Don't look for prev_stop, as that could mean a very long
9791 run.
9792 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
9793 <cached_disp_overlay_modiff>: Cache for last found display string
9794 position.
551918c1 9795 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
9796 about the same buffer in the same area of character positions, and
9797 the buffer wasn't changed since the time the display string
9798 position was cached.
551918c1 9799
b2d0c91a
EZ
98002011-07-22 Eli Zaretskii <eliz@gnu.org>
9801
9802 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
9803 is an integer, which is important for empty lines. (Bug#9149)
9804
043604ee
CY
98052011-07-22 Chong Yidong <cyd@stupidchicken.com>
9806
9807 * frame.c (Fmodify_frame_parameters): In tty case, update the
9808 default face if necessary (Bug#4238).
9809
da4adb04
CY
98102011-07-21 Chong Yidong <cyd@stupidchicken.com>
9811
9812 * editfns.c (Fstring_to_char): No need to explain what a character
9813 is in the docstring (Bug#6576).
9814
9abd0532
LMI
98152011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9816
9817 * xml.c (parse_region): Make sure we always return a tree.
9818
36881d16
HK
98192011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
9820
9821 * xml.c (parse_region): If a document contains only comments,
9822 return that, too.
9823
1e98674d
LMI
98242011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9825
9826 * xml.c (make_dom): Return comments, too.
9827
590bd467
PE
98282011-07-19 Paul Eggert <eggert@cs.ucla.edu>
9829
9830 Port to OpenBSD.
9831 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
9832 and the surrounding thread.
9833 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
9834 rather than fgets, and retry after EINTR. Otherwise, 'emacs
9835 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
9836 timer goes off.
9837 * s/openbsd.h (BROKEN_SIGIO): Define.
9838 * unexelf.c (unexec) [__OpenBSD__]:
9839 Don't update the .mdebug section of the Alpha COFF symbol table.
9840
f41628b2
LMI
98412011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
9842
9843 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
9844 (bug#8460).
9845
b59b67c5
PE
98462011-07-18 Paul Eggert <eggert@cs.ucla.edu>
9847
15e3a074
PE
9848 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
9849 This fixes some race conditions on the permissions of any newly
9850 created file.
9851
41bed37d
PE
9852 * alloc.c (valid_pointer_p): Use pipe, not open.
9853 This fixes some permissions issues when debugging.
9854
b59b67c5
PE
9855 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
9856 If fchown fails to set both uid and gid, try to set just gid,
9857 as that is sometimes allowed. Adjust the file's mode to eliminate
9858 setuid or setgid bits that are inappropriate if fchown fails.
9859
925a6be7
SM
98602011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
9861
9862 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
9863 to compare Lisp_Objects.
9864 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
9865 global_gnutls_log_level, don't mistake it for a Lisp_Object.
9866 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
9867
52968808
AS
98682011-07-17 Andreas Schwab <schwab@linux-m68k.org>
9869
0a6a104b
AS
9870 * lread.c (read_integer): Unread even EOF character.
9871 (read1): Likewise. Properly record start position of symbol.
9872
52968808
AS
9873 * lread.c (read1): Read `#:' as empty uninterned symbol if no
9874 symbol character follows.
9875
9e381cdd
PE
98762011-07-17 Paul Eggert <eggert@cs.ucla.edu>
9877
9878 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
9879 This works around a problem with the previous change to Fcopy_file.
9880 Recent glibc declares fchown with __attribute__((warn_unused_result)),
9881 and without this change, GCC might complain about discarding
9882 fchown's return value.
9883
b5641435
JB
98842011-07-16 Juanma Barranquero <lekktu@gmail.com>
9885
9886 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
9887
a8031457
PE
98882011-07-16 Paul Eggert <eggert@cs.ucla.edu>
9889
9890 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
9891
dd889327
LMI
98922011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
9893
750c33f7
LMI
9894 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
9895 it's used from the C level.
9896
dd889327
LMI
9897 * process.c: Use the same condition for POLL_FOR_INPUT in both
9898 keyboard.c and process.c (bug#1858).
9899
87e86684
LM
99002011-07-09 Lawrence Mitchell <wence@gmx.li>
9901
9902 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
9903 (Fgnutls_boot): Use it.
9904
64348f40
AS
99052011-07-15 Andreas Schwab <schwab@linux-m68k.org>
9906
9907 * doc.c (Fsubstitute_command_keys): Revert last change.
9908
1d698799
LMI
99092011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
9910
f863868c
LMI
9911 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
9912 quotes the next character, and doesn't affect other longer
9913 sequences (bug#8935).
9914
1d698799
LMI
9915 * lread.c (syms_of_lread): Clarify that is isn't only
9916 `eval-buffer' and `eval-defun' that's affected by
9917 `lexical-binding' (bug#8460).
9918
aa4b6df6
EZ
99192011-07-15 Eli Zaretskii <eliz@gnu.org>
9920
9921 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 9922 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 9923
5d856da6
PE
99242011-07-14 Paul Eggert <eggert@cs.ucla.edu>
9925
ad6042bb
PE
9926 Fix minor problems found by static checking.
9927 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
9928 (elsz): Now a signed constant, not a size_t var. We prefer signed
9929 types to unsigned, to avoid integer comparison confusion. Without
9930 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
9931 "cannot optimize loop, the loop counter may overflow", a symptom
9932 of the confusion.
f00bbb22 9933 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
9934 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
9935
6468f31c
LMI
99362011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9937
49080b10
LMI
9938 * search.c (Fre_search_backward): Mention `case-fold-search' in
9939 all the re_search_* functions (bug#8138).
9940
6468f31c
LMI
9941 * keyboard.c (Fopen_dribble_file): Document when the file is
9942 closed (bug#8056).
9943
c965adc5
EZ
99442011-07-14 Eli Zaretskii <eliz@gnu.org>
9945
df9733bf
EZ
9946 * bidi.c (bidi_dump_cached_states): Fix format of displaying
9947 bidi_cache_idx.
9948
0bb23927
EZ
9949 Support bidi reordering of display and overlay strings.
9950 * xdisp.c (compute_display_string_pos)
9951 (compute_display_string_end): Accept additional argument STRING.
9952 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
9953 (reseat_to_string): Initialize bidi_it->string.s and
9954 bidi_it->string.schars.
9955 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
9956 NULL (avoids a crash in bidi_paragraph_init).
9957 Initialize itb.string.lstring.
0bb23927
EZ
9958 (init_iterator): Call bidi_init_it only of a valid
9959 buffer position was specified. Initialize paragraph_embedding to
9960 L2R.
9961 (reseat_to_string): Initialize the bidi iterator.
9962 (display_string): If we need to ignore text properties of
9963 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
9964 original value of -1 will not work with bidi.)
9965 (compute_display_string_pos): First arg is now struct
9966 `text_pos *'; all callers changed. Support display properties on
9967 Lisp strings.
9968 (compute_display_string_end): Support display properties on Lisp
9969 strings.
9970 (init_iterator, reseat_1, reseat_to_string): Initialize the
9971 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
9972 when iterating on a string not from display properties).
640c8776
SM
9973 (compute_display_string_pos, compute_display_string_end):
9974 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
9975 arrow keys.
9976 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
9977 base_level_stop; instead, set base_level_stop to BEGV.
9978 Fixes crashes in vertical-motion.
0bb23927
EZ
9979 (next_element_from_buffer): Improve commentary for when
9980 the iterator is before prev_stop.
9981 (init_iterator): Initialize bidi_p from the default value of
9982 bidi-display-reordering, not from buffer-local value. Use the
9983 buffer-local value only if initializing for buffer iteration.
9984 (handle_invisible_prop): Support invisible properties on strings
9985 that are being bidi-reordered.
9986 (set_iterator_to_next): Support bidi reordering of C strings and
9987 Lisp strings.
9988 (next_element_from_string): Support bidi reordering of Lisp
9989 strings.
9990 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
9991 (display_string): Support display of R2L glyph rows.
9992 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
9993 (init_iterator): Don't initialize it->bidi_p for strings
9994 here.
9995 (reseat_to_string): Initialize it->bidi_p for strings here.
9996 (next_element_from_string, next_element_from_c_string)
9997 (next_element_from_buffer): Add xassert's for correspondence
9998 between IT's object being iterated and it->bidi_it.string
9999 structure.
10000 (face_before_or_after_it_pos): Support bidi iteration.
10001 (next_element_from_c_string): Handle the case of the first string
10002 character that is not the first one in the visual order.
10003 (get_visually_first_element): New function, refactored from common
10004 parts of next_element_from_buffer, next_element_from_string, and
10005 next_element_from_c_string.
10006 (tool_bar_lines_needed, redisplay_tool_bar)
10007 (display_menu_bar): Force left-to-right direction. Add a FIXME
10008 comment for making that be controlled by a user option.
10009 (push_it, pop_it): Save and restore the state of the
10010 bidi iterator. Save and restore the bidi_p flag.
10011 (pop_it): Iterate out of display property for string iteration as
10012 well.
10013 (iterate_out_of_display_property): Support iteration over strings.
10014 (handle_single_display_spec): Set up it->bidi_it for iteration
10015 over a display string, and call bidi_init_it.
10016 (handle_single_display_spec, next_overlay_string)
10017 (get_overlay_strings_1, push_display_prop): Set up the bidi
10018 iterator for displaying display or overlay strings.
10019 (forward_to_next_line_start): Don't use the shortcut if
10020 bidi-iterating.
10021 (back_to_previous_visible_line_start): If handle_display_prop
10022 pushed the iterator stack, restore the internal state of the bidi
10023 iterator by calling bidi_pop_it same number of times.
10024 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
10025 and we are bidi-iterating, don't decrement the iterator position;
10026 instead, set the first_elt flag in the bidi iterator, to produce
10027 the same effect.
10028 (reseat_1): Remove redundant setting of string_from_display_prop_p.
10029 (push_display_prop): xassert that we are iterating a buffer.
10030 (push_it, pop_it): Save and restore paragraph_embedding member.
10031 (handle_single_display_spec, next_overlay_string)
10032 (get_overlay_strings_1, reseat_1, reseat_to_string)
10033 (push_display_prop): Set up the `unibyte' member of bidi_it.string
10034 correctly. Don't assume unibyte strings are not bidi-reordered.
10035 (compute_display_string_pos)
10036 (compute_display_string_end): Fix handling the case of C string.
10037 (push_it, pop_it): Save and restore from_disp_prop_p.
10038 (handle_single_display_spec, push_display_prop): Set the
10039 from_disp_prop_p flag.
10040 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
10041 (pop_it): Call iterate_out_of_display_property only if we are
10042 popping after iteration over a string that came from a display
10043 property. Fix a typo in popping stretch info. Add an assertion
10044 for verifying that the iterator position is in sync with the bidi
10045 iterator.
10046 (handle_single_display_spec, get_overlay_strings_1)
10047 (push_display_prop): Fix initialization of paragraph direction for
10048 string when that of the parent object is not yet determined.
10049 (reseat_1): Call bidi_init_it to resync the bidi
10050 iterator with IT's position. (Bug#7616)
10051 (find_row_edges): If ROW->start.pos gives position
10052 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
10053 (handle_stop, back_to_previous_visible_line_start, reseat_1):
10054 Reset the from_disp_prop_p flag.
10055 (SAVE_IT, RESTORE_IT): New macros.
10056 (pos_visible_p, face_before_or_after_it_pos)
10057 (back_to_previous_visible_line_start)
10058 (move_it_in_display_line_to, move_it_in_display_line)
10059 (move_it_to, move_it_vertically_backward, move_it_by_lines)
10060 (try_scrolling, redisplay_window, display_line): Use them when
10061 saving a temporary copy of the iterator and restoring it back.
10062 (back_to_previous_visible_line_start, reseat_1)
10063 (init_iterator): Empty the bidi cache "stack".
10064 (move_it_in_display_line_to): If iterator ended up at
10065 EOL, but we never saw any buffer positions smaller than
10066 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
10067 motion in bidi-reordered lines.
10068 (move_it_in_display_line_to): Record prev_method and prev_pos
10069 immediately before the call to set_iterator_to_next. Fixes cursor
10070 motion in bidi-reordered lines with stretch glyphs and strings
10071 displayed in margins. (Bug#8133) (Bug#8867)
10072 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
10073 TO_CHARPOS.
640c8776
SM
10074 (pos_visible_p): Support positions in bidi-reordered lines.
10075 Save and restore bidi cache.
0bb23927
EZ
10076
10077 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
10078 (bidi_paragraph_info): Delete unused struct.
10079 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
10080 (bidi_cache_start): New variable.
10081 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
10082 to zero.
10083 (bidi_cache_fetch_state, bidi_cache_search)
10084 (bidi_cache_find_level_change, bidi_cache_iterator_state)
10085 (bidi_cache_find, bidi_peek_at_next_level)
10086 (bidi_level_of_next_char, bidi_find_other_level_edge)
10087 (bidi_move_to_visually_next): Compare cache index with
10088 bidi_cache_start rather than with zero.
10089 (bidi_fetch_char): Accept new argument STRING; all callers
10090 changed. Support iteration over a string. Support strings with
10091 display properties. Support unibyte strings. Fix the type of
10092 `len' according to what STRING_CHAR_AND_LENGTH expects.
10093 (bidi_paragraph_init, bidi_resolve_explicit_1)
10094 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
10095 (bidi_level_of_next_char, bidi_move_to_visually_next):
10096 Support iteration over a string.
0bb23927
EZ
10097 (bidi_set_sor_type, bidi_resolve_explicit_1)
10098 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
10099 can now be zero (for strings); special values 0 and -1 were
10100 changed to -1 and -2, respectively.
10101 (bidi_char_at_pos): New function.
10102 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
10103 Call it instead of FETCH_MULTIBYTE_CHAR.
10104 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
10105 initialized to valid values.
10106 (bidi_init_it): Don't initialize charpos and bytepos with invalid
10107 values.
10108 (bidi_level_of_next_char): Allow the sentinel "position" to pass
10109 the test for valid cached positions. Fix the logic for looking up
10110 the sentinel state in the cache. GCPRO the Lisp string we are
10111 iterating.
10112 (bidi_push_it, bidi_pop_it): New functions.
10113 (bidi_initialize): Initialize the bidi cache start stack pointer.
10114 (bidi_cache_ensure_space): New function, refactored from part of
10115 bidi_cache_iterator_state. Don't assume the required size is just
10116 one BIDI_CACHE_CHUNK away.
10117 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
10118 (bidi_count_bytes, bidi_char_at_pos): New functions.
10119 (bidi_cache_search): Don't assume bidi_cache_last_idx is
10120 always valid if bidi_cache_idx is valid.
10121 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
10122 is valid if it's going to be used.
10123 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
10124 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
10125 (bidi_cache_find_level_change, bidi_cache_ensure_space)
10126 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
10127 (bidi_find_other_level_edge, bidi_cache_start_stack):
10128 All variables related to cache indices are now EMACS_INT.
c965adc5 10129
0bb23927
EZ
10130 * dispextern.h (struct bidi_string_data): New structure.
10131 (struct bidi_it): New member `string'. Make flag members be 1-bit
10132 fields, and put them last in the struct.
640c8776
SM
10133 (compute_display_string_pos, compute_display_string_end):
10134 Update prototypes.
0bb23927
EZ
10135 (bidi_push_it, bidi_pop_it): Add prototypes.
10136 (struct iterator_stack_entry): New members bidi_p,
10137 paragraph_embedding, and from_disp_prop_p.
10138 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
10139 (bidi_shelve_cache, bidi_unshelve_cache):
10140 Declare prototypes.
0bb23927
EZ
10141
10142 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
10143 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
10144 and vector-like objects.
10145
10146 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
10147 cache around display iteration.
10148
10149 * window.c (Fwindow_end, window_scroll_pixel_based)
10150 (displayed_window_lines, Frecenter): Save and restore the bidi
10151 cache around display iteration.
10152
3bbd2265
LMI
101532011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
10154
10155 * editfns.c (Fdelete_region): Clarify the use of the named
10156 parameters (bug#6788).
10157
adc47434
MR
101582011-07-14 Martin Rudalics <rudalics@gmx.at>
10159
10160 * indent.c (Fvertical_motion): Set and restore w->pointm when
10161 saving and restoring the window's buffer (Bug#9006).
10162
837c31f8
LMI
101632011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
10164
10165 * editfns.c (Fstring_to_char): Clarify just what is returned
10166 (bug#6576). Text by Eli Zaretskii.
10167
ac389d0c
JB
101682011-07-13 Juanma Barranquero <lekktu@gmail.com>
10169
10170 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
10171
0be0ce47
EZ
101722011-07-13 Eli Zaretskii <eliz@gnu.org>
10173
10174 * buffer.c (mmap_find): Fix a typo.
10175
cd18e7e3
JB
101762011-07-13 Johan Bockgård <bojohan@gnu.org>
10177
10178 Fix execution of x selection hooks.
10179 * xselect.c (Qx_lost_selection_functions)
10180 (Qx_sent_selection_functions): New vars.
10181 (syms_of_xselect): DEFSYM them.
10182 (x_handle_selection_request): Pass Qx_sent_selection_functions
10183 rather than Vx_sent_selection_functions to Frun_hook_with_args.
10184 (x_handle_selection_clear,x_clear_frame_selections):
10185 Pass Qx_lost_selection_functions rather than
10186 Vx_lost_selection_functions to Frun_hook_with_args.
10187
47ea7f44
PE
101882011-07-13 Paul Eggert <eggert@cs.ucla.edu>
10189
ac389d0c 10190 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
10191 The old code sometimes used this field without initializing it.
10192
47ea7f44
PE
10193 * alloc.c (gc_sweep): Don't read past end of array.
10194 In theory, the old code could also have corrupted Emacs internals,
10195 though it'd be very unlikely.
10196
bc985c87
AS
101972011-07-12 Andreas Schwab <schwab@linux-m68k.org>
10198
10199 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 10200 argument. (Bug#4026)
bc985c87 10201
0cf34688
LMI
102022011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
10203
b3dadd76
LMI
10204 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
10205 key" (bug#4257).
10206
0cf34688
LMI
10207 * window.c (Fset_window_start): Doc fix (bug#4199).
10208 (Fset_window_hscroll): Ditto.
10209
270768cd
PE
102102011-07-12 Paul Eggert <eggert@cs.ucla.edu>
10211
077e3dda 10212 Fix minor new problems caught by GCC 4.6.1.
270768cd 10213 * term.c (init_tty): Remove unused local.
490011a6 10214 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 10215 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 10216 not used otherwise.
270768cd 10217
b1f58454
CY
102182011-07-12 Chong Yidong <cyd@stupidchicken.com>
10219
10220 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
10221
22b9578d
LMI
102222011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
10223
6e70ab07
LMI
10224 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
10225 are the mini-buffer and the echo area (bug#3320).
10226
22b9578d
LMI
10227 * term.c (init_tty): Remove support for supdup, c10 and perq
10228 terminals, which are no longer supported (bug#1482).
10229
8974cc9f
JB
102302011-07-10 Johan Bockgård <bojohan@gnu.org>
10231
10232 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
10233
a560d974
JD
102342011-07-10 Jan Djärv <jan.h.d@swipnet.se>
10235
10236 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
10237 for non-popups (Bug#3642).
10238
1dae0f0a
AS
102392011-07-10 Andreas Schwab <schwab@linux-m68k.org>
10240
268c2c36 10241 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 10242 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
10243 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
10244 * cm.c (losecursor): Likewise.
1dae0f0a
AS
10245 * data.c (fmod): Likewise.
10246 * dispnew.c (swap_glyphs_in_rows): Likewise.
10247 * emacs.c (memory_warning_signal): Likewise.
10248 * floatfns.c (float_error): Likewise.
10249 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
10250 (otf_open, font_otf_capability, generate_otf_features)
10251 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
10252 Likewise.
10253 * image.c (pbm_read_file): Likewise.
10254 * indent.c (string_display_width): Likewise.
10255 * intervals.c (check_for_interval, search_for_interval)
10256 (inc_interval_count, count_intervals, root_interval)
10257 (adjust_intervals_for_insertion, make_new_interval): Likewise.
10258 * lread.c (defalias): Likewise.
268c2c36 10259 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
10260 * regex.c (set_image_of_range_1, set_image_of_range)
10261 (regex_grow_registers): Likewise.
10262 * sysdep.c (strerror): Likewise.
10263 * termcap.c (valid_filename_p, tprint, main): Likewise.
10264 * tparam.c (main): Likewise.
10265 * unexhp9k800.c (run_time_remap, save_data_space)
10266 (update_file_ptrs, read_header, write_header, calculate_checksum)
10267 (copy_file, copy_rest, display_header): Likewise.
10268 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
10269 Likewise.
10270 * xdisp.c (check_it): Likewise.
10271 * xfaces.c (register_color, unregister_color, unregister_colors):
10272 Likewise.
10273 * xfns.c (print_fontset_result): Likewise.
10274 * xrdb.c (member, fatal, main): Likewise.
10275
99033785
PE
102762011-07-10 Paul Eggert <eggert@cs.ucla.edu>
10277
10278 Fix minor problems found by static checking (Bug#9031).
10279 * chartab.c (char_table_set_range, map_sub_char_table):
10280 Remove unused locals.
10281 (uniprop_table): Now static.
10282 * composite.c (_work_char): Remove unused static var.
10283
9cb2ac56
JB
102842011-07-09 Juanma Barranquero <lekktu@gmail.com>
10285
10286 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
10287
f25661f0
JD
102882011-07-09 Jan Djärv <jan.h.d@swipnet.se>
10289
10290 * gtkutil.c (qttip_cb): Remove code without function.
10291
8278c4fe
EZ
102922011-07-09 Eli Zaretskii <eliz@gnu.org>
10293
10294 * w32.c (pthread_sigmask): New stub.
10295
1692ae2d 102962011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 10297
8a6ebd58 10298 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
10299 sigprocmask is portable only for single-threaded applications, and
10300 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
10301 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
10302 (LIBES): Use it.
10303 * callproc.c (Fcall_process):
10304 * process.c (create_process):
10305 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
10306 Use pthread_sigmask, not sigprocmask.
123403e4 10307
1b854618
JD
103082011-07-08 Jan Djärv <jan.h.d@swipnet.se>
10309
10310 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
10311 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
10312 wrong (Bug#8591).
10313
3fe4b549
JD
103142011-07-08 Jan Djärv <jan.h.d@swipnet.se>
10315
0ce7e563
JD
10316 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
10317 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
10318 (xg_hide_tooltip): Fix comment.
10319
3fe4b549
JD
10320 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
10321 in registerServicesMenuSendTypes.
10322 (validRequestorForSendType): Don't check ns_return_types.
10323
10324 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
10325 ns_return_type.
10326
5df75e47
JR
103272011-07-08 Jason Rumney <jasonr@gnu.org>
10328
22610910
JR
10329 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
10330 SH_SHOW for hidden windows (Bug#5482).
10331
5df75e47
JR
10332 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
10333 frame struct members of non-existent frames (Bug#6284).
10334
699c10bd
JD
103352011-07-08 Jan Djärv <jan.h.d@swipnet.se>
10336
4393663b
JD
10337 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
10338 variable firstTime not needed on OSX >= 10.6.
10339 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
10340 >= 10.5. Use setKnobProportion, setDoubleValue.
10341
10342 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
10343 (MAC_OS_X_VERSION_10_5): Define if not defined.
10344 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
10345 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
10346 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
10347
10348 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 10349 cString and lossyCString on OSX >= 10.4.
4393663b 10350
58179cce 10351 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
10352 sizeToFit on OSX >= 10.2.
10353
10354 * nsimage.m (allocInitFromFile): Don't use deprecated method
10355 bestRepresentationForDevice on OSX >= 10.6.
10356
10357 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
10358 to avoid warning.
10359
10360 * emacs.c: Declare unexec_init_emacs_zone.
10361
a63e0781
JD
10362 * nsgui.h: Fix compiler warning about gnulib redefining verify.
10363
699c10bd
JD
10364 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
10365
10366 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
10367 on svcsMenu (Bug#8842).
10368
10369 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
10370 ns_return_types.
10371 (Fns_list_services): Just return Qnil on 10.6, code not working there.
10372
10373 * nsterm.m (QUTF8_STRING): Declare.
10374 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
10375 (validRequestorForSendType): Return type is (id).
10376 Change indexOfObjectIdenticalTo to indexOfObject.
10377 Check if we have local selection before returning self (Bug#8842).
10378 (writeSelectionToPasteboard): Put local selection into paste board
10379 if we have a local selection (Bug#8842).
10380 (syms_of_nsterm): DEFSYM QUTF8_STRING.
10381
10382 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
10383 (ns_get_local_selection): Declare.
10384
54e10184
LMI
103852011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
10386
9888ff71
LMI
10387 * keymap.c (describe_map_tree): Don't insert a double newline at
10388 the end of the buffer (bug#1169) and return whether we inserted
10389 something.
10390
54e10184
LMI
10391 * callint.c (Fcall_interactively): Change "reading args" to
10392 "providing args" to try to clarify what it does (bug#1010).
10393
15fa4783
KH
103942011-07-07 Kenichi Handa <handa@m17n.org>
10395
10396 * composite.c (composition_compute_stop_pos): Ignore a static
10397 composition starting before CHARPOS (Bug#8915).
10398
10399 * xdisp.c (handle_composition_prop): Likewise.
10400
a8815b00
EZ
104012011-07-07 Eli Zaretskii <eliz@gnu.org>
10402
10403 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
10404 (Bug#9015)
10405
ef7b981d 104062011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
10407
10408 * character.h (unicode_category_t): New enum type.
10409
10410 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
10411 (Qchar_code_property_table): New variable.
10412 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
10413 (UNIPROP_COMPRESSED_FORM_P): New macros.
10414 (char_table_ascii): Uncompress the compressed values.
10415 (sub_char_table_ref): New arg is_uniprop. Callers changed.
10416 Uncompress the compressed values.
ac389d0c 10417 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
10418 (char_table_ref_and_range): Uncompress the compressed values.
10419 (sub_char_table_set): New arg is_uniprop. Callers changed.
10420 Uncompress the compressed values.
10421 (sub_char_table_set_range): Args changed. Callers changed.
10422 (char_table_set_range): Adjuted for the above change.
10423 (map_sub_char_table): Delete args default_val and parent. Add arg
10424 top. Give decoded values to a Lisp function.
640c8776 10425 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
10426 values to a Lisp function. Gcpro more variables.
10427 (uniprop_table_uncompress)
10428 (uniprop_decode_value_run_length): New functions.
10429 (uniprop_decoder, uniprop_decoder_count): New variables.
10430 (uniprop_get_decoder, uniprop_encode_value_character)
10431 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
10432 New functions.
10433 (uniprop_encoder, uniprop_encoder_count): New variables.
10434 (uniprop_get_encoder, uniprop_table)
10435 (Funicode_property_table_internal, Fget_unicode_property_internal)
10436 (Fput_unicode_property_internal): New functions.
10437 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
10438 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 10439 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
10440 char-code-property-alist.
10441
640c8776 10442 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
10443 Vunicode_category_table.
10444
640c8776 10445 * font.c (font_range): Adjust for the change of
c805dec0
KH
10446 Vunicode_category_table.
10447
76b397fb
DN
104482011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
10449
10450 * m/iris4d.h: Remove file, move contents ...
10451 * s/irix6-5.h: ... here.
10452
22b4128e
PE
104532011-07-06 Paul Eggert <eggert@cs.ucla.edu>
10454
10455 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
10456 * alloc.c (mark_buffer):
10457 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
10458 (clone_per_buffer_values): Don't assume that
22b4128e
PE
10459 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
10460 This isn't true in general, and it's particularly not true
10461 if Emacs is configured with --with-wide-int.
10462 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
10463 New macros, used in the buffer.c change.
10464
869795d6
JD
104652011-07-05 Jan Djärv <jan.h.d@swipnet.se>
10466
10467 * xsettings.c: Use both GConf and GSettings if both are available.
10468 (store_config_changed_event): Add comment.
10469 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
10470 (store_tool_bar_style_changed): New functions.
5e617bc2 10471 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
10472 (struct xsettings): Move font inside HAVE_XFT.
10473 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 10474 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 10475 Move inside HAVE_XFT.
640c8776 10476 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
10477 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
10478 also.
10479 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 10480 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 10481 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
10482 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
10483 (parse_settings): Move check for font inside HAVE_XFT.
10484 (read_settings, apply_xft_settings): Add comment.
10485 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
10486 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
10487 call store_font_name_changed.
10488 (xft_settings_event): Add comment.
10489 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
10490 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
10491 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
10492 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
10493 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
10494 (xsettings_get_system_font, xsettings_get_system_normal_font):
10495 Add comment.
869795d6 10496
d8ed26bd
PE
104972011-07-05 Paul Eggert <eggert@cs.ucla.edu>
10498
10499 Random fixes. E.g., (random) never returned negative values.
10500 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
10501 subseconds part to the entropy, as that's a bit more random.
10502 Prefer signed to unsigned, since the signedness doesn't matter and
10503 in general we prefer signed. When given a limit, use a
10504 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
10505 latter isn't right if USE_2_TAGS_FOR_INTS.
10506 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
10507 not 0..VALMASK. Don't discard "excess" bits that random () returns.
10508
cabf1cac
SM
105092011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
10510
10511 * textprop.c (text_property_stickiness):
10512 Obey Vtext_property_default_nonsticky.
10513 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
10514 * w32fns.c (syms_of_w32fns):
10515 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
10516
6e9b2be9
PE
105172011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10518
10519 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
10520 This is more efficient than Ffile_directory_p and avoids a minor race.
10521
90186c68
LMI
105222011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
10523
7c301272
LMI
10524 * buffer.c (Foverlay_put): Say what the return value is
10525 (bug#7835).
10526
c4f2d8d4
LMI
10527 * fileio.c (barf_or_query_if_file_exists): Check first if the file
10528 is a directory before asking whether to use the file name
10529 (bug#7564).
ad637907
LMI
10530 (barf_or_query_if_file_exists): Make the "File is a directory"
10531 error be more correct.
c4f2d8d4 10532
90186c68
LMI
10533 * fns.c (Frequire): Remove the mention of the .gz files, since
10534 that's installation-specific, but keep the mention of
10535 `get-load-suffixes'.
10536
da64016e
PE
105372011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10538
10539 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
10540 Report string overflow if the output is too long.
10541
7d47b580
JB
105422011-07-04 Juanma Barranquero <lekktu@gmail.com>
10543
a555cb87
JB
10544 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
10545 (syms_of_gnutls): Remove duplicate DEFSYM for
10546 Qgnutls_bootprop_verify_hostname_error, an error for
10547 Qgnutls_bootprop_verify_error (which is no longer used).
10548
7d47b580
JB
10549 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
10550 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
10551 Also (re)move comments that are misplaced or no longer relevant.
10552
1e49bfab
LMI
105532011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10554
10555 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
10556
1485f4c0
CY
105572011-07-03 Chong Yidong <cyd@stupidchicken.com>
10558
10559 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
10560 and background color parameters if they have been changed.
10561
a9ab721e
LMI
105622011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10563
10564 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
10565
cf7cff57
PE
105662011-07-03 Paul Eggert <eggert@cs.ucla.edu>
10567
2e13213d
PE
10568 * xsettings.c (SYSTEM_FONT): Define only when used.
10569 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
10570
cf7cff57
PE
10571 * keymap.c (access_keymap_1): Now static.
10572
7a8e04f7
CY
105732011-07-02 Chong Yidong <cyd@stupidchicken.com>
10574
10575 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
10576 leave any prefix arg for the up event (Bug#1586).
10577
61352f62
LMI
105782011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
10579
69bb1ef7
LMI
10580 * lread.c (syms_of_lread): Mention single symbols defined by
10581 `defvar' or `defconst' (bug#7154).
10582
61352f62 10583 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 10584 (Frequire): Mention get-load-suffixes.
61352f62 10585
28545e04
MR
105862011-07-02 Martin Rudalics <rudalics@gmx.at>
10587
10588 * window.h (window): Remove clone_number slot.
10589 * window.c (Fwindow_clone_number, Fset_window_clone_number):
10590 Remove.
10591 (make_parent_window, make_window, saved_window)
10592 (Fset_window_configuration, save_window_save): Don't deal with
10593 clone numbers.
10594 * buffer.c (Qclone_number): Remove declaration.
10595 (sort_overlays, overlay_strings): Don't deal with clone numbers.
10596
3349e122
SM
105972011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
10598
10599 Add multiple inheritance to keymaps.
10600 * keymap.c (Fmake_composed_keymap): New function.
10601 (Fset_keymap_parent): Simplify.
10602 (fix_submap_inheritance): Remove.
10603 (access_keymap_1): New function extracted from access_keymap to handle
10604 embedded parents and handle lists of maps.
10605 (access_keymap): Use it.
10606 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
10607 (Fcopy_keymap): Handle embedded parents.
10608 (Fcommand_remapping, define_as_prefix): Simplify.
10609 (Fkey_binding): Simplify.
10610 (syms_of_keymap): Move minibuffer-local-completion-map,
10611 minibuffer-local-filename-completion-map,
10612 minibuffer-local-must-match-map, and
10613 minibuffer-local-filename-must-match-map to Elisp.
10614 (syms_of_keymap): Defsubr make-composed-keymap.
10615 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
10616 (parse_menu_item): Trivial simplification.
10617
3279eb87
GM
106182011-07-01 Glenn Morris <rgm@gnu.org>
10619
10620 * Makefile.in (SETTINGS_LIBS): Fix typo.
10621
39cb9e56 106222011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
10623
10624 * coding.c (Fencode_coding_string): Record the last coding system
10625 used, as the function doc string says (bug#8738).
10626
0949d2b6
JD
106272011-07-01 Jan Djärv <jan.h.d@swipnet.se>
10628
10629 * xsettings.c (store_monospaced_changed): Take new font as arg and
10630 check for change against current_mono_font.
10631 (EMACS_TYPE_SETTINGS): Remove this and related defines.
10632 (emacs_settings_constructor, emacs_settings_get_property)
10633 (emacs_settings_set_property, emacs_settings_class_init)
10634 (emacs_settings_init, gsettings_obj): Remove.
10635 (something_changedCB): New function for HAVE_GSETTINGS.
10636 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
10637 with value as argument.
10638 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
10639 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 10640 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
10641 "changed".
10642
10643 * xgselect.c: Add defined (HAVE_GSETTINGS).
10644 (xgselect_initialize): Ditto.
10645
10646 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
10647 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
10648 xg_select.
10649
bbc6b304
PE
106502011-07-01 Paul Eggert <eggert@cs.ucla.edu>
10651
10652 * eval.c (struct backtrace): Simplify and port the data structure.
10653 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
10654 signed bit field, as this assumption is not portable and it makes
10655 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
10656 "char debug_on_exit : 1" as this is not portable either; instead,
10657 use the portable "unsigned int debug_on_exit : 1". Remove unused
10658 member evalargs. Remove obsolete comments about cc bombing out.
10659
9851bfc5
JD
106602011-06-30 Jan Djärv <jan.h.d@swipnet.se>
10661
51bb811f 10662 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
10663 Let HAVE_GSETTINGS override HAVE_GCONF.
10664 (store_monospaced_changed): New function.
10665 (EMACS_SETTINGS): A new type derived from GObject to handle
10666 GSettings notifications.
10667 (emacs_settings_constructor, emacs_settings_get_property)
10668 (emacs_settings_set_property, emacs_settings_class_init):
10669 New functions.
10670 (gsettings_client, gsettings_obj): New variables.
10671 (GSETTINGS_SCHEMA): New define.
10672 (something_changedCB): Call store_monospaced_changed.
10673 (init_gsettings): New function.
10674 (xsettings_initialize): Call init_gsettings.
10675 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
10676 to NULL.
10677
640c8776 10678 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
10679 GCONF_CFLAGS/LIBS.
10680
5386012d
MR
106812011-06-29 Martin Rudalics <rudalics@gmx.at>
10682
10683 * window.c (resize_root_window, grow_mini_window)
10684 (shrink_mini_window): Rename Qresize_root_window to
10685 Qwindow_resize_root_window and Qresize_root_window_vertically to
10686 Qwindow_resize_root_window_vertically.
10687
f13e0b08
PE
106882011-06-28 Paul Eggert <eggert@cs.ucla.edu>
10689
10690 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
10691
94515237
JB
106922011-06-27 Juanma Barranquero <lekktu@gmail.com>
10693
10694 * makefile.w32-in: Redesign dependencies so they reflect more
10695 clearly which files are directly included by each source file,
10696 and not through other includes.
10697
e43b6e43
MR
106982011-06-27 Martin Rudalics <rudalics@gmx.at>
10699
10700 * buffer.c (Qclone_number): Declare static and DEFSYM it.
10701 (sort_overlays, overlay_strings): When an overlay's clone number
10702 matches the window's clone number process the overlay even if
10703 the overlay's window property doesn't match the current window.
10704
d68443dc
MR
10705 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
10706 (Fwindow_hchild): Rename to Fwindow_left_child.
10707 (Fwindow_next): Rename to Fwindow_next_sibling.
10708 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
10709 (resize_window_check): Rename to window_resize_check.
10710 (resize_window_apply): Rename to window_resize_apply.
10711 (Fresize_window_apply): Rename to Fwindow_resize_apply.
10712 (Fdelete_other_windows_internal, resize_frame_windows)
10713 (Fsplit_window_internal, Fdelete_window_internal)
10714 (grow_mini_window, shrink_mini_window)
10715 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 10716
c7e73be5
JD
107172011-06-26 Jan Djärv <jan.h.d@swipnet.se>
10718
10719 * emacsgtkfixed.h: State that this is only used with Gtk+3.
10720 (emacs_fixed_set_min_size): Remove.
10721 (emacs_fixed_new): Take frame as argument.
10722
10723 * emacsgtkfixed.c: State that this is only used with Gtk+3.
10724 (_EmacsFixedPrivate): Remove minwidth/height.
10725 Add struct frame *f.
10726 (emacs_fixed_init): Initialize priv->f.
10727 (get_parent_class, emacs_fixed_set_min_size): Remove.
10728 (emacs_fixed_new): Set priv->f to argument.
10729 (emacs_fixed_get_preferred_width)
10730 (emacs_fixed_get_preferred_height): Use min_width/height from
10731 frames size_hint to set minimum and natural (Bug#8919).
10732 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
10733 and use min_width/height from frames size_hint to set
10734 min_width/height (Bug#8919).
10735
10736 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
10737 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
10738 Fix indentation.
c7e73be5 10739
cf99dcf8
EZ
107402011-06-26 Eli Zaretskii <eliz@gnu.org>
10741
10742 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
10743 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
10744 called at ZV.
10745
029529ac
CY
107462011-06-26 Chong Yidong <cyd@stupidchicken.com>
10747
10748 * process.c (wait_reading_process_output): Bypass select if
10749 waiting for a cell while ignoring keyboard input, and input is
10750 pending. Suggested by Jan Djärv (Bug#8869).
10751
7a7ef429
PE
107522011-06-25 Paul Eggert <eggert@cs.ucla.edu>
10753
10754 Use gnulib's dup2 module instead of rolling our own.
10755 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
10756
11fdef7d 107572011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
10758
10759 * dispnew.c (scrolling_window): Before scrolling, turn off a
10760 mouse-highlight in the window being scrolled.
10761
cd3520a4
JB
107622011-06-24 Juanma Barranquero <lekktu@gmail.com>
10763
10764 Move DEFSYM to lisp.h and use everywhere.
10765
10766 * character.h (DEFSYM): Move declaration...
10767 * lisp.h (DEFSYM): ...here.
10768
10769 * gnutls.c:
10770 * minibuf.c:
10771 * w32menu.c:
10772 * w32proc.c:
10773 * w32select.c: Don't include character.h.
10774
10775 * alloc.c (syms_of_alloc):
10776 * buffer.c (syms_of_buffer):
10777 * bytecode.c (syms_of_bytecode):
10778 * callint.c (syms_of_callint):
10779 * casefiddle.c (syms_of_casefiddle):
10780 * casetab.c (init_casetab_once):
10781 * category.c (init_category_once, syms_of_category):
10782 * ccl.c (syms_of_ccl):
10783 * cmds.c (syms_of_cmds):
10784 * composite.c (syms_of_composite):
10785 * dbusbind.c (syms_of_dbusbind):
10786 * dired.c (syms_of_dired):
10787 * dispnew.c (syms_of_display):
10788 * doc.c (syms_of_doc):
10789 * editfns.c (syms_of_editfns):
10790 * emacs.c (syms_of_emacs):
10791 * eval.c (syms_of_eval):
10792 * fileio.c (syms_of_fileio):
10793 * fns.c (syms_of_fns):
10794 * frame.c (syms_of_frame):
10795 * fringe.c (syms_of_fringe):
10796 * insdel.c (syms_of_insdel):
10797 * keymap.c (syms_of_keymap):
10798 * lread.c (init_obarray, syms_of_lread):
10799 * macros.c (syms_of_macros):
10800 * msdos.c (syms_of_msdos):
10801 * print.c (syms_of_print):
10802 * process.c (syms_of_process):
10803 * search.c (syms_of_search):
10804 * sound.c (syms_of_sound):
10805 * syntax.c (init_syntax_once, syms_of_syntax):
10806 * terminal.c (syms_of_terminal):
10807 * textprop.c (syms_of_textprop):
10808 * undo.c (syms_of_undo):
10809 * w32.c (globals_of_w32):
10810 * window.c (syms_of_window):
10811 * xdisp.c (syms_of_xdisp):
10812 * xfaces.c (syms_of_xfaces):
10813 * xfns.c (syms_of_xfns):
10814 * xmenu.c (syms_of_xmenu):
10815 * xsettings.c (syms_of_xsettings):
10816 * xterm.c (syms_of_xterm): Use DEFSYM.
10817
4228cf16
TZ
108182011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
10819
cd3520a4 10820 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 10821
7fcccf1e
PE
108222011-06-23 Paul Eggert <eggert@cs.ucla.edu>
10823
7efb4e0e
PE
10824 Integer and buffer overflow fixes (Bug#8873).
10825
ff5844ad
PE
10826 * print.c (printchar, strout): Check for string overflow.
10827 (PRINTPREPARE, printchar, strout):
10828 Don't set size unless allocation succeeds.
10829
90532f02
PE
10830 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
10831 for sizes. Check for string overflow more accurately.
10832 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
10833
6d84508d
PE
10834 * macros.c: Integer and buffer overflow fixes.
10835 * keyboard.h (struct keyboard.kbd_macro_bufsize):
10836 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
10837 Use ptrdiff_t, not int, for sizes.
10838 Don't increment bufsize until after realloc succeeds.
10839 Check for size-calculation overflow.
10840 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
10841
437b2cb4
PE
10842 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
10843
8b9ac8b4
PE
10844 * lread.c: Integer overflow fixes.
10845 (read_integer): Radix is now EMACS_INT, not int,
10846 to improve quality of diagnostics for out-of-range radices.
10847 Calculate buffer size correctly for out-of-range radices.
10848 (read1): Check for integer overflow in radices, and in
10849 read-circle numbers.
82cb60d3
PE
10850 (read_escape): Avoid int overflow.
10851 (Fload, openp, read_buffer_size, read1)
10852 (substitute_object_recurse, read_vector, read_list, map_obarray):
10853 Use ptrdiff_t, not int, for sizes.
10854 (read1): Use EMACS_INT, not int, for sizes.
20270765 10855 Check for size overflow.
8b9ac8b4 10856
7fcccf1e
PE
10857 * image.c (cache_image): Check for size arithmetic overflow.
10858
bfbbd7e7
PE
10859 * lread.c: Integer overflow issues.
10860 (saved_doc_string_size, saved_doc_string_length)
10861 (prev_saved_doc_string_size, prev_saved_doc_string_length):
10862 Now ptrdiff_t, not int.
10863 (read1): Don't assume doc string length fits in int. Check for
10864 out-of-range doc string lengths.
10865 (read_list): Don't assume file position fits in int.
39019e54 10866 (read_escape): Check for hex character overflow.
bfbbd7e7 10867
4e323265
LL
108682011-06-22 Leo Liu <sdl.web@gmail.com>
10869
10870 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
10871 Move to minibuffer.el.
10872
85fece3e
PE
108732011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10874
20b84ce9 10875 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
10876 The following patches are for when GLYPH_DEBUG && !XASSERT.
10877 * dispextern.h (trace_redisplay_p, dump_glyph_string):
10878 * dispnew.c (flush_stdout):
10879 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
10880 Mark as externally visible.
10881 * dispnew.c (check_window_matrix_pointers): Now static.
10882 * dispnew.c (window_to_frame_vpos):
10883 * xfns.c (unwind_create_frame):
10884 * xterm.c (x_check_font): Remove unused local.
10885 * scroll.c (CHECK_BOUNDS):
10886 * xfaces.c (cache_fache): Rename local to avoid shadowing.
10887 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
10888 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
10889 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
10890 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
10891 Now static.
10892 (debug_method_add): Use va_list and vsprintf rather than relying
10893 on undefined behavior with wrong number of arguments.
10894 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
10895 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
10896 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
10897 since we're not interested in debugging glyphs with old libraries.
10898 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
10899 GCC 4.6.0's static checking.
10900
0766b489
PE
109012011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10902
31fd4b32
PE
10903 Integer overflow and signedness fixes (Bug#8873).
10904 A few related buffer overrun fixes, too.
10905
b79e8648
PE
10906 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
10907
0766b489
PE
10908 * dispextern.h (struct face.stipple):
10909 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
10910 (x_bitmap_mask, x_allocate_bitmap_record)
10911 (x_create_bitmap_from_data, x_create_bitmap_from_file)
10912 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
10913 (x_create_bitmap_from_xpm_data):
10914 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
10915 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
10916 (.bitmaps_last):
10917 * xfaces.c (load_pixmap):
10918 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
10919 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
10920 (.bitmaps_last, struct x_output.icon_bitmap):
10921 Use ptrdiff_t, not int, for bitmap indexes.
10922 (x_allocate_bitmap_record): Check for size overflow.
10923 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
10924
b081724f
PE
10925 Use ptrdiff_t, not int, for overlay counts.
10926 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
10927 * editfns.c (overlays_around, get_pos_property):
10928 * textprop.c (get_char_property_and_overlay):
10929 * xdisp.c (next_overlay_change, note_mouse_highlight):
10930 * xfaces.c (face_at_buffer_position):
21514da7
PE
10931 * buffer.c (OVERLAY_COUNT_MAX): New macro.
10932 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
10933 (Fnext_overlay_change, Fprevious_overlay_change)
10934 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 10935 Use ptrdiff_t, not int, for sizes.
21514da7 10936 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 10937
3de73e5e
PE
10938 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
10939
2606c57b
PE
10940 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
10941 (x_session_initialize): Do not assume string length fits in int.
10942
aaafe47a
PE
10943 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
10944 This is unlikely, but can occur if DPI is outlandish.
10945
2674ddc8 10946 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
10947 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
10948
28154962
PE
10949 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
10950 * xrdb.c (magic_file_p, search_magic_path):
10951 Omit last arg SUFFIX; it was always 0. All callers changed.
10952 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
10953
7de51af5
PE
10954 * xfont.c (xfont_match): Avoid need for strlen.
10955
25ed6cc3
PE
10956 * xfns.c: Don't assume strlen fits in int.
10957 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
10958
4eab31dd
PE
10959 * xdisp.c (message_log_check_duplicate): Return intmax_t,
10960 not unsigned long, as we prefer signed integers. All callers changed.
10961 Detect integer overflow in repeat count.
10962 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 10963 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 10964
171e2a58
PE
10965 * termcap.c: Don't assume sizes fit in int and never overflow.
10966 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
10967 (gobble_line): Check for size-calculation overflow.
10968
ad39faca 10969 * minibuf.c (Fread_buffer):
6e5bb2dc 10970 * lread.c (intern, intern_c_string):
74ca2eb3
PE
10971 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
10972 Don't assume string length fits in int.
10973
52c61c22 10974 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
10975 * gtkutil.c (style_changed_cb): Avoid need for strlen.
10976
b5b8c9e5
PE
10977 * font.c: Don't assume string length fits in int.
10978 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
10979 Use ptrdiff_t, not int.
ccd6111c
PE
10980 (font_intern_prop): Don't assume string length fits in int.
10981 Don't assume integer property fits in fixnum.
10982 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 10983
882f0d81 10984 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 10985 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
10986 Reformulate so as not to need the command string.
10987 Invoke gzip -cd rather than gunzip, as it's more portable.
10988 (lock_info_type, lock_file_1, lock_file):
10989 Don't assume pid_t and time_t fit in unsigned long.
10990 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
10991 (current_lock_owner): Prefer signed type for sizes.
10992 Use memcpy, not strncpy, where memcpy is what is really wanted.
10993 Don't assume (via atoi) that time_t and pid_t fit in int.
10994 Check for time_t and/or pid_t out of range, e.g., via a network share.
10995 Don't alloca where an auto var works fine.
10996
93f4cf88
PE
10997 * fileio.c: Fix some integer overflow issues.
10998 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
10999 Don't assume string length fits in int.
11000 (directory_file_name): Don't assume string length fits in long.
11001 (make_temp_name): Don't assume pid fits in int, or that its print
11002 length is less than 20.
11003
f3e92b69
PE
11004 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
11005
1bfdaf10
PE
11006 * coding.c (make_subsidiaries): Don't assume string length fits in int.
11007
35016e9a
PE
11008 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
11009
3d1e65a1
PE
11010 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
11011 We prefer signed integers, even for size calculations.
11012
0b963a93
PE
11013 * emacs.c: Don't assume string length fits in 'int'.
11014 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
11015 (main): Don't invoke strlen when not needed.
11016
573f4b54
PE
11017 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
11018 (XD_DEBUG_MESSAGE): Don't waste a byte.
11019
989f33ba
PE
11020 * callproc.c (getenv_internal_1, getenv_internal)
11021 (Fgetenv_internal):
965d34eb
PE
11022 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
11023
e4d29b33
PE
11024 * lread.c (invalid_syntax): Omit length argument.
11025 All uses changed. This doesn't fix a bug, but it simplifies the
11026 code away from its former Hollerith-constant appearance, and it's
11027 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 11028 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 11029
eb49b136
PE
11030 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
11031 This didn't break anything, but it didn't help either.
11032 It's confusing to put a bogus integer in a place where the actual
11033 value does not matter.
9f62aeb1 11034 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 11035 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 11036
15375a22
PE
11037 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
11038 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
11039 implementation.
b61cc01c
PE
11040 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
11041 We prefer signed types, and the value cannot exceed the EMACS_INT
11042 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
11043 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
11044 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
11045 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 11046
53b2623d
PE
11047 * indent.c (sane_tab_width): New function.
11048 (current_column, scan_for_column, Findent_to, position_indentation)
11049 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 11050 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 11051
51cab52b 11052 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 11053
f2ed8a70
PE
11054 * lisp.h (lint_assume): New macro.
11055 * composite.c (composition_gstring_put_cache):
11056 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
11057
abe80cc6
PE
11058 * editfns.c, insdel.c:
11059 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 11060
b02c740e
PE
11061 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
11062
ebc96716
PE
11063 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
11064
b4e50fa0 11065 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 11066 Use much-faster test for byte-length change.
311d5d7c 11067 Don't assume string byte-length fits in 'int'.
a4cf38e4 11068 Check that character arg fits in 'int'.
85461888 11069 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 11070
c0c1ee9f
PE
11071 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
11072
a498d7f4
PE
11073 * fns.c (concat): Catch string overflow earlier.
11074 Do not rely on integer wraparound.
11075
51cab52b
PE
11076 * dispextern.h (struct it.overlay_strings_charpos)
11077 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
11078 * xdisp.c (forward_to_next_line_start)
11079 (back_to_previous_visible_line_start)
11080 (reseat_at_next_visible_line_start, next_element_from_buffer):
11081 Don't arbitrarily truncate the value of 'selective' to int.
11082
76031fad
PE
11083 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
11084
5eb55db9
PE
11085 * composite.c: Don't truncate sizes to 'int'.
11086 (composition_gstring_p, composition_reseat_it)
11087 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
11088 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
11089 not EMACS_UINT, for indexes.
5eb55db9 11090
0703a717
PE
11091 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
11092
d6202519
PE
11093 * buffer.c: Include <verify.h>.
11094 (struct sortvec.priority, struct sortstr.priority):
8961a454 11095 Now EMACS_INT, not int.
c20998a7 11096 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
11097 (struct sortstr.size, record_overlay_string)
11098 (struct sortstrlist.size, struct sortlist.used):
11099 Don't truncate size to int.
11100 (record_overlay_string): Check for size-calculation overflow.
d6202519 11101 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 11102
d5a19415
JM
111032011-06-22 Jim Meyering <meyering@redhat.com>
11104
029529ac 11105 Don't leak an XBM-image-sized buffer
d5a19415
JM
11106 * image.c (xbm_load): Free the image buffer after using it.
11107
a9041e6c
PE
111082011-06-21 Paul Eggert <eggert@cs.ucla.edu>
11109
11110 Port to Sun C.
11111 * composite.c (find_automatic_composition): Omit needless 'return 0;'
11112 that Sun C diagnosed.
11113 * fns.c (secure_hash): Fix pointer signedness issue.
11114 * intervals.c (static_offset_intervals): New function.
11115 (offset_intervals): Use it.
11116
7f3f739f
LL
111172011-06-21 Leo Liu <sdl.web@gmail.com>
11118
11119 * deps.mk (fns.o):
11120 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
11121 sha512.h.
11122
11123 * fns.c (secure_hash): Rename from crypto_hash_function and change
11124 the first arg to accept symbols.
5b66d427 11125 (Fsecure_hash): New primitive.
7f3f739f
LL
11126 (syms_of_fns): New symbols.
11127
76147d94
DD
111282011-06-20 Deniz Dogan <deniz@dogan.se>
11129
11130 * process.c (Fset_process_buffer): Clarify return value in
11131 docstring.
11132
7d7d0045
CY
111332011-06-18 Chong Yidong <cyd@stupidchicken.com>
11134
11135 * dispnew.c (add_window_display_history): Use BVAR.
11136
11137 * xdisp.c (debug_method_add): Use BVAR.
11138 (check_window_end, dump_glyph_matrix, dump_glyph)
11139 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
11140
11141 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
11142 Likewise.
11143
11144 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
11145 check till after the cache is created in init_frame_faces.
11146
ff2bc410
SM
111472011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
11148
11149 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
11150
28177add
PE
111512011-06-16 Paul Eggert <eggert@cs.ucla.edu>
11152
dd3482fe
PE
11153 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
11154 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
11155 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
11156
393d71f3 11157 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
11158 * fileio.c (Finsert_file_contents):
11159 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
11160 Remove the old (too-loose) buffer overflow checks.
11161 They weren't needed, since make_gap checks for buffer overflow.
11162 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
11163 The old code merely checked for Emacs fixnum overflow, and relied
11164 on undefined (wraparound) behavior. The new code avoids undefined
11165 behavior, and also checks for ptrdiff_t and/or size_t overflow.
11166
2e6813b0 11167 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
11168 Tune. Don't use wider integers than needed. Don't use alloca.
11169 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 11170
599a9e4f
PE
11171 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
11172
99561444
PE
11173 * insdel.c, lisp.h (buffer_overflow): New function.
11174 (insert_from_buffer_1, replace_range, replace_range_2):
11175 * insdel.c (make_gap_larger):
11176 * editfns.c (Finsert_char):
11177 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
11178
28177add
PE
11179 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
11180
e69dafad
PE
111812011-06-15 Paul Eggert <eggert@cs.ucla.edu>
11182
4baa020d 11183 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 11184
b1c46f02
PE
11185 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
11186 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
11187
e69dafad
PE
11188 * fileio.c: Don't assume EMACS_INT fits in off_t.
11189 (emacs_lseek): New static function.
11190 (Finsert_file_contents, Fwrite_region): Use it.
11191 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
11192
566684ea
PE
11193 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
11194
e6966cd6
PE
11195 * fns.c: Don't overflow int when computing a list length.
11196 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
11197 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
11198 truncation on 64-bit hosts. Check for QUIT every
11199 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
11200 faster and is responsive enough.
11201 (Flength): Report an error instead of overflowing an integer.
11202 (Fsafe_length): Return a float if the value is not representable
11203 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 11204 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 11205 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 11206
dd0b0efb
PE
11207 * alloc.c: Check that resized vectors' lengths fit in fixnums.
11208 (header_size, word_size): New constants.
11209 (allocate_vectorlike): Don't check size overflow here.
11210 (allocate_vector): Check it here instead, since this is the only
11211 caller of allocate_vectorlike that could cause overflow.
11212 Check that the new vector's length is representable as a fixnum.
11213
86fe5cfe
PE
11214 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
11215 The previous code was bogus. For example, next_almost_prime (32)
11216 returned 39, which is undesirable as it is a multiple of 3; and
11217 next_almost_prime (24) returned 25, which is a multiple of 5 so
11218 why was the code bothering to check for multiples of 7?
11219
80e88859
PE
11220 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
11221
4a2f0ad6
PE
11222 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
11223
f66c7cf8
PE
11224 Variadic C functions now count arguments with ptrdiff_t.
11225 This partly undoes my 2011-03-30 change, which replaced int with size_t.
11226 Back then I didn't know that the Emacs coding style prefers signed int.
11227 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
11228 were being counted with int, which may truncate counts on 64-bit
11229 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
11230 * lisp.h (struct Lisp_Subr.function.aMANY)
11231 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
11232 Arg counts are now ptrdiff_t, not size_t.
11233 All variadic functions and their callers changed accordingly.
11234 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
11235 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
11236 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
11237 * callint.c (Fcall_interactively): Check arg count for overflow,
11238 to avoid potential buffer overrun. Use signed char, not 'int',
11239 for 'varies' array, so that we needn't bother to check its size
11240 calculation for overflow.
11241 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
11242 * eval.c (apply_lambda):
11243 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
11244 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
11245 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
11246
a1759b76
PE
11247 * callint.c (Fcall_interactively): Don't use index var as event count.
11248
d96be9fc
PE
11249 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
11250 * mem-limits.h (SIZE): Remove; no longer used.
11251
a690a978 11252 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 11253
578c21e6
PE
11254 Remove unnecessary casts.
11255 * xterm.c (x_term_init):
11256 * xfns.c (x_set_border_pixel):
11257 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
11258 These aren't needed now that we assume ANSI C.
11259
96f53c6c
PE
11260 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
11261 It's more likely to cause problems (due to unsigned overflow)
11262 than to cure them.
11263
83c77d31
PE
11264 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
11265
ee2079f1
PE
11266 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
11267
6da65536
PE
11268 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
11269
7147c4a4
PE
11270 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
11271
193e32d9
PE
11272 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
11273
e5533da6
PE
11274 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
11275
9910e595
PE
11276 GLYPH_CODE_FACE returns EMACS_INT, not int.
11277 * dispextern.h (merge_faces):
11278 * xfaces.c (merge_faces):
01103c44
PE
11279 * xdisp.c (get_next_display_element, next_element_from_display_vector):
11280 Don't assume EMACS_INT fits in int.
9910e595 11281
2638320e
PE
11282 * character.h (CHAR_VALID_P): Remove unused parameter.
11283 * fontset.c, lisp.h, xdisp.c: All uses changed.
11284
045eb8d9
PE
11285 * editfns.c (Ftranslate_region_internal): Omit redundant test.
11286
c1f134b5
PE
11287 * fns.c (concat): Minor tuning based on overflow analysis.
11288 This doesn't fix any bugs. Use int to hold character, instead
11289 of constantly refetching from Emacs object. Use XFASTINT, not
11290 XINT, for value known to be a character. Don't bother comparing
11291 a single byte to 0400, as it's always less.
11292
395fcb93 11293 * floatfns.c (Fexpt):
327eeec8
PE
11294 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
11295
abbd3d23
PE
11296 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
11297 for characters.
11298
684a03ef
PE
11299 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
11300
0fed43f3
PE
11301 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
11302 Without this fix, on a 64-bit host (aset S 0 4294967386) would
11303 incorrectly succeed when S was a string, because 4294967386 was
11304 truncated before it was used.
11305
8fd02eb7
PE
11306 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
11307 Otherwise, an out-of-range integer could cause undefined behavior
11308 on a 64-bit host.
11309
f8c86b69
PE
11310 * composite.c: Use int, not EMACS_INT, for characters.
11311 (fill_gstring_body, composition_compute_stop_pos): Use int, not
11312 EMACS_INT, for values that are known to be in character range.
11313 This doesn't fix any bugs but is the usual style inside Emacs and
11314 may generate better code on 32-bit machines.
11315
34206dd2
PE
11316 Make sure a 64-bit char is never passed to ENCODE_CHAR.
11317 This is for reasons similar to the recent CHAR_STRING fix.
11318 * charset.c (Fencode_char): Check that character arg is actually
11319 a character. Pass an int to ENCODE_CHAR.
11320 * charset.h (ENCODE_CHAR): Verify that the character argument is no
11321 wider than 'int', as a compile-time check to prevent future regressions
11322 in this area.
11323
c5958d4c 11324 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
11325
11326 Make sure a 64-bit char is never passed to CHAR_STRING.
11327 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
11328 by silently ignoring the top 32 bits, allowing some values
11329 that were far too large to be valid characters.
11330 * character.h: Include <verify.h>.
11331 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
11332 arguments are no wider than unsigned, as a compile-time check
11333 to prevent future regressions in this area.
11334 * data.c (Faset):
01103c44 11335 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
11336 (Fsubst_char_in_region):
11337 * fns.c (concat):
11338 * xdisp.c (decode_mode_spec_coding):
11339 Adjust to CHAR_STRING's new requirement.
11340 * editfns.c (Finsert_char, Fsubst_char_in_region):
11341 * fns.c (concat): Check that character args are actually
11342 characters. Without this test, these functions did the wrong
11343 thing with wildly out-of-range values on 64-bit hosts.
11344
d37ca623
PE
11345 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
11346 These casts should not be needed on 32-bit hosts, either.
11347 * keyboard.c (read_char):
11348 * lread.c (Fload): Remove casts to unsigned.
11349
ea204efb
PE
11350 * lisp.h (UNSIGNED_CMP): New macro.
11351 This fixes comparison bugs on 64-bit hosts.
11352 (ASCII_CHAR_P): Use it.
11353 * casefiddle.c (casify_object):
01103c44 11354 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
11355 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
11356 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
11357 * dispextern.h (FACE_FROM_ID):
11358 * keyboard.c (read_char): Use UNSIGNED_CMP.
11359
41cb286c
PE
11360 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
11361 not to EMACS_INT, to avoid GCC warning.
11362
4a1b9832
PE
11363 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
11364
55daad71
PE
11365 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
11366 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
11367 isn't needed on 32-bit machines.
8f95c75c 11368
01103c44
PE
11369 * buffer.c (Fgenerate_new_buffer_name):
11370 Use EMACS_INT for count, not int.
0ceccced 11371 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
11372
11373 * data.c (Qcompiled_function): Now static.
11374
c6f072e7
PE
11375 * window.c (window_body_lines): Now static.
11376
20ce5912
PE
11377 * image.c (gif_load): Rename local to avoid shadowing.
11378
9c4c5f81
PE
11379 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
11380 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
11381 * alloc.c (make_save_value): Integer argument is now of type
11382 ptrdiff_t, not int.
11383 (mark_object): Use ptrdiff_t, not int.
11384 * lisp.h (pD): New macro.
11385 * print.c (print_object): Use it.
11386
c0c5c8ae
PE
11387 * alloc.c: Use EMACS_INT, not int, to count objects.
11388 (total_conses, total_markers, total_symbols, total_vector_size)
11389 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
11390 (total_free_floats, total_floats, total_free_intervals)
11391 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
11392 Now EMACS_INT, not int. All uses changed.
11393 (Fgarbage_collect): Compute overall total using a double, so that
11394 integer overflow is less likely to be a problem. Check for overflow
11395 when converting back to an integer.
5a25e253
PE
11396 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
11397 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
11398 These were 'int' variables that could overflow on 64-bit hosts;
11399 they were never used, so remove them instead of repairing them.
211a0b2a 11400 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
11401 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
11402 Previously, this ceilinged at INT_MAX, but that doesn't work on
11403 64-bit machines.
e46bb31a 11404 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 11405
c78baabf 11406 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 11407 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
11408 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
11409 when a (possibly-narrower) signed value would do just as well.
11410 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 11411
c9d624c6
PE
11412 * alloc.c: Catch some string size overflows that we were missing.
11413 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
11414 for convenience in STRING_BYTES_MAX.
11415 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
11416 The definition here is exact; the one in lisp.h was approximate.
11417 (allocate_string_data): Check for string overflow. This catches
11418 some instances we weren't catching before. Also, it catches
11419 size_t overflow on (unusual) hosts where SIZE_MAX <= min
11420 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
11421 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 11422
c9d624c6
PE
11423 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
11424 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 11425 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 11426
353032ce
PE
11427 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
11428
2bccce07
PE
11429 * alloc.c (Fmake_string): Check for out-of-range init.
11430
0ac30604
SM
114312011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
11432
11433 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
11434
c195f2de
JD
114352011-06-14 Jan Djärv <jan.h.d@swipnet.se>
11436
11437 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
11438 xg_get_default_scrollbar_width.
11439
11440 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
11441 (int_gtk_range_get_value): Move to the scroll bar part of the file.
11442 (style_changed_cb): Call update_theme_scrollbar_width and call
11443 x_set_scroll_bar_default_width and xg_frame_set_char_size for
11444 all frames (Bug#8505).
11445 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
11446 Call gtk_window_set_resizable if HAVE_GTK3.
11447 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
11448 and height if HAVE_GTK3 (Bug#8505).
11449 (scroll_bar_width_for_theme): New variable.
11450 (update_theme_scrollbar_width): New function.
11451 (xg_get_default_scrollbar_width): Move code to
11452 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
11453 (xg_initialize): Call update_theme_scrollbar_width.
11454
11455 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
11456
11457 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
11458
e10ac9f1
MR
114592011-06-12 Martin Rudalics <rudalics@gmx.at>
11460
11461 * frame.c (make_frame): Call other_buffer_safely instead of
11462 other_buffer.
11463
11464 * window.c (temp_output_buffer_show): Call display_buffer with
11465 second argument Vtemp_buffer_show_specifiers and reset latter
11466 immediately after the call.
11467 (Vtemp_buffer_show_specifiers): New variable.
11468 (auto_window_vscroll_p, next_screen_context_lines)
11469 (Vscroll_preserve_screen_position): Remove leading asterisks from
11470 doc-strings.
11471
2d3c217e 114722011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 11473
7b7f97e8 11474 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
11475 * buffer.c (Qclone_number): Remove for now, as it's unused.
11476 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
11477 (record_buffer): Remove unused local.
11478 * frame.c (other_visible_frames, frame_buffer_list): Now static.
11479 (set_frame_buffer_list): Remove; unused.
11480 * frame.h (other_visible_frames): Remove decl.
11481 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
11482 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
11483 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
11484 if HAVE_GPM.
11485 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
11486 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
11487 Define only if HAVE_GPM.
11488 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
11489 (update_hints_inhibit): Remove; never set. All uses removed.
11490 * widgetprv.h (emacsFrameClassRec): Remove decl.
11491 * window.c (delete_deletable_window): Now returns void, since it
11492 wasn't returning anything.
11493 (compare_window_configurations): Remove unused locals.
11494 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
11495 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
11496 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
11497 the same widths as pointers. This follows up on the 2011-05-06 patch.
11498 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
11499 * xterm.h: Likewise.
11500 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
11501
1384b89e
JB
115022011-06-12 Juanma Barranquero <lekktu@gmail.com>
11503
11504 * makefile.w32-in: Update dependencies.
11505 (LISP_H): Add lib/intprops.h.
11506
1100a63c
CY
115072011-06-11 Chong Yidong <cyd@stupidchicken.com>
11508
11509 * image.c (gif_load): Add animation frame delay to the metadata.
11510 (syms_of_image): Use DEFSYM. New symbol `delay'.
11511
6198ccd0
MR
115122011-06-11 Martin Rudalics <rudalics@gmx.at>
11513
11514 * window.c (delete_deletable_window): Re-add.
11515 (Fset_window_configuration): Rewrite to handle dead buffers and
11516 consequently deletable windows.
11517 (window_tree, Fwindow_tree): Remove. Supply functionality in
11518 window.el.
11519 (compare_window_configurations): Simplify code.
11520
b6e3633c
AS
115212011-06-11 Andreas Schwab <schwab@linux-m68k.org>
11522
1ab0dee5
AS
11523 * image.c (imagemagick_load_image): Fix type mismatch.
11524 (Fimagemagick_types): Likewise.
11525
b6e3633c
AS
11526 * window.h (replace_buffer_in_windows): Declare.
11527
9397e56f
MR
115282011-06-11 Martin Rudalics <rudalics@gmx.at>
11529
11530 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
11531 Qclone_number. Remove external declaration of Qdelete_window.
11532 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
11533 code.
640c8776
SM
11534 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
11535 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
11536 (Fother_buffer): Rewrite doc-string. Major rewrite for new
11537 buffer list implementation.
11538 (other_buffer_safely): New function.
11539 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
11540 calls to replace_buffer_in_windows and
11541 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
11542 if allowed.
11543 (record_buffer): Inhibit quitting and rewrite using quittable
11544 functions. Run Qbuffer_list_update_hook if allowed.
11545 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
11546 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
11547 Move switch-to-buffer to window.el.
9397e56f
MR
11548 (bury-buffer): Move to window.el.
11549 (Vbuffer_list_update_hook): New variable.
11550
11551 * lisp.h (other_buffer_safely): Add prototype in buffer.c
11552 section.
11553
11554 * window.h (resize_frame_windows): Move up in code.
11555 (Fwindow_frame): Remove EXFUN.
11556 (replace_buffer_in_all_windows): Remove prototype.
11557 (replace_buffer_in_windows_safely): Add prototype.
11558
11559 * window.c: Declare Qdelete_window static again. Move down
11560 declaration of select_count.
11561 (Fnext_window, Fprevious_window): Rewrite doc-strings.
11562 (Fother_window): Move to window.el.
11563 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
11564 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
11565 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
11566 window.el.
11567 (replace_buffer_in_windows): Implement by calling
11568 Qreplace_buffer_in_windows.
11569 (replace_buffer_in_all_windows): Remove with some functionality
11570 moved into replace_buffer_in_windows_safely.
11571 (replace_buffer_in_windows_safely): New function.
11572 (select_window_norecord, select_frame_norecord): Move in front
11573 of run_window_configuration_change_hook. Remove now obsolete
11574 declarations.
640c8776
SM
11575 (Fset_window_buffer): Rewrite doc-string.
11576 Call Qrecord_window_buffer.
9397e56f
MR
11577 (keys_of_window): Move binding for other-window to window.el.
11578
b50691aa
CY
115792011-06-11 Chong Yidong <cyd@stupidchicken.com>
11580
11581 * dispextern.h (struct image): Replace data member, whose int_val
11582 and ptr_val fields were not used by anything, with a single
11583 lisp_val object.
11584
11585 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
11586 (gif_clear_image, gif_load, imagemagick_load_image)
11587 (gs_clear_image, gs_load): Callers changed.
11588
3f754b86
PE
115892011-06-10 Paul Eggert <eggert@cs.ucla.edu>
11590
cca69397
PE
11591 * buffer.h: Include <time.h>, for time_t.
11592 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
11593
109e28d0
PE
11594 Fix minor problems found by static checking.
11595
60737f02
PE
11596 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
11597
4b66faf3
PE
11598 Make identifiers static if they are not used in other modules.
11599 * data.c (Qcompiled_function, Qframe, Qvector):
11600 * image.c (QimageMagick, Qsvg):
11601 * minibuf.c (Qmetadata):
11602 * window.c (resize_window_check, resize_root_window): Now static.
11603 * window.h (resize_window_check, resize_root_window): Remove decls.
11604
109e28d0
PE
11605 * window.c (window_deletion_count, delete_deletable_window):
11606 Remove; unused.
46a4ce9e
PE
11607 (window_body_lines): Now static.
11608 (Fdelete_other_windows_internal): Mark vars as initialized.
11609 Make sure 'resize_failed' is initialized.
11610 (run_window_configuration_change_hook): Rename local to avoid shadowing.
11611 (resize_window_apply): Remove unused local.
11612 * window.h (delete_deletable_window): Remove decl.
11613
109e28d0 11614 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
11615 (imagemagick_load_image): Fix pointer signedness problem by changing
11616 last arg from unsigned char * to char *. All uses changed.
11617 Also, fix a local for similar reasons.
11618 Remove unused locals. Remove locals to avoid shadowing.
11619 (fn_rsvg_handle_free): Remove; unused.
11620 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 11621 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 11622
3f754b86
PE
11623 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
11624
2547adb1
CY
116252011-06-10 Chong Yidong <cyd@stupidchicken.com>
11626
11627 * image.c (gif_load): Fix omitted cast error introduced by
11628 2011-06-06 change.
11629
2c8e37d4
MR
116302011-06-10 Martin Rudalics <rudalics@gmx.at>
11631
11632 * window.h (resize_proportionally, orig_total_lines)
11633 (orig_top_line): Remove from window structure.
11634 (set_window_height, set_window_width, change_window_heights)
11635 (Fdelete_window): Remove prototypes.
11636 (resize_frame_windows): Remove duplicate declaration.
11637
440a42e3
EZ
116382011-06-10 Eli Zaretskii <eliz@gnu.org>
11639
11640 * window.h (resize_frame_windows, resize_window_check)
11641 (delete_deletable_window, resize_root_window)
11642 (resize_frame_windows): Declare prototypes.
11643
11644 * window.c (resize_window_apply): Make definition be "static" to
11645 match the prototype.
11646
562dd5e9
MR
116472011-06-10 Martin Rudalics <rudalics@gmx.at>
11648
11649 * window.c: Remove declarations of Qwindow_size_fixed,
11650 window_min_size_1, window_min_size_2, window_min_size,
11651 size_window, window_fixed_size_p, enlarge_window, delete_window.
11652 Remove static from declaration of Qdelete_window, it's
11653 temporarily needed by Fbury_buffer.
11654 (replace_window): Don't assign orig_top_line and
11655 orig_total_lines.
11656 (Fdelete_window, delete_window): Remove. Window deletion is
11657 handled by window.el.
640c8776
SM
11658 (window_loop): Remove DELETE_OTHER_WINDOWS case.
11659 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
11660 (Fdelete_other_windows): Remove. Deleting other windows is
11661 handled by window.el.
11662 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
11663 handled in window.el.
11664 (window_min_size_2, window_min_size_1, window_min_size): Remove.
11665 Window minimum sizes are handled in window.el.
11666 (shrink_windows, size_window, set_window_height)
11667 (set_window_width, change_window_heights, window_height)
11668 (window_width, CURBEG, CURSIZE, enlarge_window)
11669 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
11670 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
11671 handled in window.el.
11672 (make_dummy_parent): Rename to make_parent_window and give it a
11673 second argument horflag.
11674 (make_window): Don't set resize_proportionally any more.
11675 (Fsplit_window): Remove. Windows are split in window.el.
11676 (save_restore_action, save_restore_orig_size)
11677 (shrink_window_lowest_first, save_restore_orig_size): Remove.
11678 Resize mini windows in window.el.
11679 (grow_mini_window, shrink_mini_window): Implement by calling
11680 Qresize_root_window_vertically, resize_window_check and
11681 resize_window_apply.
640c8776
SM
11682 (saved_window, Fset_window_configuration, save_window_save):
11683 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
11684 resize_proportionally.
11685 (window_min_height, window_min_width): Move to window.el.
11686 (keys_of_window): Move bindings for delete-other-windows,
11687 split-window, delete-window and enlarge-window to window.el.
11688
11689 * buffer.c: Temporarily extern Qdelete_window.
11690 (Fbury_buffer): Temporarily call Qdelete_window instead of
11691 Fdelete_window (Fbury_buffer will move to window.el soon).
11692
11693 * frame.c (set_menu_bar_lines_1): Remove code handling
11694 orig_top_line and orig_total_lines.
11695
11696 * dispnew.c (adjust_frame_glyphs_initially): Don't use
11697 set_window_height but set heights directly.
11698 (change_frame_size_1): Use resize_frame_windows.
11699
11700 * xdisp.c (init_xdisp): Don't use set_window_height but set
11701 heights directly.
11702
640c8776
SM
11703 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
11704 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
11705 run_window_configuration_change_hook.
11706
11707 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
11708 instead of change_window_heights and run
11709 run_window_configuration_change_hook.
11710
1a13852e
MR
117112011-06-09 Martin Rudalics <rudalics@gmx.at>
11712
11713 * window.c (replace_window): Rename second argument REPLACEMENT to
11714 NEW. New third argument SETFLAG. Rewrite.
11715 (delete_window, make_dummy_parent): Call replace_window with
11716 third argument 1.
11717 (window_list_1): Move down in code.
11718 (run_window_configuration_change_hook): Move set_buffer part
11719 before select_frame_norecord part in order to unwind correctly.
11720 Rename count1 to count.
11721 (recombine_windows, delete_deletable_window, resize_root_window)
11722 (Fdelete_other_windows_internal)
11723 (Frun_window_configuration_change_hook, make_parent_window)
11724 (resize_window_check, resize_window_apply, Fresize_window_apply)
11725 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
11726 (Fdelete_window_internal, Fresize_mini_window_internal):
11727 New functions.
1a13852e
MR
11728 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
11729
f3d1777e
MR
117302011-06-08 Martin Rudalics <rudalics@gmx.at>
11731
496e208e
MR
11732 * window.h (window): Add some new members to window structure -
11733 normal_lines, normal_cols, new_total, new_normal, clone_number,
11734 splits, nest, prev_buffers, next_buffers.
11735 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 11736 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 11737
f3d1777e
MR
11738 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
11739 Remove.
496e208e
MR
11740 (make_dummy_parent): Set new members of windows structure.
11741 (make_window): Move down in code. Handle new members of window
11742 structure.
11743 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
11744 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
11745 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
11746 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
11747 (Fset_window_next_buffers, Fset_window_clone_number):
11748 New functions.
496e208e
MR
11749 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
11750 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
11751 Doc-string fixes.
11752 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
11753 Argument WINDOW can be now internal window too.
11754 (Fwindow_use_time): Move up in code.
11755 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
11756 Rewrite doc-string.
11757 (Fset_window_configuration, saved_window)
11758 (Fcurrent_window_configuration, save_window_save): Handle new
11759 members of window structure.
b9e809c2
MR
11760 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
11761 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
11762 (syms_of_window): New Lisp objects Qrecord_window_buffer,
11763 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
11764 Qget_mru_window, Qresize_root_window,
11765 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
11766 Qauto_buffer_name; staticpro them.
f3d1777e 11767
abde8f8c
MR
117682011-06-07 Martin Rudalics <rudalics@gmx.at>
11769
11770 * window.c (Fwindow_total_size, Fwindow_left_column)
11771 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
11772 (Fwindow_list_1): New functions.
11773 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
11774 (Fwindow_width, Fscroll_left, Fscroll_right):
11775 Use window_body_cols instead of window_box_text_cols.
11776 (delete_window, Fset_window_configuration):
11777 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
11778 (delete_all_subwindows): Take a window as argument and not a
11779 structure. Rewrite.
190b47e6
MR
11780 (window_loop): Remove handling of GET_LRU_WINDOW and
11781 GET_LARGEST_WINDOW.
11782 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
11783
11784 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
11785 window_box_text_cols. delete_all_subwindows now takes a
11786 Lisp_Object as argument.
abde8f8c 11787
640c8776
SM
11788 * indent.c (compute_motion, Fcompute_motion):
11789 Use window_body_cols instead of window_box_text_cols.
abde8f8c 11790
fa8a67e6
MR
11791 * frame.c (delete_frame): Call delete_all_subwindows with root
11792 window as argument.
11793
a54e3482
DC
117942011-06-07 Daniel Colascione <dan.colascione@gmail.com>
11795
11796 * fns.c (Fputhash): Document return value.
11797
60002bf5
CY
117982011-06-06 Chong Yidong <cyd@stupidchicken.com>
11799
11800 * image.c (gif_load): Implement gif89a spec "no disposal" method.
11801
0c671da6 118022011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 11803
b862a52a 11804 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 11805
be44ca6c
PE
11806 Check for overflow when converting integer to cons and back.
11807 * charset.c (Fdefine_charset_internal, Fdecode_char):
11808 Use cons_to_unsigned to catch overflow.
11809 (Fencode_char): Use INTEGER_TO_CONS.
11810 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
11811 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
11812 * data.c (long_to_cons, cons_to_long): Remove.
11813 (cons_to_unsigned, cons_to_signed): New functions.
11814 These signal an error for invalid or out-of-range values.
11815 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
11816 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
11817 * font.c (Ffont_variation_glyphs):
11818 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
11819 * lisp.h: Include <intprops.h>.
11820 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
11821 (cons_to_signed, cons_to_unsigned): New decls.
11822 (long_to_cons, cons_to_long): Remove decls.
11823 * undo.c (record_first_change): Use INTEGER_TO_CONS.
11824 (Fprimitive_undo): Use CONS_TO_INTEGER.
11825 * xfns.c (Fx_window_property): Likewise.
11826 * xselect.c: Include <limits.h>.
11827 (x_own_selection, selection_data_to_lisp_data):
11828 Use INTEGER_TO_CONS.
11829 (x_handle_selection_request, x_handle_selection_clear)
11830 (x_get_foreign_selection, Fx_disown_selection_internal)
11831 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
11832 (lisp_data_to_selection_data): Use cons_to_unsigned.
11833 (x_fill_property_data): Use cons_to_signed.
11834 Report values out of range.
11835
d1f3d2af
PE
11836 Check for buffer and string overflow more precisely.
11837 * buffer.h (BUF_BYTES_MAX): New macro.
11838 * lisp.h (STRING_BYTES_MAX): New macro.
11839 * alloc.c (Fmake_string):
11840 * character.c (string_escape_byte8):
11841 * coding.c (coding_alloc_by_realloc):
11842 * doprnt.c (doprnt):
11843 * editfns.c (Fformat):
11844 * eval.c (verror):
11845 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
11846 since they may not be the same number.
11847 * editfns.c (Finsert_char):
11848 * fileio.c (Finsert_file_contents):
11849 Likewise for BUF_BYTES_MAX.
11850
dd52fcea
PE
11851 * image.c: Use ptrdiff_t, not int, for sizes.
11852 (slurp_file): Switch from int to ptrdiff_t.
11853 All uses changed.
11854 (slurp_file): Check that file size fits in both size_t (for
11855 malloc) and ptrdiff_t (for sanity and safety).
11856
7f9bbdbb
PE
11857 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
11858 if b->modtime has its maximal value.
11859
dfe18f82
PE
11860 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
11861
84acfcf0
PE
11862 Don't assume time_t can fit into int.
11863 * buffer.h (struct buffer.modtime): Now time_t, not int.
11864 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
11865 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
11866
ccd9a01a
PE
11867 Minor fixes for signed vs unsigned integers.
11868 * character.h (MAYBE_UNIFY_CHAR):
11869 * charset.c (maybe_unify_char):
11870 * keyboard.c (read_char, reorder_modifiers):
11871 XINT -> XFASTINT, since the integer must be nonnegative.
11872 * ftfont.c (ftfont_spec_pattern):
11873 * keymap.c (access_keymap, silly_event_symbol_error):
11874 XUINT -> XFASTINT, since the integer must be nonnegative.
11875 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
11876 since it makes no difference and we prefer signed.
11877 * keyboard.c (record_char): Use XUINT when all the neighbors do.
11878 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
11879 nonnegative.
11880
d6d100dd
SM
118812011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
11882
11883 * window.h (Fwindow_frame): Declare.
11884
2b6148e4
PE
118852011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11886
11887 * alloc.c: Simplify handling of large-request failures (Bug#8800).
11888 (SPARE_MEMORY): Always define.
11889 (LARGE_REQUEST): Remove.
11890 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
11891
f230ecc9
MR
118922011-06-06 Martin Rudalics <rudalics@gmx.at>
11893
727e958e
MR
11894 * lisp.h: Move EXFUNS for Fframe_root_window,
11895 Fframe_first_window and Fset_frame_selected_window to window.h.
11896
11897 * window.h: Move EXFUNS for Fframe_root_window,
11898 Fframe_first_window and Fset_frame_selected_window here from
11899 lisp.h.
11900
11901 * frame.c (Fwindow_frame, Fframe_first_window)
11902 (Fframe_root_window, Fframe_selected_window)
11903 (Fset_frame_selected_window): Move to window.c.
11904 (Factive_minibuffer_window): Move to minibuf.c.
11905 (Fother_visible_frames_p): New function.
11906
11907 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
11908
f230ecc9
MR
11909 * window.c (decode_window, decode_any_window): Move up in code.
11910 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
11911 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
11912 (Fwindow_buffer): Move up and rewrite doc-string.
11913 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
11914 (Fwindow_prev): New functions.
727e958e
MR
11915 (Fwindow_frame): Move here from frame.c. Accept any window as
11916 argument.
11917 (Fframe_root_window, Fframe_first_window)
11918 (Fframe_selected_window): Move here from frame.c. Accept frame
11919 or arbitrary window as argument. Update doc-strings.
11920 (Fminibuffer_window): Move up in code.
11921 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
11922 (Fset_frame_selected_window): Move here from frame.c.
11923 Marginal rewrite.
727e958e
MR
11924 (Fselected_window, select_window, Fselect_window): Move up in
11925 code. Minor doc-string fixes.
f230ecc9 11926
4d09bcf6
PE
119272011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11928
11929 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
11930 Do not assume that spare memory exists; that assumption is valid
11931 only if SYSTEM_MALLOC.
11932 (LARGE_REQUEST): New macro, so that the issue of large requests
11933 is separated from the issue of spare memory.
11934
810928a2
AS
119352011-06-05 Andreas Schwab <schwab@linux-m68k.org>
11936
172418ad
AS
11937 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
11938 format. (Bug#8806)
11939
43f862f7
AS
11940 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
11941
810928a2
AS
11942 * xfns.c (x_set_scroll_bar_default_width): Move declarations
11943 before statements.
11944
a059fe24
JD
119452011-06-05 Jan Djärv <jan.h.d@swipnet.se>
11946
11947 * gtkutil.c (xg_get_default_scrollbar_width): New function.
11948
11949 * gtkutil.h: Declare xg_get_default_scrollbar_width.
11950
11951 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
11952 min width by calling x_set_scroll_bar_default_width (Bug#8505).
11953
989bf368
JB
119542011-06-05 Juanma Barranquero <lekktu@gmail.com>
11955
11956 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
11957
4b80f674
CY
119582011-06-04 Chong Yidong <cyd@stupidchicken.com>
11959
11960 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
11961 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
11962 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
11963 New error handlers.
4b80f674
CY
11964 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
11965 Obey Vx_select_enable_clipboard_manager. Catch errors in
11966 x_clipboard_manager_save (Bug#8779).
11967 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 11968 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 11969
99a33b77 119702011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
11971
11972 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
11973
99a33b77 119742011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
11975
11976 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
11977 in the current matrix if keep_current_p is non-zero.
11978
8264569d
EZ
119792011-06-04 Eli Zaretskii <eliz@gnu.org>
11980
11981 * bidi.c (bidi_level_of_next_char): Fix last change.
11982
57f97249
EZ
119832011-06-03 Eli Zaretskii <eliz@gnu.org>
11984
fec2107c 11985 Support bidi reordering of text covered by display properties.
57f97249 11986
fec2107c
EZ
11987 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
11988 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
11989 (bidi_cache_search, bidi_cache_iterator_state)
11990 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
11991 (bidi_level_of_next_char, bidi_move_to_visually_next):
11992 Support character positions inside a run of characters covered by a
fec2107c
EZ
11993 display string.
11994 (bidi_paragraph_init, bidi_resolve_explicit_1)
11995 (bidi_level_of_next_char): Call bidi_fetch_char and
11996 bidi_fetch_char_advance instead of FETCH_CHAR and
11997 FETCH_CHAR_ADVANCE.
11998 (bidi_init_it): Initialize new members.
11999 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
12000 definitions.
12001 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
12002 instead of using explicit *_CHAR codes.
d6d100dd
SM
12003 (bidi_resolve_explicit, bidi_resolve_weak):
12004 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
12005 bidirectional text is supported only in multibyte buffers.
12006 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
12007 it to initialize the frame_window_p member of struct bidi_it.
12008 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
12009 (bidi_resolve_explicit, bidi_resolve_weak)
12010 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
12011 bidi_it->nchars is non-positive.
12012 (bidi_level_of_next_char): Don't try to lookup the cache for the
12013 next/previous character if nothing is cached there yet, or if we
12014 were just reseat()'ed to a new position.
c40e2fb2 12015
0e14fe90
EZ
12016 * xdisp.c (set_cursor_from_row): Set start and stop points
12017 according to the row's direction when priming the loop that looks
12018 for the glyph on which to display cursor.
12019 (single_display_spec_intangible_p): Function deleted.
12020 (display_prop_intangible_p): Reimplement to call
12021 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
12022 Accept 3 additional arguments needed by handle_display_spec.
12023 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
12024 values: lists, `(when COND...)' forms, etc.
12025 (single_display_spec_string_p): Support property values that are
12026 lists with the argument STRING its top-level element.
12027 (display_prop_string_p): Fix the condition for processing a
12028 property that is a list to be consistent with handle_display_spec.
fec2107c 12029 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
12030 last portion of handle_display_prop.
12031 (compute_display_string_pos): Accept additional argument
12032 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
12033 value of a `display' property is a "replacing spec".
12034 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
12035 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
12036 the display property, but just return a value indicating whether
12037 the display property will replace the characters it covers.
12038 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
12039 frame_window_p members of struct bidi_it.
d6d100dd
SM
12040 (compute_display_string_pos, compute_display_string_end):
12041 New functions.
fec2107c
EZ
12042 (push_it): Accept second argument POSITION, where pop_it should
12043 jump to continue iteration.
12044 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 12045
fec2107c
EZ
12046 * keyboard.c (adjust_point_for_property): Adjust the call to
12047 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
12048
12049 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
12050 (bidi_init_it): Update prototypes.
12051 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
12052 (compute_display_string_pos, compute_display_string_end):
12053 Declare prototypes.
fec2107c
EZ
12054 (struct bidi_it): New members nchars and disp_pos. ch_len is now
12055 EMACS_INT.
fc6f18ce 12056
40087514 120572011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 12058
57f53182
PE
12059 Malloc failure behavior now depends on size of allocation.
12060 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
12061 * lisp.h: Change signatures accordingly.
12062 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
12063 All callers changed. (Bug#8762)
12064
12065 * gnutls.c: Use Emacs's memory allocators.
12066 Without this change, the gnutls library would invoke malloc etc.
12067 directly, which causes problems on non-SYNC_INPUT hosts, and which
12068 runs afoul of improving memory_full behavior. (Bug#8761)
12069 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
12070 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
12071 xfree instead of the default malloc, realloc, free.
12072 (Fgnutls_boot): No need to check for memory allocation failure,
12073 since xmalloc does that for us.
12074
ac32cd99 12075 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
12076 * category.c (hash_get_category_set):
12077 * ccl.c (ccl_driver):
12078 * charset.c (Fdefine_charset_internal):
12079 * charset.h (struct charset.hash_index):
12080 * composite.c (get_composition_id, gstring_lookup_cache)
12081 (composition_gstring_put_cache):
12082 * composite.h (struct composition.hash_index):
12083 * dispextern.h (struct image.hash):
12084 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
12085 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
12086 (hashfn_equal, hashfn_user_defined, make_hash_table)
12087 (maybe_resize_hash_table, hash_lookup, hash_put)
12088 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
12089 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
12090 (Fsxhash, Fgethash, Fputhash, Fmaphash):
12091 * image.c (make_image, search_image_cache, lookup_image)
12092 (xpm_put_color_table_h):
12093 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 12094 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 12095 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 12096 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
12097 * alloc.c (allocate_vectorlike):
12098 Check for overflow in vector size calculations.
12099 * ccl.c (ccl_driver):
12100 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
12101 * fns.c, image.c: Remove unnecessary static decls that would otherwise
12102 need to be updated by these changes.
40087514
PE
12103 * fns.c (make_hash_table, maybe_resize_hash_table):
12104 Check for integer overflow with large hash tables.
0de4bb68
PE
12105 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
12106 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
12107 (SXHASH_REDUCE): New macro.
12108 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
12109 Use it instead of discarding useful hash info with large hash values.
12110 (sxhash_float): New function.
12111 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
12112 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
12113 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
12114 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
12115 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
12116 Adjust signatures to match updated version of code.
12117 (consing_since_gc): Now EMACS_INT, since a single hash table can
12118 use more than INT_MAX bytes.
12119
698d32e2
DN
121202011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
12121
12122 Make it possible to build with GCC-4.6+ -O2 -flto.
12123
12124 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
12125
fd6fa53f
SM
121262011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
12127
12128 * minibuf.c (get_minibuffer, read_minibuf_unwind):
12129 Call minibuffer-inactive-mode.
12130
864db017
JB
121312011-05-31 Juanma Barranquero <lekktu@gmail.com>
12132
12133 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
12134 Update dependencies.
12135
2ad0baf4
DN
121362011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
12137
12138 * data.c (init_data): Remove code for UTS, this system is not
12139 supported anymore.
12140
4fcc2638
DN
121412011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
12142
12143 Don't force ./temacs to start in terminal mode.
12144
12145 * frame.c (make_initial_frame): Initialize faces in all cases, not
12146 only when CANNOT_DUMP is defined.
12147 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
12148
c56e0fd5
DN
121492011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
12150
12151 * dispnew.c (add_window_display_history): Use const for the string
12152 pointer. Remove declaration, not needed.
12153
333d54da 121542011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 12155
55d4c1b2 12156 Use 'inline', not 'INLINE'.
333d54da 12157 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
12158 * alloc.c, fontset.c (INLINE): Remove.
12159 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
12160 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
12161 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
12162 * gmalloc.c (register_heapinfo): Use inline unconditionally.
12163 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
12164
738db178
DN
121652011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
12166
12167 Make it possible to run ./temacs.
12168
12169 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
12170 syms_of_callproc does the same thing. Remove test for
12171 "initialized", do it in the caller.
12172 * emacs.c (main): Avoid calling set_initial_environment when dumping.
12173
620c53a6
SM
121742011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
12175
12176 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
12177 (read_minibuf): Use get_minibuffer.
12178 (syms_of_minibuf): Use DEFSYM.
12179 (Qmetadata): New var.
12180 * data.c (Qbuffer): Don't make it static.
12181 (syms_of_data): Use DEFSYM.
12182
e003a292
PE
121832011-05-31 Paul Eggert <eggert@cs.ucla.edu>
12184
12185 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
12186 (CCL_CODE_MIN): New macro.
12187
ed008a6d
PE
121882011-05-30 Paul Eggert <eggert@cs.ucla.edu>
12189
3687c2ef
PE
12190 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
12191
ed008a6d
PE
12192 * eval.c (Qdebug): Now static.
12193 * lisp.h (Qdebug): Remove decl. This reverts a part of the
12194 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
12195 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
12196
d66c4c7c
CY
121972011-05-29 Chong Yidong <cyd@stupidchicken.com>
12198
12199 * image.c: Various fixes to ImageMagick code comments.
12200 (Fimagemagick_types): Doc fix.
12201
5fbc2025
PE
122022011-05-29 Paul Eggert <eggert@cs.ucla.edu>
12203
0196f88a
PE
12204 Minor fixes prompted by GCC 4.6.0 warnings.
12205
12206 * xselect.c (converted_selections, conversion_fail_tag): Now static.
12207
5fbc2025
PE
12208 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
12209 (x_clipboard_manager_save_all): Move extern decl to ...
12210 * xterm.h: ... here, so that it can be checked for consistency.
12211
1dd3c2d9
CY
122122011-05-29 Chong Yidong <cyd@stupidchicken.com>
12213
12214 * xselect.c (x_clipboard_manager_save_frame)
12215 (x_clipboard_manager_save_all): New functions.
12216 (Fx_clipboard_manager_save): Lisp function deleted.
12217
12218 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
12219 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
12220
12221 * xterm.h: Update prototype.
12222
5ba6571d
WX
122232011-05-28 William Xu <william.xwl@gmail.com>
12224
12225 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
12226 exiting (Bug#8239).
12227
3eaff834
JM
122282011-05-28 Jim Meyering <meyering@redhat.com>
12229
e1900994 12230 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
12231 * fns.c (to_uchar): Define.
12232 (crypto_hash_function): Use it to convert some newly-signed
12233 variables to unsigned, to avoid sign-extension bugs. For example,
12234 without this change, (md5 "truc") would evaluate to
12235 45723a2aff78ff4fff7fff1114760e62 rather than the expected
12236 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 12237 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 12238
0f6990a7
PE
122392011-05-27 Paul Eggert <eggert@cs.ucla.edu>
12240
12241 Integer overflow fixes.
c8a9ca5a 12242
08686060
PE
12243 * dbusbind.c: Serial number integer overflow fixes.
12244 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
12245 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
12246 to hold a serial number that is too large for a fixnum.
12247 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12248 Check for serial numbers out of range. Decode any serial number
59568bf0 12249 that was so large that it became a float. (Bug#8722)
08686060 12250
2d1fc3c7
PE
12251 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
12252 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12253 Use XFASTINT rather than XUINT when numbers are nonnegative.
12254 (xd_append_arg, Fdbus_method_return_internal):
12255 (Fdbus_method_error_internal): Likewise. Also, for unsigned
12256 arguments, check that Lisp number is nonnegative, rather than
59568bf0 12257 silently wrapping negative numbers around. (Bug#8722)
30217ff0 12258 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 12259 (Bug#8722)
2d1fc3c7 12260
c8a9ca5a
PE
12261 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
12262
519e1d69
PE
12263 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
12264
6df6ae42 12265 ccl: Add integer overflow checks.
30569699
PE
12266 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
12267 (IN_INT_RANGE): New macros.
12268 (ccl_driver): Use them to check for integer overflow when
12269 decoding a CCL program. Many of the new checks are whether XINT (x)
12270 fits in int; it doesn't always, on 64-bit hosts. The new version
12271 doesn't catch all possible integer overflows, but it's an
847044ea 12272 improvement. (Bug#8719)
30569699 12273
c11285dc
PE
12274 * alloc.c (make_event_array): Use XINT, not XUINT.
12275 There's no need for unsigned here.
12276
fdccd48e
PE
12277 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
12278 This follows up to the 2011-05-06 change that substituted uintptr_t
12279 for EMACS_INT. This case wasn't caught back then.
12280
37910ab2
PE
12281 Rework Fformat to avoid integer overflow issues.
12282 * editfns.c: Include <float.h> unconditionally, as it's everywhere
12283 now (part of C89). Include <verify.h>.
12284 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
12285 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
12286 (Fformat): Avoid the prepass trying to compute sizes; it was only
12287 approximate and thus did not catch overflow reliably. Instead, walk
12288 through the format just once, formatting and computing sizes as we go,
12289 checking for integer overflow at every step, and allocating a larger
12290 buffer as needed. Keep track separately whether the format is
12291 multibyte. Keep only the most-recently calculated precision, rather
12292 than them all. Record whether each argument has been converted to
12293 string. Use EMACS_INT, not int, for byte and char and arg counts.
12294 Support field widths and precisions larger than INT_MAX. Avoid
12295 sprintf's undefined behavior with conversion specifications such as %#d
12296 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
12297 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
12298 formatting out-of-range floating point numbers with int
9173deec 12299 formats. (Bug#8668)
37910ab2 12300
2e6578fb
PE
12301 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
12302
0ae6bdee
PE
12303 * data.c: Avoid integer truncation in expressions involving floats.
12304 * data.c: Include <intprops.h>.
12305 (arith_driver): When there's an integer overflow in an expression
12306 involving floating point, convert the integers to floating point
12307 so that the resulting value does not suffer from catastrophic
12308 integer truncation. For example, on a 64-bit host (* 4
12309 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
12310 Do not rely on undefined behavior after integer overflow.
12311
de883a70
PE
12312 merge count_size_as_multibyte, parse_str_to_multibyte
12313 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 12314 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
12315 Check for integer overflow.
12316 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
12317 since it's now a duplicate of the other. This is more of
12318 a character than a buffer op, so better that it's in character.c.
12319 * fns.c, print.c: Adjust to above changes.
12320
2ff916cb
PE
123212011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
12322
12323 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
12324
f1b54466
PE
123252011-05-27 Paul Eggert <eggert@cs.ucla.edu>
12326
fb1ac845
PE
12327 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
12328 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
12329 (x_clipboard_manager_save): Now static.
12330 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
12331
f1b54466
PE
12332 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
12333 (crypto_hash_function): Now static.
12334 Fix pointer signedness problems. Avoid unnecessary initializations.
12335
a9f737ee
CY
123362011-05-27 Chong Yidong <cyd@stupidchicken.com>
12337
12338 * termhooks.h (Vselection_alist): Make it terminal-local.
12339
12340 * terminal.c (create_terminal): Initialize it.
12341
12342 * xselect.c: Support for clipboard managers.
12343 (Vselection_alist): Move to termhooks.h as terminal-local var.
12344 (LOCAL_SELECTION): New macro.
12345 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
12346 (symbol_to_x_atom): Remove gratuitous arg.
12347 (x_handle_selection_request, lisp_data_to_selection_data)
12348 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
12349 (x_own_selection, x_get_local_selection, x_convert_selection):
12350 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
12351 (some_frame_on_display): Delete unused function.
12352 (Fx_own_selection_internal, Fx_get_selection_internal)
12353 (Fx_disown_selection_internal, Fx_selection_owner_p)
12354 (Fx_selection_exists_p): New optional frame arg.
12355 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
12356 (x_handle_selection_clear): Don't treat other terminals with the
12357 same keyboard specially. Use the terminal-local Vselection_alist.
12358 (x_clear_frame_selections): Use Frun_hook_with_args.
12359
12360 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
12361
12362 * xterm.h: Add support for those atoms.
12363
e067f0c1
CY
123642011-05-26 Chong Yidong <cyd@stupidchicken.com>
12365
12366 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
12367 (converted_selections, conversion_fail_tag): New global variables.
12368 (x_selection_request_lisp_error): Free the above.
12369 (x_get_local_selection): Remove unnecessary code.
12370 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
12371 of converted selections stored in converted_selections.
12372 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
12373 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
12374 (x_convert_selection): New function.
12375 (x_handle_selection_event): Simplify.
12376 (x_get_foreign_selection): Don't ignore incoming requests while
12377 waiting for an answer; this will fail when we implement
12378 SAVE_TARGETS, and seems unnecessary anyway.
12379 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
12380 (Vx_sent_selection_functions): Doc fix.
12381
0f4aebc0
LL
123822011-05-26 Leo Liu <sdl.web@gmail.com>
12383
12384 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
12385
e61124cd
YM
123862011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12387
12388 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
12389
12390 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
12391 for fringe update if it has periodic bitmap.
ac389d0c 12392 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
12393 and fringe_bitmap_periodic_p.
12394
12395 * fringe.c (get_fringe_bitmap_data): New function.
12396 (draw_fringe_bitmap_1, update_window_fringes): Use it.
12397 (update_window_fringes): Record periodicity of fringe bitmap in glyph
12398 row. Mark glyph row for fringe update if periodicity changed.
12399
12400 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
12401 for fringe update unless it has periodic bitmap.
12402
f16d9837
KH
124032011-05-25 Kenichi Handa <handa@m17n.org>
12404
12405 * xdisp.c (get_next_display_element): Set correct it->face_id for
12406 a static composition.
12407
e1b90ef6
LL
124082011-05-24 Leo Liu <sdl.web@gmail.com>
12409
12410 * deps.mk (fns.o):
12411 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
12412
12413 * fns.c (crypto_hash_function, Fsha1): New function.
12414 (Fmd5): Use crypto_hash_function.
12415 (syms_of_fns): Add Ssha1.
12416
7400048f
PE
124172011-05-22 Paul Eggert <eggert@cs.ucla.edu>
12418
12419 * gnutls.c: Remove unused macros.
12420 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
12421 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
12422 Remove macros that are defined and never used.
12423 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
12424
abb71cf4
CY
124252011-05-22 Chong Yidong <cyd@stupidchicken.com>
12426
12427 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
12428 (Fx_get_selection_internal): Minor cleanup.
12429 (Fx_own_selection_internal): Rename arguments for consistency with
12430 select.el.
12431
6307db39
PE
124322011-05-22 Paul Eggert <eggert@cs.ucla.edu>
12433
12434 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
12435
f3d4e0a4
CY
124362011-05-22 Chong Yidong <cyd@stupidchicken.com>
12437
12438 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
12439
4d8ade89
YM
124402011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12441
12442 * dispnew.c (scrolling_window): Don't exclude the case that the
12443 last enabled row in the desired matrix touches the bottom boundary.
12444
32078c8d
GM
124452011-05-21 Glenn Morris <rgm@gnu.org>
12446
12447 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
12448 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
12449 and add some more files.
32078c8d 12450
7285dc67
EZ
124512011-05-20 Eli Zaretskii <eliz@gnu.org>
12452
12453 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
12454 report_file_error introduced by the change from 2011-05-07.
12455
89d1bd22
PE
124562011-05-20 Paul Eggert <eggert@cs.ucla.edu>
12457
12458 * systime.h (Time): Define only if emacs is defined.
12459 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
12460 where the include path doesn't have X11/X.h by default. See
12461 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
12462
cd394be1 124632011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
12464
12465 * composite.c (find_automatic_composition): Fix previous change.
12466
b9704ad9
GM
124672011-05-20 Glenn Morris <rgm@gnu.org>
12468
12469 * lisp.mk: New file, split from Makefile.in.
12470 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
12471 (shortlisp): Remove.
12472 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
12473
4a720484
GM
124742011-05-19 Glenn Morris <rgm@gnu.org>
12475
12476 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
12477 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
12478 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
12479 (lisp): Set the order to that of loadup.el.
12480 (shortlisp): Make it a copy of $lisp.
12481 (SOME_MACHINE_LISP): Remove.
12482 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
12483 Use just $shortlisp, not $SOME_MACHINE_LISP too.
12484
a28d4396
KH
124852011-05-18 Kenichi Handa <handa@m17n.org>
12486
12487 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
12488 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
12489 (find_automatic_composition): Mostly rewrite for efficiency.
12490
a2b1fa8e
JB
124912011-05-18 Juanma Barranquero <lekktu@gmail.com>
12492
12493 * makefile.w32-in: Update dependencies.
12494
8e1f5610
CS
124952011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
12496
12497 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 12498 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 12499
7025ee00 125002011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 12501
cdfa6eab
PE
12502 Fix some integer overflow issues, such as string length overflow.
12503
06d6db33
PE
12504 * insdel.c (count_size_as_multibyte): Check for string overflow.
12505
2b4560a8
PE
12506 * character.c (lisp_string_width): Check for string overflow.
12507 Use EMACS_INT, not int, for string indexes and lengths; in
12508 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
12509 the resulting string length overflows an EMACS_INT; instead,
12510 report a string overflow if no precision given. When checking for
12511 precision exhaustion, use a check that cannot possibly have
12512 integer overflow. (Bug#8675)
12513 * character.h (lisp_string_width): Adjust to new signature.
12514
cb93f9be
PE
12515 * alloc.c (string_overflow): New function.
12516 (Fmake_string): Use it. This doesn't change behavior, but saves
12517 a few bytes and will simplify future changes.
12518 * character.c (string_escape_byte8): Likewise.
12519 * lisp.h (string_overflow): New decl.
12520
1a1f3366
PE
12521 Fixups, following up to the user-interface timestamp change.
12522 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
12523 for UI timestamps, instead of unsigned long.
9fbd6841
PE
12524 * msdos.c (mouse_get_pos): Likewise.
12525 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
12526 * w32gui.h (Time): Define by including "systime.h" rather than by
12527 declaring it ourselves. (Bug#8664)
12528
d4e3e4d3
PE
12529 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
12530 * image.c (clear_image_cache): Likewise.
12531
f6a24d19
PE
12532 * term.c (term_mouse_position): Don't assume time_t wraparound.
12533
08dc5ae6
PE
12534 Be more systematic about user-interface timestamps.
12535 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
12536 and sometimes 'EMACS_UINT', to represent these timestamps.
12537 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
12538 This makes the code easier to follow, and makes it easier to catch
12539 integer overflow bugs such as Bug#8664.
12540 * frame.c (Fmouse_position, Fmouse_pixel_position):
12541 Use Time, not unsigned long, for user-interface timestamps.
12542 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
12543 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
12544 * keyboard.h (last_event_timestamp): Likewise.
12545 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
12546 * menu.h (xmenu_show): Likewise.
12547 * term.c (term_mouse_position): Likewise.
12548 * termhooks.h (struct input_event.timestamp): Likewise.
12549 (struct terminal.mouse_position_hook): Likewise.
12550 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
12551 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
12552 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
12553 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
12554 what it was before.
12555 * menu.h, termhooks.h: Include "systime.h", for Time.
12556
8e55734a
PE
12557 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
12558 Don't assume that the difference between two unsigned long values
12559 can fit into an integer. At this point, we know button_down_time
12560 <= event->timestamp, so the difference must be nonnegative, so
12561 there's no need to cast the result if double-click-time is
12562 nonnegative, as it should be; check that it's nonnegative, just in
12563 case. This bug is triggered when events are more than 2**31 ms
86db42d2 12564 apart (about 25 days). (Bug#8664)
8e55734a 12565
841f1b75 12566 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 12567 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 12568
3e26f69c
PE
12569 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
12570 that always fit in int. Use a sentinel instead of a counter, to
12571 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
12572 * frame.h (struct frame): Use int for menu_bar_items_used
12573 instead of EMACS_INT, since it always fits in int.
3e26f69c 12574
5cc152c0
PE
12575 * menu.c (grow_menu_items): Check for int overflow.
12576
d89eb65e
PE
12577 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
12578
5235bd3e
PE
12579 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
12580 Before, the code was not consistent. These values cannot exceed
12581 2**31 - 1 so there's no need to make them unsigned.
12582 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
12583 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
12584 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
12585 as modifiers.
12586 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
12587
bc827e23
PE
12588 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
12589 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
12590 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
12591 presumably because the widths might not match.
12592
78eb494e
PE
12593 * window.c (size_window): Avoid needless test at loop start.
12594
04f2d78b
CB
125952011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
12596
12597 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
12598
d2fc7e3d 125992011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
12600
12601 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
12602
d2fc7e3d 126032011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
12604
12605 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
12606 `width' to `bar_area_x' and `bar_area_width', respectively.
12607 (x_scroll_run): Take account of fringe background extension.
12608
04f2d78b
CB
12609 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
12610 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
12611 `bar_area_width', respectively.
12612 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
12613 background extension.
12614
79b70037
GM
126152011-05-10 Jim Meyering <meyering@redhat.com>
12616
12617 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
12618
2f142cc5
JB
126192011-05-10 Juanma Barranquero <lekktu@gmail.com>
12620
12621 * image.c (Finit_image_library): Return t for built-in image types,
12622 like pbm and xbm. (Bug#8640)
12623
57679c86
AS
126242011-05-09 Andreas Schwab <schwab@linux-m68k.org>
12625
12626 * w32menu.c (set_frame_menubar): Fix submenu allocation.
12627
888c9e86
EZ
126282011-05-07 Eli Zaretskii <eliz@gnu.org>
12629
b0512a1d
EZ
12630 * w32console.c (Fset_screen_color): Doc fix.
12631 (Fget_screen_color): New function.
12632 (syms_of_ntterm): Defsubr it.
12633
7285dc67
EZ
12634 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
12635 unlink the temporary file if Fcall_process didn't create it in the
12636 first place.
12637 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
12638 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
12639 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
12640 cue to call_process_cleanup not to close that handle.
12641
4d3fcc8e
BK
126422011-05-07 Ben Key <bkey76@gmail.com>
12643
12644 * makefile.w32-in: The bootstrap-temacs rule now makes use of
12645 one of two shell specific rules, either bootstrap-temacs-CMD or
12646 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
12647 to the previous implementation of the bootstrap-temacs rule.
12648 The bootstrap-temacs-CMD rule is similar to the previous
12649 implementation of the bootstrap-temacs rule except that it
12650 makes use of the ESC_CFLAGS variable instead of the CFLAGS
12651 variable.
12652
12653 These changes, along with some changes to nt/configure.bat,
12654 nt/gmake.defs, and nt/nmake.defs, are required to extend my
12655 earlier fix to add support for --cflags and --ldflags options
12656 that include quotes so that it works whether make uses cmd or
12657 sh as the shell.
12658
b4289b64
MA
126592011-05-06 Michael Albinus <michael.albinus@gmx.de>
12660
12661 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
12662 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
12663 is a constant.
12664 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
12665 a string. Handle both cases.
12666 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
12667 (Fdbus_register_method): Use Qinvalid_function.
12668
af4c0e28
JB
126692011-05-06 Juanma Barranquero <lekktu@gmail.com>
12670
12671 * makefile.w32-in: Update dependencies.
12672 (LISP_H): Add inttypes.h and stdin.h.
12673 (PROCESS_H): Add unistd.h.
12674
c51453d9
EZ
126752011-05-06 Eli Zaretskii <eliz@gnu.org>
12676
12677 * lread.c: Include limits.h (fixes the MS-Windows build broken by
12678 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
12679
8ff0ac3c 126802011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 12681
4c4b566b
PE
12682 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
12683
aab2b9b5
PE
12684 * term.c (vfatal): Remove stray call to va_end.
12685 It's not needed and the C Standard doesn't allow it here anyway.
12686
c378da0b
PE
12687 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
12688 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
12689
288b08c7
PE
12690 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
12691 bytes.
12692
e3601888
PE
12693 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
12694
db6c0e74
PE
12695 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
12696
dd5963ea
PE
12697 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
12698
88c9450f
PE
12699 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
12700
2f9442b8
PE
12701 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
12702
c032b5f8
PE
12703 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
12704 * charset.c (Fdefine_charset_internal): Don't initialize
12705 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 12706 32-bit int (Bug#8600).
a108c10b
PE
12707
12708 * lread.c (read_integer): Be more consistent with string-to-number.
12709 Use string_to_number to do the actual conversion; this avoids
12710 rounding errors and fixes some other screwups. Without this fix,
12711 for example, #x1fffffffffffffff was misread as -2305843009213693952.
12712 (digit_to_number): Move earlier, for benefit of read_integer.
12713 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 12714 not a digit in any supported base. (Bug#8602)
a108c10b 12715
ad5f9eea
PE
12716 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
12717
aec1708a
PE
12718 * dispnew.c (scrolling_window): Return 1 if we scrolled,
12719 to match comment at start of function. This also removes a
12720 GCC warning about overflow in a 32+64-bit port.
12721
47be4ab5
PE
12722 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
12723
371cac43
PE
12724 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
12725 Reported by Stefan Monnier in
12726 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
12727 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12728 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 12729
d01a7826
PE
12730 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
12731 (EMACS_UINTPTR): Likewise, with uintptr_t.
12732
7fd47d5c
PE
12733 * lisp.h: Prefer 64-bit EMACS_INT if available.
12734 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
12735 on 32-bit hosts that have 64-bit int, so that they can access
12736 large files.
122b0c86
PE
12737 However, temporarily disable this change unless the temporary
12738 symbol WIDE_EMACS_INT is defined.
7fd47d5c 12739
8727937b
PE
12740 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
12741
8ac068ac
PE
12742 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
12743 This removes an assumption that EMACS_INT and long are the same
12744 width as pointers. The assumption is true for Emacs porting targets
12745 now, but we want to make other targets possible.
12746 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
12747 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
12748 In the rest of the code, change types of integers that hold casted
12749 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
12750 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
12751 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
12752 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
12753 No need to cast type when ORing.
12754 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
12755 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
12756 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
12757 assume EMACS_INT is the same width as char *.
12758 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
12759 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
12760 Remove no-longer-needed casts.
12761 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
12762 (xg_tool_bar_help_callback, xg_make_tool_item):
12763 Use EMACS_INTPTR to hold an integer
12764 that will be cast to void *; this can avoid a GCC warning
12765 if EMACS_INT is not the same width as void *.
12766 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
12767 * xdisp.c (display_echo_area_1, resize_mini_window_1):
12768 (current_message_1, set_message_1):
12769 Use a local to convert to proper width without a cast.
12770 * xmenu.c (dialog_selection_callback): Likewise.
12771
ede49d71
PE
12772 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
12773 Also, don't assume VALBITS / RAND_BITS is less than 5,
12774 and don't rely on undefined behavior when shifting a 1 left into
12775 the sign bit.
12776 * lisp.h (get_random): Change signature to match.
12777
2f30ecd0
PE
12778 * lread.c (hash_string): Use size_t, not int, for hash computation.
12779 Normally we prefer signed values; but hashing is special, because
12780 it's better to use unsigned division on hash table sizes so that
12781 the remainder is nonnegative. Also, size_t is the natural width
12782 for hashing into memory. The previous code used 'int', which doesn't
12783 retain enough info to hash well into very large tables.
12784 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
12785
2a866e7b
PE
12786 * dbusbind.c: Don't possibly lose pointer info when converting.
12787 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12788 Use XPNTR rather than XHASH, so that the high-order bits of
12789 the pointer aren't lost when converting through void *.
12790
51639eac
PE
12791 * eval.c (Fautoload): Don't double-shift a pointer.
12792
92394119
PE
12793 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
12794
dbdb9a7c
JB
127952011-05-06 Juanma Barranquero <lekktu@gmail.com>
12796
12797 * gnutls.c (DEF_GNUTLS_FN):
12798 * image.c (DEF_IMGLIB_FN): Make function pointers static.
12799
db7a0b4f
AS
128002011-05-05 Andreas Schwab <schwab@linux-m68k.org>
12801
12802 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
12803 marker. (Bug#8610)
12804
cd394be1 128052011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
12806
12807 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
12808 New version that can reserve upto 2GB of heap space.
12809
f7ff1b0f 128102011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
12811
12812 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
12813
639c109b
TZ
128142011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
12815
12816 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
12817 `gnutls_certificate_set_x509_key_file'.
12818
d2127135
JB
128192011-05-05 Juanma Barranquero <lekktu@gmail.com>
12820
12821 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
12822 Update dependencies.
12823
e968f4f3
JB
128242011-05-04 Juanma Barranquero <lekktu@gmail.com>
12825
12826 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
12827 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
12828 Remove unused parameter `fildes'.
12829 * process.c (read_process_output, send_process): Don't pass it.
12830
84d358f0
JB
128312011-05-04 Juanma Barranquero <lekktu@gmail.com>
12832
12833 Fix previous change: the library cache is defined in w32.c.
12834 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
12835 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
12836
0898ca10
JB
128372011-05-04 Juanma Barranquero <lekktu@gmail.com>
12838
12839 Implement dynamic loading of GnuTLS on Windows.
12840
12841 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
12842 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
12843 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12844 Declare.
12845
12846 * gnutls.c (Qgnutls_dll): Define.
12847 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
12848 (gnutls_*): Declare function pointers.
12849 (init_gnutls_functions): New function to initialize function pointers.
12850 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
12851 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
12852 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12853 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
12854 (emacs_gnutls_write, emacs_gnutls_read)
12855 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
12856 (Fgnutls_available_p): New function.
12857 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
12858 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
12859 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
12860
12861 * image.c: Include w32.h.
12862 (Vimage_type_cache): Delete.
12863 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
12864 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
12865 (w32_delayed_load): Move to w32.c.
12866
12867 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
12868
12869 * w32.c (QCloaded_from, Vlibrary_cache): Define.
12870 (w32_delayed_load): Move from image.c. When loading a library, record
12871 its filename in the :loaded-from property of the library id.
12872 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
12873 Initialize and staticpro them.
12874 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
12875
12876 * process.c: Include lisp.h before w32.h, not after.
12877 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
12878 instead of gnutls_record_check_pending.
12879
12880 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
12881
ff4de4aa
TZ
128822011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
12883
12884 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
12885 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
12886 as passed in.
12887
abe95abb
JD
128882011-05-03 Jan Djärv <jan.h.d@swipnet.se>
12889
12890 * xterm.c (x_set_frame_alpha): Do not set property on anything
12891 else than FRAME_X_OUTER_WINDOW (Bug#8608).
12892
e16e55d4
JB
128932011-05-02 Juanma Barranquero <lekktu@gmail.com>
12894
12895 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
12896
bafcf6a5
JB
128972011-05-02 Juanma Barranquero <lekktu@gmail.com>
12898
12899 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
12900 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
12901 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
12902 (gnutls_global_initialized, Qgnutls_bootprop_priority)
12903 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
12904 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
12905 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
12906 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
12907 (Qgnutls_bootprop_callbacks_verify): Make static.
12908
e7a6747f
AS
129092011-05-01 Andreas Schwab <schwab@linux-m68k.org>
12910
19ed11ba
AS
12911 * callproc.c: Indentation fixup.
12912
e7a6747f 12913 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
12914 (wait_for_termination, interruptible_wait_for_termination):
12915 Move after wait_for_termination_1.
e7a6747f 12916
1ef14cb4
LMI
129172011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
12918
12919 * sysdep.c (interruptible_wait_for_termination): New function
12920 which is like wait_for_termination, but allows keyboard
12921 interruptions.
12922
12923 * callproc.c (Fcall_process): Add (:file "file") as an option for
12924 the STDOUT buffer.
12925 (Fcall_process_region): Ditto.
12926
330d880c
EZ
129272011-04-30 Eli Zaretskii <eliz@gnu.org>
12928
8db90b73
EZ
12929 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
12930 rather than `XVECTOR (FOO)->size'.
12931
330d880c
EZ
12932 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
12933 inttypes.h, as a gnulib replacement is used if it not available in
12934 system headers.
12935
15cbd324
EZ
129362011-04-21 Eli Zaretskii <eliz@gnu.org>
12937
12938 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
12939 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
12940 of MOST_POSITIVE_FIXNUM. (Bug#8528)
12941
12942 * coding.c (coding_alloc_by_realloc): Error out if destination
12943 will grow beyond MOST_POSITIVE_FIXNUM.
12944 (decode_coding_emacs_mule): Abort if there isn't enough place in
12945 charbuf for the composition carryover bytes. Reserve an extra
12946 space for up to 2 characters produced in a loop.
12947 (decode_coding_iso_2022): Abort if there isn't enough place in
12948 charbuf for the composition carryover bytes.
12949
129502011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 12951
ae940cca
EZ
12952 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
12953 aborting when %lld or %lll format is passed.
12954 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
12955 %llo or %llx format is passed. (Bug#8545)
12956
03ab8921
EZ
12957 * window.c (window_scroll_line_based): Use a marker instead of
12958 simple variables to record original value of point. (Bug#7952)
12959
afda1437
EZ
12960 * doprnt.c (doprnt): Fix the case where a multibyte sequence
12961 produced by %s or %c overflows available buffer space. (Bug#8545)
12962
f76dee0c
PE
129632011-04-28 Paul Eggert <eggert@cs.ucla.edu>
12964
12965 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 12966 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 12967
fdc5744d
JB
129682011-04-28 Juanma Barranquero <lekktu@gmail.com>
12969
12970 * w32.c (init_environment): Warn about defaulting HOME to C:\.
12971
638f053a
JB
129722011-04-28 Juanma Barranquero <lekktu@gmail.com>
12973
12974 * keyboard.c (Qdelayed_warnings_hook): Define.
12975 (command_loop_1): Run `delayed-warnings-hook'
12976 if Vdelayed_warnings_list is non-nil.
12977 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
12978 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
12979
d178f871
EZ
129802011-04-28 Eli Zaretskii <eliz@gnu.org>
12981
12982 * doprnt.c (doprnt): Don't return value smaller than the buffer
12983 size if the message was truncated. (Bug#8545).
12984
b124fd93
JB
129852011-04-28 Juanma Barranquero <lekktu@gmail.com>
12986
12987 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
12988 (Fx_window_property): #if-0 the whole functions, not just the bodies.
12989
e810457d
PE
129902011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12991
12992 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
12993
ea51cceb
JB
129942011-04-27 Juanma Barranquero <lekktu@gmail.com>
12995
12996 * makefile.w32-in: Update dependencies.
12997
94dcfacf
EZ
129982011-04-27 Eli Zaretskii <eliz@gnu.org>
12999
13000 Improve `doprnt' and its usage. (Bug#8545)
13001 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
13002 `format_end'. Remove support for %l as a conversion specifier.
13003 Don't use xrealloc. Improve diagnostics when the %l size modifier
13004 is used. Update the commentary.
13005
13006 * eval.c (verror): Simplify calculation of size_t.
13007
13008 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
13009 messages.
13010
f61f41d7
PE
130112011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
13012
13013 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
13014 change.
13015
96fb4434
PE
130162011-04-27 Paul Eggert <eggert@cs.ucla.edu>
13017
13018 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
13019 This makes this file independent of the recent pseudovector change.
13020
671875da 130212011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 13022
69e9b5a3
PE
13023 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
13024
b5f869a7 13025 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 13026 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 13027 Remove unused local.
c8926152 13028 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 13029
841a1577 13030 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
13031 GCC 4.6.0 optimizes based on type-based alias analysis.
13032 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
13033 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
13034 != &v->size, and therefore "v->size = 1; b->size = 2; return
13035 v->size;" must therefore return 1. This assumption is incorrect
13036 for Emacs, since it type-puns struct Lisp_Vector * with many other
13037 types. To fix this problem, this patch adds a new type struct
f904488f 13038 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
13039 and pseudovectors, and helps optimizing compilers not get fooled
13040 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
13041 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
13042 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
13043 the size member.
eab3844f
PE
13044 (XSETPVECTYPE): Rewrite in terms of new macro.
13045 (XSETPVECTYPESIZE): New macro, specifying both type and size.
13046 This is a bit clearer, and further avoids the possibility of
13047 undesirable aliasing.
13048 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 13049 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
13050 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
13051 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
13052 (ASIZE): Now uses header.size rather than size.
13053 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
13054 to avoid the hassle of writing XVECTOR (foo)->header.size.
13055 (struct vectorlike_header): New type.
eab3844f
PE
13056 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
13057 object, to help avoid aliasing.
13058 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
13059 (SUBRP): Likewise, since Lisp_Subr is a special case.
13060 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
13061 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
13062 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 13063 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
13064 changed to be "header.size" and "header.next".
13065 * buffer.h (struct buffer): Likewise.
13066 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
13067 * frame.h (struct frame): Likewise.
13068 * process.h (struct Lisp_Process): Likewise.
13069 * termhooks.h (struct terminal): Likewise.
13070 * window.c (struct save_window_data, struct saved_window): Likewise.
13071 * window.h (struct window): Likewise.
13072 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
13073 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
13074 * buffer.c (init_buffer_once): Likewise.
13075 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
13076 special case.
13077 * process.c (Fformat_network_address): Use local var for size,
13078 for brevity.
13079
0df1eac5
PE
13080 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
13081
847ab9d1 13082 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
13083 * data.c (atof): Remove decl; no longer used or needed.
13084 (digit_to_number): Move to lread.c.
13085 (Fstring_to_number): Use new string_to_number function, to be
13086 consistent with how the Lisp reader treats infinities and NaNs.
13087 Do not assume that floating-point numbers represent EMACS_INT
13088 without losing information; this is not true on most 64-bit hosts.
13089 Avoid double-rounding errors, by insisting on integers when
13090 parsing non-base-10 numbers, as the documentation specifies.
13091 * lisp.h (string_to_number): New decl, replacing ...
13092 (isfloat_string): Remove.
bc0a5c13 13093 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 13094 (read1): Do not accept +. and -. as integers; this
452f4150
PE
13095 appears to have been a coding error. Similarly, do not accept
13096 strings like +-1e0 as floating point numbers. Do not report
13097 overflow for integer overflows unless the base is not 10 which
13098 means we have no simple and reliable way to continue.
13099 Break out the floating-point parsing into a new
13100 function string_to_number, so that Fstring_to_number parses
13101 floating point numbers consistently with the Lisp reader.
04f2d78b 13102 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
13103 (E_CHAR, EXP_INT): Remove, replacing with ...
13104 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
13105 (string_to_number): New function, replacing isfloat_string.
13106 This function checks for valid syntax and produces the resulting
13107 Lisp float number too. Rework it so that string-to-number
bc0a5c13 13108 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
13109 so that overflow for non-base-10 numbers is reported only when
13110 there's no portable and simple way to convert to floating point.
452f4150 13111
67769ffc
PE
13112 * textprop.c (set_text_properties_1): Rewrite for clarity,
13113 and to avoid GCC warning about integer overflow.
13114
c20db43f
PE
13115 * intervals.h (struct interval): Use EMACS_INT for members
13116 where EMACS_UINT might cause problems. See
13117 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
13118 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
13119 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
13120 All uses changed.
37aa2f85
PE
13121 (offset_intervals): Tell GCC not to worry about length overflow
13122 when negating a negative length.
c20db43f 13123
2538aa2f
PE
13124 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
13125 (overrun_check_free): Likewise.
13126
f2d3008d
PE
13127 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
13128 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
13129 word size.
13130
ec8df744
PE
13131 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
13132 (gnutls_make_error): Rename local to avoid shadowing.
13133 (gnutls_emacs_global_deinit): ifdef out; not used.
13134 (Fgnutls_boot): Use const for pointer to readonly storage.
13135 Comment out unused local. Fix pointer signedness problems.
13136
640ee02d
PE
13137 * lread.c (openp): Don't stuff size_t into an 'int'.
13138 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
13139 about possible signed overflow.
13140
6048fb2a
PE
13141 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
13142 (GDK_KEY_g): Don't define if already defined.
13143 (xg_prepare_tooltip): Avoid pointer signedness problem.
13144 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
13145
fa3c87e1
PE
13146 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
13147 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
13148
2172544b
PE
13149 * xfns.c (Fx_window_property): Simplify a bit,
13150 to make a bit faster and to avoid GCC 4.6.0 warning.
13151 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
13152
9b821a21
PE
13153 * fns.c (internal_equal): Don't assume size_t fits in int.
13154
3c616cfa
PE
13155 * alloc.c (compact_small_strings): Tighten assertion a little.
13156
c2982e87
PE
13157 Replace pEd with more-general pI, and fix some printf arg casts.
13158 * lisp.h (pI): New macro, generalizing old pEd macro to other
13159 conversion specifiers. For example, use "...%"pI"d..." rather
13160 than "...%"pEd"...".
13161 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 13162 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
13163 * alloc.c (check_pure_size): Don't overflow by converting size to int.
13164 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
13165 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
13166 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
13167 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
13168 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
13169 64-bit hosts.
13170 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
13171 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
13172 * print.c (safe_debug_print, print_object): Likewise.
13173 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
13174 to int.
6f04d126
PE
13175 Use pI instead of if-then-else-abort. Use %p to avoid casts,
13176 avoiding the 0 flag, which is not portable.
c2982e87
PE
13177 * process.c (Fmake_network_process): Use pI to avoid cast.
13178 * region-cache.c (pp_cache): Likewise.
13179 * xdisp.c (decode_mode_spec): Likewise.
13180 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
13181 behavior on 64-bit hosts with printf arg.
6f04d126 13182 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
13183 (x_stop_queuing_selection_requests): Likewise.
13184 (x_get_window_property): Don't truncate byte count to an 'int'
13185 when tracing.
0b432f21 13186
5e073ec7
PE
13187 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
13188 here, since it parses constructs like leading '-' and spaces,
13189 which are not wanted; and it overflows with large numbers.
13190 Instead, simply match F[0-9]+, which is what is wanted anyway.
13191
36372bf9
PE
13192 * alloc.c: Remove unportable assumptions about struct layout.
13193 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
13194 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
13195 (allocate_vectorlike, make_pure_vector): Use the new macros,
13196 plus offsetof, to remove unportable assumptions about struct layout.
13197 These assumptions hold on all porting targets that I know of, but
13198 they are not guaranteed, they're easy to remove, and removing them
13199 makes further changes easier.
13200
0b432f21
PE
13201 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
13202 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
13203 (string_overrun_cookie): Now const. Use initializers that
13204 don't formally overflow signed char, to avoid warnings.
000098c1
PE
13205 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
13206 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
13207 (allocate_buffer): Don't assume sizeof (struct buffer) is a
13208 multiple of sizeof (EMACS_INT); it need not be, if
13209 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 13210 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 13211
895009e1
JB
132122011-04-26 Juanma Barranquero <lekktu@gmail.com>
13213
13214 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
13215
6a7a1b0b
TZ
132162011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
13217
13218 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 13219 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
13220 Reported by Paul Eggert <eggert@cs.ucla.edu>.
13221
841a1577 132222011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
13223
13224 * lisp.h (Qdebug): List symbol.
895009e1 13225 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
13226 * keyboard.c (debug-on-event): New variable.
13227 (handle_user_signal): Break into debugger when debug-on-event
13228 matches the current signal symbol.
13229
f2d3ba6f
DN
132302011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
13231
13232 * alloc.c (check_sblock, check_string_bytes)
13233 (check_string_free_list): Convert to standard C.
13234
42ce4c63
TZ
132352011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
13236
13237 * w32.c (emacs_gnutls_push): Fix typo.
13238
825cd63c
EZ
132392011-04-25 Eli Zaretskii <eliz@gnu.org>
13240
fb11d64d
EZ
13241 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
13242 "cast to pointer from integer of different size".
13243
825cd63c
EZ
13244 Improve doprnt and its use in verror. (Bug#8545)
13245 * doprnt.c (doprnt): Document the set of format control sequences
13246 supported by the function. Use SAFE_ALLOCA instead of always
13247 using `alloca'.
13248
13249 * eval.c (verror): Don't limit the buffer size at size_max-1, that
13250 is one byte too soon. Don't use xrealloc; instead xfree and
13251 xmalloc anew.
13252
e061a11b
TZ
132532011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
13254
13255 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
13256 callbacks stage.
13257
13258 * gnutls.c: Renamed global_initialized to
13259 gnutls_global_initialized. Added internals for the
13260 :verify-hostname-error, :verify-error, and :verify-flags
13261 parameters of `gnutls-boot' and documented those parameters in the
13262 docstring. Start callback support.
9173deec
JB
13263 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
13264 unless a fatal error occurred. Call gnutls_alert_send_appropriate
13265 on error. Return error code.
e061a11b
TZ
13266 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
13267 (emacs_gnutls_read): Likewise.
13268 (Fgnutls_boot): Return handshake error code.
13269 (emacs_gnutls_handle_error): New function.
13270 (wsaerror_to_errno): Likewise.
13271
13272 * w32.h (emacs_gnutls_pull): Add prototype.
13273 (emacs_gnutls_push): Likewise.
13274
13275 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
13276 (emacs_gnutls_push): Likewise.
13277
132782011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
13279
13280 * process.c (wait_reading_process_output): Check if GnuTLS
13281 buffered some data internally if no FDs are set for TLS
13282 connections.
13283
13284 * makefile.w32-in (OBJ2): Add gnutls.$(O).
13285 (LIBS): Link to USER_LIBS.
13286 ($(BLD)/gnutls.$(0)): New target.
13287
fa6996bc
EZ
132882011-04-24 Eli Zaretskii <eliz@gnu.org>
13289
eb35682e
EZ
13290 * xdisp.c (handle_single_display_spec): Rename the
13291 display_replaced_before_p argument into display_replaced_p, to
13292 make it consistent with the commentary. Fix typos in the
13293 commentary.
13294
e2ad650c
EZ
13295 * textprop.c (syms_of_textprop): Remove dead code.
13296 (copy_text_properties): Delete obsolete commentary about an
13297 interface that was deleted long ago. Fix typos in the description
13298 of arguments.
13299
1b2de274
EZ
13300 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
13301 to changes in oldXMenu/XMenu.h from 2011-04-16.
13302 <menu_help_message, prev_menu_help_message>: Constify.
13303 (IT_menu_make_room): menu->help_text is now `const char **';
13304 adjust.
13305
13306 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
13307 to changes in oldXMenu/XMenu.h from 2011-04-16.
13308 (struct XMenu): Declare `help_text' `const char **'.
13309
13310 * xfaces.c <Qunspecified>: Make extern again.
13311
13312 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 13313 required by POSIX.
1b2de274 13314
762b15be
EZ
13315 * doc.c (get_doc_string): Improve the format passed to `error'.
13316
13317 * doprnt.c (doprnt): Improve commentary.
13318
13319 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
13320
13321 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
13322 them with etags.
13323
f1052e5d
EZ
13324 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
13325 changes in globals.h immediately force recompilation.
762b15be
EZ
13326 (TAGS): Depend on $(CURDIR)/m/intel386.h and
13327 $(CURDIR)/s/ms-w32.h.
13328 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 13329
fa6996bc
EZ
13330 * character.c (Fchar_direction): Function deleted.
13331 (syms_of_character): Don't defsubr it.
13332 <char-direction-table>: Deleted.
13333
e6c3da20
EZ
133342011-04-23 Eli Zaretskii <eliz@gnu.org>
13335
13336 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
13337 * doprnt.c: Include limits.h.
13338 (SIZE_MAX): New macro.
04f2d78b
CB
13339 (doprnt): Return a size_t value. 2nd arg is now size_t.
13340 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
13341 Improve overflow protection. Support `l' modifier for integer
13342 conversions. Support %l conversion. Don't assume an EMACS_INT
13343 argument for integer conversions and for %c.
13344
13345 * lisp.h (doprnt): Restore prototype.
13346
13347 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
13348 $(SRC)/character.h.
13349
13350 * Makefile.in (base_obj): Add back doprnt.o.
13351
13352 * deps.mk (doprnt.o): Add back prerequisites.
13353 (callint.o): Depend on character.h.
13354
13355 * eval.c (internal_lisp_condition_case): Include the handler
13356 representation in the error message.
13357 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
13358 when breaking from the loop.
13359
13360 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
13361
13362 * callint.c (Fcall_interactively): When displaying error message
13363 about invalid control letter, pass the character's codepoint, not
13364 a pointer to its multibyte form. Improve display of the character
13365 in octal and display also its hex code.
13366
13367 * character.c (char_string): Use %x to display the (unsigned)
13368 codepoint of an invalid character, to avoid displaying a bogus
13369 negative value.
13370
13371 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
13372 `error', not SYMBOL_NAME itself.
13373
13374 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
13375 character arguments to `error'.
13376
13377 * charset.c (check_iso_charset_parameter): Fix incorrect argument
13378 to `error' in error message about FINAL_CHAR argument. Make sure
13379 FINAL_CHAR is a character, and use %c when it is passed as
13380 argument to `error'.
13381
4ffd0d6b 133822011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
13383
13384 * s/ms-w32.h (localtime): Redirect to sys_localtime.
13385
13386 * w32.c: Include <time.h>.
13387 (sys_localtime): New function.
13388
4ffd0d6b 133892011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
13390
13391 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
13392
4ffd0d6b 13393 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 13394
4ffd0d6b 133952011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 13396
4ffd0d6b
GM
13397 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
13398 zombies (Bug#8467).
aac0c6e3 13399
04c56954
EZ
134002011-04-19 Eli Zaretskii <eliz@gnu.org>
13401
13402 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
13403 gl_state.e_property when gl_state.object is Qt.
13404
13405 * insdel.c (make_gap_larger): Remove limitation of buffer size
13406 to <= INT_MAX.
13407
16a43933
CY
134082011-04-18 Chong Yidong <cyd@stupidchicken.com>
13409
13410 * xdisp.c (lookup_glyphless_char_display)
13411 (produce_glyphless_glyph): Handle cons cell entry in
13412 glyphless-char-display.
13413 (Vglyphless_char_display): Document it.
13414
13415 * term.c (produce_glyphless_glyph): Handle cons cell entry in
13416 glyphless-char-display.
13417
4581706e
CY
134182011-04-17 Chong Yidong <cyd@stupidchicken.com>
13419
13420 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
13421
13422 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
13423
13424 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
13425 definition for no-X builds.
13426
4887c6e2 134272011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 13428
fd35b6f9
PE
13429 Static checks with GCC 4.6.0 and non-default toolkits.
13430
5c1ccb01
PE
13431 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
13432
006c5daa
PE
13433 * process.c (keyboard_bit_set): Define only if SIGIO.
13434 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
13435 (send_process): Repair possible setjmp clobbering.
13436
efc736d3
PE
13437 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
13438
4e2fe2e6
PE
13439 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
13440
f97334a2
PE
13441 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
13442
4e75f29d
PE
13443 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
13444 Define only if needed.
13445
90efadd1
PE
13446 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
13447 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 13448 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 13449
3c647824
PE
13450 * dispextern.h (struct redisplay_interface): Rename param
13451 to avoid shadowing.
e264f262 13452 * termhooks.h (struct terminal): Likewise.
761383f4 13453 * xterm.c (xembed_send_message): Likewise.
3c647824 13454
b58c5c4a
PE
13455 * insdel.c (make_gap_smaller): Define only if
13456 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
13457
cad59032
PE
13458 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
13459 it.
13460
c339dc2e
PE
13461 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
13462 so that we aren't warned about unused symbols.
13463
91a3e27b
PE
13464 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
13465
399c71d3 13466 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 13467
8ffc96f5
PE
13468 * xfns.c (x_real_positions): Mark locals as initialized.
13469
eef9bc79
PE
13470 * xmenu.c (xmenu_show): Don't use uninitialized vars.
13471
098db9dd
PE
13472 * xterm.c: Fix problems found by static analysis with other toolkits.
13473 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
13474 (x_dispatch_event): Declare static if USE_GTK, and
13475 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 13476 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 13477 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
13478 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
13479 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 13480
eb18f6cc
PE
13481 * xmenu.c (menu_help_callback): Pointer type fixes.
13482 Use const pointers when pointing at readonly data. Avoid pointer
13483 signedness clashes.
13484 (FALSE): Remove unused macro.
13485 (update_frame_menubar): Remove unused decl.
13486
1fe72bf8
PE
13487 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
13488
60d9e1db
PE
13489 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
13490 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
13491 (single_menu_item): Rename local to avoid shadowing.
13492
39261c26
PE
13493 * keyboard.c (make_lispy_event): Remove unused local var.
13494
018c5e19
PE
13495 * frame.c, frame.h (x_get_resource_string): Bring this back, but
13496 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
13497
63d2b86e
PE
13498 * bitmaps: Change bitmaps from unsigned char back to the X11
13499 compatible char. Avoid the old compiler warnings about
13500 out-of-range initializers by using, for example, '\xab' rather
13501 than 0xab.
13502
aefd87e1
PE
13503 * xgselect.c (xgselect_initialize): Check vs interface
13504 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
13505
bf501fb9
PE
13506 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
13507
e9829fdf
PE
13508 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
13509 to read-only memory.
13510
1086c095
PE
13511 * fns.c (vector): Remove; this old hack is no longer needed.
13512
2baccd04 13513 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 13514 Remove unused var.
dde42981 13515 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 13516
72391843 13517 * xrdb.c (x_load_resources): Omit unused local.
3565b346 13518
436c16df 13519 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 13520 (x_window): Rename locals to avoid shadowing.
dc5ddd85 13521 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 13522
92bb796d 13523 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 13524 (x_term_init): Remove local to avoid shadowing.
92bb796d 13525
764430a3 13526 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
13527
13528 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
13529 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
13530
d1dfb56c
EZ
135312011-04-16 Eli Zaretskii <eliz@gnu.org>
13532
c4354cb4
EZ
13533 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
13534
d1dfb56c
EZ
13535 Fix regex.c, syntax.c and friends for buffers > 2GB.
13536 * syntax.h (struct gl_state_s): Declare character position members
13537 EMACS_INT.
13538
13539 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
13540
04f2d78b
CB
13541 * textprop.c (verify_interval_modification, interval_of):
13542 Declare arguments EMACS_INT.
d1dfb56c
EZ
13543
13544 * intervals.c (adjust_intervals_for_insertion): Declare arguments
13545 EMACS_INT.
13546
13547 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
13548
13549 * indent.c (Fvertical_motion): Local variable it_start is now
13550 EMACS_INT.
13551
13552 * regex.c (re_match, re_match_2, re_match_2_internal)
13553 (bcmp_translate, regcomp, regexec, print_double_string)
13554 (group_in_compile_stack, re_search, re_search_2, regex_compile)
13555 (re_compile_pattern, re_exec): Declare arguments and local
13556 variables `size_t' and `ssize_t' and return values `regoff_t', as
13557 appropriate.
13558 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
13559 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
13560 <compile_stack_type>: `size' and `avail' are now `size_t'.
13561
13562 * regex.h <regoff_t>: Use ssize_t, not int.
13563 (re_search, re_search_2, re_match, re_match_2): Arguments that
13564 specify buffer/string position and length are now ssize_t and
13565 size_t. Return type is regoff_t.
13566
613052cd
BK
135672011-04-16 Ben Key <bkey76@gmail.com>
13568
13569 * nsfont.m: Fixed bugs in ns_get_family and
13570 ns_descriptor_to_entity that were caused by using free to
13571 deallocate memory blocks that were allocated by xmalloc (via
13572 xstrdup). This caused Emacs to crash when compiled with
13573 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
13574 --enable-checking=xmallocoverrun). xfree is now used to
13575 deallocate these memory blocks.
13576
4170f62f 135772011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 13578
71b41406
PE
13579 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
13580
9587a89d
PE
13581 emacs_write: Accept and return EMACS_INT for sizes.
13582 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
13583 et seq.
13584 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
13585 Accept and return EMACS_INT.
13586 (emacs_gnutls_write): Return the number of bytes written on
13587 partial writes.
13588 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
13589 (emacs_read, emacs_write): Remove check for negative size, as the
13590 Emacs source code has been audited now.
9587a89d
PE
13591 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
13592 (emacs_read, emacs_write): Use it.
273a5f82
PE
13593 * process.c (send_process): Adjust to the new signatures of
13594 emacs_write and emacs_gnutls_write. Do not attempt to store
13595 a byte offset into an 'int'; it might overflow.
9587a89d 13596 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 13597
3e047f51
PE
13598 * sound.c: Don't assume sizes fit in 'int'.
13599 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 13600 Return EMACS_INT, not int.
3e047f51 13601 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
13602 Accept EMACS_INT, not int.
13603 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
13604 record read return values.
13605
cc39a9db
BK
136062011-04-15 Ben Key <bkey76@gmail.com>
13607
c9d0ec6d
JB
13608 * keyboard.c (Qundefined): Don't declare static since it is used
13609 in nsfns.m.
13610 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
13611 static since they are used in nsfont.m.
cc39a9db 13612
6c60eb9f
SM
136132011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
13614
13615 * process.c (Qprocessp): Don't declare static.
13616 * lisp.h (Qprocessp): Declare again.
13617
7990b61a
JB
136182011-04-15 Juanma Barranquero <lekktu@gmail.com>
13619
13620 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
13621
5d4cb038
PE
136222011-04-14 Paul Eggert <eggert@cs.ucla.edu>
13623
8bd7b830 13624 Improve C-level modularity by making more things 'static'.
cd64ea1d 13625
e3b27b31
PE
13626 Don't publish debugger-only interfaces to other modules.
13627 * lisp.h (safe_debug_print, debug_output_compilation_hack):
13628 (verify_bytepos, count_markers): Move decls to the only modules
13629 that need them.
13630 * region-cache.h (pp_cache): Likewise.
13631 * window.h (check_all_windows): Likewise.
13632 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
13633
5d4cb038
PE
13634 * sysdep.c (croak): Now static, if
13635 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
13636 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
13637
13638 * alloc.c (refill_memory_reserve): Now static if
13639 !defined REL_ALLOC || defined SYSTEM_MALLOC.
13640 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 13641
e87b6180
PE
13642 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
13643 Define only if USE_LUCID.
13644
ac64929e
PE
13645 * xrdb.c (x_customization_string, x_rm_string): Now static.
13646
6f37259d
PE
13647 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
13648 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
13649
1683e3ab
PE
13650 * xdisp.c (draw_row_with_mouse_face): Now static.
13651 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
13652
de9c2632
PE
13653 * window.h (check_all_windows): Mark externally visible.
13654
2b96acb7
PE
13655 * window.c (window_deletion_count): Now static.
13656
13657 * undo.c: Make symbols static if they're not exported.
13658 (last_undo_buffer, last_boundary_position, pending_boundary):
13659 Now static.
13660
50436f33
PE
13661 * textprop.c (interval_insert_behind_hooks): Now static.
13662 (interval_insert_in_front_hooks): Likewise.
13663
64520e5c
PE
13664 * term.c: Make symbols static if they're not exported.
13665 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
13666 (max_frame_lines, tty_set_terminal_modes):
13667 (tty_reset_terminal_modes, tty_turn_off_highlight):
13668 (get_tty_terminal): Now static.
13669 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
13670 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 13671 HAVE_WINDOW_SYSTEM.
64520e5c
PE
13672 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
13673 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
13674
1fa53021
PE
13675 * sysdep.c: Make symbols static if they're not exported.
13676 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
13677 Now static.
13678 (sigprocmask_set, full_mask): Remove; unused.
13679 (wait_debugging): Mark as visible.
13680 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
13681 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
13682
d4b43b22
PE
13683 * syntax.c (syntax_temp): Define only if !__GNUC__.
13684
b7c513d0
PE
13685 * sound.c (current_sound_device, current_sound): Now static.
13686
989b29ad
PE
13687 * search.c (searchbufs, searchbuf_head): Now static.
13688
13a55a78
PE
13689 * scroll.c (scroll_cost): Remove; unused.
13690 * dispextern.h (scroll_cost): Remove decl.
13691
de68a1fc
PE
13692 * region-cache.h (pp_cache): Mark as externally visible.
13693
40ccffa6
PE
13694 * process.c: Make symbols static if they're not exported.
13695 (process_tick, update_tick, create_process, chan_process):
13696 (Vprocess_alist, proc_buffered_char, datagram_access):
13697 (fd_callback_data, send_process_frame, process_sent_to): Now static.
13698 (deactivate_process): Mark defn as static, as well as decl.
13699 * lisp.h (create_process): Remove decl.
13700 * process.h (chan_process, Vprocess_alist): Remove decls.
13701
ad64fc97
PE
13702 * print.c: Make symbols static if they're not exported.
13703 (print_depth, new_backquote_output, being_printed, print_buffer):
13704 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
13705 (print_interval, print_number_index, initial_stderr_stream):
13706 Now static.
13707 * lisp.h (Fprinc): Remove decl.
13708 (debug_output_compilation_hack): Mark as externally visible.
13709
adddb265
PE
13710 * sysdep.c (croak): Move decl from here to syssignal.h.
13711 * syssignal.h (croak): Put it here, so the API can be checked when
13712 'croak' is called from dissociate_if_controlling_tty.
13713
1717ede2
PE
13714 * minibuf.c: Make symbols static if they're not exported.
13715 (minibuf_save_list, choose_minibuf_frame): Now static.
13716 * lisp.h (choose_minibuf_frame): Remove decl.
13717
fa5fb2bc
PE
13718 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
13719
1e3890d1
PE
13720 * lread.c: Make symbols static if they're not exported.
13721 (read_objects, initial_obarray, oblookup_last_bucket_number):
13722 Now static.
13723 (make_symbol): Remove; unused.
13724 * lisp.h (initial_obarray, make_symbol): Remove decls.
13725
8a1414fa
PE
13726 * keyboard.c: Make symbols static if they're not exported.
13727 (single_kboard, recent_keys_index, total_keys, recent_keys):
13728 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
13729 (this_single_command_key_start, echoing, last_auto_save):
13730 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
13731 (command_loop, echo_now, keyboard_init_hook, help_char_p):
13732 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
13733 (Vlispy_mouse_stem, double_click_count):
13734 Now static.
13735 (force_auto_save_soon): Define only if SIGDANGER.
13736 (ignore_mouse_drag_p): Now static if
13737 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
13738 (print_help): Remove; unused.
13739 (stop_character, last_timer_event): Mark as externally visible.
13740 * keyboard.h (ignore_mouse_drag_p): Declare only if
13741 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
13742 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
13743 * lisp.h (echoing): Remove decl.
13744 (force_auto_save_soon): Declare only if SIGDANGER.
13745 * xdisp.c (redisplay_window): Simplify code, to make it more
13746 obvious that ignore_mouse_drag_p is not accessed if !defined
13747 USE_GTK && !defined HAVE_NS.
13748
93ea6e8f
PE
13749 * intervals.c: Make symbols static if they're not exported.
13750 (merge_properties_sticky, merge_interval_right, delete_interval):
13751 Now static.
13752 * intervals.h (merge_interval_right, delete_interval): Remove decls.
13753
77382fcc
PE
13754 * insdel.c: Make symbols static if they're not exported.
13755 However, leave prepare_to_modify_buffer alone. It's never
13756 called from outside this function, but that appears to be a bug.
13757 (combine_after_change_list, combine_after_change_buffer):
4889fc82 13758 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
13759 (adjust_after_replace_noundo): Remove; unused.
13760 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 13761 (signal_before_change): Remove decls.
77382fcc 13762
9306c32e
PE
13763 * indent.c (val_compute_motion, val_vmotion): Now static.
13764
cd44d2eb
PE
13765 * image.c: Make symbols static if they're not exported.
13766 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
13767 if USE_GTK.
13768 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
13769 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
13770
ad9a7a06
PE
13771 * fringe.c (standard_bitmaps): Now static.
13772 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
13773
81626931
PE
13774 * frame.c: Make symbols static if they're not exported.
13775 (x_report_frame_params, make_terminal_frame): Now static.
13776 (get_frame_param): Now static, unless HAVE_NS.
13777 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
13778 (x_get_resource_string): Remove; not used.
13779 * frame.h (make_terminal_frame, x_report_frame_params):
13780 (x_get_resource_string); Remove decls.
13781 (x_fullscreen_adjust): Declare only if WINDOWSNT.
13782 * lisp.h (get_frame_param): Declare only if HAVE_NS.
13783
239f9db9
PE
13784 * font.c, fontset.c: Make symbols static if they're not exported.
13785 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
13786 (FACE_SUITABLE_FOR_CHAR_P): Use it.
13787 * font.c (font_close_object): Now static.
13788 * font.h (font_close_object): Remove.
13789 * fontset.c (FONTSET_OBJLIST): Remove.
13790 (free_realized_fontset) #if-0 the body, which does nothing.
13791 (face_suitable_for_char_p): #if-0, as it's never called.
13792 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
13793 * xfaces.c (face_at_string_position):
13794 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
13795 since 0 is always ASCII.
13796
dfcf3579
PE
13797 * fns.c (weak_hash_tables): Now static.
13798
5045092b
PE
13799 * fileio.c: Make symbols static if they're not exported.
13800 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
13801 (Vwrite_region_annotation_buffers): Now static.
13802
57a96f5c
PE
13803 * eval.c: Make symbols static if they're not exported.
13804 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
13805 * lisp.h (backtrace_list): Remove decl.
13806
35f08c38
PE
13807 * emacs.c: Make symbols static if they're not exported.
13808 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
13809 (fatal_error_code, fatal_error_signal_hook, standard_args):
13810 Now static.
13811 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
13812 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
13813 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
13814 * lisp.h (fatal_error_signal_hook): Remove decl.
13815 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
13816
f44bd759
PE
13817 * editfns.c: Move a (normally-unused) function to its only use.
13818 * editfns.c, lisp.h (get_operating_system_release): Remove.
13819 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
13820 worth the hassle of breaking this out.
13821
b532497d
PE
13822 * xterm.c: Make symbols static if they're not exported.
13823 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
13824 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
13825 (x_destroy_window, x_delete_display):
13826 Now static.
13827 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
13828 (x_mouse_leave): Remove; unused.
13829 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
13830 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
13831 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
13832 Remove decls.
13833 (x_mouse_leave): Declare only if WINDOWSNT.
13834 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
13835 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
13836 USE_X_TOOLKIT.
13837
1675728f
PE
13838 * ftxfont.c: Make symbols static if they're not exported.
13839 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
13840 HAVE_FREETYPE.
13841 * font.h (ftxfont_driver): Likewise.
13842
e4cebfca
PE
13843 * xfns.c: Make symbols static if they're not exported.
13844 (x_last_font_name, x_display_info_for_name):
13845 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
13846 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
13847 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
13848 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
13849 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
13850 (last_show_tip_args): Now static.
13851 (xic_defaut_fontset, xic_create_fontsetname): Define only if
13852 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
13853 (x_screen_planes): Remove; unused.
13854 * dispextern.h (x_screen_planes): Remove decl.
13855
5bf46f05
PE
13856 * dispnew.c: Make symbols static if they're not exported.
13857 * dispextern.h (redraw_garbaged_frames, scrolling):
13858 (increment_row_positions): Remove.
13859 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
13860 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
13861 Now static.
13862 (redraw_garbaged_frames): Remove; unused.
13863
435f4c28
PE
13864 * xfaces.c: Make symbols static if they're not exported.
13865 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
13866 Remove decls.
13867 * xterm.h (defined_color): Remove decls.
13868 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
13869 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
13870 (menu_face_changed_default, defined_color, free_realized_face):
13871 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
13872 (ascii_face_of_lisp_face): Remove; unused.
13873
8524aef3
PE
13874 * xdisp.c: Make symbols static if they're not exported.
13875 * dispextern.h (scratch_glyph_row, window_box_edges):
13876 (glyph_to_pixel_coords, set_cursor_from_row):
13877 (get_next_display_element, set_iterator_to_next):
13878 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
13879 (show_mouse_face): Remove decls
13880 * frame.h (message_buf_print): Likewise.
13881 * lisp.h (pop_message, set_message, check_point_in_composition):
13882 Likewise.
13883 * xterm.h (set_vertical_scroll_bar): Likewise.
13884 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
13885 (message_buf_print, scratch_glyph_row, displayed_buffer):
13886 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
13887 (get_next_display_element, show_mouse_face, window_box_edges):
13888 (frame_to_window_pixel_xy, check_point_in_composition):
13889 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
13890 (glyph_to_pixel_coords): Remove; unused.
13891
16390cd2
PE
13892 * dired.c (file_name_completion): Now static.
13893
13894 * dbusbind.c (xd_in_read_queued_messages): Now static.
13895
a25f4dfa
PE
13896 * lisp.h (circular_list_error, FOREACH): Remove; unused.
13897 * data.c (circular_list_error): Remove.
13898
14a9c8df
PE
13899 * commands.h (last_point_position, last_point_position_buffer):
13900 (last_point_position_window): Remove decls.
13901 * keyboard.c: Make these variables static.
13902
04f2d78b
CB
13903 * coding.h (coding, code_convert_region, encode_coding_gap):
13904 Remove decls.
74ab6df5
PE
13905 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
13906 (iso_code_class, detect_coding, code_convert_region): Now static.
13907 (encode_coding_gap): Remove; unused.
13908
38dfbee1
PE
13909 * chartab.c (chartab_chars, chartab_bits): Now static.
13910
a2cb4e63
PE
13911 * charset.h (charset_iso_8859_1): Remove decl.
13912 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
13913 Now static.
13914
127198fd
PE
13915 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
13916 * ccl.c (Vccl_program_table): Now static.
13917 (check_ccl_update): Remove; unused.
13918
d85b608f
PE
13919 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
13920 * category.h: ... from here.
13921 * category.c (check_category_table, set_category_set): Now static.
13922
31cd66f3
PE
13923 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
13924 * lisp.h: Remove these decls.
13925
c358e587
PE
13926 * buffer.c (buffer_count): Remove unused var.
13927
e78aecca
PE
13928 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
13929 so that it's not optimized away.
13930 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
13931 * dispextern.h (bidi_dump_cached_states): Remove, since it's
13932 exported only to the debugger.
13933
e192d7d3 13934 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 13935 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 13936
92470028
PE
13937 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
13938 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
13939 was inaccessible from Lisp.
13940 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
13941 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
13942
244ed907
PE
13943 alloc.c: Import and export fewer symbols, and remove unused items.
13944 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
13945 is defined.
13946 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
13947 it's not optimized away by whole-program optimization.
13948 (message_enable_multibyte, free_misc): Remove.
13949 (catchlist, handlerlist, mark_backtrace):
13950 Declare only if BYTE_MARK_STACK.
13951 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
13952 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
13953 (message_enable_multibyte): Remove decl.
13954 (free_misc, interval_free_list, float_block, float_block_index):
13955 (n_float_blocks, float_free_list, cons_block, cons_block_index):
13956 (cons_free_list, last_marked_index):
13957 Now static.
13958 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
13959 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
13960 (mark_backtrace): Define only if BYTE_MARK_STACK.
13961 * xdisp.c (message_enable_multibyte): Now static.
13962
61c2b50e 13963 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
13964 This makes it easier for human readers (and static analyzers)
13965 to see whether these variables are used from other modules.
13966 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
13967 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
13968 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
13969 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
13970 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
13971 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
13972 * xmenu.c, xselect.c:
13973 Declare Q* vars static if they are not used in other modules.
13974 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
13975 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
13976 Remove decls of unexported vars.
13977 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
13978
95c82688
PE
13979 * lisp.h (DEFINE_FUNC): Make sname 'static'.
13980
16a97296
PE
13981 Make Emacs functions such as Fatom 'static' by default.
13982 This makes it easier for human readers (and static analyzers)
13983 to see whether these functions can be called from other modules.
13984 DEFUN now defines a static function. To make the function external
13985 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
13986 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
13987 (Finit_image_library):
16a97296
PE
13988 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
13989 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
13990 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
13991 Remove decls, since these functions are now static.
13992 (Funintern, Fget_internal_run_time): New decls, since these functions
13993 were already external.
95c82688 13994
16a97296
PE
13995 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
13996 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
13997 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
13998 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
13999 * keyboard.c, keymap.c, lread.c:
14000 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
14001 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
14002 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
14003 Mark functions with DEFUE instead of DEFUN,
14004 if they are used in other modules.
14005 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
14006 decls for now-static functions.
14007 * buffer.h (Fdelete_overlay): Remove decl.
14008 * callproc.c (Fgetenv_internal): Mark as internal.
14009 * composite.c (Fremove_list_of_text_properties): Remove decl.
14010 (Fcomposition_get_gstring): New forward static decl.
14011 * composite.h (Fcomposite_get_gstring): Remove decl.
14012 * dired.c (Ffile_attributes): New forward static decl.
14013 * doc.c (Fdocumntation_property): New forward static decl.
14014 * eval.c (Ffetch_bytecode): New forward static decl.
14015 (Funintern): Remove extern decl; now in .h file where it belongs.
14016 * fileio.c (Fmake_symbolic_link): New forward static decl.
14017 * image.c (Finit_image_library): New forward static decl.
14018 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
14019 * intervals.h (Fprevious_property_change):
14020 (Fremove_list_of_text_properties): Remove decls.
14021 * keyboard.c (Fthis_command_keys): Remove decl.
14022 (Fcommand_execute): New forward static decl.
14023 * keymap.c (Flookup_key): New forward static decl.
14024 (Fcopy_keymap): Now static.
14025 * keymap.h (Flookup_key): Remove decl.
14026 * process.c (Fget_process): New forward static decl.
14027 (Fprocess_datagram_address): Mark as internal.
14028 * syntax.c (Fsyntax_table_p): New forward static decl.
14029 (skip_chars): Remove duplicate decl.
14030 * textprop.c (Fprevious_property_change): New forward static decl.
14031 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
14032 Now internal.
14033 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
14034 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
14035
785bbd42
PE
14036 * editfns.c (Fformat): Remove unreachable code.
14037
8b913b57
AS
140382011-04-14 Andreas Schwab <schwab@linux-m68k.org>
14039
14040 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
14041 change. (Bug#8496)
14042
a6744a35
EZ
140432011-04-13 Eli Zaretskii <eliz@gnu.org>
14044
14045 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
14046 when at ZV. (Bug#8487)
14047
e7974947
AS
140482011-04-12 Andreas Schwab <schwab@linux-m68k.org>
14049
baad03f0
AS
14050 * charset.c (Fclear_charset_maps): Use xfree instead of free.
14051 (Bug#8437)
14052 * keyboard.c (parse_tool_bar_item): Likewise.
14053 * sound.c (sound_cleanup, alsa_close): Likewise.
14054 * termcap.c (tgetent): Likewise.
14055 * xfns.c (x_default_font_parameter): Likewise.
14056 * xsettings.c (read_and_apply_settings): Likewise.
14057
e7974947
AS
14058 * alloc.c (overrun_check_malloc, overrun_check_realloc)
14059 (overrun_check_free): Protoize.
14060
28272684
PE
140612011-04-12 Paul Eggert <eggert@cs.ucla.edu>
14062
14063 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
14064 since callers should never pass a negative size.
14065 Change the signature to match that of plain 'read' and 'write'; see
14066 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
14067 * lisp.h: Update prototypes of emacs_write and emacs_read.
14068
11997c76
EZ
140692011-04-11 Eli Zaretskii <eliz@gnu.org>
14070
14071 * xdisp.c (redisplay_window): Don't try to determine the character
14072 position of the scroll margin if the window start point w->startp
e896f03c 14073 is outside the buffer's accessible region. (Bug#8468)
11997c76 14074
8a2cbd72
EZ
140752011-04-10 Eli Zaretskii <eliz@gnu.org>
14076
14077 Fix write-region and its subroutines for buffers > 2GB.
14078 * fileio.c (a_write, e_write): Modify declaration of arguments and
14079 local variables to support buffers larger than 2GB.
14080 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
14081
14082 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
14083 argument, local variables, and return value.
14084
14085 * lisp.h: Update prototypes of emacs_write and emacs_read.
14086
14087 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
14088
4073e537 140892011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 14090
1ebfdcb6
PE
14091 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
14092
b2ded58d
PE
14093 Fix more problems found by GCC 4.6.0's static checks.
14094
7d66342c
PE
14095 * xdisp.c (vmessage): Use a better test for character truncation.
14096
bbf47d44
PE
14097 * charset.c (load_charset_map): <, not <=, for optimization,
14098 and to avoid potential problems with integer overflow.
9248994d 14099 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 14100 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 14101 * editfns.c (Fformat): Likewise.
1e69125e 14102 * syntax.c (skip_chars): Likewise.
3befa583 14103
e3019616
PE
14104 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
14105 This also lets GCC 4.6.0 generate slightly better loop code.
14106
becfa255
PE
14107 * callint.c (Fcall_interactively): <, not <=, for optimization.
14108 (Fcall_interactively): Count the number of arguments produced,
14109 not the number of arguments given. This is simpler and lets GCC
14110 4.6.0 generate slightly better code.
14111
dae0cd48
PE
14112 * ftfont.c: Distingish more carefully between FcChar8 and char.
14113 The previous code passed unsigned char * to a functions like
14114 strlen and xstrcasecmp that expect char *, which does not
14115 conform to the C standard.
14116 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
14117 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
14118 char * when the C standard requires it.
14119
76032d70
PE
14120 * keyboard.c (read_char): Remove unused var.
14121
eb3f1cc8
PE
14122 * eval.c: Port to Windows vsnprintf (Bug#8435).
14123 Include <limits.h>.
14124 (SIZE_MAX): Define if the headers do not.
14125 (verror): Do not give up if vsnprintf returns a negative count.
14126 Instead, grow the buffer. This ports to Windows vsnprintf, which
14127 does not conform to C99. Problem reported by Eli Zaretskii.
14128 Also, simplify the allocation scheme, by avoiding the need for
14129 calling realloc, and removing the ALLOCATED variable.
14130
70476b54
PE
14131 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
14132
12020a9e
PE
14133 Remove invocations of doprnt, as Emacs now uses vsnprintf.
14134 But keep the doprint source code for now, as we might revamp it
14135 and use it again (Bug#8435).
ea6c7ae6
PE
14136 * lisp.h (doprnt): Remove.
14137 * Makefile.in (base_obj): Remove doprnt.o.
14138 * deps.mk (doprnt.o): Remove.
14139
5fdb398c
PE
14140 error: Print 32- and 64-bit integers portably (Bug#8435).
14141 Without this change, on typical 64-bit hosts error ("...%d...", N)
14142 was used to print both 32- and 64-bit integers N, which relied on
14143 undefined behavior.
61bdb816 14144 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
14145 * lisp.h (error, verror): Mark as printf-like functions.
14146 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
14147 Report overflow in size calculations when allocating printf buffer.
14148 Do not truncate output string at its first null byte.
14149 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
14150 Truncate the output at a character boundary, since vsnprintf does not
14151 do that.
14152 * charset.c (check_iso_charset_parameter): Convert internal
14153 character to string before calling 'error', since %c now has the
14154 printf meaning.
14155 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
14156 overflow when computing char to be passed to 'error'. Do not
14157 pass Lisp_Object to 'error'; pass the integer instead.
14158 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
14159 formatted with plain %d.
14160
b189fa66
PE
14161 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
14162
bff87ef0
PE
14163 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
14164
7e2cac20
PE
14165 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
14166
ce4d90b5
PE
14167 * xterm.c (x_catch_errors): Remove duplicate declaration.
14168
266c9547
PE
14169 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
14170
79c49ad2
PE
14171 * xdisp.c, lisp.h (message_nolog): Remove; unused.
14172
368f4090
JM
141732011-04-10 Jim Meyering <meyering@redhat.com>
14174
14175 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
14176 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
14177 return ssize_t not "int", and use size_t as the buffer length.
14178 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
14179 * gnutls.h: Update declarations.
14180 * process.c (read_process_output): Use ssize_t, to match.
14181 (send_process): Likewise.
14182
a32d4040
CY
141832011-04-09 Chong Yidong <cyd@stupidchicken.com>
14184
14185 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
14186
8546720e 141872011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 14188
04f2d78b
CB
14189 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
14190 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 14191
8546720e
GM
14192 * xterm.c (handle_one_xevent):
14193 * xmenu.c (create_and_show_popup_menu):
14194 * xselect.c (x_decline_selection_request)
14195 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 14196
0a2f5c1a 141972011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
14198
14199 Fix some uses of `int' instead of EMACS_INT.
14200 * search.c (string_match_1, fast_string_match)
14201 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
14202 (scan_buffer, find_next_newline_no_quit)
14203 (find_before_next_newline, search_command, Freplace_match)
14204 (Fmatch_data): Make some `int' variables be EMACS_INT.
14205
14206 * xdisp.c (display_count_lines): 3rd argument and return value now
14207 EMACS_INT. All callers changed.
14208 (pint2hrstr): Last argument is now EMACS_INT.
14209
14210 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
14211 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
14212 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
14213 (decode_coding_utf_16, decode_coding_emacs_mule)
14214 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
14215 (decode_coding_ccl, decode_coding_charset)
14216 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
14217 (decode_coding_iso_2022, decode_coding_emacs_mule)
14218 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
14219 <char_offset, last_offset>: Declare EMACS_INT.
14220 (encode_coding_utf_8, encode_coding_utf_16)
14221 (encode_coding_emacs_mule, encode_invocation_designation)
14222 (encode_designation_at_bol, encode_coding_iso_2022)
14223 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
14224 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
14225 Declare EMACS_INT.
14226 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
14227 (encode_invocation_designation): Last argument P_NCHARS is now
14228 EMACS_INT.
14229 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
14230 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
14231
14232 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
14233 All users changed.
14234
14235 * ccl.c (Fccl_execute_on_string): Declare some variables
14236 EMACS_INT.
14237
8546720e 142382011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
14239
14240 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
14241
4e19a977
CS
142422011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
14243
14244 * process.c (Fformat_network_address): Doc fix.
14245
87302331
R
142462011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
14247
ee7683eb 14248 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 14249
cbb59342
CY
142502011-04-08 Chong Yidong <cyd@stupidchicken.com>
14251
14252 * keyboard.c (read_char): Call Lisp function help-form-show,
14253 instead of using internal_with_output_to_temp_buffer.
14254 (Qhelp_form_show): New var.
e0d38eeb 14255 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
14256
14257 * print.c (internal_with_output_to_temp_buffer): Function deleted.
14258
14259 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
14260
e67a13ab
CY
142612011-04-06 Chong Yidong <cyd@stupidchicken.com>
14262
04f2d78b
CB
14263 * process.c (Flist_processes): Remove to Lisp.
14264 (list_processes_1): Delete.
e67a13ab 14265
973f782d
EZ
142662011-04-06 Eli Zaretskii <eliz@gnu.org>
14267
7c106b1e
EZ
14268 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
14269
973f782d
EZ
14270 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
14271
41cf7d1a 142722011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 14273
ca23cc88
PE
14274 Fix more problems found by GCC 4.6.0's static checks.
14275
f390e2d5
PE
14276 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
14277
42eea0d0
PE
14278 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
14279
b69769da 14280 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 14281
f9541e84
PE
14282 * xdisp.c (vmessage): Mark as a printf-like function.
14283
13841b55
PE
14284 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
14285
c136c10f
PE
14286 * sound.c (sound_warning): Don't crash if arg contains a printf format.
14287
5e2d4a30
PE
14288 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
14289 printf-like functions.
14290 (tiff_load): Add casts to remove these marks before passing them
14291 to system-supplied API.
14292
583f48b9
PE
14293 * eval.c (Fsignal): Remove excess argument to 'fatal'.
14294
b25d760e
PE
14295 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
14296 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
14297 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
14298 directly, rather than having caller test rule sign. This avoids
14299 some unnecessary tests.
14300 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
14301 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
14302 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 14303
bc7b6697 14304 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 14305 (xfont_open): Avoid unnecessary tests.
bc7b6697 14306
27ccc379
PE
14307 * composite.c (composition_gstring_put_cache): Use unsigned integer.
14308
dcd5c89a
PE
14309 * composite.h, composite.c (composition_gstring_put_cache):
14310 Use EMACS_INT, not int, for length.
14311
b13a45c6
PE
14312 * composite.h (COMPOSITION_DECODE_REFS): New macro,
14313 breaking out part of COMPOSITION_DECODE_RULE.
14314 (COMPOSITION_DECODE_RULE): Use it.
14315 * composite.c (get_composition_id): Remove unused local vars,
14316 by using the new macro.
14317
1e792e4d
PE
14318 * textprop.c (set_text_properties_1): Change while to do-while,
14319 since the condition is always true at first.
14320
dc6c6455 14321 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
14322 (interval_deletion_adjustment): Return unsigned value.
14323 All uses changed.
dc6c6455 14324
aba7731a
PE
14325 * process.c (list_processes_1, create_pty, read_process_output):
14326 (exec_sentinel): Remove vars that were set but not used.
afd4052b 14327 (create_pty): Remove unnecessary "volatile"s.
bc57d757 14328 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 14329 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 14330 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 14331
fdfc4bf3
PE
14332 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
14333
fca8fe46 14334 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 14335 (update_syntax_table): Use unsigned instead of int.
fca8fe46 14336
06a0259a 14337 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 14338 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 14339 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 14340
e7b9e80f
PE
14341 * print.c (print_error_message): Avoid int overflow.
14342
56201685
PE
14343 * font.c (font_list_entities): Redo for clarity,
14344 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
14345
78834453 14346 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 14347 (font_score): Avoid potential overflow in diff calculation.
78834453 14348
0bc0b309 14349 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 14350 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 14351
e610eaca
PE
14352 * eval.c (funcall_lambda): Rename local to avoid shadowing.
14353
b895abce
PE
14354 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
14355 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
14356 can always succeed if overflow has undefined behavior.
14357
1f1d9321 14358 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 14359 (wordify): Omit three unnecessary tests.
1f1d9321 14360
c59478bc
PE
14361 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
14362 All callers changed. This avoids the need for an unused var.
14363
79b73827
PE
14364 * casefiddle.c (casify_region): Remove var that is set but not used.
14365
a4db5dfe
PE
14366 * dired.c (file_name_completion): Remove var that is set but not used.
14367
43aae36e
PE
14368 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
14369
2a47c44d 14370 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 14371 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 14372
a37c69bf
PE
14373 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
14374 Check for integer overflow on size calculations.
14375
328ab8e7
PE
14376 * buffer.c (Fprevious_overlay_change): Remove var that is set
14377 but not used.
14378
e5a2a5cb
PE
14379 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
14380 Remove vars that are set but not used.
8d84a6eb 14381 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 14382 (timer_check_2): Mark vars as initialized.
e5a2a5cb 14383
a60e5f68
PE
14384 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
14385
f661cb61 14386 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 14387 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 14388
f0397f5a
PE
14389 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
14390 that are set but not used.
14391
8664db06 14392 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 14393 if XCreateBitmapFromData fails (Bug#8410).
8664db06 14394
6abdaa4a
PE
14395 * xselect.c (x_get_local_selection, x_handle_property_notify):
14396 Remove vars that are set but not used.
14397
0ce7538d 14398 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 14399 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 14400
9ae848fc
PE
14401 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
14402 Remove var that is set but not used.
0b918413
PE
14403 (scroll_bar_windows_size): Now size_t, not int.
14404 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
14405 Check for overflow.
9ae848fc 14406
a5a62657
PE
14407 * xfaces.c (realize_named_face): Remove vars that are set but not used.
14408 (map_tty_color) [!defined MSDOS]: Likewise.
14409
5c5cdd39
PE
14410 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
14411
66ebf983
PE
14412 * coding.c: Remove vars that are set but not used.
14413 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
14414 All callers changed.
14415 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
14416 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
14417 (decode_coding_charset): Remove vars that are set but not used.
14418
1be4d761
PE
14419 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
14420 that is set but not used.
14421
47553fa8
PE
14422 * print.c (print_object): Remove var that is set but not used.
14423
1f7196bf 14424 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
14425 The gnulib version avoids calling malloc in the usual case,
14426 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
14427 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
14428 * filelock.c (current_lock_owner): Likewise.
14429 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
14430 * sysdep.c: Include allocator.h, careadlinkat.h.
14431 (emacs_no_realloc_allocator): New static constant.
14432 (emacs_readlink): New function.
fdb61804
PE
14433 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
14434 ../lib/careadlinkat.h.
d1fdcab7 14435
f84c17c7
SM
144362011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
14437
14438 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
14439 first non-nil return value).
14440
ef3862ad
JD
144412011-04-03 Jan Djärv <jan.h.d@swipnet.se>
14442
14443 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
14444 if not defined (Bug#8403).
14445
376a7006
JB
144462011-04-02 Juanma Barranquero <lekktu@gmail.com>
14447
14448 * xdisp.c (display_count_lines): Remove parameter `start',
14449 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
14450 (get_char_face_and_encoding): Remove parameter `multibyte_p',
14451 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
14452 (fill_stretch_glyph_string): Remove parameters `row' and `area',
14453 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
14454 and thereabouts. All callers changed.
14455 (get_per_char_metric): Remove parameter `f', unused since
14456 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
14457
6ca3801d
JM
144582011-04-02 Jim Meyering <meyering@redhat.com>
14459
14460 do not dereference NULL upon failed strdup
14461 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
14462 (ns_get_family): Likewise.
14463
d8e2b5ba
JB
144642011-04-02 Juanma Barranquero <lekktu@gmail.com>
14465
14466 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
14467
8c74fcbd
JD
144682011-04-02 Jan Djärv <jan.h.d@swipnet.se>
14469
14470 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
14471 later (Bug#8403).
14472
7200d79c
SM
144732011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
14474
03408648 14475 Add lexical binding.
7200d79c 14476
03408648
SM
14477 * window.c (Ftemp_output_buffer_show): New fun.
14478 (Fsave_window_excursion):
14479 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
14480
14481 * lread.c (lisp_file_lexically_bound_p): New function.
14482 (Fload): Bind Qlexical_binding.
14483 (readevalloop): Remove `evalfun' arg.
14484 Bind Qinternal_interpreter_environment.
14485 (Feval_buffer): Bind Qlexical_binding.
14486 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
14487 Mark as dynamic.
14488 (syms_of_lread): Declare `lexical-binding'.
14489
14490 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
14491
14492 * keyboard.c (eval_dyn): New fun.
14493 (menu_item_eval_property): Use it.
ca105506
SM
14494
14495 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 14496
03408648
SM
14497 * fns.c (concat, mapcar1): Accept byte-code-functions.
14498
14499 * eval.c (Fsetq): Handle lexical vars.
14500 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
14501 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
14502 (FletX, Flet): Obey lexical binding.
14503 (Fcommandp): Handle closures.
14504 (Feval): New `lexical' arg.
14505 (eval_sub): New function extracted from Feval. Use it almost
14506 everywhere where Feval was used. Look up vars in lexical env.
14507 Handle closures.
14508 (Ffunctionp): Move from subr.el.
14509 (Ffuncall): Handle closures.
14510 (apply_lambda): Remove `eval_flags'.
14511 (funcall_lambda): Handle closures and new byte-code-functions.
14512 (Fspecial_variable_p): New function.
14513 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
14514 but without exporting it to Lisp.
23aba0ea 14515
23aba0ea 14516 * doc.c (Fdocumentation, store_function_docstring):
03408648 14517 * data.c (Finteractive_form): Handle closures.
23aba0ea 14518
03408648
SM
14519 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
14520 interactive spec.
ba83908c 14521
04f2d78b
CB
14522 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
14523 New byte-codes.
03408648
SM
14524 (exec_byte_code): New function extracted from Fbyte_code to handle new
14525 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 14526
03408648 14527 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 14528
03408648 14529 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 14530
e2abce01
JB
145312011-03-31 Juanma Barranquero <lekktu@gmail.com>
14532
14533 * xdisp.c (redisplay_internal): Fix prototype.
14534
63696a73 145352011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 14536
63696a73 14537 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
14538 (try_scrolling): Use it when setting scroll_limit.
14539 Limit scrolling to 100 screen lines.
63696a73
EZ
14540 (redisplay_window): Even when falling back on "recentering",
14541 position point in the window according to scroll-conservatively,
14542 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
14543
14544 (try_scrolling): When point is above the window, allow searching
14545 as far as scroll_max, or one screenful, to compute vertical
14546 distance from PT to the scroll margin position. This prevents
14547 try_scrolling from unnecessarily failing when
14548 scroll-conservatively is set to a value slightly larger than the
14549 window height. Clean up the case of PT below the margin at bottom
14550 of window: scroll_max can no longer be INT_MAX. When aggressive
14551 scrolling is in use, don't let point enter the opposite scroll
14552 margin as result of the scroll.
14553 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
14554 threshold of 100 lines for never-recentering scrolling.
14555
e4cc2dfc
JB
145562011-03-31 Juanma Barranquero <lekktu@gmail.com>
14557
14558 * dispextern.h (move_it_by_lines):
14559 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
14560 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
14561 (message_log_check_duplicate): Remove parameters `prev_bol' and
14562 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
14563 (redisplay_internal): Remove parameter `preserve_echo_area',
14564 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
14565
14566 * indent.c (Fvertical_motion):
14567 * window.c (window_scroll_pixel_based, Frecenter):
14568 Don't pass `need_y_p' to `move_it_by_lines'.
14569
1c470562
SM
145702011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
14571
44f230aa
SM
14572 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
14573 steal a few bits to be more compact.
14574 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
14575 Remove unneeded casts.
14576
1c470562
SM
14577 * bytecode.c (Fbyte_code): CAR and CDR can GC.
14578
888adce9
ZK
145792011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
14580
14581 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
14582 binding" message (bug#7967).
14583
f838ed7b
PE
145842011-03-30 Paul Eggert <eggert@cs.ucla.edu>
14585
77861b95
PE
14586 Fix more problems found by GCC 4.6.0's static checks.
14587
de6dbc14
PE
14588 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
14589 Remove unused local var.
14590
f838ed7b
PE
14591 * editfns.c (Fmessage_box): Remove unused local var.
14592
792c7b2b
PE
14593 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
14594 (note_mode_line_or_margin_highlight, note_mouse_highlight):
14595 Omit unused local vars.
c499e557 14596 * window.c (shrink_windows): Omit unused local var.
b01a1c29 14597 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
14598 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
14599 Omit unused local var.
14600
ba0165e1
PE
14601 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
14602 Don't assume string length fits in int.
32ad8845 14603 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 14604 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 14605
3c59b4c9
PE
14606 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
14607 instead of alloca (Bug#8344).
14608
a3eed478 14609 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 14610 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 14611
eb4d412d
PE
14612 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
14613
1658b401
PE
14614 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
14615 concerns.
14616
14617 * term.c (produce_glyphless_glyph): Remove unnecessary test.
14618
14619 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 14620
9a2c6e05
PE
14621 * keyboard.c (syms_of_keyboard): Use the same style as later
14622 in this function when indexing through an array. This also
14623 works around GCC bug 48267.
14624
03d0a109
PE
14625 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
14626
44f730c8
PE
14627 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
14628
fe75f926
PE
14629 * chartab.c (sub_char_table_ref_and_range): Redo for slight
14630 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
14631
ffa8c828
PE
14632 * keyboard.c, keyboard.h (num_input_events): Now size_t.
14633 This avoids undefined behavior on integer overflow, and is a bit
14634 more convenient anyway since it is compared to a size_t variable.
14635
c5101a77
PE
14636 Variadic C functions now count arguments with size_t, not int.
14637 This avoids an unnecessary limitation on 64-bit machines, which
14638 caused (substring ...) to crash on large vectors (Bug#8344).
14639 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
14640 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 14641 All variadic functions and their callers changed accordingly.
c5101a77
PE
14642 (struct gcpro.nvars): Now size_t, not int. All uses changed.
14643 * data.c (arith_driver, float_arith_driver): Likewise.
14644 * editfns.c (general_insert_function): Likewise.
14645 * eval.c (struct backtrace.nargs, interactive_p)
14646 (internal_condition_case_n, run_hook_with_args, apply_lambda)
14647 (funcall_lambda, mark_backtrace): Likewise.
14648 * fns.c (concat): Likewise.
14649 * frame.c (x_set_frame_parameters): Likewise.
14650 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
14651 0 if not found, not -1. All callers changed.
14652
dd3f25f7
PE
14653 * alloc.c (garbage_collect): Don't assume stack size fits in int.
14654 (stack_copy_size): Now size_t, not int.
14655 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
14656
461c2ab9
JB
146572011-03-28 Juanma Barranquero <lekktu@gmail.com>
14658
14659 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
14660 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14661 All callers changed.
14662
14663 * lisp.h (multibyte_char_to_unibyte):
14664 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
14665 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14666 * character.h (CHAR_TO_BYTE8):
14667 * cmds.c (internal_self_insert):
14668 * editfns.c (general_insert_function):
14669 * keymap.c (push_key_description):
14670 * search.c (Freplace_match):
14671 * xdisp.c (message_dolog, set_message_1): All callers changed.
14672
f6d62986
SM
146732011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
14674
14675 * keyboard.c (safe_run_hook_funcall): New function.
14676 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
14677 don't set the hook to nil, but remove the offending function instead.
14678 (Qcommand_hook_internal): Remove, unused.
14679 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
14680 Vcommand_hook_internal.
14681
14682 * eval.c (enum run_hooks_condition): Remove.
14683 (funcall_nil, funcall_not): New functions.
14684 (run_hook_with_args): Call each function through a `funcall' argument.
14685 Remove `cond' argument, now redundant.
14686 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
14687 (Frun_hook_with_args_until_failure): Adjust accordingly.
14688 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
14689
1db5b1ad
JB
146902011-03-28 Juanma Barranquero <lekktu@gmail.com>
14691
14692 * dispextern.h (string_buffer_position): Remove declaration.
14693
14694 * print.c (strout): Remove parameter `multibyte', unused since
14695 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
14696
14697 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
14698 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
14699 All callers changed.
14700
14701 * w32.c (_wsa_errlist): Use braces for struct initializers.
14702
14703 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
14704 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
14705 All callers changed.
14706 (string_buffer_position): Likewise. Also, make static (it's never
14707 used outside xdisp.c).
14708 (cursor_row_p): Remove parameter `w', unused since
14709 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
14710 (decode_mode_spec): Remove parameter `precision', introduced during
14711 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
14712 All callers changed.
14713
5ffb62aa
JD
147142011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14715
14716 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
14717
461c2ab9 147182011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
14719
14720 * nsterm.m (ns_menu_bar_is_hidden): New variable.
14721 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
14722 (ns_update_auto_hide_menu_bar): New functions.
14723 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
14724 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
14725 ns_constrain_all_frames.
14726 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
14727 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
14728
5c380ffb
JD
147292011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14730
14731 * nsmenu.m (runDialogAt): Remove argument to timer_check.
14732
9af30bdf
GM
147332011-03-27 Glenn Morris <rgm@gnu.org>
14734
14735 * syssignal.h: Replace RETSIGTYPE with void.
14736 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
14737 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
14738 Replace SIGTYPE with void everywhere.
14739 * s/usg5-4-common.h (SIGTYPE): Remove definition.
14740 * s/template.h (SIGTYPE): Remove commented out definition.
14741
e2abce01
JB
147422011-03-26 Eli Zaretskii <eliz@gnu.org>
14743
14744 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
14745 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
14746
f868cd8a
JB
147472011-03-26 Juanma Barranquero <lekktu@gmail.com>
14748
59eb0929
JB
14749 * w32.c (read_unc_volume): Use parameter `henum', instead of
14750 global variable `wget_enum_handle'.
14751
14752 * keymap.c (describe_vector): Remove parameters `indices' and
14753 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
14754 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
14755
f868cd8a
JB
14756 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
14757
14758 * keyboard.c (timer_check): Remove parameter `do_it_now',
14759 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
14760 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
14761 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
14762
14763 * keyboard.c (read_char):
14764 * w32menu.c (w32_menu_display_help):
14765 * xmenu.c (show_help_event, menu_help_callback):
14766 Adjust calls to `show_help_echo'.
14767
14768 * gtkutil.c (xg_maybe_add_timer):
14769 * keyboard.c (readable_events):
14770 * process.c (wait_reading_process_output):
14771 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
14772
14773 * insdel.c (adjust_markers_gap_motion):
14774 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
14775 (gap_left, gap_right): Don't call it.
14776
2ecf6fdb
CY
147772011-03-25 Chong Yidong <cyd@stupidchicken.com>
14778
14779 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
14780 incurred during fontification.
14781
6b1f9ba4
JB
147822011-03-25 Juanma Barranquero <lekktu@gmail.com>
14783
14784 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
14785 (DEFVAR_PER_BUFFER): Don't pass it.
14786
14787 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
14788 (scrolling_window): Don't pass it.
14789
0f4a96b5
JB
147902011-03-25 Juanma Barranquero <lekktu@gmail.com>
14791
14792 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
14793
14794 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
14795 and `suffix'.
14796 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
14797 of variables specific to SELinux and computation of `encoded_absname'.
14798
14799 * image.c (XPutPixel): Remove unused variable `height'.
14800
14801 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
14802
14803 * unexw32.c (get_section_info): Remove unused variable `section'.
14804
14805 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
14806 (system_process_attributes): Remove unused variable `sess'.
14807 (sys_read): Remove unused variable `err'.
14808
14809 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
14810 (w32_wnd_proc): Remove unused variable `isdead'.
14811 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
14812 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
14813 (x_create_tip_frame): Remove unused variable `tem'.
14814
14815 * w32inevt.c (w32_console_read_socket):
14816 Remove unused variable `no_events'.
14817
14818 * w32term.c (x_draw_composite_glyph_string_foreground):
14819 Remove unused variable `width'.
14820
1149507c
JB
148212011-03-24 Juanma Barranquero <lekktu@gmail.com>
14822
14823 * w32term.c (x_set_glyph_string_clipping):
14824 Don't pass uninitialized region to CombineRgn.
14825
9c88f339
JB
148262011-03-23 Juanma Barranquero <lekktu@gmail.com>
14827
14828 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
14829 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
14830 (Fx_close_connection): Remove unused variable `i'.
14831
14832 * w32font.c (w32font_draw): Return number of glyphs.
14833 (w32font_open_internal): Remove unused variable `i'.
14834 (w32font_driver): Add missing initializer.
14835
14836 * w32menu.c (utf8to16): Remove unused variable `utf16'.
14837 (fill_in_menu): Remove unused variable `items_added'.
14838
14839 * w32term.c (last_mouse_press_frame): Remove static global variable.
14840 (w32_clip_to_row): Remove unused variable `f'.
14841 (x_delete_terminal): Remove unused variable `i'.
14842
14843 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
14844 (NOTHING): Remove unused static global variable.
14845 (uniscribe_check_otf): Remove unused variable `table'.
14846 (uniscribe_font_driver): Add missing initializers.
14847
dee091a3
JD
148482011-03-23 Julien Danjou <julien@danjou.info>
14849
14850 * term.c (Fsuspend_tty, Fresume_tty):
14851 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
14852 * window.c (temp_output_buffer_show):
14853 * insdel.c (signal_before_change):
14854 * frame.c (Fhandle_switch_frame):
14855 * fileio.c (Fdo_auto_save):
14856 * emacs.c (Fkill_emacs):
14857 * editfns.c (save_excursion_restore):
14858 * cmds.c (internal_self_insert):
14859 * callint.c (Fcall_interactively):
14860 * buffer.c (Fkill_all_local_variables):
14861 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
14862 Use Frun_hooks.
0f4a96b5 14863 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 14864 unconditionally since it does the check itself.
dee091a3 14865
2c520ab5 148662011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 14867
c9c49752
PE
14868 Fix more problems found by GCC 4.5.2's static checks.
14869
8abc3f12
PE
14870 * coding.c (encode_coding_raw_text): Avoid unnecessary test
14871 the first time through the loop, since we know p0 < p1 then.
14872 This also avoids a gcc -Wstrict-overflow warning.
14873
a2d26660
PE
14874 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
14875 leading to a memory leak, possible in functions like
14876 load_charset_map_from_file that can allocate an unbounded number
b12ef411 14877 of objects (Bug#8318).
a2d26660 14878
916c72e9
PE
14879 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
14880 that could (at least in theory) be that large.
14881
19ab8a18
PE
14882 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
14883 This is less likely to overflow, and avoids undefined behavior if
14884 overflow does occur. All callers changed. Use strtoul to scan
14885 for the unsigned long integer.
b7cbbd6f
PE
14886 (pint2hrstr): Simplify and tune code slightly.
14887 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 14888
f0641eff
PE
14889 * scroll.c (do_scrolling): Work around GCC bug 48228.
14890 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
14891
7f650bb9
PE
14892 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
14893 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
14894 (validate_x_resource_name): Simplify count usage.
14895 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 14896
37dd57d1
PE
14897 * fileio.c (Fcopy_file): Report error if fchown or fchmod
14898 fail (Bug#8306).
81e56e61 14899
699979fc 14900 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 14901
401bf9b4
PE
14902 * process.c (Fmake_network_process): Use socklen_t, not int,
14903 where POSIX says socklen_t is required in portable programs.
14904 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 14905 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
14906 (Fmake_network_process, server_accept_connection):
14907 (wait_reading_process_output, read_process_output):
14908 Likewise.
14909
b93aacde
PE
14910 * process.c: Rename or move locals to avoid shadowing.
14911 (list_processes_1, Fmake_network_process):
14912 (read_process_output_error_handler, exec_sentinel_error_handler):
14913 Rename or move locals.
4dc343ee 14914 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 14915 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 14916 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 14917 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 14918 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 14919
af8a867c 14920 Make tparam.h and terminfo.c consistent.
44f230aa
SM
14921 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
14922 Include tparam.h instead, since it declares them.
af8a867c
PE
14923 * cm.h (PC): Remove extern decl; tparam.h now does this.
14924 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
14925 * terminfo.c: Include tparam.h, to check interfaces.
14926 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
14927 (tparam): Adjust signature to match interface in tparam.h;
14928 this removes some undefined behavior. Check that outstring and len
14929 are zero, which they always are with Emacs.
14930 * tparam.h (PC, BC, UP): New extern decls.
14931
0248044d 14932 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 14933 (xftfont_open): Rename locals to avoid shadowing.
0248044d 14934
8ff096c1 14935 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
14936 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
14937 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 14938 (ftfont_list): Remove unused local.
49eaafba
PE
14939 (get_adstyle_property, ftfont_pattern_entity):
14940 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
14941 Rename locals to avoid shadowing.
8ff096c1 14942
e2be39f6
PE
14943 * xfont.c (xfont_list_family): Mark var as initialized.
14944
c9735e30
PE
14945 * xml.c (make_dom): Now static.
14946
8f5201ae
PE
14947 * composite.c (composition_compute_stop_pos): Rename local to
14948 avoid shadowing.
b246f932
PE
14949 (composition_reseat_it): Remove unused locals.
14950 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 14951 (composition_update_it): Mark var as initialized.
11b61122
PE
14952 (find_automatic_composition): Mark vars as initialized,
14953 with a FIXME (Bug#8290).
8f5201ae 14954
760fbc2c
PE
14955 character.h: Rename locals to avoid shadowing.
14956 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
14957 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
14958 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
14959 (BUF_DEC_POS): Be more systematic about renaming local temporaries
14960 to avoid shadowing.
14961
ff08eb85
PE
14962 * textprop.c (property_change_between_p): Remove; unused.
14963
fc7bf025
PE
14964 * intervals.c (interval_start_pos): Now static.
14965
235d7abc
PE
14966 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
14967
44f230aa
SM
14968 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
14969 Rename locals to avoid shadowing.
3e7d6594 14970
50060332
PE
14971 * sound.c (wav_play, au_play, Fplay_sound_internal):
14972 Fix pointer signedness.
d01f234b 14973 (alsa_choose_format): Remove unused local var.
c83b8872
PE
14974 (wav_play): Initialize a variable to 0, to prevent undefined
14975 behavior (Bug#8278).
50060332 14976
c4fc4e30
PE
14977 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
14978
918436ed
PE
14979 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
14980
c939f91b
PE
14981 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
14982 clobbering (Bug#8298).
b9c7f648
PE
14983 * sysdep.c (sys_subshell): Likewise.
14984 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 14985
6bd8c144
PE
14986 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
14987 This should get cleaned up, so that child_setup has the
14988 same signature on all platforms.
14989
7710357c 14990 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 14991 (relocate_fd): Rename locals to avoid shadowing.
7710357c 14992
c59da222
CY
149932011-03-22 Chong Yidong <cyd@stupidchicken.com>
14994
14995 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
14996 not to be necessary, and produces flickering.
14997
66b87493
GM
149982011-03-20 Glenn Morris <rgm@gnu.org>
14999
15000 * config.in: Remove file.
15001
45b6f6d5
JB
150022011-03-20 Juanma Barranquero <lekktu@gmail.com>
15003
15004 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
15005 are now in src/globals.h.
15006 (syms_of_minibuf): Remove spurious & from previous change.
15007
cd394be1 150082011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
15009
15010 * minibuf.c (completing-read-function): New variable.
15011 (completing-read-default): Rename from completing-read.
15012 (completing-read): Call completing-read-function.
15013
b14e3e21
CY
150142011-03-19 Juanma Barranquero <lekktu@gmail.com>
15015
15016 * xfaces.c (Fx_load_color_file):
15017 Read color file from absolute filename (bug#8250).
15018
f2b726e6
JB
150192011-03-19 Juanma Barranquero <lekktu@gmail.com>
15020
15021 * makefile.w32-in: Update dependencies.
15022
09f6ff02
EZ
150232011-03-17 Eli Zaretskii <eliz@gnu.org>
15024
15025 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
15026
29a6015a
PE
150272011-03-17 Paul Eggert <eggert@cs.ucla.edu>
15028
a3a6c54e
PE
15029 Fix more problems found by GCC 4.5.2's static checks.
15030
b766f867
PE
15031 * process.c (make_serial_process_unwind, send_process_trap):
15032 (sigchld_handler): Now static.
15033
be02381c
PE
15034 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
15035 That way, the code declares only the vars that it needs.
15036 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
15037 * s/cygwin.h (PTY_ITERATION): Likewise.
15038 * s/darwin.h (PTY_ITERATION): Likewise.
15039 * s/gnu-linux.h (PTY_ITERATION): Likewise.
15040
57048744
PE
15041 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
15042 * process.c (allocate_pty): Don't declare stb unless it's needed.
15043
7914961c 15044 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
15045 (CONSTANTLIM): Remove; unused.
15046 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
15047 Define only if needed.
7914961c 15048
b3967b18
PE
15049 * unexelf.c (unexec): Name an expression,
15050 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
15051 Use a different way to cause a compilation error if anyone uses
15052 n rather than nn, a way that does not involve shadowing.
73366a00 15053 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 15054
29a6015a
PE
15055 * deps.mk (unexalpha.o): Remove; unused.
15056
43cfc33e 15057 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 15058 * unexec.h: New file.
ce701a33
PE
15059 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
15060 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
15061 Depend on unexec.h.
15062 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
15063 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
15064 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 15065 Change as necessary to match prototype in unexec.h.
ce701a33 15066
01f44d5a
PE
15067 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
15068 shadowing.
4f63c6bb 15069 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 15070
a6670b0b
PE
15071 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
15072 Rename locals to avoid shadowing.
15073
cef2010d 15074 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 15075 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 15076
d4d7173a
PE
15077 * print.c (Fredirect_debugging_output): Fix pointer signedess.
15078
f08b802a
PE
15079 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
15080 warning when compiling print.c.
15081
3ddb0639
PE
15082 * font.c (font_unparse_fcname): Abort in an "impossible" situation
15083 instead of using an uninitialized var.
5ad03b97 15084 (font_sort_entities): Mark var as initialized.
3ddb0639 15085
170a2692
PE
15086 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
15087
e663c700
PE
15088 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
15089 pointers to constants.
89bc529a 15090 (font_parse_fcname): Remove unused vars.
7b81e2d0 15091 (font_delete_unmatched): Now static.
ea838e10 15092 (font_get_spec): Remove; unused.
13a547c6
PE
15093 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
15094 (font_update_drivers, Ffont_get_glyphs, font_add_log):
15095 Rename or move locals to avoid shadowing.
e663c700 15096
2a80c887 15097 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 15098 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 15099
1384fa33 15100 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 15101 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 15102
8b2c52e9
PE
15103 * alloc.c (mark_backtrace): Move decl from here ...
15104 * lisp.h: ... to here, so that it can be checked.
15105
475545b5 15106 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 15107 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
15108 (lisp_indirect_variable): Name an expression,
15109 to avoid gcc -Wbad-function-cast warning.
1faed8ae 15110 (Fdefvar): Rename locals to avoid shadowing.
475545b5 15111
b1349114 15112 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 15113 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 15114 Use const pointer when appropriate.
b1349114 15115
a2928364
PE
15116 * lisp.h (get_system_name, get_operating_system_release):
15117 Move decls here, to check interfaces.
15118 * process.c (get_operating_system_release): Move decl to lisp.h.
15119 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
15120 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
15121 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
15122 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
15123 (Fformat_time_string, Fencode_time, Finsert_char):
15124 (Ftranslate_region_internal, Fformat):
15125 Rename or remove local vars to avoid shadowing.
9710023e 15126 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 15127
a415e694
PE
15128 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
15129 avoid shadowing.
15130
8ef4622d
PE
15131 * lisp.h (eassert): Check that the argument compiles, even if
15132 ENABLE_CHECKING is not defined.
15133
946f9a5b
PE
15134 * data.c (Findirect_variable): Name an expression, to avoid
15135 gcc -Wbad-function-cast warning.
112396d6 15136 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 15137 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
15138 (Fmake_variable_buffer_local, Fmake_local_variable):
15139 Mark variables as initialized.
52746918 15140 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 15141
e5aab7e7 15142 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
15143 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
15144 Rename locals to avoid shadowing.
dff45157
PE
15145 (mark_stack): Move local variables into the #ifdef region where
15146 they're used.
7bc26fdb
PE
15147 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
15148 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
15149 needed otherwise.
15150 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
15151 (GC_STRING_CHARS): Remove; not used.
d40d4be1 15152 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 15153
e5aab7e7
PE
15154 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
15155 avoids undefined behavior in theory.
15156
4da60324
PE
15157 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
15158
88043301
PE
15159 Use functions, not macros, for up- and down-casing (Bug#8254).
15160 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
15161 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
15162 to use the following functions instead of these macros.
15163 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
15164 EMACS_INT, since callers assume the returned value fits in int.
15165 (upcase1): Likewise, for UPCASE_TABLE.
15166 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 15167 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 15168 the race-condition problem in the old DOWNCASE.
88043301 15169
19ed5445
PE
15170 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
15171 Rename locals to avoid shadowing.
15172 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
15173 (regex_compile, re_search_2, re_match_2_internal):
15174 Remove unused local vars.
952db0d7
PE
15175 (FREE_VAR): Rewrite so as not to use empty "else",
15176 which gcc can warn about.
da053e48 15177 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
15178 (RETALLOC_IF): Define only if needed.
15179 (WORDCHAR_P): Likewise. This one is never needed, but is used
15180 only in a comment talking about a compiler bug, so put inside
15181 the #if 0 of that comment.
15182 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
15183 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
15184 Remove; unused.
19ed5445 15185
1f3561e4 15186 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
15187 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
15188 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 15189
ded6f8f7
PE
15190 * search.c (simple_search): Remove unused var.
15191
dbd37a95
PE
15192 * dired.c (compile_pattern): Move decl from here ...
15193 * lisp.h: ... to here, so that it can be checked.
15194 (struct re_registers): New forward decl.
15195
7e47afad
PE
15196 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
15197
85f24f61
PE
15198 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
15199 All uses changed.
15200 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
15201 Rename locals to avoid shadowing.
5671df8f 15202 (Fvertical_motion): Mark locals as initialized.
85f24f61 15203
181aa2be 15204 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 15205 (casify_region): Mark local as initialized.
181aa2be 15206
930d429c
PE
15207 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
15208
7082eac6
PE
15209 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
15210 New macros, so that the caller can use some names other than
15211 gcpro1, gcpro2, etc.
15212 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
15213 of the new macros.
15214 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
15215 argument, for consistency with GCPRO2_VAR, etc: it is now the
15216 prefix of the variable, not the variable itself. All uses
15217 changed.
38b2c076
PE
15218 * dired.c (directory_files_internal, file_name_completion):
15219 Rename locals to avoid shadowing.
15220
15206ed9
PE
15221 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
15222 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
15223 dired.c's scmp function, had undefined behavior.
15224 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
15225 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
15226 * buffer.h: ... to here, because these macros use current_buffer,
15227 and the new implementation with inline functions needs to have
15228 current_buffer in scope now, rather than later when the macros
15229 are used.
15230 (downcase, upcase1): New static inline functions.
15231 (DOWNCASE, UPCASE1): Reimplement using these functions.
15232 This avoids undefined behavior in expressions like
15233 DOWNCASE (x) == DOWNCASE (y), which previously suffered
15234 from race conditions in accessing the global variables
15235 case_temp1 and case_temp2.
15236 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
15237 * lisp.h (case_temp1, case_temp2): Remove their decls.
15238 * character.h (ASCII_CHAR_P): Move from here ...
15239 * lisp.h: ... to here, so that the inline functions mentioned
15240 above can use them.
15241
4a6bea26
PE
15242 * dired.c (directory_files_internal_unwind): Now static.
15243
f14b7e14
PE
15244 * fileio.c (file_name_as_directory, directory_file_name):
15245 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
15246 Now static.
2893f146
PE
15247 (file_name_as_directory): Use const pointers when appropriate.
15248 (Fexpand_file_name): Likewise. In particular, newdir might
15249 point at constant storage, so make it a const pointer.
fd4ead52 15250 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
15251 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
15252 signedness issues.
f839df0c
PE
15253 (Fset_file_times, Finsert_file_contents, auto_save_error):
15254 Rename locals to avoid shadowing.
f14b7e14 15255
5716756e 15256 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
15257 (Ftry_completion, Fall_completions): Rename or remove locals
15258 to avoid shadowing.
5716756e 15259
b4c3046a
PE
15260 * marker.c (bytepos_to_charpos): Remove; unused.
15261
b45db522
PE
15262 * lisp.h (verify_bytepos, count_markers): New decls,
15263 so that gcc does not warn that these functions aren't declared.
15264
85876d07
PE
15265 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
15266 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 15267 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 15268 (copy_text): Remove unused local var.
85876d07 15269
03d78a21 15270 * filelock.c (within_one_second): Now static.
b3dd38ab 15271 (lock_file_1): Rename local to avoid shadowing.
03d78a21 15272
5df8f01b
PE
15273 * buffer.c (fix_overlays_before): Mark locals as initialized.
15274 (fix_start_end_in_overlays): Likewise. This function should be
15275 simplified by using pointers-to-pointers, but that's a different
15276 matter.
b1d876f1 15277 (switch_to_buffer_1): Now static.
8f54f30a
PE
15278 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
15279 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 15280
a70072c9 15281 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 15282 Fix pointer signedness issue.
edced198
PE
15283 (sys_subshell): Mark local as volatile if checking for lint,
15284 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 15285 (MAXPATHLEN): Define only if needed.
a70072c9 15286
a0977c44
PE
15287 * process.c (serial_open, serial_configure): Move decls from here ...
15288 * systty.h: ... to here, so that they can be checked.
15289
a884fdcc
PE
15290 * fns.c (get_random, seed_random): Move extern decls from here ...
15291 * lisp.h: ... to here, so that they can be checked.
15292
604efe86 15293 * sysdep.c (reset_io): Now static.
b8950c94 15294 (wait_for_termination_signal): Remove; unused.
604efe86 15295
38fc62d9
PE
15296 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
15297 (copy_keymap_item, append_key, push_text_char_description):
15298 Now static.
1004a21a 15299 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 15300 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
15301 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
15302 (describe_map_tree):
15303 Rename locals to avoid shadowing.
38fc62d9 15304
2f2650da
PE
15305 * keyboard.c: Declare functions static if they are not used elsewhere.
15306 (echo_char, echo_dash, cmd_error, top_level_2):
15307 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
15308 (read_char, kbd_buffer_get_event, make_lispy_position):
15309 (make_lispy_event, make_lispy_movement, apply_modifiers):
15310 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
15311 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
15312 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 15313 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 15314 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 15315
a053e86c 15316 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
15317 (mark_kboards): Move decl here ...
15318 * alloc.c (mark_kboards): ... from here.
a053e86c 15319
4752793e
PE
15320 * lisp.h (force_auto_save_soon): New decl.
15321
74f10ca7 15322 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
15323 (DEFINE_DUMMY_FUNCTION): New macro.
15324 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
15325 Use it.
c03cd23f
PE
15326 (main): Add casts to avoid warnings
15327 if GCC considers string literals to be constants.
74f10ca7 15328
022e70d4
PE
15329 * lisp.h (fatal_error_signal): Add decl, since it's exported.
15330
59d6fe83
PE
15331 * dbusbind.c: Pointer signedness fixes.
15332 (xd_signature, xd_append_arg, xd_initialize):
15333 (Fdbus_call_method, Fdbus_call_method_asynchronously):
15334 (Fdbus_method_return_internal, Fdbus_method_error_internal):
15335 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
15336 (Fdbus_register_signal): Use SSDATA when the context wants char *.
15337
78320123
PE
15338 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
15339 if GCC considers string literals to be constants.
49cebcca 15340 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 15341
35ac2a97
SM
153422011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
15343
fb103ca9
SM
15344 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
15345 (print_preprocess, print_object): New macro to fix last change.
15346
35ac2a97
SM
15347 * print.c (print_preprocess): Don't forget font objects.
15348
62973b41
JB
153492011-03-16 Juanma Barranquero <lekktu@gmail.com>
15350
15351 * emacs.c (USAGE3): Doc fixes.
15352
0e48bb22
AS
153532011-03-15 Andreas Schwab <schwab@linux-m68k.org>
15354
15355 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
15356 structure.
15357
7684e57b
JB
153582011-03-14 Juanma Barranquero <lekktu@gmail.com>
15359
15360 * lisp.h (VWindow_system, Qfile_name_history):
15361 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
15362 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
15363 (w32_system_caret_x, w32_system_caret_y): Declare extern.
15364
15365 * w32select.c: Don't #include "keyboard.h".
c96bbc66 15366 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
15367
15368 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
15369 * w32console.c (detect_input_pending, read_input_pending)
15370 (encode_terminal_code):
15371 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
15372 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
15373 (w32_system_caret_y, Qfile_name_history):
15374 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
15375 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
15376 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
15377 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
15378 * w32proc.c (Qlocal, report_file_error):
15379 * w32term.c (Vwindow_system, updating_frame):
15380 * w32uniscribe.c (initialized, uniscribe_font_driver):
15381 Remove unneeded extern declarations.
15382
2aa46d6c
CY
153832011-03-14 Chong Yidong <cyd@stupidchicken.com>
15384
c96bbc66 15385 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 15386
cffc6f3b
CY
153872011-03-13 Chong Yidong <cyd@stupidchicken.com>
15388
15389 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
15390 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
15391 These macros can no longer be used for assignment.
15392
44f230aa
SM
15393 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
15394 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
15395 (record_buffer_markers, fetch_buffer_markers): New functions for
15396 recording and fetching special buffer markers.
15397 (set_buffer_internal_1, set_buffer_temp): Use them.
15398
15399 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
15400
15401 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
15402
15403 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
15404 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
15405
15406 * xdisp.c (hscroll_window_tree):
15407 (reconsider_clip_changes): Use PT instead of BUF_PT.
15408
d251f04b
EZ
154092011-03-13 Eli Zaretskii <eliz@gnu.org>
15410
15411 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
15412 $(EMACS_ROOT)/lib/intprops.h.
15413
f0c77cd1
PE
154142011-03-13 Paul Eggert <eggert@cs.ucla.edu>
15415
3eca4629
PE
15416 Fix more problems found by GCC 4.5.2's static checks.
15417
7c86ee98
PE
15418 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
15419 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
15420 (xg_free_frame_widgets): Make it clear that a local variable is
15421 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
15422 (gdk_window_get_screen): Make it clear that this macro is needed
15423 only if USE_GTK_TOOLTIP.
1e5524e7
PE
15424 (int_gtk_range_get_value): New function, which avoids a diagnostic
15425 from gcc -Wbad-function-cast.
15426 (xg_set_toolkit_scroll_bar_thumb): Use it.
15427 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
15428 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
15429 (get_utf8_string, xg_get_file_with_chooser):
15430 Rename locals to avoid shadowing.
15431 (create_dialog): Move locals to avoid shadowing.
7c86ee98 15432
41729b81
PE
15433 * xgselect.c (xg_select): Remove unused var.
15434
f0c77cd1
PE
15435 * image.c (four_corners_best): Mark locals as initialized.
15436 (gif_load): Initialize transparent_p to zero (Bug#8238).
15437 Mark another local as initialized.
ec6cf4c6 15438 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 15439
ce0ad53d 15440 * image.c (clear_image_cache): Now static.
d5d5a617 15441 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 15442 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
15443 (x_edge_detection): Remove unnecessary cast that
15444 gcc -Wbad-function-cast diagnoses.
2037898d 15445 (gif_load): Fix pointer signedness.
6ae141d6
PE
15446 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
15447 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 15448
33383987 154492011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 15450
d32df629
PE
15451 Improve quality of tests for time stamp overflow.
15452 For example, without this patch (encode-time 0 0 0 1 1
15453 1152921504606846976) returns the obviously-bogus value (-948597
15454 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
15455 reports time overflow. See
15456 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
15457 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
15458 * editfns.c: Include limits.h and intprops.h.
15459 (TIME_T_MIN, TIME_T_MAX): New macros.
15460 (time_overflow): Move earlier, to before first use.
15461 (hi_time, lo_time): New functions, for an accurate test for
15462 out-of-range times.
15463 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
15464 (Fget_internal_run_time): Don't assume time_t fits in int.
15465 (make_time): Use list2 instead of Fcons twice.
15466 (Fdecode_time): More accurate test for out-of-range times.
15467 (check_tm_member): New function.
15468 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
15469 (lisp_time_argument): Don't rely on undefined left-shift and
15470 right-shift behavior when checking for time stamp overflow.
8be6f318 15471
fe31d94c
PE
15472 * editfns.c (time_overflow): New function, refactoring common code.
15473 (Fformat_time_string, Fdecode_time, Fencode_time):
15474 (Fcurrent_time_string): Use it.
15475
8be6f318
PE
15476 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
15477 * dired.c (make_time): Move to ...
15478 * editfns.c (make_time): ... here.
15479 * systime.h: Note the move.
15480
09d9db2c 154812011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 15482
126bc0dc
YM
15483 * fringe.c (update_window_fringes): Remove unused variables.
15484
c47cbdfd
YM
15485 * unexmacosx.c (copy_data_segment): Also copy __got section.
15486 (Bug#8223)
15487
7ac80be9
EZ
154882011-03-12 Eli Zaretskii <eliz@gnu.org>
15489
c96bbc66 15490 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
15491 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
15492 Constify `char *' arguments and their references according to
15493 prototypes in tparam.h.
15494
ecb0f94d 15495 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 15496
7ac80be9
EZ
15497 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
15498 Adapt all references accordingly.
15499
15500 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
15501
ef1fd07e
TT
155022011-03-11 Tom Tromey <tromey@redhat.com>
15503
15504 * buffer.c (syms_of_buffer): Remove obsolete comment.
15505
7ef4b50c
EZ
155062011-03-11 Eli Zaretskii <eliz@gnu.org>
15507
15508 * termhooks.h (encode_terminal_code): Declare prototype.
15509
15510 * msdos.c (encode_terminal_code): Don't declare prototype.
15511
15512 * term.c (encode_terminal_code): Now external again, used by
15513 w32console.c and msdos.c.
15514
44f230aa
SM
15515 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
15516 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 15517
4b1ec863 155182011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 15519
1714f52b 15520 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 15521
4b1ec863
PE
15522 * fringe.c (update_window_fringes): Mark locals as initialized
15523 (Bug#8227).
15524 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 15525
524c7aa6
PE
15526 * alloc.c (mark_fringe_data): Move decl from here ...
15527 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
15528 to check its interface.
15529 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
15530
a5c0af81 15531 * fontset.c (free_realized_fontset): Now static.
7519b8cd 15532 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 15533 (fontset_font): Mark local as initialized.
a9a06e0b 15534 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 15535
b4716021
PE
15536 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
15537
811e9bac 15538 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 15539 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
15540 (x_own_selection, Fx_disown_selection_internal): Rename locals
15541 to avoid shadowing.
15542 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 15543
7e3ab302
PE
15544 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
15545 so that the caller can use some name other than gcpro1.
15546 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
15547 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15548 (Fx_backspace_delete_keys_p):
15549 Use them to avoid shadowing, and rename vars to avoid shadowing.
15550 (x_decode_color, x_set_name, x_window): Now static.
6b437900 15551 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 15552 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
15553 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
15554 Remove unused locals.
7e3ab302
PE
15555 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15556 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
15557 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
15558 macros.
f78faa98 15559
e2b13473
PE
15560 * xterm.h (x_mouse_leave): New decl.
15561
77f23912
PE
15562 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
15563 Remove unused functions.
cdf4ba58
PE
15564 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
15565 (x_calc_absolute_position): Now static.
7411c686 15566 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 15567 Don't declare local "event" unless it's used.
ed7bf3a5
PE
15568 (x_iconify_frame, x_free_frame_resources): Don't declare locals
15569 unless they are used.
38d0b34a
PE
15570 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
15571 (x_fatal_error_signal): Remove; not used.
a6067996
PE
15572 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
15573 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
15574 (x_error_catcher, x_connection_closed, x_error_handler):
15575 (x_error_quitter, xembed_send_message, x_iconify_frame):
15576 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 15577 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 15578 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 15579
44f230aa
SM
15580 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
15581 Rename or move locals to avoid shadowing.
6b463e58 15582 (tty_defined_color, merge_face_heights): Now static.
5967d051 15583 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
15584 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
15585 does not deduce is never used uninitialized.
73719eba
PE
15586 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
15587 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 15588
426994c3 15589 * terminal.c (store_terminal_param): Now static.
5489860b 15590
032f1620 15591 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 15592 (set_frame_menubar): Remove unused local.
d4323972 15593 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
15594 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
15595 since they might point to immutable storage.
281585b0
PE
15596 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
15597 since it's unused otherwise.
032f1620 15598
367c19e5 15599 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 15600 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
15601 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
15602 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 15603 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
15604 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
15605 does not deduce are never used uninitialized.
70739cbe 15606
07b48fa9
PE
15607 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
15608
8868a238 15609 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
15610 * window.c (window_loop, size_window):
15611 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 15612
7e5cf297 15613 * window.c (display_buffer): Now static.
d6550a9f
PE
15614 (size_window): Mark variables that gcc -Wuninitialized
15615 does not deduce are never used uninitialized.
a586633d
PE
15616 * window.h (check_all_windows): New decl, to forestall
15617 gcc -Wmissing-prototypes diagnostic.
5b555da1 15618 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 15619
f6095868
PE
15620 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
15621 shadowing.
15622 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
15623 Include <limits.h>.
15624 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
15625 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
15626 (load_charset_map): Mark variables that gcc -Wuninitialized
15627 does not deduce are never used uninitialized.
53df7c11 15628 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 15629
f38b440c
PE
15630 * coding.c (coding_set_source, coding_set_destination):
15631 Use "else { /* comment */ }" rather than "else /* comment */;"
15632 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
15633 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
15634 a block, when the outer 'i' will do.
15635 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
15636 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
15637 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
15638 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
15639 (Fdecode_sjis_char, Fdefine_coding_system_internal):
15640 Rename locals to avoid shadowing.
15641 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
15642 * coding.c (emacs_mule_char, encode_invocation_designation):
15643 Now static, since they're not used elsewhere.
413bb2db 15644 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 15645 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
15646 (decode_coding_emacs_mule): Mark variables that gcc
15647 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
15648 (detect_coding_iso_2022): Initialize a local variable that might
15649 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 15650 this initialization is needed. (Bug#8211)
5f58e762
PE
15651 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
15652 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
15653 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
15654 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
15655 Remove unused macros.
f38b440c 15656
232b38b9 15657 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 15658 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 15659 * character.c (string_count_byte8): Likewise.
232b38b9 15660
fb90da1b
PE
15661 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
15662 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
15663
fb93dbc2
PE
15664 * chartab.c (copy_sub_char_table): Now static, since it's not used
15665 elsewhere.
5c156ace
PE
15666 (sub_char_table_ref_and_range, char_table_ref_and_range):
15667 Rename locals to avoid shadowing.
bbcd0949 15668 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 15669
7d3b3862 15670 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 15671 (BIDI_BOB): Remove unused macro.
7d3b3862 15672
6be7d3da
PE
15673 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
15674 deduce are never used uninitialized.
c2ed9c8b 15675 * term.c (encode_terminal_code): Likewise.
6be7d3da 15676
75f8807f 15677 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 15678
50938595
PE
15679 * tparam.h: New file.
15680 * term.c, tparam.h: Include it.
15681 * deps.mk (term.o, tparam.o): Depend on tparam.h.
15682 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
15683 Move these decls to tparam.h, and make them agree with what
15684 is actually in tparam.c. The previous trick of using incompatible
15685 decls in different modules does not conform to the C standard.
15686 All callers of tparam changed to use tparam's actual API.
15687 * tparam.c (tparam1, tparam, tgoto):
15688 Use const pointers where appropriate.
15689
fbceeba2
PE
15690 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
15691 * cm.h (struct cm): Likewise.
15692 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
15693 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
15694 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
15695 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
15696 (turn_on_face, init_tty): Likewise.
15697 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 15698
7f3f1250
PE
15699 * term.c (term_mouse_position): Rename local to avoid shadowing.
15700
e6ca6543
PE
15701 * alloc.c (mark_ttys): Move decl from here ...
15702 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
15703
c40f8d15
AS
157042011-03-11 Andreas Schwab <schwab@linux-m68k.org>
15705
15706 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
15707
cfe0661d
JB
157082011-03-09 Juanma Barranquero <lekktu@gmail.com>
15709
15710 * search.c (compile_pattern_1): Remove argument regp, unused since
15711 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
15712 (compile_pattern): Don't pass it.
15713
0afb4571
J
157142011-03-08 Jan Djärv <jan.h.d@swipnet.se>
15715
15716 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
15717 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
15718 for ! HAVE_GTK3.
15719 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
15720
15721 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
15722
15723 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
15724 gdk_window_get_screen, gdk_window_get_geometry,
15725 gdk_x11_window_lookup_for_display and GDK_KEY_g.
15726 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
15727 (xg_get_pixbuf_from_pixmap): New function.
15728 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
15729 to Pixmap, take frame as parameter, remove GdkColormap parameter.
15730 Call xg_get_pixbuf_from_pixmap instead of
15731 gdk_pixbuf_get_from_drawable.
15732 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
15733 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
15734 (xg_check_special_colors): Use GtkStyleContext and its functions
15735 for HAVE_GTK3.
15736 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
15737 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
15738 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
15739 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
15740 Call gtk_widget_get_preferred_size.
0afb4571
J
15741 (xg_frame_resized): gdk_window_get_geometry only takes 5
15742 parameters.
44f230aa
SM
15743 (xg_win_to_widget, xg_event_is_for_menubar):
15744 Call gdk_x11_window_lookup_for_display.
0afb4571
J
15745 (xg_set_widget_bg): New function.
15746 (delete_cb): New function.
895009e1 15747 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 15748 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
15749 (xg_set_background_color): Call xg_set_widget_bg.
15750 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
15751 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
15752 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
15753 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
15754 if ! HAVE_GTK3.
15755 (update_frame_tool_bar): Call gtk_widget_hide.
15756 (xg_initialize): Use GDK_KEY_g.
15757
15758 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
15759 if ! HAVE_GTK3
15760 (x_session_initialize): Call gdk_x11_set_sm_client_id.
15761
15762 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
15763 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
15764 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
15765
1c2cc4ef
JB
157662011-03-08 Juanma Barranquero <lekktu@gmail.com>
15767
15768 * w32xfns.c (select_palette): Check success of RealizePalette against
15769 GDI_ERROR, not zero.
15770
33383987 15771See ChangeLog.11 for earlier changes.
aac0c6e3
MR
15772
15773;; Local Variables:
15774;; coding: utf-8
aac0c6e3
MR
15775;; End:
15776
2f097256 15777 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
15778
15779 This file is part of GNU Emacs.
15780
15781 GNU Emacs is free software: you can redistribute it and/or modify
15782 it under the terms of the GNU General Public License as published by
15783 the Free Software Foundation, either version 3 of the License, or
15784 (at your option) any later version.
15785
15786 GNU Emacs is distributed in the hope that it will be useful,
15787 but WITHOUT ANY WARRANTY; without even the implied warranty of
15788 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15789 GNU General Public License for more details.
15790
15791 You should have received a copy of the GNU General Public License
15792 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.