src/bidi.c: Backport from trunk a bugfix for bidi_paragraph_init at EOB.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c1734fbd
EZ
12011-07-23 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (move_it_in_display_line_to): Record the best matching
4 position for TO_CHARPOS while scanning the line, and restore it on
5 exit if none of the characters scanned was an exact match. Fixes
6 vertical-motion and pos-visible-in-window-p when exact match is
7 impossible due to invisible text, and the lines are truncated.
8
b6d5a689
EZ
92011-07-22 Eli Zaretskii <eliz@gnu.org>
10
11 * xdisp.c (compute_stop_pos_backwards): New function.
12 (handle_stop_backwards): Revert last change.
13 (next_element_from_buffer): Call compute_stop_pos_backwards to
14 find a suitable prev_stop when we find ourselves before
15 base_level_stop. Remove the funky search for 1000 character
16 positions back.
17
e8c17b88
EZ
182011-07-19 Eli Zaretskii <eliz@gnu.org>
19
20 Fix a significant slow-down of vertical-motion when leaning on C-n
21 or C-p in a fontified buffer.
22 * xdisp.c (reseat): Don't look for prev_stop, as that could mean a
23 very long run.
24 (next_element_from_buffer): When iterator oversteps prev_pos
25 backwards, don't search for a new prev_stop more than 1000
26 characters back.
27 (handle_stop_backwards): Don't assume that CHARPOS is necessarily
28 a stop_pos.
29 (compute_display_string_pos): Check also BUF_OVERLAY_MODIFF for a
30 match, when testing the cached display string position for
31 applicability.
32
551918c1
EZ
332011-07-16 Eli Zaretskii <eliz@gnu.org>
34
35 * xdisp.c <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>:
36 Cache for last found display string position.
37 (compute_display_string_pos): Return the cached position if asked
38 about the same buffer.
39
c965adc5
EZ
402011-07-14 Eli Zaretskii <eliz@gnu.org>
41
42 * bidi.c (bidi_cache_fetch_state, bidi_cache_search)
43 (bidi_cache_find_level_change, bidi_cache_ensure_space)
44 (bidi_cache_iterator_state, bidi_cache_find)
45 (bidi_find_other_level_edge, bidi_cache_start_stack): All
46 variables related to cache indices are now EMACS_INT.
47
38556355
EZ
482011-07-09 Eli Zaretskii <eliz@gnu.org>
49
66ff7ddf
EZ
50 * bidi.c (bidi_fetch_char): Fix the type of `len' according to
51 what STRING_CHAR_AND_LENGTH expects.
52
38556355
EZ
53 * xdisp.c (move_it_in_display_line_to): Record prev_method and
54 prev_pos immediately before the call to set_iterator_to_next.
55 Fixes cursor motion in bidi-reordered lines with stretch glyphs
56 and strings displayed in margins. (Bug#8133) (Bug#8867)
57 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
58 TO_CHARPOS.
59 (pos_visible_p): Support positions in bidi-reordered lines. Save
60 and restore bidi cache.
61
622011-07-08 Eli Zaretskii <eliz@gnu.org>
63
64 * xdisp.c (move_it_in_display_line_to): If iterator ended up at
65 EOL, but we never saw any buffer positions smaller than
66 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
67 motion in bidi-reordered lines.
68
ad3c1639
EZ
692011-07-07 Eli Zaretskii <eliz@gnu.org>
70
71 * xdisp.c (find_row_edges): If ROW->start.pos gives position
72 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
73
57b3e30b
EZ
742011-07-05 Eli Zaretskii <eliz@gnu.org>
75
76 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
77 cache around display iteration.
78
79 * window.c (Fwindow_end, window_scroll_pixel_based)
80 (displayed_window_lines, Frecenter): Save and restore the bidi
81 cache around display iteration.
82
83 * bidi.c (bidi_unshelve_cache): Ensure we have enough space before
84 restoring the shelved cache.
85 (bidi_cache_ensure_space): Don't assume the required size is just
86 one BIDI_CACHE_CHUNK away.
87
88 * xdisp.c (back_to_previous_visible_line_start, reseat_1)
89 (init_iterator): Empty the bidi cache "stack".
90
ed94e6d7
EZ
912011-07-03 Eli Zaretskii <eliz@gnu.org>
92
93 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): New functions.
94
95 * dispextern.h (bidi_shelve_cache, bidi_unshelve_cache): Declare
96 prototypes.
97
98 * xdisp.c (SAVE_IT, RESTORE_IT): New macros.
99 (pos_visible_p, face_before_or_after_it_pos)
100 (back_to_previous_visible_line_start)
101 (move_it_in_display_line_to, move_it_in_display_line)
102 (move_it_to, move_it_vertically_backward, move_it_by_lines)
103 (try_scrolling, redisplay_window, display_line): Use them when
104 saving a temporary copy of the iterator and restoring it back.
105
a2eaa31d
EZ
1062011-07-02 Eli Zaretskii <eliz@gnu.org>
107
6eec7596 108 * xdisp.c (reseat_1): Call bidi_init_it to resync the bidi
ad3c1639 109 iterator with IT's position. (Bug#7616)
6eec7596
EZ
110 (handle_stop, back_to_previous_visible_line_start, reseat_1):
111 Reset the from_disp_prop_p flag.
112
113 * bidi.c (bidi_cache_search): Don't assume bidi_cache_last_idx is
114 always valid if bidi_cache_idx is valid.
115 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
116 is valid if it's going to be used.
117
a2eaa31d
EZ
118 * dispextern.h (struct iterator_stack_entry, struct it): New
119 member from_disp_prop_p.
120
121 * xdisp.c (push_it, pop_it): Save and restore from_disp_prop_p.
122 (handle_single_display_spec, push_display_prop): Set the
123 from_disp_prop_p flag.
124 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
125 (pop_it): Call iterate_out_of_display_property only if we are
126 popping after iteration over a string that came from a display
127 property. Fix a typo in popping stretch info. Add an assertion
128 for verifying that the iterator position is in sync with the bidi
129 iterator.
130 (handle_single_display_spec, get_overlay_strings_1)
131 (push_display_prop): Fix initialization of paragraph direction for
132 string when that of the parent object is not yet determined.
133
f3014ef5
EZ
1342011-07-01 Eli Zaretskii <eliz@gnu.org>
135
136 * dispextern.h (struct bidi_string_data): New member `unibyte'.
137
138 * xdisp.c (handle_single_display_spec, next_overlay_string)
139 (get_overlay_strings_1, reseat_1, reseat_to_string)
140 (push_display_prop): Set up the `unibyte' member of bidi_it.string
141 correctly. Don't assume unibyte strings are not bidi-reordered.
142 (compute_display_string_pos)
143 (compute_display_string_end): Fix handling the case of C string.
144
145 * bidi.c (bidi_count_bytes, bidi_char_at_pos): Accept an
146 additional argument UNIBYTE, and support unibyte strings. All
147 callers changed.
148 (bidi_fetch_char): Support unibyte strings.
149
0c22566f
EZ
1502011-06-25 Eli Zaretskii <eliz@gnu.org>
151
a1344e7d
EZ
152 * xdisp.c (set_iterator_to_next, get_visually_first_element): Use
153 it->bidi_it.string.schars rather than it->string_nchars when
154 testing whether we're beyond string end, because string_nchars is
155 zero for strings that come from overlays and display properties.
156
157 * bidi.c (bidi_cache_iterator_state): Fix a bug with testing
158 character positions against the cached range, when we use a
159 stacked cache.
160
161 * xdisp.c (push_it, pop_it): Save and restore it.
162
163 * dispextern.h (struct iterator_stack_entry): New member
164 paragraph_embedding.
165
0c22566f
EZ
166 * xdisp.c (handle_single_display_spec, next_overlay_string)
167 (get_overlay_strings_1, push_display_prop): Set up the bidi
168 iterator for displaying display or overlay strings.
169 (forward_to_next_line_start): Don't use the shortcut if
170 bidi-iterating.
171 (back_to_previous_visible_line_start): If handle_display_prop
172 pushed the iterator stack, restore the internal state of the bidi
173 iterator by calling bidi_pop_it same number of times.
174 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
175 and we are bidi-iterating, don't decrement the iterator position;
176 instead, set the first_elt flag in the bidi iterator, to produce
177 the same effect.
178 (reseat_1): Remove redundant setting of string_from_display_prop_p.
179 (push_display_prop): xassert that we are iterating a buffer.
180
181 * bidi.c (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
182
1832011-06-24 Eli Zaretskii <eliz@gnu.org>
184
185 * xdisp.c (push_it, pop_it): Save and restore the state of the
186 bidi iterator. Save and restore the bidi_p flag.
187 (pop_it): Iterate out of display property for string iteration as
188 well.
189 (iterate_out_of_display_property): Support iteration over strings.
190 (handle_single_display_spec): Set up it->bidi_it for iteration
191 over a display string, and call bidi_init_it.
192
193 * dispextern.h (struct iterator_stack_entry): New member bidi_p.
194 (struct it): Member bidi_p is now a bit field 1 bit wide.
195
58b9f433
EZ
1962011-06-23 Eli Zaretskii <eliz@gnu.org>
197
198 * dispextern.h (bidi_push_it, bidi_pop_it): Add prototypes.
199
200 * bidi.c (bidi_push_it, bidi_pop_it): New functions.
201 (bidi_initialize): Initialize the bidi cache start stack pointer.
202 (bidi_cache_ensure_space): New function, refactored from part of
203 bidi_cache_iterator_state.
204
40eb66c4
EZ
2052011-06-18 Eli Zaretskii <eliz@gnu.org>
206
acb28818
EZ
207 * xdisp.c (tool_bar_lines_needed, redisplay_tool_bar)
208 (display_menu_bar): Force left-to-right direction. Add a FIXME
209 comment for making that be controlled by a user option.
210
211 * bidi.c (bidi_move_to_visually_next): GCPRO the Lisp string we
212 are iterating.
213
ca3122a0
EZ
214 * term.c (produce_glyphs): Add IT_GLYPHLESS to the values of
215 it->what accepted by the xassert. Fixes a gratuitous crash in an
216 Emacs built with -DXASSERTS.
217
cc7245e4
EZ
218 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
219 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
220 and vector-like objects.
221
4d3a8bb4 222 * xdisp.c (face_before_or_after_it_pos): Support bidi iteration.
40eb66c4
EZ
223 (next_element_from_c_string): Handle the case of the first string
224 character that is not the first one in the visual order.
1ace7267
EZ
225 (get_visually_first_element): New function, refactored from common
226 parts of next_element_from_buffer, next_element_from_string, and
227 next_element_from_c_string.
40eb66c4 228
578b494e
EZ
2292011-06-16 Eli Zaretskii <eliz@gnu.org>
230
231 * xdisp.c (init_iterator): Don't initialize it->bidi_p for strings
232 here.
233 (reseat_to_string): Initialize it->bidi_p for strings here.
234 (next_element_from_string, next_element_from_c_string)
235 (next_element_from_buffer): Add xassert's for correspondence
236 between IT's object being iterated and it->bidi_it.string
237 structure.
238
239 * bidi.c (bidi_level_of_next_char): Fix the logic for looking up
240 the sentinel state in the cache.
241
9f257352
EZ
2422011-06-13 Eli Zaretskii <eliz@gnu.org>
243
244 * xdisp.c (compute_display_string_pos)
245 (compute_display_string_end, reseat_to_string): Don't assume
246 it->bidi_it.string.s always points to string.lstring's data.
247
248 * bidi.c (bidi_fetch_char, bidi_paragraph_init)
249 (bidi_resolve_explicit_1, bidi_resolve_explicit)
250 (bidi_resolve_weak, bidi_level_of_next_char): Don't assume
251 string.s always points to string.lstring's data.
252
f23590cc
EZ
2532011-06-11 Eli Zaretskii <eliz@gnu.org>
254
255 * xdisp.c (set_iterator_to_next): Advance string position
256 correctly when padding it with blanks.
257
4b988f8b
EZ
2582011-06-11 Eli Zaretskii <eliz@gnu.org>
259
260 * xdisp.c (next_element_from_buffer): Improve commentary for when
261 the iterator is before prev_stop.
34c48e57
EZ
262 (init_iterator): Initialize bidi_p from the default value of
263 bidi-display-reordering, not from buffer-local value. Use the
264 buffer-local value only if initializing for buffer iteration.
265 (handle_invisible_prop): Support invisible properties on strings
266 that are being bidi-reordered.
267 (reseat_to_string): Enable bidi-related code.
268 (set_iterator_to_next): Support bidi reordering of C strings and
269 Lisp strings.
270 (next_element_from_string): Support bidi reordering of Lisp
271 strings.
272 (handle_stop_backwards): Support Lisp strings as well.
273 (display_mode_line, display_mode_element): Temporarily force L2R
274 paragraph direction.
275 (display_string): Support display of R2L glyph rows. Use
276 IT_STRING_CHARPOS when displaying from a Lisp string.
4b988f8b 277
9f4ef500
EZ
2782011-06-10 Eli Zaretskii <eliz@gnu.org>
279
280 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
281 itb.string.lstring.
282 (compute_display_string_pos, compute_display_string_end):
283 Fix calculation of the object to scan. Fixes an error when using
284 arrow keys.
285 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
286 base_level_stop; instead, set base_level_stop to BEGV. Fixes
287 crashes in vertical-motion.
288
6db161be
EZ
2892011-06-09 Eli Zaretskii <eliz@gnu.org>
290
291 * xdisp.c (compute_display_string_pos): First arg is now struct
292 `text_pos *'; all callers changed. Support display properties on
293 Lisp strings.
294 (compute_display_string_end): Support display properties on Lisp
295 strings.
296 (init_iterator, reseat_1, reseat_to_string): Initialize the
297 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
298 when iterating on a string not from display properties).
299
300 * bidi.c (bidi_fetch_char): Support strings with display
301 properties.
302
303 * dispextern.h (struct bidi_string_data): New member bufpos.
304 (compute_display_string_pos): Update prototype.
305
bb269206
EZ
3062011-06-09 Eli Zaretskii <eliz@gnu.org>
307
308 * bidi.c (bidi_level_of_next_char): Allow the sentinel "position"
309 to pass the test for valid cached positions.
310
311 * xdisp.c (init_iterator): Call bidi_init_it only of a valid
312 buffer position was specified. Initialize paragraph_embedding to
313 L2R.
314 (reseat_to_string): Initialize the bidi iterator (for now ifdef'ed
315 out).
316 (display_string): If we need to ignore text properties of
317 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
318 original value of -1 will not work with bidi.)
319
320 * dispextern.h (struct bidi_string_data): New member lstring.
321
d9334cb7
EZ
3222011-06-09 Eli Zaretskii <eliz@gnu.org>
323
324 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
325 itb.string.s to NULL (avoids a crash in bidi_paragraph_init).
326
87e67904
EZ
3272011-06-08 Eli Zaretskii <eliz@gnu.org>
328
329 * bidi.c (bidi_paragraph_info): Delete unused struct.
330 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
331 (bidi_cache_start): New variable.
332 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
333 to zero.
334 (bidi_cache_fetch_state, bidi_cache_search)
335 (bidi_cache_find_level_change, bidi_cache_iterator_state)
336 (bidi_cache_find, bidi_peek_at_next_level)
337 (bidi_level_of_next_char, bidi_find_other_level_edge)
338 (bidi_move_to_visually_next): Compare cache index with
339 bidi_cache_start rather than with zero.
340 (bidi_fetch_char): Accept new argument STRING; all callers
341 changed. Support iteration over a string.
342 (bidi_paragraph_init, bidi_resolve_explicit_1)
343 (bidi_resolve_explicit, bidi_resolve_weak)
344 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
345 iteration over a string.
346 (bidi_set_sor_type, bidi_resolve_explicit_1)
347 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
348 can now be zero (for strings); special values 0 and -1 were
349 changed to -1 and -2, respectively.
350 (bidi_char_at_pos): New function.
351 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
352 Call it instead of FETCH_MULTIBYTE_CHAR.
353 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
354 initialized to valid values.
355 (bidi_init_it): Don't initialize charpos and bytepos with invalid
356 values.
357
358 * xdisp.c (compute_display_string_pos)
359 (compute_display_string_end): Accept additional argument STRING.
360 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
361 (reseat_to_string): Initialize bidi_it->string.s and
362 bidi_it->string.schars.
363
364 * dispextern.h (struct bidi_string_data): New structure.
365 (struct bidi_it): New member `string'. Make flag members be 1-bit
366 fields, and put them last in the struct.
367 (compute_display_string_pos, compute_display_string_end): Update
368 prototypes.
369
9d68c2a9
EZ
3702011-06-04 Eli Zaretskii <eliz@gnu.org>
371
372 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
373
57f97249
EZ
3742011-06-03 Eli Zaretskii <eliz@gnu.org>
375
376 * bidi.c (bidi_fetch_char_advance): Remove unused and
377 unimplemented function.
378
c40e2fb2
EZ
3792011-05-28 Eli Zaretskii <eliz@gnu.org>
380
0e14fe90
EZ
381 * xdisp.c (set_cursor_from_row): Set start and stop points
382 according to the row's direction when priming the loop that looks
383 for the glyph on which to display cursor.
384 (single_display_spec_intangible_p): Function deleted.
385 (display_prop_intangible_p): Reimplement to call
386 handle_display_spec instead of single_display_spec_intangible_p.
387 Accept 3 additional arguments needed by handle_display_spec. This
388 fixes incorrect cursor motion across display property with complex
389 values: lists, `(when COND...)' forms, etc.
390 (single_display_spec_string_p): Support property values that are
391 lists with the argument STRING its top-level element.
392 (display_prop_string_p): Fix the condition for processing a
393 property that is a list to be consistent with handle_display_spec.
394
395 * keyboard.c (adjust_point_for_property): Adjust the call to
396 display_prop_intangible_p to its new signature.
397
398 * dispextern.h (display_prop_intangible_p): Adjust prototype.
c40e2fb2 399
fc6f18ce
EZ
4002011-05-21 Eli Zaretskii <eliz@gnu.org>
401
402 * xdisp.c (handle_display_spec): New function, refactored from the
403 last portion of handle_display_prop.
404 (compute_display_string_pos): Accept additional argument
405 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
406 value of a `display' property is a "replacing spec".
407 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
408 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
409 the display property, but just return a value indicating whether
410 the display property will replace the characters it covers.
411 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
412 frame_window_p members of struct bidi_it.
413
414 * bidi.c (bidi_fetch_char): Accept additional argument
415 FRAME_WINDOW_P and pass it to compute_display_string_pos. All
416 callers changed.
417 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
418 it to initialize the frame_window_p member of struct bidi_it.
419
420 * dispextern.h (struct bidi_it): New member frame_window_p.
421 (bidi_init_it, compute_display_string_pos): Update prototypes.
422
102ebb00
EZ
4232011-05-14 Eli Zaretskii <eliz@gnu.org>
424
7b600102
EZ
425 * xdisp.c (compute_display_string_pos): Non-trivial implementation.
426 (compute_display_string_end): New function.
683a44f7
EZ
427 (push_it): Accept second argument POSITION, where pop_it should
428 jump to continue iteration.
7b600102
EZ
429
430 * dispextern.h (compute_display_string_end): Declare prototype.
431
432 * bidi.c (bidi_resolve_explicit_1): Use ZV for disp_pos.
433 (bidi_fetch_char): Implement support for runs of characters
434 covered by display strings.
435
102ebb00 436 * bidi.c (bidi_fetch_char): Accept also character position
7b600102
EZ
437 corresponding to BYTEPOS. DISP_POS is now a character position,
438 not a byte position. All callers changed.
102ebb00
EZ
439 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
440 (bidi_resolve_explicit, bidi_resolve_weak)
441 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
442 bidi_it->nchars is non-positive.
443 (bidi_level_of_next_char): Don't try to lookup the cache for the
444 next/previous character if nothing is cached there yet, or if we
445 were just reseat()'ed to a new position.
446 (bidi_paragraph_init, bidi_resolve_explicit_1)
447 (bidi_level_of_next_char): Fix arguments in the calls to
448 bidi_fetch_char.
449
182ce2d2
EZ
4502011-05-10 Eli Zaretskii <eliz@gnu.org>
451
452 * xdisp.c (compute_display_string_pos): New function.
453 (reseat_1): Initialize bidi_it.disp_pos.
454
455 * bidi.c (bidi_copy_it): Use offsetof.
456 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
457 (bidi_cache_search, bidi_cache_iterator_state)
458 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
459 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
460 character positions inside a run of characters covered by a
461 display string.
462 (bidi_paragraph_init, bidi_resolve_explicit_1)
463 (bidi_level_of_next_char): Call bidi_fetch_char and
464 bidi_fetch_char_advance instead of FETCH_CHAR and
465 FETCH_CHAR_ADVANCE.
466 (bidi_init_it): Initialize new members.
467 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
468 definitions.
469 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
470 instead of using explicit *_CHAR codes.
471 (bidi_resolve_explicit, bidi_resolve_weak): Use
472 FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
473 bidirectional text is supported only in multibyte buffers.
474
475 * dispextern.h (struct bidi_it): New members nchars and disp_pos.
476 ch_len is now EMACS_INT.
477 (compute_display_string_pos): Declare prototype.
478
57679c86
AS
4792011-05-09 Andreas Schwab <schwab@linux-m68k.org>
480
481 * w32menu.c (set_frame_menubar): Fix submenu allocation.
482
888c9e86
EZ
4832011-05-07 Eli Zaretskii <eliz@gnu.org>
484
b0512a1d
EZ
485 * w32console.c (Fset_screen_color): Doc fix.
486 (Fget_screen_color): New function.
487 (syms_of_ntterm): Defsubr it.
488
888c9e86
EZ
489 * callproc.c (call_process_cleanup): Don't close and unlink the
490 temporary file if Fcall_process didn't create it in the first
491 place.
492 (Fcall_process): Don't create tempfile if stdout of the child
493 process will be redirected to a file specified with `:file'.
494 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
495 cue to call_process_cleanup not to close that handle.
496
4d3fcc8e
BK
4972011-05-07 Ben Key <bkey76@gmail.com>
498
499 * makefile.w32-in: The bootstrap-temacs rule now makes use of
500 one of two shell specific rules, either bootstrap-temacs-CMD or
501 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
502 to the previous implementation of the bootstrap-temacs rule.
503 The bootstrap-temacs-CMD rule is similar to the previous
504 implementation of the bootstrap-temacs rule except that it
505 makes use of the ESC_CFLAGS variable instead of the CFLAGS
506 variable.
507
508 These changes, along with some changes to nt/configure.bat,
509 nt/gmake.defs, and nt/nmake.defs, are required to extend my
510 earlier fix to add support for --cflags and --ldflags options
511 that include quotes so that it works whether make uses cmd or
512 sh as the shell.
513
b4289b64
MA
5142011-05-06 Michael Albinus <michael.albinus@gmx.de>
515
516 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
517 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
518 is a constant.
519 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
520 a string. Handle both cases.
521 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
522 (Fdbus_register_method): Use Qinvalid_function.
523
af4c0e28
JB
5242011-05-06 Juanma Barranquero <lekktu@gmail.com>
525
526 * makefile.w32-in: Update dependencies.
527 (LISP_H): Add inttypes.h and stdin.h.
528 (PROCESS_H): Add unistd.h.
529
c51453d9
EZ
5302011-05-06 Eli Zaretskii <eliz@gnu.org>
531
532 * lread.c: Include limits.h (fixes the MS-Windows build broken by
533 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
534
8ff0ac3c 5352011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 536
4c4b566b
PE
537 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
538
aab2b9b5
PE
539 * term.c (vfatal): Remove stray call to va_end.
540 It's not needed and the C Standard doesn't allow it here anyway.
541
c378da0b
PE
542 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
543 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
544
288b08c7
PE
545 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
546 bytes.
547
e3601888
PE
548 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
549
db6c0e74
PE
550 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
551
dd5963ea
PE
552 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
553
88c9450f
PE
554 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
555
2f9442b8
PE
556 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
557
c032b5f8
PE
558 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
559 * charset.c (Fdefine_charset_internal): Don't initialize
560 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 561 32-bit int (Bug#8600).
a108c10b
PE
562
563 * lread.c (read_integer): Be more consistent with string-to-number.
564 Use string_to_number to do the actual conversion; this avoids
565 rounding errors and fixes some other screwups. Without this fix,
566 for example, #x1fffffffffffffff was misread as -2305843009213693952.
567 (digit_to_number): Move earlier, for benefit of read_integer.
568 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 569 not a digit in any supported base. (Bug#8602)
a108c10b 570
ad5f9eea
PE
571 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
572
aec1708a
PE
573 * dispnew.c (scrolling_window): Return 1 if we scrolled,
574 to match comment at start of function. This also removes a
575 GCC warning about overflow in a 32+64-bit port.
576
47be4ab5
PE
577 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
578
371cac43
PE
579 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
580 Reported by Stefan Monnier in
581 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
582 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages): Use
583 SYMBOLP-guarded XSYMBOL, not XPNTR.
584
d01a7826
PE
585 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
586 (EMACS_UINTPTR): Likewise, with uintptr_t.
587
7fd47d5c
PE
588 * lisp.h: Prefer 64-bit EMACS_INT if available.
589 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
590 on 32-bit hosts that have 64-bit int, so that they can access
591 large files.
122b0c86
PE
592 However, temporarily disable this change unless the temporary
593 symbol WIDE_EMACS_INT is defined.
7fd47d5c 594
8727937b
PE
595 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
596
8ac068ac
PE
597 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
598 This removes an assumption that EMACS_INT and long are the same
599 width as pointers. The assumption is true for Emacs porting targets
600 now, but we want to make other targets possible.
601 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
602 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
603 In the rest of the code, change types of integers that hold casted
604 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
605 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
606 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
607 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
608 No need to cast type when ORing.
609 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
610 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
611 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
612 assume EMACS_INT is the same width as char *.
613 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
614 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
615 Remove no-longer-needed casts.
616 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
617 (xg_tool_bar_help_callback, xg_make_tool_item):
618 Use EMACS_INTPTR to hold an integer
619 that will be cast to void *; this can avoid a GCC warning
620 if EMACS_INT is not the same width as void *.
621 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
622 * xdisp.c (display_echo_area_1, resize_mini_window_1):
623 (current_message_1, set_message_1):
624 Use a local to convert to proper width without a cast.
625 * xmenu.c (dialog_selection_callback): Likewise.
626
ede49d71
PE
627 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
628 Also, don't assume VALBITS / RAND_BITS is less than 5,
629 and don't rely on undefined behavior when shifting a 1 left into
630 the sign bit.
631 * lisp.h (get_random): Change signature to match.
632
2f30ecd0
PE
633 * lread.c (hash_string): Use size_t, not int, for hash computation.
634 Normally we prefer signed values; but hashing is special, because
635 it's better to use unsigned division on hash table sizes so that
636 the remainder is nonnegative. Also, size_t is the natural width
637 for hashing into memory. The previous code used 'int', which doesn't
638 retain enough info to hash well into very large tables.
639 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
640
2a866e7b
PE
641 * dbusbind.c: Don't possibly lose pointer info when converting.
642 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
643 Use XPNTR rather than XHASH, so that the high-order bits of
644 the pointer aren't lost when converting through void *.
645
51639eac
PE
646 * eval.c (Fautoload): Don't double-shift a pointer.
647
92394119
PE
648 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
649
dbdb9a7c
JB
6502011-05-06 Juanma Barranquero <lekktu@gmail.com>
651
652 * gnutls.c (DEF_GNUTLS_FN):
653 * image.c (DEF_IMGLIB_FN): Make function pointers static.
654
db7a0b4f
AS
6552011-05-05 Andreas Schwab <schwab@linux-m68k.org>
656
657 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
658 marker. (Bug#8610)
659
f7ff1b0f 6602011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
661
662 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
663 New version that can reserve upto 2GB of heap space.
664
f7ff1b0f 6652011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
666
667 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
668
639c109b
TZ
6692011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
670
671 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
672 `gnutls_certificate_set_x509_key_file'.
673
d2127135
JB
6742011-05-05 Juanma Barranquero <lekktu@gmail.com>
675
676 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
677 Update dependencies.
678
e968f4f3
JB
6792011-05-04 Juanma Barranquero <lekktu@gmail.com>
680
681 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
682 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
683 Remove unused parameter `fildes'.
684 * process.c (read_process_output, send_process): Don't pass it.
685
84d358f0
JB
6862011-05-04 Juanma Barranquero <lekktu@gmail.com>
687
688 Fix previous change: the library cache is defined in w32.c.
689 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
690 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
691
0898ca10
JB
6922011-05-04 Juanma Barranquero <lekktu@gmail.com>
693
694 Implement dynamic loading of GnuTLS on Windows.
695
696 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
697 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
698 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
699 Declare.
700
701 * gnutls.c (Qgnutls_dll): Define.
702 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
703 (gnutls_*): Declare function pointers.
704 (init_gnutls_functions): New function to initialize function pointers.
705 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
706 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
707 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
708 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
709 (emacs_gnutls_write, emacs_gnutls_read)
710 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
711 (Fgnutls_available_p): New function.
712 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
713 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
714 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
715
716 * image.c: Include w32.h.
717 (Vimage_type_cache): Delete.
718 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
719 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
720 (w32_delayed_load): Move to w32.c.
721
722 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
723
724 * w32.c (QCloaded_from, Vlibrary_cache): Define.
725 (w32_delayed_load): Move from image.c. When loading a library, record
726 its filename in the :loaded-from property of the library id.
727 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
728 Initialize and staticpro them.
729 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
730
731 * process.c: Include lisp.h before w32.h, not after.
732 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
733 instead of gnutls_record_check_pending.
734
735 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
736
ff4de4aa
TZ
7372011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
738
739 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
740 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
741 as passed in.
742
abe95abb
JD
7432011-05-03 Jan Djärv <jan.h.d@swipnet.se>
744
745 * xterm.c (x_set_frame_alpha): Do not set property on anything
746 else than FRAME_X_OUTER_WINDOW (Bug#8608).
747
e16e55d4
JB
7482011-05-02 Juanma Barranquero <lekktu@gmail.com>
749
750 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
751
bafcf6a5
JB
7522011-05-02 Juanma Barranquero <lekktu@gmail.com>
753
754 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
755 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
756 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
757 (gnutls_global_initialized, Qgnutls_bootprop_priority)
758 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
759 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
760 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
761 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
762 (Qgnutls_bootprop_callbacks_verify): Make static.
763
e7a6747f
AS
7642011-05-01 Andreas Schwab <schwab@linux-m68k.org>
765
19ed11ba
AS
766 * callproc.c: Indentation fixup.
767
e7a6747f
AS
768 * sysdep.c (wait_for_termination_1): Make static.
769 (wait_for_termination, interruptible_wait_for_termination): Move
770 after wait_for_termination_1.
771
1ef14cb4
LMI
7722011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
773
774 * sysdep.c (interruptible_wait_for_termination): New function
775 which is like wait_for_termination, but allows keyboard
776 interruptions.
777
778 * callproc.c (Fcall_process): Add (:file "file") as an option for
779 the STDOUT buffer.
780 (Fcall_process_region): Ditto.
781
330d880c
EZ
7822011-04-30 Eli Zaretskii <eliz@gnu.org>
783
8db90b73
EZ
784 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
785 rather than `XVECTOR (FOO)->size'.
786
330d880c
EZ
787 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
788 inttypes.h, as a gnulib replacement is used if it not available in
789 system headers.
790
15cbd324
EZ
7912011-04-21 Eli Zaretskii <eliz@gnu.org>
792
793 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
794 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
795 of MOST_POSITIVE_FIXNUM. (Bug#8528)
796
797 * coding.c (coding_alloc_by_realloc): Error out if destination
798 will grow beyond MOST_POSITIVE_FIXNUM.
799 (decode_coding_emacs_mule): Abort if there isn't enough place in
800 charbuf for the composition carryover bytes. Reserve an extra
801 space for up to 2 characters produced in a loop.
802 (decode_coding_iso_2022): Abort if there isn't enough place in
803 charbuf for the composition carryover bytes.
804
8052011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 806
ae940cca
EZ
807 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
808 aborting when %lld or %lll format is passed.
809 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
810 %llo or %llx format is passed. (Bug#8545)
811
03ab8921
EZ
812 * window.c (window_scroll_line_based): Use a marker instead of
813 simple variables to record original value of point. (Bug#7952)
814
afda1437
EZ
815 * doprnt.c (doprnt): Fix the case where a multibyte sequence
816 produced by %s or %c overflows available buffer space. (Bug#8545)
817
f76dee0c
PE
8182011-04-28 Paul Eggert <eggert@cs.ucla.edu>
819
820 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 821 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 822
fdc5744d
JB
8232011-04-28 Juanma Barranquero <lekktu@gmail.com>
824
825 * w32.c (init_environment): Warn about defaulting HOME to C:\.
826
638f053a
JB
8272011-04-28 Juanma Barranquero <lekktu@gmail.com>
828
829 * keyboard.c (Qdelayed_warnings_hook): Define.
830 (command_loop_1): Run `delayed-warnings-hook'
831 if Vdelayed_warnings_list is non-nil.
832 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
833 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
834
d178f871
EZ
8352011-04-28 Eli Zaretskii <eliz@gnu.org>
836
837 * doprnt.c (doprnt): Don't return value smaller than the buffer
838 size if the message was truncated. (Bug#8545).
839
b124fd93
JB
8402011-04-28 Juanma Barranquero <lekktu@gmail.com>
841
842 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
843 (Fx_window_property): #if-0 the whole functions, not just the bodies.
844
e810457d
PE
8452011-04-27 Paul Eggert <eggert@cs.ucla.edu>
846
847 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
848
ea51cceb
JB
8492011-04-27 Juanma Barranquero <lekktu@gmail.com>
850
851 * makefile.w32-in: Update dependencies.
852
94dcfacf
EZ
8532011-04-27 Eli Zaretskii <eliz@gnu.org>
854
855 Improve `doprnt' and its usage. (Bug#8545)
856 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
857 `format_end'. Remove support for %l as a conversion specifier.
858 Don't use xrealloc. Improve diagnostics when the %l size modifier
859 is used. Update the commentary.
860
861 * eval.c (verror): Simplify calculation of size_t.
862
863 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
864 messages.
865
f61f41d7
PE
8662011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
867
868 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
869 change.
870
96fb4434
PE
8712011-04-27 Paul Eggert <eggert@cs.ucla.edu>
872
873 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
874 This makes this file independent of the recent pseudovector change.
875
671875da 8762011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 877
69e9b5a3
PE
878 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
879
b5f869a7 880 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 881 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 882 Remove unused local.
c8926152 883 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 884
841a1577 885 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
eab3844f
PE
886 GCC 4.6.0 optimizes based on type-based alias analysis. For
887 example, if b is of type struct buffer * and v of type struct
888 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
889 != &v->size, and therefore "v->size = 1; b->size = 2; return
890 v->size;" must therefore return 1. This assumption is incorrect
891 for Emacs, since it type-puns struct Lisp_Vector * with many other
892 types. To fix this problem, this patch adds a new type struct
f904488f 893 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
894 and pseudovectors, and helps optimizing compilers not get fooled
895 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
896 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
897 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
898 the size member.
eab3844f
PE
899 (XSETPVECTYPE): Rewrite in terms of new macro.
900 (XSETPVECTYPESIZE): New macro, specifying both type and size.
901 This is a bit clearer, and further avoids the possibility of
902 undesirable aliasing.
903 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 904 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
905 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
906 since Lisp_Subr is a special case (no "next" field).
f904488f
PE
907 (ASIZE): Now uses header.size rather than size. All
908 previous uses of XVECTOR (foo)->size replaced to use this macro,
909 to avoid the hassle of writing XVECTOR (foo)->header.size.
910 (struct vectorlike_header): New type.
eab3844f
PE
911 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
912 object, to help avoid aliasing.
913 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
914 (SUBRP): Likewise, since Lisp_Subr is a special case.
915 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
916 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
917 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 918 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
919 changed to be "header.size" and "header.next".
920 * buffer.h (struct buffer): Likewise.
921 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
922 * frame.h (struct frame): Likewise.
923 * process.h (struct Lisp_Process): Likewise.
924 * termhooks.h (struct terminal): Likewise.
925 * window.c (struct save_window_data, struct saved_window): Likewise.
926 * window.h (struct window): Likewise.
927 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
928 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
929 * buffer.c (init_buffer_once): Likewise.
930 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
931 special case.
932 * process.c (Fformat_network_address): Use local var for size,
933 for brevity.
934
0df1eac5
PE
935 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
936
847ab9d1 937 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
938 * data.c (atof): Remove decl; no longer used or needed.
939 (digit_to_number): Move to lread.c.
940 (Fstring_to_number): Use new string_to_number function, to be
941 consistent with how the Lisp reader treats infinities and NaNs.
942 Do not assume that floating-point numbers represent EMACS_INT
943 without losing information; this is not true on most 64-bit hosts.
944 Avoid double-rounding errors, by insisting on integers when
945 parsing non-base-10 numbers, as the documentation specifies.
946 * lisp.h (string_to_number): New decl, replacing ...
947 (isfloat_string): Remove.
bc0a5c13 948 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 949 (read1): Do not accept +. and -. as integers; this
452f4150
PE
950 appears to have been a coding error. Similarly, do not accept
951 strings like +-1e0 as floating point numbers. Do not report
952 overflow for integer overflows unless the base is not 10 which
953 means we have no simple and reliable way to continue.
954 Break out the floating-point parsing into a new
955 function string_to_number, so that Fstring_to_number parses
956 floating point numbers consistently with the Lisp reader.
957 (digit_to_number): Moved here from data.c. Make it static inline.
958 (E_CHAR, EXP_INT): Remove, replacing with ...
959 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
960 (string_to_number): New function, replacing isfloat_string.
961 This function checks for valid syntax and produces the resulting
962 Lisp float number too. Rework it so that string-to-number
bc0a5c13 963 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
964 so that overflow for non-base-10 numbers is reported only when
965 there's no portable and simple way to convert to floating point.
452f4150 966
67769ffc
PE
967 * textprop.c (set_text_properties_1): Rewrite for clarity,
968 and to avoid GCC warning about integer overflow.
969
c20db43f
PE
970 * intervals.h (struct interval): Use EMACS_INT for members
971 where EMACS_UINT might cause problems. See
972 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
973 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
974 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
975 All uses changed.
37aa2f85
PE
976 (offset_intervals): Tell GCC not to worry about length overflow
977 when negating a negative length.
c20db43f 978
2538aa2f
PE
979 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
980 (overrun_check_free): Likewise.
981
f2d3008d
PE
982 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
983 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
984 word size.
985
ec8df744
PE
986 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
987 (gnutls_make_error): Rename local to avoid shadowing.
988 (gnutls_emacs_global_deinit): ifdef out; not used.
989 (Fgnutls_boot): Use const for pointer to readonly storage.
990 Comment out unused local. Fix pointer signedness problems.
991
640ee02d
PE
992 * lread.c (openp): Don't stuff size_t into an 'int'.
993 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
994 about possible signed overflow.
995
6048fb2a
PE
996 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
997 (GDK_KEY_g): Don't define if already defined.
998 (xg_prepare_tooltip): Avoid pointer signedness problem.
999 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1000
fa3c87e1
PE
1001 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1002 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1003
2172544b
PE
1004 * xfns.c (Fx_window_property): Simplify a bit,
1005 to make a bit faster and to avoid GCC 4.6.0 warning.
1006 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1007
9b821a21
PE
1008 * fns.c (internal_equal): Don't assume size_t fits in int.
1009
3c616cfa
PE
1010 * alloc.c (compact_small_strings): Tighten assertion a little.
1011
c2982e87
PE
1012 Replace pEd with more-general pI, and fix some printf arg casts.
1013 * lisp.h (pI): New macro, generalizing old pEd macro to other
1014 conversion specifiers. For example, use "...%"pI"d..." rather
1015 than "...%"pEd"...".
1016 (pEd): Remove. All uses replaced with similar uses of pI.
1017 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1018 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1019 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1020 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1021 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1022 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1023 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1024 64-bit hosts.
1025 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1026 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1027 * print.c (safe_debug_print, print_object): Likewise.
1028 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1029 to int.
6f04d126
PE
1030 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1031 avoiding the 0 flag, which is not portable.
c2982e87
PE
1032 * process.c (Fmake_network_process): Use pI to avoid cast.
1033 * region-cache.c (pp_cache): Likewise.
1034 * xdisp.c (decode_mode_spec): Likewise.
1035 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1036 behavior on 64-bit hosts with printf arg.
6f04d126 1037 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1038 (x_stop_queuing_selection_requests): Likewise.
1039 (x_get_window_property): Don't truncate byte count to an 'int'
1040 when tracing.
0b432f21 1041
5e073ec7
PE
1042 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1043 here, since it parses constructs like leading '-' and spaces,
1044 which are not wanted; and it overflows with large numbers.
1045 Instead, simply match F[0-9]+, which is what is wanted anyway.
1046
36372bf9
PE
1047 * alloc.c: Remove unportable assumptions about struct layout.
1048 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1049 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1050 (allocate_vectorlike, make_pure_vector): Use the new macros,
1051 plus offsetof, to remove unportable assumptions about struct layout.
1052 These assumptions hold on all porting targets that I know of, but
1053 they are not guaranteed, they're easy to remove, and removing them
1054 makes further changes easier.
1055
0b432f21
PE
1056 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1057 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1058 (string_overrun_cookie): Now const. Use initializers that
1059 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1060 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1061 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1062 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1063 multiple of sizeof (EMACS_INT); it need not be, if
1064 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1065 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1066
895009e1
JB
10672011-04-26 Juanma Barranquero <lekktu@gmail.com>
1068
1069 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1070
6a7a1b0b
TZ
10712011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1072
1073 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1074 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1075 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1076
841a1577 10772011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1078
1079 * lisp.h (Qdebug): List symbol.
895009e1 1080 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1081 * keyboard.c (debug-on-event): New variable.
1082 (handle_user_signal): Break into debugger when debug-on-event
1083 matches the current signal symbol.
1084
f2d3ba6f
DN
10852011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1086
1087 * alloc.c (check_sblock, check_string_bytes)
1088 (check_string_free_list): Convert to standard C.
1089
42ce4c63
TZ
10902011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1091
1092 * w32.c (emacs_gnutls_push): Fix typo.
1093
825cd63c
EZ
10942011-04-25 Eli Zaretskii <eliz@gnu.org>
1095
fb11d64d
EZ
1096 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1097 "cast to pointer from integer of different size".
1098
825cd63c
EZ
1099 Improve doprnt and its use in verror. (Bug#8545)
1100 * doprnt.c (doprnt): Document the set of format control sequences
1101 supported by the function. Use SAFE_ALLOCA instead of always
1102 using `alloca'.
1103
1104 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1105 is one byte too soon. Don't use xrealloc; instead xfree and
1106 xmalloc anew.
1107
e061a11b
TZ
11082011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1109
1110 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1111 callbacks stage.
1112
1113 * gnutls.c: Renamed global_initialized to
1114 gnutls_global_initialized. Added internals for the
1115 :verify-hostname-error, :verify-error, and :verify-flags
1116 parameters of `gnutls-boot' and documented those parameters in the
1117 docstring. Start callback support.
1118 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1119 unless a fatal error occured. Call gnutls_alert_send_appropriate
1120 on error. Return error code.
1121 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1122 (emacs_gnutls_read): Likewise.
1123 (Fgnutls_boot): Return handshake error code.
1124 (emacs_gnutls_handle_error): New function.
1125 (wsaerror_to_errno): Likewise.
1126
1127 * w32.h (emacs_gnutls_pull): Add prototype.
1128 (emacs_gnutls_push): Likewise.
1129
1130 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1131 (emacs_gnutls_push): Likewise.
1132
11332011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1134
1135 * process.c (wait_reading_process_output): Check if GnuTLS
1136 buffered some data internally if no FDs are set for TLS
1137 connections.
1138
1139 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1140 (LIBS): Link to USER_LIBS.
1141 ($(BLD)/gnutls.$(0)): New target.
1142
fa6996bc
EZ
11432011-04-24 Eli Zaretskii <eliz@gnu.org>
1144
eb35682e
EZ
1145 * xdisp.c (handle_single_display_spec): Rename the
1146 display_replaced_before_p argument into display_replaced_p, to
1147 make it consistent with the commentary. Fix typos in the
1148 commentary.
1149
e2ad650c
EZ
1150 * textprop.c (syms_of_textprop): Remove dead code.
1151 (copy_text_properties): Delete obsolete commentary about an
1152 interface that was deleted long ago. Fix typos in the description
1153 of arguments.
1154
1b2de274
EZ
1155 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1156 to changes in oldXMenu/XMenu.h from 2011-04-16.
1157 <menu_help_message, prev_menu_help_message>: Constify.
1158 (IT_menu_make_room): menu->help_text is now `const char **';
1159 adjust.
1160
1161 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1162 to changes in oldXMenu/XMenu.h from 2011-04-16.
1163 (struct XMenu): Declare `help_text' `const char **'.
1164
1165 * xfaces.c <Qunspecified>: Make extern again.
1166
1167 * syntax.c: Include sys/types.h before including regex.h, as
1168 required by Posix.
1169
762b15be
EZ
1170 * doc.c (get_doc_string): Improve the format passed to `error'.
1171
1172 * doprnt.c (doprnt): Improve commentary.
1173
1174 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1175
1176 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1177 them with etags.
1178
f1052e5d
EZ
1179 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1180 changes in globals.h immediately force recompilation.
762b15be
EZ
1181 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1182 $(CURDIR)/s/ms-w32.h.
1183 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1184
fa6996bc
EZ
1185 * character.c (Fchar_direction): Function deleted.
1186 (syms_of_character): Don't defsubr it.
1187 <char-direction-table>: Deleted.
1188
e6c3da20
EZ
11892011-04-23 Eli Zaretskii <eliz@gnu.org>
1190
1191 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1192 * doprnt.c: Include limits.h.
1193 (SIZE_MAX): New macro.
1194 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
1195 local variables are now size_t instead of int or unsigned.
1196 Improve overflow protection. Support `l' modifier for integer
1197 conversions. Support %l conversion. Don't assume an EMACS_INT
1198 argument for integer conversions and for %c.
1199
1200 * lisp.h (doprnt): Restore prototype.
1201
1202 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1203 $(SRC)/character.h.
1204
1205 * Makefile.in (base_obj): Add back doprnt.o.
1206
1207 * deps.mk (doprnt.o): Add back prerequisites.
1208 (callint.o): Depend on character.h.
1209
1210 * eval.c (internal_lisp_condition_case): Include the handler
1211 representation in the error message.
1212 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1213 when breaking from the loop.
1214
1215 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1216
1217 * callint.c (Fcall_interactively): When displaying error message
1218 about invalid control letter, pass the character's codepoint, not
1219 a pointer to its multibyte form. Improve display of the character
1220 in octal and display also its hex code.
1221
1222 * character.c (char_string): Use %x to display the (unsigned)
1223 codepoint of an invalid character, to avoid displaying a bogus
1224 negative value.
1225
1226 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1227 `error', not SYMBOL_NAME itself.
1228
1229 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1230 character arguments to `error'.
1231
1232 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1233 to `error' in error message about FINAL_CHAR argument. Make sure
1234 FINAL_CHAR is a character, and use %c when it is passed as
1235 argument to `error'.
1236
4ffd0d6b 12372011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1238
1239 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1240
1241 * w32.c: Include <time.h>.
1242 (sys_localtime): New function.
1243
4ffd0d6b 12442011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1245
1246 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1247
4ffd0d6b 1248 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1249
4ffd0d6b 12502011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1251
4ffd0d6b
GM
1252 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1253 zombies (Bug#8467).
aac0c6e3 1254
04c56954
EZ
12552011-04-19 Eli Zaretskii <eliz@gnu.org>
1256
1257 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1258 gl_state.e_property when gl_state.object is Qt.
1259
1260 * insdel.c (make_gap_larger): Remove limitation of buffer size
1261 to <= INT_MAX.
1262
16a43933
CY
12632011-04-18 Chong Yidong <cyd@stupidchicken.com>
1264
1265 * xdisp.c (lookup_glyphless_char_display)
1266 (produce_glyphless_glyph): Handle cons cell entry in
1267 glyphless-char-display.
1268 (Vglyphless_char_display): Document it.
1269
1270 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1271 glyphless-char-display.
1272
4581706e
CY
12732011-04-17 Chong Yidong <cyd@stupidchicken.com>
1274
1275 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1276
1277 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1278
1279 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1280 definition for no-X builds.
1281
4887c6e2 12822011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1283
fd35b6f9
PE
1284 Static checks with GCC 4.6.0 and non-default toolkits.
1285
5c1ccb01
PE
1286 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1287
006c5daa
PE
1288 * process.c (keyboard_bit_set): Define only if SIGIO.
1289 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1290 (send_process): Repair possible setjmp clobbering.
1291
efc736d3
PE
1292 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1293
4e2fe2e6
PE
1294 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1295
f97334a2
PE
1296 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1297
4e75f29d
PE
1298 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1299 Define only if needed.
1300
90efadd1
PE
1301 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1302 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1303 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1304
3c647824
PE
1305 * dispextern.h (struct redisplay_interface): Rename param
1306 to avoid shadowing.
e264f262 1307 * termhooks.h (struct terminal): Likewise.
761383f4 1308 * xterm.c (xembed_send_message): Likewise.
3c647824 1309
b58c5c4a
PE
1310 * insdel.c (make_gap_smaller): Define only if
1311 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1312
cad59032
PE
1313 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1314 it.
1315
c339dc2e
PE
1316 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1317 so that we aren't warned about unused symbols.
1318
91a3e27b
PE
1319 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1320
399c71d3 1321 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1322
8ffc96f5
PE
1323 * xfns.c (x_real_positions): Mark locals as initialized.
1324
eef9bc79
PE
1325 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1326
098db9dd
PE
1327 * xterm.c: Fix problems found by static analysis with other toolkits.
1328 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1329 (x_dispatch_event): Declare static if USE_GTK, and
1330 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1331 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1332 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1333 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1334 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1335
eb18f6cc
PE
1336 * xmenu.c (menu_help_callback): Pointer type fixes.
1337 Use const pointers when pointing at readonly data. Avoid pointer
1338 signedness clashes.
1339 (FALSE): Remove unused macro.
1340 (update_frame_menubar): Remove unused decl.
1341
1fe72bf8
PE
1342 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1343
60d9e1db
PE
1344 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1345 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1346 (single_menu_item): Rename local to avoid shadowing.
1347
39261c26
PE
1348 * keyboard.c (make_lispy_event): Remove unused local var.
1349
018c5e19
PE
1350 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1351 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1352
63d2b86e
PE
1353 * bitmaps: Change bitmaps from unsigned char back to the X11
1354 compatible char. Avoid the old compiler warnings about
1355 out-of-range initializers by using, for example, '\xab' rather
1356 than 0xab.
1357
aefd87e1
PE
1358 * xgselect.c (xgselect_initialize): Check vs interface
1359 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1360
bf501fb9
PE
1361 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1362
e9829fdf
PE
1363 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1364 to read-only memory.
1365
1086c095
PE
1366 * fns.c (vector): Remove; this old hack is no longer needed.
1367
2baccd04 1368 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1369 Remove unused var.
dde42981 1370 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1371
72391843 1372 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1373
436c16df 1374 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1375 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1376 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1377
92bb796d 1378 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1379 (x_term_init): Remove local to avoid shadowing.
92bb796d 1380
764430a3 1381 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1382
1383 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1384 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1385
d1dfb56c
EZ
13862011-04-16 Eli Zaretskii <eliz@gnu.org>
1387
c4354cb4
EZ
1388 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1389
d1dfb56c
EZ
1390 Fix regex.c, syntax.c and friends for buffers > 2GB.
1391 * syntax.h (struct gl_state_s): Declare character position members
1392 EMACS_INT.
1393
1394 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1395
1396 * textprop.c (verify_interval_modification, interval_of): Declare
1397 arguments EMACS_INT.
1398
1399 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1400 EMACS_INT.
1401
1402 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1403
1404 * indent.c (Fvertical_motion): Local variable it_start is now
1405 EMACS_INT.
1406
1407 * regex.c (re_match, re_match_2, re_match_2_internal)
1408 (bcmp_translate, regcomp, regexec, print_double_string)
1409 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1410 (re_compile_pattern, re_exec): Declare arguments and local
1411 variables `size_t' and `ssize_t' and return values `regoff_t', as
1412 appropriate.
1413 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1414 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1415 <compile_stack_type>: `size' and `avail' are now `size_t'.
1416
1417 * regex.h <regoff_t>: Use ssize_t, not int.
1418 (re_search, re_search_2, re_match, re_match_2): Arguments that
1419 specify buffer/string position and length are now ssize_t and
1420 size_t. Return type is regoff_t.
1421
613052cd
BK
14222011-04-16 Ben Key <bkey76@gmail.com>
1423
1424 * nsfont.m: Fixed bugs in ns_get_family and
1425 ns_descriptor_to_entity that were caused by using free to
1426 deallocate memory blocks that were allocated by xmalloc (via
1427 xstrdup). This caused Emacs to crash when compiled with
1428 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1429 --enable-checking=xmallocoverrun). xfree is now used to
1430 deallocate these memory blocks.
1431
4170f62f 14322011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1433
71b41406
PE
1434 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1435
9587a89d
PE
1436 emacs_write: Accept and return EMACS_INT for sizes.
1437 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1438 et seq.
1439 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1440 Accept and return EMACS_INT.
1441 (emacs_gnutls_write): Return the number of bytes written on
1442 partial writes.
1443 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1444 (emacs_read, emacs_write): Remove check for negative size, as the
1445 Emacs source code has been audited now.
9587a89d
PE
1446 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1447 (emacs_read, emacs_write): Use it.
273a5f82
PE
1448 * process.c (send_process): Adjust to the new signatures of
1449 emacs_write and emacs_gnutls_write. Do not attempt to store
1450 a byte offset into an 'int'; it might overflow.
9587a89d 1451 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1452
3e047f51
PE
1453 * sound.c: Don't assume sizes fit in 'int'.
1454 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1455 Return EMACS_INT, not int.
3e047f51 1456 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1457 Accept EMACS_INT, not int.
1458 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1459 record read return values.
1460
cc39a9db
BK
14612011-04-15 Ben Key <bkey76@gmail.com>
1462
c9d0ec6d
JB
1463 * keyboard.c (Qundefined): Don't declare static since it is used
1464 in nsfns.m.
1465 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1466 static since they are used in nsfont.m.
cc39a9db 1467
6c60eb9f
SM
14682011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1469
1470 * process.c (Qprocessp): Don't declare static.
1471 * lisp.h (Qprocessp): Declare again.
1472
7990b61a
JB
14732011-04-15 Juanma Barranquero <lekktu@gmail.com>
1474
1475 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1476
5d4cb038
PE
14772011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1478
8bd7b830 1479 Improve C-level modularity by making more things 'static'.
cd64ea1d 1480
e3b27b31
PE
1481 Don't publish debugger-only interfaces to other modules.
1482 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1483 (verify_bytepos, count_markers): Move decls to the only modules
1484 that need them.
1485 * region-cache.h (pp_cache): Likewise.
1486 * window.h (check_all_windows): Likewise.
1487 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1488
5d4cb038
PE
1489 * sysdep.c (croak): Now static, if
1490 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1491 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1492
1493 * alloc.c (refill_memory_reserve): Now static if
1494 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1495 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1496
e87b6180
PE
1497 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1498 Define only if USE_LUCID.
1499
ac64929e
PE
1500 * xrdb.c (x_customization_string, x_rm_string): Now static.
1501
6f37259d
PE
1502 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1503 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1504
1683e3ab
PE
1505 * xdisp.c (draw_row_with_mouse_face): Now static.
1506 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1507
de9c2632
PE
1508 * window.h (check_all_windows): Mark externally visible.
1509
2b96acb7
PE
1510 * window.c (window_deletion_count): Now static.
1511
1512 * undo.c: Make symbols static if they're not exported.
1513 (last_undo_buffer, last_boundary_position, pending_boundary):
1514 Now static.
1515
50436f33
PE
1516 * textprop.c (interval_insert_behind_hooks): Now static.
1517 (interval_insert_in_front_hooks): Likewise.
1518
64520e5c
PE
1519 * term.c: Make symbols static if they're not exported.
1520 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1521 (max_frame_lines, tty_set_terminal_modes):
1522 (tty_reset_terminal_modes, tty_turn_off_highlight):
1523 (get_tty_terminal): Now static.
1524 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1525 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1526 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1527 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1528 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1529
1fa53021
PE
1530 * sysdep.c: Make symbols static if they're not exported.
1531 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1532 Now static.
1533 (sigprocmask_set, full_mask): Remove; unused.
1534 (wait_debugging): Mark as visible.
1535 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1536 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1537
d4b43b22
PE
1538 * syntax.c (syntax_temp): Define only if !__GNUC__.
1539
b7c513d0
PE
1540 * sound.c (current_sound_device, current_sound): Now static.
1541
989b29ad
PE
1542 * search.c (searchbufs, searchbuf_head): Now static.
1543
13a55a78
PE
1544 * scroll.c (scroll_cost): Remove; unused.
1545 * dispextern.h (scroll_cost): Remove decl.
1546
de68a1fc
PE
1547 * region-cache.h (pp_cache): Mark as externally visible.
1548
40ccffa6
PE
1549 * process.c: Make symbols static if they're not exported.
1550 (process_tick, update_tick, create_process, chan_process):
1551 (Vprocess_alist, proc_buffered_char, datagram_access):
1552 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1553 (deactivate_process): Mark defn as static, as well as decl.
1554 * lisp.h (create_process): Remove decl.
1555 * process.h (chan_process, Vprocess_alist): Remove decls.
1556
ad64fc97
PE
1557 * print.c: Make symbols static if they're not exported.
1558 (print_depth, new_backquote_output, being_printed, print_buffer):
1559 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1560 (print_interval, print_number_index, initial_stderr_stream):
1561 Now static.
1562 * lisp.h (Fprinc): Remove decl.
1563 (debug_output_compilation_hack): Mark as externally visible.
1564
adddb265
PE
1565 * sysdep.c (croak): Move decl from here to syssignal.h.
1566 * syssignal.h (croak): Put it here, so the API can be checked when
1567 'croak' is called from dissociate_if_controlling_tty.
1568
1717ede2
PE
1569 * minibuf.c: Make symbols static if they're not exported.
1570 (minibuf_save_list, choose_minibuf_frame): Now static.
1571 * lisp.h (choose_minibuf_frame): Remove decl.
1572
fa5fb2bc
PE
1573 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1574
1e3890d1
PE
1575 * lread.c: Make symbols static if they're not exported.
1576 (read_objects, initial_obarray, oblookup_last_bucket_number):
1577 Now static.
1578 (make_symbol): Remove; unused.
1579 * lisp.h (initial_obarray, make_symbol): Remove decls.
1580
8a1414fa
PE
1581 * keyboard.c: Make symbols static if they're not exported.
1582 (single_kboard, recent_keys_index, total_keys, recent_keys):
1583 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1584 (this_single_command_key_start, echoing, last_auto_save):
1585 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1586 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1587 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1588 (Vlispy_mouse_stem, double_click_count):
1589 Now static.
1590 (force_auto_save_soon): Define only if SIGDANGER.
1591 (ignore_mouse_drag_p): Now static if
1592 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1593 (print_help): Remove; unused.
1594 (stop_character, last_timer_event): Mark as externally visible.
1595 * keyboard.h (ignore_mouse_drag_p): Declare only if
1596 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1597 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1598 * lisp.h (echoing): Remove decl.
1599 (force_auto_save_soon): Declare only if SIGDANGER.
1600 * xdisp.c (redisplay_window): Simplify code, to make it more
1601 obvious that ignore_mouse_drag_p is not accessed if !defined
1602 USE_GTK && !defined HAVE_NS.
1603
93ea6e8f
PE
1604 * intervals.c: Make symbols static if they're not exported.
1605 (merge_properties_sticky, merge_interval_right, delete_interval):
1606 Now static.
1607 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1608
77382fcc
PE
1609 * insdel.c: Make symbols static if they're not exported.
1610 However, leave prepare_to_modify_buffer alone. It's never
1611 called from outside this function, but that appears to be a bug.
1612 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1613 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1614 (adjust_after_replace_noundo): Remove; unused.
1615 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1616 (signal_before_change): Remove decls.
77382fcc 1617
9306c32e
PE
1618 * indent.c (val_compute_motion, val_vmotion): Now static.
1619
cd44d2eb
PE
1620 * image.c: Make symbols static if they're not exported.
1621 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1622 if USE_GTK.
1623 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1624 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1625
ad9a7a06
PE
1626 * fringe.c (standard_bitmaps): Now static.
1627 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1628
81626931
PE
1629 * frame.c: Make symbols static if they're not exported.
1630 (x_report_frame_params, make_terminal_frame): Now static.
1631 (get_frame_param): Now static, unless HAVE_NS.
1632 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1633 (x_get_resource_string): Remove; not used.
1634 * frame.h (make_terminal_frame, x_report_frame_params):
1635 (x_get_resource_string); Remove decls.
1636 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1637 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1638
239f9db9
PE
1639 * font.c, fontset.c: Make symbols static if they're not exported.
1640 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1641 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1642 * font.c (font_close_object): Now static.
1643 * font.h (font_close_object): Remove.
1644 * fontset.c (FONTSET_OBJLIST): Remove.
1645 (free_realized_fontset) #if-0 the body, which does nothing.
1646 (face_suitable_for_char_p): #if-0, as it's never called.
1647 * fontset.h (face_suitable_for_char_p): Remove decl.
1648 * xfaces.c (face_at_string_position): Use
1649 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1650 since 0 is always ASCII.
1651
dfcf3579
PE
1652 * fns.c (weak_hash_tables): Now static.
1653
5045092b
PE
1654 * fileio.c: Make symbols static if they're not exported.
1655 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1656 (Vwrite_region_annotation_buffers): Now static.
1657
57a96f5c
PE
1658 * eval.c: Make symbols static if they're not exported.
1659 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1660 * lisp.h (backtrace_list): Remove decl.
1661
35f08c38
PE
1662 * emacs.c: Make symbols static if they're not exported.
1663 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1664 (fatal_error_code, fatal_error_signal_hook, standard_args):
1665 Now static.
1666 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1667 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1668 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1669 * lisp.h (fatal_error_signal_hook): Remove decl.
1670 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1671
f44bd759
PE
1672 * editfns.c: Move a (normally-unused) function to its only use.
1673 * editfns.c, lisp.h (get_operating_system_release): Remove.
1674 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1675 worth the hassle of breaking this out.
1676
b532497d
PE
1677 * xterm.c: Make symbols static if they're not exported.
1678 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1679 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1680 (x_destroy_window, x_delete_display):
1681 Now static.
1682 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1683 (x_mouse_leave): Remove; unused.
1684 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1685 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1686 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1687 Remove decls.
1688 (x_mouse_leave): Declare only if WINDOWSNT.
1689 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1690 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1691 USE_X_TOOLKIT.
1692
1675728f
PE
1693 * ftxfont.c: Make symbols static if they're not exported.
1694 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1695 HAVE_FREETYPE.
1696 * font.h (ftxfont_driver): Likewise.
1697
e4cebfca
PE
1698 * xfns.c: Make symbols static if they're not exported.
1699 (x_last_font_name, x_display_info_for_name):
1700 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1701 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1702 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1703 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1704 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1705 (last_show_tip_args): Now static.
1706 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1707 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1708 (x_screen_planes): Remove; unused.
1709 * dispextern.h (x_screen_planes): Remove decl.
1710
5bf46f05
PE
1711 * dispnew.c: Make symbols static if they're not exported.
1712 * dispextern.h (redraw_garbaged_frames, scrolling):
1713 (increment_row_positions): Remove.
1714 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1715 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1716 Now static.
1717 (redraw_garbaged_frames): Remove; unused.
1718
435f4c28
PE
1719 * xfaces.c: Make symbols static if they're not exported.
1720 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1721 Remove decls.
1722 * xterm.h (defined_color): Remove decls.
1723 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1724 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1725 (menu_face_changed_default, defined_color, free_realized_face):
1726 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1727 (ascii_face_of_lisp_face): Remove; unused.
1728
8524aef3
PE
1729 * xdisp.c: Make symbols static if they're not exported.
1730 * dispextern.h (scratch_glyph_row, window_box_edges):
1731 (glyph_to_pixel_coords, set_cursor_from_row):
1732 (get_next_display_element, set_iterator_to_next):
1733 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1734 (show_mouse_face): Remove decls
1735 * frame.h (message_buf_print): Likewise.
1736 * lisp.h (pop_message, set_message, check_point_in_composition):
1737 Likewise.
1738 * xterm.h (set_vertical_scroll_bar): Likewise.
1739 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1740 (message_buf_print, scratch_glyph_row, displayed_buffer):
1741 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1742 (get_next_display_element, show_mouse_face, window_box_edges):
1743 (frame_to_window_pixel_xy, check_point_in_composition):
1744 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1745 (glyph_to_pixel_coords): Remove; unused.
1746
16390cd2
PE
1747 * dired.c (file_name_completion): Now static.
1748
1749 * dbusbind.c (xd_in_read_queued_messages): Now static.
1750
a25f4dfa
PE
1751 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1752 * data.c (circular_list_error): Remove.
1753
14a9c8df
PE
1754 * commands.h (last_point_position, last_point_position_buffer):
1755 (last_point_position_window): Remove decls.
1756 * keyboard.c: Make these variables static.
1757
74ab6df5
PE
1758 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
1759 decls.
1760 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1761 (iso_code_class, detect_coding, code_convert_region): Now static.
1762 (encode_coding_gap): Remove; unused.
1763
38dfbee1
PE
1764 * chartab.c (chartab_chars, chartab_bits): Now static.
1765
a2cb4e63
PE
1766 * charset.h (charset_iso_8859_1): Remove decl.
1767 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1768 Now static.
1769
127198fd
PE
1770 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1771 * ccl.c (Vccl_program_table): Now static.
1772 (check_ccl_update): Remove; unused.
1773
d85b608f
PE
1774 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1775 * category.h: ... from here.
1776 * category.c (check_category_table, set_category_set): Now static.
1777
31cd66f3
PE
1778 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1779 * lisp.h: Remove these decls.
1780
c358e587
PE
1781 * buffer.c (buffer_count): Remove unused var.
1782
e78aecca
PE
1783 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1784 so that it's not optimized away.
1785 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1786 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1787 exported only to the debugger.
1788
e192d7d3
PE
1789 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1790 * atimer.h (run_all_atimers): Removed; not exported.
1791
92470028
PE
1792 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1793 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1794 was inaccessible from Lisp.
1795 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1796 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1797
244ed907
PE
1798 alloc.c: Import and export fewer symbols, and remove unused items.
1799 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1800 is defined.
1801 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1802 it's not optimized away by whole-program optimization.
1803 (message_enable_multibyte, free_misc): Remove.
1804 (catchlist, handlerlist, mark_backtrace):
1805 Declare only if BYTE_MARK_STACK.
1806 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1807 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1808 (message_enable_multibyte): Remove decl.
1809 (free_misc, interval_free_list, float_block, float_block_index):
1810 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1811 (cons_free_list, last_marked_index):
1812 Now static.
1813 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1814 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1815 (mark_backtrace): Define only if BYTE_MARK_STACK.
1816 * xdisp.c (message_enable_multibyte): Now static.
1817
61c2b50e 1818 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1819 This makes it easier for human readers (and static analyzers)
1820 to see whether these variables are used from other modules.
1821 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1822 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1823 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1824 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1825 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1826 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1827 * xmenu.c, xselect.c:
1828 Declare Q* vars static if they are not used in other modules.
1829 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1830 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1831 Remove decls of unexported vars.
1832 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1833
95c82688
PE
1834 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1835
16a97296
PE
1836 Make Emacs functions such as Fatom 'static' by default.
1837 This makes it easier for human readers (and static analyzers)
1838 to see whether these functions can be called from other modules.
1839 DEFUN now defines a static function. To make the function external
1840 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1841 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1842 (Finit_image_library):
16a97296
PE
1843 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1844 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1845 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1846 Remove decls, since these functions are now static.
1847 (Funintern, Fget_internal_run_time): New decls, since these functions
1848 were already external.
95c82688 1849
16a97296
PE
1850 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1851 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1852 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1853 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1854 * keyboard.c, keymap.c, lread.c:
1855 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1856 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1857 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1858 Mark functions with DEFUE instead of DEFUN,
1859 if they are used in other modules.
1860 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1861 decls for now-static functions.
1862 * buffer.h (Fdelete_overlay): Remove decl.
1863 * callproc.c (Fgetenv_internal): Mark as internal.
1864 * composite.c (Fremove_list_of_text_properties): Remove decl.
1865 (Fcomposition_get_gstring): New forward static decl.
1866 * composite.h (Fcomposite_get_gstring): Remove decl.
1867 * dired.c (Ffile_attributes): New forward static decl.
1868 * doc.c (Fdocumntation_property): New forward static decl.
1869 * eval.c (Ffetch_bytecode): New forward static decl.
1870 (Funintern): Remove extern decl; now in .h file where it belongs.
1871 * fileio.c (Fmake_symbolic_link): New forward static decl.
1872 * image.c (Finit_image_library): New forward static decl.
1873 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1874 * intervals.h (Fprevious_property_change):
1875 (Fremove_list_of_text_properties): Remove decls.
1876 * keyboard.c (Fthis_command_keys): Remove decl.
1877 (Fcommand_execute): New forward static decl.
1878 * keymap.c (Flookup_key): New forward static decl.
1879 (Fcopy_keymap): Now static.
1880 * keymap.h (Flookup_key): Remove decl.
1881 * process.c (Fget_process): New forward static decl.
1882 (Fprocess_datagram_address): Mark as internal.
1883 * syntax.c (Fsyntax_table_p): New forward static decl.
1884 (skip_chars): Remove duplicate decl.
1885 * textprop.c (Fprevious_property_change): New forward static decl.
1886 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1887 Now internal.
1888 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1889 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1890
785bbd42
PE
1891 * editfns.c (Fformat): Remove unreachable code.
1892
8b913b57
AS
18932011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1894
1895 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1896 change. (Bug#8496)
1897
a6744a35
EZ
18982011-04-13 Eli Zaretskii <eliz@gnu.org>
1899
1900 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1901 when at ZV. (Bug#8487)
1902
e7974947
AS
19032011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1904
baad03f0
AS
1905 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1906 (Bug#8437)
1907 * keyboard.c (parse_tool_bar_item): Likewise.
1908 * sound.c (sound_cleanup, alsa_close): Likewise.
1909 * termcap.c (tgetent): Likewise.
1910 * xfns.c (x_default_font_parameter): Likewise.
1911 * xsettings.c (read_and_apply_settings): Likewise.
1912
e7974947
AS
1913 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1914 (overrun_check_free): Protoize.
1915
28272684
PE
19162011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1917
1918 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1919 since callers should never pass a negative size.
1920 Change the signature to match that of plain 'read' and 'write'; see
1921 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1922 * lisp.h: Update prototypes of emacs_write and emacs_read.
1923
11997c76
EZ
19242011-04-11 Eli Zaretskii <eliz@gnu.org>
1925
1926 * xdisp.c (redisplay_window): Don't try to determine the character
1927 position of the scroll margin if the window start point w->startp
e896f03c 1928 is outside the buffer's accessible region. (Bug#8468)
11997c76 1929
8a2cbd72
EZ
19302011-04-10 Eli Zaretskii <eliz@gnu.org>
1931
1932 Fix write-region and its subroutines for buffers > 2GB.
1933 * fileio.c (a_write, e_write): Modify declaration of arguments and
1934 local variables to support buffers larger than 2GB.
1935 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1936
1937 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1938 argument, local variables, and return value.
1939
1940 * lisp.h: Update prototypes of emacs_write and emacs_read.
1941
1942 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1943
4073e537 19442011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1945
1ebfdcb6
PE
1946 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1947
b2ded58d
PE
1948 Fix more problems found by GCC 4.6.0's static checks.
1949
7d66342c
PE
1950 * xdisp.c (vmessage): Use a better test for character truncation.
1951
bbf47d44
PE
1952 * charset.c (load_charset_map): <, not <=, for optimization,
1953 and to avoid potential problems with integer overflow.
9248994d 1954 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1955 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1956 * editfns.c (Fformat): Likewise.
1e69125e 1957 * syntax.c (skip_chars): Likewise.
3befa583 1958
e3019616
PE
1959 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1960 This also lets GCC 4.6.0 generate slightly better loop code.
1961
becfa255
PE
1962 * callint.c (Fcall_interactively): <, not <=, for optimization.
1963 (Fcall_interactively): Count the number of arguments produced,
1964 not the number of arguments given. This is simpler and lets GCC
1965 4.6.0 generate slightly better code.
1966
dae0cd48
PE
1967 * ftfont.c: Distingish more carefully between FcChar8 and char.
1968 The previous code passed unsigned char * to a functions like
1969 strlen and xstrcasecmp that expect char *, which does not
1970 conform to the C standard.
1971 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1972 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1973 char * when the C standard requires it.
1974
76032d70
PE
1975 * keyboard.c (read_char): Remove unused var.
1976
eb3f1cc8
PE
1977 * eval.c: Port to Windows vsnprintf (Bug#8435).
1978 Include <limits.h>.
1979 (SIZE_MAX): Define if the headers do not.
1980 (verror): Do not give up if vsnprintf returns a negative count.
1981 Instead, grow the buffer. This ports to Windows vsnprintf, which
1982 does not conform to C99. Problem reported by Eli Zaretskii.
1983 Also, simplify the allocation scheme, by avoiding the need for
1984 calling realloc, and removing the ALLOCATED variable.
1985
70476b54
PE
1986 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1987
12020a9e
PE
1988 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1989 But keep the doprint source code for now, as we might revamp it
1990 and use it again (Bug#8435).
ea6c7ae6
PE
1991 * lisp.h (doprnt): Remove.
1992 * Makefile.in (base_obj): Remove doprnt.o.
1993 * deps.mk (doprnt.o): Remove.
1994
5fdb398c
PE
1995 error: Print 32- and 64-bit integers portably (Bug#8435).
1996 Without this change, on typical 64-bit hosts error ("...%d...", N)
1997 was used to print both 32- and 64-bit integers N, which relied on
1998 undefined behavior.
1999 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2000 New macro.
2001 * lisp.h (error, verror): Mark as printf-like functions.
2002 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2003 Report overflow in size calculations when allocating printf buffer.
2004 Do not truncate output string at its first null byte.
2005 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2006 Truncate the output at a character boundary, since vsnprintf does not
2007 do that.
2008 * charset.c (check_iso_charset_parameter): Convert internal
2009 character to string before calling 'error', since %c now has the
2010 printf meaning.
2011 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2012 overflow when computing char to be passed to 'error'. Do not
2013 pass Lisp_Object to 'error'; pass the integer instead.
2014 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2015 formatted with plain %d.
2016
b189fa66
PE
2017 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2018
bff87ef0
PE
2019 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2020
7e2cac20
PE
2021 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2022
ce4d90b5
PE
2023 * xterm.c (x_catch_errors): Remove duplicate declaration.
2024
266c9547
PE
2025 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2026
79c49ad2
PE
2027 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2028
368f4090
JM
20292011-04-10 Jim Meyering <meyering@redhat.com>
2030
2031 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2032 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2033 return ssize_t not "int", and use size_t as the buffer length.
2034 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2035 * gnutls.h: Update declarations.
2036 * process.c (read_process_output): Use ssize_t, to match.
2037 (send_process): Likewise.
2038
a32d4040
CY
20392011-04-09 Chong Yidong <cyd@stupidchicken.com>
2040
2041 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2042
8546720e 20432011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2044
8546720e
GM
2045 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
2046 unsigned char, to match FcChar8 type definition.
aac0c6e3 2047
8546720e
GM
2048 * xterm.c (handle_one_xevent):
2049 * xmenu.c (create_and_show_popup_menu):
2050 * xselect.c (x_decline_selection_request)
2051 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2052
0a2f5c1a 20532011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2054
2055 Fix some uses of `int' instead of EMACS_INT.
2056 * search.c (string_match_1, fast_string_match)
2057 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2058 (scan_buffer, find_next_newline_no_quit)
2059 (find_before_next_newline, search_command, Freplace_match)
2060 (Fmatch_data): Make some `int' variables be EMACS_INT.
2061
2062 * xdisp.c (display_count_lines): 3rd argument and return value now
2063 EMACS_INT. All callers changed.
2064 (pint2hrstr): Last argument is now EMACS_INT.
2065
2066 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2067 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2068 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2069 (decode_coding_utf_16, decode_coding_emacs_mule)
2070 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2071 (decode_coding_ccl, decode_coding_charset)
2072 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2073 (decode_coding_iso_2022, decode_coding_emacs_mule)
2074 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2075 <char_offset, last_offset>: Declare EMACS_INT.
2076 (encode_coding_utf_8, encode_coding_utf_16)
2077 (encode_coding_emacs_mule, encode_invocation_designation)
2078 (encode_designation_at_bol, encode_coding_iso_2022)
2079 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2080 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2081 Declare EMACS_INT.
2082 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2083 (encode_invocation_designation): Last argument P_NCHARS is now
2084 EMACS_INT.
2085 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2086 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2087
2088 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2089 All users changed.
2090
2091 * ccl.c (Fccl_execute_on_string): Declare some variables
2092 EMACS_INT.
2093
8546720e 20942011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2095
2096 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2097
4e19a977
CS
20982011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2099
2100 * process.c (Fformat_network_address): Doc fix.
2101
87302331
R
21022011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2103
2104 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2105
cbb59342
CY
21062011-04-08 Chong Yidong <cyd@stupidchicken.com>
2107
2108 * keyboard.c (read_char): Call Lisp function help-form-show,
2109 instead of using internal_with_output_to_temp_buffer.
2110 (Qhelp_form_show): New var.
e0d38eeb 2111 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2112
2113 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2114
2115 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2116
e67a13ab
CY
21172011-04-06 Chong Yidong <cyd@stupidchicken.com>
2118
2119 * process.c (Flist_processes): Removed to Lisp.
2120 (list_processes_1): Deleted.
2121
973f782d
EZ
21222011-04-06 Eli Zaretskii <eliz@gnu.org>
2123
7c106b1e
EZ
2124 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2125
973f782d
EZ
2126 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2127
41cf7d1a 21282011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2129
ca23cc88
PE
2130 Fix more problems found by GCC 4.6.0's static checks.
2131
f390e2d5
PE
2132 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2133
42eea0d0
PE
2134 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2135
b69769da 2136 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2137
f9541e84
PE
2138 * xdisp.c (vmessage): Mark as a printf-like function.
2139
13841b55
PE
2140 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2141
c136c10f
PE
2142 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2143
5e2d4a30
PE
2144 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2145 printf-like functions.
2146 (tiff_load): Add casts to remove these marks before passing them
2147 to system-supplied API.
2148
583f48b9
PE
2149 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2150
b25d760e
PE
2151 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2152 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2153 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2154 directly, rather than having caller test rule sign. This avoids
2155 some unnecessary tests.
2156 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2157 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2158 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2159
bc7b6697 2160 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2161 (xfont_open): Avoid unnecessary tests.
bc7b6697 2162
27ccc379
PE
2163 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2164
dcd5c89a
PE
2165 * composite.h, composite.c (composition_gstring_put_cache):
2166 Use EMACS_INT, not int, for length.
2167
b13a45c6
PE
2168 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2169 breaking out part of COMPOSITION_DECODE_RULE.
2170 (COMPOSITION_DECODE_RULE): Use it.
2171 * composite.c (get_composition_id): Remove unused local vars,
2172 by using the new macro.
2173
1e792e4d
PE
2174 * textprop.c (set_text_properties_1): Change while to do-while,
2175 since the condition is always true at first.
2176
dc6c6455 2177 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2178 (interval_deletion_adjustment): Return unsigned value.
2179 All uses changed.
dc6c6455 2180
aba7731a
PE
2181 * process.c (list_processes_1, create_pty, read_process_output):
2182 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2183 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2184 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2185 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2186 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2187
fdfc4bf3
PE
2188 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2189
fca8fe46 2190 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2191 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2192
06a0259a 2193 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2194 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2195 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2196
e7b9e80f
PE
2197 * print.c (print_error_message): Avoid int overflow.
2198
56201685
PE
2199 * font.c (font_list_entities): Redo for clarity,
2200 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2201
78834453 2202 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2203 (font_score): Avoid potential overflow in diff calculation.
78834453 2204
0bc0b309 2205 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2206 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2207
e610eaca
PE
2208 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2209
b895abce
PE
2210 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2211 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2212 can always succeed if overflow has undefined behavior.
2213
1f1d9321 2214 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2215 (wordify): Omit three unnecessary tests.
1f1d9321 2216
c59478bc
PE
2217 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2218 All callers changed. This avoids the need for an unused var.
2219
79b73827
PE
2220 * casefiddle.c (casify_region): Remove var that is set but not used.
2221
a4db5dfe
PE
2222 * dired.c (file_name_completion): Remove var that is set but not used.
2223
43aae36e
PE
2224 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2225
2a47c44d 2226 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2227 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2228
a37c69bf
PE
2229 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2230 Check for integer overflow on size calculations.
2231
328ab8e7
PE
2232 * buffer.c (Fprevious_overlay_change): Remove var that is set
2233 but not used.
2234
e5a2a5cb
PE
2235 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2236 Remove vars that are set but not used.
8d84a6eb 2237 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2238 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2239
a60e5f68
PE
2240 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2241
f661cb61 2242 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2243 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2244
f0397f5a
PE
2245 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2246 that are set but not used.
2247
8664db06 2248 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2249 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2250
6abdaa4a
PE
2251 * xselect.c (x_get_local_selection, x_handle_property_notify):
2252 Remove vars that are set but not used.
2253
0ce7538d 2254 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2255 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2256
9ae848fc
PE
2257 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2258 Remove var that is set but not used.
0b918413
PE
2259 (scroll_bar_windows_size): Now size_t, not int.
2260 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2261 Check for overflow.
9ae848fc 2262
a5a62657
PE
2263 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2264 (map_tty_color) [!defined MSDOS]: Likewise.
2265
5c5cdd39
PE
2266 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2267
66ebf983
PE
2268 * coding.c: Remove vars that are set but not used.
2269 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2270 All callers changed.
2271 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2272 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2273 (decode_coding_charset): Remove vars that are set but not used.
2274
1be4d761
PE
2275 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2276 that is set but not used.
2277
47553fa8
PE
2278 * print.c (print_object): Remove var that is set but not used.
2279
1f7196bf 2280 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2281 The gnulib version avoids calling malloc in the usual case,
2282 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2283 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2284 * filelock.c (current_lock_owner): Likewise.
2285 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2286 * sysdep.c: Include allocator.h, careadlinkat.h.
2287 (emacs_no_realloc_allocator): New static constant.
2288 (emacs_readlink): New function.
fdb61804
PE
2289 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2290 ../lib/careadlinkat.h.
d1fdcab7 2291
f84c17c7
SM
22922011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2293
2294 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2295 first non-nil return value).
2296
ef3862ad
JD
22972011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2298
2299 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2300 if not defined (Bug#8403).
2301
376a7006
JB
23022011-04-02 Juanma Barranquero <lekktu@gmail.com>
2303
2304 * xdisp.c (display_count_lines): Remove parameter `start',
2305 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2306 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2307 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2308 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2309 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2310 and thereabouts. All callers changed.
2311 (get_per_char_metric): Remove parameter `f', unused since
2312 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2313
6ca3801d
JM
23142011-04-02 Jim Meyering <meyering@redhat.com>
2315
2316 do not dereference NULL upon failed strdup
2317 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2318 (ns_get_family): Likewise.
2319
d8e2b5ba
JB
23202011-04-02 Juanma Barranquero <lekktu@gmail.com>
2321
2322 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2323
8c74fcbd
JD
23242011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2325
2326 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2327 later (Bug#8403).
2328
7200d79c
SM
23292011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2330
03408648 2331 Add lexical binding.
7200d79c 2332
03408648
SM
2333 * window.c (Ftemp_output_buffer_show): New fun.
2334 (Fsave_window_excursion):
2335 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2336
2337 * lread.c (lisp_file_lexically_bound_p): New function.
2338 (Fload): Bind Qlexical_binding.
2339 (readevalloop): Remove `evalfun' arg.
2340 Bind Qinternal_interpreter_environment.
2341 (Feval_buffer): Bind Qlexical_binding.
2342 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2343 Mark as dynamic.
2344 (syms_of_lread): Declare `lexical-binding'.
2345
2346 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2347
2348 * keyboard.c (eval_dyn): New fun.
2349 (menu_item_eval_property): Use it.
ca105506
SM
2350
2351 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2352
03408648
SM
2353 * fns.c (concat, mapcar1): Accept byte-code-functions.
2354
2355 * eval.c (Fsetq): Handle lexical vars.
2356 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2357 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2358 (FletX, Flet): Obey lexical binding.
2359 (Fcommandp): Handle closures.
2360 (Feval): New `lexical' arg.
2361 (eval_sub): New function extracted from Feval. Use it almost
2362 everywhere where Feval was used. Look up vars in lexical env.
2363 Handle closures.
2364 (Ffunctionp): Move from subr.el.
2365 (Ffuncall): Handle closures.
2366 (apply_lambda): Remove `eval_flags'.
2367 (funcall_lambda): Handle closures and new byte-code-functions.
2368 (Fspecial_variable_p): New function.
2369 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2370 but without exporting it to Lisp.
23aba0ea 2371
23aba0ea 2372 * doc.c (Fdocumentation, store_function_docstring):
03408648 2373 * data.c (Finteractive_form): Handle closures.
23aba0ea 2374
03408648
SM
2375 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2376 interactive spec.
ba83908c 2377
03408648
SM
2378 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
2379 byte-codes.
2380 (exec_byte_code): New function extracted from Fbyte_code to handle new
2381 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2382
03408648 2383 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2384
03408648 2385 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2386
e2abce01
JB
23872011-03-31 Juanma Barranquero <lekktu@gmail.com>
2388
2389 * xdisp.c (redisplay_internal): Fix prototype.
2390
63696a73 23912011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2392
63696a73
EZ
2393 * xdisp.c (SCROLL_LIMIT): New macro.
2394 (try_scrolling): Use it when setting scroll_limit. Limit
2395 scrolling to 100 screen lines.
2396 (redisplay_window): Even when falling back on "recentering",
2397 position point in the window according to scroll-conservatively,
2398 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2399
2400 (try_scrolling): When point is above the window, allow searching
2401 as far as scroll_max, or one screenful, to compute vertical
2402 distance from PT to the scroll margin position. This prevents
2403 try_scrolling from unnecessarily failing when
2404 scroll-conservatively is set to a value slightly larger than the
2405 window height. Clean up the case of PT below the margin at bottom
2406 of window: scroll_max can no longer be INT_MAX. When aggressive
2407 scrolling is in use, don't let point enter the opposite scroll
2408 margin as result of the scroll.
2409 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2410 threshold of 100 lines for never-recentering scrolling.
2411
e4cc2dfc
JB
24122011-03-31 Juanma Barranquero <lekktu@gmail.com>
2413
2414 * dispextern.h (move_it_by_lines):
2415 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2416 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2417 (message_log_check_duplicate): Remove parameters `prev_bol' and
2418 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2419 (redisplay_internal): Remove parameter `preserve_echo_area',
2420 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2421
2422 * indent.c (Fvertical_motion):
2423 * window.c (window_scroll_pixel_based, Frecenter):
2424 Don't pass `need_y_p' to `move_it_by_lines'.
2425
1c470562
SM
24262011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2427
44f230aa
SM
2428 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2429 steal a few bits to be more compact.
2430 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2431 Remove unneeded casts.
2432
1c470562
SM
2433 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2434
888adce9
ZK
24352011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2436
2437 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2438 binding" message (bug#7967).
2439
f838ed7b
PE
24402011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2441
77861b95
PE
2442 Fix more problems found by GCC 4.6.0's static checks.
2443
de6dbc14
PE
2444 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2445 Remove unused local var.
2446
f838ed7b
PE
2447 * editfns.c (Fmessage_box): Remove unused local var.
2448
792c7b2b
PE
2449 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2450 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2451 Omit unused local vars.
c499e557 2452 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2453 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2454 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2455 Omit unused local var.
2456
ba0165e1
PE
2457 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2458 Don't assume string length fits in int.
32ad8845 2459 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2460 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2461
3c59b4c9
PE
2462 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2463 instead of alloca (Bug#8344).
2464
a3eed478 2465 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2466 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2467
eb4d412d
PE
2468 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2469
1658b401
PE
2470 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2471 concerns.
2472
2473 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2474
2475 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2476
9a2c6e05
PE
2477 * keyboard.c (syms_of_keyboard): Use the same style as later
2478 in this function when indexing through an array. This also
2479 works around GCC bug 48267.
2480
03d0a109
PE
2481 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2482
44f730c8
PE
2483 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2484
fe75f926
PE
2485 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2486 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2487
ffa8c828
PE
2488 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2489 This avoids undefined behavior on integer overflow, and is a bit
2490 more convenient anyway since it is compared to a size_t variable.
2491
c5101a77
PE
2492 Variadic C functions now count arguments with size_t, not int.
2493 This avoids an unnecessary limitation on 64-bit machines, which
2494 caused (substring ...) to crash on large vectors (Bug#8344).
2495 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2496 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2497 All variadic functions and their callers changed accordingly.
c5101a77
PE
2498 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2499 * data.c (arith_driver, float_arith_driver): Likewise.
2500 * editfns.c (general_insert_function): Likewise.
2501 * eval.c (struct backtrace.nargs, interactive_p)
2502 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2503 (funcall_lambda, mark_backtrace): Likewise.
2504 * fns.c (concat): Likewise.
2505 * frame.c (x_set_frame_parameters): Likewise.
2506 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2507 0 if not found, not -1. All callers changed.
2508
dd3f25f7
PE
2509 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2510 (stack_copy_size): Now size_t, not int.
2511 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2512
461c2ab9
JB
25132011-03-28 Juanma Barranquero <lekktu@gmail.com>
2514
2515 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2516 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2517 All callers changed.
2518
2519 * lisp.h (multibyte_char_to_unibyte):
2520 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2521 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2522 * character.h (CHAR_TO_BYTE8):
2523 * cmds.c (internal_self_insert):
2524 * editfns.c (general_insert_function):
2525 * keymap.c (push_key_description):
2526 * search.c (Freplace_match):
2527 * xdisp.c (message_dolog, set_message_1): All callers changed.
2528
f6d62986
SM
25292011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2530
2531 * keyboard.c (safe_run_hook_funcall): New function.
2532 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2533 don't set the hook to nil, but remove the offending function instead.
2534 (Qcommand_hook_internal): Remove, unused.
2535 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2536 Vcommand_hook_internal.
2537
2538 * eval.c (enum run_hooks_condition): Remove.
2539 (funcall_nil, funcall_not): New functions.
2540 (run_hook_with_args): Call each function through a `funcall' argument.
2541 Remove `cond' argument, now redundant.
2542 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2543 (Frun_hook_with_args_until_failure): Adjust accordingly.
2544 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2545
1db5b1ad
JB
25462011-03-28 Juanma Barranquero <lekktu@gmail.com>
2547
2548 * dispextern.h (string_buffer_position): Remove declaration.
2549
2550 * print.c (strout): Remove parameter `multibyte', unused since
2551 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2552
2553 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2554 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2555 All callers changed.
2556
2557 * w32.c (_wsa_errlist): Use braces for struct initializers.
2558
2559 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2560 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2561 All callers changed.
2562 (string_buffer_position): Likewise. Also, make static (it's never
2563 used outside xdisp.c).
2564 (cursor_row_p): Remove parameter `w', unused since
2565 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2566 (decode_mode_spec): Remove parameter `precision', introduced during
2567 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2568 All callers changed.
2569
5ffb62aa
JD
25702011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2571
2572 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2573
461c2ab9 25742011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2575
2576 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2577 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2578 (ns_update_auto_hide_menu_bar): New functions.
2579 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2580 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2581 ns_constrain_all_frames.
2582 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2583 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2584
5c380ffb
JD
25852011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2586
2587 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2588
9af30bdf
GM
25892011-03-27 Glenn Morris <rgm@gnu.org>
2590
2591 * syssignal.h: Replace RETSIGTYPE with void.
2592 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2593 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2594 Replace SIGTYPE with void everywhere.
2595 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2596 * s/template.h (SIGTYPE): Remove commented out definition.
2597
e2abce01
JB
25982011-03-26 Eli Zaretskii <eliz@gnu.org>
2599
2600 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2601 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2602
f868cd8a
JB
26032011-03-26 Juanma Barranquero <lekktu@gmail.com>
2604
59eb0929
JB
2605 * w32.c (read_unc_volume): Use parameter `henum', instead of
2606 global variable `wget_enum_handle'.
2607
2608 * keymap.c (describe_vector): Remove parameters `indices' and
2609 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2610 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2611
f868cd8a
JB
2612 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2613
2614 * keyboard.c (timer_check): Remove parameter `do_it_now',
2615 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2616 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2617 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2618
2619 * keyboard.c (read_char):
2620 * w32menu.c (w32_menu_display_help):
2621 * xmenu.c (show_help_event, menu_help_callback):
2622 Adjust calls to `show_help_echo'.
2623
2624 * gtkutil.c (xg_maybe_add_timer):
2625 * keyboard.c (readable_events):
2626 * process.c (wait_reading_process_output):
2627 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2628
2629 * insdel.c (adjust_markers_gap_motion):
2630 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2631 (gap_left, gap_right): Don't call it.
2632
2ecf6fdb
CY
26332011-03-25 Chong Yidong <cyd@stupidchicken.com>
2634
2635 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2636 incurred during fontification.
2637
6b1f9ba4
JB
26382011-03-25 Juanma Barranquero <lekktu@gmail.com>
2639
2640 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2641 (DEFVAR_PER_BUFFER): Don't pass it.
2642
2643 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2644 (scrolling_window): Don't pass it.
2645
0f4a96b5
JB
26462011-03-25 Juanma Barranquero <lekktu@gmail.com>
2647
2648 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2649
2650 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2651 and `suffix'.
2652 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2653 of variables specific to SELinux and computation of `encoded_absname'.
2654
2655 * image.c (XPutPixel): Remove unused variable `height'.
2656
2657 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2658
2659 * unexw32.c (get_section_info): Remove unused variable `section'.
2660
2661 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2662 (system_process_attributes): Remove unused variable `sess'.
2663 (sys_read): Remove unused variable `err'.
2664
2665 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2666 (w32_wnd_proc): Remove unused variable `isdead'.
2667 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2668 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2669 (x_create_tip_frame): Remove unused variable `tem'.
2670
2671 * w32inevt.c (w32_console_read_socket):
2672 Remove unused variable `no_events'.
2673
2674 * w32term.c (x_draw_composite_glyph_string_foreground):
2675 Remove unused variable `width'.
2676
1149507c
JB
26772011-03-24 Juanma Barranquero <lekktu@gmail.com>
2678
2679 * w32term.c (x_set_glyph_string_clipping):
2680 Don't pass uninitialized region to CombineRgn.
2681
9c88f339
JB
26822011-03-23 Juanma Barranquero <lekktu@gmail.com>
2683
2684 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2685 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2686 (Fx_close_connection): Remove unused variable `i'.
2687
2688 * w32font.c (w32font_draw): Return number of glyphs.
2689 (w32font_open_internal): Remove unused variable `i'.
2690 (w32font_driver): Add missing initializer.
2691
2692 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2693 (fill_in_menu): Remove unused variable `items_added'.
2694
2695 * w32term.c (last_mouse_press_frame): Remove static global variable.
2696 (w32_clip_to_row): Remove unused variable `f'.
2697 (x_delete_terminal): Remove unused variable `i'.
2698
2699 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2700 (NOTHING): Remove unused static global variable.
2701 (uniscribe_check_otf): Remove unused variable `table'.
2702 (uniscribe_font_driver): Add missing initializers.
2703
dee091a3
JD
27042011-03-23 Julien Danjou <julien@danjou.info>
2705
2706 * term.c (Fsuspend_tty, Fresume_tty):
2707 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2708 * window.c (temp_output_buffer_show):
2709 * insdel.c (signal_before_change):
2710 * frame.c (Fhandle_switch_frame):
2711 * fileio.c (Fdo_auto_save):
2712 * emacs.c (Fkill_emacs):
2713 * editfns.c (save_excursion_restore):
2714 * cmds.c (internal_self_insert):
2715 * callint.c (Fcall_interactively):
2716 * buffer.c (Fkill_all_local_variables):
2717 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2718 Use Frun_hooks.
0f4a96b5 2719 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2720 unconditionnaly since it does the check itself.
2721
2c520ab5 27222011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2723
c9c49752
PE
2724 Fix more problems found by GCC 4.5.2's static checks.
2725
8abc3f12
PE
2726 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2727 the first time through the loop, since we know p0 < p1 then.
2728 This also avoids a gcc -Wstrict-overflow warning.
2729
a2d26660
PE
2730 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2731 leading to a memory leak, possible in functions like
2732 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2733 of objects (Bug#8318).
a2d26660 2734
916c72e9
PE
2735 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2736 that could (at least in theory) be that large.
2737
19ab8a18
PE
2738 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2739 This is less likely to overflow, and avoids undefined behavior if
2740 overflow does occur. All callers changed. Use strtoul to scan
2741 for the unsigned long integer.
b7cbbd6f
PE
2742 (pint2hrstr): Simplify and tune code slightly.
2743 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2744
f0641eff
PE
2745 * scroll.c (do_scrolling): Work around GCC bug 48228.
2746 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2747
7f650bb9
PE
2748 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2749 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2750 (validate_x_resource_name): Simplify count usage.
2751 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2752
37dd57d1
PE
2753 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2754 fail (Bug#8306).
81e56e61 2755
699979fc 2756 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2757
401bf9b4
PE
2758 * process.c (Fmake_network_process): Use socklen_t, not int,
2759 where POSIX says socklen_t is required in portable programs.
2760 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2761 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2762 (Fmake_network_process, server_accept_connection):
2763 (wait_reading_process_output, read_process_output):
2764 Likewise.
2765
b93aacde
PE
2766 * process.c: Rename or move locals to avoid shadowing.
2767 (list_processes_1, Fmake_network_process):
2768 (read_process_output_error_handler, exec_sentinel_error_handler):
2769 Rename or move locals.
4dc343ee 2770 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2771 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2772 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2773 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2774 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2775
af8a867c 2776 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2777 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2778 Include tparam.h instead, since it declares them.
af8a867c
PE
2779 * cm.h (PC): Remove extern decl; tparam.h now does this.
2780 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2781 * terminfo.c: Include tparam.h, to check interfaces.
2782 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2783 (tparam): Adjust signature to match interface in tparam.h;
2784 this removes some undefined behavior. Check that outstring and len
2785 are zero, which they always are with Emacs.
2786 * tparam.h (PC, BC, UP): New extern decls.
2787
0248044d 2788 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2789 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2790
8ff096c1 2791 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2792 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2793 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2794 (ftfont_list): Remove unused local.
49eaafba
PE
2795 (get_adstyle_property, ftfont_pattern_entity):
2796 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2797 Rename locals to avoid shadowing.
8ff096c1 2798
e2be39f6
PE
2799 * xfont.c (xfont_list_family): Mark var as initialized.
2800
c9735e30
PE
2801 * xml.c (make_dom): Now static.
2802
8f5201ae
PE
2803 * composite.c (composition_compute_stop_pos): Rename local to
2804 avoid shadowing.
b246f932
PE
2805 (composition_reseat_it): Remove unused locals.
2806 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2807 (composition_update_it): Mark var as initialized.
11b61122
PE
2808 (find_automatic_composition): Mark vars as initialized,
2809 with a FIXME (Bug#8290).
8f5201ae 2810
760fbc2c
PE
2811 character.h: Rename locals to avoid shadowing.
2812 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2813 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2814 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2815 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2816 to avoid shadowing.
2817
ff08eb85
PE
2818 * textprop.c (property_change_between_p): Remove; unused.
2819
fc7bf025
PE
2820 * intervals.c (interval_start_pos): Now static.
2821
235d7abc
PE
2822 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2823
44f230aa
SM
2824 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2825 Rename locals to avoid shadowing.
3e7d6594 2826
50060332
PE
2827 * sound.c (wav_play, au_play, Fplay_sound_internal):
2828 Fix pointer signedness.
d01f234b 2829 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2830 (wav_play): Initialize a variable to 0, to prevent undefined
2831 behavior (Bug#8278).
50060332 2832
c4fc4e30
PE
2833 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2834
918436ed
PE
2835 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2836
c939f91b
PE
2837 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2838 clobbering (Bug#8298).
b9c7f648
PE
2839 * sysdep.c (sys_subshell): Likewise.
2840 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2841
6bd8c144
PE
2842 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2843 This should get cleaned up, so that child_setup has the
2844 same signature on all platforms.
2845
7710357c 2846 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2847 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2848
c59da222
CY
28492011-03-22 Chong Yidong <cyd@stupidchicken.com>
2850
2851 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2852 not to be necessary, and produces flickering.
2853
66b87493
GM
28542011-03-20 Glenn Morris <rgm@gnu.org>
2855
2856 * config.in: Remove file.
2857
45b6f6d5
JB
28582011-03-20 Juanma Barranquero <lekktu@gmail.com>
2859
2860 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2861 are now in src/globals.h.
2862 (syms_of_minibuf): Remove spurious & from previous change.
2863
3ec03f7e
LL
28642011-03-20 Leo <sdl.web@gmail.com>
2865
2866 * minibuf.c (completing-read-function): New variable.
2867 (completing-read-default): Rename from completing-read.
2868 (completing-read): Call completing-read-function.
2869
b14e3e21
CY
28702011-03-19 Juanma Barranquero <lekktu@gmail.com>
2871
2872 * xfaces.c (Fx_load_color_file):
2873 Read color file from absolute filename (bug#8250).
2874
f2b726e6
JB
28752011-03-19 Juanma Barranquero <lekktu@gmail.com>
2876
2877 * makefile.w32-in: Update dependencies.
2878
09f6ff02
EZ
28792011-03-17 Eli Zaretskii <eliz@gnu.org>
2880
2881 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2882
29a6015a
PE
28832011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2884
a3a6c54e
PE
2885 Fix more problems found by GCC 4.5.2's static checks.
2886
b766f867
PE
2887 * process.c (make_serial_process_unwind, send_process_trap):
2888 (sigchld_handler): Now static.
2889
be02381c
PE
2890 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2891 That way, the code declares only the vars that it needs.
2892 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2893 * s/cygwin.h (PTY_ITERATION): Likewise.
2894 * s/darwin.h (PTY_ITERATION): Likewise.
2895 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2896
57048744
PE
2897 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2898 * process.c (allocate_pty): Don't declare stb unless it's needed.
2899
7914961c 2900 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2901 (CONSTANTLIM): Remove; unused.
2902 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2903 Define only if needed.
7914961c 2904
b3967b18
PE
2905 * unexelf.c (unexec): Name an expression,
2906 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2907 Use a different way to cause a compilation error if anyone uses
2908 n rather than nn, a way that does not involve shadowing.
73366a00 2909 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2910
29a6015a
PE
2911 * deps.mk (unexalpha.o): Remove; unused.
2912
43cfc33e 2913 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2914 * unexec.h: New file.
ce701a33
PE
2915 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2916 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2917 Depend on unexec.h.
2918 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2919 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2920 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2921 Change as necessary to match prototype in unexec.h.
ce701a33 2922
01f44d5a
PE
2923 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2924 shadowing.
4f63c6bb 2925 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2926
a6670b0b
PE
2927 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2928 Rename locals to avoid shadowing.
2929
cef2010d 2930 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2931 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2932
d4d7173a
PE
2933 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2934
f08b802a
PE
2935 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2936 warning when compiling print.c.
2937
3ddb0639
PE
2938 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2939 instead of using an uninitialized var.
5ad03b97 2940 (font_sort_entities): Mark var as initialized.
3ddb0639 2941
170a2692
PE
2942 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2943
e663c700
PE
2944 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2945 pointers to constants.
89bc529a 2946 (font_parse_fcname): Remove unused vars.
7b81e2d0 2947 (font_delete_unmatched): Now static.
ea838e10 2948 (font_get_spec): Remove; unused.
13a547c6
PE
2949 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2950 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2951 Rename or move locals to avoid shadowing.
e663c700 2952
2a80c887 2953 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2954 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2955
1384fa33 2956 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2957 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2958
8b2c52e9
PE
2959 * alloc.c (mark_backtrace): Move decl from here ...
2960 * lisp.h: ... to here, so that it can be checked.
2961
475545b5 2962 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2963 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2964 (lisp_indirect_variable): Name an expression,
2965 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2966 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2967
b1349114 2968 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2969 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2970 Use const pointer when appropriate.
b1349114 2971
a2928364
PE
2972 * lisp.h (get_system_name, get_operating_system_release):
2973 Move decls here, to check interfaces.
2974 * process.c (get_operating_system_release): Move decl to lisp.h.
2975 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2976 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2977 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2978 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2979 (Fformat_time_string, Fencode_time, Finsert_char):
2980 (Ftranslate_region_internal, Fformat):
2981 Rename or remove local vars to avoid shadowing.
9710023e 2982 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2983
a415e694
PE
2984 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2985 avoid shadowing.
2986
8ef4622d
PE
2987 * lisp.h (eassert): Check that the argument compiles, even if
2988 ENABLE_CHECKING is not defined.
2989
946f9a5b
PE
2990 * data.c (Findirect_variable): Name an expression, to avoid
2991 gcc -Wbad-function-cast warning.
112396d6 2992 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2993 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2994 (Fmake_variable_buffer_local, Fmake_local_variable):
2995 Mark variables as initialized.
52746918 2996 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2997
e5aab7e7 2998 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2999 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3000 Rename locals to avoid shadowing.
dff45157
PE
3001 (mark_stack): Move local variables into the #ifdef region where
3002 they're used.
7bc26fdb
PE
3003 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3004 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3005 needed otherwise.
3006 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3007 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3008 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3009
e5aab7e7
PE
3010 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3011 avoids undefined behavior in theory.
3012
4da60324
PE
3013 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3014
88043301
PE
3015 Use functions, not macros, for up- and down-casing (Bug#8254).
3016 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3017 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3018 to use the following functions instead of these macros.
3019 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3020 EMACS_INT, since callers assume the returned value fits in int.
3021 (upcase1): Likewise, for UPCASE_TABLE.
3022 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3023 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3024 the race-condition problem in the old DOWNCASE.
88043301 3025
19ed5445
PE
3026 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3027 Rename locals to avoid shadowing.
3028 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3029 (regex_compile, re_search_2, re_match_2_internal):
3030 Remove unused local vars.
952db0d7
PE
3031 (FREE_VAR): Rewrite so as not to use empty "else",
3032 which gcc can warn about.
da053e48 3033 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3034 (RETALLOC_IF): Define only if needed.
3035 (WORDCHAR_P): Likewise. This one is never needed, but is used
3036 only in a comment talking about a compiler bug, so put inside
3037 the #if 0 of that comment.
3038 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3039 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3040 Remove; unused.
19ed5445 3041
1f3561e4 3042 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3043 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3044 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3045
ded6f8f7
PE
3046 * search.c (simple_search): Remove unused var.
3047
dbd37a95
PE
3048 * dired.c (compile_pattern): Move decl from here ...
3049 * lisp.h: ... to here, so that it can be checked.
3050 (struct re_registers): New forward decl.
3051
7e47afad
PE
3052 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3053
85f24f61
PE
3054 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3055 All uses changed.
3056 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3057 Rename locals to avoid shadowing.
5671df8f 3058 (Fvertical_motion): Mark locals as initialized.
85f24f61 3059
181aa2be 3060 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3061 (casify_region): Mark local as initialized.
181aa2be 3062
930d429c
PE
3063 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3064
7082eac6
PE
3065 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3066 New macros, so that the caller can use some names other than
3067 gcpro1, gcpro2, etc.
3068 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3069 of the new macros.
3070 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3071 argument, for consistency with GCPRO2_VAR, etc: it is now the
3072 prefix of the variable, not the variable itself. All uses
3073 changed.
38b2c076
PE
3074 * dired.c (directory_files_internal, file_name_completion):
3075 Rename locals to avoid shadowing.
3076
15206ed9
PE
3077 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3078 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3079 dired.c's scmp function, had undefined behavior.
3080 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3081 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3082 * buffer.h: ... to here, because these macros use current_buffer,
3083 and the new implementation with inline functions needs to have
3084 current_buffer in scope now, rather than later when the macros
3085 are used.
3086 (downcase, upcase1): New static inline functions.
3087 (DOWNCASE, UPCASE1): Reimplement using these functions.
3088 This avoids undefined behavior in expressions like
3089 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3090 from race conditions in accessing the global variables
3091 case_temp1 and case_temp2.
3092 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3093 * lisp.h (case_temp1, case_temp2): Remove their decls.
3094 * character.h (ASCII_CHAR_P): Move from here ...
3095 * lisp.h: ... to here, so that the inline functions mentioned
3096 above can use them.
3097
4a6bea26
PE
3098 * dired.c (directory_files_internal_unwind): Now static.
3099
f14b7e14
PE
3100 * fileio.c (file_name_as_directory, directory_file_name):
3101 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3102 Now static.
2893f146
PE
3103 (file_name_as_directory): Use const pointers when appropriate.
3104 (Fexpand_file_name): Likewise. In particular, newdir might
3105 point at constant storage, so make it a const pointer.
fd4ead52 3106 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3107 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3108 signedness issues.
f839df0c
PE
3109 (Fset_file_times, Finsert_file_contents, auto_save_error):
3110 Rename locals to avoid shadowing.
f14b7e14 3111
5716756e 3112 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3113 (Ftry_completion, Fall_completions): Rename or remove locals
3114 to avoid shadowing.
5716756e 3115
b4c3046a
PE
3116 * marker.c (bytepos_to_charpos): Remove; unused.
3117
b45db522
PE
3118 * lisp.h (verify_bytepos, count_markers): New decls,
3119 so that gcc does not warn that these functions aren't declared.
3120
85876d07
PE
3121 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3122 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3123 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3124 (copy_text): Remove unused local var.
85876d07 3125
03d78a21 3126 * filelock.c (within_one_second): Now static.
b3dd38ab 3127 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3128
5df8f01b
PE
3129 * buffer.c (fix_overlays_before): Mark locals as initialized.
3130 (fix_start_end_in_overlays): Likewise. This function should be
3131 simplified by using pointers-to-pointers, but that's a different
3132 matter.
b1d876f1 3133 (switch_to_buffer_1): Now static.
8f54f30a
PE
3134 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3135 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3136
a70072c9 3137 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3138 Fix pointer signedness issue.
edced198
PE
3139 (sys_subshell): Mark local as volatile if checking for lint,
3140 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3141 (MAXPATHLEN): Define only if needed.
a70072c9 3142
a0977c44
PE
3143 * process.c (serial_open, serial_configure): Move decls from here ...
3144 * systty.h: ... to here, so that they can be checked.
3145
a884fdcc
PE
3146 * fns.c (get_random, seed_random): Move extern decls from here ...
3147 * lisp.h: ... to here, so that they can be checked.
3148
604efe86 3149 * sysdep.c (reset_io): Now static.
b8950c94 3150 (wait_for_termination_signal): Remove; unused.
604efe86 3151
38fc62d9
PE
3152 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3153 (copy_keymap_item, append_key, push_text_char_description):
3154 Now static.
1004a21a 3155 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3156 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3157 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3158 (describe_map_tree):
3159 Rename locals to avoid shadowing.
38fc62d9 3160
2f2650da
PE
3161 * keyboard.c: Declare functions static if they are not used elsewhere.
3162 (echo_char, echo_dash, cmd_error, top_level_2):
3163 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3164 (read_char, kbd_buffer_get_event, make_lispy_position):
3165 (make_lispy_event, make_lispy_movement, apply_modifiers):
3166 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3167 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3168 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3169 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3170 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3171
a053e86c 3172 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3173 (mark_kboards): Move decl here ...
3174 * alloc.c (mark_kboards): ... from here.
a053e86c 3175
4752793e
PE
3176 * lisp.h (force_auto_save_soon): New decl.
3177
74f10ca7 3178 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3179 (DEFINE_DUMMY_FUNCTION): New macro.
3180 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3181 Use it.
c03cd23f
PE
3182 (main): Add casts to avoid warnings
3183 if GCC considers string literals to be constants.
74f10ca7 3184
022e70d4
PE
3185 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3186
59d6fe83
PE
3187 * dbusbind.c: Pointer signedness fixes.
3188 (xd_signature, xd_append_arg, xd_initialize):
3189 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3190 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3191 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3192 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3193
78320123
PE
3194 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3195 if GCC considers string literals to be constants.
49cebcca 3196 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3197
35ac2a97
SM
31982011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3199
fb103ca9
SM
3200 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3201 (print_preprocess, print_object): New macro to fix last change.
3202
35ac2a97
SM
3203 * print.c (print_preprocess): Don't forget font objects.
3204
62973b41
JB
32052011-03-16 Juanma Barranquero <lekktu@gmail.com>
3206
3207 * emacs.c (USAGE3): Doc fixes.
3208
0e48bb22
AS
32092011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3210
3211 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3212 structure.
3213
7684e57b
JB
32142011-03-14 Juanma Barranquero <lekktu@gmail.com>
3215
3216 * lisp.h (VWindow_system, Qfile_name_history):
3217 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3218 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3219 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3220
3221 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3222 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3223
3224 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3225 * w32console.c (detect_input_pending, read_input_pending)
3226 (encode_terminal_code):
3227 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3228 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3229 (w32_system_caret_y, Qfile_name_history):
3230 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3231 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3232 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3233 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3234 * w32proc.c (Qlocal, report_file_error):
3235 * w32term.c (Vwindow_system, updating_frame):
3236 * w32uniscribe.c (initialized, uniscribe_font_driver):
3237 Remove unneeded extern declarations.
3238
2aa46d6c
CY
32392011-03-14 Chong Yidong <cyd@stupidchicken.com>
3240
c96bbc66 3241 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3242
cffc6f3b
CY
32432011-03-13 Chong Yidong <cyd@stupidchicken.com>
3244
3245 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3246 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3247 These macros can no longer be used for assignment.
3248
44f230aa
SM
3249 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3250 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3251 (record_buffer_markers, fetch_buffer_markers): New functions for
3252 recording and fetching special buffer markers.
3253 (set_buffer_internal_1, set_buffer_temp): Use them.
3254
3255 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3256
3257 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3258
3259 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3260 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3261
3262 * xdisp.c (hscroll_window_tree):
3263 (reconsider_clip_changes): Use PT instead of BUF_PT.
3264
d251f04b
EZ
32652011-03-13 Eli Zaretskii <eliz@gnu.org>
3266
3267 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3268 $(EMACS_ROOT)/lib/intprops.h.
3269
f0c77cd1
PE
32702011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3271
3eca4629
PE
3272 Fix more problems found by GCC 4.5.2's static checks.
3273
7c86ee98
PE
3274 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3275 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3276 (xg_free_frame_widgets): Make it clear that a local variable is
3277 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3278 (gdk_window_get_screen): Make it clear that this macro is needed
3279 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3280 (int_gtk_range_get_value): New function, which avoids a diagnostic
3281 from gcc -Wbad-function-cast.
3282 (xg_set_toolkit_scroll_bar_thumb): Use it.
3283 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3284 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3285 (get_utf8_string, xg_get_file_with_chooser):
3286 Rename locals to avoid shadowing.
3287 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3288
41729b81
PE
3289 * xgselect.c (xg_select): Remove unused var.
3290
f0c77cd1
PE
3291 * image.c (four_corners_best): Mark locals as initialized.
3292 (gif_load): Initialize transparent_p to zero (Bug#8238).
3293 Mark another local as initialized.
ec6cf4c6 3294 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3295
ce0ad53d 3296 * image.c (clear_image_cache): Now static.
d5d5a617 3297 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3298 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3299 (x_edge_detection): Remove unnecessary cast that
3300 gcc -Wbad-function-cast diagnoses.
2037898d 3301 (gif_load): Fix pointer signedness.
6ae141d6
PE
3302 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3303 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3304
33383987 33052011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3306
d32df629
PE
3307 Improve quality of tests for time stamp overflow.
3308 For example, without this patch (encode-time 0 0 0 1 1
3309 1152921504606846976) returns the obviously-bogus value (-948597
3310 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3311 reports time overflow. See
3312 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3313 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3314 * editfns.c: Include limits.h and intprops.h.
3315 (TIME_T_MIN, TIME_T_MAX): New macros.
3316 (time_overflow): Move earlier, to before first use.
3317 (hi_time, lo_time): New functions, for an accurate test for
3318 out-of-range times.
3319 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3320 (Fget_internal_run_time): Don't assume time_t fits in int.
3321 (make_time): Use list2 instead of Fcons twice.
3322 (Fdecode_time): More accurate test for out-of-range times.
3323 (check_tm_member): New function.
3324 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3325 (lisp_time_argument): Don't rely on undefined left-shift and
3326 right-shift behavior when checking for time stamp overflow.
8be6f318 3327
fe31d94c
PE
3328 * editfns.c (time_overflow): New function, refactoring common code.
3329 (Fformat_time_string, Fdecode_time, Fencode_time):
3330 (Fcurrent_time_string): Use it.
3331
8be6f318
PE
3332 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3333 * dired.c (make_time): Move to ...
3334 * editfns.c (make_time): ... here.
3335 * systime.h: Note the move.
3336
09d9db2c 33372011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3338
126bc0dc
YM
3339 * fringe.c (update_window_fringes): Remove unused variables.
3340
c47cbdfd
YM
3341 * unexmacosx.c (copy_data_segment): Also copy __got section.
3342 (Bug#8223)
3343
7ac80be9
EZ
33442011-03-12 Eli Zaretskii <eliz@gnu.org>
3345
c96bbc66 3346 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3347 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3348 Constify `char *' arguments and their references according to
3349 prototypes in tparam.h.
3350
ecb0f94d 3351 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3352
7ac80be9
EZ
3353 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3354 Adapt all references accordingly.
3355
3356 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3357
ef1fd07e
TT
33582011-03-11 Tom Tromey <tromey@redhat.com>
3359
3360 * buffer.c (syms_of_buffer): Remove obsolete comment.
3361
7ef4b50c
EZ
33622011-03-11 Eli Zaretskii <eliz@gnu.org>
3363
3364 * termhooks.h (encode_terminal_code): Declare prototype.
3365
3366 * msdos.c (encode_terminal_code): Don't declare prototype.
3367
3368 * term.c (encode_terminal_code): Now external again, used by
3369 w32console.c and msdos.c.
3370
44f230aa
SM
3371 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3372 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3373
4b1ec863 33742011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3375
1714f52b 3376 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3377
4b1ec863
PE
3378 * fringe.c (update_window_fringes): Mark locals as initialized
3379 (Bug#8227).
3380 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3381
524c7aa6
PE
3382 * alloc.c (mark_fringe_data): Move decl from here ...
3383 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3384 to check its interface.
3385 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3386
a5c0af81 3387 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3388 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3389 (fontset_font): Mark local as initialized.
a9a06e0b 3390 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3391
b4716021
PE
3392 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3393
811e9bac 3394 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3395 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3396 (x_own_selection, Fx_disown_selection_internal): Rename locals
3397 to avoid shadowing.
3398 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3399
7e3ab302
PE
3400 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3401 so that the caller can use some name other than gcpro1.
3402 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3403 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3404 (Fx_backspace_delete_keys_p):
3405 Use them to avoid shadowing, and rename vars to avoid shadowing.
3406 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3407 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3408 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3409 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3410 Remove unused locals.
7e3ab302
PE
3411 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3412 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3413 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3414 macros.
f78faa98 3415
e2b13473
PE
3416 * xterm.h (x_mouse_leave): New decl.
3417
77f23912
PE
3418 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3419 Remove unused functions.
cdf4ba58
PE
3420 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3421 (x_calc_absolute_position): Now static.
7411c686 3422 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3423 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3424 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3425 unless they are used.
38d0b34a
PE
3426 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3427 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3428 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3429 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3430 (x_error_catcher, x_connection_closed, x_error_handler):
3431 (x_error_quitter, xembed_send_message, x_iconify_frame):
3432 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3433 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3434 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3435
44f230aa
SM
3436 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3437 Rename or move locals to avoid shadowing.
6b463e58 3438 (tty_defined_color, merge_face_heights): Now static.
5967d051 3439 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3440 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3441 does not deduce is never used uninitialized.
73719eba
PE
3442 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3443 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3444
426994c3 3445 * terminal.c (store_terminal_param): Now static.
5489860b 3446
032f1620 3447 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3448 (set_frame_menubar): Remove unused local.
d4323972 3449 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3450 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3451 since they might point to immutable storage.
281585b0
PE
3452 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3453 since it's unused otherwise.
032f1620 3454
367c19e5 3455 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3456 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3457 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3458 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3459 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3460 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3461 does not deduce are never used uninitialized.
70739cbe 3462
07b48fa9
PE
3463 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3464
8868a238 3465 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3466 * window.c (window_loop, size_window):
3467 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3468
7e5cf297 3469 * window.c (display_buffer): Now static.
d6550a9f
PE
3470 (size_window): Mark variables that gcc -Wuninitialized
3471 does not deduce are never used uninitialized.
a586633d
PE
3472 * window.h (check_all_windows): New decl, to forestall
3473 gcc -Wmissing-prototypes diagnostic.
5b555da1 3474 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3475
f6095868
PE
3476 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3477 shadowing.
3478 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3479 Include <limits.h>.
3480 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3481 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3482 (load_charset_map): Mark variables that gcc -Wuninitialized
3483 does not deduce are never used uninitialized.
53df7c11 3484 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3485
f38b440c
PE
3486 * coding.c (coding_set_source, coding_set_destination):
3487 Use "else { /* comment */ }" rather than "else /* comment */;"
3488 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3489 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3490 a block, when the outer 'i' will do.
3491 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3492 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3493 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3494 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3495 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3496 Rename locals to avoid shadowing.
3497 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3498 * coding.c (emacs_mule_char, encode_invocation_designation):
3499 Now static, since they're not used elsewhere.
413bb2db 3500 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3501 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3502 (decode_coding_emacs_mule): Mark variables that gcc
3503 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3504 (detect_coding_iso_2022): Initialize a local variable that might
3505 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3506 this initialization is needed. (Bug#8211)
5f58e762
PE
3507 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3508 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3509 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3510 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3511 Remove unused macros.
f38b440c 3512
232b38b9 3513 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3514 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3515 * character.c (string_count_byte8): Likewise.
232b38b9 3516
fb90da1b
PE
3517 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3518 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3519
fb93dbc2
PE
3520 * chartab.c (copy_sub_char_table): Now static, since it's not used
3521 elsewhere.
5c156ace
PE
3522 (sub_char_table_ref_and_range, char_table_ref_and_range):
3523 Rename locals to avoid shadowing.
bbcd0949 3524 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3525
7d3b3862 3526 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3527 (BIDI_BOB): Remove unused macro.
7d3b3862 3528
6be7d3da
PE
3529 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3530 deduce are never used uninitialized.
c2ed9c8b 3531 * term.c (encode_terminal_code): Likewise.
6be7d3da 3532
75f8807f 3533 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3534
50938595
PE
3535 * tparam.h: New file.
3536 * term.c, tparam.h: Include it.
3537 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3538 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3539 Move these decls to tparam.h, and make them agree with what
3540 is actually in tparam.c. The previous trick of using incompatible
3541 decls in different modules does not conform to the C standard.
3542 All callers of tparam changed to use tparam's actual API.
3543 * tparam.c (tparam1, tparam, tgoto):
3544 Use const pointers where appropriate.
3545
fbceeba2
PE
3546 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3547 * cm.h (struct cm): Likewise.
3548 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3549 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3550 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3551 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3552 (turn_on_face, init_tty): Likewise.
3553 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3554
7f3f1250
PE
3555 * term.c (term_mouse_position): Rename local to avoid shadowing.
3556
e6ca6543
PE
3557 * alloc.c (mark_ttys): Move decl from here ...
3558 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3559
c40f8d15
AS
35602011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3561
3562 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3563
cfe0661d
JB
35642011-03-09 Juanma Barranquero <lekktu@gmail.com>
3565
3566 * search.c (compile_pattern_1): Remove argument regp, unused since
3567 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3568 (compile_pattern): Don't pass it.
3569
0afb4571
J
35702011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3571
3572 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3573 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3574 for ! HAVE_GTK3.
3575 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3576
3577 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3578
3579 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3580 gdk_window_get_screen, gdk_window_get_geometry,
3581 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3582 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3583 (xg_get_pixbuf_from_pixmap): New function.
3584 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3585 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3586 Call xg_get_pixbuf_from_pixmap instead of
3587 gdk_pixbuf_get_from_drawable.
3588 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3589 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3590 (xg_check_special_colors): Use GtkStyleContext and its functions
3591 for HAVE_GTK3.
3592 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3593 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3594 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3595 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3596 Call gtk_widget_get_preferred_size.
0afb4571
J
3597 (xg_frame_resized): gdk_window_get_geometry only takes 5
3598 parameters.
44f230aa
SM
3599 (xg_win_to_widget, xg_event_is_for_menubar):
3600 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3601 (xg_set_widget_bg): New function.
3602 (delete_cb): New function.
895009e1 3603 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3604 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3605 (xg_set_background_color): Call xg_set_widget_bg.
3606 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3607 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3608 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3609 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3610 if ! HAVE_GTK3.
3611 (update_frame_tool_bar): Call gtk_widget_hide.
3612 (xg_initialize): Use GDK_KEY_g.
3613
3614 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3615 if ! HAVE_GTK3
3616 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3617
3618 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3619 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3620 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3621
1c2cc4ef
JB
36222011-03-08 Juanma Barranquero <lekktu@gmail.com>
3623
3624 * w32xfns.c (select_palette): Check success of RealizePalette against
3625 GDI_ERROR, not zero.
3626
33383987 3627See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3628
3629;; Local Variables:
3630;; coding: utf-8
aac0c6e3
MR
3631;; End:
3632
33383987 3633 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3634
3635 This file is part of GNU Emacs.
3636
3637 GNU Emacs is free software: you can redistribute it and/or modify
3638 it under the terms of the GNU General Public License as published by
3639 the Free Software Foundation, either version 3 of the License, or
3640 (at your option) any later version.
3641
3642 GNU Emacs is distributed in the hope that it will be useful,
3643 but WITHOUT ANY WARRANTY; without even the implied warranty of
3644 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3645 GNU General Public License for more details.
3646
3647 You should have received a copy of the GNU General Public License
3648 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.