Miscellaneous minor cleanups and simplifications.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
0bd8297f
EZ
12012-06-23 Eli Zaretskii <eliz@gnu.org>
2
96512555
EZ
3 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
4 last argument of make_unibyte_string.
5
0bd8297f
EZ
6 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
7 language ID in the event parameters.
8
9 * w32term.c (w32_read_socket): Put the new keyboard codepage into
10 event.code, not the obscure "character set ID".
11
63def6b6
CY
122012-06-23 Chong Yidong <cyd@gnu.org>
13
14 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
15
e8a02204
EZ
162012-06-23 Eli Zaretskii <eliz@gnu.org>
17
388cdec0
EZ
18 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
19 * w32.c (fdutimens): New function.
20
21 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
22
23 * s/ms-w32.h (pselect): Redirect to sys_select.
24
25 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
26
e8a02204
EZ
27 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
28 in the logic of incrementing and decrementing the value of
29 use_relocatable_buffers.
30
d054f3fb
PE
312012-06-23 Paul Eggert <eggert@cs.ucla.edu>
32
33 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
34 Privately reported by Herbert J. Skuhra.
35 [__FreeBSD__]: Remove "*/" typo after "#include".
36 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
37 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
38 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
39 Don't assume EMACS_TIME and struct timeval are the same type.
40
d35af63c
PE
412012-06-22 Paul Eggert <eggert@cs.ucla.edu>
42
43 Support higher-resolution time stamps (Bug#9000).
44 The time stamps are only nanosecond-resolution at the C level,
45 since that's the best that any real-world system supports now.
46 But they are picosecond-resolution at the Lisp level, as that's
47 easy, and leaves room for future OS improvements.
48
49 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
50 (LIBES): Use it.
51
52 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
53 Don't get current time unless it's needed.
54
55 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
56 now provides it if it's absent.
57 (start_atimer): Port to higher-res time stamps.
58 Check for time stamp overflow. Don't get current time more
59 often than is needed.
60
61 * buffer.h (struct buffer): Buffer modtime now has high resolution.
62 Include systime.h, not time.h.
63 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
64
65 * dired.c: Include stat-time.h.
66 (Ffile-attributes): File times now have higher resolution.
67
68 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
69 (struct image): Timestamp now has higher resolution.
70
71 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
72 has at least microseconds now. All uses removed.
73 (update_frame, update_single_window, update_window, update_frame_1)
74 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
75
76 * editfns.c (time_overflow): Now extern.
77 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
78 (float-time, Fformat_time_string, Fcurrent_time_string)
79 (Fcurrent_time_zone): Accept and generate higher-resolution
80 time stamps.
81 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
82 (decode_time_components, lisp_seconds_argument): New functions.
83 (make_time): Now static.
84 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
85 Report an error if the time is invalid, rather than having the caller
86 do that.
87
88 * fileio.c: Include <stat-time.h>
89 (Fcopy_file): Copy higher-resolution time stamps.
90 Prefer to set the time stamp via a file descriptor if that works.
91 (Fset_file_times, Finsert_file_contents, Fwrite_region)
92 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
93 (Fvisited_file_modtime, Fset_visited_file_modtime):
94 Support higher-resolution time stamps.
95
96 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
97
98 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
99
100 * image.c (prepare_image_for_display, clear_image_cache)
101 (lookup_image): Port to higer-resolution time stamps.
102
103 * keyboard.c (start_polling, bind_polling_period):
104 Check for time stamp overflow.
105 (read_char, kbd_buffer_get_event, timer_start_idle)
106 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
107 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
108 Port to higher-resolution time stamps. Do not assume time_t is signed.
109 (decode_timer): New function. Timers are now vectors of length 9,
110 not 8, to accommodate the picosecond component.
111 (timer_check_2): Use it.
112
113 * nsterm.m (select_timeout, timeval_subtract): Remove.
114 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
115 as they're a bit more accurate and handle overflow better.
116 (ns_select): Change prototype to be compatible with pselect.
117 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
118 * nsterm.h (ns_select): Adjust prototype.
119
120 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
121 us-resolution time stamps.
122 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
123
124 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
125
126 * lisp.h (time_overflow): New decl.
127 (wait_reading_process_output): First arg is now intmax_t, not int,
128 to accommodate larger waits.
129
130 * process.h (struct Lisp_Process.read_output_delay):
131 Now counts nanoseconds, not microseconds.
132 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
133 EMACS_HAS_USECS.
134 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
135 (wait_reading_process_output):
136 Port to ns-resolution time stamps.
137 (Faccept_process_output, wait_reading_process_output):
138 Check for time stamp overflow. Do not assume time_t is signed.
139 (select_wrapper): Remove; we now use pselect.
140 (Fprocess_attributes): Now generates ns-resolution time stamps.
141
142 * sysdep.c: Include utimens.h. Don't include utime.h
143 or worry about struct utimbuf; gnulib does that for us now.
144 (gettimeofday): Remove; gnulib provides a substitute.
145 (make_timeval): New function.
146 (set_file_times): Now sets ns-resolution time stamps.
147 New arg FD; all uses changed.
148 (time_from_jiffies, ltime_from_jiffies, get_up_time)
149 (system_process_attributes):
150 Now returns ns-resolution time stamp. All uses changed.
151 Check for time stamp overflow.
152
153 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
154 provides a substitute now.
155
156 * systime.h: Include timespec.h rather than sys/time.h and time.h,
157 since it guarantees struct timespec.
158 (EMACS_TIME): Now struct timespec, so that we can support
159 ns-resolution time stamps.
160 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
161 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
162 (EMACS_USECS): Remove.
163 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
164 so multiply the arg by 1000 before storing it.
165 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
166 New macros.
167 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
168 Port to ns-resolution time stamps.
169 (EMACS_TIME_NEG_P): Remove; replaced by....
170 (EMACS_TIME_SIGN): New macro.
171 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
172 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
173 (set_file_times, make_time, lisp_time_argument): Adjust signature.
174 (make_timeval, make_lisp_time, decode_time_components): New decls.
175 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
176 that it mishandled time_t overflow. You can't compare by subtracting!
177 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
178 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
179
180 * term.c: Include <sys/time.h>.
181 (timeval_to_Time): New function, for proper overflow wraparound.
182 (term_mouse_position, term_mouse_click): Use it.
183
184 * undo.c (record_first_change): Support higher-resolution time stamps
185 in the undo buffer.
186 (Fprimitive_undo): Use them when restoring time stamps.
187
188 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
189 (w32_get_internal_run_time):
190 Port to higher-resolution Emacs time stamps.
191 (ltime): Now accepts single 64-bit integer, as that's more convenient
192 for callers.
193
194 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
195
196 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
197 for compatibility with pselect. Support ns-resolution time stamps.
198
199 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
200
201 * xselect.c (wait_for_property_change, x_get_foreign_selection):
202 Check for time stamp overflow, and support ns-resolution time stamps.
203
204 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
205 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
206 (timeval_subtract): Remove; no longer needed.
207 (XTflash, XTring_bell, x_wait_for_event):
208 Port to ns-resolution time stamps. Don't assume time_t is signed.
209
b6a92dfe
CY
2102012-06-22 Chong Yidong <cyd@gnu.org>
211
212 * xdisp.c (x_consider_frame_title): Revert last change.
213
d251c37c
EZ
2142012-06-22 Eli Zaretskii <eliz@gnu.org>
215
216 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
217 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
218 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
219 staticidx goes up to 1597 out of 1600 = 0x640.)
220
f10deafb
PE
2212012-06-20 Paul Eggert <eggert@cs.ucla.edu>
222
223 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
224 Otherwise, the umask might be mistakenly 0 while handling input signals.
225
ec6de1e2
SM
2262012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
227
228 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
229
28be1ada
DA
2302012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
231
232 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
233 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
234 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
235 access to `contents' member of Lisp_Vector objects with AREF and ASET
236 where appropriate.
237
c6bf3022
CY
2382012-06-19 Chong Yidong <cyd@gnu.org>
239
240 * frame.c (delete_frame): When selecting a frame on a different
241 text terminal, do not alter the terminal's top-frame.
242
243 * xdisp.c (format_mode_line_unwind_data): Record the target
244 frame's selected window and its terminal's top-frame.
245 (unwind_format_mode_line): Restore them.
246 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
247 Callers changed.
248 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
249 since tty frames can be explicitly named.
250 (prepare_menu_bars): Likewise.
251
252 * term.c (Ftty_top_frame): New function.
253
defd4196
PE
2542012-06-18 Paul Eggert <eggert@cs.ucla.edu>
255
256 Port byte-code-meter to modern targets.
257 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
258 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 259 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
260 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
261 (METER_1, METER_2): Simplify.
262
1053a871
SM
2632012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
264
265 * data.c (Fdefalias): Return `symbol' (bug#11686).
266
b7e8d081
MR
2672012-06-18 Martin Rudalics <rudalics@gmx.at>
268
269 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
270 gets killed during executing of this function (Bug#11665).
271 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
272 (Vkill_buffer_query_functions): In doc-string say that functions
273 run by this hook should not change the current buffer.
274
7ea2b339
PE
2752012-06-18 Paul Eggert <eggert@cs.ucla.edu>
276
277 Fix recently-introduced process.c problems found by static checking.
278 * process.c (write_queue_push, write_queue_pop, send_process):
279 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
280 (write_queue_pop): Fix pointer signedness problem.
281 (send_process): Remove unused local.
282
96a313a1
CY
2832012-06-17 Chong Yidong <cyd@gnu.org>
284
285 * xdisp.c (redisplay_internal): No need to redisplay terminal
286 frames that are not on top.
287
20ca2e94
TN
2882012-06-17 Troels Nielsen <bn.troels@gmail.com>
289
290 * process.c (make_process): Initialize write_queue.
291 (write_queue_push, write_queue_pop): New functions.
292 (send_process): Use them to maintain correct ordering of process
293 writes (Bug#10815).
294
9a900ca9
PE
2952012-06-17 Paul Eggert <eggert@cs.ucla.edu>
296
310fbfa8
PE
297 * lisp.h (eassert): Assume C89 or later.
298 This removes the need for CHECK.
299 (CHECK): Remove. Its comments about always evaluating its
300 argument were confusing, as 'eassert' typically does not evaluate
301 its argument.
302
27bb1ca4
PE
303 * coding.c (produce_chars): Use ptrdiff_t, not int.
304
9a900ca9
PE
305 * xterm.c (x_draw_underwave): Check for integer overflow.
306 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
307
41b7f8bc 3082012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
309
310 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
311 referenced (Bug#11583).
312
9b0e3eba
AA
3132012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
314
315 Implement wave-style variant of underlining.
316 * dispextern.h (face_underline_type): New enum.
317 (face): Add field for underline type.
318 * nsterm.m (ns_draw_underwave): New function.
319 (ns_draw_text_decoration): Use it.
320 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
321 New functions.
322 (x_draw_glyph_string): Use them.
323 * xfaces.c (Qline, Qwave): New Lisp objects.
324 (check_lface_attrs, merge_face_ref)
1053a871
SM
325 (Finternal_set_lisp_face_attribute, realize_x_face):
326 Handle wave-style underline face attributes.
9b0e3eba
AA
327 * xterm.c (x_draw_underwave): New function.
328 (x_draw_glyph_string): Use it.
329
0fb52f11
JB
3302012-06-16 Juanma Barranquero <lekktu@gmail.com>
331
332 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
333 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
334 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
335 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
336 ($(BLD)/w32select.$(O)): Update dependencies.
337
e5560ff7
AS
3382012-06-16 Andreas Schwab <schwab@linux-m68k.org>
339
340 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
341 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
342 * character.c (_fetch_multibyte_char_p): Remove.
343 * alloc.c: Include "character.h" before "buffer.h".
344 * bidi.c: Likewise.
345 * buffer.c: Likewise.
346 * bytecode.c: Likewise.
347 * callint.c: Likewise.
348 * callproc.c: Likewise.
349 * casefiddle.c: Likewise.
350 * casetab.c: Likewise.
351 * category.c: Likewise.
352 * cmds.c: Likewise.
353 * coding.c: Likewise.
354 * composite.c: Likewise.
355 * dired.c: Likewise.
356 * dispnew.c: Likewise.
357 * doc.c: Likewise.
358 * dosfns.c: Likewise.
359 * editfns.c: Likewise.
360 * emacs.c: Likewise.
361 * fileio.c: Likewise.
362 * filelock.c: Likewise.
363 * font.c: Likewise.
364 * fontset.c: Likewise.
365 * fringe.c: Likewise.
366 * indent.c: Likewise.
367 * insdel.c: Likewise.
368 * intervals.c: Likewise.
369 * keyboard.c: Likewise.
370 * keymap.c: Likewise.
371 * lread.c: Likewise.
372 * macros.c: Likewise.
373 * marker.c: Likewise.
374 * minibuf.c: Likewise.
375 * nsfns.m: Likewise.
376 * nsmenu.m: Likewise.
377 * print.c: Likewise.
378 * process.c: Likewise.
379 * regex.c: Likewise.
380 * region-cache.c: Likewise.
381 * search.c: Likewise.
382 * syntax.c: Likewise.
383 * term.c: Likewise.
384 * textprop.c: Likewise.
385 * undo.c: Likewise.
386 * unexsol.c: Likewise.
387 * w16select.c: Likewise.
388 * w32fns.c: Likewise.
389 * w32menu.c: Likewise.
390 * window.c: Likewise.
391 * xdisp.c: Likewise.
392 * xfns.c: Likewise.
393 * xmenu.c: Likewise.
394 * xml.c: Likewise.
395 * xselect.c: Likewise.
396
2f07e6af
EZ
3972012-06-16 Eli Zaretskii <eliz@gnu.org>
398
1053a871
SM
399 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
400 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 401 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
402 row.
403 (handle_face_prop): Use chunk-relative overlay string index when
404 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
405 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
406 the rightmost. (Bug#11720)
2f07e6af 407
29b83cec
AS
4082012-06-16 Andreas Schwab <schwab@linux-m68k.org>
409
410 * category.h (CHAR_HAS_CATEGORY): Define as inline.
411 (CATEGORY_MEMBER): Enforce 1/0 value.
412 * category.c (_temp_category_set): Remove.
413
4c5501e9
EZ
4142012-06-16 Eli Zaretskii <eliz@gnu.org>
415
416 * window.c (Fdelete_other_windows_internal)
417 (Fdelete_window_internal): Don't access frame's mouse highlight
418 info of the initial frame. (Bug#11677)
419
2b570124
PE
4202012-06-14 Paul Eggert <eggert@cs.ucla.edu>
421
e93864f9
PE
422 * .gdbinit (xgetint): Fix recently-introduced paren typo.
423 Assume USE_2_TAGS_FOR_INTS.
424 (xreload): Adjust $tagmask width to match recent lisp.h change.
425
2b570124
PE
426 Simplify lisp.h in minor ways that should not affect code.
427 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
428 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
429 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
430 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
431 (INTTYPEBITS): New macro, for clarity.
432 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
433 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
434 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
435 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
436 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
437
81755f69
JB
4382012-06-13 Juanma Barranquero <lekktu@gmail.com>
439
440 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
441
16192a57
GM
4422012-06-13 Glenn Morris <rgm@gnu.org>
443
444 * s/bsd-common.h (BSD4_3):
445 * s/usg5-4-common.h (USG5_4): No longer define; unused.
446
646b5f55
AS
4472012-06-13 Andreas Schwab <schwab@linux-m68k.org>
448
449 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
450 instead of union.
451 (XLI, XIL): Define.
1053a871
SM
452 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
453 Use them.
454 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 455 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 456 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
457 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
458 * frame.c (delete_frame): Remove outdated comment.
459 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
460 USE_LISP_UNION_TYPE.
461 (Fw32_unregister_hot_key): Likewise.
462 (Fw32_toggle_lock_key): Likewise.
463 * w32menu.c (add_menu_item): Likewise.
464 (w32_menu_display_help): Use XIL instead of checking
465 USE_LISP_UNION_TYPE.
466 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
467 (init_heap): Likewise.
468 * w32term.c (w32_read_socket): Update comment.
469
1d3823c9
GM
4702012-06-13 Glenn Morris <rgm@gnu.org>
471
c62ff706
GM
472 * s/usg5-4-common.h, src/s/unixware.h:
473 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
474
1d3823c9
GM
475 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
476
bfe3e0a2
PE
4772012-06-13 Paul Eggert <eggert@cs.ucla.edu>
478
479 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
480 * alloc.c (make_number) [!defined make_number]:
481 Remove, as lisp.h always defines this now.
482 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
483 (roundup_size): Verify that it is a power of 2.
484 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
485 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
486 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
487 -DUSE_LSB_TAG=0, to override the automatically-selected default.
488 USE_LSB_TAG now is always defined to be either 0 or 1.
489 All uses changed.
490 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
491 code works fine either way, and efficiency is not a concern here,
492 as the union type is for debugging, not for production.
493 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
494 Use an inline function on all platforms when using the union type,
495 since this is simpler and 'static inline' can be used portably
496 within Emacs now.
497 (LISP_INITIALLY_ZERO): New macro.
498 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
499 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
500
45fa9c0f
GM
5012012-06-12 Glenn Morris <rgm@gnu.org>
502
b4492cba
GM
503 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
504
505 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 506
45fa9c0f
GM
507 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
508 Move BROKEN_SIGIO to configure.
509
510 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
511 Move NO_TERMIO to configure.
512
0e25d334
CY
5132012-06-12 Chong Yidong <cyd@gnu.org>
514
515 * image.c (imagemagick_load_image): Use MagickFlattenImage if
516 MagickMergeImageLayers is undefined. Use pixel pusher loop if
517 MagickExportImagePixels is undefined.
518
43682bb6
PE
5192012-06-12 Paul Eggert <eggert@cs.ucla.edu>
520
521 * image.c (imagemagick_load_image): Remove unused label.
522
a9be7d2b
GM
5232012-06-11 Glenn Morris <rgm@gnu.org>
524
525 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
526 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
527 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
528 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
529
3017f87f
SM
5302012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
531
532 * alloc.c (make_byte_code): New function.
533 (Fmake_byte_code): Use it. Don't purify here.
534 * lread.c (read1): Use it as well to avoid extra allocation.
535
1b9b4cf4
CY
5362012-06-11 Chong Yidong <cyd@gnu.org>
537
538 * image.c (imagemagick_load_image): Implement transparency.
539
95988fcf
AS
5402012-06-10 Andreas Schwab <schwab@linux-m68k.org>
541
542 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
543 account for preceding backslashes. (Bug#11663)
544
cd4eb164
CY
5452012-06-09 Chong Yidong <cyd@gnu.org>
546
547 * term.c: Support italics in capable terminals (Bug#9652).
548 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
549 (turn_on_face): Output using TS_enter_italic_mode if available.
550 Don't handle unused blinking and alt-charset cases.
551 (turn_off_face): Handle italic case; discard unused tty_blinking_p
552 and tty_alt_charset_p cases.
553 (tty_capable_p, init_tty): Support italics.
554
555 * termchar.h (struct tty_display_info): Add field for italics.
556 Remove unused blink field.
557
558 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
559 Handle slant.
560
561 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
562 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
563 tty_alt_charset_p. Add tty_italic_p.
564
ff88beb8
MA
5652012-06-09 Michael Albinus <michael.albinus@gmx.de>
566
567 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
568 dbus_type_is_basic if available.
569 (xd_extract_signed, xd_extract_unsigned): Rename from
570 extract_signed and extract_unsigned, respectively. Adapt callers.
571
44286096
CY
5722012-06-09 Chong Yidong <cyd@gnu.org>
573
1682701f
CY
574 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
575
44286096
CY
576 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
577 case (Bug#9752).
578
d86feb17
PE
5792012-06-08 Paul Eggert <eggert@cs.ucla.edu>
580
581 * xdisp.c (vmessage): Treat frame message as multibyte.
582 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
583 would generate the diagnostic "Making \302\247 buffer-local while
584 let-bound!".
585
d5c20fe8
EZ
5862012-06-08 Eli Zaretskii <eliz@gnu.org>
587
588 * dispnew.c (showing_window_margins_p): Undo last change, which
589 was done due to an inadvertent commit.
590 (adjust_frame_glyphs_for_frame_redisplay): Do call
591 showing_window_margins_p.
592
513749ee
SM
5932012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
594
595 * eval.c (Fmake_var_non_special): New primitive.
596 (syms_of_eval): Defsubr it.
597 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
598
d4a8f5c1
JB
5992012-06-08 Juanma Barranquero <lekktu@gmail.com>
600
601 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
602 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
603
8bbbc977
EZ
6042012-06-08 Eli Zaretskii <eliz@gnu.org>
605
606 * alloc.c (allocate_vectorlike): Fix last change.
607
f3372c87
DA
6082012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
609
610 Block-based vector allocation of small vectors.
611 * lisp.h (struct vectorlike_header): New field `nbytes',
612 adjust comment accordingly.
613 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
614 to denote vector blocks. Adjust users (live_vector_p,
615 mark_maybe_pointer, valid_lisp_object_p) accordingly.
616 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
617 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
618 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
619 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
620 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
621 (roundup_size): New constant.
622 (struct vector_block): New data type.
623 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 624 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
625 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
626 (sweep_vectors): New functions.
627 (allocate_vectorlike): Return `zero_vector' as the only vector of
628 0 items. Allocate new vector from block if vector size is less than
629 or equal to VBLOCK_BYTES_MAX.
630 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
631 (init_alloc_once): Add call to init_vectors.
632
4f18a4ed
SM
6332012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
634
635 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
636
86f158bc
PE
6372012-06-07 Paul Eggert <eggert@cs.ucla.edu>
638
639 * doprnt.c (doprnt): Truncate multibyte char correctly.
640 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
641 would mishandle a string argument "Xc" if X was a multibyte
642 character of length 2: it would truncate after X's first byte
643 rather than including all of X.
644
c5cfcbe0
CY
6452012-06-06 Chong Yidong <cyd@gnu.org>
646
647 * buffer.c (word_wrap): Doc fix.
648
c05cf390
PE
6492012-06-04 Paul Eggert <eggert@cs.ucla.edu>
650
651 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
652
0c3461de
GM
6532012-06-03 Glenn Morris <rgm@gnu.org>
654
655 * xdisp.c (tool-bar-style): Doc fix.
656
c71232db
UM
6572012-06-03 Ulrich Müller <ulm@gentoo.org>
658
659 * Makefile.in (PAXCTL): Define.
660 (temacs$(EXEEXT)): Disable memory randomization for the temacs
661 binary via PaX flags if the paxctl utility is available.
662 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
663 Restore PaX flags to their default. (Bug#11398)
664
383f7350
CY
6652012-06-03 Chong Yidong <cyd@gnu.org>
666
667 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
668 buffer (Bug#11226).
669
5f2c76c6
CY
6702012-06-03 Chong Yidong <cyd@gnu.org>
671
672 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
673 (note_mode_line_or_margin_highlight): If there is no help echo,
674 use mode-line-default-help-echo. Handle the case where the mouse
675 position is past the end of the mode line string.
676
677 * buffer.c (buffer_local_value_1): New function, split from
678 Fbuffer_local_value; can return Qunbound.
679 (Fbuffer_local_value): Use it.
680 (Vmode_line_format): Docstring tweaks.
681
773d47f6
PE
6822012-06-02 Paul Eggert <eggert@cs.ucla.edu>
683
684 * sysdep.c (system_process_attributes): Improve comment.
685
f2d6a3df
SM
6862012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
687
688 * keyboard.c: Export real-this-command to Elisp.
689 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
690 and DEFVAR it. Update all users.
691
63810350
PE
6922012-06-02 Paul Eggert <eggert@cs.ucla.edu>
693
7bd5c1f4
PE
694 * minibuf.c (Fassoc_string): Remove duplicate declaration.
695
63810350
PE
696 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
697 Convert pctcpu and pctmem to Lisp float properly.
698 Let the compiler fold better, as 100.0/0x8000 is exact.
699
a2821611
AS
7002012-06-02 Andreas Schwab <schwab@linux-m68k.org>
701
702 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
703 cons_block.
704
5fceba1d
PE
7052012-06-01 Paul Eggert <eggert@cs.ucla.edu>
706
707 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
708
c98ff5dd
DA
7092012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
710
711 For a 'struct window', replace some Lisp_Object fields to
712 bitfields where appropriate, remove unused fields.
713 * window.h (struct window): Remove unused 'last_mark_x' and
714 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
715 change it's type from Lisp_Object to bitfield.
716 Change type of 'force_start', 'optional_new_start',
717 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
718 fields from Lisp_Object to bitfield. Adjust users accordingly.
719
ca34e0be
PE
7202012-05-31 Paul Eggert <eggert@cs.ucla.edu>
721
722 Pacify gcc -Wdouble-precision when using Xaw.
723 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
724 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
725 Use 'float' consistently, rather than 'float' in most places
726 and 'double' in a couple of places.
727
efc00ab1 7282012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
729
730 * xdisp.c (handle_stop): Detect whether we have overlay strings
731 loaded by testing it->current.overlay_string_index to be
732 non-negative, instead of checking whether n_overlay_strings is
733 positive. (Bug#11587)
734
efc00ab1 7352012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
736
737 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
738
739 * doc.c (Fsubstitute_command_keys): Doc fix.
740
efc00ab1 7412012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
742
743 * search.c (search_buffer): Remove calls to
744 r_alloc_inhibit_buffer_relocation, as it is now called by
745 maybe_unify_char, which was the cause of relocation of buffer text
746 in bug#11519.
747
efc00ab1 7482012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
749
750 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
751 for the duration of call to load_charset, to avoid problems with
752 callers of maybe_unify_char that access buffer text through C
753 pointers.
754
755 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
756 decrement the inhibition flag, instead of just setting or
757 resetting it.
758
ba93a187
PE
7592012-05-31 Paul Eggert <eggert@cs.ucla.edu>
760
761 Remove obsolete '#define static' cruft.
762 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
763 This #undef was "temporary" in 2000; it is no longer needed
764 now that '#define static' has gone away.
765 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
766 (gray_bitmap_bits): Remove; no longer needed.
767 All uses replaced with definiens.
768 * xterm.c: Include "bitmaps/gray.xbm".
769
9e4bf381
PE
7702012-05-30 Paul Eggert <eggert@cs.ucla.edu>
771
772 Clean up __executable_start, monstartup when --enable-profiling.
773 The following changes affect the code only when profiling.
774 * dispnew.c (__executable_start): Rename from safe_bcopy.
775 Define only on platforms that need it.
776 * emacs.c: Include <sys/gmon.h> when profiling.
777 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
778 (__executable_start): Remove decl, since lisp.h does it now.
779 (safe_bcopy): Remove decl; no longer has that name.
780 (main): Coalesce #if into single bit of code, for simplicity.
781 Cast pointers to uintptr_t, since standard libraries want integers
782 and not pointers.
783 * lisp.h (__executable_start): New decl.
784
32d72c2f
GM
7852012-05-31 Glenn Morris <rgm@gnu.org>
786
787 * image.c (Fimagemagick_types): Doc fix.
788
baac5bc7
JM
7892012-05-30 Jim Meyering <meyering@redhat.com>
790
791 * callproc.c (Fcall_process_region): Include directory component
792 in mkstemp error message (Bug#11586).
793
72cb32cf
PE
7942012-05-30 Paul Eggert <eggert@cs.ucla.edu>
795
796 * alloc.c, lisp.h (make_pure_vector): Now static.
797
61b108cc
SM
7982012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
799
800 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
801 Move to byte-run.el.
802 (Fautoload): Do the hash-doc more carefully.
803 * data.c (Fdefalias): Purify definition, except for keymaps.
804 (Qdefun): Move from eval.c.
805 * lisp.h (Qdefun): Remove.
806 * lread.c (read1): Tiny simplification.
807
471fe23d
TN
8082012-05-29 Troels Nielsen <bn.troels@gmail.com>
809
934f3f58 810 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
811 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
812 Bug#9642, but explicitly check that the buffer the overlay would
813 be moved to is live and rearrange lines to make sure that errors
814 will not put the overlay in an inconsistent state.
815 (Fdelete_overlay): Cosmetics.
816
85d0efd1
EZ
8172012-05-28 Eli Zaretskii <eliz@gnu.org>
818
819 * w32term.c (my_bring_window_to_top): New function.
820 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
821 could be different from the original one.
822 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
823 (Bug#11513)
824
825 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
826 by calling BringWindowToTop.
827
828 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
829 (WM_EMACS_END): Increase by one.
830
da92a98c
PE
8312012-05-28 Paul Eggert <eggert@cs.ucla.edu>
832
833 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
834 This avoids undefined behavior that might cause the eassert
835 to not catch an out-of-range value.
836
74d1f848
JB
8372012-05-28 Juanma Barranquero <lekktu@gmail.com>
838
839 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
840 Update dependencies.
841
9e1a06fc
EZ
8422012-05-27 Eli Zaretskii <eliz@gnu.org>
843
844 * bidi.c (bidi_mirror_char): Fix last change.
845
f3dd7312
AS
8462012-05-27 Andreas Schwab <schwab@linux-m68k.org>
847
848 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
849 when referring to sectname field in printf format.
850
81899c91
PE
8512012-05-27 Paul Eggert <eggert@cs.ucla.edu>
852
57b81a9f
PE
853 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
854 Only r_alloc_inhibit_buffer_relocation needed to be added;
855 the others were already declared.
856
81899c91
PE
857 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
858 before checking whether it's out of range. Put the check inside
859 eassert. See
860 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
861
33017faf 8622012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
863
864 * callproc.c (Fcall_process): Restore a line that was accidentally
865 commented out in the 2011-02-13 change (bug#11547).
866
33017faf 8672012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
868
869 * lisp.h [REL_ALLOC]: Add prototypes for external functions
870 defined on ralloc.c.
871
872 * buffer.c [REL_ALLOC]: Remove prototypes of
873 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
874 they are now on lisp.h.
875
876 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
877
878 * search.c (search_buffer): Use it to inhibit relocation of buffer
879 text while re_search_2 is doing its job, because re_search_2 is
880 passed C pointers to buffer text. (Bug#11519)
881
23415acf
EZ
882 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
883 Update value to 24.
884
44e27368
EZ
885 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
886 state after an additional call to move_it_in_display_line_to, keep
887 the values of it->max_ascent and it->max_descent found for the
888 entire line.
889 (pos_visible_p): Revert the comparison against bottom_y to what it
890 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
891 (Bug#11464)
892
c1892f11
PE
8932012-05-26 Paul Eggert <eggert@cs.ucla.edu>
894
895 Fix coding-related core dumps with gcc -ftrapv.
896 The code was computing A - B, where A and B are pointers, and B is
897 random garbage. This can lead to core dumps on platforms that
898 have special pointer registers, and it also leads to core dumps on
899 x86-64 when compiled with gcc -ftrapv. The fix is to compute
900 A - B only when B is initialized properly.
901 * coding.c (coding_set_source, coding_set_destination): Return void.
902 (coding_change_source, coding_change_destinations): New functions,
903 with the old behaviors of coding_set_source and coding_set_destination.
904 All callers that need an offset changed to use these new functions.
905
eb7afdad
GM
9062012-05-26 Glenn Morris <rgm@gnu.org>
907
908 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
909
f12fdf02
EZ
9102012-05-26 Eli Zaretskii <eliz@gnu.org>
911
53a63be6 912 Extend mouse support on W32 text-mode console.
61b108cc
SM
913 * xdisp.c (draw_row_with_mouse_face):
914 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 915
eb3f6f01 916 * w32console.c: Include window.h.
61b108cc
SM
917 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
918 New functions.
eb3f6f01
EZ
919 (initialize_w32_display): Initialize mouse-highlight data.
920
53a63be6
EZ
921 * w32inevt.c: Include termchar.h and window.h.
922 (do_mouse_event): Support mouse-autoselect-window. When the mouse
923 moves, call note_mouse_highlight. If help_echo changed, call
924 gen_help_event to produce help-echo message in the echo area.
925 Call clear_mouse_face if mouse_face_hidden is set in the mouse
926 highlight info.
927
4cfd81f6
PE
9282012-05-26 Paul Eggert <eggert@cs.ucla.edu>
929
930 * lread.c (read1): Simplify slightly to avoid an overflow warning
931 with GCC 4.7.0 on x86-64.
932
4446092a
EZ
9332012-05-26 Eli Zaretskii <eliz@gnu.org>
934
935 * bidi.c (bidi_mirror_char): Revert last change: an int is
936 definitely wide enough here.
937
42b2a986 9382012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 939
42b2a986 940 Fix integer width and related bugs (Bug#9874).
eb106a49 941 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
942 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
943 (string_bytes, check_sblock, allocate_string_data):
944 (compact_small_strings, Fmake_bool_vector, make_string)
945 (make_unibyte_string, make_multibyte_string)
946 (make_string_from_bytes, make_specified_string)
947 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
948 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
949 (mark_vectorlike):
950 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
951 (allocate_pseudovector):
952 Use int, not EMACS_INT, where int is wide enough.
953 (inhibit_garbage_collection, Fgarbage_collect):
954 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
955 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
956 int might not be wide enough.
957 (bidi_cache_search, bidi_cache_find, bidi_init_it)
958 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
959 (bidi_at_paragraph_end, bidi_find_paragraph_start)
960 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
961 (bidi_level_of_next_char, bidi_move_to_visually_next):
962 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
963 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
964 (Fkill_buffer, Fset_buffer_major_mode)
965 (advance_to_char_boundary, Fbuffer_swap_text)
966 (Fset_buffer_multibyte, overlays_at, overlays_in)
967 (overlay_touches_p, struct sortvec, record_overlay_string)
968 (overlay_strings, recenter_overlay_lists)
969 (adjust_overlays_for_insert, adjust_overlays_for_delete)
970 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
971 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
972 (Foverlay_recenter, last_overlay_modification_hooks_used)
973 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
974 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
975 (validate_region): Omit unnecessary test for b <= e,
976 since that's guaranteed by the previous test.
d311d28c
PE
977 (adjust_overlays_for_delete): Avoid pos + length overflow.
978 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
979 (report_overlay_modification):
980 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
981 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
982 Omit pointer cast, which isn't needed anyway, and doesn't work
983 after the EMACS_INT -> ptrdiff_t change.
02481186 984 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
985 * buffer.h: Adjust decls to match defn changes elsewhere.
986 (struct buffer_text, struct buffer):
987 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
988 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
989 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
990 not int, to avoid needless 32-bit limit on 64-bit hosts.
991 (exec_byte_code): Use tighter memory-full test, one that checks
992 for alloca overflow. Don't compute the address of the object just
993 before an array, as that's not portable. Use EMACS_INT, not
994 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
995 * callint.c (Fcall_interactively):
996 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
997 * callproc.c (call_process_kill, Fcall_process):
998 Don't assume pid_t fits into an Emacs fixnum.
999 (call_process_cleanup, Fcall_process, child_setup):
1000 Don't assume pid_t fits into int.
1001 (call_process_cleanup, Fcall_process, delete_temp_file)
1002 (Fcall_process_region):
1003 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1004 (Fcall_process): Simplify handling of volatile integers.
1005 Use int, not EMACS_INT, where int will do.
1006 * casefiddle.c (casify_object, casify_region, operate_on_word)
1007 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1008 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1009 (casify_object): Avoid integer overflow when overallocating buffer.
1010 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1011 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1012 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1013 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1014 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1015 integers are now checked earlier. All uses replaced with XINT.
1016 (ccl_driver):
1017 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1018 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1019 (ccl_driver, Fregister_code_conversion_map):
1020 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1021 (resolve_symbol_ccl_program): Check that vector header is in range.
1022 Always copy the vector, so that we can check its contents reliably
1023 now rather than having to recheck each instruction as it's being
1024 executed. Check that vector words fit in 'int'.
1025 (ccl_get_compiled_code, Fregister_ccl_program)
1026 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1027 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1028 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1029 contents are in range.
1030 (Fccl_execute_on_string): Check that status is in range.
1031 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1032 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1033 Accept and return EMACS_INT, not int, because callers can pass values
1034 out of 'int' range.
1035 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1036 (multibyte_chars_in_text, parse_str_as_multibyte)
1037 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1038 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1039 (string_escape_byte8, Fget_byte):
1040 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1041 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1042 avoid mishandling large integers.
1043 * character.h: Adjust decls to match defn changes elsewhere.
1044 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1045 (Ffind_charset_region):
1046 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1047 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1048 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1049 Don't assume fixnum fits in int.
d311d28c
PE
1050 (load_charset_map_from_vector, Fmap_charset_chars):
1051 Remove now-unnecessary CHECK_NATNUMs.
1052 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1053 Don't rely on undefined behavior with signed left shift overflow.
1054 Don't assume unsigned int fits into fixnum, or that fixnum fits
1055 into unsigned int. Don't require max_code to be a valid fixnum;
1056 that's not true for gb10830 4-byte on a 32-bit host. Allow
1057 invalid_code to be a cons, for the same reason. Require code_offset
1058 to be a character. Avoid int overflow if max_char is close
1059 to INT_MAX.
1060 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1061 this is intended anyway and avoids some undefined behavior.
1062 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1063 INDEX_TO_CODE_POINT, as that's what it expects.
1064 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1065 * charset.h (DECODE_CHAR): Return int, not unsigned;
1066 this is what was intended anyway, and it avoids undefined behavior.
1067 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1068 integer-overflow issues.
1069 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1070 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1071 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1072 * chartab.c (Fmake_char_table, Fset_char_table_range)
1073 (uniprop_get_decoder, uniprop_get_encoder):
1074 Don't assume fixnum fits in int.
1075 * cmds.c (move_point): New function, that does the gist of
1076 Fforward_char and Fbackward_char, but does so while checking
1077 for integer overflow more accurately.
c96e5d6a 1078 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1079 (Fforward_line, Fend_of_line, internal_self_insert)
1080 (internal_self_insert):
1081 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1082 Fix a FIXME, by checking for integer overflow when calculating
1083 target_clm and actual_clm.
1084 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1085 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1086 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1087 (coding_alloc_by_making_gap, alloc_destination)
1088 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1089 (encode_coding_utf_16, detect_coding_emacs_mule)
1090 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1091 (detect_coding_iso_2022, decode_coding_iso_2022)
1092 (encode_invocation_designation, encode_designation_at_bol)
1093 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1094 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1095 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1096 (encode_coding_ccl, encode_coding_raw_text)
1097 (detect_coding_charset, decode_coding_charset)
1098 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1099 (produce_composition, produce_charset, produce_annotation)
1100 (decode_coding, handle_composition_annotation)
1101 (handle_charset_annotation, consume_chars, decode_coding_gap)
1102 (decode_coding_object, encode_coding_object, detect_coding_system)
1103 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1104 (code_convert_region, code_convert_string)
8f50130c
PE
1105 (Fdefine_coding_system_internal)
1106 (coding_set_source, coding_set_destination):
d311d28c
PE
1107 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1108 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1109 (Fdefine_coding_system_internal):
1110 Don't assume fixnums fit in int.
1111 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1112 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1113 (Funencodable_char_position, Fcheck_coding_systems_region)
1114 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1115 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1116 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1117 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1118 Don't access memory outside of the args array.
d311d28c 1119 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1120 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1121 result of ENCODE_CHAR.
d311d28c
PE
1122 * coding.h: Adjust decls to match defn changes elsewhere.
1123 (struct coding_system):
1124 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1125 * composite.c (get_composition_id, find_composition)
1126 (run_composition_function, update_compositions)
1127 (compose_text, composition_gstring_put_cache)
1128 (composition_gstring_p, composition_gstring_width)
1129 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1130 (composition_compute_stop_pos, composition_reseat_it)
1131 (composition_update_it, struct position_record)
1132 (find_automatic_composition, composition_adjust_point)
1133 (Fcomposition_get_gstring, Ffind_composition_internal):
1134 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1135 (update_compositions):
1136 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1137 * composite.h: Adjust decls to match defn changes elsewhere.
1138 (struct composition):
1139 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1140 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1141 Do not attempt to compute the address of the object just before a
1142 buffer; this is not portable.
1143 (Faref, Faset):
1144 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1145 (Faset): Use int, not EMACS_INT, where int is wide enough.
1146 (Fstring_to_number): Don't assume fixnums fit in int.
1147 (Frem): Don't assume arg is nonnegative.
1148 * dbusbind.c (xd_append_arg): Check for integers out of range.
1149 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1150 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1151 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1152 (xd_get_connection_references): Return ptrdiff_t, not int.
1153 All uses changed.
1154 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1155 (xd_read_message_1):
1156 Use int, not unsigned, where the dbus API uses int.
1157 (Fdbus_message_internal): Don't overflow mtype.
1158 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
1159 * dired.c (directory_files_internal, file_name_completion, scmp)
1160 (file_name_completion_stat):
1161 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1162 (file_name_completion): Don't overflow matchcount.
1163 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1164 * dispextern.h: Adjust decls to match defn changes elsewhere.
1165 (struct text_pos, struct glyph, struct bidi_saved_info)
1166 (struct bidi_string_data, struct bidi_it, struct composition_it)
1167 (struct it):
1168 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1169 (struct display_pos, struct composition_it, struct it):
1170 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1171 * dispnew.c (increment_matrix_positions)
1172 (increment_row_positions, mode_line_string)
1173 (marginal_area_string):
1174 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 1175 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
1176 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1177 (duration_to_sec_usec): New function, to check for overflow better.
1178 (Fsleep_for, sit_for): Use it.
1179 * doc.c (get_doc_string, store_function_docstring):
1180 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1181 (get_doc_string, Fsnarf_documentation):
1182 Use int, not EMACS_INT, where int is wide enough.
1183 (get_doc_string):
1184 Use SAFE_ALLOCA, not alloca.
1185 Check for overflow when converting EMACS_INT to off_t.
1186 * doprnt.c (doprnt):
1187 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1188 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1189 Don't assume uid_t fits into fixnum.
1190 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1191 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1192 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1193 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1194 (general_insert_function)
1195 (Finsert_char, make_buffer_string, make_buffer_string_both)
1196 (update_buffer_properties, Fbuffer_substring)
1197 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1198 (Fsubst_char_in_region, check_translation)
1199 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1200 (transpose_markers, Ftranspose_regions):
1201 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1202 (clip_to_bounds): Move to lisp.h as an inline function).
1203 (Fconstrain_to_field): Don't assume integers are nonnegative.
1204 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1205 (Fsubst_char_in_region, Fsave_restriction):
1206 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1207 (Femacs_pid): Don't assume pid_t fits into fixnum.
1208 (lo_time): Use int, not EMACS_INT, when int suffices.
1209 (lisp_time_argument): Check for usec out of range.
1210 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
1211 (Fuser_login_name, Fuser_full_name): Signal an error
1212 if a uid argument is out of range, rather than relying on
1213 undefined behavior.
c8d5c857
PE
1214 (Fformat_time_string): Remove now-unnecessary check.
1215 lisp_time_argument checks for out-of-range usec now.
243e0530 1216 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
1217 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1218 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1219 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1220 (init_cmdargs, Fdump_emacs):
1221 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1222 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1223 the bottom (typically) 32 bits of the fixnum.
1224 * eval.c (specpdl_size, call_debugger):
1225 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1226 (when_entered_debugger, Fbacktrace_debug):
1227 Don't assume fixnum can fit in int.
1228 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1229 the object just before a buffer; this is not portable.
1230 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1231 (grow_specpdl, unbind_to):
1232 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1233 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1234 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1235 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1236 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1237 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1238 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1239 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1240 (a_write, e_write):
1241 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1242 (Fcopy_file, non_regular_nbytes, read_non_regular)
1243 (Finsert_file_contents):
1244 Use int, not EMACS_INT, where int is wide enough.
1245 (READ_BUF_SIZE): Verify that it fits in int.
1246 (Finsert_file_contents): Check that counts are in proper range,
1247 rather than assuming fixnums fit into ptrdiff_t etc.
1248 Don't assume fixnums fit into int.
125b3835 1249 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1250 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1251 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1252 (string_char_to_byte, string_byte_to_char)
1253 (string_make_multibyte, string_to_multibyte)
1254 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1255 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1256 (substring_both, Fdelete, internal_equal, Ffillarray)
1257 (Fclear_string, mapcar1)
1258 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1259 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1260 (larger_vector, make_hash_table, maybe_resize_hash_table)
1261 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1262 (Fmaphash, secure_hash):
1263 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1264 (concat): Check for string index and length overflow.
1265 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1266 (Frequire):
1267 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1268 (larger_vector): New API (vec, incr_min, size_max) replaces old
1269 one (vec, new_size, init). This catches size overflow.
1270 INIT was removed because it was always Qnil.
1271 All callers changed.
1272 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1273 the upper bound on a hash table index size.
1274 (make_hash_table, maybe_resize_hash_table): Use it.
1275 (secure_hash): Computer start_byte and end_byte only after
1276 they're known to be in ptrdiff_t range.
1277 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1278 (Ffont_get_glyphs, Ffont_at):
1279 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1280 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1281 (Flist_fonts, Fopen_font):
1282 Don't assume fixnum can fit in int.
1283 (check_gstring): Don't assume index can fit in int.
1284 (font_match_p): Check that fixnum is a character, not a nonnegative
1285 fixnum, since the later code needs to stuff it into an int.
1286 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1287 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1288 conversion overflow issues.
1289 (Fopen_font): Check for integer out of range.
1290 (Ffont_get_glyphs): Don't assume index can fit in int.
1291 * font.h: Adjust decls to match defn changes elsewhere.
1292 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1293 integer overflow.
1294 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1295 printmax_t, where ptrdiff_t is wide enough.
1296 (Finternal_char_font):
1297 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1298 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1299 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1300 (Fset_frame_position, x_set_frame_parameters)
1301 (x_set_line_spacing, x_set_border_width)
1302 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1303 Check that fixnums are in proper range for system types.
1304 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1305 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1306 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1307 Use SAFE_ALLOCA_LISP, not alloca.
1308 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1309 intptr_t is wide enough.
1310 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1311 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1312 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1313 Check for fixnum out of range.
1314 * ftfont.c (ftfont_list): Don't assume index fits in int.
1315 Check that fixnums are in proper range for system types.
1316 (ftfont_shape_by_flt):
1317 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1318 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1319 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1320 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1321 Check that fixnums are in proper range for system types.
1322 * gnutls.h: Adjust decls to match defn changes elsewhere.
1323 * gtkutil.c (xg_dialog_run):
1324 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1325 (update_frame_tool_bar):
1326 Check that fixnums are in proper range for system types.
1327 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1328 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1329 * indent.c (last_known_column, last_known_column_point):
1330 (current_column_bol_cache):
1331 (skip_invisible, current_column, check_display_width):
1332 (check_display_width, scan_for_column, current_column_1)
1333 (Findent_to, Fcurrent_indentation, position_indentation)
1334 (indented_beyond_p, Fmove_to_column, compute_motion):
1335 (Fcompute_motion, Fvertical_motion):
1336 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1337 (last_known_column_modified): Use EMACS_INT, not int.
1338 (check_display_width):
1339 (Fcompute_motion):
1340 Check that fixnums and floats are in proper range for system types.
1341 (compute_motion): Don't assume index or fixnum fits in int.
1342 (compute_motion, Fcompute_motion):
1343 Use int, not EMACS_INT, when it is wide enough.
1344 (vmotion): Omit local var start_hpos that is always 0; that way
1345 we don't need to worry about overflow in expressions involving it.
1346 * indent.h: Adjust decls to match defn changes elsewhere.
1347 (struct position):
1348 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1349 Use int, not EMACS_INT, where int is wide enough.
1350 Remove unused members ovstring_chars_done and tab_offset;
1351 all uses removed.
1352 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1353 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1354 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1355 (make_gap, copy_text, insert, insert_and_inherit)
1356 (insert_before_markers, insert_before_markers_and_inherit)
1357 (insert_1, count_combining_before, count_combining_after)
1358 (insert_1_both, insert_from_string)
1359 (insert_from_string_before_markers, insert_from_string_1)
1360 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1361 (adjust_after_replace, adjust_after_insert, replace_range)
1362 (replace_range_2, del_range, del_range_1, del_range_byte)
1363 (del_range_both, del_range_2, modify_region)
1364 (prepare_to_modify_buffer, signal_before_change)
1365 (signal_after_change, Fcombine_after_change_execute):
1366 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1367 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1368 (balance_an_interval, split_interval_right, split_interval_left)
1369 (find_interval, next_interval, update_interval)
1370 (adjust_intervals_for_insertion, delete_node, delete_interval)
1371 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1372 (static_offset_intervals, offset_intervals)
1373 (merge_interval_right, merge_interval_left, make_new_interval)
1374 (graft_intervals_into_buffer, temp_set_point_both)
1375 (temp_set_point, set_point, adjust_for_invis_intang)
1376 (set_point_both, move_if_not_intangible, get_property_and_range)
1377 (get_local_map, copy_intervals, copy_intervals_to_string)
1378 (compare_string_intervals, set_intervals_multibyte_1):
1379 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1380 * intervals.h: Adjust decls to match defn changes elsewhere.
1381 (struct interval):
1382 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1383 * keyboard.c (this_command_key_count, this_single_command_key_start)
1384 (before_command_key_count, before_command_echo_length, echo_now)
1385 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1386 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1387 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1388 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1389 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1390 (last_non_minibuf_size, last_point_position, echo_truncate)
1391 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1392 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1393 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1394 (stuff_buffered_input):
1395 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1396 (last_auto_save, command_loop_1, read_char):
1397 Use EMACS_INT, not int, to avoid integer overflow.
1398 (record_char): Avoid overflow in total_keys computation.
1399 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1400 * keyboard.h: Adjust decls to match defn changes elsewhere.
1401 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1402 (Fkey_description, Fdescribe_vector, Flookup_key):
1403 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1404 (click_position): New function, to check that positions are in range.
1405 (Fcurrent_active_maps):
1406 (describe_command):
1407 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1408 (Faccessible_keymaps, Fkey_description):
1409 (preferred_sequence_p):
1410 Don't assume fixnum can fit into int.
1411 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1412 Check for integer overflow in size calculations.
1413 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1414 avoid mishandling large integers.
1415 * lisp.h: Adjust decls to match defn changes elsewhere.
1416 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1417 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1418 (struct Lisp_Marker):
1419 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1420 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1421 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1422 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1423 All callers changed.
1424 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1425 Assume the arg has valid form, since it always does.
1426 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1427 unsigned integer system type.
1428 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1429 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1430 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1431 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1432 (duration_to_sec_usec): New decl.
1433 * lread.c (read_from_string_index, read_from_string_index_byte)
1434 (read_from_string_limit, readchar, unreadchar, openp)
1435 (read_internal_start, read1, oblookup):
1436 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1437 (Fload, readevalloop, Feval_buffer, Feval_region):
1438 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1439 (openp): Check for out-of-range argument to 'access'.
1440 (read1): Use int, not EMACS_INT, where int is wide enough.
1441 Don't assume fixnum fits into int.
6efdadfd 1442 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1443 (read_filtered_event): Use duration_to_sec_usec
1444 to do proper overflow checking on durations.
d311d28c
PE
1445 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1446 in size calculation.
1447 (Fexecute_kbd_macro):
1448 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1449 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1450 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1451 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1452 (set_marker_both, set_marker_restricted_both, marker_position)
1453 (marker_byte_position, Fbuffer_has_markers_at):
1454 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1455 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1456 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1457 It now merely ensures that the menu is large enough, without
1458 necessarily growing it, as this avoids some integer overflow issues.
1459 All callers changed.
1460 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1461 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1462 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1463 Use SAFE_ALLOCA_LISP, not alloca.
1464 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1465 to EMACS_INT. Check that fixnums are in proper range for system types.
1466 * minibuf.c (minibuf_prompt_width, string_to_object)
1467 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1468 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1469 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1470 (get_minibuffer, read_minibuf_unwind):
1471 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1472 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1473 this simplifies overflow checking. All callers changed.
1474 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1475 (Ftest_completion):
1476 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1477 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1478 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1479 Check that fixnums are in proper range for system types.
1480 (Fx_create_frame, Fx_show_tip):
1481 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1482 * nsfont.m (ns_findfonts, nsfont_list_family):
1483 Don't assume fixnum fits in long.
1484 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1485 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1486 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1487 wide enough.
17fdb222 1488 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
1489 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1490 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1491 (PRINTDECLARE, PRINTPREPARE):
1492 (strout, print_string):
1493 (print, print_preprocess, print_check_string_charset_prop)
1494 (print_object):
1495 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1496 (PRINTDECLARE):
1497 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1498 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1499 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 1500 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 1501 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
1502 (print_error_message): Use SAFE_ALLOCA, not alloca.
1503 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
1504 (print_depth, new_backquote_output, print_number_index):
1505 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
1506 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1507 (Fset_process_window_size, Fformat_network_address)
1508 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 1509 (sigchld_handler):
d311d28c 1510 Check that fixnums are in proper range for system types.
d44287d4 1511 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1512 Check for process-ids out of pid_t range rather than relying on
1513 undefined behavior.
e4d81efc 1514 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1515 (Fformat_network_address, read_process_output, send_process)
1516 (Fprocess_send_region, status_notify):
1517 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1518 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1519 (wait_reading_process_output, read_process_output, exec_sentinel):
1520 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1521 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1522 (Faccept_process_output): Use duration_to_sec_usec to do proper
1523 overflow checking on durations.
dde14581
PE
1524 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1525 Don't assume pid_t fits in int.
02481186
PE
1526 * process.h (struct Lisp_Process): Members tick and update_tick
1527 are now of type EMACS_INT, not int.
b62b53e8
PE
1528 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1529 configured --with-wide-int.
d311d28c
PE
1530 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1531 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1532 * search.c (looking_at_1, string_match_1):
1533 (fast_string_match, fast_c_string_match_ignore_case)
1534 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1535 (scan_newline, find_before_next_newline, search_command)
1536 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1537 (set_search_regs, wordify):
1538 (Freplace_match):
1539 (Fmatch_data):
1540 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1541 (string_match_1, search_buffer, set_search_regs):
1542 (Fmatch_data):
1543 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1544 (wordify): Check for overflow in size calculation.
1545 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1546 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1547 Check that fixnums are in proper range for system types.
1548 * sound.c (struct sound_device)
1549 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1550 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1551 (Fplay_sound_internal):
1552 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1553 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1554 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1555 (Fparse_partial_sexp):
1556 Don't assume fixnums can fit in int.
1557 (struct lisp_parse_state, find_start_pos, find_start_value)
1558 (find_start_value_byte, find_start_begv)
1559 (update_syntax_table, char_quoted, dec_bytepos)
1560 (find_defun_start, prev_char_comend_first, back_comment):
1561 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1562 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1563 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1564 (Finternal_describe_syntax_value): Check that match_lisp is a
1565 character, not an integer, since the code stuffs it into int.
1566 (scan_words, scan_sexps_forward):
1567 Check that fixnums are in proper range for system types.
1568 (Fforward_word):
1569 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1570 (scan_sexps_forward):
1571 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1572 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1573 * syntax.h: Adjust decls to match defn changes elsewhere.
1574 (struct gl_state_s):
1575 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1576 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1577 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1578 * sysdep.c (wait_for_termination_1, wait_for_termination)
1579 (interruptible_wait_for_termination, mkdir):
1580 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1581 (emacs_read, emacs_write):
1582 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1583 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1584 and double all fit in int.
d311d28c
PE
1585 * term.c (set_tty_color_mode):
1586 Check that fixnums are in proper range for system types.
1587 * termhooks.h (struct input_event):
1588 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1589 * textprop.c (validate_interval_range, interval_of)
1590 (Fadd_text_properties, set_text_properties_1)
1591 (Fremove_text_properties, Fremove_list_of_text_properties)
1592 (Ftext_property_any, Ftext_property_not_all)
1593 (copy_text_properties, text_property_list, extend_property_ranges)
1594 (verify_interval_modification):
1595 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1596 (Fnext_single_char_property_change)
1597 (Fprevious_single_char_property_change):
1598 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
1599 (copy_text_properties):
1600 Check for integer overflow in index calculation.
d311d28c
PE
1601 * undo.c (last_boundary_position, record_point, record_insert)
1602 (record_delete, record_marker_adjustment, record_change)
1603 (record_property_change):
1604 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1605 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1606 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1607 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1608 (Fx_hide_tip, Fx_file_dialog):
1609 * w32menu.c (set_frame_menubar):
1610 Use ptrdiff_t, not int, for consistency with rest of code.
1611 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1612 (select_window, Fdelete_other_windows_internal)
1613 (window_scroll_pixel_based, window_scroll_line_based)
1614 (Frecenter, Fset_window_configuration):
1615 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1616 (Fset_window_hscroll, run_window_configuration_change_hook)
1617 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 1618 (Fscroll_other_window, Frecenter):
d311d28c
PE
1619 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1620 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1621 Don't assume fixnum fits in int.
1622 (Fset_window_scroll_bars):
1623 Check that fixnums are in proper range for system types.
1624 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1625 (string_pos, c_string_pos, number_of_chars, init_iterator)
1626 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1627 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1628 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
1629 (face_before_or_after_it_pos, handle_invisible_prop)
1630 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
1631 (display_prop_intangible_p, string_buffer_position_lim)
1632 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1633 (get_overlay_strings_1, get_overlay_strings)
1634 (iterate_out_of_display_property, forward_to_next_line_start)
1635 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1636 (get_next_display_element, set_iterator_to_next)
1637 (get_visually_first_element, compute_stop_pos_backwards)
1638 (handle_stop_backwards, next_element_from_buffer)
1639 (move_it_in_display_line_to, move_it_in_display_line)
1640 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1641 (add_to_log, message_dolog, message_log_check_duplicate)
1642 (message2, message2_nolog, message3, message3_nolog
1643 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1644 (current_message_1, truncate_echo_area, truncate_message_1)
1645 (set_message, set_message_1, store_mode_line_noprop)
1646 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1647 (text_outside_line_unchanged_p, check_point_in_composition)
1648 (reconsider_clip_changes)
1649 (redisplay_internal, set_cursor_from_row, try_scrolling)
1650 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1651 (redisplay_window, find_last_unchanged_at_beg_row)
1652 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1653 (trailing_whitespace_p, find_row_edges, display_line)
1654 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1655 (display_mode_element, store_mode_line_string)
1656 (pint2str, pint2hrstr, decode_mode_spec)
1657 (display_count_lines, display_string, draw_glyphs)
1658 (x_produce_glyphs, x_insert_glyphs)
1659 (rows_from_pos_range, mouse_face_from_buffer_pos)
1660 (fast_find_string_pos, mouse_face_from_string_pos)
1661 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1662 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1663 (safe_call, init_from_display_pos, handle_fontified_prop)
1664 (handle_single_display_spec, load_overlay_strings)
1665 (with_echo_area_buffer, setup_echo_area_for_printing)
1666 (display_echo_area, echo_area_display)
1667 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1668 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
1669 (redisplay_window, dump_glyph_row, display_mode_line)
1670 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 1671 (handle_display_spec, display_prop_string_p):
d311d28c
PE
1672 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1673 (handle_single_display_spec, build_desired_tool_bar_string)
1674 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1675 (get_specified_cursor_type):
1676 Check that fixnums are in proper range for system types.
1677 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1678 (Flookup_image_map):
1679 Don't assume fixnums fit in int.
1680 (compare_overlay_entries):
1681 Avoid mishandling comparisons due to subtraction overflow.
1682 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1683 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1684 (handle_tool_bar_click):
1685 Use int, not unsigned, since we prefer signed and the signedness
1686 doesn't matter here.
1687 (get_next_display_element, next_element_from_display_vector):
1688 Use int, not EMACS_INT, when int is wide enough.
1689 (start_hourglass): Use duration_to_sec_usec to do proper
1690 overflow checking on durations.
1691 * xfaces.c (Fbitmap_spec_p):
1692 Check that fixnums are in proper range for system types.
1693 (compare_fonts_by_sort_order):
1694 Avoid mishandling comparisons due to subtraction overflow.
1695 (Fx_family_fonts, realize_basic_faces):
1696 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1697 (Fx_family_fonts):
1698 Don't assume fixnum fits in int.
1699 Use SAFE_ALLOCA_LISP, not alloca.
1700 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1701 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1702 (face_at_buffer_position, face_for_overlay_string)
1703 (face_at_string_position):
1704 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1705 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1706 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1707 (Fx_show_tip):
1708 Check that fixnums are in proper range for system types.
1709 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1710 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1711 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1712 (Fx_change_window_property): Don't assume fixnums fit in int.
1713 * xfont.c (xfont_chars_supported):
1714 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1715 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1716 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1717 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1718 * xml.c (parse_region):
1719 * xrdb.c (magic_file_p):
1720 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1721 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1722 (x_get_local_selection, x_reply_selection_request)
1723 (x_handle_selection_request, wait_for_property_change):
1724 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1725 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1726 short is wide enough.
1727 (x_send_client_event): Don't assume fixnum fits in int.
1728 * xterm.c (x_x_to_emacs_modifiers):
1729 Don't assume EMACS_INT overflows nicely into int.
1730 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1731 may come from Lisp.
1732 (handle_one_xevent): NATNUMP can eval its arg twice.
1733 (x_connection_closed):
1734 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1735 * xterm.h: Adjust decls to match defn changes elsewhere.
1736 (struct scroll_bar): Use struct vectorlike_header
1737 rather than rolling our own approximation.
1738 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1739
c6574eb5
GM
17402012-05-25 Glenn Morris <rgm@gnu.org>
1741
1742 * lisp.mk (lisp): Update for more files being compiled now.
1743
e8d32c7e
SM
17442012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1745
48def666
SM
1746 * lread.c: Remove `read_pure' which makes no difference.
1747 (read_pure): Remove var.
1748 (unreadpure): Remove function.
1749 (readevalloop): Don't call read_list with -1 flag.
1750 (read1, read_vector): Don't test read_pure any more.
1751 (read_list): Simplify.
1752
e8d32c7e
SM
1753 * fileio.c, character.h: Minor style tweaks.
1754
4b2addb7
DA
17552012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1756
1757 * window.h (clip_changed): Remove useless declaration.
1758
584461b2
JB
17592012-05-22 Juanma Barranquero <lekktu@gmail.com>
1760
1761 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1762 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1763
34374650
PE
17642012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1765
1766 Remove src/m/*.
1767 This directory predates autoconf and is no longer needed nowadays.
1768 Move its few remaining bits of functionality to where they're needed.
1769 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1770 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1771 * m/template.h: Remove.
1772 * Makefile.in (M_FILE): Remove. All uses removed.
1773 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1774 * lisp.h (USE_LSB_TAG):
1775 * mem-limits.h (EXCEEDS_LISP_PTR):
1776 Use VAL_MAX, not VALBITS, in #if.
1777 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1778 (EMACS_UINT): Define unconditionally now.
1779 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1780 (BITS_PER_EMACS_INT): New constants, replacing
1781 what used to be in config.h, but not useful in #if.
1782 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1783 define them any more.
1784 (VAL_MAX): New macro.
1785 (VALMASK): Use it.
1786 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1787 BITS_PER_EMACS_INT, in #if.
1788 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1789 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1790 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1791 * s/ms-w32.h (DATA_START):
1792 Move here from removed file m/intel386.h.
1793 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1794 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1795
261cb4bb
PE
17962012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1797
1798 Assume C89 or later.
1799 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1800 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1801 (xrealloc):
1802 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1803 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1804 * textprop.c, tparam.c (NULL): Remove.
1805 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1806 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1807 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1808 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1809 * xterm.c (input_signal_count): Assume volatile works.
1810
ff23cd9f
KB
18112012-05-21 Ken Brown <kbrown@cornell.edu>
1812
1813 * xgselect.c (xg_select): Fix first argument in call to 'select'
1814 (bug#11508).
1815
1b170bc6
KB
18162012-05-20 Ken Brown <kbrown@cornell.edu>
1817
1818 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1819 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1820
b2f4d39f
KB
18212012-05-19 Ken Brown <kbrown@cornell.edu>
1822
1823 * xfns.c (x_in_use): Remove `static' qualifier.
1824 * xterm.h (x_in_use): Declare.
1825 * xgselect.c: Include xterm.h.
1826 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1827 and `display_arg' (bug#9754).
1828
003fdae2
PE
18292012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1830
9232a6d9
PE
1831 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1832
003fdae2
PE
1833 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1834 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1835
784b56e2
EZ
18362012-05-18 Eli Zaretskii <eliz@gnu.org>
1837
1838 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1839
1840 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1841 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1842
1843 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1844 reference to image_cache->refcount.
1845 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1846
a0a79cde
JL
18472012-05-17 Juri Linkov <juri@jurta.org>
1848
1849 * search.c (Fword_search_regexp, Fword_search_backward)
1850 (Fword_search_forward, Fword_search_backward_lax)
1851 (Fword_search_forward_lax): Move functions to isearch.el
1852 (bug#10145, bug#11381).
1853
b0572523
PE
18542012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1855
1856 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1857
9660f5fc
SM
18582012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1859
1860 * lread.c (init_obarray): Declare Qt and Qnil as special.
1861
4374de83
GM
18622012-05-14 Glenn Morris <rgm@gnu.org>
1863
1864 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1865 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1866
dc44c39a
PE
18672012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1868
078c97cb
PE
1869 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1870
dc44c39a
PE
1871 * unexaix.c: Port to more-recent AIX compilers.
1872 (report_error, report_error_1, make_hdr, copy_sym)
1873 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1874 Make arguments const char *, not char *, to avoid violations of C
1875 standard and to fix some AIX warnings reported by Gilles Pion.
1876
e18afed7 18772012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1878
1879 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1880 already have overlays loaded.
1881 (handle_single_display_spec): Before returning without displaying
1882 fringe bitmap, synchronize the bidi iterator with the main display
1883 iterator, by calling iterate_out_of_display_property.
1884 (iterate_out_of_display_property): Detect buffer iteration by
1885 testing that it->string is a Lisp string.
1886 (get_next_display_element): When the current object is exhausted,
1887 and there's something on it->stack, call set_iterator_to_next to
1888 proceed with what's on the stack, instead of returning zero.
1889 (set_iterator_to_next): If called at the end of a Lisp string,
1890 proceed to consider_string_end without incrementing string
1891 position. Don't increment display vector index past the end of
1892 the display vector. (Bug#11417)
c8fb9dc6
EZ
1893 (pos_visible_p): Don't report a position visible when move_it_to
1894 stopped at the last line of window, which happens to be scanned
1895 backwards by the bidi iteration. (Bug#11464)
ac268e67 1896
e18afed7 18972012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
1898
1899 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1900 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
1901 are on a TTY, and thus unable to display on the fringes.
1902 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
1903 so we need to signal to the caller that this is a "replacing"
1904 display spec. This fixes display when the spec is invalid or we
1905 are on a TTY.
1906
e18afed7 19072012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
1908
1909 * unexaix.c (make_hdr): Fix typo in prototype.
1910 This bug broke the build on AIX. Problem reported by Gilles Pion.
1911
9d0a235a
MA
19122012-05-14 Michael Albinus <michael.albinus@gmx.de>
1913
1914 * keyboard.c (kbd_buffer_get_event): Read special events also in
1915 batch mode. (Bug#11415)
1916
9e6b06ed
GM
19172012-05-12 Glenn Morris <rgm@gnu.org>
1918
1919 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1920
c1a1d7a3
EZ
19212012-05-12 Eli Zaretskii <eliz@gnu.org>
1922
1923 * lisp.mk (lisp): Add newcomment.elc.
1924
3fe7cdc8
GM
19252012-05-12 Glenn Morris <rgm@gnu.org>
1926
1927 * Makefile.in (MKDIR_P): New, set by configure.
1928 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1929
53f7d2c0
PE
19302012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1931
1932 Remove unused function hourglass_started.
1933 * dispextern.h (hourglass_started):
1934 * w32fns.c (hourglass_started):
1935 * xdisp.c (hourglass_started): Remove.
1936
75aafb17
JB
19372012-05-10 Juanma Barranquero <lekktu@gmail.com>
1938
1939 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1940 Update dependencies.
1941
12959e8e
PE
19422012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1943
97107e2e
PE
1944 * xgselect.c (xg_select): Put maxfds+1 into a var.
1945 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1946
12959e8e
PE
1947 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1948
836d29b3
DA
19492012-05-10 Dave Abrahams <dave@boostpro.com>
1950
1951 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1952 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1953
5cb67954
MA
19542012-05-09 Michael Albinus <michael.albinus@gmx.de>
1955
1956 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1957 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1958 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1959 Initialize xd_registered_buses.
1960
3478ec45
PE
19612012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1962
b263a6b0
PE
1963 Untag more efficiently if USE_LSB_TAG.
1964 This is based on a proposal by YAMAMOTO Mitsuharu in
1965 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1966 For an admittedly artificial (nth 8000 longlist) benchmark on
1967 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1968 Emacs's overall text size by 1%.
1969 * lisp.h (XUNTAG): New macro.
1970 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1971 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1972 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1973 * eval.c (Fautoload):
1974 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1975 * frame.h (XFRAME): Use XUNTAG.
1976
3478ec45
PE
1977 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1978 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1979 Remove unportable assumptions about print widths of types like
1980 dbus_uint32_t.
1981 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1982 intptr_t when converting between pointer and integer, to avoid GCC
1983 warnings about wrong width.
1984
666b903b 19852012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
1986
1987 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1988 stack for each reader_thread, instead of defaulting to 8MB
1989 determined by the linker. This avoids failures in creating
1990 subprocesses on Windows 7, see the discussion in this thread:
1991 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1992
b120cc17
JC
19932012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1994
1995 Fix up display of the *Minibuf-0* buffer in the mini window.
1996 * keyboard.c (read_char): Don't clear the echo area if there's no
1997 message to clear.
1998 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 1999 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2000
9a4b36f8
MA
20012012-05-07 Michael Albinus <michael.albinus@gmx.de>
2002
2003 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2004 batch mode.
2005
e5f9458f
CY
20062012-05-06 Chong Yidong <cyd@gnu.org>
2007
2008 * lisp.mk (lisp): Update.
2009
eceeb5fc 20102012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2011
2012 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2013
71873e2b
SM
20142012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2015
2016 * data.c (PUT_ERROR): New macro.
2017 (syms_of_data): Use it. Add new error type `user-error'.
2018 * undo.c (user_error): New function.
2019 (Fprimitive_undo): Use it.
2020 * print.c (print_error_message): Adjust print style for `user-error'.
2021 * keyboard.c (user_error): New function.
2022 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2023
ab0fa4e4
PE
20242012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2025
2026 Do not limit current-time-string to years 1000..9999.
2027 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2028 (Fcurrent_time_string): Support any year that is supported by the
2029 underlying localtime representation. Don't use asctime, as it
2030 has undefined behavior for years outside the range -999..9999.
2031
7ed806a7
PE
20322012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2033
2034 Fix race conditions involving setenv, gmtime, localtime, asctime.
2035 Without this fix, interrupts could mess up code that uses these
2036 nonreentrant functions, since setting TZ invalidates existing
2037 tm_zone or tzname values, and since most of these functions return
2038 pointers to static storage.
2039 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2040 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2041 Grow the critical sections to include not just invoking
2042 localtime/gmtime, but also accessing these functions' results
2043 including their tm_zone values if any, and any related TZ setting.
2044 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2045 so that the struct tm is saved in the critical section.
2046 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2047 motivated by the fact that memory allocation needs to be outside
2048 the critical section.
2049
0c16dfed
DA
20502012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2051
2052 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2053 with RESET_INTERVAL.
2054
2055 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2056 Remove duplicated buffer name initialization.
2057
3f83ace8
JM
20582012-05-02 Jim Meyering <jim@meyering.net>
2059
2060 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2061
c7b8541e
JM
2062 * xfns.c (x_window): Use xstrdup (Bug#11375).
2063
90207a15 20642012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2065
2066 * xdisp.c (pos_visible_p): If already at a newline from the
2067 display string before the 'while' loop, don't walk back the glyphs
2068 from it3.glyph_row. Solves assertion violation when the display
2069 string begins with a newline (egg.el). (Bug#11367)
2070
b593d6a9
AH
20712012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2072
2073 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2074 Move to simple.el.
2075
4737362e
GM
20762012-05-01 Glenn Morris <rgm@gnu.org>
2077
99cf43f9
GM
2078 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2079 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2080 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2081 All were removed before 23.1.
2082
9311dcff
GM
2083 * dispnew.c: Remove HAVE_LIBNCURSES test;
2084 it is always true on relevant platforms.
2085
4d5c6349
GM
2086 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2087 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2088
4737362e
GM
2089 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2090
74dd3a6b
AS
20912012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2092
2093 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2094 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2095 Remove.
2096
13c379ee
PE
20972012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2098
2099 Do not avoid creating empty evaporating overlays (Bug#9642).
2100 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2101 That is, do not delete an evaporating overlay if it becomes
2102 empty after its bounds are adjusted to fit within its buffer.
2103 This fix caused other problems, and I'm reverting it until we get
2104 to the bottom of them.
2105
a8e7d6d7 21062012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2107
2108 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2109
a8e7d6d7 21102012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2111
2112 * xdisp.c (pos_visible_p): If the window start position is beyond
2113 ZV, start the display from buffer beginning. Prevents assertion
2114 violation in init_iterator when the minibuffer window is scrolled
2115 via the scroll bar.
2116
2117 * window.c (window_scroll_pixel_based): Likewise.
2118
a8e7d6d7 21192012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2120
2121 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2122
a8e7d6d7 21232012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2124
2125 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2126 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2127
a8e7d6d7 21282012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2129
b593d6a9
AH
2130 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2131 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2132
1c6900d9
EZ
21332012-04-26 Eli Zaretskii <eliz@gnu.org>
2134
4c3fa1d9
EZ
2135 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2136 display element, check also the underlying string or buffer
2137 character. (Bug#11341)
2138
1c6900d9
EZ
2139 * w32menu.c: Include w32heap.h.
2140 (add_menu_item): If the call to AppendMenuW (via
2141 unicode_append_menu) fails, disable Unicode menus only if we are
2142 running on Windows 9X/Me.
2143
42bf8205
AS
21442012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2145
2146 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2147 (xgetint): Add missing shift for LSB tags.
2148
b1bac16e
MR
21492012-04-24 Martin Rudalics <rudalics@gmx.at>
2150
2151 * keyboard.c (read_char): Don't wipe echo area for select window
2152 events: These might get delayed via `mouse-autoselect-window'
2153 (Bug#11304).
2154
d69621cc
JB
21552012-04-24 Juanma Barranquero <lekktu@gmail.com>
2156
2157 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2158 manipulation of :loaded-from data.
2159
02fd101b
JB
21602012-04-23 Juanma Barranquero <lekktu@gmail.com>
2161
2162 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2163 now a cons (bug#11311).
2164
888bec30
PE
21652012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2166
89a438bd
PE
2167 Do not create empty overlays with the evaporate property (Bug#9642).
2168 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2169 if it becomes empty after its bounds are adjusted to fit within
2170 its buffer. Without this fix, in a nonempty buffer (let ((o
2171 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2172 yields an empty overlay that has the evaporate property, which is
2173 not supposed to happen.
2174
1068fe4d
PE
2175 Fix minor GTK3 problems found by static checking.
2176 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2177 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2178 (struct _EmacsFixedClass, emacs_fixed_get_type):
2179 Move decls here from emacsgtkfixed.h, since they needn't be public.
2180 (emacs_fixed_get_type): Now static.
2181 (emacs_fixed_class_init): Omit unused local.
2182 (emacs_fixed_child_type): Remove; unused.
2183 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2184 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2185 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2186 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2187 (EMACS_FIXED_GET_CLASS): Remove; unused.
2188 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2189
888bec30
PE
2190 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2191 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2192
de85e130
PE
21932012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2194
d0baac98 2195 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 2196 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
2197 (__malloc_size_t, __malloc_ptrdiff_t):
2198 Remove. All uses removed, replaced by the definiens if needed,
2199 since we can assume C89 or better now.
2200 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2201 (protect_malloc_state, align, get_contiguous_space)
2202 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2203 (malloc_atfork_handler_child, malloc_enable_thread)
2204 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2205 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2206 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2207 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2208 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2209 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2210 Define using prototypes, not old style.
2211 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2212 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2213 (align): Don't assume that signed integer overflow wraps around.
2214 Omit unused local var.
2215 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2216 (_free_internal_nolock, memalign, mallochook, reallochook):
2217 Omit no-longer-needed casts.
2218 (valloc): Use getpagesize, not __getpagesize.
2219 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2220 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2221
de85e130
PE
2222 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2223
dcbf5805
MA
22242012-04-22 Michael Albinus <michael.albinus@gmx.de>
2225
2226 Move functions from C to Lisp. Make non-blocking method calls
2227 the default. Implement further D-Bus standard interfaces.
2228
2229 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2230 (QCdbus_request_name_allow_replacement)
2231 (QCdbus_request_name_replace_existing)
2232 (QCdbus_request_name_do_not_queue)
2233 (QCdbus_request_name_reply_primary_owner)
2234 (QCdbus_request_name_reply_in_queue)
2235 (QCdbus_request_name_reply_exists)
2236 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2237 (QCdbus_registered_serial, QCdbus_registered_method)
2238 (QCdbus_registered_signal): New Lisp objects.
2239 (XD_DEBUG_MESSAGE): Use sizeof.
2240 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2241 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2242 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2243 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2244 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2245 (xd_signature, xd_append_arg): Allow float for integer types.
2246 (xd_get_connection_references): New function.
b593d6a9
AH
2247 (xd_get_connection_address): Rename from xd_initialize.
2248 Return cached address.
dcbf5805
MA
2249 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2250 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2251 level.
2252 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2253 Return number of refcounts.
dcbf5805
MA
2254 (Fdbus_get_unique_name): Make stronger parameter check.
2255 (Fdbus_message_internal): New defun.
2256 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2257 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2258 (Fdbus_send_signal, Fdbus_register_service)
2259 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2260 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2261 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2262 (Vdbus_compiled_version, Vdbus_runtime_version)
2263 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2264 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2265 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2266 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2267 Adapt docstring.
dcbf5805 2268
52828e02
PE
22692012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2270
da05bc4c
PE
2271 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2272 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2273 Do not assume ptrdiff_t is the same width as 'int'.
2274
52828e02
PE
2275 * alloc.c: Handle unusual debugging option combinations.
2276 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2277 since the two debugging options are incompatible.
2278 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2279 is defined.
2280 (mem_init, mem_insert, mem_insert_fixup):
2281 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2282 (NEED_MEM_INSERT): Remove; no longer needed.
2283
f01769f9
LL
22842012-04-22 Leo Liu <sdl.web@gmail.com>
2285
2286 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2287
5790543d
PE
22882012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2289
2290 * sysdep.c [__FreeBSD__]: Minor cleanups.
2291 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2292 Use Emacs indenting style more consistently. Avoid some casts.
2293 Use 'double' consistently rather than mixing 'float' and 'double'.
2294
b91b7e4d
EW
22952012-04-21 Eduard Wiebe <usenet@pusto.de>
2296
b593d6a9
AH
2297 * sysdep.c (list_system_processes, system_process_attributes):
2298 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2299
6114eb15
AS
23002012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2301
2302 * lisp.mk (lisp): Update.
2303
2f38dff7
PE
23042012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2305
2306 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2307 It is never used otherwise.
2308
4ae29f89
SM
23092012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2310
2311 * print.c (print_preprocess): Only check print_depth if print-circle
2312 is nil.
2313 (print_object): Check for cycles even when print-circle is nil and
2314 print-gensym is t, but only check print_depth if print-circle is nil.
2315
f30d612a
CY
23162012-04-20 Chong Yidong <cyd@gnu.org>
2317
2318 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2319 set the status to "failed" and ensure that sentinel is run.
2320
c07a4c0b 23212012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2322
2323 * process.c (Fset_process_inherit_coding_system_flag)
2324 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2325 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2326
c07a4c0b 23272012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2328
2329 * xdisp.c (string_buffer_position_lim): Limit starting position to
2330 BEGV.
2331 (set_cursor_from_row): If called for a mode-line or header-line
2332 row, return zero immediately.
2333 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2334 farther than the first row after the header line, if any.
2335 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2336 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2337
c07a4c0b 23382012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2339
4ae29f89
SM
2340 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2341 (bug#11238).
ad3a2b41 2342
c07a4c0b 23432012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 23442012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2345
2346 configure: new option --enable-gcc-warnings (Bug#11207)
2347 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2348 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2349 (ALL_CFLAGS): Use new macros rather than old.
2350 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2351 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2352 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2353 -Wunused-result, -Wunused-variable. This should go away once
2354 the Emacs and Gnulib regex code is merged.
2355 (xmalloc, xrealloc): Now static.
2356
aba027e8
PE
23572012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2358
2359 * dired.c (Fsystem_groups): Remove unused local.
2360
e5a36063
GM
23612012-04-17 Glenn Morris <rgm@gnu.org>
2362
2363 * dired.c (Fsystem_users): Doc fix.
2364
316411f0
DA
23652012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2366
2367 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2368 (syms_of_dired): Add them.
2369
9426aba4
PE
23702012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2371
b62a57be
PE
2372 Fix minor alloc.c problems found by static checking.
2373 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2374 New extern decls, to avoid calling undeclared functions.
2375 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2376 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2377 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2378 (NEED_MEM_INSERT): New macro.
2379 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2380 Remove one incorrect comment and fix another.
b62a57be 2381
3539f31f
PE
2382 Fix minor ralloc.c problems found by static checking.
2383 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2384 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2385 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2386 (r_alloc_sbrk): Now static.
2387
a041960a
PE
2388 Improve ralloc.c interface checking.
2389 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2390 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2391 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2392 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2393 [REL_ALLOC]: ... to here, to check interface.
2394 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2395 Remove decls. This fixes an "It stinks!".
2396
9426aba4
PE
2397 * alloc.c (which_symbols): Fix alignment issue / type clash.
2398
d55c12ed
AS
23992012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2400
2401 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2402 (struct Lisp_Misc_Any): Likewise.
2403 (struct Lisp_Free): Likewise.
2404 * alloc.c (union aligned_Lisp_Symbol): Define.
2405 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2406 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2407 (union aligned_Lisp_Misc): Define.
2408 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2409 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2410 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2411
b948ce8b
PE
24122012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2413
2414 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2415 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2416 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2417 * s/netbsd.h, s/sol2-6.h:
2418 Remove definition of GC_MARK_STACK, since the default now works.
2419 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2420 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2421 no longer the default.
2422 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2423
35dc09a1 24242012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2425
35dc09a1
GM
2426 * lread.c (lisp_file_lexically_bound_p):
2427 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2428
35dc09a1
GM
24292012-04-14 Eli Zaretskii <eliz@gnu.org>
2430
2431 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2432 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2433
24342012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2435
2436 * nsterm.m (constrainFrameRect): Always constrain when there is only
2437 one screen (Bug#10962).
2438
bcd86815
KB
24392012-04-13 Ken Brown <kbrown@cornell.edu>
2440
2441 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2442
c25df26e
RT
24432012-04-13 Reuben Thomas <rrt@sc3d.org>
2444
2445 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2446
0fc59f1e
DC
24472012-04-11 Daniel Colascione <dancol@dancol.org>
2448
2449 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2450 against is gone. It's better to use vfork now so that when Cygwin
2451 gains a new, working vfork, we use it automatically (bug#10398).
2452
de8c03dc
SM
24532012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2454
2455 * window.c (save_window_save): Obey window-point-insertion-type.
2456
2f097256
GM
24572012-04-11 Glenn Morris <rgm@gnu.org>
2458
2459 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2460
453b951e
SM
24612012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2462
2463 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2464
75f1671a 24652012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
2466
2467 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2468 (force_quit_count): New var.
2469 (handle_interrupt): Use it.
2470
2a8ce227
JB
24712012-04-10 Juanma Barranquero <lekktu@gmail.com>
2472
2473 * w32.c (w32_delayed_load): Record the full path of the library
2474 being loaded (bug#10424).
2475
935396c0
GM
24762012-04-09 Glenn Morris <rgm@gnu.org>
2477
05920a43
GM
2478 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2479 not just in the obarray, before snarfing them. (Bug#11036)
2480
935396c0
GM
2481 * Makefile.in ($(leimdir)/leim-list.el):
2482 Pass EMACS rather than BUILT_EMACS.
2483
a18ecafa
TZ
24842012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2485
2486 * process.c (make_process):
2487 * process.h: Add integer `gnutls_handshakes_tried' member to
2488 process struct.
2489
6bbef4e5
JC
2490 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2491 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
2492
2493 * gnutls.c (gnutls_log_function2i): Convenience log function.
2494 (emacs_gnutls_read): Use new log functions,
2495 `gnutls_handshakes_tried' process member, and
2496 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2497 attempts per process (connection).
2498
b4d3bc10
CY
24992012-04-09 Chong Yidong <cyd@gnu.org>
2500
2501 * eval.c (Fuser_variable_p, user_variable_p_eh)
2502 (lisp_indirect_variable): Functions deleted.
2503 (Fdefvar): Caller changed.
2504
2505 * callint.c (Finteractive, Fcall_interactively):
2506 * minibuf.c (Fread_variable): Callers changed.
2507
70f4d973
EZ
25082012-04-09 Eli Zaretskii <eliz@gnu.org>
2509
2510 * xdisp.c (set_cursor_from_row): If the display string appears in
2511 the buffer at position that is closer to point than the position
2512 after the display string, display the cursor on the first glyph of
2513 the display string. Fixes cursor display when a 'display' text
2514 property immediately follows invisible text. (Bug#11094)
2515
cb3c2e3e
PE
25162012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2517
2518 composite.c: use 'double' consistently
2519 * composite.c (get_composition_id): Use 'double' consistently
2520 instead of converting 'float' to 'double' and vice versa; this is
2521 easier to understand and avoids a GCC warning.
2522
fd06db5d
GM
25232012-04-09 Glenn Morris <rgm@gnu.org>
2524
50fe702a
GM
2525 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2526 preparation for dumping it with emacs. (Bug#4789)
2527 (leimdir): New variable.
2528 ($(leimdir)/leim-list.el): New rule.
2529 (emacs$(EXEEXT)): Depend on leim-list.el.
2530
fd06db5d
GM
2531 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2532 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2533 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2534
55c131ee
AS
25352012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2536
2537 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2538 proper alignment.
2539
9209588f
JB
25402012-04-07 Juanma Barranquero <lekktu@gmail.com>
2541
2542 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2543 Remove unused local variable.
2544
e3fb2efb
PE
25452012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2546
2547 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2548 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2549 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2550 objects, as mark_maybe_pointer will catch them otherwise.
2551 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2552 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2553
b5385551
PE
25542012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2555
2556 Fix typo that broke non-Windows builds.
2557 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2558
9078ead6
EZ
25592012-04-07 Eli Zaretskii <eliz@gnu.org>
2560
2561 Support building on MS-Windows with libxml2.
2562
2563 * makefile.w32-in (OBJ2): Add xml.$(O).
2564 (GLOBAL_SOURCES): Add xml.c.
2565 ($(BLD)/xml.$(O)): New dependency list.
2566
2567 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2568 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2569 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2570 [!WINDOWSNT]: New macros.
2571 (init_libxml2_functions, libxml2_loaded_p): New functions.
2572 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2573 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2574 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2575 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2576 linked in).
6bbef4e5
JC
2577 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2578 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2579 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2580
2581 * emacs.c: Don't include libxml/parser.h.
2582 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2583 xmlCleanupParser directly.
2584
2585 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2586
3811fdf3
EZ
25872012-04-07 Eli Zaretskii <eliz@gnu.org>
2588
2589 * indent.c (Fvertical_motion): If there is a display string at
2590 point, use it.vpos to compute how many lines to backtrack after
2591 move_it_to point. (Bug#11133)
2592
2f8e16b2
EZ
25932012-04-06 Eli Zaretskii <eliz@gnu.org>
2594
2595 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2596 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2597 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2598 macros related to unification of CJK characters. For the details,
2599 see the discussion following the message here:
2600 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2601
3d439cd1
CY
26022012-04-04 Chong Yidong <cyd@gnu.org>
2603
2604 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2605
8bc53d00
EZ
26062012-04-01 Eli Zaretskii <eliz@gnu.org>
2607
2608 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2609 instead of alloca. (Bug#11138)
2610
3b0512a3
AS
26112012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2612
2613 * w32menu.c (is_simple_dialog): Properly check lisp types.
2614 (Bug#11141)
2615
8427ddd2
EZ
26162012-03-31 Eli Zaretskii <eliz@gnu.org>
2617
979022ef
EZ
2618 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2619 position we get to after a call to move_it_to fails the
2620 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2621 only if we wind up in a string from display property. (Bug#11063)
2622
a6b1c7cc
EZ
2623 * window.c (Fdelete_other_windows_internal): Invalidate the row
2624 and column information about mouse highlight, so that redisplay
2625 restores it after reallocating the glyph matrices. (Bug#7464)
2626
8427ddd2
EZ
2627 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2628 string comes from a `display' text property, use the buffer
2629 position of that property as if we actually saw that position in
2630 the row's glyphs.
697ba24b
EZ
2631 (move_it_by_lines): Remove the assertion that
2632 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2633 violated when there's a before-string at the beginning of a line.
2634 (Bug#11063)
8427ddd2 2635
65a0a738
EZ
26362012-03-30 Eli Zaretskii <eliz@gnu.org>
2637
2638 * xdisp.c (append_space_for_newline): If the default face was
2639 remapped, use the remapped face for the appended newline.
2640 (extend_face_to_end_of_line): Use the remapped default face for
2641 extending the face to the end of the line.
2642 (display_line): Call extend_face_to_end_of_line when the default
2643 face was remapped. (Bug#11068)
2644
581355cc
EZ
26452012-03-29 Eli Zaretskii <eliz@gnu.org>
2646
2647 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2648
e8fc049f
SM
26492012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2650
2651 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2652
4fb9a543
GM
26532012-03-27 Glenn Morris <rgm@gnu.org>
2654
2655 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2656 Doc fixes.
2657
679910f1
KH
26582012-03-26 Kenichi Handa <handa@m17n.org>
2659
2660 * dispextern.h (struct glyph): Fix previous change. Change the
2661 bit length of glyphless.ch to 25 (Bug#11082).
2662
90d49b7f
CY
26632012-03-26 Chong Yidong <cyd@gnu.org>
2664
2665 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2666 (command_loop_1): Use it; inhibit selection update for
2667 handle-select-window too (Bug#8996).
2668
f514f6f0
FP
26692012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2670
e8fc049f 2671 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 2672
bf43fa51
KH
26732012-03-25 Kenichi Handa <handa@m17n.org>
2674
2675 * dispextern.h (struct glyph): Change the bit length of
2676 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2677
8a0c01dd
EZ
26782012-03-24 Eli Zaretskii <eliz@gnu.org>
2679
2680 * s/ms-w32.h (tzname): Include time.h before redirecting to
2681 _tzname. Fixes the MSVC build. (Bug#9960)
2682
7d1c3a76
AS
26832012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2684
8ed79523
AS
2685 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2686 characters.
2687
7d1c3a76
AS
2688 * xterm.c (XTread_socket): Only modify handling_signal if
2689 !SYNC_INPUT. (Bug#11080)
2690
e99a9b8b
EZ
26912012-03-23 Eli Zaretskii <eliz@gnu.org>
2692
2693 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2694 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2695 when fetching a multibyte character consumes more bytes than
2696 CHAR_BYTES returns, due to unification of CJK characters in
2697 string_char. (Bug#11073)
2698
5063c0e1
TN
26992012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2700
2701 * process.c (wait_reading_process_output): Handle pty disconnect
2702 by refraining from sending oneself a SIGCHLD (bug#10933).
2703
9f851fbd
CY
27042012-03-22 Chong Yidong <cyd@gnu.org>
2705
2706 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2707
5063c0e1 2708 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2709 Mark string as coming from a prefix property.
2710 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2711 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2712
fb5b8aca
CY
27132012-03-21 Chong Yidong <cyd@gnu.org>
2714
2715 * xfaces.c (Vface_remapping_alist): Doc fix.
2716
62356a1b
EZ
27172012-03-20 Eli Zaretskii <eliz@gnu.org>
2718
2719 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2720 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2721 Doc fixes.
62356a1b 2722
025de85b
CY
27232012-03-20 Chong Yidong <cyd@gnu.org>
2724
2725 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2726 to reflect default non-nil value of redisplay-dont-pause.
2727
4827f94e
KH
27282012-03-19 Kenichi Handa <handa@m17n.org>
2729
2730 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2731 it fit in a valid range (Bug#11003).
2732
e50a24a2
EZ
27332012-03-18 Eli Zaretskii <eliz@gnu.org>
2734
2735 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2736 that is not from display property, accept the row as a "cursor
2737 row" if one of the string's character has a non-nil `cursor'
2738 property. Fixes cursor positioning when there are newlines in
2739 overlay strings, e.g. in icomplete.el. (Bug#11035)
2740
9af5ed87
PE
27412012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2742
2743 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2744
d1f55f16
CY
27452012-03-12 Chong Yidong <cyd@gnu.org>
2746
2747 * eval.c (inhibit_lisp_code): Rename from
2748 inhibit_window_configuration_change_hook; move from window.c.
2749
2750 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2751 * window.c (run_window_configuration_change_hook)
2752 (syms_of_window): Callers changed.
2753
66c5eebd
CY
27542012-03-11 Chong Yidong <cyd@gnu.org>
2755
413df973
CY
2756 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2757
66c5eebd
CY
2758 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2759
1de11f56
CY
27602012-03-10 Chong Yidong <cyd@gnu.org>
2761
2762 * frame.c (other_visible_frames): Don't assume the selected frame
2763 is visible (Bug#10955).
2764
cae07000
SM
27652012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2766
2767 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2768
89c94350
JD
27692012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2770
2771 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2772 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2773 zero (Bug#10954).
2774
999dd333
GM
27752012-03-03 Glenn Morris <rgm@gnu.org>
2776
01a6dcc8 2777 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2778
de0100f2
EZ
27792012-03-02 Eli Zaretskii <eliz@gnu.org>
2780
2781 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2782 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2783 (redisplay_window, next_element_from_string): Fix typos in
2784 comments.
3e441275
EZ
2785 (redisplay_window): Pass to move_it_vertically the margin in
2786 pixels, not in screen lines.
de0100f2 2787
96a72ee9
GM
27882012-03-02 Glenn Morris <rgm@gnu.org>
2789
2790 * buffer.c (buffer-list-update-hook): Doc fix.
2791
312508d7
EZ
27922012-02-29 Eli Zaretskii <eliz@gnu.org>
2793
2794 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2795 push_it before setting up the iterator for the first overlay
2796 string, even if we have an empty string loaded.
2797 (next_overlay_string): If there's an empty string on the iterator
2798 stack, pop the stack. (Bug#10903)
2799
27f3c637
PE
28002012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2801
2802 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2803 Suggested by Stefan Monnier in
2804 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2805 * alloc.c (widen_to_Lisp_Object): New static function.
2806 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2807 and widening them to Lisp_Objects. This would work even if
2808 USE_LSB_TAG is defined and wide integers are used, which might
2809 happen in a future version of Emacs.
2810
3c9dfce6
CY
28112012-02-25 Chong Yidong <cyd@gnu.org>
2812
fa74b241
CY
2813 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2814 Doc fix.
2815
3c9dfce6
CY
2816 * xselect.c (Fx_selection_exists_p): Doc fix.
2817 (x_clipboard_manager_save_all): Print an informative message
2818 before saving to clipboard manager.
2819
9486df08
CY
28202012-02-24 Chong Yidong <cyd@gnu.org>
2821
2822 * keyboard.c (process_special_events): Handle all X selection
2823 requests in kbd_buffer, not just the next one (Bug#8869).
2824
f01d3321
CY
28252012-02-23 Chong Yidong <cyd@gnu.org>
2826
2827 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2828 call when setting menu-bar-lines and tool-bar-lines parameters.
2829 (unwind_create_frame_1): New helper function.
2830
2831 * window.c (inhibit_window_configuration_change_hook): New var.
2832 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2833 (syms_of_window): Initialize it.
f01d3321 2834
86b847b6
CY
28352012-02-22 Chong Yidong <cyd@gnu.org>
2836
2837 * xterm.c (x_draw_image_relief): Add missing type check for
2838 Vtool_bar_button_margin (Bug#10743).
2839
a59225b1
CY
28402012-02-21 Chong Yidong <cyd@gnu.org>
2841
2842 * fileio.c (Vfile_name_handler_alist): Doc fix.
2843
2844 * buffer.c (Fget_file_buffer): Protect against invalid file
2845 handler return value.
2846
310f5bd4
PE
28472012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2848
cb3a28cc
PE
2849 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2850 when computing $valmask.
2851
310f5bd4
PE
2852 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2853 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2854 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2855 It's useless in that case, and it can cause problems on hosts
2856 that allocate halves of EMACS_INT values separately.
2857 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2858 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2859 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2860 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2861 it avoids undefined behavior on hosts where shifting right by more
2862 than the word width has undefined behavior.
2863
2375c96a
CY
28642012-02-19 Chong Yidong <cyd@gnu.org>
2865
2866 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2867 (Funhandled_file_name_directory, Ffile_name_as_directory)
2868 (Fdirectory_file_name, Fexpand_file_name)
2869 (Fsubstitute_in_file_name): Protect against invalid file handler
2870 return values (Bug#10845).
2871
3eb49e71
EZ
28722012-02-18 Eli Zaretskii <eliz@gnu.org>
2873
2874 * .gdbinit (pitx): Fix incorrect references to fields of the
2875 iterator stack.
2876
7b926f3f
CY
28772012-02-17 Chong Yidong <cyd@gnu.org>
2878
2879 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2880
11273115
PE
28812012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2882
2883 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2884 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2885
c3a70e2b
CY
28862012-02-15 Chong Yidong <cyd@gnu.org>
2887
2888 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2889 marked as special. Also, starting docstrings with * is obsolete.
2890
0ca43699
AS
28912012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2892
2893 * gnutls.c (emacs_gnutls_write): Fix last change.
2894
2e8f3c56
LI
28952012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2896
2897 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2898 send_process.
2899
af70074f
SM
29002012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2901
2902 * keymap.c (Fsingle_key_description): Handle char ranges.
2903
95986d52
CY
29042012-02-12 Chong Yidong <cyd@gnu.org>
2905
afd83bd1
CY
2906 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2907 as that creates a dangerous corner case.
2908
95986d52
CY
2909 * window.c (Fdelete_window_internal): Invalidate the mouse
2910 highlight (Bug#9904).
2911
bd7da63e
GM
29122012-02-12 Glenn Morris <rgm@gnu.org>
2913
2914 * xselect.c (Fx_own_selection_internal)
2915 (Fx_get_selection_internal, Fx_disown_selection_internal)
2916 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2917 * nsselect.m (Fx_own_selection_internal)
2918 (Fx_disown_selection_internal, Fx_selection_exists_p)
2919 (Fx_selection_owner_p, Fx_get_selection_internal):
2920 Sync docs and argument specs with the xselect.c versions.
2921
77abcbc2
LI
29222012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2923
2924 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2925
90b671e2
EZ
29262012-02-11 Eli Zaretskii <eliz@gnu.org>
2927
1c0ca0b7
EZ
2928 * w32select.c (Fx_selection_exists_p): Sync doc string and
2929 argument list with xselect.c. (Bug#10783)
2930
2931 * w16select.c (Fx_selection_exists_p): Sync doc string and
2932 argument list with xselect.c. (Bug#10783)
90b671e2 2933
49241268
GM
29342012-02-10 Glenn Morris <rgm@gnu.org>
2935
2936 * fns.c (Fsecure_hash): Doc fix.
2937
f998bbe7 29382012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
2939
2940 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2941
0992bd9c
CY
29422012-02-07 Chong Yidong <cyd@gnu.org>
2943
2944 * buffer.c (Fbuffer_local_variables)
2945 (buffer_lisp_local_variables): Handle unbound vars correctly;
2946 don't let Qunbound leak into Lisp.
2947
af008560
GM
29482012-02-07 Glenn Morris <rgm@gnu.org>
2949
dd605cc4
GM
2950 * image.c (Fimagemagick_types): Doc fix.
2951
af008560
GM
2952 * image.c (imagemagick-render-type): Change it from a lisp object
2953 to an integer. Move the doc here from the lisp manual.
2954 Treat all values not equal to 0 the same.
2955
1449fa1d
CY
29562012-02-06 Chong Yidong <cyd@gnu.org>
2957
2958 * doc.c (store_function_docstring): Avoid applying docstring of
2959 alias to base function (Bug#2603).
2960
3723ec07
AS
29612012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2962
2963 * .gdbinit (pp1, pv1): Remove redundant defines.
2964 (pr): Use pp.
2965
79c1cc1e
CY
29662012-02-04 Chong Yidong <cyd@gnu.org>
2967
2968 * nsterm.m: Declare a global (Bug#10694).
2969
d7f29f8e
EZ
29702012-02-04 Eli Zaretskii <eliz@gnu.org>
2971
cae07000
SM
2972 * w32.c (get_emacs_configuration_options):
2973 Include --enable-checking, if specified, in the return value.
d7f29f8e 2974
3b95a6f9
MR
29752012-02-04 Martin Rudalics <rudalics@gmx.at>
2976
2977 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2978 after rounding frame sizes. (Bug#9723)
2979
d6fa96a6
EZ
29802012-02-04 Eli Zaretskii <eliz@gnu.org>
2981
2982 * keyboard.c (adjust_point_for_property): Don't position point
2983 before BEGV. (Bug#10696)
2984
df0b2940
PE
29852012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2986
2987 Handle overflow when computing char display width (Bug#9496).
2988 * character.c (char_width): Return EMACS_INT, not int.
2989 (char_width, c_string_width): Check for overflow when
2990 computing the width; this is possible now that individual
2991 characters can have unbounded width. Problem introduced
2992 by merge from Emacs 23 on 2012-01-19.
2993
6bee44d6
MA
29942012-02-02 Michael Albinus <michael.albinus@gmx.de>
2995
2996 * dbusbind.c (Fdbus_register_method): Mention the return value
2997 :ignore in the docstring.
2998
44f92739
GM
29992012-02-02 Glenn Morris <rgm@gnu.org>
3000
1b9f60cc
GM
3001 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3002
44f92739
GM
3003 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3004 Unconditionally set to t. (Bug#10673)
3005 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3006 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3007 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3008
c5d3843c
KH
30092012-02-02 Kenichi Handa <handa@m17n.org>
3010
3011 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3012 0, do not call append_composite_glyph.
3013
159462d4 30142012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3015
3016 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3017 NULL (Bug#6988).
3018 (x_produce_glyphs): If the component of a composition is a null
3019 string, set it->pixel_width to 1 to avoid zero-width glyph.
3020
78cef877
EZ
30212012-02-01 Eli Zaretskii <eliz@gnu.org>
3022
3023 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3024 first 2 arguments are identical. This makes inserting large
3025 output from a subprocess an order of magnitude faster on
3026 MS-Windows, where all sbrk'ed memory is always contiguous.
3027
97897668
GM
30282012-01-31 Glenn Morris <rgm@gnu.org>
3029
3030 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3031 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3032 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3033
31fd3586
GM
30342012-01-29 Glenn Morris <rgm@gnu.org>
3035
3036 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3037
0e24a8b2
CY
30382012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3039
3040 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3041
cc0adcb0
CY
30422012-01-28 Chong Yidong <cyd@gnu.org>
3043
3044 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3045
acc28cb9
CY
30462012-01-26 Chong Yidong <cyd@gnu.org>
3047
9c69cfb7
CY
3048 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3049
acc28cb9
CY
3050 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3051 repeat counts (Bug#10507).
3052
48da7392
GM
30532012-01-26 Glenn Morris <rgm@gnu.org>
3054
3055 * lread.c (syms_of_lread): Doc fix.
3056
14af5f7f
CY
30572012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3058
3059 * coding.c (encode_designation_at_bol): Change return value to
3060 EMACS_INT.
3061
0b21c100
CY
30622012-01-25 Chong Yidong <cyd@gnu.org>
3063
3064 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3065
3c2907f7
CY
30662012-01-21 Chong Yidong <cyd@gnu.org>
3067
3068 * floatfns.c (Fcopysign): Make the second argument non-optional,
3069 since nil is not allowed anyway.
3070
959ad23f
AS
30712012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3072
3073 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3074 (send_process): Likewise.
3075
34a02f46
MR
30762012-01-19 Martin Rudalics <rudalics@gmx.at>
3077
3078 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3079 (Vwindow_persistent_parameters): Do not use Qstate.
3080 Rewrite doc-strings.
34a02f46 3081
1259009a 30822012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3083
3084 * character.c (char_width): New function.
70d4fdf6
GM
3085 (Fchar_width, c_string_width, lisp_string_width):
3086 Use char_width (Bug#9496).
25ed9e61 3087
6a6ee00d
MR
30882012-01-16 Martin Rudalics <rudalics@gmx.at>
3089
3090 * window.c (Vwindow_persistent_parameters): New variable.
3091 (Fset_window_configuration, save_window_save): Handle persistent
3092 window parameters.
3093
c85efaf7
EZ
30942012-01-14 Eli Zaretskii <eliz@gnu.org>
3095
3096 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3097 thrashing the stack of the thread. (Bug#9087)
3098
5944709e
PE
30992012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3100
3101 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3102
e71f5d99
EZ
31032012-01-11 Eli Zaretskii <eliz@gnu.org>
3104
3105 * xdisp.c (rows_from_pos_range): Handle the case where the
3106 highlight ends on a newline. (Bug#10464)
3107 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3108 he end column for display of highlight that ends on a newline
3109 before a R2L line.
3110
ce316182
GM
31112012-01-11 Glenn Morris <rgm@gnu.org>
3112
3113 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3114 from load-path also when installation-directory is nil. (Bug#10208)
3115
5b43da69
GM
31162012-01-10 Glenn Morris <rgm@gnu.org>
3117
74cc8ff9
GM
3118 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3119
7d8d6e4e
GM
3120 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3121 Update template values to be closer to their typical values these days.
5b43da69 3122
a0db8d43
EZ
31232012-01-09 Eli Zaretskii <eliz@gnu.org>
3124
3125 * xdisp.c (rows_from_pos_range): Accept additional argument
3126 DISP_STRING, and accept any glyph in a row whose object is that
3127 string as eligible for mouse highlight. Fixes mouse highlight of
3128 display strings from overlays. (Bug#10464)
3129
9a0115ab 31302012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3131
b9110d6a 3132 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3133 * fileio.c (auto_saving_dir_umask): New static var.
3134 (Fmake_directory_internal): Use it.
3135 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3136 creating the directory. The old code temporarily assigns
3137 too-generous permissions to the directory.
3138 (do_auto_save_eh): Clear it.
b9110d6a 3139 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3140 that the var is always cleared.
3141
6c1bd3f3
EZ
31422012-01-07 Eli Zaretskii <eliz@gnu.org>
3143
3144 * search.c (scan_buffer): Pass character positions to
3145 know_region_cache, not byte positions. (Bug#6540)
3146
069d2b50
L
31472012-01-07 LynX <_LynX@bk.ru> (tiny change)
3148
3149 * w32.c (sys_rename): Report EXDEV when rename of a directory
3150 fails because the target is on another logical disk. (Bug#10284)
3151
75bf0d33
DB
31522012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3153
3154 * xterm.c (x_embed_request_focus): New function.
3155
3156 * xterm.h: Add prototype.
3157
3158 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3159
1c6e5a32
GM
31602012-01-05 Glenn Morris <rgm@gnu.org>
3161
3162 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3163
651e947e
EZ
31642012-01-01 Eli Zaretskii <eliz@gnu.org>
3165
3166 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3167 Load gnutls_transport_set_lowat only if GnuTLS version is below
3168 2.11.1.
3169 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3170 GnuTLS versions below 2.11.1.
3171
3778cdd8
AL
31722011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3173
3174 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3175 to the doc string advising against its use for altering the way
3176 windows are scrolled.
3177
0e5317f7
KH
31782011-12-28 Kenichi Handa <handa@m17n.org>
3179
3180 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3181 coding-system ASCII compatible only when it does not produce BOM
3182 on encoding (Bug#10383).
3183
93d5ca1f
JD
31842011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3185
3186 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3187 can scroll.
3188 (create_and_show_popup_menu): Always use menu_position_func for
3189 Gtk3 (Bug#10361).
3190
ca22b785
AS
31912011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3192
3193 * callint.c (Fcall_interactively): Don't truncate prompt string.
3194
d048e1e6
EZ
31952011-12-23 Eli Zaretskii <eliz@gnu.org>
3196
3197 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3198 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 3199 resumed from there (after widening). (Bug#10360)
d048e1e6 3200
5ccaba1f
JD
32012011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3202
3203 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3204
204ee57f
JD
32052011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3206
b81d40f0
JB
3207 * nsterm.m (x_free_frame_resources):
3208 Release f->output_data.ns->miniimage.
204ee57f
JD
3209 (ns_index_color): Fix indentation. Do not retain
3210 color_table->colors[i].
3211
3212 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3213 before returning.
3214
3215 * nsfns.m (x_set_background_color): Assign return value from
3216 ns_index_color to face-background instead of NSColor*.
3217 (ns_implicitly_set_icon_type): Fix indentation.
3218 Change assignment in for loop to comparison.
3219
3220 * emacs.c (ns_pool): New variable.
3221 (main): Assign ns_pool.
3222 (Fkill_emacs): Call ns_release_autorelease_pool.
3223
3224 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3225 autorelease fdesc, release fdAttrs and tdict.
3226 (ns_get_covering_families): Release charset.
3227 (ns_findfonts): Release NSFontDescriptor created with new.
3228 (ns_uni_to_glyphs): Fix indentation.
3229 (setString): Release attrStr before assigning new value.
3230
c803b2b7
JD
32312011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3232
678f4426
JD
3233 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3234 and NS_IMPL_COCOA.
3235 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3236 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3237
cd394be1 32382011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3239
5fecd5fc
JD
3240 * nsterm.m (ns_term_init): Subscribe for notifications
3241 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3242 to method trackingNotification in EmacsMenu.
3243
3244 * nsmenu.m (trackingMenu): New variable.
3771cb17 3245 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3246 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3247 from Aquamacs (Bug#7030).
678f4426
JD
3248
32492011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3250
c803b2b7
JD
3251 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3252 (symbol_to_nsstring): Fix indentation.
3253 (ns_symbol_to_pb): New function.
cae07000
SM
3254 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3255 (Fns_rotate_cut_buffers_internal): Remove.
3256 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3257 Fns_store_cut_buffer_internal.
3258 (ns_get_foreign_selection, Fx_own_selection_internal)
3259 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3260 (Fns_get_selection_internal, Fns_store_selection_internal):
3261 Use ns_symbol_to_pb and check if return value is nil.
3262 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3263 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3264 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3265 renamed to Sns_store_selection_internal.
3266 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3267 and remove this function.
3268 (ns_handle_selection_clear): Remove, never used.
3269 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3270 here.
3271
e1b01a3a
KB
32722011-12-17 Ken Brown <kbrown@cornell.edu>
3273
3274 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3275 GID is unknown (Bug#10257).
3276
2adb6e85
PE
32772011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3278
3279 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3280 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3281 which caused a build failure on GNU/Linux IA-64. This problem was
3282 introduced by my 2011-10-07 patch.
3283
d1d7b339
JL
32842011-12-15 Juri Linkov <juri@jurta.org>
3285
3286 * image.c (imagemagick_error): New function. (Bug#10112)
3287 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3288 Use `imagemagick_error' where ImageMagick functions return
3289 `MagickFalse'.
3290 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3291 proper order.
3292
100d5755
KH
32932011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3294
3295 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3296 fill background (Bug#8992).
3297
454592a6
MR
32982011-12-13 Martin Rudalics <rudalics@gmx.at>
3299
3300 * window.c (Vwindow_combination_resize)
3301 (Vwindow_combination_limit): Use t instead of non-nil in
3302 doc-strings.
61d4b438
MR
3303 (Vrecenter_redisplay): Add first sentence of doc-string on
3304 separate line.
53524d93 3305 (Frecenter): Fix doc-string typo.
454592a6 3306
3633e3aa
KH
33072011-12-11 Kenichi Handa <handa@m17n.org>
3308
3309 * coding.c (Funencodable_char_position): Pay attention to the
3310 buffer text relocation (Bug#9389).
3311
7b9d523a 33122011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3313
7b9d523a
JD
3314 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3315 gtk_init (Bug#10100).
3316
b73189c6
EZ
33172011-12-10 Eli Zaretskii <eliz@gnu.org>
3318
3319 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3320 IT->string is nil. (Bug#10263)
3321
f7dfe5d6
JD
33222011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3323
83faebb4
JD
3324 * nsterm.h (x_free_frame_resources): Declare.
3325
f7dfe5d6
JD
3326 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3327 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3328
3329 * nsterm.h (ns_get_defaults_value): Declare.
3330
3331 * nsterm.m (ns_default): Call ns_get_defaults_value.
3332
7cd4e72c
EZ
33332011-12-09 Eli Zaretskii <eliz@gnu.org>
3334
3335 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3336 (Bug#10170)
3337
b34d7317
YM
33382011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3339
3340 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3341 that where the value of an _OBJC_* symbol points to is in the .bss
3342 section (Bug#10240).
3343
76470ad1
KH
33442011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3345
3346 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3347 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3348
745fff94
KH
33492011-12-08 Kenichi Handa <handa@m17n.org>
3350
3351 * ftfont.c (get_adstyle_property): Fix previous change
3352 (Bug#10233).
3353
6e44397c
JB
33542011-12-07 Juanma Barranquero <lekktu@gmail.com>
3355
3356 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3357 dirs from the default value of EMACSLOADPATH (bug#10208).
3358
7efa6272
GM
33592011-12-07 Glenn Morris <rgm@gnu.org>
3360
3361 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3362 installation and source directories as well. (Bug#10208)
3363
f6fc4d87
CY
33642011-12-06 Chong Yidong <cyd@gnu.org>
3365
3366 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3367
2bf26180
GM
33682011-12-06 Glenn Morris <rgm@gnu.org>
3369
3370 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3371 as an error, not just -1. (Bug#10217)
3372
3a6ad4f0
CY
33732011-12-05 Chong Yidong <cyd@gnu.org>
3374
3375 * keyboard.c (process_special_events): New function.
3376 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3377
75a3b399
PE
33782011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3379
3380 * coding.c (encode_designation_at_bol): Don't use uninitialized
3381 local variable (Bug#9318).
3382
c3c9e25e
KH
33832011-12-05 Kenichi Handa <handa@m17n.org>
3384
3385 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3386 return Qnil (Bug#8046, Bug#10193).
3387
5eb05ea3
KH
33882011-12-05 Kenichi Handa <handa@m17n.org>
3389
3390 * coding.c (encode_designation_at_bol): New args charbuf_end and
3391 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3392 (coding_set_source): Return how many bytes coding->source was
3393 relocated.
3394 (coding_set_destination): Return how many bytes
3395 coding->destination was relocated.
3396 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3397 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3398
33992011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3400
3401 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3402 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3403 macro (Bug#9318).
3404
34052011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3406
3407 The following changes are to fix Bug#9318.
3408
a79703f5 3409 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3410 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3411 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3412 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3413
7dbda6df
JB
34142011-12-05 Juanma Barranquero <lekktu@gmail.com>
3415
3416 * lisp.h (process_quit_flag): Fix external declaration.
3417
6d5eb5b0
SM
34182011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3419
3420 Don't macro-inline non-performance-critical code.
3421 * eval.c (process_quit_flag): New function.
3422 * lisp.h (QUIT): Use it.
3423
a0c3fad0
JD
34242011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3425
3426 * nsfns.m (get_geometry_from_preferences): New function.
3427 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3428
6c07aac2
AS
34292011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3430
3431 * emacs.c (Qkill_emacs): Define.
3432 (syms_of_emacs): Initialize it.
3433 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3434 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3435 (quit_throw_to_read_char): Add parameter `from_signal'.
3436 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3437 * lisp.h (QUIT): Call Fkill_emacs if requested.
3438
c052ead4
JD
34392011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3440
3441 * widget.c (update_wm_hints): Return if wmshell is null.
3442 (widget_update_wm_size_hints): New function.
3443
3444 * widget.h (widget_update_wm_size_hints): Declare.
3445
3446 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3447 widget_update_wm_size_hints (Bug#10104).
3448
9e49252b
EZ
34492011-12-03 Eli Zaretskii <eliz@gnu.org>
3450
3451 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3452 before a newline, prepare the bidi iterator for consuming the
3453 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3454 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3455
02b16839
JL
34562011-12-02 Juri Linkov <juri@jurta.org>
3457
3458 * search.c (Fword_search_regexp): New Lisp function created from
3459 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3460 (Fword_search_backward, Fword_search_forward)
3461 (Fword_search_backward_lax, Fword_search_forward_lax):
3462 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3463 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3464
0068070e
SM
34652011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3466
3467 * fileio.c (Finsert_file_contents): Move after-change-function call
3468 to before the "handled:" label, since all "goto handled" appear in
3469 cases where the *-change-functions have already been properly called
3470 (bug#10117).
3471
3360a3fc
AS
34722011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3473
3474 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3475 waiting for input. (Bug#10169)
3476
73d6c093
EZ
34772011-11-30 Eli Zaretskii <eliz@gnu.org>
3478
3479 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3480 verifies glyph row's hash code--we have just reallocated the
3481 glyphs, so their contents can be complete garbage. (Bug#10164)
3482
febe6bea
JB
34832011-11-30 Juanma Barranquero <lekktu@gmail.com>
3484
3485 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3486
801a4313
EZ
34872011-11-30 Eli Zaretskii <eliz@gnu.org>
3488
3489 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3490 attributes are tested _before_ calling verify_row_hash, to protect
3491 against GCC re-ordering of the tests. (Bug#10164)
3492
2b56b87e
JD
34932011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3494
3495 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3496
3497 * xterm.c (handle_one_xevent): Only set async_visible and friends
3498 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 3499 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
3500 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3501
dbf31225
PE
35022011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3503
3504 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3505 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3506 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3507 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3508 All uses changed to use GCPRO1 etc.
3509 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3510 Revert to old implementation (i.e., before 2011-03-11).
3511
1305621b
YM
35122011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3513
3514 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3515 of scroll runs so as to avoid assigning disabled bogus rows and
3516 unnecessary graphics copy operations.
3517
8c9afb46
EZ
35182011-11-27 Eli Zaretskii <eliz@gnu.org>
3519
3520 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3521 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3522 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3523 (malloc, free, realloc, calloc): Redirect to e_* only when
3524 compiling Emacs.
3525
3526 * lisp.h (GCTYPEBITS): Move before first use.
3527 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3528 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3529 this macro definition.
3530
3531 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3532 _MSC_VER.
3533
54e9e3bf
JD
35342011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3535
6d5eb5b0
SM
3536 * gtkutil.c (xg_create_frame_widgets):
3537 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3538 present with Gtk+ 2.0.
3539
83aca1cb
PE
35402011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3541
3542 * fileio.c (Finsert_file_contents): Undo previous change; see
3543 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3544
5b76caa4
PE
35452011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3546
3547 Rename locals to avoid shadowing.
3548 * fileio.c (Finsert_file_contents):
3549 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3550 * process.c (wait_reading_process_output):
3551 Rename inner 'proc' to 'p' to avoid shadowing.
3552 Indent for consistency with usual Emacs style.
3553
8c535114
EZ
35542011-11-25 Eli Zaretskii <eliz@gnu.org>
3555
3556 * xdisp.c (redisplay_window): If cursor row is not fully visible
3557 after recentering, and scroll-conservatively is set to a large
3558 number, scroll window by a few more lines to make the cursor fully
3559 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3560 (start_display): Don't move to the next line if the display should
3561 start at a newline that is part of a display vector or an overlay
3562 string. (Bug#10119)
8c535114 3563
fa4fdb5c
JL
35642011-11-24 Juri Linkov <juri@jurta.org>
3565
3566 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3567 after the `MagickPingImage' call. (Bug#10112)
3568
90ec88df
CY
35692011-11-23 Chong Yidong <cyd@gnu.org>
3570
3571 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3572
56e2e794
MR
35732011-11-23 Martin Rudalics <rudalics@gmx.at>
3574
3575 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3576 making another buffer current. (Bug#10114)
3577
b6e64c41
GM
35782011-11-23 Glenn Morris <rgm@gnu.org>
3579
3580 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3581
6b21de18
CY
35822011-11-23 Chong Yidong <cyd@gnu.org>
3583
3584 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3585 using it (Bug#5984).
3586
b12cd789
EZ
35872011-11-22 Eli Zaretskii <eliz@gnu.org>
3588
3589 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3590 and header-lines, as they don't have one computed for them.
3591 (Bug#10098)
3592
3593 * .gdbinit (prow): Make displayed values more self-explaining.
3594 Add row's hash code.
3595
261b6fd4
LMI
35962011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3597
3598 * process.c (wait_reading_process_output): Fix asynchrounous
3599 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 3600 (wait_reading_process_output): Add comment and URL.
261b6fd4 3601
e7cfd277
JD
36022011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3603
3604 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3605
a9b9b7f5
CY
36062011-11-21 Chong Yidong <cyd@gnu.org>
3607
3608 * window.c (Fnext_window, Fprevious_window): Doc fix.
3609
b0d15b4f
SM
36102011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3611
3612 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3613
fe7a3057
JB
36142011-11-20 Juanma Barranquero <lekktu@gmail.com>
3615
3616 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3617
d2999b1a
MR
36182011-11-20 Martin Rudalics <rudalics@gmx.at>
3619
3620 * window.c (Fset_window_combination_limit): Rename argument
3621 STATUS to LIMIT.
3622 (Vwindow_combination_limit): Remove "status" from doc-string.
3623
d5ff9cd0
AS
36242011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3625
3626 * m/ibms390.h: Remove.
3627 * m/ibms390x.h: Don't include "ibms390.h".
3628
a5bb9bd3
SM
36292011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3630
3631 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3632 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3633
cd1181db
JB
36342011-11-20 Juanma Barranquero <lekktu@gmail.com>
3635
3636 * casetab.c (Fset_case_table):
3637 * charset.c (Fcharset_after): Fix typos.
3638
615a3b8d 36392011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 3640
17e845af
PE
3641 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3642 Otherwise, valgrind does not work on some platforms.
3643 Problem reported by Andreas Schwab in
6a0bf43d
PE
3644 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3645 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3646 is set, removing the need for VIRT_ADDRESS_VARIES.
3647 (PURE_P): Use a more-efficient implementation that needs just one
3648 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3649 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3650 to 4 (xorl, subq, cmpq, setbe).
3651 * alloc.c (pure): Always extern now, since that's the
3652 VIRT_ADDR_VARIES behavior.
3653 (PURE_POINTER_P): Use a single comparison, not two, for
3654 consistency with the new puresize.h.
3655 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3656 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3657 Remove VIRT_ADDR_VARIES no longer needed.
3658
f8fe6f96
EZ
36592011-11-19 Eli Zaretskii <eliz@gnu.org>
3660
3661 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3662 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3663 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3664 behave as if the cursor position were at the window margin.
3665
3666 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3667 and the cursor position is out of bounds, behave as if the cursor
3668 position were at the window margin. (Bug#10075)
3669
df05a53c
CY
36702011-11-18 Chong Yidong <cyd@gnu.org>
3671
3672 * window.c (Fwindow_combination_limit): Make first argument
3673 non-optional, since it is meaningless for live windows like the
3674 selected window.
61ccba97 3675
2071918e
DA
36762011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3677
3678 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3679
b50a28de
SM
36802011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3681
3682 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3683 (graft_intervals_into_buffer): Simplify.
3684
015137db
EZ
36852011-11-18 Eli Zaretskii <eliz@gnu.org>
3686
3687 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3688 hash values of the two rows.
3689 (copy_row_except_pointers): Preserve the used[] arrays and the
3690 hash values of the two rows. (Bug#10035)
68c95424 3691 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3692
3693 * xdisp.c (row_hash): New function, body extracted from
3694 compute_line_metrics.
3695 (compute_line_metrics): Call row_hash, instead of computing the
3696 hash code inline.
3697
3698 * dispnew.c (verify_row_hash): Call row_hash for computing the
3699 hash code of a row, instead of duplicating code from xdisp.c.
3700
3701 * dispextern.h (row_hash): Add prototype.
3702
a2addb04
TH
37032011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3704
3705 * frame.c (delete_frame): Don't delete the terminal when the last
3706 X frame is closed if emacs is built with GTK toolkit.
3707
df85d315
JB
37082011-11-17 Juanma Barranquero <lekktu@gmail.com>
3709
3710 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3711
a0c2d0ae
MR
37122011-11-17 Martin Rudalics <rudalics@gmx.at>
3713
3714 * window.c (Vwindow_splits): Rename to
3715 Vwindow_combination_resize. Suggested by Juri Linkov.
3716 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3717 of Vwindow_splits.
3718
58179cce
JB
37192011-11-16 Juanma Barranquero <lekktu@gmail.com>
3720
7877f373
JB
3721 * nsfns.m (Fns_font_name):
3722 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3723
b6f67890
MR
37242011-11-16 Martin Rudalics <rudalics@gmx.at>
3725
3726 * window.h (window): Rename slot "nest" to "combination_limit".
3727 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3728 (Fset_window_nest): Rename to Fset_window_combination_limit.
3729 (Vwindow_nest): Rename to Vwindow_combination_limit.
3730 (recombine_windows, make_parent_window, make_window)
3731 (Fsplit_window_internal, saved_window)
3732 (Fset_window_configuration, save_window_save): Rename all
3733 occurrences of window_nest to window_combination_limit.
3734
c7015153
JB
37352011-11-15 Juanma Barranquero <lekktu@gmail.com>
3736
3737 * image.c (imagemagick_load_image): Fix typo.
3738
322ad6ec
EZ
37392011-11-14 Eli Zaretskii <eliz@gnu.org>
3740
3741 * xdisp.c (display_line): Move the call to
3742 highlight_trailing_whitespace before the call to
3743 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3744 faces of all the glyphs to compute ROW's hash value.
3745 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3746
f067b8ec
JB
37472011-11-14 Juanma Barranquero <lekktu@gmail.com>
3748
3749 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3750 just return (bug#10044).
3751
1e5b2111
EZ
37522011-11-12 Eli Zaretskii <eliz@gnu.org>
3753
7ef3cbd5
EZ
3754 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3755 with user-defined heap size. Bump the default size of the temacs
3756 heap to 27MB, to avoid memory warning when running temacs.
3757 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3758
1e5b2111
EZ
3759 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3760 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3761 (verify_row_hash) [XASSERTS]: New function.
3762 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3763 that the hash value of glyph rows is correct.
1e5b2111 3764
89d61221
MR
37652011-11-12 Martin Rudalics <rudalics@gmx.at>
3766
3767 * window.h (window): Remove splits slot.
3768 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3769 (Fdelete_other_windows_internal, make_parent_window)
3770 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3771 (Fset_window_configuration, save_window_save): Don't deal with
3772 split status of windows.
3773 (saved_window): Remove splits slot.
3774 (Vwindow_splits): Rewrite doc-string.
3775
97f18cc8
JD
37762011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3777
3778 * xfns.c (unwind_create_frame):
3779 * nsfns.m (unwind_create_frame):
3780 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3781 Vframe_list (Bug#9999).
3782
22a648b4
DA
37832011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3784
0b381c7e 3785 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3786
659afede
KH
37872011-11-11 Kenichi Handa <handa@m17n.org>
3788
3789 * callproc.c (Fcall_process): Set the member dst_multibyte of
3790 process_coding.
3791
9ac0394b
KH
37922011-11-11 Johan Bockgård <bojohan@gnu.org>
3793
3794 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3795 avoid a crash (bug#9496).
3796
2fbdc249
CY
37972011-11-09 Chong Yidong <cyd@gnu.org>
3798
3799 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3800 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3801
ac6b1f81
PE
38022011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3803
3804 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3805
09db192c
PE
38062011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3807
3808 Avoid some portability problems by eschewing 'extern inline' functions.
3809 The trivial performance wins aren't worth the portability hassles; see
3810 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3811 et seq.
3812 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3813 (window_box_width, window_box_left, window_box_left_offset)
3814 (window_box_right, window_box_right_offset): Undo previous change,
3815 by removing the "extern"s.
3816 * intervals.c (adjust_intervals_for_insertion)
3817 (adjust_intervals_for_deletion): Undo previous change,
3818 making these static again.
3819 (offset_intervals, temp_set_point_both, temp_set_point)
3820 (copy_intervals_to_string): No longer inline.
3821 * xdisp.c (window_text_bottom_y, window_box_width)
3822 (window_box_height, window_box_left_offset)
3823 (window_box_right_offset, window_box_left, window_box_right)
3824 (window_box): No longer inline.
3825
105216ed
CY
38262011-11-08 Chong Yidong <cyd@gnu.org>
3827
3828 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3829 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3830 Signal an error if not a live window.
105216ed
CY
3831 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3832 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3833
ae9e237f
JB
38342011-11-07 Juanma Barranquero <lekktu@gmail.com>
3835
3836 * lisp.h (syms_of_abbrev): Remove declaration.
3837 Reported by CHENG Gao <chenggao@royau.me>.
3838
c7aa8333
EZ
38392011-11-07 Eli Zaretskii <eliz@gnu.org>
3840
3841 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3842 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3843 of temacs in GUI mode.
3844
be7f5545
MR
38452011-11-07 Martin Rudalics <rudalics@gmx.at>
3846
3847 * window.h: Declare delete_all_child_windows instead of
3848 delete_all_subwindows.
3849 * window.c (Fwindow_nest, Fset_window_nest)
3850 (Fset_window_new_total, Fset_window_new_normal)
3851 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3852 (delete_all_subwindows): Rename to delete_all_child_windows.
3853 (Fdelete_other_windows_internal, Fset_window_configuration):
3854 Call delete_all_child_windows instead of delete_all_subwindows.
3855 * frame.c (delete_frame): Call delete_all_child_windows instead
3856 of delete_all_subwindows.
3857
ca78dc43
PE
38582011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3859
3860 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3861 This is also needed for porting to any host where GC_MARK_STACK is
3862 not GC_MAKE_GCPROS_NOOPS.
3863 (which_symbols): Use it.
3864
a0241d01
KH
38652011-11-07 Kenichi Handa <handa@m17n.org>
3866
3867 * coding.c (coding_set_destination): Check coding->src_pos only
3868 when coding->src_object is a buffer (bug#9910).
3869
3870 * process.c (send_process): Set the member src_multibyte of coding
3871 to 0 (bug#9911) when sending a unibyte text.
3872
3873 * callproc.c (Fcall_process): Set the member src_multibyte of
3874 process_coding to 0 (bug#9912).
3875
a64bfdfa 38762011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3877
3878 * xmenu.c (cleanup_widget_value_tree): New function.
3879 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3880 calling free_menubar_widget_value_tree directly (Bug#9830).
3881
cb41b32a
PE
38822011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3883
3884 Fix some portability problems with 'inline'.
3885 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3886 (window_box_width, window_box_left, window_box_left_offset)
3887 (window_box_right, window_box_right_offset): Declare extern.
3888 Otherwise, these inline functions do not conform to C99 and
3889 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3890 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3891 * intervals.c (adjust_intervals_for_insertion)
3892 (adjust_intervals_for_deletion): Now extern, because otherwise the
3893 extern inline functions 'offset_intervals' couldn't refer to it.
3894 (static_offset_intervals): Remove.
3895 (offset_intervals): Rewrite using the old contents of
3896 static_offset_intervals. The old version didn't conform to C99
3897 because an extern inline function contained a reference to an
3898 identifier with static linkage.
3899
b7041366
AS
39002011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3901
3902 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3903 GC.
3904
88a37c4d
EZ
39052011-11-06 Eli Zaretskii <eliz@gnu.org>
3906
3907 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3908 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3909 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3910 return Qleft_to_right.
3911
49745b39
CY
39122011-11-06 Chong Yidong <cyd@gnu.org>
3913
3914 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3915 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3916 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3917 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3918 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3919 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3920 (Fwindow_vscroll): Doc fix.
3921 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3922 argument, since it makes no sense to pass a live window and for
3923 consistency with window-child.
3924
1f05cd82
CS
39252011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3926
3927 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3928 support MSVC.
3929
22610910
JR
39302011-11-05 Jason Rumney <jasonr@gnu.org>
3931
3932 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3933 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3934 fonts (Bug#6029).
3935 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3936 bitwise arithmetic preventing use of unicode-sip and non-truetype
3937 opentype fonts.
3938
a06776b2
EZ
39392011-11-05 Eli Zaretskii <eliz@gnu.org>
3940
3ad924ba
EZ
3941 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3942 "emacs"-only part.
3943
a06776b2
EZ
3944 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3945 initialization code to keep similarity to xfns.c after changes
3946 from 2011-11-05.
3947
c9e7db78
JD
39482011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3949
a97f8f3f
JD
3950 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3951 (unwind_create_frame): New function (Bug#9943).
3952 (Fx_create_frame): Restructure code to be more similar to the one in
3953 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3954 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3955 Move terminal->reference_count++ just before making the frame official
3956 (Bug#9943).
3957
3958 * nsterm.m (x_free_frame_resources): New function.
3959 (x_destroy_window): Move code to x_free_frame_resources.
3960
c9e7db78 3961 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
3962 (Fx_create_frame, x_create_tip_frame):
3963 Move terminal->reference_count++ just before making the frame
75f1671a 3964 official. Move initialization of image_cache_refcount and
c9e7db78
JD
3965 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3966
a6fc3b5c
EZ
39672011-11-05 Eli Zaretskii <eliz@gnu.org>
3968
3969 Support MSVC build with newer versions of Visual Studio.
3970 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3971 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3972 nt/gmake.defs.
3973
3974 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3975 which are not supported by MSVC.
3976 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3977 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3978 bitfields.
3979 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3980 types in bitfields.
3981 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3982
3983 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3984
58179cce 39852011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
3986
3987 Support MSVC build with newer versions of Visual Studio.
3988 * w32.c: Don't include w32api.h for MSVC.
3989 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3990
3991 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3992 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3993 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3994 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3995 e_* cousins.
3996 (alloca) [_MSC_VER]: Define to _alloca.
3997
3998 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3999
4000 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4001
a58c13ed
EZ
40022011-11-04 Eli Zaretskii <eliz@gnu.org>
4003
4004 * xdisp.c (note_mouse_highlight): If either of
4005 previous/next-single-property-change returns nil, treat that as
4006 the beginning or the end of the buffer. (Bug#9955)
4007
fe0b6370
JD
40082011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4009
a58c13ed 4010 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4011 label is not null (Bug#9951).
4012 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4013 may be NULL.
4014
89bd5ee1
EZ
40152011-11-04 Eli Zaretskii <eliz@gnu.org>
4016
4017 * window.c (Fwindow_body_size): Mention in the doc string that the
4018 return value is in frame's canonical units. (Bug#9949)
4019
84c3edb9
EZ
40202011-11-03 Eli Zaretskii <eliz@gnu.org>
4021
4e2fb5c7
EZ
4022 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4023
84c3edb9 4024 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4025 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4026 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4027
bc17a887
EZ
40282011-11-01 Eli Zaretskii <eliz@gnu.org>
4029
4030 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4031 Don't stop backward scan on the continuation glyph, even though
4032 its CHARPOS is positive.
6d5eb5b0
SM
4033 (mouse_face_from_buffer_pos, note_mouse_highlight):
4034 Rename cover_string to disp_string.
bc17a887 4035
4ee88440
MR
40362011-11-01 Martin Rudalics <rudalics@gmx.at>
4037
4038 * window.c (temp_output_buffer_show): Don't use
4039 Vtemp_buffer_show_specifiers.
4040 (Vtemp_buffer_show_specifiers): Remove unused variable.
4041
c2ff3c02
EZ
40422011-10-30 Eli Zaretskii <eliz@gnu.org>
4043
4044 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4045 past the beginning of the current glyph matrix.
4046
58179cce 40472011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4048
4049 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4050 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4051 HAVE_GTK3 (Bug#9869).
b77a6a7f 4052
3b574623
JD
4053 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4054 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4055
b77a6a7f
JD
4056 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4057
4058 * xterm.c: Declare x_handle_net_wm_state to return int.
4059 (handle_one_xevent): Check if we are iconified but don't have
4060 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4061 (get_current_wm_state): Return non-zero if not hidden,
4062 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4063 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4064 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4065 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4066
196e41e4
PE
40672011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4068
4069 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4070 so that this new function doesn't get optimized away by a
4071 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4072
021f2e1a
AS
40732011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4074
4075 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4076
8b058d44
EZ
40772011-10-29 Eli Zaretskii <eliz@gnu.org>
4078
4079 Fix the `xbytecode' command.
4080 * .gdbinit (xprintbytestr): New command.
b50a28de 4081 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4082 (xbytecode): Print the byte-code string as well.
4083
4452fb80
EZ
40842011-10-29 Kim Storm <storm@cua.dk>
4085
8b058d44
EZ
4086 * alloc.c (which_symbols): New function.
4087
21b72067
AS
40882011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4089
4090 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4091 line. (Bug#9903)
4092
83ed7b5c
GM
40932011-10-29 Glenn Morris <rgm@gnu.org>
4094
4095 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4096 Not clear what it was for, and it causes various bugs. (Bug#9839)
4097
5a7a728b
EZ
40982011-10-28 Eli Zaretskii <eliz@gnu.org>
4099
4100 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4101 possible random value that matches one of those tested as
4102 condition to clear the mouse face.
4103
d3d0842f
CY
41042011-10-28 Chong Yidong <cyd@gnu.org>
4105
4106 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4107
31b39d13
DN
41082011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4109
4110 * window.c (make_window): Initialize phys_cursor_on_p.
4111
9aba6043
SM
41122011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4113
4114 * lisp.h (struct Lisp_Symbol): Update comments.
4115
c20992f4
JB
41162011-10-28 Juanma Barranquero <lekktu@gmail.com>
4117
4118 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4119
db4f02f2
EZ
41202011-10-28 Eli Zaretskii <eliz@gnu.org>
4121
4122 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4123 <oslsachem@gmail.com> for helping to debug this.
4124
4125 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4126 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4127 (g_b_init_get_glyph_outline_w): New static variables.
4128 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4129 (GetGlyphOutlineW_Proc): New typedefs.
4130 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4131 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4132 New functions.
4133 (w32font_open_internal, compute_metrics):
4134 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4135 instead of calling the "wide" APIs directly.
4136
4137 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4138
4139 * w32.h (syms_of_w32font): Add prototype.
4140
87e68db4
JB
41412011-10-27 Juanma Barranquero <lekktu@gmail.com>
4142
4143 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4144 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4145 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4146 (Fmove_to_window_line): Doc fix.
4147
435c1d67
CY
41482011-10-27 Chong Yidong <cyd@gnu.org>
4149
4150 * process.c (make_process): Set gnutls_state to NULL.
4151
4152 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4153 non-NULL, regardless of GNUTLS_INITSTAGE.
4154 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4155 an error. Set process slots as soon as we allocate them.
4156
4157 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4158
9c6c6f49
CY
41592011-10-27 Chong Yidong <cyd@gnu.org>
4160
9aba6043
SM
4161 * gnutls.c (emacs_gnutls_deinit): New function.
4162 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
4163 (Fgnutls_deinit, Fgnutls_boot): Use it.
4164
4165 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4166 (deactivate_process): Call emacs_gnutls_deinit.
4167
657d08d3
JB
41682011-10-27 Juanma Barranquero <lekktu@gmail.com>
4169
4170 * image.c (x_create_x_image_and_pixmap):
4171 * w32.c (sys_rename, w32_delayed_load):
4172 * w32font.c (fill_in_logfont):
4173 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4174
5430d399
JB
41752011-10-26 Juanma Barranquero <lekktu@gmail.com>
4176
4177 * w32fns.c (w32_default_color_map): New function,
4178 extracted from Fw32_default_color_map.
a7ef684b 4179 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 4180
fe0055fa
PE
41812011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4182
4183 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4184
e6346438
SM
41852011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4186
4187 * keyboard.c (test_undefined): New function (bug#9751).
4188 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4189
e112cc37
ET
41902011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4191
4192 * sysdep.c (init_sys_modes): Fix the check for the controlling
4193 terminal (Bug#6649).
4194
7b5d6677
EZ
41952011-10-20 Eli Zaretskii <eliz@gnu.org>
4196
4197 * dispextern.h (struct bidi_it): New member next_en_type.
4198
4199 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4200 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4201 current character, check also for next_en_type being WEAK_EN.
4202 (bidi_resolve_weak): Don't enter the expensive loop if the current
4203 position is before next_en_pos. Record the bidi type of the first
4204 non-ET, non-BN character we find, in addition to its position.
4205 (bidi_level_of_next_char): Invalidate next_en_type when
4206 next_en_pos is over-stepped.
4207
7da0b018
PE
42082011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4209
4210 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4211 * editfns.c: Rewrite current-time-zone so that it invokes
4212 the equivalent of (format-time-string "%Z") to get the time zone name.
4213 This fixes a bug when the time zone name contains characters that
4214 need converting from the system time locale to Emacs internal format.
4215 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4216 that patch fixed format-time-string to do the conversion, but
4217 I forgot to fix current-time-zone.
4218 (format_time_string): New function, containing most of
4219 what Fformat_time_string used to contain.
4220 (Fformat_time_string): Rewrite in terms of format_time_string.
4221 This doesn't change this function's behavior.
4222 (current-time-zone): Rewrite to use format_time_string.
4223 This fixes the bug reported by Michael Schierl in
4224 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4225 Jason Rumney's 2007-06-07 change worked around this bug, but
4226 didn't fix it.
4227 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4228
8547b010
EZ
42292011-10-19 Eli Zaretskii <eliz@gnu.org>
4230
4231 * xdisp.c (start_display): If the character at POS is displayed
4232 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4233 (try_window_reusing_current_matrix): If a line ends in a display
4234 vector or the next line starts in a display vector, continue
4235 redrawing the window even though the character position of
4236 start_row was reached.
8547b010
EZ
4237 (Bug#9771, part 2)
4238
4e948d15
CY
42392011-10-18 Chong Yidong <cyd@gnu.org>
4240
4241 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4242 with nobreak-char-display too.
4243
4787455f
EZ
42442011-10-18 Eli Zaretskii <eliz@gnu.org>
4245
4246 Fix part 3 of bug#9771.
4247 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4248 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4249 non-neutral characters if the current character is a paragraph
4250 separator (a.k.a. Newline). This avoids running the same
4251 expensive loop twice, once when we consume the preceding newline
4252 and the other time when the line actually needs to be displayed.
4253 Avoid the loop when we see neutrals on the base embedding level
4254 following a character whose directionality is the same as the
4255 paragraph's. This avoids running the expensive loop when a line
4256 ends in a long sequence of neutrals, like control characters.
4257 Add assertion against STRONG_AL type. Slightly rearrange code
4258 that determines the type of a neutral given the first non-neutral
4259 that follows it.
4260 (bidi_level_of_next_char): Set next_en_pos to zero when
4261 invalidating its info.
4262
2c91f553
EZ
42632011-10-17 Eli Zaretskii <eliz@gnu.org>
4264
4265 * xdisp.c (push_display_prop): Determine whether to record string
4266 or buffer position by IT->string, not by IT->method. Allow
4267 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4268 (move_it_vertically_backward): Don't look for character position
4269 immediately after the newline when in a continuation line.
4270 (Bug#9771, part 1)
2c91f553 4271
c7b08b0d
MR
42722011-10-15 Martin Rudalics <rudalics@gmx.at>
4273
4274 * window.c (coordinates_in_window): Rewrite and delabelize
4275 vertical border check. (Bug#5357) (Bug#9618)
4276
6b02f655
SM
42772011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4278
4279 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4280 errors in XSetWindowBorder (bug#9310).
4281
81d40c92
DA
42822011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4283
4284 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4285 avoid crash when xmalloc overrun checking is enabled.
4286
d4172c3b
EZ
42872011-10-13 Eli Zaretskii <eliz@gnu.org>
4288
4289 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4290 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4291 cursor motion with <left> and <right> arrow keys.
4292
4293 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4294 some callers set that themselves.
4295
b00eea75
EZ
42962011-10-12 Eli Zaretskii <eliz@gnu.org>
4297
4298 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4299 display string and the previous row comes from the same string and
4300 is empty. (Bug#9739) (Bug#9738)
4301
8fe012c4
SM
43022011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4303
4304 * doc.c (get_doc_string): Encode file name (bug#9735).
4305
0074aef2
EZ
43062011-10-12 Eli Zaretskii <eliz@gnu.org>
4307
79beb178
EZ
4308 * bidi.c (bidi_level_of_next_char):
4309 * xdisp.c (get_visually_first_element): Remove old incorrect
4310 comments regarding the Unicode Line Separator character.
4311
0074aef2
EZ
4312 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4313
6e4b3fbe
DA
43142011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4315
4316 * alloc.c (Fgc_status): Do not access beyond zombies array
4317 boundary if nzombies > MAX_ZOMBIES.
4318 * alloc.c (dump_zombies): Add missing format specifier.
4319
0324f3af
PE
43202011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4321
b5525cac
PE
4322 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4323 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4324
0324f3af
PE
4325 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4326 Some packages use them to denote characters with modifiers.
4327
e9b5f888
AS
43282011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4329
4330 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4331 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4332 matching a pp-number. Rename parameter var to var1.
4333
127827c0
SM
43342011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4335
4336 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4337
c8fd3bd0
GM
43382011-10-08 Glenn Morris <rgm@gnu.org>
4339
4340 * callint.c (Fcall_interactively): Give a more explicit error for the
4341 'c' case with a non-character input. (Bug#8479)
4342
352ec8ff
EZ
43432011-10-08 Eli Zaretskii <eliz@gnu.org>
4344
03669ccb
EZ
4345 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4346 lines.
7061c986
EZ
4347 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4348 lines that are hscrolled on the left.
03669ccb 4349
352ec8ff
EZ
4350 * dispnew.c (buffer_posn_from_coords): Account for a possible
4351 presence of header-line. (Bug#4426)
4352
a66cfb1c
SM
43532011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4354
6b02f655
SM
4355 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4356 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4357
7c5ee88e
PE
43582011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4359
4360 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4361 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4362 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4363 this makes Emacs dump core during garbage collection on rare
4364 occasions. sizeof is obviously inferior to offsetof here, so
4365 stick with offsetof.
4366 (GC_POINTER_ALIGNMENT): New macro.
4367 (mark_memory): Omit 3rd (offset) arg; caller changed.
4368 Don't assume EMACS_INT alignment is the same as pointer alignment.
4369
df1bbe5b
SM
43702011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4371
4372 * keyboard.c (read_key_sequence_remapped): New var.
4373 (read_key_sequence): Compute remapping in the right buffer.
4374 (command_loop_1): Use read_key_sequence's remapping directly.
4375
51553db6
SM
43762011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4377
32c1fffd
SM
4378 * dired.c (file_name_completion): Don't expand file name.
4379 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4380 before checking file name handler.
4381
51553db6
SM
4382 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4383 they've been requested explicitly (bug#9591).
4384
b6bd1599 43852011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4386
4387 * keymap.c (Fsingle_key_description): Use make_specified_string
4388 instead of build_string to build string from push_key_description.
4389 (Bug#5193)
4390
f701dc2a
PE
43912011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4392
4222c55d
PE
4393 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4394 This fixes a Y2038 bug on 64-bit hosts.
4395 * buffer.c (reset_buffer):
4396 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4397 (Fclear_buffer_auto_save_failure):
4398 Use 0, not -1, to represent an unset failure time, since time_t
4399 might not be signed.
4400
f701dc2a
PE
4401 Remove dependency on glibc malloc internals.
4402 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4403 Move back here from lisp.h, but with their new implementations.
4404 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4405 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4406 * charset.c (charset_table_init): New static var.
4407 (syms_of_charset): Use it instead of xmalloc. This removes a
4408 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4409 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4410 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4411 Move back to alloc.c.
4412 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4413 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4414
9ceebf39
JD
44152011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4416
4417 * nsterm.m (windowDidResize): Call x_set_window_size only when
4418 ns_in_resize is true. Otherwise set pixelwidth/height and
4419 call change_frame_size (Bug#9628).
4420
cb993c58
PE
44212011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4422
3930c88b
PE
4423 Port --enable-checking=all to Fedora 14 x86-64.
4424 * charset.c (syms_of_charset): Also account for glibc malloc's
4425 internal overhead when calculating the initial malloc maximum.
4426
cb993c58
PE
4427 Port --enable-checking=all to Fedora 14 x86.
4428 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4429 Move to lisp.h.
4430 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4431 (overrun_check_realloc, overrun_check_free):
4432 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4433 That way, xmalloc returns a properly-aligned pointer even if
4434 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4435 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4436 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4437 into account when calculating the initial malloc maximum.
4438 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4439 Move here from alloc.c, so that charset.c can use it too.
4440 Properly align; the old code wasn't right for common 32-bit hosts
4441 when configured with --enable-checking=all.
4442 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4443 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4444
31bed486
EZ
44452011-09-29 Eli Zaretskii <eliz@gnu.org>
4446
04c70788 4447 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4448 use EDOM.
4449
fbcaa2f3
EZ
44502011-09-28 Eli Zaretskii <eliz@gnu.org>
4451
4452 * xdisp.c (compute_display_string_end): If there's no display
4453 string at CHARPOS, return -1.
4454
4455 * bidi.c (bidi_fetch_char): When compute_display_string_end
4456 returns a negative value, treat the character as a normal
4457 character not covered by a display string. (Bug#9624)
4458
a239d4e9
JB
44592011-09-28 Juanma Barranquero <lekktu@gmail.com>
4460
4461 * lread.c (Fread_from_string): Fix typo in docstring.
4462
88652fd5
EZ
44632011-09-27 Eli Zaretskii <eliz@gnu.org>
4464
4465 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4466 newline, reseat the iterator instead of bidi-iterating there one
4467 character at a time. (Bug#9610)
32c1fffd
SM
4468 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4469 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 4470
ed497dd4
AS
44712011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4472
4473 * lread.c (readevalloop): Use correct code for NBSP.
4474 (read1): Likewise. (Bug#9608)
4475
b2bf61aa
MA
44762011-09-25 Michael Albinus <michael.albinus@gmx.de>
4477
4478 * dbusbind.c (Fdbus_register_signal): When service is not
4479 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4480
32bbb17c
GM
44812011-09-25 Glenn Morris <rgm@gnu.org>
4482
4483 * buffer.c (truncate-lines): Doc fix.
4484
94e0933e
CY
44852011-09-24 Chong Yidong <cyd@stupidchicken.com>
4486
4487 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4488 (Fset_window_next_buffers): Doc fix.
4489
cddde921
GM
44902011-09-24 Glenn Morris <rgm@gnu.org>
4491
4492 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4493
1260aef1
PE
44942011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4495
25b4bfa0
PE
4496 Fix minor problems found by static checking.
4497 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
4498 * indent.c (Fvertical_motion): Fix == vs = typo.
4499
e3cbd34b
EZ
45002011-09-24 Eli Zaretskii <eliz@gnu.org>
4501
a66cfb1c
SM
4502 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4503 Default value is now t. Doc fix.
6bf7006f 4504
e3cbd34b 4505 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 4506 logic when moving up, not only when moving down. Fix the
e3cbd34b 4507 confusing name and values of the it_overshoot_expected variable;
32c1fffd 4508 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
4509
4510 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4511 CHARPOS is covered by a display string which includes newlines.
4512 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4513 is covered by a display string with embedded newlines.
4514
a3de0cbd
MA
45152011-09-24 Michael Albinus <michael.albinus@gmx.de>
4516
4517 * dbusbind.c (Fdbus_register_signal): Add match rule to
4518 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4519 (Fdbus_register_method, Vdbus_registered_objects_table):
4520 Fix docstring.
a3de0cbd 4521
b260039d
JM
45222011-09-24 Jim Meyering <meyering@redhat.com>
4523
32c1fffd 4524 do not ignore write error for any output size
b260039d
JM
4525 The previous change was incomplete.
4526 While it makes emacs --batch detect the vast majority of stdout
4527 write failures, errors were still ignored whenever the output size is
4528 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4529 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4530 && echo FAIL: ignored write error
4531 FAIL: ignored write error
4532 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4533 && echo FAIL: ignored write error
4534 FAIL: ignored write error
4535 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4536
8eca8a7c
AS
45372011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4538
4539 * emacs.c (Fkill_emacs): In noninteractive mode exit
4540 non-successfully if a write error occurred on stdout. (Bug#9574)
4541
3341db62
EZ
45422011-09-21 Eli Zaretskii <eliz@gnu.org>
4543
4544 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4545 the xassert test.
4546
4547 * dispextern.h (struct it): Update the comment documenting what
4548 can it->OBJECT be.
4549
8c203dbf
EZ
45502011-09-20 Eli Zaretskii <eliz@gnu.org>
4551
4552 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4553 a display string, extend search for cursor position to end of row.
4554 (find_row_edges): If the row ends in a newline from a display
4555 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4556 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4557 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4558 non-empty line. Fixes confusing cursor motion with arrow keys at
4559 the beginning of a line that starts with whitespace.
8c203dbf 4560
a4824228
LMI
45612011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4562
4563 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4564 (bug#9493).
4565
33ed493b
CY
45662011-09-18 Chong Yidong <cyd@stupidchicken.com>
4567
4568 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4569 boolean (Bug#9154).
4570
56cd55c8
EZ
45712011-09-18 Eli Zaretskii <eliz@gnu.org>
4572
4573 * xdisp.c (display_line): Record maximum and minimum buffer
4574 positions even if no glyphs were produced (e.g., by a zero-width
4575 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4576 buffer positions that will be removed from the glyph row because
4577 they don't fit.
c02dcedf
EZ
4578 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4579 column is beyond frame width: don't subtract 1 "pixel" when
4580 computing width of the stretch.
3e62b7e0
EZ
4581 (reseat_at_next_visible_line_start): Undo the change made on
4582 2011-09-17 that saved paragraph information and restored it after
4583 the call to `reseat'. (Bug#9545)
56cd55c8 4584
5ed99d36 45852011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4586
4587 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4588 and turn window cursor on if cleared (Bug#9415).
4589
5ed99d36 45902011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4591
4592 * search.c (boyer_moore): Take unibyte characters from pattern
4593 literally. (Bug#9458)
4594
9bade7b2
EZ
45952011-09-18 Eli Zaretskii <eliz@gnu.org>
4596
4597 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4598
e5e9d610
PE
45992011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4600
87e4427a
PE
4601 Fix minor problem found by static checking.
4602 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4603 initialized, to pacify gcc -Wuninitialized.
4604
e5e9d610
PE
4605 * fileio.c: Report proper errno when syscall falls.
4606 (Finsert_file_contents): Save and restore errno,
4607 so that report_file_error outputs the correct diagnostic.
4608 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4609
a1674f0b
EZ
46102011-09-18 Eli Zaretskii <eliz@gnu.org>
4611
4612 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4613
fbfb6dd4
EZ
46142011-09-17 Eli Zaretskii <eliz@gnu.org>
4615
4616 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4617 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4618
bb187662
EZ
46192011-09-17 Eli Zaretskii <eliz@gnu.org>
4620
1137e8b8 4621 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 4622 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
4623
4624 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4625 (bidi_find_paragraph_start): Search back for paragraph beginning
4626 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4627 (bidi_move_to_visually_next): Only trigger paragraph-related
4628 computations when the last character is a newline or at EOB, not
4629 just any NEUTRAL_B. (Bug#9470)
4630
bb187662
EZ
4631 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4632 truncated lines if point is covered by a display string. (Bug#9524)
4633
2e621251
PE
46342011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4635
4636 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4637 (cons_to_x_long): New function.
4638 (lisp_data_to_selection_data): Use it. Correct the test for
4639 short-versus-long data; it was negated. Break out of vector
4640 loop, for efficiency, when a long datum is discovered.
4641
91a15bc6
SM
46422011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4643
4644 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4645
b41c3a35
EZ
46462011-09-16 Eli Zaretskii <eliz@gnu.org>
4647
4648 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4649 GCC PR/17406) by declaring this function with external scope.
4650
7812ba2d
PE
46512011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4652
4653 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4654 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4655
cf7edc2a
AS
46562011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4657
4658 * editfns.c (Fformat): Correctly handle text properties on "%%".
4659
bd01620e
EZ
46602011-09-15 Eli Zaretskii <eliz@gnu.org>
4661
4662 * xterm.c (x_draw_composite_glyph_string_foreground):
4663 * w32term.c (x_draw_composite_glyph_string_foreground):
4664 * term.c (encode_terminal_code):
4665 * composite.c (composition_update_it, get_composition_id):
4666 * xdisp.c (get_next_display_element)
4667 (fill_composite_glyph_string): Add comments about special meaning
4668 of TAB characters in a composition.
4669
a02719a3
PE
46702011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4671
4672 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
4673 This occurs when processing a multibyte format.
4674 Problem reported by Wolfgang Jenker.
a02719a3 4675
72589a3c
JB
46762011-09-15 Johan Bockgård <bojohan@gnu.org>
4677
4678 * xdisp.c (try_cursor_movement): Only check for exact match if
4679 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4680
1c14176c
PE
46812011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4682
4683 Remove unused external symbols.
4684 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4685 * xdisp.c (calc_pixel_width_or_height): Now static.
4686 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4687 * indent.c (check_display_width):
4688 * w32term.c: Fix comment to match code.
4689 * xterm.c, xterm.h (x_catching_errors): Remove.
4690
d2eea5b5
PE
46912011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4692
4693 * xselect.c: Use signed conversions more consistently (Bug#9498).
4694 (selection_data_to_lisp_data): Assume incoming selection data are
4695 signed integers, not unsigned. This is to be consistent with
4696 outgoing selection data, which was modified to use signed integers
4697 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4698 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4699 expects long, not unsigned long.
4700
46888499
EZ
47012011-09-14 Eli Zaretskii <eliz@gnu.org>
4702
4703 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4704 computation of loop end. Reported by Johan Bockgård
4705 <bojohan@gnu.org>.
4706
ef8ef9fb
CY
47072011-09-13 Chong Yidong <cyd@stupidchicken.com>
4708
4709 * frame.c (Fother_visible_frames_p): Function deleted.
4710
fa819fed
EZ
47112011-09-12 Eli Zaretskii <eliz@gnu.org>
4712
4713 * indent.c (compute_motion): Process display vector front to back
4714 rather than the other way around. (Bug#2496)
4715
2ba8e008
SM
47162011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4717
4718 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4719
20f53c69
CY
47202011-09-11 Chong Yidong <cyd@stupidchicken.com>
4721
4722 * minibuf.c (Fread_from_minibuffer): Doc fix.
4723
d562d7a4
EZ
47242011-09-11 Eli Zaretskii <eliz@gnu.org>
4725
4726 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4727 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4728
1c4d7f3d
LMI
47292011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4730
4731 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4732 value for non-existent files.
4733
b885bf36
EZ
47342011-09-11 Eli Zaretskii <eliz@gnu.org>
4735
4736 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4737 set its "size" to -1. This will set the modtime_size field of
4738 the corresponding buffer to -1, which is what
4739 verify-visited-file-modtime expects for files that do not exist.
4740 (Bug#9139)
4741
6612f0bf
PE
47422011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4743
4744 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4745 here ...
4746 * lisp.h: ... from here. push_key_description is no longer
4747 defined in keyboard.c, so its declaration should not be in
4748 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4749 logically belongs with push_key_description.
4750
dfb3f755
PE
47512011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4752
4753 * buffer.h: Include <sys/types.h> instead of <time.h>.
4754 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4755 Problem reported by Herbert J. Skuhra.
4756
3134906c
LMI
47572011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4758
4759 * xml.c (parse_region): Make the parsing work for
4760 non-comment-starting XML files again (bug#9144).
4761
8d903f4e
AS
47622011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4763
4764 * image.c (gif_load): Fix calculation of bottom and right corner.
4765 (Bug#9468)
4766
80ad64f4
EZ
47672011-09-10 Eli Zaretskii <eliz@gnu.org>
4768
4769 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4770 redisplay in small windows.
4771
208a048d
EZ
47722011-09-09 Eli Zaretskii <eliz@gnu.org>
4773
4774 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4775
9b1c252e
MR
47762011-09-08 Martin Rudalics <rudalics@gmx.at>
4777
4778 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4779 Operate on live windows only.
4780
2949f33b
JB
47812011-09-08 Juanma Barranquero <lekktu@gmail.com>
4782
4783 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4784
e08dcafd
EZ
47852011-09-07 Eli Zaretskii <eliz@gnu.org>
4786
4787 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4788 only under bidi iteration.
4789
115b96bd
JD
47902011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4791
4792 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4793
c8199d0f
PE
47942011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4795
4796 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4797 Without this fix, the command to link temacs failed due to an
4798 undefined symbol __builtin_isnan. This is because
4799 /usr/include/iso/math_c99.h #defines isnan(x) to
4800 __builtin_isnan(x), but the bundled gcc, which identifies itself
4801 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4802 a __builtin_isnan.
4803 * floatfns.c (isnan): #undef, and then #define to a clone of
4804 what's in data.c.
4805 (Fisnan): Always define, since it's always available now.
4806 (syms_of_floatfns): Always define isnan at the Lisp level.
4807
e39b275c 48082011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4809
4810 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4811
b2db44d9 48122011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4813
f4af5137 4814 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4815 The previous code assumed that file offsets (off_t values) fit in
4816 EMACS_INT variables, which is not true on typical 32-bit hosts.
4817 The code messed up by falsely reporting buffer overflow in cases
4818 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4819 when "big" contains more than 2**29 bytes, even though this
4820 inserts just one byte and does not overflow the buffer.
4821 (Finsert_file_contents): Store file offsets as off_t
4822 values, not as EMACS_INT values. Check for overflow when
4823 converting between EMACS_INT and off_t. When checking for
4824 buffer overflow or for overlap, take the offsets into account.
4825 Don't use EMACS_INT for small values where int suffices.
4826 When checking for overlap, fix a typo: ZV was used where
4827 ZV_BYTE was intended.
4828 (Fwrite_region): Don't assume off_t fits into 'long'.
4829 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4830
ecfc0a49
MA
48312011-09-05 Michael Albinus <michael.albinus@gmx.de>
4832
4833 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4834
6511acf2 48352011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4836
0999621a 4837 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4838
4839 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4840 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4841 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4842 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4843 (modify_event_symbol): Do not assume that the length of
4844 name_alist_or_stem is safe to alloca and fits in int.
4845 (Fexecute_extended_command): Likewise for function name and binding.
4846 (Frecursion_depth): Wrap around reliably on integer overflow.
4847 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4848 since some callers pass EMACS_INT values.
4849 (Fsingle_key_description): Don't crash if symbol name contains more
4850 than MAX_ALLOCA bytes.
4851 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4852 (get_minibuffer): Arg is now EMACS_INT, not int.
4853 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4854 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4855 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4856
2be7d702
PE
4857 * dbusbind.c (signature_cat): New function.
4858 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4859 Do not overrun buffer; instead, report string overflow.
4860
9d1df220
PE
4861 * dispnew.c (add_window_display_history): Don't overrun buffer.
4862 Truncate instead; this is OK since it's just a log.
4863
33ef5c64
PE
4864 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4865 even if the time zone offset is outlandishly large.
4866 Don't mishandle offset == INT_MIN.
4867
66c6fdd5
PE
4868 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4869 when creating daemon; the previous buffer-overflow check was incorrect.
4870
d749b01b
PE
4871 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4872 which has the guts of the old verror function.
4873
b5cd1905
PE
4874 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4875 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4876
6e1a67fb
PE
4877 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4878 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4879 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4880 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4881 length of string rather than counting it via multiple sprintfs;
4882 that's simpler and more reliable.
c21721cc
PE
4883 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4884 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4885 sprintf, in case result does not fit in int.
4886
c57b67fc
PE
4887 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4888 (fontset_from_font): Print it.
4889
8a401434
PE
4890 * frame.c (tty_frame_count): Now printmax_t, not int.
4891 (make_terminal_frame, set_term_frame_name): Print it.
4892 (x_report_frame_params): In X, window IDs are unsigned long,
4893 not signed long, so print them as unsigned.
4894 (validate_x_resource_name): Check for implausibly long names,
4895 and don't assume name length fits in 'int'.
4896 (x_get_resource_string): Don't blindly alloca invocation name;
4897 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4898 not fit in int.
4899
6e1a67fb
PE
4900 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4901 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
4902 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4903
0df02bf3
PE
4904 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4905 Use esprintf, not sprintf, in case result does not fit in int.
4906
48e30793
PE
4907 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4908 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4909 it as a large positive number.
4910 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4911 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4912
a66ff6d8
PE
4913 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4914 in case result does not fit in int.
4915
aca216ff
PE
4916 * print.c (float_to_string): Detect width overflow more reliably.
4917 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4918 buffer overrun. Don't assume list length fits in 'int'. Treat
4919 print length of 0 as 0, not as infinity; to be consistent with other
4920 uses of print length in this function. Don't overflow print length
4921 index. Don't assume hash table size fits in 'long', or that
4922 vectorlike size fits in 'unsigned long'.
4923
31c286f7
PE
4924 * process.c (make_process): Use printmax_t, not int, to format
4925 process-name gensyms.
4926
55e5faa1
PE
4927 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4928
80f2e268
PE
4929 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4930 to avoid potential buffer overrun.
4931
670741ab
PE
4932 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4933 if X resource line is longer than 512 bytes.
4934
b7163a50
PE
4935 * xfns.c (x_window): Make sprintf buffer a bit bigger
4936 to avoid potential buffer overrun.
4937
ae58ff1f
PE
4938 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4939
c43c8a6a
PE
4940 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4941
3f8236f4
PE
49422011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4943
53e9fe90 4944 Integer overflow fixes for scrolling, etc.
6511acf2
PE
4945 Without these, Emacs silently mishandles large integers sometimes.
4946 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
4947 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4948
6511acf2
PE
4949 * xdisp.c (try_window_id): Check Emacs fixnum range before
4950 converting to 'int'.
806add1d 4951
6511acf2 4952 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
4953 Check that an Emacs fixnum is in range before assigning it to 'int'.
4954 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4955 values converted from Emacs fixnums.
4956 (Frecenter): Don't wrap around a line count if it is out of 'int'
4957 range; instead, treat it as an extreme value.
4958 (Fset_window_configuration, compare_window_configurations):
4959 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4960
6511acf2
PE
4961 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4962 that can exceed INT_MAX. Check that EMACS_INT value is in range
4963 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
4964 (match_limit): Don't assume that a fixnum can fit in 'int'.
4965
6511acf2 4966 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
4967 exceed INT_MAX.
4968
6511acf2 4969 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
4970 (Fvertical_motion): Don't wrap around LINES values that don't fit
4971 in 'int'. Instead, treat them as extreme values. This is good
4972 enough for windows, which can't have more than INT_MAX lines anyway.
4973
fcb901a7
LMI
49742011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4975
0f2f6b6d
LMI
4976 * Require libxml/parser.h to avoid compilation warning.
4977
fcb901a7
LMI
4978 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4979
4980 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4981 since this reportedly can destroy thread storage.
4982
6e20a0d4
CY
49832011-08-30 Chong Yidong <cyd@stupidchicken.com>
4984
4985 * syntax.c (find_defun_start): Update all cache variables if
4986 exiting early (Bug#9401).
4987
148ae00e
EZ
49882011-08-30 Eli Zaretskii <eliz@gnu.org>
4989
f6cfbd8f
EZ
4990 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4991
148ae00e
EZ
4992 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4993 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4994 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4995
4996 * term.c (tty_append_glyph): New function.
4997 (produce_stretch_glyph): Static function and its prototype deleted.
4998
a66cfb1c
SM
4999 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5000 Add prototypes.
148ae00e 5001
c4a07a4c
PE
50022011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5003
5004 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5005 when checking :margin (Bug#9390).
5006 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5007 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5008 so that the name doesn't mislead. All uses changed.
5009
6bc8cd65
JB
50102011-08-28 Johan Bockgård <bojohan@gnu.org>
5011
5012 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5013 set_tty_hooks.
5014
dca4927e
EZ
50152011-08-27 Eli Zaretskii <eliz@gnu.org>
5016
5017 * xdisp.c (move_it_to): Don't bail out early when reaching
5018 position beyond to_charpos, if we are scanning backwards.
5019 (move_it_vertically_backward): When DY == 0, make sure we get to
5020 the first character in the line after the newline.
5021
f2cad773
PE
50222011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5023
5024 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5025 (ccl_driver): Do not generate an out-of-range pointer.
5026 (Fccl_execute_on_string): Remove unnecessary check for
5027 integer overflow, noted by Stefan Monnier in
5028 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5029 Remove a FIXME that didn't need fixing.
5030 Simplify the newly-introduced buffer reallocation code.
5031
0cae2cdb
JB
50322011-08-27 Juanma Barranquero <lekktu@gmail.com>
5033
5034 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5035
5fc295a4 50362011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5037
70c60eb2 5038 Integer and memory overflow issues (Bug#9196).
726e0ab1 5039
d31850da
PE
5040 * doc.c (get_doc_string): Rework so that
5041 get_doc_string_buffer_size is the actual buffer size, rather than
5042 being 1 less than the actual buffer size; this makes xpalloc more
5043 convenient.
5044
a69fbedb
PE
5045 * image.c (x_allocate_bitmap_record, cache_image):
5046 * xselect.c (Fx_register_dnd_atom):
5047 Simplify previous changes by using xpalloc.
5048
fe5c5d37
PE
5049 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5050 since either will do and ptrdiff_t is convenient with xpalloc.
5051
0065d054
PE
5052 * charset.c (charset_table_size)
5053 (struct charset_sort_data.priority): Now ptrdiff_t.
5054 (charset_compare): Don't overflow if priorities differ greatly.
5055 (Fsort_charsets): Don't assume list length fits in int.
5056 Check for size-calculation overflow when allocating sort data.
5057 (syms_of_charset): Allocate an initial charset table that is
5058 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5059
5060 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5061
5062 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5063 The actual value is always <= INT_MAX, and leaving it unsigned made
5064 overflow checking harder.
5065
5066 * dispextern.h (struct glyph_matrix.rows_allocated)
5067 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5068 with xpalloc. The values are still always <= INT_MAX.
5069
5070 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5071
5072 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5073 (SAFE_NALLOCA): New macro.
5074
5075 * region-cache.c (struct boundary.pos, find_cache_boundary)
5076 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5077 (set_cache_region, invalidate_region_cache)
5078 (revalidate_region_cache, know_region_cache, region_cache_forward)
5079 (region_cache_backward, pp_cache):
5080 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5081 so that ptrdiff_t * can be passed to xpalloc.
5082 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5083 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5084 (pp_cache): Don't assume cache_len fits in int.
5085 * region-cache.h: Adjust extern decls to match.
5086
5087 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5088 EMACS_INT, since either will do, for xpalloc.
5089
5090 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5091 (xnmalloc, xnrealloc, xpalloc): New functions.
5092
726e0ab1
PE
5093 * bidi.c (bidi_shelve_header_size): New constant.
5094 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5095 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5096
51f30bc5 5097 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5098 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5099 (overlay_strings):
5100 Don't update size of array until after memory allocation succeeds,
5101 because xmalloc/xrealloc may not return.
0065d054
PE
5102 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5103 now that we have proper integer overflow checking.
5104 (record_overlay_string, overlay_strings): Catch overflows when
5105 calculating size of overlay_str_buf.
726e0ab1 5106
0065d054
PE
5107 * callproc.c (Fcall_process): Check for size overflow when
5108 calculating size of args2.
5109 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5110 Normally we prefer signed values, but sticking with ptrdiff_t would
5111 require adding more-complicated checks.
726e0ab1
PE
5112
5113 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5114 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5115 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5116 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5117
5118 * character.c (Fstring): Check for size-calculation overflow.
5119
5120 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5121 unnecessary integer overflow. Check for size overflow.
5122 (encode_coding_object): Don't update size until xmalloc succeeds.
5123
5124 * composite.c (get_composition_id): Check for overflow in glyph
5125 length calculations.
5126
5127 Integer and memory overflow fixes for display code.
5128 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5129 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5130 (scrolling_window): Check for overflow in size calculations.
5131 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5132 Don't assume glyph table len fits in int.
5133 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5134 (row_table_size): Now ptrdiff_t, not int.
5135 (scrolling_window): Avoid overflow in size calculations.
5136 Don't update size until allocation succeeds.
5137 * fns.c (concat): Check for overflow in size calculations.
5138 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5139 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5140 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5141
5142 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5143 (get_doc_string): Check for size calculation overflow.
5144 Don't update size until allocation succeeds.
5145 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5146 EMACS_INT, where ptrdiff_t will do.
5147 (Fsubstitute_command_keys): Check for string overflow.
5148
5149 * editfns.c (set_time_zone_rule): Don't assume environment length
5150 fits in int.
5151 (message_length): Now ptrdiff_t, not int.
5152 (Fmessage_box): Don't update size until allocation succeeds.
5153 Don't assume message length fits in int.
5154 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5155
0065d054
PE
5156 * emacs.c (main): Do not reallocate argv, since there is a null at
5157 the end that can be overwritten, and this way there's no need to
5158 worry about size-calculation overflow.
5159 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
5160
5161 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5162 alloc succeeds.
5163 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5164
5165 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5166 (x_set_scroll_bar_width, x_figure_window_size):
5167 Check for integer overflow.
5168 (x_set_alpha): Do not assume XINT fits in int.
5169
5170 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5171 This is for the members text_lines, text_cols, total_lines, total_cols,
5172 where the system imposes an 'int' limit.
5173
5174 * fringe.c (Fdefine_fringe_bitmap):
5175 Don't update size until alloc works.
5176
5177 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5178 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5179
5180 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5181 Check for size-calculation overflow.
5182 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5183 do, as we prefer signed integers.
5184 (id_to_widget.max_size, id_to_widget.used)
5185 (xg_store_widget_in_map, xg_remove_widget_from_map)
5186 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5187 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5188 Use and return ptrdiff_t, not int.
5189 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5190 * gtkutil.h: Change prototypes to match the above.
5191
5192 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5193 are duplicate now that they've been promoted to lisp.h.
5194 (x_allocate_bitmap_record, x_alloc_image_color)
5195 (make_image_cache, cache_image, xpm_load):
5196 Don't update size until alloc is done.
5197 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5198 (x_detect_edges):
3256efce 5199 Check for size calculation overflow.
726e0ab1
PE
5200 (ct_colors_allocated_max): New constant.
5201 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5202 overflow.
3256efce 5203
726e0ab1
PE
5204 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5205 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5206 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5207 Use ptrdiff_t, not int, to count maps.
5208 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
5209 calculations. Don't update size until allocation succeeds.
5210 Redo calculations to avoid overflow.
726e0ab1
PE
5211 * keyboard.h: Change prototypes to match the above.
5212
5213 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5214 to count maps.
5215 (current_minor_maps): Check for size calculation overflow.
5216 * keymap.h: Change prototypes to match the above.
5217
5218 * lread.c (read1, init_obarray): Don't update size until alloc done.
5219
5220 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5221 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5222
726e0ab1
PE
5223 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5224 Now ptrdiff_t, not int.
5225 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5226 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5227
5228 * process.c (Fnetwork_interface_list): Check for overflow
5229 in size calculation.
5230
5231 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5232
5233 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5234 overflow. Don't bother calling xmalloc when xrealloc will do.
5235
5236 * search.c (Freplace_match): Check for size calculation overflow.
5237 (Fset_match_data): Don't assume list lengths fit in 'int'.
5238
5239 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5240 for command line length. Do not attempt to address one before the
5241 beginning of an array, as that's not portable.
5242
5243 * term.c (max_frame_lines): Remove; unused.
5244 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5245 not int.
5246 (encode_terminal_code, calculate_costs): Check for size
5247 calculation overflow.
5248 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5249 table lengths and related sizes. Don't update size until alloc
5250 done. Redo calculations to avoid overflow.
5251 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5252
5253 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5254 subtracting pointers.
5255 (gobble_line): Check for overflow more carefully. Don't update size
5256 until alloc done.
5257
5258 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5259 Don't update size until alloc done.
5260 Redo size calculations to avoid overflow.
5261 Check for size calculation overflow.
0065d054 5262 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5263
5264 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5265 Use ptrdiff_t, not int, for sizes.
5266 (store_mode_line_noprop_char): Don't update size until alloc done.
5267
0065d054
PE
5268 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5269 Use ptrdiff_t, not int, for sizes.
5270 (Finternal_make_lisp_face, cache_face):
5271 Check for size calculation overflow.
5272 (cache_face): Treat size calculation overflows as if they were
5273 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5274
5275 * xfns.c (x_encode_text, x_set_name_internal)
5276 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5277 sizes, since they can exceed INT_MAX in size. Check for size
5278 calculation overflow.
5279
0065d054
PE
5280 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5281 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5282 Don't update size until alloc done.
5283
0065d054 5284 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5285 as sprintf is limited to int lengths.
1d526e2f 5286
252c5ee1
PE
5287 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5288 (X_LONG_MIN): New macros.
864d7ce7
PE
5289 Use them to make the following changes clearer.
5290 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5291 This change doesn't affect the value now, but it may help remind
5292 future maintainers not to raise the value too much later.
5293 (SELECTION_QUANTUM): Remove, replacing with ...
5294 (selection_quantum): ... new function, which avoids overflow.
5295 All uses changed.
5296 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5297 assumption that selection length fits in 'int'.
5298 (x_reply_selection_request, x_handle_selection_request)
5299 (x_get_window_property, receive_incremental_selection)
5300 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5301 (lisp_data_to_selection_data, clean_local_selection_data):
5302 Use ptrdiff_t, not int, to record length of selection.
5303 (x_reply_selection_request, x_get_window_property)
5304 (receive_incremental_selection, x_property_data_to_lisp):
5305 Redo calculations to avoid overflow.
5306 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5307 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5308 something.
5309 (x_get_window_property, receive_incremental_selection)
5310 (lisp_data_to_selection_data, x_property_data_to_lisp):
5311 Check for size-calculation overflow.
5312 (x_get_window_property, receive_incremental_selection)
5313 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5314 Don't store size until memory allocation succeeds.
5315 (x_get_window_property): Plug memory leak on memory exhaustion.
5316 Don't double-block input; malloc is safe here. Don't assume 2**34
5317 - 4 fits in unsigned long. Add an xassert to check
5318 XGetWindowProperty overflow. Be more careful about overflow
5319 calculations, and distinguish size from memory overflow better.
5320 (receive_incremental_selection): When tracing, don't assume
5321 unsigned int is less than INT_MAX.
5322 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5323 harmful) conversions of unsigned short to int.
5324 (lisp_data_to_selection_data): Don't assume that integers
5325 in the range -65535 through -1 fit in an X unsigned short.
5326 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5327 result parameters unless successful. Rely on cons_to_unsigned
5328 to report problems with elements; the old code wasn't right anyway.
5329 (x_check_property_data): Check for int overflow; we cannot use
5330 a wider type due to X limits.
5331 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5332
726e0ab1 5333 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5334
0065d054
PE
5335 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5336 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5337 (x_color_cells): Don't store size until memory allocation succeeds.
5338 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5339 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5340 (x_term_init): Don't assume length fits in int (sprintf is limited
5341 to int size).
bc18e09d 5342
ebfa62c0
PE
5343 Use ptrdiff_t for composition IDs.
5344 * character.c (lisp_string_width):
5345 * composite.c (composition_table_size, n_compositions)
5346 (get_composition_id, composition_gstring_from_id):
5347 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5348 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5349 * window.c (Frecenter):
5350 Use ptrdiff_t, not int, for composition IDs.
5351 * composite.c (get_composition_id): Check for integer overflow.
5352 * composite.h: Adjust prototypes to match the above changes.
5353
d3411f89
PE
5354 Use ptrdiff_t for hash table indexes.
5355 * category.c (hash_get_category_set):
5356 * ccl.c (ccl_driver):
5357 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5358 * coding.c (coding_system_charset_list, detect_coding_system):
5359 * coding.h (struct coding_system.id):
5360 * composite.c (get_composition_id, gstring_lookup_cache):
5361 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5362 * image.c (xpm_get_color_table_h):
5363 * lisp.h (hash_lookup, hash_put):
5364 * minibuf.c (Ftest_completion):
5365 Use ptrdiff_t for hash table indexes, not int (which is too
5366 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5367 32-bit --with-wide-int hosts).
5368
e097a6fa
PE
5369 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5370 Add a FIXME comment about memory leaks.
5371 (syms_of_charset): Don't assume xmalloc returns.
5372
5637687f
PE
5373 Don't assume that stated character widths fit in int.
5374 * character.c (Fchar_width, c_string_width, lisp_string_width):
5375 * character.h (CHAR_WIDTH):
5376 * indent.c (MULTIBYTE_BYTES_WIDTH):
5377 Use sanitize_char_width to avoid undefined and/or bad behavior
5378 with outlandish widths.
a66cfb1c 5379 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5380 now that we have two such functions. All uses changed.
5381 (sanitize_char_width): New inline function.
5382
a2271ba2
PE
5383 Don't assume that tab-width fits in int.
5384 * character.h (sanitize_width): New inline function.
5385 (SANE_TAB_WIDTH): New macro.
5386 (ASCII_CHAR_WIDTH): Use it.
5387 * indent.c (sane_tab_width): Remove. All uses replaced by
5388 SANE_TAB_WIDTH (current_buffer).
5389 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5390
18c52557
PE
5391 * fileio.c: Integer overflow issues with file modes.
5392 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5393
caeeedc1
PE
5394 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5395 Remove unreachable code.
5396 (read_hex, load_charset_map_from_file): Check for integer overflow.
5397
6df6ae42 5398 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5399 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5400 (x_send_scroll_bar_event): Likewise. Check that the size does not
5401 exceed limits imposed by XClientMessageEvent, as well as the usual
5402 ptrdiff_t and size_t limits.
5403
b13995db
PE
5404 * keyboard.c: Overflow, signedness and related fixes.
5405 (make_lispy_movement): Use same integer type in forward decl
5406 that is used in the definition.
5407 (read_key_sequence, keyremap_step):
5408 Change bufsize argument back to int, undoing my 2011-03-30 change.
5409 We prefer signed types, and int is wide enough here.
5410 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5411 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5412 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5413 length, not size_t. Use ptrdiff_t for index, not int.
5414 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5415 possibility of integer overflow.
5416
13464394
PE
5417 Overflow, signedness and related fixes for images.
5418
5419 * dispextern.h (struct it.stack[0].u.image.image_id)
5420 (struct_it.image_id, struct image.id, struct image_cache.size)
5421 (struct image_cache.used, struct image_cache.ref_count):
5422 * gtkutil.c (update_frame_tool_bar):
5423 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5424 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5425 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5426 * nsmenu.m (update_frame_tool_bar):
5427 * xdisp.c (calc_pixel_width_or_height):
5428 * xfns.c (image_cache_refcount):
5429 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5430 on typical 64-bit hosts.
5431
5432 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5433 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5434 Omit unnecessary casts to int.
5435 (parse_image_spec): Check that integers fall into 'int' range
5436 when the callers expect that.
5437 (image_ascent): Redo ascent calculation to avoid int overflow.
5438 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5439 (lookup_image): Remove unnecessary tests.
5440 (xbm_image_p): Locals are now of int, not EMACS_INT,
5441 since parse_image_check makes sure they fit into int.
5442 (png_load, gif_load, svg_load_image):
5443 Prefer int to unsigned where either will do.
5444 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5445 old tiff_error_handler and tiff_warning_handler.
5446 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5447 stack buffer overflows. It uses only the features of vsnprintf
5448 that are common to both POSIX and native Microsoft.
5449 (tiff_error_handler, tiff_warning_handler): Use it.
5450 (tiff_load, gif_load, imagemagick_load_image):
5451 Don't assume :index value fits in 'int'.
5452 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5453 (imagemagick_load_image): Check that crop parameters fit into
5454 the integer types that MagickCropImage accepts. Don't assume
5455 Vimagemagick_render_type has a nonnegative value. Don't assume
5456 size_t fits in 'long'.
5457 (gs_load): Use printmax_t to print the widest integers possible.
5458 Check for integer overflow when computing image height and width.
5459
c11821d4
EZ
54602011-08-26 Eli Zaretskii <eliz@gnu.org>
5461
5462 * xdisp.c (redisplay_window): Don't force window start if point
5463 will be invisible in the resulting window. (Bug#9324)
5464
0c95fcf7
EZ
54652011-08-25 Eli Zaretskii <eliz@gnu.org>
5466
5467 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5468 the display spec is of the form `(space ...)'.
5469 (handle_display_spec): Return the value returned by
5470 handle_single_display_spec, not just 1 or zero.
5471 (handle_single_display_spec): If the display spec is of the form
5472 `(space ...)', and specifies display in the text area, return 2
5473 rather than 1.
fee65a97 5474 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5475 accurately, and prefer exact match for point under bidi.
5476 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5477
5478 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5479 into disp_prop; all users changed.
5480
5481 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5482 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5483 for the text covered by the display property.
5484
e4ed06f1
CY
54852011-08-25 Chong Yidong <cyd@stupidchicken.com>
5486
5487 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5488 Change return value to nil.
5489 (Frecord_buffer): Delete unused function.
5490
f67cdd7f
EZ
54912011-08-24 Eli Zaretskii <eliz@gnu.org>
5492
5980d4c6
EZ
5493 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5494 buffers, return left-to-right.
8610fe8b
EZ
5495 (set_cursor_from_row): Consider candidate row a win if its glyph
5496 represents a newline and point is on that newline. Fixes cursor
5497 positioning on the newline at EOL of R2L text within L2R
5498 paragraph, and vice versa.
5499 (try_cursor_movement): Check continued rows, in addition to
5500 continuation rows. Fixes unwarranted scroll when point enters a
5501 continued line of R2L text within an L2R paragraph, or vice versa.
5502 (cursor_row_p): Consider the case of point being equal to
5503 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5504 from the end of a short line to the beginning of a continued line
5505 of R2L text within L2R paragraph.
5506 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5507 composed characters.
5980d4c6 5508
f67cdd7f
EZ
5509 * bidi.c (bidi_check_type): Use xassert.
5510 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5511 members.
5512
bca633fb
EZ
55132011-08-23 Eli Zaretskii <eliz@gnu.org>
5514
5515 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5516 a character.
5517
4a5885a7
CY
55182011-08-23 Chong Yidong <cyd@stupidchicken.com>
5519
5520 * nsfont.m (ns_otf_to_script): Fix typo.
5521
0902a04e
KH
55222011-08-22 Kenichi Handa <handa@m17n.org>
5523
5524 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5525 extra slot even if the purpose is char-code-property-table.
5526
1a2e6670
EZ
55272011-08-23 Eli Zaretskii <eliz@gnu.org>
5528
8ddde651
EZ
5529 * xdisp.c (redisplay_window): When computing centering_position,
5530 account for the height of the header line. (Bug#8874)
5531
425cc014
EZ
5532 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5533 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5534 candidate is selected by the mouse, and that candidate has a
5535 composed character under the mouse.
5536
1a2e6670
EZ
5537 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5538 coordinates reported by pos-visible-in-window-p for a composed
5539 character in column zero.
5540
8b76d6f8
SM
55412011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5542
5543 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5544
dac347dd
EZ
55452011-08-22 Eli Zaretskii <eliz@gnu.org>
5546
5547 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5548 consider it a hit if to_charpos is anywhere in the range of the
5549 composed buffer positions.
5550
e013fb34
CY
55512011-08-22 Chong Yidong <cyd@stupidchicken.com>
5552
5553 * image.c (gif_load): Don't assume that each subimage has the same
5554 dimensions as the base image. Handle disposal method that is
5555 "undefined" by the gif spec (Bug#9335).
5556
bd1ba3e8
CY
55572011-08-20 Chong Yidong <cyd@stupidchicken.com>
5558
5559 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5560 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5561
54a1215b
EZ
55622011-08-19 Eli Zaretskii <eliz@gnu.org>
5563
823564e5
EZ
5564 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5565 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5566 from an Org mode buffer to a Speedbar frame.
5567
54a1215b
EZ
5568 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5569 a composition, take its buffer position from IT->cmp_it.charpos.
5570 Fixes cursor positioning at the beginning of a line that begins
5571 with a composed character.
5572
9778ebcc
EZ
55732011-08-18 Eli Zaretskii <eliz@gnu.org>
5574
0be6ee06
EZ
5575 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5576 character bidirectional type, use STRONG_L instead. Fixes crashes
5577 in a buffer produced by `describe-categories'.
5578
9778ebcc
EZ
5579 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5580 members before the level stack, so they would be saved and
5581 restored when copying iterator state. Fixes incorrect reordering
5582 around TABs covered by display properties.
5583
156bffbe
AS
55842011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5585
6b02f655 5586 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5587
72ad093b
CY
55882011-08-17 Chong Yidong <cyd@stupidchicken.com>
5589
5590 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5591 (internal_condition_case_2, internal_condition_case_n):
5592 Remove unnecessary aborts (Bug#9081).
72ad093b 5593
35774242
EZ
55942011-08-17 Eli Zaretskii <eliz@gnu.org>
5595
5596 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5597 has no `load' handler, try opening the file locally. (Bug#9311)
5598
db76dd85
KB
55992011-08-16 Ken Brown <kbrown@cornell.edu>
5600
5601 * gmalloc.c: Expand comment.
5602
b215eee5
EZ
56032011-08-16 Eli Zaretskii <eliz@gnu.org>
5604
5605 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5606 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5607
a4579d33
KB
56082011-08-16 Ken Brown <kbrown@cornell.edu>
5609
5610 Fix memory allocation problems in Cygwin build (Bug#9273).
5611
5612 * unexcw.c ( __malloc_initialized): Declare external variable.
5613 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5614
8b76d6f8
SM
5615 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5616 New variables.
a4579d33
KB
5617 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5618 dumped emacs.
5619 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5620 in the static heap.
5621 [CYGWIN] (special_realloc): New function.
5622 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5623 requests to realloc storage in the static heap.
5624
3ebec551
PE
56252011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5626
5627 * bidi.c (bidi_initialize): Remove unused local.
5628
9fd8be00
EZ
56292011-08-15 Eli Zaretskii <eliz@gnu.org>
5630
6b02f655
SM
5631 * bidimirror.h:
5632 * biditype.h: Remove file.
5633 * makefile.w32-in ($(BLD)/bidi.$(O)):
5634 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
5635
5636 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5637
5638 * chartab.c: Improve commentary for the uniprop_table API.
5639
32413314
EZ
5640 * bidi.c (bidi_paragraph_init): Support zero value of
5641 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
5642 (bidi_initialize): Use uniprop_table instead of including
5643 biditype.h and bidimirror.h.
32413314 5644
9fd8be00
EZ
5645 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5646 coordinates of the iterator when restoring from ppos_it.
5647 (Bug#9296)
5648
5cf2b69b
KH
56492011-08-14 Kenichi Handa <handa@m17n.org>
5650
5651 * process.c (create_process): Call setup_process_coding_systems
72ad093b 5652 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 5653
daf17d00
EZ
56542011-08-14 Eli Zaretskii <eliz@gnu.org>
5655
5656 * xdisp.c (move_it_in_display_line_to): Don't invoke
5657 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5658 ppos_it. Fixes vertical cursor motion when line beginning is
5659 covered by an image. (Bug#9296)
5660
08e3161a
JD
56612011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5662
5663 * nsterm.h (ns_run_ascript): Declare.
5664 (NSAPP_DATA2_RUNASSCRIPT): Define.
5665
5666 * nsfns.m (as_script, as_result, as_status): New static variables.
5667 (ns_run_ascript): New function.
5e617bc2 5668 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
5669 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5670 the event loop. Get status from as_status (Bug#7276).
5671
5672 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5673 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5674 the event loop (Bug#7276).
5675
a3720aa2
AS
56762011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5677
5678 * gnutls.c (QCgnutls_bootprop_priority)
5679 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5680 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5681 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5682 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5683 (QCgnutls_bootprop_verify_hostname_error)
5684 (QCgnutls_bootprop_callbacks_verify): Rename from
5685 Qgnutls_bootprop_..., all uses changed.
5686
5687 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5688 uses changed.
5689
0a0d27fb
PE
56902011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5691
19d5c50c
PE
5692 * xfaces.c (Qframe_set_background_mode): Now static.
5693 * dispextern.h (Qframe_set_background_mode): Remove decl.
5694
0a0d27fb
PE
5695 * process.c (Fnetwork_interface_info): Declare local only if needed.
5696
377538cb
JD
56972011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5698
5699 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5700 (Fnetwork_interface_list): Allocate in increments of bytes instead
5701 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5702 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5703 sockaddr.
5704 (struct ifflag_def): notrailers is smart on OSX.
5705 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5706 Get hardware address with getifaddrs if available.
5707
08fff70c
EZ
57082011-08-12 Eli Zaretskii <eliz@gnu.org>
5709
5710 * xdisp.c (iterate_out_of_display_property): xassert that
5711 IT->position is set to within IT->object's boundaries. Break from
5712 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5713 when IT->position is set up wrongly due to some bug.
5714 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
5715 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5716 entry. Force push_it to save on the stack the current
5717 buffer/string position, to be restored by pop_it. Fix flags in
5718 the iterator structure wrt the object coming from a display
5719 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5720 properties. (Bug#9284)
5721
7be1c708 57222011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5723
7be1c708
CY
5724 * fontset.c (fontset_get_font_group): Add proper type checks.
5725 (Bug#9172)
aac0c6e3 5726
7be1c708 57272011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5728
7be1c708
CY
5729 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5730 and LC_VERSION_MIN_MACOSX.
5731 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5732 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5733
97bb72a6
EZ
57342011-08-08 Eli Zaretskii <eliz@gnu.org>
5735
5736 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5737 no-display-properties-and-no-overlays under bidi display.
5738 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5739 properties and overlays.
97bb72a6 5740
d5617611
CY
57412011-08-08 Chong Yidong <cyd@stupidchicken.com>
5742
37e11a63
CY
5743 * editfns.c (Fset_time_zone_rule): Document relationship with the
5744 setenv function.
5745
d5617611
CY
5746 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5747 the font entity extracted from the cache (Bug#8109).
5748
58872834
CY
57492011-08-07 Chong Yidong <cyd@stupidchicken.com>
5750
5751 * composite.c (autocmp_chars): Don't reset point. That is done by
5752 restore_point_unwind (Bug#5984).
5753
75bfc667
JL
57542011-08-07 Juri Linkov <juri@jurta.org>
5755
5756 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5757 to show the arg `TIME' instead of `TIMEVAL'.
5758
d1410150
EZ
57592011-08-06 Eli Zaretskii <eliz@gnu.org>
5760
5761 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5762 display property strides EOL and includes a newline, as in
5763 longlines-mode. (Bug#9254)
75b771e4
EZ
5764 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5765 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5766
5767 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5768 is non-zero, even if the data buffer is NULL. Fixes a crash in
5769 vertical-motion with longlines-mode. (Bug#9254)
5770
35928349
EZ
57712011-08-05 Eli Zaretskii <eliz@gnu.org>
5772
ec7cc85b
EZ
5773 * bidi.c <bidi_cache_total_alloc>: Now static.
5774 (bidi_initialize): Initialize bidi_cache_total_alloc.
5775
8b76d6f8 5776 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5777 cache. (Bug#9221)
5778
5779 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5780 amount allocated this far in `bidi_cache_total_alloc'.
5781 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5782 non-zero, only free the data buffer without restoring the cache
5783 contents. All callers changed.
5784
5785 * dispextern.h (bidi_unshelve_cache): Update prototype.
5786
5787 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5788 (move_it_in_display_line, move_it_to)
5789 (move_it_vertically_backward, move_it_by_lines): Replace the call
5790 to xfree to an equivalent call to bidi_unshelve_cache.
5791 (move_it_in_display_line_to): Fix logic of returning
412b6358 5792 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5793
e2e2423b
EZ
57942011-08-05 Eli Zaretskii <eliz@gnu.org>
5795
5796 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5797 came from a string character with a `cursor' property. (Bug#9229)
5798
ae9e757a
JD
57992011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5800
5801 * Makefile.in (LIB_PTHREAD): New variable.
5802 (LIBES): Add LIB_PTHREAD (Bug#9216).
5803
5804 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5805 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5806
213bd7f2
AS
58072011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5808
6b02f655 5809 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5810
99aaf75f
JD
58112011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5812
5813 * xterm.c (x_find_topmost_parent): New function.
5814 (x_set_frame_alpha): Find topmost parent window with
5815 x_find_topmost_parent and set the property there also (bug#9181).
5816 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5817
c74e9d86
PE
58182011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5819
5820 * callproc.c (Fcall_process): Avoid vfork clobbering
5821 the local vars buffer, coding_systems, current_dir.
5822
640c8776
SM
58232011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5824
5825 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5826
f26d0e4c
PE
58272011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5828
8a10d76c
PE
5829 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5830 so that it is not optimized away.
5831
f26d0e4c
PE
5832 * xdisp.c (compute_display_string_pos): Remove unused local.
5833
55439c61
EZ
58342011-08-02 Eli Zaretskii <eliz@gnu.org>
5835
5836 Fix slow cursor motion and scrolling in large buffers with
5837 selective display, like Org Mode buffers. (Bug#9218)
5838
5839 * dispextern.h (struct bidi_it): New member disp_prop_p.
5840
5841 * xdisp.c: Remove one-slot cache of display string positions.
5842 (compute_display_string_pos): Accept an additional argument
5e617bc2 5843 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5844 for a display string or property. If found, set DISP_PROP_P
5845 non-zero.
5846
5847 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5848 DISP_PROP_P, and pass it to compute_display_string_pos.
5849 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5850 non-zero. All callers of bidi_fetch_char changed.
5851
fb33fa43
SM
58522011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5853
5854 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5855
b099e063
DM
58562010-12-03 Don March <don@ohspite.net>
5857
5858 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5859 last character M-[char] is translated to ESC [char] (bug#7541).
5860
5cc7f7af
KH
58612011-08-02 Kenichi Handa <handa@m17n.org>
5862
d0fffa3f 5863 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5864
5865 * chartab.c (uniprop_table): Make it non-static.
5866
525d5e6e
EZ
58672011-08-01 Eli Zaretskii <eliz@gnu.org>
5868
5869 * xdisp.c (forward_to_next_line_start): Accept additional argument
5870 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5871 on the newline.
5872 (reseat_at_next_visible_line_start): Use the bidi iterator state
5873 returned by forward_to_next_line_start to restore the state of
5874 it->bidi_it after backing up to previous newline. (Bug#9212)
5875
31011111
AS
58762011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5877
5878 * regex.c (re_comp): Protoize.
5879 (re_exec): Fix return type.
5880 (regexec): Fix type of `ret'. (Bug#9203)
5881
476371c4
PE
58822011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5883
e5d76069
PE
5884 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5885 This is needed if max-image-size is a floating-point number.
5886
9a79b20c
AS
58872011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5888
5889 * print.c (print_object): Print empty symbol as ##.
5890
5891 * lread.c (read1): Read ## as empty symbol.
5892
d8c2fa78
AA
58932011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5894
5895 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5896 setting frame foreground color (Bug#9175).
5897 (x_set_background_color): Likewise.
5898
ffe57a7a
AA
5899 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5900 contents (Bug#9176).
5901 (EmacsTooltip -init): Remove bezels and add shadows to
5902 tooltip windows.
5903
bf3492a5
AA
5904 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5905 or scroll bar (Bug#8470).
5906
d55e9c53
AA
5907 * nsfont.m (nsfont_open): Remove assignment to voffset and
5908 unnecessary vars hshink, expand, hd, full_height, min_height.
5909 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5910
5911 * nsterm.h (nsfont_info): Remove voffset field.
5912
d8c2fa78 59132011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
5914
5915 Implement strike-through and overline on NextStep (Bug#8863).
5916
5917 * nsfont.m (nsfont_open): Use underline position provided by font,
5918 instead of hard-coded value of 2.
5919 (nsfont_draw): Call ns_draw_text_decoration instead.
5920
5921 * nsterm.h: Add declaration for ns_draw_text_decoration.
5922
5923 * nsterm.m (ns_draw_text_decoration): New function for drawing
5924 underline, overline, and strike-through.
5925 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5926 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 5927 accommodate underlining, etc.
4843aac3 5928
4cc60b9b
EZ
59292011-07-28 Eli Zaretskii <eliz@gnu.org>
5930
bc7ece87
EZ
5931 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5932 default.
4cc60b9b 5933
476371c4
PE
59342011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5935
66606eea
PE
5936 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5937 Without this fix, if a signal arrives just after memory fills up,
5938 'malloc' might be invoked reentrantly.
5939
476371c4
PE
5940 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5941 In other words, assume that every image size is allowed, on non-X
5942 hosts. This assumption is probably wrong, but it lets Emacs compile.
5943
f3fcc40d
AS
59442011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5945
5946 * regex.c (re_iswctype): Convert return values to boolean.
5947
350c992f
EZ
59482011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5949
5950 * xdisp.c (compute_display_string_pos): Don't use cached display
5951 string position if the buffer had its restriction changed.
5952 (Bug#9184)
5953
5266b4bb
PE
59542011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5955
5956 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5957
2573a837 59582011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 5959
41f55ccd 5960 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 5961
39e378da
PE
5962 * bidi.c: Integer size and overflow fixes.
5963 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5964 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5965 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5966 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5967 (bidi_find_other_level_edge):
5968 Use ptrdiff_t instead of EMACS_INT where either will do.
5969 This works better on 32-bit hosts configured --with-wide-int.
5970 (bidi_cache_ensure_space): Check for size-calculation overflow.
5971 Use % rather than repeated addition, for better worst-case speed.
5972 Don't set bidi_cache_size until after xrealloc returns, because it
5973 might not return.
5974 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
5975 (bidi_cache_ensure_space): Also check that the bidi cache size
5976 does not exceed that of the largest Lisp string or buffer. See Eli
5977 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 5978
5e927815
PE
5979 * alloc.c (__malloc_size_t): Remove.
5980 All uses replaced by size_t. See Andreas Schwab's note
5981 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5982
ca4aa935
PE
5983 * image.c: Improve checking for integer overflow.
5984 (check_image_size): Assume that f is nonnull, since
5985 it is always nonnull in practice. This is one less thing to
5986 worry about when checking for integer overflow later.
5987 (x_check_image_size): New function, which checks for integer
5988 overflow issues inside X.
5989 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5990 This removes the need for a memory_full check.
5991 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5992 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5993 (xbm_read_bitmap_data): Change locals back to 'int', since
5994 their values must fit in 'int'.
5995 (xpm_load_image, png_load, tiff_load):
5996 Invoke x_create_x_image_and_pixmap earlier,
5997 to avoid much needless work if the image is too large.
5998 (tiff_load): Treat overly large images as if
5999 x_create_x_image_and_pixmap failed, not as malloc failures.
6000 (gs_load): Use x_check_image_size.
6001
5f8f9cc2
PE
6002 * gtkutil.c: Omit integer casts.
6003 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6004 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6005
5adf60bc
PE
6006 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6007
c8907a93
PE
6008 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6009 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6010 would wrongly return t on a 64-bit host.
6011
e3c25c68
PE
6012 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6013 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6014 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6015 and therefore cause GCC to emit a bogus diagnostic in some cases.
6016
3f791afe
PE
6017 * image.c: Integer signedness and overflow and related fixes.
6018 This is not an exhaustive set of fixes, but it's time to
6019 record what I've got.
6020 (lookup_pixel_color, check_image_size): Remove redundant decls.
6021 (check_image_size): Don't assume that arbitrary EMACS_INT values
6022 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6023 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6024 (tiff_load, imagemagick_load_image):
6025 Check for overflow in size calculations.
6026 (x_create_x_image_and_pixmap): Remove unnecessary test for
6027 xmalloc returning NULL; that can't happen.
6028 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6029 (xpm_color_bucket): Use better integer hashing function.
6030 (xpm_cache_color): Don't possibly over-allocate memory.
6031 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6032 (gif_memory_source):
6033 Use ptrdiff_t, not int or size_t, to record sizes.
6034 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6035 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6036 either works, as we prefer signed integers.
6037 (tiff_read_from_memory, tiff_write_from_memory):
6038 Return tsize_t, not size_t, since that's what the TIFF API wants.
6039 (tiff_read_from_memory): Don't fail simply because the read would
6040 go past EOF; instead, return a short read.
6041 (tiff_load): Omit no-longer-needed casts.
6042 (Fimagemagick_types): Don't assume size fits into 'int'.
6043
3cc5a532
PE
6044 Improve hashing quality when configured --with-wide-int.
6045 * fns.c (hash_string): New function, taken from sxhash_string.
6046 Do not discard information about ASCII character case; this
6047 discarding is no longer needed.
6048 (sxhash-string): Use it. Change sig to match it. Caller changed.
6049 * lisp.h: Declare it.
6050 * lread.c (hash_string): Remove, since we now use fns.c's version.
6051 The fns.c version returns a wider integer if --with-wide-int is
6052 specified, so this should help the quality of the hashing a bit.
6053
b312a492
PE
6054 * emacs.c: Integer overflow minor fix.
6055 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6056 Define only if GNU_LINUX.
6057 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6058
dfd153ae
PE
6059 * dispnew.c: Integer signedness and overflow fixes.
6060 Remove unnecessary forward decls, that were a maintenance hassle.
6061 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6062 All uses changed.
6063 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6064 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6065 (prepare_desired_row, line_draw_cost):
6066 Use int, not unsigned, where either works.
6067 (save_current_matrix, restore_current_matrix):
6068 Use ptrdiff_t, not size_t, where either works.
6069 (init_display): Check for overflow more accurately, and without
6070 relying on undefined behavior.
6071
a81d11a3
PE
6072 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6073 Remove, replacing with the new symbols in lisp.h. All uses changed.
6074 * fileio.c (make_temp_name):
6075 * filelock.c (lock_file_1, lock_file):
6076 * xdisp.c (message_dolog):
6077 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6078 Use pMd etc. instead.
6079 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6080 replacing the pWIDE etc. symbols removed from editfns.c.
6081
3300e6fd
PE
6082 * keyboard.h (num_input_events): Now uintmax_t.
6083 This is (very slightly) less likely to mess up due to wraparound.
6084 All uses changed.
6085
fd05c7e9
PE
6086 * buffer.c: Integer signedness fixes.
6087 (alloc_buffer_text, enlarge_buffer_text):
6088 Use ptrdiff_t rather than size_t when either will do, as we prefer
6089 signed integers.
6090
903fe15d
PE
6091 * alloc.c: Integer signedness and overflow fixes.
6092 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6093 (__malloc_size_t): Default to size_t, not to int.
6094 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6095 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6096 Prefer ptrdiff_t to size_t when either would do, as we prefer
6097 signed integers.
6098 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6099 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6100 Now const. Initialize with values that are in range even if char
6101 is signed.
6102 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6103 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6104 These functions do the right thing with sizes > 2**32.
6105 (check_depth): Now ptrdiff_t, not int.
6106 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6107 Adjust to new way of storing sizes. Check for size overflow bugs
6108 in rest of code.
6109 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6110 slightly wrong anyway, as it missed one instance of
6111 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6112 (refill_memory_reserve): Omit needless cast to size_t.
6113 (mark_object_loop_halt): Mark as externally visible.
6114
ac82cc6a
PE
6115 * xselect.c: Integer signedness and overflow fixes.
6116 (Fx_register_dnd_atom, x_handle_dnd_message):
6117 Use ptrdiff_t, not size_t, since we prefer signed.
6118 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6119 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6120 x_dnd_atoms_size and x_dnd_atoms_length.
6121
c2d1e36d
PE
6122 * doprnt.c: Prefer signed to unsigned when either works.
6123 * eval.c (verror):
6124 * doprnt.c (doprnt):
6125 * lisp.h (doprnt):
6126 * xdisp.c (vmessage):
6127 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6128 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6129 prefer signed arithmetic to avoid comparison confusion.
6130 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6131 but is a bit tricky.
6132
0e926e56
PE
6133 Assume freestanding C89 headers, string.h, stdlib.h.
6134 * data.c, doprnt.c, floatfns.c, print.c:
6135 Include float.h unconditionally.
6136 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6137 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6138 * regex.c: Likewise for stddef.h, string.h.
6139 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6140 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6141 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6142 (STDC_HEADERS): Remove obsolete defines.
6143 * sysdep.c: Include limits.h unconditionally.
6144
9cfdb3ec
PE
6145 Assume support for memcmp, memcpy, memmove, memset.
6146 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6147 * regex.c (memcmp, memcpy):
6148 Remove; we assume C89 now.
6149
6150 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6151 (__malloc_safe_bcopy): Remove; no longer needed.
6152
cf950e6b 6153 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
6154 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6155 well either way, and we prefer signed to unsigned.
6156
dbf38e02
LMI
61572011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6158
6159 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6160 closes the connection while we're reading (bug#9182).
6161
d6f0886c 61622011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 6163
d6f0886c
JD
6164 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6165 are specified (Bug#9168).
24e0f6b1 6166
2eb1f9e6
PE
61672011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6168
6169 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6170 Found by GCC static checking and --with-wide-int on a 32-bit host.
6171
22381272 61722011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
6173
6174 * xdisp.c (compute_display_string_pos): Fix logic of caching
6175 previous display string position. Initialize cached_prev_pos to
6176 -1. Fixes slow-down at the beginning of a buffer.
6177
f25e39b4
EZ
61782011-07-24 Eli Zaretskii <eliz@gnu.org>
6179
6180 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6181 for attrs[LFACE_FONTSET_INDEX].
6182
04c4b52e
PE
61832011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6184
6185 * xml.c (parse_region): Remove unused local
6186 that was recently introduced.
6187
c1734fbd
EZ
61882011-07-23 Eli Zaretskii <eliz@gnu.org>
6189
be18c5a5
EZ
6190 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6191 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6192
c1734fbd
EZ
6193 * xdisp.c (move_it_in_display_line_to): Record the best matching
6194 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
6195 exit if none of the characters scanned was an exact match.
6196 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
6197 when exact match is impossible due to invisible text, and the
6198 lines are truncated.
6199
a258d627
JD
62002011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6201
6202 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6203 for OSX >= 10.7.
6204
b6d5a689
EZ
62052011-07-22 Eli Zaretskii <eliz@gnu.org>
6206
0f74f785
EZ
6207 Fix a significant slow-down of cursor motion with C-n, C-p,
6208 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6209 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 6210 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
6211 (next_element_from_buffer): Call compute_stop_pos_backwards to
6212 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
6213 base_level_stop.
6214 (reseat): Don't look for prev_stop, as that could mean a very long
6215 run.
6216 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6217 <cached_disp_overlay_modiff>: Cache for last found display string
6218 position.
551918c1 6219 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
6220 about the same buffer in the same area of character positions, and
6221 the buffer wasn't changed since the time the display string
6222 position was cached.
551918c1 6223
b2d0c91a
EZ
62242011-07-22 Eli Zaretskii <eliz@gnu.org>
6225
6226 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6227 is an integer, which is important for empty lines. (Bug#9149)
6228
043604ee
CY
62292011-07-22 Chong Yidong <cyd@stupidchicken.com>
6230
6231 * frame.c (Fmodify_frame_parameters): In tty case, update the
6232 default face if necessary (Bug#4238).
6233
da4adb04
CY
62342011-07-21 Chong Yidong <cyd@stupidchicken.com>
6235
6236 * editfns.c (Fstring_to_char): No need to explain what a character
6237 is in the docstring (Bug#6576).
6238
9abd0532
LMI
62392011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6240
6241 * xml.c (parse_region): Make sure we always return a tree.
6242
36881d16
HK
62432011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6244
6245 * xml.c (parse_region): If a document contains only comments,
6246 return that, too.
6247
1e98674d
LMI
62482011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6249
6250 * xml.c (make_dom): Return comments, too.
6251
590bd467
PE
62522011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6253
6254 Port to OpenBSD.
6255 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6256 and the surrounding thread.
6257 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6258 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6259 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6260 timer goes off.
6261 * s/openbsd.h (BROKEN_SIGIO): Define.
6262 * unexelf.c (unexec) [__OpenBSD__]:
6263 Don't update the .mdebug section of the Alpha COFF symbol table.
6264
f41628b2
LMI
62652011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6266
6267 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6268 (bug#8460).
6269
b59b67c5
PE
62702011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6271
15e3a074
PE
6272 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6273 This fixes some race conditions on the permissions of any newly
6274 created file.
6275
41bed37d
PE
6276 * alloc.c (valid_pointer_p): Use pipe, not open.
6277 This fixes some permissions issues when debugging.
6278
b59b67c5
PE
6279 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6280 If fchown fails to set both uid and gid, try to set just gid,
6281 as that is sometimes allowed. Adjust the file's mode to eliminate
6282 setuid or setgid bits that are inappropriate if fchown fails.
6283
925a6be7
SM
62842011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6285
6286 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6287 to compare Lisp_Objects.
6288 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6289 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6290 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6291
52968808
AS
62922011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6293
0a6a104b
AS
6294 * lread.c (read_integer): Unread even EOF character.
6295 (read1): Likewise. Properly record start position of symbol.
6296
52968808
AS
6297 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6298 symbol character follows.
6299
9e381cdd
PE
63002011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6301
6302 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6303 This works around a problem with the previous change to Fcopy_file.
6304 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6305 and without this change, GCC might complain about discarding
6306 fchown's return value.
6307
b5641435
JB
63082011-07-16 Juanma Barranquero <lekktu@gmail.com>
6309
6310 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6311
a8031457
PE
63122011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6313
6314 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6315
dd889327
LMI
63162011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6317
750c33f7
LMI
6318 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6319 it's used from the C level.
6320
dd889327
LMI
6321 * process.c: Use the same condition for POLL_FOR_INPUT in both
6322 keyboard.c and process.c (bug#1858).
6323
87e86684
LM
63242011-07-09 Lawrence Mitchell <wence@gmx.li>
6325
6326 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6327 (Fgnutls_boot): Use it.
6328
64348f40
AS
63292011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6330
6331 * doc.c (Fsubstitute_command_keys): Revert last change.
6332
1d698799
LMI
63332011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6334
f863868c
LMI
6335 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6336 quotes the next character, and doesn't affect other longer
6337 sequences (bug#8935).
6338
1d698799
LMI
6339 * lread.c (syms_of_lread): Clarify that is isn't only
6340 `eval-buffer' and `eval-defun' that's affected by
6341 `lexical-binding' (bug#8460).
6342
aa4b6df6
EZ
63432011-07-15 Eli Zaretskii <eliz@gnu.org>
6344
6345 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6346 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6347
5d856da6
PE
63482011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6349
ad6042bb
PE
6350 Fix minor problems found by static checking.
6351 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6352 (elsz): Now a signed constant, not a size_t var. We prefer signed
6353 types to unsigned, to avoid integer comparison confusion. Without
6354 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6355 "cannot optimize loop, the loop counter may overflow", a symptom
6356 of the confusion.
f00bbb22 6357 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6358 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6359
6468f31c
LMI
63602011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6361
49080b10
LMI
6362 * search.c (Fre_search_backward): Mention `case-fold-search' in
6363 all the re_search_* functions (bug#8138).
6364
6468f31c
LMI
6365 * keyboard.c (Fopen_dribble_file): Document when the file is
6366 closed (bug#8056).
6367
c965adc5
EZ
63682011-07-14 Eli Zaretskii <eliz@gnu.org>
6369
df9733bf
EZ
6370 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6371 bidi_cache_idx.
6372
0bb23927
EZ
6373 Support bidi reordering of display and overlay strings.
6374 * xdisp.c (compute_display_string_pos)
6375 (compute_display_string_end): Accept additional argument STRING.
6376 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6377 (reseat_to_string): Initialize bidi_it->string.s and
6378 bidi_it->string.schars.
6379 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6380 NULL (avoids a crash in bidi_paragraph_init).
6381 Initialize itb.string.lstring.
0bb23927
EZ
6382 (init_iterator): Call bidi_init_it only of a valid
6383 buffer position was specified. Initialize paragraph_embedding to
6384 L2R.
6385 (reseat_to_string): Initialize the bidi iterator.
6386 (display_string): If we need to ignore text properties of
6387 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6388 original value of -1 will not work with bidi.)
6389 (compute_display_string_pos): First arg is now struct
6390 `text_pos *'; all callers changed. Support display properties on
6391 Lisp strings.
6392 (compute_display_string_end): Support display properties on Lisp
6393 strings.
6394 (init_iterator, reseat_1, reseat_to_string): Initialize the
6395 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6396 when iterating on a string not from display properties).
640c8776
SM
6397 (compute_display_string_pos, compute_display_string_end):
6398 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6399 arrow keys.
6400 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6401 base_level_stop; instead, set base_level_stop to BEGV.
6402 Fixes crashes in vertical-motion.
0bb23927
EZ
6403 (next_element_from_buffer): Improve commentary for when
6404 the iterator is before prev_stop.
6405 (init_iterator): Initialize bidi_p from the default value of
6406 bidi-display-reordering, not from buffer-local value. Use the
6407 buffer-local value only if initializing for buffer iteration.
6408 (handle_invisible_prop): Support invisible properties on strings
6409 that are being bidi-reordered.
6410 (set_iterator_to_next): Support bidi reordering of C strings and
6411 Lisp strings.
6412 (next_element_from_string): Support bidi reordering of Lisp
6413 strings.
6414 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6415 (display_string): Support display of R2L glyph rows.
6416 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6417 (init_iterator): Don't initialize it->bidi_p for strings
6418 here.
6419 (reseat_to_string): Initialize it->bidi_p for strings here.
6420 (next_element_from_string, next_element_from_c_string)
6421 (next_element_from_buffer): Add xassert's for correspondence
6422 between IT's object being iterated and it->bidi_it.string
6423 structure.
6424 (face_before_or_after_it_pos): Support bidi iteration.
6425 (next_element_from_c_string): Handle the case of the first string
6426 character that is not the first one in the visual order.
6427 (get_visually_first_element): New function, refactored from common
6428 parts of next_element_from_buffer, next_element_from_string, and
6429 next_element_from_c_string.
6430 (tool_bar_lines_needed, redisplay_tool_bar)
6431 (display_menu_bar): Force left-to-right direction. Add a FIXME
6432 comment for making that be controlled by a user option.
6433 (push_it, pop_it): Save and restore the state of the
6434 bidi iterator. Save and restore the bidi_p flag.
6435 (pop_it): Iterate out of display property for string iteration as
6436 well.
6437 (iterate_out_of_display_property): Support iteration over strings.
6438 (handle_single_display_spec): Set up it->bidi_it for iteration
6439 over a display string, and call bidi_init_it.
6440 (handle_single_display_spec, next_overlay_string)
6441 (get_overlay_strings_1, push_display_prop): Set up the bidi
6442 iterator for displaying display or overlay strings.
6443 (forward_to_next_line_start): Don't use the shortcut if
6444 bidi-iterating.
6445 (back_to_previous_visible_line_start): If handle_display_prop
6446 pushed the iterator stack, restore the internal state of the bidi
6447 iterator by calling bidi_pop_it same number of times.
6448 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6449 and we are bidi-iterating, don't decrement the iterator position;
6450 instead, set the first_elt flag in the bidi iterator, to produce
6451 the same effect.
6452 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6453 (push_display_prop): xassert that we are iterating a buffer.
6454 (push_it, pop_it): Save and restore paragraph_embedding member.
6455 (handle_single_display_spec, next_overlay_string)
6456 (get_overlay_strings_1, reseat_1, reseat_to_string)
6457 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6458 correctly. Don't assume unibyte strings are not bidi-reordered.
6459 (compute_display_string_pos)
6460 (compute_display_string_end): Fix handling the case of C string.
6461 (push_it, pop_it): Save and restore from_disp_prop_p.
6462 (handle_single_display_spec, push_display_prop): Set the
6463 from_disp_prop_p flag.
6464 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6465 (pop_it): Call iterate_out_of_display_property only if we are
6466 popping after iteration over a string that came from a display
6467 property. Fix a typo in popping stretch info. Add an assertion
6468 for verifying that the iterator position is in sync with the bidi
6469 iterator.
6470 (handle_single_display_spec, get_overlay_strings_1)
6471 (push_display_prop): Fix initialization of paragraph direction for
6472 string when that of the parent object is not yet determined.
6473 (reseat_1): Call bidi_init_it to resync the bidi
6474 iterator with IT's position. (Bug#7616)
6475 (find_row_edges): If ROW->start.pos gives position
6476 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6477 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6478 Reset the from_disp_prop_p flag.
6479 (SAVE_IT, RESTORE_IT): New macros.
6480 (pos_visible_p, face_before_or_after_it_pos)
6481 (back_to_previous_visible_line_start)
6482 (move_it_in_display_line_to, move_it_in_display_line)
6483 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6484 (try_scrolling, redisplay_window, display_line): Use them when
6485 saving a temporary copy of the iterator and restoring it back.
6486 (back_to_previous_visible_line_start, reseat_1)
6487 (init_iterator): Empty the bidi cache "stack".
6488 (move_it_in_display_line_to): If iterator ended up at
6489 EOL, but we never saw any buffer positions smaller than
6490 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6491 motion in bidi-reordered lines.
6492 (move_it_in_display_line_to): Record prev_method and prev_pos
6493 immediately before the call to set_iterator_to_next. Fixes cursor
6494 motion in bidi-reordered lines with stretch glyphs and strings
6495 displayed in margins. (Bug#8133) (Bug#8867)
6496 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6497 TO_CHARPOS.
640c8776
SM
6498 (pos_visible_p): Support positions in bidi-reordered lines.
6499 Save and restore bidi cache.
0bb23927
EZ
6500
6501 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6502 (bidi_paragraph_info): Delete unused struct.
6503 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6504 (bidi_cache_start): New variable.
6505 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6506 to zero.
6507 (bidi_cache_fetch_state, bidi_cache_search)
6508 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6509 (bidi_cache_find, bidi_peek_at_next_level)
6510 (bidi_level_of_next_char, bidi_find_other_level_edge)
6511 (bidi_move_to_visually_next): Compare cache index with
6512 bidi_cache_start rather than with zero.
6513 (bidi_fetch_char): Accept new argument STRING; all callers
6514 changed. Support iteration over a string. Support strings with
6515 display properties. Support unibyte strings. Fix the type of
6516 `len' according to what STRING_CHAR_AND_LENGTH expects.
6517 (bidi_paragraph_init, bidi_resolve_explicit_1)
6518 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6519 (bidi_level_of_next_char, bidi_move_to_visually_next):
6520 Support iteration over a string.
0bb23927
EZ
6521 (bidi_set_sor_type, bidi_resolve_explicit_1)
6522 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6523 can now be zero (for strings); special values 0 and -1 were
6524 changed to -1 and -2, respectively.
6525 (bidi_char_at_pos): New function.
6526 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6527 Call it instead of FETCH_MULTIBYTE_CHAR.
6528 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6529 initialized to valid values.
6530 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6531 values.
6532 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6533 the test for valid cached positions. Fix the logic for looking up
6534 the sentinel state in the cache. GCPRO the Lisp string we are
6535 iterating.
6536 (bidi_push_it, bidi_pop_it): New functions.
6537 (bidi_initialize): Initialize the bidi cache start stack pointer.
6538 (bidi_cache_ensure_space): New function, refactored from part of
6539 bidi_cache_iterator_state. Don't assume the required size is just
6540 one BIDI_CACHE_CHUNK away.
6541 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6542 (bidi_count_bytes, bidi_char_at_pos): New functions.
6543 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6544 always valid if bidi_cache_idx is valid.
6545 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6546 is valid if it's going to be used.
6547 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6548 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6549 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6550 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6551 (bidi_find_other_level_edge, bidi_cache_start_stack):
6552 All variables related to cache indices are now EMACS_INT.
c965adc5 6553
0bb23927
EZ
6554 * dispextern.h (struct bidi_string_data): New structure.
6555 (struct bidi_it): New member `string'. Make flag members be 1-bit
6556 fields, and put them last in the struct.
640c8776
SM
6557 (compute_display_string_pos, compute_display_string_end):
6558 Update prototypes.
0bb23927
EZ
6559 (bidi_push_it, bidi_pop_it): Add prototypes.
6560 (struct iterator_stack_entry): New members bidi_p,
6561 paragraph_embedding, and from_disp_prop_p.
6562 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6563 (bidi_shelve_cache, bidi_unshelve_cache):
6564 Declare prototypes.
0bb23927
EZ
6565
6566 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6567 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6568 and vector-like objects.
6569
6570 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6571 cache around display iteration.
6572
6573 * window.c (Fwindow_end, window_scroll_pixel_based)
6574 (displayed_window_lines, Frecenter): Save and restore the bidi
6575 cache around display iteration.
6576
3bbd2265
LMI
65772011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6578
6579 * editfns.c (Fdelete_region): Clarify the use of the named
6580 parameters (bug#6788).
6581
adc47434
MR
65822011-07-14 Martin Rudalics <rudalics@gmx.at>
6583
6584 * indent.c (Fvertical_motion): Set and restore w->pointm when
6585 saving and restoring the window's buffer (Bug#9006).
6586
837c31f8
LMI
65872011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6588
6589 * editfns.c (Fstring_to_char): Clarify just what is returned
6590 (bug#6576). Text by Eli Zaretskii.
6591
ac389d0c
JB
65922011-07-13 Juanma Barranquero <lekktu@gmail.com>
6593
6594 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6595
0be0ce47
EZ
65962011-07-13 Eli Zaretskii <eliz@gnu.org>
6597
6598 * buffer.c (mmap_find): Fix a typo.
6599
cd18e7e3
JB
66002011-07-13 Johan Bockgård <bojohan@gnu.org>
6601
6602 Fix execution of x selection hooks.
6603 * xselect.c (Qx_lost_selection_functions)
6604 (Qx_sent_selection_functions): New vars.
6605 (syms_of_xselect): DEFSYM them.
6606 (x_handle_selection_request): Pass Qx_sent_selection_functions
6607 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6608 (x_handle_selection_clear,x_clear_frame_selections):
6609 Pass Qx_lost_selection_functions rather than
6610 Vx_lost_selection_functions to Frun_hook_with_args.
6611
47ea7f44
PE
66122011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6613
ac389d0c 6614 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
6615 The old code sometimes used this field without initializing it.
6616
47ea7f44
PE
6617 * alloc.c (gc_sweep): Don't read past end of array.
6618 In theory, the old code could also have corrupted Emacs internals,
6619 though it'd be very unlikely.
6620
bc985c87
AS
66212011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6622
6623 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 6624 argument. (Bug#4026)
bc985c87 6625
0cf34688
LMI
66262011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6627
b3dadd76
LMI
6628 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6629 key" (bug#4257).
6630
0cf34688
LMI
6631 * window.c (Fset_window_start): Doc fix (bug#4199).
6632 (Fset_window_hscroll): Ditto.
6633
270768cd
PE
66342011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6635
077e3dda 6636 Fix minor new problems caught by GCC 4.6.1.
270768cd 6637 * term.c (init_tty): Remove unused local.
490011a6 6638 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 6639 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 6640 not used otherwise.
270768cd 6641
b1f58454
CY
66422011-07-12 Chong Yidong <cyd@stupidchicken.com>
6643
6644 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6645
22b9578d
LMI
66462011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6647
6e70ab07
LMI
6648 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6649 are the mini-buffer and the echo area (bug#3320).
6650
22b9578d
LMI
6651 * term.c (init_tty): Remove support for supdup, c10 and perq
6652 terminals, which are no longer supported (bug#1482).
6653
8974cc9f
JB
66542011-07-10 Johan Bockgård <bojohan@gnu.org>
6655
6656 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6657
a560d974
JD
66582011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6659
6660 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6661 for non-popups (Bug#3642).
6662
1dae0f0a
AS
66632011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6664
268c2c36 6665 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 6666 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
6667 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6668 * cm.c (losecursor): Likewise.
1dae0f0a
AS
6669 * data.c (fmod): Likewise.
6670 * dispnew.c (swap_glyphs_in_rows): Likewise.
6671 * emacs.c (memory_warning_signal): Likewise.
6672 * floatfns.c (float_error): Likewise.
6673 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6674 (otf_open, font_otf_capability, generate_otf_features)
6675 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6676 Likewise.
6677 * image.c (pbm_read_file): Likewise.
6678 * indent.c (string_display_width): Likewise.
6679 * intervals.c (check_for_interval, search_for_interval)
6680 (inc_interval_count, count_intervals, root_interval)
6681 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6682 * lread.c (defalias): Likewise.
268c2c36 6683 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6684 * regex.c (set_image_of_range_1, set_image_of_range)
6685 (regex_grow_registers): Likewise.
6686 * sysdep.c (strerror): Likewise.
6687 * termcap.c (valid_filename_p, tprint, main): Likewise.
6688 * tparam.c (main): Likewise.
6689 * unexhp9k800.c (run_time_remap, save_data_space)
6690 (update_file_ptrs, read_header, write_header, calculate_checksum)
6691 (copy_file, copy_rest, display_header): Likewise.
6692 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6693 Likewise.
6694 * xdisp.c (check_it): Likewise.
6695 * xfaces.c (register_color, unregister_color, unregister_colors):
6696 Likewise.
6697 * xfns.c (print_fontset_result): Likewise.
6698 * xrdb.c (member, fatal, main): Likewise.
6699
99033785
PE
67002011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6701
6702 Fix minor problems found by static checking (Bug#9031).
6703 * chartab.c (char_table_set_range, map_sub_char_table):
6704 Remove unused locals.
6705 (uniprop_table): Now static.
6706 * composite.c (_work_char): Remove unused static var.
6707
9cb2ac56
JB
67082011-07-09 Juanma Barranquero <lekktu@gmail.com>
6709
6710 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6711
f25661f0
JD
67122011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6713
6714 * gtkutil.c (qttip_cb): Remove code without function.
6715
8278c4fe
EZ
67162011-07-09 Eli Zaretskii <eliz@gnu.org>
6717
6718 * w32.c (pthread_sigmask): New stub.
6719
1692ae2d 67202011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6721
8a6ebd58 6722 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6723 sigprocmask is portable only for single-threaded applications, and
6724 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6725 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6726 (LIBES): Use it.
6727 * callproc.c (Fcall_process):
6728 * process.c (create_process):
6729 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6730 Use pthread_sigmask, not sigprocmask.
123403e4 6731
1b854618
JD
67322011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6733
6734 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6735 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6736 wrong (Bug#8591).
6737
3fe4b549
JD
67382011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6739
0ce7e563
JD
6740 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6741 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6742 (xg_hide_tooltip): Fix comment.
6743
3fe4b549
JD
6744 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6745 in registerServicesMenuSendTypes.
6746 (validRequestorForSendType): Don't check ns_return_types.
6747
6748 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6749 ns_return_type.
6750
5df75e47
JR
67512011-07-08 Jason Rumney <jasonr@gnu.org>
6752
22610910
JR
6753 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6754 SH_SHOW for hidden windows (Bug#5482).
6755
5df75e47
JR
6756 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6757 frame struct members of non-existent frames (Bug#6284).
6758
699c10bd
JD
67592011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6760
4393663b
JD
6761 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6762 variable firstTime not needed on OSX >= 10.6.
6763 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6764 >= 10.5. Use setKnobProportion, setDoubleValue.
6765
6766 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6767 (MAC_OS_X_VERSION_10_5): Define if not defined.
6768 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6769 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6770 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6771
6772 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6773 cString and lossyCString on OSX >= 10.4
6774
58179cce 6775 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6776 sizeToFit on OSX >= 10.2.
6777
6778 * nsimage.m (allocInitFromFile): Don't use deprecated method
6779 bestRepresentationForDevice on OSX >= 10.6.
6780
6781 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6782 to avoid warning.
6783
6784 * emacs.c: Declare unexec_init_emacs_zone.
6785
a63e0781
JD
6786 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6787
699c10bd
JD
6788 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6789
6790 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6791 on svcsMenu (Bug#8842).
6792
6793 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6794 ns_return_types.
6795 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6796
6797 * nsterm.m (QUTF8_STRING): Declare.
6798 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6799 (validRequestorForSendType): Return type is (id).
6800 Change indexOfObjectIdenticalTo to indexOfObject.
6801 Check if we have local selection before returning self (Bug#8842).
6802 (writeSelectionToPasteboard): Put local selection into paste board
6803 if we have a local selection (Bug#8842).
6804 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6805
6806 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6807 (ns_get_local_selection): Declare.
6808
54e10184
LMI
68092011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6810
9888ff71
LMI
6811 * keymap.c (describe_map_tree): Don't insert a double newline at
6812 the end of the buffer (bug#1169) and return whether we inserted
6813 something.
6814
54e10184
LMI
6815 * callint.c (Fcall_interactively): Change "reading args" to
6816 "providing args" to try to clarify what it does (bug#1010).
6817
15fa4783
KH
68182011-07-07 Kenichi Handa <handa@m17n.org>
6819
6820 * composite.c (composition_compute_stop_pos): Ignore a static
6821 composition starting before CHARPOS (Bug#8915).
6822
6823 * xdisp.c (handle_composition_prop): Likewise.
6824
a8815b00
EZ
68252011-07-07 Eli Zaretskii <eliz@gnu.org>
6826
6827 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6828 (Bug#9015)
6829
ef7b981d 68302011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6831
6832 * character.h (unicode_category_t): New enum type.
6833
6834 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6835 (Qchar_code_property_table): New variable.
6836 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6837 (UNIPROP_COMPRESSED_FORM_P): New macros.
6838 (char_table_ascii): Uncompress the compressed values.
6839 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6840 Uncompress the compressed values.
ac389d0c 6841 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6842 (char_table_ref_and_range): Uncompress the compressed values.
6843 (sub_char_table_set): New arg is_uniprop. Callers changed.
6844 Uncompress the compressed values.
6845 (sub_char_table_set_range): Args changed. Callers changed.
6846 (char_table_set_range): Adjuted for the above change.
6847 (map_sub_char_table): Delete args default_val and parent. Add arg
6848 top. Give decoded values to a Lisp function.
640c8776 6849 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6850 values to a Lisp function. Gcpro more variables.
6851 (uniprop_table_uncompress)
6852 (uniprop_decode_value_run_length): New functions.
6853 (uniprop_decoder, uniprop_decoder_count): New variables.
6854 (uniprop_get_decoder, uniprop_encode_value_character)
6855 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6856 New functions.
6857 (uniprop_encoder, uniprop_encoder_count): New variables.
6858 (uniprop_get_encoder, uniprop_table)
6859 (Funicode_property_table_internal, Fget_unicode_property_internal)
6860 (Fput_unicode_property_internal): New functions.
6861 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6862 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6863 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6864 char-code-property-alist.
6865
640c8776 6866 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6867 Vunicode_category_table.
6868
640c8776 6869 * font.c (font_range): Adjust for the change of
c805dec0
KH
6870 Vunicode_category_table.
6871
76b397fb
DN
68722011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6873
6874 * m/iris4d.h: Remove file, move contents ...
6875 * s/irix6-5.h: ... here.
6876
22b4128e
PE
68772011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6878
6879 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6880 * alloc.c (mark_buffer):
6881 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6882 (clone_per_buffer_values): Don't assume that
22b4128e
PE
6883 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6884 This isn't true in general, and it's particularly not true
6885 if Emacs is configured with --with-wide-int.
6886 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6887 New macros, used in the buffer.c change.
6888
869795d6
JD
68892011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6890
6891 * xsettings.c: Use both GConf and GSettings if both are available.
6892 (store_config_changed_event): Add comment.
6893 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6894 (store_tool_bar_style_changed): New functions.
5e617bc2 6895 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
6896 (struct xsettings): Move font inside HAVE_XFT.
6897 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 6898 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 6899 Move inside HAVE_XFT.
640c8776 6900 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
6901 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6902 also.
6903 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 6904 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 6905 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
6906 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6907 (parse_settings): Move check for font inside HAVE_XFT.
6908 (read_settings, apply_xft_settings): Add comment.
6909 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6910 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6911 call store_font_name_changed.
6912 (xft_settings_event): Add comment.
6913 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6914 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6915 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6916 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6917 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
6918 (xsettings_get_system_font, xsettings_get_system_normal_font):
6919 Add comment.
869795d6 6920
d8ed26bd
PE
69212011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6922
6923 Random fixes. E.g., (random) never returned negative values.
6924 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6925 subseconds part to the entropy, as that's a bit more random.
6926 Prefer signed to unsigned, since the signedness doesn't matter and
6927 in general we prefer signed. When given a limit, use a
6928 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6929 latter isn't right if USE_2_TAGS_FOR_INTS.
6930 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6931 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6932
cabf1cac
SM
69332011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6934
6935 * textprop.c (text_property_stickiness):
6936 Obey Vtext_property_default_nonsticky.
6937 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6938 * w32fns.c (syms_of_w32fns):
6939 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6940
6e9b2be9
PE
69412011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6942
6943 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6944 This is more efficient than Ffile_directory_p and avoids a minor race.
6945
90186c68
LMI
69462011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6947
7c301272
LMI
6948 * buffer.c (Foverlay_put): Say what the return value is
6949 (bug#7835).
6950
c4f2d8d4
LMI
6951 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6952 is a directory before asking whether to use the file name
6953 (bug#7564).
ad637907
LMI
6954 (barf_or_query_if_file_exists): Make the "File is a directory"
6955 error be more correct.
c4f2d8d4 6956
90186c68
LMI
6957 * fns.c (Frequire): Remove the mention of the .gz files, since
6958 that's installation-specific, but keep the mention of
6959 `get-load-suffixes'.
6960
da64016e
PE
69612011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6962
6963 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6964 Report string overflow if the output is too long.
6965
7d47b580
JB
69662011-07-04 Juanma Barranquero <lekktu@gmail.com>
6967
a555cb87
JB
6968 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6969 (syms_of_gnutls): Remove duplicate DEFSYM for
6970 Qgnutls_bootprop_verify_hostname_error, an error for
6971 Qgnutls_bootprop_verify_error (which is no longer used).
6972
7d47b580
JB
6973 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6974 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6975 Also (re)move comments that are misplaced or no longer relevant.
6976
1e49bfab
LMI
69772011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6978
6979 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6980
1485f4c0
CY
69812011-07-03 Chong Yidong <cyd@stupidchicken.com>
6982
6983 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6984 and background color parameters if they have been changed.
6985
a9ab721e
LMI
69862011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6987
6988 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6989
cf7cff57
PE
69902011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6991
2e13213d
PE
6992 * xsettings.c (SYSTEM_FONT): Define only when used.
6993 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6994
cf7cff57
PE
6995 * keymap.c (access_keymap_1): Now static.
6996
7a8e04f7
CY
69972011-07-02 Chong Yidong <cyd@stupidchicken.com>
6998
6999 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7000 leave any prefix arg for the up event (Bug#1586).
7001
61352f62
LMI
70022011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7003
69bb1ef7
LMI
7004 * lread.c (syms_of_lread): Mention single symbols defined by
7005 `defvar' or `defconst' (bug#7154).
7006
61352f62 7007 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7008 (Frequire): Mention get-load-suffixes.
61352f62 7009
28545e04
MR
70102011-07-02 Martin Rudalics <rudalics@gmx.at>
7011
7012 * window.h (window): Remove clone_number slot.
7013 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7014 Remove.
7015 (make_parent_window, make_window, saved_window)
7016 (Fset_window_configuration, save_window_save): Don't deal with
7017 clone numbers.
7018 * buffer.c (Qclone_number): Remove declaration.
7019 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7020
3349e122
SM
70212011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7022
7023 Add multiple inheritance to keymaps.
7024 * keymap.c (Fmake_composed_keymap): New function.
7025 (Fset_keymap_parent): Simplify.
7026 (fix_submap_inheritance): Remove.
7027 (access_keymap_1): New function extracted from access_keymap to handle
7028 embedded parents and handle lists of maps.
7029 (access_keymap): Use it.
7030 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7031 (Fcopy_keymap): Handle embedded parents.
7032 (Fcommand_remapping, define_as_prefix): Simplify.
7033 (Fkey_binding): Simplify.
7034 (syms_of_keymap): Move minibuffer-local-completion-map,
7035 minibuffer-local-filename-completion-map,
7036 minibuffer-local-must-match-map, and
7037 minibuffer-local-filename-must-match-map to Elisp.
7038 (syms_of_keymap): Defsubr make-composed-keymap.
7039 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7040 (parse_menu_item): Trivial simplification.
7041
3279eb87
GM
70422011-07-01 Glenn Morris <rgm@gnu.org>
7043
7044 * Makefile.in (SETTINGS_LIBS): Fix typo.
7045
4550efdf
KI
70462011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7047
7048 * coding.c (Fencode_coding_string): Record the last coding system
7049 used, as the function doc string says (bug#8738).
7050
0949d2b6
JD
70512011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7052
7053 * xsettings.c (store_monospaced_changed): Take new font as arg and
7054 check for change against current_mono_font.
7055 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7056 (emacs_settings_constructor, emacs_settings_get_property)
7057 (emacs_settings_set_property, emacs_settings_class_init)
7058 (emacs_settings_init, gsettings_obj): Remove.
7059 (something_changedCB): New function for HAVE_GSETTINGS.
7060 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7061 with value as argument.
7062 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7063 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7064 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7065 "changed".
7066
7067 * xgselect.c: Add defined (HAVE_GSETTINGS).
7068 (xgselect_initialize): Ditto.
7069
7070 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7071 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7072 xg_select.
7073
bbc6b304
PE
70742011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7075
7076 * eval.c (struct backtrace): Simplify and port the data structure.
7077 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7078 signed bit field, as this assumption is not portable and it makes
7079 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7080 "char debug_on_exit : 1" as this is not portable either; instead,
7081 use the portable "unsigned int debug_on_exit : 1". Remove unused
7082 member evalargs. Remove obsolete comments about cc bombing out.
7083
9851bfc5
JD
70842011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7085
51bb811f 7086 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7087 Let HAVE_GSETTINGS override HAVE_GCONF.
7088 (store_monospaced_changed): New function.
7089 (EMACS_SETTINGS): A new type derived from GObject to handle
7090 GSettings notifications.
7091 (emacs_settings_constructor, emacs_settings_get_property)
7092 (emacs_settings_set_property, emacs_settings_class_init):
7093 New functions.
7094 (gsettings_client, gsettings_obj): New variables.
7095 (GSETTINGS_SCHEMA): New define.
7096 (something_changedCB): Call store_monospaced_changed.
7097 (init_gsettings): New function.
7098 (xsettings_initialize): Call init_gsettings.
7099 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7100 to NULL.
7101
640c8776 7102 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7103 GCONF_CFLAGS/LIBS.
7104
5386012d
MR
71052011-06-29 Martin Rudalics <rudalics@gmx.at>
7106
7107 * window.c (resize_root_window, grow_mini_window)
7108 (shrink_mini_window): Rename Qresize_root_window to
7109 Qwindow_resize_root_window and Qresize_root_window_vertically to
7110 Qwindow_resize_root_window_vertically.
7111
f13e0b08
PE
71122011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7113
7114 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7115
94515237
JB
71162011-06-27 Juanma Barranquero <lekktu@gmail.com>
7117
7118 * makefile.w32-in: Redesign dependencies so they reflect more
7119 clearly which files are directly included by each source file,
7120 and not through other includes.
7121
e43b6e43
MR
71222011-06-27 Martin Rudalics <rudalics@gmx.at>
7123
7124 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7125 (sort_overlays, overlay_strings): When an overlay's clone number
7126 matches the window's clone number process the overlay even if
7127 the overlay's window property doesn't match the current window.
7128
d68443dc
MR
7129 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7130 (Fwindow_hchild): Rename to Fwindow_left_child.
7131 (Fwindow_next): Rename to Fwindow_next_sibling.
7132 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7133 (resize_window_check): Rename to window_resize_check.
7134 (resize_window_apply): Rename to window_resize_apply.
7135 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7136 (Fdelete_other_windows_internal, resize_frame_windows)
7137 (Fsplit_window_internal, Fdelete_window_internal)
7138 (grow_mini_window, shrink_mini_window)
7139 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7140
c7e73be5
JD
71412011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7142
7143 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7144 (emacs_fixed_set_min_size): Remove.
7145 (emacs_fixed_new): Take frame as argument.
7146
7147 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7148 (_EmacsFixedPrivate): Remove minwidth/height.
7149 Add struct frame *f.
7150 (emacs_fixed_init): Initialize priv->f.
7151 (get_parent_class, emacs_fixed_set_min_size): Remove.
7152 (emacs_fixed_new): Set priv->f to argument.
7153 (emacs_fixed_get_preferred_width)
7154 (emacs_fixed_get_preferred_height): Use min_width/height from
7155 frames size_hint to set minimum and natural (Bug#8919).
7156 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7157 and use min_width/height from frames size_hint to set
7158 min_width/height (Bug#8919).
7159
7160 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
7161 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7162 Fix indentation.
c7e73be5 7163
cf99dcf8
EZ
71642011-06-26 Eli Zaretskii <eliz@gnu.org>
7165
7166 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7167 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7168 called at ZV.
7169
029529ac
CY
71702011-06-26 Chong Yidong <cyd@stupidchicken.com>
7171
7172 * process.c (wait_reading_process_output): Bypass select if
7173 waiting for a cell while ignoring keyboard input, and input is
7174 pending. Suggested by Jan Djärv (Bug#8869).
7175
7a7ef429
PE
71762011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7177
7178 Use gnulib's dup2 module instead of rolling our own.
7179 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7180
11fdef7d 71812011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7182
7183 * dispnew.c (scrolling_window): Before scrolling, turn off a
7184 mouse-highlight in the window being scrolled.
7185
cd3520a4
JB
71862011-06-24 Juanma Barranquero <lekktu@gmail.com>
7187
7188 Move DEFSYM to lisp.h and use everywhere.
7189
7190 * character.h (DEFSYM): Move declaration...
7191 * lisp.h (DEFSYM): ...here.
7192
7193 * gnutls.c:
7194 * minibuf.c:
7195 * w32menu.c:
7196 * w32proc.c:
7197 * w32select.c: Don't include character.h.
7198
7199 * alloc.c (syms_of_alloc):
7200 * buffer.c (syms_of_buffer):
7201 * bytecode.c (syms_of_bytecode):
7202 * callint.c (syms_of_callint):
7203 * casefiddle.c (syms_of_casefiddle):
7204 * casetab.c (init_casetab_once):
7205 * category.c (init_category_once, syms_of_category):
7206 * ccl.c (syms_of_ccl):
7207 * cmds.c (syms_of_cmds):
7208 * composite.c (syms_of_composite):
7209 * dbusbind.c (syms_of_dbusbind):
7210 * dired.c (syms_of_dired):
7211 * dispnew.c (syms_of_display):
7212 * doc.c (syms_of_doc):
7213 * editfns.c (syms_of_editfns):
7214 * emacs.c (syms_of_emacs):
7215 * eval.c (syms_of_eval):
7216 * fileio.c (syms_of_fileio):
7217 * fns.c (syms_of_fns):
7218 * frame.c (syms_of_frame):
7219 * fringe.c (syms_of_fringe):
7220 * insdel.c (syms_of_insdel):
7221 * keymap.c (syms_of_keymap):
7222 * lread.c (init_obarray, syms_of_lread):
7223 * macros.c (syms_of_macros):
7224 * msdos.c (syms_of_msdos):
7225 * print.c (syms_of_print):
7226 * process.c (syms_of_process):
7227 * search.c (syms_of_search):
7228 * sound.c (syms_of_sound):
7229 * syntax.c (init_syntax_once, syms_of_syntax):
7230 * terminal.c (syms_of_terminal):
7231 * textprop.c (syms_of_textprop):
7232 * undo.c (syms_of_undo):
7233 * w32.c (globals_of_w32):
7234 * window.c (syms_of_window):
7235 * xdisp.c (syms_of_xdisp):
7236 * xfaces.c (syms_of_xfaces):
7237 * xfns.c (syms_of_xfns):
7238 * xmenu.c (syms_of_xmenu):
7239 * xsettings.c (syms_of_xsettings):
7240 * xterm.c (syms_of_xterm): Use DEFSYM.
7241
4228cf16
TZ
72422011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7243
cd3520a4 7244 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7245
7fcccf1e
PE
72462011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7247
7efb4e0e
PE
7248 Integer and buffer overflow fixes (Bug#8873).
7249
ff5844ad
PE
7250 * print.c (printchar, strout): Check for string overflow.
7251 (PRINTPREPARE, printchar, strout):
7252 Don't set size unless allocation succeeds.
7253
90532f02
PE
7254 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7255 for sizes. Check for string overflow more accurately.
7256 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7257
6d84508d
PE
7258 * macros.c: Integer and buffer overflow fixes.
7259 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7260 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7261 Use ptrdiff_t, not int, for sizes.
7262 Don't increment bufsize until after realloc succeeds.
7263 Check for size-calculation overflow.
7264 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7265
437b2cb4
PE
7266 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7267
8b9ac8b4
PE
7268 * lread.c: Integer overflow fixes.
7269 (read_integer): Radix is now EMACS_INT, not int,
7270 to improve quality of diagnostics for out-of-range radices.
7271 Calculate buffer size correctly for out-of-range radices.
7272 (read1): Check for integer overflow in radices, and in
7273 read-circle numbers.
82cb60d3
PE
7274 (read_escape): Avoid int overflow.
7275 (Fload, openp, read_buffer_size, read1)
7276 (substitute_object_recurse, read_vector, read_list, map_obarray):
7277 Use ptrdiff_t, not int, for sizes.
7278 (read1): Use EMACS_INT, not int, for sizes.
20270765 7279 Check for size overflow.
8b9ac8b4 7280
7fcccf1e
PE
7281 * image.c (cache_image): Check for size arithmetic overflow.
7282
bfbbd7e7
PE
7283 * lread.c: Integer overflow issues.
7284 (saved_doc_string_size, saved_doc_string_length)
7285 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7286 Now ptrdiff_t, not int.
7287 (read1): Don't assume doc string length fits in int. Check for
7288 out-of-range doc string lengths.
7289 (read_list): Don't assume file position fits in int.
39019e54 7290 (read_escape): Check for hex character overflow.
bfbbd7e7 7291
4e323265
LL
72922011-06-22 Leo Liu <sdl.web@gmail.com>
7293
7294 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7295 Move to minibuffer.el.
7296
85fece3e
PE
72972011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7298
20b84ce9 7299 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7300 The following patches are for when GLYPH_DEBUG && !XASSERT.
7301 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7302 * dispnew.c (flush_stdout):
7303 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7304 Mark as externally visible.
7305 * dispnew.c (check_window_matrix_pointers): Now static.
7306 * dispnew.c (window_to_frame_vpos):
7307 * xfns.c (unwind_create_frame):
7308 * xterm.c (x_check_font): Remove unused local.
7309 * scroll.c (CHECK_BOUNDS):
7310 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7311 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7312 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7313 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7314 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7315 Now static.
7316 (debug_method_add): Use va_list and vsprintf rather than relying
7317 on undefined behavior with wrong number of arguments.
7318 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7319 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7320 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7321 since we're not interested in debugging glyphs with old libraries.
7322 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7323 GCC 4.6.0's static checking.
7324
0766b489
PE
73252011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7326
31fd4b32
PE
7327 Integer overflow and signedness fixes (Bug#8873).
7328 A few related buffer overrun fixes, too.
7329
b79e8648
PE
7330 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7331
0766b489
PE
7332 * dispextern.h (struct face.stipple):
7333 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7334 (x_bitmap_mask, x_allocate_bitmap_record)
7335 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7336 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7337 (x_create_bitmap_from_xpm_data):
7338 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7339 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7340 (.bitmaps_last):
7341 * xfaces.c (load_pixmap):
7342 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7343 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7344 (.bitmaps_last, struct x_output.icon_bitmap):
7345 Use ptrdiff_t, not int, for bitmap indexes.
7346 (x_allocate_bitmap_record): Check for size overflow.
7347 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7348
b081724f
PE
7349 Use ptrdiff_t, not int, for overlay counts.
7350 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7351 * editfns.c (overlays_around, get_pos_property):
7352 * textprop.c (get_char_property_and_overlay):
7353 * xdisp.c (next_overlay_change, note_mouse_highlight):
7354 * xfaces.c (face_at_buffer_position):
21514da7
PE
7355 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7356 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7357 (Fnext_overlay_change, Fprevious_overlay_change)
7358 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7359 Use ptrdiff_t, not int, for sizes.
21514da7 7360 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7361
3de73e5e
PE
7362 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7363
2606c57b
PE
7364 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7365 (x_session_initialize): Do not assume string length fits in int.
7366
aaafe47a
PE
7367 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7368 This is unlikely, but can occur if DPI is outlandish.
7369
2674ddc8 7370 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7371 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7372
28154962
PE
7373 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7374 * xrdb.c (magic_file_p, search_magic_path):
7375 Omit last arg SUFFIX; it was always 0. All callers changed.
7376 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7377
7de51af5
PE
7378 * xfont.c (xfont_match): Avoid need for strlen.
7379
25ed6cc3
PE
7380 * xfns.c: Don't assume strlen fits in int.
7381 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7382
4eab31dd
PE
7383 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7384 not unsigned long, as we prefer signed integers. All callers changed.
7385 Detect integer overflow in repeat count.
7386 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7387 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7388
171e2a58
PE
7389 * termcap.c: Don't assume sizes fit in int and never overflow.
7390 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7391 (gobble_line): Check for size-calculation overflow.
7392
ad39faca 7393 * minibuf.c (Fread_buffer):
6e5bb2dc 7394 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7395 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7396 Don't assume string length fits in int.
7397
52c61c22 7398 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7399 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7400
b5b8c9e5
PE
7401 * font.c: Don't assume string length fits in int.
7402 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7403 Use ptrdiff_t, not int.
ccd6111c
PE
7404 (font_intern_prop): Don't assume string length fits in int.
7405 Don't assume integer property fits in fixnum.
7406 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7407
882f0d81 7408 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7409 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7410 Reformulate so as not to need the command string.
7411 Invoke gzip -cd rather than gunzip, as it's more portable.
7412 (lock_info_type, lock_file_1, lock_file):
7413 Don't assume pid_t and time_t fit in unsigned long.
7414 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7415 (current_lock_owner): Prefer signed type for sizes.
7416 Use memcpy, not strncpy, where memcpy is what is really wanted.
7417 Don't assume (via atoi) that time_t and pid_t fit in int.
7418 Check for time_t and/or pid_t out of range, e.g., via a network share.
7419 Don't alloca where an auto var works fine.
7420
93f4cf88
PE
7421 * fileio.c: Fix some integer overflow issues.
7422 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7423 Don't assume string length fits in int.
7424 (directory_file_name): Don't assume string length fits in long.
7425 (make_temp_name): Don't assume pid fits in int, or that its print
7426 length is less than 20.
7427
f3e92b69
PE
7428 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7429
1bfdaf10
PE
7430 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7431
35016e9a
PE
7432 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7433
3d1e65a1
PE
7434 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7435 We prefer signed integers, even for size calculations.
7436
0b963a93
PE
7437 * emacs.c: Don't assume string length fits in 'int'.
7438 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7439 (main): Don't invoke strlen when not needed.
7440
573f4b54
PE
7441 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7442 (XD_DEBUG_MESSAGE): Don't waste a byte.
7443
989f33ba
PE
7444 * callproc.c (getenv_internal_1, getenv_internal)
7445 (Fgetenv_internal):
965d34eb
PE
7446 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7447
e4d29b33
PE
7448 * lread.c (invalid_syntax): Omit length argument.
7449 All uses changed. This doesn't fix a bug, but it simplifies the
7450 code away from its former Hollerith-constant appearance, and it's
7451 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7452 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7453
eb49b136
PE
7454 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7455 This didn't break anything, but it didn't help either.
7456 It's confusing to put a bogus integer in a place where the actual
7457 value does not matter.
9f62aeb1 7458 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7459 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7460
15375a22
PE
7461 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7462 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7463 implementation.
b61cc01c
PE
7464 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7465 We prefer signed types, and the value cannot exceed the EMACS_INT
7466 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
7467 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7468 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7469 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 7470
53b2623d
PE
7471 * indent.c (sane_tab_width): New function.
7472 (current_column, scan_for_column, Findent_to, position_indentation)
7473 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7474 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7475
51cab52b 7476 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7477
f2ed8a70
PE
7478 * lisp.h (lint_assume): New macro.
7479 * composite.c (composition_gstring_put_cache):
7480 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7481
abe80cc6
PE
7482 * editfns.c, insdel.c:
7483 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 7484
b02c740e
PE
7485 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7486
ebc96716
PE
7487 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7488
b4e50fa0 7489 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 7490 Use much-faster test for byte-length change.
311d5d7c 7491 Don't assume string byte-length fits in 'int'.
a4cf38e4 7492 Check that character arg fits in 'int'.
85461888 7493 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 7494
c0c1ee9f
PE
7495 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7496
a498d7f4
PE
7497 * fns.c (concat): Catch string overflow earlier.
7498 Do not rely on integer wraparound.
7499
51cab52b
PE
7500 * dispextern.h (struct it.overlay_strings_charpos)
7501 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
7502 * xdisp.c (forward_to_next_line_start)
7503 (back_to_previous_visible_line_start)
7504 (reseat_at_next_visible_line_start, next_element_from_buffer):
7505 Don't arbitrarily truncate the value of 'selective' to int.
7506
76031fad
PE
7507 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7508
5eb55db9
PE
7509 * composite.c: Don't truncate sizes to 'int'.
7510 (composition_gstring_p, composition_reseat_it)
7511 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7512 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7513 not EMACS_UINT, for indexes.
5eb55db9 7514
0703a717
PE
7515 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7516
d6202519
PE
7517 * buffer.c: Include <verify.h>.
7518 (struct sortvec.priority, struct sortstr.priority):
8961a454 7519 Now EMACS_INT, not int.
c20998a7 7520 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7521 (struct sortstr.size, record_overlay_string)
7522 (struct sortstrlist.size, struct sortlist.used):
7523 Don't truncate size to int.
7524 (record_overlay_string): Check for size-calculation overflow.
d6202519 7525 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7526
d5a19415
JM
75272011-06-22 Jim Meyering <meyering@redhat.com>
7528
029529ac 7529 Don't leak an XBM-image-sized buffer
d5a19415
JM
7530 * image.c (xbm_load): Free the image buffer after using it.
7531
a9041e6c
PE
75322011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7533
7534 Port to Sun C.
7535 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7536 that Sun C diagnosed.
7537 * fns.c (secure_hash): Fix pointer signedness issue.
7538 * intervals.c (static_offset_intervals): New function.
7539 (offset_intervals): Use it.
7540
7f3f739f
LL
75412011-06-21 Leo Liu <sdl.web@gmail.com>
7542
7543 * deps.mk (fns.o):
7544 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7545 sha512.h.
7546
7547 * fns.c (secure_hash): Rename from crypto_hash_function and change
7548 the first arg to accept symbols.
5b66d427 7549 (Fsecure_hash): New primitive.
7f3f739f
LL
7550 (syms_of_fns): New symbols.
7551
76147d94
DD
75522011-06-20 Deniz Dogan <deniz@dogan.se>
7553
7554 * process.c (Fset_process_buffer): Clarify return value in
7555 docstring.
7556
7d7d0045
CY
75572011-06-18 Chong Yidong <cyd@stupidchicken.com>
7558
7559 * dispnew.c (add_window_display_history): Use BVAR.
7560
7561 * xdisp.c (debug_method_add): Use BVAR.
7562 (check_window_end, dump_glyph_matrix, dump_glyph)
7563 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7564
7565 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7566 Likewise.
7567
7568 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7569 check till after the cache is created in init_frame_faces.
7570
ff2bc410
SM
75712011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7572
7573 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7574
28177add
PE
75752011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7576
dd3482fe
PE
7577 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7578 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7579 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7580
393d71f3 7581 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7582 * fileio.c (Finsert_file_contents):
7583 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7584 Remove the old (too-loose) buffer overflow checks.
7585 They weren't needed, since make_gap checks for buffer overflow.
7586 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7587 The old code merely checked for Emacs fixnum overflow, and relied
7588 on undefined (wraparound) behavior. The new code avoids undefined
7589 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7590
2e6813b0 7591 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7592 Tune. Don't use wider integers than needed. Don't use alloca.
7593 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7594
599a9e4f
PE
7595 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7596
99561444
PE
7597 * insdel.c, lisp.h (buffer_overflow): New function.
7598 (insert_from_buffer_1, replace_range, replace_range_2):
7599 * insdel.c (make_gap_larger):
7600 * editfns.c (Finsert_char):
7601 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7602
28177add
PE
7603 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7604
e69dafad
PE
76052011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7606
4baa020d 7607 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 7608
b1c46f02
PE
7609 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7610 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7611
e69dafad
PE
7612 * fileio.c: Don't assume EMACS_INT fits in off_t.
7613 (emacs_lseek): New static function.
7614 (Finsert_file_contents, Fwrite_region): Use it.
7615 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7616
566684ea
PE
7617 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7618
e6966cd6
PE
7619 * fns.c: Don't overflow int when computing a list length.
7620 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7621 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7622 truncation on 64-bit hosts. Check for QUIT every
7623 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7624 faster and is responsive enough.
7625 (Flength): Report an error instead of overflowing an integer.
7626 (Fsafe_length): Return a float if the value is not representable
7627 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 7628 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 7629 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 7630
dd0b0efb
PE
7631 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7632 (header_size, word_size): New constants.
7633 (allocate_vectorlike): Don't check size overflow here.
7634 (allocate_vector): Check it here instead, since this is the only
7635 caller of allocate_vectorlike that could cause overflow.
7636 Check that the new vector's length is representable as a fixnum.
7637
86fe5cfe
PE
7638 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7639 The previous code was bogus. For example, next_almost_prime (32)
7640 returned 39, which is undesirable as it is a multiple of 3; and
7641 next_almost_prime (24) returned 25, which is a multiple of 5 so
7642 why was the code bothering to check for multiples of 7?
7643
80e88859
PE
7644 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7645
4a2f0ad6
PE
7646 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7647
f66c7cf8
PE
7648 Variadic C functions now count arguments with ptrdiff_t.
7649 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7650 Back then I didn't know that the Emacs coding style prefers signed int.
7651 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
7652 were being counted with int, which may truncate counts on 64-bit
7653 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
7654 * lisp.h (struct Lisp_Subr.function.aMANY)
7655 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7656 Arg counts are now ptrdiff_t, not size_t.
7657 All variadic functions and their callers changed accordingly.
7658 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7659 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7660 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7661 * callint.c (Fcall_interactively): Check arg count for overflow,
7662 to avoid potential buffer overrun. Use signed char, not 'int',
7663 for 'varies' array, so that we needn't bother to check its size
7664 calculation for overflow.
7665 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7666 * eval.c (apply_lambda):
7667 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7668 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7669 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7670
a1759b76
PE
7671 * callint.c (Fcall_interactively): Don't use index var as event count.
7672
d96be9fc
PE
7673 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7674 * mem-limits.h (SIZE): Remove; no longer used.
7675
a690a978 7676 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 7677
578c21e6
PE
7678 Remove unnecessary casts.
7679 * xterm.c (x_term_init):
7680 * xfns.c (x_set_border_pixel):
7681 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7682 These aren't needed now that we assume ANSI C.
7683
96f53c6c
PE
7684 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7685 It's more likely to cause problems (due to unsigned overflow)
7686 than to cure them.
7687
83c77d31
PE
7688 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7689
ee2079f1
PE
7690 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7691
6da65536
PE
7692 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7693
7147c4a4
PE
7694 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7695
193e32d9
PE
7696 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7697
e5533da6
PE
7698 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7699
9910e595
PE
7700 GLYPH_CODE_FACE returns EMACS_INT, not int.
7701 * dispextern.h (merge_faces):
7702 * xfaces.c (merge_faces):
01103c44
PE
7703 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7704 Don't assume EMACS_INT fits in int.
9910e595 7705
2638320e
PE
7706 * character.h (CHAR_VALID_P): Remove unused parameter.
7707 * fontset.c, lisp.h, xdisp.c: All uses changed.
7708
045eb8d9
PE
7709 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7710
c1f134b5
PE
7711 * fns.c (concat): Minor tuning based on overflow analysis.
7712 This doesn't fix any bugs. Use int to hold character, instead
7713 of constantly refetching from Emacs object. Use XFASTINT, not
7714 XINT, for value known to be a character. Don't bother comparing
7715 a single byte to 0400, as it's always less.
7716
395fcb93 7717 * floatfns.c (Fexpt):
327eeec8
PE
7718 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7719
abbd3d23
PE
7720 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7721 for characters.
7722
684a03ef
PE
7723 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7724
0fed43f3
PE
7725 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7726 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7727 incorrectly succeed when S was a string, because 4294967386 was
7728 truncated before it was used.
7729
8fd02eb7
PE
7730 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7731 Otherwise, an out-of-range integer could cause undefined behavior
7732 on a 64-bit host.
7733
f8c86b69
PE
7734 * composite.c: Use int, not EMACS_INT, for characters.
7735 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7736 EMACS_INT, for values that are known to be in character range.
7737 This doesn't fix any bugs but is the usual style inside Emacs and
7738 may generate better code on 32-bit machines.
7739
34206dd2
PE
7740 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7741 This is for reasons similar to the recent CHAR_STRING fix.
7742 * charset.c (Fencode_char): Check that character arg is actually
7743 a character. Pass an int to ENCODE_CHAR.
7744 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7745 wider than 'int', as a compile-time check to prevent future regressions
7746 in this area.
7747
c5958d4c 7748 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7749
7750 Make sure a 64-bit char is never passed to CHAR_STRING.
7751 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7752 by silently ignoring the top 32 bits, allowing some values
7753 that were far too large to be valid characters.
7754 * character.h: Include <verify.h>.
7755 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7756 arguments are no wider than unsigned, as a compile-time check
7757 to prevent future regressions in this area.
7758 * data.c (Faset):
01103c44 7759 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7760 (Fsubst_char_in_region):
7761 * fns.c (concat):
7762 * xdisp.c (decode_mode_spec_coding):
7763 Adjust to CHAR_STRING's new requirement.
7764 * editfns.c (Finsert_char, Fsubst_char_in_region):
7765 * fns.c (concat): Check that character args are actually
7766 characters. Without this test, these functions did the wrong
7767 thing with wildly out-of-range values on 64-bit hosts.
7768
d37ca623
PE
7769 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7770 These casts should not be needed on 32-bit hosts, either.
7771 * keyboard.c (read_char):
7772 * lread.c (Fload): Remove casts to unsigned.
7773
ea204efb
PE
7774 * lisp.h (UNSIGNED_CMP): New macro.
7775 This fixes comparison bugs on 64-bit hosts.
7776 (ASCII_CHAR_P): Use it.
7777 * casefiddle.c (casify_object):
01103c44 7778 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7779 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7780 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7781 * dispextern.h (FACE_FROM_ID):
7782 * keyboard.c (read_char): Use UNSIGNED_CMP.
7783
41cb286c
PE
7784 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7785 not to EMACS_INT, to avoid GCC warning.
7786
4a1b9832
PE
7787 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7788
55daad71
PE
7789 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7790 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7791 isn't needed on 32-bit machines.
8f95c75c 7792
01103c44
PE
7793 * buffer.c (Fgenerate_new_buffer_name):
7794 Use EMACS_INT for count, not int.
0ceccced 7795 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7796
7797 * data.c (Qcompiled_function): Now static.
7798
c6f072e7
PE
7799 * window.c (window_body_lines): Now static.
7800
20ce5912
PE
7801 * image.c (gif_load): Rename local to avoid shadowing.
7802
9c4c5f81
PE
7803 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7804 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7805 * alloc.c (make_save_value): Integer argument is now of type
7806 ptrdiff_t, not int.
7807 (mark_object): Use ptrdiff_t, not int.
7808 * lisp.h (pD): New macro.
7809 * print.c (print_object): Use it.
7810
c0c5c8ae
PE
7811 * alloc.c: Use EMACS_INT, not int, to count objects.
7812 (total_conses, total_markers, total_symbols, total_vector_size)
7813 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7814 (total_free_floats, total_floats, total_free_intervals)
7815 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7816 Now EMACS_INT, not int. All uses changed.
7817 (Fgarbage_collect): Compute overall total using a double, so that
7818 integer overflow is less likely to be a problem. Check for overflow
7819 when converting back to an integer.
5a25e253
PE
7820 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7821 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7822 These were 'int' variables that could overflow on 64-bit hosts;
7823 they were never used, so remove them instead of repairing them.
211a0b2a 7824 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7825 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7826 Previously, this ceilinged at INT_MAX, but that doesn't work on
7827 64-bit machines.
e46bb31a 7828 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7829
c78baabf 7830 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7831 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7832 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7833 when a (possibly-narrower) signed value would do just as well.
7834 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7835
c9d624c6
PE
7836 * alloc.c: Catch some string size overflows that we were missing.
7837 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7838 for convenience in STRING_BYTES_MAX.
7839 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7840 The definition here is exact; the one in lisp.h was approximate.
7841 (allocate_string_data): Check for string overflow. This catches
7842 some instances we weren't catching before. Also, it catches
7843 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7844 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7845 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7846
c9d624c6
PE
7847 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7848 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7849 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7850
353032ce
PE
7851 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7852
2bccce07
PE
7853 * alloc.c (Fmake_string): Check for out-of-range init.
7854
0ac30604
SM
78552011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7856
7857 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7858
c195f2de
JD
78592011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7860
7861 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7862 xg_get_default_scrollbar_width.
7863
7864 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7865 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7866 (style_changed_cb): Call update_theme_scrollbar_width and call
7867 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7868 all frames (Bug#8505).
7869 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7870 Call gtk_window_set_resizable if HAVE_GTK3.
7871 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7872 and height if HAVE_GTK3 (Bug#8505).
7873 (scroll_bar_width_for_theme): New variable.
7874 (update_theme_scrollbar_width): New function.
7875 (xg_get_default_scrollbar_width): Move code to
7876 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7877 (xg_initialize): Call update_theme_scrollbar_width.
7878
7879 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7880
7881 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7882
e10ac9f1
MR
78832011-06-12 Martin Rudalics <rudalics@gmx.at>
7884
7885 * frame.c (make_frame): Call other_buffer_safely instead of
7886 other_buffer.
7887
7888 * window.c (temp_output_buffer_show): Call display_buffer with
7889 second argument Vtemp_buffer_show_specifiers and reset latter
7890 immediately after the call.
7891 (Vtemp_buffer_show_specifiers): New variable.
7892 (auto_window_vscroll_p, next_screen_context_lines)
7893 (Vscroll_preserve_screen_position): Remove leading asterisks from
7894 doc-strings.
7895
2d3c217e 78962011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 7897
7b7f97e8 7898 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
7899 * buffer.c (Qclone_number): Remove for now, as it's unused.
7900 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7901 (record_buffer): Remove unused local.
7902 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7903 (set_frame_buffer_list): Remove; unused.
7904 * frame.h (other_visible_frames): Remove decl.
7905 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7906 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7907 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7908 if HAVE_GPM.
7909 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7910 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7911 Define only if HAVE_GPM.
7912 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7913 (update_hints_inhibit): Remove; never set. All uses removed.
7914 * widgetprv.h (emacsFrameClassRec): Remove decl.
7915 * window.c (delete_deletable_window): Now returns void, since it
7916 wasn't returning anything.
7917 (compare_window_configurations): Remove unused locals.
7918 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7919 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
7920 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7921 the same widths as pointers. This follows up on the 2011-05-06 patch.
7922 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7923 * xterm.h: Likewise.
7924 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7925
1384b89e
JB
79262011-06-12 Juanma Barranquero <lekktu@gmail.com>
7927
7928 * makefile.w32-in: Update dependencies.
7929 (LISP_H): Add lib/intprops.h.
7930
1100a63c
CY
79312011-06-11 Chong Yidong <cyd@stupidchicken.com>
7932
7933 * image.c (gif_load): Add animation frame delay to the metadata.
7934 (syms_of_image): Use DEFSYM. New symbol `delay'.
7935
6198ccd0
MR
79362011-06-11 Martin Rudalics <rudalics@gmx.at>
7937
7938 * window.c (delete_deletable_window): Re-add.
7939 (Fset_window_configuration): Rewrite to handle dead buffers and
7940 consequently deletable windows.
7941 (window_tree, Fwindow_tree): Remove. Supply functionality in
7942 window.el.
7943 (compare_window_configurations): Simplify code.
7944
b6e3633c
AS
79452011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7946
1ab0dee5
AS
7947 * image.c (imagemagick_load_image): Fix type mismatch.
7948 (Fimagemagick_types): Likewise.
7949
b6e3633c
AS
7950 * window.h (replace_buffer_in_windows): Declare.
7951
9397e56f
MR
79522011-06-11 Martin Rudalics <rudalics@gmx.at>
7953
7954 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7955 Qclone_number. Remove external declaration of Qdelete_window.
7956 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7957 code.
640c8776
SM
7958 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7959 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
7960 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7961 buffer list implementation.
7962 (other_buffer_safely): New function.
7963 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7964 calls to replace_buffer_in_windows and
7965 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7966 if allowed.
7967 (record_buffer): Inhibit quitting and rewrite using quittable
7968 functions. Run Qbuffer_list_update_hook if allowed.
7969 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
7970 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7971 Move switch-to-buffer to window.el.
9397e56f
MR
7972 (bury-buffer): Move to window.el.
7973 (Vbuffer_list_update_hook): New variable.
7974
7975 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7976 section.
7977
7978 * window.h (resize_frame_windows): Move up in code.
7979 (Fwindow_frame): Remove EXFUN.
7980 (replace_buffer_in_all_windows): Remove prototype.
7981 (replace_buffer_in_windows_safely): Add prototype.
7982
7983 * window.c: Declare Qdelete_window static again. Move down
7984 declaration of select_count.
7985 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7986 (Fother_window): Move to window.el.
7987 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7988 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7989 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7990 window.el.
7991 (replace_buffer_in_windows): Implement by calling
7992 Qreplace_buffer_in_windows.
7993 (replace_buffer_in_all_windows): Remove with some functionality
7994 moved into replace_buffer_in_windows_safely.
7995 (replace_buffer_in_windows_safely): New function.
7996 (select_window_norecord, select_frame_norecord): Move in front
7997 of run_window_configuration_change_hook. Remove now obsolete
7998 declarations.
640c8776
SM
7999 (Fset_window_buffer): Rewrite doc-string.
8000 Call Qrecord_window_buffer.
9397e56f
MR
8001 (keys_of_window): Move binding for other-window to window.el.
8002
b50691aa
CY
80032011-06-11 Chong Yidong <cyd@stupidchicken.com>
8004
8005 * dispextern.h (struct image): Replace data member, whose int_val
8006 and ptr_val fields were not used by anything, with a single
8007 lisp_val object.
8008
8009 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8010 (gif_clear_image, gif_load, imagemagick_load_image)
8011 (gs_clear_image, gs_load): Callers changed.
8012
3f754b86
PE
80132011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8014
cca69397
PE
8015 * buffer.h: Include <time.h>, for time_t.
8016 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8017
109e28d0
PE
8018 Fix minor problems found by static checking.
8019
60737f02
PE
8020 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8021
4b66faf3
PE
8022 Make identifiers static if they are not used in other modules.
8023 * data.c (Qcompiled_function, Qframe, Qvector):
8024 * image.c (QimageMagick, Qsvg):
8025 * minibuf.c (Qmetadata):
8026 * window.c (resize_window_check, resize_root_window): Now static.
8027 * window.h (resize_window_check, resize_root_window): Remove decls.
8028
109e28d0
PE
8029 * window.c (window_deletion_count, delete_deletable_window):
8030 Remove; unused.
46a4ce9e
PE
8031 (window_body_lines): Now static.
8032 (Fdelete_other_windows_internal): Mark vars as initialized.
8033 Make sure 'resize_failed' is initialized.
8034 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8035 (resize_window_apply): Remove unused local.
8036 * window.h (delete_deletable_window): Remove decl.
8037
109e28d0 8038 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8039 (imagemagick_load_image): Fix pointer signedness problem by changing
8040 last arg from unsigned char * to char *. All uses changed.
8041 Also, fix a local for similar reasons.
8042 Remove unused locals. Remove locals to avoid shadowing.
8043 (fn_rsvg_handle_free): Remove; unused.
8044 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8045 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8046
3f754b86
PE
8047 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8048
2547adb1
CY
80492011-06-10 Chong Yidong <cyd@stupidchicken.com>
8050
8051 * image.c (gif_load): Fix omitted cast error introduced by
8052 2011-06-06 change.
8053
2c8e37d4
MR
80542011-06-10 Martin Rudalics <rudalics@gmx.at>
8055
8056 * window.h (resize_proportionally, orig_total_lines)
8057 (orig_top_line): Remove from window structure.
8058 (set_window_height, set_window_width, change_window_heights)
8059 (Fdelete_window): Remove prototypes.
8060 (resize_frame_windows): Remove duplicate declaration.
8061
440a42e3
EZ
80622011-06-10 Eli Zaretskii <eliz@gnu.org>
8063
8064 * window.h (resize_frame_windows, resize_window_check)
8065 (delete_deletable_window, resize_root_window)
8066 (resize_frame_windows): Declare prototypes.
8067
8068 * window.c (resize_window_apply): Make definition be "static" to
8069 match the prototype.
8070
562dd5e9
MR
80712011-06-10 Martin Rudalics <rudalics@gmx.at>
8072
8073 * window.c: Remove declarations of Qwindow_size_fixed,
8074 window_min_size_1, window_min_size_2, window_min_size,
8075 size_window, window_fixed_size_p, enlarge_window, delete_window.
8076 Remove static from declaration of Qdelete_window, it's
8077 temporarily needed by Fbury_buffer.
8078 (replace_window): Don't assign orig_top_line and
8079 orig_total_lines.
8080 (Fdelete_window, delete_window): Remove. Window deletion is
8081 handled by window.el.
640c8776
SM
8082 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8083 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8084 (Fdelete_other_windows): Remove. Deleting other windows is
8085 handled by window.el.
8086 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8087 handled in window.el.
8088 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8089 Window minimum sizes are handled in window.el.
8090 (shrink_windows, size_window, set_window_height)
8091 (set_window_width, change_window_heights, window_height)
8092 (window_width, CURBEG, CURSIZE, enlarge_window)
8093 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8094 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8095 handled in window.el.
8096 (make_dummy_parent): Rename to make_parent_window and give it a
8097 second argument horflag.
8098 (make_window): Don't set resize_proportionally any more.
8099 (Fsplit_window): Remove. Windows are split in window.el.
8100 (save_restore_action, save_restore_orig_size)
8101 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8102 Resize mini windows in window.el.
8103 (grow_mini_window, shrink_mini_window): Implement by calling
8104 Qresize_root_window_vertically, resize_window_check and
8105 resize_window_apply.
640c8776
SM
8106 (saved_window, Fset_window_configuration, save_window_save):
8107 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8108 resize_proportionally.
8109 (window_min_height, window_min_width): Move to window.el.
8110 (keys_of_window): Move bindings for delete-other-windows,
8111 split-window, delete-window and enlarge-window to window.el.
8112
8113 * buffer.c: Temporarily extern Qdelete_window.
8114 (Fbury_buffer): Temporarily call Qdelete_window instead of
8115 Fdelete_window (Fbury_buffer will move to window.el soon).
8116
8117 * frame.c (set_menu_bar_lines_1): Remove code handling
8118 orig_top_line and orig_total_lines.
8119
8120 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8121 set_window_height but set heights directly.
8122 (change_frame_size_1): Use resize_frame_windows.
8123
8124 * xdisp.c (init_xdisp): Don't use set_window_height but set
8125 heights directly.
8126
640c8776
SM
8127 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8128 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8129 run_window_configuration_change_hook.
8130
8131 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8132 instead of change_window_heights and run
8133 run_window_configuration_change_hook.
8134
1a13852e
MR
81352011-06-09 Martin Rudalics <rudalics@gmx.at>
8136
8137 * window.c (replace_window): Rename second argument REPLACEMENT to
8138 NEW. New third argument SETFLAG. Rewrite.
8139 (delete_window, make_dummy_parent): Call replace_window with
8140 third argument 1.
8141 (window_list_1): Move down in code.
8142 (run_window_configuration_change_hook): Move set_buffer part
8143 before select_frame_norecord part in order to unwind correctly.
8144 Rename count1 to count.
8145 (recombine_windows, delete_deletable_window, resize_root_window)
8146 (Fdelete_other_windows_internal)
8147 (Frun_window_configuration_change_hook, make_parent_window)
8148 (resize_window_check, resize_window_apply, Fresize_window_apply)
8149 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8150 (Fdelete_window_internal, Fresize_mini_window_internal):
8151 New functions.
1a13852e
MR
8152 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8153
f3d1777e
MR
81542011-06-08 Martin Rudalics <rudalics@gmx.at>
8155
496e208e
MR
8156 * window.h (window): Add some new members to window structure -
8157 normal_lines, normal_cols, new_total, new_normal, clone_number,
8158 splits, nest, prev_buffers, next_buffers.
8159 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 8160 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 8161
f3d1777e
MR
8162 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8163 Remove.
496e208e
MR
8164 (make_dummy_parent): Set new members of windows structure.
8165 (make_window): Move down in code. Handle new members of window
8166 structure.
8167 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8168 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8169 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8170 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
8171 (Fset_window_next_buffers, Fset_window_clone_number):
8172 New functions.
496e208e
MR
8173 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8174 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8175 Doc-string fixes.
8176 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8177 Argument WINDOW can be now internal window too.
8178 (Fwindow_use_time): Move up in code.
8179 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8180 Rewrite doc-string.
8181 (Fset_window_configuration, saved_window)
8182 (Fcurrent_window_configuration, save_window_save): Handle new
8183 members of window structure.
b9e809c2
MR
8184 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8185 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8186 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8187 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8188 Qget_mru_window, Qresize_root_window,
8189 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8190 Qauto_buffer_name; staticpro them.
f3d1777e 8191
abde8f8c
MR
81922011-06-07 Martin Rudalics <rudalics@gmx.at>
8193
8194 * window.c (Fwindow_total_size, Fwindow_left_column)
8195 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8196 (Fwindow_list_1): New functions.
8197 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
8198 (Fwindow_width, Fscroll_left, Fscroll_right):
8199 Use window_body_cols instead of window_box_text_cols.
8200 (delete_window, Fset_window_configuration):
8201 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
8202 (delete_all_subwindows): Take a window as argument and not a
8203 structure. Rewrite.
190b47e6
MR
8204 (window_loop): Remove handling of GET_LRU_WINDOW and
8205 GET_LARGEST_WINDOW.
8206 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
8207
8208 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
8209 window_box_text_cols. delete_all_subwindows now takes a
8210 Lisp_Object as argument.
abde8f8c 8211
640c8776
SM
8212 * indent.c (compute_motion, Fcompute_motion):
8213 Use window_body_cols instead of window_box_text_cols.
abde8f8c 8214
fa8a67e6
MR
8215 * frame.c (delete_frame): Call delete_all_subwindows with root
8216 window as argument.
8217
a54e3482
DC
82182011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8219
8220 * fns.c (Fputhash): Document return value.
8221
60002bf5
CY
82222011-06-06 Chong Yidong <cyd@stupidchicken.com>
8223
8224 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8225
0c671da6 82262011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8227
b862a52a 8228 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8229
be44ca6c
PE
8230 Check for overflow when converting integer to cons and back.
8231 * charset.c (Fdefine_charset_internal, Fdecode_char):
8232 Use cons_to_unsigned to catch overflow.
8233 (Fencode_char): Use INTEGER_TO_CONS.
8234 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8235 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8236 * data.c (long_to_cons, cons_to_long): Remove.
8237 (cons_to_unsigned, cons_to_signed): New functions.
8238 These signal an error for invalid or out-of-range values.
8239 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8240 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8241 * font.c (Ffont_variation_glyphs):
8242 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8243 * lisp.h: Include <intprops.h>.
8244 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8245 (cons_to_signed, cons_to_unsigned): New decls.
8246 (long_to_cons, cons_to_long): Remove decls.
8247 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8248 (Fprimitive_undo): Use CONS_TO_INTEGER.
8249 * xfns.c (Fx_window_property): Likewise.
8250 * xselect.c: Include <limits.h>.
8251 (x_own_selection, selection_data_to_lisp_data):
8252 Use INTEGER_TO_CONS.
8253 (x_handle_selection_request, x_handle_selection_clear)
8254 (x_get_foreign_selection, Fx_disown_selection_internal)
8255 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8256 (lisp_data_to_selection_data): Use cons_to_unsigned.
8257 (x_fill_property_data): Use cons_to_signed.
8258 Report values out of range.
8259
d1f3d2af
PE
8260 Check for buffer and string overflow more precisely.
8261 * buffer.h (BUF_BYTES_MAX): New macro.
8262 * lisp.h (STRING_BYTES_MAX): New macro.
8263 * alloc.c (Fmake_string):
8264 * character.c (string_escape_byte8):
8265 * coding.c (coding_alloc_by_realloc):
8266 * doprnt.c (doprnt):
8267 * editfns.c (Fformat):
8268 * eval.c (verror):
8269 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8270 since they may not be the same number.
8271 * editfns.c (Finsert_char):
8272 * fileio.c (Finsert_file_contents):
8273 Likewise for BUF_BYTES_MAX.
8274
dd52fcea
PE
8275 * image.c: Use ptrdiff_t, not int, for sizes.
8276 (slurp_file): Switch from int to ptrdiff_t.
8277 All uses changed.
8278 (slurp_file): Check that file size fits in both size_t (for
8279 malloc) and ptrdiff_t (for sanity and safety).
8280
7f9bbdbb
PE
8281 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8282 if b->modtime has its maximal value.
8283
dfe18f82
PE
8284 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8285
84acfcf0
PE
8286 Don't assume time_t can fit into int.
8287 * buffer.h (struct buffer.modtime): Now time_t, not int.
8288 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8289 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8290
ccd9a01a
PE
8291 Minor fixes for signed vs unsigned integers.
8292 * character.h (MAYBE_UNIFY_CHAR):
8293 * charset.c (maybe_unify_char):
8294 * keyboard.c (read_char, reorder_modifiers):
8295 XINT -> XFASTINT, since the integer must be nonnegative.
8296 * ftfont.c (ftfont_spec_pattern):
8297 * keymap.c (access_keymap, silly_event_symbol_error):
8298 XUINT -> XFASTINT, since the integer must be nonnegative.
8299 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8300 since it makes no difference and we prefer signed.
8301 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8302 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8303 nonnegative.
8304
d6d100dd
SM
83052011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8306
8307 * window.h (Fwindow_frame): Declare.
8308
2b6148e4
PE
83092011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8310
8311 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8312 (SPARE_MEMORY): Always define.
8313 (LARGE_REQUEST): Remove.
8314 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8315
f230ecc9
MR
83162011-06-06 Martin Rudalics <rudalics@gmx.at>
8317
727e958e
MR
8318 * lisp.h: Move EXFUNS for Fframe_root_window,
8319 Fframe_first_window and Fset_frame_selected_window to window.h.
8320
8321 * window.h: Move EXFUNS for Fframe_root_window,
8322 Fframe_first_window and Fset_frame_selected_window here from
8323 lisp.h.
8324
8325 * frame.c (Fwindow_frame, Fframe_first_window)
8326 (Fframe_root_window, Fframe_selected_window)
8327 (Fset_frame_selected_window): Move to window.c.
8328 (Factive_minibuffer_window): Move to minibuf.c.
8329 (Fother_visible_frames_p): New function.
8330
8331 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8332
f230ecc9
MR
8333 * window.c (decode_window, decode_any_window): Move up in code.
8334 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8335 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8336 (Fwindow_buffer): Move up and rewrite doc-string.
8337 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8338 (Fwindow_prev): New functions.
727e958e
MR
8339 (Fwindow_frame): Move here from frame.c. Accept any window as
8340 argument.
8341 (Fframe_root_window, Fframe_first_window)
8342 (Fframe_selected_window): Move here from frame.c. Accept frame
8343 or arbitrary window as argument. Update doc-strings.
8344 (Fminibuffer_window): Move up in code.
8345 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8346 (Fset_frame_selected_window): Move here from frame.c.
8347 Marginal rewrite.
727e958e
MR
8348 (Fselected_window, select_window, Fselect_window): Move up in
8349 code. Minor doc-string fixes.
f230ecc9 8350
4d09bcf6
PE
83512011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8352
8353 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8354 Do not assume that spare memory exists; that assumption is valid
8355 only if SYSTEM_MALLOC.
8356 (LARGE_REQUEST): New macro, so that the issue of large requests
8357 is separated from the issue of spare memory.
8358
810928a2
AS
83592011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8360
172418ad
AS
8361 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8362 format. (Bug#8806)
8363
43f862f7
AS
8364 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8365
810928a2
AS
8366 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8367 before statements.
8368
a059fe24
JD
83692011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8370
8371 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8372
8373 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8374
8375 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8376 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8377
989bf368
JB
83782011-06-05 Juanma Barranquero <lekktu@gmail.com>
8379
8380 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8381
4b80f674
CY
83822011-06-04 Chong Yidong <cyd@stupidchicken.com>
8383
8384 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8385 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8386 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8387 New error handlers.
4b80f674
CY
8388 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8389 Obey Vx_select_enable_clipboard_manager. Catch errors in
8390 x_clipboard_manager_save (Bug#8779).
8391 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8392 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8393
99a33b77 83942011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8395
8396 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8397
99a33b77 83982011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8399
8400 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8401 in the current matrix if keep_current_p is non-zero.
8402
8264569d
EZ
84032011-06-04 Eli Zaretskii <eliz@gnu.org>
8404
8405 * bidi.c (bidi_level_of_next_char): Fix last change.
8406
57f97249
EZ
84072011-06-03 Eli Zaretskii <eliz@gnu.org>
8408
fec2107c 8409 Support bidi reordering of text covered by display properties.
57f97249 8410
fec2107c
EZ
8411 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8412 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8413 (bidi_cache_search, bidi_cache_iterator_state)
8414 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8415 (bidi_level_of_next_char, bidi_move_to_visually_next):
8416 Support character positions inside a run of characters covered by a
fec2107c
EZ
8417 display string.
8418 (bidi_paragraph_init, bidi_resolve_explicit_1)
8419 (bidi_level_of_next_char): Call bidi_fetch_char and
8420 bidi_fetch_char_advance instead of FETCH_CHAR and
8421 FETCH_CHAR_ADVANCE.
8422 (bidi_init_it): Initialize new members.
8423 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8424 definitions.
8425 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8426 instead of using explicit *_CHAR codes.
d6d100dd
SM
8427 (bidi_resolve_explicit, bidi_resolve_weak):
8428 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8429 bidirectional text is supported only in multibyte buffers.
8430 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8431 it to initialize the frame_window_p member of struct bidi_it.
8432 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8433 (bidi_resolve_explicit, bidi_resolve_weak)
8434 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8435 bidi_it->nchars is non-positive.
8436 (bidi_level_of_next_char): Don't try to lookup the cache for the
8437 next/previous character if nothing is cached there yet, or if we
8438 were just reseat()'ed to a new position.
c40e2fb2 8439
0e14fe90
EZ
8440 * xdisp.c (set_cursor_from_row): Set start and stop points
8441 according to the row's direction when priming the loop that looks
8442 for the glyph on which to display cursor.
8443 (single_display_spec_intangible_p): Function deleted.
8444 (display_prop_intangible_p): Reimplement to call
8445 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8446 Accept 3 additional arguments needed by handle_display_spec.
8447 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8448 values: lists, `(when COND...)' forms, etc.
8449 (single_display_spec_string_p): Support property values that are
8450 lists with the argument STRING its top-level element.
8451 (display_prop_string_p): Fix the condition for processing a
8452 property that is a list to be consistent with handle_display_spec.
fec2107c 8453 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8454 last portion of handle_display_prop.
8455 (compute_display_string_pos): Accept additional argument
8456 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8457 value of a `display' property is a "replacing spec".
8458 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8459 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8460 the display property, but just return a value indicating whether
8461 the display property will replace the characters it covers.
8462 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8463 frame_window_p members of struct bidi_it.
d6d100dd
SM
8464 (compute_display_string_pos, compute_display_string_end):
8465 New functions.
fec2107c
EZ
8466 (push_it): Accept second argument POSITION, where pop_it should
8467 jump to continue iteration.
8468 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 8469
fec2107c
EZ
8470 * keyboard.c (adjust_point_for_property): Adjust the call to
8471 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8472
8473 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8474 (bidi_init_it): Update prototypes.
8475 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8476 (compute_display_string_pos, compute_display_string_end):
8477 Declare prototypes.
fec2107c
EZ
8478 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8479 EMACS_INT.
fc6f18ce 8480
40087514 84812011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 8482
57f53182
PE
8483 Malloc failure behavior now depends on size of allocation.
8484 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8485 * lisp.h: Change signatures accordingly.
8486 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8487 All callers changed. (Bug#8762)
8488
8489 * gnutls.c: Use Emacs's memory allocators.
8490 Without this change, the gnutls library would invoke malloc etc.
8491 directly, which causes problems on non-SYNC_INPUT hosts, and which
8492 runs afoul of improving memory_full behavior. (Bug#8761)
8493 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8494 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8495 xfree instead of the default malloc, realloc, free.
8496 (Fgnutls_boot): No need to check for memory allocation failure,
8497 since xmalloc does that for us.
8498
ac32cd99 8499 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
8500 * category.c (hash_get_category_set):
8501 * ccl.c (ccl_driver):
8502 * charset.c (Fdefine_charset_internal):
8503 * charset.h (struct charset.hash_index):
8504 * composite.c (get_composition_id, gstring_lookup_cache)
8505 (composition_gstring_put_cache):
8506 * composite.h (struct composition.hash_index):
8507 * dispextern.h (struct image.hash):
8508 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8509 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8510 (hashfn_equal, hashfn_user_defined, make_hash_table)
8511 (maybe_resize_hash_table, hash_lookup, hash_put)
8512 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8513 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8514 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8515 * image.c (make_image, search_image_cache, lookup_image)
8516 (xpm_put_color_table_h):
8517 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8518 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8519 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8520 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8521 * alloc.c (allocate_vectorlike):
8522 Check for overflow in vector size calculations.
8523 * ccl.c (ccl_driver):
8524 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8525 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8526 need to be updated by these changes.
40087514
PE
8527 * fns.c (make_hash_table, maybe_resize_hash_table):
8528 Check for integer overflow with large hash tables.
0de4bb68
PE
8529 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8530 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8531 (SXHASH_REDUCE): New macro.
8532 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8533 Use it instead of discarding useful hash info with large hash values.
8534 (sxhash_float): New function.
8535 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8536 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8537 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8538 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8539 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8540 Adjust signatures to match updated version of code.
8541 (consing_since_gc): Now EMACS_INT, since a single hash table can
8542 use more than INT_MAX bytes.
8543
698d32e2
DN
85442011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8545
8546 Make it possible to build with GCC-4.6+ -O2 -flto.
8547
8548 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8549
fd6fa53f
SM
85502011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8551
8552 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8553 Call minibuffer-inactive-mode.
8554
864db017
JB
85552011-05-31 Juanma Barranquero <lekktu@gmail.com>
8556
8557 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8558 Update dependencies.
8559
2ad0baf4
DN
85602011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8561
8562 * data.c (init_data): Remove code for UTS, this system is not
8563 supported anymore.
8564
4fcc2638
DN
85652011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8566
8567 Don't force ./temacs to start in terminal mode.
8568
8569 * frame.c (make_initial_frame): Initialize faces in all cases, not
8570 only when CANNOT_DUMP is defined.
8571 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8572
c56e0fd5
DN
85732011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8574
8575 * dispnew.c (add_window_display_history): Use const for the string
8576 pointer. Remove declaration, not needed.
8577
333d54da 85782011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8579
55d4c1b2 8580 Use 'inline', not 'INLINE'.
333d54da 8581 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8582 * alloc.c, fontset.c (INLINE): Remove.
8583 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8584 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8585 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8586 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8587 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8588
738db178
DN
85892011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8590
8591 Make it possible to run ./temacs.
8592
8593 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8594 syms_of_callproc does the same thing. Remove test for
8595 "initialized", do it in the caller.
8596 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8597
620c53a6
SM
85982011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8599
8600 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8601 (read_minibuf): Use get_minibuffer.
8602 (syms_of_minibuf): Use DEFSYM.
8603 (Qmetadata): New var.
8604 * data.c (Qbuffer): Don't make it static.
8605 (syms_of_data): Use DEFSYM.
8606
e003a292
PE
86072011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8608
8609 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8610 (CCL_CODE_MIN): New macro.
8611
ed008a6d
PE
86122011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8613
3687c2ef
PE
8614 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8615
ed008a6d
PE
8616 * eval.c (Qdebug): Now static.
8617 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8618 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8619 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8620
d66c4c7c
CY
86212011-05-29 Chong Yidong <cyd@stupidchicken.com>
8622
8623 * image.c: Various fixes to ImageMagick code comments.
8624 (Fimagemagick_types): Doc fix.
8625
5fbc2025
PE
86262011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8627
0196f88a
PE
8628 Minor fixes prompted by GCC 4.6.0 warnings.
8629
8630 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8631
5fbc2025
PE
8632 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8633 (x_clipboard_manager_save_all): Move extern decl to ...
8634 * xterm.h: ... here, so that it can be checked for consistency.
8635
1dd3c2d9
CY
86362011-05-29 Chong Yidong <cyd@stupidchicken.com>
8637
8638 * xselect.c (x_clipboard_manager_save_frame)
8639 (x_clipboard_manager_save_all): New functions.
8640 (Fx_clipboard_manager_save): Lisp function deleted.
8641
8642 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8643 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8644
8645 * xterm.h: Update prototype.
8646
5ba6571d
WX
86472011-05-28 William Xu <william.xwl@gmail.com>
8648
8649 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8650 exiting (Bug#8239).
8651
3eaff834
JM
86522011-05-28 Jim Meyering <meyering@redhat.com>
8653
e1900994 8654 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
8655 * fns.c (to_uchar): Define.
8656 (crypto_hash_function): Use it to convert some newly-signed
8657 variables to unsigned, to avoid sign-extension bugs. For example,
8658 without this change, (md5 "truc") would evaluate to
8659 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8660 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 8661 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 8662
0f6990a7
PE
86632011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8664
8665 Integer overflow fixes.
c8a9ca5a 8666
08686060
PE
8667 * dbusbind.c: Serial number integer overflow fixes.
8668 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
8669 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8670 to hold a serial number that is too large for a fixnum.
8671 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8672 Check for serial numbers out of range. Decode any serial number
59568bf0 8673 that was so large that it became a float. (Bug#8722)
08686060 8674
2d1fc3c7
PE
8675 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8676 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8677 Use XFASTINT rather than XUINT when numbers are nonnegative.
8678 (xd_append_arg, Fdbus_method_return_internal):
8679 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8680 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8681 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8682 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8683 (Bug#8722)
2d1fc3c7 8684
c8a9ca5a
PE
8685 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8686
519e1d69
PE
8687 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8688
6df6ae42 8689 ccl: Add integer overflow checks.
30569699
PE
8690 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8691 (IN_INT_RANGE): New macros.
8692 (ccl_driver): Use them to check for integer overflow when
8693 decoding a CCL program. Many of the new checks are whether XINT (x)
8694 fits in int; it doesn't always, on 64-bit hosts. The new version
8695 doesn't catch all possible integer overflows, but it's an
847044ea 8696 improvement. (Bug#8719)
30569699 8697
c11285dc
PE
8698 * alloc.c (make_event_array): Use XINT, not XUINT.
8699 There's no need for unsigned here.
8700
fdccd48e
PE
8701 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8702 This follows up to the 2011-05-06 change that substituted uintptr_t
8703 for EMACS_INT. This case wasn't caught back then.
8704
37910ab2
PE
8705 Rework Fformat to avoid integer overflow issues.
8706 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8707 now (part of C89). Include <verify.h>.
8708 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8709 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8710 (Fformat): Avoid the prepass trying to compute sizes; it was only
8711 approximate and thus did not catch overflow reliably. Instead, walk
8712 through the format just once, formatting and computing sizes as we go,
8713 checking for integer overflow at every step, and allocating a larger
8714 buffer as needed. Keep track separately whether the format is
8715 multibyte. Keep only the most-recently calculated precision, rather
8716 than them all. Record whether each argument has been converted to
8717 string. Use EMACS_INT, not int, for byte and char and arg counts.
8718 Support field widths and precisions larger than INT_MAX. Avoid
8719 sprintf's undefined behavior with conversion specifications such as %#d
8720 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8721 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8722 formatting out-of-range floating point numbers with int
9173deec 8723 formats. (Bug#8668)
37910ab2 8724
2e6578fb
PE
8725 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8726
0ae6bdee
PE
8727 * data.c: Avoid integer truncation in expressions involving floats.
8728 * data.c: Include <intprops.h>.
8729 (arith_driver): When there's an integer overflow in an expression
8730 involving floating point, convert the integers to floating point
8731 so that the resulting value does not suffer from catastrophic
8732 integer truncation. For example, on a 64-bit host (* 4
8733 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8734 Do not rely on undefined behavior after integer overflow.
8735
de883a70
PE
8736 merge count_size_as_multibyte, parse_str_to_multibyte
8737 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8738 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8739 Check for integer overflow.
8740 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8741 since it's now a duplicate of the other. This is more of
8742 a character than a buffer op, so better that it's in character.c.
8743 * fns.c, print.c: Adjust to above changes.
8744
2ff916cb
PE
87452011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8746
8747 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8748
f1b54466
PE
87492011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8750
fb1ac845
PE
8751 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8752 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8753 (x_clipboard_manager_save): Now static.
8754 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8755
f1b54466
PE
8756 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8757 (crypto_hash_function): Now static.
8758 Fix pointer signedness problems. Avoid unnecessary initializations.
8759
a9f737ee
CY
87602011-05-27 Chong Yidong <cyd@stupidchicken.com>
8761
8762 * termhooks.h (Vselection_alist): Make it terminal-local.
8763
8764 * terminal.c (create_terminal): Initialize it.
8765
8766 * xselect.c: Support for clipboard managers.
8767 (Vselection_alist): Move to termhooks.h as terminal-local var.
8768 (LOCAL_SELECTION): New macro.
8769 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8770 (symbol_to_x_atom): Remove gratuitous arg.
8771 (x_handle_selection_request, lisp_data_to_selection_data)
8772 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8773 (x_own_selection, x_get_local_selection, x_convert_selection):
8774 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8775 (some_frame_on_display): Delete unused function.
8776 (Fx_own_selection_internal, Fx_get_selection_internal)
8777 (Fx_disown_selection_internal, Fx_selection_owner_p)
8778 (Fx_selection_exists_p): New optional frame arg.
8779 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8780 (x_handle_selection_clear): Don't treat other terminals with the
8781 same keyboard specially. Use the terminal-local Vselection_alist.
8782 (x_clear_frame_selections): Use Frun_hook_with_args.
8783
8784 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8785
8786 * xterm.h: Add support for those atoms.
8787
e067f0c1
CY
87882011-05-26 Chong Yidong <cyd@stupidchicken.com>
8789
8790 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8791 (converted_selections, conversion_fail_tag): New global variables.
8792 (x_selection_request_lisp_error): Free the above.
8793 (x_get_local_selection): Remove unnecessary code.
8794 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8795 of converted selections stored in converted_selections.
8796 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8797 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8798 (x_convert_selection): New function.
8799 (x_handle_selection_event): Simplify.
8800 (x_get_foreign_selection): Don't ignore incoming requests while
8801 waiting for an answer; this will fail when we implement
8802 SAVE_TARGETS, and seems unnecessary anyway.
8803 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8804 (Vx_sent_selection_functions): Doc fix.
8805
0f4aebc0
LL
88062011-05-26 Leo Liu <sdl.web@gmail.com>
8807
8808 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8809
e61124cd
YM
88102011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8811
8812 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8813
8814 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8815 for fringe update if it has periodic bitmap.
ac389d0c 8816 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8817 and fringe_bitmap_periodic_p.
8818
8819 * fringe.c (get_fringe_bitmap_data): New function.
8820 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8821 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8822 row. Mark glyph row for fringe update if periodicity changed.
8823
8824 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8825 for fringe update unless it has periodic bitmap.
8826
f16d9837
KH
88272011-05-25 Kenichi Handa <handa@m17n.org>
8828
8829 * xdisp.c (get_next_display_element): Set correct it->face_id for
8830 a static composition.
8831
e1b90ef6
LL
88322011-05-24 Leo Liu <sdl.web@gmail.com>
8833
8834 * deps.mk (fns.o):
8835 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8836
8837 * fns.c (crypto_hash_function, Fsha1): New function.
8838 (Fmd5): Use crypto_hash_function.
8839 (syms_of_fns): Add Ssha1.
8840
7400048f
PE
88412011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8842
8843 * gnutls.c: Remove unused macros.
8844 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8845 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8846 Remove macros that are defined and never used.
8847 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8848
abb71cf4
CY
88492011-05-22 Chong Yidong <cyd@stupidchicken.com>
8850
8851 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8852 (Fx_get_selection_internal): Minor cleanup.
8853 (Fx_own_selection_internal): Rename arguments for consistency with
8854 select.el.
8855
6307db39
PE
88562011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8857
8858 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8859
f3d4e0a4
CY
88602011-05-22 Chong Yidong <cyd@stupidchicken.com>
8861
8862 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8863
4d8ade89
YM
88642011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8865
8866 * dispnew.c (scrolling_window): Don't exclude the case that the
8867 last enabled row in the desired matrix touches the bottom boundary.
8868
32078c8d
GM
88692011-05-21 Glenn Morris <rgm@gnu.org>
8870
8871 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8872 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8873 and add some more files.
32078c8d 8874
7285dc67
EZ
88752011-05-20 Eli Zaretskii <eliz@gnu.org>
8876
8877 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8878 report_file_error introduced by the change from 2011-05-07.
8879
89d1bd22
PE
88802011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8881
8882 * systime.h (Time): Define only if emacs is defined.
8883 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8884 where the include path doesn't have X11/X.h by default. See
8885 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8886
cd394be1 88872011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
8888
8889 * composite.c (find_automatic_composition): Fix previous change.
8890
b9704ad9
GM
88912011-05-20 Glenn Morris <rgm@gnu.org>
8892
8893 * lisp.mk: New file, split from Makefile.in.
8894 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8895 (shortlisp): Remove.
8896 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8897
4a720484
GM
88982011-05-19 Glenn Morris <rgm@gnu.org>
8899
8900 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8901 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8902 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8903 (lisp): Set the order to that of loadup.el.
8904 (shortlisp): Make it a copy of $lisp.
8905 (SOME_MACHINE_LISP): Remove.
8906 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8907 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8908
a28d4396
KH
89092011-05-18 Kenichi Handa <handa@m17n.org>
8910
8911 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8912 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8913 (find_automatic_composition): Mostly rewrite for efficiency.
8914
a2b1fa8e
JB
89152011-05-18 Juanma Barranquero <lekktu@gmail.com>
8916
8917 * makefile.w32-in: Update dependencies.
8918
8e1f5610
CS
89192011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8920
8921 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 8922 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 8923
7025ee00 89242011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 8925
cdfa6eab
PE
8926 Fix some integer overflow issues, such as string length overflow.
8927
06d6db33
PE
8928 * insdel.c (count_size_as_multibyte): Check for string overflow.
8929
2b4560a8
PE
8930 * character.c (lisp_string_width): Check for string overflow.
8931 Use EMACS_INT, not int, for string indexes and lengths; in
8932 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8933 the resulting string length overflows an EMACS_INT; instead,
8934 report a string overflow if no precision given. When checking for
8935 precision exhaustion, use a check that cannot possibly have
8936 integer overflow. (Bug#8675)
8937 * character.h (lisp_string_width): Adjust to new signature.
8938
cb93f9be
PE
8939 * alloc.c (string_overflow): New function.
8940 (Fmake_string): Use it. This doesn't change behavior, but saves
8941 a few bytes and will simplify future changes.
8942 * character.c (string_escape_byte8): Likewise.
8943 * lisp.h (string_overflow): New decl.
8944
1a1f3366
PE
8945 Fixups, following up to the user-interface timestamp change.
8946 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8947 for UI timestamps, instead of unsigned long.
9fbd6841
PE
8948 * msdos.c (mouse_get_pos): Likewise.
8949 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
8950 * w32gui.h (Time): Define by including "systime.h" rather than by
8951 declaring it ourselves. (Bug#8664)
8952
d4e3e4d3
PE
8953 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8954 * image.c (clear_image_cache): Likewise.
8955
f6a24d19
PE
8956 * term.c (term_mouse_position): Don't assume time_t wraparound.
8957
08dc5ae6
PE
8958 Be more systematic about user-interface timestamps.
8959 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
8960 and sometimes 'EMACS_UINT', to represent these timestamps.
8961 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
8962 This makes the code easier to follow, and makes it easier to catch
8963 integer overflow bugs such as Bug#8664.
8964 * frame.c (Fmouse_position, Fmouse_pixel_position):
8965 Use Time, not unsigned long, for user-interface timestamps.
8966 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8967 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8968 * keyboard.h (last_event_timestamp): Likewise.
8969 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8970 * menu.h (xmenu_show): Likewise.
8971 * term.c (term_mouse_position): Likewise.
8972 * termhooks.h (struct input_event.timestamp): Likewise.
8973 (struct terminal.mouse_position_hook): Likewise.
8974 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8975 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8976 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8977 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8978 what it was before.
8979 * menu.h, termhooks.h: Include "systime.h", for Time.
8980
8e55734a
PE
8981 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8982 Don't assume that the difference between two unsigned long values
8983 can fit into an integer. At this point, we know button_down_time
8984 <= event->timestamp, so the difference must be nonnegative, so
8985 there's no need to cast the result if double-click-time is
8986 nonnegative, as it should be; check that it's nonnegative, just in
8987 case. This bug is triggered when events are more than 2**31 ms
86db42d2 8988 apart (about 25 days). (Bug#8664)
8e55734a 8989
841f1b75 8990 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 8991 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 8992
3e26f69c
PE
8993 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8994 that always fit in int. Use a sentinel instead of a counter, to
8995 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
8996 * frame.h (struct frame): Use int for menu_bar_items_used
8997 instead of EMACS_INT, since it always fits in int.
3e26f69c 8998
5cc152c0
PE
8999 * menu.c (grow_menu_items): Check for int overflow.
9000
d89eb65e
PE
9001 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9002
5235bd3e
PE
9003 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9004 Before, the code was not consistent. These values cannot exceed
9005 2**31 - 1 so there's no need to make them unsigned.
9006 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9007 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9008 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9009 as modifiers.
9010 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9011
bc827e23
PE
9012 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9013 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9014 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9015 presumably because the widths might not match.
9016
78eb494e
PE
9017 * window.c (size_window): Avoid needless test at loop start.
9018
04f2d78b
CB
90192011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9020
9021 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9022
d2fc7e3d 90232011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9024
9025 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9026
d2fc7e3d 90272011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9028
9029 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9030 `width' to `bar_area_x' and `bar_area_width', respectively.
9031 (x_scroll_run): Take account of fringe background extension.
9032
04f2d78b
CB
9033 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9034 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9035 `bar_area_width', respectively.
9036 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9037 background extension.
9038
79b70037
GM
90392011-05-10 Jim Meyering <meyering@redhat.com>
9040
9041 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9042
2f142cc5
JB
90432011-05-10 Juanma Barranquero <lekktu@gmail.com>
9044
9045 * image.c (Finit_image_library): Return t for built-in image types,
9046 like pbm and xbm. (Bug#8640)
9047
57679c86
AS
90482011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9049
9050 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9051
888c9e86
EZ
90522011-05-07 Eli Zaretskii <eliz@gnu.org>
9053
b0512a1d
EZ
9054 * w32console.c (Fset_screen_color): Doc fix.
9055 (Fget_screen_color): New function.
9056 (syms_of_ntterm): Defsubr it.
9057
7285dc67
EZ
9058 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9059 unlink the temporary file if Fcall_process didn't create it in the
9060 first place.
9061 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9062 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9063 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9064 cue to call_process_cleanup not to close that handle.
9065
4d3fcc8e
BK
90662011-05-07 Ben Key <bkey76@gmail.com>
9067
9068 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9069 one of two shell specific rules, either bootstrap-temacs-CMD or
9070 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9071 to the previous implementation of the bootstrap-temacs rule.
9072 The bootstrap-temacs-CMD rule is similar to the previous
9073 implementation of the bootstrap-temacs rule except that it
9074 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9075 variable.
9076
9077 These changes, along with some changes to nt/configure.bat,
9078 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9079 earlier fix to add support for --cflags and --ldflags options
9080 that include quotes so that it works whether make uses cmd or
9081 sh as the shell.
9082
b4289b64
MA
90832011-05-06 Michael Albinus <michael.albinus@gmx.de>
9084
9085 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9086 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9087 is a constant.
9088 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9089 a string. Handle both cases.
9090 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9091 (Fdbus_register_method): Use Qinvalid_function.
9092
af4c0e28
JB
90932011-05-06 Juanma Barranquero <lekktu@gmail.com>
9094
9095 * makefile.w32-in: Update dependencies.
9096 (LISP_H): Add inttypes.h and stdin.h.
9097 (PROCESS_H): Add unistd.h.
9098
c51453d9
EZ
90992011-05-06 Eli Zaretskii <eliz@gnu.org>
9100
9101 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9102 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9103
8ff0ac3c 91042011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9105
4c4b566b
PE
9106 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9107
aab2b9b5
PE
9108 * term.c (vfatal): Remove stray call to va_end.
9109 It's not needed and the C Standard doesn't allow it here anyway.
9110
c378da0b
PE
9111 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9112 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9113
288b08c7
PE
9114 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9115 bytes.
9116
e3601888
PE
9117 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9118
db6c0e74
PE
9119 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9120
dd5963ea
PE
9121 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9122
88c9450f
PE
9123 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9124
2f9442b8
PE
9125 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9126
c032b5f8
PE
9127 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9128 * charset.c (Fdefine_charset_internal): Don't initialize
9129 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9130 32-bit int (Bug#8600).
a108c10b
PE
9131
9132 * lread.c (read_integer): Be more consistent with string-to-number.
9133 Use string_to_number to do the actual conversion; this avoids
9134 rounding errors and fixes some other screwups. Without this fix,
9135 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9136 (digit_to_number): Move earlier, for benefit of read_integer.
9137 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9138 not a digit in any supported base. (Bug#8602)
a108c10b 9139
ad5f9eea
PE
9140 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9141
aec1708a
PE
9142 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9143 to match comment at start of function. This also removes a
9144 GCC warning about overflow in a 32+64-bit port.
9145
47be4ab5
PE
9146 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9147
371cac43
PE
9148 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9149 Reported by Stefan Monnier in
9150 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9151 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9152 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 9153
d01a7826
PE
9154 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9155 (EMACS_UINTPTR): Likewise, with uintptr_t.
9156
7fd47d5c
PE
9157 * lisp.h: Prefer 64-bit EMACS_INT if available.
9158 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9159 on 32-bit hosts that have 64-bit int, so that they can access
9160 large files.
122b0c86
PE
9161 However, temporarily disable this change unless the temporary
9162 symbol WIDE_EMACS_INT is defined.
7fd47d5c 9163
8727937b
PE
9164 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9165
8ac068ac
PE
9166 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9167 This removes an assumption that EMACS_INT and long are the same
9168 width as pointers. The assumption is true for Emacs porting targets
9169 now, but we want to make other targets possible.
9170 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9171 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9172 In the rest of the code, change types of integers that hold casted
9173 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9174 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9175 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9176 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9177 No need to cast type when ORing.
9178 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9179 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9180 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9181 assume EMACS_INT is the same width as char *.
9182 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9183 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9184 Remove no-longer-needed casts.
9185 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9186 (xg_tool_bar_help_callback, xg_make_tool_item):
9187 Use EMACS_INTPTR to hold an integer
9188 that will be cast to void *; this can avoid a GCC warning
9189 if EMACS_INT is not the same width as void *.
9190 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9191 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9192 (current_message_1, set_message_1):
9193 Use a local to convert to proper width without a cast.
9194 * xmenu.c (dialog_selection_callback): Likewise.
9195
ede49d71
PE
9196 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9197 Also, don't assume VALBITS / RAND_BITS is less than 5,
9198 and don't rely on undefined behavior when shifting a 1 left into
9199 the sign bit.
9200 * lisp.h (get_random): Change signature to match.
9201
2f30ecd0
PE
9202 * lread.c (hash_string): Use size_t, not int, for hash computation.
9203 Normally we prefer signed values; but hashing is special, because
9204 it's better to use unsigned division on hash table sizes so that
9205 the remainder is nonnegative. Also, size_t is the natural width
9206 for hashing into memory. The previous code used 'int', which doesn't
9207 retain enough info to hash well into very large tables.
9208 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9209
2a866e7b
PE
9210 * dbusbind.c: Don't possibly lose pointer info when converting.
9211 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9212 Use XPNTR rather than XHASH, so that the high-order bits of
9213 the pointer aren't lost when converting through void *.
9214
51639eac
PE
9215 * eval.c (Fautoload): Don't double-shift a pointer.
9216
92394119
PE
9217 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9218
dbdb9a7c
JB
92192011-05-06 Juanma Barranquero <lekktu@gmail.com>
9220
9221 * gnutls.c (DEF_GNUTLS_FN):
9222 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9223
db7a0b4f
AS
92242011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9225
9226 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9227 marker. (Bug#8610)
9228
cd394be1 92292011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9230
9231 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9232 New version that can reserve upto 2GB of heap space.
9233
f7ff1b0f 92342011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9235
9236 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9237
639c109b
TZ
92382011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9239
9240 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9241 `gnutls_certificate_set_x509_key_file'.
9242
d2127135
JB
92432011-05-05 Juanma Barranquero <lekktu@gmail.com>
9244
9245 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9246 Update dependencies.
9247
e968f4f3
JB
92482011-05-04 Juanma Barranquero <lekktu@gmail.com>
9249
9250 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9251 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9252 Remove unused parameter `fildes'.
9253 * process.c (read_process_output, send_process): Don't pass it.
9254
84d358f0
JB
92552011-05-04 Juanma Barranquero <lekktu@gmail.com>
9256
9257 Fix previous change: the library cache is defined in w32.c.
9258 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9259 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9260
0898ca10
JB
92612011-05-04 Juanma Barranquero <lekktu@gmail.com>
9262
9263 Implement dynamic loading of GnuTLS on Windows.
9264
9265 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9266 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9267 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9268 Declare.
9269
9270 * gnutls.c (Qgnutls_dll): Define.
9271 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9272 (gnutls_*): Declare function pointers.
9273 (init_gnutls_functions): New function to initialize function pointers.
9274 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9275 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9276 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9277 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9278 (emacs_gnutls_write, emacs_gnutls_read)
9279 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9280 (Fgnutls_available_p): New function.
9281 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9282 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9283 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9284
9285 * image.c: Include w32.h.
9286 (Vimage_type_cache): Delete.
9287 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9288 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9289 (w32_delayed_load): Move to w32.c.
9290
9291 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9292
9293 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9294 (w32_delayed_load): Move from image.c. When loading a library, record
9295 its filename in the :loaded-from property of the library id.
9296 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9297 Initialize and staticpro them.
9298 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9299
9300 * process.c: Include lisp.h before w32.h, not after.
9301 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9302 instead of gnutls_record_check_pending.
9303
9304 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9305
ff4de4aa
TZ
93062011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9307
9308 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9309 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9310 as passed in.
9311
abe95abb
JD
93122011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9313
9314 * xterm.c (x_set_frame_alpha): Do not set property on anything
9315 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9316
e16e55d4
JB
93172011-05-02 Juanma Barranquero <lekktu@gmail.com>
9318
9319 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9320
bafcf6a5
JB
93212011-05-02 Juanma Barranquero <lekktu@gmail.com>
9322
9323 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9324 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9325 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9326 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9327 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9328 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9329 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9330 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9331 (Qgnutls_bootprop_callbacks_verify): Make static.
9332
e7a6747f
AS
93332011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9334
19ed11ba
AS
9335 * callproc.c: Indentation fixup.
9336
e7a6747f 9337 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9338 (wait_for_termination, interruptible_wait_for_termination):
9339 Move after wait_for_termination_1.
e7a6747f 9340
1ef14cb4
LMI
93412011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9342
9343 * sysdep.c (interruptible_wait_for_termination): New function
9344 which is like wait_for_termination, but allows keyboard
9345 interruptions.
9346
9347 * callproc.c (Fcall_process): Add (:file "file") as an option for
9348 the STDOUT buffer.
9349 (Fcall_process_region): Ditto.
9350
330d880c
EZ
93512011-04-30 Eli Zaretskii <eliz@gnu.org>
9352
8db90b73
EZ
9353 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9354 rather than `XVECTOR (FOO)->size'.
9355
330d880c
EZ
9356 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9357 inttypes.h, as a gnulib replacement is used if it not available in
9358 system headers.
9359
15cbd324
EZ
93602011-04-21 Eli Zaretskii <eliz@gnu.org>
9361
9362 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9363 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9364 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9365
9366 * coding.c (coding_alloc_by_realloc): Error out if destination
9367 will grow beyond MOST_POSITIVE_FIXNUM.
9368 (decode_coding_emacs_mule): Abort if there isn't enough place in
9369 charbuf for the composition carryover bytes. Reserve an extra
9370 space for up to 2 characters produced in a loop.
9371 (decode_coding_iso_2022): Abort if there isn't enough place in
9372 charbuf for the composition carryover bytes.
9373
93742011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9375
ae940cca
EZ
9376 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9377 aborting when %lld or %lll format is passed.
9378 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9379 %llo or %llx format is passed. (Bug#8545)
9380
03ab8921
EZ
9381 * window.c (window_scroll_line_based): Use a marker instead of
9382 simple variables to record original value of point. (Bug#7952)
9383
afda1437
EZ
9384 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9385 produced by %s or %c overflows available buffer space. (Bug#8545)
9386
f76dee0c
PE
93872011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9388
9389 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9390 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9391
fdc5744d
JB
93922011-04-28 Juanma Barranquero <lekktu@gmail.com>
9393
9394 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9395
638f053a
JB
93962011-04-28 Juanma Barranquero <lekktu@gmail.com>
9397
9398 * keyboard.c (Qdelayed_warnings_hook): Define.
9399 (command_loop_1): Run `delayed-warnings-hook'
9400 if Vdelayed_warnings_list is non-nil.
9401 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9402 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9403
d178f871
EZ
94042011-04-28 Eli Zaretskii <eliz@gnu.org>
9405
9406 * doprnt.c (doprnt): Don't return value smaller than the buffer
9407 size if the message was truncated. (Bug#8545).
9408
b124fd93
JB
94092011-04-28 Juanma Barranquero <lekktu@gmail.com>
9410
9411 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9412 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9413
e810457d
PE
94142011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9415
9416 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9417
ea51cceb
JB
94182011-04-27 Juanma Barranquero <lekktu@gmail.com>
9419
9420 * makefile.w32-in: Update dependencies.
9421
94dcfacf
EZ
94222011-04-27 Eli Zaretskii <eliz@gnu.org>
9423
9424 Improve `doprnt' and its usage. (Bug#8545)
9425 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9426 `format_end'. Remove support for %l as a conversion specifier.
9427 Don't use xrealloc. Improve diagnostics when the %l size modifier
9428 is used. Update the commentary.
9429
9430 * eval.c (verror): Simplify calculation of size_t.
9431
9432 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9433 messages.
9434
f61f41d7
PE
94352011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9436
9437 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9438 change.
9439
96fb4434
PE
94402011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9441
9442 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9443 This makes this file independent of the recent pseudovector change.
9444
671875da 94452011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9446
69e9b5a3
PE
9447 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9448
b5f869a7 9449 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9450 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9451 Remove unused local.
c8926152 9452 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9453
841a1577 9454 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9455 GCC 4.6.0 optimizes based on type-based alias analysis.
9456 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9457 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9458 != &v->size, and therefore "v->size = 1; b->size = 2; return
9459 v->size;" must therefore return 1. This assumption is incorrect
9460 for Emacs, since it type-puns struct Lisp_Vector * with many other
9461 types. To fix this problem, this patch adds a new type struct
f904488f 9462 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
9463 and pseudovectors, and helps optimizing compilers not get fooled
9464 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9465 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
9466 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9467 the size member.
eab3844f
PE
9468 (XSETPVECTYPE): Rewrite in terms of new macro.
9469 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9470 This is a bit clearer, and further avoids the possibility of
9471 undesirable aliasing.
9472 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9473 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9474 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9475 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9476 (ASIZE): Now uses header.size rather than size.
9477 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9478 to avoid the hassle of writing XVECTOR (foo)->header.size.
9479 (struct vectorlike_header): New type.
eab3844f
PE
9480 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9481 object, to help avoid aliasing.
9482 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9483 (SUBRP): Likewise, since Lisp_Subr is a special case.
9484 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9485 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9486 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 9487 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
9488 changed to be "header.size" and "header.next".
9489 * buffer.h (struct buffer): Likewise.
9490 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9491 * frame.h (struct frame): Likewise.
9492 * process.h (struct Lisp_Process): Likewise.
9493 * termhooks.h (struct terminal): Likewise.
9494 * window.c (struct save_window_data, struct saved_window): Likewise.
9495 * window.h (struct window): Likewise.
9496 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9497 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9498 * buffer.c (init_buffer_once): Likewise.
9499 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9500 special case.
9501 * process.c (Fformat_network_address): Use local var for size,
9502 for brevity.
9503
0df1eac5
PE
9504 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9505
847ab9d1 9506 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
9507 * data.c (atof): Remove decl; no longer used or needed.
9508 (digit_to_number): Move to lread.c.
9509 (Fstring_to_number): Use new string_to_number function, to be
9510 consistent with how the Lisp reader treats infinities and NaNs.
9511 Do not assume that floating-point numbers represent EMACS_INT
9512 without losing information; this is not true on most 64-bit hosts.
9513 Avoid double-rounding errors, by insisting on integers when
9514 parsing non-base-10 numbers, as the documentation specifies.
9515 * lisp.h (string_to_number): New decl, replacing ...
9516 (isfloat_string): Remove.
bc0a5c13 9517 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9518 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9519 appears to have been a coding error. Similarly, do not accept
9520 strings like +-1e0 as floating point numbers. Do not report
9521 overflow for integer overflows unless the base is not 10 which
9522 means we have no simple and reliable way to continue.
9523 Break out the floating-point parsing into a new
9524 function string_to_number, so that Fstring_to_number parses
9525 floating point numbers consistently with the Lisp reader.
04f2d78b 9526 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9527 (E_CHAR, EXP_INT): Remove, replacing with ...
9528 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9529 (string_to_number): New function, replacing isfloat_string.
9530 This function checks for valid syntax and produces the resulting
9531 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9532 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9533 so that overflow for non-base-10 numbers is reported only when
9534 there's no portable and simple way to convert to floating point.
452f4150 9535
67769ffc
PE
9536 * textprop.c (set_text_properties_1): Rewrite for clarity,
9537 and to avoid GCC warning about integer overflow.
9538
c20db43f
PE
9539 * intervals.h (struct interval): Use EMACS_INT for members
9540 where EMACS_UINT might cause problems. See
9541 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9542 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9543 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9544 All uses changed.
37aa2f85
PE
9545 (offset_intervals): Tell GCC not to worry about length overflow
9546 when negating a negative length.
c20db43f 9547
2538aa2f
PE
9548 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9549 (overrun_check_free): Likewise.
9550
f2d3008d
PE
9551 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9552 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9553 word size.
9554
ec8df744
PE
9555 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9556 (gnutls_make_error): Rename local to avoid shadowing.
9557 (gnutls_emacs_global_deinit): ifdef out; not used.
9558 (Fgnutls_boot): Use const for pointer to readonly storage.
9559 Comment out unused local. Fix pointer signedness problems.
9560
640ee02d
PE
9561 * lread.c (openp): Don't stuff size_t into an 'int'.
9562 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9563 about possible signed overflow.
9564
6048fb2a
PE
9565 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9566 (GDK_KEY_g): Don't define if already defined.
9567 (xg_prepare_tooltip): Avoid pointer signedness problem.
9568 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9569
fa3c87e1
PE
9570 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9571 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9572
2172544b
PE
9573 * xfns.c (Fx_window_property): Simplify a bit,
9574 to make a bit faster and to avoid GCC 4.6.0 warning.
9575 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9576
9b821a21
PE
9577 * fns.c (internal_equal): Don't assume size_t fits in int.
9578
3c616cfa
PE
9579 * alloc.c (compact_small_strings): Tighten assertion a little.
9580
c2982e87
PE
9581 Replace pEd with more-general pI, and fix some printf arg casts.
9582 * lisp.h (pI): New macro, generalizing old pEd macro to other
9583 conversion specifiers. For example, use "...%"pI"d..." rather
9584 than "...%"pEd"...".
9585 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9586 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9587 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9588 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9589 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9590 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9591 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9592 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9593 64-bit hosts.
9594 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9595 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9596 * print.c (safe_debug_print, print_object): Likewise.
9597 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9598 to int.
6f04d126
PE
9599 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9600 avoiding the 0 flag, which is not portable.
c2982e87
PE
9601 * process.c (Fmake_network_process): Use pI to avoid cast.
9602 * region-cache.c (pp_cache): Likewise.
9603 * xdisp.c (decode_mode_spec): Likewise.
9604 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9605 behavior on 64-bit hosts with printf arg.
6f04d126 9606 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
9607 (x_stop_queuing_selection_requests): Likewise.
9608 (x_get_window_property): Don't truncate byte count to an 'int'
9609 when tracing.
0b432f21 9610
5e073ec7
PE
9611 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9612 here, since it parses constructs like leading '-' and spaces,
9613 which are not wanted; and it overflows with large numbers.
9614 Instead, simply match F[0-9]+, which is what is wanted anyway.
9615
36372bf9
PE
9616 * alloc.c: Remove unportable assumptions about struct layout.
9617 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9618 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9619 (allocate_vectorlike, make_pure_vector): Use the new macros,
9620 plus offsetof, to remove unportable assumptions about struct layout.
9621 These assumptions hold on all porting targets that I know of, but
9622 they are not guaranteed, they're easy to remove, and removing them
9623 makes further changes easier.
9624
0b432f21
PE
9625 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9626 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
9627 (string_overrun_cookie): Now const. Use initializers that
9628 don't formally overflow signed char, to avoid warnings.
000098c1
PE
9629 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9630 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
9631 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9632 multiple of sizeof (EMACS_INT); it need not be, if
9633 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 9634 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 9635
895009e1
JB
96362011-04-26 Juanma Barranquero <lekktu@gmail.com>
9637
9638 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9639
6a7a1b0b
TZ
96402011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9641
9642 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 9643 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
9644 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9645
841a1577 96462011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
9647
9648 * lisp.h (Qdebug): List symbol.
895009e1 9649 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
9650 * keyboard.c (debug-on-event): New variable.
9651 (handle_user_signal): Break into debugger when debug-on-event
9652 matches the current signal symbol.
9653
f2d3ba6f
DN
96542011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9655
9656 * alloc.c (check_sblock, check_string_bytes)
9657 (check_string_free_list): Convert to standard C.
9658
42ce4c63
TZ
96592011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9660
9661 * w32.c (emacs_gnutls_push): Fix typo.
9662
825cd63c
EZ
96632011-04-25 Eli Zaretskii <eliz@gnu.org>
9664
fb11d64d
EZ
9665 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9666 "cast to pointer from integer of different size".
9667
825cd63c
EZ
9668 Improve doprnt and its use in verror. (Bug#8545)
9669 * doprnt.c (doprnt): Document the set of format control sequences
9670 supported by the function. Use SAFE_ALLOCA instead of always
9671 using `alloca'.
9672
9673 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9674 is one byte too soon. Don't use xrealloc; instead xfree and
9675 xmalloc anew.
9676
e061a11b
TZ
96772011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9678
9679 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9680 callbacks stage.
9681
9682 * gnutls.c: Renamed global_initialized to
9683 gnutls_global_initialized. Added internals for the
9684 :verify-hostname-error, :verify-error, and :verify-flags
9685 parameters of `gnutls-boot' and documented those parameters in the
9686 docstring. Start callback support.
9173deec
JB
9687 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9688 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9689 on error. Return error code.
e061a11b
TZ
9690 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9691 (emacs_gnutls_read): Likewise.
9692 (Fgnutls_boot): Return handshake error code.
9693 (emacs_gnutls_handle_error): New function.
9694 (wsaerror_to_errno): Likewise.
9695
9696 * w32.h (emacs_gnutls_pull): Add prototype.
9697 (emacs_gnutls_push): Likewise.
9698
9699 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9700 (emacs_gnutls_push): Likewise.
9701
97022011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9703
9704 * process.c (wait_reading_process_output): Check if GnuTLS
9705 buffered some data internally if no FDs are set for TLS
9706 connections.
9707
9708 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9709 (LIBS): Link to USER_LIBS.
9710 ($(BLD)/gnutls.$(0)): New target.
9711
fa6996bc
EZ
97122011-04-24 Eli Zaretskii <eliz@gnu.org>
9713
eb35682e
EZ
9714 * xdisp.c (handle_single_display_spec): Rename the
9715 display_replaced_before_p argument into display_replaced_p, to
9716 make it consistent with the commentary. Fix typos in the
9717 commentary.
9718
e2ad650c
EZ
9719 * textprop.c (syms_of_textprop): Remove dead code.
9720 (copy_text_properties): Delete obsolete commentary about an
9721 interface that was deleted long ago. Fix typos in the description
9722 of arguments.
9723
1b2de274
EZ
9724 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9725 to changes in oldXMenu/XMenu.h from 2011-04-16.
9726 <menu_help_message, prev_menu_help_message>: Constify.
9727 (IT_menu_make_room): menu->help_text is now `const char **';
9728 adjust.
9729
9730 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9731 to changes in oldXMenu/XMenu.h from 2011-04-16.
9732 (struct XMenu): Declare `help_text' `const char **'.
9733
9734 * xfaces.c <Qunspecified>: Make extern again.
9735
9736 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9737 required by POSIX.
1b2de274 9738
762b15be
EZ
9739 * doc.c (get_doc_string): Improve the format passed to `error'.
9740
9741 * doprnt.c (doprnt): Improve commentary.
9742
9743 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9744
9745 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9746 them with etags.
9747
f1052e5d
EZ
9748 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9749 changes in globals.h immediately force recompilation.
762b15be
EZ
9750 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9751 $(CURDIR)/s/ms-w32.h.
9752 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9753
fa6996bc
EZ
9754 * character.c (Fchar_direction): Function deleted.
9755 (syms_of_character): Don't defsubr it.
9756 <char-direction-table>: Deleted.
9757
e6c3da20
EZ
97582011-04-23 Eli Zaretskii <eliz@gnu.org>
9759
9760 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9761 * doprnt.c: Include limits.h.
9762 (SIZE_MAX): New macro.
04f2d78b
CB
9763 (doprnt): Return a size_t value. 2nd arg is now size_t.
9764 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9765 Improve overflow protection. Support `l' modifier for integer
9766 conversions. Support %l conversion. Don't assume an EMACS_INT
9767 argument for integer conversions and for %c.
9768
9769 * lisp.h (doprnt): Restore prototype.
9770
9771 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9772 $(SRC)/character.h.
9773
9774 * Makefile.in (base_obj): Add back doprnt.o.
9775
9776 * deps.mk (doprnt.o): Add back prerequisites.
9777 (callint.o): Depend on character.h.
9778
9779 * eval.c (internal_lisp_condition_case): Include the handler
9780 representation in the error message.
9781 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9782 when breaking from the loop.
9783
9784 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9785
9786 * callint.c (Fcall_interactively): When displaying error message
9787 about invalid control letter, pass the character's codepoint, not
9788 a pointer to its multibyte form. Improve display of the character
9789 in octal and display also its hex code.
9790
9791 * character.c (char_string): Use %x to display the (unsigned)
9792 codepoint of an invalid character, to avoid displaying a bogus
9793 negative value.
9794
9795 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9796 `error', not SYMBOL_NAME itself.
9797
9798 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9799 character arguments to `error'.
9800
9801 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9802 to `error' in error message about FINAL_CHAR argument. Make sure
9803 FINAL_CHAR is a character, and use %c when it is passed as
9804 argument to `error'.
9805
4ffd0d6b 98062011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9807
9808 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9809
9810 * w32.c: Include <time.h>.
9811 (sys_localtime): New function.
9812
4ffd0d6b 98132011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9814
9815 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9816
4ffd0d6b 9817 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9818
4ffd0d6b 98192011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9820
4ffd0d6b
GM
9821 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9822 zombies (Bug#8467).
aac0c6e3 9823
04c56954
EZ
98242011-04-19 Eli Zaretskii <eliz@gnu.org>
9825
9826 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9827 gl_state.e_property when gl_state.object is Qt.
9828
9829 * insdel.c (make_gap_larger): Remove limitation of buffer size
9830 to <= INT_MAX.
9831
16a43933
CY
98322011-04-18 Chong Yidong <cyd@stupidchicken.com>
9833
9834 * xdisp.c (lookup_glyphless_char_display)
9835 (produce_glyphless_glyph): Handle cons cell entry in
9836 glyphless-char-display.
9837 (Vglyphless_char_display): Document it.
9838
9839 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9840 glyphless-char-display.
9841
4581706e
CY
98422011-04-17 Chong Yidong <cyd@stupidchicken.com>
9843
9844 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9845
9846 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9847
9848 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9849 definition for no-X builds.
9850
4887c6e2 98512011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9852
fd35b6f9
PE
9853 Static checks with GCC 4.6.0 and non-default toolkits.
9854
5c1ccb01
PE
9855 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9856
006c5daa
PE
9857 * process.c (keyboard_bit_set): Define only if SIGIO.
9858 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9859 (send_process): Repair possible setjmp clobbering.
9860
efc736d3
PE
9861 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9862
4e2fe2e6
PE
9863 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9864
f97334a2
PE
9865 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9866
4e75f29d
PE
9867 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9868 Define only if needed.
9869
90efadd1
PE
9870 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9871 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9872 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9873
3c647824
PE
9874 * dispextern.h (struct redisplay_interface): Rename param
9875 to avoid shadowing.
e264f262 9876 * termhooks.h (struct terminal): Likewise.
761383f4 9877 * xterm.c (xembed_send_message): Likewise.
3c647824 9878
b58c5c4a
PE
9879 * insdel.c (make_gap_smaller): Define only if
9880 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9881
cad59032
PE
9882 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9883 it.
9884
c339dc2e
PE
9885 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9886 so that we aren't warned about unused symbols.
9887
91a3e27b
PE
9888 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9889
399c71d3 9890 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 9891
8ffc96f5
PE
9892 * xfns.c (x_real_positions): Mark locals as initialized.
9893
eef9bc79
PE
9894 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9895
098db9dd
PE
9896 * xterm.c: Fix problems found by static analysis with other toolkits.
9897 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
9898 (x_dispatch_event): Declare static if USE_GTK, and
9899 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 9900 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 9901 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
9902 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9903 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 9904
eb18f6cc
PE
9905 * xmenu.c (menu_help_callback): Pointer type fixes.
9906 Use const pointers when pointing at readonly data. Avoid pointer
9907 signedness clashes.
9908 (FALSE): Remove unused macro.
9909 (update_frame_menubar): Remove unused decl.
9910
1fe72bf8
PE
9911 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9912
60d9e1db
PE
9913 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9914 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9915 (single_menu_item): Rename local to avoid shadowing.
9916
39261c26
PE
9917 * keyboard.c (make_lispy_event): Remove unused local var.
9918
018c5e19
PE
9919 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9920 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9921
63d2b86e
PE
9922 * bitmaps: Change bitmaps from unsigned char back to the X11
9923 compatible char. Avoid the old compiler warnings about
9924 out-of-range initializers by using, for example, '\xab' rather
9925 than 0xab.
9926
aefd87e1
PE
9927 * xgselect.c (xgselect_initialize): Check vs interface
9928 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9929
bf501fb9
PE
9930 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9931
e9829fdf
PE
9932 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9933 to read-only memory.
9934
1086c095
PE
9935 * fns.c (vector): Remove; this old hack is no longer needed.
9936
2baccd04 9937 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 9938 Remove unused var.
dde42981 9939 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 9940
72391843 9941 * xrdb.c (x_load_resources): Omit unused local.
3565b346 9942
436c16df 9943 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 9944 (x_window): Rename locals to avoid shadowing.
dc5ddd85 9945 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 9946
92bb796d 9947 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 9948 (x_term_init): Remove local to avoid shadowing.
92bb796d 9949
764430a3 9950 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
9951
9952 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9953 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9954
d1dfb56c
EZ
99552011-04-16 Eli Zaretskii <eliz@gnu.org>
9956
c4354cb4
EZ
9957 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9958
d1dfb56c
EZ
9959 Fix regex.c, syntax.c and friends for buffers > 2GB.
9960 * syntax.h (struct gl_state_s): Declare character position members
9961 EMACS_INT.
9962
9963 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9964
04f2d78b
CB
9965 * textprop.c (verify_interval_modification, interval_of):
9966 Declare arguments EMACS_INT.
d1dfb56c
EZ
9967
9968 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9969 EMACS_INT.
9970
9971 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9972
9973 * indent.c (Fvertical_motion): Local variable it_start is now
9974 EMACS_INT.
9975
9976 * regex.c (re_match, re_match_2, re_match_2_internal)
9977 (bcmp_translate, regcomp, regexec, print_double_string)
9978 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9979 (re_compile_pattern, re_exec): Declare arguments and local
9980 variables `size_t' and `ssize_t' and return values `regoff_t', as
9981 appropriate.
9982 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9983 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9984 <compile_stack_type>: `size' and `avail' are now `size_t'.
9985
9986 * regex.h <regoff_t>: Use ssize_t, not int.
9987 (re_search, re_search_2, re_match, re_match_2): Arguments that
9988 specify buffer/string position and length are now ssize_t and
9989 size_t. Return type is regoff_t.
9990
613052cd
BK
99912011-04-16 Ben Key <bkey76@gmail.com>
9992
9993 * nsfont.m: Fixed bugs in ns_get_family and
9994 ns_descriptor_to_entity that were caused by using free to
9995 deallocate memory blocks that were allocated by xmalloc (via
9996 xstrdup). This caused Emacs to crash when compiled with
9997 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9998 --enable-checking=xmallocoverrun). xfree is now used to
9999 deallocate these memory blocks.
10000
4170f62f 100012011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10002
71b41406
PE
10003 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10004
9587a89d
PE
10005 emacs_write: Accept and return EMACS_INT for sizes.
10006 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10007 et seq.
10008 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10009 Accept and return EMACS_INT.
10010 (emacs_gnutls_write): Return the number of bytes written on
10011 partial writes.
10012 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10013 (emacs_read, emacs_write): Remove check for negative size, as the
10014 Emacs source code has been audited now.
9587a89d
PE
10015 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10016 (emacs_read, emacs_write): Use it.
273a5f82
PE
10017 * process.c (send_process): Adjust to the new signatures of
10018 emacs_write and emacs_gnutls_write. Do not attempt to store
10019 a byte offset into an 'int'; it might overflow.
9587a89d 10020 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10021
3e047f51
PE
10022 * sound.c: Don't assume sizes fit in 'int'.
10023 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10024 Return EMACS_INT, not int.
3e047f51 10025 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10026 Accept EMACS_INT, not int.
10027 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10028 record read return values.
10029
cc39a9db
BK
100302011-04-15 Ben Key <bkey76@gmail.com>
10031
c9d0ec6d
JB
10032 * keyboard.c (Qundefined): Don't declare static since it is used
10033 in nsfns.m.
10034 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10035 static since they are used in nsfont.m.
cc39a9db 10036
6c60eb9f
SM
100372011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10038
10039 * process.c (Qprocessp): Don't declare static.
10040 * lisp.h (Qprocessp): Declare again.
10041
7990b61a
JB
100422011-04-15 Juanma Barranquero <lekktu@gmail.com>
10043
10044 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10045
5d4cb038
PE
100462011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10047
8bd7b830 10048 Improve C-level modularity by making more things 'static'.
cd64ea1d 10049
e3b27b31
PE
10050 Don't publish debugger-only interfaces to other modules.
10051 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10052 (verify_bytepos, count_markers): Move decls to the only modules
10053 that need them.
10054 * region-cache.h (pp_cache): Likewise.
10055 * window.h (check_all_windows): Likewise.
10056 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10057
5d4cb038
PE
10058 * sysdep.c (croak): Now static, if
10059 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10060 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10061
10062 * alloc.c (refill_memory_reserve): Now static if
10063 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10064 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10065
e87b6180
PE
10066 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10067 Define only if USE_LUCID.
10068
ac64929e
PE
10069 * xrdb.c (x_customization_string, x_rm_string): Now static.
10070
6f37259d
PE
10071 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10072 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10073
1683e3ab
PE
10074 * xdisp.c (draw_row_with_mouse_face): Now static.
10075 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10076
de9c2632
PE
10077 * window.h (check_all_windows): Mark externally visible.
10078
2b96acb7
PE
10079 * window.c (window_deletion_count): Now static.
10080
10081 * undo.c: Make symbols static if they're not exported.
10082 (last_undo_buffer, last_boundary_position, pending_boundary):
10083 Now static.
10084
50436f33
PE
10085 * textprop.c (interval_insert_behind_hooks): Now static.
10086 (interval_insert_in_front_hooks): Likewise.
10087
64520e5c
PE
10088 * term.c: Make symbols static if they're not exported.
10089 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10090 (max_frame_lines, tty_set_terminal_modes):
10091 (tty_reset_terminal_modes, tty_turn_off_highlight):
10092 (get_tty_terminal): Now static.
10093 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10094 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10095 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10096 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10097 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10098
1fa53021
PE
10099 * sysdep.c: Make symbols static if they're not exported.
10100 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10101 Now static.
10102 (sigprocmask_set, full_mask): Remove; unused.
10103 (wait_debugging): Mark as visible.
10104 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10105 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10106
d4b43b22
PE
10107 * syntax.c (syntax_temp): Define only if !__GNUC__.
10108
b7c513d0
PE
10109 * sound.c (current_sound_device, current_sound): Now static.
10110
989b29ad
PE
10111 * search.c (searchbufs, searchbuf_head): Now static.
10112
13a55a78
PE
10113 * scroll.c (scroll_cost): Remove; unused.
10114 * dispextern.h (scroll_cost): Remove decl.
10115
de68a1fc
PE
10116 * region-cache.h (pp_cache): Mark as externally visible.
10117
40ccffa6
PE
10118 * process.c: Make symbols static if they're not exported.
10119 (process_tick, update_tick, create_process, chan_process):
10120 (Vprocess_alist, proc_buffered_char, datagram_access):
10121 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10122 (deactivate_process): Mark defn as static, as well as decl.
10123 * lisp.h (create_process): Remove decl.
10124 * process.h (chan_process, Vprocess_alist): Remove decls.
10125
ad64fc97
PE
10126 * print.c: Make symbols static if they're not exported.
10127 (print_depth, new_backquote_output, being_printed, print_buffer):
10128 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10129 (print_interval, print_number_index, initial_stderr_stream):
10130 Now static.
10131 * lisp.h (Fprinc): Remove decl.
10132 (debug_output_compilation_hack): Mark as externally visible.
10133
adddb265
PE
10134 * sysdep.c (croak): Move decl from here to syssignal.h.
10135 * syssignal.h (croak): Put it here, so the API can be checked when
10136 'croak' is called from dissociate_if_controlling_tty.
10137
1717ede2
PE
10138 * minibuf.c: Make symbols static if they're not exported.
10139 (minibuf_save_list, choose_minibuf_frame): Now static.
10140 * lisp.h (choose_minibuf_frame): Remove decl.
10141
fa5fb2bc
PE
10142 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10143
1e3890d1
PE
10144 * lread.c: Make symbols static if they're not exported.
10145 (read_objects, initial_obarray, oblookup_last_bucket_number):
10146 Now static.
10147 (make_symbol): Remove; unused.
10148 * lisp.h (initial_obarray, make_symbol): Remove decls.
10149
8a1414fa
PE
10150 * keyboard.c: Make symbols static if they're not exported.
10151 (single_kboard, recent_keys_index, total_keys, recent_keys):
10152 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10153 (this_single_command_key_start, echoing, last_auto_save):
10154 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10155 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10156 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10157 (Vlispy_mouse_stem, double_click_count):
10158 Now static.
10159 (force_auto_save_soon): Define only if SIGDANGER.
10160 (ignore_mouse_drag_p): Now static if
10161 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10162 (print_help): Remove; unused.
10163 (stop_character, last_timer_event): Mark as externally visible.
10164 * keyboard.h (ignore_mouse_drag_p): Declare only if
10165 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10166 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10167 * lisp.h (echoing): Remove decl.
10168 (force_auto_save_soon): Declare only if SIGDANGER.
10169 * xdisp.c (redisplay_window): Simplify code, to make it more
10170 obvious that ignore_mouse_drag_p is not accessed if !defined
10171 USE_GTK && !defined HAVE_NS.
10172
93ea6e8f
PE
10173 * intervals.c: Make symbols static if they're not exported.
10174 (merge_properties_sticky, merge_interval_right, delete_interval):
10175 Now static.
10176 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10177
77382fcc
PE
10178 * insdel.c: Make symbols static if they're not exported.
10179 However, leave prepare_to_modify_buffer alone. It's never
10180 called from outside this function, but that appears to be a bug.
10181 (combine_after_change_list, combine_after_change_buffer):
4889fc82 10182 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
10183 (adjust_after_replace_noundo): Remove; unused.
10184 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 10185 (signal_before_change): Remove decls.
77382fcc 10186
9306c32e
PE
10187 * indent.c (val_compute_motion, val_vmotion): Now static.
10188
cd44d2eb
PE
10189 * image.c: Make symbols static if they're not exported.
10190 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10191 if USE_GTK.
10192 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10193 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10194
ad9a7a06
PE
10195 * fringe.c (standard_bitmaps): Now static.
10196 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10197
81626931
PE
10198 * frame.c: Make symbols static if they're not exported.
10199 (x_report_frame_params, make_terminal_frame): Now static.
10200 (get_frame_param): Now static, unless HAVE_NS.
10201 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10202 (x_get_resource_string): Remove; not used.
10203 * frame.h (make_terminal_frame, x_report_frame_params):
10204 (x_get_resource_string); Remove decls.
10205 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10206 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10207
239f9db9
PE
10208 * font.c, fontset.c: Make symbols static if they're not exported.
10209 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10210 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10211 * font.c (font_close_object): Now static.
10212 * font.h (font_close_object): Remove.
10213 * fontset.c (FONTSET_OBJLIST): Remove.
10214 (free_realized_fontset) #if-0 the body, which does nothing.
10215 (face_suitable_for_char_p): #if-0, as it's never called.
10216 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
10217 * xfaces.c (face_at_string_position):
10218 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
10219 since 0 is always ASCII.
10220
dfcf3579
PE
10221 * fns.c (weak_hash_tables): Now static.
10222
5045092b
PE
10223 * fileio.c: Make symbols static if they're not exported.
10224 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10225 (Vwrite_region_annotation_buffers): Now static.
10226
57a96f5c
PE
10227 * eval.c: Make symbols static if they're not exported.
10228 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10229 * lisp.h (backtrace_list): Remove decl.
10230
35f08c38
PE
10231 * emacs.c: Make symbols static if they're not exported.
10232 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10233 (fatal_error_code, fatal_error_signal_hook, standard_args):
10234 Now static.
10235 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10236 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10237 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10238 * lisp.h (fatal_error_signal_hook): Remove decl.
10239 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10240
f44bd759
PE
10241 * editfns.c: Move a (normally-unused) function to its only use.
10242 * editfns.c, lisp.h (get_operating_system_release): Remove.
10243 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10244 worth the hassle of breaking this out.
10245
b532497d
PE
10246 * xterm.c: Make symbols static if they're not exported.
10247 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10248 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10249 (x_destroy_window, x_delete_display):
10250 Now static.
10251 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10252 (x_mouse_leave): Remove; unused.
10253 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10254 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10255 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10256 Remove decls.
10257 (x_mouse_leave): Declare only if WINDOWSNT.
10258 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10259 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10260 USE_X_TOOLKIT.
10261
1675728f
PE
10262 * ftxfont.c: Make symbols static if they're not exported.
10263 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10264 HAVE_FREETYPE.
10265 * font.h (ftxfont_driver): Likewise.
10266
e4cebfca
PE
10267 * xfns.c: Make symbols static if they're not exported.
10268 (x_last_font_name, x_display_info_for_name):
10269 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10270 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10271 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10272 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10273 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10274 (last_show_tip_args): Now static.
10275 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10276 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10277 (x_screen_planes): Remove; unused.
10278 * dispextern.h (x_screen_planes): Remove decl.
10279
5bf46f05
PE
10280 * dispnew.c: Make symbols static if they're not exported.
10281 * dispextern.h (redraw_garbaged_frames, scrolling):
10282 (increment_row_positions): Remove.
10283 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10284 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10285 Now static.
10286 (redraw_garbaged_frames): Remove; unused.
10287
435f4c28
PE
10288 * xfaces.c: Make symbols static if they're not exported.
10289 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10290 Remove decls.
10291 * xterm.h (defined_color): Remove decls.
10292 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10293 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10294 (menu_face_changed_default, defined_color, free_realized_face):
10295 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10296 (ascii_face_of_lisp_face): Remove; unused.
10297
8524aef3
PE
10298 * xdisp.c: Make symbols static if they're not exported.
10299 * dispextern.h (scratch_glyph_row, window_box_edges):
10300 (glyph_to_pixel_coords, set_cursor_from_row):
10301 (get_next_display_element, set_iterator_to_next):
10302 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10303 (show_mouse_face): Remove decls
10304 * frame.h (message_buf_print): Likewise.
10305 * lisp.h (pop_message, set_message, check_point_in_composition):
10306 Likewise.
10307 * xterm.h (set_vertical_scroll_bar): Likewise.
10308 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10309 (message_buf_print, scratch_glyph_row, displayed_buffer):
10310 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10311 (get_next_display_element, show_mouse_face, window_box_edges):
10312 (frame_to_window_pixel_xy, check_point_in_composition):
10313 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10314 (glyph_to_pixel_coords): Remove; unused.
10315
16390cd2
PE
10316 * dired.c (file_name_completion): Now static.
10317
10318 * dbusbind.c (xd_in_read_queued_messages): Now static.
10319
a25f4dfa
PE
10320 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10321 * data.c (circular_list_error): Remove.
10322
14a9c8df
PE
10323 * commands.h (last_point_position, last_point_position_buffer):
10324 (last_point_position_window): Remove decls.
10325 * keyboard.c: Make these variables static.
10326
04f2d78b
CB
10327 * coding.h (coding, code_convert_region, encode_coding_gap):
10328 Remove decls.
74ab6df5
PE
10329 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10330 (iso_code_class, detect_coding, code_convert_region): Now static.
10331 (encode_coding_gap): Remove; unused.
10332
38dfbee1
PE
10333 * chartab.c (chartab_chars, chartab_bits): Now static.
10334
a2cb4e63
PE
10335 * charset.h (charset_iso_8859_1): Remove decl.
10336 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10337 Now static.
10338
127198fd
PE
10339 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10340 * ccl.c (Vccl_program_table): Now static.
10341 (check_ccl_update): Remove; unused.
10342
d85b608f
PE
10343 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10344 * category.h: ... from here.
10345 * category.c (check_category_table, set_category_set): Now static.
10346
31cd66f3
PE
10347 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10348 * lisp.h: Remove these decls.
10349
c358e587
PE
10350 * buffer.c (buffer_count): Remove unused var.
10351
e78aecca
PE
10352 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10353 so that it's not optimized away.
10354 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10355 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10356 exported only to the debugger.
10357
e192d7d3 10358 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10359 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10360
92470028
PE
10361 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10362 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10363 was inaccessible from Lisp.
10364 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10365 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10366
244ed907
PE
10367 alloc.c: Import and export fewer symbols, and remove unused items.
10368 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10369 is defined.
10370 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10371 it's not optimized away by whole-program optimization.
10372 (message_enable_multibyte, free_misc): Remove.
10373 (catchlist, handlerlist, mark_backtrace):
10374 Declare only if BYTE_MARK_STACK.
10375 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10376 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10377 (message_enable_multibyte): Remove decl.
10378 (free_misc, interval_free_list, float_block, float_block_index):
10379 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10380 (cons_free_list, last_marked_index):
10381 Now static.
10382 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10383 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10384 (mark_backtrace): Define only if BYTE_MARK_STACK.
10385 * xdisp.c (message_enable_multibyte): Now static.
10386
61c2b50e 10387 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10388 This makes it easier for human readers (and static analyzers)
10389 to see whether these variables are used from other modules.
10390 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10391 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10392 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10393 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10394 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10395 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10396 * xmenu.c, xselect.c:
10397 Declare Q* vars static if they are not used in other modules.
10398 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10399 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10400 Remove decls of unexported vars.
10401 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10402
95c82688
PE
10403 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10404
16a97296
PE
10405 Make Emacs functions such as Fatom 'static' by default.
10406 This makes it easier for human readers (and static analyzers)
10407 to see whether these functions can be called from other modules.
10408 DEFUN now defines a static function. To make the function external
10409 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10410 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10411 (Finit_image_library):
16a97296
PE
10412 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10413 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10414 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10415 Remove decls, since these functions are now static.
10416 (Funintern, Fget_internal_run_time): New decls, since these functions
10417 were already external.
95c82688 10418
16a97296
PE
10419 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10420 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10421 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10422 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10423 * keyboard.c, keymap.c, lread.c:
10424 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10425 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10426 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10427 Mark functions with DEFUE instead of DEFUN,
10428 if they are used in other modules.
10429 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10430 decls for now-static functions.
10431 * buffer.h (Fdelete_overlay): Remove decl.
10432 * callproc.c (Fgetenv_internal): Mark as internal.
10433 * composite.c (Fremove_list_of_text_properties): Remove decl.
10434 (Fcomposition_get_gstring): New forward static decl.
10435 * composite.h (Fcomposite_get_gstring): Remove decl.
10436 * dired.c (Ffile_attributes): New forward static decl.
10437 * doc.c (Fdocumntation_property): New forward static decl.
10438 * eval.c (Ffetch_bytecode): New forward static decl.
10439 (Funintern): Remove extern decl; now in .h file where it belongs.
10440 * fileio.c (Fmake_symbolic_link): New forward static decl.
10441 * image.c (Finit_image_library): New forward static decl.
10442 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10443 * intervals.h (Fprevious_property_change):
10444 (Fremove_list_of_text_properties): Remove decls.
10445 * keyboard.c (Fthis_command_keys): Remove decl.
10446 (Fcommand_execute): New forward static decl.
10447 * keymap.c (Flookup_key): New forward static decl.
10448 (Fcopy_keymap): Now static.
10449 * keymap.h (Flookup_key): Remove decl.
10450 * process.c (Fget_process): New forward static decl.
10451 (Fprocess_datagram_address): Mark as internal.
10452 * syntax.c (Fsyntax_table_p): New forward static decl.
10453 (skip_chars): Remove duplicate decl.
10454 * textprop.c (Fprevious_property_change): New forward static decl.
10455 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10456 Now internal.
10457 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10458 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10459
785bbd42
PE
10460 * editfns.c (Fformat): Remove unreachable code.
10461
8b913b57
AS
104622011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10463
10464 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10465 change. (Bug#8496)
10466
a6744a35
EZ
104672011-04-13 Eli Zaretskii <eliz@gnu.org>
10468
10469 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10470 when at ZV. (Bug#8487)
10471
e7974947
AS
104722011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10473
baad03f0
AS
10474 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10475 (Bug#8437)
10476 * keyboard.c (parse_tool_bar_item): Likewise.
10477 * sound.c (sound_cleanup, alsa_close): Likewise.
10478 * termcap.c (tgetent): Likewise.
10479 * xfns.c (x_default_font_parameter): Likewise.
10480 * xsettings.c (read_and_apply_settings): Likewise.
10481
e7974947
AS
10482 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10483 (overrun_check_free): Protoize.
10484
28272684
PE
104852011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10486
10487 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10488 since callers should never pass a negative size.
10489 Change the signature to match that of plain 'read' and 'write'; see
10490 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10491 * lisp.h: Update prototypes of emacs_write and emacs_read.
10492
11997c76
EZ
104932011-04-11 Eli Zaretskii <eliz@gnu.org>
10494
10495 * xdisp.c (redisplay_window): Don't try to determine the character
10496 position of the scroll margin if the window start point w->startp
e896f03c 10497 is outside the buffer's accessible region. (Bug#8468)
11997c76 10498
8a2cbd72
EZ
104992011-04-10 Eli Zaretskii <eliz@gnu.org>
10500
10501 Fix write-region and its subroutines for buffers > 2GB.
10502 * fileio.c (a_write, e_write): Modify declaration of arguments and
10503 local variables to support buffers larger than 2GB.
10504 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10505
10506 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10507 argument, local variables, and return value.
10508
10509 * lisp.h: Update prototypes of emacs_write and emacs_read.
10510
10511 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10512
4073e537 105132011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10514
1ebfdcb6
PE
10515 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10516
b2ded58d
PE
10517 Fix more problems found by GCC 4.6.0's static checks.
10518
7d66342c
PE
10519 * xdisp.c (vmessage): Use a better test for character truncation.
10520
bbf47d44
PE
10521 * charset.c (load_charset_map): <, not <=, for optimization,
10522 and to avoid potential problems with integer overflow.
9248994d 10523 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10524 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10525 * editfns.c (Fformat): Likewise.
1e69125e 10526 * syntax.c (skip_chars): Likewise.
3befa583 10527
e3019616
PE
10528 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10529 This also lets GCC 4.6.0 generate slightly better loop code.
10530
becfa255
PE
10531 * callint.c (Fcall_interactively): <, not <=, for optimization.
10532 (Fcall_interactively): Count the number of arguments produced,
10533 not the number of arguments given. This is simpler and lets GCC
10534 4.6.0 generate slightly better code.
10535
dae0cd48
PE
10536 * ftfont.c: Distingish more carefully between FcChar8 and char.
10537 The previous code passed unsigned char * to a functions like
10538 strlen and xstrcasecmp that expect char *, which does not
10539 conform to the C standard.
10540 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10541 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10542 char * when the C standard requires it.
10543
76032d70
PE
10544 * keyboard.c (read_char): Remove unused var.
10545
eb3f1cc8
PE
10546 * eval.c: Port to Windows vsnprintf (Bug#8435).
10547 Include <limits.h>.
10548 (SIZE_MAX): Define if the headers do not.
10549 (verror): Do not give up if vsnprintf returns a negative count.
10550 Instead, grow the buffer. This ports to Windows vsnprintf, which
10551 does not conform to C99. Problem reported by Eli Zaretskii.
10552 Also, simplify the allocation scheme, by avoiding the need for
10553 calling realloc, and removing the ALLOCATED variable.
10554
70476b54
PE
10555 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10556
12020a9e
PE
10557 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10558 But keep the doprint source code for now, as we might revamp it
10559 and use it again (Bug#8435).
ea6c7ae6
PE
10560 * lisp.h (doprnt): Remove.
10561 * Makefile.in (base_obj): Remove doprnt.o.
10562 * deps.mk (doprnt.o): Remove.
10563
5fdb398c
PE
10564 error: Print 32- and 64-bit integers portably (Bug#8435).
10565 Without this change, on typical 64-bit hosts error ("...%d...", N)
10566 was used to print both 32- and 64-bit integers N, which relied on
10567 undefined behavior.
61bdb816 10568 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
10569 * lisp.h (error, verror): Mark as printf-like functions.
10570 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10571 Report overflow in size calculations when allocating printf buffer.
10572 Do not truncate output string at its first null byte.
10573 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10574 Truncate the output at a character boundary, since vsnprintf does not
10575 do that.
10576 * charset.c (check_iso_charset_parameter): Convert internal
10577 character to string before calling 'error', since %c now has the
10578 printf meaning.
10579 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10580 overflow when computing char to be passed to 'error'. Do not
10581 pass Lisp_Object to 'error'; pass the integer instead.
10582 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10583 formatted with plain %d.
10584
b189fa66
PE
10585 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10586
bff87ef0
PE
10587 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10588
7e2cac20
PE
10589 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10590
ce4d90b5
PE
10591 * xterm.c (x_catch_errors): Remove duplicate declaration.
10592
266c9547
PE
10593 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10594
79c49ad2
PE
10595 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10596
368f4090
JM
105972011-04-10 Jim Meyering <meyering@redhat.com>
10598
10599 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10600 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10601 return ssize_t not "int", and use size_t as the buffer length.
10602 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10603 * gnutls.h: Update declarations.
10604 * process.c (read_process_output): Use ssize_t, to match.
10605 (send_process): Likewise.
10606
a32d4040
CY
106072011-04-09 Chong Yidong <cyd@stupidchicken.com>
10608
10609 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10610
8546720e 106112011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 10612
04f2d78b
CB
10613 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10614 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 10615
8546720e
GM
10616 * xterm.c (handle_one_xevent):
10617 * xmenu.c (create_and_show_popup_menu):
10618 * xselect.c (x_decline_selection_request)
10619 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 10620
0a2f5c1a 106212011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
10622
10623 Fix some uses of `int' instead of EMACS_INT.
10624 * search.c (string_match_1, fast_string_match)
10625 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10626 (scan_buffer, find_next_newline_no_quit)
10627 (find_before_next_newline, search_command, Freplace_match)
10628 (Fmatch_data): Make some `int' variables be EMACS_INT.
10629
10630 * xdisp.c (display_count_lines): 3rd argument and return value now
10631 EMACS_INT. All callers changed.
10632 (pint2hrstr): Last argument is now EMACS_INT.
10633
10634 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10635 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10636 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10637 (decode_coding_utf_16, decode_coding_emacs_mule)
10638 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10639 (decode_coding_ccl, decode_coding_charset)
10640 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10641 (decode_coding_iso_2022, decode_coding_emacs_mule)
10642 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10643 <char_offset, last_offset>: Declare EMACS_INT.
10644 (encode_coding_utf_8, encode_coding_utf_16)
10645 (encode_coding_emacs_mule, encode_invocation_designation)
10646 (encode_designation_at_bol, encode_coding_iso_2022)
10647 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10648 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10649 Declare EMACS_INT.
10650 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10651 (encode_invocation_designation): Last argument P_NCHARS is now
10652 EMACS_INT.
10653 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10654 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10655
10656 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10657 All users changed.
10658
10659 * ccl.c (Fccl_execute_on_string): Declare some variables
10660 EMACS_INT.
10661
8546720e 106622011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
10663
10664 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10665
4e19a977
CS
106662011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10667
10668 * process.c (Fformat_network_address): Doc fix.
10669
87302331
R
106702011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10671
ee7683eb 10672 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 10673
cbb59342
CY
106742011-04-08 Chong Yidong <cyd@stupidchicken.com>
10675
10676 * keyboard.c (read_char): Call Lisp function help-form-show,
10677 instead of using internal_with_output_to_temp_buffer.
10678 (Qhelp_form_show): New var.
e0d38eeb 10679 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
10680
10681 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10682
10683 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10684
e67a13ab
CY
106852011-04-06 Chong Yidong <cyd@stupidchicken.com>
10686
04f2d78b
CB
10687 * process.c (Flist_processes): Remove to Lisp.
10688 (list_processes_1): Delete.
e67a13ab 10689
973f782d
EZ
106902011-04-06 Eli Zaretskii <eliz@gnu.org>
10691
7c106b1e
EZ
10692 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10693
973f782d
EZ
10694 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10695
41cf7d1a 106962011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10697
ca23cc88
PE
10698 Fix more problems found by GCC 4.6.0's static checks.
10699
f390e2d5
PE
10700 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10701
42eea0d0
PE
10702 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10703
b69769da 10704 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10705
f9541e84
PE
10706 * xdisp.c (vmessage): Mark as a printf-like function.
10707
13841b55
PE
10708 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10709
c136c10f
PE
10710 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10711
5e2d4a30
PE
10712 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10713 printf-like functions.
10714 (tiff_load): Add casts to remove these marks before passing them
10715 to system-supplied API.
10716
583f48b9
PE
10717 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10718
b25d760e
PE
10719 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10720 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10721 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10722 directly, rather than having caller test rule sign. This avoids
10723 some unnecessary tests.
10724 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10725 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10726 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10727
bc7b6697 10728 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10729 (xfont_open): Avoid unnecessary tests.
bc7b6697 10730
27ccc379
PE
10731 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10732
dcd5c89a
PE
10733 * composite.h, composite.c (composition_gstring_put_cache):
10734 Use EMACS_INT, not int, for length.
10735
b13a45c6
PE
10736 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10737 breaking out part of COMPOSITION_DECODE_RULE.
10738 (COMPOSITION_DECODE_RULE): Use it.
10739 * composite.c (get_composition_id): Remove unused local vars,
10740 by using the new macro.
10741
1e792e4d
PE
10742 * textprop.c (set_text_properties_1): Change while to do-while,
10743 since the condition is always true at first.
10744
dc6c6455 10745 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10746 (interval_deletion_adjustment): Return unsigned value.
10747 All uses changed.
dc6c6455 10748
aba7731a
PE
10749 * process.c (list_processes_1, create_pty, read_process_output):
10750 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10751 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10752 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10753 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10754 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10755
fdfc4bf3
PE
10756 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10757
fca8fe46 10758 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10759 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10760
06a0259a 10761 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10762 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10763 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10764
e7b9e80f
PE
10765 * print.c (print_error_message): Avoid int overflow.
10766
56201685
PE
10767 * font.c (font_list_entities): Redo for clarity,
10768 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10769
78834453 10770 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10771 (font_score): Avoid potential overflow in diff calculation.
78834453 10772
0bc0b309 10773 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10774 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10775
e610eaca
PE
10776 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10777
b895abce
PE
10778 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10779 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10780 can always succeed if overflow has undefined behavior.
10781
1f1d9321 10782 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10783 (wordify): Omit three unnecessary tests.
1f1d9321 10784
c59478bc
PE
10785 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10786 All callers changed. This avoids the need for an unused var.
10787
79b73827
PE
10788 * casefiddle.c (casify_region): Remove var that is set but not used.
10789
a4db5dfe
PE
10790 * dired.c (file_name_completion): Remove var that is set but not used.
10791
43aae36e
PE
10792 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10793
2a47c44d 10794 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10795 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10796
a37c69bf
PE
10797 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10798 Check for integer overflow on size calculations.
10799
328ab8e7
PE
10800 * buffer.c (Fprevious_overlay_change): Remove var that is set
10801 but not used.
10802
e5a2a5cb
PE
10803 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10804 Remove vars that are set but not used.
8d84a6eb 10805 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10806 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10807
a60e5f68
PE
10808 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10809
f661cb61 10810 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10811 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10812
f0397f5a
PE
10813 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10814 that are set but not used.
10815
8664db06 10816 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10817 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10818
6abdaa4a
PE
10819 * xselect.c (x_get_local_selection, x_handle_property_notify):
10820 Remove vars that are set but not used.
10821
0ce7538d 10822 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10823 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10824
9ae848fc
PE
10825 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10826 Remove var that is set but not used.
0b918413
PE
10827 (scroll_bar_windows_size): Now size_t, not int.
10828 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10829 Check for overflow.
9ae848fc 10830
a5a62657
PE
10831 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10832 (map_tty_color) [!defined MSDOS]: Likewise.
10833
5c5cdd39
PE
10834 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10835
66ebf983
PE
10836 * coding.c: Remove vars that are set but not used.
10837 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10838 All callers changed.
10839 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10840 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10841 (decode_coding_charset): Remove vars that are set but not used.
10842
1be4d761
PE
10843 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10844 that is set but not used.
10845
47553fa8
PE
10846 * print.c (print_object): Remove var that is set but not used.
10847
1f7196bf 10848 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10849 The gnulib version avoids calling malloc in the usual case,
10850 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10851 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10852 * filelock.c (current_lock_owner): Likewise.
10853 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10854 * sysdep.c: Include allocator.h, careadlinkat.h.
10855 (emacs_no_realloc_allocator): New static constant.
10856 (emacs_readlink): New function.
fdb61804
PE
10857 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10858 ../lib/careadlinkat.h.
d1fdcab7 10859
f84c17c7
SM
108602011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10861
10862 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10863 first non-nil return value).
10864
ef3862ad
JD
108652011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10866
10867 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10868 if not defined (Bug#8403).
10869
376a7006
JB
108702011-04-02 Juanma Barranquero <lekktu@gmail.com>
10871
10872 * xdisp.c (display_count_lines): Remove parameter `start',
10873 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10874 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10875 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10876 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10877 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10878 and thereabouts. All callers changed.
10879 (get_per_char_metric): Remove parameter `f', unused since
10880 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10881
6ca3801d
JM
108822011-04-02 Jim Meyering <meyering@redhat.com>
10883
10884 do not dereference NULL upon failed strdup
10885 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10886 (ns_get_family): Likewise.
10887
d8e2b5ba
JB
108882011-04-02 Juanma Barranquero <lekktu@gmail.com>
10889
10890 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10891
8c74fcbd
JD
108922011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10893
10894 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10895 later (Bug#8403).
10896
7200d79c
SM
108972011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10898
03408648 10899 Add lexical binding.
7200d79c 10900
03408648
SM
10901 * window.c (Ftemp_output_buffer_show): New fun.
10902 (Fsave_window_excursion):
10903 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10904
10905 * lread.c (lisp_file_lexically_bound_p): New function.
10906 (Fload): Bind Qlexical_binding.
10907 (readevalloop): Remove `evalfun' arg.
10908 Bind Qinternal_interpreter_environment.
10909 (Feval_buffer): Bind Qlexical_binding.
10910 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10911 Mark as dynamic.
10912 (syms_of_lread): Declare `lexical-binding'.
10913
10914 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10915
10916 * keyboard.c (eval_dyn): New fun.
10917 (menu_item_eval_property): Use it.
ca105506
SM
10918
10919 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 10920
03408648
SM
10921 * fns.c (concat, mapcar1): Accept byte-code-functions.
10922
10923 * eval.c (Fsetq): Handle lexical vars.
10924 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10925 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10926 (FletX, Flet): Obey lexical binding.
10927 (Fcommandp): Handle closures.
10928 (Feval): New `lexical' arg.
10929 (eval_sub): New function extracted from Feval. Use it almost
10930 everywhere where Feval was used. Look up vars in lexical env.
10931 Handle closures.
10932 (Ffunctionp): Move from subr.el.
10933 (Ffuncall): Handle closures.
10934 (apply_lambda): Remove `eval_flags'.
10935 (funcall_lambda): Handle closures and new byte-code-functions.
10936 (Fspecial_variable_p): New function.
10937 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10938 but without exporting it to Lisp.
23aba0ea 10939
23aba0ea 10940 * doc.c (Fdocumentation, store_function_docstring):
03408648 10941 * data.c (Finteractive_form): Handle closures.
23aba0ea 10942
03408648
SM
10943 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10944 interactive spec.
ba83908c 10945
04f2d78b
CB
10946 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10947 New byte-codes.
03408648
SM
10948 (exec_byte_code): New function extracted from Fbyte_code to handle new
10949 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 10950
03408648 10951 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 10952
03408648 10953 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 10954
e2abce01
JB
109552011-03-31 Juanma Barranquero <lekktu@gmail.com>
10956
10957 * xdisp.c (redisplay_internal): Fix prototype.
10958
63696a73 109592011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 10960
63696a73 10961 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
10962 (try_scrolling): Use it when setting scroll_limit.
10963 Limit scrolling to 100 screen lines.
63696a73
EZ
10964 (redisplay_window): Even when falling back on "recentering",
10965 position point in the window according to scroll-conservatively,
10966 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10967
10968 (try_scrolling): When point is above the window, allow searching
10969 as far as scroll_max, or one screenful, to compute vertical
10970 distance from PT to the scroll margin position. This prevents
10971 try_scrolling from unnecessarily failing when
10972 scroll-conservatively is set to a value slightly larger than the
10973 window height. Clean up the case of PT below the margin at bottom
10974 of window: scroll_max can no longer be INT_MAX. When aggressive
10975 scrolling is in use, don't let point enter the opposite scroll
10976 margin as result of the scroll.
10977 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
10978 threshold of 100 lines for never-recentering scrolling.
10979
e4cc2dfc
JB
109802011-03-31 Juanma Barranquero <lekktu@gmail.com>
10981
10982 * dispextern.h (move_it_by_lines):
10983 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10984 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10985 (message_log_check_duplicate): Remove parameters `prev_bol' and
10986 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10987 (redisplay_internal): Remove parameter `preserve_echo_area',
10988 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10989
10990 * indent.c (Fvertical_motion):
10991 * window.c (window_scroll_pixel_based, Frecenter):
10992 Don't pass `need_y_p' to `move_it_by_lines'.
10993
1c470562
SM
109942011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10995
44f230aa
SM
10996 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10997 steal a few bits to be more compact.
10998 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10999 Remove unneeded casts.
11000
1c470562
SM
11001 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11002
888adce9
ZK
110032011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11004
11005 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11006 binding" message (bug#7967).
11007
f838ed7b
PE
110082011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11009
77861b95
PE
11010 Fix more problems found by GCC 4.6.0's static checks.
11011
de6dbc14
PE
11012 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11013 Remove unused local var.
11014
f838ed7b
PE
11015 * editfns.c (Fmessage_box): Remove unused local var.
11016
792c7b2b
PE
11017 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11018 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11019 Omit unused local vars.
c499e557 11020 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11021 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11022 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11023 Omit unused local var.
11024
ba0165e1
PE
11025 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11026 Don't assume string length fits in int.
32ad8845 11027 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11028 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11029
3c59b4c9
PE
11030 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11031 instead of alloca (Bug#8344).
11032
a3eed478 11033 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11034 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11035
eb4d412d
PE
11036 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11037
1658b401
PE
11038 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11039 concerns.
11040
11041 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11042
11043 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11044
9a2c6e05
PE
11045 * keyboard.c (syms_of_keyboard): Use the same style as later
11046 in this function when indexing through an array. This also
11047 works around GCC bug 48267.
11048
03d0a109
PE
11049 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11050
44f730c8
PE
11051 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11052
fe75f926
PE
11053 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11054 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11055
ffa8c828
PE
11056 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11057 This avoids undefined behavior on integer overflow, and is a bit
11058 more convenient anyway since it is compared to a size_t variable.
11059
c5101a77
PE
11060 Variadic C functions now count arguments with size_t, not int.
11061 This avoids an unnecessary limitation on 64-bit machines, which
11062 caused (substring ...) to crash on large vectors (Bug#8344).
11063 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11064 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11065 All variadic functions and their callers changed accordingly.
c5101a77
PE
11066 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11067 * data.c (arith_driver, float_arith_driver): Likewise.
11068 * editfns.c (general_insert_function): Likewise.
11069 * eval.c (struct backtrace.nargs, interactive_p)
11070 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11071 (funcall_lambda, mark_backtrace): Likewise.
11072 * fns.c (concat): Likewise.
11073 * frame.c (x_set_frame_parameters): Likewise.
11074 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11075 0 if not found, not -1. All callers changed.
11076
dd3f25f7
PE
11077 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11078 (stack_copy_size): Now size_t, not int.
11079 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11080
461c2ab9
JB
110812011-03-28 Juanma Barranquero <lekktu@gmail.com>
11082
11083 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11084 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11085 All callers changed.
11086
11087 * lisp.h (multibyte_char_to_unibyte):
11088 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11089 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11090 * character.h (CHAR_TO_BYTE8):
11091 * cmds.c (internal_self_insert):
11092 * editfns.c (general_insert_function):
11093 * keymap.c (push_key_description):
11094 * search.c (Freplace_match):
11095 * xdisp.c (message_dolog, set_message_1): All callers changed.
11096
f6d62986
SM
110972011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11098
11099 * keyboard.c (safe_run_hook_funcall): New function.
11100 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11101 don't set the hook to nil, but remove the offending function instead.
11102 (Qcommand_hook_internal): Remove, unused.
11103 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11104 Vcommand_hook_internal.
11105
11106 * eval.c (enum run_hooks_condition): Remove.
11107 (funcall_nil, funcall_not): New functions.
11108 (run_hook_with_args): Call each function through a `funcall' argument.
11109 Remove `cond' argument, now redundant.
11110 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11111 (Frun_hook_with_args_until_failure): Adjust accordingly.
11112 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11113
1db5b1ad
JB
111142011-03-28 Juanma Barranquero <lekktu@gmail.com>
11115
11116 * dispextern.h (string_buffer_position): Remove declaration.
11117
11118 * print.c (strout): Remove parameter `multibyte', unused since
11119 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11120
11121 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11122 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11123 All callers changed.
11124
11125 * w32.c (_wsa_errlist): Use braces for struct initializers.
11126
11127 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11128 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11129 All callers changed.
11130 (string_buffer_position): Likewise. Also, make static (it's never
11131 used outside xdisp.c).
11132 (cursor_row_p): Remove parameter `w', unused since
11133 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11134 (decode_mode_spec): Remove parameter `precision', introduced during
11135 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11136 All callers changed.
11137
5ffb62aa
JD
111382011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11139
11140 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11141
461c2ab9 111422011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11143
11144 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11145 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11146 (ns_update_auto_hide_menu_bar): New functions.
11147 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11148 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11149 ns_constrain_all_frames.
11150 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11151 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11152
5c380ffb
JD
111532011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11154
11155 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11156
9af30bdf
GM
111572011-03-27 Glenn Morris <rgm@gnu.org>
11158
11159 * syssignal.h: Replace RETSIGTYPE with void.
11160 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11161 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11162 Replace SIGTYPE with void everywhere.
11163 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11164 * s/template.h (SIGTYPE): Remove commented out definition.
11165
e2abce01
JB
111662011-03-26 Eli Zaretskii <eliz@gnu.org>
11167
11168 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11169 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11170
f868cd8a
JB
111712011-03-26 Juanma Barranquero <lekktu@gmail.com>
11172
59eb0929
JB
11173 * w32.c (read_unc_volume): Use parameter `henum', instead of
11174 global variable `wget_enum_handle'.
11175
11176 * keymap.c (describe_vector): Remove parameters `indices' and
11177 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11178 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11179
f868cd8a
JB
11180 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11181
11182 * keyboard.c (timer_check): Remove parameter `do_it_now',
11183 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11184 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11185 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11186
11187 * keyboard.c (read_char):
11188 * w32menu.c (w32_menu_display_help):
11189 * xmenu.c (show_help_event, menu_help_callback):
11190 Adjust calls to `show_help_echo'.
11191
11192 * gtkutil.c (xg_maybe_add_timer):
11193 * keyboard.c (readable_events):
11194 * process.c (wait_reading_process_output):
11195 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11196
11197 * insdel.c (adjust_markers_gap_motion):
11198 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11199 (gap_left, gap_right): Don't call it.
11200
2ecf6fdb
CY
112012011-03-25 Chong Yidong <cyd@stupidchicken.com>
11202
11203 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11204 incurred during fontification.
11205
6b1f9ba4
JB
112062011-03-25 Juanma Barranquero <lekktu@gmail.com>
11207
11208 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11209 (DEFVAR_PER_BUFFER): Don't pass it.
11210
11211 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11212 (scrolling_window): Don't pass it.
11213
0f4a96b5
JB
112142011-03-25 Juanma Barranquero <lekktu@gmail.com>
11215
11216 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11217
11218 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11219 and `suffix'.
11220 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11221 of variables specific to SELinux and computation of `encoded_absname'.
11222
11223 * image.c (XPutPixel): Remove unused variable `height'.
11224
11225 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11226
11227 * unexw32.c (get_section_info): Remove unused variable `section'.
11228
11229 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11230 (system_process_attributes): Remove unused variable `sess'.
11231 (sys_read): Remove unused variable `err'.
11232
11233 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11234 (w32_wnd_proc): Remove unused variable `isdead'.
11235 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11236 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11237 (x_create_tip_frame): Remove unused variable `tem'.
11238
11239 * w32inevt.c (w32_console_read_socket):
11240 Remove unused variable `no_events'.
11241
11242 * w32term.c (x_draw_composite_glyph_string_foreground):
11243 Remove unused variable `width'.
11244
1149507c
JB
112452011-03-24 Juanma Barranquero <lekktu@gmail.com>
11246
11247 * w32term.c (x_set_glyph_string_clipping):
11248 Don't pass uninitialized region to CombineRgn.
11249
9c88f339
JB
112502011-03-23 Juanma Barranquero <lekktu@gmail.com>
11251
11252 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11253 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11254 (Fx_close_connection): Remove unused variable `i'.
11255
11256 * w32font.c (w32font_draw): Return number of glyphs.
11257 (w32font_open_internal): Remove unused variable `i'.
11258 (w32font_driver): Add missing initializer.
11259
11260 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11261 (fill_in_menu): Remove unused variable `items_added'.
11262
11263 * w32term.c (last_mouse_press_frame): Remove static global variable.
11264 (w32_clip_to_row): Remove unused variable `f'.
11265 (x_delete_terminal): Remove unused variable `i'.
11266
11267 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11268 (NOTHING): Remove unused static global variable.
11269 (uniscribe_check_otf): Remove unused variable `table'.
11270 (uniscribe_font_driver): Add missing initializers.
11271
dee091a3
JD
112722011-03-23 Julien Danjou <julien@danjou.info>
11273
11274 * term.c (Fsuspend_tty, Fresume_tty):
11275 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11276 * window.c (temp_output_buffer_show):
11277 * insdel.c (signal_before_change):
11278 * frame.c (Fhandle_switch_frame):
11279 * fileio.c (Fdo_auto_save):
11280 * emacs.c (Fkill_emacs):
11281 * editfns.c (save_excursion_restore):
11282 * cmds.c (internal_self_insert):
11283 * callint.c (Fcall_interactively):
11284 * buffer.c (Fkill_all_local_variables):
11285 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11286 Use Frun_hooks.
0f4a96b5 11287 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11288 unconditionally since it does the check itself.
dee091a3 11289
2c520ab5 112902011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11291
c9c49752
PE
11292 Fix more problems found by GCC 4.5.2's static checks.
11293
8abc3f12
PE
11294 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11295 the first time through the loop, since we know p0 < p1 then.
11296 This also avoids a gcc -Wstrict-overflow warning.
11297
a2d26660
PE
11298 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11299 leading to a memory leak, possible in functions like
11300 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11301 of objects (Bug#8318).
a2d26660 11302
916c72e9
PE
11303 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11304 that could (at least in theory) be that large.
11305
19ab8a18
PE
11306 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11307 This is less likely to overflow, and avoids undefined behavior if
11308 overflow does occur. All callers changed. Use strtoul to scan
11309 for the unsigned long integer.
b7cbbd6f
PE
11310 (pint2hrstr): Simplify and tune code slightly.
11311 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11312
f0641eff
PE
11313 * scroll.c (do_scrolling): Work around GCC bug 48228.
11314 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11315
7f650bb9
PE
11316 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11317 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11318 (validate_x_resource_name): Simplify count usage.
11319 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11320
37dd57d1
PE
11321 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11322 fail (Bug#8306).
81e56e61 11323
699979fc 11324 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11325
401bf9b4
PE
11326 * process.c (Fmake_network_process): Use socklen_t, not int,
11327 where POSIX says socklen_t is required in portable programs.
11328 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11329 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11330 (Fmake_network_process, server_accept_connection):
11331 (wait_reading_process_output, read_process_output):
11332 Likewise.
11333
b93aacde
PE
11334 * process.c: Rename or move locals to avoid shadowing.
11335 (list_processes_1, Fmake_network_process):
11336 (read_process_output_error_handler, exec_sentinel_error_handler):
11337 Rename or move locals.
4dc343ee 11338 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11339 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11340 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11341 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11342 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11343
af8a867c 11344 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11345 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11346 Include tparam.h instead, since it declares them.
af8a867c
PE
11347 * cm.h (PC): Remove extern decl; tparam.h now does this.
11348 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11349 * terminfo.c: Include tparam.h, to check interfaces.
11350 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11351 (tparam): Adjust signature to match interface in tparam.h;
11352 this removes some undefined behavior. Check that outstring and len
11353 are zero, which they always are with Emacs.
11354 * tparam.h (PC, BC, UP): New extern decls.
11355
0248044d 11356 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11357 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11358
8ff096c1 11359 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11360 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11361 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11362 (ftfont_list): Remove unused local.
49eaafba
PE
11363 (get_adstyle_property, ftfont_pattern_entity):
11364 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11365 Rename locals to avoid shadowing.
8ff096c1 11366
e2be39f6
PE
11367 * xfont.c (xfont_list_family): Mark var as initialized.
11368
c9735e30
PE
11369 * xml.c (make_dom): Now static.
11370
8f5201ae
PE
11371 * composite.c (composition_compute_stop_pos): Rename local to
11372 avoid shadowing.
b246f932
PE
11373 (composition_reseat_it): Remove unused locals.
11374 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11375 (composition_update_it): Mark var as initialized.
11b61122
PE
11376 (find_automatic_composition): Mark vars as initialized,
11377 with a FIXME (Bug#8290).
8f5201ae 11378
760fbc2c
PE
11379 character.h: Rename locals to avoid shadowing.
11380 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11381 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11382 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11383 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11384 to avoid shadowing.
11385
ff08eb85
PE
11386 * textprop.c (property_change_between_p): Remove; unused.
11387
fc7bf025
PE
11388 * intervals.c (interval_start_pos): Now static.
11389
235d7abc
PE
11390 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11391
44f230aa
SM
11392 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11393 Rename locals to avoid shadowing.
3e7d6594 11394
50060332
PE
11395 * sound.c (wav_play, au_play, Fplay_sound_internal):
11396 Fix pointer signedness.
d01f234b 11397 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11398 (wav_play): Initialize a variable to 0, to prevent undefined
11399 behavior (Bug#8278).
50060332 11400
c4fc4e30
PE
11401 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11402
918436ed
PE
11403 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11404
c939f91b
PE
11405 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11406 clobbering (Bug#8298).
b9c7f648
PE
11407 * sysdep.c (sys_subshell): Likewise.
11408 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11409
6bd8c144
PE
11410 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11411 This should get cleaned up, so that child_setup has the
11412 same signature on all platforms.
11413
7710357c 11414 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11415 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11416
c59da222
CY
114172011-03-22 Chong Yidong <cyd@stupidchicken.com>
11418
11419 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11420 not to be necessary, and produces flickering.
11421
66b87493
GM
114222011-03-20 Glenn Morris <rgm@gnu.org>
11423
11424 * config.in: Remove file.
11425
45b6f6d5
JB
114262011-03-20 Juanma Barranquero <lekktu@gmail.com>
11427
11428 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11429 are now in src/globals.h.
11430 (syms_of_minibuf): Remove spurious & from previous change.
11431
cd394be1 114322011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11433
11434 * minibuf.c (completing-read-function): New variable.
11435 (completing-read-default): Rename from completing-read.
11436 (completing-read): Call completing-read-function.
11437
b14e3e21
CY
114382011-03-19 Juanma Barranquero <lekktu@gmail.com>
11439
11440 * xfaces.c (Fx_load_color_file):
11441 Read color file from absolute filename (bug#8250).
11442
f2b726e6
JB
114432011-03-19 Juanma Barranquero <lekktu@gmail.com>
11444
11445 * makefile.w32-in: Update dependencies.
11446
09f6ff02
EZ
114472011-03-17 Eli Zaretskii <eliz@gnu.org>
11448
11449 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11450
29a6015a
PE
114512011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11452
a3a6c54e
PE
11453 Fix more problems found by GCC 4.5.2's static checks.
11454
b766f867
PE
11455 * process.c (make_serial_process_unwind, send_process_trap):
11456 (sigchld_handler): Now static.
11457
be02381c
PE
11458 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11459 That way, the code declares only the vars that it needs.
11460 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11461 * s/cygwin.h (PTY_ITERATION): Likewise.
11462 * s/darwin.h (PTY_ITERATION): Likewise.
11463 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11464
57048744
PE
11465 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11466 * process.c (allocate_pty): Don't declare stb unless it's needed.
11467
7914961c 11468 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
11469 (CONSTANTLIM): Remove; unused.
11470 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11471 Define only if needed.
7914961c 11472
b3967b18
PE
11473 * unexelf.c (unexec): Name an expression,
11474 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11475 Use a different way to cause a compilation error if anyone uses
11476 n rather than nn, a way that does not involve shadowing.
73366a00 11477 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11478
29a6015a
PE
11479 * deps.mk (unexalpha.o): Remove; unused.
11480
43cfc33e 11481 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 11482 * unexec.h: New file.
ce701a33
PE
11483 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11484 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11485 Depend on unexec.h.
11486 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11487 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11488 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 11489 Change as necessary to match prototype in unexec.h.
ce701a33 11490
01f44d5a
PE
11491 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11492 shadowing.
4f63c6bb 11493 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 11494
a6670b0b
PE
11495 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11496 Rename locals to avoid shadowing.
11497
cef2010d 11498 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 11499 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 11500
d4d7173a
PE
11501 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11502
f08b802a
PE
11503 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11504 warning when compiling print.c.
11505
3ddb0639
PE
11506 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11507 instead of using an uninitialized var.
5ad03b97 11508 (font_sort_entities): Mark var as initialized.
3ddb0639 11509
170a2692
PE
11510 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11511
e663c700
PE
11512 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11513 pointers to constants.
89bc529a 11514 (font_parse_fcname): Remove unused vars.
7b81e2d0 11515 (font_delete_unmatched): Now static.
ea838e10 11516 (font_get_spec): Remove; unused.
13a547c6
PE
11517 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11518 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11519 Rename or move locals to avoid shadowing.
e663c700 11520
2a80c887 11521 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11522 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11523
1384fa33 11524 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11525 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11526
8b2c52e9
PE
11527 * alloc.c (mark_backtrace): Move decl from here ...
11528 * lisp.h: ... to here, so that it can be checked.
11529
475545b5 11530 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11531 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11532 (lisp_indirect_variable): Name an expression,
11533 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11534 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11535
b1349114 11536 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11537 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11538 Use const pointer when appropriate.
b1349114 11539
a2928364
PE
11540 * lisp.h (get_system_name, get_operating_system_release):
11541 Move decls here, to check interfaces.
11542 * process.c (get_operating_system_release): Move decl to lisp.h.
11543 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11544 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11545 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11546 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11547 (Fformat_time_string, Fencode_time, Finsert_char):
11548 (Ftranslate_region_internal, Fformat):
11549 Rename or remove local vars to avoid shadowing.
9710023e 11550 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11551
a415e694
PE
11552 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11553 avoid shadowing.
11554
8ef4622d
PE
11555 * lisp.h (eassert): Check that the argument compiles, even if
11556 ENABLE_CHECKING is not defined.
11557
946f9a5b
PE
11558 * data.c (Findirect_variable): Name an expression, to avoid
11559 gcc -Wbad-function-cast warning.
112396d6 11560 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11561 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11562 (Fmake_variable_buffer_local, Fmake_local_variable):
11563 Mark variables as initialized.
52746918 11564 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11565
e5aab7e7 11566 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11567 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11568 Rename locals to avoid shadowing.
dff45157
PE
11569 (mark_stack): Move local variables into the #ifdef region where
11570 they're used.
7bc26fdb
PE
11571 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11572 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11573 needed otherwise.
11574 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11575 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11576 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11577
e5aab7e7
PE
11578 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11579 avoids undefined behavior in theory.
11580
4da60324
PE
11581 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11582
88043301
PE
11583 Use functions, not macros, for up- and down-casing (Bug#8254).
11584 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11585 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11586 to use the following functions instead of these macros.
11587 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11588 EMACS_INT, since callers assume the returned value fits in int.
11589 (upcase1): Likewise, for UPCASE_TABLE.
11590 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11591 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11592 the race-condition problem in the old DOWNCASE.
88043301 11593
19ed5445
PE
11594 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11595 Rename locals to avoid shadowing.
11596 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
11597 (regex_compile, re_search_2, re_match_2_internal):
11598 Remove unused local vars.
952db0d7
PE
11599 (FREE_VAR): Rewrite so as not to use empty "else",
11600 which gcc can warn about.
da053e48 11601 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
11602 (RETALLOC_IF): Define only if needed.
11603 (WORDCHAR_P): Likewise. This one is never needed, but is used
11604 only in a comment talking about a compiler bug, so put inside
11605 the #if 0 of that comment.
11606 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11607 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11608 Remove; unused.
19ed5445 11609
1f3561e4 11610 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
11611 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11612 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 11613
ded6f8f7
PE
11614 * search.c (simple_search): Remove unused var.
11615
dbd37a95
PE
11616 * dired.c (compile_pattern): Move decl from here ...
11617 * lisp.h: ... to here, so that it can be checked.
11618 (struct re_registers): New forward decl.
11619
7e47afad
PE
11620 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11621
85f24f61
PE
11622 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11623 All uses changed.
11624 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11625 Rename locals to avoid shadowing.
5671df8f 11626 (Fvertical_motion): Mark locals as initialized.
85f24f61 11627
181aa2be 11628 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 11629 (casify_region): Mark local as initialized.
181aa2be 11630
930d429c
PE
11631 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11632
7082eac6
PE
11633 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11634 New macros, so that the caller can use some names other than
11635 gcpro1, gcpro2, etc.
11636 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11637 of the new macros.
11638 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11639 argument, for consistency with GCPRO2_VAR, etc: it is now the
11640 prefix of the variable, not the variable itself. All uses
11641 changed.
38b2c076
PE
11642 * dired.c (directory_files_internal, file_name_completion):
11643 Rename locals to avoid shadowing.
11644
15206ed9
PE
11645 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11646 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11647 dired.c's scmp function, had undefined behavior.
11648 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11649 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11650 * buffer.h: ... to here, because these macros use current_buffer,
11651 and the new implementation with inline functions needs to have
11652 current_buffer in scope now, rather than later when the macros
11653 are used.
11654 (downcase, upcase1): New static inline functions.
11655 (DOWNCASE, UPCASE1): Reimplement using these functions.
11656 This avoids undefined behavior in expressions like
11657 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11658 from race conditions in accessing the global variables
11659 case_temp1 and case_temp2.
11660 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11661 * lisp.h (case_temp1, case_temp2): Remove their decls.
11662 * character.h (ASCII_CHAR_P): Move from here ...
11663 * lisp.h: ... to here, so that the inline functions mentioned
11664 above can use them.
11665
4a6bea26
PE
11666 * dired.c (directory_files_internal_unwind): Now static.
11667
f14b7e14
PE
11668 * fileio.c (file_name_as_directory, directory_file_name):
11669 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11670 Now static.
2893f146
PE
11671 (file_name_as_directory): Use const pointers when appropriate.
11672 (Fexpand_file_name): Likewise. In particular, newdir might
11673 point at constant storage, so make it a const pointer.
fd4ead52 11674 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
11675 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11676 signedness issues.
f839df0c
PE
11677 (Fset_file_times, Finsert_file_contents, auto_save_error):
11678 Rename locals to avoid shadowing.
f14b7e14 11679
5716756e 11680 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11681 (Ftry_completion, Fall_completions): Rename or remove locals
11682 to avoid shadowing.
5716756e 11683
b4c3046a
PE
11684 * marker.c (bytepos_to_charpos): Remove; unused.
11685
b45db522
PE
11686 * lisp.h (verify_bytepos, count_markers): New decls,
11687 so that gcc does not warn that these functions aren't declared.
11688
85876d07
PE
11689 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11690 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11691 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11692 (copy_text): Remove unused local var.
85876d07 11693
03d78a21 11694 * filelock.c (within_one_second): Now static.
b3dd38ab 11695 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11696
5df8f01b
PE
11697 * buffer.c (fix_overlays_before): Mark locals as initialized.
11698 (fix_start_end_in_overlays): Likewise. This function should be
11699 simplified by using pointers-to-pointers, but that's a different
11700 matter.
b1d876f1 11701 (switch_to_buffer_1): Now static.
8f54f30a
PE
11702 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11703 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11704
a70072c9 11705 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11706 Fix pointer signedness issue.
edced198
PE
11707 (sys_subshell): Mark local as volatile if checking for lint,
11708 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11709 (MAXPATHLEN): Define only if needed.
a70072c9 11710
a0977c44
PE
11711 * process.c (serial_open, serial_configure): Move decls from here ...
11712 * systty.h: ... to here, so that they can be checked.
11713
a884fdcc
PE
11714 * fns.c (get_random, seed_random): Move extern decls from here ...
11715 * lisp.h: ... to here, so that they can be checked.
11716
604efe86 11717 * sysdep.c (reset_io): Now static.
b8950c94 11718 (wait_for_termination_signal): Remove; unused.
604efe86 11719
38fc62d9
PE
11720 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11721 (copy_keymap_item, append_key, push_text_char_description):
11722 Now static.
1004a21a 11723 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11724 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11725 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11726 (describe_map_tree):
11727 Rename locals to avoid shadowing.
38fc62d9 11728
2f2650da
PE
11729 * keyboard.c: Declare functions static if they are not used elsewhere.
11730 (echo_char, echo_dash, cmd_error, top_level_2):
11731 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11732 (read_char, kbd_buffer_get_event, make_lispy_position):
11733 (make_lispy_event, make_lispy_movement, apply_modifiers):
11734 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11735 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11736 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11737 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11738 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11739
a053e86c 11740 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11741 (mark_kboards): Move decl here ...
11742 * alloc.c (mark_kboards): ... from here.
a053e86c 11743
4752793e
PE
11744 * lisp.h (force_auto_save_soon): New decl.
11745
74f10ca7 11746 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11747 (DEFINE_DUMMY_FUNCTION): New macro.
11748 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11749 Use it.
c03cd23f
PE
11750 (main): Add casts to avoid warnings
11751 if GCC considers string literals to be constants.
74f10ca7 11752
022e70d4
PE
11753 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11754
59d6fe83
PE
11755 * dbusbind.c: Pointer signedness fixes.
11756 (xd_signature, xd_append_arg, xd_initialize):
11757 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11758 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11759 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11760 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11761
78320123
PE
11762 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11763 if GCC considers string literals to be constants.
49cebcca 11764 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11765
35ac2a97
SM
117662011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11767
fb103ca9
SM
11768 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11769 (print_preprocess, print_object): New macro to fix last change.
11770
35ac2a97
SM
11771 * print.c (print_preprocess): Don't forget font objects.
11772
62973b41
JB
117732011-03-16 Juanma Barranquero <lekktu@gmail.com>
11774
11775 * emacs.c (USAGE3): Doc fixes.
11776
0e48bb22
AS
117772011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11778
11779 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11780 structure.
11781
7684e57b
JB
117822011-03-14 Juanma Barranquero <lekktu@gmail.com>
11783
11784 * lisp.h (VWindow_system, Qfile_name_history):
11785 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11786 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11787 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11788
11789 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11790 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11791
11792 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11793 * w32console.c (detect_input_pending, read_input_pending)
11794 (encode_terminal_code):
11795 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11796 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11797 (w32_system_caret_y, Qfile_name_history):
11798 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11799 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11800 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11801 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11802 * w32proc.c (Qlocal, report_file_error):
11803 * w32term.c (Vwindow_system, updating_frame):
11804 * w32uniscribe.c (initialized, uniscribe_font_driver):
11805 Remove unneeded extern declarations.
11806
2aa46d6c
CY
118072011-03-14 Chong Yidong <cyd@stupidchicken.com>
11808
c96bbc66 11809 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11810
cffc6f3b
CY
118112011-03-13 Chong Yidong <cyd@stupidchicken.com>
11812
11813 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11814 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11815 These macros can no longer be used for assignment.
11816
44f230aa
SM
11817 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11818 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11819 (record_buffer_markers, fetch_buffer_markers): New functions for
11820 recording and fetching special buffer markers.
11821 (set_buffer_internal_1, set_buffer_temp): Use them.
11822
11823 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11824
11825 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11826
11827 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11828 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11829
11830 * xdisp.c (hscroll_window_tree):
11831 (reconsider_clip_changes): Use PT instead of BUF_PT.
11832
d251f04b
EZ
118332011-03-13 Eli Zaretskii <eliz@gnu.org>
11834
11835 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11836 $(EMACS_ROOT)/lib/intprops.h.
11837
f0c77cd1
PE
118382011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11839
3eca4629
PE
11840 Fix more problems found by GCC 4.5.2's static checks.
11841
7c86ee98
PE
11842 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11843 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11844 (xg_free_frame_widgets): Make it clear that a local variable is
11845 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11846 (gdk_window_get_screen): Make it clear that this macro is needed
11847 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11848 (int_gtk_range_get_value): New function, which avoids a diagnostic
11849 from gcc -Wbad-function-cast.
11850 (xg_set_toolkit_scroll_bar_thumb): Use it.
11851 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11852 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11853 (get_utf8_string, xg_get_file_with_chooser):
11854 Rename locals to avoid shadowing.
11855 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11856
41729b81
PE
11857 * xgselect.c (xg_select): Remove unused var.
11858
f0c77cd1
PE
11859 * image.c (four_corners_best): Mark locals as initialized.
11860 (gif_load): Initialize transparent_p to zero (Bug#8238).
11861 Mark another local as initialized.
ec6cf4c6 11862 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11863
ce0ad53d 11864 * image.c (clear_image_cache): Now static.
d5d5a617 11865 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11866 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11867 (x_edge_detection): Remove unnecessary cast that
11868 gcc -Wbad-function-cast diagnoses.
2037898d 11869 (gif_load): Fix pointer signedness.
6ae141d6
PE
11870 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11871 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11872
33383987 118732011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11874
d32df629
PE
11875 Improve quality of tests for time stamp overflow.
11876 For example, without this patch (encode-time 0 0 0 1 1
11877 1152921504606846976) returns the obviously-bogus value (-948597
11878 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11879 reports time overflow. See
11880 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11881 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11882 * editfns.c: Include limits.h and intprops.h.
11883 (TIME_T_MIN, TIME_T_MAX): New macros.
11884 (time_overflow): Move earlier, to before first use.
11885 (hi_time, lo_time): New functions, for an accurate test for
11886 out-of-range times.
11887 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11888 (Fget_internal_run_time): Don't assume time_t fits in int.
11889 (make_time): Use list2 instead of Fcons twice.
11890 (Fdecode_time): More accurate test for out-of-range times.
11891 (check_tm_member): New function.
11892 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
11893 (lisp_time_argument): Don't rely on undefined left-shift and
11894 right-shift behavior when checking for time stamp overflow.
8be6f318 11895
fe31d94c
PE
11896 * editfns.c (time_overflow): New function, refactoring common code.
11897 (Fformat_time_string, Fdecode_time, Fencode_time):
11898 (Fcurrent_time_string): Use it.
11899
8be6f318
PE
11900 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11901 * dired.c (make_time): Move to ...
11902 * editfns.c (make_time): ... here.
11903 * systime.h: Note the move.
11904
09d9db2c 119052011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 11906
126bc0dc
YM
11907 * fringe.c (update_window_fringes): Remove unused variables.
11908
c47cbdfd
YM
11909 * unexmacosx.c (copy_data_segment): Also copy __got section.
11910 (Bug#8223)
11911
7ac80be9
EZ
119122011-03-12 Eli Zaretskii <eliz@gnu.org>
11913
c96bbc66 11914 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
11915 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11916 Constify `char *' arguments and their references according to
11917 prototypes in tparam.h.
11918
ecb0f94d 11919 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 11920
7ac80be9
EZ
11921 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11922 Adapt all references accordingly.
11923
11924 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11925
ef1fd07e
TT
119262011-03-11 Tom Tromey <tromey@redhat.com>
11927
11928 * buffer.c (syms_of_buffer): Remove obsolete comment.
11929
7ef4b50c
EZ
119302011-03-11 Eli Zaretskii <eliz@gnu.org>
11931
11932 * termhooks.h (encode_terminal_code): Declare prototype.
11933
11934 * msdos.c (encode_terminal_code): Don't declare prototype.
11935
11936 * term.c (encode_terminal_code): Now external again, used by
11937 w32console.c and msdos.c.
11938
44f230aa
SM
11939 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11940 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 11941
4b1ec863 119422011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 11943
1714f52b 11944 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 11945
4b1ec863
PE
11946 * fringe.c (update_window_fringes): Mark locals as initialized
11947 (Bug#8227).
11948 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 11949
524c7aa6
PE
11950 * alloc.c (mark_fringe_data): Move decl from here ...
11951 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11952 to check its interface.
11953 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11954
a5c0af81 11955 * fontset.c (free_realized_fontset): Now static.
7519b8cd 11956 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 11957 (fontset_font): Mark local as initialized.
a9a06e0b 11958 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 11959
b4716021
PE
11960 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11961
811e9bac 11962 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 11963 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
11964 (x_own_selection, Fx_disown_selection_internal): Rename locals
11965 to avoid shadowing.
11966 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 11967
7e3ab302
PE
11968 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11969 so that the caller can use some name other than gcpro1.
11970 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
11971 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11972 (Fx_backspace_delete_keys_p):
11973 Use them to avoid shadowing, and rename vars to avoid shadowing.
11974 (x_decode_color, x_set_name, x_window): Now static.
6b437900 11975 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 11976 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
11977 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11978 Remove unused locals.
7e3ab302
PE
11979 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11980 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11981 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11982 macros.
f78faa98 11983
e2b13473
PE
11984 * xterm.h (x_mouse_leave): New decl.
11985
77f23912
PE
11986 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11987 Remove unused functions.
cdf4ba58
PE
11988 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11989 (x_calc_absolute_position): Now static.
7411c686 11990 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 11991 Don't declare local "event" unless it's used.
ed7bf3a5
PE
11992 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11993 unless they are used.
38d0b34a
PE
11994 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11995 (x_fatal_error_signal): Remove; not used.
a6067996
PE
11996 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11997 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11998 (x_error_catcher, x_connection_closed, x_error_handler):
11999 (x_error_quitter, xembed_send_message, x_iconify_frame):
12000 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12001 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12002 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12003
44f230aa
SM
12004 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12005 Rename or move locals to avoid shadowing.
6b463e58 12006 (tty_defined_color, merge_face_heights): Now static.
5967d051 12007 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12008 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12009 does not deduce is never used uninitialized.
73719eba
PE
12010 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12011 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12012
426994c3 12013 * terminal.c (store_terminal_param): Now static.
5489860b 12014
032f1620 12015 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12016 (set_frame_menubar): Remove unused local.
d4323972 12017 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12018 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12019 since they might point to immutable storage.
281585b0
PE
12020 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12021 since it's unused otherwise.
032f1620 12022
367c19e5 12023 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12024 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12025 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12026 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12027 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12028 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12029 does not deduce are never used uninitialized.
70739cbe 12030
07b48fa9
PE
12031 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12032
8868a238 12033 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12034 * window.c (window_loop, size_window):
12035 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12036
7e5cf297 12037 * window.c (display_buffer): Now static.
d6550a9f
PE
12038 (size_window): Mark variables that gcc -Wuninitialized
12039 does not deduce are never used uninitialized.
a586633d
PE
12040 * window.h (check_all_windows): New decl, to forestall
12041 gcc -Wmissing-prototypes diagnostic.
5b555da1 12042 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12043
f6095868
PE
12044 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12045 shadowing.
12046 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12047 Include <limits.h>.
12048 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12049 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12050 (load_charset_map): Mark variables that gcc -Wuninitialized
12051 does not deduce are never used uninitialized.
53df7c11 12052 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12053
f38b440c
PE
12054 * coding.c (coding_set_source, coding_set_destination):
12055 Use "else { /* comment */ }" rather than "else /* comment */;"
12056 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12057 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12058 a block, when the outer 'i' will do.
12059 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12060 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12061 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12062 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12063 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12064 Rename locals to avoid shadowing.
12065 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12066 * coding.c (emacs_mule_char, encode_invocation_designation):
12067 Now static, since they're not used elsewhere.
413bb2db 12068 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12069 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12070 (decode_coding_emacs_mule): Mark variables that gcc
12071 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12072 (detect_coding_iso_2022): Initialize a local variable that might
12073 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12074 this initialization is needed. (Bug#8211)
5f58e762
PE
12075 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12076 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12077 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12078 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12079 Remove unused macros.
f38b440c 12080
232b38b9 12081 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12082 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12083 * character.c (string_count_byte8): Likewise.
232b38b9 12084
fb90da1b
PE
12085 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12086 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12087
fb93dbc2
PE
12088 * chartab.c (copy_sub_char_table): Now static, since it's not used
12089 elsewhere.
5c156ace
PE
12090 (sub_char_table_ref_and_range, char_table_ref_and_range):
12091 Rename locals to avoid shadowing.
bbcd0949 12092 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12093
7d3b3862 12094 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12095 (BIDI_BOB): Remove unused macro.
7d3b3862 12096
6be7d3da
PE
12097 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12098 deduce are never used uninitialized.
c2ed9c8b 12099 * term.c (encode_terminal_code): Likewise.
6be7d3da 12100
75f8807f 12101 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12102
50938595
PE
12103 * tparam.h: New file.
12104 * term.c, tparam.h: Include it.
12105 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12106 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12107 Move these decls to tparam.h, and make them agree with what
12108 is actually in tparam.c. The previous trick of using incompatible
12109 decls in different modules does not conform to the C standard.
12110 All callers of tparam changed to use tparam's actual API.
12111 * tparam.c (tparam1, tparam, tgoto):
12112 Use const pointers where appropriate.
12113
fbceeba2
PE
12114 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12115 * cm.h (struct cm): Likewise.
12116 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12117 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12118 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12119 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12120 (turn_on_face, init_tty): Likewise.
12121 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12122
7f3f1250
PE
12123 * term.c (term_mouse_position): Rename local to avoid shadowing.
12124
e6ca6543
PE
12125 * alloc.c (mark_ttys): Move decl from here ...
12126 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12127
c40f8d15
AS
121282011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12129
12130 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12131
cfe0661d
JB
121322011-03-09 Juanma Barranquero <lekktu@gmail.com>
12133
12134 * search.c (compile_pattern_1): Remove argument regp, unused since
12135 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12136 (compile_pattern): Don't pass it.
12137
0afb4571
J
121382011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12139
12140 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12141 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12142 for ! HAVE_GTK3.
12143 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12144
12145 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12146
12147 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12148 gdk_window_get_screen, gdk_window_get_geometry,
12149 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12150 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12151 (xg_get_pixbuf_from_pixmap): New function.
12152 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12153 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12154 Call xg_get_pixbuf_from_pixmap instead of
12155 gdk_pixbuf_get_from_drawable.
12156 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12157 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12158 (xg_check_special_colors): Use GtkStyleContext and its functions
12159 for HAVE_GTK3.
12160 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12161 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12162 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
12163 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12164 Call gtk_widget_get_preferred_size.
0afb4571
J
12165 (xg_frame_resized): gdk_window_get_geometry only takes 5
12166 parameters.
44f230aa
SM
12167 (xg_win_to_widget, xg_event_is_for_menubar):
12168 Call gdk_x11_window_lookup_for_display.
0afb4571
J
12169 (xg_set_widget_bg): New function.
12170 (delete_cb): New function.
895009e1 12171 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 12172 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
12173 (xg_set_background_color): Call xg_set_widget_bg.
12174 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12175 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12176 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12177 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12178 if ! HAVE_GTK3.
12179 (update_frame_tool_bar): Call gtk_widget_hide.
12180 (xg_initialize): Use GDK_KEY_g.
12181
12182 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12183 if ! HAVE_GTK3
12184 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12185
12186 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12187 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12188 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12189
1c2cc4ef
JB
121902011-03-08 Juanma Barranquero <lekktu@gmail.com>
12191
12192 * w32xfns.c (select_palette): Check success of RealizePalette against
12193 GDI_ERROR, not zero.
12194
33383987 12195See ChangeLog.11 for earlier changes.
aac0c6e3
MR
12196
12197;; Local Variables:
12198;; coding: utf-8
aac0c6e3
MR
12199;; End:
12200
2f097256 12201 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
12202
12203 This file is part of GNU Emacs.
12204
12205 GNU Emacs is free software: you can redistribute it and/or modify
12206 it under the terms of the GNU General Public License as published by
12207 the Free Software Foundation, either version 3 of the License, or
12208 (at your option) any later version.
12209
12210 GNU Emacs is distributed in the hope that it will be useful,
12211 but WITHOUT ANY WARRANTY; without even the implied warranty of
12212 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12213 GNU General Public License for more details.
12214
12215 You should have received a copy of the GNU General Public License
12216 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.