Fix title and toolbar not shown in OSX 10.7.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
a258d627
JD
12011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2
3 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4 for OSX >= 10.7.
5
b6d5a689
EZ
62011-07-22 Eli Zaretskii <eliz@gnu.org>
7
0f74f785
EZ
8 Fix a significant slow-down of cursor motion with C-n, C-p,
9 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
10 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 11 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
12 (next_element_from_buffer): Call compute_stop_pos_backwards to
13 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
14 base_level_stop.
15 (reseat): Don't look for prev_stop, as that could mean a very long
16 run.
17 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
18 <cached_disp_overlay_modiff>: Cache for last found display string
19 position.
551918c1 20 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
21 about the same buffer in the same area of character positions, and
22 the buffer wasn't changed since the time the display string
23 position was cached.
551918c1 24
b2d0c91a
EZ
252011-07-22 Eli Zaretskii <eliz@gnu.org>
26
27 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
28 is an integer, which is important for empty lines. (Bug#9149)
29
043604ee
CY
302011-07-22 Chong Yidong <cyd@stupidchicken.com>
31
32 * frame.c (Fmodify_frame_parameters): In tty case, update the
33 default face if necessary (Bug#4238).
34
da4adb04
CY
352011-07-21 Chong Yidong <cyd@stupidchicken.com>
36
37 * editfns.c (Fstring_to_char): No need to explain what a character
38 is in the docstring (Bug#6576).
39
9abd0532
LMI
402011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
41
42 * xml.c (parse_region): Make sure we always return a tree.
43
36881d16
HK
442011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
45
46 * xml.c (parse_region): If a document contains only comments,
47 return that, too.
48
1e98674d
LMI
492011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
50
51 * xml.c (make_dom): Return comments, too.
52
590bd467
PE
532011-07-19 Paul Eggert <eggert@cs.ucla.edu>
54
55 Port to OpenBSD.
56 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
57 and the surrounding thread.
58 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
59 rather than fgets, and retry after EINTR. Otherwise, 'emacs
60 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
61 timer goes off.
62 * s/openbsd.h (BROKEN_SIGIO): Define.
63 * unexelf.c (unexec) [__OpenBSD__]:
64 Don't update the .mdebug section of the Alpha COFF symbol table.
65
f41628b2
LMI
662011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
67
68 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
69 (bug#8460).
70
b59b67c5
PE
712011-07-18 Paul Eggert <eggert@cs.ucla.edu>
72
15e3a074
PE
73 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
74 This fixes some race conditions on the permissions of any newly
75 created file.
76
41bed37d
PE
77 * alloc.c (valid_pointer_p): Use pipe, not open.
78 This fixes some permissions issues when debugging.
79
b59b67c5
PE
80 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
81 If fchown fails to set both uid and gid, try to set just gid,
82 as that is sometimes allowed. Adjust the file's mode to eliminate
83 setuid or setgid bits that are inappropriate if fchown fails.
84
925a6be7
SM
852011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
86
87 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
88 to compare Lisp_Objects.
89 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
90 global_gnutls_log_level, don't mistake it for a Lisp_Object.
91 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
92
52968808
AS
932011-07-17 Andreas Schwab <schwab@linux-m68k.org>
94
0a6a104b
AS
95 * lread.c (read_integer): Unread even EOF character.
96 (read1): Likewise. Properly record start position of symbol.
97
52968808
AS
98 * lread.c (read1): Read `#:' as empty uninterned symbol if no
99 symbol character follows.
100
9e381cdd
PE
1012011-07-17 Paul Eggert <eggert@cs.ucla.edu>
102
103 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
104 This works around a problem with the previous change to Fcopy_file.
105 Recent glibc declares fchown with __attribute__((warn_unused_result)),
106 and without this change, GCC might complain about discarding
107 fchown's return value.
108
b5641435
JB
1092011-07-16 Juanma Barranquero <lekktu@gmail.com>
110
111 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
112
a8031457
PE
1132011-07-16 Paul Eggert <eggert@cs.ucla.edu>
114
115 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
116
dd889327
LMI
1172011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
118
750c33f7
LMI
119 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
120 it's used from the C level.
121
dd889327
LMI
122 * process.c: Use the same condition for POLL_FOR_INPUT in both
123 keyboard.c and process.c (bug#1858).
124
87e86684
LM
1252011-07-09 Lawrence Mitchell <wence@gmx.li>
126
127 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
128 (Fgnutls_boot): Use it.
129
64348f40
AS
1302011-07-15 Andreas Schwab <schwab@linux-m68k.org>
131
132 * doc.c (Fsubstitute_command_keys): Revert last change.
133
1d698799
LMI
1342011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
135
f863868c
LMI
136 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
137 quotes the next character, and doesn't affect other longer
138 sequences (bug#8935).
139
1d698799
LMI
140 * lread.c (syms_of_lread): Clarify that is isn't only
141 `eval-buffer' and `eval-defun' that's affected by
142 `lexical-binding' (bug#8460).
143
aa4b6df6
EZ
1442011-07-15 Eli Zaretskii <eliz@gnu.org>
145
146 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
147 bidi redisplay when a line includes both an image and is
148 truncated.
149
5d856da6
PE
1502011-07-14 Paul Eggert <eggert@cs.ucla.edu>
151
ad6042bb
PE
152 Fix minor problems found by static checking.
153 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
154 (elsz): Now a signed constant, not a size_t var. We prefer signed
155 types to unsigned, to avoid integer comparison confusion. Without
156 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
157 "cannot optimize loop, the loop counter may overflow", a symptom
158 of the confusion.
f00bbb22 159 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
160 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
161
6468f31c
LMI
1622011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
163
49080b10
LMI
164 * search.c (Fre_search_backward): Mention `case-fold-search' in
165 all the re_search_* functions (bug#8138).
166
6468f31c
LMI
167 * keyboard.c (Fopen_dribble_file): Document when the file is
168 closed (bug#8056).
169
c965adc5
EZ
1702011-07-14 Eli Zaretskii <eliz@gnu.org>
171
df9733bf
EZ
172 * bidi.c (bidi_dump_cached_states): Fix format of displaying
173 bidi_cache_idx.
174
0bb23927
EZ
175 Support bidi reordering of display and overlay strings.
176 * xdisp.c (compute_display_string_pos)
177 (compute_display_string_end): Accept additional argument STRING.
178 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
179 (reseat_to_string): Initialize bidi_it->string.s and
180 bidi_it->string.schars.
181 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
182 NULL (avoids a crash in bidi_paragraph_init). Initialize
183 itb.string.lstring.
184 (init_iterator): Call bidi_init_it only of a valid
185 buffer position was specified. Initialize paragraph_embedding to
186 L2R.
187 (reseat_to_string): Initialize the bidi iterator.
188 (display_string): If we need to ignore text properties of
189 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
190 original value of -1 will not work with bidi.)
191 (compute_display_string_pos): First arg is now struct
192 `text_pos *'; all callers changed. Support display properties on
193 Lisp strings.
194 (compute_display_string_end): Support display properties on Lisp
195 strings.
196 (init_iterator, reseat_1, reseat_to_string): Initialize the
197 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
198 when iterating on a string not from display properties).
199 (compute_display_string_pos, compute_display_string_end): Fix
200 calculation of the object to scan. Fixes an error when using
201 arrow keys.
202 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
203 base_level_stop; instead, set base_level_stop to BEGV. Fixes
204 crashes in vertical-motion.
205 (next_element_from_buffer): Improve commentary for when
206 the iterator is before prev_stop.
207 (init_iterator): Initialize bidi_p from the default value of
208 bidi-display-reordering, not from buffer-local value. Use the
209 buffer-local value only if initializing for buffer iteration.
210 (handle_invisible_prop): Support invisible properties on strings
211 that are being bidi-reordered.
212 (set_iterator_to_next): Support bidi reordering of C strings and
213 Lisp strings.
214 (next_element_from_string): Support bidi reordering of Lisp
215 strings.
216 (handle_stop_backwards): Support Lisp strings as well.
217 (display_string): Support display of R2L glyph rows. Use
218 IT_STRING_CHARPOS when displaying from a Lisp string.
219 (init_iterator): Don't initialize it->bidi_p for strings
220 here.
221 (reseat_to_string): Initialize it->bidi_p for strings here.
222 (next_element_from_string, next_element_from_c_string)
223 (next_element_from_buffer): Add xassert's for correspondence
224 between IT's object being iterated and it->bidi_it.string
225 structure.
226 (face_before_or_after_it_pos): Support bidi iteration.
227 (next_element_from_c_string): Handle the case of the first string
228 character that is not the first one in the visual order.
229 (get_visually_first_element): New function, refactored from common
230 parts of next_element_from_buffer, next_element_from_string, and
231 next_element_from_c_string.
232 (tool_bar_lines_needed, redisplay_tool_bar)
233 (display_menu_bar): Force left-to-right direction. Add a FIXME
234 comment for making that be controlled by a user option.
235 (push_it, pop_it): Save and restore the state of the
236 bidi iterator. Save and restore the bidi_p flag.
237 (pop_it): Iterate out of display property for string iteration as
238 well.
239 (iterate_out_of_display_property): Support iteration over strings.
240 (handle_single_display_spec): Set up it->bidi_it for iteration
241 over a display string, and call bidi_init_it.
242 (handle_single_display_spec, next_overlay_string)
243 (get_overlay_strings_1, push_display_prop): Set up the bidi
244 iterator for displaying display or overlay strings.
245 (forward_to_next_line_start): Don't use the shortcut if
246 bidi-iterating.
247 (back_to_previous_visible_line_start): If handle_display_prop
248 pushed the iterator stack, restore the internal state of the bidi
249 iterator by calling bidi_pop_it same number of times.
250 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
251 and we are bidi-iterating, don't decrement the iterator position;
252 instead, set the first_elt flag in the bidi iterator, to produce
253 the same effect.
254 (reseat_1): Remove redundant setting of string_from_display_prop_p.
255 (push_display_prop): xassert that we are iterating a buffer.
256 (push_it, pop_it): Save and restore paragraph_embedding member.
257 (handle_single_display_spec, next_overlay_string)
258 (get_overlay_strings_1, reseat_1, reseat_to_string)
259 (push_display_prop): Set up the `unibyte' member of bidi_it.string
260 correctly. Don't assume unibyte strings are not bidi-reordered.
261 (compute_display_string_pos)
262 (compute_display_string_end): Fix handling the case of C string.
263 (push_it, pop_it): Save and restore from_disp_prop_p.
264 (handle_single_display_spec, push_display_prop): Set the
265 from_disp_prop_p flag.
266 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
267 (pop_it): Call iterate_out_of_display_property only if we are
268 popping after iteration over a string that came from a display
269 property. Fix a typo in popping stretch info. Add an assertion
270 for verifying that the iterator position is in sync with the bidi
271 iterator.
272 (handle_single_display_spec, get_overlay_strings_1)
273 (push_display_prop): Fix initialization of paragraph direction for
274 string when that of the parent object is not yet determined.
275 (reseat_1): Call bidi_init_it to resync the bidi
276 iterator with IT's position. (Bug#7616)
277 (find_row_edges): If ROW->start.pos gives position
278 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
279 (handle_stop, back_to_previous_visible_line_start, reseat_1):
280 Reset the from_disp_prop_p flag.
281 (SAVE_IT, RESTORE_IT): New macros.
282 (pos_visible_p, face_before_or_after_it_pos)
283 (back_to_previous_visible_line_start)
284 (move_it_in_display_line_to, move_it_in_display_line)
285 (move_it_to, move_it_vertically_backward, move_it_by_lines)
286 (try_scrolling, redisplay_window, display_line): Use them when
287 saving a temporary copy of the iterator and restoring it back.
288 (back_to_previous_visible_line_start, reseat_1)
289 (init_iterator): Empty the bidi cache "stack".
290 (move_it_in_display_line_to): If iterator ended up at
291 EOL, but we never saw any buffer positions smaller than
292 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
293 motion in bidi-reordered lines.
294 (move_it_in_display_line_to): Record prev_method and prev_pos
295 immediately before the call to set_iterator_to_next. Fixes cursor
296 motion in bidi-reordered lines with stretch glyphs and strings
297 displayed in margins. (Bug#8133) (Bug#8867)
298 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
299 TO_CHARPOS.
300 (pos_visible_p): Support positions in bidi-reordered lines. Save
301 and restore bidi cache.
302
303 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
304 (bidi_paragraph_info): Delete unused struct.
305 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
306 (bidi_cache_start): New variable.
307 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
308 to zero.
309 (bidi_cache_fetch_state, bidi_cache_search)
310 (bidi_cache_find_level_change, bidi_cache_iterator_state)
311 (bidi_cache_find, bidi_peek_at_next_level)
312 (bidi_level_of_next_char, bidi_find_other_level_edge)
313 (bidi_move_to_visually_next): Compare cache index with
314 bidi_cache_start rather than with zero.
315 (bidi_fetch_char): Accept new argument STRING; all callers
316 changed. Support iteration over a string. Support strings with
317 display properties. Support unibyte strings. Fix the type of
318 `len' according to what STRING_CHAR_AND_LENGTH expects.
319 (bidi_paragraph_init, bidi_resolve_explicit_1)
320 (bidi_resolve_explicit, bidi_resolve_weak)
321 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
322 iteration over a string.
323 (bidi_set_sor_type, bidi_resolve_explicit_1)
324 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
325 can now be zero (for strings); special values 0 and -1 were
326 changed to -1 and -2, respectively.
327 (bidi_char_at_pos): New function.
328 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
329 Call it instead of FETCH_MULTIBYTE_CHAR.
330 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
331 initialized to valid values.
332 (bidi_init_it): Don't initialize charpos and bytepos with invalid
333 values.
334 (bidi_level_of_next_char): Allow the sentinel "position" to pass
335 the test for valid cached positions. Fix the logic for looking up
336 the sentinel state in the cache. GCPRO the Lisp string we are
337 iterating.
338 (bidi_push_it, bidi_pop_it): New functions.
339 (bidi_initialize): Initialize the bidi cache start stack pointer.
340 (bidi_cache_ensure_space): New function, refactored from part of
341 bidi_cache_iterator_state. Don't assume the required size is just
342 one BIDI_CACHE_CHUNK away.
343 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
344 (bidi_count_bytes, bidi_char_at_pos): New functions.
345 (bidi_cache_search): Don't assume bidi_cache_last_idx is
346 always valid if bidi_cache_idx is valid.
347 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
348 is valid if it's going to be used.
349 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
350 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
351 (bidi_cache_find_level_change, bidi_cache_ensure_space)
352 (bidi_cache_iterator_state, bidi_cache_find)
353 (bidi_find_other_level_edge, bidi_cache_start_stack): All
354 variables related to cache indices are now EMACS_INT.
355
0bb23927
EZ
356 * dispextern.h (struct bidi_string_data): New structure.
357 (struct bidi_it): New member `string'. Make flag members be 1-bit
358 fields, and put them last in the struct.
359 (compute_display_string_pos, compute_display_string_end): Update
360 prototypes.
361 (bidi_push_it, bidi_pop_it): Add prototypes.
362 (struct iterator_stack_entry): New members bidi_p,
363 paragraph_embedding, and from_disp_prop_p.
364 (struct it): Member bidi_p is now a bit field 1 bit wide.
365 (bidi_shelve_cache, bidi_unshelve_cache): Declare
366 prototypes.
367
368 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
369 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
370 and vector-like objects.
371
372 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
373 cache around display iteration.
374
375 * window.c (Fwindow_end, window_scroll_pixel_based)
376 (displayed_window_lines, Frecenter): Save and restore the bidi
377 cache around display iteration.
378
3bbd2265
LMI
3792011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
380
381 * editfns.c (Fdelete_region): Clarify the use of the named
382 parameters (bug#6788).
383
adc47434
MR
3842011-07-14 Martin Rudalics <rudalics@gmx.at>
385
386 * indent.c (Fvertical_motion): Set and restore w->pointm when
387 saving and restoring the window's buffer (Bug#9006).
388
837c31f8
LMI
3892011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
390
391 * editfns.c (Fstring_to_char): Clarify just what is returned
392 (bug#6576). Text by Eli Zaretskii.
393
ac389d0c
JB
3942011-07-13 Juanma Barranquero <lekktu@gmail.com>
395
396 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
397
0be0ce47
EZ
3982011-07-13 Eli Zaretskii <eliz@gnu.org>
399
400 * buffer.c (mmap_find): Fix a typo.
401
cd18e7e3
JB
4022011-07-13 Johan Bockgård <bojohan@gnu.org>
403
404 Fix execution of x selection hooks.
405 * xselect.c (Qx_lost_selection_functions)
406 (Qx_sent_selection_functions): New vars.
407 (syms_of_xselect): DEFSYM them.
408 (x_handle_selection_request): Pass Qx_sent_selection_functions
409 rather than Vx_sent_selection_functions to Frun_hook_with_args.
410 (x_handle_selection_clear,x_clear_frame_selections):
411 Pass Qx_lost_selection_functions rather than
412 Vx_lost_selection_functions to Frun_hook_with_args.
413
47ea7f44
PE
4142011-07-13 Paul Eggert <eggert@cs.ucla.edu>
415
ac389d0c 416 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
417 The old code sometimes used this field without initializing it.
418
47ea7f44
PE
419 * alloc.c (gc_sweep): Don't read past end of array.
420 In theory, the old code could also have corrupted Emacs internals,
421 though it'd be very unlikely.
422
bc985c87
AS
4232011-07-12 Andreas Schwab <schwab@linux-m68k.org>
424
425 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 426 argument. (Bug#4026)
bc985c87 427
0cf34688
LMI
4282011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
429
b3dadd76
LMI
430 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
431 key" (bug#4257).
432
0cf34688
LMI
433 * window.c (Fset_window_start): Doc fix (bug#4199).
434 (Fset_window_hscroll): Ditto.
435
270768cd
PE
4362011-07-12 Paul Eggert <eggert@cs.ucla.edu>
437
077e3dda 438 Fix minor new problems caught by GCC 4.6.1.
270768cd 439 * term.c (init_tty): Remove unused local.
490011a6 440 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 441 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 442 not used otherwise.
270768cd 443
b1f58454
CY
4442011-07-12 Chong Yidong <cyd@stupidchicken.com>
445
446 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
447
22b9578d
LMI
4482011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
449
6e70ab07
LMI
450 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
451 are the mini-buffer and the echo area (bug#3320).
452
22b9578d
LMI
453 * term.c (init_tty): Remove support for supdup, c10 and perq
454 terminals, which are no longer supported (bug#1482).
455
8974cc9f
JB
4562011-07-10 Johan Bockgård <bojohan@gnu.org>
457
458 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
459
a560d974
JD
4602011-07-10 Jan Djärv <jan.h.d@swipnet.se>
461
462 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
463 for non-popups (Bug#3642).
464
1dae0f0a
AS
4652011-07-10 Andreas Schwab <schwab@linux-m68k.org>
466
268c2c36 467 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 468 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
469 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
470 * cm.c (losecursor): Likewise.
1dae0f0a
AS
471 * data.c (fmod): Likewise.
472 * dispnew.c (swap_glyphs_in_rows): Likewise.
473 * emacs.c (memory_warning_signal): Likewise.
474 * floatfns.c (float_error): Likewise.
475 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
476 (otf_open, font_otf_capability, generate_otf_features)
477 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
478 Likewise.
479 * image.c (pbm_read_file): Likewise.
480 * indent.c (string_display_width): Likewise.
481 * intervals.c (check_for_interval, search_for_interval)
482 (inc_interval_count, count_intervals, root_interval)
483 (adjust_intervals_for_insertion, make_new_interval): Likewise.
484 * lread.c (defalias): Likewise.
268c2c36 485 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
486 * regex.c (set_image_of_range_1, set_image_of_range)
487 (regex_grow_registers): Likewise.
488 * sysdep.c (strerror): Likewise.
489 * termcap.c (valid_filename_p, tprint, main): Likewise.
490 * tparam.c (main): Likewise.
491 * unexhp9k800.c (run_time_remap, save_data_space)
492 (update_file_ptrs, read_header, write_header, calculate_checksum)
493 (copy_file, copy_rest, display_header): Likewise.
494 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
495 Likewise.
496 * xdisp.c (check_it): Likewise.
497 * xfaces.c (register_color, unregister_color, unregister_colors):
498 Likewise.
499 * xfns.c (print_fontset_result): Likewise.
500 * xrdb.c (member, fatal, main): Likewise.
501
99033785
PE
5022011-07-10 Paul Eggert <eggert@cs.ucla.edu>
503
504 Fix minor problems found by static checking (Bug#9031).
505 * chartab.c (char_table_set_range, map_sub_char_table):
506 Remove unused locals.
507 (uniprop_table): Now static.
508 * composite.c (_work_char): Remove unused static var.
509
9cb2ac56
JB
5102011-07-09 Juanma Barranquero <lekktu@gmail.com>
511
512 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
513
f25661f0
JD
5142011-07-09 Jan Djärv <jan.h.d@swipnet.se>
515
516 * gtkutil.c (qttip_cb): Remove code without function.
517
8278c4fe
EZ
5182011-07-09 Eli Zaretskii <eliz@gnu.org>
519
520 * w32.c (pthread_sigmask): New stub.
521
1692ae2d 5222011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 523
8a6ebd58 524 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
525 sigprocmask is portable only for single-threaded applications, and
526 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
527 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
528 (LIBES): Use it.
529 * callproc.c (Fcall_process):
530 * process.c (create_process):
531 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
532 Use pthread_sigmask, not sigprocmask.
123403e4 533
1b854618
JD
5342011-07-08 Jan Djärv <jan.h.d@swipnet.se>
535
536 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
537 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
538 wrong (Bug#8591).
539
3fe4b549
JD
5402011-07-08 Jan Djärv <jan.h.d@swipnet.se>
541
0ce7e563
JD
542 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
543 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
544 (xg_hide_tooltip): Fix comment.
545
3fe4b549
JD
546 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
547 in registerServicesMenuSendTypes.
548 (validRequestorForSendType): Don't check ns_return_types.
549
550 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
551 ns_return_type.
552
5df75e47
JR
5532011-07-08 Jason Rumney <jasonr@gnu.org>
554
555 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
556 frame struct members of non-existent frames (Bug#6284).
557
699c10bd
JD
5582011-07-08 Jan Djärv <jan.h.d@swipnet.se>
559
4393663b
JD
560 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
561 variable firstTime not needed on OSX >= 10.6.
562 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
563 >= 10.5. Use setKnobProportion, setDoubleValue.
564
565 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
566 (MAC_OS_X_VERSION_10_5): Define if not defined.
567 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
568 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
569 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
570
571 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
572 cString and lossyCString on OSX >= 10.4
573
574 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
575 sizeToFit on OSX >= 10.2.
576
577 * nsimage.m (allocInitFromFile): Don't use deprecated method
578 bestRepresentationForDevice on OSX >= 10.6.
579
580 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
581 to avoid warning.
582
583 * emacs.c: Declare unexec_init_emacs_zone.
584
a63e0781
JD
585 * nsgui.h: Fix compiler warning about gnulib redefining verify.
586
699c10bd
JD
587 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
588
589 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
590 on svcsMenu (Bug#8842).
591
592 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
593 ns_return_types.
594 (Fns_list_services): Just return Qnil on 10.6, code not working there.
595
596 * nsterm.m (QUTF8_STRING): Declare.
597 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
598 (validRequestorForSendType): Return type is (id).
599 Change indexOfObjectIdenticalTo to indexOfObject.
600 Check if we have local selection before returning self (Bug#8842).
601 (writeSelectionToPasteboard): Put local selection into paste board
602 if we have a local selection (Bug#8842).
603 (syms_of_nsterm): DEFSYM QUTF8_STRING.
604
605 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
606 (ns_get_local_selection): Declare.
607
54e10184
LMI
6082011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
609
9888ff71
LMI
610 * keymap.c (describe_map_tree): Don't insert a double newline at
611 the end of the buffer (bug#1169) and return whether we inserted
612 something.
613
54e10184
LMI
614 * callint.c (Fcall_interactively): Change "reading args" to
615 "providing args" to try to clarify what it does (bug#1010).
616
15fa4783
KH
6172011-07-07 Kenichi Handa <handa@m17n.org>
618
619 * composite.c (composition_compute_stop_pos): Ignore a static
620 composition starting before CHARPOS (Bug#8915).
621
622 * xdisp.c (handle_composition_prop): Likewise.
623
a8815b00
EZ
6242011-07-07 Eli Zaretskii <eliz@gnu.org>
625
626 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
627 (Bug#9015)
628
ef7b981d 6292011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
630
631 * character.h (unicode_category_t): New enum type.
632
633 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
634 (Qchar_code_property_table): New variable.
635 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
636 (UNIPROP_COMPRESSED_FORM_P): New macros.
637 (char_table_ascii): Uncompress the compressed values.
638 (sub_char_table_ref): New arg is_uniprop. Callers changed.
639 Uncompress the compressed values.
ac389d0c 640 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
641 (char_table_ref_and_range): Uncompress the compressed values.
642 (sub_char_table_set): New arg is_uniprop. Callers changed.
643 Uncompress the compressed values.
644 (sub_char_table_set_range): Args changed. Callers changed.
645 (char_table_set_range): Adjuted for the above change.
646 (map_sub_char_table): Delete args default_val and parent. Add arg
647 top. Give decoded values to a Lisp function.
648 (map_char_table): Adjusted for the above change. Give decoded
649 values to a Lisp function. Gcpro more variables.
650 (uniprop_table_uncompress)
651 (uniprop_decode_value_run_length): New functions.
652 (uniprop_decoder, uniprop_decoder_count): New variables.
653 (uniprop_get_decoder, uniprop_encode_value_character)
654 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
655 New functions.
656 (uniprop_encoder, uniprop_encoder_count): New variables.
657 (uniprop_get_encoder, uniprop_table)
658 (Funicode_property_table_internal, Fget_unicode_property_internal)
659 (Fput_unicode_property_internal): New functions.
660 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
661 Sunicode_property_table_internal, Sget_unicode_property_internal,
662 and Sput_unicode_property_internal. Defvar_lisp
663 char-code-property-alist.
664
665 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
666 Vunicode_category_table.
667
668 * font.c (font_range): Adjusted for the change of
669 Vunicode_category_table.
670
76b397fb
DN
6712011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
672
673 * m/iris4d.h: Remove file, move contents ...
674 * s/irix6-5.h: ... here.
675
22b4128e
PE
6762011-07-06 Paul Eggert <eggert@cs.ucla.edu>
677
678 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
679 * alloc.c (mark_buffer):
680 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
681 (clone_per_buffer_values): Don't assume that
22b4128e
PE
682 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
683 This isn't true in general, and it's particularly not true
684 if Emacs is configured with --with-wide-int.
685 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
686 New macros, used in the buffer.c change.
687
869795d6
JD
6882011-07-05 Jan Djärv <jan.h.d@swipnet.se>
689
690 * xsettings.c: Use both GConf and GSettings if both are available.
691 (store_config_changed_event): Add comment.
692 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
693 (store_tool_bar_style_changed): New functions.
694 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
695 (struct xsettings): Move font inside HAVE_XFT.
696 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
697 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
698 Move inside HAVE_XFT.
699 (something_changed_gsettingsCB): Renamed from something_changedCB.
700 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
701 also.
702 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
703 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
704 (something_changed_gconfCB): Renamed from something_changedCB.
705 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
706 (parse_settings): Move check for font inside HAVE_XFT.
707 (read_settings, apply_xft_settings): Add comment.
708 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
709 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
710 call store_font_name_changed.
711 (xft_settings_event): Add comment.
712 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
713 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
714 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
715 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
716 (xsettings_initialize): Call init_gsettings last.
717 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
718 comment.
719
d8ed26bd
PE
7202011-07-05 Paul Eggert <eggert@cs.ucla.edu>
721
722 Random fixes. E.g., (random) never returned negative values.
723 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
724 subseconds part to the entropy, as that's a bit more random.
725 Prefer signed to unsigned, since the signedness doesn't matter and
726 in general we prefer signed. When given a limit, use a
727 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
728 latter isn't right if USE_2_TAGS_FOR_INTS.
729 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
730 not 0..VALMASK. Don't discard "excess" bits that random () returns.
731
cabf1cac
SM
7322011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
733
734 * textprop.c (text_property_stickiness):
735 Obey Vtext_property_default_nonsticky.
736 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
737 * w32fns.c (syms_of_w32fns):
738 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
739
6e9b2be9
PE
7402011-07-04 Paul Eggert <eggert@cs.ucla.edu>
741
742 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
743 This is more efficient than Ffile_directory_p and avoids a minor race.
744
90186c68
LMI
7452011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
746
7c301272
LMI
747 * buffer.c (Foverlay_put): Say what the return value is
748 (bug#7835).
749
c4f2d8d4
LMI
750 * fileio.c (barf_or_query_if_file_exists): Check first if the file
751 is a directory before asking whether to use the file name
752 (bug#7564).
ad637907
LMI
753 (barf_or_query_if_file_exists): Make the "File is a directory"
754 error be more correct.
c4f2d8d4 755
90186c68
LMI
756 * fns.c (Frequire): Remove the mention of the .gz files, since
757 that's installation-specific, but keep the mention of
758 `get-load-suffixes'.
759
da64016e
PE
7602011-07-04 Paul Eggert <eggert@cs.ucla.edu>
761
762 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
763 Report string overflow if the output is too long.
764
7d47b580
JB
7652011-07-04 Juanma Barranquero <lekktu@gmail.com>
766
a555cb87
JB
767 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
768 (syms_of_gnutls): Remove duplicate DEFSYM for
769 Qgnutls_bootprop_verify_hostname_error, an error for
770 Qgnutls_bootprop_verify_error (which is no longer used).
771
7d47b580
JB
772 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
773 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
774 Also (re)move comments that are misplaced or no longer relevant.
775
1e49bfab
LMI
7762011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
777
778 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
779
1485f4c0
CY
7802011-07-03 Chong Yidong <cyd@stupidchicken.com>
781
782 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
783 and background color parameters if they have been changed.
784
a9ab721e
LMI
7852011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
786
787 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
788
cf7cff57
PE
7892011-07-03 Paul Eggert <eggert@cs.ucla.edu>
790
2e13213d
PE
791 * xsettings.c (SYSTEM_FONT): Define only when used.
792 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
793
cf7cff57
PE
794 * keymap.c (access_keymap_1): Now static.
795
7a8e04f7
CY
7962011-07-02 Chong Yidong <cyd@stupidchicken.com>
797
798 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
799 leave any prefix arg for the up event (Bug#1586).
800
61352f62
LMI
8012011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
802
69bb1ef7
LMI
803 * lread.c (syms_of_lread): Mention single symbols defined by
804 `defvar' or `defconst' (bug#7154).
805
61352f62 806 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 807 (Frequire): Mention get-load-suffixes.
61352f62 808
28545e04
MR
8092011-07-02 Martin Rudalics <rudalics@gmx.at>
810
811 * window.h (window): Remove clone_number slot.
812 * window.c (Fwindow_clone_number, Fset_window_clone_number):
813 Remove.
814 (make_parent_window, make_window, saved_window)
815 (Fset_window_configuration, save_window_save): Don't deal with
816 clone numbers.
817 * buffer.c (Qclone_number): Remove declaration.
818 (sort_overlays, overlay_strings): Don't deal with clone numbers.
819
3349e122
SM
8202011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
821
822 Add multiple inheritance to keymaps.
823 * keymap.c (Fmake_composed_keymap): New function.
824 (Fset_keymap_parent): Simplify.
825 (fix_submap_inheritance): Remove.
826 (access_keymap_1): New function extracted from access_keymap to handle
827 embedded parents and handle lists of maps.
828 (access_keymap): Use it.
829 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
830 (Fcopy_keymap): Handle embedded parents.
831 (Fcommand_remapping, define_as_prefix): Simplify.
832 (Fkey_binding): Simplify.
833 (syms_of_keymap): Move minibuffer-local-completion-map,
834 minibuffer-local-filename-completion-map,
835 minibuffer-local-must-match-map, and
836 minibuffer-local-filename-must-match-map to Elisp.
837 (syms_of_keymap): Defsubr make-composed-keymap.
838 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
839 (parse_menu_item): Trivial simplification.
840
3279eb87
GM
8412011-07-01 Glenn Morris <rgm@gnu.org>
842
843 * Makefile.in (SETTINGS_LIBS): Fix typo.
844
4550efdf
KI
8452011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
846
847 * coding.c (Fencode_coding_string): Record the last coding system
848 used, as the function doc string says (bug#8738).
849
0949d2b6
JD
8502011-07-01 Jan Djärv <jan.h.d@swipnet.se>
851
852 * xsettings.c (store_monospaced_changed): Take new font as arg and
853 check for change against current_mono_font.
854 (EMACS_TYPE_SETTINGS): Remove this and related defines.
855 (emacs_settings_constructor, emacs_settings_get_property)
856 (emacs_settings_set_property, emacs_settings_class_init)
857 (emacs_settings_init, gsettings_obj): Remove.
858 (something_changedCB): New function for HAVE_GSETTINGS.
859 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
860 with value as argument.
861 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
862 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 863 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
864 "changed".
865
866 * xgselect.c: Add defined (HAVE_GSETTINGS).
867 (xgselect_initialize): Ditto.
868
869 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
870 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
871 xg_select.
872
bbc6b304
PE
8732011-07-01 Paul Eggert <eggert@cs.ucla.edu>
874
875 * eval.c (struct backtrace): Simplify and port the data structure.
876 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
877 signed bit field, as this assumption is not portable and it makes
878 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
879 "char debug_on_exit : 1" as this is not portable either; instead,
880 use the portable "unsigned int debug_on_exit : 1". Remove unused
881 member evalargs. Remove obsolete comments about cc bombing out.
882
9851bfc5
JD
8832011-06-30 Jan Djärv <jan.h.d@swipnet.se>
884
51bb811f 885 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
886 Let HAVE_GSETTINGS override HAVE_GCONF.
887 (store_monospaced_changed): New function.
888 (EMACS_SETTINGS): A new type derived from GObject to handle
889 GSettings notifications.
890 (emacs_settings_constructor, emacs_settings_get_property)
891 (emacs_settings_set_property, emacs_settings_class_init):
892 New functions.
893 (gsettings_client, gsettings_obj): New variables.
894 (GSETTINGS_SCHEMA): New define.
895 (something_changedCB): Call store_monospaced_changed.
896 (init_gsettings): New function.
897 (xsettings_initialize): Call init_gsettings.
898 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
899 to NULL.
900
901 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
902 GCONF_CFLAGS/LIBS.
903
5386012d
MR
9042011-06-29 Martin Rudalics <rudalics@gmx.at>
905
906 * window.c (resize_root_window, grow_mini_window)
907 (shrink_mini_window): Rename Qresize_root_window to
908 Qwindow_resize_root_window and Qresize_root_window_vertically to
909 Qwindow_resize_root_window_vertically.
910
f13e0b08
PE
9112011-06-28 Paul Eggert <eggert@cs.ucla.edu>
912
913 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
914
94515237
JB
9152011-06-27 Juanma Barranquero <lekktu@gmail.com>
916
917 * makefile.w32-in: Redesign dependencies so they reflect more
918 clearly which files are directly included by each source file,
919 and not through other includes.
920
e43b6e43
MR
9212011-06-27 Martin Rudalics <rudalics@gmx.at>
922
923 * buffer.c (Qclone_number): Declare static and DEFSYM it.
924 (sort_overlays, overlay_strings): When an overlay's clone number
925 matches the window's clone number process the overlay even if
926 the overlay's window property doesn't match the current window.
927
d68443dc
MR
928 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
929 (Fwindow_hchild): Rename to Fwindow_left_child.
930 (Fwindow_next): Rename to Fwindow_next_sibling.
931 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
932 (resize_window_check): Rename to window_resize_check.
933 (resize_window_apply): Rename to window_resize_apply.
934 (Fresize_window_apply): Rename to Fwindow_resize_apply.
935 (Fdelete_other_windows_internal, resize_frame_windows)
936 (Fsplit_window_internal, Fdelete_window_internal)
937 (grow_mini_window, shrink_mini_window)
938 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 939
c7e73be5
JD
9402011-06-26 Jan Djärv <jan.h.d@swipnet.se>
941
942 * emacsgtkfixed.h: State that this is only used with Gtk+3.
943 (emacs_fixed_set_min_size): Remove.
944 (emacs_fixed_new): Take frame as argument.
945
946 * emacsgtkfixed.c: State that this is only used with Gtk+3.
947 (_EmacsFixedPrivate): Remove minwidth/height.
948 Add struct frame *f.
949 (emacs_fixed_init): Initialize priv->f.
950 (get_parent_class, emacs_fixed_set_min_size): Remove.
951 (emacs_fixed_new): Set priv->f to argument.
952 (emacs_fixed_get_preferred_width)
953 (emacs_fixed_get_preferred_height): Use min_width/height from
954 frames size_hint to set minimum and natural (Bug#8919).
955 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
956 and use min_width/height from frames size_hint to set
957 min_width/height (Bug#8919).
958
959 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
960 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
961 Fix indentation.
c7e73be5 962
cf99dcf8
EZ
9632011-06-26 Eli Zaretskii <eliz@gnu.org>
964
965 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
966 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
967 called at ZV.
968
029529ac
CY
9692011-06-26 Chong Yidong <cyd@stupidchicken.com>
970
971 * process.c (wait_reading_process_output): Bypass select if
972 waiting for a cell while ignoring keyboard input, and input is
973 pending. Suggested by Jan Djärv (Bug#8869).
974
7a7ef429
PE
9752011-06-25 Paul Eggert <eggert@cs.ucla.edu>
976
977 Use gnulib's dup2 module instead of rolling our own.
978 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
979
11fdef7d 9802011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
981
982 * dispnew.c (scrolling_window): Before scrolling, turn off a
983 mouse-highlight in the window being scrolled.
984
cd3520a4
JB
9852011-06-24 Juanma Barranquero <lekktu@gmail.com>
986
987 Move DEFSYM to lisp.h and use everywhere.
988
989 * character.h (DEFSYM): Move declaration...
990 * lisp.h (DEFSYM): ...here.
991
992 * gnutls.c:
993 * minibuf.c:
994 * w32menu.c:
995 * w32proc.c:
996 * w32select.c: Don't include character.h.
997
998 * alloc.c (syms_of_alloc):
999 * buffer.c (syms_of_buffer):
1000 * bytecode.c (syms_of_bytecode):
1001 * callint.c (syms_of_callint):
1002 * casefiddle.c (syms_of_casefiddle):
1003 * casetab.c (init_casetab_once):
1004 * category.c (init_category_once, syms_of_category):
1005 * ccl.c (syms_of_ccl):
1006 * cmds.c (syms_of_cmds):
1007 * composite.c (syms_of_composite):
1008 * dbusbind.c (syms_of_dbusbind):
1009 * dired.c (syms_of_dired):
1010 * dispnew.c (syms_of_display):
1011 * doc.c (syms_of_doc):
1012 * editfns.c (syms_of_editfns):
1013 * emacs.c (syms_of_emacs):
1014 * eval.c (syms_of_eval):
1015 * fileio.c (syms_of_fileio):
1016 * fns.c (syms_of_fns):
1017 * frame.c (syms_of_frame):
1018 * fringe.c (syms_of_fringe):
1019 * insdel.c (syms_of_insdel):
1020 * keymap.c (syms_of_keymap):
1021 * lread.c (init_obarray, syms_of_lread):
1022 * macros.c (syms_of_macros):
1023 * msdos.c (syms_of_msdos):
1024 * print.c (syms_of_print):
1025 * process.c (syms_of_process):
1026 * search.c (syms_of_search):
1027 * sound.c (syms_of_sound):
1028 * syntax.c (init_syntax_once, syms_of_syntax):
1029 * terminal.c (syms_of_terminal):
1030 * textprop.c (syms_of_textprop):
1031 * undo.c (syms_of_undo):
1032 * w32.c (globals_of_w32):
1033 * window.c (syms_of_window):
1034 * xdisp.c (syms_of_xdisp):
1035 * xfaces.c (syms_of_xfaces):
1036 * xfns.c (syms_of_xfns):
1037 * xmenu.c (syms_of_xmenu):
1038 * xsettings.c (syms_of_xsettings):
1039 * xterm.c (syms_of_xterm): Use DEFSYM.
1040
4228cf16
TZ
10412011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1042
cd3520a4 1043 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 1044
7fcccf1e
PE
10452011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1046
7efb4e0e
PE
1047 Integer and buffer overflow fixes (Bug#8873).
1048
ff5844ad
PE
1049 * print.c (printchar, strout): Check for string overflow.
1050 (PRINTPREPARE, printchar, strout):
1051 Don't set size unless allocation succeeds.
1052
90532f02
PE
1053 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1054 for sizes. Check for string overflow more accurately.
1055 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1056
6d84508d
PE
1057 * macros.c: Integer and buffer overflow fixes.
1058 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1059 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1060 Use ptrdiff_t, not int, for sizes.
1061 Don't increment bufsize until after realloc succeeds.
1062 Check for size-calculation overflow.
1063 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1064
437b2cb4
PE
1065 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1066
8b9ac8b4
PE
1067 * lread.c: Integer overflow fixes.
1068 (read_integer): Radix is now EMACS_INT, not int,
1069 to improve quality of diagnostics for out-of-range radices.
1070 Calculate buffer size correctly for out-of-range radices.
1071 (read1): Check for integer overflow in radices, and in
1072 read-circle numbers.
82cb60d3
PE
1073 (read_escape): Avoid int overflow.
1074 (Fload, openp, read_buffer_size, read1)
1075 (substitute_object_recurse, read_vector, read_list, map_obarray):
1076 Use ptrdiff_t, not int, for sizes.
1077 (read1): Use EMACS_INT, not int, for sizes.
20270765 1078 Check for size overflow.
8b9ac8b4 1079
7fcccf1e
PE
1080 * image.c (cache_image): Check for size arithmetic overflow.
1081
bfbbd7e7
PE
1082 * lread.c: Integer overflow issues.
1083 (saved_doc_string_size, saved_doc_string_length)
1084 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1085 Now ptrdiff_t, not int.
1086 (read1): Don't assume doc string length fits in int. Check for
1087 out-of-range doc string lengths.
1088 (read_list): Don't assume file position fits in int.
39019e54 1089 (read_escape): Check for hex character overflow.
bfbbd7e7 1090
4e323265
LL
10912011-06-22 Leo Liu <sdl.web@gmail.com>
1092
1093 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1094 Move to minibuffer.el.
1095
85fece3e
PE
10962011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1097
20b84ce9 1098 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1099 The following patches are for when GLYPH_DEBUG && !XASSERT.
1100 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1101 * dispnew.c (flush_stdout):
1102 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1103 Mark as externally visible.
1104 * dispnew.c (check_window_matrix_pointers): Now static.
1105 * dispnew.c (window_to_frame_vpos):
1106 * xfns.c (unwind_create_frame):
1107 * xterm.c (x_check_font): Remove unused local.
1108 * scroll.c (CHECK_BOUNDS):
1109 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1110 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1111 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1112 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1113 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1114 Now static.
1115 (debug_method_add): Use va_list and vsprintf rather than relying
1116 on undefined behavior with wrong number of arguments.
1117 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1118 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1119 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1120 since we're not interested in debugging glyphs with old libraries.
1121 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1122 GCC 4.6.0's static checking.
1123
0766b489
PE
11242011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1125
31fd4b32
PE
1126 Integer overflow and signedness fixes (Bug#8873).
1127 A few related buffer overrun fixes, too.
1128
b79e8648
PE
1129 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1130
0766b489
PE
1131 * dispextern.h (struct face.stipple):
1132 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1133 (x_bitmap_mask, x_allocate_bitmap_record)
1134 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1135 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1136 (x_create_bitmap_from_xpm_data):
1137 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1138 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1139 (.bitmaps_last):
1140 * xfaces.c (load_pixmap):
1141 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1142 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1143 (.bitmaps_last, struct x_output.icon_bitmap):
1144 Use ptrdiff_t, not int, for bitmap indexes.
1145 (x_allocate_bitmap_record): Check for size overflow.
1146 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1147
b081724f
PE
1148 Use ptrdiff_t, not int, for overlay counts.
1149 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1150 * editfns.c (overlays_around, get_pos_property):
1151 * textprop.c (get_char_property_and_overlay):
1152 * xdisp.c (next_overlay_change, note_mouse_highlight):
1153 * xfaces.c (face_at_buffer_position):
21514da7
PE
1154 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1155 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1156 (Fnext_overlay_change, Fprevious_overlay_change)
1157 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1158 Use ptrdiff_t, not int, for sizes.
21514da7 1159 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1160
3de73e5e
PE
1161 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1162
2606c57b
PE
1163 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1164 (x_session_initialize): Do not assume string length fits in int.
1165
aaafe47a
PE
1166 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1167 This is unlikely, but can occur if DPI is outlandish.
1168
2674ddc8 1169 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1170 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1171
28154962
PE
1172 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1173 * xrdb.c (magic_file_p, search_magic_path):
1174 Omit last arg SUFFIX; it was always 0. All callers changed.
1175 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1176
7de51af5
PE
1177 * xfont.c (xfont_match): Avoid need for strlen.
1178
25ed6cc3
PE
1179 * xfns.c: Don't assume strlen fits in int.
1180 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1181
4eab31dd
PE
1182 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1183 not unsigned long, as we prefer signed integers. All callers changed.
1184 Detect integer overflow in repeat count.
1185 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1186 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1187
171e2a58
PE
1188 * termcap.c: Don't assume sizes fit in int and never overflow.
1189 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1190 (gobble_line): Check for size-calculation overflow.
1191
ad39faca 1192 * minibuf.c (Fread_buffer):
6e5bb2dc 1193 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1194 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1195 Don't assume string length fits in int.
1196
52c61c22 1197 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1198 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1199
b5b8c9e5
PE
1200 * font.c: Don't assume string length fits in int.
1201 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1202 Use ptrdiff_t, not int.
ccd6111c
PE
1203 (font_intern_prop): Don't assume string length fits in int.
1204 Don't assume integer property fits in fixnum.
1205 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1206
882f0d81 1207 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1208 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1209 Reformulate so as not to need the command string.
1210 Invoke gzip -cd rather than gunzip, as it's more portable.
1211 (lock_info_type, lock_file_1, lock_file):
1212 Don't assume pid_t and time_t fit in unsigned long.
1213 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1214 (current_lock_owner): Prefer signed type for sizes.
1215 Use memcpy, not strncpy, where memcpy is what is really wanted.
1216 Don't assume (via atoi) that time_t and pid_t fit in int.
1217 Check for time_t and/or pid_t out of range, e.g., via a network share.
1218 Don't alloca where an auto var works fine.
1219
93f4cf88
PE
1220 * fileio.c: Fix some integer overflow issues.
1221 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1222 Don't assume string length fits in int.
1223 (directory_file_name): Don't assume string length fits in long.
1224 (make_temp_name): Don't assume pid fits in int, or that its print
1225 length is less than 20.
1226
f3e92b69
PE
1227 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1228
1bfdaf10
PE
1229 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1230
35016e9a
PE
1231 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1232
3d1e65a1
PE
1233 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1234 We prefer signed integers, even for size calculations.
1235
0b963a93
PE
1236 * emacs.c: Don't assume string length fits in 'int'.
1237 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1238 (main): Don't invoke strlen when not needed.
1239
573f4b54
PE
1240 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1241 (XD_DEBUG_MESSAGE): Don't waste a byte.
1242
989f33ba
PE
1243 * callproc.c (getenv_internal_1, getenv_internal)
1244 (Fgetenv_internal):
965d34eb
PE
1245 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1246
e4d29b33
PE
1247 * lread.c (invalid_syntax): Omit length argument.
1248 All uses changed. This doesn't fix a bug, but it simplifies the
1249 code away from its former Hollerith-constant appearance, and it's
1250 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1251 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1252
eb49b136
PE
1253 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1254 This didn't break anything, but it didn't help either.
1255 It's confusing to put a bogus integer in a place where the actual
1256 value does not matter.
9f62aeb1 1257 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1258 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1259
15375a22
PE
1260 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1261 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1262 implementation.
b61cc01c
PE
1263 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1264 We prefer signed types, and the value cannot exceed the EMACS_INT
1265 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1266 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1267 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1268 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1269
53b2623d
PE
1270 * indent.c (sane_tab_width): New function.
1271 (current_column, scan_for_column, Findent_to, position_indentation)
1272 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1273 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1274
51cab52b 1275 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1276
f2ed8a70
PE
1277 * lisp.h (lint_assume): New macro.
1278 * composite.c (composition_gstring_put_cache):
1279 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1280
abe80cc6
PE
1281 * editfns.c, insdel.c:
1282 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1283
b02c740e
PE
1284 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1285
ebc96716
PE
1286 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1287
b4e50fa0 1288 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1289 Use much-faster test for byte-length change.
311d5d7c 1290 Don't assume string byte-length fits in 'int'.
a4cf38e4 1291 Check that character arg fits in 'int'.
85461888 1292 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1293
c0c1ee9f
PE
1294 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1295
a498d7f4
PE
1296 * fns.c (concat): Catch string overflow earlier.
1297 Do not rely on integer wraparound.
1298
51cab52b
PE
1299 * dispextern.h (struct it.overlay_strings_charpos)
1300 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1301 * xdisp.c (forward_to_next_line_start)
1302 (back_to_previous_visible_line_start)
1303 (reseat_at_next_visible_line_start, next_element_from_buffer):
1304 Don't arbitrarily truncate the value of 'selective' to int.
1305
76031fad
PE
1306 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1307
5eb55db9
PE
1308 * composite.c: Don't truncate sizes to 'int'.
1309 (composition_gstring_p, composition_reseat_it)
1310 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1311 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1312 not EMACS_UINT, for indexes.
5eb55db9 1313
0703a717
PE
1314 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1315
d6202519
PE
1316 * buffer.c: Include <verify.h>.
1317 (struct sortvec.priority, struct sortstr.priority):
8961a454 1318 Now EMACS_INT, not int.
c20998a7 1319 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1320 (struct sortstr.size, record_overlay_string)
1321 (struct sortstrlist.size, struct sortlist.used):
1322 Don't truncate size to int.
1323 (record_overlay_string): Check for size-calculation overflow.
d6202519 1324 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1325
d5a19415
JM
13262011-06-22 Jim Meyering <meyering@redhat.com>
1327
029529ac 1328 Don't leak an XBM-image-sized buffer
d5a19415
JM
1329 * image.c (xbm_load): Free the image buffer after using it.
1330
a9041e6c
PE
13312011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1332
1333 Port to Sun C.
1334 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1335 that Sun C diagnosed.
1336 * fns.c (secure_hash): Fix pointer signedness issue.
1337 * intervals.c (static_offset_intervals): New function.
1338 (offset_intervals): Use it.
1339
7f3f739f
LL
13402011-06-21 Leo Liu <sdl.web@gmail.com>
1341
1342 * deps.mk (fns.o):
1343 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1344 sha512.h.
1345
1346 * fns.c (secure_hash): Rename from crypto_hash_function and change
1347 the first arg to accept symbols.
5b66d427 1348 (Fsecure_hash): New primitive.
7f3f739f
LL
1349 (syms_of_fns): New symbols.
1350
76147d94
DD
13512011-06-20 Deniz Dogan <deniz@dogan.se>
1352
1353 * process.c (Fset_process_buffer): Clarify return value in
1354 docstring.
1355
7d7d0045
CY
13562011-06-18 Chong Yidong <cyd@stupidchicken.com>
1357
1358 * dispnew.c (add_window_display_history): Use BVAR.
1359
1360 * xdisp.c (debug_method_add): Use BVAR.
1361 (check_window_end, dump_glyph_matrix, dump_glyph)
1362 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1363
1364 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1365 Likewise.
1366
1367 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1368 check till after the cache is created in init_frame_faces.
1369
ff2bc410
SM
13702011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1371
1372 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1373
28177add
PE
13742011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1375
dd3482fe
PE
1376 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1377 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1378 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1379
393d71f3 1380 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
1381 * fileio.c (Finsert_file_contents):
1382 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1383 Remove the old (too-loose) buffer overflow checks.
1384 They weren't needed, since make_gap checks for buffer overflow.
1385 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1386 The old code merely checked for Emacs fixnum overflow, and relied
1387 on undefined (wraparound) behavior. The new code avoids undefined
1388 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1389
2e6813b0 1390 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
1391 Tune. Don't use wider integers than needed. Don't use alloca.
1392 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 1393
599a9e4f
PE
1394 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1395
99561444
PE
1396 * insdel.c, lisp.h (buffer_overflow): New function.
1397 (insert_from_buffer_1, replace_range, replace_range_2):
1398 * insdel.c (make_gap_larger):
1399 * editfns.c (Finsert_char):
1400 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1401
28177add
PE
1402 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1403
e69dafad
PE
14042011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1405
a7af7fde 1406 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 1407
b1c46f02
PE
1408 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1409 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1410
e69dafad
PE
1411 * fileio.c: Don't assume EMACS_INT fits in off_t.
1412 (emacs_lseek): New static function.
1413 (Finsert_file_contents, Fwrite_region): Use it.
1414 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1415
566684ea
PE
1416 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1417
e6966cd6
PE
1418 * fns.c: Don't overflow int when computing a list length.
1419 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1420 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1421 truncation on 64-bit hosts. Check for QUIT every
1422 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1423 faster and is responsive enough.
1424 (Flength): Report an error instead of overflowing an integer.
1425 (Fsafe_length): Return a float if the value is not representable
1426 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 1427 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 1428 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 1429
dd0b0efb
PE
1430 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1431 (header_size, word_size): New constants.
1432 (allocate_vectorlike): Don't check size overflow here.
1433 (allocate_vector): Check it here instead, since this is the only
1434 caller of allocate_vectorlike that could cause overflow.
1435 Check that the new vector's length is representable as a fixnum.
1436
86fe5cfe
PE
1437 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1438 The previous code was bogus. For example, next_almost_prime (32)
1439 returned 39, which is undesirable as it is a multiple of 3; and
1440 next_almost_prime (24) returned 25, which is a multiple of 5 so
1441 why was the code bothering to check for multiples of 7?
1442
80e88859
PE
1443 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1444
4a2f0ad6
PE
1445 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1446
f66c7cf8
PE
1447 Variadic C functions now count arguments with ptrdiff_t.
1448 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1449 Back then I didn't know that the Emacs coding style prefers signed int.
1450 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1451 were being counted with int, which may truncate counts on 64-bit
1452 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1453 * lisp.h (struct Lisp_Subr.function.aMANY)
1454 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1455 Arg counts are now ptrdiff_t, not size_t.
1456 All variadic functions and their callers changed accordingly.
1457 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1458 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1459 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1460 * callint.c (Fcall_interactively): Check arg count for overflow,
1461 to avoid potential buffer overrun. Use signed char, not 'int',
1462 for 'varies' array, so that we needn't bother to check its size
1463 calculation for overflow.
1464 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1465 * eval.c (apply_lambda):
1466 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1467 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1468 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1469
a1759b76
PE
1470 * callint.c (Fcall_interactively): Don't use index var as event count.
1471
d96be9fc
PE
1472 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1473 * mem-limits.h (SIZE): Remove; no longer used.
1474
a690a978 1475 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1476
578c21e6
PE
1477 Remove unnecessary casts.
1478 * xterm.c (x_term_init):
1479 * xfns.c (x_set_border_pixel):
1480 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1481 These aren't needed now that we assume ANSI C.
1482
96f53c6c
PE
1483 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1484 It's more likely to cause problems (due to unsigned overflow)
1485 than to cure them.
1486
83c77d31
PE
1487 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1488
ee2079f1
PE
1489 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1490
6da65536
PE
1491 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1492
7147c4a4
PE
1493 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1494
193e32d9
PE
1495 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1496
e5533da6
PE
1497 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1498
9910e595
PE
1499 GLYPH_CODE_FACE returns EMACS_INT, not int.
1500 * dispextern.h (merge_faces):
1501 * xfaces.c (merge_faces):
01103c44
PE
1502 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1503 Don't assume EMACS_INT fits in int.
9910e595 1504
2638320e
PE
1505 * character.h (CHAR_VALID_P): Remove unused parameter.
1506 * fontset.c, lisp.h, xdisp.c: All uses changed.
1507
045eb8d9
PE
1508 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1509
c1f134b5
PE
1510 * fns.c (concat): Minor tuning based on overflow analysis.
1511 This doesn't fix any bugs. Use int to hold character, instead
1512 of constantly refetching from Emacs object. Use XFASTINT, not
1513 XINT, for value known to be a character. Don't bother comparing
1514 a single byte to 0400, as it's always less.
1515
395fcb93 1516 * floatfns.c (Fexpt):
327eeec8
PE
1517 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1518
abbd3d23
PE
1519 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1520 for characters.
1521
684a03ef
PE
1522 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1523
0fed43f3
PE
1524 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1525 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1526 incorrectly succeed when S was a string, because 4294967386 was
1527 truncated before it was used.
1528
8fd02eb7
PE
1529 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1530 Otherwise, an out-of-range integer could cause undefined behavior
1531 on a 64-bit host.
1532
f8c86b69
PE
1533 * composite.c: Use int, not EMACS_INT, for characters.
1534 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1535 EMACS_INT, for values that are known to be in character range.
1536 This doesn't fix any bugs but is the usual style inside Emacs and
1537 may generate better code on 32-bit machines.
1538
34206dd2
PE
1539 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1540 This is for reasons similar to the recent CHAR_STRING fix.
1541 * charset.c (Fencode_char): Check that character arg is actually
1542 a character. Pass an int to ENCODE_CHAR.
1543 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1544 wider than 'int', as a compile-time check to prevent future regressions
1545 in this area.
1546
c5958d4c 1547 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1548
1549 Make sure a 64-bit char is never passed to CHAR_STRING.
1550 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1551 by silently ignoring the top 32 bits, allowing some values
1552 that were far too large to be valid characters.
1553 * character.h: Include <verify.h>.
1554 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1555 arguments are no wider than unsigned, as a compile-time check
1556 to prevent future regressions in this area.
1557 * data.c (Faset):
01103c44 1558 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1559 (Fsubst_char_in_region):
1560 * fns.c (concat):
1561 * xdisp.c (decode_mode_spec_coding):
1562 Adjust to CHAR_STRING's new requirement.
1563 * editfns.c (Finsert_char, Fsubst_char_in_region):
1564 * fns.c (concat): Check that character args are actually
1565 characters. Without this test, these functions did the wrong
1566 thing with wildly out-of-range values on 64-bit hosts.
1567
d37ca623
PE
1568 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1569 These casts should not be needed on 32-bit hosts, either.
1570 * keyboard.c (read_char):
1571 * lread.c (Fload): Remove casts to unsigned.
1572
ea204efb
PE
1573 * lisp.h (UNSIGNED_CMP): New macro.
1574 This fixes comparison bugs on 64-bit hosts.
1575 (ASCII_CHAR_P): Use it.
1576 * casefiddle.c (casify_object):
01103c44 1577 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1578 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1579 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1580 * dispextern.h (FACE_FROM_ID):
1581 * keyboard.c (read_char): Use UNSIGNED_CMP.
1582
41cb286c
PE
1583 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1584 not to EMACS_INT, to avoid GCC warning.
1585
4a1b9832
PE
1586 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1587
55daad71
PE
1588 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1589 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1590 isn't needed on 32-bit machines.
8f95c75c 1591
01103c44
PE
1592 * buffer.c (Fgenerate_new_buffer_name):
1593 Use EMACS_INT for count, not int.
0ceccced 1594 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1595
1596 * data.c (Qcompiled_function): Now static.
1597
c6f072e7
PE
1598 * window.c (window_body_lines): Now static.
1599
20ce5912
PE
1600 * image.c (gif_load): Rename local to avoid shadowing.
1601
9c4c5f81
PE
1602 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1603 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1604 * alloc.c (make_save_value): Integer argument is now of type
1605 ptrdiff_t, not int.
1606 (mark_object): Use ptrdiff_t, not int.
1607 * lisp.h (pD): New macro.
1608 * print.c (print_object): Use it.
1609
c0c5c8ae
PE
1610 * alloc.c: Use EMACS_INT, not int, to count objects.
1611 (total_conses, total_markers, total_symbols, total_vector_size)
1612 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1613 (total_free_floats, total_floats, total_free_intervals)
1614 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1615 Now EMACS_INT, not int. All uses changed.
1616 (Fgarbage_collect): Compute overall total using a double, so that
1617 integer overflow is less likely to be a problem. Check for overflow
1618 when converting back to an integer.
5a25e253
PE
1619 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1620 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1621 These were 'int' variables that could overflow on 64-bit hosts;
1622 they were never used, so remove them instead of repairing them.
211a0b2a 1623 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1624 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1625 Previously, this ceilinged at INT_MAX, but that doesn't work on
1626 64-bit machines.
e46bb31a 1627 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1628
c78baabf 1629 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1630 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1631 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1632 when a (possibly-narrower) signed value would do just as well.
1633 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1634
c9d624c6
PE
1635 * alloc.c: Catch some string size overflows that we were missing.
1636 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1637 for convenience in STRING_BYTES_MAX.
1638 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1639 The definition here is exact; the one in lisp.h was approximate.
1640 (allocate_string_data): Check for string overflow. This catches
1641 some instances we weren't catching before. Also, it catches
1642 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1643 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1644 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1645
c9d624c6
PE
1646 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1647 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1648 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1649
353032ce
PE
1650 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1651
2bccce07
PE
1652 * alloc.c (Fmake_string): Check for out-of-range init.
1653
0ac30604
SM
16542011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1655
1656 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1657
c195f2de
JD
16582011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1659
1660 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1661 xg_get_default_scrollbar_width.
1662
1663 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1664 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1665 (style_changed_cb): Call update_theme_scrollbar_width and call
1666 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1667 all frames (Bug#8505).
1668 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1669 Call gtk_window_set_resizable if HAVE_GTK3.
1670 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1671 and height if HAVE_GTK3 (Bug#8505).
1672 (scroll_bar_width_for_theme): New variable.
1673 (update_theme_scrollbar_width): New function.
1674 (xg_get_default_scrollbar_width): Move code to
1675 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1676 (xg_initialize): Call update_theme_scrollbar_width.
1677
1678 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1679
1680 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1681
e10ac9f1
MR
16822011-06-12 Martin Rudalics <rudalics@gmx.at>
1683
1684 * frame.c (make_frame): Call other_buffer_safely instead of
1685 other_buffer.
1686
1687 * window.c (temp_output_buffer_show): Call display_buffer with
1688 second argument Vtemp_buffer_show_specifiers and reset latter
1689 immediately after the call.
1690 (Vtemp_buffer_show_specifiers): New variable.
1691 (auto_window_vscroll_p, next_screen_context_lines)
1692 (Vscroll_preserve_screen_position): Remove leading asterisks from
1693 doc-strings.
1694
2d3c217e 16952011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1696
7b7f97e8 1697 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1698 * buffer.c (Qclone_number): Remove for now, as it's unused.
1699 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1700 (record_buffer): Remove unused local.
1701 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1702 (set_frame_buffer_list): Remove; unused.
1703 * frame.h (other_visible_frames): Remove decl.
1704 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1705 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1706 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1707 if HAVE_GPM.
1708 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1709 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1710 Define only if HAVE_GPM.
1711 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1712 (update_hints_inhibit): Remove; never set. All uses removed.
1713 * widgetprv.h (emacsFrameClassRec): Remove decl.
1714 * window.c (delete_deletable_window): Now returns void, since it
1715 wasn't returning anything.
1716 (compare_window_configurations): Remove unused locals.
1717 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1718 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1719 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1720 the same widths as pointers. This follows up on the 2011-05-06 patch.
1721 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1722 * xterm.h: Likewise.
1723 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1724
1384b89e
JB
17252011-06-12 Juanma Barranquero <lekktu@gmail.com>
1726
1727 * makefile.w32-in: Update dependencies.
1728 (LISP_H): Add lib/intprops.h.
1729
1100a63c
CY
17302011-06-11 Chong Yidong <cyd@stupidchicken.com>
1731
1732 * image.c (gif_load): Add animation frame delay to the metadata.
1733 (syms_of_image): Use DEFSYM. New symbol `delay'.
1734
6198ccd0
MR
17352011-06-11 Martin Rudalics <rudalics@gmx.at>
1736
1737 * window.c (delete_deletable_window): Re-add.
1738 (Fset_window_configuration): Rewrite to handle dead buffers and
1739 consequently deletable windows.
1740 (window_tree, Fwindow_tree): Remove. Supply functionality in
1741 window.el.
1742 (compare_window_configurations): Simplify code.
1743
b6e3633c
AS
17442011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1745
1ab0dee5
AS
1746 * image.c (imagemagick_load_image): Fix type mismatch.
1747 (Fimagemagick_types): Likewise.
1748
b6e3633c
AS
1749 * window.h (replace_buffer_in_windows): Declare.
1750
9397e56f
MR
17512011-06-11 Martin Rudalics <rudalics@gmx.at>
1752
1753 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1754 Qclone_number. Remove external declaration of Qdelete_window.
1755 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1756 code.
1757 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1758 Qbuffer_list_update_hook if allowed.
1759 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1760 buffer list implementation.
1761 (other_buffer_safely): New function.
1762 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1763 calls to replace_buffer_in_windows and
1764 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1765 if allowed.
1766 (record_buffer): Inhibit quitting and rewrite using quittable
1767 functions. Run Qbuffer_list_update_hook if allowed.
1768 (Frecord_buffer, Funrecord_buffer): New functions.
1769 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1770 switch-to-buffer to window.el.
1771 (bury-buffer): Move to window.el.
1772 (Vbuffer_list_update_hook): New variable.
1773
1774 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1775 section.
1776
1777 * window.h (resize_frame_windows): Move up in code.
1778 (Fwindow_frame): Remove EXFUN.
1779 (replace_buffer_in_all_windows): Remove prototype.
1780 (replace_buffer_in_windows_safely): Add prototype.
1781
1782 * window.c: Declare Qdelete_window static again. Move down
1783 declaration of select_count.
1784 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1785 (Fother_window): Move to window.el.
1786 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1787 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1788 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1789 window.el.
1790 (replace_buffer_in_windows): Implement by calling
1791 Qreplace_buffer_in_windows.
1792 (replace_buffer_in_all_windows): Remove with some functionality
1793 moved into replace_buffer_in_windows_safely.
1794 (replace_buffer_in_windows_safely): New function.
1795 (select_window_norecord, select_frame_norecord): Move in front
1796 of run_window_configuration_change_hook. Remove now obsolete
1797 declarations.
1798 (Fset_window_buffer): Rewrite doc-string. Call
1799 Qrecord_window_buffer.
1800 (keys_of_window): Move binding for other-window to window.el.
1801
b50691aa
CY
18022011-06-11 Chong Yidong <cyd@stupidchicken.com>
1803
1804 * dispextern.h (struct image): Replace data member, whose int_val
1805 and ptr_val fields were not used by anything, with a single
1806 lisp_val object.
1807
1808 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1809 (gif_clear_image, gif_load, imagemagick_load_image)
1810 (gs_clear_image, gs_load): Callers changed.
1811
3f754b86
PE
18122011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1813
cca69397
PE
1814 * buffer.h: Include <time.h>, for time_t.
1815 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1816
109e28d0
PE
1817 Fix minor problems found by static checking.
1818
60737f02
PE
1819 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1820
4b66faf3
PE
1821 Make identifiers static if they are not used in other modules.
1822 * data.c (Qcompiled_function, Qframe, Qvector):
1823 * image.c (QimageMagick, Qsvg):
1824 * minibuf.c (Qmetadata):
1825 * window.c (resize_window_check, resize_root_window): Now static.
1826 * window.h (resize_window_check, resize_root_window): Remove decls.
1827
109e28d0
PE
1828 * window.c (window_deletion_count, delete_deletable_window):
1829 Remove; unused.
46a4ce9e
PE
1830 (window_body_lines): Now static.
1831 (Fdelete_other_windows_internal): Mark vars as initialized.
1832 Make sure 'resize_failed' is initialized.
1833 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1834 (resize_window_apply): Remove unused local.
1835 * window.h (delete_deletable_window): Remove decl.
1836
109e28d0 1837 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
1838 (imagemagick_load_image): Fix pointer signedness problem by changing
1839 last arg from unsigned char * to char *. All uses changed.
1840 Also, fix a local for similar reasons.
1841 Remove unused locals. Remove locals to avoid shadowing.
1842 (fn_rsvg_handle_free): Remove; unused.
1843 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1844 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1845
3f754b86
PE
1846 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1847
2547adb1
CY
18482011-06-10 Chong Yidong <cyd@stupidchicken.com>
1849
1850 * image.c (gif_load): Fix omitted cast error introduced by
1851 2011-06-06 change.
1852
2c8e37d4
MR
18532011-06-10 Martin Rudalics <rudalics@gmx.at>
1854
1855 * window.h (resize_proportionally, orig_total_lines)
1856 (orig_top_line): Remove from window structure.
1857 (set_window_height, set_window_width, change_window_heights)
1858 (Fdelete_window): Remove prototypes.
1859 (resize_frame_windows): Remove duplicate declaration.
1860
440a42e3
EZ
18612011-06-10 Eli Zaretskii <eliz@gnu.org>
1862
1863 * window.h (resize_frame_windows, resize_window_check)
1864 (delete_deletable_window, resize_root_window)
1865 (resize_frame_windows): Declare prototypes.
1866
1867 * window.c (resize_window_apply): Make definition be "static" to
1868 match the prototype.
1869
562dd5e9
MR
18702011-06-10 Martin Rudalics <rudalics@gmx.at>
1871
1872 * window.c: Remove declarations of Qwindow_size_fixed,
1873 window_min_size_1, window_min_size_2, window_min_size,
1874 size_window, window_fixed_size_p, enlarge_window, delete_window.
1875 Remove static from declaration of Qdelete_window, it's
1876 temporarily needed by Fbury_buffer.
1877 (replace_window): Don't assign orig_top_line and
1878 orig_total_lines.
1879 (Fdelete_window, delete_window): Remove. Window deletion is
1880 handled by window.el.
1881 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1882 Fdelete_window calls with calls to Qdelete_window.
1883 (Fdelete_other_windows): Remove. Deleting other windows is
1884 handled by window.el.
1885 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1886 handled in window.el.
1887 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1888 Window minimum sizes are handled in window.el.
1889 (shrink_windows, size_window, set_window_height)
1890 (set_window_width, change_window_heights, window_height)
1891 (window_width, CURBEG, CURSIZE, enlarge_window)
1892 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1893 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1894 handled in window.el.
1895 (make_dummy_parent): Rename to make_parent_window and give it a
1896 second argument horflag.
1897 (make_window): Don't set resize_proportionally any more.
1898 (Fsplit_window): Remove. Windows are split in window.el.
1899 (save_restore_action, save_restore_orig_size)
1900 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1901 Resize mini windows in window.el.
1902 (grow_mini_window, shrink_mini_window): Implement by calling
1903 Qresize_root_window_vertically, resize_window_check and
1904 resize_window_apply.
1905 (saved_window, Fset_window_configuration, save_window_save): Do
1906 not handle orig_top_line, orig_total_lines, and
1907 resize_proportionally.
1908 (window_min_height, window_min_width): Move to window.el.
1909 (keys_of_window): Move bindings for delete-other-windows,
1910 split-window, delete-window and enlarge-window to window.el.
1911
1912 * buffer.c: Temporarily extern Qdelete_window.
1913 (Fbury_buffer): Temporarily call Qdelete_window instead of
1914 Fdelete_window (Fbury_buffer will move to window.el soon).
1915
1916 * frame.c (set_menu_bar_lines_1): Remove code handling
1917 orig_top_line and orig_total_lines.
1918
1919 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1920 set_window_height but set heights directly.
1921 (change_frame_size_1): Use resize_frame_windows.
1922
1923 * xdisp.c (init_xdisp): Don't use set_window_height but set
1924 heights directly.
1925
1926 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1927 resize_frame_windows instead of change_window_heights and run
1928 run_window_configuration_change_hook.
1929
1930 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1931 instead of change_window_heights and run
1932 run_window_configuration_change_hook.
1933
1a13852e
MR
19342011-06-09 Martin Rudalics <rudalics@gmx.at>
1935
1936 * window.c (replace_window): Rename second argument REPLACEMENT to
1937 NEW. New third argument SETFLAG. Rewrite.
1938 (delete_window, make_dummy_parent): Call replace_window with
1939 third argument 1.
1940 (window_list_1): Move down in code.
1941 (run_window_configuration_change_hook): Move set_buffer part
1942 before select_frame_norecord part in order to unwind correctly.
1943 Rename count1 to count.
1944 (recombine_windows, delete_deletable_window, resize_root_window)
1945 (Fdelete_other_windows_internal)
1946 (Frun_window_configuration_change_hook, make_parent_window)
1947 (resize_window_check, resize_window_apply, Fresize_window_apply)
1948 (resize_frame_windows, Fsplit_window_internal)
1949 (Fdelete_window_internal, Fresize_mini_window_internal): New
1950 functions.
1951 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1952
f3d1777e
MR
19532011-06-08 Martin Rudalics <rudalics@gmx.at>
1954
496e208e
MR
1955 * window.h (window): Add some new members to window structure -
1956 normal_lines, normal_cols, new_total, new_normal, clone_number,
1957 splits, nest, prev_buffers, next_buffers.
1958 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1959 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1960
f3d1777e
MR
1961 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1962 Remove.
496e208e
MR
1963 (make_dummy_parent): Set new members of windows structure.
1964 (make_window): Move down in code. Handle new members of window
1965 structure.
1966 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1967 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1968 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1969 (Fset_window_prev_buffers, Fwindow_next_buffers)
1970 (Fset_window_next_buffers, Fset_window_clone_number): New
1971 functions.
1972 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1973 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1974 Doc-string fixes.
1975 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1976 Argument WINDOW can be now internal window too.
1977 (Fwindow_use_time): Move up in code.
1978 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1979 Rewrite doc-string.
1980 (Fset_window_configuration, saved_window)
1981 (Fcurrent_window_configuration, save_window_save): Handle new
1982 members of window structure.
b9e809c2
MR
1983 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1984 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1985 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1986 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1987 Qget_mru_window, Qresize_root_window,
1988 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1989 Qauto_buffer_name; staticpro them.
f3d1777e 1990
abde8f8c
MR
19912011-06-07 Martin Rudalics <rudalics@gmx.at>
1992
1993 * window.c (Fwindow_total_size, Fwindow_left_column)
1994 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1995 (Fwindow_list_1): New functions.
1996 (window_box_text_cols): Replace with window_body_cols.
1997 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1998 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1999 (delete_window, Fset_window_configuration): Call
2000 delete_all_subwindows with window as argument.
2001 (delete_all_subwindows): Take a window as argument and not a
2002 structure. Rewrite.
190b47e6
MR
2003 (window_loop): Remove handling of GET_LRU_WINDOW and
2004 GET_LARGEST_WINDOW.
2005 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
2006
2007 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
2008 window_box_text_cols. delete_all_subwindows now takes a
2009 Lisp_Object as argument.
abde8f8c
MR
2010
2011 * indent.c (compute_motion, Fcompute_motion): Use
2012 window_body_cols instead of window_box_text_cols.
2013
fa8a67e6
MR
2014 * frame.c (delete_frame): Call delete_all_subwindows with root
2015 window as argument.
2016
a54e3482
DC
20172011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2018
2019 * fns.c (Fputhash): Document return value.
2020
60002bf5
CY
20212011-06-06 Chong Yidong <cyd@stupidchicken.com>
2022
2023 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2024
0c671da6 20252011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2026
b862a52a 2027 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 2028
be44ca6c
PE
2029 Check for overflow when converting integer to cons and back.
2030 * charset.c (Fdefine_charset_internal, Fdecode_char):
2031 Use cons_to_unsigned to catch overflow.
2032 (Fencode_char): Use INTEGER_TO_CONS.
2033 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2034 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2035 * data.c (long_to_cons, cons_to_long): Remove.
2036 (cons_to_unsigned, cons_to_signed): New functions.
2037 These signal an error for invalid or out-of-range values.
2038 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2039 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2040 * font.c (Ffont_variation_glyphs):
2041 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2042 * lisp.h: Include <intprops.h>.
2043 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2044 (cons_to_signed, cons_to_unsigned): New decls.
2045 (long_to_cons, cons_to_long): Remove decls.
2046 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2047 (Fprimitive_undo): Use CONS_TO_INTEGER.
2048 * xfns.c (Fx_window_property): Likewise.
2049 * xselect.c: Include <limits.h>.
2050 (x_own_selection, selection_data_to_lisp_data):
2051 Use INTEGER_TO_CONS.
2052 (x_handle_selection_request, x_handle_selection_clear)
2053 (x_get_foreign_selection, Fx_disown_selection_internal)
2054 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2055 (lisp_data_to_selection_data): Use cons_to_unsigned.
2056 (x_fill_property_data): Use cons_to_signed.
2057 Report values out of range.
2058
d1f3d2af
PE
2059 Check for buffer and string overflow more precisely.
2060 * buffer.h (BUF_BYTES_MAX): New macro.
2061 * lisp.h (STRING_BYTES_MAX): New macro.
2062 * alloc.c (Fmake_string):
2063 * character.c (string_escape_byte8):
2064 * coding.c (coding_alloc_by_realloc):
2065 * doprnt.c (doprnt):
2066 * editfns.c (Fformat):
2067 * eval.c (verror):
2068 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2069 since they may not be the same number.
2070 * editfns.c (Finsert_char):
2071 * fileio.c (Finsert_file_contents):
2072 Likewise for BUF_BYTES_MAX.
2073
dd52fcea
PE
2074 * image.c: Use ptrdiff_t, not int, for sizes.
2075 (slurp_file): Switch from int to ptrdiff_t.
2076 All uses changed.
2077 (slurp_file): Check that file size fits in both size_t (for
2078 malloc) and ptrdiff_t (for sanity and safety).
2079
7f9bbdbb
PE
2080 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2081 if b->modtime has its maximal value.
2082
dfe18f82
PE
2083 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2084
84acfcf0
PE
2085 Don't assume time_t can fit into int.
2086 * buffer.h (struct buffer.modtime): Now time_t, not int.
2087 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2088 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2089
ccd9a01a
PE
2090 Minor fixes for signed vs unsigned integers.
2091 * character.h (MAYBE_UNIFY_CHAR):
2092 * charset.c (maybe_unify_char):
2093 * keyboard.c (read_char, reorder_modifiers):
2094 XINT -> XFASTINT, since the integer must be nonnegative.
2095 * ftfont.c (ftfont_spec_pattern):
2096 * keymap.c (access_keymap, silly_event_symbol_error):
2097 XUINT -> XFASTINT, since the integer must be nonnegative.
2098 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2099 since it makes no difference and we prefer signed.
2100 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2101 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2102 nonnegative.
2103
d6d100dd
SM
21042011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2105
2106 * window.h (Fwindow_frame): Declare.
2107
2b6148e4
PE
21082011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2109
2110 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2111 (SPARE_MEMORY): Always define.
2112 (LARGE_REQUEST): Remove.
2113 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2114
f230ecc9
MR
21152011-06-06 Martin Rudalics <rudalics@gmx.at>
2116
727e958e
MR
2117 * lisp.h: Move EXFUNS for Fframe_root_window,
2118 Fframe_first_window and Fset_frame_selected_window to window.h.
2119
2120 * window.h: Move EXFUNS for Fframe_root_window,
2121 Fframe_first_window and Fset_frame_selected_window here from
2122 lisp.h.
2123
2124 * frame.c (Fwindow_frame, Fframe_first_window)
2125 (Fframe_root_window, Fframe_selected_window)
2126 (Fset_frame_selected_window): Move to window.c.
2127 (Factive_minibuffer_window): Move to minibuf.c.
2128 (Fother_visible_frames_p): New function.
2129
2130 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2131
f230ecc9
MR
2132 * window.c (decode_window, decode_any_window): Move up in code.
2133 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2134 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2135 (Fwindow_buffer): Move up and rewrite doc-string.
2136 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2137 (Fwindow_prev): New functions.
727e958e
MR
2138 (Fwindow_frame): Move here from frame.c. Accept any window as
2139 argument.
2140 (Fframe_root_window, Fframe_first_window)
2141 (Fframe_selected_window): Move here from frame.c. Accept frame
2142 or arbitrary window as argument. Update doc-strings.
2143 (Fminibuffer_window): Move up in code.
2144 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2145 (Fset_frame_selected_window): Move here from frame.c.
2146 Marginal rewrite.
727e958e
MR
2147 (Fselected_window, select_window, Fselect_window): Move up in
2148 code. Minor doc-string fixes.
f230ecc9 2149
4d09bcf6
PE
21502011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2151
2152 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2153 Do not assume that spare memory exists; that assumption is valid
2154 only if SYSTEM_MALLOC.
2155 (LARGE_REQUEST): New macro, so that the issue of large requests
2156 is separated from the issue of spare memory.
2157
810928a2
AS
21582011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2159
172418ad
AS
2160 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2161 format. (Bug#8806)
2162
43f862f7
AS
2163 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2164
810928a2
AS
2165 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2166 before statements.
2167
a059fe24
JD
21682011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2169
2170 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2171
2172 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2173
2174 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2175 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2176
989bf368
JB
21772011-06-05 Juanma Barranquero <lekktu@gmail.com>
2178
2179 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2180
4b80f674
CY
21812011-06-04 Chong Yidong <cyd@stupidchicken.com>
2182
2183 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2184 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2185 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2186 New error handlers.
4b80f674
CY
2187 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2188 Obey Vx_select_enable_clipboard_manager. Catch errors in
2189 x_clipboard_manager_save (Bug#8779).
2190 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2191 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2192
99a33b77 21932011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2194
2195 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2196
99a33b77 21972011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2198
2199 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2200 in the current matrix if keep_current_p is non-zero.
2201
8264569d
EZ
22022011-06-04 Eli Zaretskii <eliz@gnu.org>
2203
2204 * bidi.c (bidi_level_of_next_char): Fix last change.
2205
57f97249
EZ
22062011-06-03 Eli Zaretskii <eliz@gnu.org>
2207
fec2107c 2208 Support bidi reordering of text covered by display properties.
57f97249 2209
fec2107c
EZ
2210 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2211 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2212 (bidi_cache_search, bidi_cache_iterator_state)
2213 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2214 (bidi_level_of_next_char, bidi_move_to_visually_next):
2215 Support character positions inside a run of characters covered by a
fec2107c
EZ
2216 display string.
2217 (bidi_paragraph_init, bidi_resolve_explicit_1)
2218 (bidi_level_of_next_char): Call bidi_fetch_char and
2219 bidi_fetch_char_advance instead of FETCH_CHAR and
2220 FETCH_CHAR_ADVANCE.
2221 (bidi_init_it): Initialize new members.
2222 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2223 definitions.
2224 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2225 instead of using explicit *_CHAR codes.
d6d100dd
SM
2226 (bidi_resolve_explicit, bidi_resolve_weak):
2227 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2228 bidirectional text is supported only in multibyte buffers.
2229 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2230 it to initialize the frame_window_p member of struct bidi_it.
2231 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2232 (bidi_resolve_explicit, bidi_resolve_weak)
2233 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2234 bidi_it->nchars is non-positive.
2235 (bidi_level_of_next_char): Don't try to lookup the cache for the
2236 next/previous character if nothing is cached there yet, or if we
2237 were just reseat()'ed to a new position.
c40e2fb2 2238
0e14fe90
EZ
2239 * xdisp.c (set_cursor_from_row): Set start and stop points
2240 according to the row's direction when priming the loop that looks
2241 for the glyph on which to display cursor.
2242 (single_display_spec_intangible_p): Function deleted.
2243 (display_prop_intangible_p): Reimplement to call
2244 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2245 Accept 3 additional arguments needed by handle_display_spec.
2246 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2247 values: lists, `(when COND...)' forms, etc.
2248 (single_display_spec_string_p): Support property values that are
2249 lists with the argument STRING its top-level element.
2250 (display_prop_string_p): Fix the condition for processing a
2251 property that is a list to be consistent with handle_display_spec.
fec2107c 2252 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2253 last portion of handle_display_prop.
2254 (compute_display_string_pos): Accept additional argument
2255 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2256 value of a `display' property is a "replacing spec".
2257 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2258 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2259 the display property, but just return a value indicating whether
2260 the display property will replace the characters it covers.
2261 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2262 frame_window_p members of struct bidi_it.
d6d100dd
SM
2263 (compute_display_string_pos, compute_display_string_end):
2264 New functions.
fec2107c
EZ
2265 (push_it): Accept second argument POSITION, where pop_it should
2266 jump to continue iteration.
2267 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2268
fec2107c
EZ
2269 * keyboard.c (adjust_point_for_property): Adjust the call to
2270 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2271
2272 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2273 (bidi_init_it): Update prototypes.
2274 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2275 (compute_display_string_pos, compute_display_string_end):
2276 Declare prototypes.
fec2107c
EZ
2277 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2278 EMACS_INT.
fc6f18ce 2279
40087514 22802011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2281
57f53182
PE
2282 Malloc failure behavior now depends on size of allocation.
2283 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2284 * lisp.h: Change signatures accordingly.
2285 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2286 All callers changed. (Bug#8762)
2287
2288 * gnutls.c: Use Emacs's memory allocators.
2289 Without this change, the gnutls library would invoke malloc etc.
2290 directly, which causes problems on non-SYNC_INPUT hosts, and which
2291 runs afoul of improving memory_full behavior. (Bug#8761)
2292 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2293 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2294 xfree instead of the default malloc, realloc, free.
2295 (Fgnutls_boot): No need to check for memory allocation failure,
2296 since xmalloc does that for us.
2297
ac32cd99 2298 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2299 * category.c (hash_get_category_set):
2300 * ccl.c (ccl_driver):
2301 * charset.c (Fdefine_charset_internal):
2302 * charset.h (struct charset.hash_index):
2303 * composite.c (get_composition_id, gstring_lookup_cache)
2304 (composition_gstring_put_cache):
2305 * composite.h (struct composition.hash_index):
2306 * dispextern.h (struct image.hash):
2307 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2308 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2309 (hashfn_equal, hashfn_user_defined, make_hash_table)
2310 (maybe_resize_hash_table, hash_lookup, hash_put)
2311 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2312 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2313 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2314 * image.c (make_image, search_image_cache, lookup_image)
2315 (xpm_put_color_table_h):
2316 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2317 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2318 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2319 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2320 * alloc.c (allocate_vectorlike):
2321 Check for overflow in vector size calculations.
2322 * ccl.c (ccl_driver):
2323 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2324 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2325 need to be updated by these changes.
40087514
PE
2326 * fns.c (make_hash_table, maybe_resize_hash_table):
2327 Check for integer overflow with large hash tables.
0de4bb68
PE
2328 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2329 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2330 (SXHASH_REDUCE): New macro.
2331 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2332 Use it instead of discarding useful hash info with large hash values.
2333 (sxhash_float): New function.
2334 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2335 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2336 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2337 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2338 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2339 Adjust signatures to match updated version of code.
2340 (consing_since_gc): Now EMACS_INT, since a single hash table can
2341 use more than INT_MAX bytes.
2342
698d32e2
DN
23432011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2344
2345 Make it possible to build with GCC-4.6+ -O2 -flto.
2346
2347 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2348
fd6fa53f
SM
23492011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2350
2351 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2352 Call minibuffer-inactive-mode.
2353
864db017
JB
23542011-05-31 Juanma Barranquero <lekktu@gmail.com>
2355
2356 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2357 Update dependencies.
2358
2ad0baf4
DN
23592011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2360
2361 * data.c (init_data): Remove code for UTS, this system is not
2362 supported anymore.
2363
4fcc2638
DN
23642011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2365
2366 Don't force ./temacs to start in terminal mode.
2367
2368 * frame.c (make_initial_frame): Initialize faces in all cases, not
2369 only when CANNOT_DUMP is defined.
2370 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2371
c56e0fd5
DN
23722011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2373
2374 * dispnew.c (add_window_display_history): Use const for the string
2375 pointer. Remove declaration, not needed.
2376
333d54da 23772011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 2378
55d4c1b2 2379 Use 'inline', not 'INLINE'.
333d54da 2380 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
2381 * alloc.c, fontset.c (INLINE): Remove.
2382 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2383 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2384 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2385 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2386 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2387
738db178
DN
23882011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2389
2390 Make it possible to run ./temacs.
2391
2392 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2393 syms_of_callproc does the same thing. Remove test for
2394 "initialized", do it in the caller.
2395 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2396
620c53a6
SM
23972011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2398
2399 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2400 (read_minibuf): Use get_minibuffer.
2401 (syms_of_minibuf): Use DEFSYM.
2402 (Qmetadata): New var.
2403 * data.c (Qbuffer): Don't make it static.
2404 (syms_of_data): Use DEFSYM.
2405
e003a292
PE
24062011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2407
2408 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2409 (CCL_CODE_MIN): New macro.
2410
ed008a6d
PE
24112011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2412
3687c2ef
PE
2413 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2414
ed008a6d
PE
2415 * eval.c (Qdebug): Now static.
2416 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2417 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2418 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2419
d66c4c7c
CY
24202011-05-29 Chong Yidong <cyd@stupidchicken.com>
2421
2422 * image.c: Various fixes to ImageMagick code comments.
2423 (Fimagemagick_types): Doc fix.
2424
5fbc2025
PE
24252011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2426
0196f88a
PE
2427 Minor fixes prompted by GCC 4.6.0 warnings.
2428
2429 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2430
5fbc2025
PE
2431 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2432 (x_clipboard_manager_save_all): Move extern decl to ...
2433 * xterm.h: ... here, so that it can be checked for consistency.
2434
1dd3c2d9
CY
24352011-05-29 Chong Yidong <cyd@stupidchicken.com>
2436
2437 * xselect.c (x_clipboard_manager_save_frame)
2438 (x_clipboard_manager_save_all): New functions.
2439 (Fx_clipboard_manager_save): Lisp function deleted.
2440
2441 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2442 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2443
2444 * xterm.h: Update prototype.
2445
5ba6571d
WX
24462011-05-28 William Xu <william.xwl@gmail.com>
2447
2448 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2449 exiting (Bug#8239).
2450
3eaff834
JM
24512011-05-28 Jim Meyering <meyering@redhat.com>
2452
e1900994 2453 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2454 * fns.c (to_uchar): Define.
2455 (crypto_hash_function): Use it to convert some newly-signed
2456 variables to unsigned, to avoid sign-extension bugs. For example,
2457 without this change, (md5 "truc") would evaluate to
2458 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2459 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2460 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2461
0f6990a7
PE
24622011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2463
2464 Integer overflow fixes.
c8a9ca5a 2465
08686060
PE
2466 * dbusbind.c: Serial number integer overflow fixes.
2467 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2468 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2469 to hold a serial number that is too large for a fixnum.
2470 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2471 Check for serial numbers out of range. Decode any serial number
59568bf0 2472 that was so large that it became a float. (Bug#8722)
08686060 2473
2d1fc3c7
PE
2474 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2475 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2476 Use XFASTINT rather than XUINT when numbers are nonnegative.
2477 (xd_append_arg, Fdbus_method_return_internal):
2478 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2479 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2480 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2481 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2482 (Bug#8722)
2d1fc3c7 2483
c8a9ca5a
PE
2484 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2485
519e1d69
PE
2486 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2487
30569699
PE
2488 ccl: add integer overflow checks
2489 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2490 (IN_INT_RANGE): New macros.
2491 (ccl_driver): Use them to check for integer overflow when
2492 decoding a CCL program. Many of the new checks are whether XINT (x)
2493 fits in int; it doesn't always, on 64-bit hosts. The new version
2494 doesn't catch all possible integer overflows, but it's an
847044ea 2495 improvement. (Bug#8719)
30569699 2496
c11285dc
PE
2497 * alloc.c (make_event_array): Use XINT, not XUINT.
2498 There's no need for unsigned here.
2499
fdccd48e
PE
2500 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2501 This follows up to the 2011-05-06 change that substituted uintptr_t
2502 for EMACS_INT. This case wasn't caught back then.
2503
37910ab2
PE
2504 Rework Fformat to avoid integer overflow issues.
2505 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2506 now (part of C89). Include <verify.h>.
2507 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2508 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2509 (Fformat): Avoid the prepass trying to compute sizes; it was only
2510 approximate and thus did not catch overflow reliably. Instead, walk
2511 through the format just once, formatting and computing sizes as we go,
2512 checking for integer overflow at every step, and allocating a larger
2513 buffer as needed. Keep track separately whether the format is
2514 multibyte. Keep only the most-recently calculated precision, rather
2515 than them all. Record whether each argument has been converted to
2516 string. Use EMACS_INT, not int, for byte and char and arg counts.
2517 Support field widths and precisions larger than INT_MAX. Avoid
2518 sprintf's undefined behavior with conversion specifications such as %#d
2519 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2520 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2521 formatting out-of-range floating point numbers with int
9173deec 2522 formats. (Bug#8668)
37910ab2 2523
2e6578fb
PE
2524 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2525
0ae6bdee
PE
2526 * data.c: Avoid integer truncation in expressions involving floats.
2527 * data.c: Include <intprops.h>.
2528 (arith_driver): When there's an integer overflow in an expression
2529 involving floating point, convert the integers to floating point
2530 so that the resulting value does not suffer from catastrophic
2531 integer truncation. For example, on a 64-bit host (* 4
2532 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2533 Do not rely on undefined behavior after integer overflow.
2534
de883a70
PE
2535 merge count_size_as_multibyte, parse_str_to_multibyte
2536 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2537 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2538 Check for integer overflow.
2539 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2540 since it's now a duplicate of the other. This is more of
2541 a character than a buffer op, so better that it's in character.c.
2542 * fns.c, print.c: Adjust to above changes.
2543
2ff916cb
PE
25442011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2545
2546 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2547
f1b54466
PE
25482011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2549
fb1ac845
PE
2550 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2551 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2552 (x_clipboard_manager_save): Now static.
2553 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2554
f1b54466
PE
2555 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2556 (crypto_hash_function): Now static.
2557 Fix pointer signedness problems. Avoid unnecessary initializations.
2558
a9f737ee
CY
25592011-05-27 Chong Yidong <cyd@stupidchicken.com>
2560
2561 * termhooks.h (Vselection_alist): Make it terminal-local.
2562
2563 * terminal.c (create_terminal): Initialize it.
2564
2565 * xselect.c: Support for clipboard managers.
2566 (Vselection_alist): Move to termhooks.h as terminal-local var.
2567 (LOCAL_SELECTION): New macro.
2568 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2569 (symbol_to_x_atom): Remove gratuitous arg.
2570 (x_handle_selection_request, lisp_data_to_selection_data)
2571 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2572 (x_own_selection, x_get_local_selection, x_convert_selection):
2573 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2574 (some_frame_on_display): Delete unused function.
2575 (Fx_own_selection_internal, Fx_get_selection_internal)
2576 (Fx_disown_selection_internal, Fx_selection_owner_p)
2577 (Fx_selection_exists_p): New optional frame arg.
2578 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2579 (x_handle_selection_clear): Don't treat other terminals with the
2580 same keyboard specially. Use the terminal-local Vselection_alist.
2581 (x_clear_frame_selections): Use Frun_hook_with_args.
2582
2583 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2584
2585 * xterm.h: Add support for those atoms.
2586
e067f0c1
CY
25872011-05-26 Chong Yidong <cyd@stupidchicken.com>
2588
2589 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2590 (converted_selections, conversion_fail_tag): New global variables.
2591 (x_selection_request_lisp_error): Free the above.
2592 (x_get_local_selection): Remove unnecessary code.
2593 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2594 of converted selections stored in converted_selections.
2595 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2596 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2597 (x_convert_selection): New function.
2598 (x_handle_selection_event): Simplify.
2599 (x_get_foreign_selection): Don't ignore incoming requests while
2600 waiting for an answer; this will fail when we implement
2601 SAVE_TARGETS, and seems unnecessary anyway.
2602 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2603 (Vx_sent_selection_functions): Doc fix.
2604
0f4aebc0
LL
26052011-05-26 Leo Liu <sdl.web@gmail.com>
2606
2607 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2608
e61124cd
YM
26092011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2610
2611 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2612
2613 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2614 for fringe update if it has periodic bitmap.
ac389d0c 2615 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
2616 and fringe_bitmap_periodic_p.
2617
2618 * fringe.c (get_fringe_bitmap_data): New function.
2619 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2620 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2621 row. Mark glyph row for fringe update if periodicity changed.
2622
2623 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2624 for fringe update unless it has periodic bitmap.
2625
f16d9837
KH
26262011-05-25 Kenichi Handa <handa@m17n.org>
2627
2628 * xdisp.c (get_next_display_element): Set correct it->face_id for
2629 a static composition.
2630
e1b90ef6
LL
26312011-05-24 Leo Liu <sdl.web@gmail.com>
2632
2633 * deps.mk (fns.o):
2634 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2635
2636 * fns.c (crypto_hash_function, Fsha1): New function.
2637 (Fmd5): Use crypto_hash_function.
2638 (syms_of_fns): Add Ssha1.
2639
7400048f
PE
26402011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2641
2642 * gnutls.c: Remove unused macros.
2643 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2644 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2645 Remove macros that are defined and never used.
2646 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2647
abb71cf4
CY
26482011-05-22 Chong Yidong <cyd@stupidchicken.com>
2649
2650 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2651 (Fx_get_selection_internal): Minor cleanup.
2652 (Fx_own_selection_internal): Rename arguments for consistency with
2653 select.el.
2654
6307db39
PE
26552011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2656
2657 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2658
f3d4e0a4
CY
26592011-05-22 Chong Yidong <cyd@stupidchicken.com>
2660
2661 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2662
4d8ade89
YM
26632011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2664
2665 * dispnew.c (scrolling_window): Don't exclude the case that the
2666 last enabled row in the desired matrix touches the bottom boundary.
2667
32078c8d
GM
26682011-05-21 Glenn Morris <rgm@gnu.org>
2669
2670 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2671 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2672 and add some more files.
32078c8d 2673
7285dc67
EZ
26742011-05-20 Eli Zaretskii <eliz@gnu.org>
2675
2676 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2677 report_file_error introduced by the change from 2011-05-07.
2678
89d1bd22
PE
26792011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2680
2681 * systime.h (Time): Define only if emacs is defined.
2682 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2683 where the include path doesn't have X11/X.h by default. See
2684 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2685
e23640bb 26862011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2687
2688 * composite.c (find_automatic_composition): Fix previous change.
2689
b9704ad9
GM
26902011-05-20 Glenn Morris <rgm@gnu.org>
2691
2692 * lisp.mk: New file, split from Makefile.in.
2693 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2694 (shortlisp): Remove.
2695 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2696
4a720484
GM
26972011-05-19 Glenn Morris <rgm@gnu.org>
2698
2699 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2700 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2701 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2702 (lisp): Set the order to that of loadup.el.
2703 (shortlisp): Make it a copy of $lisp.
2704 (SOME_MACHINE_LISP): Remove.
2705 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2706 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2707
a28d4396
KH
27082011-05-18 Kenichi Handa <handa@m17n.org>
2709
2710 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2711 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2712 (find_automatic_composition): Mostly rewrite for efficiency.
2713
a2b1fa8e
JB
27142011-05-18 Juanma Barranquero <lekktu@gmail.com>
2715
2716 * makefile.w32-in: Update dependencies.
2717
8e1f5610
CS
27182011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2719
2720 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2721 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2722
7025ee00 27232011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2724
cdfa6eab
PE
2725 Fix some integer overflow issues, such as string length overflow.
2726
06d6db33
PE
2727 * insdel.c (count_size_as_multibyte): Check for string overflow.
2728
2b4560a8
PE
2729 * character.c (lisp_string_width): Check for string overflow.
2730 Use EMACS_INT, not int, for string indexes and lengths; in
2731 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2732 the resulting string length overflows an EMACS_INT; instead,
2733 report a string overflow if no precision given. When checking for
2734 precision exhaustion, use a check that cannot possibly have
2735 integer overflow. (Bug#8675)
2736 * character.h (lisp_string_width): Adjust to new signature.
2737
cb93f9be
PE
2738 * alloc.c (string_overflow): New function.
2739 (Fmake_string): Use it. This doesn't change behavior, but saves
2740 a few bytes and will simplify future changes.
2741 * character.c (string_escape_byte8): Likewise.
2742 * lisp.h (string_overflow): New decl.
2743
1a1f3366
PE
2744 Fixups, following up to the user-interface timestamp change.
2745 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2746 for UI timestamps, instead of unsigned long.
9fbd6841
PE
2747 * msdos.c (mouse_get_pos): Likewise.
2748 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
2749 * w32gui.h (Time): Define by including "systime.h" rather than by
2750 declaring it ourselves. (Bug#8664)
2751
d4e3e4d3
PE
2752 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2753 * image.c (clear_image_cache): Likewise.
2754
f6a24d19
PE
2755 * term.c (term_mouse_position): Don't assume time_t wraparound.
2756
08dc5ae6
PE
2757 Be more systematic about user-interface timestamps.
2758 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
2759 and sometimes 'EMACS_UINT', to represent these timestamps.
2760 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
2761 This makes the code easier to follow, and makes it easier to catch
2762 integer overflow bugs such as Bug#8664.
2763 * frame.c (Fmouse_position, Fmouse_pixel_position):
2764 Use Time, not unsigned long, for user-interface timestamps.
2765 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2766 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2767 * keyboard.h (last_event_timestamp): Likewise.
2768 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2769 * menu.h (xmenu_show): Likewise.
2770 * term.c (term_mouse_position): Likewise.
2771 * termhooks.h (struct input_event.timestamp): Likewise.
2772 (struct terminal.mouse_position_hook): Likewise.
2773 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2774 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2775 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2776 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2777 what it was before.
2778 * menu.h, termhooks.h: Include "systime.h", for Time.
2779
8e55734a
PE
2780 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2781 Don't assume that the difference between two unsigned long values
2782 can fit into an integer. At this point, we know button_down_time
2783 <= event->timestamp, so the difference must be nonnegative, so
2784 there's no need to cast the result if double-click-time is
2785 nonnegative, as it should be; check that it's nonnegative, just in
2786 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2787 apart (about 25 days). (Bug#8664)
8e55734a 2788
841f1b75 2789 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2790 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2791
3e26f69c
PE
2792 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2793 that always fit in int. Use a sentinel instead of a counter, to
2794 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2795 * frame.h (struct frame): Use int for menu_bar_items_used
2796 instead of EMACS_INT, since it always fits in int.
3e26f69c 2797
5cc152c0
PE
2798 * menu.c (grow_menu_items): Check for int overflow.
2799
d89eb65e
PE
2800 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2801
5235bd3e
PE
2802 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2803 Before, the code was not consistent. These values cannot exceed
2804 2**31 - 1 so there's no need to make them unsigned.
2805 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2806 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2807 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2808 as modifiers.
2809 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2810
bc827e23
PE
2811 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2812 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2813 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2814 presumably because the widths might not match.
2815
78eb494e
PE
2816 * window.c (size_window): Avoid needless test at loop start.
2817
04f2d78b
CB
28182011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2819
2820 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2821
d2fc7e3d 28222011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2823
2824 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2825
d2fc7e3d 28262011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2827
2828 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2829 `width' to `bar_area_x' and `bar_area_width', respectively.
2830 (x_scroll_run): Take account of fringe background extension.
2831
04f2d78b
CB
2832 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2833 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2834 `bar_area_width', respectively.
2835 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2836 background extension.
2837
79b70037
GM
28382011-05-10 Jim Meyering <meyering@redhat.com>
2839
2840 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2841
2f142cc5
JB
28422011-05-10 Juanma Barranquero <lekktu@gmail.com>
2843
2844 * image.c (Finit_image_library): Return t for built-in image types,
2845 like pbm and xbm. (Bug#8640)
2846
57679c86
AS
28472011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2848
2849 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2850
888c9e86
EZ
28512011-05-07 Eli Zaretskii <eliz@gnu.org>
2852
b0512a1d
EZ
2853 * w32console.c (Fset_screen_color): Doc fix.
2854 (Fget_screen_color): New function.
2855 (syms_of_ntterm): Defsubr it.
2856
7285dc67
EZ
2857 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2858 unlink the temporary file if Fcall_process didn't create it in the
2859 first place.
2860 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2861 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2862 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2863 cue to call_process_cleanup not to close that handle.
2864
4d3fcc8e
BK
28652011-05-07 Ben Key <bkey76@gmail.com>
2866
2867 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2868 one of two shell specific rules, either bootstrap-temacs-CMD or
2869 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2870 to the previous implementation of the bootstrap-temacs rule.
2871 The bootstrap-temacs-CMD rule is similar to the previous
2872 implementation of the bootstrap-temacs rule except that it
2873 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2874 variable.
2875
2876 These changes, along with some changes to nt/configure.bat,
2877 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2878 earlier fix to add support for --cflags and --ldflags options
2879 that include quotes so that it works whether make uses cmd or
2880 sh as the shell.
2881
b4289b64
MA
28822011-05-06 Michael Albinus <michael.albinus@gmx.de>
2883
2884 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2885 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2886 is a constant.
2887 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2888 a string. Handle both cases.
2889 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2890 (Fdbus_register_method): Use Qinvalid_function.
2891
af4c0e28
JB
28922011-05-06 Juanma Barranquero <lekktu@gmail.com>
2893
2894 * makefile.w32-in: Update dependencies.
2895 (LISP_H): Add inttypes.h and stdin.h.
2896 (PROCESS_H): Add unistd.h.
2897
c51453d9
EZ
28982011-05-06 Eli Zaretskii <eliz@gnu.org>
2899
2900 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2901 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2902
8ff0ac3c 29032011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2904
4c4b566b
PE
2905 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2906
aab2b9b5
PE
2907 * term.c (vfatal): Remove stray call to va_end.
2908 It's not needed and the C Standard doesn't allow it here anyway.
2909
c378da0b
PE
2910 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2911 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2912
288b08c7
PE
2913 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2914 bytes.
2915
e3601888
PE
2916 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2917
db6c0e74
PE
2918 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2919
dd5963ea
PE
2920 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2921
88c9450f
PE
2922 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2923
2f9442b8
PE
2924 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2925
c032b5f8
PE
2926 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2927 * charset.c (Fdefine_charset_internal): Don't initialize
2928 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2929 32-bit int (Bug#8600).
a108c10b
PE
2930
2931 * lread.c (read_integer): Be more consistent with string-to-number.
2932 Use string_to_number to do the actual conversion; this avoids
2933 rounding errors and fixes some other screwups. Without this fix,
2934 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2935 (digit_to_number): Move earlier, for benefit of read_integer.
2936 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2937 not a digit in any supported base. (Bug#8602)
a108c10b 2938
ad5f9eea
PE
2939 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2940
aec1708a
PE
2941 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2942 to match comment at start of function. This also removes a
2943 GCC warning about overflow in a 32+64-bit port.
2944
47be4ab5
PE
2945 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2946
371cac43
PE
2947 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2948 Reported by Stefan Monnier in
2949 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2950 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2951 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2952
d01a7826
PE
2953 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2954 (EMACS_UINTPTR): Likewise, with uintptr_t.
2955
7fd47d5c
PE
2956 * lisp.h: Prefer 64-bit EMACS_INT if available.
2957 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2958 on 32-bit hosts that have 64-bit int, so that they can access
2959 large files.
122b0c86
PE
2960 However, temporarily disable this change unless the temporary
2961 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2962
8727937b
PE
2963 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2964
8ac068ac
PE
2965 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2966 This removes an assumption that EMACS_INT and long are the same
2967 width as pointers. The assumption is true for Emacs porting targets
2968 now, but we want to make other targets possible.
2969 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2970 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2971 In the rest of the code, change types of integers that hold casted
2972 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2973 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2974 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2975 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2976 No need to cast type when ORing.
2977 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2978 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2979 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2980 assume EMACS_INT is the same width as char *.
2981 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2982 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2983 Remove no-longer-needed casts.
2984 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2985 (xg_tool_bar_help_callback, xg_make_tool_item):
2986 Use EMACS_INTPTR to hold an integer
2987 that will be cast to void *; this can avoid a GCC warning
2988 if EMACS_INT is not the same width as void *.
2989 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2990 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2991 (current_message_1, set_message_1):
2992 Use a local to convert to proper width without a cast.
2993 * xmenu.c (dialog_selection_callback): Likewise.
2994
ede49d71
PE
2995 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2996 Also, don't assume VALBITS / RAND_BITS is less than 5,
2997 and don't rely on undefined behavior when shifting a 1 left into
2998 the sign bit.
2999 * lisp.h (get_random): Change signature to match.
3000
2f30ecd0
PE
3001 * lread.c (hash_string): Use size_t, not int, for hash computation.
3002 Normally we prefer signed values; but hashing is special, because
3003 it's better to use unsigned division on hash table sizes so that
3004 the remainder is nonnegative. Also, size_t is the natural width
3005 for hashing into memory. The previous code used 'int', which doesn't
3006 retain enough info to hash well into very large tables.
3007 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3008
2a866e7b
PE
3009 * dbusbind.c: Don't possibly lose pointer info when converting.
3010 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3011 Use XPNTR rather than XHASH, so that the high-order bits of
3012 the pointer aren't lost when converting through void *.
3013
51639eac
PE
3014 * eval.c (Fautoload): Don't double-shift a pointer.
3015
92394119
PE
3016 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3017
dbdb9a7c
JB
30182011-05-06 Juanma Barranquero <lekktu@gmail.com>
3019
3020 * gnutls.c (DEF_GNUTLS_FN):
3021 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3022
db7a0b4f
AS
30232011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3024
3025 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3026 marker. (Bug#8610)
3027
f7ff1b0f 30282011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
3029
3030 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3031 New version that can reserve upto 2GB of heap space.
3032
f7ff1b0f 30332011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
3034
3035 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3036
639c109b
TZ
30372011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3038
3039 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3040 `gnutls_certificate_set_x509_key_file'.
3041
d2127135
JB
30422011-05-05 Juanma Barranquero <lekktu@gmail.com>
3043
3044 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3045 Update dependencies.
3046
e968f4f3
JB
30472011-05-04 Juanma Barranquero <lekktu@gmail.com>
3048
3049 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3050 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3051 Remove unused parameter `fildes'.
3052 * process.c (read_process_output, send_process): Don't pass it.
3053
84d358f0
JB
30542011-05-04 Juanma Barranquero <lekktu@gmail.com>
3055
3056 Fix previous change: the library cache is defined in w32.c.
3057 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3058 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3059
0898ca10
JB
30602011-05-04 Juanma Barranquero <lekktu@gmail.com>
3061
3062 Implement dynamic loading of GnuTLS on Windows.
3063
3064 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3065 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3066 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3067 Declare.
3068
3069 * gnutls.c (Qgnutls_dll): Define.
3070 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3071 (gnutls_*): Declare function pointers.
3072 (init_gnutls_functions): New function to initialize function pointers.
3073 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3074 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3075 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3076 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3077 (emacs_gnutls_write, emacs_gnutls_read)
3078 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3079 (Fgnutls_available_p): New function.
3080 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3081 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3082 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3083
3084 * image.c: Include w32.h.
3085 (Vimage_type_cache): Delete.
3086 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3087 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3088 (w32_delayed_load): Move to w32.c.
3089
3090 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3091
3092 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3093 (w32_delayed_load): Move from image.c. When loading a library, record
3094 its filename in the :loaded-from property of the library id.
3095 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3096 Initialize and staticpro them.
3097 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3098
3099 * process.c: Include lisp.h before w32.h, not after.
3100 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3101 instead of gnutls_record_check_pending.
3102
3103 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3104
ff4de4aa
TZ
31052011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3106
3107 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3108 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3109 as passed in.
3110
abe95abb
JD
31112011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3112
3113 * xterm.c (x_set_frame_alpha): Do not set property on anything
3114 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3115
e16e55d4
JB
31162011-05-02 Juanma Barranquero <lekktu@gmail.com>
3117
3118 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3119
bafcf6a5
JB
31202011-05-02 Juanma Barranquero <lekktu@gmail.com>
3121
3122 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3123 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3124 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3125 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3126 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3127 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3128 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3129 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3130 (Qgnutls_bootprop_callbacks_verify): Make static.
3131
e7a6747f
AS
31322011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3133
19ed11ba
AS
3134 * callproc.c: Indentation fixup.
3135
e7a6747f 3136 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3137 (wait_for_termination, interruptible_wait_for_termination):
3138 Move after wait_for_termination_1.
e7a6747f 3139
1ef14cb4
LMI
31402011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3141
3142 * sysdep.c (interruptible_wait_for_termination): New function
3143 which is like wait_for_termination, but allows keyboard
3144 interruptions.
3145
3146 * callproc.c (Fcall_process): Add (:file "file") as an option for
3147 the STDOUT buffer.
3148 (Fcall_process_region): Ditto.
3149
330d880c
EZ
31502011-04-30 Eli Zaretskii <eliz@gnu.org>
3151
8db90b73
EZ
3152 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3153 rather than `XVECTOR (FOO)->size'.
3154
330d880c
EZ
3155 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3156 inttypes.h, as a gnulib replacement is used if it not available in
3157 system headers.
3158
15cbd324
EZ
31592011-04-21 Eli Zaretskii <eliz@gnu.org>
3160
3161 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3162 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3163 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3164
3165 * coding.c (coding_alloc_by_realloc): Error out if destination
3166 will grow beyond MOST_POSITIVE_FIXNUM.
3167 (decode_coding_emacs_mule): Abort if there isn't enough place in
3168 charbuf for the composition carryover bytes. Reserve an extra
3169 space for up to 2 characters produced in a loop.
3170 (decode_coding_iso_2022): Abort if there isn't enough place in
3171 charbuf for the composition carryover bytes.
3172
31732011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3174
ae940cca
EZ
3175 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3176 aborting when %lld or %lll format is passed.
3177 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3178 %llo or %llx format is passed. (Bug#8545)
3179
03ab8921
EZ
3180 * window.c (window_scroll_line_based): Use a marker instead of
3181 simple variables to record original value of point. (Bug#7952)
3182
afda1437
EZ
3183 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3184 produced by %s or %c overflows available buffer space. (Bug#8545)
3185
f76dee0c
PE
31862011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3187
3188 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3189 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3190
fdc5744d
JB
31912011-04-28 Juanma Barranquero <lekktu@gmail.com>
3192
3193 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3194
638f053a
JB
31952011-04-28 Juanma Barranquero <lekktu@gmail.com>
3196
3197 * keyboard.c (Qdelayed_warnings_hook): Define.
3198 (command_loop_1): Run `delayed-warnings-hook'
3199 if Vdelayed_warnings_list is non-nil.
3200 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3201 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3202
d178f871
EZ
32032011-04-28 Eli Zaretskii <eliz@gnu.org>
3204
3205 * doprnt.c (doprnt): Don't return value smaller than the buffer
3206 size if the message was truncated. (Bug#8545).
3207
b124fd93
JB
32082011-04-28 Juanma Barranquero <lekktu@gmail.com>
3209
3210 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3211 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3212
e810457d
PE
32132011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3214
3215 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3216
ea51cceb
JB
32172011-04-27 Juanma Barranquero <lekktu@gmail.com>
3218
3219 * makefile.w32-in: Update dependencies.
3220
94dcfacf
EZ
32212011-04-27 Eli Zaretskii <eliz@gnu.org>
3222
3223 Improve `doprnt' and its usage. (Bug#8545)
3224 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3225 `format_end'. Remove support for %l as a conversion specifier.
3226 Don't use xrealloc. Improve diagnostics when the %l size modifier
3227 is used. Update the commentary.
3228
3229 * eval.c (verror): Simplify calculation of size_t.
3230
3231 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3232 messages.
3233
f61f41d7
PE
32342011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3235
3236 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3237 change.
3238
96fb4434
PE
32392011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3240
3241 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3242 This makes this file independent of the recent pseudovector change.
3243
671875da 32442011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3245
69e9b5a3
PE
3246 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3247
b5f869a7 3248 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3249 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3250 Remove unused local.
c8926152 3251 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3252
841a1577 3253 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3254 GCC 4.6.0 optimizes based on type-based alias analysis.
3255 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3256 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3257 != &v->size, and therefore "v->size = 1; b->size = 2; return
3258 v->size;" must therefore return 1. This assumption is incorrect
3259 for Emacs, since it type-puns struct Lisp_Vector * with many other
3260 types. To fix this problem, this patch adds a new type struct
f904488f 3261 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3262 and pseudovectors, and helps optimizing compilers not get fooled
3263 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3264 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3265 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3266 the size member.
eab3844f
PE
3267 (XSETPVECTYPE): Rewrite in terms of new macro.
3268 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3269 This is a bit clearer, and further avoids the possibility of
3270 undesirable aliasing.
3271 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3272 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3273 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3274 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3275 (ASIZE): Now uses header.size rather than size.
3276 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3277 to avoid the hassle of writing XVECTOR (foo)->header.size.
3278 (struct vectorlike_header): New type.
eab3844f
PE
3279 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3280 object, to help avoid aliasing.
3281 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3282 (SUBRP): Likewise, since Lisp_Subr is a special case.
3283 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3284 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3285 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3286 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3287 changed to be "header.size" and "header.next".
3288 * buffer.h (struct buffer): Likewise.
3289 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3290 * frame.h (struct frame): Likewise.
3291 * process.h (struct Lisp_Process): Likewise.
3292 * termhooks.h (struct terminal): Likewise.
3293 * window.c (struct save_window_data, struct saved_window): Likewise.
3294 * window.h (struct window): Likewise.
3295 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3296 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3297 * buffer.c (init_buffer_once): Likewise.
3298 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3299 special case.
3300 * process.c (Fformat_network_address): Use local var for size,
3301 for brevity.
3302
0df1eac5
PE
3303 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3304
847ab9d1 3305 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3306 * data.c (atof): Remove decl; no longer used or needed.
3307 (digit_to_number): Move to lread.c.
3308 (Fstring_to_number): Use new string_to_number function, to be
3309 consistent with how the Lisp reader treats infinities and NaNs.
3310 Do not assume that floating-point numbers represent EMACS_INT
3311 without losing information; this is not true on most 64-bit hosts.
3312 Avoid double-rounding errors, by insisting on integers when
3313 parsing non-base-10 numbers, as the documentation specifies.
3314 * lisp.h (string_to_number): New decl, replacing ...
3315 (isfloat_string): Remove.
bc0a5c13 3316 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3317 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3318 appears to have been a coding error. Similarly, do not accept
3319 strings like +-1e0 as floating point numbers. Do not report
3320 overflow for integer overflows unless the base is not 10 which
3321 means we have no simple and reliable way to continue.
3322 Break out the floating-point parsing into a new
3323 function string_to_number, so that Fstring_to_number parses
3324 floating point numbers consistently with the Lisp reader.
04f2d78b 3325 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3326 (E_CHAR, EXP_INT): Remove, replacing with ...
3327 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3328 (string_to_number): New function, replacing isfloat_string.
3329 This function checks for valid syntax and produces the resulting
3330 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3331 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3332 so that overflow for non-base-10 numbers is reported only when
3333 there's no portable and simple way to convert to floating point.
452f4150 3334
67769ffc
PE
3335 * textprop.c (set_text_properties_1): Rewrite for clarity,
3336 and to avoid GCC warning about integer overflow.
3337
c20db43f
PE
3338 * intervals.h (struct interval): Use EMACS_INT for members
3339 where EMACS_UINT might cause problems. See
3340 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3341 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3342 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3343 All uses changed.
37aa2f85
PE
3344 (offset_intervals): Tell GCC not to worry about length overflow
3345 when negating a negative length.
c20db43f 3346
2538aa2f
PE
3347 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3348 (overrun_check_free): Likewise.
3349
f2d3008d
PE
3350 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3351 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3352 word size.
3353
ec8df744
PE
3354 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3355 (gnutls_make_error): Rename local to avoid shadowing.
3356 (gnutls_emacs_global_deinit): ifdef out; not used.
3357 (Fgnutls_boot): Use const for pointer to readonly storage.
3358 Comment out unused local. Fix pointer signedness problems.
3359
640ee02d
PE
3360 * lread.c (openp): Don't stuff size_t into an 'int'.
3361 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3362 about possible signed overflow.
3363
6048fb2a
PE
3364 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3365 (GDK_KEY_g): Don't define if already defined.
3366 (xg_prepare_tooltip): Avoid pointer signedness problem.
3367 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3368
fa3c87e1
PE
3369 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3370 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3371
2172544b
PE
3372 * xfns.c (Fx_window_property): Simplify a bit,
3373 to make a bit faster and to avoid GCC 4.6.0 warning.
3374 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3375
9b821a21
PE
3376 * fns.c (internal_equal): Don't assume size_t fits in int.
3377
3c616cfa
PE
3378 * alloc.c (compact_small_strings): Tighten assertion a little.
3379
c2982e87
PE
3380 Replace pEd with more-general pI, and fix some printf arg casts.
3381 * lisp.h (pI): New macro, generalizing old pEd macro to other
3382 conversion specifiers. For example, use "...%"pI"d..." rather
3383 than "...%"pEd"...".
3384 (pEd): Remove. All uses replaced with similar uses of pI.
3385 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3386 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3387 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3388 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3389 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3390 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3391 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3392 64-bit hosts.
3393 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3394 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3395 * print.c (safe_debug_print, print_object): Likewise.
3396 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3397 to int.
6f04d126
PE
3398 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3399 avoiding the 0 flag, which is not portable.
c2982e87
PE
3400 * process.c (Fmake_network_process): Use pI to avoid cast.
3401 * region-cache.c (pp_cache): Likewise.
3402 * xdisp.c (decode_mode_spec): Likewise.
3403 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3404 behavior on 64-bit hosts with printf arg.
6f04d126 3405 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
3406 (x_stop_queuing_selection_requests): Likewise.
3407 (x_get_window_property): Don't truncate byte count to an 'int'
3408 when tracing.
0b432f21 3409
5e073ec7
PE
3410 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3411 here, since it parses constructs like leading '-' and spaces,
3412 which are not wanted; and it overflows with large numbers.
3413 Instead, simply match F[0-9]+, which is what is wanted anyway.
3414
36372bf9
PE
3415 * alloc.c: Remove unportable assumptions about struct layout.
3416 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3417 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3418 (allocate_vectorlike, make_pure_vector): Use the new macros,
3419 plus offsetof, to remove unportable assumptions about struct layout.
3420 These assumptions hold on all porting targets that I know of, but
3421 they are not guaranteed, they're easy to remove, and removing them
3422 makes further changes easier.
3423
0b432f21
PE
3424 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3425 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
3426 (string_overrun_cookie): Now const. Use initializers that
3427 don't formally overflow signed char, to avoid warnings.
000098c1
PE
3428 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3429 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
3430 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3431 multiple of sizeof (EMACS_INT); it need not be, if
3432 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 3433 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 3434
895009e1
JB
34352011-04-26 Juanma Barranquero <lekktu@gmail.com>
3436
3437 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3438
6a7a1b0b
TZ
34392011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3440
3441 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 3442 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3443 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3444
841a1577 34452011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3446
3447 * lisp.h (Qdebug): List symbol.
895009e1 3448 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3449 * keyboard.c (debug-on-event): New variable.
3450 (handle_user_signal): Break into debugger when debug-on-event
3451 matches the current signal symbol.
3452
f2d3ba6f
DN
34532011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3454
3455 * alloc.c (check_sblock, check_string_bytes)
3456 (check_string_free_list): Convert to standard C.
3457
42ce4c63
TZ
34582011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3459
3460 * w32.c (emacs_gnutls_push): Fix typo.
3461
825cd63c
EZ
34622011-04-25 Eli Zaretskii <eliz@gnu.org>
3463
fb11d64d
EZ
3464 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3465 "cast to pointer from integer of different size".
3466
825cd63c
EZ
3467 Improve doprnt and its use in verror. (Bug#8545)
3468 * doprnt.c (doprnt): Document the set of format control sequences
3469 supported by the function. Use SAFE_ALLOCA instead of always
3470 using `alloca'.
3471
3472 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3473 is one byte too soon. Don't use xrealloc; instead xfree and
3474 xmalloc anew.
3475
e061a11b
TZ
34762011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3477
3478 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3479 callbacks stage.
3480
3481 * gnutls.c: Renamed global_initialized to
3482 gnutls_global_initialized. Added internals for the
3483 :verify-hostname-error, :verify-error, and :verify-flags
3484 parameters of `gnutls-boot' and documented those parameters in the
3485 docstring. Start callback support.
9173deec
JB
3486 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3487 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3488 on error. Return error code.
e061a11b
TZ
3489 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3490 (emacs_gnutls_read): Likewise.
3491 (Fgnutls_boot): Return handshake error code.
3492 (emacs_gnutls_handle_error): New function.
3493 (wsaerror_to_errno): Likewise.
3494
3495 * w32.h (emacs_gnutls_pull): Add prototype.
3496 (emacs_gnutls_push): Likewise.
3497
3498 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3499 (emacs_gnutls_push): Likewise.
3500
35012011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3502
3503 * process.c (wait_reading_process_output): Check if GnuTLS
3504 buffered some data internally if no FDs are set for TLS
3505 connections.
3506
3507 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3508 (LIBS): Link to USER_LIBS.
3509 ($(BLD)/gnutls.$(0)): New target.
3510
fa6996bc
EZ
35112011-04-24 Eli Zaretskii <eliz@gnu.org>
3512
eb35682e
EZ
3513 * xdisp.c (handle_single_display_spec): Rename the
3514 display_replaced_before_p argument into display_replaced_p, to
3515 make it consistent with the commentary. Fix typos in the
3516 commentary.
3517
e2ad650c
EZ
3518 * textprop.c (syms_of_textprop): Remove dead code.
3519 (copy_text_properties): Delete obsolete commentary about an
3520 interface that was deleted long ago. Fix typos in the description
3521 of arguments.
3522
1b2de274
EZ
3523 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3524 to changes in oldXMenu/XMenu.h from 2011-04-16.
3525 <menu_help_message, prev_menu_help_message>: Constify.
3526 (IT_menu_make_room): menu->help_text is now `const char **';
3527 adjust.
3528
3529 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3530 to changes in oldXMenu/XMenu.h from 2011-04-16.
3531 (struct XMenu): Declare `help_text' `const char **'.
3532
3533 * xfaces.c <Qunspecified>: Make extern again.
3534
3535 * syntax.c: Include sys/types.h before including regex.h, as
3536 required by Posix.
3537
762b15be
EZ
3538 * doc.c (get_doc_string): Improve the format passed to `error'.
3539
3540 * doprnt.c (doprnt): Improve commentary.
3541
3542 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3543
3544 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3545 them with etags.
3546
f1052e5d
EZ
3547 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3548 changes in globals.h immediately force recompilation.
762b15be
EZ
3549 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3550 $(CURDIR)/s/ms-w32.h.
3551 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3552
fa6996bc
EZ
3553 * character.c (Fchar_direction): Function deleted.
3554 (syms_of_character): Don't defsubr it.
3555 <char-direction-table>: Deleted.
3556
e6c3da20
EZ
35572011-04-23 Eli Zaretskii <eliz@gnu.org>
3558
3559 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3560 * doprnt.c: Include limits.h.
3561 (SIZE_MAX): New macro.
04f2d78b
CB
3562 (doprnt): Return a size_t value. 2nd arg is now size_t.
3563 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3564 Improve overflow protection. Support `l' modifier for integer
3565 conversions. Support %l conversion. Don't assume an EMACS_INT
3566 argument for integer conversions and for %c.
3567
3568 * lisp.h (doprnt): Restore prototype.
3569
3570 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3571 $(SRC)/character.h.
3572
3573 * Makefile.in (base_obj): Add back doprnt.o.
3574
3575 * deps.mk (doprnt.o): Add back prerequisites.
3576 (callint.o): Depend on character.h.
3577
3578 * eval.c (internal_lisp_condition_case): Include the handler
3579 representation in the error message.
3580 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3581 when breaking from the loop.
3582
3583 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3584
3585 * callint.c (Fcall_interactively): When displaying error message
3586 about invalid control letter, pass the character's codepoint, not
3587 a pointer to its multibyte form. Improve display of the character
3588 in octal and display also its hex code.
3589
3590 * character.c (char_string): Use %x to display the (unsigned)
3591 codepoint of an invalid character, to avoid displaying a bogus
3592 negative value.
3593
3594 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3595 `error', not SYMBOL_NAME itself.
3596
3597 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3598 character arguments to `error'.
3599
3600 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3601 to `error' in error message about FINAL_CHAR argument. Make sure
3602 FINAL_CHAR is a character, and use %c when it is passed as
3603 argument to `error'.
3604
4ffd0d6b 36052011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3606
3607 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3608
3609 * w32.c: Include <time.h>.
3610 (sys_localtime): New function.
3611
4ffd0d6b 36122011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3613
3614 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3615
4ffd0d6b 3616 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3617
4ffd0d6b 36182011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3619
4ffd0d6b
GM
3620 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3621 zombies (Bug#8467).
aac0c6e3 3622
04c56954
EZ
36232011-04-19 Eli Zaretskii <eliz@gnu.org>
3624
3625 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3626 gl_state.e_property when gl_state.object is Qt.
3627
3628 * insdel.c (make_gap_larger): Remove limitation of buffer size
3629 to <= INT_MAX.
3630
16a43933
CY
36312011-04-18 Chong Yidong <cyd@stupidchicken.com>
3632
3633 * xdisp.c (lookup_glyphless_char_display)
3634 (produce_glyphless_glyph): Handle cons cell entry in
3635 glyphless-char-display.
3636 (Vglyphless_char_display): Document it.
3637
3638 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3639 glyphless-char-display.
3640
4581706e
CY
36412011-04-17 Chong Yidong <cyd@stupidchicken.com>
3642
3643 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3644
3645 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3646
3647 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3648 definition for no-X builds.
3649
4887c6e2 36502011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3651
fd35b6f9
PE
3652 Static checks with GCC 4.6.0 and non-default toolkits.
3653
5c1ccb01
PE
3654 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3655
006c5daa
PE
3656 * process.c (keyboard_bit_set): Define only if SIGIO.
3657 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3658 (send_process): Repair possible setjmp clobbering.
3659
efc736d3
PE
3660 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3661
4e2fe2e6
PE
3662 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3663
f97334a2
PE
3664 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3665
4e75f29d
PE
3666 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3667 Define only if needed.
3668
90efadd1
PE
3669 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3670 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3671 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3672
3c647824
PE
3673 * dispextern.h (struct redisplay_interface): Rename param
3674 to avoid shadowing.
e264f262 3675 * termhooks.h (struct terminal): Likewise.
761383f4 3676 * xterm.c (xembed_send_message): Likewise.
3c647824 3677
b58c5c4a
PE
3678 * insdel.c (make_gap_smaller): Define only if
3679 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3680
cad59032
PE
3681 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3682 it.
3683
c339dc2e
PE
3684 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3685 so that we aren't warned about unused symbols.
3686
91a3e27b
PE
3687 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3688
399c71d3 3689 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3690
8ffc96f5
PE
3691 * xfns.c (x_real_positions): Mark locals as initialized.
3692
eef9bc79
PE
3693 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3694
098db9dd
PE
3695 * xterm.c: Fix problems found by static analysis with other toolkits.
3696 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3697 (x_dispatch_event): Declare static if USE_GTK, and
3698 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3699 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3700 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3701 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3702 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3703
eb18f6cc
PE
3704 * xmenu.c (menu_help_callback): Pointer type fixes.
3705 Use const pointers when pointing at readonly data. Avoid pointer
3706 signedness clashes.
3707 (FALSE): Remove unused macro.
3708 (update_frame_menubar): Remove unused decl.
3709
1fe72bf8
PE
3710 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3711
60d9e1db
PE
3712 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3713 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3714 (single_menu_item): Rename local to avoid shadowing.
3715
39261c26
PE
3716 * keyboard.c (make_lispy_event): Remove unused local var.
3717
018c5e19
PE
3718 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3719 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3720
63d2b86e
PE
3721 * bitmaps: Change bitmaps from unsigned char back to the X11
3722 compatible char. Avoid the old compiler warnings about
3723 out-of-range initializers by using, for example, '\xab' rather
3724 than 0xab.
3725
aefd87e1
PE
3726 * xgselect.c (xgselect_initialize): Check vs interface
3727 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3728
bf501fb9
PE
3729 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3730
e9829fdf
PE
3731 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3732 to read-only memory.
3733
1086c095
PE
3734 * fns.c (vector): Remove; this old hack is no longer needed.
3735
2baccd04 3736 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3737 Remove unused var.
dde42981 3738 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 3739
72391843 3740 * xrdb.c (x_load_resources): Omit unused local.
3565b346 3741
436c16df 3742 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 3743 (x_window): Rename locals to avoid shadowing.
dc5ddd85 3744 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 3745
92bb796d 3746 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 3747 (x_term_init): Remove local to avoid shadowing.
92bb796d 3748
764430a3 3749 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
3750
3751 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3752 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3753
d1dfb56c
EZ
37542011-04-16 Eli Zaretskii <eliz@gnu.org>
3755
c4354cb4
EZ
3756 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3757
d1dfb56c
EZ
3758 Fix regex.c, syntax.c and friends for buffers > 2GB.
3759 * syntax.h (struct gl_state_s): Declare character position members
3760 EMACS_INT.
3761
3762 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3763
04f2d78b
CB
3764 * textprop.c (verify_interval_modification, interval_of):
3765 Declare arguments EMACS_INT.
d1dfb56c
EZ
3766
3767 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3768 EMACS_INT.
3769
3770 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3771
3772 * indent.c (Fvertical_motion): Local variable it_start is now
3773 EMACS_INT.
3774
3775 * regex.c (re_match, re_match_2, re_match_2_internal)
3776 (bcmp_translate, regcomp, regexec, print_double_string)
3777 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3778 (re_compile_pattern, re_exec): Declare arguments and local
3779 variables `size_t' and `ssize_t' and return values `regoff_t', as
3780 appropriate.
3781 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3782 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3783 <compile_stack_type>: `size' and `avail' are now `size_t'.
3784
3785 * regex.h <regoff_t>: Use ssize_t, not int.
3786 (re_search, re_search_2, re_match, re_match_2): Arguments that
3787 specify buffer/string position and length are now ssize_t and
3788 size_t. Return type is regoff_t.
3789
613052cd
BK
37902011-04-16 Ben Key <bkey76@gmail.com>
3791
3792 * nsfont.m: Fixed bugs in ns_get_family and
3793 ns_descriptor_to_entity that were caused by using free to
3794 deallocate memory blocks that were allocated by xmalloc (via
3795 xstrdup). This caused Emacs to crash when compiled with
3796 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3797 --enable-checking=xmallocoverrun). xfree is now used to
3798 deallocate these memory blocks.
3799
4170f62f 38002011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3801
71b41406
PE
3802 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3803
9587a89d
PE
3804 emacs_write: Accept and return EMACS_INT for sizes.
3805 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3806 et seq.
3807 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3808 Accept and return EMACS_INT.
3809 (emacs_gnutls_write): Return the number of bytes written on
3810 partial writes.
3811 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3812 (emacs_read, emacs_write): Remove check for negative size, as the
3813 Emacs source code has been audited now.
9587a89d
PE
3814 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3815 (emacs_read, emacs_write): Use it.
273a5f82
PE
3816 * process.c (send_process): Adjust to the new signatures of
3817 emacs_write and emacs_gnutls_write. Do not attempt to store
3818 a byte offset into an 'int'; it might overflow.
9587a89d 3819 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3820
3e047f51
PE
3821 * sound.c: Don't assume sizes fit in 'int'.
3822 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3823 Return EMACS_INT, not int.
3e047f51 3824 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3825 Accept EMACS_INT, not int.
3826 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3827 record read return values.
3828
cc39a9db
BK
38292011-04-15 Ben Key <bkey76@gmail.com>
3830
c9d0ec6d
JB
3831 * keyboard.c (Qundefined): Don't declare static since it is used
3832 in nsfns.m.
3833 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3834 static since they are used in nsfont.m.
cc39a9db 3835
6c60eb9f
SM
38362011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3837
3838 * process.c (Qprocessp): Don't declare static.
3839 * lisp.h (Qprocessp): Declare again.
3840
7990b61a
JB
38412011-04-15 Juanma Barranquero <lekktu@gmail.com>
3842
3843 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3844
5d4cb038
PE
38452011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3846
8bd7b830 3847 Improve C-level modularity by making more things 'static'.
cd64ea1d 3848
e3b27b31
PE
3849 Don't publish debugger-only interfaces to other modules.
3850 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3851 (verify_bytepos, count_markers): Move decls to the only modules
3852 that need them.
3853 * region-cache.h (pp_cache): Likewise.
3854 * window.h (check_all_windows): Likewise.
3855 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3856
5d4cb038
PE
3857 * sysdep.c (croak): Now static, if
3858 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3859 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3860
3861 * alloc.c (refill_memory_reserve): Now static if
3862 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3863 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3864
e87b6180
PE
3865 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3866 Define only if USE_LUCID.
3867
ac64929e
PE
3868 * xrdb.c (x_customization_string, x_rm_string): Now static.
3869
6f37259d
PE
3870 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3871 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3872
1683e3ab
PE
3873 * xdisp.c (draw_row_with_mouse_face): Now static.
3874 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3875
de9c2632
PE
3876 * window.h (check_all_windows): Mark externally visible.
3877
2b96acb7
PE
3878 * window.c (window_deletion_count): Now static.
3879
3880 * undo.c: Make symbols static if they're not exported.
3881 (last_undo_buffer, last_boundary_position, pending_boundary):
3882 Now static.
3883
50436f33
PE
3884 * textprop.c (interval_insert_behind_hooks): Now static.
3885 (interval_insert_in_front_hooks): Likewise.
3886
64520e5c
PE
3887 * term.c: Make symbols static if they're not exported.
3888 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3889 (max_frame_lines, tty_set_terminal_modes):
3890 (tty_reset_terminal_modes, tty_turn_off_highlight):
3891 (get_tty_terminal): Now static.
3892 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3893 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3894 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3895 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3896 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3897
1fa53021
PE
3898 * sysdep.c: Make symbols static if they're not exported.
3899 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3900 Now static.
3901 (sigprocmask_set, full_mask): Remove; unused.
3902 (wait_debugging): Mark as visible.
3903 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3904 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3905
d4b43b22
PE
3906 * syntax.c (syntax_temp): Define only if !__GNUC__.
3907
b7c513d0
PE
3908 * sound.c (current_sound_device, current_sound): Now static.
3909
989b29ad
PE
3910 * search.c (searchbufs, searchbuf_head): Now static.
3911
13a55a78
PE
3912 * scroll.c (scroll_cost): Remove; unused.
3913 * dispextern.h (scroll_cost): Remove decl.
3914
de68a1fc
PE
3915 * region-cache.h (pp_cache): Mark as externally visible.
3916
40ccffa6
PE
3917 * process.c: Make symbols static if they're not exported.
3918 (process_tick, update_tick, create_process, chan_process):
3919 (Vprocess_alist, proc_buffered_char, datagram_access):
3920 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3921 (deactivate_process): Mark defn as static, as well as decl.
3922 * lisp.h (create_process): Remove decl.
3923 * process.h (chan_process, Vprocess_alist): Remove decls.
3924
ad64fc97
PE
3925 * print.c: Make symbols static if they're not exported.
3926 (print_depth, new_backquote_output, being_printed, print_buffer):
3927 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3928 (print_interval, print_number_index, initial_stderr_stream):
3929 Now static.
3930 * lisp.h (Fprinc): Remove decl.
3931 (debug_output_compilation_hack): Mark as externally visible.
3932
adddb265
PE
3933 * sysdep.c (croak): Move decl from here to syssignal.h.
3934 * syssignal.h (croak): Put it here, so the API can be checked when
3935 'croak' is called from dissociate_if_controlling_tty.
3936
1717ede2
PE
3937 * minibuf.c: Make symbols static if they're not exported.
3938 (minibuf_save_list, choose_minibuf_frame): Now static.
3939 * lisp.h (choose_minibuf_frame): Remove decl.
3940
fa5fb2bc
PE
3941 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3942
1e3890d1
PE
3943 * lread.c: Make symbols static if they're not exported.
3944 (read_objects, initial_obarray, oblookup_last_bucket_number):
3945 Now static.
3946 (make_symbol): Remove; unused.
3947 * lisp.h (initial_obarray, make_symbol): Remove decls.
3948
8a1414fa
PE
3949 * keyboard.c: Make symbols static if they're not exported.
3950 (single_kboard, recent_keys_index, total_keys, recent_keys):
3951 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3952 (this_single_command_key_start, echoing, last_auto_save):
3953 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3954 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3955 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3956 (Vlispy_mouse_stem, double_click_count):
3957 Now static.
3958 (force_auto_save_soon): Define only if SIGDANGER.
3959 (ignore_mouse_drag_p): Now static if
3960 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3961 (print_help): Remove; unused.
3962 (stop_character, last_timer_event): Mark as externally visible.
3963 * keyboard.h (ignore_mouse_drag_p): Declare only if
3964 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3965 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3966 * lisp.h (echoing): Remove decl.
3967 (force_auto_save_soon): Declare only if SIGDANGER.
3968 * xdisp.c (redisplay_window): Simplify code, to make it more
3969 obvious that ignore_mouse_drag_p is not accessed if !defined
3970 USE_GTK && !defined HAVE_NS.
3971
93ea6e8f
PE
3972 * intervals.c: Make symbols static if they're not exported.
3973 (merge_properties_sticky, merge_interval_right, delete_interval):
3974 Now static.
3975 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3976
77382fcc
PE
3977 * insdel.c: Make symbols static if they're not exported.
3978 However, leave prepare_to_modify_buffer alone. It's never
3979 called from outside this function, but that appears to be a bug.
3980 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3981 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3982 (adjust_after_replace_noundo): Remove; unused.
3983 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3984 (signal_before_change): Remove decls.
77382fcc 3985
9306c32e
PE
3986 * indent.c (val_compute_motion, val_vmotion): Now static.
3987
cd44d2eb
PE
3988 * image.c: Make symbols static if they're not exported.
3989 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3990 if USE_GTK.
3991 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3992 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3993
ad9a7a06
PE
3994 * fringe.c (standard_bitmaps): Now static.
3995 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3996
81626931
PE
3997 * frame.c: Make symbols static if they're not exported.
3998 (x_report_frame_params, make_terminal_frame): Now static.
3999 (get_frame_param): Now static, unless HAVE_NS.
4000 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4001 (x_get_resource_string): Remove; not used.
4002 * frame.h (make_terminal_frame, x_report_frame_params):
4003 (x_get_resource_string); Remove decls.
4004 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4005 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4006
239f9db9
PE
4007 * font.c, fontset.c: Make symbols static if they're not exported.
4008 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4009 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4010 * font.c (font_close_object): Now static.
4011 * font.h (font_close_object): Remove.
4012 * fontset.c (FONTSET_OBJLIST): Remove.
4013 (free_realized_fontset) #if-0 the body, which does nothing.
4014 (face_suitable_for_char_p): #if-0, as it's never called.
4015 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
4016 * xfaces.c (face_at_string_position):
4017 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
4018 since 0 is always ASCII.
4019
dfcf3579
PE
4020 * fns.c (weak_hash_tables): Now static.
4021
5045092b
PE
4022 * fileio.c: Make symbols static if they're not exported.
4023 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4024 (Vwrite_region_annotation_buffers): Now static.
4025
57a96f5c
PE
4026 * eval.c: Make symbols static if they're not exported.
4027 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4028 * lisp.h (backtrace_list): Remove decl.
4029
35f08c38
PE
4030 * emacs.c: Make symbols static if they're not exported.
4031 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4032 (fatal_error_code, fatal_error_signal_hook, standard_args):
4033 Now static.
4034 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4035 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4036 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4037 * lisp.h (fatal_error_signal_hook): Remove decl.
4038 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4039
f44bd759
PE
4040 * editfns.c: Move a (normally-unused) function to its only use.
4041 * editfns.c, lisp.h (get_operating_system_release): Remove.
4042 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4043 worth the hassle of breaking this out.
4044
b532497d
PE
4045 * xterm.c: Make symbols static if they're not exported.
4046 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4047 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4048 (x_destroy_window, x_delete_display):
4049 Now static.
4050 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4051 (x_mouse_leave): Remove; unused.
4052 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4053 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4054 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4055 Remove decls.
4056 (x_mouse_leave): Declare only if WINDOWSNT.
4057 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4058 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4059 USE_X_TOOLKIT.
4060
1675728f
PE
4061 * ftxfont.c: Make symbols static if they're not exported.
4062 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4063 HAVE_FREETYPE.
4064 * font.h (ftxfont_driver): Likewise.
4065
e4cebfca
PE
4066 * xfns.c: Make symbols static if they're not exported.
4067 (x_last_font_name, x_display_info_for_name):
4068 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4069 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4070 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4071 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4072 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4073 (last_show_tip_args): Now static.
4074 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4075 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4076 (x_screen_planes): Remove; unused.
4077 * dispextern.h (x_screen_planes): Remove decl.
4078
5bf46f05
PE
4079 * dispnew.c: Make symbols static if they're not exported.
4080 * dispextern.h (redraw_garbaged_frames, scrolling):
4081 (increment_row_positions): Remove.
4082 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4083 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4084 Now static.
4085 (redraw_garbaged_frames): Remove; unused.
4086
435f4c28
PE
4087 * xfaces.c: Make symbols static if they're not exported.
4088 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4089 Remove decls.
4090 * xterm.h (defined_color): Remove decls.
4091 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4092 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4093 (menu_face_changed_default, defined_color, free_realized_face):
4094 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4095 (ascii_face_of_lisp_face): Remove; unused.
4096
8524aef3
PE
4097 * xdisp.c: Make symbols static if they're not exported.
4098 * dispextern.h (scratch_glyph_row, window_box_edges):
4099 (glyph_to_pixel_coords, set_cursor_from_row):
4100 (get_next_display_element, set_iterator_to_next):
4101 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4102 (show_mouse_face): Remove decls
4103 * frame.h (message_buf_print): Likewise.
4104 * lisp.h (pop_message, set_message, check_point_in_composition):
4105 Likewise.
4106 * xterm.h (set_vertical_scroll_bar): Likewise.
4107 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4108 (message_buf_print, scratch_glyph_row, displayed_buffer):
4109 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4110 (get_next_display_element, show_mouse_face, window_box_edges):
4111 (frame_to_window_pixel_xy, check_point_in_composition):
4112 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4113 (glyph_to_pixel_coords): Remove; unused.
4114
16390cd2
PE
4115 * dired.c (file_name_completion): Now static.
4116
4117 * dbusbind.c (xd_in_read_queued_messages): Now static.
4118
a25f4dfa
PE
4119 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4120 * data.c (circular_list_error): Remove.
4121
14a9c8df
PE
4122 * commands.h (last_point_position, last_point_position_buffer):
4123 (last_point_position_window): Remove decls.
4124 * keyboard.c: Make these variables static.
4125
04f2d78b
CB
4126 * coding.h (coding, code_convert_region, encode_coding_gap):
4127 Remove decls.
74ab6df5
PE
4128 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4129 (iso_code_class, detect_coding, code_convert_region): Now static.
4130 (encode_coding_gap): Remove; unused.
4131
38dfbee1
PE
4132 * chartab.c (chartab_chars, chartab_bits): Now static.
4133
a2cb4e63
PE
4134 * charset.h (charset_iso_8859_1): Remove decl.
4135 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4136 Now static.
4137
127198fd
PE
4138 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4139 * ccl.c (Vccl_program_table): Now static.
4140 (check_ccl_update): Remove; unused.
4141
d85b608f
PE
4142 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4143 * category.h: ... from here.
4144 * category.c (check_category_table, set_category_set): Now static.
4145
31cd66f3
PE
4146 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4147 * lisp.h: Remove these decls.
4148
c358e587
PE
4149 * buffer.c (buffer_count): Remove unused var.
4150
e78aecca
PE
4151 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4152 so that it's not optimized away.
4153 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4154 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4155 exported only to the debugger.
4156
e192d7d3 4157 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4158 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4159
92470028
PE
4160 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4161 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4162 was inaccessible from Lisp.
4163 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4164 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4165
244ed907
PE
4166 alloc.c: Import and export fewer symbols, and remove unused items.
4167 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4168 is defined.
4169 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4170 it's not optimized away by whole-program optimization.
4171 (message_enable_multibyte, free_misc): Remove.
4172 (catchlist, handlerlist, mark_backtrace):
4173 Declare only if BYTE_MARK_STACK.
4174 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4175 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4176 (message_enable_multibyte): Remove decl.
4177 (free_misc, interval_free_list, float_block, float_block_index):
4178 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4179 (cons_free_list, last_marked_index):
4180 Now static.
4181 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4182 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4183 (mark_backtrace): Define only if BYTE_MARK_STACK.
4184 * xdisp.c (message_enable_multibyte): Now static.
4185
61c2b50e 4186 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4187 This makes it easier for human readers (and static analyzers)
4188 to see whether these variables are used from other modules.
4189 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4190 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4191 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4192 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4193 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4194 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4195 * xmenu.c, xselect.c:
4196 Declare Q* vars static if they are not used in other modules.
4197 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4198 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4199 Remove decls of unexported vars.
4200 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4201
95c82688
PE
4202 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4203
16a97296
PE
4204 Make Emacs functions such as Fatom 'static' by default.
4205 This makes it easier for human readers (and static analyzers)
4206 to see whether these functions can be called from other modules.
4207 DEFUN now defines a static function. To make the function external
4208 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4209 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4210 (Finit_image_library):
16a97296
PE
4211 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4212 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4213 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4214 Remove decls, since these functions are now static.
4215 (Funintern, Fget_internal_run_time): New decls, since these functions
4216 were already external.
95c82688 4217
16a97296
PE
4218 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4219 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4220 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4221 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4222 * keyboard.c, keymap.c, lread.c:
4223 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4224 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4225 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4226 Mark functions with DEFUE instead of DEFUN,
4227 if they are used in other modules.
4228 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4229 decls for now-static functions.
4230 * buffer.h (Fdelete_overlay): Remove decl.
4231 * callproc.c (Fgetenv_internal): Mark as internal.
4232 * composite.c (Fremove_list_of_text_properties): Remove decl.
4233 (Fcomposition_get_gstring): New forward static decl.
4234 * composite.h (Fcomposite_get_gstring): Remove decl.
4235 * dired.c (Ffile_attributes): New forward static decl.
4236 * doc.c (Fdocumntation_property): New forward static decl.
4237 * eval.c (Ffetch_bytecode): New forward static decl.
4238 (Funintern): Remove extern decl; now in .h file where it belongs.
4239 * fileio.c (Fmake_symbolic_link): New forward static decl.
4240 * image.c (Finit_image_library): New forward static decl.
4241 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4242 * intervals.h (Fprevious_property_change):
4243 (Fremove_list_of_text_properties): Remove decls.
4244 * keyboard.c (Fthis_command_keys): Remove decl.
4245 (Fcommand_execute): New forward static decl.
4246 * keymap.c (Flookup_key): New forward static decl.
4247 (Fcopy_keymap): Now static.
4248 * keymap.h (Flookup_key): Remove decl.
4249 * process.c (Fget_process): New forward static decl.
4250 (Fprocess_datagram_address): Mark as internal.
4251 * syntax.c (Fsyntax_table_p): New forward static decl.
4252 (skip_chars): Remove duplicate decl.
4253 * textprop.c (Fprevious_property_change): New forward static decl.
4254 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4255 Now internal.
4256 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4257 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4258
785bbd42
PE
4259 * editfns.c (Fformat): Remove unreachable code.
4260
8b913b57
AS
42612011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4262
4263 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4264 change. (Bug#8496)
4265
a6744a35
EZ
42662011-04-13 Eli Zaretskii <eliz@gnu.org>
4267
4268 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4269 when at ZV. (Bug#8487)
4270
e7974947
AS
42712011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4272
baad03f0
AS
4273 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4274 (Bug#8437)
4275 * keyboard.c (parse_tool_bar_item): Likewise.
4276 * sound.c (sound_cleanup, alsa_close): Likewise.
4277 * termcap.c (tgetent): Likewise.
4278 * xfns.c (x_default_font_parameter): Likewise.
4279 * xsettings.c (read_and_apply_settings): Likewise.
4280
e7974947
AS
4281 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4282 (overrun_check_free): Protoize.
4283
28272684
PE
42842011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4285
4286 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4287 since callers should never pass a negative size.
4288 Change the signature to match that of plain 'read' and 'write'; see
4289 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4290 * lisp.h: Update prototypes of emacs_write and emacs_read.
4291
11997c76
EZ
42922011-04-11 Eli Zaretskii <eliz@gnu.org>
4293
4294 * xdisp.c (redisplay_window): Don't try to determine the character
4295 position of the scroll margin if the window start point w->startp
e896f03c 4296 is outside the buffer's accessible region. (Bug#8468)
11997c76 4297
8a2cbd72
EZ
42982011-04-10 Eli Zaretskii <eliz@gnu.org>
4299
4300 Fix write-region and its subroutines for buffers > 2GB.
4301 * fileio.c (a_write, e_write): Modify declaration of arguments and
4302 local variables to support buffers larger than 2GB.
4303 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4304
4305 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4306 argument, local variables, and return value.
4307
4308 * lisp.h: Update prototypes of emacs_write and emacs_read.
4309
4310 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4311
4073e537 43122011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4313
1ebfdcb6
PE
4314 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4315
b2ded58d
PE
4316 Fix more problems found by GCC 4.6.0's static checks.
4317
7d66342c
PE
4318 * xdisp.c (vmessage): Use a better test for character truncation.
4319
bbf47d44
PE
4320 * charset.c (load_charset_map): <, not <=, for optimization,
4321 and to avoid potential problems with integer overflow.
9248994d 4322 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4323 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4324 * editfns.c (Fformat): Likewise.
1e69125e 4325 * syntax.c (skip_chars): Likewise.
3befa583 4326
e3019616
PE
4327 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4328 This also lets GCC 4.6.0 generate slightly better loop code.
4329
becfa255
PE
4330 * callint.c (Fcall_interactively): <, not <=, for optimization.
4331 (Fcall_interactively): Count the number of arguments produced,
4332 not the number of arguments given. This is simpler and lets GCC
4333 4.6.0 generate slightly better code.
4334
dae0cd48
PE
4335 * ftfont.c: Distingish more carefully between FcChar8 and char.
4336 The previous code passed unsigned char * to a functions like
4337 strlen and xstrcasecmp that expect char *, which does not
4338 conform to the C standard.
4339 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4340 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4341 char * when the C standard requires it.
4342
76032d70
PE
4343 * keyboard.c (read_char): Remove unused var.
4344
eb3f1cc8
PE
4345 * eval.c: Port to Windows vsnprintf (Bug#8435).
4346 Include <limits.h>.
4347 (SIZE_MAX): Define if the headers do not.
4348 (verror): Do not give up if vsnprintf returns a negative count.
4349 Instead, grow the buffer. This ports to Windows vsnprintf, which
4350 does not conform to C99. Problem reported by Eli Zaretskii.
4351 Also, simplify the allocation scheme, by avoiding the need for
4352 calling realloc, and removing the ALLOCATED variable.
4353
70476b54
PE
4354 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4355
12020a9e
PE
4356 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4357 But keep the doprint source code for now, as we might revamp it
4358 and use it again (Bug#8435).
ea6c7ae6
PE
4359 * lisp.h (doprnt): Remove.
4360 * Makefile.in (base_obj): Remove doprnt.o.
4361 * deps.mk (doprnt.o): Remove.
4362
5fdb398c
PE
4363 error: Print 32- and 64-bit integers portably (Bug#8435).
4364 Without this change, on typical 64-bit hosts error ("...%d...", N)
4365 was used to print both 32- and 64-bit integers N, which relied on
4366 undefined behavior.
4367 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4368 New macro.
4369 * lisp.h (error, verror): Mark as printf-like functions.
4370 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4371 Report overflow in size calculations when allocating printf buffer.
4372 Do not truncate output string at its first null byte.
4373 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4374 Truncate the output at a character boundary, since vsnprintf does not
4375 do that.
4376 * charset.c (check_iso_charset_parameter): Convert internal
4377 character to string before calling 'error', since %c now has the
4378 printf meaning.
4379 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4380 overflow when computing char to be passed to 'error'. Do not
4381 pass Lisp_Object to 'error'; pass the integer instead.
4382 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4383 formatted with plain %d.
4384
b189fa66
PE
4385 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4386
bff87ef0
PE
4387 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4388
7e2cac20
PE
4389 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4390
ce4d90b5
PE
4391 * xterm.c (x_catch_errors): Remove duplicate declaration.
4392
266c9547
PE
4393 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4394
79c49ad2
PE
4395 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4396
368f4090
JM
43972011-04-10 Jim Meyering <meyering@redhat.com>
4398
4399 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4400 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4401 return ssize_t not "int", and use size_t as the buffer length.
4402 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4403 * gnutls.h: Update declarations.
4404 * process.c (read_process_output): Use ssize_t, to match.
4405 (send_process): Likewise.
4406
a32d4040
CY
44072011-04-09 Chong Yidong <cyd@stupidchicken.com>
4408
4409 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4410
8546720e 44112011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 4412
04f2d78b
CB
4413 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4414 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 4415
8546720e
GM
4416 * xterm.c (handle_one_xevent):
4417 * xmenu.c (create_and_show_popup_menu):
4418 * xselect.c (x_decline_selection_request)
4419 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 4420
0a2f5c1a 44212011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
4422
4423 Fix some uses of `int' instead of EMACS_INT.
4424 * search.c (string_match_1, fast_string_match)
4425 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4426 (scan_buffer, find_next_newline_no_quit)
4427 (find_before_next_newline, search_command, Freplace_match)
4428 (Fmatch_data): Make some `int' variables be EMACS_INT.
4429
4430 * xdisp.c (display_count_lines): 3rd argument and return value now
4431 EMACS_INT. All callers changed.
4432 (pint2hrstr): Last argument is now EMACS_INT.
4433
4434 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4435 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4436 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4437 (decode_coding_utf_16, decode_coding_emacs_mule)
4438 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4439 (decode_coding_ccl, decode_coding_charset)
4440 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4441 (decode_coding_iso_2022, decode_coding_emacs_mule)
4442 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4443 <char_offset, last_offset>: Declare EMACS_INT.
4444 (encode_coding_utf_8, encode_coding_utf_16)
4445 (encode_coding_emacs_mule, encode_invocation_designation)
4446 (encode_designation_at_bol, encode_coding_iso_2022)
4447 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4448 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4449 Declare EMACS_INT.
4450 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4451 (encode_invocation_designation): Last argument P_NCHARS is now
4452 EMACS_INT.
4453 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4454 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4455
4456 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4457 All users changed.
4458
4459 * ccl.c (Fccl_execute_on_string): Declare some variables
4460 EMACS_INT.
4461
8546720e 44622011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4463
4464 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4465
4e19a977
CS
44662011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4467
4468 * process.c (Fformat_network_address): Doc fix.
4469
87302331
R
44702011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4471
4472 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4473
cbb59342
CY
44742011-04-08 Chong Yidong <cyd@stupidchicken.com>
4475
4476 * keyboard.c (read_char): Call Lisp function help-form-show,
4477 instead of using internal_with_output_to_temp_buffer.
4478 (Qhelp_form_show): New var.
e0d38eeb 4479 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4480
4481 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4482
4483 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4484
e67a13ab
CY
44852011-04-06 Chong Yidong <cyd@stupidchicken.com>
4486
04f2d78b
CB
4487 * process.c (Flist_processes): Remove to Lisp.
4488 (list_processes_1): Delete.
e67a13ab 4489
973f782d
EZ
44902011-04-06 Eli Zaretskii <eliz@gnu.org>
4491
7c106b1e
EZ
4492 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4493
973f782d
EZ
4494 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4495
41cf7d1a 44962011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4497
ca23cc88
PE
4498 Fix more problems found by GCC 4.6.0's static checks.
4499
f390e2d5
PE
4500 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4501
42eea0d0
PE
4502 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4503
b69769da 4504 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4505
f9541e84
PE
4506 * xdisp.c (vmessage): Mark as a printf-like function.
4507
13841b55
PE
4508 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4509
c136c10f
PE
4510 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4511
5e2d4a30
PE
4512 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4513 printf-like functions.
4514 (tiff_load): Add casts to remove these marks before passing them
4515 to system-supplied API.
4516
583f48b9
PE
4517 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4518
b25d760e
PE
4519 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4520 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4521 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4522 directly, rather than having caller test rule sign. This avoids
4523 some unnecessary tests.
4524 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4525 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4526 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4527
bc7b6697 4528 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4529 (xfont_open): Avoid unnecessary tests.
bc7b6697 4530
27ccc379
PE
4531 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4532
dcd5c89a
PE
4533 * composite.h, composite.c (composition_gstring_put_cache):
4534 Use EMACS_INT, not int, for length.
4535
b13a45c6
PE
4536 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4537 breaking out part of COMPOSITION_DECODE_RULE.
4538 (COMPOSITION_DECODE_RULE): Use it.
4539 * composite.c (get_composition_id): Remove unused local vars,
4540 by using the new macro.
4541
1e792e4d
PE
4542 * textprop.c (set_text_properties_1): Change while to do-while,
4543 since the condition is always true at first.
4544
dc6c6455 4545 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4546 (interval_deletion_adjustment): Return unsigned value.
4547 All uses changed.
dc6c6455 4548
aba7731a
PE
4549 * process.c (list_processes_1, create_pty, read_process_output):
4550 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4551 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4552 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4553 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4554 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4555
fdfc4bf3
PE
4556 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4557
fca8fe46 4558 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4559 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4560
06a0259a 4561 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4562 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4563 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4564
e7b9e80f
PE
4565 * print.c (print_error_message): Avoid int overflow.
4566
56201685
PE
4567 * font.c (font_list_entities): Redo for clarity,
4568 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4569
78834453 4570 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4571 (font_score): Avoid potential overflow in diff calculation.
78834453 4572
0bc0b309 4573 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4574 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4575
e610eaca
PE
4576 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4577
b895abce
PE
4578 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4579 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4580 can always succeed if overflow has undefined behavior.
4581
1f1d9321 4582 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4583 (wordify): Omit three unnecessary tests.
1f1d9321 4584
c59478bc
PE
4585 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4586 All callers changed. This avoids the need for an unused var.
4587
79b73827
PE
4588 * casefiddle.c (casify_region): Remove var that is set but not used.
4589
a4db5dfe
PE
4590 * dired.c (file_name_completion): Remove var that is set but not used.
4591
43aae36e
PE
4592 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4593
2a47c44d 4594 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4595 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4596
a37c69bf
PE
4597 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4598 Check for integer overflow on size calculations.
4599
328ab8e7
PE
4600 * buffer.c (Fprevious_overlay_change): Remove var that is set
4601 but not used.
4602
e5a2a5cb
PE
4603 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4604 Remove vars that are set but not used.
8d84a6eb 4605 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4606 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4607
a60e5f68
PE
4608 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4609
f661cb61 4610 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4611 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4612
f0397f5a
PE
4613 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4614 that are set but not used.
4615
8664db06 4616 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4617 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4618
6abdaa4a
PE
4619 * xselect.c (x_get_local_selection, x_handle_property_notify):
4620 Remove vars that are set but not used.
4621
0ce7538d 4622 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4623 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4624
9ae848fc
PE
4625 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4626 Remove var that is set but not used.
0b918413
PE
4627 (scroll_bar_windows_size): Now size_t, not int.
4628 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4629 Check for overflow.
9ae848fc 4630
a5a62657
PE
4631 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4632 (map_tty_color) [!defined MSDOS]: Likewise.
4633
5c5cdd39
PE
4634 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4635
66ebf983
PE
4636 * coding.c: Remove vars that are set but not used.
4637 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4638 All callers changed.
4639 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4640 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4641 (decode_coding_charset): Remove vars that are set but not used.
4642
1be4d761
PE
4643 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4644 that is set but not used.
4645
47553fa8
PE
4646 * print.c (print_object): Remove var that is set but not used.
4647
1f7196bf 4648 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4649 The gnulib version avoids calling malloc in the usual case,
4650 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4651 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4652 * filelock.c (current_lock_owner): Likewise.
4653 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4654 * sysdep.c: Include allocator.h, careadlinkat.h.
4655 (emacs_no_realloc_allocator): New static constant.
4656 (emacs_readlink): New function.
fdb61804
PE
4657 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4658 ../lib/careadlinkat.h.
d1fdcab7 4659
f84c17c7
SM
46602011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4661
4662 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4663 first non-nil return value).
4664
ef3862ad
JD
46652011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4666
4667 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4668 if not defined (Bug#8403).
4669
376a7006
JB
46702011-04-02 Juanma Barranquero <lekktu@gmail.com>
4671
4672 * xdisp.c (display_count_lines): Remove parameter `start',
4673 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4674 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4675 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4676 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4677 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4678 and thereabouts. All callers changed.
4679 (get_per_char_metric): Remove parameter `f', unused since
4680 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4681
6ca3801d
JM
46822011-04-02 Jim Meyering <meyering@redhat.com>
4683
4684 do not dereference NULL upon failed strdup
4685 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4686 (ns_get_family): Likewise.
4687
d8e2b5ba
JB
46882011-04-02 Juanma Barranquero <lekktu@gmail.com>
4689
4690 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4691
8c74fcbd
JD
46922011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4693
4694 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4695 later (Bug#8403).
4696
7200d79c
SM
46972011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4698
03408648 4699 Add lexical binding.
7200d79c 4700
03408648
SM
4701 * window.c (Ftemp_output_buffer_show): New fun.
4702 (Fsave_window_excursion):
4703 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4704
4705 * lread.c (lisp_file_lexically_bound_p): New function.
4706 (Fload): Bind Qlexical_binding.
4707 (readevalloop): Remove `evalfun' arg.
4708 Bind Qinternal_interpreter_environment.
4709 (Feval_buffer): Bind Qlexical_binding.
4710 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4711 Mark as dynamic.
4712 (syms_of_lread): Declare `lexical-binding'.
4713
4714 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4715
4716 * keyboard.c (eval_dyn): New fun.
4717 (menu_item_eval_property): Use it.
ca105506
SM
4718
4719 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4720
03408648
SM
4721 * fns.c (concat, mapcar1): Accept byte-code-functions.
4722
4723 * eval.c (Fsetq): Handle lexical vars.
4724 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4725 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4726 (FletX, Flet): Obey lexical binding.
4727 (Fcommandp): Handle closures.
4728 (Feval): New `lexical' arg.
4729 (eval_sub): New function extracted from Feval. Use it almost
4730 everywhere where Feval was used. Look up vars in lexical env.
4731 Handle closures.
4732 (Ffunctionp): Move from subr.el.
4733 (Ffuncall): Handle closures.
4734 (apply_lambda): Remove `eval_flags'.
4735 (funcall_lambda): Handle closures and new byte-code-functions.
4736 (Fspecial_variable_p): New function.
4737 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4738 but without exporting it to Lisp.
23aba0ea 4739
23aba0ea 4740 * doc.c (Fdocumentation, store_function_docstring):
03408648 4741 * data.c (Finteractive_form): Handle closures.
23aba0ea 4742
03408648
SM
4743 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4744 interactive spec.
ba83908c 4745
04f2d78b
CB
4746 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4747 New byte-codes.
03408648
SM
4748 (exec_byte_code): New function extracted from Fbyte_code to handle new
4749 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 4750
03408648 4751 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 4752
03408648 4753 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 4754
e2abce01
JB
47552011-03-31 Juanma Barranquero <lekktu@gmail.com>
4756
4757 * xdisp.c (redisplay_internal): Fix prototype.
4758
63696a73 47592011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 4760
63696a73 4761 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
4762 (try_scrolling): Use it when setting scroll_limit.
4763 Limit scrolling to 100 screen lines.
63696a73
EZ
4764 (redisplay_window): Even when falling back on "recentering",
4765 position point in the window according to scroll-conservatively,
4766 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4767
4768 (try_scrolling): When point is above the window, allow searching
4769 as far as scroll_max, or one screenful, to compute vertical
4770 distance from PT to the scroll margin position. This prevents
4771 try_scrolling from unnecessarily failing when
4772 scroll-conservatively is set to a value slightly larger than the
4773 window height. Clean up the case of PT below the margin at bottom
4774 of window: scroll_max can no longer be INT_MAX. When aggressive
4775 scrolling is in use, don't let point enter the opposite scroll
4776 margin as result of the scroll.
4777 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
4778 threshold of 100 lines for never-recentering scrolling.
4779
e4cc2dfc
JB
47802011-03-31 Juanma Barranquero <lekktu@gmail.com>
4781
4782 * dispextern.h (move_it_by_lines):
4783 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4784 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4785 (message_log_check_duplicate): Remove parameters `prev_bol' and
4786 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4787 (redisplay_internal): Remove parameter `preserve_echo_area',
4788 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4789
4790 * indent.c (Fvertical_motion):
4791 * window.c (window_scroll_pixel_based, Frecenter):
4792 Don't pass `need_y_p' to `move_it_by_lines'.
4793
1c470562
SM
47942011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4795
44f230aa
SM
4796 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4797 steal a few bits to be more compact.
4798 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4799 Remove unneeded casts.
4800
1c470562
SM
4801 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4802
888adce9
ZK
48032011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4804
4805 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4806 binding" message (bug#7967).
4807
f838ed7b
PE
48082011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4809
77861b95
PE
4810 Fix more problems found by GCC 4.6.0's static checks.
4811
de6dbc14
PE
4812 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4813 Remove unused local var.
4814
f838ed7b
PE
4815 * editfns.c (Fmessage_box): Remove unused local var.
4816
792c7b2b
PE
4817 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4818 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4819 Omit unused local vars.
c499e557 4820 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4821 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4822 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4823 Omit unused local var.
4824
ba0165e1
PE
4825 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4826 Don't assume string length fits in int.
32ad8845 4827 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4828 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4829
3c59b4c9
PE
4830 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4831 instead of alloca (Bug#8344).
4832
a3eed478 4833 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4834 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4835
eb4d412d
PE
4836 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4837
1658b401
PE
4838 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4839 concerns.
4840
4841 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4842
4843 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4844
9a2c6e05
PE
4845 * keyboard.c (syms_of_keyboard): Use the same style as later
4846 in this function when indexing through an array. This also
4847 works around GCC bug 48267.
4848
03d0a109
PE
4849 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4850
44f730c8
PE
4851 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4852
fe75f926
PE
4853 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4854 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4855
ffa8c828
PE
4856 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4857 This avoids undefined behavior on integer overflow, and is a bit
4858 more convenient anyway since it is compared to a size_t variable.
4859
c5101a77
PE
4860 Variadic C functions now count arguments with size_t, not int.
4861 This avoids an unnecessary limitation on 64-bit machines, which
4862 caused (substring ...) to crash on large vectors (Bug#8344).
4863 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4864 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4865 All variadic functions and their callers changed accordingly.
c5101a77
PE
4866 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4867 * data.c (arith_driver, float_arith_driver): Likewise.
4868 * editfns.c (general_insert_function): Likewise.
4869 * eval.c (struct backtrace.nargs, interactive_p)
4870 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4871 (funcall_lambda, mark_backtrace): Likewise.
4872 * fns.c (concat): Likewise.
4873 * frame.c (x_set_frame_parameters): Likewise.
4874 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4875 0 if not found, not -1. All callers changed.
4876
dd3f25f7
PE
4877 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4878 (stack_copy_size): Now size_t, not int.
4879 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4880
461c2ab9
JB
48812011-03-28 Juanma Barranquero <lekktu@gmail.com>
4882
4883 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4884 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4885 All callers changed.
4886
4887 * lisp.h (multibyte_char_to_unibyte):
4888 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4889 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4890 * character.h (CHAR_TO_BYTE8):
4891 * cmds.c (internal_self_insert):
4892 * editfns.c (general_insert_function):
4893 * keymap.c (push_key_description):
4894 * search.c (Freplace_match):
4895 * xdisp.c (message_dolog, set_message_1): All callers changed.
4896
f6d62986
SM
48972011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4898
4899 * keyboard.c (safe_run_hook_funcall): New function.
4900 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4901 don't set the hook to nil, but remove the offending function instead.
4902 (Qcommand_hook_internal): Remove, unused.
4903 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4904 Vcommand_hook_internal.
4905
4906 * eval.c (enum run_hooks_condition): Remove.
4907 (funcall_nil, funcall_not): New functions.
4908 (run_hook_with_args): Call each function through a `funcall' argument.
4909 Remove `cond' argument, now redundant.
4910 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4911 (Frun_hook_with_args_until_failure): Adjust accordingly.
4912 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4913
1db5b1ad
JB
49142011-03-28 Juanma Barranquero <lekktu@gmail.com>
4915
4916 * dispextern.h (string_buffer_position): Remove declaration.
4917
4918 * print.c (strout): Remove parameter `multibyte', unused since
4919 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4920
4921 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4922 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4923 All callers changed.
4924
4925 * w32.c (_wsa_errlist): Use braces for struct initializers.
4926
4927 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4928 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4929 All callers changed.
4930 (string_buffer_position): Likewise. Also, make static (it's never
4931 used outside xdisp.c).
4932 (cursor_row_p): Remove parameter `w', unused since
4933 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4934 (decode_mode_spec): Remove parameter `precision', introduced during
4935 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4936 All callers changed.
4937
5ffb62aa
JD
49382011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4939
4940 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4941
461c2ab9 49422011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4943
4944 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4945 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4946 (ns_update_auto_hide_menu_bar): New functions.
4947 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4948 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4949 ns_constrain_all_frames.
4950 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4951 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4952
5c380ffb
JD
49532011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4954
4955 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4956
9af30bdf
GM
49572011-03-27 Glenn Morris <rgm@gnu.org>
4958
4959 * syssignal.h: Replace RETSIGTYPE with void.
4960 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4961 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4962 Replace SIGTYPE with void everywhere.
4963 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4964 * s/template.h (SIGTYPE): Remove commented out definition.
4965
e2abce01
JB
49662011-03-26 Eli Zaretskii <eliz@gnu.org>
4967
4968 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4969 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4970
f868cd8a
JB
49712011-03-26 Juanma Barranquero <lekktu@gmail.com>
4972
59eb0929
JB
4973 * w32.c (read_unc_volume): Use parameter `henum', instead of
4974 global variable `wget_enum_handle'.
4975
4976 * keymap.c (describe_vector): Remove parameters `indices' and
4977 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4978 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4979
f868cd8a
JB
4980 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4981
4982 * keyboard.c (timer_check): Remove parameter `do_it_now',
4983 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4984 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4985 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4986
4987 * keyboard.c (read_char):
4988 * w32menu.c (w32_menu_display_help):
4989 * xmenu.c (show_help_event, menu_help_callback):
4990 Adjust calls to `show_help_echo'.
4991
4992 * gtkutil.c (xg_maybe_add_timer):
4993 * keyboard.c (readable_events):
4994 * process.c (wait_reading_process_output):
4995 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4996
4997 * insdel.c (adjust_markers_gap_motion):
4998 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4999 (gap_left, gap_right): Don't call it.
5000
2ecf6fdb
CY
50012011-03-25 Chong Yidong <cyd@stupidchicken.com>
5002
5003 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5004 incurred during fontification.
5005
6b1f9ba4
JB
50062011-03-25 Juanma Barranquero <lekktu@gmail.com>
5007
5008 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5009 (DEFVAR_PER_BUFFER): Don't pass it.
5010
5011 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5012 (scrolling_window): Don't pass it.
5013
0f4a96b5
JB
50142011-03-25 Juanma Barranquero <lekktu@gmail.com>
5015
5016 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5017
5018 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5019 and `suffix'.
5020 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5021 of variables specific to SELinux and computation of `encoded_absname'.
5022
5023 * image.c (XPutPixel): Remove unused variable `height'.
5024
5025 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5026
5027 * unexw32.c (get_section_info): Remove unused variable `section'.
5028
5029 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5030 (system_process_attributes): Remove unused variable `sess'.
5031 (sys_read): Remove unused variable `err'.
5032
5033 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5034 (w32_wnd_proc): Remove unused variable `isdead'.
5035 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5036 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5037 (x_create_tip_frame): Remove unused variable `tem'.
5038
5039 * w32inevt.c (w32_console_read_socket):
5040 Remove unused variable `no_events'.
5041
5042 * w32term.c (x_draw_composite_glyph_string_foreground):
5043 Remove unused variable `width'.
5044
1149507c
JB
50452011-03-24 Juanma Barranquero <lekktu@gmail.com>
5046
5047 * w32term.c (x_set_glyph_string_clipping):
5048 Don't pass uninitialized region to CombineRgn.
5049
9c88f339
JB
50502011-03-23 Juanma Barranquero <lekktu@gmail.com>
5051
5052 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5053 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5054 (Fx_close_connection): Remove unused variable `i'.
5055
5056 * w32font.c (w32font_draw): Return number of glyphs.
5057 (w32font_open_internal): Remove unused variable `i'.
5058 (w32font_driver): Add missing initializer.
5059
5060 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5061 (fill_in_menu): Remove unused variable `items_added'.
5062
5063 * w32term.c (last_mouse_press_frame): Remove static global variable.
5064 (w32_clip_to_row): Remove unused variable `f'.
5065 (x_delete_terminal): Remove unused variable `i'.
5066
5067 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5068 (NOTHING): Remove unused static global variable.
5069 (uniscribe_check_otf): Remove unused variable `table'.
5070 (uniscribe_font_driver): Add missing initializers.
5071
dee091a3
JD
50722011-03-23 Julien Danjou <julien@danjou.info>
5073
5074 * term.c (Fsuspend_tty, Fresume_tty):
5075 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5076 * window.c (temp_output_buffer_show):
5077 * insdel.c (signal_before_change):
5078 * frame.c (Fhandle_switch_frame):
5079 * fileio.c (Fdo_auto_save):
5080 * emacs.c (Fkill_emacs):
5081 * editfns.c (save_excursion_restore):
5082 * cmds.c (internal_self_insert):
5083 * callint.c (Fcall_interactively):
5084 * buffer.c (Fkill_all_local_variables):
5085 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5086 Use Frun_hooks.
0f4a96b5 5087 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5088 unconditionnaly since it does the check itself.
5089
2c520ab5 50902011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5091
c9c49752
PE
5092 Fix more problems found by GCC 4.5.2's static checks.
5093
8abc3f12
PE
5094 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5095 the first time through the loop, since we know p0 < p1 then.
5096 This also avoids a gcc -Wstrict-overflow warning.
5097
a2d26660
PE
5098 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5099 leading to a memory leak, possible in functions like
5100 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5101 of objects (Bug#8318).
a2d26660 5102
916c72e9
PE
5103 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5104 that could (at least in theory) be that large.
5105
19ab8a18
PE
5106 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5107 This is less likely to overflow, and avoids undefined behavior if
5108 overflow does occur. All callers changed. Use strtoul to scan
5109 for the unsigned long integer.
b7cbbd6f
PE
5110 (pint2hrstr): Simplify and tune code slightly.
5111 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5112
f0641eff
PE
5113 * scroll.c (do_scrolling): Work around GCC bug 48228.
5114 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5115
7f650bb9
PE
5116 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5117 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5118 (validate_x_resource_name): Simplify count usage.
5119 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5120
37dd57d1
PE
5121 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5122 fail (Bug#8306).
81e56e61 5123
699979fc 5124 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5125
401bf9b4
PE
5126 * process.c (Fmake_network_process): Use socklen_t, not int,
5127 where POSIX says socklen_t is required in portable programs.
5128 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5129 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5130 (Fmake_network_process, server_accept_connection):
5131 (wait_reading_process_output, read_process_output):
5132 Likewise.
5133
b93aacde
PE
5134 * process.c: Rename or move locals to avoid shadowing.
5135 (list_processes_1, Fmake_network_process):
5136 (read_process_output_error_handler, exec_sentinel_error_handler):
5137 Rename or move locals.
4dc343ee 5138 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5139 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5140 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5141 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5142 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5143
af8a867c 5144 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5145 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5146 Include tparam.h instead, since it declares them.
af8a867c
PE
5147 * cm.h (PC): Remove extern decl; tparam.h now does this.
5148 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5149 * terminfo.c: Include tparam.h, to check interfaces.
5150 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5151 (tparam): Adjust signature to match interface in tparam.h;
5152 this removes some undefined behavior. Check that outstring and len
5153 are zero, which they always are with Emacs.
5154 * tparam.h (PC, BC, UP): New extern decls.
5155
0248044d 5156 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5157 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5158
8ff096c1 5159 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5160 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5161 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5162 (ftfont_list): Remove unused local.
49eaafba
PE
5163 (get_adstyle_property, ftfont_pattern_entity):
5164 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5165 Rename locals to avoid shadowing.
8ff096c1 5166
e2be39f6
PE
5167 * xfont.c (xfont_list_family): Mark var as initialized.
5168
c9735e30
PE
5169 * xml.c (make_dom): Now static.
5170
8f5201ae
PE
5171 * composite.c (composition_compute_stop_pos): Rename local to
5172 avoid shadowing.
b246f932
PE
5173 (composition_reseat_it): Remove unused locals.
5174 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5175 (composition_update_it): Mark var as initialized.
11b61122
PE
5176 (find_automatic_composition): Mark vars as initialized,
5177 with a FIXME (Bug#8290).
8f5201ae 5178
760fbc2c
PE
5179 character.h: Rename locals to avoid shadowing.
5180 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5181 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5182 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5183 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5184 to avoid shadowing.
5185
ff08eb85
PE
5186 * textprop.c (property_change_between_p): Remove; unused.
5187
fc7bf025
PE
5188 * intervals.c (interval_start_pos): Now static.
5189
235d7abc
PE
5190 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5191
44f230aa
SM
5192 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5193 Rename locals to avoid shadowing.
3e7d6594 5194
50060332
PE
5195 * sound.c (wav_play, au_play, Fplay_sound_internal):
5196 Fix pointer signedness.
d01f234b 5197 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5198 (wav_play): Initialize a variable to 0, to prevent undefined
5199 behavior (Bug#8278).
50060332 5200
c4fc4e30
PE
5201 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5202
918436ed
PE
5203 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5204
c939f91b
PE
5205 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5206 clobbering (Bug#8298).
b9c7f648
PE
5207 * sysdep.c (sys_subshell): Likewise.
5208 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5209
6bd8c144
PE
5210 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5211 This should get cleaned up, so that child_setup has the
5212 same signature on all platforms.
5213
7710357c 5214 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5215 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5216
c59da222
CY
52172011-03-22 Chong Yidong <cyd@stupidchicken.com>
5218
5219 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5220 not to be necessary, and produces flickering.
5221
66b87493
GM
52222011-03-20 Glenn Morris <rgm@gnu.org>
5223
5224 * config.in: Remove file.
5225
45b6f6d5
JB
52262011-03-20 Juanma Barranquero <lekktu@gmail.com>
5227
5228 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5229 are now in src/globals.h.
5230 (syms_of_minibuf): Remove spurious & from previous change.
5231
3ec03f7e
LL
52322011-03-20 Leo <sdl.web@gmail.com>
5233
5234 * minibuf.c (completing-read-function): New variable.
5235 (completing-read-default): Rename from completing-read.
5236 (completing-read): Call completing-read-function.
5237
b14e3e21
CY
52382011-03-19 Juanma Barranquero <lekktu@gmail.com>
5239
5240 * xfaces.c (Fx_load_color_file):
5241 Read color file from absolute filename (bug#8250).
5242
f2b726e6
JB
52432011-03-19 Juanma Barranquero <lekktu@gmail.com>
5244
5245 * makefile.w32-in: Update dependencies.
5246
09f6ff02
EZ
52472011-03-17 Eli Zaretskii <eliz@gnu.org>
5248
5249 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5250
29a6015a
PE
52512011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5252
a3a6c54e
PE
5253 Fix more problems found by GCC 4.5.2's static checks.
5254
b766f867
PE
5255 * process.c (make_serial_process_unwind, send_process_trap):
5256 (sigchld_handler): Now static.
5257
be02381c
PE
5258 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5259 That way, the code declares only the vars that it needs.
5260 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5261 * s/cygwin.h (PTY_ITERATION): Likewise.
5262 * s/darwin.h (PTY_ITERATION): Likewise.
5263 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5264
57048744
PE
5265 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5266 * process.c (allocate_pty): Don't declare stb unless it's needed.
5267
7914961c 5268 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5269 (CONSTANTLIM): Remove; unused.
5270 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5271 Define only if needed.
7914961c 5272
b3967b18
PE
5273 * unexelf.c (unexec): Name an expression,
5274 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5275 Use a different way to cause a compilation error if anyone uses
5276 n rather than nn, a way that does not involve shadowing.
73366a00 5277 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5278
29a6015a
PE
5279 * deps.mk (unexalpha.o): Remove; unused.
5280
43cfc33e 5281 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5282 * unexec.h: New file.
ce701a33
PE
5283 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5284 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5285 Depend on unexec.h.
5286 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5287 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5288 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5289 Change as necessary to match prototype in unexec.h.
ce701a33 5290
01f44d5a
PE
5291 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5292 shadowing.
4f63c6bb 5293 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5294
a6670b0b
PE
5295 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5296 Rename locals to avoid shadowing.
5297
cef2010d 5298 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5299 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5300
d4d7173a
PE
5301 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5302
f08b802a
PE
5303 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5304 warning when compiling print.c.
5305
3ddb0639
PE
5306 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5307 instead of using an uninitialized var.
5ad03b97 5308 (font_sort_entities): Mark var as initialized.
3ddb0639 5309
170a2692
PE
5310 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5311
e663c700
PE
5312 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5313 pointers to constants.
89bc529a 5314 (font_parse_fcname): Remove unused vars.
7b81e2d0 5315 (font_delete_unmatched): Now static.
ea838e10 5316 (font_get_spec): Remove; unused.
13a547c6
PE
5317 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5318 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5319 Rename or move locals to avoid shadowing.
e663c700 5320
2a80c887 5321 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5322 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5323
1384fa33 5324 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5325 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5326
8b2c52e9
PE
5327 * alloc.c (mark_backtrace): Move decl from here ...
5328 * lisp.h: ... to here, so that it can be checked.
5329
475545b5 5330 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5331 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5332 (lisp_indirect_variable): Name an expression,
5333 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5334 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5335
b1349114 5336 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5337 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5338 Use const pointer when appropriate.
b1349114 5339
a2928364
PE
5340 * lisp.h (get_system_name, get_operating_system_release):
5341 Move decls here, to check interfaces.
5342 * process.c (get_operating_system_release): Move decl to lisp.h.
5343 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5344 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5345 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5346 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5347 (Fformat_time_string, Fencode_time, Finsert_char):
5348 (Ftranslate_region_internal, Fformat):
5349 Rename or remove local vars to avoid shadowing.
9710023e 5350 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5351
a415e694
PE
5352 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5353 avoid shadowing.
5354
8ef4622d
PE
5355 * lisp.h (eassert): Check that the argument compiles, even if
5356 ENABLE_CHECKING is not defined.
5357
946f9a5b
PE
5358 * data.c (Findirect_variable): Name an expression, to avoid
5359 gcc -Wbad-function-cast warning.
112396d6 5360 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 5361 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
5362 (Fmake_variable_buffer_local, Fmake_local_variable):
5363 Mark variables as initialized.
52746918 5364 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 5365
e5aab7e7 5366 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
5367 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5368 Rename locals to avoid shadowing.
dff45157
PE
5369 (mark_stack): Move local variables into the #ifdef region where
5370 they're used.
7bc26fdb
PE
5371 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5372 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5373 needed otherwise.
5374 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5375 (GC_STRING_CHARS): Remove; not used.
d40d4be1 5376 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 5377
e5aab7e7
PE
5378 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5379 avoids undefined behavior in theory.
5380
4da60324
PE
5381 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5382
88043301
PE
5383 Use functions, not macros, for up- and down-casing (Bug#8254).
5384 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5385 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5386 to use the following functions instead of these macros.
5387 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5388 EMACS_INT, since callers assume the returned value fits in int.
5389 (upcase1): Likewise, for UPCASE_TABLE.
5390 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 5391 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 5392 the race-condition problem in the old DOWNCASE.
88043301 5393
19ed5445
PE
5394 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5395 Rename locals to avoid shadowing.
5396 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
5397 (regex_compile, re_search_2, re_match_2_internal):
5398 Remove unused local vars.
952db0d7
PE
5399 (FREE_VAR): Rewrite so as not to use empty "else",
5400 which gcc can warn about.
da053e48 5401 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
5402 (RETALLOC_IF): Define only if needed.
5403 (WORDCHAR_P): Likewise. This one is never needed, but is used
5404 only in a comment talking about a compiler bug, so put inside
5405 the #if 0 of that comment.
5406 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5407 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5408 Remove; unused.
19ed5445 5409
1f3561e4 5410 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
5411 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5412 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 5413
ded6f8f7
PE
5414 * search.c (simple_search): Remove unused var.
5415
dbd37a95
PE
5416 * dired.c (compile_pattern): Move decl from here ...
5417 * lisp.h: ... to here, so that it can be checked.
5418 (struct re_registers): New forward decl.
5419
7e47afad
PE
5420 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5421
85f24f61
PE
5422 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5423 All uses changed.
5424 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5425 Rename locals to avoid shadowing.
5671df8f 5426 (Fvertical_motion): Mark locals as initialized.
85f24f61 5427
181aa2be 5428 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 5429 (casify_region): Mark local as initialized.
181aa2be 5430
930d429c
PE
5431 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5432
7082eac6
PE
5433 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5434 New macros, so that the caller can use some names other than
5435 gcpro1, gcpro2, etc.
5436 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5437 of the new macros.
5438 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5439 argument, for consistency with GCPRO2_VAR, etc: it is now the
5440 prefix of the variable, not the variable itself. All uses
5441 changed.
38b2c076
PE
5442 * dired.c (directory_files_internal, file_name_completion):
5443 Rename locals to avoid shadowing.
5444
15206ed9
PE
5445 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5446 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5447 dired.c's scmp function, had undefined behavior.
5448 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5449 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5450 * buffer.h: ... to here, because these macros use current_buffer,
5451 and the new implementation with inline functions needs to have
5452 current_buffer in scope now, rather than later when the macros
5453 are used.
5454 (downcase, upcase1): New static inline functions.
5455 (DOWNCASE, UPCASE1): Reimplement using these functions.
5456 This avoids undefined behavior in expressions like
5457 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5458 from race conditions in accessing the global variables
5459 case_temp1 and case_temp2.
5460 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5461 * lisp.h (case_temp1, case_temp2): Remove their decls.
5462 * character.h (ASCII_CHAR_P): Move from here ...
5463 * lisp.h: ... to here, so that the inline functions mentioned
5464 above can use them.
5465
4a6bea26
PE
5466 * dired.c (directory_files_internal_unwind): Now static.
5467
f14b7e14
PE
5468 * fileio.c (file_name_as_directory, directory_file_name):
5469 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5470 Now static.
2893f146
PE
5471 (file_name_as_directory): Use const pointers when appropriate.
5472 (Fexpand_file_name): Likewise. In particular, newdir might
5473 point at constant storage, so make it a const pointer.
fd4ead52 5474 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5475 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5476 signedness issues.
f839df0c
PE
5477 (Fset_file_times, Finsert_file_contents, auto_save_error):
5478 Rename locals to avoid shadowing.
f14b7e14 5479
5716756e 5480 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5481 (Ftry_completion, Fall_completions): Rename or remove locals
5482 to avoid shadowing.
5716756e 5483
b4c3046a
PE
5484 * marker.c (bytepos_to_charpos): Remove; unused.
5485
b45db522
PE
5486 * lisp.h (verify_bytepos, count_markers): New decls,
5487 so that gcc does not warn that these functions aren't declared.
5488
85876d07
PE
5489 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5490 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5491 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5492 (copy_text): Remove unused local var.
85876d07 5493
03d78a21 5494 * filelock.c (within_one_second): Now static.
b3dd38ab 5495 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5496
5df8f01b
PE
5497 * buffer.c (fix_overlays_before): Mark locals as initialized.
5498 (fix_start_end_in_overlays): Likewise. This function should be
5499 simplified by using pointers-to-pointers, but that's a different
5500 matter.
b1d876f1 5501 (switch_to_buffer_1): Now static.
8f54f30a
PE
5502 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5503 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5504
a70072c9 5505 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5506 Fix pointer signedness issue.
edced198
PE
5507 (sys_subshell): Mark local as volatile if checking for lint,
5508 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5509 (MAXPATHLEN): Define only if needed.
a70072c9 5510
a0977c44
PE
5511 * process.c (serial_open, serial_configure): Move decls from here ...
5512 * systty.h: ... to here, so that they can be checked.
5513
a884fdcc
PE
5514 * fns.c (get_random, seed_random): Move extern decls from here ...
5515 * lisp.h: ... to here, so that they can be checked.
5516
604efe86 5517 * sysdep.c (reset_io): Now static.
b8950c94 5518 (wait_for_termination_signal): Remove; unused.
604efe86 5519
38fc62d9
PE
5520 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5521 (copy_keymap_item, append_key, push_text_char_description):
5522 Now static.
1004a21a 5523 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5524 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5525 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5526 (describe_map_tree):
5527 Rename locals to avoid shadowing.
38fc62d9 5528
2f2650da
PE
5529 * keyboard.c: Declare functions static if they are not used elsewhere.
5530 (echo_char, echo_dash, cmd_error, top_level_2):
5531 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5532 (read_char, kbd_buffer_get_event, make_lispy_position):
5533 (make_lispy_event, make_lispy_movement, apply_modifiers):
5534 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5535 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5536 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5537 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5538 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5539
a053e86c 5540 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5541 (mark_kboards): Move decl here ...
5542 * alloc.c (mark_kboards): ... from here.
a053e86c 5543
4752793e
PE
5544 * lisp.h (force_auto_save_soon): New decl.
5545
74f10ca7 5546 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5547 (DEFINE_DUMMY_FUNCTION): New macro.
5548 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5549 Use it.
c03cd23f
PE
5550 (main): Add casts to avoid warnings
5551 if GCC considers string literals to be constants.
74f10ca7 5552
022e70d4
PE
5553 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5554
59d6fe83
PE
5555 * dbusbind.c: Pointer signedness fixes.
5556 (xd_signature, xd_append_arg, xd_initialize):
5557 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5558 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5559 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5560 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5561
78320123
PE
5562 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5563 if GCC considers string literals to be constants.
49cebcca 5564 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5565
35ac2a97
SM
55662011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5567
fb103ca9
SM
5568 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5569 (print_preprocess, print_object): New macro to fix last change.
5570
35ac2a97
SM
5571 * print.c (print_preprocess): Don't forget font objects.
5572
62973b41
JB
55732011-03-16 Juanma Barranquero <lekktu@gmail.com>
5574
5575 * emacs.c (USAGE3): Doc fixes.
5576
0e48bb22
AS
55772011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5578
5579 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5580 structure.
5581
7684e57b
JB
55822011-03-14 Juanma Barranquero <lekktu@gmail.com>
5583
5584 * lisp.h (VWindow_system, Qfile_name_history):
5585 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5586 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5587 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5588
5589 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5590 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5591
5592 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5593 * w32console.c (detect_input_pending, read_input_pending)
5594 (encode_terminal_code):
5595 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5596 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5597 (w32_system_caret_y, Qfile_name_history):
5598 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5599 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5600 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5601 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5602 * w32proc.c (Qlocal, report_file_error):
5603 * w32term.c (Vwindow_system, updating_frame):
5604 * w32uniscribe.c (initialized, uniscribe_font_driver):
5605 Remove unneeded extern declarations.
5606
2aa46d6c
CY
56072011-03-14 Chong Yidong <cyd@stupidchicken.com>
5608
c96bbc66 5609 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5610
cffc6f3b
CY
56112011-03-13 Chong Yidong <cyd@stupidchicken.com>
5612
5613 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5614 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5615 These macros can no longer be used for assignment.
5616
44f230aa
SM
5617 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5618 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5619 (record_buffer_markers, fetch_buffer_markers): New functions for
5620 recording and fetching special buffer markers.
5621 (set_buffer_internal_1, set_buffer_temp): Use them.
5622
5623 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5624
5625 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5626
5627 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5628 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5629
5630 * xdisp.c (hscroll_window_tree):
5631 (reconsider_clip_changes): Use PT instead of BUF_PT.
5632
d251f04b
EZ
56332011-03-13 Eli Zaretskii <eliz@gnu.org>
5634
5635 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5636 $(EMACS_ROOT)/lib/intprops.h.
5637
f0c77cd1
PE
56382011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5639
3eca4629
PE
5640 Fix more problems found by GCC 4.5.2's static checks.
5641
7c86ee98
PE
5642 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5643 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5644 (xg_free_frame_widgets): Make it clear that a local variable is
5645 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5646 (gdk_window_get_screen): Make it clear that this macro is needed
5647 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5648 (int_gtk_range_get_value): New function, which avoids a diagnostic
5649 from gcc -Wbad-function-cast.
5650 (xg_set_toolkit_scroll_bar_thumb): Use it.
5651 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5652 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5653 (get_utf8_string, xg_get_file_with_chooser):
5654 Rename locals to avoid shadowing.
5655 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5656
41729b81
PE
5657 * xgselect.c (xg_select): Remove unused var.
5658
f0c77cd1
PE
5659 * image.c (four_corners_best): Mark locals as initialized.
5660 (gif_load): Initialize transparent_p to zero (Bug#8238).
5661 Mark another local as initialized.
ec6cf4c6 5662 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5663
ce0ad53d 5664 * image.c (clear_image_cache): Now static.
d5d5a617 5665 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5666 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5667 (x_edge_detection): Remove unnecessary cast that
5668 gcc -Wbad-function-cast diagnoses.
2037898d 5669 (gif_load): Fix pointer signedness.
6ae141d6
PE
5670 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5671 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5672
33383987 56732011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5674
d32df629
PE
5675 Improve quality of tests for time stamp overflow.
5676 For example, without this patch (encode-time 0 0 0 1 1
5677 1152921504606846976) returns the obviously-bogus value (-948597
5678 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5679 reports time overflow. See
5680 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5681 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5682 * editfns.c: Include limits.h and intprops.h.
5683 (TIME_T_MIN, TIME_T_MAX): New macros.
5684 (time_overflow): Move earlier, to before first use.
5685 (hi_time, lo_time): New functions, for an accurate test for
5686 out-of-range times.
5687 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5688 (Fget_internal_run_time): Don't assume time_t fits in int.
5689 (make_time): Use list2 instead of Fcons twice.
5690 (Fdecode_time): More accurate test for out-of-range times.
5691 (check_tm_member): New function.
5692 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5693 (lisp_time_argument): Don't rely on undefined left-shift and
5694 right-shift behavior when checking for time stamp overflow.
8be6f318 5695
fe31d94c
PE
5696 * editfns.c (time_overflow): New function, refactoring common code.
5697 (Fformat_time_string, Fdecode_time, Fencode_time):
5698 (Fcurrent_time_string): Use it.
5699
8be6f318
PE
5700 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5701 * dired.c (make_time): Move to ...
5702 * editfns.c (make_time): ... here.
5703 * systime.h: Note the move.
5704
09d9db2c 57052011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 5706
126bc0dc
YM
5707 * fringe.c (update_window_fringes): Remove unused variables.
5708
c47cbdfd
YM
5709 * unexmacosx.c (copy_data_segment): Also copy __got section.
5710 (Bug#8223)
5711
7ac80be9
EZ
57122011-03-12 Eli Zaretskii <eliz@gnu.org>
5713
c96bbc66 5714 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5715 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5716 Constify `char *' arguments and their references according to
5717 prototypes in tparam.h.
5718
ecb0f94d 5719 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5720
7ac80be9
EZ
5721 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5722 Adapt all references accordingly.
5723
5724 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5725
ef1fd07e
TT
57262011-03-11 Tom Tromey <tromey@redhat.com>
5727
5728 * buffer.c (syms_of_buffer): Remove obsolete comment.
5729
7ef4b50c
EZ
57302011-03-11 Eli Zaretskii <eliz@gnu.org>
5731
5732 * termhooks.h (encode_terminal_code): Declare prototype.
5733
5734 * msdos.c (encode_terminal_code): Don't declare prototype.
5735
5736 * term.c (encode_terminal_code): Now external again, used by
5737 w32console.c and msdos.c.
5738
44f230aa
SM
5739 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5740 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 5741
4b1ec863 57422011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 5743
1714f52b 5744 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 5745
4b1ec863
PE
5746 * fringe.c (update_window_fringes): Mark locals as initialized
5747 (Bug#8227).
5748 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 5749
524c7aa6
PE
5750 * alloc.c (mark_fringe_data): Move decl from here ...
5751 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5752 to check its interface.
5753 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5754
a5c0af81 5755 * fontset.c (free_realized_fontset): Now static.
7519b8cd 5756 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 5757 (fontset_font): Mark local as initialized.
a9a06e0b 5758 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 5759
b4716021
PE
5760 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5761
811e9bac 5762 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 5763 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
5764 (x_own_selection, Fx_disown_selection_internal): Rename locals
5765 to avoid shadowing.
5766 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 5767
7e3ab302
PE
5768 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5769 so that the caller can use some name other than gcpro1.
5770 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
5771 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5772 (Fx_backspace_delete_keys_p):
5773 Use them to avoid shadowing, and rename vars to avoid shadowing.
5774 (x_decode_color, x_set_name, x_window): Now static.
6b437900 5775 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 5776 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
5777 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5778 Remove unused locals.
7e3ab302
PE
5779 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5780 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5781 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5782 macros.
f78faa98 5783
e2b13473
PE
5784 * xterm.h (x_mouse_leave): New decl.
5785
77f23912
PE
5786 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5787 Remove unused functions.
cdf4ba58
PE
5788 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5789 (x_calc_absolute_position): Now static.
7411c686 5790 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5791 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5792 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5793 unless they are used.
38d0b34a
PE
5794 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5795 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5796 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5797 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5798 (x_error_catcher, x_connection_closed, x_error_handler):
5799 (x_error_quitter, xembed_send_message, x_iconify_frame):
5800 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5801 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5802 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5803
44f230aa
SM
5804 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5805 Rename or move locals to avoid shadowing.
6b463e58 5806 (tty_defined_color, merge_face_heights): Now static.
5967d051 5807 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5808 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5809 does not deduce is never used uninitialized.
73719eba
PE
5810 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5811 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5812
426994c3 5813 * terminal.c (store_terminal_param): Now static.
5489860b 5814
032f1620 5815 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5816 (set_frame_menubar): Remove unused local.
d4323972 5817 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5818 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5819 since they might point to immutable storage.
281585b0
PE
5820 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5821 since it's unused otherwise.
032f1620 5822
367c19e5 5823 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5824 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5825 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5826 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5827 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5828 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5829 does not deduce are never used uninitialized.
70739cbe 5830
07b48fa9
PE
5831 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5832
8868a238 5833 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5834 * window.c (window_loop, size_window):
5835 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5836
7e5cf297 5837 * window.c (display_buffer): Now static.
d6550a9f
PE
5838 (size_window): Mark variables that gcc -Wuninitialized
5839 does not deduce are never used uninitialized.
a586633d
PE
5840 * window.h (check_all_windows): New decl, to forestall
5841 gcc -Wmissing-prototypes diagnostic.
5b555da1 5842 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 5843
f6095868
PE
5844 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5845 shadowing.
5846 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5847 Include <limits.h>.
5848 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5849 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5850 (load_charset_map): Mark variables that gcc -Wuninitialized
5851 does not deduce are never used uninitialized.
53df7c11 5852 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5853
f38b440c
PE
5854 * coding.c (coding_set_source, coding_set_destination):
5855 Use "else { /* comment */ }" rather than "else /* comment */;"
5856 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5857 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5858 a block, when the outer 'i' will do.
5859 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5860 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5861 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5862 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5863 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5864 Rename locals to avoid shadowing.
5865 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5866 * coding.c (emacs_mule_char, encode_invocation_designation):
5867 Now static, since they're not used elsewhere.
413bb2db 5868 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5869 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5870 (decode_coding_emacs_mule): Mark variables that gcc
5871 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5872 (detect_coding_iso_2022): Initialize a local variable that might
5873 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5874 this initialization is needed. (Bug#8211)
5f58e762
PE
5875 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5876 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5877 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5878 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5879 Remove unused macros.
f38b440c 5880
232b38b9 5881 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5882 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5883 * character.c (string_count_byte8): Likewise.
232b38b9 5884
fb90da1b
PE
5885 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5886 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5887
fb93dbc2
PE
5888 * chartab.c (copy_sub_char_table): Now static, since it's not used
5889 elsewhere.
5c156ace
PE
5890 (sub_char_table_ref_and_range, char_table_ref_and_range):
5891 Rename locals to avoid shadowing.
bbcd0949 5892 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5893
7d3b3862 5894 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5895 (BIDI_BOB): Remove unused macro.
7d3b3862 5896
6be7d3da
PE
5897 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5898 deduce are never used uninitialized.
c2ed9c8b 5899 * term.c (encode_terminal_code): Likewise.
6be7d3da 5900
75f8807f 5901 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5902
50938595
PE
5903 * tparam.h: New file.
5904 * term.c, tparam.h: Include it.
5905 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5906 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5907 Move these decls to tparam.h, and make them agree with what
5908 is actually in tparam.c. The previous trick of using incompatible
5909 decls in different modules does not conform to the C standard.
5910 All callers of tparam changed to use tparam's actual API.
5911 * tparam.c (tparam1, tparam, tgoto):
5912 Use const pointers where appropriate.
5913
fbceeba2
PE
5914 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5915 * cm.h (struct cm): Likewise.
5916 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5917 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5918 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5919 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5920 (turn_on_face, init_tty): Likewise.
5921 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5922
7f3f1250
PE
5923 * term.c (term_mouse_position): Rename local to avoid shadowing.
5924
e6ca6543
PE
5925 * alloc.c (mark_ttys): Move decl from here ...
5926 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5927
c40f8d15
AS
59282011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5929
5930 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5931
cfe0661d
JB
59322011-03-09 Juanma Barranquero <lekktu@gmail.com>
5933
5934 * search.c (compile_pattern_1): Remove argument regp, unused since
5935 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5936 (compile_pattern): Don't pass it.
5937
0afb4571
J
59382011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5939
5940 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5941 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5942 for ! HAVE_GTK3.
5943 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5944
5945 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5946
5947 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5948 gdk_window_get_screen, gdk_window_get_geometry,
5949 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5950 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5951 (xg_get_pixbuf_from_pixmap): New function.
5952 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5953 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5954 Call xg_get_pixbuf_from_pixmap instead of
5955 gdk_pixbuf_get_from_drawable.
5956 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5957 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5958 (xg_check_special_colors): Use GtkStyleContext and its functions
5959 for HAVE_GTK3.
5960 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5961 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5962 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5963 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5964 Call gtk_widget_get_preferred_size.
0afb4571
J
5965 (xg_frame_resized): gdk_window_get_geometry only takes 5
5966 parameters.
44f230aa
SM
5967 (xg_win_to_widget, xg_event_is_for_menubar):
5968 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5969 (xg_set_widget_bg): New function.
5970 (delete_cb): New function.
895009e1 5971 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5972 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5973 (xg_set_background_color): Call xg_set_widget_bg.
5974 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5975 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5976 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5977 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5978 if ! HAVE_GTK3.
5979 (update_frame_tool_bar): Call gtk_widget_hide.
5980 (xg_initialize): Use GDK_KEY_g.
5981
5982 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5983 if ! HAVE_GTK3
5984 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5985
5986 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5987 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5988 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5989
1c2cc4ef
JB
59902011-03-08 Juanma Barranquero <lekktu@gmail.com>
5991
5992 * w32xfns.c (select_palette): Check success of RealizePalette against
5993 GDI_ERROR, not zero.
5994
33383987 5995See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5996
5997;; Local Variables:
5998;; coding: utf-8
aac0c6e3
MR
5999;; End:
6000
33383987 6001 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
6002
6003 This file is part of GNU Emacs.
6004
6005 GNU Emacs is free software: you can redistribute it and/or modify
6006 it under the terms of the GNU General Public License as published by
6007 the Free Software Foundation, either version 3 of the License, or
6008 (at your option) any later version.
6009
6010 GNU Emacs is distributed in the hope that it will be useful,
6011 but WITHOUT ANY WARRANTY; without even the implied warranty of
6012 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6013 GNU General Public License for more details.
6014
6015 You should have received a copy of the GNU General Public License
6016 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.