* subr.el (accept-change-group): Fix arg usage.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
888bec30
PE
12012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2
1068fe4d
PE
3 Fix minor GTK3 problems found by static checking.
4 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
6 (struct _EmacsFixedClass, emacs_fixed_get_type):
7 Move decls here from emacsgtkfixed.h, since they needn't be public.
8 (emacs_fixed_get_type): Now static.
9 (emacs_fixed_class_init): Omit unused local.
10 (emacs_fixed_child_type): Remove; unused.
11 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
12 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
13 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
14 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
15 (EMACS_FIXED_GET_CLASS): Remove; unused.
16 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
17
888bec30
PE
18 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
19 Problem reported by Juanma Barranquero for Windows -Wunused-function.
20
de85e130
PE
212012-04-22 Paul Eggert <eggert@cs.ucla.edu>
22
d0baac98
PE
23 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
24 * gmalloc.c: (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
25 (__malloc_size_t, __malloc_ptrdiff_t):
26 Remove. All uses removed, replaced by the definiens if needed,
27 since we can assume C89 or better now.
28 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
29 (protect_malloc_state, align, get_contiguous_space)
30 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
31 (malloc_atfork_handler_child, malloc_enable_thread)
32 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
33 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
34 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
35 (special_realloc, _realloc_internal_nolock, _realloc_internal)
36 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
37 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
38 Define using prototypes, not old style.
39 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
40 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
41 (align): Don't assume that signed integer overflow wraps around.
42 Omit unused local var.
43 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
44 (_free_internal_nolock, memalign, mallochook, reallochook):
45 Omit no-longer-needed casts.
46 (valloc): Use getpagesize, not __getpagesize.
47 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
48 (struct hdr): The 'magic' member is now size_t, not unsigned long.
49
de85e130
PE
50 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
51
dcbf5805
MA
522012-04-22 Michael Albinus <michael.albinus@gmx.de>
53
54 Move functions from C to Lisp. Make non-blocking method calls
55 the default. Implement further D-Bus standard interfaces.
56
57 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
58 (QCdbus_request_name_allow_replacement)
59 (QCdbus_request_name_replace_existing)
60 (QCdbus_request_name_do_not_queue)
61 (QCdbus_request_name_reply_primary_owner)
62 (QCdbus_request_name_reply_in_queue)
63 (QCdbus_request_name_reply_exists)
64 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
65 (QCdbus_registered_serial, QCdbus_registered_method)
66 (QCdbus_registered_signal): New Lisp objects.
67 (XD_DEBUG_MESSAGE): Use sizeof.
68 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
69 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
70 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
71 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
72 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
73 (xd_signature, xd_append_arg): Allow float for integer types.
74 (xd_get_connection_references): New function.
75 (xd_get_connection_address): Rename from xd_initialize. Return
76 cached address.
77 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
78 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
79 level.
80 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
81 Return number of recounts.
82 (Fdbus_get_unique_name): Make stronger parameter check.
83 (Fdbus_message_internal): New defun.
84 (Fdbus_call_method, Fdbus_call_method_asynchronously)
85 (Fdbus_method_return_internal, Fdbus_method_error_internal)
86 (Fdbus_send_signal, Fdbus_register_service)
87 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
88 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
89 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
90 (Vdbus_compiled_version, Vdbus_runtime_version)
91 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
92 (Vdbus_message_type_method_return, Vdbus_message_type_error)
93 (Vdbus_message_type_signal): New defvars.
94 (Vdbus_registered_buses, Vdbus_registered_objects_table): Adapt
95 docstring.
96
52828e02
PE
972012-04-22 Paul Eggert <eggert@cs.ucla.edu>
98
da05bc4c
PE
99 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
100 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
101 Do not assume ptrdiff_t is the same width as 'int'.
102
52828e02
PE
103 * alloc.c: Handle unusual debugging option combinations.
104 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
105 since the two debugging options are incompatible.
106 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
107 is defined.
108 (mem_init, mem_insert, mem_insert_fixup):
109 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
110 (NEED_MEM_INSERT): Remove; no longer needed.
111
f01769f9
LL
1122012-04-22 Leo Liu <sdl.web@gmail.com>
113
114 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
115
5790543d
PE
1162012-04-22 Paul Eggert <eggert@cs.ucla.edu>
117
118 * sysdep.c [__FreeBSD__]: Minor cleanups.
119 (list_system_processes, system_process_attributes) [__FreeBSD__]:
120 Use Emacs indenting style more consistently. Avoid some casts.
121 Use 'double' consistently rather than mixing 'float' and 'double'.
122
b91b7e4d
EW
1232012-04-21 Eduard Wiebe <usenet@pusto.de>
124
125 * sysdep.c (list_system_processes, system_process_attributes): Add
126 implementation for FreeBSD (Bug#5243).
127
6114eb15
AS
1282012-04-21 Andreas Schwab <schwab@linux-m68k.org>
129
130 * lisp.mk (lisp): Update.
131
2f38dff7
PE
1322012-04-20 Paul Eggert <eggert@cs.ucla.edu>
133
134 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
135 It is never used otherwise.
136
4ae29f89
SM
1372012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
138
139 * print.c (print_preprocess): Only check print_depth if print-circle
140 is nil.
141 (print_object): Check for cycles even when print-circle is nil and
142 print-gensym is t, but only check print_depth if print-circle is nil.
143
f30d612a
CY
1442012-04-20 Chong Yidong <cyd@gnu.org>
145
146 * process.c (wait_reading_process_output): If EIO occurs on a pty,
147 set the status to "failed" and ensure that sentinel is run.
148
c07a4c0b 1492012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
150
151 * process.c (Fset_process_inherit_coding_system_flag)
152 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 153 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 154
c07a4c0b 1552012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
156
157 * xdisp.c (string_buffer_position_lim): Limit starting position to
158 BEGV.
159 (set_cursor_from_row): If called for a mode-line or header-line
160 row, return zero immediately.
161 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
162 farther than the first row after the header line, if any.
163 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
164 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
165
c07a4c0b 1662012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 167
4ae29f89
SM
168 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
169 (bug#11238).
ad3a2b41 170
c07a4c0b 1712012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 1722012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
173
174 configure: new option --enable-gcc-warnings (Bug#11207)
175 * Makefile.in (C_WARNINGS_SWITCH): Remove.
176 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
177 (ALL_CFLAGS): Use new macros rather than old.
178 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
179 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
180 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
181 -Wunused-result, -Wunused-variable. This should go away once
182 the Emacs and Gnulib regex code is merged.
183 (xmalloc, xrealloc): Now static.
184
aba027e8
PE
1852012-04-17 Paul Eggert <eggert@cs.ucla.edu>
186
187 * dired.c (Fsystem_groups): Remove unused local.
188
e5a36063
GM
1892012-04-17 Glenn Morris <rgm@gnu.org>
190
191 * dired.c (Fsystem_users): Doc fix.
192
316411f0
DA
1932012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
194
195 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
196 (syms_of_dired): Add them.
197
9426aba4
PE
1982012-04-16 Paul Eggert <eggert@cs.ucla.edu>
199
b62a57be
PE
200 Fix minor alloc.c problems found by static checking.
201 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
202 New extern decls, to avoid calling undeclared functions.
203 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
204 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
205 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
206 (NEED_MEM_INSERT): New macro.
207 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 208 Remove one incorrect comment and fix another.
b62a57be 209
3539f31f
PE
210 Fix minor ralloc.c problems found by static checking.
211 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
212 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
213 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
214 (r_alloc_sbrk): Now static.
215
a041960a
PE
216 Improve ralloc.c interface checking.
217 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
218 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
219 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
220 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
221 [REL_ALLOC]: ... to here, to check interface.
222 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
223 Remove decls. This fixes an "It stinks!".
224
9426aba4
PE
225 * alloc.c (which_symbols): Fix alignment issue / type clash.
226
d55c12ed
AS
2272012-04-15 Andreas Schwab <schwab@linux-m68k.org>
228
229 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
230 (struct Lisp_Misc_Any): Likewise.
231 (struct Lisp_Free): Likewise.
232 * alloc.c (union aligned_Lisp_Symbol): Define.
233 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
234 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
235 (union aligned_Lisp_Misc): Define.
236 (MARKER_BLOCK_SIZE, struct marker_block): Use union
237 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 238 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 239
b948ce8b
PE
2402012-04-14 Paul Eggert <eggert@cs.ucla.edu>
241
242 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
243 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
244 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
245 * s/netbsd.h, s/sol2-6.h:
246 Remove definition of GC_MARK_STACK, since the default now works.
247 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
248 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
249 no longer the default.
250 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
251
35dc09a1 2522012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 253
35dc09a1
GM
254 * lread.c (lisp_file_lexically_bound_p):
255 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 256
35dc09a1
GM
2572012-04-14 Eli Zaretskii <eliz@gnu.org>
258
259 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
260 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
261
2622012-04-14 Jan Djärv <jan.h.d@swipnet.se>
263
264 * nsterm.m (constrainFrameRect): Always constrain when there is only
265 one screen (Bug#10962).
266
bcd86815
KB
2672012-04-13 Ken Brown <kbrown@cornell.edu>
268
269 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
270
c25df26e
RT
2712012-04-13 Reuben Thomas <rrt@sc3d.org>
272
273 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
274
0fc59f1e
DC
2752012-04-11 Daniel Colascione <dancol@dancol.org>
276
277 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
278 against is gone. It's better to use vfork now so that when Cygwin
279 gains a new, working vfork, we use it automatically (bug#10398).
280
de8c03dc
SM
2812012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
282
283 * window.c (save_window_save): Obey window-point-insertion-type.
284
2f097256
GM
2852012-04-11 Glenn Morris <rgm@gnu.org>
286
287 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
288
453b951e
SM
2892012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
290
291 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
292
75f1671a 2932012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
294
295 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
296 (force_quit_count): New var.
297 (handle_interrupt): Use it.
298
2a8ce227
JB
2992012-04-10 Juanma Barranquero <lekktu@gmail.com>
300
301 * w32.c (w32_delayed_load): Record the full path of the library
302 being loaded (bug#10424).
303
935396c0
GM
3042012-04-09 Glenn Morris <rgm@gnu.org>
305
05920a43
GM
306 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
307 not just in the obarray, before snarfing them. (Bug#11036)
308
935396c0
GM
309 * Makefile.in ($(leimdir)/leim-list.el):
310 Pass EMACS rather than BUILT_EMACS.
311
a18ecafa
TZ
3122012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
313
314 * process.c (make_process):
315 * process.h: Add integer `gnutls_handshakes_tried' member to
316 process struct.
317
6bbef4e5
JC
318 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
319 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
320
321 * gnutls.c (gnutls_log_function2i): Convenience log function.
322 (emacs_gnutls_read): Use new log functions,
323 `gnutls_handshakes_tried' process member, and
324 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
325 attempts per process (connection).
326
b4d3bc10
CY
3272012-04-09 Chong Yidong <cyd@gnu.org>
328
329 * eval.c (Fuser_variable_p, user_variable_p_eh)
330 (lisp_indirect_variable): Functions deleted.
331 (Fdefvar): Caller changed.
332
333 * callint.c (Finteractive, Fcall_interactively):
334 * minibuf.c (Fread_variable): Callers changed.
335
70f4d973
EZ
3362012-04-09 Eli Zaretskii <eliz@gnu.org>
337
338 * xdisp.c (set_cursor_from_row): If the display string appears in
339 the buffer at position that is closer to point than the position
340 after the display string, display the cursor on the first glyph of
341 the display string. Fixes cursor display when a 'display' text
342 property immediately follows invisible text. (Bug#11094)
343
cb3c2e3e
PE
3442012-04-09 Paul Eggert <eggert@cs.ucla.edu>
345
346 composite.c: use 'double' consistently
347 * composite.c (get_composition_id): Use 'double' consistently
348 instead of converting 'float' to 'double' and vice versa; this is
349 easier to understand and avoids a GCC warning.
350
fd06db5d
GM
3512012-04-09 Glenn Morris <rgm@gnu.org>
352
50fe702a
GM
353 * Makefile.in: Generate leim-list with bootstrap-emacs, in
354 preparation for dumping it with emacs. (Bug#4789)
355 (leimdir): New variable.
356 ($(leimdir)/leim-list.el): New rule.
357 (emacs$(EXEEXT)): Depend on leim-list.el.
358
fd06db5d
GM
359 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
360 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
361 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
362
55c131ee
AS
3632012-04-08 Andreas Schwab <schwab@linux-m68k.org>
364
365 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
366 proper alignment.
367
9209588f
JB
3682012-04-07 Juanma Barranquero <lekktu@gmail.com>
369
370 * xml.c (init_libxml2_functions) [WINDOWSNT]:
371 Remove unused local variable.
372
e3fb2efb
PE
3732012-04-07 Paul Eggert <eggert@cs.ucla.edu>
374
375 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
376 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
377 (mark_memory): Mark Lisp_Objects only if pointers might hide in
378 objects, as mark_maybe_pointer will catch them otherwise.
379 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
380 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
381
b5385551
PE
3822012-04-07 Paul Eggert <eggert@cs.ucla.edu>
383
384 Fix typo that broke non-Windows builds.
385 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
386
9078ead6
EZ
3872012-04-07 Eli Zaretskii <eliz@gnu.org>
388
389 Support building on MS-Windows with libxml2.
390
391 * makefile.w32-in (OBJ2): Add xml.$(O).
392 (GLOBAL_SOURCES): Add xml.c.
393 ($(BLD)/xml.$(O)): New dependency list.
394
395 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
396 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
397 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
398 [!WINDOWSNT]: New macros.
399 (init_libxml2_functions, libxml2_loaded_p): New functions.
400 (parse_region): Call fn_xmlCheckVersion instead of using the macro
401 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
402 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
403 Calls xmlCleanupParser only if libxml2 was loaded (or statically
404 linked in).
6bbef4e5
JC
405 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
406 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
407 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
408
409 * emacs.c: Don't include libxml/parser.h.
410 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
411 xmlCleanupParser directly.
412
413 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
414
3811fdf3
EZ
4152012-04-07 Eli Zaretskii <eliz@gnu.org>
416
417 * indent.c (Fvertical_motion): If there is a display string at
418 point, use it.vpos to compute how many lines to backtrack after
419 move_it_to point. (Bug#11133)
420
2f8e16b2
EZ
4212012-04-06 Eli Zaretskii <eliz@gnu.org>
422
423 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
424 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
425 about subtle differences between FETCH_CHAR* and STRING_CHAR*
426 macros related to unification of CJK characters. For the details,
427 see the discussion following the message here:
428 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
429
3d439cd1
CY
4302012-04-04 Chong Yidong <cyd@gnu.org>
431
432 * keyboard.c (Vdelayed_warnings_list): Doc fix.
433
8bc53d00
EZ
4342012-04-01 Eli Zaretskii <eliz@gnu.org>
435
436 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
437 instead of alloca. (Bug#11138)
438
3b0512a3
AS
4392012-04-01 Andreas Schwab <schwab@linux-m68k.org>
440
441 * w32menu.c (is_simple_dialog): Properly check lisp types.
442 (Bug#11141)
443
8427ddd2
EZ
4442012-03-31 Eli Zaretskii <eliz@gnu.org>
445
979022ef
EZ
446 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
447 position we get to after a call to move_it_to fails the
448 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
449 only if we wind up in a string from display property. (Bug#11063)
450
a6b1c7cc
EZ
451 * window.c (Fdelete_other_windows_internal): Invalidate the row
452 and column information about mouse highlight, so that redisplay
453 restores it after reallocating the glyph matrices. (Bug#7464)
454
8427ddd2
EZ
455 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
456 string comes from a `display' text property, use the buffer
457 position of that property as if we actually saw that position in
458 the row's glyphs.
697ba24b
EZ
459 (move_it_by_lines): Remove the assertion that
460 "it->current_x == 0 && it->hpos == 0" which can be legitimately
461 violated when there's a before-string at the beginning of a line.
462 (Bug#11063)
8427ddd2 463
65a0a738
EZ
4642012-03-30 Eli Zaretskii <eliz@gnu.org>
465
466 * xdisp.c (append_space_for_newline): If the default face was
467 remapped, use the remapped face for the appended newline.
468 (extend_face_to_end_of_line): Use the remapped default face for
469 extending the face to the end of the line.
470 (display_line): Call extend_face_to_end_of_line when the default
471 face was remapped. (Bug#11068)
472
581355cc
EZ
4732012-03-29 Eli Zaretskii <eliz@gnu.org>
474
475 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
476
e8fc049f
SM
4772012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
478
479 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
480
4fb9a543
GM
4812012-03-27 Glenn Morris <rgm@gnu.org>
482
483 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
484 Doc fixes.
485
679910f1
KH
4862012-03-26 Kenichi Handa <handa@m17n.org>
487
488 * dispextern.h (struct glyph): Fix previous change. Change the
489 bit length of glyphless.ch to 25 (Bug#11082).
490
90d49b7f
CY
4912012-03-26 Chong Yidong <cyd@gnu.org>
492
493 * keyboard.c (Vselection_inhibit_update_commands): New variable.
494 (command_loop_1): Use it; inhibit selection update for
495 handle-select-window too (Bug#8996).
496
f514f6f0
FP
4972012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
498
e8fc049f 499 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 500
bf43fa51
KH
5012012-03-25 Kenichi Handa <handa@m17n.org>
502
503 * dispextern.h (struct glyph): Change the bit length of
504 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
505
8a0c01dd
EZ
5062012-03-24 Eli Zaretskii <eliz@gnu.org>
507
508 * s/ms-w32.h (tzname): Include time.h before redirecting to
509 _tzname. Fixes the MSVC build. (Bug#9960)
510
7d1c3a76
AS
5112012-03-24 Andreas Schwab <schwab@linux-m68k.org>
512
8ed79523
AS
513 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
514 characters.
515
7d1c3a76
AS
516 * xterm.c (XTread_socket): Only modify handling_signal if
517 !SYNC_INPUT. (Bug#11080)
518
e99a9b8b
EZ
5192012-03-23 Eli Zaretskii <eliz@gnu.org>
520
521 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
522 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
523 when fetching a multibyte character consumes more bytes than
524 CHAR_BYTES returns, due to unification of CJK characters in
525 string_char. (Bug#11073)
526
5063c0e1
TN
5272012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
528
529 * process.c (wait_reading_process_output): Handle pty disconnect
530 by refraining from sending oneself a SIGCHLD (bug#10933).
531
9f851fbd
CY
5322012-03-22 Chong Yidong <cyd@gnu.org>
533
534 * dispextern.h (struct it): New member string_from_prefix_prop_p.
535
5063c0e1 536 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
537 Mark string as coming from a prefix property.
538 (handle_face_prop): Use default face for prefix strings (Bug#4281).
539 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
540
fb5b8aca
CY
5412012-03-21 Chong Yidong <cyd@gnu.org>
542
543 * xfaces.c (Vface_remapping_alist): Doc fix.
544
62356a1b
EZ
5452012-03-20 Eli Zaretskii <eliz@gnu.org>
546
547 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
548 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
549 Doc fixes.
62356a1b 550
025de85b
CY
5512012-03-20 Chong Yidong <cyd@gnu.org>
552
553 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
554 to reflect default non-nil value of redisplay-dont-pause.
555
4827f94e
KH
5562012-03-19 Kenichi Handa <handa@m17n.org>
557
558 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
559 it fit in a valid range (Bug#11003).
560
e50a24a2
EZ
5612012-03-18 Eli Zaretskii <eliz@gnu.org>
562
563 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
564 that is not from display property, accept the row as a "cursor
565 row" if one of the string's character has a non-nil `cursor'
566 property. Fixes cursor positioning when there are newlines in
567 overlay strings, e.g. in icomplete.el. (Bug#11035)
568
9af5ed87
PE
5692012-03-12 Paul Eggert <eggert@cs.ucla.edu>
570
571 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
572
d1f55f16
CY
5732012-03-12 Chong Yidong <cyd@gnu.org>
574
575 * eval.c (inhibit_lisp_code): Rename from
576 inhibit_window_configuration_change_hook; move from window.c.
577
578 * xfns.c (unwind_create_frame_1, Fx_create_frame):
579 * window.c (run_window_configuration_change_hook)
580 (syms_of_window): Callers changed.
581
66c5eebd
CY
5822012-03-11 Chong Yidong <cyd@gnu.org>
583
413df973
CY
584 * keymap.c (Fkey_description): Doc fix (Bug#9700).
585
66c5eebd
CY
586 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
587
1de11f56
CY
5882012-03-10 Chong Yidong <cyd@gnu.org>
589
590 * frame.c (other_visible_frames): Don't assume the selected frame
591 is visible (Bug#10955).
592
cae07000
SM
5932012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
594
595 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
596
89c94350
JD
5972012-03-08 Jan Djärv <jan.h.d@swipnet.se>
598
599 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
600 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
601 zero (Bug#10954).
602
999dd333
GM
6032012-03-03 Glenn Morris <rgm@gnu.org>
604
01a6dcc8 605 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 606
de0100f2
EZ
6072012-03-02 Eli Zaretskii <eliz@gnu.org>
608
609 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
610 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
611 (redisplay_window, next_element_from_string): Fix typos in
612 comments.
3e441275
EZ
613 (redisplay_window): Pass to move_it_vertically the margin in
614 pixels, not in screen lines.
de0100f2 615
96a72ee9
GM
6162012-03-02 Glenn Morris <rgm@gnu.org>
617
618 * buffer.c (buffer-list-update-hook): Doc fix.
619
312508d7
EZ
6202012-02-29 Eli Zaretskii <eliz@gnu.org>
621
622 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
623 push_it before setting up the iterator for the first overlay
624 string, even if we have an empty string loaded.
625 (next_overlay_string): If there's an empty string on the iterator
626 stack, pop the stack. (Bug#10903)
627
27f3c637
PE
6282012-02-25 Paul Eggert <eggert@cs.ucla.edu>
629
630 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
631 Suggested by Stefan Monnier in
632 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
633 * alloc.c (widen_to_Lisp_Object): New static function.
634 (mark_memory): Also mark Lisp_Objects by fetching pointer words
635 and widening them to Lisp_Objects. This would work even if
636 USE_LSB_TAG is defined and wide integers are used, which might
637 happen in a future version of Emacs.
638
3c9dfce6
CY
6392012-02-25 Chong Yidong <cyd@gnu.org>
640
fa74b241
CY
641 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
642 Doc fix.
643
3c9dfce6
CY
644 * xselect.c (Fx_selection_exists_p): Doc fix.
645 (x_clipboard_manager_save_all): Print an informative message
646 before saving to clipboard manager.
647
9486df08
CY
6482012-02-24 Chong Yidong <cyd@gnu.org>
649
650 * keyboard.c (process_special_events): Handle all X selection
651 requests in kbd_buffer, not just the next one (Bug#8869).
652
f01d3321
CY
6532012-02-23 Chong Yidong <cyd@gnu.org>
654
655 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
656 call when setting menu-bar-lines and tool-bar-lines parameters.
657 (unwind_create_frame_1): New helper function.
658
659 * window.c (inhibit_window_configuration_change_hook): New var.
660 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 661 (syms_of_window): Initialize it.
f01d3321 662
86b847b6
CY
6632012-02-22 Chong Yidong <cyd@gnu.org>
664
665 * xterm.c (x_draw_image_relief): Add missing type check for
666 Vtool_bar_button_margin (Bug#10743).
667
a59225b1
CY
6682012-02-21 Chong Yidong <cyd@gnu.org>
669
670 * fileio.c (Vfile_name_handler_alist): Doc fix.
671
672 * buffer.c (Fget_file_buffer): Protect against invalid file
673 handler return value.
674
310f5bd4
PE
6752012-02-20 Paul Eggert <eggert@cs.ucla.edu>
676
cb3a28cc
PE
677 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
678 when computing $valmask.
679
310f5bd4
PE
680 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
681 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
682 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
683 It's useless in that case, and it can cause problems on hosts
684 that allocate halves of EMACS_INT values separately.
685 Reported by Dan Horák. Diagnosed by Andreas Schwab in
686 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
687 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
688 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
689 it avoids undefined behavior on hosts where shifting right by more
690 than the word width has undefined behavior.
691
2375c96a
CY
6922012-02-19 Chong Yidong <cyd@gnu.org>
693
694 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
695 (Funhandled_file_name_directory, Ffile_name_as_directory)
696 (Fdirectory_file_name, Fexpand_file_name)
697 (Fsubstitute_in_file_name): Protect against invalid file handler
698 return values (Bug#10845).
699
3eb49e71
EZ
7002012-02-18 Eli Zaretskii <eliz@gnu.org>
701
702 * .gdbinit (pitx): Fix incorrect references to fields of the
703 iterator stack.
704
7b926f3f
CY
7052012-02-17 Chong Yidong <cyd@gnu.org>
706
707 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
708
11273115
PE
7092012-02-15 Paul Eggert <eggert@cs.ucla.edu>
710
711 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
712 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
713
c3a70e2b
CY
7142012-02-15 Chong Yidong <cyd@gnu.org>
715
716 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
717 marked as special. Also, starting docstrings with * is obsolete.
718
0ca43699
AS
7192012-02-13 Andreas Schwab <schwab@linux-m68k.org>
720
721 * gnutls.c (emacs_gnutls_write): Fix last change.
722
2e8f3c56
LI
7232012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
724
725 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
726 send_process.
727
af70074f
SM
7282012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
729
730 * keymap.c (Fsingle_key_description): Handle char ranges.
731
95986d52
CY
7322012-02-12 Chong Yidong <cyd@gnu.org>
733
afd83bd1
CY
734 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
735 as that creates a dangerous corner case.
736
95986d52
CY
737 * window.c (Fdelete_window_internal): Invalidate the mouse
738 highlight (Bug#9904).
739
bd7da63e
GM
7402012-02-12 Glenn Morris <rgm@gnu.org>
741
742 * xselect.c (Fx_own_selection_internal)
743 (Fx_get_selection_internal, Fx_disown_selection_internal)
744 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
745 * nsselect.m (Fx_own_selection_internal)
746 (Fx_disown_selection_internal, Fx_selection_exists_p)
747 (Fx_selection_owner_p, Fx_get_selection_internal):
748 Sync docs and argument specs with the xselect.c versions.
749
77abcbc2
LI
7502012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
751
752 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
753
90b671e2
EZ
7542012-02-11 Eli Zaretskii <eliz@gnu.org>
755
1c0ca0b7
EZ
756 * w32select.c (Fx_selection_exists_p): Sync doc string and
757 argument list with xselect.c. (Bug#10783)
758
759 * w16select.c (Fx_selection_exists_p): Sync doc string and
760 argument list with xselect.c. (Bug#10783)
90b671e2 761
49241268
GM
7622012-02-10 Glenn Morris <rgm@gnu.org>
763
764 * fns.c (Fsecure_hash): Doc fix.
765
f998bbe7 7662012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
767
768 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
769
0992bd9c
CY
7702012-02-07 Chong Yidong <cyd@gnu.org>
771
772 * buffer.c (Fbuffer_local_variables)
773 (buffer_lisp_local_variables): Handle unbound vars correctly;
774 don't let Qunbound leak into Lisp.
775
af008560
GM
7762012-02-07 Glenn Morris <rgm@gnu.org>
777
dd605cc4
GM
778 * image.c (Fimagemagick_types): Doc fix.
779
af008560
GM
780 * image.c (imagemagick-render-type): Change it from a lisp object
781 to an integer. Move the doc here from the lisp manual.
782 Treat all values not equal to 0 the same.
783
1449fa1d
CY
7842012-02-06 Chong Yidong <cyd@gnu.org>
785
786 * doc.c (store_function_docstring): Avoid applying docstring of
787 alias to base function (Bug#2603).
788
3723ec07
AS
7892012-02-04 Andreas Schwab <schwab@linux-m68k.org>
790
791 * .gdbinit (pp1, pv1): Remove redundant defines.
792 (pr): Use pp.
793
79c1cc1e
CY
7942012-02-04 Chong Yidong <cyd@gnu.org>
795
796 * nsterm.m: Declare a global (Bug#10694).
797
d7f29f8e
EZ
7982012-02-04 Eli Zaretskii <eliz@gnu.org>
799
cae07000
SM
800 * w32.c (get_emacs_configuration_options):
801 Include --enable-checking, if specified, in the return value.
d7f29f8e 802
3b95a6f9
MR
8032012-02-04 Martin Rudalics <rudalics@gmx.at>
804
805 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
806 after rounding frame sizes. (Bug#9723)
807
d6fa96a6
EZ
8082012-02-04 Eli Zaretskii <eliz@gnu.org>
809
810 * keyboard.c (adjust_point_for_property): Don't position point
811 before BEGV. (Bug#10696)
812
df0b2940
PE
8132012-02-03 Paul Eggert <eggert@cs.ucla.edu>
814
815 Handle overflow when computing char display width (Bug#9496).
816 * character.c (char_width): Return EMACS_INT, not int.
817 (char_width, c_string_width): Check for overflow when
818 computing the width; this is possible now that individual
819 characters can have unbounded width. Problem introduced
820 by merge from Emacs 23 on 2012-01-19.
821
6bee44d6
MA
8222012-02-02 Michael Albinus <michael.albinus@gmx.de>
823
824 * dbusbind.c (Fdbus_register_method): Mention the return value
825 :ignore in the docstring.
826
44f92739
GM
8272012-02-02 Glenn Morris <rgm@gnu.org>
828
1b9f60cc
GM
829 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
830
44f92739
GM
831 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
832 Unconditionally set to t. (Bug#10673)
833 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
834 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
835 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
836
c5d3843c
KH
8372012-02-02 Kenichi Handa <handa@m17n.org>
838
839 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
840 0, do not call append_composite_glyph.
841
159462d4 8422012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
843
844 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
845 NULL (Bug#6988).
846 (x_produce_glyphs): If the component of a composition is a null
847 string, set it->pixel_width to 1 to avoid zero-width glyph.
848
78cef877
EZ
8492012-02-01 Eli Zaretskii <eliz@gnu.org>
850
851 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
852 first 2 arguments are identical. This makes inserting large
853 output from a subprocess an order of magnitude faster on
854 MS-Windows, where all sbrk'ed memory is always contiguous.
855
97897668
GM
8562012-01-31 Glenn Morris <rgm@gnu.org>
857
858 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 859 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
860 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
861
31fd3586
GM
8622012-01-29 Glenn Morris <rgm@gnu.org>
863
864 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
865
0e24a8b2
CY
8662012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
867
868 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
869
cc0adcb0
CY
8702012-01-28 Chong Yidong <cyd@gnu.org>
871
872 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
873
acc28cb9
CY
8742012-01-26 Chong Yidong <cyd@gnu.org>
875
9c69cfb7
CY
876 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
877
acc28cb9
CY
878 * search.c (Fsearch_forward, Fsearch_backward): Document negative
879 repeat counts (Bug#10507).
880
48da7392
GM
8812012-01-26 Glenn Morris <rgm@gnu.org>
882
883 * lread.c (syms_of_lread): Doc fix.
884
14af5f7f
CY
8852012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
886
887 * coding.c (encode_designation_at_bol): Change return value to
888 EMACS_INT.
889
0b21c100
CY
8902012-01-25 Chong Yidong <cyd@gnu.org>
891
892 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
893
3c2907f7
CY
8942012-01-21 Chong Yidong <cyd@gnu.org>
895
896 * floatfns.c (Fcopysign): Make the second argument non-optional,
897 since nil is not allowed anyway.
898
959ad23f
AS
8992012-01-21 Andreas Schwab <schwab@linux-m68k.org>
900
901 * process.c (read_process_output): Use p instead of XPROCESS (proc).
902 (send_process): Likewise.
903
34a02f46
MR
9042012-01-19 Martin Rudalics <rudalics@gmx.at>
905
906 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
907 (Vwindow_persistent_parameters): Do not use Qstate.
908 Rewrite doc-strings.
34a02f46 909
1259009a 9102012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
911
912 * character.c (char_width): New function.
70d4fdf6
GM
913 (Fchar_width, c_string_width, lisp_string_width):
914 Use char_width (Bug#9496).
25ed9e61 915
6a6ee00d
MR
9162012-01-16 Martin Rudalics <rudalics@gmx.at>
917
918 * window.c (Vwindow_persistent_parameters): New variable.
919 (Fset_window_configuration, save_window_save): Handle persistent
920 window parameters.
921
c85efaf7
EZ
9222012-01-14 Eli Zaretskii <eliz@gnu.org>
923
924 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
925 thrashing the stack of the thread. (Bug#9087)
926
5944709e
PE
9272012-01-12 Paul Eggert <eggert@cs.ucla.edu>
928
929 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
930
e71f5d99
EZ
9312012-01-11 Eli Zaretskii <eliz@gnu.org>
932
933 * xdisp.c (rows_from_pos_range): Handle the case where the
934 highlight ends on a newline. (Bug#10464)
935 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
936 he end column for display of highlight that ends on a newline
937 before a R2L line.
938
ce316182
GM
9392012-01-11 Glenn Morris <rgm@gnu.org>
940
941 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
942 from load-path also when installation-directory is nil. (Bug#10208)
943
5b43da69
GM
9442012-01-10 Glenn Morris <rgm@gnu.org>
945
74cc8ff9
GM
946 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
947
7d8d6e4e
GM
948 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
949 Update template values to be closer to their typical values these days.
5b43da69 950
a0db8d43
EZ
9512012-01-09 Eli Zaretskii <eliz@gnu.org>
952
953 * xdisp.c (rows_from_pos_range): Accept additional argument
954 DISP_STRING, and accept any glyph in a row whose object is that
955 string as eligible for mouse highlight. Fixes mouse highlight of
956 display strings from overlays. (Bug#10464)
957
9a0115ab 9582012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 959
b9110d6a 960 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
961 * fileio.c (auto_saving_dir_umask): New static var.
962 (Fmake_directory_internal): Use it.
963 (do_auto_save_make_dir): Set it, instead of invoking chmod after
964 creating the directory. The old code temporarily assigns
965 too-generous permissions to the directory.
966 (do_auto_save_eh): Clear it.
b9110d6a 967 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
968 that the var is always cleared.
969
6c1bd3f3
EZ
9702012-01-07 Eli Zaretskii <eliz@gnu.org>
971
972 * search.c (scan_buffer): Pass character positions to
973 know_region_cache, not byte positions. (Bug#6540)
974
069d2b50
L
9752012-01-07 LynX <_LynX@bk.ru> (tiny change)
976
977 * w32.c (sys_rename): Report EXDEV when rename of a directory
978 fails because the target is on another logical disk. (Bug#10284)
979
75bf0d33
DB
9802012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
981
982 * xterm.c (x_embed_request_focus): New function.
983
984 * xterm.h: Add prototype.
985
986 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
987
1c6e5a32
GM
9882012-01-05 Glenn Morris <rgm@gnu.org>
989
990 * emacs.c (emacs_copyright): Update short copyright year to 2012.
991
651e947e
EZ
9922012-01-01 Eli Zaretskii <eliz@gnu.org>
993
994 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
995 Load gnutls_transport_set_lowat only if GnuTLS version is below
996 2.11.1.
997 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
998 GnuTLS versions below 2.11.1.
999
3778cdd8
AL
10002011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1001
1002 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1003 to the doc string advising against its use for altering the way
1004 windows are scrolled.
1005
0e5317f7
KH
10062011-12-28 Kenichi Handa <handa@m17n.org>
1007
1008 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1009 coding-system ASCII compatible only when it does not produce BOM
1010 on encoding (Bug#10383).
1011
93d5ca1f
JD
10122011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1013
1014 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1015 can scroll.
1016 (create_and_show_popup_menu): Always use menu_position_func for
1017 Gtk3 (Bug#10361).
1018
ca22b785
AS
10192011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1020
1021 * callint.c (Fcall_interactively): Don't truncate prompt string.
1022
d048e1e6
EZ
10232011-12-23 Eli Zaretskii <eliz@gnu.org>
1024
1025 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1026 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 1027 resumed from there (after widening). (Bug#10360)
d048e1e6 1028
5ccaba1f
JD
10292011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1030
1031 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1032
204ee57f
JD
10332011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1034
b81d40f0
JB
1035 * nsterm.m (x_free_frame_resources):
1036 Release f->output_data.ns->miniimage.
204ee57f
JD
1037 (ns_index_color): Fix indentation. Do not retain
1038 color_table->colors[i].
1039
1040 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1041 before returning.
1042
1043 * nsfns.m (x_set_background_color): Assign return value from
1044 ns_index_color to face-background instead of NSColor*.
1045 (ns_implicitly_set_icon_type): Fix indentation.
1046 Change assignment in for loop to comparison.
1047
1048 * emacs.c (ns_pool): New variable.
1049 (main): Assign ns_pool.
1050 (Fkill_emacs): Call ns_release_autorelease_pool.
1051
1052 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1053 autorelease fdesc, release fdAttrs and tdict.
1054 (ns_get_covering_families): Release charset.
1055 (ns_findfonts): Release NSFontDescriptor created with new.
1056 (ns_uni_to_glyphs): Fix indentation.
1057 (setString): Release attrStr before assigning new value.
1058
c803b2b7
JD
10592011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1060
678f4426
JD
1061 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1062 and NS_IMPL_COCOA.
1063 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1064 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1065
cd394be1 10662011-12-18 David Reitter <reitter@cmu.edu>
678f4426 1067
5fecd5fc
JD
1068 * nsterm.m (ns_term_init): Subscribe for notifications
1069 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1070 to method trackingNotification in EmacsMenu.
1071
1072 * nsmenu.m (trackingMenu): New variable.
3771cb17 1073 (trackingNotification): New method (from Aquamacs).
5fecd5fc 1074 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 1075 from Aquamacs (Bug#7030).
678f4426
JD
1076
10772011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 1078
c803b2b7
JD
1079 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1080 (symbol_to_nsstring): Fix indentation.
1081 (ns_symbol_to_pb): New function.
cae07000
SM
1082 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1083 (Fns_rotate_cut_buffers_internal): Remove.
1084 (Fns_store_selection_internal): Rename from
c803b2b7
JD
1085 Fns_store_cut_buffer_internal.
1086 (ns_get_foreign_selection, Fx_own_selection_internal)
1087 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
1088 (Fns_get_selection_internal, Fns_store_selection_internal):
1089 Use ns_symbol_to_pb and check if return value is nil.
1090 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1091 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
1092 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1093 renamed to Sns_store_selection_internal.
1094 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1095 and remove this function.
1096 (ns_handle_selection_clear): Remove, never used.
1097 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1098 here.
1099
e1b01a3a
KB
11002011-12-17 Ken Brown <kbrown@cornell.edu>
1101
1102 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1103 GID is unknown (Bug#10257).
1104
2adb6e85
PE
11052011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1106
1107 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1108 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1109 which caused a build failure on GNU/Linux IA-64. This problem was
1110 introduced by my 2011-10-07 patch.
1111
d1d7b339
JL
11122011-12-15 Juri Linkov <juri@jurta.org>
1113
1114 * image.c (imagemagick_error): New function. (Bug#10112)
1115 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1116 Use `imagemagick_error' where ImageMagick functions return
1117 `MagickFalse'.
1118 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1119 proper order.
1120
100d5755
KH
11212011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1122
1123 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1124 fill background (Bug#8992).
1125
454592a6
MR
11262011-12-13 Martin Rudalics <rudalics@gmx.at>
1127
1128 * window.c (Vwindow_combination_resize)
1129 (Vwindow_combination_limit): Use t instead of non-nil in
1130 doc-strings.
61d4b438
MR
1131 (Vrecenter_redisplay): Add first sentence of doc-string on
1132 separate line.
53524d93 1133 (Frecenter): Fix doc-string typo.
454592a6 1134
3633e3aa
KH
11352011-12-11 Kenichi Handa <handa@m17n.org>
1136
1137 * coding.c (Funencodable_char_position): Pay attention to the
1138 buffer text relocation (Bug#9389).
1139
7b9d523a
JD
11402011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1141
1142 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1143 gtk_init (Bug#10100).
1144
b73189c6
EZ
11452011-12-10 Eli Zaretskii <eliz@gnu.org>
1146
1147 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1148 IT->string is nil. (Bug#10263)
1149
f7dfe5d6
JD
11502011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1151
83faebb4
JD
1152 * nsterm.h (x_free_frame_resources): Declare.
1153
f7dfe5d6
JD
1154 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1155 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1156
1157 * nsterm.h (ns_get_defaults_value): Declare.
1158
1159 * nsterm.m (ns_default): Call ns_get_defaults_value.
1160
7cd4e72c
EZ
11612011-12-09 Eli Zaretskii <eliz@gnu.org>
1162
1163 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1164 (Bug#10170)
1165
b34d7317
YM
11662011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1167
1168 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1169 that where the value of an _OBJC_* symbol points to is in the .bss
1170 section (Bug#10240).
1171
76470ad1
KH
11722011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1173
1174 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 1175 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 1176
745fff94
KH
11772011-12-08 Kenichi Handa <handa@m17n.org>
1178
1179 * ftfont.c (get_adstyle_property): Fix previous change
1180 (Bug#10233).
1181
6e44397c
JB
11822011-12-07 Juanma Barranquero <lekktu@gmail.com>
1183
1184 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1185 dirs from the default value of EMACSLOADPATH (bug#10208).
1186
7efa6272
GM
11872011-12-07 Glenn Morris <rgm@gnu.org>
1188
1189 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1190 installation and source directories as well. (Bug#10208)
1191
f6fc4d87
CY
11922011-12-06 Chong Yidong <cyd@gnu.org>
1193
1194 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1195
2bf26180
GM
11962011-12-06 Glenn Morris <rgm@gnu.org>
1197
1198 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1199 as an error, not just -1. (Bug#10217)
1200
3a6ad4f0
CY
12012011-12-05 Chong Yidong <cyd@gnu.org>
1202
1203 * keyboard.c (process_special_events): New function.
1204 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1205
75a3b399
PE
12062011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1207
1208 * coding.c (encode_designation_at_bol): Don't use uninitialized
1209 local variable (Bug#9318).
1210
c3c9e25e
KH
12112011-12-05 Kenichi Handa <handa@m17n.org>
1212
1213 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1214 return Qnil (Bug#8046, Bug#10193).
1215
5eb05ea3
KH
12162011-12-05 Kenichi Handa <handa@m17n.org>
1217
1218 * coding.c (encode_designation_at_bol): New args charbuf_end and
1219 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
1220 (coding_set_source): Return how many bytes coding->source was
1221 relocated.
1222 (coding_set_destination): Return how many bytes
1223 coding->destination was relocated.
1224 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 1225 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
1226
12272011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1228
1229 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1230 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1231 macro (Bug#9318).
1232
12332011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1234
1235 The following changes are to fix Bug#9318.
1236
a79703f5 1237 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
1238 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1239 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 1240 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 1241
7dbda6df
JB
12422011-12-05 Juanma Barranquero <lekktu@gmail.com>
1243
1244 * lisp.h (process_quit_flag): Fix external declaration.
1245
6d5eb5b0
SM
12462011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1247
1248 Don't macro-inline non-performance-critical code.
1249 * eval.c (process_quit_flag): New function.
1250 * lisp.h (QUIT): Use it.
1251
a0c3fad0
JD
12522011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1253
1254 * nsfns.m (get_geometry_from_preferences): New function.
1255 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1256
6c07aac2
AS
12572011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1258
1259 * emacs.c (Qkill_emacs): Define.
1260 (syms_of_emacs): Initialize it.
1261 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1262 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
1263 (quit_throw_to_read_char): Add parameter `from_signal'.
1264 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
1265 * lisp.h (QUIT): Call Fkill_emacs if requested.
1266
c052ead4
JD
12672011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1268
1269 * widget.c (update_wm_hints): Return if wmshell is null.
1270 (widget_update_wm_size_hints): New function.
1271
1272 * widget.h (widget_update_wm_size_hints): Declare.
1273
1274 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1275 widget_update_wm_size_hints (Bug#10104).
1276
9e49252b
EZ
12772011-12-03 Eli Zaretskii <eliz@gnu.org>
1278
1279 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1280 before a newline, prepare the bidi iterator for consuming the
1281 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 1282 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 1283
02b16839
JL
12842011-12-02 Juri Linkov <juri@jurta.org>
1285
1286 * search.c (Fword_search_regexp): New Lisp function created from
1287 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1288 (Fword_search_backward, Fword_search_forward)
1289 (Fword_search_backward_lax, Fword_search_forward_lax):
1290 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1291 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1292
0068070e
SM
12932011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1294
1295 * fileio.c (Finsert_file_contents): Move after-change-function call
1296 to before the "handled:" label, since all "goto handled" appear in
1297 cases where the *-change-functions have already been properly called
1298 (bug#10117).
1299
3360a3fc
AS
13002011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1301
1302 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1303 waiting for input. (Bug#10169)
1304
73d6c093
EZ
13052011-11-30 Eli Zaretskii <eliz@gnu.org>
1306
1307 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1308 verifies glyph row's hash code--we have just reallocated the
1309 glyphs, so their contents can be complete garbage. (Bug#10164)
1310
febe6bea
JB
13112011-11-30 Juanma Barranquero <lekktu@gmail.com>
1312
1313 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1314
801a4313
EZ
13152011-11-30 Eli Zaretskii <eliz@gnu.org>
1316
1317 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1318 attributes are tested _before_ calling verify_row_hash, to protect
1319 against GCC re-ordering of the tests. (Bug#10164)
1320
2b56b87e
JD
13212011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1322
1323 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1324
1325 * xterm.c (handle_one_xevent): Only set async_visible and friends
1326 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1327 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1328 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1329
dbf31225
PE
13302011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1331
1332 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1333 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1334 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1335 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1336 All uses changed to use GCPRO1 etc.
1337 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1338 Revert to old implementation (i.e., before 2011-03-11).
1339
1305621b
YM
13402011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1341
1342 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1343 of scroll runs so as to avoid assigning disabled bogus rows and
1344 unnecessary graphics copy operations.
1345
8c9afb46
EZ
13462011-11-27 Eli Zaretskii <eliz@gnu.org>
1347
1348 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1349 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1350 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1351 (malloc, free, realloc, calloc): Redirect to e_* only when
1352 compiling Emacs.
1353
1354 * lisp.h (GCTYPEBITS): Move before first use.
1355 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1356 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1357 this macro definition.
1358
1359 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1360 _MSC_VER.
1361
54e9e3bf
JD
13622011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1363
6d5eb5b0
SM
1364 * gtkutil.c (xg_create_frame_widgets):
1365 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1366 present with Gtk+ 2.0.
1367
83aca1cb
PE
13682011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1369
1370 * fileio.c (Finsert_file_contents): Undo previous change; see
1371 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1372
5b76caa4
PE
13732011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1374
1375 Rename locals to avoid shadowing.
1376 * fileio.c (Finsert_file_contents):
1377 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1378 * process.c (wait_reading_process_output):
1379 Rename inner 'proc' to 'p' to avoid shadowing.
1380 Indent for consistency with usual Emacs style.
1381
8c535114
EZ
13822011-11-25 Eli Zaretskii <eliz@gnu.org>
1383
1384 * xdisp.c (redisplay_window): If cursor row is not fully visible
1385 after recentering, and scroll-conservatively is set to a large
1386 number, scroll window by a few more lines to make the cursor fully
1387 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1388 (start_display): Don't move to the next line if the display should
1389 start at a newline that is part of a display vector or an overlay
1390 string. (Bug#10119)
8c535114 1391
fa4fdb5c
JL
13922011-11-24 Juri Linkov <juri@jurta.org>
1393
1394 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1395 after the `MagickPingImage' call. (Bug#10112)
1396
90ec88df
CY
13972011-11-23 Chong Yidong <cyd@gnu.org>
1398
1399 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1400
56e2e794
MR
14012011-11-23 Martin Rudalics <rudalics@gmx.at>
1402
1403 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1404 making another buffer current. (Bug#10114)
1405
b6e64c41
GM
14062011-11-23 Glenn Morris <rgm@gnu.org>
1407
1408 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1409
6b21de18
CY
14102011-11-23 Chong Yidong <cyd@gnu.org>
1411
1412 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1413 using it (Bug#5984).
1414
b12cd789
EZ
14152011-11-22 Eli Zaretskii <eliz@gnu.org>
1416
1417 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1418 and header-lines, as they don't have one computed for them.
1419 (Bug#10098)
1420
1421 * .gdbinit (prow): Make displayed values more self-explaining.
1422 Add row's hash code.
1423
261b6fd4
LMI
14242011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1425
1426 * process.c (wait_reading_process_output): Fix asynchrounous
1427 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1428 (wait_reading_process_output): Add comment and URL.
261b6fd4 1429
e7cfd277
JD
14302011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1431
1432 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1433
a9b9b7f5
CY
14342011-11-21 Chong Yidong <cyd@gnu.org>
1435
1436 * window.c (Fnext_window, Fprevious_window): Doc fix.
1437
b0d15b4f
SM
14382011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1439
1440 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1441
fe7a3057
JB
14422011-11-20 Juanma Barranquero <lekktu@gmail.com>
1443
1444 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1445
d2999b1a
MR
14462011-11-20 Martin Rudalics <rudalics@gmx.at>
1447
1448 * window.c (Fset_window_combination_limit): Rename argument
1449 STATUS to LIMIT.
1450 (Vwindow_combination_limit): Remove "status" from doc-string.
1451
d5ff9cd0
AS
14522011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1453
1454 * m/ibms390.h: Remove.
1455 * m/ibms390x.h: Don't include "ibms390.h".
1456
a5bb9bd3
SM
14572011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1458
1459 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1460 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1461
cd1181db
JB
14622011-11-20 Juanma Barranquero <lekktu@gmail.com>
1463
1464 * casetab.c (Fset_case_table):
1465 * charset.c (Fcharset_after): Fix typos.
1466
615a3b8d 14672011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1468
17e845af
PE
1469 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1470 Otherwise, valgrind does not work on some platforms.
1471 Problem reported by Andreas Schwab in
6a0bf43d
PE
1472 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1473 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1474 is set, removing the need for VIRT_ADDRESS_VARIES.
1475 (PURE_P): Use a more-efficient implementation that needs just one
1476 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1477 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1478 to 4 (xorl, subq, cmpq, setbe).
1479 * alloc.c (pure): Always extern now, since that's the
1480 VIRT_ADDR_VARIES behavior.
1481 (PURE_POINTER_P): Use a single comparison, not two, for
1482 consistency with the new puresize.h.
1483 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1484 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1485 Remove VIRT_ADDR_VARIES no longer needed.
1486
f8fe6f96
EZ
14872011-11-19 Eli Zaretskii <eliz@gnu.org>
1488
1489 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1490 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1491 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1492 behave as if the cursor position were at the window margin.
1493
1494 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1495 and the cursor position is out of bounds, behave as if the cursor
1496 position were at the window margin. (Bug#10075)
1497
df05a53c
CY
14982011-11-18 Chong Yidong <cyd@gnu.org>
1499
1500 * window.c (Fwindow_combination_limit): Make first argument
1501 non-optional, since it is meaningless for live windows like the
1502 selected window.
1503
2071918e
DA
15042011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1505
1506 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1507
b50a28de
SM
15082011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1509
1510 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1511 (graft_intervals_into_buffer): Simplify.
1512
015137db
EZ
15132011-11-18 Eli Zaretskii <eliz@gnu.org>
1514
1515 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1516 hash values of the two rows.
1517 (copy_row_except_pointers): Preserve the used[] arrays and the
1518 hash values of the two rows. (Bug#10035)
68c95424 1519 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1520
1521 * xdisp.c (row_hash): New function, body extracted from
1522 compute_line_metrics.
1523 (compute_line_metrics): Call row_hash, instead of computing the
1524 hash code inline.
1525
1526 * dispnew.c (verify_row_hash): Call row_hash for computing the
1527 hash code of a row, instead of duplicating code from xdisp.c.
1528
1529 * dispextern.h (row_hash): Add prototype.
1530
a2addb04
TH
15312011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1532
1533 * frame.c (delete_frame): Don't delete the terminal when the last
1534 X frame is closed if emacs is built with GTK toolkit.
1535
df85d315
JB
15362011-11-17 Juanma Barranquero <lekktu@gmail.com>
1537
1538 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1539
a0c2d0ae
MR
15402011-11-17 Martin Rudalics <rudalics@gmx.at>
1541
1542 * window.c (Vwindow_splits): Rename to
1543 Vwindow_combination_resize. Suggested by Juri Linkov.
1544 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1545 of Vwindow_splits.
1546
58179cce
JB
15472011-11-16 Juanma Barranquero <lekktu@gmail.com>
1548
7877f373
JB
1549 * nsfns.m (Fns_font_name):
1550 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1551
b6f67890
MR
15522011-11-16 Martin Rudalics <rudalics@gmx.at>
1553
1554 * window.h (window): Rename slot "nest" to "combination_limit".
1555 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1556 (Fset_window_nest): Rename to Fset_window_combination_limit.
1557 (Vwindow_nest): Rename to Vwindow_combination_limit.
1558 (recombine_windows, make_parent_window, make_window)
1559 (Fsplit_window_internal, saved_window)
1560 (Fset_window_configuration, save_window_save): Rename all
1561 occurrences of window_nest to window_combination_limit.
1562
c7015153
JB
15632011-11-15 Juanma Barranquero <lekktu@gmail.com>
1564
1565 * image.c (imagemagick_load_image): Fix typo.
1566
322ad6ec
EZ
15672011-11-14 Eli Zaretskii <eliz@gnu.org>
1568
1569 * xdisp.c (display_line): Move the call to
1570 highlight_trailing_whitespace before the call to
1571 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1572 faces of all the glyphs to compute ROW's hash value.
1573 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1574
f067b8ec
JB
15752011-11-14 Juanma Barranquero <lekktu@gmail.com>
1576
1577 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1578 just return (bug#10044).
1579
1e5b2111
EZ
15802011-11-12 Eli Zaretskii <eliz@gnu.org>
1581
7ef3cbd5
EZ
1582 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1583 with user-defined heap size. Bump the default size of the temacs
1584 heap to 27MB, to avoid memory warning when running temacs.
1585 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1586
1e5b2111
EZ
1587 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1588 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1589 (verify_row_hash) [XASSERTS]: New function.
1590 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1591 that the hash value of glyph rows is correct.
1e5b2111 1592
89d61221
MR
15932011-11-12 Martin Rudalics <rudalics@gmx.at>
1594
1595 * window.h (window): Remove splits slot.
1596 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1597 (Fdelete_other_windows_internal, make_parent_window)
1598 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1599 (Fset_window_configuration, save_window_save): Don't deal with
1600 split status of windows.
1601 (saved_window): Remove splits slot.
1602 (Vwindow_splits): Rewrite doc-string.
1603
97f18cc8
JD
16042011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1605
1606 * xfns.c (unwind_create_frame):
1607 * nsfns.m (unwind_create_frame):
1608 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1609 Vframe_list (Bug#9999).
1610
22a648b4
DA
16112011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1612
0b381c7e 1613 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1614
659afede
KH
16152011-11-11 Kenichi Handa <handa@m17n.org>
1616
1617 * callproc.c (Fcall_process): Set the member dst_multibyte of
1618 process_coding.
1619
9ac0394b
KH
16202011-11-11 Johan Bockgård <bojohan@gnu.org>
1621
1622 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1623 avoid a crash (bug#9496).
1624
2fbdc249
CY
16252011-11-09 Chong Yidong <cyd@gnu.org>
1626
1627 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1628 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1629
ac6b1f81
PE
16302011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1631
1632 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1633
09db192c
PE
16342011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1635
1636 Avoid some portability problems by eschewing 'extern inline' functions.
1637 The trivial performance wins aren't worth the portability hassles; see
1638 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1639 et seq.
1640 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1641 (window_box_width, window_box_left, window_box_left_offset)
1642 (window_box_right, window_box_right_offset): Undo previous change,
1643 by removing the "extern"s.
1644 * intervals.c (adjust_intervals_for_insertion)
1645 (adjust_intervals_for_deletion): Undo previous change,
1646 making these static again.
1647 (offset_intervals, temp_set_point_both, temp_set_point)
1648 (copy_intervals_to_string): No longer inline.
1649 * xdisp.c (window_text_bottom_y, window_box_width)
1650 (window_box_height, window_box_left_offset)
1651 (window_box_right_offset, window_box_left, window_box_right)
1652 (window_box): No longer inline.
1653
105216ed
CY
16542011-11-08 Chong Yidong <cyd@gnu.org>
1655
1656 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1657 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1658 Signal an error if not a live window.
105216ed
CY
1659 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1660 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1661
ae9e237f
JB
16622011-11-07 Juanma Barranquero <lekktu@gmail.com>
1663
1664 * lisp.h (syms_of_abbrev): Remove declaration.
1665 Reported by CHENG Gao <chenggao@royau.me>.
1666
c7aa8333
EZ
16672011-11-07 Eli Zaretskii <eliz@gnu.org>
1668
1669 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1670 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1671 of temacs in GUI mode.
1672
be7f5545
MR
16732011-11-07 Martin Rudalics <rudalics@gmx.at>
1674
1675 * window.h: Declare delete_all_child_windows instead of
1676 delete_all_subwindows.
1677 * window.c (Fwindow_nest, Fset_window_nest)
1678 (Fset_window_new_total, Fset_window_new_normal)
1679 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1680 (delete_all_subwindows): Rename to delete_all_child_windows.
1681 (Fdelete_other_windows_internal, Fset_window_configuration):
1682 Call delete_all_child_windows instead of delete_all_subwindows.
1683 * frame.c (delete_frame): Call delete_all_child_windows instead
1684 of delete_all_subwindows.
1685
ca78dc43
PE
16862011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1687
1688 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1689 This is also needed for porting to any host where GC_MARK_STACK is
1690 not GC_MAKE_GCPROS_NOOPS.
1691 (which_symbols): Use it.
1692
a0241d01
KH
16932011-11-07 Kenichi Handa <handa@m17n.org>
1694
1695 * coding.c (coding_set_destination): Check coding->src_pos only
1696 when coding->src_object is a buffer (bug#9910).
1697
1698 * process.c (send_process): Set the member src_multibyte of coding
1699 to 0 (bug#9911) when sending a unibyte text.
1700
1701 * callproc.c (Fcall_process): Set the member src_multibyte of
1702 process_coding to 0 (bug#9912).
1703
a64bfdfa 17042011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1705
1706 * xmenu.c (cleanup_widget_value_tree): New function.
1707 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1708 calling free_menubar_widget_value_tree directly (Bug#9830).
1709
cb41b32a
PE
17102011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1711
1712 Fix some portability problems with 'inline'.
1713 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1714 (window_box_width, window_box_left, window_box_left_offset)
1715 (window_box_right, window_box_right_offset): Declare extern.
1716 Otherwise, these inline functions do not conform to C99 and
1717 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1718 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1719 * intervals.c (adjust_intervals_for_insertion)
1720 (adjust_intervals_for_deletion): Now extern, because otherwise the
1721 extern inline functions 'offset_intervals' couldn't refer to it.
1722 (static_offset_intervals): Remove.
1723 (offset_intervals): Rewrite using the old contents of
1724 static_offset_intervals. The old version didn't conform to C99
1725 because an extern inline function contained a reference to an
1726 identifier with static linkage.
1727
b7041366
AS
17282011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1729
1730 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1731 GC.
1732
88a37c4d
EZ
17332011-11-06 Eli Zaretskii <eliz@gnu.org>
1734
1735 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1736 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1737 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1738 return Qleft_to_right.
1739
49745b39
CY
17402011-11-06 Chong Yidong <cyd@gnu.org>
1741
1742 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1743 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1744 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1745 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1746 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1747 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1748 (Fwindow_vscroll): Doc fix.
1749 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1750 argument, since it makes no sense to pass a live window and for
1751 consistency with window-child.
1752
1f05cd82
CS
17532011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1754
1755 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1756 support MSVC.
1757
22610910
JR
17582011-11-05 Jason Rumney <jasonr@gnu.org>
1759
1760 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1761 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1762 fonts (Bug#6029).
1763 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1764 bitwise arithmetic preventing use of unicode-sip and non-truetype
1765 opentype fonts.
1766
a06776b2
EZ
17672011-11-05 Eli Zaretskii <eliz@gnu.org>
1768
3ad924ba
EZ
1769 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1770 "emacs"-only part.
1771
a06776b2
EZ
1772 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1773 initialization code to keep similarity to xfns.c after changes
1774 from 2011-11-05.
1775
c9e7db78
JD
17762011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1777
a97f8f3f
JD
1778 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1779 (unwind_create_frame): New function (Bug#9943).
1780 (Fx_create_frame): Restructure code to be more similar to the one in
1781 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1782 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1783 Move terminal->reference_count++ just before making the frame official
1784 (Bug#9943).
1785
1786 * nsterm.m (x_free_frame_resources): New function.
1787 (x_destroy_window): Move code to x_free_frame_resources.
1788
c9e7db78 1789 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1790 (Fx_create_frame, x_create_tip_frame):
1791 Move terminal->reference_count++ just before making the frame
75f1671a 1792 official. Move initialization of image_cache_refcount and
c9e7db78
JD
1793 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1794
a6fc3b5c
EZ
17952011-11-05 Eli Zaretskii <eliz@gnu.org>
1796
1797 Support MSVC build with newer versions of Visual Studio.
1798 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1799 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1800 nt/gmake.defs.
1801
1802 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1803 which are not supported by MSVC.
1804 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1805 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1806 bitfields.
1807 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1808 types in bitfields.
1809 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1810
1811 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1812
58179cce 18132011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1814
1815 Support MSVC build with newer versions of Visual Studio.
1816 * w32.c: Don't include w32api.h for MSVC.
1817 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1818
1819 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1820 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1821 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1822 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1823 e_* cousins.
1824 (alloca) [_MSC_VER]: Define to _alloca.
1825
1826 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1827
1828 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1829
a58c13ed
EZ
18302011-11-04 Eli Zaretskii <eliz@gnu.org>
1831
1832 * xdisp.c (note_mouse_highlight): If either of
1833 previous/next-single-property-change returns nil, treat that as
1834 the beginning or the end of the buffer. (Bug#9955)
1835
fe0b6370
JD
18362011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1837
a58c13ed 1838 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1839 label is not null (Bug#9951).
1840 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1841 may be NULL.
1842
89bd5ee1
EZ
18432011-11-04 Eli Zaretskii <eliz@gnu.org>
1844
1845 * window.c (Fwindow_body_size): Mention in the doc string that the
1846 return value is in frame's canonical units. (Bug#9949)
1847
84c3edb9
EZ
18482011-11-03 Eli Zaretskii <eliz@gnu.org>
1849
4e2fb5c7
EZ
1850 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1851
84c3edb9 1852 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1853 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1854 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1855
bc17a887
EZ
18562011-11-01 Eli Zaretskii <eliz@gnu.org>
1857
1858 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1859 Don't stop backward scan on the continuation glyph, even though
1860 its CHARPOS is positive.
6d5eb5b0
SM
1861 (mouse_face_from_buffer_pos, note_mouse_highlight):
1862 Rename cover_string to disp_string.
bc17a887 1863
4ee88440
MR
18642011-11-01 Martin Rudalics <rudalics@gmx.at>
1865
1866 * window.c (temp_output_buffer_show): Don't use
1867 Vtemp_buffer_show_specifiers.
1868 (Vtemp_buffer_show_specifiers): Remove unused variable.
1869
c2ff3c02
EZ
18702011-10-30 Eli Zaretskii <eliz@gnu.org>
1871
1872 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1873 past the beginning of the current glyph matrix.
1874
58179cce 18752011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1876
1877 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1878 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1879 HAVE_GTK3 (Bug#9869).
b77a6a7f 1880
3b574623
JD
1881 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1882 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1883
b77a6a7f
JD
1884 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1885
1886 * xterm.c: Declare x_handle_net_wm_state to return int.
1887 (handle_one_xevent): Check if we are iconified but don't have
1888 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1889 (get_current_wm_state): Return non-zero if not hidden,
1890 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1891 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1892 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1893 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1894
196e41e4
PE
18952011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1896
1897 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1898 so that this new function doesn't get optimized away by a
1899 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1900
021f2e1a
AS
19012011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1902
1903 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1904
8b058d44
EZ
19052011-10-29 Eli Zaretskii <eliz@gnu.org>
1906
1907 Fix the `xbytecode' command.
1908 * .gdbinit (xprintbytestr): New command.
b50a28de 1909 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1910 (xbytecode): Print the byte-code string as well.
1911
4452fb80
EZ
19122011-10-29 Kim Storm <storm@cua.dk>
1913
8b058d44
EZ
1914 * alloc.c (which_symbols): New function.
1915
21b72067
AS
19162011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1917
1918 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1919 line. (Bug#9903)
1920
83ed7b5c
GM
19212011-10-29 Glenn Morris <rgm@gnu.org>
1922
1923 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1924 Not clear what it was for, and it causes various bugs. (Bug#9839)
1925
5a7a728b
EZ
19262011-10-28 Eli Zaretskii <eliz@gnu.org>
1927
1928 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1929 possible random value that matches one of those tested as
1930 condition to clear the mouse face.
1931
d3d0842f
CY
19322011-10-28 Chong Yidong <cyd@gnu.org>
1933
1934 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1935
31b39d13
DN
19362011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1937
1938 * window.c (make_window): Initialize phys_cursor_on_p.
1939
9aba6043
SM
19402011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1941
1942 * lisp.h (struct Lisp_Symbol): Update comments.
1943
c20992f4
JB
19442011-10-28 Juanma Barranquero <lekktu@gmail.com>
1945
1946 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1947
db4f02f2
EZ
19482011-10-28 Eli Zaretskii <eliz@gnu.org>
1949
1950 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1951 <oslsachem@gmail.com> for helping to debug this.
1952
1953 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1954 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1955 (g_b_init_get_glyph_outline_w): New static variables.
1956 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1957 (GetGlyphOutlineW_Proc): New typedefs.
1958 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1959 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1960 New functions.
1961 (w32font_open_internal, compute_metrics):
1962 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1963 instead of calling the "wide" APIs directly.
1964
1965 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1966
1967 * w32.h (syms_of_w32font): Add prototype.
1968
87e68db4
JB
19692011-10-27 Juanma Barranquero <lekktu@gmail.com>
1970
1971 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1972 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1973 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1974 (Fmove_to_window_line): Doc fix.
1975
435c1d67
CY
19762011-10-27 Chong Yidong <cyd@gnu.org>
1977
1978 * process.c (make_process): Set gnutls_state to NULL.
1979
1980 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1981 non-NULL, regardless of GNUTLS_INITSTAGE.
1982 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1983 an error. Set process slots as soon as we allocate them.
1984
1985 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1986
9c6c6f49
CY
19872011-10-27 Chong Yidong <cyd@gnu.org>
1988
9aba6043
SM
1989 * gnutls.c (emacs_gnutls_deinit): New function.
1990 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1991 (Fgnutls_deinit, Fgnutls_boot): Use it.
1992
1993 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1994 (deactivate_process): Call emacs_gnutls_deinit.
1995
657d08d3
JB
19962011-10-27 Juanma Barranquero <lekktu@gmail.com>
1997
1998 * image.c (x_create_x_image_and_pixmap):
1999 * w32.c (sys_rename, w32_delayed_load):
2000 * w32font.c (fill_in_logfont):
2001 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2002
5430d399
JB
20032011-10-26 Juanma Barranquero <lekktu@gmail.com>
2004
2005 * w32fns.c (w32_default_color_map): New function,
2006 extracted from Fw32_default_color_map.
a7ef684b 2007 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 2008
fe0055fa
PE
20092011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2010
2011 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2012
e6346438
SM
20132011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2014
2015 * keyboard.c (test_undefined): New function (bug#9751).
2016 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2017
e112cc37
ET
20182011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2019
2020 * sysdep.c (init_sys_modes): Fix the check for the controlling
2021 terminal (Bug#6649).
2022
7b5d6677
EZ
20232011-10-20 Eli Zaretskii <eliz@gnu.org>
2024
2025 * dispextern.h (struct bidi_it): New member next_en_type.
2026
2027 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2028 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2029 current character, check also for next_en_type being WEAK_EN.
2030 (bidi_resolve_weak): Don't enter the expensive loop if the current
2031 position is before next_en_pos. Record the bidi type of the first
2032 non-ET, non-BN character we find, in addition to its position.
2033 (bidi_level_of_next_char): Invalidate next_en_type when
2034 next_en_pos is over-stepped.
2035
7da0b018
PE
20362011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2037
2038 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2039 * editfns.c: Rewrite current-time-zone so that it invokes
2040 the equivalent of (format-time-string "%Z") to get the time zone name.
2041 This fixes a bug when the time zone name contains characters that
2042 need converting from the system time locale to Emacs internal format.
2043 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2044 that patch fixed format-time-string to do the conversion, but
2045 I forgot to fix current-time-zone.
2046 (format_time_string): New function, containing most of
2047 what Fformat_time_string used to contain.
2048 (Fformat_time_string): Rewrite in terms of format_time_string.
2049 This doesn't change this function's behavior.
2050 (current-time-zone): Rewrite to use format_time_string.
2051 This fixes the bug reported by Michael Schierl in
2052 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2053 Jason Rumney's 2007-06-07 change worked around this bug, but
2054 didn't fix it.
2055 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2056
8547b010
EZ
20572011-10-19 Eli Zaretskii <eliz@gnu.org>
2058
2059 * xdisp.c (start_display): If the character at POS is displayed
2060 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
2061 (try_window_reusing_current_matrix): If a line ends in a display
2062 vector or the next line starts in a display vector, continue
2063 redrawing the window even though the character position of
2064 start_row was reached.
8547b010
EZ
2065 (Bug#9771, part 2)
2066
4e948d15
CY
20672011-10-18 Chong Yidong <cyd@gnu.org>
2068
2069 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2070 with nobreak-char-display too.
2071
4787455f
EZ
20722011-10-18 Eli Zaretskii <eliz@gnu.org>
2073
2074 Fix part 3 of bug#9771.
2075 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2076 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2077 non-neutral characters if the current character is a paragraph
2078 separator (a.k.a. Newline). This avoids running the same
2079 expensive loop twice, once when we consume the preceding newline
2080 and the other time when the line actually needs to be displayed.
2081 Avoid the loop when we see neutrals on the base embedding level
2082 following a character whose directionality is the same as the
2083 paragraph's. This avoids running the expensive loop when a line
2084 ends in a long sequence of neutrals, like control characters.
2085 Add assertion against STRONG_AL type. Slightly rearrange code
2086 that determines the type of a neutral given the first non-neutral
2087 that follows it.
2088 (bidi_level_of_next_char): Set next_en_pos to zero when
2089 invalidating its info.
2090
2c91f553
EZ
20912011-10-17 Eli Zaretskii <eliz@gnu.org>
2092
2093 * xdisp.c (push_display_prop): Determine whether to record string
2094 or buffer position by IT->string, not by IT->method. Allow
2095 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
2096 (move_it_vertically_backward): Don't look for character position
2097 immediately after the newline when in a continuation line.
2098 (Bug#9771, part 1)
2c91f553 2099
c7b08b0d
MR
21002011-10-15 Martin Rudalics <rudalics@gmx.at>
2101
2102 * window.c (coordinates_in_window): Rewrite and delabelize
2103 vertical border check. (Bug#5357) (Bug#9618)
2104
6b02f655
SM
21052011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2106
2107 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2108 errors in XSetWindowBorder (bug#9310).
2109
81d40c92
DA
21102011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2111
2112 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2113 avoid crash when xmalloc overrun checking is enabled.
2114
d4172c3b
EZ
21152011-10-13 Eli Zaretskii <eliz@gnu.org>
2116
2117 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2118 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2119 cursor motion with <left> and <right> arrow keys.
2120
2121 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2122 some callers set that themselves.
2123
b00eea75
EZ
21242011-10-12 Eli Zaretskii <eliz@gnu.org>
2125
2126 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2127 display string and the previous row comes from the same string and
2128 is empty. (Bug#9739) (Bug#9738)
2129
8fe012c4
SM
21302011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2131
2132 * doc.c (get_doc_string): Encode file name (bug#9735).
2133
0074aef2
EZ
21342011-10-12 Eli Zaretskii <eliz@gnu.org>
2135
79beb178
EZ
2136 * bidi.c (bidi_level_of_next_char):
2137 * xdisp.c (get_visually_first_element): Remove old incorrect
2138 comments regarding the Unicode Line Separator character.
2139
0074aef2
EZ
2140 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2141
6e4b3fbe
DA
21422011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2143
2144 * alloc.c (Fgc_status): Do not access beyond zombies array
2145 boundary if nzombies > MAX_ZOMBIES.
2146 * alloc.c (dump_zombies): Add missing format specifier.
2147
0324f3af
PE
21482011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2149
b5525cac
PE
2150 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2151 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2152
0324f3af
PE
2153 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2154 Some packages use them to denote characters with modifiers.
2155
e9b5f888
AS
21562011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2157
2158 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2159 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2160 matching a pp-number. Rename parameter var to var1.
2161
127827c0
SM
21622011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2163
2164 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2165
c8fd3bd0
GM
21662011-10-08 Glenn Morris <rgm@gnu.org>
2167
2168 * callint.c (Fcall_interactively): Give a more explicit error for the
2169 'c' case with a non-character input. (Bug#8479)
2170
352ec8ff
EZ
21712011-10-08 Eli Zaretskii <eliz@gnu.org>
2172
03669ccb
EZ
2173 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2174 lines.
7061c986
EZ
2175 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2176 lines that are hscrolled on the left.
03669ccb 2177
352ec8ff
EZ
2178 * dispnew.c (buffer_posn_from_coords): Account for a possible
2179 presence of header-line. (Bug#4426)
2180
a66cfb1c
SM
21812011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2182
6b02f655
SM
2183 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2184 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 2185
7c5ee88e
PE
21862011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2187
2188 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2189 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2190 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2191 this makes Emacs dump core during garbage collection on rare
2192 occasions. sizeof is obviously inferior to offsetof here, so
2193 stick with offsetof.
2194 (GC_POINTER_ALIGNMENT): New macro.
2195 (mark_memory): Omit 3rd (offset) arg; caller changed.
2196 Don't assume EMACS_INT alignment is the same as pointer alignment.
2197
df1bbe5b
SM
21982011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2199
2200 * keyboard.c (read_key_sequence_remapped): New var.
2201 (read_key_sequence): Compute remapping in the right buffer.
2202 (command_loop_1): Use read_key_sequence's remapping directly.
2203
51553db6
SM
22042011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2205
32c1fffd
SM
2206 * dired.c (file_name_completion): Don't expand file name.
2207 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2208 before checking file name handler.
2209
51553db6
SM
2210 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2211 they've been requested explicitly (bug#9591).
2212
b6bd1599 22132011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
2214
2215 * keymap.c (Fsingle_key_description): Use make_specified_string
2216 instead of build_string to build string from push_key_description.
2217 (Bug#5193)
2218
f701dc2a
PE
22192011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2220
4222c55d
PE
2221 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2222 This fixes a Y2038 bug on 64-bit hosts.
2223 * buffer.c (reset_buffer):
2224 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2225 (Fclear_buffer_auto_save_failure):
2226 Use 0, not -1, to represent an unset failure time, since time_t
2227 might not be signed.
2228
f701dc2a
PE
2229 Remove dependency on glibc malloc internals.
2230 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2231 Move back here from lisp.h, but with their new implementations.
2232 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2233 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2234 * charset.c (charset_table_init): New static var.
2235 (syms_of_charset): Use it instead of xmalloc. This removes a
2236 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2237 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2238 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2239 Move back to alloc.c.
2240 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2241 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2242
9ceebf39
JD
22432011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2244
2245 * nsterm.m (windowDidResize): Call x_set_window_size only when
2246 ns_in_resize is true. Otherwise set pixelwidth/height and
2247 call change_frame_size (Bug#9628).
2248
cb993c58
PE
22492011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2250
3930c88b
PE
2251 Port --enable-checking=all to Fedora 14 x86-64.
2252 * charset.c (syms_of_charset): Also account for glibc malloc's
2253 internal overhead when calculating the initial malloc maximum.
2254
cb993c58
PE
2255 Port --enable-checking=all to Fedora 14 x86.
2256 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2257 Move to lisp.h.
2258 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2259 (overrun_check_realloc, overrun_check_free):
2260 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2261 That way, xmalloc returns a properly-aligned pointer even if
2262 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2263 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2264 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2265 into account when calculating the initial malloc maximum.
2266 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2267 Move here from alloc.c, so that charset.c can use it too.
2268 Properly align; the old code wasn't right for common 32-bit hosts
2269 when configured with --enable-checking=all.
2270 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2271 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2272
31bed486
EZ
22732011-09-29 Eli Zaretskii <eliz@gnu.org>
2274
04c70788 2275 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
2276 use EDOM.
2277
fbcaa2f3
EZ
22782011-09-28 Eli Zaretskii <eliz@gnu.org>
2279
2280 * xdisp.c (compute_display_string_end): If there's no display
2281 string at CHARPOS, return -1.
2282
2283 * bidi.c (bidi_fetch_char): When compute_display_string_end
2284 returns a negative value, treat the character as a normal
2285 character not covered by a display string. (Bug#9624)
2286
a239d4e9
JB
22872011-09-28 Juanma Barranquero <lekktu@gmail.com>
2288
2289 * lread.c (Fread_from_string): Fix typo in docstring.
2290
88652fd5
EZ
22912011-09-27 Eli Zaretskii <eliz@gnu.org>
2292
2293 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2294 newline, reseat the iterator instead of bidi-iterating there one
2295 character at a time. (Bug#9610)
32c1fffd
SM
2296 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2297 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 2298
ed497dd4
AS
22992011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2300
2301 * lread.c (readevalloop): Use correct code for NBSP.
2302 (read1): Likewise. (Bug#9608)
2303
b2bf61aa
MA
23042011-09-25 Michael Albinus <michael.albinus@gmx.de>
2305
2306 * dbusbind.c (Fdbus_register_signal): When service is not
2307 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2308
32bbb17c
GM
23092011-09-25 Glenn Morris <rgm@gnu.org>
2310
2311 * buffer.c (truncate-lines): Doc fix.
2312
94e0933e
CY
23132011-09-24 Chong Yidong <cyd@stupidchicken.com>
2314
2315 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2316 (Fset_window_next_buffers): Doc fix.
2317
cddde921
GM
23182011-09-24 Glenn Morris <rgm@gnu.org>
2319
2320 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2321
1260aef1
PE
23222011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2323
25b4bfa0
PE
2324 Fix minor problems found by static checking.
2325 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2326 * indent.c (Fvertical_motion): Fix == vs = typo.
2327
e3cbd34b
EZ
23282011-09-24 Eli Zaretskii <eliz@gnu.org>
2329
a66cfb1c
SM
2330 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2331 Default value is now t. Doc fix.
6bf7006f 2332
e3cbd34b 2333 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2334 logic when moving up, not only when moving down. Fix the
e3cbd34b 2335 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2336 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2337
2338 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2339 CHARPOS is covered by a display string which includes newlines.
2340 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2341 is covered by a display string with embedded newlines.
2342
a3de0cbd
MA
23432011-09-24 Michael Albinus <michael.albinus@gmx.de>
2344
2345 * dbusbind.c (Fdbus_register_signal): Add match rule to
2346 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2347 (Fdbus_register_method, Vdbus_registered_objects_table):
2348 Fix docstring.
a3de0cbd 2349
b260039d
JM
23502011-09-24 Jim Meyering <meyering@redhat.com>
2351
32c1fffd 2352 do not ignore write error for any output size
b260039d
JM
2353 The previous change was incomplete.
2354 While it makes emacs --batch detect the vast majority of stdout
2355 write failures, errors were still ignored whenever the output size is
2356 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2357 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2358 && echo FAIL: ignored write error
2359 FAIL: ignored write error
2360 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2361 && echo FAIL: ignored write error
2362 FAIL: ignored write error
2363 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2364
8eca8a7c
AS
23652011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2366
2367 * emacs.c (Fkill_emacs): In noninteractive mode exit
2368 non-successfully if a write error occurred on stdout. (Bug#9574)
2369
3341db62
EZ
23702011-09-21 Eli Zaretskii <eliz@gnu.org>
2371
2372 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2373 the xassert test.
2374
2375 * dispextern.h (struct it): Update the comment documenting what
2376 can it->OBJECT be.
2377
8c203dbf
EZ
23782011-09-20 Eli Zaretskii <eliz@gnu.org>
2379
2380 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2381 a display string, extend search for cursor position to end of row.
2382 (find_row_edges): If the row ends in a newline from a display
2383 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2384 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2385 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2386 non-empty line. Fixes confusing cursor motion with arrow keys at
2387 the beginning of a line that starts with whitespace.
8c203dbf 2388
a4824228
LMI
23892011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2390
2391 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2392 (bug#9493).
2393
33ed493b
CY
23942011-09-18 Chong Yidong <cyd@stupidchicken.com>
2395
2396 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2397 boolean (Bug#9154).
2398
56cd55c8
EZ
23992011-09-18 Eli Zaretskii <eliz@gnu.org>
2400
2401 * xdisp.c (display_line): Record maximum and minimum buffer
2402 positions even if no glyphs were produced (e.g., by a zero-width
2403 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2404 buffer positions that will be removed from the glyph row because
2405 they don't fit.
c02dcedf
EZ
2406 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2407 column is beyond frame width: don't subtract 1 "pixel" when
2408 computing width of the stretch.
3e62b7e0
EZ
2409 (reseat_at_next_visible_line_start): Undo the change made on
2410 2011-09-17 that saved paragraph information and restored it after
2411 the call to `reseat'. (Bug#9545)
56cd55c8 2412
5ed99d36 24132011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2414
2415 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2416 and turn window cursor on if cleared (Bug#9415).
2417
5ed99d36 24182011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2419
2420 * search.c (boyer_moore): Take unibyte characters from pattern
2421 literally. (Bug#9458)
2422
9bade7b2
EZ
24232011-09-18 Eli Zaretskii <eliz@gnu.org>
2424
2425 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2426
e5e9d610
PE
24272011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2428
87e4427a
PE
2429 Fix minor problem found by static checking.
2430 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2431 initialized, to pacify gcc -Wuninitialized.
2432
e5e9d610
PE
2433 * fileio.c: Report proper errno when syscall falls.
2434 (Finsert_file_contents): Save and restore errno,
2435 so that report_file_error outputs the correct diagnostic.
2436 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2437
a1674f0b
EZ
24382011-09-18 Eli Zaretskii <eliz@gnu.org>
2439
2440 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2441
fbfb6dd4
EZ
24422011-09-17 Eli Zaretskii <eliz@gnu.org>
2443
2444 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2445 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2446
bb187662
EZ
24472011-09-17 Eli Zaretskii <eliz@gnu.org>
2448
1137e8b8 2449 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2450 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2451
2452 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2453 (bidi_find_paragraph_start): Search back for paragraph beginning
2454 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2455 (bidi_move_to_visually_next): Only trigger paragraph-related
2456 computations when the last character is a newline or at EOB, not
2457 just any NEUTRAL_B. (Bug#9470)
2458
bb187662
EZ
2459 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2460 truncated lines if point is covered by a display string. (Bug#9524)
2461
2e621251
PE
24622011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2463
2464 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2465 (cons_to_x_long): New function.
2466 (lisp_data_to_selection_data): Use it. Correct the test for
2467 short-versus-long data; it was negated. Break out of vector
2468 loop, for efficiency, when a long datum is discovered.
2469
91a15bc6
SM
24702011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2471
2472 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2473
b41c3a35
EZ
24742011-09-16 Eli Zaretskii <eliz@gnu.org>
2475
2476 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2477 GCC PR/17406) by declaring this function with external scope.
2478
7812ba2d
PE
24792011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2480
2481 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2482 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2483
cf7edc2a
AS
24842011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2485
2486 * editfns.c (Fformat): Correctly handle text properties on "%%".
2487
bd01620e
EZ
24882011-09-15 Eli Zaretskii <eliz@gnu.org>
2489
2490 * xterm.c (x_draw_composite_glyph_string_foreground):
2491 * w32term.c (x_draw_composite_glyph_string_foreground):
2492 * term.c (encode_terminal_code):
2493 * composite.c (composition_update_it, get_composition_id):
2494 * xdisp.c (get_next_display_element)
2495 (fill_composite_glyph_string): Add comments about special meaning
2496 of TAB characters in a composition.
2497
a02719a3
PE
24982011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2499
2500 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2501 This occurs when processing a multibyte format.
2502 Problem reported by Wolfgang Jenker.
a02719a3 2503
72589a3c
JB
25042011-09-15 Johan Bockgård <bojohan@gnu.org>
2505
2506 * xdisp.c (try_cursor_movement): Only check for exact match if
2507 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2508
1c14176c
PE
25092011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2510
2511 Remove unused external symbols.
2512 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2513 * xdisp.c (calc_pixel_width_or_height): Now static.
2514 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2515 * indent.c (check_display_width):
2516 * w32term.c: Fix comment to match code.
2517 * xterm.c, xterm.h (x_catching_errors): Remove.
2518
d2eea5b5
PE
25192011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2520
2521 * xselect.c: Use signed conversions more consistently (Bug#9498).
2522 (selection_data_to_lisp_data): Assume incoming selection data are
2523 signed integers, not unsigned. This is to be consistent with
2524 outgoing selection data, which was modified to use signed integers
2525 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2526 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2527 expects long, not unsigned long.
2528
46888499
EZ
25292011-09-14 Eli Zaretskii <eliz@gnu.org>
2530
2531 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2532 computation of loop end. Reported by Johan Bockgård
2533 <bojohan@gnu.org>.
2534
ef8ef9fb
CY
25352011-09-13 Chong Yidong <cyd@stupidchicken.com>
2536
2537 * frame.c (Fother_visible_frames_p): Function deleted.
2538
fa819fed
EZ
25392011-09-12 Eli Zaretskii <eliz@gnu.org>
2540
2541 * indent.c (compute_motion): Process display vector front to back
2542 rather than the other way around. (Bug#2496)
2543
2ba8e008
SM
25442011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2545
2546 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2547
20f53c69
CY
25482011-09-11 Chong Yidong <cyd@stupidchicken.com>
2549
2550 * minibuf.c (Fread_from_minibuffer): Doc fix.
2551
d562d7a4
EZ
25522011-09-11 Eli Zaretskii <eliz@gnu.org>
2553
2554 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2555 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2556
1c4d7f3d
LMI
25572011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2558
2559 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2560 value for non-existent files.
2561
b885bf36
EZ
25622011-09-11 Eli Zaretskii <eliz@gnu.org>
2563
2564 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2565 set its "size" to -1. This will set the modtime_size field of
2566 the corresponding buffer to -1, which is what
2567 verify-visited-file-modtime expects for files that do not exist.
2568 (Bug#9139)
2569
6612f0bf
PE
25702011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2571
2572 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2573 here ...
2574 * lisp.h: ... from here. push_key_description is no longer
2575 defined in keyboard.c, so its declaration should not be in
2576 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2577 logically belongs with push_key_description.
2578
dfb3f755
PE
25792011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2580
2581 * buffer.h: Include <sys/types.h> instead of <time.h>.
2582 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2583 Problem reported by Herbert J. Skuhra.
2584
3134906c
LMI
25852011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2586
2587 * xml.c (parse_region): Make the parsing work for
2588 non-comment-starting XML files again (bug#9144).
2589
8d903f4e
AS
25902011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2591
2592 * image.c (gif_load): Fix calculation of bottom and right corner.
2593 (Bug#9468)
2594
80ad64f4
EZ
25952011-09-10 Eli Zaretskii <eliz@gnu.org>
2596
2597 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2598 redisplay in small windows.
2599
208a048d
EZ
26002011-09-09 Eli Zaretskii <eliz@gnu.org>
2601
2602 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2603
9b1c252e
MR
26042011-09-08 Martin Rudalics <rudalics@gmx.at>
2605
2606 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2607 Operate on live windows only.
2608
2949f33b
JB
26092011-09-08 Juanma Barranquero <lekktu@gmail.com>
2610
2611 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2612
e08dcafd
EZ
26132011-09-07 Eli Zaretskii <eliz@gnu.org>
2614
2615 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2616 only under bidi iteration.
2617
115b96bd
JD
26182011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2619
2620 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2621
c8199d0f
PE
26222011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2623
2624 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2625 Without this fix, the command to link temacs failed due to an
2626 undefined symbol __builtin_isnan. This is because
2627 /usr/include/iso/math_c99.h #defines isnan(x) to
2628 __builtin_isnan(x), but the bundled gcc, which identifies itself
2629 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2630 a __builtin_isnan.
2631 * floatfns.c (isnan): #undef, and then #define to a clone of
2632 what's in data.c.
2633 (Fisnan): Always define, since it's always available now.
2634 (syms_of_floatfns): Always define isnan at the Lisp level.
2635
e39b275c 26362011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2637
2638 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2639
b2db44d9 26402011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2641
f4af5137 2642 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2643 The previous code assumed that file offsets (off_t values) fit in
2644 EMACS_INT variables, which is not true on typical 32-bit hosts.
2645 The code messed up by falsely reporting buffer overflow in cases
2646 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2647 when "big" contains more than 2**29 bytes, even though this
2648 inserts just one byte and does not overflow the buffer.
2649 (Finsert_file_contents): Store file offsets as off_t
2650 values, not as EMACS_INT values. Check for overflow when
2651 converting between EMACS_INT and off_t. When checking for
2652 buffer overflow or for overlap, take the offsets into account.
2653 Don't use EMACS_INT for small values where int suffices.
2654 When checking for overlap, fix a typo: ZV was used where
2655 ZV_BYTE was intended.
2656 (Fwrite_region): Don't assume off_t fits into 'long'.
2657 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2658
ecfc0a49
MA
26592011-09-05 Michael Albinus <michael.albinus@gmx.de>
2660
2661 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2662
6511acf2 26632011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2664
0999621a 2665 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2666
2667 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2668 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2669 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2670 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2671 (modify_event_symbol): Do not assume that the length of
2672 name_alist_or_stem is safe to alloca and fits in int.
2673 (Fexecute_extended_command): Likewise for function name and binding.
2674 (Frecursion_depth): Wrap around reliably on integer overflow.
2675 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2676 since some callers pass EMACS_INT values.
2677 (Fsingle_key_description): Don't crash if symbol name contains more
2678 than MAX_ALLOCA bytes.
2679 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2680 (get_minibuffer): Arg is now EMACS_INT, not int.
2681 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2682 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2683 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2684
2be7d702
PE
2685 * dbusbind.c (signature_cat): New function.
2686 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2687 Do not overrun buffer; instead, report string overflow.
2688
9d1df220
PE
2689 * dispnew.c (add_window_display_history): Don't overrun buffer.
2690 Truncate instead; this is OK since it's just a log.
2691
33ef5c64
PE
2692 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2693 even if the time zone offset is outlandishly large.
2694 Don't mishandle offset == INT_MIN.
2695
66c6fdd5
PE
2696 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2697 when creating daemon; the previous buffer-overflow check was incorrect.
2698
d749b01b
PE
2699 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2700 which has the guts of the old verror function.
2701
b5cd1905
PE
2702 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2703 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2704
6e1a67fb
PE
2705 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2706 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2707 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2708 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2709 length of string rather than counting it via multiple sprintfs;
2710 that's simpler and more reliable.
c21721cc
PE
2711 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2712 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2713 sprintf, in case result does not fit in int.
2714
c57b67fc
PE
2715 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2716 (fontset_from_font): Print it.
2717
8a401434
PE
2718 * frame.c (tty_frame_count): Now printmax_t, not int.
2719 (make_terminal_frame, set_term_frame_name): Print it.
2720 (x_report_frame_params): In X, window IDs are unsigned long,
2721 not signed long, so print them as unsigned.
2722 (validate_x_resource_name): Check for implausibly long names,
2723 and don't assume name length fits in 'int'.
2724 (x_get_resource_string): Don't blindly alloca invocation name;
2725 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2726 not fit in int.
2727
6e1a67fb
PE
2728 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2729 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2730 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2731
0df02bf3
PE
2732 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2733 Use esprintf, not sprintf, in case result does not fit in int.
2734
48e30793
PE
2735 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2736 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2737 it as a large positive number.
2738 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2739 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2740
a66ff6d8
PE
2741 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2742 in case result does not fit in int.
2743
aca216ff
PE
2744 * print.c (float_to_string): Detect width overflow more reliably.
2745 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2746 buffer overrun. Don't assume list length fits in 'int'. Treat
2747 print length of 0 as 0, not as infinity; to be consistent with other
2748 uses of print length in this function. Don't overflow print length
2749 index. Don't assume hash table size fits in 'long', or that
2750 vectorlike size fits in 'unsigned long'.
2751
31c286f7
PE
2752 * process.c (make_process): Use printmax_t, not int, to format
2753 process-name gensyms.
2754
55e5faa1
PE
2755 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2756
80f2e268
PE
2757 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2758 to avoid potential buffer overrun.
2759
670741ab
PE
2760 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2761 if X resource line is longer than 512 bytes.
2762
b7163a50
PE
2763 * xfns.c (x_window): Make sprintf buffer a bit bigger
2764 to avoid potential buffer overrun.
2765
ae58ff1f
PE
2766 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2767
c43c8a6a
PE
2768 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2769
3f8236f4
PE
27702011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2771
53e9fe90 2772 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2773 Without these, Emacs silently mishandles large integers sometimes.
2774 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2775 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2776
6511acf2
PE
2777 * xdisp.c (try_window_id): Check Emacs fixnum range before
2778 converting to 'int'.
806add1d 2779
6511acf2 2780 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2781 Check that an Emacs fixnum is in range before assigning it to 'int'.
2782 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2783 values converted from Emacs fixnums.
2784 (Frecenter): Don't wrap around a line count if it is out of 'int'
2785 range; instead, treat it as an extreme value.
2786 (Fset_window_configuration, compare_window_configurations):
2787 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2788
6511acf2
PE
2789 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2790 that can exceed INT_MAX. Check that EMACS_INT value is in range
2791 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2792 (match_limit): Don't assume that a fixnum can fit in 'int'.
2793
6511acf2 2794 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2795 exceed INT_MAX.
2796
6511acf2 2797 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2798 (Fvertical_motion): Don't wrap around LINES values that don't fit
2799 in 'int'. Instead, treat them as extreme values. This is good
2800 enough for windows, which can't have more than INT_MAX lines anyway.
2801
fcb901a7
LMI
28022011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2803
0f2f6b6d
LMI
2804 * Require libxml/parser.h to avoid compilation warning.
2805
fcb901a7
LMI
2806 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2807
2808 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2809 since this reportedly can destroy thread storage.
2810
6e20a0d4
CY
28112011-08-30 Chong Yidong <cyd@stupidchicken.com>
2812
2813 * syntax.c (find_defun_start): Update all cache variables if
2814 exiting early (Bug#9401).
2815
148ae00e
EZ
28162011-08-30 Eli Zaretskii <eliz@gnu.org>
2817
f6cfbd8f
EZ
2818 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2819
148ae00e
EZ
2820 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2821 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2822 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2823
2824 * term.c (tty_append_glyph): New function.
2825 (produce_stretch_glyph): Static function and its prototype deleted.
2826
a66cfb1c
SM
2827 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2828 Add prototypes.
148ae00e 2829
c4a07a4c
PE
28302011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2831
2832 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2833 when checking :margin (Bug#9390).
2834 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2835 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2836 so that the name doesn't mislead. All uses changed.
2837
6bc8cd65
JB
28382011-08-28 Johan Bockgård <bojohan@gnu.org>
2839
2840 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2841 set_tty_hooks.
2842
dca4927e
EZ
28432011-08-27 Eli Zaretskii <eliz@gnu.org>
2844
2845 * xdisp.c (move_it_to): Don't bail out early when reaching
2846 position beyond to_charpos, if we are scanning backwards.
2847 (move_it_vertically_backward): When DY == 0, make sure we get to
2848 the first character in the line after the newline.
2849
f2cad773
PE
28502011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2851
2852 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2853 (ccl_driver): Do not generate an out-of-range pointer.
2854 (Fccl_execute_on_string): Remove unnecessary check for
2855 integer overflow, noted by Stefan Monnier in
2856 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2857 Remove a FIXME that didn't need fixing.
2858 Simplify the newly-introduced buffer reallocation code.
2859
0cae2cdb
JB
28602011-08-27 Juanma Barranquero <lekktu@gmail.com>
2861
2862 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2863
5fc295a4 28642011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2865
70c60eb2 2866 Integer and memory overflow issues (Bug#9196).
726e0ab1 2867
d31850da
PE
2868 * doc.c (get_doc_string): Rework so that
2869 get_doc_string_buffer_size is the actual buffer size, rather than
2870 being 1 less than the actual buffer size; this makes xpalloc more
2871 convenient.
2872
a69fbedb
PE
2873 * image.c (x_allocate_bitmap_record, cache_image):
2874 * xselect.c (Fx_register_dnd_atom):
2875 Simplify previous changes by using xpalloc.
2876
fe5c5d37
PE
2877 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2878 since either will do and ptrdiff_t is convenient with xpalloc.
2879
0065d054
PE
2880 * charset.c (charset_table_size)
2881 (struct charset_sort_data.priority): Now ptrdiff_t.
2882 (charset_compare): Don't overflow if priorities differ greatly.
2883 (Fsort_charsets): Don't assume list length fits in int.
2884 Check for size-calculation overflow when allocating sort data.
2885 (syms_of_charset): Allocate an initial charset table that is
2886 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2887
2888 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2889
2890 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2891 The actual value is always <= INT_MAX, and leaving it unsigned made
2892 overflow checking harder.
2893
2894 * dispextern.h (struct glyph_matrix.rows_allocated)
2895 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2896 with xpalloc. The values are still always <= INT_MAX.
2897
2898 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2899
2900 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2901 (SAFE_NALLOCA): New macro.
2902
2903 * region-cache.c (struct boundary.pos, find_cache_boundary)
2904 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2905 (set_cache_region, invalidate_region_cache)
2906 (revalidate_region_cache, know_region_cache, region_cache_forward)
2907 (region_cache_backward, pp_cache):
2908 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2909 so that ptrdiff_t * can be passed to xpalloc.
2910 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2911 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2912 (pp_cache): Don't assume cache_len fits in int.
2913 * region-cache.h: Adjust extern decls to match.
2914
2915 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2916 EMACS_INT, since either will do, for xpalloc.
2917
2918 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2919 (xnmalloc, xnrealloc, xpalloc): New functions.
2920
726e0ab1
PE
2921 * bidi.c (bidi_shelve_header_size): New constant.
2922 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2923 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2924
51f30bc5 2925 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2926 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2927 (overlay_strings):
2928 Don't update size of array until after memory allocation succeeds,
2929 because xmalloc/xrealloc may not return.
0065d054
PE
2930 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2931 now that we have proper integer overflow checking.
2932 (record_overlay_string, overlay_strings): Catch overflows when
2933 calculating size of overlay_str_buf.
726e0ab1 2934
0065d054
PE
2935 * callproc.c (Fcall_process): Check for size overflow when
2936 calculating size of args2.
2937 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2938 Normally we prefer signed values, but sticking with ptrdiff_t would
2939 require adding more-complicated checks.
726e0ab1
PE
2940
2941 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2942 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2943 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2944 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2945
2946 * character.c (Fstring): Check for size-calculation overflow.
2947
2948 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2949 unnecessary integer overflow. Check for size overflow.
2950 (encode_coding_object): Don't update size until xmalloc succeeds.
2951
2952 * composite.c (get_composition_id): Check for overflow in glyph
2953 length calculations.
2954
2955 Integer and memory overflow fixes for display code.
2956 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2957 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2958 (scrolling_window): Check for overflow in size calculations.
2959 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2960 Don't assume glyph table len fits in int.
2961 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2962 (row_table_size): Now ptrdiff_t, not int.
2963 (scrolling_window): Avoid overflow in size calculations.
2964 Don't update size until allocation succeeds.
2965 * fns.c (concat): Check for overflow in size calculations.
2966 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2967 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2968 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2969
2970 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2971 (get_doc_string): Check for size calculation overflow.
2972 Don't update size until allocation succeeds.
2973 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2974 EMACS_INT, where ptrdiff_t will do.
2975 (Fsubstitute_command_keys): Check for string overflow.
2976
2977 * editfns.c (set_time_zone_rule): Don't assume environment length
2978 fits in int.
2979 (message_length): Now ptrdiff_t, not int.
2980 (Fmessage_box): Don't update size until allocation succeeds.
2981 Don't assume message length fits in int.
2982 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2983
0065d054
PE
2984 * emacs.c (main): Do not reallocate argv, since there is a null at
2985 the end that can be overwritten, and this way there's no need to
2986 worry about size-calculation overflow.
2987 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2988
2989 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2990 alloc succeeds.
2991 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2992
2993 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2994 (x_set_scroll_bar_width, x_figure_window_size):
2995 Check for integer overflow.
2996 (x_set_alpha): Do not assume XINT fits in int.
2997
2998 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2999 This is for the members text_lines, text_cols, total_lines, total_cols,
3000 where the system imposes an 'int' limit.
3001
3002 * fringe.c (Fdefine_fringe_bitmap):
3003 Don't update size until alloc works.
3004
3005 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3006 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3007
3008 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3009 Check for size-calculation overflow.
3010 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3011 do, as we prefer signed integers.
3012 (id_to_widget.max_size, id_to_widget.used)
3013 (xg_store_widget_in_map, xg_remove_widget_from_map)
3014 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3015 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3016 Use and return ptrdiff_t, not int.
3017 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3018 * gtkutil.h: Change prototypes to match the above.
3019
3020 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3021 are duplicate now that they've been promoted to lisp.h.
3022 (x_allocate_bitmap_record, x_alloc_image_color)
3023 (make_image_cache, cache_image, xpm_load):
3024 Don't update size until alloc is done.
3025 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3026 (x_detect_edges):
3256efce 3027 Check for size calculation overflow.
726e0ab1
PE
3028 (ct_colors_allocated_max): New constant.
3029 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3030 overflow.
3256efce 3031
726e0ab1
PE
3032 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3033 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3034 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3035 Use ptrdiff_t, not int, to count maps.
3036 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
3037 calculations. Don't update size until allocation succeeds.
3038 Redo calculations to avoid overflow.
726e0ab1
PE
3039 * keyboard.h: Change prototypes to match the above.
3040
3041 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3042 to count maps.
3043 (current_minor_maps): Check for size calculation overflow.
3044 * keymap.h: Change prototypes to match the above.
3045
3046 * lread.c (read1, init_obarray): Don't update size until alloc done.
3047
3048 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3049 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3050
726e0ab1
PE
3051 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3052 Now ptrdiff_t, not int.
3053 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3054 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3055
3056 * process.c (Fnetwork_interface_list): Check for overflow
3057 in size calculation.
3058
3059 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3060
3061 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3062 overflow. Don't bother calling xmalloc when xrealloc will do.
3063
3064 * search.c (Freplace_match): Check for size calculation overflow.
3065 (Fset_match_data): Don't assume list lengths fit in 'int'.
3066
3067 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3068 for command line length. Do not attempt to address one before the
3069 beginning of an array, as that's not portable.
3070
3071 * term.c (max_frame_lines): Remove; unused.
3072 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3073 not int.
3074 (encode_terminal_code, calculate_costs): Check for size
3075 calculation overflow.
3076 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3077 table lengths and related sizes. Don't update size until alloc
3078 done. Redo calculations to avoid overflow.
3079 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3080
3081 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3082 subtracting pointers.
3083 (gobble_line): Check for overflow more carefully. Don't update size
3084 until alloc done.
3085
3086 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3087 Don't update size until alloc done.
3088 Redo size calculations to avoid overflow.
3089 Check for size calculation overflow.
0065d054 3090 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
3091
3092 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3093 Use ptrdiff_t, not int, for sizes.
3094 (store_mode_line_noprop_char): Don't update size until alloc done.
3095
0065d054
PE
3096 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3097 Use ptrdiff_t, not int, for sizes.
3098 (Finternal_make_lisp_face, cache_face):
3099 Check for size calculation overflow.
3100 (cache_face): Treat size calculation overflows as if they were
3101 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
3102
3103 * xfns.c (x_encode_text, x_set_name_internal)
3104 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3105 sizes, since they can exceed INT_MAX in size. Check for size
3106 calculation overflow.
3107
0065d054
PE
3108 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3109 (xg_select): Check for size calculation overflow.
726e0ab1
PE
3110 Don't update size until alloc done.
3111
0065d054 3112 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 3113 as sprintf is limited to int lengths.
1d526e2f 3114
252c5ee1
PE
3115 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3116 (X_LONG_MIN): New macros.
864d7ce7
PE
3117 Use them to make the following changes clearer.
3118 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3119 This change doesn't affect the value now, but it may help remind
3120 future maintainers not to raise the value too much later.
3121 (SELECTION_QUANTUM): Remove, replacing with ...
3122 (selection_quantum): ... new function, which avoids overflow.
3123 All uses changed.
3124 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3125 assumption that selection length fits in 'int'.
3126 (x_reply_selection_request, x_handle_selection_request)
3127 (x_get_window_property, receive_incremental_selection)
3128 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3129 (lisp_data_to_selection_data, clean_local_selection_data):
3130 Use ptrdiff_t, not int, to record length of selection.
3131 (x_reply_selection_request, x_get_window_property)
3132 (receive_incremental_selection, x_property_data_to_lisp):
3133 Redo calculations to avoid overflow.
3134 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 3135 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
3136 something.
3137 (x_get_window_property, receive_incremental_selection)
3138 (lisp_data_to_selection_data, x_property_data_to_lisp):
3139 Check for size-calculation overflow.
3140 (x_get_window_property, receive_incremental_selection)
3141 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3142 Don't store size until memory allocation succeeds.
3143 (x_get_window_property): Plug memory leak on memory exhaustion.
3144 Don't double-block input; malloc is safe here. Don't assume 2**34
3145 - 4 fits in unsigned long. Add an xassert to check
3146 XGetWindowProperty overflow. Be more careful about overflow
3147 calculations, and distinguish size from memory overflow better.
3148 (receive_incremental_selection): When tracing, don't assume
3149 unsigned int is less than INT_MAX.
3150 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3151 harmful) conversions of unsigned short to int.
3152 (lisp_data_to_selection_data): Don't assume that integers
3153 in the range -65535 through -1 fit in an X unsigned short.
3154 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3155 result parameters unless successful. Rely on cons_to_unsigned
3156 to report problems with elements; the old code wasn't right anyway.
3157 (x_check_property_data): Check for int overflow; we cannot use
3158 a wider type due to X limits.
3159 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3160
726e0ab1 3161 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 3162
0065d054
PE
3163 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3164 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
3165 (x_color_cells): Don't store size until memory allocation succeeds.
3166 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 3167 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
3168 (x_term_init): Don't assume length fits in int (sprintf is limited
3169 to int size).
bc18e09d 3170
ebfa62c0
PE
3171 Use ptrdiff_t for composition IDs.
3172 * character.c (lisp_string_width):
3173 * composite.c (composition_table_size, n_compositions)
3174 (get_composition_id, composition_gstring_from_id):
3175 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3176 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3177 * window.c (Frecenter):
3178 Use ptrdiff_t, not int, for composition IDs.
3179 * composite.c (get_composition_id): Check for integer overflow.
3180 * composite.h: Adjust prototypes to match the above changes.
3181
d3411f89
PE
3182 Use ptrdiff_t for hash table indexes.
3183 * category.c (hash_get_category_set):
3184 * ccl.c (ccl_driver):
3185 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3186 * coding.c (coding_system_charset_list, detect_coding_system):
3187 * coding.h (struct coding_system.id):
3188 * composite.c (get_composition_id, gstring_lookup_cache):
3189 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3190 * image.c (xpm_get_color_table_h):
3191 * lisp.h (hash_lookup, hash_put):
3192 * minibuf.c (Ftest_completion):
3193 Use ptrdiff_t for hash table indexes, not int (which is too
3194 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3195 32-bit --with-wide-int hosts).
3196
e097a6fa
PE
3197 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3198 Add a FIXME comment about memory leaks.
3199 (syms_of_charset): Don't assume xmalloc returns.
3200
5637687f
PE
3201 Don't assume that stated character widths fit in int.
3202 * character.c (Fchar_width, c_string_width, lisp_string_width):
3203 * character.h (CHAR_WIDTH):
3204 * indent.c (MULTIBYTE_BYTES_WIDTH):
3205 Use sanitize_char_width to avoid undefined and/or bad behavior
3206 with outlandish widths.
a66cfb1c 3207 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
3208 now that we have two such functions. All uses changed.
3209 (sanitize_char_width): New inline function.
3210
a2271ba2
PE
3211 Don't assume that tab-width fits in int.
3212 * character.h (sanitize_width): New inline function.
3213 (SANE_TAB_WIDTH): New macro.
3214 (ASCII_CHAR_WIDTH): Use it.
3215 * indent.c (sane_tab_width): Remove. All uses replaced by
3216 SANE_TAB_WIDTH (current_buffer).
3217 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3218
18c52557
PE
3219 * fileio.c: Integer overflow issues with file modes.
3220 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3221
caeeedc1
PE
3222 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3223 Remove unreachable code.
3224 (read_hex, load_charset_map_from_file): Check for integer overflow.
3225
6df6ae42 3226 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
3227 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3228 (x_send_scroll_bar_event): Likewise. Check that the size does not
3229 exceed limits imposed by XClientMessageEvent, as well as the usual
3230 ptrdiff_t and size_t limits.
3231
b13995db
PE
3232 * keyboard.c: Overflow, signedness and related fixes.
3233 (make_lispy_movement): Use same integer type in forward decl
3234 that is used in the definition.
3235 (read_key_sequence, keyremap_step):
3236 Change bufsize argument back to int, undoing my 2011-03-30 change.
3237 We prefer signed types, and int is wide enough here.
3238 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3239 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3240 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3241 length, not size_t. Use ptrdiff_t for index, not int.
3242 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3243 possibility of integer overflow.
3244
13464394
PE
3245 Overflow, signedness and related fixes for images.
3246
3247 * dispextern.h (struct it.stack[0].u.image.image_id)
3248 (struct_it.image_id, struct image.id, struct image_cache.size)
3249 (struct image_cache.used, struct image_cache.ref_count):
3250 * gtkutil.c (update_frame_tool_bar):
3251 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3252 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3253 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3254 * nsmenu.m (update_frame_tool_bar):
3255 * xdisp.c (calc_pixel_width_or_height):
3256 * xfns.c (image_cache_refcount):
3257 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3258 on typical 64-bit hosts.
3259
3260 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3261 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3262 Omit unnecessary casts to int.
3263 (parse_image_spec): Check that integers fall into 'int' range
3264 when the callers expect that.
3265 (image_ascent): Redo ascent calculation to avoid int overflow.
3266 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3267 (lookup_image): Remove unnecessary tests.
3268 (xbm_image_p): Locals are now of int, not EMACS_INT,
3269 since parse_image_check makes sure they fit into int.
3270 (png_load, gif_load, svg_load_image):
3271 Prefer int to unsigned where either will do.
3272 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
3273 old tiff_error_handler and tiff_warning_handler.
3274 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
3275 stack buffer overflows. It uses only the features of vsnprintf
3276 that are common to both POSIX and native Microsoft.
3277 (tiff_error_handler, tiff_warning_handler): Use it.
3278 (tiff_load, gif_load, imagemagick_load_image):
3279 Don't assume :index value fits in 'int'.
3280 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3281 (imagemagick_load_image): Check that crop parameters fit into
3282 the integer types that MagickCropImage accepts. Don't assume
3283 Vimagemagick_render_type has a nonnegative value. Don't assume
3284 size_t fits in 'long'.
3285 (gs_load): Use printmax_t to print the widest integers possible.
3286 Check for integer overflow when computing image height and width.
3287
c11821d4
EZ
32882011-08-26 Eli Zaretskii <eliz@gnu.org>
3289
3290 * xdisp.c (redisplay_window): Don't force window start if point
3291 will be invisible in the resulting window. (Bug#9324)
3292
0c95fcf7
EZ
32932011-08-25 Eli Zaretskii <eliz@gnu.org>
3294
3295 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3296 the display spec is of the form `(space ...)'.
3297 (handle_display_spec): Return the value returned by
3298 handle_single_display_spec, not just 1 or zero.
3299 (handle_single_display_spec): If the display spec is of the form
3300 `(space ...)', and specifies display in the text area, return 2
3301 rather than 1.
fee65a97 3302 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
3303 accurately, and prefer exact match for point under bidi.
3304 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
3305
3306 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3307 into disp_prop; all users changed.
3308
3309 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3310 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3311 for the text covered by the display property.
3312
e4ed06f1
CY
33132011-08-25 Chong Yidong <cyd@stupidchicken.com>
3314
3315 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3316 Change return value to nil.
3317 (Frecord_buffer): Delete unused function.
3318
f67cdd7f
EZ
33192011-08-24 Eli Zaretskii <eliz@gnu.org>
3320
5980d4c6
EZ
3321 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3322 buffers, return left-to-right.
8610fe8b
EZ
3323 (set_cursor_from_row): Consider candidate row a win if its glyph
3324 represents a newline and point is on that newline. Fixes cursor
3325 positioning on the newline at EOL of R2L text within L2R
3326 paragraph, and vice versa.
3327 (try_cursor_movement): Check continued rows, in addition to
3328 continuation rows. Fixes unwarranted scroll when point enters a
3329 continued line of R2L text within an L2R paragraph, or vice versa.
3330 (cursor_row_p): Consider the case of point being equal to
3331 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3332 from the end of a short line to the beginning of a continued line
3333 of R2L text within L2R paragraph.
3334 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3335 composed characters.
5980d4c6 3336
f67cdd7f
EZ
3337 * bidi.c (bidi_check_type): Use xassert.
3338 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3339 members.
3340
bca633fb
EZ
33412011-08-23 Eli Zaretskii <eliz@gnu.org>
3342
3343 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3344 a character.
3345
4a5885a7
CY
33462011-08-23 Chong Yidong <cyd@stupidchicken.com>
3347
3348 * nsfont.m (ns_otf_to_script): Fix typo.
3349
0902a04e
KH
33502011-08-22 Kenichi Handa <handa@m17n.org>
3351
3352 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3353 extra slot even if the purpose is char-code-property-table.
3354
1a2e6670
EZ
33552011-08-23 Eli Zaretskii <eliz@gnu.org>
3356
8ddde651
EZ
3357 * xdisp.c (redisplay_window): When computing centering_position,
3358 account for the height of the header line. (Bug#8874)
3359
425cc014
EZ
3360 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3361 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3362 candidate is selected by the mouse, and that candidate has a
3363 composed character under the mouse.
3364
1a2e6670
EZ
3365 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3366 coordinates reported by pos-visible-in-window-p for a composed
3367 character in column zero.
3368
8b76d6f8
SM
33692011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3370
3371 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3372
dac347dd
EZ
33732011-08-22 Eli Zaretskii <eliz@gnu.org>
3374
3375 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3376 consider it a hit if to_charpos is anywhere in the range of the
3377 composed buffer positions.
3378
e013fb34
CY
33792011-08-22 Chong Yidong <cyd@stupidchicken.com>
3380
3381 * image.c (gif_load): Don't assume that each subimage has the same
3382 dimensions as the base image. Handle disposal method that is
3383 "undefined" by the gif spec (Bug#9335).
3384
bd1ba3e8
CY
33852011-08-20 Chong Yidong <cyd@stupidchicken.com>
3386
3387 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3388 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3389
54a1215b
EZ
33902011-08-19 Eli Zaretskii <eliz@gnu.org>
3391
823564e5
EZ
3392 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3393 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3394 from an Org mode buffer to a Speedbar frame.
3395
54a1215b
EZ
3396 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3397 a composition, take its buffer position from IT->cmp_it.charpos.
3398 Fixes cursor positioning at the beginning of a line that begins
3399 with a composed character.
3400
9778ebcc
EZ
34012011-08-18 Eli Zaretskii <eliz@gnu.org>
3402
0be6ee06
EZ
3403 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3404 character bidirectional type, use STRONG_L instead. Fixes crashes
3405 in a buffer produced by `describe-categories'.
3406
9778ebcc
EZ
3407 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3408 members before the level stack, so they would be saved and
3409 restored when copying iterator state. Fixes incorrect reordering
3410 around TABs covered by display properties.
3411
156bffbe
AS
34122011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3413
6b02f655 3414 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3415
72ad093b
CY
34162011-08-17 Chong Yidong <cyd@stupidchicken.com>
3417
3418 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3419 (internal_condition_case_2, internal_condition_case_n):
3420 Remove unnecessary aborts (Bug#9081).
72ad093b 3421
35774242
EZ
34222011-08-17 Eli Zaretskii <eliz@gnu.org>
3423
3424 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3425 has no `load' handler, try opening the file locally. (Bug#9311)
3426
db76dd85
KB
34272011-08-16 Ken Brown <kbrown@cornell.edu>
3428
3429 * gmalloc.c: Expand comment.
3430
b215eee5
EZ
34312011-08-16 Eli Zaretskii <eliz@gnu.org>
3432
3433 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3434 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3435
a4579d33
KB
34362011-08-16 Ken Brown <kbrown@cornell.edu>
3437
3438 Fix memory allocation problems in Cygwin build (Bug#9273).
3439
3440 * unexcw.c ( __malloc_initialized): Declare external variable.
3441 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3442
8b76d6f8
SM
3443 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3444 New variables.
a4579d33
KB
3445 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3446 dumped emacs.
3447 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3448 in the static heap.
3449 [CYGWIN] (special_realloc): New function.
3450 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3451 requests to realloc storage in the static heap.
3452
3ebec551
PE
34532011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3454
3455 * bidi.c (bidi_initialize): Remove unused local.
3456
9fd8be00
EZ
34572011-08-15 Eli Zaretskii <eliz@gnu.org>
3458
6b02f655
SM
3459 * bidimirror.h:
3460 * biditype.h: Remove file.
3461 * makefile.w32-in ($(BLD)/bidi.$(O)):
3462 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3463
3464 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3465
3466 * chartab.c: Improve commentary for the uniprop_table API.
3467
32413314
EZ
3468 * bidi.c (bidi_paragraph_init): Support zero value of
3469 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3470 (bidi_initialize): Use uniprop_table instead of including
3471 biditype.h and bidimirror.h.
32413314 3472
9fd8be00
EZ
3473 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3474 coordinates of the iterator when restoring from ppos_it.
3475 (Bug#9296)
3476
5cf2b69b
KH
34772011-08-14 Kenichi Handa <handa@m17n.org>
3478
3479 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3480 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3481
daf17d00
EZ
34822011-08-14 Eli Zaretskii <eliz@gnu.org>
3483
3484 * xdisp.c (move_it_in_display_line_to): Don't invoke
3485 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3486 ppos_it. Fixes vertical cursor motion when line beginning is
3487 covered by an image. (Bug#9296)
3488
08e3161a
JD
34892011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3490
3491 * nsterm.h (ns_run_ascript): Declare.
3492 (NSAPP_DATA2_RUNASSCRIPT): Define.
3493
3494 * nsfns.m (as_script, as_result, as_status): New static variables.
3495 (ns_run_ascript): New function.
5e617bc2 3496 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3497 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3498 the event loop. Get status from as_status (Bug#7276).
3499
3500 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3501 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3502 the event loop (Bug#7276).
3503
a3720aa2
AS
35042011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3505
3506 * gnutls.c (QCgnutls_bootprop_priority)
3507 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3508 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3509 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3510 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3511 (QCgnutls_bootprop_verify_hostname_error)
3512 (QCgnutls_bootprop_callbacks_verify): Rename from
3513 Qgnutls_bootprop_..., all uses changed.
3514
3515 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3516 uses changed.
3517
0a0d27fb
PE
35182011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3519
19d5c50c
PE
3520 * xfaces.c (Qframe_set_background_mode): Now static.
3521 * dispextern.h (Qframe_set_background_mode): Remove decl.
3522
0a0d27fb
PE
3523 * process.c (Fnetwork_interface_info): Declare local only if needed.
3524
377538cb
JD
35252011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3526
3527 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3528 (Fnetwork_interface_list): Allocate in increments of bytes instead
3529 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3530 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3531 sockaddr.
3532 (struct ifflag_def): notrailers is smart on OSX.
3533 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3534 Get hardware address with getifaddrs if available.
3535
08fff70c
EZ
35362011-08-12 Eli Zaretskii <eliz@gnu.org>
3537
3538 * xdisp.c (iterate_out_of_display_property): xassert that
3539 IT->position is set to within IT->object's boundaries. Break from
3540 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3541 when IT->position is set up wrongly due to some bug.
3542 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3543 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3544 entry. Force push_it to save on the stack the current
3545 buffer/string position, to be restored by pop_it. Fix flags in
3546 the iterator structure wrt the object coming from a display
3547 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3548 properties. (Bug#9284)
3549
7be1c708 35502011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3551
7be1c708
CY
3552 * fontset.c (fontset_get_font_group): Add proper type checks.
3553 (Bug#9172)
aac0c6e3 3554
7be1c708 35552011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3556
7be1c708
CY
3557 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3558 and LC_VERSION_MIN_MACOSX.
3559 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3560 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3561
97bb72a6
EZ
35622011-08-08 Eli Zaretskii <eliz@gnu.org>
3563
3564 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3565 no-display-properties-and-no-overlays under bidi display.
3566 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3567 properties and overlays.
97bb72a6 3568
d5617611
CY
35692011-08-08 Chong Yidong <cyd@stupidchicken.com>
3570
37e11a63
CY
3571 * editfns.c (Fset_time_zone_rule): Document relationship with the
3572 setenv function.
3573
d5617611
CY
3574 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3575 the font entity extracted from the cache (Bug#8109).
3576
58872834
CY
35772011-08-07 Chong Yidong <cyd@stupidchicken.com>
3578
3579 * composite.c (autocmp_chars): Don't reset point. That is done by
3580 restore_point_unwind (Bug#5984).
3581
75bfc667
JL
35822011-08-07 Juri Linkov <juri@jurta.org>
3583
3584 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3585 to show the arg `TIME' instead of `TIMEVAL'.
3586
d1410150
EZ
35872011-08-06 Eli Zaretskii <eliz@gnu.org>
3588
3589 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3590 display property strides EOL and includes a newline, as in
3591 longlines-mode. (Bug#9254)
75b771e4
EZ
3592 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3593 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3594
3595 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3596 is non-zero, even if the data buffer is NULL. Fixes a crash in
3597 vertical-motion with longlines-mode. (Bug#9254)
3598
35928349
EZ
35992011-08-05 Eli Zaretskii <eliz@gnu.org>
3600
ec7cc85b
EZ
3601 * bidi.c <bidi_cache_total_alloc>: Now static.
3602 (bidi_initialize): Initialize bidi_cache_total_alloc.
3603
8b76d6f8 3604 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3605 cache. (Bug#9221)
3606
3607 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3608 amount allocated this far in `bidi_cache_total_alloc'.
3609 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3610 non-zero, only free the data buffer without restoring the cache
3611 contents. All callers changed.
3612
3613 * dispextern.h (bidi_unshelve_cache): Update prototype.
3614
3615 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3616 (move_it_in_display_line, move_it_to)
3617 (move_it_vertically_backward, move_it_by_lines): Replace the call
3618 to xfree to an equivalent call to bidi_unshelve_cache.
3619 (move_it_in_display_line_to): Fix logic of returning
412b6358 3620 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3621
e2e2423b
EZ
36222011-08-05 Eli Zaretskii <eliz@gnu.org>
3623
3624 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3625 came from a string character with a `cursor' property. (Bug#9229)
3626
ae9e757a
JD
36272011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3628
3629 * Makefile.in (LIB_PTHREAD): New variable.
3630 (LIBES): Add LIB_PTHREAD (Bug#9216).
3631
3632 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3633 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3634
213bd7f2
AS
36352011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3636
6b02f655 3637 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3638
99aaf75f
JD
36392011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3640
3641 * xterm.c (x_find_topmost_parent): New function.
3642 (x_set_frame_alpha): Find topmost parent window with
3643 x_find_topmost_parent and set the property there also (bug#9181).
3644 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3645
c74e9d86
PE
36462011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3647
3648 * callproc.c (Fcall_process): Avoid vfork clobbering
3649 the local vars buffer, coding_systems, current_dir.
3650
640c8776
SM
36512011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3652
3653 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3654
f26d0e4c
PE
36552011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3656
8a10d76c
PE
3657 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3658 so that it is not optimized away.
3659
f26d0e4c
PE
3660 * xdisp.c (compute_display_string_pos): Remove unused local.
3661
55439c61
EZ
36622011-08-02 Eli Zaretskii <eliz@gnu.org>
3663
3664 Fix slow cursor motion and scrolling in large buffers with
3665 selective display, like Org Mode buffers. (Bug#9218)
3666
3667 * dispextern.h (struct bidi_it): New member disp_prop_p.
3668
3669 * xdisp.c: Remove one-slot cache of display string positions.
3670 (compute_display_string_pos): Accept an additional argument
5e617bc2 3671 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3672 for a display string or property. If found, set DISP_PROP_P
3673 non-zero.
3674
3675 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3676 DISP_PROP_P, and pass it to compute_display_string_pos.
3677 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3678 non-zero. All callers of bidi_fetch_char changed.
3679
fb33fa43
SM
36802011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3681
3682 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3683
b099e063
DM
36842010-12-03 Don March <don@ohspite.net>
3685
3686 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3687 last character M-[char] is translated to ESC [char] (bug#7541).
3688
5cc7f7af
KH
36892011-08-02 Kenichi Handa <handa@m17n.org>
3690
d0fffa3f 3691 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3692
3693 * chartab.c (uniprop_table): Make it non-static.
3694
525d5e6e
EZ
36952011-08-01 Eli Zaretskii <eliz@gnu.org>
3696
3697 * xdisp.c (forward_to_next_line_start): Accept additional argument
3698 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3699 on the newline.
3700 (reseat_at_next_visible_line_start): Use the bidi iterator state
3701 returned by forward_to_next_line_start to restore the state of
3702 it->bidi_it after backing up to previous newline. (Bug#9212)
3703
31011111
AS
37042011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3705
3706 * regex.c (re_comp): Protoize.
3707 (re_exec): Fix return type.
3708 (regexec): Fix type of `ret'. (Bug#9203)
3709
476371c4
PE
37102011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3711
e5d76069
PE
3712 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3713 This is needed if max-image-size is a floating-point number.
3714
9a79b20c
AS
37152011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3716
3717 * print.c (print_object): Print empty symbol as ##.
3718
3719 * lread.c (read1): Read ## as empty symbol.
3720
d8c2fa78
AA
37212011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3722
3723 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3724 setting frame foreground color (Bug#9175).
3725 (x_set_background_color): Likewise.
3726
ffe57a7a
AA
3727 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3728 contents (Bug#9176).
3729 (EmacsTooltip -init): Remove bezels and add shadows to
3730 tooltip windows.
3731
bf3492a5
AA
3732 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3733 or scroll bar (Bug#8470).
3734
d55e9c53
AA
3735 * nsfont.m (nsfont_open): Remove assignment to voffset and
3736 unnecessary vars hshink, expand, hd, full_height, min_height.
3737 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3738
3739 * nsterm.h (nsfont_info): Remove voffset field.
3740
d8c2fa78 37412011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3742
3743 Implement strike-through and overline on NextStep (Bug#8863).
3744
3745 * nsfont.m (nsfont_open): Use underline position provided by font,
3746 instead of hard-coded value of 2.
3747 (nsfont_draw): Call ns_draw_text_decoration instead.
3748
3749 * nsterm.h: Add declaration for ns_draw_text_decoration.
3750
3751 * nsterm.m (ns_draw_text_decoration): New function for drawing
3752 underline, overline, and strike-through.
3753 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3754 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3755 accommodate underlining, etc.
4843aac3 3756
4cc60b9b
EZ
37572011-07-28 Eli Zaretskii <eliz@gnu.org>
3758
bc7ece87
EZ
3759 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3760 default.
4cc60b9b 3761
476371c4
PE
37622011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3763
66606eea
PE
3764 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3765 Without this fix, if a signal arrives just after memory fills up,
3766 'malloc' might be invoked reentrantly.
3767
476371c4
PE
3768 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3769 In other words, assume that every image size is allowed, on non-X
3770 hosts. This assumption is probably wrong, but it lets Emacs compile.
3771
f3fcc40d
AS
37722011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3773
3774 * regex.c (re_iswctype): Convert return values to boolean.
3775
350c992f
EZ
37762011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3777
3778 * xdisp.c (compute_display_string_pos): Don't use cached display
3779 string position if the buffer had its restriction changed.
3780 (Bug#9184)
3781
5266b4bb
PE
37822011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3783
3784 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3785
2573a837 37862011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3787
41f55ccd 3788 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3789
39e378da
PE
3790 * bidi.c: Integer size and overflow fixes.
3791 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3792 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3793 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3794 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3795 (bidi_find_other_level_edge):
3796 Use ptrdiff_t instead of EMACS_INT where either will do.
3797 This works better on 32-bit hosts configured --with-wide-int.
3798 (bidi_cache_ensure_space): Check for size-calculation overflow.
3799 Use % rather than repeated addition, for better worst-case speed.
3800 Don't set bidi_cache_size until after xrealloc returns, because it
3801 might not return.
3802 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3803 (bidi_cache_ensure_space): Also check that the bidi cache size
3804 does not exceed that of the largest Lisp string or buffer. See Eli
3805 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3806
5e927815
PE
3807 * alloc.c (__malloc_size_t): Remove.
3808 All uses replaced by size_t. See Andreas Schwab's note
3809 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3810
ca4aa935
PE
3811 * image.c: Improve checking for integer overflow.
3812 (check_image_size): Assume that f is nonnull, since
3813 it is always nonnull in practice. This is one less thing to
3814 worry about when checking for integer overflow later.
3815 (x_check_image_size): New function, which checks for integer
3816 overflow issues inside X.
3817 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3818 This removes the need for a memory_full check.
3819 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3820 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3821 (xbm_read_bitmap_data): Change locals back to 'int', since
3822 their values must fit in 'int'.
3823 (xpm_load_image, png_load, tiff_load):
3824 Invoke x_create_x_image_and_pixmap earlier,
3825 to avoid much needless work if the image is too large.
3826 (tiff_load): Treat overly large images as if
3827 x_create_x_image_and_pixmap failed, not as malloc failures.
3828 (gs_load): Use x_check_image_size.
3829
5f8f9cc2
PE
3830 * gtkutil.c: Omit integer casts.
3831 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3832 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3833
5adf60bc
PE
3834 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3835
c8907a93
PE
3836 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3837 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3838 would wrongly return t on a 64-bit host.
3839
e3c25c68
PE
3840 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3841 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3842 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3843 and therefore cause GCC to emit a bogus diagnostic in some cases.
3844
3f791afe
PE
3845 * image.c: Integer signedness and overflow and related fixes.
3846 This is not an exhaustive set of fixes, but it's time to
3847 record what I've got.
3848 (lookup_pixel_color, check_image_size): Remove redundant decls.
3849 (check_image_size): Don't assume that arbitrary EMACS_INT values
3850 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3851 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3852 (tiff_load, imagemagick_load_image):
3853 Check for overflow in size calculations.
3854 (x_create_x_image_and_pixmap): Remove unnecessary test for
3855 xmalloc returning NULL; that can't happen.
3856 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3857 (xpm_color_bucket): Use better integer hashing function.
3858 (xpm_cache_color): Don't possibly over-allocate memory.
3859 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3860 (gif_memory_source):
3861 Use ptrdiff_t, not int or size_t, to record sizes.
3862 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3863 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3864 either works, as we prefer signed integers.
3865 (tiff_read_from_memory, tiff_write_from_memory):
3866 Return tsize_t, not size_t, since that's what the TIFF API wants.
3867 (tiff_read_from_memory): Don't fail simply because the read would
3868 go past EOF; instead, return a short read.
3869 (tiff_load): Omit no-longer-needed casts.
3870 (Fimagemagick_types): Don't assume size fits into 'int'.
3871
3cc5a532
PE
3872 Improve hashing quality when configured --with-wide-int.
3873 * fns.c (hash_string): New function, taken from sxhash_string.
3874 Do not discard information about ASCII character case; this
3875 discarding is no longer needed.
3876 (sxhash-string): Use it. Change sig to match it. Caller changed.
3877 * lisp.h: Declare it.
3878 * lread.c (hash_string): Remove, since we now use fns.c's version.
3879 The fns.c version returns a wider integer if --with-wide-int is
3880 specified, so this should help the quality of the hashing a bit.
3881
b312a492
PE
3882 * emacs.c: Integer overflow minor fix.
3883 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3884 Define only if GNU_LINUX.
3885 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3886
dfd153ae
PE
3887 * dispnew.c: Integer signedness and overflow fixes.
3888 Remove unnecessary forward decls, that were a maintenance hassle.
3889 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3890 All uses changed.
3891 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3892 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3893 (prepare_desired_row, line_draw_cost):
3894 Use int, not unsigned, where either works.
3895 (save_current_matrix, restore_current_matrix):
3896 Use ptrdiff_t, not size_t, where either works.
3897 (init_display): Check for overflow more accurately, and without
3898 relying on undefined behavior.
3899
a81d11a3
PE
3900 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3901 Remove, replacing with the new symbols in lisp.h. All uses changed.
3902 * fileio.c (make_temp_name):
3903 * filelock.c (lock_file_1, lock_file):
3904 * xdisp.c (message_dolog):
3905 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3906 Use pMd etc. instead.
3907 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3908 replacing the pWIDE etc. symbols removed from editfns.c.
3909
3300e6fd
PE
3910 * keyboard.h (num_input_events): Now uintmax_t.
3911 This is (very slightly) less likely to mess up due to wraparound.
3912 All uses changed.
3913
fd05c7e9
PE
3914 * buffer.c: Integer signedness fixes.
3915 (alloc_buffer_text, enlarge_buffer_text):
3916 Use ptrdiff_t rather than size_t when either will do, as we prefer
3917 signed integers.
3918
903fe15d
PE
3919 * alloc.c: Integer signedness and overflow fixes.
3920 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3921 (__malloc_size_t): Default to size_t, not to int.
3922 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3923 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3924 Prefer ptrdiff_t to size_t when either would do, as we prefer
3925 signed integers.
3926 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3927 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3928 Now const. Initialize with values that are in range even if char
3929 is signed.
3930 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3931 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3932 These functions do the right thing with sizes > 2**32.
3933 (check_depth): Now ptrdiff_t, not int.
3934 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3935 Adjust to new way of storing sizes. Check for size overflow bugs
3936 in rest of code.
3937 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3938 slightly wrong anyway, as it missed one instance of
3939 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3940 (refill_memory_reserve): Omit needless cast to size_t.
3941 (mark_object_loop_halt): Mark as externally visible.
3942
ac82cc6a
PE
3943 * xselect.c: Integer signedness and overflow fixes.
3944 (Fx_register_dnd_atom, x_handle_dnd_message):
3945 Use ptrdiff_t, not size_t, since we prefer signed.
3946 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3947 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3948 x_dnd_atoms_size and x_dnd_atoms_length.
3949
c2d1e36d
PE
3950 * doprnt.c: Prefer signed to unsigned when either works.
3951 * eval.c (verror):
3952 * doprnt.c (doprnt):
3953 * lisp.h (doprnt):
3954 * xdisp.c (vmessage):
3955 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3956 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3957 prefer signed arithmetic to avoid comparison confusion.
3958 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3959 but is a bit tricky.
3960
0e926e56
PE
3961 Assume freestanding C89 headers, string.h, stdlib.h.
3962 * data.c, doprnt.c, floatfns.c, print.c:
3963 Include float.h unconditionally.
3964 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3965 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3966 * regex.c: Likewise for stddef.h, string.h.
3967 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3968 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3969 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3970 (STDC_HEADERS): Remove obsolete defines.
3971 * sysdep.c: Include limits.h unconditionally.
3972
9cfdb3ec
PE
3973 Assume support for memcmp, memcpy, memmove, memset.
3974 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3975 * regex.c (memcmp, memcpy):
3976 Remove; we assume C89 now.
3977
3978 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3979 (__malloc_safe_bcopy): Remove; no longer needed.
3980
cf950e6b 3981 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3982 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3983 well either way, and we prefer signed to unsigned.
3984
dbf38e02
LMI
39852011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3986
3987 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3988 closes the connection while we're reading (bug#9182).
3989
d6f0886c 39902011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3991
d6f0886c
JD
3992 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3993 are specified (Bug#9168).
24e0f6b1 3994
2eb1f9e6
PE
39952011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3996
3997 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3998 Found by GCC static checking and --with-wide-int on a 32-bit host.
3999
22381272 40002011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
4001
4002 * xdisp.c (compute_display_string_pos): Fix logic of caching
4003 previous display string position. Initialize cached_prev_pos to
4004 -1. Fixes slow-down at the beginning of a buffer.
4005
f25e39b4
EZ
40062011-07-24 Eli Zaretskii <eliz@gnu.org>
4007
4008 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4009 for attrs[LFACE_FONTSET_INDEX].
4010
04c4b52e
PE
40112011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4012
4013 * xml.c (parse_region): Remove unused local
4014 that was recently introduced.
4015
c1734fbd
EZ
40162011-07-23 Eli Zaretskii <eliz@gnu.org>
4017
be18c5a5
EZ
4018 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4019 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4020
c1734fbd
EZ
4021 * xdisp.c (move_it_in_display_line_to): Record the best matching
4022 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
4023 exit if none of the characters scanned was an exact match.
4024 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
4025 when exact match is impossible due to invisible text, and the
4026 lines are truncated.
4027
a258d627
JD
40282011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4029
4030 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4031 for OSX >= 10.7.
4032
b6d5a689
EZ
40332011-07-22 Eli Zaretskii <eliz@gnu.org>
4034
0f74f785
EZ
4035 Fix a significant slow-down of cursor motion with C-n, C-p,
4036 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4037 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 4038 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
4039 (next_element_from_buffer): Call compute_stop_pos_backwards to
4040 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
4041 base_level_stop.
4042 (reseat): Don't look for prev_stop, as that could mean a very long
4043 run.
4044 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4045 <cached_disp_overlay_modiff>: Cache for last found display string
4046 position.
551918c1 4047 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
4048 about the same buffer in the same area of character positions, and
4049 the buffer wasn't changed since the time the display string
4050 position was cached.
551918c1 4051
b2d0c91a
EZ
40522011-07-22 Eli Zaretskii <eliz@gnu.org>
4053
4054 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4055 is an integer, which is important for empty lines. (Bug#9149)
4056
043604ee
CY
40572011-07-22 Chong Yidong <cyd@stupidchicken.com>
4058
4059 * frame.c (Fmodify_frame_parameters): In tty case, update the
4060 default face if necessary (Bug#4238).
4061
da4adb04
CY
40622011-07-21 Chong Yidong <cyd@stupidchicken.com>
4063
4064 * editfns.c (Fstring_to_char): No need to explain what a character
4065 is in the docstring (Bug#6576).
4066
9abd0532
LMI
40672011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4068
4069 * xml.c (parse_region): Make sure we always return a tree.
4070
36881d16
HK
40712011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4072
4073 * xml.c (parse_region): If a document contains only comments,
4074 return that, too.
4075
1e98674d
LMI
40762011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4077
4078 * xml.c (make_dom): Return comments, too.
4079
590bd467
PE
40802011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4081
4082 Port to OpenBSD.
4083 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4084 and the surrounding thread.
4085 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4086 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4087 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4088 timer goes off.
4089 * s/openbsd.h (BROKEN_SIGIO): Define.
4090 * unexelf.c (unexec) [__OpenBSD__]:
4091 Don't update the .mdebug section of the Alpha COFF symbol table.
4092
f41628b2
LMI
40932011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4094
4095 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4096 (bug#8460).
4097
b59b67c5
PE
40982011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4099
15e3a074
PE
4100 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4101 This fixes some race conditions on the permissions of any newly
4102 created file.
4103
41bed37d
PE
4104 * alloc.c (valid_pointer_p): Use pipe, not open.
4105 This fixes some permissions issues when debugging.
4106
b59b67c5
PE
4107 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4108 If fchown fails to set both uid and gid, try to set just gid,
4109 as that is sometimes allowed. Adjust the file's mode to eliminate
4110 setuid or setgid bits that are inappropriate if fchown fails.
4111
925a6be7
SM
41122011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4113
4114 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4115 to compare Lisp_Objects.
4116 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4117 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4118 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4119
52968808
AS
41202011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4121
0a6a104b
AS
4122 * lread.c (read_integer): Unread even EOF character.
4123 (read1): Likewise. Properly record start position of symbol.
4124
52968808
AS
4125 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4126 symbol character follows.
4127
9e381cdd
PE
41282011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4129
4130 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4131 This works around a problem with the previous change to Fcopy_file.
4132 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4133 and without this change, GCC might complain about discarding
4134 fchown's return value.
4135
b5641435
JB
41362011-07-16 Juanma Barranquero <lekktu@gmail.com>
4137
4138 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4139
a8031457
PE
41402011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4141
4142 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4143
dd889327
LMI
41442011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4145
750c33f7
LMI
4146 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4147 it's used from the C level.
4148
dd889327
LMI
4149 * process.c: Use the same condition for POLL_FOR_INPUT in both
4150 keyboard.c and process.c (bug#1858).
4151
87e86684
LM
41522011-07-09 Lawrence Mitchell <wence@gmx.li>
4153
4154 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4155 (Fgnutls_boot): Use it.
4156
64348f40
AS
41572011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4158
4159 * doc.c (Fsubstitute_command_keys): Revert last change.
4160
1d698799
LMI
41612011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4162
f863868c
LMI
4163 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4164 quotes the next character, and doesn't affect other longer
4165 sequences (bug#8935).
4166
1d698799
LMI
4167 * lread.c (syms_of_lread): Clarify that is isn't only
4168 `eval-buffer' and `eval-defun' that's affected by
4169 `lexical-binding' (bug#8460).
4170
aa4b6df6
EZ
41712011-07-15 Eli Zaretskii <eliz@gnu.org>
4172
4173 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 4174 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 4175
5d856da6
PE
41762011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4177
ad6042bb
PE
4178 Fix minor problems found by static checking.
4179 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4180 (elsz): Now a signed constant, not a size_t var. We prefer signed
4181 types to unsigned, to avoid integer comparison confusion. Without
4182 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4183 "cannot optimize loop, the loop counter may overflow", a symptom
4184 of the confusion.
f00bbb22 4185 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
4186 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4187
6468f31c
LMI
41882011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4189
49080b10
LMI
4190 * search.c (Fre_search_backward): Mention `case-fold-search' in
4191 all the re_search_* functions (bug#8138).
4192
6468f31c
LMI
4193 * keyboard.c (Fopen_dribble_file): Document when the file is
4194 closed (bug#8056).
4195
c965adc5
EZ
41962011-07-14 Eli Zaretskii <eliz@gnu.org>
4197
df9733bf
EZ
4198 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4199 bidi_cache_idx.
4200
0bb23927
EZ
4201 Support bidi reordering of display and overlay strings.
4202 * xdisp.c (compute_display_string_pos)
4203 (compute_display_string_end): Accept additional argument STRING.
4204 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4205 (reseat_to_string): Initialize bidi_it->string.s and
4206 bidi_it->string.schars.
4207 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
4208 NULL (avoids a crash in bidi_paragraph_init).
4209 Initialize itb.string.lstring.
0bb23927
EZ
4210 (init_iterator): Call bidi_init_it only of a valid
4211 buffer position was specified. Initialize paragraph_embedding to
4212 L2R.
4213 (reseat_to_string): Initialize the bidi iterator.
4214 (display_string): If we need to ignore text properties of
4215 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4216 original value of -1 will not work with bidi.)
4217 (compute_display_string_pos): First arg is now struct
4218 `text_pos *'; all callers changed. Support display properties on
4219 Lisp strings.
4220 (compute_display_string_end): Support display properties on Lisp
4221 strings.
4222 (init_iterator, reseat_1, reseat_to_string): Initialize the
4223 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4224 when iterating on a string not from display properties).
640c8776
SM
4225 (compute_display_string_pos, compute_display_string_end):
4226 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
4227 arrow keys.
4228 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
4229 base_level_stop; instead, set base_level_stop to BEGV.
4230 Fixes crashes in vertical-motion.
0bb23927
EZ
4231 (next_element_from_buffer): Improve commentary for when
4232 the iterator is before prev_stop.
4233 (init_iterator): Initialize bidi_p from the default value of
4234 bidi-display-reordering, not from buffer-local value. Use the
4235 buffer-local value only if initializing for buffer iteration.
4236 (handle_invisible_prop): Support invisible properties on strings
4237 that are being bidi-reordered.
4238 (set_iterator_to_next): Support bidi reordering of C strings and
4239 Lisp strings.
4240 (next_element_from_string): Support bidi reordering of Lisp
4241 strings.
4242 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
4243 (display_string): Support display of R2L glyph rows.
4244 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
4245 (init_iterator): Don't initialize it->bidi_p for strings
4246 here.
4247 (reseat_to_string): Initialize it->bidi_p for strings here.
4248 (next_element_from_string, next_element_from_c_string)
4249 (next_element_from_buffer): Add xassert's for correspondence
4250 between IT's object being iterated and it->bidi_it.string
4251 structure.
4252 (face_before_or_after_it_pos): Support bidi iteration.
4253 (next_element_from_c_string): Handle the case of the first string
4254 character that is not the first one in the visual order.
4255 (get_visually_first_element): New function, refactored from common
4256 parts of next_element_from_buffer, next_element_from_string, and
4257 next_element_from_c_string.
4258 (tool_bar_lines_needed, redisplay_tool_bar)
4259 (display_menu_bar): Force left-to-right direction. Add a FIXME
4260 comment for making that be controlled by a user option.
4261 (push_it, pop_it): Save and restore the state of the
4262 bidi iterator. Save and restore the bidi_p flag.
4263 (pop_it): Iterate out of display property for string iteration as
4264 well.
4265 (iterate_out_of_display_property): Support iteration over strings.
4266 (handle_single_display_spec): Set up it->bidi_it for iteration
4267 over a display string, and call bidi_init_it.
4268 (handle_single_display_spec, next_overlay_string)
4269 (get_overlay_strings_1, push_display_prop): Set up the bidi
4270 iterator for displaying display or overlay strings.
4271 (forward_to_next_line_start): Don't use the shortcut if
4272 bidi-iterating.
4273 (back_to_previous_visible_line_start): If handle_display_prop
4274 pushed the iterator stack, restore the internal state of the bidi
4275 iterator by calling bidi_pop_it same number of times.
4276 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4277 and we are bidi-iterating, don't decrement the iterator position;
4278 instead, set the first_elt flag in the bidi iterator, to produce
4279 the same effect.
4280 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4281 (push_display_prop): xassert that we are iterating a buffer.
4282 (push_it, pop_it): Save and restore paragraph_embedding member.
4283 (handle_single_display_spec, next_overlay_string)
4284 (get_overlay_strings_1, reseat_1, reseat_to_string)
4285 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4286 correctly. Don't assume unibyte strings are not bidi-reordered.
4287 (compute_display_string_pos)
4288 (compute_display_string_end): Fix handling the case of C string.
4289 (push_it, pop_it): Save and restore from_disp_prop_p.
4290 (handle_single_display_spec, push_display_prop): Set the
4291 from_disp_prop_p flag.
4292 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4293 (pop_it): Call iterate_out_of_display_property only if we are
4294 popping after iteration over a string that came from a display
4295 property. Fix a typo in popping stretch info. Add an assertion
4296 for verifying that the iterator position is in sync with the bidi
4297 iterator.
4298 (handle_single_display_spec, get_overlay_strings_1)
4299 (push_display_prop): Fix initialization of paragraph direction for
4300 string when that of the parent object is not yet determined.
4301 (reseat_1): Call bidi_init_it to resync the bidi
4302 iterator with IT's position. (Bug#7616)
4303 (find_row_edges): If ROW->start.pos gives position
4304 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4305 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4306 Reset the from_disp_prop_p flag.
4307 (SAVE_IT, RESTORE_IT): New macros.
4308 (pos_visible_p, face_before_or_after_it_pos)
4309 (back_to_previous_visible_line_start)
4310 (move_it_in_display_line_to, move_it_in_display_line)
4311 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4312 (try_scrolling, redisplay_window, display_line): Use them when
4313 saving a temporary copy of the iterator and restoring it back.
4314 (back_to_previous_visible_line_start, reseat_1)
4315 (init_iterator): Empty the bidi cache "stack".
4316 (move_it_in_display_line_to): If iterator ended up at
4317 EOL, but we never saw any buffer positions smaller than
4318 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4319 motion in bidi-reordered lines.
4320 (move_it_in_display_line_to): Record prev_method and prev_pos
4321 immediately before the call to set_iterator_to_next. Fixes cursor
4322 motion in bidi-reordered lines with stretch glyphs and strings
4323 displayed in margins. (Bug#8133) (Bug#8867)
4324 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4325 TO_CHARPOS.
640c8776
SM
4326 (pos_visible_p): Support positions in bidi-reordered lines.
4327 Save and restore bidi cache.
0bb23927
EZ
4328
4329 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4330 (bidi_paragraph_info): Delete unused struct.
4331 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4332 (bidi_cache_start): New variable.
4333 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4334 to zero.
4335 (bidi_cache_fetch_state, bidi_cache_search)
4336 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4337 (bidi_cache_find, bidi_peek_at_next_level)
4338 (bidi_level_of_next_char, bidi_find_other_level_edge)
4339 (bidi_move_to_visually_next): Compare cache index with
4340 bidi_cache_start rather than with zero.
4341 (bidi_fetch_char): Accept new argument STRING; all callers
4342 changed. Support iteration over a string. Support strings with
4343 display properties. Support unibyte strings. Fix the type of
4344 `len' according to what STRING_CHAR_AND_LENGTH expects.
4345 (bidi_paragraph_init, bidi_resolve_explicit_1)
4346 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4347 (bidi_level_of_next_char, bidi_move_to_visually_next):
4348 Support iteration over a string.
0bb23927
EZ
4349 (bidi_set_sor_type, bidi_resolve_explicit_1)
4350 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4351 can now be zero (for strings); special values 0 and -1 were
4352 changed to -1 and -2, respectively.
4353 (bidi_char_at_pos): New function.
4354 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4355 Call it instead of FETCH_MULTIBYTE_CHAR.
4356 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4357 initialized to valid values.
4358 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4359 values.
4360 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4361 the test for valid cached positions. Fix the logic for looking up
4362 the sentinel state in the cache. GCPRO the Lisp string we are
4363 iterating.
4364 (bidi_push_it, bidi_pop_it): New functions.
4365 (bidi_initialize): Initialize the bidi cache start stack pointer.
4366 (bidi_cache_ensure_space): New function, refactored from part of
4367 bidi_cache_iterator_state. Don't assume the required size is just
4368 one BIDI_CACHE_CHUNK away.
4369 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4370 (bidi_count_bytes, bidi_char_at_pos): New functions.
4371 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4372 always valid if bidi_cache_idx is valid.
4373 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4374 is valid if it's going to be used.
4375 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4376 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4377 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4378 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4379 (bidi_find_other_level_edge, bidi_cache_start_stack):
4380 All variables related to cache indices are now EMACS_INT.
c965adc5 4381
0bb23927
EZ
4382 * dispextern.h (struct bidi_string_data): New structure.
4383 (struct bidi_it): New member `string'. Make flag members be 1-bit
4384 fields, and put them last in the struct.
640c8776
SM
4385 (compute_display_string_pos, compute_display_string_end):
4386 Update prototypes.
0bb23927
EZ
4387 (bidi_push_it, bidi_pop_it): Add prototypes.
4388 (struct iterator_stack_entry): New members bidi_p,
4389 paragraph_embedding, and from_disp_prop_p.
4390 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4391 (bidi_shelve_cache, bidi_unshelve_cache):
4392 Declare prototypes.
0bb23927
EZ
4393
4394 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4395 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4396 and vector-like objects.
4397
4398 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4399 cache around display iteration.
4400
4401 * window.c (Fwindow_end, window_scroll_pixel_based)
4402 (displayed_window_lines, Frecenter): Save and restore the bidi
4403 cache around display iteration.
4404
3bbd2265
LMI
44052011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4406
4407 * editfns.c (Fdelete_region): Clarify the use of the named
4408 parameters (bug#6788).
4409
adc47434
MR
44102011-07-14 Martin Rudalics <rudalics@gmx.at>
4411
4412 * indent.c (Fvertical_motion): Set and restore w->pointm when
4413 saving and restoring the window's buffer (Bug#9006).
4414
837c31f8
LMI
44152011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4416
4417 * editfns.c (Fstring_to_char): Clarify just what is returned
4418 (bug#6576). Text by Eli Zaretskii.
4419
ac389d0c
JB
44202011-07-13 Juanma Barranquero <lekktu@gmail.com>
4421
4422 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4423
0be0ce47
EZ
44242011-07-13 Eli Zaretskii <eliz@gnu.org>
4425
4426 * buffer.c (mmap_find): Fix a typo.
4427
cd18e7e3
JB
44282011-07-13 Johan Bockgård <bojohan@gnu.org>
4429
4430 Fix execution of x selection hooks.
4431 * xselect.c (Qx_lost_selection_functions)
4432 (Qx_sent_selection_functions): New vars.
4433 (syms_of_xselect): DEFSYM them.
4434 (x_handle_selection_request): Pass Qx_sent_selection_functions
4435 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4436 (x_handle_selection_clear,x_clear_frame_selections):
4437 Pass Qx_lost_selection_functions rather than
4438 Vx_lost_selection_functions to Frun_hook_with_args.
4439
47ea7f44
PE
44402011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4441
ac389d0c 4442 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4443 The old code sometimes used this field without initializing it.
4444
47ea7f44
PE
4445 * alloc.c (gc_sweep): Don't read past end of array.
4446 In theory, the old code could also have corrupted Emacs internals,
4447 though it'd be very unlikely.
4448
bc985c87
AS
44492011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4450
4451 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4452 argument. (Bug#4026)
bc985c87 4453
0cf34688
LMI
44542011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4455
b3dadd76
LMI
4456 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4457 key" (bug#4257).
4458
0cf34688
LMI
4459 * window.c (Fset_window_start): Doc fix (bug#4199).
4460 (Fset_window_hscroll): Ditto.
4461
270768cd
PE
44622011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4463
077e3dda 4464 Fix minor new problems caught by GCC 4.6.1.
270768cd 4465 * term.c (init_tty): Remove unused local.
490011a6 4466 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4467 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4468 not used otherwise.
270768cd 4469
b1f58454
CY
44702011-07-12 Chong Yidong <cyd@stupidchicken.com>
4471
4472 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4473
22b9578d
LMI
44742011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4475
6e70ab07
LMI
4476 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4477 are the mini-buffer and the echo area (bug#3320).
4478
22b9578d
LMI
4479 * term.c (init_tty): Remove support for supdup, c10 and perq
4480 terminals, which are no longer supported (bug#1482).
4481
8974cc9f
JB
44822011-07-10 Johan Bockgård <bojohan@gnu.org>
4483
4484 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4485
a560d974
JD
44862011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4487
4488 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4489 for non-popups (Bug#3642).
4490
1dae0f0a
AS
44912011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4492
268c2c36 4493 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4494 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4495 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4496 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4497 * data.c (fmod): Likewise.
4498 * dispnew.c (swap_glyphs_in_rows): Likewise.
4499 * emacs.c (memory_warning_signal): Likewise.
4500 * floatfns.c (float_error): Likewise.
4501 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4502 (otf_open, font_otf_capability, generate_otf_features)
4503 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4504 Likewise.
4505 * image.c (pbm_read_file): Likewise.
4506 * indent.c (string_display_width): Likewise.
4507 * intervals.c (check_for_interval, search_for_interval)
4508 (inc_interval_count, count_intervals, root_interval)
4509 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4510 * lread.c (defalias): Likewise.
268c2c36 4511 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4512 * regex.c (set_image_of_range_1, set_image_of_range)
4513 (regex_grow_registers): Likewise.
4514 * sysdep.c (strerror): Likewise.
4515 * termcap.c (valid_filename_p, tprint, main): Likewise.
4516 * tparam.c (main): Likewise.
4517 * unexhp9k800.c (run_time_remap, save_data_space)
4518 (update_file_ptrs, read_header, write_header, calculate_checksum)
4519 (copy_file, copy_rest, display_header): Likewise.
4520 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4521 Likewise.
4522 * xdisp.c (check_it): Likewise.
4523 * xfaces.c (register_color, unregister_color, unregister_colors):
4524 Likewise.
4525 * xfns.c (print_fontset_result): Likewise.
4526 * xrdb.c (member, fatal, main): Likewise.
4527
99033785
PE
45282011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4529
4530 Fix minor problems found by static checking (Bug#9031).
4531 * chartab.c (char_table_set_range, map_sub_char_table):
4532 Remove unused locals.
4533 (uniprop_table): Now static.
4534 * composite.c (_work_char): Remove unused static var.
4535
9cb2ac56
JB
45362011-07-09 Juanma Barranquero <lekktu@gmail.com>
4537
4538 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4539
f25661f0
JD
45402011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4541
4542 * gtkutil.c (qttip_cb): Remove code without function.
4543
8278c4fe
EZ
45442011-07-09 Eli Zaretskii <eliz@gnu.org>
4545
4546 * w32.c (pthread_sigmask): New stub.
4547
1692ae2d 45482011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4549
8a6ebd58 4550 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4551 sigprocmask is portable only for single-threaded applications, and
4552 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4553 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4554 (LIBES): Use it.
4555 * callproc.c (Fcall_process):
4556 * process.c (create_process):
4557 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4558 Use pthread_sigmask, not sigprocmask.
123403e4 4559
1b854618
JD
45602011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4561
4562 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4563 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4564 wrong (Bug#8591).
4565
3fe4b549
JD
45662011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4567
0ce7e563
JD
4568 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4569 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4570 (xg_hide_tooltip): Fix comment.
4571
3fe4b549
JD
4572 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4573 in registerServicesMenuSendTypes.
4574 (validRequestorForSendType): Don't check ns_return_types.
4575
4576 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4577 ns_return_type.
4578
5df75e47
JR
45792011-07-08 Jason Rumney <jasonr@gnu.org>
4580
22610910
JR
4581 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4582 SH_SHOW for hidden windows (Bug#5482).
4583
5df75e47
JR
4584 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4585 frame struct members of non-existent frames (Bug#6284).
4586
699c10bd
JD
45872011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4588
4393663b
JD
4589 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4590 variable firstTime not needed on OSX >= 10.6.
4591 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4592 >= 10.5. Use setKnobProportion, setDoubleValue.
4593
4594 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4595 (MAC_OS_X_VERSION_10_5): Define if not defined.
4596 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4597 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4598 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4599
4600 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4601 cString and lossyCString on OSX >= 10.4
4602
58179cce 4603 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4604 sizeToFit on OSX >= 10.2.
4605
4606 * nsimage.m (allocInitFromFile): Don't use deprecated method
4607 bestRepresentationForDevice on OSX >= 10.6.
4608
4609 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4610 to avoid warning.
4611
4612 * emacs.c: Declare unexec_init_emacs_zone.
4613
a63e0781
JD
4614 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4615
699c10bd
JD
4616 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4617
4618 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4619 on svcsMenu (Bug#8842).
4620
4621 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4622 ns_return_types.
4623 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4624
4625 * nsterm.m (QUTF8_STRING): Declare.
4626 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4627 (validRequestorForSendType): Return type is (id).
4628 Change indexOfObjectIdenticalTo to indexOfObject.
4629 Check if we have local selection before returning self (Bug#8842).
4630 (writeSelectionToPasteboard): Put local selection into paste board
4631 if we have a local selection (Bug#8842).
4632 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4633
4634 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4635 (ns_get_local_selection): Declare.
4636
54e10184
LMI
46372011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4638
9888ff71
LMI
4639 * keymap.c (describe_map_tree): Don't insert a double newline at
4640 the end of the buffer (bug#1169) and return whether we inserted
4641 something.
4642
54e10184
LMI
4643 * callint.c (Fcall_interactively): Change "reading args" to
4644 "providing args" to try to clarify what it does (bug#1010).
4645
15fa4783
KH
46462011-07-07 Kenichi Handa <handa@m17n.org>
4647
4648 * composite.c (composition_compute_stop_pos): Ignore a static
4649 composition starting before CHARPOS (Bug#8915).
4650
4651 * xdisp.c (handle_composition_prop): Likewise.
4652
a8815b00
EZ
46532011-07-07 Eli Zaretskii <eliz@gnu.org>
4654
4655 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4656 (Bug#9015)
4657
ef7b981d 46582011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4659
4660 * character.h (unicode_category_t): New enum type.
4661
4662 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4663 (Qchar_code_property_table): New variable.
4664 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4665 (UNIPROP_COMPRESSED_FORM_P): New macros.
4666 (char_table_ascii): Uncompress the compressed values.
4667 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4668 Uncompress the compressed values.
ac389d0c 4669 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4670 (char_table_ref_and_range): Uncompress the compressed values.
4671 (sub_char_table_set): New arg is_uniprop. Callers changed.
4672 Uncompress the compressed values.
4673 (sub_char_table_set_range): Args changed. Callers changed.
4674 (char_table_set_range): Adjuted for the above change.
4675 (map_sub_char_table): Delete args default_val and parent. Add arg
4676 top. Give decoded values to a Lisp function.
640c8776 4677 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4678 values to a Lisp function. Gcpro more variables.
4679 (uniprop_table_uncompress)
4680 (uniprop_decode_value_run_length): New functions.
4681 (uniprop_decoder, uniprop_decoder_count): New variables.
4682 (uniprop_get_decoder, uniprop_encode_value_character)
4683 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4684 New functions.
4685 (uniprop_encoder, uniprop_encoder_count): New variables.
4686 (uniprop_get_encoder, uniprop_table)
4687 (Funicode_property_table_internal, Fget_unicode_property_internal)
4688 (Fput_unicode_property_internal): New functions.
4689 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4690 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4691 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4692 char-code-property-alist.
4693
640c8776 4694 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4695 Vunicode_category_table.
4696
640c8776 4697 * font.c (font_range): Adjust for the change of
c805dec0
KH
4698 Vunicode_category_table.
4699
76b397fb
DN
47002011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4701
4702 * m/iris4d.h: Remove file, move contents ...
4703 * s/irix6-5.h: ... here.
4704
22b4128e
PE
47052011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4706
4707 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4708 * alloc.c (mark_buffer):
4709 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4710 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4711 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4712 This isn't true in general, and it's particularly not true
4713 if Emacs is configured with --with-wide-int.
4714 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4715 New macros, used in the buffer.c change.
4716
869795d6
JD
47172011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4718
4719 * xsettings.c: Use both GConf and GSettings if both are available.
4720 (store_config_changed_event): Add comment.
4721 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4722 (store_tool_bar_style_changed): New functions.
5e617bc2 4723 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4724 (struct xsettings): Move font inside HAVE_XFT.
4725 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4726 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4727 Move inside HAVE_XFT.
640c8776 4728 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4729 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4730 also.
4731 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4732 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4733 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4734 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4735 (parse_settings): Move check for font inside HAVE_XFT.
4736 (read_settings, apply_xft_settings): Add comment.
4737 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4738 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4739 call store_font_name_changed.
4740 (xft_settings_event): Add comment.
4741 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4742 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4743 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4744 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4745 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4746 (xsettings_get_system_font, xsettings_get_system_normal_font):
4747 Add comment.
869795d6 4748
d8ed26bd
PE
47492011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4750
4751 Random fixes. E.g., (random) never returned negative values.
4752 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4753 subseconds part to the entropy, as that's a bit more random.
4754 Prefer signed to unsigned, since the signedness doesn't matter and
4755 in general we prefer signed. When given a limit, use a
4756 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4757 latter isn't right if USE_2_TAGS_FOR_INTS.
4758 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4759 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4760
cabf1cac
SM
47612011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4762
4763 * textprop.c (text_property_stickiness):
4764 Obey Vtext_property_default_nonsticky.
4765 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4766 * w32fns.c (syms_of_w32fns):
4767 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4768
6e9b2be9
PE
47692011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4770
4771 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4772 This is more efficient than Ffile_directory_p and avoids a minor race.
4773
90186c68
LMI
47742011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4775
7c301272
LMI
4776 * buffer.c (Foverlay_put): Say what the return value is
4777 (bug#7835).
4778
c4f2d8d4
LMI
4779 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4780 is a directory before asking whether to use the file name
4781 (bug#7564).
ad637907
LMI
4782 (barf_or_query_if_file_exists): Make the "File is a directory"
4783 error be more correct.
c4f2d8d4 4784
90186c68
LMI
4785 * fns.c (Frequire): Remove the mention of the .gz files, since
4786 that's installation-specific, but keep the mention of
4787 `get-load-suffixes'.
4788
da64016e
PE
47892011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4790
4791 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4792 Report string overflow if the output is too long.
4793
7d47b580
JB
47942011-07-04 Juanma Barranquero <lekktu@gmail.com>
4795
a555cb87
JB
4796 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4797 (syms_of_gnutls): Remove duplicate DEFSYM for
4798 Qgnutls_bootprop_verify_hostname_error, an error for
4799 Qgnutls_bootprop_verify_error (which is no longer used).
4800
7d47b580
JB
4801 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4802 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4803 Also (re)move comments that are misplaced or no longer relevant.
4804
1e49bfab
LMI
48052011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4806
4807 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4808
1485f4c0
CY
48092011-07-03 Chong Yidong <cyd@stupidchicken.com>
4810
4811 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4812 and background color parameters if they have been changed.
4813
a9ab721e
LMI
48142011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4815
4816 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4817
cf7cff57
PE
48182011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4819
2e13213d
PE
4820 * xsettings.c (SYSTEM_FONT): Define only when used.
4821 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4822
cf7cff57
PE
4823 * keymap.c (access_keymap_1): Now static.
4824
7a8e04f7
CY
48252011-07-02 Chong Yidong <cyd@stupidchicken.com>
4826
4827 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4828 leave any prefix arg for the up event (Bug#1586).
4829
61352f62
LMI
48302011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4831
69bb1ef7
LMI
4832 * lread.c (syms_of_lread): Mention single symbols defined by
4833 `defvar' or `defconst' (bug#7154).
4834
61352f62 4835 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4836 (Frequire): Mention get-load-suffixes.
61352f62 4837
28545e04
MR
48382011-07-02 Martin Rudalics <rudalics@gmx.at>
4839
4840 * window.h (window): Remove clone_number slot.
4841 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4842 Remove.
4843 (make_parent_window, make_window, saved_window)
4844 (Fset_window_configuration, save_window_save): Don't deal with
4845 clone numbers.
4846 * buffer.c (Qclone_number): Remove declaration.
4847 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4848
3349e122
SM
48492011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4850
4851 Add multiple inheritance to keymaps.
4852 * keymap.c (Fmake_composed_keymap): New function.
4853 (Fset_keymap_parent): Simplify.
4854 (fix_submap_inheritance): Remove.
4855 (access_keymap_1): New function extracted from access_keymap to handle
4856 embedded parents and handle lists of maps.
4857 (access_keymap): Use it.
4858 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4859 (Fcopy_keymap): Handle embedded parents.
4860 (Fcommand_remapping, define_as_prefix): Simplify.
4861 (Fkey_binding): Simplify.
4862 (syms_of_keymap): Move minibuffer-local-completion-map,
4863 minibuffer-local-filename-completion-map,
4864 minibuffer-local-must-match-map, and
4865 minibuffer-local-filename-must-match-map to Elisp.
4866 (syms_of_keymap): Defsubr make-composed-keymap.
4867 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4868 (parse_menu_item): Trivial simplification.
4869
3279eb87
GM
48702011-07-01 Glenn Morris <rgm@gnu.org>
4871
4872 * Makefile.in (SETTINGS_LIBS): Fix typo.
4873
4550efdf
KI
48742011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4875
4876 * coding.c (Fencode_coding_string): Record the last coding system
4877 used, as the function doc string says (bug#8738).
4878
0949d2b6
JD
48792011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4880
4881 * xsettings.c (store_monospaced_changed): Take new font as arg and
4882 check for change against current_mono_font.
4883 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4884 (emacs_settings_constructor, emacs_settings_get_property)
4885 (emacs_settings_set_property, emacs_settings_class_init)
4886 (emacs_settings_init, gsettings_obj): Remove.
4887 (something_changedCB): New function for HAVE_GSETTINGS.
4888 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4889 with value as argument.
4890 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4891 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4892 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4893 "changed".
4894
4895 * xgselect.c: Add defined (HAVE_GSETTINGS).
4896 (xgselect_initialize): Ditto.
4897
4898 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4899 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4900 xg_select.
4901
bbc6b304
PE
49022011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4903
4904 * eval.c (struct backtrace): Simplify and port the data structure.
4905 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4906 signed bit field, as this assumption is not portable and it makes
4907 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4908 "char debug_on_exit : 1" as this is not portable either; instead,
4909 use the portable "unsigned int debug_on_exit : 1". Remove unused
4910 member evalargs. Remove obsolete comments about cc bombing out.
4911
9851bfc5
JD
49122011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4913
51bb811f 4914 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4915 Let HAVE_GSETTINGS override HAVE_GCONF.
4916 (store_monospaced_changed): New function.
4917 (EMACS_SETTINGS): A new type derived from GObject to handle
4918 GSettings notifications.
4919 (emacs_settings_constructor, emacs_settings_get_property)
4920 (emacs_settings_set_property, emacs_settings_class_init):
4921 New functions.
4922 (gsettings_client, gsettings_obj): New variables.
4923 (GSETTINGS_SCHEMA): New define.
4924 (something_changedCB): Call store_monospaced_changed.
4925 (init_gsettings): New function.
4926 (xsettings_initialize): Call init_gsettings.
4927 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4928 to NULL.
4929
640c8776 4930 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4931 GCONF_CFLAGS/LIBS.
4932
5386012d
MR
49332011-06-29 Martin Rudalics <rudalics@gmx.at>
4934
4935 * window.c (resize_root_window, grow_mini_window)
4936 (shrink_mini_window): Rename Qresize_root_window to
4937 Qwindow_resize_root_window and Qresize_root_window_vertically to
4938 Qwindow_resize_root_window_vertically.
4939
f13e0b08
PE
49402011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4941
4942 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4943
94515237
JB
49442011-06-27 Juanma Barranquero <lekktu@gmail.com>
4945
4946 * makefile.w32-in: Redesign dependencies so they reflect more
4947 clearly which files are directly included by each source file,
4948 and not through other includes.
4949
e43b6e43
MR
49502011-06-27 Martin Rudalics <rudalics@gmx.at>
4951
4952 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4953 (sort_overlays, overlay_strings): When an overlay's clone number
4954 matches the window's clone number process the overlay even if
4955 the overlay's window property doesn't match the current window.
4956
d68443dc
MR
4957 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4958 (Fwindow_hchild): Rename to Fwindow_left_child.
4959 (Fwindow_next): Rename to Fwindow_next_sibling.
4960 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4961 (resize_window_check): Rename to window_resize_check.
4962 (resize_window_apply): Rename to window_resize_apply.
4963 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4964 (Fdelete_other_windows_internal, resize_frame_windows)
4965 (Fsplit_window_internal, Fdelete_window_internal)
4966 (grow_mini_window, shrink_mini_window)
4967 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4968
c7e73be5
JD
49692011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4970
4971 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4972 (emacs_fixed_set_min_size): Remove.
4973 (emacs_fixed_new): Take frame as argument.
4974
4975 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4976 (_EmacsFixedPrivate): Remove minwidth/height.
4977 Add struct frame *f.
4978 (emacs_fixed_init): Initialize priv->f.
4979 (get_parent_class, emacs_fixed_set_min_size): Remove.
4980 (emacs_fixed_new): Set priv->f to argument.
4981 (emacs_fixed_get_preferred_width)
4982 (emacs_fixed_get_preferred_height): Use min_width/height from
4983 frames size_hint to set minimum and natural (Bug#8919).
4984 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4985 and use min_width/height from frames size_hint to set
4986 min_width/height (Bug#8919).
4987
4988 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4989 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4990 Fix indentation.
c7e73be5 4991
cf99dcf8
EZ
49922011-06-26 Eli Zaretskii <eliz@gnu.org>
4993
4994 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4995 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4996 called at ZV.
4997
029529ac
CY
49982011-06-26 Chong Yidong <cyd@stupidchicken.com>
4999
5000 * process.c (wait_reading_process_output): Bypass select if
5001 waiting for a cell while ignoring keyboard input, and input is
5002 pending. Suggested by Jan Djärv (Bug#8869).
5003
7a7ef429
PE
50042011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5005
5006 Use gnulib's dup2 module instead of rolling our own.
5007 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5008
11fdef7d 50092011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
5010
5011 * dispnew.c (scrolling_window): Before scrolling, turn off a
5012 mouse-highlight in the window being scrolled.
5013
cd3520a4
JB
50142011-06-24 Juanma Barranquero <lekktu@gmail.com>
5015
5016 Move DEFSYM to lisp.h and use everywhere.
5017
5018 * character.h (DEFSYM): Move declaration...
5019 * lisp.h (DEFSYM): ...here.
5020
5021 * gnutls.c:
5022 * minibuf.c:
5023 * w32menu.c:
5024 * w32proc.c:
5025 * w32select.c: Don't include character.h.
5026
5027 * alloc.c (syms_of_alloc):
5028 * buffer.c (syms_of_buffer):
5029 * bytecode.c (syms_of_bytecode):
5030 * callint.c (syms_of_callint):
5031 * casefiddle.c (syms_of_casefiddle):
5032 * casetab.c (init_casetab_once):
5033 * category.c (init_category_once, syms_of_category):
5034 * ccl.c (syms_of_ccl):
5035 * cmds.c (syms_of_cmds):
5036 * composite.c (syms_of_composite):
5037 * dbusbind.c (syms_of_dbusbind):
5038 * dired.c (syms_of_dired):
5039 * dispnew.c (syms_of_display):
5040 * doc.c (syms_of_doc):
5041 * editfns.c (syms_of_editfns):
5042 * emacs.c (syms_of_emacs):
5043 * eval.c (syms_of_eval):
5044 * fileio.c (syms_of_fileio):
5045 * fns.c (syms_of_fns):
5046 * frame.c (syms_of_frame):
5047 * fringe.c (syms_of_fringe):
5048 * insdel.c (syms_of_insdel):
5049 * keymap.c (syms_of_keymap):
5050 * lread.c (init_obarray, syms_of_lread):
5051 * macros.c (syms_of_macros):
5052 * msdos.c (syms_of_msdos):
5053 * print.c (syms_of_print):
5054 * process.c (syms_of_process):
5055 * search.c (syms_of_search):
5056 * sound.c (syms_of_sound):
5057 * syntax.c (init_syntax_once, syms_of_syntax):
5058 * terminal.c (syms_of_terminal):
5059 * textprop.c (syms_of_textprop):
5060 * undo.c (syms_of_undo):
5061 * w32.c (globals_of_w32):
5062 * window.c (syms_of_window):
5063 * xdisp.c (syms_of_xdisp):
5064 * xfaces.c (syms_of_xfaces):
5065 * xfns.c (syms_of_xfns):
5066 * xmenu.c (syms_of_xmenu):
5067 * xsettings.c (syms_of_xsettings):
5068 * xterm.c (syms_of_xterm): Use DEFSYM.
5069
4228cf16
TZ
50702011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5071
cd3520a4 5072 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 5073
7fcccf1e
PE
50742011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5075
7efb4e0e
PE
5076 Integer and buffer overflow fixes (Bug#8873).
5077
ff5844ad
PE
5078 * print.c (printchar, strout): Check for string overflow.
5079 (PRINTPREPARE, printchar, strout):
5080 Don't set size unless allocation succeeds.
5081
90532f02
PE
5082 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5083 for sizes. Check for string overflow more accurately.
5084 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5085
6d84508d
PE
5086 * macros.c: Integer and buffer overflow fixes.
5087 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5088 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5089 Use ptrdiff_t, not int, for sizes.
5090 Don't increment bufsize until after realloc succeeds.
5091 Check for size-calculation overflow.
5092 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5093
437b2cb4
PE
5094 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5095
8b9ac8b4
PE
5096 * lread.c: Integer overflow fixes.
5097 (read_integer): Radix is now EMACS_INT, not int,
5098 to improve quality of diagnostics for out-of-range radices.
5099 Calculate buffer size correctly for out-of-range radices.
5100 (read1): Check for integer overflow in radices, and in
5101 read-circle numbers.
82cb60d3
PE
5102 (read_escape): Avoid int overflow.
5103 (Fload, openp, read_buffer_size, read1)
5104 (substitute_object_recurse, read_vector, read_list, map_obarray):
5105 Use ptrdiff_t, not int, for sizes.
5106 (read1): Use EMACS_INT, not int, for sizes.
20270765 5107 Check for size overflow.
8b9ac8b4 5108
7fcccf1e
PE
5109 * image.c (cache_image): Check for size arithmetic overflow.
5110
bfbbd7e7
PE
5111 * lread.c: Integer overflow issues.
5112 (saved_doc_string_size, saved_doc_string_length)
5113 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5114 Now ptrdiff_t, not int.
5115 (read1): Don't assume doc string length fits in int. Check for
5116 out-of-range doc string lengths.
5117 (read_list): Don't assume file position fits in int.
39019e54 5118 (read_escape): Check for hex character overflow.
bfbbd7e7 5119
4e323265
LL
51202011-06-22 Leo Liu <sdl.web@gmail.com>
5121
5122 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5123 Move to minibuffer.el.
5124
85fece3e
PE
51252011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5126
20b84ce9 5127 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
5128 The following patches are for when GLYPH_DEBUG && !XASSERT.
5129 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5130 * dispnew.c (flush_stdout):
5131 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5132 Mark as externally visible.
5133 * dispnew.c (check_window_matrix_pointers): Now static.
5134 * dispnew.c (window_to_frame_vpos):
5135 * xfns.c (unwind_create_frame):
5136 * xterm.c (x_check_font): Remove unused local.
5137 * scroll.c (CHECK_BOUNDS):
5138 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5139 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5140 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5141 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5142 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5143 Now static.
5144 (debug_method_add): Use va_list and vsprintf rather than relying
5145 on undefined behavior with wrong number of arguments.
5146 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5147 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5148 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5149 since we're not interested in debugging glyphs with old libraries.
5150 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5151 GCC 4.6.0's static checking.
5152
0766b489
PE
51532011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5154
31fd4b32
PE
5155 Integer overflow and signedness fixes (Bug#8873).
5156 A few related buffer overrun fixes, too.
5157
b79e8648
PE
5158 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5159
0766b489
PE
5160 * dispextern.h (struct face.stipple):
5161 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5162 (x_bitmap_mask, x_allocate_bitmap_record)
5163 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5164 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5165 (x_create_bitmap_from_xpm_data):
5166 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5167 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5168 (.bitmaps_last):
5169 * xfaces.c (load_pixmap):
5170 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5171 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5172 (.bitmaps_last, struct x_output.icon_bitmap):
5173 Use ptrdiff_t, not int, for bitmap indexes.
5174 (x_allocate_bitmap_record): Check for size overflow.
5175 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5176
b081724f
PE
5177 Use ptrdiff_t, not int, for overlay counts.
5178 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5179 * editfns.c (overlays_around, get_pos_property):
5180 * textprop.c (get_char_property_and_overlay):
5181 * xdisp.c (next_overlay_change, note_mouse_highlight):
5182 * xfaces.c (face_at_buffer_position):
21514da7
PE
5183 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5184 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5185 (Fnext_overlay_change, Fprevious_overlay_change)
5186 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 5187 Use ptrdiff_t, not int, for sizes.
21514da7 5188 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 5189
3de73e5e
PE
5190 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5191
2606c57b
PE
5192 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5193 (x_session_initialize): Do not assume string length fits in int.
5194
aaafe47a
PE
5195 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5196 This is unlikely, but can occur if DPI is outlandish.
5197
2674ddc8 5198 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
5199 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5200
28154962
PE
5201 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5202 * xrdb.c (magic_file_p, search_magic_path):
5203 Omit last arg SUFFIX; it was always 0. All callers changed.
5204 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5205
7de51af5
PE
5206 * xfont.c (xfont_match): Avoid need for strlen.
5207
25ed6cc3
PE
5208 * xfns.c: Don't assume strlen fits in int.
5209 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5210
4eab31dd
PE
5211 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5212 not unsigned long, as we prefer signed integers. All callers changed.
5213 Detect integer overflow in repeat count.
5214 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 5215 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 5216
171e2a58
PE
5217 * termcap.c: Don't assume sizes fit in int and never overflow.
5218 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5219 (gobble_line): Check for size-calculation overflow.
5220
ad39faca 5221 * minibuf.c (Fread_buffer):
6e5bb2dc 5222 * lread.c (intern, intern_c_string):
74ca2eb3
PE
5223 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5224 Don't assume string length fits in int.
5225
52c61c22 5226 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
5227 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5228
b5b8c9e5
PE
5229 * font.c: Don't assume string length fits in int.
5230 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5231 Use ptrdiff_t, not int.
ccd6111c
PE
5232 (font_intern_prop): Don't assume string length fits in int.
5233 Don't assume integer property fits in fixnum.
5234 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 5235
882f0d81 5236 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 5237 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
5238 Reformulate so as not to need the command string.
5239 Invoke gzip -cd rather than gunzip, as it's more portable.
5240 (lock_info_type, lock_file_1, lock_file):
5241 Don't assume pid_t and time_t fit in unsigned long.
5242 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5243 (current_lock_owner): Prefer signed type for sizes.
5244 Use memcpy, not strncpy, where memcpy is what is really wanted.
5245 Don't assume (via atoi) that time_t and pid_t fit in int.
5246 Check for time_t and/or pid_t out of range, e.g., via a network share.
5247 Don't alloca where an auto var works fine.
5248
93f4cf88
PE
5249 * fileio.c: Fix some integer overflow issues.
5250 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5251 Don't assume string length fits in int.
5252 (directory_file_name): Don't assume string length fits in long.
5253 (make_temp_name): Don't assume pid fits in int, or that its print
5254 length is less than 20.
5255
f3e92b69
PE
5256 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5257
1bfdaf10
PE
5258 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5259
35016e9a
PE
5260 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5261
3d1e65a1
PE
5262 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5263 We prefer signed integers, even for size calculations.
5264
0b963a93
PE
5265 * emacs.c: Don't assume string length fits in 'int'.
5266 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5267 (main): Don't invoke strlen when not needed.
5268
573f4b54
PE
5269 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5270 (XD_DEBUG_MESSAGE): Don't waste a byte.
5271
989f33ba
PE
5272 * callproc.c (getenv_internal_1, getenv_internal)
5273 (Fgetenv_internal):
965d34eb
PE
5274 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5275
e4d29b33
PE
5276 * lread.c (invalid_syntax): Omit length argument.
5277 All uses changed. This doesn't fix a bug, but it simplifies the
5278 code away from its former Hollerith-constant appearance, and it's
5279 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 5280 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 5281
eb49b136
PE
5282 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5283 This didn't break anything, but it didn't help either.
5284 It's confusing to put a bogus integer in a place where the actual
5285 value does not matter.
9f62aeb1 5286 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 5287 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 5288
15375a22
PE
5289 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5290 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5291 implementation.
b61cc01c
PE
5292 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5293 We prefer signed types, and the value cannot exceed the EMACS_INT
5294 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
5295 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5296 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5297 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 5298
53b2623d
PE
5299 * indent.c (sane_tab_width): New function.
5300 (current_column, scan_for_column, Findent_to, position_indentation)
5301 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 5302 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 5303
51cab52b 5304 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 5305
f2ed8a70
PE
5306 * lisp.h (lint_assume): New macro.
5307 * composite.c (composition_gstring_put_cache):
5308 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5309
abe80cc6
PE
5310 * editfns.c, insdel.c:
5311 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5312
b02c740e
PE
5313 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5314
ebc96716
PE
5315 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5316
b4e50fa0 5317 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5318 Use much-faster test for byte-length change.
311d5d7c 5319 Don't assume string byte-length fits in 'int'.
a4cf38e4 5320 Check that character arg fits in 'int'.
85461888 5321 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5322
c0c1ee9f
PE
5323 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5324
a498d7f4
PE
5325 * fns.c (concat): Catch string overflow earlier.
5326 Do not rely on integer wraparound.
5327
51cab52b
PE
5328 * dispextern.h (struct it.overlay_strings_charpos)
5329 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5330 * xdisp.c (forward_to_next_line_start)
5331 (back_to_previous_visible_line_start)
5332 (reseat_at_next_visible_line_start, next_element_from_buffer):
5333 Don't arbitrarily truncate the value of 'selective' to int.
5334
76031fad
PE
5335 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5336
5eb55db9
PE
5337 * composite.c: Don't truncate sizes to 'int'.
5338 (composition_gstring_p, composition_reseat_it)
5339 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5340 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5341 not EMACS_UINT, for indexes.
5eb55db9 5342
0703a717
PE
5343 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5344
d6202519
PE
5345 * buffer.c: Include <verify.h>.
5346 (struct sortvec.priority, struct sortstr.priority):
8961a454 5347 Now EMACS_INT, not int.
c20998a7 5348 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5349 (struct sortstr.size, record_overlay_string)
5350 (struct sortstrlist.size, struct sortlist.used):
5351 Don't truncate size to int.
5352 (record_overlay_string): Check for size-calculation overflow.
d6202519 5353 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5354
d5a19415
JM
53552011-06-22 Jim Meyering <meyering@redhat.com>
5356
029529ac 5357 Don't leak an XBM-image-sized buffer
d5a19415
JM
5358 * image.c (xbm_load): Free the image buffer after using it.
5359
a9041e6c
PE
53602011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5361
5362 Port to Sun C.
5363 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5364 that Sun C diagnosed.
5365 * fns.c (secure_hash): Fix pointer signedness issue.
5366 * intervals.c (static_offset_intervals): New function.
5367 (offset_intervals): Use it.
5368
7f3f739f
LL
53692011-06-21 Leo Liu <sdl.web@gmail.com>
5370
5371 * deps.mk (fns.o):
5372 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5373 sha512.h.
5374
5375 * fns.c (secure_hash): Rename from crypto_hash_function and change
5376 the first arg to accept symbols.
5b66d427 5377 (Fsecure_hash): New primitive.
7f3f739f
LL
5378 (syms_of_fns): New symbols.
5379
76147d94
DD
53802011-06-20 Deniz Dogan <deniz@dogan.se>
5381
5382 * process.c (Fset_process_buffer): Clarify return value in
5383 docstring.
5384
7d7d0045
CY
53852011-06-18 Chong Yidong <cyd@stupidchicken.com>
5386
5387 * dispnew.c (add_window_display_history): Use BVAR.
5388
5389 * xdisp.c (debug_method_add): Use BVAR.
5390 (check_window_end, dump_glyph_matrix, dump_glyph)
5391 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5392
5393 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5394 Likewise.
5395
5396 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5397 check till after the cache is created in init_frame_faces.
5398
ff2bc410
SM
53992011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5400
5401 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5402
28177add
PE
54032011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5404
dd3482fe
PE
5405 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5406 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5407 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5408
393d71f3 5409 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5410 * fileio.c (Finsert_file_contents):
5411 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5412 Remove the old (too-loose) buffer overflow checks.
5413 They weren't needed, since make_gap checks for buffer overflow.
5414 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5415 The old code merely checked for Emacs fixnum overflow, and relied
5416 on undefined (wraparound) behavior. The new code avoids undefined
5417 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5418
2e6813b0 5419 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5420 Tune. Don't use wider integers than needed. Don't use alloca.
5421 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5422
599a9e4f
PE
5423 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5424
99561444
PE
5425 * insdel.c, lisp.h (buffer_overflow): New function.
5426 (insert_from_buffer_1, replace_range, replace_range_2):
5427 * insdel.c (make_gap_larger):
5428 * editfns.c (Finsert_char):
5429 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5430
28177add
PE
5431 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5432
e69dafad
PE
54332011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5434
4baa020d 5435 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5436
b1c46f02
PE
5437 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5438 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5439
e69dafad
PE
5440 * fileio.c: Don't assume EMACS_INT fits in off_t.
5441 (emacs_lseek): New static function.
5442 (Finsert_file_contents, Fwrite_region): Use it.
5443 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5444
566684ea
PE
5445 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5446
e6966cd6
PE
5447 * fns.c: Don't overflow int when computing a list length.
5448 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5449 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5450 truncation on 64-bit hosts. Check for QUIT every
5451 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5452 faster and is responsive enough.
5453 (Flength): Report an error instead of overflowing an integer.
5454 (Fsafe_length): Return a float if the value is not representable
5455 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5456 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5457 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5458
dd0b0efb
PE
5459 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5460 (header_size, word_size): New constants.
5461 (allocate_vectorlike): Don't check size overflow here.
5462 (allocate_vector): Check it here instead, since this is the only
5463 caller of allocate_vectorlike that could cause overflow.
5464 Check that the new vector's length is representable as a fixnum.
5465
86fe5cfe
PE
5466 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5467 The previous code was bogus. For example, next_almost_prime (32)
5468 returned 39, which is undesirable as it is a multiple of 3; and
5469 next_almost_prime (24) returned 25, which is a multiple of 5 so
5470 why was the code bothering to check for multiples of 7?
5471
80e88859
PE
5472 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5473
4a2f0ad6
PE
5474 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5475
f66c7cf8
PE
5476 Variadic C functions now count arguments with ptrdiff_t.
5477 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5478 Back then I didn't know that the Emacs coding style prefers signed int.
5479 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5480 were being counted with int, which may truncate counts on 64-bit
5481 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5482 * lisp.h (struct Lisp_Subr.function.aMANY)
5483 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5484 Arg counts are now ptrdiff_t, not size_t.
5485 All variadic functions and their callers changed accordingly.
5486 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5487 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5488 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5489 * callint.c (Fcall_interactively): Check arg count for overflow,
5490 to avoid potential buffer overrun. Use signed char, not 'int',
5491 for 'varies' array, so that we needn't bother to check its size
5492 calculation for overflow.
5493 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5494 * eval.c (apply_lambda):
5495 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5496 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5497 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5498
a1759b76
PE
5499 * callint.c (Fcall_interactively): Don't use index var as event count.
5500
d96be9fc
PE
5501 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5502 * mem-limits.h (SIZE): Remove; no longer used.
5503
a690a978 5504 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5505
578c21e6
PE
5506 Remove unnecessary casts.
5507 * xterm.c (x_term_init):
5508 * xfns.c (x_set_border_pixel):
5509 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5510 These aren't needed now that we assume ANSI C.
5511
96f53c6c
PE
5512 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5513 It's more likely to cause problems (due to unsigned overflow)
5514 than to cure them.
5515
83c77d31
PE
5516 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5517
ee2079f1
PE
5518 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5519
6da65536
PE
5520 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5521
7147c4a4
PE
5522 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5523
193e32d9
PE
5524 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5525
e5533da6
PE
5526 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5527
9910e595
PE
5528 GLYPH_CODE_FACE returns EMACS_INT, not int.
5529 * dispextern.h (merge_faces):
5530 * xfaces.c (merge_faces):
01103c44
PE
5531 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5532 Don't assume EMACS_INT fits in int.
9910e595 5533
2638320e
PE
5534 * character.h (CHAR_VALID_P): Remove unused parameter.
5535 * fontset.c, lisp.h, xdisp.c: All uses changed.
5536
045eb8d9
PE
5537 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5538
c1f134b5
PE
5539 * fns.c (concat): Minor tuning based on overflow analysis.
5540 This doesn't fix any bugs. Use int to hold character, instead
5541 of constantly refetching from Emacs object. Use XFASTINT, not
5542 XINT, for value known to be a character. Don't bother comparing
5543 a single byte to 0400, as it's always less.
5544
395fcb93 5545 * floatfns.c (Fexpt):
327eeec8
PE
5546 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5547
abbd3d23
PE
5548 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5549 for characters.
5550
684a03ef
PE
5551 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5552
0fed43f3
PE
5553 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5554 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5555 incorrectly succeed when S was a string, because 4294967386 was
5556 truncated before it was used.
5557
8fd02eb7
PE
5558 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5559 Otherwise, an out-of-range integer could cause undefined behavior
5560 on a 64-bit host.
5561
f8c86b69
PE
5562 * composite.c: Use int, not EMACS_INT, for characters.
5563 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5564 EMACS_INT, for values that are known to be in character range.
5565 This doesn't fix any bugs but is the usual style inside Emacs and
5566 may generate better code on 32-bit machines.
5567
34206dd2
PE
5568 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5569 This is for reasons similar to the recent CHAR_STRING fix.
5570 * charset.c (Fencode_char): Check that character arg is actually
5571 a character. Pass an int to ENCODE_CHAR.
5572 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5573 wider than 'int', as a compile-time check to prevent future regressions
5574 in this area.
5575
c5958d4c 5576 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5577
5578 Make sure a 64-bit char is never passed to CHAR_STRING.
5579 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5580 by silently ignoring the top 32 bits, allowing some values
5581 that were far too large to be valid characters.
5582 * character.h: Include <verify.h>.
5583 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5584 arguments are no wider than unsigned, as a compile-time check
5585 to prevent future regressions in this area.
5586 * data.c (Faset):
01103c44 5587 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5588 (Fsubst_char_in_region):
5589 * fns.c (concat):
5590 * xdisp.c (decode_mode_spec_coding):
5591 Adjust to CHAR_STRING's new requirement.
5592 * editfns.c (Finsert_char, Fsubst_char_in_region):
5593 * fns.c (concat): Check that character args are actually
5594 characters. Without this test, these functions did the wrong
5595 thing with wildly out-of-range values on 64-bit hosts.
5596
d37ca623
PE
5597 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5598 These casts should not be needed on 32-bit hosts, either.
5599 * keyboard.c (read_char):
5600 * lread.c (Fload): Remove casts to unsigned.
5601
ea204efb
PE
5602 * lisp.h (UNSIGNED_CMP): New macro.
5603 This fixes comparison bugs on 64-bit hosts.
5604 (ASCII_CHAR_P): Use it.
5605 * casefiddle.c (casify_object):
01103c44 5606 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5607 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5608 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5609 * dispextern.h (FACE_FROM_ID):
5610 * keyboard.c (read_char): Use UNSIGNED_CMP.
5611
41cb286c
PE
5612 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5613 not to EMACS_INT, to avoid GCC warning.
5614
4a1b9832
PE
5615 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5616
55daad71
PE
5617 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5618 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5619 isn't needed on 32-bit machines.
8f95c75c 5620
01103c44
PE
5621 * buffer.c (Fgenerate_new_buffer_name):
5622 Use EMACS_INT for count, not int.
0ceccced 5623 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5624
5625 * data.c (Qcompiled_function): Now static.
5626
c6f072e7
PE
5627 * window.c (window_body_lines): Now static.
5628
20ce5912
PE
5629 * image.c (gif_load): Rename local to avoid shadowing.
5630
9c4c5f81
PE
5631 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5632 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5633 * alloc.c (make_save_value): Integer argument is now of type
5634 ptrdiff_t, not int.
5635 (mark_object): Use ptrdiff_t, not int.
5636 * lisp.h (pD): New macro.
5637 * print.c (print_object): Use it.
5638
c0c5c8ae
PE
5639 * alloc.c: Use EMACS_INT, not int, to count objects.
5640 (total_conses, total_markers, total_symbols, total_vector_size)
5641 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5642 (total_free_floats, total_floats, total_free_intervals)
5643 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5644 Now EMACS_INT, not int. All uses changed.
5645 (Fgarbage_collect): Compute overall total using a double, so that
5646 integer overflow is less likely to be a problem. Check for overflow
5647 when converting back to an integer.
5a25e253
PE
5648 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5649 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5650 These were 'int' variables that could overflow on 64-bit hosts;
5651 they were never used, so remove them instead of repairing them.
211a0b2a 5652 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5653 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5654 Previously, this ceilinged at INT_MAX, but that doesn't work on
5655 64-bit machines.
e46bb31a 5656 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5657
c78baabf 5658 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5659 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5660 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5661 when a (possibly-narrower) signed value would do just as well.
5662 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5663
c9d624c6
PE
5664 * alloc.c: Catch some string size overflows that we were missing.
5665 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5666 for convenience in STRING_BYTES_MAX.
5667 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5668 The definition here is exact; the one in lisp.h was approximate.
5669 (allocate_string_data): Check for string overflow. This catches
5670 some instances we weren't catching before. Also, it catches
5671 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5672 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5673 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5674
c9d624c6
PE
5675 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5676 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5677 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5678
353032ce
PE
5679 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5680
2bccce07
PE
5681 * alloc.c (Fmake_string): Check for out-of-range init.
5682
0ac30604
SM
56832011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5684
5685 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5686
c195f2de
JD
56872011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5688
5689 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5690 xg_get_default_scrollbar_width.
5691
5692 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5693 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5694 (style_changed_cb): Call update_theme_scrollbar_width and call
5695 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5696 all frames (Bug#8505).
5697 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5698 Call gtk_window_set_resizable if HAVE_GTK3.
5699 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5700 and height if HAVE_GTK3 (Bug#8505).
5701 (scroll_bar_width_for_theme): New variable.
5702 (update_theme_scrollbar_width): New function.
5703 (xg_get_default_scrollbar_width): Move code to
5704 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5705 (xg_initialize): Call update_theme_scrollbar_width.
5706
5707 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5708
5709 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5710
e10ac9f1
MR
57112011-06-12 Martin Rudalics <rudalics@gmx.at>
5712
5713 * frame.c (make_frame): Call other_buffer_safely instead of
5714 other_buffer.
5715
5716 * window.c (temp_output_buffer_show): Call display_buffer with
5717 second argument Vtemp_buffer_show_specifiers and reset latter
5718 immediately after the call.
5719 (Vtemp_buffer_show_specifiers): New variable.
5720 (auto_window_vscroll_p, next_screen_context_lines)
5721 (Vscroll_preserve_screen_position): Remove leading asterisks from
5722 doc-strings.
5723
2d3c217e 57242011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5725
7b7f97e8 5726 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5727 * buffer.c (Qclone_number): Remove for now, as it's unused.
5728 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5729 (record_buffer): Remove unused local.
5730 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5731 (set_frame_buffer_list): Remove; unused.
5732 * frame.h (other_visible_frames): Remove decl.
5733 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5734 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5735 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5736 if HAVE_GPM.
5737 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5738 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5739 Define only if HAVE_GPM.
5740 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5741 (update_hints_inhibit): Remove; never set. All uses removed.
5742 * widgetprv.h (emacsFrameClassRec): Remove decl.
5743 * window.c (delete_deletable_window): Now returns void, since it
5744 wasn't returning anything.
5745 (compare_window_configurations): Remove unused locals.
5746 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5747 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5748 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5749 the same widths as pointers. This follows up on the 2011-05-06 patch.
5750 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5751 * xterm.h: Likewise.
5752 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5753
1384b89e
JB
57542011-06-12 Juanma Barranquero <lekktu@gmail.com>
5755
5756 * makefile.w32-in: Update dependencies.
5757 (LISP_H): Add lib/intprops.h.
5758
1100a63c
CY
57592011-06-11 Chong Yidong <cyd@stupidchicken.com>
5760
5761 * image.c (gif_load): Add animation frame delay to the metadata.
5762 (syms_of_image): Use DEFSYM. New symbol `delay'.
5763
6198ccd0
MR
57642011-06-11 Martin Rudalics <rudalics@gmx.at>
5765
5766 * window.c (delete_deletable_window): Re-add.
5767 (Fset_window_configuration): Rewrite to handle dead buffers and
5768 consequently deletable windows.
5769 (window_tree, Fwindow_tree): Remove. Supply functionality in
5770 window.el.
5771 (compare_window_configurations): Simplify code.
5772
b6e3633c
AS
57732011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5774
1ab0dee5
AS
5775 * image.c (imagemagick_load_image): Fix type mismatch.
5776 (Fimagemagick_types): Likewise.
5777
b6e3633c
AS
5778 * window.h (replace_buffer_in_windows): Declare.
5779
9397e56f
MR
57802011-06-11 Martin Rudalics <rudalics@gmx.at>
5781
5782 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5783 Qclone_number. Remove external declaration of Qdelete_window.
5784 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5785 code.
640c8776
SM
5786 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5787 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5788 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5789 buffer list implementation.
5790 (other_buffer_safely): New function.
5791 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5792 calls to replace_buffer_in_windows and
5793 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5794 if allowed.
5795 (record_buffer): Inhibit quitting and rewrite using quittable
5796 functions. Run Qbuffer_list_update_hook if allowed.
5797 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5798 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5799 Move switch-to-buffer to window.el.
9397e56f
MR
5800 (bury-buffer): Move to window.el.
5801 (Vbuffer_list_update_hook): New variable.
5802
5803 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5804 section.
5805
5806 * window.h (resize_frame_windows): Move up in code.
5807 (Fwindow_frame): Remove EXFUN.
5808 (replace_buffer_in_all_windows): Remove prototype.
5809 (replace_buffer_in_windows_safely): Add prototype.
5810
5811 * window.c: Declare Qdelete_window static again. Move down
5812 declaration of select_count.
5813 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5814 (Fother_window): Move to window.el.
5815 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5816 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5817 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5818 window.el.
5819 (replace_buffer_in_windows): Implement by calling
5820 Qreplace_buffer_in_windows.
5821 (replace_buffer_in_all_windows): Remove with some functionality
5822 moved into replace_buffer_in_windows_safely.
5823 (replace_buffer_in_windows_safely): New function.
5824 (select_window_norecord, select_frame_norecord): Move in front
5825 of run_window_configuration_change_hook. Remove now obsolete
5826 declarations.
640c8776
SM
5827 (Fset_window_buffer): Rewrite doc-string.
5828 Call Qrecord_window_buffer.
9397e56f
MR
5829 (keys_of_window): Move binding for other-window to window.el.
5830
b50691aa
CY
58312011-06-11 Chong Yidong <cyd@stupidchicken.com>
5832
5833 * dispextern.h (struct image): Replace data member, whose int_val
5834 and ptr_val fields were not used by anything, with a single
5835 lisp_val object.
5836
5837 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5838 (gif_clear_image, gif_load, imagemagick_load_image)
5839 (gs_clear_image, gs_load): Callers changed.
5840
3f754b86
PE
58412011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5842
cca69397
PE
5843 * buffer.h: Include <time.h>, for time_t.
5844 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5845
109e28d0
PE
5846 Fix minor problems found by static checking.
5847
60737f02
PE
5848 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5849
4b66faf3
PE
5850 Make identifiers static if they are not used in other modules.
5851 * data.c (Qcompiled_function, Qframe, Qvector):
5852 * image.c (QimageMagick, Qsvg):
5853 * minibuf.c (Qmetadata):
5854 * window.c (resize_window_check, resize_root_window): Now static.
5855 * window.h (resize_window_check, resize_root_window): Remove decls.
5856
109e28d0
PE
5857 * window.c (window_deletion_count, delete_deletable_window):
5858 Remove; unused.
46a4ce9e
PE
5859 (window_body_lines): Now static.
5860 (Fdelete_other_windows_internal): Mark vars as initialized.
5861 Make sure 'resize_failed' is initialized.
5862 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5863 (resize_window_apply): Remove unused local.
5864 * window.h (delete_deletable_window): Remove decl.
5865
109e28d0 5866 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5867 (imagemagick_load_image): Fix pointer signedness problem by changing
5868 last arg from unsigned char * to char *. All uses changed.
5869 Also, fix a local for similar reasons.
5870 Remove unused locals. Remove locals to avoid shadowing.
5871 (fn_rsvg_handle_free): Remove; unused.
5872 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5873 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5874
3f754b86
PE
5875 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5876
2547adb1
CY
58772011-06-10 Chong Yidong <cyd@stupidchicken.com>
5878
5879 * image.c (gif_load): Fix omitted cast error introduced by
5880 2011-06-06 change.
5881
2c8e37d4
MR
58822011-06-10 Martin Rudalics <rudalics@gmx.at>
5883
5884 * window.h (resize_proportionally, orig_total_lines)
5885 (orig_top_line): Remove from window structure.
5886 (set_window_height, set_window_width, change_window_heights)
5887 (Fdelete_window): Remove prototypes.
5888 (resize_frame_windows): Remove duplicate declaration.
5889
440a42e3
EZ
58902011-06-10 Eli Zaretskii <eliz@gnu.org>
5891
5892 * window.h (resize_frame_windows, resize_window_check)
5893 (delete_deletable_window, resize_root_window)
5894 (resize_frame_windows): Declare prototypes.
5895
5896 * window.c (resize_window_apply): Make definition be "static" to
5897 match the prototype.
5898
562dd5e9
MR
58992011-06-10 Martin Rudalics <rudalics@gmx.at>
5900
5901 * window.c: Remove declarations of Qwindow_size_fixed,
5902 window_min_size_1, window_min_size_2, window_min_size,
5903 size_window, window_fixed_size_p, enlarge_window, delete_window.
5904 Remove static from declaration of Qdelete_window, it's
5905 temporarily needed by Fbury_buffer.
5906 (replace_window): Don't assign orig_top_line and
5907 orig_total_lines.
5908 (Fdelete_window, delete_window): Remove. Window deletion is
5909 handled by window.el.
640c8776
SM
5910 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5911 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5912 (Fdelete_other_windows): Remove. Deleting other windows is
5913 handled by window.el.
5914 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5915 handled in window.el.
5916 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5917 Window minimum sizes are handled in window.el.
5918 (shrink_windows, size_window, set_window_height)
5919 (set_window_width, change_window_heights, window_height)
5920 (window_width, CURBEG, CURSIZE, enlarge_window)
5921 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5922 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5923 handled in window.el.
5924 (make_dummy_parent): Rename to make_parent_window and give it a
5925 second argument horflag.
5926 (make_window): Don't set resize_proportionally any more.
5927 (Fsplit_window): Remove. Windows are split in window.el.
5928 (save_restore_action, save_restore_orig_size)
5929 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5930 Resize mini windows in window.el.
5931 (grow_mini_window, shrink_mini_window): Implement by calling
5932 Qresize_root_window_vertically, resize_window_check and
5933 resize_window_apply.
640c8776
SM
5934 (saved_window, Fset_window_configuration, save_window_save):
5935 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5936 resize_proportionally.
5937 (window_min_height, window_min_width): Move to window.el.
5938 (keys_of_window): Move bindings for delete-other-windows,
5939 split-window, delete-window and enlarge-window to window.el.
5940
5941 * buffer.c: Temporarily extern Qdelete_window.
5942 (Fbury_buffer): Temporarily call Qdelete_window instead of
5943 Fdelete_window (Fbury_buffer will move to window.el soon).
5944
5945 * frame.c (set_menu_bar_lines_1): Remove code handling
5946 orig_top_line and orig_total_lines.
5947
5948 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5949 set_window_height but set heights directly.
5950 (change_frame_size_1): Use resize_frame_windows.
5951
5952 * xdisp.c (init_xdisp): Don't use set_window_height but set
5953 heights directly.
5954
640c8776
SM
5955 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5956 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5957 run_window_configuration_change_hook.
5958
5959 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5960 instead of change_window_heights and run
5961 run_window_configuration_change_hook.
5962
1a13852e
MR
59632011-06-09 Martin Rudalics <rudalics@gmx.at>
5964
5965 * window.c (replace_window): Rename second argument REPLACEMENT to
5966 NEW. New third argument SETFLAG. Rewrite.
5967 (delete_window, make_dummy_parent): Call replace_window with
5968 third argument 1.
5969 (window_list_1): Move down in code.
5970 (run_window_configuration_change_hook): Move set_buffer part
5971 before select_frame_norecord part in order to unwind correctly.
5972 Rename count1 to count.
5973 (recombine_windows, delete_deletable_window, resize_root_window)
5974 (Fdelete_other_windows_internal)
5975 (Frun_window_configuration_change_hook, make_parent_window)
5976 (resize_window_check, resize_window_apply, Fresize_window_apply)
5977 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5978 (Fdelete_window_internal, Fresize_mini_window_internal):
5979 New functions.
1a13852e
MR
5980 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5981
f3d1777e
MR
59822011-06-08 Martin Rudalics <rudalics@gmx.at>
5983
496e208e
MR
5984 * window.h (window): Add some new members to window structure -
5985 normal_lines, normal_cols, new_total, new_normal, clone_number,
5986 splits, nest, prev_buffers, next_buffers.
5987 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5988 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5989
f3d1777e
MR
5990 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5991 Remove.
496e208e
MR
5992 (make_dummy_parent): Set new members of windows structure.
5993 (make_window): Move down in code. Handle new members of window
5994 structure.
5995 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5996 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5997 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5998 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5999 (Fset_window_next_buffers, Fset_window_clone_number):
6000 New functions.
496e208e
MR
6001 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6002 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6003 Doc-string fixes.
6004 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6005 Argument WINDOW can be now internal window too.
6006 (Fwindow_use_time): Move up in code.
6007 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6008 Rewrite doc-string.
6009 (Fset_window_configuration, saved_window)
6010 (Fcurrent_window_configuration, save_window_save): Handle new
6011 members of window structure.
b9e809c2
MR
6012 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6013 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6014 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6015 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6016 Qget_mru_window, Qresize_root_window,
6017 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6018 Qauto_buffer_name; staticpro them.
f3d1777e 6019
abde8f8c
MR
60202011-06-07 Martin Rudalics <rudalics@gmx.at>
6021
6022 * window.c (Fwindow_total_size, Fwindow_left_column)
6023 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6024 (Fwindow_list_1): New functions.
6025 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
6026 (Fwindow_width, Fscroll_left, Fscroll_right):
6027 Use window_body_cols instead of window_box_text_cols.
6028 (delete_window, Fset_window_configuration):
6029 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
6030 (delete_all_subwindows): Take a window as argument and not a
6031 structure. Rewrite.
190b47e6
MR
6032 (window_loop): Remove handling of GET_LRU_WINDOW and
6033 GET_LARGEST_WINDOW.
6034 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
6035
6036 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
6037 window_box_text_cols. delete_all_subwindows now takes a
6038 Lisp_Object as argument.
abde8f8c 6039
640c8776
SM
6040 * indent.c (compute_motion, Fcompute_motion):
6041 Use window_body_cols instead of window_box_text_cols.
abde8f8c 6042
fa8a67e6
MR
6043 * frame.c (delete_frame): Call delete_all_subwindows with root
6044 window as argument.
6045
a54e3482
DC
60462011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6047
6048 * fns.c (Fputhash): Document return value.
6049
60002bf5
CY
60502011-06-06 Chong Yidong <cyd@stupidchicken.com>
6051
6052 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6053
0c671da6 60542011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 6055
b862a52a 6056 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 6057
be44ca6c
PE
6058 Check for overflow when converting integer to cons and back.
6059 * charset.c (Fdefine_charset_internal, Fdecode_char):
6060 Use cons_to_unsigned to catch overflow.
6061 (Fencode_char): Use INTEGER_TO_CONS.
6062 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6063 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6064 * data.c (long_to_cons, cons_to_long): Remove.
6065 (cons_to_unsigned, cons_to_signed): New functions.
6066 These signal an error for invalid or out-of-range values.
6067 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6068 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6069 * font.c (Ffont_variation_glyphs):
6070 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6071 * lisp.h: Include <intprops.h>.
6072 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6073 (cons_to_signed, cons_to_unsigned): New decls.
6074 (long_to_cons, cons_to_long): Remove decls.
6075 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6076 (Fprimitive_undo): Use CONS_TO_INTEGER.
6077 * xfns.c (Fx_window_property): Likewise.
6078 * xselect.c: Include <limits.h>.
6079 (x_own_selection, selection_data_to_lisp_data):
6080 Use INTEGER_TO_CONS.
6081 (x_handle_selection_request, x_handle_selection_clear)
6082 (x_get_foreign_selection, Fx_disown_selection_internal)
6083 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6084 (lisp_data_to_selection_data): Use cons_to_unsigned.
6085 (x_fill_property_data): Use cons_to_signed.
6086 Report values out of range.
6087
d1f3d2af
PE
6088 Check for buffer and string overflow more precisely.
6089 * buffer.h (BUF_BYTES_MAX): New macro.
6090 * lisp.h (STRING_BYTES_MAX): New macro.
6091 * alloc.c (Fmake_string):
6092 * character.c (string_escape_byte8):
6093 * coding.c (coding_alloc_by_realloc):
6094 * doprnt.c (doprnt):
6095 * editfns.c (Fformat):
6096 * eval.c (verror):
6097 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6098 since they may not be the same number.
6099 * editfns.c (Finsert_char):
6100 * fileio.c (Finsert_file_contents):
6101 Likewise for BUF_BYTES_MAX.
6102
dd52fcea
PE
6103 * image.c: Use ptrdiff_t, not int, for sizes.
6104 (slurp_file): Switch from int to ptrdiff_t.
6105 All uses changed.
6106 (slurp_file): Check that file size fits in both size_t (for
6107 malloc) and ptrdiff_t (for sanity and safety).
6108
7f9bbdbb
PE
6109 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6110 if b->modtime has its maximal value.
6111
dfe18f82
PE
6112 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6113
84acfcf0
PE
6114 Don't assume time_t can fit into int.
6115 * buffer.h (struct buffer.modtime): Now time_t, not int.
6116 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6117 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6118
ccd9a01a
PE
6119 Minor fixes for signed vs unsigned integers.
6120 * character.h (MAYBE_UNIFY_CHAR):
6121 * charset.c (maybe_unify_char):
6122 * keyboard.c (read_char, reorder_modifiers):
6123 XINT -> XFASTINT, since the integer must be nonnegative.
6124 * ftfont.c (ftfont_spec_pattern):
6125 * keymap.c (access_keymap, silly_event_symbol_error):
6126 XUINT -> XFASTINT, since the integer must be nonnegative.
6127 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6128 since it makes no difference and we prefer signed.
6129 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6130 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6131 nonnegative.
6132
d6d100dd
SM
61332011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6134
6135 * window.h (Fwindow_frame): Declare.
6136
2b6148e4
PE
61372011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6138
6139 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6140 (SPARE_MEMORY): Always define.
6141 (LARGE_REQUEST): Remove.
6142 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6143
f230ecc9
MR
61442011-06-06 Martin Rudalics <rudalics@gmx.at>
6145
727e958e
MR
6146 * lisp.h: Move EXFUNS for Fframe_root_window,
6147 Fframe_first_window and Fset_frame_selected_window to window.h.
6148
6149 * window.h: Move EXFUNS for Fframe_root_window,
6150 Fframe_first_window and Fset_frame_selected_window here from
6151 lisp.h.
6152
6153 * frame.c (Fwindow_frame, Fframe_first_window)
6154 (Fframe_root_window, Fframe_selected_window)
6155 (Fset_frame_selected_window): Move to window.c.
6156 (Factive_minibuffer_window): Move to minibuf.c.
6157 (Fother_visible_frames_p): New function.
6158
6159 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6160
f230ecc9
MR
6161 * window.c (decode_window, decode_any_window): Move up in code.
6162 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6163 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
6164 (Fwindow_buffer): Move up and rewrite doc-string.
6165 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6166 (Fwindow_prev): New functions.
727e958e
MR
6167 (Fwindow_frame): Move here from frame.c. Accept any window as
6168 argument.
6169 (Fframe_root_window, Fframe_first_window)
6170 (Fframe_selected_window): Move here from frame.c. Accept frame
6171 or arbitrary window as argument. Update doc-strings.
6172 (Fminibuffer_window): Move up in code.
6173 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
6174 (Fset_frame_selected_window): Move here from frame.c.
6175 Marginal rewrite.
727e958e
MR
6176 (Fselected_window, select_window, Fselect_window): Move up in
6177 code. Minor doc-string fixes.
f230ecc9 6178
4d09bcf6
PE
61792011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6180
6181 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6182 Do not assume that spare memory exists; that assumption is valid
6183 only if SYSTEM_MALLOC.
6184 (LARGE_REQUEST): New macro, so that the issue of large requests
6185 is separated from the issue of spare memory.
6186
810928a2
AS
61872011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6188
172418ad
AS
6189 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6190 format. (Bug#8806)
6191
43f862f7
AS
6192 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6193
810928a2
AS
6194 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6195 before statements.
6196
a059fe24
JD
61972011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6198
6199 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6200
6201 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6202
6203 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6204 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6205
989bf368
JB
62062011-06-05 Juanma Barranquero <lekktu@gmail.com>
6207
6208 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6209
4b80f674
CY
62102011-06-04 Chong Yidong <cyd@stupidchicken.com>
6211
6212 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6213 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
6214 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6215 New error handlers.
4b80f674
CY
6216 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6217 Obey Vx_select_enable_clipboard_manager. Catch errors in
6218 x_clipboard_manager_save (Bug#8779).
6219 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 6220 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 6221
99a33b77 62222011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
6223
6224 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6225
99a33b77 62262011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
6227
6228 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6229 in the current matrix if keep_current_p is non-zero.
6230
8264569d
EZ
62312011-06-04 Eli Zaretskii <eliz@gnu.org>
6232
6233 * bidi.c (bidi_level_of_next_char): Fix last change.
6234
57f97249
EZ
62352011-06-03 Eli Zaretskii <eliz@gnu.org>
6236
fec2107c 6237 Support bidi reordering of text covered by display properties.
57f97249 6238
fec2107c
EZ
6239 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6240 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6241 (bidi_cache_search, bidi_cache_iterator_state)
6242 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
6243 (bidi_level_of_next_char, bidi_move_to_visually_next):
6244 Support character positions inside a run of characters covered by a
fec2107c
EZ
6245 display string.
6246 (bidi_paragraph_init, bidi_resolve_explicit_1)
6247 (bidi_level_of_next_char): Call bidi_fetch_char and
6248 bidi_fetch_char_advance instead of FETCH_CHAR and
6249 FETCH_CHAR_ADVANCE.
6250 (bidi_init_it): Initialize new members.
6251 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6252 definitions.
6253 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6254 instead of using explicit *_CHAR codes.
d6d100dd
SM
6255 (bidi_resolve_explicit, bidi_resolve_weak):
6256 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
6257 bidirectional text is supported only in multibyte buffers.
6258 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6259 it to initialize the frame_window_p member of struct bidi_it.
6260 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6261 (bidi_resolve_explicit, bidi_resolve_weak)
6262 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6263 bidi_it->nchars is non-positive.
6264 (bidi_level_of_next_char): Don't try to lookup the cache for the
6265 next/previous character if nothing is cached there yet, or if we
6266 were just reseat()'ed to a new position.
c40e2fb2 6267
0e14fe90
EZ
6268 * xdisp.c (set_cursor_from_row): Set start and stop points
6269 according to the row's direction when priming the loop that looks
6270 for the glyph on which to display cursor.
6271 (single_display_spec_intangible_p): Function deleted.
6272 (display_prop_intangible_p): Reimplement to call
6273 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
6274 Accept 3 additional arguments needed by handle_display_spec.
6275 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
6276 values: lists, `(when COND...)' forms, etc.
6277 (single_display_spec_string_p): Support property values that are
6278 lists with the argument STRING its top-level element.
6279 (display_prop_string_p): Fix the condition for processing a
6280 property that is a list to be consistent with handle_display_spec.
fec2107c 6281 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
6282 last portion of handle_display_prop.
6283 (compute_display_string_pos): Accept additional argument
6284 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6285 value of a `display' property is a "replacing spec".
6286 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6287 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6288 the display property, but just return a value indicating whether
6289 the display property will replace the characters it covers.
6290 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6291 frame_window_p members of struct bidi_it.
d6d100dd
SM
6292 (compute_display_string_pos, compute_display_string_end):
6293 New functions.
fec2107c
EZ
6294 (push_it): Accept second argument POSITION, where pop_it should
6295 jump to continue iteration.
6296 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 6297
fec2107c
EZ
6298 * keyboard.c (adjust_point_for_property): Adjust the call to
6299 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
6300
6301 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
6302 (bidi_init_it): Update prototypes.
6303 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
6304 (compute_display_string_pos, compute_display_string_end):
6305 Declare prototypes.
fec2107c
EZ
6306 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6307 EMACS_INT.
fc6f18ce 6308
40087514 63092011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6310
57f53182
PE
6311 Malloc failure behavior now depends on size of allocation.
6312 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6313 * lisp.h: Change signatures accordingly.
6314 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6315 All callers changed. (Bug#8762)
6316
6317 * gnutls.c: Use Emacs's memory allocators.
6318 Without this change, the gnutls library would invoke malloc etc.
6319 directly, which causes problems on non-SYNC_INPUT hosts, and which
6320 runs afoul of improving memory_full behavior. (Bug#8761)
6321 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6322 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6323 xfree instead of the default malloc, realloc, free.
6324 (Fgnutls_boot): No need to check for memory allocation failure,
6325 since xmalloc does that for us.
6326
ac32cd99 6327 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6328 * category.c (hash_get_category_set):
6329 * ccl.c (ccl_driver):
6330 * charset.c (Fdefine_charset_internal):
6331 * charset.h (struct charset.hash_index):
6332 * composite.c (get_composition_id, gstring_lookup_cache)
6333 (composition_gstring_put_cache):
6334 * composite.h (struct composition.hash_index):
6335 * dispextern.h (struct image.hash):
6336 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6337 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6338 (hashfn_equal, hashfn_user_defined, make_hash_table)
6339 (maybe_resize_hash_table, hash_lookup, hash_put)
6340 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6341 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6342 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6343 * image.c (make_image, search_image_cache, lookup_image)
6344 (xpm_put_color_table_h):
6345 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6346 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6347 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6348 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6349 * alloc.c (allocate_vectorlike):
6350 Check for overflow in vector size calculations.
6351 * ccl.c (ccl_driver):
6352 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6353 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6354 need to be updated by these changes.
40087514
PE
6355 * fns.c (make_hash_table, maybe_resize_hash_table):
6356 Check for integer overflow with large hash tables.
0de4bb68
PE
6357 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6358 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6359 (SXHASH_REDUCE): New macro.
6360 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6361 Use it instead of discarding useful hash info with large hash values.
6362 (sxhash_float): New function.
6363 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6364 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6365 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6366 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6367 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6368 Adjust signatures to match updated version of code.
6369 (consing_since_gc): Now EMACS_INT, since a single hash table can
6370 use more than INT_MAX bytes.
6371
698d32e2
DN
63722011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6373
6374 Make it possible to build with GCC-4.6+ -O2 -flto.
6375
6376 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6377
fd6fa53f
SM
63782011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6379
6380 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6381 Call minibuffer-inactive-mode.
6382
864db017
JB
63832011-05-31 Juanma Barranquero <lekktu@gmail.com>
6384
6385 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6386 Update dependencies.
6387
2ad0baf4
DN
63882011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6389
6390 * data.c (init_data): Remove code for UTS, this system is not
6391 supported anymore.
6392
4fcc2638
DN
63932011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6394
6395 Don't force ./temacs to start in terminal mode.
6396
6397 * frame.c (make_initial_frame): Initialize faces in all cases, not
6398 only when CANNOT_DUMP is defined.
6399 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6400
c56e0fd5
DN
64012011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6402
6403 * dispnew.c (add_window_display_history): Use const for the string
6404 pointer. Remove declaration, not needed.
6405
333d54da 64062011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6407
55d4c1b2 6408 Use 'inline', not 'INLINE'.
333d54da 6409 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6410 * alloc.c, fontset.c (INLINE): Remove.
6411 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6412 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6413 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6414 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6415 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6416
738db178
DN
64172011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6418
6419 Make it possible to run ./temacs.
6420
6421 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6422 syms_of_callproc does the same thing. Remove test for
6423 "initialized", do it in the caller.
6424 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6425
620c53a6
SM
64262011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6427
6428 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6429 (read_minibuf): Use get_minibuffer.
6430 (syms_of_minibuf): Use DEFSYM.
6431 (Qmetadata): New var.
6432 * data.c (Qbuffer): Don't make it static.
6433 (syms_of_data): Use DEFSYM.
6434
e003a292
PE
64352011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6436
6437 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6438 (CCL_CODE_MIN): New macro.
6439
ed008a6d
PE
64402011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6441
3687c2ef
PE
6442 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6443
ed008a6d
PE
6444 * eval.c (Qdebug): Now static.
6445 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6446 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6447 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6448
d66c4c7c
CY
64492011-05-29 Chong Yidong <cyd@stupidchicken.com>
6450
6451 * image.c: Various fixes to ImageMagick code comments.
6452 (Fimagemagick_types): Doc fix.
6453
5fbc2025
PE
64542011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6455
0196f88a
PE
6456 Minor fixes prompted by GCC 4.6.0 warnings.
6457
6458 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6459
5fbc2025
PE
6460 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6461 (x_clipboard_manager_save_all): Move extern decl to ...
6462 * xterm.h: ... here, so that it can be checked for consistency.
6463
1dd3c2d9
CY
64642011-05-29 Chong Yidong <cyd@stupidchicken.com>
6465
6466 * xselect.c (x_clipboard_manager_save_frame)
6467 (x_clipboard_manager_save_all): New functions.
6468 (Fx_clipboard_manager_save): Lisp function deleted.
6469
6470 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6471 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6472
6473 * xterm.h: Update prototype.
6474
5ba6571d
WX
64752011-05-28 William Xu <william.xwl@gmail.com>
6476
6477 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6478 exiting (Bug#8239).
6479
3eaff834
JM
64802011-05-28 Jim Meyering <meyering@redhat.com>
6481
e1900994 6482 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6483 * fns.c (to_uchar): Define.
6484 (crypto_hash_function): Use it to convert some newly-signed
6485 variables to unsigned, to avoid sign-extension bugs. For example,
6486 without this change, (md5 "truc") would evaluate to
6487 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6488 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6489 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6490
0f6990a7
PE
64912011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6492
6493 Integer overflow fixes.
c8a9ca5a 6494
08686060
PE
6495 * dbusbind.c: Serial number integer overflow fixes.
6496 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6497 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6498 to hold a serial number that is too large for a fixnum.
6499 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6500 Check for serial numbers out of range. Decode any serial number
59568bf0 6501 that was so large that it became a float. (Bug#8722)
08686060 6502
2d1fc3c7
PE
6503 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6504 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6505 Use XFASTINT rather than XUINT when numbers are nonnegative.
6506 (xd_append_arg, Fdbus_method_return_internal):
6507 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6508 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6509 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6510 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6511 (Bug#8722)
2d1fc3c7 6512
c8a9ca5a
PE
6513 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6514
519e1d69
PE
6515 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6516
6df6ae42 6517 ccl: Add integer overflow checks.
30569699
PE
6518 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6519 (IN_INT_RANGE): New macros.
6520 (ccl_driver): Use them to check for integer overflow when
6521 decoding a CCL program. Many of the new checks are whether XINT (x)
6522 fits in int; it doesn't always, on 64-bit hosts. The new version
6523 doesn't catch all possible integer overflows, but it's an
847044ea 6524 improvement. (Bug#8719)
30569699 6525
c11285dc
PE
6526 * alloc.c (make_event_array): Use XINT, not XUINT.
6527 There's no need for unsigned here.
6528
fdccd48e
PE
6529 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6530 This follows up to the 2011-05-06 change that substituted uintptr_t
6531 for EMACS_INT. This case wasn't caught back then.
6532
37910ab2
PE
6533 Rework Fformat to avoid integer overflow issues.
6534 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6535 now (part of C89). Include <verify.h>.
6536 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6537 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6538 (Fformat): Avoid the prepass trying to compute sizes; it was only
6539 approximate and thus did not catch overflow reliably. Instead, walk
6540 through the format just once, formatting and computing sizes as we go,
6541 checking for integer overflow at every step, and allocating a larger
6542 buffer as needed. Keep track separately whether the format is
6543 multibyte. Keep only the most-recently calculated precision, rather
6544 than them all. Record whether each argument has been converted to
6545 string. Use EMACS_INT, not int, for byte and char and arg counts.
6546 Support field widths and precisions larger than INT_MAX. Avoid
6547 sprintf's undefined behavior with conversion specifications such as %#d
6548 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6549 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6550 formatting out-of-range floating point numbers with int
9173deec 6551 formats. (Bug#8668)
37910ab2 6552
2e6578fb
PE
6553 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6554
0ae6bdee
PE
6555 * data.c: Avoid integer truncation in expressions involving floats.
6556 * data.c: Include <intprops.h>.
6557 (arith_driver): When there's an integer overflow in an expression
6558 involving floating point, convert the integers to floating point
6559 so that the resulting value does not suffer from catastrophic
6560 integer truncation. For example, on a 64-bit host (* 4
6561 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6562 Do not rely on undefined behavior after integer overflow.
6563
de883a70
PE
6564 merge count_size_as_multibyte, parse_str_to_multibyte
6565 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6566 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6567 Check for integer overflow.
6568 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6569 since it's now a duplicate of the other. This is more of
6570 a character than a buffer op, so better that it's in character.c.
6571 * fns.c, print.c: Adjust to above changes.
6572
2ff916cb
PE
65732011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6574
6575 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6576
f1b54466
PE
65772011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6578
fb1ac845
PE
6579 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6580 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6581 (x_clipboard_manager_save): Now static.
6582 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6583
f1b54466
PE
6584 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6585 (crypto_hash_function): Now static.
6586 Fix pointer signedness problems. Avoid unnecessary initializations.
6587
a9f737ee
CY
65882011-05-27 Chong Yidong <cyd@stupidchicken.com>
6589
6590 * termhooks.h (Vselection_alist): Make it terminal-local.
6591
6592 * terminal.c (create_terminal): Initialize it.
6593
6594 * xselect.c: Support for clipboard managers.
6595 (Vselection_alist): Move to termhooks.h as terminal-local var.
6596 (LOCAL_SELECTION): New macro.
6597 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6598 (symbol_to_x_atom): Remove gratuitous arg.
6599 (x_handle_selection_request, lisp_data_to_selection_data)
6600 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6601 (x_own_selection, x_get_local_selection, x_convert_selection):
6602 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6603 (some_frame_on_display): Delete unused function.
6604 (Fx_own_selection_internal, Fx_get_selection_internal)
6605 (Fx_disown_selection_internal, Fx_selection_owner_p)
6606 (Fx_selection_exists_p): New optional frame arg.
6607 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6608 (x_handle_selection_clear): Don't treat other terminals with the
6609 same keyboard specially. Use the terminal-local Vselection_alist.
6610 (x_clear_frame_selections): Use Frun_hook_with_args.
6611
6612 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6613
6614 * xterm.h: Add support for those atoms.
6615
e067f0c1
CY
66162011-05-26 Chong Yidong <cyd@stupidchicken.com>
6617
6618 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6619 (converted_selections, conversion_fail_tag): New global variables.
6620 (x_selection_request_lisp_error): Free the above.
6621 (x_get_local_selection): Remove unnecessary code.
6622 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6623 of converted selections stored in converted_selections.
6624 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6625 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6626 (x_convert_selection): New function.
6627 (x_handle_selection_event): Simplify.
6628 (x_get_foreign_selection): Don't ignore incoming requests while
6629 waiting for an answer; this will fail when we implement
6630 SAVE_TARGETS, and seems unnecessary anyway.
6631 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6632 (Vx_sent_selection_functions): Doc fix.
6633
0f4aebc0
LL
66342011-05-26 Leo Liu <sdl.web@gmail.com>
6635
6636 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6637
e61124cd
YM
66382011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6639
6640 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6641
6642 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6643 for fringe update if it has periodic bitmap.
ac389d0c 6644 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6645 and fringe_bitmap_periodic_p.
6646
6647 * fringe.c (get_fringe_bitmap_data): New function.
6648 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6649 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6650 row. Mark glyph row for fringe update if periodicity changed.
6651
6652 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6653 for fringe update unless it has periodic bitmap.
6654
f16d9837
KH
66552011-05-25 Kenichi Handa <handa@m17n.org>
6656
6657 * xdisp.c (get_next_display_element): Set correct it->face_id for
6658 a static composition.
6659
e1b90ef6
LL
66602011-05-24 Leo Liu <sdl.web@gmail.com>
6661
6662 * deps.mk (fns.o):
6663 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6664
6665 * fns.c (crypto_hash_function, Fsha1): New function.
6666 (Fmd5): Use crypto_hash_function.
6667 (syms_of_fns): Add Ssha1.
6668
7400048f
PE
66692011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6670
6671 * gnutls.c: Remove unused macros.
6672 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6673 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6674 Remove macros that are defined and never used.
6675 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6676
abb71cf4
CY
66772011-05-22 Chong Yidong <cyd@stupidchicken.com>
6678
6679 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6680 (Fx_get_selection_internal): Minor cleanup.
6681 (Fx_own_selection_internal): Rename arguments for consistency with
6682 select.el.
6683
6307db39
PE
66842011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6685
6686 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6687
f3d4e0a4
CY
66882011-05-22 Chong Yidong <cyd@stupidchicken.com>
6689
6690 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6691
4d8ade89
YM
66922011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6693
6694 * dispnew.c (scrolling_window): Don't exclude the case that the
6695 last enabled row in the desired matrix touches the bottom boundary.
6696
32078c8d
GM
66972011-05-21 Glenn Morris <rgm@gnu.org>
6698
6699 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6700 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6701 and add some more files.
32078c8d 6702
7285dc67
EZ
67032011-05-20 Eli Zaretskii <eliz@gnu.org>
6704
6705 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6706 report_file_error introduced by the change from 2011-05-07.
6707
89d1bd22
PE
67082011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6709
6710 * systime.h (Time): Define only if emacs is defined.
6711 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6712 where the include path doesn't have X11/X.h by default. See
6713 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6714
cd394be1 67152011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6716
6717 * composite.c (find_automatic_composition): Fix previous change.
6718
b9704ad9
GM
67192011-05-20 Glenn Morris <rgm@gnu.org>
6720
6721 * lisp.mk: New file, split from Makefile.in.
6722 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6723 (shortlisp): Remove.
6724 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6725
4a720484
GM
67262011-05-19 Glenn Morris <rgm@gnu.org>
6727
6728 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6729 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6730 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6731 (lisp): Set the order to that of loadup.el.
6732 (shortlisp): Make it a copy of $lisp.
6733 (SOME_MACHINE_LISP): Remove.
6734 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6735 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6736
a28d4396
KH
67372011-05-18 Kenichi Handa <handa@m17n.org>
6738
6739 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6740 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6741 (find_automatic_composition): Mostly rewrite for efficiency.
6742
a2b1fa8e
JB
67432011-05-18 Juanma Barranquero <lekktu@gmail.com>
6744
6745 * makefile.w32-in: Update dependencies.
6746
8e1f5610
CS
67472011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6748
6749 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6750 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6751
7025ee00 67522011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6753
cdfa6eab
PE
6754 Fix some integer overflow issues, such as string length overflow.
6755
06d6db33
PE
6756 * insdel.c (count_size_as_multibyte): Check for string overflow.
6757
2b4560a8
PE
6758 * character.c (lisp_string_width): Check for string overflow.
6759 Use EMACS_INT, not int, for string indexes and lengths; in
6760 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6761 the resulting string length overflows an EMACS_INT; instead,
6762 report a string overflow if no precision given. When checking for
6763 precision exhaustion, use a check that cannot possibly have
6764 integer overflow. (Bug#8675)
6765 * character.h (lisp_string_width): Adjust to new signature.
6766
cb93f9be
PE
6767 * alloc.c (string_overflow): New function.
6768 (Fmake_string): Use it. This doesn't change behavior, but saves
6769 a few bytes and will simplify future changes.
6770 * character.c (string_escape_byte8): Likewise.
6771 * lisp.h (string_overflow): New decl.
6772
1a1f3366
PE
6773 Fixups, following up to the user-interface timestamp change.
6774 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6775 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6776 * msdos.c (mouse_get_pos): Likewise.
6777 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6778 * w32gui.h (Time): Define by including "systime.h" rather than by
6779 declaring it ourselves. (Bug#8664)
6780
d4e3e4d3
PE
6781 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6782 * image.c (clear_image_cache): Likewise.
6783
f6a24d19
PE
6784 * term.c (term_mouse_position): Don't assume time_t wraparound.
6785
08dc5ae6
PE
6786 Be more systematic about user-interface timestamps.
6787 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6788 and sometimes 'EMACS_UINT', to represent these timestamps.
6789 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6790 This makes the code easier to follow, and makes it easier to catch
6791 integer overflow bugs such as Bug#8664.
6792 * frame.c (Fmouse_position, Fmouse_pixel_position):
6793 Use Time, not unsigned long, for user-interface timestamps.
6794 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6795 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6796 * keyboard.h (last_event_timestamp): Likewise.
6797 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6798 * menu.h (xmenu_show): Likewise.
6799 * term.c (term_mouse_position): Likewise.
6800 * termhooks.h (struct input_event.timestamp): Likewise.
6801 (struct terminal.mouse_position_hook): Likewise.
6802 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6803 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6804 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6805 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6806 what it was before.
6807 * menu.h, termhooks.h: Include "systime.h", for Time.
6808
8e55734a
PE
6809 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6810 Don't assume that the difference between two unsigned long values
6811 can fit into an integer. At this point, we know button_down_time
6812 <= event->timestamp, so the difference must be nonnegative, so
6813 there's no need to cast the result if double-click-time is
6814 nonnegative, as it should be; check that it's nonnegative, just in
6815 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6816 apart (about 25 days). (Bug#8664)
8e55734a 6817
841f1b75 6818 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6819 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6820
3e26f69c
PE
6821 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6822 that always fit in int. Use a sentinel instead of a counter, to
6823 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6824 * frame.h (struct frame): Use int for menu_bar_items_used
6825 instead of EMACS_INT, since it always fits in int.
3e26f69c 6826
5cc152c0
PE
6827 * menu.c (grow_menu_items): Check for int overflow.
6828
d89eb65e
PE
6829 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6830
5235bd3e
PE
6831 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6832 Before, the code was not consistent. These values cannot exceed
6833 2**31 - 1 so there's no need to make them unsigned.
6834 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6835 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6836 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6837 as modifiers.
6838 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6839
bc827e23
PE
6840 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6841 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6842 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6843 presumably because the widths might not match.
6844
78eb494e
PE
6845 * window.c (size_window): Avoid needless test at loop start.
6846
04f2d78b
CB
68472011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6848
6849 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6850
d2fc7e3d 68512011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6852
6853 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6854
d2fc7e3d 68552011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6856
6857 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6858 `width' to `bar_area_x' and `bar_area_width', respectively.
6859 (x_scroll_run): Take account of fringe background extension.
6860
04f2d78b
CB
6861 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6862 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6863 `bar_area_width', respectively.
6864 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6865 background extension.
6866
79b70037
GM
68672011-05-10 Jim Meyering <meyering@redhat.com>
6868
6869 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6870
2f142cc5
JB
68712011-05-10 Juanma Barranquero <lekktu@gmail.com>
6872
6873 * image.c (Finit_image_library): Return t for built-in image types,
6874 like pbm and xbm. (Bug#8640)
6875
57679c86
AS
68762011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6877
6878 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6879
888c9e86
EZ
68802011-05-07 Eli Zaretskii <eliz@gnu.org>
6881
b0512a1d
EZ
6882 * w32console.c (Fset_screen_color): Doc fix.
6883 (Fget_screen_color): New function.
6884 (syms_of_ntterm): Defsubr it.
6885
7285dc67
EZ
6886 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6887 unlink the temporary file if Fcall_process didn't create it in the
6888 first place.
6889 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6890 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6891 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6892 cue to call_process_cleanup not to close that handle.
6893
4d3fcc8e
BK
68942011-05-07 Ben Key <bkey76@gmail.com>
6895
6896 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6897 one of two shell specific rules, either bootstrap-temacs-CMD or
6898 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6899 to the previous implementation of the bootstrap-temacs rule.
6900 The bootstrap-temacs-CMD rule is similar to the previous
6901 implementation of the bootstrap-temacs rule except that it
6902 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6903 variable.
6904
6905 These changes, along with some changes to nt/configure.bat,
6906 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6907 earlier fix to add support for --cflags and --ldflags options
6908 that include quotes so that it works whether make uses cmd or
6909 sh as the shell.
6910
b4289b64
MA
69112011-05-06 Michael Albinus <michael.albinus@gmx.de>
6912
6913 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6914 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6915 is a constant.
6916 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6917 a string. Handle both cases.
6918 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6919 (Fdbus_register_method): Use Qinvalid_function.
6920
af4c0e28
JB
69212011-05-06 Juanma Barranquero <lekktu@gmail.com>
6922
6923 * makefile.w32-in: Update dependencies.
6924 (LISP_H): Add inttypes.h and stdin.h.
6925 (PROCESS_H): Add unistd.h.
6926
c51453d9
EZ
69272011-05-06 Eli Zaretskii <eliz@gnu.org>
6928
6929 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6930 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6931
8ff0ac3c 69322011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6933
4c4b566b
PE
6934 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6935
aab2b9b5
PE
6936 * term.c (vfatal): Remove stray call to va_end.
6937 It's not needed and the C Standard doesn't allow it here anyway.
6938
c378da0b
PE
6939 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6940 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6941
288b08c7
PE
6942 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6943 bytes.
6944
e3601888
PE
6945 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6946
db6c0e74
PE
6947 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6948
dd5963ea
PE
6949 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6950
88c9450f
PE
6951 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6952
2f9442b8
PE
6953 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6954
c032b5f8
PE
6955 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6956 * charset.c (Fdefine_charset_internal): Don't initialize
6957 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6958 32-bit int (Bug#8600).
a108c10b
PE
6959
6960 * lread.c (read_integer): Be more consistent with string-to-number.
6961 Use string_to_number to do the actual conversion; this avoids
6962 rounding errors and fixes some other screwups. Without this fix,
6963 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6964 (digit_to_number): Move earlier, for benefit of read_integer.
6965 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6966 not a digit in any supported base. (Bug#8602)
a108c10b 6967
ad5f9eea
PE
6968 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6969
aec1708a
PE
6970 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6971 to match comment at start of function. This also removes a
6972 GCC warning about overflow in a 32+64-bit port.
6973
47be4ab5
PE
6974 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6975
371cac43
PE
6976 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6977 Reported by Stefan Monnier in
6978 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6979 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6980 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6981
d01a7826
PE
6982 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6983 (EMACS_UINTPTR): Likewise, with uintptr_t.
6984
7fd47d5c
PE
6985 * lisp.h: Prefer 64-bit EMACS_INT if available.
6986 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6987 on 32-bit hosts that have 64-bit int, so that they can access
6988 large files.
122b0c86
PE
6989 However, temporarily disable this change unless the temporary
6990 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6991
8727937b
PE
6992 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6993
8ac068ac
PE
6994 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6995 This removes an assumption that EMACS_INT and long are the same
6996 width as pointers. The assumption is true for Emacs porting targets
6997 now, but we want to make other targets possible.
6998 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6999 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7000 In the rest of the code, change types of integers that hold casted
7001 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7002 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7003 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7004 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7005 No need to cast type when ORing.
7006 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7007 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7008 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7009 assume EMACS_INT is the same width as char *.
7010 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7011 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7012 Remove no-longer-needed casts.
7013 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7014 (xg_tool_bar_help_callback, xg_make_tool_item):
7015 Use EMACS_INTPTR to hold an integer
7016 that will be cast to void *; this can avoid a GCC warning
7017 if EMACS_INT is not the same width as void *.
7018 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7019 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7020 (current_message_1, set_message_1):
7021 Use a local to convert to proper width without a cast.
7022 * xmenu.c (dialog_selection_callback): Likewise.
7023
ede49d71
PE
7024 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7025 Also, don't assume VALBITS / RAND_BITS is less than 5,
7026 and don't rely on undefined behavior when shifting a 1 left into
7027 the sign bit.
7028 * lisp.h (get_random): Change signature to match.
7029
2f30ecd0
PE
7030 * lread.c (hash_string): Use size_t, not int, for hash computation.
7031 Normally we prefer signed values; but hashing is special, because
7032 it's better to use unsigned division on hash table sizes so that
7033 the remainder is nonnegative. Also, size_t is the natural width
7034 for hashing into memory. The previous code used 'int', which doesn't
7035 retain enough info to hash well into very large tables.
7036 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7037
2a866e7b
PE
7038 * dbusbind.c: Don't possibly lose pointer info when converting.
7039 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7040 Use XPNTR rather than XHASH, so that the high-order bits of
7041 the pointer aren't lost when converting through void *.
7042
51639eac
PE
7043 * eval.c (Fautoload): Don't double-shift a pointer.
7044
92394119
PE
7045 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7046
dbdb9a7c
JB
70472011-05-06 Juanma Barranquero <lekktu@gmail.com>
7048
7049 * gnutls.c (DEF_GNUTLS_FN):
7050 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7051
db7a0b4f
AS
70522011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7053
7054 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7055 marker. (Bug#8610)
7056
cd394be1 70572011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
7058
7059 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7060 New version that can reserve upto 2GB of heap space.
7061
f7ff1b0f 70622011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
7063
7064 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7065
639c109b
TZ
70662011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7067
7068 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7069 `gnutls_certificate_set_x509_key_file'.
7070
d2127135
JB
70712011-05-05 Juanma Barranquero <lekktu@gmail.com>
7072
7073 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7074 Update dependencies.
7075
e968f4f3
JB
70762011-05-04 Juanma Barranquero <lekktu@gmail.com>
7077
7078 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7079 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7080 Remove unused parameter `fildes'.
7081 * process.c (read_process_output, send_process): Don't pass it.
7082
84d358f0
JB
70832011-05-04 Juanma Barranquero <lekktu@gmail.com>
7084
7085 Fix previous change: the library cache is defined in w32.c.
7086 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7087 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7088
0898ca10
JB
70892011-05-04 Juanma Barranquero <lekktu@gmail.com>
7090
7091 Implement dynamic loading of GnuTLS on Windows.
7092
7093 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7094 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7095 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7096 Declare.
7097
7098 * gnutls.c (Qgnutls_dll): Define.
7099 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7100 (gnutls_*): Declare function pointers.
7101 (init_gnutls_functions): New function to initialize function pointers.
7102 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7103 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7104 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7105 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7106 (emacs_gnutls_write, emacs_gnutls_read)
7107 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7108 (Fgnutls_available_p): New function.
7109 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7110 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7111 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7112
7113 * image.c: Include w32.h.
7114 (Vimage_type_cache): Delete.
7115 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7116 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7117 (w32_delayed_load): Move to w32.c.
7118
7119 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7120
7121 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7122 (w32_delayed_load): Move from image.c. When loading a library, record
7123 its filename in the :loaded-from property of the library id.
7124 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7125 Initialize and staticpro them.
7126 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7127
7128 * process.c: Include lisp.h before w32.h, not after.
7129 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7130 instead of gnutls_record_check_pending.
7131
7132 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7133
ff4de4aa
TZ
71342011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7135
7136 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7137 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7138 as passed in.
7139
abe95abb
JD
71402011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7141
7142 * xterm.c (x_set_frame_alpha): Do not set property on anything
7143 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7144
e16e55d4
JB
71452011-05-02 Juanma Barranquero <lekktu@gmail.com>
7146
7147 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7148
bafcf6a5
JB
71492011-05-02 Juanma Barranquero <lekktu@gmail.com>
7150
7151 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7152 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7153 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7154 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7155 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7156 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7157 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7158 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7159 (Qgnutls_bootprop_callbacks_verify): Make static.
7160
e7a6747f
AS
71612011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7162
19ed11ba
AS
7163 * callproc.c: Indentation fixup.
7164
e7a6747f 7165 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
7166 (wait_for_termination, interruptible_wait_for_termination):
7167 Move after wait_for_termination_1.
e7a6747f 7168
1ef14cb4
LMI
71692011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7170
7171 * sysdep.c (interruptible_wait_for_termination): New function
7172 which is like wait_for_termination, but allows keyboard
7173 interruptions.
7174
7175 * callproc.c (Fcall_process): Add (:file "file") as an option for
7176 the STDOUT buffer.
7177 (Fcall_process_region): Ditto.
7178
330d880c
EZ
71792011-04-30 Eli Zaretskii <eliz@gnu.org>
7180
8db90b73
EZ
7181 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7182 rather than `XVECTOR (FOO)->size'.
7183
330d880c
EZ
7184 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7185 inttypes.h, as a gnulib replacement is used if it not available in
7186 system headers.
7187
15cbd324
EZ
71882011-04-21 Eli Zaretskii <eliz@gnu.org>
7189
7190 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7191 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7192 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7193
7194 * coding.c (coding_alloc_by_realloc): Error out if destination
7195 will grow beyond MOST_POSITIVE_FIXNUM.
7196 (decode_coding_emacs_mule): Abort if there isn't enough place in
7197 charbuf for the composition carryover bytes. Reserve an extra
7198 space for up to 2 characters produced in a loop.
7199 (decode_coding_iso_2022): Abort if there isn't enough place in
7200 charbuf for the composition carryover bytes.
7201
72022011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 7203
ae940cca
EZ
7204 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7205 aborting when %lld or %lll format is passed.
7206 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7207 %llo or %llx format is passed. (Bug#8545)
7208
03ab8921
EZ
7209 * window.c (window_scroll_line_based): Use a marker instead of
7210 simple variables to record original value of point. (Bug#7952)
7211
afda1437
EZ
7212 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7213 produced by %s or %c overflows available buffer space. (Bug#8545)
7214
f76dee0c
PE
72152011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7216
7217 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 7218 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 7219
fdc5744d
JB
72202011-04-28 Juanma Barranquero <lekktu@gmail.com>
7221
7222 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7223
638f053a
JB
72242011-04-28 Juanma Barranquero <lekktu@gmail.com>
7225
7226 * keyboard.c (Qdelayed_warnings_hook): Define.
7227 (command_loop_1): Run `delayed-warnings-hook'
7228 if Vdelayed_warnings_list is non-nil.
7229 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7230 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7231
d178f871
EZ
72322011-04-28 Eli Zaretskii <eliz@gnu.org>
7233
7234 * doprnt.c (doprnt): Don't return value smaller than the buffer
7235 size if the message was truncated. (Bug#8545).
7236
b124fd93
JB
72372011-04-28 Juanma Barranquero <lekktu@gmail.com>
7238
7239 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7240 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7241
e810457d
PE
72422011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7243
7244 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7245
ea51cceb
JB
72462011-04-27 Juanma Barranquero <lekktu@gmail.com>
7247
7248 * makefile.w32-in: Update dependencies.
7249
94dcfacf
EZ
72502011-04-27 Eli Zaretskii <eliz@gnu.org>
7251
7252 Improve `doprnt' and its usage. (Bug#8545)
7253 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7254 `format_end'. Remove support for %l as a conversion specifier.
7255 Don't use xrealloc. Improve diagnostics when the %l size modifier
7256 is used. Update the commentary.
7257
7258 * eval.c (verror): Simplify calculation of size_t.
7259
7260 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7261 messages.
7262
f61f41d7
PE
72632011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7264
7265 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7266 change.
7267
96fb4434
PE
72682011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7269
7270 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7271 This makes this file independent of the recent pseudovector change.
7272
671875da 72732011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 7274
69e9b5a3
PE
7275 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7276
b5f869a7 7277 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 7278 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 7279 Remove unused local.
c8926152 7280 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 7281
841a1577 7282 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
7283 GCC 4.6.0 optimizes based on type-based alias analysis.
7284 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
7285 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7286 != &v->size, and therefore "v->size = 1; b->size = 2; return
7287 v->size;" must therefore return 1. This assumption is incorrect
7288 for Emacs, since it type-puns struct Lisp_Vector * with many other
7289 types. To fix this problem, this patch adds a new type struct
f904488f 7290 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
7291 and pseudovectors, and helps optimizing compilers not get fooled
7292 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7293 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
7294 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7295 the size member.
eab3844f
PE
7296 (XSETPVECTYPE): Rewrite in terms of new macro.
7297 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7298 This is a bit clearer, and further avoids the possibility of
7299 undesirable aliasing.
7300 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 7301 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
7302 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7303 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
7304 (ASIZE): Now uses header.size rather than size.
7305 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7306 to avoid the hassle of writing XVECTOR (foo)->header.size.
7307 (struct vectorlike_header): New type.
eab3844f
PE
7308 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7309 object, to help avoid aliasing.
7310 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7311 (SUBRP): Likewise, since Lisp_Subr is a special case.
7312 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7313 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7314 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7315 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7316 changed to be "header.size" and "header.next".
7317 * buffer.h (struct buffer): Likewise.
7318 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7319 * frame.h (struct frame): Likewise.
7320 * process.h (struct Lisp_Process): Likewise.
7321 * termhooks.h (struct terminal): Likewise.
7322 * window.c (struct save_window_data, struct saved_window): Likewise.
7323 * window.h (struct window): Likewise.
7324 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7325 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7326 * buffer.c (init_buffer_once): Likewise.
7327 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7328 special case.
7329 * process.c (Fformat_network_address): Use local var for size,
7330 for brevity.
7331
0df1eac5
PE
7332 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7333
847ab9d1 7334 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7335 * data.c (atof): Remove decl; no longer used or needed.
7336 (digit_to_number): Move to lread.c.
7337 (Fstring_to_number): Use new string_to_number function, to be
7338 consistent with how the Lisp reader treats infinities and NaNs.
7339 Do not assume that floating-point numbers represent EMACS_INT
7340 without losing information; this is not true on most 64-bit hosts.
7341 Avoid double-rounding errors, by insisting on integers when
7342 parsing non-base-10 numbers, as the documentation specifies.
7343 * lisp.h (string_to_number): New decl, replacing ...
7344 (isfloat_string): Remove.
bc0a5c13 7345 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7346 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7347 appears to have been a coding error. Similarly, do not accept
7348 strings like +-1e0 as floating point numbers. Do not report
7349 overflow for integer overflows unless the base is not 10 which
7350 means we have no simple and reliable way to continue.
7351 Break out the floating-point parsing into a new
7352 function string_to_number, so that Fstring_to_number parses
7353 floating point numbers consistently with the Lisp reader.
04f2d78b 7354 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7355 (E_CHAR, EXP_INT): Remove, replacing with ...
7356 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7357 (string_to_number): New function, replacing isfloat_string.
7358 This function checks for valid syntax and produces the resulting
7359 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7360 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7361 so that overflow for non-base-10 numbers is reported only when
7362 there's no portable and simple way to convert to floating point.
452f4150 7363
67769ffc
PE
7364 * textprop.c (set_text_properties_1): Rewrite for clarity,
7365 and to avoid GCC warning about integer overflow.
7366
c20db43f
PE
7367 * intervals.h (struct interval): Use EMACS_INT for members
7368 where EMACS_UINT might cause problems. See
7369 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7370 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7371 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7372 All uses changed.
37aa2f85
PE
7373 (offset_intervals): Tell GCC not to worry about length overflow
7374 when negating a negative length.
c20db43f 7375
2538aa2f
PE
7376 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7377 (overrun_check_free): Likewise.
7378
f2d3008d
PE
7379 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7380 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7381 word size.
7382
ec8df744
PE
7383 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7384 (gnutls_make_error): Rename local to avoid shadowing.
7385 (gnutls_emacs_global_deinit): ifdef out; not used.
7386 (Fgnutls_boot): Use const for pointer to readonly storage.
7387 Comment out unused local. Fix pointer signedness problems.
7388
640ee02d
PE
7389 * lread.c (openp): Don't stuff size_t into an 'int'.
7390 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7391 about possible signed overflow.
7392
6048fb2a
PE
7393 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7394 (GDK_KEY_g): Don't define if already defined.
7395 (xg_prepare_tooltip): Avoid pointer signedness problem.
7396 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7397
fa3c87e1
PE
7398 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7399 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7400
2172544b
PE
7401 * xfns.c (Fx_window_property): Simplify a bit,
7402 to make a bit faster and to avoid GCC 4.6.0 warning.
7403 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7404
9b821a21
PE
7405 * fns.c (internal_equal): Don't assume size_t fits in int.
7406
3c616cfa
PE
7407 * alloc.c (compact_small_strings): Tighten assertion a little.
7408
c2982e87
PE
7409 Replace pEd with more-general pI, and fix some printf arg casts.
7410 * lisp.h (pI): New macro, generalizing old pEd macro to other
7411 conversion specifiers. For example, use "...%"pI"d..." rather
7412 than "...%"pEd"...".
7413 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7414 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7415 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7416 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7417 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7418 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7419 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7420 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7421 64-bit hosts.
7422 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7423 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7424 * print.c (safe_debug_print, print_object): Likewise.
7425 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7426 to int.
6f04d126
PE
7427 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7428 avoiding the 0 flag, which is not portable.
c2982e87
PE
7429 * process.c (Fmake_network_process): Use pI to avoid cast.
7430 * region-cache.c (pp_cache): Likewise.
7431 * xdisp.c (decode_mode_spec): Likewise.
7432 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7433 behavior on 64-bit hosts with printf arg.
6f04d126 7434 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7435 (x_stop_queuing_selection_requests): Likewise.
7436 (x_get_window_property): Don't truncate byte count to an 'int'
7437 when tracing.
0b432f21 7438
5e073ec7
PE
7439 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7440 here, since it parses constructs like leading '-' and spaces,
7441 which are not wanted; and it overflows with large numbers.
7442 Instead, simply match F[0-9]+, which is what is wanted anyway.
7443
36372bf9
PE
7444 * alloc.c: Remove unportable assumptions about struct layout.
7445 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7446 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7447 (allocate_vectorlike, make_pure_vector): Use the new macros,
7448 plus offsetof, to remove unportable assumptions about struct layout.
7449 These assumptions hold on all porting targets that I know of, but
7450 they are not guaranteed, they're easy to remove, and removing them
7451 makes further changes easier.
7452
0b432f21
PE
7453 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7454 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7455 (string_overrun_cookie): Now const. Use initializers that
7456 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7457 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7458 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7459 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7460 multiple of sizeof (EMACS_INT); it need not be, if
7461 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7462 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7463
895009e1
JB
74642011-04-26 Juanma Barranquero <lekktu@gmail.com>
7465
7466 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7467
6a7a1b0b
TZ
74682011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7469
7470 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7471 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7472 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7473
841a1577 74742011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7475
7476 * lisp.h (Qdebug): List symbol.
895009e1 7477 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7478 * keyboard.c (debug-on-event): New variable.
7479 (handle_user_signal): Break into debugger when debug-on-event
7480 matches the current signal symbol.
7481
f2d3ba6f
DN
74822011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7483
7484 * alloc.c (check_sblock, check_string_bytes)
7485 (check_string_free_list): Convert to standard C.
7486
42ce4c63
TZ
74872011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7488
7489 * w32.c (emacs_gnutls_push): Fix typo.
7490
825cd63c
EZ
74912011-04-25 Eli Zaretskii <eliz@gnu.org>
7492
fb11d64d
EZ
7493 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7494 "cast to pointer from integer of different size".
7495
825cd63c
EZ
7496 Improve doprnt and its use in verror. (Bug#8545)
7497 * doprnt.c (doprnt): Document the set of format control sequences
7498 supported by the function. Use SAFE_ALLOCA instead of always
7499 using `alloca'.
7500
7501 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7502 is one byte too soon. Don't use xrealloc; instead xfree and
7503 xmalloc anew.
7504
e061a11b
TZ
75052011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7506
7507 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7508 callbacks stage.
7509
7510 * gnutls.c: Renamed global_initialized to
7511 gnutls_global_initialized. Added internals for the
7512 :verify-hostname-error, :verify-error, and :verify-flags
7513 parameters of `gnutls-boot' and documented those parameters in the
7514 docstring. Start callback support.
9173deec
JB
7515 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7516 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7517 on error. Return error code.
e061a11b
TZ
7518 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7519 (emacs_gnutls_read): Likewise.
7520 (Fgnutls_boot): Return handshake error code.
7521 (emacs_gnutls_handle_error): New function.
7522 (wsaerror_to_errno): Likewise.
7523
7524 * w32.h (emacs_gnutls_pull): Add prototype.
7525 (emacs_gnutls_push): Likewise.
7526
7527 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7528 (emacs_gnutls_push): Likewise.
7529
75302011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7531
7532 * process.c (wait_reading_process_output): Check if GnuTLS
7533 buffered some data internally if no FDs are set for TLS
7534 connections.
7535
7536 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7537 (LIBS): Link to USER_LIBS.
7538 ($(BLD)/gnutls.$(0)): New target.
7539
fa6996bc
EZ
75402011-04-24 Eli Zaretskii <eliz@gnu.org>
7541
eb35682e
EZ
7542 * xdisp.c (handle_single_display_spec): Rename the
7543 display_replaced_before_p argument into display_replaced_p, to
7544 make it consistent with the commentary. Fix typos in the
7545 commentary.
7546
e2ad650c
EZ
7547 * textprop.c (syms_of_textprop): Remove dead code.
7548 (copy_text_properties): Delete obsolete commentary about an
7549 interface that was deleted long ago. Fix typos in the description
7550 of arguments.
7551
1b2de274
EZ
7552 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7553 to changes in oldXMenu/XMenu.h from 2011-04-16.
7554 <menu_help_message, prev_menu_help_message>: Constify.
7555 (IT_menu_make_room): menu->help_text is now `const char **';
7556 adjust.
7557
7558 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7559 to changes in oldXMenu/XMenu.h from 2011-04-16.
7560 (struct XMenu): Declare `help_text' `const char **'.
7561
7562 * xfaces.c <Qunspecified>: Make extern again.
7563
7564 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 7565 required by POSIX.
1b2de274 7566
762b15be
EZ
7567 * doc.c (get_doc_string): Improve the format passed to `error'.
7568
7569 * doprnt.c (doprnt): Improve commentary.
7570
7571 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7572
7573 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7574 them with etags.
7575
f1052e5d
EZ
7576 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7577 changes in globals.h immediately force recompilation.
762b15be
EZ
7578 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7579 $(CURDIR)/s/ms-w32.h.
7580 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7581
fa6996bc
EZ
7582 * character.c (Fchar_direction): Function deleted.
7583 (syms_of_character): Don't defsubr it.
7584 <char-direction-table>: Deleted.
7585
e6c3da20
EZ
75862011-04-23 Eli Zaretskii <eliz@gnu.org>
7587
7588 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7589 * doprnt.c: Include limits.h.
7590 (SIZE_MAX): New macro.
04f2d78b
CB
7591 (doprnt): Return a size_t value. 2nd arg is now size_t.
7592 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7593 Improve overflow protection. Support `l' modifier for integer
7594 conversions. Support %l conversion. Don't assume an EMACS_INT
7595 argument for integer conversions and for %c.
7596
7597 * lisp.h (doprnt): Restore prototype.
7598
7599 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7600 $(SRC)/character.h.
7601
7602 * Makefile.in (base_obj): Add back doprnt.o.
7603
7604 * deps.mk (doprnt.o): Add back prerequisites.
7605 (callint.o): Depend on character.h.
7606
7607 * eval.c (internal_lisp_condition_case): Include the handler
7608 representation in the error message.
7609 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7610 when breaking from the loop.
7611
7612 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7613
7614 * callint.c (Fcall_interactively): When displaying error message
7615 about invalid control letter, pass the character's codepoint, not
7616 a pointer to its multibyte form. Improve display of the character
7617 in octal and display also its hex code.
7618
7619 * character.c (char_string): Use %x to display the (unsigned)
7620 codepoint of an invalid character, to avoid displaying a bogus
7621 negative value.
7622
7623 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7624 `error', not SYMBOL_NAME itself.
7625
7626 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7627 character arguments to `error'.
7628
7629 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7630 to `error' in error message about FINAL_CHAR argument. Make sure
7631 FINAL_CHAR is a character, and use %c when it is passed as
7632 argument to `error'.
7633
4ffd0d6b 76342011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7635
7636 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7637
7638 * w32.c: Include <time.h>.
7639 (sys_localtime): New function.
7640
4ffd0d6b 76412011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7642
7643 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7644
4ffd0d6b 7645 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7646
4ffd0d6b 76472011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7648
4ffd0d6b
GM
7649 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7650 zombies (Bug#8467).
aac0c6e3 7651
04c56954
EZ
76522011-04-19 Eli Zaretskii <eliz@gnu.org>
7653
7654 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7655 gl_state.e_property when gl_state.object is Qt.
7656
7657 * insdel.c (make_gap_larger): Remove limitation of buffer size
7658 to <= INT_MAX.
7659
16a43933
CY
76602011-04-18 Chong Yidong <cyd@stupidchicken.com>
7661
7662 * xdisp.c (lookup_glyphless_char_display)
7663 (produce_glyphless_glyph): Handle cons cell entry in
7664 glyphless-char-display.
7665 (Vglyphless_char_display): Document it.
7666
7667 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7668 glyphless-char-display.
7669
4581706e
CY
76702011-04-17 Chong Yidong <cyd@stupidchicken.com>
7671
7672 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7673
7674 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7675
7676 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7677 definition for no-X builds.
7678
4887c6e2 76792011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7680
fd35b6f9
PE
7681 Static checks with GCC 4.6.0 and non-default toolkits.
7682
5c1ccb01
PE
7683 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7684
006c5daa
PE
7685 * process.c (keyboard_bit_set): Define only if SIGIO.
7686 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7687 (send_process): Repair possible setjmp clobbering.
7688
efc736d3
PE
7689 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7690
4e2fe2e6
PE
7691 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7692
f97334a2
PE
7693 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7694
4e75f29d
PE
7695 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7696 Define only if needed.
7697
90efadd1
PE
7698 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7699 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7700 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7701
3c647824
PE
7702 * dispextern.h (struct redisplay_interface): Rename param
7703 to avoid shadowing.
e264f262 7704 * termhooks.h (struct terminal): Likewise.
761383f4 7705 * xterm.c (xembed_send_message): Likewise.
3c647824 7706
b58c5c4a
PE
7707 * insdel.c (make_gap_smaller): Define only if
7708 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7709
cad59032
PE
7710 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7711 it.
7712
c339dc2e
PE
7713 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7714 so that we aren't warned about unused symbols.
7715
91a3e27b
PE
7716 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7717
399c71d3 7718 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7719
8ffc96f5
PE
7720 * xfns.c (x_real_positions): Mark locals as initialized.
7721
eef9bc79
PE
7722 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7723
098db9dd
PE
7724 * xterm.c: Fix problems found by static analysis with other toolkits.
7725 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7726 (x_dispatch_event): Declare static if USE_GTK, and
7727 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7728 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7729 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7730 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7731 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7732
eb18f6cc
PE
7733 * xmenu.c (menu_help_callback): Pointer type fixes.
7734 Use const pointers when pointing at readonly data. Avoid pointer
7735 signedness clashes.
7736 (FALSE): Remove unused macro.
7737 (update_frame_menubar): Remove unused decl.
7738
1fe72bf8
PE
7739 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7740
60d9e1db
PE
7741 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7742 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7743 (single_menu_item): Rename local to avoid shadowing.
7744
39261c26
PE
7745 * keyboard.c (make_lispy_event): Remove unused local var.
7746
018c5e19
PE
7747 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7748 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7749
63d2b86e
PE
7750 * bitmaps: Change bitmaps from unsigned char back to the X11
7751 compatible char. Avoid the old compiler warnings about
7752 out-of-range initializers by using, for example, '\xab' rather
7753 than 0xab.
7754
aefd87e1
PE
7755 * xgselect.c (xgselect_initialize): Check vs interface
7756 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7757
bf501fb9
PE
7758 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7759
e9829fdf
PE
7760 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7761 to read-only memory.
7762
1086c095
PE
7763 * fns.c (vector): Remove; this old hack is no longer needed.
7764
2baccd04 7765 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7766 Remove unused var.
dde42981 7767 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7768
72391843 7769 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7770
436c16df 7771 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7772 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7773 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7774
92bb796d 7775 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7776 (x_term_init): Remove local to avoid shadowing.
92bb796d 7777
764430a3 7778 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7779
7780 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7781 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7782
d1dfb56c
EZ
77832011-04-16 Eli Zaretskii <eliz@gnu.org>
7784
c4354cb4
EZ
7785 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7786
d1dfb56c
EZ
7787 Fix regex.c, syntax.c and friends for buffers > 2GB.
7788 * syntax.h (struct gl_state_s): Declare character position members
7789 EMACS_INT.
7790
7791 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7792
04f2d78b
CB
7793 * textprop.c (verify_interval_modification, interval_of):
7794 Declare arguments EMACS_INT.
d1dfb56c
EZ
7795
7796 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7797 EMACS_INT.
7798
7799 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7800
7801 * indent.c (Fvertical_motion): Local variable it_start is now
7802 EMACS_INT.
7803
7804 * regex.c (re_match, re_match_2, re_match_2_internal)
7805 (bcmp_translate, regcomp, regexec, print_double_string)
7806 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7807 (re_compile_pattern, re_exec): Declare arguments and local
7808 variables `size_t' and `ssize_t' and return values `regoff_t', as
7809 appropriate.
7810 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7811 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7812 <compile_stack_type>: `size' and `avail' are now `size_t'.
7813
7814 * regex.h <regoff_t>: Use ssize_t, not int.
7815 (re_search, re_search_2, re_match, re_match_2): Arguments that
7816 specify buffer/string position and length are now ssize_t and
7817 size_t. Return type is regoff_t.
7818
613052cd
BK
78192011-04-16 Ben Key <bkey76@gmail.com>
7820
7821 * nsfont.m: Fixed bugs in ns_get_family and
7822 ns_descriptor_to_entity that were caused by using free to
7823 deallocate memory blocks that were allocated by xmalloc (via
7824 xstrdup). This caused Emacs to crash when compiled with
7825 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7826 --enable-checking=xmallocoverrun). xfree is now used to
7827 deallocate these memory blocks.
7828
4170f62f 78292011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7830
71b41406
PE
7831 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7832
9587a89d
PE
7833 emacs_write: Accept and return EMACS_INT for sizes.
7834 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7835 et seq.
7836 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7837 Accept and return EMACS_INT.
7838 (emacs_gnutls_write): Return the number of bytes written on
7839 partial writes.
7840 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7841 (emacs_read, emacs_write): Remove check for negative size, as the
7842 Emacs source code has been audited now.
9587a89d
PE
7843 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7844 (emacs_read, emacs_write): Use it.
273a5f82
PE
7845 * process.c (send_process): Adjust to the new signatures of
7846 emacs_write and emacs_gnutls_write. Do not attempt to store
7847 a byte offset into an 'int'; it might overflow.
9587a89d 7848 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7849
3e047f51
PE
7850 * sound.c: Don't assume sizes fit in 'int'.
7851 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7852 Return EMACS_INT, not int.
3e047f51 7853 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7854 Accept EMACS_INT, not int.
7855 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7856 record read return values.
7857
cc39a9db
BK
78582011-04-15 Ben Key <bkey76@gmail.com>
7859
c9d0ec6d
JB
7860 * keyboard.c (Qundefined): Don't declare static since it is used
7861 in nsfns.m.
7862 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7863 static since they are used in nsfont.m.
cc39a9db 7864
6c60eb9f
SM
78652011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7866
7867 * process.c (Qprocessp): Don't declare static.
7868 * lisp.h (Qprocessp): Declare again.
7869
7990b61a
JB
78702011-04-15 Juanma Barranquero <lekktu@gmail.com>
7871
7872 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7873
5d4cb038
PE
78742011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7875
8bd7b830 7876 Improve C-level modularity by making more things 'static'.
cd64ea1d 7877
e3b27b31
PE
7878 Don't publish debugger-only interfaces to other modules.
7879 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7880 (verify_bytepos, count_markers): Move decls to the only modules
7881 that need them.
7882 * region-cache.h (pp_cache): Likewise.
7883 * window.h (check_all_windows): Likewise.
7884 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7885
5d4cb038
PE
7886 * sysdep.c (croak): Now static, if
7887 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7888 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7889
7890 * alloc.c (refill_memory_reserve): Now static if
7891 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7892 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7893
e87b6180
PE
7894 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7895 Define only if USE_LUCID.
7896
ac64929e
PE
7897 * xrdb.c (x_customization_string, x_rm_string): Now static.
7898
6f37259d
PE
7899 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7900 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7901
1683e3ab
PE
7902 * xdisp.c (draw_row_with_mouse_face): Now static.
7903 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7904
de9c2632
PE
7905 * window.h (check_all_windows): Mark externally visible.
7906
2b96acb7
PE
7907 * window.c (window_deletion_count): Now static.
7908
7909 * undo.c: Make symbols static if they're not exported.
7910 (last_undo_buffer, last_boundary_position, pending_boundary):
7911 Now static.
7912
50436f33
PE
7913 * textprop.c (interval_insert_behind_hooks): Now static.
7914 (interval_insert_in_front_hooks): Likewise.
7915
64520e5c
PE
7916 * term.c: Make symbols static if they're not exported.
7917 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7918 (max_frame_lines, tty_set_terminal_modes):
7919 (tty_reset_terminal_modes, tty_turn_off_highlight):
7920 (get_tty_terminal): Now static.
7921 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7922 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7923 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7924 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7925 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7926
1fa53021
PE
7927 * sysdep.c: Make symbols static if they're not exported.
7928 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7929 Now static.
7930 (sigprocmask_set, full_mask): Remove; unused.
7931 (wait_debugging): Mark as visible.
7932 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7933 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7934
d4b43b22
PE
7935 * syntax.c (syntax_temp): Define only if !__GNUC__.
7936
b7c513d0
PE
7937 * sound.c (current_sound_device, current_sound): Now static.
7938
989b29ad
PE
7939 * search.c (searchbufs, searchbuf_head): Now static.
7940
13a55a78
PE
7941 * scroll.c (scroll_cost): Remove; unused.
7942 * dispextern.h (scroll_cost): Remove decl.
7943
de68a1fc
PE
7944 * region-cache.h (pp_cache): Mark as externally visible.
7945
40ccffa6
PE
7946 * process.c: Make symbols static if they're not exported.
7947 (process_tick, update_tick, create_process, chan_process):
7948 (Vprocess_alist, proc_buffered_char, datagram_access):
7949 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7950 (deactivate_process): Mark defn as static, as well as decl.
7951 * lisp.h (create_process): Remove decl.
7952 * process.h (chan_process, Vprocess_alist): Remove decls.
7953
ad64fc97
PE
7954 * print.c: Make symbols static if they're not exported.
7955 (print_depth, new_backquote_output, being_printed, print_buffer):
7956 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7957 (print_interval, print_number_index, initial_stderr_stream):
7958 Now static.
7959 * lisp.h (Fprinc): Remove decl.
7960 (debug_output_compilation_hack): Mark as externally visible.
7961
adddb265
PE
7962 * sysdep.c (croak): Move decl from here to syssignal.h.
7963 * syssignal.h (croak): Put it here, so the API can be checked when
7964 'croak' is called from dissociate_if_controlling_tty.
7965
1717ede2
PE
7966 * minibuf.c: Make symbols static if they're not exported.
7967 (minibuf_save_list, choose_minibuf_frame): Now static.
7968 * lisp.h (choose_minibuf_frame): Remove decl.
7969
fa5fb2bc
PE
7970 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7971
1e3890d1
PE
7972 * lread.c: Make symbols static if they're not exported.
7973 (read_objects, initial_obarray, oblookup_last_bucket_number):
7974 Now static.
7975 (make_symbol): Remove; unused.
7976 * lisp.h (initial_obarray, make_symbol): Remove decls.
7977
8a1414fa
PE
7978 * keyboard.c: Make symbols static if they're not exported.
7979 (single_kboard, recent_keys_index, total_keys, recent_keys):
7980 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7981 (this_single_command_key_start, echoing, last_auto_save):
7982 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7983 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7984 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7985 (Vlispy_mouse_stem, double_click_count):
7986 Now static.
7987 (force_auto_save_soon): Define only if SIGDANGER.
7988 (ignore_mouse_drag_p): Now static if
7989 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7990 (print_help): Remove; unused.
7991 (stop_character, last_timer_event): Mark as externally visible.
7992 * keyboard.h (ignore_mouse_drag_p): Declare only if
7993 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7994 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7995 * lisp.h (echoing): Remove decl.
7996 (force_auto_save_soon): Declare only if SIGDANGER.
7997 * xdisp.c (redisplay_window): Simplify code, to make it more
7998 obvious that ignore_mouse_drag_p is not accessed if !defined
7999 USE_GTK && !defined HAVE_NS.
8000
93ea6e8f
PE
8001 * intervals.c: Make symbols static if they're not exported.
8002 (merge_properties_sticky, merge_interval_right, delete_interval):
8003 Now static.
8004 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8005
77382fcc
PE
8006 * insdel.c: Make symbols static if they're not exported.
8007 However, leave prepare_to_modify_buffer alone. It's never
8008 called from outside this function, but that appears to be a bug.
8009 (combine_after_change_list, combine_after_change_buffer):
4889fc82 8010 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
8011 (adjust_after_replace_noundo): Remove; unused.
8012 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 8013 (signal_before_change): Remove decls.
77382fcc 8014
9306c32e
PE
8015 * indent.c (val_compute_motion, val_vmotion): Now static.
8016
cd44d2eb
PE
8017 * image.c: Make symbols static if they're not exported.
8018 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8019 if USE_GTK.
8020 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8021 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8022
ad9a7a06
PE
8023 * fringe.c (standard_bitmaps): Now static.
8024 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8025
81626931
PE
8026 * frame.c: Make symbols static if they're not exported.
8027 (x_report_frame_params, make_terminal_frame): Now static.
8028 (get_frame_param): Now static, unless HAVE_NS.
8029 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8030 (x_get_resource_string): Remove; not used.
8031 * frame.h (make_terminal_frame, x_report_frame_params):
8032 (x_get_resource_string); Remove decls.
8033 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8034 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8035
239f9db9
PE
8036 * font.c, fontset.c: Make symbols static if they're not exported.
8037 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8038 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8039 * font.c (font_close_object): Now static.
8040 * font.h (font_close_object): Remove.
8041 * fontset.c (FONTSET_OBJLIST): Remove.
8042 (free_realized_fontset) #if-0 the body, which does nothing.
8043 (face_suitable_for_char_p): #if-0, as it's never called.
8044 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
8045 * xfaces.c (face_at_string_position):
8046 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
8047 since 0 is always ASCII.
8048
dfcf3579
PE
8049 * fns.c (weak_hash_tables): Now static.
8050
5045092b
PE
8051 * fileio.c: Make symbols static if they're not exported.
8052 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8053 (Vwrite_region_annotation_buffers): Now static.
8054
57a96f5c
PE
8055 * eval.c: Make symbols static if they're not exported.
8056 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8057 * lisp.h (backtrace_list): Remove decl.
8058
35f08c38
PE
8059 * emacs.c: Make symbols static if they're not exported.
8060 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8061 (fatal_error_code, fatal_error_signal_hook, standard_args):
8062 Now static.
8063 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8064 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8065 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8066 * lisp.h (fatal_error_signal_hook): Remove decl.
8067 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8068
f44bd759
PE
8069 * editfns.c: Move a (normally-unused) function to its only use.
8070 * editfns.c, lisp.h (get_operating_system_release): Remove.
8071 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8072 worth the hassle of breaking this out.
8073
b532497d
PE
8074 * xterm.c: Make symbols static if they're not exported.
8075 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8076 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8077 (x_destroy_window, x_delete_display):
8078 Now static.
8079 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8080 (x_mouse_leave): Remove; unused.
8081 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8082 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8083 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8084 Remove decls.
8085 (x_mouse_leave): Declare only if WINDOWSNT.
8086 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8087 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8088 USE_X_TOOLKIT.
8089
1675728f
PE
8090 * ftxfont.c: Make symbols static if they're not exported.
8091 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8092 HAVE_FREETYPE.
8093 * font.h (ftxfont_driver): Likewise.
8094
e4cebfca
PE
8095 * xfns.c: Make symbols static if they're not exported.
8096 (x_last_font_name, x_display_info_for_name):
8097 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8098 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8099 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8100 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8101 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8102 (last_show_tip_args): Now static.
8103 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8104 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8105 (x_screen_planes): Remove; unused.
8106 * dispextern.h (x_screen_planes): Remove decl.
8107
5bf46f05
PE
8108 * dispnew.c: Make symbols static if they're not exported.
8109 * dispextern.h (redraw_garbaged_frames, scrolling):
8110 (increment_row_positions): Remove.
8111 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8112 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8113 Now static.
8114 (redraw_garbaged_frames): Remove; unused.
8115
435f4c28
PE
8116 * xfaces.c: Make symbols static if they're not exported.
8117 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8118 Remove decls.
8119 * xterm.h (defined_color): Remove decls.
8120 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8121 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8122 (menu_face_changed_default, defined_color, free_realized_face):
8123 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8124 (ascii_face_of_lisp_face): Remove; unused.
8125
8524aef3
PE
8126 * xdisp.c: Make symbols static if they're not exported.
8127 * dispextern.h (scratch_glyph_row, window_box_edges):
8128 (glyph_to_pixel_coords, set_cursor_from_row):
8129 (get_next_display_element, set_iterator_to_next):
8130 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8131 (show_mouse_face): Remove decls
8132 * frame.h (message_buf_print): Likewise.
8133 * lisp.h (pop_message, set_message, check_point_in_composition):
8134 Likewise.
8135 * xterm.h (set_vertical_scroll_bar): Likewise.
8136 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8137 (message_buf_print, scratch_glyph_row, displayed_buffer):
8138 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8139 (get_next_display_element, show_mouse_face, window_box_edges):
8140 (frame_to_window_pixel_xy, check_point_in_composition):
8141 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8142 (glyph_to_pixel_coords): Remove; unused.
8143
16390cd2
PE
8144 * dired.c (file_name_completion): Now static.
8145
8146 * dbusbind.c (xd_in_read_queued_messages): Now static.
8147
a25f4dfa
PE
8148 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8149 * data.c (circular_list_error): Remove.
8150
14a9c8df
PE
8151 * commands.h (last_point_position, last_point_position_buffer):
8152 (last_point_position_window): Remove decls.
8153 * keyboard.c: Make these variables static.
8154
04f2d78b
CB
8155 * coding.h (coding, code_convert_region, encode_coding_gap):
8156 Remove decls.
74ab6df5
PE
8157 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8158 (iso_code_class, detect_coding, code_convert_region): Now static.
8159 (encode_coding_gap): Remove; unused.
8160
38dfbee1
PE
8161 * chartab.c (chartab_chars, chartab_bits): Now static.
8162
a2cb4e63
PE
8163 * charset.h (charset_iso_8859_1): Remove decl.
8164 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8165 Now static.
8166
127198fd
PE
8167 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8168 * ccl.c (Vccl_program_table): Now static.
8169 (check_ccl_update): Remove; unused.
8170
d85b608f
PE
8171 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8172 * category.h: ... from here.
8173 * category.c (check_category_table, set_category_set): Now static.
8174
31cd66f3
PE
8175 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8176 * lisp.h: Remove these decls.
8177
c358e587
PE
8178 * buffer.c (buffer_count): Remove unused var.
8179
e78aecca
PE
8180 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8181 so that it's not optimized away.
8182 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8183 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8184 exported only to the debugger.
8185
e192d7d3 8186 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 8187 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 8188
92470028
PE
8189 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8190 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8191 was inaccessible from Lisp.
8192 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8193 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8194
244ed907
PE
8195 alloc.c: Import and export fewer symbols, and remove unused items.
8196 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8197 is defined.
8198 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8199 it's not optimized away by whole-program optimization.
8200 (message_enable_multibyte, free_misc): Remove.
8201 (catchlist, handlerlist, mark_backtrace):
8202 Declare only if BYTE_MARK_STACK.
8203 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8204 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8205 (message_enable_multibyte): Remove decl.
8206 (free_misc, interval_free_list, float_block, float_block_index):
8207 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8208 (cons_free_list, last_marked_index):
8209 Now static.
8210 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8211 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8212 (mark_backtrace): Define only if BYTE_MARK_STACK.
8213 * xdisp.c (message_enable_multibyte): Now static.
8214
61c2b50e 8215 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
8216 This makes it easier for human readers (and static analyzers)
8217 to see whether these variables are used from other modules.
8218 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8219 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8220 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8221 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8222 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8223 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8224 * xmenu.c, xselect.c:
8225 Declare Q* vars static if they are not used in other modules.
8226 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8227 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8228 Remove decls of unexported vars.
8229 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8230
95c82688
PE
8231 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8232
16a97296
PE
8233 Make Emacs functions such as Fatom 'static' by default.
8234 This makes it easier for human readers (and static analyzers)
8235 to see whether these functions can be called from other modules.
8236 DEFUN now defines a static function. To make the function external
8237 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
8238 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8239 (Finit_image_library):
16a97296
PE
8240 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8241 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8242 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8243 Remove decls, since these functions are now static.
8244 (Funintern, Fget_internal_run_time): New decls, since these functions
8245 were already external.
95c82688 8246
16a97296
PE
8247 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8248 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8249 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8250 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8251 * keyboard.c, keymap.c, lread.c:
8252 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8253 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8254 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8255 Mark functions with DEFUE instead of DEFUN,
8256 if they are used in other modules.
8257 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8258 decls for now-static functions.
8259 * buffer.h (Fdelete_overlay): Remove decl.
8260 * callproc.c (Fgetenv_internal): Mark as internal.
8261 * composite.c (Fremove_list_of_text_properties): Remove decl.
8262 (Fcomposition_get_gstring): New forward static decl.
8263 * composite.h (Fcomposite_get_gstring): Remove decl.
8264 * dired.c (Ffile_attributes): New forward static decl.
8265 * doc.c (Fdocumntation_property): New forward static decl.
8266 * eval.c (Ffetch_bytecode): New forward static decl.
8267 (Funintern): Remove extern decl; now in .h file where it belongs.
8268 * fileio.c (Fmake_symbolic_link): New forward static decl.
8269 * image.c (Finit_image_library): New forward static decl.
8270 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8271 * intervals.h (Fprevious_property_change):
8272 (Fremove_list_of_text_properties): Remove decls.
8273 * keyboard.c (Fthis_command_keys): Remove decl.
8274 (Fcommand_execute): New forward static decl.
8275 * keymap.c (Flookup_key): New forward static decl.
8276 (Fcopy_keymap): Now static.
8277 * keymap.h (Flookup_key): Remove decl.
8278 * process.c (Fget_process): New forward static decl.
8279 (Fprocess_datagram_address): Mark as internal.
8280 * syntax.c (Fsyntax_table_p): New forward static decl.
8281 (skip_chars): Remove duplicate decl.
8282 * textprop.c (Fprevious_property_change): New forward static decl.
8283 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8284 Now internal.
8285 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8286 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8287
785bbd42
PE
8288 * editfns.c (Fformat): Remove unreachable code.
8289
8b913b57
AS
82902011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8291
8292 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8293 change. (Bug#8496)
8294
a6744a35
EZ
82952011-04-13 Eli Zaretskii <eliz@gnu.org>
8296
8297 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8298 when at ZV. (Bug#8487)
8299
e7974947
AS
83002011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8301
baad03f0
AS
8302 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8303 (Bug#8437)
8304 * keyboard.c (parse_tool_bar_item): Likewise.
8305 * sound.c (sound_cleanup, alsa_close): Likewise.
8306 * termcap.c (tgetent): Likewise.
8307 * xfns.c (x_default_font_parameter): Likewise.
8308 * xsettings.c (read_and_apply_settings): Likewise.
8309
e7974947
AS
8310 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8311 (overrun_check_free): Protoize.
8312
28272684
PE
83132011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8314
8315 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8316 since callers should never pass a negative size.
8317 Change the signature to match that of plain 'read' and 'write'; see
8318 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8319 * lisp.h: Update prototypes of emacs_write and emacs_read.
8320
11997c76
EZ
83212011-04-11 Eli Zaretskii <eliz@gnu.org>
8322
8323 * xdisp.c (redisplay_window): Don't try to determine the character
8324 position of the scroll margin if the window start point w->startp
e896f03c 8325 is outside the buffer's accessible region. (Bug#8468)
11997c76 8326
8a2cbd72
EZ
83272011-04-10 Eli Zaretskii <eliz@gnu.org>
8328
8329 Fix write-region and its subroutines for buffers > 2GB.
8330 * fileio.c (a_write, e_write): Modify declaration of arguments and
8331 local variables to support buffers larger than 2GB.
8332 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8333
8334 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8335 argument, local variables, and return value.
8336
8337 * lisp.h: Update prototypes of emacs_write and emacs_read.
8338
8339 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8340
4073e537 83412011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8342
1ebfdcb6
PE
8343 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8344
b2ded58d
PE
8345 Fix more problems found by GCC 4.6.0's static checks.
8346
7d66342c
PE
8347 * xdisp.c (vmessage): Use a better test for character truncation.
8348
bbf47d44
PE
8349 * charset.c (load_charset_map): <, not <=, for optimization,
8350 and to avoid potential problems with integer overflow.
9248994d 8351 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8352 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8353 * editfns.c (Fformat): Likewise.
1e69125e 8354 * syntax.c (skip_chars): Likewise.
3befa583 8355
e3019616
PE
8356 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8357 This also lets GCC 4.6.0 generate slightly better loop code.
8358
becfa255
PE
8359 * callint.c (Fcall_interactively): <, not <=, for optimization.
8360 (Fcall_interactively): Count the number of arguments produced,
8361 not the number of arguments given. This is simpler and lets GCC
8362 4.6.0 generate slightly better code.
8363
dae0cd48
PE
8364 * ftfont.c: Distingish more carefully between FcChar8 and char.
8365 The previous code passed unsigned char * to a functions like
8366 strlen and xstrcasecmp that expect char *, which does not
8367 conform to the C standard.
8368 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8369 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8370 char * when the C standard requires it.
8371
76032d70
PE
8372 * keyboard.c (read_char): Remove unused var.
8373
eb3f1cc8
PE
8374 * eval.c: Port to Windows vsnprintf (Bug#8435).
8375 Include <limits.h>.
8376 (SIZE_MAX): Define if the headers do not.
8377 (verror): Do not give up if vsnprintf returns a negative count.
8378 Instead, grow the buffer. This ports to Windows vsnprintf, which
8379 does not conform to C99. Problem reported by Eli Zaretskii.
8380 Also, simplify the allocation scheme, by avoiding the need for
8381 calling realloc, and removing the ALLOCATED variable.
8382
70476b54
PE
8383 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8384
12020a9e
PE
8385 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8386 But keep the doprint source code for now, as we might revamp it
8387 and use it again (Bug#8435).
ea6c7ae6
PE
8388 * lisp.h (doprnt): Remove.
8389 * Makefile.in (base_obj): Remove doprnt.o.
8390 * deps.mk (doprnt.o): Remove.
8391
5fdb398c
PE
8392 error: Print 32- and 64-bit integers portably (Bug#8435).
8393 Without this change, on typical 64-bit hosts error ("...%d...", N)
8394 was used to print both 32- and 64-bit integers N, which relied on
8395 undefined behavior.
61bdb816 8396 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8397 * lisp.h (error, verror): Mark as printf-like functions.
8398 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8399 Report overflow in size calculations when allocating printf buffer.
8400 Do not truncate output string at its first null byte.
8401 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8402 Truncate the output at a character boundary, since vsnprintf does not
8403 do that.
8404 * charset.c (check_iso_charset_parameter): Convert internal
8405 character to string before calling 'error', since %c now has the
8406 printf meaning.
8407 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8408 overflow when computing char to be passed to 'error'. Do not
8409 pass Lisp_Object to 'error'; pass the integer instead.
8410 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8411 formatted with plain %d.
8412
b189fa66
PE
8413 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8414
bff87ef0
PE
8415 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8416
7e2cac20
PE
8417 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8418
ce4d90b5
PE
8419 * xterm.c (x_catch_errors): Remove duplicate declaration.
8420
266c9547
PE
8421 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8422
79c49ad2
PE
8423 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8424
368f4090
JM
84252011-04-10 Jim Meyering <meyering@redhat.com>
8426
8427 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8428 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8429 return ssize_t not "int", and use size_t as the buffer length.
8430 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8431 * gnutls.h: Update declarations.
8432 * process.c (read_process_output): Use ssize_t, to match.
8433 (send_process): Likewise.
8434
a32d4040
CY
84352011-04-09 Chong Yidong <cyd@stupidchicken.com>
8436
8437 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8438
8546720e 84392011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8440
04f2d78b
CB
8441 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8442 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8443
8546720e
GM
8444 * xterm.c (handle_one_xevent):
8445 * xmenu.c (create_and_show_popup_menu):
8446 * xselect.c (x_decline_selection_request)
8447 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8448
0a2f5c1a 84492011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8450
8451 Fix some uses of `int' instead of EMACS_INT.
8452 * search.c (string_match_1, fast_string_match)
8453 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8454 (scan_buffer, find_next_newline_no_quit)
8455 (find_before_next_newline, search_command, Freplace_match)
8456 (Fmatch_data): Make some `int' variables be EMACS_INT.
8457
8458 * xdisp.c (display_count_lines): 3rd argument and return value now
8459 EMACS_INT. All callers changed.
8460 (pint2hrstr): Last argument is now EMACS_INT.
8461
8462 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8463 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8464 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8465 (decode_coding_utf_16, decode_coding_emacs_mule)
8466 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8467 (decode_coding_ccl, decode_coding_charset)
8468 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8469 (decode_coding_iso_2022, decode_coding_emacs_mule)
8470 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8471 <char_offset, last_offset>: Declare EMACS_INT.
8472 (encode_coding_utf_8, encode_coding_utf_16)
8473 (encode_coding_emacs_mule, encode_invocation_designation)
8474 (encode_designation_at_bol, encode_coding_iso_2022)
8475 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8476 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8477 Declare EMACS_INT.
8478 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8479 (encode_invocation_designation): Last argument P_NCHARS is now
8480 EMACS_INT.
8481 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8482 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8483
8484 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8485 All users changed.
8486
8487 * ccl.c (Fccl_execute_on_string): Declare some variables
8488 EMACS_INT.
8489
8546720e 84902011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8491
8492 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8493
4e19a977
CS
84942011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8495
8496 * process.c (Fformat_network_address): Doc fix.
8497
87302331
R
84982011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8499
ee7683eb 8500 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8501
cbb59342
CY
85022011-04-08 Chong Yidong <cyd@stupidchicken.com>
8503
8504 * keyboard.c (read_char): Call Lisp function help-form-show,
8505 instead of using internal_with_output_to_temp_buffer.
8506 (Qhelp_form_show): New var.
e0d38eeb 8507 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8508
8509 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8510
8511 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8512
e67a13ab
CY
85132011-04-06 Chong Yidong <cyd@stupidchicken.com>
8514
04f2d78b
CB
8515 * process.c (Flist_processes): Remove to Lisp.
8516 (list_processes_1): Delete.
e67a13ab 8517
973f782d
EZ
85182011-04-06 Eli Zaretskii <eliz@gnu.org>
8519
7c106b1e
EZ
8520 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8521
973f782d
EZ
8522 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8523
41cf7d1a 85242011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8525
ca23cc88
PE
8526 Fix more problems found by GCC 4.6.0's static checks.
8527
f390e2d5
PE
8528 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8529
42eea0d0
PE
8530 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8531
b69769da 8532 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8533
f9541e84
PE
8534 * xdisp.c (vmessage): Mark as a printf-like function.
8535
13841b55
PE
8536 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8537
c136c10f
PE
8538 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8539
5e2d4a30
PE
8540 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8541 printf-like functions.
8542 (tiff_load): Add casts to remove these marks before passing them
8543 to system-supplied API.
8544
583f48b9
PE
8545 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8546
b25d760e
PE
8547 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8548 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8549 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8550 directly, rather than having caller test rule sign. This avoids
8551 some unnecessary tests.
8552 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8553 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8554 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8555
bc7b6697 8556 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8557 (xfont_open): Avoid unnecessary tests.
bc7b6697 8558
27ccc379
PE
8559 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8560
dcd5c89a
PE
8561 * composite.h, composite.c (composition_gstring_put_cache):
8562 Use EMACS_INT, not int, for length.
8563
b13a45c6
PE
8564 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8565 breaking out part of COMPOSITION_DECODE_RULE.
8566 (COMPOSITION_DECODE_RULE): Use it.
8567 * composite.c (get_composition_id): Remove unused local vars,
8568 by using the new macro.
8569
1e792e4d
PE
8570 * textprop.c (set_text_properties_1): Change while to do-while,
8571 since the condition is always true at first.
8572
dc6c6455 8573 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8574 (interval_deletion_adjustment): Return unsigned value.
8575 All uses changed.
dc6c6455 8576
aba7731a
PE
8577 * process.c (list_processes_1, create_pty, read_process_output):
8578 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8579 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8580 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8581 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8582 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8583
fdfc4bf3
PE
8584 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8585
fca8fe46 8586 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8587 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8588
06a0259a 8589 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8590 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8591 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8592
e7b9e80f
PE
8593 * print.c (print_error_message): Avoid int overflow.
8594
56201685
PE
8595 * font.c (font_list_entities): Redo for clarity,
8596 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8597
78834453 8598 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8599 (font_score): Avoid potential overflow in diff calculation.
78834453 8600
0bc0b309 8601 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8602 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8603
e610eaca
PE
8604 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8605
b895abce
PE
8606 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8607 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8608 can always succeed if overflow has undefined behavior.
8609
1f1d9321 8610 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8611 (wordify): Omit three unnecessary tests.
1f1d9321 8612
c59478bc
PE
8613 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8614 All callers changed. This avoids the need for an unused var.
8615
79b73827
PE
8616 * casefiddle.c (casify_region): Remove var that is set but not used.
8617
a4db5dfe
PE
8618 * dired.c (file_name_completion): Remove var that is set but not used.
8619
43aae36e
PE
8620 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8621
2a47c44d 8622 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8623 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8624
a37c69bf
PE
8625 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8626 Check for integer overflow on size calculations.
8627
328ab8e7
PE
8628 * buffer.c (Fprevious_overlay_change): Remove var that is set
8629 but not used.
8630
e5a2a5cb
PE
8631 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8632 Remove vars that are set but not used.
8d84a6eb 8633 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8634 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8635
a60e5f68
PE
8636 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8637
f661cb61 8638 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8639 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8640
f0397f5a
PE
8641 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8642 that are set but not used.
8643
8664db06 8644 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8645 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8646
6abdaa4a
PE
8647 * xselect.c (x_get_local_selection, x_handle_property_notify):
8648 Remove vars that are set but not used.
8649
0ce7538d 8650 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8651 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8652
9ae848fc
PE
8653 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8654 Remove var that is set but not used.
0b918413
PE
8655 (scroll_bar_windows_size): Now size_t, not int.
8656 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8657 Check for overflow.
9ae848fc 8658
a5a62657
PE
8659 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8660 (map_tty_color) [!defined MSDOS]: Likewise.
8661
5c5cdd39
PE
8662 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8663
66ebf983
PE
8664 * coding.c: Remove vars that are set but not used.
8665 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8666 All callers changed.
8667 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8668 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8669 (decode_coding_charset): Remove vars that are set but not used.
8670
1be4d761
PE
8671 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8672 that is set but not used.
8673
47553fa8
PE
8674 * print.c (print_object): Remove var that is set but not used.
8675
1f7196bf 8676 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8677 The gnulib version avoids calling malloc in the usual case,
8678 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8679 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8680 * filelock.c (current_lock_owner): Likewise.
8681 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8682 * sysdep.c: Include allocator.h, careadlinkat.h.
8683 (emacs_no_realloc_allocator): New static constant.
8684 (emacs_readlink): New function.
fdb61804
PE
8685 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8686 ../lib/careadlinkat.h.
d1fdcab7 8687
f84c17c7
SM
86882011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8689
8690 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8691 first non-nil return value).
8692
ef3862ad
JD
86932011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8694
8695 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8696 if not defined (Bug#8403).
8697
376a7006
JB
86982011-04-02 Juanma Barranquero <lekktu@gmail.com>
8699
8700 * xdisp.c (display_count_lines): Remove parameter `start',
8701 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8702 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8703 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8704 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8705 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8706 and thereabouts. All callers changed.
8707 (get_per_char_metric): Remove parameter `f', unused since
8708 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8709
6ca3801d
JM
87102011-04-02 Jim Meyering <meyering@redhat.com>
8711
8712 do not dereference NULL upon failed strdup
8713 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8714 (ns_get_family): Likewise.
8715
d8e2b5ba
JB
87162011-04-02 Juanma Barranquero <lekktu@gmail.com>
8717
8718 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8719
8c74fcbd
JD
87202011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8721
8722 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8723 later (Bug#8403).
8724
7200d79c
SM
87252011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8726
03408648 8727 Add lexical binding.
7200d79c 8728
03408648
SM
8729 * window.c (Ftemp_output_buffer_show): New fun.
8730 (Fsave_window_excursion):
8731 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8732
8733 * lread.c (lisp_file_lexically_bound_p): New function.
8734 (Fload): Bind Qlexical_binding.
8735 (readevalloop): Remove `evalfun' arg.
8736 Bind Qinternal_interpreter_environment.
8737 (Feval_buffer): Bind Qlexical_binding.
8738 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8739 Mark as dynamic.
8740 (syms_of_lread): Declare `lexical-binding'.
8741
8742 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8743
8744 * keyboard.c (eval_dyn): New fun.
8745 (menu_item_eval_property): Use it.
ca105506
SM
8746
8747 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8748
03408648
SM
8749 * fns.c (concat, mapcar1): Accept byte-code-functions.
8750
8751 * eval.c (Fsetq): Handle lexical vars.
8752 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8753 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8754 (FletX, Flet): Obey lexical binding.
8755 (Fcommandp): Handle closures.
8756 (Feval): New `lexical' arg.
8757 (eval_sub): New function extracted from Feval. Use it almost
8758 everywhere where Feval was used. Look up vars in lexical env.
8759 Handle closures.
8760 (Ffunctionp): Move from subr.el.
8761 (Ffuncall): Handle closures.
8762 (apply_lambda): Remove `eval_flags'.
8763 (funcall_lambda): Handle closures and new byte-code-functions.
8764 (Fspecial_variable_p): New function.
8765 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8766 but without exporting it to Lisp.
23aba0ea 8767
23aba0ea 8768 * doc.c (Fdocumentation, store_function_docstring):
03408648 8769 * data.c (Finteractive_form): Handle closures.
23aba0ea 8770
03408648
SM
8771 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8772 interactive spec.
ba83908c 8773
04f2d78b
CB
8774 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8775 New byte-codes.
03408648
SM
8776 (exec_byte_code): New function extracted from Fbyte_code to handle new
8777 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8778
03408648 8779 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8780
03408648 8781 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8782
e2abce01
JB
87832011-03-31 Juanma Barranquero <lekktu@gmail.com>
8784
8785 * xdisp.c (redisplay_internal): Fix prototype.
8786
63696a73 87872011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8788
63696a73 8789 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8790 (try_scrolling): Use it when setting scroll_limit.
8791 Limit scrolling to 100 screen lines.
63696a73
EZ
8792 (redisplay_window): Even when falling back on "recentering",
8793 position point in the window according to scroll-conservatively,
8794 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8795
8796 (try_scrolling): When point is above the window, allow searching
8797 as far as scroll_max, or one screenful, to compute vertical
8798 distance from PT to the scroll margin position. This prevents
8799 try_scrolling from unnecessarily failing when
8800 scroll-conservatively is set to a value slightly larger than the
8801 window height. Clean up the case of PT below the margin at bottom
8802 of window: scroll_max can no longer be INT_MAX. When aggressive
8803 scrolling is in use, don't let point enter the opposite scroll
8804 margin as result of the scroll.
8805 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8806 threshold of 100 lines for never-recentering scrolling.
8807
e4cc2dfc
JB
88082011-03-31 Juanma Barranquero <lekktu@gmail.com>
8809
8810 * dispextern.h (move_it_by_lines):
8811 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8812 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8813 (message_log_check_duplicate): Remove parameters `prev_bol' and
8814 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8815 (redisplay_internal): Remove parameter `preserve_echo_area',
8816 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8817
8818 * indent.c (Fvertical_motion):
8819 * window.c (window_scroll_pixel_based, Frecenter):
8820 Don't pass `need_y_p' to `move_it_by_lines'.
8821
1c470562
SM
88222011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8823
44f230aa
SM
8824 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8825 steal a few bits to be more compact.
8826 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8827 Remove unneeded casts.
8828
1c470562
SM
8829 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8830
888adce9
ZK
88312011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8832
8833 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8834 binding" message (bug#7967).
8835
f838ed7b
PE
88362011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8837
77861b95
PE
8838 Fix more problems found by GCC 4.6.0's static checks.
8839
de6dbc14
PE
8840 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8841 Remove unused local var.
8842
f838ed7b
PE
8843 * editfns.c (Fmessage_box): Remove unused local var.
8844
792c7b2b
PE
8845 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8846 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8847 Omit unused local vars.
c499e557 8848 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8849 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8850 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8851 Omit unused local var.
8852
ba0165e1
PE
8853 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8854 Don't assume string length fits in int.
32ad8845 8855 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8856 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8857
3c59b4c9
PE
8858 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8859 instead of alloca (Bug#8344).
8860
a3eed478 8861 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8862 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8863
eb4d412d
PE
8864 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8865
1658b401
PE
8866 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8867 concerns.
8868
8869 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8870
8871 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8872
9a2c6e05
PE
8873 * keyboard.c (syms_of_keyboard): Use the same style as later
8874 in this function when indexing through an array. This also
8875 works around GCC bug 48267.
8876
03d0a109
PE
8877 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8878
44f730c8
PE
8879 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8880
fe75f926
PE
8881 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8882 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8883
ffa8c828
PE
8884 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8885 This avoids undefined behavior on integer overflow, and is a bit
8886 more convenient anyway since it is compared to a size_t variable.
8887
c5101a77
PE
8888 Variadic C functions now count arguments with size_t, not int.
8889 This avoids an unnecessary limitation on 64-bit machines, which
8890 caused (substring ...) to crash on large vectors (Bug#8344).
8891 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8892 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8893 All variadic functions and their callers changed accordingly.
c5101a77
PE
8894 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8895 * data.c (arith_driver, float_arith_driver): Likewise.
8896 * editfns.c (general_insert_function): Likewise.
8897 * eval.c (struct backtrace.nargs, interactive_p)
8898 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8899 (funcall_lambda, mark_backtrace): Likewise.
8900 * fns.c (concat): Likewise.
8901 * frame.c (x_set_frame_parameters): Likewise.
8902 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8903 0 if not found, not -1. All callers changed.
8904
dd3f25f7
PE
8905 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8906 (stack_copy_size): Now size_t, not int.
8907 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8908
461c2ab9
JB
89092011-03-28 Juanma Barranquero <lekktu@gmail.com>
8910
8911 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8912 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8913 All callers changed.
8914
8915 * lisp.h (multibyte_char_to_unibyte):
8916 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8917 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8918 * character.h (CHAR_TO_BYTE8):
8919 * cmds.c (internal_self_insert):
8920 * editfns.c (general_insert_function):
8921 * keymap.c (push_key_description):
8922 * search.c (Freplace_match):
8923 * xdisp.c (message_dolog, set_message_1): All callers changed.
8924
f6d62986
SM
89252011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8926
8927 * keyboard.c (safe_run_hook_funcall): New function.
8928 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8929 don't set the hook to nil, but remove the offending function instead.
8930 (Qcommand_hook_internal): Remove, unused.
8931 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8932 Vcommand_hook_internal.
8933
8934 * eval.c (enum run_hooks_condition): Remove.
8935 (funcall_nil, funcall_not): New functions.
8936 (run_hook_with_args): Call each function through a `funcall' argument.
8937 Remove `cond' argument, now redundant.
8938 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8939 (Frun_hook_with_args_until_failure): Adjust accordingly.
8940 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8941
1db5b1ad
JB
89422011-03-28 Juanma Barranquero <lekktu@gmail.com>
8943
8944 * dispextern.h (string_buffer_position): Remove declaration.
8945
8946 * print.c (strout): Remove parameter `multibyte', unused since
8947 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8948
8949 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8950 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8951 All callers changed.
8952
8953 * w32.c (_wsa_errlist): Use braces for struct initializers.
8954
8955 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8956 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8957 All callers changed.
8958 (string_buffer_position): Likewise. Also, make static (it's never
8959 used outside xdisp.c).
8960 (cursor_row_p): Remove parameter `w', unused since
8961 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8962 (decode_mode_spec): Remove parameter `precision', introduced during
8963 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8964 All callers changed.
8965
5ffb62aa
JD
89662011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8967
8968 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8969
461c2ab9 89702011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8971
8972 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8973 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8974 (ns_update_auto_hide_menu_bar): New functions.
8975 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8976 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8977 ns_constrain_all_frames.
8978 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8979 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8980
5c380ffb
JD
89812011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8982
8983 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8984
9af30bdf
GM
89852011-03-27 Glenn Morris <rgm@gnu.org>
8986
8987 * syssignal.h: Replace RETSIGTYPE with void.
8988 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8989 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8990 Replace SIGTYPE with void everywhere.
8991 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8992 * s/template.h (SIGTYPE): Remove commented out definition.
8993
e2abce01
JB
89942011-03-26 Eli Zaretskii <eliz@gnu.org>
8995
8996 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8997 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8998
f868cd8a
JB
89992011-03-26 Juanma Barranquero <lekktu@gmail.com>
9000
59eb0929
JB
9001 * w32.c (read_unc_volume): Use parameter `henum', instead of
9002 global variable `wget_enum_handle'.
9003
9004 * keymap.c (describe_vector): Remove parameters `indices' and
9005 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9006 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9007
f868cd8a
JB
9008 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9009
9010 * keyboard.c (timer_check): Remove parameter `do_it_now',
9011 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9012 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9013 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9014
9015 * keyboard.c (read_char):
9016 * w32menu.c (w32_menu_display_help):
9017 * xmenu.c (show_help_event, menu_help_callback):
9018 Adjust calls to `show_help_echo'.
9019
9020 * gtkutil.c (xg_maybe_add_timer):
9021 * keyboard.c (readable_events):
9022 * process.c (wait_reading_process_output):
9023 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9024
9025 * insdel.c (adjust_markers_gap_motion):
9026 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9027 (gap_left, gap_right): Don't call it.
9028
2ecf6fdb
CY
90292011-03-25 Chong Yidong <cyd@stupidchicken.com>
9030
9031 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9032 incurred during fontification.
9033
6b1f9ba4
JB
90342011-03-25 Juanma Barranquero <lekktu@gmail.com>
9035
9036 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9037 (DEFVAR_PER_BUFFER): Don't pass it.
9038
9039 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9040 (scrolling_window): Don't pass it.
9041
0f4a96b5
JB
90422011-03-25 Juanma Barranquero <lekktu@gmail.com>
9043
9044 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9045
9046 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9047 and `suffix'.
9048 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9049 of variables specific to SELinux and computation of `encoded_absname'.
9050
9051 * image.c (XPutPixel): Remove unused variable `height'.
9052
9053 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9054
9055 * unexw32.c (get_section_info): Remove unused variable `section'.
9056
9057 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9058 (system_process_attributes): Remove unused variable `sess'.
9059 (sys_read): Remove unused variable `err'.
9060
9061 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9062 (w32_wnd_proc): Remove unused variable `isdead'.
9063 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9064 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9065 (x_create_tip_frame): Remove unused variable `tem'.
9066
9067 * w32inevt.c (w32_console_read_socket):
9068 Remove unused variable `no_events'.
9069
9070 * w32term.c (x_draw_composite_glyph_string_foreground):
9071 Remove unused variable `width'.
9072
1149507c
JB
90732011-03-24 Juanma Barranquero <lekktu@gmail.com>
9074
9075 * w32term.c (x_set_glyph_string_clipping):
9076 Don't pass uninitialized region to CombineRgn.
9077
9c88f339
JB
90782011-03-23 Juanma Barranquero <lekktu@gmail.com>
9079
9080 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9081 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9082 (Fx_close_connection): Remove unused variable `i'.
9083
9084 * w32font.c (w32font_draw): Return number of glyphs.
9085 (w32font_open_internal): Remove unused variable `i'.
9086 (w32font_driver): Add missing initializer.
9087
9088 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9089 (fill_in_menu): Remove unused variable `items_added'.
9090
9091 * w32term.c (last_mouse_press_frame): Remove static global variable.
9092 (w32_clip_to_row): Remove unused variable `f'.
9093 (x_delete_terminal): Remove unused variable `i'.
9094
9095 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9096 (NOTHING): Remove unused static global variable.
9097 (uniscribe_check_otf): Remove unused variable `table'.
9098 (uniscribe_font_driver): Add missing initializers.
9099
dee091a3
JD
91002011-03-23 Julien Danjou <julien@danjou.info>
9101
9102 * term.c (Fsuspend_tty, Fresume_tty):
9103 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9104 * window.c (temp_output_buffer_show):
9105 * insdel.c (signal_before_change):
9106 * frame.c (Fhandle_switch_frame):
9107 * fileio.c (Fdo_auto_save):
9108 * emacs.c (Fkill_emacs):
9109 * editfns.c (save_excursion_restore):
9110 * cmds.c (internal_self_insert):
9111 * callint.c (Fcall_interactively):
9112 * buffer.c (Fkill_all_local_variables):
9113 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9114 Use Frun_hooks.
0f4a96b5 9115 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 9116 unconditionally since it does the check itself.
dee091a3 9117
2c520ab5 91182011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 9119
c9c49752
PE
9120 Fix more problems found by GCC 4.5.2's static checks.
9121
8abc3f12
PE
9122 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9123 the first time through the loop, since we know p0 < p1 then.
9124 This also avoids a gcc -Wstrict-overflow warning.
9125
a2d26660
PE
9126 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9127 leading to a memory leak, possible in functions like
9128 load_charset_map_from_file that can allocate an unbounded number
b12ef411 9129 of objects (Bug#8318).
a2d26660 9130
916c72e9
PE
9131 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9132 that could (at least in theory) be that large.
9133
19ab8a18
PE
9134 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9135 This is less likely to overflow, and avoids undefined behavior if
9136 overflow does occur. All callers changed. Use strtoul to scan
9137 for the unsigned long integer.
b7cbbd6f
PE
9138 (pint2hrstr): Simplify and tune code slightly.
9139 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 9140
f0641eff
PE
9141 * scroll.c (do_scrolling): Work around GCC bug 48228.
9142 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9143
7f650bb9
PE
9144 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9145 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
9146 (validate_x_resource_name): Simplify count usage.
9147 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 9148
37dd57d1
PE
9149 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9150 fail (Bug#8306).
81e56e61 9151
699979fc 9152 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 9153
401bf9b4
PE
9154 * process.c (Fmake_network_process): Use socklen_t, not int,
9155 where POSIX says socklen_t is required in portable programs.
9156 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 9157 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
9158 (Fmake_network_process, server_accept_connection):
9159 (wait_reading_process_output, read_process_output):
9160 Likewise.
9161
b93aacde
PE
9162 * process.c: Rename or move locals to avoid shadowing.
9163 (list_processes_1, Fmake_network_process):
9164 (read_process_output_error_handler, exec_sentinel_error_handler):
9165 Rename or move locals.
4dc343ee 9166 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 9167 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 9168 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 9169 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 9170 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 9171
af8a867c 9172 Make tparam.h and terminfo.c consistent.
44f230aa
SM
9173 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9174 Include tparam.h instead, since it declares them.
af8a867c
PE
9175 * cm.h (PC): Remove extern decl; tparam.h now does this.
9176 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9177 * terminfo.c: Include tparam.h, to check interfaces.
9178 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9179 (tparam): Adjust signature to match interface in tparam.h;
9180 this removes some undefined behavior. Check that outstring and len
9181 are zero, which they always are with Emacs.
9182 * tparam.h (PC, BC, UP): New extern decls.
9183
0248044d 9184 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 9185 (xftfont_open): Rename locals to avoid shadowing.
0248044d 9186
8ff096c1 9187 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
9188 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9189 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 9190 (ftfont_list): Remove unused local.
49eaafba
PE
9191 (get_adstyle_property, ftfont_pattern_entity):
9192 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9193 Rename locals to avoid shadowing.
8ff096c1 9194
e2be39f6
PE
9195 * xfont.c (xfont_list_family): Mark var as initialized.
9196
c9735e30
PE
9197 * xml.c (make_dom): Now static.
9198
8f5201ae
PE
9199 * composite.c (composition_compute_stop_pos): Rename local to
9200 avoid shadowing.
b246f932
PE
9201 (composition_reseat_it): Remove unused locals.
9202 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 9203 (composition_update_it): Mark var as initialized.
11b61122
PE
9204 (find_automatic_composition): Mark vars as initialized,
9205 with a FIXME (Bug#8290).
8f5201ae 9206
760fbc2c
PE
9207 character.h: Rename locals to avoid shadowing.
9208 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9209 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9210 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9211 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9212 to avoid shadowing.
9213
ff08eb85
PE
9214 * textprop.c (property_change_between_p): Remove; unused.
9215
fc7bf025
PE
9216 * intervals.c (interval_start_pos): Now static.
9217
235d7abc
PE
9218 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9219
44f230aa
SM
9220 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9221 Rename locals to avoid shadowing.
3e7d6594 9222
50060332
PE
9223 * sound.c (wav_play, au_play, Fplay_sound_internal):
9224 Fix pointer signedness.
d01f234b 9225 (alsa_choose_format): Remove unused local var.
c83b8872
PE
9226 (wav_play): Initialize a variable to 0, to prevent undefined
9227 behavior (Bug#8278).
50060332 9228
c4fc4e30
PE
9229 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9230
918436ed
PE
9231 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9232
c939f91b
PE
9233 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9234 clobbering (Bug#8298).
b9c7f648
PE
9235 * sysdep.c (sys_subshell): Likewise.
9236 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 9237
6bd8c144
PE
9238 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9239 This should get cleaned up, so that child_setup has the
9240 same signature on all platforms.
9241
7710357c 9242 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 9243 (relocate_fd): Rename locals to avoid shadowing.
7710357c 9244
c59da222
CY
92452011-03-22 Chong Yidong <cyd@stupidchicken.com>
9246
9247 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9248 not to be necessary, and produces flickering.
9249
66b87493
GM
92502011-03-20 Glenn Morris <rgm@gnu.org>
9251
9252 * config.in: Remove file.
9253
45b6f6d5
JB
92542011-03-20 Juanma Barranquero <lekktu@gmail.com>
9255
9256 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9257 are now in src/globals.h.
9258 (syms_of_minibuf): Remove spurious & from previous change.
9259
cd394be1 92602011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
9261
9262 * minibuf.c (completing-read-function): New variable.
9263 (completing-read-default): Rename from completing-read.
9264 (completing-read): Call completing-read-function.
9265
b14e3e21
CY
92662011-03-19 Juanma Barranquero <lekktu@gmail.com>
9267
9268 * xfaces.c (Fx_load_color_file):
9269 Read color file from absolute filename (bug#8250).
9270
f2b726e6
JB
92712011-03-19 Juanma Barranquero <lekktu@gmail.com>
9272
9273 * makefile.w32-in: Update dependencies.
9274
09f6ff02
EZ
92752011-03-17 Eli Zaretskii <eliz@gnu.org>
9276
9277 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9278
29a6015a
PE
92792011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9280
a3a6c54e
PE
9281 Fix more problems found by GCC 4.5.2's static checks.
9282
b766f867
PE
9283 * process.c (make_serial_process_unwind, send_process_trap):
9284 (sigchld_handler): Now static.
9285
be02381c
PE
9286 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9287 That way, the code declares only the vars that it needs.
9288 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9289 * s/cygwin.h (PTY_ITERATION): Likewise.
9290 * s/darwin.h (PTY_ITERATION): Likewise.
9291 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9292
57048744
PE
9293 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9294 * process.c (allocate_pty): Don't declare stb unless it's needed.
9295
7914961c 9296 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
9297 (CONSTANTLIM): Remove; unused.
9298 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9299 Define only if needed.
7914961c 9300
b3967b18
PE
9301 * unexelf.c (unexec): Name an expression,
9302 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
9303 Use a different way to cause a compilation error if anyone uses
9304 n rather than nn, a way that does not involve shadowing.
73366a00 9305 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9306
29a6015a
PE
9307 * deps.mk (unexalpha.o): Remove; unused.
9308
43cfc33e 9309 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9310 * unexec.h: New file.
ce701a33
PE
9311 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9312 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9313 Depend on unexec.h.
9314 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9315 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9316 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9317 Change as necessary to match prototype in unexec.h.
ce701a33 9318
01f44d5a
PE
9319 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9320 shadowing.
4f63c6bb 9321 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9322
a6670b0b
PE
9323 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9324 Rename locals to avoid shadowing.
9325
cef2010d 9326 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9327 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9328
d4d7173a
PE
9329 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9330
f08b802a
PE
9331 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9332 warning when compiling print.c.
9333
3ddb0639
PE
9334 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9335 instead of using an uninitialized var.
5ad03b97 9336 (font_sort_entities): Mark var as initialized.
3ddb0639 9337
170a2692
PE
9338 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9339
e663c700
PE
9340 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9341 pointers to constants.
89bc529a 9342 (font_parse_fcname): Remove unused vars.
7b81e2d0 9343 (font_delete_unmatched): Now static.
ea838e10 9344 (font_get_spec): Remove; unused.
13a547c6
PE
9345 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9346 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9347 Rename or move locals to avoid shadowing.
e663c700 9348
2a80c887 9349 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9350 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9351
1384fa33 9352 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9353 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9354
8b2c52e9
PE
9355 * alloc.c (mark_backtrace): Move decl from here ...
9356 * lisp.h: ... to here, so that it can be checked.
9357
475545b5 9358 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9359 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9360 (lisp_indirect_variable): Name an expression,
9361 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9362 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9363
b1349114 9364 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9365 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9366 Use const pointer when appropriate.
b1349114 9367
a2928364
PE
9368 * lisp.h (get_system_name, get_operating_system_release):
9369 Move decls here, to check interfaces.
9370 * process.c (get_operating_system_release): Move decl to lisp.h.
9371 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9372 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9373 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9374 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9375 (Fformat_time_string, Fencode_time, Finsert_char):
9376 (Ftranslate_region_internal, Fformat):
9377 Rename or remove local vars to avoid shadowing.
9710023e 9378 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9379
a415e694
PE
9380 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9381 avoid shadowing.
9382
8ef4622d
PE
9383 * lisp.h (eassert): Check that the argument compiles, even if
9384 ENABLE_CHECKING is not defined.
9385
946f9a5b
PE
9386 * data.c (Findirect_variable): Name an expression, to avoid
9387 gcc -Wbad-function-cast warning.
112396d6 9388 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9389 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9390 (Fmake_variable_buffer_local, Fmake_local_variable):
9391 Mark variables as initialized.
52746918 9392 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9393
e5aab7e7 9394 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9395 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9396 Rename locals to avoid shadowing.
dff45157
PE
9397 (mark_stack): Move local variables into the #ifdef region where
9398 they're used.
7bc26fdb
PE
9399 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9400 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9401 needed otherwise.
9402 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9403 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9404 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9405
e5aab7e7
PE
9406 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9407 avoids undefined behavior in theory.
9408
4da60324
PE
9409 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9410
88043301
PE
9411 Use functions, not macros, for up- and down-casing (Bug#8254).
9412 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9413 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9414 to use the following functions instead of these macros.
9415 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9416 EMACS_INT, since callers assume the returned value fits in int.
9417 (upcase1): Likewise, for UPCASE_TABLE.
9418 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9419 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9420 the race-condition problem in the old DOWNCASE.
88043301 9421
19ed5445
PE
9422 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9423 Rename locals to avoid shadowing.
9424 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9425 (regex_compile, re_search_2, re_match_2_internal):
9426 Remove unused local vars.
952db0d7
PE
9427 (FREE_VAR): Rewrite so as not to use empty "else",
9428 which gcc can warn about.
da053e48 9429 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9430 (RETALLOC_IF): Define only if needed.
9431 (WORDCHAR_P): Likewise. This one is never needed, but is used
9432 only in a comment talking about a compiler bug, so put inside
9433 the #if 0 of that comment.
9434 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9435 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9436 Remove; unused.
19ed5445 9437
1f3561e4 9438 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9439 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9440 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9441
ded6f8f7
PE
9442 * search.c (simple_search): Remove unused var.
9443
dbd37a95
PE
9444 * dired.c (compile_pattern): Move decl from here ...
9445 * lisp.h: ... to here, so that it can be checked.
9446 (struct re_registers): New forward decl.
9447
7e47afad
PE
9448 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9449
85f24f61
PE
9450 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9451 All uses changed.
9452 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9453 Rename locals to avoid shadowing.
5671df8f 9454 (Fvertical_motion): Mark locals as initialized.
85f24f61 9455
181aa2be 9456 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9457 (casify_region): Mark local as initialized.
181aa2be 9458
930d429c
PE
9459 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9460
7082eac6
PE
9461 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9462 New macros, so that the caller can use some names other than
9463 gcpro1, gcpro2, etc.
9464 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9465 of the new macros.
9466 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9467 argument, for consistency with GCPRO2_VAR, etc: it is now the
9468 prefix of the variable, not the variable itself. All uses
9469 changed.
38b2c076
PE
9470 * dired.c (directory_files_internal, file_name_completion):
9471 Rename locals to avoid shadowing.
9472
15206ed9
PE
9473 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9474 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9475 dired.c's scmp function, had undefined behavior.
9476 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9477 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9478 * buffer.h: ... to here, because these macros use current_buffer,
9479 and the new implementation with inline functions needs to have
9480 current_buffer in scope now, rather than later when the macros
9481 are used.
9482 (downcase, upcase1): New static inline functions.
9483 (DOWNCASE, UPCASE1): Reimplement using these functions.
9484 This avoids undefined behavior in expressions like
9485 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9486 from race conditions in accessing the global variables
9487 case_temp1 and case_temp2.
9488 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9489 * lisp.h (case_temp1, case_temp2): Remove their decls.
9490 * character.h (ASCII_CHAR_P): Move from here ...
9491 * lisp.h: ... to here, so that the inline functions mentioned
9492 above can use them.
9493
4a6bea26
PE
9494 * dired.c (directory_files_internal_unwind): Now static.
9495
f14b7e14
PE
9496 * fileio.c (file_name_as_directory, directory_file_name):
9497 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9498 Now static.
2893f146
PE
9499 (file_name_as_directory): Use const pointers when appropriate.
9500 (Fexpand_file_name): Likewise. In particular, newdir might
9501 point at constant storage, so make it a const pointer.
fd4ead52 9502 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9503 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9504 signedness issues.
f839df0c
PE
9505 (Fset_file_times, Finsert_file_contents, auto_save_error):
9506 Rename locals to avoid shadowing.
f14b7e14 9507
5716756e 9508 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9509 (Ftry_completion, Fall_completions): Rename or remove locals
9510 to avoid shadowing.
5716756e 9511
b4c3046a
PE
9512 * marker.c (bytepos_to_charpos): Remove; unused.
9513
b45db522
PE
9514 * lisp.h (verify_bytepos, count_markers): New decls,
9515 so that gcc does not warn that these functions aren't declared.
9516
85876d07
PE
9517 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9518 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9519 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9520 (copy_text): Remove unused local var.
85876d07 9521
03d78a21 9522 * filelock.c (within_one_second): Now static.
b3dd38ab 9523 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9524
5df8f01b
PE
9525 * buffer.c (fix_overlays_before): Mark locals as initialized.
9526 (fix_start_end_in_overlays): Likewise. This function should be
9527 simplified by using pointers-to-pointers, but that's a different
9528 matter.
b1d876f1 9529 (switch_to_buffer_1): Now static.
8f54f30a
PE
9530 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9531 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9532
a70072c9 9533 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9534 Fix pointer signedness issue.
edced198
PE
9535 (sys_subshell): Mark local as volatile if checking for lint,
9536 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9537 (MAXPATHLEN): Define only if needed.
a70072c9 9538
a0977c44
PE
9539 * process.c (serial_open, serial_configure): Move decls from here ...
9540 * systty.h: ... to here, so that they can be checked.
9541
a884fdcc
PE
9542 * fns.c (get_random, seed_random): Move extern decls from here ...
9543 * lisp.h: ... to here, so that they can be checked.
9544
604efe86 9545 * sysdep.c (reset_io): Now static.
b8950c94 9546 (wait_for_termination_signal): Remove; unused.
604efe86 9547
38fc62d9
PE
9548 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9549 (copy_keymap_item, append_key, push_text_char_description):
9550 Now static.
1004a21a 9551 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9552 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9553 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9554 (describe_map_tree):
9555 Rename locals to avoid shadowing.
38fc62d9 9556
2f2650da
PE
9557 * keyboard.c: Declare functions static if they are not used elsewhere.
9558 (echo_char, echo_dash, cmd_error, top_level_2):
9559 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9560 (read_char, kbd_buffer_get_event, make_lispy_position):
9561 (make_lispy_event, make_lispy_movement, apply_modifiers):
9562 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9563 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9564 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9565 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9566 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9567
a053e86c 9568 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9569 (mark_kboards): Move decl here ...
9570 * alloc.c (mark_kboards): ... from here.
a053e86c 9571
4752793e
PE
9572 * lisp.h (force_auto_save_soon): New decl.
9573
74f10ca7 9574 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9575 (DEFINE_DUMMY_FUNCTION): New macro.
9576 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9577 Use it.
c03cd23f
PE
9578 (main): Add casts to avoid warnings
9579 if GCC considers string literals to be constants.
74f10ca7 9580
022e70d4
PE
9581 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9582
59d6fe83
PE
9583 * dbusbind.c: Pointer signedness fixes.
9584 (xd_signature, xd_append_arg, xd_initialize):
9585 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9586 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9587 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9588 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9589
78320123
PE
9590 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9591 if GCC considers string literals to be constants.
49cebcca 9592 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9593
35ac2a97
SM
95942011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9595
fb103ca9
SM
9596 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9597 (print_preprocess, print_object): New macro to fix last change.
9598
35ac2a97
SM
9599 * print.c (print_preprocess): Don't forget font objects.
9600
62973b41
JB
96012011-03-16 Juanma Barranquero <lekktu@gmail.com>
9602
9603 * emacs.c (USAGE3): Doc fixes.
9604
0e48bb22
AS
96052011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9606
9607 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9608 structure.
9609
7684e57b
JB
96102011-03-14 Juanma Barranquero <lekktu@gmail.com>
9611
9612 * lisp.h (VWindow_system, Qfile_name_history):
9613 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9614 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9615 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9616
9617 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9618 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9619
9620 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9621 * w32console.c (detect_input_pending, read_input_pending)
9622 (encode_terminal_code):
9623 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9624 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9625 (w32_system_caret_y, Qfile_name_history):
9626 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9627 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9628 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9629 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9630 * w32proc.c (Qlocal, report_file_error):
9631 * w32term.c (Vwindow_system, updating_frame):
9632 * w32uniscribe.c (initialized, uniscribe_font_driver):
9633 Remove unneeded extern declarations.
9634
2aa46d6c
CY
96352011-03-14 Chong Yidong <cyd@stupidchicken.com>
9636
c96bbc66 9637 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9638
cffc6f3b
CY
96392011-03-13 Chong Yidong <cyd@stupidchicken.com>
9640
9641 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9642 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9643 These macros can no longer be used for assignment.
9644
44f230aa
SM
9645 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9646 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9647 (record_buffer_markers, fetch_buffer_markers): New functions for
9648 recording and fetching special buffer markers.
9649 (set_buffer_internal_1, set_buffer_temp): Use them.
9650
9651 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9652
9653 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9654
9655 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9656 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9657
9658 * xdisp.c (hscroll_window_tree):
9659 (reconsider_clip_changes): Use PT instead of BUF_PT.
9660
d251f04b
EZ
96612011-03-13 Eli Zaretskii <eliz@gnu.org>
9662
9663 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9664 $(EMACS_ROOT)/lib/intprops.h.
9665
f0c77cd1
PE
96662011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9667
3eca4629
PE
9668 Fix more problems found by GCC 4.5.2's static checks.
9669
7c86ee98
PE
9670 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9671 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9672 (xg_free_frame_widgets): Make it clear that a local variable is
9673 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9674 (gdk_window_get_screen): Make it clear that this macro is needed
9675 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9676 (int_gtk_range_get_value): New function, which avoids a diagnostic
9677 from gcc -Wbad-function-cast.
9678 (xg_set_toolkit_scroll_bar_thumb): Use it.
9679 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9680 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9681 (get_utf8_string, xg_get_file_with_chooser):
9682 Rename locals to avoid shadowing.
9683 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9684
41729b81
PE
9685 * xgselect.c (xg_select): Remove unused var.
9686
f0c77cd1
PE
9687 * image.c (four_corners_best): Mark locals as initialized.
9688 (gif_load): Initialize transparent_p to zero (Bug#8238).
9689 Mark another local as initialized.
ec6cf4c6 9690 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9691
ce0ad53d 9692 * image.c (clear_image_cache): Now static.
d5d5a617 9693 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9694 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9695 (x_edge_detection): Remove unnecessary cast that
9696 gcc -Wbad-function-cast diagnoses.
2037898d 9697 (gif_load): Fix pointer signedness.
6ae141d6
PE
9698 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9699 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9700
33383987 97012011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9702
d32df629
PE
9703 Improve quality of tests for time stamp overflow.
9704 For example, without this patch (encode-time 0 0 0 1 1
9705 1152921504606846976) returns the obviously-bogus value (-948597
9706 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9707 reports time overflow. See
9708 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9709 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9710 * editfns.c: Include limits.h and intprops.h.
9711 (TIME_T_MIN, TIME_T_MAX): New macros.
9712 (time_overflow): Move earlier, to before first use.
9713 (hi_time, lo_time): New functions, for an accurate test for
9714 out-of-range times.
9715 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9716 (Fget_internal_run_time): Don't assume time_t fits in int.
9717 (make_time): Use list2 instead of Fcons twice.
9718 (Fdecode_time): More accurate test for out-of-range times.
9719 (check_tm_member): New function.
9720 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9721 (lisp_time_argument): Don't rely on undefined left-shift and
9722 right-shift behavior when checking for time stamp overflow.
8be6f318 9723
fe31d94c
PE
9724 * editfns.c (time_overflow): New function, refactoring common code.
9725 (Fformat_time_string, Fdecode_time, Fencode_time):
9726 (Fcurrent_time_string): Use it.
9727
8be6f318
PE
9728 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9729 * dired.c (make_time): Move to ...
9730 * editfns.c (make_time): ... here.
9731 * systime.h: Note the move.
9732
09d9db2c 97332011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9734
126bc0dc
YM
9735 * fringe.c (update_window_fringes): Remove unused variables.
9736
c47cbdfd
YM
9737 * unexmacosx.c (copy_data_segment): Also copy __got section.
9738 (Bug#8223)
9739
7ac80be9
EZ
97402011-03-12 Eli Zaretskii <eliz@gnu.org>
9741
c96bbc66 9742 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9743 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9744 Constify `char *' arguments and their references according to
9745 prototypes in tparam.h.
9746
ecb0f94d 9747 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9748
7ac80be9
EZ
9749 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9750 Adapt all references accordingly.
9751
9752 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9753
ef1fd07e
TT
97542011-03-11 Tom Tromey <tromey@redhat.com>
9755
9756 * buffer.c (syms_of_buffer): Remove obsolete comment.
9757
7ef4b50c
EZ
97582011-03-11 Eli Zaretskii <eliz@gnu.org>
9759
9760 * termhooks.h (encode_terminal_code): Declare prototype.
9761
9762 * msdos.c (encode_terminal_code): Don't declare prototype.
9763
9764 * term.c (encode_terminal_code): Now external again, used by
9765 w32console.c and msdos.c.
9766
44f230aa
SM
9767 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9768 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9769
4b1ec863 97702011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9771
1714f52b 9772 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9773
4b1ec863
PE
9774 * fringe.c (update_window_fringes): Mark locals as initialized
9775 (Bug#8227).
9776 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9777
524c7aa6
PE
9778 * alloc.c (mark_fringe_data): Move decl from here ...
9779 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9780 to check its interface.
9781 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9782
a5c0af81 9783 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9784 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9785 (fontset_font): Mark local as initialized.
a9a06e0b 9786 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9787
b4716021
PE
9788 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9789
811e9bac 9790 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9791 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9792 (x_own_selection, Fx_disown_selection_internal): Rename locals
9793 to avoid shadowing.
9794 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9795
7e3ab302
PE
9796 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9797 so that the caller can use some name other than gcpro1.
9798 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9799 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9800 (Fx_backspace_delete_keys_p):
9801 Use them to avoid shadowing, and rename vars to avoid shadowing.
9802 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9803 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9804 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9805 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9806 Remove unused locals.
7e3ab302
PE
9807 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9808 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9809 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9810 macros.
f78faa98 9811
e2b13473
PE
9812 * xterm.h (x_mouse_leave): New decl.
9813
77f23912
PE
9814 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9815 Remove unused functions.
cdf4ba58
PE
9816 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9817 (x_calc_absolute_position): Now static.
7411c686 9818 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9819 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9820 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9821 unless they are used.
38d0b34a
PE
9822 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9823 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9824 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9825 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9826 (x_error_catcher, x_connection_closed, x_error_handler):
9827 (x_error_quitter, xembed_send_message, x_iconify_frame):
9828 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9829 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9830 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9831
44f230aa
SM
9832 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9833 Rename or move locals to avoid shadowing.
6b463e58 9834 (tty_defined_color, merge_face_heights): Now static.
5967d051 9835 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9836 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9837 does not deduce is never used uninitialized.
73719eba
PE
9838 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9839 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9840
426994c3 9841 * terminal.c (store_terminal_param): Now static.
5489860b 9842
032f1620 9843 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9844 (set_frame_menubar): Remove unused local.
d4323972 9845 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9846 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9847 since they might point to immutable storage.
281585b0
PE
9848 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9849 since it's unused otherwise.
032f1620 9850
367c19e5 9851 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9852 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9853 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9854 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9855 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9856 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9857 does not deduce are never used uninitialized.
70739cbe 9858
07b48fa9
PE
9859 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9860
8868a238 9861 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9862 * window.c (window_loop, size_window):
9863 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9864
7e5cf297 9865 * window.c (display_buffer): Now static.
d6550a9f
PE
9866 (size_window): Mark variables that gcc -Wuninitialized
9867 does not deduce are never used uninitialized.
a586633d
PE
9868 * window.h (check_all_windows): New decl, to forestall
9869 gcc -Wmissing-prototypes diagnostic.
5b555da1 9870 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9871
f6095868
PE
9872 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9873 shadowing.
9874 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9875 Include <limits.h>.
9876 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9877 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9878 (load_charset_map): Mark variables that gcc -Wuninitialized
9879 does not deduce are never used uninitialized.
53df7c11 9880 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9881
f38b440c
PE
9882 * coding.c (coding_set_source, coding_set_destination):
9883 Use "else { /* comment */ }" rather than "else /* comment */;"
9884 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9885 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9886 a block, when the outer 'i' will do.
9887 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9888 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9889 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9890 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9891 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9892 Rename locals to avoid shadowing.
9893 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9894 * coding.c (emacs_mule_char, encode_invocation_designation):
9895 Now static, since they're not used elsewhere.
413bb2db 9896 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9897 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9898 (decode_coding_emacs_mule): Mark variables that gcc
9899 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9900 (detect_coding_iso_2022): Initialize a local variable that might
9901 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9902 this initialization is needed. (Bug#8211)
5f58e762
PE
9903 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9904 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9905 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9906 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9907 Remove unused macros.
f38b440c 9908
232b38b9 9909 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9910 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9911 * character.c (string_count_byte8): Likewise.
232b38b9 9912
fb90da1b
PE
9913 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9914 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9915
fb93dbc2
PE
9916 * chartab.c (copy_sub_char_table): Now static, since it's not used
9917 elsewhere.
5c156ace
PE
9918 (sub_char_table_ref_and_range, char_table_ref_and_range):
9919 Rename locals to avoid shadowing.
bbcd0949 9920 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9921
7d3b3862 9922 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9923 (BIDI_BOB): Remove unused macro.
7d3b3862 9924
6be7d3da
PE
9925 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9926 deduce are never used uninitialized.
c2ed9c8b 9927 * term.c (encode_terminal_code): Likewise.
6be7d3da 9928
75f8807f 9929 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9930
50938595
PE
9931 * tparam.h: New file.
9932 * term.c, tparam.h: Include it.
9933 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9934 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9935 Move these decls to tparam.h, and make them agree with what
9936 is actually in tparam.c. The previous trick of using incompatible
9937 decls in different modules does not conform to the C standard.
9938 All callers of tparam changed to use tparam's actual API.
9939 * tparam.c (tparam1, tparam, tgoto):
9940 Use const pointers where appropriate.
9941
fbceeba2
PE
9942 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9943 * cm.h (struct cm): Likewise.
9944 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9945 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9946 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9947 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9948 (turn_on_face, init_tty): Likewise.
9949 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9950
7f3f1250
PE
9951 * term.c (term_mouse_position): Rename local to avoid shadowing.
9952
e6ca6543
PE
9953 * alloc.c (mark_ttys): Move decl from here ...
9954 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9955
c40f8d15
AS
99562011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9957
9958 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9959
cfe0661d
JB
99602011-03-09 Juanma Barranquero <lekktu@gmail.com>
9961
9962 * search.c (compile_pattern_1): Remove argument regp, unused since
9963 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9964 (compile_pattern): Don't pass it.
9965
0afb4571
J
99662011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9967
9968 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9969 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9970 for ! HAVE_GTK3.
9971 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9972
9973 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9974
9975 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9976 gdk_window_get_screen, gdk_window_get_geometry,
9977 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9978 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9979 (xg_get_pixbuf_from_pixmap): New function.
9980 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9981 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9982 Call xg_get_pixbuf_from_pixmap instead of
9983 gdk_pixbuf_get_from_drawable.
9984 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9985 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9986 (xg_check_special_colors): Use GtkStyleContext and its functions
9987 for HAVE_GTK3.
9988 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9989 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9990 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9991 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9992 Call gtk_widget_get_preferred_size.
0afb4571
J
9993 (xg_frame_resized): gdk_window_get_geometry only takes 5
9994 parameters.
44f230aa
SM
9995 (xg_win_to_widget, xg_event_is_for_menubar):
9996 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9997 (xg_set_widget_bg): New function.
9998 (delete_cb): New function.
895009e1 9999 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 10000 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
10001 (xg_set_background_color): Call xg_set_widget_bg.
10002 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10003 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10004 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10005 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10006 if ! HAVE_GTK3.
10007 (update_frame_tool_bar): Call gtk_widget_hide.
10008 (xg_initialize): Use GDK_KEY_g.
10009
10010 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10011 if ! HAVE_GTK3
10012 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10013
10014 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10015 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10016 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10017
1c2cc4ef
JB
100182011-03-08 Juanma Barranquero <lekktu@gmail.com>
10019
10020 * w32xfns.c (select_palette): Check success of RealizePalette against
10021 GDI_ERROR, not zero.
10022
33383987 10023See ChangeLog.11 for earlier changes.
aac0c6e3
MR
10024
10025;; Local Variables:
10026;; coding: utf-8
aac0c6e3
MR
10027;; End:
10028
2f097256 10029 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
10030
10031 This file is part of GNU Emacs.
10032
10033 GNU Emacs is free software: you can redistribute it and/or modify
10034 it under the terms of the GNU General Public License as published by
10035 the Free Software Foundation, either version 3 of the License, or
10036 (at your option) any later version.
10037
10038 GNU Emacs is distributed in the hope that it will be useful,
10039 but WITHOUT ANY WARRANTY; without even the implied warranty of
10040 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10041 GNU General Public License for more details.
10042
10043 You should have received a copy of the GNU General Public License
10044 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.