* alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
[bpt/emacs.git] / src / ChangeLog
CommitLineData
296094c3
DA
12012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2
3 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
4 is enabled, avoid dereferencing NULL current_sblock if
5 running undumped.
6
36429c89
DA
72012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
8
9 Cleanup basic buffer management.
10 * buffer.h (struct buffer): Change layout to use generic vector
11 marking code. Fix some comments. Change type of 'clip_changed'
12 to bitfield. Remove unused #ifndef old.
13 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
14 (GET_OVERLAYS_AT): Fix indentation.
15 (for_each_per_buffer_object_at): New macro.
16 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
17 (Fbuffer_local_variables): Use it.
18 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
19 * alloc.c (allocate_buffer): Adjust to match new layout of
20 struct buffer. Fix comment.
21 (mark_overlay): New function.
22 (mark_buffer): Use it. Use mark_vectorlike to mark normal
23 Lisp area of struct buffer.
24 (mark_object): Use it. Adjust marking of misc objects
25 and related comments.
26
3b3e4cac
PE
272012-07-02 Paul Eggert <eggert@cs.ucla.edu>
28
29 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
30 wrapper that is not needed because the wrapped code is a no-op (zero
31 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
32 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
33
cf5c0175
DA
342012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
35
36 * alloc.c (mark_buffer): Simplify. Remove prototype.
37 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 38 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
39 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
40 redundant calls to mark_vectorlike for bool vectors.
41
ca26824c
GM
422012-06-30 Glenn Morris <rgm@gnu.org>
43
2e4c5312
GM
44 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
45
ca26824c
GM
46 * epaths.in (PATH_SITELOADSEARCH): New.
47 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
48 This is rather than relying on --enable-locallisppath elements
49 having "site-lisp" in their names. (Bug#10208#25, 11658)
50
0d23c240
EZ
512012-06-30 Eli Zaretskii <eliz@gnu.org>
52
c9240d7a
EZ
53 * w32proc.c (sys_select): Accept and ignore one more argument.
54
55 * w32.c (emacs_gnutls_pull): Call select with one more argument.
56
0d23c240 57 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 58 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
59
60 * sysdep.c: Don't include dos.h and dosfns.h.
61
62 * process.c (sys_select):
63 * msdos.c (sys_select): Accept one more argument and ignore it.
64
65 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
66 adapt data types and code to that.
67
68 * dosfns.c:
69 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
70 which clashes with the gnulib function of the same name.
71
af5a5a98
AS
722012-06-30 Andreas Schwab <schwab@linux-m68k.org>
73
c5e4379c
AS
74 * font.c (font_style_to_value, font_style_symbolic)
75 (font_prop_validate_style): Add type checks for values in
76 font_style_table.
77
af5a5a98
AS
78 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
79 argument.
80 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
81 uses.
82
8d38f461
EZ
832012-06-29 Eli Zaretskii <eliz@gnu.org>
84
2e5a6631
EZ
85 * xdisp.c (try_window_id): Undo last change.
86
8d38f461
EZ
87 * w32.c (getwd): Adjust commentary about startup_dir.
88 (init_environment): Always call sys_access, even in non-MSVC
89 builds. Don't chdir to the directory of the Emacs executable.
90 This undoes code from 1997 which was justified by the need to
91 "avoid conflicts when removing and renaming directories". But its
92 downside was that every relative file name was being interpreted
93 relative to the directory of the Emacs executable, which can never
94 be TRT. In particular, it broke sys_access when called with
95 relative file names.
96 (sys_access): Map GetLastError to errno.
97
2af3565e
DA
982012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
99
100 * window.h (struct window): Change type of 'fringes_outside_margins'
101 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 102 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
103 Adjust comment.
104 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
105 to ptrdiff_t.
106
c8d3a25c 1072012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 108
c8d3a25c
GM
109 * gnutls.c (emacs_gnutls_handshake):
110 Add QUIT to make the loop interruptible.
57570cd3 111
c8d3a25c 1122012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 113
c8d3a25c
GM
114 * charset.c (init_charset): Make lack of etc/charsets fatal.
115
3e984ee8
DA
1162012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
117
118 * editfns.c (region_limit): Fix type mismatch.
119
ef884f23
DA
1202012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
121
122 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
123 undefined. Convert from xassert to eassert.
124 * nsmenu.m: Convert from xassert to eassert.
125 * nsterm.m: Likewise.
126
7d7e0027
SM
1272012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
128
129 * editfns.c (region_limit): Clip to narrowing (bug#11770).
130
aa754e6a
PE
1312012-06-28 Paul Eggert <eggert@cs.ucla.edu>
132
133 Avoid integer overflow on scroll-left and scroll-right.
134 * window.c (HSCROLL_MAX): New macro.
135 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
136 overflow when requested scroll falls outside ptrdiff_t range.
137
80b00b08
DA
1382012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
139
140 * window.h (struct window): Change type of 'hscroll',
141 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
142 'last_modified' and 'last_overlay_modified' to EMACS_INT.
143 Adjust users accordingly.
144 * xdisp.c (try_cursor_movement): Replace type check with eassert.
145 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
146 from EMACS_INT to ptrdiff_t.
147 (make_window): Omit redundant initialization.
148
62b2bcf6
JB
1492012-06-28 Juanma Barranquero <lekktu@gmail.com>
150
151 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
152
45942c7d
DA
1532012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
154
155 * window.h (struct window): Change type of 'use_time' and
156 'sequence_number' from Lisp_Object to int.
157 * frame.c (make_frame): Adjust users accordingly.
158 * print.c (print_object): Likewise.
159 * window.c (select_window, Fwindow_use_time, make_parent_window)
160 (make_window): Likewise.
161
e509cfa6
DA
1622012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
163
164 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
165 enabled with --enable-checking=[all,glyphs] configure option.
166 Fix GLYPH_DEBUG usage assuming that it may be undefined,
167 adjust comments accordingly.
168 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
169 undefined, adjust comments accordingly.
170 * image.c: Likewise.
171 * scroll.c: Likewise.
172 * w32fns.c: Likewise.
173 * w32term.c: Likewise.
174 * xdisp.c: Likewise.
175 * xfaces.c: Likewise.
176 * xfns.c: Likewise.
177 * xterm.c: Likewise.
178
a54e2c05
DA
1792012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
180
181 Generalize run-time debugging checks.
182 * dispextern.h (XASSERTS): Remove.
183 * fontset.c (xassert): Remove.
184 Convert from xassert to eassert.
185 * alloc.c: Convert from xassert to eassert.
186 * bidi.c: Likewise.
187 * dispnew.c: Likewise.
188 * fns.c: Likewise.
189 * fringe.c: Likewise.
190 * ftfont.c: Likewise.
191 * gtkutil.c: Likewise.
192 * image.c: Likewise.
193 * keyboard.c: Likewise.
194 * menu.c: Likewise.
195 * process.c: Likewise.
196 * scroll.c: Likewise.
197 * sound.c: Likewise.
198 * term.c: Likewise.
199 * w32console.c: Likewise.
200 * w32fns.c: Likewise.
201 * w32term.c: Likewise.
202 * window.c: Likewise.
203 * xdisp.c: Likewise.
204 * xfaces.c: Likewise.
205 * xfns.c: Likewise.
206 * xselect.c: Likewise.
207 * xterm.c: Likewise.
208
1ec4b7b2
SM
2092012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
210
211 * fns.c (maybe_resize_hash_table): Output message when growing the
212 purify-hashtable.
213
2014308a
DA
2142012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
215
216 * alloc.c (allocate_string_data): Remove dead code.
217 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
218 avoid GCC warning about unused macro.
219
246155eb
DA
2202012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
221
222 * alloc.c (allocate_string): Omit intervals initialization.
223 * alloc.c (make_uninit_multibyte_string): Initialize intervals
224 as in make_pure_string and make_pure_c_string.
225
43184b7b
DA
2262012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
227
228 * alloc.c (allocate_string): Fix last change.
229
3fe6dd74
DA
2302012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
231
232 * alloc.c (allocate_string): Remove two redundant calls
233 to memset, add explicit initialization where appropriate.
234
1ba6038a
GM
2352012-06-27 Glenn Morris <rgm@gnu.org>
236
237 * lisp.mk (lisp): Remove paths.elc.
238
c89926a5
CY
2392012-06-27 Chong Yidong <cyd@gnu.org>
240
241 * doc.c (Fsubstitute_command_keys): Fix punctuation.
242
ed6b3510
JW
2432012-06-26 John Wiegley <johnw@newartisans.com>
244
1ec4b7b2 245 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
246 on Mac OS X Lion: __mod_init_func and __mod_term_func.
247
ed6b3510
JW
248 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
249 when building with Clang.
250
8edd4a2b
SM
2512012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
252
253 * eval.c (Fapply): Allow calling it with a single argument.
254
f6f62d1b
EZ
2552012-06-26 Eli Zaretskii <eliz@gnu.org>
256
257 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
258 _stricmp and _strnicmp.
259 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
260
62efea5e
DA
2612012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
262
263 * alloc.c (allocate_window): Zero out non-Lisp part of newly
264 allocated window.
265 (allocate_process): Likewise for new process.
8edd4a2b 266 (allocate_terminal): Change to use offsetof.
62efea5e
DA
267 (allocate_frame): Likewise.
268 * frame.c (make_frame): Omit redundant initialization.
269 * window.c (make_parent_window): Use memset.
270 (make_window): Omit redundant initialization.
271 * process.c (make_process): Omit redundant initialization.
272 * terminal.c (create_terminal): Likewise.
273
42997f4d
DA
2742012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
275
276 * term.c (delete_tty): Remove redundant call to memset.
277
1130ecfc
DA
2782012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
279
280 * alloc.c: Remove build_string.
281 * lisp.h: Define build_string as static inline. This provides
282 a better opportunity to optimize away calls to strlen when the
283 function is called with compile-time constant argument.
284 * image.c (imagemagick_error): Convert to build_string.
285 * w32proc.c (sys_spawnve): Likewise.
286 * xterm.c (x_term_init): Likewise.
287
cf38a720
PE
2882012-06-26 Paul Eggert <eggert@cs.ucla.edu>
289
99027bdd
PE
290 Use sprintf return value instead of invoking strlen on result.
291 In the old days this wasn't portable, since some sprintf
292 implementations returned char *. But they died out years ago and
293 Emacs already assumes sprintf returns int.
294 Similarly for float_to_string.
295 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
296 * ccl.c (ccl_driver):
297 * character.c (string_escape_byte8):
298 * data.c (Fnumber_to_string):
299 * doprnt.c (doprnt):
300 * print.c (print_object):
301 * xdisp.c (message_dolog):
302 * xfns.c (syms_of_xfns):
303 Use sprintf or float_to_string result to avoid need to call strlen.
304 * data.c (Fnumber_to_string):
305 Use make_unibyte_string, since the string must be ASCII.
306 * lisp.h, print.c (float_to_string): Now returns int length.
307 * term.c (produce_glyphless_glyph):
308 Use sprintf result rather than recomputing it.
309
cf38a720
PE
310 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
311 * Makefile.in (ALL_CFLAGS):
312 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
313 * gmalloc.c, regex.c: Include <config.h> unconditionally.
314
3511c784
DA
3152012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
316
0a08eb21 317 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
318 strcasecmp if available.
319 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
320
fb7da12e
AS
3212012-06-25 Andreas Schwab <schwab@linux-m68k.org>
322
323 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
324 Avoid comma operator.
325 * menu.c (push_submenu_start, push_submenu_end)
326 (push_left_right_boundary, push_menu_pane): Likewise.
327 * msdos.c (dos_rawgetc): Likewise.
328
afa2ffd8
DA
3292012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
330
331 * xfns.c (xic_create_fontsetname): Remove redundant calls
332 to memset.
333
b3b4476b
PE
3342012-06-25 Paul Eggert <eggert@cs.ucla.edu>
335
4495ff38
PE
336 * gtkutil.c (get_utf8_string): Remove redundant assignment.
337 sprintf already null-terminates its output.
338
b3b4476b
PE
339 * xfns.c (x_window): Remove redundant cast.
340
b00876c9
DA
3412012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
342
343 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
344 `const char *' to `char *' to avoid compiler warning.
345
d188e26b
PE
3462012-06-24 Paul Eggert <eggert@cs.ucla.edu>
347
885d1d74
PE
348 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
349 instead of truncating it to 63 (admittedly a generous limit).
350
d188e26b
PE
351 * process.c: Fix spelling and caps in comments.
352
e2f560b1
DN
3532012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
354
e86db54b 355 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
356 * sysdep.c (setpgrp): Remove definition, not used in this file.
357
7583a3a1
JB
3582012-06-24 Juanma Barranquero <lekktu@gmail.com>
359
360 * makefile.w32-in: Update dependencies.
361
696056c2
EZ
3622012-06-24 Eli Zaretskii <eliz@gnu.org>
363
364 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
365 (SYSTIME_H): Add nt/inc/sys/time.h.
366
367 * systime.h [WINDOWSNT]: Include sys/time.h.
368
369 * s/ms-w32.h (struct timespec): Definition moved from
370 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
371
845ca893
PE
3722012-06-24 Paul Eggert <eggert@cs.ucla.edu>
373
374 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
375 * buffer.h (buffer_slot_type_mismatch):
376 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
377 * eval.c (unwind_to_catch):
378 * image.c (my_png_error, my_error_exit):
379 * keyboard.c (quit_throw_to_read_char, user_error)
380 (Fexit_recursive_edit, Fabort_recursive_edit):
381 * lisp.h (die, args_out_of_range, args_out_of_range_3)
382 (wrong_type_argument, buffer_overflow, __executable_start)
383 (memory_full, buffer_memory_full, string_overflow, Fthrow)
384 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
385 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
386 (fatal):
387 (child_setup) [!DOS_NT]:
388 * lread.c (end_of_file_error, invalid_syntax):
389 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
390 * puresize.h (pure_write_error):
391 * search.c (matcher_overflow):
392 * sound.c (sound_perror, alsa_sound_perror):
393 * sysdep.c, syssignal.h (croak):
394 * term.c (maybe_fatal, vfatal):
395 * textprop.c (text_read_only):
396 * undo.c (user_error):
397 * unexmacosx.c (unexec_error):
398 * xterm.c (x_ins_del_lines, x_delete_glyphs):
399 Use _Noreturn rather than NO_RETURN.
400 No need for separate decl merely because of _Noreturn.
401 * sound.c (sound_warning, parse_sound):
402 Remove unnecessary forward decls.
403
f1dd8073
PE
4042012-06-24 Paul Eggert <eggert@cs.ucla.edu>
405
406 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
407 * lisp.h (WAIT_READING_MAX): New macro.
408 * dispnew.c (Fsleep_for, sit_for):
409 * keyboard.c (kbd_buffer_get_event):
410 * process.c (Faccept_process_output):
411 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
412 This improves on the previous patch, which introduced a bug
413 when time_t is unsigned and as wide as intmax_t.
414 See <http://bugs.gnu.org/9000#51>.
415
b82c1755
EZ
4162012-06-23 Eli Zaretskii <eliz@gnu.org>
417
418 * dispnew.c (sit_for, Fsleep_for):
419 * keyboard.c (kbd_buffer_get_event):
420 * process.c (Faccept_process_output): Avoid compiler warnings when
421 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
422
ca300656
JB
4232012-06-23 Juanma Barranquero <lekktu@gmail.com>
424
049ec95b
JB
425 * makefile.w32-in: Update dependencies.
426
ca300656
JB
427 * w32.c (ltime): Add return type and declare static.
428 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
429
db7b8d06
PE
4302012-06-23 Paul Eggert <eggert@cs.ucla.edu>
431
432 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
433 Privately reported by Herbert J. Skuhra.
434 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
435 All uses changed.
436 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
437 not make_lisp_timeval, when the argument is of type EMACS_TIME.
438
0bd8297f
EZ
4392012-06-23 Eli Zaretskii <eliz@gnu.org>
440
96512555
EZ
441 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
442 last argument of make_unibyte_string.
443
0bd8297f
EZ
444 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
445 language ID in the event parameters.
446
447 * w32term.c (w32_read_socket): Put the new keyboard codepage into
448 event.code, not the obscure "character set ID".
449
63def6b6
CY
4502012-06-23 Chong Yidong <cyd@gnu.org>
451
452 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
453
e8a02204
EZ
4542012-06-23 Eli Zaretskii <eliz@gnu.org>
455
388cdec0
EZ
456 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
457 * w32.c (fdutimens): New function.
458
459 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
460
461 * s/ms-w32.h (pselect): Redirect to sys_select.
462
463 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
464
e8a02204
EZ
465 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
466 in the logic of incrementing and decrementing the value of
467 use_relocatable_buffers.
468
d054f3fb
PE
4692012-06-23 Paul Eggert <eggert@cs.ucla.edu>
470
471 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
472 Privately reported by Herbert J. Skuhra.
473 [__FreeBSD__]: Remove "*/" typo after "#include".
474 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
475 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
476 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
477 Don't assume EMACS_TIME and struct timeval are the same type.
478
d35af63c
PE
4792012-06-22 Paul Eggert <eggert@cs.ucla.edu>
480
481 Support higher-resolution time stamps (Bug#9000).
482 The time stamps are only nanosecond-resolution at the C level,
483 since that's the best that any real-world system supports now.
484 But they are picosecond-resolution at the Lisp level, as that's
485 easy, and leaves room for future OS improvements.
486
487 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
488 (LIBES): Use it.
489
490 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
491 Don't get current time unless it's needed.
492
493 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
494 now provides it if it's absent.
495 (start_atimer): Port to higher-res time stamps.
496 Check for time stamp overflow. Don't get current time more
497 often than is needed.
498
499 * buffer.h (struct buffer): Buffer modtime now has high resolution.
500 Include systime.h, not time.h.
501 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
502
503 * dired.c: Include stat-time.h.
504 (Ffile-attributes): File times now have higher resolution.
505
506 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
507 (struct image): Timestamp now has higher resolution.
508
509 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
510 has at least microseconds now. All uses removed.
511 (update_frame, update_single_window, update_window, update_frame_1)
512 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
513
514 * editfns.c (time_overflow): Now extern.
515 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
516 (float-time, Fformat_time_string, Fcurrent_time_string)
517 (Fcurrent_time_zone): Accept and generate higher-resolution
518 time stamps.
519 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
520 (decode_time_components, lisp_seconds_argument): New functions.
521 (make_time): Now static.
522 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
523 Report an error if the time is invalid, rather than having the caller
524 do that.
525
526 * fileio.c: Include <stat-time.h>
527 (Fcopy_file): Copy higher-resolution time stamps.
528 Prefer to set the time stamp via a file descriptor if that works.
529 (Fset_file_times, Finsert_file_contents, Fwrite_region)
530 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
531 (Fvisited_file_modtime, Fset_visited_file_modtime):
532 Support higher-resolution time stamps.
533
534 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
535
536 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
537
538 * image.c (prepare_image_for_display, clear_image_cache)
539 (lookup_image): Port to higer-resolution time stamps.
540
541 * keyboard.c (start_polling, bind_polling_period):
542 Check for time stamp overflow.
543 (read_char, kbd_buffer_get_event, timer_start_idle)
544 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
545 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
546 Port to higher-resolution time stamps. Do not assume time_t is signed.
547 (decode_timer): New function. Timers are now vectors of length 9,
548 not 8, to accommodate the picosecond component.
549 (timer_check_2): Use it.
550
551 * nsterm.m (select_timeout, timeval_subtract): Remove.
552 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
553 as they're a bit more accurate and handle overflow better.
554 (ns_select): Change prototype to be compatible with pselect.
555 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
556 * nsterm.h (ns_select): Adjust prototype.
557
558 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
559 us-resolution time stamps.
560 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
561
562 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
563
564 * lisp.h (time_overflow): New decl.
565 (wait_reading_process_output): First arg is now intmax_t, not int,
566 to accommodate larger waits.
567
568 * process.h (struct Lisp_Process.read_output_delay):
569 Now counts nanoseconds, not microseconds.
570 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
571 EMACS_HAS_USECS.
572 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
573 (wait_reading_process_output):
574 Port to ns-resolution time stamps.
575 (Faccept_process_output, wait_reading_process_output):
576 Check for time stamp overflow. Do not assume time_t is signed.
577 (select_wrapper): Remove; we now use pselect.
578 (Fprocess_attributes): Now generates ns-resolution time stamps.
579
580 * sysdep.c: Include utimens.h. Don't include utime.h
581 or worry about struct utimbuf; gnulib does that for us now.
582 (gettimeofday): Remove; gnulib provides a substitute.
583 (make_timeval): New function.
584 (set_file_times): Now sets ns-resolution time stamps.
585 New arg FD; all uses changed.
586 (time_from_jiffies, ltime_from_jiffies, get_up_time)
587 (system_process_attributes):
588 Now returns ns-resolution time stamp. All uses changed.
589 Check for time stamp overflow.
590
591 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
592 provides a substitute now.
593
594 * systime.h: Include timespec.h rather than sys/time.h and time.h,
595 since it guarantees struct timespec.
596 (EMACS_TIME): Now struct timespec, so that we can support
597 ns-resolution time stamps.
598 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
599 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
600 (EMACS_USECS): Remove.
601 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
602 so multiply the arg by 1000 before storing it.
603 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
604 New macros.
605 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
606 Port to ns-resolution time stamps.
607 (EMACS_TIME_NEG_P): Remove; replaced by....
608 (EMACS_TIME_SIGN): New macro.
609 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
610 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
611 (set_file_times, make_time, lisp_time_argument): Adjust signature.
612 (make_timeval, make_lisp_time, decode_time_components): New decls.
613 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
614 that it mishandled time_t overflow. You can't compare by subtracting!
615 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
616 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
617
618 * term.c: Include <sys/time.h>.
619 (timeval_to_Time): New function, for proper overflow wraparound.
620 (term_mouse_position, term_mouse_click): Use it.
621
622 * undo.c (record_first_change): Support higher-resolution time stamps
623 in the undo buffer.
624 (Fprimitive_undo): Use them when restoring time stamps.
625
626 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
627 (w32_get_internal_run_time):
628 Port to higher-resolution Emacs time stamps.
629 (ltime): Now accepts single 64-bit integer, as that's more convenient
630 for callers.
631
632 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
633
634 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
635 for compatibility with pselect. Support ns-resolution time stamps.
636
637 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
638
639 * xselect.c (wait_for_property_change, x_get_foreign_selection):
640 Check for time stamp overflow, and support ns-resolution time stamps.
641
642 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
643 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
644 (timeval_subtract): Remove; no longer needed.
645 (XTflash, XTring_bell, x_wait_for_event):
646 Port to ns-resolution time stamps. Don't assume time_t is signed.
647
b6a92dfe
CY
6482012-06-22 Chong Yidong <cyd@gnu.org>
649
650 * xdisp.c (x_consider_frame_title): Revert last change.
651
d251c37c
EZ
6522012-06-22 Eli Zaretskii <eliz@gnu.org>
653
654 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
655 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
656 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
657 staticidx goes up to 1597 out of 1600 = 0x640.)
658
f10deafb
PE
6592012-06-20 Paul Eggert <eggert@cs.ucla.edu>
660
661 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
662 Otherwise, the umask might be mistakenly 0 while handling input signals.
663
ec6de1e2
SM
6642012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
665
666 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
667
28be1ada
DA
6682012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
669
670 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
671 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
672 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
673 access to `contents' member of Lisp_Vector objects with AREF and ASET
674 where appropriate.
675
c6bf3022
CY
6762012-06-19 Chong Yidong <cyd@gnu.org>
677
678 * frame.c (delete_frame): When selecting a frame on a different
679 text terminal, do not alter the terminal's top-frame.
680
681 * xdisp.c (format_mode_line_unwind_data): Record the target
682 frame's selected window and its terminal's top-frame.
683 (unwind_format_mode_line): Restore them.
684 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
685 Callers changed.
686 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
687 since tty frames can be explicitly named.
688 (prepare_menu_bars): Likewise.
689
690 * term.c (Ftty_top_frame): New function.
691
defd4196
PE
6922012-06-18 Paul Eggert <eggert@cs.ucla.edu>
693
694 Port byte-code-meter to modern targets.
695 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
696 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 697 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
698 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
699 (METER_1, METER_2): Simplify.
700
1053a871
SM
7012012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
702
703 * data.c (Fdefalias): Return `symbol' (bug#11686).
704
b7e8d081
MR
7052012-06-18 Martin Rudalics <rudalics@gmx.at>
706
707 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
708 gets killed during executing of this function (Bug#11665).
709 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
710 (Vkill_buffer_query_functions): In doc-string say that functions
711 run by this hook should not change the current buffer.
712
7ea2b339
PE
7132012-06-18 Paul Eggert <eggert@cs.ucla.edu>
714
715 Fix recently-introduced process.c problems found by static checking.
716 * process.c (write_queue_push, write_queue_pop, send_process):
717 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
718 (write_queue_pop): Fix pointer signedness problem.
719 (send_process): Remove unused local.
720
96a313a1
CY
7212012-06-17 Chong Yidong <cyd@gnu.org>
722
723 * xdisp.c (redisplay_internal): No need to redisplay terminal
724 frames that are not on top.
725
20ca2e94
TN
7262012-06-17 Troels Nielsen <bn.troels@gmail.com>
727
728 * process.c (make_process): Initialize write_queue.
729 (write_queue_push, write_queue_pop): New functions.
730 (send_process): Use them to maintain correct ordering of process
731 writes (Bug#10815).
732
9a900ca9
PE
7332012-06-17 Paul Eggert <eggert@cs.ucla.edu>
734
310fbfa8
PE
735 * lisp.h (eassert): Assume C89 or later.
736 This removes the need for CHECK.
737 (CHECK): Remove. Its comments about always evaluating its
738 argument were confusing, as 'eassert' typically does not evaluate
739 its argument.
740
27bb1ca4
PE
741 * coding.c (produce_chars): Use ptrdiff_t, not int.
742
9a900ca9
PE
743 * xterm.c (x_draw_underwave): Check for integer overflow.
744 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
745
41b7f8bc 7462012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
747
748 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
749 referenced (Bug#11583).
750
9b0e3eba
AA
7512012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
752
753 Implement wave-style variant of underlining.
754 * dispextern.h (face_underline_type): New enum.
755 (face): Add field for underline type.
756 * nsterm.m (ns_draw_underwave): New function.
757 (ns_draw_text_decoration): Use it.
758 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
759 New functions.
760 (x_draw_glyph_string): Use them.
761 * xfaces.c (Qline, Qwave): New Lisp objects.
762 (check_lface_attrs, merge_face_ref)
1053a871
SM
763 (Finternal_set_lisp_face_attribute, realize_x_face):
764 Handle wave-style underline face attributes.
9b0e3eba
AA
765 * xterm.c (x_draw_underwave): New function.
766 (x_draw_glyph_string): Use it.
767
0fb52f11
JB
7682012-06-16 Juanma Barranquero <lekktu@gmail.com>
769
770 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
771 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
772 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
773 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
774 ($(BLD)/w32select.$(O)): Update dependencies.
775
e5560ff7
AS
7762012-06-16 Andreas Schwab <schwab@linux-m68k.org>
777
778 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
779 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
780 * character.c (_fetch_multibyte_char_p): Remove.
781 * alloc.c: Include "character.h" before "buffer.h".
782 * bidi.c: Likewise.
783 * buffer.c: Likewise.
784 * bytecode.c: Likewise.
785 * callint.c: Likewise.
786 * callproc.c: Likewise.
787 * casefiddle.c: Likewise.
788 * casetab.c: Likewise.
789 * category.c: Likewise.
790 * cmds.c: Likewise.
791 * coding.c: Likewise.
792 * composite.c: Likewise.
793 * dired.c: Likewise.
794 * dispnew.c: Likewise.
795 * doc.c: Likewise.
796 * dosfns.c: Likewise.
797 * editfns.c: Likewise.
798 * emacs.c: Likewise.
799 * fileio.c: Likewise.
800 * filelock.c: Likewise.
801 * font.c: Likewise.
802 * fontset.c: Likewise.
803 * fringe.c: Likewise.
804 * indent.c: Likewise.
805 * insdel.c: Likewise.
806 * intervals.c: Likewise.
807 * keyboard.c: Likewise.
808 * keymap.c: Likewise.
809 * lread.c: Likewise.
810 * macros.c: Likewise.
811 * marker.c: Likewise.
812 * minibuf.c: Likewise.
813 * nsfns.m: Likewise.
814 * nsmenu.m: Likewise.
815 * print.c: Likewise.
816 * process.c: Likewise.
817 * regex.c: Likewise.
818 * region-cache.c: Likewise.
819 * search.c: Likewise.
820 * syntax.c: Likewise.
821 * term.c: Likewise.
822 * textprop.c: Likewise.
823 * undo.c: Likewise.
824 * unexsol.c: Likewise.
825 * w16select.c: Likewise.
826 * w32fns.c: Likewise.
827 * w32menu.c: Likewise.
828 * window.c: Likewise.
829 * xdisp.c: Likewise.
830 * xfns.c: Likewise.
831 * xmenu.c: Likewise.
832 * xml.c: Likewise.
833 * xselect.c: Likewise.
834
2f07e6af
EZ
8352012-06-16 Eli Zaretskii <eliz@gnu.org>
836
1053a871
SM
837 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
838 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 839 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
840 row.
841 (handle_face_prop): Use chunk-relative overlay string index when
842 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
843 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
844 the rightmost. (Bug#11720)
2f07e6af 845
29b83cec
AS
8462012-06-16 Andreas Schwab <schwab@linux-m68k.org>
847
848 * category.h (CHAR_HAS_CATEGORY): Define as inline.
849 (CATEGORY_MEMBER): Enforce 1/0 value.
850 * category.c (_temp_category_set): Remove.
851
4c5501e9
EZ
8522012-06-16 Eli Zaretskii <eliz@gnu.org>
853
854 * window.c (Fdelete_other_windows_internal)
855 (Fdelete_window_internal): Don't access frame's mouse highlight
856 info of the initial frame. (Bug#11677)
857
2b570124
PE
8582012-06-14 Paul Eggert <eggert@cs.ucla.edu>
859
e93864f9
PE
860 * .gdbinit (xgetint): Fix recently-introduced paren typo.
861 Assume USE_2_TAGS_FOR_INTS.
862 (xreload): Adjust $tagmask width to match recent lisp.h change.
863
2b570124
PE
864 Simplify lisp.h in minor ways that should not affect code.
865 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
866 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
867 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
868 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
869 (INTTYPEBITS): New macro, for clarity.
870 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
871 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
872 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
873 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
874 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
875
81755f69
JB
8762012-06-13 Juanma Barranquero <lekktu@gmail.com>
877
878 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
879
16192a57
GM
8802012-06-13 Glenn Morris <rgm@gnu.org>
881
882 * s/bsd-common.h (BSD4_3):
883 * s/usg5-4-common.h (USG5_4): No longer define; unused.
884
646b5f55
AS
8852012-06-13 Andreas Schwab <schwab@linux-m68k.org>
886
887 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
888 instead of union.
889 (XLI, XIL): Define.
1053a871
SM
890 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
891 Use them.
892 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 893 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 894 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
895 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
896 * frame.c (delete_frame): Remove outdated comment.
897 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
898 USE_LISP_UNION_TYPE.
899 (Fw32_unregister_hot_key): Likewise.
900 (Fw32_toggle_lock_key): Likewise.
901 * w32menu.c (add_menu_item): Likewise.
902 (w32_menu_display_help): Use XIL instead of checking
903 USE_LISP_UNION_TYPE.
904 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
905 (init_heap): Likewise.
906 * w32term.c (w32_read_socket): Update comment.
907
1d3823c9
GM
9082012-06-13 Glenn Morris <rgm@gnu.org>
909
c62ff706
GM
910 * s/usg5-4-common.h, src/s/unixware.h:
911 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
912
1d3823c9
GM
913 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
914
bfe3e0a2
PE
9152012-06-13 Paul Eggert <eggert@cs.ucla.edu>
916
917 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
918 * alloc.c (make_number) [!defined make_number]:
919 Remove, as lisp.h always defines this now.
920 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
921 (roundup_size): Verify that it is a power of 2.
922 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
923 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
924 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
925 -DUSE_LSB_TAG=0, to override the automatically-selected default.
926 USE_LSB_TAG now is always defined to be either 0 or 1.
927 All uses changed.
928 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
929 code works fine either way, and efficiency is not a concern here,
930 as the union type is for debugging, not for production.
931 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
932 Use an inline function on all platforms when using the union type,
933 since this is simpler and 'static inline' can be used portably
934 within Emacs now.
935 (LISP_INITIALLY_ZERO): New macro.
936 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
937 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
938
45fa9c0f
GM
9392012-06-12 Glenn Morris <rgm@gnu.org>
940
b4492cba
GM
941 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
942
943 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 944
45fa9c0f
GM
945 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
946 Move BROKEN_SIGIO to configure.
947
948 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
949 Move NO_TERMIO to configure.
950
0e25d334
CY
9512012-06-12 Chong Yidong <cyd@gnu.org>
952
953 * image.c (imagemagick_load_image): Use MagickFlattenImage if
954 MagickMergeImageLayers is undefined. Use pixel pusher loop if
955 MagickExportImagePixels is undefined.
956
43682bb6
PE
9572012-06-12 Paul Eggert <eggert@cs.ucla.edu>
958
959 * image.c (imagemagick_load_image): Remove unused label.
960
a9be7d2b
GM
9612012-06-11 Glenn Morris <rgm@gnu.org>
962
963 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
964 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
965 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
966 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
967
3017f87f
SM
9682012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
969
970 * alloc.c (make_byte_code): New function.
971 (Fmake_byte_code): Use it. Don't purify here.
972 * lread.c (read1): Use it as well to avoid extra allocation.
973
1b9b4cf4
CY
9742012-06-11 Chong Yidong <cyd@gnu.org>
975
976 * image.c (imagemagick_load_image): Implement transparency.
977
95988fcf
AS
9782012-06-10 Andreas Schwab <schwab@linux-m68k.org>
979
980 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
981 account for preceding backslashes. (Bug#11663)
982
cd4eb164
CY
9832012-06-09 Chong Yidong <cyd@gnu.org>
984
985 * term.c: Support italics in capable terminals (Bug#9652).
986 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
987 (turn_on_face): Output using TS_enter_italic_mode if available.
988 Don't handle unused blinking and alt-charset cases.
989 (turn_off_face): Handle italic case; discard unused tty_blinking_p
990 and tty_alt_charset_p cases.
991 (tty_capable_p, init_tty): Support italics.
992
993 * termchar.h (struct tty_display_info): Add field for italics.
994 Remove unused blink field.
995
996 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
997 Handle slant.
998
999 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1000 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1001 tty_alt_charset_p. Add tty_italic_p.
1002
ff88beb8
MA
10032012-06-09 Michael Albinus <michael.albinus@gmx.de>
1004
1005 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1006 dbus_type_is_basic if available.
1007 (xd_extract_signed, xd_extract_unsigned): Rename from
1008 extract_signed and extract_unsigned, respectively. Adapt callers.
1009
44286096
CY
10102012-06-09 Chong Yidong <cyd@gnu.org>
1011
1682701f
CY
1012 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1013
44286096
CY
1014 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1015 case (Bug#9752).
1016
d86feb17
PE
10172012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1018
1019 * xdisp.c (vmessage): Treat frame message as multibyte.
1020 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1021 would generate the diagnostic "Making \302\247 buffer-local while
1022 let-bound!".
1023
d5c20fe8
EZ
10242012-06-08 Eli Zaretskii <eliz@gnu.org>
1025
1026 * dispnew.c (showing_window_margins_p): Undo last change, which
1027 was done due to an inadvertent commit.
1028 (adjust_frame_glyphs_for_frame_redisplay): Do call
1029 showing_window_margins_p.
1030
513749ee
SM
10312012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1032
1033 * eval.c (Fmake_var_non_special): New primitive.
1034 (syms_of_eval): Defsubr it.
1035 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1036
d4a8f5c1
JB
10372012-06-08 Juanma Barranquero <lekktu@gmail.com>
1038
1039 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1040 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1041
8bbbc977
EZ
10422012-06-08 Eli Zaretskii <eliz@gnu.org>
1043
1044 * alloc.c (allocate_vectorlike): Fix last change.
1045
f3372c87
DA
10462012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1047
1048 Block-based vector allocation of small vectors.
1049 * lisp.h (struct vectorlike_header): New field `nbytes',
1050 adjust comment accordingly.
1051 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1052 to denote vector blocks. Adjust users (live_vector_p,
1053 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1054 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1055 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1056 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1057 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1058 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1059 (roundup_size): New constant.
1060 (struct vector_block): New data type.
1061 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1062 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1063 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1064 (sweep_vectors): New functions.
1065 (allocate_vectorlike): Return `zero_vector' as the only vector of
1066 0 items. Allocate new vector from block if vector size is less than
1067 or equal to VBLOCK_BYTES_MAX.
1068 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1069 (init_alloc_once): Add call to init_vectors.
1070
4f18a4ed
SM
10712012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1072
1073 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1074
86f158bc
PE
10752012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1076
1077 * doprnt.c (doprnt): Truncate multibyte char correctly.
1078 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1079 would mishandle a string argument "Xc" if X was a multibyte
1080 character of length 2: it would truncate after X's first byte
1081 rather than including all of X.
1082
c5cfcbe0
CY
10832012-06-06 Chong Yidong <cyd@gnu.org>
1084
1085 * buffer.c (word_wrap): Doc fix.
1086
c05cf390
PE
10872012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1088
1089 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1090
0c3461de
GM
10912012-06-03 Glenn Morris <rgm@gnu.org>
1092
1093 * xdisp.c (tool-bar-style): Doc fix.
1094
c71232db
UM
10952012-06-03 Ulrich Müller <ulm@gentoo.org>
1096
1097 * Makefile.in (PAXCTL): Define.
1098 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1099 binary via PaX flags if the paxctl utility is available.
1100 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1101 Restore PaX flags to their default. (Bug#11398)
1102
383f7350
CY
11032012-06-03 Chong Yidong <cyd@gnu.org>
1104
1105 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1106 buffer (Bug#11226).
1107
5f2c76c6
CY
11082012-06-03 Chong Yidong <cyd@gnu.org>
1109
1110 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1111 (note_mode_line_or_margin_highlight): If there is no help echo,
1112 use mode-line-default-help-echo. Handle the case where the mouse
1113 position is past the end of the mode line string.
1114
1115 * buffer.c (buffer_local_value_1): New function, split from
1116 Fbuffer_local_value; can return Qunbound.
1117 (Fbuffer_local_value): Use it.
1118 (Vmode_line_format): Docstring tweaks.
1119
773d47f6
PE
11202012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1121
1122 * sysdep.c (system_process_attributes): Improve comment.
1123
f2d6a3df
SM
11242012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1125
1126 * keyboard.c: Export real-this-command to Elisp.
1127 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1128 and DEFVAR it. Update all users.
1129
63810350
PE
11302012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1131
7bd5c1f4
PE
1132 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1133
63810350
PE
1134 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1135 Convert pctcpu and pctmem to Lisp float properly.
1136 Let the compiler fold better, as 100.0/0x8000 is exact.
1137
a2821611
AS
11382012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1139
1140 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1141 cons_block.
1142
5fceba1d
PE
11432012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1144
1145 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1146
c98ff5dd
DA
11472012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1148
1149 For a 'struct window', replace some Lisp_Object fields to
1150 bitfields where appropriate, remove unused fields.
1151 * window.h (struct window): Remove unused 'last_mark_x' and
1152 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1153 change it's type from Lisp_Object to bitfield.
1154 Change type of 'force_start', 'optional_new_start',
1155 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1156 fields from Lisp_Object to bitfield. Adjust users accordingly.
1157
ca34e0be
PE
11582012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1159
1160 Pacify gcc -Wdouble-precision when using Xaw.
1161 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1162 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1163 Use 'float' consistently, rather than 'float' in most places
1164 and 'double' in a couple of places.
1165
efc00ab1 11662012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1167
1168 * xdisp.c (handle_stop): Detect whether we have overlay strings
1169 loaded by testing it->current.overlay_string_index to be
1170 non-negative, instead of checking whether n_overlay_strings is
1171 positive. (Bug#11587)
1172
efc00ab1 11732012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1174
1175 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1176
1177 * doc.c (Fsubstitute_command_keys): Doc fix.
1178
efc00ab1 11792012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1180
1181 * search.c (search_buffer): Remove calls to
1182 r_alloc_inhibit_buffer_relocation, as it is now called by
1183 maybe_unify_char, which was the cause of relocation of buffer text
1184 in bug#11519.
1185
efc00ab1 11862012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1187
1188 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1189 for the duration of call to load_charset, to avoid problems with
1190 callers of maybe_unify_char that access buffer text through C
1191 pointers.
1192
1193 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1194 decrement the inhibition flag, instead of just setting or
1195 resetting it.
1196
ba93a187
PE
11972012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1198
1199 Remove obsolete '#define static' cruft.
1200 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1201 This #undef was "temporary" in 2000; it is no longer needed
1202 now that '#define static' has gone away.
1203 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1204 (gray_bitmap_bits): Remove; no longer needed.
1205 All uses replaced with definiens.
1206 * xterm.c: Include "bitmaps/gray.xbm".
1207
9e4bf381
PE
12082012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1209
1210 Clean up __executable_start, monstartup when --enable-profiling.
1211 The following changes affect the code only when profiling.
1212 * dispnew.c (__executable_start): Rename from safe_bcopy.
1213 Define only on platforms that need it.
1214 * emacs.c: Include <sys/gmon.h> when profiling.
1215 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1216 (__executable_start): Remove decl, since lisp.h does it now.
1217 (safe_bcopy): Remove decl; no longer has that name.
1218 (main): Coalesce #if into single bit of code, for simplicity.
1219 Cast pointers to uintptr_t, since standard libraries want integers
1220 and not pointers.
1221 * lisp.h (__executable_start): New decl.
1222
32d72c2f
GM
12232012-05-31 Glenn Morris <rgm@gnu.org>
1224
1225 * image.c (Fimagemagick_types): Doc fix.
1226
baac5bc7
JM
12272012-05-30 Jim Meyering <meyering@redhat.com>
1228
1229 * callproc.c (Fcall_process_region): Include directory component
1230 in mkstemp error message (Bug#11586).
1231
72cb32cf
PE
12322012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1233
1234 * alloc.c, lisp.h (make_pure_vector): Now static.
1235
61b108cc
SM
12362012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1237
1238 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1239 Move to byte-run.el.
1240 (Fautoload): Do the hash-doc more carefully.
1241 * data.c (Fdefalias): Purify definition, except for keymaps.
1242 (Qdefun): Move from eval.c.
1243 * lisp.h (Qdefun): Remove.
1244 * lread.c (read1): Tiny simplification.
1245
471fe23d
TN
12462012-05-29 Troels Nielsen <bn.troels@gmail.com>
1247
934f3f58 1248 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
1249 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1250 Bug#9642, but explicitly check that the buffer the overlay would
1251 be moved to is live and rearrange lines to make sure that errors
1252 will not put the overlay in an inconsistent state.
1253 (Fdelete_overlay): Cosmetics.
1254
85d0efd1
EZ
12552012-05-28 Eli Zaretskii <eliz@gnu.org>
1256
1257 * w32term.c (my_bring_window_to_top): New function.
1258 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
1259 could be different from the original one.
1260 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
1261 (Bug#11513)
1262
1263 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1264 by calling BringWindowToTop.
1265
1266 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1267 (WM_EMACS_END): Increase by one.
1268
da92a98c
PE
12692012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1270
1271 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1272 This avoids undefined behavior that might cause the eassert
1273 to not catch an out-of-range value.
1274
74d1f848
JB
12752012-05-28 Juanma Barranquero <lekktu@gmail.com>
1276
1277 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1278 Update dependencies.
1279
9e1a06fc
EZ
12802012-05-27 Eli Zaretskii <eliz@gnu.org>
1281
1282 * bidi.c (bidi_mirror_char): Fix last change.
1283
f3dd7312
AS
12842012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1285
1286 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1287 when referring to sectname field in printf format.
1288
81899c91
PE
12892012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1290
57b81a9f
PE
1291 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1292 Only r_alloc_inhibit_buffer_relocation needed to be added;
1293 the others were already declared.
1294
81899c91
PE
1295 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1296 before checking whether it's out of range. Put the check inside
1297 eassert. See
1298 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1299
33017faf 13002012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
1301
1302 * callproc.c (Fcall_process): Restore a line that was accidentally
1303 commented out in the 2011-02-13 change (bug#11547).
1304
33017faf 13052012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
1306
1307 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1308 defined on ralloc.c.
1309
1310 * buffer.c [REL_ALLOC]: Remove prototypes of
1311 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1312 they are now on lisp.h.
1313
1314 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1315
1316 * search.c (search_buffer): Use it to inhibit relocation of buffer
1317 text while re_search_2 is doing its job, because re_search_2 is
1318 passed C pointers to buffer text. (Bug#11519)
1319
23415acf
EZ
1320 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1321 Update value to 24.
1322
44e27368
EZ
1323 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1324 state after an additional call to move_it_in_display_line_to, keep
1325 the values of it->max_ascent and it->max_descent found for the
1326 entire line.
1327 (pos_visible_p): Revert the comparison against bottom_y to what it
1328 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1329 (Bug#11464)
1330
c1892f11
PE
13312012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1332
1333 Fix coding-related core dumps with gcc -ftrapv.
1334 The code was computing A - B, where A and B are pointers, and B is
1335 random garbage. This can lead to core dumps on platforms that
1336 have special pointer registers, and it also leads to core dumps on
1337 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1338 A - B only when B is initialized properly.
1339 * coding.c (coding_set_source, coding_set_destination): Return void.
1340 (coding_change_source, coding_change_destinations): New functions,
1341 with the old behaviors of coding_set_source and coding_set_destination.
1342 All callers that need an offset changed to use these new functions.
1343
eb7afdad
GM
13442012-05-26 Glenn Morris <rgm@gnu.org>
1345
1346 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1347
f12fdf02
EZ
13482012-05-26 Eli Zaretskii <eliz@gnu.org>
1349
53a63be6 1350 Extend mouse support on W32 text-mode console.
61b108cc
SM
1351 * xdisp.c (draw_row_with_mouse_face):
1352 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1353
eb3f6f01 1354 * w32console.c: Include window.h.
61b108cc
SM
1355 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1356 New functions.
eb3f6f01
EZ
1357 (initialize_w32_display): Initialize mouse-highlight data.
1358
53a63be6
EZ
1359 * w32inevt.c: Include termchar.h and window.h.
1360 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1361 moves, call note_mouse_highlight. If help_echo changed, call
1362 gen_help_event to produce help-echo message in the echo area.
1363 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1364 highlight info.
1365
4cfd81f6
PE
13662012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1367
1368 * lread.c (read1): Simplify slightly to avoid an overflow warning
1369 with GCC 4.7.0 on x86-64.
1370
4446092a
EZ
13712012-05-26 Eli Zaretskii <eliz@gnu.org>
1372
1373 * bidi.c (bidi_mirror_char): Revert last change: an int is
1374 definitely wide enough here.
1375
42b2a986 13762012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1377
42b2a986 1378 Fix integer width and related bugs (Bug#9874).
eb106a49 1379 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1380 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1381 (string_bytes, check_sblock, allocate_string_data):
1382 (compact_small_strings, Fmake_bool_vector, make_string)
1383 (make_unibyte_string, make_multibyte_string)
1384 (make_string_from_bytes, make_specified_string)
1385 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1386 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1387 (mark_vectorlike):
1388 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1389 (allocate_pseudovector):
1390 Use int, not EMACS_INT, where int is wide enough.
1391 (inhibit_garbage_collection, Fgarbage_collect):
1392 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1393 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1394 int might not be wide enough.
1395 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1396 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1397 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1398 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1399 (bidi_level_of_next_char, bidi_move_to_visually_next):
1400 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1401 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1402 (Fkill_buffer, Fset_buffer_major_mode)
1403 (advance_to_char_boundary, Fbuffer_swap_text)
1404 (Fset_buffer_multibyte, overlays_at, overlays_in)
1405 (overlay_touches_p, struct sortvec, record_overlay_string)
1406 (overlay_strings, recenter_overlay_lists)
1407 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1408 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1409 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1410 (Foverlay_recenter, last_overlay_modification_hooks_used)
1411 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1412 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
1413 (validate_region): Omit unnecessary test for b <= e,
1414 since that's guaranteed by the previous test.
d311d28c
PE
1415 (adjust_overlays_for_delete): Avoid pos + length overflow.
1416 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1417 (report_overlay_modification):
1418 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1419 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1420 Omit pointer cast, which isn't needed anyway, and doesn't work
1421 after the EMACS_INT -> ptrdiff_t change.
02481186 1422 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
1423 * buffer.h: Adjust decls to match defn changes elsewhere.
1424 (struct buffer_text, struct buffer):
1425 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1426 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
1427 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1428 not int, to avoid needless 32-bit limit on 64-bit hosts.
1429 (exec_byte_code): Use tighter memory-full test, one that checks
1430 for alloca overflow. Don't compute the address of the object just
1431 before an array, as that's not portable. Use EMACS_INT, not
1432 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
1433 * callint.c (Fcall_interactively):
1434 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1435 * callproc.c (call_process_kill, Fcall_process):
1436 Don't assume pid_t fits into an Emacs fixnum.
1437 (call_process_cleanup, Fcall_process, child_setup):
1438 Don't assume pid_t fits into int.
1439 (call_process_cleanup, Fcall_process, delete_temp_file)
1440 (Fcall_process_region):
1441 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1442 (Fcall_process): Simplify handling of volatile integers.
1443 Use int, not EMACS_INT, where int will do.
1444 * casefiddle.c (casify_object, casify_region, operate_on_word)
1445 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1446 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1447 (casify_object): Avoid integer overflow when overallocating buffer.
1448 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1449 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1450 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1451 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1452 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1453 integers are now checked earlier. All uses replaced with XINT.
1454 (ccl_driver):
1455 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1456 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1457 (ccl_driver, Fregister_code_conversion_map):
1458 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1459 (resolve_symbol_ccl_program): Check that vector header is in range.
1460 Always copy the vector, so that we can check its contents reliably
1461 now rather than having to recheck each instruction as it's being
1462 executed. Check that vector words fit in 'int'.
1463 (ccl_get_compiled_code, Fregister_ccl_program)
1464 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1465 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1466 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1467 contents are in range.
1468 (Fccl_execute_on_string): Check that status is in range.
1469 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1470 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1471 Accept and return EMACS_INT, not int, because callers can pass values
1472 out of 'int' range.
1473 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1474 (multibyte_chars_in_text, parse_str_as_multibyte)
1475 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1476 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1477 (string_escape_byte8, Fget_byte):
1478 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1479 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1480 avoid mishandling large integers.
1481 * character.h: Adjust decls to match defn changes elsewhere.
1482 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1483 (Ffind_charset_region):
1484 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1485 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1486 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1487 Don't assume fixnum fits in int.
d311d28c
PE
1488 (load_charset_map_from_vector, Fmap_charset_chars):
1489 Remove now-unnecessary CHECK_NATNUMs.
1490 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1491 Don't rely on undefined behavior with signed left shift overflow.
1492 Don't assume unsigned int fits into fixnum, or that fixnum fits
1493 into unsigned int. Don't require max_code to be a valid fixnum;
1494 that's not true for gb10830 4-byte on a 32-bit host. Allow
1495 invalid_code to be a cons, for the same reason. Require code_offset
1496 to be a character. Avoid int overflow if max_char is close
1497 to INT_MAX.
1498 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1499 this is intended anyway and avoids some undefined behavior.
1500 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1501 INDEX_TO_CODE_POINT, as that's what it expects.
1502 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1503 * charset.h (DECODE_CHAR): Return int, not unsigned;
1504 this is what was intended anyway, and it avoids undefined behavior.
1505 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1506 integer-overflow issues.
1507 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1508 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1509 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1510 * chartab.c (Fmake_char_table, Fset_char_table_range)
1511 (uniprop_get_decoder, uniprop_get_encoder):
1512 Don't assume fixnum fits in int.
1513 * cmds.c (move_point): New function, that does the gist of
1514 Fforward_char and Fbackward_char, but does so while checking
1515 for integer overflow more accurately.
c96e5d6a 1516 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1517 (Fforward_line, Fend_of_line, internal_self_insert)
1518 (internal_self_insert):
1519 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1520 Fix a FIXME, by checking for integer overflow when calculating
1521 target_clm and actual_clm.
1522 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1523 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1524 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1525 (coding_alloc_by_making_gap, alloc_destination)
1526 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1527 (encode_coding_utf_16, detect_coding_emacs_mule)
1528 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1529 (detect_coding_iso_2022, decode_coding_iso_2022)
1530 (encode_invocation_designation, encode_designation_at_bol)
1531 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1532 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1533 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1534 (encode_coding_ccl, encode_coding_raw_text)
1535 (detect_coding_charset, decode_coding_charset)
1536 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1537 (produce_composition, produce_charset, produce_annotation)
1538 (decode_coding, handle_composition_annotation)
1539 (handle_charset_annotation, consume_chars, decode_coding_gap)
1540 (decode_coding_object, encode_coding_object, detect_coding_system)
1541 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1542 (code_convert_region, code_convert_string)
8f50130c
PE
1543 (Fdefine_coding_system_internal)
1544 (coding_set_source, coding_set_destination):
d311d28c
PE
1545 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1546 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1547 (Fdefine_coding_system_internal):
1548 Don't assume fixnums fit in int.
1549 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1550 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1551 (Funencodable_char_position, Fcheck_coding_systems_region)
1552 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1553 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1554 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1555 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1556 Don't access memory outside of the args array.
d311d28c 1557 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1558 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1559 result of ENCODE_CHAR.
d311d28c
PE
1560 * coding.h: Adjust decls to match defn changes elsewhere.
1561 (struct coding_system):
1562 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1563 * composite.c (get_composition_id, find_composition)
1564 (run_composition_function, update_compositions)
1565 (compose_text, composition_gstring_put_cache)
1566 (composition_gstring_p, composition_gstring_width)
1567 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1568 (composition_compute_stop_pos, composition_reseat_it)
1569 (composition_update_it, struct position_record)
1570 (find_automatic_composition, composition_adjust_point)
1571 (Fcomposition_get_gstring, Ffind_composition_internal):
1572 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1573 (update_compositions):
1574 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1575 * composite.h: Adjust decls to match defn changes elsewhere.
1576 (struct composition):
1577 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1578 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1579 Do not attempt to compute the address of the object just before a
1580 buffer; this is not portable.
1581 (Faref, Faset):
1582 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1583 (Faset): Use int, not EMACS_INT, where int is wide enough.
1584 (Fstring_to_number): Don't assume fixnums fit in int.
1585 (Frem): Don't assume arg is nonnegative.
1586 * dbusbind.c (xd_append_arg): Check for integers out of range.
1587 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1588 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1589 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1590 (xd_get_connection_references): Return ptrdiff_t, not int.
1591 All uses changed.
1592 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1593 (xd_read_message_1):
1594 Use int, not unsigned, where the dbus API uses int.
1595 (Fdbus_message_internal): Don't overflow mtype.
1596 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
1597 * dired.c (directory_files_internal, file_name_completion, scmp)
1598 (file_name_completion_stat):
1599 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1600 (file_name_completion): Don't overflow matchcount.
1601 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1602 * dispextern.h: Adjust decls to match defn changes elsewhere.
1603 (struct text_pos, struct glyph, struct bidi_saved_info)
1604 (struct bidi_string_data, struct bidi_it, struct composition_it)
1605 (struct it):
1606 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1607 (struct display_pos, struct composition_it, struct it):
1608 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1609 * dispnew.c (increment_matrix_positions)
1610 (increment_row_positions, mode_line_string)
1611 (marginal_area_string):
1612 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 1613 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
1614 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1615 (duration_to_sec_usec): New function, to check for overflow better.
1616 (Fsleep_for, sit_for): Use it.
1617 * doc.c (get_doc_string, store_function_docstring):
1618 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1619 (get_doc_string, Fsnarf_documentation):
1620 Use int, not EMACS_INT, where int is wide enough.
1621 (get_doc_string):
1622 Use SAFE_ALLOCA, not alloca.
1623 Check for overflow when converting EMACS_INT to off_t.
1624 * doprnt.c (doprnt):
1625 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1626 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1627 Don't assume uid_t fits into fixnum.
1628 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1629 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1630 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1631 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1632 (general_insert_function)
1633 (Finsert_char, make_buffer_string, make_buffer_string_both)
1634 (update_buffer_properties, Fbuffer_substring)
1635 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1636 (Fsubst_char_in_region, check_translation)
1637 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1638 (transpose_markers, Ftranspose_regions):
1639 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1640 (clip_to_bounds): Move to lisp.h as an inline function).
1641 (Fconstrain_to_field): Don't assume integers are nonnegative.
1642 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1643 (Fsubst_char_in_region, Fsave_restriction):
1644 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1645 (Femacs_pid): Don't assume pid_t fits into fixnum.
1646 (lo_time): Use int, not EMACS_INT, when int suffices.
1647 (lisp_time_argument): Check for usec out of range.
1648 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
1649 (Fuser_login_name, Fuser_full_name): Signal an error
1650 if a uid argument is out of range, rather than relying on
1651 undefined behavior.
c8d5c857
PE
1652 (Fformat_time_string): Remove now-unnecessary check.
1653 lisp_time_argument checks for out-of-range usec now.
243e0530 1654 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
1655 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1656 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1657 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1658 (init_cmdargs, Fdump_emacs):
1659 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1660 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1661 the bottom (typically) 32 bits of the fixnum.
1662 * eval.c (specpdl_size, call_debugger):
1663 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1664 (when_entered_debugger, Fbacktrace_debug):
1665 Don't assume fixnum can fit in int.
1666 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1667 the object just before a buffer; this is not portable.
1668 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1669 (grow_specpdl, unbind_to):
1670 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1671 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1672 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1673 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1674 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1675 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1676 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1677 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1678 (a_write, e_write):
1679 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1680 (Fcopy_file, non_regular_nbytes, read_non_regular)
1681 (Finsert_file_contents):
1682 Use int, not EMACS_INT, where int is wide enough.
1683 (READ_BUF_SIZE): Verify that it fits in int.
1684 (Finsert_file_contents): Check that counts are in proper range,
1685 rather than assuming fixnums fit into ptrdiff_t etc.
1686 Don't assume fixnums fit into int.
125b3835 1687 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1688 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1689 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1690 (string_char_to_byte, string_byte_to_char)
1691 (string_make_multibyte, string_to_multibyte)
1692 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1693 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1694 (substring_both, Fdelete, internal_equal, Ffillarray)
1695 (Fclear_string, mapcar1)
1696 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1697 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1698 (larger_vector, make_hash_table, maybe_resize_hash_table)
1699 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1700 (Fmaphash, secure_hash):
1701 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1702 (concat): Check for string index and length overflow.
1703 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1704 (Frequire):
1705 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1706 (larger_vector): New API (vec, incr_min, size_max) replaces old
1707 one (vec, new_size, init). This catches size overflow.
1708 INIT was removed because it was always Qnil.
1709 All callers changed.
1710 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1711 the upper bound on a hash table index size.
1712 (make_hash_table, maybe_resize_hash_table): Use it.
1713 (secure_hash): Computer start_byte and end_byte only after
1714 they're known to be in ptrdiff_t range.
1715 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1716 (Ffont_get_glyphs, Ffont_at):
1717 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1718 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1719 (Flist_fonts, Fopen_font):
1720 Don't assume fixnum can fit in int.
1721 (check_gstring): Don't assume index can fit in int.
1722 (font_match_p): Check that fixnum is a character, not a nonnegative
1723 fixnum, since the later code needs to stuff it into an int.
1724 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1725 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1726 conversion overflow issues.
1727 (Fopen_font): Check for integer out of range.
1728 (Ffont_get_glyphs): Don't assume index can fit in int.
1729 * font.h: Adjust decls to match defn changes elsewhere.
1730 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1731 integer overflow.
1732 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1733 printmax_t, where ptrdiff_t is wide enough.
1734 (Finternal_char_font):
1735 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1736 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1737 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1738 (Fset_frame_position, x_set_frame_parameters)
1739 (x_set_line_spacing, x_set_border_width)
1740 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1741 Check that fixnums are in proper range for system types.
1742 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1743 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1744 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1745 Use SAFE_ALLOCA_LISP, not alloca.
1746 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1747 intptr_t is wide enough.
1748 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1749 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1750 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1751 Check for fixnum out of range.
1752 * ftfont.c (ftfont_list): Don't assume index fits in int.
1753 Check that fixnums are in proper range for system types.
1754 (ftfont_shape_by_flt):
1755 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1756 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1757 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1758 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1759 Check that fixnums are in proper range for system types.
1760 * gnutls.h: Adjust decls to match defn changes elsewhere.
1761 * gtkutil.c (xg_dialog_run):
1762 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1763 (update_frame_tool_bar):
1764 Check that fixnums are in proper range for system types.
1765 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1766 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1767 * indent.c (last_known_column, last_known_column_point):
1768 (current_column_bol_cache):
1769 (skip_invisible, current_column, check_display_width):
1770 (check_display_width, scan_for_column, current_column_1)
1771 (Findent_to, Fcurrent_indentation, position_indentation)
1772 (indented_beyond_p, Fmove_to_column, compute_motion):
1773 (Fcompute_motion, Fvertical_motion):
1774 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1775 (last_known_column_modified): Use EMACS_INT, not int.
1776 (check_display_width):
1777 (Fcompute_motion):
1778 Check that fixnums and floats are in proper range for system types.
1779 (compute_motion): Don't assume index or fixnum fits in int.
1780 (compute_motion, Fcompute_motion):
1781 Use int, not EMACS_INT, when it is wide enough.
1782 (vmotion): Omit local var start_hpos that is always 0; that way
1783 we don't need to worry about overflow in expressions involving it.
1784 * indent.h: Adjust decls to match defn changes elsewhere.
1785 (struct position):
1786 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1787 Use int, not EMACS_INT, where int is wide enough.
1788 Remove unused members ovstring_chars_done and tab_offset;
1789 all uses removed.
1790 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1791 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1792 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1793 (make_gap, copy_text, insert, insert_and_inherit)
1794 (insert_before_markers, insert_before_markers_and_inherit)
1795 (insert_1, count_combining_before, count_combining_after)
1796 (insert_1_both, insert_from_string)
1797 (insert_from_string_before_markers, insert_from_string_1)
1798 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1799 (adjust_after_replace, adjust_after_insert, replace_range)
1800 (replace_range_2, del_range, del_range_1, del_range_byte)
1801 (del_range_both, del_range_2, modify_region)
1802 (prepare_to_modify_buffer, signal_before_change)
1803 (signal_after_change, Fcombine_after_change_execute):
1804 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1805 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1806 (balance_an_interval, split_interval_right, split_interval_left)
1807 (find_interval, next_interval, update_interval)
1808 (adjust_intervals_for_insertion, delete_node, delete_interval)
1809 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1810 (static_offset_intervals, offset_intervals)
1811 (merge_interval_right, merge_interval_left, make_new_interval)
1812 (graft_intervals_into_buffer, temp_set_point_both)
1813 (temp_set_point, set_point, adjust_for_invis_intang)
1814 (set_point_both, move_if_not_intangible, get_property_and_range)
1815 (get_local_map, copy_intervals, copy_intervals_to_string)
1816 (compare_string_intervals, set_intervals_multibyte_1):
1817 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1818 * intervals.h: Adjust decls to match defn changes elsewhere.
1819 (struct interval):
1820 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1821 * keyboard.c (this_command_key_count, this_single_command_key_start)
1822 (before_command_key_count, before_command_echo_length, echo_now)
1823 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1824 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1825 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1826 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1827 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1828 (last_non_minibuf_size, last_point_position, echo_truncate)
1829 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1830 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1831 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1832 (stuff_buffered_input):
1833 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1834 (last_auto_save, command_loop_1, read_char):
1835 Use EMACS_INT, not int, to avoid integer overflow.
1836 (record_char): Avoid overflow in total_keys computation.
1837 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1838 * keyboard.h: Adjust decls to match defn changes elsewhere.
1839 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1840 (Fkey_description, Fdescribe_vector, Flookup_key):
1841 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1842 (click_position): New function, to check that positions are in range.
1843 (Fcurrent_active_maps):
1844 (describe_command):
1845 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1846 (Faccessible_keymaps, Fkey_description):
1847 (preferred_sequence_p):
1848 Don't assume fixnum can fit into int.
1849 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1850 Check for integer overflow in size calculations.
1851 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1852 avoid mishandling large integers.
1853 * lisp.h: Adjust decls to match defn changes elsewhere.
1854 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1855 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1856 (struct Lisp_Marker):
1857 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1858 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1859 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1860 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1861 All callers changed.
1862 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1863 Assume the arg has valid form, since it always does.
1864 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1865 unsigned integer system type.
1866 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1867 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1868 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1869 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1870 (duration_to_sec_usec): New decl.
1871 * lread.c (read_from_string_index, read_from_string_index_byte)
1872 (read_from_string_limit, readchar, unreadchar, openp)
1873 (read_internal_start, read1, oblookup):
1874 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1875 (Fload, readevalloop, Feval_buffer, Feval_region):
1876 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1877 (openp): Check for out-of-range argument to 'access'.
1878 (read1): Use int, not EMACS_INT, where int is wide enough.
1879 Don't assume fixnum fits into int.
6efdadfd 1880 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1881 (read_filtered_event): Use duration_to_sec_usec
1882 to do proper overflow checking on durations.
d311d28c
PE
1883 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1884 in size calculation.
1885 (Fexecute_kbd_macro):
1886 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1887 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1888 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1889 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1890 (set_marker_both, set_marker_restricted_both, marker_position)
1891 (marker_byte_position, Fbuffer_has_markers_at):
1892 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1893 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1894 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1895 It now merely ensures that the menu is large enough, without
1896 necessarily growing it, as this avoids some integer overflow issues.
1897 All callers changed.
1898 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1899 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1900 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1901 Use SAFE_ALLOCA_LISP, not alloca.
1902 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1903 to EMACS_INT. Check that fixnums are in proper range for system types.
1904 * minibuf.c (minibuf_prompt_width, string_to_object)
1905 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1906 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1907 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1908 (get_minibuffer, read_minibuf_unwind):
1909 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1910 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1911 this simplifies overflow checking. All callers changed.
1912 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1913 (Ftest_completion):
1914 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1915 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1916 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1917 Check that fixnums are in proper range for system types.
1918 (Fx_create_frame, Fx_show_tip):
1919 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1920 * nsfont.m (ns_findfonts, nsfont_list_family):
1921 Don't assume fixnum fits in long.
1922 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1923 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1924 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1925 wide enough.
17fdb222 1926 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
1927 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1928 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1929 (PRINTDECLARE, PRINTPREPARE):
1930 (strout, print_string):
1931 (print, print_preprocess, print_check_string_charset_prop)
1932 (print_object):
1933 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1934 (PRINTDECLARE):
1935 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1936 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1937 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 1938 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 1939 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
1940 (print_error_message): Use SAFE_ALLOCA, not alloca.
1941 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
1942 (print_depth, new_backquote_output, print_number_index):
1943 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
1944 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1945 (Fset_process_window_size, Fformat_network_address)
1946 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 1947 (sigchld_handler):
d311d28c 1948 Check that fixnums are in proper range for system types.
d44287d4 1949 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1950 Check for process-ids out of pid_t range rather than relying on
1951 undefined behavior.
e4d81efc 1952 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1953 (Fformat_network_address, read_process_output, send_process)
1954 (Fprocess_send_region, status_notify):
1955 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1956 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1957 (wait_reading_process_output, read_process_output, exec_sentinel):
1958 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1959 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1960 (Faccept_process_output): Use duration_to_sec_usec to do proper
1961 overflow checking on durations.
dde14581
PE
1962 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1963 Don't assume pid_t fits in int.
02481186
PE
1964 * process.h (struct Lisp_Process): Members tick and update_tick
1965 are now of type EMACS_INT, not int.
b62b53e8
PE
1966 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1967 configured --with-wide-int.
d311d28c
PE
1968 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1969 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1970 * search.c (looking_at_1, string_match_1):
1971 (fast_string_match, fast_c_string_match_ignore_case)
1972 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1973 (scan_newline, find_before_next_newline, search_command)
1974 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1975 (set_search_regs, wordify):
1976 (Freplace_match):
1977 (Fmatch_data):
1978 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1979 (string_match_1, search_buffer, set_search_regs):
1980 (Fmatch_data):
1981 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1982 (wordify): Check for overflow in size calculation.
1983 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1984 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1985 Check that fixnums are in proper range for system types.
1986 * sound.c (struct sound_device)
1987 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1988 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1989 (Fplay_sound_internal):
1990 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1991 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1992 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1993 (Fparse_partial_sexp):
1994 Don't assume fixnums can fit in int.
1995 (struct lisp_parse_state, find_start_pos, find_start_value)
1996 (find_start_value_byte, find_start_begv)
1997 (update_syntax_table, char_quoted, dec_bytepos)
1998 (find_defun_start, prev_char_comend_first, back_comment):
1999 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2000 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2001 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2002 (Finternal_describe_syntax_value): Check that match_lisp is a
2003 character, not an integer, since the code stuffs it into int.
2004 (scan_words, scan_sexps_forward):
2005 Check that fixnums are in proper range for system types.
2006 (Fforward_word):
2007 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2008 (scan_sexps_forward):
2009 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2010 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2011 * syntax.h: Adjust decls to match defn changes elsewhere.
2012 (struct gl_state_s):
2013 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2014 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2015 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2016 * sysdep.c (wait_for_termination_1, wait_for_termination)
2017 (interruptible_wait_for_termination, mkdir):
2018 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2019 (emacs_read, emacs_write):
2020 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2021 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2022 and double all fit in int.
d311d28c
PE
2023 * term.c (set_tty_color_mode):
2024 Check that fixnums are in proper range for system types.
2025 * termhooks.h (struct input_event):
2026 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2027 * textprop.c (validate_interval_range, interval_of)
2028 (Fadd_text_properties, set_text_properties_1)
2029 (Fremove_text_properties, Fremove_list_of_text_properties)
2030 (Ftext_property_any, Ftext_property_not_all)
2031 (copy_text_properties, text_property_list, extend_property_ranges)
2032 (verify_interval_modification):
2033 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2034 (Fnext_single_char_property_change)
2035 (Fprevious_single_char_property_change):
2036 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2037 (copy_text_properties):
2038 Check for integer overflow in index calculation.
d311d28c
PE
2039 * undo.c (last_boundary_position, record_point, record_insert)
2040 (record_delete, record_marker_adjustment, record_change)
2041 (record_property_change):
2042 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2043 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2044 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2045 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2046 (Fx_hide_tip, Fx_file_dialog):
2047 * w32menu.c (set_frame_menubar):
2048 Use ptrdiff_t, not int, for consistency with rest of code.
2049 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2050 (select_window, Fdelete_other_windows_internal)
2051 (window_scroll_pixel_based, window_scroll_line_based)
2052 (Frecenter, Fset_window_configuration):
2053 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2054 (Fset_window_hscroll, run_window_configuration_change_hook)
2055 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2056 (Fscroll_other_window, Frecenter):
d311d28c
PE
2057 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2058 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2059 Don't assume fixnum fits in int.
2060 (Fset_window_scroll_bars):
2061 Check that fixnums are in proper range for system types.
2062 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2063 (string_pos, c_string_pos, number_of_chars, init_iterator)
2064 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2065 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2066 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2067 (face_before_or_after_it_pos, handle_invisible_prop)
2068 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2069 (display_prop_intangible_p, string_buffer_position_lim)
2070 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2071 (get_overlay_strings_1, get_overlay_strings)
2072 (iterate_out_of_display_property, forward_to_next_line_start)
2073 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2074 (get_next_display_element, set_iterator_to_next)
2075 (get_visually_first_element, compute_stop_pos_backwards)
2076 (handle_stop_backwards, next_element_from_buffer)
2077 (move_it_in_display_line_to, move_it_in_display_line)
2078 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2079 (add_to_log, message_dolog, message_log_check_duplicate)
2080 (message2, message2_nolog, message3, message3_nolog
2081 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2082 (current_message_1, truncate_echo_area, truncate_message_1)
2083 (set_message, set_message_1, store_mode_line_noprop)
2084 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2085 (text_outside_line_unchanged_p, check_point_in_composition)
2086 (reconsider_clip_changes)
2087 (redisplay_internal, set_cursor_from_row, try_scrolling)
2088 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2089 (redisplay_window, find_last_unchanged_at_beg_row)
2090 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2091 (trailing_whitespace_p, find_row_edges, display_line)
2092 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2093 (display_mode_element, store_mode_line_string)
2094 (pint2str, pint2hrstr, decode_mode_spec)
2095 (display_count_lines, display_string, draw_glyphs)
2096 (x_produce_glyphs, x_insert_glyphs)
2097 (rows_from_pos_range, mouse_face_from_buffer_pos)
2098 (fast_find_string_pos, mouse_face_from_string_pos)
2099 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2100 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2101 (safe_call, init_from_display_pos, handle_fontified_prop)
2102 (handle_single_display_spec, load_overlay_strings)
2103 (with_echo_area_buffer, setup_echo_area_for_printing)
2104 (display_echo_area, echo_area_display)
2105 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2106 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2107 (redisplay_window, dump_glyph_row, display_mode_line)
2108 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2109 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2110 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2111 (handle_single_display_spec, build_desired_tool_bar_string)
2112 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2113 (get_specified_cursor_type):
2114 Check that fixnums are in proper range for system types.
2115 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2116 (Flookup_image_map):
2117 Don't assume fixnums fit in int.
2118 (compare_overlay_entries):
2119 Avoid mishandling comparisons due to subtraction overflow.
2120 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2121 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2122 (handle_tool_bar_click):
2123 Use int, not unsigned, since we prefer signed and the signedness
2124 doesn't matter here.
2125 (get_next_display_element, next_element_from_display_vector):
2126 Use int, not EMACS_INT, when int is wide enough.
2127 (start_hourglass): Use duration_to_sec_usec to do proper
2128 overflow checking on durations.
2129 * xfaces.c (Fbitmap_spec_p):
2130 Check that fixnums are in proper range for system types.
2131 (compare_fonts_by_sort_order):
2132 Avoid mishandling comparisons due to subtraction overflow.
2133 (Fx_family_fonts, realize_basic_faces):
2134 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2135 (Fx_family_fonts):
2136 Don't assume fixnum fits in int.
2137 Use SAFE_ALLOCA_LISP, not alloca.
2138 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2139 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2140 (face_at_buffer_position, face_for_overlay_string)
2141 (face_at_string_position):
2142 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2143 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2144 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2145 (Fx_show_tip):
2146 Check that fixnums are in proper range for system types.
2147 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2148 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2149 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2150 (Fx_change_window_property): Don't assume fixnums fit in int.
2151 * xfont.c (xfont_chars_supported):
2152 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2153 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2154 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2155 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2156 * xml.c (parse_region):
2157 * xrdb.c (magic_file_p):
2158 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2159 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2160 (x_get_local_selection, x_reply_selection_request)
2161 (x_handle_selection_request, wait_for_property_change):
2162 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2163 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2164 short is wide enough.
2165 (x_send_client_event): Don't assume fixnum fits in int.
2166 * xterm.c (x_x_to_emacs_modifiers):
2167 Don't assume EMACS_INT overflows nicely into int.
2168 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2169 may come from Lisp.
2170 (handle_one_xevent): NATNUMP can eval its arg twice.
2171 (x_connection_closed):
2172 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2173 * xterm.h: Adjust decls to match defn changes elsewhere.
2174 (struct scroll_bar): Use struct vectorlike_header
2175 rather than rolling our own approximation.
2176 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2177
c6574eb5
GM
21782012-05-25 Glenn Morris <rgm@gnu.org>
2179
2180 * lisp.mk (lisp): Update for more files being compiled now.
2181
e8d32c7e
SM
21822012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2183
48def666
SM
2184 * lread.c: Remove `read_pure' which makes no difference.
2185 (read_pure): Remove var.
2186 (unreadpure): Remove function.
2187 (readevalloop): Don't call read_list with -1 flag.
2188 (read1, read_vector): Don't test read_pure any more.
2189 (read_list): Simplify.
2190
e8d32c7e
SM
2191 * fileio.c, character.h: Minor style tweaks.
2192
4b2addb7
DA
21932012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2194
2195 * window.h (clip_changed): Remove useless declaration.
2196
584461b2
JB
21972012-05-22 Juanma Barranquero <lekktu@gmail.com>
2198
2199 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2200 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2201
34374650
PE
22022012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2203
2204 Remove src/m/*.
2205 This directory predates autoconf and is no longer needed nowadays.
2206 Move its few remaining bits of functionality to where they're needed.
2207 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2208 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2209 * m/template.h: Remove.
2210 * Makefile.in (M_FILE): Remove. All uses removed.
2211 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2212 * lisp.h (USE_LSB_TAG):
2213 * mem-limits.h (EXCEEDS_LISP_PTR):
2214 Use VAL_MAX, not VALBITS, in #if.
2215 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2216 (EMACS_UINT): Define unconditionally now.
2217 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2218 (BITS_PER_EMACS_INT): New constants, replacing
2219 what used to be in config.h, but not useful in #if.
2220 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2221 define them any more.
2222 (VAL_MAX): New macro.
2223 (VALMASK): Use it.
2224 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2225 BITS_PER_EMACS_INT, in #if.
2226 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2227 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2228 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2229 * s/ms-w32.h (DATA_START):
2230 Move here from removed file m/intel386.h.
2231 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2232 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2233
261cb4bb
PE
22342012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2235
2236 Assume C89 or later.
2237 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2238 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2239 (xrealloc):
2240 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2241 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2242 * textprop.c, tparam.c (NULL): Remove.
2243 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2244 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2245 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2246 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2247 * xterm.c (input_signal_count): Assume volatile works.
2248
ff23cd9f
KB
22492012-05-21 Ken Brown <kbrown@cornell.edu>
2250
2251 * xgselect.c (xg_select): Fix first argument in call to 'select'
2252 (bug#11508).
2253
1b170bc6
KB
22542012-05-20 Ken Brown <kbrown@cornell.edu>
2255
2256 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 2257 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 2258
b2f4d39f
KB
22592012-05-19 Ken Brown <kbrown@cornell.edu>
2260
2261 * xfns.c (x_in_use): Remove `static' qualifier.
2262 * xterm.h (x_in_use): Declare.
2263 * xgselect.c: Include xterm.h.
2264 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2265 and `display_arg' (bug#9754).
2266
003fdae2
PE
22672012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2268
9232a6d9
PE
2269 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2270
003fdae2
PE
2271 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2272 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2273
784b56e2
EZ
22742012-05-18 Eli Zaretskii <eliz@gnu.org>
2275
2276 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2277
2278 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2279 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2280
2281 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2282 reference to image_cache->refcount.
2283 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2284
a0a79cde
JL
22852012-05-17 Juri Linkov <juri@jurta.org>
2286
2287 * search.c (Fword_search_regexp, Fword_search_backward)
2288 (Fword_search_forward, Fword_search_backward_lax)
2289 (Fword_search_forward_lax): Move functions to isearch.el
2290 (bug#10145, bug#11381).
2291
b0572523
PE
22922012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2293
2294 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2295
9660f5fc
SM
22962012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2297
2298 * lread.c (init_obarray): Declare Qt and Qnil as special.
2299
4374de83
GM
23002012-05-14 Glenn Morris <rgm@gnu.org>
2301
2302 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 2303 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 2304
dc44c39a
PE
23052012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2306
078c97cb
PE
2307 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2308
dc44c39a
PE
2309 * unexaix.c: Port to more-recent AIX compilers.
2310 (report_error, report_error_1, make_hdr, copy_sym)
2311 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2312 Make arguments const char *, not char *, to avoid violations of C
2313 standard and to fix some AIX warnings reported by Gilles Pion.
2314
e18afed7 23152012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
2316
2317 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2318 already have overlays loaded.
2319 (handle_single_display_spec): Before returning without displaying
2320 fringe bitmap, synchronize the bidi iterator with the main display
2321 iterator, by calling iterate_out_of_display_property.
2322 (iterate_out_of_display_property): Detect buffer iteration by
2323 testing that it->string is a Lisp string.
2324 (get_next_display_element): When the current object is exhausted,
2325 and there's something on it->stack, call set_iterator_to_next to
2326 proceed with what's on the stack, instead of returning zero.
2327 (set_iterator_to_next): If called at the end of a Lisp string,
2328 proceed to consider_string_end without incrementing string
2329 position. Don't increment display vector index past the end of
2330 the display vector. (Bug#11417)
c8fb9dc6
EZ
2331 (pos_visible_p): Don't report a position visible when move_it_to
2332 stopped at the last line of window, which happens to be scanned
2333 backwards by the bidi iteration. (Bug#11464)
ac268e67 2334
e18afed7 23352012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2336
2337 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2338 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2339 are on a TTY, and thus unable to display on the fringes.
2340 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2341 so we need to signal to the caller that this is a "replacing"
2342 display spec. This fixes display when the spec is invalid or we
2343 are on a TTY.
2344
e18afed7 23452012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2346
2347 * unexaix.c (make_hdr): Fix typo in prototype.
2348 This bug broke the build on AIX. Problem reported by Gilles Pion.
2349
9d0a235a
MA
23502012-05-14 Michael Albinus <michael.albinus@gmx.de>
2351
2352 * keyboard.c (kbd_buffer_get_event): Read special events also in
2353 batch mode. (Bug#11415)
2354
9e6b06ed
GM
23552012-05-12 Glenn Morris <rgm@gnu.org>
2356
2357 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2358
c1a1d7a3
EZ
23592012-05-12 Eli Zaretskii <eliz@gnu.org>
2360
2361 * lisp.mk (lisp): Add newcomment.elc.
2362
3fe7cdc8
GM
23632012-05-12 Glenn Morris <rgm@gnu.org>
2364
2365 * Makefile.in (MKDIR_P): New, set by configure.
2366 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2367
53f7d2c0
PE
23682012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2369
2370 Remove unused function hourglass_started.
2371 * dispextern.h (hourglass_started):
2372 * w32fns.c (hourglass_started):
2373 * xdisp.c (hourglass_started): Remove.
2374
75aafb17
JB
23752012-05-10 Juanma Barranquero <lekktu@gmail.com>
2376
2377 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2378 Update dependencies.
2379
12959e8e
PE
23802012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2381
97107e2e
PE
2382 * xgselect.c (xg_select): Put maxfds+1 into a var.
2383 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2384
12959e8e
PE
2385 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2386
836d29b3
DA
23872012-05-10 Dave Abrahams <dave@boostpro.com>
2388
2389 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2390 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2391
5cb67954
MA
23922012-05-09 Michael Albinus <michael.albinus@gmx.de>
2393
2394 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2395 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2396 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2397 Initialize xd_registered_buses.
2398
3478ec45
PE
23992012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2400
b263a6b0
PE
2401 Untag more efficiently if USE_LSB_TAG.
2402 This is based on a proposal by YAMAMOTO Mitsuharu in
2403 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2404 For an admittedly artificial (nth 8000 longlist) benchmark on
2405 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2406 Emacs's overall text size by 1%.
2407 * lisp.h (XUNTAG): New macro.
2408 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2409 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2410 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2411 * eval.c (Fautoload):
2412 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2413 * frame.h (XFRAME): Use XUNTAG.
2414
3478ec45
PE
2415 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2416 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2417 Remove unportable assumptions about print widths of types like
2418 dbus_uint32_t.
2419 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2420 intptr_t when converting between pointer and integer, to avoid GCC
2421 warnings about wrong width.
2422
666b903b 24232012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
2424
2425 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2426 stack for each reader_thread, instead of defaulting to 8MB
2427 determined by the linker. This avoids failures in creating
2428 subprocesses on Windows 7, see the discussion in this thread:
2429 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2430
b120cc17
JC
24312012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2432
2433 Fix up display of the *Minibuf-0* buffer in the mini window.
2434 * keyboard.c (read_char): Don't clear the echo area if there's no
2435 message to clear.
2436 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 2437 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2438
9a4b36f8
MA
24392012-05-07 Michael Albinus <michael.albinus@gmx.de>
2440
2441 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2442 batch mode.
2443
e5f9458f
CY
24442012-05-06 Chong Yidong <cyd@gnu.org>
2445
2446 * lisp.mk (lisp): Update.
2447
eceeb5fc 24482012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2449
2450 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2451
71873e2b
SM
24522012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2453
2454 * data.c (PUT_ERROR): New macro.
2455 (syms_of_data): Use it. Add new error type `user-error'.
2456 * undo.c (user_error): New function.
2457 (Fprimitive_undo): Use it.
2458 * print.c (print_error_message): Adjust print style for `user-error'.
2459 * keyboard.c (user_error): New function.
2460 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2461
ab0fa4e4
PE
24622012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2463
2464 Do not limit current-time-string to years 1000..9999.
2465 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2466 (Fcurrent_time_string): Support any year that is supported by the
2467 underlying localtime representation. Don't use asctime, as it
2468 has undefined behavior for years outside the range -999..9999.
2469
7ed806a7
PE
24702012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2471
2472 Fix race conditions involving setenv, gmtime, localtime, asctime.
2473 Without this fix, interrupts could mess up code that uses these
2474 nonreentrant functions, since setting TZ invalidates existing
2475 tm_zone or tzname values, and since most of these functions return
2476 pointers to static storage.
2477 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2478 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2479 Grow the critical sections to include not just invoking
2480 localtime/gmtime, but also accessing these functions' results
2481 including their tm_zone values if any, and any related TZ setting.
2482 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2483 so that the struct tm is saved in the critical section.
2484 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2485 motivated by the fact that memory allocation needs to be outside
2486 the critical section.
2487
0c16dfed
DA
24882012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2489
2490 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2491 with RESET_INTERVAL.
2492
2493 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2494 Remove duplicated buffer name initialization.
2495
3f83ace8
JM
24962012-05-02 Jim Meyering <jim@meyering.net>
2497
2498 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2499
c7b8541e
JM
2500 * xfns.c (x_window): Use xstrdup (Bug#11375).
2501
90207a15 25022012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2503
2504 * xdisp.c (pos_visible_p): If already at a newline from the
2505 display string before the 'while' loop, don't walk back the glyphs
2506 from it3.glyph_row. Solves assertion violation when the display
2507 string begins with a newline (egg.el). (Bug#11367)
2508
b593d6a9
AH
25092012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2510
2511 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2512 Move to simple.el.
2513
4737362e
GM
25142012-05-01 Glenn Morris <rgm@gnu.org>
2515
99cf43f9
GM
2516 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2517 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2518 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2519 All were removed before 23.1.
2520
9311dcff
GM
2521 * dispnew.c: Remove HAVE_LIBNCURSES test;
2522 it is always true on relevant platforms.
2523
4d5c6349
GM
2524 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2525 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2526
4737362e
GM
2527 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2528
74dd3a6b
AS
25292012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2530
2531 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2532 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2533 Remove.
2534
13c379ee
PE
25352012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2536
2537 Do not avoid creating empty evaporating overlays (Bug#9642).
2538 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2539 That is, do not delete an evaporating overlay if it becomes
2540 empty after its bounds are adjusted to fit within its buffer.
2541 This fix caused other problems, and I'm reverting it until we get
2542 to the bottom of them.
2543
a8e7d6d7 25442012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2545
2546 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2547
a8e7d6d7 25482012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2549
2550 * xdisp.c (pos_visible_p): If the window start position is beyond
2551 ZV, start the display from buffer beginning. Prevents assertion
2552 violation in init_iterator when the minibuffer window is scrolled
2553 via the scroll bar.
2554
2555 * window.c (window_scroll_pixel_based): Likewise.
2556
a8e7d6d7 25572012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2558
2559 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2560
a8e7d6d7 25612012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2562
2563 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2564 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2565
a8e7d6d7 25662012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2567
b593d6a9
AH
2568 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2569 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2570
1c6900d9
EZ
25712012-04-26 Eli Zaretskii <eliz@gnu.org>
2572
4c3fa1d9
EZ
2573 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2574 display element, check also the underlying string or buffer
2575 character. (Bug#11341)
2576
1c6900d9
EZ
2577 * w32menu.c: Include w32heap.h.
2578 (add_menu_item): If the call to AppendMenuW (via
2579 unicode_append_menu) fails, disable Unicode menus only if we are
2580 running on Windows 9X/Me.
2581
42bf8205
AS
25822012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2583
2584 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2585 (xgetint): Add missing shift for LSB tags.
2586
b1bac16e
MR
25872012-04-24 Martin Rudalics <rudalics@gmx.at>
2588
2589 * keyboard.c (read_char): Don't wipe echo area for select window
2590 events: These might get delayed via `mouse-autoselect-window'
2591 (Bug#11304).
2592
d69621cc
JB
25932012-04-24 Juanma Barranquero <lekktu@gmail.com>
2594
2595 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2596 manipulation of :loaded-from data.
2597
02fd101b
JB
25982012-04-23 Juanma Barranquero <lekktu@gmail.com>
2599
2600 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2601 now a cons (bug#11311).
2602
888bec30
PE
26032012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2604
89a438bd
PE
2605 Do not create empty overlays with the evaporate property (Bug#9642).
2606 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2607 if it becomes empty after its bounds are adjusted to fit within
2608 its buffer. Without this fix, in a nonempty buffer (let ((o
2609 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2610 yields an empty overlay that has the evaporate property, which is
2611 not supposed to happen.
2612
1068fe4d
PE
2613 Fix minor GTK3 problems found by static checking.
2614 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2615 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2616 (struct _EmacsFixedClass, emacs_fixed_get_type):
2617 Move decls here from emacsgtkfixed.h, since they needn't be public.
2618 (emacs_fixed_get_type): Now static.
2619 (emacs_fixed_class_init): Omit unused local.
2620 (emacs_fixed_child_type): Remove; unused.
2621 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2622 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2623 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2624 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2625 (EMACS_FIXED_GET_CLASS): Remove; unused.
2626 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2627
888bec30
PE
2628 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2629 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2630
de85e130
PE
26312012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2632
d0baac98 2633 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 2634 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
2635 (__malloc_size_t, __malloc_ptrdiff_t):
2636 Remove. All uses removed, replaced by the definiens if needed,
2637 since we can assume C89 or better now.
2638 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2639 (protect_malloc_state, align, get_contiguous_space)
2640 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2641 (malloc_atfork_handler_child, malloc_enable_thread)
2642 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2643 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2644 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2645 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2646 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2647 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2648 Define using prototypes, not old style.
2649 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2650 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2651 (align): Don't assume that signed integer overflow wraps around.
2652 Omit unused local var.
2653 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2654 (_free_internal_nolock, memalign, mallochook, reallochook):
2655 Omit no-longer-needed casts.
2656 (valloc): Use getpagesize, not __getpagesize.
2657 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2658 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2659
de85e130
PE
2660 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2661
dcbf5805
MA
26622012-04-22 Michael Albinus <michael.albinus@gmx.de>
2663
2664 Move functions from C to Lisp. Make non-blocking method calls
2665 the default. Implement further D-Bus standard interfaces.
2666
2667 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2668 (QCdbus_request_name_allow_replacement)
2669 (QCdbus_request_name_replace_existing)
2670 (QCdbus_request_name_do_not_queue)
2671 (QCdbus_request_name_reply_primary_owner)
2672 (QCdbus_request_name_reply_in_queue)
2673 (QCdbus_request_name_reply_exists)
2674 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2675 (QCdbus_registered_serial, QCdbus_registered_method)
2676 (QCdbus_registered_signal): New Lisp objects.
2677 (XD_DEBUG_MESSAGE): Use sizeof.
2678 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2679 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2680 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2681 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2682 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2683 (xd_signature, xd_append_arg): Allow float for integer types.
2684 (xd_get_connection_references): New function.
b593d6a9
AH
2685 (xd_get_connection_address): Rename from xd_initialize.
2686 Return cached address.
dcbf5805
MA
2687 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2688 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2689 level.
2690 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2691 Return number of refcounts.
dcbf5805
MA
2692 (Fdbus_get_unique_name): Make stronger parameter check.
2693 (Fdbus_message_internal): New defun.
2694 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2695 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2696 (Fdbus_send_signal, Fdbus_register_service)
2697 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2698 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2699 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2700 (Vdbus_compiled_version, Vdbus_runtime_version)
2701 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2702 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2703 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2704 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2705 Adapt docstring.
dcbf5805 2706
52828e02
PE
27072012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2708
da05bc4c
PE
2709 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2710 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2711 Do not assume ptrdiff_t is the same width as 'int'.
2712
52828e02
PE
2713 * alloc.c: Handle unusual debugging option combinations.
2714 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2715 since the two debugging options are incompatible.
2716 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2717 is defined.
2718 (mem_init, mem_insert, mem_insert_fixup):
2719 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2720 (NEED_MEM_INSERT): Remove; no longer needed.
2721
f01769f9
LL
27222012-04-22 Leo Liu <sdl.web@gmail.com>
2723
2724 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2725
5790543d
PE
27262012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2727
2728 * sysdep.c [__FreeBSD__]: Minor cleanups.
2729 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2730 Use Emacs indenting style more consistently. Avoid some casts.
2731 Use 'double' consistently rather than mixing 'float' and 'double'.
2732
b91b7e4d
EW
27332012-04-21 Eduard Wiebe <usenet@pusto.de>
2734
b593d6a9
AH
2735 * sysdep.c (list_system_processes, system_process_attributes):
2736 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2737
6114eb15
AS
27382012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2739
2740 * lisp.mk (lisp): Update.
2741
2f38dff7
PE
27422012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2743
2744 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2745 It is never used otherwise.
2746
4ae29f89
SM
27472012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2748
2749 * print.c (print_preprocess): Only check print_depth if print-circle
2750 is nil.
2751 (print_object): Check for cycles even when print-circle is nil and
2752 print-gensym is t, but only check print_depth if print-circle is nil.
2753
f30d612a
CY
27542012-04-20 Chong Yidong <cyd@gnu.org>
2755
2756 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2757 set the status to "failed" and ensure that sentinel is run.
2758
c07a4c0b 27592012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2760
2761 * process.c (Fset_process_inherit_coding_system_flag)
2762 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2763 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2764
c07a4c0b 27652012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2766
2767 * xdisp.c (string_buffer_position_lim): Limit starting position to
2768 BEGV.
2769 (set_cursor_from_row): If called for a mode-line or header-line
2770 row, return zero immediately.
2771 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2772 farther than the first row after the header line, if any.
2773 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2774 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2775
c07a4c0b 27762012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2777
4ae29f89
SM
2778 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2779 (bug#11238).
ad3a2b41 2780
c07a4c0b 27812012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 27822012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2783
2784 configure: new option --enable-gcc-warnings (Bug#11207)
2785 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2786 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2787 (ALL_CFLAGS): Use new macros rather than old.
2788 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2789 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2790 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2791 -Wunused-result, -Wunused-variable. This should go away once
2792 the Emacs and Gnulib regex code is merged.
2793 (xmalloc, xrealloc): Now static.
2794
aba027e8
PE
27952012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2796
2797 * dired.c (Fsystem_groups): Remove unused local.
2798
e5a36063
GM
27992012-04-17 Glenn Morris <rgm@gnu.org>
2800
2801 * dired.c (Fsystem_users): Doc fix.
2802
316411f0
DA
28032012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2804
2805 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2806 (syms_of_dired): Add them.
2807
9426aba4
PE
28082012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2809
b62a57be
PE
2810 Fix minor alloc.c problems found by static checking.
2811 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2812 New extern decls, to avoid calling undeclared functions.
2813 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2814 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2815 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2816 (NEED_MEM_INSERT): New macro.
2817 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2818 Remove one incorrect comment and fix another.
b62a57be 2819
3539f31f
PE
2820 Fix minor ralloc.c problems found by static checking.
2821 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2822 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2823 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2824 (r_alloc_sbrk): Now static.
2825
a041960a
PE
2826 Improve ralloc.c interface checking.
2827 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2828 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2829 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2830 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2831 [REL_ALLOC]: ... to here, to check interface.
2832 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2833 Remove decls. This fixes an "It stinks!".
2834
9426aba4
PE
2835 * alloc.c (which_symbols): Fix alignment issue / type clash.
2836
d55c12ed
AS
28372012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2838
2839 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2840 (struct Lisp_Misc_Any): Likewise.
2841 (struct Lisp_Free): Likewise.
2842 * alloc.c (union aligned_Lisp_Symbol): Define.
2843 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2844 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2845 (union aligned_Lisp_Misc): Define.
2846 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2847 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2848 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2849
b948ce8b
PE
28502012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2851
2852 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2853 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2854 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2855 * s/netbsd.h, s/sol2-6.h:
2856 Remove definition of GC_MARK_STACK, since the default now works.
2857 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2858 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2859 no longer the default.
2860 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2861
35dc09a1 28622012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2863
35dc09a1
GM
2864 * lread.c (lisp_file_lexically_bound_p):
2865 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2866
35dc09a1
GM
28672012-04-14 Eli Zaretskii <eliz@gnu.org>
2868
2869 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2870 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2871
28722012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2873
2874 * nsterm.m (constrainFrameRect): Always constrain when there is only
2875 one screen (Bug#10962).
2876
bcd86815
KB
28772012-04-13 Ken Brown <kbrown@cornell.edu>
2878
2879 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2880
c25df26e
RT
28812012-04-13 Reuben Thomas <rrt@sc3d.org>
2882
2883 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2884
0fc59f1e
DC
28852012-04-11 Daniel Colascione <dancol@dancol.org>
2886
2887 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2888 against is gone. It's better to use vfork now so that when Cygwin
2889 gains a new, working vfork, we use it automatically (bug#10398).
2890
de8c03dc
SM
28912012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2892
2893 * window.c (save_window_save): Obey window-point-insertion-type.
2894
2f097256
GM
28952012-04-11 Glenn Morris <rgm@gnu.org>
2896
2897 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2898
453b951e
SM
28992012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2900
2901 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2902
75f1671a 29032012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
2904
2905 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2906 (force_quit_count): New var.
2907 (handle_interrupt): Use it.
2908
2a8ce227
JB
29092012-04-10 Juanma Barranquero <lekktu@gmail.com>
2910
2911 * w32.c (w32_delayed_load): Record the full path of the library
2912 being loaded (bug#10424).
2913
935396c0
GM
29142012-04-09 Glenn Morris <rgm@gnu.org>
2915
05920a43
GM
2916 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2917 not just in the obarray, before snarfing them. (Bug#11036)
2918
935396c0
GM
2919 * Makefile.in ($(leimdir)/leim-list.el):
2920 Pass EMACS rather than BUILT_EMACS.
2921
a18ecafa
TZ
29222012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2923
2924 * process.c (make_process):
2925 * process.h: Add integer `gnutls_handshakes_tried' member to
2926 process struct.
2927
6bbef4e5
JC
2928 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2929 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
2930
2931 * gnutls.c (gnutls_log_function2i): Convenience log function.
2932 (emacs_gnutls_read): Use new log functions,
2933 `gnutls_handshakes_tried' process member, and
2934 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2935 attempts per process (connection).
2936
b4d3bc10
CY
29372012-04-09 Chong Yidong <cyd@gnu.org>
2938
2939 * eval.c (Fuser_variable_p, user_variable_p_eh)
2940 (lisp_indirect_variable): Functions deleted.
2941 (Fdefvar): Caller changed.
2942
2943 * callint.c (Finteractive, Fcall_interactively):
2944 * minibuf.c (Fread_variable): Callers changed.
2945
70f4d973
EZ
29462012-04-09 Eli Zaretskii <eliz@gnu.org>
2947
2948 * xdisp.c (set_cursor_from_row): If the display string appears in
2949 the buffer at position that is closer to point than the position
2950 after the display string, display the cursor on the first glyph of
2951 the display string. Fixes cursor display when a 'display' text
2952 property immediately follows invisible text. (Bug#11094)
2953
cb3c2e3e
PE
29542012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2955
2956 composite.c: use 'double' consistently
2957 * composite.c (get_composition_id): Use 'double' consistently
2958 instead of converting 'float' to 'double' and vice versa; this is
2959 easier to understand and avoids a GCC warning.
2960
fd06db5d
GM
29612012-04-09 Glenn Morris <rgm@gnu.org>
2962
50fe702a
GM
2963 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2964 preparation for dumping it with emacs. (Bug#4789)
2965 (leimdir): New variable.
2966 ($(leimdir)/leim-list.el): New rule.
2967 (emacs$(EXEEXT)): Depend on leim-list.el.
2968
fd06db5d
GM
2969 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2970 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2971 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2972
55c131ee
AS
29732012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2974
2975 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2976 proper alignment.
2977
9209588f
JB
29782012-04-07 Juanma Barranquero <lekktu@gmail.com>
2979
2980 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2981 Remove unused local variable.
2982
e3fb2efb
PE
29832012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2984
2985 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2986 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2987 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2988 objects, as mark_maybe_pointer will catch them otherwise.
2989 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2990 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2991
b5385551
PE
29922012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2993
2994 Fix typo that broke non-Windows builds.
2995 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2996
9078ead6
EZ
29972012-04-07 Eli Zaretskii <eliz@gnu.org>
2998
2999 Support building on MS-Windows with libxml2.
3000
3001 * makefile.w32-in (OBJ2): Add xml.$(O).
3002 (GLOBAL_SOURCES): Add xml.c.
3003 ($(BLD)/xml.$(O)): New dependency list.
3004
3005 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3006 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3007 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3008 [!WINDOWSNT]: New macros.
3009 (init_libxml2_functions, libxml2_loaded_p): New functions.
3010 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3011 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3012 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3013 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3014 linked in).
6bbef4e5
JC
3015 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3016 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3017 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3018
3019 * emacs.c: Don't include libxml/parser.h.
3020 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3021 xmlCleanupParser directly.
3022
3023 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3024
3811fdf3
EZ
30252012-04-07 Eli Zaretskii <eliz@gnu.org>
3026
3027 * indent.c (Fvertical_motion): If there is a display string at
3028 point, use it.vpos to compute how many lines to backtrack after
3029 move_it_to point. (Bug#11133)
3030
2f8e16b2
EZ
30312012-04-06 Eli Zaretskii <eliz@gnu.org>
3032
3033 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3034 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3035 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3036 macros related to unification of CJK characters. For the details,
3037 see the discussion following the message here:
3038 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3039
3d439cd1
CY
30402012-04-04 Chong Yidong <cyd@gnu.org>
3041
3042 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3043
8bc53d00
EZ
30442012-04-01 Eli Zaretskii <eliz@gnu.org>
3045
3046 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3047 instead of alloca. (Bug#11138)
3048
3b0512a3
AS
30492012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3050
3051 * w32menu.c (is_simple_dialog): Properly check lisp types.
3052 (Bug#11141)
3053
8427ddd2
EZ
30542012-03-31 Eli Zaretskii <eliz@gnu.org>
3055
979022ef
EZ
3056 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3057 position we get to after a call to move_it_to fails the
3058 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3059 only if we wind up in a string from display property. (Bug#11063)
3060
a6b1c7cc
EZ
3061 * window.c (Fdelete_other_windows_internal): Invalidate the row
3062 and column information about mouse highlight, so that redisplay
3063 restores it after reallocating the glyph matrices. (Bug#7464)
3064
8427ddd2
EZ
3065 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3066 string comes from a `display' text property, use the buffer
3067 position of that property as if we actually saw that position in
3068 the row's glyphs.
697ba24b
EZ
3069 (move_it_by_lines): Remove the assertion that
3070 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3071 violated when there's a before-string at the beginning of a line.
3072 (Bug#11063)
8427ddd2 3073
65a0a738
EZ
30742012-03-30 Eli Zaretskii <eliz@gnu.org>
3075
3076 * xdisp.c (append_space_for_newline): If the default face was
3077 remapped, use the remapped face for the appended newline.
3078 (extend_face_to_end_of_line): Use the remapped default face for
3079 extending the face to the end of the line.
3080 (display_line): Call extend_face_to_end_of_line when the default
3081 face was remapped. (Bug#11068)
3082
581355cc
EZ
30832012-03-29 Eli Zaretskii <eliz@gnu.org>
3084
3085 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3086
e8fc049f
SM
30872012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3088
3089 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3090
4fb9a543
GM
30912012-03-27 Glenn Morris <rgm@gnu.org>
3092
3093 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3094 Doc fixes.
3095
679910f1
KH
30962012-03-26 Kenichi Handa <handa@m17n.org>
3097
3098 * dispextern.h (struct glyph): Fix previous change. Change the
3099 bit length of glyphless.ch to 25 (Bug#11082).
3100
90d49b7f
CY
31012012-03-26 Chong Yidong <cyd@gnu.org>
3102
3103 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3104 (command_loop_1): Use it; inhibit selection update for
3105 handle-select-window too (Bug#8996).
3106
f514f6f0
FP
31072012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3108
e8fc049f 3109 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3110
bf43fa51
KH
31112012-03-25 Kenichi Handa <handa@m17n.org>
3112
3113 * dispextern.h (struct glyph): Change the bit length of
3114 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3115
8a0c01dd
EZ
31162012-03-24 Eli Zaretskii <eliz@gnu.org>
3117
3118 * s/ms-w32.h (tzname): Include time.h before redirecting to
3119 _tzname. Fixes the MSVC build. (Bug#9960)
3120
7d1c3a76
AS
31212012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3122
8ed79523
AS
3123 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3124 characters.
3125
7d1c3a76
AS
3126 * xterm.c (XTread_socket): Only modify handling_signal if
3127 !SYNC_INPUT. (Bug#11080)
3128
e99a9b8b
EZ
31292012-03-23 Eli Zaretskii <eliz@gnu.org>
3130
3131 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3132 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3133 when fetching a multibyte character consumes more bytes than
3134 CHAR_BYTES returns, due to unification of CJK characters in
3135 string_char. (Bug#11073)
3136
5063c0e1
TN
31372012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3138
3139 * process.c (wait_reading_process_output): Handle pty disconnect
3140 by refraining from sending oneself a SIGCHLD (bug#10933).
3141
9f851fbd
CY
31422012-03-22 Chong Yidong <cyd@gnu.org>
3143
3144 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3145
5063c0e1 3146 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3147 Mark string as coming from a prefix property.
3148 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3149 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3150
fb5b8aca
CY
31512012-03-21 Chong Yidong <cyd@gnu.org>
3152
3153 * xfaces.c (Vface_remapping_alist): Doc fix.
3154
62356a1b
EZ
31552012-03-20 Eli Zaretskii <eliz@gnu.org>
3156
3157 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3158 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3159 Doc fixes.
62356a1b 3160
025de85b
CY
31612012-03-20 Chong Yidong <cyd@gnu.org>
3162
3163 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3164 to reflect default non-nil value of redisplay-dont-pause.
3165
4827f94e
KH
31662012-03-19 Kenichi Handa <handa@m17n.org>
3167
3168 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3169 it fit in a valid range (Bug#11003).
3170
e50a24a2
EZ
31712012-03-18 Eli Zaretskii <eliz@gnu.org>
3172
3173 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3174 that is not from display property, accept the row as a "cursor
3175 row" if one of the string's character has a non-nil `cursor'
3176 property. Fixes cursor positioning when there are newlines in
3177 overlay strings, e.g. in icomplete.el. (Bug#11035)
3178
9af5ed87
PE
31792012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3180
3181 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3182
d1f55f16
CY
31832012-03-12 Chong Yidong <cyd@gnu.org>
3184
3185 * eval.c (inhibit_lisp_code): Rename from
3186 inhibit_window_configuration_change_hook; move from window.c.
3187
3188 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3189 * window.c (run_window_configuration_change_hook)
3190 (syms_of_window): Callers changed.
3191
66c5eebd
CY
31922012-03-11 Chong Yidong <cyd@gnu.org>
3193
413df973
CY
3194 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3195
66c5eebd
CY
3196 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3197
1de11f56
CY
31982012-03-10 Chong Yidong <cyd@gnu.org>
3199
3200 * frame.c (other_visible_frames): Don't assume the selected frame
3201 is visible (Bug#10955).
3202
cae07000
SM
32032012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3204
3205 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3206
89c94350
JD
32072012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3208
3209 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3210 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3211 zero (Bug#10954).
3212
999dd333
GM
32132012-03-03 Glenn Morris <rgm@gnu.org>
3214
01a6dcc8 3215 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3216
de0100f2
EZ
32172012-03-02 Eli Zaretskii <eliz@gnu.org>
3218
3219 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3220 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3221 (redisplay_window, next_element_from_string): Fix typos in
3222 comments.
3e441275
EZ
3223 (redisplay_window): Pass to move_it_vertically the margin in
3224 pixels, not in screen lines.
de0100f2 3225
96a72ee9
GM
32262012-03-02 Glenn Morris <rgm@gnu.org>
3227
3228 * buffer.c (buffer-list-update-hook): Doc fix.
3229
312508d7
EZ
32302012-02-29 Eli Zaretskii <eliz@gnu.org>
3231
3232 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3233 push_it before setting up the iterator for the first overlay
3234 string, even if we have an empty string loaded.
3235 (next_overlay_string): If there's an empty string on the iterator
3236 stack, pop the stack. (Bug#10903)
3237
27f3c637
PE
32382012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3239
3240 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3241 Suggested by Stefan Monnier in
3242 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3243 * alloc.c (widen_to_Lisp_Object): New static function.
3244 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3245 and widening them to Lisp_Objects. This would work even if
3246 USE_LSB_TAG is defined and wide integers are used, which might
3247 happen in a future version of Emacs.
3248
3c9dfce6
CY
32492012-02-25 Chong Yidong <cyd@gnu.org>
3250
fa74b241
CY
3251 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3252 Doc fix.
3253
3c9dfce6
CY
3254 * xselect.c (Fx_selection_exists_p): Doc fix.
3255 (x_clipboard_manager_save_all): Print an informative message
3256 before saving to clipboard manager.
3257
9486df08
CY
32582012-02-24 Chong Yidong <cyd@gnu.org>
3259
3260 * keyboard.c (process_special_events): Handle all X selection
3261 requests in kbd_buffer, not just the next one (Bug#8869).
3262
f01d3321
CY
32632012-02-23 Chong Yidong <cyd@gnu.org>
3264
3265 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3266 call when setting menu-bar-lines and tool-bar-lines parameters.
3267 (unwind_create_frame_1): New helper function.
3268
3269 * window.c (inhibit_window_configuration_change_hook): New var.
3270 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 3271 (syms_of_window): Initialize it.
f01d3321 3272
86b847b6
CY
32732012-02-22 Chong Yidong <cyd@gnu.org>
3274
3275 * xterm.c (x_draw_image_relief): Add missing type check for
3276 Vtool_bar_button_margin (Bug#10743).
3277
a59225b1
CY
32782012-02-21 Chong Yidong <cyd@gnu.org>
3279
3280 * fileio.c (Vfile_name_handler_alist): Doc fix.
3281
3282 * buffer.c (Fget_file_buffer): Protect against invalid file
3283 handler return value.
3284
310f5bd4
PE
32852012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3286
cb3a28cc
PE
3287 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3288 when computing $valmask.
3289
310f5bd4
PE
3290 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3291 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3292 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3293 It's useless in that case, and it can cause problems on hosts
3294 that allocate halves of EMACS_INT values separately.
3295 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3296 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3297 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3298 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3299 it avoids undefined behavior on hosts where shifting right by more
3300 than the word width has undefined behavior.
3301
2375c96a
CY
33022012-02-19 Chong Yidong <cyd@gnu.org>
3303
3304 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3305 (Funhandled_file_name_directory, Ffile_name_as_directory)
3306 (Fdirectory_file_name, Fexpand_file_name)
3307 (Fsubstitute_in_file_name): Protect against invalid file handler
3308 return values (Bug#10845).
3309
3eb49e71
EZ
33102012-02-18 Eli Zaretskii <eliz@gnu.org>
3311
3312 * .gdbinit (pitx): Fix incorrect references to fields of the
3313 iterator stack.
3314
7b926f3f
CY
33152012-02-17 Chong Yidong <cyd@gnu.org>
3316
3317 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3318
11273115
PE
33192012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3320
3321 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3322 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3323
c3a70e2b
CY
33242012-02-15 Chong Yidong <cyd@gnu.org>
3325
3326 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3327 marked as special. Also, starting docstrings with * is obsolete.
3328
0ca43699
AS
33292012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3330
3331 * gnutls.c (emacs_gnutls_write): Fix last change.
3332
2e8f3c56
LI
33332012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3334
3335 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3336 send_process.
3337
af70074f
SM
33382012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3339
3340 * keymap.c (Fsingle_key_description): Handle char ranges.
3341
95986d52
CY
33422012-02-12 Chong Yidong <cyd@gnu.org>
3343
afd83bd1
CY
3344 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3345 as that creates a dangerous corner case.
3346
95986d52
CY
3347 * window.c (Fdelete_window_internal): Invalidate the mouse
3348 highlight (Bug#9904).
3349
bd7da63e
GM
33502012-02-12 Glenn Morris <rgm@gnu.org>
3351
3352 * xselect.c (Fx_own_selection_internal)
3353 (Fx_get_selection_internal, Fx_disown_selection_internal)
3354 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3355 * nsselect.m (Fx_own_selection_internal)
3356 (Fx_disown_selection_internal, Fx_selection_exists_p)
3357 (Fx_selection_owner_p, Fx_get_selection_internal):
3358 Sync docs and argument specs with the xselect.c versions.
3359
77abcbc2
LI
33602012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3361
3362 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3363
90b671e2
EZ
33642012-02-11 Eli Zaretskii <eliz@gnu.org>
3365
1c0ca0b7
EZ
3366 * w32select.c (Fx_selection_exists_p): Sync doc string and
3367 argument list with xselect.c. (Bug#10783)
3368
3369 * w16select.c (Fx_selection_exists_p): Sync doc string and
3370 argument list with xselect.c. (Bug#10783)
90b671e2 3371
49241268
GM
33722012-02-10 Glenn Morris <rgm@gnu.org>
3373
3374 * fns.c (Fsecure_hash): Doc fix.
3375
f998bbe7 33762012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3377
3378 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3379
0992bd9c
CY
33802012-02-07 Chong Yidong <cyd@gnu.org>
3381
3382 * buffer.c (Fbuffer_local_variables)
3383 (buffer_lisp_local_variables): Handle unbound vars correctly;
3384 don't let Qunbound leak into Lisp.
3385
af008560
GM
33862012-02-07 Glenn Morris <rgm@gnu.org>
3387
dd605cc4
GM
3388 * image.c (Fimagemagick_types): Doc fix.
3389
af008560
GM
3390 * image.c (imagemagick-render-type): Change it from a lisp object
3391 to an integer. Move the doc here from the lisp manual.
3392 Treat all values not equal to 0 the same.
3393
1449fa1d
CY
33942012-02-06 Chong Yidong <cyd@gnu.org>
3395
3396 * doc.c (store_function_docstring): Avoid applying docstring of
3397 alias to base function (Bug#2603).
3398
3723ec07
AS
33992012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3400
3401 * .gdbinit (pp1, pv1): Remove redundant defines.
3402 (pr): Use pp.
3403
79c1cc1e
CY
34042012-02-04 Chong Yidong <cyd@gnu.org>
3405
3406 * nsterm.m: Declare a global (Bug#10694).
3407
d7f29f8e
EZ
34082012-02-04 Eli Zaretskii <eliz@gnu.org>
3409
cae07000
SM
3410 * w32.c (get_emacs_configuration_options):
3411 Include --enable-checking, if specified, in the return value.
d7f29f8e 3412
3b95a6f9
MR
34132012-02-04 Martin Rudalics <rudalics@gmx.at>
3414
3415 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3416 after rounding frame sizes. (Bug#9723)
3417
d6fa96a6
EZ
34182012-02-04 Eli Zaretskii <eliz@gnu.org>
3419
3420 * keyboard.c (adjust_point_for_property): Don't position point
3421 before BEGV. (Bug#10696)
3422
df0b2940
PE
34232012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3424
3425 Handle overflow when computing char display width (Bug#9496).
3426 * character.c (char_width): Return EMACS_INT, not int.
3427 (char_width, c_string_width): Check for overflow when
3428 computing the width; this is possible now that individual
3429 characters can have unbounded width. Problem introduced
3430 by merge from Emacs 23 on 2012-01-19.
3431
6bee44d6
MA
34322012-02-02 Michael Albinus <michael.albinus@gmx.de>
3433
3434 * dbusbind.c (Fdbus_register_method): Mention the return value
3435 :ignore in the docstring.
3436
44f92739
GM
34372012-02-02 Glenn Morris <rgm@gnu.org>
3438
1b9f60cc
GM
3439 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3440
44f92739
GM
3441 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3442 Unconditionally set to t. (Bug#10673)
3443 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3444 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3445 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3446
c5d3843c
KH
34472012-02-02 Kenichi Handa <handa@m17n.org>
3448
3449 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3450 0, do not call append_composite_glyph.
3451
159462d4 34522012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3453
3454 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3455 NULL (Bug#6988).
3456 (x_produce_glyphs): If the component of a composition is a null
3457 string, set it->pixel_width to 1 to avoid zero-width glyph.
3458
78cef877
EZ
34592012-02-01 Eli Zaretskii <eliz@gnu.org>
3460
3461 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3462 first 2 arguments are identical. This makes inserting large
3463 output from a subprocess an order of magnitude faster on
3464 MS-Windows, where all sbrk'ed memory is always contiguous.
3465
97897668
GM
34662012-01-31 Glenn Morris <rgm@gnu.org>
3467
3468 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3469 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3470 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3471
31fd3586
GM
34722012-01-29 Glenn Morris <rgm@gnu.org>
3473
3474 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3475
0e24a8b2
CY
34762012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3477
3478 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3479
cc0adcb0
CY
34802012-01-28 Chong Yidong <cyd@gnu.org>
3481
3482 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3483
acc28cb9
CY
34842012-01-26 Chong Yidong <cyd@gnu.org>
3485
9c69cfb7
CY
3486 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3487
acc28cb9
CY
3488 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3489 repeat counts (Bug#10507).
3490
48da7392
GM
34912012-01-26 Glenn Morris <rgm@gnu.org>
3492
3493 * lread.c (syms_of_lread): Doc fix.
3494
14af5f7f
CY
34952012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3496
3497 * coding.c (encode_designation_at_bol): Change return value to
3498 EMACS_INT.
3499
0b21c100
CY
35002012-01-25 Chong Yidong <cyd@gnu.org>
3501
3502 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3503
3c2907f7
CY
35042012-01-21 Chong Yidong <cyd@gnu.org>
3505
3506 * floatfns.c (Fcopysign): Make the second argument non-optional,
3507 since nil is not allowed anyway.
3508
959ad23f
AS
35092012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3510
3511 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3512 (send_process): Likewise.
3513
34a02f46
MR
35142012-01-19 Martin Rudalics <rudalics@gmx.at>
3515
3516 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3517 (Vwindow_persistent_parameters): Do not use Qstate.
3518 Rewrite doc-strings.
34a02f46 3519
1259009a 35202012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3521
3522 * character.c (char_width): New function.
70d4fdf6
GM
3523 (Fchar_width, c_string_width, lisp_string_width):
3524 Use char_width (Bug#9496).
25ed9e61 3525
6a6ee00d
MR
35262012-01-16 Martin Rudalics <rudalics@gmx.at>
3527
3528 * window.c (Vwindow_persistent_parameters): New variable.
3529 (Fset_window_configuration, save_window_save): Handle persistent
3530 window parameters.
3531
c85efaf7
EZ
35322012-01-14 Eli Zaretskii <eliz@gnu.org>
3533
3534 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3535 thrashing the stack of the thread. (Bug#9087)
3536
5944709e
PE
35372012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3538
3539 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3540
e71f5d99
EZ
35412012-01-11 Eli Zaretskii <eliz@gnu.org>
3542
3543 * xdisp.c (rows_from_pos_range): Handle the case where the
3544 highlight ends on a newline. (Bug#10464)
3545 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3546 he end column for display of highlight that ends on a newline
3547 before a R2L line.
3548
ce316182
GM
35492012-01-11 Glenn Morris <rgm@gnu.org>
3550
3551 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3552 from load-path also when installation-directory is nil. (Bug#10208)
3553
5b43da69
GM
35542012-01-10 Glenn Morris <rgm@gnu.org>
3555
74cc8ff9
GM
3556 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3557
7d8d6e4e
GM
3558 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3559 Update template values to be closer to their typical values these days.
5b43da69 3560
a0db8d43
EZ
35612012-01-09 Eli Zaretskii <eliz@gnu.org>
3562
3563 * xdisp.c (rows_from_pos_range): Accept additional argument
3564 DISP_STRING, and accept any glyph in a row whose object is that
3565 string as eligible for mouse highlight. Fixes mouse highlight of
3566 display strings from overlays. (Bug#10464)
3567
9a0115ab 35682012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3569
b9110d6a 3570 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3571 * fileio.c (auto_saving_dir_umask): New static var.
3572 (Fmake_directory_internal): Use it.
3573 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3574 creating the directory. The old code temporarily assigns
3575 too-generous permissions to the directory.
3576 (do_auto_save_eh): Clear it.
b9110d6a 3577 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3578 that the var is always cleared.
3579
6c1bd3f3
EZ
35802012-01-07 Eli Zaretskii <eliz@gnu.org>
3581
3582 * search.c (scan_buffer): Pass character positions to
3583 know_region_cache, not byte positions. (Bug#6540)
3584
069d2b50
L
35852012-01-07 LynX <_LynX@bk.ru> (tiny change)
3586
3587 * w32.c (sys_rename): Report EXDEV when rename of a directory
3588 fails because the target is on another logical disk. (Bug#10284)
3589
75bf0d33
DB
35902012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3591
3592 * xterm.c (x_embed_request_focus): New function.
3593
3594 * xterm.h: Add prototype.
3595
3596 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3597
1c6e5a32
GM
35982012-01-05 Glenn Morris <rgm@gnu.org>
3599
3600 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3601
651e947e
EZ
36022012-01-01 Eli Zaretskii <eliz@gnu.org>
3603
3604 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3605 Load gnutls_transport_set_lowat only if GnuTLS version is below
3606 2.11.1.
3607 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3608 GnuTLS versions below 2.11.1.
3609
3778cdd8
AL
36102011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3611
3612 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3613 to the doc string advising against its use for altering the way
3614 windows are scrolled.
3615
0e5317f7
KH
36162011-12-28 Kenichi Handa <handa@m17n.org>
3617
3618 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3619 coding-system ASCII compatible only when it does not produce BOM
3620 on encoding (Bug#10383).
3621
93d5ca1f
JD
36222011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3623
3624 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3625 can scroll.
3626 (create_and_show_popup_menu): Always use menu_position_func for
3627 Gtk3 (Bug#10361).
3628
ca22b785
AS
36292011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3630
3631 * callint.c (Fcall_interactively): Don't truncate prompt string.
3632
d048e1e6
EZ
36332011-12-23 Eli Zaretskii <eliz@gnu.org>
3634
3635 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3636 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 3637 resumed from there (after widening). (Bug#10360)
d048e1e6 3638
5ccaba1f
JD
36392011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3640
3641 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3642
204ee57f
JD
36432011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3644
b81d40f0
JB
3645 * nsterm.m (x_free_frame_resources):
3646 Release f->output_data.ns->miniimage.
204ee57f
JD
3647 (ns_index_color): Fix indentation. Do not retain
3648 color_table->colors[i].
3649
3650 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3651 before returning.
3652
3653 * nsfns.m (x_set_background_color): Assign return value from
3654 ns_index_color to face-background instead of NSColor*.
3655 (ns_implicitly_set_icon_type): Fix indentation.
3656 Change assignment in for loop to comparison.
3657
3658 * emacs.c (ns_pool): New variable.
3659 (main): Assign ns_pool.
3660 (Fkill_emacs): Call ns_release_autorelease_pool.
3661
3662 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3663 autorelease fdesc, release fdAttrs and tdict.
3664 (ns_get_covering_families): Release charset.
3665 (ns_findfonts): Release NSFontDescriptor created with new.
3666 (ns_uni_to_glyphs): Fix indentation.
3667 (setString): Release attrStr before assigning new value.
3668
c803b2b7
JD
36692011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3670
678f4426
JD
3671 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3672 and NS_IMPL_COCOA.
3673 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3674 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3675
cd394be1 36762011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3677
5fecd5fc
JD
3678 * nsterm.m (ns_term_init): Subscribe for notifications
3679 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3680 to method trackingNotification in EmacsMenu.
3681
3682 * nsmenu.m (trackingMenu): New variable.
3771cb17 3683 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3684 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3685 from Aquamacs (Bug#7030).
678f4426
JD
3686
36872011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3688
c803b2b7
JD
3689 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3690 (symbol_to_nsstring): Fix indentation.
3691 (ns_symbol_to_pb): New function.
cae07000
SM
3692 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3693 (Fns_rotate_cut_buffers_internal): Remove.
3694 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3695 Fns_store_cut_buffer_internal.
3696 (ns_get_foreign_selection, Fx_own_selection_internal)
3697 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3698 (Fns_get_selection_internal, Fns_store_selection_internal):
3699 Use ns_symbol_to_pb and check if return value is nil.
3700 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3701 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3702 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3703 renamed to Sns_store_selection_internal.
3704 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3705 and remove this function.
3706 (ns_handle_selection_clear): Remove, never used.
3707 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3708 here.
3709
e1b01a3a
KB
37102011-12-17 Ken Brown <kbrown@cornell.edu>
3711
3712 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3713 GID is unknown (Bug#10257).
3714
2adb6e85
PE
37152011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3716
3717 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3718 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3719 which caused a build failure on GNU/Linux IA-64. This problem was
3720 introduced by my 2011-10-07 patch.
3721
d1d7b339
JL
37222011-12-15 Juri Linkov <juri@jurta.org>
3723
3724 * image.c (imagemagick_error): New function. (Bug#10112)
3725 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3726 Use `imagemagick_error' where ImageMagick functions return
3727 `MagickFalse'.
3728 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3729 proper order.
3730
100d5755
KH
37312011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3732
3733 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3734 fill background (Bug#8992).
3735
454592a6
MR
37362011-12-13 Martin Rudalics <rudalics@gmx.at>
3737
3738 * window.c (Vwindow_combination_resize)
3739 (Vwindow_combination_limit): Use t instead of non-nil in
3740 doc-strings.
61d4b438
MR
3741 (Vrecenter_redisplay): Add first sentence of doc-string on
3742 separate line.
53524d93 3743 (Frecenter): Fix doc-string typo.
454592a6 3744
3633e3aa
KH
37452011-12-11 Kenichi Handa <handa@m17n.org>
3746
3747 * coding.c (Funencodable_char_position): Pay attention to the
3748 buffer text relocation (Bug#9389).
3749
7b9d523a 37502011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3751
7b9d523a
JD
3752 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3753 gtk_init (Bug#10100).
3754
b73189c6
EZ
37552011-12-10 Eli Zaretskii <eliz@gnu.org>
3756
3757 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3758 IT->string is nil. (Bug#10263)
3759
f7dfe5d6
JD
37602011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3761
83faebb4
JD
3762 * nsterm.h (x_free_frame_resources): Declare.
3763
f7dfe5d6
JD
3764 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3765 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3766
3767 * nsterm.h (ns_get_defaults_value): Declare.
3768
3769 * nsterm.m (ns_default): Call ns_get_defaults_value.
3770
7cd4e72c
EZ
37712011-12-09 Eli Zaretskii <eliz@gnu.org>
3772
3773 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3774 (Bug#10170)
3775
b34d7317
YM
37762011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3777
3778 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3779 that where the value of an _OBJC_* symbol points to is in the .bss
3780 section (Bug#10240).
3781
76470ad1
KH
37822011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3783
3784 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3785 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3786
745fff94
KH
37872011-12-08 Kenichi Handa <handa@m17n.org>
3788
3789 * ftfont.c (get_adstyle_property): Fix previous change
3790 (Bug#10233).
3791
6e44397c
JB
37922011-12-07 Juanma Barranquero <lekktu@gmail.com>
3793
3794 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3795 dirs from the default value of EMACSLOADPATH (bug#10208).
3796
7efa6272
GM
37972011-12-07 Glenn Morris <rgm@gnu.org>
3798
3799 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3800 installation and source directories as well. (Bug#10208)
3801
f6fc4d87
CY
38022011-12-06 Chong Yidong <cyd@gnu.org>
3803
3804 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3805
2bf26180
GM
38062011-12-06 Glenn Morris <rgm@gnu.org>
3807
3808 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3809 as an error, not just -1. (Bug#10217)
3810
3a6ad4f0
CY
38112011-12-05 Chong Yidong <cyd@gnu.org>
3812
3813 * keyboard.c (process_special_events): New function.
3814 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3815
75a3b399
PE
38162011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3817
3818 * coding.c (encode_designation_at_bol): Don't use uninitialized
3819 local variable (Bug#9318).
3820
c3c9e25e
KH
38212011-12-05 Kenichi Handa <handa@m17n.org>
3822
3823 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3824 return Qnil (Bug#8046, Bug#10193).
3825
5eb05ea3
KH
38262011-12-05 Kenichi Handa <handa@m17n.org>
3827
3828 * coding.c (encode_designation_at_bol): New args charbuf_end and
3829 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3830 (coding_set_source): Return how many bytes coding->source was
3831 relocated.
3832 (coding_set_destination): Return how many bytes
3833 coding->destination was relocated.
3834 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3835 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3836
38372011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3838
3839 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3840 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3841 macro (Bug#9318).
3842
38432011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3844
3845 The following changes are to fix Bug#9318.
3846
a79703f5 3847 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3848 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3849 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3850 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3851
7dbda6df
JB
38522011-12-05 Juanma Barranquero <lekktu@gmail.com>
3853
3854 * lisp.h (process_quit_flag): Fix external declaration.
3855
6d5eb5b0
SM
38562011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3857
3858 Don't macro-inline non-performance-critical code.
3859 * eval.c (process_quit_flag): New function.
3860 * lisp.h (QUIT): Use it.
3861
a0c3fad0
JD
38622011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3863
3864 * nsfns.m (get_geometry_from_preferences): New function.
3865 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3866
6c07aac2
AS
38672011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3868
3869 * emacs.c (Qkill_emacs): Define.
3870 (syms_of_emacs): Initialize it.
3871 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3872 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3873 (quit_throw_to_read_char): Add parameter `from_signal'.
3874 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3875 * lisp.h (QUIT): Call Fkill_emacs if requested.
3876
c052ead4
JD
38772011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3878
3879 * widget.c (update_wm_hints): Return if wmshell is null.
3880 (widget_update_wm_size_hints): New function.
3881
3882 * widget.h (widget_update_wm_size_hints): Declare.
3883
3884 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3885 widget_update_wm_size_hints (Bug#10104).
3886
9e49252b
EZ
38872011-12-03 Eli Zaretskii <eliz@gnu.org>
3888
3889 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3890 before a newline, prepare the bidi iterator for consuming the
3891 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3892 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3893
02b16839
JL
38942011-12-02 Juri Linkov <juri@jurta.org>
3895
3896 * search.c (Fword_search_regexp): New Lisp function created from
3897 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3898 (Fword_search_backward, Fword_search_forward)
3899 (Fword_search_backward_lax, Fword_search_forward_lax):
3900 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3901 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3902
0068070e
SM
39032011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3904
3905 * fileio.c (Finsert_file_contents): Move after-change-function call
3906 to before the "handled:" label, since all "goto handled" appear in
3907 cases where the *-change-functions have already been properly called
3908 (bug#10117).
3909
3360a3fc
AS
39102011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3911
3912 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3913 waiting for input. (Bug#10169)
3914
73d6c093
EZ
39152011-11-30 Eli Zaretskii <eliz@gnu.org>
3916
3917 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3918 verifies glyph row's hash code--we have just reallocated the
3919 glyphs, so their contents can be complete garbage. (Bug#10164)
3920
febe6bea
JB
39212011-11-30 Juanma Barranquero <lekktu@gmail.com>
3922
3923 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3924
801a4313
EZ
39252011-11-30 Eli Zaretskii <eliz@gnu.org>
3926
3927 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3928 attributes are tested _before_ calling verify_row_hash, to protect
3929 against GCC re-ordering of the tests. (Bug#10164)
3930
2b56b87e
JD
39312011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3932
3933 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3934
3935 * xterm.c (handle_one_xevent): Only set async_visible and friends
3936 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 3937 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
3938 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3939
dbf31225
PE
39402011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3941
3942 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3943 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3944 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3945 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3946 All uses changed to use GCPRO1 etc.
3947 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3948 Revert to old implementation (i.e., before 2011-03-11).
3949
1305621b
YM
39502011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3951
3952 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3953 of scroll runs so as to avoid assigning disabled bogus rows and
3954 unnecessary graphics copy operations.
3955
8c9afb46
EZ
39562011-11-27 Eli Zaretskii <eliz@gnu.org>
3957
3958 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3959 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3960 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3961 (malloc, free, realloc, calloc): Redirect to e_* only when
3962 compiling Emacs.
3963
3964 * lisp.h (GCTYPEBITS): Move before first use.
3965 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3966 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3967 this macro definition.
3968
3969 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3970 _MSC_VER.
3971
54e9e3bf
JD
39722011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3973
6d5eb5b0
SM
3974 * gtkutil.c (xg_create_frame_widgets):
3975 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3976 present with Gtk+ 2.0.
3977
83aca1cb
PE
39782011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3979
3980 * fileio.c (Finsert_file_contents): Undo previous change; see
3981 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3982
5b76caa4
PE
39832011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3984
3985 Rename locals to avoid shadowing.
3986 * fileio.c (Finsert_file_contents):
3987 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3988 * process.c (wait_reading_process_output):
3989 Rename inner 'proc' to 'p' to avoid shadowing.
3990 Indent for consistency with usual Emacs style.
3991
8c535114
EZ
39922011-11-25 Eli Zaretskii <eliz@gnu.org>
3993
3994 * xdisp.c (redisplay_window): If cursor row is not fully visible
3995 after recentering, and scroll-conservatively is set to a large
3996 number, scroll window by a few more lines to make the cursor fully
3997 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3998 (start_display): Don't move to the next line if the display should
3999 start at a newline that is part of a display vector or an overlay
4000 string. (Bug#10119)
8c535114 4001
fa4fdb5c
JL
40022011-11-24 Juri Linkov <juri@jurta.org>
4003
4004 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4005 after the `MagickPingImage' call. (Bug#10112)
4006
90ec88df
CY
40072011-11-23 Chong Yidong <cyd@gnu.org>
4008
4009 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4010
56e2e794
MR
40112011-11-23 Martin Rudalics <rudalics@gmx.at>
4012
4013 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4014 making another buffer current. (Bug#10114)
4015
b6e64c41
GM
40162011-11-23 Glenn Morris <rgm@gnu.org>
4017
4018 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4019
6b21de18
CY
40202011-11-23 Chong Yidong <cyd@gnu.org>
4021
4022 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4023 using it (Bug#5984).
4024
b12cd789
EZ
40252011-11-22 Eli Zaretskii <eliz@gnu.org>
4026
4027 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4028 and header-lines, as they don't have one computed for them.
4029 (Bug#10098)
4030
4031 * .gdbinit (prow): Make displayed values more self-explaining.
4032 Add row's hash code.
4033
261b6fd4
LMI
40342011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4035
4036 * process.c (wait_reading_process_output): Fix asynchrounous
4037 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4038 (wait_reading_process_output): Add comment and URL.
261b6fd4 4039
e7cfd277
JD
40402011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4041
4042 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4043
a9b9b7f5
CY
40442011-11-21 Chong Yidong <cyd@gnu.org>
4045
4046 * window.c (Fnext_window, Fprevious_window): Doc fix.
4047
b0d15b4f
SM
40482011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4049
4050 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4051
fe7a3057
JB
40522011-11-20 Juanma Barranquero <lekktu@gmail.com>
4053
4054 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4055
d2999b1a
MR
40562011-11-20 Martin Rudalics <rudalics@gmx.at>
4057
4058 * window.c (Fset_window_combination_limit): Rename argument
4059 STATUS to LIMIT.
4060 (Vwindow_combination_limit): Remove "status" from doc-string.
4061
d5ff9cd0
AS
40622011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4063
4064 * m/ibms390.h: Remove.
4065 * m/ibms390x.h: Don't include "ibms390.h".
4066
a5bb9bd3
SM
40672011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4068
4069 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4070 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4071
cd1181db
JB
40722011-11-20 Juanma Barranquero <lekktu@gmail.com>
4073
4074 * casetab.c (Fset_case_table):
4075 * charset.c (Fcharset_after): Fix typos.
4076
615a3b8d 40772011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4078
17e845af
PE
4079 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4080 Otherwise, valgrind does not work on some platforms.
4081 Problem reported by Andreas Schwab in
6a0bf43d
PE
4082 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4083 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4084 is set, removing the need for VIRT_ADDRESS_VARIES.
4085 (PURE_P): Use a more-efficient implementation that needs just one
4086 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4087 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4088 to 4 (xorl, subq, cmpq, setbe).
4089 * alloc.c (pure): Always extern now, since that's the
4090 VIRT_ADDR_VARIES behavior.
4091 (PURE_POINTER_P): Use a single comparison, not two, for
4092 consistency with the new puresize.h.
4093 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4094 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4095 Remove VIRT_ADDR_VARIES no longer needed.
4096
f8fe6f96
EZ
40972011-11-19 Eli Zaretskii <eliz@gnu.org>
4098
4099 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4100 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4101 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4102 behave as if the cursor position were at the window margin.
4103
4104 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4105 and the cursor position is out of bounds, behave as if the cursor
4106 position were at the window margin. (Bug#10075)
4107
df05a53c
CY
41082011-11-18 Chong Yidong <cyd@gnu.org>
4109
4110 * window.c (Fwindow_combination_limit): Make first argument
4111 non-optional, since it is meaningless for live windows like the
4112 selected window.
61ccba97 4113
2071918e
DA
41142011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4115
4116 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4117
b50a28de
SM
41182011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4119
4120 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4121 (graft_intervals_into_buffer): Simplify.
4122
015137db
EZ
41232011-11-18 Eli Zaretskii <eliz@gnu.org>
4124
4125 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4126 hash values of the two rows.
4127 (copy_row_except_pointers): Preserve the used[] arrays and the
4128 hash values of the two rows. (Bug#10035)
68c95424 4129 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4130
4131 * xdisp.c (row_hash): New function, body extracted from
4132 compute_line_metrics.
4133 (compute_line_metrics): Call row_hash, instead of computing the
4134 hash code inline.
4135
4136 * dispnew.c (verify_row_hash): Call row_hash for computing the
4137 hash code of a row, instead of duplicating code from xdisp.c.
4138
4139 * dispextern.h (row_hash): Add prototype.
4140
a2addb04
TH
41412011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4142
4143 * frame.c (delete_frame): Don't delete the terminal when the last
4144 X frame is closed if emacs is built with GTK toolkit.
4145
df85d315
JB
41462011-11-17 Juanma Barranquero <lekktu@gmail.com>
4147
4148 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4149
a0c2d0ae
MR
41502011-11-17 Martin Rudalics <rudalics@gmx.at>
4151
4152 * window.c (Vwindow_splits): Rename to
4153 Vwindow_combination_resize. Suggested by Juri Linkov.
4154 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4155 of Vwindow_splits.
4156
58179cce
JB
41572011-11-16 Juanma Barranquero <lekktu@gmail.com>
4158
7877f373
JB
4159 * nsfns.m (Fns_font_name):
4160 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4161
b6f67890
MR
41622011-11-16 Martin Rudalics <rudalics@gmx.at>
4163
4164 * window.h (window): Rename slot "nest" to "combination_limit".
4165 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4166 (Fset_window_nest): Rename to Fset_window_combination_limit.
4167 (Vwindow_nest): Rename to Vwindow_combination_limit.
4168 (recombine_windows, make_parent_window, make_window)
4169 (Fsplit_window_internal, saved_window)
4170 (Fset_window_configuration, save_window_save): Rename all
4171 occurrences of window_nest to window_combination_limit.
4172
c7015153
JB
41732011-11-15 Juanma Barranquero <lekktu@gmail.com>
4174
4175 * image.c (imagemagick_load_image): Fix typo.
4176
322ad6ec
EZ
41772011-11-14 Eli Zaretskii <eliz@gnu.org>
4178
4179 * xdisp.c (display_line): Move the call to
4180 highlight_trailing_whitespace before the call to
4181 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4182 faces of all the glyphs to compute ROW's hash value.
4183 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4184
f067b8ec
JB
41852011-11-14 Juanma Barranquero <lekktu@gmail.com>
4186
4187 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4188 just return (bug#10044).
4189
1e5b2111
EZ
41902011-11-12 Eli Zaretskii <eliz@gnu.org>
4191
7ef3cbd5
EZ
4192 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4193 with user-defined heap size. Bump the default size of the temacs
4194 heap to 27MB, to avoid memory warning when running temacs.
4195 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4196
1e5b2111
EZ
4197 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4198 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4199 (verify_row_hash) [XASSERTS]: New function.
4200 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4201 that the hash value of glyph rows is correct.
1e5b2111 4202
89d61221
MR
42032011-11-12 Martin Rudalics <rudalics@gmx.at>
4204
4205 * window.h (window): Remove splits slot.
4206 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4207 (Fdelete_other_windows_internal, make_parent_window)
4208 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4209 (Fset_window_configuration, save_window_save): Don't deal with
4210 split status of windows.
4211 (saved_window): Remove splits slot.
4212 (Vwindow_splits): Rewrite doc-string.
4213
97f18cc8
JD
42142011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4215
4216 * xfns.c (unwind_create_frame):
4217 * nsfns.m (unwind_create_frame):
4218 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4219 Vframe_list (Bug#9999).
4220
22a648b4
DA
42212011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4222
0b381c7e 4223 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 4224
659afede
KH
42252011-11-11 Kenichi Handa <handa@m17n.org>
4226
4227 * callproc.c (Fcall_process): Set the member dst_multibyte of
4228 process_coding.
4229
9ac0394b
KH
42302011-11-11 Johan Bockgård <bojohan@gnu.org>
4231
4232 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4233 avoid a crash (bug#9496).
4234
2fbdc249
CY
42352011-11-09 Chong Yidong <cyd@gnu.org>
4236
4237 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4238 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4239
ac6b1f81
PE
42402011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4241
4242 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4243
09db192c
PE
42442011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4245
4246 Avoid some portability problems by eschewing 'extern inline' functions.
4247 The trivial performance wins aren't worth the portability hassles; see
4248 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4249 et seq.
4250 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4251 (window_box_width, window_box_left, window_box_left_offset)
4252 (window_box_right, window_box_right_offset): Undo previous change,
4253 by removing the "extern"s.
4254 * intervals.c (adjust_intervals_for_insertion)
4255 (adjust_intervals_for_deletion): Undo previous change,
4256 making these static again.
4257 (offset_intervals, temp_set_point_both, temp_set_point)
4258 (copy_intervals_to_string): No longer inline.
4259 * xdisp.c (window_text_bottom_y, window_box_width)
4260 (window_box_height, window_box_left_offset)
4261 (window_box_right_offset, window_box_left, window_box_right)
4262 (window_box): No longer inline.
4263
105216ed
CY
42642011-11-08 Chong Yidong <cyd@gnu.org>
4265
4266 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
4267 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4268 Signal an error if not a live window.
105216ed
CY
4269 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4270 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4271
ae9e237f
JB
42722011-11-07 Juanma Barranquero <lekktu@gmail.com>
4273
4274 * lisp.h (syms_of_abbrev): Remove declaration.
4275 Reported by CHENG Gao <chenggao@royau.me>.
4276
c7aa8333
EZ
42772011-11-07 Eli Zaretskii <eliz@gnu.org>
4278
4279 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4280 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4281 of temacs in GUI mode.
4282
be7f5545
MR
42832011-11-07 Martin Rudalics <rudalics@gmx.at>
4284
4285 * window.h: Declare delete_all_child_windows instead of
4286 delete_all_subwindows.
4287 * window.c (Fwindow_nest, Fset_window_nest)
4288 (Fset_window_new_total, Fset_window_new_normal)
4289 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4290 (delete_all_subwindows): Rename to delete_all_child_windows.
4291 (Fdelete_other_windows_internal, Fset_window_configuration):
4292 Call delete_all_child_windows instead of delete_all_subwindows.
4293 * frame.c (delete_frame): Call delete_all_child_windows instead
4294 of delete_all_subwindows.
4295
ca78dc43
PE
42962011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4297
4298 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4299 This is also needed for porting to any host where GC_MARK_STACK is
4300 not GC_MAKE_GCPROS_NOOPS.
4301 (which_symbols): Use it.
4302
a0241d01
KH
43032011-11-07 Kenichi Handa <handa@m17n.org>
4304
4305 * coding.c (coding_set_destination): Check coding->src_pos only
4306 when coding->src_object is a buffer (bug#9910).
4307
4308 * process.c (send_process): Set the member src_multibyte of coding
4309 to 0 (bug#9911) when sending a unibyte text.
4310
4311 * callproc.c (Fcall_process): Set the member src_multibyte of
4312 process_coding to 0 (bug#9912).
4313
a64bfdfa 43142011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
4315
4316 * xmenu.c (cleanup_widget_value_tree): New function.
4317 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4318 calling free_menubar_widget_value_tree directly (Bug#9830).
4319
cb41b32a
PE
43202011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4321
4322 Fix some portability problems with 'inline'.
4323 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4324 (window_box_width, window_box_left, window_box_left_offset)
4325 (window_box_right, window_box_right_offset): Declare extern.
4326 Otherwise, these inline functions do not conform to C99 and
4327 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4328 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4329 * intervals.c (adjust_intervals_for_insertion)
4330 (adjust_intervals_for_deletion): Now extern, because otherwise the
4331 extern inline functions 'offset_intervals' couldn't refer to it.
4332 (static_offset_intervals): Remove.
4333 (offset_intervals): Rewrite using the old contents of
4334 static_offset_intervals. The old version didn't conform to C99
4335 because an extern inline function contained a reference to an
4336 identifier with static linkage.
4337
b7041366
AS
43382011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4339
4340 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4341 GC.
4342
88a37c4d
EZ
43432011-11-06 Eli Zaretskii <eliz@gnu.org>
4344
4345 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4346 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4347 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4348 return Qleft_to_right.
4349
49745b39
CY
43502011-11-06 Chong Yidong <cyd@gnu.org>
4351
4352 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4353 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4354 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4355 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4356 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4357 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4358 (Fwindow_vscroll): Doc fix.
4359 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4360 argument, since it makes no sense to pass a live window and for
4361 consistency with window-child.
4362
1f05cd82
CS
43632011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4364
4365 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4366 support MSVC.
4367
22610910
JR
43682011-11-05 Jason Rumney <jasonr@gnu.org>
4369
4370 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4371 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4372 fonts (Bug#6029).
4373 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4374 bitwise arithmetic preventing use of unicode-sip and non-truetype
4375 opentype fonts.
4376
a06776b2
EZ
43772011-11-05 Eli Zaretskii <eliz@gnu.org>
4378
3ad924ba
EZ
4379 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4380 "emacs"-only part.
4381
a06776b2
EZ
4382 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4383 initialization code to keep similarity to xfns.c after changes
4384 from 2011-11-05.
4385
c9e7db78
JD
43862011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4387
a97f8f3f
JD
4388 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4389 (unwind_create_frame): New function (Bug#9943).
4390 (Fx_create_frame): Restructure code to be more similar to the one in
4391 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4392 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4393 Move terminal->reference_count++ just before making the frame official
4394 (Bug#9943).
4395
4396 * nsterm.m (x_free_frame_resources): New function.
4397 (x_destroy_window): Move code to x_free_frame_resources.
4398
c9e7db78 4399 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4400 (Fx_create_frame, x_create_tip_frame):
4401 Move terminal->reference_count++ just before making the frame
75f1671a 4402 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4403 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4404
a6fc3b5c
EZ
44052011-11-05 Eli Zaretskii <eliz@gnu.org>
4406
4407 Support MSVC build with newer versions of Visual Studio.
4408 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4409 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4410 nt/gmake.defs.
4411
4412 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4413 which are not supported by MSVC.
4414 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4415 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4416 bitfields.
4417 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4418 types in bitfields.
4419 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4420
4421 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4422
58179cce 44232011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
4424
4425 Support MSVC build with newer versions of Visual Studio.
4426 * w32.c: Don't include w32api.h for MSVC.
4427 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4428
4429 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4430 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4431 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4432 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4433 e_* cousins.
4434 (alloca) [_MSC_VER]: Define to _alloca.
4435
4436 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4437
4438 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4439
a58c13ed
EZ
44402011-11-04 Eli Zaretskii <eliz@gnu.org>
4441
4442 * xdisp.c (note_mouse_highlight): If either of
4443 previous/next-single-property-change returns nil, treat that as
4444 the beginning or the end of the buffer. (Bug#9955)
4445
fe0b6370
JD
44462011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4447
a58c13ed 4448 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4449 label is not null (Bug#9951).
4450 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4451 may be NULL.
4452
89bd5ee1
EZ
44532011-11-04 Eli Zaretskii <eliz@gnu.org>
4454
4455 * window.c (Fwindow_body_size): Mention in the doc string that the
4456 return value is in frame's canonical units. (Bug#9949)
4457
84c3edb9
EZ
44582011-11-03 Eli Zaretskii <eliz@gnu.org>
4459
4e2fb5c7
EZ
4460 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4461
84c3edb9 4462 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4463 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4464 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4465
bc17a887
EZ
44662011-11-01 Eli Zaretskii <eliz@gnu.org>
4467
4468 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4469 Don't stop backward scan on the continuation glyph, even though
4470 its CHARPOS is positive.
6d5eb5b0
SM
4471 (mouse_face_from_buffer_pos, note_mouse_highlight):
4472 Rename cover_string to disp_string.
bc17a887 4473
4ee88440
MR
44742011-11-01 Martin Rudalics <rudalics@gmx.at>
4475
4476 * window.c (temp_output_buffer_show): Don't use
4477 Vtemp_buffer_show_specifiers.
4478 (Vtemp_buffer_show_specifiers): Remove unused variable.
4479
c2ff3c02
EZ
44802011-10-30 Eli Zaretskii <eliz@gnu.org>
4481
4482 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4483 past the beginning of the current glyph matrix.
4484
58179cce 44852011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4486
4487 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4488 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4489 HAVE_GTK3 (Bug#9869).
b77a6a7f 4490
3b574623
JD
4491 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4492 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4493
b77a6a7f
JD
4494 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4495
4496 * xterm.c: Declare x_handle_net_wm_state to return int.
4497 (handle_one_xevent): Check if we are iconified but don't have
4498 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4499 (get_current_wm_state): Return non-zero if not hidden,
4500 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4501 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4502 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4503 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4504
196e41e4
PE
45052011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4506
4507 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4508 so that this new function doesn't get optimized away by a
4509 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4510
021f2e1a
AS
45112011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4512
4513 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4514
8b058d44
EZ
45152011-10-29 Eli Zaretskii <eliz@gnu.org>
4516
4517 Fix the `xbytecode' command.
4518 * .gdbinit (xprintbytestr): New command.
b50a28de 4519 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4520 (xbytecode): Print the byte-code string as well.
4521
4452fb80
EZ
45222011-10-29 Kim Storm <storm@cua.dk>
4523
8b058d44
EZ
4524 * alloc.c (which_symbols): New function.
4525
21b72067
AS
45262011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4527
4528 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4529 line. (Bug#9903)
4530
83ed7b5c
GM
45312011-10-29 Glenn Morris <rgm@gnu.org>
4532
4533 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4534 Not clear what it was for, and it causes various bugs. (Bug#9839)
4535
5a7a728b
EZ
45362011-10-28 Eli Zaretskii <eliz@gnu.org>
4537
4538 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4539 possible random value that matches one of those tested as
4540 condition to clear the mouse face.
4541
d3d0842f
CY
45422011-10-28 Chong Yidong <cyd@gnu.org>
4543
4544 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4545
31b39d13
DN
45462011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4547
4548 * window.c (make_window): Initialize phys_cursor_on_p.
4549
9aba6043
SM
45502011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4551
4552 * lisp.h (struct Lisp_Symbol): Update comments.
4553
c20992f4
JB
45542011-10-28 Juanma Barranquero <lekktu@gmail.com>
4555
4556 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4557
db4f02f2
EZ
45582011-10-28 Eli Zaretskii <eliz@gnu.org>
4559
4560 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4561 <oslsachem@gmail.com> for helping to debug this.
4562
4563 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4564 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4565 (g_b_init_get_glyph_outline_w): New static variables.
4566 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4567 (GetGlyphOutlineW_Proc): New typedefs.
4568 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4569 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4570 New functions.
4571 (w32font_open_internal, compute_metrics):
4572 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4573 instead of calling the "wide" APIs directly.
4574
4575 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4576
4577 * w32.h (syms_of_w32font): Add prototype.
4578
87e68db4
JB
45792011-10-27 Juanma Barranquero <lekktu@gmail.com>
4580
4581 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4582 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4583 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4584 (Fmove_to_window_line): Doc fix.
4585
435c1d67
CY
45862011-10-27 Chong Yidong <cyd@gnu.org>
4587
4588 * process.c (make_process): Set gnutls_state to NULL.
4589
4590 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4591 non-NULL, regardless of GNUTLS_INITSTAGE.
4592 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4593 an error. Set process slots as soon as we allocate them.
4594
4595 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4596
9c6c6f49
CY
45972011-10-27 Chong Yidong <cyd@gnu.org>
4598
9aba6043
SM
4599 * gnutls.c (emacs_gnutls_deinit): New function.
4600 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
4601 (Fgnutls_deinit, Fgnutls_boot): Use it.
4602
4603 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4604 (deactivate_process): Call emacs_gnutls_deinit.
4605
657d08d3
JB
46062011-10-27 Juanma Barranquero <lekktu@gmail.com>
4607
4608 * image.c (x_create_x_image_and_pixmap):
4609 * w32.c (sys_rename, w32_delayed_load):
4610 * w32font.c (fill_in_logfont):
4611 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4612
5430d399
JB
46132011-10-26 Juanma Barranquero <lekktu@gmail.com>
4614
4615 * w32fns.c (w32_default_color_map): New function,
4616 extracted from Fw32_default_color_map.
a7ef684b 4617 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 4618
fe0055fa
PE
46192011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4620
4621 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4622
e6346438
SM
46232011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4624
4625 * keyboard.c (test_undefined): New function (bug#9751).
4626 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4627
e112cc37
ET
46282011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4629
4630 * sysdep.c (init_sys_modes): Fix the check for the controlling
4631 terminal (Bug#6649).
4632
7b5d6677
EZ
46332011-10-20 Eli Zaretskii <eliz@gnu.org>
4634
4635 * dispextern.h (struct bidi_it): New member next_en_type.
4636
4637 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4638 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4639 current character, check also for next_en_type being WEAK_EN.
4640 (bidi_resolve_weak): Don't enter the expensive loop if the current
4641 position is before next_en_pos. Record the bidi type of the first
4642 non-ET, non-BN character we find, in addition to its position.
4643 (bidi_level_of_next_char): Invalidate next_en_type when
4644 next_en_pos is over-stepped.
4645
7da0b018
PE
46462011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4647
4648 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4649 * editfns.c: Rewrite current-time-zone so that it invokes
4650 the equivalent of (format-time-string "%Z") to get the time zone name.
4651 This fixes a bug when the time zone name contains characters that
4652 need converting from the system time locale to Emacs internal format.
4653 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4654 that patch fixed format-time-string to do the conversion, but
4655 I forgot to fix current-time-zone.
4656 (format_time_string): New function, containing most of
4657 what Fformat_time_string used to contain.
4658 (Fformat_time_string): Rewrite in terms of format_time_string.
4659 This doesn't change this function's behavior.
4660 (current-time-zone): Rewrite to use format_time_string.
4661 This fixes the bug reported by Michael Schierl in
4662 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4663 Jason Rumney's 2007-06-07 change worked around this bug, but
4664 didn't fix it.
4665 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4666
8547b010
EZ
46672011-10-19 Eli Zaretskii <eliz@gnu.org>
4668
4669 * xdisp.c (start_display): If the character at POS is displayed
4670 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4671 (try_window_reusing_current_matrix): If a line ends in a display
4672 vector or the next line starts in a display vector, continue
4673 redrawing the window even though the character position of
4674 start_row was reached.
8547b010
EZ
4675 (Bug#9771, part 2)
4676
4e948d15
CY
46772011-10-18 Chong Yidong <cyd@gnu.org>
4678
4679 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4680 with nobreak-char-display too.
4681
4787455f
EZ
46822011-10-18 Eli Zaretskii <eliz@gnu.org>
4683
4684 Fix part 3 of bug#9771.
4685 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4686 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4687 non-neutral characters if the current character is a paragraph
4688 separator (a.k.a. Newline). This avoids running the same
4689 expensive loop twice, once when we consume the preceding newline
4690 and the other time when the line actually needs to be displayed.
4691 Avoid the loop when we see neutrals on the base embedding level
4692 following a character whose directionality is the same as the
4693 paragraph's. This avoids running the expensive loop when a line
4694 ends in a long sequence of neutrals, like control characters.
4695 Add assertion against STRONG_AL type. Slightly rearrange code
4696 that determines the type of a neutral given the first non-neutral
4697 that follows it.
4698 (bidi_level_of_next_char): Set next_en_pos to zero when
4699 invalidating its info.
4700
2c91f553
EZ
47012011-10-17 Eli Zaretskii <eliz@gnu.org>
4702
4703 * xdisp.c (push_display_prop): Determine whether to record string
4704 or buffer position by IT->string, not by IT->method. Allow
4705 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4706 (move_it_vertically_backward): Don't look for character position
4707 immediately after the newline when in a continuation line.
4708 (Bug#9771, part 1)
2c91f553 4709
c7b08b0d
MR
47102011-10-15 Martin Rudalics <rudalics@gmx.at>
4711
4712 * window.c (coordinates_in_window): Rewrite and delabelize
4713 vertical border check. (Bug#5357) (Bug#9618)
4714
6b02f655
SM
47152011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4716
4717 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4718 errors in XSetWindowBorder (bug#9310).
4719
81d40c92
DA
47202011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4721
4722 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4723 avoid crash when xmalloc overrun checking is enabled.
4724
d4172c3b
EZ
47252011-10-13 Eli Zaretskii <eliz@gnu.org>
4726
4727 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4728 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4729 cursor motion with <left> and <right> arrow keys.
4730
4731 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4732 some callers set that themselves.
4733
b00eea75
EZ
47342011-10-12 Eli Zaretskii <eliz@gnu.org>
4735
4736 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4737 display string and the previous row comes from the same string and
4738 is empty. (Bug#9739) (Bug#9738)
4739
8fe012c4
SM
47402011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4741
4742 * doc.c (get_doc_string): Encode file name (bug#9735).
4743
0074aef2
EZ
47442011-10-12 Eli Zaretskii <eliz@gnu.org>
4745
79beb178
EZ
4746 * bidi.c (bidi_level_of_next_char):
4747 * xdisp.c (get_visually_first_element): Remove old incorrect
4748 comments regarding the Unicode Line Separator character.
4749
0074aef2
EZ
4750 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4751
6e4b3fbe
DA
47522011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4753
4754 * alloc.c (Fgc_status): Do not access beyond zombies array
4755 boundary if nzombies > MAX_ZOMBIES.
4756 * alloc.c (dump_zombies): Add missing format specifier.
4757
0324f3af
PE
47582011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4759
b5525cac
PE
4760 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4761 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4762
0324f3af
PE
4763 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4764 Some packages use them to denote characters with modifiers.
4765
e9b5f888
AS
47662011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4767
4768 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4769 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4770 matching a pp-number. Rename parameter var to var1.
4771
127827c0
SM
47722011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4773
4774 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4775
c8fd3bd0
GM
47762011-10-08 Glenn Morris <rgm@gnu.org>
4777
4778 * callint.c (Fcall_interactively): Give a more explicit error for the
4779 'c' case with a non-character input. (Bug#8479)
4780
352ec8ff
EZ
47812011-10-08 Eli Zaretskii <eliz@gnu.org>
4782
03669ccb
EZ
4783 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4784 lines.
7061c986
EZ
4785 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4786 lines that are hscrolled on the left.
03669ccb 4787
352ec8ff
EZ
4788 * dispnew.c (buffer_posn_from_coords): Account for a possible
4789 presence of header-line. (Bug#4426)
4790
a66cfb1c
SM
47912011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4792
6b02f655
SM
4793 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4794 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4795
7c5ee88e
PE
47962011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4797
4798 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4799 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4800 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4801 this makes Emacs dump core during garbage collection on rare
4802 occasions. sizeof is obviously inferior to offsetof here, so
4803 stick with offsetof.
4804 (GC_POINTER_ALIGNMENT): New macro.
4805 (mark_memory): Omit 3rd (offset) arg; caller changed.
4806 Don't assume EMACS_INT alignment is the same as pointer alignment.
4807
df1bbe5b
SM
48082011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4809
4810 * keyboard.c (read_key_sequence_remapped): New var.
4811 (read_key_sequence): Compute remapping in the right buffer.
4812 (command_loop_1): Use read_key_sequence's remapping directly.
4813
51553db6
SM
48142011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4815
32c1fffd
SM
4816 * dired.c (file_name_completion): Don't expand file name.
4817 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4818 before checking file name handler.
4819
51553db6
SM
4820 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4821 they've been requested explicitly (bug#9591).
4822
b6bd1599 48232011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4824
4825 * keymap.c (Fsingle_key_description): Use make_specified_string
4826 instead of build_string to build string from push_key_description.
4827 (Bug#5193)
4828
f701dc2a
PE
48292011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4830
4222c55d
PE
4831 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4832 This fixes a Y2038 bug on 64-bit hosts.
4833 * buffer.c (reset_buffer):
4834 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4835 (Fclear_buffer_auto_save_failure):
4836 Use 0, not -1, to represent an unset failure time, since time_t
4837 might not be signed.
4838
f701dc2a
PE
4839 Remove dependency on glibc malloc internals.
4840 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4841 Move back here from lisp.h, but with their new implementations.
4842 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4843 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4844 * charset.c (charset_table_init): New static var.
4845 (syms_of_charset): Use it instead of xmalloc. This removes a
4846 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4847 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4848 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4849 Move back to alloc.c.
4850 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4851 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4852
9ceebf39
JD
48532011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4854
4855 * nsterm.m (windowDidResize): Call x_set_window_size only when
4856 ns_in_resize is true. Otherwise set pixelwidth/height and
4857 call change_frame_size (Bug#9628).
4858
cb993c58
PE
48592011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4860
3930c88b
PE
4861 Port --enable-checking=all to Fedora 14 x86-64.
4862 * charset.c (syms_of_charset): Also account for glibc malloc's
4863 internal overhead when calculating the initial malloc maximum.
4864
cb993c58
PE
4865 Port --enable-checking=all to Fedora 14 x86.
4866 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4867 Move to lisp.h.
4868 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4869 (overrun_check_realloc, overrun_check_free):
4870 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4871 That way, xmalloc returns a properly-aligned pointer even if
4872 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4873 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4874 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4875 into account when calculating the initial malloc maximum.
4876 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4877 Move here from alloc.c, so that charset.c can use it too.
4878 Properly align; the old code wasn't right for common 32-bit hosts
4879 when configured with --enable-checking=all.
4880 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4881 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4882
31bed486
EZ
48832011-09-29 Eli Zaretskii <eliz@gnu.org>
4884
04c70788 4885 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4886 use EDOM.
4887
fbcaa2f3
EZ
48882011-09-28 Eli Zaretskii <eliz@gnu.org>
4889
4890 * xdisp.c (compute_display_string_end): If there's no display
4891 string at CHARPOS, return -1.
4892
4893 * bidi.c (bidi_fetch_char): When compute_display_string_end
4894 returns a negative value, treat the character as a normal
4895 character not covered by a display string. (Bug#9624)
4896
a239d4e9
JB
48972011-09-28 Juanma Barranquero <lekktu@gmail.com>
4898
4899 * lread.c (Fread_from_string): Fix typo in docstring.
4900
88652fd5
EZ
49012011-09-27 Eli Zaretskii <eliz@gnu.org>
4902
4903 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4904 newline, reseat the iterator instead of bidi-iterating there one
4905 character at a time. (Bug#9610)
32c1fffd
SM
4906 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4907 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 4908
ed497dd4
AS
49092011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4910
4911 * lread.c (readevalloop): Use correct code for NBSP.
4912 (read1): Likewise. (Bug#9608)
4913
b2bf61aa
MA
49142011-09-25 Michael Albinus <michael.albinus@gmx.de>
4915
4916 * dbusbind.c (Fdbus_register_signal): When service is not
4917 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4918
32bbb17c
GM
49192011-09-25 Glenn Morris <rgm@gnu.org>
4920
4921 * buffer.c (truncate-lines): Doc fix.
4922
94e0933e
CY
49232011-09-24 Chong Yidong <cyd@stupidchicken.com>
4924
4925 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4926 (Fset_window_next_buffers): Doc fix.
4927
cddde921
GM
49282011-09-24 Glenn Morris <rgm@gnu.org>
4929
4930 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4931
1260aef1
PE
49322011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4933
25b4bfa0
PE
4934 Fix minor problems found by static checking.
4935 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
4936 * indent.c (Fvertical_motion): Fix == vs = typo.
4937
e3cbd34b
EZ
49382011-09-24 Eli Zaretskii <eliz@gnu.org>
4939
a66cfb1c
SM
4940 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4941 Default value is now t. Doc fix.
6bf7006f 4942
e3cbd34b 4943 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 4944 logic when moving up, not only when moving down. Fix the
e3cbd34b 4945 confusing name and values of the it_overshoot_expected variable;
32c1fffd 4946 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
4947
4948 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4949 CHARPOS is covered by a display string which includes newlines.
4950 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4951 is covered by a display string with embedded newlines.
4952
a3de0cbd
MA
49532011-09-24 Michael Albinus <michael.albinus@gmx.de>
4954
4955 * dbusbind.c (Fdbus_register_signal): Add match rule to
4956 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4957 (Fdbus_register_method, Vdbus_registered_objects_table):
4958 Fix docstring.
a3de0cbd 4959
b260039d
JM
49602011-09-24 Jim Meyering <meyering@redhat.com>
4961
32c1fffd 4962 do not ignore write error for any output size
b260039d
JM
4963 The previous change was incomplete.
4964 While it makes emacs --batch detect the vast majority of stdout
4965 write failures, errors were still ignored whenever the output size is
4966 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4967 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4968 && echo FAIL: ignored write error
4969 FAIL: ignored write error
4970 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4971 && echo FAIL: ignored write error
4972 FAIL: ignored write error
4973 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4974
8eca8a7c
AS
49752011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4976
4977 * emacs.c (Fkill_emacs): In noninteractive mode exit
4978 non-successfully if a write error occurred on stdout. (Bug#9574)
4979
3341db62
EZ
49802011-09-21 Eli Zaretskii <eliz@gnu.org>
4981
4982 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4983 the xassert test.
4984
4985 * dispextern.h (struct it): Update the comment documenting what
4986 can it->OBJECT be.
4987
8c203dbf
EZ
49882011-09-20 Eli Zaretskii <eliz@gnu.org>
4989
4990 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4991 a display string, extend search for cursor position to end of row.
4992 (find_row_edges): If the row ends in a newline from a display
4993 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4994 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4995 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4996 non-empty line. Fixes confusing cursor motion with arrow keys at
4997 the beginning of a line that starts with whitespace.
8c203dbf 4998
a4824228
LMI
49992011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5000
5001 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5002 (bug#9493).
5003
33ed493b
CY
50042011-09-18 Chong Yidong <cyd@stupidchicken.com>
5005
5006 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5007 boolean (Bug#9154).
5008
56cd55c8
EZ
50092011-09-18 Eli Zaretskii <eliz@gnu.org>
5010
5011 * xdisp.c (display_line): Record maximum and minimum buffer
5012 positions even if no glyphs were produced (e.g., by a zero-width
5013 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5014 buffer positions that will be removed from the glyph row because
5015 they don't fit.
c02dcedf
EZ
5016 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5017 column is beyond frame width: don't subtract 1 "pixel" when
5018 computing width of the stretch.
3e62b7e0
EZ
5019 (reseat_at_next_visible_line_start): Undo the change made on
5020 2011-09-17 that saved paragraph information and restored it after
5021 the call to `reseat'. (Bug#9545)
56cd55c8 5022
5ed99d36 50232011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5024
5025 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5026 and turn window cursor on if cleared (Bug#9415).
5027
5ed99d36 50282011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5029
5030 * search.c (boyer_moore): Take unibyte characters from pattern
5031 literally. (Bug#9458)
5032
9bade7b2
EZ
50332011-09-18 Eli Zaretskii <eliz@gnu.org>
5034
5035 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5036
e5e9d610
PE
50372011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5038
87e4427a
PE
5039 Fix minor problem found by static checking.
5040 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5041 initialized, to pacify gcc -Wuninitialized.
5042
e5e9d610
PE
5043 * fileio.c: Report proper errno when syscall falls.
5044 (Finsert_file_contents): Save and restore errno,
5045 so that report_file_error outputs the correct diagnostic.
5046 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5047
a1674f0b
EZ
50482011-09-18 Eli Zaretskii <eliz@gnu.org>
5049
5050 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5051
fbfb6dd4
EZ
50522011-09-17 Eli Zaretskii <eliz@gnu.org>
5053
5054 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5055 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5056
bb187662
EZ
50572011-09-17 Eli Zaretskii <eliz@gnu.org>
5058
1137e8b8 5059 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5060 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5061
5062 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5063 (bidi_find_paragraph_start): Search back for paragraph beginning
5064 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5065 (bidi_move_to_visually_next): Only trigger paragraph-related
5066 computations when the last character is a newline or at EOB, not
5067 just any NEUTRAL_B. (Bug#9470)
5068
bb187662
EZ
5069 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5070 truncated lines if point is covered by a display string. (Bug#9524)
5071
2e621251
PE
50722011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5073
5074 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5075 (cons_to_x_long): New function.
5076 (lisp_data_to_selection_data): Use it. Correct the test for
5077 short-versus-long data; it was negated. Break out of vector
5078 loop, for efficiency, when a long datum is discovered.
5079
91a15bc6
SM
50802011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5081
5082 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5083
b41c3a35
EZ
50842011-09-16 Eli Zaretskii <eliz@gnu.org>
5085
5086 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5087 GCC PR/17406) by declaring this function with external scope.
5088
7812ba2d
PE
50892011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5090
5091 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5092 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5093
cf7edc2a
AS
50942011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5095
5096 * editfns.c (Fformat): Correctly handle text properties on "%%".
5097
bd01620e
EZ
50982011-09-15 Eli Zaretskii <eliz@gnu.org>
5099
5100 * xterm.c (x_draw_composite_glyph_string_foreground):
5101 * w32term.c (x_draw_composite_glyph_string_foreground):
5102 * term.c (encode_terminal_code):
5103 * composite.c (composition_update_it, get_composition_id):
5104 * xdisp.c (get_next_display_element)
5105 (fill_composite_glyph_string): Add comments about special meaning
5106 of TAB characters in a composition.
5107
a02719a3
PE
51082011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5109
5110 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5111 This occurs when processing a multibyte format.
5112 Problem reported by Wolfgang Jenker.
a02719a3 5113
72589a3c
JB
51142011-09-15 Johan Bockgård <bojohan@gnu.org>
5115
5116 * xdisp.c (try_cursor_movement): Only check for exact match if
5117 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5118
1c14176c
PE
51192011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5120
5121 Remove unused external symbols.
5122 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5123 * xdisp.c (calc_pixel_width_or_height): Now static.
5124 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5125 * indent.c (check_display_width):
5126 * w32term.c: Fix comment to match code.
5127 * xterm.c, xterm.h (x_catching_errors): Remove.
5128
d2eea5b5
PE
51292011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5130
5131 * xselect.c: Use signed conversions more consistently (Bug#9498).
5132 (selection_data_to_lisp_data): Assume incoming selection data are
5133 signed integers, not unsigned. This is to be consistent with
5134 outgoing selection data, which was modified to use signed integers
5135 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5136 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5137 expects long, not unsigned long.
5138
46888499
EZ
51392011-09-14 Eli Zaretskii <eliz@gnu.org>
5140
5141 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5142 computation of loop end. Reported by Johan Bockgård
5143 <bojohan@gnu.org>.
5144
ef8ef9fb
CY
51452011-09-13 Chong Yidong <cyd@stupidchicken.com>
5146
5147 * frame.c (Fother_visible_frames_p): Function deleted.
5148
fa819fed
EZ
51492011-09-12 Eli Zaretskii <eliz@gnu.org>
5150
5151 * indent.c (compute_motion): Process display vector front to back
5152 rather than the other way around. (Bug#2496)
5153
2ba8e008
SM
51542011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5155
5156 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5157
20f53c69
CY
51582011-09-11 Chong Yidong <cyd@stupidchicken.com>
5159
5160 * minibuf.c (Fread_from_minibuffer): Doc fix.
5161
d562d7a4
EZ
51622011-09-11 Eli Zaretskii <eliz@gnu.org>
5163
5164 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5165 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5166
1c4d7f3d
LMI
51672011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5168
5169 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5170 value for non-existent files.
5171
b885bf36
EZ
51722011-09-11 Eli Zaretskii <eliz@gnu.org>
5173
5174 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5175 set its "size" to -1. This will set the modtime_size field of
5176 the corresponding buffer to -1, which is what
5177 verify-visited-file-modtime expects for files that do not exist.
5178 (Bug#9139)
5179
6612f0bf
PE
51802011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5181
5182 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5183 here ...
5184 * lisp.h: ... from here. push_key_description is no longer
5185 defined in keyboard.c, so its declaration should not be in
5186 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5187 logically belongs with push_key_description.
5188
dfb3f755
PE
51892011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5190
5191 * buffer.h: Include <sys/types.h> instead of <time.h>.
5192 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5193 Problem reported by Herbert J. Skuhra.
5194
3134906c
LMI
51952011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5196
5197 * xml.c (parse_region): Make the parsing work for
5198 non-comment-starting XML files again (bug#9144).
5199
8d903f4e
AS
52002011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5201
5202 * image.c (gif_load): Fix calculation of bottom and right corner.
5203 (Bug#9468)
5204
80ad64f4
EZ
52052011-09-10 Eli Zaretskii <eliz@gnu.org>
5206
5207 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5208 redisplay in small windows.
5209
208a048d
EZ
52102011-09-09 Eli Zaretskii <eliz@gnu.org>
5211
5212 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5213
9b1c252e
MR
52142011-09-08 Martin Rudalics <rudalics@gmx.at>
5215
5216 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5217 Operate on live windows only.
5218
2949f33b
JB
52192011-09-08 Juanma Barranquero <lekktu@gmail.com>
5220
5221 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5222
e08dcafd
EZ
52232011-09-07 Eli Zaretskii <eliz@gnu.org>
5224
5225 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5226 only under bidi iteration.
5227
115b96bd
JD
52282011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5229
5230 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5231
c8199d0f
PE
52322011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5233
5234 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5235 Without this fix, the command to link temacs failed due to an
5236 undefined symbol __builtin_isnan. This is because
5237 /usr/include/iso/math_c99.h #defines isnan(x) to
5238 __builtin_isnan(x), but the bundled gcc, which identifies itself
5239 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5240 a __builtin_isnan.
5241 * floatfns.c (isnan): #undef, and then #define to a clone of
5242 what's in data.c.
5243 (Fisnan): Always define, since it's always available now.
5244 (syms_of_floatfns): Always define isnan at the Lisp level.
5245
e39b275c 52462011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
5247
5248 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5249
b2db44d9 52502011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 5251
f4af5137 5252 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
5253 The previous code assumed that file offsets (off_t values) fit in
5254 EMACS_INT variables, which is not true on typical 32-bit hosts.
5255 The code messed up by falsely reporting buffer overflow in cases
5256 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5257 when "big" contains more than 2**29 bytes, even though this
5258 inserts just one byte and does not overflow the buffer.
5259 (Finsert_file_contents): Store file offsets as off_t
5260 values, not as EMACS_INT values. Check for overflow when
5261 converting between EMACS_INT and off_t. When checking for
5262 buffer overflow or for overlap, take the offsets into account.
5263 Don't use EMACS_INT for small values where int suffices.
5264 When checking for overlap, fix a typo: ZV was used where
5265 ZV_BYTE was intended.
5266 (Fwrite_region): Don't assume off_t fits into 'long'.
5267 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5268
ecfc0a49
MA
52692011-09-05 Michael Albinus <michael.albinus@gmx.de>
5270
5271 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5272
6511acf2 52732011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 5274
0999621a 5275 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
5276
5277 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 5278 (esprintf, exprintf, evxprintf): New functions.
62f19c19 5279 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 5280 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
5281 (modify_event_symbol): Do not assume that the length of
5282 name_alist_or_stem is safe to alloca and fits in int.
5283 (Fexecute_extended_command): Likewise for function name and binding.
5284 (Frecursion_depth): Wrap around reliably on integer overflow.
5285 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5286 since some callers pass EMACS_INT values.
5287 (Fsingle_key_description): Don't crash if symbol name contains more
5288 than MAX_ALLOCA bytes.
5289 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5290 (get_minibuffer): Arg is now EMACS_INT, not int.
5291 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 5292 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
5293 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5294
2be7d702
PE
5295 * dbusbind.c (signature_cat): New function.
5296 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
5297 Do not overrun buffer; instead, report string overflow.
5298
9d1df220
PE
5299 * dispnew.c (add_window_display_history): Don't overrun buffer.
5300 Truncate instead; this is OK since it's just a log.
5301
33ef5c64
PE
5302 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5303 even if the time zone offset is outlandishly large.
5304 Don't mishandle offset == INT_MIN.
5305
66c6fdd5
PE
5306 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5307 when creating daemon; the previous buffer-overflow check was incorrect.
5308
d749b01b
PE
5309 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5310 which has the guts of the old verror function.
5311
b5cd1905
PE
5312 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5313 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5314
6e1a67fb
PE
5315 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5316 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 5317 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 5318 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
5319 length of string rather than counting it via multiple sprintfs;
5320 that's simpler and more reliable.
c21721cc
PE
5321 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5322 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5323 sprintf, in case result does not fit in int.
5324
c57b67fc
PE
5325 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5326 (fontset_from_font): Print it.
5327
8a401434
PE
5328 * frame.c (tty_frame_count): Now printmax_t, not int.
5329 (make_terminal_frame, set_term_frame_name): Print it.
5330 (x_report_frame_params): In X, window IDs are unsigned long,
5331 not signed long, so print them as unsigned.
5332 (validate_x_resource_name): Check for implausibly long names,
5333 and don't assume name length fits in 'int'.
5334 (x_get_resource_string): Don't blindly alloca invocation name;
5335 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5336 not fit in int.
5337
6e1a67fb
PE
5338 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5339 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5340 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5341
0df02bf3
PE
5342 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5343 Use esprintf, not sprintf, in case result does not fit in int.
5344
48e30793
PE
5345 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5346 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5347 it as a large positive number.
5348 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5349 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5350
a66ff6d8
PE
5351 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5352 in case result does not fit in int.
5353
aca216ff
PE
5354 * print.c (float_to_string): Detect width overflow more reliably.
5355 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5356 buffer overrun. Don't assume list length fits in 'int'. Treat
5357 print length of 0 as 0, not as infinity; to be consistent with other
5358 uses of print length in this function. Don't overflow print length
5359 index. Don't assume hash table size fits in 'long', or that
5360 vectorlike size fits in 'unsigned long'.
5361
31c286f7
PE
5362 * process.c (make_process): Use printmax_t, not int, to format
5363 process-name gensyms.
5364
55e5faa1
PE
5365 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5366
80f2e268
PE
5367 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5368 to avoid potential buffer overrun.
5369
670741ab
PE
5370 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5371 if X resource line is longer than 512 bytes.
5372
b7163a50
PE
5373 * xfns.c (x_window): Make sprintf buffer a bit bigger
5374 to avoid potential buffer overrun.
5375
ae58ff1f
PE
5376 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5377
c43c8a6a
PE
5378 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5379
3f8236f4
PE
53802011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5381
53e9fe90 5382 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5383 Without these, Emacs silently mishandles large integers sometimes.
5384 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5385 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5386
6511acf2
PE
5387 * xdisp.c (try_window_id): Check Emacs fixnum range before
5388 converting to 'int'.
806add1d 5389
6511acf2 5390 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5391 Check that an Emacs fixnum is in range before assigning it to 'int'.
5392 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5393 values converted from Emacs fixnums.
5394 (Frecenter): Don't wrap around a line count if it is out of 'int'
5395 range; instead, treat it as an extreme value.
5396 (Fset_window_configuration, compare_window_configurations):
5397 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5398
6511acf2
PE
5399 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5400 that can exceed INT_MAX. Check that EMACS_INT value is in range
5401 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5402 (match_limit): Don't assume that a fixnum can fit in 'int'.
5403
6511acf2 5404 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5405 exceed INT_MAX.
5406
6511acf2 5407 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
5408 (Fvertical_motion): Don't wrap around LINES values that don't fit
5409 in 'int'. Instead, treat them as extreme values. This is good
5410 enough for windows, which can't have more than INT_MAX lines anyway.
5411
fcb901a7
LMI
54122011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5413
0f2f6b6d
LMI
5414 * Require libxml/parser.h to avoid compilation warning.
5415
fcb901a7
LMI
5416 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5417
5418 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5419 since this reportedly can destroy thread storage.
5420
6e20a0d4
CY
54212011-08-30 Chong Yidong <cyd@stupidchicken.com>
5422
5423 * syntax.c (find_defun_start): Update all cache variables if
5424 exiting early (Bug#9401).
5425
148ae00e
EZ
54262011-08-30 Eli Zaretskii <eliz@gnu.org>
5427
f6cfbd8f
EZ
5428 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5429
148ae00e
EZ
5430 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5431 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5432 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5433
5434 * term.c (tty_append_glyph): New function.
5435 (produce_stretch_glyph): Static function and its prototype deleted.
5436
a66cfb1c
SM
5437 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5438 Add prototypes.
148ae00e 5439
c4a07a4c
PE
54402011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5441
5442 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5443 when checking :margin (Bug#9390).
5444 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5445 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5446 so that the name doesn't mislead. All uses changed.
5447
6bc8cd65
JB
54482011-08-28 Johan Bockgård <bojohan@gnu.org>
5449
5450 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5451 set_tty_hooks.
5452
dca4927e
EZ
54532011-08-27 Eli Zaretskii <eliz@gnu.org>
5454
5455 * xdisp.c (move_it_to): Don't bail out early when reaching
5456 position beyond to_charpos, if we are scanning backwards.
5457 (move_it_vertically_backward): When DY == 0, make sure we get to
5458 the first character in the line after the newline.
5459
f2cad773
PE
54602011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5461
5462 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5463 (ccl_driver): Do not generate an out-of-range pointer.
5464 (Fccl_execute_on_string): Remove unnecessary check for
5465 integer overflow, noted by Stefan Monnier in
5466 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5467 Remove a FIXME that didn't need fixing.
5468 Simplify the newly-introduced buffer reallocation code.
5469
0cae2cdb
JB
54702011-08-27 Juanma Barranquero <lekktu@gmail.com>
5471
5472 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5473
5fc295a4 54742011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5475
70c60eb2 5476 Integer and memory overflow issues (Bug#9196).
726e0ab1 5477
d31850da
PE
5478 * doc.c (get_doc_string): Rework so that
5479 get_doc_string_buffer_size is the actual buffer size, rather than
5480 being 1 less than the actual buffer size; this makes xpalloc more
5481 convenient.
5482
a69fbedb
PE
5483 * image.c (x_allocate_bitmap_record, cache_image):
5484 * xselect.c (Fx_register_dnd_atom):
5485 Simplify previous changes by using xpalloc.
5486
fe5c5d37
PE
5487 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5488 since either will do and ptrdiff_t is convenient with xpalloc.
5489
0065d054
PE
5490 * charset.c (charset_table_size)
5491 (struct charset_sort_data.priority): Now ptrdiff_t.
5492 (charset_compare): Don't overflow if priorities differ greatly.
5493 (Fsort_charsets): Don't assume list length fits in int.
5494 Check for size-calculation overflow when allocating sort data.
5495 (syms_of_charset): Allocate an initial charset table that is
5496 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5497
5498 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5499
5500 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5501 The actual value is always <= INT_MAX, and leaving it unsigned made
5502 overflow checking harder.
5503
5504 * dispextern.h (struct glyph_matrix.rows_allocated)
5505 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5506 with xpalloc. The values are still always <= INT_MAX.
5507
5508 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5509
5510 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5511 (SAFE_NALLOCA): New macro.
5512
5513 * region-cache.c (struct boundary.pos, find_cache_boundary)
5514 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5515 (set_cache_region, invalidate_region_cache)
5516 (revalidate_region_cache, know_region_cache, region_cache_forward)
5517 (region_cache_backward, pp_cache):
5518 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5519 so that ptrdiff_t * can be passed to xpalloc.
5520 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5521 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5522 (pp_cache): Don't assume cache_len fits in int.
5523 * region-cache.h: Adjust extern decls to match.
5524
5525 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5526 EMACS_INT, since either will do, for xpalloc.
5527
5528 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5529 (xnmalloc, xnrealloc, xpalloc): New functions.
5530
726e0ab1
PE
5531 * bidi.c (bidi_shelve_header_size): New constant.
5532 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5533 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5534
51f30bc5 5535 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5536 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5537 (overlay_strings):
5538 Don't update size of array until after memory allocation succeeds,
5539 because xmalloc/xrealloc may not return.
0065d054
PE
5540 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5541 now that we have proper integer overflow checking.
5542 (record_overlay_string, overlay_strings): Catch overflows when
5543 calculating size of overlay_str_buf.
726e0ab1 5544
0065d054
PE
5545 * callproc.c (Fcall_process): Check for size overflow when
5546 calculating size of args2.
5547 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5548 Normally we prefer signed values, but sticking with ptrdiff_t would
5549 require adding more-complicated checks.
726e0ab1
PE
5550
5551 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5552 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5553 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5554 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5555
5556 * character.c (Fstring): Check for size-calculation overflow.
5557
5558 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5559 unnecessary integer overflow. Check for size overflow.
5560 (encode_coding_object): Don't update size until xmalloc succeeds.
5561
5562 * composite.c (get_composition_id): Check for overflow in glyph
5563 length calculations.
5564
5565 Integer and memory overflow fixes for display code.
5566 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5567 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5568 (scrolling_window): Check for overflow in size calculations.
5569 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5570 Don't assume glyph table len fits in int.
5571 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5572 (row_table_size): Now ptrdiff_t, not int.
5573 (scrolling_window): Avoid overflow in size calculations.
5574 Don't update size until allocation succeeds.
5575 * fns.c (concat): Check for overflow in size calculations.
5576 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5577 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5578 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5579
5580 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5581 (get_doc_string): Check for size calculation overflow.
5582 Don't update size until allocation succeeds.
5583 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5584 EMACS_INT, where ptrdiff_t will do.
5585 (Fsubstitute_command_keys): Check for string overflow.
5586
5587 * editfns.c (set_time_zone_rule): Don't assume environment length
5588 fits in int.
5589 (message_length): Now ptrdiff_t, not int.
5590 (Fmessage_box): Don't update size until allocation succeeds.
5591 Don't assume message length fits in int.
5592 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5593
0065d054
PE
5594 * emacs.c (main): Do not reallocate argv, since there is a null at
5595 the end that can be overwritten, and this way there's no need to
5596 worry about size-calculation overflow.
5597 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
5598
5599 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5600 alloc succeeds.
5601 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5602
5603 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5604 (x_set_scroll_bar_width, x_figure_window_size):
5605 Check for integer overflow.
5606 (x_set_alpha): Do not assume XINT fits in int.
5607
5608 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5609 This is for the members text_lines, text_cols, total_lines, total_cols,
5610 where the system imposes an 'int' limit.
5611
5612 * fringe.c (Fdefine_fringe_bitmap):
5613 Don't update size until alloc works.
5614
5615 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5616 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5617
5618 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5619 Check for size-calculation overflow.
5620 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5621 do, as we prefer signed integers.
5622 (id_to_widget.max_size, id_to_widget.used)
5623 (xg_store_widget_in_map, xg_remove_widget_from_map)
5624 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5625 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5626 Use and return ptrdiff_t, not int.
5627 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5628 * gtkutil.h: Change prototypes to match the above.
5629
5630 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5631 are duplicate now that they've been promoted to lisp.h.
5632 (x_allocate_bitmap_record, x_alloc_image_color)
5633 (make_image_cache, cache_image, xpm_load):
5634 Don't update size until alloc is done.
5635 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5636 (x_detect_edges):
3256efce 5637 Check for size calculation overflow.
726e0ab1
PE
5638 (ct_colors_allocated_max): New constant.
5639 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5640 overflow.
3256efce 5641
726e0ab1
PE
5642 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5643 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5644 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5645 Use ptrdiff_t, not int, to count maps.
5646 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
5647 calculations. Don't update size until allocation succeeds.
5648 Redo calculations to avoid overflow.
726e0ab1
PE
5649 * keyboard.h: Change prototypes to match the above.
5650
5651 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5652 to count maps.
5653 (current_minor_maps): Check for size calculation overflow.
5654 * keymap.h: Change prototypes to match the above.
5655
5656 * lread.c (read1, init_obarray): Don't update size until alloc done.
5657
5658 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5659 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5660
726e0ab1
PE
5661 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5662 Now ptrdiff_t, not int.
5663 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5664 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5665
5666 * process.c (Fnetwork_interface_list): Check for overflow
5667 in size calculation.
5668
5669 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5670
5671 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5672 overflow. Don't bother calling xmalloc when xrealloc will do.
5673
5674 * search.c (Freplace_match): Check for size calculation overflow.
5675 (Fset_match_data): Don't assume list lengths fit in 'int'.
5676
5677 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5678 for command line length. Do not attempt to address one before the
5679 beginning of an array, as that's not portable.
5680
5681 * term.c (max_frame_lines): Remove; unused.
5682 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5683 not int.
5684 (encode_terminal_code, calculate_costs): Check for size
5685 calculation overflow.
5686 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5687 table lengths and related sizes. Don't update size until alloc
5688 done. Redo calculations to avoid overflow.
5689 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5690
5691 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5692 subtracting pointers.
5693 (gobble_line): Check for overflow more carefully. Don't update size
5694 until alloc done.
5695
5696 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5697 Don't update size until alloc done.
5698 Redo size calculations to avoid overflow.
5699 Check for size calculation overflow.
0065d054 5700 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5701
5702 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5703 Use ptrdiff_t, not int, for sizes.
5704 (store_mode_line_noprop_char): Don't update size until alloc done.
5705
0065d054
PE
5706 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5707 Use ptrdiff_t, not int, for sizes.
5708 (Finternal_make_lisp_face, cache_face):
5709 Check for size calculation overflow.
5710 (cache_face): Treat size calculation overflows as if they were
5711 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5712
5713 * xfns.c (x_encode_text, x_set_name_internal)
5714 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5715 sizes, since they can exceed INT_MAX in size. Check for size
5716 calculation overflow.
5717
0065d054
PE
5718 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5719 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5720 Don't update size until alloc done.
5721
0065d054 5722 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5723 as sprintf is limited to int lengths.
1d526e2f 5724
252c5ee1
PE
5725 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5726 (X_LONG_MIN): New macros.
864d7ce7
PE
5727 Use them to make the following changes clearer.
5728 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5729 This change doesn't affect the value now, but it may help remind
5730 future maintainers not to raise the value too much later.
5731 (SELECTION_QUANTUM): Remove, replacing with ...
5732 (selection_quantum): ... new function, which avoids overflow.
5733 All uses changed.
5734 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5735 assumption that selection length fits in 'int'.
5736 (x_reply_selection_request, x_handle_selection_request)
5737 (x_get_window_property, receive_incremental_selection)
5738 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5739 (lisp_data_to_selection_data, clean_local_selection_data):
5740 Use ptrdiff_t, not int, to record length of selection.
5741 (x_reply_selection_request, x_get_window_property)
5742 (receive_incremental_selection, x_property_data_to_lisp):
5743 Redo calculations to avoid overflow.
5744 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5745 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5746 something.
5747 (x_get_window_property, receive_incremental_selection)
5748 (lisp_data_to_selection_data, x_property_data_to_lisp):
5749 Check for size-calculation overflow.
5750 (x_get_window_property, receive_incremental_selection)
5751 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5752 Don't store size until memory allocation succeeds.
5753 (x_get_window_property): Plug memory leak on memory exhaustion.
5754 Don't double-block input; malloc is safe here. Don't assume 2**34
5755 - 4 fits in unsigned long. Add an xassert to check
5756 XGetWindowProperty overflow. Be more careful about overflow
5757 calculations, and distinguish size from memory overflow better.
5758 (receive_incremental_selection): When tracing, don't assume
5759 unsigned int is less than INT_MAX.
5760 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5761 harmful) conversions of unsigned short to int.
5762 (lisp_data_to_selection_data): Don't assume that integers
5763 in the range -65535 through -1 fit in an X unsigned short.
5764 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5765 result parameters unless successful. Rely on cons_to_unsigned
5766 to report problems with elements; the old code wasn't right anyway.
5767 (x_check_property_data): Check for int overflow; we cannot use
5768 a wider type due to X limits.
5769 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5770
726e0ab1 5771 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5772
0065d054
PE
5773 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5774 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5775 (x_color_cells): Don't store size until memory allocation succeeds.
5776 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5777 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5778 (x_term_init): Don't assume length fits in int (sprintf is limited
5779 to int size).
bc18e09d 5780
ebfa62c0
PE
5781 Use ptrdiff_t for composition IDs.
5782 * character.c (lisp_string_width):
5783 * composite.c (composition_table_size, n_compositions)
5784 (get_composition_id, composition_gstring_from_id):
5785 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5786 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5787 * window.c (Frecenter):
5788 Use ptrdiff_t, not int, for composition IDs.
5789 * composite.c (get_composition_id): Check for integer overflow.
5790 * composite.h: Adjust prototypes to match the above changes.
5791
d3411f89
PE
5792 Use ptrdiff_t for hash table indexes.
5793 * category.c (hash_get_category_set):
5794 * ccl.c (ccl_driver):
5795 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5796 * coding.c (coding_system_charset_list, detect_coding_system):
5797 * coding.h (struct coding_system.id):
5798 * composite.c (get_composition_id, gstring_lookup_cache):
5799 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5800 * image.c (xpm_get_color_table_h):
5801 * lisp.h (hash_lookup, hash_put):
5802 * minibuf.c (Ftest_completion):
5803 Use ptrdiff_t for hash table indexes, not int (which is too
5804 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5805 32-bit --with-wide-int hosts).
5806
e097a6fa
PE
5807 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5808 Add a FIXME comment about memory leaks.
5809 (syms_of_charset): Don't assume xmalloc returns.
5810
5637687f
PE
5811 Don't assume that stated character widths fit in int.
5812 * character.c (Fchar_width, c_string_width, lisp_string_width):
5813 * character.h (CHAR_WIDTH):
5814 * indent.c (MULTIBYTE_BYTES_WIDTH):
5815 Use sanitize_char_width to avoid undefined and/or bad behavior
5816 with outlandish widths.
a66cfb1c 5817 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5818 now that we have two such functions. All uses changed.
5819 (sanitize_char_width): New inline function.
5820
a2271ba2
PE
5821 Don't assume that tab-width fits in int.
5822 * character.h (sanitize_width): New inline function.
5823 (SANE_TAB_WIDTH): New macro.
5824 (ASCII_CHAR_WIDTH): Use it.
5825 * indent.c (sane_tab_width): Remove. All uses replaced by
5826 SANE_TAB_WIDTH (current_buffer).
5827 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5828
18c52557
PE
5829 * fileio.c: Integer overflow issues with file modes.
5830 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5831
caeeedc1
PE
5832 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5833 Remove unreachable code.
5834 (read_hex, load_charset_map_from_file): Check for integer overflow.
5835
6df6ae42 5836 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5837 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5838 (x_send_scroll_bar_event): Likewise. Check that the size does not
5839 exceed limits imposed by XClientMessageEvent, as well as the usual
5840 ptrdiff_t and size_t limits.
5841
b13995db
PE
5842 * keyboard.c: Overflow, signedness and related fixes.
5843 (make_lispy_movement): Use same integer type in forward decl
5844 that is used in the definition.
5845 (read_key_sequence, keyremap_step):
5846 Change bufsize argument back to int, undoing my 2011-03-30 change.
5847 We prefer signed types, and int is wide enough here.
5848 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5849 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5850 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5851 length, not size_t. Use ptrdiff_t for index, not int.
5852 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5853 possibility of integer overflow.
5854
13464394
PE
5855 Overflow, signedness and related fixes for images.
5856
5857 * dispextern.h (struct it.stack[0].u.image.image_id)
5858 (struct_it.image_id, struct image.id, struct image_cache.size)
5859 (struct image_cache.used, struct image_cache.ref_count):
5860 * gtkutil.c (update_frame_tool_bar):
5861 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5862 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5863 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5864 * nsmenu.m (update_frame_tool_bar):
5865 * xdisp.c (calc_pixel_width_or_height):
5866 * xfns.c (image_cache_refcount):
5867 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5868 on typical 64-bit hosts.
5869
5870 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5871 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5872 Omit unnecessary casts to int.
5873 (parse_image_spec): Check that integers fall into 'int' range
5874 when the callers expect that.
5875 (image_ascent): Redo ascent calculation to avoid int overflow.
5876 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5877 (lookup_image): Remove unnecessary tests.
5878 (xbm_image_p): Locals are now of int, not EMACS_INT,
5879 since parse_image_check makes sure they fit into int.
5880 (png_load, gif_load, svg_load_image):
5881 Prefer int to unsigned where either will do.
5882 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5883 old tiff_error_handler and tiff_warning_handler.
5884 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5885 stack buffer overflows. It uses only the features of vsnprintf
5886 that are common to both POSIX and native Microsoft.
5887 (tiff_error_handler, tiff_warning_handler): Use it.
5888 (tiff_load, gif_load, imagemagick_load_image):
5889 Don't assume :index value fits in 'int'.
5890 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5891 (imagemagick_load_image): Check that crop parameters fit into
5892 the integer types that MagickCropImage accepts. Don't assume
5893 Vimagemagick_render_type has a nonnegative value. Don't assume
5894 size_t fits in 'long'.
5895 (gs_load): Use printmax_t to print the widest integers possible.
5896 Check for integer overflow when computing image height and width.
5897
c11821d4
EZ
58982011-08-26 Eli Zaretskii <eliz@gnu.org>
5899
5900 * xdisp.c (redisplay_window): Don't force window start if point
5901 will be invisible in the resulting window. (Bug#9324)
5902
0c95fcf7
EZ
59032011-08-25 Eli Zaretskii <eliz@gnu.org>
5904
5905 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5906 the display spec is of the form `(space ...)'.
5907 (handle_display_spec): Return the value returned by
5908 handle_single_display_spec, not just 1 or zero.
5909 (handle_single_display_spec): If the display spec is of the form
5910 `(space ...)', and specifies display in the text area, return 2
5911 rather than 1.
fee65a97 5912 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5913 accurately, and prefer exact match for point under bidi.
5914 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5915
5916 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5917 into disp_prop; all users changed.
5918
5919 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5920 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5921 for the text covered by the display property.
5922
e4ed06f1
CY
59232011-08-25 Chong Yidong <cyd@stupidchicken.com>
5924
5925 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5926 Change return value to nil.
5927 (Frecord_buffer): Delete unused function.
5928
f67cdd7f
EZ
59292011-08-24 Eli Zaretskii <eliz@gnu.org>
5930
5980d4c6
EZ
5931 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5932 buffers, return left-to-right.
8610fe8b
EZ
5933 (set_cursor_from_row): Consider candidate row a win if its glyph
5934 represents a newline and point is on that newline. Fixes cursor
5935 positioning on the newline at EOL of R2L text within L2R
5936 paragraph, and vice versa.
5937 (try_cursor_movement): Check continued rows, in addition to
5938 continuation rows. Fixes unwarranted scroll when point enters a
5939 continued line of R2L text within an L2R paragraph, or vice versa.
5940 (cursor_row_p): Consider the case of point being equal to
5941 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5942 from the end of a short line to the beginning of a continued line
5943 of R2L text within L2R paragraph.
5944 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5945 composed characters.
5980d4c6 5946
f67cdd7f
EZ
5947 * bidi.c (bidi_check_type): Use xassert.
5948 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5949 members.
5950
bca633fb
EZ
59512011-08-23 Eli Zaretskii <eliz@gnu.org>
5952
5953 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5954 a character.
5955
4a5885a7
CY
59562011-08-23 Chong Yidong <cyd@stupidchicken.com>
5957
5958 * nsfont.m (ns_otf_to_script): Fix typo.
5959
0902a04e
KH
59602011-08-22 Kenichi Handa <handa@m17n.org>
5961
5962 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5963 extra slot even if the purpose is char-code-property-table.
5964
1a2e6670
EZ
59652011-08-23 Eli Zaretskii <eliz@gnu.org>
5966
8ddde651
EZ
5967 * xdisp.c (redisplay_window): When computing centering_position,
5968 account for the height of the header line. (Bug#8874)
5969
425cc014
EZ
5970 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5971 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5972 candidate is selected by the mouse, and that candidate has a
5973 composed character under the mouse.
5974
1a2e6670
EZ
5975 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5976 coordinates reported by pos-visible-in-window-p for a composed
5977 character in column zero.
5978
8b76d6f8
SM
59792011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5980
5981 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5982
dac347dd
EZ
59832011-08-22 Eli Zaretskii <eliz@gnu.org>
5984
5985 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5986 consider it a hit if to_charpos is anywhere in the range of the
5987 composed buffer positions.
5988
e013fb34
CY
59892011-08-22 Chong Yidong <cyd@stupidchicken.com>
5990
5991 * image.c (gif_load): Don't assume that each subimage has the same
5992 dimensions as the base image. Handle disposal method that is
5993 "undefined" by the gif spec (Bug#9335).
5994
bd1ba3e8
CY
59952011-08-20 Chong Yidong <cyd@stupidchicken.com>
5996
5997 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5998 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5999
54a1215b
EZ
60002011-08-19 Eli Zaretskii <eliz@gnu.org>
6001
823564e5
EZ
6002 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6003 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6004 from an Org mode buffer to a Speedbar frame.
6005
54a1215b
EZ
6006 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6007 a composition, take its buffer position from IT->cmp_it.charpos.
6008 Fixes cursor positioning at the beginning of a line that begins
6009 with a composed character.
6010
9778ebcc
EZ
60112011-08-18 Eli Zaretskii <eliz@gnu.org>
6012
0be6ee06
EZ
6013 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6014 character bidirectional type, use STRONG_L instead. Fixes crashes
6015 in a buffer produced by `describe-categories'.
6016
9778ebcc
EZ
6017 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6018 members before the level stack, so they would be saved and
6019 restored when copying iterator state. Fixes incorrect reordering
6020 around TABs covered by display properties.
6021
156bffbe
AS
60222011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6023
6b02f655 6024 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6025
72ad093b
CY
60262011-08-17 Chong Yidong <cyd@stupidchicken.com>
6027
6028 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6029 (internal_condition_case_2, internal_condition_case_n):
6030 Remove unnecessary aborts (Bug#9081).
72ad093b 6031
35774242
EZ
60322011-08-17 Eli Zaretskii <eliz@gnu.org>
6033
6034 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6035 has no `load' handler, try opening the file locally. (Bug#9311)
6036
db76dd85
KB
60372011-08-16 Ken Brown <kbrown@cornell.edu>
6038
6039 * gmalloc.c: Expand comment.
6040
b215eee5
EZ
60412011-08-16 Eli Zaretskii <eliz@gnu.org>
6042
6043 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6044 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6045
a4579d33
KB
60462011-08-16 Ken Brown <kbrown@cornell.edu>
6047
6048 Fix memory allocation problems in Cygwin build (Bug#9273).
6049
6050 * unexcw.c ( __malloc_initialized): Declare external variable.
6051 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6052
8b76d6f8
SM
6053 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6054 New variables.
a4579d33
KB
6055 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6056 dumped emacs.
6057 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6058 in the static heap.
6059 [CYGWIN] (special_realloc): New function.
6060 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6061 requests to realloc storage in the static heap.
6062
3ebec551
PE
60632011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6064
6065 * bidi.c (bidi_initialize): Remove unused local.
6066
9fd8be00
EZ
60672011-08-15 Eli Zaretskii <eliz@gnu.org>
6068
6b02f655
SM
6069 * bidimirror.h:
6070 * biditype.h: Remove file.
6071 * makefile.w32-in ($(BLD)/bidi.$(O)):
6072 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6073
6074 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6075
6076 * chartab.c: Improve commentary for the uniprop_table API.
6077
32413314
EZ
6078 * bidi.c (bidi_paragraph_init): Support zero value of
6079 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6080 (bidi_initialize): Use uniprop_table instead of including
6081 biditype.h and bidimirror.h.
32413314 6082
9fd8be00
EZ
6083 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6084 coordinates of the iterator when restoring from ppos_it.
6085 (Bug#9296)
6086
5cf2b69b
KH
60872011-08-14 Kenichi Handa <handa@m17n.org>
6088
6089 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6090 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6091
daf17d00
EZ
60922011-08-14 Eli Zaretskii <eliz@gnu.org>
6093
6094 * xdisp.c (move_it_in_display_line_to): Don't invoke
6095 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6096 ppos_it. Fixes vertical cursor motion when line beginning is
6097 covered by an image. (Bug#9296)
6098
08e3161a
JD
60992011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6100
6101 * nsterm.h (ns_run_ascript): Declare.
6102 (NSAPP_DATA2_RUNASSCRIPT): Define.
6103
6104 * nsfns.m (as_script, as_result, as_status): New static variables.
6105 (ns_run_ascript): New function.
5e617bc2 6106 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6107 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6108 the event loop. Get status from as_status (Bug#7276).
6109
6110 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6111 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6112 the event loop (Bug#7276).
6113
a3720aa2
AS
61142011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6115
6116 * gnutls.c (QCgnutls_bootprop_priority)
6117 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6118 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6119 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6120 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6121 (QCgnutls_bootprop_verify_hostname_error)
6122 (QCgnutls_bootprop_callbacks_verify): Rename from
6123 Qgnutls_bootprop_..., all uses changed.
6124
6125 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6126 uses changed.
6127
0a0d27fb
PE
61282011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6129
19d5c50c
PE
6130 * xfaces.c (Qframe_set_background_mode): Now static.
6131 * dispextern.h (Qframe_set_background_mode): Remove decl.
6132
0a0d27fb
PE
6133 * process.c (Fnetwork_interface_info): Declare local only if needed.
6134
377538cb
JD
61352011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6136
6137 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6138 (Fnetwork_interface_list): Allocate in increments of bytes instead
6139 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6140 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6141 sockaddr.
6142 (struct ifflag_def): notrailers is smart on OSX.
6143 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6144 Get hardware address with getifaddrs if available.
6145
08fff70c
EZ
61462011-08-12 Eli Zaretskii <eliz@gnu.org>
6147
6148 * xdisp.c (iterate_out_of_display_property): xassert that
6149 IT->position is set to within IT->object's boundaries. Break from
6150 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6151 when IT->position is set up wrongly due to some bug.
6152 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6153 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6154 entry. Force push_it to save on the stack the current
6155 buffer/string position, to be restored by pop_it. Fix flags in
6156 the iterator structure wrt the object coming from a display
6157 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6158 properties. (Bug#9284)
6159
7be1c708 61602011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6161
7be1c708
CY
6162 * fontset.c (fontset_get_font_group): Add proper type checks.
6163 (Bug#9172)
aac0c6e3 6164
7be1c708 61652011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6166
7be1c708
CY
6167 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6168 and LC_VERSION_MIN_MACOSX.
6169 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6170 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6171
97bb72a6
EZ
61722011-08-08 Eli Zaretskii <eliz@gnu.org>
6173
6174 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6175 no-display-properties-and-no-overlays under bidi display.
6176 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6177 properties and overlays.
97bb72a6 6178
d5617611
CY
61792011-08-08 Chong Yidong <cyd@stupidchicken.com>
6180
37e11a63
CY
6181 * editfns.c (Fset_time_zone_rule): Document relationship with the
6182 setenv function.
6183
d5617611
CY
6184 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6185 the font entity extracted from the cache (Bug#8109).
6186
58872834
CY
61872011-08-07 Chong Yidong <cyd@stupidchicken.com>
6188
6189 * composite.c (autocmp_chars): Don't reset point. That is done by
6190 restore_point_unwind (Bug#5984).
6191
75bfc667
JL
61922011-08-07 Juri Linkov <juri@jurta.org>
6193
6194 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6195 to show the arg `TIME' instead of `TIMEVAL'.
6196
d1410150
EZ
61972011-08-06 Eli Zaretskii <eliz@gnu.org>
6198
6199 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6200 display property strides EOL and includes a newline, as in
6201 longlines-mode. (Bug#9254)
75b771e4
EZ
6202 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6203 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6204
6205 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6206 is non-zero, even if the data buffer is NULL. Fixes a crash in
6207 vertical-motion with longlines-mode. (Bug#9254)
6208
35928349
EZ
62092011-08-05 Eli Zaretskii <eliz@gnu.org>
6210
ec7cc85b
EZ
6211 * bidi.c <bidi_cache_total_alloc>: Now static.
6212 (bidi_initialize): Initialize bidi_cache_total_alloc.
6213
8b76d6f8 6214 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6215 cache. (Bug#9221)
6216
6217 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6218 amount allocated this far in `bidi_cache_total_alloc'.
6219 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6220 non-zero, only free the data buffer without restoring the cache
6221 contents. All callers changed.
6222
6223 * dispextern.h (bidi_unshelve_cache): Update prototype.
6224
6225 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6226 (move_it_in_display_line, move_it_to)
6227 (move_it_vertically_backward, move_it_by_lines): Replace the call
6228 to xfree to an equivalent call to bidi_unshelve_cache.
6229 (move_it_in_display_line_to): Fix logic of returning
412b6358 6230 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 6231
e2e2423b
EZ
62322011-08-05 Eli Zaretskii <eliz@gnu.org>
6233
6234 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6235 came from a string character with a `cursor' property. (Bug#9229)
6236
ae9e757a
JD
62372011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6238
6239 * Makefile.in (LIB_PTHREAD): New variable.
6240 (LIBES): Add LIB_PTHREAD (Bug#9216).
6241
6242 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6243 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6244
213bd7f2
AS
62452011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6246
6b02f655 6247 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 6248
99aaf75f
JD
62492011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6250
6251 * xterm.c (x_find_topmost_parent): New function.
6252 (x_set_frame_alpha): Find topmost parent window with
6253 x_find_topmost_parent and set the property there also (bug#9181).
6254 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6255
c74e9d86
PE
62562011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6257
6258 * callproc.c (Fcall_process): Avoid vfork clobbering
6259 the local vars buffer, coding_systems, current_dir.
6260
640c8776
SM
62612011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6262
6263 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6264
f26d0e4c
PE
62652011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6266
8a10d76c
PE
6267 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6268 so that it is not optimized away.
6269
f26d0e4c
PE
6270 * xdisp.c (compute_display_string_pos): Remove unused local.
6271
55439c61
EZ
62722011-08-02 Eli Zaretskii <eliz@gnu.org>
6273
6274 Fix slow cursor motion and scrolling in large buffers with
6275 selective display, like Org Mode buffers. (Bug#9218)
6276
6277 * dispextern.h (struct bidi_it): New member disp_prop_p.
6278
6279 * xdisp.c: Remove one-slot cache of display string positions.
6280 (compute_display_string_pos): Accept an additional argument
5e617bc2 6281 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
6282 for a display string or property. If found, set DISP_PROP_P
6283 non-zero.
6284
6285 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
6286 DISP_PROP_P, and pass it to compute_display_string_pos.
6287 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
6288 non-zero. All callers of bidi_fetch_char changed.
6289
fb33fa43
SM
62902011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6291
6292 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6293
b099e063
DM
62942010-12-03 Don March <don@ohspite.net>
6295
6296 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6297 last character M-[char] is translated to ESC [char] (bug#7541).
6298
5cc7f7af
KH
62992011-08-02 Kenichi Handa <handa@m17n.org>
6300
d0fffa3f 6301 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
6302
6303 * chartab.c (uniprop_table): Make it non-static.
6304
525d5e6e
EZ
63052011-08-01 Eli Zaretskii <eliz@gnu.org>
6306
6307 * xdisp.c (forward_to_next_line_start): Accept additional argument
6308 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6309 on the newline.
6310 (reseat_at_next_visible_line_start): Use the bidi iterator state
6311 returned by forward_to_next_line_start to restore the state of
6312 it->bidi_it after backing up to previous newline. (Bug#9212)
6313
31011111
AS
63142011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6315
6316 * regex.c (re_comp): Protoize.
6317 (re_exec): Fix return type.
6318 (regexec): Fix type of `ret'. (Bug#9203)
6319
476371c4
PE
63202011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6321
e5d76069
PE
6322 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6323 This is needed if max-image-size is a floating-point number.
6324
9a79b20c
AS
63252011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6326
6327 * print.c (print_object): Print empty symbol as ##.
6328
6329 * lread.c (read1): Read ## as empty symbol.
6330
d8c2fa78
AA
63312011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6332
6333 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6334 setting frame foreground color (Bug#9175).
6335 (x_set_background_color): Likewise.
6336
ffe57a7a
AA
6337 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6338 contents (Bug#9176).
6339 (EmacsTooltip -init): Remove bezels and add shadows to
6340 tooltip windows.
6341
bf3492a5
AA
6342 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6343 or scroll bar (Bug#8470).
6344
d55e9c53
AA
6345 * nsfont.m (nsfont_open): Remove assignment to voffset and
6346 unnecessary vars hshink, expand, hd, full_height, min_height.
6347 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6348
6349 * nsterm.h (nsfont_info): Remove voffset field.
6350
d8c2fa78 63512011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6352
6353 Implement strike-through and overline on NextStep (Bug#8863).
6354
6355 * nsfont.m (nsfont_open): Use underline position provided by font,
6356 instead of hard-coded value of 2.
6357 (nsfont_draw): Call ns_draw_text_decoration instead.
6358
6359 * nsterm.h: Add declaration for ns_draw_text_decoration.
6360
6361 * nsterm.m (ns_draw_text_decoration): New function for drawing
6362 underline, overline, and strike-through.
6363 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6364 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6365 accommodate underlining, etc.
4843aac3 6366
4cc60b9b
EZ
63672011-07-28 Eli Zaretskii <eliz@gnu.org>
6368
bc7ece87
EZ
6369 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6370 default.
4cc60b9b 6371
476371c4
PE
63722011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6373
66606eea
PE
6374 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6375 Without this fix, if a signal arrives just after memory fills up,
6376 'malloc' might be invoked reentrantly.
6377
476371c4
PE
6378 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6379 In other words, assume that every image size is allowed, on non-X
6380 hosts. This assumption is probably wrong, but it lets Emacs compile.
6381
f3fcc40d
AS
63822011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6383
6384 * regex.c (re_iswctype): Convert return values to boolean.
6385
350c992f
EZ
63862011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6387
6388 * xdisp.c (compute_display_string_pos): Don't use cached display
6389 string position if the buffer had its restriction changed.
6390 (Bug#9184)
6391
5266b4bb
PE
63922011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6393
6394 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6395
2573a837 63962011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6397
41f55ccd 6398 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6399
39e378da
PE
6400 * bidi.c: Integer size and overflow fixes.
6401 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6402 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6403 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6404 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6405 (bidi_find_other_level_edge):
6406 Use ptrdiff_t instead of EMACS_INT where either will do.
6407 This works better on 32-bit hosts configured --with-wide-int.
6408 (bidi_cache_ensure_space): Check for size-calculation overflow.
6409 Use % rather than repeated addition, for better worst-case speed.
6410 Don't set bidi_cache_size until after xrealloc returns, because it
6411 might not return.
6412 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
6413 (bidi_cache_ensure_space): Also check that the bidi cache size
6414 does not exceed that of the largest Lisp string or buffer. See Eli
6415 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 6416
5e927815
PE
6417 * alloc.c (__malloc_size_t): Remove.
6418 All uses replaced by size_t. See Andreas Schwab's note
6419 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6420
ca4aa935
PE
6421 * image.c: Improve checking for integer overflow.
6422 (check_image_size): Assume that f is nonnull, since
6423 it is always nonnull in practice. This is one less thing to
6424 worry about when checking for integer overflow later.
6425 (x_check_image_size): New function, which checks for integer
6426 overflow issues inside X.
6427 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6428 This removes the need for a memory_full check.
6429 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6430 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6431 (xbm_read_bitmap_data): Change locals back to 'int', since
6432 their values must fit in 'int'.
6433 (xpm_load_image, png_load, tiff_load):
6434 Invoke x_create_x_image_and_pixmap earlier,
6435 to avoid much needless work if the image is too large.
6436 (tiff_load): Treat overly large images as if
6437 x_create_x_image_and_pixmap failed, not as malloc failures.
6438 (gs_load): Use x_check_image_size.
6439
5f8f9cc2
PE
6440 * gtkutil.c: Omit integer casts.
6441 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6442 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6443
5adf60bc
PE
6444 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6445
c8907a93
PE
6446 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6447 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6448 would wrongly return t on a 64-bit host.
6449
e3c25c68
PE
6450 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6451 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6452 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6453 and therefore cause GCC to emit a bogus diagnostic in some cases.
6454
3f791afe
PE
6455 * image.c: Integer signedness and overflow and related fixes.
6456 This is not an exhaustive set of fixes, but it's time to
6457 record what I've got.
6458 (lookup_pixel_color, check_image_size): Remove redundant decls.
6459 (check_image_size): Don't assume that arbitrary EMACS_INT values
6460 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6461 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6462 (tiff_load, imagemagick_load_image):
6463 Check for overflow in size calculations.
6464 (x_create_x_image_and_pixmap): Remove unnecessary test for
6465 xmalloc returning NULL; that can't happen.
6466 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6467 (xpm_color_bucket): Use better integer hashing function.
6468 (xpm_cache_color): Don't possibly over-allocate memory.
6469 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6470 (gif_memory_source):
6471 Use ptrdiff_t, not int or size_t, to record sizes.
6472 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6473 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6474 either works, as we prefer signed integers.
6475 (tiff_read_from_memory, tiff_write_from_memory):
6476 Return tsize_t, not size_t, since that's what the TIFF API wants.
6477 (tiff_read_from_memory): Don't fail simply because the read would
6478 go past EOF; instead, return a short read.
6479 (tiff_load): Omit no-longer-needed casts.
6480 (Fimagemagick_types): Don't assume size fits into 'int'.
6481
3cc5a532
PE
6482 Improve hashing quality when configured --with-wide-int.
6483 * fns.c (hash_string): New function, taken from sxhash_string.
6484 Do not discard information about ASCII character case; this
6485 discarding is no longer needed.
6486 (sxhash-string): Use it. Change sig to match it. Caller changed.
6487 * lisp.h: Declare it.
6488 * lread.c (hash_string): Remove, since we now use fns.c's version.
6489 The fns.c version returns a wider integer if --with-wide-int is
6490 specified, so this should help the quality of the hashing a bit.
6491
b312a492
PE
6492 * emacs.c: Integer overflow minor fix.
6493 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6494 Define only if GNU_LINUX.
6495 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6496
dfd153ae
PE
6497 * dispnew.c: Integer signedness and overflow fixes.
6498 Remove unnecessary forward decls, that were a maintenance hassle.
6499 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6500 All uses changed.
6501 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6502 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6503 (prepare_desired_row, line_draw_cost):
6504 Use int, not unsigned, where either works.
6505 (save_current_matrix, restore_current_matrix):
6506 Use ptrdiff_t, not size_t, where either works.
6507 (init_display): Check for overflow more accurately, and without
6508 relying on undefined behavior.
6509
a81d11a3
PE
6510 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6511 Remove, replacing with the new symbols in lisp.h. All uses changed.
6512 * fileio.c (make_temp_name):
6513 * filelock.c (lock_file_1, lock_file):
6514 * xdisp.c (message_dolog):
6515 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6516 Use pMd etc. instead.
6517 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6518 replacing the pWIDE etc. symbols removed from editfns.c.
6519
3300e6fd
PE
6520 * keyboard.h (num_input_events): Now uintmax_t.
6521 This is (very slightly) less likely to mess up due to wraparound.
6522 All uses changed.
6523
fd05c7e9
PE
6524 * buffer.c: Integer signedness fixes.
6525 (alloc_buffer_text, enlarge_buffer_text):
6526 Use ptrdiff_t rather than size_t when either will do, as we prefer
6527 signed integers.
6528
903fe15d
PE
6529 * alloc.c: Integer signedness and overflow fixes.
6530 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6531 (__malloc_size_t): Default to size_t, not to int.
6532 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6533 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6534 Prefer ptrdiff_t to size_t when either would do, as we prefer
6535 signed integers.
6536 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6537 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6538 Now const. Initialize with values that are in range even if char
6539 is signed.
6540 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6541 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6542 These functions do the right thing with sizes > 2**32.
6543 (check_depth): Now ptrdiff_t, not int.
6544 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6545 Adjust to new way of storing sizes. Check for size overflow bugs
6546 in rest of code.
6547 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6548 slightly wrong anyway, as it missed one instance of
6549 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6550 (refill_memory_reserve): Omit needless cast to size_t.
6551 (mark_object_loop_halt): Mark as externally visible.
6552
ac82cc6a
PE
6553 * xselect.c: Integer signedness and overflow fixes.
6554 (Fx_register_dnd_atom, x_handle_dnd_message):
6555 Use ptrdiff_t, not size_t, since we prefer signed.
6556 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6557 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6558 x_dnd_atoms_size and x_dnd_atoms_length.
6559
c2d1e36d
PE
6560 * doprnt.c: Prefer signed to unsigned when either works.
6561 * eval.c (verror):
6562 * doprnt.c (doprnt):
6563 * lisp.h (doprnt):
6564 * xdisp.c (vmessage):
6565 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6566 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6567 prefer signed arithmetic to avoid comparison confusion.
6568 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6569 but is a bit tricky.
6570
0e926e56
PE
6571 Assume freestanding C89 headers, string.h, stdlib.h.
6572 * data.c, doprnt.c, floatfns.c, print.c:
6573 Include float.h unconditionally.
6574 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6575 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6576 * regex.c: Likewise for stddef.h, string.h.
6577 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6578 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6579 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6580 (STDC_HEADERS): Remove obsolete defines.
6581 * sysdep.c: Include limits.h unconditionally.
6582
9cfdb3ec
PE
6583 Assume support for memcmp, memcpy, memmove, memset.
6584 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6585 * regex.c (memcmp, memcpy):
6586 Remove; we assume C89 now.
6587
6588 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6589 (__malloc_safe_bcopy): Remove; no longer needed.
6590
cf950e6b 6591 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
6592 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6593 well either way, and we prefer signed to unsigned.
6594
dbf38e02
LMI
65952011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6596
6597 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6598 closes the connection while we're reading (bug#9182).
6599
d6f0886c 66002011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 6601
d6f0886c
JD
6602 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6603 are specified (Bug#9168).
24e0f6b1 6604
2eb1f9e6
PE
66052011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6606
6607 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6608 Found by GCC static checking and --with-wide-int on a 32-bit host.
6609
22381272 66102011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
6611
6612 * xdisp.c (compute_display_string_pos): Fix logic of caching
6613 previous display string position. Initialize cached_prev_pos to
6614 -1. Fixes slow-down at the beginning of a buffer.
6615
f25e39b4
EZ
66162011-07-24 Eli Zaretskii <eliz@gnu.org>
6617
6618 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6619 for attrs[LFACE_FONTSET_INDEX].
6620
04c4b52e
PE
66212011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6622
6623 * xml.c (parse_region): Remove unused local
6624 that was recently introduced.
6625
c1734fbd
EZ
66262011-07-23 Eli Zaretskii <eliz@gnu.org>
6627
be18c5a5
EZ
6628 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6629 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6630
c1734fbd
EZ
6631 * xdisp.c (move_it_in_display_line_to): Record the best matching
6632 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
6633 exit if none of the characters scanned was an exact match.
6634 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
6635 when exact match is impossible due to invisible text, and the
6636 lines are truncated.
6637
a258d627
JD
66382011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6639
6640 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6641 for OSX >= 10.7.
6642
b6d5a689
EZ
66432011-07-22 Eli Zaretskii <eliz@gnu.org>
6644
0f74f785
EZ
6645 Fix a significant slow-down of cursor motion with C-n, C-p,
6646 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6647 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 6648 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
6649 (next_element_from_buffer): Call compute_stop_pos_backwards to
6650 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
6651 base_level_stop.
6652 (reseat): Don't look for prev_stop, as that could mean a very long
6653 run.
6654 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6655 <cached_disp_overlay_modiff>: Cache for last found display string
6656 position.
551918c1 6657 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
6658 about the same buffer in the same area of character positions, and
6659 the buffer wasn't changed since the time the display string
6660 position was cached.
551918c1 6661
b2d0c91a
EZ
66622011-07-22 Eli Zaretskii <eliz@gnu.org>
6663
6664 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6665 is an integer, which is important for empty lines. (Bug#9149)
6666
043604ee
CY
66672011-07-22 Chong Yidong <cyd@stupidchicken.com>
6668
6669 * frame.c (Fmodify_frame_parameters): In tty case, update the
6670 default face if necessary (Bug#4238).
6671
da4adb04
CY
66722011-07-21 Chong Yidong <cyd@stupidchicken.com>
6673
6674 * editfns.c (Fstring_to_char): No need to explain what a character
6675 is in the docstring (Bug#6576).
6676
9abd0532
LMI
66772011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6678
6679 * xml.c (parse_region): Make sure we always return a tree.
6680
36881d16
HK
66812011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6682
6683 * xml.c (parse_region): If a document contains only comments,
6684 return that, too.
6685
1e98674d
LMI
66862011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6687
6688 * xml.c (make_dom): Return comments, too.
6689
590bd467
PE
66902011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6691
6692 Port to OpenBSD.
6693 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6694 and the surrounding thread.
6695 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6696 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6697 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6698 timer goes off.
6699 * s/openbsd.h (BROKEN_SIGIO): Define.
6700 * unexelf.c (unexec) [__OpenBSD__]:
6701 Don't update the .mdebug section of the Alpha COFF symbol table.
6702
f41628b2
LMI
67032011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6704
6705 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6706 (bug#8460).
6707
b59b67c5
PE
67082011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6709
15e3a074
PE
6710 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6711 This fixes some race conditions on the permissions of any newly
6712 created file.
6713
41bed37d
PE
6714 * alloc.c (valid_pointer_p): Use pipe, not open.
6715 This fixes some permissions issues when debugging.
6716
b59b67c5
PE
6717 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6718 If fchown fails to set both uid and gid, try to set just gid,
6719 as that is sometimes allowed. Adjust the file's mode to eliminate
6720 setuid or setgid bits that are inappropriate if fchown fails.
6721
925a6be7
SM
67222011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6723
6724 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6725 to compare Lisp_Objects.
6726 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6727 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6728 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6729
52968808
AS
67302011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6731
0a6a104b
AS
6732 * lread.c (read_integer): Unread even EOF character.
6733 (read1): Likewise. Properly record start position of symbol.
6734
52968808
AS
6735 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6736 symbol character follows.
6737
9e381cdd
PE
67382011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6739
6740 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6741 This works around a problem with the previous change to Fcopy_file.
6742 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6743 and without this change, GCC might complain about discarding
6744 fchown's return value.
6745
b5641435
JB
67462011-07-16 Juanma Barranquero <lekktu@gmail.com>
6747
6748 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6749
a8031457
PE
67502011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6751
6752 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6753
dd889327
LMI
67542011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6755
750c33f7
LMI
6756 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6757 it's used from the C level.
6758
dd889327
LMI
6759 * process.c: Use the same condition for POLL_FOR_INPUT in both
6760 keyboard.c and process.c (bug#1858).
6761
87e86684
LM
67622011-07-09 Lawrence Mitchell <wence@gmx.li>
6763
6764 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6765 (Fgnutls_boot): Use it.
6766
64348f40
AS
67672011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6768
6769 * doc.c (Fsubstitute_command_keys): Revert last change.
6770
1d698799
LMI
67712011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6772
f863868c
LMI
6773 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6774 quotes the next character, and doesn't affect other longer
6775 sequences (bug#8935).
6776
1d698799
LMI
6777 * lread.c (syms_of_lread): Clarify that is isn't only
6778 `eval-buffer' and `eval-defun' that's affected by
6779 `lexical-binding' (bug#8460).
6780
aa4b6df6
EZ
67812011-07-15 Eli Zaretskii <eliz@gnu.org>
6782
6783 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6784 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6785
5d856da6
PE
67862011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6787
ad6042bb
PE
6788 Fix minor problems found by static checking.
6789 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6790 (elsz): Now a signed constant, not a size_t var. We prefer signed
6791 types to unsigned, to avoid integer comparison confusion. Without
6792 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6793 "cannot optimize loop, the loop counter may overflow", a symptom
6794 of the confusion.
f00bbb22 6795 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6796 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6797
6468f31c
LMI
67982011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6799
49080b10
LMI
6800 * search.c (Fre_search_backward): Mention `case-fold-search' in
6801 all the re_search_* functions (bug#8138).
6802
6468f31c
LMI
6803 * keyboard.c (Fopen_dribble_file): Document when the file is
6804 closed (bug#8056).
6805
c965adc5
EZ
68062011-07-14 Eli Zaretskii <eliz@gnu.org>
6807
df9733bf
EZ
6808 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6809 bidi_cache_idx.
6810
0bb23927
EZ
6811 Support bidi reordering of display and overlay strings.
6812 * xdisp.c (compute_display_string_pos)
6813 (compute_display_string_end): Accept additional argument STRING.
6814 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6815 (reseat_to_string): Initialize bidi_it->string.s and
6816 bidi_it->string.schars.
6817 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6818 NULL (avoids a crash in bidi_paragraph_init).
6819 Initialize itb.string.lstring.
0bb23927
EZ
6820 (init_iterator): Call bidi_init_it only of a valid
6821 buffer position was specified. Initialize paragraph_embedding to
6822 L2R.
6823 (reseat_to_string): Initialize the bidi iterator.
6824 (display_string): If we need to ignore text properties of
6825 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6826 original value of -1 will not work with bidi.)
6827 (compute_display_string_pos): First arg is now struct
6828 `text_pos *'; all callers changed. Support display properties on
6829 Lisp strings.
6830 (compute_display_string_end): Support display properties on Lisp
6831 strings.
6832 (init_iterator, reseat_1, reseat_to_string): Initialize the
6833 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6834 when iterating on a string not from display properties).
640c8776
SM
6835 (compute_display_string_pos, compute_display_string_end):
6836 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6837 arrow keys.
6838 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6839 base_level_stop; instead, set base_level_stop to BEGV.
6840 Fixes crashes in vertical-motion.
0bb23927
EZ
6841 (next_element_from_buffer): Improve commentary for when
6842 the iterator is before prev_stop.
6843 (init_iterator): Initialize bidi_p from the default value of
6844 bidi-display-reordering, not from buffer-local value. Use the
6845 buffer-local value only if initializing for buffer iteration.
6846 (handle_invisible_prop): Support invisible properties on strings
6847 that are being bidi-reordered.
6848 (set_iterator_to_next): Support bidi reordering of C strings and
6849 Lisp strings.
6850 (next_element_from_string): Support bidi reordering of Lisp
6851 strings.
6852 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6853 (display_string): Support display of R2L glyph rows.
6854 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6855 (init_iterator): Don't initialize it->bidi_p for strings
6856 here.
6857 (reseat_to_string): Initialize it->bidi_p for strings here.
6858 (next_element_from_string, next_element_from_c_string)
6859 (next_element_from_buffer): Add xassert's for correspondence
6860 between IT's object being iterated and it->bidi_it.string
6861 structure.
6862 (face_before_or_after_it_pos): Support bidi iteration.
6863 (next_element_from_c_string): Handle the case of the first string
6864 character that is not the first one in the visual order.
6865 (get_visually_first_element): New function, refactored from common
6866 parts of next_element_from_buffer, next_element_from_string, and
6867 next_element_from_c_string.
6868 (tool_bar_lines_needed, redisplay_tool_bar)
6869 (display_menu_bar): Force left-to-right direction. Add a FIXME
6870 comment for making that be controlled by a user option.
6871 (push_it, pop_it): Save and restore the state of the
6872 bidi iterator. Save and restore the bidi_p flag.
6873 (pop_it): Iterate out of display property for string iteration as
6874 well.
6875 (iterate_out_of_display_property): Support iteration over strings.
6876 (handle_single_display_spec): Set up it->bidi_it for iteration
6877 over a display string, and call bidi_init_it.
6878 (handle_single_display_spec, next_overlay_string)
6879 (get_overlay_strings_1, push_display_prop): Set up the bidi
6880 iterator for displaying display or overlay strings.
6881 (forward_to_next_line_start): Don't use the shortcut if
6882 bidi-iterating.
6883 (back_to_previous_visible_line_start): If handle_display_prop
6884 pushed the iterator stack, restore the internal state of the bidi
6885 iterator by calling bidi_pop_it same number of times.
6886 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6887 and we are bidi-iterating, don't decrement the iterator position;
6888 instead, set the first_elt flag in the bidi iterator, to produce
6889 the same effect.
6890 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6891 (push_display_prop): xassert that we are iterating a buffer.
6892 (push_it, pop_it): Save and restore paragraph_embedding member.
6893 (handle_single_display_spec, next_overlay_string)
6894 (get_overlay_strings_1, reseat_1, reseat_to_string)
6895 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6896 correctly. Don't assume unibyte strings are not bidi-reordered.
6897 (compute_display_string_pos)
6898 (compute_display_string_end): Fix handling the case of C string.
6899 (push_it, pop_it): Save and restore from_disp_prop_p.
6900 (handle_single_display_spec, push_display_prop): Set the
6901 from_disp_prop_p flag.
6902 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6903 (pop_it): Call iterate_out_of_display_property only if we are
6904 popping after iteration over a string that came from a display
6905 property. Fix a typo in popping stretch info. Add an assertion
6906 for verifying that the iterator position is in sync with the bidi
6907 iterator.
6908 (handle_single_display_spec, get_overlay_strings_1)
6909 (push_display_prop): Fix initialization of paragraph direction for
6910 string when that of the parent object is not yet determined.
6911 (reseat_1): Call bidi_init_it to resync the bidi
6912 iterator with IT's position. (Bug#7616)
6913 (find_row_edges): If ROW->start.pos gives position
6914 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6915 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6916 Reset the from_disp_prop_p flag.
6917 (SAVE_IT, RESTORE_IT): New macros.
6918 (pos_visible_p, face_before_or_after_it_pos)
6919 (back_to_previous_visible_line_start)
6920 (move_it_in_display_line_to, move_it_in_display_line)
6921 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6922 (try_scrolling, redisplay_window, display_line): Use them when
6923 saving a temporary copy of the iterator and restoring it back.
6924 (back_to_previous_visible_line_start, reseat_1)
6925 (init_iterator): Empty the bidi cache "stack".
6926 (move_it_in_display_line_to): If iterator ended up at
6927 EOL, but we never saw any buffer positions smaller than
6928 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6929 motion in bidi-reordered lines.
6930 (move_it_in_display_line_to): Record prev_method and prev_pos
6931 immediately before the call to set_iterator_to_next. Fixes cursor
6932 motion in bidi-reordered lines with stretch glyphs and strings
6933 displayed in margins. (Bug#8133) (Bug#8867)
6934 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6935 TO_CHARPOS.
640c8776
SM
6936 (pos_visible_p): Support positions in bidi-reordered lines.
6937 Save and restore bidi cache.
0bb23927
EZ
6938
6939 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6940 (bidi_paragraph_info): Delete unused struct.
6941 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6942 (bidi_cache_start): New variable.
6943 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6944 to zero.
6945 (bidi_cache_fetch_state, bidi_cache_search)
6946 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6947 (bidi_cache_find, bidi_peek_at_next_level)
6948 (bidi_level_of_next_char, bidi_find_other_level_edge)
6949 (bidi_move_to_visually_next): Compare cache index with
6950 bidi_cache_start rather than with zero.
6951 (bidi_fetch_char): Accept new argument STRING; all callers
6952 changed. Support iteration over a string. Support strings with
6953 display properties. Support unibyte strings. Fix the type of
6954 `len' according to what STRING_CHAR_AND_LENGTH expects.
6955 (bidi_paragraph_init, bidi_resolve_explicit_1)
6956 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6957 (bidi_level_of_next_char, bidi_move_to_visually_next):
6958 Support iteration over a string.
0bb23927
EZ
6959 (bidi_set_sor_type, bidi_resolve_explicit_1)
6960 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6961 can now be zero (for strings); special values 0 and -1 were
6962 changed to -1 and -2, respectively.
6963 (bidi_char_at_pos): New function.
6964 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6965 Call it instead of FETCH_MULTIBYTE_CHAR.
6966 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6967 initialized to valid values.
6968 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6969 values.
6970 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6971 the test for valid cached positions. Fix the logic for looking up
6972 the sentinel state in the cache. GCPRO the Lisp string we are
6973 iterating.
6974 (bidi_push_it, bidi_pop_it): New functions.
6975 (bidi_initialize): Initialize the bidi cache start stack pointer.
6976 (bidi_cache_ensure_space): New function, refactored from part of
6977 bidi_cache_iterator_state. Don't assume the required size is just
6978 one BIDI_CACHE_CHUNK away.
6979 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6980 (bidi_count_bytes, bidi_char_at_pos): New functions.
6981 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6982 always valid if bidi_cache_idx is valid.
6983 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6984 is valid if it's going to be used.
6985 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6986 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6987 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6988 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6989 (bidi_find_other_level_edge, bidi_cache_start_stack):
6990 All variables related to cache indices are now EMACS_INT.
c965adc5 6991
0bb23927
EZ
6992 * dispextern.h (struct bidi_string_data): New structure.
6993 (struct bidi_it): New member `string'. Make flag members be 1-bit
6994 fields, and put them last in the struct.
640c8776
SM
6995 (compute_display_string_pos, compute_display_string_end):
6996 Update prototypes.
0bb23927
EZ
6997 (bidi_push_it, bidi_pop_it): Add prototypes.
6998 (struct iterator_stack_entry): New members bidi_p,
6999 paragraph_embedding, and from_disp_prop_p.
7000 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7001 (bidi_shelve_cache, bidi_unshelve_cache):
7002 Declare prototypes.
0bb23927
EZ
7003
7004 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7005 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7006 and vector-like objects.
7007
7008 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7009 cache around display iteration.
7010
7011 * window.c (Fwindow_end, window_scroll_pixel_based)
7012 (displayed_window_lines, Frecenter): Save and restore the bidi
7013 cache around display iteration.
7014
3bbd2265
LMI
70152011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7016
7017 * editfns.c (Fdelete_region): Clarify the use of the named
7018 parameters (bug#6788).
7019
adc47434
MR
70202011-07-14 Martin Rudalics <rudalics@gmx.at>
7021
7022 * indent.c (Fvertical_motion): Set and restore w->pointm when
7023 saving and restoring the window's buffer (Bug#9006).
7024
837c31f8
LMI
70252011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7026
7027 * editfns.c (Fstring_to_char): Clarify just what is returned
7028 (bug#6576). Text by Eli Zaretskii.
7029
ac389d0c
JB
70302011-07-13 Juanma Barranquero <lekktu@gmail.com>
7031
7032 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7033
0be0ce47
EZ
70342011-07-13 Eli Zaretskii <eliz@gnu.org>
7035
7036 * buffer.c (mmap_find): Fix a typo.
7037
cd18e7e3
JB
70382011-07-13 Johan Bockgård <bojohan@gnu.org>
7039
7040 Fix execution of x selection hooks.
7041 * xselect.c (Qx_lost_selection_functions)
7042 (Qx_sent_selection_functions): New vars.
7043 (syms_of_xselect): DEFSYM them.
7044 (x_handle_selection_request): Pass Qx_sent_selection_functions
7045 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7046 (x_handle_selection_clear,x_clear_frame_selections):
7047 Pass Qx_lost_selection_functions rather than
7048 Vx_lost_selection_functions to Frun_hook_with_args.
7049
47ea7f44
PE
70502011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7051
ac389d0c 7052 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7053 The old code sometimes used this field without initializing it.
7054
47ea7f44
PE
7055 * alloc.c (gc_sweep): Don't read past end of array.
7056 In theory, the old code could also have corrupted Emacs internals,
7057 though it'd be very unlikely.
7058
bc985c87
AS
70592011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7060
7061 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7062 argument. (Bug#4026)
bc985c87 7063
0cf34688
LMI
70642011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7065
b3dadd76
LMI
7066 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7067 key" (bug#4257).
7068
0cf34688
LMI
7069 * window.c (Fset_window_start): Doc fix (bug#4199).
7070 (Fset_window_hscroll): Ditto.
7071
270768cd
PE
70722011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7073
077e3dda 7074 Fix minor new problems caught by GCC 4.6.1.
270768cd 7075 * term.c (init_tty): Remove unused local.
490011a6 7076 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7077 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7078 not used otherwise.
270768cd 7079
b1f58454
CY
70802011-07-12 Chong Yidong <cyd@stupidchicken.com>
7081
7082 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7083
22b9578d
LMI
70842011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7085
6e70ab07
LMI
7086 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7087 are the mini-buffer and the echo area (bug#3320).
7088
22b9578d
LMI
7089 * term.c (init_tty): Remove support for supdup, c10 and perq
7090 terminals, which are no longer supported (bug#1482).
7091
8974cc9f
JB
70922011-07-10 Johan Bockgård <bojohan@gnu.org>
7093
7094 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7095
a560d974
JD
70962011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7097
7098 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7099 for non-popups (Bug#3642).
7100
1dae0f0a
AS
71012011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7102
268c2c36 7103 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7104 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7105 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7106 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7107 * data.c (fmod): Likewise.
7108 * dispnew.c (swap_glyphs_in_rows): Likewise.
7109 * emacs.c (memory_warning_signal): Likewise.
7110 * floatfns.c (float_error): Likewise.
7111 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7112 (otf_open, font_otf_capability, generate_otf_features)
7113 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7114 Likewise.
7115 * image.c (pbm_read_file): Likewise.
7116 * indent.c (string_display_width): Likewise.
7117 * intervals.c (check_for_interval, search_for_interval)
7118 (inc_interval_count, count_intervals, root_interval)
7119 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7120 * lread.c (defalias): Likewise.
268c2c36 7121 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7122 * regex.c (set_image_of_range_1, set_image_of_range)
7123 (regex_grow_registers): Likewise.
7124 * sysdep.c (strerror): Likewise.
7125 * termcap.c (valid_filename_p, tprint, main): Likewise.
7126 * tparam.c (main): Likewise.
7127 * unexhp9k800.c (run_time_remap, save_data_space)
7128 (update_file_ptrs, read_header, write_header, calculate_checksum)
7129 (copy_file, copy_rest, display_header): Likewise.
7130 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7131 Likewise.
7132 * xdisp.c (check_it): Likewise.
7133 * xfaces.c (register_color, unregister_color, unregister_colors):
7134 Likewise.
7135 * xfns.c (print_fontset_result): Likewise.
7136 * xrdb.c (member, fatal, main): Likewise.
7137
99033785
PE
71382011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7139
7140 Fix minor problems found by static checking (Bug#9031).
7141 * chartab.c (char_table_set_range, map_sub_char_table):
7142 Remove unused locals.
7143 (uniprop_table): Now static.
7144 * composite.c (_work_char): Remove unused static var.
7145
9cb2ac56
JB
71462011-07-09 Juanma Barranquero <lekktu@gmail.com>
7147
7148 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7149
f25661f0
JD
71502011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7151
7152 * gtkutil.c (qttip_cb): Remove code without function.
7153
8278c4fe
EZ
71542011-07-09 Eli Zaretskii <eliz@gnu.org>
7155
7156 * w32.c (pthread_sigmask): New stub.
7157
1692ae2d 71582011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7159
8a6ebd58 7160 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7161 sigprocmask is portable only for single-threaded applications, and
7162 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7163 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7164 (LIBES): Use it.
7165 * callproc.c (Fcall_process):
7166 * process.c (create_process):
7167 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7168 Use pthread_sigmask, not sigprocmask.
123403e4 7169
1b854618
JD
71702011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7171
7172 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7173 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7174 wrong (Bug#8591).
7175
3fe4b549
JD
71762011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7177
0ce7e563
JD
7178 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7179 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7180 (xg_hide_tooltip): Fix comment.
7181
3fe4b549
JD
7182 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7183 in registerServicesMenuSendTypes.
7184 (validRequestorForSendType): Don't check ns_return_types.
7185
7186 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7187 ns_return_type.
7188
5df75e47
JR
71892011-07-08 Jason Rumney <jasonr@gnu.org>
7190
22610910
JR
7191 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7192 SH_SHOW for hidden windows (Bug#5482).
7193
5df75e47
JR
7194 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7195 frame struct members of non-existent frames (Bug#6284).
7196
699c10bd
JD
71972011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7198
4393663b
JD
7199 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7200 variable firstTime not needed on OSX >= 10.6.
7201 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7202 >= 10.5. Use setKnobProportion, setDoubleValue.
7203
7204 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7205 (MAC_OS_X_VERSION_10_5): Define if not defined.
7206 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7207 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7208 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7209
7210 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7211 cString and lossyCString on OSX >= 10.4
7212
58179cce 7213 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7214 sizeToFit on OSX >= 10.2.
7215
7216 * nsimage.m (allocInitFromFile): Don't use deprecated method
7217 bestRepresentationForDevice on OSX >= 10.6.
7218
7219 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7220 to avoid warning.
7221
7222 * emacs.c: Declare unexec_init_emacs_zone.
7223
a63e0781
JD
7224 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7225
699c10bd
JD
7226 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7227
7228 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7229 on svcsMenu (Bug#8842).
7230
7231 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7232 ns_return_types.
7233 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7234
7235 * nsterm.m (QUTF8_STRING): Declare.
7236 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7237 (validRequestorForSendType): Return type is (id).
7238 Change indexOfObjectIdenticalTo to indexOfObject.
7239 Check if we have local selection before returning self (Bug#8842).
7240 (writeSelectionToPasteboard): Put local selection into paste board
7241 if we have a local selection (Bug#8842).
7242 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7243
7244 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7245 (ns_get_local_selection): Declare.
7246
54e10184
LMI
72472011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7248
9888ff71
LMI
7249 * keymap.c (describe_map_tree): Don't insert a double newline at
7250 the end of the buffer (bug#1169) and return whether we inserted
7251 something.
7252
54e10184
LMI
7253 * callint.c (Fcall_interactively): Change "reading args" to
7254 "providing args" to try to clarify what it does (bug#1010).
7255
15fa4783
KH
72562011-07-07 Kenichi Handa <handa@m17n.org>
7257
7258 * composite.c (composition_compute_stop_pos): Ignore a static
7259 composition starting before CHARPOS (Bug#8915).
7260
7261 * xdisp.c (handle_composition_prop): Likewise.
7262
a8815b00
EZ
72632011-07-07 Eli Zaretskii <eliz@gnu.org>
7264
7265 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7266 (Bug#9015)
7267
ef7b981d 72682011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
7269
7270 * character.h (unicode_category_t): New enum type.
7271
7272 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7273 (Qchar_code_property_table): New variable.
7274 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7275 (UNIPROP_COMPRESSED_FORM_P): New macros.
7276 (char_table_ascii): Uncompress the compressed values.
7277 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7278 Uncompress the compressed values.
ac389d0c 7279 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
7280 (char_table_ref_and_range): Uncompress the compressed values.
7281 (sub_char_table_set): New arg is_uniprop. Callers changed.
7282 Uncompress the compressed values.
7283 (sub_char_table_set_range): Args changed. Callers changed.
7284 (char_table_set_range): Adjuted for the above change.
7285 (map_sub_char_table): Delete args default_val and parent. Add arg
7286 top. Give decoded values to a Lisp function.
640c8776 7287 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
7288 values to a Lisp function. Gcpro more variables.
7289 (uniprop_table_uncompress)
7290 (uniprop_decode_value_run_length): New functions.
7291 (uniprop_decoder, uniprop_decoder_count): New variables.
7292 (uniprop_get_decoder, uniprop_encode_value_character)
7293 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7294 New functions.
7295 (uniprop_encoder, uniprop_encoder_count): New variables.
7296 (uniprop_get_encoder, uniprop_table)
7297 (Funicode_property_table_internal, Fget_unicode_property_internal)
7298 (Fput_unicode_property_internal): New functions.
7299 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7300 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 7301 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
7302 char-code-property-alist.
7303
640c8776 7304 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
7305 Vunicode_category_table.
7306
640c8776 7307 * font.c (font_range): Adjust for the change of
c805dec0
KH
7308 Vunicode_category_table.
7309
76b397fb
DN
73102011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7311
7312 * m/iris4d.h: Remove file, move contents ...
7313 * s/irix6-5.h: ... here.
7314
22b4128e
PE
73152011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7316
7317 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
7318 * alloc.c (mark_buffer):
7319 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7320 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7321 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7322 This isn't true in general, and it's particularly not true
7323 if Emacs is configured with --with-wide-int.
7324 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7325 New macros, used in the buffer.c change.
7326
869795d6
JD
73272011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7328
7329 * xsettings.c: Use both GConf and GSettings if both are available.
7330 (store_config_changed_event): Add comment.
7331 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7332 (store_tool_bar_style_changed): New functions.
5e617bc2 7333 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7334 (struct xsettings): Move font inside HAVE_XFT.
7335 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7336 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7337 Move inside HAVE_XFT.
640c8776 7338 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7339 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7340 also.
7341 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7342 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7343 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7344 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7345 (parse_settings): Move check for font inside HAVE_XFT.
7346 (read_settings, apply_xft_settings): Add comment.
7347 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7348 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7349 call store_font_name_changed.
7350 (xft_settings_event): Add comment.
7351 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7352 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7353 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7354 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7355 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7356 (xsettings_get_system_font, xsettings_get_system_normal_font):
7357 Add comment.
869795d6 7358
d8ed26bd
PE
73592011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7360
7361 Random fixes. E.g., (random) never returned negative values.
7362 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7363 subseconds part to the entropy, as that's a bit more random.
7364 Prefer signed to unsigned, since the signedness doesn't matter and
7365 in general we prefer signed. When given a limit, use a
7366 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7367 latter isn't right if USE_2_TAGS_FOR_INTS.
7368 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7369 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7370
cabf1cac
SM
73712011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7372
7373 * textprop.c (text_property_stickiness):
7374 Obey Vtext_property_default_nonsticky.
7375 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7376 * w32fns.c (syms_of_w32fns):
7377 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7378
6e9b2be9
PE
73792011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7380
7381 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7382 This is more efficient than Ffile_directory_p and avoids a minor race.
7383
90186c68
LMI
73842011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7385
7c301272
LMI
7386 * buffer.c (Foverlay_put): Say what the return value is
7387 (bug#7835).
7388
c4f2d8d4
LMI
7389 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7390 is a directory before asking whether to use the file name
7391 (bug#7564).
ad637907
LMI
7392 (barf_or_query_if_file_exists): Make the "File is a directory"
7393 error be more correct.
c4f2d8d4 7394
90186c68
LMI
7395 * fns.c (Frequire): Remove the mention of the .gz files, since
7396 that's installation-specific, but keep the mention of
7397 `get-load-suffixes'.
7398
da64016e
PE
73992011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7400
7401 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7402 Report string overflow if the output is too long.
7403
7d47b580
JB
74042011-07-04 Juanma Barranquero <lekktu@gmail.com>
7405
a555cb87
JB
7406 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7407 (syms_of_gnutls): Remove duplicate DEFSYM for
7408 Qgnutls_bootprop_verify_hostname_error, an error for
7409 Qgnutls_bootprop_verify_error (which is no longer used).
7410
7d47b580
JB
7411 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7412 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7413 Also (re)move comments that are misplaced or no longer relevant.
7414
1e49bfab
LMI
74152011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7416
7417 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7418
1485f4c0
CY
74192011-07-03 Chong Yidong <cyd@stupidchicken.com>
7420
7421 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7422 and background color parameters if they have been changed.
7423
a9ab721e
LMI
74242011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7425
7426 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7427
cf7cff57
PE
74282011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7429
2e13213d
PE
7430 * xsettings.c (SYSTEM_FONT): Define only when used.
7431 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7432
cf7cff57
PE
7433 * keymap.c (access_keymap_1): Now static.
7434
7a8e04f7
CY
74352011-07-02 Chong Yidong <cyd@stupidchicken.com>
7436
7437 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7438 leave any prefix arg for the up event (Bug#1586).
7439
61352f62
LMI
74402011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7441
69bb1ef7
LMI
7442 * lread.c (syms_of_lread): Mention single symbols defined by
7443 `defvar' or `defconst' (bug#7154).
7444
61352f62 7445 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7446 (Frequire): Mention get-load-suffixes.
61352f62 7447
28545e04
MR
74482011-07-02 Martin Rudalics <rudalics@gmx.at>
7449
7450 * window.h (window): Remove clone_number slot.
7451 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7452 Remove.
7453 (make_parent_window, make_window, saved_window)
7454 (Fset_window_configuration, save_window_save): Don't deal with
7455 clone numbers.
7456 * buffer.c (Qclone_number): Remove declaration.
7457 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7458
3349e122
SM
74592011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7460
7461 Add multiple inheritance to keymaps.
7462 * keymap.c (Fmake_composed_keymap): New function.
7463 (Fset_keymap_parent): Simplify.
7464 (fix_submap_inheritance): Remove.
7465 (access_keymap_1): New function extracted from access_keymap to handle
7466 embedded parents and handle lists of maps.
7467 (access_keymap): Use it.
7468 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7469 (Fcopy_keymap): Handle embedded parents.
7470 (Fcommand_remapping, define_as_prefix): Simplify.
7471 (Fkey_binding): Simplify.
7472 (syms_of_keymap): Move minibuffer-local-completion-map,
7473 minibuffer-local-filename-completion-map,
7474 minibuffer-local-must-match-map, and
7475 minibuffer-local-filename-must-match-map to Elisp.
7476 (syms_of_keymap): Defsubr make-composed-keymap.
7477 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7478 (parse_menu_item): Trivial simplification.
7479
3279eb87
GM
74802011-07-01 Glenn Morris <rgm@gnu.org>
7481
7482 * Makefile.in (SETTINGS_LIBS): Fix typo.
7483
4550efdf
KI
74842011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7485
7486 * coding.c (Fencode_coding_string): Record the last coding system
7487 used, as the function doc string says (bug#8738).
7488
0949d2b6
JD
74892011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7490
7491 * xsettings.c (store_monospaced_changed): Take new font as arg and
7492 check for change against current_mono_font.
7493 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7494 (emacs_settings_constructor, emacs_settings_get_property)
7495 (emacs_settings_set_property, emacs_settings_class_init)
7496 (emacs_settings_init, gsettings_obj): Remove.
7497 (something_changedCB): New function for HAVE_GSETTINGS.
7498 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7499 with value as argument.
7500 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7501 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7502 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7503 "changed".
7504
7505 * xgselect.c: Add defined (HAVE_GSETTINGS).
7506 (xgselect_initialize): Ditto.
7507
7508 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7509 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7510 xg_select.
7511
bbc6b304
PE
75122011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7513
7514 * eval.c (struct backtrace): Simplify and port the data structure.
7515 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7516 signed bit field, as this assumption is not portable and it makes
7517 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7518 "char debug_on_exit : 1" as this is not portable either; instead,
7519 use the portable "unsigned int debug_on_exit : 1". Remove unused
7520 member evalargs. Remove obsolete comments about cc bombing out.
7521
9851bfc5
JD
75222011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7523
51bb811f 7524 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7525 Let HAVE_GSETTINGS override HAVE_GCONF.
7526 (store_monospaced_changed): New function.
7527 (EMACS_SETTINGS): A new type derived from GObject to handle
7528 GSettings notifications.
7529 (emacs_settings_constructor, emacs_settings_get_property)
7530 (emacs_settings_set_property, emacs_settings_class_init):
7531 New functions.
7532 (gsettings_client, gsettings_obj): New variables.
7533 (GSETTINGS_SCHEMA): New define.
7534 (something_changedCB): Call store_monospaced_changed.
7535 (init_gsettings): New function.
7536 (xsettings_initialize): Call init_gsettings.
7537 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7538 to NULL.
7539
640c8776 7540 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7541 GCONF_CFLAGS/LIBS.
7542
5386012d
MR
75432011-06-29 Martin Rudalics <rudalics@gmx.at>
7544
7545 * window.c (resize_root_window, grow_mini_window)
7546 (shrink_mini_window): Rename Qresize_root_window to
7547 Qwindow_resize_root_window and Qresize_root_window_vertically to
7548 Qwindow_resize_root_window_vertically.
7549
f13e0b08
PE
75502011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7551
7552 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7553
94515237
JB
75542011-06-27 Juanma Barranquero <lekktu@gmail.com>
7555
7556 * makefile.w32-in: Redesign dependencies so they reflect more
7557 clearly which files are directly included by each source file,
7558 and not through other includes.
7559
e43b6e43
MR
75602011-06-27 Martin Rudalics <rudalics@gmx.at>
7561
7562 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7563 (sort_overlays, overlay_strings): When an overlay's clone number
7564 matches the window's clone number process the overlay even if
7565 the overlay's window property doesn't match the current window.
7566
d68443dc
MR
7567 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7568 (Fwindow_hchild): Rename to Fwindow_left_child.
7569 (Fwindow_next): Rename to Fwindow_next_sibling.
7570 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7571 (resize_window_check): Rename to window_resize_check.
7572 (resize_window_apply): Rename to window_resize_apply.
7573 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7574 (Fdelete_other_windows_internal, resize_frame_windows)
7575 (Fsplit_window_internal, Fdelete_window_internal)
7576 (grow_mini_window, shrink_mini_window)
7577 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7578
c7e73be5
JD
75792011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7580
7581 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7582 (emacs_fixed_set_min_size): Remove.
7583 (emacs_fixed_new): Take frame as argument.
7584
7585 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7586 (_EmacsFixedPrivate): Remove minwidth/height.
7587 Add struct frame *f.
7588 (emacs_fixed_init): Initialize priv->f.
7589 (get_parent_class, emacs_fixed_set_min_size): Remove.
7590 (emacs_fixed_new): Set priv->f to argument.
7591 (emacs_fixed_get_preferred_width)
7592 (emacs_fixed_get_preferred_height): Use min_width/height from
7593 frames size_hint to set minimum and natural (Bug#8919).
7594 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7595 and use min_width/height from frames size_hint to set
7596 min_width/height (Bug#8919).
7597
7598 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
7599 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7600 Fix indentation.
c7e73be5 7601
cf99dcf8
EZ
76022011-06-26 Eli Zaretskii <eliz@gnu.org>
7603
7604 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7605 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7606 called at ZV.
7607
029529ac
CY
76082011-06-26 Chong Yidong <cyd@stupidchicken.com>
7609
7610 * process.c (wait_reading_process_output): Bypass select if
7611 waiting for a cell while ignoring keyboard input, and input is
7612 pending. Suggested by Jan Djärv (Bug#8869).
7613
7a7ef429
PE
76142011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7615
7616 Use gnulib's dup2 module instead of rolling our own.
7617 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7618
11fdef7d 76192011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7620
7621 * dispnew.c (scrolling_window): Before scrolling, turn off a
7622 mouse-highlight in the window being scrolled.
7623
cd3520a4
JB
76242011-06-24 Juanma Barranquero <lekktu@gmail.com>
7625
7626 Move DEFSYM to lisp.h and use everywhere.
7627
7628 * character.h (DEFSYM): Move declaration...
7629 * lisp.h (DEFSYM): ...here.
7630
7631 * gnutls.c:
7632 * minibuf.c:
7633 * w32menu.c:
7634 * w32proc.c:
7635 * w32select.c: Don't include character.h.
7636
7637 * alloc.c (syms_of_alloc):
7638 * buffer.c (syms_of_buffer):
7639 * bytecode.c (syms_of_bytecode):
7640 * callint.c (syms_of_callint):
7641 * casefiddle.c (syms_of_casefiddle):
7642 * casetab.c (init_casetab_once):
7643 * category.c (init_category_once, syms_of_category):
7644 * ccl.c (syms_of_ccl):
7645 * cmds.c (syms_of_cmds):
7646 * composite.c (syms_of_composite):
7647 * dbusbind.c (syms_of_dbusbind):
7648 * dired.c (syms_of_dired):
7649 * dispnew.c (syms_of_display):
7650 * doc.c (syms_of_doc):
7651 * editfns.c (syms_of_editfns):
7652 * emacs.c (syms_of_emacs):
7653 * eval.c (syms_of_eval):
7654 * fileio.c (syms_of_fileio):
7655 * fns.c (syms_of_fns):
7656 * frame.c (syms_of_frame):
7657 * fringe.c (syms_of_fringe):
7658 * insdel.c (syms_of_insdel):
7659 * keymap.c (syms_of_keymap):
7660 * lread.c (init_obarray, syms_of_lread):
7661 * macros.c (syms_of_macros):
7662 * msdos.c (syms_of_msdos):
7663 * print.c (syms_of_print):
7664 * process.c (syms_of_process):
7665 * search.c (syms_of_search):
7666 * sound.c (syms_of_sound):
7667 * syntax.c (init_syntax_once, syms_of_syntax):
7668 * terminal.c (syms_of_terminal):
7669 * textprop.c (syms_of_textprop):
7670 * undo.c (syms_of_undo):
7671 * w32.c (globals_of_w32):
7672 * window.c (syms_of_window):
7673 * xdisp.c (syms_of_xdisp):
7674 * xfaces.c (syms_of_xfaces):
7675 * xfns.c (syms_of_xfns):
7676 * xmenu.c (syms_of_xmenu):
7677 * xsettings.c (syms_of_xsettings):
7678 * xterm.c (syms_of_xterm): Use DEFSYM.
7679
4228cf16
TZ
76802011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7681
cd3520a4 7682 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7683
7fcccf1e
PE
76842011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7685
7efb4e0e
PE
7686 Integer and buffer overflow fixes (Bug#8873).
7687
ff5844ad
PE
7688 * print.c (printchar, strout): Check for string overflow.
7689 (PRINTPREPARE, printchar, strout):
7690 Don't set size unless allocation succeeds.
7691
90532f02
PE
7692 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7693 for sizes. Check for string overflow more accurately.
7694 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7695
6d84508d
PE
7696 * macros.c: Integer and buffer overflow fixes.
7697 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7698 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7699 Use ptrdiff_t, not int, for sizes.
7700 Don't increment bufsize until after realloc succeeds.
7701 Check for size-calculation overflow.
7702 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7703
437b2cb4
PE
7704 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7705
8b9ac8b4
PE
7706 * lread.c: Integer overflow fixes.
7707 (read_integer): Radix is now EMACS_INT, not int,
7708 to improve quality of diagnostics for out-of-range radices.
7709 Calculate buffer size correctly for out-of-range radices.
7710 (read1): Check for integer overflow in radices, and in
7711 read-circle numbers.
82cb60d3
PE
7712 (read_escape): Avoid int overflow.
7713 (Fload, openp, read_buffer_size, read1)
7714 (substitute_object_recurse, read_vector, read_list, map_obarray):
7715 Use ptrdiff_t, not int, for sizes.
7716 (read1): Use EMACS_INT, not int, for sizes.
20270765 7717 Check for size overflow.
8b9ac8b4 7718
7fcccf1e
PE
7719 * image.c (cache_image): Check for size arithmetic overflow.
7720
bfbbd7e7
PE
7721 * lread.c: Integer overflow issues.
7722 (saved_doc_string_size, saved_doc_string_length)
7723 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7724 Now ptrdiff_t, not int.
7725 (read1): Don't assume doc string length fits in int. Check for
7726 out-of-range doc string lengths.
7727 (read_list): Don't assume file position fits in int.
39019e54 7728 (read_escape): Check for hex character overflow.
bfbbd7e7 7729
4e323265
LL
77302011-06-22 Leo Liu <sdl.web@gmail.com>
7731
7732 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7733 Move to minibuffer.el.
7734
85fece3e
PE
77352011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7736
20b84ce9 7737 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7738 The following patches are for when GLYPH_DEBUG && !XASSERT.
7739 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7740 * dispnew.c (flush_stdout):
7741 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7742 Mark as externally visible.
7743 * dispnew.c (check_window_matrix_pointers): Now static.
7744 * dispnew.c (window_to_frame_vpos):
7745 * xfns.c (unwind_create_frame):
7746 * xterm.c (x_check_font): Remove unused local.
7747 * scroll.c (CHECK_BOUNDS):
7748 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7749 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7750 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7751 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7752 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7753 Now static.
7754 (debug_method_add): Use va_list and vsprintf rather than relying
7755 on undefined behavior with wrong number of arguments.
7756 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7757 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7758 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7759 since we're not interested in debugging glyphs with old libraries.
7760 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7761 GCC 4.6.0's static checking.
7762
0766b489
PE
77632011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7764
31fd4b32
PE
7765 Integer overflow and signedness fixes (Bug#8873).
7766 A few related buffer overrun fixes, too.
7767
b79e8648
PE
7768 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7769
0766b489
PE
7770 * dispextern.h (struct face.stipple):
7771 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7772 (x_bitmap_mask, x_allocate_bitmap_record)
7773 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7774 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7775 (x_create_bitmap_from_xpm_data):
7776 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7777 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7778 (.bitmaps_last):
7779 * xfaces.c (load_pixmap):
7780 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7781 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7782 (.bitmaps_last, struct x_output.icon_bitmap):
7783 Use ptrdiff_t, not int, for bitmap indexes.
7784 (x_allocate_bitmap_record): Check for size overflow.
7785 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7786
b081724f
PE
7787 Use ptrdiff_t, not int, for overlay counts.
7788 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7789 * editfns.c (overlays_around, get_pos_property):
7790 * textprop.c (get_char_property_and_overlay):
7791 * xdisp.c (next_overlay_change, note_mouse_highlight):
7792 * xfaces.c (face_at_buffer_position):
21514da7
PE
7793 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7794 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7795 (Fnext_overlay_change, Fprevious_overlay_change)
7796 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7797 Use ptrdiff_t, not int, for sizes.
21514da7 7798 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7799
3de73e5e
PE
7800 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7801
2606c57b
PE
7802 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7803 (x_session_initialize): Do not assume string length fits in int.
7804
aaafe47a
PE
7805 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7806 This is unlikely, but can occur if DPI is outlandish.
7807
2674ddc8 7808 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7809 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7810
28154962
PE
7811 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7812 * xrdb.c (magic_file_p, search_magic_path):
7813 Omit last arg SUFFIX; it was always 0. All callers changed.
7814 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7815
7de51af5
PE
7816 * xfont.c (xfont_match): Avoid need for strlen.
7817
25ed6cc3
PE
7818 * xfns.c: Don't assume strlen fits in int.
7819 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7820
4eab31dd
PE
7821 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7822 not unsigned long, as we prefer signed integers. All callers changed.
7823 Detect integer overflow in repeat count.
7824 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7825 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7826
171e2a58
PE
7827 * termcap.c: Don't assume sizes fit in int and never overflow.
7828 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7829 (gobble_line): Check for size-calculation overflow.
7830
ad39faca 7831 * minibuf.c (Fread_buffer):
6e5bb2dc 7832 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7833 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7834 Don't assume string length fits in int.
7835
52c61c22 7836 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7837 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7838
b5b8c9e5
PE
7839 * font.c: Don't assume string length fits in int.
7840 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7841 Use ptrdiff_t, not int.
ccd6111c
PE
7842 (font_intern_prop): Don't assume string length fits in int.
7843 Don't assume integer property fits in fixnum.
7844 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7845
882f0d81 7846 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7847 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7848 Reformulate so as not to need the command string.
7849 Invoke gzip -cd rather than gunzip, as it's more portable.
7850 (lock_info_type, lock_file_1, lock_file):
7851 Don't assume pid_t and time_t fit in unsigned long.
7852 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7853 (current_lock_owner): Prefer signed type for sizes.
7854 Use memcpy, not strncpy, where memcpy is what is really wanted.
7855 Don't assume (via atoi) that time_t and pid_t fit in int.
7856 Check for time_t and/or pid_t out of range, e.g., via a network share.
7857 Don't alloca where an auto var works fine.
7858
93f4cf88
PE
7859 * fileio.c: Fix some integer overflow issues.
7860 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7861 Don't assume string length fits in int.
7862 (directory_file_name): Don't assume string length fits in long.
7863 (make_temp_name): Don't assume pid fits in int, or that its print
7864 length is less than 20.
7865
f3e92b69
PE
7866 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7867
1bfdaf10
PE
7868 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7869
35016e9a
PE
7870 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7871
3d1e65a1
PE
7872 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7873 We prefer signed integers, even for size calculations.
7874
0b963a93
PE
7875 * emacs.c: Don't assume string length fits in 'int'.
7876 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7877 (main): Don't invoke strlen when not needed.
7878
573f4b54
PE
7879 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7880 (XD_DEBUG_MESSAGE): Don't waste a byte.
7881
989f33ba
PE
7882 * callproc.c (getenv_internal_1, getenv_internal)
7883 (Fgetenv_internal):
965d34eb
PE
7884 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7885
e4d29b33
PE
7886 * lread.c (invalid_syntax): Omit length argument.
7887 All uses changed. This doesn't fix a bug, but it simplifies the
7888 code away from its former Hollerith-constant appearance, and it's
7889 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7890 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7891
eb49b136
PE
7892 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7893 This didn't break anything, but it didn't help either.
7894 It's confusing to put a bogus integer in a place where the actual
7895 value does not matter.
9f62aeb1 7896 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7897 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7898
15375a22
PE
7899 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7900 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7901 implementation.
b61cc01c
PE
7902 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7903 We prefer signed types, and the value cannot exceed the EMACS_INT
7904 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
7905 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7906 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7907 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 7908
53b2623d
PE
7909 * indent.c (sane_tab_width): New function.
7910 (current_column, scan_for_column, Findent_to, position_indentation)
7911 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7912 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7913
51cab52b 7914 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7915
f2ed8a70
PE
7916 * lisp.h (lint_assume): New macro.
7917 * composite.c (composition_gstring_put_cache):
7918 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7919
abe80cc6
PE
7920 * editfns.c, insdel.c:
7921 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 7922
b02c740e
PE
7923 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7924
ebc96716
PE
7925 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7926
b4e50fa0 7927 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 7928 Use much-faster test for byte-length change.
311d5d7c 7929 Don't assume string byte-length fits in 'int'.
a4cf38e4 7930 Check that character arg fits in 'int'.
85461888 7931 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 7932
c0c1ee9f
PE
7933 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7934
a498d7f4
PE
7935 * fns.c (concat): Catch string overflow earlier.
7936 Do not rely on integer wraparound.
7937
51cab52b
PE
7938 * dispextern.h (struct it.overlay_strings_charpos)
7939 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
7940 * xdisp.c (forward_to_next_line_start)
7941 (back_to_previous_visible_line_start)
7942 (reseat_at_next_visible_line_start, next_element_from_buffer):
7943 Don't arbitrarily truncate the value of 'selective' to int.
7944
76031fad
PE
7945 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7946
5eb55db9
PE
7947 * composite.c: Don't truncate sizes to 'int'.
7948 (composition_gstring_p, composition_reseat_it)
7949 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7950 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7951 not EMACS_UINT, for indexes.
5eb55db9 7952
0703a717
PE
7953 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7954
d6202519
PE
7955 * buffer.c: Include <verify.h>.
7956 (struct sortvec.priority, struct sortstr.priority):
8961a454 7957 Now EMACS_INT, not int.
c20998a7 7958 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7959 (struct sortstr.size, record_overlay_string)
7960 (struct sortstrlist.size, struct sortlist.used):
7961 Don't truncate size to int.
7962 (record_overlay_string): Check for size-calculation overflow.
d6202519 7963 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7964
d5a19415
JM
79652011-06-22 Jim Meyering <meyering@redhat.com>
7966
029529ac 7967 Don't leak an XBM-image-sized buffer
d5a19415
JM
7968 * image.c (xbm_load): Free the image buffer after using it.
7969
a9041e6c
PE
79702011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7971
7972 Port to Sun C.
7973 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7974 that Sun C diagnosed.
7975 * fns.c (secure_hash): Fix pointer signedness issue.
7976 * intervals.c (static_offset_intervals): New function.
7977 (offset_intervals): Use it.
7978
7f3f739f
LL
79792011-06-21 Leo Liu <sdl.web@gmail.com>
7980
7981 * deps.mk (fns.o):
7982 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7983 sha512.h.
7984
7985 * fns.c (secure_hash): Rename from crypto_hash_function and change
7986 the first arg to accept symbols.
5b66d427 7987 (Fsecure_hash): New primitive.
7f3f739f
LL
7988 (syms_of_fns): New symbols.
7989
76147d94
DD
79902011-06-20 Deniz Dogan <deniz@dogan.se>
7991
7992 * process.c (Fset_process_buffer): Clarify return value in
7993 docstring.
7994
7d7d0045
CY
79952011-06-18 Chong Yidong <cyd@stupidchicken.com>
7996
7997 * dispnew.c (add_window_display_history): Use BVAR.
7998
7999 * xdisp.c (debug_method_add): Use BVAR.
8000 (check_window_end, dump_glyph_matrix, dump_glyph)
8001 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8002
8003 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8004 Likewise.
8005
8006 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8007 check till after the cache is created in init_frame_faces.
8008
ff2bc410
SM
80092011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8010
8011 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8012
28177add
PE
80132011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8014
dd3482fe
PE
8015 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8016 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8017 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8018
393d71f3 8019 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8020 * fileio.c (Finsert_file_contents):
8021 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8022 Remove the old (too-loose) buffer overflow checks.
8023 They weren't needed, since make_gap checks for buffer overflow.
8024 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8025 The old code merely checked for Emacs fixnum overflow, and relied
8026 on undefined (wraparound) behavior. The new code avoids undefined
8027 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8028
2e6813b0 8029 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8030 Tune. Don't use wider integers than needed. Don't use alloca.
8031 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8032
599a9e4f
PE
8033 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8034
99561444
PE
8035 * insdel.c, lisp.h (buffer_overflow): New function.
8036 (insert_from_buffer_1, replace_range, replace_range_2):
8037 * insdel.c (make_gap_larger):
8038 * editfns.c (Finsert_char):
8039 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8040
28177add
PE
8041 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8042
e69dafad
PE
80432011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8044
4baa020d 8045 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8046
b1c46f02
PE
8047 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8048 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8049
e69dafad
PE
8050 * fileio.c: Don't assume EMACS_INT fits in off_t.
8051 (emacs_lseek): New static function.
8052 (Finsert_file_contents, Fwrite_region): Use it.
8053 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8054
566684ea
PE
8055 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8056
e6966cd6
PE
8057 * fns.c: Don't overflow int when computing a list length.
8058 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8059 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8060 truncation on 64-bit hosts. Check for QUIT every
8061 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8062 faster and is responsive enough.
8063 (Flength): Report an error instead of overflowing an integer.
8064 (Fsafe_length): Return a float if the value is not representable
8065 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8066 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8067 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8068
dd0b0efb
PE
8069 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8070 (header_size, word_size): New constants.
8071 (allocate_vectorlike): Don't check size overflow here.
8072 (allocate_vector): Check it here instead, since this is the only
8073 caller of allocate_vectorlike that could cause overflow.
8074 Check that the new vector's length is representable as a fixnum.
8075
86fe5cfe
PE
8076 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8077 The previous code was bogus. For example, next_almost_prime (32)
8078 returned 39, which is undesirable as it is a multiple of 3; and
8079 next_almost_prime (24) returned 25, which is a multiple of 5 so
8080 why was the code bothering to check for multiples of 7?
8081
80e88859
PE
8082 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8083
4a2f0ad6
PE
8084 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8085
f66c7cf8
PE
8086 Variadic C functions now count arguments with ptrdiff_t.
8087 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8088 Back then I didn't know that the Emacs coding style prefers signed int.
8089 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8090 were being counted with int, which may truncate counts on 64-bit
8091 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8092 * lisp.h (struct Lisp_Subr.function.aMANY)
8093 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8094 Arg counts are now ptrdiff_t, not size_t.
8095 All variadic functions and their callers changed accordingly.
8096 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8097 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8098 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8099 * callint.c (Fcall_interactively): Check arg count for overflow,
8100 to avoid potential buffer overrun. Use signed char, not 'int',
8101 for 'varies' array, so that we needn't bother to check its size
8102 calculation for overflow.
8103 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8104 * eval.c (apply_lambda):
8105 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8106 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8107 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8108
a1759b76
PE
8109 * callint.c (Fcall_interactively): Don't use index var as event count.
8110
d96be9fc
PE
8111 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8112 * mem-limits.h (SIZE): Remove; no longer used.
8113
a690a978 8114 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8115
578c21e6
PE
8116 Remove unnecessary casts.
8117 * xterm.c (x_term_init):
8118 * xfns.c (x_set_border_pixel):
8119 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8120 These aren't needed now that we assume ANSI C.
8121
96f53c6c
PE
8122 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8123 It's more likely to cause problems (due to unsigned overflow)
8124 than to cure them.
8125
83c77d31
PE
8126 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8127
ee2079f1
PE
8128 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8129
6da65536
PE
8130 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8131
7147c4a4
PE
8132 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8133
193e32d9
PE
8134 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8135
e5533da6
PE
8136 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8137
9910e595
PE
8138 GLYPH_CODE_FACE returns EMACS_INT, not int.
8139 * dispextern.h (merge_faces):
8140 * xfaces.c (merge_faces):
01103c44
PE
8141 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8142 Don't assume EMACS_INT fits in int.
9910e595 8143
2638320e
PE
8144 * character.h (CHAR_VALID_P): Remove unused parameter.
8145 * fontset.c, lisp.h, xdisp.c: All uses changed.
8146
045eb8d9
PE
8147 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8148
c1f134b5
PE
8149 * fns.c (concat): Minor tuning based on overflow analysis.
8150 This doesn't fix any bugs. Use int to hold character, instead
8151 of constantly refetching from Emacs object. Use XFASTINT, not
8152 XINT, for value known to be a character. Don't bother comparing
8153 a single byte to 0400, as it's always less.
8154
395fcb93 8155 * floatfns.c (Fexpt):
327eeec8
PE
8156 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8157
abbd3d23
PE
8158 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8159 for characters.
8160
684a03ef
PE
8161 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8162
0fed43f3
PE
8163 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8164 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8165 incorrectly succeed when S was a string, because 4294967386 was
8166 truncated before it was used.
8167
8fd02eb7
PE
8168 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8169 Otherwise, an out-of-range integer could cause undefined behavior
8170 on a 64-bit host.
8171
f8c86b69
PE
8172 * composite.c: Use int, not EMACS_INT, for characters.
8173 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8174 EMACS_INT, for values that are known to be in character range.
8175 This doesn't fix any bugs but is the usual style inside Emacs and
8176 may generate better code on 32-bit machines.
8177
34206dd2
PE
8178 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8179 This is for reasons similar to the recent CHAR_STRING fix.
8180 * charset.c (Fencode_char): Check that character arg is actually
8181 a character. Pass an int to ENCODE_CHAR.
8182 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8183 wider than 'int', as a compile-time check to prevent future regressions
8184 in this area.
8185
c5958d4c 8186 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8187
8188 Make sure a 64-bit char is never passed to CHAR_STRING.
8189 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8190 by silently ignoring the top 32 bits, allowing some values
8191 that were far too large to be valid characters.
8192 * character.h: Include <verify.h>.
8193 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8194 arguments are no wider than unsigned, as a compile-time check
8195 to prevent future regressions in this area.
8196 * data.c (Faset):
01103c44 8197 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8198 (Fsubst_char_in_region):
8199 * fns.c (concat):
8200 * xdisp.c (decode_mode_spec_coding):
8201 Adjust to CHAR_STRING's new requirement.
8202 * editfns.c (Finsert_char, Fsubst_char_in_region):
8203 * fns.c (concat): Check that character args are actually
8204 characters. Without this test, these functions did the wrong
8205 thing with wildly out-of-range values on 64-bit hosts.
8206
d37ca623
PE
8207 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8208 These casts should not be needed on 32-bit hosts, either.
8209 * keyboard.c (read_char):
8210 * lread.c (Fload): Remove casts to unsigned.
8211
ea204efb
PE
8212 * lisp.h (UNSIGNED_CMP): New macro.
8213 This fixes comparison bugs on 64-bit hosts.
8214 (ASCII_CHAR_P): Use it.
8215 * casefiddle.c (casify_object):
01103c44 8216 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8217 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8218 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8219 * dispextern.h (FACE_FROM_ID):
8220 * keyboard.c (read_char): Use UNSIGNED_CMP.
8221
41cb286c
PE
8222 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8223 not to EMACS_INT, to avoid GCC warning.
8224
4a1b9832
PE
8225 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8226
55daad71
PE
8227 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8228 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8229 isn't needed on 32-bit machines.
8f95c75c 8230
01103c44
PE
8231 * buffer.c (Fgenerate_new_buffer_name):
8232 Use EMACS_INT for count, not int.
0ceccced 8233 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
8234
8235 * data.c (Qcompiled_function): Now static.
8236
c6f072e7
PE
8237 * window.c (window_body_lines): Now static.
8238
20ce5912
PE
8239 * image.c (gif_load): Rename local to avoid shadowing.
8240
9c4c5f81
PE
8241 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8242 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8243 * alloc.c (make_save_value): Integer argument is now of type
8244 ptrdiff_t, not int.
8245 (mark_object): Use ptrdiff_t, not int.
8246 * lisp.h (pD): New macro.
8247 * print.c (print_object): Use it.
8248
c0c5c8ae
PE
8249 * alloc.c: Use EMACS_INT, not int, to count objects.
8250 (total_conses, total_markers, total_symbols, total_vector_size)
8251 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
8252 (total_free_floats, total_floats, total_free_intervals)
8253 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
8254 Now EMACS_INT, not int. All uses changed.
8255 (Fgarbage_collect): Compute overall total using a double, so that
8256 integer overflow is less likely to be a problem. Check for overflow
8257 when converting back to an integer.
5a25e253
PE
8258 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8259 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8260 These were 'int' variables that could overflow on 64-bit hosts;
8261 they were never used, so remove them instead of repairing them.
211a0b2a 8262 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
8263 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8264 Previously, this ceilinged at INT_MAX, but that doesn't work on
8265 64-bit machines.
e46bb31a 8266 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 8267
c78baabf 8268 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 8269 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
8270 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8271 when a (possibly-narrower) signed value would do just as well.
8272 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 8273
c9d624c6
PE
8274 * alloc.c: Catch some string size overflows that we were missing.
8275 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8276 for convenience in STRING_BYTES_MAX.
8277 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8278 The definition here is exact; the one in lisp.h was approximate.
8279 (allocate_string_data): Check for string overflow. This catches
8280 some instances we weren't catching before. Also, it catches
8281 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8282 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8283 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 8284
c9d624c6
PE
8285 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8286 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 8287 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 8288
353032ce
PE
8289 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8290
2bccce07
PE
8291 * alloc.c (Fmake_string): Check for out-of-range init.
8292
0ac30604
SM
82932011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8294
8295 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8296
c195f2de
JD
82972011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8298
8299 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8300 xg_get_default_scrollbar_width.
8301
8302 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8303 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8304 (style_changed_cb): Call update_theme_scrollbar_width and call
8305 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8306 all frames (Bug#8505).
8307 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8308 Call gtk_window_set_resizable if HAVE_GTK3.
8309 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8310 and height if HAVE_GTK3 (Bug#8505).
8311 (scroll_bar_width_for_theme): New variable.
8312 (update_theme_scrollbar_width): New function.
8313 (xg_get_default_scrollbar_width): Move code to
8314 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8315 (xg_initialize): Call update_theme_scrollbar_width.
8316
8317 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8318
8319 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8320
e10ac9f1
MR
83212011-06-12 Martin Rudalics <rudalics@gmx.at>
8322
8323 * frame.c (make_frame): Call other_buffer_safely instead of
8324 other_buffer.
8325
8326 * window.c (temp_output_buffer_show): Call display_buffer with
8327 second argument Vtemp_buffer_show_specifiers and reset latter
8328 immediately after the call.
8329 (Vtemp_buffer_show_specifiers): New variable.
8330 (auto_window_vscroll_p, next_screen_context_lines)
8331 (Vscroll_preserve_screen_position): Remove leading asterisks from
8332 doc-strings.
8333
2d3c217e 83342011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8335
7b7f97e8 8336 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8337 * buffer.c (Qclone_number): Remove for now, as it's unused.
8338 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8339 (record_buffer): Remove unused local.
8340 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8341 (set_frame_buffer_list): Remove; unused.
8342 * frame.h (other_visible_frames): Remove decl.
8343 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8344 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8345 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8346 if HAVE_GPM.
8347 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8348 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8349 Define only if HAVE_GPM.
8350 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8351 (update_hints_inhibit): Remove; never set. All uses removed.
8352 * widgetprv.h (emacsFrameClassRec): Remove decl.
8353 * window.c (delete_deletable_window): Now returns void, since it
8354 wasn't returning anything.
8355 (compare_window_configurations): Remove unused locals.
8356 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8357 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8358 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8359 the same widths as pointers. This follows up on the 2011-05-06 patch.
8360 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8361 * xterm.h: Likewise.
8362 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8363
1384b89e
JB
83642011-06-12 Juanma Barranquero <lekktu@gmail.com>
8365
8366 * makefile.w32-in: Update dependencies.
8367 (LISP_H): Add lib/intprops.h.
8368
1100a63c
CY
83692011-06-11 Chong Yidong <cyd@stupidchicken.com>
8370
8371 * image.c (gif_load): Add animation frame delay to the metadata.
8372 (syms_of_image): Use DEFSYM. New symbol `delay'.
8373
6198ccd0
MR
83742011-06-11 Martin Rudalics <rudalics@gmx.at>
8375
8376 * window.c (delete_deletable_window): Re-add.
8377 (Fset_window_configuration): Rewrite to handle dead buffers and
8378 consequently deletable windows.
8379 (window_tree, Fwindow_tree): Remove. Supply functionality in
8380 window.el.
8381 (compare_window_configurations): Simplify code.
8382
b6e3633c
AS
83832011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8384
1ab0dee5
AS
8385 * image.c (imagemagick_load_image): Fix type mismatch.
8386 (Fimagemagick_types): Likewise.
8387
b6e3633c
AS
8388 * window.h (replace_buffer_in_windows): Declare.
8389
9397e56f
MR
83902011-06-11 Martin Rudalics <rudalics@gmx.at>
8391
8392 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8393 Qclone_number. Remove external declaration of Qdelete_window.
8394 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8395 code.
640c8776
SM
8396 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8397 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8398 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8399 buffer list implementation.
8400 (other_buffer_safely): New function.
8401 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8402 calls to replace_buffer_in_windows and
8403 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8404 if allowed.
8405 (record_buffer): Inhibit quitting and rewrite using quittable
8406 functions. Run Qbuffer_list_update_hook if allowed.
8407 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
8408 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8409 Move switch-to-buffer to window.el.
9397e56f
MR
8410 (bury-buffer): Move to window.el.
8411 (Vbuffer_list_update_hook): New variable.
8412
8413 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8414 section.
8415
8416 * window.h (resize_frame_windows): Move up in code.
8417 (Fwindow_frame): Remove EXFUN.
8418 (replace_buffer_in_all_windows): Remove prototype.
8419 (replace_buffer_in_windows_safely): Add prototype.
8420
8421 * window.c: Declare Qdelete_window static again. Move down
8422 declaration of select_count.
8423 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8424 (Fother_window): Move to window.el.
8425 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8426 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8427 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8428 window.el.
8429 (replace_buffer_in_windows): Implement by calling
8430 Qreplace_buffer_in_windows.
8431 (replace_buffer_in_all_windows): Remove with some functionality
8432 moved into replace_buffer_in_windows_safely.
8433 (replace_buffer_in_windows_safely): New function.
8434 (select_window_norecord, select_frame_norecord): Move in front
8435 of run_window_configuration_change_hook. Remove now obsolete
8436 declarations.
640c8776
SM
8437 (Fset_window_buffer): Rewrite doc-string.
8438 Call Qrecord_window_buffer.
9397e56f
MR
8439 (keys_of_window): Move binding for other-window to window.el.
8440
b50691aa
CY
84412011-06-11 Chong Yidong <cyd@stupidchicken.com>
8442
8443 * dispextern.h (struct image): Replace data member, whose int_val
8444 and ptr_val fields were not used by anything, with a single
8445 lisp_val object.
8446
8447 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8448 (gif_clear_image, gif_load, imagemagick_load_image)
8449 (gs_clear_image, gs_load): Callers changed.
8450
3f754b86
PE
84512011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8452
cca69397
PE
8453 * buffer.h: Include <time.h>, for time_t.
8454 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8455
109e28d0
PE
8456 Fix minor problems found by static checking.
8457
60737f02
PE
8458 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8459
4b66faf3
PE
8460 Make identifiers static if they are not used in other modules.
8461 * data.c (Qcompiled_function, Qframe, Qvector):
8462 * image.c (QimageMagick, Qsvg):
8463 * minibuf.c (Qmetadata):
8464 * window.c (resize_window_check, resize_root_window): Now static.
8465 * window.h (resize_window_check, resize_root_window): Remove decls.
8466
109e28d0
PE
8467 * window.c (window_deletion_count, delete_deletable_window):
8468 Remove; unused.
46a4ce9e
PE
8469 (window_body_lines): Now static.
8470 (Fdelete_other_windows_internal): Mark vars as initialized.
8471 Make sure 'resize_failed' is initialized.
8472 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8473 (resize_window_apply): Remove unused local.
8474 * window.h (delete_deletable_window): Remove decl.
8475
109e28d0 8476 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8477 (imagemagick_load_image): Fix pointer signedness problem by changing
8478 last arg from unsigned char * to char *. All uses changed.
8479 Also, fix a local for similar reasons.
8480 Remove unused locals. Remove locals to avoid shadowing.
8481 (fn_rsvg_handle_free): Remove; unused.
8482 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8483 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8484
3f754b86
PE
8485 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8486
2547adb1
CY
84872011-06-10 Chong Yidong <cyd@stupidchicken.com>
8488
8489 * image.c (gif_load): Fix omitted cast error introduced by
8490 2011-06-06 change.
8491
2c8e37d4
MR
84922011-06-10 Martin Rudalics <rudalics@gmx.at>
8493
8494 * window.h (resize_proportionally, orig_total_lines)
8495 (orig_top_line): Remove from window structure.
8496 (set_window_height, set_window_width, change_window_heights)
8497 (Fdelete_window): Remove prototypes.
8498 (resize_frame_windows): Remove duplicate declaration.
8499
440a42e3
EZ
85002011-06-10 Eli Zaretskii <eliz@gnu.org>
8501
8502 * window.h (resize_frame_windows, resize_window_check)
8503 (delete_deletable_window, resize_root_window)
8504 (resize_frame_windows): Declare prototypes.
8505
8506 * window.c (resize_window_apply): Make definition be "static" to
8507 match the prototype.
8508
562dd5e9
MR
85092011-06-10 Martin Rudalics <rudalics@gmx.at>
8510
8511 * window.c: Remove declarations of Qwindow_size_fixed,
8512 window_min_size_1, window_min_size_2, window_min_size,
8513 size_window, window_fixed_size_p, enlarge_window, delete_window.
8514 Remove static from declaration of Qdelete_window, it's
8515 temporarily needed by Fbury_buffer.
8516 (replace_window): Don't assign orig_top_line and
8517 orig_total_lines.
8518 (Fdelete_window, delete_window): Remove. Window deletion is
8519 handled by window.el.
640c8776
SM
8520 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8521 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8522 (Fdelete_other_windows): Remove. Deleting other windows is
8523 handled by window.el.
8524 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8525 handled in window.el.
8526 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8527 Window minimum sizes are handled in window.el.
8528 (shrink_windows, size_window, set_window_height)
8529 (set_window_width, change_window_heights, window_height)
8530 (window_width, CURBEG, CURSIZE, enlarge_window)
8531 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8532 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8533 handled in window.el.
8534 (make_dummy_parent): Rename to make_parent_window and give it a
8535 second argument horflag.
8536 (make_window): Don't set resize_proportionally any more.
8537 (Fsplit_window): Remove. Windows are split in window.el.
8538 (save_restore_action, save_restore_orig_size)
8539 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8540 Resize mini windows in window.el.
8541 (grow_mini_window, shrink_mini_window): Implement by calling
8542 Qresize_root_window_vertically, resize_window_check and
8543 resize_window_apply.
640c8776
SM
8544 (saved_window, Fset_window_configuration, save_window_save):
8545 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8546 resize_proportionally.
8547 (window_min_height, window_min_width): Move to window.el.
8548 (keys_of_window): Move bindings for delete-other-windows,
8549 split-window, delete-window and enlarge-window to window.el.
8550
8551 * buffer.c: Temporarily extern Qdelete_window.
8552 (Fbury_buffer): Temporarily call Qdelete_window instead of
8553 Fdelete_window (Fbury_buffer will move to window.el soon).
8554
8555 * frame.c (set_menu_bar_lines_1): Remove code handling
8556 orig_top_line and orig_total_lines.
8557
8558 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8559 set_window_height but set heights directly.
8560 (change_frame_size_1): Use resize_frame_windows.
8561
8562 * xdisp.c (init_xdisp): Don't use set_window_height but set
8563 heights directly.
8564
640c8776
SM
8565 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8566 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8567 run_window_configuration_change_hook.
8568
8569 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8570 instead of change_window_heights and run
8571 run_window_configuration_change_hook.
8572
1a13852e
MR
85732011-06-09 Martin Rudalics <rudalics@gmx.at>
8574
8575 * window.c (replace_window): Rename second argument REPLACEMENT to
8576 NEW. New third argument SETFLAG. Rewrite.
8577 (delete_window, make_dummy_parent): Call replace_window with
8578 third argument 1.
8579 (window_list_1): Move down in code.
8580 (run_window_configuration_change_hook): Move set_buffer part
8581 before select_frame_norecord part in order to unwind correctly.
8582 Rename count1 to count.
8583 (recombine_windows, delete_deletable_window, resize_root_window)
8584 (Fdelete_other_windows_internal)
8585 (Frun_window_configuration_change_hook, make_parent_window)
8586 (resize_window_check, resize_window_apply, Fresize_window_apply)
8587 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8588 (Fdelete_window_internal, Fresize_mini_window_internal):
8589 New functions.
1a13852e
MR
8590 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8591
f3d1777e
MR
85922011-06-08 Martin Rudalics <rudalics@gmx.at>
8593
496e208e
MR
8594 * window.h (window): Add some new members to window structure -
8595 normal_lines, normal_cols, new_total, new_normal, clone_number,
8596 splits, nest, prev_buffers, next_buffers.
8597 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 8598 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 8599
f3d1777e
MR
8600 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8601 Remove.
496e208e
MR
8602 (make_dummy_parent): Set new members of windows structure.
8603 (make_window): Move down in code. Handle new members of window
8604 structure.
8605 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8606 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8607 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8608 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
8609 (Fset_window_next_buffers, Fset_window_clone_number):
8610 New functions.
496e208e
MR
8611 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8612 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8613 Doc-string fixes.
8614 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8615 Argument WINDOW can be now internal window too.
8616 (Fwindow_use_time): Move up in code.
8617 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8618 Rewrite doc-string.
8619 (Fset_window_configuration, saved_window)
8620 (Fcurrent_window_configuration, save_window_save): Handle new
8621 members of window structure.
b9e809c2
MR
8622 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8623 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8624 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8625 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8626 Qget_mru_window, Qresize_root_window,
8627 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8628 Qauto_buffer_name; staticpro them.
f3d1777e 8629
abde8f8c
MR
86302011-06-07 Martin Rudalics <rudalics@gmx.at>
8631
8632 * window.c (Fwindow_total_size, Fwindow_left_column)
8633 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8634 (Fwindow_list_1): New functions.
8635 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
8636 (Fwindow_width, Fscroll_left, Fscroll_right):
8637 Use window_body_cols instead of window_box_text_cols.
8638 (delete_window, Fset_window_configuration):
8639 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
8640 (delete_all_subwindows): Take a window as argument and not a
8641 structure. Rewrite.
190b47e6
MR
8642 (window_loop): Remove handling of GET_LRU_WINDOW and
8643 GET_LARGEST_WINDOW.
8644 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
8645
8646 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
8647 window_box_text_cols. delete_all_subwindows now takes a
8648 Lisp_Object as argument.
abde8f8c 8649
640c8776
SM
8650 * indent.c (compute_motion, Fcompute_motion):
8651 Use window_body_cols instead of window_box_text_cols.
abde8f8c 8652
fa8a67e6
MR
8653 * frame.c (delete_frame): Call delete_all_subwindows with root
8654 window as argument.
8655
a54e3482
DC
86562011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8657
8658 * fns.c (Fputhash): Document return value.
8659
60002bf5
CY
86602011-06-06 Chong Yidong <cyd@stupidchicken.com>
8661
8662 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8663
0c671da6 86642011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8665
b862a52a 8666 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8667
be44ca6c
PE
8668 Check for overflow when converting integer to cons and back.
8669 * charset.c (Fdefine_charset_internal, Fdecode_char):
8670 Use cons_to_unsigned to catch overflow.
8671 (Fencode_char): Use INTEGER_TO_CONS.
8672 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8673 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8674 * data.c (long_to_cons, cons_to_long): Remove.
8675 (cons_to_unsigned, cons_to_signed): New functions.
8676 These signal an error for invalid or out-of-range values.
8677 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8678 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8679 * font.c (Ffont_variation_glyphs):
8680 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8681 * lisp.h: Include <intprops.h>.
8682 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8683 (cons_to_signed, cons_to_unsigned): New decls.
8684 (long_to_cons, cons_to_long): Remove decls.
8685 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8686 (Fprimitive_undo): Use CONS_TO_INTEGER.
8687 * xfns.c (Fx_window_property): Likewise.
8688 * xselect.c: Include <limits.h>.
8689 (x_own_selection, selection_data_to_lisp_data):
8690 Use INTEGER_TO_CONS.
8691 (x_handle_selection_request, x_handle_selection_clear)
8692 (x_get_foreign_selection, Fx_disown_selection_internal)
8693 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8694 (lisp_data_to_selection_data): Use cons_to_unsigned.
8695 (x_fill_property_data): Use cons_to_signed.
8696 Report values out of range.
8697
d1f3d2af
PE
8698 Check for buffer and string overflow more precisely.
8699 * buffer.h (BUF_BYTES_MAX): New macro.
8700 * lisp.h (STRING_BYTES_MAX): New macro.
8701 * alloc.c (Fmake_string):
8702 * character.c (string_escape_byte8):
8703 * coding.c (coding_alloc_by_realloc):
8704 * doprnt.c (doprnt):
8705 * editfns.c (Fformat):
8706 * eval.c (verror):
8707 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8708 since they may not be the same number.
8709 * editfns.c (Finsert_char):
8710 * fileio.c (Finsert_file_contents):
8711 Likewise for BUF_BYTES_MAX.
8712
dd52fcea
PE
8713 * image.c: Use ptrdiff_t, not int, for sizes.
8714 (slurp_file): Switch from int to ptrdiff_t.
8715 All uses changed.
8716 (slurp_file): Check that file size fits in both size_t (for
8717 malloc) and ptrdiff_t (for sanity and safety).
8718
7f9bbdbb
PE
8719 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8720 if b->modtime has its maximal value.
8721
dfe18f82
PE
8722 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8723
84acfcf0
PE
8724 Don't assume time_t can fit into int.
8725 * buffer.h (struct buffer.modtime): Now time_t, not int.
8726 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8727 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8728
ccd9a01a
PE
8729 Minor fixes for signed vs unsigned integers.
8730 * character.h (MAYBE_UNIFY_CHAR):
8731 * charset.c (maybe_unify_char):
8732 * keyboard.c (read_char, reorder_modifiers):
8733 XINT -> XFASTINT, since the integer must be nonnegative.
8734 * ftfont.c (ftfont_spec_pattern):
8735 * keymap.c (access_keymap, silly_event_symbol_error):
8736 XUINT -> XFASTINT, since the integer must be nonnegative.
8737 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8738 since it makes no difference and we prefer signed.
8739 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8740 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8741 nonnegative.
8742
d6d100dd
SM
87432011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8744
8745 * window.h (Fwindow_frame): Declare.
8746
2b6148e4
PE
87472011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8748
8749 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8750 (SPARE_MEMORY): Always define.
8751 (LARGE_REQUEST): Remove.
8752 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8753
f230ecc9
MR
87542011-06-06 Martin Rudalics <rudalics@gmx.at>
8755
727e958e
MR
8756 * lisp.h: Move EXFUNS for Fframe_root_window,
8757 Fframe_first_window and Fset_frame_selected_window to window.h.
8758
8759 * window.h: Move EXFUNS for Fframe_root_window,
8760 Fframe_first_window and Fset_frame_selected_window here from
8761 lisp.h.
8762
8763 * frame.c (Fwindow_frame, Fframe_first_window)
8764 (Fframe_root_window, Fframe_selected_window)
8765 (Fset_frame_selected_window): Move to window.c.
8766 (Factive_minibuffer_window): Move to minibuf.c.
8767 (Fother_visible_frames_p): New function.
8768
8769 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8770
f230ecc9
MR
8771 * window.c (decode_window, decode_any_window): Move up in code.
8772 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8773 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8774 (Fwindow_buffer): Move up and rewrite doc-string.
8775 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8776 (Fwindow_prev): New functions.
727e958e
MR
8777 (Fwindow_frame): Move here from frame.c. Accept any window as
8778 argument.
8779 (Fframe_root_window, Fframe_first_window)
8780 (Fframe_selected_window): Move here from frame.c. Accept frame
8781 or arbitrary window as argument. Update doc-strings.
8782 (Fminibuffer_window): Move up in code.
8783 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8784 (Fset_frame_selected_window): Move here from frame.c.
8785 Marginal rewrite.
727e958e
MR
8786 (Fselected_window, select_window, Fselect_window): Move up in
8787 code. Minor doc-string fixes.
f230ecc9 8788
4d09bcf6
PE
87892011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8790
8791 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8792 Do not assume that spare memory exists; that assumption is valid
8793 only if SYSTEM_MALLOC.
8794 (LARGE_REQUEST): New macro, so that the issue of large requests
8795 is separated from the issue of spare memory.
8796
810928a2
AS
87972011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8798
172418ad
AS
8799 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8800 format. (Bug#8806)
8801
43f862f7
AS
8802 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8803
810928a2
AS
8804 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8805 before statements.
8806
a059fe24
JD
88072011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8808
8809 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8810
8811 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8812
8813 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8814 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8815
989bf368
JB
88162011-06-05 Juanma Barranquero <lekktu@gmail.com>
8817
8818 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8819
4b80f674
CY
88202011-06-04 Chong Yidong <cyd@stupidchicken.com>
8821
8822 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8823 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8824 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8825 New error handlers.
4b80f674
CY
8826 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8827 Obey Vx_select_enable_clipboard_manager. Catch errors in
8828 x_clipboard_manager_save (Bug#8779).
8829 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8830 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8831
99a33b77 88322011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8833
8834 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8835
99a33b77 88362011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8837
8838 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8839 in the current matrix if keep_current_p is non-zero.
8840
8264569d
EZ
88412011-06-04 Eli Zaretskii <eliz@gnu.org>
8842
8843 * bidi.c (bidi_level_of_next_char): Fix last change.
8844
57f97249
EZ
88452011-06-03 Eli Zaretskii <eliz@gnu.org>
8846
fec2107c 8847 Support bidi reordering of text covered by display properties.
57f97249 8848
fec2107c
EZ
8849 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8850 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8851 (bidi_cache_search, bidi_cache_iterator_state)
8852 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8853 (bidi_level_of_next_char, bidi_move_to_visually_next):
8854 Support character positions inside a run of characters covered by a
fec2107c
EZ
8855 display string.
8856 (bidi_paragraph_init, bidi_resolve_explicit_1)
8857 (bidi_level_of_next_char): Call bidi_fetch_char and
8858 bidi_fetch_char_advance instead of FETCH_CHAR and
8859 FETCH_CHAR_ADVANCE.
8860 (bidi_init_it): Initialize new members.
8861 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8862 definitions.
8863 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8864 instead of using explicit *_CHAR codes.
d6d100dd
SM
8865 (bidi_resolve_explicit, bidi_resolve_weak):
8866 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8867 bidirectional text is supported only in multibyte buffers.
8868 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8869 it to initialize the frame_window_p member of struct bidi_it.
8870 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8871 (bidi_resolve_explicit, bidi_resolve_weak)
8872 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8873 bidi_it->nchars is non-positive.
8874 (bidi_level_of_next_char): Don't try to lookup the cache for the
8875 next/previous character if nothing is cached there yet, or if we
8876 were just reseat()'ed to a new position.
c40e2fb2 8877
0e14fe90
EZ
8878 * xdisp.c (set_cursor_from_row): Set start and stop points
8879 according to the row's direction when priming the loop that looks
8880 for the glyph on which to display cursor.
8881 (single_display_spec_intangible_p): Function deleted.
8882 (display_prop_intangible_p): Reimplement to call
8883 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8884 Accept 3 additional arguments needed by handle_display_spec.
8885 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8886 values: lists, `(when COND...)' forms, etc.
8887 (single_display_spec_string_p): Support property values that are
8888 lists with the argument STRING its top-level element.
8889 (display_prop_string_p): Fix the condition for processing a
8890 property that is a list to be consistent with handle_display_spec.
fec2107c 8891 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8892 last portion of handle_display_prop.
8893 (compute_display_string_pos): Accept additional argument
8894 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8895 value of a `display' property is a "replacing spec".
8896 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8897 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8898 the display property, but just return a value indicating whether
8899 the display property will replace the characters it covers.
8900 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8901 frame_window_p members of struct bidi_it.
d6d100dd
SM
8902 (compute_display_string_pos, compute_display_string_end):
8903 New functions.
fec2107c
EZ
8904 (push_it): Accept second argument POSITION, where pop_it should
8905 jump to continue iteration.
8906 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 8907
fec2107c
EZ
8908 * keyboard.c (adjust_point_for_property): Adjust the call to
8909 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8910
8911 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8912 (bidi_init_it): Update prototypes.
8913 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8914 (compute_display_string_pos, compute_display_string_end):
8915 Declare prototypes.
fec2107c
EZ
8916 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8917 EMACS_INT.
fc6f18ce 8918
40087514 89192011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 8920
57f53182
PE
8921 Malloc failure behavior now depends on size of allocation.
8922 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8923 * lisp.h: Change signatures accordingly.
8924 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8925 All callers changed. (Bug#8762)
8926
8927 * gnutls.c: Use Emacs's memory allocators.
8928 Without this change, the gnutls library would invoke malloc etc.
8929 directly, which causes problems on non-SYNC_INPUT hosts, and which
8930 runs afoul of improving memory_full behavior. (Bug#8761)
8931 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8932 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8933 xfree instead of the default malloc, realloc, free.
8934 (Fgnutls_boot): No need to check for memory allocation failure,
8935 since xmalloc does that for us.
8936
ac32cd99 8937 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
8938 * category.c (hash_get_category_set):
8939 * ccl.c (ccl_driver):
8940 * charset.c (Fdefine_charset_internal):
8941 * charset.h (struct charset.hash_index):
8942 * composite.c (get_composition_id, gstring_lookup_cache)
8943 (composition_gstring_put_cache):
8944 * composite.h (struct composition.hash_index):
8945 * dispextern.h (struct image.hash):
8946 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8947 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8948 (hashfn_equal, hashfn_user_defined, make_hash_table)
8949 (maybe_resize_hash_table, hash_lookup, hash_put)
8950 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8951 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8952 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8953 * image.c (make_image, search_image_cache, lookup_image)
8954 (xpm_put_color_table_h):
8955 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8956 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8957 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8958 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8959 * alloc.c (allocate_vectorlike):
8960 Check for overflow in vector size calculations.
8961 * ccl.c (ccl_driver):
8962 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8963 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8964 need to be updated by these changes.
40087514
PE
8965 * fns.c (make_hash_table, maybe_resize_hash_table):
8966 Check for integer overflow with large hash tables.
0de4bb68
PE
8967 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8968 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8969 (SXHASH_REDUCE): New macro.
8970 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8971 Use it instead of discarding useful hash info with large hash values.
8972 (sxhash_float): New function.
8973 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8974 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8975 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8976 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8977 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8978 Adjust signatures to match updated version of code.
8979 (consing_since_gc): Now EMACS_INT, since a single hash table can
8980 use more than INT_MAX bytes.
8981
698d32e2
DN
89822011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8983
8984 Make it possible to build with GCC-4.6+ -O2 -flto.
8985
8986 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8987
fd6fa53f
SM
89882011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8989
8990 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8991 Call minibuffer-inactive-mode.
8992
864db017
JB
89932011-05-31 Juanma Barranquero <lekktu@gmail.com>
8994
8995 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8996 Update dependencies.
8997
2ad0baf4
DN
89982011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8999
9000 * data.c (init_data): Remove code for UTS, this system is not
9001 supported anymore.
9002
4fcc2638
DN
90032011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9004
9005 Don't force ./temacs to start in terminal mode.
9006
9007 * frame.c (make_initial_frame): Initialize faces in all cases, not
9008 only when CANNOT_DUMP is defined.
9009 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9010
c56e0fd5
DN
90112011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9012
9013 * dispnew.c (add_window_display_history): Use const for the string
9014 pointer. Remove declaration, not needed.
9015
333d54da 90162011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9017
55d4c1b2 9018 Use 'inline', not 'INLINE'.
333d54da 9019 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9020 * alloc.c, fontset.c (INLINE): Remove.
9021 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9022 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9023 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9024 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9025 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9026
738db178
DN
90272011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9028
9029 Make it possible to run ./temacs.
9030
9031 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9032 syms_of_callproc does the same thing. Remove test for
9033 "initialized", do it in the caller.
9034 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9035
620c53a6
SM
90362011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9037
9038 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9039 (read_minibuf): Use get_minibuffer.
9040 (syms_of_minibuf): Use DEFSYM.
9041 (Qmetadata): New var.
9042 * data.c (Qbuffer): Don't make it static.
9043 (syms_of_data): Use DEFSYM.
9044
e003a292
PE
90452011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9046
9047 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9048 (CCL_CODE_MIN): New macro.
9049
ed008a6d
PE
90502011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9051
3687c2ef
PE
9052 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9053
ed008a6d
PE
9054 * eval.c (Qdebug): Now static.
9055 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9056 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9057 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9058
d66c4c7c
CY
90592011-05-29 Chong Yidong <cyd@stupidchicken.com>
9060
9061 * image.c: Various fixes to ImageMagick code comments.
9062 (Fimagemagick_types): Doc fix.
9063
5fbc2025
PE
90642011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9065
0196f88a
PE
9066 Minor fixes prompted by GCC 4.6.0 warnings.
9067
9068 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9069
5fbc2025
PE
9070 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9071 (x_clipboard_manager_save_all): Move extern decl to ...
9072 * xterm.h: ... here, so that it can be checked for consistency.
9073
1dd3c2d9
CY
90742011-05-29 Chong Yidong <cyd@stupidchicken.com>
9075
9076 * xselect.c (x_clipboard_manager_save_frame)
9077 (x_clipboard_manager_save_all): New functions.
9078 (Fx_clipboard_manager_save): Lisp function deleted.
9079
9080 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9081 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9082
9083 * xterm.h: Update prototype.
9084
5ba6571d
WX
90852011-05-28 William Xu <william.xwl@gmail.com>
9086
9087 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9088 exiting (Bug#8239).
9089
3eaff834
JM
90902011-05-28 Jim Meyering <meyering@redhat.com>
9091
e1900994 9092 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9093 * fns.c (to_uchar): Define.
9094 (crypto_hash_function): Use it to convert some newly-signed
9095 variables to unsigned, to avoid sign-extension bugs. For example,
9096 without this change, (md5 "truc") would evaluate to
9097 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9098 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9099 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9100
0f6990a7
PE
91012011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9102
9103 Integer overflow fixes.
c8a9ca5a 9104
08686060
PE
9105 * dbusbind.c: Serial number integer overflow fixes.
9106 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9107 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9108 to hold a serial number that is too large for a fixnum.
9109 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9110 Check for serial numbers out of range. Decode any serial number
59568bf0 9111 that was so large that it became a float. (Bug#8722)
08686060 9112
2d1fc3c7
PE
9113 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9114 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9115 Use XFASTINT rather than XUINT when numbers are nonnegative.
9116 (xd_append_arg, Fdbus_method_return_internal):
9117 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9118 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9119 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9120 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9121 (Bug#8722)
2d1fc3c7 9122
c8a9ca5a
PE
9123 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9124
519e1d69
PE
9125 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9126
6df6ae42 9127 ccl: Add integer overflow checks.
30569699
PE
9128 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9129 (IN_INT_RANGE): New macros.
9130 (ccl_driver): Use them to check for integer overflow when
9131 decoding a CCL program. Many of the new checks are whether XINT (x)
9132 fits in int; it doesn't always, on 64-bit hosts. The new version
9133 doesn't catch all possible integer overflows, but it's an
847044ea 9134 improvement. (Bug#8719)
30569699 9135
c11285dc
PE
9136 * alloc.c (make_event_array): Use XINT, not XUINT.
9137 There's no need for unsigned here.
9138
fdccd48e
PE
9139 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9140 This follows up to the 2011-05-06 change that substituted uintptr_t
9141 for EMACS_INT. This case wasn't caught back then.
9142
37910ab2
PE
9143 Rework Fformat to avoid integer overflow issues.
9144 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9145 now (part of C89). Include <verify.h>.
9146 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9147 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9148 (Fformat): Avoid the prepass trying to compute sizes; it was only
9149 approximate and thus did not catch overflow reliably. Instead, walk
9150 through the format just once, formatting and computing sizes as we go,
9151 checking for integer overflow at every step, and allocating a larger
9152 buffer as needed. Keep track separately whether the format is
9153 multibyte. Keep only the most-recently calculated precision, rather
9154 than them all. Record whether each argument has been converted to
9155 string. Use EMACS_INT, not int, for byte and char and arg counts.
9156 Support field widths and precisions larger than INT_MAX. Avoid
9157 sprintf's undefined behavior with conversion specifications such as %#d
9158 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9159 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9160 formatting out-of-range floating point numbers with int
9173deec 9161 formats. (Bug#8668)
37910ab2 9162
2e6578fb
PE
9163 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9164
0ae6bdee
PE
9165 * data.c: Avoid integer truncation in expressions involving floats.
9166 * data.c: Include <intprops.h>.
9167 (arith_driver): When there's an integer overflow in an expression
9168 involving floating point, convert the integers to floating point
9169 so that the resulting value does not suffer from catastrophic
9170 integer truncation. For example, on a 64-bit host (* 4
9171 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9172 Do not rely on undefined behavior after integer overflow.
9173
de883a70
PE
9174 merge count_size_as_multibyte, parse_str_to_multibyte
9175 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9176 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9177 Check for integer overflow.
9178 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9179 since it's now a duplicate of the other. This is more of
9180 a character than a buffer op, so better that it's in character.c.
9181 * fns.c, print.c: Adjust to above changes.
9182
2ff916cb
PE
91832011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9184
9185 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9186
f1b54466
PE
91872011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9188
fb1ac845
PE
9189 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9190 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9191 (x_clipboard_manager_save): Now static.
9192 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9193
f1b54466
PE
9194 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9195 (crypto_hash_function): Now static.
9196 Fix pointer signedness problems. Avoid unnecessary initializations.
9197
a9f737ee
CY
91982011-05-27 Chong Yidong <cyd@stupidchicken.com>
9199
9200 * termhooks.h (Vselection_alist): Make it terminal-local.
9201
9202 * terminal.c (create_terminal): Initialize it.
9203
9204 * xselect.c: Support for clipboard managers.
9205 (Vselection_alist): Move to termhooks.h as terminal-local var.
9206 (LOCAL_SELECTION): New macro.
9207 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9208 (symbol_to_x_atom): Remove gratuitous arg.
9209 (x_handle_selection_request, lisp_data_to_selection_data)
9210 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9211 (x_own_selection, x_get_local_selection, x_convert_selection):
9212 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9213 (some_frame_on_display): Delete unused function.
9214 (Fx_own_selection_internal, Fx_get_selection_internal)
9215 (Fx_disown_selection_internal, Fx_selection_owner_p)
9216 (Fx_selection_exists_p): New optional frame arg.
9217 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9218 (x_handle_selection_clear): Don't treat other terminals with the
9219 same keyboard specially. Use the terminal-local Vselection_alist.
9220 (x_clear_frame_selections): Use Frun_hook_with_args.
9221
9222 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9223
9224 * xterm.h: Add support for those atoms.
9225
e067f0c1
CY
92262011-05-26 Chong Yidong <cyd@stupidchicken.com>
9227
9228 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9229 (converted_selections, conversion_fail_tag): New global variables.
9230 (x_selection_request_lisp_error): Free the above.
9231 (x_get_local_selection): Remove unnecessary code.
9232 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
9233 of converted selections stored in converted_selections.
9234 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
9235 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9236 (x_convert_selection): New function.
9237 (x_handle_selection_event): Simplify.
9238 (x_get_foreign_selection): Don't ignore incoming requests while
9239 waiting for an answer; this will fail when we implement
9240 SAVE_TARGETS, and seems unnecessary anyway.
9241 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9242 (Vx_sent_selection_functions): Doc fix.
9243
0f4aebc0
LL
92442011-05-26 Leo Liu <sdl.web@gmail.com>
9245
9246 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9247
e61124cd
YM
92482011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9249
9250 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9251
9252 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9253 for fringe update if it has periodic bitmap.
ac389d0c 9254 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
9255 and fringe_bitmap_periodic_p.
9256
9257 * fringe.c (get_fringe_bitmap_data): New function.
9258 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9259 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9260 row. Mark glyph row for fringe update if periodicity changed.
9261
9262 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9263 for fringe update unless it has periodic bitmap.
9264
f16d9837
KH
92652011-05-25 Kenichi Handa <handa@m17n.org>
9266
9267 * xdisp.c (get_next_display_element): Set correct it->face_id for
9268 a static composition.
9269
e1b90ef6
LL
92702011-05-24 Leo Liu <sdl.web@gmail.com>
9271
9272 * deps.mk (fns.o):
9273 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9274
9275 * fns.c (crypto_hash_function, Fsha1): New function.
9276 (Fmd5): Use crypto_hash_function.
9277 (syms_of_fns): Add Ssha1.
9278
7400048f
PE
92792011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9280
9281 * gnutls.c: Remove unused macros.
9282 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9283 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9284 Remove macros that are defined and never used.
9285 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9286
abb71cf4
CY
92872011-05-22 Chong Yidong <cyd@stupidchicken.com>
9288
9289 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9290 (Fx_get_selection_internal): Minor cleanup.
9291 (Fx_own_selection_internal): Rename arguments for consistency with
9292 select.el.
9293
6307db39
PE
92942011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9295
9296 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9297
f3d4e0a4
CY
92982011-05-22 Chong Yidong <cyd@stupidchicken.com>
9299
9300 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9301
4d8ade89
YM
93022011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9303
9304 * dispnew.c (scrolling_window): Don't exclude the case that the
9305 last enabled row in the desired matrix touches the bottom boundary.
9306
32078c8d
GM
93072011-05-21 Glenn Morris <rgm@gnu.org>
9308
9309 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
9310 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9311 and add some more files.
32078c8d 9312
7285dc67
EZ
93132011-05-20 Eli Zaretskii <eliz@gnu.org>
9314
9315 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9316 report_file_error introduced by the change from 2011-05-07.
9317
89d1bd22
PE
93182011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9319
9320 * systime.h (Time): Define only if emacs is defined.
9321 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9322 where the include path doesn't have X11/X.h by default. See
9323 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9324
cd394be1 93252011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9326
9327 * composite.c (find_automatic_composition): Fix previous change.
9328
b9704ad9
GM
93292011-05-20 Glenn Morris <rgm@gnu.org>
9330
9331 * lisp.mk: New file, split from Makefile.in.
9332 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9333 (shortlisp): Remove.
9334 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9335
4a720484
GM
93362011-05-19 Glenn Morris <rgm@gnu.org>
9337
9338 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9339 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9340 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9341 (lisp): Set the order to that of loadup.el.
9342 (shortlisp): Make it a copy of $lisp.
9343 (SOME_MACHINE_LISP): Remove.
9344 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9345 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9346
a28d4396
KH
93472011-05-18 Kenichi Handa <handa@m17n.org>
9348
9349 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9350 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9351 (find_automatic_composition): Mostly rewrite for efficiency.
9352
a2b1fa8e
JB
93532011-05-18 Juanma Barranquero <lekktu@gmail.com>
9354
9355 * makefile.w32-in: Update dependencies.
9356
8e1f5610
CS
93572011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9358
9359 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9360 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9361
7025ee00 93622011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9363
cdfa6eab
PE
9364 Fix some integer overflow issues, such as string length overflow.
9365
06d6db33
PE
9366 * insdel.c (count_size_as_multibyte): Check for string overflow.
9367
2b4560a8
PE
9368 * character.c (lisp_string_width): Check for string overflow.
9369 Use EMACS_INT, not int, for string indexes and lengths; in
9370 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9371 the resulting string length overflows an EMACS_INT; instead,
9372 report a string overflow if no precision given. When checking for
9373 precision exhaustion, use a check that cannot possibly have
9374 integer overflow. (Bug#8675)
9375 * character.h (lisp_string_width): Adjust to new signature.
9376
cb93f9be
PE
9377 * alloc.c (string_overflow): New function.
9378 (Fmake_string): Use it. This doesn't change behavior, but saves
9379 a few bytes and will simplify future changes.
9380 * character.c (string_escape_byte8): Likewise.
9381 * lisp.h (string_overflow): New decl.
9382
1a1f3366
PE
9383 Fixups, following up to the user-interface timestamp change.
9384 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9385 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9386 * msdos.c (mouse_get_pos): Likewise.
9387 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9388 * w32gui.h (Time): Define by including "systime.h" rather than by
9389 declaring it ourselves. (Bug#8664)
9390
d4e3e4d3
PE
9391 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9392 * image.c (clear_image_cache): Likewise.
9393
f6a24d19
PE
9394 * term.c (term_mouse_position): Don't assume time_t wraparound.
9395
08dc5ae6
PE
9396 Be more systematic about user-interface timestamps.
9397 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9398 and sometimes 'EMACS_UINT', to represent these timestamps.
9399 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9400 This makes the code easier to follow, and makes it easier to catch
9401 integer overflow bugs such as Bug#8664.
9402 * frame.c (Fmouse_position, Fmouse_pixel_position):
9403 Use Time, not unsigned long, for user-interface timestamps.
9404 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9405 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9406 * keyboard.h (last_event_timestamp): Likewise.
9407 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9408 * menu.h (xmenu_show): Likewise.
9409 * term.c (term_mouse_position): Likewise.
9410 * termhooks.h (struct input_event.timestamp): Likewise.
9411 (struct terminal.mouse_position_hook): Likewise.
9412 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9413 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9414 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9415 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9416 what it was before.
9417 * menu.h, termhooks.h: Include "systime.h", for Time.
9418
8e55734a
PE
9419 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9420 Don't assume that the difference between two unsigned long values
9421 can fit into an integer. At this point, we know button_down_time
9422 <= event->timestamp, so the difference must be nonnegative, so
9423 there's no need to cast the result if double-click-time is
9424 nonnegative, as it should be; check that it's nonnegative, just in
9425 case. This bug is triggered when events are more than 2**31 ms
86db42d2 9426 apart (about 25 days). (Bug#8664)
8e55734a 9427
841f1b75 9428 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9429 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9430
3e26f69c
PE
9431 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9432 that always fit in int. Use a sentinel instead of a counter, to
9433 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
9434 * frame.h (struct frame): Use int for menu_bar_items_used
9435 instead of EMACS_INT, since it always fits in int.
3e26f69c 9436
5cc152c0
PE
9437 * menu.c (grow_menu_items): Check for int overflow.
9438
d89eb65e
PE
9439 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9440
5235bd3e
PE
9441 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9442 Before, the code was not consistent. These values cannot exceed
9443 2**31 - 1 so there's no need to make them unsigned.
9444 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9445 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9446 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9447 as modifiers.
9448 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9449
bc827e23
PE
9450 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9451 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9452 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9453 presumably because the widths might not match.
9454
78eb494e
PE
9455 * window.c (size_window): Avoid needless test at loop start.
9456
04f2d78b
CB
94572011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9458
9459 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9460
d2fc7e3d 94612011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9462
9463 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9464
d2fc7e3d 94652011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9466
9467 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9468 `width' to `bar_area_x' and `bar_area_width', respectively.
9469 (x_scroll_run): Take account of fringe background extension.
9470
04f2d78b
CB
9471 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9472 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9473 `bar_area_width', respectively.
9474 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9475 background extension.
9476
79b70037
GM
94772011-05-10 Jim Meyering <meyering@redhat.com>
9478
9479 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9480
2f142cc5
JB
94812011-05-10 Juanma Barranquero <lekktu@gmail.com>
9482
9483 * image.c (Finit_image_library): Return t for built-in image types,
9484 like pbm and xbm. (Bug#8640)
9485
57679c86
AS
94862011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9487
9488 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9489
888c9e86
EZ
94902011-05-07 Eli Zaretskii <eliz@gnu.org>
9491
b0512a1d
EZ
9492 * w32console.c (Fset_screen_color): Doc fix.
9493 (Fget_screen_color): New function.
9494 (syms_of_ntterm): Defsubr it.
9495
7285dc67
EZ
9496 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9497 unlink the temporary file if Fcall_process didn't create it in the
9498 first place.
9499 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9500 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9501 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9502 cue to call_process_cleanup not to close that handle.
9503
4d3fcc8e
BK
95042011-05-07 Ben Key <bkey76@gmail.com>
9505
9506 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9507 one of two shell specific rules, either bootstrap-temacs-CMD or
9508 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9509 to the previous implementation of the bootstrap-temacs rule.
9510 The bootstrap-temacs-CMD rule is similar to the previous
9511 implementation of the bootstrap-temacs rule except that it
9512 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9513 variable.
9514
9515 These changes, along with some changes to nt/configure.bat,
9516 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9517 earlier fix to add support for --cflags and --ldflags options
9518 that include quotes so that it works whether make uses cmd or
9519 sh as the shell.
9520
b4289b64
MA
95212011-05-06 Michael Albinus <michael.albinus@gmx.de>
9522
9523 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9524 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9525 is a constant.
9526 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9527 a string. Handle both cases.
9528 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9529 (Fdbus_register_method): Use Qinvalid_function.
9530
af4c0e28
JB
95312011-05-06 Juanma Barranquero <lekktu@gmail.com>
9532
9533 * makefile.w32-in: Update dependencies.
9534 (LISP_H): Add inttypes.h and stdin.h.
9535 (PROCESS_H): Add unistd.h.
9536
c51453d9
EZ
95372011-05-06 Eli Zaretskii <eliz@gnu.org>
9538
9539 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9540 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9541
8ff0ac3c 95422011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9543
4c4b566b
PE
9544 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9545
aab2b9b5
PE
9546 * term.c (vfatal): Remove stray call to va_end.
9547 It's not needed and the C Standard doesn't allow it here anyway.
9548
c378da0b
PE
9549 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9550 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9551
288b08c7
PE
9552 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9553 bytes.
9554
e3601888
PE
9555 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9556
db6c0e74
PE
9557 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9558
dd5963ea
PE
9559 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9560
88c9450f
PE
9561 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9562
2f9442b8
PE
9563 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9564
c032b5f8
PE
9565 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9566 * charset.c (Fdefine_charset_internal): Don't initialize
9567 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9568 32-bit int (Bug#8600).
a108c10b
PE
9569
9570 * lread.c (read_integer): Be more consistent with string-to-number.
9571 Use string_to_number to do the actual conversion; this avoids
9572 rounding errors and fixes some other screwups. Without this fix,
9573 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9574 (digit_to_number): Move earlier, for benefit of read_integer.
9575 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9576 not a digit in any supported base. (Bug#8602)
a108c10b 9577
ad5f9eea
PE
9578 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9579
aec1708a
PE
9580 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9581 to match comment at start of function. This also removes a
9582 GCC warning about overflow in a 32+64-bit port.
9583
47be4ab5
PE
9584 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9585
371cac43
PE
9586 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9587 Reported by Stefan Monnier in
9588 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9589 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9590 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 9591
d01a7826
PE
9592 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9593 (EMACS_UINTPTR): Likewise, with uintptr_t.
9594
7fd47d5c
PE
9595 * lisp.h: Prefer 64-bit EMACS_INT if available.
9596 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9597 on 32-bit hosts that have 64-bit int, so that they can access
9598 large files.
122b0c86
PE
9599 However, temporarily disable this change unless the temporary
9600 symbol WIDE_EMACS_INT is defined.
7fd47d5c 9601
8727937b
PE
9602 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9603
8ac068ac
PE
9604 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9605 This removes an assumption that EMACS_INT and long are the same
9606 width as pointers. The assumption is true for Emacs porting targets
9607 now, but we want to make other targets possible.
9608 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9609 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9610 In the rest of the code, change types of integers that hold casted
9611 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9612 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9613 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9614 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9615 No need to cast type when ORing.
9616 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9617 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9618 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9619 assume EMACS_INT is the same width as char *.
9620 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9621 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9622 Remove no-longer-needed casts.
9623 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9624 (xg_tool_bar_help_callback, xg_make_tool_item):
9625 Use EMACS_INTPTR to hold an integer
9626 that will be cast to void *; this can avoid a GCC warning
9627 if EMACS_INT is not the same width as void *.
9628 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9629 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9630 (current_message_1, set_message_1):
9631 Use a local to convert to proper width without a cast.
9632 * xmenu.c (dialog_selection_callback): Likewise.
9633
ede49d71
PE
9634 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9635 Also, don't assume VALBITS / RAND_BITS is less than 5,
9636 and don't rely on undefined behavior when shifting a 1 left into
9637 the sign bit.
9638 * lisp.h (get_random): Change signature to match.
9639
2f30ecd0
PE
9640 * lread.c (hash_string): Use size_t, not int, for hash computation.
9641 Normally we prefer signed values; but hashing is special, because
9642 it's better to use unsigned division on hash table sizes so that
9643 the remainder is nonnegative. Also, size_t is the natural width
9644 for hashing into memory. The previous code used 'int', which doesn't
9645 retain enough info to hash well into very large tables.
9646 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9647
2a866e7b
PE
9648 * dbusbind.c: Don't possibly lose pointer info when converting.
9649 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9650 Use XPNTR rather than XHASH, so that the high-order bits of
9651 the pointer aren't lost when converting through void *.
9652
51639eac
PE
9653 * eval.c (Fautoload): Don't double-shift a pointer.
9654
92394119
PE
9655 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9656
dbdb9a7c
JB
96572011-05-06 Juanma Barranquero <lekktu@gmail.com>
9658
9659 * gnutls.c (DEF_GNUTLS_FN):
9660 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9661
db7a0b4f
AS
96622011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9663
9664 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9665 marker. (Bug#8610)
9666
cd394be1 96672011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9668
9669 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9670 New version that can reserve upto 2GB of heap space.
9671
f7ff1b0f 96722011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9673
9674 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9675
639c109b
TZ
96762011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9677
9678 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9679 `gnutls_certificate_set_x509_key_file'.
9680
d2127135
JB
96812011-05-05 Juanma Barranquero <lekktu@gmail.com>
9682
9683 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9684 Update dependencies.
9685
e968f4f3
JB
96862011-05-04 Juanma Barranquero <lekktu@gmail.com>
9687
9688 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9689 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9690 Remove unused parameter `fildes'.
9691 * process.c (read_process_output, send_process): Don't pass it.
9692
84d358f0
JB
96932011-05-04 Juanma Barranquero <lekktu@gmail.com>
9694
9695 Fix previous change: the library cache is defined in w32.c.
9696 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9697 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9698
0898ca10
JB
96992011-05-04 Juanma Barranquero <lekktu@gmail.com>
9700
9701 Implement dynamic loading of GnuTLS on Windows.
9702
9703 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9704 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9705 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9706 Declare.
9707
9708 * gnutls.c (Qgnutls_dll): Define.
9709 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9710 (gnutls_*): Declare function pointers.
9711 (init_gnutls_functions): New function to initialize function pointers.
9712 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9713 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9714 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9715 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9716 (emacs_gnutls_write, emacs_gnutls_read)
9717 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9718 (Fgnutls_available_p): New function.
9719 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9720 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9721 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9722
9723 * image.c: Include w32.h.
9724 (Vimage_type_cache): Delete.
9725 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9726 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9727 (w32_delayed_load): Move to w32.c.
9728
9729 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9730
9731 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9732 (w32_delayed_load): Move from image.c. When loading a library, record
9733 its filename in the :loaded-from property of the library id.
9734 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9735 Initialize and staticpro them.
9736 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9737
9738 * process.c: Include lisp.h before w32.h, not after.
9739 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9740 instead of gnutls_record_check_pending.
9741
9742 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9743
ff4de4aa
TZ
97442011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9745
9746 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9747 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9748 as passed in.
9749
abe95abb
JD
97502011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9751
9752 * xterm.c (x_set_frame_alpha): Do not set property on anything
9753 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9754
e16e55d4
JB
97552011-05-02 Juanma Barranquero <lekktu@gmail.com>
9756
9757 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9758
bafcf6a5
JB
97592011-05-02 Juanma Barranquero <lekktu@gmail.com>
9760
9761 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9762 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9763 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9764 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9765 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9766 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9767 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9768 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9769 (Qgnutls_bootprop_callbacks_verify): Make static.
9770
e7a6747f
AS
97712011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9772
19ed11ba
AS
9773 * callproc.c: Indentation fixup.
9774
e7a6747f 9775 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9776 (wait_for_termination, interruptible_wait_for_termination):
9777 Move after wait_for_termination_1.
e7a6747f 9778
1ef14cb4
LMI
97792011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9780
9781 * sysdep.c (interruptible_wait_for_termination): New function
9782 which is like wait_for_termination, but allows keyboard
9783 interruptions.
9784
9785 * callproc.c (Fcall_process): Add (:file "file") as an option for
9786 the STDOUT buffer.
9787 (Fcall_process_region): Ditto.
9788
330d880c
EZ
97892011-04-30 Eli Zaretskii <eliz@gnu.org>
9790
8db90b73
EZ
9791 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9792 rather than `XVECTOR (FOO)->size'.
9793
330d880c
EZ
9794 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9795 inttypes.h, as a gnulib replacement is used if it not available in
9796 system headers.
9797
15cbd324
EZ
97982011-04-21 Eli Zaretskii <eliz@gnu.org>
9799
9800 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9801 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9802 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9803
9804 * coding.c (coding_alloc_by_realloc): Error out if destination
9805 will grow beyond MOST_POSITIVE_FIXNUM.
9806 (decode_coding_emacs_mule): Abort if there isn't enough place in
9807 charbuf for the composition carryover bytes. Reserve an extra
9808 space for up to 2 characters produced in a loop.
9809 (decode_coding_iso_2022): Abort if there isn't enough place in
9810 charbuf for the composition carryover bytes.
9811
98122011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9813
ae940cca
EZ
9814 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9815 aborting when %lld or %lll format is passed.
9816 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9817 %llo or %llx format is passed. (Bug#8545)
9818
03ab8921
EZ
9819 * window.c (window_scroll_line_based): Use a marker instead of
9820 simple variables to record original value of point. (Bug#7952)
9821
afda1437
EZ
9822 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9823 produced by %s or %c overflows available buffer space. (Bug#8545)
9824
f76dee0c
PE
98252011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9826
9827 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9828 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9829
fdc5744d
JB
98302011-04-28 Juanma Barranquero <lekktu@gmail.com>
9831
9832 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9833
638f053a
JB
98342011-04-28 Juanma Barranquero <lekktu@gmail.com>
9835
9836 * keyboard.c (Qdelayed_warnings_hook): Define.
9837 (command_loop_1): Run `delayed-warnings-hook'
9838 if Vdelayed_warnings_list is non-nil.
9839 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9840 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9841
d178f871
EZ
98422011-04-28 Eli Zaretskii <eliz@gnu.org>
9843
9844 * doprnt.c (doprnt): Don't return value smaller than the buffer
9845 size if the message was truncated. (Bug#8545).
9846
b124fd93
JB
98472011-04-28 Juanma Barranquero <lekktu@gmail.com>
9848
9849 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9850 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9851
e810457d
PE
98522011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9853
9854 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9855
ea51cceb
JB
98562011-04-27 Juanma Barranquero <lekktu@gmail.com>
9857
9858 * makefile.w32-in: Update dependencies.
9859
94dcfacf
EZ
98602011-04-27 Eli Zaretskii <eliz@gnu.org>
9861
9862 Improve `doprnt' and its usage. (Bug#8545)
9863 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9864 `format_end'. Remove support for %l as a conversion specifier.
9865 Don't use xrealloc. Improve diagnostics when the %l size modifier
9866 is used. Update the commentary.
9867
9868 * eval.c (verror): Simplify calculation of size_t.
9869
9870 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9871 messages.
9872
f61f41d7
PE
98732011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9874
9875 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9876 change.
9877
96fb4434
PE
98782011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9879
9880 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9881 This makes this file independent of the recent pseudovector change.
9882
671875da 98832011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9884
69e9b5a3
PE
9885 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9886
b5f869a7 9887 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9888 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9889 Remove unused local.
c8926152 9890 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9891
841a1577 9892 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9893 GCC 4.6.0 optimizes based on type-based alias analysis.
9894 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9895 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9896 != &v->size, and therefore "v->size = 1; b->size = 2; return
9897 v->size;" must therefore return 1. This assumption is incorrect
9898 for Emacs, since it type-puns struct Lisp_Vector * with many other
9899 types. To fix this problem, this patch adds a new type struct
f904488f 9900 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
9901 and pseudovectors, and helps optimizing compilers not get fooled
9902 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9903 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
9904 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9905 the size member.
eab3844f
PE
9906 (XSETPVECTYPE): Rewrite in terms of new macro.
9907 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9908 This is a bit clearer, and further avoids the possibility of
9909 undesirable aliasing.
9910 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9911 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9912 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9913 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9914 (ASIZE): Now uses header.size rather than size.
9915 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9916 to avoid the hassle of writing XVECTOR (foo)->header.size.
9917 (struct vectorlike_header): New type.
eab3844f
PE
9918 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9919 object, to help avoid aliasing.
9920 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9921 (SUBRP): Likewise, since Lisp_Subr is a special case.
9922 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9923 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9924 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 9925 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
9926 changed to be "header.size" and "header.next".
9927 * buffer.h (struct buffer): Likewise.
9928 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9929 * frame.h (struct frame): Likewise.
9930 * process.h (struct Lisp_Process): Likewise.
9931 * termhooks.h (struct terminal): Likewise.
9932 * window.c (struct save_window_data, struct saved_window): Likewise.
9933 * window.h (struct window): Likewise.
9934 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9935 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9936 * buffer.c (init_buffer_once): Likewise.
9937 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9938 special case.
9939 * process.c (Fformat_network_address): Use local var for size,
9940 for brevity.
9941
0df1eac5
PE
9942 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9943
847ab9d1 9944 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
9945 * data.c (atof): Remove decl; no longer used or needed.
9946 (digit_to_number): Move to lread.c.
9947 (Fstring_to_number): Use new string_to_number function, to be
9948 consistent with how the Lisp reader treats infinities and NaNs.
9949 Do not assume that floating-point numbers represent EMACS_INT
9950 without losing information; this is not true on most 64-bit hosts.
9951 Avoid double-rounding errors, by insisting on integers when
9952 parsing non-base-10 numbers, as the documentation specifies.
9953 * lisp.h (string_to_number): New decl, replacing ...
9954 (isfloat_string): Remove.
bc0a5c13 9955 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9956 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9957 appears to have been a coding error. Similarly, do not accept
9958 strings like +-1e0 as floating point numbers. Do not report
9959 overflow for integer overflows unless the base is not 10 which
9960 means we have no simple and reliable way to continue.
9961 Break out the floating-point parsing into a new
9962 function string_to_number, so that Fstring_to_number parses
9963 floating point numbers consistently with the Lisp reader.
04f2d78b 9964 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9965 (E_CHAR, EXP_INT): Remove, replacing with ...
9966 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9967 (string_to_number): New function, replacing isfloat_string.
9968 This function checks for valid syntax and produces the resulting
9969 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9970 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9971 so that overflow for non-base-10 numbers is reported only when
9972 there's no portable and simple way to convert to floating point.
452f4150 9973
67769ffc
PE
9974 * textprop.c (set_text_properties_1): Rewrite for clarity,
9975 and to avoid GCC warning about integer overflow.
9976
c20db43f
PE
9977 * intervals.h (struct interval): Use EMACS_INT for members
9978 where EMACS_UINT might cause problems. See
9979 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9980 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9981 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9982 All uses changed.
37aa2f85
PE
9983 (offset_intervals): Tell GCC not to worry about length overflow
9984 when negating a negative length.
c20db43f 9985
2538aa2f
PE
9986 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9987 (overrun_check_free): Likewise.
9988
f2d3008d
PE
9989 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9990 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9991 word size.
9992
ec8df744
PE
9993 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9994 (gnutls_make_error): Rename local to avoid shadowing.
9995 (gnutls_emacs_global_deinit): ifdef out; not used.
9996 (Fgnutls_boot): Use const for pointer to readonly storage.
9997 Comment out unused local. Fix pointer signedness problems.
9998
640ee02d
PE
9999 * lread.c (openp): Don't stuff size_t into an 'int'.
10000 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10001 about possible signed overflow.
10002
6048fb2a
PE
10003 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10004 (GDK_KEY_g): Don't define if already defined.
10005 (xg_prepare_tooltip): Avoid pointer signedness problem.
10006 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10007
fa3c87e1
PE
10008 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10009 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10010
2172544b
PE
10011 * xfns.c (Fx_window_property): Simplify a bit,
10012 to make a bit faster and to avoid GCC 4.6.0 warning.
10013 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10014
9b821a21
PE
10015 * fns.c (internal_equal): Don't assume size_t fits in int.
10016
3c616cfa
PE
10017 * alloc.c (compact_small_strings): Tighten assertion a little.
10018
c2982e87
PE
10019 Replace pEd with more-general pI, and fix some printf arg casts.
10020 * lisp.h (pI): New macro, generalizing old pEd macro to other
10021 conversion specifiers. For example, use "...%"pI"d..." rather
10022 than "...%"pEd"...".
10023 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10024 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10025 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10026 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10027 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10028 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10029 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10030 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10031 64-bit hosts.
10032 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10033 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10034 * print.c (safe_debug_print, print_object): Likewise.
10035 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10036 to int.
6f04d126
PE
10037 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10038 avoiding the 0 flag, which is not portable.
c2982e87
PE
10039 * process.c (Fmake_network_process): Use pI to avoid cast.
10040 * region-cache.c (pp_cache): Likewise.
10041 * xdisp.c (decode_mode_spec): Likewise.
10042 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10043 behavior on 64-bit hosts with printf arg.
6f04d126 10044 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10045 (x_stop_queuing_selection_requests): Likewise.
10046 (x_get_window_property): Don't truncate byte count to an 'int'
10047 when tracing.
0b432f21 10048
5e073ec7
PE
10049 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10050 here, since it parses constructs like leading '-' and spaces,
10051 which are not wanted; and it overflows with large numbers.
10052 Instead, simply match F[0-9]+, which is what is wanted anyway.
10053
36372bf9
PE
10054 * alloc.c: Remove unportable assumptions about struct layout.
10055 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10056 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10057 (allocate_vectorlike, make_pure_vector): Use the new macros,
10058 plus offsetof, to remove unportable assumptions about struct layout.
10059 These assumptions hold on all porting targets that I know of, but
10060 they are not guaranteed, they're easy to remove, and removing them
10061 makes further changes easier.
10062
0b432f21
PE
10063 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10064 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10065 (string_overrun_cookie): Now const. Use initializers that
10066 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10067 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10068 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10069 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10070 multiple of sizeof (EMACS_INT); it need not be, if
10071 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10072 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10073
895009e1
JB
100742011-04-26 Juanma Barranquero <lekktu@gmail.com>
10075
10076 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10077
6a7a1b0b
TZ
100782011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10079
10080 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10081 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10082 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10083
841a1577 100842011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10085
10086 * lisp.h (Qdebug): List symbol.
895009e1 10087 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10088 * keyboard.c (debug-on-event): New variable.
10089 (handle_user_signal): Break into debugger when debug-on-event
10090 matches the current signal symbol.
10091
f2d3ba6f
DN
100922011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10093
10094 * alloc.c (check_sblock, check_string_bytes)
10095 (check_string_free_list): Convert to standard C.
10096
42ce4c63
TZ
100972011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10098
10099 * w32.c (emacs_gnutls_push): Fix typo.
10100
825cd63c
EZ
101012011-04-25 Eli Zaretskii <eliz@gnu.org>
10102
fb11d64d
EZ
10103 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10104 "cast to pointer from integer of different size".
10105
825cd63c
EZ
10106 Improve doprnt and its use in verror. (Bug#8545)
10107 * doprnt.c (doprnt): Document the set of format control sequences
10108 supported by the function. Use SAFE_ALLOCA instead of always
10109 using `alloca'.
10110
10111 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10112 is one byte too soon. Don't use xrealloc; instead xfree and
10113 xmalloc anew.
10114
e061a11b
TZ
101152011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10116
10117 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10118 callbacks stage.
10119
10120 * gnutls.c: Renamed global_initialized to
10121 gnutls_global_initialized. Added internals for the
10122 :verify-hostname-error, :verify-error, and :verify-flags
10123 parameters of `gnutls-boot' and documented those parameters in the
10124 docstring. Start callback support.
9173deec
JB
10125 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10126 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10127 on error. Return error code.
e061a11b
TZ
10128 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10129 (emacs_gnutls_read): Likewise.
10130 (Fgnutls_boot): Return handshake error code.
10131 (emacs_gnutls_handle_error): New function.
10132 (wsaerror_to_errno): Likewise.
10133
10134 * w32.h (emacs_gnutls_pull): Add prototype.
10135 (emacs_gnutls_push): Likewise.
10136
10137 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10138 (emacs_gnutls_push): Likewise.
10139
101402011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10141
10142 * process.c (wait_reading_process_output): Check if GnuTLS
10143 buffered some data internally if no FDs are set for TLS
10144 connections.
10145
10146 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10147 (LIBS): Link to USER_LIBS.
10148 ($(BLD)/gnutls.$(0)): New target.
10149
fa6996bc
EZ
101502011-04-24 Eli Zaretskii <eliz@gnu.org>
10151
eb35682e
EZ
10152 * xdisp.c (handle_single_display_spec): Rename the
10153 display_replaced_before_p argument into display_replaced_p, to
10154 make it consistent with the commentary. Fix typos in the
10155 commentary.
10156
e2ad650c
EZ
10157 * textprop.c (syms_of_textprop): Remove dead code.
10158 (copy_text_properties): Delete obsolete commentary about an
10159 interface that was deleted long ago. Fix typos in the description
10160 of arguments.
10161
1b2de274
EZ
10162 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10163 to changes in oldXMenu/XMenu.h from 2011-04-16.
10164 <menu_help_message, prev_menu_help_message>: Constify.
10165 (IT_menu_make_room): menu->help_text is now `const char **';
10166 adjust.
10167
10168 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10169 to changes in oldXMenu/XMenu.h from 2011-04-16.
10170 (struct XMenu): Declare `help_text' `const char **'.
10171
10172 * xfaces.c <Qunspecified>: Make extern again.
10173
10174 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10175 required by POSIX.
1b2de274 10176
762b15be
EZ
10177 * doc.c (get_doc_string): Improve the format passed to `error'.
10178
10179 * doprnt.c (doprnt): Improve commentary.
10180
10181 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10182
10183 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10184 them with etags.
10185
f1052e5d
EZ
10186 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10187 changes in globals.h immediately force recompilation.
762b15be
EZ
10188 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10189 $(CURDIR)/s/ms-w32.h.
10190 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10191
fa6996bc
EZ
10192 * character.c (Fchar_direction): Function deleted.
10193 (syms_of_character): Don't defsubr it.
10194 <char-direction-table>: Deleted.
10195
e6c3da20
EZ
101962011-04-23 Eli Zaretskii <eliz@gnu.org>
10197
10198 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10199 * doprnt.c: Include limits.h.
10200 (SIZE_MAX): New macro.
04f2d78b
CB
10201 (doprnt): Return a size_t value. 2nd arg is now size_t.
10202 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10203 Improve overflow protection. Support `l' modifier for integer
10204 conversions. Support %l conversion. Don't assume an EMACS_INT
10205 argument for integer conversions and for %c.
10206
10207 * lisp.h (doprnt): Restore prototype.
10208
10209 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10210 $(SRC)/character.h.
10211
10212 * Makefile.in (base_obj): Add back doprnt.o.
10213
10214 * deps.mk (doprnt.o): Add back prerequisites.
10215 (callint.o): Depend on character.h.
10216
10217 * eval.c (internal_lisp_condition_case): Include the handler
10218 representation in the error message.
10219 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10220 when breaking from the loop.
10221
10222 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10223
10224 * callint.c (Fcall_interactively): When displaying error message
10225 about invalid control letter, pass the character's codepoint, not
10226 a pointer to its multibyte form. Improve display of the character
10227 in octal and display also its hex code.
10228
10229 * character.c (char_string): Use %x to display the (unsigned)
10230 codepoint of an invalid character, to avoid displaying a bogus
10231 negative value.
10232
10233 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10234 `error', not SYMBOL_NAME itself.
10235
10236 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10237 character arguments to `error'.
10238
10239 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10240 to `error' in error message about FINAL_CHAR argument. Make sure
10241 FINAL_CHAR is a character, and use %c when it is passed as
10242 argument to `error'.
10243
4ffd0d6b 102442011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
10245
10246 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10247
10248 * w32.c: Include <time.h>.
10249 (sys_localtime): New function.
10250
4ffd0d6b 102512011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
10252
10253 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10254
4ffd0d6b 10255 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 10256
4ffd0d6b 102572011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 10258
4ffd0d6b
GM
10259 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10260 zombies (Bug#8467).
aac0c6e3 10261
04c56954
EZ
102622011-04-19 Eli Zaretskii <eliz@gnu.org>
10263
10264 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10265 gl_state.e_property when gl_state.object is Qt.
10266
10267 * insdel.c (make_gap_larger): Remove limitation of buffer size
10268 to <= INT_MAX.
10269
16a43933
CY
102702011-04-18 Chong Yidong <cyd@stupidchicken.com>
10271
10272 * xdisp.c (lookup_glyphless_char_display)
10273 (produce_glyphless_glyph): Handle cons cell entry in
10274 glyphless-char-display.
10275 (Vglyphless_char_display): Document it.
10276
10277 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10278 glyphless-char-display.
10279
4581706e
CY
102802011-04-17 Chong Yidong <cyd@stupidchicken.com>
10281
10282 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10283
10284 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10285
10286 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10287 definition for no-X builds.
10288
4887c6e2 102892011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 10290
fd35b6f9
PE
10291 Static checks with GCC 4.6.0 and non-default toolkits.
10292
5c1ccb01
PE
10293 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10294
006c5daa
PE
10295 * process.c (keyboard_bit_set): Define only if SIGIO.
10296 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10297 (send_process): Repair possible setjmp clobbering.
10298
efc736d3
PE
10299 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10300
4e2fe2e6
PE
10301 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10302
f97334a2
PE
10303 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10304
4e75f29d
PE
10305 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10306 Define only if needed.
10307
90efadd1
PE
10308 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10309 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 10310 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 10311
3c647824
PE
10312 * dispextern.h (struct redisplay_interface): Rename param
10313 to avoid shadowing.
e264f262 10314 * termhooks.h (struct terminal): Likewise.
761383f4 10315 * xterm.c (xembed_send_message): Likewise.
3c647824 10316
b58c5c4a
PE
10317 * insdel.c (make_gap_smaller): Define only if
10318 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10319
cad59032
PE
10320 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10321 it.
10322
c339dc2e
PE
10323 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10324 so that we aren't warned about unused symbols.
10325
91a3e27b
PE
10326 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10327
399c71d3 10328 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10329
8ffc96f5
PE
10330 * xfns.c (x_real_positions): Mark locals as initialized.
10331
eef9bc79
PE
10332 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10333
098db9dd
PE
10334 * xterm.c: Fix problems found by static analysis with other toolkits.
10335 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10336 (x_dispatch_event): Declare static if USE_GTK, and
10337 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10338 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10339 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10340 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10341 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10342
eb18f6cc
PE
10343 * xmenu.c (menu_help_callback): Pointer type fixes.
10344 Use const pointers when pointing at readonly data. Avoid pointer
10345 signedness clashes.
10346 (FALSE): Remove unused macro.
10347 (update_frame_menubar): Remove unused decl.
10348
1fe72bf8
PE
10349 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10350
60d9e1db
PE
10351 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10352 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10353 (single_menu_item): Rename local to avoid shadowing.
10354
39261c26
PE
10355 * keyboard.c (make_lispy_event): Remove unused local var.
10356
018c5e19
PE
10357 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10358 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10359
63d2b86e
PE
10360 * bitmaps: Change bitmaps from unsigned char back to the X11
10361 compatible char. Avoid the old compiler warnings about
10362 out-of-range initializers by using, for example, '\xab' rather
10363 than 0xab.
10364
aefd87e1
PE
10365 * xgselect.c (xgselect_initialize): Check vs interface
10366 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10367
bf501fb9
PE
10368 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10369
e9829fdf
PE
10370 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10371 to read-only memory.
10372
1086c095
PE
10373 * fns.c (vector): Remove; this old hack is no longer needed.
10374
2baccd04 10375 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10376 Remove unused var.
dde42981 10377 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10378
72391843 10379 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10380
436c16df 10381 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10382 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10383 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10384
92bb796d 10385 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10386 (x_term_init): Remove local to avoid shadowing.
92bb796d 10387
764430a3 10388 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10389
10390 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10391 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10392
d1dfb56c
EZ
103932011-04-16 Eli Zaretskii <eliz@gnu.org>
10394
c4354cb4
EZ
10395 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10396
d1dfb56c
EZ
10397 Fix regex.c, syntax.c and friends for buffers > 2GB.
10398 * syntax.h (struct gl_state_s): Declare character position members
10399 EMACS_INT.
10400
10401 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10402
04f2d78b
CB
10403 * textprop.c (verify_interval_modification, interval_of):
10404 Declare arguments EMACS_INT.
d1dfb56c
EZ
10405
10406 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10407 EMACS_INT.
10408
10409 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10410
10411 * indent.c (Fvertical_motion): Local variable it_start is now
10412 EMACS_INT.
10413
10414 * regex.c (re_match, re_match_2, re_match_2_internal)
10415 (bcmp_translate, regcomp, regexec, print_double_string)
10416 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10417 (re_compile_pattern, re_exec): Declare arguments and local
10418 variables `size_t' and `ssize_t' and return values `regoff_t', as
10419 appropriate.
10420 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10421 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10422 <compile_stack_type>: `size' and `avail' are now `size_t'.
10423
10424 * regex.h <regoff_t>: Use ssize_t, not int.
10425 (re_search, re_search_2, re_match, re_match_2): Arguments that
10426 specify buffer/string position and length are now ssize_t and
10427 size_t. Return type is regoff_t.
10428
613052cd
BK
104292011-04-16 Ben Key <bkey76@gmail.com>
10430
10431 * nsfont.m: Fixed bugs in ns_get_family and
10432 ns_descriptor_to_entity that were caused by using free to
10433 deallocate memory blocks that were allocated by xmalloc (via
10434 xstrdup). This caused Emacs to crash when compiled with
10435 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10436 --enable-checking=xmallocoverrun). xfree is now used to
10437 deallocate these memory blocks.
10438
4170f62f 104392011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10440
71b41406
PE
10441 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10442
9587a89d
PE
10443 emacs_write: Accept and return EMACS_INT for sizes.
10444 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10445 et seq.
10446 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10447 Accept and return EMACS_INT.
10448 (emacs_gnutls_write): Return the number of bytes written on
10449 partial writes.
10450 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10451 (emacs_read, emacs_write): Remove check for negative size, as the
10452 Emacs source code has been audited now.
9587a89d
PE
10453 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10454 (emacs_read, emacs_write): Use it.
273a5f82
PE
10455 * process.c (send_process): Adjust to the new signatures of
10456 emacs_write and emacs_gnutls_write. Do not attempt to store
10457 a byte offset into an 'int'; it might overflow.
9587a89d 10458 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10459
3e047f51
PE
10460 * sound.c: Don't assume sizes fit in 'int'.
10461 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10462 Return EMACS_INT, not int.
3e047f51 10463 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10464 Accept EMACS_INT, not int.
10465 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10466 record read return values.
10467
cc39a9db
BK
104682011-04-15 Ben Key <bkey76@gmail.com>
10469
c9d0ec6d
JB
10470 * keyboard.c (Qundefined): Don't declare static since it is used
10471 in nsfns.m.
10472 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10473 static since they are used in nsfont.m.
cc39a9db 10474
6c60eb9f
SM
104752011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10476
10477 * process.c (Qprocessp): Don't declare static.
10478 * lisp.h (Qprocessp): Declare again.
10479
7990b61a
JB
104802011-04-15 Juanma Barranquero <lekktu@gmail.com>
10481
10482 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10483
5d4cb038
PE
104842011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10485
8bd7b830 10486 Improve C-level modularity by making more things 'static'.
cd64ea1d 10487
e3b27b31
PE
10488 Don't publish debugger-only interfaces to other modules.
10489 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10490 (verify_bytepos, count_markers): Move decls to the only modules
10491 that need them.
10492 * region-cache.h (pp_cache): Likewise.
10493 * window.h (check_all_windows): Likewise.
10494 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10495
5d4cb038
PE
10496 * sysdep.c (croak): Now static, if
10497 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10498 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10499
10500 * alloc.c (refill_memory_reserve): Now static if
10501 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10502 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10503
e87b6180
PE
10504 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10505 Define only if USE_LUCID.
10506
ac64929e
PE
10507 * xrdb.c (x_customization_string, x_rm_string): Now static.
10508
6f37259d
PE
10509 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10510 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10511
1683e3ab
PE
10512 * xdisp.c (draw_row_with_mouse_face): Now static.
10513 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10514
de9c2632
PE
10515 * window.h (check_all_windows): Mark externally visible.
10516
2b96acb7
PE
10517 * window.c (window_deletion_count): Now static.
10518
10519 * undo.c: Make symbols static if they're not exported.
10520 (last_undo_buffer, last_boundary_position, pending_boundary):
10521 Now static.
10522
50436f33
PE
10523 * textprop.c (interval_insert_behind_hooks): Now static.
10524 (interval_insert_in_front_hooks): Likewise.
10525
64520e5c
PE
10526 * term.c: Make symbols static if they're not exported.
10527 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10528 (max_frame_lines, tty_set_terminal_modes):
10529 (tty_reset_terminal_modes, tty_turn_off_highlight):
10530 (get_tty_terminal): Now static.
10531 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10532 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10533 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10534 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10535 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10536
1fa53021
PE
10537 * sysdep.c: Make symbols static if they're not exported.
10538 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10539 Now static.
10540 (sigprocmask_set, full_mask): Remove; unused.
10541 (wait_debugging): Mark as visible.
10542 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10543 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10544
d4b43b22
PE
10545 * syntax.c (syntax_temp): Define only if !__GNUC__.
10546
b7c513d0
PE
10547 * sound.c (current_sound_device, current_sound): Now static.
10548
989b29ad
PE
10549 * search.c (searchbufs, searchbuf_head): Now static.
10550
13a55a78
PE
10551 * scroll.c (scroll_cost): Remove; unused.
10552 * dispextern.h (scroll_cost): Remove decl.
10553
de68a1fc
PE
10554 * region-cache.h (pp_cache): Mark as externally visible.
10555
40ccffa6
PE
10556 * process.c: Make symbols static if they're not exported.
10557 (process_tick, update_tick, create_process, chan_process):
10558 (Vprocess_alist, proc_buffered_char, datagram_access):
10559 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10560 (deactivate_process): Mark defn as static, as well as decl.
10561 * lisp.h (create_process): Remove decl.
10562 * process.h (chan_process, Vprocess_alist): Remove decls.
10563
ad64fc97
PE
10564 * print.c: Make symbols static if they're not exported.
10565 (print_depth, new_backquote_output, being_printed, print_buffer):
10566 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10567 (print_interval, print_number_index, initial_stderr_stream):
10568 Now static.
10569 * lisp.h (Fprinc): Remove decl.
10570 (debug_output_compilation_hack): Mark as externally visible.
10571
adddb265
PE
10572 * sysdep.c (croak): Move decl from here to syssignal.h.
10573 * syssignal.h (croak): Put it here, so the API can be checked when
10574 'croak' is called from dissociate_if_controlling_tty.
10575
1717ede2
PE
10576 * minibuf.c: Make symbols static if they're not exported.
10577 (minibuf_save_list, choose_minibuf_frame): Now static.
10578 * lisp.h (choose_minibuf_frame): Remove decl.
10579
fa5fb2bc
PE
10580 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10581
1e3890d1
PE
10582 * lread.c: Make symbols static if they're not exported.
10583 (read_objects, initial_obarray, oblookup_last_bucket_number):
10584 Now static.
10585 (make_symbol): Remove; unused.
10586 * lisp.h (initial_obarray, make_symbol): Remove decls.
10587
8a1414fa
PE
10588 * keyboard.c: Make symbols static if they're not exported.
10589 (single_kboard, recent_keys_index, total_keys, recent_keys):
10590 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10591 (this_single_command_key_start, echoing, last_auto_save):
10592 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10593 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10594 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10595 (Vlispy_mouse_stem, double_click_count):
10596 Now static.
10597 (force_auto_save_soon): Define only if SIGDANGER.
10598 (ignore_mouse_drag_p): Now static if
10599 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10600 (print_help): Remove; unused.
10601 (stop_character, last_timer_event): Mark as externally visible.
10602 * keyboard.h (ignore_mouse_drag_p): Declare only if
10603 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10604 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10605 * lisp.h (echoing): Remove decl.
10606 (force_auto_save_soon): Declare only if SIGDANGER.
10607 * xdisp.c (redisplay_window): Simplify code, to make it more
10608 obvious that ignore_mouse_drag_p is not accessed if !defined
10609 USE_GTK && !defined HAVE_NS.
10610
93ea6e8f
PE
10611 * intervals.c: Make symbols static if they're not exported.
10612 (merge_properties_sticky, merge_interval_right, delete_interval):
10613 Now static.
10614 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10615
77382fcc
PE
10616 * insdel.c: Make symbols static if they're not exported.
10617 However, leave prepare_to_modify_buffer alone. It's never
10618 called from outside this function, but that appears to be a bug.
10619 (combine_after_change_list, combine_after_change_buffer):
4889fc82 10620 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
10621 (adjust_after_replace_noundo): Remove; unused.
10622 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 10623 (signal_before_change): Remove decls.
77382fcc 10624
9306c32e
PE
10625 * indent.c (val_compute_motion, val_vmotion): Now static.
10626
cd44d2eb
PE
10627 * image.c: Make symbols static if they're not exported.
10628 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10629 if USE_GTK.
10630 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10631 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10632
ad9a7a06
PE
10633 * fringe.c (standard_bitmaps): Now static.
10634 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10635
81626931
PE
10636 * frame.c: Make symbols static if they're not exported.
10637 (x_report_frame_params, make_terminal_frame): Now static.
10638 (get_frame_param): Now static, unless HAVE_NS.
10639 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10640 (x_get_resource_string): Remove; not used.
10641 * frame.h (make_terminal_frame, x_report_frame_params):
10642 (x_get_resource_string); Remove decls.
10643 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10644 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10645
239f9db9
PE
10646 * font.c, fontset.c: Make symbols static if they're not exported.
10647 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10648 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10649 * font.c (font_close_object): Now static.
10650 * font.h (font_close_object): Remove.
10651 * fontset.c (FONTSET_OBJLIST): Remove.
10652 (free_realized_fontset) #if-0 the body, which does nothing.
10653 (face_suitable_for_char_p): #if-0, as it's never called.
10654 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
10655 * xfaces.c (face_at_string_position):
10656 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
10657 since 0 is always ASCII.
10658
dfcf3579
PE
10659 * fns.c (weak_hash_tables): Now static.
10660
5045092b
PE
10661 * fileio.c: Make symbols static if they're not exported.
10662 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10663 (Vwrite_region_annotation_buffers): Now static.
10664
57a96f5c
PE
10665 * eval.c: Make symbols static if they're not exported.
10666 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10667 * lisp.h (backtrace_list): Remove decl.
10668
35f08c38
PE
10669 * emacs.c: Make symbols static if they're not exported.
10670 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10671 (fatal_error_code, fatal_error_signal_hook, standard_args):
10672 Now static.
10673 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10674 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10675 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10676 * lisp.h (fatal_error_signal_hook): Remove decl.
10677 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10678
f44bd759
PE
10679 * editfns.c: Move a (normally-unused) function to its only use.
10680 * editfns.c, lisp.h (get_operating_system_release): Remove.
10681 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10682 worth the hassle of breaking this out.
10683
b532497d
PE
10684 * xterm.c: Make symbols static if they're not exported.
10685 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10686 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10687 (x_destroy_window, x_delete_display):
10688 Now static.
10689 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10690 (x_mouse_leave): Remove; unused.
10691 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10692 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10693 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10694 Remove decls.
10695 (x_mouse_leave): Declare only if WINDOWSNT.
10696 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10697 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10698 USE_X_TOOLKIT.
10699
1675728f
PE
10700 * ftxfont.c: Make symbols static if they're not exported.
10701 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10702 HAVE_FREETYPE.
10703 * font.h (ftxfont_driver): Likewise.
10704
e4cebfca
PE
10705 * xfns.c: Make symbols static if they're not exported.
10706 (x_last_font_name, x_display_info_for_name):
10707 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10708 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10709 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10710 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10711 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10712 (last_show_tip_args): Now static.
10713 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10714 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10715 (x_screen_planes): Remove; unused.
10716 * dispextern.h (x_screen_planes): Remove decl.
10717
5bf46f05
PE
10718 * dispnew.c: Make symbols static if they're not exported.
10719 * dispextern.h (redraw_garbaged_frames, scrolling):
10720 (increment_row_positions): Remove.
10721 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10722 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10723 Now static.
10724 (redraw_garbaged_frames): Remove; unused.
10725
435f4c28
PE
10726 * xfaces.c: Make symbols static if they're not exported.
10727 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10728 Remove decls.
10729 * xterm.h (defined_color): Remove decls.
10730 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10731 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10732 (menu_face_changed_default, defined_color, free_realized_face):
10733 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10734 (ascii_face_of_lisp_face): Remove; unused.
10735
8524aef3
PE
10736 * xdisp.c: Make symbols static if they're not exported.
10737 * dispextern.h (scratch_glyph_row, window_box_edges):
10738 (glyph_to_pixel_coords, set_cursor_from_row):
10739 (get_next_display_element, set_iterator_to_next):
10740 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10741 (show_mouse_face): Remove decls
10742 * frame.h (message_buf_print): Likewise.
10743 * lisp.h (pop_message, set_message, check_point_in_composition):
10744 Likewise.
10745 * xterm.h (set_vertical_scroll_bar): Likewise.
10746 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10747 (message_buf_print, scratch_glyph_row, displayed_buffer):
10748 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10749 (get_next_display_element, show_mouse_face, window_box_edges):
10750 (frame_to_window_pixel_xy, check_point_in_composition):
10751 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10752 (glyph_to_pixel_coords): Remove; unused.
10753
16390cd2
PE
10754 * dired.c (file_name_completion): Now static.
10755
10756 * dbusbind.c (xd_in_read_queued_messages): Now static.
10757
a25f4dfa
PE
10758 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10759 * data.c (circular_list_error): Remove.
10760
14a9c8df
PE
10761 * commands.h (last_point_position, last_point_position_buffer):
10762 (last_point_position_window): Remove decls.
10763 * keyboard.c: Make these variables static.
10764
04f2d78b
CB
10765 * coding.h (coding, code_convert_region, encode_coding_gap):
10766 Remove decls.
74ab6df5
PE
10767 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10768 (iso_code_class, detect_coding, code_convert_region): Now static.
10769 (encode_coding_gap): Remove; unused.
10770
38dfbee1
PE
10771 * chartab.c (chartab_chars, chartab_bits): Now static.
10772
a2cb4e63
PE
10773 * charset.h (charset_iso_8859_1): Remove decl.
10774 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10775 Now static.
10776
127198fd
PE
10777 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10778 * ccl.c (Vccl_program_table): Now static.
10779 (check_ccl_update): Remove; unused.
10780
d85b608f
PE
10781 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10782 * category.h: ... from here.
10783 * category.c (check_category_table, set_category_set): Now static.
10784
31cd66f3
PE
10785 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10786 * lisp.h: Remove these decls.
10787
c358e587
PE
10788 * buffer.c (buffer_count): Remove unused var.
10789
e78aecca
PE
10790 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10791 so that it's not optimized away.
10792 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10793 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10794 exported only to the debugger.
10795
e192d7d3 10796 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10797 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10798
92470028
PE
10799 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10800 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10801 was inaccessible from Lisp.
10802 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10803 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10804
244ed907
PE
10805 alloc.c: Import and export fewer symbols, and remove unused items.
10806 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10807 is defined.
10808 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10809 it's not optimized away by whole-program optimization.
10810 (message_enable_multibyte, free_misc): Remove.
10811 (catchlist, handlerlist, mark_backtrace):
10812 Declare only if BYTE_MARK_STACK.
10813 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10814 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10815 (message_enable_multibyte): Remove decl.
10816 (free_misc, interval_free_list, float_block, float_block_index):
10817 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10818 (cons_free_list, last_marked_index):
10819 Now static.
10820 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10821 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10822 (mark_backtrace): Define only if BYTE_MARK_STACK.
10823 * xdisp.c (message_enable_multibyte): Now static.
10824
61c2b50e 10825 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10826 This makes it easier for human readers (and static analyzers)
10827 to see whether these variables are used from other modules.
10828 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10829 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10830 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10831 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10832 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10833 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10834 * xmenu.c, xselect.c:
10835 Declare Q* vars static if they are not used in other modules.
10836 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10837 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10838 Remove decls of unexported vars.
10839 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10840
95c82688
PE
10841 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10842
16a97296
PE
10843 Make Emacs functions such as Fatom 'static' by default.
10844 This makes it easier for human readers (and static analyzers)
10845 to see whether these functions can be called from other modules.
10846 DEFUN now defines a static function. To make the function external
10847 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10848 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10849 (Finit_image_library):
16a97296
PE
10850 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10851 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10852 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10853 Remove decls, since these functions are now static.
10854 (Funintern, Fget_internal_run_time): New decls, since these functions
10855 were already external.
95c82688 10856
16a97296
PE
10857 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10858 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10859 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10860 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10861 * keyboard.c, keymap.c, lread.c:
10862 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10863 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10864 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10865 Mark functions with DEFUE instead of DEFUN,
10866 if they are used in other modules.
10867 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10868 decls for now-static functions.
10869 * buffer.h (Fdelete_overlay): Remove decl.
10870 * callproc.c (Fgetenv_internal): Mark as internal.
10871 * composite.c (Fremove_list_of_text_properties): Remove decl.
10872 (Fcomposition_get_gstring): New forward static decl.
10873 * composite.h (Fcomposite_get_gstring): Remove decl.
10874 * dired.c (Ffile_attributes): New forward static decl.
10875 * doc.c (Fdocumntation_property): New forward static decl.
10876 * eval.c (Ffetch_bytecode): New forward static decl.
10877 (Funintern): Remove extern decl; now in .h file where it belongs.
10878 * fileio.c (Fmake_symbolic_link): New forward static decl.
10879 * image.c (Finit_image_library): New forward static decl.
10880 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10881 * intervals.h (Fprevious_property_change):
10882 (Fremove_list_of_text_properties): Remove decls.
10883 * keyboard.c (Fthis_command_keys): Remove decl.
10884 (Fcommand_execute): New forward static decl.
10885 * keymap.c (Flookup_key): New forward static decl.
10886 (Fcopy_keymap): Now static.
10887 * keymap.h (Flookup_key): Remove decl.
10888 * process.c (Fget_process): New forward static decl.
10889 (Fprocess_datagram_address): Mark as internal.
10890 * syntax.c (Fsyntax_table_p): New forward static decl.
10891 (skip_chars): Remove duplicate decl.
10892 * textprop.c (Fprevious_property_change): New forward static decl.
10893 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10894 Now internal.
10895 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10896 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10897
785bbd42
PE
10898 * editfns.c (Fformat): Remove unreachable code.
10899
8b913b57
AS
109002011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10901
10902 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10903 change. (Bug#8496)
10904
a6744a35
EZ
109052011-04-13 Eli Zaretskii <eliz@gnu.org>
10906
10907 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10908 when at ZV. (Bug#8487)
10909
e7974947
AS
109102011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10911
baad03f0
AS
10912 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10913 (Bug#8437)
10914 * keyboard.c (parse_tool_bar_item): Likewise.
10915 * sound.c (sound_cleanup, alsa_close): Likewise.
10916 * termcap.c (tgetent): Likewise.
10917 * xfns.c (x_default_font_parameter): Likewise.
10918 * xsettings.c (read_and_apply_settings): Likewise.
10919
e7974947
AS
10920 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10921 (overrun_check_free): Protoize.
10922
28272684
PE
109232011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10924
10925 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10926 since callers should never pass a negative size.
10927 Change the signature to match that of plain 'read' and 'write'; see
10928 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10929 * lisp.h: Update prototypes of emacs_write and emacs_read.
10930
11997c76
EZ
109312011-04-11 Eli Zaretskii <eliz@gnu.org>
10932
10933 * xdisp.c (redisplay_window): Don't try to determine the character
10934 position of the scroll margin if the window start point w->startp
e896f03c 10935 is outside the buffer's accessible region. (Bug#8468)
11997c76 10936
8a2cbd72
EZ
109372011-04-10 Eli Zaretskii <eliz@gnu.org>
10938
10939 Fix write-region and its subroutines for buffers > 2GB.
10940 * fileio.c (a_write, e_write): Modify declaration of arguments and
10941 local variables to support buffers larger than 2GB.
10942 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10943
10944 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10945 argument, local variables, and return value.
10946
10947 * lisp.h: Update prototypes of emacs_write and emacs_read.
10948
10949 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10950
4073e537 109512011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10952
1ebfdcb6
PE
10953 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10954
b2ded58d
PE
10955 Fix more problems found by GCC 4.6.0's static checks.
10956
7d66342c
PE
10957 * xdisp.c (vmessage): Use a better test for character truncation.
10958
bbf47d44
PE
10959 * charset.c (load_charset_map): <, not <=, for optimization,
10960 and to avoid potential problems with integer overflow.
9248994d 10961 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10962 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10963 * editfns.c (Fformat): Likewise.
1e69125e 10964 * syntax.c (skip_chars): Likewise.
3befa583 10965
e3019616
PE
10966 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10967 This also lets GCC 4.6.0 generate slightly better loop code.
10968
becfa255
PE
10969 * callint.c (Fcall_interactively): <, not <=, for optimization.
10970 (Fcall_interactively): Count the number of arguments produced,
10971 not the number of arguments given. This is simpler and lets GCC
10972 4.6.0 generate slightly better code.
10973
dae0cd48
PE
10974 * ftfont.c: Distingish more carefully between FcChar8 and char.
10975 The previous code passed unsigned char * to a functions like
10976 strlen and xstrcasecmp that expect char *, which does not
10977 conform to the C standard.
10978 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10979 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10980 char * when the C standard requires it.
10981
76032d70
PE
10982 * keyboard.c (read_char): Remove unused var.
10983
eb3f1cc8
PE
10984 * eval.c: Port to Windows vsnprintf (Bug#8435).
10985 Include <limits.h>.
10986 (SIZE_MAX): Define if the headers do not.
10987 (verror): Do not give up if vsnprintf returns a negative count.
10988 Instead, grow the buffer. This ports to Windows vsnprintf, which
10989 does not conform to C99. Problem reported by Eli Zaretskii.
10990 Also, simplify the allocation scheme, by avoiding the need for
10991 calling realloc, and removing the ALLOCATED variable.
10992
70476b54
PE
10993 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10994
12020a9e
PE
10995 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10996 But keep the doprint source code for now, as we might revamp it
10997 and use it again (Bug#8435).
ea6c7ae6
PE
10998 * lisp.h (doprnt): Remove.
10999 * Makefile.in (base_obj): Remove doprnt.o.
11000 * deps.mk (doprnt.o): Remove.
11001
5fdb398c
PE
11002 error: Print 32- and 64-bit integers portably (Bug#8435).
11003 Without this change, on typical 64-bit hosts error ("...%d...", N)
11004 was used to print both 32- and 64-bit integers N, which relied on
11005 undefined behavior.
61bdb816 11006 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11007 * lisp.h (error, verror): Mark as printf-like functions.
11008 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11009 Report overflow in size calculations when allocating printf buffer.
11010 Do not truncate output string at its first null byte.
11011 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11012 Truncate the output at a character boundary, since vsnprintf does not
11013 do that.
11014 * charset.c (check_iso_charset_parameter): Convert internal
11015 character to string before calling 'error', since %c now has the
11016 printf meaning.
11017 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11018 overflow when computing char to be passed to 'error'. Do not
11019 pass Lisp_Object to 'error'; pass the integer instead.
11020 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11021 formatted with plain %d.
11022
b189fa66
PE
11023 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11024
bff87ef0
PE
11025 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11026
7e2cac20
PE
11027 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11028
ce4d90b5
PE
11029 * xterm.c (x_catch_errors): Remove duplicate declaration.
11030
266c9547
PE
11031 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11032
79c49ad2
PE
11033 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11034
368f4090
JM
110352011-04-10 Jim Meyering <meyering@redhat.com>
11036
11037 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11038 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11039 return ssize_t not "int", and use size_t as the buffer length.
11040 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11041 * gnutls.h: Update declarations.
11042 * process.c (read_process_output): Use ssize_t, to match.
11043 (send_process): Likewise.
11044
a32d4040
CY
110452011-04-09 Chong Yidong <cyd@stupidchicken.com>
11046
11047 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11048
8546720e 110492011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11050
04f2d78b
CB
11051 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11052 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11053
8546720e
GM
11054 * xterm.c (handle_one_xevent):
11055 * xmenu.c (create_and_show_popup_menu):
11056 * xselect.c (x_decline_selection_request)
11057 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11058
0a2f5c1a 110592011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11060
11061 Fix some uses of `int' instead of EMACS_INT.
11062 * search.c (string_match_1, fast_string_match)
11063 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11064 (scan_buffer, find_next_newline_no_quit)
11065 (find_before_next_newline, search_command, Freplace_match)
11066 (Fmatch_data): Make some `int' variables be EMACS_INT.
11067
11068 * xdisp.c (display_count_lines): 3rd argument and return value now
11069 EMACS_INT. All callers changed.
11070 (pint2hrstr): Last argument is now EMACS_INT.
11071
11072 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11073 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11074 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11075 (decode_coding_utf_16, decode_coding_emacs_mule)
11076 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11077 (decode_coding_ccl, decode_coding_charset)
11078 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11079 (decode_coding_iso_2022, decode_coding_emacs_mule)
11080 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11081 <char_offset, last_offset>: Declare EMACS_INT.
11082 (encode_coding_utf_8, encode_coding_utf_16)
11083 (encode_coding_emacs_mule, encode_invocation_designation)
11084 (encode_designation_at_bol, encode_coding_iso_2022)
11085 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11086 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11087 Declare EMACS_INT.
11088 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11089 (encode_invocation_designation): Last argument P_NCHARS is now
11090 EMACS_INT.
11091 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11092 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11093
11094 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11095 All users changed.
11096
11097 * ccl.c (Fccl_execute_on_string): Declare some variables
11098 EMACS_INT.
11099
8546720e 111002011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11101
11102 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11103
4e19a977
CS
111042011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11105
11106 * process.c (Fformat_network_address): Doc fix.
11107
87302331
R
111082011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11109
ee7683eb 11110 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11111
cbb59342
CY
111122011-04-08 Chong Yidong <cyd@stupidchicken.com>
11113
11114 * keyboard.c (read_char): Call Lisp function help-form-show,
11115 instead of using internal_with_output_to_temp_buffer.
11116 (Qhelp_form_show): New var.
e0d38eeb 11117 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11118
11119 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11120
11121 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11122
e67a13ab
CY
111232011-04-06 Chong Yidong <cyd@stupidchicken.com>
11124
04f2d78b
CB
11125 * process.c (Flist_processes): Remove to Lisp.
11126 (list_processes_1): Delete.
e67a13ab 11127
973f782d
EZ
111282011-04-06 Eli Zaretskii <eliz@gnu.org>
11129
7c106b1e
EZ
11130 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11131
973f782d
EZ
11132 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11133
41cf7d1a 111342011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11135
ca23cc88
PE
11136 Fix more problems found by GCC 4.6.0's static checks.
11137
f390e2d5
PE
11138 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11139
42eea0d0
PE
11140 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11141
b69769da 11142 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11143
f9541e84
PE
11144 * xdisp.c (vmessage): Mark as a printf-like function.
11145
13841b55
PE
11146 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11147
c136c10f
PE
11148 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11149
5e2d4a30
PE
11150 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11151 printf-like functions.
11152 (tiff_load): Add casts to remove these marks before passing them
11153 to system-supplied API.
11154
583f48b9
PE
11155 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11156
b25d760e
PE
11157 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11158 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11159 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11160 directly, rather than having caller test rule sign. This avoids
11161 some unnecessary tests.
11162 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11163 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11164 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11165
bc7b6697 11166 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11167 (xfont_open): Avoid unnecessary tests.
bc7b6697 11168
27ccc379
PE
11169 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11170
dcd5c89a
PE
11171 * composite.h, composite.c (composition_gstring_put_cache):
11172 Use EMACS_INT, not int, for length.
11173
b13a45c6
PE
11174 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11175 breaking out part of COMPOSITION_DECODE_RULE.
11176 (COMPOSITION_DECODE_RULE): Use it.
11177 * composite.c (get_composition_id): Remove unused local vars,
11178 by using the new macro.
11179
1e792e4d
PE
11180 * textprop.c (set_text_properties_1): Change while to do-while,
11181 since the condition is always true at first.
11182
dc6c6455 11183 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11184 (interval_deletion_adjustment): Return unsigned value.
11185 All uses changed.
dc6c6455 11186
aba7731a
PE
11187 * process.c (list_processes_1, create_pty, read_process_output):
11188 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11189 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11190 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11191 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11192 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11193
fdfc4bf3
PE
11194 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11195
fca8fe46 11196 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11197 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11198
06a0259a 11199 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11200 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11201 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11202
e7b9e80f
PE
11203 * print.c (print_error_message): Avoid int overflow.
11204
56201685
PE
11205 * font.c (font_list_entities): Redo for clarity,
11206 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11207
78834453 11208 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11209 (font_score): Avoid potential overflow in diff calculation.
78834453 11210
0bc0b309 11211 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11212 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11213
e610eaca
PE
11214 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11215
b895abce
PE
11216 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11217 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11218 can always succeed if overflow has undefined behavior.
11219
1f1d9321 11220 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11221 (wordify): Omit three unnecessary tests.
1f1d9321 11222
c59478bc
PE
11223 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11224 All callers changed. This avoids the need for an unused var.
11225
79b73827
PE
11226 * casefiddle.c (casify_region): Remove var that is set but not used.
11227
a4db5dfe
PE
11228 * dired.c (file_name_completion): Remove var that is set but not used.
11229
43aae36e
PE
11230 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11231
2a47c44d 11232 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 11233 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 11234
a37c69bf
PE
11235 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11236 Check for integer overflow on size calculations.
11237
328ab8e7
PE
11238 * buffer.c (Fprevious_overlay_change): Remove var that is set
11239 but not used.
11240
e5a2a5cb
PE
11241 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11242 Remove vars that are set but not used.
8d84a6eb 11243 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 11244 (timer_check_2): Mark vars as initialized.
e5a2a5cb 11245
a60e5f68
PE
11246 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11247
f661cb61 11248 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 11249 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 11250
f0397f5a
PE
11251 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11252 that are set but not used.
11253
8664db06 11254 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 11255 if XCreateBitmapFromData fails (Bug#8410).
8664db06 11256
6abdaa4a
PE
11257 * xselect.c (x_get_local_selection, x_handle_property_notify):
11258 Remove vars that are set but not used.
11259
0ce7538d 11260 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 11261 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 11262
9ae848fc
PE
11263 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11264 Remove var that is set but not used.
0b918413
PE
11265 (scroll_bar_windows_size): Now size_t, not int.
11266 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11267 Check for overflow.
9ae848fc 11268
a5a62657
PE
11269 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11270 (map_tty_color) [!defined MSDOS]: Likewise.
11271
5c5cdd39
PE
11272 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11273
66ebf983
PE
11274 * coding.c: Remove vars that are set but not used.
11275 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11276 All callers changed.
11277 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11278 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11279 (decode_coding_charset): Remove vars that are set but not used.
11280
1be4d761
PE
11281 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11282 that is set but not used.
11283
47553fa8
PE
11284 * print.c (print_object): Remove var that is set but not used.
11285
1f7196bf 11286 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
11287 The gnulib version avoids calling malloc in the usual case,
11288 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11289 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11290 * filelock.c (current_lock_owner): Likewise.
11291 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11292 * sysdep.c: Include allocator.h, careadlinkat.h.
11293 (emacs_no_realloc_allocator): New static constant.
11294 (emacs_readlink): New function.
fdb61804
PE
11295 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11296 ../lib/careadlinkat.h.
d1fdcab7 11297
f84c17c7
SM
112982011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11299
11300 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11301 first non-nil return value).
11302
ef3862ad
JD
113032011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11304
11305 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11306 if not defined (Bug#8403).
11307
376a7006
JB
113082011-04-02 Juanma Barranquero <lekktu@gmail.com>
11309
11310 * xdisp.c (display_count_lines): Remove parameter `start',
11311 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11312 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11313 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11314 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11315 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11316 and thereabouts. All callers changed.
11317 (get_per_char_metric): Remove parameter `f', unused since
11318 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11319
6ca3801d
JM
113202011-04-02 Jim Meyering <meyering@redhat.com>
11321
11322 do not dereference NULL upon failed strdup
11323 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11324 (ns_get_family): Likewise.
11325
d8e2b5ba
JB
113262011-04-02 Juanma Barranquero <lekktu@gmail.com>
11327
11328 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11329
8c74fcbd
JD
113302011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11331
11332 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11333 later (Bug#8403).
11334
7200d79c
SM
113352011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11336
03408648 11337 Add lexical binding.
7200d79c 11338
03408648
SM
11339 * window.c (Ftemp_output_buffer_show): New fun.
11340 (Fsave_window_excursion):
11341 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11342
11343 * lread.c (lisp_file_lexically_bound_p): New function.
11344 (Fload): Bind Qlexical_binding.
11345 (readevalloop): Remove `evalfun' arg.
11346 Bind Qinternal_interpreter_environment.
11347 (Feval_buffer): Bind Qlexical_binding.
11348 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11349 Mark as dynamic.
11350 (syms_of_lread): Declare `lexical-binding'.
11351
11352 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11353
11354 * keyboard.c (eval_dyn): New fun.
11355 (menu_item_eval_property): Use it.
ca105506
SM
11356
11357 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11358
03408648
SM
11359 * fns.c (concat, mapcar1): Accept byte-code-functions.
11360
11361 * eval.c (Fsetq): Handle lexical vars.
11362 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11363 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11364 (FletX, Flet): Obey lexical binding.
11365 (Fcommandp): Handle closures.
11366 (Feval): New `lexical' arg.
11367 (eval_sub): New function extracted from Feval. Use it almost
11368 everywhere where Feval was used. Look up vars in lexical env.
11369 Handle closures.
11370 (Ffunctionp): Move from subr.el.
11371 (Ffuncall): Handle closures.
11372 (apply_lambda): Remove `eval_flags'.
11373 (funcall_lambda): Handle closures and new byte-code-functions.
11374 (Fspecial_variable_p): New function.
11375 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11376 but without exporting it to Lisp.
23aba0ea 11377
23aba0ea 11378 * doc.c (Fdocumentation, store_function_docstring):
03408648 11379 * data.c (Finteractive_form): Handle closures.
23aba0ea 11380
03408648
SM
11381 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11382 interactive spec.
ba83908c 11383
04f2d78b
CB
11384 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11385 New byte-codes.
03408648
SM
11386 (exec_byte_code): New function extracted from Fbyte_code to handle new
11387 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11388
03408648 11389 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11390
03408648 11391 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11392
e2abce01
JB
113932011-03-31 Juanma Barranquero <lekktu@gmail.com>
11394
11395 * xdisp.c (redisplay_internal): Fix prototype.
11396
63696a73 113972011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11398
63696a73 11399 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11400 (try_scrolling): Use it when setting scroll_limit.
11401 Limit scrolling to 100 screen lines.
63696a73
EZ
11402 (redisplay_window): Even when falling back on "recentering",
11403 position point in the window according to scroll-conservatively,
11404 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11405
11406 (try_scrolling): When point is above the window, allow searching
11407 as far as scroll_max, or one screenful, to compute vertical
11408 distance from PT to the scroll margin position. This prevents
11409 try_scrolling from unnecessarily failing when
11410 scroll-conservatively is set to a value slightly larger than the
11411 window height. Clean up the case of PT below the margin at bottom
11412 of window: scroll_max can no longer be INT_MAX. When aggressive
11413 scrolling is in use, don't let point enter the opposite scroll
11414 margin as result of the scroll.
11415 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
11416 threshold of 100 lines for never-recentering scrolling.
11417
e4cc2dfc
JB
114182011-03-31 Juanma Barranquero <lekktu@gmail.com>
11419
11420 * dispextern.h (move_it_by_lines):
11421 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11422 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11423 (message_log_check_duplicate): Remove parameters `prev_bol' and
11424 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11425 (redisplay_internal): Remove parameter `preserve_echo_area',
11426 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11427
11428 * indent.c (Fvertical_motion):
11429 * window.c (window_scroll_pixel_based, Frecenter):
11430 Don't pass `need_y_p' to `move_it_by_lines'.
11431
1c470562
SM
114322011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11433
44f230aa
SM
11434 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11435 steal a few bits to be more compact.
11436 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11437 Remove unneeded casts.
11438
1c470562
SM
11439 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11440
888adce9
ZK
114412011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11442
11443 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11444 binding" message (bug#7967).
11445
f838ed7b
PE
114462011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11447
77861b95
PE
11448 Fix more problems found by GCC 4.6.0's static checks.
11449
de6dbc14
PE
11450 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11451 Remove unused local var.
11452
f838ed7b
PE
11453 * editfns.c (Fmessage_box): Remove unused local var.
11454
792c7b2b
PE
11455 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11456 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11457 Omit unused local vars.
c499e557 11458 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11459 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11460 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11461 Omit unused local var.
11462
ba0165e1
PE
11463 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11464 Don't assume string length fits in int.
32ad8845 11465 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11466 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11467
3c59b4c9
PE
11468 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11469 instead of alloca (Bug#8344).
11470
a3eed478 11471 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11472 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11473
eb4d412d
PE
11474 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11475
1658b401
PE
11476 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11477 concerns.
11478
11479 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11480
11481 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11482
9a2c6e05
PE
11483 * keyboard.c (syms_of_keyboard): Use the same style as later
11484 in this function when indexing through an array. This also
11485 works around GCC bug 48267.
11486
03d0a109
PE
11487 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11488
44f730c8
PE
11489 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11490
fe75f926
PE
11491 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11492 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11493
ffa8c828
PE
11494 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11495 This avoids undefined behavior on integer overflow, and is a bit
11496 more convenient anyway since it is compared to a size_t variable.
11497
c5101a77
PE
11498 Variadic C functions now count arguments with size_t, not int.
11499 This avoids an unnecessary limitation on 64-bit machines, which
11500 caused (substring ...) to crash on large vectors (Bug#8344).
11501 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11502 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11503 All variadic functions and their callers changed accordingly.
c5101a77
PE
11504 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11505 * data.c (arith_driver, float_arith_driver): Likewise.
11506 * editfns.c (general_insert_function): Likewise.
11507 * eval.c (struct backtrace.nargs, interactive_p)
11508 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11509 (funcall_lambda, mark_backtrace): Likewise.
11510 * fns.c (concat): Likewise.
11511 * frame.c (x_set_frame_parameters): Likewise.
11512 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11513 0 if not found, not -1. All callers changed.
11514
dd3f25f7
PE
11515 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11516 (stack_copy_size): Now size_t, not int.
11517 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11518
461c2ab9
JB
115192011-03-28 Juanma Barranquero <lekktu@gmail.com>
11520
11521 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11522 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11523 All callers changed.
11524
11525 * lisp.h (multibyte_char_to_unibyte):
11526 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11527 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11528 * character.h (CHAR_TO_BYTE8):
11529 * cmds.c (internal_self_insert):
11530 * editfns.c (general_insert_function):
11531 * keymap.c (push_key_description):
11532 * search.c (Freplace_match):
11533 * xdisp.c (message_dolog, set_message_1): All callers changed.
11534
f6d62986
SM
115352011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11536
11537 * keyboard.c (safe_run_hook_funcall): New function.
11538 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11539 don't set the hook to nil, but remove the offending function instead.
11540 (Qcommand_hook_internal): Remove, unused.
11541 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11542 Vcommand_hook_internal.
11543
11544 * eval.c (enum run_hooks_condition): Remove.
11545 (funcall_nil, funcall_not): New functions.
11546 (run_hook_with_args): Call each function through a `funcall' argument.
11547 Remove `cond' argument, now redundant.
11548 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11549 (Frun_hook_with_args_until_failure): Adjust accordingly.
11550 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11551
1db5b1ad
JB
115522011-03-28 Juanma Barranquero <lekktu@gmail.com>
11553
11554 * dispextern.h (string_buffer_position): Remove declaration.
11555
11556 * print.c (strout): Remove parameter `multibyte', unused since
11557 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11558
11559 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11560 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11561 All callers changed.
11562
11563 * w32.c (_wsa_errlist): Use braces for struct initializers.
11564
11565 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11566 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11567 All callers changed.
11568 (string_buffer_position): Likewise. Also, make static (it's never
11569 used outside xdisp.c).
11570 (cursor_row_p): Remove parameter `w', unused since
11571 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11572 (decode_mode_spec): Remove parameter `precision', introduced during
11573 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11574 All callers changed.
11575
5ffb62aa
JD
115762011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11577
11578 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11579
461c2ab9 115802011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11581
11582 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11583 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11584 (ns_update_auto_hide_menu_bar): New functions.
11585 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11586 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11587 ns_constrain_all_frames.
11588 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11589 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11590
5c380ffb
JD
115912011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11592
11593 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11594
9af30bdf
GM
115952011-03-27 Glenn Morris <rgm@gnu.org>
11596
11597 * syssignal.h: Replace RETSIGTYPE with void.
11598 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11599 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11600 Replace SIGTYPE with void everywhere.
11601 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11602 * s/template.h (SIGTYPE): Remove commented out definition.
11603
e2abce01
JB
116042011-03-26 Eli Zaretskii <eliz@gnu.org>
11605
11606 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11607 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11608
f868cd8a
JB
116092011-03-26 Juanma Barranquero <lekktu@gmail.com>
11610
59eb0929
JB
11611 * w32.c (read_unc_volume): Use parameter `henum', instead of
11612 global variable `wget_enum_handle'.
11613
11614 * keymap.c (describe_vector): Remove parameters `indices' and
11615 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11616 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11617
f868cd8a
JB
11618 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11619
11620 * keyboard.c (timer_check): Remove parameter `do_it_now',
11621 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11622 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11623 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11624
11625 * keyboard.c (read_char):
11626 * w32menu.c (w32_menu_display_help):
11627 * xmenu.c (show_help_event, menu_help_callback):
11628 Adjust calls to `show_help_echo'.
11629
11630 * gtkutil.c (xg_maybe_add_timer):
11631 * keyboard.c (readable_events):
11632 * process.c (wait_reading_process_output):
11633 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11634
11635 * insdel.c (adjust_markers_gap_motion):
11636 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11637 (gap_left, gap_right): Don't call it.
11638
2ecf6fdb
CY
116392011-03-25 Chong Yidong <cyd@stupidchicken.com>
11640
11641 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11642 incurred during fontification.
11643
6b1f9ba4
JB
116442011-03-25 Juanma Barranquero <lekktu@gmail.com>
11645
11646 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11647 (DEFVAR_PER_BUFFER): Don't pass it.
11648
11649 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11650 (scrolling_window): Don't pass it.
11651
0f4a96b5
JB
116522011-03-25 Juanma Barranquero <lekktu@gmail.com>
11653
11654 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11655
11656 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11657 and `suffix'.
11658 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11659 of variables specific to SELinux and computation of `encoded_absname'.
11660
11661 * image.c (XPutPixel): Remove unused variable `height'.
11662
11663 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11664
11665 * unexw32.c (get_section_info): Remove unused variable `section'.
11666
11667 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11668 (system_process_attributes): Remove unused variable `sess'.
11669 (sys_read): Remove unused variable `err'.
11670
11671 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11672 (w32_wnd_proc): Remove unused variable `isdead'.
11673 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11674 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11675 (x_create_tip_frame): Remove unused variable `tem'.
11676
11677 * w32inevt.c (w32_console_read_socket):
11678 Remove unused variable `no_events'.
11679
11680 * w32term.c (x_draw_composite_glyph_string_foreground):
11681 Remove unused variable `width'.
11682
1149507c
JB
116832011-03-24 Juanma Barranquero <lekktu@gmail.com>
11684
11685 * w32term.c (x_set_glyph_string_clipping):
11686 Don't pass uninitialized region to CombineRgn.
11687
9c88f339
JB
116882011-03-23 Juanma Barranquero <lekktu@gmail.com>
11689
11690 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11691 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11692 (Fx_close_connection): Remove unused variable `i'.
11693
11694 * w32font.c (w32font_draw): Return number of glyphs.
11695 (w32font_open_internal): Remove unused variable `i'.
11696 (w32font_driver): Add missing initializer.
11697
11698 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11699 (fill_in_menu): Remove unused variable `items_added'.
11700
11701 * w32term.c (last_mouse_press_frame): Remove static global variable.
11702 (w32_clip_to_row): Remove unused variable `f'.
11703 (x_delete_terminal): Remove unused variable `i'.
11704
11705 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11706 (NOTHING): Remove unused static global variable.
11707 (uniscribe_check_otf): Remove unused variable `table'.
11708 (uniscribe_font_driver): Add missing initializers.
11709
dee091a3
JD
117102011-03-23 Julien Danjou <julien@danjou.info>
11711
11712 * term.c (Fsuspend_tty, Fresume_tty):
11713 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11714 * window.c (temp_output_buffer_show):
11715 * insdel.c (signal_before_change):
11716 * frame.c (Fhandle_switch_frame):
11717 * fileio.c (Fdo_auto_save):
11718 * emacs.c (Fkill_emacs):
11719 * editfns.c (save_excursion_restore):
11720 * cmds.c (internal_self_insert):
11721 * callint.c (Fcall_interactively):
11722 * buffer.c (Fkill_all_local_variables):
11723 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11724 Use Frun_hooks.
0f4a96b5 11725 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11726 unconditionally since it does the check itself.
dee091a3 11727
2c520ab5 117282011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11729
c9c49752
PE
11730 Fix more problems found by GCC 4.5.2's static checks.
11731
8abc3f12
PE
11732 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11733 the first time through the loop, since we know p0 < p1 then.
11734 This also avoids a gcc -Wstrict-overflow warning.
11735
a2d26660
PE
11736 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11737 leading to a memory leak, possible in functions like
11738 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11739 of objects (Bug#8318).
a2d26660 11740
916c72e9
PE
11741 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11742 that could (at least in theory) be that large.
11743
19ab8a18
PE
11744 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11745 This is less likely to overflow, and avoids undefined behavior if
11746 overflow does occur. All callers changed. Use strtoul to scan
11747 for the unsigned long integer.
b7cbbd6f
PE
11748 (pint2hrstr): Simplify and tune code slightly.
11749 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11750
f0641eff
PE
11751 * scroll.c (do_scrolling): Work around GCC bug 48228.
11752 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11753
7f650bb9
PE
11754 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11755 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11756 (validate_x_resource_name): Simplify count usage.
11757 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11758
37dd57d1
PE
11759 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11760 fail (Bug#8306).
81e56e61 11761
699979fc 11762 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11763
401bf9b4
PE
11764 * process.c (Fmake_network_process): Use socklen_t, not int,
11765 where POSIX says socklen_t is required in portable programs.
11766 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11767 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11768 (Fmake_network_process, server_accept_connection):
11769 (wait_reading_process_output, read_process_output):
11770 Likewise.
11771
b93aacde
PE
11772 * process.c: Rename or move locals to avoid shadowing.
11773 (list_processes_1, Fmake_network_process):
11774 (read_process_output_error_handler, exec_sentinel_error_handler):
11775 Rename or move locals.
4dc343ee 11776 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11777 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11778 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11779 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11780 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11781
af8a867c 11782 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11783 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11784 Include tparam.h instead, since it declares them.
af8a867c
PE
11785 * cm.h (PC): Remove extern decl; tparam.h now does this.
11786 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11787 * terminfo.c: Include tparam.h, to check interfaces.
11788 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11789 (tparam): Adjust signature to match interface in tparam.h;
11790 this removes some undefined behavior. Check that outstring and len
11791 are zero, which they always are with Emacs.
11792 * tparam.h (PC, BC, UP): New extern decls.
11793
0248044d 11794 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11795 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11796
8ff096c1 11797 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11798 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11799 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11800 (ftfont_list): Remove unused local.
49eaafba
PE
11801 (get_adstyle_property, ftfont_pattern_entity):
11802 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11803 Rename locals to avoid shadowing.
8ff096c1 11804
e2be39f6
PE
11805 * xfont.c (xfont_list_family): Mark var as initialized.
11806
c9735e30
PE
11807 * xml.c (make_dom): Now static.
11808
8f5201ae
PE
11809 * composite.c (composition_compute_stop_pos): Rename local to
11810 avoid shadowing.
b246f932
PE
11811 (composition_reseat_it): Remove unused locals.
11812 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11813 (composition_update_it): Mark var as initialized.
11b61122
PE
11814 (find_automatic_composition): Mark vars as initialized,
11815 with a FIXME (Bug#8290).
8f5201ae 11816
760fbc2c
PE
11817 character.h: Rename locals to avoid shadowing.
11818 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11819 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11820 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11821 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11822 to avoid shadowing.
11823
ff08eb85
PE
11824 * textprop.c (property_change_between_p): Remove; unused.
11825
fc7bf025
PE
11826 * intervals.c (interval_start_pos): Now static.
11827
235d7abc
PE
11828 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11829
44f230aa
SM
11830 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11831 Rename locals to avoid shadowing.
3e7d6594 11832
50060332
PE
11833 * sound.c (wav_play, au_play, Fplay_sound_internal):
11834 Fix pointer signedness.
d01f234b 11835 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11836 (wav_play): Initialize a variable to 0, to prevent undefined
11837 behavior (Bug#8278).
50060332 11838
c4fc4e30
PE
11839 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11840
918436ed
PE
11841 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11842
c939f91b
PE
11843 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11844 clobbering (Bug#8298).
b9c7f648
PE
11845 * sysdep.c (sys_subshell): Likewise.
11846 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11847
6bd8c144
PE
11848 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11849 This should get cleaned up, so that child_setup has the
11850 same signature on all platforms.
11851
7710357c 11852 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11853 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11854
c59da222
CY
118552011-03-22 Chong Yidong <cyd@stupidchicken.com>
11856
11857 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11858 not to be necessary, and produces flickering.
11859
66b87493
GM
118602011-03-20 Glenn Morris <rgm@gnu.org>
11861
11862 * config.in: Remove file.
11863
45b6f6d5
JB
118642011-03-20 Juanma Barranquero <lekktu@gmail.com>
11865
11866 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11867 are now in src/globals.h.
11868 (syms_of_minibuf): Remove spurious & from previous change.
11869
cd394be1 118702011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11871
11872 * minibuf.c (completing-read-function): New variable.
11873 (completing-read-default): Rename from completing-read.
11874 (completing-read): Call completing-read-function.
11875
b14e3e21
CY
118762011-03-19 Juanma Barranquero <lekktu@gmail.com>
11877
11878 * xfaces.c (Fx_load_color_file):
11879 Read color file from absolute filename (bug#8250).
11880
f2b726e6
JB
118812011-03-19 Juanma Barranquero <lekktu@gmail.com>
11882
11883 * makefile.w32-in: Update dependencies.
11884
09f6ff02
EZ
118852011-03-17 Eli Zaretskii <eliz@gnu.org>
11886
11887 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11888
29a6015a
PE
118892011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11890
a3a6c54e
PE
11891 Fix more problems found by GCC 4.5.2's static checks.
11892
b766f867
PE
11893 * process.c (make_serial_process_unwind, send_process_trap):
11894 (sigchld_handler): Now static.
11895
be02381c
PE
11896 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11897 That way, the code declares only the vars that it needs.
11898 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11899 * s/cygwin.h (PTY_ITERATION): Likewise.
11900 * s/darwin.h (PTY_ITERATION): Likewise.
11901 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11902
57048744
PE
11903 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11904 * process.c (allocate_pty): Don't declare stb unless it's needed.
11905
7914961c 11906 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
11907 (CONSTANTLIM): Remove; unused.
11908 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11909 Define only if needed.
7914961c 11910
b3967b18
PE
11911 * unexelf.c (unexec): Name an expression,
11912 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11913 Use a different way to cause a compilation error if anyone uses
11914 n rather than nn, a way that does not involve shadowing.
73366a00 11915 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11916
29a6015a
PE
11917 * deps.mk (unexalpha.o): Remove; unused.
11918
43cfc33e 11919 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 11920 * unexec.h: New file.
ce701a33
PE
11921 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11922 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11923 Depend on unexec.h.
11924 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11925 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11926 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 11927 Change as necessary to match prototype in unexec.h.
ce701a33 11928
01f44d5a
PE
11929 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11930 shadowing.
4f63c6bb 11931 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 11932
a6670b0b
PE
11933 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11934 Rename locals to avoid shadowing.
11935
cef2010d 11936 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 11937 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 11938
d4d7173a
PE
11939 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11940
f08b802a
PE
11941 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11942 warning when compiling print.c.
11943
3ddb0639
PE
11944 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11945 instead of using an uninitialized var.
5ad03b97 11946 (font_sort_entities): Mark var as initialized.
3ddb0639 11947
170a2692
PE
11948 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11949
e663c700
PE
11950 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11951 pointers to constants.
89bc529a 11952 (font_parse_fcname): Remove unused vars.
7b81e2d0 11953 (font_delete_unmatched): Now static.
ea838e10 11954 (font_get_spec): Remove; unused.
13a547c6
PE
11955 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11956 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11957 Rename or move locals to avoid shadowing.
e663c700 11958
2a80c887 11959 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11960 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11961
1384fa33 11962 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11963 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11964
8b2c52e9
PE
11965 * alloc.c (mark_backtrace): Move decl from here ...
11966 * lisp.h: ... to here, so that it can be checked.
11967
475545b5 11968 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11969 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11970 (lisp_indirect_variable): Name an expression,
11971 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11972 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11973
b1349114 11974 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11975 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11976 Use const pointer when appropriate.
b1349114 11977
a2928364
PE
11978 * lisp.h (get_system_name, get_operating_system_release):
11979 Move decls here, to check interfaces.
11980 * process.c (get_operating_system_release): Move decl to lisp.h.
11981 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11982 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11983 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11984 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11985 (Fformat_time_string, Fencode_time, Finsert_char):
11986 (Ftranslate_region_internal, Fformat):
11987 Rename or remove local vars to avoid shadowing.
9710023e 11988 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11989
a415e694
PE
11990 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11991 avoid shadowing.
11992
8ef4622d
PE
11993 * lisp.h (eassert): Check that the argument compiles, even if
11994 ENABLE_CHECKING is not defined.
11995
946f9a5b
PE
11996 * data.c (Findirect_variable): Name an expression, to avoid
11997 gcc -Wbad-function-cast warning.
112396d6 11998 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11999 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12000 (Fmake_variable_buffer_local, Fmake_local_variable):
12001 Mark variables as initialized.
52746918 12002 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12003
e5aab7e7 12004 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12005 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12006 Rename locals to avoid shadowing.
dff45157
PE
12007 (mark_stack): Move local variables into the #ifdef region where
12008 they're used.
7bc26fdb
PE
12009 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12010 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12011 needed otherwise.
12012 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12013 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12014 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12015
e5aab7e7
PE
12016 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12017 avoids undefined behavior in theory.
12018
4da60324
PE
12019 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12020
88043301
PE
12021 Use functions, not macros, for up- and down-casing (Bug#8254).
12022 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12023 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12024 to use the following functions instead of these macros.
12025 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12026 EMACS_INT, since callers assume the returned value fits in int.
12027 (upcase1): Likewise, for UPCASE_TABLE.
12028 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12029 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12030 the race-condition problem in the old DOWNCASE.
88043301 12031
19ed5445
PE
12032 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12033 Rename locals to avoid shadowing.
12034 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12035 (regex_compile, re_search_2, re_match_2_internal):
12036 Remove unused local vars.
952db0d7
PE
12037 (FREE_VAR): Rewrite so as not to use empty "else",
12038 which gcc can warn about.
da053e48 12039 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12040 (RETALLOC_IF): Define only if needed.
12041 (WORDCHAR_P): Likewise. This one is never needed, but is used
12042 only in a comment talking about a compiler bug, so put inside
12043 the #if 0 of that comment.
12044 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12045 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12046 Remove; unused.
19ed5445 12047
1f3561e4 12048 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12049 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12050 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12051
ded6f8f7
PE
12052 * search.c (simple_search): Remove unused var.
12053
dbd37a95
PE
12054 * dired.c (compile_pattern): Move decl from here ...
12055 * lisp.h: ... to here, so that it can be checked.
12056 (struct re_registers): New forward decl.
12057
7e47afad
PE
12058 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12059
85f24f61
PE
12060 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12061 All uses changed.
12062 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12063 Rename locals to avoid shadowing.
5671df8f 12064 (Fvertical_motion): Mark locals as initialized.
85f24f61 12065
181aa2be 12066 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12067 (casify_region): Mark local as initialized.
181aa2be 12068
930d429c
PE
12069 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12070
7082eac6
PE
12071 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12072 New macros, so that the caller can use some names other than
12073 gcpro1, gcpro2, etc.
12074 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12075 of the new macros.
12076 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12077 argument, for consistency with GCPRO2_VAR, etc: it is now the
12078 prefix of the variable, not the variable itself. All uses
12079 changed.
38b2c076
PE
12080 * dired.c (directory_files_internal, file_name_completion):
12081 Rename locals to avoid shadowing.
12082
15206ed9
PE
12083 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12084 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12085 dired.c's scmp function, had undefined behavior.
12086 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12087 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12088 * buffer.h: ... to here, because these macros use current_buffer,
12089 and the new implementation with inline functions needs to have
12090 current_buffer in scope now, rather than later when the macros
12091 are used.
12092 (downcase, upcase1): New static inline functions.
12093 (DOWNCASE, UPCASE1): Reimplement using these functions.
12094 This avoids undefined behavior in expressions like
12095 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12096 from race conditions in accessing the global variables
12097 case_temp1 and case_temp2.
12098 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12099 * lisp.h (case_temp1, case_temp2): Remove their decls.
12100 * character.h (ASCII_CHAR_P): Move from here ...
12101 * lisp.h: ... to here, so that the inline functions mentioned
12102 above can use them.
12103
4a6bea26
PE
12104 * dired.c (directory_files_internal_unwind): Now static.
12105
f14b7e14
PE
12106 * fileio.c (file_name_as_directory, directory_file_name):
12107 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12108 Now static.
2893f146
PE
12109 (file_name_as_directory): Use const pointers when appropriate.
12110 (Fexpand_file_name): Likewise. In particular, newdir might
12111 point at constant storage, so make it a const pointer.
fd4ead52 12112 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12113 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12114 signedness issues.
f839df0c
PE
12115 (Fset_file_times, Finsert_file_contents, auto_save_error):
12116 Rename locals to avoid shadowing.
f14b7e14 12117
5716756e 12118 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12119 (Ftry_completion, Fall_completions): Rename or remove locals
12120 to avoid shadowing.
5716756e 12121
b4c3046a
PE
12122 * marker.c (bytepos_to_charpos): Remove; unused.
12123
b45db522
PE
12124 * lisp.h (verify_bytepos, count_markers): New decls,
12125 so that gcc does not warn that these functions aren't declared.
12126
85876d07
PE
12127 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12128 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12129 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12130 (copy_text): Remove unused local var.
85876d07 12131
03d78a21 12132 * filelock.c (within_one_second): Now static.
b3dd38ab 12133 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12134
5df8f01b
PE
12135 * buffer.c (fix_overlays_before): Mark locals as initialized.
12136 (fix_start_end_in_overlays): Likewise. This function should be
12137 simplified by using pointers-to-pointers, but that's a different
12138 matter.
b1d876f1 12139 (switch_to_buffer_1): Now static.
8f54f30a
PE
12140 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12141 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12142
a70072c9 12143 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12144 Fix pointer signedness issue.
edced198
PE
12145 (sys_subshell): Mark local as volatile if checking for lint,
12146 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12147 (MAXPATHLEN): Define only if needed.
a70072c9 12148
a0977c44
PE
12149 * process.c (serial_open, serial_configure): Move decls from here ...
12150 * systty.h: ... to here, so that they can be checked.
12151
a884fdcc
PE
12152 * fns.c (get_random, seed_random): Move extern decls from here ...
12153 * lisp.h: ... to here, so that they can be checked.
12154
604efe86 12155 * sysdep.c (reset_io): Now static.
b8950c94 12156 (wait_for_termination_signal): Remove; unused.
604efe86 12157
38fc62d9
PE
12158 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12159 (copy_keymap_item, append_key, push_text_char_description):
12160 Now static.
1004a21a 12161 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12162 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12163 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12164 (describe_map_tree):
12165 Rename locals to avoid shadowing.
38fc62d9 12166
2f2650da
PE
12167 * keyboard.c: Declare functions static if they are not used elsewhere.
12168 (echo_char, echo_dash, cmd_error, top_level_2):
12169 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12170 (read_char, kbd_buffer_get_event, make_lispy_position):
12171 (make_lispy_event, make_lispy_movement, apply_modifiers):
12172 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12173 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12174 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12175 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12176 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12177
a053e86c 12178 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12179 (mark_kboards): Move decl here ...
12180 * alloc.c (mark_kboards): ... from here.
a053e86c 12181
4752793e
PE
12182 * lisp.h (force_auto_save_soon): New decl.
12183
74f10ca7 12184 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12185 (DEFINE_DUMMY_FUNCTION): New macro.
12186 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12187 Use it.
c03cd23f
PE
12188 (main): Add casts to avoid warnings
12189 if GCC considers string literals to be constants.
74f10ca7 12190
022e70d4
PE
12191 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12192
59d6fe83
PE
12193 * dbusbind.c: Pointer signedness fixes.
12194 (xd_signature, xd_append_arg, xd_initialize):
12195 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12196 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12197 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12198 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12199
78320123
PE
12200 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12201 if GCC considers string literals to be constants.
49cebcca 12202 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12203
35ac2a97
SM
122042011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12205
fb103ca9
SM
12206 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12207 (print_preprocess, print_object): New macro to fix last change.
12208
35ac2a97
SM
12209 * print.c (print_preprocess): Don't forget font objects.
12210
62973b41
JB
122112011-03-16 Juanma Barranquero <lekktu@gmail.com>
12212
12213 * emacs.c (USAGE3): Doc fixes.
12214
0e48bb22
AS
122152011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12216
12217 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12218 structure.
12219
7684e57b
JB
122202011-03-14 Juanma Barranquero <lekktu@gmail.com>
12221
12222 * lisp.h (VWindow_system, Qfile_name_history):
12223 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12224 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12225 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12226
12227 * w32select.c: Don't #include "keyboard.h".
c96bbc66 12228 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
12229
12230 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12231 * w32console.c (detect_input_pending, read_input_pending)
12232 (encode_terminal_code):
12233 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12234 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12235 (w32_system_caret_y, Qfile_name_history):
12236 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12237 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12238 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12239 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12240 * w32proc.c (Qlocal, report_file_error):
12241 * w32term.c (Vwindow_system, updating_frame):
12242 * w32uniscribe.c (initialized, uniscribe_font_driver):
12243 Remove unneeded extern declarations.
12244
2aa46d6c
CY
122452011-03-14 Chong Yidong <cyd@stupidchicken.com>
12246
c96bbc66 12247 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 12248
cffc6f3b
CY
122492011-03-13 Chong Yidong <cyd@stupidchicken.com>
12250
12251 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12252 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12253 These macros can no longer be used for assignment.
12254
44f230aa
SM
12255 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12256 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
12257 (record_buffer_markers, fetch_buffer_markers): New functions for
12258 recording and fetching special buffer markers.
12259 (set_buffer_internal_1, set_buffer_temp): Use them.
12260
12261 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12262
12263 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12264
12265 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12266 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12267
12268 * xdisp.c (hscroll_window_tree):
12269 (reconsider_clip_changes): Use PT instead of BUF_PT.
12270
d251f04b
EZ
122712011-03-13 Eli Zaretskii <eliz@gnu.org>
12272
12273 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12274 $(EMACS_ROOT)/lib/intprops.h.
12275
f0c77cd1
PE
122762011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12277
3eca4629
PE
12278 Fix more problems found by GCC 4.5.2's static checks.
12279
7c86ee98
PE
12280 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12281 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
12282 (xg_free_frame_widgets): Make it clear that a local variable is
12283 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
12284 (gdk_window_get_screen): Make it clear that this macro is needed
12285 only if USE_GTK_TOOLTIP.
1e5524e7
PE
12286 (int_gtk_range_get_value): New function, which avoids a diagnostic
12287 from gcc -Wbad-function-cast.
12288 (xg_set_toolkit_scroll_bar_thumb): Use it.
12289 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12290 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
12291 (get_utf8_string, xg_get_file_with_chooser):
12292 Rename locals to avoid shadowing.
12293 (create_dialog): Move locals to avoid shadowing.
7c86ee98 12294
41729b81
PE
12295 * xgselect.c (xg_select): Remove unused var.
12296
f0c77cd1
PE
12297 * image.c (four_corners_best): Mark locals as initialized.
12298 (gif_load): Initialize transparent_p to zero (Bug#8238).
12299 Mark another local as initialized.
ec6cf4c6 12300 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 12301
ce0ad53d 12302 * image.c (clear_image_cache): Now static.
d5d5a617 12303 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 12304 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
12305 (x_edge_detection): Remove unnecessary cast that
12306 gcc -Wbad-function-cast diagnoses.
2037898d 12307 (gif_load): Fix pointer signedness.
6ae141d6
PE
12308 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12309 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 12310
33383987 123112011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 12312
d32df629
PE
12313 Improve quality of tests for time stamp overflow.
12314 For example, without this patch (encode-time 0 0 0 1 1
12315 1152921504606846976) returns the obviously-bogus value (-948597
12316 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12317 reports time overflow. See
12318 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
12319 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12320 * editfns.c: Include limits.h and intprops.h.
12321 (TIME_T_MIN, TIME_T_MAX): New macros.
12322 (time_overflow): Move earlier, to before first use.
12323 (hi_time, lo_time): New functions, for an accurate test for
12324 out-of-range times.
12325 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12326 (Fget_internal_run_time): Don't assume time_t fits in int.
12327 (make_time): Use list2 instead of Fcons twice.
12328 (Fdecode_time): More accurate test for out-of-range times.
12329 (check_tm_member): New function.
12330 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12331 (lisp_time_argument): Don't rely on undefined left-shift and
12332 right-shift behavior when checking for time stamp overflow.
8be6f318 12333
fe31d94c
PE
12334 * editfns.c (time_overflow): New function, refactoring common code.
12335 (Fformat_time_string, Fdecode_time, Fencode_time):
12336 (Fcurrent_time_string): Use it.
12337
8be6f318
PE
12338 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12339 * dired.c (make_time): Move to ...
12340 * editfns.c (make_time): ... here.
12341 * systime.h: Note the move.
12342
09d9db2c 123432011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12344
126bc0dc
YM
12345 * fringe.c (update_window_fringes): Remove unused variables.
12346
c47cbdfd
YM
12347 * unexmacosx.c (copy_data_segment): Also copy __got section.
12348 (Bug#8223)
12349
7ac80be9
EZ
123502011-03-12 Eli Zaretskii <eliz@gnu.org>
12351
c96bbc66 12352 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12353 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12354 Constify `char *' arguments and their references according to
12355 prototypes in tparam.h.
12356
ecb0f94d 12357 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12358
7ac80be9
EZ
12359 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12360 Adapt all references accordingly.
12361
12362 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12363
ef1fd07e
TT
123642011-03-11 Tom Tromey <tromey@redhat.com>
12365
12366 * buffer.c (syms_of_buffer): Remove obsolete comment.
12367
7ef4b50c
EZ
123682011-03-11 Eli Zaretskii <eliz@gnu.org>
12369
12370 * termhooks.h (encode_terminal_code): Declare prototype.
12371
12372 * msdos.c (encode_terminal_code): Don't declare prototype.
12373
12374 * term.c (encode_terminal_code): Now external again, used by
12375 w32console.c and msdos.c.
12376
44f230aa
SM
12377 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12378 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12379
4b1ec863 123802011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12381
1714f52b 12382 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12383
4b1ec863
PE
12384 * fringe.c (update_window_fringes): Mark locals as initialized
12385 (Bug#8227).
12386 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12387
524c7aa6
PE
12388 * alloc.c (mark_fringe_data): Move decl from here ...
12389 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12390 to check its interface.
12391 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12392
a5c0af81 12393 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12394 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12395 (fontset_font): Mark local as initialized.
a9a06e0b 12396 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12397
b4716021
PE
12398 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12399
811e9bac 12400 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12401 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12402 (x_own_selection, Fx_disown_selection_internal): Rename locals
12403 to avoid shadowing.
12404 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12405
7e3ab302
PE
12406 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12407 so that the caller can use some name other than gcpro1.
12408 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
12409 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12410 (Fx_backspace_delete_keys_p):
12411 Use them to avoid shadowing, and rename vars to avoid shadowing.
12412 (x_decode_color, x_set_name, x_window): Now static.
6b437900 12413 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 12414 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
12415 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12416 Remove unused locals.
7e3ab302
PE
12417 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12418 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12419 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12420 macros.
f78faa98 12421
e2b13473
PE
12422 * xterm.h (x_mouse_leave): New decl.
12423
77f23912
PE
12424 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12425 Remove unused functions.
cdf4ba58
PE
12426 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12427 (x_calc_absolute_position): Now static.
7411c686 12428 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12429 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12430 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12431 unless they are used.
38d0b34a
PE
12432 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12433 (x_fatal_error_signal): Remove; not used.
a6067996
PE
12434 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12435 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12436 (x_error_catcher, x_connection_closed, x_error_handler):
12437 (x_error_quitter, xembed_send_message, x_iconify_frame):
12438 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12439 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12440 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12441
44f230aa
SM
12442 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12443 Rename or move locals to avoid shadowing.
6b463e58 12444 (tty_defined_color, merge_face_heights): Now static.
5967d051 12445 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12446 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12447 does not deduce is never used uninitialized.
73719eba
PE
12448 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12449 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12450
426994c3 12451 * terminal.c (store_terminal_param): Now static.
5489860b 12452
032f1620 12453 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12454 (set_frame_menubar): Remove unused local.
d4323972 12455 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12456 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12457 since they might point to immutable storage.
281585b0
PE
12458 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12459 since it's unused otherwise.
032f1620 12460
367c19e5 12461 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12462 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12463 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12464 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12465 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12466 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12467 does not deduce are never used uninitialized.
70739cbe 12468
07b48fa9
PE
12469 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12470
8868a238 12471 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12472 * window.c (window_loop, size_window):
12473 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12474
7e5cf297 12475 * window.c (display_buffer): Now static.
d6550a9f
PE
12476 (size_window): Mark variables that gcc -Wuninitialized
12477 does not deduce are never used uninitialized.
a586633d
PE
12478 * window.h (check_all_windows): New decl, to forestall
12479 gcc -Wmissing-prototypes diagnostic.
5b555da1 12480 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12481
f6095868
PE
12482 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12483 shadowing.
12484 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12485 Include <limits.h>.
12486 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12487 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12488 (load_charset_map): Mark variables that gcc -Wuninitialized
12489 does not deduce are never used uninitialized.
53df7c11 12490 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12491
f38b440c
PE
12492 * coding.c (coding_set_source, coding_set_destination):
12493 Use "else { /* comment */ }" rather than "else /* comment */;"
12494 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12495 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12496 a block, when the outer 'i' will do.
12497 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12498 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12499 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12500 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12501 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12502 Rename locals to avoid shadowing.
12503 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12504 * coding.c (emacs_mule_char, encode_invocation_designation):
12505 Now static, since they're not used elsewhere.
413bb2db 12506 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12507 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12508 (decode_coding_emacs_mule): Mark variables that gcc
12509 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12510 (detect_coding_iso_2022): Initialize a local variable that might
12511 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12512 this initialization is needed. (Bug#8211)
5f58e762
PE
12513 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12514 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12515 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12516 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12517 Remove unused macros.
f38b440c 12518
232b38b9 12519 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12520 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12521 * character.c (string_count_byte8): Likewise.
232b38b9 12522
fb90da1b
PE
12523 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12524 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12525
fb93dbc2
PE
12526 * chartab.c (copy_sub_char_table): Now static, since it's not used
12527 elsewhere.
5c156ace
PE
12528 (sub_char_table_ref_and_range, char_table_ref_and_range):
12529 Rename locals to avoid shadowing.
bbcd0949 12530 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12531
7d3b3862 12532 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12533 (BIDI_BOB): Remove unused macro.
7d3b3862 12534
6be7d3da
PE
12535 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12536 deduce are never used uninitialized.
c2ed9c8b 12537 * term.c (encode_terminal_code): Likewise.
6be7d3da 12538
75f8807f 12539 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12540
50938595
PE
12541 * tparam.h: New file.
12542 * term.c, tparam.h: Include it.
12543 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12544 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12545 Move these decls to tparam.h, and make them agree with what
12546 is actually in tparam.c. The previous trick of using incompatible
12547 decls in different modules does not conform to the C standard.
12548 All callers of tparam changed to use tparam's actual API.
12549 * tparam.c (tparam1, tparam, tgoto):
12550 Use const pointers where appropriate.
12551
fbceeba2
PE
12552 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12553 * cm.h (struct cm): Likewise.
12554 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12555 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12556 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12557 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12558 (turn_on_face, init_tty): Likewise.
12559 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12560
7f3f1250
PE
12561 * term.c (term_mouse_position): Rename local to avoid shadowing.
12562
e6ca6543
PE
12563 * alloc.c (mark_ttys): Move decl from here ...
12564 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12565
c40f8d15
AS
125662011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12567
12568 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12569
cfe0661d
JB
125702011-03-09 Juanma Barranquero <lekktu@gmail.com>
12571
12572 * search.c (compile_pattern_1): Remove argument regp, unused since
12573 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12574 (compile_pattern): Don't pass it.
12575
0afb4571
J
125762011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12577
12578 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12579 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12580 for ! HAVE_GTK3.
12581 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12582
12583 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12584
12585 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12586 gdk_window_get_screen, gdk_window_get_geometry,
12587 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12588 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12589 (xg_get_pixbuf_from_pixmap): New function.
12590 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12591 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12592 Call xg_get_pixbuf_from_pixmap instead of
12593 gdk_pixbuf_get_from_drawable.
12594 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12595 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12596 (xg_check_special_colors): Use GtkStyleContext and its functions
12597 for HAVE_GTK3.
12598 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12599 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12600 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
12601 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12602 Call gtk_widget_get_preferred_size.
0afb4571
J
12603 (xg_frame_resized): gdk_window_get_geometry only takes 5
12604 parameters.
44f230aa
SM
12605 (xg_win_to_widget, xg_event_is_for_menubar):
12606 Call gdk_x11_window_lookup_for_display.
0afb4571
J
12607 (xg_set_widget_bg): New function.
12608 (delete_cb): New function.
895009e1 12609 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 12610 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
12611 (xg_set_background_color): Call xg_set_widget_bg.
12612 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12613 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12614 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12615 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12616 if ! HAVE_GTK3.
12617 (update_frame_tool_bar): Call gtk_widget_hide.
12618 (xg_initialize): Use GDK_KEY_g.
12619
12620 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12621 if ! HAVE_GTK3
12622 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12623
12624 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12625 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12626 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12627
1c2cc4ef
JB
126282011-03-08 Juanma Barranquero <lekktu@gmail.com>
12629
12630 * w32xfns.c (select_palette): Check success of RealizePalette against
12631 GDI_ERROR, not zero.
12632
33383987 12633See ChangeLog.11 for earlier changes.
aac0c6e3
MR
12634
12635;; Local Variables:
12636;; coding: utf-8
aac0c6e3
MR
12637;; End:
12638
2f097256 12639 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
12640
12641 This file is part of GNU Emacs.
12642
12643 GNU Emacs is free software: you can redistribute it and/or modify
12644 it under the terms of the GNU General Public License as published by
12645 the Free Software Foundation, either version 3 of the License, or
12646 (at your option) any later version.
12647
12648 GNU Emacs is distributed in the hope that it will be useful,
12649 but WITHOUT ANY WARRANTY; without even the implied warranty of
12650 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12651 GNU General Public License for more details.
12652
12653 You should have received a copy of the GNU General Public License
12654 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.