Auto-commit of generated files.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
fe0055fa
PE
12011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2
3 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4
e6346438
SM
52011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6
7 * keyboard.c (test_undefined): New function (bug#9751).
8 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
9
e112cc37
ET
102011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
11
12 * sysdep.c (init_sys_modes): Fix the check for the controlling
13 terminal (Bug#6649).
14
7b5d6677
EZ
152011-10-20 Eli Zaretskii <eliz@gnu.org>
16
17 * dispextern.h (struct bidi_it): New member next_en_type.
18
19 * bidi.c (bidi_line_init): Initialize the next_en_type member.
20 (bidi_resolve_explicit_1): When next_en_pos is valid for the
21 current character, check also for next_en_type being WEAK_EN.
22 (bidi_resolve_weak): Don't enter the expensive loop if the current
23 position is before next_en_pos. Record the bidi type of the first
24 non-ET, non-BN character we find, in addition to its position.
25 (bidi_level_of_next_char): Invalidate next_en_type when
26 next_en_pos is over-stepped.
27
7da0b018
PE
282011-10-20 Paul Eggert <eggert@cs.ucla.edu>
29
30 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
31 * editfns.c: Rewrite current-time-zone so that it invokes
32 the equivalent of (format-time-string "%Z") to get the time zone name.
33 This fixes a bug when the time zone name contains characters that
34 need converting from the system time locale to Emacs internal format.
35 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
36 that patch fixed format-time-string to do the conversion, but
37 I forgot to fix current-time-zone.
38 (format_time_string): New function, containing most of
39 what Fformat_time_string used to contain.
40 (Fformat_time_string): Rewrite in terms of format_time_string.
41 This doesn't change this function's behavior.
42 (current-time-zone): Rewrite to use format_time_string.
43 This fixes the bug reported by Michael Schierl in
44 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
45 Jason Rumney's 2007-06-07 change worked around this bug, but
46 didn't fix it.
47 * systime.h (tzname, timezone): Remove no-longer-used declarations.
48
8547b010
EZ
492011-10-19 Eli Zaretskii <eliz@gnu.org>
50
51 * xdisp.c (start_display): If the character at POS is displayed
52 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
53 (try_window_reusing_current_matrix): If a line ends in a display
54 vector or the next line starts in a display vector, continue
55 redrawing the window even though the character position of
56 start_row was reached.
8547b010
EZ
57 (Bug#9771, part 2)
58
4e948d15
CY
592011-10-18 Chong Yidong <cyd@gnu.org>
60
61 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
62 with nobreak-char-display too.
63
4787455f
EZ
642011-10-18 Eli Zaretskii <eliz@gnu.org>
65
66 Fix part 3 of bug#9771.
67 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
68 (bidi_resolve_neutral): Don't enter the expensive loop looking for
69 non-neutral characters if the current character is a paragraph
70 separator (a.k.a. Newline). This avoids running the same
71 expensive loop twice, once when we consume the preceding newline
72 and the other time when the line actually needs to be displayed.
73 Avoid the loop when we see neutrals on the base embedding level
74 following a character whose directionality is the same as the
75 paragraph's. This avoids running the expensive loop when a line
76 ends in a long sequence of neutrals, like control characters.
77 Add assertion against STRONG_AL type. Slightly rearrange code
78 that determines the type of a neutral given the first non-neutral
79 that follows it.
80 (bidi_level_of_next_char): Set next_en_pos to zero when
81 invalidating its info.
82
2c91f553
EZ
832011-10-17 Eli Zaretskii <eliz@gnu.org>
84
85 * xdisp.c (push_display_prop): Determine whether to record string
86 or buffer position by IT->string, not by IT->method. Allow
87 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
88 (move_it_vertically_backward): Don't look for character position
89 immediately after the newline when in a continuation line.
90 (Bug#9771, part 1)
2c91f553 91
c7b08b0d
MR
922011-10-15 Martin Rudalics <rudalics@gmx.at>
93
94 * window.c (coordinates_in_window): Rewrite and delabelize
95 vertical border check. (Bug#5357) (Bug#9618)
96
6b02f655
SM
972011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
98
99 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
100 errors in XSetWindowBorder (bug#9310).
101
81d40c92
DA
1022011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
103
104 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
105 avoid crash when xmalloc overrun checking is enabled.
106
d4172c3b
EZ
1072011-10-13 Eli Zaretskii <eliz@gnu.org>
108
109 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
110 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
111 cursor motion with <left> and <right> arrow keys.
112
113 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
114 some callers set that themselves.
115
b00eea75
EZ
1162011-10-12 Eli Zaretskii <eliz@gnu.org>
117
118 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
119 display string and the previous row comes from the same string and
120 is empty. (Bug#9739) (Bug#9738)
121
8fe012c4
SM
1222011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
123
124 * doc.c (get_doc_string): Encode file name (bug#9735).
125
0074aef2
EZ
1262011-10-12 Eli Zaretskii <eliz@gnu.org>
127
79beb178
EZ
128 * bidi.c (bidi_level_of_next_char):
129 * xdisp.c (get_visually_first_element): Remove old incorrect
130 comments regarding the Unicode Line Separator character.
131
0074aef2
EZ
132 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
133
6e4b3fbe
DA
1342011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
135
136 * alloc.c (Fgc_status): Do not access beyond zombies array
137 boundary if nzombies > MAX_ZOMBIES.
138 * alloc.c (dump_zombies): Add missing format specifier.
139
0324f3af
PE
1402011-10-12 Paul Eggert <eggert@cs.ucla.edu>
141
b5525cac
PE
142 * xdisp.c (set_cursor_from_row): Simplify conditionals,
143 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
144
0324f3af
PE
145 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
146 Some packages use them to denote characters with modifiers.
147
e9b5f888
AS
1482011-10-11 Andreas Schwab <schwab@linux-m68k.org>
149
150 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
151 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
152 matching a pp-number. Rename parameter var to var1.
153
127827c0
SM
1542011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
155
156 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
157
c8fd3bd0
GM
1582011-10-08 Glenn Morris <rgm@gnu.org>
159
160 * callint.c (Fcall_interactively): Give a more explicit error for the
161 'c' case with a non-character input. (Bug#8479)
162
352ec8ff
EZ
1632011-10-08 Eli Zaretskii <eliz@gnu.org>
164
03669ccb
EZ
165 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
166 lines.
7061c986
EZ
167 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
168 lines that are hscrolled on the left.
03669ccb 169
352ec8ff
EZ
170 * dispnew.c (buffer_posn_from_coords): Account for a possible
171 presence of header-line. (Bug#4426)
172
a66cfb1c
SM
1732011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
174
6b02f655
SM
175 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
176 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 177
7c5ee88e
PE
1782011-10-07 Paul Eggert <eggert@cs.ucla.edu>
179
180 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
181 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
182 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
183 this makes Emacs dump core during garbage collection on rare
184 occasions. sizeof is obviously inferior to offsetof here, so
185 stick with offsetof.
186 (GC_POINTER_ALIGNMENT): New macro.
187 (mark_memory): Omit 3rd (offset) arg; caller changed.
188 Don't assume EMACS_INT alignment is the same as pointer alignment.
189
df1bbe5b
SM
1902011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
191
192 * keyboard.c (read_key_sequence_remapped): New var.
193 (read_key_sequence): Compute remapping in the right buffer.
194 (command_loop_1): Use read_key_sequence's remapping directly.
195
51553db6
SM
1962011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
197
32c1fffd
SM
198 * dired.c (file_name_completion): Don't expand file name.
199 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
200 before checking file name handler.
201
51553db6
SM
202 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
203 they've been requested explicitly (bug#9591).
204
b6bd1599 2052011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
206
207 * keymap.c (Fsingle_key_description): Use make_specified_string
208 instead of build_string to build string from push_key_description.
209 (Bug#5193)
210
f701dc2a
PE
2112011-09-30 Paul Eggert <eggert@cs.ucla.edu>
212
4222c55d
PE
213 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
214 This fixes a Y2038 bug on 64-bit hosts.
215 * buffer.c (reset_buffer):
216 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
217 (Fclear_buffer_auto_save_failure):
218 Use 0, not -1, to represent an unset failure time, since time_t
219 might not be signed.
220
f701dc2a
PE
221 Remove dependency on glibc malloc internals.
222 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
223 Move back here from lisp.h, but with their new implementations.
224 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
225 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
226 * charset.c (charset_table_init): New static var.
227 (syms_of_charset): Use it instead of xmalloc. This removes a
228 dependency on glibc malloc internals. See Eli Zaretskii's comment in
229 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
230 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
231 Move back to alloc.c.
232 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
233 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
234
9ceebf39
JD
2352011-09-30 Jan Djärv <jan.h.d@swipnet.se>
236
237 * nsterm.m (windowDidResize): Call x_set_window_size only when
238 ns_in_resize is true. Otherwise set pixelwidth/height and
239 call change_frame_size (Bug#9628).
240
cb993c58
PE
2412011-09-30 Paul Eggert <eggert@cs.ucla.edu>
242
3930c88b
PE
243 Port --enable-checking=all to Fedora 14 x86-64.
244 * charset.c (syms_of_charset): Also account for glibc malloc's
245 internal overhead when calculating the initial malloc maximum.
246
cb993c58
PE
247 Port --enable-checking=all to Fedora 14 x86.
248 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
249 Move to lisp.h.
250 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
251 (overrun_check_realloc, overrun_check_free):
252 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
253 That way, xmalloc returns a properly-aligned pointer even if
254 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
255 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
256 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
257 into account when calculating the initial malloc maximum.
258 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
259 Move here from alloc.c, so that charset.c can use it too.
260 Properly align; the old code wasn't right for common 32-bit hosts
261 when configured with --enable-checking=all.
262 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
263 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
264
31bed486
EZ
2652011-09-29 Eli Zaretskii <eliz@gnu.org>
266
04c70788 267 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
268 use EDOM.
269
fbcaa2f3
EZ
2702011-09-28 Eli Zaretskii <eliz@gnu.org>
271
272 * xdisp.c (compute_display_string_end): If there's no display
273 string at CHARPOS, return -1.
274
275 * bidi.c (bidi_fetch_char): When compute_display_string_end
276 returns a negative value, treat the character as a normal
277 character not covered by a display string. (Bug#9624)
278
a239d4e9
JB
2792011-09-28 Juanma Barranquero <lekktu@gmail.com>
280
281 * lread.c (Fread_from_string): Fix typo in docstring.
282
88652fd5
EZ
2832011-09-27 Eli Zaretskii <eliz@gnu.org>
284
285 * xdisp.c (handle_invisible_prop): If invisible text ends on a
286 newline, reseat the iterator instead of bidi-iterating there one
287 character at a time. (Bug#9610)
32c1fffd
SM
288 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
289 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 290
ed497dd4
AS
2912011-09-27 Andreas Schwab <schwab@linux-m68k.org>
292
293 * lread.c (readevalloop): Use correct code for NBSP.
294 (read1): Likewise. (Bug#9608)
295
b2bf61aa
MA
2962011-09-25 Michael Albinus <michael.albinus@gmx.de>
297
298 * dbusbind.c (Fdbus_register_signal): When service is not
299 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
300
32bbb17c
GM
3012011-09-25 Glenn Morris <rgm@gnu.org>
302
303 * buffer.c (truncate-lines): Doc fix.
304
94e0933e
CY
3052011-09-24 Chong Yidong <cyd@stupidchicken.com>
306
307 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
308 (Fset_window_next_buffers): Doc fix.
309
cddde921
GM
3102011-09-24 Glenn Morris <rgm@gnu.org>
311
312 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
313
1260aef1
PE
3142011-09-24 Paul Eggert <eggert@cs.ucla.edu>
315
25b4bfa0
PE
316 Fix minor problems found by static checking.
317 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
318 * indent.c (Fvertical_motion): Fix == vs = typo.
319
e3cbd34b
EZ
3202011-09-24 Eli Zaretskii <eliz@gnu.org>
321
a66cfb1c
SM
322 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
323 Default value is now t. Doc fix.
6bf7006f 324
e3cbd34b 325 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 326 logic when moving up, not only when moving down. Fix the
e3cbd34b 327 confusing name and values of the it_overshoot_expected variable;
32c1fffd 328 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
329
330 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
331 CHARPOS is covered by a display string which includes newlines.
332 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
333 is covered by a display string with embedded newlines.
334
a3de0cbd
MA
3352011-09-24 Michael Albinus <michael.albinus@gmx.de>
336
337 * dbusbind.c (Fdbus_register_signal): Add match rule to
338 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
339 (Fdbus_register_method, Vdbus_registered_objects_table):
340 Fix docstring.
a3de0cbd 341
b260039d
JM
3422011-09-24 Jim Meyering <meyering@redhat.com>
343
32c1fffd 344 do not ignore write error for any output size
b260039d
JM
345 The previous change was incomplete.
346 While it makes emacs --batch detect the vast majority of stdout
347 write failures, errors were still ignored whenever the output size is
348 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
349 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
350 && echo FAIL: ignored write error
351 FAIL: ignored write error
352 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
353 && echo FAIL: ignored write error
354 FAIL: ignored write error
355 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
356
8eca8a7c
AS
3572011-09-23 Andreas Schwab <schwab@linux-m68k.org>
358
359 * emacs.c (Fkill_emacs): In noninteractive mode exit
360 non-successfully if a write error occurred on stdout. (Bug#9574)
361
3341db62
EZ
3622011-09-21 Eli Zaretskii <eliz@gnu.org>
363
364 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
365 the xassert test.
366
367 * dispextern.h (struct it): Update the comment documenting what
368 can it->OBJECT be.
369
8c203dbf
EZ
3702011-09-20 Eli Zaretskii <eliz@gnu.org>
371
372 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
373 a display string, extend search for cursor position to end of row.
374 (find_row_edges): If the row ends in a newline from a display
375 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
376 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
377 (Fcurrent_bidi_paragraph_direction): Fix search for previous
378 non-empty line. Fixes confusing cursor motion with arrow keys at
379 the beginning of a line that starts with whitespace.
8c203dbf 380
a4824228
LMI
3812011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
382
383 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
384 (bug#9493).
385
33ed493b
CY
3862011-09-18 Chong Yidong <cyd@stupidchicken.com>
387
388 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
389 boolean (Bug#9154).
390
56cd55c8
EZ
3912011-09-18 Eli Zaretskii <eliz@gnu.org>
392
393 * xdisp.c (display_line): Record maximum and minimum buffer
394 positions even if no glyphs were produced (e.g., by a zero-width
395 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
396 buffer positions that will be removed from the glyph row because
397 they don't fit.
c02dcedf
EZ
398 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
399 column is beyond frame width: don't subtract 1 "pixel" when
400 computing width of the stretch.
3e62b7e0
EZ
401 (reseat_at_next_visible_line_start): Undo the change made on
402 2011-09-17 that saved paragraph information and restored it after
403 the call to `reseat'. (Bug#9545)
56cd55c8 404
5ed99d36 4052011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
406
407 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
408 and turn window cursor on if cleared (Bug#9415).
409
5ed99d36 4102011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
411
412 * search.c (boyer_moore): Take unibyte characters from pattern
413 literally. (Bug#9458)
414
9bade7b2
EZ
4152011-09-18 Eli Zaretskii <eliz@gnu.org>
416
417 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
418
e5e9d610
PE
4192011-09-18 Paul Eggert <eggert@cs.ucla.edu>
420
87e4427a
PE
421 Fix minor problem found by static checking.
422 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
423 initialized, to pacify gcc -Wuninitialized.
424
e5e9d610
PE
425 * fileio.c: Report proper errno when syscall falls.
426 (Finsert_file_contents): Save and restore errno,
427 so that report_file_error outputs the correct diagnostic.
428 (Fwrite_region) [CLASH_DETECTION]: Likewise.
429
a1674f0b
EZ
4302011-09-18 Eli Zaretskii <eliz@gnu.org>
431
432 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
433
fbfb6dd4
EZ
4342011-09-17 Eli Zaretskii <eliz@gnu.org>
435
436 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
437 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
438
bb187662
EZ
4392011-09-17 Eli Zaretskii <eliz@gnu.org>
440
1137e8b8 441 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 442 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
443
444 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
445 (bidi_find_paragraph_start): Search back for paragraph beginning
446 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
447 (bidi_move_to_visually_next): Only trigger paragraph-related
448 computations when the last character is a newline or at EOB, not
449 just any NEUTRAL_B. (Bug#9470)
450
bb187662
EZ
451 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
452 truncated lines if point is covered by a display string. (Bug#9524)
453
2e621251
PE
4542011-09-16 Paul Eggert <eggert@cs.ucla.edu>
455
456 * xselect.c: Relax test for outgoing X longs (Bug#9498).
457 (cons_to_x_long): New function.
458 (lisp_data_to_selection_data): Use it. Correct the test for
459 short-versus-long data; it was negated. Break out of vector
460 loop, for efficiency, when a long datum is discovered.
461
91a15bc6
SM
4622011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
463
464 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
465
b41c3a35
EZ
4662011-09-16 Eli Zaretskii <eliz@gnu.org>
467
468 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
469 GCC PR/17406) by declaring this function with external scope.
470
7812ba2d
PE
4712011-09-15 Paul Eggert <eggert@cs.ucla.edu>
472
473 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
474 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
475
cf7edc2a
AS
4762011-09-15 Andreas Schwab <schwab@linux-m68k.org>
477
478 * editfns.c (Fformat): Correctly handle text properties on "%%".
479
bd01620e
EZ
4802011-09-15 Eli Zaretskii <eliz@gnu.org>
481
482 * xterm.c (x_draw_composite_glyph_string_foreground):
483 * w32term.c (x_draw_composite_glyph_string_foreground):
484 * term.c (encode_terminal_code):
485 * composite.c (composition_update_it, get_composition_id):
486 * xdisp.c (get_next_display_element)
487 (fill_composite_glyph_string): Add comments about special meaning
488 of TAB characters in a composition.
489
a02719a3
PE
4902011-09-15 Paul Eggert <eggert@cs.ucla.edu>
491
492 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
493 This occurs when processing a multibyte format.
494 Problem reported by Wolfgang Jenker.
a02719a3 495
72589a3c
JB
4962011-09-15 Johan Bockgård <bojohan@gnu.org>
497
498 * xdisp.c (try_cursor_movement): Only check for exact match if
499 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
500
1c14176c
PE
5012011-09-14 Paul Eggert <eggert@cs.ucla.edu>
502
503 Remove unused external symbols.
504 * dispextern.h (calc_pixel_width_or_height): Remove decl.
505 * xdisp.c (calc_pixel_width_or_height): Now static.
506 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
507 * indent.c (check_display_width):
508 * w32term.c: Fix comment to match code.
509 * xterm.c, xterm.h (x_catching_errors): Remove.
510
d2eea5b5
PE
5112011-09-14 Paul Eggert <eggert@cs.ucla.edu>
512
513 * xselect.c: Use signed conversions more consistently (Bug#9498).
514 (selection_data_to_lisp_data): Assume incoming selection data are
515 signed integers, not unsigned. This is to be consistent with
516 outgoing selection data, which was modified to use signed integers
517 in as part of the fix to Bug#9196 in response to Jan D.'s comment
518 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
519 expects long, not unsigned long.
520
46888499
EZ
5212011-09-14 Eli Zaretskii <eliz@gnu.org>
522
523 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
524 computation of loop end. Reported by Johan Bockgård
525 <bojohan@gnu.org>.
526
ef8ef9fb
CY
5272011-09-13 Chong Yidong <cyd@stupidchicken.com>
528
529 * frame.c (Fother_visible_frames_p): Function deleted.
530
fa819fed
EZ
5312011-09-12 Eli Zaretskii <eliz@gnu.org>
532
533 * indent.c (compute_motion): Process display vector front to back
534 rather than the other way around. (Bug#2496)
535
2ba8e008
SM
5362011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
537
538 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
539
20f53c69
CY
5402011-09-11 Chong Yidong <cyd@stupidchicken.com>
541
542 * minibuf.c (Fread_from_minibuffer): Doc fix.
543
d562d7a4
EZ
5442011-09-11 Eli Zaretskii <eliz@gnu.org>
545
546 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
547 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
548
1c4d7f3d
LMI
5492011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
550
551 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
552 value for non-existent files.
553
b885bf36
EZ
5542011-09-11 Eli Zaretskii <eliz@gnu.org>
555
556 * fileio.c (Finsert_file_contents): If the file cannot be opened,
557 set its "size" to -1. This will set the modtime_size field of
558 the corresponding buffer to -1, which is what
559 verify-visited-file-modtime expects for files that do not exist.
560 (Bug#9139)
561
6612f0bf
PE
5622011-09-11 Paul Eggert <eggert@cs.ucla.edu>
563
564 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
565 here ...
566 * lisp.h: ... from here. push_key_description is no longer
567 defined in keyboard.c, so its declaration should not be in
568 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
569 logically belongs with push_key_description.
570
dfb3f755
PE
5712011-09-10 Paul Eggert <eggert@cs.ucla.edu>
572
573 * buffer.h: Include <sys/types.h> instead of <time.h>.
574 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
575 Problem reported by Herbert J. Skuhra.
576
3134906c
LMI
5772011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
578
579 * xml.c (parse_region): Make the parsing work for
580 non-comment-starting XML files again (bug#9144).
581
8d903f4e
AS
5822011-09-10 Andreas Schwab <schwab@linux-m68k.org>
583
584 * image.c (gif_load): Fix calculation of bottom and right corner.
585 (Bug#9468)
586
80ad64f4
EZ
5872011-09-10 Eli Zaretskii <eliz@gnu.org>
588
589 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
590 redisplay in small windows.
591
208a048d
EZ
5922011-09-09 Eli Zaretskii <eliz@gnu.org>
593
594 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
595
9b1c252e
MR
5962011-09-08 Martin Rudalics <rudalics@gmx.at>
597
598 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
599 Operate on live windows only.
600
2949f33b
JB
6012011-09-08 Juanma Barranquero <lekktu@gmail.com>
602
603 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
604
e08dcafd
EZ
6052011-09-07 Eli Zaretskii <eliz@gnu.org>
606
607 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
608 only under bidi iteration.
609
115b96bd
JD
6102011-09-07 Jan Djärv <jan.h.d@swipnet.se>
611
612 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
613
c8199d0f
PE
6142011-09-06 Paul Eggert <eggert@cs.ucla.edu>
615
616 isnan: Fix porting problem to Solaris 10 with bundled gcc.
617 Without this fix, the command to link temacs failed due to an
618 undefined symbol __builtin_isnan. This is because
619 /usr/include/iso/math_c99.h #defines isnan(x) to
620 __builtin_isnan(x), but the bundled gcc, which identifies itself
621 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
622 a __builtin_isnan.
623 * floatfns.c (isnan): #undef, and then #define to a clone of
624 what's in data.c.
625 (Fisnan): Always define, since it's always available now.
626 (syms_of_floatfns): Always define isnan at the Lisp level.
627
e39b275c 6282011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
629
630 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
631
b2db44d9 6322011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 633
f4af5137 634 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
635 The previous code assumed that file offsets (off_t values) fit in
636 EMACS_INT variables, which is not true on typical 32-bit hosts.
637 The code messed up by falsely reporting buffer overflow in cases
638 such as (insert-file-contents "big" nil 1 2) into an empty buffer
639 when "big" contains more than 2**29 bytes, even though this
640 inserts just one byte and does not overflow the buffer.
641 (Finsert_file_contents): Store file offsets as off_t
642 values, not as EMACS_INT values. Check for overflow when
643 converting between EMACS_INT and off_t. When checking for
644 buffer overflow or for overlap, take the offsets into account.
645 Don't use EMACS_INT for small values where int suffices.
646 When checking for overlap, fix a typo: ZV was used where
647 ZV_BYTE was intended.
648 (Fwrite_region): Don't assume off_t fits into 'long'.
649 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
650
ecfc0a49
MA
6512011-09-05 Michael Albinus <michael.albinus@gmx.de>
652
653 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
654
6511acf2 6552011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 656
0999621a 657 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
658
659 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 660 (esprintf, exprintf, evxprintf): New functions.
62f19c19 661 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 662 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
663 (modify_event_symbol): Do not assume that the length of
664 name_alist_or_stem is safe to alloca and fits in int.
665 (Fexecute_extended_command): Likewise for function name and binding.
666 (Frecursion_depth): Wrap around reliably on integer overflow.
667 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
668 since some callers pass EMACS_INT values.
669 (Fsingle_key_description): Don't crash if symbol name contains more
670 than MAX_ALLOCA bytes.
671 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
672 (get_minibuffer): Arg is now EMACS_INT, not int.
673 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 674 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
675 * window.h (command_loop_level, minibuf_level): Reflect API changes.
676
2be7d702
PE
677 * dbusbind.c (signature_cat): New function.
678 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
679 Do not overrun buffer; instead, report string overflow.
680
9d1df220
PE
681 * dispnew.c (add_window_display_history): Don't overrun buffer.
682 Truncate instead; this is OK since it's just a log.
683
33ef5c64
PE
684 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
685 even if the time zone offset is outlandishly large.
686 Don't mishandle offset == INT_MIN.
687
66c6fdd5
PE
688 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
689 when creating daemon; the previous buffer-overflow check was incorrect.
690
d749b01b
PE
691 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
692 which has the guts of the old verror function.
693
b5cd1905
PE
694 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
695 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
696
6e1a67fb
PE
697 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
698 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 699 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 700 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
701 length of string rather than counting it via multiple sprintfs;
702 that's simpler and more reliable.
c21721cc
PE
703 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
704 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
705 sprintf, in case result does not fit in int.
706
c57b67fc
PE
707 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
708 (fontset_from_font): Print it.
709
8a401434
PE
710 * frame.c (tty_frame_count): Now printmax_t, not int.
711 (make_terminal_frame, set_term_frame_name): Print it.
712 (x_report_frame_params): In X, window IDs are unsigned long,
713 not signed long, so print them as unsigned.
714 (validate_x_resource_name): Check for implausibly long names,
715 and don't assume name length fits in 'int'.
716 (x_get_resource_string): Don't blindly alloca invocation name;
717 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
718 not fit in int.
719
6e1a67fb
PE
720 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
721 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
722 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
723
0df02bf3
PE
724 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
725 Use esprintf, not sprintf, in case result does not fit in int.
726
48e30793
PE
727 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
728 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
729 it as a large positive number.
730 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
731 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
732
a66ff6d8
PE
733 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
734 in case result does not fit in int.
735
aca216ff
PE
736 * print.c (float_to_string): Detect width overflow more reliably.
737 (print_object): Make sprintf buffer a bit bigger, to avoid potential
738 buffer overrun. Don't assume list length fits in 'int'. Treat
739 print length of 0 as 0, not as infinity; to be consistent with other
740 uses of print length in this function. Don't overflow print length
741 index. Don't assume hash table size fits in 'long', or that
742 vectorlike size fits in 'unsigned long'.
743
31c286f7
PE
744 * process.c (make_process): Use printmax_t, not int, to format
745 process-name gensyms.
746
55e5faa1
PE
747 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
748
80f2e268
PE
749 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
750 to avoid potential buffer overrun.
751
670741ab
PE
752 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
753 if X resource line is longer than 512 bytes.
754
b7163a50
PE
755 * xfns.c (x_window): Make sprintf buffer a bit bigger
756 to avoid potential buffer overrun.
757
ae58ff1f
PE
758 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
759
c43c8a6a
PE
760 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
761
3f8236f4
PE
7622011-09-04 Paul Eggert <eggert@cs.ucla.edu>
763
53e9fe90 764 Integer overflow fixes for scrolling, etc.
6511acf2
PE
765 Without these, Emacs silently mishandles large integers sometimes.
766 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
767 it were "C-u 1 M-x recenter" on a typical 64-bit host.
768
6511acf2
PE
769 * xdisp.c (try_window_id): Check Emacs fixnum range before
770 converting to 'int'.
806add1d 771
6511acf2 772 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
773 Check that an Emacs fixnum is in range before assigning it to 'int'.
774 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
775 values converted from Emacs fixnums.
776 (Frecenter): Don't wrap around a line count if it is out of 'int'
777 range; instead, treat it as an extreme value.
778 (Fset_window_configuration, compare_window_configurations):
779 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
780
6511acf2
PE
781 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
782 that can exceed INT_MAX. Check that EMACS_INT value is in range
783 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
784 (match_limit): Don't assume that a fixnum can fit in 'int'.
785
6511acf2 786 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
787 exceed INT_MAX.
788
6511acf2 789 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
790 (Fvertical_motion): Don't wrap around LINES values that don't fit
791 in 'int'. Instead, treat them as extreme values. This is good
792 enough for windows, which can't have more than INT_MAX lines anyway.
793
fcb901a7
LMI
7942011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
795
0f2f6b6d
LMI
796 * Require libxml/parser.h to avoid compilation warning.
797
fcb901a7
LMI
798 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
799
800 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
801 since this reportedly can destroy thread storage.
802
6e20a0d4
CY
8032011-08-30 Chong Yidong <cyd@stupidchicken.com>
804
805 * syntax.c (find_defun_start): Update all cache variables if
806 exiting early (Bug#9401).
807
148ae00e
EZ
8082011-08-30 Eli Zaretskii <eliz@gnu.org>
809
f6cfbd8f
EZ
810 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
811
148ae00e
EZ
812 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
813 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
814 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
815
816 * term.c (tty_append_glyph): New function.
817 (produce_stretch_glyph): Static function and its prototype deleted.
818
a66cfb1c
SM
819 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
820 Add prototypes.
148ae00e 821
c4a07a4c
PE
8222011-08-29 Paul Eggert <eggert@cs.ucla.edu>
823
824 * image.c (parse_image_spec): Check for nonnegative, not for positive,
825 when checking :margin (Bug#9390).
826 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 827 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
828 so that the name doesn't mislead. All uses changed.
829
6bc8cd65
JB
8302011-08-28 Johan Bockgård <bojohan@gnu.org>
831
832 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
833 set_tty_hooks.
834
dca4927e
EZ
8352011-08-27 Eli Zaretskii <eliz@gnu.org>
836
837 * xdisp.c (move_it_to): Don't bail out early when reaching
838 position beyond to_charpos, if we are scanning backwards.
839 (move_it_vertically_backward): When DY == 0, make sure we get to
840 the first character in the line after the newline.
841
f2cad773
PE
8422011-08-27 Paul Eggert <eggert@cs.ucla.edu>
843
844 * ccl.c: Improve and simplify overflow checking (Bug#9196).
845 (ccl_driver): Do not generate an out-of-range pointer.
846 (Fccl_execute_on_string): Remove unnecessary check for
847 integer overflow, noted by Stefan Monnier in
848 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
849 Remove a FIXME that didn't need fixing.
850 Simplify the newly-introduced buffer reallocation code.
851
0cae2cdb
JB
8522011-08-27 Juanma Barranquero <lekktu@gmail.com>
853
854 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
855
5fc295a4 8562011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 857
70c60eb2 858 Integer and memory overflow issues (Bug#9196).
726e0ab1 859
d31850da
PE
860 * doc.c (get_doc_string): Rework so that
861 get_doc_string_buffer_size is the actual buffer size, rather than
862 being 1 less than the actual buffer size; this makes xpalloc more
863 convenient.
864
a69fbedb
PE
865 * image.c (x_allocate_bitmap_record, cache_image):
866 * xselect.c (Fx_register_dnd_atom):
867 Simplify previous changes by using xpalloc.
868
fe5c5d37
PE
869 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
870 since either will do and ptrdiff_t is convenient with xpalloc.
871
0065d054
PE
872 * charset.c (charset_table_size)
873 (struct charset_sort_data.priority): Now ptrdiff_t.
874 (charset_compare): Don't overflow if priorities differ greatly.
875 (Fsort_charsets): Don't assume list length fits in int.
876 Check for size-calculation overflow when allocating sort data.
877 (syms_of_charset): Allocate an initial charset table that is
878 just under 64 KiB, to avoid problems with glibc malloc and mmap.
879
880 * cmds.c (internal_self_insert): Check for size-calculation overflow.
881
882 * composite.h (struct composition.glyph_len): Now int, not unsigned.
883 The actual value is always <= INT_MAX, and leaving it unsigned made
884 overflow checking harder.
885
886 * dispextern.h (struct glyph_matrix.rows_allocated)
887 (struct face_cache.size): Now ptrdiff_t, for convenience in use
888 with xpalloc. The values are still always <= INT_MAX.
889
890 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
891
892 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
893 (SAFE_NALLOCA): New macro.
894
895 * region-cache.c (struct boundary.pos, find_cache_boundary)
896 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
897 (set_cache_region, invalidate_region_cache)
898 (revalidate_region_cache, know_region_cache, region_cache_forward)
899 (region_cache_backward, pp_cache):
900 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
901 so that ptrdiff_t * can be passed to xpalloc.
902 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
903 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
904 (pp_cache): Don't assume cache_len fits in int.
905 * region-cache.h: Adjust extern decls to match.
906
907 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
908 EMACS_INT, since either will do, for xpalloc.
909
910 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
911 (xnmalloc, xnrealloc, xpalloc): New functions.
912
726e0ab1
PE
913 * bidi.c (bidi_shelve_header_size): New constant.
914 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
915 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
916
51f30bc5 917 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
918 * buffer.c (overlays_at, overlays_in, record_overlay_string)
919 (overlay_strings):
920 Don't update size of array until after memory allocation succeeds,
921 because xmalloc/xrealloc may not return.
0065d054
PE
922 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
923 now that we have proper integer overflow checking.
924 (record_overlay_string, overlay_strings): Catch overflows when
925 calculating size of overlay_str_buf.
726e0ab1 926
0065d054
PE
927 * callproc.c (Fcall_process): Check for size overflow when
928 calculating size of args2.
929 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
930 Normally we prefer signed values, but sticking with ptrdiff_t would
931 require adding more-complicated checks.
726e0ab1
PE
932
933 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
934 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
935 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 936 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
937
938 * character.c (Fstring): Check for size-calculation overflow.
939
940 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
941 unnecessary integer overflow. Check for size overflow.
942 (encode_coding_object): Don't update size until xmalloc succeeds.
943
944 * composite.c (get_composition_id): Check for overflow in glyph
945 length calculations.
946
947 Integer and memory overflow fixes for display code.
948 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
949 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
950 (scrolling_window): Check for overflow in size calculations.
951 (line_draw_cost, realloc_glyph_pool, add_row_entry):
952 Don't assume glyph table len fits in int.
953 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
954 (row_table_size): Now ptrdiff_t, not int.
955 (scrolling_window): Avoid overflow in size calculations.
956 Don't update size until allocation succeeds.
957 * fns.c (concat): Check for overflow in size calculations.
958 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
959 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
960 (NEXT_ALMOST_PRIME_LIMIT): New constant.
961
962 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
963 (get_doc_string): Check for size calculation overflow.
964 Don't update size until allocation succeeds.
965 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
966 EMACS_INT, where ptrdiff_t will do.
967 (Fsubstitute_command_keys): Check for string overflow.
968
969 * editfns.c (set_time_zone_rule): Don't assume environment length
970 fits in int.
971 (message_length): Now ptrdiff_t, not int.
972 (Fmessage_box): Don't update size until allocation succeeds.
973 Don't assume message length fits in int.
974 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
975
0065d054
PE
976 * emacs.c (main): Do not reallocate argv, since there is a null at
977 the end that can be overwritten, and this way there's no need to
978 worry about size-calculation overflow.
979 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
980
981 * eval.c (init_eval_once, grow_specpdl): Don't update size until
982 alloc succeeds.
983 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
984
985 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
986 (x_set_scroll_bar_width, x_figure_window_size):
987 Check for integer overflow.
988 (x_set_alpha): Do not assume XINT fits in int.
989
990 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
991 This is for the members text_lines, text_cols, total_lines, total_cols,
992 where the system imposes an 'int' limit.
993
994 * fringe.c (Fdefine_fringe_bitmap):
995 Don't update size until alloc works.
996
997 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
998 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
999
1000 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1001 Check for size-calculation overflow.
1002 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1003 do, as we prefer signed integers.
1004 (id_to_widget.max_size, id_to_widget.used)
1005 (xg_store_widget_in_map, xg_remove_widget_from_map)
1006 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1007 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1008 Use and return ptrdiff_t, not int.
1009 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1010 * gtkutil.h: Change prototypes to match the above.
1011
1012 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1013 are duplicate now that they've been promoted to lisp.h.
1014 (x_allocate_bitmap_record, x_alloc_image_color)
1015 (make_image_cache, cache_image, xpm_load):
1016 Don't update size until alloc is done.
1017 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1018 (x_detect_edges):
3256efce 1019 Check for size calculation overflow.
726e0ab1
PE
1020 (ct_colors_allocated_max): New constant.
1021 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1022 overflow.
3256efce 1023
726e0ab1
PE
1024 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1025 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1026 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1027 Use ptrdiff_t, not int, to count maps.
1028 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1029 calculations. Don't update size until allocation succeeds.
1030 Redo calculations to avoid overflow.
726e0ab1
PE
1031 * keyboard.h: Change prototypes to match the above.
1032
1033 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1034 to count maps.
1035 (current_minor_maps): Check for size calculation overflow.
1036 * keymap.h: Change prototypes to match the above.
1037
1038 * lread.c (read1, init_obarray): Don't update size until alloc done.
1039
1040 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1041 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1042
726e0ab1
PE
1043 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1044 Now ptrdiff_t, not int.
1045 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1046 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1047
1048 * process.c (Fnetwork_interface_list): Check for overflow
1049 in size calculation.
1050
1051 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1052
1053 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1054 overflow. Don't bother calling xmalloc when xrealloc will do.
1055
1056 * search.c (Freplace_match): Check for size calculation overflow.
1057 (Fset_match_data): Don't assume list lengths fit in 'int'.
1058
1059 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1060 for command line length. Do not attempt to address one before the
1061 beginning of an array, as that's not portable.
1062
1063 * term.c (max_frame_lines): Remove; unused.
1064 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1065 not int.
1066 (encode_terminal_code, calculate_costs): Check for size
1067 calculation overflow.
1068 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1069 table lengths and related sizes. Don't update size until alloc
1070 done. Redo calculations to avoid overflow.
1071 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1072
1073 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1074 subtracting pointers.
1075 (gobble_line): Check for overflow more carefully. Don't update size
1076 until alloc done.
1077
1078 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1079 Don't update size until alloc done.
1080 Redo size calculations to avoid overflow.
1081 Check for size calculation overflow.
0065d054 1082 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1083
1084 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1085 Use ptrdiff_t, not int, for sizes.
1086 (store_mode_line_noprop_char): Don't update size until alloc done.
1087
0065d054
PE
1088 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1089 Use ptrdiff_t, not int, for sizes.
1090 (Finternal_make_lisp_face, cache_face):
1091 Check for size calculation overflow.
1092 (cache_face): Treat size calculation overflows as if they were
1093 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1094
1095 * xfns.c (x_encode_text, x_set_name_internal)
1096 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1097 sizes, since they can exceed INT_MAX in size. Check for size
1098 calculation overflow.
1099
0065d054
PE
1100 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1101 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1102 Don't update size until alloc done.
1103
0065d054 1104 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1105 as sprintf is limited to int lengths.
1d526e2f 1106
252c5ee1
PE
1107 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1108 (X_LONG_MIN): New macros.
864d7ce7
PE
1109 Use them to make the following changes clearer.
1110 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1111 This change doesn't affect the value now, but it may help remind
1112 future maintainers not to raise the value too much later.
1113 (SELECTION_QUANTUM): Remove, replacing with ...
1114 (selection_quantum): ... new function, which avoids overflow.
1115 All uses changed.
1116 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1117 assumption that selection length fits in 'int'.
1118 (x_reply_selection_request, x_handle_selection_request)
1119 (x_get_window_property, receive_incremental_selection)
1120 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1121 (lisp_data_to_selection_data, clean_local_selection_data):
1122 Use ptrdiff_t, not int, to record length of selection.
1123 (x_reply_selection_request, x_get_window_property)
1124 (receive_incremental_selection, x_property_data_to_lisp):
1125 Redo calculations to avoid overflow.
1126 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1127 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1128 something.
1129 (x_get_window_property, receive_incremental_selection)
1130 (lisp_data_to_selection_data, x_property_data_to_lisp):
1131 Check for size-calculation overflow.
1132 (x_get_window_property, receive_incremental_selection)
1133 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1134 Don't store size until memory allocation succeeds.
1135 (x_get_window_property): Plug memory leak on memory exhaustion.
1136 Don't double-block input; malloc is safe here. Don't assume 2**34
1137 - 4 fits in unsigned long. Add an xassert to check
1138 XGetWindowProperty overflow. Be more careful about overflow
1139 calculations, and distinguish size from memory overflow better.
1140 (receive_incremental_selection): When tracing, don't assume
1141 unsigned int is less than INT_MAX.
1142 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1143 harmful) conversions of unsigned short to int.
1144 (lisp_data_to_selection_data): Don't assume that integers
1145 in the range -65535 through -1 fit in an X unsigned short.
1146 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1147 result parameters unless successful. Rely on cons_to_unsigned
1148 to report problems with elements; the old code wasn't right anyway.
1149 (x_check_property_data): Check for int overflow; we cannot use
1150 a wider type due to X limits.
1151 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1152
726e0ab1 1153 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1154
0065d054
PE
1155 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1156 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1157 (x_color_cells): Don't store size until memory allocation succeeds.
1158 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1159 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1160 (x_term_init): Don't assume length fits in int (sprintf is limited
1161 to int size).
bc18e09d 1162
ebfa62c0
PE
1163 Use ptrdiff_t for composition IDs.
1164 * character.c (lisp_string_width):
1165 * composite.c (composition_table_size, n_compositions)
1166 (get_composition_id, composition_gstring_from_id):
1167 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1168 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1169 * window.c (Frecenter):
1170 Use ptrdiff_t, not int, for composition IDs.
1171 * composite.c (get_composition_id): Check for integer overflow.
1172 * composite.h: Adjust prototypes to match the above changes.
1173
d3411f89
PE
1174 Use ptrdiff_t for hash table indexes.
1175 * category.c (hash_get_category_set):
1176 * ccl.c (ccl_driver):
1177 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1178 * coding.c (coding_system_charset_list, detect_coding_system):
1179 * coding.h (struct coding_system.id):
1180 * composite.c (get_composition_id, gstring_lookup_cache):
1181 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1182 * image.c (xpm_get_color_table_h):
1183 * lisp.h (hash_lookup, hash_put):
1184 * minibuf.c (Ftest_completion):
1185 Use ptrdiff_t for hash table indexes, not int (which is too
1186 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1187 32-bit --with-wide-int hosts).
1188
e097a6fa
PE
1189 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1190 Add a FIXME comment about memory leaks.
1191 (syms_of_charset): Don't assume xmalloc returns.
1192
5637687f
PE
1193 Don't assume that stated character widths fit in int.
1194 * character.c (Fchar_width, c_string_width, lisp_string_width):
1195 * character.h (CHAR_WIDTH):
1196 * indent.c (MULTIBYTE_BYTES_WIDTH):
1197 Use sanitize_char_width to avoid undefined and/or bad behavior
1198 with outlandish widths.
a66cfb1c 1199 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1200 now that we have two such functions. All uses changed.
1201 (sanitize_char_width): New inline function.
1202
a2271ba2
PE
1203 Don't assume that tab-width fits in int.
1204 * character.h (sanitize_width): New inline function.
1205 (SANE_TAB_WIDTH): New macro.
1206 (ASCII_CHAR_WIDTH): Use it.
1207 * indent.c (sane_tab_width): Remove. All uses replaced by
1208 SANE_TAB_WIDTH (current_buffer).
1209 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1210
18c52557
PE
1211 * fileio.c: Integer overflow issues with file modes.
1212 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1213
caeeedc1
PE
1214 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1215 Remove unreachable code.
1216 (read_hex, load_charset_map_from_file): Check for integer overflow.
1217
50849c52
PE
1218 * xterm.c: don't go over XClientMessageEvent limit
1219 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1220 (x_send_scroll_bar_event): Likewise. Check that the size does not
1221 exceed limits imposed by XClientMessageEvent, as well as the usual
1222 ptrdiff_t and size_t limits.
1223
b13995db
PE
1224 * keyboard.c: Overflow, signedness and related fixes.
1225 (make_lispy_movement): Use same integer type in forward decl
1226 that is used in the definition.
1227 (read_key_sequence, keyremap_step):
1228 Change bufsize argument back to int, undoing my 2011-03-30 change.
1229 We prefer signed types, and int is wide enough here.
1230 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1231 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1232 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1233 length, not size_t. Use ptrdiff_t for index, not int.
1234 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1235 possibility of integer overflow.
1236
13464394
PE
1237 Overflow, signedness and related fixes for images.
1238
1239 * dispextern.h (struct it.stack[0].u.image.image_id)
1240 (struct_it.image_id, struct image.id, struct image_cache.size)
1241 (struct image_cache.used, struct image_cache.ref_count):
1242 * gtkutil.c (update_frame_tool_bar):
1243 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1244 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1245 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1246 * nsmenu.m (update_frame_tool_bar):
1247 * xdisp.c (calc_pixel_width_or_height):
1248 * xfns.c (image_cache_refcount):
1249 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1250 on typical 64-bit hosts.
1251
1252 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1253 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1254 Omit unnecessary casts to int.
1255 (parse_image_spec): Check that integers fall into 'int' range
1256 when the callers expect that.
1257 (image_ascent): Redo ascent calculation to avoid int overflow.
1258 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1259 (lookup_image): Remove unnecessary tests.
1260 (xbm_image_p): Locals are now of int, not EMACS_INT,
1261 since parse_image_check makes sure they fit into int.
1262 (png_load, gif_load, svg_load_image):
1263 Prefer int to unsigned where either will do.
1264 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1265 old tiff_error_handler and tiff_warning_handler.
1266 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1267 stack buffer overflows. It uses only the features of vsnprintf
1268 that are common to both POSIX and native Microsoft.
1269 (tiff_error_handler, tiff_warning_handler): Use it.
1270 (tiff_load, gif_load, imagemagick_load_image):
1271 Don't assume :index value fits in 'int'.
1272 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1273 (imagemagick_load_image): Check that crop parameters fit into
1274 the integer types that MagickCropImage accepts. Don't assume
1275 Vimagemagick_render_type has a nonnegative value. Don't assume
1276 size_t fits in 'long'.
1277 (gs_load): Use printmax_t to print the widest integers possible.
1278 Check for integer overflow when computing image height and width.
1279
c11821d4
EZ
12802011-08-26 Eli Zaretskii <eliz@gnu.org>
1281
1282 * xdisp.c (redisplay_window): Don't force window start if point
1283 will be invisible in the resulting window. (Bug#9324)
1284
0c95fcf7
EZ
12852011-08-25 Eli Zaretskii <eliz@gnu.org>
1286
1287 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1288 the display spec is of the form `(space ...)'.
1289 (handle_display_spec): Return the value returned by
1290 handle_single_display_spec, not just 1 or zero.
1291 (handle_single_display_spec): If the display spec is of the form
1292 `(space ...)', and specifies display in the text area, return 2
1293 rather than 1.
fee65a97 1294 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1295 accurately, and prefer exact match for point under bidi.
1296 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1297
1298 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1299 into disp_prop; all users changed.
1300
1301 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1302 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1303 for the text covered by the display property.
1304
e4ed06f1
CY
13052011-08-25 Chong Yidong <cyd@stupidchicken.com>
1306
1307 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1308 Change return value to nil.
1309 (Frecord_buffer): Delete unused function.
1310
f67cdd7f
EZ
13112011-08-24 Eli Zaretskii <eliz@gnu.org>
1312
5980d4c6
EZ
1313 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1314 buffers, return left-to-right.
8610fe8b
EZ
1315 (set_cursor_from_row): Consider candidate row a win if its glyph
1316 represents a newline and point is on that newline. Fixes cursor
1317 positioning on the newline at EOL of R2L text within L2R
1318 paragraph, and vice versa.
1319 (try_cursor_movement): Check continued rows, in addition to
1320 continuation rows. Fixes unwarranted scroll when point enters a
1321 continued line of R2L text within an L2R paragraph, or vice versa.
1322 (cursor_row_p): Consider the case of point being equal to
1323 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1324 from the end of a short line to the beginning of a continued line
1325 of R2L text within L2R paragraph.
1326 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1327 composed characters.
5980d4c6 1328
f67cdd7f
EZ
1329 * bidi.c (bidi_check_type): Use xassert.
1330 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1331 members.
1332
bca633fb
EZ
13332011-08-23 Eli Zaretskii <eliz@gnu.org>
1334
1335 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1336 a character.
1337
4a5885a7
CY
13382011-08-23 Chong Yidong <cyd@stupidchicken.com>
1339
1340 * nsfont.m (ns_otf_to_script): Fix typo.
1341
0902a04e
KH
13422011-08-22 Kenichi Handa <handa@m17n.org>
1343
1344 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1345 extra slot even if the purpose is char-code-property-table.
1346
1a2e6670
EZ
13472011-08-23 Eli Zaretskii <eliz@gnu.org>
1348
8ddde651
EZ
1349 * xdisp.c (redisplay_window): When computing centering_position,
1350 account for the height of the header line. (Bug#8874)
1351
425cc014
EZ
1352 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1353 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1354 candidate is selected by the mouse, and that candidate has a
1355 composed character under the mouse.
1356
1a2e6670
EZ
1357 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1358 coordinates reported by pos-visible-in-window-p for a composed
1359 character in column zero.
1360
8b76d6f8
SM
13612011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1362
1363 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1364
dac347dd
EZ
13652011-08-22 Eli Zaretskii <eliz@gnu.org>
1366
1367 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1368 consider it a hit if to_charpos is anywhere in the range of the
1369 composed buffer positions.
1370
e013fb34
CY
13712011-08-22 Chong Yidong <cyd@stupidchicken.com>
1372
1373 * image.c (gif_load): Don't assume that each subimage has the same
1374 dimensions as the base image. Handle disposal method that is
1375 "undefined" by the gif spec (Bug#9335).
1376
bd1ba3e8
CY
13772011-08-20 Chong Yidong <cyd@stupidchicken.com>
1378
1379 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1380 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1381
54a1215b
EZ
13822011-08-19 Eli Zaretskii <eliz@gnu.org>
1383
823564e5
EZ
1384 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1385 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1386 from an Org mode buffer to a Speedbar frame.
1387
54a1215b
EZ
1388 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1389 a composition, take its buffer position from IT->cmp_it.charpos.
1390 Fixes cursor positioning at the beginning of a line that begins
1391 with a composed character.
1392
9778ebcc
EZ
13932011-08-18 Eli Zaretskii <eliz@gnu.org>
1394
0be6ee06
EZ
1395 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1396 character bidirectional type, use STRONG_L instead. Fixes crashes
1397 in a buffer produced by `describe-categories'.
1398
9778ebcc
EZ
1399 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1400 members before the level stack, so they would be saved and
1401 restored when copying iterator state. Fixes incorrect reordering
1402 around TABs covered by display properties.
1403
156bffbe
AS
14042011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1405
6b02f655 1406 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 1407
72ad093b
CY
14082011-08-17 Chong Yidong <cyd@stupidchicken.com>
1409
1410 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1411 (internal_condition_case_2, internal_condition_case_n):
1412 Remove unnecessary aborts (Bug#9081).
72ad093b 1413
35774242
EZ
14142011-08-17 Eli Zaretskii <eliz@gnu.org>
1415
1416 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1417 has no `load' handler, try opening the file locally. (Bug#9311)
1418
db76dd85
KB
14192011-08-16 Ken Brown <kbrown@cornell.edu>
1420
1421 * gmalloc.c: Expand comment.
1422
b215eee5
EZ
14232011-08-16 Eli Zaretskii <eliz@gnu.org>
1424
1425 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1426 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1427
a4579d33
KB
14282011-08-16 Ken Brown <kbrown@cornell.edu>
1429
1430 Fix memory allocation problems in Cygwin build (Bug#9273).
1431
1432 * unexcw.c ( __malloc_initialized): Declare external variable.
1433 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1434
8b76d6f8
SM
1435 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1436 New variables.
a4579d33
KB
1437 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1438 dumped emacs.
1439 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1440 in the static heap.
1441 [CYGWIN] (special_realloc): New function.
1442 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1443 requests to realloc storage in the static heap.
1444
3ebec551
PE
14452011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1446
1447 * bidi.c (bidi_initialize): Remove unused local.
1448
9fd8be00
EZ
14492011-08-15 Eli Zaretskii <eliz@gnu.org>
1450
6b02f655
SM
1451 * bidimirror.h:
1452 * biditype.h: Remove file.
1453 * makefile.w32-in ($(BLD)/bidi.$(O)):
1454 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
1455
1456 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1457
1458 * chartab.c: Improve commentary for the uniprop_table API.
1459
32413314
EZ
1460 * bidi.c (bidi_paragraph_init): Support zero value of
1461 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1462 (bidi_initialize): Use uniprop_table instead of including
1463 biditype.h and bidimirror.h.
32413314 1464
9fd8be00
EZ
1465 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1466 coordinates of the iterator when restoring from ppos_it.
1467 (Bug#9296)
1468
5cf2b69b
KH
14692011-08-14 Kenichi Handa <handa@m17n.org>
1470
1471 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1472 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1473
daf17d00
EZ
14742011-08-14 Eli Zaretskii <eliz@gnu.org>
1475
1476 * xdisp.c (move_it_in_display_line_to): Don't invoke
1477 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1478 ppos_it. Fixes vertical cursor motion when line beginning is
1479 covered by an image. (Bug#9296)
1480
08e3161a
JD
14812011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1482
1483 * nsterm.h (ns_run_ascript): Declare.
1484 (NSAPP_DATA2_RUNASSCRIPT): Define.
1485
1486 * nsfns.m (as_script, as_result, as_status): New static variables.
1487 (ns_run_ascript): New function.
5e617bc2 1488 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1489 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1490 the event loop. Get status from as_status (Bug#7276).
1491
1492 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1493 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1494 the event loop (Bug#7276).
1495
a3720aa2
AS
14962011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1497
1498 * gnutls.c (QCgnutls_bootprop_priority)
1499 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1500 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1501 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1502 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1503 (QCgnutls_bootprop_verify_hostname_error)
1504 (QCgnutls_bootprop_callbacks_verify): Rename from
1505 Qgnutls_bootprop_..., all uses changed.
1506
1507 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1508 uses changed.
1509
0a0d27fb
PE
15102011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1511
19d5c50c
PE
1512 * xfaces.c (Qframe_set_background_mode): Now static.
1513 * dispextern.h (Qframe_set_background_mode): Remove decl.
1514
0a0d27fb
PE
1515 * process.c (Fnetwork_interface_info): Declare local only if needed.
1516
377538cb
JD
15172011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1518
1519 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1520 (Fnetwork_interface_list): Allocate in increments of bytes instead
1521 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1522 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1523 sockaddr.
1524 (struct ifflag_def): notrailers is smart on OSX.
1525 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1526 Get hardware address with getifaddrs if available.
1527
08fff70c
EZ
15282011-08-12 Eli Zaretskii <eliz@gnu.org>
1529
1530 * xdisp.c (iterate_out_of_display_property): xassert that
1531 IT->position is set to within IT->object's boundaries. Break from
1532 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1533 when IT->position is set up wrongly due to some bug.
1534 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1535 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1536 entry. Force push_it to save on the stack the current
1537 buffer/string position, to be restored by pop_it. Fix flags in
1538 the iterator structure wrt the object coming from a display
1539 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1540 properties. (Bug#9284)
1541
7be1c708 15422011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1543
7be1c708
CY
1544 * fontset.c (fontset_get_font_group): Add proper type checks.
1545 (Bug#9172)
aac0c6e3 1546
7be1c708 15472011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1548
7be1c708
CY
1549 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1550 and LC_VERSION_MIN_MACOSX.
1551 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1552 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1553
97bb72a6
EZ
15542011-08-08 Eli Zaretskii <eliz@gnu.org>
1555
1556 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1557 no-display-properties-and-no-overlays under bidi display.
1558 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1559 properties and overlays.
97bb72a6 1560
d5617611
CY
15612011-08-08 Chong Yidong <cyd@stupidchicken.com>
1562
37e11a63
CY
1563 * editfns.c (Fset_time_zone_rule): Document relationship with the
1564 setenv function.
1565
d5617611
CY
1566 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1567 the font entity extracted from the cache (Bug#8109).
1568
58872834
CY
15692011-08-07 Chong Yidong <cyd@stupidchicken.com>
1570
1571 * composite.c (autocmp_chars): Don't reset point. That is done by
1572 restore_point_unwind (Bug#5984).
1573
75bfc667
JL
15742011-08-07 Juri Linkov <juri@jurta.org>
1575
1576 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1577 to show the arg `TIME' instead of `TIMEVAL'.
1578
d1410150
EZ
15792011-08-06 Eli Zaretskii <eliz@gnu.org>
1580
1581 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1582 display property strides EOL and includes a newline, as in
1583 longlines-mode. (Bug#9254)
75b771e4
EZ
1584 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1585 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1586
1587 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1588 is non-zero, even if the data buffer is NULL. Fixes a crash in
1589 vertical-motion with longlines-mode. (Bug#9254)
1590
35928349
EZ
15912011-08-05 Eli Zaretskii <eliz@gnu.org>
1592
ec7cc85b
EZ
1593 * bidi.c <bidi_cache_total_alloc>: Now static.
1594 (bidi_initialize): Initialize bidi_cache_total_alloc.
1595
8b76d6f8 1596 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1597 cache. (Bug#9221)
1598
1599 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1600 amount allocated this far in `bidi_cache_total_alloc'.
1601 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1602 non-zero, only free the data buffer without restoring the cache
1603 contents. All callers changed.
1604
1605 * dispextern.h (bidi_unshelve_cache): Update prototype.
1606
1607 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1608 (move_it_in_display_line, move_it_to)
1609 (move_it_vertically_backward, move_it_by_lines): Replace the call
1610 to xfree to an equivalent call to bidi_unshelve_cache.
1611 (move_it_in_display_line_to): Fix logic of returning
412b6358 1612 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1613
e2e2423b
EZ
16142011-08-05 Eli Zaretskii <eliz@gnu.org>
1615
1616 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1617 came from a string character with a `cursor' property. (Bug#9229)
1618
ae9e757a
JD
16192011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1620
1621 * Makefile.in (LIB_PTHREAD): New variable.
1622 (LIBES): Add LIB_PTHREAD (Bug#9216).
1623
1624 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1625 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1626
213bd7f2
AS
16272011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1628
6b02f655 1629 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 1630
99aaf75f
JD
16312011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1632
1633 * xterm.c (x_find_topmost_parent): New function.
1634 (x_set_frame_alpha): Find topmost parent window with
1635 x_find_topmost_parent and set the property there also (bug#9181).
1636 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1637
c74e9d86
PE
16382011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1639
1640 * callproc.c (Fcall_process): Avoid vfork clobbering
1641 the local vars buffer, coding_systems, current_dir.
1642
640c8776
SM
16432011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1644
1645 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1646
f26d0e4c
PE
16472011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1648
8a10d76c
PE
1649 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1650 so that it is not optimized away.
1651
f26d0e4c
PE
1652 * xdisp.c (compute_display_string_pos): Remove unused local.
1653
55439c61
EZ
16542011-08-02 Eli Zaretskii <eliz@gnu.org>
1655
1656 Fix slow cursor motion and scrolling in large buffers with
1657 selective display, like Org Mode buffers. (Bug#9218)
1658
1659 * dispextern.h (struct bidi_it): New member disp_prop_p.
1660
1661 * xdisp.c: Remove one-slot cache of display string positions.
1662 (compute_display_string_pos): Accept an additional argument
5e617bc2 1663 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1664 for a display string or property. If found, set DISP_PROP_P
1665 non-zero.
1666
1667 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1668 DISP_PROP_P, and pass it to compute_display_string_pos.
1669 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1670 non-zero. All callers of bidi_fetch_char changed.
1671
fb33fa43
SM
16722011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1673
1674 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1675
b099e063
DM
16762010-12-03 Don March <don@ohspite.net>
1677
1678 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1679 last character M-[char] is translated to ESC [char] (bug#7541).
1680
5cc7f7af
KH
16812011-08-02 Kenichi Handa <handa@m17n.org>
1682
d0fffa3f 1683 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1684
1685 * chartab.c (uniprop_table): Make it non-static.
1686
525d5e6e
EZ
16872011-08-01 Eli Zaretskii <eliz@gnu.org>
1688
1689 * xdisp.c (forward_to_next_line_start): Accept additional argument
1690 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1691 on the newline.
1692 (reseat_at_next_visible_line_start): Use the bidi iterator state
1693 returned by forward_to_next_line_start to restore the state of
1694 it->bidi_it after backing up to previous newline. (Bug#9212)
1695
31011111
AS
16962011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1697
1698 * regex.c (re_comp): Protoize.
1699 (re_exec): Fix return type.
1700 (regexec): Fix type of `ret'. (Bug#9203)
1701
476371c4
PE
17022011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1703
e5d76069
PE
1704 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1705 This is needed if max-image-size is a floating-point number.
1706
9a79b20c
AS
17072011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1708
1709 * print.c (print_object): Print empty symbol as ##.
1710
1711 * lread.c (read1): Read ## as empty symbol.
1712
d8c2fa78
AA
17132011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1714
1715 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1716 setting frame foreground color (Bug#9175).
1717 (x_set_background_color): Likewise.
1718
ffe57a7a
AA
1719 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1720 contents (Bug#9176).
1721 (EmacsTooltip -init): Remove bezels and add shadows to
1722 tooltip windows.
1723
bf3492a5
AA
1724 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1725 or scroll bar (Bug#8470).
1726
d55e9c53
AA
1727 * nsfont.m (nsfont_open): Remove assignment to voffset and
1728 unnecessary vars hshink, expand, hd, full_height, min_height.
1729 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1730
1731 * nsterm.h (nsfont_info): Remove voffset field.
1732
d8c2fa78 17332011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1734
1735 Implement strike-through and overline on NextStep (Bug#8863).
1736
1737 * nsfont.m (nsfont_open): Use underline position provided by font,
1738 instead of hard-coded value of 2.
1739 (nsfont_draw): Call ns_draw_text_decoration instead.
1740
1741 * nsterm.h: Add declaration for ns_draw_text_decoration.
1742
1743 * nsterm.m (ns_draw_text_decoration): New function for drawing
1744 underline, overline, and strike-through.
1745 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1746 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 1747 accommodate underlining, etc.
4843aac3 1748
4cc60b9b
EZ
17492011-07-28 Eli Zaretskii <eliz@gnu.org>
1750
bc7ece87
EZ
1751 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1752 default.
4cc60b9b 1753
476371c4
PE
17542011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1755
66606eea
PE
1756 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1757 Without this fix, if a signal arrives just after memory fills up,
1758 'malloc' might be invoked reentrantly.
1759
476371c4
PE
1760 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1761 In other words, assume that every image size is allowed, on non-X
1762 hosts. This assumption is probably wrong, but it lets Emacs compile.
1763
f3fcc40d
AS
17642011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1765
1766 * regex.c (re_iswctype): Convert return values to boolean.
1767
350c992f
EZ
17682011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1769
1770 * xdisp.c (compute_display_string_pos): Don't use cached display
1771 string position if the buffer had its restriction changed.
1772 (Bug#9184)
1773
5266b4bb
PE
17742011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1775
1776 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1777
2573a837 17782011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1779
41f55ccd 1780 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1781
39e378da
PE
1782 * bidi.c: Integer size and overflow fixes.
1783 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1784 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1785 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1786 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1787 (bidi_find_other_level_edge):
1788 Use ptrdiff_t instead of EMACS_INT where either will do.
1789 This works better on 32-bit hosts configured --with-wide-int.
1790 (bidi_cache_ensure_space): Check for size-calculation overflow.
1791 Use % rather than repeated addition, for better worst-case speed.
1792 Don't set bidi_cache_size until after xrealloc returns, because it
1793 might not return.
1794 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1795 (bidi_cache_ensure_space): Also check that the bidi cache size
1796 does not exceed that of the largest Lisp string or buffer. See Eli
1797 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1798
5e927815
PE
1799 * alloc.c (__malloc_size_t): Remove.
1800 All uses replaced by size_t. See Andreas Schwab's note
1801 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1802
ca4aa935
PE
1803 * image.c: Improve checking for integer overflow.
1804 (check_image_size): Assume that f is nonnull, since
1805 it is always nonnull in practice. This is one less thing to
1806 worry about when checking for integer overflow later.
1807 (x_check_image_size): New function, which checks for integer
1808 overflow issues inside X.
1809 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1810 This removes the need for a memory_full check.
1811 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1812 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1813 (xbm_read_bitmap_data): Change locals back to 'int', since
1814 their values must fit in 'int'.
1815 (xpm_load_image, png_load, tiff_load):
1816 Invoke x_create_x_image_and_pixmap earlier,
1817 to avoid much needless work if the image is too large.
1818 (tiff_load): Treat overly large images as if
1819 x_create_x_image_and_pixmap failed, not as malloc failures.
1820 (gs_load): Use x_check_image_size.
1821
5f8f9cc2
PE
1822 * gtkutil.c: Omit integer casts.
1823 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1824 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1825
5adf60bc
PE
1826 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1827
c8907a93
PE
1828 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1829 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1830 would wrongly return t on a 64-bit host.
1831
e3c25c68
PE
1832 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1833 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1834 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1835 and therefore cause GCC to emit a bogus diagnostic in some cases.
1836
3f791afe
PE
1837 * image.c: Integer signedness and overflow and related fixes.
1838 This is not an exhaustive set of fixes, but it's time to
1839 record what I've got.
1840 (lookup_pixel_color, check_image_size): Remove redundant decls.
1841 (check_image_size): Don't assume that arbitrary EMACS_INT values
1842 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1843 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1844 (tiff_load, imagemagick_load_image):
1845 Check for overflow in size calculations.
1846 (x_create_x_image_and_pixmap): Remove unnecessary test for
1847 xmalloc returning NULL; that can't happen.
1848 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1849 (xpm_color_bucket): Use better integer hashing function.
1850 (xpm_cache_color): Don't possibly over-allocate memory.
1851 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1852 (gif_memory_source):
1853 Use ptrdiff_t, not int or size_t, to record sizes.
1854 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1855 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1856 either works, as we prefer signed integers.
1857 (tiff_read_from_memory, tiff_write_from_memory):
1858 Return tsize_t, not size_t, since that's what the TIFF API wants.
1859 (tiff_read_from_memory): Don't fail simply because the read would
1860 go past EOF; instead, return a short read.
1861 (tiff_load): Omit no-longer-needed casts.
1862 (Fimagemagick_types): Don't assume size fits into 'int'.
1863
3cc5a532
PE
1864 Improve hashing quality when configured --with-wide-int.
1865 * fns.c (hash_string): New function, taken from sxhash_string.
1866 Do not discard information about ASCII character case; this
1867 discarding is no longer needed.
1868 (sxhash-string): Use it. Change sig to match it. Caller changed.
1869 * lisp.h: Declare it.
1870 * lread.c (hash_string): Remove, since we now use fns.c's version.
1871 The fns.c version returns a wider integer if --with-wide-int is
1872 specified, so this should help the quality of the hashing a bit.
1873
b312a492
PE
1874 * emacs.c: Integer overflow minor fix.
1875 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1876 Define only if GNU_LINUX.
1877 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1878
dfd153ae
PE
1879 * dispnew.c: Integer signedness and overflow fixes.
1880 Remove unnecessary forward decls, that were a maintenance hassle.
1881 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1882 All uses changed.
1883 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1884 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1885 (prepare_desired_row, line_draw_cost):
1886 Use int, not unsigned, where either works.
1887 (save_current_matrix, restore_current_matrix):
1888 Use ptrdiff_t, not size_t, where either works.
1889 (init_display): Check for overflow more accurately, and without
1890 relying on undefined behavior.
1891
a81d11a3
PE
1892 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1893 Remove, replacing with the new symbols in lisp.h. All uses changed.
1894 * fileio.c (make_temp_name):
1895 * filelock.c (lock_file_1, lock_file):
1896 * xdisp.c (message_dolog):
1897 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1898 Use pMd etc. instead.
1899 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1900 replacing the pWIDE etc. symbols removed from editfns.c.
1901
3300e6fd
PE
1902 * keyboard.h (num_input_events): Now uintmax_t.
1903 This is (very slightly) less likely to mess up due to wraparound.
1904 All uses changed.
1905
fd05c7e9
PE
1906 * buffer.c: Integer signedness fixes.
1907 (alloc_buffer_text, enlarge_buffer_text):
1908 Use ptrdiff_t rather than size_t when either will do, as we prefer
1909 signed integers.
1910
903fe15d
PE
1911 * alloc.c: Integer signedness and overflow fixes.
1912 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1913 (__malloc_size_t): Default to size_t, not to int.
1914 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1915 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1916 Prefer ptrdiff_t to size_t when either would do, as we prefer
1917 signed integers.
1918 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1919 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1920 Now const. Initialize with values that are in range even if char
1921 is signed.
1922 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1923 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1924 These functions do the right thing with sizes > 2**32.
1925 (check_depth): Now ptrdiff_t, not int.
1926 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1927 Adjust to new way of storing sizes. Check for size overflow bugs
1928 in rest of code.
1929 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1930 slightly wrong anyway, as it missed one instance of
1931 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1932 (refill_memory_reserve): Omit needless cast to size_t.
1933 (mark_object_loop_halt): Mark as externally visible.
1934
ac82cc6a
PE
1935 * xselect.c: Integer signedness and overflow fixes.
1936 (Fx_register_dnd_atom, x_handle_dnd_message):
1937 Use ptrdiff_t, not size_t, since we prefer signed.
1938 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1939 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1940 x_dnd_atoms_size and x_dnd_atoms_length.
1941
c2d1e36d
PE
1942 * doprnt.c: Prefer signed to unsigned when either works.
1943 * eval.c (verror):
1944 * doprnt.c (doprnt):
1945 * lisp.h (doprnt):
1946 * xdisp.c (vmessage):
1947 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1948 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1949 prefer signed arithmetic to avoid comparison confusion.
1950 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1951 but is a bit tricky.
1952
0e926e56
PE
1953 Assume freestanding C89 headers, string.h, stdlib.h.
1954 * data.c, doprnt.c, floatfns.c, print.c:
1955 Include float.h unconditionally.
1956 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1957 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1958 * regex.c: Likewise for stddef.h, string.h.
1959 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1960 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1961 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1962 (STDC_HEADERS): Remove obsolete defines.
1963 * sysdep.c: Include limits.h unconditionally.
1964
9cfdb3ec
PE
1965 Assume support for memcmp, memcpy, memmove, memset.
1966 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1967 * regex.c (memcmp, memcpy):
1968 Remove; we assume C89 now.
1969
1970 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1971 (__malloc_safe_bcopy): Remove; no longer needed.
1972
cf950e6b 1973 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1974 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1975 well either way, and we prefer signed to unsigned.
1976
dbf38e02
LMI
19772011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1978
1979 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1980 closes the connection while we're reading (bug#9182).
1981
d6f0886c 19822011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 1983
d6f0886c
JD
1984 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1985 are specified (Bug#9168).
24e0f6b1 1986
2eb1f9e6
PE
19872011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1988
1989 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1990 Found by GCC static checking and --with-wide-int on a 32-bit host.
1991
22381272 19922011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1993
1994 * xdisp.c (compute_display_string_pos): Fix logic of caching
1995 previous display string position. Initialize cached_prev_pos to
1996 -1. Fixes slow-down at the beginning of a buffer.
1997
f25e39b4
EZ
19982011-07-24 Eli Zaretskii <eliz@gnu.org>
1999
2000 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2001 for attrs[LFACE_FONTSET_INDEX].
2002
04c4b52e
PE
20032011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2004
2005 * xml.c (parse_region): Remove unused local
2006 that was recently introduced.
2007
c1734fbd
EZ
20082011-07-23 Eli Zaretskii <eliz@gnu.org>
2009
be18c5a5
EZ
2010 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2011 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2012
c1734fbd
EZ
2013 * xdisp.c (move_it_in_display_line_to): Record the best matching
2014 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2015 exit if none of the characters scanned was an exact match.
2016 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2017 when exact match is impossible due to invisible text, and the
2018 lines are truncated.
2019
a258d627
JD
20202011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2021
2022 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2023 for OSX >= 10.7.
2024
b6d5a689
EZ
20252011-07-22 Eli Zaretskii <eliz@gnu.org>
2026
0f74f785
EZ
2027 Fix a significant slow-down of cursor motion with C-n, C-p,
2028 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2029 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2030 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2031 (next_element_from_buffer): Call compute_stop_pos_backwards to
2032 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2033 base_level_stop.
2034 (reseat): Don't look for prev_stop, as that could mean a very long
2035 run.
2036 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2037 <cached_disp_overlay_modiff>: Cache for last found display string
2038 position.
551918c1 2039 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2040 about the same buffer in the same area of character positions, and
2041 the buffer wasn't changed since the time the display string
2042 position was cached.
551918c1 2043
b2d0c91a
EZ
20442011-07-22 Eli Zaretskii <eliz@gnu.org>
2045
2046 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2047 is an integer, which is important for empty lines. (Bug#9149)
2048
043604ee
CY
20492011-07-22 Chong Yidong <cyd@stupidchicken.com>
2050
2051 * frame.c (Fmodify_frame_parameters): In tty case, update the
2052 default face if necessary (Bug#4238).
2053
da4adb04
CY
20542011-07-21 Chong Yidong <cyd@stupidchicken.com>
2055
2056 * editfns.c (Fstring_to_char): No need to explain what a character
2057 is in the docstring (Bug#6576).
2058
9abd0532
LMI
20592011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2060
2061 * xml.c (parse_region): Make sure we always return a tree.
2062
36881d16
HK
20632011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2064
2065 * xml.c (parse_region): If a document contains only comments,
2066 return that, too.
2067
1e98674d
LMI
20682011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2069
2070 * xml.c (make_dom): Return comments, too.
2071
590bd467
PE
20722011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2073
2074 Port to OpenBSD.
2075 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2076 and the surrounding thread.
2077 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2078 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2079 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2080 timer goes off.
2081 * s/openbsd.h (BROKEN_SIGIO): Define.
2082 * unexelf.c (unexec) [__OpenBSD__]:
2083 Don't update the .mdebug section of the Alpha COFF symbol table.
2084
f41628b2
LMI
20852011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2086
2087 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2088 (bug#8460).
2089
b59b67c5
PE
20902011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2091
15e3a074
PE
2092 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2093 This fixes some race conditions on the permissions of any newly
2094 created file.
2095
41bed37d
PE
2096 * alloc.c (valid_pointer_p): Use pipe, not open.
2097 This fixes some permissions issues when debugging.
2098
b59b67c5
PE
2099 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2100 If fchown fails to set both uid and gid, try to set just gid,
2101 as that is sometimes allowed. Adjust the file's mode to eliminate
2102 setuid or setgid bits that are inappropriate if fchown fails.
2103
925a6be7
SM
21042011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2105
2106 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2107 to compare Lisp_Objects.
2108 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2109 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2110 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2111
52968808
AS
21122011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2113
0a6a104b
AS
2114 * lread.c (read_integer): Unread even EOF character.
2115 (read1): Likewise. Properly record start position of symbol.
2116
52968808
AS
2117 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2118 symbol character follows.
2119
9e381cdd
PE
21202011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2121
2122 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2123 This works around a problem with the previous change to Fcopy_file.
2124 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2125 and without this change, GCC might complain about discarding
2126 fchown's return value.
2127
b5641435
JB
21282011-07-16 Juanma Barranquero <lekktu@gmail.com>
2129
2130 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2131
a8031457
PE
21322011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2133
2134 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2135
dd889327
LMI
21362011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2137
750c33f7
LMI
2138 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2139 it's used from the C level.
2140
dd889327
LMI
2141 * process.c: Use the same condition for POLL_FOR_INPUT in both
2142 keyboard.c and process.c (bug#1858).
2143
87e86684
LM
21442011-07-09 Lawrence Mitchell <wence@gmx.li>
2145
2146 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2147 (Fgnutls_boot): Use it.
2148
64348f40
AS
21492011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2150
2151 * doc.c (Fsubstitute_command_keys): Revert last change.
2152
1d698799
LMI
21532011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2154
f863868c
LMI
2155 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2156 quotes the next character, and doesn't affect other longer
2157 sequences (bug#8935).
2158
1d698799
LMI
2159 * lread.c (syms_of_lread): Clarify that is isn't only
2160 `eval-buffer' and `eval-defun' that's affected by
2161 `lexical-binding' (bug#8460).
2162
aa4b6df6
EZ
21632011-07-15 Eli Zaretskii <eliz@gnu.org>
2164
2165 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2166 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2167
5d856da6
PE
21682011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2169
ad6042bb
PE
2170 Fix minor problems found by static checking.
2171 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2172 (elsz): Now a signed constant, not a size_t var. We prefer signed
2173 types to unsigned, to avoid integer comparison confusion. Without
2174 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2175 "cannot optimize loop, the loop counter may overflow", a symptom
2176 of the confusion.
f00bbb22 2177 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2178 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2179
6468f31c
LMI
21802011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2181
49080b10
LMI
2182 * search.c (Fre_search_backward): Mention `case-fold-search' in
2183 all the re_search_* functions (bug#8138).
2184
6468f31c
LMI
2185 * keyboard.c (Fopen_dribble_file): Document when the file is
2186 closed (bug#8056).
2187
c965adc5
EZ
21882011-07-14 Eli Zaretskii <eliz@gnu.org>
2189
df9733bf
EZ
2190 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2191 bidi_cache_idx.
2192
0bb23927
EZ
2193 Support bidi reordering of display and overlay strings.
2194 * xdisp.c (compute_display_string_pos)
2195 (compute_display_string_end): Accept additional argument STRING.
2196 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2197 (reseat_to_string): Initialize bidi_it->string.s and
2198 bidi_it->string.schars.
2199 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2200 NULL (avoids a crash in bidi_paragraph_init).
2201 Initialize itb.string.lstring.
0bb23927
EZ
2202 (init_iterator): Call bidi_init_it only of a valid
2203 buffer position was specified. Initialize paragraph_embedding to
2204 L2R.
2205 (reseat_to_string): Initialize the bidi iterator.
2206 (display_string): If we need to ignore text properties of
2207 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2208 original value of -1 will not work with bidi.)
2209 (compute_display_string_pos): First arg is now struct
2210 `text_pos *'; all callers changed. Support display properties on
2211 Lisp strings.
2212 (compute_display_string_end): Support display properties on Lisp
2213 strings.
2214 (init_iterator, reseat_1, reseat_to_string): Initialize the
2215 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2216 when iterating on a string not from display properties).
640c8776
SM
2217 (compute_display_string_pos, compute_display_string_end):
2218 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2219 arrow keys.
2220 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2221 base_level_stop; instead, set base_level_stop to BEGV.
2222 Fixes crashes in vertical-motion.
0bb23927
EZ
2223 (next_element_from_buffer): Improve commentary for when
2224 the iterator is before prev_stop.
2225 (init_iterator): Initialize bidi_p from the default value of
2226 bidi-display-reordering, not from buffer-local value. Use the
2227 buffer-local value only if initializing for buffer iteration.
2228 (handle_invisible_prop): Support invisible properties on strings
2229 that are being bidi-reordered.
2230 (set_iterator_to_next): Support bidi reordering of C strings and
2231 Lisp strings.
2232 (next_element_from_string): Support bidi reordering of Lisp
2233 strings.
2234 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2235 (display_string): Support display of R2L glyph rows.
2236 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2237 (init_iterator): Don't initialize it->bidi_p for strings
2238 here.
2239 (reseat_to_string): Initialize it->bidi_p for strings here.
2240 (next_element_from_string, next_element_from_c_string)
2241 (next_element_from_buffer): Add xassert's for correspondence
2242 between IT's object being iterated and it->bidi_it.string
2243 structure.
2244 (face_before_or_after_it_pos): Support bidi iteration.
2245 (next_element_from_c_string): Handle the case of the first string
2246 character that is not the first one in the visual order.
2247 (get_visually_first_element): New function, refactored from common
2248 parts of next_element_from_buffer, next_element_from_string, and
2249 next_element_from_c_string.
2250 (tool_bar_lines_needed, redisplay_tool_bar)
2251 (display_menu_bar): Force left-to-right direction. Add a FIXME
2252 comment for making that be controlled by a user option.
2253 (push_it, pop_it): Save and restore the state of the
2254 bidi iterator. Save and restore the bidi_p flag.
2255 (pop_it): Iterate out of display property for string iteration as
2256 well.
2257 (iterate_out_of_display_property): Support iteration over strings.
2258 (handle_single_display_spec): Set up it->bidi_it for iteration
2259 over a display string, and call bidi_init_it.
2260 (handle_single_display_spec, next_overlay_string)
2261 (get_overlay_strings_1, push_display_prop): Set up the bidi
2262 iterator for displaying display or overlay strings.
2263 (forward_to_next_line_start): Don't use the shortcut if
2264 bidi-iterating.
2265 (back_to_previous_visible_line_start): If handle_display_prop
2266 pushed the iterator stack, restore the internal state of the bidi
2267 iterator by calling bidi_pop_it same number of times.
2268 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2269 and we are bidi-iterating, don't decrement the iterator position;
2270 instead, set the first_elt flag in the bidi iterator, to produce
2271 the same effect.
2272 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2273 (push_display_prop): xassert that we are iterating a buffer.
2274 (push_it, pop_it): Save and restore paragraph_embedding member.
2275 (handle_single_display_spec, next_overlay_string)
2276 (get_overlay_strings_1, reseat_1, reseat_to_string)
2277 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2278 correctly. Don't assume unibyte strings are not bidi-reordered.
2279 (compute_display_string_pos)
2280 (compute_display_string_end): Fix handling the case of C string.
2281 (push_it, pop_it): Save and restore from_disp_prop_p.
2282 (handle_single_display_spec, push_display_prop): Set the
2283 from_disp_prop_p flag.
2284 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2285 (pop_it): Call iterate_out_of_display_property only if we are
2286 popping after iteration over a string that came from a display
2287 property. Fix a typo in popping stretch info. Add an assertion
2288 for verifying that the iterator position is in sync with the bidi
2289 iterator.
2290 (handle_single_display_spec, get_overlay_strings_1)
2291 (push_display_prop): Fix initialization of paragraph direction for
2292 string when that of the parent object is not yet determined.
2293 (reseat_1): Call bidi_init_it to resync the bidi
2294 iterator with IT's position. (Bug#7616)
2295 (find_row_edges): If ROW->start.pos gives position
2296 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2297 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2298 Reset the from_disp_prop_p flag.
2299 (SAVE_IT, RESTORE_IT): New macros.
2300 (pos_visible_p, face_before_or_after_it_pos)
2301 (back_to_previous_visible_line_start)
2302 (move_it_in_display_line_to, move_it_in_display_line)
2303 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2304 (try_scrolling, redisplay_window, display_line): Use them when
2305 saving a temporary copy of the iterator and restoring it back.
2306 (back_to_previous_visible_line_start, reseat_1)
2307 (init_iterator): Empty the bidi cache "stack".
2308 (move_it_in_display_line_to): If iterator ended up at
2309 EOL, but we never saw any buffer positions smaller than
2310 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2311 motion in bidi-reordered lines.
2312 (move_it_in_display_line_to): Record prev_method and prev_pos
2313 immediately before the call to set_iterator_to_next. Fixes cursor
2314 motion in bidi-reordered lines with stretch glyphs and strings
2315 displayed in margins. (Bug#8133) (Bug#8867)
2316 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2317 TO_CHARPOS.
640c8776
SM
2318 (pos_visible_p): Support positions in bidi-reordered lines.
2319 Save and restore bidi cache.
0bb23927
EZ
2320
2321 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2322 (bidi_paragraph_info): Delete unused struct.
2323 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2324 (bidi_cache_start): New variable.
2325 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2326 to zero.
2327 (bidi_cache_fetch_state, bidi_cache_search)
2328 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2329 (bidi_cache_find, bidi_peek_at_next_level)
2330 (bidi_level_of_next_char, bidi_find_other_level_edge)
2331 (bidi_move_to_visually_next): Compare cache index with
2332 bidi_cache_start rather than with zero.
2333 (bidi_fetch_char): Accept new argument STRING; all callers
2334 changed. Support iteration over a string. Support strings with
2335 display properties. Support unibyte strings. Fix the type of
2336 `len' according to what STRING_CHAR_AND_LENGTH expects.
2337 (bidi_paragraph_init, bidi_resolve_explicit_1)
2338 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2339 (bidi_level_of_next_char, bidi_move_to_visually_next):
2340 Support iteration over a string.
0bb23927
EZ
2341 (bidi_set_sor_type, bidi_resolve_explicit_1)
2342 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2343 can now be zero (for strings); special values 0 and -1 were
2344 changed to -1 and -2, respectively.
2345 (bidi_char_at_pos): New function.
2346 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2347 Call it instead of FETCH_MULTIBYTE_CHAR.
2348 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2349 initialized to valid values.
2350 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2351 values.
2352 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2353 the test for valid cached positions. Fix the logic for looking up
2354 the sentinel state in the cache. GCPRO the Lisp string we are
2355 iterating.
2356 (bidi_push_it, bidi_pop_it): New functions.
2357 (bidi_initialize): Initialize the bidi cache start stack pointer.
2358 (bidi_cache_ensure_space): New function, refactored from part of
2359 bidi_cache_iterator_state. Don't assume the required size is just
2360 one BIDI_CACHE_CHUNK away.
2361 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2362 (bidi_count_bytes, bidi_char_at_pos): New functions.
2363 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2364 always valid if bidi_cache_idx is valid.
2365 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2366 is valid if it's going to be used.
2367 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2368 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2369 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2370 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2371 (bidi_find_other_level_edge, bidi_cache_start_stack):
2372 All variables related to cache indices are now EMACS_INT.
c965adc5 2373
0bb23927
EZ
2374 * dispextern.h (struct bidi_string_data): New structure.
2375 (struct bidi_it): New member `string'. Make flag members be 1-bit
2376 fields, and put them last in the struct.
640c8776
SM
2377 (compute_display_string_pos, compute_display_string_end):
2378 Update prototypes.
0bb23927
EZ
2379 (bidi_push_it, bidi_pop_it): Add prototypes.
2380 (struct iterator_stack_entry): New members bidi_p,
2381 paragraph_embedding, and from_disp_prop_p.
2382 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2383 (bidi_shelve_cache, bidi_unshelve_cache):
2384 Declare prototypes.
0bb23927
EZ
2385
2386 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2387 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2388 and vector-like objects.
2389
2390 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2391 cache around display iteration.
2392
2393 * window.c (Fwindow_end, window_scroll_pixel_based)
2394 (displayed_window_lines, Frecenter): Save and restore the bidi
2395 cache around display iteration.
2396
3bbd2265
LMI
23972011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2398
2399 * editfns.c (Fdelete_region): Clarify the use of the named
2400 parameters (bug#6788).
2401
adc47434
MR
24022011-07-14 Martin Rudalics <rudalics@gmx.at>
2403
2404 * indent.c (Fvertical_motion): Set and restore w->pointm when
2405 saving and restoring the window's buffer (Bug#9006).
2406
837c31f8
LMI
24072011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2408
2409 * editfns.c (Fstring_to_char): Clarify just what is returned
2410 (bug#6576). Text by Eli Zaretskii.
2411
ac389d0c
JB
24122011-07-13 Juanma Barranquero <lekktu@gmail.com>
2413
2414 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2415
0be0ce47
EZ
24162011-07-13 Eli Zaretskii <eliz@gnu.org>
2417
2418 * buffer.c (mmap_find): Fix a typo.
2419
cd18e7e3
JB
24202011-07-13 Johan Bockgård <bojohan@gnu.org>
2421
2422 Fix execution of x selection hooks.
2423 * xselect.c (Qx_lost_selection_functions)
2424 (Qx_sent_selection_functions): New vars.
2425 (syms_of_xselect): DEFSYM them.
2426 (x_handle_selection_request): Pass Qx_sent_selection_functions
2427 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2428 (x_handle_selection_clear,x_clear_frame_selections):
2429 Pass Qx_lost_selection_functions rather than
2430 Vx_lost_selection_functions to Frun_hook_with_args.
2431
47ea7f44
PE
24322011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2433
ac389d0c 2434 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2435 The old code sometimes used this field without initializing it.
2436
47ea7f44
PE
2437 * alloc.c (gc_sweep): Don't read past end of array.
2438 In theory, the old code could also have corrupted Emacs internals,
2439 though it'd be very unlikely.
2440
bc985c87
AS
24412011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2442
2443 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2444 argument. (Bug#4026)
bc985c87 2445
0cf34688
LMI
24462011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2447
b3dadd76
LMI
2448 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2449 key" (bug#4257).
2450
0cf34688
LMI
2451 * window.c (Fset_window_start): Doc fix (bug#4199).
2452 (Fset_window_hscroll): Ditto.
2453
270768cd
PE
24542011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2455
077e3dda 2456 Fix minor new problems caught by GCC 4.6.1.
270768cd 2457 * term.c (init_tty): Remove unused local.
490011a6 2458 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2459 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2460 not used otherwise.
270768cd 2461
b1f58454
CY
24622011-07-12 Chong Yidong <cyd@stupidchicken.com>
2463
2464 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2465
22b9578d
LMI
24662011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2467
6e70ab07
LMI
2468 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2469 are the mini-buffer and the echo area (bug#3320).
2470
22b9578d
LMI
2471 * term.c (init_tty): Remove support for supdup, c10 and perq
2472 terminals, which are no longer supported (bug#1482).
2473
8974cc9f
JB
24742011-07-10 Johan Bockgård <bojohan@gnu.org>
2475
2476 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2477
a560d974
JD
24782011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2479
2480 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2481 for non-popups (Bug#3642).
2482
1dae0f0a
AS
24832011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2484
268c2c36 2485 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2486 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2487 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2488 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2489 * data.c (fmod): Likewise.
2490 * dispnew.c (swap_glyphs_in_rows): Likewise.
2491 * emacs.c (memory_warning_signal): Likewise.
2492 * floatfns.c (float_error): Likewise.
2493 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2494 (otf_open, font_otf_capability, generate_otf_features)
2495 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2496 Likewise.
2497 * image.c (pbm_read_file): Likewise.
2498 * indent.c (string_display_width): Likewise.
2499 * intervals.c (check_for_interval, search_for_interval)
2500 (inc_interval_count, count_intervals, root_interval)
2501 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2502 * lread.c (defalias): Likewise.
268c2c36 2503 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2504 * regex.c (set_image_of_range_1, set_image_of_range)
2505 (regex_grow_registers): Likewise.
2506 * sysdep.c (strerror): Likewise.
2507 * termcap.c (valid_filename_p, tprint, main): Likewise.
2508 * tparam.c (main): Likewise.
2509 * unexhp9k800.c (run_time_remap, save_data_space)
2510 (update_file_ptrs, read_header, write_header, calculate_checksum)
2511 (copy_file, copy_rest, display_header): Likewise.
2512 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2513 Likewise.
2514 * xdisp.c (check_it): Likewise.
2515 * xfaces.c (register_color, unregister_color, unregister_colors):
2516 Likewise.
2517 * xfns.c (print_fontset_result): Likewise.
2518 * xrdb.c (member, fatal, main): Likewise.
2519
99033785
PE
25202011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2521
2522 Fix minor problems found by static checking (Bug#9031).
2523 * chartab.c (char_table_set_range, map_sub_char_table):
2524 Remove unused locals.
2525 (uniprop_table): Now static.
2526 * composite.c (_work_char): Remove unused static var.
2527
9cb2ac56
JB
25282011-07-09 Juanma Barranquero <lekktu@gmail.com>
2529
2530 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2531
f25661f0
JD
25322011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2533
2534 * gtkutil.c (qttip_cb): Remove code without function.
2535
8278c4fe
EZ
25362011-07-09 Eli Zaretskii <eliz@gnu.org>
2537
2538 * w32.c (pthread_sigmask): New stub.
2539
1692ae2d 25402011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2541
8a6ebd58 2542 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2543 sigprocmask is portable only for single-threaded applications, and
2544 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2545 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2546 (LIBES): Use it.
2547 * callproc.c (Fcall_process):
2548 * process.c (create_process):
2549 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2550 Use pthread_sigmask, not sigprocmask.
123403e4 2551
1b854618
JD
25522011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2553
2554 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2555 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2556 wrong (Bug#8591).
2557
3fe4b549
JD
25582011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2559
0ce7e563
JD
2560 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2561 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2562 (xg_hide_tooltip): Fix comment.
2563
3fe4b549
JD
2564 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2565 in registerServicesMenuSendTypes.
2566 (validRequestorForSendType): Don't check ns_return_types.
2567
2568 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2569 ns_return_type.
2570
5df75e47
JR
25712011-07-08 Jason Rumney <jasonr@gnu.org>
2572
2573 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2574 frame struct members of non-existent frames (Bug#6284).
2575
699c10bd
JD
25762011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2577
4393663b
JD
2578 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2579 variable firstTime not needed on OSX >= 10.6.
2580 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2581 >= 10.5. Use setKnobProportion, setDoubleValue.
2582
2583 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2584 (MAC_OS_X_VERSION_10_5): Define if not defined.
2585 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2586 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2587 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2588
2589 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2590 cString and lossyCString on OSX >= 10.4
2591
2592 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2593 sizeToFit on OSX >= 10.2.
2594
2595 * nsimage.m (allocInitFromFile): Don't use deprecated method
2596 bestRepresentationForDevice on OSX >= 10.6.
2597
2598 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2599 to avoid warning.
2600
2601 * emacs.c: Declare unexec_init_emacs_zone.
2602
a63e0781
JD
2603 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2604
699c10bd
JD
2605 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2606
2607 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2608 on svcsMenu (Bug#8842).
2609
2610 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2611 ns_return_types.
2612 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2613
2614 * nsterm.m (QUTF8_STRING): Declare.
2615 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2616 (validRequestorForSendType): Return type is (id).
2617 Change indexOfObjectIdenticalTo to indexOfObject.
2618 Check if we have local selection before returning self (Bug#8842).
2619 (writeSelectionToPasteboard): Put local selection into paste board
2620 if we have a local selection (Bug#8842).
2621 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2622
2623 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2624 (ns_get_local_selection): Declare.
2625
54e10184
LMI
26262011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2627
9888ff71
LMI
2628 * keymap.c (describe_map_tree): Don't insert a double newline at
2629 the end of the buffer (bug#1169) and return whether we inserted
2630 something.
2631
54e10184
LMI
2632 * callint.c (Fcall_interactively): Change "reading args" to
2633 "providing args" to try to clarify what it does (bug#1010).
2634
15fa4783
KH
26352011-07-07 Kenichi Handa <handa@m17n.org>
2636
2637 * composite.c (composition_compute_stop_pos): Ignore a static
2638 composition starting before CHARPOS (Bug#8915).
2639
2640 * xdisp.c (handle_composition_prop): Likewise.
2641
a8815b00
EZ
26422011-07-07 Eli Zaretskii <eliz@gnu.org>
2643
2644 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2645 (Bug#9015)
2646
ef7b981d 26472011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2648
2649 * character.h (unicode_category_t): New enum type.
2650
2651 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2652 (Qchar_code_property_table): New variable.
2653 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2654 (UNIPROP_COMPRESSED_FORM_P): New macros.
2655 (char_table_ascii): Uncompress the compressed values.
2656 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2657 Uncompress the compressed values.
ac389d0c 2658 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2659 (char_table_ref_and_range): Uncompress the compressed values.
2660 (sub_char_table_set): New arg is_uniprop. Callers changed.
2661 Uncompress the compressed values.
2662 (sub_char_table_set_range): Args changed. Callers changed.
2663 (char_table_set_range): Adjuted for the above change.
2664 (map_sub_char_table): Delete args default_val and parent. Add arg
2665 top. Give decoded values to a Lisp function.
640c8776 2666 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2667 values to a Lisp function. Gcpro more variables.
2668 (uniprop_table_uncompress)
2669 (uniprop_decode_value_run_length): New functions.
2670 (uniprop_decoder, uniprop_decoder_count): New variables.
2671 (uniprop_get_decoder, uniprop_encode_value_character)
2672 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2673 New functions.
2674 (uniprop_encoder, uniprop_encoder_count): New variables.
2675 (uniprop_get_encoder, uniprop_table)
2676 (Funicode_property_table_internal, Fget_unicode_property_internal)
2677 (Fput_unicode_property_internal): New functions.
2678 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2679 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2680 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2681 char-code-property-alist.
2682
640c8776 2683 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2684 Vunicode_category_table.
2685
640c8776 2686 * font.c (font_range): Adjust for the change of
c805dec0
KH
2687 Vunicode_category_table.
2688
76b397fb
DN
26892011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2690
2691 * m/iris4d.h: Remove file, move contents ...
2692 * s/irix6-5.h: ... here.
2693
22b4128e
PE
26942011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2695
2696 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2697 * alloc.c (mark_buffer):
2698 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2699 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2700 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2701 This isn't true in general, and it's particularly not true
2702 if Emacs is configured with --with-wide-int.
2703 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2704 New macros, used in the buffer.c change.
2705
869795d6
JD
27062011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2707
2708 * xsettings.c: Use both GConf and GSettings if both are available.
2709 (store_config_changed_event): Add comment.
2710 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2711 (store_tool_bar_style_changed): New functions.
5e617bc2 2712 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2713 (struct xsettings): Move font inside HAVE_XFT.
2714 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2715 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2716 Move inside HAVE_XFT.
640c8776 2717 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2718 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2719 also.
2720 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2721 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2722 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2723 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2724 (parse_settings): Move check for font inside HAVE_XFT.
2725 (read_settings, apply_xft_settings): Add comment.
2726 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2727 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2728 call store_font_name_changed.
2729 (xft_settings_event): Add comment.
2730 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2731 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2732 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2733 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2734 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2735 (xsettings_get_system_font, xsettings_get_system_normal_font):
2736 Add comment.
869795d6 2737
d8ed26bd
PE
27382011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2739
2740 Random fixes. E.g., (random) never returned negative values.
2741 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2742 subseconds part to the entropy, as that's a bit more random.
2743 Prefer signed to unsigned, since the signedness doesn't matter and
2744 in general we prefer signed. When given a limit, use a
2745 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2746 latter isn't right if USE_2_TAGS_FOR_INTS.
2747 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2748 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2749
cabf1cac
SM
27502011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2751
2752 * textprop.c (text_property_stickiness):
2753 Obey Vtext_property_default_nonsticky.
2754 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2755 * w32fns.c (syms_of_w32fns):
2756 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2757
6e9b2be9
PE
27582011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2759
2760 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2761 This is more efficient than Ffile_directory_p and avoids a minor race.
2762
90186c68
LMI
27632011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2764
7c301272
LMI
2765 * buffer.c (Foverlay_put): Say what the return value is
2766 (bug#7835).
2767
c4f2d8d4
LMI
2768 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2769 is a directory before asking whether to use the file name
2770 (bug#7564).
ad637907
LMI
2771 (barf_or_query_if_file_exists): Make the "File is a directory"
2772 error be more correct.
c4f2d8d4 2773
90186c68
LMI
2774 * fns.c (Frequire): Remove the mention of the .gz files, since
2775 that's installation-specific, but keep the mention of
2776 `get-load-suffixes'.
2777
da64016e
PE
27782011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2779
2780 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2781 Report string overflow if the output is too long.
2782
7d47b580
JB
27832011-07-04 Juanma Barranquero <lekktu@gmail.com>
2784
a555cb87
JB
2785 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2786 (syms_of_gnutls): Remove duplicate DEFSYM for
2787 Qgnutls_bootprop_verify_hostname_error, an error for
2788 Qgnutls_bootprop_verify_error (which is no longer used).
2789
7d47b580
JB
2790 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2791 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2792 Also (re)move comments that are misplaced or no longer relevant.
2793
1e49bfab
LMI
27942011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2795
2796 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2797
1485f4c0
CY
27982011-07-03 Chong Yidong <cyd@stupidchicken.com>
2799
2800 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2801 and background color parameters if they have been changed.
2802
a9ab721e
LMI
28032011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2804
2805 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2806
cf7cff57
PE
28072011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2808
2e13213d
PE
2809 * xsettings.c (SYSTEM_FONT): Define only when used.
2810 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2811
cf7cff57
PE
2812 * keymap.c (access_keymap_1): Now static.
2813
7a8e04f7
CY
28142011-07-02 Chong Yidong <cyd@stupidchicken.com>
2815
2816 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2817 leave any prefix arg for the up event (Bug#1586).
2818
61352f62
LMI
28192011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2820
69bb1ef7
LMI
2821 * lread.c (syms_of_lread): Mention single symbols defined by
2822 `defvar' or `defconst' (bug#7154).
2823
61352f62 2824 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2825 (Frequire): Mention get-load-suffixes.
61352f62 2826
28545e04
MR
28272011-07-02 Martin Rudalics <rudalics@gmx.at>
2828
2829 * window.h (window): Remove clone_number slot.
2830 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2831 Remove.
2832 (make_parent_window, make_window, saved_window)
2833 (Fset_window_configuration, save_window_save): Don't deal with
2834 clone numbers.
2835 * buffer.c (Qclone_number): Remove declaration.
2836 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2837
3349e122
SM
28382011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2839
2840 Add multiple inheritance to keymaps.
2841 * keymap.c (Fmake_composed_keymap): New function.
2842 (Fset_keymap_parent): Simplify.
2843 (fix_submap_inheritance): Remove.
2844 (access_keymap_1): New function extracted from access_keymap to handle
2845 embedded parents and handle lists of maps.
2846 (access_keymap): Use it.
2847 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2848 (Fcopy_keymap): Handle embedded parents.
2849 (Fcommand_remapping, define_as_prefix): Simplify.
2850 (Fkey_binding): Simplify.
2851 (syms_of_keymap): Move minibuffer-local-completion-map,
2852 minibuffer-local-filename-completion-map,
2853 minibuffer-local-must-match-map, and
2854 minibuffer-local-filename-must-match-map to Elisp.
2855 (syms_of_keymap): Defsubr make-composed-keymap.
2856 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2857 (parse_menu_item): Trivial simplification.
2858
3279eb87
GM
28592011-07-01 Glenn Morris <rgm@gnu.org>
2860
2861 * Makefile.in (SETTINGS_LIBS): Fix typo.
2862
4550efdf
KI
28632011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2864
2865 * coding.c (Fencode_coding_string): Record the last coding system
2866 used, as the function doc string says (bug#8738).
2867
0949d2b6
JD
28682011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2869
2870 * xsettings.c (store_monospaced_changed): Take new font as arg and
2871 check for change against current_mono_font.
2872 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2873 (emacs_settings_constructor, emacs_settings_get_property)
2874 (emacs_settings_set_property, emacs_settings_class_init)
2875 (emacs_settings_init, gsettings_obj): Remove.
2876 (something_changedCB): New function for HAVE_GSETTINGS.
2877 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2878 with value as argument.
2879 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2880 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2881 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2882 "changed".
2883
2884 * xgselect.c: Add defined (HAVE_GSETTINGS).
2885 (xgselect_initialize): Ditto.
2886
2887 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2888 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2889 xg_select.
2890
bbc6b304
PE
28912011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2892
2893 * eval.c (struct backtrace): Simplify and port the data structure.
2894 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2895 signed bit field, as this assumption is not portable and it makes
2896 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2897 "char debug_on_exit : 1" as this is not portable either; instead,
2898 use the portable "unsigned int debug_on_exit : 1". Remove unused
2899 member evalargs. Remove obsolete comments about cc bombing out.
2900
9851bfc5
JD
29012011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2902
51bb811f 2903 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2904 Let HAVE_GSETTINGS override HAVE_GCONF.
2905 (store_monospaced_changed): New function.
2906 (EMACS_SETTINGS): A new type derived from GObject to handle
2907 GSettings notifications.
2908 (emacs_settings_constructor, emacs_settings_get_property)
2909 (emacs_settings_set_property, emacs_settings_class_init):
2910 New functions.
2911 (gsettings_client, gsettings_obj): New variables.
2912 (GSETTINGS_SCHEMA): New define.
2913 (something_changedCB): Call store_monospaced_changed.
2914 (init_gsettings): New function.
2915 (xsettings_initialize): Call init_gsettings.
2916 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2917 to NULL.
2918
640c8776 2919 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2920 GCONF_CFLAGS/LIBS.
2921
5386012d
MR
29222011-06-29 Martin Rudalics <rudalics@gmx.at>
2923
2924 * window.c (resize_root_window, grow_mini_window)
2925 (shrink_mini_window): Rename Qresize_root_window to
2926 Qwindow_resize_root_window and Qresize_root_window_vertically to
2927 Qwindow_resize_root_window_vertically.
2928
f13e0b08
PE
29292011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2930
2931 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2932
94515237
JB
29332011-06-27 Juanma Barranquero <lekktu@gmail.com>
2934
2935 * makefile.w32-in: Redesign dependencies so they reflect more
2936 clearly which files are directly included by each source file,
2937 and not through other includes.
2938
e43b6e43
MR
29392011-06-27 Martin Rudalics <rudalics@gmx.at>
2940
2941 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2942 (sort_overlays, overlay_strings): When an overlay's clone number
2943 matches the window's clone number process the overlay even if
2944 the overlay's window property doesn't match the current window.
2945
d68443dc
MR
2946 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2947 (Fwindow_hchild): Rename to Fwindow_left_child.
2948 (Fwindow_next): Rename to Fwindow_next_sibling.
2949 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2950 (resize_window_check): Rename to window_resize_check.
2951 (resize_window_apply): Rename to window_resize_apply.
2952 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2953 (Fdelete_other_windows_internal, resize_frame_windows)
2954 (Fsplit_window_internal, Fdelete_window_internal)
2955 (grow_mini_window, shrink_mini_window)
2956 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2957
c7e73be5
JD
29582011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2959
2960 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2961 (emacs_fixed_set_min_size): Remove.
2962 (emacs_fixed_new): Take frame as argument.
2963
2964 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2965 (_EmacsFixedPrivate): Remove minwidth/height.
2966 Add struct frame *f.
2967 (emacs_fixed_init): Initialize priv->f.
2968 (get_parent_class, emacs_fixed_set_min_size): Remove.
2969 (emacs_fixed_new): Set priv->f to argument.
2970 (emacs_fixed_get_preferred_width)
2971 (emacs_fixed_get_preferred_height): Use min_width/height from
2972 frames size_hint to set minimum and natural (Bug#8919).
2973 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2974 and use min_width/height from frames size_hint to set
2975 min_width/height (Bug#8919).
2976
2977 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2978 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2979 Fix indentation.
c7e73be5 2980
cf99dcf8
EZ
29812011-06-26 Eli Zaretskii <eliz@gnu.org>
2982
2983 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2984 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2985 called at ZV.
2986
029529ac
CY
29872011-06-26 Chong Yidong <cyd@stupidchicken.com>
2988
2989 * process.c (wait_reading_process_output): Bypass select if
2990 waiting for a cell while ignoring keyboard input, and input is
2991 pending. Suggested by Jan Djärv (Bug#8869).
2992
7a7ef429
PE
29932011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2994
2995 Use gnulib's dup2 module instead of rolling our own.
2996 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2997
11fdef7d 29982011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2999
3000 * dispnew.c (scrolling_window): Before scrolling, turn off a
3001 mouse-highlight in the window being scrolled.
3002
cd3520a4
JB
30032011-06-24 Juanma Barranquero <lekktu@gmail.com>
3004
3005 Move DEFSYM to lisp.h and use everywhere.
3006
3007 * character.h (DEFSYM): Move declaration...
3008 * lisp.h (DEFSYM): ...here.
3009
3010 * gnutls.c:
3011 * minibuf.c:
3012 * w32menu.c:
3013 * w32proc.c:
3014 * w32select.c: Don't include character.h.
3015
3016 * alloc.c (syms_of_alloc):
3017 * buffer.c (syms_of_buffer):
3018 * bytecode.c (syms_of_bytecode):
3019 * callint.c (syms_of_callint):
3020 * casefiddle.c (syms_of_casefiddle):
3021 * casetab.c (init_casetab_once):
3022 * category.c (init_category_once, syms_of_category):
3023 * ccl.c (syms_of_ccl):
3024 * cmds.c (syms_of_cmds):
3025 * composite.c (syms_of_composite):
3026 * dbusbind.c (syms_of_dbusbind):
3027 * dired.c (syms_of_dired):
3028 * dispnew.c (syms_of_display):
3029 * doc.c (syms_of_doc):
3030 * editfns.c (syms_of_editfns):
3031 * emacs.c (syms_of_emacs):
3032 * eval.c (syms_of_eval):
3033 * fileio.c (syms_of_fileio):
3034 * fns.c (syms_of_fns):
3035 * frame.c (syms_of_frame):
3036 * fringe.c (syms_of_fringe):
3037 * insdel.c (syms_of_insdel):
3038 * keymap.c (syms_of_keymap):
3039 * lread.c (init_obarray, syms_of_lread):
3040 * macros.c (syms_of_macros):
3041 * msdos.c (syms_of_msdos):
3042 * print.c (syms_of_print):
3043 * process.c (syms_of_process):
3044 * search.c (syms_of_search):
3045 * sound.c (syms_of_sound):
3046 * syntax.c (init_syntax_once, syms_of_syntax):
3047 * terminal.c (syms_of_terminal):
3048 * textprop.c (syms_of_textprop):
3049 * undo.c (syms_of_undo):
3050 * w32.c (globals_of_w32):
3051 * window.c (syms_of_window):
3052 * xdisp.c (syms_of_xdisp):
3053 * xfaces.c (syms_of_xfaces):
3054 * xfns.c (syms_of_xfns):
3055 * xmenu.c (syms_of_xmenu):
3056 * xsettings.c (syms_of_xsettings):
3057 * xterm.c (syms_of_xterm): Use DEFSYM.
3058
4228cf16
TZ
30592011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3060
cd3520a4 3061 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3062
7fcccf1e
PE
30632011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3064
7efb4e0e
PE
3065 Integer and buffer overflow fixes (Bug#8873).
3066
ff5844ad
PE
3067 * print.c (printchar, strout): Check for string overflow.
3068 (PRINTPREPARE, printchar, strout):
3069 Don't set size unless allocation succeeds.
3070
90532f02
PE
3071 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3072 for sizes. Check for string overflow more accurately.
3073 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3074
6d84508d
PE
3075 * macros.c: Integer and buffer overflow fixes.
3076 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3077 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3078 Use ptrdiff_t, not int, for sizes.
3079 Don't increment bufsize until after realloc succeeds.
3080 Check for size-calculation overflow.
3081 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3082
437b2cb4
PE
3083 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3084
8b9ac8b4
PE
3085 * lread.c: Integer overflow fixes.
3086 (read_integer): Radix is now EMACS_INT, not int,
3087 to improve quality of diagnostics for out-of-range radices.
3088 Calculate buffer size correctly for out-of-range radices.
3089 (read1): Check for integer overflow in radices, and in
3090 read-circle numbers.
82cb60d3
PE
3091 (read_escape): Avoid int overflow.
3092 (Fload, openp, read_buffer_size, read1)
3093 (substitute_object_recurse, read_vector, read_list, map_obarray):
3094 Use ptrdiff_t, not int, for sizes.
3095 (read1): Use EMACS_INT, not int, for sizes.
20270765 3096 Check for size overflow.
8b9ac8b4 3097
7fcccf1e
PE
3098 * image.c (cache_image): Check for size arithmetic overflow.
3099
bfbbd7e7
PE
3100 * lread.c: Integer overflow issues.
3101 (saved_doc_string_size, saved_doc_string_length)
3102 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3103 Now ptrdiff_t, not int.
3104 (read1): Don't assume doc string length fits in int. Check for
3105 out-of-range doc string lengths.
3106 (read_list): Don't assume file position fits in int.
39019e54 3107 (read_escape): Check for hex character overflow.
bfbbd7e7 3108
4e323265
LL
31092011-06-22 Leo Liu <sdl.web@gmail.com>
3110
3111 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3112 Move to minibuffer.el.
3113
85fece3e
PE
31142011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3115
20b84ce9 3116 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3117 The following patches are for when GLYPH_DEBUG && !XASSERT.
3118 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3119 * dispnew.c (flush_stdout):
3120 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3121 Mark as externally visible.
3122 * dispnew.c (check_window_matrix_pointers): Now static.
3123 * dispnew.c (window_to_frame_vpos):
3124 * xfns.c (unwind_create_frame):
3125 * xterm.c (x_check_font): Remove unused local.
3126 * scroll.c (CHECK_BOUNDS):
3127 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3128 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3129 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3130 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3131 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3132 Now static.
3133 (debug_method_add): Use va_list and vsprintf rather than relying
3134 on undefined behavior with wrong number of arguments.
3135 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3136 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3137 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3138 since we're not interested in debugging glyphs with old libraries.
3139 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3140 GCC 4.6.0's static checking.
3141
0766b489
PE
31422011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3143
31fd4b32
PE
3144 Integer overflow and signedness fixes (Bug#8873).
3145 A few related buffer overrun fixes, too.
3146
b79e8648
PE
3147 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3148
0766b489
PE
3149 * dispextern.h (struct face.stipple):
3150 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3151 (x_bitmap_mask, x_allocate_bitmap_record)
3152 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3153 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3154 (x_create_bitmap_from_xpm_data):
3155 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3156 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3157 (.bitmaps_last):
3158 * xfaces.c (load_pixmap):
3159 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3160 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3161 (.bitmaps_last, struct x_output.icon_bitmap):
3162 Use ptrdiff_t, not int, for bitmap indexes.
3163 (x_allocate_bitmap_record): Check for size overflow.
3164 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3165
b081724f
PE
3166 Use ptrdiff_t, not int, for overlay counts.
3167 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3168 * editfns.c (overlays_around, get_pos_property):
3169 * textprop.c (get_char_property_and_overlay):
3170 * xdisp.c (next_overlay_change, note_mouse_highlight):
3171 * xfaces.c (face_at_buffer_position):
21514da7
PE
3172 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3173 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3174 (Fnext_overlay_change, Fprevious_overlay_change)
3175 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3176 Use ptrdiff_t, not int, for sizes.
21514da7 3177 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3178
3de73e5e
PE
3179 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3180
2606c57b
PE
3181 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3182 (x_session_initialize): Do not assume string length fits in int.
3183
aaafe47a
PE
3184 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3185 This is unlikely, but can occur if DPI is outlandish.
3186
2674ddc8 3187 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3188 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3189
28154962
PE
3190 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3191 * xrdb.c (magic_file_p, search_magic_path):
3192 Omit last arg SUFFIX; it was always 0. All callers changed.
3193 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3194
7de51af5
PE
3195 * xfont.c (xfont_match): Avoid need for strlen.
3196
25ed6cc3
PE
3197 * xfns.c: Don't assume strlen fits in int.
3198 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3199
4eab31dd
PE
3200 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3201 not unsigned long, as we prefer signed integers. All callers changed.
3202 Detect integer overflow in repeat count.
3203 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3204 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3205
171e2a58
PE
3206 * termcap.c: Don't assume sizes fit in int and never overflow.
3207 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3208 (gobble_line): Check for size-calculation overflow.
3209
ad39faca 3210 * minibuf.c (Fread_buffer):
6e5bb2dc 3211 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3212 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3213 Don't assume string length fits in int.
3214
52c61c22 3215 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3216 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3217
b5b8c9e5
PE
3218 * font.c: Don't assume string length fits in int.
3219 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3220 Use ptrdiff_t, not int.
ccd6111c
PE
3221 (font_intern_prop): Don't assume string length fits in int.
3222 Don't assume integer property fits in fixnum.
3223 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3224
882f0d81 3225 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3226 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3227 Reformulate so as not to need the command string.
3228 Invoke gzip -cd rather than gunzip, as it's more portable.
3229 (lock_info_type, lock_file_1, lock_file):
3230 Don't assume pid_t and time_t fit in unsigned long.
3231 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3232 (current_lock_owner): Prefer signed type for sizes.
3233 Use memcpy, not strncpy, where memcpy is what is really wanted.
3234 Don't assume (via atoi) that time_t and pid_t fit in int.
3235 Check for time_t and/or pid_t out of range, e.g., via a network share.
3236 Don't alloca where an auto var works fine.
3237
93f4cf88
PE
3238 * fileio.c: Fix some integer overflow issues.
3239 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3240 Don't assume string length fits in int.
3241 (directory_file_name): Don't assume string length fits in long.
3242 (make_temp_name): Don't assume pid fits in int, or that its print
3243 length is less than 20.
3244
f3e92b69
PE
3245 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3246
1bfdaf10
PE
3247 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3248
35016e9a
PE
3249 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3250
3d1e65a1
PE
3251 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3252 We prefer signed integers, even for size calculations.
3253
0b963a93
PE
3254 * emacs.c: Don't assume string length fits in 'int'.
3255 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3256 (main): Don't invoke strlen when not needed.
3257
573f4b54
PE
3258 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3259 (XD_DEBUG_MESSAGE): Don't waste a byte.
3260
989f33ba
PE
3261 * callproc.c (getenv_internal_1, getenv_internal)
3262 (Fgetenv_internal):
965d34eb
PE
3263 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3264
e4d29b33
PE
3265 * lread.c (invalid_syntax): Omit length argument.
3266 All uses changed. This doesn't fix a bug, but it simplifies the
3267 code away from its former Hollerith-constant appearance, and it's
3268 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3269 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3270
eb49b136
PE
3271 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3272 This didn't break anything, but it didn't help either.
3273 It's confusing to put a bogus integer in a place where the actual
3274 value does not matter.
9f62aeb1 3275 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3276 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3277
15375a22
PE
3278 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3279 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3280 implementation.
b61cc01c
PE
3281 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3282 We prefer signed types, and the value cannot exceed the EMACS_INT
3283 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3284 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3285 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3286 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3287
53b2623d
PE
3288 * indent.c (sane_tab_width): New function.
3289 (current_column, scan_for_column, Findent_to, position_indentation)
3290 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3291 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3292
51cab52b 3293 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3294
f2ed8a70
PE
3295 * lisp.h (lint_assume): New macro.
3296 * composite.c (composition_gstring_put_cache):
3297 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3298
abe80cc6
PE
3299 * editfns.c, insdel.c:
3300 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3301
b02c740e
PE
3302 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3303
ebc96716
PE
3304 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3305
b4e50fa0 3306 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3307 Use much-faster test for byte-length change.
311d5d7c 3308 Don't assume string byte-length fits in 'int'.
a4cf38e4 3309 Check that character arg fits in 'int'.
85461888 3310 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3311
c0c1ee9f
PE
3312 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3313
a498d7f4
PE
3314 * fns.c (concat): Catch string overflow earlier.
3315 Do not rely on integer wraparound.
3316
51cab52b
PE
3317 * dispextern.h (struct it.overlay_strings_charpos)
3318 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3319 * xdisp.c (forward_to_next_line_start)
3320 (back_to_previous_visible_line_start)
3321 (reseat_at_next_visible_line_start, next_element_from_buffer):
3322 Don't arbitrarily truncate the value of 'selective' to int.
3323
76031fad
PE
3324 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3325
5eb55db9
PE
3326 * composite.c: Don't truncate sizes to 'int'.
3327 (composition_gstring_p, composition_reseat_it)
3328 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3329 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3330 not EMACS_UINT, for indexes.
5eb55db9 3331
0703a717
PE
3332 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3333
d6202519
PE
3334 * buffer.c: Include <verify.h>.
3335 (struct sortvec.priority, struct sortstr.priority):
8961a454 3336 Now EMACS_INT, not int.
c20998a7 3337 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3338 (struct sortstr.size, record_overlay_string)
3339 (struct sortstrlist.size, struct sortlist.used):
3340 Don't truncate size to int.
3341 (record_overlay_string): Check for size-calculation overflow.
d6202519 3342 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3343
d5a19415
JM
33442011-06-22 Jim Meyering <meyering@redhat.com>
3345
029529ac 3346 Don't leak an XBM-image-sized buffer
d5a19415
JM
3347 * image.c (xbm_load): Free the image buffer after using it.
3348
a9041e6c
PE
33492011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3350
3351 Port to Sun C.
3352 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3353 that Sun C diagnosed.
3354 * fns.c (secure_hash): Fix pointer signedness issue.
3355 * intervals.c (static_offset_intervals): New function.
3356 (offset_intervals): Use it.
3357
7f3f739f
LL
33582011-06-21 Leo Liu <sdl.web@gmail.com>
3359
3360 * deps.mk (fns.o):
3361 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3362 sha512.h.
3363
3364 * fns.c (secure_hash): Rename from crypto_hash_function and change
3365 the first arg to accept symbols.
5b66d427 3366 (Fsecure_hash): New primitive.
7f3f739f
LL
3367 (syms_of_fns): New symbols.
3368
76147d94
DD
33692011-06-20 Deniz Dogan <deniz@dogan.se>
3370
3371 * process.c (Fset_process_buffer): Clarify return value in
3372 docstring.
3373
7d7d0045
CY
33742011-06-18 Chong Yidong <cyd@stupidchicken.com>
3375
3376 * dispnew.c (add_window_display_history): Use BVAR.
3377
3378 * xdisp.c (debug_method_add): Use BVAR.
3379 (check_window_end, dump_glyph_matrix, dump_glyph)
3380 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3381
3382 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3383 Likewise.
3384
3385 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3386 check till after the cache is created in init_frame_faces.
3387
ff2bc410
SM
33882011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3389
3390 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3391
28177add
PE
33922011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3393
dd3482fe
PE
3394 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3395 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3396 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3397
393d71f3 3398 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3399 * fileio.c (Finsert_file_contents):
3400 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3401 Remove the old (too-loose) buffer overflow checks.
3402 They weren't needed, since make_gap checks for buffer overflow.
3403 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3404 The old code merely checked for Emacs fixnum overflow, and relied
3405 on undefined (wraparound) behavior. The new code avoids undefined
3406 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3407
2e6813b0 3408 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3409 Tune. Don't use wider integers than needed. Don't use alloca.
3410 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3411
599a9e4f
PE
3412 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3413
99561444
PE
3414 * insdel.c, lisp.h (buffer_overflow): New function.
3415 (insert_from_buffer_1, replace_range, replace_range_2):
3416 * insdel.c (make_gap_larger):
3417 * editfns.c (Finsert_char):
3418 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3419
28177add
PE
3420 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3421
e69dafad
PE
34222011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3423
a7af7fde 3424 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3425
b1c46f02
PE
3426 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3427 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3428
e69dafad
PE
3429 * fileio.c: Don't assume EMACS_INT fits in off_t.
3430 (emacs_lseek): New static function.
3431 (Finsert_file_contents, Fwrite_region): Use it.
3432 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3433
566684ea
PE
3434 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3435
e6966cd6
PE
3436 * fns.c: Don't overflow int when computing a list length.
3437 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3438 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3439 truncation on 64-bit hosts. Check for QUIT every
3440 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3441 faster and is responsive enough.
3442 (Flength): Report an error instead of overflowing an integer.
3443 (Fsafe_length): Return a float if the value is not representable
3444 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3445 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3446 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3447
dd0b0efb
PE
3448 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3449 (header_size, word_size): New constants.
3450 (allocate_vectorlike): Don't check size overflow here.
3451 (allocate_vector): Check it here instead, since this is the only
3452 caller of allocate_vectorlike that could cause overflow.
3453 Check that the new vector's length is representable as a fixnum.
3454
86fe5cfe
PE
3455 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3456 The previous code was bogus. For example, next_almost_prime (32)
3457 returned 39, which is undesirable as it is a multiple of 3; and
3458 next_almost_prime (24) returned 25, which is a multiple of 5 so
3459 why was the code bothering to check for multiples of 7?
3460
80e88859
PE
3461 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3462
4a2f0ad6
PE
3463 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3464
f66c7cf8
PE
3465 Variadic C functions now count arguments with ptrdiff_t.
3466 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3467 Back then I didn't know that the Emacs coding style prefers signed int.
3468 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3469 were being counted with int, which may truncate counts on 64-bit
3470 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3471 * lisp.h (struct Lisp_Subr.function.aMANY)
3472 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3473 Arg counts are now ptrdiff_t, not size_t.
3474 All variadic functions and their callers changed accordingly.
3475 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3476 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3477 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3478 * callint.c (Fcall_interactively): Check arg count for overflow,
3479 to avoid potential buffer overrun. Use signed char, not 'int',
3480 for 'varies' array, so that we needn't bother to check its size
3481 calculation for overflow.
3482 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3483 * eval.c (apply_lambda):
3484 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3485 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3486 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3487
a1759b76
PE
3488 * callint.c (Fcall_interactively): Don't use index var as event count.
3489
d96be9fc
PE
3490 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3491 * mem-limits.h (SIZE): Remove; no longer used.
3492
a690a978 3493 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3494
578c21e6
PE
3495 Remove unnecessary casts.
3496 * xterm.c (x_term_init):
3497 * xfns.c (x_set_border_pixel):
3498 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3499 These aren't needed now that we assume ANSI C.
3500
96f53c6c
PE
3501 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3502 It's more likely to cause problems (due to unsigned overflow)
3503 than to cure them.
3504
83c77d31
PE
3505 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3506
ee2079f1
PE
3507 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3508
6da65536
PE
3509 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3510
7147c4a4
PE
3511 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3512
193e32d9
PE
3513 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3514
e5533da6
PE
3515 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3516
9910e595
PE
3517 GLYPH_CODE_FACE returns EMACS_INT, not int.
3518 * dispextern.h (merge_faces):
3519 * xfaces.c (merge_faces):
01103c44
PE
3520 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3521 Don't assume EMACS_INT fits in int.
9910e595 3522
2638320e
PE
3523 * character.h (CHAR_VALID_P): Remove unused parameter.
3524 * fontset.c, lisp.h, xdisp.c: All uses changed.
3525
045eb8d9
PE
3526 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3527
c1f134b5
PE
3528 * fns.c (concat): Minor tuning based on overflow analysis.
3529 This doesn't fix any bugs. Use int to hold character, instead
3530 of constantly refetching from Emacs object. Use XFASTINT, not
3531 XINT, for value known to be a character. Don't bother comparing
3532 a single byte to 0400, as it's always less.
3533
395fcb93 3534 * floatfns.c (Fexpt):
327eeec8
PE
3535 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3536
abbd3d23
PE
3537 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3538 for characters.
3539
684a03ef
PE
3540 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3541
0fed43f3
PE
3542 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3543 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3544 incorrectly succeed when S was a string, because 4294967386 was
3545 truncated before it was used.
3546
8fd02eb7
PE
3547 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3548 Otherwise, an out-of-range integer could cause undefined behavior
3549 on a 64-bit host.
3550
f8c86b69
PE
3551 * composite.c: Use int, not EMACS_INT, for characters.
3552 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3553 EMACS_INT, for values that are known to be in character range.
3554 This doesn't fix any bugs but is the usual style inside Emacs and
3555 may generate better code on 32-bit machines.
3556
34206dd2
PE
3557 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3558 This is for reasons similar to the recent CHAR_STRING fix.
3559 * charset.c (Fencode_char): Check that character arg is actually
3560 a character. Pass an int to ENCODE_CHAR.
3561 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3562 wider than 'int', as a compile-time check to prevent future regressions
3563 in this area.
3564
c5958d4c 3565 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3566
3567 Make sure a 64-bit char is never passed to CHAR_STRING.
3568 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3569 by silently ignoring the top 32 bits, allowing some values
3570 that were far too large to be valid characters.
3571 * character.h: Include <verify.h>.
3572 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3573 arguments are no wider than unsigned, as a compile-time check
3574 to prevent future regressions in this area.
3575 * data.c (Faset):
01103c44 3576 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3577 (Fsubst_char_in_region):
3578 * fns.c (concat):
3579 * xdisp.c (decode_mode_spec_coding):
3580 Adjust to CHAR_STRING's new requirement.
3581 * editfns.c (Finsert_char, Fsubst_char_in_region):
3582 * fns.c (concat): Check that character args are actually
3583 characters. Without this test, these functions did the wrong
3584 thing with wildly out-of-range values on 64-bit hosts.
3585
d37ca623
PE
3586 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3587 These casts should not be needed on 32-bit hosts, either.
3588 * keyboard.c (read_char):
3589 * lread.c (Fload): Remove casts to unsigned.
3590
ea204efb
PE
3591 * lisp.h (UNSIGNED_CMP): New macro.
3592 This fixes comparison bugs on 64-bit hosts.
3593 (ASCII_CHAR_P): Use it.
3594 * casefiddle.c (casify_object):
01103c44 3595 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3596 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3597 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3598 * dispextern.h (FACE_FROM_ID):
3599 * keyboard.c (read_char): Use UNSIGNED_CMP.
3600
41cb286c
PE
3601 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3602 not to EMACS_INT, to avoid GCC warning.
3603
4a1b9832
PE
3604 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3605
55daad71
PE
3606 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3607 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3608 isn't needed on 32-bit machines.
8f95c75c 3609
01103c44
PE
3610 * buffer.c (Fgenerate_new_buffer_name):
3611 Use EMACS_INT for count, not int.
0ceccced 3612 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3613
3614 * data.c (Qcompiled_function): Now static.
3615
c6f072e7
PE
3616 * window.c (window_body_lines): Now static.
3617
20ce5912
PE
3618 * image.c (gif_load): Rename local to avoid shadowing.
3619
9c4c5f81
PE
3620 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3621 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3622 * alloc.c (make_save_value): Integer argument is now of type
3623 ptrdiff_t, not int.
3624 (mark_object): Use ptrdiff_t, not int.
3625 * lisp.h (pD): New macro.
3626 * print.c (print_object): Use it.
3627
c0c5c8ae
PE
3628 * alloc.c: Use EMACS_INT, not int, to count objects.
3629 (total_conses, total_markers, total_symbols, total_vector_size)
3630 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3631 (total_free_floats, total_floats, total_free_intervals)
3632 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3633 Now EMACS_INT, not int. All uses changed.
3634 (Fgarbage_collect): Compute overall total using a double, so that
3635 integer overflow is less likely to be a problem. Check for overflow
3636 when converting back to an integer.
5a25e253
PE
3637 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3638 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3639 These were 'int' variables that could overflow on 64-bit hosts;
3640 they were never used, so remove them instead of repairing them.
211a0b2a 3641 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3642 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3643 Previously, this ceilinged at INT_MAX, but that doesn't work on
3644 64-bit machines.
e46bb31a 3645 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3646
c78baabf 3647 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3648 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3649 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3650 when a (possibly-narrower) signed value would do just as well.
3651 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3652
c9d624c6
PE
3653 * alloc.c: Catch some string size overflows that we were missing.
3654 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3655 for convenience in STRING_BYTES_MAX.
3656 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3657 The definition here is exact; the one in lisp.h was approximate.
3658 (allocate_string_data): Check for string overflow. This catches
3659 some instances we weren't catching before. Also, it catches
3660 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3661 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3662 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3663
c9d624c6
PE
3664 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3665 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3666 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3667
353032ce
PE
3668 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3669
2bccce07
PE
3670 * alloc.c (Fmake_string): Check for out-of-range init.
3671
0ac30604
SM
36722011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3673
3674 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3675
c195f2de
JD
36762011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3677
3678 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3679 xg_get_default_scrollbar_width.
3680
3681 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3682 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3683 (style_changed_cb): Call update_theme_scrollbar_width and call
3684 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3685 all frames (Bug#8505).
3686 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3687 Call gtk_window_set_resizable if HAVE_GTK3.
3688 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3689 and height if HAVE_GTK3 (Bug#8505).
3690 (scroll_bar_width_for_theme): New variable.
3691 (update_theme_scrollbar_width): New function.
3692 (xg_get_default_scrollbar_width): Move code to
3693 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3694 (xg_initialize): Call update_theme_scrollbar_width.
3695
3696 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3697
3698 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3699
e10ac9f1
MR
37002011-06-12 Martin Rudalics <rudalics@gmx.at>
3701
3702 * frame.c (make_frame): Call other_buffer_safely instead of
3703 other_buffer.
3704
3705 * window.c (temp_output_buffer_show): Call display_buffer with
3706 second argument Vtemp_buffer_show_specifiers and reset latter
3707 immediately after the call.
3708 (Vtemp_buffer_show_specifiers): New variable.
3709 (auto_window_vscroll_p, next_screen_context_lines)
3710 (Vscroll_preserve_screen_position): Remove leading asterisks from
3711 doc-strings.
3712
2d3c217e 37132011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3714
7b7f97e8 3715 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3716 * buffer.c (Qclone_number): Remove for now, as it's unused.
3717 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3718 (record_buffer): Remove unused local.
3719 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3720 (set_frame_buffer_list): Remove; unused.
3721 * frame.h (other_visible_frames): Remove decl.
3722 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3723 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3724 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3725 if HAVE_GPM.
3726 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3727 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3728 Define only if HAVE_GPM.
3729 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3730 (update_hints_inhibit): Remove; never set. All uses removed.
3731 * widgetprv.h (emacsFrameClassRec): Remove decl.
3732 * window.c (delete_deletable_window): Now returns void, since it
3733 wasn't returning anything.
3734 (compare_window_configurations): Remove unused locals.
3735 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3736 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3737 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3738 the same widths as pointers. This follows up on the 2011-05-06 patch.
3739 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3740 * xterm.h: Likewise.
3741 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3742
1384b89e
JB
37432011-06-12 Juanma Barranquero <lekktu@gmail.com>
3744
3745 * makefile.w32-in: Update dependencies.
3746 (LISP_H): Add lib/intprops.h.
3747
1100a63c
CY
37482011-06-11 Chong Yidong <cyd@stupidchicken.com>
3749
3750 * image.c (gif_load): Add animation frame delay to the metadata.
3751 (syms_of_image): Use DEFSYM. New symbol `delay'.
3752
6198ccd0
MR
37532011-06-11 Martin Rudalics <rudalics@gmx.at>
3754
3755 * window.c (delete_deletable_window): Re-add.
3756 (Fset_window_configuration): Rewrite to handle dead buffers and
3757 consequently deletable windows.
3758 (window_tree, Fwindow_tree): Remove. Supply functionality in
3759 window.el.
3760 (compare_window_configurations): Simplify code.
3761
b6e3633c
AS
37622011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3763
1ab0dee5
AS
3764 * image.c (imagemagick_load_image): Fix type mismatch.
3765 (Fimagemagick_types): Likewise.
3766
b6e3633c
AS
3767 * window.h (replace_buffer_in_windows): Declare.
3768
9397e56f
MR
37692011-06-11 Martin Rudalics <rudalics@gmx.at>
3770
3771 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3772 Qclone_number. Remove external declaration of Qdelete_window.
3773 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3774 code.
640c8776
SM
3775 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3776 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3777 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3778 buffer list implementation.
3779 (other_buffer_safely): New function.
3780 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3781 calls to replace_buffer_in_windows and
3782 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3783 if allowed.
3784 (record_buffer): Inhibit quitting and rewrite using quittable
3785 functions. Run Qbuffer_list_update_hook if allowed.
3786 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3787 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3788 Move switch-to-buffer to window.el.
9397e56f
MR
3789 (bury-buffer): Move to window.el.
3790 (Vbuffer_list_update_hook): New variable.
3791
3792 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3793 section.
3794
3795 * window.h (resize_frame_windows): Move up in code.
3796 (Fwindow_frame): Remove EXFUN.
3797 (replace_buffer_in_all_windows): Remove prototype.
3798 (replace_buffer_in_windows_safely): Add prototype.
3799
3800 * window.c: Declare Qdelete_window static again. Move down
3801 declaration of select_count.
3802 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3803 (Fother_window): Move to window.el.
3804 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3805 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3806 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3807 window.el.
3808 (replace_buffer_in_windows): Implement by calling
3809 Qreplace_buffer_in_windows.
3810 (replace_buffer_in_all_windows): Remove with some functionality
3811 moved into replace_buffer_in_windows_safely.
3812 (replace_buffer_in_windows_safely): New function.
3813 (select_window_norecord, select_frame_norecord): Move in front
3814 of run_window_configuration_change_hook. Remove now obsolete
3815 declarations.
640c8776
SM
3816 (Fset_window_buffer): Rewrite doc-string.
3817 Call Qrecord_window_buffer.
9397e56f
MR
3818 (keys_of_window): Move binding for other-window to window.el.
3819
b50691aa
CY
38202011-06-11 Chong Yidong <cyd@stupidchicken.com>
3821
3822 * dispextern.h (struct image): Replace data member, whose int_val
3823 and ptr_val fields were not used by anything, with a single
3824 lisp_val object.
3825
3826 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3827 (gif_clear_image, gif_load, imagemagick_load_image)
3828 (gs_clear_image, gs_load): Callers changed.
3829
3f754b86
PE
38302011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3831
cca69397
PE
3832 * buffer.h: Include <time.h>, for time_t.
3833 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3834
109e28d0
PE
3835 Fix minor problems found by static checking.
3836
60737f02
PE
3837 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3838
4b66faf3
PE
3839 Make identifiers static if they are not used in other modules.
3840 * data.c (Qcompiled_function, Qframe, Qvector):
3841 * image.c (QimageMagick, Qsvg):
3842 * minibuf.c (Qmetadata):
3843 * window.c (resize_window_check, resize_root_window): Now static.
3844 * window.h (resize_window_check, resize_root_window): Remove decls.
3845
109e28d0
PE
3846 * window.c (window_deletion_count, delete_deletable_window):
3847 Remove; unused.
46a4ce9e
PE
3848 (window_body_lines): Now static.
3849 (Fdelete_other_windows_internal): Mark vars as initialized.
3850 Make sure 'resize_failed' is initialized.
3851 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3852 (resize_window_apply): Remove unused local.
3853 * window.h (delete_deletable_window): Remove decl.
3854
109e28d0 3855 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3856 (imagemagick_load_image): Fix pointer signedness problem by changing
3857 last arg from unsigned char * to char *. All uses changed.
3858 Also, fix a local for similar reasons.
3859 Remove unused locals. Remove locals to avoid shadowing.
3860 (fn_rsvg_handle_free): Remove; unused.
3861 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3862 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3863
3f754b86
PE
3864 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3865
2547adb1
CY
38662011-06-10 Chong Yidong <cyd@stupidchicken.com>
3867
3868 * image.c (gif_load): Fix omitted cast error introduced by
3869 2011-06-06 change.
3870
2c8e37d4
MR
38712011-06-10 Martin Rudalics <rudalics@gmx.at>
3872
3873 * window.h (resize_proportionally, orig_total_lines)
3874 (orig_top_line): Remove from window structure.
3875 (set_window_height, set_window_width, change_window_heights)
3876 (Fdelete_window): Remove prototypes.
3877 (resize_frame_windows): Remove duplicate declaration.
3878
440a42e3
EZ
38792011-06-10 Eli Zaretskii <eliz@gnu.org>
3880
3881 * window.h (resize_frame_windows, resize_window_check)
3882 (delete_deletable_window, resize_root_window)
3883 (resize_frame_windows): Declare prototypes.
3884
3885 * window.c (resize_window_apply): Make definition be "static" to
3886 match the prototype.
3887
562dd5e9
MR
38882011-06-10 Martin Rudalics <rudalics@gmx.at>
3889
3890 * window.c: Remove declarations of Qwindow_size_fixed,
3891 window_min_size_1, window_min_size_2, window_min_size,
3892 size_window, window_fixed_size_p, enlarge_window, delete_window.
3893 Remove static from declaration of Qdelete_window, it's
3894 temporarily needed by Fbury_buffer.
3895 (replace_window): Don't assign orig_top_line and
3896 orig_total_lines.
3897 (Fdelete_window, delete_window): Remove. Window deletion is
3898 handled by window.el.
640c8776
SM
3899 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3900 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3901 (Fdelete_other_windows): Remove. Deleting other windows is
3902 handled by window.el.
3903 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3904 handled in window.el.
3905 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3906 Window minimum sizes are handled in window.el.
3907 (shrink_windows, size_window, set_window_height)
3908 (set_window_width, change_window_heights, window_height)
3909 (window_width, CURBEG, CURSIZE, enlarge_window)
3910 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3911 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3912 handled in window.el.
3913 (make_dummy_parent): Rename to make_parent_window and give it a
3914 second argument horflag.
3915 (make_window): Don't set resize_proportionally any more.
3916 (Fsplit_window): Remove. Windows are split in window.el.
3917 (save_restore_action, save_restore_orig_size)
3918 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3919 Resize mini windows in window.el.
3920 (grow_mini_window, shrink_mini_window): Implement by calling
3921 Qresize_root_window_vertically, resize_window_check and
3922 resize_window_apply.
640c8776
SM
3923 (saved_window, Fset_window_configuration, save_window_save):
3924 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3925 resize_proportionally.
3926 (window_min_height, window_min_width): Move to window.el.
3927 (keys_of_window): Move bindings for delete-other-windows,
3928 split-window, delete-window and enlarge-window to window.el.
3929
3930 * buffer.c: Temporarily extern Qdelete_window.
3931 (Fbury_buffer): Temporarily call Qdelete_window instead of
3932 Fdelete_window (Fbury_buffer will move to window.el soon).
3933
3934 * frame.c (set_menu_bar_lines_1): Remove code handling
3935 orig_top_line and orig_total_lines.
3936
3937 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3938 set_window_height but set heights directly.
3939 (change_frame_size_1): Use resize_frame_windows.
3940
3941 * xdisp.c (init_xdisp): Don't use set_window_height but set
3942 heights directly.
3943
640c8776
SM
3944 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3945 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3946 run_window_configuration_change_hook.
3947
3948 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3949 instead of change_window_heights and run
3950 run_window_configuration_change_hook.
3951
1a13852e
MR
39522011-06-09 Martin Rudalics <rudalics@gmx.at>
3953
3954 * window.c (replace_window): Rename second argument REPLACEMENT to
3955 NEW. New third argument SETFLAG. Rewrite.
3956 (delete_window, make_dummy_parent): Call replace_window with
3957 third argument 1.
3958 (window_list_1): Move down in code.
3959 (run_window_configuration_change_hook): Move set_buffer part
3960 before select_frame_norecord part in order to unwind correctly.
3961 Rename count1 to count.
3962 (recombine_windows, delete_deletable_window, resize_root_window)
3963 (Fdelete_other_windows_internal)
3964 (Frun_window_configuration_change_hook, make_parent_window)
3965 (resize_window_check, resize_window_apply, Fresize_window_apply)
3966 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3967 (Fdelete_window_internal, Fresize_mini_window_internal):
3968 New functions.
1a13852e
MR
3969 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3970
f3d1777e
MR
39712011-06-08 Martin Rudalics <rudalics@gmx.at>
3972
496e208e
MR
3973 * window.h (window): Add some new members to window structure -
3974 normal_lines, normal_cols, new_total, new_normal, clone_number,
3975 splits, nest, prev_buffers, next_buffers.
3976 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3977 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3978
f3d1777e
MR
3979 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3980 Remove.
496e208e
MR
3981 (make_dummy_parent): Set new members of windows structure.
3982 (make_window): Move down in code. Handle new members of window
3983 structure.
3984 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3985 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3986 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3987 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3988 (Fset_window_next_buffers, Fset_window_clone_number):
3989 New functions.
496e208e
MR
3990 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3991 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3992 Doc-string fixes.
3993 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3994 Argument WINDOW can be now internal window too.
3995 (Fwindow_use_time): Move up in code.
3996 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3997 Rewrite doc-string.
3998 (Fset_window_configuration, saved_window)
3999 (Fcurrent_window_configuration, save_window_save): Handle new
4000 members of window structure.
b9e809c2
MR
4001 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4002 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4003 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4004 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4005 Qget_mru_window, Qresize_root_window,
4006 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4007 Qauto_buffer_name; staticpro them.
f3d1777e 4008
abde8f8c
MR
40092011-06-07 Martin Rudalics <rudalics@gmx.at>
4010
4011 * window.c (Fwindow_total_size, Fwindow_left_column)
4012 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4013 (Fwindow_list_1): New functions.
4014 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4015 (Fwindow_width, Fscroll_left, Fscroll_right):
4016 Use window_body_cols instead of window_box_text_cols.
4017 (delete_window, Fset_window_configuration):
4018 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4019 (delete_all_subwindows): Take a window as argument and not a
4020 structure. Rewrite.
190b47e6
MR
4021 (window_loop): Remove handling of GET_LRU_WINDOW and
4022 GET_LARGEST_WINDOW.
4023 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4024
4025 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4026 window_box_text_cols. delete_all_subwindows now takes a
4027 Lisp_Object as argument.
abde8f8c 4028
640c8776
SM
4029 * indent.c (compute_motion, Fcompute_motion):
4030 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4031
fa8a67e6
MR
4032 * frame.c (delete_frame): Call delete_all_subwindows with root
4033 window as argument.
4034
a54e3482
DC
40352011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4036
4037 * fns.c (Fputhash): Document return value.
4038
60002bf5
CY
40392011-06-06 Chong Yidong <cyd@stupidchicken.com>
4040
4041 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4042
0c671da6 40432011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4044
b862a52a 4045 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4046
be44ca6c
PE
4047 Check for overflow when converting integer to cons and back.
4048 * charset.c (Fdefine_charset_internal, Fdecode_char):
4049 Use cons_to_unsigned to catch overflow.
4050 (Fencode_char): Use INTEGER_TO_CONS.
4051 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4052 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4053 * data.c (long_to_cons, cons_to_long): Remove.
4054 (cons_to_unsigned, cons_to_signed): New functions.
4055 These signal an error for invalid or out-of-range values.
4056 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4057 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4058 * font.c (Ffont_variation_glyphs):
4059 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4060 * lisp.h: Include <intprops.h>.
4061 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4062 (cons_to_signed, cons_to_unsigned): New decls.
4063 (long_to_cons, cons_to_long): Remove decls.
4064 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4065 (Fprimitive_undo): Use CONS_TO_INTEGER.
4066 * xfns.c (Fx_window_property): Likewise.
4067 * xselect.c: Include <limits.h>.
4068 (x_own_selection, selection_data_to_lisp_data):
4069 Use INTEGER_TO_CONS.
4070 (x_handle_selection_request, x_handle_selection_clear)
4071 (x_get_foreign_selection, Fx_disown_selection_internal)
4072 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4073 (lisp_data_to_selection_data): Use cons_to_unsigned.
4074 (x_fill_property_data): Use cons_to_signed.
4075 Report values out of range.
4076
d1f3d2af
PE
4077 Check for buffer and string overflow more precisely.
4078 * buffer.h (BUF_BYTES_MAX): New macro.
4079 * lisp.h (STRING_BYTES_MAX): New macro.
4080 * alloc.c (Fmake_string):
4081 * character.c (string_escape_byte8):
4082 * coding.c (coding_alloc_by_realloc):
4083 * doprnt.c (doprnt):
4084 * editfns.c (Fformat):
4085 * eval.c (verror):
4086 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4087 since they may not be the same number.
4088 * editfns.c (Finsert_char):
4089 * fileio.c (Finsert_file_contents):
4090 Likewise for BUF_BYTES_MAX.
4091
dd52fcea
PE
4092 * image.c: Use ptrdiff_t, not int, for sizes.
4093 (slurp_file): Switch from int to ptrdiff_t.
4094 All uses changed.
4095 (slurp_file): Check that file size fits in both size_t (for
4096 malloc) and ptrdiff_t (for sanity and safety).
4097
7f9bbdbb
PE
4098 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4099 if b->modtime has its maximal value.
4100
dfe18f82
PE
4101 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4102
84acfcf0
PE
4103 Don't assume time_t can fit into int.
4104 * buffer.h (struct buffer.modtime): Now time_t, not int.
4105 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4106 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4107
ccd9a01a
PE
4108 Minor fixes for signed vs unsigned integers.
4109 * character.h (MAYBE_UNIFY_CHAR):
4110 * charset.c (maybe_unify_char):
4111 * keyboard.c (read_char, reorder_modifiers):
4112 XINT -> XFASTINT, since the integer must be nonnegative.
4113 * ftfont.c (ftfont_spec_pattern):
4114 * keymap.c (access_keymap, silly_event_symbol_error):
4115 XUINT -> XFASTINT, since the integer must be nonnegative.
4116 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4117 since it makes no difference and we prefer signed.
4118 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4119 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4120 nonnegative.
4121
d6d100dd
SM
41222011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4123
4124 * window.h (Fwindow_frame): Declare.
4125
2b6148e4
PE
41262011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4127
4128 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4129 (SPARE_MEMORY): Always define.
4130 (LARGE_REQUEST): Remove.
4131 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4132
f230ecc9
MR
41332011-06-06 Martin Rudalics <rudalics@gmx.at>
4134
727e958e
MR
4135 * lisp.h: Move EXFUNS for Fframe_root_window,
4136 Fframe_first_window and Fset_frame_selected_window to window.h.
4137
4138 * window.h: Move EXFUNS for Fframe_root_window,
4139 Fframe_first_window and Fset_frame_selected_window here from
4140 lisp.h.
4141
4142 * frame.c (Fwindow_frame, Fframe_first_window)
4143 (Fframe_root_window, Fframe_selected_window)
4144 (Fset_frame_selected_window): Move to window.c.
4145 (Factive_minibuffer_window): Move to minibuf.c.
4146 (Fother_visible_frames_p): New function.
4147
4148 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4149
f230ecc9
MR
4150 * window.c (decode_window, decode_any_window): Move up in code.
4151 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4152 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4153 (Fwindow_buffer): Move up and rewrite doc-string.
4154 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4155 (Fwindow_prev): New functions.
727e958e
MR
4156 (Fwindow_frame): Move here from frame.c. Accept any window as
4157 argument.
4158 (Fframe_root_window, Fframe_first_window)
4159 (Fframe_selected_window): Move here from frame.c. Accept frame
4160 or arbitrary window as argument. Update doc-strings.
4161 (Fminibuffer_window): Move up in code.
4162 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4163 (Fset_frame_selected_window): Move here from frame.c.
4164 Marginal rewrite.
727e958e
MR
4165 (Fselected_window, select_window, Fselect_window): Move up in
4166 code. Minor doc-string fixes.
f230ecc9 4167
4d09bcf6
PE
41682011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4169
4170 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4171 Do not assume that spare memory exists; that assumption is valid
4172 only if SYSTEM_MALLOC.
4173 (LARGE_REQUEST): New macro, so that the issue of large requests
4174 is separated from the issue of spare memory.
4175
810928a2
AS
41762011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4177
172418ad
AS
4178 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4179 format. (Bug#8806)
4180
43f862f7
AS
4181 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4182
810928a2
AS
4183 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4184 before statements.
4185
a059fe24
JD
41862011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4187
4188 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4189
4190 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4191
4192 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4193 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4194
989bf368
JB
41952011-06-05 Juanma Barranquero <lekktu@gmail.com>
4196
4197 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4198
4b80f674
CY
41992011-06-04 Chong Yidong <cyd@stupidchicken.com>
4200
4201 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4202 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4203 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4204 New error handlers.
4b80f674
CY
4205 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4206 Obey Vx_select_enable_clipboard_manager. Catch errors in
4207 x_clipboard_manager_save (Bug#8779).
4208 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4209 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4210
99a33b77 42112011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4212
4213 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4214
99a33b77 42152011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4216
4217 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4218 in the current matrix if keep_current_p is non-zero.
4219
8264569d
EZ
42202011-06-04 Eli Zaretskii <eliz@gnu.org>
4221
4222 * bidi.c (bidi_level_of_next_char): Fix last change.
4223
57f97249
EZ
42242011-06-03 Eli Zaretskii <eliz@gnu.org>
4225
fec2107c 4226 Support bidi reordering of text covered by display properties.
57f97249 4227
fec2107c
EZ
4228 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4229 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4230 (bidi_cache_search, bidi_cache_iterator_state)
4231 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4232 (bidi_level_of_next_char, bidi_move_to_visually_next):
4233 Support character positions inside a run of characters covered by a
fec2107c
EZ
4234 display string.
4235 (bidi_paragraph_init, bidi_resolve_explicit_1)
4236 (bidi_level_of_next_char): Call bidi_fetch_char and
4237 bidi_fetch_char_advance instead of FETCH_CHAR and
4238 FETCH_CHAR_ADVANCE.
4239 (bidi_init_it): Initialize new members.
4240 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4241 definitions.
4242 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4243 instead of using explicit *_CHAR codes.
d6d100dd
SM
4244 (bidi_resolve_explicit, bidi_resolve_weak):
4245 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4246 bidirectional text is supported only in multibyte buffers.
4247 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4248 it to initialize the frame_window_p member of struct bidi_it.
4249 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4250 (bidi_resolve_explicit, bidi_resolve_weak)
4251 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4252 bidi_it->nchars is non-positive.
4253 (bidi_level_of_next_char): Don't try to lookup the cache for the
4254 next/previous character if nothing is cached there yet, or if we
4255 were just reseat()'ed to a new position.
c40e2fb2 4256
0e14fe90
EZ
4257 * xdisp.c (set_cursor_from_row): Set start and stop points
4258 according to the row's direction when priming the loop that looks
4259 for the glyph on which to display cursor.
4260 (single_display_spec_intangible_p): Function deleted.
4261 (display_prop_intangible_p): Reimplement to call
4262 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4263 Accept 3 additional arguments needed by handle_display_spec.
4264 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4265 values: lists, `(when COND...)' forms, etc.
4266 (single_display_spec_string_p): Support property values that are
4267 lists with the argument STRING its top-level element.
4268 (display_prop_string_p): Fix the condition for processing a
4269 property that is a list to be consistent with handle_display_spec.
fec2107c 4270 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4271 last portion of handle_display_prop.
4272 (compute_display_string_pos): Accept additional argument
4273 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4274 value of a `display' property is a "replacing spec".
4275 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4276 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4277 the display property, but just return a value indicating whether
4278 the display property will replace the characters it covers.
4279 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4280 frame_window_p members of struct bidi_it.
d6d100dd
SM
4281 (compute_display_string_pos, compute_display_string_end):
4282 New functions.
fec2107c
EZ
4283 (push_it): Accept second argument POSITION, where pop_it should
4284 jump to continue iteration.
4285 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4286
fec2107c
EZ
4287 * keyboard.c (adjust_point_for_property): Adjust the call to
4288 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4289
4290 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4291 (bidi_init_it): Update prototypes.
4292 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4293 (compute_display_string_pos, compute_display_string_end):
4294 Declare prototypes.
fec2107c
EZ
4295 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4296 EMACS_INT.
fc6f18ce 4297
40087514 42982011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4299
57f53182
PE
4300 Malloc failure behavior now depends on size of allocation.
4301 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4302 * lisp.h: Change signatures accordingly.
4303 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4304 All callers changed. (Bug#8762)
4305
4306 * gnutls.c: Use Emacs's memory allocators.
4307 Without this change, the gnutls library would invoke malloc etc.
4308 directly, which causes problems on non-SYNC_INPUT hosts, and which
4309 runs afoul of improving memory_full behavior. (Bug#8761)
4310 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4311 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4312 xfree instead of the default malloc, realloc, free.
4313 (Fgnutls_boot): No need to check for memory allocation failure,
4314 since xmalloc does that for us.
4315
ac32cd99 4316 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4317 * category.c (hash_get_category_set):
4318 * ccl.c (ccl_driver):
4319 * charset.c (Fdefine_charset_internal):
4320 * charset.h (struct charset.hash_index):
4321 * composite.c (get_composition_id, gstring_lookup_cache)
4322 (composition_gstring_put_cache):
4323 * composite.h (struct composition.hash_index):
4324 * dispextern.h (struct image.hash):
4325 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4326 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4327 (hashfn_equal, hashfn_user_defined, make_hash_table)
4328 (maybe_resize_hash_table, hash_lookup, hash_put)
4329 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4330 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4331 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4332 * image.c (make_image, search_image_cache, lookup_image)
4333 (xpm_put_color_table_h):
4334 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4335 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4336 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4337 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4338 * alloc.c (allocate_vectorlike):
4339 Check for overflow in vector size calculations.
4340 * ccl.c (ccl_driver):
4341 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4342 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4343 need to be updated by these changes.
40087514
PE
4344 * fns.c (make_hash_table, maybe_resize_hash_table):
4345 Check for integer overflow with large hash tables.
0de4bb68
PE
4346 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4347 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4348 (SXHASH_REDUCE): New macro.
4349 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4350 Use it instead of discarding useful hash info with large hash values.
4351 (sxhash_float): New function.
4352 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4353 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4354 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4355 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4356 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4357 Adjust signatures to match updated version of code.
4358 (consing_since_gc): Now EMACS_INT, since a single hash table can
4359 use more than INT_MAX bytes.
4360
698d32e2
DN
43612011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4362
4363 Make it possible to build with GCC-4.6+ -O2 -flto.
4364
4365 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4366
fd6fa53f
SM
43672011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4368
4369 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4370 Call minibuffer-inactive-mode.
4371
864db017
JB
43722011-05-31 Juanma Barranquero <lekktu@gmail.com>
4373
4374 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4375 Update dependencies.
4376
2ad0baf4
DN
43772011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4378
4379 * data.c (init_data): Remove code for UTS, this system is not
4380 supported anymore.
4381
4fcc2638
DN
43822011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4383
4384 Don't force ./temacs to start in terminal mode.
4385
4386 * frame.c (make_initial_frame): Initialize faces in all cases, not
4387 only when CANNOT_DUMP is defined.
4388 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4389
c56e0fd5
DN
43902011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4391
4392 * dispnew.c (add_window_display_history): Use const for the string
4393 pointer. Remove declaration, not needed.
4394
333d54da 43952011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4396
55d4c1b2 4397 Use 'inline', not 'INLINE'.
333d54da 4398 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4399 * alloc.c, fontset.c (INLINE): Remove.
4400 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4401 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4402 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4403 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4404 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4405
738db178
DN
44062011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4407
4408 Make it possible to run ./temacs.
4409
4410 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4411 syms_of_callproc does the same thing. Remove test for
4412 "initialized", do it in the caller.
4413 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4414
620c53a6
SM
44152011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4416
4417 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4418 (read_minibuf): Use get_minibuffer.
4419 (syms_of_minibuf): Use DEFSYM.
4420 (Qmetadata): New var.
4421 * data.c (Qbuffer): Don't make it static.
4422 (syms_of_data): Use DEFSYM.
4423
e003a292
PE
44242011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4425
4426 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4427 (CCL_CODE_MIN): New macro.
4428
ed008a6d
PE
44292011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4430
3687c2ef
PE
4431 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4432
ed008a6d
PE
4433 * eval.c (Qdebug): Now static.
4434 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4435 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4436 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4437
d66c4c7c
CY
44382011-05-29 Chong Yidong <cyd@stupidchicken.com>
4439
4440 * image.c: Various fixes to ImageMagick code comments.
4441 (Fimagemagick_types): Doc fix.
4442
5fbc2025
PE
44432011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4444
0196f88a
PE
4445 Minor fixes prompted by GCC 4.6.0 warnings.
4446
4447 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4448
5fbc2025
PE
4449 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4450 (x_clipboard_manager_save_all): Move extern decl to ...
4451 * xterm.h: ... here, so that it can be checked for consistency.
4452
1dd3c2d9
CY
44532011-05-29 Chong Yidong <cyd@stupidchicken.com>
4454
4455 * xselect.c (x_clipboard_manager_save_frame)
4456 (x_clipboard_manager_save_all): New functions.
4457 (Fx_clipboard_manager_save): Lisp function deleted.
4458
4459 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4460 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4461
4462 * xterm.h: Update prototype.
4463
5ba6571d
WX
44642011-05-28 William Xu <william.xwl@gmail.com>
4465
4466 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4467 exiting (Bug#8239).
4468
3eaff834
JM
44692011-05-28 Jim Meyering <meyering@redhat.com>
4470
e1900994 4471 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4472 * fns.c (to_uchar): Define.
4473 (crypto_hash_function): Use it to convert some newly-signed
4474 variables to unsigned, to avoid sign-extension bugs. For example,
4475 without this change, (md5 "truc") would evaluate to
4476 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4477 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4478 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4479
0f6990a7
PE
44802011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4481
4482 Integer overflow fixes.
c8a9ca5a 4483
08686060
PE
4484 * dbusbind.c: Serial number integer overflow fixes.
4485 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4486 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4487 to hold a serial number that is too large for a fixnum.
4488 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4489 Check for serial numbers out of range. Decode any serial number
59568bf0 4490 that was so large that it became a float. (Bug#8722)
08686060 4491
2d1fc3c7
PE
4492 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4493 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4494 Use XFASTINT rather than XUINT when numbers are nonnegative.
4495 (xd_append_arg, Fdbus_method_return_internal):
4496 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4497 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4498 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4499 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4500 (Bug#8722)
2d1fc3c7 4501
c8a9ca5a
PE
4502 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4503
519e1d69
PE
4504 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4505
30569699
PE
4506 ccl: add integer overflow checks
4507 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4508 (IN_INT_RANGE): New macros.
4509 (ccl_driver): Use them to check for integer overflow when
4510 decoding a CCL program. Many of the new checks are whether XINT (x)
4511 fits in int; it doesn't always, on 64-bit hosts. The new version
4512 doesn't catch all possible integer overflows, but it's an
847044ea 4513 improvement. (Bug#8719)
30569699 4514
c11285dc
PE
4515 * alloc.c (make_event_array): Use XINT, not XUINT.
4516 There's no need for unsigned here.
4517
fdccd48e
PE
4518 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4519 This follows up to the 2011-05-06 change that substituted uintptr_t
4520 for EMACS_INT. This case wasn't caught back then.
4521
37910ab2
PE
4522 Rework Fformat to avoid integer overflow issues.
4523 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4524 now (part of C89). Include <verify.h>.
4525 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4526 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4527 (Fformat): Avoid the prepass trying to compute sizes; it was only
4528 approximate and thus did not catch overflow reliably. Instead, walk
4529 through the format just once, formatting and computing sizes as we go,
4530 checking for integer overflow at every step, and allocating a larger
4531 buffer as needed. Keep track separately whether the format is
4532 multibyte. Keep only the most-recently calculated precision, rather
4533 than them all. Record whether each argument has been converted to
4534 string. Use EMACS_INT, not int, for byte and char and arg counts.
4535 Support field widths and precisions larger than INT_MAX. Avoid
4536 sprintf's undefined behavior with conversion specifications such as %#d
4537 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4538 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4539 formatting out-of-range floating point numbers with int
9173deec 4540 formats. (Bug#8668)
37910ab2 4541
2e6578fb
PE
4542 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4543
0ae6bdee
PE
4544 * data.c: Avoid integer truncation in expressions involving floats.
4545 * data.c: Include <intprops.h>.
4546 (arith_driver): When there's an integer overflow in an expression
4547 involving floating point, convert the integers to floating point
4548 so that the resulting value does not suffer from catastrophic
4549 integer truncation. For example, on a 64-bit host (* 4
4550 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4551 Do not rely on undefined behavior after integer overflow.
4552
de883a70
PE
4553 merge count_size_as_multibyte, parse_str_to_multibyte
4554 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4555 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4556 Check for integer overflow.
4557 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4558 since it's now a duplicate of the other. This is more of
4559 a character than a buffer op, so better that it's in character.c.
4560 * fns.c, print.c: Adjust to above changes.
4561
2ff916cb
PE
45622011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4563
4564 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4565
f1b54466
PE
45662011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4567
fb1ac845
PE
4568 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4569 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4570 (x_clipboard_manager_save): Now static.
4571 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4572
f1b54466
PE
4573 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4574 (crypto_hash_function): Now static.
4575 Fix pointer signedness problems. Avoid unnecessary initializations.
4576
a9f737ee
CY
45772011-05-27 Chong Yidong <cyd@stupidchicken.com>
4578
4579 * termhooks.h (Vselection_alist): Make it terminal-local.
4580
4581 * terminal.c (create_terminal): Initialize it.
4582
4583 * xselect.c: Support for clipboard managers.
4584 (Vselection_alist): Move to termhooks.h as terminal-local var.
4585 (LOCAL_SELECTION): New macro.
4586 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4587 (symbol_to_x_atom): Remove gratuitous arg.
4588 (x_handle_selection_request, lisp_data_to_selection_data)
4589 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4590 (x_own_selection, x_get_local_selection, x_convert_selection):
4591 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4592 (some_frame_on_display): Delete unused function.
4593 (Fx_own_selection_internal, Fx_get_selection_internal)
4594 (Fx_disown_selection_internal, Fx_selection_owner_p)
4595 (Fx_selection_exists_p): New optional frame arg.
4596 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4597 (x_handle_selection_clear): Don't treat other terminals with the
4598 same keyboard specially. Use the terminal-local Vselection_alist.
4599 (x_clear_frame_selections): Use Frun_hook_with_args.
4600
4601 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4602
4603 * xterm.h: Add support for those atoms.
4604
e067f0c1
CY
46052011-05-26 Chong Yidong <cyd@stupidchicken.com>
4606
4607 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4608 (converted_selections, conversion_fail_tag): New global variables.
4609 (x_selection_request_lisp_error): Free the above.
4610 (x_get_local_selection): Remove unnecessary code.
4611 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4612 of converted selections stored in converted_selections.
4613 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4614 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4615 (x_convert_selection): New function.
4616 (x_handle_selection_event): Simplify.
4617 (x_get_foreign_selection): Don't ignore incoming requests while
4618 waiting for an answer; this will fail when we implement
4619 SAVE_TARGETS, and seems unnecessary anyway.
4620 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4621 (Vx_sent_selection_functions): Doc fix.
4622
0f4aebc0
LL
46232011-05-26 Leo Liu <sdl.web@gmail.com>
4624
4625 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4626
e61124cd
YM
46272011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4628
4629 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4630
4631 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4632 for fringe update if it has periodic bitmap.
ac389d0c 4633 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4634 and fringe_bitmap_periodic_p.
4635
4636 * fringe.c (get_fringe_bitmap_data): New function.
4637 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4638 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4639 row. Mark glyph row for fringe update if periodicity changed.
4640
4641 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4642 for fringe update unless it has periodic bitmap.
4643
f16d9837
KH
46442011-05-25 Kenichi Handa <handa@m17n.org>
4645
4646 * xdisp.c (get_next_display_element): Set correct it->face_id for
4647 a static composition.
4648
e1b90ef6
LL
46492011-05-24 Leo Liu <sdl.web@gmail.com>
4650
4651 * deps.mk (fns.o):
4652 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4653
4654 * fns.c (crypto_hash_function, Fsha1): New function.
4655 (Fmd5): Use crypto_hash_function.
4656 (syms_of_fns): Add Ssha1.
4657
7400048f
PE
46582011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4659
4660 * gnutls.c: Remove unused macros.
4661 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4662 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4663 Remove macros that are defined and never used.
4664 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4665
abb71cf4
CY
46662011-05-22 Chong Yidong <cyd@stupidchicken.com>
4667
4668 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4669 (Fx_get_selection_internal): Minor cleanup.
4670 (Fx_own_selection_internal): Rename arguments for consistency with
4671 select.el.
4672
6307db39
PE
46732011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4674
4675 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4676
f3d4e0a4
CY
46772011-05-22 Chong Yidong <cyd@stupidchicken.com>
4678
4679 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4680
4d8ade89
YM
46812011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4682
4683 * dispnew.c (scrolling_window): Don't exclude the case that the
4684 last enabled row in the desired matrix touches the bottom boundary.
4685
32078c8d
GM
46862011-05-21 Glenn Morris <rgm@gnu.org>
4687
4688 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4689 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4690 and add some more files.
32078c8d 4691
7285dc67
EZ
46922011-05-20 Eli Zaretskii <eliz@gnu.org>
4693
4694 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4695 report_file_error introduced by the change from 2011-05-07.
4696
89d1bd22
PE
46972011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4698
4699 * systime.h (Time): Define only if emacs is defined.
4700 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4701 where the include path doesn't have X11/X.h by default. See
4702 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4703
e23640bb 47042011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4705
4706 * composite.c (find_automatic_composition): Fix previous change.
4707
b9704ad9
GM
47082011-05-20 Glenn Morris <rgm@gnu.org>
4709
4710 * lisp.mk: New file, split from Makefile.in.
4711 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4712 (shortlisp): Remove.
4713 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4714
4a720484
GM
47152011-05-19 Glenn Morris <rgm@gnu.org>
4716
4717 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4718 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4719 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4720 (lisp): Set the order to that of loadup.el.
4721 (shortlisp): Make it a copy of $lisp.
4722 (SOME_MACHINE_LISP): Remove.
4723 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4724 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4725
a28d4396
KH
47262011-05-18 Kenichi Handa <handa@m17n.org>
4727
4728 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4729 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4730 (find_automatic_composition): Mostly rewrite for efficiency.
4731
a2b1fa8e
JB
47322011-05-18 Juanma Barranquero <lekktu@gmail.com>
4733
4734 * makefile.w32-in: Update dependencies.
4735
8e1f5610
CS
47362011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4737
4738 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4739 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4740
7025ee00 47412011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4742
cdfa6eab
PE
4743 Fix some integer overflow issues, such as string length overflow.
4744
06d6db33
PE
4745 * insdel.c (count_size_as_multibyte): Check for string overflow.
4746
2b4560a8
PE
4747 * character.c (lisp_string_width): Check for string overflow.
4748 Use EMACS_INT, not int, for string indexes and lengths; in
4749 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4750 the resulting string length overflows an EMACS_INT; instead,
4751 report a string overflow if no precision given. When checking for
4752 precision exhaustion, use a check that cannot possibly have
4753 integer overflow. (Bug#8675)
4754 * character.h (lisp_string_width): Adjust to new signature.
4755
cb93f9be
PE
4756 * alloc.c (string_overflow): New function.
4757 (Fmake_string): Use it. This doesn't change behavior, but saves
4758 a few bytes and will simplify future changes.
4759 * character.c (string_escape_byte8): Likewise.
4760 * lisp.h (string_overflow): New decl.
4761
1a1f3366
PE
4762 Fixups, following up to the user-interface timestamp change.
4763 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4764 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4765 * msdos.c (mouse_get_pos): Likewise.
4766 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4767 * w32gui.h (Time): Define by including "systime.h" rather than by
4768 declaring it ourselves. (Bug#8664)
4769
d4e3e4d3
PE
4770 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4771 * image.c (clear_image_cache): Likewise.
4772
f6a24d19
PE
4773 * term.c (term_mouse_position): Don't assume time_t wraparound.
4774
08dc5ae6
PE
4775 Be more systematic about user-interface timestamps.
4776 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4777 and sometimes 'EMACS_UINT', to represent these timestamps.
4778 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4779 This makes the code easier to follow, and makes it easier to catch
4780 integer overflow bugs such as Bug#8664.
4781 * frame.c (Fmouse_position, Fmouse_pixel_position):
4782 Use Time, not unsigned long, for user-interface timestamps.
4783 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4784 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4785 * keyboard.h (last_event_timestamp): Likewise.
4786 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4787 * menu.h (xmenu_show): Likewise.
4788 * term.c (term_mouse_position): Likewise.
4789 * termhooks.h (struct input_event.timestamp): Likewise.
4790 (struct terminal.mouse_position_hook): Likewise.
4791 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4792 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4793 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4794 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4795 what it was before.
4796 * menu.h, termhooks.h: Include "systime.h", for Time.
4797
8e55734a
PE
4798 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4799 Don't assume that the difference between two unsigned long values
4800 can fit into an integer. At this point, we know button_down_time
4801 <= event->timestamp, so the difference must be nonnegative, so
4802 there's no need to cast the result if double-click-time is
4803 nonnegative, as it should be; check that it's nonnegative, just in
4804 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4805 apart (about 25 days). (Bug#8664)
8e55734a 4806
841f1b75 4807 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4808 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4809
3e26f69c
PE
4810 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4811 that always fit in int. Use a sentinel instead of a counter, to
4812 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4813 * frame.h (struct frame): Use int for menu_bar_items_used
4814 instead of EMACS_INT, since it always fits in int.
3e26f69c 4815
5cc152c0
PE
4816 * menu.c (grow_menu_items): Check for int overflow.
4817
d89eb65e
PE
4818 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4819
5235bd3e
PE
4820 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4821 Before, the code was not consistent. These values cannot exceed
4822 2**31 - 1 so there's no need to make them unsigned.
4823 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4824 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4825 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4826 as modifiers.
4827 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4828
bc827e23
PE
4829 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4830 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4831 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4832 presumably because the widths might not match.
4833
78eb494e
PE
4834 * window.c (size_window): Avoid needless test at loop start.
4835
04f2d78b
CB
48362011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4837
4838 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4839
d2fc7e3d 48402011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4841
4842 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4843
d2fc7e3d 48442011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4845
4846 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4847 `width' to `bar_area_x' and `bar_area_width', respectively.
4848 (x_scroll_run): Take account of fringe background extension.
4849
04f2d78b
CB
4850 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4851 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4852 `bar_area_width', respectively.
4853 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4854 background extension.
4855
79b70037
GM
48562011-05-10 Jim Meyering <meyering@redhat.com>
4857
4858 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4859
2f142cc5
JB
48602011-05-10 Juanma Barranquero <lekktu@gmail.com>
4861
4862 * image.c (Finit_image_library): Return t for built-in image types,
4863 like pbm and xbm. (Bug#8640)
4864
57679c86
AS
48652011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4866
4867 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4868
888c9e86
EZ
48692011-05-07 Eli Zaretskii <eliz@gnu.org>
4870
b0512a1d
EZ
4871 * w32console.c (Fset_screen_color): Doc fix.
4872 (Fget_screen_color): New function.
4873 (syms_of_ntterm): Defsubr it.
4874
7285dc67
EZ
4875 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4876 unlink the temporary file if Fcall_process didn't create it in the
4877 first place.
4878 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4879 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4880 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4881 cue to call_process_cleanup not to close that handle.
4882
4d3fcc8e
BK
48832011-05-07 Ben Key <bkey76@gmail.com>
4884
4885 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4886 one of two shell specific rules, either bootstrap-temacs-CMD or
4887 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4888 to the previous implementation of the bootstrap-temacs rule.
4889 The bootstrap-temacs-CMD rule is similar to the previous
4890 implementation of the bootstrap-temacs rule except that it
4891 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4892 variable.
4893
4894 These changes, along with some changes to nt/configure.bat,
4895 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4896 earlier fix to add support for --cflags and --ldflags options
4897 that include quotes so that it works whether make uses cmd or
4898 sh as the shell.
4899
b4289b64
MA
49002011-05-06 Michael Albinus <michael.albinus@gmx.de>
4901
4902 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4903 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4904 is a constant.
4905 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4906 a string. Handle both cases.
4907 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4908 (Fdbus_register_method): Use Qinvalid_function.
4909
af4c0e28
JB
49102011-05-06 Juanma Barranquero <lekktu@gmail.com>
4911
4912 * makefile.w32-in: Update dependencies.
4913 (LISP_H): Add inttypes.h and stdin.h.
4914 (PROCESS_H): Add unistd.h.
4915
c51453d9
EZ
49162011-05-06 Eli Zaretskii <eliz@gnu.org>
4917
4918 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4919 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4920
8ff0ac3c 49212011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4922
4c4b566b
PE
4923 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4924
aab2b9b5
PE
4925 * term.c (vfatal): Remove stray call to va_end.
4926 It's not needed and the C Standard doesn't allow it here anyway.
4927
c378da0b
PE
4928 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4929 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4930
288b08c7
PE
4931 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4932 bytes.
4933
e3601888
PE
4934 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4935
db6c0e74
PE
4936 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4937
dd5963ea
PE
4938 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4939
88c9450f
PE
4940 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4941
2f9442b8
PE
4942 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4943
c032b5f8
PE
4944 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4945 * charset.c (Fdefine_charset_internal): Don't initialize
4946 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4947 32-bit int (Bug#8600).
a108c10b
PE
4948
4949 * lread.c (read_integer): Be more consistent with string-to-number.
4950 Use string_to_number to do the actual conversion; this avoids
4951 rounding errors and fixes some other screwups. Without this fix,
4952 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4953 (digit_to_number): Move earlier, for benefit of read_integer.
4954 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4955 not a digit in any supported base. (Bug#8602)
a108c10b 4956
ad5f9eea
PE
4957 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4958
aec1708a
PE
4959 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4960 to match comment at start of function. This also removes a
4961 GCC warning about overflow in a 32+64-bit port.
4962
47be4ab5
PE
4963 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4964
371cac43
PE
4965 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4966 Reported by Stefan Monnier in
4967 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4968 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4969 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4970
d01a7826
PE
4971 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4972 (EMACS_UINTPTR): Likewise, with uintptr_t.
4973
7fd47d5c
PE
4974 * lisp.h: Prefer 64-bit EMACS_INT if available.
4975 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4976 on 32-bit hosts that have 64-bit int, so that they can access
4977 large files.
122b0c86
PE
4978 However, temporarily disable this change unless the temporary
4979 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4980
8727937b
PE
4981 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4982
8ac068ac
PE
4983 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4984 This removes an assumption that EMACS_INT and long are the same
4985 width as pointers. The assumption is true for Emacs porting targets
4986 now, but we want to make other targets possible.
4987 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4988 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4989 In the rest of the code, change types of integers that hold casted
4990 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4991 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4992 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4993 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4994 No need to cast type when ORing.
4995 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4996 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4997 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4998 assume EMACS_INT is the same width as char *.
4999 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5000 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5001 Remove no-longer-needed casts.
5002 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5003 (xg_tool_bar_help_callback, xg_make_tool_item):
5004 Use EMACS_INTPTR to hold an integer
5005 that will be cast to void *; this can avoid a GCC warning
5006 if EMACS_INT is not the same width as void *.
5007 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5008 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5009 (current_message_1, set_message_1):
5010 Use a local to convert to proper width without a cast.
5011 * xmenu.c (dialog_selection_callback): Likewise.
5012
ede49d71
PE
5013 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5014 Also, don't assume VALBITS / RAND_BITS is less than 5,
5015 and don't rely on undefined behavior when shifting a 1 left into
5016 the sign bit.
5017 * lisp.h (get_random): Change signature to match.
5018
2f30ecd0
PE
5019 * lread.c (hash_string): Use size_t, not int, for hash computation.
5020 Normally we prefer signed values; but hashing is special, because
5021 it's better to use unsigned division on hash table sizes so that
5022 the remainder is nonnegative. Also, size_t is the natural width
5023 for hashing into memory. The previous code used 'int', which doesn't
5024 retain enough info to hash well into very large tables.
5025 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5026
2a866e7b
PE
5027 * dbusbind.c: Don't possibly lose pointer info when converting.
5028 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5029 Use XPNTR rather than XHASH, so that the high-order bits of
5030 the pointer aren't lost when converting through void *.
5031
51639eac
PE
5032 * eval.c (Fautoload): Don't double-shift a pointer.
5033
92394119
PE
5034 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5035
dbdb9a7c
JB
50362011-05-06 Juanma Barranquero <lekktu@gmail.com>
5037
5038 * gnutls.c (DEF_GNUTLS_FN):
5039 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5040
db7a0b4f
AS
50412011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5042
5043 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5044 marker. (Bug#8610)
5045
f7ff1b0f 50462011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5047
5048 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5049 New version that can reserve upto 2GB of heap space.
5050
f7ff1b0f 50512011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5052
5053 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5054
639c109b
TZ
50552011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5056
5057 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5058 `gnutls_certificate_set_x509_key_file'.
5059
d2127135
JB
50602011-05-05 Juanma Barranquero <lekktu@gmail.com>
5061
5062 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5063 Update dependencies.
5064
e968f4f3
JB
50652011-05-04 Juanma Barranquero <lekktu@gmail.com>
5066
5067 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5068 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5069 Remove unused parameter `fildes'.
5070 * process.c (read_process_output, send_process): Don't pass it.
5071
84d358f0
JB
50722011-05-04 Juanma Barranquero <lekktu@gmail.com>
5073
5074 Fix previous change: the library cache is defined in w32.c.
5075 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5076 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5077
0898ca10
JB
50782011-05-04 Juanma Barranquero <lekktu@gmail.com>
5079
5080 Implement dynamic loading of GnuTLS on Windows.
5081
5082 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5083 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5084 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5085 Declare.
5086
5087 * gnutls.c (Qgnutls_dll): Define.
5088 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5089 (gnutls_*): Declare function pointers.
5090 (init_gnutls_functions): New function to initialize function pointers.
5091 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5092 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5093 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5094 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5095 (emacs_gnutls_write, emacs_gnutls_read)
5096 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5097 (Fgnutls_available_p): New function.
5098 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5099 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5100 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5101
5102 * image.c: Include w32.h.
5103 (Vimage_type_cache): Delete.
5104 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5105 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5106 (w32_delayed_load): Move to w32.c.
5107
5108 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5109
5110 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5111 (w32_delayed_load): Move from image.c. When loading a library, record
5112 its filename in the :loaded-from property of the library id.
5113 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5114 Initialize and staticpro them.
5115 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5116
5117 * process.c: Include lisp.h before w32.h, not after.
5118 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5119 instead of gnutls_record_check_pending.
5120
5121 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5122
ff4de4aa
TZ
51232011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5124
5125 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5126 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5127 as passed in.
5128
abe95abb
JD
51292011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5130
5131 * xterm.c (x_set_frame_alpha): Do not set property on anything
5132 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5133
e16e55d4
JB
51342011-05-02 Juanma Barranquero <lekktu@gmail.com>
5135
5136 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5137
bafcf6a5
JB
51382011-05-02 Juanma Barranquero <lekktu@gmail.com>
5139
5140 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5141 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5142 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5143 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5144 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5145 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5146 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5147 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5148 (Qgnutls_bootprop_callbacks_verify): Make static.
5149
e7a6747f
AS
51502011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5151
19ed11ba
AS
5152 * callproc.c: Indentation fixup.
5153
e7a6747f 5154 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5155 (wait_for_termination, interruptible_wait_for_termination):
5156 Move after wait_for_termination_1.
e7a6747f 5157
1ef14cb4
LMI
51582011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5159
5160 * sysdep.c (interruptible_wait_for_termination): New function
5161 which is like wait_for_termination, but allows keyboard
5162 interruptions.
5163
5164 * callproc.c (Fcall_process): Add (:file "file") as an option for
5165 the STDOUT buffer.
5166 (Fcall_process_region): Ditto.
5167
330d880c
EZ
51682011-04-30 Eli Zaretskii <eliz@gnu.org>
5169
8db90b73
EZ
5170 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5171 rather than `XVECTOR (FOO)->size'.
5172
330d880c
EZ
5173 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5174 inttypes.h, as a gnulib replacement is used if it not available in
5175 system headers.
5176
15cbd324
EZ
51772011-04-21 Eli Zaretskii <eliz@gnu.org>
5178
5179 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5180 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5181 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5182
5183 * coding.c (coding_alloc_by_realloc): Error out if destination
5184 will grow beyond MOST_POSITIVE_FIXNUM.
5185 (decode_coding_emacs_mule): Abort if there isn't enough place in
5186 charbuf for the composition carryover bytes. Reserve an extra
5187 space for up to 2 characters produced in a loop.
5188 (decode_coding_iso_2022): Abort if there isn't enough place in
5189 charbuf for the composition carryover bytes.
5190
51912011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5192
ae940cca
EZ
5193 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5194 aborting when %lld or %lll format is passed.
5195 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5196 %llo or %llx format is passed. (Bug#8545)
5197
03ab8921
EZ
5198 * window.c (window_scroll_line_based): Use a marker instead of
5199 simple variables to record original value of point. (Bug#7952)
5200
afda1437
EZ
5201 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5202 produced by %s or %c overflows available buffer space. (Bug#8545)
5203
f76dee0c
PE
52042011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5205
5206 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5207 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5208
fdc5744d
JB
52092011-04-28 Juanma Barranquero <lekktu@gmail.com>
5210
5211 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5212
638f053a
JB
52132011-04-28 Juanma Barranquero <lekktu@gmail.com>
5214
5215 * keyboard.c (Qdelayed_warnings_hook): Define.
5216 (command_loop_1): Run `delayed-warnings-hook'
5217 if Vdelayed_warnings_list is non-nil.
5218 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5219 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5220
d178f871
EZ
52212011-04-28 Eli Zaretskii <eliz@gnu.org>
5222
5223 * doprnt.c (doprnt): Don't return value smaller than the buffer
5224 size if the message was truncated. (Bug#8545).
5225
b124fd93
JB
52262011-04-28 Juanma Barranquero <lekktu@gmail.com>
5227
5228 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5229 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5230
e810457d
PE
52312011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5232
5233 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5234
ea51cceb
JB
52352011-04-27 Juanma Barranquero <lekktu@gmail.com>
5236
5237 * makefile.w32-in: Update dependencies.
5238
94dcfacf
EZ
52392011-04-27 Eli Zaretskii <eliz@gnu.org>
5240
5241 Improve `doprnt' and its usage. (Bug#8545)
5242 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5243 `format_end'. Remove support for %l as a conversion specifier.
5244 Don't use xrealloc. Improve diagnostics when the %l size modifier
5245 is used. Update the commentary.
5246
5247 * eval.c (verror): Simplify calculation of size_t.
5248
5249 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5250 messages.
5251
f61f41d7
PE
52522011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5253
5254 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5255 change.
5256
96fb4434
PE
52572011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5258
5259 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5260 This makes this file independent of the recent pseudovector change.
5261
671875da 52622011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5263
69e9b5a3
PE
5264 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5265
b5f869a7 5266 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5267 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5268 Remove unused local.
c8926152 5269 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5270
841a1577 5271 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5272 GCC 4.6.0 optimizes based on type-based alias analysis.
5273 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5274 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5275 != &v->size, and therefore "v->size = 1; b->size = 2; return
5276 v->size;" must therefore return 1. This assumption is incorrect
5277 for Emacs, since it type-puns struct Lisp_Vector * with many other
5278 types. To fix this problem, this patch adds a new type struct
f904488f 5279 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5280 and pseudovectors, and helps optimizing compilers not get fooled
5281 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5282 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5283 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5284 the size member.
eab3844f
PE
5285 (XSETPVECTYPE): Rewrite in terms of new macro.
5286 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5287 This is a bit clearer, and further avoids the possibility of
5288 undesirable aliasing.
5289 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5290 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5291 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5292 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5293 (ASIZE): Now uses header.size rather than size.
5294 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5295 to avoid the hassle of writing XVECTOR (foo)->header.size.
5296 (struct vectorlike_header): New type.
eab3844f
PE
5297 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5298 object, to help avoid aliasing.
5299 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5300 (SUBRP): Likewise, since Lisp_Subr is a special case.
5301 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5302 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5303 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5304 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5305 changed to be "header.size" and "header.next".
5306 * buffer.h (struct buffer): Likewise.
5307 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5308 * frame.h (struct frame): Likewise.
5309 * process.h (struct Lisp_Process): Likewise.
5310 * termhooks.h (struct terminal): Likewise.
5311 * window.c (struct save_window_data, struct saved_window): Likewise.
5312 * window.h (struct window): Likewise.
5313 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5314 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5315 * buffer.c (init_buffer_once): Likewise.
5316 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5317 special case.
5318 * process.c (Fformat_network_address): Use local var for size,
5319 for brevity.
5320
0df1eac5
PE
5321 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5322
847ab9d1 5323 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5324 * data.c (atof): Remove decl; no longer used or needed.
5325 (digit_to_number): Move to lread.c.
5326 (Fstring_to_number): Use new string_to_number function, to be
5327 consistent with how the Lisp reader treats infinities and NaNs.
5328 Do not assume that floating-point numbers represent EMACS_INT
5329 without losing information; this is not true on most 64-bit hosts.
5330 Avoid double-rounding errors, by insisting on integers when
5331 parsing non-base-10 numbers, as the documentation specifies.
5332 * lisp.h (string_to_number): New decl, replacing ...
5333 (isfloat_string): Remove.
bc0a5c13 5334 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5335 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5336 appears to have been a coding error. Similarly, do not accept
5337 strings like +-1e0 as floating point numbers. Do not report
5338 overflow for integer overflows unless the base is not 10 which
5339 means we have no simple and reliable way to continue.
5340 Break out the floating-point parsing into a new
5341 function string_to_number, so that Fstring_to_number parses
5342 floating point numbers consistently with the Lisp reader.
04f2d78b 5343 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5344 (E_CHAR, EXP_INT): Remove, replacing with ...
5345 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5346 (string_to_number): New function, replacing isfloat_string.
5347 This function checks for valid syntax and produces the resulting
5348 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5349 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5350 so that overflow for non-base-10 numbers is reported only when
5351 there's no portable and simple way to convert to floating point.
452f4150 5352
67769ffc
PE
5353 * textprop.c (set_text_properties_1): Rewrite for clarity,
5354 and to avoid GCC warning about integer overflow.
5355
c20db43f
PE
5356 * intervals.h (struct interval): Use EMACS_INT for members
5357 where EMACS_UINT might cause problems. See
5358 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5359 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5360 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5361 All uses changed.
37aa2f85
PE
5362 (offset_intervals): Tell GCC not to worry about length overflow
5363 when negating a negative length.
c20db43f 5364
2538aa2f
PE
5365 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5366 (overrun_check_free): Likewise.
5367
f2d3008d
PE
5368 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5369 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5370 word size.
5371
ec8df744
PE
5372 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5373 (gnutls_make_error): Rename local to avoid shadowing.
5374 (gnutls_emacs_global_deinit): ifdef out; not used.
5375 (Fgnutls_boot): Use const for pointer to readonly storage.
5376 Comment out unused local. Fix pointer signedness problems.
5377
640ee02d
PE
5378 * lread.c (openp): Don't stuff size_t into an 'int'.
5379 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5380 about possible signed overflow.
5381
6048fb2a
PE
5382 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5383 (GDK_KEY_g): Don't define if already defined.
5384 (xg_prepare_tooltip): Avoid pointer signedness problem.
5385 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5386
fa3c87e1
PE
5387 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5388 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5389
2172544b
PE
5390 * xfns.c (Fx_window_property): Simplify a bit,
5391 to make a bit faster and to avoid GCC 4.6.0 warning.
5392 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5393
9b821a21
PE
5394 * fns.c (internal_equal): Don't assume size_t fits in int.
5395
3c616cfa
PE
5396 * alloc.c (compact_small_strings): Tighten assertion a little.
5397
c2982e87
PE
5398 Replace pEd with more-general pI, and fix some printf arg casts.
5399 * lisp.h (pI): New macro, generalizing old pEd macro to other
5400 conversion specifiers. For example, use "...%"pI"d..." rather
5401 than "...%"pEd"...".
5402 (pEd): Remove. All uses replaced with similar uses of pI.
5403 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5404 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5405 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5406 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5407 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5408 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5409 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5410 64-bit hosts.
5411 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5412 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5413 * print.c (safe_debug_print, print_object): Likewise.
5414 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5415 to int.
6f04d126
PE
5416 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5417 avoiding the 0 flag, which is not portable.
c2982e87
PE
5418 * process.c (Fmake_network_process): Use pI to avoid cast.
5419 * region-cache.c (pp_cache): Likewise.
5420 * xdisp.c (decode_mode_spec): Likewise.
5421 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5422 behavior on 64-bit hosts with printf arg.
6f04d126 5423 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5424 (x_stop_queuing_selection_requests): Likewise.
5425 (x_get_window_property): Don't truncate byte count to an 'int'
5426 when tracing.
0b432f21 5427
5e073ec7
PE
5428 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5429 here, since it parses constructs like leading '-' and spaces,
5430 which are not wanted; and it overflows with large numbers.
5431 Instead, simply match F[0-9]+, which is what is wanted anyway.
5432
36372bf9
PE
5433 * alloc.c: Remove unportable assumptions about struct layout.
5434 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5435 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5436 (allocate_vectorlike, make_pure_vector): Use the new macros,
5437 plus offsetof, to remove unportable assumptions about struct layout.
5438 These assumptions hold on all porting targets that I know of, but
5439 they are not guaranteed, they're easy to remove, and removing them
5440 makes further changes easier.
5441
0b432f21
PE
5442 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5443 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5444 (string_overrun_cookie): Now const. Use initializers that
5445 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5446 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5447 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5448 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5449 multiple of sizeof (EMACS_INT); it need not be, if
5450 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5451 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5452
895009e1
JB
54532011-04-26 Juanma Barranquero <lekktu@gmail.com>
5454
5455 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5456
6a7a1b0b
TZ
54572011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5458
5459 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5460 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5461 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5462
841a1577 54632011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5464
5465 * lisp.h (Qdebug): List symbol.
895009e1 5466 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5467 * keyboard.c (debug-on-event): New variable.
5468 (handle_user_signal): Break into debugger when debug-on-event
5469 matches the current signal symbol.
5470
f2d3ba6f
DN
54712011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5472
5473 * alloc.c (check_sblock, check_string_bytes)
5474 (check_string_free_list): Convert to standard C.
5475
42ce4c63
TZ
54762011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5477
5478 * w32.c (emacs_gnutls_push): Fix typo.
5479
825cd63c
EZ
54802011-04-25 Eli Zaretskii <eliz@gnu.org>
5481
fb11d64d
EZ
5482 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5483 "cast to pointer from integer of different size".
5484
825cd63c
EZ
5485 Improve doprnt and its use in verror. (Bug#8545)
5486 * doprnt.c (doprnt): Document the set of format control sequences
5487 supported by the function. Use SAFE_ALLOCA instead of always
5488 using `alloca'.
5489
5490 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5491 is one byte too soon. Don't use xrealloc; instead xfree and
5492 xmalloc anew.
5493
e061a11b
TZ
54942011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5495
5496 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5497 callbacks stage.
5498
5499 * gnutls.c: Renamed global_initialized to
5500 gnutls_global_initialized. Added internals for the
5501 :verify-hostname-error, :verify-error, and :verify-flags
5502 parameters of `gnutls-boot' and documented those parameters in the
5503 docstring. Start callback support.
9173deec
JB
5504 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5505 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5506 on error. Return error code.
e061a11b
TZ
5507 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5508 (emacs_gnutls_read): Likewise.
5509 (Fgnutls_boot): Return handshake error code.
5510 (emacs_gnutls_handle_error): New function.
5511 (wsaerror_to_errno): Likewise.
5512
5513 * w32.h (emacs_gnutls_pull): Add prototype.
5514 (emacs_gnutls_push): Likewise.
5515
5516 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5517 (emacs_gnutls_push): Likewise.
5518
55192011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5520
5521 * process.c (wait_reading_process_output): Check if GnuTLS
5522 buffered some data internally if no FDs are set for TLS
5523 connections.
5524
5525 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5526 (LIBS): Link to USER_LIBS.
5527 ($(BLD)/gnutls.$(0)): New target.
5528
fa6996bc
EZ
55292011-04-24 Eli Zaretskii <eliz@gnu.org>
5530
eb35682e
EZ
5531 * xdisp.c (handle_single_display_spec): Rename the
5532 display_replaced_before_p argument into display_replaced_p, to
5533 make it consistent with the commentary. Fix typos in the
5534 commentary.
5535
e2ad650c
EZ
5536 * textprop.c (syms_of_textprop): Remove dead code.
5537 (copy_text_properties): Delete obsolete commentary about an
5538 interface that was deleted long ago. Fix typos in the description
5539 of arguments.
5540
1b2de274
EZ
5541 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5542 to changes in oldXMenu/XMenu.h from 2011-04-16.
5543 <menu_help_message, prev_menu_help_message>: Constify.
5544 (IT_menu_make_room): menu->help_text is now `const char **';
5545 adjust.
5546
5547 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5548 to changes in oldXMenu/XMenu.h from 2011-04-16.
5549 (struct XMenu): Declare `help_text' `const char **'.
5550
5551 * xfaces.c <Qunspecified>: Make extern again.
5552
5553 * syntax.c: Include sys/types.h before including regex.h, as
5554 required by Posix.
5555
762b15be
EZ
5556 * doc.c (get_doc_string): Improve the format passed to `error'.
5557
5558 * doprnt.c (doprnt): Improve commentary.
5559
5560 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5561
5562 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5563 them with etags.
5564
f1052e5d
EZ
5565 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5566 changes in globals.h immediately force recompilation.
762b15be
EZ
5567 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5568 $(CURDIR)/s/ms-w32.h.
5569 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5570
fa6996bc
EZ
5571 * character.c (Fchar_direction): Function deleted.
5572 (syms_of_character): Don't defsubr it.
5573 <char-direction-table>: Deleted.
5574
e6c3da20
EZ
55752011-04-23 Eli Zaretskii <eliz@gnu.org>
5576
5577 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5578 * doprnt.c: Include limits.h.
5579 (SIZE_MAX): New macro.
04f2d78b
CB
5580 (doprnt): Return a size_t value. 2nd arg is now size_t.
5581 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5582 Improve overflow protection. Support `l' modifier for integer
5583 conversions. Support %l conversion. Don't assume an EMACS_INT
5584 argument for integer conversions and for %c.
5585
5586 * lisp.h (doprnt): Restore prototype.
5587
5588 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5589 $(SRC)/character.h.
5590
5591 * Makefile.in (base_obj): Add back doprnt.o.
5592
5593 * deps.mk (doprnt.o): Add back prerequisites.
5594 (callint.o): Depend on character.h.
5595
5596 * eval.c (internal_lisp_condition_case): Include the handler
5597 representation in the error message.
5598 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5599 when breaking from the loop.
5600
5601 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5602
5603 * callint.c (Fcall_interactively): When displaying error message
5604 about invalid control letter, pass the character's codepoint, not
5605 a pointer to its multibyte form. Improve display of the character
5606 in octal and display also its hex code.
5607
5608 * character.c (char_string): Use %x to display the (unsigned)
5609 codepoint of an invalid character, to avoid displaying a bogus
5610 negative value.
5611
5612 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5613 `error', not SYMBOL_NAME itself.
5614
5615 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5616 character arguments to `error'.
5617
5618 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5619 to `error' in error message about FINAL_CHAR argument. Make sure
5620 FINAL_CHAR is a character, and use %c when it is passed as
5621 argument to `error'.
5622
4ffd0d6b 56232011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5624
5625 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5626
5627 * w32.c: Include <time.h>.
5628 (sys_localtime): New function.
5629
4ffd0d6b 56302011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5631
5632 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5633
4ffd0d6b 5634 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5635
4ffd0d6b 56362011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5637
4ffd0d6b
GM
5638 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5639 zombies (Bug#8467).
aac0c6e3 5640
04c56954
EZ
56412011-04-19 Eli Zaretskii <eliz@gnu.org>
5642
5643 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5644 gl_state.e_property when gl_state.object is Qt.
5645
5646 * insdel.c (make_gap_larger): Remove limitation of buffer size
5647 to <= INT_MAX.
5648
16a43933
CY
56492011-04-18 Chong Yidong <cyd@stupidchicken.com>
5650
5651 * xdisp.c (lookup_glyphless_char_display)
5652 (produce_glyphless_glyph): Handle cons cell entry in
5653 glyphless-char-display.
5654 (Vglyphless_char_display): Document it.
5655
5656 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5657 glyphless-char-display.
5658
4581706e
CY
56592011-04-17 Chong Yidong <cyd@stupidchicken.com>
5660
5661 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5662
5663 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5664
5665 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5666 definition for no-X builds.
5667
4887c6e2 56682011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5669
fd35b6f9
PE
5670 Static checks with GCC 4.6.0 and non-default toolkits.
5671
5c1ccb01
PE
5672 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5673
006c5daa
PE
5674 * process.c (keyboard_bit_set): Define only if SIGIO.
5675 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5676 (send_process): Repair possible setjmp clobbering.
5677
efc736d3
PE
5678 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5679
4e2fe2e6
PE
5680 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5681
f97334a2
PE
5682 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5683
4e75f29d
PE
5684 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5685 Define only if needed.
5686
90efadd1
PE
5687 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5688 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5689 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5690
3c647824
PE
5691 * dispextern.h (struct redisplay_interface): Rename param
5692 to avoid shadowing.
e264f262 5693 * termhooks.h (struct terminal): Likewise.
761383f4 5694 * xterm.c (xembed_send_message): Likewise.
3c647824 5695
b58c5c4a
PE
5696 * insdel.c (make_gap_smaller): Define only if
5697 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5698
cad59032
PE
5699 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5700 it.
5701
c339dc2e
PE
5702 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5703 so that we aren't warned about unused symbols.
5704
91a3e27b
PE
5705 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5706
399c71d3 5707 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5708
8ffc96f5
PE
5709 * xfns.c (x_real_positions): Mark locals as initialized.
5710
eef9bc79
PE
5711 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5712
098db9dd
PE
5713 * xterm.c: Fix problems found by static analysis with other toolkits.
5714 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5715 (x_dispatch_event): Declare static if USE_GTK, and
5716 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5717 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5718 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5719 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5720 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5721
eb18f6cc
PE
5722 * xmenu.c (menu_help_callback): Pointer type fixes.
5723 Use const pointers when pointing at readonly data. Avoid pointer
5724 signedness clashes.
5725 (FALSE): Remove unused macro.
5726 (update_frame_menubar): Remove unused decl.
5727
1fe72bf8
PE
5728 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5729
60d9e1db
PE
5730 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5731 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5732 (single_menu_item): Rename local to avoid shadowing.
5733
39261c26
PE
5734 * keyboard.c (make_lispy_event): Remove unused local var.
5735
018c5e19
PE
5736 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5737 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5738
63d2b86e
PE
5739 * bitmaps: Change bitmaps from unsigned char back to the X11
5740 compatible char. Avoid the old compiler warnings about
5741 out-of-range initializers by using, for example, '\xab' rather
5742 than 0xab.
5743
aefd87e1
PE
5744 * xgselect.c (xgselect_initialize): Check vs interface
5745 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5746
bf501fb9
PE
5747 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5748
e9829fdf
PE
5749 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5750 to read-only memory.
5751
1086c095
PE
5752 * fns.c (vector): Remove; this old hack is no longer needed.
5753
2baccd04 5754 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5755 Remove unused var.
dde42981 5756 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5757
72391843 5758 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5759
436c16df 5760 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5761 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5762 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5763
92bb796d 5764 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5765 (x_term_init): Remove local to avoid shadowing.
92bb796d 5766
764430a3 5767 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5768
5769 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5770 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5771
d1dfb56c
EZ
57722011-04-16 Eli Zaretskii <eliz@gnu.org>
5773
c4354cb4
EZ
5774 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5775
d1dfb56c
EZ
5776 Fix regex.c, syntax.c and friends for buffers > 2GB.
5777 * syntax.h (struct gl_state_s): Declare character position members
5778 EMACS_INT.
5779
5780 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5781
04f2d78b
CB
5782 * textprop.c (verify_interval_modification, interval_of):
5783 Declare arguments EMACS_INT.
d1dfb56c
EZ
5784
5785 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5786 EMACS_INT.
5787
5788 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5789
5790 * indent.c (Fvertical_motion): Local variable it_start is now
5791 EMACS_INT.
5792
5793 * regex.c (re_match, re_match_2, re_match_2_internal)
5794 (bcmp_translate, regcomp, regexec, print_double_string)
5795 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5796 (re_compile_pattern, re_exec): Declare arguments and local
5797 variables `size_t' and `ssize_t' and return values `regoff_t', as
5798 appropriate.
5799 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5800 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5801 <compile_stack_type>: `size' and `avail' are now `size_t'.
5802
5803 * regex.h <regoff_t>: Use ssize_t, not int.
5804 (re_search, re_search_2, re_match, re_match_2): Arguments that
5805 specify buffer/string position and length are now ssize_t and
5806 size_t. Return type is regoff_t.
5807
613052cd
BK
58082011-04-16 Ben Key <bkey76@gmail.com>
5809
5810 * nsfont.m: Fixed bugs in ns_get_family and
5811 ns_descriptor_to_entity that were caused by using free to
5812 deallocate memory blocks that were allocated by xmalloc (via
5813 xstrdup). This caused Emacs to crash when compiled with
5814 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5815 --enable-checking=xmallocoverrun). xfree is now used to
5816 deallocate these memory blocks.
5817
4170f62f 58182011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5819
71b41406
PE
5820 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5821
9587a89d
PE
5822 emacs_write: Accept and return EMACS_INT for sizes.
5823 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5824 et seq.
5825 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5826 Accept and return EMACS_INT.
5827 (emacs_gnutls_write): Return the number of bytes written on
5828 partial writes.
5829 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5830 (emacs_read, emacs_write): Remove check for negative size, as the
5831 Emacs source code has been audited now.
9587a89d
PE
5832 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5833 (emacs_read, emacs_write): Use it.
273a5f82
PE
5834 * process.c (send_process): Adjust to the new signatures of
5835 emacs_write and emacs_gnutls_write. Do not attempt to store
5836 a byte offset into an 'int'; it might overflow.
9587a89d 5837 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5838
3e047f51
PE
5839 * sound.c: Don't assume sizes fit in 'int'.
5840 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5841 Return EMACS_INT, not int.
3e047f51 5842 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5843 Accept EMACS_INT, not int.
5844 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5845 record read return values.
5846
cc39a9db
BK
58472011-04-15 Ben Key <bkey76@gmail.com>
5848
c9d0ec6d
JB
5849 * keyboard.c (Qundefined): Don't declare static since it is used
5850 in nsfns.m.
5851 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5852 static since they are used in nsfont.m.
cc39a9db 5853
6c60eb9f
SM
58542011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5855
5856 * process.c (Qprocessp): Don't declare static.
5857 * lisp.h (Qprocessp): Declare again.
5858
7990b61a
JB
58592011-04-15 Juanma Barranquero <lekktu@gmail.com>
5860
5861 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5862
5d4cb038
PE
58632011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5864
8bd7b830 5865 Improve C-level modularity by making more things 'static'.
cd64ea1d 5866
e3b27b31
PE
5867 Don't publish debugger-only interfaces to other modules.
5868 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5869 (verify_bytepos, count_markers): Move decls to the only modules
5870 that need them.
5871 * region-cache.h (pp_cache): Likewise.
5872 * window.h (check_all_windows): Likewise.
5873 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5874
5d4cb038
PE
5875 * sysdep.c (croak): Now static, if
5876 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5877 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5878
5879 * alloc.c (refill_memory_reserve): Now static if
5880 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5881 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5882
e87b6180
PE
5883 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5884 Define only if USE_LUCID.
5885
ac64929e
PE
5886 * xrdb.c (x_customization_string, x_rm_string): Now static.
5887
6f37259d
PE
5888 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5889 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5890
1683e3ab
PE
5891 * xdisp.c (draw_row_with_mouse_face): Now static.
5892 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5893
de9c2632
PE
5894 * window.h (check_all_windows): Mark externally visible.
5895
2b96acb7
PE
5896 * window.c (window_deletion_count): Now static.
5897
5898 * undo.c: Make symbols static if they're not exported.
5899 (last_undo_buffer, last_boundary_position, pending_boundary):
5900 Now static.
5901
50436f33
PE
5902 * textprop.c (interval_insert_behind_hooks): Now static.
5903 (interval_insert_in_front_hooks): Likewise.
5904
64520e5c
PE
5905 * term.c: Make symbols static if they're not exported.
5906 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5907 (max_frame_lines, tty_set_terminal_modes):
5908 (tty_reset_terminal_modes, tty_turn_off_highlight):
5909 (get_tty_terminal): Now static.
5910 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5911 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5912 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5913 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5914 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5915
1fa53021
PE
5916 * sysdep.c: Make symbols static if they're not exported.
5917 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5918 Now static.
5919 (sigprocmask_set, full_mask): Remove; unused.
5920 (wait_debugging): Mark as visible.
5921 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5922 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5923
d4b43b22
PE
5924 * syntax.c (syntax_temp): Define only if !__GNUC__.
5925
b7c513d0
PE
5926 * sound.c (current_sound_device, current_sound): Now static.
5927
989b29ad
PE
5928 * search.c (searchbufs, searchbuf_head): Now static.
5929
13a55a78
PE
5930 * scroll.c (scroll_cost): Remove; unused.
5931 * dispextern.h (scroll_cost): Remove decl.
5932
de68a1fc
PE
5933 * region-cache.h (pp_cache): Mark as externally visible.
5934
40ccffa6
PE
5935 * process.c: Make symbols static if they're not exported.
5936 (process_tick, update_tick, create_process, chan_process):
5937 (Vprocess_alist, proc_buffered_char, datagram_access):
5938 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5939 (deactivate_process): Mark defn as static, as well as decl.
5940 * lisp.h (create_process): Remove decl.
5941 * process.h (chan_process, Vprocess_alist): Remove decls.
5942
ad64fc97
PE
5943 * print.c: Make symbols static if they're not exported.
5944 (print_depth, new_backquote_output, being_printed, print_buffer):
5945 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5946 (print_interval, print_number_index, initial_stderr_stream):
5947 Now static.
5948 * lisp.h (Fprinc): Remove decl.
5949 (debug_output_compilation_hack): Mark as externally visible.
5950
adddb265
PE
5951 * sysdep.c (croak): Move decl from here to syssignal.h.
5952 * syssignal.h (croak): Put it here, so the API can be checked when
5953 'croak' is called from dissociate_if_controlling_tty.
5954
1717ede2
PE
5955 * minibuf.c: Make symbols static if they're not exported.
5956 (minibuf_save_list, choose_minibuf_frame): Now static.
5957 * lisp.h (choose_minibuf_frame): Remove decl.
5958
fa5fb2bc
PE
5959 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5960
1e3890d1
PE
5961 * lread.c: Make symbols static if they're not exported.
5962 (read_objects, initial_obarray, oblookup_last_bucket_number):
5963 Now static.
5964 (make_symbol): Remove; unused.
5965 * lisp.h (initial_obarray, make_symbol): Remove decls.
5966
8a1414fa
PE
5967 * keyboard.c: Make symbols static if they're not exported.
5968 (single_kboard, recent_keys_index, total_keys, recent_keys):
5969 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5970 (this_single_command_key_start, echoing, last_auto_save):
5971 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5972 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5973 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5974 (Vlispy_mouse_stem, double_click_count):
5975 Now static.
5976 (force_auto_save_soon): Define only if SIGDANGER.
5977 (ignore_mouse_drag_p): Now static if
5978 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5979 (print_help): Remove; unused.
5980 (stop_character, last_timer_event): Mark as externally visible.
5981 * keyboard.h (ignore_mouse_drag_p): Declare only if
5982 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5983 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5984 * lisp.h (echoing): Remove decl.
5985 (force_auto_save_soon): Declare only if SIGDANGER.
5986 * xdisp.c (redisplay_window): Simplify code, to make it more
5987 obvious that ignore_mouse_drag_p is not accessed if !defined
5988 USE_GTK && !defined HAVE_NS.
5989
93ea6e8f
PE
5990 * intervals.c: Make symbols static if they're not exported.
5991 (merge_properties_sticky, merge_interval_right, delete_interval):
5992 Now static.
5993 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5994
77382fcc
PE
5995 * insdel.c: Make symbols static if they're not exported.
5996 However, leave prepare_to_modify_buffer alone. It's never
5997 called from outside this function, but that appears to be a bug.
5998 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5999 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6000 (adjust_after_replace_noundo): Remove; unused.
6001 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6002 (signal_before_change): Remove decls.
77382fcc 6003
9306c32e
PE
6004 * indent.c (val_compute_motion, val_vmotion): Now static.
6005
cd44d2eb
PE
6006 * image.c: Make symbols static if they're not exported.
6007 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6008 if USE_GTK.
6009 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6010 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6011
ad9a7a06
PE
6012 * fringe.c (standard_bitmaps): Now static.
6013 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6014
81626931
PE
6015 * frame.c: Make symbols static if they're not exported.
6016 (x_report_frame_params, make_terminal_frame): Now static.
6017 (get_frame_param): Now static, unless HAVE_NS.
6018 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6019 (x_get_resource_string): Remove; not used.
6020 * frame.h (make_terminal_frame, x_report_frame_params):
6021 (x_get_resource_string); Remove decls.
6022 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6023 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6024
239f9db9
PE
6025 * font.c, fontset.c: Make symbols static if they're not exported.
6026 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6027 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6028 * font.c (font_close_object): Now static.
6029 * font.h (font_close_object): Remove.
6030 * fontset.c (FONTSET_OBJLIST): Remove.
6031 (free_realized_fontset) #if-0 the body, which does nothing.
6032 (face_suitable_for_char_p): #if-0, as it's never called.
6033 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6034 * xfaces.c (face_at_string_position):
6035 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6036 since 0 is always ASCII.
6037
dfcf3579
PE
6038 * fns.c (weak_hash_tables): Now static.
6039
5045092b
PE
6040 * fileio.c: Make symbols static if they're not exported.
6041 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6042 (Vwrite_region_annotation_buffers): Now static.
6043
57a96f5c
PE
6044 * eval.c: Make symbols static if they're not exported.
6045 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6046 * lisp.h (backtrace_list): Remove decl.
6047
35f08c38
PE
6048 * emacs.c: Make symbols static if they're not exported.
6049 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6050 (fatal_error_code, fatal_error_signal_hook, standard_args):
6051 Now static.
6052 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6053 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6054 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6055 * lisp.h (fatal_error_signal_hook): Remove decl.
6056 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6057
f44bd759
PE
6058 * editfns.c: Move a (normally-unused) function to its only use.
6059 * editfns.c, lisp.h (get_operating_system_release): Remove.
6060 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6061 worth the hassle of breaking this out.
6062
b532497d
PE
6063 * xterm.c: Make symbols static if they're not exported.
6064 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6065 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6066 (x_destroy_window, x_delete_display):
6067 Now static.
6068 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6069 (x_mouse_leave): Remove; unused.
6070 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6071 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6072 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6073 Remove decls.
6074 (x_mouse_leave): Declare only if WINDOWSNT.
6075 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6076 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6077 USE_X_TOOLKIT.
6078
1675728f
PE
6079 * ftxfont.c: Make symbols static if they're not exported.
6080 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6081 HAVE_FREETYPE.
6082 * font.h (ftxfont_driver): Likewise.
6083
e4cebfca
PE
6084 * xfns.c: Make symbols static if they're not exported.
6085 (x_last_font_name, x_display_info_for_name):
6086 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6087 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6088 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6089 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6090 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6091 (last_show_tip_args): Now static.
6092 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6093 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6094 (x_screen_planes): Remove; unused.
6095 * dispextern.h (x_screen_planes): Remove decl.
6096
5bf46f05
PE
6097 * dispnew.c: Make symbols static if they're not exported.
6098 * dispextern.h (redraw_garbaged_frames, scrolling):
6099 (increment_row_positions): Remove.
6100 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6101 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6102 Now static.
6103 (redraw_garbaged_frames): Remove; unused.
6104
435f4c28
PE
6105 * xfaces.c: Make symbols static if they're not exported.
6106 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6107 Remove decls.
6108 * xterm.h (defined_color): Remove decls.
6109 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6110 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6111 (menu_face_changed_default, defined_color, free_realized_face):
6112 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6113 (ascii_face_of_lisp_face): Remove; unused.
6114
8524aef3
PE
6115 * xdisp.c: Make symbols static if they're not exported.
6116 * dispextern.h (scratch_glyph_row, window_box_edges):
6117 (glyph_to_pixel_coords, set_cursor_from_row):
6118 (get_next_display_element, set_iterator_to_next):
6119 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6120 (show_mouse_face): Remove decls
6121 * frame.h (message_buf_print): Likewise.
6122 * lisp.h (pop_message, set_message, check_point_in_composition):
6123 Likewise.
6124 * xterm.h (set_vertical_scroll_bar): Likewise.
6125 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6126 (message_buf_print, scratch_glyph_row, displayed_buffer):
6127 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6128 (get_next_display_element, show_mouse_face, window_box_edges):
6129 (frame_to_window_pixel_xy, check_point_in_composition):
6130 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6131 (glyph_to_pixel_coords): Remove; unused.
6132
16390cd2
PE
6133 * dired.c (file_name_completion): Now static.
6134
6135 * dbusbind.c (xd_in_read_queued_messages): Now static.
6136
a25f4dfa
PE
6137 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6138 * data.c (circular_list_error): Remove.
6139
14a9c8df
PE
6140 * commands.h (last_point_position, last_point_position_buffer):
6141 (last_point_position_window): Remove decls.
6142 * keyboard.c: Make these variables static.
6143
04f2d78b
CB
6144 * coding.h (coding, code_convert_region, encode_coding_gap):
6145 Remove decls.
74ab6df5
PE
6146 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6147 (iso_code_class, detect_coding, code_convert_region): Now static.
6148 (encode_coding_gap): Remove; unused.
6149
38dfbee1
PE
6150 * chartab.c (chartab_chars, chartab_bits): Now static.
6151
a2cb4e63
PE
6152 * charset.h (charset_iso_8859_1): Remove decl.
6153 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6154 Now static.
6155
127198fd
PE
6156 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6157 * ccl.c (Vccl_program_table): Now static.
6158 (check_ccl_update): Remove; unused.
6159
d85b608f
PE
6160 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6161 * category.h: ... from here.
6162 * category.c (check_category_table, set_category_set): Now static.
6163
31cd66f3
PE
6164 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6165 * lisp.h: Remove these decls.
6166
c358e587
PE
6167 * buffer.c (buffer_count): Remove unused var.
6168
e78aecca
PE
6169 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6170 so that it's not optimized away.
6171 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6172 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6173 exported only to the debugger.
6174
e192d7d3 6175 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6176 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6177
92470028
PE
6178 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6179 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6180 was inaccessible from Lisp.
6181 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6182 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6183
244ed907
PE
6184 alloc.c: Import and export fewer symbols, and remove unused items.
6185 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6186 is defined.
6187 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6188 it's not optimized away by whole-program optimization.
6189 (message_enable_multibyte, free_misc): Remove.
6190 (catchlist, handlerlist, mark_backtrace):
6191 Declare only if BYTE_MARK_STACK.
6192 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6193 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6194 (message_enable_multibyte): Remove decl.
6195 (free_misc, interval_free_list, float_block, float_block_index):
6196 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6197 (cons_free_list, last_marked_index):
6198 Now static.
6199 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6200 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6201 (mark_backtrace): Define only if BYTE_MARK_STACK.
6202 * xdisp.c (message_enable_multibyte): Now static.
6203
61c2b50e 6204 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6205 This makes it easier for human readers (and static analyzers)
6206 to see whether these variables are used from other modules.
6207 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6208 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6209 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6210 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6211 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6212 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6213 * xmenu.c, xselect.c:
6214 Declare Q* vars static if they are not used in other modules.
6215 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6216 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6217 Remove decls of unexported vars.
6218 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6219
95c82688
PE
6220 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6221
16a97296
PE
6222 Make Emacs functions such as Fatom 'static' by default.
6223 This makes it easier for human readers (and static analyzers)
6224 to see whether these functions can be called from other modules.
6225 DEFUN now defines a static function. To make the function external
6226 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6227 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6228 (Finit_image_library):
16a97296
PE
6229 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6230 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6231 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6232 Remove decls, since these functions are now static.
6233 (Funintern, Fget_internal_run_time): New decls, since these functions
6234 were already external.
95c82688 6235
16a97296
PE
6236 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6237 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6238 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6239 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6240 * keyboard.c, keymap.c, lread.c:
6241 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6242 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6243 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6244 Mark functions with DEFUE instead of DEFUN,
6245 if they are used in other modules.
6246 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6247 decls for now-static functions.
6248 * buffer.h (Fdelete_overlay): Remove decl.
6249 * callproc.c (Fgetenv_internal): Mark as internal.
6250 * composite.c (Fremove_list_of_text_properties): Remove decl.
6251 (Fcomposition_get_gstring): New forward static decl.
6252 * composite.h (Fcomposite_get_gstring): Remove decl.
6253 * dired.c (Ffile_attributes): New forward static decl.
6254 * doc.c (Fdocumntation_property): New forward static decl.
6255 * eval.c (Ffetch_bytecode): New forward static decl.
6256 (Funintern): Remove extern decl; now in .h file where it belongs.
6257 * fileio.c (Fmake_symbolic_link): New forward static decl.
6258 * image.c (Finit_image_library): New forward static decl.
6259 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6260 * intervals.h (Fprevious_property_change):
6261 (Fremove_list_of_text_properties): Remove decls.
6262 * keyboard.c (Fthis_command_keys): Remove decl.
6263 (Fcommand_execute): New forward static decl.
6264 * keymap.c (Flookup_key): New forward static decl.
6265 (Fcopy_keymap): Now static.
6266 * keymap.h (Flookup_key): Remove decl.
6267 * process.c (Fget_process): New forward static decl.
6268 (Fprocess_datagram_address): Mark as internal.
6269 * syntax.c (Fsyntax_table_p): New forward static decl.
6270 (skip_chars): Remove duplicate decl.
6271 * textprop.c (Fprevious_property_change): New forward static decl.
6272 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6273 Now internal.
6274 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6275 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6276
785bbd42
PE
6277 * editfns.c (Fformat): Remove unreachable code.
6278
8b913b57
AS
62792011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6280
6281 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6282 change. (Bug#8496)
6283
a6744a35
EZ
62842011-04-13 Eli Zaretskii <eliz@gnu.org>
6285
6286 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6287 when at ZV. (Bug#8487)
6288
e7974947
AS
62892011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6290
baad03f0
AS
6291 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6292 (Bug#8437)
6293 * keyboard.c (parse_tool_bar_item): Likewise.
6294 * sound.c (sound_cleanup, alsa_close): Likewise.
6295 * termcap.c (tgetent): Likewise.
6296 * xfns.c (x_default_font_parameter): Likewise.
6297 * xsettings.c (read_and_apply_settings): Likewise.
6298
e7974947
AS
6299 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6300 (overrun_check_free): Protoize.
6301
28272684
PE
63022011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6303
6304 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6305 since callers should never pass a negative size.
6306 Change the signature to match that of plain 'read' and 'write'; see
6307 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6308 * lisp.h: Update prototypes of emacs_write and emacs_read.
6309
11997c76
EZ
63102011-04-11 Eli Zaretskii <eliz@gnu.org>
6311
6312 * xdisp.c (redisplay_window): Don't try to determine the character
6313 position of the scroll margin if the window start point w->startp
e896f03c 6314 is outside the buffer's accessible region. (Bug#8468)
11997c76 6315
8a2cbd72
EZ
63162011-04-10 Eli Zaretskii <eliz@gnu.org>
6317
6318 Fix write-region and its subroutines for buffers > 2GB.
6319 * fileio.c (a_write, e_write): Modify declaration of arguments and
6320 local variables to support buffers larger than 2GB.
6321 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6322
6323 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6324 argument, local variables, and return value.
6325
6326 * lisp.h: Update prototypes of emacs_write and emacs_read.
6327
6328 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6329
4073e537 63302011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6331
1ebfdcb6
PE
6332 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6333
b2ded58d
PE
6334 Fix more problems found by GCC 4.6.0's static checks.
6335
7d66342c
PE
6336 * xdisp.c (vmessage): Use a better test for character truncation.
6337
bbf47d44
PE
6338 * charset.c (load_charset_map): <, not <=, for optimization,
6339 and to avoid potential problems with integer overflow.
9248994d 6340 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6341 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6342 * editfns.c (Fformat): Likewise.
1e69125e 6343 * syntax.c (skip_chars): Likewise.
3befa583 6344
e3019616
PE
6345 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6346 This also lets GCC 4.6.0 generate slightly better loop code.
6347
becfa255
PE
6348 * callint.c (Fcall_interactively): <, not <=, for optimization.
6349 (Fcall_interactively): Count the number of arguments produced,
6350 not the number of arguments given. This is simpler and lets GCC
6351 4.6.0 generate slightly better code.
6352
dae0cd48
PE
6353 * ftfont.c: Distingish more carefully between FcChar8 and char.
6354 The previous code passed unsigned char * to a functions like
6355 strlen and xstrcasecmp that expect char *, which does not
6356 conform to the C standard.
6357 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6358 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6359 char * when the C standard requires it.
6360
76032d70
PE
6361 * keyboard.c (read_char): Remove unused var.
6362
eb3f1cc8
PE
6363 * eval.c: Port to Windows vsnprintf (Bug#8435).
6364 Include <limits.h>.
6365 (SIZE_MAX): Define if the headers do not.
6366 (verror): Do not give up if vsnprintf returns a negative count.
6367 Instead, grow the buffer. This ports to Windows vsnprintf, which
6368 does not conform to C99. Problem reported by Eli Zaretskii.
6369 Also, simplify the allocation scheme, by avoiding the need for
6370 calling realloc, and removing the ALLOCATED variable.
6371
70476b54
PE
6372 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6373
12020a9e
PE
6374 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6375 But keep the doprint source code for now, as we might revamp it
6376 and use it again (Bug#8435).
ea6c7ae6
PE
6377 * lisp.h (doprnt): Remove.
6378 * Makefile.in (base_obj): Remove doprnt.o.
6379 * deps.mk (doprnt.o): Remove.
6380
5fdb398c
PE
6381 error: Print 32- and 64-bit integers portably (Bug#8435).
6382 Without this change, on typical 64-bit hosts error ("...%d...", N)
6383 was used to print both 32- and 64-bit integers N, which relied on
6384 undefined behavior.
6385 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6386 New macro.
6387 * lisp.h (error, verror): Mark as printf-like functions.
6388 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6389 Report overflow in size calculations when allocating printf buffer.
6390 Do not truncate output string at its first null byte.
6391 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6392 Truncate the output at a character boundary, since vsnprintf does not
6393 do that.
6394 * charset.c (check_iso_charset_parameter): Convert internal
6395 character to string before calling 'error', since %c now has the
6396 printf meaning.
6397 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6398 overflow when computing char to be passed to 'error'. Do not
6399 pass Lisp_Object to 'error'; pass the integer instead.
6400 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6401 formatted with plain %d.
6402
b189fa66
PE
6403 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6404
bff87ef0
PE
6405 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6406
7e2cac20
PE
6407 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6408
ce4d90b5
PE
6409 * xterm.c (x_catch_errors): Remove duplicate declaration.
6410
266c9547
PE
6411 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6412
79c49ad2
PE
6413 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6414
368f4090
JM
64152011-04-10 Jim Meyering <meyering@redhat.com>
6416
6417 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6418 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6419 return ssize_t not "int", and use size_t as the buffer length.
6420 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6421 * gnutls.h: Update declarations.
6422 * process.c (read_process_output): Use ssize_t, to match.
6423 (send_process): Likewise.
6424
a32d4040
CY
64252011-04-09 Chong Yidong <cyd@stupidchicken.com>
6426
6427 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6428
8546720e 64292011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6430
04f2d78b
CB
6431 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6432 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6433
8546720e
GM
6434 * xterm.c (handle_one_xevent):
6435 * xmenu.c (create_and_show_popup_menu):
6436 * xselect.c (x_decline_selection_request)
6437 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6438
0a2f5c1a 64392011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6440
6441 Fix some uses of `int' instead of EMACS_INT.
6442 * search.c (string_match_1, fast_string_match)
6443 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6444 (scan_buffer, find_next_newline_no_quit)
6445 (find_before_next_newline, search_command, Freplace_match)
6446 (Fmatch_data): Make some `int' variables be EMACS_INT.
6447
6448 * xdisp.c (display_count_lines): 3rd argument and return value now
6449 EMACS_INT. All callers changed.
6450 (pint2hrstr): Last argument is now EMACS_INT.
6451
6452 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6453 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6454 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6455 (decode_coding_utf_16, decode_coding_emacs_mule)
6456 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6457 (decode_coding_ccl, decode_coding_charset)
6458 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6459 (decode_coding_iso_2022, decode_coding_emacs_mule)
6460 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6461 <char_offset, last_offset>: Declare EMACS_INT.
6462 (encode_coding_utf_8, encode_coding_utf_16)
6463 (encode_coding_emacs_mule, encode_invocation_designation)
6464 (encode_designation_at_bol, encode_coding_iso_2022)
6465 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6466 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6467 Declare EMACS_INT.
6468 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6469 (encode_invocation_designation): Last argument P_NCHARS is now
6470 EMACS_INT.
6471 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6472 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6473
6474 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6475 All users changed.
6476
6477 * ccl.c (Fccl_execute_on_string): Declare some variables
6478 EMACS_INT.
6479
8546720e 64802011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6481
6482 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6483
4e19a977
CS
64842011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6485
6486 * process.c (Fformat_network_address): Doc fix.
6487
87302331
R
64882011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6489
6490 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6491
cbb59342
CY
64922011-04-08 Chong Yidong <cyd@stupidchicken.com>
6493
6494 * keyboard.c (read_char): Call Lisp function help-form-show,
6495 instead of using internal_with_output_to_temp_buffer.
6496 (Qhelp_form_show): New var.
e0d38eeb 6497 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6498
6499 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6500
6501 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6502
e67a13ab
CY
65032011-04-06 Chong Yidong <cyd@stupidchicken.com>
6504
04f2d78b
CB
6505 * process.c (Flist_processes): Remove to Lisp.
6506 (list_processes_1): Delete.
e67a13ab 6507
973f782d
EZ
65082011-04-06 Eli Zaretskii <eliz@gnu.org>
6509
7c106b1e
EZ
6510 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6511
973f782d
EZ
6512 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6513
41cf7d1a 65142011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6515
ca23cc88
PE
6516 Fix more problems found by GCC 4.6.0's static checks.
6517
f390e2d5
PE
6518 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6519
42eea0d0
PE
6520 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6521
b69769da 6522 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6523
f9541e84
PE
6524 * xdisp.c (vmessage): Mark as a printf-like function.
6525
13841b55
PE
6526 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6527
c136c10f
PE
6528 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6529
5e2d4a30
PE
6530 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6531 printf-like functions.
6532 (tiff_load): Add casts to remove these marks before passing them
6533 to system-supplied API.
6534
583f48b9
PE
6535 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6536
b25d760e
PE
6537 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6538 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6539 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6540 directly, rather than having caller test rule sign. This avoids
6541 some unnecessary tests.
6542 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6543 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6544 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6545
bc7b6697 6546 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6547 (xfont_open): Avoid unnecessary tests.
bc7b6697 6548
27ccc379
PE
6549 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6550
dcd5c89a
PE
6551 * composite.h, composite.c (composition_gstring_put_cache):
6552 Use EMACS_INT, not int, for length.
6553
b13a45c6
PE
6554 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6555 breaking out part of COMPOSITION_DECODE_RULE.
6556 (COMPOSITION_DECODE_RULE): Use it.
6557 * composite.c (get_composition_id): Remove unused local vars,
6558 by using the new macro.
6559
1e792e4d
PE
6560 * textprop.c (set_text_properties_1): Change while to do-while,
6561 since the condition is always true at first.
6562
dc6c6455 6563 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6564 (interval_deletion_adjustment): Return unsigned value.
6565 All uses changed.
dc6c6455 6566
aba7731a
PE
6567 * process.c (list_processes_1, create_pty, read_process_output):
6568 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6569 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6570 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6571 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6572 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6573
fdfc4bf3
PE
6574 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6575
fca8fe46 6576 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6577 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6578
06a0259a 6579 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6580 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6581 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6582
e7b9e80f
PE
6583 * print.c (print_error_message): Avoid int overflow.
6584
56201685
PE
6585 * font.c (font_list_entities): Redo for clarity,
6586 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6587
78834453 6588 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6589 (font_score): Avoid potential overflow in diff calculation.
78834453 6590
0bc0b309 6591 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6592 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6593
e610eaca
PE
6594 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6595
b895abce
PE
6596 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6597 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6598 can always succeed if overflow has undefined behavior.
6599
1f1d9321 6600 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6601 (wordify): Omit three unnecessary tests.
1f1d9321 6602
c59478bc
PE
6603 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6604 All callers changed. This avoids the need for an unused var.
6605
79b73827
PE
6606 * casefiddle.c (casify_region): Remove var that is set but not used.
6607
a4db5dfe
PE
6608 * dired.c (file_name_completion): Remove var that is set but not used.
6609
43aae36e
PE
6610 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6611
2a47c44d 6612 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6613 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6614
a37c69bf
PE
6615 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6616 Check for integer overflow on size calculations.
6617
328ab8e7
PE
6618 * buffer.c (Fprevious_overlay_change): Remove var that is set
6619 but not used.
6620
e5a2a5cb
PE
6621 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6622 Remove vars that are set but not used.
8d84a6eb 6623 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6624 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6625
a60e5f68
PE
6626 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6627
f661cb61 6628 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6629 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6630
f0397f5a
PE
6631 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6632 that are set but not used.
6633
8664db06 6634 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6635 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6636
6abdaa4a
PE
6637 * xselect.c (x_get_local_selection, x_handle_property_notify):
6638 Remove vars that are set but not used.
6639
0ce7538d 6640 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6641 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6642
9ae848fc
PE
6643 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6644 Remove var that is set but not used.
0b918413
PE
6645 (scroll_bar_windows_size): Now size_t, not int.
6646 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6647 Check for overflow.
9ae848fc 6648
a5a62657
PE
6649 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6650 (map_tty_color) [!defined MSDOS]: Likewise.
6651
5c5cdd39
PE
6652 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6653
66ebf983
PE
6654 * coding.c: Remove vars that are set but not used.
6655 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6656 All callers changed.
6657 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6658 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6659 (decode_coding_charset): Remove vars that are set but not used.
6660
1be4d761
PE
6661 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6662 that is set but not used.
6663
47553fa8
PE
6664 * print.c (print_object): Remove var that is set but not used.
6665
1f7196bf 6666 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6667 The gnulib version avoids calling malloc in the usual case,
6668 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6669 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6670 * filelock.c (current_lock_owner): Likewise.
6671 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6672 * sysdep.c: Include allocator.h, careadlinkat.h.
6673 (emacs_no_realloc_allocator): New static constant.
6674 (emacs_readlink): New function.
fdb61804
PE
6675 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6676 ../lib/careadlinkat.h.
d1fdcab7 6677
f84c17c7
SM
66782011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6679
6680 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6681 first non-nil return value).
6682
ef3862ad
JD
66832011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6684
6685 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6686 if not defined (Bug#8403).
6687
376a7006
JB
66882011-04-02 Juanma Barranquero <lekktu@gmail.com>
6689
6690 * xdisp.c (display_count_lines): Remove parameter `start',
6691 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6692 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6693 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6694 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6695 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6696 and thereabouts. All callers changed.
6697 (get_per_char_metric): Remove parameter `f', unused since
6698 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6699
6ca3801d
JM
67002011-04-02 Jim Meyering <meyering@redhat.com>
6701
6702 do not dereference NULL upon failed strdup
6703 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6704 (ns_get_family): Likewise.
6705
d8e2b5ba
JB
67062011-04-02 Juanma Barranquero <lekktu@gmail.com>
6707
6708 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6709
8c74fcbd
JD
67102011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6711
6712 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6713 later (Bug#8403).
6714
7200d79c
SM
67152011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6716
03408648 6717 Add lexical binding.
7200d79c 6718
03408648
SM
6719 * window.c (Ftemp_output_buffer_show): New fun.
6720 (Fsave_window_excursion):
6721 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6722
6723 * lread.c (lisp_file_lexically_bound_p): New function.
6724 (Fload): Bind Qlexical_binding.
6725 (readevalloop): Remove `evalfun' arg.
6726 Bind Qinternal_interpreter_environment.
6727 (Feval_buffer): Bind Qlexical_binding.
6728 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6729 Mark as dynamic.
6730 (syms_of_lread): Declare `lexical-binding'.
6731
6732 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6733
6734 * keyboard.c (eval_dyn): New fun.
6735 (menu_item_eval_property): Use it.
ca105506
SM
6736
6737 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6738
03408648
SM
6739 * fns.c (concat, mapcar1): Accept byte-code-functions.
6740
6741 * eval.c (Fsetq): Handle lexical vars.
6742 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6743 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6744 (FletX, Flet): Obey lexical binding.
6745 (Fcommandp): Handle closures.
6746 (Feval): New `lexical' arg.
6747 (eval_sub): New function extracted from Feval. Use it almost
6748 everywhere where Feval was used. Look up vars in lexical env.
6749 Handle closures.
6750 (Ffunctionp): Move from subr.el.
6751 (Ffuncall): Handle closures.
6752 (apply_lambda): Remove `eval_flags'.
6753 (funcall_lambda): Handle closures and new byte-code-functions.
6754 (Fspecial_variable_p): New function.
6755 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6756 but without exporting it to Lisp.
23aba0ea 6757
23aba0ea 6758 * doc.c (Fdocumentation, store_function_docstring):
03408648 6759 * data.c (Finteractive_form): Handle closures.
23aba0ea 6760
03408648
SM
6761 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6762 interactive spec.
ba83908c 6763
04f2d78b
CB
6764 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6765 New byte-codes.
03408648
SM
6766 (exec_byte_code): New function extracted from Fbyte_code to handle new
6767 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6768
03408648 6769 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6770
03408648 6771 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6772
e2abce01
JB
67732011-03-31 Juanma Barranquero <lekktu@gmail.com>
6774
6775 * xdisp.c (redisplay_internal): Fix prototype.
6776
63696a73 67772011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6778
63696a73 6779 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6780 (try_scrolling): Use it when setting scroll_limit.
6781 Limit scrolling to 100 screen lines.
63696a73
EZ
6782 (redisplay_window): Even when falling back on "recentering",
6783 position point in the window according to scroll-conservatively,
6784 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6785
6786 (try_scrolling): When point is above the window, allow searching
6787 as far as scroll_max, or one screenful, to compute vertical
6788 distance from PT to the scroll margin position. This prevents
6789 try_scrolling from unnecessarily failing when
6790 scroll-conservatively is set to a value slightly larger than the
6791 window height. Clean up the case of PT below the margin at bottom
6792 of window: scroll_max can no longer be INT_MAX. When aggressive
6793 scrolling is in use, don't let point enter the opposite scroll
6794 margin as result of the scroll.
6795 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6796 threshold of 100 lines for never-recentering scrolling.
6797
e4cc2dfc
JB
67982011-03-31 Juanma Barranquero <lekktu@gmail.com>
6799
6800 * dispextern.h (move_it_by_lines):
6801 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6802 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6803 (message_log_check_duplicate): Remove parameters `prev_bol' and
6804 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6805 (redisplay_internal): Remove parameter `preserve_echo_area',
6806 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6807
6808 * indent.c (Fvertical_motion):
6809 * window.c (window_scroll_pixel_based, Frecenter):
6810 Don't pass `need_y_p' to `move_it_by_lines'.
6811
1c470562
SM
68122011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6813
44f230aa
SM
6814 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6815 steal a few bits to be more compact.
6816 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6817 Remove unneeded casts.
6818
1c470562
SM
6819 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6820
888adce9
ZK
68212011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6822
6823 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6824 binding" message (bug#7967).
6825
f838ed7b
PE
68262011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6827
77861b95
PE
6828 Fix more problems found by GCC 4.6.0's static checks.
6829
de6dbc14
PE
6830 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6831 Remove unused local var.
6832
f838ed7b
PE
6833 * editfns.c (Fmessage_box): Remove unused local var.
6834
792c7b2b
PE
6835 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6836 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6837 Omit unused local vars.
c499e557 6838 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6839 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6840 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6841 Omit unused local var.
6842
ba0165e1
PE
6843 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6844 Don't assume string length fits in int.
32ad8845 6845 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6846 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6847
3c59b4c9
PE
6848 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6849 instead of alloca (Bug#8344).
6850
a3eed478 6851 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6852 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6853
eb4d412d
PE
6854 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6855
1658b401
PE
6856 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6857 concerns.
6858
6859 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6860
6861 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6862
9a2c6e05
PE
6863 * keyboard.c (syms_of_keyboard): Use the same style as later
6864 in this function when indexing through an array. This also
6865 works around GCC bug 48267.
6866
03d0a109
PE
6867 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6868
44f730c8
PE
6869 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6870
fe75f926
PE
6871 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6872 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6873
ffa8c828
PE
6874 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6875 This avoids undefined behavior on integer overflow, and is a bit
6876 more convenient anyway since it is compared to a size_t variable.
6877
c5101a77
PE
6878 Variadic C functions now count arguments with size_t, not int.
6879 This avoids an unnecessary limitation on 64-bit machines, which
6880 caused (substring ...) to crash on large vectors (Bug#8344).
6881 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6882 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6883 All variadic functions and their callers changed accordingly.
c5101a77
PE
6884 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6885 * data.c (arith_driver, float_arith_driver): Likewise.
6886 * editfns.c (general_insert_function): Likewise.
6887 * eval.c (struct backtrace.nargs, interactive_p)
6888 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6889 (funcall_lambda, mark_backtrace): Likewise.
6890 * fns.c (concat): Likewise.
6891 * frame.c (x_set_frame_parameters): Likewise.
6892 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6893 0 if not found, not -1. All callers changed.
6894
dd3f25f7
PE
6895 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6896 (stack_copy_size): Now size_t, not int.
6897 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6898
461c2ab9
JB
68992011-03-28 Juanma Barranquero <lekktu@gmail.com>
6900
6901 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6902 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6903 All callers changed.
6904
6905 * lisp.h (multibyte_char_to_unibyte):
6906 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6907 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6908 * character.h (CHAR_TO_BYTE8):
6909 * cmds.c (internal_self_insert):
6910 * editfns.c (general_insert_function):
6911 * keymap.c (push_key_description):
6912 * search.c (Freplace_match):
6913 * xdisp.c (message_dolog, set_message_1): All callers changed.
6914
f6d62986
SM
69152011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6916
6917 * keyboard.c (safe_run_hook_funcall): New function.
6918 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6919 don't set the hook to nil, but remove the offending function instead.
6920 (Qcommand_hook_internal): Remove, unused.
6921 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6922 Vcommand_hook_internal.
6923
6924 * eval.c (enum run_hooks_condition): Remove.
6925 (funcall_nil, funcall_not): New functions.
6926 (run_hook_with_args): Call each function through a `funcall' argument.
6927 Remove `cond' argument, now redundant.
6928 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6929 (Frun_hook_with_args_until_failure): Adjust accordingly.
6930 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6931
1db5b1ad
JB
69322011-03-28 Juanma Barranquero <lekktu@gmail.com>
6933
6934 * dispextern.h (string_buffer_position): Remove declaration.
6935
6936 * print.c (strout): Remove parameter `multibyte', unused since
6937 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6938
6939 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6940 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6941 All callers changed.
6942
6943 * w32.c (_wsa_errlist): Use braces for struct initializers.
6944
6945 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6946 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6947 All callers changed.
6948 (string_buffer_position): Likewise. Also, make static (it's never
6949 used outside xdisp.c).
6950 (cursor_row_p): Remove parameter `w', unused since
6951 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6952 (decode_mode_spec): Remove parameter `precision', introduced during
6953 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6954 All callers changed.
6955
5ffb62aa
JD
69562011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6957
6958 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6959
461c2ab9 69602011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6961
6962 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6963 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6964 (ns_update_auto_hide_menu_bar): New functions.
6965 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6966 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6967 ns_constrain_all_frames.
6968 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6969 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6970
5c380ffb
JD
69712011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6972
6973 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6974
9af30bdf
GM
69752011-03-27 Glenn Morris <rgm@gnu.org>
6976
6977 * syssignal.h: Replace RETSIGTYPE with void.
6978 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6979 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6980 Replace SIGTYPE with void everywhere.
6981 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6982 * s/template.h (SIGTYPE): Remove commented out definition.
6983
e2abce01
JB
69842011-03-26 Eli Zaretskii <eliz@gnu.org>
6985
6986 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6987 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6988
f868cd8a
JB
69892011-03-26 Juanma Barranquero <lekktu@gmail.com>
6990
59eb0929
JB
6991 * w32.c (read_unc_volume): Use parameter `henum', instead of
6992 global variable `wget_enum_handle'.
6993
6994 * keymap.c (describe_vector): Remove parameters `indices' and
6995 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6996 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6997
f868cd8a
JB
6998 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6999
7000 * keyboard.c (timer_check): Remove parameter `do_it_now',
7001 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7002 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7003 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7004
7005 * keyboard.c (read_char):
7006 * w32menu.c (w32_menu_display_help):
7007 * xmenu.c (show_help_event, menu_help_callback):
7008 Adjust calls to `show_help_echo'.
7009
7010 * gtkutil.c (xg_maybe_add_timer):
7011 * keyboard.c (readable_events):
7012 * process.c (wait_reading_process_output):
7013 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7014
7015 * insdel.c (adjust_markers_gap_motion):
7016 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7017 (gap_left, gap_right): Don't call it.
7018
2ecf6fdb
CY
70192011-03-25 Chong Yidong <cyd@stupidchicken.com>
7020
7021 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7022 incurred during fontification.
7023
6b1f9ba4
JB
70242011-03-25 Juanma Barranquero <lekktu@gmail.com>
7025
7026 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7027 (DEFVAR_PER_BUFFER): Don't pass it.
7028
7029 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7030 (scrolling_window): Don't pass it.
7031
0f4a96b5
JB
70322011-03-25 Juanma Barranquero <lekktu@gmail.com>
7033
7034 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7035
7036 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7037 and `suffix'.
7038 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7039 of variables specific to SELinux and computation of `encoded_absname'.
7040
7041 * image.c (XPutPixel): Remove unused variable `height'.
7042
7043 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7044
7045 * unexw32.c (get_section_info): Remove unused variable `section'.
7046
7047 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7048 (system_process_attributes): Remove unused variable `sess'.
7049 (sys_read): Remove unused variable `err'.
7050
7051 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7052 (w32_wnd_proc): Remove unused variable `isdead'.
7053 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7054 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7055 (x_create_tip_frame): Remove unused variable `tem'.
7056
7057 * w32inevt.c (w32_console_read_socket):
7058 Remove unused variable `no_events'.
7059
7060 * w32term.c (x_draw_composite_glyph_string_foreground):
7061 Remove unused variable `width'.
7062
1149507c
JB
70632011-03-24 Juanma Barranquero <lekktu@gmail.com>
7064
7065 * w32term.c (x_set_glyph_string_clipping):
7066 Don't pass uninitialized region to CombineRgn.
7067
9c88f339
JB
70682011-03-23 Juanma Barranquero <lekktu@gmail.com>
7069
7070 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7071 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7072 (Fx_close_connection): Remove unused variable `i'.
7073
7074 * w32font.c (w32font_draw): Return number of glyphs.
7075 (w32font_open_internal): Remove unused variable `i'.
7076 (w32font_driver): Add missing initializer.
7077
7078 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7079 (fill_in_menu): Remove unused variable `items_added'.
7080
7081 * w32term.c (last_mouse_press_frame): Remove static global variable.
7082 (w32_clip_to_row): Remove unused variable `f'.
7083 (x_delete_terminal): Remove unused variable `i'.
7084
7085 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7086 (NOTHING): Remove unused static global variable.
7087 (uniscribe_check_otf): Remove unused variable `table'.
7088 (uniscribe_font_driver): Add missing initializers.
7089
dee091a3
JD
70902011-03-23 Julien Danjou <julien@danjou.info>
7091
7092 * term.c (Fsuspend_tty, Fresume_tty):
7093 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7094 * window.c (temp_output_buffer_show):
7095 * insdel.c (signal_before_change):
7096 * frame.c (Fhandle_switch_frame):
7097 * fileio.c (Fdo_auto_save):
7098 * emacs.c (Fkill_emacs):
7099 * editfns.c (save_excursion_restore):
7100 * cmds.c (internal_self_insert):
7101 * callint.c (Fcall_interactively):
7102 * buffer.c (Fkill_all_local_variables):
7103 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7104 Use Frun_hooks.
0f4a96b5 7105 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7106 unconditionnaly since it does the check itself.
7107
2c520ab5 71082011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7109
c9c49752
PE
7110 Fix more problems found by GCC 4.5.2's static checks.
7111
8abc3f12
PE
7112 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7113 the first time through the loop, since we know p0 < p1 then.
7114 This also avoids a gcc -Wstrict-overflow warning.
7115
a2d26660
PE
7116 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7117 leading to a memory leak, possible in functions like
7118 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7119 of objects (Bug#8318).
a2d26660 7120
916c72e9
PE
7121 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7122 that could (at least in theory) be that large.
7123
19ab8a18
PE
7124 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7125 This is less likely to overflow, and avoids undefined behavior if
7126 overflow does occur. All callers changed. Use strtoul to scan
7127 for the unsigned long integer.
b7cbbd6f
PE
7128 (pint2hrstr): Simplify and tune code slightly.
7129 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7130
f0641eff
PE
7131 * scroll.c (do_scrolling): Work around GCC bug 48228.
7132 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7133
7f650bb9
PE
7134 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7135 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7136 (validate_x_resource_name): Simplify count usage.
7137 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7138
37dd57d1
PE
7139 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7140 fail (Bug#8306).
81e56e61 7141
699979fc 7142 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7143
401bf9b4
PE
7144 * process.c (Fmake_network_process): Use socklen_t, not int,
7145 where POSIX says socklen_t is required in portable programs.
7146 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7147 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7148 (Fmake_network_process, server_accept_connection):
7149 (wait_reading_process_output, read_process_output):
7150 Likewise.
7151
b93aacde
PE
7152 * process.c: Rename or move locals to avoid shadowing.
7153 (list_processes_1, Fmake_network_process):
7154 (read_process_output_error_handler, exec_sentinel_error_handler):
7155 Rename or move locals.
4dc343ee 7156 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7157 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7158 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7159 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7160 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7161
af8a867c 7162 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7163 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7164 Include tparam.h instead, since it declares them.
af8a867c
PE
7165 * cm.h (PC): Remove extern decl; tparam.h now does this.
7166 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7167 * terminfo.c: Include tparam.h, to check interfaces.
7168 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7169 (tparam): Adjust signature to match interface in tparam.h;
7170 this removes some undefined behavior. Check that outstring and len
7171 are zero, which they always are with Emacs.
7172 * tparam.h (PC, BC, UP): New extern decls.
7173
0248044d 7174 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7175 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7176
8ff096c1 7177 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7178 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7179 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7180 (ftfont_list): Remove unused local.
49eaafba
PE
7181 (get_adstyle_property, ftfont_pattern_entity):
7182 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7183 Rename locals to avoid shadowing.
8ff096c1 7184
e2be39f6
PE
7185 * xfont.c (xfont_list_family): Mark var as initialized.
7186
c9735e30
PE
7187 * xml.c (make_dom): Now static.
7188
8f5201ae
PE
7189 * composite.c (composition_compute_stop_pos): Rename local to
7190 avoid shadowing.
b246f932
PE
7191 (composition_reseat_it): Remove unused locals.
7192 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7193 (composition_update_it): Mark var as initialized.
11b61122
PE
7194 (find_automatic_composition): Mark vars as initialized,
7195 with a FIXME (Bug#8290).
8f5201ae 7196
760fbc2c
PE
7197 character.h: Rename locals to avoid shadowing.
7198 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7199 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7200 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7201 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7202 to avoid shadowing.
7203
ff08eb85
PE
7204 * textprop.c (property_change_between_p): Remove; unused.
7205
fc7bf025
PE
7206 * intervals.c (interval_start_pos): Now static.
7207
235d7abc
PE
7208 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7209
44f230aa
SM
7210 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7211 Rename locals to avoid shadowing.
3e7d6594 7212
50060332
PE
7213 * sound.c (wav_play, au_play, Fplay_sound_internal):
7214 Fix pointer signedness.
d01f234b 7215 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7216 (wav_play): Initialize a variable to 0, to prevent undefined
7217 behavior (Bug#8278).
50060332 7218
c4fc4e30
PE
7219 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7220
918436ed
PE
7221 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7222
c939f91b
PE
7223 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7224 clobbering (Bug#8298).
b9c7f648
PE
7225 * sysdep.c (sys_subshell): Likewise.
7226 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7227
6bd8c144
PE
7228 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7229 This should get cleaned up, so that child_setup has the
7230 same signature on all platforms.
7231
7710357c 7232 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7233 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7234
c59da222
CY
72352011-03-22 Chong Yidong <cyd@stupidchicken.com>
7236
7237 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7238 not to be necessary, and produces flickering.
7239
66b87493
GM
72402011-03-20 Glenn Morris <rgm@gnu.org>
7241
7242 * config.in: Remove file.
7243
45b6f6d5
JB
72442011-03-20 Juanma Barranquero <lekktu@gmail.com>
7245
7246 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7247 are now in src/globals.h.
7248 (syms_of_minibuf): Remove spurious & from previous change.
7249
3ec03f7e
LL
72502011-03-20 Leo <sdl.web@gmail.com>
7251
7252 * minibuf.c (completing-read-function): New variable.
7253 (completing-read-default): Rename from completing-read.
7254 (completing-read): Call completing-read-function.
7255
b14e3e21
CY
72562011-03-19 Juanma Barranquero <lekktu@gmail.com>
7257
7258 * xfaces.c (Fx_load_color_file):
7259 Read color file from absolute filename (bug#8250).
7260
f2b726e6
JB
72612011-03-19 Juanma Barranquero <lekktu@gmail.com>
7262
7263 * makefile.w32-in: Update dependencies.
7264
09f6ff02
EZ
72652011-03-17 Eli Zaretskii <eliz@gnu.org>
7266
7267 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7268
29a6015a
PE
72692011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7270
a3a6c54e
PE
7271 Fix more problems found by GCC 4.5.2's static checks.
7272
b766f867
PE
7273 * process.c (make_serial_process_unwind, send_process_trap):
7274 (sigchld_handler): Now static.
7275
be02381c
PE
7276 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7277 That way, the code declares only the vars that it needs.
7278 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7279 * s/cygwin.h (PTY_ITERATION): Likewise.
7280 * s/darwin.h (PTY_ITERATION): Likewise.
7281 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7282
57048744
PE
7283 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7284 * process.c (allocate_pty): Don't declare stb unless it's needed.
7285
7914961c 7286 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7287 (CONSTANTLIM): Remove; unused.
7288 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7289 Define only if needed.
7914961c 7290
b3967b18
PE
7291 * unexelf.c (unexec): Name an expression,
7292 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7293 Use a different way to cause a compilation error if anyone uses
7294 n rather than nn, a way that does not involve shadowing.
73366a00 7295 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7296
29a6015a
PE
7297 * deps.mk (unexalpha.o): Remove; unused.
7298
43cfc33e 7299 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7300 * unexec.h: New file.
ce701a33
PE
7301 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7302 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7303 Depend on unexec.h.
7304 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7305 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7306 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7307 Change as necessary to match prototype in unexec.h.
ce701a33 7308
01f44d5a
PE
7309 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7310 shadowing.
4f63c6bb 7311 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7312
a6670b0b
PE
7313 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7314 Rename locals to avoid shadowing.
7315
cef2010d 7316 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7317 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7318
d4d7173a
PE
7319 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7320
f08b802a
PE
7321 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7322 warning when compiling print.c.
7323
3ddb0639
PE
7324 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7325 instead of using an uninitialized var.
5ad03b97 7326 (font_sort_entities): Mark var as initialized.
3ddb0639 7327
170a2692
PE
7328 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7329
e663c700
PE
7330 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7331 pointers to constants.
89bc529a 7332 (font_parse_fcname): Remove unused vars.
7b81e2d0 7333 (font_delete_unmatched): Now static.
ea838e10 7334 (font_get_spec): Remove; unused.
13a547c6
PE
7335 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7336 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7337 Rename or move locals to avoid shadowing.
e663c700 7338
2a80c887 7339 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7340 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7341
1384fa33 7342 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7343 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7344
8b2c52e9
PE
7345 * alloc.c (mark_backtrace): Move decl from here ...
7346 * lisp.h: ... to here, so that it can be checked.
7347
475545b5 7348 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7349 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7350 (lisp_indirect_variable): Name an expression,
7351 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7352 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7353
b1349114 7354 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7355 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7356 Use const pointer when appropriate.
b1349114 7357
a2928364
PE
7358 * lisp.h (get_system_name, get_operating_system_release):
7359 Move decls here, to check interfaces.
7360 * process.c (get_operating_system_release): Move decl to lisp.h.
7361 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7362 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7363 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7364 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7365 (Fformat_time_string, Fencode_time, Finsert_char):
7366 (Ftranslate_region_internal, Fformat):
7367 Rename or remove local vars to avoid shadowing.
9710023e 7368 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7369
a415e694
PE
7370 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7371 avoid shadowing.
7372
8ef4622d
PE
7373 * lisp.h (eassert): Check that the argument compiles, even if
7374 ENABLE_CHECKING is not defined.
7375
946f9a5b
PE
7376 * data.c (Findirect_variable): Name an expression, to avoid
7377 gcc -Wbad-function-cast warning.
112396d6 7378 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7379 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7380 (Fmake_variable_buffer_local, Fmake_local_variable):
7381 Mark variables as initialized.
52746918 7382 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7383
e5aab7e7 7384 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7385 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7386 Rename locals to avoid shadowing.
dff45157
PE
7387 (mark_stack): Move local variables into the #ifdef region where
7388 they're used.
7bc26fdb
PE
7389 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7390 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7391 needed otherwise.
7392 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7393 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7394 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7395
e5aab7e7
PE
7396 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7397 avoids undefined behavior in theory.
7398
4da60324
PE
7399 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7400
88043301
PE
7401 Use functions, not macros, for up- and down-casing (Bug#8254).
7402 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7403 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7404 to use the following functions instead of these macros.
7405 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7406 EMACS_INT, since callers assume the returned value fits in int.
7407 (upcase1): Likewise, for UPCASE_TABLE.
7408 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7409 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7410 the race-condition problem in the old DOWNCASE.
88043301 7411
19ed5445
PE
7412 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7413 Rename locals to avoid shadowing.
7414 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7415 (regex_compile, re_search_2, re_match_2_internal):
7416 Remove unused local vars.
952db0d7
PE
7417 (FREE_VAR): Rewrite so as not to use empty "else",
7418 which gcc can warn about.
da053e48 7419 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7420 (RETALLOC_IF): Define only if needed.
7421 (WORDCHAR_P): Likewise. This one is never needed, but is used
7422 only in a comment talking about a compiler bug, so put inside
7423 the #if 0 of that comment.
7424 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7425 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7426 Remove; unused.
19ed5445 7427
1f3561e4 7428 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7429 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7430 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7431
ded6f8f7
PE
7432 * search.c (simple_search): Remove unused var.
7433
dbd37a95
PE
7434 * dired.c (compile_pattern): Move decl from here ...
7435 * lisp.h: ... to here, so that it can be checked.
7436 (struct re_registers): New forward decl.
7437
7e47afad
PE
7438 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7439
85f24f61
PE
7440 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7441 All uses changed.
7442 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7443 Rename locals to avoid shadowing.
5671df8f 7444 (Fvertical_motion): Mark locals as initialized.
85f24f61 7445
181aa2be 7446 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7447 (casify_region): Mark local as initialized.
181aa2be 7448
930d429c
PE
7449 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7450
7082eac6
PE
7451 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7452 New macros, so that the caller can use some names other than
7453 gcpro1, gcpro2, etc.
7454 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7455 of the new macros.
7456 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7457 argument, for consistency with GCPRO2_VAR, etc: it is now the
7458 prefix of the variable, not the variable itself. All uses
7459 changed.
38b2c076
PE
7460 * dired.c (directory_files_internal, file_name_completion):
7461 Rename locals to avoid shadowing.
7462
15206ed9
PE
7463 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7464 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7465 dired.c's scmp function, had undefined behavior.
7466 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7467 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7468 * buffer.h: ... to here, because these macros use current_buffer,
7469 and the new implementation with inline functions needs to have
7470 current_buffer in scope now, rather than later when the macros
7471 are used.
7472 (downcase, upcase1): New static inline functions.
7473 (DOWNCASE, UPCASE1): Reimplement using these functions.
7474 This avoids undefined behavior in expressions like
7475 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7476 from race conditions in accessing the global variables
7477 case_temp1 and case_temp2.
7478 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7479 * lisp.h (case_temp1, case_temp2): Remove their decls.
7480 * character.h (ASCII_CHAR_P): Move from here ...
7481 * lisp.h: ... to here, so that the inline functions mentioned
7482 above can use them.
7483
4a6bea26
PE
7484 * dired.c (directory_files_internal_unwind): Now static.
7485
f14b7e14
PE
7486 * fileio.c (file_name_as_directory, directory_file_name):
7487 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7488 Now static.
2893f146
PE
7489 (file_name_as_directory): Use const pointers when appropriate.
7490 (Fexpand_file_name): Likewise. In particular, newdir might
7491 point at constant storage, so make it a const pointer.
fd4ead52 7492 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7493 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7494 signedness issues.
f839df0c
PE
7495 (Fset_file_times, Finsert_file_contents, auto_save_error):
7496 Rename locals to avoid shadowing.
f14b7e14 7497
5716756e 7498 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7499 (Ftry_completion, Fall_completions): Rename or remove locals
7500 to avoid shadowing.
5716756e 7501
b4c3046a
PE
7502 * marker.c (bytepos_to_charpos): Remove; unused.
7503
b45db522
PE
7504 * lisp.h (verify_bytepos, count_markers): New decls,
7505 so that gcc does not warn that these functions aren't declared.
7506
85876d07
PE
7507 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7508 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7509 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7510 (copy_text): Remove unused local var.
85876d07 7511
03d78a21 7512 * filelock.c (within_one_second): Now static.
b3dd38ab 7513 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7514
5df8f01b
PE
7515 * buffer.c (fix_overlays_before): Mark locals as initialized.
7516 (fix_start_end_in_overlays): Likewise. This function should be
7517 simplified by using pointers-to-pointers, but that's a different
7518 matter.
b1d876f1 7519 (switch_to_buffer_1): Now static.
8f54f30a
PE
7520 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7521 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7522
a70072c9 7523 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7524 Fix pointer signedness issue.
edced198
PE
7525 (sys_subshell): Mark local as volatile if checking for lint,
7526 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7527 (MAXPATHLEN): Define only if needed.
a70072c9 7528
a0977c44
PE
7529 * process.c (serial_open, serial_configure): Move decls from here ...
7530 * systty.h: ... to here, so that they can be checked.
7531
a884fdcc
PE
7532 * fns.c (get_random, seed_random): Move extern decls from here ...
7533 * lisp.h: ... to here, so that they can be checked.
7534
604efe86 7535 * sysdep.c (reset_io): Now static.
b8950c94 7536 (wait_for_termination_signal): Remove; unused.
604efe86 7537
38fc62d9
PE
7538 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7539 (copy_keymap_item, append_key, push_text_char_description):
7540 Now static.
1004a21a 7541 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7542 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7543 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7544 (describe_map_tree):
7545 Rename locals to avoid shadowing.
38fc62d9 7546
2f2650da
PE
7547 * keyboard.c: Declare functions static if they are not used elsewhere.
7548 (echo_char, echo_dash, cmd_error, top_level_2):
7549 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7550 (read_char, kbd_buffer_get_event, make_lispy_position):
7551 (make_lispy_event, make_lispy_movement, apply_modifiers):
7552 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7553 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7554 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7555 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7556 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7557
a053e86c 7558 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7559 (mark_kboards): Move decl here ...
7560 * alloc.c (mark_kboards): ... from here.
a053e86c 7561
4752793e
PE
7562 * lisp.h (force_auto_save_soon): New decl.
7563
74f10ca7 7564 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7565 (DEFINE_DUMMY_FUNCTION): New macro.
7566 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7567 Use it.
c03cd23f
PE
7568 (main): Add casts to avoid warnings
7569 if GCC considers string literals to be constants.
74f10ca7 7570
022e70d4
PE
7571 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7572
59d6fe83
PE
7573 * dbusbind.c: Pointer signedness fixes.
7574 (xd_signature, xd_append_arg, xd_initialize):
7575 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7576 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7577 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7578 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7579
78320123
PE
7580 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7581 if GCC considers string literals to be constants.
49cebcca 7582 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7583
35ac2a97
SM
75842011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7585
fb103ca9
SM
7586 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7587 (print_preprocess, print_object): New macro to fix last change.
7588
35ac2a97
SM
7589 * print.c (print_preprocess): Don't forget font objects.
7590
62973b41
JB
75912011-03-16 Juanma Barranquero <lekktu@gmail.com>
7592
7593 * emacs.c (USAGE3): Doc fixes.
7594
0e48bb22
AS
75952011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7596
7597 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7598 structure.
7599
7684e57b
JB
76002011-03-14 Juanma Barranquero <lekktu@gmail.com>
7601
7602 * lisp.h (VWindow_system, Qfile_name_history):
7603 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7604 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7605 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7606
7607 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7608 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7609
7610 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7611 * w32console.c (detect_input_pending, read_input_pending)
7612 (encode_terminal_code):
7613 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7614 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7615 (w32_system_caret_y, Qfile_name_history):
7616 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7617 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7618 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7619 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7620 * w32proc.c (Qlocal, report_file_error):
7621 * w32term.c (Vwindow_system, updating_frame):
7622 * w32uniscribe.c (initialized, uniscribe_font_driver):
7623 Remove unneeded extern declarations.
7624
2aa46d6c
CY
76252011-03-14 Chong Yidong <cyd@stupidchicken.com>
7626
c96bbc66 7627 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7628
cffc6f3b
CY
76292011-03-13 Chong Yidong <cyd@stupidchicken.com>
7630
7631 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7632 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7633 These macros can no longer be used for assignment.
7634
44f230aa
SM
7635 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7636 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7637 (record_buffer_markers, fetch_buffer_markers): New functions for
7638 recording and fetching special buffer markers.
7639 (set_buffer_internal_1, set_buffer_temp): Use them.
7640
7641 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7642
7643 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7644
7645 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7646 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7647
7648 * xdisp.c (hscroll_window_tree):
7649 (reconsider_clip_changes): Use PT instead of BUF_PT.
7650
d251f04b
EZ
76512011-03-13 Eli Zaretskii <eliz@gnu.org>
7652
7653 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7654 $(EMACS_ROOT)/lib/intprops.h.
7655
f0c77cd1
PE
76562011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7657
3eca4629
PE
7658 Fix more problems found by GCC 4.5.2's static checks.
7659
7c86ee98
PE
7660 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7661 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7662 (xg_free_frame_widgets): Make it clear that a local variable is
7663 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7664 (gdk_window_get_screen): Make it clear that this macro is needed
7665 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7666 (int_gtk_range_get_value): New function, which avoids a diagnostic
7667 from gcc -Wbad-function-cast.
7668 (xg_set_toolkit_scroll_bar_thumb): Use it.
7669 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7670 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7671 (get_utf8_string, xg_get_file_with_chooser):
7672 Rename locals to avoid shadowing.
7673 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7674
41729b81
PE
7675 * xgselect.c (xg_select): Remove unused var.
7676
f0c77cd1
PE
7677 * image.c (four_corners_best): Mark locals as initialized.
7678 (gif_load): Initialize transparent_p to zero (Bug#8238).
7679 Mark another local as initialized.
ec6cf4c6 7680 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7681
ce0ad53d 7682 * image.c (clear_image_cache): Now static.
d5d5a617 7683 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7684 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7685 (x_edge_detection): Remove unnecessary cast that
7686 gcc -Wbad-function-cast diagnoses.
2037898d 7687 (gif_load): Fix pointer signedness.
6ae141d6
PE
7688 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7689 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7690
33383987 76912011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7692
d32df629
PE
7693 Improve quality of tests for time stamp overflow.
7694 For example, without this patch (encode-time 0 0 0 1 1
7695 1152921504606846976) returns the obviously-bogus value (-948597
7696 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7697 reports time overflow. See
7698 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7699 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7700 * editfns.c: Include limits.h and intprops.h.
7701 (TIME_T_MIN, TIME_T_MAX): New macros.
7702 (time_overflow): Move earlier, to before first use.
7703 (hi_time, lo_time): New functions, for an accurate test for
7704 out-of-range times.
7705 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7706 (Fget_internal_run_time): Don't assume time_t fits in int.
7707 (make_time): Use list2 instead of Fcons twice.
7708 (Fdecode_time): More accurate test for out-of-range times.
7709 (check_tm_member): New function.
7710 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7711 (lisp_time_argument): Don't rely on undefined left-shift and
7712 right-shift behavior when checking for time stamp overflow.
8be6f318 7713
fe31d94c
PE
7714 * editfns.c (time_overflow): New function, refactoring common code.
7715 (Fformat_time_string, Fdecode_time, Fencode_time):
7716 (Fcurrent_time_string): Use it.
7717
8be6f318
PE
7718 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7719 * dired.c (make_time): Move to ...
7720 * editfns.c (make_time): ... here.
7721 * systime.h: Note the move.
7722
09d9db2c 77232011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7724
126bc0dc
YM
7725 * fringe.c (update_window_fringes): Remove unused variables.
7726
c47cbdfd
YM
7727 * unexmacosx.c (copy_data_segment): Also copy __got section.
7728 (Bug#8223)
7729
7ac80be9
EZ
77302011-03-12 Eli Zaretskii <eliz@gnu.org>
7731
c96bbc66 7732 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7733 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7734 Constify `char *' arguments and their references according to
7735 prototypes in tparam.h.
7736
ecb0f94d 7737 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7738
7ac80be9
EZ
7739 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7740 Adapt all references accordingly.
7741
7742 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7743
ef1fd07e
TT
77442011-03-11 Tom Tromey <tromey@redhat.com>
7745
7746 * buffer.c (syms_of_buffer): Remove obsolete comment.
7747
7ef4b50c
EZ
77482011-03-11 Eli Zaretskii <eliz@gnu.org>
7749
7750 * termhooks.h (encode_terminal_code): Declare prototype.
7751
7752 * msdos.c (encode_terminal_code): Don't declare prototype.
7753
7754 * term.c (encode_terminal_code): Now external again, used by
7755 w32console.c and msdos.c.
7756
44f230aa
SM
7757 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7758 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7759
4b1ec863 77602011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7761
1714f52b 7762 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7763
4b1ec863
PE
7764 * fringe.c (update_window_fringes): Mark locals as initialized
7765 (Bug#8227).
7766 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7767
524c7aa6
PE
7768 * alloc.c (mark_fringe_data): Move decl from here ...
7769 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7770 to check its interface.
7771 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7772
a5c0af81 7773 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7774 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7775 (fontset_font): Mark local as initialized.
a9a06e0b 7776 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7777
b4716021
PE
7778 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7779
811e9bac 7780 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7781 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7782 (x_own_selection, Fx_disown_selection_internal): Rename locals
7783 to avoid shadowing.
7784 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7785
7e3ab302
PE
7786 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7787 so that the caller can use some name other than gcpro1.
7788 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7789 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7790 (Fx_backspace_delete_keys_p):
7791 Use them to avoid shadowing, and rename vars to avoid shadowing.
7792 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7793 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7794 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7795 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7796 Remove unused locals.
7e3ab302
PE
7797 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7798 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7799 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7800 macros.
f78faa98 7801
e2b13473
PE
7802 * xterm.h (x_mouse_leave): New decl.
7803
77f23912
PE
7804 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7805 Remove unused functions.
cdf4ba58
PE
7806 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7807 (x_calc_absolute_position): Now static.
7411c686 7808 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7809 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7810 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7811 unless they are used.
38d0b34a
PE
7812 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7813 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7814 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7815 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7816 (x_error_catcher, x_connection_closed, x_error_handler):
7817 (x_error_quitter, xembed_send_message, x_iconify_frame):
7818 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7819 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7820 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7821
44f230aa
SM
7822 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7823 Rename or move locals to avoid shadowing.
6b463e58 7824 (tty_defined_color, merge_face_heights): Now static.
5967d051 7825 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7826 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7827 does not deduce is never used uninitialized.
73719eba
PE
7828 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7829 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7830
426994c3 7831 * terminal.c (store_terminal_param): Now static.
5489860b 7832
032f1620 7833 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7834 (set_frame_menubar): Remove unused local.
d4323972 7835 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7836 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7837 since they might point to immutable storage.
281585b0
PE
7838 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7839 since it's unused otherwise.
032f1620 7840
367c19e5 7841 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7842 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7843 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7844 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7845 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7846 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7847 does not deduce are never used uninitialized.
70739cbe 7848
07b48fa9
PE
7849 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7850
8868a238 7851 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7852 * window.c (window_loop, size_window):
7853 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7854
7e5cf297 7855 * window.c (display_buffer): Now static.
d6550a9f
PE
7856 (size_window): Mark variables that gcc -Wuninitialized
7857 does not deduce are never used uninitialized.
a586633d
PE
7858 * window.h (check_all_windows): New decl, to forestall
7859 gcc -Wmissing-prototypes diagnostic.
5b555da1 7860 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7861
f6095868
PE
7862 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7863 shadowing.
7864 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7865 Include <limits.h>.
7866 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7867 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7868 (load_charset_map): Mark variables that gcc -Wuninitialized
7869 does not deduce are never used uninitialized.
53df7c11 7870 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7871
f38b440c
PE
7872 * coding.c (coding_set_source, coding_set_destination):
7873 Use "else { /* comment */ }" rather than "else /* comment */;"
7874 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7875 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7876 a block, when the outer 'i' will do.
7877 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7878 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7879 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7880 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7881 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7882 Rename locals to avoid shadowing.
7883 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7884 * coding.c (emacs_mule_char, encode_invocation_designation):
7885 Now static, since they're not used elsewhere.
413bb2db 7886 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7887 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7888 (decode_coding_emacs_mule): Mark variables that gcc
7889 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7890 (detect_coding_iso_2022): Initialize a local variable that might
7891 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7892 this initialization is needed. (Bug#8211)
5f58e762
PE
7893 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7894 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7895 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7896 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7897 Remove unused macros.
f38b440c 7898
232b38b9 7899 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7900 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7901 * character.c (string_count_byte8): Likewise.
232b38b9 7902
fb90da1b
PE
7903 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7904 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7905
fb93dbc2
PE
7906 * chartab.c (copy_sub_char_table): Now static, since it's not used
7907 elsewhere.
5c156ace
PE
7908 (sub_char_table_ref_and_range, char_table_ref_and_range):
7909 Rename locals to avoid shadowing.
bbcd0949 7910 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7911
7d3b3862 7912 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7913 (BIDI_BOB): Remove unused macro.
7d3b3862 7914
6be7d3da
PE
7915 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7916 deduce are never used uninitialized.
c2ed9c8b 7917 * term.c (encode_terminal_code): Likewise.
6be7d3da 7918
75f8807f 7919 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7920
50938595
PE
7921 * tparam.h: New file.
7922 * term.c, tparam.h: Include it.
7923 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7924 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7925 Move these decls to tparam.h, and make them agree with what
7926 is actually in tparam.c. The previous trick of using incompatible
7927 decls in different modules does not conform to the C standard.
7928 All callers of tparam changed to use tparam's actual API.
7929 * tparam.c (tparam1, tparam, tgoto):
7930 Use const pointers where appropriate.
7931
fbceeba2
PE
7932 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7933 * cm.h (struct cm): Likewise.
7934 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7935 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7936 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7937 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7938 (turn_on_face, init_tty): Likewise.
7939 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7940
7f3f1250
PE
7941 * term.c (term_mouse_position): Rename local to avoid shadowing.
7942
e6ca6543
PE
7943 * alloc.c (mark_ttys): Move decl from here ...
7944 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7945
c40f8d15
AS
79462011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7947
7948 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7949
cfe0661d
JB
79502011-03-09 Juanma Barranquero <lekktu@gmail.com>
7951
7952 * search.c (compile_pattern_1): Remove argument regp, unused since
7953 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7954 (compile_pattern): Don't pass it.
7955
0afb4571
J
79562011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7957
7958 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7959 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7960 for ! HAVE_GTK3.
7961 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7962
7963 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7964
7965 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7966 gdk_window_get_screen, gdk_window_get_geometry,
7967 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7968 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7969 (xg_get_pixbuf_from_pixmap): New function.
7970 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7971 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7972 Call xg_get_pixbuf_from_pixmap instead of
7973 gdk_pixbuf_get_from_drawable.
7974 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7975 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7976 (xg_check_special_colors): Use GtkStyleContext and its functions
7977 for HAVE_GTK3.
7978 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7979 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7980 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7981 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7982 Call gtk_widget_get_preferred_size.
0afb4571
J
7983 (xg_frame_resized): gdk_window_get_geometry only takes 5
7984 parameters.
44f230aa
SM
7985 (xg_win_to_widget, xg_event_is_for_menubar):
7986 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7987 (xg_set_widget_bg): New function.
7988 (delete_cb): New function.
895009e1 7989 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7990 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7991 (xg_set_background_color): Call xg_set_widget_bg.
7992 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7993 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7994 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7995 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7996 if ! HAVE_GTK3.
7997 (update_frame_tool_bar): Call gtk_widget_hide.
7998 (xg_initialize): Use GDK_KEY_g.
7999
8000 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8001 if ! HAVE_GTK3
8002 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8003
8004 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8005 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8006 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8007
1c2cc4ef
JB
80082011-03-08 Juanma Barranquero <lekktu@gmail.com>
8009
8010 * w32xfns.c (select_palette): Check success of RealizePalette against
8011 GDI_ERROR, not zero.
8012
33383987 8013See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8014
8015;; Local Variables:
8016;; coding: utf-8
aac0c6e3
MR
8017;; End:
8018
33383987 8019 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8020
8021 This file is part of GNU Emacs.
8022
8023 GNU Emacs is free software: you can redistribute it and/or modify
8024 it under the terms of the GNU General Public License as published by
8025 the Free Software Foundation, either version 3 of the License, or
8026 (at your option) any later version.
8027
8028 GNU Emacs is distributed in the hope that it will be useful,
8029 but WITHOUT ANY WARRANTY; without even the implied warranty of
8030 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8031 GNU General Public License for more details.
8032
8033 You should have received a copy of the GNU General Public License
8034 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.