* src/gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
810928a2
AS
12011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2
43f862f7
AS
3 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4
810928a2
AS
5 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6 before statements.
7
a059fe24
JD
82011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9
10 * gtkutil.c (xg_get_default_scrollbar_width): New function.
11
12 * gtkutil.h: Declare xg_get_default_scrollbar_width.
13
14 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
15 min width by calling x_set_scroll_bar_default_width (Bug#8505).
16
989bf368
JB
172011-06-05 Juanma Barranquero <lekktu@gmail.com>
18
19 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
20
4b80f674
CY
212011-06-04 Chong Yidong <cyd@stupidchicken.com>
22
23 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
24 (x_clipboard_manager_save): Add return value.
25 (x_clipboard_manager_error_1, x_clipboard_manager_error_2): New
26 error handlers.
27 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
28 Obey Vx_select_enable_clipboard_manager. Catch errors in
29 x_clipboard_manager_save (Bug#8779).
30 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 31 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 32
99a33b77 332011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
34
35 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
36
99a33b77 372011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
38
39 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
40 in the current matrix if keep_current_p is non-zero.
41
8264569d
EZ
422011-06-04 Eli Zaretskii <eliz@gnu.org>
43
44 * bidi.c (bidi_level_of_next_char): Fix last change.
45
57f97249
EZ
462011-06-03 Eli Zaretskii <eliz@gnu.org>
47
fec2107c 48 Support bidi reordering of text covered by display properties.
57f97249 49
fec2107c
EZ
50 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
51 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
52 (bidi_cache_search, bidi_cache_iterator_state)
53 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
54 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
55 character positions inside a run of characters covered by a
56 display string.
57 (bidi_paragraph_init, bidi_resolve_explicit_1)
58 (bidi_level_of_next_char): Call bidi_fetch_char and
59 bidi_fetch_char_advance instead of FETCH_CHAR and
60 FETCH_CHAR_ADVANCE.
61 (bidi_init_it): Initialize new members.
62 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
63 definitions.
64 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
65 instead of using explicit *_CHAR codes.
66 (bidi_resolve_explicit, bidi_resolve_weak): Use
67 FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
68 bidirectional text is supported only in multibyte buffers.
69 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
70 it to initialize the frame_window_p member of struct bidi_it.
71 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
72 (bidi_resolve_explicit, bidi_resolve_weak)
73 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
74 bidi_it->nchars is non-positive.
75 (bidi_level_of_next_char): Don't try to lookup the cache for the
76 next/previous character if nothing is cached there yet, or if we
77 were just reseat()'ed to a new position.
c40e2fb2 78
0e14fe90
EZ
79 * xdisp.c (set_cursor_from_row): Set start and stop points
80 according to the row's direction when priming the loop that looks
81 for the glyph on which to display cursor.
82 (single_display_spec_intangible_p): Function deleted.
83 (display_prop_intangible_p): Reimplement to call
84 handle_display_spec instead of single_display_spec_intangible_p.
85 Accept 3 additional arguments needed by handle_display_spec. This
86 fixes incorrect cursor motion across display property with complex
87 values: lists, `(when COND...)' forms, etc.
88 (single_display_spec_string_p): Support property values that are
89 lists with the argument STRING its top-level element.
90 (display_prop_string_p): Fix the condition for processing a
91 property that is a list to be consistent with handle_display_spec.
fec2107c 92 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
93 last portion of handle_display_prop.
94 (compute_display_string_pos): Accept additional argument
95 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
96 value of a `display' property is a "replacing spec".
97 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
98 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
99 the display property, but just return a value indicating whether
100 the display property will replace the characters it covers.
101 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
102 frame_window_p members of struct bidi_it.
fec2107c
EZ
103 (compute_display_string_pos, compute_display_string_end): New
104 functions.
105 (push_it): Accept second argument POSITION, where pop_it should
106 jump to continue iteration.
107 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 108
fec2107c
EZ
109 * keyboard.c (adjust_point_for_property): Adjust the call to
110 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
111
112 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
113 (bidi_init_it): Update prototypes.
114 (display_prop_intangible_p): Update prototype.
115 (compute_display_string_pos, compute_display_string_end): Declare
116 prototypes.
117 (struct bidi_it): New members nchars and disp_pos. ch_len is now
118 EMACS_INT.
fc6f18ce 119
40087514 1202011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 121
57f53182
PE
122 Malloc failure behavior now depends on size of allocation.
123 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
124 * lisp.h: Change signatures accordingly.
125 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
126 All callers changed. (Bug#8762)
127
128 * gnutls.c: Use Emacs's memory allocators.
129 Without this change, the gnutls library would invoke malloc etc.
130 directly, which causes problems on non-SYNC_INPUT hosts, and which
131 runs afoul of improving memory_full behavior. (Bug#8761)
132 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
133 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
134 xfree instead of the default malloc, realloc, free.
135 (Fgnutls_boot): No need to check for memory allocation failure,
136 since xmalloc does that for us.
137
ac32cd99 138 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
139 * category.c (hash_get_category_set):
140 * ccl.c (ccl_driver):
141 * charset.c (Fdefine_charset_internal):
142 * charset.h (struct charset.hash_index):
143 * composite.c (get_composition_id, gstring_lookup_cache)
144 (composition_gstring_put_cache):
145 * composite.h (struct composition.hash_index):
146 * dispextern.h (struct image.hash):
147 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
148 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
149 (hashfn_equal, hashfn_user_defined, make_hash_table)
150 (maybe_resize_hash_table, hash_lookup, hash_put)
151 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
152 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
153 (Fsxhash, Fgethash, Fputhash, Fmaphash):
154 * image.c (make_image, search_image_cache, lookup_image)
155 (xpm_put_color_table_h):
156 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 157 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
158 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
159 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
160 * alloc.c (allocate_vectorlike):
161 Check for overflow in vector size calculations.
162 * ccl.c (ccl_driver):
163 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
164 * fns.c, image.c: Remove unnecessary static decls that would otherwise
165 need to be updated by these changes.
40087514
PE
166 * fns.c (make_hash_table, maybe_resize_hash_table):
167 Check for integer overflow with large hash tables.
0de4bb68
PE
168 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
169 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
170 (SXHASH_REDUCE): New macro.
171 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
172 Use it instead of discarding useful hash info with large hash values.
173 (sxhash_float): New function.
174 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
175 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
176 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
177 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
178 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
179 Adjust signatures to match updated version of code.
180 (consing_since_gc): Now EMACS_INT, since a single hash table can
181 use more than INT_MAX bytes.
182
698d32e2
DN
1832011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
184
185 Make it possible to build with GCC-4.6+ -O2 -flto.
186
187 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
188
fd6fa53f
SM
1892011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
190
191 * minibuf.c (get_minibuffer, read_minibuf_unwind):
192 Call minibuffer-inactive-mode.
193
864db017
JB
1942011-05-31 Juanma Barranquero <lekktu@gmail.com>
195
196 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
197 Update dependencies.
198
2ad0baf4
DN
1992011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
200
201 * data.c (init_data): Remove code for UTS, this system is not
202 supported anymore.
203
4fcc2638
DN
2042011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
205
206 Don't force ./temacs to start in terminal mode.
207
208 * frame.c (make_initial_frame): Initialize faces in all cases, not
209 only when CANNOT_DUMP is defined.
210 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
211
c56e0fd5
DN
2122011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
213
214 * dispnew.c (add_window_display_history): Use const for the string
215 pointer. Remove declaration, not needed.
216
333d54da 2172011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 218
55d4c1b2 219 Use 'inline', not 'INLINE'.
333d54da 220 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
221 * alloc.c, fontset.c (INLINE): Remove.
222 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
223 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
224 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
225 * gmalloc.c (register_heapinfo): Use inline unconditionally.
226 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
227
738db178
DN
2282011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
229
230 Make it possible to run ./temacs.
231
232 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
233 syms_of_callproc does the same thing. Remove test for
234 "initialized", do it in the caller.
235 * emacs.c (main): Avoid calling set_initial_environment when dumping.
236
620c53a6
SM
2372011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
238
239 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
240 (read_minibuf): Use get_minibuffer.
241 (syms_of_minibuf): Use DEFSYM.
242 (Qmetadata): New var.
243 * data.c (Qbuffer): Don't make it static.
244 (syms_of_data): Use DEFSYM.
245
e003a292
PE
2462011-05-31 Paul Eggert <eggert@cs.ucla.edu>
247
248 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
249 (CCL_CODE_MIN): New macro.
250
ed008a6d
PE
2512011-05-30 Paul Eggert <eggert@cs.ucla.edu>
252
3687c2ef
PE
253 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
254
ed008a6d
PE
255 * eval.c (Qdebug): Now static.
256 * lisp.h (Qdebug): Remove decl. This reverts a part of the
257 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
258 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
259
d66c4c7c
CY
2602011-05-29 Chong Yidong <cyd@stupidchicken.com>
261
262 * image.c: Various fixes to ImageMagick code comments.
263 (Fimagemagick_types): Doc fix.
264
5fbc2025
PE
2652011-05-29 Paul Eggert <eggert@cs.ucla.edu>
266
0196f88a
PE
267 Minor fixes prompted by GCC 4.6.0 warnings.
268
269 * xselect.c (converted_selections, conversion_fail_tag): Now static.
270
5fbc2025
PE
271 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
272 (x_clipboard_manager_save_all): Move extern decl to ...
273 * xterm.h: ... here, so that it can be checked for consistency.
274
1dd3c2d9
CY
2752011-05-29 Chong Yidong <cyd@stupidchicken.com>
276
277 * xselect.c (x_clipboard_manager_save_frame)
278 (x_clipboard_manager_save_all): New functions.
279 (Fx_clipboard_manager_save): Lisp function deleted.
280
281 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
282 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
283
284 * xterm.h: Update prototype.
285
5ba6571d
WX
2862011-05-28 William Xu <william.xwl@gmail.com>
287
288 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
289 exiting (Bug#8239).
290
3eaff834
JM
2912011-05-28 Jim Meyering <meyering@redhat.com>
292
e1900994 293 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
294 * fns.c (to_uchar): Define.
295 (crypto_hash_function): Use it to convert some newly-signed
296 variables to unsigned, to avoid sign-extension bugs. For example,
297 without this change, (md5 "truc") would evaluate to
298 45723a2aff78ff4fff7fff1114760e62 rather than the expected
299 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 300 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 301
0f6990a7
PE
3022011-05-27 Paul Eggert <eggert@cs.ucla.edu>
303
304 Integer overflow fixes.
c8a9ca5a 305
08686060
PE
306 * dbusbind.c: Serial number integer overflow fixes.
307 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
308 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
309 to hold a serial number that is too large for a fixnum.
310 (Fdbus_method_return_internal, Fdbus_method_error_internal):
311 Check for serial numbers out of range. Decode any serial number
59568bf0 312 that was so large that it became a float. (Bug#8722)
08686060 313
2d1fc3c7
PE
314 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
315 (Fdbus_call_method, Fdbus_call_method_asynchronously):
316 Use XFASTINT rather than XUINT when numbers are nonnegative.
317 (xd_append_arg, Fdbus_method_return_internal):
318 (Fdbus_method_error_internal): Likewise. Also, for unsigned
319 arguments, check that Lisp number is nonnegative, rather than
59568bf0 320 silently wrapping negative numbers around. (Bug#8722)
30217ff0 321 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 322 (Bug#8722)
2d1fc3c7 323
c8a9ca5a
PE
324 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
325
519e1d69
PE
326 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
327
30569699
PE
328 ccl: add integer overflow checks
329 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
330 (IN_INT_RANGE): New macros.
331 (ccl_driver): Use them to check for integer overflow when
332 decoding a CCL program. Many of the new checks are whether XINT (x)
333 fits in int; it doesn't always, on 64-bit hosts. The new version
334 doesn't catch all possible integer overflows, but it's an
847044ea 335 improvement. (Bug#8719)
30569699 336
c11285dc
PE
337 * alloc.c (make_event_array): Use XINT, not XUINT.
338 There's no need for unsigned here.
339
fdccd48e
PE
340 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
341 This follows up to the 2011-05-06 change that substituted uintptr_t
342 for EMACS_INT. This case wasn't caught back then.
343
37910ab2
PE
344 Rework Fformat to avoid integer overflow issues.
345 * editfns.c: Include <float.h> unconditionally, as it's everywhere
346 now (part of C89). Include <verify.h>.
347 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
348 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
349 (Fformat): Avoid the prepass trying to compute sizes; it was only
350 approximate and thus did not catch overflow reliably. Instead, walk
351 through the format just once, formatting and computing sizes as we go,
352 checking for integer overflow at every step, and allocating a larger
353 buffer as needed. Keep track separately whether the format is
354 multibyte. Keep only the most-recently calculated precision, rather
355 than them all. Record whether each argument has been converted to
356 string. Use EMACS_INT, not int, for byte and char and arg counts.
357 Support field widths and precisions larger than INT_MAX. Avoid
358 sprintf's undefined behavior with conversion specifications such as %#d
359 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
360 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
361 formatting out-of-range floating point numbers with int
362 formats. (Bug#8668)
363
2e6578fb
PE
364 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
365
0ae6bdee
PE
366 * data.c: Avoid integer truncation in expressions involving floats.
367 * data.c: Include <intprops.h>.
368 (arith_driver): When there's an integer overflow in an expression
369 involving floating point, convert the integers to floating point
370 so that the resulting value does not suffer from catastrophic
371 integer truncation. For example, on a 64-bit host (* 4
372 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
373 Do not rely on undefined behavior after integer overflow.
374
de883a70
PE
375 merge count_size_as_multibyte, parse_str_to_multibyte
376 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 377 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
378 Check for integer overflow.
379 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
380 since it's now a duplicate of the other. This is more of
381 a character than a buffer op, so better that it's in character.c.
382 * fns.c, print.c: Adjust to above changes.
383
2ff916cb
PE
3842011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
385
386 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
387
f1b54466
PE
3882011-05-27 Paul Eggert <eggert@cs.ucla.edu>
389
fb1ac845
PE
390 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
391 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
392 (x_clipboard_manager_save): Now static.
393 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
394
f1b54466
PE
395 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
396 (crypto_hash_function): Now static.
397 Fix pointer signedness problems. Avoid unnecessary initializations.
398
a9f737ee
CY
3992011-05-27 Chong Yidong <cyd@stupidchicken.com>
400
401 * termhooks.h (Vselection_alist): Make it terminal-local.
402
403 * terminal.c (create_terminal): Initialize it.
404
405 * xselect.c: Support for clipboard managers.
406 (Vselection_alist): Move to termhooks.h as terminal-local var.
407 (LOCAL_SELECTION): New macro.
408 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
409 (symbol_to_x_atom): Remove gratuitous arg.
410 (x_handle_selection_request, lisp_data_to_selection_data)
411 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
412 (x_own_selection, x_get_local_selection, x_convert_selection):
413 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
414 (some_frame_on_display): Delete unused function.
415 (Fx_own_selection_internal, Fx_get_selection_internal)
416 (Fx_disown_selection_internal, Fx_selection_owner_p)
417 (Fx_selection_exists_p): New optional frame arg.
418 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
419 (x_handle_selection_clear): Don't treat other terminals with the
420 same keyboard specially. Use the terminal-local Vselection_alist.
421 (x_clear_frame_selections): Use Frun_hook_with_args.
422
423 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
424
425 * xterm.h: Add support for those atoms.
426
e067f0c1
CY
4272011-05-26 Chong Yidong <cyd@stupidchicken.com>
428
429 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
430 (converted_selections, conversion_fail_tag): New global variables.
431 (x_selection_request_lisp_error): Free the above.
432 (x_get_local_selection): Remove unnecessary code.
433 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
434 of converted selections stored in converted_selections.
435 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
436 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
437 (x_convert_selection): New function.
438 (x_handle_selection_event): Simplify.
439 (x_get_foreign_selection): Don't ignore incoming requests while
440 waiting for an answer; this will fail when we implement
441 SAVE_TARGETS, and seems unnecessary anyway.
442 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
443 (Vx_sent_selection_functions): Doc fix.
444
0f4aebc0
LL
4452011-05-26 Leo Liu <sdl.web@gmail.com>
446
447 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
448
e61124cd
YM
4492011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
450
451 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
452
453 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
454 for fringe update if it has periodic bitmap.
455 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
456 and fringe_bitmap_periodic_p.
457
458 * fringe.c (get_fringe_bitmap_data): New function.
459 (draw_fringe_bitmap_1, update_window_fringes): Use it.
460 (update_window_fringes): Record periodicity of fringe bitmap in glyph
461 row. Mark glyph row for fringe update if periodicity changed.
462
463 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
464 for fringe update unless it has periodic bitmap.
465
f16d9837
KH
4662011-05-25 Kenichi Handa <handa@m17n.org>
467
468 * xdisp.c (get_next_display_element): Set correct it->face_id for
469 a static composition.
470
e1b90ef6
LL
4712011-05-24 Leo Liu <sdl.web@gmail.com>
472
473 * deps.mk (fns.o):
474 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
475
476 * fns.c (crypto_hash_function, Fsha1): New function.
477 (Fmd5): Use crypto_hash_function.
478 (syms_of_fns): Add Ssha1.
479
7400048f
PE
4802011-05-22 Paul Eggert <eggert@cs.ucla.edu>
481
482 * gnutls.c: Remove unused macros.
483 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
484 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
485 Remove macros that are defined and never used.
486 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
487
abb71cf4
CY
4882011-05-22 Chong Yidong <cyd@stupidchicken.com>
489
490 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
491 (Fx_get_selection_internal): Minor cleanup.
492 (Fx_own_selection_internal): Rename arguments for consistency with
493 select.el.
494
6307db39
PE
4952011-05-22 Paul Eggert <eggert@cs.ucla.edu>
496
497 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
498
f3d4e0a4
CY
4992011-05-22 Chong Yidong <cyd@stupidchicken.com>
500
501 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
502
4d8ade89
YM
5032011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
504
505 * dispnew.c (scrolling_window): Don't exclude the case that the
506 last enabled row in the desired matrix touches the bottom boundary.
507
32078c8d
GM
5082011-05-21 Glenn Morris <rgm@gnu.org>
509
510 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
511 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
512 and add some more files.
32078c8d 513
7285dc67
EZ
5142011-05-20 Eli Zaretskii <eliz@gnu.org>
515
516 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
517 report_file_error introduced by the change from 2011-05-07.
518
89d1bd22
PE
5192011-05-20 Paul Eggert <eggert@cs.ucla.edu>
520
521 * systime.h (Time): Define only if emacs is defined.
522 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
523 where the include path doesn't have X11/X.h by default. See
524 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
525
e23640bb 5262011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
527
528 * composite.c (find_automatic_composition): Fix previous change.
529
b9704ad9
GM
5302011-05-20 Glenn Morris <rgm@gnu.org>
531
532 * lisp.mk: New file, split from Makefile.in.
533 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
534 (shortlisp): Remove.
535 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
536
4a720484
GM
5372011-05-19 Glenn Morris <rgm@gnu.org>
538
539 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
540 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
541 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
542 (lisp): Set the order to that of loadup.el.
543 (shortlisp): Make it a copy of $lisp.
544 (SOME_MACHINE_LISP): Remove.
545 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
546 Use just $shortlisp, not $SOME_MACHINE_LISP too.
547
a28d4396
KH
5482011-05-18 Kenichi Handa <handa@m17n.org>
549
550 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
551 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
552 (find_automatic_composition): Mostly rewrite for efficiency.
553
a2b1fa8e
JB
5542011-05-18 Juanma Barranquero <lekktu@gmail.com>
555
556 * makefile.w32-in: Update dependencies.
557
8e1f5610
CS
5582011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
559
560 * menu.c: Include limits.h (fixes the MS-Windows build broken by
561 revision 104625).
562
7025ee00 5632011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 564
cdfa6eab
PE
565 Fix some integer overflow issues, such as string length overflow.
566
06d6db33
PE
567 * insdel.c (count_size_as_multibyte): Check for string overflow.
568
2b4560a8
PE
569 * character.c (lisp_string_width): Check for string overflow.
570 Use EMACS_INT, not int, for string indexes and lengths; in
571 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
572 the resulting string length overflows an EMACS_INT; instead,
573 report a string overflow if no precision given. When checking for
574 precision exhaustion, use a check that cannot possibly have
575 integer overflow. (Bug#8675)
576 * character.h (lisp_string_width): Adjust to new signature.
577
cb93f9be
PE
578 * alloc.c (string_overflow): New function.
579 (Fmake_string): Use it. This doesn't change behavior, but saves
580 a few bytes and will simplify future changes.
581 * character.c (string_escape_byte8): Likewise.
582 * lisp.h (string_overflow): New decl.
583
1a1f3366
PE
584 Fixups, following up to the user-interface timestamp change.
585 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
586 for UI timestamps, instead of unsigned long.
9fbd6841
PE
587 * msdos.c (mouse_get_pos): Likewise.
588 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
589 * w32gui.h (Time): Define by including "systime.h" rather than by
590 declaring it ourselves. (Bug#8664)
591
d4e3e4d3
PE
592 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
593 * image.c (clear_image_cache): Likewise.
594
f6a24d19
PE
595 * term.c (term_mouse_position): Don't assume time_t wraparound.
596
08dc5ae6
PE
597 Be more systematic about user-interface timestamps.
598 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
599 and sometimes 'EMACS_UINT', to represent these timestamps.
600 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
601 This makes the code easier to follow, and makes it easier to catch
602 integer overflow bugs such as Bug#8664.
603 * frame.c (Fmouse_position, Fmouse_pixel_position):
604 Use Time, not unsigned long, for user-interface timestamps.
605 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
606 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
607 * keyboard.h (last_event_timestamp): Likewise.
608 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
609 * menu.h (xmenu_show): Likewise.
610 * term.c (term_mouse_position): Likewise.
611 * termhooks.h (struct input_event.timestamp): Likewise.
612 (struct terminal.mouse_position_hook): Likewise.
613 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
614 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
615 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
616 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
617 what it was before.
618 * menu.h, termhooks.h: Include "systime.h", for Time.
619
8e55734a
PE
620 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
621 Don't assume that the difference between two unsigned long values
622 can fit into an integer. At this point, we know button_down_time
623 <= event->timestamp, so the difference must be nonnegative, so
624 there's no need to cast the result if double-click-time is
625 nonnegative, as it should be; check that it's nonnegative, just in
626 case. This bug is triggered when events are more than 2**31 ms
86db42d2 627 apart (about 25 days). (Bug#8664)
8e55734a 628
841f1b75 629 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 630 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 631
3e26f69c
PE
632 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
633 that always fit in int. Use a sentinel instead of a counter, to
634 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
635 * frame.h (struct frame): Use int for menu_bar_items_used
636 instead of EMACS_INT, since it always fits in int.
3e26f69c 637
5cc152c0
PE
638 * menu.c (grow_menu_items): Check for int overflow.
639
d89eb65e
PE
640 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
641
5235bd3e
PE
642 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
643 Before, the code was not consistent. These values cannot exceed
644 2**31 - 1 so there's no need to make them unsigned.
645 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
646 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
647 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
648 as modifiers.
649 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
650
bc827e23
PE
651 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
652 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
653 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
654 presumably because the widths might not match.
655
78eb494e
PE
656 * window.c (size_window): Avoid needless test at loop start.
657
04f2d78b
CB
6582011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
659
660 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
661
d2fc7e3d 6622011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
663
664 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
665
d2fc7e3d 6662011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
667
668 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
669 `width' to `bar_area_x' and `bar_area_width', respectively.
670 (x_scroll_run): Take account of fringe background extension.
671
04f2d78b
CB
672 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
673 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
674 `bar_area_width', respectively.
675 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
676 background extension.
677
79b70037
GM
6782011-05-10 Jim Meyering <meyering@redhat.com>
679
680 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
681
2f142cc5
JB
6822011-05-10 Juanma Barranquero <lekktu@gmail.com>
683
684 * image.c (Finit_image_library): Return t for built-in image types,
685 like pbm and xbm. (Bug#8640)
686
57679c86
AS
6872011-05-09 Andreas Schwab <schwab@linux-m68k.org>
688
689 * w32menu.c (set_frame_menubar): Fix submenu allocation.
690
888c9e86
EZ
6912011-05-07 Eli Zaretskii <eliz@gnu.org>
692
b0512a1d
EZ
693 * w32console.c (Fset_screen_color): Doc fix.
694 (Fget_screen_color): New function.
695 (syms_of_ntterm): Defsubr it.
696
7285dc67
EZ
697 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
698 unlink the temporary file if Fcall_process didn't create it in the
699 first place.
700 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
701 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
702 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
703 cue to call_process_cleanup not to close that handle.
704
4d3fcc8e
BK
7052011-05-07 Ben Key <bkey76@gmail.com>
706
707 * makefile.w32-in: The bootstrap-temacs rule now makes use of
708 one of two shell specific rules, either bootstrap-temacs-CMD or
709 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
710 to the previous implementation of the bootstrap-temacs rule.
711 The bootstrap-temacs-CMD rule is similar to the previous
712 implementation of the bootstrap-temacs rule except that it
713 makes use of the ESC_CFLAGS variable instead of the CFLAGS
714 variable.
715
716 These changes, along with some changes to nt/configure.bat,
717 nt/gmake.defs, and nt/nmake.defs, are required to extend my
718 earlier fix to add support for --cflags and --ldflags options
719 that include quotes so that it works whether make uses cmd or
720 sh as the shell.
721
b4289b64
MA
7222011-05-06 Michael Albinus <michael.albinus@gmx.de>
723
724 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
725 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
726 is a constant.
727 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
728 a string. Handle both cases.
729 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
730 (Fdbus_register_method): Use Qinvalid_function.
731
af4c0e28
JB
7322011-05-06 Juanma Barranquero <lekktu@gmail.com>
733
734 * makefile.w32-in: Update dependencies.
735 (LISP_H): Add inttypes.h and stdin.h.
736 (PROCESS_H): Add unistd.h.
737
c51453d9
EZ
7382011-05-06 Eli Zaretskii <eliz@gnu.org>
739
740 * lread.c: Include limits.h (fixes the MS-Windows build broken by
741 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
742
8ff0ac3c 7432011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 744
4c4b566b
PE
745 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
746
aab2b9b5
PE
747 * term.c (vfatal): Remove stray call to va_end.
748 It's not needed and the C Standard doesn't allow it here anyway.
749
c378da0b
PE
750 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
751 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
752
288b08c7
PE
753 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
754 bytes.
755
e3601888
PE
756 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
757
db6c0e74
PE
758 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
759
dd5963ea
PE
760 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
761
88c9450f
PE
762 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
763
2f9442b8
PE
764 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
765
c032b5f8
PE
766 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
767 * charset.c (Fdefine_charset_internal): Don't initialize
768 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 769 32-bit int (Bug#8600).
a108c10b
PE
770
771 * lread.c (read_integer): Be more consistent with string-to-number.
772 Use string_to_number to do the actual conversion; this avoids
773 rounding errors and fixes some other screwups. Without this fix,
774 for example, #x1fffffffffffffff was misread as -2305843009213693952.
775 (digit_to_number): Move earlier, for benefit of read_integer.
776 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 777 not a digit in any supported base. (Bug#8602)
a108c10b 778
ad5f9eea
PE
779 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
780
aec1708a
PE
781 * dispnew.c (scrolling_window): Return 1 if we scrolled,
782 to match comment at start of function. This also removes a
783 GCC warning about overflow in a 32+64-bit port.
784
47be4ab5
PE
785 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
786
371cac43
PE
787 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
788 Reported by Stefan Monnier in
789 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
790 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
791 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 792
d01a7826
PE
793 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
794 (EMACS_UINTPTR): Likewise, with uintptr_t.
795
7fd47d5c
PE
796 * lisp.h: Prefer 64-bit EMACS_INT if available.
797 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
798 on 32-bit hosts that have 64-bit int, so that they can access
799 large files.
122b0c86
PE
800 However, temporarily disable this change unless the temporary
801 symbol WIDE_EMACS_INT is defined.
7fd47d5c 802
8727937b
PE
803 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
804
8ac068ac
PE
805 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
806 This removes an assumption that EMACS_INT and long are the same
807 width as pointers. The assumption is true for Emacs porting targets
808 now, but we want to make other targets possible.
809 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
810 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
811 In the rest of the code, change types of integers that hold casted
812 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
813 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
814 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
815 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
816 No need to cast type when ORing.
817 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
818 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
819 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
820 assume EMACS_INT is the same width as char *.
821 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
822 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
823 Remove no-longer-needed casts.
824 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
825 (xg_tool_bar_help_callback, xg_make_tool_item):
826 Use EMACS_INTPTR to hold an integer
827 that will be cast to void *; this can avoid a GCC warning
828 if EMACS_INT is not the same width as void *.
829 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
830 * xdisp.c (display_echo_area_1, resize_mini_window_1):
831 (current_message_1, set_message_1):
832 Use a local to convert to proper width without a cast.
833 * xmenu.c (dialog_selection_callback): Likewise.
834
ede49d71
PE
835 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
836 Also, don't assume VALBITS / RAND_BITS is less than 5,
837 and don't rely on undefined behavior when shifting a 1 left into
838 the sign bit.
839 * lisp.h (get_random): Change signature to match.
840
2f30ecd0
PE
841 * lread.c (hash_string): Use size_t, not int, for hash computation.
842 Normally we prefer signed values; but hashing is special, because
843 it's better to use unsigned division on hash table sizes so that
844 the remainder is nonnegative. Also, size_t is the natural width
845 for hashing into memory. The previous code used 'int', which doesn't
846 retain enough info to hash well into very large tables.
847 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
848
2a866e7b
PE
849 * dbusbind.c: Don't possibly lose pointer info when converting.
850 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
851 Use XPNTR rather than XHASH, so that the high-order bits of
852 the pointer aren't lost when converting through void *.
853
51639eac
PE
854 * eval.c (Fautoload): Don't double-shift a pointer.
855
92394119
PE
856 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
857
dbdb9a7c
JB
8582011-05-06 Juanma Barranquero <lekktu@gmail.com>
859
860 * gnutls.c (DEF_GNUTLS_FN):
861 * image.c (DEF_IMGLIB_FN): Make function pointers static.
862
db7a0b4f
AS
8632011-05-05 Andreas Schwab <schwab@linux-m68k.org>
864
865 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
866 marker. (Bug#8610)
867
f7ff1b0f 8682011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
869
870 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
871 New version that can reserve upto 2GB of heap space.
872
f7ff1b0f 8732011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
874
875 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
876
639c109b
TZ
8772011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
878
879 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
880 `gnutls_certificate_set_x509_key_file'.
881
d2127135
JB
8822011-05-05 Juanma Barranquero <lekktu@gmail.com>
883
884 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
885 Update dependencies.
886
e968f4f3
JB
8872011-05-04 Juanma Barranquero <lekktu@gmail.com>
888
889 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
890 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
891 Remove unused parameter `fildes'.
892 * process.c (read_process_output, send_process): Don't pass it.
893
84d358f0
JB
8942011-05-04 Juanma Barranquero <lekktu@gmail.com>
895
896 Fix previous change: the library cache is defined in w32.c.
897 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
898 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
899
0898ca10
JB
9002011-05-04 Juanma Barranquero <lekktu@gmail.com>
901
902 Implement dynamic loading of GnuTLS on Windows.
903
904 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
905 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
906 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
907 Declare.
908
909 * gnutls.c (Qgnutls_dll): Define.
910 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
911 (gnutls_*): Declare function pointers.
912 (init_gnutls_functions): New function to initialize function pointers.
913 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
914 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
915 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
916 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
917 (emacs_gnutls_write, emacs_gnutls_read)
918 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
919 (Fgnutls_available_p): New function.
920 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
921 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
922 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
923
924 * image.c: Include w32.h.
925 (Vimage_type_cache): Delete.
926 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
927 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
928 (w32_delayed_load): Move to w32.c.
929
930 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
931
932 * w32.c (QCloaded_from, Vlibrary_cache): Define.
933 (w32_delayed_load): Move from image.c. When loading a library, record
934 its filename in the :loaded-from property of the library id.
935 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
936 Initialize and staticpro them.
937 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
938
939 * process.c: Include lisp.h before w32.h, not after.
940 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
941 instead of gnutls_record_check_pending.
942
943 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
944
ff4de4aa
TZ
9452011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
946
947 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
948 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
949 as passed in.
950
abe95abb
JD
9512011-05-03 Jan Djärv <jan.h.d@swipnet.se>
952
953 * xterm.c (x_set_frame_alpha): Do not set property on anything
954 else than FRAME_X_OUTER_WINDOW (Bug#8608).
955
e16e55d4
JB
9562011-05-02 Juanma Barranquero <lekktu@gmail.com>
957
958 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
959
bafcf6a5
JB
9602011-05-02 Juanma Barranquero <lekktu@gmail.com>
961
962 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
963 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
964 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
965 (gnutls_global_initialized, Qgnutls_bootprop_priority)
966 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
967 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
968 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
969 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
970 (Qgnutls_bootprop_callbacks_verify): Make static.
971
e7a6747f
AS
9722011-05-01 Andreas Schwab <schwab@linux-m68k.org>
973
19ed11ba
AS
974 * callproc.c: Indentation fixup.
975
e7a6747f 976 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
977 (wait_for_termination, interruptible_wait_for_termination):
978 Move after wait_for_termination_1.
e7a6747f 979
1ef14cb4
LMI
9802011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
981
982 * sysdep.c (interruptible_wait_for_termination): New function
983 which is like wait_for_termination, but allows keyboard
984 interruptions.
985
986 * callproc.c (Fcall_process): Add (:file "file") as an option for
987 the STDOUT buffer.
988 (Fcall_process_region): Ditto.
989
330d880c
EZ
9902011-04-30 Eli Zaretskii <eliz@gnu.org>
991
8db90b73
EZ
992 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
993 rather than `XVECTOR (FOO)->size'.
994
330d880c
EZ
995 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
996 inttypes.h, as a gnulib replacement is used if it not available in
997 system headers.
998
15cbd324
EZ
9992011-04-21 Eli Zaretskii <eliz@gnu.org>
1000
1001 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1002 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1003 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1004
1005 * coding.c (coding_alloc_by_realloc): Error out if destination
1006 will grow beyond MOST_POSITIVE_FIXNUM.
1007 (decode_coding_emacs_mule): Abort if there isn't enough place in
1008 charbuf for the composition carryover bytes. Reserve an extra
1009 space for up to 2 characters produced in a loop.
1010 (decode_coding_iso_2022): Abort if there isn't enough place in
1011 charbuf for the composition carryover bytes.
1012
10132011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1014
ae940cca
EZ
1015 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1016 aborting when %lld or %lll format is passed.
1017 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1018 %llo or %llx format is passed. (Bug#8545)
1019
03ab8921
EZ
1020 * window.c (window_scroll_line_based): Use a marker instead of
1021 simple variables to record original value of point. (Bug#7952)
1022
afda1437
EZ
1023 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1024 produced by %s or %c overflows available buffer space. (Bug#8545)
1025
f76dee0c
PE
10262011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1027
1028 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1029 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1030
fdc5744d
JB
10312011-04-28 Juanma Barranquero <lekktu@gmail.com>
1032
1033 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1034
638f053a
JB
10352011-04-28 Juanma Barranquero <lekktu@gmail.com>
1036
1037 * keyboard.c (Qdelayed_warnings_hook): Define.
1038 (command_loop_1): Run `delayed-warnings-hook'
1039 if Vdelayed_warnings_list is non-nil.
1040 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1041 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1042
d178f871
EZ
10432011-04-28 Eli Zaretskii <eliz@gnu.org>
1044
1045 * doprnt.c (doprnt): Don't return value smaller than the buffer
1046 size if the message was truncated. (Bug#8545).
1047
b124fd93
JB
10482011-04-28 Juanma Barranquero <lekktu@gmail.com>
1049
1050 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1051 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1052
e810457d
PE
10532011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1054
1055 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1056
ea51cceb
JB
10572011-04-27 Juanma Barranquero <lekktu@gmail.com>
1058
1059 * makefile.w32-in: Update dependencies.
1060
94dcfacf
EZ
10612011-04-27 Eli Zaretskii <eliz@gnu.org>
1062
1063 Improve `doprnt' and its usage. (Bug#8545)
1064 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1065 `format_end'. Remove support for %l as a conversion specifier.
1066 Don't use xrealloc. Improve diagnostics when the %l size modifier
1067 is used. Update the commentary.
1068
1069 * eval.c (verror): Simplify calculation of size_t.
1070
1071 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1072 messages.
1073
f61f41d7
PE
10742011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1075
1076 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1077 change.
1078
96fb4434
PE
10792011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1080
1081 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1082 This makes this file independent of the recent pseudovector change.
1083
671875da 10842011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1085
69e9b5a3
PE
1086 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1087
b5f869a7 1088 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1089 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1090 Remove unused local.
c8926152 1091 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1092
841a1577 1093 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1094 GCC 4.6.0 optimizes based on type-based alias analysis.
1095 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1096 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1097 != &v->size, and therefore "v->size = 1; b->size = 2; return
1098 v->size;" must therefore return 1. This assumption is incorrect
1099 for Emacs, since it type-puns struct Lisp_Vector * with many other
1100 types. To fix this problem, this patch adds a new type struct
f904488f 1101 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1102 and pseudovectors, and helps optimizing compilers not get fooled
1103 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1104 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1105 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1106 the size member.
eab3844f
PE
1107 (XSETPVECTYPE): Rewrite in terms of new macro.
1108 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1109 This is a bit clearer, and further avoids the possibility of
1110 undesirable aliasing.
1111 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1112 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1113 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1114 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1115 (ASIZE): Now uses header.size rather than size.
1116 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1117 to avoid the hassle of writing XVECTOR (foo)->header.size.
1118 (struct vectorlike_header): New type.
eab3844f
PE
1119 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1120 object, to help avoid aliasing.
1121 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1122 (SUBRP): Likewise, since Lisp_Subr is a special case.
1123 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1124 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1125 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1126 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1127 changed to be "header.size" and "header.next".
1128 * buffer.h (struct buffer): Likewise.
1129 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1130 * frame.h (struct frame): Likewise.
1131 * process.h (struct Lisp_Process): Likewise.
1132 * termhooks.h (struct terminal): Likewise.
1133 * window.c (struct save_window_data, struct saved_window): Likewise.
1134 * window.h (struct window): Likewise.
1135 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1136 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1137 * buffer.c (init_buffer_once): Likewise.
1138 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1139 special case.
1140 * process.c (Fformat_network_address): Use local var for size,
1141 for brevity.
1142
0df1eac5
PE
1143 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1144
847ab9d1 1145 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1146 * data.c (atof): Remove decl; no longer used or needed.
1147 (digit_to_number): Move to lread.c.
1148 (Fstring_to_number): Use new string_to_number function, to be
1149 consistent with how the Lisp reader treats infinities and NaNs.
1150 Do not assume that floating-point numbers represent EMACS_INT
1151 without losing information; this is not true on most 64-bit hosts.
1152 Avoid double-rounding errors, by insisting on integers when
1153 parsing non-base-10 numbers, as the documentation specifies.
1154 * lisp.h (string_to_number): New decl, replacing ...
1155 (isfloat_string): Remove.
bc0a5c13 1156 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1157 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1158 appears to have been a coding error. Similarly, do not accept
1159 strings like +-1e0 as floating point numbers. Do not report
1160 overflow for integer overflows unless the base is not 10 which
1161 means we have no simple and reliable way to continue.
1162 Break out the floating-point parsing into a new
1163 function string_to_number, so that Fstring_to_number parses
1164 floating point numbers consistently with the Lisp reader.
04f2d78b 1165 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1166 (E_CHAR, EXP_INT): Remove, replacing with ...
1167 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1168 (string_to_number): New function, replacing isfloat_string.
1169 This function checks for valid syntax and produces the resulting
1170 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1171 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1172 so that overflow for non-base-10 numbers is reported only when
1173 there's no portable and simple way to convert to floating point.
452f4150 1174
67769ffc
PE
1175 * textprop.c (set_text_properties_1): Rewrite for clarity,
1176 and to avoid GCC warning about integer overflow.
1177
c20db43f
PE
1178 * intervals.h (struct interval): Use EMACS_INT for members
1179 where EMACS_UINT might cause problems. See
1180 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1181 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1182 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1183 All uses changed.
37aa2f85
PE
1184 (offset_intervals): Tell GCC not to worry about length overflow
1185 when negating a negative length.
c20db43f 1186
2538aa2f
PE
1187 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1188 (overrun_check_free): Likewise.
1189
f2d3008d
PE
1190 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1191 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1192 word size.
1193
ec8df744
PE
1194 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1195 (gnutls_make_error): Rename local to avoid shadowing.
1196 (gnutls_emacs_global_deinit): ifdef out; not used.
1197 (Fgnutls_boot): Use const for pointer to readonly storage.
1198 Comment out unused local. Fix pointer signedness problems.
1199
640ee02d
PE
1200 * lread.c (openp): Don't stuff size_t into an 'int'.
1201 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1202 about possible signed overflow.
1203
6048fb2a
PE
1204 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1205 (GDK_KEY_g): Don't define if already defined.
1206 (xg_prepare_tooltip): Avoid pointer signedness problem.
1207 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1208
fa3c87e1
PE
1209 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1210 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1211
2172544b
PE
1212 * xfns.c (Fx_window_property): Simplify a bit,
1213 to make a bit faster and to avoid GCC 4.6.0 warning.
1214 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1215
9b821a21
PE
1216 * fns.c (internal_equal): Don't assume size_t fits in int.
1217
3c616cfa
PE
1218 * alloc.c (compact_small_strings): Tighten assertion a little.
1219
c2982e87
PE
1220 Replace pEd with more-general pI, and fix some printf arg casts.
1221 * lisp.h (pI): New macro, generalizing old pEd macro to other
1222 conversion specifiers. For example, use "...%"pI"d..." rather
1223 than "...%"pEd"...".
1224 (pEd): Remove. All uses replaced with similar uses of pI.
1225 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1226 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1227 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1228 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1229 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1230 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1231 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1232 64-bit hosts.
1233 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1234 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1235 * print.c (safe_debug_print, print_object): Likewise.
1236 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1237 to int.
6f04d126
PE
1238 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1239 avoiding the 0 flag, which is not portable.
c2982e87
PE
1240 * process.c (Fmake_network_process): Use pI to avoid cast.
1241 * region-cache.c (pp_cache): Likewise.
1242 * xdisp.c (decode_mode_spec): Likewise.
1243 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1244 behavior on 64-bit hosts with printf arg.
6f04d126 1245 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1246 (x_stop_queuing_selection_requests): Likewise.
1247 (x_get_window_property): Don't truncate byte count to an 'int'
1248 when tracing.
0b432f21 1249
5e073ec7
PE
1250 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1251 here, since it parses constructs like leading '-' and spaces,
1252 which are not wanted; and it overflows with large numbers.
1253 Instead, simply match F[0-9]+, which is what is wanted anyway.
1254
36372bf9
PE
1255 * alloc.c: Remove unportable assumptions about struct layout.
1256 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1257 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1258 (allocate_vectorlike, make_pure_vector): Use the new macros,
1259 plus offsetof, to remove unportable assumptions about struct layout.
1260 These assumptions hold on all porting targets that I know of, but
1261 they are not guaranteed, they're easy to remove, and removing them
1262 makes further changes easier.
1263
0b432f21
PE
1264 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1265 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1266 (string_overrun_cookie): Now const. Use initializers that
1267 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1268 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1269 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1270 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1271 multiple of sizeof (EMACS_INT); it need not be, if
1272 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1273 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1274
895009e1
JB
12752011-04-26 Juanma Barranquero <lekktu@gmail.com>
1276
1277 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1278
6a7a1b0b
TZ
12792011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1280
1281 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1282 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1283 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1284
841a1577 12852011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1286
1287 * lisp.h (Qdebug): List symbol.
895009e1 1288 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1289 * keyboard.c (debug-on-event): New variable.
1290 (handle_user_signal): Break into debugger when debug-on-event
1291 matches the current signal symbol.
1292
f2d3ba6f
DN
12932011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1294
1295 * alloc.c (check_sblock, check_string_bytes)
1296 (check_string_free_list): Convert to standard C.
1297
42ce4c63
TZ
12982011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1299
1300 * w32.c (emacs_gnutls_push): Fix typo.
1301
825cd63c
EZ
13022011-04-25 Eli Zaretskii <eliz@gnu.org>
1303
fb11d64d
EZ
1304 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1305 "cast to pointer from integer of different size".
1306
825cd63c
EZ
1307 Improve doprnt and its use in verror. (Bug#8545)
1308 * doprnt.c (doprnt): Document the set of format control sequences
1309 supported by the function. Use SAFE_ALLOCA instead of always
1310 using `alloca'.
1311
1312 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1313 is one byte too soon. Don't use xrealloc; instead xfree and
1314 xmalloc anew.
1315
e061a11b
TZ
13162011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1317
1318 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1319 callbacks stage.
1320
1321 * gnutls.c: Renamed global_initialized to
1322 gnutls_global_initialized. Added internals for the
1323 :verify-hostname-error, :verify-error, and :verify-flags
1324 parameters of `gnutls-boot' and documented those parameters in the
1325 docstring. Start callback support.
1326 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1327 unless a fatal error occured. Call gnutls_alert_send_appropriate
1328 on error. Return error code.
1329 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1330 (emacs_gnutls_read): Likewise.
1331 (Fgnutls_boot): Return handshake error code.
1332 (emacs_gnutls_handle_error): New function.
1333 (wsaerror_to_errno): Likewise.
1334
1335 * w32.h (emacs_gnutls_pull): Add prototype.
1336 (emacs_gnutls_push): Likewise.
1337
1338 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1339 (emacs_gnutls_push): Likewise.
1340
13412011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1342
1343 * process.c (wait_reading_process_output): Check if GnuTLS
1344 buffered some data internally if no FDs are set for TLS
1345 connections.
1346
1347 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1348 (LIBS): Link to USER_LIBS.
1349 ($(BLD)/gnutls.$(0)): New target.
1350
fa6996bc
EZ
13512011-04-24 Eli Zaretskii <eliz@gnu.org>
1352
eb35682e
EZ
1353 * xdisp.c (handle_single_display_spec): Rename the
1354 display_replaced_before_p argument into display_replaced_p, to
1355 make it consistent with the commentary. Fix typos in the
1356 commentary.
1357
e2ad650c
EZ
1358 * textprop.c (syms_of_textprop): Remove dead code.
1359 (copy_text_properties): Delete obsolete commentary about an
1360 interface that was deleted long ago. Fix typos in the description
1361 of arguments.
1362
1b2de274
EZ
1363 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1364 to changes in oldXMenu/XMenu.h from 2011-04-16.
1365 <menu_help_message, prev_menu_help_message>: Constify.
1366 (IT_menu_make_room): menu->help_text is now `const char **';
1367 adjust.
1368
1369 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1370 to changes in oldXMenu/XMenu.h from 2011-04-16.
1371 (struct XMenu): Declare `help_text' `const char **'.
1372
1373 * xfaces.c <Qunspecified>: Make extern again.
1374
1375 * syntax.c: Include sys/types.h before including regex.h, as
1376 required by Posix.
1377
762b15be
EZ
1378 * doc.c (get_doc_string): Improve the format passed to `error'.
1379
1380 * doprnt.c (doprnt): Improve commentary.
1381
1382 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1383
1384 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1385 them with etags.
1386
f1052e5d
EZ
1387 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1388 changes in globals.h immediately force recompilation.
762b15be
EZ
1389 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1390 $(CURDIR)/s/ms-w32.h.
1391 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1392
fa6996bc
EZ
1393 * character.c (Fchar_direction): Function deleted.
1394 (syms_of_character): Don't defsubr it.
1395 <char-direction-table>: Deleted.
1396
e6c3da20
EZ
13972011-04-23 Eli Zaretskii <eliz@gnu.org>
1398
1399 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1400 * doprnt.c: Include limits.h.
1401 (SIZE_MAX): New macro.
04f2d78b
CB
1402 (doprnt): Return a size_t value. 2nd arg is now size_t.
1403 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1404 Improve overflow protection. Support `l' modifier for integer
1405 conversions. Support %l conversion. Don't assume an EMACS_INT
1406 argument for integer conversions and for %c.
1407
1408 * lisp.h (doprnt): Restore prototype.
1409
1410 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1411 $(SRC)/character.h.
1412
1413 * Makefile.in (base_obj): Add back doprnt.o.
1414
1415 * deps.mk (doprnt.o): Add back prerequisites.
1416 (callint.o): Depend on character.h.
1417
1418 * eval.c (internal_lisp_condition_case): Include the handler
1419 representation in the error message.
1420 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1421 when breaking from the loop.
1422
1423 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1424
1425 * callint.c (Fcall_interactively): When displaying error message
1426 about invalid control letter, pass the character's codepoint, not
1427 a pointer to its multibyte form. Improve display of the character
1428 in octal and display also its hex code.
1429
1430 * character.c (char_string): Use %x to display the (unsigned)
1431 codepoint of an invalid character, to avoid displaying a bogus
1432 negative value.
1433
1434 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1435 `error', not SYMBOL_NAME itself.
1436
1437 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1438 character arguments to `error'.
1439
1440 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1441 to `error' in error message about FINAL_CHAR argument. Make sure
1442 FINAL_CHAR is a character, and use %c when it is passed as
1443 argument to `error'.
1444
4ffd0d6b 14452011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1446
1447 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1448
1449 * w32.c: Include <time.h>.
1450 (sys_localtime): New function.
1451
4ffd0d6b 14522011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1453
1454 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1455
4ffd0d6b 1456 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1457
4ffd0d6b 14582011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1459
4ffd0d6b
GM
1460 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1461 zombies (Bug#8467).
aac0c6e3 1462
04c56954
EZ
14632011-04-19 Eli Zaretskii <eliz@gnu.org>
1464
1465 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1466 gl_state.e_property when gl_state.object is Qt.
1467
1468 * insdel.c (make_gap_larger): Remove limitation of buffer size
1469 to <= INT_MAX.
1470
16a43933
CY
14712011-04-18 Chong Yidong <cyd@stupidchicken.com>
1472
1473 * xdisp.c (lookup_glyphless_char_display)
1474 (produce_glyphless_glyph): Handle cons cell entry in
1475 glyphless-char-display.
1476 (Vglyphless_char_display): Document it.
1477
1478 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1479 glyphless-char-display.
1480
4581706e
CY
14812011-04-17 Chong Yidong <cyd@stupidchicken.com>
1482
1483 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1484
1485 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1486
1487 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1488 definition for no-X builds.
1489
4887c6e2 14902011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1491
fd35b6f9
PE
1492 Static checks with GCC 4.6.0 and non-default toolkits.
1493
5c1ccb01
PE
1494 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1495
006c5daa
PE
1496 * process.c (keyboard_bit_set): Define only if SIGIO.
1497 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1498 (send_process): Repair possible setjmp clobbering.
1499
efc736d3
PE
1500 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1501
4e2fe2e6
PE
1502 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1503
f97334a2
PE
1504 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1505
4e75f29d
PE
1506 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1507 Define only if needed.
1508
90efadd1
PE
1509 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1510 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1511 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1512
3c647824
PE
1513 * dispextern.h (struct redisplay_interface): Rename param
1514 to avoid shadowing.
e264f262 1515 * termhooks.h (struct terminal): Likewise.
761383f4 1516 * xterm.c (xembed_send_message): Likewise.
3c647824 1517
b58c5c4a
PE
1518 * insdel.c (make_gap_smaller): Define only if
1519 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1520
cad59032
PE
1521 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1522 it.
1523
c339dc2e
PE
1524 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1525 so that we aren't warned about unused symbols.
1526
91a3e27b
PE
1527 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1528
399c71d3 1529 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1530
8ffc96f5
PE
1531 * xfns.c (x_real_positions): Mark locals as initialized.
1532
eef9bc79
PE
1533 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1534
098db9dd
PE
1535 * xterm.c: Fix problems found by static analysis with other toolkits.
1536 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1537 (x_dispatch_event): Declare static if USE_GTK, and
1538 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1539 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1540 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1541 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1542 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1543
eb18f6cc
PE
1544 * xmenu.c (menu_help_callback): Pointer type fixes.
1545 Use const pointers when pointing at readonly data. Avoid pointer
1546 signedness clashes.
1547 (FALSE): Remove unused macro.
1548 (update_frame_menubar): Remove unused decl.
1549
1fe72bf8
PE
1550 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1551
60d9e1db
PE
1552 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1553 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1554 (single_menu_item): Rename local to avoid shadowing.
1555
39261c26
PE
1556 * keyboard.c (make_lispy_event): Remove unused local var.
1557
018c5e19
PE
1558 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1559 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1560
63d2b86e
PE
1561 * bitmaps: Change bitmaps from unsigned char back to the X11
1562 compatible char. Avoid the old compiler warnings about
1563 out-of-range initializers by using, for example, '\xab' rather
1564 than 0xab.
1565
aefd87e1
PE
1566 * xgselect.c (xgselect_initialize): Check vs interface
1567 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1568
bf501fb9
PE
1569 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1570
e9829fdf
PE
1571 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1572 to read-only memory.
1573
1086c095
PE
1574 * fns.c (vector): Remove; this old hack is no longer needed.
1575
2baccd04 1576 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1577 Remove unused var.
dde42981 1578 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1579
72391843 1580 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1581
436c16df 1582 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1583 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1584 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1585
92bb796d 1586 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1587 (x_term_init): Remove local to avoid shadowing.
92bb796d 1588
764430a3 1589 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1590
1591 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1592 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1593
d1dfb56c
EZ
15942011-04-16 Eli Zaretskii <eliz@gnu.org>
1595
c4354cb4
EZ
1596 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1597
d1dfb56c
EZ
1598 Fix regex.c, syntax.c and friends for buffers > 2GB.
1599 * syntax.h (struct gl_state_s): Declare character position members
1600 EMACS_INT.
1601
1602 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1603
04f2d78b
CB
1604 * textprop.c (verify_interval_modification, interval_of):
1605 Declare arguments EMACS_INT.
d1dfb56c
EZ
1606
1607 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1608 EMACS_INT.
1609
1610 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1611
1612 * indent.c (Fvertical_motion): Local variable it_start is now
1613 EMACS_INT.
1614
1615 * regex.c (re_match, re_match_2, re_match_2_internal)
1616 (bcmp_translate, regcomp, regexec, print_double_string)
1617 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1618 (re_compile_pattern, re_exec): Declare arguments and local
1619 variables `size_t' and `ssize_t' and return values `regoff_t', as
1620 appropriate.
1621 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1622 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1623 <compile_stack_type>: `size' and `avail' are now `size_t'.
1624
1625 * regex.h <regoff_t>: Use ssize_t, not int.
1626 (re_search, re_search_2, re_match, re_match_2): Arguments that
1627 specify buffer/string position and length are now ssize_t and
1628 size_t. Return type is regoff_t.
1629
613052cd
BK
16302011-04-16 Ben Key <bkey76@gmail.com>
1631
1632 * nsfont.m: Fixed bugs in ns_get_family and
1633 ns_descriptor_to_entity that were caused by using free to
1634 deallocate memory blocks that were allocated by xmalloc (via
1635 xstrdup). This caused Emacs to crash when compiled with
1636 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1637 --enable-checking=xmallocoverrun). xfree is now used to
1638 deallocate these memory blocks.
1639
4170f62f 16402011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1641
71b41406
PE
1642 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1643
9587a89d
PE
1644 emacs_write: Accept and return EMACS_INT for sizes.
1645 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1646 et seq.
1647 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1648 Accept and return EMACS_INT.
1649 (emacs_gnutls_write): Return the number of bytes written on
1650 partial writes.
1651 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1652 (emacs_read, emacs_write): Remove check for negative size, as the
1653 Emacs source code has been audited now.
9587a89d
PE
1654 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1655 (emacs_read, emacs_write): Use it.
273a5f82
PE
1656 * process.c (send_process): Adjust to the new signatures of
1657 emacs_write and emacs_gnutls_write. Do not attempt to store
1658 a byte offset into an 'int'; it might overflow.
9587a89d 1659 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1660
3e047f51
PE
1661 * sound.c: Don't assume sizes fit in 'int'.
1662 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1663 Return EMACS_INT, not int.
3e047f51 1664 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1665 Accept EMACS_INT, not int.
1666 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1667 record read return values.
1668
cc39a9db
BK
16692011-04-15 Ben Key <bkey76@gmail.com>
1670
c9d0ec6d
JB
1671 * keyboard.c (Qundefined): Don't declare static since it is used
1672 in nsfns.m.
1673 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1674 static since they are used in nsfont.m.
cc39a9db 1675
6c60eb9f
SM
16762011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1677
1678 * process.c (Qprocessp): Don't declare static.
1679 * lisp.h (Qprocessp): Declare again.
1680
7990b61a
JB
16812011-04-15 Juanma Barranquero <lekktu@gmail.com>
1682
1683 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1684
5d4cb038
PE
16852011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1686
8bd7b830 1687 Improve C-level modularity by making more things 'static'.
cd64ea1d 1688
e3b27b31
PE
1689 Don't publish debugger-only interfaces to other modules.
1690 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1691 (verify_bytepos, count_markers): Move decls to the only modules
1692 that need them.
1693 * region-cache.h (pp_cache): Likewise.
1694 * window.h (check_all_windows): Likewise.
1695 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1696
5d4cb038
PE
1697 * sysdep.c (croak): Now static, if
1698 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1699 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1700
1701 * alloc.c (refill_memory_reserve): Now static if
1702 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1703 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1704
e87b6180
PE
1705 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1706 Define only if USE_LUCID.
1707
ac64929e
PE
1708 * xrdb.c (x_customization_string, x_rm_string): Now static.
1709
6f37259d
PE
1710 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1711 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1712
1683e3ab
PE
1713 * xdisp.c (draw_row_with_mouse_face): Now static.
1714 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1715
de9c2632
PE
1716 * window.h (check_all_windows): Mark externally visible.
1717
2b96acb7
PE
1718 * window.c (window_deletion_count): Now static.
1719
1720 * undo.c: Make symbols static if they're not exported.
1721 (last_undo_buffer, last_boundary_position, pending_boundary):
1722 Now static.
1723
50436f33
PE
1724 * textprop.c (interval_insert_behind_hooks): Now static.
1725 (interval_insert_in_front_hooks): Likewise.
1726
64520e5c
PE
1727 * term.c: Make symbols static if they're not exported.
1728 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1729 (max_frame_lines, tty_set_terminal_modes):
1730 (tty_reset_terminal_modes, tty_turn_off_highlight):
1731 (get_tty_terminal): Now static.
1732 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1733 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1734 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1735 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1736 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1737
1fa53021
PE
1738 * sysdep.c: Make symbols static if they're not exported.
1739 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1740 Now static.
1741 (sigprocmask_set, full_mask): Remove; unused.
1742 (wait_debugging): Mark as visible.
1743 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1744 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1745
d4b43b22
PE
1746 * syntax.c (syntax_temp): Define only if !__GNUC__.
1747
b7c513d0
PE
1748 * sound.c (current_sound_device, current_sound): Now static.
1749
989b29ad
PE
1750 * search.c (searchbufs, searchbuf_head): Now static.
1751
13a55a78
PE
1752 * scroll.c (scroll_cost): Remove; unused.
1753 * dispextern.h (scroll_cost): Remove decl.
1754
de68a1fc
PE
1755 * region-cache.h (pp_cache): Mark as externally visible.
1756
40ccffa6
PE
1757 * process.c: Make symbols static if they're not exported.
1758 (process_tick, update_tick, create_process, chan_process):
1759 (Vprocess_alist, proc_buffered_char, datagram_access):
1760 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1761 (deactivate_process): Mark defn as static, as well as decl.
1762 * lisp.h (create_process): Remove decl.
1763 * process.h (chan_process, Vprocess_alist): Remove decls.
1764
ad64fc97
PE
1765 * print.c: Make symbols static if they're not exported.
1766 (print_depth, new_backquote_output, being_printed, print_buffer):
1767 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1768 (print_interval, print_number_index, initial_stderr_stream):
1769 Now static.
1770 * lisp.h (Fprinc): Remove decl.
1771 (debug_output_compilation_hack): Mark as externally visible.
1772
adddb265
PE
1773 * sysdep.c (croak): Move decl from here to syssignal.h.
1774 * syssignal.h (croak): Put it here, so the API can be checked when
1775 'croak' is called from dissociate_if_controlling_tty.
1776
1717ede2
PE
1777 * minibuf.c: Make symbols static if they're not exported.
1778 (minibuf_save_list, choose_minibuf_frame): Now static.
1779 * lisp.h (choose_minibuf_frame): Remove decl.
1780
fa5fb2bc
PE
1781 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1782
1e3890d1
PE
1783 * lread.c: Make symbols static if they're not exported.
1784 (read_objects, initial_obarray, oblookup_last_bucket_number):
1785 Now static.
1786 (make_symbol): Remove; unused.
1787 * lisp.h (initial_obarray, make_symbol): Remove decls.
1788
8a1414fa
PE
1789 * keyboard.c: Make symbols static if they're not exported.
1790 (single_kboard, recent_keys_index, total_keys, recent_keys):
1791 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1792 (this_single_command_key_start, echoing, last_auto_save):
1793 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1794 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1795 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1796 (Vlispy_mouse_stem, double_click_count):
1797 Now static.
1798 (force_auto_save_soon): Define only if SIGDANGER.
1799 (ignore_mouse_drag_p): Now static if
1800 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1801 (print_help): Remove; unused.
1802 (stop_character, last_timer_event): Mark as externally visible.
1803 * keyboard.h (ignore_mouse_drag_p): Declare only if
1804 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1805 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1806 * lisp.h (echoing): Remove decl.
1807 (force_auto_save_soon): Declare only if SIGDANGER.
1808 * xdisp.c (redisplay_window): Simplify code, to make it more
1809 obvious that ignore_mouse_drag_p is not accessed if !defined
1810 USE_GTK && !defined HAVE_NS.
1811
93ea6e8f
PE
1812 * intervals.c: Make symbols static if they're not exported.
1813 (merge_properties_sticky, merge_interval_right, delete_interval):
1814 Now static.
1815 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1816
77382fcc
PE
1817 * insdel.c: Make symbols static if they're not exported.
1818 However, leave prepare_to_modify_buffer alone. It's never
1819 called from outside this function, but that appears to be a bug.
1820 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1821 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1822 (adjust_after_replace_noundo): Remove; unused.
1823 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1824 (signal_before_change): Remove decls.
77382fcc 1825
9306c32e
PE
1826 * indent.c (val_compute_motion, val_vmotion): Now static.
1827
cd44d2eb
PE
1828 * image.c: Make symbols static if they're not exported.
1829 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1830 if USE_GTK.
1831 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1832 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1833
ad9a7a06
PE
1834 * fringe.c (standard_bitmaps): Now static.
1835 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1836
81626931
PE
1837 * frame.c: Make symbols static if they're not exported.
1838 (x_report_frame_params, make_terminal_frame): Now static.
1839 (get_frame_param): Now static, unless HAVE_NS.
1840 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1841 (x_get_resource_string): Remove; not used.
1842 * frame.h (make_terminal_frame, x_report_frame_params):
1843 (x_get_resource_string); Remove decls.
1844 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1845 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1846
239f9db9
PE
1847 * font.c, fontset.c: Make symbols static if they're not exported.
1848 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1849 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1850 * font.c (font_close_object): Now static.
1851 * font.h (font_close_object): Remove.
1852 * fontset.c (FONTSET_OBJLIST): Remove.
1853 (free_realized_fontset) #if-0 the body, which does nothing.
1854 (face_suitable_for_char_p): #if-0, as it's never called.
1855 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
1856 * xfaces.c (face_at_string_position):
1857 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
1858 since 0 is always ASCII.
1859
dfcf3579
PE
1860 * fns.c (weak_hash_tables): Now static.
1861
5045092b
PE
1862 * fileio.c: Make symbols static if they're not exported.
1863 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1864 (Vwrite_region_annotation_buffers): Now static.
1865
57a96f5c
PE
1866 * eval.c: Make symbols static if they're not exported.
1867 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1868 * lisp.h (backtrace_list): Remove decl.
1869
35f08c38
PE
1870 * emacs.c: Make symbols static if they're not exported.
1871 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1872 (fatal_error_code, fatal_error_signal_hook, standard_args):
1873 Now static.
1874 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1875 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1876 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1877 * lisp.h (fatal_error_signal_hook): Remove decl.
1878 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1879
f44bd759
PE
1880 * editfns.c: Move a (normally-unused) function to its only use.
1881 * editfns.c, lisp.h (get_operating_system_release): Remove.
1882 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1883 worth the hassle of breaking this out.
1884
b532497d
PE
1885 * xterm.c: Make symbols static if they're not exported.
1886 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1887 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1888 (x_destroy_window, x_delete_display):
1889 Now static.
1890 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1891 (x_mouse_leave): Remove; unused.
1892 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1893 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1894 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1895 Remove decls.
1896 (x_mouse_leave): Declare only if WINDOWSNT.
1897 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1898 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1899 USE_X_TOOLKIT.
1900
1675728f
PE
1901 * ftxfont.c: Make symbols static if they're not exported.
1902 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1903 HAVE_FREETYPE.
1904 * font.h (ftxfont_driver): Likewise.
1905
e4cebfca
PE
1906 * xfns.c: Make symbols static if they're not exported.
1907 (x_last_font_name, x_display_info_for_name):
1908 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1909 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1910 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1911 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1912 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1913 (last_show_tip_args): Now static.
1914 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1915 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1916 (x_screen_planes): Remove; unused.
1917 * dispextern.h (x_screen_planes): Remove decl.
1918
5bf46f05
PE
1919 * dispnew.c: Make symbols static if they're not exported.
1920 * dispextern.h (redraw_garbaged_frames, scrolling):
1921 (increment_row_positions): Remove.
1922 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1923 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1924 Now static.
1925 (redraw_garbaged_frames): Remove; unused.
1926
435f4c28
PE
1927 * xfaces.c: Make symbols static if they're not exported.
1928 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1929 Remove decls.
1930 * xterm.h (defined_color): Remove decls.
1931 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1932 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1933 (menu_face_changed_default, defined_color, free_realized_face):
1934 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1935 (ascii_face_of_lisp_face): Remove; unused.
1936
8524aef3
PE
1937 * xdisp.c: Make symbols static if they're not exported.
1938 * dispextern.h (scratch_glyph_row, window_box_edges):
1939 (glyph_to_pixel_coords, set_cursor_from_row):
1940 (get_next_display_element, set_iterator_to_next):
1941 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1942 (show_mouse_face): Remove decls
1943 * frame.h (message_buf_print): Likewise.
1944 * lisp.h (pop_message, set_message, check_point_in_composition):
1945 Likewise.
1946 * xterm.h (set_vertical_scroll_bar): Likewise.
1947 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1948 (message_buf_print, scratch_glyph_row, displayed_buffer):
1949 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1950 (get_next_display_element, show_mouse_face, window_box_edges):
1951 (frame_to_window_pixel_xy, check_point_in_composition):
1952 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1953 (glyph_to_pixel_coords): Remove; unused.
1954
16390cd2
PE
1955 * dired.c (file_name_completion): Now static.
1956
1957 * dbusbind.c (xd_in_read_queued_messages): Now static.
1958
a25f4dfa
PE
1959 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1960 * data.c (circular_list_error): Remove.
1961
14a9c8df
PE
1962 * commands.h (last_point_position, last_point_position_buffer):
1963 (last_point_position_window): Remove decls.
1964 * keyboard.c: Make these variables static.
1965
04f2d78b
CB
1966 * coding.h (coding, code_convert_region, encode_coding_gap):
1967 Remove decls.
74ab6df5
PE
1968 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1969 (iso_code_class, detect_coding, code_convert_region): Now static.
1970 (encode_coding_gap): Remove; unused.
1971
38dfbee1
PE
1972 * chartab.c (chartab_chars, chartab_bits): Now static.
1973
a2cb4e63
PE
1974 * charset.h (charset_iso_8859_1): Remove decl.
1975 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1976 Now static.
1977
127198fd
PE
1978 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1979 * ccl.c (Vccl_program_table): Now static.
1980 (check_ccl_update): Remove; unused.
1981
d85b608f
PE
1982 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1983 * category.h: ... from here.
1984 * category.c (check_category_table, set_category_set): Now static.
1985
31cd66f3
PE
1986 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1987 * lisp.h: Remove these decls.
1988
c358e587
PE
1989 * buffer.c (buffer_count): Remove unused var.
1990
e78aecca
PE
1991 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1992 so that it's not optimized away.
1993 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1994 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1995 exported only to the debugger.
1996
e192d7d3 1997 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 1998 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 1999
92470028
PE
2000 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2001 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2002 was inaccessible from Lisp.
2003 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2004 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2005
244ed907
PE
2006 alloc.c: Import and export fewer symbols, and remove unused items.
2007 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2008 is defined.
2009 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2010 it's not optimized away by whole-program optimization.
2011 (message_enable_multibyte, free_misc): Remove.
2012 (catchlist, handlerlist, mark_backtrace):
2013 Declare only if BYTE_MARK_STACK.
2014 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2015 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2016 (message_enable_multibyte): Remove decl.
2017 (free_misc, interval_free_list, float_block, float_block_index):
2018 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2019 (cons_free_list, last_marked_index):
2020 Now static.
2021 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2022 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2023 (mark_backtrace): Define only if BYTE_MARK_STACK.
2024 * xdisp.c (message_enable_multibyte): Now static.
2025
61c2b50e 2026 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2027 This makes it easier for human readers (and static analyzers)
2028 to see whether these variables are used from other modules.
2029 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2030 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2031 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2032 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2033 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2034 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2035 * xmenu.c, xselect.c:
2036 Declare Q* vars static if they are not used in other modules.
2037 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2038 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2039 Remove decls of unexported vars.
2040 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2041
95c82688
PE
2042 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2043
16a97296
PE
2044 Make Emacs functions such as Fatom 'static' by default.
2045 This makes it easier for human readers (and static analyzers)
2046 to see whether these functions can be called from other modules.
2047 DEFUN now defines a static function. To make the function external
2048 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2049 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2050 (Finit_image_library):
16a97296
PE
2051 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2052 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2053 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2054 Remove decls, since these functions are now static.
2055 (Funintern, Fget_internal_run_time): New decls, since these functions
2056 were already external.
95c82688 2057
16a97296
PE
2058 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2059 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2060 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2061 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2062 * keyboard.c, keymap.c, lread.c:
2063 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2064 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2065 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2066 Mark functions with DEFUE instead of DEFUN,
2067 if they are used in other modules.
2068 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2069 decls for now-static functions.
2070 * buffer.h (Fdelete_overlay): Remove decl.
2071 * callproc.c (Fgetenv_internal): Mark as internal.
2072 * composite.c (Fremove_list_of_text_properties): Remove decl.
2073 (Fcomposition_get_gstring): New forward static decl.
2074 * composite.h (Fcomposite_get_gstring): Remove decl.
2075 * dired.c (Ffile_attributes): New forward static decl.
2076 * doc.c (Fdocumntation_property): New forward static decl.
2077 * eval.c (Ffetch_bytecode): New forward static decl.
2078 (Funintern): Remove extern decl; now in .h file where it belongs.
2079 * fileio.c (Fmake_symbolic_link): New forward static decl.
2080 * image.c (Finit_image_library): New forward static decl.
2081 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2082 * intervals.h (Fprevious_property_change):
2083 (Fremove_list_of_text_properties): Remove decls.
2084 * keyboard.c (Fthis_command_keys): Remove decl.
2085 (Fcommand_execute): New forward static decl.
2086 * keymap.c (Flookup_key): New forward static decl.
2087 (Fcopy_keymap): Now static.
2088 * keymap.h (Flookup_key): Remove decl.
2089 * process.c (Fget_process): New forward static decl.
2090 (Fprocess_datagram_address): Mark as internal.
2091 * syntax.c (Fsyntax_table_p): New forward static decl.
2092 (skip_chars): Remove duplicate decl.
2093 * textprop.c (Fprevious_property_change): New forward static decl.
2094 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2095 Now internal.
2096 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2097 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2098
785bbd42
PE
2099 * editfns.c (Fformat): Remove unreachable code.
2100
8b913b57
AS
21012011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2102
2103 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2104 change. (Bug#8496)
2105
a6744a35
EZ
21062011-04-13 Eli Zaretskii <eliz@gnu.org>
2107
2108 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2109 when at ZV. (Bug#8487)
2110
e7974947
AS
21112011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2112
baad03f0
AS
2113 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2114 (Bug#8437)
2115 * keyboard.c (parse_tool_bar_item): Likewise.
2116 * sound.c (sound_cleanup, alsa_close): Likewise.
2117 * termcap.c (tgetent): Likewise.
2118 * xfns.c (x_default_font_parameter): Likewise.
2119 * xsettings.c (read_and_apply_settings): Likewise.
2120
e7974947
AS
2121 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2122 (overrun_check_free): Protoize.
2123
28272684
PE
21242011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2125
2126 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2127 since callers should never pass a negative size.
2128 Change the signature to match that of plain 'read' and 'write'; see
2129 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2130 * lisp.h: Update prototypes of emacs_write and emacs_read.
2131
11997c76
EZ
21322011-04-11 Eli Zaretskii <eliz@gnu.org>
2133
2134 * xdisp.c (redisplay_window): Don't try to determine the character
2135 position of the scroll margin if the window start point w->startp
e896f03c 2136 is outside the buffer's accessible region. (Bug#8468)
11997c76 2137
8a2cbd72
EZ
21382011-04-10 Eli Zaretskii <eliz@gnu.org>
2139
2140 Fix write-region and its subroutines for buffers > 2GB.
2141 * fileio.c (a_write, e_write): Modify declaration of arguments and
2142 local variables to support buffers larger than 2GB.
2143 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2144
2145 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2146 argument, local variables, and return value.
2147
2148 * lisp.h: Update prototypes of emacs_write and emacs_read.
2149
2150 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2151
4073e537 21522011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2153
1ebfdcb6
PE
2154 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2155
b2ded58d
PE
2156 Fix more problems found by GCC 4.6.0's static checks.
2157
7d66342c
PE
2158 * xdisp.c (vmessage): Use a better test for character truncation.
2159
bbf47d44
PE
2160 * charset.c (load_charset_map): <, not <=, for optimization,
2161 and to avoid potential problems with integer overflow.
9248994d 2162 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2163 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2164 * editfns.c (Fformat): Likewise.
1e69125e 2165 * syntax.c (skip_chars): Likewise.
3befa583 2166
e3019616
PE
2167 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2168 This also lets GCC 4.6.0 generate slightly better loop code.
2169
becfa255
PE
2170 * callint.c (Fcall_interactively): <, not <=, for optimization.
2171 (Fcall_interactively): Count the number of arguments produced,
2172 not the number of arguments given. This is simpler and lets GCC
2173 4.6.0 generate slightly better code.
2174
dae0cd48
PE
2175 * ftfont.c: Distingish more carefully between FcChar8 and char.
2176 The previous code passed unsigned char * to a functions like
2177 strlen and xstrcasecmp that expect char *, which does not
2178 conform to the C standard.
2179 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2180 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2181 char * when the C standard requires it.
2182
76032d70
PE
2183 * keyboard.c (read_char): Remove unused var.
2184
eb3f1cc8
PE
2185 * eval.c: Port to Windows vsnprintf (Bug#8435).
2186 Include <limits.h>.
2187 (SIZE_MAX): Define if the headers do not.
2188 (verror): Do not give up if vsnprintf returns a negative count.
2189 Instead, grow the buffer. This ports to Windows vsnprintf, which
2190 does not conform to C99. Problem reported by Eli Zaretskii.
2191 Also, simplify the allocation scheme, by avoiding the need for
2192 calling realloc, and removing the ALLOCATED variable.
2193
70476b54
PE
2194 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2195
12020a9e
PE
2196 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2197 But keep the doprint source code for now, as we might revamp it
2198 and use it again (Bug#8435).
ea6c7ae6
PE
2199 * lisp.h (doprnt): Remove.
2200 * Makefile.in (base_obj): Remove doprnt.o.
2201 * deps.mk (doprnt.o): Remove.
2202
5fdb398c
PE
2203 error: Print 32- and 64-bit integers portably (Bug#8435).
2204 Without this change, on typical 64-bit hosts error ("...%d...", N)
2205 was used to print both 32- and 64-bit integers N, which relied on
2206 undefined behavior.
2207 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2208 New macro.
2209 * lisp.h (error, verror): Mark as printf-like functions.
2210 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2211 Report overflow in size calculations when allocating printf buffer.
2212 Do not truncate output string at its first null byte.
2213 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2214 Truncate the output at a character boundary, since vsnprintf does not
2215 do that.
2216 * charset.c (check_iso_charset_parameter): Convert internal
2217 character to string before calling 'error', since %c now has the
2218 printf meaning.
2219 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2220 overflow when computing char to be passed to 'error'. Do not
2221 pass Lisp_Object to 'error'; pass the integer instead.
2222 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2223 formatted with plain %d.
2224
b189fa66
PE
2225 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2226
bff87ef0
PE
2227 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2228
7e2cac20
PE
2229 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2230
ce4d90b5
PE
2231 * xterm.c (x_catch_errors): Remove duplicate declaration.
2232
266c9547
PE
2233 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2234
79c49ad2
PE
2235 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2236
368f4090
JM
22372011-04-10 Jim Meyering <meyering@redhat.com>
2238
2239 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2240 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2241 return ssize_t not "int", and use size_t as the buffer length.
2242 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2243 * gnutls.h: Update declarations.
2244 * process.c (read_process_output): Use ssize_t, to match.
2245 (send_process): Likewise.
2246
a32d4040
CY
22472011-04-09 Chong Yidong <cyd@stupidchicken.com>
2248
2249 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2250
8546720e 22512011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2252
04f2d78b
CB
2253 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2254 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2255
8546720e
GM
2256 * xterm.c (handle_one_xevent):
2257 * xmenu.c (create_and_show_popup_menu):
2258 * xselect.c (x_decline_selection_request)
2259 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2260
0a2f5c1a 22612011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2262
2263 Fix some uses of `int' instead of EMACS_INT.
2264 * search.c (string_match_1, fast_string_match)
2265 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2266 (scan_buffer, find_next_newline_no_quit)
2267 (find_before_next_newline, search_command, Freplace_match)
2268 (Fmatch_data): Make some `int' variables be EMACS_INT.
2269
2270 * xdisp.c (display_count_lines): 3rd argument and return value now
2271 EMACS_INT. All callers changed.
2272 (pint2hrstr): Last argument is now EMACS_INT.
2273
2274 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2275 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2276 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2277 (decode_coding_utf_16, decode_coding_emacs_mule)
2278 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2279 (decode_coding_ccl, decode_coding_charset)
2280 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2281 (decode_coding_iso_2022, decode_coding_emacs_mule)
2282 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2283 <char_offset, last_offset>: Declare EMACS_INT.
2284 (encode_coding_utf_8, encode_coding_utf_16)
2285 (encode_coding_emacs_mule, encode_invocation_designation)
2286 (encode_designation_at_bol, encode_coding_iso_2022)
2287 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2288 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2289 Declare EMACS_INT.
2290 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2291 (encode_invocation_designation): Last argument P_NCHARS is now
2292 EMACS_INT.
2293 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2294 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2295
2296 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2297 All users changed.
2298
2299 * ccl.c (Fccl_execute_on_string): Declare some variables
2300 EMACS_INT.
2301
8546720e 23022011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2303
2304 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2305
4e19a977
CS
23062011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2307
2308 * process.c (Fformat_network_address): Doc fix.
2309
87302331
R
23102011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2311
2312 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2313
cbb59342
CY
23142011-04-08 Chong Yidong <cyd@stupidchicken.com>
2315
2316 * keyboard.c (read_char): Call Lisp function help-form-show,
2317 instead of using internal_with_output_to_temp_buffer.
2318 (Qhelp_form_show): New var.
e0d38eeb 2319 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2320
2321 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2322
2323 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2324
e67a13ab
CY
23252011-04-06 Chong Yidong <cyd@stupidchicken.com>
2326
04f2d78b
CB
2327 * process.c (Flist_processes): Remove to Lisp.
2328 (list_processes_1): Delete.
e67a13ab 2329
973f782d
EZ
23302011-04-06 Eli Zaretskii <eliz@gnu.org>
2331
7c106b1e
EZ
2332 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2333
973f782d
EZ
2334 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2335
41cf7d1a 23362011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2337
ca23cc88
PE
2338 Fix more problems found by GCC 4.6.0's static checks.
2339
f390e2d5
PE
2340 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2341
42eea0d0
PE
2342 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2343
b69769da 2344 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2345
f9541e84
PE
2346 * xdisp.c (vmessage): Mark as a printf-like function.
2347
13841b55
PE
2348 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2349
c136c10f
PE
2350 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2351
5e2d4a30
PE
2352 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2353 printf-like functions.
2354 (tiff_load): Add casts to remove these marks before passing them
2355 to system-supplied API.
2356
583f48b9
PE
2357 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2358
b25d760e
PE
2359 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2360 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2361 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2362 directly, rather than having caller test rule sign. This avoids
2363 some unnecessary tests.
2364 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2365 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2366 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2367
bc7b6697 2368 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2369 (xfont_open): Avoid unnecessary tests.
bc7b6697 2370
27ccc379
PE
2371 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2372
dcd5c89a
PE
2373 * composite.h, composite.c (composition_gstring_put_cache):
2374 Use EMACS_INT, not int, for length.
2375
b13a45c6
PE
2376 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2377 breaking out part of COMPOSITION_DECODE_RULE.
2378 (COMPOSITION_DECODE_RULE): Use it.
2379 * composite.c (get_composition_id): Remove unused local vars,
2380 by using the new macro.
2381
1e792e4d
PE
2382 * textprop.c (set_text_properties_1): Change while to do-while,
2383 since the condition is always true at first.
2384
dc6c6455 2385 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2386 (interval_deletion_adjustment): Return unsigned value.
2387 All uses changed.
dc6c6455 2388
aba7731a
PE
2389 * process.c (list_processes_1, create_pty, read_process_output):
2390 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2391 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2392 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2393 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2394 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2395
fdfc4bf3
PE
2396 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2397
fca8fe46 2398 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2399 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2400
06a0259a 2401 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2402 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2403 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2404
e7b9e80f
PE
2405 * print.c (print_error_message): Avoid int overflow.
2406
56201685
PE
2407 * font.c (font_list_entities): Redo for clarity,
2408 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2409
78834453 2410 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2411 (font_score): Avoid potential overflow in diff calculation.
78834453 2412
0bc0b309 2413 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2414 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2415
e610eaca
PE
2416 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2417
b895abce
PE
2418 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2419 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2420 can always succeed if overflow has undefined behavior.
2421
1f1d9321 2422 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2423 (wordify): Omit three unnecessary tests.
1f1d9321 2424
c59478bc
PE
2425 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2426 All callers changed. This avoids the need for an unused var.
2427
79b73827
PE
2428 * casefiddle.c (casify_region): Remove var that is set but not used.
2429
a4db5dfe
PE
2430 * dired.c (file_name_completion): Remove var that is set but not used.
2431
43aae36e
PE
2432 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2433
2a47c44d 2434 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2435 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2436
a37c69bf
PE
2437 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2438 Check for integer overflow on size calculations.
2439
328ab8e7
PE
2440 * buffer.c (Fprevious_overlay_change): Remove var that is set
2441 but not used.
2442
e5a2a5cb
PE
2443 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2444 Remove vars that are set but not used.
8d84a6eb 2445 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2446 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2447
a60e5f68
PE
2448 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2449
f661cb61 2450 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2451 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2452
f0397f5a
PE
2453 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2454 that are set but not used.
2455
8664db06 2456 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2457 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2458
6abdaa4a
PE
2459 * xselect.c (x_get_local_selection, x_handle_property_notify):
2460 Remove vars that are set but not used.
2461
0ce7538d 2462 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2463 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2464
9ae848fc
PE
2465 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2466 Remove var that is set but not used.
0b918413
PE
2467 (scroll_bar_windows_size): Now size_t, not int.
2468 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2469 Check for overflow.
9ae848fc 2470
a5a62657
PE
2471 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2472 (map_tty_color) [!defined MSDOS]: Likewise.
2473
5c5cdd39
PE
2474 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2475
66ebf983
PE
2476 * coding.c: Remove vars that are set but not used.
2477 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2478 All callers changed.
2479 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2480 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2481 (decode_coding_charset): Remove vars that are set but not used.
2482
1be4d761
PE
2483 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2484 that is set but not used.
2485
47553fa8
PE
2486 * print.c (print_object): Remove var that is set but not used.
2487
1f7196bf 2488 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2489 The gnulib version avoids calling malloc in the usual case,
2490 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2491 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2492 * filelock.c (current_lock_owner): Likewise.
2493 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2494 * sysdep.c: Include allocator.h, careadlinkat.h.
2495 (emacs_no_realloc_allocator): New static constant.
2496 (emacs_readlink): New function.
fdb61804
PE
2497 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2498 ../lib/careadlinkat.h.
d1fdcab7 2499
f84c17c7
SM
25002011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2501
2502 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2503 first non-nil return value).
2504
ef3862ad
JD
25052011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2506
2507 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2508 if not defined (Bug#8403).
2509
376a7006
JB
25102011-04-02 Juanma Barranquero <lekktu@gmail.com>
2511
2512 * xdisp.c (display_count_lines): Remove parameter `start',
2513 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2514 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2515 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2516 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2517 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2518 and thereabouts. All callers changed.
2519 (get_per_char_metric): Remove parameter `f', unused since
2520 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2521
6ca3801d
JM
25222011-04-02 Jim Meyering <meyering@redhat.com>
2523
2524 do not dereference NULL upon failed strdup
2525 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2526 (ns_get_family): Likewise.
2527
d8e2b5ba
JB
25282011-04-02 Juanma Barranquero <lekktu@gmail.com>
2529
2530 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2531
8c74fcbd
JD
25322011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2533
2534 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2535 later (Bug#8403).
2536
7200d79c
SM
25372011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2538
03408648 2539 Add lexical binding.
7200d79c 2540
03408648
SM
2541 * window.c (Ftemp_output_buffer_show): New fun.
2542 (Fsave_window_excursion):
2543 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2544
2545 * lread.c (lisp_file_lexically_bound_p): New function.
2546 (Fload): Bind Qlexical_binding.
2547 (readevalloop): Remove `evalfun' arg.
2548 Bind Qinternal_interpreter_environment.
2549 (Feval_buffer): Bind Qlexical_binding.
2550 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2551 Mark as dynamic.
2552 (syms_of_lread): Declare `lexical-binding'.
2553
2554 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2555
2556 * keyboard.c (eval_dyn): New fun.
2557 (menu_item_eval_property): Use it.
ca105506
SM
2558
2559 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2560
03408648
SM
2561 * fns.c (concat, mapcar1): Accept byte-code-functions.
2562
2563 * eval.c (Fsetq): Handle lexical vars.
2564 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2565 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2566 (FletX, Flet): Obey lexical binding.
2567 (Fcommandp): Handle closures.
2568 (Feval): New `lexical' arg.
2569 (eval_sub): New function extracted from Feval. Use it almost
2570 everywhere where Feval was used. Look up vars in lexical env.
2571 Handle closures.
2572 (Ffunctionp): Move from subr.el.
2573 (Ffuncall): Handle closures.
2574 (apply_lambda): Remove `eval_flags'.
2575 (funcall_lambda): Handle closures and new byte-code-functions.
2576 (Fspecial_variable_p): New function.
2577 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2578 but without exporting it to Lisp.
23aba0ea 2579
23aba0ea 2580 * doc.c (Fdocumentation, store_function_docstring):
03408648 2581 * data.c (Finteractive_form): Handle closures.
23aba0ea 2582
03408648
SM
2583 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2584 interactive spec.
ba83908c 2585
04f2d78b
CB
2586 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2587 New byte-codes.
03408648
SM
2588 (exec_byte_code): New function extracted from Fbyte_code to handle new
2589 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2590
03408648 2591 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2592
03408648 2593 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2594
e2abce01
JB
25952011-03-31 Juanma Barranquero <lekktu@gmail.com>
2596
2597 * xdisp.c (redisplay_internal): Fix prototype.
2598
63696a73 25992011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2600
63696a73 2601 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
2602 (try_scrolling): Use it when setting scroll_limit.
2603 Limit scrolling to 100 screen lines.
63696a73
EZ
2604 (redisplay_window): Even when falling back on "recentering",
2605 position point in the window according to scroll-conservatively,
2606 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2607
2608 (try_scrolling): When point is above the window, allow searching
2609 as far as scroll_max, or one screenful, to compute vertical
2610 distance from PT to the scroll margin position. This prevents
2611 try_scrolling from unnecessarily failing when
2612 scroll-conservatively is set to a value slightly larger than the
2613 window height. Clean up the case of PT below the margin at bottom
2614 of window: scroll_max can no longer be INT_MAX. When aggressive
2615 scrolling is in use, don't let point enter the opposite scroll
2616 margin as result of the scroll.
2617 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2618 threshold of 100 lines for never-recentering scrolling.
2619
e4cc2dfc
JB
26202011-03-31 Juanma Barranquero <lekktu@gmail.com>
2621
2622 * dispextern.h (move_it_by_lines):
2623 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2624 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2625 (message_log_check_duplicate): Remove parameters `prev_bol' and
2626 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2627 (redisplay_internal): Remove parameter `preserve_echo_area',
2628 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2629
2630 * indent.c (Fvertical_motion):
2631 * window.c (window_scroll_pixel_based, Frecenter):
2632 Don't pass `need_y_p' to `move_it_by_lines'.
2633
1c470562
SM
26342011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2635
44f230aa
SM
2636 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2637 steal a few bits to be more compact.
2638 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2639 Remove unneeded casts.
2640
1c470562
SM
2641 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2642
888adce9
ZK
26432011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2644
2645 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2646 binding" message (bug#7967).
2647
f838ed7b
PE
26482011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2649
77861b95
PE
2650 Fix more problems found by GCC 4.6.0's static checks.
2651
de6dbc14
PE
2652 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2653 Remove unused local var.
2654
f838ed7b
PE
2655 * editfns.c (Fmessage_box): Remove unused local var.
2656
792c7b2b
PE
2657 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2658 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2659 Omit unused local vars.
c499e557 2660 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2661 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2662 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2663 Omit unused local var.
2664
ba0165e1
PE
2665 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2666 Don't assume string length fits in int.
32ad8845 2667 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2668 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2669
3c59b4c9
PE
2670 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2671 instead of alloca (Bug#8344).
2672
a3eed478 2673 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2674 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2675
eb4d412d
PE
2676 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2677
1658b401
PE
2678 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2679 concerns.
2680
2681 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2682
2683 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2684
9a2c6e05
PE
2685 * keyboard.c (syms_of_keyboard): Use the same style as later
2686 in this function when indexing through an array. This also
2687 works around GCC bug 48267.
2688
03d0a109
PE
2689 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2690
44f730c8
PE
2691 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2692
fe75f926
PE
2693 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2694 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2695
ffa8c828
PE
2696 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2697 This avoids undefined behavior on integer overflow, and is a bit
2698 more convenient anyway since it is compared to a size_t variable.
2699
c5101a77
PE
2700 Variadic C functions now count arguments with size_t, not int.
2701 This avoids an unnecessary limitation on 64-bit machines, which
2702 caused (substring ...) to crash on large vectors (Bug#8344).
2703 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2704 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2705 All variadic functions and their callers changed accordingly.
c5101a77
PE
2706 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2707 * data.c (arith_driver, float_arith_driver): Likewise.
2708 * editfns.c (general_insert_function): Likewise.
2709 * eval.c (struct backtrace.nargs, interactive_p)
2710 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2711 (funcall_lambda, mark_backtrace): Likewise.
2712 * fns.c (concat): Likewise.
2713 * frame.c (x_set_frame_parameters): Likewise.
2714 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2715 0 if not found, not -1. All callers changed.
2716
dd3f25f7
PE
2717 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2718 (stack_copy_size): Now size_t, not int.
2719 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2720
461c2ab9
JB
27212011-03-28 Juanma Barranquero <lekktu@gmail.com>
2722
2723 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2724 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2725 All callers changed.
2726
2727 * lisp.h (multibyte_char_to_unibyte):
2728 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2729 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2730 * character.h (CHAR_TO_BYTE8):
2731 * cmds.c (internal_self_insert):
2732 * editfns.c (general_insert_function):
2733 * keymap.c (push_key_description):
2734 * search.c (Freplace_match):
2735 * xdisp.c (message_dolog, set_message_1): All callers changed.
2736
f6d62986
SM
27372011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2738
2739 * keyboard.c (safe_run_hook_funcall): New function.
2740 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2741 don't set the hook to nil, but remove the offending function instead.
2742 (Qcommand_hook_internal): Remove, unused.
2743 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2744 Vcommand_hook_internal.
2745
2746 * eval.c (enum run_hooks_condition): Remove.
2747 (funcall_nil, funcall_not): New functions.
2748 (run_hook_with_args): Call each function through a `funcall' argument.
2749 Remove `cond' argument, now redundant.
2750 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2751 (Frun_hook_with_args_until_failure): Adjust accordingly.
2752 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2753
1db5b1ad
JB
27542011-03-28 Juanma Barranquero <lekktu@gmail.com>
2755
2756 * dispextern.h (string_buffer_position): Remove declaration.
2757
2758 * print.c (strout): Remove parameter `multibyte', unused since
2759 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2760
2761 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2762 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2763 All callers changed.
2764
2765 * w32.c (_wsa_errlist): Use braces for struct initializers.
2766
2767 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2768 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2769 All callers changed.
2770 (string_buffer_position): Likewise. Also, make static (it's never
2771 used outside xdisp.c).
2772 (cursor_row_p): Remove parameter `w', unused since
2773 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2774 (decode_mode_spec): Remove parameter `precision', introduced during
2775 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2776 All callers changed.
2777
5ffb62aa
JD
27782011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2779
2780 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2781
461c2ab9 27822011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2783
2784 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2785 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2786 (ns_update_auto_hide_menu_bar): New functions.
2787 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2788 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2789 ns_constrain_all_frames.
2790 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2791 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2792
5c380ffb
JD
27932011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2794
2795 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2796
9af30bdf
GM
27972011-03-27 Glenn Morris <rgm@gnu.org>
2798
2799 * syssignal.h: Replace RETSIGTYPE with void.
2800 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2801 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2802 Replace SIGTYPE with void everywhere.
2803 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2804 * s/template.h (SIGTYPE): Remove commented out definition.
2805
e2abce01
JB
28062011-03-26 Eli Zaretskii <eliz@gnu.org>
2807
2808 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2809 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2810
f868cd8a
JB
28112011-03-26 Juanma Barranquero <lekktu@gmail.com>
2812
59eb0929
JB
2813 * w32.c (read_unc_volume): Use parameter `henum', instead of
2814 global variable `wget_enum_handle'.
2815
2816 * keymap.c (describe_vector): Remove parameters `indices' and
2817 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2818 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2819
f868cd8a
JB
2820 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2821
2822 * keyboard.c (timer_check): Remove parameter `do_it_now',
2823 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2824 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2825 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2826
2827 * keyboard.c (read_char):
2828 * w32menu.c (w32_menu_display_help):
2829 * xmenu.c (show_help_event, menu_help_callback):
2830 Adjust calls to `show_help_echo'.
2831
2832 * gtkutil.c (xg_maybe_add_timer):
2833 * keyboard.c (readable_events):
2834 * process.c (wait_reading_process_output):
2835 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2836
2837 * insdel.c (adjust_markers_gap_motion):
2838 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2839 (gap_left, gap_right): Don't call it.
2840
2ecf6fdb
CY
28412011-03-25 Chong Yidong <cyd@stupidchicken.com>
2842
2843 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2844 incurred during fontification.
2845
6b1f9ba4
JB
28462011-03-25 Juanma Barranquero <lekktu@gmail.com>
2847
2848 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2849 (DEFVAR_PER_BUFFER): Don't pass it.
2850
2851 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2852 (scrolling_window): Don't pass it.
2853
0f4a96b5
JB
28542011-03-25 Juanma Barranquero <lekktu@gmail.com>
2855
2856 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2857
2858 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2859 and `suffix'.
2860 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2861 of variables specific to SELinux and computation of `encoded_absname'.
2862
2863 * image.c (XPutPixel): Remove unused variable `height'.
2864
2865 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2866
2867 * unexw32.c (get_section_info): Remove unused variable `section'.
2868
2869 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2870 (system_process_attributes): Remove unused variable `sess'.
2871 (sys_read): Remove unused variable `err'.
2872
2873 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2874 (w32_wnd_proc): Remove unused variable `isdead'.
2875 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2876 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2877 (x_create_tip_frame): Remove unused variable `tem'.
2878
2879 * w32inevt.c (w32_console_read_socket):
2880 Remove unused variable `no_events'.
2881
2882 * w32term.c (x_draw_composite_glyph_string_foreground):
2883 Remove unused variable `width'.
2884
1149507c
JB
28852011-03-24 Juanma Barranquero <lekktu@gmail.com>
2886
2887 * w32term.c (x_set_glyph_string_clipping):
2888 Don't pass uninitialized region to CombineRgn.
2889
9c88f339
JB
28902011-03-23 Juanma Barranquero <lekktu@gmail.com>
2891
2892 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2893 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2894 (Fx_close_connection): Remove unused variable `i'.
2895
2896 * w32font.c (w32font_draw): Return number of glyphs.
2897 (w32font_open_internal): Remove unused variable `i'.
2898 (w32font_driver): Add missing initializer.
2899
2900 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2901 (fill_in_menu): Remove unused variable `items_added'.
2902
2903 * w32term.c (last_mouse_press_frame): Remove static global variable.
2904 (w32_clip_to_row): Remove unused variable `f'.
2905 (x_delete_terminal): Remove unused variable `i'.
2906
2907 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2908 (NOTHING): Remove unused static global variable.
2909 (uniscribe_check_otf): Remove unused variable `table'.
2910 (uniscribe_font_driver): Add missing initializers.
2911
dee091a3
JD
29122011-03-23 Julien Danjou <julien@danjou.info>
2913
2914 * term.c (Fsuspend_tty, Fresume_tty):
2915 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2916 * window.c (temp_output_buffer_show):
2917 * insdel.c (signal_before_change):
2918 * frame.c (Fhandle_switch_frame):
2919 * fileio.c (Fdo_auto_save):
2920 * emacs.c (Fkill_emacs):
2921 * editfns.c (save_excursion_restore):
2922 * cmds.c (internal_self_insert):
2923 * callint.c (Fcall_interactively):
2924 * buffer.c (Fkill_all_local_variables):
2925 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2926 Use Frun_hooks.
0f4a96b5 2927 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2928 unconditionnaly since it does the check itself.
2929
2c520ab5 29302011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2931
c9c49752
PE
2932 Fix more problems found by GCC 4.5.2's static checks.
2933
8abc3f12
PE
2934 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2935 the first time through the loop, since we know p0 < p1 then.
2936 This also avoids a gcc -Wstrict-overflow warning.
2937
a2d26660
PE
2938 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2939 leading to a memory leak, possible in functions like
2940 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2941 of objects (Bug#8318).
a2d26660 2942
916c72e9
PE
2943 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2944 that could (at least in theory) be that large.
2945
19ab8a18
PE
2946 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2947 This is less likely to overflow, and avoids undefined behavior if
2948 overflow does occur. All callers changed. Use strtoul to scan
2949 for the unsigned long integer.
b7cbbd6f
PE
2950 (pint2hrstr): Simplify and tune code slightly.
2951 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2952
f0641eff
PE
2953 * scroll.c (do_scrolling): Work around GCC bug 48228.
2954 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2955
7f650bb9
PE
2956 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2957 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2958 (validate_x_resource_name): Simplify count usage.
2959 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2960
37dd57d1
PE
2961 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2962 fail (Bug#8306).
81e56e61 2963
699979fc 2964 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2965
401bf9b4
PE
2966 * process.c (Fmake_network_process): Use socklen_t, not int,
2967 where POSIX says socklen_t is required in portable programs.
2968 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2969 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2970 (Fmake_network_process, server_accept_connection):
2971 (wait_reading_process_output, read_process_output):
2972 Likewise.
2973
b93aacde
PE
2974 * process.c: Rename or move locals to avoid shadowing.
2975 (list_processes_1, Fmake_network_process):
2976 (read_process_output_error_handler, exec_sentinel_error_handler):
2977 Rename or move locals.
4dc343ee 2978 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2979 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2980 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2981 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2982 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2983
af8a867c 2984 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2985 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2986 Include tparam.h instead, since it declares them.
af8a867c
PE
2987 * cm.h (PC): Remove extern decl; tparam.h now does this.
2988 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2989 * terminfo.c: Include tparam.h, to check interfaces.
2990 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2991 (tparam): Adjust signature to match interface in tparam.h;
2992 this removes some undefined behavior. Check that outstring and len
2993 are zero, which they always are with Emacs.
2994 * tparam.h (PC, BC, UP): New extern decls.
2995
0248044d 2996 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2997 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2998
8ff096c1 2999 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3000 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3001 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3002 (ftfont_list): Remove unused local.
49eaafba
PE
3003 (get_adstyle_property, ftfont_pattern_entity):
3004 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3005 Rename locals to avoid shadowing.
8ff096c1 3006
e2be39f6
PE
3007 * xfont.c (xfont_list_family): Mark var as initialized.
3008
c9735e30
PE
3009 * xml.c (make_dom): Now static.
3010
8f5201ae
PE
3011 * composite.c (composition_compute_stop_pos): Rename local to
3012 avoid shadowing.
b246f932
PE
3013 (composition_reseat_it): Remove unused locals.
3014 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3015 (composition_update_it): Mark var as initialized.
11b61122
PE
3016 (find_automatic_composition): Mark vars as initialized,
3017 with a FIXME (Bug#8290).
8f5201ae 3018
760fbc2c
PE
3019 character.h: Rename locals to avoid shadowing.
3020 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3021 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3022 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3023 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3024 to avoid shadowing.
3025
ff08eb85
PE
3026 * textprop.c (property_change_between_p): Remove; unused.
3027
fc7bf025
PE
3028 * intervals.c (interval_start_pos): Now static.
3029
235d7abc
PE
3030 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3031
44f230aa
SM
3032 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3033 Rename locals to avoid shadowing.
3e7d6594 3034
50060332
PE
3035 * sound.c (wav_play, au_play, Fplay_sound_internal):
3036 Fix pointer signedness.
d01f234b 3037 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3038 (wav_play): Initialize a variable to 0, to prevent undefined
3039 behavior (Bug#8278).
50060332 3040
c4fc4e30
PE
3041 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3042
918436ed
PE
3043 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3044
c939f91b
PE
3045 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3046 clobbering (Bug#8298).
b9c7f648
PE
3047 * sysdep.c (sys_subshell): Likewise.
3048 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3049
6bd8c144
PE
3050 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3051 This should get cleaned up, so that child_setup has the
3052 same signature on all platforms.
3053
7710357c 3054 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3055 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3056
c59da222
CY
30572011-03-22 Chong Yidong <cyd@stupidchicken.com>
3058
3059 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3060 not to be necessary, and produces flickering.
3061
66b87493
GM
30622011-03-20 Glenn Morris <rgm@gnu.org>
3063
3064 * config.in: Remove file.
3065
45b6f6d5
JB
30662011-03-20 Juanma Barranquero <lekktu@gmail.com>
3067
3068 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3069 are now in src/globals.h.
3070 (syms_of_minibuf): Remove spurious & from previous change.
3071
3ec03f7e
LL
30722011-03-20 Leo <sdl.web@gmail.com>
3073
3074 * minibuf.c (completing-read-function): New variable.
3075 (completing-read-default): Rename from completing-read.
3076 (completing-read): Call completing-read-function.
3077
b14e3e21
CY
30782011-03-19 Juanma Barranquero <lekktu@gmail.com>
3079
3080 * xfaces.c (Fx_load_color_file):
3081 Read color file from absolute filename (bug#8250).
3082
f2b726e6
JB
30832011-03-19 Juanma Barranquero <lekktu@gmail.com>
3084
3085 * makefile.w32-in: Update dependencies.
3086
09f6ff02
EZ
30872011-03-17 Eli Zaretskii <eliz@gnu.org>
3088
3089 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3090
29a6015a
PE
30912011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3092
a3a6c54e
PE
3093 Fix more problems found by GCC 4.5.2's static checks.
3094
b766f867
PE
3095 * process.c (make_serial_process_unwind, send_process_trap):
3096 (sigchld_handler): Now static.
3097
be02381c
PE
3098 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3099 That way, the code declares only the vars that it needs.
3100 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3101 * s/cygwin.h (PTY_ITERATION): Likewise.
3102 * s/darwin.h (PTY_ITERATION): Likewise.
3103 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3104
57048744
PE
3105 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3106 * process.c (allocate_pty): Don't declare stb unless it's needed.
3107
7914961c 3108 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3109 (CONSTANTLIM): Remove; unused.
3110 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3111 Define only if needed.
7914961c 3112
b3967b18
PE
3113 * unexelf.c (unexec): Name an expression,
3114 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3115 Use a different way to cause a compilation error if anyone uses
3116 n rather than nn, a way that does not involve shadowing.
73366a00 3117 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3118
29a6015a
PE
3119 * deps.mk (unexalpha.o): Remove; unused.
3120
43cfc33e 3121 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3122 * unexec.h: New file.
ce701a33
PE
3123 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3124 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3125 Depend on unexec.h.
3126 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3127 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3128 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3129 Change as necessary to match prototype in unexec.h.
ce701a33 3130
01f44d5a
PE
3131 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3132 shadowing.
4f63c6bb 3133 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3134
a6670b0b
PE
3135 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3136 Rename locals to avoid shadowing.
3137
cef2010d 3138 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3139 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3140
d4d7173a
PE
3141 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3142
f08b802a
PE
3143 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3144 warning when compiling print.c.
3145
3ddb0639
PE
3146 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3147 instead of using an uninitialized var.
5ad03b97 3148 (font_sort_entities): Mark var as initialized.
3ddb0639 3149
170a2692
PE
3150 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3151
e663c700
PE
3152 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3153 pointers to constants.
89bc529a 3154 (font_parse_fcname): Remove unused vars.
7b81e2d0 3155 (font_delete_unmatched): Now static.
ea838e10 3156 (font_get_spec): Remove; unused.
13a547c6
PE
3157 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3158 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3159 Rename or move locals to avoid shadowing.
e663c700 3160
2a80c887 3161 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3162 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3163
1384fa33 3164 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3165 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3166
8b2c52e9
PE
3167 * alloc.c (mark_backtrace): Move decl from here ...
3168 * lisp.h: ... to here, so that it can be checked.
3169
475545b5 3170 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3171 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3172 (lisp_indirect_variable): Name an expression,
3173 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3174 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3175
b1349114 3176 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3177 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3178 Use const pointer when appropriate.
b1349114 3179
a2928364
PE
3180 * lisp.h (get_system_name, get_operating_system_release):
3181 Move decls here, to check interfaces.
3182 * process.c (get_operating_system_release): Move decl to lisp.h.
3183 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3184 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3185 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3186 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3187 (Fformat_time_string, Fencode_time, Finsert_char):
3188 (Ftranslate_region_internal, Fformat):
3189 Rename or remove local vars to avoid shadowing.
9710023e 3190 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3191
a415e694
PE
3192 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3193 avoid shadowing.
3194
8ef4622d
PE
3195 * lisp.h (eassert): Check that the argument compiles, even if
3196 ENABLE_CHECKING is not defined.
3197
946f9a5b
PE
3198 * data.c (Findirect_variable): Name an expression, to avoid
3199 gcc -Wbad-function-cast warning.
112396d6 3200 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3201 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3202 (Fmake_variable_buffer_local, Fmake_local_variable):
3203 Mark variables as initialized.
52746918 3204 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3205
e5aab7e7 3206 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3207 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3208 Rename locals to avoid shadowing.
dff45157
PE
3209 (mark_stack): Move local variables into the #ifdef region where
3210 they're used.
7bc26fdb
PE
3211 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3212 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3213 needed otherwise.
3214 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3215 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3216 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3217
e5aab7e7
PE
3218 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3219 avoids undefined behavior in theory.
3220
4da60324
PE
3221 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3222
88043301
PE
3223 Use functions, not macros, for up- and down-casing (Bug#8254).
3224 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3225 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3226 to use the following functions instead of these macros.
3227 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3228 EMACS_INT, since callers assume the returned value fits in int.
3229 (upcase1): Likewise, for UPCASE_TABLE.
3230 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3231 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3232 the race-condition problem in the old DOWNCASE.
88043301 3233
19ed5445
PE
3234 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3235 Rename locals to avoid shadowing.
3236 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3237 (regex_compile, re_search_2, re_match_2_internal):
3238 Remove unused local vars.
952db0d7
PE
3239 (FREE_VAR): Rewrite so as not to use empty "else",
3240 which gcc can warn about.
da053e48 3241 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3242 (RETALLOC_IF): Define only if needed.
3243 (WORDCHAR_P): Likewise. This one is never needed, but is used
3244 only in a comment talking about a compiler bug, so put inside
3245 the #if 0 of that comment.
3246 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3247 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3248 Remove; unused.
19ed5445 3249
1f3561e4 3250 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3251 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3252 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3253
ded6f8f7
PE
3254 * search.c (simple_search): Remove unused var.
3255
dbd37a95
PE
3256 * dired.c (compile_pattern): Move decl from here ...
3257 * lisp.h: ... to here, so that it can be checked.
3258 (struct re_registers): New forward decl.
3259
7e47afad
PE
3260 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3261
85f24f61
PE
3262 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3263 All uses changed.
3264 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3265 Rename locals to avoid shadowing.
5671df8f 3266 (Fvertical_motion): Mark locals as initialized.
85f24f61 3267
181aa2be 3268 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3269 (casify_region): Mark local as initialized.
181aa2be 3270
930d429c
PE
3271 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3272
7082eac6
PE
3273 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3274 New macros, so that the caller can use some names other than
3275 gcpro1, gcpro2, etc.
3276 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3277 of the new macros.
3278 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3279 argument, for consistency with GCPRO2_VAR, etc: it is now the
3280 prefix of the variable, not the variable itself. All uses
3281 changed.
38b2c076
PE
3282 * dired.c (directory_files_internal, file_name_completion):
3283 Rename locals to avoid shadowing.
3284
15206ed9
PE
3285 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3286 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3287 dired.c's scmp function, had undefined behavior.
3288 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3289 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3290 * buffer.h: ... to here, because these macros use current_buffer,
3291 and the new implementation with inline functions needs to have
3292 current_buffer in scope now, rather than later when the macros
3293 are used.
3294 (downcase, upcase1): New static inline functions.
3295 (DOWNCASE, UPCASE1): Reimplement using these functions.
3296 This avoids undefined behavior in expressions like
3297 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3298 from race conditions in accessing the global variables
3299 case_temp1 and case_temp2.
3300 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3301 * lisp.h (case_temp1, case_temp2): Remove their decls.
3302 * character.h (ASCII_CHAR_P): Move from here ...
3303 * lisp.h: ... to here, so that the inline functions mentioned
3304 above can use them.
3305
4a6bea26
PE
3306 * dired.c (directory_files_internal_unwind): Now static.
3307
f14b7e14
PE
3308 * fileio.c (file_name_as_directory, directory_file_name):
3309 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3310 Now static.
2893f146
PE
3311 (file_name_as_directory): Use const pointers when appropriate.
3312 (Fexpand_file_name): Likewise. In particular, newdir might
3313 point at constant storage, so make it a const pointer.
fd4ead52 3314 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3315 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3316 signedness issues.
f839df0c
PE
3317 (Fset_file_times, Finsert_file_contents, auto_save_error):
3318 Rename locals to avoid shadowing.
f14b7e14 3319
5716756e 3320 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3321 (Ftry_completion, Fall_completions): Rename or remove locals
3322 to avoid shadowing.
5716756e 3323
b4c3046a
PE
3324 * marker.c (bytepos_to_charpos): Remove; unused.
3325
b45db522
PE
3326 * lisp.h (verify_bytepos, count_markers): New decls,
3327 so that gcc does not warn that these functions aren't declared.
3328
85876d07
PE
3329 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3330 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3331 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3332 (copy_text): Remove unused local var.
85876d07 3333
03d78a21 3334 * filelock.c (within_one_second): Now static.
b3dd38ab 3335 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3336
5df8f01b
PE
3337 * buffer.c (fix_overlays_before): Mark locals as initialized.
3338 (fix_start_end_in_overlays): Likewise. This function should be
3339 simplified by using pointers-to-pointers, but that's a different
3340 matter.
b1d876f1 3341 (switch_to_buffer_1): Now static.
8f54f30a
PE
3342 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3343 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3344
a70072c9 3345 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3346 Fix pointer signedness issue.
edced198
PE
3347 (sys_subshell): Mark local as volatile if checking for lint,
3348 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3349 (MAXPATHLEN): Define only if needed.
a70072c9 3350
a0977c44
PE
3351 * process.c (serial_open, serial_configure): Move decls from here ...
3352 * systty.h: ... to here, so that they can be checked.
3353
a884fdcc
PE
3354 * fns.c (get_random, seed_random): Move extern decls from here ...
3355 * lisp.h: ... to here, so that they can be checked.
3356
604efe86 3357 * sysdep.c (reset_io): Now static.
b8950c94 3358 (wait_for_termination_signal): Remove; unused.
604efe86 3359
38fc62d9
PE
3360 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3361 (copy_keymap_item, append_key, push_text_char_description):
3362 Now static.
1004a21a 3363 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3364 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3365 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3366 (describe_map_tree):
3367 Rename locals to avoid shadowing.
38fc62d9 3368
2f2650da
PE
3369 * keyboard.c: Declare functions static if they are not used elsewhere.
3370 (echo_char, echo_dash, cmd_error, top_level_2):
3371 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3372 (read_char, kbd_buffer_get_event, make_lispy_position):
3373 (make_lispy_event, make_lispy_movement, apply_modifiers):
3374 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3375 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3376 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3377 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3378 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3379
a053e86c 3380 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3381 (mark_kboards): Move decl here ...
3382 * alloc.c (mark_kboards): ... from here.
a053e86c 3383
4752793e
PE
3384 * lisp.h (force_auto_save_soon): New decl.
3385
74f10ca7 3386 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3387 (DEFINE_DUMMY_FUNCTION): New macro.
3388 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3389 Use it.
c03cd23f
PE
3390 (main): Add casts to avoid warnings
3391 if GCC considers string literals to be constants.
74f10ca7 3392
022e70d4
PE
3393 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3394
59d6fe83
PE
3395 * dbusbind.c: Pointer signedness fixes.
3396 (xd_signature, xd_append_arg, xd_initialize):
3397 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3398 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3399 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3400 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3401
78320123
PE
3402 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3403 if GCC considers string literals to be constants.
49cebcca 3404 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3405
35ac2a97
SM
34062011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3407
fb103ca9
SM
3408 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3409 (print_preprocess, print_object): New macro to fix last change.
3410
35ac2a97
SM
3411 * print.c (print_preprocess): Don't forget font objects.
3412
62973b41
JB
34132011-03-16 Juanma Barranquero <lekktu@gmail.com>
3414
3415 * emacs.c (USAGE3): Doc fixes.
3416
0e48bb22
AS
34172011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3418
3419 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3420 structure.
3421
7684e57b
JB
34222011-03-14 Juanma Barranquero <lekktu@gmail.com>
3423
3424 * lisp.h (VWindow_system, Qfile_name_history):
3425 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3426 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3427 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3428
3429 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3430 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3431
3432 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3433 * w32console.c (detect_input_pending, read_input_pending)
3434 (encode_terminal_code):
3435 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3436 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3437 (w32_system_caret_y, Qfile_name_history):
3438 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3439 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3440 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3441 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3442 * w32proc.c (Qlocal, report_file_error):
3443 * w32term.c (Vwindow_system, updating_frame):
3444 * w32uniscribe.c (initialized, uniscribe_font_driver):
3445 Remove unneeded extern declarations.
3446
2aa46d6c
CY
34472011-03-14 Chong Yidong <cyd@stupidchicken.com>
3448
c96bbc66 3449 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3450
cffc6f3b
CY
34512011-03-13 Chong Yidong <cyd@stupidchicken.com>
3452
3453 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3454 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3455 These macros can no longer be used for assignment.
3456
44f230aa
SM
3457 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3458 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3459 (record_buffer_markers, fetch_buffer_markers): New functions for
3460 recording and fetching special buffer markers.
3461 (set_buffer_internal_1, set_buffer_temp): Use them.
3462
3463 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3464
3465 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3466
3467 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3468 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3469
3470 * xdisp.c (hscroll_window_tree):
3471 (reconsider_clip_changes): Use PT instead of BUF_PT.
3472
d251f04b
EZ
34732011-03-13 Eli Zaretskii <eliz@gnu.org>
3474
3475 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3476 $(EMACS_ROOT)/lib/intprops.h.
3477
f0c77cd1
PE
34782011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3479
3eca4629
PE
3480 Fix more problems found by GCC 4.5.2's static checks.
3481
7c86ee98
PE
3482 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3483 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3484 (xg_free_frame_widgets): Make it clear that a local variable is
3485 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3486 (gdk_window_get_screen): Make it clear that this macro is needed
3487 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3488 (int_gtk_range_get_value): New function, which avoids a diagnostic
3489 from gcc -Wbad-function-cast.
3490 (xg_set_toolkit_scroll_bar_thumb): Use it.
3491 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3492 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3493 (get_utf8_string, xg_get_file_with_chooser):
3494 Rename locals to avoid shadowing.
3495 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3496
41729b81
PE
3497 * xgselect.c (xg_select): Remove unused var.
3498
f0c77cd1
PE
3499 * image.c (four_corners_best): Mark locals as initialized.
3500 (gif_load): Initialize transparent_p to zero (Bug#8238).
3501 Mark another local as initialized.
ec6cf4c6 3502 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3503
ce0ad53d 3504 * image.c (clear_image_cache): Now static.
d5d5a617 3505 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3506 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3507 (x_edge_detection): Remove unnecessary cast that
3508 gcc -Wbad-function-cast diagnoses.
2037898d 3509 (gif_load): Fix pointer signedness.
6ae141d6
PE
3510 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3511 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3512
33383987 35132011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3514
d32df629
PE
3515 Improve quality of tests for time stamp overflow.
3516 For example, without this patch (encode-time 0 0 0 1 1
3517 1152921504606846976) returns the obviously-bogus value (-948597
3518 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3519 reports time overflow. See
3520 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3521 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3522 * editfns.c: Include limits.h and intprops.h.
3523 (TIME_T_MIN, TIME_T_MAX): New macros.
3524 (time_overflow): Move earlier, to before first use.
3525 (hi_time, lo_time): New functions, for an accurate test for
3526 out-of-range times.
3527 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3528 (Fget_internal_run_time): Don't assume time_t fits in int.
3529 (make_time): Use list2 instead of Fcons twice.
3530 (Fdecode_time): More accurate test for out-of-range times.
3531 (check_tm_member): New function.
3532 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3533 (lisp_time_argument): Don't rely on undefined left-shift and
3534 right-shift behavior when checking for time stamp overflow.
8be6f318 3535
fe31d94c
PE
3536 * editfns.c (time_overflow): New function, refactoring common code.
3537 (Fformat_time_string, Fdecode_time, Fencode_time):
3538 (Fcurrent_time_string): Use it.
3539
8be6f318
PE
3540 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3541 * dired.c (make_time): Move to ...
3542 * editfns.c (make_time): ... here.
3543 * systime.h: Note the move.
3544
09d9db2c 35452011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3546
126bc0dc
YM
3547 * fringe.c (update_window_fringes): Remove unused variables.
3548
c47cbdfd
YM
3549 * unexmacosx.c (copy_data_segment): Also copy __got section.
3550 (Bug#8223)
3551
7ac80be9
EZ
35522011-03-12 Eli Zaretskii <eliz@gnu.org>
3553
c96bbc66 3554 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3555 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3556 Constify `char *' arguments and their references according to
3557 prototypes in tparam.h.
3558
ecb0f94d 3559 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3560
7ac80be9
EZ
3561 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3562 Adapt all references accordingly.
3563
3564 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3565
ef1fd07e
TT
35662011-03-11 Tom Tromey <tromey@redhat.com>
3567
3568 * buffer.c (syms_of_buffer): Remove obsolete comment.
3569
7ef4b50c
EZ
35702011-03-11 Eli Zaretskii <eliz@gnu.org>
3571
3572 * termhooks.h (encode_terminal_code): Declare prototype.
3573
3574 * msdos.c (encode_terminal_code): Don't declare prototype.
3575
3576 * term.c (encode_terminal_code): Now external again, used by
3577 w32console.c and msdos.c.
3578
44f230aa
SM
3579 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3580 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3581
4b1ec863 35822011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3583
1714f52b 3584 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3585
4b1ec863
PE
3586 * fringe.c (update_window_fringes): Mark locals as initialized
3587 (Bug#8227).
3588 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3589
524c7aa6
PE
3590 * alloc.c (mark_fringe_data): Move decl from here ...
3591 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3592 to check its interface.
3593 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3594
a5c0af81 3595 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3596 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3597 (fontset_font): Mark local as initialized.
a9a06e0b 3598 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3599
b4716021
PE
3600 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3601
811e9bac 3602 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3603 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3604 (x_own_selection, Fx_disown_selection_internal): Rename locals
3605 to avoid shadowing.
3606 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3607
7e3ab302
PE
3608 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3609 so that the caller can use some name other than gcpro1.
3610 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3611 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3612 (Fx_backspace_delete_keys_p):
3613 Use them to avoid shadowing, and rename vars to avoid shadowing.
3614 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3615 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3616 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3617 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3618 Remove unused locals.
7e3ab302
PE
3619 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3620 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3621 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3622 macros.
f78faa98 3623
e2b13473
PE
3624 * xterm.h (x_mouse_leave): New decl.
3625
77f23912
PE
3626 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3627 Remove unused functions.
cdf4ba58
PE
3628 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3629 (x_calc_absolute_position): Now static.
7411c686 3630 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3631 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3632 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3633 unless they are used.
38d0b34a
PE
3634 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3635 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3636 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3637 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3638 (x_error_catcher, x_connection_closed, x_error_handler):
3639 (x_error_quitter, xembed_send_message, x_iconify_frame):
3640 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3641 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3642 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3643
44f230aa
SM
3644 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3645 Rename or move locals to avoid shadowing.
6b463e58 3646 (tty_defined_color, merge_face_heights): Now static.
5967d051 3647 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3648 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3649 does not deduce is never used uninitialized.
73719eba
PE
3650 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3651 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3652
426994c3 3653 * terminal.c (store_terminal_param): Now static.
5489860b 3654
032f1620 3655 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3656 (set_frame_menubar): Remove unused local.
d4323972 3657 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3658 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3659 since they might point to immutable storage.
281585b0
PE
3660 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3661 since it's unused otherwise.
032f1620 3662
367c19e5 3663 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3664 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3665 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3666 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3667 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3668 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3669 does not deduce are never used uninitialized.
70739cbe 3670
07b48fa9
PE
3671 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3672
8868a238 3673 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3674 * window.c (window_loop, size_window):
3675 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3676
7e5cf297 3677 * window.c (display_buffer): Now static.
d6550a9f
PE
3678 (size_window): Mark variables that gcc -Wuninitialized
3679 does not deduce are never used uninitialized.
a586633d
PE
3680 * window.h (check_all_windows): New decl, to forestall
3681 gcc -Wmissing-prototypes diagnostic.
5b555da1 3682 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3683
f6095868
PE
3684 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3685 shadowing.
3686 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3687 Include <limits.h>.
3688 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3689 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3690 (load_charset_map): Mark variables that gcc -Wuninitialized
3691 does not deduce are never used uninitialized.
53df7c11 3692 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3693
f38b440c
PE
3694 * coding.c (coding_set_source, coding_set_destination):
3695 Use "else { /* comment */ }" rather than "else /* comment */;"
3696 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3697 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3698 a block, when the outer 'i' will do.
3699 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3700 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3701 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3702 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3703 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3704 Rename locals to avoid shadowing.
3705 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3706 * coding.c (emacs_mule_char, encode_invocation_designation):
3707 Now static, since they're not used elsewhere.
413bb2db 3708 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3709 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3710 (decode_coding_emacs_mule): Mark variables that gcc
3711 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3712 (detect_coding_iso_2022): Initialize a local variable that might
3713 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3714 this initialization is needed. (Bug#8211)
5f58e762
PE
3715 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3716 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3717 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3718 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3719 Remove unused macros.
f38b440c 3720
232b38b9 3721 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3722 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3723 * character.c (string_count_byte8): Likewise.
232b38b9 3724
fb90da1b
PE
3725 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3726 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3727
fb93dbc2
PE
3728 * chartab.c (copy_sub_char_table): Now static, since it's not used
3729 elsewhere.
5c156ace
PE
3730 (sub_char_table_ref_and_range, char_table_ref_and_range):
3731 Rename locals to avoid shadowing.
bbcd0949 3732 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3733
7d3b3862 3734 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3735 (BIDI_BOB): Remove unused macro.
7d3b3862 3736
6be7d3da
PE
3737 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3738 deduce are never used uninitialized.
c2ed9c8b 3739 * term.c (encode_terminal_code): Likewise.
6be7d3da 3740
75f8807f 3741 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3742
50938595
PE
3743 * tparam.h: New file.
3744 * term.c, tparam.h: Include it.
3745 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3746 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3747 Move these decls to tparam.h, and make them agree with what
3748 is actually in tparam.c. The previous trick of using incompatible
3749 decls in different modules does not conform to the C standard.
3750 All callers of tparam changed to use tparam's actual API.
3751 * tparam.c (tparam1, tparam, tgoto):
3752 Use const pointers where appropriate.
3753
fbceeba2
PE
3754 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3755 * cm.h (struct cm): Likewise.
3756 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3757 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3758 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3759 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3760 (turn_on_face, init_tty): Likewise.
3761 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3762
7f3f1250
PE
3763 * term.c (term_mouse_position): Rename local to avoid shadowing.
3764
e6ca6543
PE
3765 * alloc.c (mark_ttys): Move decl from here ...
3766 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3767
c40f8d15
AS
37682011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3769
3770 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3771
cfe0661d
JB
37722011-03-09 Juanma Barranquero <lekktu@gmail.com>
3773
3774 * search.c (compile_pattern_1): Remove argument regp, unused since
3775 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3776 (compile_pattern): Don't pass it.
3777
0afb4571
J
37782011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3779
3780 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3781 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3782 for ! HAVE_GTK3.
3783 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3784
3785 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3786
3787 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3788 gdk_window_get_screen, gdk_window_get_geometry,
3789 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3790 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3791 (xg_get_pixbuf_from_pixmap): New function.
3792 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3793 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3794 Call xg_get_pixbuf_from_pixmap instead of
3795 gdk_pixbuf_get_from_drawable.
3796 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3797 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3798 (xg_check_special_colors): Use GtkStyleContext and its functions
3799 for HAVE_GTK3.
3800 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3801 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3802 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3803 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3804 Call gtk_widget_get_preferred_size.
0afb4571
J
3805 (xg_frame_resized): gdk_window_get_geometry only takes 5
3806 parameters.
44f230aa
SM
3807 (xg_win_to_widget, xg_event_is_for_menubar):
3808 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3809 (xg_set_widget_bg): New function.
3810 (delete_cb): New function.
895009e1 3811 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3812 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3813 (xg_set_background_color): Call xg_set_widget_bg.
3814 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3815 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3816 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3817 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3818 if ! HAVE_GTK3.
3819 (update_frame_tool_bar): Call gtk_widget_hide.
3820 (xg_initialize): Use GDK_KEY_g.
3821
3822 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3823 if ! HAVE_GTK3
3824 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3825
3826 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3827 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3828 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3829
1c2cc4ef
JB
38302011-03-08 Juanma Barranquero <lekktu@gmail.com>
3831
3832 * w32xfns.c (select_palette): Check success of RealizePalette against
3833 GDI_ERROR, not zero.
3834
33383987 3835See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3836
3837;; Local Variables:
3838;; coding: utf-8
aac0c6e3
MR
3839;; End:
3840
33383987 3841 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3842
3843 This file is part of GNU Emacs.
3844
3845 GNU Emacs is free software: you can redistribute it and/or modify
3846 it under the terms of the GNU General Public License as published by
3847 the Free Software Foundation, either version 3 of the License, or
3848 (at your option) any later version.
3849
3850 GNU Emacs is distributed in the hope that it will be useful,
3851 but WITHOUT ANY WARRANTY; without even the implied warranty of
3852 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3853 GNU General Public License for more details.
3854
3855 You should have received a copy of the GNU General Public License
3856 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.