* alloc.c: Simplify handling of large-request failures (Bug#8800).
[bpt/emacs.git] / src / ChangeLog
CommitLineData
2b6148e4
PE
12011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2
3 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4 (SPARE_MEMORY): Always define.
5 (LARGE_REQUEST): Remove.
6 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7
f230ecc9
MR
82011-06-06 Martin Rudalics <rudalics@gmx.at>
9
727e958e
MR
10 * lisp.h: Move EXFUNS for Fframe_root_window,
11 Fframe_first_window and Fset_frame_selected_window to window.h.
12
13 * window.h: Move EXFUNS for Fframe_root_window,
14 Fframe_first_window and Fset_frame_selected_window here from
15 lisp.h.
16
17 * frame.c (Fwindow_frame, Fframe_first_window)
18 (Fframe_root_window, Fframe_selected_window)
19 (Fset_frame_selected_window): Move to window.c.
20 (Factive_minibuffer_window): Move to minibuf.c.
21 (Fother_visible_frames_p): New function.
22
23 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
24
f230ecc9
MR
25 * window.c (decode_window, decode_any_window): Move up in code.
26 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
27 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
28 (Fwindow_buffer): Move up and rewrite doc-string.
29 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
30 (Fwindow_prev): New functions.
727e958e
MR
31 (Fwindow_frame): Move here from frame.c. Accept any window as
32 argument.
33 (Fframe_root_window, Fframe_first_window)
34 (Fframe_selected_window): Move here from frame.c. Accept frame
35 or arbitrary window as argument. Update doc-strings.
36 (Fminibuffer_window): Move up in code.
37 (Fwindow_minibuffer_p): Move up in code and simplify.
38 (Fset_frame_selected_window): Move here from frame.c. Marginal
39 rewrite.
40 (Fselected_window, select_window, Fselect_window): Move up in
41 code. Minor doc-string fixes.
f230ecc9 42
4d09bcf6
PE
432011-06-06 Paul Eggert <eggert@cs.ucla.edu>
44
45 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
46 Do not assume that spare memory exists; that assumption is valid
47 only if SYSTEM_MALLOC.
48 (LARGE_REQUEST): New macro, so that the issue of large requests
49 is separated from the issue of spare memory.
50
810928a2
AS
512011-06-05 Andreas Schwab <schwab@linux-m68k.org>
52
172418ad
AS
53 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
54 format. (Bug#8806)
55
43f862f7
AS
56 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
57
810928a2
AS
58 * xfns.c (x_set_scroll_bar_default_width): Move declarations
59 before statements.
60
a059fe24
JD
612011-06-05 Jan Djärv <jan.h.d@swipnet.se>
62
63 * gtkutil.c (xg_get_default_scrollbar_width): New function.
64
65 * gtkutil.h: Declare xg_get_default_scrollbar_width.
66
67 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
68 min width by calling x_set_scroll_bar_default_width (Bug#8505).
69
989bf368
JB
702011-06-05 Juanma Barranquero <lekktu@gmail.com>
71
72 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
73
4b80f674
CY
742011-06-04 Chong Yidong <cyd@stupidchicken.com>
75
76 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
77 (x_clipboard_manager_save): Add return value.
78 (x_clipboard_manager_error_1, x_clipboard_manager_error_2): New
79 error handlers.
80 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
81 Obey Vx_select_enable_clipboard_manager. Catch errors in
82 x_clipboard_manager_save (Bug#8779).
83 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 84 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 85
99a33b77 862011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
87
88 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
89
99a33b77 902011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
91
92 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
93 in the current matrix if keep_current_p is non-zero.
94
8264569d
EZ
952011-06-04 Eli Zaretskii <eliz@gnu.org>
96
97 * bidi.c (bidi_level_of_next_char): Fix last change.
98
57f97249
EZ
992011-06-03 Eli Zaretskii <eliz@gnu.org>
100
fec2107c 101 Support bidi reordering of text covered by display properties.
57f97249 102
fec2107c
EZ
103 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
104 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
105 (bidi_cache_search, bidi_cache_iterator_state)
106 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
107 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
108 character positions inside a run of characters covered by a
109 display string.
110 (bidi_paragraph_init, bidi_resolve_explicit_1)
111 (bidi_level_of_next_char): Call bidi_fetch_char and
112 bidi_fetch_char_advance instead of FETCH_CHAR and
113 FETCH_CHAR_ADVANCE.
114 (bidi_init_it): Initialize new members.
115 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
116 definitions.
117 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
118 instead of using explicit *_CHAR codes.
119 (bidi_resolve_explicit, bidi_resolve_weak): Use
120 FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
121 bidirectional text is supported only in multibyte buffers.
122 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
123 it to initialize the frame_window_p member of struct bidi_it.
124 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
125 (bidi_resolve_explicit, bidi_resolve_weak)
126 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
127 bidi_it->nchars is non-positive.
128 (bidi_level_of_next_char): Don't try to lookup the cache for the
129 next/previous character if nothing is cached there yet, or if we
130 were just reseat()'ed to a new position.
c40e2fb2 131
0e14fe90
EZ
132 * xdisp.c (set_cursor_from_row): Set start and stop points
133 according to the row's direction when priming the loop that looks
134 for the glyph on which to display cursor.
135 (single_display_spec_intangible_p): Function deleted.
136 (display_prop_intangible_p): Reimplement to call
137 handle_display_spec instead of single_display_spec_intangible_p.
138 Accept 3 additional arguments needed by handle_display_spec. This
139 fixes incorrect cursor motion across display property with complex
140 values: lists, `(when COND...)' forms, etc.
141 (single_display_spec_string_p): Support property values that are
142 lists with the argument STRING its top-level element.
143 (display_prop_string_p): Fix the condition for processing a
144 property that is a list to be consistent with handle_display_spec.
fec2107c 145 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
146 last portion of handle_display_prop.
147 (compute_display_string_pos): Accept additional argument
148 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
149 value of a `display' property is a "replacing spec".
150 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
151 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
152 the display property, but just return a value indicating whether
153 the display property will replace the characters it covers.
154 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
155 frame_window_p members of struct bidi_it.
fec2107c
EZ
156 (compute_display_string_pos, compute_display_string_end): New
157 functions.
158 (push_it): Accept second argument POSITION, where pop_it should
159 jump to continue iteration.
160 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 161
fec2107c
EZ
162 * keyboard.c (adjust_point_for_property): Adjust the call to
163 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
164
165 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
166 (bidi_init_it): Update prototypes.
167 (display_prop_intangible_p): Update prototype.
168 (compute_display_string_pos, compute_display_string_end): Declare
169 prototypes.
170 (struct bidi_it): New members nchars and disp_pos. ch_len is now
171 EMACS_INT.
fc6f18ce 172
40087514 1732011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 174
57f53182
PE
175 Malloc failure behavior now depends on size of allocation.
176 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
177 * lisp.h: Change signatures accordingly.
178 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
179 All callers changed. (Bug#8762)
180
181 * gnutls.c: Use Emacs's memory allocators.
182 Without this change, the gnutls library would invoke malloc etc.
183 directly, which causes problems on non-SYNC_INPUT hosts, and which
184 runs afoul of improving memory_full behavior. (Bug#8761)
185 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
186 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
187 xfree instead of the default malloc, realloc, free.
188 (Fgnutls_boot): No need to check for memory allocation failure,
189 since xmalloc does that for us.
190
ac32cd99 191 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
192 * category.c (hash_get_category_set):
193 * ccl.c (ccl_driver):
194 * charset.c (Fdefine_charset_internal):
195 * charset.h (struct charset.hash_index):
196 * composite.c (get_composition_id, gstring_lookup_cache)
197 (composition_gstring_put_cache):
198 * composite.h (struct composition.hash_index):
199 * dispextern.h (struct image.hash):
200 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
201 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
202 (hashfn_equal, hashfn_user_defined, make_hash_table)
203 (maybe_resize_hash_table, hash_lookup, hash_put)
204 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
205 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
206 (Fsxhash, Fgethash, Fputhash, Fmaphash):
207 * image.c (make_image, search_image_cache, lookup_image)
208 (xpm_put_color_table_h):
209 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 210 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
211 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
212 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
213 * alloc.c (allocate_vectorlike):
214 Check for overflow in vector size calculations.
215 * ccl.c (ccl_driver):
216 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
217 * fns.c, image.c: Remove unnecessary static decls that would otherwise
218 need to be updated by these changes.
40087514
PE
219 * fns.c (make_hash_table, maybe_resize_hash_table):
220 Check for integer overflow with large hash tables.
0de4bb68
PE
221 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
222 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
223 (SXHASH_REDUCE): New macro.
224 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
225 Use it instead of discarding useful hash info with large hash values.
226 (sxhash_float): New function.
227 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
228 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
229 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
230 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
231 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
232 Adjust signatures to match updated version of code.
233 (consing_since_gc): Now EMACS_INT, since a single hash table can
234 use more than INT_MAX bytes.
235
698d32e2
DN
2362011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
237
238 Make it possible to build with GCC-4.6+ -O2 -flto.
239
240 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
241
fd6fa53f
SM
2422011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
243
244 * minibuf.c (get_minibuffer, read_minibuf_unwind):
245 Call minibuffer-inactive-mode.
246
864db017
JB
2472011-05-31 Juanma Barranquero <lekktu@gmail.com>
248
249 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
250 Update dependencies.
251
2ad0baf4
DN
2522011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
253
254 * data.c (init_data): Remove code for UTS, this system is not
255 supported anymore.
256
4fcc2638
DN
2572011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
258
259 Don't force ./temacs to start in terminal mode.
260
261 * frame.c (make_initial_frame): Initialize faces in all cases, not
262 only when CANNOT_DUMP is defined.
263 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
264
c56e0fd5
DN
2652011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
266
267 * dispnew.c (add_window_display_history): Use const for the string
268 pointer. Remove declaration, not needed.
269
333d54da 2702011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 271
55d4c1b2 272 Use 'inline', not 'INLINE'.
333d54da 273 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
274 * alloc.c, fontset.c (INLINE): Remove.
275 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
276 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
277 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
278 * gmalloc.c (register_heapinfo): Use inline unconditionally.
279 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
280
738db178
DN
2812011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
282
283 Make it possible to run ./temacs.
284
285 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
286 syms_of_callproc does the same thing. Remove test for
287 "initialized", do it in the caller.
288 * emacs.c (main): Avoid calling set_initial_environment when dumping.
289
620c53a6
SM
2902011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
291
292 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
293 (read_minibuf): Use get_minibuffer.
294 (syms_of_minibuf): Use DEFSYM.
295 (Qmetadata): New var.
296 * data.c (Qbuffer): Don't make it static.
297 (syms_of_data): Use DEFSYM.
298
e003a292
PE
2992011-05-31 Paul Eggert <eggert@cs.ucla.edu>
300
301 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
302 (CCL_CODE_MIN): New macro.
303
ed008a6d
PE
3042011-05-30 Paul Eggert <eggert@cs.ucla.edu>
305
3687c2ef
PE
306 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
307
ed008a6d
PE
308 * eval.c (Qdebug): Now static.
309 * lisp.h (Qdebug): Remove decl. This reverts a part of the
310 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
311 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
312
d66c4c7c
CY
3132011-05-29 Chong Yidong <cyd@stupidchicken.com>
314
315 * image.c: Various fixes to ImageMagick code comments.
316 (Fimagemagick_types): Doc fix.
317
5fbc2025
PE
3182011-05-29 Paul Eggert <eggert@cs.ucla.edu>
319
0196f88a
PE
320 Minor fixes prompted by GCC 4.6.0 warnings.
321
322 * xselect.c (converted_selections, conversion_fail_tag): Now static.
323
5fbc2025
PE
324 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
325 (x_clipboard_manager_save_all): Move extern decl to ...
326 * xterm.h: ... here, so that it can be checked for consistency.
327
1dd3c2d9
CY
3282011-05-29 Chong Yidong <cyd@stupidchicken.com>
329
330 * xselect.c (x_clipboard_manager_save_frame)
331 (x_clipboard_manager_save_all): New functions.
332 (Fx_clipboard_manager_save): Lisp function deleted.
333
334 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
335 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
336
337 * xterm.h: Update prototype.
338
5ba6571d
WX
3392011-05-28 William Xu <william.xwl@gmail.com>
340
341 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
342 exiting (Bug#8239).
343
3eaff834
JM
3442011-05-28 Jim Meyering <meyering@redhat.com>
345
e1900994 346 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
347 * fns.c (to_uchar): Define.
348 (crypto_hash_function): Use it to convert some newly-signed
349 variables to unsigned, to avoid sign-extension bugs. For example,
350 without this change, (md5 "truc") would evaluate to
351 45723a2aff78ff4fff7fff1114760e62 rather than the expected
352 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 353 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 354
0f6990a7
PE
3552011-05-27 Paul Eggert <eggert@cs.ucla.edu>
356
357 Integer overflow fixes.
c8a9ca5a 358
08686060
PE
359 * dbusbind.c: Serial number integer overflow fixes.
360 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
361 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
362 to hold a serial number that is too large for a fixnum.
363 (Fdbus_method_return_internal, Fdbus_method_error_internal):
364 Check for serial numbers out of range. Decode any serial number
59568bf0 365 that was so large that it became a float. (Bug#8722)
08686060 366
2d1fc3c7
PE
367 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
368 (Fdbus_call_method, Fdbus_call_method_asynchronously):
369 Use XFASTINT rather than XUINT when numbers are nonnegative.
370 (xd_append_arg, Fdbus_method_return_internal):
371 (Fdbus_method_error_internal): Likewise. Also, for unsigned
372 arguments, check that Lisp number is nonnegative, rather than
59568bf0 373 silently wrapping negative numbers around. (Bug#8722)
30217ff0 374 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 375 (Bug#8722)
2d1fc3c7 376
c8a9ca5a
PE
377 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
378
519e1d69
PE
379 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
380
30569699
PE
381 ccl: add integer overflow checks
382 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
383 (IN_INT_RANGE): New macros.
384 (ccl_driver): Use them to check for integer overflow when
385 decoding a CCL program. Many of the new checks are whether XINT (x)
386 fits in int; it doesn't always, on 64-bit hosts. The new version
387 doesn't catch all possible integer overflows, but it's an
847044ea 388 improvement. (Bug#8719)
30569699 389
c11285dc
PE
390 * alloc.c (make_event_array): Use XINT, not XUINT.
391 There's no need for unsigned here.
392
fdccd48e
PE
393 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
394 This follows up to the 2011-05-06 change that substituted uintptr_t
395 for EMACS_INT. This case wasn't caught back then.
396
37910ab2
PE
397 Rework Fformat to avoid integer overflow issues.
398 * editfns.c: Include <float.h> unconditionally, as it's everywhere
399 now (part of C89). Include <verify.h>.
400 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
401 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
402 (Fformat): Avoid the prepass trying to compute sizes; it was only
403 approximate and thus did not catch overflow reliably. Instead, walk
404 through the format just once, formatting and computing sizes as we go,
405 checking for integer overflow at every step, and allocating a larger
406 buffer as needed. Keep track separately whether the format is
407 multibyte. Keep only the most-recently calculated precision, rather
408 than them all. Record whether each argument has been converted to
409 string. Use EMACS_INT, not int, for byte and char and arg counts.
410 Support field widths and precisions larger than INT_MAX. Avoid
411 sprintf's undefined behavior with conversion specifications such as %#d
412 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
413 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
414 formatting out-of-range floating point numbers with int
415 formats. (Bug#8668)
416
2e6578fb
PE
417 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
418
0ae6bdee
PE
419 * data.c: Avoid integer truncation in expressions involving floats.
420 * data.c: Include <intprops.h>.
421 (arith_driver): When there's an integer overflow in an expression
422 involving floating point, convert the integers to floating point
423 so that the resulting value does not suffer from catastrophic
424 integer truncation. For example, on a 64-bit host (* 4
425 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
426 Do not rely on undefined behavior after integer overflow.
427
de883a70
PE
428 merge count_size_as_multibyte, parse_str_to_multibyte
429 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 430 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
431 Check for integer overflow.
432 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
433 since it's now a duplicate of the other. This is more of
434 a character than a buffer op, so better that it's in character.c.
435 * fns.c, print.c: Adjust to above changes.
436
2ff916cb
PE
4372011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
438
439 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
440
f1b54466
PE
4412011-05-27 Paul Eggert <eggert@cs.ucla.edu>
442
fb1ac845
PE
443 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
444 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
445 (x_clipboard_manager_save): Now static.
446 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
447
f1b54466
PE
448 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
449 (crypto_hash_function): Now static.
450 Fix pointer signedness problems. Avoid unnecessary initializations.
451
a9f737ee
CY
4522011-05-27 Chong Yidong <cyd@stupidchicken.com>
453
454 * termhooks.h (Vselection_alist): Make it terminal-local.
455
456 * terminal.c (create_terminal): Initialize it.
457
458 * xselect.c: Support for clipboard managers.
459 (Vselection_alist): Move to termhooks.h as terminal-local var.
460 (LOCAL_SELECTION): New macro.
461 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
462 (symbol_to_x_atom): Remove gratuitous arg.
463 (x_handle_selection_request, lisp_data_to_selection_data)
464 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
465 (x_own_selection, x_get_local_selection, x_convert_selection):
466 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
467 (some_frame_on_display): Delete unused function.
468 (Fx_own_selection_internal, Fx_get_selection_internal)
469 (Fx_disown_selection_internal, Fx_selection_owner_p)
470 (Fx_selection_exists_p): New optional frame arg.
471 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
472 (x_handle_selection_clear): Don't treat other terminals with the
473 same keyboard specially. Use the terminal-local Vselection_alist.
474 (x_clear_frame_selections): Use Frun_hook_with_args.
475
476 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
477
478 * xterm.h: Add support for those atoms.
479
e067f0c1
CY
4802011-05-26 Chong Yidong <cyd@stupidchicken.com>
481
482 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
483 (converted_selections, conversion_fail_tag): New global variables.
484 (x_selection_request_lisp_error): Free the above.
485 (x_get_local_selection): Remove unnecessary code.
486 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
487 of converted selections stored in converted_selections.
488 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
489 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
490 (x_convert_selection): New function.
491 (x_handle_selection_event): Simplify.
492 (x_get_foreign_selection): Don't ignore incoming requests while
493 waiting for an answer; this will fail when we implement
494 SAVE_TARGETS, and seems unnecessary anyway.
495 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
496 (Vx_sent_selection_functions): Doc fix.
497
0f4aebc0
LL
4982011-05-26 Leo Liu <sdl.web@gmail.com>
499
500 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
501
e61124cd
YM
5022011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
503
504 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
505
506 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
507 for fringe update if it has periodic bitmap.
508 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
509 and fringe_bitmap_periodic_p.
510
511 * fringe.c (get_fringe_bitmap_data): New function.
512 (draw_fringe_bitmap_1, update_window_fringes): Use it.
513 (update_window_fringes): Record periodicity of fringe bitmap in glyph
514 row. Mark glyph row for fringe update if periodicity changed.
515
516 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
517 for fringe update unless it has periodic bitmap.
518
f16d9837
KH
5192011-05-25 Kenichi Handa <handa@m17n.org>
520
521 * xdisp.c (get_next_display_element): Set correct it->face_id for
522 a static composition.
523
e1b90ef6
LL
5242011-05-24 Leo Liu <sdl.web@gmail.com>
525
526 * deps.mk (fns.o):
527 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
528
529 * fns.c (crypto_hash_function, Fsha1): New function.
530 (Fmd5): Use crypto_hash_function.
531 (syms_of_fns): Add Ssha1.
532
7400048f
PE
5332011-05-22 Paul Eggert <eggert@cs.ucla.edu>
534
535 * gnutls.c: Remove unused macros.
536 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
537 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
538 Remove macros that are defined and never used.
539 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
540
abb71cf4
CY
5412011-05-22 Chong Yidong <cyd@stupidchicken.com>
542
543 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
544 (Fx_get_selection_internal): Minor cleanup.
545 (Fx_own_selection_internal): Rename arguments for consistency with
546 select.el.
547
6307db39
PE
5482011-05-22 Paul Eggert <eggert@cs.ucla.edu>
549
550 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
551
f3d4e0a4
CY
5522011-05-22 Chong Yidong <cyd@stupidchicken.com>
553
554 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
555
4d8ade89
YM
5562011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
557
558 * dispnew.c (scrolling_window): Don't exclude the case that the
559 last enabled row in the desired matrix touches the bottom boundary.
560
32078c8d
GM
5612011-05-21 Glenn Morris <rgm@gnu.org>
562
563 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
564 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
565 and add some more files.
32078c8d 566
7285dc67
EZ
5672011-05-20 Eli Zaretskii <eliz@gnu.org>
568
569 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
570 report_file_error introduced by the change from 2011-05-07.
571
89d1bd22
PE
5722011-05-20 Paul Eggert <eggert@cs.ucla.edu>
573
574 * systime.h (Time): Define only if emacs is defined.
575 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
576 where the include path doesn't have X11/X.h by default. See
577 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
578
e23640bb 5792011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
580
581 * composite.c (find_automatic_composition): Fix previous change.
582
b9704ad9
GM
5832011-05-20 Glenn Morris <rgm@gnu.org>
584
585 * lisp.mk: New file, split from Makefile.in.
586 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
587 (shortlisp): Remove.
588 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
589
4a720484
GM
5902011-05-19 Glenn Morris <rgm@gnu.org>
591
592 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
593 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
594 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
595 (lisp): Set the order to that of loadup.el.
596 (shortlisp): Make it a copy of $lisp.
597 (SOME_MACHINE_LISP): Remove.
598 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
599 Use just $shortlisp, not $SOME_MACHINE_LISP too.
600
a28d4396
KH
6012011-05-18 Kenichi Handa <handa@m17n.org>
602
603 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
604 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
605 (find_automatic_composition): Mostly rewrite for efficiency.
606
a2b1fa8e
JB
6072011-05-18 Juanma Barranquero <lekktu@gmail.com>
608
609 * makefile.w32-in: Update dependencies.
610
8e1f5610
CS
6112011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
612
613 * menu.c: Include limits.h (fixes the MS-Windows build broken by
614 revision 104625).
615
7025ee00 6162011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 617
cdfa6eab
PE
618 Fix some integer overflow issues, such as string length overflow.
619
06d6db33
PE
620 * insdel.c (count_size_as_multibyte): Check for string overflow.
621
2b4560a8
PE
622 * character.c (lisp_string_width): Check for string overflow.
623 Use EMACS_INT, not int, for string indexes and lengths; in
624 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
625 the resulting string length overflows an EMACS_INT; instead,
626 report a string overflow if no precision given. When checking for
627 precision exhaustion, use a check that cannot possibly have
628 integer overflow. (Bug#8675)
629 * character.h (lisp_string_width): Adjust to new signature.
630
cb93f9be
PE
631 * alloc.c (string_overflow): New function.
632 (Fmake_string): Use it. This doesn't change behavior, but saves
633 a few bytes and will simplify future changes.
634 * character.c (string_escape_byte8): Likewise.
635 * lisp.h (string_overflow): New decl.
636
1a1f3366
PE
637 Fixups, following up to the user-interface timestamp change.
638 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
639 for UI timestamps, instead of unsigned long.
9fbd6841
PE
640 * msdos.c (mouse_get_pos): Likewise.
641 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
642 * w32gui.h (Time): Define by including "systime.h" rather than by
643 declaring it ourselves. (Bug#8664)
644
d4e3e4d3
PE
645 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
646 * image.c (clear_image_cache): Likewise.
647
f6a24d19
PE
648 * term.c (term_mouse_position): Don't assume time_t wraparound.
649
08dc5ae6
PE
650 Be more systematic about user-interface timestamps.
651 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
652 and sometimes 'EMACS_UINT', to represent these timestamps.
653 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
654 This makes the code easier to follow, and makes it easier to catch
655 integer overflow bugs such as Bug#8664.
656 * frame.c (Fmouse_position, Fmouse_pixel_position):
657 Use Time, not unsigned long, for user-interface timestamps.
658 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
659 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
660 * keyboard.h (last_event_timestamp): Likewise.
661 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
662 * menu.h (xmenu_show): Likewise.
663 * term.c (term_mouse_position): Likewise.
664 * termhooks.h (struct input_event.timestamp): Likewise.
665 (struct terminal.mouse_position_hook): Likewise.
666 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
667 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
668 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
669 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
670 what it was before.
671 * menu.h, termhooks.h: Include "systime.h", for Time.
672
8e55734a
PE
673 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
674 Don't assume that the difference between two unsigned long values
675 can fit into an integer. At this point, we know button_down_time
676 <= event->timestamp, so the difference must be nonnegative, so
677 there's no need to cast the result if double-click-time is
678 nonnegative, as it should be; check that it's nonnegative, just in
679 case. This bug is triggered when events are more than 2**31 ms
86db42d2 680 apart (about 25 days). (Bug#8664)
8e55734a 681
841f1b75 682 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 683 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 684
3e26f69c
PE
685 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
686 that always fit in int. Use a sentinel instead of a counter, to
687 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
688 * frame.h (struct frame): Use int for menu_bar_items_used
689 instead of EMACS_INT, since it always fits in int.
3e26f69c 690
5cc152c0
PE
691 * menu.c (grow_menu_items): Check for int overflow.
692
d89eb65e
PE
693 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
694
5235bd3e
PE
695 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
696 Before, the code was not consistent. These values cannot exceed
697 2**31 - 1 so there's no need to make them unsigned.
698 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
699 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
700 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
701 as modifiers.
702 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
703
bc827e23
PE
704 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
705 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
706 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
707 presumably because the widths might not match.
708
78eb494e
PE
709 * window.c (size_window): Avoid needless test at loop start.
710
04f2d78b
CB
7112011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
712
713 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
714
d2fc7e3d 7152011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
716
717 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
718
d2fc7e3d 7192011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
720
721 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
722 `width' to `bar_area_x' and `bar_area_width', respectively.
723 (x_scroll_run): Take account of fringe background extension.
724
04f2d78b
CB
725 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
726 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
727 `bar_area_width', respectively.
728 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
729 background extension.
730
79b70037
GM
7312011-05-10 Jim Meyering <meyering@redhat.com>
732
733 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
734
2f142cc5
JB
7352011-05-10 Juanma Barranquero <lekktu@gmail.com>
736
737 * image.c (Finit_image_library): Return t for built-in image types,
738 like pbm and xbm. (Bug#8640)
739
57679c86
AS
7402011-05-09 Andreas Schwab <schwab@linux-m68k.org>
741
742 * w32menu.c (set_frame_menubar): Fix submenu allocation.
743
888c9e86
EZ
7442011-05-07 Eli Zaretskii <eliz@gnu.org>
745
b0512a1d
EZ
746 * w32console.c (Fset_screen_color): Doc fix.
747 (Fget_screen_color): New function.
748 (syms_of_ntterm): Defsubr it.
749
7285dc67
EZ
750 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
751 unlink the temporary file if Fcall_process didn't create it in the
752 first place.
753 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
754 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
755 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
756 cue to call_process_cleanup not to close that handle.
757
4d3fcc8e
BK
7582011-05-07 Ben Key <bkey76@gmail.com>
759
760 * makefile.w32-in: The bootstrap-temacs rule now makes use of
761 one of two shell specific rules, either bootstrap-temacs-CMD or
762 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
763 to the previous implementation of the bootstrap-temacs rule.
764 The bootstrap-temacs-CMD rule is similar to the previous
765 implementation of the bootstrap-temacs rule except that it
766 makes use of the ESC_CFLAGS variable instead of the CFLAGS
767 variable.
768
769 These changes, along with some changes to nt/configure.bat,
770 nt/gmake.defs, and nt/nmake.defs, are required to extend my
771 earlier fix to add support for --cflags and --ldflags options
772 that include quotes so that it works whether make uses cmd or
773 sh as the shell.
774
b4289b64
MA
7752011-05-06 Michael Albinus <michael.albinus@gmx.de>
776
777 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
778 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
779 is a constant.
780 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
781 a string. Handle both cases.
782 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
783 (Fdbus_register_method): Use Qinvalid_function.
784
af4c0e28
JB
7852011-05-06 Juanma Barranquero <lekktu@gmail.com>
786
787 * makefile.w32-in: Update dependencies.
788 (LISP_H): Add inttypes.h and stdin.h.
789 (PROCESS_H): Add unistd.h.
790
c51453d9
EZ
7912011-05-06 Eli Zaretskii <eliz@gnu.org>
792
793 * lread.c: Include limits.h (fixes the MS-Windows build broken by
794 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
795
8ff0ac3c 7962011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 797
4c4b566b
PE
798 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
799
aab2b9b5
PE
800 * term.c (vfatal): Remove stray call to va_end.
801 It's not needed and the C Standard doesn't allow it here anyway.
802
c378da0b
PE
803 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
804 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
805
288b08c7
PE
806 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
807 bytes.
808
e3601888
PE
809 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
810
db6c0e74
PE
811 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
812
dd5963ea
PE
813 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
814
88c9450f
PE
815 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
816
2f9442b8
PE
817 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
818
c032b5f8
PE
819 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
820 * charset.c (Fdefine_charset_internal): Don't initialize
821 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 822 32-bit int (Bug#8600).
a108c10b
PE
823
824 * lread.c (read_integer): Be more consistent with string-to-number.
825 Use string_to_number to do the actual conversion; this avoids
826 rounding errors and fixes some other screwups. Without this fix,
827 for example, #x1fffffffffffffff was misread as -2305843009213693952.
828 (digit_to_number): Move earlier, for benefit of read_integer.
829 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 830 not a digit in any supported base. (Bug#8602)
a108c10b 831
ad5f9eea
PE
832 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
833
aec1708a
PE
834 * dispnew.c (scrolling_window): Return 1 if we scrolled,
835 to match comment at start of function. This also removes a
836 GCC warning about overflow in a 32+64-bit port.
837
47be4ab5
PE
838 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
839
371cac43
PE
840 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
841 Reported by Stefan Monnier in
842 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
843 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
844 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 845
d01a7826
PE
846 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
847 (EMACS_UINTPTR): Likewise, with uintptr_t.
848
7fd47d5c
PE
849 * lisp.h: Prefer 64-bit EMACS_INT if available.
850 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
851 on 32-bit hosts that have 64-bit int, so that they can access
852 large files.
122b0c86
PE
853 However, temporarily disable this change unless the temporary
854 symbol WIDE_EMACS_INT is defined.
7fd47d5c 855
8727937b
PE
856 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
857
8ac068ac
PE
858 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
859 This removes an assumption that EMACS_INT and long are the same
860 width as pointers. The assumption is true for Emacs porting targets
861 now, but we want to make other targets possible.
862 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
863 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
864 In the rest of the code, change types of integers that hold casted
865 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
866 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
867 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
868 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
869 No need to cast type when ORing.
870 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
871 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
872 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
873 assume EMACS_INT is the same width as char *.
874 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
875 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
876 Remove no-longer-needed casts.
877 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
878 (xg_tool_bar_help_callback, xg_make_tool_item):
879 Use EMACS_INTPTR to hold an integer
880 that will be cast to void *; this can avoid a GCC warning
881 if EMACS_INT is not the same width as void *.
882 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
883 * xdisp.c (display_echo_area_1, resize_mini_window_1):
884 (current_message_1, set_message_1):
885 Use a local to convert to proper width without a cast.
886 * xmenu.c (dialog_selection_callback): Likewise.
887
ede49d71
PE
888 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
889 Also, don't assume VALBITS / RAND_BITS is less than 5,
890 and don't rely on undefined behavior when shifting a 1 left into
891 the sign bit.
892 * lisp.h (get_random): Change signature to match.
893
2f30ecd0
PE
894 * lread.c (hash_string): Use size_t, not int, for hash computation.
895 Normally we prefer signed values; but hashing is special, because
896 it's better to use unsigned division on hash table sizes so that
897 the remainder is nonnegative. Also, size_t is the natural width
898 for hashing into memory. The previous code used 'int', which doesn't
899 retain enough info to hash well into very large tables.
900 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
901
2a866e7b
PE
902 * dbusbind.c: Don't possibly lose pointer info when converting.
903 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
904 Use XPNTR rather than XHASH, so that the high-order bits of
905 the pointer aren't lost when converting through void *.
906
51639eac
PE
907 * eval.c (Fautoload): Don't double-shift a pointer.
908
92394119
PE
909 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
910
dbdb9a7c
JB
9112011-05-06 Juanma Barranquero <lekktu@gmail.com>
912
913 * gnutls.c (DEF_GNUTLS_FN):
914 * image.c (DEF_IMGLIB_FN): Make function pointers static.
915
db7a0b4f
AS
9162011-05-05 Andreas Schwab <schwab@linux-m68k.org>
917
918 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
919 marker. (Bug#8610)
920
f7ff1b0f 9212011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
922
923 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
924 New version that can reserve upto 2GB of heap space.
925
f7ff1b0f 9262011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
927
928 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
929
639c109b
TZ
9302011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
931
932 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
933 `gnutls_certificate_set_x509_key_file'.
934
d2127135
JB
9352011-05-05 Juanma Barranquero <lekktu@gmail.com>
936
937 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
938 Update dependencies.
939
e968f4f3
JB
9402011-05-04 Juanma Barranquero <lekktu@gmail.com>
941
942 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
943 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
944 Remove unused parameter `fildes'.
945 * process.c (read_process_output, send_process): Don't pass it.
946
84d358f0
JB
9472011-05-04 Juanma Barranquero <lekktu@gmail.com>
948
949 Fix previous change: the library cache is defined in w32.c.
950 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
951 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
952
0898ca10
JB
9532011-05-04 Juanma Barranquero <lekktu@gmail.com>
954
955 Implement dynamic loading of GnuTLS on Windows.
956
957 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
958 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
959 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
960 Declare.
961
962 * gnutls.c (Qgnutls_dll): Define.
963 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
964 (gnutls_*): Declare function pointers.
965 (init_gnutls_functions): New function to initialize function pointers.
966 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
967 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
968 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
969 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
970 (emacs_gnutls_write, emacs_gnutls_read)
971 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
972 (Fgnutls_available_p): New function.
973 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
974 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
975 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
976
977 * image.c: Include w32.h.
978 (Vimage_type_cache): Delete.
979 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
980 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
981 (w32_delayed_load): Move to w32.c.
982
983 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
984
985 * w32.c (QCloaded_from, Vlibrary_cache): Define.
986 (w32_delayed_load): Move from image.c. When loading a library, record
987 its filename in the :loaded-from property of the library id.
988 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
989 Initialize and staticpro them.
990 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
991
992 * process.c: Include lisp.h before w32.h, not after.
993 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
994 instead of gnutls_record_check_pending.
995
996 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
997
ff4de4aa
TZ
9982011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
999
1000 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1001 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1002 as passed in.
1003
abe95abb
JD
10042011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1005
1006 * xterm.c (x_set_frame_alpha): Do not set property on anything
1007 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1008
e16e55d4
JB
10092011-05-02 Juanma Barranquero <lekktu@gmail.com>
1010
1011 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1012
bafcf6a5
JB
10132011-05-02 Juanma Barranquero <lekktu@gmail.com>
1014
1015 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1016 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1017 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1018 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1019 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1020 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1021 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1022 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1023 (Qgnutls_bootprop_callbacks_verify): Make static.
1024
e7a6747f
AS
10252011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1026
19ed11ba
AS
1027 * callproc.c: Indentation fixup.
1028
e7a6747f 1029 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1030 (wait_for_termination, interruptible_wait_for_termination):
1031 Move after wait_for_termination_1.
e7a6747f 1032
1ef14cb4
LMI
10332011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1034
1035 * sysdep.c (interruptible_wait_for_termination): New function
1036 which is like wait_for_termination, but allows keyboard
1037 interruptions.
1038
1039 * callproc.c (Fcall_process): Add (:file "file") as an option for
1040 the STDOUT buffer.
1041 (Fcall_process_region): Ditto.
1042
330d880c
EZ
10432011-04-30 Eli Zaretskii <eliz@gnu.org>
1044
8db90b73
EZ
1045 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1046 rather than `XVECTOR (FOO)->size'.
1047
330d880c
EZ
1048 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1049 inttypes.h, as a gnulib replacement is used if it not available in
1050 system headers.
1051
15cbd324
EZ
10522011-04-21 Eli Zaretskii <eliz@gnu.org>
1053
1054 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1055 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1056 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1057
1058 * coding.c (coding_alloc_by_realloc): Error out if destination
1059 will grow beyond MOST_POSITIVE_FIXNUM.
1060 (decode_coding_emacs_mule): Abort if there isn't enough place in
1061 charbuf for the composition carryover bytes. Reserve an extra
1062 space for up to 2 characters produced in a loop.
1063 (decode_coding_iso_2022): Abort if there isn't enough place in
1064 charbuf for the composition carryover bytes.
1065
10662011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1067
ae940cca
EZ
1068 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1069 aborting when %lld or %lll format is passed.
1070 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1071 %llo or %llx format is passed. (Bug#8545)
1072
03ab8921
EZ
1073 * window.c (window_scroll_line_based): Use a marker instead of
1074 simple variables to record original value of point. (Bug#7952)
1075
afda1437
EZ
1076 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1077 produced by %s or %c overflows available buffer space. (Bug#8545)
1078
f76dee0c
PE
10792011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1080
1081 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1082 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1083
fdc5744d
JB
10842011-04-28 Juanma Barranquero <lekktu@gmail.com>
1085
1086 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1087
638f053a
JB
10882011-04-28 Juanma Barranquero <lekktu@gmail.com>
1089
1090 * keyboard.c (Qdelayed_warnings_hook): Define.
1091 (command_loop_1): Run `delayed-warnings-hook'
1092 if Vdelayed_warnings_list is non-nil.
1093 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1094 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1095
d178f871
EZ
10962011-04-28 Eli Zaretskii <eliz@gnu.org>
1097
1098 * doprnt.c (doprnt): Don't return value smaller than the buffer
1099 size if the message was truncated. (Bug#8545).
1100
b124fd93
JB
11012011-04-28 Juanma Barranquero <lekktu@gmail.com>
1102
1103 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1104 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1105
e810457d
PE
11062011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1107
1108 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1109
ea51cceb
JB
11102011-04-27 Juanma Barranquero <lekktu@gmail.com>
1111
1112 * makefile.w32-in: Update dependencies.
1113
94dcfacf
EZ
11142011-04-27 Eli Zaretskii <eliz@gnu.org>
1115
1116 Improve `doprnt' and its usage. (Bug#8545)
1117 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1118 `format_end'. Remove support for %l as a conversion specifier.
1119 Don't use xrealloc. Improve diagnostics when the %l size modifier
1120 is used. Update the commentary.
1121
1122 * eval.c (verror): Simplify calculation of size_t.
1123
1124 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1125 messages.
1126
f61f41d7
PE
11272011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1128
1129 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1130 change.
1131
96fb4434
PE
11322011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1133
1134 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1135 This makes this file independent of the recent pseudovector change.
1136
671875da 11372011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1138
69e9b5a3
PE
1139 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1140
b5f869a7 1141 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1142 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1143 Remove unused local.
c8926152 1144 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1145
841a1577 1146 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1147 GCC 4.6.0 optimizes based on type-based alias analysis.
1148 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1149 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1150 != &v->size, and therefore "v->size = 1; b->size = 2; return
1151 v->size;" must therefore return 1. This assumption is incorrect
1152 for Emacs, since it type-puns struct Lisp_Vector * with many other
1153 types. To fix this problem, this patch adds a new type struct
f904488f 1154 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1155 and pseudovectors, and helps optimizing compilers not get fooled
1156 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1157 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1158 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1159 the size member.
eab3844f
PE
1160 (XSETPVECTYPE): Rewrite in terms of new macro.
1161 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1162 This is a bit clearer, and further avoids the possibility of
1163 undesirable aliasing.
1164 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1165 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1166 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1167 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1168 (ASIZE): Now uses header.size rather than size.
1169 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1170 to avoid the hassle of writing XVECTOR (foo)->header.size.
1171 (struct vectorlike_header): New type.
eab3844f
PE
1172 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1173 object, to help avoid aliasing.
1174 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1175 (SUBRP): Likewise, since Lisp_Subr is a special case.
1176 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1177 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1178 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1179 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1180 changed to be "header.size" and "header.next".
1181 * buffer.h (struct buffer): Likewise.
1182 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1183 * frame.h (struct frame): Likewise.
1184 * process.h (struct Lisp_Process): Likewise.
1185 * termhooks.h (struct terminal): Likewise.
1186 * window.c (struct save_window_data, struct saved_window): Likewise.
1187 * window.h (struct window): Likewise.
1188 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1189 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1190 * buffer.c (init_buffer_once): Likewise.
1191 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1192 special case.
1193 * process.c (Fformat_network_address): Use local var for size,
1194 for brevity.
1195
0df1eac5
PE
1196 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1197
847ab9d1 1198 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1199 * data.c (atof): Remove decl; no longer used or needed.
1200 (digit_to_number): Move to lread.c.
1201 (Fstring_to_number): Use new string_to_number function, to be
1202 consistent with how the Lisp reader treats infinities and NaNs.
1203 Do not assume that floating-point numbers represent EMACS_INT
1204 without losing information; this is not true on most 64-bit hosts.
1205 Avoid double-rounding errors, by insisting on integers when
1206 parsing non-base-10 numbers, as the documentation specifies.
1207 * lisp.h (string_to_number): New decl, replacing ...
1208 (isfloat_string): Remove.
bc0a5c13 1209 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1210 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1211 appears to have been a coding error. Similarly, do not accept
1212 strings like +-1e0 as floating point numbers. Do not report
1213 overflow for integer overflows unless the base is not 10 which
1214 means we have no simple and reliable way to continue.
1215 Break out the floating-point parsing into a new
1216 function string_to_number, so that Fstring_to_number parses
1217 floating point numbers consistently with the Lisp reader.
04f2d78b 1218 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1219 (E_CHAR, EXP_INT): Remove, replacing with ...
1220 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1221 (string_to_number): New function, replacing isfloat_string.
1222 This function checks for valid syntax and produces the resulting
1223 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1224 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1225 so that overflow for non-base-10 numbers is reported only when
1226 there's no portable and simple way to convert to floating point.
452f4150 1227
67769ffc
PE
1228 * textprop.c (set_text_properties_1): Rewrite for clarity,
1229 and to avoid GCC warning about integer overflow.
1230
c20db43f
PE
1231 * intervals.h (struct interval): Use EMACS_INT for members
1232 where EMACS_UINT might cause problems. See
1233 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1234 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1235 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1236 All uses changed.
37aa2f85
PE
1237 (offset_intervals): Tell GCC not to worry about length overflow
1238 when negating a negative length.
c20db43f 1239
2538aa2f
PE
1240 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1241 (overrun_check_free): Likewise.
1242
f2d3008d
PE
1243 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1244 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1245 word size.
1246
ec8df744
PE
1247 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1248 (gnutls_make_error): Rename local to avoid shadowing.
1249 (gnutls_emacs_global_deinit): ifdef out; not used.
1250 (Fgnutls_boot): Use const for pointer to readonly storage.
1251 Comment out unused local. Fix pointer signedness problems.
1252
640ee02d
PE
1253 * lread.c (openp): Don't stuff size_t into an 'int'.
1254 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1255 about possible signed overflow.
1256
6048fb2a
PE
1257 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1258 (GDK_KEY_g): Don't define if already defined.
1259 (xg_prepare_tooltip): Avoid pointer signedness problem.
1260 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1261
fa3c87e1
PE
1262 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1263 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1264
2172544b
PE
1265 * xfns.c (Fx_window_property): Simplify a bit,
1266 to make a bit faster and to avoid GCC 4.6.0 warning.
1267 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1268
9b821a21
PE
1269 * fns.c (internal_equal): Don't assume size_t fits in int.
1270
3c616cfa
PE
1271 * alloc.c (compact_small_strings): Tighten assertion a little.
1272
c2982e87
PE
1273 Replace pEd with more-general pI, and fix some printf arg casts.
1274 * lisp.h (pI): New macro, generalizing old pEd macro to other
1275 conversion specifiers. For example, use "...%"pI"d..." rather
1276 than "...%"pEd"...".
1277 (pEd): Remove. All uses replaced with similar uses of pI.
1278 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1279 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1280 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1281 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1282 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1283 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1284 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1285 64-bit hosts.
1286 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1287 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1288 * print.c (safe_debug_print, print_object): Likewise.
1289 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1290 to int.
6f04d126
PE
1291 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1292 avoiding the 0 flag, which is not portable.
c2982e87
PE
1293 * process.c (Fmake_network_process): Use pI to avoid cast.
1294 * region-cache.c (pp_cache): Likewise.
1295 * xdisp.c (decode_mode_spec): Likewise.
1296 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1297 behavior on 64-bit hosts with printf arg.
6f04d126 1298 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1299 (x_stop_queuing_selection_requests): Likewise.
1300 (x_get_window_property): Don't truncate byte count to an 'int'
1301 when tracing.
0b432f21 1302
5e073ec7
PE
1303 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1304 here, since it parses constructs like leading '-' and spaces,
1305 which are not wanted; and it overflows with large numbers.
1306 Instead, simply match F[0-9]+, which is what is wanted anyway.
1307
36372bf9
PE
1308 * alloc.c: Remove unportable assumptions about struct layout.
1309 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1310 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1311 (allocate_vectorlike, make_pure_vector): Use the new macros,
1312 plus offsetof, to remove unportable assumptions about struct layout.
1313 These assumptions hold on all porting targets that I know of, but
1314 they are not guaranteed, they're easy to remove, and removing them
1315 makes further changes easier.
1316
0b432f21
PE
1317 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1318 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1319 (string_overrun_cookie): Now const. Use initializers that
1320 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1321 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1322 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1323 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1324 multiple of sizeof (EMACS_INT); it need not be, if
1325 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1326 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1327
895009e1
JB
13282011-04-26 Juanma Barranquero <lekktu@gmail.com>
1329
1330 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1331
6a7a1b0b
TZ
13322011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1333
1334 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1335 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1336 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1337
841a1577 13382011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1339
1340 * lisp.h (Qdebug): List symbol.
895009e1 1341 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1342 * keyboard.c (debug-on-event): New variable.
1343 (handle_user_signal): Break into debugger when debug-on-event
1344 matches the current signal symbol.
1345
f2d3ba6f
DN
13462011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1347
1348 * alloc.c (check_sblock, check_string_bytes)
1349 (check_string_free_list): Convert to standard C.
1350
42ce4c63
TZ
13512011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1352
1353 * w32.c (emacs_gnutls_push): Fix typo.
1354
825cd63c
EZ
13552011-04-25 Eli Zaretskii <eliz@gnu.org>
1356
fb11d64d
EZ
1357 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1358 "cast to pointer from integer of different size".
1359
825cd63c
EZ
1360 Improve doprnt and its use in verror. (Bug#8545)
1361 * doprnt.c (doprnt): Document the set of format control sequences
1362 supported by the function. Use SAFE_ALLOCA instead of always
1363 using `alloca'.
1364
1365 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1366 is one byte too soon. Don't use xrealloc; instead xfree and
1367 xmalloc anew.
1368
e061a11b
TZ
13692011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1370
1371 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1372 callbacks stage.
1373
1374 * gnutls.c: Renamed global_initialized to
1375 gnutls_global_initialized. Added internals for the
1376 :verify-hostname-error, :verify-error, and :verify-flags
1377 parameters of `gnutls-boot' and documented those parameters in the
1378 docstring. Start callback support.
1379 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1380 unless a fatal error occured. Call gnutls_alert_send_appropriate
1381 on error. Return error code.
1382 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1383 (emacs_gnutls_read): Likewise.
1384 (Fgnutls_boot): Return handshake error code.
1385 (emacs_gnutls_handle_error): New function.
1386 (wsaerror_to_errno): Likewise.
1387
1388 * w32.h (emacs_gnutls_pull): Add prototype.
1389 (emacs_gnutls_push): Likewise.
1390
1391 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1392 (emacs_gnutls_push): Likewise.
1393
13942011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1395
1396 * process.c (wait_reading_process_output): Check if GnuTLS
1397 buffered some data internally if no FDs are set for TLS
1398 connections.
1399
1400 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1401 (LIBS): Link to USER_LIBS.
1402 ($(BLD)/gnutls.$(0)): New target.
1403
fa6996bc
EZ
14042011-04-24 Eli Zaretskii <eliz@gnu.org>
1405
eb35682e
EZ
1406 * xdisp.c (handle_single_display_spec): Rename the
1407 display_replaced_before_p argument into display_replaced_p, to
1408 make it consistent with the commentary. Fix typos in the
1409 commentary.
1410
e2ad650c
EZ
1411 * textprop.c (syms_of_textprop): Remove dead code.
1412 (copy_text_properties): Delete obsolete commentary about an
1413 interface that was deleted long ago. Fix typos in the description
1414 of arguments.
1415
1b2de274
EZ
1416 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1417 to changes in oldXMenu/XMenu.h from 2011-04-16.
1418 <menu_help_message, prev_menu_help_message>: Constify.
1419 (IT_menu_make_room): menu->help_text is now `const char **';
1420 adjust.
1421
1422 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1423 to changes in oldXMenu/XMenu.h from 2011-04-16.
1424 (struct XMenu): Declare `help_text' `const char **'.
1425
1426 * xfaces.c <Qunspecified>: Make extern again.
1427
1428 * syntax.c: Include sys/types.h before including regex.h, as
1429 required by Posix.
1430
762b15be
EZ
1431 * doc.c (get_doc_string): Improve the format passed to `error'.
1432
1433 * doprnt.c (doprnt): Improve commentary.
1434
1435 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1436
1437 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1438 them with etags.
1439
f1052e5d
EZ
1440 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1441 changes in globals.h immediately force recompilation.
762b15be
EZ
1442 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1443 $(CURDIR)/s/ms-w32.h.
1444 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1445
fa6996bc
EZ
1446 * character.c (Fchar_direction): Function deleted.
1447 (syms_of_character): Don't defsubr it.
1448 <char-direction-table>: Deleted.
1449
e6c3da20
EZ
14502011-04-23 Eli Zaretskii <eliz@gnu.org>
1451
1452 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1453 * doprnt.c: Include limits.h.
1454 (SIZE_MAX): New macro.
04f2d78b
CB
1455 (doprnt): Return a size_t value. 2nd arg is now size_t.
1456 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1457 Improve overflow protection. Support `l' modifier for integer
1458 conversions. Support %l conversion. Don't assume an EMACS_INT
1459 argument for integer conversions and for %c.
1460
1461 * lisp.h (doprnt): Restore prototype.
1462
1463 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1464 $(SRC)/character.h.
1465
1466 * Makefile.in (base_obj): Add back doprnt.o.
1467
1468 * deps.mk (doprnt.o): Add back prerequisites.
1469 (callint.o): Depend on character.h.
1470
1471 * eval.c (internal_lisp_condition_case): Include the handler
1472 representation in the error message.
1473 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1474 when breaking from the loop.
1475
1476 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1477
1478 * callint.c (Fcall_interactively): When displaying error message
1479 about invalid control letter, pass the character's codepoint, not
1480 a pointer to its multibyte form. Improve display of the character
1481 in octal and display also its hex code.
1482
1483 * character.c (char_string): Use %x to display the (unsigned)
1484 codepoint of an invalid character, to avoid displaying a bogus
1485 negative value.
1486
1487 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1488 `error', not SYMBOL_NAME itself.
1489
1490 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1491 character arguments to `error'.
1492
1493 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1494 to `error' in error message about FINAL_CHAR argument. Make sure
1495 FINAL_CHAR is a character, and use %c when it is passed as
1496 argument to `error'.
1497
4ffd0d6b 14982011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1499
1500 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1501
1502 * w32.c: Include <time.h>.
1503 (sys_localtime): New function.
1504
4ffd0d6b 15052011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1506
1507 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1508
4ffd0d6b 1509 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1510
4ffd0d6b 15112011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1512
4ffd0d6b
GM
1513 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1514 zombies (Bug#8467).
aac0c6e3 1515
04c56954
EZ
15162011-04-19 Eli Zaretskii <eliz@gnu.org>
1517
1518 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1519 gl_state.e_property when gl_state.object is Qt.
1520
1521 * insdel.c (make_gap_larger): Remove limitation of buffer size
1522 to <= INT_MAX.
1523
16a43933
CY
15242011-04-18 Chong Yidong <cyd@stupidchicken.com>
1525
1526 * xdisp.c (lookup_glyphless_char_display)
1527 (produce_glyphless_glyph): Handle cons cell entry in
1528 glyphless-char-display.
1529 (Vglyphless_char_display): Document it.
1530
1531 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1532 glyphless-char-display.
1533
4581706e
CY
15342011-04-17 Chong Yidong <cyd@stupidchicken.com>
1535
1536 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1537
1538 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1539
1540 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1541 definition for no-X builds.
1542
4887c6e2 15432011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1544
fd35b6f9
PE
1545 Static checks with GCC 4.6.0 and non-default toolkits.
1546
5c1ccb01
PE
1547 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1548
006c5daa
PE
1549 * process.c (keyboard_bit_set): Define only if SIGIO.
1550 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1551 (send_process): Repair possible setjmp clobbering.
1552
efc736d3
PE
1553 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1554
4e2fe2e6
PE
1555 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1556
f97334a2
PE
1557 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1558
4e75f29d
PE
1559 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1560 Define only if needed.
1561
90efadd1
PE
1562 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1563 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1564 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1565
3c647824
PE
1566 * dispextern.h (struct redisplay_interface): Rename param
1567 to avoid shadowing.
e264f262 1568 * termhooks.h (struct terminal): Likewise.
761383f4 1569 * xterm.c (xembed_send_message): Likewise.
3c647824 1570
b58c5c4a
PE
1571 * insdel.c (make_gap_smaller): Define only if
1572 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1573
cad59032
PE
1574 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1575 it.
1576
c339dc2e
PE
1577 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1578 so that we aren't warned about unused symbols.
1579
91a3e27b
PE
1580 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1581
399c71d3 1582 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1583
8ffc96f5
PE
1584 * xfns.c (x_real_positions): Mark locals as initialized.
1585
eef9bc79
PE
1586 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1587
098db9dd
PE
1588 * xterm.c: Fix problems found by static analysis with other toolkits.
1589 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1590 (x_dispatch_event): Declare static if USE_GTK, and
1591 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1592 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1593 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1594 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1595 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1596
eb18f6cc
PE
1597 * xmenu.c (menu_help_callback): Pointer type fixes.
1598 Use const pointers when pointing at readonly data. Avoid pointer
1599 signedness clashes.
1600 (FALSE): Remove unused macro.
1601 (update_frame_menubar): Remove unused decl.
1602
1fe72bf8
PE
1603 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1604
60d9e1db
PE
1605 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1606 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1607 (single_menu_item): Rename local to avoid shadowing.
1608
39261c26
PE
1609 * keyboard.c (make_lispy_event): Remove unused local var.
1610
018c5e19
PE
1611 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1612 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1613
63d2b86e
PE
1614 * bitmaps: Change bitmaps from unsigned char back to the X11
1615 compatible char. Avoid the old compiler warnings about
1616 out-of-range initializers by using, for example, '\xab' rather
1617 than 0xab.
1618
aefd87e1
PE
1619 * xgselect.c (xgselect_initialize): Check vs interface
1620 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1621
bf501fb9
PE
1622 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1623
e9829fdf
PE
1624 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1625 to read-only memory.
1626
1086c095
PE
1627 * fns.c (vector): Remove; this old hack is no longer needed.
1628
2baccd04 1629 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1630 Remove unused var.
dde42981 1631 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1632
72391843 1633 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1634
436c16df 1635 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1636 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1637 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1638
92bb796d 1639 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1640 (x_term_init): Remove local to avoid shadowing.
92bb796d 1641
764430a3 1642 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1643
1644 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1645 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1646
d1dfb56c
EZ
16472011-04-16 Eli Zaretskii <eliz@gnu.org>
1648
c4354cb4
EZ
1649 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1650
d1dfb56c
EZ
1651 Fix regex.c, syntax.c and friends for buffers > 2GB.
1652 * syntax.h (struct gl_state_s): Declare character position members
1653 EMACS_INT.
1654
1655 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1656
04f2d78b
CB
1657 * textprop.c (verify_interval_modification, interval_of):
1658 Declare arguments EMACS_INT.
d1dfb56c
EZ
1659
1660 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1661 EMACS_INT.
1662
1663 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1664
1665 * indent.c (Fvertical_motion): Local variable it_start is now
1666 EMACS_INT.
1667
1668 * regex.c (re_match, re_match_2, re_match_2_internal)
1669 (bcmp_translate, regcomp, regexec, print_double_string)
1670 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1671 (re_compile_pattern, re_exec): Declare arguments and local
1672 variables `size_t' and `ssize_t' and return values `regoff_t', as
1673 appropriate.
1674 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1675 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1676 <compile_stack_type>: `size' and `avail' are now `size_t'.
1677
1678 * regex.h <regoff_t>: Use ssize_t, not int.
1679 (re_search, re_search_2, re_match, re_match_2): Arguments that
1680 specify buffer/string position and length are now ssize_t and
1681 size_t. Return type is regoff_t.
1682
613052cd
BK
16832011-04-16 Ben Key <bkey76@gmail.com>
1684
1685 * nsfont.m: Fixed bugs in ns_get_family and
1686 ns_descriptor_to_entity that were caused by using free to
1687 deallocate memory blocks that were allocated by xmalloc (via
1688 xstrdup). This caused Emacs to crash when compiled with
1689 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1690 --enable-checking=xmallocoverrun). xfree is now used to
1691 deallocate these memory blocks.
1692
4170f62f 16932011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1694
71b41406
PE
1695 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1696
9587a89d
PE
1697 emacs_write: Accept and return EMACS_INT for sizes.
1698 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1699 et seq.
1700 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1701 Accept and return EMACS_INT.
1702 (emacs_gnutls_write): Return the number of bytes written on
1703 partial writes.
1704 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1705 (emacs_read, emacs_write): Remove check for negative size, as the
1706 Emacs source code has been audited now.
9587a89d
PE
1707 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1708 (emacs_read, emacs_write): Use it.
273a5f82
PE
1709 * process.c (send_process): Adjust to the new signatures of
1710 emacs_write and emacs_gnutls_write. Do not attempt to store
1711 a byte offset into an 'int'; it might overflow.
9587a89d 1712 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1713
3e047f51
PE
1714 * sound.c: Don't assume sizes fit in 'int'.
1715 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1716 Return EMACS_INT, not int.
3e047f51 1717 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1718 Accept EMACS_INT, not int.
1719 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1720 record read return values.
1721
cc39a9db
BK
17222011-04-15 Ben Key <bkey76@gmail.com>
1723
c9d0ec6d
JB
1724 * keyboard.c (Qundefined): Don't declare static since it is used
1725 in nsfns.m.
1726 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1727 static since they are used in nsfont.m.
cc39a9db 1728
6c60eb9f
SM
17292011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1730
1731 * process.c (Qprocessp): Don't declare static.
1732 * lisp.h (Qprocessp): Declare again.
1733
7990b61a
JB
17342011-04-15 Juanma Barranquero <lekktu@gmail.com>
1735
1736 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1737
5d4cb038
PE
17382011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1739
8bd7b830 1740 Improve C-level modularity by making more things 'static'.
cd64ea1d 1741
e3b27b31
PE
1742 Don't publish debugger-only interfaces to other modules.
1743 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1744 (verify_bytepos, count_markers): Move decls to the only modules
1745 that need them.
1746 * region-cache.h (pp_cache): Likewise.
1747 * window.h (check_all_windows): Likewise.
1748 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1749
5d4cb038
PE
1750 * sysdep.c (croak): Now static, if
1751 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1752 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1753
1754 * alloc.c (refill_memory_reserve): Now static if
1755 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1756 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1757
e87b6180
PE
1758 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1759 Define only if USE_LUCID.
1760
ac64929e
PE
1761 * xrdb.c (x_customization_string, x_rm_string): Now static.
1762
6f37259d
PE
1763 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1764 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1765
1683e3ab
PE
1766 * xdisp.c (draw_row_with_mouse_face): Now static.
1767 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1768
de9c2632
PE
1769 * window.h (check_all_windows): Mark externally visible.
1770
2b96acb7
PE
1771 * window.c (window_deletion_count): Now static.
1772
1773 * undo.c: Make symbols static if they're not exported.
1774 (last_undo_buffer, last_boundary_position, pending_boundary):
1775 Now static.
1776
50436f33
PE
1777 * textprop.c (interval_insert_behind_hooks): Now static.
1778 (interval_insert_in_front_hooks): Likewise.
1779
64520e5c
PE
1780 * term.c: Make symbols static if they're not exported.
1781 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1782 (max_frame_lines, tty_set_terminal_modes):
1783 (tty_reset_terminal_modes, tty_turn_off_highlight):
1784 (get_tty_terminal): Now static.
1785 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1786 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1787 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1788 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1789 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1790
1fa53021
PE
1791 * sysdep.c: Make symbols static if they're not exported.
1792 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1793 Now static.
1794 (sigprocmask_set, full_mask): Remove; unused.
1795 (wait_debugging): Mark as visible.
1796 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1797 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1798
d4b43b22
PE
1799 * syntax.c (syntax_temp): Define only if !__GNUC__.
1800
b7c513d0
PE
1801 * sound.c (current_sound_device, current_sound): Now static.
1802
989b29ad
PE
1803 * search.c (searchbufs, searchbuf_head): Now static.
1804
13a55a78
PE
1805 * scroll.c (scroll_cost): Remove; unused.
1806 * dispextern.h (scroll_cost): Remove decl.
1807
de68a1fc
PE
1808 * region-cache.h (pp_cache): Mark as externally visible.
1809
40ccffa6
PE
1810 * process.c: Make symbols static if they're not exported.
1811 (process_tick, update_tick, create_process, chan_process):
1812 (Vprocess_alist, proc_buffered_char, datagram_access):
1813 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1814 (deactivate_process): Mark defn as static, as well as decl.
1815 * lisp.h (create_process): Remove decl.
1816 * process.h (chan_process, Vprocess_alist): Remove decls.
1817
ad64fc97
PE
1818 * print.c: Make symbols static if they're not exported.
1819 (print_depth, new_backquote_output, being_printed, print_buffer):
1820 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1821 (print_interval, print_number_index, initial_stderr_stream):
1822 Now static.
1823 * lisp.h (Fprinc): Remove decl.
1824 (debug_output_compilation_hack): Mark as externally visible.
1825
adddb265
PE
1826 * sysdep.c (croak): Move decl from here to syssignal.h.
1827 * syssignal.h (croak): Put it here, so the API can be checked when
1828 'croak' is called from dissociate_if_controlling_tty.
1829
1717ede2
PE
1830 * minibuf.c: Make symbols static if they're not exported.
1831 (minibuf_save_list, choose_minibuf_frame): Now static.
1832 * lisp.h (choose_minibuf_frame): Remove decl.
1833
fa5fb2bc
PE
1834 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1835
1e3890d1
PE
1836 * lread.c: Make symbols static if they're not exported.
1837 (read_objects, initial_obarray, oblookup_last_bucket_number):
1838 Now static.
1839 (make_symbol): Remove; unused.
1840 * lisp.h (initial_obarray, make_symbol): Remove decls.
1841
8a1414fa
PE
1842 * keyboard.c: Make symbols static if they're not exported.
1843 (single_kboard, recent_keys_index, total_keys, recent_keys):
1844 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1845 (this_single_command_key_start, echoing, last_auto_save):
1846 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1847 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1848 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1849 (Vlispy_mouse_stem, double_click_count):
1850 Now static.
1851 (force_auto_save_soon): Define only if SIGDANGER.
1852 (ignore_mouse_drag_p): Now static if
1853 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1854 (print_help): Remove; unused.
1855 (stop_character, last_timer_event): Mark as externally visible.
1856 * keyboard.h (ignore_mouse_drag_p): Declare only if
1857 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1858 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1859 * lisp.h (echoing): Remove decl.
1860 (force_auto_save_soon): Declare only if SIGDANGER.
1861 * xdisp.c (redisplay_window): Simplify code, to make it more
1862 obvious that ignore_mouse_drag_p is not accessed if !defined
1863 USE_GTK && !defined HAVE_NS.
1864
93ea6e8f
PE
1865 * intervals.c: Make symbols static if they're not exported.
1866 (merge_properties_sticky, merge_interval_right, delete_interval):
1867 Now static.
1868 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1869
77382fcc
PE
1870 * insdel.c: Make symbols static if they're not exported.
1871 However, leave prepare_to_modify_buffer alone. It's never
1872 called from outside this function, but that appears to be a bug.
1873 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1874 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1875 (adjust_after_replace_noundo): Remove; unused.
1876 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1877 (signal_before_change): Remove decls.
77382fcc 1878
9306c32e
PE
1879 * indent.c (val_compute_motion, val_vmotion): Now static.
1880
cd44d2eb
PE
1881 * image.c: Make symbols static if they're not exported.
1882 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1883 if USE_GTK.
1884 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1885 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1886
ad9a7a06
PE
1887 * fringe.c (standard_bitmaps): Now static.
1888 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1889
81626931
PE
1890 * frame.c: Make symbols static if they're not exported.
1891 (x_report_frame_params, make_terminal_frame): Now static.
1892 (get_frame_param): Now static, unless HAVE_NS.
1893 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1894 (x_get_resource_string): Remove; not used.
1895 * frame.h (make_terminal_frame, x_report_frame_params):
1896 (x_get_resource_string); Remove decls.
1897 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1898 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1899
239f9db9
PE
1900 * font.c, fontset.c: Make symbols static if they're not exported.
1901 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1902 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1903 * font.c (font_close_object): Now static.
1904 * font.h (font_close_object): Remove.
1905 * fontset.c (FONTSET_OBJLIST): Remove.
1906 (free_realized_fontset) #if-0 the body, which does nothing.
1907 (face_suitable_for_char_p): #if-0, as it's never called.
1908 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
1909 * xfaces.c (face_at_string_position):
1910 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
1911 since 0 is always ASCII.
1912
dfcf3579
PE
1913 * fns.c (weak_hash_tables): Now static.
1914
5045092b
PE
1915 * fileio.c: Make symbols static if they're not exported.
1916 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1917 (Vwrite_region_annotation_buffers): Now static.
1918
57a96f5c
PE
1919 * eval.c: Make symbols static if they're not exported.
1920 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1921 * lisp.h (backtrace_list): Remove decl.
1922
35f08c38
PE
1923 * emacs.c: Make symbols static if they're not exported.
1924 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1925 (fatal_error_code, fatal_error_signal_hook, standard_args):
1926 Now static.
1927 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1928 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1929 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1930 * lisp.h (fatal_error_signal_hook): Remove decl.
1931 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1932
f44bd759
PE
1933 * editfns.c: Move a (normally-unused) function to its only use.
1934 * editfns.c, lisp.h (get_operating_system_release): Remove.
1935 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1936 worth the hassle of breaking this out.
1937
b532497d
PE
1938 * xterm.c: Make symbols static if they're not exported.
1939 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1940 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1941 (x_destroy_window, x_delete_display):
1942 Now static.
1943 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1944 (x_mouse_leave): Remove; unused.
1945 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1946 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1947 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1948 Remove decls.
1949 (x_mouse_leave): Declare only if WINDOWSNT.
1950 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1951 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1952 USE_X_TOOLKIT.
1953
1675728f
PE
1954 * ftxfont.c: Make symbols static if they're not exported.
1955 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1956 HAVE_FREETYPE.
1957 * font.h (ftxfont_driver): Likewise.
1958
e4cebfca
PE
1959 * xfns.c: Make symbols static if they're not exported.
1960 (x_last_font_name, x_display_info_for_name):
1961 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1962 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1963 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1964 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1965 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1966 (last_show_tip_args): Now static.
1967 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1968 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1969 (x_screen_planes): Remove; unused.
1970 * dispextern.h (x_screen_planes): Remove decl.
1971
5bf46f05
PE
1972 * dispnew.c: Make symbols static if they're not exported.
1973 * dispextern.h (redraw_garbaged_frames, scrolling):
1974 (increment_row_positions): Remove.
1975 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1976 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1977 Now static.
1978 (redraw_garbaged_frames): Remove; unused.
1979
435f4c28
PE
1980 * xfaces.c: Make symbols static if they're not exported.
1981 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1982 Remove decls.
1983 * xterm.h (defined_color): Remove decls.
1984 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1985 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1986 (menu_face_changed_default, defined_color, free_realized_face):
1987 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1988 (ascii_face_of_lisp_face): Remove; unused.
1989
8524aef3
PE
1990 * xdisp.c: Make symbols static if they're not exported.
1991 * dispextern.h (scratch_glyph_row, window_box_edges):
1992 (glyph_to_pixel_coords, set_cursor_from_row):
1993 (get_next_display_element, set_iterator_to_next):
1994 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1995 (show_mouse_face): Remove decls
1996 * frame.h (message_buf_print): Likewise.
1997 * lisp.h (pop_message, set_message, check_point_in_composition):
1998 Likewise.
1999 * xterm.h (set_vertical_scroll_bar): Likewise.
2000 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2001 (message_buf_print, scratch_glyph_row, displayed_buffer):
2002 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2003 (get_next_display_element, show_mouse_face, window_box_edges):
2004 (frame_to_window_pixel_xy, check_point_in_composition):
2005 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2006 (glyph_to_pixel_coords): Remove; unused.
2007
16390cd2
PE
2008 * dired.c (file_name_completion): Now static.
2009
2010 * dbusbind.c (xd_in_read_queued_messages): Now static.
2011
a25f4dfa
PE
2012 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2013 * data.c (circular_list_error): Remove.
2014
14a9c8df
PE
2015 * commands.h (last_point_position, last_point_position_buffer):
2016 (last_point_position_window): Remove decls.
2017 * keyboard.c: Make these variables static.
2018
04f2d78b
CB
2019 * coding.h (coding, code_convert_region, encode_coding_gap):
2020 Remove decls.
74ab6df5
PE
2021 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2022 (iso_code_class, detect_coding, code_convert_region): Now static.
2023 (encode_coding_gap): Remove; unused.
2024
38dfbee1
PE
2025 * chartab.c (chartab_chars, chartab_bits): Now static.
2026
a2cb4e63
PE
2027 * charset.h (charset_iso_8859_1): Remove decl.
2028 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2029 Now static.
2030
127198fd
PE
2031 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2032 * ccl.c (Vccl_program_table): Now static.
2033 (check_ccl_update): Remove; unused.
2034
d85b608f
PE
2035 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2036 * category.h: ... from here.
2037 * category.c (check_category_table, set_category_set): Now static.
2038
31cd66f3
PE
2039 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2040 * lisp.h: Remove these decls.
2041
c358e587
PE
2042 * buffer.c (buffer_count): Remove unused var.
2043
e78aecca
PE
2044 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2045 so that it's not optimized away.
2046 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2047 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2048 exported only to the debugger.
2049
e192d7d3 2050 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2051 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2052
92470028
PE
2053 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2054 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2055 was inaccessible from Lisp.
2056 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2057 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2058
244ed907
PE
2059 alloc.c: Import and export fewer symbols, and remove unused items.
2060 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2061 is defined.
2062 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2063 it's not optimized away by whole-program optimization.
2064 (message_enable_multibyte, free_misc): Remove.
2065 (catchlist, handlerlist, mark_backtrace):
2066 Declare only if BYTE_MARK_STACK.
2067 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2068 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2069 (message_enable_multibyte): Remove decl.
2070 (free_misc, interval_free_list, float_block, float_block_index):
2071 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2072 (cons_free_list, last_marked_index):
2073 Now static.
2074 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2075 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2076 (mark_backtrace): Define only if BYTE_MARK_STACK.
2077 * xdisp.c (message_enable_multibyte): Now static.
2078
61c2b50e 2079 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2080 This makes it easier for human readers (and static analyzers)
2081 to see whether these variables are used from other modules.
2082 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2083 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2084 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2085 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2086 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2087 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2088 * xmenu.c, xselect.c:
2089 Declare Q* vars static if they are not used in other modules.
2090 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2091 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2092 Remove decls of unexported vars.
2093 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2094
95c82688
PE
2095 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2096
16a97296
PE
2097 Make Emacs functions such as Fatom 'static' by default.
2098 This makes it easier for human readers (and static analyzers)
2099 to see whether these functions can be called from other modules.
2100 DEFUN now defines a static function. To make the function external
2101 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2102 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2103 (Finit_image_library):
16a97296
PE
2104 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2105 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2106 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2107 Remove decls, since these functions are now static.
2108 (Funintern, Fget_internal_run_time): New decls, since these functions
2109 were already external.
95c82688 2110
16a97296
PE
2111 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2112 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2113 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2114 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2115 * keyboard.c, keymap.c, lread.c:
2116 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2117 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2118 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2119 Mark functions with DEFUE instead of DEFUN,
2120 if they are used in other modules.
2121 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2122 decls for now-static functions.
2123 * buffer.h (Fdelete_overlay): Remove decl.
2124 * callproc.c (Fgetenv_internal): Mark as internal.
2125 * composite.c (Fremove_list_of_text_properties): Remove decl.
2126 (Fcomposition_get_gstring): New forward static decl.
2127 * composite.h (Fcomposite_get_gstring): Remove decl.
2128 * dired.c (Ffile_attributes): New forward static decl.
2129 * doc.c (Fdocumntation_property): New forward static decl.
2130 * eval.c (Ffetch_bytecode): New forward static decl.
2131 (Funintern): Remove extern decl; now in .h file where it belongs.
2132 * fileio.c (Fmake_symbolic_link): New forward static decl.
2133 * image.c (Finit_image_library): New forward static decl.
2134 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2135 * intervals.h (Fprevious_property_change):
2136 (Fremove_list_of_text_properties): Remove decls.
2137 * keyboard.c (Fthis_command_keys): Remove decl.
2138 (Fcommand_execute): New forward static decl.
2139 * keymap.c (Flookup_key): New forward static decl.
2140 (Fcopy_keymap): Now static.
2141 * keymap.h (Flookup_key): Remove decl.
2142 * process.c (Fget_process): New forward static decl.
2143 (Fprocess_datagram_address): Mark as internal.
2144 * syntax.c (Fsyntax_table_p): New forward static decl.
2145 (skip_chars): Remove duplicate decl.
2146 * textprop.c (Fprevious_property_change): New forward static decl.
2147 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2148 Now internal.
2149 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2150 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2151
785bbd42
PE
2152 * editfns.c (Fformat): Remove unreachable code.
2153
8b913b57
AS
21542011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2155
2156 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2157 change. (Bug#8496)
2158
a6744a35
EZ
21592011-04-13 Eli Zaretskii <eliz@gnu.org>
2160
2161 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2162 when at ZV. (Bug#8487)
2163
e7974947
AS
21642011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2165
baad03f0
AS
2166 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2167 (Bug#8437)
2168 * keyboard.c (parse_tool_bar_item): Likewise.
2169 * sound.c (sound_cleanup, alsa_close): Likewise.
2170 * termcap.c (tgetent): Likewise.
2171 * xfns.c (x_default_font_parameter): Likewise.
2172 * xsettings.c (read_and_apply_settings): Likewise.
2173
e7974947
AS
2174 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2175 (overrun_check_free): Protoize.
2176
28272684
PE
21772011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2178
2179 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2180 since callers should never pass a negative size.
2181 Change the signature to match that of plain 'read' and 'write'; see
2182 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2183 * lisp.h: Update prototypes of emacs_write and emacs_read.
2184
11997c76
EZ
21852011-04-11 Eli Zaretskii <eliz@gnu.org>
2186
2187 * xdisp.c (redisplay_window): Don't try to determine the character
2188 position of the scroll margin if the window start point w->startp
e896f03c 2189 is outside the buffer's accessible region. (Bug#8468)
11997c76 2190
8a2cbd72
EZ
21912011-04-10 Eli Zaretskii <eliz@gnu.org>
2192
2193 Fix write-region and its subroutines for buffers > 2GB.
2194 * fileio.c (a_write, e_write): Modify declaration of arguments and
2195 local variables to support buffers larger than 2GB.
2196 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2197
2198 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2199 argument, local variables, and return value.
2200
2201 * lisp.h: Update prototypes of emacs_write and emacs_read.
2202
2203 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2204
4073e537 22052011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2206
1ebfdcb6
PE
2207 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2208
b2ded58d
PE
2209 Fix more problems found by GCC 4.6.0's static checks.
2210
7d66342c
PE
2211 * xdisp.c (vmessage): Use a better test for character truncation.
2212
bbf47d44
PE
2213 * charset.c (load_charset_map): <, not <=, for optimization,
2214 and to avoid potential problems with integer overflow.
9248994d 2215 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2216 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2217 * editfns.c (Fformat): Likewise.
1e69125e 2218 * syntax.c (skip_chars): Likewise.
3befa583 2219
e3019616
PE
2220 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2221 This also lets GCC 4.6.0 generate slightly better loop code.
2222
becfa255
PE
2223 * callint.c (Fcall_interactively): <, not <=, for optimization.
2224 (Fcall_interactively): Count the number of arguments produced,
2225 not the number of arguments given. This is simpler and lets GCC
2226 4.6.0 generate slightly better code.
2227
dae0cd48
PE
2228 * ftfont.c: Distingish more carefully between FcChar8 and char.
2229 The previous code passed unsigned char * to a functions like
2230 strlen and xstrcasecmp that expect char *, which does not
2231 conform to the C standard.
2232 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2233 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2234 char * when the C standard requires it.
2235
76032d70
PE
2236 * keyboard.c (read_char): Remove unused var.
2237
eb3f1cc8
PE
2238 * eval.c: Port to Windows vsnprintf (Bug#8435).
2239 Include <limits.h>.
2240 (SIZE_MAX): Define if the headers do not.
2241 (verror): Do not give up if vsnprintf returns a negative count.
2242 Instead, grow the buffer. This ports to Windows vsnprintf, which
2243 does not conform to C99. Problem reported by Eli Zaretskii.
2244 Also, simplify the allocation scheme, by avoiding the need for
2245 calling realloc, and removing the ALLOCATED variable.
2246
70476b54
PE
2247 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2248
12020a9e
PE
2249 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2250 But keep the doprint source code for now, as we might revamp it
2251 and use it again (Bug#8435).
ea6c7ae6
PE
2252 * lisp.h (doprnt): Remove.
2253 * Makefile.in (base_obj): Remove doprnt.o.
2254 * deps.mk (doprnt.o): Remove.
2255
5fdb398c
PE
2256 error: Print 32- and 64-bit integers portably (Bug#8435).
2257 Without this change, on typical 64-bit hosts error ("...%d...", N)
2258 was used to print both 32- and 64-bit integers N, which relied on
2259 undefined behavior.
2260 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2261 New macro.
2262 * lisp.h (error, verror): Mark as printf-like functions.
2263 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2264 Report overflow in size calculations when allocating printf buffer.
2265 Do not truncate output string at its first null byte.
2266 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2267 Truncate the output at a character boundary, since vsnprintf does not
2268 do that.
2269 * charset.c (check_iso_charset_parameter): Convert internal
2270 character to string before calling 'error', since %c now has the
2271 printf meaning.
2272 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2273 overflow when computing char to be passed to 'error'. Do not
2274 pass Lisp_Object to 'error'; pass the integer instead.
2275 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2276 formatted with plain %d.
2277
b189fa66
PE
2278 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2279
bff87ef0
PE
2280 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2281
7e2cac20
PE
2282 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2283
ce4d90b5
PE
2284 * xterm.c (x_catch_errors): Remove duplicate declaration.
2285
266c9547
PE
2286 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2287
79c49ad2
PE
2288 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2289
368f4090
JM
22902011-04-10 Jim Meyering <meyering@redhat.com>
2291
2292 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2293 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2294 return ssize_t not "int", and use size_t as the buffer length.
2295 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2296 * gnutls.h: Update declarations.
2297 * process.c (read_process_output): Use ssize_t, to match.
2298 (send_process): Likewise.
2299
a32d4040
CY
23002011-04-09 Chong Yidong <cyd@stupidchicken.com>
2301
2302 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2303
8546720e 23042011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2305
04f2d78b
CB
2306 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2307 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2308
8546720e
GM
2309 * xterm.c (handle_one_xevent):
2310 * xmenu.c (create_and_show_popup_menu):
2311 * xselect.c (x_decline_selection_request)
2312 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2313
0a2f5c1a 23142011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2315
2316 Fix some uses of `int' instead of EMACS_INT.
2317 * search.c (string_match_1, fast_string_match)
2318 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2319 (scan_buffer, find_next_newline_no_quit)
2320 (find_before_next_newline, search_command, Freplace_match)
2321 (Fmatch_data): Make some `int' variables be EMACS_INT.
2322
2323 * xdisp.c (display_count_lines): 3rd argument and return value now
2324 EMACS_INT. All callers changed.
2325 (pint2hrstr): Last argument is now EMACS_INT.
2326
2327 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2328 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2329 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2330 (decode_coding_utf_16, decode_coding_emacs_mule)
2331 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2332 (decode_coding_ccl, decode_coding_charset)
2333 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2334 (decode_coding_iso_2022, decode_coding_emacs_mule)
2335 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2336 <char_offset, last_offset>: Declare EMACS_INT.
2337 (encode_coding_utf_8, encode_coding_utf_16)
2338 (encode_coding_emacs_mule, encode_invocation_designation)
2339 (encode_designation_at_bol, encode_coding_iso_2022)
2340 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2341 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2342 Declare EMACS_INT.
2343 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2344 (encode_invocation_designation): Last argument P_NCHARS is now
2345 EMACS_INT.
2346 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2347 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2348
2349 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2350 All users changed.
2351
2352 * ccl.c (Fccl_execute_on_string): Declare some variables
2353 EMACS_INT.
2354
8546720e 23552011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2356
2357 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2358
4e19a977
CS
23592011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2360
2361 * process.c (Fformat_network_address): Doc fix.
2362
87302331
R
23632011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2364
2365 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2366
cbb59342
CY
23672011-04-08 Chong Yidong <cyd@stupidchicken.com>
2368
2369 * keyboard.c (read_char): Call Lisp function help-form-show,
2370 instead of using internal_with_output_to_temp_buffer.
2371 (Qhelp_form_show): New var.
e0d38eeb 2372 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2373
2374 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2375
2376 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2377
e67a13ab
CY
23782011-04-06 Chong Yidong <cyd@stupidchicken.com>
2379
04f2d78b
CB
2380 * process.c (Flist_processes): Remove to Lisp.
2381 (list_processes_1): Delete.
e67a13ab 2382
973f782d
EZ
23832011-04-06 Eli Zaretskii <eliz@gnu.org>
2384
7c106b1e
EZ
2385 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2386
973f782d
EZ
2387 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2388
41cf7d1a 23892011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2390
ca23cc88
PE
2391 Fix more problems found by GCC 4.6.0's static checks.
2392
f390e2d5
PE
2393 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2394
42eea0d0
PE
2395 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2396
b69769da 2397 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2398
f9541e84
PE
2399 * xdisp.c (vmessage): Mark as a printf-like function.
2400
13841b55
PE
2401 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2402
c136c10f
PE
2403 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2404
5e2d4a30
PE
2405 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2406 printf-like functions.
2407 (tiff_load): Add casts to remove these marks before passing them
2408 to system-supplied API.
2409
583f48b9
PE
2410 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2411
b25d760e
PE
2412 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2413 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2414 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2415 directly, rather than having caller test rule sign. This avoids
2416 some unnecessary tests.
2417 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2418 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2419 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2420
bc7b6697 2421 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2422 (xfont_open): Avoid unnecessary tests.
bc7b6697 2423
27ccc379
PE
2424 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2425
dcd5c89a
PE
2426 * composite.h, composite.c (composition_gstring_put_cache):
2427 Use EMACS_INT, not int, for length.
2428
b13a45c6
PE
2429 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2430 breaking out part of COMPOSITION_DECODE_RULE.
2431 (COMPOSITION_DECODE_RULE): Use it.
2432 * composite.c (get_composition_id): Remove unused local vars,
2433 by using the new macro.
2434
1e792e4d
PE
2435 * textprop.c (set_text_properties_1): Change while to do-while,
2436 since the condition is always true at first.
2437
dc6c6455 2438 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2439 (interval_deletion_adjustment): Return unsigned value.
2440 All uses changed.
dc6c6455 2441
aba7731a
PE
2442 * process.c (list_processes_1, create_pty, read_process_output):
2443 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2444 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2445 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2446 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2447 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2448
fdfc4bf3
PE
2449 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2450
fca8fe46 2451 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2452 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2453
06a0259a 2454 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2455 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2456 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2457
e7b9e80f
PE
2458 * print.c (print_error_message): Avoid int overflow.
2459
56201685
PE
2460 * font.c (font_list_entities): Redo for clarity,
2461 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2462
78834453 2463 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2464 (font_score): Avoid potential overflow in diff calculation.
78834453 2465
0bc0b309 2466 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2467 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2468
e610eaca
PE
2469 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2470
b895abce
PE
2471 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2472 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2473 can always succeed if overflow has undefined behavior.
2474
1f1d9321 2475 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2476 (wordify): Omit three unnecessary tests.
1f1d9321 2477
c59478bc
PE
2478 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2479 All callers changed. This avoids the need for an unused var.
2480
79b73827
PE
2481 * casefiddle.c (casify_region): Remove var that is set but not used.
2482
a4db5dfe
PE
2483 * dired.c (file_name_completion): Remove var that is set but not used.
2484
43aae36e
PE
2485 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2486
2a47c44d 2487 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2488 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2489
a37c69bf
PE
2490 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2491 Check for integer overflow on size calculations.
2492
328ab8e7
PE
2493 * buffer.c (Fprevious_overlay_change): Remove var that is set
2494 but not used.
2495
e5a2a5cb
PE
2496 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2497 Remove vars that are set but not used.
8d84a6eb 2498 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2499 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2500
a60e5f68
PE
2501 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2502
f661cb61 2503 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2504 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2505
f0397f5a
PE
2506 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2507 that are set but not used.
2508
8664db06 2509 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2510 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2511
6abdaa4a
PE
2512 * xselect.c (x_get_local_selection, x_handle_property_notify):
2513 Remove vars that are set but not used.
2514
0ce7538d 2515 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2516 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2517
9ae848fc
PE
2518 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2519 Remove var that is set but not used.
0b918413
PE
2520 (scroll_bar_windows_size): Now size_t, not int.
2521 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2522 Check for overflow.
9ae848fc 2523
a5a62657
PE
2524 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2525 (map_tty_color) [!defined MSDOS]: Likewise.
2526
5c5cdd39
PE
2527 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2528
66ebf983
PE
2529 * coding.c: Remove vars that are set but not used.
2530 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2531 All callers changed.
2532 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2533 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2534 (decode_coding_charset): Remove vars that are set but not used.
2535
1be4d761
PE
2536 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2537 that is set but not used.
2538
47553fa8
PE
2539 * print.c (print_object): Remove var that is set but not used.
2540
1f7196bf 2541 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2542 The gnulib version avoids calling malloc in the usual case,
2543 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2544 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2545 * filelock.c (current_lock_owner): Likewise.
2546 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2547 * sysdep.c: Include allocator.h, careadlinkat.h.
2548 (emacs_no_realloc_allocator): New static constant.
2549 (emacs_readlink): New function.
fdb61804
PE
2550 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2551 ../lib/careadlinkat.h.
d1fdcab7 2552
f84c17c7
SM
25532011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2554
2555 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2556 first non-nil return value).
2557
ef3862ad
JD
25582011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2559
2560 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2561 if not defined (Bug#8403).
2562
376a7006
JB
25632011-04-02 Juanma Barranquero <lekktu@gmail.com>
2564
2565 * xdisp.c (display_count_lines): Remove parameter `start',
2566 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2567 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2568 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2569 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2570 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2571 and thereabouts. All callers changed.
2572 (get_per_char_metric): Remove parameter `f', unused since
2573 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2574
6ca3801d
JM
25752011-04-02 Jim Meyering <meyering@redhat.com>
2576
2577 do not dereference NULL upon failed strdup
2578 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2579 (ns_get_family): Likewise.
2580
d8e2b5ba
JB
25812011-04-02 Juanma Barranquero <lekktu@gmail.com>
2582
2583 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2584
8c74fcbd
JD
25852011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2586
2587 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2588 later (Bug#8403).
2589
7200d79c
SM
25902011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2591
03408648 2592 Add lexical binding.
7200d79c 2593
03408648
SM
2594 * window.c (Ftemp_output_buffer_show): New fun.
2595 (Fsave_window_excursion):
2596 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2597
2598 * lread.c (lisp_file_lexically_bound_p): New function.
2599 (Fload): Bind Qlexical_binding.
2600 (readevalloop): Remove `evalfun' arg.
2601 Bind Qinternal_interpreter_environment.
2602 (Feval_buffer): Bind Qlexical_binding.
2603 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2604 Mark as dynamic.
2605 (syms_of_lread): Declare `lexical-binding'.
2606
2607 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2608
2609 * keyboard.c (eval_dyn): New fun.
2610 (menu_item_eval_property): Use it.
ca105506
SM
2611
2612 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2613
03408648
SM
2614 * fns.c (concat, mapcar1): Accept byte-code-functions.
2615
2616 * eval.c (Fsetq): Handle lexical vars.
2617 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2618 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2619 (FletX, Flet): Obey lexical binding.
2620 (Fcommandp): Handle closures.
2621 (Feval): New `lexical' arg.
2622 (eval_sub): New function extracted from Feval. Use it almost
2623 everywhere where Feval was used. Look up vars in lexical env.
2624 Handle closures.
2625 (Ffunctionp): Move from subr.el.
2626 (Ffuncall): Handle closures.
2627 (apply_lambda): Remove `eval_flags'.
2628 (funcall_lambda): Handle closures and new byte-code-functions.
2629 (Fspecial_variable_p): New function.
2630 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2631 but without exporting it to Lisp.
23aba0ea 2632
23aba0ea 2633 * doc.c (Fdocumentation, store_function_docstring):
03408648 2634 * data.c (Finteractive_form): Handle closures.
23aba0ea 2635
03408648
SM
2636 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2637 interactive spec.
ba83908c 2638
04f2d78b
CB
2639 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2640 New byte-codes.
03408648
SM
2641 (exec_byte_code): New function extracted from Fbyte_code to handle new
2642 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2643
03408648 2644 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2645
03408648 2646 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2647
e2abce01
JB
26482011-03-31 Juanma Barranquero <lekktu@gmail.com>
2649
2650 * xdisp.c (redisplay_internal): Fix prototype.
2651
63696a73 26522011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2653
63696a73 2654 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
2655 (try_scrolling): Use it when setting scroll_limit.
2656 Limit scrolling to 100 screen lines.
63696a73
EZ
2657 (redisplay_window): Even when falling back on "recentering",
2658 position point in the window according to scroll-conservatively,
2659 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2660
2661 (try_scrolling): When point is above the window, allow searching
2662 as far as scroll_max, or one screenful, to compute vertical
2663 distance from PT to the scroll margin position. This prevents
2664 try_scrolling from unnecessarily failing when
2665 scroll-conservatively is set to a value slightly larger than the
2666 window height. Clean up the case of PT below the margin at bottom
2667 of window: scroll_max can no longer be INT_MAX. When aggressive
2668 scrolling is in use, don't let point enter the opposite scroll
2669 margin as result of the scroll.
2670 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2671 threshold of 100 lines for never-recentering scrolling.
2672
e4cc2dfc
JB
26732011-03-31 Juanma Barranquero <lekktu@gmail.com>
2674
2675 * dispextern.h (move_it_by_lines):
2676 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2677 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2678 (message_log_check_duplicate): Remove parameters `prev_bol' and
2679 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2680 (redisplay_internal): Remove parameter `preserve_echo_area',
2681 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2682
2683 * indent.c (Fvertical_motion):
2684 * window.c (window_scroll_pixel_based, Frecenter):
2685 Don't pass `need_y_p' to `move_it_by_lines'.
2686
1c470562
SM
26872011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2688
44f230aa
SM
2689 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2690 steal a few bits to be more compact.
2691 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2692 Remove unneeded casts.
2693
1c470562
SM
2694 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2695
888adce9
ZK
26962011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2697
2698 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2699 binding" message (bug#7967).
2700
f838ed7b
PE
27012011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2702
77861b95
PE
2703 Fix more problems found by GCC 4.6.0's static checks.
2704
de6dbc14
PE
2705 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2706 Remove unused local var.
2707
f838ed7b
PE
2708 * editfns.c (Fmessage_box): Remove unused local var.
2709
792c7b2b
PE
2710 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2711 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2712 Omit unused local vars.
c499e557 2713 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2714 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2715 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2716 Omit unused local var.
2717
ba0165e1
PE
2718 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2719 Don't assume string length fits in int.
32ad8845 2720 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2721 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2722
3c59b4c9
PE
2723 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2724 instead of alloca (Bug#8344).
2725
a3eed478 2726 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2727 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2728
eb4d412d
PE
2729 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2730
1658b401
PE
2731 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2732 concerns.
2733
2734 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2735
2736 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2737
9a2c6e05
PE
2738 * keyboard.c (syms_of_keyboard): Use the same style as later
2739 in this function when indexing through an array. This also
2740 works around GCC bug 48267.
2741
03d0a109
PE
2742 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2743
44f730c8
PE
2744 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2745
fe75f926
PE
2746 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2747 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2748
ffa8c828
PE
2749 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2750 This avoids undefined behavior on integer overflow, and is a bit
2751 more convenient anyway since it is compared to a size_t variable.
2752
c5101a77
PE
2753 Variadic C functions now count arguments with size_t, not int.
2754 This avoids an unnecessary limitation on 64-bit machines, which
2755 caused (substring ...) to crash on large vectors (Bug#8344).
2756 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2757 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2758 All variadic functions and their callers changed accordingly.
c5101a77
PE
2759 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2760 * data.c (arith_driver, float_arith_driver): Likewise.
2761 * editfns.c (general_insert_function): Likewise.
2762 * eval.c (struct backtrace.nargs, interactive_p)
2763 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2764 (funcall_lambda, mark_backtrace): Likewise.
2765 * fns.c (concat): Likewise.
2766 * frame.c (x_set_frame_parameters): Likewise.
2767 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2768 0 if not found, not -1. All callers changed.
2769
dd3f25f7
PE
2770 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2771 (stack_copy_size): Now size_t, not int.
2772 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2773
461c2ab9
JB
27742011-03-28 Juanma Barranquero <lekktu@gmail.com>
2775
2776 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2777 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2778 All callers changed.
2779
2780 * lisp.h (multibyte_char_to_unibyte):
2781 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2782 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2783 * character.h (CHAR_TO_BYTE8):
2784 * cmds.c (internal_self_insert):
2785 * editfns.c (general_insert_function):
2786 * keymap.c (push_key_description):
2787 * search.c (Freplace_match):
2788 * xdisp.c (message_dolog, set_message_1): All callers changed.
2789
f6d62986
SM
27902011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2791
2792 * keyboard.c (safe_run_hook_funcall): New function.
2793 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2794 don't set the hook to nil, but remove the offending function instead.
2795 (Qcommand_hook_internal): Remove, unused.
2796 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2797 Vcommand_hook_internal.
2798
2799 * eval.c (enum run_hooks_condition): Remove.
2800 (funcall_nil, funcall_not): New functions.
2801 (run_hook_with_args): Call each function through a `funcall' argument.
2802 Remove `cond' argument, now redundant.
2803 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2804 (Frun_hook_with_args_until_failure): Adjust accordingly.
2805 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2806
1db5b1ad
JB
28072011-03-28 Juanma Barranquero <lekktu@gmail.com>
2808
2809 * dispextern.h (string_buffer_position): Remove declaration.
2810
2811 * print.c (strout): Remove parameter `multibyte', unused since
2812 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2813
2814 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2815 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2816 All callers changed.
2817
2818 * w32.c (_wsa_errlist): Use braces for struct initializers.
2819
2820 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2821 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2822 All callers changed.
2823 (string_buffer_position): Likewise. Also, make static (it's never
2824 used outside xdisp.c).
2825 (cursor_row_p): Remove parameter `w', unused since
2826 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2827 (decode_mode_spec): Remove parameter `precision', introduced during
2828 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2829 All callers changed.
2830
5ffb62aa
JD
28312011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2832
2833 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2834
461c2ab9 28352011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2836
2837 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2838 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2839 (ns_update_auto_hide_menu_bar): New functions.
2840 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2841 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2842 ns_constrain_all_frames.
2843 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2844 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2845
5c380ffb
JD
28462011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2847
2848 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2849
9af30bdf
GM
28502011-03-27 Glenn Morris <rgm@gnu.org>
2851
2852 * syssignal.h: Replace RETSIGTYPE with void.
2853 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2854 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2855 Replace SIGTYPE with void everywhere.
2856 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2857 * s/template.h (SIGTYPE): Remove commented out definition.
2858
e2abce01
JB
28592011-03-26 Eli Zaretskii <eliz@gnu.org>
2860
2861 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2862 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2863
f868cd8a
JB
28642011-03-26 Juanma Barranquero <lekktu@gmail.com>
2865
59eb0929
JB
2866 * w32.c (read_unc_volume): Use parameter `henum', instead of
2867 global variable `wget_enum_handle'.
2868
2869 * keymap.c (describe_vector): Remove parameters `indices' and
2870 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2871 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2872
f868cd8a
JB
2873 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2874
2875 * keyboard.c (timer_check): Remove parameter `do_it_now',
2876 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2877 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2878 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2879
2880 * keyboard.c (read_char):
2881 * w32menu.c (w32_menu_display_help):
2882 * xmenu.c (show_help_event, menu_help_callback):
2883 Adjust calls to `show_help_echo'.
2884
2885 * gtkutil.c (xg_maybe_add_timer):
2886 * keyboard.c (readable_events):
2887 * process.c (wait_reading_process_output):
2888 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2889
2890 * insdel.c (adjust_markers_gap_motion):
2891 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2892 (gap_left, gap_right): Don't call it.
2893
2ecf6fdb
CY
28942011-03-25 Chong Yidong <cyd@stupidchicken.com>
2895
2896 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2897 incurred during fontification.
2898
6b1f9ba4
JB
28992011-03-25 Juanma Barranquero <lekktu@gmail.com>
2900
2901 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2902 (DEFVAR_PER_BUFFER): Don't pass it.
2903
2904 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2905 (scrolling_window): Don't pass it.
2906
0f4a96b5
JB
29072011-03-25 Juanma Barranquero <lekktu@gmail.com>
2908
2909 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2910
2911 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2912 and `suffix'.
2913 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2914 of variables specific to SELinux and computation of `encoded_absname'.
2915
2916 * image.c (XPutPixel): Remove unused variable `height'.
2917
2918 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2919
2920 * unexw32.c (get_section_info): Remove unused variable `section'.
2921
2922 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2923 (system_process_attributes): Remove unused variable `sess'.
2924 (sys_read): Remove unused variable `err'.
2925
2926 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2927 (w32_wnd_proc): Remove unused variable `isdead'.
2928 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2929 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2930 (x_create_tip_frame): Remove unused variable `tem'.
2931
2932 * w32inevt.c (w32_console_read_socket):
2933 Remove unused variable `no_events'.
2934
2935 * w32term.c (x_draw_composite_glyph_string_foreground):
2936 Remove unused variable `width'.
2937
1149507c
JB
29382011-03-24 Juanma Barranquero <lekktu@gmail.com>
2939
2940 * w32term.c (x_set_glyph_string_clipping):
2941 Don't pass uninitialized region to CombineRgn.
2942
9c88f339
JB
29432011-03-23 Juanma Barranquero <lekktu@gmail.com>
2944
2945 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2946 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2947 (Fx_close_connection): Remove unused variable `i'.
2948
2949 * w32font.c (w32font_draw): Return number of glyphs.
2950 (w32font_open_internal): Remove unused variable `i'.
2951 (w32font_driver): Add missing initializer.
2952
2953 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2954 (fill_in_menu): Remove unused variable `items_added'.
2955
2956 * w32term.c (last_mouse_press_frame): Remove static global variable.
2957 (w32_clip_to_row): Remove unused variable `f'.
2958 (x_delete_terminal): Remove unused variable `i'.
2959
2960 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2961 (NOTHING): Remove unused static global variable.
2962 (uniscribe_check_otf): Remove unused variable `table'.
2963 (uniscribe_font_driver): Add missing initializers.
2964
dee091a3
JD
29652011-03-23 Julien Danjou <julien@danjou.info>
2966
2967 * term.c (Fsuspend_tty, Fresume_tty):
2968 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2969 * window.c (temp_output_buffer_show):
2970 * insdel.c (signal_before_change):
2971 * frame.c (Fhandle_switch_frame):
2972 * fileio.c (Fdo_auto_save):
2973 * emacs.c (Fkill_emacs):
2974 * editfns.c (save_excursion_restore):
2975 * cmds.c (internal_self_insert):
2976 * callint.c (Fcall_interactively):
2977 * buffer.c (Fkill_all_local_variables):
2978 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2979 Use Frun_hooks.
0f4a96b5 2980 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2981 unconditionnaly since it does the check itself.
2982
2c520ab5 29832011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2984
c9c49752
PE
2985 Fix more problems found by GCC 4.5.2's static checks.
2986
8abc3f12
PE
2987 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2988 the first time through the loop, since we know p0 < p1 then.
2989 This also avoids a gcc -Wstrict-overflow warning.
2990
a2d26660
PE
2991 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2992 leading to a memory leak, possible in functions like
2993 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2994 of objects (Bug#8318).
a2d26660 2995
916c72e9
PE
2996 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2997 that could (at least in theory) be that large.
2998
19ab8a18
PE
2999 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3000 This is less likely to overflow, and avoids undefined behavior if
3001 overflow does occur. All callers changed. Use strtoul to scan
3002 for the unsigned long integer.
b7cbbd6f
PE
3003 (pint2hrstr): Simplify and tune code slightly.
3004 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3005
f0641eff
PE
3006 * scroll.c (do_scrolling): Work around GCC bug 48228.
3007 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3008
7f650bb9
PE
3009 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3010 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3011 (validate_x_resource_name): Simplify count usage.
3012 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3013
37dd57d1
PE
3014 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3015 fail (Bug#8306).
81e56e61 3016
699979fc 3017 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3018
401bf9b4
PE
3019 * process.c (Fmake_network_process): Use socklen_t, not int,
3020 where POSIX says socklen_t is required in portable programs.
3021 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3022 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3023 (Fmake_network_process, server_accept_connection):
3024 (wait_reading_process_output, read_process_output):
3025 Likewise.
3026
b93aacde
PE
3027 * process.c: Rename or move locals to avoid shadowing.
3028 (list_processes_1, Fmake_network_process):
3029 (read_process_output_error_handler, exec_sentinel_error_handler):
3030 Rename or move locals.
4dc343ee 3031 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3032 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3033 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3034 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3035 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3036
af8a867c 3037 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3038 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3039 Include tparam.h instead, since it declares them.
af8a867c
PE
3040 * cm.h (PC): Remove extern decl; tparam.h now does this.
3041 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3042 * terminfo.c: Include tparam.h, to check interfaces.
3043 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3044 (tparam): Adjust signature to match interface in tparam.h;
3045 this removes some undefined behavior. Check that outstring and len
3046 are zero, which they always are with Emacs.
3047 * tparam.h (PC, BC, UP): New extern decls.
3048
0248044d 3049 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3050 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3051
8ff096c1 3052 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3053 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3054 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3055 (ftfont_list): Remove unused local.
49eaafba
PE
3056 (get_adstyle_property, ftfont_pattern_entity):
3057 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3058 Rename locals to avoid shadowing.
8ff096c1 3059
e2be39f6
PE
3060 * xfont.c (xfont_list_family): Mark var as initialized.
3061
c9735e30
PE
3062 * xml.c (make_dom): Now static.
3063
8f5201ae
PE
3064 * composite.c (composition_compute_stop_pos): Rename local to
3065 avoid shadowing.
b246f932
PE
3066 (composition_reseat_it): Remove unused locals.
3067 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3068 (composition_update_it): Mark var as initialized.
11b61122
PE
3069 (find_automatic_composition): Mark vars as initialized,
3070 with a FIXME (Bug#8290).
8f5201ae 3071
760fbc2c
PE
3072 character.h: Rename locals to avoid shadowing.
3073 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3074 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3075 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3076 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3077 to avoid shadowing.
3078
ff08eb85
PE
3079 * textprop.c (property_change_between_p): Remove; unused.
3080
fc7bf025
PE
3081 * intervals.c (interval_start_pos): Now static.
3082
235d7abc
PE
3083 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3084
44f230aa
SM
3085 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3086 Rename locals to avoid shadowing.
3e7d6594 3087
50060332
PE
3088 * sound.c (wav_play, au_play, Fplay_sound_internal):
3089 Fix pointer signedness.
d01f234b 3090 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3091 (wav_play): Initialize a variable to 0, to prevent undefined
3092 behavior (Bug#8278).
50060332 3093
c4fc4e30
PE
3094 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3095
918436ed
PE
3096 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3097
c939f91b
PE
3098 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3099 clobbering (Bug#8298).
b9c7f648
PE
3100 * sysdep.c (sys_subshell): Likewise.
3101 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3102
6bd8c144
PE
3103 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3104 This should get cleaned up, so that child_setup has the
3105 same signature on all platforms.
3106
7710357c 3107 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3108 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3109
c59da222
CY
31102011-03-22 Chong Yidong <cyd@stupidchicken.com>
3111
3112 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3113 not to be necessary, and produces flickering.
3114
66b87493
GM
31152011-03-20 Glenn Morris <rgm@gnu.org>
3116
3117 * config.in: Remove file.
3118
45b6f6d5
JB
31192011-03-20 Juanma Barranquero <lekktu@gmail.com>
3120
3121 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3122 are now in src/globals.h.
3123 (syms_of_minibuf): Remove spurious & from previous change.
3124
3ec03f7e
LL
31252011-03-20 Leo <sdl.web@gmail.com>
3126
3127 * minibuf.c (completing-read-function): New variable.
3128 (completing-read-default): Rename from completing-read.
3129 (completing-read): Call completing-read-function.
3130
b14e3e21
CY
31312011-03-19 Juanma Barranquero <lekktu@gmail.com>
3132
3133 * xfaces.c (Fx_load_color_file):
3134 Read color file from absolute filename (bug#8250).
3135
f2b726e6
JB
31362011-03-19 Juanma Barranquero <lekktu@gmail.com>
3137
3138 * makefile.w32-in: Update dependencies.
3139
09f6ff02
EZ
31402011-03-17 Eli Zaretskii <eliz@gnu.org>
3141
3142 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3143
29a6015a
PE
31442011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3145
a3a6c54e
PE
3146 Fix more problems found by GCC 4.5.2's static checks.
3147
b766f867
PE
3148 * process.c (make_serial_process_unwind, send_process_trap):
3149 (sigchld_handler): Now static.
3150
be02381c
PE
3151 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3152 That way, the code declares only the vars that it needs.
3153 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3154 * s/cygwin.h (PTY_ITERATION): Likewise.
3155 * s/darwin.h (PTY_ITERATION): Likewise.
3156 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3157
57048744
PE
3158 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3159 * process.c (allocate_pty): Don't declare stb unless it's needed.
3160
7914961c 3161 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3162 (CONSTANTLIM): Remove; unused.
3163 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3164 Define only if needed.
7914961c 3165
b3967b18
PE
3166 * unexelf.c (unexec): Name an expression,
3167 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3168 Use a different way to cause a compilation error if anyone uses
3169 n rather than nn, a way that does not involve shadowing.
73366a00 3170 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3171
29a6015a
PE
3172 * deps.mk (unexalpha.o): Remove; unused.
3173
43cfc33e 3174 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3175 * unexec.h: New file.
ce701a33
PE
3176 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3177 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3178 Depend on unexec.h.
3179 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3180 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3181 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3182 Change as necessary to match prototype in unexec.h.
ce701a33 3183
01f44d5a
PE
3184 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3185 shadowing.
4f63c6bb 3186 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3187
a6670b0b
PE
3188 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3189 Rename locals to avoid shadowing.
3190
cef2010d 3191 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3192 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3193
d4d7173a
PE
3194 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3195
f08b802a
PE
3196 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3197 warning when compiling print.c.
3198
3ddb0639
PE
3199 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3200 instead of using an uninitialized var.
5ad03b97 3201 (font_sort_entities): Mark var as initialized.
3ddb0639 3202
170a2692
PE
3203 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3204
e663c700
PE
3205 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3206 pointers to constants.
89bc529a 3207 (font_parse_fcname): Remove unused vars.
7b81e2d0 3208 (font_delete_unmatched): Now static.
ea838e10 3209 (font_get_spec): Remove; unused.
13a547c6
PE
3210 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3211 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3212 Rename or move locals to avoid shadowing.
e663c700 3213
2a80c887 3214 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3215 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3216
1384fa33 3217 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3218 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3219
8b2c52e9
PE
3220 * alloc.c (mark_backtrace): Move decl from here ...
3221 * lisp.h: ... to here, so that it can be checked.
3222
475545b5 3223 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3224 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3225 (lisp_indirect_variable): Name an expression,
3226 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3227 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3228
b1349114 3229 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3230 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3231 Use const pointer when appropriate.
b1349114 3232
a2928364
PE
3233 * lisp.h (get_system_name, get_operating_system_release):
3234 Move decls here, to check interfaces.
3235 * process.c (get_operating_system_release): Move decl to lisp.h.
3236 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3237 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3238 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3239 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3240 (Fformat_time_string, Fencode_time, Finsert_char):
3241 (Ftranslate_region_internal, Fformat):
3242 Rename or remove local vars to avoid shadowing.
9710023e 3243 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3244
a415e694
PE
3245 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3246 avoid shadowing.
3247
8ef4622d
PE
3248 * lisp.h (eassert): Check that the argument compiles, even if
3249 ENABLE_CHECKING is not defined.
3250
946f9a5b
PE
3251 * data.c (Findirect_variable): Name an expression, to avoid
3252 gcc -Wbad-function-cast warning.
112396d6 3253 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3254 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3255 (Fmake_variable_buffer_local, Fmake_local_variable):
3256 Mark variables as initialized.
52746918 3257 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3258
e5aab7e7 3259 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3260 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3261 Rename locals to avoid shadowing.
dff45157
PE
3262 (mark_stack): Move local variables into the #ifdef region where
3263 they're used.
7bc26fdb
PE
3264 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3265 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3266 needed otherwise.
3267 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3268 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3269 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3270
e5aab7e7
PE
3271 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3272 avoids undefined behavior in theory.
3273
4da60324
PE
3274 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3275
88043301
PE
3276 Use functions, not macros, for up- and down-casing (Bug#8254).
3277 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3278 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3279 to use the following functions instead of these macros.
3280 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3281 EMACS_INT, since callers assume the returned value fits in int.
3282 (upcase1): Likewise, for UPCASE_TABLE.
3283 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3284 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3285 the race-condition problem in the old DOWNCASE.
88043301 3286
19ed5445
PE
3287 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3288 Rename locals to avoid shadowing.
3289 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3290 (regex_compile, re_search_2, re_match_2_internal):
3291 Remove unused local vars.
952db0d7
PE
3292 (FREE_VAR): Rewrite so as not to use empty "else",
3293 which gcc can warn about.
da053e48 3294 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3295 (RETALLOC_IF): Define only if needed.
3296 (WORDCHAR_P): Likewise. This one is never needed, but is used
3297 only in a comment talking about a compiler bug, so put inside
3298 the #if 0 of that comment.
3299 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3300 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3301 Remove; unused.
19ed5445 3302
1f3561e4 3303 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3304 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3305 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3306
ded6f8f7
PE
3307 * search.c (simple_search): Remove unused var.
3308
dbd37a95
PE
3309 * dired.c (compile_pattern): Move decl from here ...
3310 * lisp.h: ... to here, so that it can be checked.
3311 (struct re_registers): New forward decl.
3312
7e47afad
PE
3313 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3314
85f24f61
PE
3315 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3316 All uses changed.
3317 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3318 Rename locals to avoid shadowing.
5671df8f 3319 (Fvertical_motion): Mark locals as initialized.
85f24f61 3320
181aa2be 3321 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3322 (casify_region): Mark local as initialized.
181aa2be 3323
930d429c
PE
3324 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3325
7082eac6
PE
3326 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3327 New macros, so that the caller can use some names other than
3328 gcpro1, gcpro2, etc.
3329 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3330 of the new macros.
3331 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3332 argument, for consistency with GCPRO2_VAR, etc: it is now the
3333 prefix of the variable, not the variable itself. All uses
3334 changed.
38b2c076
PE
3335 * dired.c (directory_files_internal, file_name_completion):
3336 Rename locals to avoid shadowing.
3337
15206ed9
PE
3338 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3339 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3340 dired.c's scmp function, had undefined behavior.
3341 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3342 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3343 * buffer.h: ... to here, because these macros use current_buffer,
3344 and the new implementation with inline functions needs to have
3345 current_buffer in scope now, rather than later when the macros
3346 are used.
3347 (downcase, upcase1): New static inline functions.
3348 (DOWNCASE, UPCASE1): Reimplement using these functions.
3349 This avoids undefined behavior in expressions like
3350 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3351 from race conditions in accessing the global variables
3352 case_temp1 and case_temp2.
3353 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3354 * lisp.h (case_temp1, case_temp2): Remove their decls.
3355 * character.h (ASCII_CHAR_P): Move from here ...
3356 * lisp.h: ... to here, so that the inline functions mentioned
3357 above can use them.
3358
4a6bea26
PE
3359 * dired.c (directory_files_internal_unwind): Now static.
3360
f14b7e14
PE
3361 * fileio.c (file_name_as_directory, directory_file_name):
3362 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3363 Now static.
2893f146
PE
3364 (file_name_as_directory): Use const pointers when appropriate.
3365 (Fexpand_file_name): Likewise. In particular, newdir might
3366 point at constant storage, so make it a const pointer.
fd4ead52 3367 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3368 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3369 signedness issues.
f839df0c
PE
3370 (Fset_file_times, Finsert_file_contents, auto_save_error):
3371 Rename locals to avoid shadowing.
f14b7e14 3372
5716756e 3373 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3374 (Ftry_completion, Fall_completions): Rename or remove locals
3375 to avoid shadowing.
5716756e 3376
b4c3046a
PE
3377 * marker.c (bytepos_to_charpos): Remove; unused.
3378
b45db522
PE
3379 * lisp.h (verify_bytepos, count_markers): New decls,
3380 so that gcc does not warn that these functions aren't declared.
3381
85876d07
PE
3382 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3383 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3384 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3385 (copy_text): Remove unused local var.
85876d07 3386
03d78a21 3387 * filelock.c (within_one_second): Now static.
b3dd38ab 3388 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3389
5df8f01b
PE
3390 * buffer.c (fix_overlays_before): Mark locals as initialized.
3391 (fix_start_end_in_overlays): Likewise. This function should be
3392 simplified by using pointers-to-pointers, but that's a different
3393 matter.
b1d876f1 3394 (switch_to_buffer_1): Now static.
8f54f30a
PE
3395 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3396 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3397
a70072c9 3398 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3399 Fix pointer signedness issue.
edced198
PE
3400 (sys_subshell): Mark local as volatile if checking for lint,
3401 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3402 (MAXPATHLEN): Define only if needed.
a70072c9 3403
a0977c44
PE
3404 * process.c (serial_open, serial_configure): Move decls from here ...
3405 * systty.h: ... to here, so that they can be checked.
3406
a884fdcc
PE
3407 * fns.c (get_random, seed_random): Move extern decls from here ...
3408 * lisp.h: ... to here, so that they can be checked.
3409
604efe86 3410 * sysdep.c (reset_io): Now static.
b8950c94 3411 (wait_for_termination_signal): Remove; unused.
604efe86 3412
38fc62d9
PE
3413 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3414 (copy_keymap_item, append_key, push_text_char_description):
3415 Now static.
1004a21a 3416 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3417 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3418 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3419 (describe_map_tree):
3420 Rename locals to avoid shadowing.
38fc62d9 3421
2f2650da
PE
3422 * keyboard.c: Declare functions static if they are not used elsewhere.
3423 (echo_char, echo_dash, cmd_error, top_level_2):
3424 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3425 (read_char, kbd_buffer_get_event, make_lispy_position):
3426 (make_lispy_event, make_lispy_movement, apply_modifiers):
3427 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3428 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3429 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3430 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3431 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3432
a053e86c 3433 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3434 (mark_kboards): Move decl here ...
3435 * alloc.c (mark_kboards): ... from here.
a053e86c 3436
4752793e
PE
3437 * lisp.h (force_auto_save_soon): New decl.
3438
74f10ca7 3439 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3440 (DEFINE_DUMMY_FUNCTION): New macro.
3441 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3442 Use it.
c03cd23f
PE
3443 (main): Add casts to avoid warnings
3444 if GCC considers string literals to be constants.
74f10ca7 3445
022e70d4
PE
3446 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3447
59d6fe83
PE
3448 * dbusbind.c: Pointer signedness fixes.
3449 (xd_signature, xd_append_arg, xd_initialize):
3450 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3451 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3452 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3453 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3454
78320123
PE
3455 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3456 if GCC considers string literals to be constants.
49cebcca 3457 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3458
35ac2a97
SM
34592011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3460
fb103ca9
SM
3461 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3462 (print_preprocess, print_object): New macro to fix last change.
3463
35ac2a97
SM
3464 * print.c (print_preprocess): Don't forget font objects.
3465
62973b41
JB
34662011-03-16 Juanma Barranquero <lekktu@gmail.com>
3467
3468 * emacs.c (USAGE3): Doc fixes.
3469
0e48bb22
AS
34702011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3471
3472 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3473 structure.
3474
7684e57b
JB
34752011-03-14 Juanma Barranquero <lekktu@gmail.com>
3476
3477 * lisp.h (VWindow_system, Qfile_name_history):
3478 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3479 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3480 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3481
3482 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3483 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3484
3485 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3486 * w32console.c (detect_input_pending, read_input_pending)
3487 (encode_terminal_code):
3488 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3489 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3490 (w32_system_caret_y, Qfile_name_history):
3491 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3492 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3493 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3494 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3495 * w32proc.c (Qlocal, report_file_error):
3496 * w32term.c (Vwindow_system, updating_frame):
3497 * w32uniscribe.c (initialized, uniscribe_font_driver):
3498 Remove unneeded extern declarations.
3499
2aa46d6c
CY
35002011-03-14 Chong Yidong <cyd@stupidchicken.com>
3501
c96bbc66 3502 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3503
cffc6f3b
CY
35042011-03-13 Chong Yidong <cyd@stupidchicken.com>
3505
3506 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3507 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3508 These macros can no longer be used for assignment.
3509
44f230aa
SM
3510 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3511 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3512 (record_buffer_markers, fetch_buffer_markers): New functions for
3513 recording and fetching special buffer markers.
3514 (set_buffer_internal_1, set_buffer_temp): Use them.
3515
3516 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3517
3518 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3519
3520 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3521 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3522
3523 * xdisp.c (hscroll_window_tree):
3524 (reconsider_clip_changes): Use PT instead of BUF_PT.
3525
d251f04b
EZ
35262011-03-13 Eli Zaretskii <eliz@gnu.org>
3527
3528 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3529 $(EMACS_ROOT)/lib/intprops.h.
3530
f0c77cd1
PE
35312011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3532
3eca4629
PE
3533 Fix more problems found by GCC 4.5.2's static checks.
3534
7c86ee98
PE
3535 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3536 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3537 (xg_free_frame_widgets): Make it clear that a local variable is
3538 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3539 (gdk_window_get_screen): Make it clear that this macro is needed
3540 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3541 (int_gtk_range_get_value): New function, which avoids a diagnostic
3542 from gcc -Wbad-function-cast.
3543 (xg_set_toolkit_scroll_bar_thumb): Use it.
3544 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3545 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3546 (get_utf8_string, xg_get_file_with_chooser):
3547 Rename locals to avoid shadowing.
3548 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3549
41729b81
PE
3550 * xgselect.c (xg_select): Remove unused var.
3551
f0c77cd1
PE
3552 * image.c (four_corners_best): Mark locals as initialized.
3553 (gif_load): Initialize transparent_p to zero (Bug#8238).
3554 Mark another local as initialized.
ec6cf4c6 3555 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3556
ce0ad53d 3557 * image.c (clear_image_cache): Now static.
d5d5a617 3558 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3559 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3560 (x_edge_detection): Remove unnecessary cast that
3561 gcc -Wbad-function-cast diagnoses.
2037898d 3562 (gif_load): Fix pointer signedness.
6ae141d6
PE
3563 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3564 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3565
33383987 35662011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3567
d32df629
PE
3568 Improve quality of tests for time stamp overflow.
3569 For example, without this patch (encode-time 0 0 0 1 1
3570 1152921504606846976) returns the obviously-bogus value (-948597
3571 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3572 reports time overflow. See
3573 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3574 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3575 * editfns.c: Include limits.h and intprops.h.
3576 (TIME_T_MIN, TIME_T_MAX): New macros.
3577 (time_overflow): Move earlier, to before first use.
3578 (hi_time, lo_time): New functions, for an accurate test for
3579 out-of-range times.
3580 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3581 (Fget_internal_run_time): Don't assume time_t fits in int.
3582 (make_time): Use list2 instead of Fcons twice.
3583 (Fdecode_time): More accurate test for out-of-range times.
3584 (check_tm_member): New function.
3585 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3586 (lisp_time_argument): Don't rely on undefined left-shift and
3587 right-shift behavior when checking for time stamp overflow.
8be6f318 3588
fe31d94c
PE
3589 * editfns.c (time_overflow): New function, refactoring common code.
3590 (Fformat_time_string, Fdecode_time, Fencode_time):
3591 (Fcurrent_time_string): Use it.
3592
8be6f318
PE
3593 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3594 * dired.c (make_time): Move to ...
3595 * editfns.c (make_time): ... here.
3596 * systime.h: Note the move.
3597
09d9db2c 35982011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3599
126bc0dc
YM
3600 * fringe.c (update_window_fringes): Remove unused variables.
3601
c47cbdfd
YM
3602 * unexmacosx.c (copy_data_segment): Also copy __got section.
3603 (Bug#8223)
3604
7ac80be9
EZ
36052011-03-12 Eli Zaretskii <eliz@gnu.org>
3606
c96bbc66 3607 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3608 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3609 Constify `char *' arguments and their references according to
3610 prototypes in tparam.h.
3611
ecb0f94d 3612 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3613
7ac80be9
EZ
3614 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3615 Adapt all references accordingly.
3616
3617 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3618
ef1fd07e
TT
36192011-03-11 Tom Tromey <tromey@redhat.com>
3620
3621 * buffer.c (syms_of_buffer): Remove obsolete comment.
3622
7ef4b50c
EZ
36232011-03-11 Eli Zaretskii <eliz@gnu.org>
3624
3625 * termhooks.h (encode_terminal_code): Declare prototype.
3626
3627 * msdos.c (encode_terminal_code): Don't declare prototype.
3628
3629 * term.c (encode_terminal_code): Now external again, used by
3630 w32console.c and msdos.c.
3631
44f230aa
SM
3632 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3633 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3634
4b1ec863 36352011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3636
1714f52b 3637 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3638
4b1ec863
PE
3639 * fringe.c (update_window_fringes): Mark locals as initialized
3640 (Bug#8227).
3641 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3642
524c7aa6
PE
3643 * alloc.c (mark_fringe_data): Move decl from here ...
3644 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3645 to check its interface.
3646 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3647
a5c0af81 3648 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3649 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3650 (fontset_font): Mark local as initialized.
a9a06e0b 3651 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3652
b4716021
PE
3653 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3654
811e9bac 3655 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3656 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3657 (x_own_selection, Fx_disown_selection_internal): Rename locals
3658 to avoid shadowing.
3659 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3660
7e3ab302
PE
3661 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3662 so that the caller can use some name other than gcpro1.
3663 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3664 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3665 (Fx_backspace_delete_keys_p):
3666 Use them to avoid shadowing, and rename vars to avoid shadowing.
3667 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3668 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3669 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3670 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3671 Remove unused locals.
7e3ab302
PE
3672 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3673 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3674 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3675 macros.
f78faa98 3676
e2b13473
PE
3677 * xterm.h (x_mouse_leave): New decl.
3678
77f23912
PE
3679 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3680 Remove unused functions.
cdf4ba58
PE
3681 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3682 (x_calc_absolute_position): Now static.
7411c686 3683 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3684 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3685 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3686 unless they are used.
38d0b34a
PE
3687 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3688 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3689 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3690 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3691 (x_error_catcher, x_connection_closed, x_error_handler):
3692 (x_error_quitter, xembed_send_message, x_iconify_frame):
3693 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3694 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3695 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3696
44f230aa
SM
3697 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3698 Rename or move locals to avoid shadowing.
6b463e58 3699 (tty_defined_color, merge_face_heights): Now static.
5967d051 3700 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3701 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3702 does not deduce is never used uninitialized.
73719eba
PE
3703 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3704 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3705
426994c3 3706 * terminal.c (store_terminal_param): Now static.
5489860b 3707
032f1620 3708 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3709 (set_frame_menubar): Remove unused local.
d4323972 3710 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3711 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3712 since they might point to immutable storage.
281585b0
PE
3713 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3714 since it's unused otherwise.
032f1620 3715
367c19e5 3716 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3717 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3718 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3719 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3720 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3721 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3722 does not deduce are never used uninitialized.
70739cbe 3723
07b48fa9
PE
3724 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3725
8868a238 3726 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3727 * window.c (window_loop, size_window):
3728 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3729
7e5cf297 3730 * window.c (display_buffer): Now static.
d6550a9f
PE
3731 (size_window): Mark variables that gcc -Wuninitialized
3732 does not deduce are never used uninitialized.
a586633d
PE
3733 * window.h (check_all_windows): New decl, to forestall
3734 gcc -Wmissing-prototypes diagnostic.
5b555da1 3735 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3736
f6095868
PE
3737 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3738 shadowing.
3739 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3740 Include <limits.h>.
3741 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3742 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3743 (load_charset_map): Mark variables that gcc -Wuninitialized
3744 does not deduce are never used uninitialized.
53df7c11 3745 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3746
f38b440c
PE
3747 * coding.c (coding_set_source, coding_set_destination):
3748 Use "else { /* comment */ }" rather than "else /* comment */;"
3749 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3750 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3751 a block, when the outer 'i' will do.
3752 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3753 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3754 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3755 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3756 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3757 Rename locals to avoid shadowing.
3758 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3759 * coding.c (emacs_mule_char, encode_invocation_designation):
3760 Now static, since they're not used elsewhere.
413bb2db 3761 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3762 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3763 (decode_coding_emacs_mule): Mark variables that gcc
3764 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3765 (detect_coding_iso_2022): Initialize a local variable that might
3766 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3767 this initialization is needed. (Bug#8211)
5f58e762
PE
3768 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3769 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3770 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3771 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3772 Remove unused macros.
f38b440c 3773
232b38b9 3774 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3775 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3776 * character.c (string_count_byte8): Likewise.
232b38b9 3777
fb90da1b
PE
3778 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3779 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3780
fb93dbc2
PE
3781 * chartab.c (copy_sub_char_table): Now static, since it's not used
3782 elsewhere.
5c156ace
PE
3783 (sub_char_table_ref_and_range, char_table_ref_and_range):
3784 Rename locals to avoid shadowing.
bbcd0949 3785 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3786
7d3b3862 3787 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3788 (BIDI_BOB): Remove unused macro.
7d3b3862 3789
6be7d3da
PE
3790 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3791 deduce are never used uninitialized.
c2ed9c8b 3792 * term.c (encode_terminal_code): Likewise.
6be7d3da 3793
75f8807f 3794 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3795
50938595
PE
3796 * tparam.h: New file.
3797 * term.c, tparam.h: Include it.
3798 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3799 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3800 Move these decls to tparam.h, and make them agree with what
3801 is actually in tparam.c. The previous trick of using incompatible
3802 decls in different modules does not conform to the C standard.
3803 All callers of tparam changed to use tparam's actual API.
3804 * tparam.c (tparam1, tparam, tgoto):
3805 Use const pointers where appropriate.
3806
fbceeba2
PE
3807 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3808 * cm.h (struct cm): Likewise.
3809 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3810 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3811 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3812 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3813 (turn_on_face, init_tty): Likewise.
3814 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3815
7f3f1250
PE
3816 * term.c (term_mouse_position): Rename local to avoid shadowing.
3817
e6ca6543
PE
3818 * alloc.c (mark_ttys): Move decl from here ...
3819 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3820
c40f8d15
AS
38212011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3822
3823 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3824
cfe0661d
JB
38252011-03-09 Juanma Barranquero <lekktu@gmail.com>
3826
3827 * search.c (compile_pattern_1): Remove argument regp, unused since
3828 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3829 (compile_pattern): Don't pass it.
3830
0afb4571
J
38312011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3832
3833 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3834 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3835 for ! HAVE_GTK3.
3836 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3837
3838 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3839
3840 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3841 gdk_window_get_screen, gdk_window_get_geometry,
3842 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3843 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3844 (xg_get_pixbuf_from_pixmap): New function.
3845 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3846 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3847 Call xg_get_pixbuf_from_pixmap instead of
3848 gdk_pixbuf_get_from_drawable.
3849 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3850 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3851 (xg_check_special_colors): Use GtkStyleContext and its functions
3852 for HAVE_GTK3.
3853 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3854 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3855 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3856 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3857 Call gtk_widget_get_preferred_size.
0afb4571
J
3858 (xg_frame_resized): gdk_window_get_geometry only takes 5
3859 parameters.
44f230aa
SM
3860 (xg_win_to_widget, xg_event_is_for_menubar):
3861 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3862 (xg_set_widget_bg): New function.
3863 (delete_cb): New function.
895009e1 3864 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3865 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3866 (xg_set_background_color): Call xg_set_widget_bg.
3867 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3868 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3869 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3870 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3871 if ! HAVE_GTK3.
3872 (update_frame_tool_bar): Call gtk_widget_hide.
3873 (xg_initialize): Use GDK_KEY_g.
3874
3875 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3876 if ! HAVE_GTK3
3877 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3878
3879 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3880 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3881 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3882
1c2cc4ef
JB
38832011-03-08 Juanma Barranquero <lekktu@gmail.com>
3884
3885 * w32xfns.c (select_palette): Check success of RealizePalette against
3886 GDI_ERROR, not zero.
3887
33383987 3888See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3889
3890;; Local Variables:
3891;; coding: utf-8
aac0c6e3
MR
3892;; End:
3893
33383987 3894 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3895
3896 This file is part of GNU Emacs.
3897
3898 GNU Emacs is free software: you can redistribute it and/or modify
3899 it under the terms of the GNU General Public License as published by
3900 the Free Software Foundation, either version 3 of the License, or
3901 (at your option) any later version.
3902
3903 GNU Emacs is distributed in the hope that it will be useful,
3904 but WITHOUT ANY WARRANTY; without even the implied warranty of
3905 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3906 GNU General Public License for more details.
3907
3908 You should have received a copy of the GNU General Public License
3909 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.