Auto-commit of loaddefs files.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
6c07aac2
AS
12011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2
3 * emacs.c (Qkill_emacs): Define.
4 (syms_of_emacs): Initialize it.
5 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
6 Qquit_flag to `kill-emacs' instead.
7 (quit_throw_to_read_char): Add parameter `from_signal'. All
8 callers changed. Call Fkill_emacs if requested and safe.
9 * lisp.h (QUIT): Call Fkill_emacs if requested.
10
c052ead4
JD
112011-12-03 Jan Djärv <jan.h.d@swipnet.se>
12
13 * widget.c (update_wm_hints): Return if wmshell is null.
14 (widget_update_wm_size_hints): New function.
15
16 * widget.h (widget_update_wm_size_hints): Declare.
17
18 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
19 widget_update_wm_size_hints (Bug#10104).
20
9e49252b
EZ
212011-12-03 Eli Zaretskii <eliz@gnu.org>
22
23 * xdisp.c (handle_invisible_prop): If the invisible text ends just
24 before a newline, prepare the bidi iterator for consuming the
25 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 26 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 27
02b16839
JL
282011-12-02 Juri Linkov <juri@jurta.org>
29
30 * search.c (Fword_search_regexp): New Lisp function created from
31 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
32 (Fword_search_backward, Fword_search_forward)
33 (Fword_search_backward_lax, Fword_search_forward_lax):
34 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
35 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
36
0068070e
SM
372011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
38
39 * fileio.c (Finsert_file_contents): Move after-change-function call
40 to before the "handled:" label, since all "goto handled" appear in
41 cases where the *-change-functions have already been properly called
42 (bug#10117).
43
3360a3fc
AS
442011-12-01 Andreas Schwab <schwab@linux-m68k.org>
45
46 * keyboard.c (interrupt_signal): Don't call kill-emacs when
47 waiting for input. (Bug#10169)
48
73d6c093
EZ
492011-11-30 Eli Zaretskii <eliz@gnu.org>
50
51 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
52 verifies glyph row's hash code--we have just reallocated the
53 glyphs, so their contents can be complete garbage. (Bug#10164)
54
febe6bea
JB
552011-11-30 Juanma Barranquero <lekktu@gmail.com>
56
57 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
58
801a4313
EZ
592011-11-30 Eli Zaretskii <eliz@gnu.org>
60
61 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
62 attributes are tested _before_ calling verify_row_hash, to protect
63 against GCC re-ordering of the tests. (Bug#10164)
64
2b56b87e
JD
652011-11-29 Jan Djärv <jan.h.d@swipnet.se>
66
67 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
68
69 * xterm.c (handle_one_xevent): Only set async_visible and friends
70 if net_wm_state_hidden_seen is non-zero (Bug#10002)
71 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
72 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
73
dbf31225
PE
742011-11-28 Paul Eggert <eggert@cs.ucla.edu>
75
76 Remove GCPRO-related macros that exist only to avoid shadowing locals.
77 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
78 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
79 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
80 All uses changed to use GCPRO1 etc.
81 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
82 Revert to old implementation (i.e., before 2011-03-11).
83
1305621b
YM
842011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
85
86 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
87 of scroll runs so as to avoid assigning disabled bogus rows and
88 unnecessary graphics copy operations.
89
8c9afb46
EZ
902011-11-27 Eli Zaretskii <eliz@gnu.org>
91
92 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
93 (snprintf) [_MSC_VER]: Redirect to _snprintf.
94 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
95 (malloc, free, realloc, calloc): Redirect to e_* only when
96 compiling Emacs.
97
98 * lisp.h (GCTYPEBITS): Move before first use.
99 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
100 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
101 this macro definition.
102
103 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
104 _MSC_VER.
105
54e9e3bf
JD
1062011-11-27 Jan Djärv <jan.h.d@swipnet.se>
107
108 * gtkutil.c (xg_create_frame_widgets): Call
109 gtk_window_set_has_resize_grip (FALSE) if that function is
110 present with Gtk+ 2.0.
111
83aca1cb
PE
1122011-11-26 Paul Eggert <eggert@cs.ucla.edu>
113
114 * fileio.c (Finsert_file_contents): Undo previous change; see
115 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
116
5b76caa4
PE
1172011-11-26 Paul Eggert <eggert@cs.ucla.edu>
118
119 Rename locals to avoid shadowing.
120 * fileio.c (Finsert_file_contents):
121 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
122 * process.c (wait_reading_process_output):
123 Rename inner 'proc' to 'p' to avoid shadowing.
124 Indent for consistency with usual Emacs style.
125
8c535114
EZ
1262011-11-25 Eli Zaretskii <eliz@gnu.org>
127
128 * xdisp.c (redisplay_window): If cursor row is not fully visible
129 after recentering, and scroll-conservatively is set to a large
130 number, scroll window by a few more lines to make the cursor fully
131 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
132 (start_display): Don't move to the next line if the display should
133 start at a newline that is part of a display vector or an overlay
134 string. (Bug#10119)
8c535114 135
fa4fdb5c
JL
1362011-11-24 Juri Linkov <juri@jurta.org>
137
138 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
139 after the `MagickPingImage' call. (Bug#10112)
140
90ec88df
CY
1412011-11-23 Chong Yidong <cyd@gnu.org>
142
143 * window.c (Fcoordinates_in_window_p): Accept only live windows.
144
56e2e794
MR
1452011-11-23 Martin Rudalics <rudalics@gmx.at>
146
147 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
148 making another buffer current. (Bug#10114)
149
b6e64c41
GM
1502011-11-23 Glenn Morris <rgm@gnu.org>
151
152 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
153
6b21de18
CY
1542011-11-23 Chong Yidong <cyd@gnu.org>
155
156 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
157 using it (Bug#5984).
158
b12cd789
EZ
1592011-11-22 Eli Zaretskii <eliz@gnu.org>
160
161 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
162 and header-lines, as they don't have one computed for them.
163 (Bug#10098)
164
165 * .gdbinit (prow): Make displayed values more self-explaining.
166 Add row's hash code.
167
261b6fd4
LMI
1682011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
169
170 * process.c (wait_reading_process_output): Fix asynchrounous
171 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 172 (wait_reading_process_output): Add comment and URL.
261b6fd4 173
e7cfd277
JD
1742011-11-21 Jan Djärv <jan.h.d@swipnet.se>
175
176 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
177
a9b9b7f5
CY
1782011-11-21 Chong Yidong <cyd@gnu.org>
179
180 * window.c (Fnext_window, Fprevious_window): Doc fix.
181
b0d15b4f
SM
1822011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
183
184 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
185
fe7a3057
JB
1862011-11-20 Juanma Barranquero <lekktu@gmail.com>
187
188 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
189
d2999b1a
MR
1902011-11-20 Martin Rudalics <rudalics@gmx.at>
191
192 * window.c (Fset_window_combination_limit): Rename argument
193 STATUS to LIMIT.
194 (Vwindow_combination_limit): Remove "status" from doc-string.
195
d5ff9cd0
AS
1962011-11-20 Andreas Schwab <schwab@linux-m68k.org>
197
198 * m/ibms390.h: Remove.
199 * m/ibms390x.h: Don't include "ibms390.h".
200
a5bb9bd3
SM
2012011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
202
203 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
204 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
205
cd1181db
JB
2062011-11-20 Juanma Barranquero <lekktu@gmail.com>
207
208 * casetab.c (Fset_case_table):
209 * charset.c (Fcharset_after): Fix typos.
210
615a3b8d 2112011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 212
17e845af
PE
213 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
214 Otherwise, valgrind does not work on some platforms.
215 Problem reported by Andreas Schwab in
6a0bf43d
PE
216 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
217 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
218 is set, removing the need for VIRT_ADDRESS_VARIES.
219 (PURE_P): Use a more-efficient implementation that needs just one
220 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
221 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
222 to 4 (xorl, subq, cmpq, setbe).
223 * alloc.c (pure): Always extern now, since that's the
224 VIRT_ADDR_VARIES behavior.
225 (PURE_POINTER_P): Use a single comparison, not two, for
226 consistency with the new puresize.h.
227 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
228 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
229 Remove VIRT_ADDR_VARIES no longer needed.
230
f8fe6f96
EZ
2312011-11-19 Eli Zaretskii <eliz@gnu.org>
232
233 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
234 (erase_phys_cursor, update_window_cursor, show_mouse_face)
235 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
236 behave as if the cursor position were at the window margin.
237
238 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
239 and the cursor position is out of bounds, behave as if the cursor
240 position were at the window margin. (Bug#10075)
241
df05a53c
CY
2422011-11-18 Chong Yidong <cyd@gnu.org>
243
244 * window.c (Fwindow_combination_limit): Make first argument
245 non-optional, since it is meaningless for live windows like the
246 selected window.
247
2071918e
DA
2482011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
249
250 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
251
b50a28de
SM
2522011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
253
254 * intervals.c: Fix grafting over the whole buffer (bug#10071).
255 (graft_intervals_into_buffer): Simplify.
256
015137db
EZ
2572011-11-18 Eli Zaretskii <eliz@gnu.org>
258
259 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
260 hash values of the two rows.
261 (copy_row_except_pointers): Preserve the used[] arrays and the
262 hash values of the two rows. (Bug#10035)
68c95424 263 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
264
265 * xdisp.c (row_hash): New function, body extracted from
266 compute_line_metrics.
267 (compute_line_metrics): Call row_hash, instead of computing the
268 hash code inline.
269
270 * dispnew.c (verify_row_hash): Call row_hash for computing the
271 hash code of a row, instead of duplicating code from xdisp.c.
272
273 * dispextern.h (row_hash): Add prototype.
274
a2addb04
TH
2752011-11-18 Tassilo Horn <tassilo@member.fsf.org>
276
277 * frame.c (delete_frame): Don't delete the terminal when the last
278 X frame is closed if emacs is built with GTK toolkit.
279
df85d315
JB
2802011-11-17 Juanma Barranquero <lekktu@gmail.com>
281
282 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
283
a0c2d0ae
MR
2842011-11-17 Martin Rudalics <rudalics@gmx.at>
285
286 * window.c (Vwindow_splits): Rename to
287 Vwindow_combination_resize. Suggested by Juri Linkov.
288 (Fsplit_window_internal): Use Vwindow_combination_resize instead
289 of Vwindow_splits.
290
58179cce
JB
2912011-11-16 Juanma Barranquero <lekktu@gmail.com>
292
7877f373
JB
293 * nsfns.m (Fns_font_name):
294 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 295
b6f67890
MR
2962011-11-16 Martin Rudalics <rudalics@gmx.at>
297
298 * window.h (window): Rename slot "nest" to "combination_limit".
299 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
300 (Fset_window_nest): Rename to Fset_window_combination_limit.
301 (Vwindow_nest): Rename to Vwindow_combination_limit.
302 (recombine_windows, make_parent_window, make_window)
303 (Fsplit_window_internal, saved_window)
304 (Fset_window_configuration, save_window_save): Rename all
305 occurrences of window_nest to window_combination_limit.
306
c7015153
JB
3072011-11-15 Juanma Barranquero <lekktu@gmail.com>
308
309 * image.c (imagemagick_load_image): Fix typo.
310
322ad6ec
EZ
3112011-11-14 Eli Zaretskii <eliz@gnu.org>
312
313 * xdisp.c (display_line): Move the call to
314 highlight_trailing_whitespace before the call to
315 compute_line_metrics, since the latter needs to see the final
316 faces of all the glyphs to compute ROW's hash value. Fixes
317 assertion violations in row_equal_p. (Bug#10035)
318
f067b8ec
JB
3192011-11-14 Juanma Barranquero <lekktu@gmail.com>
320
321 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
322 just return (bug#10044).
323
1e5b2111
EZ
3242011-11-12 Eli Zaretskii <eliz@gnu.org>
325
7ef3cbd5
EZ
326 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
327 with user-defined heap size. Bump the default size of the temacs
328 heap to 27MB, to avoid memory warning when running temacs.
329 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
330
1e5b2111
EZ
331 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
332 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
333 (verify_row_hash) [XASSERTS]: New function.
334 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
335 that the hash value of glyph rows is correct.
1e5b2111 336
89d61221
MR
3372011-11-12 Martin Rudalics <rudalics@gmx.at>
338
339 * window.h (window): Remove splits slot.
340 * window.c (Fwindow_splits, Fset_window_splits): Remove.
341 (Fdelete_other_windows_internal, make_parent_window)
342 (make_window, Fsplit_window_internal, Fdelete_window_internal)
343 (Fset_window_configuration, save_window_save): Don't deal with
344 split status of windows.
345 (saved_window): Remove splits slot.
346 (Vwindow_splits): Rewrite doc-string.
347
97f18cc8
JD
3482011-11-11 Jan Djärv <jan.h.d@swipnet.se>
349
350 * xfns.c (unwind_create_frame):
351 * nsfns.m (unwind_create_frame):
352 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
353 Vframe_list (Bug#9999).
354
22a648b4
DA
3552011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
356
0b381c7e 357 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 358
659afede
KH
3592011-11-11 Kenichi Handa <handa@m17n.org>
360
361 * callproc.c (Fcall_process): Set the member dst_multibyte of
362 process_coding.
363
9ac0394b
KH
3642011-11-11 Johan Bockgård <bojohan@gnu.org>
365
366 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
367 avoid a crash (bug#9496).
368
2fbdc249
CY
3692011-11-09 Chong Yidong <cyd@gnu.org>
370
371 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
372 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
373
ac6b1f81
PE
3742011-11-08 Paul Eggert <eggert@cs.ucla.edu>
375
376 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
377
09db192c
PE
3782011-11-08 Paul Eggert <eggert@cs.ucla.edu>
379
380 Avoid some portability problems by eschewing 'extern inline' functions.
381 The trivial performance wins aren't worth the portability hassles; see
382 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
383 et seq.
384 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
385 (window_box_width, window_box_left, window_box_left_offset)
386 (window_box_right, window_box_right_offset): Undo previous change,
387 by removing the "extern"s.
388 * intervals.c (adjust_intervals_for_insertion)
389 (adjust_intervals_for_deletion): Undo previous change,
390 making these static again.
391 (offset_intervals, temp_set_point_both, temp_set_point)
392 (copy_intervals_to_string): No longer inline.
393 * xdisp.c (window_text_bottom_y, window_box_width)
394 (window_box_height, window_box_left_offset)
395 (window_box_right_offset, window_box_left, window_box_right)
396 (window_box): No longer inline.
397
105216ed
CY
3982011-11-08 Chong Yidong <cyd@gnu.org>
399
400 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
401 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
402 an error if not a live window.
403 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
404 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
405
ae9e237f
JB
4062011-11-07 Juanma Barranquero <lekktu@gmail.com>
407
408 * lisp.h (syms_of_abbrev): Remove declaration.
409 Reported by CHENG Gao <chenggao@royau.me>.
410
c7aa8333
EZ
4112011-11-07 Eli Zaretskii <eliz@gnu.org>
412
413 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
414 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
415 of temacs in GUI mode.
416
be7f5545
MR
4172011-11-07 Martin Rudalics <rudalics@gmx.at>
418
419 * window.h: Declare delete_all_child_windows instead of
420 delete_all_subwindows.
421 * window.c (Fwindow_nest, Fset_window_nest)
422 (Fset_window_new_total, Fset_window_new_normal)
423 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
424 (delete_all_subwindows): Rename to delete_all_child_windows.
425 (Fdelete_other_windows_internal, Fset_window_configuration):
426 Call delete_all_child_windows instead of delete_all_subwindows.
427 * frame.c (delete_frame): Call delete_all_child_windows instead
428 of delete_all_subwindows.
429
ca78dc43
PE
4302011-11-07 Paul Eggert <eggert@cs.ucla.edu>
431
432 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
433 This is also needed for porting to any host where GC_MARK_STACK is
434 not GC_MAKE_GCPROS_NOOPS.
435 (which_symbols): Use it.
436
a0241d01
KH
4372011-11-07 Kenichi Handa <handa@m17n.org>
438
439 * coding.c (coding_set_destination): Check coding->src_pos only
440 when coding->src_object is a buffer (bug#9910).
441
442 * process.c (send_process): Set the member src_multibyte of coding
443 to 0 (bug#9911) when sending a unibyte text.
444
445 * callproc.c (Fcall_process): Set the member src_multibyte of
446 process_coding to 0 (bug#9912).
447
a64bfdfa 4482011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
449
450 * xmenu.c (cleanup_widget_value_tree): New function.
451 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
452 calling free_menubar_widget_value_tree directly (Bug#9830).
453
cb41b32a
PE
4542011-11-06 Paul Eggert <eggert@cs.ucla.edu>
455
456 Fix some portability problems with 'inline'.
457 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
458 (window_box_width, window_box_left, window_box_left_offset)
459 (window_box_right, window_box_right_offset): Declare extern.
460 Otherwise, these inline functions do not conform to C99 and
461 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
462 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
463 * intervals.c (adjust_intervals_for_insertion)
464 (adjust_intervals_for_deletion): Now extern, because otherwise the
465 extern inline functions 'offset_intervals' couldn't refer to it.
466 (static_offset_intervals): Remove.
467 (offset_intervals): Rewrite using the old contents of
468 static_offset_intervals. The old version didn't conform to C99
469 because an extern inline function contained a reference to an
470 identifier with static linkage.
471
b7041366
AS
4722011-11-06 Andreas Schwab <schwab@linux-m68k.org>
473
474 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
475 GC.
476
88a37c4d
EZ
4772011-11-06 Eli Zaretskii <eliz@gnu.org>
478
479 * xdisp.c (init_iterator, reseat_to_string): Don't set the
480 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
481 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
482 return Qleft_to_right.
483
49745b39
CY
4842011-11-06 Chong Yidong <cyd@gnu.org>
485
486 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
487 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
488 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
489 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
490 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
491 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
492 (Fwindow_vscroll): Doc fix.
493 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
494 argument, since it makes no sense to pass a live window and for
495 consistency with window-child.
496
1f05cd82
CS
4972011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
498
499 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
500 support MSVC.
501
22610910
JR
5022011-11-05 Jason Rumney <jasonr@gnu.org>
503
504 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
505 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
506 fonts (Bug#6029).
507 (add_font_entity_to_list): Fix logic errors in mixed boolean and
508 bitwise arithmetic preventing use of unicode-sip and non-truetype
509 opentype fonts.
510
a06776b2
EZ
5112011-11-05 Eli Zaretskii <eliz@gnu.org>
512
3ad924ba
EZ
513 * s/ms-w32.h (fstat, stat, utime): Move redirections to
514 "emacs"-only part.
515
a06776b2
EZ
516 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
517 initialization code to keep similarity to xfns.c after changes
518 from 2011-11-05.
519
c9e7db78
JD
5202011-11-05 Jan Djärv <jan.h.d@swipnet.se>
521
a97f8f3f
JD
522 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
523 (unwind_create_frame): New function (Bug#9943).
524 (Fx_create_frame): Restructure code to be more similar to the one in
525 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
526 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
527 Move terminal->reference_count++ just before making the frame official
528 (Bug#9943).
529
530 * nsterm.m (x_free_frame_resources): New function.
531 (x_destroy_window): Move code to x_free_frame_resources.
532
c9e7db78
JD
533 * xfns.c (unwind_create_frame): Fix comment.
534 (Fx_create_frame, x_create_tip_frame): Move
535 terminal->reference_count++ just before making the frame
536 official. Move initialization of image_cache_refcount and
537 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
538
a6fc3b5c
EZ
5392011-11-05 Eli Zaretskii <eliz@gnu.org>
540
541 Support MSVC build with newer versions of Visual Studio.
542 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
543 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
544 nt/gmake.defs.
545
546 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
547 which are not supported by MSVC.
548 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
549 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
550 bitfields.
551 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
552 types in bitfields.
553 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
554
555 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
556
58179cce 5572011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
558
559 Support MSVC build with newer versions of Visual Studio.
560 * w32.c: Don't include w32api.h for MSVC.
561 (init_environment) [_MSC_VER]: Call sys_access, not _access.
562
563 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
564 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
565 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
566 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
567 e_* cousins.
568 (alloca) [_MSC_VER]: Define to _alloca.
569
570 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
571
572 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
573
a58c13ed
EZ
5742011-11-04 Eli Zaretskii <eliz@gnu.org>
575
576 * xdisp.c (note_mouse_highlight): If either of
577 previous/next-single-property-change returns nil, treat that as
578 the beginning or the end of the buffer. (Bug#9955)
579
fe0b6370
JD
5802011-11-04 Jan Djärv <jan.h.d@swipnet.se>
581
a58c13ed 582 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
583 label is not null (Bug#9951).
584 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
585 may be NULL.
586
89bd5ee1
EZ
5872011-11-04 Eli Zaretskii <eliz@gnu.org>
588
589 * window.c (Fwindow_body_size): Mention in the doc string that the
590 return value is in frame's canonical units. (Bug#9949)
591
84c3edb9
EZ
5922011-11-03 Eli Zaretskii <eliz@gnu.org>
593
4e2fb5c7
EZ
594 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
595
84c3edb9 596 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 597 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 598 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 599
bc17a887
EZ
6002011-11-01 Eli Zaretskii <eliz@gnu.org>
601
602 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
603 Don't stop backward scan on the continuation glyph, even though
604 its CHARPOS is positive.
26b46e51
EZ
605 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
606 cover_string to disp_string.
bc17a887 607
4ee88440
MR
6082011-11-01 Martin Rudalics <rudalics@gmx.at>
609
610 * window.c (temp_output_buffer_show): Don't use
611 Vtemp_buffer_show_specifiers.
612 (Vtemp_buffer_show_specifiers): Remove unused variable.
613
c2ff3c02
EZ
6142011-10-30 Eli Zaretskii <eliz@gnu.org>
615
616 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
617 past the beginning of the current glyph matrix.
618
58179cce 6192011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
620
621 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
622 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
623 HAVE_GTK3 (Bug#9869).
b77a6a7f 624
3b574623
JD
625 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
626 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
627
b77a6a7f
JD
628 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
629
630 * xterm.c: Declare x_handle_net_wm_state to return int.
631 (handle_one_xevent): Check if we are iconified but don't have
632 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
633 (get_current_wm_state): Return non-zero if not hidden,
634 check for _NET_WM_STATE_HIDDEN (Bug#9893).
635 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
636 (x_handle_net_wm_state): Return what get_current_wm_state returns.
637 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
638
196e41e4
PE
6392011-10-29 Paul Eggert <eggert@cs.ucla.edu>
640
641 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
642 so that this new function doesn't get optimized away by a
643 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
644
021f2e1a
AS
6452011-10-29 Andreas Schwab <schwab@linux-m68k.org>
646
647 * frame.h (MOUSE_HL_INFO): Remove excess parens.
648
8b058d44
EZ
6492011-10-29 Eli Zaretskii <eliz@gnu.org>
650
651 Fix the `xbytecode' command.
652 * .gdbinit (xprintbytestr): New command.
b50a28de 653 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
654 (xbytecode): Print the byte-code string as well.
655
4452fb80
EZ
6562011-10-29 Kim Storm <storm@cua.dk>
657
8b058d44
EZ
658 * alloc.c (which_symbols): New function.
659
21b72067
AS
6602011-10-29 Andreas Schwab <schwab@linux-m68k.org>
661
662 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
663 line. (Bug#9903)
664
83ed7b5c
GM
6652011-10-29 Glenn Morris <rgm@gnu.org>
666
667 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
668 Not clear what it was for, and it causes various bugs. (Bug#9839)
669
5a7a728b
EZ
6702011-10-28 Eli Zaretskii <eliz@gnu.org>
671
672 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
673 possible random value that matches one of those tested as
674 condition to clear the mouse face.
675
d3d0842f
CY
6762011-10-28 Chong Yidong <cyd@gnu.org>
677
678 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
679
31b39d13
DN
6802011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
681
682 * window.c (make_window): Initialize phys_cursor_on_p.
683
9aba6043
SM
6842011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
685
686 * lisp.h (struct Lisp_Symbol): Update comments.
687
c20992f4
JB
6882011-10-28 Juanma Barranquero <lekktu@gmail.com>
689
690 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
691
db4f02f2
EZ
6922011-10-28 Eli Zaretskii <eliz@gnu.org>
693
694 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
695 <oslsachem@gmail.com> for helping to debug this.
696
697 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
698 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
699 (g_b_init_get_glyph_outline_w): New static variables.
700 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
701 (GetGlyphOutlineW_Proc): New typedefs.
702 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
703 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
704 New functions.
705 (w32font_open_internal, compute_metrics):
706 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
707 instead of calling the "wide" APIs directly.
708
709 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
710
711 * w32.h (syms_of_w32font): Add prototype.
712
87e68db4
JB
7132011-10-27 Juanma Barranquero <lekktu@gmail.com>
714
715 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
716 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
717 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
718 (Fmove_to_window_line): Doc fix.
719
435c1d67
CY
7202011-10-27 Chong Yidong <cyd@gnu.org>
721
722 * process.c (make_process): Set gnutls_state to NULL.
723
724 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
725 non-NULL, regardless of GNUTLS_INITSTAGE.
726 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
727 an error. Set process slots as soon as we allocate them.
728
729 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
730
9c6c6f49
CY
7312011-10-27 Chong Yidong <cyd@gnu.org>
732
9aba6043
SM
733 * gnutls.c (emacs_gnutls_deinit): New function.
734 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
735 (Fgnutls_deinit, Fgnutls_boot): Use it.
736
737 * process.c (make_process): Initialize GnuTLS credentials to NULL.
738 (deactivate_process): Call emacs_gnutls_deinit.
739
657d08d3
JB
7402011-10-27 Juanma Barranquero <lekktu@gmail.com>
741
742 * image.c (x_create_x_image_and_pixmap):
743 * w32.c (sys_rename, w32_delayed_load):
744 * w32font.c (fill_in_logfont):
745 * w32reg.c (x_get_string_resource): Silence compiler warnings.
746
5430d399
JB
7472011-10-26 Juanma Barranquero <lekktu@gmail.com>
748
749 * w32fns.c (w32_default_color_map): New function,
750 extracted from Fw32_default_color_map.
a7ef684b 751 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 752
fe0055fa
PE
7532011-10-25 Paul Eggert <eggert@cs.ucla.edu>
754
755 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
756
e6346438
SM
7572011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
758
759 * keyboard.c (test_undefined): New function (bug#9751).
760 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
761
e112cc37
ET
7622011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
763
764 * sysdep.c (init_sys_modes): Fix the check for the controlling
765 terminal (Bug#6649).
766
7b5d6677
EZ
7672011-10-20 Eli Zaretskii <eliz@gnu.org>
768
769 * dispextern.h (struct bidi_it): New member next_en_type.
770
771 * bidi.c (bidi_line_init): Initialize the next_en_type member.
772 (bidi_resolve_explicit_1): When next_en_pos is valid for the
773 current character, check also for next_en_type being WEAK_EN.
774 (bidi_resolve_weak): Don't enter the expensive loop if the current
775 position is before next_en_pos. Record the bidi type of the first
776 non-ET, non-BN character we find, in addition to its position.
777 (bidi_level_of_next_char): Invalidate next_en_type when
778 next_en_pos is over-stepped.
779
7da0b018
PE
7802011-10-20 Paul Eggert <eggert@cs.ucla.edu>
781
782 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
783 * editfns.c: Rewrite current-time-zone so that it invokes
784 the equivalent of (format-time-string "%Z") to get the time zone name.
785 This fixes a bug when the time zone name contains characters that
786 need converting from the system time locale to Emacs internal format.
787 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
788 that patch fixed format-time-string to do the conversion, but
789 I forgot to fix current-time-zone.
790 (format_time_string): New function, containing most of
791 what Fformat_time_string used to contain.
792 (Fformat_time_string): Rewrite in terms of format_time_string.
793 This doesn't change this function's behavior.
794 (current-time-zone): Rewrite to use format_time_string.
795 This fixes the bug reported by Michael Schierl in
796 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
797 Jason Rumney's 2007-06-07 change worked around this bug, but
798 didn't fix it.
799 * systime.h (tzname, timezone): Remove no-longer-used declarations.
800
8547b010
EZ
8012011-10-19 Eli Zaretskii <eliz@gnu.org>
802
803 * xdisp.c (start_display): If the character at POS is displayed
804 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
805 (try_window_reusing_current_matrix): If a line ends in a display
806 vector or the next line starts in a display vector, continue
807 redrawing the window even though the character position of
808 start_row was reached.
8547b010
EZ
809 (Bug#9771, part 2)
810
4e948d15
CY
8112011-10-18 Chong Yidong <cyd@gnu.org>
812
813 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
814 with nobreak-char-display too.
815
4787455f
EZ
8162011-10-18 Eli Zaretskii <eliz@gnu.org>
817
818 Fix part 3 of bug#9771.
819 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
820 (bidi_resolve_neutral): Don't enter the expensive loop looking for
821 non-neutral characters if the current character is a paragraph
822 separator (a.k.a. Newline). This avoids running the same
823 expensive loop twice, once when we consume the preceding newline
824 and the other time when the line actually needs to be displayed.
825 Avoid the loop when we see neutrals on the base embedding level
826 following a character whose directionality is the same as the
827 paragraph's. This avoids running the expensive loop when a line
828 ends in a long sequence of neutrals, like control characters.
829 Add assertion against STRONG_AL type. Slightly rearrange code
830 that determines the type of a neutral given the first non-neutral
831 that follows it.
832 (bidi_level_of_next_char): Set next_en_pos to zero when
833 invalidating its info.
834
2c91f553
EZ
8352011-10-17 Eli Zaretskii <eliz@gnu.org>
836
837 * xdisp.c (push_display_prop): Determine whether to record string
838 or buffer position by IT->string, not by IT->method. Allow
839 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
840 (move_it_vertically_backward): Don't look for character position
841 immediately after the newline when in a continuation line.
842 (Bug#9771, part 1)
2c91f553 843
c7b08b0d
MR
8442011-10-15 Martin Rudalics <rudalics@gmx.at>
845
846 * window.c (coordinates_in_window): Rewrite and delabelize
847 vertical border check. (Bug#5357) (Bug#9618)
848
6b02f655
SM
8492011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
850
851 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
852 errors in XSetWindowBorder (bug#9310).
853
81d40c92
DA
8542011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
855
856 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
857 avoid crash when xmalloc overrun checking is enabled.
858
d4172c3b
EZ
8592011-10-13 Eli Zaretskii <eliz@gnu.org>
860
861 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
862 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
863 cursor motion with <left> and <right> arrow keys.
864
865 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
866 some callers set that themselves.
867
b00eea75
EZ
8682011-10-12 Eli Zaretskii <eliz@gnu.org>
869
870 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
871 display string and the previous row comes from the same string and
872 is empty. (Bug#9739) (Bug#9738)
873
8fe012c4
SM
8742011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
875
876 * doc.c (get_doc_string): Encode file name (bug#9735).
877
0074aef2
EZ
8782011-10-12 Eli Zaretskii <eliz@gnu.org>
879
79beb178
EZ
880 * bidi.c (bidi_level_of_next_char):
881 * xdisp.c (get_visually_first_element): Remove old incorrect
882 comments regarding the Unicode Line Separator character.
883
0074aef2
EZ
884 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
885
6e4b3fbe
DA
8862011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
887
888 * alloc.c (Fgc_status): Do not access beyond zombies array
889 boundary if nzombies > MAX_ZOMBIES.
890 * alloc.c (dump_zombies): Add missing format specifier.
891
0324f3af
PE
8922011-10-12 Paul Eggert <eggert@cs.ucla.edu>
893
b5525cac
PE
894 * xdisp.c (set_cursor_from_row): Simplify conditionals,
895 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
896
0324f3af
PE
897 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
898 Some packages use them to denote characters with modifiers.
899
e9b5f888
AS
9002011-10-11 Andreas Schwab <schwab@linux-m68k.org>
901
902 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
903 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
904 matching a pp-number. Rename parameter var to var1.
905
127827c0
SM
9062011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
907
908 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
909
c8fd3bd0
GM
9102011-10-08 Glenn Morris <rgm@gnu.org>
911
912 * callint.c (Fcall_interactively): Give a more explicit error for the
913 'c' case with a non-character input. (Bug#8479)
914
352ec8ff
EZ
9152011-10-08 Eli Zaretskii <eliz@gnu.org>
916
03669ccb
EZ
917 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
918 lines.
7061c986
EZ
919 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
920 lines that are hscrolled on the left.
03669ccb 921
352ec8ff
EZ
922 * dispnew.c (buffer_posn_from_coords): Account for a possible
923 presence of header-line. (Bug#4426)
924
a66cfb1c
SM
9252011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
926
6b02f655
SM
927 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
928 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 929
7c5ee88e
PE
9302011-10-07 Paul Eggert <eggert@cs.ucla.edu>
931
932 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
933 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
934 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
935 this makes Emacs dump core during garbage collection on rare
936 occasions. sizeof is obviously inferior to offsetof here, so
937 stick with offsetof.
938 (GC_POINTER_ALIGNMENT): New macro.
939 (mark_memory): Omit 3rd (offset) arg; caller changed.
940 Don't assume EMACS_INT alignment is the same as pointer alignment.
941
df1bbe5b
SM
9422011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
943
944 * keyboard.c (read_key_sequence_remapped): New var.
945 (read_key_sequence): Compute remapping in the right buffer.
946 (command_loop_1): Use read_key_sequence's remapping directly.
947
51553db6
SM
9482011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
949
32c1fffd
SM
950 * dired.c (file_name_completion): Don't expand file name.
951 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
952 before checking file name handler.
953
51553db6
SM
954 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
955 they've been requested explicitly (bug#9591).
956
b6bd1599 9572011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
958
959 * keymap.c (Fsingle_key_description): Use make_specified_string
960 instead of build_string to build string from push_key_description.
961 (Bug#5193)
962
f701dc2a
PE
9632011-09-30 Paul Eggert <eggert@cs.ucla.edu>
964
4222c55d
PE
965 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
966 This fixes a Y2038 bug on 64-bit hosts.
967 * buffer.c (reset_buffer):
968 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
969 (Fclear_buffer_auto_save_failure):
970 Use 0, not -1, to represent an unset failure time, since time_t
971 might not be signed.
972
f701dc2a
PE
973 Remove dependency on glibc malloc internals.
974 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
975 Move back here from lisp.h, but with their new implementations.
976 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
977 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
978 * charset.c (charset_table_init): New static var.
979 (syms_of_charset): Use it instead of xmalloc. This removes a
980 dependency on glibc malloc internals. See Eli Zaretskii's comment in
981 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
982 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
983 Move back to alloc.c.
984 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
985 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
986
9ceebf39
JD
9872011-09-30 Jan Djärv <jan.h.d@swipnet.se>
988
989 * nsterm.m (windowDidResize): Call x_set_window_size only when
990 ns_in_resize is true. Otherwise set pixelwidth/height and
991 call change_frame_size (Bug#9628).
992
cb993c58
PE
9932011-09-30 Paul Eggert <eggert@cs.ucla.edu>
994
3930c88b
PE
995 Port --enable-checking=all to Fedora 14 x86-64.
996 * charset.c (syms_of_charset): Also account for glibc malloc's
997 internal overhead when calculating the initial malloc maximum.
998
cb993c58
PE
999 Port --enable-checking=all to Fedora 14 x86.
1000 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1001 Move to lisp.h.
1002 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1003 (overrun_check_realloc, overrun_check_free):
1004 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1005 That way, xmalloc returns a properly-aligned pointer even if
1006 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1007 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1008 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1009 into account when calculating the initial malloc maximum.
1010 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1011 Move here from alloc.c, so that charset.c can use it too.
1012 Properly align; the old code wasn't right for common 32-bit hosts
1013 when configured with --enable-checking=all.
1014 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1015 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1016
31bed486
EZ
10172011-09-29 Eli Zaretskii <eliz@gnu.org>
1018
04c70788 1019 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1020 use EDOM.
1021
fbcaa2f3
EZ
10222011-09-28 Eli Zaretskii <eliz@gnu.org>
1023
1024 * xdisp.c (compute_display_string_end): If there's no display
1025 string at CHARPOS, return -1.
1026
1027 * bidi.c (bidi_fetch_char): When compute_display_string_end
1028 returns a negative value, treat the character as a normal
1029 character not covered by a display string. (Bug#9624)
1030
a239d4e9
JB
10312011-09-28 Juanma Barranquero <lekktu@gmail.com>
1032
1033 * lread.c (Fread_from_string): Fix typo in docstring.
1034
88652fd5
EZ
10352011-09-27 Eli Zaretskii <eliz@gnu.org>
1036
1037 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1038 newline, reseat the iterator instead of bidi-iterating there one
1039 character at a time. (Bug#9610)
32c1fffd
SM
1040 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1041 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1042
ed497dd4
AS
10432011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1044
1045 * lread.c (readevalloop): Use correct code for NBSP.
1046 (read1): Likewise. (Bug#9608)
1047
b2bf61aa
MA
10482011-09-25 Michael Albinus <michael.albinus@gmx.de>
1049
1050 * dbusbind.c (Fdbus_register_signal): When service is not
1051 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1052
32bbb17c
GM
10532011-09-25 Glenn Morris <rgm@gnu.org>
1054
1055 * buffer.c (truncate-lines): Doc fix.
1056
94e0933e
CY
10572011-09-24 Chong Yidong <cyd@stupidchicken.com>
1058
1059 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1060 (Fset_window_next_buffers): Doc fix.
1061
cddde921
GM
10622011-09-24 Glenn Morris <rgm@gnu.org>
1063
1064 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1065
1260aef1
PE
10662011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1067
25b4bfa0
PE
1068 Fix minor problems found by static checking.
1069 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1070 * indent.c (Fvertical_motion): Fix == vs = typo.
1071
e3cbd34b
EZ
10722011-09-24 Eli Zaretskii <eliz@gnu.org>
1073
a66cfb1c
SM
1074 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1075 Default value is now t. Doc fix.
6bf7006f 1076
e3cbd34b 1077 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1078 logic when moving up, not only when moving down. Fix the
e3cbd34b 1079 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1080 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1081
1082 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1083 CHARPOS is covered by a display string which includes newlines.
1084 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1085 is covered by a display string with embedded newlines.
1086
a3de0cbd
MA
10872011-09-24 Michael Albinus <michael.albinus@gmx.de>
1088
1089 * dbusbind.c (Fdbus_register_signal): Add match rule to
1090 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1091 (Fdbus_register_method, Vdbus_registered_objects_table):
1092 Fix docstring.
a3de0cbd 1093
b260039d
JM
10942011-09-24 Jim Meyering <meyering@redhat.com>
1095
32c1fffd 1096 do not ignore write error for any output size
b260039d
JM
1097 The previous change was incomplete.
1098 While it makes emacs --batch detect the vast majority of stdout
1099 write failures, errors were still ignored whenever the output size is
1100 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1101 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1102 && echo FAIL: ignored write error
1103 FAIL: ignored write error
1104 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1105 && echo FAIL: ignored write error
1106 FAIL: ignored write error
1107 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1108
8eca8a7c
AS
11092011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1110
1111 * emacs.c (Fkill_emacs): In noninteractive mode exit
1112 non-successfully if a write error occurred on stdout. (Bug#9574)
1113
3341db62
EZ
11142011-09-21 Eli Zaretskii <eliz@gnu.org>
1115
1116 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1117 the xassert test.
1118
1119 * dispextern.h (struct it): Update the comment documenting what
1120 can it->OBJECT be.
1121
8c203dbf
EZ
11222011-09-20 Eli Zaretskii <eliz@gnu.org>
1123
1124 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1125 a display string, extend search for cursor position to end of row.
1126 (find_row_edges): If the row ends in a newline from a display
1127 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1128 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1129 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1130 non-empty line. Fixes confusing cursor motion with arrow keys at
1131 the beginning of a line that starts with whitespace.
8c203dbf 1132
a4824228
LMI
11332011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1134
1135 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1136 (bug#9493).
1137
33ed493b
CY
11382011-09-18 Chong Yidong <cyd@stupidchicken.com>
1139
1140 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1141 boolean (Bug#9154).
1142
56cd55c8
EZ
11432011-09-18 Eli Zaretskii <eliz@gnu.org>
1144
1145 * xdisp.c (display_line): Record maximum and minimum buffer
1146 positions even if no glyphs were produced (e.g., by a zero-width
1147 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1148 buffer positions that will be removed from the glyph row because
1149 they don't fit.
c02dcedf
EZ
1150 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1151 column is beyond frame width: don't subtract 1 "pixel" when
1152 computing width of the stretch.
3e62b7e0
EZ
1153 (reseat_at_next_visible_line_start): Undo the change made on
1154 2011-09-17 that saved paragraph information and restored it after
1155 the call to `reseat'. (Bug#9545)
56cd55c8 1156
5ed99d36 11572011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1158
1159 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1160 and turn window cursor on if cleared (Bug#9415).
1161
5ed99d36 11622011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1163
1164 * search.c (boyer_moore): Take unibyte characters from pattern
1165 literally. (Bug#9458)
1166
9bade7b2
EZ
11672011-09-18 Eli Zaretskii <eliz@gnu.org>
1168
1169 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1170
e5e9d610
PE
11712011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1172
87e4427a
PE
1173 Fix minor problem found by static checking.
1174 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1175 initialized, to pacify gcc -Wuninitialized.
1176
e5e9d610
PE
1177 * fileio.c: Report proper errno when syscall falls.
1178 (Finsert_file_contents): Save and restore errno,
1179 so that report_file_error outputs the correct diagnostic.
1180 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1181
a1674f0b
EZ
11822011-09-18 Eli Zaretskii <eliz@gnu.org>
1183
1184 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1185
fbfb6dd4
EZ
11862011-09-17 Eli Zaretskii <eliz@gnu.org>
1187
1188 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1189 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1190
bb187662
EZ
11912011-09-17 Eli Zaretskii <eliz@gnu.org>
1192
1137e8b8 1193 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1194 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1195
1196 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1197 (bidi_find_paragraph_start): Search back for paragraph beginning
1198 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1199 (bidi_move_to_visually_next): Only trigger paragraph-related
1200 computations when the last character is a newline or at EOB, not
1201 just any NEUTRAL_B. (Bug#9470)
1202
bb187662
EZ
1203 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1204 truncated lines if point is covered by a display string. (Bug#9524)
1205
2e621251
PE
12062011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1207
1208 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1209 (cons_to_x_long): New function.
1210 (lisp_data_to_selection_data): Use it. Correct the test for
1211 short-versus-long data; it was negated. Break out of vector
1212 loop, for efficiency, when a long datum is discovered.
1213
91a15bc6
SM
12142011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1215
1216 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1217
b41c3a35
EZ
12182011-09-16 Eli Zaretskii <eliz@gnu.org>
1219
1220 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1221 GCC PR/17406) by declaring this function with external scope.
1222
7812ba2d
PE
12232011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1224
1225 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1226 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1227
cf7edc2a
AS
12282011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1229
1230 * editfns.c (Fformat): Correctly handle text properties on "%%".
1231
bd01620e
EZ
12322011-09-15 Eli Zaretskii <eliz@gnu.org>
1233
1234 * xterm.c (x_draw_composite_glyph_string_foreground):
1235 * w32term.c (x_draw_composite_glyph_string_foreground):
1236 * term.c (encode_terminal_code):
1237 * composite.c (composition_update_it, get_composition_id):
1238 * xdisp.c (get_next_display_element)
1239 (fill_composite_glyph_string): Add comments about special meaning
1240 of TAB characters in a composition.
1241
a02719a3
PE
12422011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1243
1244 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1245 This occurs when processing a multibyte format.
1246 Problem reported by Wolfgang Jenker.
a02719a3 1247
72589a3c
JB
12482011-09-15 Johan Bockgård <bojohan@gnu.org>
1249
1250 * xdisp.c (try_cursor_movement): Only check for exact match if
1251 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1252
1c14176c
PE
12532011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1254
1255 Remove unused external symbols.
1256 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1257 * xdisp.c (calc_pixel_width_or_height): Now static.
1258 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1259 * indent.c (check_display_width):
1260 * w32term.c: Fix comment to match code.
1261 * xterm.c, xterm.h (x_catching_errors): Remove.
1262
d2eea5b5
PE
12632011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1264
1265 * xselect.c: Use signed conversions more consistently (Bug#9498).
1266 (selection_data_to_lisp_data): Assume incoming selection data are
1267 signed integers, not unsigned. This is to be consistent with
1268 outgoing selection data, which was modified to use signed integers
1269 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1270 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1271 expects long, not unsigned long.
1272
46888499
EZ
12732011-09-14 Eli Zaretskii <eliz@gnu.org>
1274
1275 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1276 computation of loop end. Reported by Johan Bockgård
1277 <bojohan@gnu.org>.
1278
ef8ef9fb
CY
12792011-09-13 Chong Yidong <cyd@stupidchicken.com>
1280
1281 * frame.c (Fother_visible_frames_p): Function deleted.
1282
fa819fed
EZ
12832011-09-12 Eli Zaretskii <eliz@gnu.org>
1284
1285 * indent.c (compute_motion): Process display vector front to back
1286 rather than the other way around. (Bug#2496)
1287
2ba8e008
SM
12882011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1289
1290 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1291
20f53c69
CY
12922011-09-11 Chong Yidong <cyd@stupidchicken.com>
1293
1294 * minibuf.c (Fread_from_minibuffer): Doc fix.
1295
d562d7a4
EZ
12962011-09-11 Eli Zaretskii <eliz@gnu.org>
1297
1298 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1299 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1300
1c4d7f3d
LMI
13012011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1302
1303 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1304 value for non-existent files.
1305
b885bf36
EZ
13062011-09-11 Eli Zaretskii <eliz@gnu.org>
1307
1308 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1309 set its "size" to -1. This will set the modtime_size field of
1310 the corresponding buffer to -1, which is what
1311 verify-visited-file-modtime expects for files that do not exist.
1312 (Bug#9139)
1313
6612f0bf
PE
13142011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1315
1316 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1317 here ...
1318 * lisp.h: ... from here. push_key_description is no longer
1319 defined in keyboard.c, so its declaration should not be in
1320 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1321 logically belongs with push_key_description.
1322
dfb3f755
PE
13232011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1324
1325 * buffer.h: Include <sys/types.h> instead of <time.h>.
1326 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1327 Problem reported by Herbert J. Skuhra.
1328
3134906c
LMI
13292011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1330
1331 * xml.c (parse_region): Make the parsing work for
1332 non-comment-starting XML files again (bug#9144).
1333
8d903f4e
AS
13342011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1335
1336 * image.c (gif_load): Fix calculation of bottom and right corner.
1337 (Bug#9468)
1338
80ad64f4
EZ
13392011-09-10 Eli Zaretskii <eliz@gnu.org>
1340
1341 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1342 redisplay in small windows.
1343
208a048d
EZ
13442011-09-09 Eli Zaretskii <eliz@gnu.org>
1345
1346 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1347
9b1c252e
MR
13482011-09-08 Martin Rudalics <rudalics@gmx.at>
1349
1350 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1351 Operate on live windows only.
1352
2949f33b
JB
13532011-09-08 Juanma Barranquero <lekktu@gmail.com>
1354
1355 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1356
e08dcafd
EZ
13572011-09-07 Eli Zaretskii <eliz@gnu.org>
1358
1359 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1360 only under bidi iteration.
1361
115b96bd
JD
13622011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1363
1364 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1365
c8199d0f
PE
13662011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1367
1368 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1369 Without this fix, the command to link temacs failed due to an
1370 undefined symbol __builtin_isnan. This is because
1371 /usr/include/iso/math_c99.h #defines isnan(x) to
1372 __builtin_isnan(x), but the bundled gcc, which identifies itself
1373 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1374 a __builtin_isnan.
1375 * floatfns.c (isnan): #undef, and then #define to a clone of
1376 what's in data.c.
1377 (Fisnan): Always define, since it's always available now.
1378 (syms_of_floatfns): Always define isnan at the Lisp level.
1379
e39b275c 13802011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1381
1382 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1383
b2db44d9 13842011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1385
f4af5137 1386 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1387 The previous code assumed that file offsets (off_t values) fit in
1388 EMACS_INT variables, which is not true on typical 32-bit hosts.
1389 The code messed up by falsely reporting buffer overflow in cases
1390 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1391 when "big" contains more than 2**29 bytes, even though this
1392 inserts just one byte and does not overflow the buffer.
1393 (Finsert_file_contents): Store file offsets as off_t
1394 values, not as EMACS_INT values. Check for overflow when
1395 converting between EMACS_INT and off_t. When checking for
1396 buffer overflow or for overlap, take the offsets into account.
1397 Don't use EMACS_INT for small values where int suffices.
1398 When checking for overlap, fix a typo: ZV was used where
1399 ZV_BYTE was intended.
1400 (Fwrite_region): Don't assume off_t fits into 'long'.
1401 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1402
ecfc0a49
MA
14032011-09-05 Michael Albinus <michael.albinus@gmx.de>
1404
1405 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1406
6511acf2 14072011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1408
0999621a 1409 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1410
1411 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1412 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1413 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1414 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1415 (modify_event_symbol): Do not assume that the length of
1416 name_alist_or_stem is safe to alloca and fits in int.
1417 (Fexecute_extended_command): Likewise for function name and binding.
1418 (Frecursion_depth): Wrap around reliably on integer overflow.
1419 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1420 since some callers pass EMACS_INT values.
1421 (Fsingle_key_description): Don't crash if symbol name contains more
1422 than MAX_ALLOCA bytes.
1423 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1424 (get_minibuffer): Arg is now EMACS_INT, not int.
1425 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1426 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1427 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1428
2be7d702
PE
1429 * dbusbind.c (signature_cat): New function.
1430 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1431 Do not overrun buffer; instead, report string overflow.
1432
9d1df220
PE
1433 * dispnew.c (add_window_display_history): Don't overrun buffer.
1434 Truncate instead; this is OK since it's just a log.
1435
33ef5c64
PE
1436 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1437 even if the time zone offset is outlandishly large.
1438 Don't mishandle offset == INT_MIN.
1439
66c6fdd5
PE
1440 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1441 when creating daemon; the previous buffer-overflow check was incorrect.
1442
d749b01b
PE
1443 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1444 which has the guts of the old verror function.
1445
b5cd1905
PE
1446 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1447 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1448
6e1a67fb
PE
1449 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1450 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1451 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1452 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1453 length of string rather than counting it via multiple sprintfs;
1454 that's simpler and more reliable.
c21721cc
PE
1455 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1456 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1457 sprintf, in case result does not fit in int.
1458
c57b67fc
PE
1459 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1460 (fontset_from_font): Print it.
1461
8a401434
PE
1462 * frame.c (tty_frame_count): Now printmax_t, not int.
1463 (make_terminal_frame, set_term_frame_name): Print it.
1464 (x_report_frame_params): In X, window IDs are unsigned long,
1465 not signed long, so print them as unsigned.
1466 (validate_x_resource_name): Check for implausibly long names,
1467 and don't assume name length fits in 'int'.
1468 (x_get_resource_string): Don't blindly alloca invocation name;
1469 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1470 not fit in int.
1471
6e1a67fb
PE
1472 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1473 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1474 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1475
0df02bf3
PE
1476 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1477 Use esprintf, not sprintf, in case result does not fit in int.
1478
48e30793
PE
1479 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1480 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1481 it as a large positive number.
1482 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1483 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1484
a66ff6d8
PE
1485 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1486 in case result does not fit in int.
1487
aca216ff
PE
1488 * print.c (float_to_string): Detect width overflow more reliably.
1489 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1490 buffer overrun. Don't assume list length fits in 'int'. Treat
1491 print length of 0 as 0, not as infinity; to be consistent with other
1492 uses of print length in this function. Don't overflow print length
1493 index. Don't assume hash table size fits in 'long', or that
1494 vectorlike size fits in 'unsigned long'.
1495
31c286f7
PE
1496 * process.c (make_process): Use printmax_t, not int, to format
1497 process-name gensyms.
1498
55e5faa1
PE
1499 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1500
80f2e268
PE
1501 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1502 to avoid potential buffer overrun.
1503
670741ab
PE
1504 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1505 if X resource line is longer than 512 bytes.
1506
b7163a50
PE
1507 * xfns.c (x_window): Make sprintf buffer a bit bigger
1508 to avoid potential buffer overrun.
1509
ae58ff1f
PE
1510 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1511
c43c8a6a
PE
1512 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1513
3f8236f4
PE
15142011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1515
53e9fe90 1516 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1517 Without these, Emacs silently mishandles large integers sometimes.
1518 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1519 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1520
6511acf2
PE
1521 * xdisp.c (try_window_id): Check Emacs fixnum range before
1522 converting to 'int'.
806add1d 1523
6511acf2 1524 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1525 Check that an Emacs fixnum is in range before assigning it to 'int'.
1526 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1527 values converted from Emacs fixnums.
1528 (Frecenter): Don't wrap around a line count if it is out of 'int'
1529 range; instead, treat it as an extreme value.
1530 (Fset_window_configuration, compare_window_configurations):
1531 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1532
6511acf2
PE
1533 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1534 that can exceed INT_MAX. Check that EMACS_INT value is in range
1535 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1536 (match_limit): Don't assume that a fixnum can fit in 'int'.
1537
6511acf2 1538 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1539 exceed INT_MAX.
1540
6511acf2 1541 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1542 (Fvertical_motion): Don't wrap around LINES values that don't fit
1543 in 'int'. Instead, treat them as extreme values. This is good
1544 enough for windows, which can't have more than INT_MAX lines anyway.
1545
fcb901a7
LMI
15462011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1547
0f2f6b6d
LMI
1548 * Require libxml/parser.h to avoid compilation warning.
1549
fcb901a7
LMI
1550 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1551
1552 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1553 since this reportedly can destroy thread storage.
1554
6e20a0d4
CY
15552011-08-30 Chong Yidong <cyd@stupidchicken.com>
1556
1557 * syntax.c (find_defun_start): Update all cache variables if
1558 exiting early (Bug#9401).
1559
148ae00e
EZ
15602011-08-30 Eli Zaretskii <eliz@gnu.org>
1561
f6cfbd8f
EZ
1562 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1563
148ae00e
EZ
1564 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1565 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1566 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1567
1568 * term.c (tty_append_glyph): New function.
1569 (produce_stretch_glyph): Static function and its prototype deleted.
1570
a66cfb1c
SM
1571 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1572 Add prototypes.
148ae00e 1573
c4a07a4c
PE
15742011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1575
1576 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1577 when checking :margin (Bug#9390).
1578 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1579 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1580 so that the name doesn't mislead. All uses changed.
1581
6bc8cd65
JB
15822011-08-28 Johan Bockgård <bojohan@gnu.org>
1583
1584 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1585 set_tty_hooks.
1586
dca4927e
EZ
15872011-08-27 Eli Zaretskii <eliz@gnu.org>
1588
1589 * xdisp.c (move_it_to): Don't bail out early when reaching
1590 position beyond to_charpos, if we are scanning backwards.
1591 (move_it_vertically_backward): When DY == 0, make sure we get to
1592 the first character in the line after the newline.
1593
f2cad773
PE
15942011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1595
1596 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1597 (ccl_driver): Do not generate an out-of-range pointer.
1598 (Fccl_execute_on_string): Remove unnecessary check for
1599 integer overflow, noted by Stefan Monnier in
1600 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1601 Remove a FIXME that didn't need fixing.
1602 Simplify the newly-introduced buffer reallocation code.
1603
0cae2cdb
JB
16042011-08-27 Juanma Barranquero <lekktu@gmail.com>
1605
1606 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1607
5fc295a4 16082011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1609
70c60eb2 1610 Integer and memory overflow issues (Bug#9196).
726e0ab1 1611
d31850da
PE
1612 * doc.c (get_doc_string): Rework so that
1613 get_doc_string_buffer_size is the actual buffer size, rather than
1614 being 1 less than the actual buffer size; this makes xpalloc more
1615 convenient.
1616
a69fbedb
PE
1617 * image.c (x_allocate_bitmap_record, cache_image):
1618 * xselect.c (Fx_register_dnd_atom):
1619 Simplify previous changes by using xpalloc.
1620
fe5c5d37
PE
1621 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1622 since either will do and ptrdiff_t is convenient with xpalloc.
1623
0065d054
PE
1624 * charset.c (charset_table_size)
1625 (struct charset_sort_data.priority): Now ptrdiff_t.
1626 (charset_compare): Don't overflow if priorities differ greatly.
1627 (Fsort_charsets): Don't assume list length fits in int.
1628 Check for size-calculation overflow when allocating sort data.
1629 (syms_of_charset): Allocate an initial charset table that is
1630 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1631
1632 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1633
1634 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1635 The actual value is always <= INT_MAX, and leaving it unsigned made
1636 overflow checking harder.
1637
1638 * dispextern.h (struct glyph_matrix.rows_allocated)
1639 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1640 with xpalloc. The values are still always <= INT_MAX.
1641
1642 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1643
1644 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1645 (SAFE_NALLOCA): New macro.
1646
1647 * region-cache.c (struct boundary.pos, find_cache_boundary)
1648 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1649 (set_cache_region, invalidate_region_cache)
1650 (revalidate_region_cache, know_region_cache, region_cache_forward)
1651 (region_cache_backward, pp_cache):
1652 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1653 so that ptrdiff_t * can be passed to xpalloc.
1654 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1655 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1656 (pp_cache): Don't assume cache_len fits in int.
1657 * region-cache.h: Adjust extern decls to match.
1658
1659 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1660 EMACS_INT, since either will do, for xpalloc.
1661
1662 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1663 (xnmalloc, xnrealloc, xpalloc): New functions.
1664
726e0ab1
PE
1665 * bidi.c (bidi_shelve_header_size): New constant.
1666 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1667 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1668
51f30bc5 1669 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1670 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1671 (overlay_strings):
1672 Don't update size of array until after memory allocation succeeds,
1673 because xmalloc/xrealloc may not return.
0065d054
PE
1674 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1675 now that we have proper integer overflow checking.
1676 (record_overlay_string, overlay_strings): Catch overflows when
1677 calculating size of overlay_str_buf.
726e0ab1 1678
0065d054
PE
1679 * callproc.c (Fcall_process): Check for size overflow when
1680 calculating size of args2.
1681 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1682 Normally we prefer signed values, but sticking with ptrdiff_t would
1683 require adding more-complicated checks.
726e0ab1
PE
1684
1685 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1686 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1687 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1688 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1689
1690 * character.c (Fstring): Check for size-calculation overflow.
1691
1692 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1693 unnecessary integer overflow. Check for size overflow.
1694 (encode_coding_object): Don't update size until xmalloc succeeds.
1695
1696 * composite.c (get_composition_id): Check for overflow in glyph
1697 length calculations.
1698
1699 Integer and memory overflow fixes for display code.
1700 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1701 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1702 (scrolling_window): Check for overflow in size calculations.
1703 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1704 Don't assume glyph table len fits in int.
1705 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1706 (row_table_size): Now ptrdiff_t, not int.
1707 (scrolling_window): Avoid overflow in size calculations.
1708 Don't update size until allocation succeeds.
1709 * fns.c (concat): Check for overflow in size calculations.
1710 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1711 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1712 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1713
1714 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1715 (get_doc_string): Check for size calculation overflow.
1716 Don't update size until allocation succeeds.
1717 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1718 EMACS_INT, where ptrdiff_t will do.
1719 (Fsubstitute_command_keys): Check for string overflow.
1720
1721 * editfns.c (set_time_zone_rule): Don't assume environment length
1722 fits in int.
1723 (message_length): Now ptrdiff_t, not int.
1724 (Fmessage_box): Don't update size until allocation succeeds.
1725 Don't assume message length fits in int.
1726 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1727
0065d054
PE
1728 * emacs.c (main): Do not reallocate argv, since there is a null at
1729 the end that can be overwritten, and this way there's no need to
1730 worry about size-calculation overflow.
1731 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1732
1733 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1734 alloc succeeds.
1735 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1736
1737 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1738 (x_set_scroll_bar_width, x_figure_window_size):
1739 Check for integer overflow.
1740 (x_set_alpha): Do not assume XINT fits in int.
1741
1742 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1743 This is for the members text_lines, text_cols, total_lines, total_cols,
1744 where the system imposes an 'int' limit.
1745
1746 * fringe.c (Fdefine_fringe_bitmap):
1747 Don't update size until alloc works.
1748
1749 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1750 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1751
1752 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1753 Check for size-calculation overflow.
1754 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1755 do, as we prefer signed integers.
1756 (id_to_widget.max_size, id_to_widget.used)
1757 (xg_store_widget_in_map, xg_remove_widget_from_map)
1758 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1759 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1760 Use and return ptrdiff_t, not int.
1761 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1762 * gtkutil.h: Change prototypes to match the above.
1763
1764 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1765 are duplicate now that they've been promoted to lisp.h.
1766 (x_allocate_bitmap_record, x_alloc_image_color)
1767 (make_image_cache, cache_image, xpm_load):
1768 Don't update size until alloc is done.
1769 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1770 (x_detect_edges):
3256efce 1771 Check for size calculation overflow.
726e0ab1
PE
1772 (ct_colors_allocated_max): New constant.
1773 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1774 overflow.
3256efce 1775
726e0ab1
PE
1776 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1777 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1778 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1779 Use ptrdiff_t, not int, to count maps.
1780 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1781 calculations. Don't update size until allocation succeeds.
1782 Redo calculations to avoid overflow.
726e0ab1
PE
1783 * keyboard.h: Change prototypes to match the above.
1784
1785 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1786 to count maps.
1787 (current_minor_maps): Check for size calculation overflow.
1788 * keymap.h: Change prototypes to match the above.
1789
1790 * lread.c (read1, init_obarray): Don't update size until alloc done.
1791
1792 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1793 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1794
726e0ab1
PE
1795 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1796 Now ptrdiff_t, not int.
1797 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1798 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1799
1800 * process.c (Fnetwork_interface_list): Check for overflow
1801 in size calculation.
1802
1803 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1804
1805 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1806 overflow. Don't bother calling xmalloc when xrealloc will do.
1807
1808 * search.c (Freplace_match): Check for size calculation overflow.
1809 (Fset_match_data): Don't assume list lengths fit in 'int'.
1810
1811 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1812 for command line length. Do not attempt to address one before the
1813 beginning of an array, as that's not portable.
1814
1815 * term.c (max_frame_lines): Remove; unused.
1816 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1817 not int.
1818 (encode_terminal_code, calculate_costs): Check for size
1819 calculation overflow.
1820 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1821 table lengths and related sizes. Don't update size until alloc
1822 done. Redo calculations to avoid overflow.
1823 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1824
1825 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1826 subtracting pointers.
1827 (gobble_line): Check for overflow more carefully. Don't update size
1828 until alloc done.
1829
1830 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1831 Don't update size until alloc done.
1832 Redo size calculations to avoid overflow.
1833 Check for size calculation overflow.
0065d054 1834 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1835
1836 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1837 Use ptrdiff_t, not int, for sizes.
1838 (store_mode_line_noprop_char): Don't update size until alloc done.
1839
0065d054
PE
1840 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1841 Use ptrdiff_t, not int, for sizes.
1842 (Finternal_make_lisp_face, cache_face):
1843 Check for size calculation overflow.
1844 (cache_face): Treat size calculation overflows as if they were
1845 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1846
1847 * xfns.c (x_encode_text, x_set_name_internal)
1848 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1849 sizes, since they can exceed INT_MAX in size. Check for size
1850 calculation overflow.
1851
0065d054
PE
1852 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1853 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1854 Don't update size until alloc done.
1855
0065d054 1856 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1857 as sprintf is limited to int lengths.
1d526e2f 1858
252c5ee1
PE
1859 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1860 (X_LONG_MIN): New macros.
864d7ce7
PE
1861 Use them to make the following changes clearer.
1862 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1863 This change doesn't affect the value now, but it may help remind
1864 future maintainers not to raise the value too much later.
1865 (SELECTION_QUANTUM): Remove, replacing with ...
1866 (selection_quantum): ... new function, which avoids overflow.
1867 All uses changed.
1868 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1869 assumption that selection length fits in 'int'.
1870 (x_reply_selection_request, x_handle_selection_request)
1871 (x_get_window_property, receive_incremental_selection)
1872 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1873 (lisp_data_to_selection_data, clean_local_selection_data):
1874 Use ptrdiff_t, not int, to record length of selection.
1875 (x_reply_selection_request, x_get_window_property)
1876 (receive_incremental_selection, x_property_data_to_lisp):
1877 Redo calculations to avoid overflow.
1878 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1879 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1880 something.
1881 (x_get_window_property, receive_incremental_selection)
1882 (lisp_data_to_selection_data, x_property_data_to_lisp):
1883 Check for size-calculation overflow.
1884 (x_get_window_property, receive_incremental_selection)
1885 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1886 Don't store size until memory allocation succeeds.
1887 (x_get_window_property): Plug memory leak on memory exhaustion.
1888 Don't double-block input; malloc is safe here. Don't assume 2**34
1889 - 4 fits in unsigned long. Add an xassert to check
1890 XGetWindowProperty overflow. Be more careful about overflow
1891 calculations, and distinguish size from memory overflow better.
1892 (receive_incremental_selection): When tracing, don't assume
1893 unsigned int is less than INT_MAX.
1894 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1895 harmful) conversions of unsigned short to int.
1896 (lisp_data_to_selection_data): Don't assume that integers
1897 in the range -65535 through -1 fit in an X unsigned short.
1898 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1899 result parameters unless successful. Rely on cons_to_unsigned
1900 to report problems with elements; the old code wasn't right anyway.
1901 (x_check_property_data): Check for int overflow; we cannot use
1902 a wider type due to X limits.
1903 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1904
726e0ab1 1905 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1906
0065d054
PE
1907 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1908 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1909 (x_color_cells): Don't store size until memory allocation succeeds.
1910 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1911 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1912 (x_term_init): Don't assume length fits in int (sprintf is limited
1913 to int size).
bc18e09d 1914
ebfa62c0
PE
1915 Use ptrdiff_t for composition IDs.
1916 * character.c (lisp_string_width):
1917 * composite.c (composition_table_size, n_compositions)
1918 (get_composition_id, composition_gstring_from_id):
1919 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1920 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1921 * window.c (Frecenter):
1922 Use ptrdiff_t, not int, for composition IDs.
1923 * composite.c (get_composition_id): Check for integer overflow.
1924 * composite.h: Adjust prototypes to match the above changes.
1925
d3411f89
PE
1926 Use ptrdiff_t for hash table indexes.
1927 * category.c (hash_get_category_set):
1928 * ccl.c (ccl_driver):
1929 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1930 * coding.c (coding_system_charset_list, detect_coding_system):
1931 * coding.h (struct coding_system.id):
1932 * composite.c (get_composition_id, gstring_lookup_cache):
1933 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1934 * image.c (xpm_get_color_table_h):
1935 * lisp.h (hash_lookup, hash_put):
1936 * minibuf.c (Ftest_completion):
1937 Use ptrdiff_t for hash table indexes, not int (which is too
1938 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1939 32-bit --with-wide-int hosts).
1940
e097a6fa
PE
1941 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1942 Add a FIXME comment about memory leaks.
1943 (syms_of_charset): Don't assume xmalloc returns.
1944
5637687f
PE
1945 Don't assume that stated character widths fit in int.
1946 * character.c (Fchar_width, c_string_width, lisp_string_width):
1947 * character.h (CHAR_WIDTH):
1948 * indent.c (MULTIBYTE_BYTES_WIDTH):
1949 Use sanitize_char_width to avoid undefined and/or bad behavior
1950 with outlandish widths.
a66cfb1c 1951 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1952 now that we have two such functions. All uses changed.
1953 (sanitize_char_width): New inline function.
1954
a2271ba2
PE
1955 Don't assume that tab-width fits in int.
1956 * character.h (sanitize_width): New inline function.
1957 (SANE_TAB_WIDTH): New macro.
1958 (ASCII_CHAR_WIDTH): Use it.
1959 * indent.c (sane_tab_width): Remove. All uses replaced by
1960 SANE_TAB_WIDTH (current_buffer).
1961 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1962
18c52557
PE
1963 * fileio.c: Integer overflow issues with file modes.
1964 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1965
caeeedc1
PE
1966 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1967 Remove unreachable code.
1968 (read_hex, load_charset_map_from_file): Check for integer overflow.
1969
50849c52
PE
1970 * xterm.c: don't go over XClientMessageEvent limit
1971 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1972 (x_send_scroll_bar_event): Likewise. Check that the size does not
1973 exceed limits imposed by XClientMessageEvent, as well as the usual
1974 ptrdiff_t and size_t limits.
1975
b13995db
PE
1976 * keyboard.c: Overflow, signedness and related fixes.
1977 (make_lispy_movement): Use same integer type in forward decl
1978 that is used in the definition.
1979 (read_key_sequence, keyremap_step):
1980 Change bufsize argument back to int, undoing my 2011-03-30 change.
1981 We prefer signed types, and int is wide enough here.
1982 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1983 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1984 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1985 length, not size_t. Use ptrdiff_t for index, not int.
1986 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1987 possibility of integer overflow.
1988
13464394
PE
1989 Overflow, signedness and related fixes for images.
1990
1991 * dispextern.h (struct it.stack[0].u.image.image_id)
1992 (struct_it.image_id, struct image.id, struct image_cache.size)
1993 (struct image_cache.used, struct image_cache.ref_count):
1994 * gtkutil.c (update_frame_tool_bar):
1995 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1996 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1997 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1998 * nsmenu.m (update_frame_tool_bar):
1999 * xdisp.c (calc_pixel_width_or_height):
2000 * xfns.c (image_cache_refcount):
2001 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2002 on typical 64-bit hosts.
2003
2004 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2005 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2006 Omit unnecessary casts to int.
2007 (parse_image_spec): Check that integers fall into 'int' range
2008 when the callers expect that.
2009 (image_ascent): Redo ascent calculation to avoid int overflow.
2010 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2011 (lookup_image): Remove unnecessary tests.
2012 (xbm_image_p): Locals are now of int, not EMACS_INT,
2013 since parse_image_check makes sure they fit into int.
2014 (png_load, gif_load, svg_load_image):
2015 Prefer int to unsigned where either will do.
2016 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2017 old tiff_error_handler and tiff_warning_handler.
2018 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2019 stack buffer overflows. It uses only the features of vsnprintf
2020 that are common to both POSIX and native Microsoft.
2021 (tiff_error_handler, tiff_warning_handler): Use it.
2022 (tiff_load, gif_load, imagemagick_load_image):
2023 Don't assume :index value fits in 'int'.
2024 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2025 (imagemagick_load_image): Check that crop parameters fit into
2026 the integer types that MagickCropImage accepts. Don't assume
2027 Vimagemagick_render_type has a nonnegative value. Don't assume
2028 size_t fits in 'long'.
2029 (gs_load): Use printmax_t to print the widest integers possible.
2030 Check for integer overflow when computing image height and width.
2031
c11821d4
EZ
20322011-08-26 Eli Zaretskii <eliz@gnu.org>
2033
2034 * xdisp.c (redisplay_window): Don't force window start if point
2035 will be invisible in the resulting window. (Bug#9324)
2036
0c95fcf7
EZ
20372011-08-25 Eli Zaretskii <eliz@gnu.org>
2038
2039 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2040 the display spec is of the form `(space ...)'.
2041 (handle_display_spec): Return the value returned by
2042 handle_single_display_spec, not just 1 or zero.
2043 (handle_single_display_spec): If the display spec is of the form
2044 `(space ...)', and specifies display in the text area, return 2
2045 rather than 1.
fee65a97 2046 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2047 accurately, and prefer exact match for point under bidi.
2048 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2049
2050 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2051 into disp_prop; all users changed.
2052
2053 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2054 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2055 for the text covered by the display property.
2056
e4ed06f1
CY
20572011-08-25 Chong Yidong <cyd@stupidchicken.com>
2058
2059 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2060 Change return value to nil.
2061 (Frecord_buffer): Delete unused function.
2062
f67cdd7f
EZ
20632011-08-24 Eli Zaretskii <eliz@gnu.org>
2064
5980d4c6
EZ
2065 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2066 buffers, return left-to-right.
8610fe8b
EZ
2067 (set_cursor_from_row): Consider candidate row a win if its glyph
2068 represents a newline and point is on that newline. Fixes cursor
2069 positioning on the newline at EOL of R2L text within L2R
2070 paragraph, and vice versa.
2071 (try_cursor_movement): Check continued rows, in addition to
2072 continuation rows. Fixes unwarranted scroll when point enters a
2073 continued line of R2L text within an L2R paragraph, or vice versa.
2074 (cursor_row_p): Consider the case of point being equal to
2075 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2076 from the end of a short line to the beginning of a continued line
2077 of R2L text within L2R paragraph.
2078 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2079 composed characters.
5980d4c6 2080
f67cdd7f
EZ
2081 * bidi.c (bidi_check_type): Use xassert.
2082 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2083 members.
2084
bca633fb
EZ
20852011-08-23 Eli Zaretskii <eliz@gnu.org>
2086
2087 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2088 a character.
2089
4a5885a7
CY
20902011-08-23 Chong Yidong <cyd@stupidchicken.com>
2091
2092 * nsfont.m (ns_otf_to_script): Fix typo.
2093
0902a04e
KH
20942011-08-22 Kenichi Handa <handa@m17n.org>
2095
2096 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2097 extra slot even if the purpose is char-code-property-table.
2098
1a2e6670
EZ
20992011-08-23 Eli Zaretskii <eliz@gnu.org>
2100
8ddde651
EZ
2101 * xdisp.c (redisplay_window): When computing centering_position,
2102 account for the height of the header line. (Bug#8874)
2103
425cc014
EZ
2104 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2105 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2106 candidate is selected by the mouse, and that candidate has a
2107 composed character under the mouse.
2108
1a2e6670
EZ
2109 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2110 coordinates reported by pos-visible-in-window-p for a composed
2111 character in column zero.
2112
8b76d6f8
SM
21132011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2114
2115 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2116
dac347dd
EZ
21172011-08-22 Eli Zaretskii <eliz@gnu.org>
2118
2119 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2120 consider it a hit if to_charpos is anywhere in the range of the
2121 composed buffer positions.
2122
e013fb34
CY
21232011-08-22 Chong Yidong <cyd@stupidchicken.com>
2124
2125 * image.c (gif_load): Don't assume that each subimage has the same
2126 dimensions as the base image. Handle disposal method that is
2127 "undefined" by the gif spec (Bug#9335).
2128
bd1ba3e8
CY
21292011-08-20 Chong Yidong <cyd@stupidchicken.com>
2130
2131 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2132 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2133
54a1215b
EZ
21342011-08-19 Eli Zaretskii <eliz@gnu.org>
2135
823564e5
EZ
2136 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2137 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2138 from an Org mode buffer to a Speedbar frame.
2139
54a1215b
EZ
2140 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2141 a composition, take its buffer position from IT->cmp_it.charpos.
2142 Fixes cursor positioning at the beginning of a line that begins
2143 with a composed character.
2144
9778ebcc
EZ
21452011-08-18 Eli Zaretskii <eliz@gnu.org>
2146
0be6ee06
EZ
2147 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2148 character bidirectional type, use STRONG_L instead. Fixes crashes
2149 in a buffer produced by `describe-categories'.
2150
9778ebcc
EZ
2151 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2152 members before the level stack, so they would be saved and
2153 restored when copying iterator state. Fixes incorrect reordering
2154 around TABs covered by display properties.
2155
156bffbe
AS
21562011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2157
6b02f655 2158 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2159
72ad093b
CY
21602011-08-17 Chong Yidong <cyd@stupidchicken.com>
2161
2162 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2163 (internal_condition_case_2, internal_condition_case_n):
2164 Remove unnecessary aborts (Bug#9081).
72ad093b 2165
35774242
EZ
21662011-08-17 Eli Zaretskii <eliz@gnu.org>
2167
2168 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2169 has no `load' handler, try opening the file locally. (Bug#9311)
2170
db76dd85
KB
21712011-08-16 Ken Brown <kbrown@cornell.edu>
2172
2173 * gmalloc.c: Expand comment.
2174
b215eee5
EZ
21752011-08-16 Eli Zaretskii <eliz@gnu.org>
2176
2177 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2178 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2179
a4579d33
KB
21802011-08-16 Ken Brown <kbrown@cornell.edu>
2181
2182 Fix memory allocation problems in Cygwin build (Bug#9273).
2183
2184 * unexcw.c ( __malloc_initialized): Declare external variable.
2185 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2186
8b76d6f8
SM
2187 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2188 New variables.
a4579d33
KB
2189 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2190 dumped emacs.
2191 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2192 in the static heap.
2193 [CYGWIN] (special_realloc): New function.
2194 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2195 requests to realloc storage in the static heap.
2196
3ebec551
PE
21972011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2198
2199 * bidi.c (bidi_initialize): Remove unused local.
2200
9fd8be00
EZ
22012011-08-15 Eli Zaretskii <eliz@gnu.org>
2202
6b02f655
SM
2203 * bidimirror.h:
2204 * biditype.h: Remove file.
2205 * makefile.w32-in ($(BLD)/bidi.$(O)):
2206 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2207
2208 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2209
2210 * chartab.c: Improve commentary for the uniprop_table API.
2211
32413314
EZ
2212 * bidi.c (bidi_paragraph_init): Support zero value of
2213 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2214 (bidi_initialize): Use uniprop_table instead of including
2215 biditype.h and bidimirror.h.
32413314 2216
9fd8be00
EZ
2217 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2218 coordinates of the iterator when restoring from ppos_it.
2219 (Bug#9296)
2220
5cf2b69b
KH
22212011-08-14 Kenichi Handa <handa@m17n.org>
2222
2223 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2224 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2225
daf17d00
EZ
22262011-08-14 Eli Zaretskii <eliz@gnu.org>
2227
2228 * xdisp.c (move_it_in_display_line_to): Don't invoke
2229 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2230 ppos_it. Fixes vertical cursor motion when line beginning is
2231 covered by an image. (Bug#9296)
2232
08e3161a
JD
22332011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2234
2235 * nsterm.h (ns_run_ascript): Declare.
2236 (NSAPP_DATA2_RUNASSCRIPT): Define.
2237
2238 * nsfns.m (as_script, as_result, as_status): New static variables.
2239 (ns_run_ascript): New function.
5e617bc2 2240 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2241 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2242 the event loop. Get status from as_status (Bug#7276).
2243
2244 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2245 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2246 the event loop (Bug#7276).
2247
a3720aa2
AS
22482011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2249
2250 * gnutls.c (QCgnutls_bootprop_priority)
2251 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2252 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2253 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2254 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2255 (QCgnutls_bootprop_verify_hostname_error)
2256 (QCgnutls_bootprop_callbacks_verify): Rename from
2257 Qgnutls_bootprop_..., all uses changed.
2258
2259 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2260 uses changed.
2261
0a0d27fb
PE
22622011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2263
19d5c50c
PE
2264 * xfaces.c (Qframe_set_background_mode): Now static.
2265 * dispextern.h (Qframe_set_background_mode): Remove decl.
2266
0a0d27fb
PE
2267 * process.c (Fnetwork_interface_info): Declare local only if needed.
2268
377538cb
JD
22692011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2270
2271 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2272 (Fnetwork_interface_list): Allocate in increments of bytes instead
2273 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2274 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2275 sockaddr.
2276 (struct ifflag_def): notrailers is smart on OSX.
2277 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2278 Get hardware address with getifaddrs if available.
2279
08fff70c
EZ
22802011-08-12 Eli Zaretskii <eliz@gnu.org>
2281
2282 * xdisp.c (iterate_out_of_display_property): xassert that
2283 IT->position is set to within IT->object's boundaries. Break from
2284 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2285 when IT->position is set up wrongly due to some bug.
2286 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2287 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2288 entry. Force push_it to save on the stack the current
2289 buffer/string position, to be restored by pop_it. Fix flags in
2290 the iterator structure wrt the object coming from a display
2291 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2292 properties. (Bug#9284)
2293
7be1c708 22942011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2295
7be1c708
CY
2296 * fontset.c (fontset_get_font_group): Add proper type checks.
2297 (Bug#9172)
aac0c6e3 2298
7be1c708 22992011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2300
7be1c708
CY
2301 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2302 and LC_VERSION_MIN_MACOSX.
2303 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2304 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2305
97bb72a6
EZ
23062011-08-08 Eli Zaretskii <eliz@gnu.org>
2307
2308 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2309 no-display-properties-and-no-overlays under bidi display.
2310 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2311 properties and overlays.
97bb72a6 2312
d5617611
CY
23132011-08-08 Chong Yidong <cyd@stupidchicken.com>
2314
37e11a63
CY
2315 * editfns.c (Fset_time_zone_rule): Document relationship with the
2316 setenv function.
2317
d5617611
CY
2318 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2319 the font entity extracted from the cache (Bug#8109).
2320
58872834
CY
23212011-08-07 Chong Yidong <cyd@stupidchicken.com>
2322
2323 * composite.c (autocmp_chars): Don't reset point. That is done by
2324 restore_point_unwind (Bug#5984).
2325
75bfc667
JL
23262011-08-07 Juri Linkov <juri@jurta.org>
2327
2328 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2329 to show the arg `TIME' instead of `TIMEVAL'.
2330
d1410150
EZ
23312011-08-06 Eli Zaretskii <eliz@gnu.org>
2332
2333 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2334 display property strides EOL and includes a newline, as in
2335 longlines-mode. (Bug#9254)
75b771e4
EZ
2336 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2337 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2338
2339 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2340 is non-zero, even if the data buffer is NULL. Fixes a crash in
2341 vertical-motion with longlines-mode. (Bug#9254)
2342
35928349
EZ
23432011-08-05 Eli Zaretskii <eliz@gnu.org>
2344
ec7cc85b
EZ
2345 * bidi.c <bidi_cache_total_alloc>: Now static.
2346 (bidi_initialize): Initialize bidi_cache_total_alloc.
2347
8b76d6f8 2348 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2349 cache. (Bug#9221)
2350
2351 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2352 amount allocated this far in `bidi_cache_total_alloc'.
2353 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2354 non-zero, only free the data buffer without restoring the cache
2355 contents. All callers changed.
2356
2357 * dispextern.h (bidi_unshelve_cache): Update prototype.
2358
2359 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2360 (move_it_in_display_line, move_it_to)
2361 (move_it_vertically_backward, move_it_by_lines): Replace the call
2362 to xfree to an equivalent call to bidi_unshelve_cache.
2363 (move_it_in_display_line_to): Fix logic of returning
412b6358 2364 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2365
e2e2423b
EZ
23662011-08-05 Eli Zaretskii <eliz@gnu.org>
2367
2368 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2369 came from a string character with a `cursor' property. (Bug#9229)
2370
ae9e757a
JD
23712011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2372
2373 * Makefile.in (LIB_PTHREAD): New variable.
2374 (LIBES): Add LIB_PTHREAD (Bug#9216).
2375
2376 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2377 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2378
213bd7f2
AS
23792011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2380
6b02f655 2381 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2382
99aaf75f
JD
23832011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2384
2385 * xterm.c (x_find_topmost_parent): New function.
2386 (x_set_frame_alpha): Find topmost parent window with
2387 x_find_topmost_parent and set the property there also (bug#9181).
2388 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2389
c74e9d86
PE
23902011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2391
2392 * callproc.c (Fcall_process): Avoid vfork clobbering
2393 the local vars buffer, coding_systems, current_dir.
2394
640c8776
SM
23952011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2396
2397 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2398
f26d0e4c
PE
23992011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2400
8a10d76c
PE
2401 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2402 so that it is not optimized away.
2403
f26d0e4c
PE
2404 * xdisp.c (compute_display_string_pos): Remove unused local.
2405
55439c61
EZ
24062011-08-02 Eli Zaretskii <eliz@gnu.org>
2407
2408 Fix slow cursor motion and scrolling in large buffers with
2409 selective display, like Org Mode buffers. (Bug#9218)
2410
2411 * dispextern.h (struct bidi_it): New member disp_prop_p.
2412
2413 * xdisp.c: Remove one-slot cache of display string positions.
2414 (compute_display_string_pos): Accept an additional argument
5e617bc2 2415 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2416 for a display string or property. If found, set DISP_PROP_P
2417 non-zero.
2418
2419 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2420 DISP_PROP_P, and pass it to compute_display_string_pos.
2421 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2422 non-zero. All callers of bidi_fetch_char changed.
2423
fb33fa43
SM
24242011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2425
2426 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2427
b099e063
DM
24282010-12-03 Don March <don@ohspite.net>
2429
2430 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2431 last character M-[char] is translated to ESC [char] (bug#7541).
2432
5cc7f7af
KH
24332011-08-02 Kenichi Handa <handa@m17n.org>
2434
d0fffa3f 2435 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2436
2437 * chartab.c (uniprop_table): Make it non-static.
2438
525d5e6e
EZ
24392011-08-01 Eli Zaretskii <eliz@gnu.org>
2440
2441 * xdisp.c (forward_to_next_line_start): Accept additional argument
2442 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2443 on the newline.
2444 (reseat_at_next_visible_line_start): Use the bidi iterator state
2445 returned by forward_to_next_line_start to restore the state of
2446 it->bidi_it after backing up to previous newline. (Bug#9212)
2447
31011111
AS
24482011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2449
2450 * regex.c (re_comp): Protoize.
2451 (re_exec): Fix return type.
2452 (regexec): Fix type of `ret'. (Bug#9203)
2453
476371c4
PE
24542011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2455
e5d76069
PE
2456 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2457 This is needed if max-image-size is a floating-point number.
2458
9a79b20c
AS
24592011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2460
2461 * print.c (print_object): Print empty symbol as ##.
2462
2463 * lread.c (read1): Read ## as empty symbol.
2464
d8c2fa78
AA
24652011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2466
2467 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2468 setting frame foreground color (Bug#9175).
2469 (x_set_background_color): Likewise.
2470
ffe57a7a
AA
2471 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2472 contents (Bug#9176).
2473 (EmacsTooltip -init): Remove bezels and add shadows to
2474 tooltip windows.
2475
bf3492a5
AA
2476 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2477 or scroll bar (Bug#8470).
2478
d55e9c53
AA
2479 * nsfont.m (nsfont_open): Remove assignment to voffset and
2480 unnecessary vars hshink, expand, hd, full_height, min_height.
2481 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2482
2483 * nsterm.h (nsfont_info): Remove voffset field.
2484
d8c2fa78 24852011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2486
2487 Implement strike-through and overline on NextStep (Bug#8863).
2488
2489 * nsfont.m (nsfont_open): Use underline position provided by font,
2490 instead of hard-coded value of 2.
2491 (nsfont_draw): Call ns_draw_text_decoration instead.
2492
2493 * nsterm.h: Add declaration for ns_draw_text_decoration.
2494
2495 * nsterm.m (ns_draw_text_decoration): New function for drawing
2496 underline, overline, and strike-through.
2497 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2498 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2499 accommodate underlining, etc.
4843aac3 2500
4cc60b9b
EZ
25012011-07-28 Eli Zaretskii <eliz@gnu.org>
2502
bc7ece87
EZ
2503 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2504 default.
4cc60b9b 2505
476371c4
PE
25062011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2507
66606eea
PE
2508 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2509 Without this fix, if a signal arrives just after memory fills up,
2510 'malloc' might be invoked reentrantly.
2511
476371c4
PE
2512 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2513 In other words, assume that every image size is allowed, on non-X
2514 hosts. This assumption is probably wrong, but it lets Emacs compile.
2515
f3fcc40d
AS
25162011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2517
2518 * regex.c (re_iswctype): Convert return values to boolean.
2519
350c992f
EZ
25202011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2521
2522 * xdisp.c (compute_display_string_pos): Don't use cached display
2523 string position if the buffer had its restriction changed.
2524 (Bug#9184)
2525
5266b4bb
PE
25262011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2527
2528 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2529
2573a837 25302011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2531
41f55ccd 2532 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2533
39e378da
PE
2534 * bidi.c: Integer size and overflow fixes.
2535 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2536 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2537 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2538 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2539 (bidi_find_other_level_edge):
2540 Use ptrdiff_t instead of EMACS_INT where either will do.
2541 This works better on 32-bit hosts configured --with-wide-int.
2542 (bidi_cache_ensure_space): Check for size-calculation overflow.
2543 Use % rather than repeated addition, for better worst-case speed.
2544 Don't set bidi_cache_size until after xrealloc returns, because it
2545 might not return.
2546 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2547 (bidi_cache_ensure_space): Also check that the bidi cache size
2548 does not exceed that of the largest Lisp string or buffer. See Eli
2549 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2550
5e927815
PE
2551 * alloc.c (__malloc_size_t): Remove.
2552 All uses replaced by size_t. See Andreas Schwab's note
2553 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2554
ca4aa935
PE
2555 * image.c: Improve checking for integer overflow.
2556 (check_image_size): Assume that f is nonnull, since
2557 it is always nonnull in practice. This is one less thing to
2558 worry about when checking for integer overflow later.
2559 (x_check_image_size): New function, which checks for integer
2560 overflow issues inside X.
2561 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2562 This removes the need for a memory_full check.
2563 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2564 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2565 (xbm_read_bitmap_data): Change locals back to 'int', since
2566 their values must fit in 'int'.
2567 (xpm_load_image, png_load, tiff_load):
2568 Invoke x_create_x_image_and_pixmap earlier,
2569 to avoid much needless work if the image is too large.
2570 (tiff_load): Treat overly large images as if
2571 x_create_x_image_and_pixmap failed, not as malloc failures.
2572 (gs_load): Use x_check_image_size.
2573
5f8f9cc2
PE
2574 * gtkutil.c: Omit integer casts.
2575 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2576 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2577
5adf60bc
PE
2578 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2579
c8907a93
PE
2580 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2581 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2582 would wrongly return t on a 64-bit host.
2583
e3c25c68
PE
2584 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2585 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2586 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2587 and therefore cause GCC to emit a bogus diagnostic in some cases.
2588
3f791afe
PE
2589 * image.c: Integer signedness and overflow and related fixes.
2590 This is not an exhaustive set of fixes, but it's time to
2591 record what I've got.
2592 (lookup_pixel_color, check_image_size): Remove redundant decls.
2593 (check_image_size): Don't assume that arbitrary EMACS_INT values
2594 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2595 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2596 (tiff_load, imagemagick_load_image):
2597 Check for overflow in size calculations.
2598 (x_create_x_image_and_pixmap): Remove unnecessary test for
2599 xmalloc returning NULL; that can't happen.
2600 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2601 (xpm_color_bucket): Use better integer hashing function.
2602 (xpm_cache_color): Don't possibly over-allocate memory.
2603 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2604 (gif_memory_source):
2605 Use ptrdiff_t, not int or size_t, to record sizes.
2606 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2607 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2608 either works, as we prefer signed integers.
2609 (tiff_read_from_memory, tiff_write_from_memory):
2610 Return tsize_t, not size_t, since that's what the TIFF API wants.
2611 (tiff_read_from_memory): Don't fail simply because the read would
2612 go past EOF; instead, return a short read.
2613 (tiff_load): Omit no-longer-needed casts.
2614 (Fimagemagick_types): Don't assume size fits into 'int'.
2615
3cc5a532
PE
2616 Improve hashing quality when configured --with-wide-int.
2617 * fns.c (hash_string): New function, taken from sxhash_string.
2618 Do not discard information about ASCII character case; this
2619 discarding is no longer needed.
2620 (sxhash-string): Use it. Change sig to match it. Caller changed.
2621 * lisp.h: Declare it.
2622 * lread.c (hash_string): Remove, since we now use fns.c's version.
2623 The fns.c version returns a wider integer if --with-wide-int is
2624 specified, so this should help the quality of the hashing a bit.
2625
b312a492
PE
2626 * emacs.c: Integer overflow minor fix.
2627 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2628 Define only if GNU_LINUX.
2629 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2630
dfd153ae
PE
2631 * dispnew.c: Integer signedness and overflow fixes.
2632 Remove unnecessary forward decls, that were a maintenance hassle.
2633 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2634 All uses changed.
2635 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2636 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2637 (prepare_desired_row, line_draw_cost):
2638 Use int, not unsigned, where either works.
2639 (save_current_matrix, restore_current_matrix):
2640 Use ptrdiff_t, not size_t, where either works.
2641 (init_display): Check for overflow more accurately, and without
2642 relying on undefined behavior.
2643
a81d11a3
PE
2644 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2645 Remove, replacing with the new symbols in lisp.h. All uses changed.
2646 * fileio.c (make_temp_name):
2647 * filelock.c (lock_file_1, lock_file):
2648 * xdisp.c (message_dolog):
2649 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2650 Use pMd etc. instead.
2651 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2652 replacing the pWIDE etc. symbols removed from editfns.c.
2653
3300e6fd
PE
2654 * keyboard.h (num_input_events): Now uintmax_t.
2655 This is (very slightly) less likely to mess up due to wraparound.
2656 All uses changed.
2657
fd05c7e9
PE
2658 * buffer.c: Integer signedness fixes.
2659 (alloc_buffer_text, enlarge_buffer_text):
2660 Use ptrdiff_t rather than size_t when either will do, as we prefer
2661 signed integers.
2662
903fe15d
PE
2663 * alloc.c: Integer signedness and overflow fixes.
2664 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2665 (__malloc_size_t): Default to size_t, not to int.
2666 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2667 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2668 Prefer ptrdiff_t to size_t when either would do, as we prefer
2669 signed integers.
2670 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2671 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2672 Now const. Initialize with values that are in range even if char
2673 is signed.
2674 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2675 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2676 These functions do the right thing with sizes > 2**32.
2677 (check_depth): Now ptrdiff_t, not int.
2678 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2679 Adjust to new way of storing sizes. Check for size overflow bugs
2680 in rest of code.
2681 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2682 slightly wrong anyway, as it missed one instance of
2683 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2684 (refill_memory_reserve): Omit needless cast to size_t.
2685 (mark_object_loop_halt): Mark as externally visible.
2686
ac82cc6a
PE
2687 * xselect.c: Integer signedness and overflow fixes.
2688 (Fx_register_dnd_atom, x_handle_dnd_message):
2689 Use ptrdiff_t, not size_t, since we prefer signed.
2690 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2691 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2692 x_dnd_atoms_size and x_dnd_atoms_length.
2693
c2d1e36d
PE
2694 * doprnt.c: Prefer signed to unsigned when either works.
2695 * eval.c (verror):
2696 * doprnt.c (doprnt):
2697 * lisp.h (doprnt):
2698 * xdisp.c (vmessage):
2699 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2700 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2701 prefer signed arithmetic to avoid comparison confusion.
2702 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2703 but is a bit tricky.
2704
0e926e56
PE
2705 Assume freestanding C89 headers, string.h, stdlib.h.
2706 * data.c, doprnt.c, floatfns.c, print.c:
2707 Include float.h unconditionally.
2708 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2709 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2710 * regex.c: Likewise for stddef.h, string.h.
2711 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2712 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2713 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2714 (STDC_HEADERS): Remove obsolete defines.
2715 * sysdep.c: Include limits.h unconditionally.
2716
9cfdb3ec
PE
2717 Assume support for memcmp, memcpy, memmove, memset.
2718 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2719 * regex.c (memcmp, memcpy):
2720 Remove; we assume C89 now.
2721
2722 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2723 (__malloc_safe_bcopy): Remove; no longer needed.
2724
cf950e6b 2725 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2726 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2727 well either way, and we prefer signed to unsigned.
2728
dbf38e02
LMI
27292011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2730
2731 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2732 closes the connection while we're reading (bug#9182).
2733
d6f0886c 27342011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2735
d6f0886c
JD
2736 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2737 are specified (Bug#9168).
24e0f6b1 2738
2eb1f9e6
PE
27392011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2740
2741 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2742 Found by GCC static checking and --with-wide-int on a 32-bit host.
2743
22381272 27442011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2745
2746 * xdisp.c (compute_display_string_pos): Fix logic of caching
2747 previous display string position. Initialize cached_prev_pos to
2748 -1. Fixes slow-down at the beginning of a buffer.
2749
f25e39b4
EZ
27502011-07-24 Eli Zaretskii <eliz@gnu.org>
2751
2752 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2753 for attrs[LFACE_FONTSET_INDEX].
2754
04c4b52e
PE
27552011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2756
2757 * xml.c (parse_region): Remove unused local
2758 that was recently introduced.
2759
c1734fbd
EZ
27602011-07-23 Eli Zaretskii <eliz@gnu.org>
2761
be18c5a5
EZ
2762 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2763 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2764
c1734fbd
EZ
2765 * xdisp.c (move_it_in_display_line_to): Record the best matching
2766 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2767 exit if none of the characters scanned was an exact match.
2768 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2769 when exact match is impossible due to invisible text, and the
2770 lines are truncated.
2771
a258d627
JD
27722011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2773
2774 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2775 for OSX >= 10.7.
2776
b6d5a689
EZ
27772011-07-22 Eli Zaretskii <eliz@gnu.org>
2778
0f74f785
EZ
2779 Fix a significant slow-down of cursor motion with C-n, C-p,
2780 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2781 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2782 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2783 (next_element_from_buffer): Call compute_stop_pos_backwards to
2784 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2785 base_level_stop.
2786 (reseat): Don't look for prev_stop, as that could mean a very long
2787 run.
2788 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2789 <cached_disp_overlay_modiff>: Cache for last found display string
2790 position.
551918c1 2791 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2792 about the same buffer in the same area of character positions, and
2793 the buffer wasn't changed since the time the display string
2794 position was cached.
551918c1 2795
b2d0c91a
EZ
27962011-07-22 Eli Zaretskii <eliz@gnu.org>
2797
2798 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2799 is an integer, which is important for empty lines. (Bug#9149)
2800
043604ee
CY
28012011-07-22 Chong Yidong <cyd@stupidchicken.com>
2802
2803 * frame.c (Fmodify_frame_parameters): In tty case, update the
2804 default face if necessary (Bug#4238).
2805
da4adb04
CY
28062011-07-21 Chong Yidong <cyd@stupidchicken.com>
2807
2808 * editfns.c (Fstring_to_char): No need to explain what a character
2809 is in the docstring (Bug#6576).
2810
9abd0532
LMI
28112011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2812
2813 * xml.c (parse_region): Make sure we always return a tree.
2814
36881d16
HK
28152011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2816
2817 * xml.c (parse_region): If a document contains only comments,
2818 return that, too.
2819
1e98674d
LMI
28202011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2821
2822 * xml.c (make_dom): Return comments, too.
2823
590bd467
PE
28242011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2825
2826 Port to OpenBSD.
2827 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2828 and the surrounding thread.
2829 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2830 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2831 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2832 timer goes off.
2833 * s/openbsd.h (BROKEN_SIGIO): Define.
2834 * unexelf.c (unexec) [__OpenBSD__]:
2835 Don't update the .mdebug section of the Alpha COFF symbol table.
2836
f41628b2
LMI
28372011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2838
2839 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2840 (bug#8460).
2841
b59b67c5
PE
28422011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2843
15e3a074
PE
2844 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2845 This fixes some race conditions on the permissions of any newly
2846 created file.
2847
41bed37d
PE
2848 * alloc.c (valid_pointer_p): Use pipe, not open.
2849 This fixes some permissions issues when debugging.
2850
b59b67c5
PE
2851 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2852 If fchown fails to set both uid and gid, try to set just gid,
2853 as that is sometimes allowed. Adjust the file's mode to eliminate
2854 setuid or setgid bits that are inappropriate if fchown fails.
2855
925a6be7
SM
28562011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2857
2858 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2859 to compare Lisp_Objects.
2860 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2861 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2862 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2863
52968808
AS
28642011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2865
0a6a104b
AS
2866 * lread.c (read_integer): Unread even EOF character.
2867 (read1): Likewise. Properly record start position of symbol.
2868
52968808
AS
2869 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2870 symbol character follows.
2871
9e381cdd
PE
28722011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2873
2874 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2875 This works around a problem with the previous change to Fcopy_file.
2876 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2877 and without this change, GCC might complain about discarding
2878 fchown's return value.
2879
b5641435
JB
28802011-07-16 Juanma Barranquero <lekktu@gmail.com>
2881
2882 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2883
a8031457
PE
28842011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2885
2886 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2887
dd889327
LMI
28882011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2889
750c33f7
LMI
2890 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2891 it's used from the C level.
2892
dd889327
LMI
2893 * process.c: Use the same condition for POLL_FOR_INPUT in both
2894 keyboard.c and process.c (bug#1858).
2895
87e86684
LM
28962011-07-09 Lawrence Mitchell <wence@gmx.li>
2897
2898 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2899 (Fgnutls_boot): Use it.
2900
64348f40
AS
29012011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2902
2903 * doc.c (Fsubstitute_command_keys): Revert last change.
2904
1d698799
LMI
29052011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2906
f863868c
LMI
2907 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2908 quotes the next character, and doesn't affect other longer
2909 sequences (bug#8935).
2910
1d698799
LMI
2911 * lread.c (syms_of_lread): Clarify that is isn't only
2912 `eval-buffer' and `eval-defun' that's affected by
2913 `lexical-binding' (bug#8460).
2914
aa4b6df6
EZ
29152011-07-15 Eli Zaretskii <eliz@gnu.org>
2916
2917 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2918 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2919
5d856da6
PE
29202011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2921
ad6042bb
PE
2922 Fix minor problems found by static checking.
2923 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2924 (elsz): Now a signed constant, not a size_t var. We prefer signed
2925 types to unsigned, to avoid integer comparison confusion. Without
2926 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2927 "cannot optimize loop, the loop counter may overflow", a symptom
2928 of the confusion.
f00bbb22 2929 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2930 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2931
6468f31c
LMI
29322011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2933
49080b10
LMI
2934 * search.c (Fre_search_backward): Mention `case-fold-search' in
2935 all the re_search_* functions (bug#8138).
2936
6468f31c
LMI
2937 * keyboard.c (Fopen_dribble_file): Document when the file is
2938 closed (bug#8056).
2939
c965adc5
EZ
29402011-07-14 Eli Zaretskii <eliz@gnu.org>
2941
df9733bf
EZ
2942 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2943 bidi_cache_idx.
2944
0bb23927
EZ
2945 Support bidi reordering of display and overlay strings.
2946 * xdisp.c (compute_display_string_pos)
2947 (compute_display_string_end): Accept additional argument STRING.
2948 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2949 (reseat_to_string): Initialize bidi_it->string.s and
2950 bidi_it->string.schars.
2951 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2952 NULL (avoids a crash in bidi_paragraph_init).
2953 Initialize itb.string.lstring.
0bb23927
EZ
2954 (init_iterator): Call bidi_init_it only of a valid
2955 buffer position was specified. Initialize paragraph_embedding to
2956 L2R.
2957 (reseat_to_string): Initialize the bidi iterator.
2958 (display_string): If we need to ignore text properties of
2959 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2960 original value of -1 will not work with bidi.)
2961 (compute_display_string_pos): First arg is now struct
2962 `text_pos *'; all callers changed. Support display properties on
2963 Lisp strings.
2964 (compute_display_string_end): Support display properties on Lisp
2965 strings.
2966 (init_iterator, reseat_1, reseat_to_string): Initialize the
2967 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2968 when iterating on a string not from display properties).
640c8776
SM
2969 (compute_display_string_pos, compute_display_string_end):
2970 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2971 arrow keys.
2972 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2973 base_level_stop; instead, set base_level_stop to BEGV.
2974 Fixes crashes in vertical-motion.
0bb23927
EZ
2975 (next_element_from_buffer): Improve commentary for when
2976 the iterator is before prev_stop.
2977 (init_iterator): Initialize bidi_p from the default value of
2978 bidi-display-reordering, not from buffer-local value. Use the
2979 buffer-local value only if initializing for buffer iteration.
2980 (handle_invisible_prop): Support invisible properties on strings
2981 that are being bidi-reordered.
2982 (set_iterator_to_next): Support bidi reordering of C strings and
2983 Lisp strings.
2984 (next_element_from_string): Support bidi reordering of Lisp
2985 strings.
2986 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2987 (display_string): Support display of R2L glyph rows.
2988 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2989 (init_iterator): Don't initialize it->bidi_p for strings
2990 here.
2991 (reseat_to_string): Initialize it->bidi_p for strings here.
2992 (next_element_from_string, next_element_from_c_string)
2993 (next_element_from_buffer): Add xassert's for correspondence
2994 between IT's object being iterated and it->bidi_it.string
2995 structure.
2996 (face_before_or_after_it_pos): Support bidi iteration.
2997 (next_element_from_c_string): Handle the case of the first string
2998 character that is not the first one in the visual order.
2999 (get_visually_first_element): New function, refactored from common
3000 parts of next_element_from_buffer, next_element_from_string, and
3001 next_element_from_c_string.
3002 (tool_bar_lines_needed, redisplay_tool_bar)
3003 (display_menu_bar): Force left-to-right direction. Add a FIXME
3004 comment for making that be controlled by a user option.
3005 (push_it, pop_it): Save and restore the state of the
3006 bidi iterator. Save and restore the bidi_p flag.
3007 (pop_it): Iterate out of display property for string iteration as
3008 well.
3009 (iterate_out_of_display_property): Support iteration over strings.
3010 (handle_single_display_spec): Set up it->bidi_it for iteration
3011 over a display string, and call bidi_init_it.
3012 (handle_single_display_spec, next_overlay_string)
3013 (get_overlay_strings_1, push_display_prop): Set up the bidi
3014 iterator for displaying display or overlay strings.
3015 (forward_to_next_line_start): Don't use the shortcut if
3016 bidi-iterating.
3017 (back_to_previous_visible_line_start): If handle_display_prop
3018 pushed the iterator stack, restore the internal state of the bidi
3019 iterator by calling bidi_pop_it same number of times.
3020 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3021 and we are bidi-iterating, don't decrement the iterator position;
3022 instead, set the first_elt flag in the bidi iterator, to produce
3023 the same effect.
3024 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3025 (push_display_prop): xassert that we are iterating a buffer.
3026 (push_it, pop_it): Save and restore paragraph_embedding member.
3027 (handle_single_display_spec, next_overlay_string)
3028 (get_overlay_strings_1, reseat_1, reseat_to_string)
3029 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3030 correctly. Don't assume unibyte strings are not bidi-reordered.
3031 (compute_display_string_pos)
3032 (compute_display_string_end): Fix handling the case of C string.
3033 (push_it, pop_it): Save and restore from_disp_prop_p.
3034 (handle_single_display_spec, push_display_prop): Set the
3035 from_disp_prop_p flag.
3036 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3037 (pop_it): Call iterate_out_of_display_property only if we are
3038 popping after iteration over a string that came from a display
3039 property. Fix a typo in popping stretch info. Add an assertion
3040 for verifying that the iterator position is in sync with the bidi
3041 iterator.
3042 (handle_single_display_spec, get_overlay_strings_1)
3043 (push_display_prop): Fix initialization of paragraph direction for
3044 string when that of the parent object is not yet determined.
3045 (reseat_1): Call bidi_init_it to resync the bidi
3046 iterator with IT's position. (Bug#7616)
3047 (find_row_edges): If ROW->start.pos gives position
3048 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3049 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3050 Reset the from_disp_prop_p flag.
3051 (SAVE_IT, RESTORE_IT): New macros.
3052 (pos_visible_p, face_before_or_after_it_pos)
3053 (back_to_previous_visible_line_start)
3054 (move_it_in_display_line_to, move_it_in_display_line)
3055 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3056 (try_scrolling, redisplay_window, display_line): Use them when
3057 saving a temporary copy of the iterator and restoring it back.
3058 (back_to_previous_visible_line_start, reseat_1)
3059 (init_iterator): Empty the bidi cache "stack".
3060 (move_it_in_display_line_to): If iterator ended up at
3061 EOL, but we never saw any buffer positions smaller than
3062 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3063 motion in bidi-reordered lines.
3064 (move_it_in_display_line_to): Record prev_method and prev_pos
3065 immediately before the call to set_iterator_to_next. Fixes cursor
3066 motion in bidi-reordered lines with stretch glyphs and strings
3067 displayed in margins. (Bug#8133) (Bug#8867)
3068 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3069 TO_CHARPOS.
640c8776
SM
3070 (pos_visible_p): Support positions in bidi-reordered lines.
3071 Save and restore bidi cache.
0bb23927
EZ
3072
3073 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3074 (bidi_paragraph_info): Delete unused struct.
3075 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3076 (bidi_cache_start): New variable.
3077 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3078 to zero.
3079 (bidi_cache_fetch_state, bidi_cache_search)
3080 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3081 (bidi_cache_find, bidi_peek_at_next_level)
3082 (bidi_level_of_next_char, bidi_find_other_level_edge)
3083 (bidi_move_to_visually_next): Compare cache index with
3084 bidi_cache_start rather than with zero.
3085 (bidi_fetch_char): Accept new argument STRING; all callers
3086 changed. Support iteration over a string. Support strings with
3087 display properties. Support unibyte strings. Fix the type of
3088 `len' according to what STRING_CHAR_AND_LENGTH expects.
3089 (bidi_paragraph_init, bidi_resolve_explicit_1)
3090 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3091 (bidi_level_of_next_char, bidi_move_to_visually_next):
3092 Support iteration over a string.
0bb23927
EZ
3093 (bidi_set_sor_type, bidi_resolve_explicit_1)
3094 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3095 can now be zero (for strings); special values 0 and -1 were
3096 changed to -1 and -2, respectively.
3097 (bidi_char_at_pos): New function.
3098 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3099 Call it instead of FETCH_MULTIBYTE_CHAR.
3100 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3101 initialized to valid values.
3102 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3103 values.
3104 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3105 the test for valid cached positions. Fix the logic for looking up
3106 the sentinel state in the cache. GCPRO the Lisp string we are
3107 iterating.
3108 (bidi_push_it, bidi_pop_it): New functions.
3109 (bidi_initialize): Initialize the bidi cache start stack pointer.
3110 (bidi_cache_ensure_space): New function, refactored from part of
3111 bidi_cache_iterator_state. Don't assume the required size is just
3112 one BIDI_CACHE_CHUNK away.
3113 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3114 (bidi_count_bytes, bidi_char_at_pos): New functions.
3115 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3116 always valid if bidi_cache_idx is valid.
3117 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3118 is valid if it's going to be used.
3119 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3120 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3121 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3122 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3123 (bidi_find_other_level_edge, bidi_cache_start_stack):
3124 All variables related to cache indices are now EMACS_INT.
c965adc5 3125
0bb23927
EZ
3126 * dispextern.h (struct bidi_string_data): New structure.
3127 (struct bidi_it): New member `string'. Make flag members be 1-bit
3128 fields, and put them last in the struct.
640c8776
SM
3129 (compute_display_string_pos, compute_display_string_end):
3130 Update prototypes.
0bb23927
EZ
3131 (bidi_push_it, bidi_pop_it): Add prototypes.
3132 (struct iterator_stack_entry): New members bidi_p,
3133 paragraph_embedding, and from_disp_prop_p.
3134 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3135 (bidi_shelve_cache, bidi_unshelve_cache):
3136 Declare prototypes.
0bb23927
EZ
3137
3138 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3139 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3140 and vector-like objects.
3141
3142 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3143 cache around display iteration.
3144
3145 * window.c (Fwindow_end, window_scroll_pixel_based)
3146 (displayed_window_lines, Frecenter): Save and restore the bidi
3147 cache around display iteration.
3148
3bbd2265
LMI
31492011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3150
3151 * editfns.c (Fdelete_region): Clarify the use of the named
3152 parameters (bug#6788).
3153
adc47434
MR
31542011-07-14 Martin Rudalics <rudalics@gmx.at>
3155
3156 * indent.c (Fvertical_motion): Set and restore w->pointm when
3157 saving and restoring the window's buffer (Bug#9006).
3158
837c31f8
LMI
31592011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3160
3161 * editfns.c (Fstring_to_char): Clarify just what is returned
3162 (bug#6576). Text by Eli Zaretskii.
3163
ac389d0c
JB
31642011-07-13 Juanma Barranquero <lekktu@gmail.com>
3165
3166 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3167
0be0ce47
EZ
31682011-07-13 Eli Zaretskii <eliz@gnu.org>
3169
3170 * buffer.c (mmap_find): Fix a typo.
3171
cd18e7e3
JB
31722011-07-13 Johan Bockgård <bojohan@gnu.org>
3173
3174 Fix execution of x selection hooks.
3175 * xselect.c (Qx_lost_selection_functions)
3176 (Qx_sent_selection_functions): New vars.
3177 (syms_of_xselect): DEFSYM them.
3178 (x_handle_selection_request): Pass Qx_sent_selection_functions
3179 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3180 (x_handle_selection_clear,x_clear_frame_selections):
3181 Pass Qx_lost_selection_functions rather than
3182 Vx_lost_selection_functions to Frun_hook_with_args.
3183
47ea7f44
PE
31842011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3185
ac389d0c 3186 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3187 The old code sometimes used this field without initializing it.
3188
47ea7f44
PE
3189 * alloc.c (gc_sweep): Don't read past end of array.
3190 In theory, the old code could also have corrupted Emacs internals,
3191 though it'd be very unlikely.
3192
bc985c87
AS
31932011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3194
3195 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3196 argument. (Bug#4026)
bc985c87 3197
0cf34688
LMI
31982011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3199
b3dadd76
LMI
3200 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3201 key" (bug#4257).
3202
0cf34688
LMI
3203 * window.c (Fset_window_start): Doc fix (bug#4199).
3204 (Fset_window_hscroll): Ditto.
3205
270768cd
PE
32062011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3207
077e3dda 3208 Fix minor new problems caught by GCC 4.6.1.
270768cd 3209 * term.c (init_tty): Remove unused local.
490011a6 3210 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3211 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3212 not used otherwise.
270768cd 3213
b1f58454
CY
32142011-07-12 Chong Yidong <cyd@stupidchicken.com>
3215
3216 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3217
22b9578d
LMI
32182011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3219
6e70ab07
LMI
3220 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3221 are the mini-buffer and the echo area (bug#3320).
3222
22b9578d
LMI
3223 * term.c (init_tty): Remove support for supdup, c10 and perq
3224 terminals, which are no longer supported (bug#1482).
3225
8974cc9f
JB
32262011-07-10 Johan Bockgård <bojohan@gnu.org>
3227
3228 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3229
a560d974
JD
32302011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3231
3232 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3233 for non-popups (Bug#3642).
3234
1dae0f0a
AS
32352011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3236
268c2c36 3237 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3238 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3239 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3240 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3241 * data.c (fmod): Likewise.
3242 * dispnew.c (swap_glyphs_in_rows): Likewise.
3243 * emacs.c (memory_warning_signal): Likewise.
3244 * floatfns.c (float_error): Likewise.
3245 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3246 (otf_open, font_otf_capability, generate_otf_features)
3247 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3248 Likewise.
3249 * image.c (pbm_read_file): Likewise.
3250 * indent.c (string_display_width): Likewise.
3251 * intervals.c (check_for_interval, search_for_interval)
3252 (inc_interval_count, count_intervals, root_interval)
3253 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3254 * lread.c (defalias): Likewise.
268c2c36 3255 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3256 * regex.c (set_image_of_range_1, set_image_of_range)
3257 (regex_grow_registers): Likewise.
3258 * sysdep.c (strerror): Likewise.
3259 * termcap.c (valid_filename_p, tprint, main): Likewise.
3260 * tparam.c (main): Likewise.
3261 * unexhp9k800.c (run_time_remap, save_data_space)
3262 (update_file_ptrs, read_header, write_header, calculate_checksum)
3263 (copy_file, copy_rest, display_header): Likewise.
3264 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3265 Likewise.
3266 * xdisp.c (check_it): Likewise.
3267 * xfaces.c (register_color, unregister_color, unregister_colors):
3268 Likewise.
3269 * xfns.c (print_fontset_result): Likewise.
3270 * xrdb.c (member, fatal, main): Likewise.
3271
99033785
PE
32722011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3273
3274 Fix minor problems found by static checking (Bug#9031).
3275 * chartab.c (char_table_set_range, map_sub_char_table):
3276 Remove unused locals.
3277 (uniprop_table): Now static.
3278 * composite.c (_work_char): Remove unused static var.
3279
9cb2ac56
JB
32802011-07-09 Juanma Barranquero <lekktu@gmail.com>
3281
3282 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3283
f25661f0
JD
32842011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3285
3286 * gtkutil.c (qttip_cb): Remove code without function.
3287
8278c4fe
EZ
32882011-07-09 Eli Zaretskii <eliz@gnu.org>
3289
3290 * w32.c (pthread_sigmask): New stub.
3291
1692ae2d 32922011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3293
8a6ebd58 3294 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3295 sigprocmask is portable only for single-threaded applications, and
3296 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3297 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3298 (LIBES): Use it.
3299 * callproc.c (Fcall_process):
3300 * process.c (create_process):
3301 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3302 Use pthread_sigmask, not sigprocmask.
123403e4 3303
1b854618
JD
33042011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3305
3306 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3307 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3308 wrong (Bug#8591).
3309
3fe4b549
JD
33102011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3311
0ce7e563
JD
3312 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3313 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3314 (xg_hide_tooltip): Fix comment.
3315
3fe4b549
JD
3316 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3317 in registerServicesMenuSendTypes.
3318 (validRequestorForSendType): Don't check ns_return_types.
3319
3320 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3321 ns_return_type.
3322
5df75e47
JR
33232011-07-08 Jason Rumney <jasonr@gnu.org>
3324
22610910
JR
3325 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3326 SH_SHOW for hidden windows (Bug#5482).
3327
5df75e47
JR
3328 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3329 frame struct members of non-existent frames (Bug#6284).
3330
699c10bd
JD
33312011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3332
4393663b
JD
3333 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3334 variable firstTime not needed on OSX >= 10.6.
3335 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3336 >= 10.5. Use setKnobProportion, setDoubleValue.
3337
3338 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3339 (MAC_OS_X_VERSION_10_5): Define if not defined.
3340 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3341 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3342 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3343
3344 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3345 cString and lossyCString on OSX >= 10.4
3346
58179cce 3347 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3348 sizeToFit on OSX >= 10.2.
3349
3350 * nsimage.m (allocInitFromFile): Don't use deprecated method
3351 bestRepresentationForDevice on OSX >= 10.6.
3352
3353 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3354 to avoid warning.
3355
3356 * emacs.c: Declare unexec_init_emacs_zone.
3357
a63e0781
JD
3358 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3359
699c10bd
JD
3360 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3361
3362 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3363 on svcsMenu (Bug#8842).
3364
3365 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3366 ns_return_types.
3367 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3368
3369 * nsterm.m (QUTF8_STRING): Declare.
3370 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3371 (validRequestorForSendType): Return type is (id).
3372 Change indexOfObjectIdenticalTo to indexOfObject.
3373 Check if we have local selection before returning self (Bug#8842).
3374 (writeSelectionToPasteboard): Put local selection into paste board
3375 if we have a local selection (Bug#8842).
3376 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3377
3378 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3379 (ns_get_local_selection): Declare.
3380
54e10184
LMI
33812011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3382
9888ff71
LMI
3383 * keymap.c (describe_map_tree): Don't insert a double newline at
3384 the end of the buffer (bug#1169) and return whether we inserted
3385 something.
3386
54e10184
LMI
3387 * callint.c (Fcall_interactively): Change "reading args" to
3388 "providing args" to try to clarify what it does (bug#1010).
3389
15fa4783
KH
33902011-07-07 Kenichi Handa <handa@m17n.org>
3391
3392 * composite.c (composition_compute_stop_pos): Ignore a static
3393 composition starting before CHARPOS (Bug#8915).
3394
3395 * xdisp.c (handle_composition_prop): Likewise.
3396
a8815b00
EZ
33972011-07-07 Eli Zaretskii <eliz@gnu.org>
3398
3399 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3400 (Bug#9015)
3401
ef7b981d 34022011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3403
3404 * character.h (unicode_category_t): New enum type.
3405
3406 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3407 (Qchar_code_property_table): New variable.
3408 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3409 (UNIPROP_COMPRESSED_FORM_P): New macros.
3410 (char_table_ascii): Uncompress the compressed values.
3411 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3412 Uncompress the compressed values.
ac389d0c 3413 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3414 (char_table_ref_and_range): Uncompress the compressed values.
3415 (sub_char_table_set): New arg is_uniprop. Callers changed.
3416 Uncompress the compressed values.
3417 (sub_char_table_set_range): Args changed. Callers changed.
3418 (char_table_set_range): Adjuted for the above change.
3419 (map_sub_char_table): Delete args default_val and parent. Add arg
3420 top. Give decoded values to a Lisp function.
640c8776 3421 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3422 values to a Lisp function. Gcpro more variables.
3423 (uniprop_table_uncompress)
3424 (uniprop_decode_value_run_length): New functions.
3425 (uniprop_decoder, uniprop_decoder_count): New variables.
3426 (uniprop_get_decoder, uniprop_encode_value_character)
3427 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3428 New functions.
3429 (uniprop_encoder, uniprop_encoder_count): New variables.
3430 (uniprop_get_encoder, uniprop_table)
3431 (Funicode_property_table_internal, Fget_unicode_property_internal)
3432 (Fput_unicode_property_internal): New functions.
3433 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3434 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3435 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3436 char-code-property-alist.
3437
640c8776 3438 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3439 Vunicode_category_table.
3440
640c8776 3441 * font.c (font_range): Adjust for the change of
c805dec0
KH
3442 Vunicode_category_table.
3443
76b397fb
DN
34442011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3445
3446 * m/iris4d.h: Remove file, move contents ...
3447 * s/irix6-5.h: ... here.
3448
22b4128e
PE
34492011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3450
3451 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3452 * alloc.c (mark_buffer):
3453 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3454 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3455 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3456 This isn't true in general, and it's particularly not true
3457 if Emacs is configured with --with-wide-int.
3458 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3459 New macros, used in the buffer.c change.
3460
869795d6
JD
34612011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3462
3463 * xsettings.c: Use both GConf and GSettings if both are available.
3464 (store_config_changed_event): Add comment.
3465 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3466 (store_tool_bar_style_changed): New functions.
5e617bc2 3467 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3468 (struct xsettings): Move font inside HAVE_XFT.
3469 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3470 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3471 Move inside HAVE_XFT.
640c8776 3472 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3473 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3474 also.
3475 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3476 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3477 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3478 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3479 (parse_settings): Move check for font inside HAVE_XFT.
3480 (read_settings, apply_xft_settings): Add comment.
3481 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3482 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3483 call store_font_name_changed.
3484 (xft_settings_event): Add comment.
3485 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3486 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3487 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3488 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3489 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3490 (xsettings_get_system_font, xsettings_get_system_normal_font):
3491 Add comment.
869795d6 3492
d8ed26bd
PE
34932011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3494
3495 Random fixes. E.g., (random) never returned negative values.
3496 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3497 subseconds part to the entropy, as that's a bit more random.
3498 Prefer signed to unsigned, since the signedness doesn't matter and
3499 in general we prefer signed. When given a limit, use a
3500 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3501 latter isn't right if USE_2_TAGS_FOR_INTS.
3502 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3503 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3504
cabf1cac
SM
35052011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3506
3507 * textprop.c (text_property_stickiness):
3508 Obey Vtext_property_default_nonsticky.
3509 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3510 * w32fns.c (syms_of_w32fns):
3511 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3512
6e9b2be9
PE
35132011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3514
3515 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3516 This is more efficient than Ffile_directory_p and avoids a minor race.
3517
90186c68
LMI
35182011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3519
7c301272
LMI
3520 * buffer.c (Foverlay_put): Say what the return value is
3521 (bug#7835).
3522
c4f2d8d4
LMI
3523 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3524 is a directory before asking whether to use the file name
3525 (bug#7564).
ad637907
LMI
3526 (barf_or_query_if_file_exists): Make the "File is a directory"
3527 error be more correct.
c4f2d8d4 3528
90186c68
LMI
3529 * fns.c (Frequire): Remove the mention of the .gz files, since
3530 that's installation-specific, but keep the mention of
3531 `get-load-suffixes'.
3532
da64016e
PE
35332011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3534
3535 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3536 Report string overflow if the output is too long.
3537
7d47b580
JB
35382011-07-04 Juanma Barranquero <lekktu@gmail.com>
3539
a555cb87
JB
3540 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3541 (syms_of_gnutls): Remove duplicate DEFSYM for
3542 Qgnutls_bootprop_verify_hostname_error, an error for
3543 Qgnutls_bootprop_verify_error (which is no longer used).
3544
7d47b580
JB
3545 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3546 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3547 Also (re)move comments that are misplaced or no longer relevant.
3548
1e49bfab
LMI
35492011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3550
3551 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3552
1485f4c0
CY
35532011-07-03 Chong Yidong <cyd@stupidchicken.com>
3554
3555 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3556 and background color parameters if they have been changed.
3557
a9ab721e
LMI
35582011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3559
3560 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3561
cf7cff57
PE
35622011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3563
2e13213d
PE
3564 * xsettings.c (SYSTEM_FONT): Define only when used.
3565 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3566
cf7cff57
PE
3567 * keymap.c (access_keymap_1): Now static.
3568
7a8e04f7
CY
35692011-07-02 Chong Yidong <cyd@stupidchicken.com>
3570
3571 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3572 leave any prefix arg for the up event (Bug#1586).
3573
61352f62
LMI
35742011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3575
69bb1ef7
LMI
3576 * lread.c (syms_of_lread): Mention single symbols defined by
3577 `defvar' or `defconst' (bug#7154).
3578
61352f62 3579 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3580 (Frequire): Mention get-load-suffixes.
61352f62 3581
28545e04
MR
35822011-07-02 Martin Rudalics <rudalics@gmx.at>
3583
3584 * window.h (window): Remove clone_number slot.
3585 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3586 Remove.
3587 (make_parent_window, make_window, saved_window)
3588 (Fset_window_configuration, save_window_save): Don't deal with
3589 clone numbers.
3590 * buffer.c (Qclone_number): Remove declaration.
3591 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3592
3349e122
SM
35932011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3594
3595 Add multiple inheritance to keymaps.
3596 * keymap.c (Fmake_composed_keymap): New function.
3597 (Fset_keymap_parent): Simplify.
3598 (fix_submap_inheritance): Remove.
3599 (access_keymap_1): New function extracted from access_keymap to handle
3600 embedded parents and handle lists of maps.
3601 (access_keymap): Use it.
3602 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3603 (Fcopy_keymap): Handle embedded parents.
3604 (Fcommand_remapping, define_as_prefix): Simplify.
3605 (Fkey_binding): Simplify.
3606 (syms_of_keymap): Move minibuffer-local-completion-map,
3607 minibuffer-local-filename-completion-map,
3608 minibuffer-local-must-match-map, and
3609 minibuffer-local-filename-must-match-map to Elisp.
3610 (syms_of_keymap): Defsubr make-composed-keymap.
3611 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3612 (parse_menu_item): Trivial simplification.
3613
3279eb87
GM
36142011-07-01 Glenn Morris <rgm@gnu.org>
3615
3616 * Makefile.in (SETTINGS_LIBS): Fix typo.
3617
4550efdf
KI
36182011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3619
3620 * coding.c (Fencode_coding_string): Record the last coding system
3621 used, as the function doc string says (bug#8738).
3622
0949d2b6
JD
36232011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3624
3625 * xsettings.c (store_monospaced_changed): Take new font as arg and
3626 check for change against current_mono_font.
3627 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3628 (emacs_settings_constructor, emacs_settings_get_property)
3629 (emacs_settings_set_property, emacs_settings_class_init)
3630 (emacs_settings_init, gsettings_obj): Remove.
3631 (something_changedCB): New function for HAVE_GSETTINGS.
3632 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3633 with value as argument.
3634 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3635 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3636 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3637 "changed".
3638
3639 * xgselect.c: Add defined (HAVE_GSETTINGS).
3640 (xgselect_initialize): Ditto.
3641
3642 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3643 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3644 xg_select.
3645
bbc6b304
PE
36462011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3647
3648 * eval.c (struct backtrace): Simplify and port the data structure.
3649 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3650 signed bit field, as this assumption is not portable and it makes
3651 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3652 "char debug_on_exit : 1" as this is not portable either; instead,
3653 use the portable "unsigned int debug_on_exit : 1". Remove unused
3654 member evalargs. Remove obsolete comments about cc bombing out.
3655
9851bfc5
JD
36562011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3657
51bb811f 3658 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3659 Let HAVE_GSETTINGS override HAVE_GCONF.
3660 (store_monospaced_changed): New function.
3661 (EMACS_SETTINGS): A new type derived from GObject to handle
3662 GSettings notifications.
3663 (emacs_settings_constructor, emacs_settings_get_property)
3664 (emacs_settings_set_property, emacs_settings_class_init):
3665 New functions.
3666 (gsettings_client, gsettings_obj): New variables.
3667 (GSETTINGS_SCHEMA): New define.
3668 (something_changedCB): Call store_monospaced_changed.
3669 (init_gsettings): New function.
3670 (xsettings_initialize): Call init_gsettings.
3671 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3672 to NULL.
3673
640c8776 3674 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3675 GCONF_CFLAGS/LIBS.
3676
5386012d
MR
36772011-06-29 Martin Rudalics <rudalics@gmx.at>
3678
3679 * window.c (resize_root_window, grow_mini_window)
3680 (shrink_mini_window): Rename Qresize_root_window to
3681 Qwindow_resize_root_window and Qresize_root_window_vertically to
3682 Qwindow_resize_root_window_vertically.
3683
f13e0b08
PE
36842011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3685
3686 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3687
94515237
JB
36882011-06-27 Juanma Barranquero <lekktu@gmail.com>
3689
3690 * makefile.w32-in: Redesign dependencies so they reflect more
3691 clearly which files are directly included by each source file,
3692 and not through other includes.
3693
e43b6e43
MR
36942011-06-27 Martin Rudalics <rudalics@gmx.at>
3695
3696 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3697 (sort_overlays, overlay_strings): When an overlay's clone number
3698 matches the window's clone number process the overlay even if
3699 the overlay's window property doesn't match the current window.
3700
d68443dc
MR
3701 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3702 (Fwindow_hchild): Rename to Fwindow_left_child.
3703 (Fwindow_next): Rename to Fwindow_next_sibling.
3704 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3705 (resize_window_check): Rename to window_resize_check.
3706 (resize_window_apply): Rename to window_resize_apply.
3707 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3708 (Fdelete_other_windows_internal, resize_frame_windows)
3709 (Fsplit_window_internal, Fdelete_window_internal)
3710 (grow_mini_window, shrink_mini_window)
3711 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3712
c7e73be5
JD
37132011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3714
3715 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3716 (emacs_fixed_set_min_size): Remove.
3717 (emacs_fixed_new): Take frame as argument.
3718
3719 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3720 (_EmacsFixedPrivate): Remove minwidth/height.
3721 Add struct frame *f.
3722 (emacs_fixed_init): Initialize priv->f.
3723 (get_parent_class, emacs_fixed_set_min_size): Remove.
3724 (emacs_fixed_new): Set priv->f to argument.
3725 (emacs_fixed_get_preferred_width)
3726 (emacs_fixed_get_preferred_height): Use min_width/height from
3727 frames size_hint to set minimum and natural (Bug#8919).
3728 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3729 and use min_width/height from frames size_hint to set
3730 min_width/height (Bug#8919).
3731
3732 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3733 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3734 Fix indentation.
c7e73be5 3735
cf99dcf8
EZ
37362011-06-26 Eli Zaretskii <eliz@gnu.org>
3737
3738 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3739 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3740 called at ZV.
3741
029529ac
CY
37422011-06-26 Chong Yidong <cyd@stupidchicken.com>
3743
3744 * process.c (wait_reading_process_output): Bypass select if
3745 waiting for a cell while ignoring keyboard input, and input is
3746 pending. Suggested by Jan Djärv (Bug#8869).
3747
7a7ef429
PE
37482011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3749
3750 Use gnulib's dup2 module instead of rolling our own.
3751 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3752
11fdef7d 37532011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3754
3755 * dispnew.c (scrolling_window): Before scrolling, turn off a
3756 mouse-highlight in the window being scrolled.
3757
cd3520a4
JB
37582011-06-24 Juanma Barranquero <lekktu@gmail.com>
3759
3760 Move DEFSYM to lisp.h and use everywhere.
3761
3762 * character.h (DEFSYM): Move declaration...
3763 * lisp.h (DEFSYM): ...here.
3764
3765 * gnutls.c:
3766 * minibuf.c:
3767 * w32menu.c:
3768 * w32proc.c:
3769 * w32select.c: Don't include character.h.
3770
3771 * alloc.c (syms_of_alloc):
3772 * buffer.c (syms_of_buffer):
3773 * bytecode.c (syms_of_bytecode):
3774 * callint.c (syms_of_callint):
3775 * casefiddle.c (syms_of_casefiddle):
3776 * casetab.c (init_casetab_once):
3777 * category.c (init_category_once, syms_of_category):
3778 * ccl.c (syms_of_ccl):
3779 * cmds.c (syms_of_cmds):
3780 * composite.c (syms_of_composite):
3781 * dbusbind.c (syms_of_dbusbind):
3782 * dired.c (syms_of_dired):
3783 * dispnew.c (syms_of_display):
3784 * doc.c (syms_of_doc):
3785 * editfns.c (syms_of_editfns):
3786 * emacs.c (syms_of_emacs):
3787 * eval.c (syms_of_eval):
3788 * fileio.c (syms_of_fileio):
3789 * fns.c (syms_of_fns):
3790 * frame.c (syms_of_frame):
3791 * fringe.c (syms_of_fringe):
3792 * insdel.c (syms_of_insdel):
3793 * keymap.c (syms_of_keymap):
3794 * lread.c (init_obarray, syms_of_lread):
3795 * macros.c (syms_of_macros):
3796 * msdos.c (syms_of_msdos):
3797 * print.c (syms_of_print):
3798 * process.c (syms_of_process):
3799 * search.c (syms_of_search):
3800 * sound.c (syms_of_sound):
3801 * syntax.c (init_syntax_once, syms_of_syntax):
3802 * terminal.c (syms_of_terminal):
3803 * textprop.c (syms_of_textprop):
3804 * undo.c (syms_of_undo):
3805 * w32.c (globals_of_w32):
3806 * window.c (syms_of_window):
3807 * xdisp.c (syms_of_xdisp):
3808 * xfaces.c (syms_of_xfaces):
3809 * xfns.c (syms_of_xfns):
3810 * xmenu.c (syms_of_xmenu):
3811 * xsettings.c (syms_of_xsettings):
3812 * xterm.c (syms_of_xterm): Use DEFSYM.
3813
4228cf16
TZ
38142011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3815
cd3520a4 3816 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3817
7fcccf1e
PE
38182011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3819
7efb4e0e
PE
3820 Integer and buffer overflow fixes (Bug#8873).
3821
ff5844ad
PE
3822 * print.c (printchar, strout): Check for string overflow.
3823 (PRINTPREPARE, printchar, strout):
3824 Don't set size unless allocation succeeds.
3825
90532f02
PE
3826 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3827 for sizes. Check for string overflow more accurately.
3828 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3829
6d84508d
PE
3830 * macros.c: Integer and buffer overflow fixes.
3831 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3832 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3833 Use ptrdiff_t, not int, for sizes.
3834 Don't increment bufsize until after realloc succeeds.
3835 Check for size-calculation overflow.
3836 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3837
437b2cb4
PE
3838 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3839
8b9ac8b4
PE
3840 * lread.c: Integer overflow fixes.
3841 (read_integer): Radix is now EMACS_INT, not int,
3842 to improve quality of diagnostics for out-of-range radices.
3843 Calculate buffer size correctly for out-of-range radices.
3844 (read1): Check for integer overflow in radices, and in
3845 read-circle numbers.
82cb60d3
PE
3846 (read_escape): Avoid int overflow.
3847 (Fload, openp, read_buffer_size, read1)
3848 (substitute_object_recurse, read_vector, read_list, map_obarray):
3849 Use ptrdiff_t, not int, for sizes.
3850 (read1): Use EMACS_INT, not int, for sizes.
20270765 3851 Check for size overflow.
8b9ac8b4 3852
7fcccf1e
PE
3853 * image.c (cache_image): Check for size arithmetic overflow.
3854
bfbbd7e7
PE
3855 * lread.c: Integer overflow issues.
3856 (saved_doc_string_size, saved_doc_string_length)
3857 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3858 Now ptrdiff_t, not int.
3859 (read1): Don't assume doc string length fits in int. Check for
3860 out-of-range doc string lengths.
3861 (read_list): Don't assume file position fits in int.
39019e54 3862 (read_escape): Check for hex character overflow.
bfbbd7e7 3863
4e323265
LL
38642011-06-22 Leo Liu <sdl.web@gmail.com>
3865
3866 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3867 Move to minibuffer.el.
3868
85fece3e
PE
38692011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3870
20b84ce9 3871 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3872 The following patches are for when GLYPH_DEBUG && !XASSERT.
3873 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3874 * dispnew.c (flush_stdout):
3875 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3876 Mark as externally visible.
3877 * dispnew.c (check_window_matrix_pointers): Now static.
3878 * dispnew.c (window_to_frame_vpos):
3879 * xfns.c (unwind_create_frame):
3880 * xterm.c (x_check_font): Remove unused local.
3881 * scroll.c (CHECK_BOUNDS):
3882 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3883 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3884 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3885 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3886 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3887 Now static.
3888 (debug_method_add): Use va_list and vsprintf rather than relying
3889 on undefined behavior with wrong number of arguments.
3890 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3891 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3892 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3893 since we're not interested in debugging glyphs with old libraries.
3894 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3895 GCC 4.6.0's static checking.
3896
0766b489
PE
38972011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3898
31fd4b32
PE
3899 Integer overflow and signedness fixes (Bug#8873).
3900 A few related buffer overrun fixes, too.
3901
b79e8648
PE
3902 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3903
0766b489
PE
3904 * dispextern.h (struct face.stipple):
3905 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3906 (x_bitmap_mask, x_allocate_bitmap_record)
3907 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3908 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3909 (x_create_bitmap_from_xpm_data):
3910 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3911 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3912 (.bitmaps_last):
3913 * xfaces.c (load_pixmap):
3914 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3915 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3916 (.bitmaps_last, struct x_output.icon_bitmap):
3917 Use ptrdiff_t, not int, for bitmap indexes.
3918 (x_allocate_bitmap_record): Check for size overflow.
3919 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3920
b081724f
PE
3921 Use ptrdiff_t, not int, for overlay counts.
3922 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3923 * editfns.c (overlays_around, get_pos_property):
3924 * textprop.c (get_char_property_and_overlay):
3925 * xdisp.c (next_overlay_change, note_mouse_highlight):
3926 * xfaces.c (face_at_buffer_position):
21514da7
PE
3927 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3928 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3929 (Fnext_overlay_change, Fprevious_overlay_change)
3930 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3931 Use ptrdiff_t, not int, for sizes.
21514da7 3932 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3933
3de73e5e
PE
3934 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3935
2606c57b
PE
3936 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3937 (x_session_initialize): Do not assume string length fits in int.
3938
aaafe47a
PE
3939 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3940 This is unlikely, but can occur if DPI is outlandish.
3941
2674ddc8 3942 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3943 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3944
28154962
PE
3945 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3946 * xrdb.c (magic_file_p, search_magic_path):
3947 Omit last arg SUFFIX; it was always 0. All callers changed.
3948 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3949
7de51af5
PE
3950 * xfont.c (xfont_match): Avoid need for strlen.
3951
25ed6cc3
PE
3952 * xfns.c: Don't assume strlen fits in int.
3953 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3954
4eab31dd
PE
3955 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3956 not unsigned long, as we prefer signed integers. All callers changed.
3957 Detect integer overflow in repeat count.
3958 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3959 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3960
171e2a58
PE
3961 * termcap.c: Don't assume sizes fit in int and never overflow.
3962 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3963 (gobble_line): Check for size-calculation overflow.
3964
ad39faca 3965 * minibuf.c (Fread_buffer):
6e5bb2dc 3966 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3967 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3968 Don't assume string length fits in int.
3969
52c61c22 3970 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3971 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3972
b5b8c9e5
PE
3973 * font.c: Don't assume string length fits in int.
3974 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3975 Use ptrdiff_t, not int.
ccd6111c
PE
3976 (font_intern_prop): Don't assume string length fits in int.
3977 Don't assume integer property fits in fixnum.
3978 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3979
882f0d81 3980 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3981 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3982 Reformulate so as not to need the command string.
3983 Invoke gzip -cd rather than gunzip, as it's more portable.
3984 (lock_info_type, lock_file_1, lock_file):
3985 Don't assume pid_t and time_t fit in unsigned long.
3986 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3987 (current_lock_owner): Prefer signed type for sizes.
3988 Use memcpy, not strncpy, where memcpy is what is really wanted.
3989 Don't assume (via atoi) that time_t and pid_t fit in int.
3990 Check for time_t and/or pid_t out of range, e.g., via a network share.
3991 Don't alloca where an auto var works fine.
3992
93f4cf88
PE
3993 * fileio.c: Fix some integer overflow issues.
3994 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3995 Don't assume string length fits in int.
3996 (directory_file_name): Don't assume string length fits in long.
3997 (make_temp_name): Don't assume pid fits in int, or that its print
3998 length is less than 20.
3999
f3e92b69
PE
4000 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4001
1bfdaf10
PE
4002 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4003
35016e9a
PE
4004 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4005
3d1e65a1
PE
4006 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4007 We prefer signed integers, even for size calculations.
4008
0b963a93
PE
4009 * emacs.c: Don't assume string length fits in 'int'.
4010 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4011 (main): Don't invoke strlen when not needed.
4012
573f4b54
PE
4013 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4014 (XD_DEBUG_MESSAGE): Don't waste a byte.
4015
989f33ba
PE
4016 * callproc.c (getenv_internal_1, getenv_internal)
4017 (Fgetenv_internal):
965d34eb
PE
4018 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4019
e4d29b33
PE
4020 * lread.c (invalid_syntax): Omit length argument.
4021 All uses changed. This doesn't fix a bug, but it simplifies the
4022 code away from its former Hollerith-constant appearance, and it's
4023 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4024 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4025
eb49b136
PE
4026 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4027 This didn't break anything, but it didn't help either.
4028 It's confusing to put a bogus integer in a place where the actual
4029 value does not matter.
9f62aeb1 4030 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4031 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4032
15375a22
PE
4033 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4034 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4035 implementation.
b61cc01c
PE
4036 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4037 We prefer signed types, and the value cannot exceed the EMACS_INT
4038 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4039 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4040 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4041 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4042
53b2623d
PE
4043 * indent.c (sane_tab_width): New function.
4044 (current_column, scan_for_column, Findent_to, position_indentation)
4045 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4046 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4047
51cab52b 4048 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4049
f2ed8a70
PE
4050 * lisp.h (lint_assume): New macro.
4051 * composite.c (composition_gstring_put_cache):
4052 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4053
abe80cc6
PE
4054 * editfns.c, insdel.c:
4055 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4056
b02c740e
PE
4057 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4058
ebc96716
PE
4059 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4060
b4e50fa0 4061 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4062 Use much-faster test for byte-length change.
311d5d7c 4063 Don't assume string byte-length fits in 'int'.
a4cf38e4 4064 Check that character arg fits in 'int'.
85461888 4065 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4066
c0c1ee9f
PE
4067 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4068
a498d7f4
PE
4069 * fns.c (concat): Catch string overflow earlier.
4070 Do not rely on integer wraparound.
4071
51cab52b
PE
4072 * dispextern.h (struct it.overlay_strings_charpos)
4073 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4074 * xdisp.c (forward_to_next_line_start)
4075 (back_to_previous_visible_line_start)
4076 (reseat_at_next_visible_line_start, next_element_from_buffer):
4077 Don't arbitrarily truncate the value of 'selective' to int.
4078
76031fad
PE
4079 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4080
5eb55db9
PE
4081 * composite.c: Don't truncate sizes to 'int'.
4082 (composition_gstring_p, composition_reseat_it)
4083 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4084 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4085 not EMACS_UINT, for indexes.
5eb55db9 4086
0703a717
PE
4087 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4088
d6202519
PE
4089 * buffer.c: Include <verify.h>.
4090 (struct sortvec.priority, struct sortstr.priority):
8961a454 4091 Now EMACS_INT, not int.
c20998a7 4092 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4093 (struct sortstr.size, record_overlay_string)
4094 (struct sortstrlist.size, struct sortlist.used):
4095 Don't truncate size to int.
4096 (record_overlay_string): Check for size-calculation overflow.
d6202519 4097 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4098
d5a19415
JM
40992011-06-22 Jim Meyering <meyering@redhat.com>
4100
029529ac 4101 Don't leak an XBM-image-sized buffer
d5a19415
JM
4102 * image.c (xbm_load): Free the image buffer after using it.
4103
a9041e6c
PE
41042011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4105
4106 Port to Sun C.
4107 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4108 that Sun C diagnosed.
4109 * fns.c (secure_hash): Fix pointer signedness issue.
4110 * intervals.c (static_offset_intervals): New function.
4111 (offset_intervals): Use it.
4112
7f3f739f
LL
41132011-06-21 Leo Liu <sdl.web@gmail.com>
4114
4115 * deps.mk (fns.o):
4116 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4117 sha512.h.
4118
4119 * fns.c (secure_hash): Rename from crypto_hash_function and change
4120 the first arg to accept symbols.
5b66d427 4121 (Fsecure_hash): New primitive.
7f3f739f
LL
4122 (syms_of_fns): New symbols.
4123
76147d94
DD
41242011-06-20 Deniz Dogan <deniz@dogan.se>
4125
4126 * process.c (Fset_process_buffer): Clarify return value in
4127 docstring.
4128
7d7d0045
CY
41292011-06-18 Chong Yidong <cyd@stupidchicken.com>
4130
4131 * dispnew.c (add_window_display_history): Use BVAR.
4132
4133 * xdisp.c (debug_method_add): Use BVAR.
4134 (check_window_end, dump_glyph_matrix, dump_glyph)
4135 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4136
4137 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4138 Likewise.
4139
4140 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4141 check till after the cache is created in init_frame_faces.
4142
ff2bc410
SM
41432011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4144
4145 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4146
28177add
PE
41472011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4148
dd3482fe
PE
4149 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4150 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4151 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4152
393d71f3 4153 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4154 * fileio.c (Finsert_file_contents):
4155 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4156 Remove the old (too-loose) buffer overflow checks.
4157 They weren't needed, since make_gap checks for buffer overflow.
4158 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4159 The old code merely checked for Emacs fixnum overflow, and relied
4160 on undefined (wraparound) behavior. The new code avoids undefined
4161 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4162
2e6813b0 4163 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4164 Tune. Don't use wider integers than needed. Don't use alloca.
4165 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4166
599a9e4f
PE
4167 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4168
99561444
PE
4169 * insdel.c, lisp.h (buffer_overflow): New function.
4170 (insert_from_buffer_1, replace_range, replace_range_2):
4171 * insdel.c (make_gap_larger):
4172 * editfns.c (Finsert_char):
4173 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4174
28177add
PE
4175 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4176
e69dafad
PE
41772011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4178
a7af7fde 4179 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 4180
b1c46f02
PE
4181 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4182 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4183
e69dafad
PE
4184 * fileio.c: Don't assume EMACS_INT fits in off_t.
4185 (emacs_lseek): New static function.
4186 (Finsert_file_contents, Fwrite_region): Use it.
4187 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4188
566684ea
PE
4189 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4190
e6966cd6
PE
4191 * fns.c: Don't overflow int when computing a list length.
4192 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4193 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4194 truncation on 64-bit hosts. Check for QUIT every
4195 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4196 faster and is responsive enough.
4197 (Flength): Report an error instead of overflowing an integer.
4198 (Fsafe_length): Return a float if the value is not representable
4199 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4200 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4201 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4202
dd0b0efb
PE
4203 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4204 (header_size, word_size): New constants.
4205 (allocate_vectorlike): Don't check size overflow here.
4206 (allocate_vector): Check it here instead, since this is the only
4207 caller of allocate_vectorlike that could cause overflow.
4208 Check that the new vector's length is representable as a fixnum.
4209
86fe5cfe
PE
4210 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4211 The previous code was bogus. For example, next_almost_prime (32)
4212 returned 39, which is undesirable as it is a multiple of 3; and
4213 next_almost_prime (24) returned 25, which is a multiple of 5 so
4214 why was the code bothering to check for multiples of 7?
4215
80e88859
PE
4216 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4217
4a2f0ad6
PE
4218 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4219
f66c7cf8
PE
4220 Variadic C functions now count arguments with ptrdiff_t.
4221 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4222 Back then I didn't know that the Emacs coding style prefers signed int.
4223 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4224 were being counted with int, which may truncate counts on 64-bit
4225 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4226 * lisp.h (struct Lisp_Subr.function.aMANY)
4227 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4228 Arg counts are now ptrdiff_t, not size_t.
4229 All variadic functions and their callers changed accordingly.
4230 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4231 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4232 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4233 * callint.c (Fcall_interactively): Check arg count for overflow,
4234 to avoid potential buffer overrun. Use signed char, not 'int',
4235 for 'varies' array, so that we needn't bother to check its size
4236 calculation for overflow.
4237 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4238 * eval.c (apply_lambda):
4239 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4240 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4241 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4242
a1759b76
PE
4243 * callint.c (Fcall_interactively): Don't use index var as event count.
4244
d96be9fc
PE
4245 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4246 * mem-limits.h (SIZE): Remove; no longer used.
4247
a690a978 4248 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4249
578c21e6
PE
4250 Remove unnecessary casts.
4251 * xterm.c (x_term_init):
4252 * xfns.c (x_set_border_pixel):
4253 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4254 These aren't needed now that we assume ANSI C.
4255
96f53c6c
PE
4256 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4257 It's more likely to cause problems (due to unsigned overflow)
4258 than to cure them.
4259
83c77d31
PE
4260 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4261
ee2079f1
PE
4262 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4263
6da65536
PE
4264 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4265
7147c4a4
PE
4266 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4267
193e32d9
PE
4268 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4269
e5533da6
PE
4270 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4271
9910e595
PE
4272 GLYPH_CODE_FACE returns EMACS_INT, not int.
4273 * dispextern.h (merge_faces):
4274 * xfaces.c (merge_faces):
01103c44
PE
4275 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4276 Don't assume EMACS_INT fits in int.
9910e595 4277
2638320e
PE
4278 * character.h (CHAR_VALID_P): Remove unused parameter.
4279 * fontset.c, lisp.h, xdisp.c: All uses changed.
4280
045eb8d9
PE
4281 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4282
c1f134b5
PE
4283 * fns.c (concat): Minor tuning based on overflow analysis.
4284 This doesn't fix any bugs. Use int to hold character, instead
4285 of constantly refetching from Emacs object. Use XFASTINT, not
4286 XINT, for value known to be a character. Don't bother comparing
4287 a single byte to 0400, as it's always less.
4288
395fcb93 4289 * floatfns.c (Fexpt):
327eeec8
PE
4290 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4291
abbd3d23
PE
4292 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4293 for characters.
4294
684a03ef
PE
4295 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4296
0fed43f3
PE
4297 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4298 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4299 incorrectly succeed when S was a string, because 4294967386 was
4300 truncated before it was used.
4301
8fd02eb7
PE
4302 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4303 Otherwise, an out-of-range integer could cause undefined behavior
4304 on a 64-bit host.
4305
f8c86b69
PE
4306 * composite.c: Use int, not EMACS_INT, for characters.
4307 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4308 EMACS_INT, for values that are known to be in character range.
4309 This doesn't fix any bugs but is the usual style inside Emacs and
4310 may generate better code on 32-bit machines.
4311
34206dd2
PE
4312 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4313 This is for reasons similar to the recent CHAR_STRING fix.
4314 * charset.c (Fencode_char): Check that character arg is actually
4315 a character. Pass an int to ENCODE_CHAR.
4316 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4317 wider than 'int', as a compile-time check to prevent future regressions
4318 in this area.
4319
c5958d4c 4320 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4321
4322 Make sure a 64-bit char is never passed to CHAR_STRING.
4323 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4324 by silently ignoring the top 32 bits, allowing some values
4325 that were far too large to be valid characters.
4326 * character.h: Include <verify.h>.
4327 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4328 arguments are no wider than unsigned, as a compile-time check
4329 to prevent future regressions in this area.
4330 * data.c (Faset):
01103c44 4331 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4332 (Fsubst_char_in_region):
4333 * fns.c (concat):
4334 * xdisp.c (decode_mode_spec_coding):
4335 Adjust to CHAR_STRING's new requirement.
4336 * editfns.c (Finsert_char, Fsubst_char_in_region):
4337 * fns.c (concat): Check that character args are actually
4338 characters. Without this test, these functions did the wrong
4339 thing with wildly out-of-range values on 64-bit hosts.
4340
d37ca623
PE
4341 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4342 These casts should not be needed on 32-bit hosts, either.
4343 * keyboard.c (read_char):
4344 * lread.c (Fload): Remove casts to unsigned.
4345
ea204efb
PE
4346 * lisp.h (UNSIGNED_CMP): New macro.
4347 This fixes comparison bugs on 64-bit hosts.
4348 (ASCII_CHAR_P): Use it.
4349 * casefiddle.c (casify_object):
01103c44 4350 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4351 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4352 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4353 * dispextern.h (FACE_FROM_ID):
4354 * keyboard.c (read_char): Use UNSIGNED_CMP.
4355
41cb286c
PE
4356 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4357 not to EMACS_INT, to avoid GCC warning.
4358
4a1b9832
PE
4359 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4360
55daad71
PE
4361 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4362 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4363 isn't needed on 32-bit machines.
8f95c75c 4364
01103c44
PE
4365 * buffer.c (Fgenerate_new_buffer_name):
4366 Use EMACS_INT for count, not int.
0ceccced 4367 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4368
4369 * data.c (Qcompiled_function): Now static.
4370
c6f072e7
PE
4371 * window.c (window_body_lines): Now static.
4372
20ce5912
PE
4373 * image.c (gif_load): Rename local to avoid shadowing.
4374
9c4c5f81
PE
4375 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4376 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4377 * alloc.c (make_save_value): Integer argument is now of type
4378 ptrdiff_t, not int.
4379 (mark_object): Use ptrdiff_t, not int.
4380 * lisp.h (pD): New macro.
4381 * print.c (print_object): Use it.
4382
c0c5c8ae
PE
4383 * alloc.c: Use EMACS_INT, not int, to count objects.
4384 (total_conses, total_markers, total_symbols, total_vector_size)
4385 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4386 (total_free_floats, total_floats, total_free_intervals)
4387 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4388 Now EMACS_INT, not int. All uses changed.
4389 (Fgarbage_collect): Compute overall total using a double, so that
4390 integer overflow is less likely to be a problem. Check for overflow
4391 when converting back to an integer.
5a25e253
PE
4392 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4393 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4394 These were 'int' variables that could overflow on 64-bit hosts;
4395 they were never used, so remove them instead of repairing them.
211a0b2a 4396 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4397 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4398 Previously, this ceilinged at INT_MAX, but that doesn't work on
4399 64-bit machines.
e46bb31a 4400 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4401
c78baabf 4402 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4403 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4404 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4405 when a (possibly-narrower) signed value would do just as well.
4406 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4407
c9d624c6
PE
4408 * alloc.c: Catch some string size overflows that we were missing.
4409 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4410 for convenience in STRING_BYTES_MAX.
4411 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4412 The definition here is exact; the one in lisp.h was approximate.
4413 (allocate_string_data): Check for string overflow. This catches
4414 some instances we weren't catching before. Also, it catches
4415 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4416 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4417 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4418
c9d624c6
PE
4419 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4420 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4421 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4422
353032ce
PE
4423 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4424
2bccce07
PE
4425 * alloc.c (Fmake_string): Check for out-of-range init.
4426
0ac30604
SM
44272011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4428
4429 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4430
c195f2de
JD
44312011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4432
4433 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4434 xg_get_default_scrollbar_width.
4435
4436 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4437 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4438 (style_changed_cb): Call update_theme_scrollbar_width and call
4439 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4440 all frames (Bug#8505).
4441 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4442 Call gtk_window_set_resizable if HAVE_GTK3.
4443 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4444 and height if HAVE_GTK3 (Bug#8505).
4445 (scroll_bar_width_for_theme): New variable.
4446 (update_theme_scrollbar_width): New function.
4447 (xg_get_default_scrollbar_width): Move code to
4448 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4449 (xg_initialize): Call update_theme_scrollbar_width.
4450
4451 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4452
4453 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4454
e10ac9f1
MR
44552011-06-12 Martin Rudalics <rudalics@gmx.at>
4456
4457 * frame.c (make_frame): Call other_buffer_safely instead of
4458 other_buffer.
4459
4460 * window.c (temp_output_buffer_show): Call display_buffer with
4461 second argument Vtemp_buffer_show_specifiers and reset latter
4462 immediately after the call.
4463 (Vtemp_buffer_show_specifiers): New variable.
4464 (auto_window_vscroll_p, next_screen_context_lines)
4465 (Vscroll_preserve_screen_position): Remove leading asterisks from
4466 doc-strings.
4467
2d3c217e 44682011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4469
7b7f97e8 4470 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4471 * buffer.c (Qclone_number): Remove for now, as it's unused.
4472 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4473 (record_buffer): Remove unused local.
4474 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4475 (set_frame_buffer_list): Remove; unused.
4476 * frame.h (other_visible_frames): Remove decl.
4477 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4478 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4479 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4480 if HAVE_GPM.
4481 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4482 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4483 Define only if HAVE_GPM.
4484 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4485 (update_hints_inhibit): Remove; never set. All uses removed.
4486 * widgetprv.h (emacsFrameClassRec): Remove decl.
4487 * window.c (delete_deletable_window): Now returns void, since it
4488 wasn't returning anything.
4489 (compare_window_configurations): Remove unused locals.
4490 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4491 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4492 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4493 the same widths as pointers. This follows up on the 2011-05-06 patch.
4494 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4495 * xterm.h: Likewise.
4496 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4497
1384b89e
JB
44982011-06-12 Juanma Barranquero <lekktu@gmail.com>
4499
4500 * makefile.w32-in: Update dependencies.
4501 (LISP_H): Add lib/intprops.h.
4502
1100a63c
CY
45032011-06-11 Chong Yidong <cyd@stupidchicken.com>
4504
4505 * image.c (gif_load): Add animation frame delay to the metadata.
4506 (syms_of_image): Use DEFSYM. New symbol `delay'.
4507
6198ccd0
MR
45082011-06-11 Martin Rudalics <rudalics@gmx.at>
4509
4510 * window.c (delete_deletable_window): Re-add.
4511 (Fset_window_configuration): Rewrite to handle dead buffers and
4512 consequently deletable windows.
4513 (window_tree, Fwindow_tree): Remove. Supply functionality in
4514 window.el.
4515 (compare_window_configurations): Simplify code.
4516
b6e3633c
AS
45172011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4518
1ab0dee5
AS
4519 * image.c (imagemagick_load_image): Fix type mismatch.
4520 (Fimagemagick_types): Likewise.
4521
b6e3633c
AS
4522 * window.h (replace_buffer_in_windows): Declare.
4523
9397e56f
MR
45242011-06-11 Martin Rudalics <rudalics@gmx.at>
4525
4526 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4527 Qclone_number. Remove external declaration of Qdelete_window.
4528 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4529 code.
640c8776
SM
4530 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4531 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4532 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4533 buffer list implementation.
4534 (other_buffer_safely): New function.
4535 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4536 calls to replace_buffer_in_windows and
4537 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4538 if allowed.
4539 (record_buffer): Inhibit quitting and rewrite using quittable
4540 functions. Run Qbuffer_list_update_hook if allowed.
4541 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4542 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4543 Move switch-to-buffer to window.el.
9397e56f
MR
4544 (bury-buffer): Move to window.el.
4545 (Vbuffer_list_update_hook): New variable.
4546
4547 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4548 section.
4549
4550 * window.h (resize_frame_windows): Move up in code.
4551 (Fwindow_frame): Remove EXFUN.
4552 (replace_buffer_in_all_windows): Remove prototype.
4553 (replace_buffer_in_windows_safely): Add prototype.
4554
4555 * window.c: Declare Qdelete_window static again. Move down
4556 declaration of select_count.
4557 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4558 (Fother_window): Move to window.el.
4559 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4560 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4561 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4562 window.el.
4563 (replace_buffer_in_windows): Implement by calling
4564 Qreplace_buffer_in_windows.
4565 (replace_buffer_in_all_windows): Remove with some functionality
4566 moved into replace_buffer_in_windows_safely.
4567 (replace_buffer_in_windows_safely): New function.
4568 (select_window_norecord, select_frame_norecord): Move in front
4569 of run_window_configuration_change_hook. Remove now obsolete
4570 declarations.
640c8776
SM
4571 (Fset_window_buffer): Rewrite doc-string.
4572 Call Qrecord_window_buffer.
9397e56f
MR
4573 (keys_of_window): Move binding for other-window to window.el.
4574
b50691aa
CY
45752011-06-11 Chong Yidong <cyd@stupidchicken.com>
4576
4577 * dispextern.h (struct image): Replace data member, whose int_val
4578 and ptr_val fields were not used by anything, with a single
4579 lisp_val object.
4580
4581 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4582 (gif_clear_image, gif_load, imagemagick_load_image)
4583 (gs_clear_image, gs_load): Callers changed.
4584
3f754b86
PE
45852011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4586
cca69397
PE
4587 * buffer.h: Include <time.h>, for time_t.
4588 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4589
109e28d0
PE
4590 Fix minor problems found by static checking.
4591
60737f02
PE
4592 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4593
4b66faf3
PE
4594 Make identifiers static if they are not used in other modules.
4595 * data.c (Qcompiled_function, Qframe, Qvector):
4596 * image.c (QimageMagick, Qsvg):
4597 * minibuf.c (Qmetadata):
4598 * window.c (resize_window_check, resize_root_window): Now static.
4599 * window.h (resize_window_check, resize_root_window): Remove decls.
4600
109e28d0
PE
4601 * window.c (window_deletion_count, delete_deletable_window):
4602 Remove; unused.
46a4ce9e
PE
4603 (window_body_lines): Now static.
4604 (Fdelete_other_windows_internal): Mark vars as initialized.
4605 Make sure 'resize_failed' is initialized.
4606 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4607 (resize_window_apply): Remove unused local.
4608 * window.h (delete_deletable_window): Remove decl.
4609
109e28d0 4610 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4611 (imagemagick_load_image): Fix pointer signedness problem by changing
4612 last arg from unsigned char * to char *. All uses changed.
4613 Also, fix a local for similar reasons.
4614 Remove unused locals. Remove locals to avoid shadowing.
4615 (fn_rsvg_handle_free): Remove; unused.
4616 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4617 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4618
3f754b86
PE
4619 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4620
2547adb1
CY
46212011-06-10 Chong Yidong <cyd@stupidchicken.com>
4622
4623 * image.c (gif_load): Fix omitted cast error introduced by
4624 2011-06-06 change.
4625
2c8e37d4
MR
46262011-06-10 Martin Rudalics <rudalics@gmx.at>
4627
4628 * window.h (resize_proportionally, orig_total_lines)
4629 (orig_top_line): Remove from window structure.
4630 (set_window_height, set_window_width, change_window_heights)
4631 (Fdelete_window): Remove prototypes.
4632 (resize_frame_windows): Remove duplicate declaration.
4633
440a42e3
EZ
46342011-06-10 Eli Zaretskii <eliz@gnu.org>
4635
4636 * window.h (resize_frame_windows, resize_window_check)
4637 (delete_deletable_window, resize_root_window)
4638 (resize_frame_windows): Declare prototypes.
4639
4640 * window.c (resize_window_apply): Make definition be "static" to
4641 match the prototype.
4642
562dd5e9
MR
46432011-06-10 Martin Rudalics <rudalics@gmx.at>
4644
4645 * window.c: Remove declarations of Qwindow_size_fixed,
4646 window_min_size_1, window_min_size_2, window_min_size,
4647 size_window, window_fixed_size_p, enlarge_window, delete_window.
4648 Remove static from declaration of Qdelete_window, it's
4649 temporarily needed by Fbury_buffer.
4650 (replace_window): Don't assign orig_top_line and
4651 orig_total_lines.
4652 (Fdelete_window, delete_window): Remove. Window deletion is
4653 handled by window.el.
640c8776
SM
4654 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4655 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4656 (Fdelete_other_windows): Remove. Deleting other windows is
4657 handled by window.el.
4658 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4659 handled in window.el.
4660 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4661 Window minimum sizes are handled in window.el.
4662 (shrink_windows, size_window, set_window_height)
4663 (set_window_width, change_window_heights, window_height)
4664 (window_width, CURBEG, CURSIZE, enlarge_window)
4665 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4666 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4667 handled in window.el.
4668 (make_dummy_parent): Rename to make_parent_window and give it a
4669 second argument horflag.
4670 (make_window): Don't set resize_proportionally any more.
4671 (Fsplit_window): Remove. Windows are split in window.el.
4672 (save_restore_action, save_restore_orig_size)
4673 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4674 Resize mini windows in window.el.
4675 (grow_mini_window, shrink_mini_window): Implement by calling
4676 Qresize_root_window_vertically, resize_window_check and
4677 resize_window_apply.
640c8776
SM
4678 (saved_window, Fset_window_configuration, save_window_save):
4679 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4680 resize_proportionally.
4681 (window_min_height, window_min_width): Move to window.el.
4682 (keys_of_window): Move bindings for delete-other-windows,
4683 split-window, delete-window and enlarge-window to window.el.
4684
4685 * buffer.c: Temporarily extern Qdelete_window.
4686 (Fbury_buffer): Temporarily call Qdelete_window instead of
4687 Fdelete_window (Fbury_buffer will move to window.el soon).
4688
4689 * frame.c (set_menu_bar_lines_1): Remove code handling
4690 orig_top_line and orig_total_lines.
4691
4692 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4693 set_window_height but set heights directly.
4694 (change_frame_size_1): Use resize_frame_windows.
4695
4696 * xdisp.c (init_xdisp): Don't use set_window_height but set
4697 heights directly.
4698
640c8776
SM
4699 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4700 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4701 run_window_configuration_change_hook.
4702
4703 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4704 instead of change_window_heights and run
4705 run_window_configuration_change_hook.
4706
1a13852e
MR
47072011-06-09 Martin Rudalics <rudalics@gmx.at>
4708
4709 * window.c (replace_window): Rename second argument REPLACEMENT to
4710 NEW. New third argument SETFLAG. Rewrite.
4711 (delete_window, make_dummy_parent): Call replace_window with
4712 third argument 1.
4713 (window_list_1): Move down in code.
4714 (run_window_configuration_change_hook): Move set_buffer part
4715 before select_frame_norecord part in order to unwind correctly.
4716 Rename count1 to count.
4717 (recombine_windows, delete_deletable_window, resize_root_window)
4718 (Fdelete_other_windows_internal)
4719 (Frun_window_configuration_change_hook, make_parent_window)
4720 (resize_window_check, resize_window_apply, Fresize_window_apply)
4721 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4722 (Fdelete_window_internal, Fresize_mini_window_internal):
4723 New functions.
1a13852e
MR
4724 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4725
f3d1777e
MR
47262011-06-08 Martin Rudalics <rudalics@gmx.at>
4727
496e208e
MR
4728 * window.h (window): Add some new members to window structure -
4729 normal_lines, normal_cols, new_total, new_normal, clone_number,
4730 splits, nest, prev_buffers, next_buffers.
4731 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4732 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4733
f3d1777e
MR
4734 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4735 Remove.
496e208e
MR
4736 (make_dummy_parent): Set new members of windows structure.
4737 (make_window): Move down in code. Handle new members of window
4738 structure.
4739 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4740 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4741 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4742 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4743 (Fset_window_next_buffers, Fset_window_clone_number):
4744 New functions.
496e208e
MR
4745 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4746 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4747 Doc-string fixes.
4748 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4749 Argument WINDOW can be now internal window too.
4750 (Fwindow_use_time): Move up in code.
4751 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4752 Rewrite doc-string.
4753 (Fset_window_configuration, saved_window)
4754 (Fcurrent_window_configuration, save_window_save): Handle new
4755 members of window structure.
b9e809c2
MR
4756 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4757 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4758 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4759 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4760 Qget_mru_window, Qresize_root_window,
4761 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4762 Qauto_buffer_name; staticpro them.
f3d1777e 4763
abde8f8c
MR
47642011-06-07 Martin Rudalics <rudalics@gmx.at>
4765
4766 * window.c (Fwindow_total_size, Fwindow_left_column)
4767 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4768 (Fwindow_list_1): New functions.
4769 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4770 (Fwindow_width, Fscroll_left, Fscroll_right):
4771 Use window_body_cols instead of window_box_text_cols.
4772 (delete_window, Fset_window_configuration):
4773 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4774 (delete_all_subwindows): Take a window as argument and not a
4775 structure. Rewrite.
190b47e6
MR
4776 (window_loop): Remove handling of GET_LRU_WINDOW and
4777 GET_LARGEST_WINDOW.
4778 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4779
4780 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4781 window_box_text_cols. delete_all_subwindows now takes a
4782 Lisp_Object as argument.
abde8f8c 4783
640c8776
SM
4784 * indent.c (compute_motion, Fcompute_motion):
4785 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4786
fa8a67e6
MR
4787 * frame.c (delete_frame): Call delete_all_subwindows with root
4788 window as argument.
4789
a54e3482
DC
47902011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4791
4792 * fns.c (Fputhash): Document return value.
4793
60002bf5
CY
47942011-06-06 Chong Yidong <cyd@stupidchicken.com>
4795
4796 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4797
0c671da6 47982011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4799
b862a52a 4800 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4801
be44ca6c
PE
4802 Check for overflow when converting integer to cons and back.
4803 * charset.c (Fdefine_charset_internal, Fdecode_char):
4804 Use cons_to_unsigned to catch overflow.
4805 (Fencode_char): Use INTEGER_TO_CONS.
4806 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4807 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4808 * data.c (long_to_cons, cons_to_long): Remove.
4809 (cons_to_unsigned, cons_to_signed): New functions.
4810 These signal an error for invalid or out-of-range values.
4811 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4812 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4813 * font.c (Ffont_variation_glyphs):
4814 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4815 * lisp.h: Include <intprops.h>.
4816 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4817 (cons_to_signed, cons_to_unsigned): New decls.
4818 (long_to_cons, cons_to_long): Remove decls.
4819 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4820 (Fprimitive_undo): Use CONS_TO_INTEGER.
4821 * xfns.c (Fx_window_property): Likewise.
4822 * xselect.c: Include <limits.h>.
4823 (x_own_selection, selection_data_to_lisp_data):
4824 Use INTEGER_TO_CONS.
4825 (x_handle_selection_request, x_handle_selection_clear)
4826 (x_get_foreign_selection, Fx_disown_selection_internal)
4827 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4828 (lisp_data_to_selection_data): Use cons_to_unsigned.
4829 (x_fill_property_data): Use cons_to_signed.
4830 Report values out of range.
4831
d1f3d2af
PE
4832 Check for buffer and string overflow more precisely.
4833 * buffer.h (BUF_BYTES_MAX): New macro.
4834 * lisp.h (STRING_BYTES_MAX): New macro.
4835 * alloc.c (Fmake_string):
4836 * character.c (string_escape_byte8):
4837 * coding.c (coding_alloc_by_realloc):
4838 * doprnt.c (doprnt):
4839 * editfns.c (Fformat):
4840 * eval.c (verror):
4841 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4842 since they may not be the same number.
4843 * editfns.c (Finsert_char):
4844 * fileio.c (Finsert_file_contents):
4845 Likewise for BUF_BYTES_MAX.
4846
dd52fcea
PE
4847 * image.c: Use ptrdiff_t, not int, for sizes.
4848 (slurp_file): Switch from int to ptrdiff_t.
4849 All uses changed.
4850 (slurp_file): Check that file size fits in both size_t (for
4851 malloc) and ptrdiff_t (for sanity and safety).
4852
7f9bbdbb
PE
4853 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4854 if b->modtime has its maximal value.
4855
dfe18f82
PE
4856 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4857
84acfcf0
PE
4858 Don't assume time_t can fit into int.
4859 * buffer.h (struct buffer.modtime): Now time_t, not int.
4860 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4861 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4862
ccd9a01a
PE
4863 Minor fixes for signed vs unsigned integers.
4864 * character.h (MAYBE_UNIFY_CHAR):
4865 * charset.c (maybe_unify_char):
4866 * keyboard.c (read_char, reorder_modifiers):
4867 XINT -> XFASTINT, since the integer must be nonnegative.
4868 * ftfont.c (ftfont_spec_pattern):
4869 * keymap.c (access_keymap, silly_event_symbol_error):
4870 XUINT -> XFASTINT, since the integer must be nonnegative.
4871 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4872 since it makes no difference and we prefer signed.
4873 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4874 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4875 nonnegative.
4876
d6d100dd
SM
48772011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4878
4879 * window.h (Fwindow_frame): Declare.
4880
2b6148e4
PE
48812011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4882
4883 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4884 (SPARE_MEMORY): Always define.
4885 (LARGE_REQUEST): Remove.
4886 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4887
f230ecc9
MR
48882011-06-06 Martin Rudalics <rudalics@gmx.at>
4889
727e958e
MR
4890 * lisp.h: Move EXFUNS for Fframe_root_window,
4891 Fframe_first_window and Fset_frame_selected_window to window.h.
4892
4893 * window.h: Move EXFUNS for Fframe_root_window,
4894 Fframe_first_window and Fset_frame_selected_window here from
4895 lisp.h.
4896
4897 * frame.c (Fwindow_frame, Fframe_first_window)
4898 (Fframe_root_window, Fframe_selected_window)
4899 (Fset_frame_selected_window): Move to window.c.
4900 (Factive_minibuffer_window): Move to minibuf.c.
4901 (Fother_visible_frames_p): New function.
4902
4903 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4904
f230ecc9
MR
4905 * window.c (decode_window, decode_any_window): Move up in code.
4906 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4907 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4908 (Fwindow_buffer): Move up and rewrite doc-string.
4909 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4910 (Fwindow_prev): New functions.
727e958e
MR
4911 (Fwindow_frame): Move here from frame.c. Accept any window as
4912 argument.
4913 (Fframe_root_window, Fframe_first_window)
4914 (Fframe_selected_window): Move here from frame.c. Accept frame
4915 or arbitrary window as argument. Update doc-strings.
4916 (Fminibuffer_window): Move up in code.
4917 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4918 (Fset_frame_selected_window): Move here from frame.c.
4919 Marginal rewrite.
727e958e
MR
4920 (Fselected_window, select_window, Fselect_window): Move up in
4921 code. Minor doc-string fixes.
f230ecc9 4922
4d09bcf6
PE
49232011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4924
4925 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4926 Do not assume that spare memory exists; that assumption is valid
4927 only if SYSTEM_MALLOC.
4928 (LARGE_REQUEST): New macro, so that the issue of large requests
4929 is separated from the issue of spare memory.
4930
810928a2
AS
49312011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4932
172418ad
AS
4933 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4934 format. (Bug#8806)
4935
43f862f7
AS
4936 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4937
810928a2
AS
4938 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4939 before statements.
4940
a059fe24
JD
49412011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4942
4943 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4944
4945 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4946
4947 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4948 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4949
989bf368
JB
49502011-06-05 Juanma Barranquero <lekktu@gmail.com>
4951
4952 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4953
4b80f674
CY
49542011-06-04 Chong Yidong <cyd@stupidchicken.com>
4955
4956 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4957 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4958 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4959 New error handlers.
4b80f674
CY
4960 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4961 Obey Vx_select_enable_clipboard_manager. Catch errors in
4962 x_clipboard_manager_save (Bug#8779).
4963 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4964 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4965
99a33b77 49662011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4967
4968 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4969
99a33b77 49702011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4971
4972 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4973 in the current matrix if keep_current_p is non-zero.
4974
8264569d
EZ
49752011-06-04 Eli Zaretskii <eliz@gnu.org>
4976
4977 * bidi.c (bidi_level_of_next_char): Fix last change.
4978
57f97249
EZ
49792011-06-03 Eli Zaretskii <eliz@gnu.org>
4980
fec2107c 4981 Support bidi reordering of text covered by display properties.
57f97249 4982
fec2107c
EZ
4983 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4984 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4985 (bidi_cache_search, bidi_cache_iterator_state)
4986 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4987 (bidi_level_of_next_char, bidi_move_to_visually_next):
4988 Support character positions inside a run of characters covered by a
fec2107c
EZ
4989 display string.
4990 (bidi_paragraph_init, bidi_resolve_explicit_1)
4991 (bidi_level_of_next_char): Call bidi_fetch_char and
4992 bidi_fetch_char_advance instead of FETCH_CHAR and
4993 FETCH_CHAR_ADVANCE.
4994 (bidi_init_it): Initialize new members.
4995 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4996 definitions.
4997 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4998 instead of using explicit *_CHAR codes.
d6d100dd
SM
4999 (bidi_resolve_explicit, bidi_resolve_weak):
5000 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5001 bidirectional text is supported only in multibyte buffers.
5002 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5003 it to initialize the frame_window_p member of struct bidi_it.
5004 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5005 (bidi_resolve_explicit, bidi_resolve_weak)
5006 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5007 bidi_it->nchars is non-positive.
5008 (bidi_level_of_next_char): Don't try to lookup the cache for the
5009 next/previous character if nothing is cached there yet, or if we
5010 were just reseat()'ed to a new position.
c40e2fb2 5011
0e14fe90
EZ
5012 * xdisp.c (set_cursor_from_row): Set start and stop points
5013 according to the row's direction when priming the loop that looks
5014 for the glyph on which to display cursor.
5015 (single_display_spec_intangible_p): Function deleted.
5016 (display_prop_intangible_p): Reimplement to call
5017 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5018 Accept 3 additional arguments needed by handle_display_spec.
5019 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5020 values: lists, `(when COND...)' forms, etc.
5021 (single_display_spec_string_p): Support property values that are
5022 lists with the argument STRING its top-level element.
5023 (display_prop_string_p): Fix the condition for processing a
5024 property that is a list to be consistent with handle_display_spec.
fec2107c 5025 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5026 last portion of handle_display_prop.
5027 (compute_display_string_pos): Accept additional argument
5028 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5029 value of a `display' property is a "replacing spec".
5030 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5031 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5032 the display property, but just return a value indicating whether
5033 the display property will replace the characters it covers.
5034 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5035 frame_window_p members of struct bidi_it.
d6d100dd
SM
5036 (compute_display_string_pos, compute_display_string_end):
5037 New functions.
fec2107c
EZ
5038 (push_it): Accept second argument POSITION, where pop_it should
5039 jump to continue iteration.
5040 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5041
fec2107c
EZ
5042 * keyboard.c (adjust_point_for_property): Adjust the call to
5043 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5044
5045 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5046 (bidi_init_it): Update prototypes.
5047 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5048 (compute_display_string_pos, compute_display_string_end):
5049 Declare prototypes.
fec2107c
EZ
5050 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5051 EMACS_INT.
fc6f18ce 5052
40087514 50532011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5054
57f53182
PE
5055 Malloc failure behavior now depends on size of allocation.
5056 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5057 * lisp.h: Change signatures accordingly.
5058 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5059 All callers changed. (Bug#8762)
5060
5061 * gnutls.c: Use Emacs's memory allocators.
5062 Without this change, the gnutls library would invoke malloc etc.
5063 directly, which causes problems on non-SYNC_INPUT hosts, and which
5064 runs afoul of improving memory_full behavior. (Bug#8761)
5065 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5066 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5067 xfree instead of the default malloc, realloc, free.
5068 (Fgnutls_boot): No need to check for memory allocation failure,
5069 since xmalloc does that for us.
5070
ac32cd99 5071 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5072 * category.c (hash_get_category_set):
5073 * ccl.c (ccl_driver):
5074 * charset.c (Fdefine_charset_internal):
5075 * charset.h (struct charset.hash_index):
5076 * composite.c (get_composition_id, gstring_lookup_cache)
5077 (composition_gstring_put_cache):
5078 * composite.h (struct composition.hash_index):
5079 * dispextern.h (struct image.hash):
5080 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5081 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5082 (hashfn_equal, hashfn_user_defined, make_hash_table)
5083 (maybe_resize_hash_table, hash_lookup, hash_put)
5084 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5085 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5086 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5087 * image.c (make_image, search_image_cache, lookup_image)
5088 (xpm_put_color_table_h):
5089 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5090 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5091 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5092 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5093 * alloc.c (allocate_vectorlike):
5094 Check for overflow in vector size calculations.
5095 * ccl.c (ccl_driver):
5096 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5097 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5098 need to be updated by these changes.
40087514
PE
5099 * fns.c (make_hash_table, maybe_resize_hash_table):
5100 Check for integer overflow with large hash tables.
0de4bb68
PE
5101 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5102 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5103 (SXHASH_REDUCE): New macro.
5104 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5105 Use it instead of discarding useful hash info with large hash values.
5106 (sxhash_float): New function.
5107 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5108 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5109 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5110 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5111 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5112 Adjust signatures to match updated version of code.
5113 (consing_since_gc): Now EMACS_INT, since a single hash table can
5114 use more than INT_MAX bytes.
5115
698d32e2
DN
51162011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5117
5118 Make it possible to build with GCC-4.6+ -O2 -flto.
5119
5120 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5121
fd6fa53f
SM
51222011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5123
5124 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5125 Call minibuffer-inactive-mode.
5126
864db017
JB
51272011-05-31 Juanma Barranquero <lekktu@gmail.com>
5128
5129 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5130 Update dependencies.
5131
2ad0baf4
DN
51322011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5133
5134 * data.c (init_data): Remove code for UTS, this system is not
5135 supported anymore.
5136
4fcc2638
DN
51372011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5138
5139 Don't force ./temacs to start in terminal mode.
5140
5141 * frame.c (make_initial_frame): Initialize faces in all cases, not
5142 only when CANNOT_DUMP is defined.
5143 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5144
c56e0fd5
DN
51452011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5146
5147 * dispnew.c (add_window_display_history): Use const for the string
5148 pointer. Remove declaration, not needed.
5149
333d54da 51502011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5151
55d4c1b2 5152 Use 'inline', not 'INLINE'.
333d54da 5153 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5154 * alloc.c, fontset.c (INLINE): Remove.
5155 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5156 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5157 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5158 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5159 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5160
738db178
DN
51612011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5162
5163 Make it possible to run ./temacs.
5164
5165 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5166 syms_of_callproc does the same thing. Remove test for
5167 "initialized", do it in the caller.
5168 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5169
620c53a6
SM
51702011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5171
5172 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5173 (read_minibuf): Use get_minibuffer.
5174 (syms_of_minibuf): Use DEFSYM.
5175 (Qmetadata): New var.
5176 * data.c (Qbuffer): Don't make it static.
5177 (syms_of_data): Use DEFSYM.
5178
e003a292
PE
51792011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5180
5181 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5182 (CCL_CODE_MIN): New macro.
5183
ed008a6d
PE
51842011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5185
3687c2ef
PE
5186 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5187
ed008a6d
PE
5188 * eval.c (Qdebug): Now static.
5189 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5190 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5191 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5192
d66c4c7c
CY
51932011-05-29 Chong Yidong <cyd@stupidchicken.com>
5194
5195 * image.c: Various fixes to ImageMagick code comments.
5196 (Fimagemagick_types): Doc fix.
5197
5fbc2025
PE
51982011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5199
0196f88a
PE
5200 Minor fixes prompted by GCC 4.6.0 warnings.
5201
5202 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5203
5fbc2025
PE
5204 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5205 (x_clipboard_manager_save_all): Move extern decl to ...
5206 * xterm.h: ... here, so that it can be checked for consistency.
5207
1dd3c2d9
CY
52082011-05-29 Chong Yidong <cyd@stupidchicken.com>
5209
5210 * xselect.c (x_clipboard_manager_save_frame)
5211 (x_clipboard_manager_save_all): New functions.
5212 (Fx_clipboard_manager_save): Lisp function deleted.
5213
5214 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5215 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5216
5217 * xterm.h: Update prototype.
5218
5ba6571d
WX
52192011-05-28 William Xu <william.xwl@gmail.com>
5220
5221 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5222 exiting (Bug#8239).
5223
3eaff834
JM
52242011-05-28 Jim Meyering <meyering@redhat.com>
5225
e1900994 5226 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5227 * fns.c (to_uchar): Define.
5228 (crypto_hash_function): Use it to convert some newly-signed
5229 variables to unsigned, to avoid sign-extension bugs. For example,
5230 without this change, (md5 "truc") would evaluate to
5231 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5232 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5233 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5234
0f6990a7
PE
52352011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5236
5237 Integer overflow fixes.
c8a9ca5a 5238
08686060
PE
5239 * dbusbind.c: Serial number integer overflow fixes.
5240 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5241 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5242 to hold a serial number that is too large for a fixnum.
5243 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5244 Check for serial numbers out of range. Decode any serial number
59568bf0 5245 that was so large that it became a float. (Bug#8722)
08686060 5246
2d1fc3c7
PE
5247 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5248 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5249 Use XFASTINT rather than XUINT when numbers are nonnegative.
5250 (xd_append_arg, Fdbus_method_return_internal):
5251 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5252 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5253 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5254 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5255 (Bug#8722)
2d1fc3c7 5256
c8a9ca5a
PE
5257 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5258
519e1d69
PE
5259 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5260
30569699
PE
5261 ccl: add integer overflow checks
5262 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5263 (IN_INT_RANGE): New macros.
5264 (ccl_driver): Use them to check for integer overflow when
5265 decoding a CCL program. Many of the new checks are whether XINT (x)
5266 fits in int; it doesn't always, on 64-bit hosts. The new version
5267 doesn't catch all possible integer overflows, but it's an
847044ea 5268 improvement. (Bug#8719)
30569699 5269
c11285dc
PE
5270 * alloc.c (make_event_array): Use XINT, not XUINT.
5271 There's no need for unsigned here.
5272
fdccd48e
PE
5273 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5274 This follows up to the 2011-05-06 change that substituted uintptr_t
5275 for EMACS_INT. This case wasn't caught back then.
5276
37910ab2
PE
5277 Rework Fformat to avoid integer overflow issues.
5278 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5279 now (part of C89). Include <verify.h>.
5280 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5281 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5282 (Fformat): Avoid the prepass trying to compute sizes; it was only
5283 approximate and thus did not catch overflow reliably. Instead, walk
5284 through the format just once, formatting and computing sizes as we go,
5285 checking for integer overflow at every step, and allocating a larger
5286 buffer as needed. Keep track separately whether the format is
5287 multibyte. Keep only the most-recently calculated precision, rather
5288 than them all. Record whether each argument has been converted to
5289 string. Use EMACS_INT, not int, for byte and char and arg counts.
5290 Support field widths and precisions larger than INT_MAX. Avoid
5291 sprintf's undefined behavior with conversion specifications such as %#d
5292 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5293 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5294 formatting out-of-range floating point numbers with int
9173deec 5295 formats. (Bug#8668)
37910ab2 5296
2e6578fb
PE
5297 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5298
0ae6bdee
PE
5299 * data.c: Avoid integer truncation in expressions involving floats.
5300 * data.c: Include <intprops.h>.
5301 (arith_driver): When there's an integer overflow in an expression
5302 involving floating point, convert the integers to floating point
5303 so that the resulting value does not suffer from catastrophic
5304 integer truncation. For example, on a 64-bit host (* 4
5305 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5306 Do not rely on undefined behavior after integer overflow.
5307
de883a70
PE
5308 merge count_size_as_multibyte, parse_str_to_multibyte
5309 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5310 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5311 Check for integer overflow.
5312 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5313 since it's now a duplicate of the other. This is more of
5314 a character than a buffer op, so better that it's in character.c.
5315 * fns.c, print.c: Adjust to above changes.
5316
2ff916cb
PE
53172011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5318
5319 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5320
f1b54466
PE
53212011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5322
fb1ac845
PE
5323 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5324 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5325 (x_clipboard_manager_save): Now static.
5326 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5327
f1b54466
PE
5328 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5329 (crypto_hash_function): Now static.
5330 Fix pointer signedness problems. Avoid unnecessary initializations.
5331
a9f737ee
CY
53322011-05-27 Chong Yidong <cyd@stupidchicken.com>
5333
5334 * termhooks.h (Vselection_alist): Make it terminal-local.
5335
5336 * terminal.c (create_terminal): Initialize it.
5337
5338 * xselect.c: Support for clipboard managers.
5339 (Vselection_alist): Move to termhooks.h as terminal-local var.
5340 (LOCAL_SELECTION): New macro.
5341 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5342 (symbol_to_x_atom): Remove gratuitous arg.
5343 (x_handle_selection_request, lisp_data_to_selection_data)
5344 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5345 (x_own_selection, x_get_local_selection, x_convert_selection):
5346 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5347 (some_frame_on_display): Delete unused function.
5348 (Fx_own_selection_internal, Fx_get_selection_internal)
5349 (Fx_disown_selection_internal, Fx_selection_owner_p)
5350 (Fx_selection_exists_p): New optional frame arg.
5351 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5352 (x_handle_selection_clear): Don't treat other terminals with the
5353 same keyboard specially. Use the terminal-local Vselection_alist.
5354 (x_clear_frame_selections): Use Frun_hook_with_args.
5355
5356 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5357
5358 * xterm.h: Add support for those atoms.
5359
e067f0c1
CY
53602011-05-26 Chong Yidong <cyd@stupidchicken.com>
5361
5362 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5363 (converted_selections, conversion_fail_tag): New global variables.
5364 (x_selection_request_lisp_error): Free the above.
5365 (x_get_local_selection): Remove unnecessary code.
5366 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5367 of converted selections stored in converted_selections.
5368 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5369 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5370 (x_convert_selection): New function.
5371 (x_handle_selection_event): Simplify.
5372 (x_get_foreign_selection): Don't ignore incoming requests while
5373 waiting for an answer; this will fail when we implement
5374 SAVE_TARGETS, and seems unnecessary anyway.
5375 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5376 (Vx_sent_selection_functions): Doc fix.
5377
0f4aebc0
LL
53782011-05-26 Leo Liu <sdl.web@gmail.com>
5379
5380 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5381
e61124cd
YM
53822011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5383
5384 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5385
5386 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5387 for fringe update if it has periodic bitmap.
ac389d0c 5388 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5389 and fringe_bitmap_periodic_p.
5390
5391 * fringe.c (get_fringe_bitmap_data): New function.
5392 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5393 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5394 row. Mark glyph row for fringe update if periodicity changed.
5395
5396 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5397 for fringe update unless it has periodic bitmap.
5398
f16d9837
KH
53992011-05-25 Kenichi Handa <handa@m17n.org>
5400
5401 * xdisp.c (get_next_display_element): Set correct it->face_id for
5402 a static composition.
5403
e1b90ef6
LL
54042011-05-24 Leo Liu <sdl.web@gmail.com>
5405
5406 * deps.mk (fns.o):
5407 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5408
5409 * fns.c (crypto_hash_function, Fsha1): New function.
5410 (Fmd5): Use crypto_hash_function.
5411 (syms_of_fns): Add Ssha1.
5412
7400048f
PE
54132011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5414
5415 * gnutls.c: Remove unused macros.
5416 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5417 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5418 Remove macros that are defined and never used.
5419 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5420
abb71cf4
CY
54212011-05-22 Chong Yidong <cyd@stupidchicken.com>
5422
5423 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5424 (Fx_get_selection_internal): Minor cleanup.
5425 (Fx_own_selection_internal): Rename arguments for consistency with
5426 select.el.
5427
6307db39
PE
54282011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5429
5430 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5431
f3d4e0a4
CY
54322011-05-22 Chong Yidong <cyd@stupidchicken.com>
5433
5434 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5435
4d8ade89
YM
54362011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5437
5438 * dispnew.c (scrolling_window): Don't exclude the case that the
5439 last enabled row in the desired matrix touches the bottom boundary.
5440
32078c8d
GM
54412011-05-21 Glenn Morris <rgm@gnu.org>
5442
5443 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5444 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5445 and add some more files.
32078c8d 5446
7285dc67
EZ
54472011-05-20 Eli Zaretskii <eliz@gnu.org>
5448
5449 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5450 report_file_error introduced by the change from 2011-05-07.
5451
89d1bd22
PE
54522011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5453
5454 * systime.h (Time): Define only if emacs is defined.
5455 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5456 where the include path doesn't have X11/X.h by default. See
5457 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5458
e23640bb 54592011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5460
5461 * composite.c (find_automatic_composition): Fix previous change.
5462
b9704ad9
GM
54632011-05-20 Glenn Morris <rgm@gnu.org>
5464
5465 * lisp.mk: New file, split from Makefile.in.
5466 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5467 (shortlisp): Remove.
5468 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5469
4a720484
GM
54702011-05-19 Glenn Morris <rgm@gnu.org>
5471
5472 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5473 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5474 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5475 (lisp): Set the order to that of loadup.el.
5476 (shortlisp): Make it a copy of $lisp.
5477 (SOME_MACHINE_LISP): Remove.
5478 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5479 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5480
a28d4396
KH
54812011-05-18 Kenichi Handa <handa@m17n.org>
5482
5483 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5484 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5485 (find_automatic_composition): Mostly rewrite for efficiency.
5486
a2b1fa8e
JB
54872011-05-18 Juanma Barranquero <lekktu@gmail.com>
5488
5489 * makefile.w32-in: Update dependencies.
5490
8e1f5610
CS
54912011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5492
5493 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5494 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5495
7025ee00 54962011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5497
cdfa6eab
PE
5498 Fix some integer overflow issues, such as string length overflow.
5499
06d6db33
PE
5500 * insdel.c (count_size_as_multibyte): Check for string overflow.
5501
2b4560a8
PE
5502 * character.c (lisp_string_width): Check for string overflow.
5503 Use EMACS_INT, not int, for string indexes and lengths; in
5504 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5505 the resulting string length overflows an EMACS_INT; instead,
5506 report a string overflow if no precision given. When checking for
5507 precision exhaustion, use a check that cannot possibly have
5508 integer overflow. (Bug#8675)
5509 * character.h (lisp_string_width): Adjust to new signature.
5510
cb93f9be
PE
5511 * alloc.c (string_overflow): New function.
5512 (Fmake_string): Use it. This doesn't change behavior, but saves
5513 a few bytes and will simplify future changes.
5514 * character.c (string_escape_byte8): Likewise.
5515 * lisp.h (string_overflow): New decl.
5516
1a1f3366
PE
5517 Fixups, following up to the user-interface timestamp change.
5518 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5519 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5520 * msdos.c (mouse_get_pos): Likewise.
5521 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5522 * w32gui.h (Time): Define by including "systime.h" rather than by
5523 declaring it ourselves. (Bug#8664)
5524
d4e3e4d3
PE
5525 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5526 * image.c (clear_image_cache): Likewise.
5527
f6a24d19
PE
5528 * term.c (term_mouse_position): Don't assume time_t wraparound.
5529
08dc5ae6
PE
5530 Be more systematic about user-interface timestamps.
5531 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5532 and sometimes 'EMACS_UINT', to represent these timestamps.
5533 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5534 This makes the code easier to follow, and makes it easier to catch
5535 integer overflow bugs such as Bug#8664.
5536 * frame.c (Fmouse_position, Fmouse_pixel_position):
5537 Use Time, not unsigned long, for user-interface timestamps.
5538 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5539 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5540 * keyboard.h (last_event_timestamp): Likewise.
5541 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5542 * menu.h (xmenu_show): Likewise.
5543 * term.c (term_mouse_position): Likewise.
5544 * termhooks.h (struct input_event.timestamp): Likewise.
5545 (struct terminal.mouse_position_hook): Likewise.
5546 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5547 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5548 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5549 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5550 what it was before.
5551 * menu.h, termhooks.h: Include "systime.h", for Time.
5552
8e55734a
PE
5553 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5554 Don't assume that the difference between two unsigned long values
5555 can fit into an integer. At this point, we know button_down_time
5556 <= event->timestamp, so the difference must be nonnegative, so
5557 there's no need to cast the result if double-click-time is
5558 nonnegative, as it should be; check that it's nonnegative, just in
5559 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5560 apart (about 25 days). (Bug#8664)
8e55734a 5561
841f1b75 5562 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5563 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5564
3e26f69c
PE
5565 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5566 that always fit in int. Use a sentinel instead of a counter, to
5567 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5568 * frame.h (struct frame): Use int for menu_bar_items_used
5569 instead of EMACS_INT, since it always fits in int.
3e26f69c 5570
5cc152c0
PE
5571 * menu.c (grow_menu_items): Check for int overflow.
5572
d89eb65e
PE
5573 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5574
5235bd3e
PE
5575 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5576 Before, the code was not consistent. These values cannot exceed
5577 2**31 - 1 so there's no need to make them unsigned.
5578 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5579 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5580 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5581 as modifiers.
5582 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5583
bc827e23
PE
5584 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5585 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5586 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5587 presumably because the widths might not match.
5588
78eb494e
PE
5589 * window.c (size_window): Avoid needless test at loop start.
5590
04f2d78b
CB
55912011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5592
5593 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5594
d2fc7e3d 55952011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5596
5597 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5598
d2fc7e3d 55992011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5600
5601 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5602 `width' to `bar_area_x' and `bar_area_width', respectively.
5603 (x_scroll_run): Take account of fringe background extension.
5604
04f2d78b
CB
5605 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5606 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5607 `bar_area_width', respectively.
5608 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5609 background extension.
5610
79b70037
GM
56112011-05-10 Jim Meyering <meyering@redhat.com>
5612
5613 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5614
2f142cc5
JB
56152011-05-10 Juanma Barranquero <lekktu@gmail.com>
5616
5617 * image.c (Finit_image_library): Return t for built-in image types,
5618 like pbm and xbm. (Bug#8640)
5619
57679c86
AS
56202011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5621
5622 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5623
888c9e86
EZ
56242011-05-07 Eli Zaretskii <eliz@gnu.org>
5625
b0512a1d
EZ
5626 * w32console.c (Fset_screen_color): Doc fix.
5627 (Fget_screen_color): New function.
5628 (syms_of_ntterm): Defsubr it.
5629
7285dc67
EZ
5630 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5631 unlink the temporary file if Fcall_process didn't create it in the
5632 first place.
5633 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5634 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5635 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5636 cue to call_process_cleanup not to close that handle.
5637
4d3fcc8e
BK
56382011-05-07 Ben Key <bkey76@gmail.com>
5639
5640 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5641 one of two shell specific rules, either bootstrap-temacs-CMD or
5642 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5643 to the previous implementation of the bootstrap-temacs rule.
5644 The bootstrap-temacs-CMD rule is similar to the previous
5645 implementation of the bootstrap-temacs rule except that it
5646 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5647 variable.
5648
5649 These changes, along with some changes to nt/configure.bat,
5650 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5651 earlier fix to add support for --cflags and --ldflags options
5652 that include quotes so that it works whether make uses cmd or
5653 sh as the shell.
5654
b4289b64
MA
56552011-05-06 Michael Albinus <michael.albinus@gmx.de>
5656
5657 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5658 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5659 is a constant.
5660 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5661 a string. Handle both cases.
5662 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5663 (Fdbus_register_method): Use Qinvalid_function.
5664
af4c0e28
JB
56652011-05-06 Juanma Barranquero <lekktu@gmail.com>
5666
5667 * makefile.w32-in: Update dependencies.
5668 (LISP_H): Add inttypes.h and stdin.h.
5669 (PROCESS_H): Add unistd.h.
5670
c51453d9
EZ
56712011-05-06 Eli Zaretskii <eliz@gnu.org>
5672
5673 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5674 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5675
8ff0ac3c 56762011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5677
4c4b566b
PE
5678 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5679
aab2b9b5
PE
5680 * term.c (vfatal): Remove stray call to va_end.
5681 It's not needed and the C Standard doesn't allow it here anyway.
5682
c378da0b
PE
5683 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5684 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5685
288b08c7
PE
5686 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5687 bytes.
5688
e3601888
PE
5689 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5690
db6c0e74
PE
5691 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5692
dd5963ea
PE
5693 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5694
88c9450f
PE
5695 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5696
2f9442b8
PE
5697 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5698
c032b5f8
PE
5699 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5700 * charset.c (Fdefine_charset_internal): Don't initialize
5701 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5702 32-bit int (Bug#8600).
a108c10b
PE
5703
5704 * lread.c (read_integer): Be more consistent with string-to-number.
5705 Use string_to_number to do the actual conversion; this avoids
5706 rounding errors and fixes some other screwups. Without this fix,
5707 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5708 (digit_to_number): Move earlier, for benefit of read_integer.
5709 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5710 not a digit in any supported base. (Bug#8602)
a108c10b 5711
ad5f9eea
PE
5712 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5713
aec1708a
PE
5714 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5715 to match comment at start of function. This also removes a
5716 GCC warning about overflow in a 32+64-bit port.
5717
47be4ab5
PE
5718 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5719
371cac43
PE
5720 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5721 Reported by Stefan Monnier in
5722 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5723 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5724 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5725
d01a7826
PE
5726 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5727 (EMACS_UINTPTR): Likewise, with uintptr_t.
5728
7fd47d5c
PE
5729 * lisp.h: Prefer 64-bit EMACS_INT if available.
5730 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5731 on 32-bit hosts that have 64-bit int, so that they can access
5732 large files.
122b0c86
PE
5733 However, temporarily disable this change unless the temporary
5734 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5735
8727937b
PE
5736 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5737
8ac068ac
PE
5738 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5739 This removes an assumption that EMACS_INT and long are the same
5740 width as pointers. The assumption is true for Emacs porting targets
5741 now, but we want to make other targets possible.
5742 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5743 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5744 In the rest of the code, change types of integers that hold casted
5745 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5746 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5747 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5748 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5749 No need to cast type when ORing.
5750 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5751 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5752 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5753 assume EMACS_INT is the same width as char *.
5754 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5755 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5756 Remove no-longer-needed casts.
5757 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5758 (xg_tool_bar_help_callback, xg_make_tool_item):
5759 Use EMACS_INTPTR to hold an integer
5760 that will be cast to void *; this can avoid a GCC warning
5761 if EMACS_INT is not the same width as void *.
5762 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5763 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5764 (current_message_1, set_message_1):
5765 Use a local to convert to proper width without a cast.
5766 * xmenu.c (dialog_selection_callback): Likewise.
5767
ede49d71
PE
5768 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5769 Also, don't assume VALBITS / RAND_BITS is less than 5,
5770 and don't rely on undefined behavior when shifting a 1 left into
5771 the sign bit.
5772 * lisp.h (get_random): Change signature to match.
5773
2f30ecd0
PE
5774 * lread.c (hash_string): Use size_t, not int, for hash computation.
5775 Normally we prefer signed values; but hashing is special, because
5776 it's better to use unsigned division on hash table sizes so that
5777 the remainder is nonnegative. Also, size_t is the natural width
5778 for hashing into memory. The previous code used 'int', which doesn't
5779 retain enough info to hash well into very large tables.
5780 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5781
2a866e7b
PE
5782 * dbusbind.c: Don't possibly lose pointer info when converting.
5783 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5784 Use XPNTR rather than XHASH, so that the high-order bits of
5785 the pointer aren't lost when converting through void *.
5786
51639eac
PE
5787 * eval.c (Fautoload): Don't double-shift a pointer.
5788
92394119
PE
5789 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5790
dbdb9a7c
JB
57912011-05-06 Juanma Barranquero <lekktu@gmail.com>
5792
5793 * gnutls.c (DEF_GNUTLS_FN):
5794 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5795
db7a0b4f
AS
57962011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5797
5798 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5799 marker. (Bug#8610)
5800
f7ff1b0f 58012011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5802
5803 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5804 New version that can reserve upto 2GB of heap space.
5805
f7ff1b0f 58062011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5807
5808 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5809
639c109b
TZ
58102011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5811
5812 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5813 `gnutls_certificate_set_x509_key_file'.
5814
d2127135
JB
58152011-05-05 Juanma Barranquero <lekktu@gmail.com>
5816
5817 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5818 Update dependencies.
5819
e968f4f3
JB
58202011-05-04 Juanma Barranquero <lekktu@gmail.com>
5821
5822 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5823 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5824 Remove unused parameter `fildes'.
5825 * process.c (read_process_output, send_process): Don't pass it.
5826
84d358f0
JB
58272011-05-04 Juanma Barranquero <lekktu@gmail.com>
5828
5829 Fix previous change: the library cache is defined in w32.c.
5830 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5831 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5832
0898ca10
JB
58332011-05-04 Juanma Barranquero <lekktu@gmail.com>
5834
5835 Implement dynamic loading of GnuTLS on Windows.
5836
5837 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5838 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5839 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5840 Declare.
5841
5842 * gnutls.c (Qgnutls_dll): Define.
5843 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5844 (gnutls_*): Declare function pointers.
5845 (init_gnutls_functions): New function to initialize function pointers.
5846 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5847 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5848 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5849 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5850 (emacs_gnutls_write, emacs_gnutls_read)
5851 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5852 (Fgnutls_available_p): New function.
5853 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5854 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5855 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5856
5857 * image.c: Include w32.h.
5858 (Vimage_type_cache): Delete.
5859 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5860 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5861 (w32_delayed_load): Move to w32.c.
5862
5863 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5864
5865 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5866 (w32_delayed_load): Move from image.c. When loading a library, record
5867 its filename in the :loaded-from property of the library id.
5868 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5869 Initialize and staticpro them.
5870 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5871
5872 * process.c: Include lisp.h before w32.h, not after.
5873 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5874 instead of gnutls_record_check_pending.
5875
5876 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5877
ff4de4aa
TZ
58782011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5879
5880 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5881 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5882 as passed in.
5883
abe95abb
JD
58842011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5885
5886 * xterm.c (x_set_frame_alpha): Do not set property on anything
5887 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5888
e16e55d4
JB
58892011-05-02 Juanma Barranquero <lekktu@gmail.com>
5890
5891 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5892
bafcf6a5
JB
58932011-05-02 Juanma Barranquero <lekktu@gmail.com>
5894
5895 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5896 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5897 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5898 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5899 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5900 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5901 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5902 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5903 (Qgnutls_bootprop_callbacks_verify): Make static.
5904
e7a6747f
AS
59052011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5906
19ed11ba
AS
5907 * callproc.c: Indentation fixup.
5908
e7a6747f 5909 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5910 (wait_for_termination, interruptible_wait_for_termination):
5911 Move after wait_for_termination_1.
e7a6747f 5912
1ef14cb4
LMI
59132011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5914
5915 * sysdep.c (interruptible_wait_for_termination): New function
5916 which is like wait_for_termination, but allows keyboard
5917 interruptions.
5918
5919 * callproc.c (Fcall_process): Add (:file "file") as an option for
5920 the STDOUT buffer.
5921 (Fcall_process_region): Ditto.
5922
330d880c
EZ
59232011-04-30 Eli Zaretskii <eliz@gnu.org>
5924
8db90b73
EZ
5925 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5926 rather than `XVECTOR (FOO)->size'.
5927
330d880c
EZ
5928 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5929 inttypes.h, as a gnulib replacement is used if it not available in
5930 system headers.
5931
15cbd324
EZ
59322011-04-21 Eli Zaretskii <eliz@gnu.org>
5933
5934 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5935 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5936 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5937
5938 * coding.c (coding_alloc_by_realloc): Error out if destination
5939 will grow beyond MOST_POSITIVE_FIXNUM.
5940 (decode_coding_emacs_mule): Abort if there isn't enough place in
5941 charbuf for the composition carryover bytes. Reserve an extra
5942 space for up to 2 characters produced in a loop.
5943 (decode_coding_iso_2022): Abort if there isn't enough place in
5944 charbuf for the composition carryover bytes.
5945
59462011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5947
ae940cca
EZ
5948 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5949 aborting when %lld or %lll format is passed.
5950 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5951 %llo or %llx format is passed. (Bug#8545)
5952
03ab8921
EZ
5953 * window.c (window_scroll_line_based): Use a marker instead of
5954 simple variables to record original value of point. (Bug#7952)
5955
afda1437
EZ
5956 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5957 produced by %s or %c overflows available buffer space. (Bug#8545)
5958
f76dee0c
PE
59592011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5960
5961 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5962 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5963
fdc5744d
JB
59642011-04-28 Juanma Barranquero <lekktu@gmail.com>
5965
5966 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5967
638f053a
JB
59682011-04-28 Juanma Barranquero <lekktu@gmail.com>
5969
5970 * keyboard.c (Qdelayed_warnings_hook): Define.
5971 (command_loop_1): Run `delayed-warnings-hook'
5972 if Vdelayed_warnings_list is non-nil.
5973 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5974 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5975
d178f871
EZ
59762011-04-28 Eli Zaretskii <eliz@gnu.org>
5977
5978 * doprnt.c (doprnt): Don't return value smaller than the buffer
5979 size if the message was truncated. (Bug#8545).
5980
b124fd93
JB
59812011-04-28 Juanma Barranquero <lekktu@gmail.com>
5982
5983 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5984 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5985
e810457d
PE
59862011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5987
5988 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5989
ea51cceb
JB
59902011-04-27 Juanma Barranquero <lekktu@gmail.com>
5991
5992 * makefile.w32-in: Update dependencies.
5993
94dcfacf
EZ
59942011-04-27 Eli Zaretskii <eliz@gnu.org>
5995
5996 Improve `doprnt' and its usage. (Bug#8545)
5997 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5998 `format_end'. Remove support for %l as a conversion specifier.
5999 Don't use xrealloc. Improve diagnostics when the %l size modifier
6000 is used. Update the commentary.
6001
6002 * eval.c (verror): Simplify calculation of size_t.
6003
6004 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6005 messages.
6006
f61f41d7
PE
60072011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6008
6009 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6010 change.
6011
96fb4434
PE
60122011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6013
6014 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6015 This makes this file independent of the recent pseudovector change.
6016
671875da 60172011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6018
69e9b5a3
PE
6019 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6020
b5f869a7 6021 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6022 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6023 Remove unused local.
c8926152 6024 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6025
841a1577 6026 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6027 GCC 4.6.0 optimizes based on type-based alias analysis.
6028 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6029 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6030 != &v->size, and therefore "v->size = 1; b->size = 2; return
6031 v->size;" must therefore return 1. This assumption is incorrect
6032 for Emacs, since it type-puns struct Lisp_Vector * with many other
6033 types. To fix this problem, this patch adds a new type struct
f904488f 6034 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6035 and pseudovectors, and helps optimizing compilers not get fooled
6036 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6037 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6038 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6039 the size member.
eab3844f
PE
6040 (XSETPVECTYPE): Rewrite in terms of new macro.
6041 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6042 This is a bit clearer, and further avoids the possibility of
6043 undesirable aliasing.
6044 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6045 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6046 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6047 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6048 (ASIZE): Now uses header.size rather than size.
6049 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6050 to avoid the hassle of writing XVECTOR (foo)->header.size.
6051 (struct vectorlike_header): New type.
eab3844f
PE
6052 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6053 object, to help avoid aliasing.
6054 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6055 (SUBRP): Likewise, since Lisp_Subr is a special case.
6056 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6057 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6058 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6059 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6060 changed to be "header.size" and "header.next".
6061 * buffer.h (struct buffer): Likewise.
6062 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6063 * frame.h (struct frame): Likewise.
6064 * process.h (struct Lisp_Process): Likewise.
6065 * termhooks.h (struct terminal): Likewise.
6066 * window.c (struct save_window_data, struct saved_window): Likewise.
6067 * window.h (struct window): Likewise.
6068 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6069 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6070 * buffer.c (init_buffer_once): Likewise.
6071 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6072 special case.
6073 * process.c (Fformat_network_address): Use local var for size,
6074 for brevity.
6075
0df1eac5
PE
6076 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6077
847ab9d1 6078 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6079 * data.c (atof): Remove decl; no longer used or needed.
6080 (digit_to_number): Move to lread.c.
6081 (Fstring_to_number): Use new string_to_number function, to be
6082 consistent with how the Lisp reader treats infinities and NaNs.
6083 Do not assume that floating-point numbers represent EMACS_INT
6084 without losing information; this is not true on most 64-bit hosts.
6085 Avoid double-rounding errors, by insisting on integers when
6086 parsing non-base-10 numbers, as the documentation specifies.
6087 * lisp.h (string_to_number): New decl, replacing ...
6088 (isfloat_string): Remove.
bc0a5c13 6089 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6090 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6091 appears to have been a coding error. Similarly, do not accept
6092 strings like +-1e0 as floating point numbers. Do not report
6093 overflow for integer overflows unless the base is not 10 which
6094 means we have no simple and reliable way to continue.
6095 Break out the floating-point parsing into a new
6096 function string_to_number, so that Fstring_to_number parses
6097 floating point numbers consistently with the Lisp reader.
04f2d78b 6098 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6099 (E_CHAR, EXP_INT): Remove, replacing with ...
6100 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6101 (string_to_number): New function, replacing isfloat_string.
6102 This function checks for valid syntax and produces the resulting
6103 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6104 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6105 so that overflow for non-base-10 numbers is reported only when
6106 there's no portable and simple way to convert to floating point.
452f4150 6107
67769ffc
PE
6108 * textprop.c (set_text_properties_1): Rewrite for clarity,
6109 and to avoid GCC warning about integer overflow.
6110
c20db43f
PE
6111 * intervals.h (struct interval): Use EMACS_INT for members
6112 where EMACS_UINT might cause problems. See
6113 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6114 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6115 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6116 All uses changed.
37aa2f85
PE
6117 (offset_intervals): Tell GCC not to worry about length overflow
6118 when negating a negative length.
c20db43f 6119
2538aa2f
PE
6120 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6121 (overrun_check_free): Likewise.
6122
f2d3008d
PE
6123 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6124 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6125 word size.
6126
ec8df744
PE
6127 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6128 (gnutls_make_error): Rename local to avoid shadowing.
6129 (gnutls_emacs_global_deinit): ifdef out; not used.
6130 (Fgnutls_boot): Use const for pointer to readonly storage.
6131 Comment out unused local. Fix pointer signedness problems.
6132
640ee02d
PE
6133 * lread.c (openp): Don't stuff size_t into an 'int'.
6134 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6135 about possible signed overflow.
6136
6048fb2a
PE
6137 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6138 (GDK_KEY_g): Don't define if already defined.
6139 (xg_prepare_tooltip): Avoid pointer signedness problem.
6140 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6141
fa3c87e1
PE
6142 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6143 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6144
2172544b
PE
6145 * xfns.c (Fx_window_property): Simplify a bit,
6146 to make a bit faster and to avoid GCC 4.6.0 warning.
6147 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6148
9b821a21
PE
6149 * fns.c (internal_equal): Don't assume size_t fits in int.
6150
3c616cfa
PE
6151 * alloc.c (compact_small_strings): Tighten assertion a little.
6152
c2982e87
PE
6153 Replace pEd with more-general pI, and fix some printf arg casts.
6154 * lisp.h (pI): New macro, generalizing old pEd macro to other
6155 conversion specifiers. For example, use "...%"pI"d..." rather
6156 than "...%"pEd"...".
6157 (pEd): Remove. All uses replaced with similar uses of pI.
6158 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6159 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6160 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6161 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6162 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6163 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6164 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6165 64-bit hosts.
6166 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6167 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6168 * print.c (safe_debug_print, print_object): Likewise.
6169 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6170 to int.
6f04d126
PE
6171 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6172 avoiding the 0 flag, which is not portable.
c2982e87
PE
6173 * process.c (Fmake_network_process): Use pI to avoid cast.
6174 * region-cache.c (pp_cache): Likewise.
6175 * xdisp.c (decode_mode_spec): Likewise.
6176 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6177 behavior on 64-bit hosts with printf arg.
6f04d126 6178 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6179 (x_stop_queuing_selection_requests): Likewise.
6180 (x_get_window_property): Don't truncate byte count to an 'int'
6181 when tracing.
0b432f21 6182
5e073ec7
PE
6183 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6184 here, since it parses constructs like leading '-' and spaces,
6185 which are not wanted; and it overflows with large numbers.
6186 Instead, simply match F[0-9]+, which is what is wanted anyway.
6187
36372bf9
PE
6188 * alloc.c: Remove unportable assumptions about struct layout.
6189 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6190 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6191 (allocate_vectorlike, make_pure_vector): Use the new macros,
6192 plus offsetof, to remove unportable assumptions about struct layout.
6193 These assumptions hold on all porting targets that I know of, but
6194 they are not guaranteed, they're easy to remove, and removing them
6195 makes further changes easier.
6196
0b432f21
PE
6197 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6198 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6199 (string_overrun_cookie): Now const. Use initializers that
6200 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6201 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6202 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6203 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6204 multiple of sizeof (EMACS_INT); it need not be, if
6205 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6206 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6207
895009e1
JB
62082011-04-26 Juanma Barranquero <lekktu@gmail.com>
6209
6210 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6211
6a7a1b0b
TZ
62122011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6213
6214 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6215 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6216 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6217
841a1577 62182011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6219
6220 * lisp.h (Qdebug): List symbol.
895009e1 6221 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6222 * keyboard.c (debug-on-event): New variable.
6223 (handle_user_signal): Break into debugger when debug-on-event
6224 matches the current signal symbol.
6225
f2d3ba6f
DN
62262011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6227
6228 * alloc.c (check_sblock, check_string_bytes)
6229 (check_string_free_list): Convert to standard C.
6230
42ce4c63
TZ
62312011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6232
6233 * w32.c (emacs_gnutls_push): Fix typo.
6234
825cd63c
EZ
62352011-04-25 Eli Zaretskii <eliz@gnu.org>
6236
fb11d64d
EZ
6237 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6238 "cast to pointer from integer of different size".
6239
825cd63c
EZ
6240 Improve doprnt and its use in verror. (Bug#8545)
6241 * doprnt.c (doprnt): Document the set of format control sequences
6242 supported by the function. Use SAFE_ALLOCA instead of always
6243 using `alloca'.
6244
6245 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6246 is one byte too soon. Don't use xrealloc; instead xfree and
6247 xmalloc anew.
6248
e061a11b
TZ
62492011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6250
6251 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6252 callbacks stage.
6253
6254 * gnutls.c: Renamed global_initialized to
6255 gnutls_global_initialized. Added internals for the
6256 :verify-hostname-error, :verify-error, and :verify-flags
6257 parameters of `gnutls-boot' and documented those parameters in the
6258 docstring. Start callback support.
9173deec
JB
6259 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6260 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6261 on error. Return error code.
e061a11b
TZ
6262 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6263 (emacs_gnutls_read): Likewise.
6264 (Fgnutls_boot): Return handshake error code.
6265 (emacs_gnutls_handle_error): New function.
6266 (wsaerror_to_errno): Likewise.
6267
6268 * w32.h (emacs_gnutls_pull): Add prototype.
6269 (emacs_gnutls_push): Likewise.
6270
6271 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6272 (emacs_gnutls_push): Likewise.
6273
62742011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6275
6276 * process.c (wait_reading_process_output): Check if GnuTLS
6277 buffered some data internally if no FDs are set for TLS
6278 connections.
6279
6280 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6281 (LIBS): Link to USER_LIBS.
6282 ($(BLD)/gnutls.$(0)): New target.
6283
fa6996bc
EZ
62842011-04-24 Eli Zaretskii <eliz@gnu.org>
6285
eb35682e
EZ
6286 * xdisp.c (handle_single_display_spec): Rename the
6287 display_replaced_before_p argument into display_replaced_p, to
6288 make it consistent with the commentary. Fix typos in the
6289 commentary.
6290
e2ad650c
EZ
6291 * textprop.c (syms_of_textprop): Remove dead code.
6292 (copy_text_properties): Delete obsolete commentary about an
6293 interface that was deleted long ago. Fix typos in the description
6294 of arguments.
6295
1b2de274
EZ
6296 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6297 to changes in oldXMenu/XMenu.h from 2011-04-16.
6298 <menu_help_message, prev_menu_help_message>: Constify.
6299 (IT_menu_make_room): menu->help_text is now `const char **';
6300 adjust.
6301
6302 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6303 to changes in oldXMenu/XMenu.h from 2011-04-16.
6304 (struct XMenu): Declare `help_text' `const char **'.
6305
6306 * xfaces.c <Qunspecified>: Make extern again.
6307
6308 * syntax.c: Include sys/types.h before including regex.h, as
6309 required by Posix.
6310
762b15be
EZ
6311 * doc.c (get_doc_string): Improve the format passed to `error'.
6312
6313 * doprnt.c (doprnt): Improve commentary.
6314
6315 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6316
6317 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6318 them with etags.
6319
f1052e5d
EZ
6320 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6321 changes in globals.h immediately force recompilation.
762b15be
EZ
6322 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6323 $(CURDIR)/s/ms-w32.h.
6324 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6325
fa6996bc
EZ
6326 * character.c (Fchar_direction): Function deleted.
6327 (syms_of_character): Don't defsubr it.
6328 <char-direction-table>: Deleted.
6329
e6c3da20
EZ
63302011-04-23 Eli Zaretskii <eliz@gnu.org>
6331
6332 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6333 * doprnt.c: Include limits.h.
6334 (SIZE_MAX): New macro.
04f2d78b
CB
6335 (doprnt): Return a size_t value. 2nd arg is now size_t.
6336 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6337 Improve overflow protection. Support `l' modifier for integer
6338 conversions. Support %l conversion. Don't assume an EMACS_INT
6339 argument for integer conversions and for %c.
6340
6341 * lisp.h (doprnt): Restore prototype.
6342
6343 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6344 $(SRC)/character.h.
6345
6346 * Makefile.in (base_obj): Add back doprnt.o.
6347
6348 * deps.mk (doprnt.o): Add back prerequisites.
6349 (callint.o): Depend on character.h.
6350
6351 * eval.c (internal_lisp_condition_case): Include the handler
6352 representation in the error message.
6353 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6354 when breaking from the loop.
6355
6356 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6357
6358 * callint.c (Fcall_interactively): When displaying error message
6359 about invalid control letter, pass the character's codepoint, not
6360 a pointer to its multibyte form. Improve display of the character
6361 in octal and display also its hex code.
6362
6363 * character.c (char_string): Use %x to display the (unsigned)
6364 codepoint of an invalid character, to avoid displaying a bogus
6365 negative value.
6366
6367 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6368 `error', not SYMBOL_NAME itself.
6369
6370 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6371 character arguments to `error'.
6372
6373 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6374 to `error' in error message about FINAL_CHAR argument. Make sure
6375 FINAL_CHAR is a character, and use %c when it is passed as
6376 argument to `error'.
6377
4ffd0d6b 63782011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6379
6380 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6381
6382 * w32.c: Include <time.h>.
6383 (sys_localtime): New function.
6384
4ffd0d6b 63852011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6386
6387 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6388
4ffd0d6b 6389 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6390
4ffd0d6b 63912011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6392
4ffd0d6b
GM
6393 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6394 zombies (Bug#8467).
aac0c6e3 6395
04c56954
EZ
63962011-04-19 Eli Zaretskii <eliz@gnu.org>
6397
6398 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6399 gl_state.e_property when gl_state.object is Qt.
6400
6401 * insdel.c (make_gap_larger): Remove limitation of buffer size
6402 to <= INT_MAX.
6403
16a43933
CY
64042011-04-18 Chong Yidong <cyd@stupidchicken.com>
6405
6406 * xdisp.c (lookup_glyphless_char_display)
6407 (produce_glyphless_glyph): Handle cons cell entry in
6408 glyphless-char-display.
6409 (Vglyphless_char_display): Document it.
6410
6411 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6412 glyphless-char-display.
6413
4581706e
CY
64142011-04-17 Chong Yidong <cyd@stupidchicken.com>
6415
6416 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6417
6418 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6419
6420 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6421 definition for no-X builds.
6422
4887c6e2 64232011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6424
fd35b6f9
PE
6425 Static checks with GCC 4.6.0 and non-default toolkits.
6426
5c1ccb01
PE
6427 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6428
006c5daa
PE
6429 * process.c (keyboard_bit_set): Define only if SIGIO.
6430 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6431 (send_process): Repair possible setjmp clobbering.
6432
efc736d3
PE
6433 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6434
4e2fe2e6
PE
6435 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6436
f97334a2
PE
6437 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6438
4e75f29d
PE
6439 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6440 Define only if needed.
6441
90efadd1
PE
6442 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6443 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6444 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6445
3c647824
PE
6446 * dispextern.h (struct redisplay_interface): Rename param
6447 to avoid shadowing.
e264f262 6448 * termhooks.h (struct terminal): Likewise.
761383f4 6449 * xterm.c (xembed_send_message): Likewise.
3c647824 6450
b58c5c4a
PE
6451 * insdel.c (make_gap_smaller): Define only if
6452 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6453
cad59032
PE
6454 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6455 it.
6456
c339dc2e
PE
6457 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6458 so that we aren't warned about unused symbols.
6459
91a3e27b
PE
6460 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6461
399c71d3 6462 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6463
8ffc96f5
PE
6464 * xfns.c (x_real_positions): Mark locals as initialized.
6465
eef9bc79
PE
6466 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6467
098db9dd
PE
6468 * xterm.c: Fix problems found by static analysis with other toolkits.
6469 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6470 (x_dispatch_event): Declare static if USE_GTK, and
6471 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6472 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6473 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6474 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6475 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6476
eb18f6cc
PE
6477 * xmenu.c (menu_help_callback): Pointer type fixes.
6478 Use const pointers when pointing at readonly data. Avoid pointer
6479 signedness clashes.
6480 (FALSE): Remove unused macro.
6481 (update_frame_menubar): Remove unused decl.
6482
1fe72bf8
PE
6483 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6484
60d9e1db
PE
6485 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6486 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6487 (single_menu_item): Rename local to avoid shadowing.
6488
39261c26
PE
6489 * keyboard.c (make_lispy_event): Remove unused local var.
6490
018c5e19
PE
6491 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6492 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6493
63d2b86e
PE
6494 * bitmaps: Change bitmaps from unsigned char back to the X11
6495 compatible char. Avoid the old compiler warnings about
6496 out-of-range initializers by using, for example, '\xab' rather
6497 than 0xab.
6498
aefd87e1
PE
6499 * xgselect.c (xgselect_initialize): Check vs interface
6500 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6501
bf501fb9
PE
6502 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6503
e9829fdf
PE
6504 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6505 to read-only memory.
6506
1086c095
PE
6507 * fns.c (vector): Remove; this old hack is no longer needed.
6508
2baccd04 6509 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6510 Remove unused var.
dde42981 6511 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6512
72391843 6513 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6514
436c16df 6515 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6516 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6517 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6518
92bb796d 6519 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6520 (x_term_init): Remove local to avoid shadowing.
92bb796d 6521
764430a3 6522 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6523
6524 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6525 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6526
d1dfb56c
EZ
65272011-04-16 Eli Zaretskii <eliz@gnu.org>
6528
c4354cb4
EZ
6529 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6530
d1dfb56c
EZ
6531 Fix regex.c, syntax.c and friends for buffers > 2GB.
6532 * syntax.h (struct gl_state_s): Declare character position members
6533 EMACS_INT.
6534
6535 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6536
04f2d78b
CB
6537 * textprop.c (verify_interval_modification, interval_of):
6538 Declare arguments EMACS_INT.
d1dfb56c
EZ
6539
6540 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6541 EMACS_INT.
6542
6543 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6544
6545 * indent.c (Fvertical_motion): Local variable it_start is now
6546 EMACS_INT.
6547
6548 * regex.c (re_match, re_match_2, re_match_2_internal)
6549 (bcmp_translate, regcomp, regexec, print_double_string)
6550 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6551 (re_compile_pattern, re_exec): Declare arguments and local
6552 variables `size_t' and `ssize_t' and return values `regoff_t', as
6553 appropriate.
6554 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6555 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6556 <compile_stack_type>: `size' and `avail' are now `size_t'.
6557
6558 * regex.h <regoff_t>: Use ssize_t, not int.
6559 (re_search, re_search_2, re_match, re_match_2): Arguments that
6560 specify buffer/string position and length are now ssize_t and
6561 size_t. Return type is regoff_t.
6562
613052cd
BK
65632011-04-16 Ben Key <bkey76@gmail.com>
6564
6565 * nsfont.m: Fixed bugs in ns_get_family and
6566 ns_descriptor_to_entity that were caused by using free to
6567 deallocate memory blocks that were allocated by xmalloc (via
6568 xstrdup). This caused Emacs to crash when compiled with
6569 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6570 --enable-checking=xmallocoverrun). xfree is now used to
6571 deallocate these memory blocks.
6572
4170f62f 65732011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6574
71b41406
PE
6575 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6576
9587a89d
PE
6577 emacs_write: Accept and return EMACS_INT for sizes.
6578 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6579 et seq.
6580 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6581 Accept and return EMACS_INT.
6582 (emacs_gnutls_write): Return the number of bytes written on
6583 partial writes.
6584 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6585 (emacs_read, emacs_write): Remove check for negative size, as the
6586 Emacs source code has been audited now.
9587a89d
PE
6587 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6588 (emacs_read, emacs_write): Use it.
273a5f82
PE
6589 * process.c (send_process): Adjust to the new signatures of
6590 emacs_write and emacs_gnutls_write. Do not attempt to store
6591 a byte offset into an 'int'; it might overflow.
9587a89d 6592 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6593
3e047f51
PE
6594 * sound.c: Don't assume sizes fit in 'int'.
6595 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6596 Return EMACS_INT, not int.
3e047f51 6597 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6598 Accept EMACS_INT, not int.
6599 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6600 record read return values.
6601
cc39a9db
BK
66022011-04-15 Ben Key <bkey76@gmail.com>
6603
c9d0ec6d
JB
6604 * keyboard.c (Qundefined): Don't declare static since it is used
6605 in nsfns.m.
6606 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6607 static since they are used in nsfont.m.
cc39a9db 6608
6c60eb9f
SM
66092011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6610
6611 * process.c (Qprocessp): Don't declare static.
6612 * lisp.h (Qprocessp): Declare again.
6613
7990b61a
JB
66142011-04-15 Juanma Barranquero <lekktu@gmail.com>
6615
6616 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6617
5d4cb038
PE
66182011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6619
8bd7b830 6620 Improve C-level modularity by making more things 'static'.
cd64ea1d 6621
e3b27b31
PE
6622 Don't publish debugger-only interfaces to other modules.
6623 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6624 (verify_bytepos, count_markers): Move decls to the only modules
6625 that need them.
6626 * region-cache.h (pp_cache): Likewise.
6627 * window.h (check_all_windows): Likewise.
6628 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6629
5d4cb038
PE
6630 * sysdep.c (croak): Now static, if
6631 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6632 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6633
6634 * alloc.c (refill_memory_reserve): Now static if
6635 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6636 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6637
e87b6180
PE
6638 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6639 Define only if USE_LUCID.
6640
ac64929e
PE
6641 * xrdb.c (x_customization_string, x_rm_string): Now static.
6642
6f37259d
PE
6643 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6644 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6645
1683e3ab
PE
6646 * xdisp.c (draw_row_with_mouse_face): Now static.
6647 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6648
de9c2632
PE
6649 * window.h (check_all_windows): Mark externally visible.
6650
2b96acb7
PE
6651 * window.c (window_deletion_count): Now static.
6652
6653 * undo.c: Make symbols static if they're not exported.
6654 (last_undo_buffer, last_boundary_position, pending_boundary):
6655 Now static.
6656
50436f33
PE
6657 * textprop.c (interval_insert_behind_hooks): Now static.
6658 (interval_insert_in_front_hooks): Likewise.
6659
64520e5c
PE
6660 * term.c: Make symbols static if they're not exported.
6661 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6662 (max_frame_lines, tty_set_terminal_modes):
6663 (tty_reset_terminal_modes, tty_turn_off_highlight):
6664 (get_tty_terminal): Now static.
6665 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6666 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6667 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6668 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6669 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6670
1fa53021
PE
6671 * sysdep.c: Make symbols static if they're not exported.
6672 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6673 Now static.
6674 (sigprocmask_set, full_mask): Remove; unused.
6675 (wait_debugging): Mark as visible.
6676 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6677 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6678
d4b43b22
PE
6679 * syntax.c (syntax_temp): Define only if !__GNUC__.
6680
b7c513d0
PE
6681 * sound.c (current_sound_device, current_sound): Now static.
6682
989b29ad
PE
6683 * search.c (searchbufs, searchbuf_head): Now static.
6684
13a55a78
PE
6685 * scroll.c (scroll_cost): Remove; unused.
6686 * dispextern.h (scroll_cost): Remove decl.
6687
de68a1fc
PE
6688 * region-cache.h (pp_cache): Mark as externally visible.
6689
40ccffa6
PE
6690 * process.c: Make symbols static if they're not exported.
6691 (process_tick, update_tick, create_process, chan_process):
6692 (Vprocess_alist, proc_buffered_char, datagram_access):
6693 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6694 (deactivate_process): Mark defn as static, as well as decl.
6695 * lisp.h (create_process): Remove decl.
6696 * process.h (chan_process, Vprocess_alist): Remove decls.
6697
ad64fc97
PE
6698 * print.c: Make symbols static if they're not exported.
6699 (print_depth, new_backquote_output, being_printed, print_buffer):
6700 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6701 (print_interval, print_number_index, initial_stderr_stream):
6702 Now static.
6703 * lisp.h (Fprinc): Remove decl.
6704 (debug_output_compilation_hack): Mark as externally visible.
6705
adddb265
PE
6706 * sysdep.c (croak): Move decl from here to syssignal.h.
6707 * syssignal.h (croak): Put it here, so the API can be checked when
6708 'croak' is called from dissociate_if_controlling_tty.
6709
1717ede2
PE
6710 * minibuf.c: Make symbols static if they're not exported.
6711 (minibuf_save_list, choose_minibuf_frame): Now static.
6712 * lisp.h (choose_minibuf_frame): Remove decl.
6713
fa5fb2bc
PE
6714 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6715
1e3890d1
PE
6716 * lread.c: Make symbols static if they're not exported.
6717 (read_objects, initial_obarray, oblookup_last_bucket_number):
6718 Now static.
6719 (make_symbol): Remove; unused.
6720 * lisp.h (initial_obarray, make_symbol): Remove decls.
6721
8a1414fa
PE
6722 * keyboard.c: Make symbols static if they're not exported.
6723 (single_kboard, recent_keys_index, total_keys, recent_keys):
6724 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6725 (this_single_command_key_start, echoing, last_auto_save):
6726 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6727 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6728 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6729 (Vlispy_mouse_stem, double_click_count):
6730 Now static.
6731 (force_auto_save_soon): Define only if SIGDANGER.
6732 (ignore_mouse_drag_p): Now static if
6733 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6734 (print_help): Remove; unused.
6735 (stop_character, last_timer_event): Mark as externally visible.
6736 * keyboard.h (ignore_mouse_drag_p): Declare only if
6737 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6738 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6739 * lisp.h (echoing): Remove decl.
6740 (force_auto_save_soon): Declare only if SIGDANGER.
6741 * xdisp.c (redisplay_window): Simplify code, to make it more
6742 obvious that ignore_mouse_drag_p is not accessed if !defined
6743 USE_GTK && !defined HAVE_NS.
6744
93ea6e8f
PE
6745 * intervals.c: Make symbols static if they're not exported.
6746 (merge_properties_sticky, merge_interval_right, delete_interval):
6747 Now static.
6748 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6749
77382fcc
PE
6750 * insdel.c: Make symbols static if they're not exported.
6751 However, leave prepare_to_modify_buffer alone. It's never
6752 called from outside this function, but that appears to be a bug.
6753 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6754 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6755 (adjust_after_replace_noundo): Remove; unused.
6756 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6757 (signal_before_change): Remove decls.
77382fcc 6758
9306c32e
PE
6759 * indent.c (val_compute_motion, val_vmotion): Now static.
6760
cd44d2eb
PE
6761 * image.c: Make symbols static if they're not exported.
6762 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6763 if USE_GTK.
6764 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6765 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6766
ad9a7a06
PE
6767 * fringe.c (standard_bitmaps): Now static.
6768 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6769
81626931
PE
6770 * frame.c: Make symbols static if they're not exported.
6771 (x_report_frame_params, make_terminal_frame): Now static.
6772 (get_frame_param): Now static, unless HAVE_NS.
6773 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6774 (x_get_resource_string): Remove; not used.
6775 * frame.h (make_terminal_frame, x_report_frame_params):
6776 (x_get_resource_string); Remove decls.
6777 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6778 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6779
239f9db9
PE
6780 * font.c, fontset.c: Make symbols static if they're not exported.
6781 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6782 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6783 * font.c (font_close_object): Now static.
6784 * font.h (font_close_object): Remove.
6785 * fontset.c (FONTSET_OBJLIST): Remove.
6786 (free_realized_fontset) #if-0 the body, which does nothing.
6787 (face_suitable_for_char_p): #if-0, as it's never called.
6788 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6789 * xfaces.c (face_at_string_position):
6790 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6791 since 0 is always ASCII.
6792
dfcf3579
PE
6793 * fns.c (weak_hash_tables): Now static.
6794
5045092b
PE
6795 * fileio.c: Make symbols static if they're not exported.
6796 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6797 (Vwrite_region_annotation_buffers): Now static.
6798
57a96f5c
PE
6799 * eval.c: Make symbols static if they're not exported.
6800 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6801 * lisp.h (backtrace_list): Remove decl.
6802
35f08c38
PE
6803 * emacs.c: Make symbols static if they're not exported.
6804 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6805 (fatal_error_code, fatal_error_signal_hook, standard_args):
6806 Now static.
6807 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6808 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6809 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6810 * lisp.h (fatal_error_signal_hook): Remove decl.
6811 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6812
f44bd759
PE
6813 * editfns.c: Move a (normally-unused) function to its only use.
6814 * editfns.c, lisp.h (get_operating_system_release): Remove.
6815 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6816 worth the hassle of breaking this out.
6817
b532497d
PE
6818 * xterm.c: Make symbols static if they're not exported.
6819 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6820 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6821 (x_destroy_window, x_delete_display):
6822 Now static.
6823 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6824 (x_mouse_leave): Remove; unused.
6825 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6826 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6827 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6828 Remove decls.
6829 (x_mouse_leave): Declare only if WINDOWSNT.
6830 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6831 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6832 USE_X_TOOLKIT.
6833
1675728f
PE
6834 * ftxfont.c: Make symbols static if they're not exported.
6835 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6836 HAVE_FREETYPE.
6837 * font.h (ftxfont_driver): Likewise.
6838
e4cebfca
PE
6839 * xfns.c: Make symbols static if they're not exported.
6840 (x_last_font_name, x_display_info_for_name):
6841 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6842 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6843 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6844 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6845 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6846 (last_show_tip_args): Now static.
6847 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6848 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6849 (x_screen_planes): Remove; unused.
6850 * dispextern.h (x_screen_planes): Remove decl.
6851
5bf46f05
PE
6852 * dispnew.c: Make symbols static if they're not exported.
6853 * dispextern.h (redraw_garbaged_frames, scrolling):
6854 (increment_row_positions): Remove.
6855 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6856 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6857 Now static.
6858 (redraw_garbaged_frames): Remove; unused.
6859
435f4c28
PE
6860 * xfaces.c: Make symbols static if they're not exported.
6861 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6862 Remove decls.
6863 * xterm.h (defined_color): Remove decls.
6864 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6865 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6866 (menu_face_changed_default, defined_color, free_realized_face):
6867 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6868 (ascii_face_of_lisp_face): Remove; unused.
6869
8524aef3
PE
6870 * xdisp.c: Make symbols static if they're not exported.
6871 * dispextern.h (scratch_glyph_row, window_box_edges):
6872 (glyph_to_pixel_coords, set_cursor_from_row):
6873 (get_next_display_element, set_iterator_to_next):
6874 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6875 (show_mouse_face): Remove decls
6876 * frame.h (message_buf_print): Likewise.
6877 * lisp.h (pop_message, set_message, check_point_in_composition):
6878 Likewise.
6879 * xterm.h (set_vertical_scroll_bar): Likewise.
6880 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6881 (message_buf_print, scratch_glyph_row, displayed_buffer):
6882 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6883 (get_next_display_element, show_mouse_face, window_box_edges):
6884 (frame_to_window_pixel_xy, check_point_in_composition):
6885 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6886 (glyph_to_pixel_coords): Remove; unused.
6887
16390cd2
PE
6888 * dired.c (file_name_completion): Now static.
6889
6890 * dbusbind.c (xd_in_read_queued_messages): Now static.
6891
a25f4dfa
PE
6892 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6893 * data.c (circular_list_error): Remove.
6894
14a9c8df
PE
6895 * commands.h (last_point_position, last_point_position_buffer):
6896 (last_point_position_window): Remove decls.
6897 * keyboard.c: Make these variables static.
6898
04f2d78b
CB
6899 * coding.h (coding, code_convert_region, encode_coding_gap):
6900 Remove decls.
74ab6df5
PE
6901 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6902 (iso_code_class, detect_coding, code_convert_region): Now static.
6903 (encode_coding_gap): Remove; unused.
6904
38dfbee1
PE
6905 * chartab.c (chartab_chars, chartab_bits): Now static.
6906
a2cb4e63
PE
6907 * charset.h (charset_iso_8859_1): Remove decl.
6908 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6909 Now static.
6910
127198fd
PE
6911 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6912 * ccl.c (Vccl_program_table): Now static.
6913 (check_ccl_update): Remove; unused.
6914
d85b608f
PE
6915 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6916 * category.h: ... from here.
6917 * category.c (check_category_table, set_category_set): Now static.
6918
31cd66f3
PE
6919 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6920 * lisp.h: Remove these decls.
6921
c358e587
PE
6922 * buffer.c (buffer_count): Remove unused var.
6923
e78aecca
PE
6924 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6925 so that it's not optimized away.
6926 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6927 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6928 exported only to the debugger.
6929
e192d7d3 6930 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6931 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6932
92470028
PE
6933 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6934 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6935 was inaccessible from Lisp.
6936 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6937 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6938
244ed907
PE
6939 alloc.c: Import and export fewer symbols, and remove unused items.
6940 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6941 is defined.
6942 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6943 it's not optimized away by whole-program optimization.
6944 (message_enable_multibyte, free_misc): Remove.
6945 (catchlist, handlerlist, mark_backtrace):
6946 Declare only if BYTE_MARK_STACK.
6947 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6948 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6949 (message_enable_multibyte): Remove decl.
6950 (free_misc, interval_free_list, float_block, float_block_index):
6951 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6952 (cons_free_list, last_marked_index):
6953 Now static.
6954 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6955 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6956 (mark_backtrace): Define only if BYTE_MARK_STACK.
6957 * xdisp.c (message_enable_multibyte): Now static.
6958
61c2b50e 6959 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6960 This makes it easier for human readers (and static analyzers)
6961 to see whether these variables are used from other modules.
6962 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6963 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6964 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6965 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6966 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6967 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6968 * xmenu.c, xselect.c:
6969 Declare Q* vars static if they are not used in other modules.
6970 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6971 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6972 Remove decls of unexported vars.
6973 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6974
95c82688
PE
6975 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6976
16a97296
PE
6977 Make Emacs functions such as Fatom 'static' by default.
6978 This makes it easier for human readers (and static analyzers)
6979 to see whether these functions can be called from other modules.
6980 DEFUN now defines a static function. To make the function external
6981 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6982 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6983 (Finit_image_library):
16a97296
PE
6984 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6985 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6986 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6987 Remove decls, since these functions are now static.
6988 (Funintern, Fget_internal_run_time): New decls, since these functions
6989 were already external.
95c82688 6990
16a97296
PE
6991 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6992 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6993 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6994 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6995 * keyboard.c, keymap.c, lread.c:
6996 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6997 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6998 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6999 Mark functions with DEFUE instead of DEFUN,
7000 if they are used in other modules.
7001 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7002 decls for now-static functions.
7003 * buffer.h (Fdelete_overlay): Remove decl.
7004 * callproc.c (Fgetenv_internal): Mark as internal.
7005 * composite.c (Fremove_list_of_text_properties): Remove decl.
7006 (Fcomposition_get_gstring): New forward static decl.
7007 * composite.h (Fcomposite_get_gstring): Remove decl.
7008 * dired.c (Ffile_attributes): New forward static decl.
7009 * doc.c (Fdocumntation_property): New forward static decl.
7010 * eval.c (Ffetch_bytecode): New forward static decl.
7011 (Funintern): Remove extern decl; now in .h file where it belongs.
7012 * fileio.c (Fmake_symbolic_link): New forward static decl.
7013 * image.c (Finit_image_library): New forward static decl.
7014 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7015 * intervals.h (Fprevious_property_change):
7016 (Fremove_list_of_text_properties): Remove decls.
7017 * keyboard.c (Fthis_command_keys): Remove decl.
7018 (Fcommand_execute): New forward static decl.
7019 * keymap.c (Flookup_key): New forward static decl.
7020 (Fcopy_keymap): Now static.
7021 * keymap.h (Flookup_key): Remove decl.
7022 * process.c (Fget_process): New forward static decl.
7023 (Fprocess_datagram_address): Mark as internal.
7024 * syntax.c (Fsyntax_table_p): New forward static decl.
7025 (skip_chars): Remove duplicate decl.
7026 * textprop.c (Fprevious_property_change): New forward static decl.
7027 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7028 Now internal.
7029 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7030 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7031
785bbd42
PE
7032 * editfns.c (Fformat): Remove unreachable code.
7033
8b913b57
AS
70342011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7035
7036 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7037 change. (Bug#8496)
7038
a6744a35
EZ
70392011-04-13 Eli Zaretskii <eliz@gnu.org>
7040
7041 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7042 when at ZV. (Bug#8487)
7043
e7974947
AS
70442011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7045
baad03f0
AS
7046 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7047 (Bug#8437)
7048 * keyboard.c (parse_tool_bar_item): Likewise.
7049 * sound.c (sound_cleanup, alsa_close): Likewise.
7050 * termcap.c (tgetent): Likewise.
7051 * xfns.c (x_default_font_parameter): Likewise.
7052 * xsettings.c (read_and_apply_settings): Likewise.
7053
e7974947
AS
7054 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7055 (overrun_check_free): Protoize.
7056
28272684
PE
70572011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7058
7059 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7060 since callers should never pass a negative size.
7061 Change the signature to match that of plain 'read' and 'write'; see
7062 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7063 * lisp.h: Update prototypes of emacs_write and emacs_read.
7064
11997c76
EZ
70652011-04-11 Eli Zaretskii <eliz@gnu.org>
7066
7067 * xdisp.c (redisplay_window): Don't try to determine the character
7068 position of the scroll margin if the window start point w->startp
e896f03c 7069 is outside the buffer's accessible region. (Bug#8468)
11997c76 7070
8a2cbd72
EZ
70712011-04-10 Eli Zaretskii <eliz@gnu.org>
7072
7073 Fix write-region and its subroutines for buffers > 2GB.
7074 * fileio.c (a_write, e_write): Modify declaration of arguments and
7075 local variables to support buffers larger than 2GB.
7076 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7077
7078 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7079 argument, local variables, and return value.
7080
7081 * lisp.h: Update prototypes of emacs_write and emacs_read.
7082
7083 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7084
4073e537 70852011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7086
1ebfdcb6
PE
7087 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7088
b2ded58d
PE
7089 Fix more problems found by GCC 4.6.0's static checks.
7090
7d66342c
PE
7091 * xdisp.c (vmessage): Use a better test for character truncation.
7092
bbf47d44
PE
7093 * charset.c (load_charset_map): <, not <=, for optimization,
7094 and to avoid potential problems with integer overflow.
9248994d 7095 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7096 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7097 * editfns.c (Fformat): Likewise.
1e69125e 7098 * syntax.c (skip_chars): Likewise.
3befa583 7099
e3019616
PE
7100 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7101 This also lets GCC 4.6.0 generate slightly better loop code.
7102
becfa255
PE
7103 * callint.c (Fcall_interactively): <, not <=, for optimization.
7104 (Fcall_interactively): Count the number of arguments produced,
7105 not the number of arguments given. This is simpler and lets GCC
7106 4.6.0 generate slightly better code.
7107
dae0cd48
PE
7108 * ftfont.c: Distingish more carefully between FcChar8 and char.
7109 The previous code passed unsigned char * to a functions like
7110 strlen and xstrcasecmp that expect char *, which does not
7111 conform to the C standard.
7112 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7113 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7114 char * when the C standard requires it.
7115
76032d70
PE
7116 * keyboard.c (read_char): Remove unused var.
7117
eb3f1cc8
PE
7118 * eval.c: Port to Windows vsnprintf (Bug#8435).
7119 Include <limits.h>.
7120 (SIZE_MAX): Define if the headers do not.
7121 (verror): Do not give up if vsnprintf returns a negative count.
7122 Instead, grow the buffer. This ports to Windows vsnprintf, which
7123 does not conform to C99. Problem reported by Eli Zaretskii.
7124 Also, simplify the allocation scheme, by avoiding the need for
7125 calling realloc, and removing the ALLOCATED variable.
7126
70476b54
PE
7127 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7128
12020a9e
PE
7129 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7130 But keep the doprint source code for now, as we might revamp it
7131 and use it again (Bug#8435).
ea6c7ae6
PE
7132 * lisp.h (doprnt): Remove.
7133 * Makefile.in (base_obj): Remove doprnt.o.
7134 * deps.mk (doprnt.o): Remove.
7135
5fdb398c
PE
7136 error: Print 32- and 64-bit integers portably (Bug#8435).
7137 Without this change, on typical 64-bit hosts error ("...%d...", N)
7138 was used to print both 32- and 64-bit integers N, which relied on
7139 undefined behavior.
7140 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7141 New macro.
7142 * lisp.h (error, verror): Mark as printf-like functions.
7143 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7144 Report overflow in size calculations when allocating printf buffer.
7145 Do not truncate output string at its first null byte.
7146 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7147 Truncate the output at a character boundary, since vsnprintf does not
7148 do that.
7149 * charset.c (check_iso_charset_parameter): Convert internal
7150 character to string before calling 'error', since %c now has the
7151 printf meaning.
7152 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7153 overflow when computing char to be passed to 'error'. Do not
7154 pass Lisp_Object to 'error'; pass the integer instead.
7155 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7156 formatted with plain %d.
7157
b189fa66
PE
7158 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7159
bff87ef0
PE
7160 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7161
7e2cac20
PE
7162 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7163
ce4d90b5
PE
7164 * xterm.c (x_catch_errors): Remove duplicate declaration.
7165
266c9547
PE
7166 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7167
79c49ad2
PE
7168 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7169
368f4090
JM
71702011-04-10 Jim Meyering <meyering@redhat.com>
7171
7172 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7173 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7174 return ssize_t not "int", and use size_t as the buffer length.
7175 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7176 * gnutls.h: Update declarations.
7177 * process.c (read_process_output): Use ssize_t, to match.
7178 (send_process): Likewise.
7179
a32d4040
CY
71802011-04-09 Chong Yidong <cyd@stupidchicken.com>
7181
7182 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7183
8546720e 71842011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7185
04f2d78b
CB
7186 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7187 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7188
8546720e
GM
7189 * xterm.c (handle_one_xevent):
7190 * xmenu.c (create_and_show_popup_menu):
7191 * xselect.c (x_decline_selection_request)
7192 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7193
0a2f5c1a 71942011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7195
7196 Fix some uses of `int' instead of EMACS_INT.
7197 * search.c (string_match_1, fast_string_match)
7198 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7199 (scan_buffer, find_next_newline_no_quit)
7200 (find_before_next_newline, search_command, Freplace_match)
7201 (Fmatch_data): Make some `int' variables be EMACS_INT.
7202
7203 * xdisp.c (display_count_lines): 3rd argument and return value now
7204 EMACS_INT. All callers changed.
7205 (pint2hrstr): Last argument is now EMACS_INT.
7206
7207 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7208 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7209 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7210 (decode_coding_utf_16, decode_coding_emacs_mule)
7211 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7212 (decode_coding_ccl, decode_coding_charset)
7213 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7214 (decode_coding_iso_2022, decode_coding_emacs_mule)
7215 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7216 <char_offset, last_offset>: Declare EMACS_INT.
7217 (encode_coding_utf_8, encode_coding_utf_16)
7218 (encode_coding_emacs_mule, encode_invocation_designation)
7219 (encode_designation_at_bol, encode_coding_iso_2022)
7220 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7221 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7222 Declare EMACS_INT.
7223 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7224 (encode_invocation_designation): Last argument P_NCHARS is now
7225 EMACS_INT.
7226 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7227 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7228
7229 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7230 All users changed.
7231
7232 * ccl.c (Fccl_execute_on_string): Declare some variables
7233 EMACS_INT.
7234
8546720e 72352011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7236
7237 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7238
4e19a977
CS
72392011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7240
7241 * process.c (Fformat_network_address): Doc fix.
7242
87302331
R
72432011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7244
ee7683eb 7245 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7246
cbb59342
CY
72472011-04-08 Chong Yidong <cyd@stupidchicken.com>
7248
7249 * keyboard.c (read_char): Call Lisp function help-form-show,
7250 instead of using internal_with_output_to_temp_buffer.
7251 (Qhelp_form_show): New var.
e0d38eeb 7252 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7253
7254 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7255
7256 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7257
e67a13ab
CY
72582011-04-06 Chong Yidong <cyd@stupidchicken.com>
7259
04f2d78b
CB
7260 * process.c (Flist_processes): Remove to Lisp.
7261 (list_processes_1): Delete.
e67a13ab 7262
973f782d
EZ
72632011-04-06 Eli Zaretskii <eliz@gnu.org>
7264
7c106b1e
EZ
7265 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7266
973f782d
EZ
7267 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7268
41cf7d1a 72692011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7270
ca23cc88
PE
7271 Fix more problems found by GCC 4.6.0's static checks.
7272
f390e2d5
PE
7273 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7274
42eea0d0
PE
7275 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7276
b69769da 7277 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7278
f9541e84
PE
7279 * xdisp.c (vmessage): Mark as a printf-like function.
7280
13841b55
PE
7281 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7282
c136c10f
PE
7283 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7284
5e2d4a30
PE
7285 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7286 printf-like functions.
7287 (tiff_load): Add casts to remove these marks before passing them
7288 to system-supplied API.
7289
583f48b9
PE
7290 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7291
b25d760e
PE
7292 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7293 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7294 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7295 directly, rather than having caller test rule sign. This avoids
7296 some unnecessary tests.
7297 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7298 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7299 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7300
bc7b6697 7301 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7302 (xfont_open): Avoid unnecessary tests.
bc7b6697 7303
27ccc379
PE
7304 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7305
dcd5c89a
PE
7306 * composite.h, composite.c (composition_gstring_put_cache):
7307 Use EMACS_INT, not int, for length.
7308
b13a45c6
PE
7309 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7310 breaking out part of COMPOSITION_DECODE_RULE.
7311 (COMPOSITION_DECODE_RULE): Use it.
7312 * composite.c (get_composition_id): Remove unused local vars,
7313 by using the new macro.
7314
1e792e4d
PE
7315 * textprop.c (set_text_properties_1): Change while to do-while,
7316 since the condition is always true at first.
7317
dc6c6455 7318 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7319 (interval_deletion_adjustment): Return unsigned value.
7320 All uses changed.
dc6c6455 7321
aba7731a
PE
7322 * process.c (list_processes_1, create_pty, read_process_output):
7323 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7324 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7325 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7326 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7327 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7328
fdfc4bf3
PE
7329 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7330
fca8fe46 7331 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7332 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7333
06a0259a 7334 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7335 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7336 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7337
e7b9e80f
PE
7338 * print.c (print_error_message): Avoid int overflow.
7339
56201685
PE
7340 * font.c (font_list_entities): Redo for clarity,
7341 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7342
78834453 7343 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7344 (font_score): Avoid potential overflow in diff calculation.
78834453 7345
0bc0b309 7346 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7347 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7348
e610eaca
PE
7349 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7350
b895abce
PE
7351 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7352 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7353 can always succeed if overflow has undefined behavior.
7354
1f1d9321 7355 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7356 (wordify): Omit three unnecessary tests.
1f1d9321 7357
c59478bc
PE
7358 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7359 All callers changed. This avoids the need for an unused var.
7360
79b73827
PE
7361 * casefiddle.c (casify_region): Remove var that is set but not used.
7362
a4db5dfe
PE
7363 * dired.c (file_name_completion): Remove var that is set but not used.
7364
43aae36e
PE
7365 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7366
2a47c44d 7367 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7368 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7369
a37c69bf
PE
7370 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7371 Check for integer overflow on size calculations.
7372
328ab8e7
PE
7373 * buffer.c (Fprevious_overlay_change): Remove var that is set
7374 but not used.
7375
e5a2a5cb
PE
7376 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7377 Remove vars that are set but not used.
8d84a6eb 7378 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7379 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7380
a60e5f68
PE
7381 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7382
f661cb61 7383 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7384 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7385
f0397f5a
PE
7386 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7387 that are set but not used.
7388
8664db06 7389 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7390 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7391
6abdaa4a
PE
7392 * xselect.c (x_get_local_selection, x_handle_property_notify):
7393 Remove vars that are set but not used.
7394
0ce7538d 7395 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7396 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7397
9ae848fc
PE
7398 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7399 Remove var that is set but not used.
0b918413
PE
7400 (scroll_bar_windows_size): Now size_t, not int.
7401 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7402 Check for overflow.
9ae848fc 7403
a5a62657
PE
7404 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7405 (map_tty_color) [!defined MSDOS]: Likewise.
7406
5c5cdd39
PE
7407 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7408
66ebf983
PE
7409 * coding.c: Remove vars that are set but not used.
7410 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7411 All callers changed.
7412 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7413 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7414 (decode_coding_charset): Remove vars that are set but not used.
7415
1be4d761
PE
7416 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7417 that is set but not used.
7418
47553fa8
PE
7419 * print.c (print_object): Remove var that is set but not used.
7420
1f7196bf 7421 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7422 The gnulib version avoids calling malloc in the usual case,
7423 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7424 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7425 * filelock.c (current_lock_owner): Likewise.
7426 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7427 * sysdep.c: Include allocator.h, careadlinkat.h.
7428 (emacs_no_realloc_allocator): New static constant.
7429 (emacs_readlink): New function.
fdb61804
PE
7430 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7431 ../lib/careadlinkat.h.
d1fdcab7 7432
f84c17c7
SM
74332011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7434
7435 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7436 first non-nil return value).
7437
ef3862ad
JD
74382011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7439
7440 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7441 if not defined (Bug#8403).
7442
376a7006
JB
74432011-04-02 Juanma Barranquero <lekktu@gmail.com>
7444
7445 * xdisp.c (display_count_lines): Remove parameter `start',
7446 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7447 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7448 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7449 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7450 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7451 and thereabouts. All callers changed.
7452 (get_per_char_metric): Remove parameter `f', unused since
7453 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7454
6ca3801d
JM
74552011-04-02 Jim Meyering <meyering@redhat.com>
7456
7457 do not dereference NULL upon failed strdup
7458 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7459 (ns_get_family): Likewise.
7460
d8e2b5ba
JB
74612011-04-02 Juanma Barranquero <lekktu@gmail.com>
7462
7463 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7464
8c74fcbd
JD
74652011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7466
7467 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7468 later (Bug#8403).
7469
7200d79c
SM
74702011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7471
03408648 7472 Add lexical binding.
7200d79c 7473
03408648
SM
7474 * window.c (Ftemp_output_buffer_show): New fun.
7475 (Fsave_window_excursion):
7476 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7477
7478 * lread.c (lisp_file_lexically_bound_p): New function.
7479 (Fload): Bind Qlexical_binding.
7480 (readevalloop): Remove `evalfun' arg.
7481 Bind Qinternal_interpreter_environment.
7482 (Feval_buffer): Bind Qlexical_binding.
7483 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7484 Mark as dynamic.
7485 (syms_of_lread): Declare `lexical-binding'.
7486
7487 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7488
7489 * keyboard.c (eval_dyn): New fun.
7490 (menu_item_eval_property): Use it.
ca105506
SM
7491
7492 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7493
03408648
SM
7494 * fns.c (concat, mapcar1): Accept byte-code-functions.
7495
7496 * eval.c (Fsetq): Handle lexical vars.
7497 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7498 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7499 (FletX, Flet): Obey lexical binding.
7500 (Fcommandp): Handle closures.
7501 (Feval): New `lexical' arg.
7502 (eval_sub): New function extracted from Feval. Use it almost
7503 everywhere where Feval was used. Look up vars in lexical env.
7504 Handle closures.
7505 (Ffunctionp): Move from subr.el.
7506 (Ffuncall): Handle closures.
7507 (apply_lambda): Remove `eval_flags'.
7508 (funcall_lambda): Handle closures and new byte-code-functions.
7509 (Fspecial_variable_p): New function.
7510 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7511 but without exporting it to Lisp.
23aba0ea 7512
23aba0ea 7513 * doc.c (Fdocumentation, store_function_docstring):
03408648 7514 * data.c (Finteractive_form): Handle closures.
23aba0ea 7515
03408648
SM
7516 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7517 interactive spec.
ba83908c 7518
04f2d78b
CB
7519 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7520 New byte-codes.
03408648
SM
7521 (exec_byte_code): New function extracted from Fbyte_code to handle new
7522 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7523
03408648 7524 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7525
03408648 7526 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7527
e2abce01
JB
75282011-03-31 Juanma Barranquero <lekktu@gmail.com>
7529
7530 * xdisp.c (redisplay_internal): Fix prototype.
7531
63696a73 75322011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7533
63696a73 7534 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7535 (try_scrolling): Use it when setting scroll_limit.
7536 Limit scrolling to 100 screen lines.
63696a73
EZ
7537 (redisplay_window): Even when falling back on "recentering",
7538 position point in the window according to scroll-conservatively,
7539 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7540
7541 (try_scrolling): When point is above the window, allow searching
7542 as far as scroll_max, or one screenful, to compute vertical
7543 distance from PT to the scroll margin position. This prevents
7544 try_scrolling from unnecessarily failing when
7545 scroll-conservatively is set to a value slightly larger than the
7546 window height. Clean up the case of PT below the margin at bottom
7547 of window: scroll_max can no longer be INT_MAX. When aggressive
7548 scrolling is in use, don't let point enter the opposite scroll
7549 margin as result of the scroll.
7550 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7551 threshold of 100 lines for never-recentering scrolling.
7552
e4cc2dfc
JB
75532011-03-31 Juanma Barranquero <lekktu@gmail.com>
7554
7555 * dispextern.h (move_it_by_lines):
7556 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7557 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7558 (message_log_check_duplicate): Remove parameters `prev_bol' and
7559 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7560 (redisplay_internal): Remove parameter `preserve_echo_area',
7561 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7562
7563 * indent.c (Fvertical_motion):
7564 * window.c (window_scroll_pixel_based, Frecenter):
7565 Don't pass `need_y_p' to `move_it_by_lines'.
7566
1c470562
SM
75672011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7568
44f230aa
SM
7569 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7570 steal a few bits to be more compact.
7571 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7572 Remove unneeded casts.
7573
1c470562
SM
7574 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7575
888adce9
ZK
75762011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7577
7578 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7579 binding" message (bug#7967).
7580
f838ed7b
PE
75812011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7582
77861b95
PE
7583 Fix more problems found by GCC 4.6.0's static checks.
7584
de6dbc14
PE
7585 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7586 Remove unused local var.
7587
f838ed7b
PE
7588 * editfns.c (Fmessage_box): Remove unused local var.
7589
792c7b2b
PE
7590 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7591 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7592 Omit unused local vars.
c499e557 7593 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7594 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7595 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7596 Omit unused local var.
7597
ba0165e1
PE
7598 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7599 Don't assume string length fits in int.
32ad8845 7600 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7601 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7602
3c59b4c9
PE
7603 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7604 instead of alloca (Bug#8344).
7605
a3eed478 7606 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7607 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7608
eb4d412d
PE
7609 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7610
1658b401
PE
7611 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7612 concerns.
7613
7614 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7615
7616 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7617
9a2c6e05
PE
7618 * keyboard.c (syms_of_keyboard): Use the same style as later
7619 in this function when indexing through an array. This also
7620 works around GCC bug 48267.
7621
03d0a109
PE
7622 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7623
44f730c8
PE
7624 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7625
fe75f926
PE
7626 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7627 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7628
ffa8c828
PE
7629 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7630 This avoids undefined behavior on integer overflow, and is a bit
7631 more convenient anyway since it is compared to a size_t variable.
7632
c5101a77
PE
7633 Variadic C functions now count arguments with size_t, not int.
7634 This avoids an unnecessary limitation on 64-bit machines, which
7635 caused (substring ...) to crash on large vectors (Bug#8344).
7636 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7637 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7638 All variadic functions and their callers changed accordingly.
c5101a77
PE
7639 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7640 * data.c (arith_driver, float_arith_driver): Likewise.
7641 * editfns.c (general_insert_function): Likewise.
7642 * eval.c (struct backtrace.nargs, interactive_p)
7643 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7644 (funcall_lambda, mark_backtrace): Likewise.
7645 * fns.c (concat): Likewise.
7646 * frame.c (x_set_frame_parameters): Likewise.
7647 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7648 0 if not found, not -1. All callers changed.
7649
dd3f25f7
PE
7650 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7651 (stack_copy_size): Now size_t, not int.
7652 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7653
461c2ab9
JB
76542011-03-28 Juanma Barranquero <lekktu@gmail.com>
7655
7656 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7657 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7658 All callers changed.
7659
7660 * lisp.h (multibyte_char_to_unibyte):
7661 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7662 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7663 * character.h (CHAR_TO_BYTE8):
7664 * cmds.c (internal_self_insert):
7665 * editfns.c (general_insert_function):
7666 * keymap.c (push_key_description):
7667 * search.c (Freplace_match):
7668 * xdisp.c (message_dolog, set_message_1): All callers changed.
7669
f6d62986
SM
76702011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7671
7672 * keyboard.c (safe_run_hook_funcall): New function.
7673 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7674 don't set the hook to nil, but remove the offending function instead.
7675 (Qcommand_hook_internal): Remove, unused.
7676 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7677 Vcommand_hook_internal.
7678
7679 * eval.c (enum run_hooks_condition): Remove.
7680 (funcall_nil, funcall_not): New functions.
7681 (run_hook_with_args): Call each function through a `funcall' argument.
7682 Remove `cond' argument, now redundant.
7683 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7684 (Frun_hook_with_args_until_failure): Adjust accordingly.
7685 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7686
1db5b1ad
JB
76872011-03-28 Juanma Barranquero <lekktu@gmail.com>
7688
7689 * dispextern.h (string_buffer_position): Remove declaration.
7690
7691 * print.c (strout): Remove parameter `multibyte', unused since
7692 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7693
7694 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7695 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7696 All callers changed.
7697
7698 * w32.c (_wsa_errlist): Use braces for struct initializers.
7699
7700 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7701 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7702 All callers changed.
7703 (string_buffer_position): Likewise. Also, make static (it's never
7704 used outside xdisp.c).
7705 (cursor_row_p): Remove parameter `w', unused since
7706 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7707 (decode_mode_spec): Remove parameter `precision', introduced during
7708 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7709 All callers changed.
7710
5ffb62aa
JD
77112011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7712
7713 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7714
461c2ab9 77152011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7716
7717 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7718 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7719 (ns_update_auto_hide_menu_bar): New functions.
7720 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7721 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7722 ns_constrain_all_frames.
7723 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7724 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7725
5c380ffb
JD
77262011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7727
7728 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7729
9af30bdf
GM
77302011-03-27 Glenn Morris <rgm@gnu.org>
7731
7732 * syssignal.h: Replace RETSIGTYPE with void.
7733 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7734 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7735 Replace SIGTYPE with void everywhere.
7736 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7737 * s/template.h (SIGTYPE): Remove commented out definition.
7738
e2abce01
JB
77392011-03-26 Eli Zaretskii <eliz@gnu.org>
7740
7741 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7742 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7743
f868cd8a
JB
77442011-03-26 Juanma Barranquero <lekktu@gmail.com>
7745
59eb0929
JB
7746 * w32.c (read_unc_volume): Use parameter `henum', instead of
7747 global variable `wget_enum_handle'.
7748
7749 * keymap.c (describe_vector): Remove parameters `indices' and
7750 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7751 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7752
f868cd8a
JB
7753 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7754
7755 * keyboard.c (timer_check): Remove parameter `do_it_now',
7756 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7757 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7758 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7759
7760 * keyboard.c (read_char):
7761 * w32menu.c (w32_menu_display_help):
7762 * xmenu.c (show_help_event, menu_help_callback):
7763 Adjust calls to `show_help_echo'.
7764
7765 * gtkutil.c (xg_maybe_add_timer):
7766 * keyboard.c (readable_events):
7767 * process.c (wait_reading_process_output):
7768 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7769
7770 * insdel.c (adjust_markers_gap_motion):
7771 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7772 (gap_left, gap_right): Don't call it.
7773
2ecf6fdb
CY
77742011-03-25 Chong Yidong <cyd@stupidchicken.com>
7775
7776 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7777 incurred during fontification.
7778
6b1f9ba4
JB
77792011-03-25 Juanma Barranquero <lekktu@gmail.com>
7780
7781 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7782 (DEFVAR_PER_BUFFER): Don't pass it.
7783
7784 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7785 (scrolling_window): Don't pass it.
7786
0f4a96b5
JB
77872011-03-25 Juanma Barranquero <lekktu@gmail.com>
7788
7789 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7790
7791 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7792 and `suffix'.
7793 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7794 of variables specific to SELinux and computation of `encoded_absname'.
7795
7796 * image.c (XPutPixel): Remove unused variable `height'.
7797
7798 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7799
7800 * unexw32.c (get_section_info): Remove unused variable `section'.
7801
7802 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7803 (system_process_attributes): Remove unused variable `sess'.
7804 (sys_read): Remove unused variable `err'.
7805
7806 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7807 (w32_wnd_proc): Remove unused variable `isdead'.
7808 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7809 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7810 (x_create_tip_frame): Remove unused variable `tem'.
7811
7812 * w32inevt.c (w32_console_read_socket):
7813 Remove unused variable `no_events'.
7814
7815 * w32term.c (x_draw_composite_glyph_string_foreground):
7816 Remove unused variable `width'.
7817
1149507c
JB
78182011-03-24 Juanma Barranquero <lekktu@gmail.com>
7819
7820 * w32term.c (x_set_glyph_string_clipping):
7821 Don't pass uninitialized region to CombineRgn.
7822
9c88f339
JB
78232011-03-23 Juanma Barranquero <lekktu@gmail.com>
7824
7825 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7826 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7827 (Fx_close_connection): Remove unused variable `i'.
7828
7829 * w32font.c (w32font_draw): Return number of glyphs.
7830 (w32font_open_internal): Remove unused variable `i'.
7831 (w32font_driver): Add missing initializer.
7832
7833 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7834 (fill_in_menu): Remove unused variable `items_added'.
7835
7836 * w32term.c (last_mouse_press_frame): Remove static global variable.
7837 (w32_clip_to_row): Remove unused variable `f'.
7838 (x_delete_terminal): Remove unused variable `i'.
7839
7840 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7841 (NOTHING): Remove unused static global variable.
7842 (uniscribe_check_otf): Remove unused variable `table'.
7843 (uniscribe_font_driver): Add missing initializers.
7844
dee091a3
JD
78452011-03-23 Julien Danjou <julien@danjou.info>
7846
7847 * term.c (Fsuspend_tty, Fresume_tty):
7848 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7849 * window.c (temp_output_buffer_show):
7850 * insdel.c (signal_before_change):
7851 * frame.c (Fhandle_switch_frame):
7852 * fileio.c (Fdo_auto_save):
7853 * emacs.c (Fkill_emacs):
7854 * editfns.c (save_excursion_restore):
7855 * cmds.c (internal_self_insert):
7856 * callint.c (Fcall_interactively):
7857 * buffer.c (Fkill_all_local_variables):
7858 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7859 Use Frun_hooks.
0f4a96b5 7860 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 7861 unconditionally since it does the check itself.
dee091a3 7862
2c520ab5 78632011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7864
c9c49752
PE
7865 Fix more problems found by GCC 4.5.2's static checks.
7866
8abc3f12
PE
7867 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7868 the first time through the loop, since we know p0 < p1 then.
7869 This also avoids a gcc -Wstrict-overflow warning.
7870
a2d26660
PE
7871 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7872 leading to a memory leak, possible in functions like
7873 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7874 of objects (Bug#8318).
a2d26660 7875
916c72e9
PE
7876 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7877 that could (at least in theory) be that large.
7878
19ab8a18
PE
7879 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7880 This is less likely to overflow, and avoids undefined behavior if
7881 overflow does occur. All callers changed. Use strtoul to scan
7882 for the unsigned long integer.
b7cbbd6f
PE
7883 (pint2hrstr): Simplify and tune code slightly.
7884 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7885
f0641eff
PE
7886 * scroll.c (do_scrolling): Work around GCC bug 48228.
7887 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7888
7f650bb9
PE
7889 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7890 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7891 (validate_x_resource_name): Simplify count usage.
7892 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7893
37dd57d1
PE
7894 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7895 fail (Bug#8306).
81e56e61 7896
699979fc 7897 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7898
401bf9b4
PE
7899 * process.c (Fmake_network_process): Use socklen_t, not int,
7900 where POSIX says socklen_t is required in portable programs.
7901 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7902 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7903 (Fmake_network_process, server_accept_connection):
7904 (wait_reading_process_output, read_process_output):
7905 Likewise.
7906
b93aacde
PE
7907 * process.c: Rename or move locals to avoid shadowing.
7908 (list_processes_1, Fmake_network_process):
7909 (read_process_output_error_handler, exec_sentinel_error_handler):
7910 Rename or move locals.
4dc343ee 7911 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7912 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7913 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7914 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7915 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7916
af8a867c 7917 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7918 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7919 Include tparam.h instead, since it declares them.
af8a867c
PE
7920 * cm.h (PC): Remove extern decl; tparam.h now does this.
7921 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7922 * terminfo.c: Include tparam.h, to check interfaces.
7923 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7924 (tparam): Adjust signature to match interface in tparam.h;
7925 this removes some undefined behavior. Check that outstring and len
7926 are zero, which they always are with Emacs.
7927 * tparam.h (PC, BC, UP): New extern decls.
7928
0248044d 7929 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7930 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7931
8ff096c1 7932 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7933 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7934 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7935 (ftfont_list): Remove unused local.
49eaafba
PE
7936 (get_adstyle_property, ftfont_pattern_entity):
7937 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7938 Rename locals to avoid shadowing.
8ff096c1 7939
e2be39f6
PE
7940 * xfont.c (xfont_list_family): Mark var as initialized.
7941
c9735e30
PE
7942 * xml.c (make_dom): Now static.
7943
8f5201ae
PE
7944 * composite.c (composition_compute_stop_pos): Rename local to
7945 avoid shadowing.
b246f932
PE
7946 (composition_reseat_it): Remove unused locals.
7947 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7948 (composition_update_it): Mark var as initialized.
11b61122
PE
7949 (find_automatic_composition): Mark vars as initialized,
7950 with a FIXME (Bug#8290).
8f5201ae 7951
760fbc2c
PE
7952 character.h: Rename locals to avoid shadowing.
7953 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7954 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7955 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7956 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7957 to avoid shadowing.
7958
ff08eb85
PE
7959 * textprop.c (property_change_between_p): Remove; unused.
7960
fc7bf025
PE
7961 * intervals.c (interval_start_pos): Now static.
7962
235d7abc
PE
7963 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7964
44f230aa
SM
7965 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7966 Rename locals to avoid shadowing.
3e7d6594 7967
50060332
PE
7968 * sound.c (wav_play, au_play, Fplay_sound_internal):
7969 Fix pointer signedness.
d01f234b 7970 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7971 (wav_play): Initialize a variable to 0, to prevent undefined
7972 behavior (Bug#8278).
50060332 7973
c4fc4e30
PE
7974 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7975
918436ed
PE
7976 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7977
c939f91b
PE
7978 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7979 clobbering (Bug#8298).
b9c7f648
PE
7980 * sysdep.c (sys_subshell): Likewise.
7981 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7982
6bd8c144
PE
7983 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7984 This should get cleaned up, so that child_setup has the
7985 same signature on all platforms.
7986
7710357c 7987 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7988 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7989
c59da222
CY
79902011-03-22 Chong Yidong <cyd@stupidchicken.com>
7991
7992 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7993 not to be necessary, and produces flickering.
7994
66b87493
GM
79952011-03-20 Glenn Morris <rgm@gnu.org>
7996
7997 * config.in: Remove file.
7998
45b6f6d5
JB
79992011-03-20 Juanma Barranquero <lekktu@gmail.com>
8000
8001 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8002 are now in src/globals.h.
8003 (syms_of_minibuf): Remove spurious & from previous change.
8004
3ec03f7e
LL
80052011-03-20 Leo <sdl.web@gmail.com>
8006
8007 * minibuf.c (completing-read-function): New variable.
8008 (completing-read-default): Rename from completing-read.
8009 (completing-read): Call completing-read-function.
8010
b14e3e21
CY
80112011-03-19 Juanma Barranquero <lekktu@gmail.com>
8012
8013 * xfaces.c (Fx_load_color_file):
8014 Read color file from absolute filename (bug#8250).
8015
f2b726e6
JB
80162011-03-19 Juanma Barranquero <lekktu@gmail.com>
8017
8018 * makefile.w32-in: Update dependencies.
8019
09f6ff02
EZ
80202011-03-17 Eli Zaretskii <eliz@gnu.org>
8021
8022 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8023
29a6015a
PE
80242011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8025
a3a6c54e
PE
8026 Fix more problems found by GCC 4.5.2's static checks.
8027
b766f867
PE
8028 * process.c (make_serial_process_unwind, send_process_trap):
8029 (sigchld_handler): Now static.
8030
be02381c
PE
8031 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8032 That way, the code declares only the vars that it needs.
8033 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8034 * s/cygwin.h (PTY_ITERATION): Likewise.
8035 * s/darwin.h (PTY_ITERATION): Likewise.
8036 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8037
57048744
PE
8038 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8039 * process.c (allocate_pty): Don't declare stb unless it's needed.
8040
7914961c 8041 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8042 (CONSTANTLIM): Remove; unused.
8043 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8044 Define only if needed.
7914961c 8045
b3967b18
PE
8046 * unexelf.c (unexec): Name an expression,
8047 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8048 Use a different way to cause a compilation error if anyone uses
8049 n rather than nn, a way that does not involve shadowing.
73366a00 8050 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8051
29a6015a
PE
8052 * deps.mk (unexalpha.o): Remove; unused.
8053
43cfc33e 8054 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8055 * unexec.h: New file.
ce701a33
PE
8056 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8057 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8058 Depend on unexec.h.
8059 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8060 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8061 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8062 Change as necessary to match prototype in unexec.h.
ce701a33 8063
01f44d5a
PE
8064 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8065 shadowing.
4f63c6bb 8066 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8067
a6670b0b
PE
8068 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8069 Rename locals to avoid shadowing.
8070
cef2010d 8071 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8072 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8073
d4d7173a
PE
8074 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8075
f08b802a
PE
8076 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8077 warning when compiling print.c.
8078
3ddb0639
PE
8079 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8080 instead of using an uninitialized var.
5ad03b97 8081 (font_sort_entities): Mark var as initialized.
3ddb0639 8082
170a2692
PE
8083 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8084
e663c700
PE
8085 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8086 pointers to constants.
89bc529a 8087 (font_parse_fcname): Remove unused vars.
7b81e2d0 8088 (font_delete_unmatched): Now static.
ea838e10 8089 (font_get_spec): Remove; unused.
13a547c6
PE
8090 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8091 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8092 Rename or move locals to avoid shadowing.
e663c700 8093
2a80c887 8094 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8095 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8096
1384fa33 8097 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8098 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8099
8b2c52e9
PE
8100 * alloc.c (mark_backtrace): Move decl from here ...
8101 * lisp.h: ... to here, so that it can be checked.
8102
475545b5 8103 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8104 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8105 (lisp_indirect_variable): Name an expression,
8106 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8107 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8108
b1349114 8109 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8110 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8111 Use const pointer when appropriate.
b1349114 8112
a2928364
PE
8113 * lisp.h (get_system_name, get_operating_system_release):
8114 Move decls here, to check interfaces.
8115 * process.c (get_operating_system_release): Move decl to lisp.h.
8116 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8117 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8118 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8119 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8120 (Fformat_time_string, Fencode_time, Finsert_char):
8121 (Ftranslate_region_internal, Fformat):
8122 Rename or remove local vars to avoid shadowing.
9710023e 8123 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8124
a415e694
PE
8125 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8126 avoid shadowing.
8127
8ef4622d
PE
8128 * lisp.h (eassert): Check that the argument compiles, even if
8129 ENABLE_CHECKING is not defined.
8130
946f9a5b
PE
8131 * data.c (Findirect_variable): Name an expression, to avoid
8132 gcc -Wbad-function-cast warning.
112396d6 8133 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8134 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8135 (Fmake_variable_buffer_local, Fmake_local_variable):
8136 Mark variables as initialized.
52746918 8137 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8138
e5aab7e7 8139 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8140 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8141 Rename locals to avoid shadowing.
dff45157
PE
8142 (mark_stack): Move local variables into the #ifdef region where
8143 they're used.
7bc26fdb
PE
8144 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8145 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8146 needed otherwise.
8147 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8148 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8149 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8150
e5aab7e7
PE
8151 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8152 avoids undefined behavior in theory.
8153
4da60324
PE
8154 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8155
88043301
PE
8156 Use functions, not macros, for up- and down-casing (Bug#8254).
8157 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8158 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8159 to use the following functions instead of these macros.
8160 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8161 EMACS_INT, since callers assume the returned value fits in int.
8162 (upcase1): Likewise, for UPCASE_TABLE.
8163 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8164 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8165 the race-condition problem in the old DOWNCASE.
88043301 8166
19ed5445
PE
8167 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8168 Rename locals to avoid shadowing.
8169 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8170 (regex_compile, re_search_2, re_match_2_internal):
8171 Remove unused local vars.
952db0d7
PE
8172 (FREE_VAR): Rewrite so as not to use empty "else",
8173 which gcc can warn about.
da053e48 8174 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8175 (RETALLOC_IF): Define only if needed.
8176 (WORDCHAR_P): Likewise. This one is never needed, but is used
8177 only in a comment talking about a compiler bug, so put inside
8178 the #if 0 of that comment.
8179 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8180 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8181 Remove; unused.
19ed5445 8182
1f3561e4 8183 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8184 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8185 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8186
ded6f8f7
PE
8187 * search.c (simple_search): Remove unused var.
8188
dbd37a95
PE
8189 * dired.c (compile_pattern): Move decl from here ...
8190 * lisp.h: ... to here, so that it can be checked.
8191 (struct re_registers): New forward decl.
8192
7e47afad
PE
8193 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8194
85f24f61
PE
8195 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8196 All uses changed.
8197 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8198 Rename locals to avoid shadowing.
5671df8f 8199 (Fvertical_motion): Mark locals as initialized.
85f24f61 8200
181aa2be 8201 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8202 (casify_region): Mark local as initialized.
181aa2be 8203
930d429c
PE
8204 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8205
7082eac6
PE
8206 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8207 New macros, so that the caller can use some names other than
8208 gcpro1, gcpro2, etc.
8209 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8210 of the new macros.
8211 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8212 argument, for consistency with GCPRO2_VAR, etc: it is now the
8213 prefix of the variable, not the variable itself. All uses
8214 changed.
38b2c076
PE
8215 * dired.c (directory_files_internal, file_name_completion):
8216 Rename locals to avoid shadowing.
8217
15206ed9
PE
8218 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8219 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8220 dired.c's scmp function, had undefined behavior.
8221 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8222 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8223 * buffer.h: ... to here, because these macros use current_buffer,
8224 and the new implementation with inline functions needs to have
8225 current_buffer in scope now, rather than later when the macros
8226 are used.
8227 (downcase, upcase1): New static inline functions.
8228 (DOWNCASE, UPCASE1): Reimplement using these functions.
8229 This avoids undefined behavior in expressions like
8230 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8231 from race conditions in accessing the global variables
8232 case_temp1 and case_temp2.
8233 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8234 * lisp.h (case_temp1, case_temp2): Remove their decls.
8235 * character.h (ASCII_CHAR_P): Move from here ...
8236 * lisp.h: ... to here, so that the inline functions mentioned
8237 above can use them.
8238
4a6bea26
PE
8239 * dired.c (directory_files_internal_unwind): Now static.
8240
f14b7e14
PE
8241 * fileio.c (file_name_as_directory, directory_file_name):
8242 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8243 Now static.
2893f146
PE
8244 (file_name_as_directory): Use const pointers when appropriate.
8245 (Fexpand_file_name): Likewise. In particular, newdir might
8246 point at constant storage, so make it a const pointer.
fd4ead52 8247 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8248 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8249 signedness issues.
f839df0c
PE
8250 (Fset_file_times, Finsert_file_contents, auto_save_error):
8251 Rename locals to avoid shadowing.
f14b7e14 8252
5716756e 8253 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8254 (Ftry_completion, Fall_completions): Rename or remove locals
8255 to avoid shadowing.
5716756e 8256
b4c3046a
PE
8257 * marker.c (bytepos_to_charpos): Remove; unused.
8258
b45db522
PE
8259 * lisp.h (verify_bytepos, count_markers): New decls,
8260 so that gcc does not warn that these functions aren't declared.
8261
85876d07
PE
8262 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8263 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8264 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8265 (copy_text): Remove unused local var.
85876d07 8266
03d78a21 8267 * filelock.c (within_one_second): Now static.
b3dd38ab 8268 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8269
5df8f01b
PE
8270 * buffer.c (fix_overlays_before): Mark locals as initialized.
8271 (fix_start_end_in_overlays): Likewise. This function should be
8272 simplified by using pointers-to-pointers, but that's a different
8273 matter.
b1d876f1 8274 (switch_to_buffer_1): Now static.
8f54f30a
PE
8275 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8276 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8277
a70072c9 8278 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8279 Fix pointer signedness issue.
edced198
PE
8280 (sys_subshell): Mark local as volatile if checking for lint,
8281 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8282 (MAXPATHLEN): Define only if needed.
a70072c9 8283
a0977c44
PE
8284 * process.c (serial_open, serial_configure): Move decls from here ...
8285 * systty.h: ... to here, so that they can be checked.
8286
a884fdcc
PE
8287 * fns.c (get_random, seed_random): Move extern decls from here ...
8288 * lisp.h: ... to here, so that they can be checked.
8289
604efe86 8290 * sysdep.c (reset_io): Now static.
b8950c94 8291 (wait_for_termination_signal): Remove; unused.
604efe86 8292
38fc62d9
PE
8293 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8294 (copy_keymap_item, append_key, push_text_char_description):
8295 Now static.
1004a21a 8296 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8297 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8298 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8299 (describe_map_tree):
8300 Rename locals to avoid shadowing.
38fc62d9 8301
2f2650da
PE
8302 * keyboard.c: Declare functions static if they are not used elsewhere.
8303 (echo_char, echo_dash, cmd_error, top_level_2):
8304 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8305 (read_char, kbd_buffer_get_event, make_lispy_position):
8306 (make_lispy_event, make_lispy_movement, apply_modifiers):
8307 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8308 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8309 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8310 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8311 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8312
a053e86c 8313 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8314 (mark_kboards): Move decl here ...
8315 * alloc.c (mark_kboards): ... from here.
a053e86c 8316
4752793e
PE
8317 * lisp.h (force_auto_save_soon): New decl.
8318
74f10ca7 8319 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8320 (DEFINE_DUMMY_FUNCTION): New macro.
8321 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8322 Use it.
c03cd23f
PE
8323 (main): Add casts to avoid warnings
8324 if GCC considers string literals to be constants.
74f10ca7 8325
022e70d4
PE
8326 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8327
59d6fe83
PE
8328 * dbusbind.c: Pointer signedness fixes.
8329 (xd_signature, xd_append_arg, xd_initialize):
8330 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8331 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8332 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8333 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8334
78320123
PE
8335 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8336 if GCC considers string literals to be constants.
49cebcca 8337 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8338
35ac2a97
SM
83392011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8340
fb103ca9
SM
8341 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8342 (print_preprocess, print_object): New macro to fix last change.
8343
35ac2a97
SM
8344 * print.c (print_preprocess): Don't forget font objects.
8345
62973b41
JB
83462011-03-16 Juanma Barranquero <lekktu@gmail.com>
8347
8348 * emacs.c (USAGE3): Doc fixes.
8349
0e48bb22
AS
83502011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8351
8352 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8353 structure.
8354
7684e57b
JB
83552011-03-14 Juanma Barranquero <lekktu@gmail.com>
8356
8357 * lisp.h (VWindow_system, Qfile_name_history):
8358 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8359 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8360 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8361
8362 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8363 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8364
8365 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8366 * w32console.c (detect_input_pending, read_input_pending)
8367 (encode_terminal_code):
8368 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8369 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8370 (w32_system_caret_y, Qfile_name_history):
8371 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8372 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8373 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8374 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8375 * w32proc.c (Qlocal, report_file_error):
8376 * w32term.c (Vwindow_system, updating_frame):
8377 * w32uniscribe.c (initialized, uniscribe_font_driver):
8378 Remove unneeded extern declarations.
8379
2aa46d6c
CY
83802011-03-14 Chong Yidong <cyd@stupidchicken.com>
8381
c96bbc66 8382 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8383
cffc6f3b
CY
83842011-03-13 Chong Yidong <cyd@stupidchicken.com>
8385
8386 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8387 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8388 These macros can no longer be used for assignment.
8389
44f230aa
SM
8390 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8391 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8392 (record_buffer_markers, fetch_buffer_markers): New functions for
8393 recording and fetching special buffer markers.
8394 (set_buffer_internal_1, set_buffer_temp): Use them.
8395
8396 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8397
8398 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8399
8400 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8401 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8402
8403 * xdisp.c (hscroll_window_tree):
8404 (reconsider_clip_changes): Use PT instead of BUF_PT.
8405
d251f04b
EZ
84062011-03-13 Eli Zaretskii <eliz@gnu.org>
8407
8408 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8409 $(EMACS_ROOT)/lib/intprops.h.
8410
f0c77cd1
PE
84112011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8412
3eca4629
PE
8413 Fix more problems found by GCC 4.5.2's static checks.
8414
7c86ee98
PE
8415 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8416 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8417 (xg_free_frame_widgets): Make it clear that a local variable is
8418 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8419 (gdk_window_get_screen): Make it clear that this macro is needed
8420 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8421 (int_gtk_range_get_value): New function, which avoids a diagnostic
8422 from gcc -Wbad-function-cast.
8423 (xg_set_toolkit_scroll_bar_thumb): Use it.
8424 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8425 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8426 (get_utf8_string, xg_get_file_with_chooser):
8427 Rename locals to avoid shadowing.
8428 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8429
41729b81
PE
8430 * xgselect.c (xg_select): Remove unused var.
8431
f0c77cd1
PE
8432 * image.c (four_corners_best): Mark locals as initialized.
8433 (gif_load): Initialize transparent_p to zero (Bug#8238).
8434 Mark another local as initialized.
ec6cf4c6 8435 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8436
ce0ad53d 8437 * image.c (clear_image_cache): Now static.
d5d5a617 8438 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8439 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8440 (x_edge_detection): Remove unnecessary cast that
8441 gcc -Wbad-function-cast diagnoses.
2037898d 8442 (gif_load): Fix pointer signedness.
6ae141d6
PE
8443 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8444 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8445
33383987 84462011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8447
d32df629
PE
8448 Improve quality of tests for time stamp overflow.
8449 For example, without this patch (encode-time 0 0 0 1 1
8450 1152921504606846976) returns the obviously-bogus value (-948597
8451 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8452 reports time overflow. See
8453 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8454 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8455 * editfns.c: Include limits.h and intprops.h.
8456 (TIME_T_MIN, TIME_T_MAX): New macros.
8457 (time_overflow): Move earlier, to before first use.
8458 (hi_time, lo_time): New functions, for an accurate test for
8459 out-of-range times.
8460 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8461 (Fget_internal_run_time): Don't assume time_t fits in int.
8462 (make_time): Use list2 instead of Fcons twice.
8463 (Fdecode_time): More accurate test for out-of-range times.
8464 (check_tm_member): New function.
8465 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8466 (lisp_time_argument): Don't rely on undefined left-shift and
8467 right-shift behavior when checking for time stamp overflow.
8be6f318 8468
fe31d94c
PE
8469 * editfns.c (time_overflow): New function, refactoring common code.
8470 (Fformat_time_string, Fdecode_time, Fencode_time):
8471 (Fcurrent_time_string): Use it.
8472
8be6f318
PE
8473 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8474 * dired.c (make_time): Move to ...
8475 * editfns.c (make_time): ... here.
8476 * systime.h: Note the move.
8477
09d9db2c 84782011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8479
126bc0dc
YM
8480 * fringe.c (update_window_fringes): Remove unused variables.
8481
c47cbdfd
YM
8482 * unexmacosx.c (copy_data_segment): Also copy __got section.
8483 (Bug#8223)
8484
7ac80be9
EZ
84852011-03-12 Eli Zaretskii <eliz@gnu.org>
8486
c96bbc66 8487 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8488 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8489 Constify `char *' arguments and their references according to
8490 prototypes in tparam.h.
8491
ecb0f94d 8492 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8493
7ac80be9
EZ
8494 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8495 Adapt all references accordingly.
8496
8497 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8498
ef1fd07e
TT
84992011-03-11 Tom Tromey <tromey@redhat.com>
8500
8501 * buffer.c (syms_of_buffer): Remove obsolete comment.
8502
7ef4b50c
EZ
85032011-03-11 Eli Zaretskii <eliz@gnu.org>
8504
8505 * termhooks.h (encode_terminal_code): Declare prototype.
8506
8507 * msdos.c (encode_terminal_code): Don't declare prototype.
8508
8509 * term.c (encode_terminal_code): Now external again, used by
8510 w32console.c and msdos.c.
8511
44f230aa
SM
8512 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8513 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8514
4b1ec863 85152011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8516
1714f52b 8517 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8518
4b1ec863
PE
8519 * fringe.c (update_window_fringes): Mark locals as initialized
8520 (Bug#8227).
8521 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8522
524c7aa6
PE
8523 * alloc.c (mark_fringe_data): Move decl from here ...
8524 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8525 to check its interface.
8526 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8527
a5c0af81 8528 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8529 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8530 (fontset_font): Mark local as initialized.
a9a06e0b 8531 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8532
b4716021
PE
8533 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8534
811e9bac 8535 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8536 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8537 (x_own_selection, Fx_disown_selection_internal): Rename locals
8538 to avoid shadowing.
8539 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8540
7e3ab302
PE
8541 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8542 so that the caller can use some name other than gcpro1.
8543 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8544 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8545 (Fx_backspace_delete_keys_p):
8546 Use them to avoid shadowing, and rename vars to avoid shadowing.
8547 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8548 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8549 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8550 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8551 Remove unused locals.
7e3ab302
PE
8552 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8553 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8554 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8555 macros.
f78faa98 8556
e2b13473
PE
8557 * xterm.h (x_mouse_leave): New decl.
8558
77f23912
PE
8559 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8560 Remove unused functions.
cdf4ba58
PE
8561 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8562 (x_calc_absolute_position): Now static.
7411c686 8563 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8564 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8565 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8566 unless they are used.
38d0b34a
PE
8567 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8568 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8569 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8570 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8571 (x_error_catcher, x_connection_closed, x_error_handler):
8572 (x_error_quitter, xembed_send_message, x_iconify_frame):
8573 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8574 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8575 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8576
44f230aa
SM
8577 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8578 Rename or move locals to avoid shadowing.
6b463e58 8579 (tty_defined_color, merge_face_heights): Now static.
5967d051 8580 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8581 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8582 does not deduce is never used uninitialized.
73719eba
PE
8583 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8584 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8585
426994c3 8586 * terminal.c (store_terminal_param): Now static.
5489860b 8587
032f1620 8588 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8589 (set_frame_menubar): Remove unused local.
d4323972 8590 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8591 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8592 since they might point to immutable storage.
281585b0
PE
8593 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8594 since it's unused otherwise.
032f1620 8595
367c19e5 8596 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8597 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8598 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8599 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8600 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8601 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8602 does not deduce are never used uninitialized.
70739cbe 8603
07b48fa9
PE
8604 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8605
8868a238 8606 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8607 * window.c (window_loop, size_window):
8608 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8609
7e5cf297 8610 * window.c (display_buffer): Now static.
d6550a9f
PE
8611 (size_window): Mark variables that gcc -Wuninitialized
8612 does not deduce are never used uninitialized.
a586633d
PE
8613 * window.h (check_all_windows): New decl, to forestall
8614 gcc -Wmissing-prototypes diagnostic.
5b555da1 8615 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8616
f6095868
PE
8617 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8618 shadowing.
8619 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8620 Include <limits.h>.
8621 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8622 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8623 (load_charset_map): Mark variables that gcc -Wuninitialized
8624 does not deduce are never used uninitialized.
53df7c11 8625 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8626
f38b440c
PE
8627 * coding.c (coding_set_source, coding_set_destination):
8628 Use "else { /* comment */ }" rather than "else /* comment */;"
8629 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8630 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8631 a block, when the outer 'i' will do.
8632 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8633 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8634 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8635 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8636 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8637 Rename locals to avoid shadowing.
8638 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8639 * coding.c (emacs_mule_char, encode_invocation_designation):
8640 Now static, since they're not used elsewhere.
413bb2db 8641 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8642 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8643 (decode_coding_emacs_mule): Mark variables that gcc
8644 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8645 (detect_coding_iso_2022): Initialize a local variable that might
8646 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8647 this initialization is needed. (Bug#8211)
5f58e762
PE
8648 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8649 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8650 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8651 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8652 Remove unused macros.
f38b440c 8653
232b38b9 8654 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8655 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8656 * character.c (string_count_byte8): Likewise.
232b38b9 8657
fb90da1b
PE
8658 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8659 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8660
fb93dbc2
PE
8661 * chartab.c (copy_sub_char_table): Now static, since it's not used
8662 elsewhere.
5c156ace
PE
8663 (sub_char_table_ref_and_range, char_table_ref_and_range):
8664 Rename locals to avoid shadowing.
bbcd0949 8665 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8666
7d3b3862 8667 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8668 (BIDI_BOB): Remove unused macro.
7d3b3862 8669
6be7d3da
PE
8670 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8671 deduce are never used uninitialized.
c2ed9c8b 8672 * term.c (encode_terminal_code): Likewise.
6be7d3da 8673
75f8807f 8674 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8675
50938595
PE
8676 * tparam.h: New file.
8677 * term.c, tparam.h: Include it.
8678 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8679 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8680 Move these decls to tparam.h, and make them agree with what
8681 is actually in tparam.c. The previous trick of using incompatible
8682 decls in different modules does not conform to the C standard.
8683 All callers of tparam changed to use tparam's actual API.
8684 * tparam.c (tparam1, tparam, tgoto):
8685 Use const pointers where appropriate.
8686
fbceeba2
PE
8687 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8688 * cm.h (struct cm): Likewise.
8689 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8690 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8691 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8692 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8693 (turn_on_face, init_tty): Likewise.
8694 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8695
7f3f1250
PE
8696 * term.c (term_mouse_position): Rename local to avoid shadowing.
8697
e6ca6543
PE
8698 * alloc.c (mark_ttys): Move decl from here ...
8699 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8700
c40f8d15
AS
87012011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8702
8703 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8704
cfe0661d
JB
87052011-03-09 Juanma Barranquero <lekktu@gmail.com>
8706
8707 * search.c (compile_pattern_1): Remove argument regp, unused since
8708 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8709 (compile_pattern): Don't pass it.
8710
0afb4571
J
87112011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8712
8713 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8714 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8715 for ! HAVE_GTK3.
8716 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8717
8718 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8719
8720 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8721 gdk_window_get_screen, gdk_window_get_geometry,
8722 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8723 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8724 (xg_get_pixbuf_from_pixmap): New function.
8725 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8726 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8727 Call xg_get_pixbuf_from_pixmap instead of
8728 gdk_pixbuf_get_from_drawable.
8729 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8730 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8731 (xg_check_special_colors): Use GtkStyleContext and its functions
8732 for HAVE_GTK3.
8733 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8734 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8735 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8736 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8737 Call gtk_widget_get_preferred_size.
0afb4571
J
8738 (xg_frame_resized): gdk_window_get_geometry only takes 5
8739 parameters.
44f230aa
SM
8740 (xg_win_to_widget, xg_event_is_for_menubar):
8741 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8742 (xg_set_widget_bg): New function.
8743 (delete_cb): New function.
895009e1 8744 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 8745 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
8746 (xg_set_background_color): Call xg_set_widget_bg.
8747 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8748 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8749 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8750 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8751 if ! HAVE_GTK3.
8752 (update_frame_tool_bar): Call gtk_widget_hide.
8753 (xg_initialize): Use GDK_KEY_g.
8754
8755 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8756 if ! HAVE_GTK3
8757 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8758
8759 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8760 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8761 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8762
1c2cc4ef
JB
87632011-03-08 Juanma Barranquero <lekktu@gmail.com>
8764
8765 * w32xfns.c (select_palette): Check success of RealizePalette against
8766 GDI_ERROR, not zero.
8767
33383987 8768See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8769
8770;; Local Variables:
8771;; coding: utf-8
aac0c6e3
MR
8772;; End:
8773
33383987 8774 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8775
8776 This file is part of GNU Emacs.
8777
8778 GNU Emacs is free software: you can redistribute it and/or modify
8779 it under the terms of the GNU General Public License as published by
8780 the Free Software Foundation, either version 3 of the License, or
8781 (at your option) any later version.
8782
8783 GNU Emacs is distributed in the hope that it will be useful,
8784 but WITHOUT ANY WARRANTY; without even the implied warranty of
8785 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8786 GNU General Public License for more details.
8787
8788 You should have received a copy of the GNU General Public License
8789 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.