* eval.c (verror): Simplify by rewriting in terms of evxprintf,
[bpt/emacs.git] / src / ChangeLog
CommitLineData
62f19c19
PE
12011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2
3 sprintf-related integer and memory overflow issues.
4
5 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
6 (esprintf, esnprintf, exprintf, evxprintf): New functions.
7 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
8 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
9 (modify_event_symbol): Do not assume that the length of
10 name_alist_or_stem is safe to alloca and fits in int.
11 (Fexecute_extended_command): Likewise for function name and binding.
12 (Frecursion_depth): Wrap around reliably on integer overflow.
13 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
14 since some callers pass EMACS_INT values.
15 (Fsingle_key_description): Don't crash if symbol name contains more
16 than MAX_ALLOCA bytes.
17 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
18 (get_minibuffer): Arg is now EMACS_INT, not int.
19 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
20 (esprintf, esnprintf, exprintf, evxprintf): New decls.
21 * window.h (command_loop_level, minibuf_level): Reflect API changes.
22
2ea16b89
PE
23 * dbusbind.c (xd_signature, Fdbus_register_signal):
24 Do not overrun buffer; instead, report string overflow.
25
9d1df220
PE
26 * dispnew.c (add_window_display_history): Don't overrun buffer.
27 Truncate instead; this is OK since it's just a log.
28
33ef5c64
PE
29 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
30 even if the time zone offset is outlandishly large.
31 Don't mishandle offset == INT_MIN.
32
66c6fdd5
PE
33 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
34 when creating daemon; the previous buffer-overflow check was incorrect.
35
d749b01b
PE
36 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
37 which has the guts of the old verror function.
38
5fc295a4 392011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 40
70c60eb2 41 Integer and memory overflow issues (Bug#9196).
726e0ab1 42
d31850da
PE
43 * doc.c (get_doc_string): Rework so that
44 get_doc_string_buffer_size is the actual buffer size, rather than
45 being 1 less than the actual buffer size; this makes xpalloc more
46 convenient.
47
a69fbedb
PE
48 * image.c (x_allocate_bitmap_record, cache_image):
49 * xselect.c (Fx_register_dnd_atom):
50 Simplify previous changes by using xpalloc.
51
fe5c5d37
PE
52 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
53 since either will do and ptrdiff_t is convenient with xpalloc.
54
0065d054
PE
55 * charset.c (charset_table_size)
56 (struct charset_sort_data.priority): Now ptrdiff_t.
57 (charset_compare): Don't overflow if priorities differ greatly.
58 (Fsort_charsets): Don't assume list length fits in int.
59 Check for size-calculation overflow when allocating sort data.
60 (syms_of_charset): Allocate an initial charset table that is
61 just under 64 KiB, to avoid problems with glibc malloc and mmap.
62
63 * cmds.c (internal_self_insert): Check for size-calculation overflow.
64
65 * composite.h (struct composition.glyph_len): Now int, not unsigned.
66 The actual value is always <= INT_MAX, and leaving it unsigned made
67 overflow checking harder.
68
69 * dispextern.h (struct glyph_matrix.rows_allocated)
70 (struct face_cache.size): Now ptrdiff_t, for convenience in use
71 with xpalloc. The values are still always <= INT_MAX.
72
73 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
74
75 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
76 (SAFE_NALLOCA): New macro.
77
78 * region-cache.c (struct boundary.pos, find_cache_boundary)
79 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
80 (set_cache_region, invalidate_region_cache)
81 (revalidate_region_cache, know_region_cache, region_cache_forward)
82 (region_cache_backward, pp_cache):
83 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
84 so that ptrdiff_t * can be passed to xpalloc.
85 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
86 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
87 (pp_cache): Don't assume cache_len fits in int.
88 * region-cache.h: Adjust extern decls to match.
89
90 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
91 EMACS_INT, since either will do, for xpalloc.
92
93 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
94 (xnmalloc, xnrealloc, xpalloc): New functions.
95
726e0ab1
PE
96 * bidi.c (bidi_shelve_header_size): New constant.
97 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
98 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
99
51f30bc5 100 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
101 * buffer.c (overlays_at, overlays_in, record_overlay_string)
102 (overlay_strings):
103 Don't update size of array until after memory allocation succeeds,
104 because xmalloc/xrealloc may not return.
0065d054
PE
105 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
106 now that we have proper integer overflow checking.
107 (record_overlay_string, overlay_strings): Catch overflows when
108 calculating size of overlay_str_buf.
726e0ab1 109
0065d054
PE
110 * callproc.c (Fcall_process): Check for size overflow when
111 calculating size of args2.
112 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
113 Normally we prefer signed values, but sticking with ptrdiff_t would
114 require adding more-complicated checks.
726e0ab1
PE
115
116 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
117 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
118 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 119 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
120
121 * character.c (Fstring): Check for size-calculation overflow.
122
123 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
124 unnecessary integer overflow. Check for size overflow.
125 (encode_coding_object): Don't update size until xmalloc succeeds.
126
127 * composite.c (get_composition_id): Check for overflow in glyph
128 length calculations.
129
130 Integer and memory overflow fixes for display code.
131 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
132 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
133 (scrolling_window): Check for overflow in size calculations.
134 (line_draw_cost, realloc_glyph_pool, add_row_entry):
135 Don't assume glyph table len fits in int.
136 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
137 (row_table_size): Now ptrdiff_t, not int.
138 (scrolling_window): Avoid overflow in size calculations.
139 Don't update size until allocation succeeds.
140 * fns.c (concat): Check for overflow in size calculations.
141 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
142 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
143 (NEXT_ALMOST_PRIME_LIMIT): New constant.
144
145 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
146 (get_doc_string): Check for size calculation overflow.
147 Don't update size until allocation succeeds.
148 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
149 EMACS_INT, where ptrdiff_t will do.
150 (Fsubstitute_command_keys): Check for string overflow.
151
152 * editfns.c (set_time_zone_rule): Don't assume environment length
153 fits in int.
154 (message_length): Now ptrdiff_t, not int.
155 (Fmessage_box): Don't update size until allocation succeeds.
156 Don't assume message length fits in int.
157 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
158
0065d054
PE
159 * emacs.c (main): Do not reallocate argv, since there is a null at
160 the end that can be overwritten, and this way there's no need to
161 worry about size-calculation overflow.
162 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
163
164 * eval.c (init_eval_once, grow_specpdl): Don't update size until
165 alloc succeeds.
166 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
167
168 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
169 (x_set_scroll_bar_width, x_figure_window_size):
170 Check for integer overflow.
171 (x_set_alpha): Do not assume XINT fits in int.
172
173 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
174 This is for the members text_lines, text_cols, total_lines, total_cols,
175 where the system imposes an 'int' limit.
176
177 * fringe.c (Fdefine_fringe_bitmap):
178 Don't update size until alloc works.
179
180 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
181 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
182
183 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
184 Check for size-calculation overflow.
185 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
186 do, as we prefer signed integers.
187 (id_to_widget.max_size, id_to_widget.used)
188 (xg_store_widget_in_map, xg_remove_widget_from_map)
189 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
190 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
191 Use and return ptrdiff_t, not int.
192 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
193 * gtkutil.h: Change prototypes to match the above.
194
195 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
196 are duplicate now that they've been promoted to lisp.h.
197 (x_allocate_bitmap_record, x_alloc_image_color)
198 (make_image_cache, cache_image, xpm_load):
199 Don't update size until alloc is done.
200 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
201 (x_detect_edges):
3256efce 202 Check for size calculation overflow.
726e0ab1
PE
203 (ct_colors_allocated_max): New constant.
204 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
205 overflow.
3256efce 206
726e0ab1
PE
207 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
208 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
209 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
210 Use ptrdiff_t, not int, to count maps.
211 (read_char_minibuf_menu_prompt): Check for overflow in size
212 calculations. Don't update size until allocation succeeds. Redo
213 calculations to avoid overflow.
214 * keyboard.h: Change prototypes to match the above.
215
216 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
217 to count maps.
218 (current_minor_maps): Check for size calculation overflow.
219 * keymap.h: Change prototypes to match the above.
220
221 * lread.c (read1, init_obarray): Don't update size until alloc done.
222
223 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
224 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
225
726e0ab1
PE
226 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
227 Now ptrdiff_t, not int.
228 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
229 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
230
231 * process.c (Fnetwork_interface_list): Check for overflow
232 in size calculation.
233
234 * region-cache.c (move_cache_gap): Check for size calculation overflow.
235
236 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
237 overflow. Don't bother calling xmalloc when xrealloc will do.
238
239 * search.c (Freplace_match): Check for size calculation overflow.
240 (Fset_match_data): Don't assume list lengths fit in 'int'.
241
242 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
243 for command line length. Do not attempt to address one before the
244 beginning of an array, as that's not portable.
245
246 * term.c (max_frame_lines): Remove; unused.
247 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
248 not int.
249 (encode_terminal_code, calculate_costs): Check for size
250 calculation overflow.
251 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
252 table lengths and related sizes. Don't update size until alloc
253 done. Redo calculations to avoid overflow.
254 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
255
256 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
257 subtracting pointers.
258 (gobble_line): Check for overflow more carefully. Don't update size
259 until alloc done.
260
261 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
262 Don't update size until alloc done.
263 Redo size calculations to avoid overflow.
264 Check for size calculation overflow.
0065d054 265 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
266
267 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
268 Use ptrdiff_t, not int, for sizes.
269 (store_mode_line_noprop_char): Don't update size until alloc done.
270
0065d054
PE
271 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
272 Use ptrdiff_t, not int, for sizes.
273 (Finternal_make_lisp_face, cache_face):
274 Check for size calculation overflow.
275 (cache_face): Treat size calculation overflows as if they were
276 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
277
278 * xfns.c (x_encode_text, x_set_name_internal)
279 (Fx_change_window_property): Use ptrdiff_t, not int, to count
280 sizes, since they can exceed INT_MAX in size. Check for size
281 calculation overflow.
282
0065d054
PE
283 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
284 (xg_select): Check for size calculation overflow.
726e0ab1
PE
285 Don't update size until alloc done.
286
0065d054 287 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 288 as sprintf is limited to int lengths.
1d526e2f 289
252c5ee1
PE
290 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
291 (X_LONG_MIN): New macros.
864d7ce7
PE
292 Use them to make the following changes clearer.
293 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
294 This change doesn't affect the value now, but it may help remind
295 future maintainers not to raise the value too much later.
296 (SELECTION_QUANTUM): Remove, replacing with ...
297 (selection_quantum): ... new function, which avoids overflow.
298 All uses changed.
299 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
300 assumption that selection length fits in 'int'.
301 (x_reply_selection_request, x_handle_selection_request)
302 (x_get_window_property, receive_incremental_selection)
303 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
304 (lisp_data_to_selection_data, clean_local_selection_data):
305 Use ptrdiff_t, not int, to record length of selection.
306 (x_reply_selection_request, x_get_window_property)
307 (receive_incremental_selection, x_property_data_to_lisp):
308 Redo calculations to avoid overflow.
309 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 310 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
311 something.
312 (x_get_window_property, receive_incremental_selection)
313 (lisp_data_to_selection_data, x_property_data_to_lisp):
314 Check for size-calculation overflow.
315 (x_get_window_property, receive_incremental_selection)
316 (lisp_data_to_selection_data, Fx_register_dnd_atom):
317 Don't store size until memory allocation succeeds.
318 (x_get_window_property): Plug memory leak on memory exhaustion.
319 Don't double-block input; malloc is safe here. Don't assume 2**34
320 - 4 fits in unsigned long. Add an xassert to check
321 XGetWindowProperty overflow. Be more careful about overflow
322 calculations, and distinguish size from memory overflow better.
323 (receive_incremental_selection): When tracing, don't assume
324 unsigned int is less than INT_MAX.
325 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
326 harmful) conversions of unsigned short to int.
327 (lisp_data_to_selection_data): Don't assume that integers
328 in the range -65535 through -1 fit in an X unsigned short.
329 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
330 result parameters unless successful. Rely on cons_to_unsigned
331 to report problems with elements; the old code wasn't right anyway.
332 (x_check_property_data): Check for int overflow; we cannot use
333 a wider type due to X limits.
334 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
335
726e0ab1 336 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 337
0065d054
PE
338 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
339 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
340 (x_color_cells): Don't store size until memory allocation succeeds.
341 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 342 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
343 (x_term_init): Don't assume length fits in int (sprintf is limited
344 to int size).
bc18e09d 345
ebfa62c0
PE
346 Use ptrdiff_t for composition IDs.
347 * character.c (lisp_string_width):
348 * composite.c (composition_table_size, n_compositions)
349 (get_composition_id, composition_gstring_from_id):
350 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
351 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
352 * window.c (Frecenter):
353 Use ptrdiff_t, not int, for composition IDs.
354 * composite.c (get_composition_id): Check for integer overflow.
355 * composite.h: Adjust prototypes to match the above changes.
356
d3411f89
PE
357 Use ptrdiff_t for hash table indexes.
358 * category.c (hash_get_category_set):
359 * ccl.c (ccl_driver):
360 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
361 * coding.c (coding_system_charset_list, detect_coding_system):
362 * coding.h (struct coding_system.id):
363 * composite.c (get_composition_id, gstring_lookup_cache):
364 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
365 * image.c (xpm_get_color_table_h):
366 * lisp.h (hash_lookup, hash_put):
367 * minibuf.c (Ftest_completion):
368 Use ptrdiff_t for hash table indexes, not int (which is too
369 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
370 32-bit --with-wide-int hosts).
371
e097a6fa
PE
372 * charset.c (Fdefine_charset_internal): Check for integer overflow.
373 Add a FIXME comment about memory leaks.
374 (syms_of_charset): Don't assume xmalloc returns.
375
5637687f
PE
376 Don't assume that stated character widths fit in int.
377 * character.c (Fchar_width, c_string_width, lisp_string_width):
378 * character.h (CHAR_WIDTH):
379 * indent.c (MULTIBYTE_BYTES_WIDTH):
380 Use sanitize_char_width to avoid undefined and/or bad behavior
381 with outlandish widths.
382 * character.h (sanitize_tab_width): Renamed from sanitize_width,
383 now that we have two such functions. All uses changed.
384 (sanitize_char_width): New inline function.
385
a2271ba2
PE
386 Don't assume that tab-width fits in int.
387 * character.h (sanitize_width): New inline function.
388 (SANE_TAB_WIDTH): New macro.
389 (ASCII_CHAR_WIDTH): Use it.
390 * indent.c (sane_tab_width): Remove. All uses replaced by
391 SANE_TAB_WIDTH (current_buffer).
392 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
393
18c52557
PE
394 * fileio.c: Integer overflow issues with file modes.
395 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
396
caeeedc1
PE
397 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
398 Remove unreachable code.
399 (read_hex, load_charset_map_from_file): Check for integer overflow.
400
50849c52
PE
401 * xterm.c: don't go over XClientMessageEvent limit
402 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
403 (x_send_scroll_bar_event): Likewise. Check that the size does not
404 exceed limits imposed by XClientMessageEvent, as well as the usual
405 ptrdiff_t and size_t limits.
406
b13995db
PE
407 * keyboard.c: Overflow, signedness and related fixes.
408 (make_lispy_movement): Use same integer type in forward decl
409 that is used in the definition.
410 (read_key_sequence, keyremap_step):
411 Change bufsize argument back to int, undoing my 2011-03-30 change.
412 We prefer signed types, and int is wide enough here.
413 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
414 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
415 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
416 length, not size_t. Use ptrdiff_t for index, not int.
417 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
418 possibility of integer overflow.
419
13464394
PE
420 Overflow, signedness and related fixes for images.
421
422 * dispextern.h (struct it.stack[0].u.image.image_id)
423 (struct_it.image_id, struct image.id, struct image_cache.size)
424 (struct image_cache.used, struct image_cache.ref_count):
425 * gtkutil.c (update_frame_tool_bar):
426 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
427 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
428 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
429 * nsmenu.m (update_frame_tool_bar):
430 * xdisp.c (calc_pixel_width_or_height):
431 * xfns.c (image_cache_refcount):
432 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
433 on typical 64-bit hosts.
434
435 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
436 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
437 Omit unnecessary casts to int.
438 (parse_image_spec): Check that integers fall into 'int' range
439 when the callers expect that.
440 (image_ascent): Redo ascent calculation to avoid int overflow.
441 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
442 (lookup_image): Remove unnecessary tests.
443 (xbm_image_p): Locals are now of int, not EMACS_INT,
444 since parse_image_check makes sure they fit into int.
445 (png_load, gif_load, svg_load_image):
446 Prefer int to unsigned where either will do.
447 (tiff_handler): New function, combining the cores of the
448 old tiff_error_handler and tiff_warning_handler. This
449 function is rewritten to use vsnprintf and thereby avoid
450 stack buffer overflows. It uses only the features of vsnprintf
451 that are common to both POSIX and native Microsoft.
452 (tiff_error_handler, tiff_warning_handler): Use it.
453 (tiff_load, gif_load, imagemagick_load_image):
454 Don't assume :index value fits in 'int'.
455 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
456 (imagemagick_load_image): Check that crop parameters fit into
457 the integer types that MagickCropImage accepts. Don't assume
458 Vimagemagick_render_type has a nonnegative value. Don't assume
459 size_t fits in 'long'.
460 (gs_load): Use printmax_t to print the widest integers possible.
461 Check for integer overflow when computing image height and width.
462
c11821d4
EZ
4632011-08-26 Eli Zaretskii <eliz@gnu.org>
464
465 * xdisp.c (redisplay_window): Don't force window start if point
466 will be invisible in the resulting window. (Bug#9324)
467
0c95fcf7
EZ
4682011-08-25 Eli Zaretskii <eliz@gnu.org>
469
470 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
471 the display spec is of the form `(space ...)'.
472 (handle_display_spec): Return the value returned by
473 handle_single_display_spec, not just 1 or zero.
474 (handle_single_display_spec): If the display spec is of the form
475 `(space ...)', and specifies display in the text area, return 2
476 rather than 1.
fee65a97 477 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
478 accurately, and prefer exact match for point under bidi. Don't
479 advance `row' beyond the last row of the window.
0c95fcf7
EZ
480
481 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
482 into disp_prop; all users changed.
483
484 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
485 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
486 for the text covered by the display property.
487
e4ed06f1
CY
4882011-08-25 Chong Yidong <cyd@stupidchicken.com>
489
490 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
491 Change return value to nil.
492 (Frecord_buffer): Delete unused function.
493
f67cdd7f
EZ
4942011-08-24 Eli Zaretskii <eliz@gnu.org>
495
5980d4c6
EZ
496 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
497 buffers, return left-to-right.
8610fe8b
EZ
498 (set_cursor_from_row): Consider candidate row a win if its glyph
499 represents a newline and point is on that newline. Fixes cursor
500 positioning on the newline at EOL of R2L text within L2R
501 paragraph, and vice versa.
502 (try_cursor_movement): Check continued rows, in addition to
503 continuation rows. Fixes unwarranted scroll when point enters a
504 continued line of R2L text within an L2R paragraph, or vice versa.
505 (cursor_row_p): Consider the case of point being equal to
506 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
507 from the end of a short line to the beginning of a continued line
508 of R2L text within L2R paragraph.
509 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
510 composed characters.
5980d4c6 511
f67cdd7f
EZ
512 * bidi.c (bidi_check_type): Use xassert.
513 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
514 members.
515
bca633fb
EZ
5162011-08-23 Eli Zaretskii <eliz@gnu.org>
517
518 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
519 a character.
520
4a5885a7
CY
5212011-08-23 Chong Yidong <cyd@stupidchicken.com>
522
523 * nsfont.m (ns_otf_to_script): Fix typo.
524
0902a04e
KH
5252011-08-22 Kenichi Handa <handa@m17n.org>
526
527 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
528 extra slot even if the purpose is char-code-property-table.
529
1a2e6670
EZ
5302011-08-23 Eli Zaretskii <eliz@gnu.org>
531
8ddde651
EZ
532 * xdisp.c (redisplay_window): When computing centering_position,
533 account for the height of the header line. (Bug#8874)
534
425cc014
EZ
535 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
536 instead of CHAR_TO_BYTE. Fixes a crash when a completion
537 candidate is selected by the mouse, and that candidate has a
538 composed character under the mouse.
539
1a2e6670
EZ
540 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
541 coordinates reported by pos-visible-in-window-p for a composed
542 character in column zero.
543
8b76d6f8
SM
5442011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
545
546 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
547
dac347dd
EZ
5482011-08-22 Eli Zaretskii <eliz@gnu.org>
549
550 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
551 consider it a hit if to_charpos is anywhere in the range of the
552 composed buffer positions.
553
e013fb34
CY
5542011-08-22 Chong Yidong <cyd@stupidchicken.com>
555
556 * image.c (gif_load): Don't assume that each subimage has the same
557 dimensions as the base image. Handle disposal method that is
558 "undefined" by the gif spec (Bug#9335).
559
bd1ba3e8
CY
5602011-08-20 Chong Yidong <cyd@stupidchicken.com>
561
562 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 563 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 564
54a1215b
EZ
5652011-08-19 Eli Zaretskii <eliz@gnu.org>
566
823564e5
EZ
567 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
568 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
569 from an Org mode buffer to a Speedbar frame.
570
54a1215b
EZ
571 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
572 a composition, take its buffer position from IT->cmp_it.charpos.
573 Fixes cursor positioning at the beginning of a line that begins
574 with a composed character.
575
9778ebcc
EZ
5762011-08-18 Eli Zaretskii <eliz@gnu.org>
577
0be6ee06
EZ
578 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
579 character bidirectional type, use STRONG_L instead. Fixes crashes
580 in a buffer produced by `describe-categories'.
581
9778ebcc
EZ
582 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
583 members before the level stack, so they would be saved and
584 restored when copying iterator state. Fixes incorrect reordering
585 around TABs covered by display properties.
586
156bffbe
AS
5872011-08-18 Andreas Schwab <schwab@linux-m68k.org>
588
589 * process.c (Fnetwork_interface_list): Correctly determine buffer
590 size.
591
72ad093b
CY
5922011-08-17 Chong Yidong <cyd@stupidchicken.com>
593
594 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
595 (internal_condition_case_2, internal_condition_case_n):
596 Remove unnecessary aborts (Bug#9081).
72ad093b 597
35774242
EZ
5982011-08-17 Eli Zaretskii <eliz@gnu.org>
599
600 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
601 has no `load' handler, try opening the file locally. (Bug#9311)
602
db76dd85
KB
6032011-08-16 Ken Brown <kbrown@cornell.edu>
604
605 * gmalloc.c: Expand comment.
606
b215eee5
EZ
6072011-08-16 Eli Zaretskii <eliz@gnu.org>
608
609 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
610 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
611
a4579d33
KB
6122011-08-16 Ken Brown <kbrown@cornell.edu>
613
614 Fix memory allocation problems in Cygwin build (Bug#9273).
615
616 * unexcw.c ( __malloc_initialized): Declare external variable.
617 (fixup_executable): Force the dumped emacs to reinitialize malloc.
618
8b76d6f8
SM
619 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
620 New variables.
a4579d33
KB
621 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
622 dumped emacs.
623 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
624 in the static heap.
625 [CYGWIN] (special_realloc): New function.
626 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
627 requests to realloc storage in the static heap.
628
3ebec551
PE
6292011-08-15 Paul Eggert <eggert@cs.ucla.edu>
630
631 * bidi.c (bidi_initialize): Remove unused local.
632
9fd8be00
EZ
6332011-08-15 Eli Zaretskii <eliz@gnu.org>
634
474a8465
EZ
635 * biditype.h: File removed.
636
637 * bidimirror.h: File removed.
638
639 * deps.mk (bidi.o): Remove biditype.h and
640 bidimirror.h.
641
642 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
643 bidimirror.h.
644
645 * dispextern.h: Fix a typo in the comment to bidi_type_t.
646
647 * chartab.c: Improve commentary for the uniprop_table API.
648
32413314
EZ
649 * bidi.c (bidi_paragraph_init): Support zero value of
650 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
651 (bidi_initialize): Use uniprop_table instead of including
652 biditype.h and bidimirror.h.
32413314 653
9fd8be00
EZ
654 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
655 coordinates of the iterator when restoring from ppos_it.
656 (Bug#9296)
657
5cf2b69b
KH
6582011-08-14 Kenichi Handa <handa@m17n.org>
659
660 * process.c (create_process): Call setup_process_coding_systems
72ad093b 661 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 662
daf17d00
EZ
6632011-08-14 Eli Zaretskii <eliz@gnu.org>
664
665 * xdisp.c (move_it_in_display_line_to): Don't invoke
666 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
667 ppos_it. Fixes vertical cursor motion when line beginning is
668 covered by an image. (Bug#9296)
669
08e3161a
JD
6702011-08-14 Jan Djärv <jan.h.d@swipnet.se>
671
672 * nsterm.h (ns_run_ascript): Declare.
673 (NSAPP_DATA2_RUNASSCRIPT): Define.
674
675 * nsfns.m (as_script, as_result, as_status): New static variables.
676 (ns_run_ascript): New function.
677 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
678 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
679 the event loop. Get status from as_status (Bug#7276).
680
681 * nsterm.m (sendEvent): If event is NSApplicationDefined and
682 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
683 the event loop (Bug#7276).
684
a3720aa2
AS
6852011-08-14 Andreas Schwab <schwab@linux-m68k.org>
686
687 * gnutls.c (QCgnutls_bootprop_priority)
688 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
689 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
690 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
691 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
692 (QCgnutls_bootprop_verify_hostname_error)
693 (QCgnutls_bootprop_callbacks_verify): Rename from
694 Qgnutls_bootprop_..., all uses changed.
695
696 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
697 uses changed.
698
0a0d27fb
PE
6992011-08-14 Paul Eggert <eggert@cs.ucla.edu>
700
19d5c50c
PE
701 * xfaces.c (Qframe_set_background_mode): Now static.
702 * dispextern.h (Qframe_set_background_mode): Remove decl.
703
0a0d27fb
PE
704 * process.c (Fnetwork_interface_info): Declare local only if needed.
705
377538cb
JD
7062011-08-13 Jan Djärv <jan.h.d@swipnet.se>
707
708 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
709 (Fnetwork_interface_list): Allocate in increments of bytes instead
710 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
711 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
712 sockaddr.
713 (struct ifflag_def): notrailers is smart on OSX.
714 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
715 Get hardware address with getifaddrs if available.
716
08fff70c
EZ
7172011-08-12 Eli Zaretskii <eliz@gnu.org>
718
719 * xdisp.c (iterate_out_of_display_property): xassert that
720 IT->position is set to within IT->object's boundaries. Break from
721 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
722 when IT->position is set up wrongly due to some bug.
723 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
724 (push_display_prop): Allow GET_FROM_STRING as IT->method on
725 entry. Force push_it to save on the stack the current
726 buffer/string position, to be restored by pop_it. Fix flags in
727 the iterator structure wrt the object coming from a display
728 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
729 properties. (Bug#9284)
730
7be1c708 7312011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 732
7be1c708
CY
733 * fontset.c (fontset_get_font_group): Add proper type checks.
734 (Bug#9172)
aac0c6e3 735
7be1c708 7362011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 737
7be1c708
CY
738 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
739 and LC_VERSION_MIN_MACOSX.
740 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
741 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 742
97bb72a6
EZ
7432011-08-08 Eli Zaretskii <eliz@gnu.org>
744
745 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
746 no-display-properties-and-no-overlays under bidi display.
747 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 748 properties and overlays.
97bb72a6 749
d5617611
CY
7502011-08-08 Chong Yidong <cyd@stupidchicken.com>
751
37e11a63
CY
752 * editfns.c (Fset_time_zone_rule): Document relationship with the
753 setenv function.
754
d5617611
CY
755 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
756 the font entity extracted from the cache (Bug#8109).
757
58872834
CY
7582011-08-07 Chong Yidong <cyd@stupidchicken.com>
759
760 * composite.c (autocmp_chars): Don't reset point. That is done by
761 restore_point_unwind (Bug#5984).
762
75bfc667
JL
7632011-08-07 Juri Linkov <juri@jurta.org>
764
765 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
766 to show the arg `TIME' instead of `TIMEVAL'.
767
d1410150
EZ
7682011-08-06 Eli Zaretskii <eliz@gnu.org>
769
770 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
771 display property strides EOL and includes a newline, as in
772 longlines-mode. (Bug#9254)
75b771e4
EZ
773 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
774 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
775
776 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
777 is non-zero, even if the data buffer is NULL. Fixes a crash in
778 vertical-motion with longlines-mode. (Bug#9254)
779
35928349
EZ
7802011-08-05 Eli Zaretskii <eliz@gnu.org>
781
ec7cc85b
EZ
782 * bidi.c <bidi_cache_total_alloc>: Now static.
783 (bidi_initialize): Initialize bidi_cache_total_alloc.
784
8b76d6f8 785 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
786 cache. (Bug#9221)
787
788 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
789 amount allocated this far in `bidi_cache_total_alloc'.
790 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
791 non-zero, only free the data buffer without restoring the cache
792 contents. All callers changed.
793
794 * dispextern.h (bidi_unshelve_cache): Update prototype.
795
796 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
797 (move_it_in_display_line, move_it_to)
798 (move_it_vertically_backward, move_it_by_lines): Replace the call
799 to xfree to an equivalent call to bidi_unshelve_cache.
800 (move_it_in_display_line_to): Fix logic of returning
412b6358 801 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 802
e2e2423b
EZ
8032011-08-05 Eli Zaretskii <eliz@gnu.org>
804
805 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
806 came from a string character with a `cursor' property. (Bug#9229)
807
ae9e757a
JD
8082011-08-04 Jan Djärv <jan.h.d@swipnet.se>
809
810 * Makefile.in (LIB_PTHREAD): New variable.
811 (LIBES): Add LIB_PTHREAD (Bug#9216).
812
813 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
814 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
815
213bd7f2
AS
8162011-08-04 Andreas Schwab <schwab@linux-m68k.org>
817
818 * regex.c (re_iswctype): Remove some redundant boolean
819 conversions.
820
99aaf75f
JD
8212011-08-04 Jan Djärv <jan.h.d@swipnet.se>
822
823 * xterm.c (x_find_topmost_parent): New function.
824 (x_set_frame_alpha): Find topmost parent window with
825 x_find_topmost_parent and set the property there also (bug#9181).
826 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
827
c74e9d86
PE
8282011-08-04 Paul Eggert <eggert@cs.ucla.edu>
829
830 * callproc.c (Fcall_process): Avoid vfork clobbering
831 the local vars buffer, coding_systems, current_dir.
832
640c8776
SM
8332011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
834
835 * keymap.c (Fmake_composed_keymap): Move to subr.el.
836
f26d0e4c
PE
8372011-08-03 Paul Eggert <eggert@cs.ucla.edu>
838
8a10d76c
PE
839 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
840 so that it is not optimized away.
841
f26d0e4c
PE
842 * xdisp.c (compute_display_string_pos): Remove unused local.
843
55439c61
EZ
8442011-08-02 Eli Zaretskii <eliz@gnu.org>
845
846 Fix slow cursor motion and scrolling in large buffers with
847 selective display, like Org Mode buffers. (Bug#9218)
848
849 * dispextern.h (struct bidi_it): New member disp_prop_p.
850
851 * xdisp.c: Remove one-slot cache of display string positions.
852 (compute_display_string_pos): Accept an additional argument
853 DISP_PROP_P; callers changed. Scan at most 5K characters forward
854 for a display string or property. If found, set DISP_PROP_P
855 non-zero.
856
857 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
858 DISP_PROP_P, and pass it to compute_display_string_pos.
859 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
860 non-zero. All callers of bidi_fetch_char changed.
861
fb33fa43
SM
8622011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
863
864 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
865
b099e063
DM
8662010-12-03 Don March <don@ohspite.net>
867
868 * keymap.c (Fdefine_key): Fix non-prefix key error message when
869 last character M-[char] is translated to ESC [char] (bug#7541).
870
5cc7f7af
KH
8712011-08-02 Kenichi Handa <handa@m17n.org>
872
d0fffa3f 873 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
874
875 * chartab.c (uniprop_table): Make it non-static.
876
525d5e6e
EZ
8772011-08-01 Eli Zaretskii <eliz@gnu.org>
878
879 * xdisp.c (forward_to_next_line_start): Accept additional argument
880 BIDI_IT_PREV, and store into it the state of the bidi iterator had
881 on the newline.
882 (reseat_at_next_visible_line_start): Use the bidi iterator state
883 returned by forward_to_next_line_start to restore the state of
884 it->bidi_it after backing up to previous newline. (Bug#9212)
885
31011111
AS
8862011-07-30 Andreas Schwab <schwab@linux-m68k.org>
887
888 * regex.c (re_comp): Protoize.
889 (re_exec): Fix return type.
890 (regexec): Fix type of `ret'. (Bug#9203)
891
e5d76069
PE
8922011-07-29 Paul Eggert <eggert@cs.ucla.edu>
893
894 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
895 This is needed if max-image-size is a floating-point number.
896
9a79b20c
AS
8972011-07-28 Andreas Schwab <schwab@linux-m68k.org>
898
899 * print.c (print_object): Print empty symbol as ##.
900
901 * lread.c (read1): Read ## as empty symbol.
902
d8c2fa78
AA
9032011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
904
905 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
906 setting frame foreground color (Bug#9175).
907 (x_set_background_color): Likewise.
908
ffe57a7a
AA
909 * nsmenu.m (-setText): Size tooltip dimensions precisely to
910 contents (Bug#9176).
911 (EmacsTooltip -init): Remove bezels and add shadows to
912 tooltip windows.
913
bf3492a5
AA
914 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
915 or scroll bar (Bug#8470).
916
d55e9c53
AA
917 * nsfont.m (nsfont_open): Remove assignment to voffset and
918 unnecessary vars hshink, expand, hd, full_height, min_height.
919 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
920
921 * nsterm.h (nsfont_info): Remove voffset field.
922
d8c2fa78 9232011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
924
925 Implement strike-through and overline on NextStep (Bug#8863).
926
927 * nsfont.m (nsfont_open): Use underline position provided by font,
928 instead of hard-coded value of 2.
929 (nsfont_draw): Call ns_draw_text_decoration instead.
930
931 * nsterm.h: Add declaration for ns_draw_text_decoration.
932
933 * nsterm.m (ns_draw_text_decoration): New function for drawing
934 underline, overline, and strike-through.
935 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
936 ns_draw_text_decoration. Change treatment of cursor drawing to
937 accomodate underlining, etc.
938
4cc60b9b
EZ
9392011-07-28 Eli Zaretskii <eliz@gnu.org>
940
bc7ece87
EZ
941 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
942 default.
4cc60b9b 943
476371c4
PE
9442011-07-28 Paul Eggert <eggert@cs.ucla.edu>
945
66606eea
PE
946 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
947 Without this fix, if a signal arrives just after memory fills up,
948 'malloc' might be invoked reentrantly.
949
476371c4
PE
950 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
951 In other words, assume that every image size is allowed, on non-X
952 hosts. This assumption is probably wrong, but it lets Emacs compile.
953
f3fcc40d
AS
9542011-07-28 Andreas Schwab <schwab@linux-m68k.org>
955
956 * regex.c (re_iswctype): Convert return values to boolean.
957
350c992f
EZ
9582011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
959
960 * xdisp.c (compute_display_string_pos): Don't use cached display
961 string position if the buffer had its restriction changed.
962 (Bug#9184)
963
5266b4bb
PE
9642011-07-28 Paul Eggert <eggert@cs.ucla.edu>
965
966 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
967
2573a837 9682011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 969
41f55ccd 970 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 971
39e378da
PE
972 * bidi.c: Integer size and overflow fixes.
973 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
974 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
975 (bidi_cache_find_level_change, bidi_cache_ensure_space)
976 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
977 (bidi_find_other_level_edge):
978 Use ptrdiff_t instead of EMACS_INT where either will do.
979 This works better on 32-bit hosts configured --with-wide-int.
980 (bidi_cache_ensure_space): Check for size-calculation overflow.
981 Use % rather than repeated addition, for better worst-case speed.
982 Don't set bidi_cache_size until after xrealloc returns, because it
983 might not return.
984 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
985 (bidi_cache_ensure_space): Also check that the bidi cache size
986 does not exceed that of the largest Lisp string or buffer. See Eli
987 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 988
5e927815
PE
989 * alloc.c (__malloc_size_t): Remove.
990 All uses replaced by size_t. See Andreas Schwab's note
991 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
992
ca4aa935
PE
993 * image.c: Improve checking for integer overflow.
994 (check_image_size): Assume that f is nonnull, since
995 it is always nonnull in practice. This is one less thing to
996 worry about when checking for integer overflow later.
997 (x_check_image_size): New function, which checks for integer
998 overflow issues inside X.
999 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1000 This removes the need for a memory_full check.
1001 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1002 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1003 (xbm_read_bitmap_data): Change locals back to 'int', since
1004 their values must fit in 'int'.
1005 (xpm_load_image, png_load, tiff_load):
1006 Invoke x_create_x_image_and_pixmap earlier,
1007 to avoid much needless work if the image is too large.
1008 (tiff_load): Treat overly large images as if
1009 x_create_x_image_and_pixmap failed, not as malloc failures.
1010 (gs_load): Use x_check_image_size.
1011
5f8f9cc2
PE
1012 * gtkutil.c: Omit integer casts.
1013 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1014 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1015
5adf60bc
PE
1016 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1017
c8907a93
PE
1018 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1019 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1020 would wrongly return t on a 64-bit host.
1021
e3c25c68
PE
1022 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1023 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1024 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1025 and therefore cause GCC to emit a bogus diagnostic in some cases.
1026
3f791afe
PE
1027 * image.c: Integer signedness and overflow and related fixes.
1028 This is not an exhaustive set of fixes, but it's time to
1029 record what I've got.
1030 (lookup_pixel_color, check_image_size): Remove redundant decls.
1031 (check_image_size): Don't assume that arbitrary EMACS_INT values
1032 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1033 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1034 (tiff_load, imagemagick_load_image):
1035 Check for overflow in size calculations.
1036 (x_create_x_image_and_pixmap): Remove unnecessary test for
1037 xmalloc returning NULL; that can't happen.
1038 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1039 (xpm_color_bucket): Use better integer hashing function.
1040 (xpm_cache_color): Don't possibly over-allocate memory.
1041 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1042 (gif_memory_source):
1043 Use ptrdiff_t, not int or size_t, to record sizes.
1044 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1045 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1046 either works, as we prefer signed integers.
1047 (tiff_read_from_memory, tiff_write_from_memory):
1048 Return tsize_t, not size_t, since that's what the TIFF API wants.
1049 (tiff_read_from_memory): Don't fail simply because the read would
1050 go past EOF; instead, return a short read.
1051 (tiff_load): Omit no-longer-needed casts.
1052 (Fimagemagick_types): Don't assume size fits into 'int'.
1053
3cc5a532
PE
1054 Improve hashing quality when configured --with-wide-int.
1055 * fns.c (hash_string): New function, taken from sxhash_string.
1056 Do not discard information about ASCII character case; this
1057 discarding is no longer needed.
1058 (sxhash-string): Use it. Change sig to match it. Caller changed.
1059 * lisp.h: Declare it.
1060 * lread.c (hash_string): Remove, since we now use fns.c's version.
1061 The fns.c version returns a wider integer if --with-wide-int is
1062 specified, so this should help the quality of the hashing a bit.
1063
b312a492
PE
1064 * emacs.c: Integer overflow minor fix.
1065 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1066 Define only if GNU_LINUX.
1067 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1068
dfd153ae
PE
1069 * dispnew.c: Integer signedness and overflow fixes.
1070 Remove unnecessary forward decls, that were a maintenance hassle.
1071 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1072 All uses changed.
1073 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1074 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1075 (prepare_desired_row, line_draw_cost):
1076 Use int, not unsigned, where either works.
1077 (save_current_matrix, restore_current_matrix):
1078 Use ptrdiff_t, not size_t, where either works.
1079 (init_display): Check for overflow more accurately, and without
1080 relying on undefined behavior.
1081
a81d11a3
PE
1082 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1083 Remove, replacing with the new symbols in lisp.h. All uses changed.
1084 * fileio.c (make_temp_name):
1085 * filelock.c (lock_file_1, lock_file):
1086 * xdisp.c (message_dolog):
1087 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1088 Use pMd etc. instead.
1089 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1090 replacing the pWIDE etc. symbols removed from editfns.c.
1091
3300e6fd
PE
1092 * keyboard.h (num_input_events): Now uintmax_t.
1093 This is (very slightly) less likely to mess up due to wraparound.
1094 All uses changed.
1095
fd05c7e9
PE
1096 * buffer.c: Integer signedness fixes.
1097 (alloc_buffer_text, enlarge_buffer_text):
1098 Use ptrdiff_t rather than size_t when either will do, as we prefer
1099 signed integers.
1100
903fe15d
PE
1101 * alloc.c: Integer signedness and overflow fixes.
1102 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1103 (__malloc_size_t): Default to size_t, not to int.
1104 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1105 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1106 Prefer ptrdiff_t to size_t when either would do, as we prefer
1107 signed integers.
1108 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1109 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1110 Now const. Initialize with values that are in range even if char
1111 is signed.
1112 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1113 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1114 These functions do the right thing with sizes > 2**32.
1115 (check_depth): Now ptrdiff_t, not int.
1116 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1117 Adjust to new way of storing sizes. Check for size overflow bugs
1118 in rest of code.
1119 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1120 slightly wrong anyway, as it missed one instance of
1121 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1122 (refill_memory_reserve): Omit needless cast to size_t.
1123 (mark_object_loop_halt): Mark as externally visible.
1124
ac82cc6a
PE
1125 * xselect.c: Integer signedness and overflow fixes.
1126 (Fx_register_dnd_atom, x_handle_dnd_message):
1127 Use ptrdiff_t, not size_t, since we prefer signed.
1128 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1129 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1130 x_dnd_atoms_size and x_dnd_atoms_length.
1131
c2d1e36d
PE
1132 * doprnt.c: Prefer signed to unsigned when either works.
1133 * eval.c (verror):
1134 * doprnt.c (doprnt):
1135 * lisp.h (doprnt):
1136 * xdisp.c (vmessage):
1137 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1138 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1139 prefer signed arithmetic to avoid comparison confusion.
1140 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1141 but is a bit tricky.
1142
0e926e56
PE
1143 Assume freestanding C89 headers, string.h, stdlib.h.
1144 * data.c, doprnt.c, floatfns.c, print.c:
1145 Include float.h unconditionally.
1146 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1147 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1148 * regex.c: Likewise for stddef.h, string.h.
1149 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1150 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1151 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1152 (STDC_HEADERS): Remove obsolete defines.
1153 * sysdep.c: Include limits.h unconditionally.
1154
9cfdb3ec
PE
1155 Assume support for memcmp, memcpy, memmove, memset.
1156 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1157 * regex.c (memcmp, memcpy):
1158 Remove; we assume C89 now.
1159
1160 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1161 (__malloc_safe_bcopy): Remove; no longer needed.
1162
cf950e6b 1163 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1164 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1165 well either way, and we prefer signed to unsigned.
1166
dbf38e02
LMI
11672011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1168
1169 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1170 closes the connection while we're reading (bug#9182).
1171
d6f0886c
JD
11722011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1173
1174 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1175 are specified (Bug#9168).
1176
2eb1f9e6
PE
11772011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1178
1179 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1180 Found by GCC static checking and --with-wide-int on a 32-bit host.
1181
22381272 11822011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1183
1184 * xdisp.c (compute_display_string_pos): Fix logic of caching
1185 previous display string position. Initialize cached_prev_pos to
1186 -1. Fixes slow-down at the beginning of a buffer.
1187
f25e39b4
EZ
11882011-07-24 Eli Zaretskii <eliz@gnu.org>
1189
1190 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1191 for attrs[LFACE_FONTSET_INDEX].
1192
04c4b52e
PE
11932011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1194
1195 * xml.c (parse_region): Remove unused local
1196 that was recently introduced.
1197
c1734fbd
EZ
11982011-07-23 Eli Zaretskii <eliz@gnu.org>
1199
be18c5a5
EZ
1200 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1201 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1202
c1734fbd
EZ
1203 * xdisp.c (move_it_in_display_line_to): Record the best matching
1204 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1205 exit if none of the characters scanned was an exact match.
1206 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1207 when exact match is impossible due to invisible text, and the
1208 lines are truncated.
1209
a258d627
JD
12102011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1211
1212 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1213 for OSX >= 10.7.
1214
b6d5a689
EZ
12152011-07-22 Eli Zaretskii <eliz@gnu.org>
1216
0f74f785
EZ
1217 Fix a significant slow-down of cursor motion with C-n, C-p,
1218 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1219 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1220 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1221 (next_element_from_buffer): Call compute_stop_pos_backwards to
1222 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1223 base_level_stop.
1224 (reseat): Don't look for prev_stop, as that could mean a very long
1225 run.
1226 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1227 <cached_disp_overlay_modiff>: Cache for last found display string
1228 position.
551918c1 1229 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1230 about the same buffer in the same area of character positions, and
1231 the buffer wasn't changed since the time the display string
1232 position was cached.
551918c1 1233
b2d0c91a
EZ
12342011-07-22 Eli Zaretskii <eliz@gnu.org>
1235
1236 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1237 is an integer, which is important for empty lines. (Bug#9149)
1238
043604ee
CY
12392011-07-22 Chong Yidong <cyd@stupidchicken.com>
1240
1241 * frame.c (Fmodify_frame_parameters): In tty case, update the
1242 default face if necessary (Bug#4238).
1243
da4adb04
CY
12442011-07-21 Chong Yidong <cyd@stupidchicken.com>
1245
1246 * editfns.c (Fstring_to_char): No need to explain what a character
1247 is in the docstring (Bug#6576).
1248
9abd0532
LMI
12492011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1250
1251 * xml.c (parse_region): Make sure we always return a tree.
1252
36881d16
HK
12532011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1254
1255 * xml.c (parse_region): If a document contains only comments,
1256 return that, too.
1257
1e98674d
LMI
12582011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1259
1260 * xml.c (make_dom): Return comments, too.
1261
590bd467
PE
12622011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1263
1264 Port to OpenBSD.
1265 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1266 and the surrounding thread.
1267 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1268 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1269 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1270 timer goes off.
1271 * s/openbsd.h (BROKEN_SIGIO): Define.
1272 * unexelf.c (unexec) [__OpenBSD__]:
1273 Don't update the .mdebug section of the Alpha COFF symbol table.
1274
f41628b2
LMI
12752011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1276
1277 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1278 (bug#8460).
1279
b59b67c5
PE
12802011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1281
15e3a074
PE
1282 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1283 This fixes some race conditions on the permissions of any newly
1284 created file.
1285
41bed37d
PE
1286 * alloc.c (valid_pointer_p): Use pipe, not open.
1287 This fixes some permissions issues when debugging.
1288
b59b67c5
PE
1289 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1290 If fchown fails to set both uid and gid, try to set just gid,
1291 as that is sometimes allowed. Adjust the file's mode to eliminate
1292 setuid or setgid bits that are inappropriate if fchown fails.
1293
925a6be7
SM
12942011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1295
1296 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1297 to compare Lisp_Objects.
1298 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1299 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1300 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1301
52968808
AS
13022011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1303
0a6a104b
AS
1304 * lread.c (read_integer): Unread even EOF character.
1305 (read1): Likewise. Properly record start position of symbol.
1306
52968808
AS
1307 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1308 symbol character follows.
1309
9e381cdd
PE
13102011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1311
1312 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1313 This works around a problem with the previous change to Fcopy_file.
1314 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1315 and without this change, GCC might complain about discarding
1316 fchown's return value.
1317
b5641435
JB
13182011-07-16 Juanma Barranquero <lekktu@gmail.com>
1319
1320 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1321
a8031457
PE
13222011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1323
1324 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1325
dd889327
LMI
13262011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1327
750c33f7
LMI
1328 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1329 it's used from the C level.
1330
dd889327
LMI
1331 * process.c: Use the same condition for POLL_FOR_INPUT in both
1332 keyboard.c and process.c (bug#1858).
1333
87e86684
LM
13342011-07-09 Lawrence Mitchell <wence@gmx.li>
1335
1336 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1337 (Fgnutls_boot): Use it.
1338
64348f40
AS
13392011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1340
1341 * doc.c (Fsubstitute_command_keys): Revert last change.
1342
1d698799
LMI
13432011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1344
f863868c
LMI
1345 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1346 quotes the next character, and doesn't affect other longer
1347 sequences (bug#8935).
1348
1d698799
LMI
1349 * lread.c (syms_of_lread): Clarify that is isn't only
1350 `eval-buffer' and `eval-defun' that's affected by
1351 `lexical-binding' (bug#8460).
1352
aa4b6df6
EZ
13532011-07-15 Eli Zaretskii <eliz@gnu.org>
1354
1355 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1356 bidi redisplay when a line includes both an image and is
1357 truncated.
1358
5d856da6
PE
13592011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1360
ad6042bb
PE
1361 Fix minor problems found by static checking.
1362 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1363 (elsz): Now a signed constant, not a size_t var. We prefer signed
1364 types to unsigned, to avoid integer comparison confusion. Without
1365 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1366 "cannot optimize loop, the loop counter may overflow", a symptom
1367 of the confusion.
f00bbb22 1368 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1369 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1370
6468f31c
LMI
13712011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1372
49080b10
LMI
1373 * search.c (Fre_search_backward): Mention `case-fold-search' in
1374 all the re_search_* functions (bug#8138).
1375
6468f31c
LMI
1376 * keyboard.c (Fopen_dribble_file): Document when the file is
1377 closed (bug#8056).
1378
c965adc5
EZ
13792011-07-14 Eli Zaretskii <eliz@gnu.org>
1380
df9733bf
EZ
1381 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1382 bidi_cache_idx.
1383
0bb23927
EZ
1384 Support bidi reordering of display and overlay strings.
1385 * xdisp.c (compute_display_string_pos)
1386 (compute_display_string_end): Accept additional argument STRING.
1387 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1388 (reseat_to_string): Initialize bidi_it->string.s and
1389 bidi_it->string.schars.
1390 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1391 NULL (avoids a crash in bidi_paragraph_init).
1392 Initialize itb.string.lstring.
0bb23927
EZ
1393 (init_iterator): Call bidi_init_it only of a valid
1394 buffer position was specified. Initialize paragraph_embedding to
1395 L2R.
1396 (reseat_to_string): Initialize the bidi iterator.
1397 (display_string): If we need to ignore text properties of
1398 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1399 original value of -1 will not work with bidi.)
1400 (compute_display_string_pos): First arg is now struct
1401 `text_pos *'; all callers changed. Support display properties on
1402 Lisp strings.
1403 (compute_display_string_end): Support display properties on Lisp
1404 strings.
1405 (init_iterator, reseat_1, reseat_to_string): Initialize the
1406 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1407 when iterating on a string not from display properties).
640c8776
SM
1408 (compute_display_string_pos, compute_display_string_end):
1409 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1410 arrow keys.
1411 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1412 base_level_stop; instead, set base_level_stop to BEGV.
1413 Fixes crashes in vertical-motion.
0bb23927
EZ
1414 (next_element_from_buffer): Improve commentary for when
1415 the iterator is before prev_stop.
1416 (init_iterator): Initialize bidi_p from the default value of
1417 bidi-display-reordering, not from buffer-local value. Use the
1418 buffer-local value only if initializing for buffer iteration.
1419 (handle_invisible_prop): Support invisible properties on strings
1420 that are being bidi-reordered.
1421 (set_iterator_to_next): Support bidi reordering of C strings and
1422 Lisp strings.
1423 (next_element_from_string): Support bidi reordering of Lisp
1424 strings.
1425 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
1426 (display_string): Support display of R2L glyph rows.
1427 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
1428 (init_iterator): Don't initialize it->bidi_p for strings
1429 here.
1430 (reseat_to_string): Initialize it->bidi_p for strings here.
1431 (next_element_from_string, next_element_from_c_string)
1432 (next_element_from_buffer): Add xassert's for correspondence
1433 between IT's object being iterated and it->bidi_it.string
1434 structure.
1435 (face_before_or_after_it_pos): Support bidi iteration.
1436 (next_element_from_c_string): Handle the case of the first string
1437 character that is not the first one in the visual order.
1438 (get_visually_first_element): New function, refactored from common
1439 parts of next_element_from_buffer, next_element_from_string, and
1440 next_element_from_c_string.
1441 (tool_bar_lines_needed, redisplay_tool_bar)
1442 (display_menu_bar): Force left-to-right direction. Add a FIXME
1443 comment for making that be controlled by a user option.
1444 (push_it, pop_it): Save and restore the state of the
1445 bidi iterator. Save and restore the bidi_p flag.
1446 (pop_it): Iterate out of display property for string iteration as
1447 well.
1448 (iterate_out_of_display_property): Support iteration over strings.
1449 (handle_single_display_spec): Set up it->bidi_it for iteration
1450 over a display string, and call bidi_init_it.
1451 (handle_single_display_spec, next_overlay_string)
1452 (get_overlay_strings_1, push_display_prop): Set up the bidi
1453 iterator for displaying display or overlay strings.
1454 (forward_to_next_line_start): Don't use the shortcut if
1455 bidi-iterating.
1456 (back_to_previous_visible_line_start): If handle_display_prop
1457 pushed the iterator stack, restore the internal state of the bidi
1458 iterator by calling bidi_pop_it same number of times.
1459 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1460 and we are bidi-iterating, don't decrement the iterator position;
1461 instead, set the first_elt flag in the bidi iterator, to produce
1462 the same effect.
1463 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1464 (push_display_prop): xassert that we are iterating a buffer.
1465 (push_it, pop_it): Save and restore paragraph_embedding member.
1466 (handle_single_display_spec, next_overlay_string)
1467 (get_overlay_strings_1, reseat_1, reseat_to_string)
1468 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1469 correctly. Don't assume unibyte strings are not bidi-reordered.
1470 (compute_display_string_pos)
1471 (compute_display_string_end): Fix handling the case of C string.
1472 (push_it, pop_it): Save and restore from_disp_prop_p.
1473 (handle_single_display_spec, push_display_prop): Set the
1474 from_disp_prop_p flag.
1475 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1476 (pop_it): Call iterate_out_of_display_property only if we are
1477 popping after iteration over a string that came from a display
1478 property. Fix a typo in popping stretch info. Add an assertion
1479 for verifying that the iterator position is in sync with the bidi
1480 iterator.
1481 (handle_single_display_spec, get_overlay_strings_1)
1482 (push_display_prop): Fix initialization of paragraph direction for
1483 string when that of the parent object is not yet determined.
1484 (reseat_1): Call bidi_init_it to resync the bidi
1485 iterator with IT's position. (Bug#7616)
1486 (find_row_edges): If ROW->start.pos gives position
1487 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1488 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1489 Reset the from_disp_prop_p flag.
1490 (SAVE_IT, RESTORE_IT): New macros.
1491 (pos_visible_p, face_before_or_after_it_pos)
1492 (back_to_previous_visible_line_start)
1493 (move_it_in_display_line_to, move_it_in_display_line)
1494 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1495 (try_scrolling, redisplay_window, display_line): Use them when
1496 saving a temporary copy of the iterator and restoring it back.
1497 (back_to_previous_visible_line_start, reseat_1)
1498 (init_iterator): Empty the bidi cache "stack".
1499 (move_it_in_display_line_to): If iterator ended up at
1500 EOL, but we never saw any buffer positions smaller than
1501 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1502 motion in bidi-reordered lines.
1503 (move_it_in_display_line_to): Record prev_method and prev_pos
1504 immediately before the call to set_iterator_to_next. Fixes cursor
1505 motion in bidi-reordered lines with stretch glyphs and strings
1506 displayed in margins. (Bug#8133) (Bug#8867)
1507 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1508 TO_CHARPOS.
640c8776
SM
1509 (pos_visible_p): Support positions in bidi-reordered lines.
1510 Save and restore bidi cache.
0bb23927
EZ
1511
1512 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1513 (bidi_paragraph_info): Delete unused struct.
1514 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1515 (bidi_cache_start): New variable.
1516 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1517 to zero.
1518 (bidi_cache_fetch_state, bidi_cache_search)
1519 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1520 (bidi_cache_find, bidi_peek_at_next_level)
1521 (bidi_level_of_next_char, bidi_find_other_level_edge)
1522 (bidi_move_to_visually_next): Compare cache index with
1523 bidi_cache_start rather than with zero.
1524 (bidi_fetch_char): Accept new argument STRING; all callers
1525 changed. Support iteration over a string. Support strings with
1526 display properties. Support unibyte strings. Fix the type of
1527 `len' according to what STRING_CHAR_AND_LENGTH expects.
1528 (bidi_paragraph_init, bidi_resolve_explicit_1)
1529 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
1530 (bidi_level_of_next_char, bidi_move_to_visually_next):
1531 Support iteration over a string.
0bb23927
EZ
1532 (bidi_set_sor_type, bidi_resolve_explicit_1)
1533 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1534 can now be zero (for strings); special values 0 and -1 were
1535 changed to -1 and -2, respectively.
1536 (bidi_char_at_pos): New function.
1537 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1538 Call it instead of FETCH_MULTIBYTE_CHAR.
1539 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1540 initialized to valid values.
1541 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1542 values.
1543 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1544 the test for valid cached positions. Fix the logic for looking up
1545 the sentinel state in the cache. GCPRO the Lisp string we are
1546 iterating.
1547 (bidi_push_it, bidi_pop_it): New functions.
1548 (bidi_initialize): Initialize the bidi cache start stack pointer.
1549 (bidi_cache_ensure_space): New function, refactored from part of
1550 bidi_cache_iterator_state. Don't assume the required size is just
1551 one BIDI_CACHE_CHUNK away.
1552 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1553 (bidi_count_bytes, bidi_char_at_pos): New functions.
1554 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1555 always valid if bidi_cache_idx is valid.
1556 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1557 is valid if it's going to be used.
1558 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1559 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
1560 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1561 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
1562 (bidi_find_other_level_edge, bidi_cache_start_stack):
1563 All variables related to cache indices are now EMACS_INT.
c965adc5 1564
0bb23927
EZ
1565 * dispextern.h (struct bidi_string_data): New structure.
1566 (struct bidi_it): New member `string'. Make flag members be 1-bit
1567 fields, and put them last in the struct.
640c8776
SM
1568 (compute_display_string_pos, compute_display_string_end):
1569 Update prototypes.
0bb23927
EZ
1570 (bidi_push_it, bidi_pop_it): Add prototypes.
1571 (struct iterator_stack_entry): New members bidi_p,
1572 paragraph_embedding, and from_disp_prop_p.
1573 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
1574 (bidi_shelve_cache, bidi_unshelve_cache):
1575 Declare prototypes.
0bb23927
EZ
1576
1577 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1578 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1579 and vector-like objects.
1580
1581 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1582 cache around display iteration.
1583
1584 * window.c (Fwindow_end, window_scroll_pixel_based)
1585 (displayed_window_lines, Frecenter): Save and restore the bidi
1586 cache around display iteration.
1587
3bbd2265
LMI
15882011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1589
1590 * editfns.c (Fdelete_region): Clarify the use of the named
1591 parameters (bug#6788).
1592
adc47434
MR
15932011-07-14 Martin Rudalics <rudalics@gmx.at>
1594
1595 * indent.c (Fvertical_motion): Set and restore w->pointm when
1596 saving and restoring the window's buffer (Bug#9006).
1597
837c31f8
LMI
15982011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1599
1600 * editfns.c (Fstring_to_char): Clarify just what is returned
1601 (bug#6576). Text by Eli Zaretskii.
1602
ac389d0c
JB
16032011-07-13 Juanma Barranquero <lekktu@gmail.com>
1604
1605 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1606
0be0ce47
EZ
16072011-07-13 Eli Zaretskii <eliz@gnu.org>
1608
1609 * buffer.c (mmap_find): Fix a typo.
1610
cd18e7e3
JB
16112011-07-13 Johan Bockgård <bojohan@gnu.org>
1612
1613 Fix execution of x selection hooks.
1614 * xselect.c (Qx_lost_selection_functions)
1615 (Qx_sent_selection_functions): New vars.
1616 (syms_of_xselect): DEFSYM them.
1617 (x_handle_selection_request): Pass Qx_sent_selection_functions
1618 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1619 (x_handle_selection_clear,x_clear_frame_selections):
1620 Pass Qx_lost_selection_functions rather than
1621 Vx_lost_selection_functions to Frun_hook_with_args.
1622
47ea7f44
PE
16232011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1624
ac389d0c 1625 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
1626 The old code sometimes used this field without initializing it.
1627
47ea7f44
PE
1628 * alloc.c (gc_sweep): Don't read past end of array.
1629 In theory, the old code could also have corrupted Emacs internals,
1630 though it'd be very unlikely.
1631
bc985c87
AS
16322011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1633
1634 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 1635 argument. (Bug#4026)
bc985c87 1636
0cf34688
LMI
16372011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1638
b3dadd76
LMI
1639 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1640 key" (bug#4257).
1641
0cf34688
LMI
1642 * window.c (Fset_window_start): Doc fix (bug#4199).
1643 (Fset_window_hscroll): Ditto.
1644
270768cd
PE
16452011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1646
077e3dda 1647 Fix minor new problems caught by GCC 4.6.1.
270768cd 1648 * term.c (init_tty): Remove unused local.
490011a6 1649 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 1650 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 1651 not used otherwise.
270768cd 1652
b1f58454
CY
16532011-07-12 Chong Yidong <cyd@stupidchicken.com>
1654
1655 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1656
22b9578d
LMI
16572011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1658
6e70ab07
LMI
1659 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1660 are the mini-buffer and the echo area (bug#3320).
1661
22b9578d
LMI
1662 * term.c (init_tty): Remove support for supdup, c10 and perq
1663 terminals, which are no longer supported (bug#1482).
1664
8974cc9f
JB
16652011-07-10 Johan Bockgård <bojohan@gnu.org>
1666
1667 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1668
a560d974
JD
16692011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1670
1671 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1672 for non-popups (Bug#3642).
1673
1dae0f0a
AS
16742011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1675
268c2c36 1676 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 1677 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
1678 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1679 * cm.c (losecursor): Likewise.
1dae0f0a
AS
1680 * data.c (fmod): Likewise.
1681 * dispnew.c (swap_glyphs_in_rows): Likewise.
1682 * emacs.c (memory_warning_signal): Likewise.
1683 * floatfns.c (float_error): Likewise.
1684 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1685 (otf_open, font_otf_capability, generate_otf_features)
1686 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1687 Likewise.
1688 * image.c (pbm_read_file): Likewise.
1689 * indent.c (string_display_width): Likewise.
1690 * intervals.c (check_for_interval, search_for_interval)
1691 (inc_interval_count, count_intervals, root_interval)
1692 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1693 * lread.c (defalias): Likewise.
268c2c36 1694 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
1695 * regex.c (set_image_of_range_1, set_image_of_range)
1696 (regex_grow_registers): Likewise.
1697 * sysdep.c (strerror): Likewise.
1698 * termcap.c (valid_filename_p, tprint, main): Likewise.
1699 * tparam.c (main): Likewise.
1700 * unexhp9k800.c (run_time_remap, save_data_space)
1701 (update_file_ptrs, read_header, write_header, calculate_checksum)
1702 (copy_file, copy_rest, display_header): Likewise.
1703 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1704 Likewise.
1705 * xdisp.c (check_it): Likewise.
1706 * xfaces.c (register_color, unregister_color, unregister_colors):
1707 Likewise.
1708 * xfns.c (print_fontset_result): Likewise.
1709 * xrdb.c (member, fatal, main): Likewise.
1710
99033785
PE
17112011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1712
1713 Fix minor problems found by static checking (Bug#9031).
1714 * chartab.c (char_table_set_range, map_sub_char_table):
1715 Remove unused locals.
1716 (uniprop_table): Now static.
1717 * composite.c (_work_char): Remove unused static var.
1718
9cb2ac56
JB
17192011-07-09 Juanma Barranquero <lekktu@gmail.com>
1720
1721 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1722
f25661f0
JD
17232011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1724
1725 * gtkutil.c (qttip_cb): Remove code without function.
1726
8278c4fe
EZ
17272011-07-09 Eli Zaretskii <eliz@gnu.org>
1728
1729 * w32.c (pthread_sigmask): New stub.
1730
1692ae2d 17312011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 1732
8a6ebd58 1733 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
1734 sigprocmask is portable only for single-threaded applications, and
1735 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
1736 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1737 (LIBES): Use it.
1738 * callproc.c (Fcall_process):
1739 * process.c (create_process):
1740 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1741 Use pthread_sigmask, not sigprocmask.
123403e4 1742
1b854618
JD
17432011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1744
1745 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1746 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1747 wrong (Bug#8591).
1748
3fe4b549
JD
17492011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1750
0ce7e563
JD
1751 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1752 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1753 (xg_hide_tooltip): Fix comment.
1754
3fe4b549
JD
1755 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1756 in registerServicesMenuSendTypes.
1757 (validRequestorForSendType): Don't check ns_return_types.
1758
1759 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1760 ns_return_type.
1761
5df75e47
JR
17622011-07-08 Jason Rumney <jasonr@gnu.org>
1763
1764 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1765 frame struct members of non-existent frames (Bug#6284).
1766
699c10bd
JD
17672011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1768
4393663b
JD
1769 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1770 variable firstTime not needed on OSX >= 10.6.
1771 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1772 >= 10.5. Use setKnobProportion, setDoubleValue.
1773
1774 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1775 (MAC_OS_X_VERSION_10_5): Define if not defined.
1776 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1777 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1778 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1779
1780 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1781 cString and lossyCString on OSX >= 10.4
1782
1783 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1784 sizeToFit on OSX >= 10.2.
1785
1786 * nsimage.m (allocInitFromFile): Don't use deprecated method
1787 bestRepresentationForDevice on OSX >= 10.6.
1788
1789 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1790 to avoid warning.
1791
1792 * emacs.c: Declare unexec_init_emacs_zone.
1793
a63e0781
JD
1794 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1795
699c10bd
JD
1796 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1797
1798 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1799 on svcsMenu (Bug#8842).
1800
1801 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1802 ns_return_types.
1803 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1804
1805 * nsterm.m (QUTF8_STRING): Declare.
1806 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1807 (validRequestorForSendType): Return type is (id).
1808 Change indexOfObjectIdenticalTo to indexOfObject.
1809 Check if we have local selection before returning self (Bug#8842).
1810 (writeSelectionToPasteboard): Put local selection into paste board
1811 if we have a local selection (Bug#8842).
1812 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1813
1814 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1815 (ns_get_local_selection): Declare.
1816
54e10184
LMI
18172011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1818
9888ff71
LMI
1819 * keymap.c (describe_map_tree): Don't insert a double newline at
1820 the end of the buffer (bug#1169) and return whether we inserted
1821 something.
1822
54e10184
LMI
1823 * callint.c (Fcall_interactively): Change "reading args" to
1824 "providing args" to try to clarify what it does (bug#1010).
1825
15fa4783
KH
18262011-07-07 Kenichi Handa <handa@m17n.org>
1827
1828 * composite.c (composition_compute_stop_pos): Ignore a static
1829 composition starting before CHARPOS (Bug#8915).
1830
1831 * xdisp.c (handle_composition_prop): Likewise.
1832
a8815b00
EZ
18332011-07-07 Eli Zaretskii <eliz@gnu.org>
1834
1835 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1836 (Bug#9015)
1837
ef7b981d 18382011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
1839
1840 * character.h (unicode_category_t): New enum type.
1841
1842 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1843 (Qchar_code_property_table): New variable.
1844 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1845 (UNIPROP_COMPRESSED_FORM_P): New macros.
1846 (char_table_ascii): Uncompress the compressed values.
1847 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1848 Uncompress the compressed values.
ac389d0c 1849 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
1850 (char_table_ref_and_range): Uncompress the compressed values.
1851 (sub_char_table_set): New arg is_uniprop. Callers changed.
1852 Uncompress the compressed values.
1853 (sub_char_table_set_range): Args changed. Callers changed.
1854 (char_table_set_range): Adjuted for the above change.
1855 (map_sub_char_table): Delete args default_val and parent. Add arg
1856 top. Give decoded values to a Lisp function.
640c8776 1857 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
1858 values to a Lisp function. Gcpro more variables.
1859 (uniprop_table_uncompress)
1860 (uniprop_decode_value_run_length): New functions.
1861 (uniprop_decoder, uniprop_decoder_count): New variables.
1862 (uniprop_get_decoder, uniprop_encode_value_character)
1863 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1864 New functions.
1865 (uniprop_encoder, uniprop_encoder_count): New variables.
1866 (uniprop_get_encoder, uniprop_table)
1867 (Funicode_property_table_internal, Fget_unicode_property_internal)
1868 (Fput_unicode_property_internal): New functions.
1869 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1870 Sunicode_property_table_internal, Sget_unicode_property_internal,
1871 and Sput_unicode_property_internal. Defvar_lisp
1872 char-code-property-alist.
1873
640c8776 1874 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
1875 Vunicode_category_table.
1876
640c8776 1877 * font.c (font_range): Adjust for the change of
c805dec0
KH
1878 Vunicode_category_table.
1879
76b397fb
DN
18802011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1881
1882 * m/iris4d.h: Remove file, move contents ...
1883 * s/irix6-5.h: ... here.
1884
22b4128e
PE
18852011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1886
1887 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
1888 * alloc.c (mark_buffer):
1889 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1890 (clone_per_buffer_values): Don't assume that
22b4128e
PE
1891 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1892 This isn't true in general, and it's particularly not true
1893 if Emacs is configured with --with-wide-int.
1894 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1895 New macros, used in the buffer.c change.
1896
869795d6
JD
18972011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1898
1899 * xsettings.c: Use both GConf and GSettings if both are available.
1900 (store_config_changed_event): Add comment.
1901 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1902 (store_tool_bar_style_changed): New functions.
1903 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1904 (struct xsettings): Move font inside HAVE_XFT.
1905 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 1906 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 1907 Move inside HAVE_XFT.
640c8776 1908 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
1909 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1910 also.
1911 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
640c8776
SM
1912 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1913 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
1914 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1915 (parse_settings): Move check for font inside HAVE_XFT.
1916 (read_settings, apply_xft_settings): Add comment.
1917 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1918 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1919 call store_font_name_changed.
1920 (xft_settings_event): Add comment.
1921 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1922 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1923 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1924 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1925 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
1926 (xsettings_get_system_font, xsettings_get_system_normal_font):
1927 Add comment.
869795d6 1928
d8ed26bd
PE
19292011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1930
1931 Random fixes. E.g., (random) never returned negative values.
1932 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1933 subseconds part to the entropy, as that's a bit more random.
1934 Prefer signed to unsigned, since the signedness doesn't matter and
1935 in general we prefer signed. When given a limit, use a
1936 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1937 latter isn't right if USE_2_TAGS_FOR_INTS.
1938 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1939 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1940
cabf1cac
SM
19412011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1942
1943 * textprop.c (text_property_stickiness):
1944 Obey Vtext_property_default_nonsticky.
1945 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1946 * w32fns.c (syms_of_w32fns):
1947 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1948
6e9b2be9
PE
19492011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1950
1951 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1952 This is more efficient than Ffile_directory_p and avoids a minor race.
1953
90186c68
LMI
19542011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1955
7c301272
LMI
1956 * buffer.c (Foverlay_put): Say what the return value is
1957 (bug#7835).
1958
c4f2d8d4
LMI
1959 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1960 is a directory before asking whether to use the file name
1961 (bug#7564).
ad637907
LMI
1962 (barf_or_query_if_file_exists): Make the "File is a directory"
1963 error be more correct.
c4f2d8d4 1964
90186c68
LMI
1965 * fns.c (Frequire): Remove the mention of the .gz files, since
1966 that's installation-specific, but keep the mention of
1967 `get-load-suffixes'.
1968
da64016e
PE
19692011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1970
1971 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1972 Report string overflow if the output is too long.
1973
7d47b580
JB
19742011-07-04 Juanma Barranquero <lekktu@gmail.com>
1975
a555cb87
JB
1976 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1977 (syms_of_gnutls): Remove duplicate DEFSYM for
1978 Qgnutls_bootprop_verify_hostname_error, an error for
1979 Qgnutls_bootprop_verify_error (which is no longer used).
1980
7d47b580
JB
1981 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1982 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1983 Also (re)move comments that are misplaced or no longer relevant.
1984
1e49bfab
LMI
19852011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1986
1987 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1988
1485f4c0
CY
19892011-07-03 Chong Yidong <cyd@stupidchicken.com>
1990
1991 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1992 and background color parameters if they have been changed.
1993
a9ab721e
LMI
19942011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1995
1996 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1997
cf7cff57
PE
19982011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1999
2e13213d
PE
2000 * xsettings.c (SYSTEM_FONT): Define only when used.
2001 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2002
cf7cff57
PE
2003 * keymap.c (access_keymap_1): Now static.
2004
7a8e04f7
CY
20052011-07-02 Chong Yidong <cyd@stupidchicken.com>
2006
2007 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2008 leave any prefix arg for the up event (Bug#1586).
2009
61352f62
LMI
20102011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2011
69bb1ef7
LMI
2012 * lread.c (syms_of_lread): Mention single symbols defined by
2013 `defvar' or `defconst' (bug#7154).
2014
61352f62 2015 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2016 (Frequire): Mention get-load-suffixes.
61352f62 2017
28545e04
MR
20182011-07-02 Martin Rudalics <rudalics@gmx.at>
2019
2020 * window.h (window): Remove clone_number slot.
2021 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2022 Remove.
2023 (make_parent_window, make_window, saved_window)
2024 (Fset_window_configuration, save_window_save): Don't deal with
2025 clone numbers.
2026 * buffer.c (Qclone_number): Remove declaration.
2027 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2028
3349e122
SM
20292011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2030
2031 Add multiple inheritance to keymaps.
2032 * keymap.c (Fmake_composed_keymap): New function.
2033 (Fset_keymap_parent): Simplify.
2034 (fix_submap_inheritance): Remove.
2035 (access_keymap_1): New function extracted from access_keymap to handle
2036 embedded parents and handle lists of maps.
2037 (access_keymap): Use it.
2038 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2039 (Fcopy_keymap): Handle embedded parents.
2040 (Fcommand_remapping, define_as_prefix): Simplify.
2041 (Fkey_binding): Simplify.
2042 (syms_of_keymap): Move minibuffer-local-completion-map,
2043 minibuffer-local-filename-completion-map,
2044 minibuffer-local-must-match-map, and
2045 minibuffer-local-filename-must-match-map to Elisp.
2046 (syms_of_keymap): Defsubr make-composed-keymap.
2047 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2048 (parse_menu_item): Trivial simplification.
2049
3279eb87
GM
20502011-07-01 Glenn Morris <rgm@gnu.org>
2051
2052 * Makefile.in (SETTINGS_LIBS): Fix typo.
2053
4550efdf
KI
20542011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2055
2056 * coding.c (Fencode_coding_string): Record the last coding system
2057 used, as the function doc string says (bug#8738).
2058
0949d2b6
JD
20592011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2060
2061 * xsettings.c (store_monospaced_changed): Take new font as arg and
2062 check for change against current_mono_font.
2063 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2064 (emacs_settings_constructor, emacs_settings_get_property)
2065 (emacs_settings_set_property, emacs_settings_class_init)
2066 (emacs_settings_init, gsettings_obj): Remove.
2067 (something_changedCB): New function for HAVE_GSETTINGS.
2068 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2069 with value as argument.
2070 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2071 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2072 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2073 "changed".
2074
2075 * xgselect.c: Add defined (HAVE_GSETTINGS).
2076 (xgselect_initialize): Ditto.
2077
2078 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2079 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2080 xg_select.
2081
bbc6b304
PE
20822011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2083
2084 * eval.c (struct backtrace): Simplify and port the data structure.
2085 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2086 signed bit field, as this assumption is not portable and it makes
2087 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2088 "char debug_on_exit : 1" as this is not portable either; instead,
2089 use the portable "unsigned int debug_on_exit : 1". Remove unused
2090 member evalargs. Remove obsolete comments about cc bombing out.
2091
9851bfc5
JD
20922011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2093
51bb811f 2094 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2095 Let HAVE_GSETTINGS override HAVE_GCONF.
2096 (store_monospaced_changed): New function.
2097 (EMACS_SETTINGS): A new type derived from GObject to handle
2098 GSettings notifications.
2099 (emacs_settings_constructor, emacs_settings_get_property)
2100 (emacs_settings_set_property, emacs_settings_class_init):
2101 New functions.
2102 (gsettings_client, gsettings_obj): New variables.
2103 (GSETTINGS_SCHEMA): New define.
2104 (something_changedCB): Call store_monospaced_changed.
2105 (init_gsettings): New function.
2106 (xsettings_initialize): Call init_gsettings.
2107 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2108 to NULL.
2109
640c8776 2110 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2111 GCONF_CFLAGS/LIBS.
2112
5386012d
MR
21132011-06-29 Martin Rudalics <rudalics@gmx.at>
2114
2115 * window.c (resize_root_window, grow_mini_window)
2116 (shrink_mini_window): Rename Qresize_root_window to
2117 Qwindow_resize_root_window and Qresize_root_window_vertically to
2118 Qwindow_resize_root_window_vertically.
2119
f13e0b08
PE
21202011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2121
2122 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2123
94515237
JB
21242011-06-27 Juanma Barranquero <lekktu@gmail.com>
2125
2126 * makefile.w32-in: Redesign dependencies so they reflect more
2127 clearly which files are directly included by each source file,
2128 and not through other includes.
2129
e43b6e43
MR
21302011-06-27 Martin Rudalics <rudalics@gmx.at>
2131
2132 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2133 (sort_overlays, overlay_strings): When an overlay's clone number
2134 matches the window's clone number process the overlay even if
2135 the overlay's window property doesn't match the current window.
2136
d68443dc
MR
2137 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2138 (Fwindow_hchild): Rename to Fwindow_left_child.
2139 (Fwindow_next): Rename to Fwindow_next_sibling.
2140 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2141 (resize_window_check): Rename to window_resize_check.
2142 (resize_window_apply): Rename to window_resize_apply.
2143 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2144 (Fdelete_other_windows_internal, resize_frame_windows)
2145 (Fsplit_window_internal, Fdelete_window_internal)
2146 (grow_mini_window, shrink_mini_window)
2147 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2148
c7e73be5
JD
21492011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2150
2151 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2152 (emacs_fixed_set_min_size): Remove.
2153 (emacs_fixed_new): Take frame as argument.
2154
2155 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2156 (_EmacsFixedPrivate): Remove minwidth/height.
2157 Add struct frame *f.
2158 (emacs_fixed_init): Initialize priv->f.
2159 (get_parent_class, emacs_fixed_set_min_size): Remove.
2160 (emacs_fixed_new): Set priv->f to argument.
2161 (emacs_fixed_get_preferred_width)
2162 (emacs_fixed_get_preferred_height): Use min_width/height from
2163 frames size_hint to set minimum and natural (Bug#8919).
2164 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2165 and use min_width/height from frames size_hint to set
2166 min_width/height (Bug#8919).
2167
2168 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2169 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2170 Fix indentation.
c7e73be5 2171
cf99dcf8
EZ
21722011-06-26 Eli Zaretskii <eliz@gnu.org>
2173
2174 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2175 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2176 called at ZV.
2177
029529ac
CY
21782011-06-26 Chong Yidong <cyd@stupidchicken.com>
2179
2180 * process.c (wait_reading_process_output): Bypass select if
2181 waiting for a cell while ignoring keyboard input, and input is
2182 pending. Suggested by Jan Djärv (Bug#8869).
2183
7a7ef429
PE
21842011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2185
2186 Use gnulib's dup2 module instead of rolling our own.
2187 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2188
11fdef7d 21892011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2190
2191 * dispnew.c (scrolling_window): Before scrolling, turn off a
2192 mouse-highlight in the window being scrolled.
2193
cd3520a4
JB
21942011-06-24 Juanma Barranquero <lekktu@gmail.com>
2195
2196 Move DEFSYM to lisp.h and use everywhere.
2197
2198 * character.h (DEFSYM): Move declaration...
2199 * lisp.h (DEFSYM): ...here.
2200
2201 * gnutls.c:
2202 * minibuf.c:
2203 * w32menu.c:
2204 * w32proc.c:
2205 * w32select.c: Don't include character.h.
2206
2207 * alloc.c (syms_of_alloc):
2208 * buffer.c (syms_of_buffer):
2209 * bytecode.c (syms_of_bytecode):
2210 * callint.c (syms_of_callint):
2211 * casefiddle.c (syms_of_casefiddle):
2212 * casetab.c (init_casetab_once):
2213 * category.c (init_category_once, syms_of_category):
2214 * ccl.c (syms_of_ccl):
2215 * cmds.c (syms_of_cmds):
2216 * composite.c (syms_of_composite):
2217 * dbusbind.c (syms_of_dbusbind):
2218 * dired.c (syms_of_dired):
2219 * dispnew.c (syms_of_display):
2220 * doc.c (syms_of_doc):
2221 * editfns.c (syms_of_editfns):
2222 * emacs.c (syms_of_emacs):
2223 * eval.c (syms_of_eval):
2224 * fileio.c (syms_of_fileio):
2225 * fns.c (syms_of_fns):
2226 * frame.c (syms_of_frame):
2227 * fringe.c (syms_of_fringe):
2228 * insdel.c (syms_of_insdel):
2229 * keymap.c (syms_of_keymap):
2230 * lread.c (init_obarray, syms_of_lread):
2231 * macros.c (syms_of_macros):
2232 * msdos.c (syms_of_msdos):
2233 * print.c (syms_of_print):
2234 * process.c (syms_of_process):
2235 * search.c (syms_of_search):
2236 * sound.c (syms_of_sound):
2237 * syntax.c (init_syntax_once, syms_of_syntax):
2238 * terminal.c (syms_of_terminal):
2239 * textprop.c (syms_of_textprop):
2240 * undo.c (syms_of_undo):
2241 * w32.c (globals_of_w32):
2242 * window.c (syms_of_window):
2243 * xdisp.c (syms_of_xdisp):
2244 * xfaces.c (syms_of_xfaces):
2245 * xfns.c (syms_of_xfns):
2246 * xmenu.c (syms_of_xmenu):
2247 * xsettings.c (syms_of_xsettings):
2248 * xterm.c (syms_of_xterm): Use DEFSYM.
2249
4228cf16
TZ
22502011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2251
cd3520a4 2252 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2253
7fcccf1e
PE
22542011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2255
7efb4e0e
PE
2256 Integer and buffer overflow fixes (Bug#8873).
2257
ff5844ad
PE
2258 * print.c (printchar, strout): Check for string overflow.
2259 (PRINTPREPARE, printchar, strout):
2260 Don't set size unless allocation succeeds.
2261
90532f02
PE
2262 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2263 for sizes. Check for string overflow more accurately.
2264 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2265
6d84508d
PE
2266 * macros.c: Integer and buffer overflow fixes.
2267 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2268 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2269 Use ptrdiff_t, not int, for sizes.
2270 Don't increment bufsize until after realloc succeeds.
2271 Check for size-calculation overflow.
2272 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2273
437b2cb4
PE
2274 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2275
8b9ac8b4
PE
2276 * lread.c: Integer overflow fixes.
2277 (read_integer): Radix is now EMACS_INT, not int,
2278 to improve quality of diagnostics for out-of-range radices.
2279 Calculate buffer size correctly for out-of-range radices.
2280 (read1): Check for integer overflow in radices, and in
2281 read-circle numbers.
82cb60d3
PE
2282 (read_escape): Avoid int overflow.
2283 (Fload, openp, read_buffer_size, read1)
2284 (substitute_object_recurse, read_vector, read_list, map_obarray):
2285 Use ptrdiff_t, not int, for sizes.
2286 (read1): Use EMACS_INT, not int, for sizes.
20270765 2287 Check for size overflow.
8b9ac8b4 2288
7fcccf1e
PE
2289 * image.c (cache_image): Check for size arithmetic overflow.
2290
bfbbd7e7
PE
2291 * lread.c: Integer overflow issues.
2292 (saved_doc_string_size, saved_doc_string_length)
2293 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2294 Now ptrdiff_t, not int.
2295 (read1): Don't assume doc string length fits in int. Check for
2296 out-of-range doc string lengths.
2297 (read_list): Don't assume file position fits in int.
39019e54 2298 (read_escape): Check for hex character overflow.
bfbbd7e7 2299
4e323265
LL
23002011-06-22 Leo Liu <sdl.web@gmail.com>
2301
2302 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2303 Move to minibuffer.el.
2304
85fece3e
PE
23052011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2306
20b84ce9 2307 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2308 The following patches are for when GLYPH_DEBUG && !XASSERT.
2309 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2310 * dispnew.c (flush_stdout):
2311 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2312 Mark as externally visible.
2313 * dispnew.c (check_window_matrix_pointers): Now static.
2314 * dispnew.c (window_to_frame_vpos):
2315 * xfns.c (unwind_create_frame):
2316 * xterm.c (x_check_font): Remove unused local.
2317 * scroll.c (CHECK_BOUNDS):
2318 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2319 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2320 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2321 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2322 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2323 Now static.
2324 (debug_method_add): Use va_list and vsprintf rather than relying
2325 on undefined behavior with wrong number of arguments.
2326 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2327 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2328 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2329 since we're not interested in debugging glyphs with old libraries.
2330 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2331 GCC 4.6.0's static checking.
2332
0766b489
PE
23332011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2334
31fd4b32
PE
2335 Integer overflow and signedness fixes (Bug#8873).
2336 A few related buffer overrun fixes, too.
2337
b79e8648
PE
2338 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2339
0766b489
PE
2340 * dispextern.h (struct face.stipple):
2341 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2342 (x_bitmap_mask, x_allocate_bitmap_record)
2343 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2344 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2345 (x_create_bitmap_from_xpm_data):
2346 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2347 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2348 (.bitmaps_last):
2349 * xfaces.c (load_pixmap):
2350 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2351 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2352 (.bitmaps_last, struct x_output.icon_bitmap):
2353 Use ptrdiff_t, not int, for bitmap indexes.
2354 (x_allocate_bitmap_record): Check for size overflow.
2355 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2356
b081724f
PE
2357 Use ptrdiff_t, not int, for overlay counts.
2358 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2359 * editfns.c (overlays_around, get_pos_property):
2360 * textprop.c (get_char_property_and_overlay):
2361 * xdisp.c (next_overlay_change, note_mouse_highlight):
2362 * xfaces.c (face_at_buffer_position):
21514da7
PE
2363 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2364 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2365 (Fnext_overlay_change, Fprevious_overlay_change)
2366 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2367 Use ptrdiff_t, not int, for sizes.
21514da7 2368 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2369
3de73e5e
PE
2370 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2371
2606c57b
PE
2372 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2373 (x_session_initialize): Do not assume string length fits in int.
2374
aaafe47a
PE
2375 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2376 This is unlikely, but can occur if DPI is outlandish.
2377
2674ddc8 2378 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2379 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2380
28154962
PE
2381 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2382 * xrdb.c (magic_file_p, search_magic_path):
2383 Omit last arg SUFFIX; it was always 0. All callers changed.
2384 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2385
7de51af5
PE
2386 * xfont.c (xfont_match): Avoid need for strlen.
2387
25ed6cc3
PE
2388 * xfns.c: Don't assume strlen fits in int.
2389 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2390
4eab31dd
PE
2391 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2392 not unsigned long, as we prefer signed integers. All callers changed.
2393 Detect integer overflow in repeat count.
2394 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2395 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2396
171e2a58
PE
2397 * termcap.c: Don't assume sizes fit in int and never overflow.
2398 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2399 (gobble_line): Check for size-calculation overflow.
2400
ad39faca 2401 * minibuf.c (Fread_buffer):
6e5bb2dc 2402 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2403 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2404 Don't assume string length fits in int.
2405
52c61c22 2406 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2407 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2408
b5b8c9e5
PE
2409 * font.c: Don't assume string length fits in int.
2410 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2411 Use ptrdiff_t, not int.
ccd6111c
PE
2412 (font_intern_prop): Don't assume string length fits in int.
2413 Don't assume integer property fits in fixnum.
2414 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2415
882f0d81 2416 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2417 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2418 Reformulate so as not to need the command string.
2419 Invoke gzip -cd rather than gunzip, as it's more portable.
2420 (lock_info_type, lock_file_1, lock_file):
2421 Don't assume pid_t and time_t fit in unsigned long.
2422 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2423 (current_lock_owner): Prefer signed type for sizes.
2424 Use memcpy, not strncpy, where memcpy is what is really wanted.
2425 Don't assume (via atoi) that time_t and pid_t fit in int.
2426 Check for time_t and/or pid_t out of range, e.g., via a network share.
2427 Don't alloca where an auto var works fine.
2428
93f4cf88
PE
2429 * fileio.c: Fix some integer overflow issues.
2430 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2431 Don't assume string length fits in int.
2432 (directory_file_name): Don't assume string length fits in long.
2433 (make_temp_name): Don't assume pid fits in int, or that its print
2434 length is less than 20.
2435
f3e92b69
PE
2436 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2437
1bfdaf10
PE
2438 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2439
35016e9a
PE
2440 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2441
3d1e65a1
PE
2442 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2443 We prefer signed integers, even for size calculations.
2444
0b963a93
PE
2445 * emacs.c: Don't assume string length fits in 'int'.
2446 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2447 (main): Don't invoke strlen when not needed.
2448
573f4b54
PE
2449 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2450 (XD_DEBUG_MESSAGE): Don't waste a byte.
2451
989f33ba
PE
2452 * callproc.c (getenv_internal_1, getenv_internal)
2453 (Fgetenv_internal):
965d34eb
PE
2454 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2455
e4d29b33
PE
2456 * lread.c (invalid_syntax): Omit length argument.
2457 All uses changed. This doesn't fix a bug, but it simplifies the
2458 code away from its former Hollerith-constant appearance, and it's
2459 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 2460 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 2461
eb49b136
PE
2462 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2463 This didn't break anything, but it didn't help either.
2464 It's confusing to put a bogus integer in a place where the actual
2465 value does not matter.
9f62aeb1 2466 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 2467 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 2468
15375a22
PE
2469 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2470 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2471 implementation.
b61cc01c
PE
2472 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2473 We prefer signed types, and the value cannot exceed the EMACS_INT
2474 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
2475 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2476 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2477 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 2478
53b2623d
PE
2479 * indent.c (sane_tab_width): New function.
2480 (current_column, scan_for_column, Findent_to, position_indentation)
2481 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 2482 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 2483
51cab52b 2484 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 2485
f2ed8a70
PE
2486 * lisp.h (lint_assume): New macro.
2487 * composite.c (composition_gstring_put_cache):
2488 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2489
abe80cc6
PE
2490 * editfns.c, insdel.c:
2491 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 2492
b02c740e
PE
2493 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2494
ebc96716
PE
2495 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2496
b4e50fa0 2497 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 2498 Use much-faster test for byte-length change.
311d5d7c 2499 Don't assume string byte-length fits in 'int'.
a4cf38e4 2500 Check that character arg fits in 'int'.
85461888 2501 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 2502
c0c1ee9f
PE
2503 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2504
a498d7f4
PE
2505 * fns.c (concat): Catch string overflow earlier.
2506 Do not rely on integer wraparound.
2507
51cab52b
PE
2508 * dispextern.h (struct it.overlay_strings_charpos)
2509 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
2510 * xdisp.c (forward_to_next_line_start)
2511 (back_to_previous_visible_line_start)
2512 (reseat_at_next_visible_line_start, next_element_from_buffer):
2513 Don't arbitrarily truncate the value of 'selective' to int.
2514
76031fad
PE
2515 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2516
5eb55db9
PE
2517 * composite.c: Don't truncate sizes to 'int'.
2518 (composition_gstring_p, composition_reseat_it)
2519 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
2520 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2521 not EMACS_UINT, for indexes.
5eb55db9 2522
0703a717
PE
2523 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2524
d6202519
PE
2525 * buffer.c: Include <verify.h>.
2526 (struct sortvec.priority, struct sortstr.priority):
8961a454 2527 Now EMACS_INT, not int.
c20998a7 2528 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
2529 (struct sortstr.size, record_overlay_string)
2530 (struct sortstrlist.size, struct sortlist.used):
2531 Don't truncate size to int.
2532 (record_overlay_string): Check for size-calculation overflow.
d6202519 2533 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 2534
d5a19415
JM
25352011-06-22 Jim Meyering <meyering@redhat.com>
2536
029529ac 2537 Don't leak an XBM-image-sized buffer
d5a19415
JM
2538 * image.c (xbm_load): Free the image buffer after using it.
2539
a9041e6c
PE
25402011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2541
2542 Port to Sun C.
2543 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2544 that Sun C diagnosed.
2545 * fns.c (secure_hash): Fix pointer signedness issue.
2546 * intervals.c (static_offset_intervals): New function.
2547 (offset_intervals): Use it.
2548
7f3f739f
LL
25492011-06-21 Leo Liu <sdl.web@gmail.com>
2550
2551 * deps.mk (fns.o):
2552 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2553 sha512.h.
2554
2555 * fns.c (secure_hash): Rename from crypto_hash_function and change
2556 the first arg to accept symbols.
5b66d427 2557 (Fsecure_hash): New primitive.
7f3f739f
LL
2558 (syms_of_fns): New symbols.
2559
76147d94
DD
25602011-06-20 Deniz Dogan <deniz@dogan.se>
2561
2562 * process.c (Fset_process_buffer): Clarify return value in
2563 docstring.
2564
7d7d0045
CY
25652011-06-18 Chong Yidong <cyd@stupidchicken.com>
2566
2567 * dispnew.c (add_window_display_history): Use BVAR.
2568
2569 * xdisp.c (debug_method_add): Use BVAR.
2570 (check_window_end, dump_glyph_matrix, dump_glyph)
2571 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2572
2573 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2574 Likewise.
2575
2576 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2577 check till after the cache is created in init_frame_faces.
2578
ff2bc410
SM
25792011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2580
2581 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2582
28177add
PE
25832011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2584
dd3482fe
PE
2585 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2586 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2587 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2588
393d71f3 2589 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
2590 * fileio.c (Finsert_file_contents):
2591 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2592 Remove the old (too-loose) buffer overflow checks.
2593 They weren't needed, since make_gap checks for buffer overflow.
2594 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2595 The old code merely checked for Emacs fixnum overflow, and relied
2596 on undefined (wraparound) behavior. The new code avoids undefined
2597 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2598
2e6813b0 2599 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
2600 Tune. Don't use wider integers than needed. Don't use alloca.
2601 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 2602
599a9e4f
PE
2603 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2604
99561444
PE
2605 * insdel.c, lisp.h (buffer_overflow): New function.
2606 (insert_from_buffer_1, replace_range, replace_range_2):
2607 * insdel.c (make_gap_larger):
2608 * editfns.c (Finsert_char):
2609 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2610
28177add
PE
2611 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2612
e69dafad
PE
26132011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2614
a7af7fde 2615 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2616
b1c46f02
PE
2617 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2618 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2619
e69dafad
PE
2620 * fileio.c: Don't assume EMACS_INT fits in off_t.
2621 (emacs_lseek): New static function.
2622 (Finsert_file_contents, Fwrite_region): Use it.
2623 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2624
566684ea
PE
2625 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2626
e6966cd6
PE
2627 * fns.c: Don't overflow int when computing a list length.
2628 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2629 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2630 truncation on 64-bit hosts. Check for QUIT every
2631 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2632 faster and is responsive enough.
2633 (Flength): Report an error instead of overflowing an integer.
2634 (Fsafe_length): Return a float if the value is not representable
2635 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 2636 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 2637 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 2638
dd0b0efb
PE
2639 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2640 (header_size, word_size): New constants.
2641 (allocate_vectorlike): Don't check size overflow here.
2642 (allocate_vector): Check it here instead, since this is the only
2643 caller of allocate_vectorlike that could cause overflow.
2644 Check that the new vector's length is representable as a fixnum.
2645
86fe5cfe
PE
2646 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2647 The previous code was bogus. For example, next_almost_prime (32)
2648 returned 39, which is undesirable as it is a multiple of 3; and
2649 next_almost_prime (24) returned 25, which is a multiple of 5 so
2650 why was the code bothering to check for multiples of 7?
2651
80e88859
PE
2652 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2653
4a2f0ad6
PE
2654 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2655
f66c7cf8
PE
2656 Variadic C functions now count arguments with ptrdiff_t.
2657 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2658 Back then I didn't know that the Emacs coding style prefers signed int.
2659 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
2660 were being counted with int, which may truncate counts on 64-bit
2661 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
2662 * lisp.h (struct Lisp_Subr.function.aMANY)
2663 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2664 Arg counts are now ptrdiff_t, not size_t.
2665 All variadic functions and their callers changed accordingly.
2666 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2667 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2668 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2669 * callint.c (Fcall_interactively): Check arg count for overflow,
2670 to avoid potential buffer overrun. Use signed char, not 'int',
2671 for 'varies' array, so that we needn't bother to check its size
2672 calculation for overflow.
2673 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2674 * eval.c (apply_lambda):
2675 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2676 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2677 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2678
a1759b76
PE
2679 * callint.c (Fcall_interactively): Don't use index var as event count.
2680
d96be9fc
PE
2681 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2682 * mem-limits.h (SIZE): Remove; no longer used.
2683
a690a978 2684 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 2685
578c21e6
PE
2686 Remove unnecessary casts.
2687 * xterm.c (x_term_init):
2688 * xfns.c (x_set_border_pixel):
2689 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2690 These aren't needed now that we assume ANSI C.
2691
96f53c6c
PE
2692 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2693 It's more likely to cause problems (due to unsigned overflow)
2694 than to cure them.
2695
83c77d31
PE
2696 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2697
ee2079f1
PE
2698 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2699
6da65536
PE
2700 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2701
7147c4a4
PE
2702 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2703
193e32d9
PE
2704 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2705
e5533da6
PE
2706 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2707
9910e595
PE
2708 GLYPH_CODE_FACE returns EMACS_INT, not int.
2709 * dispextern.h (merge_faces):
2710 * xfaces.c (merge_faces):
01103c44
PE
2711 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2712 Don't assume EMACS_INT fits in int.
9910e595 2713
2638320e
PE
2714 * character.h (CHAR_VALID_P): Remove unused parameter.
2715 * fontset.c, lisp.h, xdisp.c: All uses changed.
2716
045eb8d9
PE
2717 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2718
c1f134b5
PE
2719 * fns.c (concat): Minor tuning based on overflow analysis.
2720 This doesn't fix any bugs. Use int to hold character, instead
2721 of constantly refetching from Emacs object. Use XFASTINT, not
2722 XINT, for value known to be a character. Don't bother comparing
2723 a single byte to 0400, as it's always less.
2724
395fcb93 2725 * floatfns.c (Fexpt):
327eeec8
PE
2726 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2727
abbd3d23
PE
2728 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2729 for characters.
2730
684a03ef
PE
2731 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2732
0fed43f3
PE
2733 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2734 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2735 incorrectly succeed when S was a string, because 4294967386 was
2736 truncated before it was used.
2737
8fd02eb7
PE
2738 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2739 Otherwise, an out-of-range integer could cause undefined behavior
2740 on a 64-bit host.
2741
f8c86b69
PE
2742 * composite.c: Use int, not EMACS_INT, for characters.
2743 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2744 EMACS_INT, for values that are known to be in character range.
2745 This doesn't fix any bugs but is the usual style inside Emacs and
2746 may generate better code on 32-bit machines.
2747
34206dd2
PE
2748 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2749 This is for reasons similar to the recent CHAR_STRING fix.
2750 * charset.c (Fencode_char): Check that character arg is actually
2751 a character. Pass an int to ENCODE_CHAR.
2752 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2753 wider than 'int', as a compile-time check to prevent future regressions
2754 in this area.
2755
c5958d4c 2756 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
2757
2758 Make sure a 64-bit char is never passed to CHAR_STRING.
2759 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2760 by silently ignoring the top 32 bits, allowing some values
2761 that were far too large to be valid characters.
2762 * character.h: Include <verify.h>.
2763 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2764 arguments are no wider than unsigned, as a compile-time check
2765 to prevent future regressions in this area.
2766 * data.c (Faset):
01103c44 2767 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
2768 (Fsubst_char_in_region):
2769 * fns.c (concat):
2770 * xdisp.c (decode_mode_spec_coding):
2771 Adjust to CHAR_STRING's new requirement.
2772 * editfns.c (Finsert_char, Fsubst_char_in_region):
2773 * fns.c (concat): Check that character args are actually
2774 characters. Without this test, these functions did the wrong
2775 thing with wildly out-of-range values on 64-bit hosts.
2776
d37ca623
PE
2777 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2778 These casts should not be needed on 32-bit hosts, either.
2779 * keyboard.c (read_char):
2780 * lread.c (Fload): Remove casts to unsigned.
2781
ea204efb
PE
2782 * lisp.h (UNSIGNED_CMP): New macro.
2783 This fixes comparison bugs on 64-bit hosts.
2784 (ASCII_CHAR_P): Use it.
2785 * casefiddle.c (casify_object):
01103c44 2786 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
2787 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2788 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2789 * dispextern.h (FACE_FROM_ID):
2790 * keyboard.c (read_char): Use UNSIGNED_CMP.
2791
41cb286c
PE
2792 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2793 not to EMACS_INT, to avoid GCC warning.
2794
4a1b9832
PE
2795 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2796
55daad71
PE
2797 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2798 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2799 isn't needed on 32-bit machines.
8f95c75c 2800
01103c44
PE
2801 * buffer.c (Fgenerate_new_buffer_name):
2802 Use EMACS_INT for count, not int.
0ceccced 2803 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
2804
2805 * data.c (Qcompiled_function): Now static.
2806
c6f072e7
PE
2807 * window.c (window_body_lines): Now static.
2808
20ce5912
PE
2809 * image.c (gif_load): Rename local to avoid shadowing.
2810
9c4c5f81
PE
2811 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2812 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2813 * alloc.c (make_save_value): Integer argument is now of type
2814 ptrdiff_t, not int.
2815 (mark_object): Use ptrdiff_t, not int.
2816 * lisp.h (pD): New macro.
2817 * print.c (print_object): Use it.
2818
c0c5c8ae
PE
2819 * alloc.c: Use EMACS_INT, not int, to count objects.
2820 (total_conses, total_markers, total_symbols, total_vector_size)
2821 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
2822 (total_free_floats, total_floats, total_free_intervals)
2823 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
2824 Now EMACS_INT, not int. All uses changed.
2825 (Fgarbage_collect): Compute overall total using a double, so that
2826 integer overflow is less likely to be a problem. Check for overflow
2827 when converting back to an integer.
5a25e253
PE
2828 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2829 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2830 These were 'int' variables that could overflow on 64-bit hosts;
2831 they were never used, so remove them instead of repairing them.
211a0b2a 2832 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
2833 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2834 Previously, this ceilinged at INT_MAX, but that doesn't work on
2835 64-bit machines.
e46bb31a 2836 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 2837
c78baabf 2838 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 2839 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
2840 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2841 when a (possibly-narrower) signed value would do just as well.
2842 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 2843
c9d624c6
PE
2844 * alloc.c: Catch some string size overflows that we were missing.
2845 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2846 for convenience in STRING_BYTES_MAX.
2847 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2848 The definition here is exact; the one in lisp.h was approximate.
2849 (allocate_string_data): Check for string overflow. This catches
2850 some instances we weren't catching before. Also, it catches
2851 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2852 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2853 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 2854
c9d624c6
PE
2855 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2856 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 2857 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 2858
353032ce
PE
2859 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2860
2bccce07
PE
2861 * alloc.c (Fmake_string): Check for out-of-range init.
2862
0ac30604
SM
28632011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2864
2865 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2866
c195f2de
JD
28672011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2868
2869 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2870 xg_get_default_scrollbar_width.
2871
2872 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2873 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2874 (style_changed_cb): Call update_theme_scrollbar_width and call
2875 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2876 all frames (Bug#8505).
2877 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2878 Call gtk_window_set_resizable if HAVE_GTK3.
2879 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2880 and height if HAVE_GTK3 (Bug#8505).
2881 (scroll_bar_width_for_theme): New variable.
2882 (update_theme_scrollbar_width): New function.
2883 (xg_get_default_scrollbar_width): Move code to
2884 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2885 (xg_initialize): Call update_theme_scrollbar_width.
2886
2887 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2888
2889 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2890
e10ac9f1
MR
28912011-06-12 Martin Rudalics <rudalics@gmx.at>
2892
2893 * frame.c (make_frame): Call other_buffer_safely instead of
2894 other_buffer.
2895
2896 * window.c (temp_output_buffer_show): Call display_buffer with
2897 second argument Vtemp_buffer_show_specifiers and reset latter
2898 immediately after the call.
2899 (Vtemp_buffer_show_specifiers): New variable.
2900 (auto_window_vscroll_p, next_screen_context_lines)
2901 (Vscroll_preserve_screen_position): Remove leading asterisks from
2902 doc-strings.
2903
2d3c217e 29042011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 2905
7b7f97e8 2906 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
2907 * buffer.c (Qclone_number): Remove for now, as it's unused.
2908 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2909 (record_buffer): Remove unused local.
2910 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2911 (set_frame_buffer_list): Remove; unused.
2912 * frame.h (other_visible_frames): Remove decl.
2913 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2914 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2915 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2916 if HAVE_GPM.
2917 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2918 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2919 Define only if HAVE_GPM.
2920 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2921 (update_hints_inhibit): Remove; never set. All uses removed.
2922 * widgetprv.h (emacsFrameClassRec): Remove decl.
2923 * window.c (delete_deletable_window): Now returns void, since it
2924 wasn't returning anything.
2925 (compare_window_configurations): Remove unused locals.
2926 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2927 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
2928 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2929 the same widths as pointers. This follows up on the 2011-05-06 patch.
2930 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2931 * xterm.h: Likewise.
2932 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2933
1384b89e
JB
29342011-06-12 Juanma Barranquero <lekktu@gmail.com>
2935
2936 * makefile.w32-in: Update dependencies.
2937 (LISP_H): Add lib/intprops.h.
2938
1100a63c
CY
29392011-06-11 Chong Yidong <cyd@stupidchicken.com>
2940
2941 * image.c (gif_load): Add animation frame delay to the metadata.
2942 (syms_of_image): Use DEFSYM. New symbol `delay'.
2943
6198ccd0
MR
29442011-06-11 Martin Rudalics <rudalics@gmx.at>
2945
2946 * window.c (delete_deletable_window): Re-add.
2947 (Fset_window_configuration): Rewrite to handle dead buffers and
2948 consequently deletable windows.
2949 (window_tree, Fwindow_tree): Remove. Supply functionality in
2950 window.el.
2951 (compare_window_configurations): Simplify code.
2952
b6e3633c
AS
29532011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2954
1ab0dee5
AS
2955 * image.c (imagemagick_load_image): Fix type mismatch.
2956 (Fimagemagick_types): Likewise.
2957
b6e3633c
AS
2958 * window.h (replace_buffer_in_windows): Declare.
2959
9397e56f
MR
29602011-06-11 Martin Rudalics <rudalics@gmx.at>
2961
2962 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2963 Qclone_number. Remove external declaration of Qdelete_window.
2964 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2965 code.
640c8776
SM
2966 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2967 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
2968 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2969 buffer list implementation.
2970 (other_buffer_safely): New function.
2971 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2972 calls to replace_buffer_in_windows and
2973 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2974 if allowed.
2975 (record_buffer): Inhibit quitting and rewrite using quittable
2976 functions. Run Qbuffer_list_update_hook if allowed.
2977 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
2978 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2979 Move switch-to-buffer to window.el.
9397e56f
MR
2980 (bury-buffer): Move to window.el.
2981 (Vbuffer_list_update_hook): New variable.
2982
2983 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2984 section.
2985
2986 * window.h (resize_frame_windows): Move up in code.
2987 (Fwindow_frame): Remove EXFUN.
2988 (replace_buffer_in_all_windows): Remove prototype.
2989 (replace_buffer_in_windows_safely): Add prototype.
2990
2991 * window.c: Declare Qdelete_window static again. Move down
2992 declaration of select_count.
2993 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2994 (Fother_window): Move to window.el.
2995 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2996 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2997 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2998 window.el.
2999 (replace_buffer_in_windows): Implement by calling
3000 Qreplace_buffer_in_windows.
3001 (replace_buffer_in_all_windows): Remove with some functionality
3002 moved into replace_buffer_in_windows_safely.
3003 (replace_buffer_in_windows_safely): New function.
3004 (select_window_norecord, select_frame_norecord): Move in front
3005 of run_window_configuration_change_hook. Remove now obsolete
3006 declarations.
640c8776
SM
3007 (Fset_window_buffer): Rewrite doc-string.
3008 Call Qrecord_window_buffer.
9397e56f
MR
3009 (keys_of_window): Move binding for other-window to window.el.
3010
b50691aa
CY
30112011-06-11 Chong Yidong <cyd@stupidchicken.com>
3012
3013 * dispextern.h (struct image): Replace data member, whose int_val
3014 and ptr_val fields were not used by anything, with a single
3015 lisp_val object.
3016
3017 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3018 (gif_clear_image, gif_load, imagemagick_load_image)
3019 (gs_clear_image, gs_load): Callers changed.
3020
3f754b86
PE
30212011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3022
cca69397
PE
3023 * buffer.h: Include <time.h>, for time_t.
3024 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3025
109e28d0
PE
3026 Fix minor problems found by static checking.
3027
60737f02
PE
3028 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3029
4b66faf3
PE
3030 Make identifiers static if they are not used in other modules.
3031 * data.c (Qcompiled_function, Qframe, Qvector):
3032 * image.c (QimageMagick, Qsvg):
3033 * minibuf.c (Qmetadata):
3034 * window.c (resize_window_check, resize_root_window): Now static.
3035 * window.h (resize_window_check, resize_root_window): Remove decls.
3036
109e28d0
PE
3037 * window.c (window_deletion_count, delete_deletable_window):
3038 Remove; unused.
46a4ce9e
PE
3039 (window_body_lines): Now static.
3040 (Fdelete_other_windows_internal): Mark vars as initialized.
3041 Make sure 'resize_failed' is initialized.
3042 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3043 (resize_window_apply): Remove unused local.
3044 * window.h (delete_deletable_window): Remove decl.
3045
109e28d0 3046 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3047 (imagemagick_load_image): Fix pointer signedness problem by changing
3048 last arg from unsigned char * to char *. All uses changed.
3049 Also, fix a local for similar reasons.
3050 Remove unused locals. Remove locals to avoid shadowing.
3051 (fn_rsvg_handle_free): Remove; unused.
3052 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3053 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3054
3f754b86
PE
3055 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3056
2547adb1
CY
30572011-06-10 Chong Yidong <cyd@stupidchicken.com>
3058
3059 * image.c (gif_load): Fix omitted cast error introduced by
3060 2011-06-06 change.
3061
2c8e37d4
MR
30622011-06-10 Martin Rudalics <rudalics@gmx.at>
3063
3064 * window.h (resize_proportionally, orig_total_lines)
3065 (orig_top_line): Remove from window structure.
3066 (set_window_height, set_window_width, change_window_heights)
3067 (Fdelete_window): Remove prototypes.
3068 (resize_frame_windows): Remove duplicate declaration.
3069
440a42e3
EZ
30702011-06-10 Eli Zaretskii <eliz@gnu.org>
3071
3072 * window.h (resize_frame_windows, resize_window_check)
3073 (delete_deletable_window, resize_root_window)
3074 (resize_frame_windows): Declare prototypes.
3075
3076 * window.c (resize_window_apply): Make definition be "static" to
3077 match the prototype.
3078
562dd5e9
MR
30792011-06-10 Martin Rudalics <rudalics@gmx.at>
3080
3081 * window.c: Remove declarations of Qwindow_size_fixed,
3082 window_min_size_1, window_min_size_2, window_min_size,
3083 size_window, window_fixed_size_p, enlarge_window, delete_window.
3084 Remove static from declaration of Qdelete_window, it's
3085 temporarily needed by Fbury_buffer.
3086 (replace_window): Don't assign orig_top_line and
3087 orig_total_lines.
3088 (Fdelete_window, delete_window): Remove. Window deletion is
3089 handled by window.el.
640c8776
SM
3090 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3091 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3092 (Fdelete_other_windows): Remove. Deleting other windows is
3093 handled by window.el.
3094 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3095 handled in window.el.
3096 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3097 Window minimum sizes are handled in window.el.
3098 (shrink_windows, size_window, set_window_height)
3099 (set_window_width, change_window_heights, window_height)
3100 (window_width, CURBEG, CURSIZE, enlarge_window)
3101 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3102 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3103 handled in window.el.
3104 (make_dummy_parent): Rename to make_parent_window and give it a
3105 second argument horflag.
3106 (make_window): Don't set resize_proportionally any more.
3107 (Fsplit_window): Remove. Windows are split in window.el.
3108 (save_restore_action, save_restore_orig_size)
3109 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3110 Resize mini windows in window.el.
3111 (grow_mini_window, shrink_mini_window): Implement by calling
3112 Qresize_root_window_vertically, resize_window_check and
3113 resize_window_apply.
640c8776
SM
3114 (saved_window, Fset_window_configuration, save_window_save):
3115 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3116 resize_proportionally.
3117 (window_min_height, window_min_width): Move to window.el.
3118 (keys_of_window): Move bindings for delete-other-windows,
3119 split-window, delete-window and enlarge-window to window.el.
3120
3121 * buffer.c: Temporarily extern Qdelete_window.
3122 (Fbury_buffer): Temporarily call Qdelete_window instead of
3123 Fdelete_window (Fbury_buffer will move to window.el soon).
3124
3125 * frame.c (set_menu_bar_lines_1): Remove code handling
3126 orig_top_line and orig_total_lines.
3127
3128 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3129 set_window_height but set heights directly.
3130 (change_frame_size_1): Use resize_frame_windows.
3131
3132 * xdisp.c (init_xdisp): Don't use set_window_height but set
3133 heights directly.
3134
640c8776
SM
3135 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3136 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3137 run_window_configuration_change_hook.
3138
3139 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3140 instead of change_window_heights and run
3141 run_window_configuration_change_hook.
3142
1a13852e
MR
31432011-06-09 Martin Rudalics <rudalics@gmx.at>
3144
3145 * window.c (replace_window): Rename second argument REPLACEMENT to
3146 NEW. New third argument SETFLAG. Rewrite.
3147 (delete_window, make_dummy_parent): Call replace_window with
3148 third argument 1.
3149 (window_list_1): Move down in code.
3150 (run_window_configuration_change_hook): Move set_buffer part
3151 before select_frame_norecord part in order to unwind correctly.
3152 Rename count1 to count.
3153 (recombine_windows, delete_deletable_window, resize_root_window)
3154 (Fdelete_other_windows_internal)
3155 (Frun_window_configuration_change_hook, make_parent_window)
3156 (resize_window_check, resize_window_apply, Fresize_window_apply)
3157 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3158 (Fdelete_window_internal, Fresize_mini_window_internal):
3159 New functions.
1a13852e
MR
3160 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3161
f3d1777e
MR
31622011-06-08 Martin Rudalics <rudalics@gmx.at>
3163
496e208e
MR
3164 * window.h (window): Add some new members to window structure -
3165 normal_lines, normal_cols, new_total, new_normal, clone_number,
3166 splits, nest, prev_buffers, next_buffers.
3167 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3168 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3169
f3d1777e
MR
3170 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3171 Remove.
496e208e
MR
3172 (make_dummy_parent): Set new members of windows structure.
3173 (make_window): Move down in code. Handle new members of window
3174 structure.
3175 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3176 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3177 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3178 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3179 (Fset_window_next_buffers, Fset_window_clone_number):
3180 New functions.
496e208e
MR
3181 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3182 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3183 Doc-string fixes.
3184 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3185 Argument WINDOW can be now internal window too.
3186 (Fwindow_use_time): Move up in code.
3187 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3188 Rewrite doc-string.
3189 (Fset_window_configuration, saved_window)
3190 (Fcurrent_window_configuration, save_window_save): Handle new
3191 members of window structure.
b9e809c2
MR
3192 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3193 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3194 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3195 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3196 Qget_mru_window, Qresize_root_window,
3197 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3198 Qauto_buffer_name; staticpro them.
f3d1777e 3199
abde8f8c
MR
32002011-06-07 Martin Rudalics <rudalics@gmx.at>
3201
3202 * window.c (Fwindow_total_size, Fwindow_left_column)
3203 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3204 (Fwindow_list_1): New functions.
3205 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3206 (Fwindow_width, Fscroll_left, Fscroll_right):
3207 Use window_body_cols instead of window_box_text_cols.
3208 (delete_window, Fset_window_configuration):
3209 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3210 (delete_all_subwindows): Take a window as argument and not a
3211 structure. Rewrite.
190b47e6
MR
3212 (window_loop): Remove handling of GET_LRU_WINDOW and
3213 GET_LARGEST_WINDOW.
3214 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3215
3216 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3217 window_box_text_cols. delete_all_subwindows now takes a
3218 Lisp_Object as argument.
abde8f8c 3219
640c8776
SM
3220 * indent.c (compute_motion, Fcompute_motion):
3221 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3222
fa8a67e6
MR
3223 * frame.c (delete_frame): Call delete_all_subwindows with root
3224 window as argument.
3225
a54e3482
DC
32262011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3227
3228 * fns.c (Fputhash): Document return value.
3229
60002bf5
CY
32302011-06-06 Chong Yidong <cyd@stupidchicken.com>
3231
3232 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3233
0c671da6 32342011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3235
b862a52a 3236 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3237
be44ca6c
PE
3238 Check for overflow when converting integer to cons and back.
3239 * charset.c (Fdefine_charset_internal, Fdecode_char):
3240 Use cons_to_unsigned to catch overflow.
3241 (Fencode_char): Use INTEGER_TO_CONS.
3242 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3243 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3244 * data.c (long_to_cons, cons_to_long): Remove.
3245 (cons_to_unsigned, cons_to_signed): New functions.
3246 These signal an error for invalid or out-of-range values.
3247 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3248 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3249 * font.c (Ffont_variation_glyphs):
3250 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3251 * lisp.h: Include <intprops.h>.
3252 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3253 (cons_to_signed, cons_to_unsigned): New decls.
3254 (long_to_cons, cons_to_long): Remove decls.
3255 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3256 (Fprimitive_undo): Use CONS_TO_INTEGER.
3257 * xfns.c (Fx_window_property): Likewise.
3258 * xselect.c: Include <limits.h>.
3259 (x_own_selection, selection_data_to_lisp_data):
3260 Use INTEGER_TO_CONS.
3261 (x_handle_selection_request, x_handle_selection_clear)
3262 (x_get_foreign_selection, Fx_disown_selection_internal)
3263 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3264 (lisp_data_to_selection_data): Use cons_to_unsigned.
3265 (x_fill_property_data): Use cons_to_signed.
3266 Report values out of range.
3267
d1f3d2af
PE
3268 Check for buffer and string overflow more precisely.
3269 * buffer.h (BUF_BYTES_MAX): New macro.
3270 * lisp.h (STRING_BYTES_MAX): New macro.
3271 * alloc.c (Fmake_string):
3272 * character.c (string_escape_byte8):
3273 * coding.c (coding_alloc_by_realloc):
3274 * doprnt.c (doprnt):
3275 * editfns.c (Fformat):
3276 * eval.c (verror):
3277 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3278 since they may not be the same number.
3279 * editfns.c (Finsert_char):
3280 * fileio.c (Finsert_file_contents):
3281 Likewise for BUF_BYTES_MAX.
3282
dd52fcea
PE
3283 * image.c: Use ptrdiff_t, not int, for sizes.
3284 (slurp_file): Switch from int to ptrdiff_t.
3285 All uses changed.
3286 (slurp_file): Check that file size fits in both size_t (for
3287 malloc) and ptrdiff_t (for sanity and safety).
3288
7f9bbdbb
PE
3289 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3290 if b->modtime has its maximal value.
3291
dfe18f82
PE
3292 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3293
84acfcf0
PE
3294 Don't assume time_t can fit into int.
3295 * buffer.h (struct buffer.modtime): Now time_t, not int.
3296 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3297 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3298
ccd9a01a
PE
3299 Minor fixes for signed vs unsigned integers.
3300 * character.h (MAYBE_UNIFY_CHAR):
3301 * charset.c (maybe_unify_char):
3302 * keyboard.c (read_char, reorder_modifiers):
3303 XINT -> XFASTINT, since the integer must be nonnegative.
3304 * ftfont.c (ftfont_spec_pattern):
3305 * keymap.c (access_keymap, silly_event_symbol_error):
3306 XUINT -> XFASTINT, since the integer must be nonnegative.
3307 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3308 since it makes no difference and we prefer signed.
3309 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3310 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3311 nonnegative.
3312
d6d100dd
SM
33132011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3314
3315 * window.h (Fwindow_frame): Declare.
3316
2b6148e4
PE
33172011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3318
3319 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3320 (SPARE_MEMORY): Always define.
3321 (LARGE_REQUEST): Remove.
3322 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3323
f230ecc9
MR
33242011-06-06 Martin Rudalics <rudalics@gmx.at>
3325
727e958e
MR
3326 * lisp.h: Move EXFUNS for Fframe_root_window,
3327 Fframe_first_window and Fset_frame_selected_window to window.h.
3328
3329 * window.h: Move EXFUNS for Fframe_root_window,
3330 Fframe_first_window and Fset_frame_selected_window here from
3331 lisp.h.
3332
3333 * frame.c (Fwindow_frame, Fframe_first_window)
3334 (Fframe_root_window, Fframe_selected_window)
3335 (Fset_frame_selected_window): Move to window.c.
3336 (Factive_minibuffer_window): Move to minibuf.c.
3337 (Fother_visible_frames_p): New function.
3338
3339 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3340
f230ecc9
MR
3341 * window.c (decode_window, decode_any_window): Move up in code.
3342 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3343 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3344 (Fwindow_buffer): Move up and rewrite doc-string.
3345 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3346 (Fwindow_prev): New functions.
727e958e
MR
3347 (Fwindow_frame): Move here from frame.c. Accept any window as
3348 argument.
3349 (Fframe_root_window, Fframe_first_window)
3350 (Fframe_selected_window): Move here from frame.c. Accept frame
3351 or arbitrary window as argument. Update doc-strings.
3352 (Fminibuffer_window): Move up in code.
3353 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3354 (Fset_frame_selected_window): Move here from frame.c.
3355 Marginal rewrite.
727e958e
MR
3356 (Fselected_window, select_window, Fselect_window): Move up in
3357 code. Minor doc-string fixes.
f230ecc9 3358
4d09bcf6
PE
33592011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3360
3361 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3362 Do not assume that spare memory exists; that assumption is valid
3363 only if SYSTEM_MALLOC.
3364 (LARGE_REQUEST): New macro, so that the issue of large requests
3365 is separated from the issue of spare memory.
3366
810928a2
AS
33672011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3368
172418ad
AS
3369 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3370 format. (Bug#8806)
3371
43f862f7
AS
3372 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3373
810928a2
AS
3374 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3375 before statements.
3376
a059fe24
JD
33772011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3378
3379 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3380
3381 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3382
3383 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3384 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3385
989bf368
JB
33862011-06-05 Juanma Barranquero <lekktu@gmail.com>
3387
3388 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3389
4b80f674
CY
33902011-06-04 Chong Yidong <cyd@stupidchicken.com>
3391
3392 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3393 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3394 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3395 New error handlers.
4b80f674
CY
3396 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3397 Obey Vx_select_enable_clipboard_manager. Catch errors in
3398 x_clipboard_manager_save (Bug#8779).
3399 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3400 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3401
99a33b77 34022011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3403
3404 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3405
99a33b77 34062011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3407
3408 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3409 in the current matrix if keep_current_p is non-zero.
3410
8264569d
EZ
34112011-06-04 Eli Zaretskii <eliz@gnu.org>
3412
3413 * bidi.c (bidi_level_of_next_char): Fix last change.
3414
57f97249
EZ
34152011-06-03 Eli Zaretskii <eliz@gnu.org>
3416
fec2107c 3417 Support bidi reordering of text covered by display properties.
57f97249 3418
fec2107c
EZ
3419 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3420 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3421 (bidi_cache_search, bidi_cache_iterator_state)
3422 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3423 (bidi_level_of_next_char, bidi_move_to_visually_next):
3424 Support character positions inside a run of characters covered by a
fec2107c
EZ
3425 display string.
3426 (bidi_paragraph_init, bidi_resolve_explicit_1)
3427 (bidi_level_of_next_char): Call bidi_fetch_char and
3428 bidi_fetch_char_advance instead of FETCH_CHAR and
3429 FETCH_CHAR_ADVANCE.
3430 (bidi_init_it): Initialize new members.
3431 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3432 definitions.
3433 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3434 instead of using explicit *_CHAR codes.
d6d100dd
SM
3435 (bidi_resolve_explicit, bidi_resolve_weak):
3436 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
3437 bidirectional text is supported only in multibyte buffers.
3438 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3439 it to initialize the frame_window_p member of struct bidi_it.
3440 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3441 (bidi_resolve_explicit, bidi_resolve_weak)
3442 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3443 bidi_it->nchars is non-positive.
3444 (bidi_level_of_next_char): Don't try to lookup the cache for the
3445 next/previous character if nothing is cached there yet, or if we
3446 were just reseat()'ed to a new position.
c40e2fb2 3447
0e14fe90
EZ
3448 * xdisp.c (set_cursor_from_row): Set start and stop points
3449 according to the row's direction when priming the loop that looks
3450 for the glyph on which to display cursor.
3451 (single_display_spec_intangible_p): Function deleted.
3452 (display_prop_intangible_p): Reimplement to call
3453 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
3454 Accept 3 additional arguments needed by handle_display_spec.
3455 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
3456 values: lists, `(when COND...)' forms, etc.
3457 (single_display_spec_string_p): Support property values that are
3458 lists with the argument STRING its top-level element.
3459 (display_prop_string_p): Fix the condition for processing a
3460 property that is a list to be consistent with handle_display_spec.
fec2107c 3461 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
3462 last portion of handle_display_prop.
3463 (compute_display_string_pos): Accept additional argument
3464 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3465 value of a `display' property is a "replacing spec".
3466 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3467 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3468 the display property, but just return a value indicating whether
3469 the display property will replace the characters it covers.
3470 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3471 frame_window_p members of struct bidi_it.
d6d100dd
SM
3472 (compute_display_string_pos, compute_display_string_end):
3473 New functions.
fec2107c
EZ
3474 (push_it): Accept second argument POSITION, where pop_it should
3475 jump to continue iteration.
3476 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 3477
fec2107c
EZ
3478 * keyboard.c (adjust_point_for_property): Adjust the call to
3479 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
3480
3481 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
3482 (bidi_init_it): Update prototypes.
3483 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
3484 (compute_display_string_pos, compute_display_string_end):
3485 Declare prototypes.
fec2107c
EZ
3486 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3487 EMACS_INT.
fc6f18ce 3488
40087514 34892011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 3490
57f53182
PE
3491 Malloc failure behavior now depends on size of allocation.
3492 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3493 * lisp.h: Change signatures accordingly.
3494 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3495 All callers changed. (Bug#8762)
3496
3497 * gnutls.c: Use Emacs's memory allocators.
3498 Without this change, the gnutls library would invoke malloc etc.
3499 directly, which causes problems on non-SYNC_INPUT hosts, and which
3500 runs afoul of improving memory_full behavior. (Bug#8761)
3501 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3502 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3503 xfree instead of the default malloc, realloc, free.
3504 (Fgnutls_boot): No need to check for memory allocation failure,
3505 since xmalloc does that for us.
3506
ac32cd99 3507 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
3508 * category.c (hash_get_category_set):
3509 * ccl.c (ccl_driver):
3510 * charset.c (Fdefine_charset_internal):
3511 * charset.h (struct charset.hash_index):
3512 * composite.c (get_composition_id, gstring_lookup_cache)
3513 (composition_gstring_put_cache):
3514 * composite.h (struct composition.hash_index):
3515 * dispextern.h (struct image.hash):
3516 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3517 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3518 (hashfn_equal, hashfn_user_defined, make_hash_table)
3519 (maybe_resize_hash_table, hash_lookup, hash_put)
3520 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3521 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3522 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3523 * image.c (make_image, search_image_cache, lookup_image)
3524 (xpm_put_color_table_h):
3525 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 3526 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 3527 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 3528 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
3529 * alloc.c (allocate_vectorlike):
3530 Check for overflow in vector size calculations.
3531 * ccl.c (ccl_driver):
3532 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
3533 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3534 need to be updated by these changes.
40087514
PE
3535 * fns.c (make_hash_table, maybe_resize_hash_table):
3536 Check for integer overflow with large hash tables.
0de4bb68
PE
3537 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3538 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3539 (SXHASH_REDUCE): New macro.
3540 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3541 Use it instead of discarding useful hash info with large hash values.
3542 (sxhash_float): New function.
3543 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3544 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
3545 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3546 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
3547 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3548 Adjust signatures to match updated version of code.
3549 (consing_since_gc): Now EMACS_INT, since a single hash table can
3550 use more than INT_MAX bytes.
3551
698d32e2
DN
35522011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3553
3554 Make it possible to build with GCC-4.6+ -O2 -flto.
3555
3556 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3557
fd6fa53f
SM
35582011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3559
3560 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3561 Call minibuffer-inactive-mode.
3562
864db017
JB
35632011-05-31 Juanma Barranquero <lekktu@gmail.com>
3564
3565 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3566 Update dependencies.
3567
2ad0baf4
DN
35682011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3569
3570 * data.c (init_data): Remove code for UTS, this system is not
3571 supported anymore.
3572
4fcc2638
DN
35732011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3574
3575 Don't force ./temacs to start in terminal mode.
3576
3577 * frame.c (make_initial_frame): Initialize faces in all cases, not
3578 only when CANNOT_DUMP is defined.
3579 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3580
c56e0fd5
DN
35812011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3582
3583 * dispnew.c (add_window_display_history): Use const for the string
3584 pointer. Remove declaration, not needed.
3585
333d54da 35862011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 3587
55d4c1b2 3588 Use 'inline', not 'INLINE'.
333d54da 3589 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
3590 * alloc.c, fontset.c (INLINE): Remove.
3591 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3592 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3593 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3594 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3595 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3596
738db178
DN
35972011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3598
3599 Make it possible to run ./temacs.
3600
3601 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3602 syms_of_callproc does the same thing. Remove test for
3603 "initialized", do it in the caller.
3604 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3605
620c53a6
SM
36062011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3607
3608 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3609 (read_minibuf): Use get_minibuffer.
3610 (syms_of_minibuf): Use DEFSYM.
3611 (Qmetadata): New var.
3612 * data.c (Qbuffer): Don't make it static.
3613 (syms_of_data): Use DEFSYM.
3614
e003a292
PE
36152011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3616
3617 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3618 (CCL_CODE_MIN): New macro.
3619
ed008a6d
PE
36202011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3621
3687c2ef
PE
3622 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3623
ed008a6d
PE
3624 * eval.c (Qdebug): Now static.
3625 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3626 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3627 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3628
d66c4c7c
CY
36292011-05-29 Chong Yidong <cyd@stupidchicken.com>
3630
3631 * image.c: Various fixes to ImageMagick code comments.
3632 (Fimagemagick_types): Doc fix.
3633
5fbc2025
PE
36342011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3635
0196f88a
PE
3636 Minor fixes prompted by GCC 4.6.0 warnings.
3637
3638 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3639
5fbc2025
PE
3640 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3641 (x_clipboard_manager_save_all): Move extern decl to ...
3642 * xterm.h: ... here, so that it can be checked for consistency.
3643
1dd3c2d9
CY
36442011-05-29 Chong Yidong <cyd@stupidchicken.com>
3645
3646 * xselect.c (x_clipboard_manager_save_frame)
3647 (x_clipboard_manager_save_all): New functions.
3648 (Fx_clipboard_manager_save): Lisp function deleted.
3649
3650 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3651 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3652
3653 * xterm.h: Update prototype.
3654
5ba6571d
WX
36552011-05-28 William Xu <william.xwl@gmail.com>
3656
3657 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3658 exiting (Bug#8239).
3659
3eaff834
JM
36602011-05-28 Jim Meyering <meyering@redhat.com>
3661
e1900994 3662 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
3663 * fns.c (to_uchar): Define.
3664 (crypto_hash_function): Use it to convert some newly-signed
3665 variables to unsigned, to avoid sign-extension bugs. For example,
3666 without this change, (md5 "truc") would evaluate to
3667 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3668 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 3669 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 3670
0f6990a7
PE
36712011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3672
3673 Integer overflow fixes.
c8a9ca5a 3674
08686060
PE
3675 * dbusbind.c: Serial number integer overflow fixes.
3676 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
3677 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3678 to hold a serial number that is too large for a fixnum.
3679 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3680 Check for serial numbers out of range. Decode any serial number
59568bf0 3681 that was so large that it became a float. (Bug#8722)
08686060 3682
2d1fc3c7
PE
3683 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3684 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3685 Use XFASTINT rather than XUINT when numbers are nonnegative.
3686 (xd_append_arg, Fdbus_method_return_internal):
3687 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3688 arguments, check that Lisp number is nonnegative, rather than
59568bf0 3689 silently wrapping negative numbers around. (Bug#8722)
30217ff0 3690 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 3691 (Bug#8722)
2d1fc3c7 3692
c8a9ca5a
PE
3693 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3694
519e1d69
PE
3695 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3696
30569699
PE
3697 ccl: add integer overflow checks
3698 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3699 (IN_INT_RANGE): New macros.
3700 (ccl_driver): Use them to check for integer overflow when
3701 decoding a CCL program. Many of the new checks are whether XINT (x)
3702 fits in int; it doesn't always, on 64-bit hosts. The new version
3703 doesn't catch all possible integer overflows, but it's an
847044ea 3704 improvement. (Bug#8719)
30569699 3705
c11285dc
PE
3706 * alloc.c (make_event_array): Use XINT, not XUINT.
3707 There's no need for unsigned here.
3708
fdccd48e
PE
3709 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3710 This follows up to the 2011-05-06 change that substituted uintptr_t
3711 for EMACS_INT. This case wasn't caught back then.
3712
37910ab2
PE
3713 Rework Fformat to avoid integer overflow issues.
3714 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3715 now (part of C89). Include <verify.h>.
3716 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3717 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3718 (Fformat): Avoid the prepass trying to compute sizes; it was only
3719 approximate and thus did not catch overflow reliably. Instead, walk
3720 through the format just once, formatting and computing sizes as we go,
3721 checking for integer overflow at every step, and allocating a larger
3722 buffer as needed. Keep track separately whether the format is
3723 multibyte. Keep only the most-recently calculated precision, rather
3724 than them all. Record whether each argument has been converted to
3725 string. Use EMACS_INT, not int, for byte and char and arg counts.
3726 Support field widths and precisions larger than INT_MAX. Avoid
3727 sprintf's undefined behavior with conversion specifications such as %#d
3728 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3729 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3730 formatting out-of-range floating point numbers with int
9173deec 3731 formats. (Bug#8668)
37910ab2 3732
2e6578fb
PE
3733 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3734
0ae6bdee
PE
3735 * data.c: Avoid integer truncation in expressions involving floats.
3736 * data.c: Include <intprops.h>.
3737 (arith_driver): When there's an integer overflow in an expression
3738 involving floating point, convert the integers to floating point
3739 so that the resulting value does not suffer from catastrophic
3740 integer truncation. For example, on a 64-bit host (* 4
3741 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3742 Do not rely on undefined behavior after integer overflow.
3743
de883a70
PE
3744 merge count_size_as_multibyte, parse_str_to_multibyte
3745 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 3746 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
3747 Check for integer overflow.
3748 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3749 since it's now a duplicate of the other. This is more of
3750 a character than a buffer op, so better that it's in character.c.
3751 * fns.c, print.c: Adjust to above changes.
3752
2ff916cb
PE
37532011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3754
3755 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3756
f1b54466
PE
37572011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3758
fb1ac845
PE
3759 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3760 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3761 (x_clipboard_manager_save): Now static.
3762 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3763
f1b54466
PE
3764 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3765 (crypto_hash_function): Now static.
3766 Fix pointer signedness problems. Avoid unnecessary initializations.
3767
a9f737ee
CY
37682011-05-27 Chong Yidong <cyd@stupidchicken.com>
3769
3770 * termhooks.h (Vselection_alist): Make it terminal-local.
3771
3772 * terminal.c (create_terminal): Initialize it.
3773
3774 * xselect.c: Support for clipboard managers.
3775 (Vselection_alist): Move to termhooks.h as terminal-local var.
3776 (LOCAL_SELECTION): New macro.
3777 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3778 (symbol_to_x_atom): Remove gratuitous arg.
3779 (x_handle_selection_request, lisp_data_to_selection_data)
3780 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
3781 (x_own_selection, x_get_local_selection, x_convert_selection):
3782 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
3783 (some_frame_on_display): Delete unused function.
3784 (Fx_own_selection_internal, Fx_get_selection_internal)
3785 (Fx_disown_selection_internal, Fx_selection_owner_p)
3786 (Fx_selection_exists_p): New optional frame arg.
3787 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3788 (x_handle_selection_clear): Don't treat other terminals with the
3789 same keyboard specially. Use the terminal-local Vselection_alist.
3790 (x_clear_frame_selections): Use Frun_hook_with_args.
3791
3792 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3793
3794 * xterm.h: Add support for those atoms.
3795
e067f0c1
CY
37962011-05-26 Chong Yidong <cyd@stupidchicken.com>
3797
3798 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3799 (converted_selections, conversion_fail_tag): New global variables.
3800 (x_selection_request_lisp_error): Free the above.
3801 (x_get_local_selection): Remove unnecessary code.
3802 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
3803 of converted selections stored in converted_selections.
3804 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
3805 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3806 (x_convert_selection): New function.
3807 (x_handle_selection_event): Simplify.
3808 (x_get_foreign_selection): Don't ignore incoming requests while
3809 waiting for an answer; this will fail when we implement
3810 SAVE_TARGETS, and seems unnecessary anyway.
3811 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3812 (Vx_sent_selection_functions): Doc fix.
3813
0f4aebc0
LL
38142011-05-26 Leo Liu <sdl.web@gmail.com>
3815
3816 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3817
e61124cd
YM
38182011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3819
3820 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3821
3822 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3823 for fringe update if it has periodic bitmap.
ac389d0c 3824 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
3825 and fringe_bitmap_periodic_p.
3826
3827 * fringe.c (get_fringe_bitmap_data): New function.
3828 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3829 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3830 row. Mark glyph row for fringe update if periodicity changed.
3831
3832 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3833 for fringe update unless it has periodic bitmap.
3834
f16d9837
KH
38352011-05-25 Kenichi Handa <handa@m17n.org>
3836
3837 * xdisp.c (get_next_display_element): Set correct it->face_id for
3838 a static composition.
3839
e1b90ef6
LL
38402011-05-24 Leo Liu <sdl.web@gmail.com>
3841
3842 * deps.mk (fns.o):
3843 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3844
3845 * fns.c (crypto_hash_function, Fsha1): New function.
3846 (Fmd5): Use crypto_hash_function.
3847 (syms_of_fns): Add Ssha1.
3848
7400048f
PE
38492011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3850
3851 * gnutls.c: Remove unused macros.
3852 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3853 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3854 Remove macros that are defined and never used.
3855 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3856
abb71cf4
CY
38572011-05-22 Chong Yidong <cyd@stupidchicken.com>
3858
3859 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3860 (Fx_get_selection_internal): Minor cleanup.
3861 (Fx_own_selection_internal): Rename arguments for consistency with
3862 select.el.
3863
6307db39
PE
38642011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3865
3866 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3867
f3d4e0a4
CY
38682011-05-22 Chong Yidong <cyd@stupidchicken.com>
3869
3870 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3871
4d8ade89
YM
38722011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3873
3874 * dispnew.c (scrolling_window): Don't exclude the case that the
3875 last enabled row in the desired matrix touches the bottom boundary.
3876
32078c8d
GM
38772011-05-21 Glenn Morris <rgm@gnu.org>
3878
3879 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
3880 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3881 and add some more files.
32078c8d 3882
7285dc67
EZ
38832011-05-20 Eli Zaretskii <eliz@gnu.org>
3884
3885 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3886 report_file_error introduced by the change from 2011-05-07.
3887
89d1bd22
PE
38882011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3889
3890 * systime.h (Time): Define only if emacs is defined.
3891 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3892 where the include path doesn't have X11/X.h by default. See
3893 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3894
e23640bb 38952011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
3896
3897 * composite.c (find_automatic_composition): Fix previous change.
3898
b9704ad9
GM
38992011-05-20 Glenn Morris <rgm@gnu.org>
3900
3901 * lisp.mk: New file, split from Makefile.in.
3902 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3903 (shortlisp): Remove.
3904 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3905
4a720484
GM
39062011-05-19 Glenn Morris <rgm@gnu.org>
3907
3908 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3909 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3910 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3911 (lisp): Set the order to that of loadup.el.
3912 (shortlisp): Make it a copy of $lisp.
3913 (SOME_MACHINE_LISP): Remove.
3914 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3915 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3916
a28d4396
KH
39172011-05-18 Kenichi Handa <handa@m17n.org>
3918
3919 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3920 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3921 (find_automatic_composition): Mostly rewrite for efficiency.
3922
a2b1fa8e
JB
39232011-05-18 Juanma Barranquero <lekktu@gmail.com>
3924
3925 * makefile.w32-in: Update dependencies.
3926
8e1f5610
CS
39272011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3928
3929 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 3930 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 3931
7025ee00 39322011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 3933
cdfa6eab
PE
3934 Fix some integer overflow issues, such as string length overflow.
3935
06d6db33
PE
3936 * insdel.c (count_size_as_multibyte): Check for string overflow.
3937
2b4560a8
PE
3938 * character.c (lisp_string_width): Check for string overflow.
3939 Use EMACS_INT, not int, for string indexes and lengths; in
3940 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3941 the resulting string length overflows an EMACS_INT; instead,
3942 report a string overflow if no precision given. When checking for
3943 precision exhaustion, use a check that cannot possibly have
3944 integer overflow. (Bug#8675)
3945 * character.h (lisp_string_width): Adjust to new signature.
3946
cb93f9be
PE
3947 * alloc.c (string_overflow): New function.
3948 (Fmake_string): Use it. This doesn't change behavior, but saves
3949 a few bytes and will simplify future changes.
3950 * character.c (string_escape_byte8): Likewise.
3951 * lisp.h (string_overflow): New decl.
3952
1a1f3366
PE
3953 Fixups, following up to the user-interface timestamp change.
3954 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3955 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3956 * msdos.c (mouse_get_pos): Likewise.
3957 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3958 * w32gui.h (Time): Define by including "systime.h" rather than by
3959 declaring it ourselves. (Bug#8664)
3960
d4e3e4d3
PE
3961 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3962 * image.c (clear_image_cache): Likewise.
3963
f6a24d19
PE
3964 * term.c (term_mouse_position): Don't assume time_t wraparound.
3965
08dc5ae6
PE
3966 Be more systematic about user-interface timestamps.
3967 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3968 and sometimes 'EMACS_UINT', to represent these timestamps.
3969 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3970 This makes the code easier to follow, and makes it easier to catch
3971 integer overflow bugs such as Bug#8664.
3972 * frame.c (Fmouse_position, Fmouse_pixel_position):
3973 Use Time, not unsigned long, for user-interface timestamps.
3974 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3975 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3976 * keyboard.h (last_event_timestamp): Likewise.
3977 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3978 * menu.h (xmenu_show): Likewise.
3979 * term.c (term_mouse_position): Likewise.
3980 * termhooks.h (struct input_event.timestamp): Likewise.
3981 (struct terminal.mouse_position_hook): Likewise.
3982 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3983 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3984 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3985 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3986 what it was before.
3987 * menu.h, termhooks.h: Include "systime.h", for Time.
3988
8e55734a
PE
3989 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3990 Don't assume that the difference between two unsigned long values
3991 can fit into an integer. At this point, we know button_down_time
3992 <= event->timestamp, so the difference must be nonnegative, so
3993 there's no need to cast the result if double-click-time is
3994 nonnegative, as it should be; check that it's nonnegative, just in
3995 case. This bug is triggered when events are more than 2**31 ms
86db42d2 3996 apart (about 25 days). (Bug#8664)
8e55734a 3997
841f1b75 3998 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 3999 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4000
3e26f69c
PE
4001 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4002 that always fit in int. Use a sentinel instead of a counter, to
4003 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4004 * frame.h (struct frame): Use int for menu_bar_items_used
4005 instead of EMACS_INT, since it always fits in int.
3e26f69c 4006
5cc152c0
PE
4007 * menu.c (grow_menu_items): Check for int overflow.
4008
d89eb65e
PE
4009 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4010
5235bd3e
PE
4011 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4012 Before, the code was not consistent. These values cannot exceed
4013 2**31 - 1 so there's no need to make them unsigned.
4014 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4015 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4016 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4017 as modifiers.
4018 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4019
bc827e23
PE
4020 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4021 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4022 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4023 presumably because the widths might not match.
4024
78eb494e
PE
4025 * window.c (size_window): Avoid needless test at loop start.
4026
04f2d78b
CB
40272011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4028
4029 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4030
d2fc7e3d 40312011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4032
4033 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4034
d2fc7e3d 40352011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4036
4037 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4038 `width' to `bar_area_x' and `bar_area_width', respectively.
4039 (x_scroll_run): Take account of fringe background extension.
4040
04f2d78b
CB
4041 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4042 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4043 `bar_area_width', respectively.
4044 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4045 background extension.
4046
79b70037
GM
40472011-05-10 Jim Meyering <meyering@redhat.com>
4048
4049 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4050
2f142cc5
JB
40512011-05-10 Juanma Barranquero <lekktu@gmail.com>
4052
4053 * image.c (Finit_image_library): Return t for built-in image types,
4054 like pbm and xbm. (Bug#8640)
4055
57679c86
AS
40562011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4057
4058 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4059
888c9e86
EZ
40602011-05-07 Eli Zaretskii <eliz@gnu.org>
4061
b0512a1d
EZ
4062 * w32console.c (Fset_screen_color): Doc fix.
4063 (Fget_screen_color): New function.
4064 (syms_of_ntterm): Defsubr it.
4065
7285dc67
EZ
4066 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4067 unlink the temporary file if Fcall_process didn't create it in the
4068 first place.
4069 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4070 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4071 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4072 cue to call_process_cleanup not to close that handle.
4073
4d3fcc8e
BK
40742011-05-07 Ben Key <bkey76@gmail.com>
4075
4076 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4077 one of two shell specific rules, either bootstrap-temacs-CMD or
4078 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4079 to the previous implementation of the bootstrap-temacs rule.
4080 The bootstrap-temacs-CMD rule is similar to the previous
4081 implementation of the bootstrap-temacs rule except that it
4082 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4083 variable.
4084
4085 These changes, along with some changes to nt/configure.bat,
4086 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4087 earlier fix to add support for --cflags and --ldflags options
4088 that include quotes so that it works whether make uses cmd or
4089 sh as the shell.
4090
b4289b64
MA
40912011-05-06 Michael Albinus <michael.albinus@gmx.de>
4092
4093 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4094 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4095 is a constant.
4096 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4097 a string. Handle both cases.
4098 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4099 (Fdbus_register_method): Use Qinvalid_function.
4100
af4c0e28
JB
41012011-05-06 Juanma Barranquero <lekktu@gmail.com>
4102
4103 * makefile.w32-in: Update dependencies.
4104 (LISP_H): Add inttypes.h and stdin.h.
4105 (PROCESS_H): Add unistd.h.
4106
c51453d9
EZ
41072011-05-06 Eli Zaretskii <eliz@gnu.org>
4108
4109 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4110 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4111
8ff0ac3c 41122011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4113
4c4b566b
PE
4114 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4115
aab2b9b5
PE
4116 * term.c (vfatal): Remove stray call to va_end.
4117 It's not needed and the C Standard doesn't allow it here anyway.
4118
c378da0b
PE
4119 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4120 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4121
288b08c7
PE
4122 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4123 bytes.
4124
e3601888
PE
4125 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4126
db6c0e74
PE
4127 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4128
dd5963ea
PE
4129 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4130
88c9450f
PE
4131 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4132
2f9442b8
PE
4133 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4134
c032b5f8
PE
4135 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4136 * charset.c (Fdefine_charset_internal): Don't initialize
4137 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4138 32-bit int (Bug#8600).
a108c10b
PE
4139
4140 * lread.c (read_integer): Be more consistent with string-to-number.
4141 Use string_to_number to do the actual conversion; this avoids
4142 rounding errors and fixes some other screwups. Without this fix,
4143 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4144 (digit_to_number): Move earlier, for benefit of read_integer.
4145 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4146 not a digit in any supported base. (Bug#8602)
a108c10b 4147
ad5f9eea
PE
4148 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4149
aec1708a
PE
4150 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4151 to match comment at start of function. This also removes a
4152 GCC warning about overflow in a 32+64-bit port.
4153
47be4ab5
PE
4154 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4155
371cac43
PE
4156 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4157 Reported by Stefan Monnier in
4158 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4159 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4160 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4161
d01a7826
PE
4162 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4163 (EMACS_UINTPTR): Likewise, with uintptr_t.
4164
7fd47d5c
PE
4165 * lisp.h: Prefer 64-bit EMACS_INT if available.
4166 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4167 on 32-bit hosts that have 64-bit int, so that they can access
4168 large files.
122b0c86
PE
4169 However, temporarily disable this change unless the temporary
4170 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4171
8727937b
PE
4172 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4173
8ac068ac
PE
4174 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4175 This removes an assumption that EMACS_INT and long are the same
4176 width as pointers. The assumption is true for Emacs porting targets
4177 now, but we want to make other targets possible.
4178 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4179 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4180 In the rest of the code, change types of integers that hold casted
4181 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4182 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4183 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4184 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4185 No need to cast type when ORing.
4186 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4187 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4188 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4189 assume EMACS_INT is the same width as char *.
4190 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4191 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4192 Remove no-longer-needed casts.
4193 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4194 (xg_tool_bar_help_callback, xg_make_tool_item):
4195 Use EMACS_INTPTR to hold an integer
4196 that will be cast to void *; this can avoid a GCC warning
4197 if EMACS_INT is not the same width as void *.
4198 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4199 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4200 (current_message_1, set_message_1):
4201 Use a local to convert to proper width without a cast.
4202 * xmenu.c (dialog_selection_callback): Likewise.
4203
ede49d71
PE
4204 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4205 Also, don't assume VALBITS / RAND_BITS is less than 5,
4206 and don't rely on undefined behavior when shifting a 1 left into
4207 the sign bit.
4208 * lisp.h (get_random): Change signature to match.
4209
2f30ecd0
PE
4210 * lread.c (hash_string): Use size_t, not int, for hash computation.
4211 Normally we prefer signed values; but hashing is special, because
4212 it's better to use unsigned division on hash table sizes so that
4213 the remainder is nonnegative. Also, size_t is the natural width
4214 for hashing into memory. The previous code used 'int', which doesn't
4215 retain enough info to hash well into very large tables.
4216 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4217
2a866e7b
PE
4218 * dbusbind.c: Don't possibly lose pointer info when converting.
4219 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4220 Use XPNTR rather than XHASH, so that the high-order bits of
4221 the pointer aren't lost when converting through void *.
4222
51639eac
PE
4223 * eval.c (Fautoload): Don't double-shift a pointer.
4224
92394119
PE
4225 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4226
dbdb9a7c
JB
42272011-05-06 Juanma Barranquero <lekktu@gmail.com>
4228
4229 * gnutls.c (DEF_GNUTLS_FN):
4230 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4231
db7a0b4f
AS
42322011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4233
4234 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4235 marker. (Bug#8610)
4236
f7ff1b0f 42372011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4238
4239 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4240 New version that can reserve upto 2GB of heap space.
4241
f7ff1b0f 42422011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4243
4244 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4245
639c109b
TZ
42462011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4247
4248 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4249 `gnutls_certificate_set_x509_key_file'.
4250
d2127135
JB
42512011-05-05 Juanma Barranquero <lekktu@gmail.com>
4252
4253 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4254 Update dependencies.
4255
e968f4f3
JB
42562011-05-04 Juanma Barranquero <lekktu@gmail.com>
4257
4258 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4259 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4260 Remove unused parameter `fildes'.
4261 * process.c (read_process_output, send_process): Don't pass it.
4262
84d358f0
JB
42632011-05-04 Juanma Barranquero <lekktu@gmail.com>
4264
4265 Fix previous change: the library cache is defined in w32.c.
4266 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4267 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4268
0898ca10
JB
42692011-05-04 Juanma Barranquero <lekktu@gmail.com>
4270
4271 Implement dynamic loading of GnuTLS on Windows.
4272
4273 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4274 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4275 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4276 Declare.
4277
4278 * gnutls.c (Qgnutls_dll): Define.
4279 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4280 (gnutls_*): Declare function pointers.
4281 (init_gnutls_functions): New function to initialize function pointers.
4282 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4283 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4284 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4285 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4286 (emacs_gnutls_write, emacs_gnutls_read)
4287 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4288 (Fgnutls_available_p): New function.
4289 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4290 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4291 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4292
4293 * image.c: Include w32.h.
4294 (Vimage_type_cache): Delete.
4295 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4296 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4297 (w32_delayed_load): Move to w32.c.
4298
4299 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4300
4301 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4302 (w32_delayed_load): Move from image.c. When loading a library, record
4303 its filename in the :loaded-from property of the library id.
4304 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4305 Initialize and staticpro them.
4306 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4307
4308 * process.c: Include lisp.h before w32.h, not after.
4309 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4310 instead of gnutls_record_check_pending.
4311
4312 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4313
ff4de4aa
TZ
43142011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4315
4316 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4317 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4318 as passed in.
4319
abe95abb
JD
43202011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4321
4322 * xterm.c (x_set_frame_alpha): Do not set property on anything
4323 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4324
e16e55d4
JB
43252011-05-02 Juanma Barranquero <lekktu@gmail.com>
4326
4327 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4328
bafcf6a5
JB
43292011-05-02 Juanma Barranquero <lekktu@gmail.com>
4330
4331 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4332 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4333 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4334 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4335 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4336 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4337 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4338 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4339 (Qgnutls_bootprop_callbacks_verify): Make static.
4340
e7a6747f
AS
43412011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4342
19ed11ba
AS
4343 * callproc.c: Indentation fixup.
4344
e7a6747f 4345 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4346 (wait_for_termination, interruptible_wait_for_termination):
4347 Move after wait_for_termination_1.
e7a6747f 4348
1ef14cb4
LMI
43492011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4350
4351 * sysdep.c (interruptible_wait_for_termination): New function
4352 which is like wait_for_termination, but allows keyboard
4353 interruptions.
4354
4355 * callproc.c (Fcall_process): Add (:file "file") as an option for
4356 the STDOUT buffer.
4357 (Fcall_process_region): Ditto.
4358
330d880c
EZ
43592011-04-30 Eli Zaretskii <eliz@gnu.org>
4360
8db90b73
EZ
4361 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4362 rather than `XVECTOR (FOO)->size'.
4363
330d880c
EZ
4364 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4365 inttypes.h, as a gnulib replacement is used if it not available in
4366 system headers.
4367
15cbd324
EZ
43682011-04-21 Eli Zaretskii <eliz@gnu.org>
4369
4370 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4371 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4372 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4373
4374 * coding.c (coding_alloc_by_realloc): Error out if destination
4375 will grow beyond MOST_POSITIVE_FIXNUM.
4376 (decode_coding_emacs_mule): Abort if there isn't enough place in
4377 charbuf for the composition carryover bytes. Reserve an extra
4378 space for up to 2 characters produced in a loop.
4379 (decode_coding_iso_2022): Abort if there isn't enough place in
4380 charbuf for the composition carryover bytes.
4381
43822011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4383
ae940cca
EZ
4384 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4385 aborting when %lld or %lll format is passed.
4386 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4387 %llo or %llx format is passed. (Bug#8545)
4388
03ab8921
EZ
4389 * window.c (window_scroll_line_based): Use a marker instead of
4390 simple variables to record original value of point. (Bug#7952)
4391
afda1437
EZ
4392 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4393 produced by %s or %c overflows available buffer space. (Bug#8545)
4394
f76dee0c
PE
43952011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4396
4397 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4398 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4399
fdc5744d
JB
44002011-04-28 Juanma Barranquero <lekktu@gmail.com>
4401
4402 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4403
638f053a
JB
44042011-04-28 Juanma Barranquero <lekktu@gmail.com>
4405
4406 * keyboard.c (Qdelayed_warnings_hook): Define.
4407 (command_loop_1): Run `delayed-warnings-hook'
4408 if Vdelayed_warnings_list is non-nil.
4409 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4410 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4411
d178f871
EZ
44122011-04-28 Eli Zaretskii <eliz@gnu.org>
4413
4414 * doprnt.c (doprnt): Don't return value smaller than the buffer
4415 size if the message was truncated. (Bug#8545).
4416
b124fd93
JB
44172011-04-28 Juanma Barranquero <lekktu@gmail.com>
4418
4419 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4420 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4421
e810457d
PE
44222011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4423
4424 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4425
ea51cceb
JB
44262011-04-27 Juanma Barranquero <lekktu@gmail.com>
4427
4428 * makefile.w32-in: Update dependencies.
4429
94dcfacf
EZ
44302011-04-27 Eli Zaretskii <eliz@gnu.org>
4431
4432 Improve `doprnt' and its usage. (Bug#8545)
4433 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4434 `format_end'. Remove support for %l as a conversion specifier.
4435 Don't use xrealloc. Improve diagnostics when the %l size modifier
4436 is used. Update the commentary.
4437
4438 * eval.c (verror): Simplify calculation of size_t.
4439
4440 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4441 messages.
4442
f61f41d7
PE
44432011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4444
4445 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4446 change.
4447
96fb4434
PE
44482011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4449
4450 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4451 This makes this file independent of the recent pseudovector change.
4452
671875da 44532011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 4454
69e9b5a3
PE
4455 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4456
b5f869a7 4457 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 4458 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 4459 Remove unused local.
c8926152 4460 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 4461
841a1577 4462 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
4463 GCC 4.6.0 optimizes based on type-based alias analysis.
4464 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
4465 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4466 != &v->size, and therefore "v->size = 1; b->size = 2; return
4467 v->size;" must therefore return 1. This assumption is incorrect
4468 for Emacs, since it type-puns struct Lisp_Vector * with many other
4469 types. To fix this problem, this patch adds a new type struct
f904488f 4470 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
4471 and pseudovectors, and helps optimizing compilers not get fooled
4472 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4473 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
4474 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4475 the size member.
eab3844f
PE
4476 (XSETPVECTYPE): Rewrite in terms of new macro.
4477 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4478 This is a bit clearer, and further avoids the possibility of
4479 undesirable aliasing.
4480 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 4481 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
4482 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4483 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
4484 (ASIZE): Now uses header.size rather than size.
4485 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
4486 to avoid the hassle of writing XVECTOR (foo)->header.size.
4487 (struct vectorlike_header): New type.
eab3844f
PE
4488 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4489 object, to help avoid aliasing.
4490 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4491 (SUBRP): Likewise, since Lisp_Subr is a special case.
4492 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4493 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4494 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 4495 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
4496 changed to be "header.size" and "header.next".
4497 * buffer.h (struct buffer): Likewise.
4498 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4499 * frame.h (struct frame): Likewise.
4500 * process.h (struct Lisp_Process): Likewise.
4501 * termhooks.h (struct terminal): Likewise.
4502 * window.c (struct save_window_data, struct saved_window): Likewise.
4503 * window.h (struct window): Likewise.
4504 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4505 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4506 * buffer.c (init_buffer_once): Likewise.
4507 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4508 special case.
4509 * process.c (Fformat_network_address): Use local var for size,
4510 for brevity.
4511
0df1eac5
PE
4512 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4513
847ab9d1 4514 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
4515 * data.c (atof): Remove decl; no longer used or needed.
4516 (digit_to_number): Move to lread.c.
4517 (Fstring_to_number): Use new string_to_number function, to be
4518 consistent with how the Lisp reader treats infinities and NaNs.
4519 Do not assume that floating-point numbers represent EMACS_INT
4520 without losing information; this is not true on most 64-bit hosts.
4521 Avoid double-rounding errors, by insisting on integers when
4522 parsing non-base-10 numbers, as the documentation specifies.
4523 * lisp.h (string_to_number): New decl, replacing ...
4524 (isfloat_string): Remove.
bc0a5c13 4525 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 4526 (read1): Do not accept +. and -. as integers; this
452f4150
PE
4527 appears to have been a coding error. Similarly, do not accept
4528 strings like +-1e0 as floating point numbers. Do not report
4529 overflow for integer overflows unless the base is not 10 which
4530 means we have no simple and reliable way to continue.
4531 Break out the floating-point parsing into a new
4532 function string_to_number, so that Fstring_to_number parses
4533 floating point numbers consistently with the Lisp reader.
04f2d78b 4534 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
4535 (E_CHAR, EXP_INT): Remove, replacing with ...
4536 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4537 (string_to_number): New function, replacing isfloat_string.
4538 This function checks for valid syntax and produces the resulting
4539 Lisp float number too. Rework it so that string-to-number
bc0a5c13 4540 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
4541 so that overflow for non-base-10 numbers is reported only when
4542 there's no portable and simple way to convert to floating point.
452f4150 4543
67769ffc
PE
4544 * textprop.c (set_text_properties_1): Rewrite for clarity,
4545 and to avoid GCC warning about integer overflow.
4546
c20db43f
PE
4547 * intervals.h (struct interval): Use EMACS_INT for members
4548 where EMACS_UINT might cause problems. See
4549 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4550 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4551 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4552 All uses changed.
37aa2f85
PE
4553 (offset_intervals): Tell GCC not to worry about length overflow
4554 when negating a negative length.
c20db43f 4555
2538aa2f
PE
4556 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4557 (overrun_check_free): Likewise.
4558
f2d3008d
PE
4559 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4560 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4561 word size.
4562
ec8df744
PE
4563 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4564 (gnutls_make_error): Rename local to avoid shadowing.
4565 (gnutls_emacs_global_deinit): ifdef out; not used.
4566 (Fgnutls_boot): Use const for pointer to readonly storage.
4567 Comment out unused local. Fix pointer signedness problems.
4568
640ee02d
PE
4569 * lread.c (openp): Don't stuff size_t into an 'int'.
4570 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4571 about possible signed overflow.
4572
6048fb2a
PE
4573 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4574 (GDK_KEY_g): Don't define if already defined.
4575 (xg_prepare_tooltip): Avoid pointer signedness problem.
4576 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4577
fa3c87e1
PE
4578 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4579 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4580
2172544b
PE
4581 * xfns.c (Fx_window_property): Simplify a bit,
4582 to make a bit faster and to avoid GCC 4.6.0 warning.
4583 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4584
9b821a21
PE
4585 * fns.c (internal_equal): Don't assume size_t fits in int.
4586
3c616cfa
PE
4587 * alloc.c (compact_small_strings): Tighten assertion a little.
4588
c2982e87
PE
4589 Replace pEd with more-general pI, and fix some printf arg casts.
4590 * lisp.h (pI): New macro, generalizing old pEd macro to other
4591 conversion specifiers. For example, use "...%"pI"d..." rather
4592 than "...%"pEd"...".
4593 (pEd): Remove. All uses replaced with similar uses of pI.
4594 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4595 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4596 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4597 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4598 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4599 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4600 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4601 64-bit hosts.
4602 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4603 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4604 * print.c (safe_debug_print, print_object): Likewise.
4605 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4606 to int.
6f04d126
PE
4607 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4608 avoiding the 0 flag, which is not portable.
c2982e87
PE
4609 * process.c (Fmake_network_process): Use pI to avoid cast.
4610 * region-cache.c (pp_cache): Likewise.
4611 * xdisp.c (decode_mode_spec): Likewise.
4612 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4613 behavior on 64-bit hosts with printf arg.
6f04d126 4614 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4615 (x_stop_queuing_selection_requests): Likewise.
4616 (x_get_window_property): Don't truncate byte count to an 'int'
4617 when tracing.
0b432f21 4618
5e073ec7
PE
4619 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4620 here, since it parses constructs like leading '-' and spaces,
4621 which are not wanted; and it overflows with large numbers.
4622 Instead, simply match F[0-9]+, which is what is wanted anyway.
4623
36372bf9
PE
4624 * alloc.c: Remove unportable assumptions about struct layout.
4625 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4626 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4627 (allocate_vectorlike, make_pure_vector): Use the new macros,
4628 plus offsetof, to remove unportable assumptions about struct layout.
4629 These assumptions hold on all porting targets that I know of, but
4630 they are not guaranteed, they're easy to remove, and removing them
4631 makes further changes easier.
4632
0b432f21
PE
4633 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4634 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
4635 (string_overrun_cookie): Now const. Use initializers that
4636 don't formally overflow signed char, to avoid warnings.
000098c1
PE
4637 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4638 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
4639 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4640 multiple of sizeof (EMACS_INT); it need not be, if
4641 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 4642 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 4643
895009e1
JB
46442011-04-26 Juanma Barranquero <lekktu@gmail.com>
4645
4646 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4647
6a7a1b0b
TZ
46482011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4649
4650 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 4651 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
4652 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4653
841a1577 46542011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
4655
4656 * lisp.h (Qdebug): List symbol.
895009e1 4657 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
4658 * keyboard.c (debug-on-event): New variable.
4659 (handle_user_signal): Break into debugger when debug-on-event
4660 matches the current signal symbol.
4661
f2d3ba6f
DN
46622011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4663
4664 * alloc.c (check_sblock, check_string_bytes)
4665 (check_string_free_list): Convert to standard C.
4666
42ce4c63
TZ
46672011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4668
4669 * w32.c (emacs_gnutls_push): Fix typo.
4670
825cd63c
EZ
46712011-04-25 Eli Zaretskii <eliz@gnu.org>
4672
fb11d64d
EZ
4673 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4674 "cast to pointer from integer of different size".
4675
825cd63c
EZ
4676 Improve doprnt and its use in verror. (Bug#8545)
4677 * doprnt.c (doprnt): Document the set of format control sequences
4678 supported by the function. Use SAFE_ALLOCA instead of always
4679 using `alloca'.
4680
4681 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4682 is one byte too soon. Don't use xrealloc; instead xfree and
4683 xmalloc anew.
4684
e061a11b
TZ
46852011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4686
4687 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4688 callbacks stage.
4689
4690 * gnutls.c: Renamed global_initialized to
4691 gnutls_global_initialized. Added internals for the
4692 :verify-hostname-error, :verify-error, and :verify-flags
4693 parameters of `gnutls-boot' and documented those parameters in the
4694 docstring. Start callback support.
9173deec
JB
4695 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4696 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4697 on error. Return error code.
e061a11b
TZ
4698 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4699 (emacs_gnutls_read): Likewise.
4700 (Fgnutls_boot): Return handshake error code.
4701 (emacs_gnutls_handle_error): New function.
4702 (wsaerror_to_errno): Likewise.
4703
4704 * w32.h (emacs_gnutls_pull): Add prototype.
4705 (emacs_gnutls_push): Likewise.
4706
4707 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4708 (emacs_gnutls_push): Likewise.
4709
47102011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4711
4712 * process.c (wait_reading_process_output): Check if GnuTLS
4713 buffered some data internally if no FDs are set for TLS
4714 connections.
4715
4716 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4717 (LIBS): Link to USER_LIBS.
4718 ($(BLD)/gnutls.$(0)): New target.
4719
fa6996bc
EZ
47202011-04-24 Eli Zaretskii <eliz@gnu.org>
4721
eb35682e
EZ
4722 * xdisp.c (handle_single_display_spec): Rename the
4723 display_replaced_before_p argument into display_replaced_p, to
4724 make it consistent with the commentary. Fix typos in the
4725 commentary.
4726
e2ad650c
EZ
4727 * textprop.c (syms_of_textprop): Remove dead code.
4728 (copy_text_properties): Delete obsolete commentary about an
4729 interface that was deleted long ago. Fix typos in the description
4730 of arguments.
4731
1b2de274
EZ
4732 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4733 to changes in oldXMenu/XMenu.h from 2011-04-16.
4734 <menu_help_message, prev_menu_help_message>: Constify.
4735 (IT_menu_make_room): menu->help_text is now `const char **';
4736 adjust.
4737
4738 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4739 to changes in oldXMenu/XMenu.h from 2011-04-16.
4740 (struct XMenu): Declare `help_text' `const char **'.
4741
4742 * xfaces.c <Qunspecified>: Make extern again.
4743
4744 * syntax.c: Include sys/types.h before including regex.h, as
4745 required by Posix.
4746
762b15be
EZ
4747 * doc.c (get_doc_string): Improve the format passed to `error'.
4748
4749 * doprnt.c (doprnt): Improve commentary.
4750
4751 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4752
4753 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4754 them with etags.
4755
f1052e5d
EZ
4756 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4757 changes in globals.h immediately force recompilation.
762b15be
EZ
4758 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4759 $(CURDIR)/s/ms-w32.h.
4760 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 4761
fa6996bc
EZ
4762 * character.c (Fchar_direction): Function deleted.
4763 (syms_of_character): Don't defsubr it.
4764 <char-direction-table>: Deleted.
4765
e6c3da20
EZ
47662011-04-23 Eli Zaretskii <eliz@gnu.org>
4767
4768 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4769 * doprnt.c: Include limits.h.
4770 (SIZE_MAX): New macro.
04f2d78b
CB
4771 (doprnt): Return a size_t value. 2nd arg is now size_t.
4772 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
4773 Improve overflow protection. Support `l' modifier for integer
4774 conversions. Support %l conversion. Don't assume an EMACS_INT
4775 argument for integer conversions and for %c.
4776
4777 * lisp.h (doprnt): Restore prototype.
4778
4779 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4780 $(SRC)/character.h.
4781
4782 * Makefile.in (base_obj): Add back doprnt.o.
4783
4784 * deps.mk (doprnt.o): Add back prerequisites.
4785 (callint.o): Depend on character.h.
4786
4787 * eval.c (internal_lisp_condition_case): Include the handler
4788 representation in the error message.
4789 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4790 when breaking from the loop.
4791
4792 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4793
4794 * callint.c (Fcall_interactively): When displaying error message
4795 about invalid control letter, pass the character's codepoint, not
4796 a pointer to its multibyte form. Improve display of the character
4797 in octal and display also its hex code.
4798
4799 * character.c (char_string): Use %x to display the (unsigned)
4800 codepoint of an invalid character, to avoid displaying a bogus
4801 negative value.
4802
4803 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4804 `error', not SYMBOL_NAME itself.
4805
4806 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4807 character arguments to `error'.
4808
4809 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4810 to `error' in error message about FINAL_CHAR argument. Make sure
4811 FINAL_CHAR is a character, and use %c when it is passed as
4812 argument to `error'.
4813
4ffd0d6b 48142011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
4815
4816 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4817
4818 * w32.c: Include <time.h>.
4819 (sys_localtime): New function.
4820
4ffd0d6b 48212011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
4822
4823 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4824
4ffd0d6b 4825 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 4826
4ffd0d6b 48272011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 4828
4ffd0d6b
GM
4829 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4830 zombies (Bug#8467).
aac0c6e3 4831
04c56954
EZ
48322011-04-19 Eli Zaretskii <eliz@gnu.org>
4833
4834 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4835 gl_state.e_property when gl_state.object is Qt.
4836
4837 * insdel.c (make_gap_larger): Remove limitation of buffer size
4838 to <= INT_MAX.
4839
16a43933
CY
48402011-04-18 Chong Yidong <cyd@stupidchicken.com>
4841
4842 * xdisp.c (lookup_glyphless_char_display)
4843 (produce_glyphless_glyph): Handle cons cell entry in
4844 glyphless-char-display.
4845 (Vglyphless_char_display): Document it.
4846
4847 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4848 glyphless-char-display.
4849
4581706e
CY
48502011-04-17 Chong Yidong <cyd@stupidchicken.com>
4851
4852 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4853
4854 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4855
4856 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4857 definition for no-X builds.
4858
4887c6e2 48592011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 4860
fd35b6f9
PE
4861 Static checks with GCC 4.6.0 and non-default toolkits.
4862
5c1ccb01
PE
4863 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4864
006c5daa
PE
4865 * process.c (keyboard_bit_set): Define only if SIGIO.
4866 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4867 (send_process): Repair possible setjmp clobbering.
4868
efc736d3
PE
4869 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4870
4e2fe2e6
PE
4871 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4872
f97334a2
PE
4873 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4874
4e75f29d
PE
4875 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4876 Define only if needed.
4877
90efadd1
PE
4878 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4879 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 4880 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 4881
3c647824
PE
4882 * dispextern.h (struct redisplay_interface): Rename param
4883 to avoid shadowing.
e264f262 4884 * termhooks.h (struct terminal): Likewise.
761383f4 4885 * xterm.c (xembed_send_message): Likewise.
3c647824 4886
b58c5c4a
PE
4887 * insdel.c (make_gap_smaller): Define only if
4888 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4889
cad59032
PE
4890 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4891 it.
4892
c339dc2e
PE
4893 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4894 so that we aren't warned about unused symbols.
4895
91a3e27b
PE
4896 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4897
399c71d3 4898 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 4899
8ffc96f5
PE
4900 * xfns.c (x_real_positions): Mark locals as initialized.
4901
eef9bc79
PE
4902 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4903
098db9dd
PE
4904 * xterm.c: Fix problems found by static analysis with other toolkits.
4905 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
4906 (x_dispatch_event): Declare static if USE_GTK, and
4907 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 4908 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 4909 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
4910 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4911 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 4912
eb18f6cc
PE
4913 * xmenu.c (menu_help_callback): Pointer type fixes.
4914 Use const pointers when pointing at readonly data. Avoid pointer
4915 signedness clashes.
4916 (FALSE): Remove unused macro.
4917 (update_frame_menubar): Remove unused decl.
4918
1fe72bf8
PE
4919 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4920
60d9e1db
PE
4921 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4922 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4923 (single_menu_item): Rename local to avoid shadowing.
4924
39261c26
PE
4925 * keyboard.c (make_lispy_event): Remove unused local var.
4926
018c5e19
PE
4927 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4928 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4929
63d2b86e
PE
4930 * bitmaps: Change bitmaps from unsigned char back to the X11
4931 compatible char. Avoid the old compiler warnings about
4932 out-of-range initializers by using, for example, '\xab' rather
4933 than 0xab.
4934
aefd87e1
PE
4935 * xgselect.c (xgselect_initialize): Check vs interface
4936 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4937
bf501fb9
PE
4938 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4939
e9829fdf
PE
4940 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4941 to read-only memory.
4942
1086c095
PE
4943 * fns.c (vector): Remove; this old hack is no longer needed.
4944
2baccd04 4945 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4946 Remove unused var.
dde42981 4947 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4948
72391843 4949 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4950
436c16df 4951 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4952 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4953 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4954
92bb796d 4955 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4956 (x_term_init): Remove local to avoid shadowing.
92bb796d 4957
764430a3 4958 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4959
4960 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4961 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4962
d1dfb56c
EZ
49632011-04-16 Eli Zaretskii <eliz@gnu.org>
4964
c4354cb4
EZ
4965 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4966
d1dfb56c
EZ
4967 Fix regex.c, syntax.c and friends for buffers > 2GB.
4968 * syntax.h (struct gl_state_s): Declare character position members
4969 EMACS_INT.
4970
4971 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4972
04f2d78b
CB
4973 * textprop.c (verify_interval_modification, interval_of):
4974 Declare arguments EMACS_INT.
d1dfb56c
EZ
4975
4976 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4977 EMACS_INT.
4978
4979 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4980
4981 * indent.c (Fvertical_motion): Local variable it_start is now
4982 EMACS_INT.
4983
4984 * regex.c (re_match, re_match_2, re_match_2_internal)
4985 (bcmp_translate, regcomp, regexec, print_double_string)
4986 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4987 (re_compile_pattern, re_exec): Declare arguments and local
4988 variables `size_t' and `ssize_t' and return values `regoff_t', as
4989 appropriate.
4990 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4991 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4992 <compile_stack_type>: `size' and `avail' are now `size_t'.
4993
4994 * regex.h <regoff_t>: Use ssize_t, not int.
4995 (re_search, re_search_2, re_match, re_match_2): Arguments that
4996 specify buffer/string position and length are now ssize_t and
4997 size_t. Return type is regoff_t.
4998
613052cd
BK
49992011-04-16 Ben Key <bkey76@gmail.com>
5000
5001 * nsfont.m: Fixed bugs in ns_get_family and
5002 ns_descriptor_to_entity that were caused by using free to
5003 deallocate memory blocks that were allocated by xmalloc (via
5004 xstrdup). This caused Emacs to crash when compiled with
5005 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5006 --enable-checking=xmallocoverrun). xfree is now used to
5007 deallocate these memory blocks.
5008
4170f62f 50092011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5010
71b41406
PE
5011 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5012
9587a89d
PE
5013 emacs_write: Accept and return EMACS_INT for sizes.
5014 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5015 et seq.
5016 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5017 Accept and return EMACS_INT.
5018 (emacs_gnutls_write): Return the number of bytes written on
5019 partial writes.
5020 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5021 (emacs_read, emacs_write): Remove check for negative size, as the
5022 Emacs source code has been audited now.
9587a89d
PE
5023 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5024 (emacs_read, emacs_write): Use it.
273a5f82
PE
5025 * process.c (send_process): Adjust to the new signatures of
5026 emacs_write and emacs_gnutls_write. Do not attempt to store
5027 a byte offset into an 'int'; it might overflow.
9587a89d 5028 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5029
3e047f51
PE
5030 * sound.c: Don't assume sizes fit in 'int'.
5031 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5032 Return EMACS_INT, not int.
3e047f51 5033 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5034 Accept EMACS_INT, not int.
5035 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5036 record read return values.
5037
cc39a9db
BK
50382011-04-15 Ben Key <bkey76@gmail.com>
5039
c9d0ec6d
JB
5040 * keyboard.c (Qundefined): Don't declare static since it is used
5041 in nsfns.m.
5042 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5043 static since they are used in nsfont.m.
cc39a9db 5044
6c60eb9f
SM
50452011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5046
5047 * process.c (Qprocessp): Don't declare static.
5048 * lisp.h (Qprocessp): Declare again.
5049
7990b61a
JB
50502011-04-15 Juanma Barranquero <lekktu@gmail.com>
5051
5052 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5053
5d4cb038
PE
50542011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5055
8bd7b830 5056 Improve C-level modularity by making more things 'static'.
cd64ea1d 5057
e3b27b31
PE
5058 Don't publish debugger-only interfaces to other modules.
5059 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5060 (verify_bytepos, count_markers): Move decls to the only modules
5061 that need them.
5062 * region-cache.h (pp_cache): Likewise.
5063 * window.h (check_all_windows): Likewise.
5064 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5065
5d4cb038
PE
5066 * sysdep.c (croak): Now static, if
5067 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5068 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5069
5070 * alloc.c (refill_memory_reserve): Now static if
5071 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5072 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5073
e87b6180
PE
5074 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5075 Define only if USE_LUCID.
5076
ac64929e
PE
5077 * xrdb.c (x_customization_string, x_rm_string): Now static.
5078
6f37259d
PE
5079 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5080 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5081
1683e3ab
PE
5082 * xdisp.c (draw_row_with_mouse_face): Now static.
5083 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5084
de9c2632
PE
5085 * window.h (check_all_windows): Mark externally visible.
5086
2b96acb7
PE
5087 * window.c (window_deletion_count): Now static.
5088
5089 * undo.c: Make symbols static if they're not exported.
5090 (last_undo_buffer, last_boundary_position, pending_boundary):
5091 Now static.
5092
50436f33
PE
5093 * textprop.c (interval_insert_behind_hooks): Now static.
5094 (interval_insert_in_front_hooks): Likewise.
5095
64520e5c
PE
5096 * term.c: Make symbols static if they're not exported.
5097 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5098 (max_frame_lines, tty_set_terminal_modes):
5099 (tty_reset_terminal_modes, tty_turn_off_highlight):
5100 (get_tty_terminal): Now static.
5101 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5102 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5103 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5104 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5105 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5106
1fa53021
PE
5107 * sysdep.c: Make symbols static if they're not exported.
5108 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5109 Now static.
5110 (sigprocmask_set, full_mask): Remove; unused.
5111 (wait_debugging): Mark as visible.
5112 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5113 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5114
d4b43b22
PE
5115 * syntax.c (syntax_temp): Define only if !__GNUC__.
5116
b7c513d0
PE
5117 * sound.c (current_sound_device, current_sound): Now static.
5118
989b29ad
PE
5119 * search.c (searchbufs, searchbuf_head): Now static.
5120
13a55a78
PE
5121 * scroll.c (scroll_cost): Remove; unused.
5122 * dispextern.h (scroll_cost): Remove decl.
5123
de68a1fc
PE
5124 * region-cache.h (pp_cache): Mark as externally visible.
5125
40ccffa6
PE
5126 * process.c: Make symbols static if they're not exported.
5127 (process_tick, update_tick, create_process, chan_process):
5128 (Vprocess_alist, proc_buffered_char, datagram_access):
5129 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5130 (deactivate_process): Mark defn as static, as well as decl.
5131 * lisp.h (create_process): Remove decl.
5132 * process.h (chan_process, Vprocess_alist): Remove decls.
5133
ad64fc97
PE
5134 * print.c: Make symbols static if they're not exported.
5135 (print_depth, new_backquote_output, being_printed, print_buffer):
5136 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5137 (print_interval, print_number_index, initial_stderr_stream):
5138 Now static.
5139 * lisp.h (Fprinc): Remove decl.
5140 (debug_output_compilation_hack): Mark as externally visible.
5141
adddb265
PE
5142 * sysdep.c (croak): Move decl from here to syssignal.h.
5143 * syssignal.h (croak): Put it here, so the API can be checked when
5144 'croak' is called from dissociate_if_controlling_tty.
5145
1717ede2
PE
5146 * minibuf.c: Make symbols static if they're not exported.
5147 (minibuf_save_list, choose_minibuf_frame): Now static.
5148 * lisp.h (choose_minibuf_frame): Remove decl.
5149
fa5fb2bc
PE
5150 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5151
1e3890d1
PE
5152 * lread.c: Make symbols static if they're not exported.
5153 (read_objects, initial_obarray, oblookup_last_bucket_number):
5154 Now static.
5155 (make_symbol): Remove; unused.
5156 * lisp.h (initial_obarray, make_symbol): Remove decls.
5157
8a1414fa
PE
5158 * keyboard.c: Make symbols static if they're not exported.
5159 (single_kboard, recent_keys_index, total_keys, recent_keys):
5160 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5161 (this_single_command_key_start, echoing, last_auto_save):
5162 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5163 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5164 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5165 (Vlispy_mouse_stem, double_click_count):
5166 Now static.
5167 (force_auto_save_soon): Define only if SIGDANGER.
5168 (ignore_mouse_drag_p): Now static if
5169 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5170 (print_help): Remove; unused.
5171 (stop_character, last_timer_event): Mark as externally visible.
5172 * keyboard.h (ignore_mouse_drag_p): Declare only if
5173 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5174 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5175 * lisp.h (echoing): Remove decl.
5176 (force_auto_save_soon): Declare only if SIGDANGER.
5177 * xdisp.c (redisplay_window): Simplify code, to make it more
5178 obvious that ignore_mouse_drag_p is not accessed if !defined
5179 USE_GTK && !defined HAVE_NS.
5180
93ea6e8f
PE
5181 * intervals.c: Make symbols static if they're not exported.
5182 (merge_properties_sticky, merge_interval_right, delete_interval):
5183 Now static.
5184 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5185
77382fcc
PE
5186 * insdel.c: Make symbols static if they're not exported.
5187 However, leave prepare_to_modify_buffer alone. It's never
5188 called from outside this function, but that appears to be a bug.
5189 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5190 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5191 (adjust_after_replace_noundo): Remove; unused.
5192 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5193 (signal_before_change): Remove decls.
77382fcc 5194
9306c32e
PE
5195 * indent.c (val_compute_motion, val_vmotion): Now static.
5196
cd44d2eb
PE
5197 * image.c: Make symbols static if they're not exported.
5198 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5199 if USE_GTK.
5200 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5201 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5202
ad9a7a06
PE
5203 * fringe.c (standard_bitmaps): Now static.
5204 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5205
81626931
PE
5206 * frame.c: Make symbols static if they're not exported.
5207 (x_report_frame_params, make_terminal_frame): Now static.
5208 (get_frame_param): Now static, unless HAVE_NS.
5209 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5210 (x_get_resource_string): Remove; not used.
5211 * frame.h (make_terminal_frame, x_report_frame_params):
5212 (x_get_resource_string); Remove decls.
5213 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5214 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5215
239f9db9
PE
5216 * font.c, fontset.c: Make symbols static if they're not exported.
5217 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5218 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5219 * font.c (font_close_object): Now static.
5220 * font.h (font_close_object): Remove.
5221 * fontset.c (FONTSET_OBJLIST): Remove.
5222 (free_realized_fontset) #if-0 the body, which does nothing.
5223 (face_suitable_for_char_p): #if-0, as it's never called.
5224 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5225 * xfaces.c (face_at_string_position):
5226 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5227 since 0 is always ASCII.
5228
dfcf3579
PE
5229 * fns.c (weak_hash_tables): Now static.
5230
5045092b
PE
5231 * fileio.c: Make symbols static if they're not exported.
5232 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5233 (Vwrite_region_annotation_buffers): Now static.
5234
57a96f5c
PE
5235 * eval.c: Make symbols static if they're not exported.
5236 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5237 * lisp.h (backtrace_list): Remove decl.
5238
35f08c38
PE
5239 * emacs.c: Make symbols static if they're not exported.
5240 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5241 (fatal_error_code, fatal_error_signal_hook, standard_args):
5242 Now static.
5243 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5244 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5245 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5246 * lisp.h (fatal_error_signal_hook): Remove decl.
5247 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5248
f44bd759
PE
5249 * editfns.c: Move a (normally-unused) function to its only use.
5250 * editfns.c, lisp.h (get_operating_system_release): Remove.
5251 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5252 worth the hassle of breaking this out.
5253
b532497d
PE
5254 * xterm.c: Make symbols static if they're not exported.
5255 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5256 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5257 (x_destroy_window, x_delete_display):
5258 Now static.
5259 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5260 (x_mouse_leave): Remove; unused.
5261 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5262 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5263 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5264 Remove decls.
5265 (x_mouse_leave): Declare only if WINDOWSNT.
5266 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5267 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5268 USE_X_TOOLKIT.
5269
1675728f
PE
5270 * ftxfont.c: Make symbols static if they're not exported.
5271 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5272 HAVE_FREETYPE.
5273 * font.h (ftxfont_driver): Likewise.
5274
e4cebfca
PE
5275 * xfns.c: Make symbols static if they're not exported.
5276 (x_last_font_name, x_display_info_for_name):
5277 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5278 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5279 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5280 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5281 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5282 (last_show_tip_args): Now static.
5283 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5284 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5285 (x_screen_planes): Remove; unused.
5286 * dispextern.h (x_screen_planes): Remove decl.
5287
5bf46f05
PE
5288 * dispnew.c: Make symbols static if they're not exported.
5289 * dispextern.h (redraw_garbaged_frames, scrolling):
5290 (increment_row_positions): Remove.
5291 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5292 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5293 Now static.
5294 (redraw_garbaged_frames): Remove; unused.
5295
435f4c28
PE
5296 * xfaces.c: Make symbols static if they're not exported.
5297 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5298 Remove decls.
5299 * xterm.h (defined_color): Remove decls.
5300 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5301 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5302 (menu_face_changed_default, defined_color, free_realized_face):
5303 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5304 (ascii_face_of_lisp_face): Remove; unused.
5305
8524aef3
PE
5306 * xdisp.c: Make symbols static if they're not exported.
5307 * dispextern.h (scratch_glyph_row, window_box_edges):
5308 (glyph_to_pixel_coords, set_cursor_from_row):
5309 (get_next_display_element, set_iterator_to_next):
5310 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5311 (show_mouse_face): Remove decls
5312 * frame.h (message_buf_print): Likewise.
5313 * lisp.h (pop_message, set_message, check_point_in_composition):
5314 Likewise.
5315 * xterm.h (set_vertical_scroll_bar): Likewise.
5316 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5317 (message_buf_print, scratch_glyph_row, displayed_buffer):
5318 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5319 (get_next_display_element, show_mouse_face, window_box_edges):
5320 (frame_to_window_pixel_xy, check_point_in_composition):
5321 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5322 (glyph_to_pixel_coords): Remove; unused.
5323
16390cd2
PE
5324 * dired.c (file_name_completion): Now static.
5325
5326 * dbusbind.c (xd_in_read_queued_messages): Now static.
5327
a25f4dfa
PE
5328 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5329 * data.c (circular_list_error): Remove.
5330
14a9c8df
PE
5331 * commands.h (last_point_position, last_point_position_buffer):
5332 (last_point_position_window): Remove decls.
5333 * keyboard.c: Make these variables static.
5334
04f2d78b
CB
5335 * coding.h (coding, code_convert_region, encode_coding_gap):
5336 Remove decls.
74ab6df5
PE
5337 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5338 (iso_code_class, detect_coding, code_convert_region): Now static.
5339 (encode_coding_gap): Remove; unused.
5340
38dfbee1
PE
5341 * chartab.c (chartab_chars, chartab_bits): Now static.
5342
a2cb4e63
PE
5343 * charset.h (charset_iso_8859_1): Remove decl.
5344 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5345 Now static.
5346
127198fd
PE
5347 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5348 * ccl.c (Vccl_program_table): Now static.
5349 (check_ccl_update): Remove; unused.
5350
d85b608f
PE
5351 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5352 * category.h: ... from here.
5353 * category.c (check_category_table, set_category_set): Now static.
5354
31cd66f3
PE
5355 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5356 * lisp.h: Remove these decls.
5357
c358e587
PE
5358 * buffer.c (buffer_count): Remove unused var.
5359
e78aecca
PE
5360 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5361 so that it's not optimized away.
5362 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5363 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5364 exported only to the debugger.
5365
e192d7d3 5366 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5367 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5368
92470028
PE
5369 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5370 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5371 was inaccessible from Lisp.
5372 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5373 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5374
244ed907
PE
5375 alloc.c: Import and export fewer symbols, and remove unused items.
5376 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5377 is defined.
5378 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5379 it's not optimized away by whole-program optimization.
5380 (message_enable_multibyte, free_misc): Remove.
5381 (catchlist, handlerlist, mark_backtrace):
5382 Declare only if BYTE_MARK_STACK.
5383 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5384 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5385 (message_enable_multibyte): Remove decl.
5386 (free_misc, interval_free_list, float_block, float_block_index):
5387 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5388 (cons_free_list, last_marked_index):
5389 Now static.
5390 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5391 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5392 (mark_backtrace): Define only if BYTE_MARK_STACK.
5393 * xdisp.c (message_enable_multibyte): Now static.
5394
61c2b50e 5395 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5396 This makes it easier for human readers (and static analyzers)
5397 to see whether these variables are used from other modules.
5398 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5399 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5400 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5401 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5402 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5403 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5404 * xmenu.c, xselect.c:
5405 Declare Q* vars static if they are not used in other modules.
5406 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5407 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5408 Remove decls of unexported vars.
5409 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5410
95c82688
PE
5411 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5412
16a97296
PE
5413 Make Emacs functions such as Fatom 'static' by default.
5414 This makes it easier for human readers (and static analyzers)
5415 to see whether these functions can be called from other modules.
5416 DEFUN now defines a static function. To make the function external
5417 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5418 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5419 (Finit_image_library):
16a97296
PE
5420 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5421 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5422 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5423 Remove decls, since these functions are now static.
5424 (Funintern, Fget_internal_run_time): New decls, since these functions
5425 were already external.
95c82688 5426
16a97296
PE
5427 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5428 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5429 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5430 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5431 * keyboard.c, keymap.c, lread.c:
5432 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5433 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5434 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5435 Mark functions with DEFUE instead of DEFUN,
5436 if they are used in other modules.
5437 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5438 decls for now-static functions.
5439 * buffer.h (Fdelete_overlay): Remove decl.
5440 * callproc.c (Fgetenv_internal): Mark as internal.
5441 * composite.c (Fremove_list_of_text_properties): Remove decl.
5442 (Fcomposition_get_gstring): New forward static decl.
5443 * composite.h (Fcomposite_get_gstring): Remove decl.
5444 * dired.c (Ffile_attributes): New forward static decl.
5445 * doc.c (Fdocumntation_property): New forward static decl.
5446 * eval.c (Ffetch_bytecode): New forward static decl.
5447 (Funintern): Remove extern decl; now in .h file where it belongs.
5448 * fileio.c (Fmake_symbolic_link): New forward static decl.
5449 * image.c (Finit_image_library): New forward static decl.
5450 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5451 * intervals.h (Fprevious_property_change):
5452 (Fremove_list_of_text_properties): Remove decls.
5453 * keyboard.c (Fthis_command_keys): Remove decl.
5454 (Fcommand_execute): New forward static decl.
5455 * keymap.c (Flookup_key): New forward static decl.
5456 (Fcopy_keymap): Now static.
5457 * keymap.h (Flookup_key): Remove decl.
5458 * process.c (Fget_process): New forward static decl.
5459 (Fprocess_datagram_address): Mark as internal.
5460 * syntax.c (Fsyntax_table_p): New forward static decl.
5461 (skip_chars): Remove duplicate decl.
5462 * textprop.c (Fprevious_property_change): New forward static decl.
5463 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5464 Now internal.
5465 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5466 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5467
785bbd42
PE
5468 * editfns.c (Fformat): Remove unreachable code.
5469
8b913b57
AS
54702011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5471
5472 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5473 change. (Bug#8496)
5474
a6744a35
EZ
54752011-04-13 Eli Zaretskii <eliz@gnu.org>
5476
5477 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5478 when at ZV. (Bug#8487)
5479
e7974947
AS
54802011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5481
baad03f0
AS
5482 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5483 (Bug#8437)
5484 * keyboard.c (parse_tool_bar_item): Likewise.
5485 * sound.c (sound_cleanup, alsa_close): Likewise.
5486 * termcap.c (tgetent): Likewise.
5487 * xfns.c (x_default_font_parameter): Likewise.
5488 * xsettings.c (read_and_apply_settings): Likewise.
5489
e7974947
AS
5490 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5491 (overrun_check_free): Protoize.
5492
28272684
PE
54932011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5494
5495 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5496 since callers should never pass a negative size.
5497 Change the signature to match that of plain 'read' and 'write'; see
5498 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5499 * lisp.h: Update prototypes of emacs_write and emacs_read.
5500
11997c76
EZ
55012011-04-11 Eli Zaretskii <eliz@gnu.org>
5502
5503 * xdisp.c (redisplay_window): Don't try to determine the character
5504 position of the scroll margin if the window start point w->startp
e896f03c 5505 is outside the buffer's accessible region. (Bug#8468)
11997c76 5506
8a2cbd72
EZ
55072011-04-10 Eli Zaretskii <eliz@gnu.org>
5508
5509 Fix write-region and its subroutines for buffers > 2GB.
5510 * fileio.c (a_write, e_write): Modify declaration of arguments and
5511 local variables to support buffers larger than 2GB.
5512 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5513
5514 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5515 argument, local variables, and return value.
5516
5517 * lisp.h: Update prototypes of emacs_write and emacs_read.
5518
5519 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5520
4073e537 55212011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 5522
1ebfdcb6
PE
5523 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5524
b2ded58d
PE
5525 Fix more problems found by GCC 4.6.0's static checks.
5526
7d66342c
PE
5527 * xdisp.c (vmessage): Use a better test for character truncation.
5528
bbf47d44
PE
5529 * charset.c (load_charset_map): <, not <=, for optimization,
5530 and to avoid potential problems with integer overflow.
9248994d 5531 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 5532 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 5533 * editfns.c (Fformat): Likewise.
1e69125e 5534 * syntax.c (skip_chars): Likewise.
3befa583 5535
e3019616
PE
5536 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5537 This also lets GCC 4.6.0 generate slightly better loop code.
5538
becfa255
PE
5539 * callint.c (Fcall_interactively): <, not <=, for optimization.
5540 (Fcall_interactively): Count the number of arguments produced,
5541 not the number of arguments given. This is simpler and lets GCC
5542 4.6.0 generate slightly better code.
5543
dae0cd48
PE
5544 * ftfont.c: Distingish more carefully between FcChar8 and char.
5545 The previous code passed unsigned char * to a functions like
5546 strlen and xstrcasecmp that expect char *, which does not
5547 conform to the C standard.
5548 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5549 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5550 char * when the C standard requires it.
5551
76032d70
PE
5552 * keyboard.c (read_char): Remove unused var.
5553
eb3f1cc8
PE
5554 * eval.c: Port to Windows vsnprintf (Bug#8435).
5555 Include <limits.h>.
5556 (SIZE_MAX): Define if the headers do not.
5557 (verror): Do not give up if vsnprintf returns a negative count.
5558 Instead, grow the buffer. This ports to Windows vsnprintf, which
5559 does not conform to C99. Problem reported by Eli Zaretskii.
5560 Also, simplify the allocation scheme, by avoiding the need for
5561 calling realloc, and removing the ALLOCATED variable.
5562
70476b54
PE
5563 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5564
12020a9e
PE
5565 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5566 But keep the doprint source code for now, as we might revamp it
5567 and use it again (Bug#8435).
ea6c7ae6
PE
5568 * lisp.h (doprnt): Remove.
5569 * Makefile.in (base_obj): Remove doprnt.o.
5570 * deps.mk (doprnt.o): Remove.
5571
5fdb398c
PE
5572 error: Print 32- and 64-bit integers portably (Bug#8435).
5573 Without this change, on typical 64-bit hosts error ("...%d...", N)
5574 was used to print both 32- and 64-bit integers N, which relied on
5575 undefined behavior.
5576 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5577 New macro.
5578 * lisp.h (error, verror): Mark as printf-like functions.
5579 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5580 Report overflow in size calculations when allocating printf buffer.
5581 Do not truncate output string at its first null byte.
5582 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5583 Truncate the output at a character boundary, since vsnprintf does not
5584 do that.
5585 * charset.c (check_iso_charset_parameter): Convert internal
5586 character to string before calling 'error', since %c now has the
5587 printf meaning.
5588 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5589 overflow when computing char to be passed to 'error'. Do not
5590 pass Lisp_Object to 'error'; pass the integer instead.
5591 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5592 formatted with plain %d.
5593
b189fa66
PE
5594 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5595
bff87ef0
PE
5596 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5597
7e2cac20
PE
5598 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5599
ce4d90b5
PE
5600 * xterm.c (x_catch_errors): Remove duplicate declaration.
5601
266c9547
PE
5602 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5603
79c49ad2
PE
5604 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5605
368f4090
JM
56062011-04-10 Jim Meyering <meyering@redhat.com>
5607
5608 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5609 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5610 return ssize_t not "int", and use size_t as the buffer length.
5611 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5612 * gnutls.h: Update declarations.
5613 * process.c (read_process_output): Use ssize_t, to match.
5614 (send_process): Likewise.
5615
a32d4040
CY
56162011-04-09 Chong Yidong <cyd@stupidchicken.com>
5617
5618 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5619
8546720e 56202011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 5621
04f2d78b
CB
5622 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5623 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 5624
8546720e
GM
5625 * xterm.c (handle_one_xevent):
5626 * xmenu.c (create_and_show_popup_menu):
5627 * xselect.c (x_decline_selection_request)
5628 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5629
0a2f5c1a 56302011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
5631
5632 Fix some uses of `int' instead of EMACS_INT.
5633 * search.c (string_match_1, fast_string_match)
5634 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5635 (scan_buffer, find_next_newline_no_quit)
5636 (find_before_next_newline, search_command, Freplace_match)
5637 (Fmatch_data): Make some `int' variables be EMACS_INT.
5638
5639 * xdisp.c (display_count_lines): 3rd argument and return value now
5640 EMACS_INT. All callers changed.
5641 (pint2hrstr): Last argument is now EMACS_INT.
5642
5643 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5644 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5645 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5646 (decode_coding_utf_16, decode_coding_emacs_mule)
5647 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5648 (decode_coding_ccl, decode_coding_charset)
5649 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5650 (decode_coding_iso_2022, decode_coding_emacs_mule)
5651 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5652 <char_offset, last_offset>: Declare EMACS_INT.
5653 (encode_coding_utf_8, encode_coding_utf_16)
5654 (encode_coding_emacs_mule, encode_invocation_designation)
5655 (encode_designation_at_bol, encode_coding_iso_2022)
5656 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5657 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5658 Declare EMACS_INT.
5659 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5660 (encode_invocation_designation): Last argument P_NCHARS is now
5661 EMACS_INT.
5662 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5663 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5664
5665 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5666 All users changed.
5667
5668 * ccl.c (Fccl_execute_on_string): Declare some variables
5669 EMACS_INT.
5670
8546720e 56712011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
5672
5673 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5674
4e19a977
CS
56752011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5676
5677 * process.c (Fformat_network_address): Doc fix.
5678
87302331
R
56792011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5680
5681 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5682
cbb59342
CY
56832011-04-08 Chong Yidong <cyd@stupidchicken.com>
5684
5685 * keyboard.c (read_char): Call Lisp function help-form-show,
5686 instead of using internal_with_output_to_temp_buffer.
5687 (Qhelp_form_show): New var.
e0d38eeb 5688 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
5689
5690 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5691
5692 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5693
e67a13ab
CY
56942011-04-06 Chong Yidong <cyd@stupidchicken.com>
5695
04f2d78b
CB
5696 * process.c (Flist_processes): Remove to Lisp.
5697 (list_processes_1): Delete.
e67a13ab 5698
973f782d
EZ
56992011-04-06 Eli Zaretskii <eliz@gnu.org>
5700
7c106b1e
EZ
5701 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5702
973f782d
EZ
5703 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5704
41cf7d1a 57052011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 5706
ca23cc88
PE
5707 Fix more problems found by GCC 4.6.0's static checks.
5708
f390e2d5
PE
5709 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5710
42eea0d0
PE
5711 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5712
b69769da 5713 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 5714
f9541e84
PE
5715 * xdisp.c (vmessage): Mark as a printf-like function.
5716
13841b55
PE
5717 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5718
c136c10f
PE
5719 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5720
5e2d4a30
PE
5721 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5722 printf-like functions.
5723 (tiff_load): Add casts to remove these marks before passing them
5724 to system-supplied API.
5725
583f48b9
PE
5726 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5727
b25d760e
PE
5728 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5729 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
5730 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5731 directly, rather than having caller test rule sign. This avoids
5732 some unnecessary tests.
5733 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5734 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5735 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 5736
bc7b6697 5737 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 5738 (xfont_open): Avoid unnecessary tests.
bc7b6697 5739
27ccc379
PE
5740 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5741
dcd5c89a
PE
5742 * composite.h, composite.c (composition_gstring_put_cache):
5743 Use EMACS_INT, not int, for length.
5744
b13a45c6
PE
5745 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5746 breaking out part of COMPOSITION_DECODE_RULE.
5747 (COMPOSITION_DECODE_RULE): Use it.
5748 * composite.c (get_composition_id): Remove unused local vars,
5749 by using the new macro.
5750
1e792e4d
PE
5751 * textprop.c (set_text_properties_1): Change while to do-while,
5752 since the condition is always true at first.
5753
dc6c6455 5754 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
5755 (interval_deletion_adjustment): Return unsigned value.
5756 All uses changed.
dc6c6455 5757
aba7731a
PE
5758 * process.c (list_processes_1, create_pty, read_process_output):
5759 (exec_sentinel): Remove vars that were set but not used.
afd4052b 5760 (create_pty): Remove unnecessary "volatile"s.
bc57d757 5761 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 5762 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 5763 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 5764
fdfc4bf3
PE
5765 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5766
fca8fe46 5767 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 5768 (update_syntax_table): Use unsigned instead of int.
fca8fe46 5769
06a0259a 5770 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 5771 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 5772 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 5773
e7b9e80f
PE
5774 * print.c (print_error_message): Avoid int overflow.
5775
56201685
PE
5776 * font.c (font_list_entities): Redo for clarity,
5777 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5778
78834453 5779 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 5780 (font_score): Avoid potential overflow in diff calculation.
78834453 5781
0bc0b309 5782 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 5783 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 5784
e610eaca
PE
5785 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5786
b895abce
PE
5787 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5788 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5789 can always succeed if overflow has undefined behavior.
5790
1f1d9321 5791 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 5792 (wordify): Omit three unnecessary tests.
1f1d9321 5793
c59478bc
PE
5794 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5795 All callers changed. This avoids the need for an unused var.
5796
79b73827
PE
5797 * casefiddle.c (casify_region): Remove var that is set but not used.
5798
a4db5dfe
PE
5799 * dired.c (file_name_completion): Remove var that is set but not used.
5800
43aae36e
PE
5801 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5802
2a47c44d 5803 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 5804 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 5805
a37c69bf
PE
5806 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5807 Check for integer overflow on size calculations.
5808
328ab8e7
PE
5809 * buffer.c (Fprevious_overlay_change): Remove var that is set
5810 but not used.
5811
e5a2a5cb
PE
5812 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5813 Remove vars that are set but not used.
8d84a6eb 5814 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 5815 (timer_check_2): Mark vars as initialized.
e5a2a5cb 5816
a60e5f68
PE
5817 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5818
f661cb61 5819 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 5820 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 5821
f0397f5a
PE
5822 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5823 that are set but not used.
5824
8664db06 5825 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 5826 if XCreateBitmapFromData fails (Bug#8410).
8664db06 5827
6abdaa4a
PE
5828 * xselect.c (x_get_local_selection, x_handle_property_notify):
5829 Remove vars that are set but not used.
5830
0ce7538d 5831 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 5832 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 5833
9ae848fc
PE
5834 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5835 Remove var that is set but not used.
0b918413
PE
5836 (scroll_bar_windows_size): Now size_t, not int.
5837 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5838 Check for overflow.
9ae848fc 5839
a5a62657
PE
5840 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5841 (map_tty_color) [!defined MSDOS]: Likewise.
5842
5c5cdd39
PE
5843 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5844
66ebf983
PE
5845 * coding.c: Remove vars that are set but not used.
5846 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5847 All callers changed.
5848 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5849 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5850 (decode_coding_charset): Remove vars that are set but not used.
5851
1be4d761
PE
5852 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5853 that is set but not used.
5854
47553fa8
PE
5855 * print.c (print_object): Remove var that is set but not used.
5856
1f7196bf 5857 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
5858 The gnulib version avoids calling malloc in the usual case,
5859 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5860 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5861 * filelock.c (current_lock_owner): Likewise.
5862 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5863 * sysdep.c: Include allocator.h, careadlinkat.h.
5864 (emacs_no_realloc_allocator): New static constant.
5865 (emacs_readlink): New function.
fdb61804
PE
5866 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5867 ../lib/careadlinkat.h.
d1fdcab7 5868
f84c17c7
SM
58692011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5870
5871 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5872 first non-nil return value).
5873
ef3862ad
JD
58742011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5875
5876 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5877 if not defined (Bug#8403).
5878
376a7006
JB
58792011-04-02 Juanma Barranquero <lekktu@gmail.com>
5880
5881 * xdisp.c (display_count_lines): Remove parameter `start',
5882 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5883 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5884 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5885 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5886 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5887 and thereabouts. All callers changed.
5888 (get_per_char_metric): Remove parameter `f', unused since
5889 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5890
6ca3801d
JM
58912011-04-02 Jim Meyering <meyering@redhat.com>
5892
5893 do not dereference NULL upon failed strdup
5894 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5895 (ns_get_family): Likewise.
5896
d8e2b5ba
JB
58972011-04-02 Juanma Barranquero <lekktu@gmail.com>
5898
5899 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5900
8c74fcbd
JD
59012011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5902
5903 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5904 later (Bug#8403).
5905
7200d79c
SM
59062011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5907
03408648 5908 Add lexical binding.
7200d79c 5909
03408648
SM
5910 * window.c (Ftemp_output_buffer_show): New fun.
5911 (Fsave_window_excursion):
5912 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5913
5914 * lread.c (lisp_file_lexically_bound_p): New function.
5915 (Fload): Bind Qlexical_binding.
5916 (readevalloop): Remove `evalfun' arg.
5917 Bind Qinternal_interpreter_environment.
5918 (Feval_buffer): Bind Qlexical_binding.
5919 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5920 Mark as dynamic.
5921 (syms_of_lread): Declare `lexical-binding'.
5922
5923 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5924
5925 * keyboard.c (eval_dyn): New fun.
5926 (menu_item_eval_property): Use it.
ca105506
SM
5927
5928 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 5929
03408648
SM
5930 * fns.c (concat, mapcar1): Accept byte-code-functions.
5931
5932 * eval.c (Fsetq): Handle lexical vars.
5933 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5934 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5935 (FletX, Flet): Obey lexical binding.
5936 (Fcommandp): Handle closures.
5937 (Feval): New `lexical' arg.
5938 (eval_sub): New function extracted from Feval. Use it almost
5939 everywhere where Feval was used. Look up vars in lexical env.
5940 Handle closures.
5941 (Ffunctionp): Move from subr.el.
5942 (Ffuncall): Handle closures.
5943 (apply_lambda): Remove `eval_flags'.
5944 (funcall_lambda): Handle closures and new byte-code-functions.
5945 (Fspecial_variable_p): New function.
5946 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5947 but without exporting it to Lisp.
23aba0ea 5948
23aba0ea 5949 * doc.c (Fdocumentation, store_function_docstring):
03408648 5950 * data.c (Finteractive_form): Handle closures.
23aba0ea 5951
03408648
SM
5952 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5953 interactive spec.
ba83908c 5954
04f2d78b
CB
5955 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5956 New byte-codes.
03408648
SM
5957 (exec_byte_code): New function extracted from Fbyte_code to handle new
5958 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5959
03408648 5960 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5961
03408648 5962 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5963
e2abce01
JB
59642011-03-31 Juanma Barranquero <lekktu@gmail.com>
5965
5966 * xdisp.c (redisplay_internal): Fix prototype.
5967
63696a73 59682011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5969
63696a73 5970 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5971 (try_scrolling): Use it when setting scroll_limit.
5972 Limit scrolling to 100 screen lines.
63696a73
EZ
5973 (redisplay_window): Even when falling back on "recentering",
5974 position point in the window according to scroll-conservatively,
5975 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5976
5977 (try_scrolling): When point is above the window, allow searching
5978 as far as scroll_max, or one screenful, to compute vertical
5979 distance from PT to the scroll margin position. This prevents
5980 try_scrolling from unnecessarily failing when
5981 scroll-conservatively is set to a value slightly larger than the
5982 window height. Clean up the case of PT below the margin at bottom
5983 of window: scroll_max can no longer be INT_MAX. When aggressive
5984 scrolling is in use, don't let point enter the opposite scroll
5985 margin as result of the scroll.
5986 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
5987 threshold of 100 lines for never-recentering scrolling.
5988
e4cc2dfc
JB
59892011-03-31 Juanma Barranquero <lekktu@gmail.com>
5990
5991 * dispextern.h (move_it_by_lines):
5992 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5993 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5994 (message_log_check_duplicate): Remove parameters `prev_bol' and
5995 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5996 (redisplay_internal): Remove parameter `preserve_echo_area',
5997 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5998
5999 * indent.c (Fvertical_motion):
6000 * window.c (window_scroll_pixel_based, Frecenter):
6001 Don't pass `need_y_p' to `move_it_by_lines'.
6002
1c470562
SM
60032011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6004
44f230aa
SM
6005 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6006 steal a few bits to be more compact.
6007 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6008 Remove unneeded casts.
6009
1c470562
SM
6010 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6011
888adce9
ZK
60122011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6013
6014 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6015 binding" message (bug#7967).
6016
f838ed7b
PE
60172011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6018
77861b95
PE
6019 Fix more problems found by GCC 4.6.0's static checks.
6020
de6dbc14
PE
6021 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6022 Remove unused local var.
6023
f838ed7b
PE
6024 * editfns.c (Fmessage_box): Remove unused local var.
6025
792c7b2b
PE
6026 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6027 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6028 Omit unused local vars.
c499e557 6029 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6030 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6031 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6032 Omit unused local var.
6033
ba0165e1
PE
6034 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6035 Don't assume string length fits in int.
32ad8845 6036 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6037 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6038
3c59b4c9
PE
6039 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6040 instead of alloca (Bug#8344).
6041
a3eed478 6042 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6043 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6044
eb4d412d
PE
6045 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6046
1658b401
PE
6047 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6048 concerns.
6049
6050 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6051
6052 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6053
9a2c6e05
PE
6054 * keyboard.c (syms_of_keyboard): Use the same style as later
6055 in this function when indexing through an array. This also
6056 works around GCC bug 48267.
6057
03d0a109
PE
6058 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6059
44f730c8
PE
6060 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6061
fe75f926
PE
6062 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6063 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6064
ffa8c828
PE
6065 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6066 This avoids undefined behavior on integer overflow, and is a bit
6067 more convenient anyway since it is compared to a size_t variable.
6068
c5101a77
PE
6069 Variadic C functions now count arguments with size_t, not int.
6070 This avoids an unnecessary limitation on 64-bit machines, which
6071 caused (substring ...) to crash on large vectors (Bug#8344).
6072 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6073 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6074 All variadic functions and their callers changed accordingly.
c5101a77
PE
6075 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6076 * data.c (arith_driver, float_arith_driver): Likewise.
6077 * editfns.c (general_insert_function): Likewise.
6078 * eval.c (struct backtrace.nargs, interactive_p)
6079 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6080 (funcall_lambda, mark_backtrace): Likewise.
6081 * fns.c (concat): Likewise.
6082 * frame.c (x_set_frame_parameters): Likewise.
6083 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6084 0 if not found, not -1. All callers changed.
6085
dd3f25f7
PE
6086 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6087 (stack_copy_size): Now size_t, not int.
6088 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6089
461c2ab9
JB
60902011-03-28 Juanma Barranquero <lekktu@gmail.com>
6091
6092 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6093 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6094 All callers changed.
6095
6096 * lisp.h (multibyte_char_to_unibyte):
6097 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6098 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6099 * character.h (CHAR_TO_BYTE8):
6100 * cmds.c (internal_self_insert):
6101 * editfns.c (general_insert_function):
6102 * keymap.c (push_key_description):
6103 * search.c (Freplace_match):
6104 * xdisp.c (message_dolog, set_message_1): All callers changed.
6105
f6d62986
SM
61062011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6107
6108 * keyboard.c (safe_run_hook_funcall): New function.
6109 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6110 don't set the hook to nil, but remove the offending function instead.
6111 (Qcommand_hook_internal): Remove, unused.
6112 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6113 Vcommand_hook_internal.
6114
6115 * eval.c (enum run_hooks_condition): Remove.
6116 (funcall_nil, funcall_not): New functions.
6117 (run_hook_with_args): Call each function through a `funcall' argument.
6118 Remove `cond' argument, now redundant.
6119 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6120 (Frun_hook_with_args_until_failure): Adjust accordingly.
6121 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6122
1db5b1ad
JB
61232011-03-28 Juanma Barranquero <lekktu@gmail.com>
6124
6125 * dispextern.h (string_buffer_position): Remove declaration.
6126
6127 * print.c (strout): Remove parameter `multibyte', unused since
6128 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6129
6130 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6131 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6132 All callers changed.
6133
6134 * w32.c (_wsa_errlist): Use braces for struct initializers.
6135
6136 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6137 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6138 All callers changed.
6139 (string_buffer_position): Likewise. Also, make static (it's never
6140 used outside xdisp.c).
6141 (cursor_row_p): Remove parameter `w', unused since
6142 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6143 (decode_mode_spec): Remove parameter `precision', introduced during
6144 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6145 All callers changed.
6146
5ffb62aa
JD
61472011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6148
6149 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6150
461c2ab9 61512011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6152
6153 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6154 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6155 (ns_update_auto_hide_menu_bar): New functions.
6156 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6157 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6158 ns_constrain_all_frames.
6159 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6160 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6161
5c380ffb
JD
61622011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6163
6164 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6165
9af30bdf
GM
61662011-03-27 Glenn Morris <rgm@gnu.org>
6167
6168 * syssignal.h: Replace RETSIGTYPE with void.
6169 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6170 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6171 Replace SIGTYPE with void everywhere.
6172 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6173 * s/template.h (SIGTYPE): Remove commented out definition.
6174
e2abce01
JB
61752011-03-26 Eli Zaretskii <eliz@gnu.org>
6176
6177 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6178 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6179
f868cd8a
JB
61802011-03-26 Juanma Barranquero <lekktu@gmail.com>
6181
59eb0929
JB
6182 * w32.c (read_unc_volume): Use parameter `henum', instead of
6183 global variable `wget_enum_handle'.
6184
6185 * keymap.c (describe_vector): Remove parameters `indices' and
6186 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6187 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6188
f868cd8a
JB
6189 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6190
6191 * keyboard.c (timer_check): Remove parameter `do_it_now',
6192 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6193 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6194 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6195
6196 * keyboard.c (read_char):
6197 * w32menu.c (w32_menu_display_help):
6198 * xmenu.c (show_help_event, menu_help_callback):
6199 Adjust calls to `show_help_echo'.
6200
6201 * gtkutil.c (xg_maybe_add_timer):
6202 * keyboard.c (readable_events):
6203 * process.c (wait_reading_process_output):
6204 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6205
6206 * insdel.c (adjust_markers_gap_motion):
6207 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6208 (gap_left, gap_right): Don't call it.
6209
2ecf6fdb
CY
62102011-03-25 Chong Yidong <cyd@stupidchicken.com>
6211
6212 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6213 incurred during fontification.
6214
6b1f9ba4
JB
62152011-03-25 Juanma Barranquero <lekktu@gmail.com>
6216
6217 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6218 (DEFVAR_PER_BUFFER): Don't pass it.
6219
6220 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6221 (scrolling_window): Don't pass it.
6222
0f4a96b5
JB
62232011-03-25 Juanma Barranquero <lekktu@gmail.com>
6224
6225 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6226
6227 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6228 and `suffix'.
6229 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6230 of variables specific to SELinux and computation of `encoded_absname'.
6231
6232 * image.c (XPutPixel): Remove unused variable `height'.
6233
6234 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6235
6236 * unexw32.c (get_section_info): Remove unused variable `section'.
6237
6238 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6239 (system_process_attributes): Remove unused variable `sess'.
6240 (sys_read): Remove unused variable `err'.
6241
6242 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6243 (w32_wnd_proc): Remove unused variable `isdead'.
6244 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6245 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6246 (x_create_tip_frame): Remove unused variable `tem'.
6247
6248 * w32inevt.c (w32_console_read_socket):
6249 Remove unused variable `no_events'.
6250
6251 * w32term.c (x_draw_composite_glyph_string_foreground):
6252 Remove unused variable `width'.
6253
1149507c
JB
62542011-03-24 Juanma Barranquero <lekktu@gmail.com>
6255
6256 * w32term.c (x_set_glyph_string_clipping):
6257 Don't pass uninitialized region to CombineRgn.
6258
9c88f339
JB
62592011-03-23 Juanma Barranquero <lekktu@gmail.com>
6260
6261 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6262 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6263 (Fx_close_connection): Remove unused variable `i'.
6264
6265 * w32font.c (w32font_draw): Return number of glyphs.
6266 (w32font_open_internal): Remove unused variable `i'.
6267 (w32font_driver): Add missing initializer.
6268
6269 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6270 (fill_in_menu): Remove unused variable `items_added'.
6271
6272 * w32term.c (last_mouse_press_frame): Remove static global variable.
6273 (w32_clip_to_row): Remove unused variable `f'.
6274 (x_delete_terminal): Remove unused variable `i'.
6275
6276 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6277 (NOTHING): Remove unused static global variable.
6278 (uniscribe_check_otf): Remove unused variable `table'.
6279 (uniscribe_font_driver): Add missing initializers.
6280
dee091a3
JD
62812011-03-23 Julien Danjou <julien@danjou.info>
6282
6283 * term.c (Fsuspend_tty, Fresume_tty):
6284 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6285 * window.c (temp_output_buffer_show):
6286 * insdel.c (signal_before_change):
6287 * frame.c (Fhandle_switch_frame):
6288 * fileio.c (Fdo_auto_save):
6289 * emacs.c (Fkill_emacs):
6290 * editfns.c (save_excursion_restore):
6291 * cmds.c (internal_self_insert):
6292 * callint.c (Fcall_interactively):
6293 * buffer.c (Fkill_all_local_variables):
6294 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6295 Use Frun_hooks.
0f4a96b5 6296 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6297 unconditionnaly since it does the check itself.
6298
2c520ab5 62992011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6300
c9c49752
PE
6301 Fix more problems found by GCC 4.5.2's static checks.
6302
8abc3f12
PE
6303 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6304 the first time through the loop, since we know p0 < p1 then.
6305 This also avoids a gcc -Wstrict-overflow warning.
6306
a2d26660
PE
6307 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6308 leading to a memory leak, possible in functions like
6309 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6310 of objects (Bug#8318).
a2d26660 6311
916c72e9
PE
6312 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6313 that could (at least in theory) be that large.
6314
19ab8a18
PE
6315 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6316 This is less likely to overflow, and avoids undefined behavior if
6317 overflow does occur. All callers changed. Use strtoul to scan
6318 for the unsigned long integer.
b7cbbd6f
PE
6319 (pint2hrstr): Simplify and tune code slightly.
6320 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6321
f0641eff
PE
6322 * scroll.c (do_scrolling): Work around GCC bug 48228.
6323 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6324
7f650bb9
PE
6325 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6326 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6327 (validate_x_resource_name): Simplify count usage.
6328 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6329
37dd57d1
PE
6330 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6331 fail (Bug#8306).
81e56e61 6332
699979fc 6333 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6334
401bf9b4
PE
6335 * process.c (Fmake_network_process): Use socklen_t, not int,
6336 where POSIX says socklen_t is required in portable programs.
6337 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6338 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6339 (Fmake_network_process, server_accept_connection):
6340 (wait_reading_process_output, read_process_output):
6341 Likewise.
6342
b93aacde
PE
6343 * process.c: Rename or move locals to avoid shadowing.
6344 (list_processes_1, Fmake_network_process):
6345 (read_process_output_error_handler, exec_sentinel_error_handler):
6346 Rename or move locals.
4dc343ee 6347 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6348 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6349 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6350 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6351 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6352
af8a867c 6353 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6354 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6355 Include tparam.h instead, since it declares them.
af8a867c
PE
6356 * cm.h (PC): Remove extern decl; tparam.h now does this.
6357 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6358 * terminfo.c: Include tparam.h, to check interfaces.
6359 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6360 (tparam): Adjust signature to match interface in tparam.h;
6361 this removes some undefined behavior. Check that outstring and len
6362 are zero, which they always are with Emacs.
6363 * tparam.h (PC, BC, UP): New extern decls.
6364
0248044d 6365 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6366 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6367
8ff096c1 6368 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6369 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6370 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6371 (ftfont_list): Remove unused local.
49eaafba
PE
6372 (get_adstyle_property, ftfont_pattern_entity):
6373 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6374 Rename locals to avoid shadowing.
8ff096c1 6375
e2be39f6
PE
6376 * xfont.c (xfont_list_family): Mark var as initialized.
6377
c9735e30
PE
6378 * xml.c (make_dom): Now static.
6379
8f5201ae
PE
6380 * composite.c (composition_compute_stop_pos): Rename local to
6381 avoid shadowing.
b246f932
PE
6382 (composition_reseat_it): Remove unused locals.
6383 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6384 (composition_update_it): Mark var as initialized.
11b61122
PE
6385 (find_automatic_composition): Mark vars as initialized,
6386 with a FIXME (Bug#8290).
8f5201ae 6387
760fbc2c
PE
6388 character.h: Rename locals to avoid shadowing.
6389 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6390 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6391 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6392 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6393 to avoid shadowing.
6394
ff08eb85
PE
6395 * textprop.c (property_change_between_p): Remove; unused.
6396
fc7bf025
PE
6397 * intervals.c (interval_start_pos): Now static.
6398
235d7abc
PE
6399 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6400
44f230aa
SM
6401 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6402 Rename locals to avoid shadowing.
3e7d6594 6403
50060332
PE
6404 * sound.c (wav_play, au_play, Fplay_sound_internal):
6405 Fix pointer signedness.
d01f234b 6406 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6407 (wav_play): Initialize a variable to 0, to prevent undefined
6408 behavior (Bug#8278).
50060332 6409
c4fc4e30
PE
6410 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6411
918436ed
PE
6412 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6413
c939f91b
PE
6414 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6415 clobbering (Bug#8298).
b9c7f648
PE
6416 * sysdep.c (sys_subshell): Likewise.
6417 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6418
6bd8c144
PE
6419 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6420 This should get cleaned up, so that child_setup has the
6421 same signature on all platforms.
6422
7710357c 6423 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6424 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6425
c59da222
CY
64262011-03-22 Chong Yidong <cyd@stupidchicken.com>
6427
6428 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6429 not to be necessary, and produces flickering.
6430
66b87493
GM
64312011-03-20 Glenn Morris <rgm@gnu.org>
6432
6433 * config.in: Remove file.
6434
45b6f6d5
JB
64352011-03-20 Juanma Barranquero <lekktu@gmail.com>
6436
6437 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6438 are now in src/globals.h.
6439 (syms_of_minibuf): Remove spurious & from previous change.
6440
3ec03f7e
LL
64412011-03-20 Leo <sdl.web@gmail.com>
6442
6443 * minibuf.c (completing-read-function): New variable.
6444 (completing-read-default): Rename from completing-read.
6445 (completing-read): Call completing-read-function.
6446
b14e3e21
CY
64472011-03-19 Juanma Barranquero <lekktu@gmail.com>
6448
6449 * xfaces.c (Fx_load_color_file):
6450 Read color file from absolute filename (bug#8250).
6451
f2b726e6
JB
64522011-03-19 Juanma Barranquero <lekktu@gmail.com>
6453
6454 * makefile.w32-in: Update dependencies.
6455
09f6ff02
EZ
64562011-03-17 Eli Zaretskii <eliz@gnu.org>
6457
6458 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6459
29a6015a
PE
64602011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6461
a3a6c54e
PE
6462 Fix more problems found by GCC 4.5.2's static checks.
6463
b766f867
PE
6464 * process.c (make_serial_process_unwind, send_process_trap):
6465 (sigchld_handler): Now static.
6466
be02381c
PE
6467 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6468 That way, the code declares only the vars that it needs.
6469 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6470 * s/cygwin.h (PTY_ITERATION): Likewise.
6471 * s/darwin.h (PTY_ITERATION): Likewise.
6472 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6473
57048744
PE
6474 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6475 * process.c (allocate_pty): Don't declare stb unless it's needed.
6476
7914961c 6477 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
6478 (CONSTANTLIM): Remove; unused.
6479 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6480 Define only if needed.
7914961c 6481
b3967b18
PE
6482 * unexelf.c (unexec): Name an expression,
6483 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
6484 Use a different way to cause a compilation error if anyone uses
6485 n rather than nn, a way that does not involve shadowing.
73366a00 6486 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 6487
29a6015a
PE
6488 * deps.mk (unexalpha.o): Remove; unused.
6489
43cfc33e 6490 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 6491 * unexec.h: New file.
ce701a33
PE
6492 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6493 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6494 Depend on unexec.h.
6495 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6496 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6497 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 6498 Change as necessary to match prototype in unexec.h.
ce701a33 6499
01f44d5a
PE
6500 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6501 shadowing.
4f63c6bb 6502 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 6503
a6670b0b
PE
6504 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6505 Rename locals to avoid shadowing.
6506
cef2010d 6507 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 6508 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 6509
d4d7173a
PE
6510 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6511
f08b802a
PE
6512 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6513 warning when compiling print.c.
6514
3ddb0639
PE
6515 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6516 instead of using an uninitialized var.
5ad03b97 6517 (font_sort_entities): Mark var as initialized.
3ddb0639 6518
170a2692
PE
6519 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6520
e663c700
PE
6521 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6522 pointers to constants.
89bc529a 6523 (font_parse_fcname): Remove unused vars.
7b81e2d0 6524 (font_delete_unmatched): Now static.
ea838e10 6525 (font_get_spec): Remove; unused.
13a547c6
PE
6526 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6527 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6528 Rename or move locals to avoid shadowing.
e663c700 6529
2a80c887 6530 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 6531 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 6532
1384fa33 6533 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 6534 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 6535
8b2c52e9
PE
6536 * alloc.c (mark_backtrace): Move decl from here ...
6537 * lisp.h: ... to here, so that it can be checked.
6538
475545b5 6539 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 6540 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
6541 (lisp_indirect_variable): Name an expression,
6542 to avoid gcc -Wbad-function-cast warning.
1faed8ae 6543 (Fdefvar): Rename locals to avoid shadowing.
475545b5 6544
b1349114 6545 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 6546 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 6547 Use const pointer when appropriate.
b1349114 6548
a2928364
PE
6549 * lisp.h (get_system_name, get_operating_system_release):
6550 Move decls here, to check interfaces.
6551 * process.c (get_operating_system_release): Move decl to lisp.h.
6552 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
6553 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6554 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6555 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
6556 (Fformat_time_string, Fencode_time, Finsert_char):
6557 (Ftranslate_region_internal, Fformat):
6558 Rename or remove local vars to avoid shadowing.
9710023e 6559 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 6560
a415e694
PE
6561 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6562 avoid shadowing.
6563
8ef4622d
PE
6564 * lisp.h (eassert): Check that the argument compiles, even if
6565 ENABLE_CHECKING is not defined.
6566
946f9a5b
PE
6567 * data.c (Findirect_variable): Name an expression, to avoid
6568 gcc -Wbad-function-cast warning.
112396d6 6569 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6570 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6571 (Fmake_variable_buffer_local, Fmake_local_variable):
6572 Mark variables as initialized.
52746918 6573 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 6574
e5aab7e7 6575 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
6576 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6577 Rename locals to avoid shadowing.
dff45157
PE
6578 (mark_stack): Move local variables into the #ifdef region where
6579 they're used.
7bc26fdb
PE
6580 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6581 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6582 needed otherwise.
6583 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6584 (GC_STRING_CHARS): Remove; not used.
d40d4be1 6585 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 6586
e5aab7e7
PE
6587 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6588 avoids undefined behavior in theory.
6589
4da60324
PE
6590 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6591
88043301
PE
6592 Use functions, not macros, for up- and down-casing (Bug#8254).
6593 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6594 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6595 to use the following functions instead of these macros.
6596 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6597 EMACS_INT, since callers assume the returned value fits in int.
6598 (upcase1): Likewise, for UPCASE_TABLE.
6599 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 6600 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 6601 the race-condition problem in the old DOWNCASE.
88043301 6602
19ed5445
PE
6603 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6604 Rename locals to avoid shadowing.
6605 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6606 (regex_compile, re_search_2, re_match_2_internal):
6607 Remove unused local vars.
952db0d7
PE
6608 (FREE_VAR): Rewrite so as not to use empty "else",
6609 which gcc can warn about.
da053e48 6610 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6611 (RETALLOC_IF): Define only if needed.
6612 (WORDCHAR_P): Likewise. This one is never needed, but is used
6613 only in a comment talking about a compiler bug, so put inside
6614 the #if 0 of that comment.
6615 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6616 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6617 Remove; unused.
19ed5445 6618
1f3561e4 6619 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
6620 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6621 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 6622
ded6f8f7
PE
6623 * search.c (simple_search): Remove unused var.
6624
dbd37a95
PE
6625 * dired.c (compile_pattern): Move decl from here ...
6626 * lisp.h: ... to here, so that it can be checked.
6627 (struct re_registers): New forward decl.
6628
7e47afad
PE
6629 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6630
85f24f61
PE
6631 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6632 All uses changed.
6633 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6634 Rename locals to avoid shadowing.
5671df8f 6635 (Fvertical_motion): Mark locals as initialized.
85f24f61 6636
181aa2be 6637 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 6638 (casify_region): Mark local as initialized.
181aa2be 6639
930d429c
PE
6640 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6641
7082eac6
PE
6642 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6643 New macros, so that the caller can use some names other than
6644 gcpro1, gcpro2, etc.
6645 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6646 of the new macros.
6647 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6648 argument, for consistency with GCPRO2_VAR, etc: it is now the
6649 prefix of the variable, not the variable itself. All uses
6650 changed.
38b2c076
PE
6651 * dired.c (directory_files_internal, file_name_completion):
6652 Rename locals to avoid shadowing.
6653
15206ed9
PE
6654 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6655 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6656 dired.c's scmp function, had undefined behavior.
6657 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6658 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6659 * buffer.h: ... to here, because these macros use current_buffer,
6660 and the new implementation with inline functions needs to have
6661 current_buffer in scope now, rather than later when the macros
6662 are used.
6663 (downcase, upcase1): New static inline functions.
6664 (DOWNCASE, UPCASE1): Reimplement using these functions.
6665 This avoids undefined behavior in expressions like
6666 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6667 from race conditions in accessing the global variables
6668 case_temp1 and case_temp2.
6669 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6670 * lisp.h (case_temp1, case_temp2): Remove their decls.
6671 * character.h (ASCII_CHAR_P): Move from here ...
6672 * lisp.h: ... to here, so that the inline functions mentioned
6673 above can use them.
6674
4a6bea26
PE
6675 * dired.c (directory_files_internal_unwind): Now static.
6676
f14b7e14
PE
6677 * fileio.c (file_name_as_directory, directory_file_name):
6678 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6679 Now static.
2893f146
PE
6680 (file_name_as_directory): Use const pointers when appropriate.
6681 (Fexpand_file_name): Likewise. In particular, newdir might
6682 point at constant storage, so make it a const pointer.
fd4ead52 6683 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
6684 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6685 signedness issues.
f839df0c
PE
6686 (Fset_file_times, Finsert_file_contents, auto_save_error):
6687 Rename locals to avoid shadowing.
f14b7e14 6688
5716756e 6689 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
6690 (Ftry_completion, Fall_completions): Rename or remove locals
6691 to avoid shadowing.
5716756e 6692
b4c3046a
PE
6693 * marker.c (bytepos_to_charpos): Remove; unused.
6694
b45db522
PE
6695 * lisp.h (verify_bytepos, count_markers): New decls,
6696 so that gcc does not warn that these functions aren't declared.
6697
85876d07
PE
6698 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6699 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 6700 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 6701 (copy_text): Remove unused local var.
85876d07 6702
03d78a21 6703 * filelock.c (within_one_second): Now static.
b3dd38ab 6704 (lock_file_1): Rename local to avoid shadowing.
03d78a21 6705
5df8f01b
PE
6706 * buffer.c (fix_overlays_before): Mark locals as initialized.
6707 (fix_start_end_in_overlays): Likewise. This function should be
6708 simplified by using pointers-to-pointers, but that's a different
6709 matter.
b1d876f1 6710 (switch_to_buffer_1): Now static.
8f54f30a
PE
6711 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6712 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 6713
a70072c9 6714 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 6715 Fix pointer signedness issue.
edced198
PE
6716 (sys_subshell): Mark local as volatile if checking for lint,
6717 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 6718 (MAXPATHLEN): Define only if needed.
a70072c9 6719
a0977c44
PE
6720 * process.c (serial_open, serial_configure): Move decls from here ...
6721 * systty.h: ... to here, so that they can be checked.
6722
a884fdcc
PE
6723 * fns.c (get_random, seed_random): Move extern decls from here ...
6724 * lisp.h: ... to here, so that they can be checked.
6725
604efe86 6726 * sysdep.c (reset_io): Now static.
b8950c94 6727 (wait_for_termination_signal): Remove; unused.
604efe86 6728
38fc62d9
PE
6729 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6730 (copy_keymap_item, append_key, push_text_char_description):
6731 Now static.
1004a21a 6732 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 6733 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
6734 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6735 (describe_map_tree):
6736 Rename locals to avoid shadowing.
38fc62d9 6737
2f2650da
PE
6738 * keyboard.c: Declare functions static if they are not used elsewhere.
6739 (echo_char, echo_dash, cmd_error, top_level_2):
6740 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
6741 (read_char, kbd_buffer_get_event, make_lispy_position):
6742 (make_lispy_event, make_lispy_movement, apply_modifiers):
6743 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6744 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6745 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 6746 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 6747 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 6748
a053e86c 6749 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
6750 (mark_kboards): Move decl here ...
6751 * alloc.c (mark_kboards): ... from here.
a053e86c 6752
4752793e
PE
6753 * lisp.h (force_auto_save_soon): New decl.
6754
74f10ca7 6755 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
6756 (DEFINE_DUMMY_FUNCTION): New macro.
6757 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6758 Use it.
c03cd23f
PE
6759 (main): Add casts to avoid warnings
6760 if GCC considers string literals to be constants.
74f10ca7 6761
022e70d4
PE
6762 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6763
59d6fe83
PE
6764 * dbusbind.c: Pointer signedness fixes.
6765 (xd_signature, xd_append_arg, xd_initialize):
6766 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6767 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6768 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6769 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6770
78320123
PE
6771 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6772 if GCC considers string literals to be constants.
49cebcca 6773 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 6774
35ac2a97
SM
67752011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6776
fb103ca9
SM
6777 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6778 (print_preprocess, print_object): New macro to fix last change.
6779
35ac2a97
SM
6780 * print.c (print_preprocess): Don't forget font objects.
6781
62973b41
JB
67822011-03-16 Juanma Barranquero <lekktu@gmail.com>
6783
6784 * emacs.c (USAGE3): Doc fixes.
6785
0e48bb22
AS
67862011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6787
6788 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6789 structure.
6790
7684e57b
JB
67912011-03-14 Juanma Barranquero <lekktu@gmail.com>
6792
6793 * lisp.h (VWindow_system, Qfile_name_history):
6794 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6795 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6796 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6797
6798 * w32select.c: Don't #include "keyboard.h".
c96bbc66 6799 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
6800
6801 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6802 * w32console.c (detect_input_pending, read_input_pending)
6803 (encode_terminal_code):
6804 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6805 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6806 (w32_system_caret_y, Qfile_name_history):
6807 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6808 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6809 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6810 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6811 * w32proc.c (Qlocal, report_file_error):
6812 * w32term.c (Vwindow_system, updating_frame):
6813 * w32uniscribe.c (initialized, uniscribe_font_driver):
6814 Remove unneeded extern declarations.
6815
2aa46d6c
CY
68162011-03-14 Chong Yidong <cyd@stupidchicken.com>
6817
c96bbc66 6818 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 6819
cffc6f3b
CY
68202011-03-13 Chong Yidong <cyd@stupidchicken.com>
6821
6822 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6823 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6824 These macros can no longer be used for assignment.
6825
44f230aa
SM
6826 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6827 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
6828 (record_buffer_markers, fetch_buffer_markers): New functions for
6829 recording and fetching special buffer markers.
6830 (set_buffer_internal_1, set_buffer_temp): Use them.
6831
6832 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6833
6834 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6835
6836 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6837 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6838
6839 * xdisp.c (hscroll_window_tree):
6840 (reconsider_clip_changes): Use PT instead of BUF_PT.
6841
d251f04b
EZ
68422011-03-13 Eli Zaretskii <eliz@gnu.org>
6843
6844 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6845 $(EMACS_ROOT)/lib/intprops.h.
6846
f0c77cd1
PE
68472011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6848
3eca4629
PE
6849 Fix more problems found by GCC 4.5.2's static checks.
6850
7c86ee98
PE
6851 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6852 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
6853 (xg_free_frame_widgets): Make it clear that a local variable is
6854 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
6855 (gdk_window_get_screen): Make it clear that this macro is needed
6856 only if USE_GTK_TOOLTIP.
1e5524e7
PE
6857 (int_gtk_range_get_value): New function, which avoids a diagnostic
6858 from gcc -Wbad-function-cast.
6859 (xg_set_toolkit_scroll_bar_thumb): Use it.
6860 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6861 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
6862 (get_utf8_string, xg_get_file_with_chooser):
6863 Rename locals to avoid shadowing.
6864 (create_dialog): Move locals to avoid shadowing.
7c86ee98 6865
41729b81
PE
6866 * xgselect.c (xg_select): Remove unused var.
6867
f0c77cd1
PE
6868 * image.c (four_corners_best): Mark locals as initialized.
6869 (gif_load): Initialize transparent_p to zero (Bug#8238).
6870 Mark another local as initialized.
ec6cf4c6 6871 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 6872
ce0ad53d 6873 * image.c (clear_image_cache): Now static.
d5d5a617 6874 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 6875 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
6876 (x_edge_detection): Remove unnecessary cast that
6877 gcc -Wbad-function-cast diagnoses.
2037898d 6878 (gif_load): Fix pointer signedness.
6ae141d6
PE
6879 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6880 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 6881
33383987 68822011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 6883
d32df629
PE
6884 Improve quality of tests for time stamp overflow.
6885 For example, without this patch (encode-time 0 0 0 1 1
6886 1152921504606846976) returns the obviously-bogus value (-948597
6887 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6888 reports time overflow. See
6889 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
6890 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6891 * editfns.c: Include limits.h and intprops.h.
6892 (TIME_T_MIN, TIME_T_MAX): New macros.
6893 (time_overflow): Move earlier, to before first use.
6894 (hi_time, lo_time): New functions, for an accurate test for
6895 out-of-range times.
6896 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6897 (Fget_internal_run_time): Don't assume time_t fits in int.
6898 (make_time): Use list2 instead of Fcons twice.
6899 (Fdecode_time): More accurate test for out-of-range times.
6900 (check_tm_member): New function.
6901 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
6902 (lisp_time_argument): Don't rely on undefined left-shift and
6903 right-shift behavior when checking for time stamp overflow.
8be6f318 6904
fe31d94c
PE
6905 * editfns.c (time_overflow): New function, refactoring common code.
6906 (Fformat_time_string, Fdecode_time, Fencode_time):
6907 (Fcurrent_time_string): Use it.
6908
8be6f318
PE
6909 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6910 * dired.c (make_time): Move to ...
6911 * editfns.c (make_time): ... here.
6912 * systime.h: Note the move.
6913
09d9db2c 69142011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 6915
126bc0dc
YM
6916 * fringe.c (update_window_fringes): Remove unused variables.
6917
c47cbdfd
YM
6918 * unexmacosx.c (copy_data_segment): Also copy __got section.
6919 (Bug#8223)
6920
7ac80be9
EZ
69212011-03-12 Eli Zaretskii <eliz@gnu.org>
6922
c96bbc66 6923 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
6924 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6925 Constify `char *' arguments and their references according to
6926 prototypes in tparam.h.
6927
ecb0f94d 6928 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 6929
7ac80be9
EZ
6930 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6931 Adapt all references accordingly.
6932
6933 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6934
ef1fd07e
TT
69352011-03-11 Tom Tromey <tromey@redhat.com>
6936
6937 * buffer.c (syms_of_buffer): Remove obsolete comment.
6938
7ef4b50c
EZ
69392011-03-11 Eli Zaretskii <eliz@gnu.org>
6940
6941 * termhooks.h (encode_terminal_code): Declare prototype.
6942
6943 * msdos.c (encode_terminal_code): Don't declare prototype.
6944
6945 * term.c (encode_terminal_code): Now external again, used by
6946 w32console.c and msdos.c.
6947
44f230aa
SM
6948 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6949 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6950
4b1ec863 69512011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 6952
1714f52b 6953 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6954
4b1ec863
PE
6955 * fringe.c (update_window_fringes): Mark locals as initialized
6956 (Bug#8227).
6957 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6958
524c7aa6
PE
6959 * alloc.c (mark_fringe_data): Move decl from here ...
6960 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6961 to check its interface.
6962 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6963
a5c0af81 6964 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6965 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6966 (fontset_font): Mark local as initialized.
a9a06e0b 6967 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6968
b4716021
PE
6969 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6970
811e9bac 6971 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6972 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6973 (x_own_selection, Fx_disown_selection_internal): Rename locals
6974 to avoid shadowing.
6975 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6976
7e3ab302
PE
6977 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6978 so that the caller can use some name other than gcpro1.
6979 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6980 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6981 (Fx_backspace_delete_keys_p):
6982 Use them to avoid shadowing, and rename vars to avoid shadowing.
6983 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6984 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 6985 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
6986 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6987 Remove unused locals.
7e3ab302
PE
6988 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6989 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6990 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6991 macros.
f78faa98 6992
e2b13473
PE
6993 * xterm.h (x_mouse_leave): New decl.
6994
77f23912
PE
6995 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6996 Remove unused functions.
cdf4ba58
PE
6997 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6998 (x_calc_absolute_position): Now static.
7411c686 6999 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7000 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7001 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7002 unless they are used.
38d0b34a
PE
7003 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7004 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7005 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7006 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7007 (x_error_catcher, x_connection_closed, x_error_handler):
7008 (x_error_quitter, xembed_send_message, x_iconify_frame):
7009 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7010 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7011 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7012
44f230aa
SM
7013 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7014 Rename or move locals to avoid shadowing.
6b463e58 7015 (tty_defined_color, merge_face_heights): Now static.
5967d051 7016 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7017 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7018 does not deduce is never used uninitialized.
73719eba
PE
7019 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7020 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7021
426994c3 7022 * terminal.c (store_terminal_param): Now static.
5489860b 7023
032f1620 7024 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7025 (set_frame_menubar): Remove unused local.
d4323972 7026 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7027 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7028 since they might point to immutable storage.
281585b0
PE
7029 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7030 since it's unused otherwise.
032f1620 7031
367c19e5 7032 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7033 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7034 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7035 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7036 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7037 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7038 does not deduce are never used uninitialized.
70739cbe 7039
07b48fa9
PE
7040 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7041
8868a238 7042 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7043 * window.c (window_loop, size_window):
7044 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7045
7e5cf297 7046 * window.c (display_buffer): Now static.
d6550a9f
PE
7047 (size_window): Mark variables that gcc -Wuninitialized
7048 does not deduce are never used uninitialized.
a586633d
PE
7049 * window.h (check_all_windows): New decl, to forestall
7050 gcc -Wmissing-prototypes diagnostic.
5b555da1 7051 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7052
f6095868
PE
7053 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7054 shadowing.
7055 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7056 Include <limits.h>.
7057 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7058 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7059 (load_charset_map): Mark variables that gcc -Wuninitialized
7060 does not deduce are never used uninitialized.
53df7c11 7061 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7062
f38b440c
PE
7063 * coding.c (coding_set_source, coding_set_destination):
7064 Use "else { /* comment */ }" rather than "else /* comment */;"
7065 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7066 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7067 a block, when the outer 'i' will do.
7068 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7069 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7070 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7071 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7072 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7073 Rename locals to avoid shadowing.
7074 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7075 * coding.c (emacs_mule_char, encode_invocation_designation):
7076 Now static, since they're not used elsewhere.
413bb2db 7077 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7078 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7079 (decode_coding_emacs_mule): Mark variables that gcc
7080 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7081 (detect_coding_iso_2022): Initialize a local variable that might
7082 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7083 this initialization is needed. (Bug#8211)
5f58e762
PE
7084 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7085 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7086 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7087 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7088 Remove unused macros.
f38b440c 7089
232b38b9 7090 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7091 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7092 * character.c (string_count_byte8): Likewise.
232b38b9 7093
fb90da1b
PE
7094 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7095 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7096
fb93dbc2
PE
7097 * chartab.c (copy_sub_char_table): Now static, since it's not used
7098 elsewhere.
5c156ace
PE
7099 (sub_char_table_ref_and_range, char_table_ref_and_range):
7100 Rename locals to avoid shadowing.
bbcd0949 7101 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7102
7d3b3862 7103 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7104 (BIDI_BOB): Remove unused macro.
7d3b3862 7105
6be7d3da
PE
7106 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7107 deduce are never used uninitialized.
c2ed9c8b 7108 * term.c (encode_terminal_code): Likewise.
6be7d3da 7109
75f8807f 7110 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7111
50938595
PE
7112 * tparam.h: New file.
7113 * term.c, tparam.h: Include it.
7114 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7115 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7116 Move these decls to tparam.h, and make them agree with what
7117 is actually in tparam.c. The previous trick of using incompatible
7118 decls in different modules does not conform to the C standard.
7119 All callers of tparam changed to use tparam's actual API.
7120 * tparam.c (tparam1, tparam, tgoto):
7121 Use const pointers where appropriate.
7122
fbceeba2
PE
7123 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7124 * cm.h (struct cm): Likewise.
7125 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7126 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7127 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7128 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7129 (turn_on_face, init_tty): Likewise.
7130 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7131
7f3f1250
PE
7132 * term.c (term_mouse_position): Rename local to avoid shadowing.
7133
e6ca6543
PE
7134 * alloc.c (mark_ttys): Move decl from here ...
7135 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7136
c40f8d15
AS
71372011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7138
7139 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7140
cfe0661d
JB
71412011-03-09 Juanma Barranquero <lekktu@gmail.com>
7142
7143 * search.c (compile_pattern_1): Remove argument regp, unused since
7144 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7145 (compile_pattern): Don't pass it.
7146
0afb4571
J
71472011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7148
7149 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7150 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7151 for ! HAVE_GTK3.
7152 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7153
7154 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7155
7156 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7157 gdk_window_get_screen, gdk_window_get_geometry,
7158 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7159 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7160 (xg_get_pixbuf_from_pixmap): New function.
7161 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7162 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7163 Call xg_get_pixbuf_from_pixmap instead of
7164 gdk_pixbuf_get_from_drawable.
7165 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7166 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7167 (xg_check_special_colors): Use GtkStyleContext and its functions
7168 for HAVE_GTK3.
7169 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7170 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7171 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7172 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7173 Call gtk_widget_get_preferred_size.
0afb4571
J
7174 (xg_frame_resized): gdk_window_get_geometry only takes 5
7175 parameters.
44f230aa
SM
7176 (xg_win_to_widget, xg_event_is_for_menubar):
7177 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7178 (xg_set_widget_bg): New function.
7179 (delete_cb): New function.
895009e1 7180 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7181 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7182 (xg_set_background_color): Call xg_set_widget_bg.
7183 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7184 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7185 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7186 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7187 if ! HAVE_GTK3.
7188 (update_frame_tool_bar): Call gtk_widget_hide.
7189 (xg_initialize): Use GDK_KEY_g.
7190
7191 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7192 if ! HAVE_GTK3
7193 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7194
7195 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7196 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7197 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7198
1c2cc4ef
JB
71992011-03-08 Juanma Barranquero <lekktu@gmail.com>
7200
7201 * w32xfns.c (select_palette): Check success of RealizePalette against
7202 GDI_ERROR, not zero.
7203
33383987 7204See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7205
7206;; Local Variables:
7207;; coding: utf-8
aac0c6e3
MR
7208;; End:
7209
33383987 7210 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7211
7212 This file is part of GNU Emacs.
7213
7214 GNU Emacs is free software: you can redistribute it and/or modify
7215 it under the terms of the GNU General Public License as published by
7216 the Free Software Foundation, either version 3 of the License, or
7217 (at your option) any later version.
7218
7219 GNU Emacs is distributed in the hope that it will be useful,
7220 but WITHOUT ANY WARRANTY; without even the implied warranty of
7221 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7222 GNU General Public License for more details.
7223
7224 You should have received a copy of the GNU General Public License
7225 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.