* mh-folder.el (mh-inc-folder, mh-modify, mh-scan-folder)
[bpt/emacs.git] / src / ChangeLog
CommitLineData
1dae0f0a
AS
12011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2
268c2c36 3 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
5 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7 * data.c (fmod): Likewise.
8 * dispnew.c (swap_glyphs_in_rows): Likewise.
9 * emacs.c (memory_warning_signal): Likewise.
10 * floatfns.c (float_error): Likewise.
11 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
12 (otf_open, font_otf_capability, generate_otf_features)
13 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
14 Likewise.
15 * image.c (pbm_read_file): Likewise.
16 * indent.c (string_display_width): Likewise.
17 * intervals.c (check_for_interval, search_for_interval)
18 (inc_interval_count, count_intervals, root_interval)
19 (adjust_intervals_for_insertion, make_new_interval): Likewise.
20 * lread.c (defalias): Likewise.
268c2c36 21 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
22 * regex.c (set_image_of_range_1, set_image_of_range)
23 (regex_grow_registers): Likewise.
24 * sysdep.c (strerror): Likewise.
25 * termcap.c (valid_filename_p, tprint, main): Likewise.
26 * tparam.c (main): Likewise.
27 * unexhp9k800.c (run_time_remap, save_data_space)
28 (update_file_ptrs, read_header, write_header, calculate_checksum)
29 (copy_file, copy_rest, display_header): Likewise.
30 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
31 Likewise.
32 * xdisp.c (check_it): Likewise.
33 * xfaces.c (register_color, unregister_color, unregister_colors):
34 Likewise.
35 * xfns.c (print_fontset_result): Likewise.
36 * xrdb.c (member, fatal, main): Likewise.
37
99033785
PE
382011-07-10 Paul Eggert <eggert@cs.ucla.edu>
39
40 Fix minor problems found by static checking (Bug#9031).
41 * chartab.c (char_table_set_range, map_sub_char_table):
42 Remove unused locals.
43 (uniprop_table): Now static.
44 * composite.c (_work_char): Remove unused static var.
45
9cb2ac56
JB
462011-07-09 Juanma Barranquero <lekktu@gmail.com>
47
48 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
49
f25661f0
JD
502011-07-09 Jan Djärv <jan.h.d@swipnet.se>
51
52 * gtkutil.c (qttip_cb): Remove code without function.
53
8278c4fe
EZ
542011-07-09 Eli Zaretskii <eliz@gnu.org>
55
56 * w32.c (pthread_sigmask): New stub.
57
1692ae2d 582011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 59
8a6ebd58 60 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
61 sigprocmask is portable only for single-threaded applications, and
62 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
63 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
64 (LIBES): Use it.
65 * callproc.c (Fcall_process):
66 * process.c (create_process):
67 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
68 Use pthread_sigmask, not sigprocmask.
123403e4 69
1b854618
JD
702011-07-08 Jan Djärv <jan.h.d@swipnet.se>
71
72 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
73 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
74 wrong (Bug#8591).
75
3fe4b549
JD
762011-07-08 Jan Djärv <jan.h.d@swipnet.se>
77
0ce7e563
JD
78 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
79 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
80 (xg_hide_tooltip): Fix comment.
81
3fe4b549
JD
82 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
83 in registerServicesMenuSendTypes.
84 (validRequestorForSendType): Don't check ns_return_types.
85
86 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
87 ns_return_type.
88
5df75e47
JR
892011-07-08 Jason Rumney <jasonr@gnu.org>
90
91 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
92 frame struct members of non-existent frames (Bug#6284).
93
699c10bd
JD
942011-07-08 Jan Djärv <jan.h.d@swipnet.se>
95
4393663b
JD
96 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
97 variable firstTime not needed on OSX >= 10.6.
98 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
99 >= 10.5. Use setKnobProportion, setDoubleValue.
100
101 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
102 (MAC_OS_X_VERSION_10_5): Define if not defined.
103 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
104 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
105 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
106
107 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
108 cString and lossyCString on OSX >= 10.4
109
110 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
111 sizeToFit on OSX >= 10.2.
112
113 * nsimage.m (allocInitFromFile): Don't use deprecated method
114 bestRepresentationForDevice on OSX >= 10.6.
115
116 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
117 to avoid warning.
118
119 * emacs.c: Declare unexec_init_emacs_zone.
120
a63e0781
JD
121 * nsgui.h: Fix compiler warning about gnulib redefining verify.
122
699c10bd
JD
123 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
124
125 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
126 on svcsMenu (Bug#8842).
127
128 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
129 ns_return_types.
130 (Fns_list_services): Just return Qnil on 10.6, code not working there.
131
132 * nsterm.m (QUTF8_STRING): Declare.
133 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
134 (validRequestorForSendType): Return type is (id).
135 Change indexOfObjectIdenticalTo to indexOfObject.
136 Check if we have local selection before returning self (Bug#8842).
137 (writeSelectionToPasteboard): Put local selection into paste board
138 if we have a local selection (Bug#8842).
139 (syms_of_nsterm): DEFSYM QUTF8_STRING.
140
141 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
142 (ns_get_local_selection): Declare.
143
54e10184
LMI
1442011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
145
9888ff71
LMI
146 * keymap.c (describe_map_tree): Don't insert a double newline at
147 the end of the buffer (bug#1169) and return whether we inserted
148 something.
149
54e10184
LMI
150 * callint.c (Fcall_interactively): Change "reading args" to
151 "providing args" to try to clarify what it does (bug#1010).
152
15fa4783
KH
1532011-07-07 Kenichi Handa <handa@m17n.org>
154
155 * composite.c (composition_compute_stop_pos): Ignore a static
156 composition starting before CHARPOS (Bug#8915).
157
158 * xdisp.c (handle_composition_prop): Likewise.
159
a8815b00
EZ
1602011-07-07 Eli Zaretskii <eliz@gnu.org>
161
162 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
163 (Bug#9015)
164
ef7b981d 1652011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
166
167 * character.h (unicode_category_t): New enum type.
168
169 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
170 (Qchar_code_property_table): New variable.
171 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
172 (UNIPROP_COMPRESSED_FORM_P): New macros.
173 (char_table_ascii): Uncompress the compressed values.
174 (sub_char_table_ref): New arg is_uniprop. Callers changed.
175 Uncompress the compressed values.
176 (sub_char_table_ref_and_range): Likewise.
177 (char_table_ref_and_range): Uncompress the compressed values.
178 (sub_char_table_set): New arg is_uniprop. Callers changed.
179 Uncompress the compressed values.
180 (sub_char_table_set_range): Args changed. Callers changed.
181 (char_table_set_range): Adjuted for the above change.
182 (map_sub_char_table): Delete args default_val and parent. Add arg
183 top. Give decoded values to a Lisp function.
184 (map_char_table): Adjusted for the above change. Give decoded
185 values to a Lisp function. Gcpro more variables.
186 (uniprop_table_uncompress)
187 (uniprop_decode_value_run_length): New functions.
188 (uniprop_decoder, uniprop_decoder_count): New variables.
189 (uniprop_get_decoder, uniprop_encode_value_character)
190 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
191 New functions.
192 (uniprop_encoder, uniprop_encoder_count): New variables.
193 (uniprop_get_encoder, uniprop_table)
194 (Funicode_property_table_internal, Fget_unicode_property_internal)
195 (Fput_unicode_property_internal): New functions.
196 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
197 Sunicode_property_table_internal, Sget_unicode_property_internal,
198 and Sput_unicode_property_internal. Defvar_lisp
199 char-code-property-alist.
200
201 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
202 Vunicode_category_table.
203
204 * font.c (font_range): Adjusted for the change of
205 Vunicode_category_table.
206
76b397fb
DN
2072011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
208
209 * m/iris4d.h: Remove file, move contents ...
210 * s/irix6-5.h: ... here.
211
22b4128e
PE
2122011-07-06 Paul Eggert <eggert@cs.ucla.edu>
213
214 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
215 * alloc.c (mark_buffer):
216 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
217 (clone_per_buffer_values): Don't assume that
22b4128e
PE
218 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
219 This isn't true in general, and it's particularly not true
220 if Emacs is configured with --with-wide-int.
221 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
222 New macros, used in the buffer.c change.
223
869795d6
JD
2242011-07-05 Jan Djärv <jan.h.d@swipnet.se>
225
226 * xsettings.c: Use both GConf and GSettings if both are available.
227 (store_config_changed_event): Add comment.
228 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
229 (store_tool_bar_style_changed): New functions.
230 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
231 (struct xsettings): Move font inside HAVE_XFT.
232 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
233 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
234 Move inside HAVE_XFT.
235 (something_changed_gsettingsCB): Renamed from something_changedCB.
236 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
237 also.
238 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
239 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
240 (something_changed_gconfCB): Renamed from something_changedCB.
241 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
242 (parse_settings): Move check for font inside HAVE_XFT.
243 (read_settings, apply_xft_settings): Add comment.
244 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
245 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
246 call store_font_name_changed.
247 (xft_settings_event): Add comment.
248 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
249 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
250 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
251 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
252 (xsettings_initialize): Call init_gsettings last.
253 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
254 comment.
255
d8ed26bd
PE
2562011-07-05 Paul Eggert <eggert@cs.ucla.edu>
257
258 Random fixes. E.g., (random) never returned negative values.
259 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
260 subseconds part to the entropy, as that's a bit more random.
261 Prefer signed to unsigned, since the signedness doesn't matter and
262 in general we prefer signed. When given a limit, use a
263 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
264 latter isn't right if USE_2_TAGS_FOR_INTS.
265 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
266 not 0..VALMASK. Don't discard "excess" bits that random () returns.
267
cabf1cac
SM
2682011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
269
270 * textprop.c (text_property_stickiness):
271 Obey Vtext_property_default_nonsticky.
272 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
273 * w32fns.c (syms_of_w32fns):
274 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
275
6e9b2be9
PE
2762011-07-04 Paul Eggert <eggert@cs.ucla.edu>
277
278 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
279 This is more efficient than Ffile_directory_p and avoids a minor race.
280
90186c68
LMI
2812011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
282
7c301272
LMI
283 * buffer.c (Foverlay_put): Say what the return value is
284 (bug#7835).
285
c4f2d8d4
LMI
286 * fileio.c (barf_or_query_if_file_exists): Check first if the file
287 is a directory before asking whether to use the file name
288 (bug#7564).
ad637907
LMI
289 (barf_or_query_if_file_exists): Make the "File is a directory"
290 error be more correct.
c4f2d8d4 291
90186c68
LMI
292 * fns.c (Frequire): Remove the mention of the .gz files, since
293 that's installation-specific, but keep the mention of
294 `get-load-suffixes'.
295
da64016e
PE
2962011-07-04 Paul Eggert <eggert@cs.ucla.edu>
297
298 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
299 Report string overflow if the output is too long.
300
7d47b580
JB
3012011-07-04 Juanma Barranquero <lekktu@gmail.com>
302
a555cb87
JB
303 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
304 (syms_of_gnutls): Remove duplicate DEFSYM for
305 Qgnutls_bootprop_verify_hostname_error, an error for
306 Qgnutls_bootprop_verify_error (which is no longer used).
307
7d47b580
JB
308 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
309 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
310 Also (re)move comments that are misplaced or no longer relevant.
311
1e49bfab
LMI
3122011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
313
314 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
315
1485f4c0
CY
3162011-07-03 Chong Yidong <cyd@stupidchicken.com>
317
318 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
319 and background color parameters if they have been changed.
320
a9ab721e
LMI
3212011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
322
323 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
324
cf7cff57
PE
3252011-07-03 Paul Eggert <eggert@cs.ucla.edu>
326
2e13213d
PE
327 * xsettings.c (SYSTEM_FONT): Define only when used.
328 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
329
cf7cff57
PE
330 * keymap.c (access_keymap_1): Now static.
331
7a8e04f7
CY
3322011-07-02 Chong Yidong <cyd@stupidchicken.com>
333
334 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
335 leave any prefix arg for the up event (Bug#1586).
336
61352f62
LMI
3372011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
338
69bb1ef7
LMI
339 * lread.c (syms_of_lread): Mention single symbols defined by
340 `defvar' or `defconst' (bug#7154).
341
61352f62 342 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 343 (Frequire): Mention get-load-suffixes.
61352f62 344
28545e04
MR
3452011-07-02 Martin Rudalics <rudalics@gmx.at>
346
347 * window.h (window): Remove clone_number slot.
348 * window.c (Fwindow_clone_number, Fset_window_clone_number):
349 Remove.
350 (make_parent_window, make_window, saved_window)
351 (Fset_window_configuration, save_window_save): Don't deal with
352 clone numbers.
353 * buffer.c (Qclone_number): Remove declaration.
354 (sort_overlays, overlay_strings): Don't deal with clone numbers.
355
3349e122
SM
3562011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
357
358 Add multiple inheritance to keymaps.
359 * keymap.c (Fmake_composed_keymap): New function.
360 (Fset_keymap_parent): Simplify.
361 (fix_submap_inheritance): Remove.
362 (access_keymap_1): New function extracted from access_keymap to handle
363 embedded parents and handle lists of maps.
364 (access_keymap): Use it.
365 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
366 (Fcopy_keymap): Handle embedded parents.
367 (Fcommand_remapping, define_as_prefix): Simplify.
368 (Fkey_binding): Simplify.
369 (syms_of_keymap): Move minibuffer-local-completion-map,
370 minibuffer-local-filename-completion-map,
371 minibuffer-local-must-match-map, and
372 minibuffer-local-filename-must-match-map to Elisp.
373 (syms_of_keymap): Defsubr make-composed-keymap.
374 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
375 (parse_menu_item): Trivial simplification.
376
3279eb87
GM
3772011-07-01 Glenn Morris <rgm@gnu.org>
378
379 * Makefile.in (SETTINGS_LIBS): Fix typo.
380
4550efdf
KI
3812011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
382
383 * coding.c (Fencode_coding_string): Record the last coding system
384 used, as the function doc string says (bug#8738).
385
0949d2b6
JD
3862011-07-01 Jan Djärv <jan.h.d@swipnet.se>
387
388 * xsettings.c (store_monospaced_changed): Take new font as arg and
389 check for change against current_mono_font.
390 (EMACS_TYPE_SETTINGS): Remove this and related defines.
391 (emacs_settings_constructor, emacs_settings_get_property)
392 (emacs_settings_set_property, emacs_settings_class_init)
393 (emacs_settings_init, gsettings_obj): Remove.
394 (something_changedCB): New function for HAVE_GSETTINGS.
395 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
396 with value as argument.
397 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
398 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 399 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
400 "changed".
401
402 * xgselect.c: Add defined (HAVE_GSETTINGS).
403 (xgselect_initialize): Ditto.
404
405 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
406 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
407 xg_select.
408
bbc6b304
PE
4092011-07-01 Paul Eggert <eggert@cs.ucla.edu>
410
411 * eval.c (struct backtrace): Simplify and port the data structure.
412 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
413 signed bit field, as this assumption is not portable and it makes
414 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
415 "char debug_on_exit : 1" as this is not portable either; instead,
416 use the portable "unsigned int debug_on_exit : 1". Remove unused
417 member evalargs. Remove obsolete comments about cc bombing out.
418
9851bfc5
JD
4192011-06-30 Jan Djärv <jan.h.d@swipnet.se>
420
51bb811f 421 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
422 Let HAVE_GSETTINGS override HAVE_GCONF.
423 (store_monospaced_changed): New function.
424 (EMACS_SETTINGS): A new type derived from GObject to handle
425 GSettings notifications.
426 (emacs_settings_constructor, emacs_settings_get_property)
427 (emacs_settings_set_property, emacs_settings_class_init):
428 New functions.
429 (gsettings_client, gsettings_obj): New variables.
430 (GSETTINGS_SCHEMA): New define.
431 (something_changedCB): Call store_monospaced_changed.
432 (init_gsettings): New function.
433 (xsettings_initialize): Call init_gsettings.
434 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
435 to NULL.
436
437 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
438 GCONF_CFLAGS/LIBS.
439
5386012d
MR
4402011-06-29 Martin Rudalics <rudalics@gmx.at>
441
442 * window.c (resize_root_window, grow_mini_window)
443 (shrink_mini_window): Rename Qresize_root_window to
444 Qwindow_resize_root_window and Qresize_root_window_vertically to
445 Qwindow_resize_root_window_vertically.
446
f13e0b08
PE
4472011-06-28 Paul Eggert <eggert@cs.ucla.edu>
448
449 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
450
94515237
JB
4512011-06-27 Juanma Barranquero <lekktu@gmail.com>
452
453 * makefile.w32-in: Redesign dependencies so they reflect more
454 clearly which files are directly included by each source file,
455 and not through other includes.
456
e43b6e43
MR
4572011-06-27 Martin Rudalics <rudalics@gmx.at>
458
459 * buffer.c (Qclone_number): Declare static and DEFSYM it.
460 (sort_overlays, overlay_strings): When an overlay's clone number
461 matches the window's clone number process the overlay even if
462 the overlay's window property doesn't match the current window.
463
d68443dc
MR
464 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
465 (Fwindow_hchild): Rename to Fwindow_left_child.
466 (Fwindow_next): Rename to Fwindow_next_sibling.
467 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
468 (resize_window_check): Rename to window_resize_check.
469 (resize_window_apply): Rename to window_resize_apply.
470 (Fresize_window_apply): Rename to Fwindow_resize_apply.
471 (Fdelete_other_windows_internal, resize_frame_windows)
472 (Fsplit_window_internal, Fdelete_window_internal)
473 (grow_mini_window, shrink_mini_window)
474 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 475
c7e73be5
JD
4762011-06-26 Jan Djärv <jan.h.d@swipnet.se>
477
478 * emacsgtkfixed.h: State that this is only used with Gtk+3.
479 (emacs_fixed_set_min_size): Remove.
480 (emacs_fixed_new): Take frame as argument.
481
482 * emacsgtkfixed.c: State that this is only used with Gtk+3.
483 (_EmacsFixedPrivate): Remove minwidth/height.
484 Add struct frame *f.
485 (emacs_fixed_init): Initialize priv->f.
486 (get_parent_class, emacs_fixed_set_min_size): Remove.
487 (emacs_fixed_new): Set priv->f to argument.
488 (emacs_fixed_get_preferred_width)
489 (emacs_fixed_get_preferred_height): Use min_width/height from
490 frames size_hint to set minimum and natural (Bug#8919).
491 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
492 and use min_width/height from frames size_hint to set
493 min_width/height (Bug#8919).
494
495 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
496 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
497 Fix indentation.
c7e73be5 498
cf99dcf8
EZ
4992011-06-26 Eli Zaretskii <eliz@gnu.org>
500
501 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
502 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
503 called at ZV.
504
029529ac
CY
5052011-06-26 Chong Yidong <cyd@stupidchicken.com>
506
507 * process.c (wait_reading_process_output): Bypass select if
508 waiting for a cell while ignoring keyboard input, and input is
509 pending. Suggested by Jan Djärv (Bug#8869).
510
7a7ef429
PE
5112011-06-25 Paul Eggert <eggert@cs.ucla.edu>
512
513 Use gnulib's dup2 module instead of rolling our own.
514 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
515
11fdef7d 5162011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
517
518 * dispnew.c (scrolling_window): Before scrolling, turn off a
519 mouse-highlight in the window being scrolled.
520
cd3520a4
JB
5212011-06-24 Juanma Barranquero <lekktu@gmail.com>
522
523 Move DEFSYM to lisp.h and use everywhere.
524
525 * character.h (DEFSYM): Move declaration...
526 * lisp.h (DEFSYM): ...here.
527
528 * gnutls.c:
529 * minibuf.c:
530 * w32menu.c:
531 * w32proc.c:
532 * w32select.c: Don't include character.h.
533
534 * alloc.c (syms_of_alloc):
535 * buffer.c (syms_of_buffer):
536 * bytecode.c (syms_of_bytecode):
537 * callint.c (syms_of_callint):
538 * casefiddle.c (syms_of_casefiddle):
539 * casetab.c (init_casetab_once):
540 * category.c (init_category_once, syms_of_category):
541 * ccl.c (syms_of_ccl):
542 * cmds.c (syms_of_cmds):
543 * composite.c (syms_of_composite):
544 * dbusbind.c (syms_of_dbusbind):
545 * dired.c (syms_of_dired):
546 * dispnew.c (syms_of_display):
547 * doc.c (syms_of_doc):
548 * editfns.c (syms_of_editfns):
549 * emacs.c (syms_of_emacs):
550 * eval.c (syms_of_eval):
551 * fileio.c (syms_of_fileio):
552 * fns.c (syms_of_fns):
553 * frame.c (syms_of_frame):
554 * fringe.c (syms_of_fringe):
555 * insdel.c (syms_of_insdel):
556 * keymap.c (syms_of_keymap):
557 * lread.c (init_obarray, syms_of_lread):
558 * macros.c (syms_of_macros):
559 * msdos.c (syms_of_msdos):
560 * print.c (syms_of_print):
561 * process.c (syms_of_process):
562 * search.c (syms_of_search):
563 * sound.c (syms_of_sound):
564 * syntax.c (init_syntax_once, syms_of_syntax):
565 * terminal.c (syms_of_terminal):
566 * textprop.c (syms_of_textprop):
567 * undo.c (syms_of_undo):
568 * w32.c (globals_of_w32):
569 * window.c (syms_of_window):
570 * xdisp.c (syms_of_xdisp):
571 * xfaces.c (syms_of_xfaces):
572 * xfns.c (syms_of_xfns):
573 * xmenu.c (syms_of_xmenu):
574 * xsettings.c (syms_of_xsettings):
575 * xterm.c (syms_of_xterm): Use DEFSYM.
576
4228cf16
TZ
5772011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
578
cd3520a4 579 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 580
7fcccf1e
PE
5812011-06-23 Paul Eggert <eggert@cs.ucla.edu>
582
7efb4e0e
PE
583 Integer and buffer overflow fixes (Bug#8873).
584
ff5844ad
PE
585 * print.c (printchar, strout): Check for string overflow.
586 (PRINTPREPARE, printchar, strout):
587 Don't set size unless allocation succeeds.
588
90532f02
PE
589 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
590 for sizes. Check for string overflow more accurately.
591 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
592
6d84508d
PE
593 * macros.c: Integer and buffer overflow fixes.
594 * keyboard.h (struct keyboard.kbd_macro_bufsize):
595 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
596 Use ptrdiff_t, not int, for sizes.
597 Don't increment bufsize until after realloc succeeds.
598 Check for size-calculation overflow.
599 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
600
437b2cb4
PE
601 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
602
8b9ac8b4
PE
603 * lread.c: Integer overflow fixes.
604 (read_integer): Radix is now EMACS_INT, not int,
605 to improve quality of diagnostics for out-of-range radices.
606 Calculate buffer size correctly for out-of-range radices.
607 (read1): Check for integer overflow in radices, and in
608 read-circle numbers.
82cb60d3
PE
609 (read_escape): Avoid int overflow.
610 (Fload, openp, read_buffer_size, read1)
611 (substitute_object_recurse, read_vector, read_list, map_obarray):
612 Use ptrdiff_t, not int, for sizes.
613 (read1): Use EMACS_INT, not int, for sizes.
20270765 614 Check for size overflow.
8b9ac8b4 615
7fcccf1e
PE
616 * image.c (cache_image): Check for size arithmetic overflow.
617
bfbbd7e7
PE
618 * lread.c: Integer overflow issues.
619 (saved_doc_string_size, saved_doc_string_length)
620 (prev_saved_doc_string_size, prev_saved_doc_string_length):
621 Now ptrdiff_t, not int.
622 (read1): Don't assume doc string length fits in int. Check for
623 out-of-range doc string lengths.
624 (read_list): Don't assume file position fits in int.
39019e54 625 (read_escape): Check for hex character overflow.
bfbbd7e7 626
4e323265
LL
6272011-06-22 Leo Liu <sdl.web@gmail.com>
628
629 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
630 Move to minibuffer.el.
631
85fece3e
PE
6322011-06-22 Paul Eggert <eggert@cs.ucla.edu>
633
20b84ce9 634 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
635 The following patches are for when GLYPH_DEBUG && !XASSERT.
636 * dispextern.h (trace_redisplay_p, dump_glyph_string):
637 * dispnew.c (flush_stdout):
638 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
639 Mark as externally visible.
640 * dispnew.c (check_window_matrix_pointers): Now static.
641 * dispnew.c (window_to_frame_vpos):
642 * xfns.c (unwind_create_frame):
643 * xterm.c (x_check_font): Remove unused local.
644 * scroll.c (CHECK_BOUNDS):
645 * xfaces.c (cache_fache): Rename local to avoid shadowing.
646 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
647 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
648 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
649 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
650 Now static.
651 (debug_method_add): Use va_list and vsprintf rather than relying
652 on undefined behavior with wrong number of arguments.
653 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
654 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
655 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
656 since we're not interested in debugging glyphs with old libraries.
657 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
658 GCC 4.6.0's static checking.
659
0766b489
PE
6602011-06-22 Paul Eggert <eggert@cs.ucla.edu>
661
31fd4b32
PE
662 Integer overflow and signedness fixes (Bug#8873).
663 A few related buffer overrun fixes, too.
664
b79e8648
PE
665 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
666
0766b489
PE
667 * dispextern.h (struct face.stipple):
668 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
669 (x_bitmap_mask, x_allocate_bitmap_record)
670 (x_create_bitmap_from_data, x_create_bitmap_from_file)
671 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
672 (x_create_bitmap_from_xpm_data):
673 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
674 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
675 (.bitmaps_last):
676 * xfaces.c (load_pixmap):
677 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
678 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
679 (.bitmaps_last, struct x_output.icon_bitmap):
680 Use ptrdiff_t, not int, for bitmap indexes.
681 (x_allocate_bitmap_record): Check for size overflow.
682 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
683
b081724f
PE
684 Use ptrdiff_t, not int, for overlay counts.
685 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
686 * editfns.c (overlays_around, get_pos_property):
687 * textprop.c (get_char_property_and_overlay):
688 * xdisp.c (next_overlay_change, note_mouse_highlight):
689 * xfaces.c (face_at_buffer_position):
21514da7
PE
690 * buffer.c (OVERLAY_COUNT_MAX): New macro.
691 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
692 (Fnext_overlay_change, Fprevious_overlay_change)
693 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 694 Use ptrdiff_t, not int, for sizes.
21514da7 695 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 696
3de73e5e
PE
697 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
698
2606c57b
PE
699 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
700 (x_session_initialize): Do not assume string length fits in int.
701
aaafe47a
PE
702 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
703 This is unlikely, but can occur if DPI is outlandish.
704
2674ddc8 705 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
706 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
707
28154962
PE
708 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
709 * xrdb.c (magic_file_p, search_magic_path):
710 Omit last arg SUFFIX; it was always 0. All callers changed.
711 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
712
7de51af5
PE
713 * xfont.c (xfont_match): Avoid need for strlen.
714
25ed6cc3
PE
715 * xfns.c: Don't assume strlen fits in int.
716 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
717
4eab31dd
PE
718 * xdisp.c (message_log_check_duplicate): Return intmax_t,
719 not unsigned long, as we prefer signed integers. All callers changed.
720 Detect integer overflow in repeat count.
721 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 722 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 723
171e2a58
PE
724 * termcap.c: Don't assume sizes fit in int and never overflow.
725 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
726 (gobble_line): Check for size-calculation overflow.
727
ad39faca 728 * minibuf.c (Fread_buffer):
6e5bb2dc 729 * lread.c (intern, intern_c_string):
74ca2eb3
PE
730 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
731 Don't assume string length fits in int.
732
52c61c22 733 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
734 * gtkutil.c (style_changed_cb): Avoid need for strlen.
735
b5b8c9e5
PE
736 * font.c: Don't assume string length fits in int.
737 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
738 Use ptrdiff_t, not int.
ccd6111c
PE
739 (font_intern_prop): Don't assume string length fits in int.
740 Don't assume integer property fits in fixnum.
741 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 742
882f0d81 743 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 744 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
745 Reformulate so as not to need the command string.
746 Invoke gzip -cd rather than gunzip, as it's more portable.
747 (lock_info_type, lock_file_1, lock_file):
748 Don't assume pid_t and time_t fit in unsigned long.
749 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
750 (current_lock_owner): Prefer signed type for sizes.
751 Use memcpy, not strncpy, where memcpy is what is really wanted.
752 Don't assume (via atoi) that time_t and pid_t fit in int.
753 Check for time_t and/or pid_t out of range, e.g., via a network share.
754 Don't alloca where an auto var works fine.
755
93f4cf88
PE
756 * fileio.c: Fix some integer overflow issues.
757 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
758 Don't assume string length fits in int.
759 (directory_file_name): Don't assume string length fits in long.
760 (make_temp_name): Don't assume pid fits in int, or that its print
761 length is less than 20.
762
f3e92b69
PE
763 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
764
1bfdaf10
PE
765 * coding.c (make_subsidiaries): Don't assume string length fits in int.
766
35016e9a
PE
767 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
768
3d1e65a1
PE
769 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
770 We prefer signed integers, even for size calculations.
771
0b963a93
PE
772 * emacs.c: Don't assume string length fits in 'int'.
773 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
774 (main): Don't invoke strlen when not needed.
775
573f4b54
PE
776 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
777 (XD_DEBUG_MESSAGE): Don't waste a byte.
778
989f33ba
PE
779 * callproc.c (getenv_internal_1, getenv_internal)
780 (Fgetenv_internal):
965d34eb
PE
781 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
782
e4d29b33
PE
783 * lread.c (invalid_syntax): Omit length argument.
784 All uses changed. This doesn't fix a bug, but it simplifies the
785 code away from its former Hollerith-constant appearance, and it's
786 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 787 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 788
eb49b136
PE
789 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
790 This didn't break anything, but it didn't help either.
791 It's confusing to put a bogus integer in a place where the actual
792 value does not matter.
9f62aeb1 793 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 794 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 795
15375a22
PE
796 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
797 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
798 implementation.
b61cc01c
PE
799 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
800 We prefer signed types, and the value cannot exceed the EMACS_INT
801 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
802 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
803 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
804 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 805
53b2623d
PE
806 * indent.c (sane_tab_width): New function.
807 (current_column, scan_for_column, Findent_to, position_indentation)
808 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 809 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 810
51cab52b 811 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 812
f2ed8a70
PE
813 * lisp.h (lint_assume): New macro.
814 * composite.c (composition_gstring_put_cache):
815 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
816
abe80cc6
PE
817 * editfns.c, insdel.c:
818 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 819
b02c740e
PE
820 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
821
ebc96716
PE
822 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
823
b4e50fa0 824 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 825 Use much-faster test for byte-length change.
311d5d7c 826 Don't assume string byte-length fits in 'int'.
a4cf38e4 827 Check that character arg fits in 'int'.
85461888 828 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 829
c0c1ee9f
PE
830 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
831
a498d7f4
PE
832 * fns.c (concat): Catch string overflow earlier.
833 Do not rely on integer wraparound.
834
51cab52b
PE
835 * dispextern.h (struct it.overlay_strings_charpos)
836 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
837 * xdisp.c (forward_to_next_line_start)
838 (back_to_previous_visible_line_start)
839 (reseat_at_next_visible_line_start, next_element_from_buffer):
840 Don't arbitrarily truncate the value of 'selective' to int.
841
76031fad
PE
842 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
843
5eb55db9
PE
844 * composite.c: Don't truncate sizes to 'int'.
845 (composition_gstring_p, composition_reseat_it)
846 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
847 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
848 not EMACS_UINT, for indexes.
5eb55db9 849
0703a717
PE
850 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
851
d6202519
PE
852 * buffer.c: Include <verify.h>.
853 (struct sortvec.priority, struct sortstr.priority):
8961a454 854 Now EMACS_INT, not int.
c20998a7 855 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
856 (struct sortstr.size, record_overlay_string)
857 (struct sortstrlist.size, struct sortlist.used):
858 Don't truncate size to int.
859 (record_overlay_string): Check for size-calculation overflow.
d6202519 860 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 861
d5a19415
JM
8622011-06-22 Jim Meyering <meyering@redhat.com>
863
029529ac 864 Don't leak an XBM-image-sized buffer
d5a19415
JM
865 * image.c (xbm_load): Free the image buffer after using it.
866
a9041e6c
PE
8672011-06-21 Paul Eggert <eggert@cs.ucla.edu>
868
869 Port to Sun C.
870 * composite.c (find_automatic_composition): Omit needless 'return 0;'
871 that Sun C diagnosed.
872 * fns.c (secure_hash): Fix pointer signedness issue.
873 * intervals.c (static_offset_intervals): New function.
874 (offset_intervals): Use it.
875
7f3f739f
LL
8762011-06-21 Leo Liu <sdl.web@gmail.com>
877
878 * deps.mk (fns.o):
879 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
880 sha512.h.
881
882 * fns.c (secure_hash): Rename from crypto_hash_function and change
883 the first arg to accept symbols.
5b66d427 884 (Fsecure_hash): New primitive.
7f3f739f
LL
885 (syms_of_fns): New symbols.
886
76147d94
DD
8872011-06-20 Deniz Dogan <deniz@dogan.se>
888
889 * process.c (Fset_process_buffer): Clarify return value in
890 docstring.
891
7d7d0045
CY
8922011-06-18 Chong Yidong <cyd@stupidchicken.com>
893
894 * dispnew.c (add_window_display_history): Use BVAR.
895
896 * xdisp.c (debug_method_add): Use BVAR.
897 (check_window_end, dump_glyph_matrix, dump_glyph)
898 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
899
900 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
901 Likewise.
902
903 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
904 check till after the cache is created in init_frame_faces.
905
ff2bc410
SM
9062011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
907
908 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
909
28177add
PE
9102011-06-16 Paul Eggert <eggert@cs.ucla.edu>
911
dd3482fe
PE
912 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
913 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
914 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
915
393d71f3 916 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
917 * fileio.c (Finsert_file_contents):
918 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
919 Remove the old (too-loose) buffer overflow checks.
920 They weren't needed, since make_gap checks for buffer overflow.
921 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
922 The old code merely checked for Emacs fixnum overflow, and relied
923 on undefined (wraparound) behavior. The new code avoids undefined
924 behavior, and also checks for ptrdiff_t and/or size_t overflow.
925
2e6813b0 926 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
927 Tune. Don't use wider integers than needed. Don't use alloca.
928 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 929
599a9e4f
PE
930 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
931
99561444
PE
932 * insdel.c, lisp.h (buffer_overflow): New function.
933 (insert_from_buffer_1, replace_range, replace_range_2):
934 * insdel.c (make_gap_larger):
935 * editfns.c (Finsert_char):
936 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
937
28177add
PE
938 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
939
e69dafad
PE
9402011-06-15 Paul Eggert <eggert@cs.ucla.edu>
941
a7af7fde 942 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 943
b1c46f02
PE
944 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
945 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
946
e69dafad
PE
947 * fileio.c: Don't assume EMACS_INT fits in off_t.
948 (emacs_lseek): New static function.
949 (Finsert_file_contents, Fwrite_region): Use it.
950 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
951
566684ea
PE
952 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
953
e6966cd6
PE
954 * fns.c: Don't overflow int when computing a list length.
955 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
956 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
957 truncation on 64-bit hosts. Check for QUIT every
958 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
959 faster and is responsive enough.
960 (Flength): Report an error instead of overflowing an integer.
961 (Fsafe_length): Return a float if the value is not representable
962 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 963 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 964 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 965
dd0b0efb
PE
966 * alloc.c: Check that resized vectors' lengths fit in fixnums.
967 (header_size, word_size): New constants.
968 (allocate_vectorlike): Don't check size overflow here.
969 (allocate_vector): Check it here instead, since this is the only
970 caller of allocate_vectorlike that could cause overflow.
971 Check that the new vector's length is representable as a fixnum.
972
86fe5cfe
PE
973 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
974 The previous code was bogus. For example, next_almost_prime (32)
975 returned 39, which is undesirable as it is a multiple of 3; and
976 next_almost_prime (24) returned 25, which is a multiple of 5 so
977 why was the code bothering to check for multiples of 7?
978
80e88859
PE
979 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
980
4a2f0ad6
PE
981 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
982
f66c7cf8
PE
983 Variadic C functions now count arguments with ptrdiff_t.
984 This partly undoes my 2011-03-30 change, which replaced int with size_t.
985 Back then I didn't know that the Emacs coding style prefers signed int.
986 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
987 were being counted with int, which may truncate counts on 64-bit
988 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
989 * lisp.h (struct Lisp_Subr.function.aMANY)
990 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
991 Arg counts are now ptrdiff_t, not size_t.
992 All variadic functions and their callers changed accordingly.
993 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
994 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
995 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
996 * callint.c (Fcall_interactively): Check arg count for overflow,
997 to avoid potential buffer overrun. Use signed char, not 'int',
998 for 'varies' array, so that we needn't bother to check its size
999 calculation for overflow.
1000 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1001 * eval.c (apply_lambda):
1002 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1003 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1004 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1005
a1759b76
PE
1006 * callint.c (Fcall_interactively): Don't use index var as event count.
1007
d96be9fc
PE
1008 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1009 * mem-limits.h (SIZE): Remove; no longer used.
1010
a690a978 1011 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1012
578c21e6
PE
1013 Remove unnecessary casts.
1014 * xterm.c (x_term_init):
1015 * xfns.c (x_set_border_pixel):
1016 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1017 These aren't needed now that we assume ANSI C.
1018
96f53c6c
PE
1019 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1020 It's more likely to cause problems (due to unsigned overflow)
1021 than to cure them.
1022
83c77d31
PE
1023 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1024
ee2079f1
PE
1025 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1026
6da65536
PE
1027 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1028
7147c4a4
PE
1029 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1030
193e32d9
PE
1031 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1032
e5533da6
PE
1033 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1034
9910e595
PE
1035 GLYPH_CODE_FACE returns EMACS_INT, not int.
1036 * dispextern.h (merge_faces):
1037 * xfaces.c (merge_faces):
01103c44
PE
1038 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1039 Don't assume EMACS_INT fits in int.
9910e595 1040
2638320e
PE
1041 * character.h (CHAR_VALID_P): Remove unused parameter.
1042 * fontset.c, lisp.h, xdisp.c: All uses changed.
1043
045eb8d9
PE
1044 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1045
c1f134b5
PE
1046 * fns.c (concat): Minor tuning based on overflow analysis.
1047 This doesn't fix any bugs. Use int to hold character, instead
1048 of constantly refetching from Emacs object. Use XFASTINT, not
1049 XINT, for value known to be a character. Don't bother comparing
1050 a single byte to 0400, as it's always less.
1051
395fcb93 1052 * floatfns.c (Fexpt):
327eeec8
PE
1053 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1054
abbd3d23
PE
1055 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1056 for characters.
1057
684a03ef
PE
1058 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1059
0fed43f3
PE
1060 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1061 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1062 incorrectly succeed when S was a string, because 4294967386 was
1063 truncated before it was used.
1064
8fd02eb7
PE
1065 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1066 Otherwise, an out-of-range integer could cause undefined behavior
1067 on a 64-bit host.
1068
f8c86b69
PE
1069 * composite.c: Use int, not EMACS_INT, for characters.
1070 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1071 EMACS_INT, for values that are known to be in character range.
1072 This doesn't fix any bugs but is the usual style inside Emacs and
1073 may generate better code on 32-bit machines.
1074
34206dd2
PE
1075 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1076 This is for reasons similar to the recent CHAR_STRING fix.
1077 * charset.c (Fencode_char): Check that character arg is actually
1078 a character. Pass an int to ENCODE_CHAR.
1079 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1080 wider than 'int', as a compile-time check to prevent future regressions
1081 in this area.
1082
c5958d4c 1083 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1084
1085 Make sure a 64-bit char is never passed to CHAR_STRING.
1086 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1087 by silently ignoring the top 32 bits, allowing some values
1088 that were far too large to be valid characters.
1089 * character.h: Include <verify.h>.
1090 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1091 arguments are no wider than unsigned, as a compile-time check
1092 to prevent future regressions in this area.
1093 * data.c (Faset):
01103c44 1094 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1095 (Fsubst_char_in_region):
1096 * fns.c (concat):
1097 * xdisp.c (decode_mode_spec_coding):
1098 Adjust to CHAR_STRING's new requirement.
1099 * editfns.c (Finsert_char, Fsubst_char_in_region):
1100 * fns.c (concat): Check that character args are actually
1101 characters. Without this test, these functions did the wrong
1102 thing with wildly out-of-range values on 64-bit hosts.
1103
d37ca623
PE
1104 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1105 These casts should not be needed on 32-bit hosts, either.
1106 * keyboard.c (read_char):
1107 * lread.c (Fload): Remove casts to unsigned.
1108
ea204efb
PE
1109 * lisp.h (UNSIGNED_CMP): New macro.
1110 This fixes comparison bugs on 64-bit hosts.
1111 (ASCII_CHAR_P): Use it.
1112 * casefiddle.c (casify_object):
01103c44 1113 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1114 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1115 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1116 * dispextern.h (FACE_FROM_ID):
1117 * keyboard.c (read_char): Use UNSIGNED_CMP.
1118
41cb286c
PE
1119 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1120 not to EMACS_INT, to avoid GCC warning.
1121
4a1b9832
PE
1122 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1123
55daad71
PE
1124 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1125 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1126 isn't needed on 32-bit machines.
8f95c75c 1127
01103c44
PE
1128 * buffer.c (Fgenerate_new_buffer_name):
1129 Use EMACS_INT for count, not int.
0ceccced 1130 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1131
1132 * data.c (Qcompiled_function): Now static.
1133
c6f072e7
PE
1134 * window.c (window_body_lines): Now static.
1135
20ce5912
PE
1136 * image.c (gif_load): Rename local to avoid shadowing.
1137
9c4c5f81
PE
1138 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1139 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1140 * alloc.c (make_save_value): Integer argument is now of type
1141 ptrdiff_t, not int.
1142 (mark_object): Use ptrdiff_t, not int.
1143 * lisp.h (pD): New macro.
1144 * print.c (print_object): Use it.
1145
c0c5c8ae
PE
1146 * alloc.c: Use EMACS_INT, not int, to count objects.
1147 (total_conses, total_markers, total_symbols, total_vector_size)
1148 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1149 (total_free_floats, total_floats, total_free_intervals)
1150 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1151 Now EMACS_INT, not int. All uses changed.
1152 (Fgarbage_collect): Compute overall total using a double, so that
1153 integer overflow is less likely to be a problem. Check for overflow
1154 when converting back to an integer.
5a25e253
PE
1155 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1156 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1157 These were 'int' variables that could overflow on 64-bit hosts;
1158 they were never used, so remove them instead of repairing them.
211a0b2a 1159 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1160 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1161 Previously, this ceilinged at INT_MAX, but that doesn't work on
1162 64-bit machines.
e46bb31a 1163 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1164
c78baabf 1165 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1166 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1167 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1168 when a (possibly-narrower) signed value would do just as well.
1169 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1170
c9d624c6
PE
1171 * alloc.c: Catch some string size overflows that we were missing.
1172 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1173 for convenience in STRING_BYTES_MAX.
1174 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1175 The definition here is exact; the one in lisp.h was approximate.
1176 (allocate_string_data): Check for string overflow. This catches
1177 some instances we weren't catching before. Also, it catches
1178 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1179 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1180 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1181
c9d624c6
PE
1182 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1183 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1184 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1185
353032ce
PE
1186 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1187
2bccce07
PE
1188 * alloc.c (Fmake_string): Check for out-of-range init.
1189
0ac30604
SM
11902011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1191
1192 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1193
c195f2de
JD
11942011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1195
1196 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1197 xg_get_default_scrollbar_width.
1198
1199 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1200 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1201 (style_changed_cb): Call update_theme_scrollbar_width and call
1202 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1203 all frames (Bug#8505).
1204 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1205 Call gtk_window_set_resizable if HAVE_GTK3.
1206 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1207 and height if HAVE_GTK3 (Bug#8505).
1208 (scroll_bar_width_for_theme): New variable.
1209 (update_theme_scrollbar_width): New function.
1210 (xg_get_default_scrollbar_width): Move code to
1211 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1212 (xg_initialize): Call update_theme_scrollbar_width.
1213
1214 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1215
1216 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1217
e10ac9f1
MR
12182011-06-12 Martin Rudalics <rudalics@gmx.at>
1219
1220 * frame.c (make_frame): Call other_buffer_safely instead of
1221 other_buffer.
1222
1223 * window.c (temp_output_buffer_show): Call display_buffer with
1224 second argument Vtemp_buffer_show_specifiers and reset latter
1225 immediately after the call.
1226 (Vtemp_buffer_show_specifiers): New variable.
1227 (auto_window_vscroll_p, next_screen_context_lines)
1228 (Vscroll_preserve_screen_position): Remove leading asterisks from
1229 doc-strings.
1230
2d3c217e 12312011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1232
7b7f97e8 1233 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1234 * buffer.c (Qclone_number): Remove for now, as it's unused.
1235 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1236 (record_buffer): Remove unused local.
1237 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1238 (set_frame_buffer_list): Remove; unused.
1239 * frame.h (other_visible_frames): Remove decl.
1240 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1241 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1242 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1243 if HAVE_GPM.
1244 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1245 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1246 Define only if HAVE_GPM.
1247 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1248 (update_hints_inhibit): Remove; never set. All uses removed.
1249 * widgetprv.h (emacsFrameClassRec): Remove decl.
1250 * window.c (delete_deletable_window): Now returns void, since it
1251 wasn't returning anything.
1252 (compare_window_configurations): Remove unused locals.
1253 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1254 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1255 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1256 the same widths as pointers. This follows up on the 2011-05-06 patch.
1257 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1258 * xterm.h: Likewise.
1259 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1260
1384b89e
JB
12612011-06-12 Juanma Barranquero <lekktu@gmail.com>
1262
1263 * makefile.w32-in: Update dependencies.
1264 (LISP_H): Add lib/intprops.h.
1265
1100a63c
CY
12662011-06-11 Chong Yidong <cyd@stupidchicken.com>
1267
1268 * image.c (gif_load): Add animation frame delay to the metadata.
1269 (syms_of_image): Use DEFSYM. New symbol `delay'.
1270
6198ccd0
MR
12712011-06-11 Martin Rudalics <rudalics@gmx.at>
1272
1273 * window.c (delete_deletable_window): Re-add.
1274 (Fset_window_configuration): Rewrite to handle dead buffers and
1275 consequently deletable windows.
1276 (window_tree, Fwindow_tree): Remove. Supply functionality in
1277 window.el.
1278 (compare_window_configurations): Simplify code.
1279
b6e3633c
AS
12802011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1281
1ab0dee5
AS
1282 * image.c (imagemagick_load_image): Fix type mismatch.
1283 (Fimagemagick_types): Likewise.
1284
b6e3633c
AS
1285 * window.h (replace_buffer_in_windows): Declare.
1286
9397e56f
MR
12872011-06-11 Martin Rudalics <rudalics@gmx.at>
1288
1289 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1290 Qclone_number. Remove external declaration of Qdelete_window.
1291 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1292 code.
1293 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1294 Qbuffer_list_update_hook if allowed.
1295 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1296 buffer list implementation.
1297 (other_buffer_safely): New function.
1298 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1299 calls to replace_buffer_in_windows and
1300 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1301 if allowed.
1302 (record_buffer): Inhibit quitting and rewrite using quittable
1303 functions. Run Qbuffer_list_update_hook if allowed.
1304 (Frecord_buffer, Funrecord_buffer): New functions.
1305 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1306 switch-to-buffer to window.el.
1307 (bury-buffer): Move to window.el.
1308 (Vbuffer_list_update_hook): New variable.
1309
1310 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1311 section.
1312
1313 * window.h (resize_frame_windows): Move up in code.
1314 (Fwindow_frame): Remove EXFUN.
1315 (replace_buffer_in_all_windows): Remove prototype.
1316 (replace_buffer_in_windows_safely): Add prototype.
1317
1318 * window.c: Declare Qdelete_window static again. Move down
1319 declaration of select_count.
1320 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1321 (Fother_window): Move to window.el.
1322 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1323 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1324 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1325 window.el.
1326 (replace_buffer_in_windows): Implement by calling
1327 Qreplace_buffer_in_windows.
1328 (replace_buffer_in_all_windows): Remove with some functionality
1329 moved into replace_buffer_in_windows_safely.
1330 (replace_buffer_in_windows_safely): New function.
1331 (select_window_norecord, select_frame_norecord): Move in front
1332 of run_window_configuration_change_hook. Remove now obsolete
1333 declarations.
1334 (Fset_window_buffer): Rewrite doc-string. Call
1335 Qrecord_window_buffer.
1336 (keys_of_window): Move binding for other-window to window.el.
1337
b50691aa
CY
13382011-06-11 Chong Yidong <cyd@stupidchicken.com>
1339
1340 * dispextern.h (struct image): Replace data member, whose int_val
1341 and ptr_val fields were not used by anything, with a single
1342 lisp_val object.
1343
1344 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1345 (gif_clear_image, gif_load, imagemagick_load_image)
1346 (gs_clear_image, gs_load): Callers changed.
1347
3f754b86
PE
13482011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1349
cca69397
PE
1350 * buffer.h: Include <time.h>, for time_t.
1351 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1352
109e28d0
PE
1353 Fix minor problems found by static checking.
1354
60737f02
PE
1355 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1356
4b66faf3
PE
1357 Make identifiers static if they are not used in other modules.
1358 * data.c (Qcompiled_function, Qframe, Qvector):
1359 * image.c (QimageMagick, Qsvg):
1360 * minibuf.c (Qmetadata):
1361 * window.c (resize_window_check, resize_root_window): Now static.
1362 * window.h (resize_window_check, resize_root_window): Remove decls.
1363
109e28d0
PE
1364 * window.c (window_deletion_count, delete_deletable_window):
1365 Remove; unused.
46a4ce9e
PE
1366 (window_body_lines): Now static.
1367 (Fdelete_other_windows_internal): Mark vars as initialized.
1368 Make sure 'resize_failed' is initialized.
1369 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1370 (resize_window_apply): Remove unused local.
1371 * window.h (delete_deletable_window): Remove decl.
1372
109e28d0 1373 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
1374 (imagemagick_load_image): Fix pointer signedness problem by changing
1375 last arg from unsigned char * to char *. All uses changed.
1376 Also, fix a local for similar reasons.
1377 Remove unused locals. Remove locals to avoid shadowing.
1378 (fn_rsvg_handle_free): Remove; unused.
1379 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1380 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1381
3f754b86
PE
1382 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1383
2547adb1
CY
13842011-06-10 Chong Yidong <cyd@stupidchicken.com>
1385
1386 * image.c (gif_load): Fix omitted cast error introduced by
1387 2011-06-06 change.
1388
2c8e37d4
MR
13892011-06-10 Martin Rudalics <rudalics@gmx.at>
1390
1391 * window.h (resize_proportionally, orig_total_lines)
1392 (orig_top_line): Remove from window structure.
1393 (set_window_height, set_window_width, change_window_heights)
1394 (Fdelete_window): Remove prototypes.
1395 (resize_frame_windows): Remove duplicate declaration.
1396
440a42e3
EZ
13972011-06-10 Eli Zaretskii <eliz@gnu.org>
1398
1399 * window.h (resize_frame_windows, resize_window_check)
1400 (delete_deletable_window, resize_root_window)
1401 (resize_frame_windows): Declare prototypes.
1402
1403 * window.c (resize_window_apply): Make definition be "static" to
1404 match the prototype.
1405
562dd5e9
MR
14062011-06-10 Martin Rudalics <rudalics@gmx.at>
1407
1408 * window.c: Remove declarations of Qwindow_size_fixed,
1409 window_min_size_1, window_min_size_2, window_min_size,
1410 size_window, window_fixed_size_p, enlarge_window, delete_window.
1411 Remove static from declaration of Qdelete_window, it's
1412 temporarily needed by Fbury_buffer.
1413 (replace_window): Don't assign orig_top_line and
1414 orig_total_lines.
1415 (Fdelete_window, delete_window): Remove. Window deletion is
1416 handled by window.el.
1417 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1418 Fdelete_window calls with calls to Qdelete_window.
1419 (Fdelete_other_windows): Remove. Deleting other windows is
1420 handled by window.el.
1421 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1422 handled in window.el.
1423 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1424 Window minimum sizes are handled in window.el.
1425 (shrink_windows, size_window, set_window_height)
1426 (set_window_width, change_window_heights, window_height)
1427 (window_width, CURBEG, CURSIZE, enlarge_window)
1428 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1429 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1430 handled in window.el.
1431 (make_dummy_parent): Rename to make_parent_window and give it a
1432 second argument horflag.
1433 (make_window): Don't set resize_proportionally any more.
1434 (Fsplit_window): Remove. Windows are split in window.el.
1435 (save_restore_action, save_restore_orig_size)
1436 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1437 Resize mini windows in window.el.
1438 (grow_mini_window, shrink_mini_window): Implement by calling
1439 Qresize_root_window_vertically, resize_window_check and
1440 resize_window_apply.
1441 (saved_window, Fset_window_configuration, save_window_save): Do
1442 not handle orig_top_line, orig_total_lines, and
1443 resize_proportionally.
1444 (window_min_height, window_min_width): Move to window.el.
1445 (keys_of_window): Move bindings for delete-other-windows,
1446 split-window, delete-window and enlarge-window to window.el.
1447
1448 * buffer.c: Temporarily extern Qdelete_window.
1449 (Fbury_buffer): Temporarily call Qdelete_window instead of
1450 Fdelete_window (Fbury_buffer will move to window.el soon).
1451
1452 * frame.c (set_menu_bar_lines_1): Remove code handling
1453 orig_top_line and orig_total_lines.
1454
1455 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1456 set_window_height but set heights directly.
1457 (change_frame_size_1): Use resize_frame_windows.
1458
1459 * xdisp.c (init_xdisp): Don't use set_window_height but set
1460 heights directly.
1461
1462 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1463 resize_frame_windows instead of change_window_heights and run
1464 run_window_configuration_change_hook.
1465
1466 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1467 instead of change_window_heights and run
1468 run_window_configuration_change_hook.
1469
1a13852e
MR
14702011-06-09 Martin Rudalics <rudalics@gmx.at>
1471
1472 * window.c (replace_window): Rename second argument REPLACEMENT to
1473 NEW. New third argument SETFLAG. Rewrite.
1474 (delete_window, make_dummy_parent): Call replace_window with
1475 third argument 1.
1476 (window_list_1): Move down in code.
1477 (run_window_configuration_change_hook): Move set_buffer part
1478 before select_frame_norecord part in order to unwind correctly.
1479 Rename count1 to count.
1480 (recombine_windows, delete_deletable_window, resize_root_window)
1481 (Fdelete_other_windows_internal)
1482 (Frun_window_configuration_change_hook, make_parent_window)
1483 (resize_window_check, resize_window_apply, Fresize_window_apply)
1484 (resize_frame_windows, Fsplit_window_internal)
1485 (Fdelete_window_internal, Fresize_mini_window_internal): New
1486 functions.
1487 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1488
f3d1777e
MR
14892011-06-08 Martin Rudalics <rudalics@gmx.at>
1490
496e208e
MR
1491 * window.h (window): Add some new members to window structure -
1492 normal_lines, normal_cols, new_total, new_normal, clone_number,
1493 splits, nest, prev_buffers, next_buffers.
1494 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1495 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1496
f3d1777e
MR
1497 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1498 Remove.
496e208e
MR
1499 (make_dummy_parent): Set new members of windows structure.
1500 (make_window): Move down in code. Handle new members of window
1501 structure.
1502 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1503 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1504 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1505 (Fset_window_prev_buffers, Fwindow_next_buffers)
1506 (Fset_window_next_buffers, Fset_window_clone_number): New
1507 functions.
1508 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1509 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1510 Doc-string fixes.
1511 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1512 Argument WINDOW can be now internal window too.
1513 (Fwindow_use_time): Move up in code.
1514 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1515 Rewrite doc-string.
1516 (Fset_window_configuration, saved_window)
1517 (Fcurrent_window_configuration, save_window_save): Handle new
1518 members of window structure.
b9e809c2
MR
1519 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1520 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1521 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1522 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1523 Qget_mru_window, Qresize_root_window,
1524 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1525 Qauto_buffer_name; staticpro them.
f3d1777e 1526
abde8f8c
MR
15272011-06-07 Martin Rudalics <rudalics@gmx.at>
1528
1529 * window.c (Fwindow_total_size, Fwindow_left_column)
1530 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1531 (Fwindow_list_1): New functions.
1532 (window_box_text_cols): Replace with window_body_cols.
1533 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1534 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1535 (delete_window, Fset_window_configuration): Call
1536 delete_all_subwindows with window as argument.
1537 (delete_all_subwindows): Take a window as argument and not a
1538 structure. Rewrite.
190b47e6
MR
1539 (window_loop): Remove handling of GET_LRU_WINDOW and
1540 GET_LARGEST_WINDOW.
1541 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1542
1543 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1544 window_box_text_cols. delete_all_subwindows now takes a
1545 Lisp_Object as argument.
abde8f8c
MR
1546
1547 * indent.c (compute_motion, Fcompute_motion): Use
1548 window_body_cols instead of window_box_text_cols.
1549
fa8a67e6
MR
1550 * frame.c (delete_frame): Call delete_all_subwindows with root
1551 window as argument.
1552
a54e3482
DC
15532011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1554
1555 * fns.c (Fputhash): Document return value.
1556
60002bf5
CY
15572011-06-06 Chong Yidong <cyd@stupidchicken.com>
1558
1559 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1560
0c671da6 15612011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1562
b862a52a 1563 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1564
be44ca6c
PE
1565 Check for overflow when converting integer to cons and back.
1566 * charset.c (Fdefine_charset_internal, Fdecode_char):
1567 Use cons_to_unsigned to catch overflow.
1568 (Fencode_char): Use INTEGER_TO_CONS.
1569 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1570 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1571 * data.c (long_to_cons, cons_to_long): Remove.
1572 (cons_to_unsigned, cons_to_signed): New functions.
1573 These signal an error for invalid or out-of-range values.
1574 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1575 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1576 * font.c (Ffont_variation_glyphs):
1577 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1578 * lisp.h: Include <intprops.h>.
1579 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1580 (cons_to_signed, cons_to_unsigned): New decls.
1581 (long_to_cons, cons_to_long): Remove decls.
1582 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1583 (Fprimitive_undo): Use CONS_TO_INTEGER.
1584 * xfns.c (Fx_window_property): Likewise.
1585 * xselect.c: Include <limits.h>.
1586 (x_own_selection, selection_data_to_lisp_data):
1587 Use INTEGER_TO_CONS.
1588 (x_handle_selection_request, x_handle_selection_clear)
1589 (x_get_foreign_selection, Fx_disown_selection_internal)
1590 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1591 (lisp_data_to_selection_data): Use cons_to_unsigned.
1592 (x_fill_property_data): Use cons_to_signed.
1593 Report values out of range.
1594
d1f3d2af
PE
1595 Check for buffer and string overflow more precisely.
1596 * buffer.h (BUF_BYTES_MAX): New macro.
1597 * lisp.h (STRING_BYTES_MAX): New macro.
1598 * alloc.c (Fmake_string):
1599 * character.c (string_escape_byte8):
1600 * coding.c (coding_alloc_by_realloc):
1601 * doprnt.c (doprnt):
1602 * editfns.c (Fformat):
1603 * eval.c (verror):
1604 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1605 since they may not be the same number.
1606 * editfns.c (Finsert_char):
1607 * fileio.c (Finsert_file_contents):
1608 Likewise for BUF_BYTES_MAX.
1609
dd52fcea
PE
1610 * image.c: Use ptrdiff_t, not int, for sizes.
1611 (slurp_file): Switch from int to ptrdiff_t.
1612 All uses changed.
1613 (slurp_file): Check that file size fits in both size_t (for
1614 malloc) and ptrdiff_t (for sanity and safety).
1615
7f9bbdbb
PE
1616 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1617 if b->modtime has its maximal value.
1618
dfe18f82
PE
1619 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1620
84acfcf0
PE
1621 Don't assume time_t can fit into int.
1622 * buffer.h (struct buffer.modtime): Now time_t, not int.
1623 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1624 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1625
ccd9a01a
PE
1626 Minor fixes for signed vs unsigned integers.
1627 * character.h (MAYBE_UNIFY_CHAR):
1628 * charset.c (maybe_unify_char):
1629 * keyboard.c (read_char, reorder_modifiers):
1630 XINT -> XFASTINT, since the integer must be nonnegative.
1631 * ftfont.c (ftfont_spec_pattern):
1632 * keymap.c (access_keymap, silly_event_symbol_error):
1633 XUINT -> XFASTINT, since the integer must be nonnegative.
1634 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1635 since it makes no difference and we prefer signed.
1636 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1637 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1638 nonnegative.
1639
d6d100dd
SM
16402011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1641
1642 * window.h (Fwindow_frame): Declare.
1643
2b6148e4
PE
16442011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1645
1646 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1647 (SPARE_MEMORY): Always define.
1648 (LARGE_REQUEST): Remove.
1649 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1650
f230ecc9
MR
16512011-06-06 Martin Rudalics <rudalics@gmx.at>
1652
727e958e
MR
1653 * lisp.h: Move EXFUNS for Fframe_root_window,
1654 Fframe_first_window and Fset_frame_selected_window to window.h.
1655
1656 * window.h: Move EXFUNS for Fframe_root_window,
1657 Fframe_first_window and Fset_frame_selected_window here from
1658 lisp.h.
1659
1660 * frame.c (Fwindow_frame, Fframe_first_window)
1661 (Fframe_root_window, Fframe_selected_window)
1662 (Fset_frame_selected_window): Move to window.c.
1663 (Factive_minibuffer_window): Move to minibuf.c.
1664 (Fother_visible_frames_p): New function.
1665
1666 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1667
f230ecc9
MR
1668 * window.c (decode_window, decode_any_window): Move up in code.
1669 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1670 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1671 (Fwindow_buffer): Move up and rewrite doc-string.
1672 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1673 (Fwindow_prev): New functions.
727e958e
MR
1674 (Fwindow_frame): Move here from frame.c. Accept any window as
1675 argument.
1676 (Fframe_root_window, Fframe_first_window)
1677 (Fframe_selected_window): Move here from frame.c. Accept frame
1678 or arbitrary window as argument. Update doc-strings.
1679 (Fminibuffer_window): Move up in code.
1680 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1681 (Fset_frame_selected_window): Move here from frame.c.
1682 Marginal rewrite.
727e958e
MR
1683 (Fselected_window, select_window, Fselect_window): Move up in
1684 code. Minor doc-string fixes.
f230ecc9 1685
4d09bcf6
PE
16862011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1687
1688 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1689 Do not assume that spare memory exists; that assumption is valid
1690 only if SYSTEM_MALLOC.
1691 (LARGE_REQUEST): New macro, so that the issue of large requests
1692 is separated from the issue of spare memory.
1693
810928a2
AS
16942011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1695
172418ad
AS
1696 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1697 format. (Bug#8806)
1698
43f862f7
AS
1699 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1700
810928a2
AS
1701 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1702 before statements.
1703
a059fe24
JD
17042011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1705
1706 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1707
1708 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1709
1710 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1711 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1712
989bf368
JB
17132011-06-05 Juanma Barranquero <lekktu@gmail.com>
1714
1715 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1716
4b80f674
CY
17172011-06-04 Chong Yidong <cyd@stupidchicken.com>
1718
1719 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1720 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1721 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1722 New error handlers.
4b80f674
CY
1723 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1724 Obey Vx_select_enable_clipboard_manager. Catch errors in
1725 x_clipboard_manager_save (Bug#8779).
1726 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1727 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1728
99a33b77 17292011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1730
1731 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1732
99a33b77 17332011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1734
1735 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1736 in the current matrix if keep_current_p is non-zero.
1737
8264569d
EZ
17382011-06-04 Eli Zaretskii <eliz@gnu.org>
1739
1740 * bidi.c (bidi_level_of_next_char): Fix last change.
1741
57f97249
EZ
17422011-06-03 Eli Zaretskii <eliz@gnu.org>
1743
fec2107c 1744 Support bidi reordering of text covered by display properties.
57f97249 1745
fec2107c
EZ
1746 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1747 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1748 (bidi_cache_search, bidi_cache_iterator_state)
1749 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1750 (bidi_level_of_next_char, bidi_move_to_visually_next):
1751 Support character positions inside a run of characters covered by a
fec2107c
EZ
1752 display string.
1753 (bidi_paragraph_init, bidi_resolve_explicit_1)
1754 (bidi_level_of_next_char): Call bidi_fetch_char and
1755 bidi_fetch_char_advance instead of FETCH_CHAR and
1756 FETCH_CHAR_ADVANCE.
1757 (bidi_init_it): Initialize new members.
1758 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1759 definitions.
1760 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1761 instead of using explicit *_CHAR codes.
d6d100dd
SM
1762 (bidi_resolve_explicit, bidi_resolve_weak):
1763 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1764 bidirectional text is supported only in multibyte buffers.
1765 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1766 it to initialize the frame_window_p member of struct bidi_it.
1767 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1768 (bidi_resolve_explicit, bidi_resolve_weak)
1769 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1770 bidi_it->nchars is non-positive.
1771 (bidi_level_of_next_char): Don't try to lookup the cache for the
1772 next/previous character if nothing is cached there yet, or if we
1773 were just reseat()'ed to a new position.
c40e2fb2 1774
0e14fe90
EZ
1775 * xdisp.c (set_cursor_from_row): Set start and stop points
1776 according to the row's direction when priming the loop that looks
1777 for the glyph on which to display cursor.
1778 (single_display_spec_intangible_p): Function deleted.
1779 (display_prop_intangible_p): Reimplement to call
1780 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1781 Accept 3 additional arguments needed by handle_display_spec.
1782 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1783 values: lists, `(when COND...)' forms, etc.
1784 (single_display_spec_string_p): Support property values that are
1785 lists with the argument STRING its top-level element.
1786 (display_prop_string_p): Fix the condition for processing a
1787 property that is a list to be consistent with handle_display_spec.
fec2107c 1788 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1789 last portion of handle_display_prop.
1790 (compute_display_string_pos): Accept additional argument
1791 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1792 value of a `display' property is a "replacing spec".
1793 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1794 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1795 the display property, but just return a value indicating whether
1796 the display property will replace the characters it covers.
1797 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1798 frame_window_p members of struct bidi_it.
d6d100dd
SM
1799 (compute_display_string_pos, compute_display_string_end):
1800 New functions.
fec2107c
EZ
1801 (push_it): Accept second argument POSITION, where pop_it should
1802 jump to continue iteration.
1803 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1804
fec2107c
EZ
1805 * keyboard.c (adjust_point_for_property): Adjust the call to
1806 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1807
1808 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1809 (bidi_init_it): Update prototypes.
1810 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1811 (compute_display_string_pos, compute_display_string_end):
1812 Declare prototypes.
fec2107c
EZ
1813 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1814 EMACS_INT.
fc6f18ce 1815
40087514 18162011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1817
57f53182
PE
1818 Malloc failure behavior now depends on size of allocation.
1819 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1820 * lisp.h: Change signatures accordingly.
1821 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1822 All callers changed. (Bug#8762)
1823
1824 * gnutls.c: Use Emacs's memory allocators.
1825 Without this change, the gnutls library would invoke malloc etc.
1826 directly, which causes problems on non-SYNC_INPUT hosts, and which
1827 runs afoul of improving memory_full behavior. (Bug#8761)
1828 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1829 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1830 xfree instead of the default malloc, realloc, free.
1831 (Fgnutls_boot): No need to check for memory allocation failure,
1832 since xmalloc does that for us.
1833
ac32cd99 1834 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1835 * category.c (hash_get_category_set):
1836 * ccl.c (ccl_driver):
1837 * charset.c (Fdefine_charset_internal):
1838 * charset.h (struct charset.hash_index):
1839 * composite.c (get_composition_id, gstring_lookup_cache)
1840 (composition_gstring_put_cache):
1841 * composite.h (struct composition.hash_index):
1842 * dispextern.h (struct image.hash):
1843 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1844 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1845 (hashfn_equal, hashfn_user_defined, make_hash_table)
1846 (maybe_resize_hash_table, hash_lookup, hash_put)
1847 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1848 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1849 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1850 * image.c (make_image, search_image_cache, lookup_image)
1851 (xpm_put_color_table_h):
1852 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1853 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1854 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1855 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1856 * alloc.c (allocate_vectorlike):
1857 Check for overflow in vector size calculations.
1858 * ccl.c (ccl_driver):
1859 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1860 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1861 need to be updated by these changes.
40087514
PE
1862 * fns.c (make_hash_table, maybe_resize_hash_table):
1863 Check for integer overflow with large hash tables.
0de4bb68
PE
1864 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1865 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1866 (SXHASH_REDUCE): New macro.
1867 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1868 Use it instead of discarding useful hash info with large hash values.
1869 (sxhash_float): New function.
1870 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1871 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1872 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1873 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1874 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1875 Adjust signatures to match updated version of code.
1876 (consing_since_gc): Now EMACS_INT, since a single hash table can
1877 use more than INT_MAX bytes.
1878
698d32e2
DN
18792011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1880
1881 Make it possible to build with GCC-4.6+ -O2 -flto.
1882
1883 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1884
fd6fa53f
SM
18852011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1886
1887 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1888 Call minibuffer-inactive-mode.
1889
864db017
JB
18902011-05-31 Juanma Barranquero <lekktu@gmail.com>
1891
1892 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1893 Update dependencies.
1894
2ad0baf4
DN
18952011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1896
1897 * data.c (init_data): Remove code for UTS, this system is not
1898 supported anymore.
1899
4fcc2638
DN
19002011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1901
1902 Don't force ./temacs to start in terminal mode.
1903
1904 * frame.c (make_initial_frame): Initialize faces in all cases, not
1905 only when CANNOT_DUMP is defined.
1906 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1907
c56e0fd5
DN
19082011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1909
1910 * dispnew.c (add_window_display_history): Use const for the string
1911 pointer. Remove declaration, not needed.
1912
333d54da 19132011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1914
55d4c1b2 1915 Use 'inline', not 'INLINE'.
333d54da 1916 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1917 * alloc.c, fontset.c (INLINE): Remove.
1918 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1919 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1920 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1921 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1922 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1923
738db178
DN
19242011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1925
1926 Make it possible to run ./temacs.
1927
1928 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1929 syms_of_callproc does the same thing. Remove test for
1930 "initialized", do it in the caller.
1931 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1932
620c53a6
SM
19332011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1934
1935 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1936 (read_minibuf): Use get_minibuffer.
1937 (syms_of_minibuf): Use DEFSYM.
1938 (Qmetadata): New var.
1939 * data.c (Qbuffer): Don't make it static.
1940 (syms_of_data): Use DEFSYM.
1941
e003a292
PE
19422011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1943
1944 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1945 (CCL_CODE_MIN): New macro.
1946
ed008a6d
PE
19472011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1948
3687c2ef
PE
1949 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1950
ed008a6d
PE
1951 * eval.c (Qdebug): Now static.
1952 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1953 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1954 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1955
d66c4c7c
CY
19562011-05-29 Chong Yidong <cyd@stupidchicken.com>
1957
1958 * image.c: Various fixes to ImageMagick code comments.
1959 (Fimagemagick_types): Doc fix.
1960
5fbc2025
PE
19612011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1962
0196f88a
PE
1963 Minor fixes prompted by GCC 4.6.0 warnings.
1964
1965 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1966
5fbc2025
PE
1967 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1968 (x_clipboard_manager_save_all): Move extern decl to ...
1969 * xterm.h: ... here, so that it can be checked for consistency.
1970
1dd3c2d9
CY
19712011-05-29 Chong Yidong <cyd@stupidchicken.com>
1972
1973 * xselect.c (x_clipboard_manager_save_frame)
1974 (x_clipboard_manager_save_all): New functions.
1975 (Fx_clipboard_manager_save): Lisp function deleted.
1976
1977 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1978 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1979
1980 * xterm.h: Update prototype.
1981
5ba6571d
WX
19822011-05-28 William Xu <william.xwl@gmail.com>
1983
1984 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1985 exiting (Bug#8239).
1986
3eaff834
JM
19872011-05-28 Jim Meyering <meyering@redhat.com>
1988
e1900994 1989 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1990 * fns.c (to_uchar): Define.
1991 (crypto_hash_function): Use it to convert some newly-signed
1992 variables to unsigned, to avoid sign-extension bugs. For example,
1993 without this change, (md5 "truc") would evaluate to
1994 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1995 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1996 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1997
0f6990a7
PE
19982011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1999
2000 Integer overflow fixes.
c8a9ca5a 2001
08686060
PE
2002 * dbusbind.c: Serial number integer overflow fixes.
2003 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2004 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2005 to hold a serial number that is too large for a fixnum.
2006 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2007 Check for serial numbers out of range. Decode any serial number
59568bf0 2008 that was so large that it became a float. (Bug#8722)
08686060 2009
2d1fc3c7
PE
2010 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2011 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2012 Use XFASTINT rather than XUINT when numbers are nonnegative.
2013 (xd_append_arg, Fdbus_method_return_internal):
2014 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2015 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2016 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2017 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2018 (Bug#8722)
2d1fc3c7 2019
c8a9ca5a
PE
2020 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2021
519e1d69
PE
2022 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2023
30569699
PE
2024 ccl: add integer overflow checks
2025 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2026 (IN_INT_RANGE): New macros.
2027 (ccl_driver): Use them to check for integer overflow when
2028 decoding a CCL program. Many of the new checks are whether XINT (x)
2029 fits in int; it doesn't always, on 64-bit hosts. The new version
2030 doesn't catch all possible integer overflows, but it's an
847044ea 2031 improvement. (Bug#8719)
30569699 2032
c11285dc
PE
2033 * alloc.c (make_event_array): Use XINT, not XUINT.
2034 There's no need for unsigned here.
2035
fdccd48e
PE
2036 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2037 This follows up to the 2011-05-06 change that substituted uintptr_t
2038 for EMACS_INT. This case wasn't caught back then.
2039
37910ab2
PE
2040 Rework Fformat to avoid integer overflow issues.
2041 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2042 now (part of C89). Include <verify.h>.
2043 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2044 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2045 (Fformat): Avoid the prepass trying to compute sizes; it was only
2046 approximate and thus did not catch overflow reliably. Instead, walk
2047 through the format just once, formatting and computing sizes as we go,
2048 checking for integer overflow at every step, and allocating a larger
2049 buffer as needed. Keep track separately whether the format is
2050 multibyte. Keep only the most-recently calculated precision, rather
2051 than them all. Record whether each argument has been converted to
2052 string. Use EMACS_INT, not int, for byte and char and arg counts.
2053 Support field widths and precisions larger than INT_MAX. Avoid
2054 sprintf's undefined behavior with conversion specifications such as %#d
2055 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2056 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2057 formatting out-of-range floating point numbers with int
9173deec 2058 formats. (Bug#8668)
37910ab2 2059
2e6578fb
PE
2060 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2061
0ae6bdee
PE
2062 * data.c: Avoid integer truncation in expressions involving floats.
2063 * data.c: Include <intprops.h>.
2064 (arith_driver): When there's an integer overflow in an expression
2065 involving floating point, convert the integers to floating point
2066 so that the resulting value does not suffer from catastrophic
2067 integer truncation. For example, on a 64-bit host (* 4
2068 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2069 Do not rely on undefined behavior after integer overflow.
2070
de883a70
PE
2071 merge count_size_as_multibyte, parse_str_to_multibyte
2072 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2073 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2074 Check for integer overflow.
2075 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2076 since it's now a duplicate of the other. This is more of
2077 a character than a buffer op, so better that it's in character.c.
2078 * fns.c, print.c: Adjust to above changes.
2079
2ff916cb
PE
20802011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2081
2082 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2083
f1b54466
PE
20842011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2085
fb1ac845
PE
2086 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2087 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2088 (x_clipboard_manager_save): Now static.
2089 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2090
f1b54466
PE
2091 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2092 (crypto_hash_function): Now static.
2093 Fix pointer signedness problems. Avoid unnecessary initializations.
2094
a9f737ee
CY
20952011-05-27 Chong Yidong <cyd@stupidchicken.com>
2096
2097 * termhooks.h (Vselection_alist): Make it terminal-local.
2098
2099 * terminal.c (create_terminal): Initialize it.
2100
2101 * xselect.c: Support for clipboard managers.
2102 (Vselection_alist): Move to termhooks.h as terminal-local var.
2103 (LOCAL_SELECTION): New macro.
2104 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2105 (symbol_to_x_atom): Remove gratuitous arg.
2106 (x_handle_selection_request, lisp_data_to_selection_data)
2107 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2108 (x_own_selection, x_get_local_selection, x_convert_selection):
2109 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2110 (some_frame_on_display): Delete unused function.
2111 (Fx_own_selection_internal, Fx_get_selection_internal)
2112 (Fx_disown_selection_internal, Fx_selection_owner_p)
2113 (Fx_selection_exists_p): New optional frame arg.
2114 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2115 (x_handle_selection_clear): Don't treat other terminals with the
2116 same keyboard specially. Use the terminal-local Vselection_alist.
2117 (x_clear_frame_selections): Use Frun_hook_with_args.
2118
2119 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2120
2121 * xterm.h: Add support for those atoms.
2122
e067f0c1
CY
21232011-05-26 Chong Yidong <cyd@stupidchicken.com>
2124
2125 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2126 (converted_selections, conversion_fail_tag): New global variables.
2127 (x_selection_request_lisp_error): Free the above.
2128 (x_get_local_selection): Remove unnecessary code.
2129 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2130 of converted selections stored in converted_selections.
2131 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2132 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2133 (x_convert_selection): New function.
2134 (x_handle_selection_event): Simplify.
2135 (x_get_foreign_selection): Don't ignore incoming requests while
2136 waiting for an answer; this will fail when we implement
2137 SAVE_TARGETS, and seems unnecessary anyway.
2138 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2139 (Vx_sent_selection_functions): Doc fix.
2140
0f4aebc0
LL
21412011-05-26 Leo Liu <sdl.web@gmail.com>
2142
2143 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2144
e61124cd
YM
21452011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2146
2147 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2148
2149 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2150 for fringe update if it has periodic bitmap.
2151 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2152 and fringe_bitmap_periodic_p.
2153
2154 * fringe.c (get_fringe_bitmap_data): New function.
2155 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2156 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2157 row. Mark glyph row for fringe update if periodicity changed.
2158
2159 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2160 for fringe update unless it has periodic bitmap.
2161
f16d9837
KH
21622011-05-25 Kenichi Handa <handa@m17n.org>
2163
2164 * xdisp.c (get_next_display_element): Set correct it->face_id for
2165 a static composition.
2166
e1b90ef6
LL
21672011-05-24 Leo Liu <sdl.web@gmail.com>
2168
2169 * deps.mk (fns.o):
2170 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2171
2172 * fns.c (crypto_hash_function, Fsha1): New function.
2173 (Fmd5): Use crypto_hash_function.
2174 (syms_of_fns): Add Ssha1.
2175
7400048f
PE
21762011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2177
2178 * gnutls.c: Remove unused macros.
2179 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2180 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2181 Remove macros that are defined and never used.
2182 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2183
abb71cf4
CY
21842011-05-22 Chong Yidong <cyd@stupidchicken.com>
2185
2186 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2187 (Fx_get_selection_internal): Minor cleanup.
2188 (Fx_own_selection_internal): Rename arguments for consistency with
2189 select.el.
2190
6307db39
PE
21912011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2192
2193 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2194
f3d4e0a4
CY
21952011-05-22 Chong Yidong <cyd@stupidchicken.com>
2196
2197 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2198
4d8ade89
YM
21992011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2200
2201 * dispnew.c (scrolling_window): Don't exclude the case that the
2202 last enabled row in the desired matrix touches the bottom boundary.
2203
32078c8d
GM
22042011-05-21 Glenn Morris <rgm@gnu.org>
2205
2206 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2207 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2208 and add some more files.
32078c8d 2209
7285dc67
EZ
22102011-05-20 Eli Zaretskii <eliz@gnu.org>
2211
2212 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2213 report_file_error introduced by the change from 2011-05-07.
2214
89d1bd22
PE
22152011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2216
2217 * systime.h (Time): Define only if emacs is defined.
2218 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2219 where the include path doesn't have X11/X.h by default. See
2220 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2221
e23640bb 22222011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2223
2224 * composite.c (find_automatic_composition): Fix previous change.
2225
b9704ad9
GM
22262011-05-20 Glenn Morris <rgm@gnu.org>
2227
2228 * lisp.mk: New file, split from Makefile.in.
2229 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2230 (shortlisp): Remove.
2231 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2232
4a720484
GM
22332011-05-19 Glenn Morris <rgm@gnu.org>
2234
2235 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2236 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2237 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2238 (lisp): Set the order to that of loadup.el.
2239 (shortlisp): Make it a copy of $lisp.
2240 (SOME_MACHINE_LISP): Remove.
2241 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2242 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2243
a28d4396
KH
22442011-05-18 Kenichi Handa <handa@m17n.org>
2245
2246 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2247 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2248 (find_automatic_composition): Mostly rewrite for efficiency.
2249
a2b1fa8e
JB
22502011-05-18 Juanma Barranquero <lekktu@gmail.com>
2251
2252 * makefile.w32-in: Update dependencies.
2253
8e1f5610
CS
22542011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2255
2256 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2257 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2258
7025ee00 22592011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2260
cdfa6eab
PE
2261 Fix some integer overflow issues, such as string length overflow.
2262
06d6db33
PE
2263 * insdel.c (count_size_as_multibyte): Check for string overflow.
2264
2b4560a8
PE
2265 * character.c (lisp_string_width): Check for string overflow.
2266 Use EMACS_INT, not int, for string indexes and lengths; in
2267 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2268 the resulting string length overflows an EMACS_INT; instead,
2269 report a string overflow if no precision given. When checking for
2270 precision exhaustion, use a check that cannot possibly have
2271 integer overflow. (Bug#8675)
2272 * character.h (lisp_string_width): Adjust to new signature.
2273
cb93f9be
PE
2274 * alloc.c (string_overflow): New function.
2275 (Fmake_string): Use it. This doesn't change behavior, but saves
2276 a few bytes and will simplify future changes.
2277 * character.c (string_escape_byte8): Likewise.
2278 * lisp.h (string_overflow): New decl.
2279
1a1f3366
PE
2280 Fixups, following up to the user-interface timestamp change.
2281 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2282 for UI timestamps, instead of unsigned long.
9fbd6841
PE
2283 * msdos.c (mouse_get_pos): Likewise.
2284 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
2285 * w32gui.h (Time): Define by including "systime.h" rather than by
2286 declaring it ourselves. (Bug#8664)
2287
d4e3e4d3
PE
2288 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2289 * image.c (clear_image_cache): Likewise.
2290
f6a24d19
PE
2291 * term.c (term_mouse_position): Don't assume time_t wraparound.
2292
08dc5ae6
PE
2293 Be more systematic about user-interface timestamps.
2294 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
2295 and sometimes 'EMACS_UINT', to represent these timestamps.
2296 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
2297 This makes the code easier to follow, and makes it easier to catch
2298 integer overflow bugs such as Bug#8664.
2299 * frame.c (Fmouse_position, Fmouse_pixel_position):
2300 Use Time, not unsigned long, for user-interface timestamps.
2301 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2302 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2303 * keyboard.h (last_event_timestamp): Likewise.
2304 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2305 * menu.h (xmenu_show): Likewise.
2306 * term.c (term_mouse_position): Likewise.
2307 * termhooks.h (struct input_event.timestamp): Likewise.
2308 (struct terminal.mouse_position_hook): Likewise.
2309 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2310 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2311 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2312 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2313 what it was before.
2314 * menu.h, termhooks.h: Include "systime.h", for Time.
2315
8e55734a
PE
2316 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2317 Don't assume that the difference between two unsigned long values
2318 can fit into an integer. At this point, we know button_down_time
2319 <= event->timestamp, so the difference must be nonnegative, so
2320 there's no need to cast the result if double-click-time is
2321 nonnegative, as it should be; check that it's nonnegative, just in
2322 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2323 apart (about 25 days). (Bug#8664)
8e55734a 2324
841f1b75 2325 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2326 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2327
3e26f69c
PE
2328 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2329 that always fit in int. Use a sentinel instead of a counter, to
2330 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2331 * frame.h (struct frame): Use int for menu_bar_items_used
2332 instead of EMACS_INT, since it always fits in int.
3e26f69c 2333
5cc152c0
PE
2334 * menu.c (grow_menu_items): Check for int overflow.
2335
d89eb65e
PE
2336 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2337
5235bd3e
PE
2338 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2339 Before, the code was not consistent. These values cannot exceed
2340 2**31 - 1 so there's no need to make them unsigned.
2341 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2342 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2343 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2344 as modifiers.
2345 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2346
bc827e23
PE
2347 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2348 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2349 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2350 presumably because the widths might not match.
2351
78eb494e
PE
2352 * window.c (size_window): Avoid needless test at loop start.
2353
04f2d78b
CB
23542011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2355
2356 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2357
d2fc7e3d 23582011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2359
2360 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2361
d2fc7e3d 23622011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2363
2364 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2365 `width' to `bar_area_x' and `bar_area_width', respectively.
2366 (x_scroll_run): Take account of fringe background extension.
2367
04f2d78b
CB
2368 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2369 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2370 `bar_area_width', respectively.
2371 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2372 background extension.
2373
79b70037
GM
23742011-05-10 Jim Meyering <meyering@redhat.com>
2375
2376 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2377
2f142cc5
JB
23782011-05-10 Juanma Barranquero <lekktu@gmail.com>
2379
2380 * image.c (Finit_image_library): Return t for built-in image types,
2381 like pbm and xbm. (Bug#8640)
2382
57679c86
AS
23832011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2384
2385 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2386
888c9e86
EZ
23872011-05-07 Eli Zaretskii <eliz@gnu.org>
2388
b0512a1d
EZ
2389 * w32console.c (Fset_screen_color): Doc fix.
2390 (Fget_screen_color): New function.
2391 (syms_of_ntterm): Defsubr it.
2392
7285dc67
EZ
2393 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2394 unlink the temporary file if Fcall_process didn't create it in the
2395 first place.
2396 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2397 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2398 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2399 cue to call_process_cleanup not to close that handle.
2400
4d3fcc8e
BK
24012011-05-07 Ben Key <bkey76@gmail.com>
2402
2403 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2404 one of two shell specific rules, either bootstrap-temacs-CMD or
2405 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2406 to the previous implementation of the bootstrap-temacs rule.
2407 The bootstrap-temacs-CMD rule is similar to the previous
2408 implementation of the bootstrap-temacs rule except that it
2409 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2410 variable.
2411
2412 These changes, along with some changes to nt/configure.bat,
2413 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2414 earlier fix to add support for --cflags and --ldflags options
2415 that include quotes so that it works whether make uses cmd or
2416 sh as the shell.
2417
b4289b64
MA
24182011-05-06 Michael Albinus <michael.albinus@gmx.de>
2419
2420 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2421 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2422 is a constant.
2423 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2424 a string. Handle both cases.
2425 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2426 (Fdbus_register_method): Use Qinvalid_function.
2427
af4c0e28
JB
24282011-05-06 Juanma Barranquero <lekktu@gmail.com>
2429
2430 * makefile.w32-in: Update dependencies.
2431 (LISP_H): Add inttypes.h and stdin.h.
2432 (PROCESS_H): Add unistd.h.
2433
c51453d9
EZ
24342011-05-06 Eli Zaretskii <eliz@gnu.org>
2435
2436 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2437 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2438
8ff0ac3c 24392011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2440
4c4b566b
PE
2441 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2442
aab2b9b5
PE
2443 * term.c (vfatal): Remove stray call to va_end.
2444 It's not needed and the C Standard doesn't allow it here anyway.
2445
c378da0b
PE
2446 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2447 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2448
288b08c7
PE
2449 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2450 bytes.
2451
e3601888
PE
2452 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2453
db6c0e74
PE
2454 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2455
dd5963ea
PE
2456 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2457
88c9450f
PE
2458 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2459
2f9442b8
PE
2460 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2461
c032b5f8
PE
2462 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2463 * charset.c (Fdefine_charset_internal): Don't initialize
2464 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2465 32-bit int (Bug#8600).
a108c10b
PE
2466
2467 * lread.c (read_integer): Be more consistent with string-to-number.
2468 Use string_to_number to do the actual conversion; this avoids
2469 rounding errors and fixes some other screwups. Without this fix,
2470 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2471 (digit_to_number): Move earlier, for benefit of read_integer.
2472 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2473 not a digit in any supported base. (Bug#8602)
a108c10b 2474
ad5f9eea
PE
2475 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2476
aec1708a
PE
2477 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2478 to match comment at start of function. This also removes a
2479 GCC warning about overflow in a 32+64-bit port.
2480
47be4ab5
PE
2481 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2482
371cac43
PE
2483 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2484 Reported by Stefan Monnier in
2485 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2486 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2487 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2488
d01a7826
PE
2489 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2490 (EMACS_UINTPTR): Likewise, with uintptr_t.
2491
7fd47d5c
PE
2492 * lisp.h: Prefer 64-bit EMACS_INT if available.
2493 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2494 on 32-bit hosts that have 64-bit int, so that they can access
2495 large files.
122b0c86
PE
2496 However, temporarily disable this change unless the temporary
2497 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2498
8727937b
PE
2499 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2500
8ac068ac
PE
2501 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2502 This removes an assumption that EMACS_INT and long are the same
2503 width as pointers. The assumption is true for Emacs porting targets
2504 now, but we want to make other targets possible.
2505 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2506 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2507 In the rest of the code, change types of integers that hold casted
2508 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2509 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2510 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2511 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2512 No need to cast type when ORing.
2513 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2514 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2515 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2516 assume EMACS_INT is the same width as char *.
2517 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2518 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2519 Remove no-longer-needed casts.
2520 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2521 (xg_tool_bar_help_callback, xg_make_tool_item):
2522 Use EMACS_INTPTR to hold an integer
2523 that will be cast to void *; this can avoid a GCC warning
2524 if EMACS_INT is not the same width as void *.
2525 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2526 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2527 (current_message_1, set_message_1):
2528 Use a local to convert to proper width without a cast.
2529 * xmenu.c (dialog_selection_callback): Likewise.
2530
ede49d71
PE
2531 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2532 Also, don't assume VALBITS / RAND_BITS is less than 5,
2533 and don't rely on undefined behavior when shifting a 1 left into
2534 the sign bit.
2535 * lisp.h (get_random): Change signature to match.
2536
2f30ecd0
PE
2537 * lread.c (hash_string): Use size_t, not int, for hash computation.
2538 Normally we prefer signed values; but hashing is special, because
2539 it's better to use unsigned division on hash table sizes so that
2540 the remainder is nonnegative. Also, size_t is the natural width
2541 for hashing into memory. The previous code used 'int', which doesn't
2542 retain enough info to hash well into very large tables.
2543 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2544
2a866e7b
PE
2545 * dbusbind.c: Don't possibly lose pointer info when converting.
2546 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2547 Use XPNTR rather than XHASH, so that the high-order bits of
2548 the pointer aren't lost when converting through void *.
2549
51639eac
PE
2550 * eval.c (Fautoload): Don't double-shift a pointer.
2551
92394119
PE
2552 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2553
dbdb9a7c
JB
25542011-05-06 Juanma Barranquero <lekktu@gmail.com>
2555
2556 * gnutls.c (DEF_GNUTLS_FN):
2557 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2558
db7a0b4f
AS
25592011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2560
2561 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2562 marker. (Bug#8610)
2563
f7ff1b0f 25642011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2565
2566 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2567 New version that can reserve upto 2GB of heap space.
2568
f7ff1b0f 25692011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2570
2571 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2572
639c109b
TZ
25732011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2574
2575 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2576 `gnutls_certificate_set_x509_key_file'.
2577
d2127135
JB
25782011-05-05 Juanma Barranquero <lekktu@gmail.com>
2579
2580 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2581 Update dependencies.
2582
e968f4f3
JB
25832011-05-04 Juanma Barranquero <lekktu@gmail.com>
2584
2585 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2586 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2587 Remove unused parameter `fildes'.
2588 * process.c (read_process_output, send_process): Don't pass it.
2589
84d358f0
JB
25902011-05-04 Juanma Barranquero <lekktu@gmail.com>
2591
2592 Fix previous change: the library cache is defined in w32.c.
2593 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2594 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2595
0898ca10
JB
25962011-05-04 Juanma Barranquero <lekktu@gmail.com>
2597
2598 Implement dynamic loading of GnuTLS on Windows.
2599
2600 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2601 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2602 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2603 Declare.
2604
2605 * gnutls.c (Qgnutls_dll): Define.
2606 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2607 (gnutls_*): Declare function pointers.
2608 (init_gnutls_functions): New function to initialize function pointers.
2609 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2610 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2611 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2612 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2613 (emacs_gnutls_write, emacs_gnutls_read)
2614 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2615 (Fgnutls_available_p): New function.
2616 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2617 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2618 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2619
2620 * image.c: Include w32.h.
2621 (Vimage_type_cache): Delete.
2622 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2623 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2624 (w32_delayed_load): Move to w32.c.
2625
2626 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2627
2628 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2629 (w32_delayed_load): Move from image.c. When loading a library, record
2630 its filename in the :loaded-from property of the library id.
2631 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2632 Initialize and staticpro them.
2633 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2634
2635 * process.c: Include lisp.h before w32.h, not after.
2636 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2637 instead of gnutls_record_check_pending.
2638
2639 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2640
ff4de4aa
TZ
26412011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2642
2643 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2644 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2645 as passed in.
2646
abe95abb
JD
26472011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2648
2649 * xterm.c (x_set_frame_alpha): Do not set property on anything
2650 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2651
e16e55d4
JB
26522011-05-02 Juanma Barranquero <lekktu@gmail.com>
2653
2654 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2655
bafcf6a5
JB
26562011-05-02 Juanma Barranquero <lekktu@gmail.com>
2657
2658 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2659 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2660 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2661 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2662 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2663 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2664 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2665 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2666 (Qgnutls_bootprop_callbacks_verify): Make static.
2667
e7a6747f
AS
26682011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2669
19ed11ba
AS
2670 * callproc.c: Indentation fixup.
2671
e7a6747f 2672 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2673 (wait_for_termination, interruptible_wait_for_termination):
2674 Move after wait_for_termination_1.
e7a6747f 2675
1ef14cb4
LMI
26762011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2677
2678 * sysdep.c (interruptible_wait_for_termination): New function
2679 which is like wait_for_termination, but allows keyboard
2680 interruptions.
2681
2682 * callproc.c (Fcall_process): Add (:file "file") as an option for
2683 the STDOUT buffer.
2684 (Fcall_process_region): Ditto.
2685
330d880c
EZ
26862011-04-30 Eli Zaretskii <eliz@gnu.org>
2687
8db90b73
EZ
2688 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2689 rather than `XVECTOR (FOO)->size'.
2690
330d880c
EZ
2691 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2692 inttypes.h, as a gnulib replacement is used if it not available in
2693 system headers.
2694
15cbd324
EZ
26952011-04-21 Eli Zaretskii <eliz@gnu.org>
2696
2697 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2698 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2699 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2700
2701 * coding.c (coding_alloc_by_realloc): Error out if destination
2702 will grow beyond MOST_POSITIVE_FIXNUM.
2703 (decode_coding_emacs_mule): Abort if there isn't enough place in
2704 charbuf for the composition carryover bytes. Reserve an extra
2705 space for up to 2 characters produced in a loop.
2706 (decode_coding_iso_2022): Abort if there isn't enough place in
2707 charbuf for the composition carryover bytes.
2708
27092011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 2710
ae940cca
EZ
2711 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2712 aborting when %lld or %lll format is passed.
2713 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2714 %llo or %llx format is passed. (Bug#8545)
2715
03ab8921
EZ
2716 * window.c (window_scroll_line_based): Use a marker instead of
2717 simple variables to record original value of point. (Bug#7952)
2718
afda1437
EZ
2719 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2720 produced by %s or %c overflows available buffer space. (Bug#8545)
2721
f76dee0c
PE
27222011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2723
2724 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2725 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2726
fdc5744d
JB
27272011-04-28 Juanma Barranquero <lekktu@gmail.com>
2728
2729 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2730
638f053a
JB
27312011-04-28 Juanma Barranquero <lekktu@gmail.com>
2732
2733 * keyboard.c (Qdelayed_warnings_hook): Define.
2734 (command_loop_1): Run `delayed-warnings-hook'
2735 if Vdelayed_warnings_list is non-nil.
2736 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2737 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2738
d178f871
EZ
27392011-04-28 Eli Zaretskii <eliz@gnu.org>
2740
2741 * doprnt.c (doprnt): Don't return value smaller than the buffer
2742 size if the message was truncated. (Bug#8545).
2743
b124fd93
JB
27442011-04-28 Juanma Barranquero <lekktu@gmail.com>
2745
2746 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2747 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2748
e810457d
PE
27492011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2750
2751 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2752
ea51cceb
JB
27532011-04-27 Juanma Barranquero <lekktu@gmail.com>
2754
2755 * makefile.w32-in: Update dependencies.
2756
94dcfacf
EZ
27572011-04-27 Eli Zaretskii <eliz@gnu.org>
2758
2759 Improve `doprnt' and its usage. (Bug#8545)
2760 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2761 `format_end'. Remove support for %l as a conversion specifier.
2762 Don't use xrealloc. Improve diagnostics when the %l size modifier
2763 is used. Update the commentary.
2764
2765 * eval.c (verror): Simplify calculation of size_t.
2766
2767 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2768 messages.
2769
f61f41d7
PE
27702011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2771
2772 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2773 change.
2774
96fb4434
PE
27752011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2776
2777 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2778 This makes this file independent of the recent pseudovector change.
2779
671875da 27802011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2781
69e9b5a3
PE
2782 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2783
b5f869a7 2784 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2785 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2786 Remove unused local.
c8926152 2787 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2788
841a1577 2789 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2790 GCC 4.6.0 optimizes based on type-based alias analysis.
2791 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2792 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2793 != &v->size, and therefore "v->size = 1; b->size = 2; return
2794 v->size;" must therefore return 1. This assumption is incorrect
2795 for Emacs, since it type-puns struct Lisp_Vector * with many other
2796 types. To fix this problem, this patch adds a new type struct
f904488f 2797 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2798 and pseudovectors, and helps optimizing compilers not get fooled
2799 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2800 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2801 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2802 the size member.
eab3844f
PE
2803 (XSETPVECTYPE): Rewrite in terms of new macro.
2804 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2805 This is a bit clearer, and further avoids the possibility of
2806 undesirable aliasing.
2807 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2808 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2809 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2810 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2811 (ASIZE): Now uses header.size rather than size.
2812 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2813 to avoid the hassle of writing XVECTOR (foo)->header.size.
2814 (struct vectorlike_header): New type.
eab3844f
PE
2815 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2816 object, to help avoid aliasing.
2817 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2818 (SUBRP): Likewise, since Lisp_Subr is a special case.
2819 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2820 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2821 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2822 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2823 changed to be "header.size" and "header.next".
2824 * buffer.h (struct buffer): Likewise.
2825 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2826 * frame.h (struct frame): Likewise.
2827 * process.h (struct Lisp_Process): Likewise.
2828 * termhooks.h (struct terminal): Likewise.
2829 * window.c (struct save_window_data, struct saved_window): Likewise.
2830 * window.h (struct window): Likewise.
2831 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2832 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2833 * buffer.c (init_buffer_once): Likewise.
2834 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2835 special case.
2836 * process.c (Fformat_network_address): Use local var for size,
2837 for brevity.
2838
0df1eac5
PE
2839 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2840
847ab9d1 2841 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2842 * data.c (atof): Remove decl; no longer used or needed.
2843 (digit_to_number): Move to lread.c.
2844 (Fstring_to_number): Use new string_to_number function, to be
2845 consistent with how the Lisp reader treats infinities and NaNs.
2846 Do not assume that floating-point numbers represent EMACS_INT
2847 without losing information; this is not true on most 64-bit hosts.
2848 Avoid double-rounding errors, by insisting on integers when
2849 parsing non-base-10 numbers, as the documentation specifies.
2850 * lisp.h (string_to_number): New decl, replacing ...
2851 (isfloat_string): Remove.
bc0a5c13 2852 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2853 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2854 appears to have been a coding error. Similarly, do not accept
2855 strings like +-1e0 as floating point numbers. Do not report
2856 overflow for integer overflows unless the base is not 10 which
2857 means we have no simple and reliable way to continue.
2858 Break out the floating-point parsing into a new
2859 function string_to_number, so that Fstring_to_number parses
2860 floating point numbers consistently with the Lisp reader.
04f2d78b 2861 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2862 (E_CHAR, EXP_INT): Remove, replacing with ...
2863 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2864 (string_to_number): New function, replacing isfloat_string.
2865 This function checks for valid syntax and produces the resulting
2866 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2867 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2868 so that overflow for non-base-10 numbers is reported only when
2869 there's no portable and simple way to convert to floating point.
452f4150 2870
67769ffc
PE
2871 * textprop.c (set_text_properties_1): Rewrite for clarity,
2872 and to avoid GCC warning about integer overflow.
2873
c20db43f
PE
2874 * intervals.h (struct interval): Use EMACS_INT for members
2875 where EMACS_UINT might cause problems. See
2876 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2877 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2878 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2879 All uses changed.
37aa2f85
PE
2880 (offset_intervals): Tell GCC not to worry about length overflow
2881 when negating a negative length.
c20db43f 2882
2538aa2f
PE
2883 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2884 (overrun_check_free): Likewise.
2885
f2d3008d
PE
2886 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2887 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2888 word size.
2889
ec8df744
PE
2890 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2891 (gnutls_make_error): Rename local to avoid shadowing.
2892 (gnutls_emacs_global_deinit): ifdef out; not used.
2893 (Fgnutls_boot): Use const for pointer to readonly storage.
2894 Comment out unused local. Fix pointer signedness problems.
2895
640ee02d
PE
2896 * lread.c (openp): Don't stuff size_t into an 'int'.
2897 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2898 about possible signed overflow.
2899
6048fb2a
PE
2900 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2901 (GDK_KEY_g): Don't define if already defined.
2902 (xg_prepare_tooltip): Avoid pointer signedness problem.
2903 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2904
fa3c87e1
PE
2905 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2906 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2907
2172544b
PE
2908 * xfns.c (Fx_window_property): Simplify a bit,
2909 to make a bit faster and to avoid GCC 4.6.0 warning.
2910 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2911
9b821a21
PE
2912 * fns.c (internal_equal): Don't assume size_t fits in int.
2913
3c616cfa
PE
2914 * alloc.c (compact_small_strings): Tighten assertion a little.
2915
c2982e87
PE
2916 Replace pEd with more-general pI, and fix some printf arg casts.
2917 * lisp.h (pI): New macro, generalizing old pEd macro to other
2918 conversion specifiers. For example, use "...%"pI"d..." rather
2919 than "...%"pEd"...".
2920 (pEd): Remove. All uses replaced with similar uses of pI.
2921 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2922 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2923 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2924 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2925 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2926 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2927 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2928 64-bit hosts.
2929 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2930 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2931 * print.c (safe_debug_print, print_object): Likewise.
2932 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2933 to int.
6f04d126
PE
2934 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2935 avoiding the 0 flag, which is not portable.
c2982e87
PE
2936 * process.c (Fmake_network_process): Use pI to avoid cast.
2937 * region-cache.c (pp_cache): Likewise.
2938 * xdisp.c (decode_mode_spec): Likewise.
2939 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2940 behavior on 64-bit hosts with printf arg.
6f04d126 2941 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2942 (x_stop_queuing_selection_requests): Likewise.
2943 (x_get_window_property): Don't truncate byte count to an 'int'
2944 when tracing.
0b432f21 2945
5e073ec7
PE
2946 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2947 here, since it parses constructs like leading '-' and spaces,
2948 which are not wanted; and it overflows with large numbers.
2949 Instead, simply match F[0-9]+, which is what is wanted anyway.
2950
36372bf9
PE
2951 * alloc.c: Remove unportable assumptions about struct layout.
2952 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2953 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2954 (allocate_vectorlike, make_pure_vector): Use the new macros,
2955 plus offsetof, to remove unportable assumptions about struct layout.
2956 These assumptions hold on all porting targets that I know of, but
2957 they are not guaranteed, they're easy to remove, and removing them
2958 makes further changes easier.
2959
0b432f21
PE
2960 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2961 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2962 (string_overrun_cookie): Now const. Use initializers that
2963 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2964 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2965 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2966 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2967 multiple of sizeof (EMACS_INT); it need not be, if
2968 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2969 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2970
895009e1
JB
29712011-04-26 Juanma Barranquero <lekktu@gmail.com>
2972
2973 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2974
6a7a1b0b
TZ
29752011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2976
2977 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2978 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2979 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2980
841a1577 29812011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2982
2983 * lisp.h (Qdebug): List symbol.
895009e1 2984 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2985 * keyboard.c (debug-on-event): New variable.
2986 (handle_user_signal): Break into debugger when debug-on-event
2987 matches the current signal symbol.
2988
f2d3ba6f
DN
29892011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2990
2991 * alloc.c (check_sblock, check_string_bytes)
2992 (check_string_free_list): Convert to standard C.
2993
42ce4c63
TZ
29942011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2995
2996 * w32.c (emacs_gnutls_push): Fix typo.
2997
825cd63c
EZ
29982011-04-25 Eli Zaretskii <eliz@gnu.org>
2999
fb11d64d
EZ
3000 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3001 "cast to pointer from integer of different size".
3002
825cd63c
EZ
3003 Improve doprnt and its use in verror. (Bug#8545)
3004 * doprnt.c (doprnt): Document the set of format control sequences
3005 supported by the function. Use SAFE_ALLOCA instead of always
3006 using `alloca'.
3007
3008 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3009 is one byte too soon. Don't use xrealloc; instead xfree and
3010 xmalloc anew.
3011
e061a11b
TZ
30122011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3013
3014 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3015 callbacks stage.
3016
3017 * gnutls.c: Renamed global_initialized to
3018 gnutls_global_initialized. Added internals for the
3019 :verify-hostname-error, :verify-error, and :verify-flags
3020 parameters of `gnutls-boot' and documented those parameters in the
3021 docstring. Start callback support.
9173deec
JB
3022 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3023 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3024 on error. Return error code.
e061a11b
TZ
3025 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3026 (emacs_gnutls_read): Likewise.
3027 (Fgnutls_boot): Return handshake error code.
3028 (emacs_gnutls_handle_error): New function.
3029 (wsaerror_to_errno): Likewise.
3030
3031 * w32.h (emacs_gnutls_pull): Add prototype.
3032 (emacs_gnutls_push): Likewise.
3033
3034 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3035 (emacs_gnutls_push): Likewise.
3036
30372011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3038
3039 * process.c (wait_reading_process_output): Check if GnuTLS
3040 buffered some data internally if no FDs are set for TLS
3041 connections.
3042
3043 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3044 (LIBS): Link to USER_LIBS.
3045 ($(BLD)/gnutls.$(0)): New target.
3046
fa6996bc
EZ
30472011-04-24 Eli Zaretskii <eliz@gnu.org>
3048
eb35682e
EZ
3049 * xdisp.c (handle_single_display_spec): Rename the
3050 display_replaced_before_p argument into display_replaced_p, to
3051 make it consistent with the commentary. Fix typos in the
3052 commentary.
3053
e2ad650c
EZ
3054 * textprop.c (syms_of_textprop): Remove dead code.
3055 (copy_text_properties): Delete obsolete commentary about an
3056 interface that was deleted long ago. Fix typos in the description
3057 of arguments.
3058
1b2de274
EZ
3059 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3060 to changes in oldXMenu/XMenu.h from 2011-04-16.
3061 <menu_help_message, prev_menu_help_message>: Constify.
3062 (IT_menu_make_room): menu->help_text is now `const char **';
3063 adjust.
3064
3065 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3066 to changes in oldXMenu/XMenu.h from 2011-04-16.
3067 (struct XMenu): Declare `help_text' `const char **'.
3068
3069 * xfaces.c <Qunspecified>: Make extern again.
3070
3071 * syntax.c: Include sys/types.h before including regex.h, as
3072 required by Posix.
3073
762b15be
EZ
3074 * doc.c (get_doc_string): Improve the format passed to `error'.
3075
3076 * doprnt.c (doprnt): Improve commentary.
3077
3078 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3079
3080 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3081 them with etags.
3082
f1052e5d
EZ
3083 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3084 changes in globals.h immediately force recompilation.
762b15be
EZ
3085 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3086 $(CURDIR)/s/ms-w32.h.
3087 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3088
fa6996bc
EZ
3089 * character.c (Fchar_direction): Function deleted.
3090 (syms_of_character): Don't defsubr it.
3091 <char-direction-table>: Deleted.
3092
e6c3da20
EZ
30932011-04-23 Eli Zaretskii <eliz@gnu.org>
3094
3095 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3096 * doprnt.c: Include limits.h.
3097 (SIZE_MAX): New macro.
04f2d78b
CB
3098 (doprnt): Return a size_t value. 2nd arg is now size_t.
3099 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3100 Improve overflow protection. Support `l' modifier for integer
3101 conversions. Support %l conversion. Don't assume an EMACS_INT
3102 argument for integer conversions and for %c.
3103
3104 * lisp.h (doprnt): Restore prototype.
3105
3106 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3107 $(SRC)/character.h.
3108
3109 * Makefile.in (base_obj): Add back doprnt.o.
3110
3111 * deps.mk (doprnt.o): Add back prerequisites.
3112 (callint.o): Depend on character.h.
3113
3114 * eval.c (internal_lisp_condition_case): Include the handler
3115 representation in the error message.
3116 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3117 when breaking from the loop.
3118
3119 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3120
3121 * callint.c (Fcall_interactively): When displaying error message
3122 about invalid control letter, pass the character's codepoint, not
3123 a pointer to its multibyte form. Improve display of the character
3124 in octal and display also its hex code.
3125
3126 * character.c (char_string): Use %x to display the (unsigned)
3127 codepoint of an invalid character, to avoid displaying a bogus
3128 negative value.
3129
3130 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3131 `error', not SYMBOL_NAME itself.
3132
3133 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3134 character arguments to `error'.
3135
3136 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3137 to `error' in error message about FINAL_CHAR argument. Make sure
3138 FINAL_CHAR is a character, and use %c when it is passed as
3139 argument to `error'.
3140
4ffd0d6b 31412011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3142
3143 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3144
3145 * w32.c: Include <time.h>.
3146 (sys_localtime): New function.
3147
4ffd0d6b 31482011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3149
3150 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3151
4ffd0d6b 3152 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3153
4ffd0d6b 31542011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3155
4ffd0d6b
GM
3156 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3157 zombies (Bug#8467).
aac0c6e3 3158
04c56954
EZ
31592011-04-19 Eli Zaretskii <eliz@gnu.org>
3160
3161 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3162 gl_state.e_property when gl_state.object is Qt.
3163
3164 * insdel.c (make_gap_larger): Remove limitation of buffer size
3165 to <= INT_MAX.
3166
16a43933
CY
31672011-04-18 Chong Yidong <cyd@stupidchicken.com>
3168
3169 * xdisp.c (lookup_glyphless_char_display)
3170 (produce_glyphless_glyph): Handle cons cell entry in
3171 glyphless-char-display.
3172 (Vglyphless_char_display): Document it.
3173
3174 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3175 glyphless-char-display.
3176
4581706e
CY
31772011-04-17 Chong Yidong <cyd@stupidchicken.com>
3178
3179 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3180
3181 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3182
3183 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3184 definition for no-X builds.
3185
4887c6e2 31862011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3187
fd35b6f9
PE
3188 Static checks with GCC 4.6.0 and non-default toolkits.
3189
5c1ccb01
PE
3190 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3191
006c5daa
PE
3192 * process.c (keyboard_bit_set): Define only if SIGIO.
3193 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3194 (send_process): Repair possible setjmp clobbering.
3195
efc736d3
PE
3196 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3197
4e2fe2e6
PE
3198 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3199
f97334a2
PE
3200 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3201
4e75f29d
PE
3202 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3203 Define only if needed.
3204
90efadd1
PE
3205 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3206 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3207 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3208
3c647824
PE
3209 * dispextern.h (struct redisplay_interface): Rename param
3210 to avoid shadowing.
e264f262 3211 * termhooks.h (struct terminal): Likewise.
761383f4 3212 * xterm.c (xembed_send_message): Likewise.
3c647824 3213
b58c5c4a
PE
3214 * insdel.c (make_gap_smaller): Define only if
3215 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3216
cad59032
PE
3217 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3218 it.
3219
c339dc2e
PE
3220 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3221 so that we aren't warned about unused symbols.
3222
91a3e27b
PE
3223 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3224
399c71d3 3225 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3226
8ffc96f5
PE
3227 * xfns.c (x_real_positions): Mark locals as initialized.
3228
eef9bc79
PE
3229 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3230
098db9dd
PE
3231 * xterm.c: Fix problems found by static analysis with other toolkits.
3232 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3233 (x_dispatch_event): Declare static if USE_GTK, and
3234 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3235 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3236 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3237 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3238 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3239
eb18f6cc
PE
3240 * xmenu.c (menu_help_callback): Pointer type fixes.
3241 Use const pointers when pointing at readonly data. Avoid pointer
3242 signedness clashes.
3243 (FALSE): Remove unused macro.
3244 (update_frame_menubar): Remove unused decl.
3245
1fe72bf8
PE
3246 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3247
60d9e1db
PE
3248 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3249 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3250 (single_menu_item): Rename local to avoid shadowing.
3251
39261c26
PE
3252 * keyboard.c (make_lispy_event): Remove unused local var.
3253
018c5e19
PE
3254 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3255 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3256
63d2b86e
PE
3257 * bitmaps: Change bitmaps from unsigned char back to the X11
3258 compatible char. Avoid the old compiler warnings about
3259 out-of-range initializers by using, for example, '\xab' rather
3260 than 0xab.
3261
aefd87e1
PE
3262 * xgselect.c (xgselect_initialize): Check vs interface
3263 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3264
bf501fb9
PE
3265 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3266
e9829fdf
PE
3267 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3268 to read-only memory.
3269
1086c095
PE
3270 * fns.c (vector): Remove; this old hack is no longer needed.
3271
2baccd04 3272 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3273 Remove unused var.
dde42981 3274 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 3275
72391843 3276 * xrdb.c (x_load_resources): Omit unused local.
3565b346 3277
436c16df 3278 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 3279 (x_window): Rename locals to avoid shadowing.
dc5ddd85 3280 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 3281
92bb796d 3282 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 3283 (x_term_init): Remove local to avoid shadowing.
92bb796d 3284
764430a3 3285 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
3286
3287 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3288 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3289
d1dfb56c
EZ
32902011-04-16 Eli Zaretskii <eliz@gnu.org>
3291
c4354cb4
EZ
3292 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3293
d1dfb56c
EZ
3294 Fix regex.c, syntax.c and friends for buffers > 2GB.
3295 * syntax.h (struct gl_state_s): Declare character position members
3296 EMACS_INT.
3297
3298 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3299
04f2d78b
CB
3300 * textprop.c (verify_interval_modification, interval_of):
3301 Declare arguments EMACS_INT.
d1dfb56c
EZ
3302
3303 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3304 EMACS_INT.
3305
3306 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3307
3308 * indent.c (Fvertical_motion): Local variable it_start is now
3309 EMACS_INT.
3310
3311 * regex.c (re_match, re_match_2, re_match_2_internal)
3312 (bcmp_translate, regcomp, regexec, print_double_string)
3313 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3314 (re_compile_pattern, re_exec): Declare arguments and local
3315 variables `size_t' and `ssize_t' and return values `regoff_t', as
3316 appropriate.
3317 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3318 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3319 <compile_stack_type>: `size' and `avail' are now `size_t'.
3320
3321 * regex.h <regoff_t>: Use ssize_t, not int.
3322 (re_search, re_search_2, re_match, re_match_2): Arguments that
3323 specify buffer/string position and length are now ssize_t and
3324 size_t. Return type is regoff_t.
3325
613052cd
BK
33262011-04-16 Ben Key <bkey76@gmail.com>
3327
3328 * nsfont.m: Fixed bugs in ns_get_family and
3329 ns_descriptor_to_entity that were caused by using free to
3330 deallocate memory blocks that were allocated by xmalloc (via
3331 xstrdup). This caused Emacs to crash when compiled with
3332 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3333 --enable-checking=xmallocoverrun). xfree is now used to
3334 deallocate these memory blocks.
3335
4170f62f 33362011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3337
71b41406
PE
3338 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3339
9587a89d
PE
3340 emacs_write: Accept and return EMACS_INT for sizes.
3341 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3342 et seq.
3343 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3344 Accept and return EMACS_INT.
3345 (emacs_gnutls_write): Return the number of bytes written on
3346 partial writes.
3347 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3348 (emacs_read, emacs_write): Remove check for negative size, as the
3349 Emacs source code has been audited now.
9587a89d
PE
3350 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3351 (emacs_read, emacs_write): Use it.
273a5f82
PE
3352 * process.c (send_process): Adjust to the new signatures of
3353 emacs_write and emacs_gnutls_write. Do not attempt to store
3354 a byte offset into an 'int'; it might overflow.
9587a89d 3355 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3356
3e047f51
PE
3357 * sound.c: Don't assume sizes fit in 'int'.
3358 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3359 Return EMACS_INT, not int.
3e047f51 3360 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3361 Accept EMACS_INT, not int.
3362 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3363 record read return values.
3364
cc39a9db
BK
33652011-04-15 Ben Key <bkey76@gmail.com>
3366
c9d0ec6d
JB
3367 * keyboard.c (Qundefined): Don't declare static since it is used
3368 in nsfns.m.
3369 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3370 static since they are used in nsfont.m.
cc39a9db 3371
6c60eb9f
SM
33722011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3373
3374 * process.c (Qprocessp): Don't declare static.
3375 * lisp.h (Qprocessp): Declare again.
3376
7990b61a
JB
33772011-04-15 Juanma Barranquero <lekktu@gmail.com>
3378
3379 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3380
5d4cb038
PE
33812011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3382
8bd7b830 3383 Improve C-level modularity by making more things 'static'.
cd64ea1d 3384
e3b27b31
PE
3385 Don't publish debugger-only interfaces to other modules.
3386 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3387 (verify_bytepos, count_markers): Move decls to the only modules
3388 that need them.
3389 * region-cache.h (pp_cache): Likewise.
3390 * window.h (check_all_windows): Likewise.
3391 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3392
5d4cb038
PE
3393 * sysdep.c (croak): Now static, if
3394 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3395 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3396
3397 * alloc.c (refill_memory_reserve): Now static if
3398 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3399 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3400
e87b6180
PE
3401 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3402 Define only if USE_LUCID.
3403
ac64929e
PE
3404 * xrdb.c (x_customization_string, x_rm_string): Now static.
3405
6f37259d
PE
3406 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3407 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3408
1683e3ab
PE
3409 * xdisp.c (draw_row_with_mouse_face): Now static.
3410 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3411
de9c2632
PE
3412 * window.h (check_all_windows): Mark externally visible.
3413
2b96acb7
PE
3414 * window.c (window_deletion_count): Now static.
3415
3416 * undo.c: Make symbols static if they're not exported.
3417 (last_undo_buffer, last_boundary_position, pending_boundary):
3418 Now static.
3419
50436f33
PE
3420 * textprop.c (interval_insert_behind_hooks): Now static.
3421 (interval_insert_in_front_hooks): Likewise.
3422
64520e5c
PE
3423 * term.c: Make symbols static if they're not exported.
3424 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3425 (max_frame_lines, tty_set_terminal_modes):
3426 (tty_reset_terminal_modes, tty_turn_off_highlight):
3427 (get_tty_terminal): Now static.
3428 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3429 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3430 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3431 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3432 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3433
1fa53021
PE
3434 * sysdep.c: Make symbols static if they're not exported.
3435 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3436 Now static.
3437 (sigprocmask_set, full_mask): Remove; unused.
3438 (wait_debugging): Mark as visible.
3439 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3440 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3441
d4b43b22
PE
3442 * syntax.c (syntax_temp): Define only if !__GNUC__.
3443
b7c513d0
PE
3444 * sound.c (current_sound_device, current_sound): Now static.
3445
989b29ad
PE
3446 * search.c (searchbufs, searchbuf_head): Now static.
3447
13a55a78
PE
3448 * scroll.c (scroll_cost): Remove; unused.
3449 * dispextern.h (scroll_cost): Remove decl.
3450
de68a1fc
PE
3451 * region-cache.h (pp_cache): Mark as externally visible.
3452
40ccffa6
PE
3453 * process.c: Make symbols static if they're not exported.
3454 (process_tick, update_tick, create_process, chan_process):
3455 (Vprocess_alist, proc_buffered_char, datagram_access):
3456 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3457 (deactivate_process): Mark defn as static, as well as decl.
3458 * lisp.h (create_process): Remove decl.
3459 * process.h (chan_process, Vprocess_alist): Remove decls.
3460
ad64fc97
PE
3461 * print.c: Make symbols static if they're not exported.
3462 (print_depth, new_backquote_output, being_printed, print_buffer):
3463 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3464 (print_interval, print_number_index, initial_stderr_stream):
3465 Now static.
3466 * lisp.h (Fprinc): Remove decl.
3467 (debug_output_compilation_hack): Mark as externally visible.
3468
adddb265
PE
3469 * sysdep.c (croak): Move decl from here to syssignal.h.
3470 * syssignal.h (croak): Put it here, so the API can be checked when
3471 'croak' is called from dissociate_if_controlling_tty.
3472
1717ede2
PE
3473 * minibuf.c: Make symbols static if they're not exported.
3474 (minibuf_save_list, choose_minibuf_frame): Now static.
3475 * lisp.h (choose_minibuf_frame): Remove decl.
3476
fa5fb2bc
PE
3477 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3478
1e3890d1
PE
3479 * lread.c: Make symbols static if they're not exported.
3480 (read_objects, initial_obarray, oblookup_last_bucket_number):
3481 Now static.
3482 (make_symbol): Remove; unused.
3483 * lisp.h (initial_obarray, make_symbol): Remove decls.
3484
8a1414fa
PE
3485 * keyboard.c: Make symbols static if they're not exported.
3486 (single_kboard, recent_keys_index, total_keys, recent_keys):
3487 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3488 (this_single_command_key_start, echoing, last_auto_save):
3489 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3490 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3491 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3492 (Vlispy_mouse_stem, double_click_count):
3493 Now static.
3494 (force_auto_save_soon): Define only if SIGDANGER.
3495 (ignore_mouse_drag_p): Now static if
3496 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3497 (print_help): Remove; unused.
3498 (stop_character, last_timer_event): Mark as externally visible.
3499 * keyboard.h (ignore_mouse_drag_p): Declare only if
3500 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3501 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3502 * lisp.h (echoing): Remove decl.
3503 (force_auto_save_soon): Declare only if SIGDANGER.
3504 * xdisp.c (redisplay_window): Simplify code, to make it more
3505 obvious that ignore_mouse_drag_p is not accessed if !defined
3506 USE_GTK && !defined HAVE_NS.
3507
93ea6e8f
PE
3508 * intervals.c: Make symbols static if they're not exported.
3509 (merge_properties_sticky, merge_interval_right, delete_interval):
3510 Now static.
3511 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3512
77382fcc
PE
3513 * insdel.c: Make symbols static if they're not exported.
3514 However, leave prepare_to_modify_buffer alone. It's never
3515 called from outside this function, but that appears to be a bug.
3516 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3517 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3518 (adjust_after_replace_noundo): Remove; unused.
3519 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3520 (signal_before_change): Remove decls.
77382fcc 3521
9306c32e
PE
3522 * indent.c (val_compute_motion, val_vmotion): Now static.
3523
cd44d2eb
PE
3524 * image.c: Make symbols static if they're not exported.
3525 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3526 if USE_GTK.
3527 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3528 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3529
ad9a7a06
PE
3530 * fringe.c (standard_bitmaps): Now static.
3531 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3532
81626931
PE
3533 * frame.c: Make symbols static if they're not exported.
3534 (x_report_frame_params, make_terminal_frame): Now static.
3535 (get_frame_param): Now static, unless HAVE_NS.
3536 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3537 (x_get_resource_string): Remove; not used.
3538 * frame.h (make_terminal_frame, x_report_frame_params):
3539 (x_get_resource_string); Remove decls.
3540 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3541 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3542
239f9db9
PE
3543 * font.c, fontset.c: Make symbols static if they're not exported.
3544 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3545 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3546 * font.c (font_close_object): Now static.
3547 * font.h (font_close_object): Remove.
3548 * fontset.c (FONTSET_OBJLIST): Remove.
3549 (free_realized_fontset) #if-0 the body, which does nothing.
3550 (face_suitable_for_char_p): #if-0, as it's never called.
3551 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3552 * xfaces.c (face_at_string_position):
3553 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3554 since 0 is always ASCII.
3555
dfcf3579
PE
3556 * fns.c (weak_hash_tables): Now static.
3557
5045092b
PE
3558 * fileio.c: Make symbols static if they're not exported.
3559 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3560 (Vwrite_region_annotation_buffers): Now static.
3561
57a96f5c
PE
3562 * eval.c: Make symbols static if they're not exported.
3563 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3564 * lisp.h (backtrace_list): Remove decl.
3565
35f08c38
PE
3566 * emacs.c: Make symbols static if they're not exported.
3567 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3568 (fatal_error_code, fatal_error_signal_hook, standard_args):
3569 Now static.
3570 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3571 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3572 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3573 * lisp.h (fatal_error_signal_hook): Remove decl.
3574 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3575
f44bd759
PE
3576 * editfns.c: Move a (normally-unused) function to its only use.
3577 * editfns.c, lisp.h (get_operating_system_release): Remove.
3578 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3579 worth the hassle of breaking this out.
3580
b532497d
PE
3581 * xterm.c: Make symbols static if they're not exported.
3582 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3583 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3584 (x_destroy_window, x_delete_display):
3585 Now static.
3586 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3587 (x_mouse_leave): Remove; unused.
3588 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3589 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3590 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3591 Remove decls.
3592 (x_mouse_leave): Declare only if WINDOWSNT.
3593 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3594 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3595 USE_X_TOOLKIT.
3596
1675728f
PE
3597 * ftxfont.c: Make symbols static if they're not exported.
3598 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3599 HAVE_FREETYPE.
3600 * font.h (ftxfont_driver): Likewise.
3601
e4cebfca
PE
3602 * xfns.c: Make symbols static if they're not exported.
3603 (x_last_font_name, x_display_info_for_name):
3604 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3605 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3606 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3607 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3608 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3609 (last_show_tip_args): Now static.
3610 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3611 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3612 (x_screen_planes): Remove; unused.
3613 * dispextern.h (x_screen_planes): Remove decl.
3614
5bf46f05
PE
3615 * dispnew.c: Make symbols static if they're not exported.
3616 * dispextern.h (redraw_garbaged_frames, scrolling):
3617 (increment_row_positions): Remove.
3618 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3619 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3620 Now static.
3621 (redraw_garbaged_frames): Remove; unused.
3622
435f4c28
PE
3623 * xfaces.c: Make symbols static if they're not exported.
3624 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3625 Remove decls.
3626 * xterm.h (defined_color): Remove decls.
3627 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3628 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3629 (menu_face_changed_default, defined_color, free_realized_face):
3630 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3631 (ascii_face_of_lisp_face): Remove; unused.
3632
8524aef3
PE
3633 * xdisp.c: Make symbols static if they're not exported.
3634 * dispextern.h (scratch_glyph_row, window_box_edges):
3635 (glyph_to_pixel_coords, set_cursor_from_row):
3636 (get_next_display_element, set_iterator_to_next):
3637 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3638 (show_mouse_face): Remove decls
3639 * frame.h (message_buf_print): Likewise.
3640 * lisp.h (pop_message, set_message, check_point_in_composition):
3641 Likewise.
3642 * xterm.h (set_vertical_scroll_bar): Likewise.
3643 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3644 (message_buf_print, scratch_glyph_row, displayed_buffer):
3645 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3646 (get_next_display_element, show_mouse_face, window_box_edges):
3647 (frame_to_window_pixel_xy, check_point_in_composition):
3648 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3649 (glyph_to_pixel_coords): Remove; unused.
3650
16390cd2
PE
3651 * dired.c (file_name_completion): Now static.
3652
3653 * dbusbind.c (xd_in_read_queued_messages): Now static.
3654
a25f4dfa
PE
3655 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3656 * data.c (circular_list_error): Remove.
3657
14a9c8df
PE
3658 * commands.h (last_point_position, last_point_position_buffer):
3659 (last_point_position_window): Remove decls.
3660 * keyboard.c: Make these variables static.
3661
04f2d78b
CB
3662 * coding.h (coding, code_convert_region, encode_coding_gap):
3663 Remove decls.
74ab6df5
PE
3664 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3665 (iso_code_class, detect_coding, code_convert_region): Now static.
3666 (encode_coding_gap): Remove; unused.
3667
38dfbee1
PE
3668 * chartab.c (chartab_chars, chartab_bits): Now static.
3669
a2cb4e63
PE
3670 * charset.h (charset_iso_8859_1): Remove decl.
3671 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3672 Now static.
3673
127198fd
PE
3674 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3675 * ccl.c (Vccl_program_table): Now static.
3676 (check_ccl_update): Remove; unused.
3677
d85b608f
PE
3678 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3679 * category.h: ... from here.
3680 * category.c (check_category_table, set_category_set): Now static.
3681
31cd66f3
PE
3682 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3683 * lisp.h: Remove these decls.
3684
c358e587
PE
3685 * buffer.c (buffer_count): Remove unused var.
3686
e78aecca
PE
3687 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3688 so that it's not optimized away.
3689 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3690 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3691 exported only to the debugger.
3692
e192d7d3 3693 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 3694 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 3695
92470028
PE
3696 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3697 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3698 was inaccessible from Lisp.
3699 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3700 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3701
244ed907
PE
3702 alloc.c: Import and export fewer symbols, and remove unused items.
3703 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3704 is defined.
3705 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3706 it's not optimized away by whole-program optimization.
3707 (message_enable_multibyte, free_misc): Remove.
3708 (catchlist, handlerlist, mark_backtrace):
3709 Declare only if BYTE_MARK_STACK.
3710 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3711 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3712 (message_enable_multibyte): Remove decl.
3713 (free_misc, interval_free_list, float_block, float_block_index):
3714 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3715 (cons_free_list, last_marked_index):
3716 Now static.
3717 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3718 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3719 (mark_backtrace): Define only if BYTE_MARK_STACK.
3720 * xdisp.c (message_enable_multibyte): Now static.
3721
61c2b50e 3722 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3723 This makes it easier for human readers (and static analyzers)
3724 to see whether these variables are used from other modules.
3725 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3726 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3727 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3728 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3729 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3730 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3731 * xmenu.c, xselect.c:
3732 Declare Q* vars static if they are not used in other modules.
3733 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3734 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3735 Remove decls of unexported vars.
3736 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3737
95c82688
PE
3738 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3739
16a97296
PE
3740 Make Emacs functions such as Fatom 'static' by default.
3741 This makes it easier for human readers (and static analyzers)
3742 to see whether these functions can be called from other modules.
3743 DEFUN now defines a static function. To make the function external
3744 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3745 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3746 (Finit_image_library):
16a97296
PE
3747 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3748 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3749 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3750 Remove decls, since these functions are now static.
3751 (Funintern, Fget_internal_run_time): New decls, since these functions
3752 were already external.
95c82688 3753
16a97296
PE
3754 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3755 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3756 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3757 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3758 * keyboard.c, keymap.c, lread.c:
3759 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3760 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3761 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3762 Mark functions with DEFUE instead of DEFUN,
3763 if they are used in other modules.
3764 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3765 decls for now-static functions.
3766 * buffer.h (Fdelete_overlay): Remove decl.
3767 * callproc.c (Fgetenv_internal): Mark as internal.
3768 * composite.c (Fremove_list_of_text_properties): Remove decl.
3769 (Fcomposition_get_gstring): New forward static decl.
3770 * composite.h (Fcomposite_get_gstring): Remove decl.
3771 * dired.c (Ffile_attributes): New forward static decl.
3772 * doc.c (Fdocumntation_property): New forward static decl.
3773 * eval.c (Ffetch_bytecode): New forward static decl.
3774 (Funintern): Remove extern decl; now in .h file where it belongs.
3775 * fileio.c (Fmake_symbolic_link): New forward static decl.
3776 * image.c (Finit_image_library): New forward static decl.
3777 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3778 * intervals.h (Fprevious_property_change):
3779 (Fremove_list_of_text_properties): Remove decls.
3780 * keyboard.c (Fthis_command_keys): Remove decl.
3781 (Fcommand_execute): New forward static decl.
3782 * keymap.c (Flookup_key): New forward static decl.
3783 (Fcopy_keymap): Now static.
3784 * keymap.h (Flookup_key): Remove decl.
3785 * process.c (Fget_process): New forward static decl.
3786 (Fprocess_datagram_address): Mark as internal.
3787 * syntax.c (Fsyntax_table_p): New forward static decl.
3788 (skip_chars): Remove duplicate decl.
3789 * textprop.c (Fprevious_property_change): New forward static decl.
3790 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3791 Now internal.
3792 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3793 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3794
785bbd42
PE
3795 * editfns.c (Fformat): Remove unreachable code.
3796
8b913b57
AS
37972011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3798
3799 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3800 change. (Bug#8496)
3801
a6744a35
EZ
38022011-04-13 Eli Zaretskii <eliz@gnu.org>
3803
3804 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3805 when at ZV. (Bug#8487)
3806
e7974947
AS
38072011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3808
baad03f0
AS
3809 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3810 (Bug#8437)
3811 * keyboard.c (parse_tool_bar_item): Likewise.
3812 * sound.c (sound_cleanup, alsa_close): Likewise.
3813 * termcap.c (tgetent): Likewise.
3814 * xfns.c (x_default_font_parameter): Likewise.
3815 * xsettings.c (read_and_apply_settings): Likewise.
3816
e7974947
AS
3817 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3818 (overrun_check_free): Protoize.
3819
28272684
PE
38202011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3821
3822 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3823 since callers should never pass a negative size.
3824 Change the signature to match that of plain 'read' and 'write'; see
3825 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3826 * lisp.h: Update prototypes of emacs_write and emacs_read.
3827
11997c76
EZ
38282011-04-11 Eli Zaretskii <eliz@gnu.org>
3829
3830 * xdisp.c (redisplay_window): Don't try to determine the character
3831 position of the scroll margin if the window start point w->startp
e896f03c 3832 is outside the buffer's accessible region. (Bug#8468)
11997c76 3833
8a2cbd72
EZ
38342011-04-10 Eli Zaretskii <eliz@gnu.org>
3835
3836 Fix write-region and its subroutines for buffers > 2GB.
3837 * fileio.c (a_write, e_write): Modify declaration of arguments and
3838 local variables to support buffers larger than 2GB.
3839 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3840
3841 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3842 argument, local variables, and return value.
3843
3844 * lisp.h: Update prototypes of emacs_write and emacs_read.
3845
3846 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3847
4073e537 38482011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3849
1ebfdcb6
PE
3850 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3851
b2ded58d
PE
3852 Fix more problems found by GCC 4.6.0's static checks.
3853
7d66342c
PE
3854 * xdisp.c (vmessage): Use a better test for character truncation.
3855
bbf47d44
PE
3856 * charset.c (load_charset_map): <, not <=, for optimization,
3857 and to avoid potential problems with integer overflow.
9248994d 3858 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3859 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3860 * editfns.c (Fformat): Likewise.
1e69125e 3861 * syntax.c (skip_chars): Likewise.
3befa583 3862
e3019616
PE
3863 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3864 This also lets GCC 4.6.0 generate slightly better loop code.
3865
becfa255
PE
3866 * callint.c (Fcall_interactively): <, not <=, for optimization.
3867 (Fcall_interactively): Count the number of arguments produced,
3868 not the number of arguments given. This is simpler and lets GCC
3869 4.6.0 generate slightly better code.
3870
dae0cd48
PE
3871 * ftfont.c: Distingish more carefully between FcChar8 and char.
3872 The previous code passed unsigned char * to a functions like
3873 strlen and xstrcasecmp that expect char *, which does not
3874 conform to the C standard.
3875 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3876 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3877 char * when the C standard requires it.
3878
76032d70
PE
3879 * keyboard.c (read_char): Remove unused var.
3880
eb3f1cc8
PE
3881 * eval.c: Port to Windows vsnprintf (Bug#8435).
3882 Include <limits.h>.
3883 (SIZE_MAX): Define if the headers do not.
3884 (verror): Do not give up if vsnprintf returns a negative count.
3885 Instead, grow the buffer. This ports to Windows vsnprintf, which
3886 does not conform to C99. Problem reported by Eli Zaretskii.
3887 Also, simplify the allocation scheme, by avoiding the need for
3888 calling realloc, and removing the ALLOCATED variable.
3889
70476b54
PE
3890 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3891
12020a9e
PE
3892 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3893 But keep the doprint source code for now, as we might revamp it
3894 and use it again (Bug#8435).
ea6c7ae6
PE
3895 * lisp.h (doprnt): Remove.
3896 * Makefile.in (base_obj): Remove doprnt.o.
3897 * deps.mk (doprnt.o): Remove.
3898
5fdb398c
PE
3899 error: Print 32- and 64-bit integers portably (Bug#8435).
3900 Without this change, on typical 64-bit hosts error ("...%d...", N)
3901 was used to print both 32- and 64-bit integers N, which relied on
3902 undefined behavior.
3903 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3904 New macro.
3905 * lisp.h (error, verror): Mark as printf-like functions.
3906 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3907 Report overflow in size calculations when allocating printf buffer.
3908 Do not truncate output string at its first null byte.
3909 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3910 Truncate the output at a character boundary, since vsnprintf does not
3911 do that.
3912 * charset.c (check_iso_charset_parameter): Convert internal
3913 character to string before calling 'error', since %c now has the
3914 printf meaning.
3915 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3916 overflow when computing char to be passed to 'error'. Do not
3917 pass Lisp_Object to 'error'; pass the integer instead.
3918 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3919 formatted with plain %d.
3920
b189fa66
PE
3921 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3922
bff87ef0
PE
3923 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3924
7e2cac20
PE
3925 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3926
ce4d90b5
PE
3927 * xterm.c (x_catch_errors): Remove duplicate declaration.
3928
266c9547
PE
3929 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3930
79c49ad2
PE
3931 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3932
368f4090
JM
39332011-04-10 Jim Meyering <meyering@redhat.com>
3934
3935 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3936 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3937 return ssize_t not "int", and use size_t as the buffer length.
3938 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3939 * gnutls.h: Update declarations.
3940 * process.c (read_process_output): Use ssize_t, to match.
3941 (send_process): Likewise.
3942
a32d4040
CY
39432011-04-09 Chong Yidong <cyd@stupidchicken.com>
3944
3945 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3946
8546720e 39472011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3948
04f2d78b
CB
3949 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3950 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3951
8546720e
GM
3952 * xterm.c (handle_one_xevent):
3953 * xmenu.c (create_and_show_popup_menu):
3954 * xselect.c (x_decline_selection_request)
3955 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3956
0a2f5c1a 39572011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3958
3959 Fix some uses of `int' instead of EMACS_INT.
3960 * search.c (string_match_1, fast_string_match)
3961 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3962 (scan_buffer, find_next_newline_no_quit)
3963 (find_before_next_newline, search_command, Freplace_match)
3964 (Fmatch_data): Make some `int' variables be EMACS_INT.
3965
3966 * xdisp.c (display_count_lines): 3rd argument and return value now
3967 EMACS_INT. All callers changed.
3968 (pint2hrstr): Last argument is now EMACS_INT.
3969
3970 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3971 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3972 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3973 (decode_coding_utf_16, decode_coding_emacs_mule)
3974 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3975 (decode_coding_ccl, decode_coding_charset)
3976 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3977 (decode_coding_iso_2022, decode_coding_emacs_mule)
3978 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3979 <char_offset, last_offset>: Declare EMACS_INT.
3980 (encode_coding_utf_8, encode_coding_utf_16)
3981 (encode_coding_emacs_mule, encode_invocation_designation)
3982 (encode_designation_at_bol, encode_coding_iso_2022)
3983 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3984 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3985 Declare EMACS_INT.
3986 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3987 (encode_invocation_designation): Last argument P_NCHARS is now
3988 EMACS_INT.
3989 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3990 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3991
3992 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3993 All users changed.
3994
3995 * ccl.c (Fccl_execute_on_string): Declare some variables
3996 EMACS_INT.
3997
8546720e 39982011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3999
4000 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4001
4e19a977
CS
40022011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4003
4004 * process.c (Fformat_network_address): Doc fix.
4005
87302331
R
40062011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4007
4008 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4009
cbb59342
CY
40102011-04-08 Chong Yidong <cyd@stupidchicken.com>
4011
4012 * keyboard.c (read_char): Call Lisp function help-form-show,
4013 instead of using internal_with_output_to_temp_buffer.
4014 (Qhelp_form_show): New var.
e0d38eeb 4015 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4016
4017 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4018
4019 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4020
e67a13ab
CY
40212011-04-06 Chong Yidong <cyd@stupidchicken.com>
4022
04f2d78b
CB
4023 * process.c (Flist_processes): Remove to Lisp.
4024 (list_processes_1): Delete.
e67a13ab 4025
973f782d
EZ
40262011-04-06 Eli Zaretskii <eliz@gnu.org>
4027
7c106b1e
EZ
4028 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4029
973f782d
EZ
4030 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4031
41cf7d1a 40322011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4033
ca23cc88
PE
4034 Fix more problems found by GCC 4.6.0's static checks.
4035
f390e2d5
PE
4036 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4037
42eea0d0
PE
4038 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4039
b69769da 4040 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4041
f9541e84
PE
4042 * xdisp.c (vmessage): Mark as a printf-like function.
4043
13841b55
PE
4044 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4045
c136c10f
PE
4046 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4047
5e2d4a30
PE
4048 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4049 printf-like functions.
4050 (tiff_load): Add casts to remove these marks before passing them
4051 to system-supplied API.
4052
583f48b9
PE
4053 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4054
b25d760e
PE
4055 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4056 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4057 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4058 directly, rather than having caller test rule sign. This avoids
4059 some unnecessary tests.
4060 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4061 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4062 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4063
bc7b6697 4064 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4065 (xfont_open): Avoid unnecessary tests.
bc7b6697 4066
27ccc379
PE
4067 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4068
dcd5c89a
PE
4069 * composite.h, composite.c (composition_gstring_put_cache):
4070 Use EMACS_INT, not int, for length.
4071
b13a45c6
PE
4072 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4073 breaking out part of COMPOSITION_DECODE_RULE.
4074 (COMPOSITION_DECODE_RULE): Use it.
4075 * composite.c (get_composition_id): Remove unused local vars,
4076 by using the new macro.
4077
1e792e4d
PE
4078 * textprop.c (set_text_properties_1): Change while to do-while,
4079 since the condition is always true at first.
4080
dc6c6455 4081 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4082 (interval_deletion_adjustment): Return unsigned value.
4083 All uses changed.
dc6c6455 4084
aba7731a
PE
4085 * process.c (list_processes_1, create_pty, read_process_output):
4086 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4087 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4088 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4089 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4090 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4091
fdfc4bf3
PE
4092 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4093
fca8fe46 4094 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4095 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4096
06a0259a 4097 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4098 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4099 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4100
e7b9e80f
PE
4101 * print.c (print_error_message): Avoid int overflow.
4102
56201685
PE
4103 * font.c (font_list_entities): Redo for clarity,
4104 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4105
78834453 4106 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4107 (font_score): Avoid potential overflow in diff calculation.
78834453 4108
0bc0b309 4109 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4110 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4111
e610eaca
PE
4112 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4113
b895abce
PE
4114 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4115 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4116 can always succeed if overflow has undefined behavior.
4117
1f1d9321 4118 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4119 (wordify): Omit three unnecessary tests.
1f1d9321 4120
c59478bc
PE
4121 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4122 All callers changed. This avoids the need for an unused var.
4123
79b73827
PE
4124 * casefiddle.c (casify_region): Remove var that is set but not used.
4125
a4db5dfe
PE
4126 * dired.c (file_name_completion): Remove var that is set but not used.
4127
43aae36e
PE
4128 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4129
2a47c44d 4130 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4131 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4132
a37c69bf
PE
4133 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4134 Check for integer overflow on size calculations.
4135
328ab8e7
PE
4136 * buffer.c (Fprevious_overlay_change): Remove var that is set
4137 but not used.
4138
e5a2a5cb
PE
4139 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4140 Remove vars that are set but not used.
8d84a6eb 4141 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4142 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4143
a60e5f68
PE
4144 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4145
f661cb61 4146 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4147 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4148
f0397f5a
PE
4149 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4150 that are set but not used.
4151
8664db06 4152 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4153 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4154
6abdaa4a
PE
4155 * xselect.c (x_get_local_selection, x_handle_property_notify):
4156 Remove vars that are set but not used.
4157
0ce7538d 4158 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4159 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4160
9ae848fc
PE
4161 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4162 Remove var that is set but not used.
0b918413
PE
4163 (scroll_bar_windows_size): Now size_t, not int.
4164 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4165 Check for overflow.
9ae848fc 4166
a5a62657
PE
4167 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4168 (map_tty_color) [!defined MSDOS]: Likewise.
4169
5c5cdd39
PE
4170 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4171
66ebf983
PE
4172 * coding.c: Remove vars that are set but not used.
4173 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4174 All callers changed.
4175 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4176 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4177 (decode_coding_charset): Remove vars that are set but not used.
4178
1be4d761
PE
4179 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4180 that is set but not used.
4181
47553fa8
PE
4182 * print.c (print_object): Remove var that is set but not used.
4183
1f7196bf 4184 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4185 The gnulib version avoids calling malloc in the usual case,
4186 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4187 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4188 * filelock.c (current_lock_owner): Likewise.
4189 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4190 * sysdep.c: Include allocator.h, careadlinkat.h.
4191 (emacs_no_realloc_allocator): New static constant.
4192 (emacs_readlink): New function.
fdb61804
PE
4193 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4194 ../lib/careadlinkat.h.
d1fdcab7 4195
f84c17c7
SM
41962011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4197
4198 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4199 first non-nil return value).
4200
ef3862ad
JD
42012011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4202
4203 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4204 if not defined (Bug#8403).
4205
376a7006
JB
42062011-04-02 Juanma Barranquero <lekktu@gmail.com>
4207
4208 * xdisp.c (display_count_lines): Remove parameter `start',
4209 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4210 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4211 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4212 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4213 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4214 and thereabouts. All callers changed.
4215 (get_per_char_metric): Remove parameter `f', unused since
4216 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4217
6ca3801d
JM
42182011-04-02 Jim Meyering <meyering@redhat.com>
4219
4220 do not dereference NULL upon failed strdup
4221 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4222 (ns_get_family): Likewise.
4223
d8e2b5ba
JB
42242011-04-02 Juanma Barranquero <lekktu@gmail.com>
4225
4226 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4227
8c74fcbd
JD
42282011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4229
4230 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4231 later (Bug#8403).
4232
7200d79c
SM
42332011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4234
03408648 4235 Add lexical binding.
7200d79c 4236
03408648
SM
4237 * window.c (Ftemp_output_buffer_show): New fun.
4238 (Fsave_window_excursion):
4239 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4240
4241 * lread.c (lisp_file_lexically_bound_p): New function.
4242 (Fload): Bind Qlexical_binding.
4243 (readevalloop): Remove `evalfun' arg.
4244 Bind Qinternal_interpreter_environment.
4245 (Feval_buffer): Bind Qlexical_binding.
4246 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4247 Mark as dynamic.
4248 (syms_of_lread): Declare `lexical-binding'.
4249
4250 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4251
4252 * keyboard.c (eval_dyn): New fun.
4253 (menu_item_eval_property): Use it.
ca105506
SM
4254
4255 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4256
03408648
SM
4257 * fns.c (concat, mapcar1): Accept byte-code-functions.
4258
4259 * eval.c (Fsetq): Handle lexical vars.
4260 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4261 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4262 (FletX, Flet): Obey lexical binding.
4263 (Fcommandp): Handle closures.
4264 (Feval): New `lexical' arg.
4265 (eval_sub): New function extracted from Feval. Use it almost
4266 everywhere where Feval was used. Look up vars in lexical env.
4267 Handle closures.
4268 (Ffunctionp): Move from subr.el.
4269 (Ffuncall): Handle closures.
4270 (apply_lambda): Remove `eval_flags'.
4271 (funcall_lambda): Handle closures and new byte-code-functions.
4272 (Fspecial_variable_p): New function.
4273 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4274 but without exporting it to Lisp.
23aba0ea 4275
23aba0ea 4276 * doc.c (Fdocumentation, store_function_docstring):
03408648 4277 * data.c (Finteractive_form): Handle closures.
23aba0ea 4278
03408648
SM
4279 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4280 interactive spec.
ba83908c 4281
04f2d78b
CB
4282 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4283 New byte-codes.
03408648
SM
4284 (exec_byte_code): New function extracted from Fbyte_code to handle new
4285 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 4286
03408648 4287 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 4288
03408648 4289 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 4290
e2abce01
JB
42912011-03-31 Juanma Barranquero <lekktu@gmail.com>
4292
4293 * xdisp.c (redisplay_internal): Fix prototype.
4294
63696a73 42952011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 4296
63696a73 4297 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
4298 (try_scrolling): Use it when setting scroll_limit.
4299 Limit scrolling to 100 screen lines.
63696a73
EZ
4300 (redisplay_window): Even when falling back on "recentering",
4301 position point in the window according to scroll-conservatively,
4302 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4303
4304 (try_scrolling): When point is above the window, allow searching
4305 as far as scroll_max, or one screenful, to compute vertical
4306 distance from PT to the scroll margin position. This prevents
4307 try_scrolling from unnecessarily failing when
4308 scroll-conservatively is set to a value slightly larger than the
4309 window height. Clean up the case of PT below the margin at bottom
4310 of window: scroll_max can no longer be INT_MAX. When aggressive
4311 scrolling is in use, don't let point enter the opposite scroll
4312 margin as result of the scroll.
4313 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
4314 threshold of 100 lines for never-recentering scrolling.
4315
e4cc2dfc
JB
43162011-03-31 Juanma Barranquero <lekktu@gmail.com>
4317
4318 * dispextern.h (move_it_by_lines):
4319 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4320 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4321 (message_log_check_duplicate): Remove parameters `prev_bol' and
4322 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4323 (redisplay_internal): Remove parameter `preserve_echo_area',
4324 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4325
4326 * indent.c (Fvertical_motion):
4327 * window.c (window_scroll_pixel_based, Frecenter):
4328 Don't pass `need_y_p' to `move_it_by_lines'.
4329
1c470562
SM
43302011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4331
44f230aa
SM
4332 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4333 steal a few bits to be more compact.
4334 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4335 Remove unneeded casts.
4336
1c470562
SM
4337 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4338
888adce9
ZK
43392011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4340
4341 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4342 binding" message (bug#7967).
4343
f838ed7b
PE
43442011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4345
77861b95
PE
4346 Fix more problems found by GCC 4.6.0's static checks.
4347
de6dbc14
PE
4348 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4349 Remove unused local var.
4350
f838ed7b
PE
4351 * editfns.c (Fmessage_box): Remove unused local var.
4352
792c7b2b
PE
4353 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4354 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4355 Omit unused local vars.
c499e557 4356 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4357 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4358 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4359 Omit unused local var.
4360
ba0165e1
PE
4361 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4362 Don't assume string length fits in int.
32ad8845 4363 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4364 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4365
3c59b4c9
PE
4366 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4367 instead of alloca (Bug#8344).
4368
a3eed478 4369 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4370 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4371
eb4d412d
PE
4372 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4373
1658b401
PE
4374 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4375 concerns.
4376
4377 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4378
4379 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4380
9a2c6e05
PE
4381 * keyboard.c (syms_of_keyboard): Use the same style as later
4382 in this function when indexing through an array. This also
4383 works around GCC bug 48267.
4384
03d0a109
PE
4385 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4386
44f730c8
PE
4387 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4388
fe75f926
PE
4389 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4390 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4391
ffa8c828
PE
4392 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4393 This avoids undefined behavior on integer overflow, and is a bit
4394 more convenient anyway since it is compared to a size_t variable.
4395
c5101a77
PE
4396 Variadic C functions now count arguments with size_t, not int.
4397 This avoids an unnecessary limitation on 64-bit machines, which
4398 caused (substring ...) to crash on large vectors (Bug#8344).
4399 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4400 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4401 All variadic functions and their callers changed accordingly.
c5101a77
PE
4402 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4403 * data.c (arith_driver, float_arith_driver): Likewise.
4404 * editfns.c (general_insert_function): Likewise.
4405 * eval.c (struct backtrace.nargs, interactive_p)
4406 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4407 (funcall_lambda, mark_backtrace): Likewise.
4408 * fns.c (concat): Likewise.
4409 * frame.c (x_set_frame_parameters): Likewise.
4410 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4411 0 if not found, not -1. All callers changed.
4412
dd3f25f7
PE
4413 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4414 (stack_copy_size): Now size_t, not int.
4415 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4416
461c2ab9
JB
44172011-03-28 Juanma Barranquero <lekktu@gmail.com>
4418
4419 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4420 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4421 All callers changed.
4422
4423 * lisp.h (multibyte_char_to_unibyte):
4424 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4425 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4426 * character.h (CHAR_TO_BYTE8):
4427 * cmds.c (internal_self_insert):
4428 * editfns.c (general_insert_function):
4429 * keymap.c (push_key_description):
4430 * search.c (Freplace_match):
4431 * xdisp.c (message_dolog, set_message_1): All callers changed.
4432
f6d62986
SM
44332011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4434
4435 * keyboard.c (safe_run_hook_funcall): New function.
4436 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4437 don't set the hook to nil, but remove the offending function instead.
4438 (Qcommand_hook_internal): Remove, unused.
4439 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4440 Vcommand_hook_internal.
4441
4442 * eval.c (enum run_hooks_condition): Remove.
4443 (funcall_nil, funcall_not): New functions.
4444 (run_hook_with_args): Call each function through a `funcall' argument.
4445 Remove `cond' argument, now redundant.
4446 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4447 (Frun_hook_with_args_until_failure): Adjust accordingly.
4448 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4449
1db5b1ad
JB
44502011-03-28 Juanma Barranquero <lekktu@gmail.com>
4451
4452 * dispextern.h (string_buffer_position): Remove declaration.
4453
4454 * print.c (strout): Remove parameter `multibyte', unused since
4455 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4456
4457 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4458 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4459 All callers changed.
4460
4461 * w32.c (_wsa_errlist): Use braces for struct initializers.
4462
4463 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4464 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4465 All callers changed.
4466 (string_buffer_position): Likewise. Also, make static (it's never
4467 used outside xdisp.c).
4468 (cursor_row_p): Remove parameter `w', unused since
4469 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4470 (decode_mode_spec): Remove parameter `precision', introduced during
4471 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4472 All callers changed.
4473
5ffb62aa
JD
44742011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4475
4476 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4477
461c2ab9 44782011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4479
4480 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4481 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4482 (ns_update_auto_hide_menu_bar): New functions.
4483 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4484 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4485 ns_constrain_all_frames.
4486 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4487 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4488
5c380ffb
JD
44892011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4490
4491 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4492
9af30bdf
GM
44932011-03-27 Glenn Morris <rgm@gnu.org>
4494
4495 * syssignal.h: Replace RETSIGTYPE with void.
4496 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4497 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4498 Replace SIGTYPE with void everywhere.
4499 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4500 * s/template.h (SIGTYPE): Remove commented out definition.
4501
e2abce01
JB
45022011-03-26 Eli Zaretskii <eliz@gnu.org>
4503
4504 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4505 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4506
f868cd8a
JB
45072011-03-26 Juanma Barranquero <lekktu@gmail.com>
4508
59eb0929
JB
4509 * w32.c (read_unc_volume): Use parameter `henum', instead of
4510 global variable `wget_enum_handle'.
4511
4512 * keymap.c (describe_vector): Remove parameters `indices' and
4513 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4514 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4515
f868cd8a
JB
4516 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4517
4518 * keyboard.c (timer_check): Remove parameter `do_it_now',
4519 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4520 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4521 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4522
4523 * keyboard.c (read_char):
4524 * w32menu.c (w32_menu_display_help):
4525 * xmenu.c (show_help_event, menu_help_callback):
4526 Adjust calls to `show_help_echo'.
4527
4528 * gtkutil.c (xg_maybe_add_timer):
4529 * keyboard.c (readable_events):
4530 * process.c (wait_reading_process_output):
4531 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4532
4533 * insdel.c (adjust_markers_gap_motion):
4534 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4535 (gap_left, gap_right): Don't call it.
4536
2ecf6fdb
CY
45372011-03-25 Chong Yidong <cyd@stupidchicken.com>
4538
4539 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4540 incurred during fontification.
4541
6b1f9ba4
JB
45422011-03-25 Juanma Barranquero <lekktu@gmail.com>
4543
4544 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4545 (DEFVAR_PER_BUFFER): Don't pass it.
4546
4547 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4548 (scrolling_window): Don't pass it.
4549
0f4a96b5
JB
45502011-03-25 Juanma Barranquero <lekktu@gmail.com>
4551
4552 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4553
4554 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4555 and `suffix'.
4556 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4557 of variables specific to SELinux and computation of `encoded_absname'.
4558
4559 * image.c (XPutPixel): Remove unused variable `height'.
4560
4561 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4562
4563 * unexw32.c (get_section_info): Remove unused variable `section'.
4564
4565 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4566 (system_process_attributes): Remove unused variable `sess'.
4567 (sys_read): Remove unused variable `err'.
4568
4569 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4570 (w32_wnd_proc): Remove unused variable `isdead'.
4571 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4572 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4573 (x_create_tip_frame): Remove unused variable `tem'.
4574
4575 * w32inevt.c (w32_console_read_socket):
4576 Remove unused variable `no_events'.
4577
4578 * w32term.c (x_draw_composite_glyph_string_foreground):
4579 Remove unused variable `width'.
4580
1149507c
JB
45812011-03-24 Juanma Barranquero <lekktu@gmail.com>
4582
4583 * w32term.c (x_set_glyph_string_clipping):
4584 Don't pass uninitialized region to CombineRgn.
4585
9c88f339
JB
45862011-03-23 Juanma Barranquero <lekktu@gmail.com>
4587
4588 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4589 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4590 (Fx_close_connection): Remove unused variable `i'.
4591
4592 * w32font.c (w32font_draw): Return number of glyphs.
4593 (w32font_open_internal): Remove unused variable `i'.
4594 (w32font_driver): Add missing initializer.
4595
4596 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4597 (fill_in_menu): Remove unused variable `items_added'.
4598
4599 * w32term.c (last_mouse_press_frame): Remove static global variable.
4600 (w32_clip_to_row): Remove unused variable `f'.
4601 (x_delete_terminal): Remove unused variable `i'.
4602
4603 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4604 (NOTHING): Remove unused static global variable.
4605 (uniscribe_check_otf): Remove unused variable `table'.
4606 (uniscribe_font_driver): Add missing initializers.
4607
dee091a3
JD
46082011-03-23 Julien Danjou <julien@danjou.info>
4609
4610 * term.c (Fsuspend_tty, Fresume_tty):
4611 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4612 * window.c (temp_output_buffer_show):
4613 * insdel.c (signal_before_change):
4614 * frame.c (Fhandle_switch_frame):
4615 * fileio.c (Fdo_auto_save):
4616 * emacs.c (Fkill_emacs):
4617 * editfns.c (save_excursion_restore):
4618 * cmds.c (internal_self_insert):
4619 * callint.c (Fcall_interactively):
4620 * buffer.c (Fkill_all_local_variables):
4621 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4622 Use Frun_hooks.
0f4a96b5 4623 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4624 unconditionnaly since it does the check itself.
4625
2c520ab5 46262011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4627
c9c49752
PE
4628 Fix more problems found by GCC 4.5.2's static checks.
4629
8abc3f12
PE
4630 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4631 the first time through the loop, since we know p0 < p1 then.
4632 This also avoids a gcc -Wstrict-overflow warning.
4633
a2d26660
PE
4634 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4635 leading to a memory leak, possible in functions like
4636 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4637 of objects (Bug#8318).
a2d26660 4638
916c72e9
PE
4639 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4640 that could (at least in theory) be that large.
4641
19ab8a18
PE
4642 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4643 This is less likely to overflow, and avoids undefined behavior if
4644 overflow does occur. All callers changed. Use strtoul to scan
4645 for the unsigned long integer.
b7cbbd6f
PE
4646 (pint2hrstr): Simplify and tune code slightly.
4647 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4648
f0641eff
PE
4649 * scroll.c (do_scrolling): Work around GCC bug 48228.
4650 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4651
7f650bb9
PE
4652 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4653 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4654 (validate_x_resource_name): Simplify count usage.
4655 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4656
37dd57d1
PE
4657 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4658 fail (Bug#8306).
81e56e61 4659
699979fc 4660 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4661
401bf9b4
PE
4662 * process.c (Fmake_network_process): Use socklen_t, not int,
4663 where POSIX says socklen_t is required in portable programs.
4664 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4665 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4666 (Fmake_network_process, server_accept_connection):
4667 (wait_reading_process_output, read_process_output):
4668 Likewise.
4669
b93aacde
PE
4670 * process.c: Rename or move locals to avoid shadowing.
4671 (list_processes_1, Fmake_network_process):
4672 (read_process_output_error_handler, exec_sentinel_error_handler):
4673 Rename or move locals.
4dc343ee 4674 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4675 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4676 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4677 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4678 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4679
af8a867c 4680 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4681 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4682 Include tparam.h instead, since it declares them.
af8a867c
PE
4683 * cm.h (PC): Remove extern decl; tparam.h now does this.
4684 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4685 * terminfo.c: Include tparam.h, to check interfaces.
4686 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4687 (tparam): Adjust signature to match interface in tparam.h;
4688 this removes some undefined behavior. Check that outstring and len
4689 are zero, which they always are with Emacs.
4690 * tparam.h (PC, BC, UP): New extern decls.
4691
0248044d 4692 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4693 (xftfont_open): Rename locals to avoid shadowing.
0248044d 4694
8ff096c1 4695 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
4696 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4697 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 4698 (ftfont_list): Remove unused local.
49eaafba
PE
4699 (get_adstyle_property, ftfont_pattern_entity):
4700 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4701 Rename locals to avoid shadowing.
8ff096c1 4702
e2be39f6
PE
4703 * xfont.c (xfont_list_family): Mark var as initialized.
4704
c9735e30
PE
4705 * xml.c (make_dom): Now static.
4706
8f5201ae
PE
4707 * composite.c (composition_compute_stop_pos): Rename local to
4708 avoid shadowing.
b246f932
PE
4709 (composition_reseat_it): Remove unused locals.
4710 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 4711 (composition_update_it): Mark var as initialized.
11b61122
PE
4712 (find_automatic_composition): Mark vars as initialized,
4713 with a FIXME (Bug#8290).
8f5201ae 4714
760fbc2c
PE
4715 character.h: Rename locals to avoid shadowing.
4716 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4717 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4718 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4719 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4720 to avoid shadowing.
4721
ff08eb85
PE
4722 * textprop.c (property_change_between_p): Remove; unused.
4723
fc7bf025
PE
4724 * intervals.c (interval_start_pos): Now static.
4725
235d7abc
PE
4726 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4727
44f230aa
SM
4728 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4729 Rename locals to avoid shadowing.
3e7d6594 4730
50060332
PE
4731 * sound.c (wav_play, au_play, Fplay_sound_internal):
4732 Fix pointer signedness.
d01f234b 4733 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4734 (wav_play): Initialize a variable to 0, to prevent undefined
4735 behavior (Bug#8278).
50060332 4736
c4fc4e30
PE
4737 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4738
918436ed
PE
4739 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4740
c939f91b
PE
4741 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4742 clobbering (Bug#8298).
b9c7f648
PE
4743 * sysdep.c (sys_subshell): Likewise.
4744 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4745
6bd8c144
PE
4746 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4747 This should get cleaned up, so that child_setup has the
4748 same signature on all platforms.
4749
7710357c 4750 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4751 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4752
c59da222
CY
47532011-03-22 Chong Yidong <cyd@stupidchicken.com>
4754
4755 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4756 not to be necessary, and produces flickering.
4757
66b87493
GM
47582011-03-20 Glenn Morris <rgm@gnu.org>
4759
4760 * config.in: Remove file.
4761
45b6f6d5
JB
47622011-03-20 Juanma Barranquero <lekktu@gmail.com>
4763
4764 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4765 are now in src/globals.h.
4766 (syms_of_minibuf): Remove spurious & from previous change.
4767
3ec03f7e
LL
47682011-03-20 Leo <sdl.web@gmail.com>
4769
4770 * minibuf.c (completing-read-function): New variable.
4771 (completing-read-default): Rename from completing-read.
4772 (completing-read): Call completing-read-function.
4773
b14e3e21
CY
47742011-03-19 Juanma Barranquero <lekktu@gmail.com>
4775
4776 * xfaces.c (Fx_load_color_file):
4777 Read color file from absolute filename (bug#8250).
4778
f2b726e6
JB
47792011-03-19 Juanma Barranquero <lekktu@gmail.com>
4780
4781 * makefile.w32-in: Update dependencies.
4782
09f6ff02
EZ
47832011-03-17 Eli Zaretskii <eliz@gnu.org>
4784
4785 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4786
29a6015a
PE
47872011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4788
a3a6c54e
PE
4789 Fix more problems found by GCC 4.5.2's static checks.
4790
b766f867
PE
4791 * process.c (make_serial_process_unwind, send_process_trap):
4792 (sigchld_handler): Now static.
4793
be02381c
PE
4794 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4795 That way, the code declares only the vars that it needs.
4796 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4797 * s/cygwin.h (PTY_ITERATION): Likewise.
4798 * s/darwin.h (PTY_ITERATION): Likewise.
4799 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4800
57048744
PE
4801 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4802 * process.c (allocate_pty): Don't declare stb unless it's needed.
4803
7914961c 4804 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4805 (CONSTANTLIM): Remove; unused.
4806 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4807 Define only if needed.
7914961c 4808
b3967b18
PE
4809 * unexelf.c (unexec): Name an expression,
4810 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4811 Use a different way to cause a compilation error if anyone uses
4812 n rather than nn, a way that does not involve shadowing.
73366a00 4813 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4814
29a6015a
PE
4815 * deps.mk (unexalpha.o): Remove; unused.
4816
43cfc33e 4817 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4818 * unexec.h: New file.
ce701a33
PE
4819 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4820 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4821 Depend on unexec.h.
4822 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4823 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4824 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4825 Change as necessary to match prototype in unexec.h.
ce701a33 4826
01f44d5a
PE
4827 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4828 shadowing.
4f63c6bb 4829 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4830
a6670b0b
PE
4831 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4832 Rename locals to avoid shadowing.
4833
cef2010d 4834 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4835 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4836
d4d7173a
PE
4837 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4838
f08b802a
PE
4839 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4840 warning when compiling print.c.
4841
3ddb0639
PE
4842 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4843 instead of using an uninitialized var.
5ad03b97 4844 (font_sort_entities): Mark var as initialized.
3ddb0639 4845
170a2692
PE
4846 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4847
e663c700
PE
4848 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4849 pointers to constants.
89bc529a 4850 (font_parse_fcname): Remove unused vars.
7b81e2d0 4851 (font_delete_unmatched): Now static.
ea838e10 4852 (font_get_spec): Remove; unused.
13a547c6
PE
4853 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4854 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4855 Rename or move locals to avoid shadowing.
e663c700 4856
2a80c887 4857 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4858 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4859
1384fa33 4860 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4861 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4862
8b2c52e9
PE
4863 * alloc.c (mark_backtrace): Move decl from here ...
4864 * lisp.h: ... to here, so that it can be checked.
4865
475545b5 4866 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4867 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4868 (lisp_indirect_variable): Name an expression,
4869 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4870 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4871
b1349114 4872 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4873 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4874 Use const pointer when appropriate.
b1349114 4875
a2928364
PE
4876 * lisp.h (get_system_name, get_operating_system_release):
4877 Move decls here, to check interfaces.
4878 * process.c (get_operating_system_release): Move decl to lisp.h.
4879 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4880 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4881 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4882 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4883 (Fformat_time_string, Fencode_time, Finsert_char):
4884 (Ftranslate_region_internal, Fformat):
4885 Rename or remove local vars to avoid shadowing.
9710023e 4886 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4887
a415e694
PE
4888 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4889 avoid shadowing.
4890
8ef4622d
PE
4891 * lisp.h (eassert): Check that the argument compiles, even if
4892 ENABLE_CHECKING is not defined.
4893
946f9a5b
PE
4894 * data.c (Findirect_variable): Name an expression, to avoid
4895 gcc -Wbad-function-cast warning.
112396d6 4896 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4897 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4898 (Fmake_variable_buffer_local, Fmake_local_variable):
4899 Mark variables as initialized.
52746918 4900 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4901
e5aab7e7 4902 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4903 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4904 Rename locals to avoid shadowing.
dff45157
PE
4905 (mark_stack): Move local variables into the #ifdef region where
4906 they're used.
7bc26fdb
PE
4907 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4908 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4909 needed otherwise.
4910 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4911 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4912 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4913
e5aab7e7
PE
4914 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4915 avoids undefined behavior in theory.
4916
4da60324
PE
4917 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4918
88043301
PE
4919 Use functions, not macros, for up- and down-casing (Bug#8254).
4920 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4921 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4922 to use the following functions instead of these macros.
4923 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4924 EMACS_INT, since callers assume the returned value fits in int.
4925 (upcase1): Likewise, for UPCASE_TABLE.
4926 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4927 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4928 the race-condition problem in the old DOWNCASE.
88043301 4929
19ed5445
PE
4930 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4931 Rename locals to avoid shadowing.
4932 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4933 (regex_compile, re_search_2, re_match_2_internal):
4934 Remove unused local vars.
952db0d7
PE
4935 (FREE_VAR): Rewrite so as not to use empty "else",
4936 which gcc can warn about.
da053e48 4937 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4938 (RETALLOC_IF): Define only if needed.
4939 (WORDCHAR_P): Likewise. This one is never needed, but is used
4940 only in a comment talking about a compiler bug, so put inside
4941 the #if 0 of that comment.
4942 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4943 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4944 Remove; unused.
19ed5445 4945
1f3561e4 4946 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4947 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4948 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4949
ded6f8f7
PE
4950 * search.c (simple_search): Remove unused var.
4951
dbd37a95
PE
4952 * dired.c (compile_pattern): Move decl from here ...
4953 * lisp.h: ... to here, so that it can be checked.
4954 (struct re_registers): New forward decl.
4955
7e47afad
PE
4956 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4957
85f24f61
PE
4958 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4959 All uses changed.
4960 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4961 Rename locals to avoid shadowing.
5671df8f 4962 (Fvertical_motion): Mark locals as initialized.
85f24f61 4963
181aa2be 4964 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4965 (casify_region): Mark local as initialized.
181aa2be 4966
930d429c
PE
4967 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4968
7082eac6
PE
4969 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4970 New macros, so that the caller can use some names other than
4971 gcpro1, gcpro2, etc.
4972 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4973 of the new macros.
4974 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4975 argument, for consistency with GCPRO2_VAR, etc: it is now the
4976 prefix of the variable, not the variable itself. All uses
4977 changed.
38b2c076
PE
4978 * dired.c (directory_files_internal, file_name_completion):
4979 Rename locals to avoid shadowing.
4980
15206ed9
PE
4981 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4982 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4983 dired.c's scmp function, had undefined behavior.
4984 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4985 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4986 * buffer.h: ... to here, because these macros use current_buffer,
4987 and the new implementation with inline functions needs to have
4988 current_buffer in scope now, rather than later when the macros
4989 are used.
4990 (downcase, upcase1): New static inline functions.
4991 (DOWNCASE, UPCASE1): Reimplement using these functions.
4992 This avoids undefined behavior in expressions like
4993 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4994 from race conditions in accessing the global variables
4995 case_temp1 and case_temp2.
4996 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4997 * lisp.h (case_temp1, case_temp2): Remove their decls.
4998 * character.h (ASCII_CHAR_P): Move from here ...
4999 * lisp.h: ... to here, so that the inline functions mentioned
5000 above can use them.
5001
4a6bea26
PE
5002 * dired.c (directory_files_internal_unwind): Now static.
5003
f14b7e14
PE
5004 * fileio.c (file_name_as_directory, directory_file_name):
5005 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5006 Now static.
2893f146
PE
5007 (file_name_as_directory): Use const pointers when appropriate.
5008 (Fexpand_file_name): Likewise. In particular, newdir might
5009 point at constant storage, so make it a const pointer.
fd4ead52 5010 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5011 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5012 signedness issues.
f839df0c
PE
5013 (Fset_file_times, Finsert_file_contents, auto_save_error):
5014 Rename locals to avoid shadowing.
f14b7e14 5015
5716756e 5016 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5017 (Ftry_completion, Fall_completions): Rename or remove locals
5018 to avoid shadowing.
5716756e 5019
b4c3046a
PE
5020 * marker.c (bytepos_to_charpos): Remove; unused.
5021
b45db522
PE
5022 * lisp.h (verify_bytepos, count_markers): New decls,
5023 so that gcc does not warn that these functions aren't declared.
5024
85876d07
PE
5025 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5026 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5027 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5028 (copy_text): Remove unused local var.
85876d07 5029
03d78a21 5030 * filelock.c (within_one_second): Now static.
b3dd38ab 5031 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5032
5df8f01b
PE
5033 * buffer.c (fix_overlays_before): Mark locals as initialized.
5034 (fix_start_end_in_overlays): Likewise. This function should be
5035 simplified by using pointers-to-pointers, but that's a different
5036 matter.
b1d876f1 5037 (switch_to_buffer_1): Now static.
8f54f30a
PE
5038 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5039 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5040
a70072c9 5041 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5042 Fix pointer signedness issue.
edced198
PE
5043 (sys_subshell): Mark local as volatile if checking for lint,
5044 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5045 (MAXPATHLEN): Define only if needed.
a70072c9 5046
a0977c44
PE
5047 * process.c (serial_open, serial_configure): Move decls from here ...
5048 * systty.h: ... to here, so that they can be checked.
5049
a884fdcc
PE
5050 * fns.c (get_random, seed_random): Move extern decls from here ...
5051 * lisp.h: ... to here, so that they can be checked.
5052
604efe86 5053 * sysdep.c (reset_io): Now static.
b8950c94 5054 (wait_for_termination_signal): Remove; unused.
604efe86 5055
38fc62d9
PE
5056 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5057 (copy_keymap_item, append_key, push_text_char_description):
5058 Now static.
1004a21a 5059 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5060 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5061 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5062 (describe_map_tree):
5063 Rename locals to avoid shadowing.
38fc62d9 5064
2f2650da
PE
5065 * keyboard.c: Declare functions static if they are not used elsewhere.
5066 (echo_char, echo_dash, cmd_error, top_level_2):
5067 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5068 (read_char, kbd_buffer_get_event, make_lispy_position):
5069 (make_lispy_event, make_lispy_movement, apply_modifiers):
5070 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5071 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5072 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5073 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5074 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5075
a053e86c 5076 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5077 (mark_kboards): Move decl here ...
5078 * alloc.c (mark_kboards): ... from here.
a053e86c 5079
4752793e
PE
5080 * lisp.h (force_auto_save_soon): New decl.
5081
74f10ca7 5082 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5083 (DEFINE_DUMMY_FUNCTION): New macro.
5084 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5085 Use it.
c03cd23f
PE
5086 (main): Add casts to avoid warnings
5087 if GCC considers string literals to be constants.
74f10ca7 5088
022e70d4
PE
5089 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5090
59d6fe83
PE
5091 * dbusbind.c: Pointer signedness fixes.
5092 (xd_signature, xd_append_arg, xd_initialize):
5093 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5094 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5095 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5096 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5097
78320123
PE
5098 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5099 if GCC considers string literals to be constants.
49cebcca 5100 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5101
35ac2a97
SM
51022011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5103
fb103ca9
SM
5104 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5105 (print_preprocess, print_object): New macro to fix last change.
5106
35ac2a97
SM
5107 * print.c (print_preprocess): Don't forget font objects.
5108
62973b41
JB
51092011-03-16 Juanma Barranquero <lekktu@gmail.com>
5110
5111 * emacs.c (USAGE3): Doc fixes.
5112
0e48bb22
AS
51132011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5114
5115 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5116 structure.
5117
7684e57b
JB
51182011-03-14 Juanma Barranquero <lekktu@gmail.com>
5119
5120 * lisp.h (VWindow_system, Qfile_name_history):
5121 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5122 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5123 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5124
5125 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5126 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5127
5128 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5129 * w32console.c (detect_input_pending, read_input_pending)
5130 (encode_terminal_code):
5131 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5132 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5133 (w32_system_caret_y, Qfile_name_history):
5134 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5135 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5136 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5137 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5138 * w32proc.c (Qlocal, report_file_error):
5139 * w32term.c (Vwindow_system, updating_frame):
5140 * w32uniscribe.c (initialized, uniscribe_font_driver):
5141 Remove unneeded extern declarations.
5142
2aa46d6c
CY
51432011-03-14 Chong Yidong <cyd@stupidchicken.com>
5144
c96bbc66 5145 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5146
cffc6f3b
CY
51472011-03-13 Chong Yidong <cyd@stupidchicken.com>
5148
5149 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5150 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5151 These macros can no longer be used for assignment.
5152
44f230aa
SM
5153 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5154 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5155 (record_buffer_markers, fetch_buffer_markers): New functions for
5156 recording and fetching special buffer markers.
5157 (set_buffer_internal_1, set_buffer_temp): Use them.
5158
5159 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5160
5161 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5162
5163 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5164 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5165
5166 * xdisp.c (hscroll_window_tree):
5167 (reconsider_clip_changes): Use PT instead of BUF_PT.
5168
d251f04b
EZ
51692011-03-13 Eli Zaretskii <eliz@gnu.org>
5170
5171 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5172 $(EMACS_ROOT)/lib/intprops.h.
5173
f0c77cd1
PE
51742011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5175
3eca4629
PE
5176 Fix more problems found by GCC 4.5.2's static checks.
5177
7c86ee98
PE
5178 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5179 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5180 (xg_free_frame_widgets): Make it clear that a local variable is
5181 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5182 (gdk_window_get_screen): Make it clear that this macro is needed
5183 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5184 (int_gtk_range_get_value): New function, which avoids a diagnostic
5185 from gcc -Wbad-function-cast.
5186 (xg_set_toolkit_scroll_bar_thumb): Use it.
5187 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5188 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5189 (get_utf8_string, xg_get_file_with_chooser):
5190 Rename locals to avoid shadowing.
5191 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5192
41729b81
PE
5193 * xgselect.c (xg_select): Remove unused var.
5194
f0c77cd1
PE
5195 * image.c (four_corners_best): Mark locals as initialized.
5196 (gif_load): Initialize transparent_p to zero (Bug#8238).
5197 Mark another local as initialized.
ec6cf4c6 5198 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5199
ce0ad53d 5200 * image.c (clear_image_cache): Now static.
d5d5a617 5201 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5202 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5203 (x_edge_detection): Remove unnecessary cast that
5204 gcc -Wbad-function-cast diagnoses.
2037898d 5205 (gif_load): Fix pointer signedness.
6ae141d6
PE
5206 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5207 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5208
33383987 52092011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5210
d32df629
PE
5211 Improve quality of tests for time stamp overflow.
5212 For example, without this patch (encode-time 0 0 0 1 1
5213 1152921504606846976) returns the obviously-bogus value (-948597
5214 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5215 reports time overflow. See
5216 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5217 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5218 * editfns.c: Include limits.h and intprops.h.
5219 (TIME_T_MIN, TIME_T_MAX): New macros.
5220 (time_overflow): Move earlier, to before first use.
5221 (hi_time, lo_time): New functions, for an accurate test for
5222 out-of-range times.
5223 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5224 (Fget_internal_run_time): Don't assume time_t fits in int.
5225 (make_time): Use list2 instead of Fcons twice.
5226 (Fdecode_time): More accurate test for out-of-range times.
5227 (check_tm_member): New function.
5228 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5229 (lisp_time_argument): Don't rely on undefined left-shift and
5230 right-shift behavior when checking for time stamp overflow.
8be6f318 5231
fe31d94c
PE
5232 * editfns.c (time_overflow): New function, refactoring common code.
5233 (Fformat_time_string, Fdecode_time, Fencode_time):
5234 (Fcurrent_time_string): Use it.
5235
8be6f318
PE
5236 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5237 * dired.c (make_time): Move to ...
5238 * editfns.c (make_time): ... here.
5239 * systime.h: Note the move.
5240
09d9db2c 52412011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 5242
126bc0dc
YM
5243 * fringe.c (update_window_fringes): Remove unused variables.
5244
c47cbdfd
YM
5245 * unexmacosx.c (copy_data_segment): Also copy __got section.
5246 (Bug#8223)
5247
7ac80be9
EZ
52482011-03-12 Eli Zaretskii <eliz@gnu.org>
5249
c96bbc66 5250 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5251 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5252 Constify `char *' arguments and their references according to
5253 prototypes in tparam.h.
5254
ecb0f94d 5255 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5256
7ac80be9
EZ
5257 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5258 Adapt all references accordingly.
5259
5260 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5261
ef1fd07e
TT
52622011-03-11 Tom Tromey <tromey@redhat.com>
5263
5264 * buffer.c (syms_of_buffer): Remove obsolete comment.
5265
7ef4b50c
EZ
52662011-03-11 Eli Zaretskii <eliz@gnu.org>
5267
5268 * termhooks.h (encode_terminal_code): Declare prototype.
5269
5270 * msdos.c (encode_terminal_code): Don't declare prototype.
5271
5272 * term.c (encode_terminal_code): Now external again, used by
5273 w32console.c and msdos.c.
5274
44f230aa
SM
5275 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5276 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 5277
4b1ec863 52782011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 5279
1714f52b 5280 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 5281
4b1ec863
PE
5282 * fringe.c (update_window_fringes): Mark locals as initialized
5283 (Bug#8227).
5284 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 5285
524c7aa6
PE
5286 * alloc.c (mark_fringe_data): Move decl from here ...
5287 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5288 to check its interface.
5289 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5290
a5c0af81 5291 * fontset.c (free_realized_fontset): Now static.
7519b8cd 5292 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 5293 (fontset_font): Mark local as initialized.
a9a06e0b 5294 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 5295
b4716021
PE
5296 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5297
811e9bac 5298 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 5299 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
5300 (x_own_selection, Fx_disown_selection_internal): Rename locals
5301 to avoid shadowing.
5302 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 5303
7e3ab302
PE
5304 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5305 so that the caller can use some name other than gcpro1.
5306 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
5307 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5308 (Fx_backspace_delete_keys_p):
5309 Use them to avoid shadowing, and rename vars to avoid shadowing.
5310 (x_decode_color, x_set_name, x_window): Now static.
6b437900 5311 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 5312 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
5313 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5314 Remove unused locals.
7e3ab302
PE
5315 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5316 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5317 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5318 macros.
f78faa98 5319
e2b13473
PE
5320 * xterm.h (x_mouse_leave): New decl.
5321
77f23912
PE
5322 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5323 Remove unused functions.
cdf4ba58
PE
5324 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5325 (x_calc_absolute_position): Now static.
7411c686 5326 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5327 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5328 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5329 unless they are used.
38d0b34a
PE
5330 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5331 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5332 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5333 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5334 (x_error_catcher, x_connection_closed, x_error_handler):
5335 (x_error_quitter, xembed_send_message, x_iconify_frame):
5336 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5337 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5338 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5339
44f230aa
SM
5340 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5341 Rename or move locals to avoid shadowing.
6b463e58 5342 (tty_defined_color, merge_face_heights): Now static.
5967d051 5343 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5344 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5345 does not deduce is never used uninitialized.
73719eba
PE
5346 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5347 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5348
426994c3 5349 * terminal.c (store_terminal_param): Now static.
5489860b 5350
032f1620 5351 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5352 (set_frame_menubar): Remove unused local.
d4323972 5353 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5354 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5355 since they might point to immutable storage.
281585b0
PE
5356 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5357 since it's unused otherwise.
032f1620 5358
367c19e5 5359 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5360 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5361 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5362 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5363 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5364 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5365 does not deduce are never used uninitialized.
70739cbe 5366
07b48fa9
PE
5367 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5368
8868a238 5369 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5370 * window.c (window_loop, size_window):
5371 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5372
7e5cf297 5373 * window.c (display_buffer): Now static.
d6550a9f
PE
5374 (size_window): Mark variables that gcc -Wuninitialized
5375 does not deduce are never used uninitialized.
a586633d
PE
5376 * window.h (check_all_windows): New decl, to forestall
5377 gcc -Wmissing-prototypes diagnostic.
5b555da1 5378 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 5379
f6095868
PE
5380 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5381 shadowing.
5382 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5383 Include <limits.h>.
5384 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5385 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5386 (load_charset_map): Mark variables that gcc -Wuninitialized
5387 does not deduce are never used uninitialized.
53df7c11 5388 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5389
f38b440c
PE
5390 * coding.c (coding_set_source, coding_set_destination):
5391 Use "else { /* comment */ }" rather than "else /* comment */;"
5392 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5393 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5394 a block, when the outer 'i' will do.
5395 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5396 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5397 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5398 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5399 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5400 Rename locals to avoid shadowing.
5401 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5402 * coding.c (emacs_mule_char, encode_invocation_designation):
5403 Now static, since they're not used elsewhere.
413bb2db 5404 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5405 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5406 (decode_coding_emacs_mule): Mark variables that gcc
5407 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5408 (detect_coding_iso_2022): Initialize a local variable that might
5409 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5410 this initialization is needed. (Bug#8211)
5f58e762
PE
5411 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5412 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5413 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5414 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5415 Remove unused macros.
f38b440c 5416
232b38b9 5417 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5418 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5419 * character.c (string_count_byte8): Likewise.
232b38b9 5420
fb90da1b
PE
5421 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5422 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5423
fb93dbc2
PE
5424 * chartab.c (copy_sub_char_table): Now static, since it's not used
5425 elsewhere.
5c156ace
PE
5426 (sub_char_table_ref_and_range, char_table_ref_and_range):
5427 Rename locals to avoid shadowing.
bbcd0949 5428 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5429
7d3b3862 5430 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5431 (BIDI_BOB): Remove unused macro.
7d3b3862 5432
6be7d3da
PE
5433 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5434 deduce are never used uninitialized.
c2ed9c8b 5435 * term.c (encode_terminal_code): Likewise.
6be7d3da 5436
75f8807f 5437 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5438
50938595
PE
5439 * tparam.h: New file.
5440 * term.c, tparam.h: Include it.
5441 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5442 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5443 Move these decls to tparam.h, and make them agree with what
5444 is actually in tparam.c. The previous trick of using incompatible
5445 decls in different modules does not conform to the C standard.
5446 All callers of tparam changed to use tparam's actual API.
5447 * tparam.c (tparam1, tparam, tgoto):
5448 Use const pointers where appropriate.
5449
fbceeba2
PE
5450 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5451 * cm.h (struct cm): Likewise.
5452 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5453 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5454 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5455 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5456 (turn_on_face, init_tty): Likewise.
5457 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5458
7f3f1250
PE
5459 * term.c (term_mouse_position): Rename local to avoid shadowing.
5460
e6ca6543
PE
5461 * alloc.c (mark_ttys): Move decl from here ...
5462 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5463
c40f8d15
AS
54642011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5465
5466 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5467
cfe0661d
JB
54682011-03-09 Juanma Barranquero <lekktu@gmail.com>
5469
5470 * search.c (compile_pattern_1): Remove argument regp, unused since
5471 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5472 (compile_pattern): Don't pass it.
5473
0afb4571
J
54742011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5475
5476 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5477 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5478 for ! HAVE_GTK3.
5479 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5480
5481 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5482
5483 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5484 gdk_window_get_screen, gdk_window_get_geometry,
5485 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5486 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5487 (xg_get_pixbuf_from_pixmap): New function.
5488 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5489 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5490 Call xg_get_pixbuf_from_pixmap instead of
5491 gdk_pixbuf_get_from_drawable.
5492 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5493 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5494 (xg_check_special_colors): Use GtkStyleContext and its functions
5495 for HAVE_GTK3.
5496 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5497 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5498 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5499 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5500 Call gtk_widget_get_preferred_size.
0afb4571
J
5501 (xg_frame_resized): gdk_window_get_geometry only takes 5
5502 parameters.
44f230aa
SM
5503 (xg_win_to_widget, xg_event_is_for_menubar):
5504 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5505 (xg_set_widget_bg): New function.
5506 (delete_cb): New function.
895009e1 5507 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5508 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5509 (xg_set_background_color): Call xg_set_widget_bg.
5510 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5511 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5512 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5513 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5514 if ! HAVE_GTK3.
5515 (update_frame_tool_bar): Call gtk_widget_hide.
5516 (xg_initialize): Use GDK_KEY_g.
5517
5518 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5519 if ! HAVE_GTK3
5520 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5521
5522 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5523 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5524 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5525
1c2cc4ef
JB
55262011-03-08 Juanma Barranquero <lekktu@gmail.com>
5527
5528 * w32xfns.c (select_palette): Check success of RealizePalette against
5529 GDI_ERROR, not zero.
5530
33383987 5531See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5532
5533;; Local Variables:
5534;; coding: utf-8
aac0c6e3
MR
5535;; End:
5536
33383987 5537 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5538
5539 This file is part of GNU Emacs.
5540
5541 GNU Emacs is free software: you can redistribute it and/or modify
5542 it under the terms of the GNU General Public License as published by
5543 the Free Software Foundation, either version 3 of the License, or
5544 (at your option) any later version.
5545
5546 GNU Emacs is distributed in the hope that it will be useful,
5547 but WITHOUT ANY WARRANTY; without even the implied warranty of
5548 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5549 GNU General Public License for more details.
5550
5551 You should have received a copy of the GNU General Public License
5552 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.