rgrep ignored file tweak
[bpt/emacs.git] / src / ChangeLog
CommitLineData
de8c03dc
SM
12012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2
3 * window.c (save_window_save): Obey window-point-insertion-type.
4
2f097256
GM
52012-04-11 Glenn Morris <rgm@gnu.org>
6
7 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
8
453b951e
SM
92012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
10
11 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
12
6bbef4e5
JC
132012-04-10 "Jason S. Cornez" <jcornez@ravenpack.com> (tiny change)
14
15 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
16 (force_quit_count): New var.
17 (handle_interrupt): Use it.
18
2a8ce227
JB
192012-04-10 Juanma Barranquero <lekktu@gmail.com>
20
21 * w32.c (w32_delayed_load): Record the full path of the library
22 being loaded (bug#10424).
23
935396c0
GM
242012-04-09 Glenn Morris <rgm@gnu.org>
25
05920a43
GM
26 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
27 not just in the obarray, before snarfing them. (Bug#11036)
28
935396c0
GM
29 * Makefile.in ($(leimdir)/leim-list.el):
30 Pass EMACS rather than BUILT_EMACS.
31
a18ecafa
TZ
322012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
33
34 * process.c (make_process):
35 * process.h: Add integer `gnutls_handshakes_tried' member to
36 process struct.
37
6bbef4e5
JC
38 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
39 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
40
41 * gnutls.c (gnutls_log_function2i): Convenience log function.
42 (emacs_gnutls_read): Use new log functions,
43 `gnutls_handshakes_tried' process member, and
44 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
45 attempts per process (connection).
46
b4d3bc10
CY
472012-04-09 Chong Yidong <cyd@gnu.org>
48
49 * eval.c (Fuser_variable_p, user_variable_p_eh)
50 (lisp_indirect_variable): Functions deleted.
51 (Fdefvar): Caller changed.
52
53 * callint.c (Finteractive, Fcall_interactively):
54 * minibuf.c (Fread_variable): Callers changed.
55
70f4d973
EZ
562012-04-09 Eli Zaretskii <eliz@gnu.org>
57
58 * xdisp.c (set_cursor_from_row): If the display string appears in
59 the buffer at position that is closer to point than the position
60 after the display string, display the cursor on the first glyph of
61 the display string. Fixes cursor display when a 'display' text
62 property immediately follows invisible text. (Bug#11094)
63
cb3c2e3e
PE
642012-04-09 Paul Eggert <eggert@cs.ucla.edu>
65
66 composite.c: use 'double' consistently
67 * composite.c (get_composition_id): Use 'double' consistently
68 instead of converting 'float' to 'double' and vice versa; this is
69 easier to understand and avoids a GCC warning.
70
fd06db5d
GM
712012-04-09 Glenn Morris <rgm@gnu.org>
72
50fe702a
GM
73 * Makefile.in: Generate leim-list with bootstrap-emacs, in
74 preparation for dumping it with emacs. (Bug#4789)
75 (leimdir): New variable.
76 ($(leimdir)/leim-list.el): New rule.
77 (emacs$(EXEEXT)): Depend on leim-list.el.
78
fd06db5d
GM
79 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
80 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
81 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
82
55c131ee
AS
832012-04-08 Andreas Schwab <schwab@linux-m68k.org>
84
85 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
86 proper alignment.
87
9209588f
JB
882012-04-07 Juanma Barranquero <lekktu@gmail.com>
89
90 * xml.c (init_libxml2_functions) [WINDOWSNT]:
91 Remove unused local variable.
92
e3fb2efb
PE
932012-04-07 Paul Eggert <eggert@cs.ucla.edu>
94
95 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
96 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
97 (mark_memory): Mark Lisp_Objects only if pointers might hide in
98 objects, as mark_maybe_pointer will catch them otherwise.
99 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
100 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
101
b5385551
PE
1022012-04-07 Paul Eggert <eggert@cs.ucla.edu>
103
104 Fix typo that broke non-Windows builds.
105 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
106
9078ead6
EZ
1072012-04-07 Eli Zaretskii <eliz@gnu.org>
108
109 Support building on MS-Windows with libxml2.
110
111 * makefile.w32-in (OBJ2): Add xml.$(O).
112 (GLOBAL_SOURCES): Add xml.c.
113 ($(BLD)/xml.$(O)): New dependency list.
114
115 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
116 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
117 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
118 [!WINDOWSNT]: New macros.
119 (init_libxml2_functions, libxml2_loaded_p): New functions.
120 (parse_region): Call fn_xmlCheckVersion instead of using the macro
121 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
122 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
123 Calls xmlCleanupParser only if libxml2 was loaded (or statically
124 linked in).
6bbef4e5
JC
125 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
126 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
127 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
128
129 * emacs.c: Don't include libxml/parser.h.
130 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
131 xmlCleanupParser directly.
132
133 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
134
3811fdf3
EZ
1352012-04-07 Eli Zaretskii <eliz@gnu.org>
136
137 * indent.c (Fvertical_motion): If there is a display string at
138 point, use it.vpos to compute how many lines to backtrack after
139 move_it_to point. (Bug#11133)
140
2f8e16b2
EZ
1412012-04-06 Eli Zaretskii <eliz@gnu.org>
142
143 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
144 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
145 about subtle differences between FETCH_CHAR* and STRING_CHAR*
146 macros related to unification of CJK characters. For the details,
147 see the discussion following the message here:
148 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
149
3d439cd1
CY
1502012-04-04 Chong Yidong <cyd@gnu.org>
151
152 * keyboard.c (Vdelayed_warnings_list): Doc fix.
153
8bc53d00
EZ
1542012-04-01 Eli Zaretskii <eliz@gnu.org>
155
156 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
157 instead of alloca. (Bug#11138)
158
3b0512a3
AS
1592012-04-01 Andreas Schwab <schwab@linux-m68k.org>
160
161 * w32menu.c (is_simple_dialog): Properly check lisp types.
162 (Bug#11141)
163
8427ddd2
EZ
1642012-03-31 Eli Zaretskii <eliz@gnu.org>
165
979022ef
EZ
166 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
167 position we get to after a call to move_it_to fails the
168 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
169 only if we wind up in a string from display property. (Bug#11063)
170
a6b1c7cc
EZ
171 * window.c (Fdelete_other_windows_internal): Invalidate the row
172 and column information about mouse highlight, so that redisplay
173 restores it after reallocating the glyph matrices. (Bug#7464)
174
8427ddd2
EZ
175 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
176 string comes from a `display' text property, use the buffer
177 position of that property as if we actually saw that position in
178 the row's glyphs.
697ba24b
EZ
179 (move_it_by_lines): Remove the assertion that
180 "it->current_x == 0 && it->hpos == 0" which can be legitimately
181 violated when there's a before-string at the beginning of a line.
182 (Bug#11063)
8427ddd2 183
65a0a738
EZ
1842012-03-30 Eli Zaretskii <eliz@gnu.org>
185
186 * xdisp.c (append_space_for_newline): If the default face was
187 remapped, use the remapped face for the appended newline.
188 (extend_face_to_end_of_line): Use the remapped default face for
189 extending the face to the end of the line.
190 (display_line): Call extend_face_to_end_of_line when the default
191 face was remapped. (Bug#11068)
192
581355cc
EZ
1932012-03-29 Eli Zaretskii <eliz@gnu.org>
194
195 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
196
e8fc049f
SM
1972012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
198
199 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
200
4fb9a543
GM
2012012-03-27 Glenn Morris <rgm@gnu.org>
202
203 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
204 Doc fixes.
205
679910f1
KH
2062012-03-26 Kenichi Handa <handa@m17n.org>
207
208 * dispextern.h (struct glyph): Fix previous change. Change the
209 bit length of glyphless.ch to 25 (Bug#11082).
210
90d49b7f
CY
2112012-03-26 Chong Yidong <cyd@gnu.org>
212
213 * keyboard.c (Vselection_inhibit_update_commands): New variable.
214 (command_loop_1): Use it; inhibit selection update for
215 handle-select-window too (Bug#8996).
216
f514f6f0
FP
2172012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
218
e8fc049f 219 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 220
bf43fa51
KH
2212012-03-25 Kenichi Handa <handa@m17n.org>
222
223 * dispextern.h (struct glyph): Change the bit length of
224 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
225
8a0c01dd
EZ
2262012-03-24 Eli Zaretskii <eliz@gnu.org>
227
228 * s/ms-w32.h (tzname): Include time.h before redirecting to
229 _tzname. Fixes the MSVC build. (Bug#9960)
230
7d1c3a76
AS
2312012-03-24 Andreas Schwab <schwab@linux-m68k.org>
232
8ed79523
AS
233 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
234 characters.
235
7d1c3a76
AS
236 * xterm.c (XTread_socket): Only modify handling_signal if
237 !SYNC_INPUT. (Bug#11080)
238
e99a9b8b
EZ
2392012-03-23 Eli Zaretskii <eliz@gnu.org>
240
241 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
242 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
243 when fetching a multibyte character consumes more bytes than
244 CHAR_BYTES returns, due to unification of CJK characters in
245 string_char. (Bug#11073)
246
5063c0e1
TN
2472012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
248
249 * process.c (wait_reading_process_output): Handle pty disconnect
250 by refraining from sending oneself a SIGCHLD (bug#10933).
251
9f851fbd
CY
2522012-03-22 Chong Yidong <cyd@gnu.org>
253
254 * dispextern.h (struct it): New member string_from_prefix_prop_p.
255
5063c0e1 256 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
257 Mark string as coming from a prefix property.
258 (handle_face_prop): Use default face for prefix strings (Bug#4281).
259 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
260
fb5b8aca
CY
2612012-03-21 Chong Yidong <cyd@gnu.org>
262
263 * xfaces.c (Vface_remapping_alist): Doc fix.
264
62356a1b
EZ
2652012-03-20 Eli Zaretskii <eliz@gnu.org>
266
267 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
268 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
269 Doc fixes.
62356a1b 270
025de85b
CY
2712012-03-20 Chong Yidong <cyd@gnu.org>
272
273 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
274 to reflect default non-nil value of redisplay-dont-pause.
275
4827f94e
KH
2762012-03-19 Kenichi Handa <handa@m17n.org>
277
278 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
279 it fit in a valid range (Bug#11003).
280
e50a24a2
EZ
2812012-03-18 Eli Zaretskii <eliz@gnu.org>
282
283 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
284 that is not from display property, accept the row as a "cursor
285 row" if one of the string's character has a non-nil `cursor'
286 property. Fixes cursor positioning when there are newlines in
287 overlay strings, e.g. in icomplete.el. (Bug#11035)
288
9af5ed87
PE
2892012-03-12 Paul Eggert <eggert@cs.ucla.edu>
290
291 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
292
d1f55f16
CY
2932012-03-12 Chong Yidong <cyd@gnu.org>
294
295 * eval.c (inhibit_lisp_code): Rename from
296 inhibit_window_configuration_change_hook; move from window.c.
297
298 * xfns.c (unwind_create_frame_1, Fx_create_frame):
299 * window.c (run_window_configuration_change_hook)
300 (syms_of_window): Callers changed.
301
66c5eebd
CY
3022012-03-11 Chong Yidong <cyd@gnu.org>
303
413df973
CY
304 * keymap.c (Fkey_description): Doc fix (Bug#9700).
305
66c5eebd
CY
306 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
307
1de11f56
CY
3082012-03-10 Chong Yidong <cyd@gnu.org>
309
310 * frame.c (other_visible_frames): Don't assume the selected frame
311 is visible (Bug#10955).
312
cae07000
SM
3132012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
314
315 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
316
89c94350
JD
3172012-03-08 Jan Djärv <jan.h.d@swipnet.se>
318
319 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
320 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
321 zero (Bug#10954).
322
999dd333
GM
3232012-03-03 Glenn Morris <rgm@gnu.org>
324
01a6dcc8 325 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 326
de0100f2
EZ
3272012-03-02 Eli Zaretskii <eliz@gnu.org>
328
329 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
330 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
331 (redisplay_window, next_element_from_string): Fix typos in
332 comments.
3e441275
EZ
333 (redisplay_window): Pass to move_it_vertically the margin in
334 pixels, not in screen lines.
de0100f2 335
96a72ee9
GM
3362012-03-02 Glenn Morris <rgm@gnu.org>
337
338 * buffer.c (buffer-list-update-hook): Doc fix.
339
312508d7
EZ
3402012-02-29 Eli Zaretskii <eliz@gnu.org>
341
342 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
343 push_it before setting up the iterator for the first overlay
344 string, even if we have an empty string loaded.
345 (next_overlay_string): If there's an empty string on the iterator
346 stack, pop the stack. (Bug#10903)
347
27f3c637
PE
3482012-02-25 Paul Eggert <eggert@cs.ucla.edu>
349
350 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
351 Suggested by Stefan Monnier in
352 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
353 * alloc.c (widen_to_Lisp_Object): New static function.
354 (mark_memory): Also mark Lisp_Objects by fetching pointer words
355 and widening them to Lisp_Objects. This would work even if
356 USE_LSB_TAG is defined and wide integers are used, which might
357 happen in a future version of Emacs.
358
3c9dfce6
CY
3592012-02-25 Chong Yidong <cyd@gnu.org>
360
fa74b241
CY
361 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
362 Doc fix.
363
3c9dfce6
CY
364 * xselect.c (Fx_selection_exists_p): Doc fix.
365 (x_clipboard_manager_save_all): Print an informative message
366 before saving to clipboard manager.
367
9486df08
CY
3682012-02-24 Chong Yidong <cyd@gnu.org>
369
370 * keyboard.c (process_special_events): Handle all X selection
371 requests in kbd_buffer, not just the next one (Bug#8869).
372
f01d3321
CY
3732012-02-23 Chong Yidong <cyd@gnu.org>
374
375 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
376 call when setting menu-bar-lines and tool-bar-lines parameters.
377 (unwind_create_frame_1): New helper function.
378
379 * window.c (inhibit_window_configuration_change_hook): New var.
380 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 381 (syms_of_window): Initialize it.
f01d3321 382
86b847b6
CY
3832012-02-22 Chong Yidong <cyd@gnu.org>
384
385 * xterm.c (x_draw_image_relief): Add missing type check for
386 Vtool_bar_button_margin (Bug#10743).
387
a59225b1
CY
3882012-02-21 Chong Yidong <cyd@gnu.org>
389
390 * fileio.c (Vfile_name_handler_alist): Doc fix.
391
392 * buffer.c (Fget_file_buffer): Protect against invalid file
393 handler return value.
394
310f5bd4
PE
3952012-02-20 Paul Eggert <eggert@cs.ucla.edu>
396
cb3a28cc
PE
397 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
398 when computing $valmask.
399
310f5bd4
PE
400 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
401 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
402 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
403 It's useless in that case, and it can cause problems on hosts
404 that allocate halves of EMACS_INT values separately.
405 Reported by Dan Horák. Diagnosed by Andreas Schwab in
406 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
407 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
408 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
409 it avoids undefined behavior on hosts where shifting right by more
410 than the word width has undefined behavior.
411
2375c96a
CY
4122012-02-19 Chong Yidong <cyd@gnu.org>
413
414 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
415 (Funhandled_file_name_directory, Ffile_name_as_directory)
416 (Fdirectory_file_name, Fexpand_file_name)
417 (Fsubstitute_in_file_name): Protect against invalid file handler
418 return values (Bug#10845).
419
3eb49e71
EZ
4202012-02-18 Eli Zaretskii <eliz@gnu.org>
421
422 * .gdbinit (pitx): Fix incorrect references to fields of the
423 iterator stack.
424
7b926f3f
CY
4252012-02-17 Chong Yidong <cyd@gnu.org>
426
427 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
428
11273115
PE
4292012-02-15 Paul Eggert <eggert@cs.ucla.edu>
430
431 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
432 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
433
c3a70e2b
CY
4342012-02-15 Chong Yidong <cyd@gnu.org>
435
436 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
437 marked as special. Also, starting docstrings with * is obsolete.
438
0ca43699
AS
4392012-02-13 Andreas Schwab <schwab@linux-m68k.org>
440
441 * gnutls.c (emacs_gnutls_write): Fix last change.
442
2e8f3c56
LI
4432012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
444
445 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
446 send_process.
447
af70074f
SM
4482012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
449
450 * keymap.c (Fsingle_key_description): Handle char ranges.
451
95986d52
CY
4522012-02-12 Chong Yidong <cyd@gnu.org>
453
afd83bd1
CY
454 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
455 as that creates a dangerous corner case.
456
95986d52
CY
457 * window.c (Fdelete_window_internal): Invalidate the mouse
458 highlight (Bug#9904).
459
bd7da63e
GM
4602012-02-12 Glenn Morris <rgm@gnu.org>
461
462 * xselect.c (Fx_own_selection_internal)
463 (Fx_get_selection_internal, Fx_disown_selection_internal)
464 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
465 * nsselect.m (Fx_own_selection_internal)
466 (Fx_disown_selection_internal, Fx_selection_exists_p)
467 (Fx_selection_owner_p, Fx_get_selection_internal):
468 Sync docs and argument specs with the xselect.c versions.
469
77abcbc2
LI
4702012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
471
472 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
473
90b671e2
EZ
4742012-02-11 Eli Zaretskii <eliz@gnu.org>
475
1c0ca0b7
EZ
476 * w32select.c (Fx_selection_exists_p): Sync doc string and
477 argument list with xselect.c. (Bug#10783)
478
479 * w16select.c (Fx_selection_exists_p): Sync doc string and
480 argument list with xselect.c. (Bug#10783)
90b671e2 481
49241268
GM
4822012-02-10 Glenn Morris <rgm@gnu.org>
483
484 * fns.c (Fsecure_hash): Doc fix.
485
f998bbe7 4862012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
487
488 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
489
0992bd9c
CY
4902012-02-07 Chong Yidong <cyd@gnu.org>
491
492 * buffer.c (Fbuffer_local_variables)
493 (buffer_lisp_local_variables): Handle unbound vars correctly;
494 don't let Qunbound leak into Lisp.
495
af008560
GM
4962012-02-07 Glenn Morris <rgm@gnu.org>
497
dd605cc4
GM
498 * image.c (Fimagemagick_types): Doc fix.
499
af008560
GM
500 * image.c (imagemagick-render-type): Change it from a lisp object
501 to an integer. Move the doc here from the lisp manual.
502 Treat all values not equal to 0 the same.
503
1449fa1d
CY
5042012-02-06 Chong Yidong <cyd@gnu.org>
505
506 * doc.c (store_function_docstring): Avoid applying docstring of
507 alias to base function (Bug#2603).
508
3723ec07
AS
5092012-02-04 Andreas Schwab <schwab@linux-m68k.org>
510
511 * .gdbinit (pp1, pv1): Remove redundant defines.
512 (pr): Use pp.
513
79c1cc1e
CY
5142012-02-04 Chong Yidong <cyd@gnu.org>
515
516 * nsterm.m: Declare a global (Bug#10694).
517
d7f29f8e
EZ
5182012-02-04 Eli Zaretskii <eliz@gnu.org>
519
cae07000
SM
520 * w32.c (get_emacs_configuration_options):
521 Include --enable-checking, if specified, in the return value.
d7f29f8e 522
3b95a6f9
MR
5232012-02-04 Martin Rudalics <rudalics@gmx.at>
524
525 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
526 after rounding frame sizes. (Bug#9723)
527
d6fa96a6
EZ
5282012-02-04 Eli Zaretskii <eliz@gnu.org>
529
530 * keyboard.c (adjust_point_for_property): Don't position point
531 before BEGV. (Bug#10696)
532
df0b2940
PE
5332012-02-03 Paul Eggert <eggert@cs.ucla.edu>
534
535 Handle overflow when computing char display width (Bug#9496).
536 * character.c (char_width): Return EMACS_INT, not int.
537 (char_width, c_string_width): Check for overflow when
538 computing the width; this is possible now that individual
539 characters can have unbounded width. Problem introduced
540 by merge from Emacs 23 on 2012-01-19.
541
6bee44d6
MA
5422012-02-02 Michael Albinus <michael.albinus@gmx.de>
543
544 * dbusbind.c (Fdbus_register_method): Mention the return value
545 :ignore in the docstring.
546
44f92739
GM
5472012-02-02 Glenn Morris <rgm@gnu.org>
548
1b9f60cc
GM
549 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
550
44f92739
GM
551 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
552 Unconditionally set to t. (Bug#10673)
553 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
554 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
555 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
556
c5d3843c
KH
5572012-02-02 Kenichi Handa <handa@m17n.org>
558
559 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
560 0, do not call append_composite_glyph.
561
159462d4 5622012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
563
564 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
565 NULL (Bug#6988).
566 (x_produce_glyphs): If the component of a composition is a null
567 string, set it->pixel_width to 1 to avoid zero-width glyph.
568
78cef877
EZ
5692012-02-01 Eli Zaretskii <eliz@gnu.org>
570
571 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
572 first 2 arguments are identical. This makes inserting large
573 output from a subprocess an order of magnitude faster on
574 MS-Windows, where all sbrk'ed memory is always contiguous.
575
97897668
GM
5762012-01-31 Glenn Morris <rgm@gnu.org>
577
578 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 579 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
580 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
581
31fd3586
GM
5822012-01-29 Glenn Morris <rgm@gnu.org>
583
584 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
585
0e24a8b2
CY
5862012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
587
588 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
589
cc0adcb0
CY
5902012-01-28 Chong Yidong <cyd@gnu.org>
591
592 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
593
acc28cb9
CY
5942012-01-26 Chong Yidong <cyd@gnu.org>
595
9c69cfb7
CY
596 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
597
acc28cb9
CY
598 * search.c (Fsearch_forward, Fsearch_backward): Document negative
599 repeat counts (Bug#10507).
600
48da7392
GM
6012012-01-26 Glenn Morris <rgm@gnu.org>
602
603 * lread.c (syms_of_lread): Doc fix.
604
14af5f7f
CY
6052012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
606
607 * coding.c (encode_designation_at_bol): Change return value to
608 EMACS_INT.
609
0b21c100
CY
6102012-01-25 Chong Yidong <cyd@gnu.org>
611
612 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
613
3c2907f7
CY
6142012-01-21 Chong Yidong <cyd@gnu.org>
615
616 * floatfns.c (Fcopysign): Make the second argument non-optional,
617 since nil is not allowed anyway.
618
959ad23f
AS
6192012-01-21 Andreas Schwab <schwab@linux-m68k.org>
620
621 * process.c (read_process_output): Use p instead of XPROCESS (proc).
622 (send_process): Likewise.
623
34a02f46
MR
6242012-01-19 Martin Rudalics <rudalics@gmx.at>
625
626 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
627 (Vwindow_persistent_parameters): Do not use Qstate.
628 Rewrite doc-strings.
34a02f46 629
1259009a 6302012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
631
632 * character.c (char_width): New function.
70d4fdf6
GM
633 (Fchar_width, c_string_width, lisp_string_width):
634 Use char_width (Bug#9496).
25ed9e61 635
6a6ee00d
MR
6362012-01-16 Martin Rudalics <rudalics@gmx.at>
637
638 * window.c (Vwindow_persistent_parameters): New variable.
639 (Fset_window_configuration, save_window_save): Handle persistent
640 window parameters.
641
c85efaf7
EZ
6422012-01-14 Eli Zaretskii <eliz@gnu.org>
643
644 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
645 thrashing the stack of the thread. (Bug#9087)
646
5944709e
PE
6472012-01-12 Paul Eggert <eggert@cs.ucla.edu>
648
649 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
650
e71f5d99
EZ
6512012-01-11 Eli Zaretskii <eliz@gnu.org>
652
653 * xdisp.c (rows_from_pos_range): Handle the case where the
654 highlight ends on a newline. (Bug#10464)
655 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
656 he end column for display of highlight that ends on a newline
657 before a R2L line.
658
ce316182
GM
6592012-01-11 Glenn Morris <rgm@gnu.org>
660
661 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
662 from load-path also when installation-directory is nil. (Bug#10208)
663
5b43da69
GM
6642012-01-10 Glenn Morris <rgm@gnu.org>
665
74cc8ff9
GM
666 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
667
7d8d6e4e
GM
668 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
669 Update template values to be closer to their typical values these days.
5b43da69 670
a0db8d43
EZ
6712012-01-09 Eli Zaretskii <eliz@gnu.org>
672
673 * xdisp.c (rows_from_pos_range): Accept additional argument
674 DISP_STRING, and accept any glyph in a row whose object is that
675 string as eligible for mouse highlight. Fixes mouse highlight of
676 display strings from overlays. (Bug#10464)
677
9a0115ab 6782012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 679
b9110d6a 680 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
681 * fileio.c (auto_saving_dir_umask): New static var.
682 (Fmake_directory_internal): Use it.
683 (do_auto_save_make_dir): Set it, instead of invoking chmod after
684 creating the directory. The old code temporarily assigns
685 too-generous permissions to the directory.
686 (do_auto_save_eh): Clear it.
b9110d6a 687 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
688 that the var is always cleared.
689
6c1bd3f3
EZ
6902012-01-07 Eli Zaretskii <eliz@gnu.org>
691
692 * search.c (scan_buffer): Pass character positions to
693 know_region_cache, not byte positions. (Bug#6540)
694
069d2b50
L
6952012-01-07 LynX <_LynX@bk.ru> (tiny change)
696
697 * w32.c (sys_rename): Report EXDEV when rename of a directory
698 fails because the target is on another logical disk. (Bug#10284)
699
75bf0d33
DB
7002012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
701
702 * xterm.c (x_embed_request_focus): New function.
703
704 * xterm.h: Add prototype.
705
706 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
707
1c6e5a32
GM
7082012-01-05 Glenn Morris <rgm@gnu.org>
709
710 * emacs.c (emacs_copyright): Update short copyright year to 2012.
711
651e947e
EZ
7122012-01-01 Eli Zaretskii <eliz@gnu.org>
713
714 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
715 Load gnutls_transport_set_lowat only if GnuTLS version is below
716 2.11.1.
717 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
718 GnuTLS versions below 2.11.1.
719
3778cdd8
AL
7202011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
721
722 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
723 to the doc string advising against its use for altering the way
724 windows are scrolled.
725
0e5317f7
KH
7262011-12-28 Kenichi Handa <handa@m17n.org>
727
728 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
729 coding-system ASCII compatible only when it does not produce BOM
730 on encoding (Bug#10383).
731
93d5ca1f
JD
7322011-12-26 Jan Djärv <jan.h.d@swipnet.se>
733
734 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
735 can scroll.
736 (create_and_show_popup_menu): Always use menu_position_func for
737 Gtk3 (Bug#10361).
738
ca22b785
AS
7392011-12-24 Andreas Schwab <schwab@linux-m68k.org>
740
741 * callint.c (Fcall_interactively): Don't truncate prompt string.
742
d048e1e6
EZ
7432011-12-23 Eli Zaretskii <eliz@gnu.org>
744
745 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
746 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 747 resumed from there (after widening). (Bug#10360)
d048e1e6 748
5ccaba1f
JD
7492011-12-22 Jan Djärv <jan.h.d@swipnet.se>
750
751 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
752
204ee57f
JD
7532011-12-21 Jan Djärv <jan.h.d@swipnet.se>
754
b81d40f0
JB
755 * nsterm.m (x_free_frame_resources):
756 Release f->output_data.ns->miniimage.
204ee57f
JD
757 (ns_index_color): Fix indentation. Do not retain
758 color_table->colors[i].
759
760 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
761 before returning.
762
763 * nsfns.m (x_set_background_color): Assign return value from
764 ns_index_color to face-background instead of NSColor*.
765 (ns_implicitly_set_icon_type): Fix indentation.
766 Change assignment in for loop to comparison.
767
768 * emacs.c (ns_pool): New variable.
769 (main): Assign ns_pool.
770 (Fkill_emacs): Call ns_release_autorelease_pool.
771
772 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
773 autorelease fdesc, release fdAttrs and tdict.
774 (ns_get_covering_families): Release charset.
775 (ns_findfonts): Release NSFontDescriptor created with new.
776 (ns_uni_to_glyphs): Fix indentation.
777 (setString): Release attrStr before assigning new value.
778
c803b2b7
JD
7792011-12-18 Jan Djärv <jan.h.d@swipnet.se>
780
678f4426
JD
781 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
782 and NS_IMPL_COCOA.
783 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
784 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
785
cd394be1 7862011-12-18 David Reitter <reitter@cmu.edu>
678f4426 787
5fecd5fc
JD
788 * nsterm.m (ns_term_init): Subscribe for notifications
789 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
790 to method trackingNotification in EmacsMenu.
791
792 * nsmenu.m (trackingMenu): New variable.
3771cb17 793 (trackingNotification): New method (from Aquamacs).
5fecd5fc 794 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 795 from Aquamacs (Bug#7030).
678f4426
JD
796
7972011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 798
c803b2b7
JD
799 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
800 (symbol_to_nsstring): Fix indentation.
801 (ns_symbol_to_pb): New function.
cae07000
SM
802 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
803 (Fns_rotate_cut_buffers_internal): Remove.
804 (Fns_store_selection_internal): Rename from
c803b2b7
JD
805 Fns_store_cut_buffer_internal.
806 (ns_get_foreign_selection, Fx_own_selection_internal)
807 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
808 (Fns_get_selection_internal, Fns_store_selection_internal):
809 Use ns_symbol_to_pb and check if return value is nil.
810 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
811 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
812 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
813 renamed to Sns_store_selection_internal.
814 (ns_handle_selection_request): Move code to Fx_own_selection_internal
815 and remove this function.
816 (ns_handle_selection_clear): Remove, never used.
817 (Fx_own_selection_internal): Move code from ns_handle_selection_request
818 here.
819
e1b01a3a
KB
8202011-12-17 Ken Brown <kbrown@cornell.edu>
821
822 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
823 GID is unknown (Bug#10257).
824
2adb6e85
PE
8252011-12-17 Paul Eggert <eggert@cs.ucla.edu>
826
827 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
828 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
829 which caused a build failure on GNU/Linux IA-64. This problem was
830 introduced by my 2011-10-07 patch.
831
d1d7b339
JL
8322011-12-15 Juri Linkov <juri@jurta.org>
833
834 * image.c (imagemagick_error): New function. (Bug#10112)
835 (imagemagick_load_image): Comment out `MagickSetResolution' call.
836 Use `imagemagick_error' where ImageMagick functions return
837 `MagickFalse'.
838 (Fimagemagick_types): Add `Fnreverse' to return the list in the
839 proper order.
840
100d5755
KH
8412011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
842
843 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
844 fill background (Bug#8992).
845
454592a6
MR
8462011-12-13 Martin Rudalics <rudalics@gmx.at>
847
848 * window.c (Vwindow_combination_resize)
849 (Vwindow_combination_limit): Use t instead of non-nil in
850 doc-strings.
61d4b438
MR
851 (Vrecenter_redisplay): Add first sentence of doc-string on
852 separate line.
53524d93 853 (Frecenter): Fix doc-string typo.
454592a6 854
3633e3aa
KH
8552011-12-11 Kenichi Handa <handa@m17n.org>
856
857 * coding.c (Funencodable_char_position): Pay attention to the
858 buffer text relocation (Bug#9389).
859
7b9d523a
JD
8602011-12-10 Jan Djärv <jan.h.d@swipnet.se>
861
862 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
863 gtk_init (Bug#10100).
864
b73189c6
EZ
8652011-12-10 Eli Zaretskii <eliz@gnu.org>
866
867 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
868 IT->string is nil. (Bug#10263)
869
f7dfe5d6
JD
8702011-12-10 Jan Djärv <jan.h.d@swipnet.se>
871
83faebb4
JD
872 * nsterm.h (x_free_frame_resources): Declare.
873
f7dfe5d6
JD
874 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
875 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
876
877 * nsterm.h (ns_get_defaults_value): Declare.
878
879 * nsterm.m (ns_default): Call ns_get_defaults_value.
880
7cd4e72c
EZ
8812011-12-09 Eli Zaretskii <eliz@gnu.org>
882
883 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
884 (Bug#10170)
885
b34d7317
YM
8862011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
887
888 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
889 that where the value of an _OBJC_* symbol points to is in the .bss
890 section (Bug#10240).
891
76470ad1
KH
8922011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
893
894 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 895 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 896
745fff94
KH
8972011-12-08 Kenichi Handa <handa@m17n.org>
898
899 * ftfont.c (get_adstyle_property): Fix previous change
900 (Bug#10233).
901
6e44397c
JB
9022011-12-07 Juanma Barranquero <lekktu@gmail.com>
903
904 * w32.c (init_environment): If no_site_lisp, remove site-lisp
905 dirs from the default value of EMACSLOADPATH (bug#10208).
906
7efa6272
GM
9072011-12-07 Glenn Morris <rgm@gnu.org>
908
909 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
910 installation and source directories as well. (Bug#10208)
911
f6fc4d87
CY
9122011-12-06 Chong Yidong <cyd@gnu.org>
913
914 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
915
2bf26180
GM
9162011-12-06 Glenn Morris <rgm@gnu.org>
917
918 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
919 as an error, not just -1. (Bug#10217)
920
3a6ad4f0
CY
9212011-12-05 Chong Yidong <cyd@gnu.org>
922
923 * keyboard.c (process_special_events): New function.
924 (swallow_events, Finput_pending_p): Use it (Bug#10195).
925
75a3b399
PE
9262011-12-05 Paul Eggert <eggert@cs.ucla.edu>
927
928 * coding.c (encode_designation_at_bol): Don't use uninitialized
929 local variable (Bug#9318).
930
c3c9e25e
KH
9312011-12-05 Kenichi Handa <handa@m17n.org>
932
933 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
934 return Qnil (Bug#8046, Bug#10193).
935
5eb05ea3
KH
9362011-12-05 Kenichi Handa <handa@m17n.org>
937
938 * coding.c (encode_designation_at_bol): New args charbuf_end and
939 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
940 (coding_set_source): Return how many bytes coding->source was
941 relocated.
942 (coding_set_destination): Return how many bytes
943 coding->destination was relocated.
944 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 945 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
946
9472011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
948
949 * coding.c (CODING_CHAR_CHARSET_P): New macro.
950 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
951 macro (Bug#9318).
952
9532011-12-05 Andreas Schwab <schwab@linux-m68k.org>
954
955 The following changes are to fix Bug#9318.
956
a79703f5 957 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
958 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
959 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 960 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 961
7dbda6df
JB
9622011-12-05 Juanma Barranquero <lekktu@gmail.com>
963
964 * lisp.h (process_quit_flag): Fix external declaration.
965
6d5eb5b0
SM
9662011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
967
968 Don't macro-inline non-performance-critical code.
969 * eval.c (process_quit_flag): New function.
970 * lisp.h (QUIT): Use it.
971
a0c3fad0
JD
9722011-12-04 Jan Djärv <jan.h.d@swipnet.se>
973
974 * nsfns.m (get_geometry_from_preferences): New function.
975 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
976
6c07aac2
AS
9772011-12-04 Andreas Schwab <schwab@linux-m68k.org>
978
979 * emacs.c (Qkill_emacs): Define.
980 (syms_of_emacs): Initialize it.
981 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
982 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
983 (quit_throw_to_read_char): Add parameter `from_signal'.
984 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
985 * lisp.h (QUIT): Call Fkill_emacs if requested.
986
c052ead4
JD
9872011-12-03 Jan Djärv <jan.h.d@swipnet.se>
988
989 * widget.c (update_wm_hints): Return if wmshell is null.
990 (widget_update_wm_size_hints): New function.
991
992 * widget.h (widget_update_wm_size_hints): Declare.
993
994 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
995 widget_update_wm_size_hints (Bug#10104).
996
9e49252b
EZ
9972011-12-03 Eli Zaretskii <eliz@gnu.org>
998
999 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1000 before a newline, prepare the bidi iterator for consuming the
1001 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 1002 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 1003
02b16839
JL
10042011-12-02 Juri Linkov <juri@jurta.org>
1005
1006 * search.c (Fword_search_regexp): New Lisp function created from
1007 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1008 (Fword_search_backward, Fword_search_forward)
1009 (Fword_search_backward_lax, Fword_search_forward_lax):
1010 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1011 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1012
0068070e
SM
10132011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1014
1015 * fileio.c (Finsert_file_contents): Move after-change-function call
1016 to before the "handled:" label, since all "goto handled" appear in
1017 cases where the *-change-functions have already been properly called
1018 (bug#10117).
1019
3360a3fc
AS
10202011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1021
1022 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1023 waiting for input. (Bug#10169)
1024
73d6c093
EZ
10252011-11-30 Eli Zaretskii <eliz@gnu.org>
1026
1027 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1028 verifies glyph row's hash code--we have just reallocated the
1029 glyphs, so their contents can be complete garbage. (Bug#10164)
1030
febe6bea
JB
10312011-11-30 Juanma Barranquero <lekktu@gmail.com>
1032
1033 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1034
801a4313
EZ
10352011-11-30 Eli Zaretskii <eliz@gnu.org>
1036
1037 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1038 attributes are tested _before_ calling verify_row_hash, to protect
1039 against GCC re-ordering of the tests. (Bug#10164)
1040
2b56b87e
JD
10412011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1042
1043 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1044
1045 * xterm.c (handle_one_xevent): Only set async_visible and friends
1046 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1047 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1048 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1049
dbf31225
PE
10502011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1051
1052 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1053 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1054 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1055 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1056 All uses changed to use GCPRO1 etc.
1057 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1058 Revert to old implementation (i.e., before 2011-03-11).
1059
1305621b
YM
10602011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1061
1062 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1063 of scroll runs so as to avoid assigning disabled bogus rows and
1064 unnecessary graphics copy operations.
1065
8c9afb46
EZ
10662011-11-27 Eli Zaretskii <eliz@gnu.org>
1067
1068 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1069 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1070 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1071 (malloc, free, realloc, calloc): Redirect to e_* only when
1072 compiling Emacs.
1073
1074 * lisp.h (GCTYPEBITS): Move before first use.
1075 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1076 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1077 this macro definition.
1078
1079 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1080 _MSC_VER.
1081
54e9e3bf
JD
10822011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1083
6d5eb5b0
SM
1084 * gtkutil.c (xg_create_frame_widgets):
1085 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1086 present with Gtk+ 2.0.
1087
83aca1cb
PE
10882011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1089
1090 * fileio.c (Finsert_file_contents): Undo previous change; see
1091 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1092
5b76caa4
PE
10932011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1094
1095 Rename locals to avoid shadowing.
1096 * fileio.c (Finsert_file_contents):
1097 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1098 * process.c (wait_reading_process_output):
1099 Rename inner 'proc' to 'p' to avoid shadowing.
1100 Indent for consistency with usual Emacs style.
1101
8c535114
EZ
11022011-11-25 Eli Zaretskii <eliz@gnu.org>
1103
1104 * xdisp.c (redisplay_window): If cursor row is not fully visible
1105 after recentering, and scroll-conservatively is set to a large
1106 number, scroll window by a few more lines to make the cursor fully
1107 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1108 (start_display): Don't move to the next line if the display should
1109 start at a newline that is part of a display vector or an overlay
1110 string. (Bug#10119)
8c535114 1111
fa4fdb5c
JL
11122011-11-24 Juri Linkov <juri@jurta.org>
1113
1114 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1115 after the `MagickPingImage' call. (Bug#10112)
1116
90ec88df
CY
11172011-11-23 Chong Yidong <cyd@gnu.org>
1118
1119 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1120
56e2e794
MR
11212011-11-23 Martin Rudalics <rudalics@gmx.at>
1122
1123 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1124 making another buffer current. (Bug#10114)
1125
b6e64c41
GM
11262011-11-23 Glenn Morris <rgm@gnu.org>
1127
1128 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1129
6b21de18
CY
11302011-11-23 Chong Yidong <cyd@gnu.org>
1131
1132 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1133 using it (Bug#5984).
1134
b12cd789
EZ
11352011-11-22 Eli Zaretskii <eliz@gnu.org>
1136
1137 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1138 and header-lines, as they don't have one computed for them.
1139 (Bug#10098)
1140
1141 * .gdbinit (prow): Make displayed values more self-explaining.
1142 Add row's hash code.
1143
261b6fd4
LMI
11442011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1145
1146 * process.c (wait_reading_process_output): Fix asynchrounous
1147 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1148 (wait_reading_process_output): Add comment and URL.
261b6fd4 1149
e7cfd277
JD
11502011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1151
1152 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1153
a9b9b7f5
CY
11542011-11-21 Chong Yidong <cyd@gnu.org>
1155
1156 * window.c (Fnext_window, Fprevious_window): Doc fix.
1157
b0d15b4f
SM
11582011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1159
1160 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1161
fe7a3057
JB
11622011-11-20 Juanma Barranquero <lekktu@gmail.com>
1163
1164 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1165
d2999b1a
MR
11662011-11-20 Martin Rudalics <rudalics@gmx.at>
1167
1168 * window.c (Fset_window_combination_limit): Rename argument
1169 STATUS to LIMIT.
1170 (Vwindow_combination_limit): Remove "status" from doc-string.
1171
d5ff9cd0
AS
11722011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1173
1174 * m/ibms390.h: Remove.
1175 * m/ibms390x.h: Don't include "ibms390.h".
1176
a5bb9bd3
SM
11772011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1178
1179 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1180 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1181
cd1181db
JB
11822011-11-20 Juanma Barranquero <lekktu@gmail.com>
1183
1184 * casetab.c (Fset_case_table):
1185 * charset.c (Fcharset_after): Fix typos.
1186
615a3b8d 11872011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1188
17e845af
PE
1189 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1190 Otherwise, valgrind does not work on some platforms.
1191 Problem reported by Andreas Schwab in
6a0bf43d
PE
1192 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1193 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1194 is set, removing the need for VIRT_ADDRESS_VARIES.
1195 (PURE_P): Use a more-efficient implementation that needs just one
1196 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1197 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1198 to 4 (xorl, subq, cmpq, setbe).
1199 * alloc.c (pure): Always extern now, since that's the
1200 VIRT_ADDR_VARIES behavior.
1201 (PURE_POINTER_P): Use a single comparison, not two, for
1202 consistency with the new puresize.h.
1203 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1204 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1205 Remove VIRT_ADDR_VARIES no longer needed.
1206
f8fe6f96
EZ
12072011-11-19 Eli Zaretskii <eliz@gnu.org>
1208
1209 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1210 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1211 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1212 behave as if the cursor position were at the window margin.
1213
1214 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1215 and the cursor position is out of bounds, behave as if the cursor
1216 position were at the window margin. (Bug#10075)
1217
df05a53c
CY
12182011-11-18 Chong Yidong <cyd@gnu.org>
1219
1220 * window.c (Fwindow_combination_limit): Make first argument
1221 non-optional, since it is meaningless for live windows like the
1222 selected window.
1223
2071918e
DA
12242011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1225
1226 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1227
b50a28de
SM
12282011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1229
1230 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1231 (graft_intervals_into_buffer): Simplify.
1232
015137db
EZ
12332011-11-18 Eli Zaretskii <eliz@gnu.org>
1234
1235 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1236 hash values of the two rows.
1237 (copy_row_except_pointers): Preserve the used[] arrays and the
1238 hash values of the two rows. (Bug#10035)
68c95424 1239 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1240
1241 * xdisp.c (row_hash): New function, body extracted from
1242 compute_line_metrics.
1243 (compute_line_metrics): Call row_hash, instead of computing the
1244 hash code inline.
1245
1246 * dispnew.c (verify_row_hash): Call row_hash for computing the
1247 hash code of a row, instead of duplicating code from xdisp.c.
1248
1249 * dispextern.h (row_hash): Add prototype.
1250
a2addb04
TH
12512011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1252
1253 * frame.c (delete_frame): Don't delete the terminal when the last
1254 X frame is closed if emacs is built with GTK toolkit.
1255
df85d315
JB
12562011-11-17 Juanma Barranquero <lekktu@gmail.com>
1257
1258 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1259
a0c2d0ae
MR
12602011-11-17 Martin Rudalics <rudalics@gmx.at>
1261
1262 * window.c (Vwindow_splits): Rename to
1263 Vwindow_combination_resize. Suggested by Juri Linkov.
1264 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1265 of Vwindow_splits.
1266
58179cce
JB
12672011-11-16 Juanma Barranquero <lekktu@gmail.com>
1268
7877f373
JB
1269 * nsfns.m (Fns_font_name):
1270 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1271
b6f67890
MR
12722011-11-16 Martin Rudalics <rudalics@gmx.at>
1273
1274 * window.h (window): Rename slot "nest" to "combination_limit".
1275 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1276 (Fset_window_nest): Rename to Fset_window_combination_limit.
1277 (Vwindow_nest): Rename to Vwindow_combination_limit.
1278 (recombine_windows, make_parent_window, make_window)
1279 (Fsplit_window_internal, saved_window)
1280 (Fset_window_configuration, save_window_save): Rename all
1281 occurrences of window_nest to window_combination_limit.
1282
c7015153
JB
12832011-11-15 Juanma Barranquero <lekktu@gmail.com>
1284
1285 * image.c (imagemagick_load_image): Fix typo.
1286
322ad6ec
EZ
12872011-11-14 Eli Zaretskii <eliz@gnu.org>
1288
1289 * xdisp.c (display_line): Move the call to
1290 highlight_trailing_whitespace before the call to
1291 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1292 faces of all the glyphs to compute ROW's hash value.
1293 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1294
f067b8ec
JB
12952011-11-14 Juanma Barranquero <lekktu@gmail.com>
1296
1297 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1298 just return (bug#10044).
1299
1e5b2111
EZ
13002011-11-12 Eli Zaretskii <eliz@gnu.org>
1301
7ef3cbd5
EZ
1302 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1303 with user-defined heap size. Bump the default size of the temacs
1304 heap to 27MB, to avoid memory warning when running temacs.
1305 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1306
1e5b2111
EZ
1307 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1308 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1309 (verify_row_hash) [XASSERTS]: New function.
1310 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1311 that the hash value of glyph rows is correct.
1e5b2111 1312
89d61221
MR
13132011-11-12 Martin Rudalics <rudalics@gmx.at>
1314
1315 * window.h (window): Remove splits slot.
1316 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1317 (Fdelete_other_windows_internal, make_parent_window)
1318 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1319 (Fset_window_configuration, save_window_save): Don't deal with
1320 split status of windows.
1321 (saved_window): Remove splits slot.
1322 (Vwindow_splits): Rewrite doc-string.
1323
97f18cc8
JD
13242011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1325
1326 * xfns.c (unwind_create_frame):
1327 * nsfns.m (unwind_create_frame):
1328 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1329 Vframe_list (Bug#9999).
1330
22a648b4
DA
13312011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1332
0b381c7e 1333 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1334
659afede
KH
13352011-11-11 Kenichi Handa <handa@m17n.org>
1336
1337 * callproc.c (Fcall_process): Set the member dst_multibyte of
1338 process_coding.
1339
9ac0394b
KH
13402011-11-11 Johan Bockgård <bojohan@gnu.org>
1341
1342 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1343 avoid a crash (bug#9496).
1344
2fbdc249
CY
13452011-11-09 Chong Yidong <cyd@gnu.org>
1346
1347 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1348 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1349
ac6b1f81
PE
13502011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1351
1352 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1353
09db192c
PE
13542011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1355
1356 Avoid some portability problems by eschewing 'extern inline' functions.
1357 The trivial performance wins aren't worth the portability hassles; see
1358 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1359 et seq.
1360 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1361 (window_box_width, window_box_left, window_box_left_offset)
1362 (window_box_right, window_box_right_offset): Undo previous change,
1363 by removing the "extern"s.
1364 * intervals.c (adjust_intervals_for_insertion)
1365 (adjust_intervals_for_deletion): Undo previous change,
1366 making these static again.
1367 (offset_intervals, temp_set_point_both, temp_set_point)
1368 (copy_intervals_to_string): No longer inline.
1369 * xdisp.c (window_text_bottom_y, window_box_width)
1370 (window_box_height, window_box_left_offset)
1371 (window_box_right_offset, window_box_left, window_box_right)
1372 (window_box): No longer inline.
1373
105216ed
CY
13742011-11-08 Chong Yidong <cyd@gnu.org>
1375
1376 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1377 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1378 Signal an error if not a live window.
105216ed
CY
1379 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1380 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1381
ae9e237f
JB
13822011-11-07 Juanma Barranquero <lekktu@gmail.com>
1383
1384 * lisp.h (syms_of_abbrev): Remove declaration.
1385 Reported by CHENG Gao <chenggao@royau.me>.
1386
c7aa8333
EZ
13872011-11-07 Eli Zaretskii <eliz@gnu.org>
1388
1389 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1390 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1391 of temacs in GUI mode.
1392
be7f5545
MR
13932011-11-07 Martin Rudalics <rudalics@gmx.at>
1394
1395 * window.h: Declare delete_all_child_windows instead of
1396 delete_all_subwindows.
1397 * window.c (Fwindow_nest, Fset_window_nest)
1398 (Fset_window_new_total, Fset_window_new_normal)
1399 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1400 (delete_all_subwindows): Rename to delete_all_child_windows.
1401 (Fdelete_other_windows_internal, Fset_window_configuration):
1402 Call delete_all_child_windows instead of delete_all_subwindows.
1403 * frame.c (delete_frame): Call delete_all_child_windows instead
1404 of delete_all_subwindows.
1405
ca78dc43
PE
14062011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1407
1408 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1409 This is also needed for porting to any host where GC_MARK_STACK is
1410 not GC_MAKE_GCPROS_NOOPS.
1411 (which_symbols): Use it.
1412
a0241d01
KH
14132011-11-07 Kenichi Handa <handa@m17n.org>
1414
1415 * coding.c (coding_set_destination): Check coding->src_pos only
1416 when coding->src_object is a buffer (bug#9910).
1417
1418 * process.c (send_process): Set the member src_multibyte of coding
1419 to 0 (bug#9911) when sending a unibyte text.
1420
1421 * callproc.c (Fcall_process): Set the member src_multibyte of
1422 process_coding to 0 (bug#9912).
1423
a64bfdfa 14242011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1425
1426 * xmenu.c (cleanup_widget_value_tree): New function.
1427 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1428 calling free_menubar_widget_value_tree directly (Bug#9830).
1429
cb41b32a
PE
14302011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1431
1432 Fix some portability problems with 'inline'.
1433 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1434 (window_box_width, window_box_left, window_box_left_offset)
1435 (window_box_right, window_box_right_offset): Declare extern.
1436 Otherwise, these inline functions do not conform to C99 and
1437 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1438 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1439 * intervals.c (adjust_intervals_for_insertion)
1440 (adjust_intervals_for_deletion): Now extern, because otherwise the
1441 extern inline functions 'offset_intervals' couldn't refer to it.
1442 (static_offset_intervals): Remove.
1443 (offset_intervals): Rewrite using the old contents of
1444 static_offset_intervals. The old version didn't conform to C99
1445 because an extern inline function contained a reference to an
1446 identifier with static linkage.
1447
b7041366
AS
14482011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1449
1450 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1451 GC.
1452
88a37c4d
EZ
14532011-11-06 Eli Zaretskii <eliz@gnu.org>
1454
1455 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1456 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1457 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1458 return Qleft_to_right.
1459
49745b39
CY
14602011-11-06 Chong Yidong <cyd@gnu.org>
1461
1462 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1463 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1464 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1465 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1466 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1467 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1468 (Fwindow_vscroll): Doc fix.
1469 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1470 argument, since it makes no sense to pass a live window and for
1471 consistency with window-child.
1472
1f05cd82
CS
14732011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1474
1475 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1476 support MSVC.
1477
22610910
JR
14782011-11-05 Jason Rumney <jasonr@gnu.org>
1479
1480 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1481 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1482 fonts (Bug#6029).
1483 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1484 bitwise arithmetic preventing use of unicode-sip and non-truetype
1485 opentype fonts.
1486
a06776b2
EZ
14872011-11-05 Eli Zaretskii <eliz@gnu.org>
1488
3ad924ba
EZ
1489 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1490 "emacs"-only part.
1491
a06776b2
EZ
1492 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1493 initialization code to keep similarity to xfns.c after changes
1494 from 2011-11-05.
1495
c9e7db78
JD
14962011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1497
a97f8f3f
JD
1498 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1499 (unwind_create_frame): New function (Bug#9943).
1500 (Fx_create_frame): Restructure code to be more similar to the one in
1501 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1502 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1503 Move terminal->reference_count++ just before making the frame official
1504 (Bug#9943).
1505
1506 * nsterm.m (x_free_frame_resources): New function.
1507 (x_destroy_window): Move code to x_free_frame_resources.
1508
c9e7db78 1509 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1510 (Fx_create_frame, x_create_tip_frame):
1511 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1512 official. Move initialization of image_cache_refcount and
1513 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1514
a6fc3b5c
EZ
15152011-11-05 Eli Zaretskii <eliz@gnu.org>
1516
1517 Support MSVC build with newer versions of Visual Studio.
1518 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1519 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1520 nt/gmake.defs.
1521
1522 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1523 which are not supported by MSVC.
1524 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1525 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1526 bitfields.
1527 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1528 types in bitfields.
1529 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1530
1531 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1532
58179cce 15332011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1534
1535 Support MSVC build with newer versions of Visual Studio.
1536 * w32.c: Don't include w32api.h for MSVC.
1537 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1538
1539 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1540 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1541 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1542 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1543 e_* cousins.
1544 (alloca) [_MSC_VER]: Define to _alloca.
1545
1546 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1547
1548 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1549
a58c13ed
EZ
15502011-11-04 Eli Zaretskii <eliz@gnu.org>
1551
1552 * xdisp.c (note_mouse_highlight): If either of
1553 previous/next-single-property-change returns nil, treat that as
1554 the beginning or the end of the buffer. (Bug#9955)
1555
fe0b6370
JD
15562011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1557
a58c13ed 1558 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1559 label is not null (Bug#9951).
1560 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1561 may be NULL.
1562
89bd5ee1
EZ
15632011-11-04 Eli Zaretskii <eliz@gnu.org>
1564
1565 * window.c (Fwindow_body_size): Mention in the doc string that the
1566 return value is in frame's canonical units. (Bug#9949)
1567
84c3edb9
EZ
15682011-11-03 Eli Zaretskii <eliz@gnu.org>
1569
4e2fb5c7
EZ
1570 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1571
84c3edb9 1572 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1573 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1574 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1575
bc17a887
EZ
15762011-11-01 Eli Zaretskii <eliz@gnu.org>
1577
1578 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1579 Don't stop backward scan on the continuation glyph, even though
1580 its CHARPOS is positive.
6d5eb5b0
SM
1581 (mouse_face_from_buffer_pos, note_mouse_highlight):
1582 Rename cover_string to disp_string.
bc17a887 1583
4ee88440
MR
15842011-11-01 Martin Rudalics <rudalics@gmx.at>
1585
1586 * window.c (temp_output_buffer_show): Don't use
1587 Vtemp_buffer_show_specifiers.
1588 (Vtemp_buffer_show_specifiers): Remove unused variable.
1589
c2ff3c02
EZ
15902011-10-30 Eli Zaretskii <eliz@gnu.org>
1591
1592 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1593 past the beginning of the current glyph matrix.
1594
58179cce 15952011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1596
1597 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1598 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1599 HAVE_GTK3 (Bug#9869).
b77a6a7f 1600
3b574623
JD
1601 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1602 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1603
b77a6a7f
JD
1604 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1605
1606 * xterm.c: Declare x_handle_net_wm_state to return int.
1607 (handle_one_xevent): Check if we are iconified but don't have
1608 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1609 (get_current_wm_state): Return non-zero if not hidden,
1610 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1611 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1612 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1613 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1614
196e41e4
PE
16152011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1616
1617 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1618 so that this new function doesn't get optimized away by a
1619 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1620
021f2e1a
AS
16212011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1622
1623 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1624
8b058d44
EZ
16252011-10-29 Eli Zaretskii <eliz@gnu.org>
1626
1627 Fix the `xbytecode' command.
1628 * .gdbinit (xprintbytestr): New command.
b50a28de 1629 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1630 (xbytecode): Print the byte-code string as well.
1631
4452fb80
EZ
16322011-10-29 Kim Storm <storm@cua.dk>
1633
8b058d44
EZ
1634 * alloc.c (which_symbols): New function.
1635
21b72067
AS
16362011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1637
1638 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1639 line. (Bug#9903)
1640
83ed7b5c
GM
16412011-10-29 Glenn Morris <rgm@gnu.org>
1642
1643 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1644 Not clear what it was for, and it causes various bugs. (Bug#9839)
1645
5a7a728b
EZ
16462011-10-28 Eli Zaretskii <eliz@gnu.org>
1647
1648 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1649 possible random value that matches one of those tested as
1650 condition to clear the mouse face.
1651
d3d0842f
CY
16522011-10-28 Chong Yidong <cyd@gnu.org>
1653
1654 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1655
31b39d13
DN
16562011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1657
1658 * window.c (make_window): Initialize phys_cursor_on_p.
1659
9aba6043
SM
16602011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1661
1662 * lisp.h (struct Lisp_Symbol): Update comments.
1663
c20992f4
JB
16642011-10-28 Juanma Barranquero <lekktu@gmail.com>
1665
1666 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1667
db4f02f2
EZ
16682011-10-28 Eli Zaretskii <eliz@gnu.org>
1669
1670 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1671 <oslsachem@gmail.com> for helping to debug this.
1672
1673 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1674 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1675 (g_b_init_get_glyph_outline_w): New static variables.
1676 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1677 (GetGlyphOutlineW_Proc): New typedefs.
1678 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1679 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1680 New functions.
1681 (w32font_open_internal, compute_metrics):
1682 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1683 instead of calling the "wide" APIs directly.
1684
1685 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1686
1687 * w32.h (syms_of_w32font): Add prototype.
1688
87e68db4
JB
16892011-10-27 Juanma Barranquero <lekktu@gmail.com>
1690
1691 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1692 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1693 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1694 (Fmove_to_window_line): Doc fix.
1695
435c1d67
CY
16962011-10-27 Chong Yidong <cyd@gnu.org>
1697
1698 * process.c (make_process): Set gnutls_state to NULL.
1699
1700 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1701 non-NULL, regardless of GNUTLS_INITSTAGE.
1702 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1703 an error. Set process slots as soon as we allocate them.
1704
1705 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1706
9c6c6f49
CY
17072011-10-27 Chong Yidong <cyd@gnu.org>
1708
9aba6043
SM
1709 * gnutls.c (emacs_gnutls_deinit): New function.
1710 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1711 (Fgnutls_deinit, Fgnutls_boot): Use it.
1712
1713 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1714 (deactivate_process): Call emacs_gnutls_deinit.
1715
657d08d3
JB
17162011-10-27 Juanma Barranquero <lekktu@gmail.com>
1717
1718 * image.c (x_create_x_image_and_pixmap):
1719 * w32.c (sys_rename, w32_delayed_load):
1720 * w32font.c (fill_in_logfont):
1721 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1722
5430d399
JB
17232011-10-26 Juanma Barranquero <lekktu@gmail.com>
1724
1725 * w32fns.c (w32_default_color_map): New function,
1726 extracted from Fw32_default_color_map.
a7ef684b 1727 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1728
fe0055fa
PE
17292011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1730
1731 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1732
e6346438
SM
17332011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1734
1735 * keyboard.c (test_undefined): New function (bug#9751).
1736 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1737
e112cc37
ET
17382011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1739
1740 * sysdep.c (init_sys_modes): Fix the check for the controlling
1741 terminal (Bug#6649).
1742
7b5d6677
EZ
17432011-10-20 Eli Zaretskii <eliz@gnu.org>
1744
1745 * dispextern.h (struct bidi_it): New member next_en_type.
1746
1747 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1748 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1749 current character, check also for next_en_type being WEAK_EN.
1750 (bidi_resolve_weak): Don't enter the expensive loop if the current
1751 position is before next_en_pos. Record the bidi type of the first
1752 non-ET, non-BN character we find, in addition to its position.
1753 (bidi_level_of_next_char): Invalidate next_en_type when
1754 next_en_pos is over-stepped.
1755
7da0b018
PE
17562011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1757
1758 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1759 * editfns.c: Rewrite current-time-zone so that it invokes
1760 the equivalent of (format-time-string "%Z") to get the time zone name.
1761 This fixes a bug when the time zone name contains characters that
1762 need converting from the system time locale to Emacs internal format.
1763 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1764 that patch fixed format-time-string to do the conversion, but
1765 I forgot to fix current-time-zone.
1766 (format_time_string): New function, containing most of
1767 what Fformat_time_string used to contain.
1768 (Fformat_time_string): Rewrite in terms of format_time_string.
1769 This doesn't change this function's behavior.
1770 (current-time-zone): Rewrite to use format_time_string.
1771 This fixes the bug reported by Michael Schierl in
1772 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1773 Jason Rumney's 2007-06-07 change worked around this bug, but
1774 didn't fix it.
1775 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1776
8547b010
EZ
17772011-10-19 Eli Zaretskii <eliz@gnu.org>
1778
1779 * xdisp.c (start_display): If the character at POS is displayed
1780 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1781 (try_window_reusing_current_matrix): If a line ends in a display
1782 vector or the next line starts in a display vector, continue
1783 redrawing the window even though the character position of
1784 start_row was reached.
8547b010
EZ
1785 (Bug#9771, part 2)
1786
4e948d15
CY
17872011-10-18 Chong Yidong <cyd@gnu.org>
1788
1789 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1790 with nobreak-char-display too.
1791
4787455f
EZ
17922011-10-18 Eli Zaretskii <eliz@gnu.org>
1793
1794 Fix part 3 of bug#9771.
1795 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1796 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1797 non-neutral characters if the current character is a paragraph
1798 separator (a.k.a. Newline). This avoids running the same
1799 expensive loop twice, once when we consume the preceding newline
1800 and the other time when the line actually needs to be displayed.
1801 Avoid the loop when we see neutrals on the base embedding level
1802 following a character whose directionality is the same as the
1803 paragraph's. This avoids running the expensive loop when a line
1804 ends in a long sequence of neutrals, like control characters.
1805 Add assertion against STRONG_AL type. Slightly rearrange code
1806 that determines the type of a neutral given the first non-neutral
1807 that follows it.
1808 (bidi_level_of_next_char): Set next_en_pos to zero when
1809 invalidating its info.
1810
2c91f553
EZ
18112011-10-17 Eli Zaretskii <eliz@gnu.org>
1812
1813 * xdisp.c (push_display_prop): Determine whether to record string
1814 or buffer position by IT->string, not by IT->method. Allow
1815 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1816 (move_it_vertically_backward): Don't look for character position
1817 immediately after the newline when in a continuation line.
1818 (Bug#9771, part 1)
2c91f553 1819
c7b08b0d
MR
18202011-10-15 Martin Rudalics <rudalics@gmx.at>
1821
1822 * window.c (coordinates_in_window): Rewrite and delabelize
1823 vertical border check. (Bug#5357) (Bug#9618)
1824
6b02f655
SM
18252011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1826
1827 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1828 errors in XSetWindowBorder (bug#9310).
1829
81d40c92
DA
18302011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1831
1832 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1833 avoid crash when xmalloc overrun checking is enabled.
1834
d4172c3b
EZ
18352011-10-13 Eli Zaretskii <eliz@gnu.org>
1836
1837 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1838 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1839 cursor motion with <left> and <right> arrow keys.
1840
1841 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1842 some callers set that themselves.
1843
b00eea75
EZ
18442011-10-12 Eli Zaretskii <eliz@gnu.org>
1845
1846 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1847 display string and the previous row comes from the same string and
1848 is empty. (Bug#9739) (Bug#9738)
1849
8fe012c4
SM
18502011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1851
1852 * doc.c (get_doc_string): Encode file name (bug#9735).
1853
0074aef2
EZ
18542011-10-12 Eli Zaretskii <eliz@gnu.org>
1855
79beb178
EZ
1856 * bidi.c (bidi_level_of_next_char):
1857 * xdisp.c (get_visually_first_element): Remove old incorrect
1858 comments regarding the Unicode Line Separator character.
1859
0074aef2
EZ
1860 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1861
6e4b3fbe
DA
18622011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1863
1864 * alloc.c (Fgc_status): Do not access beyond zombies array
1865 boundary if nzombies > MAX_ZOMBIES.
1866 * alloc.c (dump_zombies): Add missing format specifier.
1867
0324f3af
PE
18682011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1869
b5525cac
PE
1870 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1871 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1872
0324f3af
PE
1873 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1874 Some packages use them to denote characters with modifiers.
1875
e9b5f888
AS
18762011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1877
1878 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1879 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1880 matching a pp-number. Rename parameter var to var1.
1881
127827c0
SM
18822011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1883
1884 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1885
c8fd3bd0
GM
18862011-10-08 Glenn Morris <rgm@gnu.org>
1887
1888 * callint.c (Fcall_interactively): Give a more explicit error for the
1889 'c' case with a non-character input. (Bug#8479)
1890
352ec8ff
EZ
18912011-10-08 Eli Zaretskii <eliz@gnu.org>
1892
03669ccb
EZ
1893 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1894 lines.
7061c986
EZ
1895 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1896 lines that are hscrolled on the left.
03669ccb 1897
352ec8ff
EZ
1898 * dispnew.c (buffer_posn_from_coords): Account for a possible
1899 presence of header-line. (Bug#4426)
1900
a66cfb1c
SM
19012011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1902
6b02f655
SM
1903 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1904 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1905
7c5ee88e
PE
19062011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1907
1908 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1909 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1910 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1911 this makes Emacs dump core during garbage collection on rare
1912 occasions. sizeof is obviously inferior to offsetof here, so
1913 stick with offsetof.
1914 (GC_POINTER_ALIGNMENT): New macro.
1915 (mark_memory): Omit 3rd (offset) arg; caller changed.
1916 Don't assume EMACS_INT alignment is the same as pointer alignment.
1917
df1bbe5b
SM
19182011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1919
1920 * keyboard.c (read_key_sequence_remapped): New var.
1921 (read_key_sequence): Compute remapping in the right buffer.
1922 (command_loop_1): Use read_key_sequence's remapping directly.
1923
51553db6
SM
19242011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1925
32c1fffd
SM
1926 * dired.c (file_name_completion): Don't expand file name.
1927 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1928 before checking file name handler.
1929
51553db6
SM
1930 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1931 they've been requested explicitly (bug#9591).
1932
b6bd1599 19332011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1934
1935 * keymap.c (Fsingle_key_description): Use make_specified_string
1936 instead of build_string to build string from push_key_description.
1937 (Bug#5193)
1938
f701dc2a
PE
19392011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1940
4222c55d
PE
1941 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1942 This fixes a Y2038 bug on 64-bit hosts.
1943 * buffer.c (reset_buffer):
1944 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1945 (Fclear_buffer_auto_save_failure):
1946 Use 0, not -1, to represent an unset failure time, since time_t
1947 might not be signed.
1948
f701dc2a
PE
1949 Remove dependency on glibc malloc internals.
1950 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1951 Move back here from lisp.h, but with their new implementations.
1952 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1953 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1954 * charset.c (charset_table_init): New static var.
1955 (syms_of_charset): Use it instead of xmalloc. This removes a
1956 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1957 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1958 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1959 Move back to alloc.c.
1960 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1961 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1962
9ceebf39
JD
19632011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1964
1965 * nsterm.m (windowDidResize): Call x_set_window_size only when
1966 ns_in_resize is true. Otherwise set pixelwidth/height and
1967 call change_frame_size (Bug#9628).
1968
cb993c58
PE
19692011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1970
3930c88b
PE
1971 Port --enable-checking=all to Fedora 14 x86-64.
1972 * charset.c (syms_of_charset): Also account for glibc malloc's
1973 internal overhead when calculating the initial malloc maximum.
1974
cb993c58
PE
1975 Port --enable-checking=all to Fedora 14 x86.
1976 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1977 Move to lisp.h.
1978 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1979 (overrun_check_realloc, overrun_check_free):
1980 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1981 That way, xmalloc returns a properly-aligned pointer even if
1982 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1983 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1984 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1985 into account when calculating the initial malloc maximum.
1986 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1987 Move here from alloc.c, so that charset.c can use it too.
1988 Properly align; the old code wasn't right for common 32-bit hosts
1989 when configured with --enable-checking=all.
1990 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1991 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1992
31bed486
EZ
19932011-09-29 Eli Zaretskii <eliz@gnu.org>
1994
04c70788 1995 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1996 use EDOM.
1997
fbcaa2f3
EZ
19982011-09-28 Eli Zaretskii <eliz@gnu.org>
1999
2000 * xdisp.c (compute_display_string_end): If there's no display
2001 string at CHARPOS, return -1.
2002
2003 * bidi.c (bidi_fetch_char): When compute_display_string_end
2004 returns a negative value, treat the character as a normal
2005 character not covered by a display string. (Bug#9624)
2006
a239d4e9
JB
20072011-09-28 Juanma Barranquero <lekktu@gmail.com>
2008
2009 * lread.c (Fread_from_string): Fix typo in docstring.
2010
88652fd5
EZ
20112011-09-27 Eli Zaretskii <eliz@gnu.org>
2012
2013 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2014 newline, reseat the iterator instead of bidi-iterating there one
2015 character at a time. (Bug#9610)
32c1fffd
SM
2016 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2017 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 2018
ed497dd4
AS
20192011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2020
2021 * lread.c (readevalloop): Use correct code for NBSP.
2022 (read1): Likewise. (Bug#9608)
2023
b2bf61aa
MA
20242011-09-25 Michael Albinus <michael.albinus@gmx.de>
2025
2026 * dbusbind.c (Fdbus_register_signal): When service is not
2027 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2028
32bbb17c
GM
20292011-09-25 Glenn Morris <rgm@gnu.org>
2030
2031 * buffer.c (truncate-lines): Doc fix.
2032
94e0933e
CY
20332011-09-24 Chong Yidong <cyd@stupidchicken.com>
2034
2035 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2036 (Fset_window_next_buffers): Doc fix.
2037
cddde921
GM
20382011-09-24 Glenn Morris <rgm@gnu.org>
2039
2040 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2041
1260aef1
PE
20422011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2043
25b4bfa0
PE
2044 Fix minor problems found by static checking.
2045 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2046 * indent.c (Fvertical_motion): Fix == vs = typo.
2047
e3cbd34b
EZ
20482011-09-24 Eli Zaretskii <eliz@gnu.org>
2049
a66cfb1c
SM
2050 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2051 Default value is now t. Doc fix.
6bf7006f 2052
e3cbd34b 2053 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2054 logic when moving up, not only when moving down. Fix the
e3cbd34b 2055 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2056 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2057
2058 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2059 CHARPOS is covered by a display string which includes newlines.
2060 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2061 is covered by a display string with embedded newlines.
2062
a3de0cbd
MA
20632011-09-24 Michael Albinus <michael.albinus@gmx.de>
2064
2065 * dbusbind.c (Fdbus_register_signal): Add match rule to
2066 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2067 (Fdbus_register_method, Vdbus_registered_objects_table):
2068 Fix docstring.
a3de0cbd 2069
b260039d
JM
20702011-09-24 Jim Meyering <meyering@redhat.com>
2071
32c1fffd 2072 do not ignore write error for any output size
b260039d
JM
2073 The previous change was incomplete.
2074 While it makes emacs --batch detect the vast majority of stdout
2075 write failures, errors were still ignored whenever the output size is
2076 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2077 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2078 && echo FAIL: ignored write error
2079 FAIL: ignored write error
2080 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2081 && echo FAIL: ignored write error
2082 FAIL: ignored write error
2083 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2084
8eca8a7c
AS
20852011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2086
2087 * emacs.c (Fkill_emacs): In noninteractive mode exit
2088 non-successfully if a write error occurred on stdout. (Bug#9574)
2089
3341db62
EZ
20902011-09-21 Eli Zaretskii <eliz@gnu.org>
2091
2092 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2093 the xassert test.
2094
2095 * dispextern.h (struct it): Update the comment documenting what
2096 can it->OBJECT be.
2097
8c203dbf
EZ
20982011-09-20 Eli Zaretskii <eliz@gnu.org>
2099
2100 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2101 a display string, extend search for cursor position to end of row.
2102 (find_row_edges): If the row ends in a newline from a display
2103 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2104 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2105 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2106 non-empty line. Fixes confusing cursor motion with arrow keys at
2107 the beginning of a line that starts with whitespace.
8c203dbf 2108
a4824228
LMI
21092011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2110
2111 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2112 (bug#9493).
2113
33ed493b
CY
21142011-09-18 Chong Yidong <cyd@stupidchicken.com>
2115
2116 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2117 boolean (Bug#9154).
2118
56cd55c8
EZ
21192011-09-18 Eli Zaretskii <eliz@gnu.org>
2120
2121 * xdisp.c (display_line): Record maximum and minimum buffer
2122 positions even if no glyphs were produced (e.g., by a zero-width
2123 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2124 buffer positions that will be removed from the glyph row because
2125 they don't fit.
c02dcedf
EZ
2126 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2127 column is beyond frame width: don't subtract 1 "pixel" when
2128 computing width of the stretch.
3e62b7e0
EZ
2129 (reseat_at_next_visible_line_start): Undo the change made on
2130 2011-09-17 that saved paragraph information and restored it after
2131 the call to `reseat'. (Bug#9545)
56cd55c8 2132
5ed99d36 21332011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2134
2135 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2136 and turn window cursor on if cleared (Bug#9415).
2137
5ed99d36 21382011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2139
2140 * search.c (boyer_moore): Take unibyte characters from pattern
2141 literally. (Bug#9458)
2142
9bade7b2
EZ
21432011-09-18 Eli Zaretskii <eliz@gnu.org>
2144
2145 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2146
e5e9d610
PE
21472011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2148
87e4427a
PE
2149 Fix minor problem found by static checking.
2150 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2151 initialized, to pacify gcc -Wuninitialized.
2152
e5e9d610
PE
2153 * fileio.c: Report proper errno when syscall falls.
2154 (Finsert_file_contents): Save and restore errno,
2155 so that report_file_error outputs the correct diagnostic.
2156 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2157
a1674f0b
EZ
21582011-09-18 Eli Zaretskii <eliz@gnu.org>
2159
2160 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2161
fbfb6dd4
EZ
21622011-09-17 Eli Zaretskii <eliz@gnu.org>
2163
2164 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2165 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2166
bb187662
EZ
21672011-09-17 Eli Zaretskii <eliz@gnu.org>
2168
1137e8b8 2169 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2170 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2171
2172 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2173 (bidi_find_paragraph_start): Search back for paragraph beginning
2174 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2175 (bidi_move_to_visually_next): Only trigger paragraph-related
2176 computations when the last character is a newline or at EOB, not
2177 just any NEUTRAL_B. (Bug#9470)
2178
bb187662
EZ
2179 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2180 truncated lines if point is covered by a display string. (Bug#9524)
2181
2e621251
PE
21822011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2183
2184 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2185 (cons_to_x_long): New function.
2186 (lisp_data_to_selection_data): Use it. Correct the test for
2187 short-versus-long data; it was negated. Break out of vector
2188 loop, for efficiency, when a long datum is discovered.
2189
91a15bc6
SM
21902011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2191
2192 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2193
b41c3a35
EZ
21942011-09-16 Eli Zaretskii <eliz@gnu.org>
2195
2196 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2197 GCC PR/17406) by declaring this function with external scope.
2198
7812ba2d
PE
21992011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2200
2201 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2202 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2203
cf7edc2a
AS
22042011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2205
2206 * editfns.c (Fformat): Correctly handle text properties on "%%".
2207
bd01620e
EZ
22082011-09-15 Eli Zaretskii <eliz@gnu.org>
2209
2210 * xterm.c (x_draw_composite_glyph_string_foreground):
2211 * w32term.c (x_draw_composite_glyph_string_foreground):
2212 * term.c (encode_terminal_code):
2213 * composite.c (composition_update_it, get_composition_id):
2214 * xdisp.c (get_next_display_element)
2215 (fill_composite_glyph_string): Add comments about special meaning
2216 of TAB characters in a composition.
2217
a02719a3
PE
22182011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2219
2220 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2221 This occurs when processing a multibyte format.
2222 Problem reported by Wolfgang Jenker.
a02719a3 2223
72589a3c
JB
22242011-09-15 Johan Bockgård <bojohan@gnu.org>
2225
2226 * xdisp.c (try_cursor_movement): Only check for exact match if
2227 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2228
1c14176c
PE
22292011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2230
2231 Remove unused external symbols.
2232 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2233 * xdisp.c (calc_pixel_width_or_height): Now static.
2234 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2235 * indent.c (check_display_width):
2236 * w32term.c: Fix comment to match code.
2237 * xterm.c, xterm.h (x_catching_errors): Remove.
2238
d2eea5b5
PE
22392011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2240
2241 * xselect.c: Use signed conversions more consistently (Bug#9498).
2242 (selection_data_to_lisp_data): Assume incoming selection data are
2243 signed integers, not unsigned. This is to be consistent with
2244 outgoing selection data, which was modified to use signed integers
2245 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2246 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2247 expects long, not unsigned long.
2248
46888499
EZ
22492011-09-14 Eli Zaretskii <eliz@gnu.org>
2250
2251 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2252 computation of loop end. Reported by Johan Bockgård
2253 <bojohan@gnu.org>.
2254
ef8ef9fb
CY
22552011-09-13 Chong Yidong <cyd@stupidchicken.com>
2256
2257 * frame.c (Fother_visible_frames_p): Function deleted.
2258
fa819fed
EZ
22592011-09-12 Eli Zaretskii <eliz@gnu.org>
2260
2261 * indent.c (compute_motion): Process display vector front to back
2262 rather than the other way around. (Bug#2496)
2263
2ba8e008
SM
22642011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2265
2266 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2267
20f53c69
CY
22682011-09-11 Chong Yidong <cyd@stupidchicken.com>
2269
2270 * minibuf.c (Fread_from_minibuffer): Doc fix.
2271
d562d7a4
EZ
22722011-09-11 Eli Zaretskii <eliz@gnu.org>
2273
2274 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2275 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2276
1c4d7f3d
LMI
22772011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2278
2279 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2280 value for non-existent files.
2281
b885bf36
EZ
22822011-09-11 Eli Zaretskii <eliz@gnu.org>
2283
2284 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2285 set its "size" to -1. This will set the modtime_size field of
2286 the corresponding buffer to -1, which is what
2287 verify-visited-file-modtime expects for files that do not exist.
2288 (Bug#9139)
2289
6612f0bf
PE
22902011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2291
2292 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2293 here ...
2294 * lisp.h: ... from here. push_key_description is no longer
2295 defined in keyboard.c, so its declaration should not be in
2296 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2297 logically belongs with push_key_description.
2298
dfb3f755
PE
22992011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2300
2301 * buffer.h: Include <sys/types.h> instead of <time.h>.
2302 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2303 Problem reported by Herbert J. Skuhra.
2304
3134906c
LMI
23052011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2306
2307 * xml.c (parse_region): Make the parsing work for
2308 non-comment-starting XML files again (bug#9144).
2309
8d903f4e
AS
23102011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2311
2312 * image.c (gif_load): Fix calculation of bottom and right corner.
2313 (Bug#9468)
2314
80ad64f4
EZ
23152011-09-10 Eli Zaretskii <eliz@gnu.org>
2316
2317 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2318 redisplay in small windows.
2319
208a048d
EZ
23202011-09-09 Eli Zaretskii <eliz@gnu.org>
2321
2322 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2323
9b1c252e
MR
23242011-09-08 Martin Rudalics <rudalics@gmx.at>
2325
2326 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2327 Operate on live windows only.
2328
2949f33b
JB
23292011-09-08 Juanma Barranquero <lekktu@gmail.com>
2330
2331 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2332
e08dcafd
EZ
23332011-09-07 Eli Zaretskii <eliz@gnu.org>
2334
2335 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2336 only under bidi iteration.
2337
115b96bd
JD
23382011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2339
2340 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2341
c8199d0f
PE
23422011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2343
2344 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2345 Without this fix, the command to link temacs failed due to an
2346 undefined symbol __builtin_isnan. This is because
2347 /usr/include/iso/math_c99.h #defines isnan(x) to
2348 __builtin_isnan(x), but the bundled gcc, which identifies itself
2349 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2350 a __builtin_isnan.
2351 * floatfns.c (isnan): #undef, and then #define to a clone of
2352 what's in data.c.
2353 (Fisnan): Always define, since it's always available now.
2354 (syms_of_floatfns): Always define isnan at the Lisp level.
2355
e39b275c 23562011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2357
2358 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2359
b2db44d9 23602011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2361
f4af5137 2362 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2363 The previous code assumed that file offsets (off_t values) fit in
2364 EMACS_INT variables, which is not true on typical 32-bit hosts.
2365 The code messed up by falsely reporting buffer overflow in cases
2366 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2367 when "big" contains more than 2**29 bytes, even though this
2368 inserts just one byte and does not overflow the buffer.
2369 (Finsert_file_contents): Store file offsets as off_t
2370 values, not as EMACS_INT values. Check for overflow when
2371 converting between EMACS_INT and off_t. When checking for
2372 buffer overflow or for overlap, take the offsets into account.
2373 Don't use EMACS_INT for small values where int suffices.
2374 When checking for overlap, fix a typo: ZV was used where
2375 ZV_BYTE was intended.
2376 (Fwrite_region): Don't assume off_t fits into 'long'.
2377 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2378
ecfc0a49
MA
23792011-09-05 Michael Albinus <michael.albinus@gmx.de>
2380
2381 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2382
6511acf2 23832011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2384
0999621a 2385 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2386
2387 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2388 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2389 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2390 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2391 (modify_event_symbol): Do not assume that the length of
2392 name_alist_or_stem is safe to alloca and fits in int.
2393 (Fexecute_extended_command): Likewise for function name and binding.
2394 (Frecursion_depth): Wrap around reliably on integer overflow.
2395 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2396 since some callers pass EMACS_INT values.
2397 (Fsingle_key_description): Don't crash if symbol name contains more
2398 than MAX_ALLOCA bytes.
2399 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2400 (get_minibuffer): Arg is now EMACS_INT, not int.
2401 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2402 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2403 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2404
2be7d702
PE
2405 * dbusbind.c (signature_cat): New function.
2406 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2407 Do not overrun buffer; instead, report string overflow.
2408
9d1df220
PE
2409 * dispnew.c (add_window_display_history): Don't overrun buffer.
2410 Truncate instead; this is OK since it's just a log.
2411
33ef5c64
PE
2412 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2413 even if the time zone offset is outlandishly large.
2414 Don't mishandle offset == INT_MIN.
2415
66c6fdd5
PE
2416 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2417 when creating daemon; the previous buffer-overflow check was incorrect.
2418
d749b01b
PE
2419 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2420 which has the guts of the old verror function.
2421
b5cd1905
PE
2422 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2423 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2424
6e1a67fb
PE
2425 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2426 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2427 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2428 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2429 length of string rather than counting it via multiple sprintfs;
2430 that's simpler and more reliable.
c21721cc
PE
2431 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2432 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2433 sprintf, in case result does not fit in int.
2434
c57b67fc
PE
2435 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2436 (fontset_from_font): Print it.
2437
8a401434
PE
2438 * frame.c (tty_frame_count): Now printmax_t, not int.
2439 (make_terminal_frame, set_term_frame_name): Print it.
2440 (x_report_frame_params): In X, window IDs are unsigned long,
2441 not signed long, so print them as unsigned.
2442 (validate_x_resource_name): Check for implausibly long names,
2443 and don't assume name length fits in 'int'.
2444 (x_get_resource_string): Don't blindly alloca invocation name;
2445 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2446 not fit in int.
2447
6e1a67fb
PE
2448 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2449 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2450 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2451
0df02bf3
PE
2452 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2453 Use esprintf, not sprintf, in case result does not fit in int.
2454
48e30793
PE
2455 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2456 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2457 it as a large positive number.
2458 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2459 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2460
a66ff6d8
PE
2461 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2462 in case result does not fit in int.
2463
aca216ff
PE
2464 * print.c (float_to_string): Detect width overflow more reliably.
2465 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2466 buffer overrun. Don't assume list length fits in 'int'. Treat
2467 print length of 0 as 0, not as infinity; to be consistent with other
2468 uses of print length in this function. Don't overflow print length
2469 index. Don't assume hash table size fits in 'long', or that
2470 vectorlike size fits in 'unsigned long'.
2471
31c286f7
PE
2472 * process.c (make_process): Use printmax_t, not int, to format
2473 process-name gensyms.
2474
55e5faa1
PE
2475 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2476
80f2e268
PE
2477 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2478 to avoid potential buffer overrun.
2479
670741ab
PE
2480 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2481 if X resource line is longer than 512 bytes.
2482
b7163a50
PE
2483 * xfns.c (x_window): Make sprintf buffer a bit bigger
2484 to avoid potential buffer overrun.
2485
ae58ff1f
PE
2486 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2487
c43c8a6a
PE
2488 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2489
3f8236f4
PE
24902011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2491
53e9fe90 2492 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2493 Without these, Emacs silently mishandles large integers sometimes.
2494 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2495 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2496
6511acf2
PE
2497 * xdisp.c (try_window_id): Check Emacs fixnum range before
2498 converting to 'int'.
806add1d 2499
6511acf2 2500 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2501 Check that an Emacs fixnum is in range before assigning it to 'int'.
2502 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2503 values converted from Emacs fixnums.
2504 (Frecenter): Don't wrap around a line count if it is out of 'int'
2505 range; instead, treat it as an extreme value.
2506 (Fset_window_configuration, compare_window_configurations):
2507 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2508
6511acf2
PE
2509 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2510 that can exceed INT_MAX. Check that EMACS_INT value is in range
2511 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2512 (match_limit): Don't assume that a fixnum can fit in 'int'.
2513
6511acf2 2514 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2515 exceed INT_MAX.
2516
6511acf2 2517 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2518 (Fvertical_motion): Don't wrap around LINES values that don't fit
2519 in 'int'. Instead, treat them as extreme values. This is good
2520 enough for windows, which can't have more than INT_MAX lines anyway.
2521
fcb901a7
LMI
25222011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2523
0f2f6b6d
LMI
2524 * Require libxml/parser.h to avoid compilation warning.
2525
fcb901a7
LMI
2526 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2527
2528 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2529 since this reportedly can destroy thread storage.
2530
6e20a0d4
CY
25312011-08-30 Chong Yidong <cyd@stupidchicken.com>
2532
2533 * syntax.c (find_defun_start): Update all cache variables if
2534 exiting early (Bug#9401).
2535
148ae00e
EZ
25362011-08-30 Eli Zaretskii <eliz@gnu.org>
2537
f6cfbd8f
EZ
2538 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2539
148ae00e
EZ
2540 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2541 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2542 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2543
2544 * term.c (tty_append_glyph): New function.
2545 (produce_stretch_glyph): Static function and its prototype deleted.
2546
a66cfb1c
SM
2547 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2548 Add prototypes.
148ae00e 2549
c4a07a4c
PE
25502011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2551
2552 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2553 when checking :margin (Bug#9390).
2554 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2555 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2556 so that the name doesn't mislead. All uses changed.
2557
6bc8cd65
JB
25582011-08-28 Johan Bockgård <bojohan@gnu.org>
2559
2560 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2561 set_tty_hooks.
2562
dca4927e
EZ
25632011-08-27 Eli Zaretskii <eliz@gnu.org>
2564
2565 * xdisp.c (move_it_to): Don't bail out early when reaching
2566 position beyond to_charpos, if we are scanning backwards.
2567 (move_it_vertically_backward): When DY == 0, make sure we get to
2568 the first character in the line after the newline.
2569
f2cad773
PE
25702011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2571
2572 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2573 (ccl_driver): Do not generate an out-of-range pointer.
2574 (Fccl_execute_on_string): Remove unnecessary check for
2575 integer overflow, noted by Stefan Monnier in
2576 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2577 Remove a FIXME that didn't need fixing.
2578 Simplify the newly-introduced buffer reallocation code.
2579
0cae2cdb
JB
25802011-08-27 Juanma Barranquero <lekktu@gmail.com>
2581
2582 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2583
5fc295a4 25842011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2585
70c60eb2 2586 Integer and memory overflow issues (Bug#9196).
726e0ab1 2587
d31850da
PE
2588 * doc.c (get_doc_string): Rework so that
2589 get_doc_string_buffer_size is the actual buffer size, rather than
2590 being 1 less than the actual buffer size; this makes xpalloc more
2591 convenient.
2592
a69fbedb
PE
2593 * image.c (x_allocate_bitmap_record, cache_image):
2594 * xselect.c (Fx_register_dnd_atom):
2595 Simplify previous changes by using xpalloc.
2596
fe5c5d37
PE
2597 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2598 since either will do and ptrdiff_t is convenient with xpalloc.
2599
0065d054
PE
2600 * charset.c (charset_table_size)
2601 (struct charset_sort_data.priority): Now ptrdiff_t.
2602 (charset_compare): Don't overflow if priorities differ greatly.
2603 (Fsort_charsets): Don't assume list length fits in int.
2604 Check for size-calculation overflow when allocating sort data.
2605 (syms_of_charset): Allocate an initial charset table that is
2606 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2607
2608 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2609
2610 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2611 The actual value is always <= INT_MAX, and leaving it unsigned made
2612 overflow checking harder.
2613
2614 * dispextern.h (struct glyph_matrix.rows_allocated)
2615 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2616 with xpalloc. The values are still always <= INT_MAX.
2617
2618 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2619
2620 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2621 (SAFE_NALLOCA): New macro.
2622
2623 * region-cache.c (struct boundary.pos, find_cache_boundary)
2624 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2625 (set_cache_region, invalidate_region_cache)
2626 (revalidate_region_cache, know_region_cache, region_cache_forward)
2627 (region_cache_backward, pp_cache):
2628 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2629 so that ptrdiff_t * can be passed to xpalloc.
2630 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2631 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2632 (pp_cache): Don't assume cache_len fits in int.
2633 * region-cache.h: Adjust extern decls to match.
2634
2635 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2636 EMACS_INT, since either will do, for xpalloc.
2637
2638 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2639 (xnmalloc, xnrealloc, xpalloc): New functions.
2640
726e0ab1
PE
2641 * bidi.c (bidi_shelve_header_size): New constant.
2642 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2643 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2644
51f30bc5 2645 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2646 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2647 (overlay_strings):
2648 Don't update size of array until after memory allocation succeeds,
2649 because xmalloc/xrealloc may not return.
0065d054
PE
2650 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2651 now that we have proper integer overflow checking.
2652 (record_overlay_string, overlay_strings): Catch overflows when
2653 calculating size of overlay_str_buf.
726e0ab1 2654
0065d054
PE
2655 * callproc.c (Fcall_process): Check for size overflow when
2656 calculating size of args2.
2657 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2658 Normally we prefer signed values, but sticking with ptrdiff_t would
2659 require adding more-complicated checks.
726e0ab1
PE
2660
2661 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2662 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2663 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2664 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2665
2666 * character.c (Fstring): Check for size-calculation overflow.
2667
2668 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2669 unnecessary integer overflow. Check for size overflow.
2670 (encode_coding_object): Don't update size until xmalloc succeeds.
2671
2672 * composite.c (get_composition_id): Check for overflow in glyph
2673 length calculations.
2674
2675 Integer and memory overflow fixes for display code.
2676 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2677 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2678 (scrolling_window): Check for overflow in size calculations.
2679 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2680 Don't assume glyph table len fits in int.
2681 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2682 (row_table_size): Now ptrdiff_t, not int.
2683 (scrolling_window): Avoid overflow in size calculations.
2684 Don't update size until allocation succeeds.
2685 * fns.c (concat): Check for overflow in size calculations.
2686 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2687 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2688 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2689
2690 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2691 (get_doc_string): Check for size calculation overflow.
2692 Don't update size until allocation succeeds.
2693 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2694 EMACS_INT, where ptrdiff_t will do.
2695 (Fsubstitute_command_keys): Check for string overflow.
2696
2697 * editfns.c (set_time_zone_rule): Don't assume environment length
2698 fits in int.
2699 (message_length): Now ptrdiff_t, not int.
2700 (Fmessage_box): Don't update size until allocation succeeds.
2701 Don't assume message length fits in int.
2702 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2703
0065d054
PE
2704 * emacs.c (main): Do not reallocate argv, since there is a null at
2705 the end that can be overwritten, and this way there's no need to
2706 worry about size-calculation overflow.
2707 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2708
2709 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2710 alloc succeeds.
2711 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2712
2713 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2714 (x_set_scroll_bar_width, x_figure_window_size):
2715 Check for integer overflow.
2716 (x_set_alpha): Do not assume XINT fits in int.
2717
2718 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2719 This is for the members text_lines, text_cols, total_lines, total_cols,
2720 where the system imposes an 'int' limit.
2721
2722 * fringe.c (Fdefine_fringe_bitmap):
2723 Don't update size until alloc works.
2724
2725 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2726 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2727
2728 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2729 Check for size-calculation overflow.
2730 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2731 do, as we prefer signed integers.
2732 (id_to_widget.max_size, id_to_widget.used)
2733 (xg_store_widget_in_map, xg_remove_widget_from_map)
2734 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2735 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2736 Use and return ptrdiff_t, not int.
2737 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2738 * gtkutil.h: Change prototypes to match the above.
2739
2740 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2741 are duplicate now that they've been promoted to lisp.h.
2742 (x_allocate_bitmap_record, x_alloc_image_color)
2743 (make_image_cache, cache_image, xpm_load):
2744 Don't update size until alloc is done.
2745 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2746 (x_detect_edges):
3256efce 2747 Check for size calculation overflow.
726e0ab1
PE
2748 (ct_colors_allocated_max): New constant.
2749 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2750 overflow.
3256efce 2751
726e0ab1
PE
2752 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2753 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2754 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2755 Use ptrdiff_t, not int, to count maps.
2756 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2757 calculations. Don't update size until allocation succeeds.
2758 Redo calculations to avoid overflow.
726e0ab1
PE
2759 * keyboard.h: Change prototypes to match the above.
2760
2761 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2762 to count maps.
2763 (current_minor_maps): Check for size calculation overflow.
2764 * keymap.h: Change prototypes to match the above.
2765
2766 * lread.c (read1, init_obarray): Don't update size until alloc done.
2767
2768 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2769 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2770
726e0ab1
PE
2771 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2772 Now ptrdiff_t, not int.
2773 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2774 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2775
2776 * process.c (Fnetwork_interface_list): Check for overflow
2777 in size calculation.
2778
2779 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2780
2781 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2782 overflow. Don't bother calling xmalloc when xrealloc will do.
2783
2784 * search.c (Freplace_match): Check for size calculation overflow.
2785 (Fset_match_data): Don't assume list lengths fit in 'int'.
2786
2787 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2788 for command line length. Do not attempt to address one before the
2789 beginning of an array, as that's not portable.
2790
2791 * term.c (max_frame_lines): Remove; unused.
2792 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2793 not int.
2794 (encode_terminal_code, calculate_costs): Check for size
2795 calculation overflow.
2796 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2797 table lengths and related sizes. Don't update size until alloc
2798 done. Redo calculations to avoid overflow.
2799 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2800
2801 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2802 subtracting pointers.
2803 (gobble_line): Check for overflow more carefully. Don't update size
2804 until alloc done.
2805
2806 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2807 Don't update size until alloc done.
2808 Redo size calculations to avoid overflow.
2809 Check for size calculation overflow.
0065d054 2810 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2811
2812 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2813 Use ptrdiff_t, not int, for sizes.
2814 (store_mode_line_noprop_char): Don't update size until alloc done.
2815
0065d054
PE
2816 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2817 Use ptrdiff_t, not int, for sizes.
2818 (Finternal_make_lisp_face, cache_face):
2819 Check for size calculation overflow.
2820 (cache_face): Treat size calculation overflows as if they were
2821 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2822
2823 * xfns.c (x_encode_text, x_set_name_internal)
2824 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2825 sizes, since they can exceed INT_MAX in size. Check for size
2826 calculation overflow.
2827
0065d054
PE
2828 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2829 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2830 Don't update size until alloc done.
2831
0065d054 2832 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2833 as sprintf is limited to int lengths.
1d526e2f 2834
252c5ee1
PE
2835 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2836 (X_LONG_MIN): New macros.
864d7ce7
PE
2837 Use them to make the following changes clearer.
2838 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2839 This change doesn't affect the value now, but it may help remind
2840 future maintainers not to raise the value too much later.
2841 (SELECTION_QUANTUM): Remove, replacing with ...
2842 (selection_quantum): ... new function, which avoids overflow.
2843 All uses changed.
2844 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2845 assumption that selection length fits in 'int'.
2846 (x_reply_selection_request, x_handle_selection_request)
2847 (x_get_window_property, receive_incremental_selection)
2848 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2849 (lisp_data_to_selection_data, clean_local_selection_data):
2850 Use ptrdiff_t, not int, to record length of selection.
2851 (x_reply_selection_request, x_get_window_property)
2852 (receive_incremental_selection, x_property_data_to_lisp):
2853 Redo calculations to avoid overflow.
2854 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2855 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2856 something.
2857 (x_get_window_property, receive_incremental_selection)
2858 (lisp_data_to_selection_data, x_property_data_to_lisp):
2859 Check for size-calculation overflow.
2860 (x_get_window_property, receive_incremental_selection)
2861 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2862 Don't store size until memory allocation succeeds.
2863 (x_get_window_property): Plug memory leak on memory exhaustion.
2864 Don't double-block input; malloc is safe here. Don't assume 2**34
2865 - 4 fits in unsigned long. Add an xassert to check
2866 XGetWindowProperty overflow. Be more careful about overflow
2867 calculations, and distinguish size from memory overflow better.
2868 (receive_incremental_selection): When tracing, don't assume
2869 unsigned int is less than INT_MAX.
2870 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2871 harmful) conversions of unsigned short to int.
2872 (lisp_data_to_selection_data): Don't assume that integers
2873 in the range -65535 through -1 fit in an X unsigned short.
2874 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2875 result parameters unless successful. Rely on cons_to_unsigned
2876 to report problems with elements; the old code wasn't right anyway.
2877 (x_check_property_data): Check for int overflow; we cannot use
2878 a wider type due to X limits.
2879 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2880
726e0ab1 2881 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2882
0065d054
PE
2883 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2884 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2885 (x_color_cells): Don't store size until memory allocation succeeds.
2886 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2887 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2888 (x_term_init): Don't assume length fits in int (sprintf is limited
2889 to int size).
bc18e09d 2890
ebfa62c0
PE
2891 Use ptrdiff_t for composition IDs.
2892 * character.c (lisp_string_width):
2893 * composite.c (composition_table_size, n_compositions)
2894 (get_composition_id, composition_gstring_from_id):
2895 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2896 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2897 * window.c (Frecenter):
2898 Use ptrdiff_t, not int, for composition IDs.
2899 * composite.c (get_composition_id): Check for integer overflow.
2900 * composite.h: Adjust prototypes to match the above changes.
2901
d3411f89
PE
2902 Use ptrdiff_t for hash table indexes.
2903 * category.c (hash_get_category_set):
2904 * ccl.c (ccl_driver):
2905 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2906 * coding.c (coding_system_charset_list, detect_coding_system):
2907 * coding.h (struct coding_system.id):
2908 * composite.c (get_composition_id, gstring_lookup_cache):
2909 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2910 * image.c (xpm_get_color_table_h):
2911 * lisp.h (hash_lookup, hash_put):
2912 * minibuf.c (Ftest_completion):
2913 Use ptrdiff_t for hash table indexes, not int (which is too
2914 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2915 32-bit --with-wide-int hosts).
2916
e097a6fa
PE
2917 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2918 Add a FIXME comment about memory leaks.
2919 (syms_of_charset): Don't assume xmalloc returns.
2920
5637687f
PE
2921 Don't assume that stated character widths fit in int.
2922 * character.c (Fchar_width, c_string_width, lisp_string_width):
2923 * character.h (CHAR_WIDTH):
2924 * indent.c (MULTIBYTE_BYTES_WIDTH):
2925 Use sanitize_char_width to avoid undefined and/or bad behavior
2926 with outlandish widths.
a66cfb1c 2927 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2928 now that we have two such functions. All uses changed.
2929 (sanitize_char_width): New inline function.
2930
a2271ba2
PE
2931 Don't assume that tab-width fits in int.
2932 * character.h (sanitize_width): New inline function.
2933 (SANE_TAB_WIDTH): New macro.
2934 (ASCII_CHAR_WIDTH): Use it.
2935 * indent.c (sane_tab_width): Remove. All uses replaced by
2936 SANE_TAB_WIDTH (current_buffer).
2937 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2938
18c52557
PE
2939 * fileio.c: Integer overflow issues with file modes.
2940 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2941
caeeedc1
PE
2942 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2943 Remove unreachable code.
2944 (read_hex, load_charset_map_from_file): Check for integer overflow.
2945
6df6ae42 2946 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2947 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2948 (x_send_scroll_bar_event): Likewise. Check that the size does not
2949 exceed limits imposed by XClientMessageEvent, as well as the usual
2950 ptrdiff_t and size_t limits.
2951
b13995db
PE
2952 * keyboard.c: Overflow, signedness and related fixes.
2953 (make_lispy_movement): Use same integer type in forward decl
2954 that is used in the definition.
2955 (read_key_sequence, keyremap_step):
2956 Change bufsize argument back to int, undoing my 2011-03-30 change.
2957 We prefer signed types, and int is wide enough here.
2958 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2959 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2960 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2961 length, not size_t. Use ptrdiff_t for index, not int.
2962 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2963 possibility of integer overflow.
2964
13464394
PE
2965 Overflow, signedness and related fixes for images.
2966
2967 * dispextern.h (struct it.stack[0].u.image.image_id)
2968 (struct_it.image_id, struct image.id, struct image_cache.size)
2969 (struct image_cache.used, struct image_cache.ref_count):
2970 * gtkutil.c (update_frame_tool_bar):
2971 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2972 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2973 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2974 * nsmenu.m (update_frame_tool_bar):
2975 * xdisp.c (calc_pixel_width_or_height):
2976 * xfns.c (image_cache_refcount):
2977 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2978 on typical 64-bit hosts.
2979
2980 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2981 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2982 Omit unnecessary casts to int.
2983 (parse_image_spec): Check that integers fall into 'int' range
2984 when the callers expect that.
2985 (image_ascent): Redo ascent calculation to avoid int overflow.
2986 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2987 (lookup_image): Remove unnecessary tests.
2988 (xbm_image_p): Locals are now of int, not EMACS_INT,
2989 since parse_image_check makes sure they fit into int.
2990 (png_load, gif_load, svg_load_image):
2991 Prefer int to unsigned where either will do.
2992 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2993 old tiff_error_handler and tiff_warning_handler.
2994 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2995 stack buffer overflows. It uses only the features of vsnprintf
2996 that are common to both POSIX and native Microsoft.
2997 (tiff_error_handler, tiff_warning_handler): Use it.
2998 (tiff_load, gif_load, imagemagick_load_image):
2999 Don't assume :index value fits in 'int'.
3000 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3001 (imagemagick_load_image): Check that crop parameters fit into
3002 the integer types that MagickCropImage accepts. Don't assume
3003 Vimagemagick_render_type has a nonnegative value. Don't assume
3004 size_t fits in 'long'.
3005 (gs_load): Use printmax_t to print the widest integers possible.
3006 Check for integer overflow when computing image height and width.
3007
c11821d4
EZ
30082011-08-26 Eli Zaretskii <eliz@gnu.org>
3009
3010 * xdisp.c (redisplay_window): Don't force window start if point
3011 will be invisible in the resulting window. (Bug#9324)
3012
0c95fcf7
EZ
30132011-08-25 Eli Zaretskii <eliz@gnu.org>
3014
3015 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3016 the display spec is of the form `(space ...)'.
3017 (handle_display_spec): Return the value returned by
3018 handle_single_display_spec, not just 1 or zero.
3019 (handle_single_display_spec): If the display spec is of the form
3020 `(space ...)', and specifies display in the text area, return 2
3021 rather than 1.
fee65a97 3022 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
3023 accurately, and prefer exact match for point under bidi.
3024 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
3025
3026 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3027 into disp_prop; all users changed.
3028
3029 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3030 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3031 for the text covered by the display property.
3032
e4ed06f1
CY
30332011-08-25 Chong Yidong <cyd@stupidchicken.com>
3034
3035 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3036 Change return value to nil.
3037 (Frecord_buffer): Delete unused function.
3038
f67cdd7f
EZ
30392011-08-24 Eli Zaretskii <eliz@gnu.org>
3040
5980d4c6
EZ
3041 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3042 buffers, return left-to-right.
8610fe8b
EZ
3043 (set_cursor_from_row): Consider candidate row a win if its glyph
3044 represents a newline and point is on that newline. Fixes cursor
3045 positioning on the newline at EOL of R2L text within L2R
3046 paragraph, and vice versa.
3047 (try_cursor_movement): Check continued rows, in addition to
3048 continuation rows. Fixes unwarranted scroll when point enters a
3049 continued line of R2L text within an L2R paragraph, or vice versa.
3050 (cursor_row_p): Consider the case of point being equal to
3051 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3052 from the end of a short line to the beginning of a continued line
3053 of R2L text within L2R paragraph.
3054 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3055 composed characters.
5980d4c6 3056
f67cdd7f
EZ
3057 * bidi.c (bidi_check_type): Use xassert.
3058 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3059 members.
3060
bca633fb
EZ
30612011-08-23 Eli Zaretskii <eliz@gnu.org>
3062
3063 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3064 a character.
3065
4a5885a7
CY
30662011-08-23 Chong Yidong <cyd@stupidchicken.com>
3067
3068 * nsfont.m (ns_otf_to_script): Fix typo.
3069
0902a04e
KH
30702011-08-22 Kenichi Handa <handa@m17n.org>
3071
3072 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3073 extra slot even if the purpose is char-code-property-table.
3074
1a2e6670
EZ
30752011-08-23 Eli Zaretskii <eliz@gnu.org>
3076
8ddde651
EZ
3077 * xdisp.c (redisplay_window): When computing centering_position,
3078 account for the height of the header line. (Bug#8874)
3079
425cc014
EZ
3080 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3081 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3082 candidate is selected by the mouse, and that candidate has a
3083 composed character under the mouse.
3084
1a2e6670
EZ
3085 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3086 coordinates reported by pos-visible-in-window-p for a composed
3087 character in column zero.
3088
8b76d6f8
SM
30892011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3090
3091 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3092
dac347dd
EZ
30932011-08-22 Eli Zaretskii <eliz@gnu.org>
3094
3095 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3096 consider it a hit if to_charpos is anywhere in the range of the
3097 composed buffer positions.
3098
e013fb34
CY
30992011-08-22 Chong Yidong <cyd@stupidchicken.com>
3100
3101 * image.c (gif_load): Don't assume that each subimage has the same
3102 dimensions as the base image. Handle disposal method that is
3103 "undefined" by the gif spec (Bug#9335).
3104
bd1ba3e8
CY
31052011-08-20 Chong Yidong <cyd@stupidchicken.com>
3106
3107 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3108 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3109
54a1215b
EZ
31102011-08-19 Eli Zaretskii <eliz@gnu.org>
3111
823564e5
EZ
3112 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3113 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3114 from an Org mode buffer to a Speedbar frame.
3115
54a1215b
EZ
3116 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3117 a composition, take its buffer position from IT->cmp_it.charpos.
3118 Fixes cursor positioning at the beginning of a line that begins
3119 with a composed character.
3120
9778ebcc
EZ
31212011-08-18 Eli Zaretskii <eliz@gnu.org>
3122
0be6ee06
EZ
3123 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3124 character bidirectional type, use STRONG_L instead. Fixes crashes
3125 in a buffer produced by `describe-categories'.
3126
9778ebcc
EZ
3127 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3128 members before the level stack, so they would be saved and
3129 restored when copying iterator state. Fixes incorrect reordering
3130 around TABs covered by display properties.
3131
156bffbe
AS
31322011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3133
6b02f655 3134 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3135
72ad093b
CY
31362011-08-17 Chong Yidong <cyd@stupidchicken.com>
3137
3138 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3139 (internal_condition_case_2, internal_condition_case_n):
3140 Remove unnecessary aborts (Bug#9081).
72ad093b 3141
35774242
EZ
31422011-08-17 Eli Zaretskii <eliz@gnu.org>
3143
3144 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3145 has no `load' handler, try opening the file locally. (Bug#9311)
3146
db76dd85
KB
31472011-08-16 Ken Brown <kbrown@cornell.edu>
3148
3149 * gmalloc.c: Expand comment.
3150
b215eee5
EZ
31512011-08-16 Eli Zaretskii <eliz@gnu.org>
3152
3153 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3154 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3155
a4579d33
KB
31562011-08-16 Ken Brown <kbrown@cornell.edu>
3157
3158 Fix memory allocation problems in Cygwin build (Bug#9273).
3159
3160 * unexcw.c ( __malloc_initialized): Declare external variable.
3161 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3162
8b76d6f8
SM
3163 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3164 New variables.
a4579d33
KB
3165 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3166 dumped emacs.
3167 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3168 in the static heap.
3169 [CYGWIN] (special_realloc): New function.
3170 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3171 requests to realloc storage in the static heap.
3172
3ebec551
PE
31732011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3174
3175 * bidi.c (bidi_initialize): Remove unused local.
3176
9fd8be00
EZ
31772011-08-15 Eli Zaretskii <eliz@gnu.org>
3178
6b02f655
SM
3179 * bidimirror.h:
3180 * biditype.h: Remove file.
3181 * makefile.w32-in ($(BLD)/bidi.$(O)):
3182 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3183
3184 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3185
3186 * chartab.c: Improve commentary for the uniprop_table API.
3187
32413314
EZ
3188 * bidi.c (bidi_paragraph_init): Support zero value of
3189 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3190 (bidi_initialize): Use uniprop_table instead of including
3191 biditype.h and bidimirror.h.
32413314 3192
9fd8be00
EZ
3193 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3194 coordinates of the iterator when restoring from ppos_it.
3195 (Bug#9296)
3196
5cf2b69b
KH
31972011-08-14 Kenichi Handa <handa@m17n.org>
3198
3199 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3200 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3201
daf17d00
EZ
32022011-08-14 Eli Zaretskii <eliz@gnu.org>
3203
3204 * xdisp.c (move_it_in_display_line_to): Don't invoke
3205 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3206 ppos_it. Fixes vertical cursor motion when line beginning is
3207 covered by an image. (Bug#9296)
3208
08e3161a
JD
32092011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3210
3211 * nsterm.h (ns_run_ascript): Declare.
3212 (NSAPP_DATA2_RUNASSCRIPT): Define.
3213
3214 * nsfns.m (as_script, as_result, as_status): New static variables.
3215 (ns_run_ascript): New function.
5e617bc2 3216 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3217 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3218 the event loop. Get status from as_status (Bug#7276).
3219
3220 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3221 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3222 the event loop (Bug#7276).
3223
a3720aa2
AS
32242011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3225
3226 * gnutls.c (QCgnutls_bootprop_priority)
3227 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3228 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3229 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3230 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3231 (QCgnutls_bootprop_verify_hostname_error)
3232 (QCgnutls_bootprop_callbacks_verify): Rename from
3233 Qgnutls_bootprop_..., all uses changed.
3234
3235 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3236 uses changed.
3237
0a0d27fb
PE
32382011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3239
19d5c50c
PE
3240 * xfaces.c (Qframe_set_background_mode): Now static.
3241 * dispextern.h (Qframe_set_background_mode): Remove decl.
3242
0a0d27fb
PE
3243 * process.c (Fnetwork_interface_info): Declare local only if needed.
3244
377538cb
JD
32452011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3246
3247 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3248 (Fnetwork_interface_list): Allocate in increments of bytes instead
3249 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3250 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3251 sockaddr.
3252 (struct ifflag_def): notrailers is smart on OSX.
3253 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3254 Get hardware address with getifaddrs if available.
3255
08fff70c
EZ
32562011-08-12 Eli Zaretskii <eliz@gnu.org>
3257
3258 * xdisp.c (iterate_out_of_display_property): xassert that
3259 IT->position is set to within IT->object's boundaries. Break from
3260 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3261 when IT->position is set up wrongly due to some bug.
3262 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3263 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3264 entry. Force push_it to save on the stack the current
3265 buffer/string position, to be restored by pop_it. Fix flags in
3266 the iterator structure wrt the object coming from a display
3267 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3268 properties. (Bug#9284)
3269
7be1c708 32702011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3271
7be1c708
CY
3272 * fontset.c (fontset_get_font_group): Add proper type checks.
3273 (Bug#9172)
aac0c6e3 3274
7be1c708 32752011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3276
7be1c708
CY
3277 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3278 and LC_VERSION_MIN_MACOSX.
3279 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3280 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3281
97bb72a6
EZ
32822011-08-08 Eli Zaretskii <eliz@gnu.org>
3283
3284 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3285 no-display-properties-and-no-overlays under bidi display.
3286 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3287 properties and overlays.
97bb72a6 3288
d5617611
CY
32892011-08-08 Chong Yidong <cyd@stupidchicken.com>
3290
37e11a63
CY
3291 * editfns.c (Fset_time_zone_rule): Document relationship with the
3292 setenv function.
3293
d5617611
CY
3294 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3295 the font entity extracted from the cache (Bug#8109).
3296
58872834
CY
32972011-08-07 Chong Yidong <cyd@stupidchicken.com>
3298
3299 * composite.c (autocmp_chars): Don't reset point. That is done by
3300 restore_point_unwind (Bug#5984).
3301
75bfc667
JL
33022011-08-07 Juri Linkov <juri@jurta.org>
3303
3304 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3305 to show the arg `TIME' instead of `TIMEVAL'.
3306
d1410150
EZ
33072011-08-06 Eli Zaretskii <eliz@gnu.org>
3308
3309 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3310 display property strides EOL and includes a newline, as in
3311 longlines-mode. (Bug#9254)
75b771e4
EZ
3312 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3313 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3314
3315 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3316 is non-zero, even if the data buffer is NULL. Fixes a crash in
3317 vertical-motion with longlines-mode. (Bug#9254)
3318
35928349
EZ
33192011-08-05 Eli Zaretskii <eliz@gnu.org>
3320
ec7cc85b
EZ
3321 * bidi.c <bidi_cache_total_alloc>: Now static.
3322 (bidi_initialize): Initialize bidi_cache_total_alloc.
3323
8b76d6f8 3324 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3325 cache. (Bug#9221)
3326
3327 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3328 amount allocated this far in `bidi_cache_total_alloc'.
3329 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3330 non-zero, only free the data buffer without restoring the cache
3331 contents. All callers changed.
3332
3333 * dispextern.h (bidi_unshelve_cache): Update prototype.
3334
3335 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3336 (move_it_in_display_line, move_it_to)
3337 (move_it_vertically_backward, move_it_by_lines): Replace the call
3338 to xfree to an equivalent call to bidi_unshelve_cache.
3339 (move_it_in_display_line_to): Fix logic of returning
412b6358 3340 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3341
e2e2423b
EZ
33422011-08-05 Eli Zaretskii <eliz@gnu.org>
3343
3344 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3345 came from a string character with a `cursor' property. (Bug#9229)
3346
ae9e757a
JD
33472011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3348
3349 * Makefile.in (LIB_PTHREAD): New variable.
3350 (LIBES): Add LIB_PTHREAD (Bug#9216).
3351
3352 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3353 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3354
213bd7f2
AS
33552011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3356
6b02f655 3357 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3358
99aaf75f
JD
33592011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3360
3361 * xterm.c (x_find_topmost_parent): New function.
3362 (x_set_frame_alpha): Find topmost parent window with
3363 x_find_topmost_parent and set the property there also (bug#9181).
3364 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3365
c74e9d86
PE
33662011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3367
3368 * callproc.c (Fcall_process): Avoid vfork clobbering
3369 the local vars buffer, coding_systems, current_dir.
3370
640c8776
SM
33712011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3372
3373 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3374
f26d0e4c
PE
33752011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3376
8a10d76c
PE
3377 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3378 so that it is not optimized away.
3379
f26d0e4c
PE
3380 * xdisp.c (compute_display_string_pos): Remove unused local.
3381
55439c61
EZ
33822011-08-02 Eli Zaretskii <eliz@gnu.org>
3383
3384 Fix slow cursor motion and scrolling in large buffers with
3385 selective display, like Org Mode buffers. (Bug#9218)
3386
3387 * dispextern.h (struct bidi_it): New member disp_prop_p.
3388
3389 * xdisp.c: Remove one-slot cache of display string positions.
3390 (compute_display_string_pos): Accept an additional argument
5e617bc2 3391 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3392 for a display string or property. If found, set DISP_PROP_P
3393 non-zero.
3394
3395 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3396 DISP_PROP_P, and pass it to compute_display_string_pos.
3397 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3398 non-zero. All callers of bidi_fetch_char changed.
3399
fb33fa43
SM
34002011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3401
3402 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3403
b099e063
DM
34042010-12-03 Don March <don@ohspite.net>
3405
3406 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3407 last character M-[char] is translated to ESC [char] (bug#7541).
3408
5cc7f7af
KH
34092011-08-02 Kenichi Handa <handa@m17n.org>
3410
d0fffa3f 3411 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3412
3413 * chartab.c (uniprop_table): Make it non-static.
3414
525d5e6e
EZ
34152011-08-01 Eli Zaretskii <eliz@gnu.org>
3416
3417 * xdisp.c (forward_to_next_line_start): Accept additional argument
3418 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3419 on the newline.
3420 (reseat_at_next_visible_line_start): Use the bidi iterator state
3421 returned by forward_to_next_line_start to restore the state of
3422 it->bidi_it after backing up to previous newline. (Bug#9212)
3423
31011111
AS
34242011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3425
3426 * regex.c (re_comp): Protoize.
3427 (re_exec): Fix return type.
3428 (regexec): Fix type of `ret'. (Bug#9203)
3429
476371c4
PE
34302011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3431
e5d76069
PE
3432 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3433 This is needed if max-image-size is a floating-point number.
3434
9a79b20c
AS
34352011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3436
3437 * print.c (print_object): Print empty symbol as ##.
3438
3439 * lread.c (read1): Read ## as empty symbol.
3440
d8c2fa78
AA
34412011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3442
3443 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3444 setting frame foreground color (Bug#9175).
3445 (x_set_background_color): Likewise.
3446
ffe57a7a
AA
3447 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3448 contents (Bug#9176).
3449 (EmacsTooltip -init): Remove bezels and add shadows to
3450 tooltip windows.
3451
bf3492a5
AA
3452 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3453 or scroll bar (Bug#8470).
3454
d55e9c53
AA
3455 * nsfont.m (nsfont_open): Remove assignment to voffset and
3456 unnecessary vars hshink, expand, hd, full_height, min_height.
3457 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3458
3459 * nsterm.h (nsfont_info): Remove voffset field.
3460
d8c2fa78 34612011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3462
3463 Implement strike-through and overline on NextStep (Bug#8863).
3464
3465 * nsfont.m (nsfont_open): Use underline position provided by font,
3466 instead of hard-coded value of 2.
3467 (nsfont_draw): Call ns_draw_text_decoration instead.
3468
3469 * nsterm.h: Add declaration for ns_draw_text_decoration.
3470
3471 * nsterm.m (ns_draw_text_decoration): New function for drawing
3472 underline, overline, and strike-through.
3473 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3474 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3475 accommodate underlining, etc.
4843aac3 3476
4cc60b9b
EZ
34772011-07-28 Eli Zaretskii <eliz@gnu.org>
3478
bc7ece87
EZ
3479 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3480 default.
4cc60b9b 3481
476371c4
PE
34822011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3483
66606eea
PE
3484 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3485 Without this fix, if a signal arrives just after memory fills up,
3486 'malloc' might be invoked reentrantly.
3487
476371c4
PE
3488 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3489 In other words, assume that every image size is allowed, on non-X
3490 hosts. This assumption is probably wrong, but it lets Emacs compile.
3491
f3fcc40d
AS
34922011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3493
3494 * regex.c (re_iswctype): Convert return values to boolean.
3495
350c992f
EZ
34962011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3497
3498 * xdisp.c (compute_display_string_pos): Don't use cached display
3499 string position if the buffer had its restriction changed.
3500 (Bug#9184)
3501
5266b4bb
PE
35022011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3503
3504 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3505
2573a837 35062011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3507
41f55ccd 3508 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3509
39e378da
PE
3510 * bidi.c: Integer size and overflow fixes.
3511 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3512 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3513 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3514 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3515 (bidi_find_other_level_edge):
3516 Use ptrdiff_t instead of EMACS_INT where either will do.
3517 This works better on 32-bit hosts configured --with-wide-int.
3518 (bidi_cache_ensure_space): Check for size-calculation overflow.
3519 Use % rather than repeated addition, for better worst-case speed.
3520 Don't set bidi_cache_size until after xrealloc returns, because it
3521 might not return.
3522 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3523 (bidi_cache_ensure_space): Also check that the bidi cache size
3524 does not exceed that of the largest Lisp string or buffer. See Eli
3525 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3526
5e927815
PE
3527 * alloc.c (__malloc_size_t): Remove.
3528 All uses replaced by size_t. See Andreas Schwab's note
3529 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3530
ca4aa935
PE
3531 * image.c: Improve checking for integer overflow.
3532 (check_image_size): Assume that f is nonnull, since
3533 it is always nonnull in practice. This is one less thing to
3534 worry about when checking for integer overflow later.
3535 (x_check_image_size): New function, which checks for integer
3536 overflow issues inside X.
3537 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3538 This removes the need for a memory_full check.
3539 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3540 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3541 (xbm_read_bitmap_data): Change locals back to 'int', since
3542 their values must fit in 'int'.
3543 (xpm_load_image, png_load, tiff_load):
3544 Invoke x_create_x_image_and_pixmap earlier,
3545 to avoid much needless work if the image is too large.
3546 (tiff_load): Treat overly large images as if
3547 x_create_x_image_and_pixmap failed, not as malloc failures.
3548 (gs_load): Use x_check_image_size.
3549
5f8f9cc2
PE
3550 * gtkutil.c: Omit integer casts.
3551 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3552 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3553
5adf60bc
PE
3554 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3555
c8907a93
PE
3556 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3557 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3558 would wrongly return t on a 64-bit host.
3559
e3c25c68
PE
3560 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3561 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3562 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3563 and therefore cause GCC to emit a bogus diagnostic in some cases.
3564
3f791afe
PE
3565 * image.c: Integer signedness and overflow and related fixes.
3566 This is not an exhaustive set of fixes, but it's time to
3567 record what I've got.
3568 (lookup_pixel_color, check_image_size): Remove redundant decls.
3569 (check_image_size): Don't assume that arbitrary EMACS_INT values
3570 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3571 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3572 (tiff_load, imagemagick_load_image):
3573 Check for overflow in size calculations.
3574 (x_create_x_image_and_pixmap): Remove unnecessary test for
3575 xmalloc returning NULL; that can't happen.
3576 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3577 (xpm_color_bucket): Use better integer hashing function.
3578 (xpm_cache_color): Don't possibly over-allocate memory.
3579 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3580 (gif_memory_source):
3581 Use ptrdiff_t, not int or size_t, to record sizes.
3582 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3583 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3584 either works, as we prefer signed integers.
3585 (tiff_read_from_memory, tiff_write_from_memory):
3586 Return tsize_t, not size_t, since that's what the TIFF API wants.
3587 (tiff_read_from_memory): Don't fail simply because the read would
3588 go past EOF; instead, return a short read.
3589 (tiff_load): Omit no-longer-needed casts.
3590 (Fimagemagick_types): Don't assume size fits into 'int'.
3591
3cc5a532
PE
3592 Improve hashing quality when configured --with-wide-int.
3593 * fns.c (hash_string): New function, taken from sxhash_string.
3594 Do not discard information about ASCII character case; this
3595 discarding is no longer needed.
3596 (sxhash-string): Use it. Change sig to match it. Caller changed.
3597 * lisp.h: Declare it.
3598 * lread.c (hash_string): Remove, since we now use fns.c's version.
3599 The fns.c version returns a wider integer if --with-wide-int is
3600 specified, so this should help the quality of the hashing a bit.
3601
b312a492
PE
3602 * emacs.c: Integer overflow minor fix.
3603 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3604 Define only if GNU_LINUX.
3605 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3606
dfd153ae
PE
3607 * dispnew.c: Integer signedness and overflow fixes.
3608 Remove unnecessary forward decls, that were a maintenance hassle.
3609 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3610 All uses changed.
3611 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3612 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3613 (prepare_desired_row, line_draw_cost):
3614 Use int, not unsigned, where either works.
3615 (save_current_matrix, restore_current_matrix):
3616 Use ptrdiff_t, not size_t, where either works.
3617 (init_display): Check for overflow more accurately, and without
3618 relying on undefined behavior.
3619
a81d11a3
PE
3620 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3621 Remove, replacing with the new symbols in lisp.h. All uses changed.
3622 * fileio.c (make_temp_name):
3623 * filelock.c (lock_file_1, lock_file):
3624 * xdisp.c (message_dolog):
3625 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3626 Use pMd etc. instead.
3627 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3628 replacing the pWIDE etc. symbols removed from editfns.c.
3629
3300e6fd
PE
3630 * keyboard.h (num_input_events): Now uintmax_t.
3631 This is (very slightly) less likely to mess up due to wraparound.
3632 All uses changed.
3633
fd05c7e9
PE
3634 * buffer.c: Integer signedness fixes.
3635 (alloc_buffer_text, enlarge_buffer_text):
3636 Use ptrdiff_t rather than size_t when either will do, as we prefer
3637 signed integers.
3638
903fe15d
PE
3639 * alloc.c: Integer signedness and overflow fixes.
3640 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3641 (__malloc_size_t): Default to size_t, not to int.
3642 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3643 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3644 Prefer ptrdiff_t to size_t when either would do, as we prefer
3645 signed integers.
3646 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3647 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3648 Now const. Initialize with values that are in range even if char
3649 is signed.
3650 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3651 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3652 These functions do the right thing with sizes > 2**32.
3653 (check_depth): Now ptrdiff_t, not int.
3654 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3655 Adjust to new way of storing sizes. Check for size overflow bugs
3656 in rest of code.
3657 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3658 slightly wrong anyway, as it missed one instance of
3659 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3660 (refill_memory_reserve): Omit needless cast to size_t.
3661 (mark_object_loop_halt): Mark as externally visible.
3662
ac82cc6a
PE
3663 * xselect.c: Integer signedness and overflow fixes.
3664 (Fx_register_dnd_atom, x_handle_dnd_message):
3665 Use ptrdiff_t, not size_t, since we prefer signed.
3666 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3667 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3668 x_dnd_atoms_size and x_dnd_atoms_length.
3669
c2d1e36d
PE
3670 * doprnt.c: Prefer signed to unsigned when either works.
3671 * eval.c (verror):
3672 * doprnt.c (doprnt):
3673 * lisp.h (doprnt):
3674 * xdisp.c (vmessage):
3675 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3676 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3677 prefer signed arithmetic to avoid comparison confusion.
3678 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3679 but is a bit tricky.
3680
0e926e56
PE
3681 Assume freestanding C89 headers, string.h, stdlib.h.
3682 * data.c, doprnt.c, floatfns.c, print.c:
3683 Include float.h unconditionally.
3684 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3685 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3686 * regex.c: Likewise for stddef.h, string.h.
3687 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3688 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3689 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3690 (STDC_HEADERS): Remove obsolete defines.
3691 * sysdep.c: Include limits.h unconditionally.
3692
9cfdb3ec
PE
3693 Assume support for memcmp, memcpy, memmove, memset.
3694 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3695 * regex.c (memcmp, memcpy):
3696 Remove; we assume C89 now.
3697
3698 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3699 (__malloc_safe_bcopy): Remove; no longer needed.
3700
cf950e6b 3701 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3702 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3703 well either way, and we prefer signed to unsigned.
3704
dbf38e02
LMI
37052011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3706
3707 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3708 closes the connection while we're reading (bug#9182).
3709
d6f0886c 37102011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3711
d6f0886c
JD
3712 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3713 are specified (Bug#9168).
24e0f6b1 3714
2eb1f9e6
PE
37152011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3716
3717 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3718 Found by GCC static checking and --with-wide-int on a 32-bit host.
3719
22381272 37202011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3721
3722 * xdisp.c (compute_display_string_pos): Fix logic of caching
3723 previous display string position. Initialize cached_prev_pos to
3724 -1. Fixes slow-down at the beginning of a buffer.
3725
f25e39b4
EZ
37262011-07-24 Eli Zaretskii <eliz@gnu.org>
3727
3728 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3729 for attrs[LFACE_FONTSET_INDEX].
3730
04c4b52e
PE
37312011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3732
3733 * xml.c (parse_region): Remove unused local
3734 that was recently introduced.
3735
c1734fbd
EZ
37362011-07-23 Eli Zaretskii <eliz@gnu.org>
3737
be18c5a5
EZ
3738 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3739 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3740
c1734fbd
EZ
3741 * xdisp.c (move_it_in_display_line_to): Record the best matching
3742 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3743 exit if none of the characters scanned was an exact match.
3744 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3745 when exact match is impossible due to invisible text, and the
3746 lines are truncated.
3747
a258d627
JD
37482011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3749
3750 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3751 for OSX >= 10.7.
3752
b6d5a689
EZ
37532011-07-22 Eli Zaretskii <eliz@gnu.org>
3754
0f74f785
EZ
3755 Fix a significant slow-down of cursor motion with C-n, C-p,
3756 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3757 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3758 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3759 (next_element_from_buffer): Call compute_stop_pos_backwards to
3760 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3761 base_level_stop.
3762 (reseat): Don't look for prev_stop, as that could mean a very long
3763 run.
3764 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3765 <cached_disp_overlay_modiff>: Cache for last found display string
3766 position.
551918c1 3767 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3768 about the same buffer in the same area of character positions, and
3769 the buffer wasn't changed since the time the display string
3770 position was cached.
551918c1 3771
b2d0c91a
EZ
37722011-07-22 Eli Zaretskii <eliz@gnu.org>
3773
3774 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3775 is an integer, which is important for empty lines. (Bug#9149)
3776
043604ee
CY
37772011-07-22 Chong Yidong <cyd@stupidchicken.com>
3778
3779 * frame.c (Fmodify_frame_parameters): In tty case, update the
3780 default face if necessary (Bug#4238).
3781
da4adb04
CY
37822011-07-21 Chong Yidong <cyd@stupidchicken.com>
3783
3784 * editfns.c (Fstring_to_char): No need to explain what a character
3785 is in the docstring (Bug#6576).
3786
9abd0532
LMI
37872011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3788
3789 * xml.c (parse_region): Make sure we always return a tree.
3790
36881d16
HK
37912011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3792
3793 * xml.c (parse_region): If a document contains only comments,
3794 return that, too.
3795
1e98674d
LMI
37962011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3797
3798 * xml.c (make_dom): Return comments, too.
3799
590bd467
PE
38002011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3801
3802 Port to OpenBSD.
3803 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3804 and the surrounding thread.
3805 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3806 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3807 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3808 timer goes off.
3809 * s/openbsd.h (BROKEN_SIGIO): Define.
3810 * unexelf.c (unexec) [__OpenBSD__]:
3811 Don't update the .mdebug section of the Alpha COFF symbol table.
3812
f41628b2
LMI
38132011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3814
3815 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3816 (bug#8460).
3817
b59b67c5
PE
38182011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3819
15e3a074
PE
3820 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3821 This fixes some race conditions on the permissions of any newly
3822 created file.
3823
41bed37d
PE
3824 * alloc.c (valid_pointer_p): Use pipe, not open.
3825 This fixes some permissions issues when debugging.
3826
b59b67c5
PE
3827 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3828 If fchown fails to set both uid and gid, try to set just gid,
3829 as that is sometimes allowed. Adjust the file's mode to eliminate
3830 setuid or setgid bits that are inappropriate if fchown fails.
3831
925a6be7
SM
38322011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3833
3834 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3835 to compare Lisp_Objects.
3836 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3837 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3838 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3839
52968808
AS
38402011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3841
0a6a104b
AS
3842 * lread.c (read_integer): Unread even EOF character.
3843 (read1): Likewise. Properly record start position of symbol.
3844
52968808
AS
3845 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3846 symbol character follows.
3847
9e381cdd
PE
38482011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3849
3850 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3851 This works around a problem with the previous change to Fcopy_file.
3852 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3853 and without this change, GCC might complain about discarding
3854 fchown's return value.
3855
b5641435
JB
38562011-07-16 Juanma Barranquero <lekktu@gmail.com>
3857
3858 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3859
a8031457
PE
38602011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3861
3862 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3863
dd889327
LMI
38642011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3865
750c33f7
LMI
3866 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3867 it's used from the C level.
3868
dd889327
LMI
3869 * process.c: Use the same condition for POLL_FOR_INPUT in both
3870 keyboard.c and process.c (bug#1858).
3871
87e86684
LM
38722011-07-09 Lawrence Mitchell <wence@gmx.li>
3873
3874 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3875 (Fgnutls_boot): Use it.
3876
64348f40
AS
38772011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3878
3879 * doc.c (Fsubstitute_command_keys): Revert last change.
3880
1d698799
LMI
38812011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3882
f863868c
LMI
3883 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3884 quotes the next character, and doesn't affect other longer
3885 sequences (bug#8935).
3886
1d698799
LMI
3887 * lread.c (syms_of_lread): Clarify that is isn't only
3888 `eval-buffer' and `eval-defun' that's affected by
3889 `lexical-binding' (bug#8460).
3890
aa4b6df6
EZ
38912011-07-15 Eli Zaretskii <eliz@gnu.org>
3892
3893 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3894 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3895
5d856da6
PE
38962011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3897
ad6042bb
PE
3898 Fix minor problems found by static checking.
3899 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3900 (elsz): Now a signed constant, not a size_t var. We prefer signed
3901 types to unsigned, to avoid integer comparison confusion. Without
3902 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3903 "cannot optimize loop, the loop counter may overflow", a symptom
3904 of the confusion.
f00bbb22 3905 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3906 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3907
6468f31c
LMI
39082011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3909
49080b10
LMI
3910 * search.c (Fre_search_backward): Mention `case-fold-search' in
3911 all the re_search_* functions (bug#8138).
3912
6468f31c
LMI
3913 * keyboard.c (Fopen_dribble_file): Document when the file is
3914 closed (bug#8056).
3915
c965adc5
EZ
39162011-07-14 Eli Zaretskii <eliz@gnu.org>
3917
df9733bf
EZ
3918 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3919 bidi_cache_idx.
3920
0bb23927
EZ
3921 Support bidi reordering of display and overlay strings.
3922 * xdisp.c (compute_display_string_pos)
3923 (compute_display_string_end): Accept additional argument STRING.
3924 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3925 (reseat_to_string): Initialize bidi_it->string.s and
3926 bidi_it->string.schars.
3927 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3928 NULL (avoids a crash in bidi_paragraph_init).
3929 Initialize itb.string.lstring.
0bb23927
EZ
3930 (init_iterator): Call bidi_init_it only of a valid
3931 buffer position was specified. Initialize paragraph_embedding to
3932 L2R.
3933 (reseat_to_string): Initialize the bidi iterator.
3934 (display_string): If we need to ignore text properties of
3935 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3936 original value of -1 will not work with bidi.)
3937 (compute_display_string_pos): First arg is now struct
3938 `text_pos *'; all callers changed. Support display properties on
3939 Lisp strings.
3940 (compute_display_string_end): Support display properties on Lisp
3941 strings.
3942 (init_iterator, reseat_1, reseat_to_string): Initialize the
3943 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3944 when iterating on a string not from display properties).
640c8776
SM
3945 (compute_display_string_pos, compute_display_string_end):
3946 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3947 arrow keys.
3948 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3949 base_level_stop; instead, set base_level_stop to BEGV.
3950 Fixes crashes in vertical-motion.
0bb23927
EZ
3951 (next_element_from_buffer): Improve commentary for when
3952 the iterator is before prev_stop.
3953 (init_iterator): Initialize bidi_p from the default value of
3954 bidi-display-reordering, not from buffer-local value. Use the
3955 buffer-local value only if initializing for buffer iteration.
3956 (handle_invisible_prop): Support invisible properties on strings
3957 that are being bidi-reordered.
3958 (set_iterator_to_next): Support bidi reordering of C strings and
3959 Lisp strings.
3960 (next_element_from_string): Support bidi reordering of Lisp
3961 strings.
3962 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3963 (display_string): Support display of R2L glyph rows.
3964 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3965 (init_iterator): Don't initialize it->bidi_p for strings
3966 here.
3967 (reseat_to_string): Initialize it->bidi_p for strings here.
3968 (next_element_from_string, next_element_from_c_string)
3969 (next_element_from_buffer): Add xassert's for correspondence
3970 between IT's object being iterated and it->bidi_it.string
3971 structure.
3972 (face_before_or_after_it_pos): Support bidi iteration.
3973 (next_element_from_c_string): Handle the case of the first string
3974 character that is not the first one in the visual order.
3975 (get_visually_first_element): New function, refactored from common
3976 parts of next_element_from_buffer, next_element_from_string, and
3977 next_element_from_c_string.
3978 (tool_bar_lines_needed, redisplay_tool_bar)
3979 (display_menu_bar): Force left-to-right direction. Add a FIXME
3980 comment for making that be controlled by a user option.
3981 (push_it, pop_it): Save and restore the state of the
3982 bidi iterator. Save and restore the bidi_p flag.
3983 (pop_it): Iterate out of display property for string iteration as
3984 well.
3985 (iterate_out_of_display_property): Support iteration over strings.
3986 (handle_single_display_spec): Set up it->bidi_it for iteration
3987 over a display string, and call bidi_init_it.
3988 (handle_single_display_spec, next_overlay_string)
3989 (get_overlay_strings_1, push_display_prop): Set up the bidi
3990 iterator for displaying display or overlay strings.
3991 (forward_to_next_line_start): Don't use the shortcut if
3992 bidi-iterating.
3993 (back_to_previous_visible_line_start): If handle_display_prop
3994 pushed the iterator stack, restore the internal state of the bidi
3995 iterator by calling bidi_pop_it same number of times.
3996 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3997 and we are bidi-iterating, don't decrement the iterator position;
3998 instead, set the first_elt flag in the bidi iterator, to produce
3999 the same effect.
4000 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4001 (push_display_prop): xassert that we are iterating a buffer.
4002 (push_it, pop_it): Save and restore paragraph_embedding member.
4003 (handle_single_display_spec, next_overlay_string)
4004 (get_overlay_strings_1, reseat_1, reseat_to_string)
4005 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4006 correctly. Don't assume unibyte strings are not bidi-reordered.
4007 (compute_display_string_pos)
4008 (compute_display_string_end): Fix handling the case of C string.
4009 (push_it, pop_it): Save and restore from_disp_prop_p.
4010 (handle_single_display_spec, push_display_prop): Set the
4011 from_disp_prop_p flag.
4012 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4013 (pop_it): Call iterate_out_of_display_property only if we are
4014 popping after iteration over a string that came from a display
4015 property. Fix a typo in popping stretch info. Add an assertion
4016 for verifying that the iterator position is in sync with the bidi
4017 iterator.
4018 (handle_single_display_spec, get_overlay_strings_1)
4019 (push_display_prop): Fix initialization of paragraph direction for
4020 string when that of the parent object is not yet determined.
4021 (reseat_1): Call bidi_init_it to resync the bidi
4022 iterator with IT's position. (Bug#7616)
4023 (find_row_edges): If ROW->start.pos gives position
4024 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4025 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4026 Reset the from_disp_prop_p flag.
4027 (SAVE_IT, RESTORE_IT): New macros.
4028 (pos_visible_p, face_before_or_after_it_pos)
4029 (back_to_previous_visible_line_start)
4030 (move_it_in_display_line_to, move_it_in_display_line)
4031 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4032 (try_scrolling, redisplay_window, display_line): Use them when
4033 saving a temporary copy of the iterator and restoring it back.
4034 (back_to_previous_visible_line_start, reseat_1)
4035 (init_iterator): Empty the bidi cache "stack".
4036 (move_it_in_display_line_to): If iterator ended up at
4037 EOL, but we never saw any buffer positions smaller than
4038 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4039 motion in bidi-reordered lines.
4040 (move_it_in_display_line_to): Record prev_method and prev_pos
4041 immediately before the call to set_iterator_to_next. Fixes cursor
4042 motion in bidi-reordered lines with stretch glyphs and strings
4043 displayed in margins. (Bug#8133) (Bug#8867)
4044 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4045 TO_CHARPOS.
640c8776
SM
4046 (pos_visible_p): Support positions in bidi-reordered lines.
4047 Save and restore bidi cache.
0bb23927
EZ
4048
4049 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4050 (bidi_paragraph_info): Delete unused struct.
4051 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4052 (bidi_cache_start): New variable.
4053 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4054 to zero.
4055 (bidi_cache_fetch_state, bidi_cache_search)
4056 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4057 (bidi_cache_find, bidi_peek_at_next_level)
4058 (bidi_level_of_next_char, bidi_find_other_level_edge)
4059 (bidi_move_to_visually_next): Compare cache index with
4060 bidi_cache_start rather than with zero.
4061 (bidi_fetch_char): Accept new argument STRING; all callers
4062 changed. Support iteration over a string. Support strings with
4063 display properties. Support unibyte strings. Fix the type of
4064 `len' according to what STRING_CHAR_AND_LENGTH expects.
4065 (bidi_paragraph_init, bidi_resolve_explicit_1)
4066 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4067 (bidi_level_of_next_char, bidi_move_to_visually_next):
4068 Support iteration over a string.
0bb23927
EZ
4069 (bidi_set_sor_type, bidi_resolve_explicit_1)
4070 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4071 can now be zero (for strings); special values 0 and -1 were
4072 changed to -1 and -2, respectively.
4073 (bidi_char_at_pos): New function.
4074 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4075 Call it instead of FETCH_MULTIBYTE_CHAR.
4076 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4077 initialized to valid values.
4078 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4079 values.
4080 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4081 the test for valid cached positions. Fix the logic for looking up
4082 the sentinel state in the cache. GCPRO the Lisp string we are
4083 iterating.
4084 (bidi_push_it, bidi_pop_it): New functions.
4085 (bidi_initialize): Initialize the bidi cache start stack pointer.
4086 (bidi_cache_ensure_space): New function, refactored from part of
4087 bidi_cache_iterator_state. Don't assume the required size is just
4088 one BIDI_CACHE_CHUNK away.
4089 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4090 (bidi_count_bytes, bidi_char_at_pos): New functions.
4091 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4092 always valid if bidi_cache_idx is valid.
4093 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4094 is valid if it's going to be used.
4095 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4096 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4097 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4098 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4099 (bidi_find_other_level_edge, bidi_cache_start_stack):
4100 All variables related to cache indices are now EMACS_INT.
c965adc5 4101
0bb23927
EZ
4102 * dispextern.h (struct bidi_string_data): New structure.
4103 (struct bidi_it): New member `string'. Make flag members be 1-bit
4104 fields, and put them last in the struct.
640c8776
SM
4105 (compute_display_string_pos, compute_display_string_end):
4106 Update prototypes.
0bb23927
EZ
4107 (bidi_push_it, bidi_pop_it): Add prototypes.
4108 (struct iterator_stack_entry): New members bidi_p,
4109 paragraph_embedding, and from_disp_prop_p.
4110 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4111 (bidi_shelve_cache, bidi_unshelve_cache):
4112 Declare prototypes.
0bb23927
EZ
4113
4114 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4115 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4116 and vector-like objects.
4117
4118 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4119 cache around display iteration.
4120
4121 * window.c (Fwindow_end, window_scroll_pixel_based)
4122 (displayed_window_lines, Frecenter): Save and restore the bidi
4123 cache around display iteration.
4124
3bbd2265
LMI
41252011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4126
4127 * editfns.c (Fdelete_region): Clarify the use of the named
4128 parameters (bug#6788).
4129
adc47434
MR
41302011-07-14 Martin Rudalics <rudalics@gmx.at>
4131
4132 * indent.c (Fvertical_motion): Set and restore w->pointm when
4133 saving and restoring the window's buffer (Bug#9006).
4134
837c31f8
LMI
41352011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4136
4137 * editfns.c (Fstring_to_char): Clarify just what is returned
4138 (bug#6576). Text by Eli Zaretskii.
4139
ac389d0c
JB
41402011-07-13 Juanma Barranquero <lekktu@gmail.com>
4141
4142 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4143
0be0ce47
EZ
41442011-07-13 Eli Zaretskii <eliz@gnu.org>
4145
4146 * buffer.c (mmap_find): Fix a typo.
4147
cd18e7e3
JB
41482011-07-13 Johan Bockgård <bojohan@gnu.org>
4149
4150 Fix execution of x selection hooks.
4151 * xselect.c (Qx_lost_selection_functions)
4152 (Qx_sent_selection_functions): New vars.
4153 (syms_of_xselect): DEFSYM them.
4154 (x_handle_selection_request): Pass Qx_sent_selection_functions
4155 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4156 (x_handle_selection_clear,x_clear_frame_selections):
4157 Pass Qx_lost_selection_functions rather than
4158 Vx_lost_selection_functions to Frun_hook_with_args.
4159
47ea7f44
PE
41602011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4161
ac389d0c 4162 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4163 The old code sometimes used this field without initializing it.
4164
47ea7f44
PE
4165 * alloc.c (gc_sweep): Don't read past end of array.
4166 In theory, the old code could also have corrupted Emacs internals,
4167 though it'd be very unlikely.
4168
bc985c87
AS
41692011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4170
4171 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4172 argument. (Bug#4026)
bc985c87 4173
0cf34688
LMI
41742011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4175
b3dadd76
LMI
4176 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4177 key" (bug#4257).
4178
0cf34688
LMI
4179 * window.c (Fset_window_start): Doc fix (bug#4199).
4180 (Fset_window_hscroll): Ditto.
4181
270768cd
PE
41822011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4183
077e3dda 4184 Fix minor new problems caught by GCC 4.6.1.
270768cd 4185 * term.c (init_tty): Remove unused local.
490011a6 4186 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4187 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4188 not used otherwise.
270768cd 4189
b1f58454
CY
41902011-07-12 Chong Yidong <cyd@stupidchicken.com>
4191
4192 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4193
22b9578d
LMI
41942011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4195
6e70ab07
LMI
4196 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4197 are the mini-buffer and the echo area (bug#3320).
4198
22b9578d
LMI
4199 * term.c (init_tty): Remove support for supdup, c10 and perq
4200 terminals, which are no longer supported (bug#1482).
4201
8974cc9f
JB
42022011-07-10 Johan Bockgård <bojohan@gnu.org>
4203
4204 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4205
a560d974
JD
42062011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4207
4208 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4209 for non-popups (Bug#3642).
4210
1dae0f0a
AS
42112011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4212
268c2c36 4213 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4214 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4215 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4216 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4217 * data.c (fmod): Likewise.
4218 * dispnew.c (swap_glyphs_in_rows): Likewise.
4219 * emacs.c (memory_warning_signal): Likewise.
4220 * floatfns.c (float_error): Likewise.
4221 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4222 (otf_open, font_otf_capability, generate_otf_features)
4223 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4224 Likewise.
4225 * image.c (pbm_read_file): Likewise.
4226 * indent.c (string_display_width): Likewise.
4227 * intervals.c (check_for_interval, search_for_interval)
4228 (inc_interval_count, count_intervals, root_interval)
4229 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4230 * lread.c (defalias): Likewise.
268c2c36 4231 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4232 * regex.c (set_image_of_range_1, set_image_of_range)
4233 (regex_grow_registers): Likewise.
4234 * sysdep.c (strerror): Likewise.
4235 * termcap.c (valid_filename_p, tprint, main): Likewise.
4236 * tparam.c (main): Likewise.
4237 * unexhp9k800.c (run_time_remap, save_data_space)
4238 (update_file_ptrs, read_header, write_header, calculate_checksum)
4239 (copy_file, copy_rest, display_header): Likewise.
4240 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4241 Likewise.
4242 * xdisp.c (check_it): Likewise.
4243 * xfaces.c (register_color, unregister_color, unregister_colors):
4244 Likewise.
4245 * xfns.c (print_fontset_result): Likewise.
4246 * xrdb.c (member, fatal, main): Likewise.
4247
99033785
PE
42482011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4249
4250 Fix minor problems found by static checking (Bug#9031).
4251 * chartab.c (char_table_set_range, map_sub_char_table):
4252 Remove unused locals.
4253 (uniprop_table): Now static.
4254 * composite.c (_work_char): Remove unused static var.
4255
9cb2ac56
JB
42562011-07-09 Juanma Barranquero <lekktu@gmail.com>
4257
4258 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4259
f25661f0
JD
42602011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4261
4262 * gtkutil.c (qttip_cb): Remove code without function.
4263
8278c4fe
EZ
42642011-07-09 Eli Zaretskii <eliz@gnu.org>
4265
4266 * w32.c (pthread_sigmask): New stub.
4267
1692ae2d 42682011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4269
8a6ebd58 4270 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4271 sigprocmask is portable only for single-threaded applications, and
4272 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4273 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4274 (LIBES): Use it.
4275 * callproc.c (Fcall_process):
4276 * process.c (create_process):
4277 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4278 Use pthread_sigmask, not sigprocmask.
123403e4 4279
1b854618
JD
42802011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4281
4282 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4283 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4284 wrong (Bug#8591).
4285
3fe4b549
JD
42862011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4287
0ce7e563
JD
4288 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4289 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4290 (xg_hide_tooltip): Fix comment.
4291
3fe4b549
JD
4292 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4293 in registerServicesMenuSendTypes.
4294 (validRequestorForSendType): Don't check ns_return_types.
4295
4296 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4297 ns_return_type.
4298
5df75e47
JR
42992011-07-08 Jason Rumney <jasonr@gnu.org>
4300
22610910
JR
4301 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4302 SH_SHOW for hidden windows (Bug#5482).
4303
5df75e47
JR
4304 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4305 frame struct members of non-existent frames (Bug#6284).
4306
699c10bd
JD
43072011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4308
4393663b
JD
4309 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4310 variable firstTime not needed on OSX >= 10.6.
4311 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4312 >= 10.5. Use setKnobProportion, setDoubleValue.
4313
4314 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4315 (MAC_OS_X_VERSION_10_5): Define if not defined.
4316 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4317 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4318 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4319
4320 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4321 cString and lossyCString on OSX >= 10.4
4322
58179cce 4323 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4324 sizeToFit on OSX >= 10.2.
4325
4326 * nsimage.m (allocInitFromFile): Don't use deprecated method
4327 bestRepresentationForDevice on OSX >= 10.6.
4328
4329 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4330 to avoid warning.
4331
4332 * emacs.c: Declare unexec_init_emacs_zone.
4333
a63e0781
JD
4334 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4335
699c10bd
JD
4336 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4337
4338 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4339 on svcsMenu (Bug#8842).
4340
4341 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4342 ns_return_types.
4343 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4344
4345 * nsterm.m (QUTF8_STRING): Declare.
4346 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4347 (validRequestorForSendType): Return type is (id).
4348 Change indexOfObjectIdenticalTo to indexOfObject.
4349 Check if we have local selection before returning self (Bug#8842).
4350 (writeSelectionToPasteboard): Put local selection into paste board
4351 if we have a local selection (Bug#8842).
4352 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4353
4354 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4355 (ns_get_local_selection): Declare.
4356
54e10184
LMI
43572011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4358
9888ff71
LMI
4359 * keymap.c (describe_map_tree): Don't insert a double newline at
4360 the end of the buffer (bug#1169) and return whether we inserted
4361 something.
4362
54e10184
LMI
4363 * callint.c (Fcall_interactively): Change "reading args" to
4364 "providing args" to try to clarify what it does (bug#1010).
4365
15fa4783
KH
43662011-07-07 Kenichi Handa <handa@m17n.org>
4367
4368 * composite.c (composition_compute_stop_pos): Ignore a static
4369 composition starting before CHARPOS (Bug#8915).
4370
4371 * xdisp.c (handle_composition_prop): Likewise.
4372
a8815b00
EZ
43732011-07-07 Eli Zaretskii <eliz@gnu.org>
4374
4375 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4376 (Bug#9015)
4377
ef7b981d 43782011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4379
4380 * character.h (unicode_category_t): New enum type.
4381
4382 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4383 (Qchar_code_property_table): New variable.
4384 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4385 (UNIPROP_COMPRESSED_FORM_P): New macros.
4386 (char_table_ascii): Uncompress the compressed values.
4387 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4388 Uncompress the compressed values.
ac389d0c 4389 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4390 (char_table_ref_and_range): Uncompress the compressed values.
4391 (sub_char_table_set): New arg is_uniprop. Callers changed.
4392 Uncompress the compressed values.
4393 (sub_char_table_set_range): Args changed. Callers changed.
4394 (char_table_set_range): Adjuted for the above change.
4395 (map_sub_char_table): Delete args default_val and parent. Add arg
4396 top. Give decoded values to a Lisp function.
640c8776 4397 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4398 values to a Lisp function. Gcpro more variables.
4399 (uniprop_table_uncompress)
4400 (uniprop_decode_value_run_length): New functions.
4401 (uniprop_decoder, uniprop_decoder_count): New variables.
4402 (uniprop_get_decoder, uniprop_encode_value_character)
4403 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4404 New functions.
4405 (uniprop_encoder, uniprop_encoder_count): New variables.
4406 (uniprop_get_encoder, uniprop_table)
4407 (Funicode_property_table_internal, Fget_unicode_property_internal)
4408 (Fput_unicode_property_internal): New functions.
4409 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4410 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4411 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4412 char-code-property-alist.
4413
640c8776 4414 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4415 Vunicode_category_table.
4416
640c8776 4417 * font.c (font_range): Adjust for the change of
c805dec0
KH
4418 Vunicode_category_table.
4419
76b397fb
DN
44202011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4421
4422 * m/iris4d.h: Remove file, move contents ...
4423 * s/irix6-5.h: ... here.
4424
22b4128e
PE
44252011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4426
4427 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4428 * alloc.c (mark_buffer):
4429 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4430 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4431 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4432 This isn't true in general, and it's particularly not true
4433 if Emacs is configured with --with-wide-int.
4434 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4435 New macros, used in the buffer.c change.
4436
869795d6
JD
44372011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4438
4439 * xsettings.c: Use both GConf and GSettings if both are available.
4440 (store_config_changed_event): Add comment.
4441 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4442 (store_tool_bar_style_changed): New functions.
5e617bc2 4443 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4444 (struct xsettings): Move font inside HAVE_XFT.
4445 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4446 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4447 Move inside HAVE_XFT.
640c8776 4448 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4449 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4450 also.
4451 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4452 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4453 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4454 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4455 (parse_settings): Move check for font inside HAVE_XFT.
4456 (read_settings, apply_xft_settings): Add comment.
4457 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4458 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4459 call store_font_name_changed.
4460 (xft_settings_event): Add comment.
4461 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4462 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4463 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4464 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4465 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4466 (xsettings_get_system_font, xsettings_get_system_normal_font):
4467 Add comment.
869795d6 4468
d8ed26bd
PE
44692011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4470
4471 Random fixes. E.g., (random) never returned negative values.
4472 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4473 subseconds part to the entropy, as that's a bit more random.
4474 Prefer signed to unsigned, since the signedness doesn't matter and
4475 in general we prefer signed. When given a limit, use a
4476 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4477 latter isn't right if USE_2_TAGS_FOR_INTS.
4478 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4479 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4480
cabf1cac
SM
44812011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4482
4483 * textprop.c (text_property_stickiness):
4484 Obey Vtext_property_default_nonsticky.
4485 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4486 * w32fns.c (syms_of_w32fns):
4487 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4488
6e9b2be9
PE
44892011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4490
4491 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4492 This is more efficient than Ffile_directory_p and avoids a minor race.
4493
90186c68
LMI
44942011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4495
7c301272
LMI
4496 * buffer.c (Foverlay_put): Say what the return value is
4497 (bug#7835).
4498
c4f2d8d4
LMI
4499 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4500 is a directory before asking whether to use the file name
4501 (bug#7564).
ad637907
LMI
4502 (barf_or_query_if_file_exists): Make the "File is a directory"
4503 error be more correct.
c4f2d8d4 4504
90186c68
LMI
4505 * fns.c (Frequire): Remove the mention of the .gz files, since
4506 that's installation-specific, but keep the mention of
4507 `get-load-suffixes'.
4508
da64016e
PE
45092011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4510
4511 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4512 Report string overflow if the output is too long.
4513
7d47b580
JB
45142011-07-04 Juanma Barranquero <lekktu@gmail.com>
4515
a555cb87
JB
4516 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4517 (syms_of_gnutls): Remove duplicate DEFSYM for
4518 Qgnutls_bootprop_verify_hostname_error, an error for
4519 Qgnutls_bootprop_verify_error (which is no longer used).
4520
7d47b580
JB
4521 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4522 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4523 Also (re)move comments that are misplaced or no longer relevant.
4524
1e49bfab
LMI
45252011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4526
4527 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4528
1485f4c0
CY
45292011-07-03 Chong Yidong <cyd@stupidchicken.com>
4530
4531 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4532 and background color parameters if they have been changed.
4533
a9ab721e
LMI
45342011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4535
4536 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4537
cf7cff57
PE
45382011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4539
2e13213d
PE
4540 * xsettings.c (SYSTEM_FONT): Define only when used.
4541 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4542
cf7cff57
PE
4543 * keymap.c (access_keymap_1): Now static.
4544
7a8e04f7
CY
45452011-07-02 Chong Yidong <cyd@stupidchicken.com>
4546
4547 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4548 leave any prefix arg for the up event (Bug#1586).
4549
61352f62
LMI
45502011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4551
69bb1ef7
LMI
4552 * lread.c (syms_of_lread): Mention single symbols defined by
4553 `defvar' or `defconst' (bug#7154).
4554
61352f62 4555 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4556 (Frequire): Mention get-load-suffixes.
61352f62 4557
28545e04
MR
45582011-07-02 Martin Rudalics <rudalics@gmx.at>
4559
4560 * window.h (window): Remove clone_number slot.
4561 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4562 Remove.
4563 (make_parent_window, make_window, saved_window)
4564 (Fset_window_configuration, save_window_save): Don't deal with
4565 clone numbers.
4566 * buffer.c (Qclone_number): Remove declaration.
4567 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4568
3349e122
SM
45692011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4570
4571 Add multiple inheritance to keymaps.
4572 * keymap.c (Fmake_composed_keymap): New function.
4573 (Fset_keymap_parent): Simplify.
4574 (fix_submap_inheritance): Remove.
4575 (access_keymap_1): New function extracted from access_keymap to handle
4576 embedded parents and handle lists of maps.
4577 (access_keymap): Use it.
4578 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4579 (Fcopy_keymap): Handle embedded parents.
4580 (Fcommand_remapping, define_as_prefix): Simplify.
4581 (Fkey_binding): Simplify.
4582 (syms_of_keymap): Move minibuffer-local-completion-map,
4583 minibuffer-local-filename-completion-map,
4584 minibuffer-local-must-match-map, and
4585 minibuffer-local-filename-must-match-map to Elisp.
4586 (syms_of_keymap): Defsubr make-composed-keymap.
4587 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4588 (parse_menu_item): Trivial simplification.
4589
3279eb87
GM
45902011-07-01 Glenn Morris <rgm@gnu.org>
4591
4592 * Makefile.in (SETTINGS_LIBS): Fix typo.
4593
4550efdf
KI
45942011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4595
4596 * coding.c (Fencode_coding_string): Record the last coding system
4597 used, as the function doc string says (bug#8738).
4598
0949d2b6
JD
45992011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4600
4601 * xsettings.c (store_monospaced_changed): Take new font as arg and
4602 check for change against current_mono_font.
4603 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4604 (emacs_settings_constructor, emacs_settings_get_property)
4605 (emacs_settings_set_property, emacs_settings_class_init)
4606 (emacs_settings_init, gsettings_obj): Remove.
4607 (something_changedCB): New function for HAVE_GSETTINGS.
4608 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4609 with value as argument.
4610 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4611 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4612 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4613 "changed".
4614
4615 * xgselect.c: Add defined (HAVE_GSETTINGS).
4616 (xgselect_initialize): Ditto.
4617
4618 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4619 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4620 xg_select.
4621
bbc6b304
PE
46222011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4623
4624 * eval.c (struct backtrace): Simplify and port the data structure.
4625 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4626 signed bit field, as this assumption is not portable and it makes
4627 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4628 "char debug_on_exit : 1" as this is not portable either; instead,
4629 use the portable "unsigned int debug_on_exit : 1". Remove unused
4630 member evalargs. Remove obsolete comments about cc bombing out.
4631
9851bfc5
JD
46322011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4633
51bb811f 4634 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4635 Let HAVE_GSETTINGS override HAVE_GCONF.
4636 (store_monospaced_changed): New function.
4637 (EMACS_SETTINGS): A new type derived from GObject to handle
4638 GSettings notifications.
4639 (emacs_settings_constructor, emacs_settings_get_property)
4640 (emacs_settings_set_property, emacs_settings_class_init):
4641 New functions.
4642 (gsettings_client, gsettings_obj): New variables.
4643 (GSETTINGS_SCHEMA): New define.
4644 (something_changedCB): Call store_monospaced_changed.
4645 (init_gsettings): New function.
4646 (xsettings_initialize): Call init_gsettings.
4647 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4648 to NULL.
4649
640c8776 4650 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4651 GCONF_CFLAGS/LIBS.
4652
5386012d
MR
46532011-06-29 Martin Rudalics <rudalics@gmx.at>
4654
4655 * window.c (resize_root_window, grow_mini_window)
4656 (shrink_mini_window): Rename Qresize_root_window to
4657 Qwindow_resize_root_window and Qresize_root_window_vertically to
4658 Qwindow_resize_root_window_vertically.
4659
f13e0b08
PE
46602011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4661
4662 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4663
94515237
JB
46642011-06-27 Juanma Barranquero <lekktu@gmail.com>
4665
4666 * makefile.w32-in: Redesign dependencies so they reflect more
4667 clearly which files are directly included by each source file,
4668 and not through other includes.
4669
e43b6e43
MR
46702011-06-27 Martin Rudalics <rudalics@gmx.at>
4671
4672 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4673 (sort_overlays, overlay_strings): When an overlay's clone number
4674 matches the window's clone number process the overlay even if
4675 the overlay's window property doesn't match the current window.
4676
d68443dc
MR
4677 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4678 (Fwindow_hchild): Rename to Fwindow_left_child.
4679 (Fwindow_next): Rename to Fwindow_next_sibling.
4680 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4681 (resize_window_check): Rename to window_resize_check.
4682 (resize_window_apply): Rename to window_resize_apply.
4683 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4684 (Fdelete_other_windows_internal, resize_frame_windows)
4685 (Fsplit_window_internal, Fdelete_window_internal)
4686 (grow_mini_window, shrink_mini_window)
4687 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4688
c7e73be5
JD
46892011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4690
4691 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4692 (emacs_fixed_set_min_size): Remove.
4693 (emacs_fixed_new): Take frame as argument.
4694
4695 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4696 (_EmacsFixedPrivate): Remove minwidth/height.
4697 Add struct frame *f.
4698 (emacs_fixed_init): Initialize priv->f.
4699 (get_parent_class, emacs_fixed_set_min_size): Remove.
4700 (emacs_fixed_new): Set priv->f to argument.
4701 (emacs_fixed_get_preferred_width)
4702 (emacs_fixed_get_preferred_height): Use min_width/height from
4703 frames size_hint to set minimum and natural (Bug#8919).
4704 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4705 and use min_width/height from frames size_hint to set
4706 min_width/height (Bug#8919).
4707
4708 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4709 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4710 Fix indentation.
c7e73be5 4711
cf99dcf8
EZ
47122011-06-26 Eli Zaretskii <eliz@gnu.org>
4713
4714 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4715 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4716 called at ZV.
4717
029529ac
CY
47182011-06-26 Chong Yidong <cyd@stupidchicken.com>
4719
4720 * process.c (wait_reading_process_output): Bypass select if
4721 waiting for a cell while ignoring keyboard input, and input is
4722 pending. Suggested by Jan Djärv (Bug#8869).
4723
7a7ef429
PE
47242011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4725
4726 Use gnulib's dup2 module instead of rolling our own.
4727 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4728
11fdef7d 47292011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4730
4731 * dispnew.c (scrolling_window): Before scrolling, turn off a
4732 mouse-highlight in the window being scrolled.
4733
cd3520a4
JB
47342011-06-24 Juanma Barranquero <lekktu@gmail.com>
4735
4736 Move DEFSYM to lisp.h and use everywhere.
4737
4738 * character.h (DEFSYM): Move declaration...
4739 * lisp.h (DEFSYM): ...here.
4740
4741 * gnutls.c:
4742 * minibuf.c:
4743 * w32menu.c:
4744 * w32proc.c:
4745 * w32select.c: Don't include character.h.
4746
4747 * alloc.c (syms_of_alloc):
4748 * buffer.c (syms_of_buffer):
4749 * bytecode.c (syms_of_bytecode):
4750 * callint.c (syms_of_callint):
4751 * casefiddle.c (syms_of_casefiddle):
4752 * casetab.c (init_casetab_once):
4753 * category.c (init_category_once, syms_of_category):
4754 * ccl.c (syms_of_ccl):
4755 * cmds.c (syms_of_cmds):
4756 * composite.c (syms_of_composite):
4757 * dbusbind.c (syms_of_dbusbind):
4758 * dired.c (syms_of_dired):
4759 * dispnew.c (syms_of_display):
4760 * doc.c (syms_of_doc):
4761 * editfns.c (syms_of_editfns):
4762 * emacs.c (syms_of_emacs):
4763 * eval.c (syms_of_eval):
4764 * fileio.c (syms_of_fileio):
4765 * fns.c (syms_of_fns):
4766 * frame.c (syms_of_frame):
4767 * fringe.c (syms_of_fringe):
4768 * insdel.c (syms_of_insdel):
4769 * keymap.c (syms_of_keymap):
4770 * lread.c (init_obarray, syms_of_lread):
4771 * macros.c (syms_of_macros):
4772 * msdos.c (syms_of_msdos):
4773 * print.c (syms_of_print):
4774 * process.c (syms_of_process):
4775 * search.c (syms_of_search):
4776 * sound.c (syms_of_sound):
4777 * syntax.c (init_syntax_once, syms_of_syntax):
4778 * terminal.c (syms_of_terminal):
4779 * textprop.c (syms_of_textprop):
4780 * undo.c (syms_of_undo):
4781 * w32.c (globals_of_w32):
4782 * window.c (syms_of_window):
4783 * xdisp.c (syms_of_xdisp):
4784 * xfaces.c (syms_of_xfaces):
4785 * xfns.c (syms_of_xfns):
4786 * xmenu.c (syms_of_xmenu):
4787 * xsettings.c (syms_of_xsettings):
4788 * xterm.c (syms_of_xterm): Use DEFSYM.
4789
4228cf16
TZ
47902011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4791
cd3520a4 4792 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4793
7fcccf1e
PE
47942011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4795
7efb4e0e
PE
4796 Integer and buffer overflow fixes (Bug#8873).
4797
ff5844ad
PE
4798 * print.c (printchar, strout): Check for string overflow.
4799 (PRINTPREPARE, printchar, strout):
4800 Don't set size unless allocation succeeds.
4801
90532f02
PE
4802 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4803 for sizes. Check for string overflow more accurately.
4804 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4805
6d84508d
PE
4806 * macros.c: Integer and buffer overflow fixes.
4807 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4808 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4809 Use ptrdiff_t, not int, for sizes.
4810 Don't increment bufsize until after realloc succeeds.
4811 Check for size-calculation overflow.
4812 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4813
437b2cb4
PE
4814 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4815
8b9ac8b4
PE
4816 * lread.c: Integer overflow fixes.
4817 (read_integer): Radix is now EMACS_INT, not int,
4818 to improve quality of diagnostics for out-of-range radices.
4819 Calculate buffer size correctly for out-of-range radices.
4820 (read1): Check for integer overflow in radices, and in
4821 read-circle numbers.
82cb60d3
PE
4822 (read_escape): Avoid int overflow.
4823 (Fload, openp, read_buffer_size, read1)
4824 (substitute_object_recurse, read_vector, read_list, map_obarray):
4825 Use ptrdiff_t, not int, for sizes.
4826 (read1): Use EMACS_INT, not int, for sizes.
20270765 4827 Check for size overflow.
8b9ac8b4 4828
7fcccf1e
PE
4829 * image.c (cache_image): Check for size arithmetic overflow.
4830
bfbbd7e7
PE
4831 * lread.c: Integer overflow issues.
4832 (saved_doc_string_size, saved_doc_string_length)
4833 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4834 Now ptrdiff_t, not int.
4835 (read1): Don't assume doc string length fits in int. Check for
4836 out-of-range doc string lengths.
4837 (read_list): Don't assume file position fits in int.
39019e54 4838 (read_escape): Check for hex character overflow.
bfbbd7e7 4839
4e323265
LL
48402011-06-22 Leo Liu <sdl.web@gmail.com>
4841
4842 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4843 Move to minibuffer.el.
4844
85fece3e
PE
48452011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4846
20b84ce9 4847 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4848 The following patches are for when GLYPH_DEBUG && !XASSERT.
4849 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4850 * dispnew.c (flush_stdout):
4851 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4852 Mark as externally visible.
4853 * dispnew.c (check_window_matrix_pointers): Now static.
4854 * dispnew.c (window_to_frame_vpos):
4855 * xfns.c (unwind_create_frame):
4856 * xterm.c (x_check_font): Remove unused local.
4857 * scroll.c (CHECK_BOUNDS):
4858 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4859 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4860 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4861 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4862 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4863 Now static.
4864 (debug_method_add): Use va_list and vsprintf rather than relying
4865 on undefined behavior with wrong number of arguments.
4866 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4867 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4868 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4869 since we're not interested in debugging glyphs with old libraries.
4870 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4871 GCC 4.6.0's static checking.
4872
0766b489
PE
48732011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4874
31fd4b32
PE
4875 Integer overflow and signedness fixes (Bug#8873).
4876 A few related buffer overrun fixes, too.
4877
b79e8648
PE
4878 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4879
0766b489
PE
4880 * dispextern.h (struct face.stipple):
4881 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4882 (x_bitmap_mask, x_allocate_bitmap_record)
4883 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4884 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4885 (x_create_bitmap_from_xpm_data):
4886 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4887 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4888 (.bitmaps_last):
4889 * xfaces.c (load_pixmap):
4890 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4891 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4892 (.bitmaps_last, struct x_output.icon_bitmap):
4893 Use ptrdiff_t, not int, for bitmap indexes.
4894 (x_allocate_bitmap_record): Check for size overflow.
4895 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4896
b081724f
PE
4897 Use ptrdiff_t, not int, for overlay counts.
4898 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4899 * editfns.c (overlays_around, get_pos_property):
4900 * textprop.c (get_char_property_and_overlay):
4901 * xdisp.c (next_overlay_change, note_mouse_highlight):
4902 * xfaces.c (face_at_buffer_position):
21514da7
PE
4903 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4904 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4905 (Fnext_overlay_change, Fprevious_overlay_change)
4906 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4907 Use ptrdiff_t, not int, for sizes.
21514da7 4908 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4909
3de73e5e
PE
4910 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4911
2606c57b
PE
4912 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4913 (x_session_initialize): Do not assume string length fits in int.
4914
aaafe47a
PE
4915 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4916 This is unlikely, but can occur if DPI is outlandish.
4917
2674ddc8 4918 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4919 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4920
28154962
PE
4921 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4922 * xrdb.c (magic_file_p, search_magic_path):
4923 Omit last arg SUFFIX; it was always 0. All callers changed.
4924 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4925
7de51af5
PE
4926 * xfont.c (xfont_match): Avoid need for strlen.
4927
25ed6cc3
PE
4928 * xfns.c: Don't assume strlen fits in int.
4929 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4930
4eab31dd
PE
4931 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4932 not unsigned long, as we prefer signed integers. All callers changed.
4933 Detect integer overflow in repeat count.
4934 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4935 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4936
171e2a58
PE
4937 * termcap.c: Don't assume sizes fit in int and never overflow.
4938 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4939 (gobble_line): Check for size-calculation overflow.
4940
ad39faca 4941 * minibuf.c (Fread_buffer):
6e5bb2dc 4942 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4943 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4944 Don't assume string length fits in int.
4945
52c61c22 4946 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4947 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4948
b5b8c9e5
PE
4949 * font.c: Don't assume string length fits in int.
4950 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4951 Use ptrdiff_t, not int.
ccd6111c
PE
4952 (font_intern_prop): Don't assume string length fits in int.
4953 Don't assume integer property fits in fixnum.
4954 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4955
882f0d81 4956 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4957 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4958 Reformulate so as not to need the command string.
4959 Invoke gzip -cd rather than gunzip, as it's more portable.
4960 (lock_info_type, lock_file_1, lock_file):
4961 Don't assume pid_t and time_t fit in unsigned long.
4962 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4963 (current_lock_owner): Prefer signed type for sizes.
4964 Use memcpy, not strncpy, where memcpy is what is really wanted.
4965 Don't assume (via atoi) that time_t and pid_t fit in int.
4966 Check for time_t and/or pid_t out of range, e.g., via a network share.
4967 Don't alloca where an auto var works fine.
4968
93f4cf88
PE
4969 * fileio.c: Fix some integer overflow issues.
4970 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4971 Don't assume string length fits in int.
4972 (directory_file_name): Don't assume string length fits in long.
4973 (make_temp_name): Don't assume pid fits in int, or that its print
4974 length is less than 20.
4975
f3e92b69
PE
4976 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4977
1bfdaf10
PE
4978 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4979
35016e9a
PE
4980 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4981
3d1e65a1
PE
4982 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4983 We prefer signed integers, even for size calculations.
4984
0b963a93
PE
4985 * emacs.c: Don't assume string length fits in 'int'.
4986 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4987 (main): Don't invoke strlen when not needed.
4988
573f4b54
PE
4989 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4990 (XD_DEBUG_MESSAGE): Don't waste a byte.
4991
989f33ba
PE
4992 * callproc.c (getenv_internal_1, getenv_internal)
4993 (Fgetenv_internal):
965d34eb
PE
4994 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4995
e4d29b33
PE
4996 * lread.c (invalid_syntax): Omit length argument.
4997 All uses changed. This doesn't fix a bug, but it simplifies the
4998 code away from its former Hollerith-constant appearance, and it's
4999 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 5000 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 5001
eb49b136
PE
5002 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5003 This didn't break anything, but it didn't help either.
5004 It's confusing to put a bogus integer in a place where the actual
5005 value does not matter.
9f62aeb1 5006 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 5007 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 5008
15375a22
PE
5009 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5010 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5011 implementation.
b61cc01c
PE
5012 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5013 We prefer signed types, and the value cannot exceed the EMACS_INT
5014 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
5015 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5016 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5017 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 5018
53b2623d
PE
5019 * indent.c (sane_tab_width): New function.
5020 (current_column, scan_for_column, Findent_to, position_indentation)
5021 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 5022 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 5023
51cab52b 5024 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 5025
f2ed8a70
PE
5026 * lisp.h (lint_assume): New macro.
5027 * composite.c (composition_gstring_put_cache):
5028 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5029
abe80cc6
PE
5030 * editfns.c, insdel.c:
5031 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5032
b02c740e
PE
5033 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5034
ebc96716
PE
5035 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5036
b4e50fa0 5037 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5038 Use much-faster test for byte-length change.
311d5d7c 5039 Don't assume string byte-length fits in 'int'.
a4cf38e4 5040 Check that character arg fits in 'int'.
85461888 5041 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5042
c0c1ee9f
PE
5043 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5044
a498d7f4
PE
5045 * fns.c (concat): Catch string overflow earlier.
5046 Do not rely on integer wraparound.
5047
51cab52b
PE
5048 * dispextern.h (struct it.overlay_strings_charpos)
5049 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5050 * xdisp.c (forward_to_next_line_start)
5051 (back_to_previous_visible_line_start)
5052 (reseat_at_next_visible_line_start, next_element_from_buffer):
5053 Don't arbitrarily truncate the value of 'selective' to int.
5054
76031fad
PE
5055 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5056
5eb55db9
PE
5057 * composite.c: Don't truncate sizes to 'int'.
5058 (composition_gstring_p, composition_reseat_it)
5059 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5060 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5061 not EMACS_UINT, for indexes.
5eb55db9 5062
0703a717
PE
5063 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5064
d6202519
PE
5065 * buffer.c: Include <verify.h>.
5066 (struct sortvec.priority, struct sortstr.priority):
8961a454 5067 Now EMACS_INT, not int.
c20998a7 5068 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5069 (struct sortstr.size, record_overlay_string)
5070 (struct sortstrlist.size, struct sortlist.used):
5071 Don't truncate size to int.
5072 (record_overlay_string): Check for size-calculation overflow.
d6202519 5073 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5074
d5a19415
JM
50752011-06-22 Jim Meyering <meyering@redhat.com>
5076
029529ac 5077 Don't leak an XBM-image-sized buffer
d5a19415
JM
5078 * image.c (xbm_load): Free the image buffer after using it.
5079
a9041e6c
PE
50802011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5081
5082 Port to Sun C.
5083 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5084 that Sun C diagnosed.
5085 * fns.c (secure_hash): Fix pointer signedness issue.
5086 * intervals.c (static_offset_intervals): New function.
5087 (offset_intervals): Use it.
5088
7f3f739f
LL
50892011-06-21 Leo Liu <sdl.web@gmail.com>
5090
5091 * deps.mk (fns.o):
5092 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5093 sha512.h.
5094
5095 * fns.c (secure_hash): Rename from crypto_hash_function and change
5096 the first arg to accept symbols.
5b66d427 5097 (Fsecure_hash): New primitive.
7f3f739f
LL
5098 (syms_of_fns): New symbols.
5099
76147d94
DD
51002011-06-20 Deniz Dogan <deniz@dogan.se>
5101
5102 * process.c (Fset_process_buffer): Clarify return value in
5103 docstring.
5104
7d7d0045
CY
51052011-06-18 Chong Yidong <cyd@stupidchicken.com>
5106
5107 * dispnew.c (add_window_display_history): Use BVAR.
5108
5109 * xdisp.c (debug_method_add): Use BVAR.
5110 (check_window_end, dump_glyph_matrix, dump_glyph)
5111 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5112
5113 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5114 Likewise.
5115
5116 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5117 check till after the cache is created in init_frame_faces.
5118
ff2bc410
SM
51192011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5120
5121 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5122
28177add
PE
51232011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5124
dd3482fe
PE
5125 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5126 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5127 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5128
393d71f3 5129 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5130 * fileio.c (Finsert_file_contents):
5131 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5132 Remove the old (too-loose) buffer overflow checks.
5133 They weren't needed, since make_gap checks for buffer overflow.
5134 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5135 The old code merely checked for Emacs fixnum overflow, and relied
5136 on undefined (wraparound) behavior. The new code avoids undefined
5137 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5138
2e6813b0 5139 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5140 Tune. Don't use wider integers than needed. Don't use alloca.
5141 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5142
599a9e4f
PE
5143 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5144
99561444
PE
5145 * insdel.c, lisp.h (buffer_overflow): New function.
5146 (insert_from_buffer_1, replace_range, replace_range_2):
5147 * insdel.c (make_gap_larger):
5148 * editfns.c (Finsert_char):
5149 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5150
28177add
PE
5151 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5152
e69dafad
PE
51532011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5154
4baa020d 5155 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5156
b1c46f02
PE
5157 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5158 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5159
e69dafad
PE
5160 * fileio.c: Don't assume EMACS_INT fits in off_t.
5161 (emacs_lseek): New static function.
5162 (Finsert_file_contents, Fwrite_region): Use it.
5163 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5164
566684ea
PE
5165 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5166
e6966cd6
PE
5167 * fns.c: Don't overflow int when computing a list length.
5168 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5169 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5170 truncation on 64-bit hosts. Check for QUIT every
5171 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5172 faster and is responsive enough.
5173 (Flength): Report an error instead of overflowing an integer.
5174 (Fsafe_length): Return a float if the value is not representable
5175 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5176 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5177 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5178
dd0b0efb
PE
5179 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5180 (header_size, word_size): New constants.
5181 (allocate_vectorlike): Don't check size overflow here.
5182 (allocate_vector): Check it here instead, since this is the only
5183 caller of allocate_vectorlike that could cause overflow.
5184 Check that the new vector's length is representable as a fixnum.
5185
86fe5cfe
PE
5186 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5187 The previous code was bogus. For example, next_almost_prime (32)
5188 returned 39, which is undesirable as it is a multiple of 3; and
5189 next_almost_prime (24) returned 25, which is a multiple of 5 so
5190 why was the code bothering to check for multiples of 7?
5191
80e88859
PE
5192 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5193
4a2f0ad6
PE
5194 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5195
f66c7cf8
PE
5196 Variadic C functions now count arguments with ptrdiff_t.
5197 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5198 Back then I didn't know that the Emacs coding style prefers signed int.
5199 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5200 were being counted with int, which may truncate counts on 64-bit
5201 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5202 * lisp.h (struct Lisp_Subr.function.aMANY)
5203 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5204 Arg counts are now ptrdiff_t, not size_t.
5205 All variadic functions and their callers changed accordingly.
5206 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5207 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5208 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5209 * callint.c (Fcall_interactively): Check arg count for overflow,
5210 to avoid potential buffer overrun. Use signed char, not 'int',
5211 for 'varies' array, so that we needn't bother to check its size
5212 calculation for overflow.
5213 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5214 * eval.c (apply_lambda):
5215 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5216 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5217 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5218
a1759b76
PE
5219 * callint.c (Fcall_interactively): Don't use index var as event count.
5220
d96be9fc
PE
5221 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5222 * mem-limits.h (SIZE): Remove; no longer used.
5223
a690a978 5224 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5225
578c21e6
PE
5226 Remove unnecessary casts.
5227 * xterm.c (x_term_init):
5228 * xfns.c (x_set_border_pixel):
5229 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5230 These aren't needed now that we assume ANSI C.
5231
96f53c6c
PE
5232 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5233 It's more likely to cause problems (due to unsigned overflow)
5234 than to cure them.
5235
83c77d31
PE
5236 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5237
ee2079f1
PE
5238 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5239
6da65536
PE
5240 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5241
7147c4a4
PE
5242 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5243
193e32d9
PE
5244 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5245
e5533da6
PE
5246 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5247
9910e595
PE
5248 GLYPH_CODE_FACE returns EMACS_INT, not int.
5249 * dispextern.h (merge_faces):
5250 * xfaces.c (merge_faces):
01103c44
PE
5251 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5252 Don't assume EMACS_INT fits in int.
9910e595 5253
2638320e
PE
5254 * character.h (CHAR_VALID_P): Remove unused parameter.
5255 * fontset.c, lisp.h, xdisp.c: All uses changed.
5256
045eb8d9
PE
5257 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5258
c1f134b5
PE
5259 * fns.c (concat): Minor tuning based on overflow analysis.
5260 This doesn't fix any bugs. Use int to hold character, instead
5261 of constantly refetching from Emacs object. Use XFASTINT, not
5262 XINT, for value known to be a character. Don't bother comparing
5263 a single byte to 0400, as it's always less.
5264
395fcb93 5265 * floatfns.c (Fexpt):
327eeec8
PE
5266 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5267
abbd3d23
PE
5268 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5269 for characters.
5270
684a03ef
PE
5271 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5272
0fed43f3
PE
5273 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5274 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5275 incorrectly succeed when S was a string, because 4294967386 was
5276 truncated before it was used.
5277
8fd02eb7
PE
5278 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5279 Otherwise, an out-of-range integer could cause undefined behavior
5280 on a 64-bit host.
5281
f8c86b69
PE
5282 * composite.c: Use int, not EMACS_INT, for characters.
5283 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5284 EMACS_INT, for values that are known to be in character range.
5285 This doesn't fix any bugs but is the usual style inside Emacs and
5286 may generate better code on 32-bit machines.
5287
34206dd2
PE
5288 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5289 This is for reasons similar to the recent CHAR_STRING fix.
5290 * charset.c (Fencode_char): Check that character arg is actually
5291 a character. Pass an int to ENCODE_CHAR.
5292 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5293 wider than 'int', as a compile-time check to prevent future regressions
5294 in this area.
5295
c5958d4c 5296 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5297
5298 Make sure a 64-bit char is never passed to CHAR_STRING.
5299 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5300 by silently ignoring the top 32 bits, allowing some values
5301 that were far too large to be valid characters.
5302 * character.h: Include <verify.h>.
5303 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5304 arguments are no wider than unsigned, as a compile-time check
5305 to prevent future regressions in this area.
5306 * data.c (Faset):
01103c44 5307 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5308 (Fsubst_char_in_region):
5309 * fns.c (concat):
5310 * xdisp.c (decode_mode_spec_coding):
5311 Adjust to CHAR_STRING's new requirement.
5312 * editfns.c (Finsert_char, Fsubst_char_in_region):
5313 * fns.c (concat): Check that character args are actually
5314 characters. Without this test, these functions did the wrong
5315 thing with wildly out-of-range values on 64-bit hosts.
5316
d37ca623
PE
5317 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5318 These casts should not be needed on 32-bit hosts, either.
5319 * keyboard.c (read_char):
5320 * lread.c (Fload): Remove casts to unsigned.
5321
ea204efb
PE
5322 * lisp.h (UNSIGNED_CMP): New macro.
5323 This fixes comparison bugs on 64-bit hosts.
5324 (ASCII_CHAR_P): Use it.
5325 * casefiddle.c (casify_object):
01103c44 5326 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5327 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5328 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5329 * dispextern.h (FACE_FROM_ID):
5330 * keyboard.c (read_char): Use UNSIGNED_CMP.
5331
41cb286c
PE
5332 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5333 not to EMACS_INT, to avoid GCC warning.
5334
4a1b9832
PE
5335 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5336
55daad71
PE
5337 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5338 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5339 isn't needed on 32-bit machines.
8f95c75c 5340
01103c44
PE
5341 * buffer.c (Fgenerate_new_buffer_name):
5342 Use EMACS_INT for count, not int.
0ceccced 5343 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5344
5345 * data.c (Qcompiled_function): Now static.
5346
c6f072e7
PE
5347 * window.c (window_body_lines): Now static.
5348
20ce5912
PE
5349 * image.c (gif_load): Rename local to avoid shadowing.
5350
9c4c5f81
PE
5351 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5352 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5353 * alloc.c (make_save_value): Integer argument is now of type
5354 ptrdiff_t, not int.
5355 (mark_object): Use ptrdiff_t, not int.
5356 * lisp.h (pD): New macro.
5357 * print.c (print_object): Use it.
5358
c0c5c8ae
PE
5359 * alloc.c: Use EMACS_INT, not int, to count objects.
5360 (total_conses, total_markers, total_symbols, total_vector_size)
5361 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5362 (total_free_floats, total_floats, total_free_intervals)
5363 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5364 Now EMACS_INT, not int. All uses changed.
5365 (Fgarbage_collect): Compute overall total using a double, so that
5366 integer overflow is less likely to be a problem. Check for overflow
5367 when converting back to an integer.
5a25e253
PE
5368 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5369 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5370 These were 'int' variables that could overflow on 64-bit hosts;
5371 they were never used, so remove them instead of repairing them.
211a0b2a 5372 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5373 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5374 Previously, this ceilinged at INT_MAX, but that doesn't work on
5375 64-bit machines.
e46bb31a 5376 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5377
c78baabf 5378 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5379 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5380 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5381 when a (possibly-narrower) signed value would do just as well.
5382 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5383
c9d624c6
PE
5384 * alloc.c: Catch some string size overflows that we were missing.
5385 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5386 for convenience in STRING_BYTES_MAX.
5387 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5388 The definition here is exact; the one in lisp.h was approximate.
5389 (allocate_string_data): Check for string overflow. This catches
5390 some instances we weren't catching before. Also, it catches
5391 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5392 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5393 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5394
c9d624c6
PE
5395 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5396 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5397 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5398
353032ce
PE
5399 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5400
2bccce07
PE
5401 * alloc.c (Fmake_string): Check for out-of-range init.
5402
0ac30604
SM
54032011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5404
5405 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5406
c195f2de
JD
54072011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5408
5409 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5410 xg_get_default_scrollbar_width.
5411
5412 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5413 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5414 (style_changed_cb): Call update_theme_scrollbar_width and call
5415 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5416 all frames (Bug#8505).
5417 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5418 Call gtk_window_set_resizable if HAVE_GTK3.
5419 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5420 and height if HAVE_GTK3 (Bug#8505).
5421 (scroll_bar_width_for_theme): New variable.
5422 (update_theme_scrollbar_width): New function.
5423 (xg_get_default_scrollbar_width): Move code to
5424 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5425 (xg_initialize): Call update_theme_scrollbar_width.
5426
5427 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5428
5429 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5430
e10ac9f1
MR
54312011-06-12 Martin Rudalics <rudalics@gmx.at>
5432
5433 * frame.c (make_frame): Call other_buffer_safely instead of
5434 other_buffer.
5435
5436 * window.c (temp_output_buffer_show): Call display_buffer with
5437 second argument Vtemp_buffer_show_specifiers and reset latter
5438 immediately after the call.
5439 (Vtemp_buffer_show_specifiers): New variable.
5440 (auto_window_vscroll_p, next_screen_context_lines)
5441 (Vscroll_preserve_screen_position): Remove leading asterisks from
5442 doc-strings.
5443
2d3c217e 54442011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5445
7b7f97e8 5446 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5447 * buffer.c (Qclone_number): Remove for now, as it's unused.
5448 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5449 (record_buffer): Remove unused local.
5450 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5451 (set_frame_buffer_list): Remove; unused.
5452 * frame.h (other_visible_frames): Remove decl.
5453 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5454 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5455 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5456 if HAVE_GPM.
5457 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5458 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5459 Define only if HAVE_GPM.
5460 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5461 (update_hints_inhibit): Remove; never set. All uses removed.
5462 * widgetprv.h (emacsFrameClassRec): Remove decl.
5463 * window.c (delete_deletable_window): Now returns void, since it
5464 wasn't returning anything.
5465 (compare_window_configurations): Remove unused locals.
5466 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5467 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5468 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5469 the same widths as pointers. This follows up on the 2011-05-06 patch.
5470 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5471 * xterm.h: Likewise.
5472 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5473
1384b89e
JB
54742011-06-12 Juanma Barranquero <lekktu@gmail.com>
5475
5476 * makefile.w32-in: Update dependencies.
5477 (LISP_H): Add lib/intprops.h.
5478
1100a63c
CY
54792011-06-11 Chong Yidong <cyd@stupidchicken.com>
5480
5481 * image.c (gif_load): Add animation frame delay to the metadata.
5482 (syms_of_image): Use DEFSYM. New symbol `delay'.
5483
6198ccd0
MR
54842011-06-11 Martin Rudalics <rudalics@gmx.at>
5485
5486 * window.c (delete_deletable_window): Re-add.
5487 (Fset_window_configuration): Rewrite to handle dead buffers and
5488 consequently deletable windows.
5489 (window_tree, Fwindow_tree): Remove. Supply functionality in
5490 window.el.
5491 (compare_window_configurations): Simplify code.
5492
b6e3633c
AS
54932011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5494
1ab0dee5
AS
5495 * image.c (imagemagick_load_image): Fix type mismatch.
5496 (Fimagemagick_types): Likewise.
5497
b6e3633c
AS
5498 * window.h (replace_buffer_in_windows): Declare.
5499
9397e56f
MR
55002011-06-11 Martin Rudalics <rudalics@gmx.at>
5501
5502 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5503 Qclone_number. Remove external declaration of Qdelete_window.
5504 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5505 code.
640c8776
SM
5506 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5507 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5508 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5509 buffer list implementation.
5510 (other_buffer_safely): New function.
5511 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5512 calls to replace_buffer_in_windows and
5513 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5514 if allowed.
5515 (record_buffer): Inhibit quitting and rewrite using quittable
5516 functions. Run Qbuffer_list_update_hook if allowed.
5517 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5518 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5519 Move switch-to-buffer to window.el.
9397e56f
MR
5520 (bury-buffer): Move to window.el.
5521 (Vbuffer_list_update_hook): New variable.
5522
5523 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5524 section.
5525
5526 * window.h (resize_frame_windows): Move up in code.
5527 (Fwindow_frame): Remove EXFUN.
5528 (replace_buffer_in_all_windows): Remove prototype.
5529 (replace_buffer_in_windows_safely): Add prototype.
5530
5531 * window.c: Declare Qdelete_window static again. Move down
5532 declaration of select_count.
5533 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5534 (Fother_window): Move to window.el.
5535 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5536 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5537 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5538 window.el.
5539 (replace_buffer_in_windows): Implement by calling
5540 Qreplace_buffer_in_windows.
5541 (replace_buffer_in_all_windows): Remove with some functionality
5542 moved into replace_buffer_in_windows_safely.
5543 (replace_buffer_in_windows_safely): New function.
5544 (select_window_norecord, select_frame_norecord): Move in front
5545 of run_window_configuration_change_hook. Remove now obsolete
5546 declarations.
640c8776
SM
5547 (Fset_window_buffer): Rewrite doc-string.
5548 Call Qrecord_window_buffer.
9397e56f
MR
5549 (keys_of_window): Move binding for other-window to window.el.
5550
b50691aa
CY
55512011-06-11 Chong Yidong <cyd@stupidchicken.com>
5552
5553 * dispextern.h (struct image): Replace data member, whose int_val
5554 and ptr_val fields were not used by anything, with a single
5555 lisp_val object.
5556
5557 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5558 (gif_clear_image, gif_load, imagemagick_load_image)
5559 (gs_clear_image, gs_load): Callers changed.
5560
3f754b86
PE
55612011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5562
cca69397
PE
5563 * buffer.h: Include <time.h>, for time_t.
5564 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5565
109e28d0
PE
5566 Fix minor problems found by static checking.
5567
60737f02
PE
5568 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5569
4b66faf3
PE
5570 Make identifiers static if they are not used in other modules.
5571 * data.c (Qcompiled_function, Qframe, Qvector):
5572 * image.c (QimageMagick, Qsvg):
5573 * minibuf.c (Qmetadata):
5574 * window.c (resize_window_check, resize_root_window): Now static.
5575 * window.h (resize_window_check, resize_root_window): Remove decls.
5576
109e28d0
PE
5577 * window.c (window_deletion_count, delete_deletable_window):
5578 Remove; unused.
46a4ce9e
PE
5579 (window_body_lines): Now static.
5580 (Fdelete_other_windows_internal): Mark vars as initialized.
5581 Make sure 'resize_failed' is initialized.
5582 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5583 (resize_window_apply): Remove unused local.
5584 * window.h (delete_deletable_window): Remove decl.
5585
109e28d0 5586 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5587 (imagemagick_load_image): Fix pointer signedness problem by changing
5588 last arg from unsigned char * to char *. All uses changed.
5589 Also, fix a local for similar reasons.
5590 Remove unused locals. Remove locals to avoid shadowing.
5591 (fn_rsvg_handle_free): Remove; unused.
5592 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5593 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5594
3f754b86
PE
5595 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5596
2547adb1
CY
55972011-06-10 Chong Yidong <cyd@stupidchicken.com>
5598
5599 * image.c (gif_load): Fix omitted cast error introduced by
5600 2011-06-06 change.
5601
2c8e37d4
MR
56022011-06-10 Martin Rudalics <rudalics@gmx.at>
5603
5604 * window.h (resize_proportionally, orig_total_lines)
5605 (orig_top_line): Remove from window structure.
5606 (set_window_height, set_window_width, change_window_heights)
5607 (Fdelete_window): Remove prototypes.
5608 (resize_frame_windows): Remove duplicate declaration.
5609
440a42e3
EZ
56102011-06-10 Eli Zaretskii <eliz@gnu.org>
5611
5612 * window.h (resize_frame_windows, resize_window_check)
5613 (delete_deletable_window, resize_root_window)
5614 (resize_frame_windows): Declare prototypes.
5615
5616 * window.c (resize_window_apply): Make definition be "static" to
5617 match the prototype.
5618
562dd5e9
MR
56192011-06-10 Martin Rudalics <rudalics@gmx.at>
5620
5621 * window.c: Remove declarations of Qwindow_size_fixed,
5622 window_min_size_1, window_min_size_2, window_min_size,
5623 size_window, window_fixed_size_p, enlarge_window, delete_window.
5624 Remove static from declaration of Qdelete_window, it's
5625 temporarily needed by Fbury_buffer.
5626 (replace_window): Don't assign orig_top_line and
5627 orig_total_lines.
5628 (Fdelete_window, delete_window): Remove. Window deletion is
5629 handled by window.el.
640c8776
SM
5630 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5631 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5632 (Fdelete_other_windows): Remove. Deleting other windows is
5633 handled by window.el.
5634 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5635 handled in window.el.
5636 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5637 Window minimum sizes are handled in window.el.
5638 (shrink_windows, size_window, set_window_height)
5639 (set_window_width, change_window_heights, window_height)
5640 (window_width, CURBEG, CURSIZE, enlarge_window)
5641 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5642 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5643 handled in window.el.
5644 (make_dummy_parent): Rename to make_parent_window and give it a
5645 second argument horflag.
5646 (make_window): Don't set resize_proportionally any more.
5647 (Fsplit_window): Remove. Windows are split in window.el.
5648 (save_restore_action, save_restore_orig_size)
5649 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5650 Resize mini windows in window.el.
5651 (grow_mini_window, shrink_mini_window): Implement by calling
5652 Qresize_root_window_vertically, resize_window_check and
5653 resize_window_apply.
640c8776
SM
5654 (saved_window, Fset_window_configuration, save_window_save):
5655 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5656 resize_proportionally.
5657 (window_min_height, window_min_width): Move to window.el.
5658 (keys_of_window): Move bindings for delete-other-windows,
5659 split-window, delete-window and enlarge-window to window.el.
5660
5661 * buffer.c: Temporarily extern Qdelete_window.
5662 (Fbury_buffer): Temporarily call Qdelete_window instead of
5663 Fdelete_window (Fbury_buffer will move to window.el soon).
5664
5665 * frame.c (set_menu_bar_lines_1): Remove code handling
5666 orig_top_line and orig_total_lines.
5667
5668 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5669 set_window_height but set heights directly.
5670 (change_frame_size_1): Use resize_frame_windows.
5671
5672 * xdisp.c (init_xdisp): Don't use set_window_height but set
5673 heights directly.
5674
640c8776
SM
5675 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5676 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5677 run_window_configuration_change_hook.
5678
5679 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5680 instead of change_window_heights and run
5681 run_window_configuration_change_hook.
5682
1a13852e
MR
56832011-06-09 Martin Rudalics <rudalics@gmx.at>
5684
5685 * window.c (replace_window): Rename second argument REPLACEMENT to
5686 NEW. New third argument SETFLAG. Rewrite.
5687 (delete_window, make_dummy_parent): Call replace_window with
5688 third argument 1.
5689 (window_list_1): Move down in code.
5690 (run_window_configuration_change_hook): Move set_buffer part
5691 before select_frame_norecord part in order to unwind correctly.
5692 Rename count1 to count.
5693 (recombine_windows, delete_deletable_window, resize_root_window)
5694 (Fdelete_other_windows_internal)
5695 (Frun_window_configuration_change_hook, make_parent_window)
5696 (resize_window_check, resize_window_apply, Fresize_window_apply)
5697 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5698 (Fdelete_window_internal, Fresize_mini_window_internal):
5699 New functions.
1a13852e
MR
5700 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5701
f3d1777e
MR
57022011-06-08 Martin Rudalics <rudalics@gmx.at>
5703
496e208e
MR
5704 * window.h (window): Add some new members to window structure -
5705 normal_lines, normal_cols, new_total, new_normal, clone_number,
5706 splits, nest, prev_buffers, next_buffers.
5707 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5708 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5709
f3d1777e
MR
5710 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5711 Remove.
496e208e
MR
5712 (make_dummy_parent): Set new members of windows structure.
5713 (make_window): Move down in code. Handle new members of window
5714 structure.
5715 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5716 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5717 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5718 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5719 (Fset_window_next_buffers, Fset_window_clone_number):
5720 New functions.
496e208e
MR
5721 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5722 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5723 Doc-string fixes.
5724 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5725 Argument WINDOW can be now internal window too.
5726 (Fwindow_use_time): Move up in code.
5727 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5728 Rewrite doc-string.
5729 (Fset_window_configuration, saved_window)
5730 (Fcurrent_window_configuration, save_window_save): Handle new
5731 members of window structure.
b9e809c2
MR
5732 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5733 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5734 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5735 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5736 Qget_mru_window, Qresize_root_window,
5737 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5738 Qauto_buffer_name; staticpro them.
f3d1777e 5739
abde8f8c
MR
57402011-06-07 Martin Rudalics <rudalics@gmx.at>
5741
5742 * window.c (Fwindow_total_size, Fwindow_left_column)
5743 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5744 (Fwindow_list_1): New functions.
5745 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5746 (Fwindow_width, Fscroll_left, Fscroll_right):
5747 Use window_body_cols instead of window_box_text_cols.
5748 (delete_window, Fset_window_configuration):
5749 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5750 (delete_all_subwindows): Take a window as argument and not a
5751 structure. Rewrite.
190b47e6
MR
5752 (window_loop): Remove handling of GET_LRU_WINDOW and
5753 GET_LARGEST_WINDOW.
5754 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5755
5756 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5757 window_box_text_cols. delete_all_subwindows now takes a
5758 Lisp_Object as argument.
abde8f8c 5759
640c8776
SM
5760 * indent.c (compute_motion, Fcompute_motion):
5761 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5762
fa8a67e6
MR
5763 * frame.c (delete_frame): Call delete_all_subwindows with root
5764 window as argument.
5765
a54e3482
DC
57662011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5767
5768 * fns.c (Fputhash): Document return value.
5769
60002bf5
CY
57702011-06-06 Chong Yidong <cyd@stupidchicken.com>
5771
5772 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5773
0c671da6 57742011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5775
b862a52a 5776 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5777
be44ca6c
PE
5778 Check for overflow when converting integer to cons and back.
5779 * charset.c (Fdefine_charset_internal, Fdecode_char):
5780 Use cons_to_unsigned to catch overflow.
5781 (Fencode_char): Use INTEGER_TO_CONS.
5782 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5783 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5784 * data.c (long_to_cons, cons_to_long): Remove.
5785 (cons_to_unsigned, cons_to_signed): New functions.
5786 These signal an error for invalid or out-of-range values.
5787 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5788 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5789 * font.c (Ffont_variation_glyphs):
5790 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5791 * lisp.h: Include <intprops.h>.
5792 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5793 (cons_to_signed, cons_to_unsigned): New decls.
5794 (long_to_cons, cons_to_long): Remove decls.
5795 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5796 (Fprimitive_undo): Use CONS_TO_INTEGER.
5797 * xfns.c (Fx_window_property): Likewise.
5798 * xselect.c: Include <limits.h>.
5799 (x_own_selection, selection_data_to_lisp_data):
5800 Use INTEGER_TO_CONS.
5801 (x_handle_selection_request, x_handle_selection_clear)
5802 (x_get_foreign_selection, Fx_disown_selection_internal)
5803 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5804 (lisp_data_to_selection_data): Use cons_to_unsigned.
5805 (x_fill_property_data): Use cons_to_signed.
5806 Report values out of range.
5807
d1f3d2af
PE
5808 Check for buffer and string overflow more precisely.
5809 * buffer.h (BUF_BYTES_MAX): New macro.
5810 * lisp.h (STRING_BYTES_MAX): New macro.
5811 * alloc.c (Fmake_string):
5812 * character.c (string_escape_byte8):
5813 * coding.c (coding_alloc_by_realloc):
5814 * doprnt.c (doprnt):
5815 * editfns.c (Fformat):
5816 * eval.c (verror):
5817 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5818 since they may not be the same number.
5819 * editfns.c (Finsert_char):
5820 * fileio.c (Finsert_file_contents):
5821 Likewise for BUF_BYTES_MAX.
5822
dd52fcea
PE
5823 * image.c: Use ptrdiff_t, not int, for sizes.
5824 (slurp_file): Switch from int to ptrdiff_t.
5825 All uses changed.
5826 (slurp_file): Check that file size fits in both size_t (for
5827 malloc) and ptrdiff_t (for sanity and safety).
5828
7f9bbdbb
PE
5829 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5830 if b->modtime has its maximal value.
5831
dfe18f82
PE
5832 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5833
84acfcf0
PE
5834 Don't assume time_t can fit into int.
5835 * buffer.h (struct buffer.modtime): Now time_t, not int.
5836 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5837 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5838
ccd9a01a
PE
5839 Minor fixes for signed vs unsigned integers.
5840 * character.h (MAYBE_UNIFY_CHAR):
5841 * charset.c (maybe_unify_char):
5842 * keyboard.c (read_char, reorder_modifiers):
5843 XINT -> XFASTINT, since the integer must be nonnegative.
5844 * ftfont.c (ftfont_spec_pattern):
5845 * keymap.c (access_keymap, silly_event_symbol_error):
5846 XUINT -> XFASTINT, since the integer must be nonnegative.
5847 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5848 since it makes no difference and we prefer signed.
5849 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5850 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5851 nonnegative.
5852
d6d100dd
SM
58532011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5854
5855 * window.h (Fwindow_frame): Declare.
5856
2b6148e4
PE
58572011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5858
5859 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5860 (SPARE_MEMORY): Always define.
5861 (LARGE_REQUEST): Remove.
5862 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5863
f230ecc9
MR
58642011-06-06 Martin Rudalics <rudalics@gmx.at>
5865
727e958e
MR
5866 * lisp.h: Move EXFUNS for Fframe_root_window,
5867 Fframe_first_window and Fset_frame_selected_window to window.h.
5868
5869 * window.h: Move EXFUNS for Fframe_root_window,
5870 Fframe_first_window and Fset_frame_selected_window here from
5871 lisp.h.
5872
5873 * frame.c (Fwindow_frame, Fframe_first_window)
5874 (Fframe_root_window, Fframe_selected_window)
5875 (Fset_frame_selected_window): Move to window.c.
5876 (Factive_minibuffer_window): Move to minibuf.c.
5877 (Fother_visible_frames_p): New function.
5878
5879 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5880
f230ecc9
MR
5881 * window.c (decode_window, decode_any_window): Move up in code.
5882 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5883 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5884 (Fwindow_buffer): Move up and rewrite doc-string.
5885 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5886 (Fwindow_prev): New functions.
727e958e
MR
5887 (Fwindow_frame): Move here from frame.c. Accept any window as
5888 argument.
5889 (Fframe_root_window, Fframe_first_window)
5890 (Fframe_selected_window): Move here from frame.c. Accept frame
5891 or arbitrary window as argument. Update doc-strings.
5892 (Fminibuffer_window): Move up in code.
5893 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5894 (Fset_frame_selected_window): Move here from frame.c.
5895 Marginal rewrite.
727e958e
MR
5896 (Fselected_window, select_window, Fselect_window): Move up in
5897 code. Minor doc-string fixes.
f230ecc9 5898
4d09bcf6
PE
58992011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5900
5901 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5902 Do not assume that spare memory exists; that assumption is valid
5903 only if SYSTEM_MALLOC.
5904 (LARGE_REQUEST): New macro, so that the issue of large requests
5905 is separated from the issue of spare memory.
5906
810928a2
AS
59072011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5908
172418ad
AS
5909 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5910 format. (Bug#8806)
5911
43f862f7
AS
5912 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5913
810928a2
AS
5914 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5915 before statements.
5916
a059fe24
JD
59172011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5918
5919 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5920
5921 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5922
5923 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5924 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5925
989bf368
JB
59262011-06-05 Juanma Barranquero <lekktu@gmail.com>
5927
5928 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5929
4b80f674
CY
59302011-06-04 Chong Yidong <cyd@stupidchicken.com>
5931
5932 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5933 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5934 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5935 New error handlers.
4b80f674
CY
5936 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5937 Obey Vx_select_enable_clipboard_manager. Catch errors in
5938 x_clipboard_manager_save (Bug#8779).
5939 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5940 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5941
99a33b77 59422011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5943
5944 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5945
99a33b77 59462011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5947
5948 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5949 in the current matrix if keep_current_p is non-zero.
5950
8264569d
EZ
59512011-06-04 Eli Zaretskii <eliz@gnu.org>
5952
5953 * bidi.c (bidi_level_of_next_char): Fix last change.
5954
57f97249
EZ
59552011-06-03 Eli Zaretskii <eliz@gnu.org>
5956
fec2107c 5957 Support bidi reordering of text covered by display properties.
57f97249 5958
fec2107c
EZ
5959 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5960 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5961 (bidi_cache_search, bidi_cache_iterator_state)
5962 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5963 (bidi_level_of_next_char, bidi_move_to_visually_next):
5964 Support character positions inside a run of characters covered by a
fec2107c
EZ
5965 display string.
5966 (bidi_paragraph_init, bidi_resolve_explicit_1)
5967 (bidi_level_of_next_char): Call bidi_fetch_char and
5968 bidi_fetch_char_advance instead of FETCH_CHAR and
5969 FETCH_CHAR_ADVANCE.
5970 (bidi_init_it): Initialize new members.
5971 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5972 definitions.
5973 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5974 instead of using explicit *_CHAR codes.
d6d100dd
SM
5975 (bidi_resolve_explicit, bidi_resolve_weak):
5976 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5977 bidirectional text is supported only in multibyte buffers.
5978 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5979 it to initialize the frame_window_p member of struct bidi_it.
5980 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5981 (bidi_resolve_explicit, bidi_resolve_weak)
5982 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5983 bidi_it->nchars is non-positive.
5984 (bidi_level_of_next_char): Don't try to lookup the cache for the
5985 next/previous character if nothing is cached there yet, or if we
5986 were just reseat()'ed to a new position.
c40e2fb2 5987
0e14fe90
EZ
5988 * xdisp.c (set_cursor_from_row): Set start and stop points
5989 according to the row's direction when priming the loop that looks
5990 for the glyph on which to display cursor.
5991 (single_display_spec_intangible_p): Function deleted.
5992 (display_prop_intangible_p): Reimplement to call
5993 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5994 Accept 3 additional arguments needed by handle_display_spec.
5995 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5996 values: lists, `(when COND...)' forms, etc.
5997 (single_display_spec_string_p): Support property values that are
5998 lists with the argument STRING its top-level element.
5999 (display_prop_string_p): Fix the condition for processing a
6000 property that is a list to be consistent with handle_display_spec.
fec2107c 6001 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
6002 last portion of handle_display_prop.
6003 (compute_display_string_pos): Accept additional argument
6004 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6005 value of a `display' property is a "replacing spec".
6006 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6007 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6008 the display property, but just return a value indicating whether
6009 the display property will replace the characters it covers.
6010 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6011 frame_window_p members of struct bidi_it.
d6d100dd
SM
6012 (compute_display_string_pos, compute_display_string_end):
6013 New functions.
fec2107c
EZ
6014 (push_it): Accept second argument POSITION, where pop_it should
6015 jump to continue iteration.
6016 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 6017
fec2107c
EZ
6018 * keyboard.c (adjust_point_for_property): Adjust the call to
6019 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
6020
6021 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
6022 (bidi_init_it): Update prototypes.
6023 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
6024 (compute_display_string_pos, compute_display_string_end):
6025 Declare prototypes.
fec2107c
EZ
6026 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6027 EMACS_INT.
fc6f18ce 6028
40087514 60292011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6030
57f53182
PE
6031 Malloc failure behavior now depends on size of allocation.
6032 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6033 * lisp.h: Change signatures accordingly.
6034 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6035 All callers changed. (Bug#8762)
6036
6037 * gnutls.c: Use Emacs's memory allocators.
6038 Without this change, the gnutls library would invoke malloc etc.
6039 directly, which causes problems on non-SYNC_INPUT hosts, and which
6040 runs afoul of improving memory_full behavior. (Bug#8761)
6041 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6042 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6043 xfree instead of the default malloc, realloc, free.
6044 (Fgnutls_boot): No need to check for memory allocation failure,
6045 since xmalloc does that for us.
6046
ac32cd99 6047 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6048 * category.c (hash_get_category_set):
6049 * ccl.c (ccl_driver):
6050 * charset.c (Fdefine_charset_internal):
6051 * charset.h (struct charset.hash_index):
6052 * composite.c (get_composition_id, gstring_lookup_cache)
6053 (composition_gstring_put_cache):
6054 * composite.h (struct composition.hash_index):
6055 * dispextern.h (struct image.hash):
6056 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6057 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6058 (hashfn_equal, hashfn_user_defined, make_hash_table)
6059 (maybe_resize_hash_table, hash_lookup, hash_put)
6060 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6061 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6062 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6063 * image.c (make_image, search_image_cache, lookup_image)
6064 (xpm_put_color_table_h):
6065 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6066 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6067 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6068 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6069 * alloc.c (allocate_vectorlike):
6070 Check for overflow in vector size calculations.
6071 * ccl.c (ccl_driver):
6072 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6073 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6074 need to be updated by these changes.
40087514
PE
6075 * fns.c (make_hash_table, maybe_resize_hash_table):
6076 Check for integer overflow with large hash tables.
0de4bb68
PE
6077 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6078 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6079 (SXHASH_REDUCE): New macro.
6080 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6081 Use it instead of discarding useful hash info with large hash values.
6082 (sxhash_float): New function.
6083 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6084 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6085 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6086 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6087 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6088 Adjust signatures to match updated version of code.
6089 (consing_since_gc): Now EMACS_INT, since a single hash table can
6090 use more than INT_MAX bytes.
6091
698d32e2
DN
60922011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6093
6094 Make it possible to build with GCC-4.6+ -O2 -flto.
6095
6096 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6097
fd6fa53f
SM
60982011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6099
6100 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6101 Call minibuffer-inactive-mode.
6102
864db017
JB
61032011-05-31 Juanma Barranquero <lekktu@gmail.com>
6104
6105 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6106 Update dependencies.
6107
2ad0baf4
DN
61082011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6109
6110 * data.c (init_data): Remove code for UTS, this system is not
6111 supported anymore.
6112
4fcc2638
DN
61132011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6114
6115 Don't force ./temacs to start in terminal mode.
6116
6117 * frame.c (make_initial_frame): Initialize faces in all cases, not
6118 only when CANNOT_DUMP is defined.
6119 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6120
c56e0fd5
DN
61212011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6122
6123 * dispnew.c (add_window_display_history): Use const for the string
6124 pointer. Remove declaration, not needed.
6125
333d54da 61262011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6127
55d4c1b2 6128 Use 'inline', not 'INLINE'.
333d54da 6129 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6130 * alloc.c, fontset.c (INLINE): Remove.
6131 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6132 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6133 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6134 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6135 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6136
738db178
DN
61372011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6138
6139 Make it possible to run ./temacs.
6140
6141 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6142 syms_of_callproc does the same thing. Remove test for
6143 "initialized", do it in the caller.
6144 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6145
620c53a6
SM
61462011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6147
6148 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6149 (read_minibuf): Use get_minibuffer.
6150 (syms_of_minibuf): Use DEFSYM.
6151 (Qmetadata): New var.
6152 * data.c (Qbuffer): Don't make it static.
6153 (syms_of_data): Use DEFSYM.
6154
e003a292
PE
61552011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6156
6157 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6158 (CCL_CODE_MIN): New macro.
6159
ed008a6d
PE
61602011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6161
3687c2ef
PE
6162 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6163
ed008a6d
PE
6164 * eval.c (Qdebug): Now static.
6165 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6166 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6167 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6168
d66c4c7c
CY
61692011-05-29 Chong Yidong <cyd@stupidchicken.com>
6170
6171 * image.c: Various fixes to ImageMagick code comments.
6172 (Fimagemagick_types): Doc fix.
6173
5fbc2025
PE
61742011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6175
0196f88a
PE
6176 Minor fixes prompted by GCC 4.6.0 warnings.
6177
6178 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6179
5fbc2025
PE
6180 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6181 (x_clipboard_manager_save_all): Move extern decl to ...
6182 * xterm.h: ... here, so that it can be checked for consistency.
6183
1dd3c2d9
CY
61842011-05-29 Chong Yidong <cyd@stupidchicken.com>
6185
6186 * xselect.c (x_clipboard_manager_save_frame)
6187 (x_clipboard_manager_save_all): New functions.
6188 (Fx_clipboard_manager_save): Lisp function deleted.
6189
6190 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6191 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6192
6193 * xterm.h: Update prototype.
6194
5ba6571d
WX
61952011-05-28 William Xu <william.xwl@gmail.com>
6196
6197 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6198 exiting (Bug#8239).
6199
3eaff834
JM
62002011-05-28 Jim Meyering <meyering@redhat.com>
6201
e1900994 6202 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6203 * fns.c (to_uchar): Define.
6204 (crypto_hash_function): Use it to convert some newly-signed
6205 variables to unsigned, to avoid sign-extension bugs. For example,
6206 without this change, (md5 "truc") would evaluate to
6207 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6208 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6209 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6210
0f6990a7
PE
62112011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6212
6213 Integer overflow fixes.
c8a9ca5a 6214
08686060
PE
6215 * dbusbind.c: Serial number integer overflow fixes.
6216 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6217 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6218 to hold a serial number that is too large for a fixnum.
6219 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6220 Check for serial numbers out of range. Decode any serial number
59568bf0 6221 that was so large that it became a float. (Bug#8722)
08686060 6222
2d1fc3c7
PE
6223 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6224 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6225 Use XFASTINT rather than XUINT when numbers are nonnegative.
6226 (xd_append_arg, Fdbus_method_return_internal):
6227 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6228 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6229 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6230 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6231 (Bug#8722)
2d1fc3c7 6232
c8a9ca5a
PE
6233 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6234
519e1d69
PE
6235 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6236
6df6ae42 6237 ccl: Add integer overflow checks.
30569699
PE
6238 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6239 (IN_INT_RANGE): New macros.
6240 (ccl_driver): Use them to check for integer overflow when
6241 decoding a CCL program. Many of the new checks are whether XINT (x)
6242 fits in int; it doesn't always, on 64-bit hosts. The new version
6243 doesn't catch all possible integer overflows, but it's an
847044ea 6244 improvement. (Bug#8719)
30569699 6245
c11285dc
PE
6246 * alloc.c (make_event_array): Use XINT, not XUINT.
6247 There's no need for unsigned here.
6248
fdccd48e
PE
6249 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6250 This follows up to the 2011-05-06 change that substituted uintptr_t
6251 for EMACS_INT. This case wasn't caught back then.
6252
37910ab2
PE
6253 Rework Fformat to avoid integer overflow issues.
6254 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6255 now (part of C89). Include <verify.h>.
6256 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6257 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6258 (Fformat): Avoid the prepass trying to compute sizes; it was only
6259 approximate and thus did not catch overflow reliably. Instead, walk
6260 through the format just once, formatting and computing sizes as we go,
6261 checking for integer overflow at every step, and allocating a larger
6262 buffer as needed. Keep track separately whether the format is
6263 multibyte. Keep only the most-recently calculated precision, rather
6264 than them all. Record whether each argument has been converted to
6265 string. Use EMACS_INT, not int, for byte and char and arg counts.
6266 Support field widths and precisions larger than INT_MAX. Avoid
6267 sprintf's undefined behavior with conversion specifications such as %#d
6268 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6269 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6270 formatting out-of-range floating point numbers with int
9173deec 6271 formats. (Bug#8668)
37910ab2 6272
2e6578fb
PE
6273 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6274
0ae6bdee
PE
6275 * data.c: Avoid integer truncation in expressions involving floats.
6276 * data.c: Include <intprops.h>.
6277 (arith_driver): When there's an integer overflow in an expression
6278 involving floating point, convert the integers to floating point
6279 so that the resulting value does not suffer from catastrophic
6280 integer truncation. For example, on a 64-bit host (* 4
6281 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6282 Do not rely on undefined behavior after integer overflow.
6283
de883a70
PE
6284 merge count_size_as_multibyte, parse_str_to_multibyte
6285 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6286 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6287 Check for integer overflow.
6288 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6289 since it's now a duplicate of the other. This is more of
6290 a character than a buffer op, so better that it's in character.c.
6291 * fns.c, print.c: Adjust to above changes.
6292
2ff916cb
PE
62932011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6294
6295 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6296
f1b54466
PE
62972011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6298
fb1ac845
PE
6299 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6300 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6301 (x_clipboard_manager_save): Now static.
6302 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6303
f1b54466
PE
6304 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6305 (crypto_hash_function): Now static.
6306 Fix pointer signedness problems. Avoid unnecessary initializations.
6307
a9f737ee
CY
63082011-05-27 Chong Yidong <cyd@stupidchicken.com>
6309
6310 * termhooks.h (Vselection_alist): Make it terminal-local.
6311
6312 * terminal.c (create_terminal): Initialize it.
6313
6314 * xselect.c: Support for clipboard managers.
6315 (Vselection_alist): Move to termhooks.h as terminal-local var.
6316 (LOCAL_SELECTION): New macro.
6317 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6318 (symbol_to_x_atom): Remove gratuitous arg.
6319 (x_handle_selection_request, lisp_data_to_selection_data)
6320 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6321 (x_own_selection, x_get_local_selection, x_convert_selection):
6322 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6323 (some_frame_on_display): Delete unused function.
6324 (Fx_own_selection_internal, Fx_get_selection_internal)
6325 (Fx_disown_selection_internal, Fx_selection_owner_p)
6326 (Fx_selection_exists_p): New optional frame arg.
6327 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6328 (x_handle_selection_clear): Don't treat other terminals with the
6329 same keyboard specially. Use the terminal-local Vselection_alist.
6330 (x_clear_frame_selections): Use Frun_hook_with_args.
6331
6332 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6333
6334 * xterm.h: Add support for those atoms.
6335
e067f0c1
CY
63362011-05-26 Chong Yidong <cyd@stupidchicken.com>
6337
6338 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6339 (converted_selections, conversion_fail_tag): New global variables.
6340 (x_selection_request_lisp_error): Free the above.
6341 (x_get_local_selection): Remove unnecessary code.
6342 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6343 of converted selections stored in converted_selections.
6344 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6345 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6346 (x_convert_selection): New function.
6347 (x_handle_selection_event): Simplify.
6348 (x_get_foreign_selection): Don't ignore incoming requests while
6349 waiting for an answer; this will fail when we implement
6350 SAVE_TARGETS, and seems unnecessary anyway.
6351 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6352 (Vx_sent_selection_functions): Doc fix.
6353
0f4aebc0
LL
63542011-05-26 Leo Liu <sdl.web@gmail.com>
6355
6356 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6357
e61124cd
YM
63582011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6359
6360 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6361
6362 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6363 for fringe update if it has periodic bitmap.
ac389d0c 6364 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6365 and fringe_bitmap_periodic_p.
6366
6367 * fringe.c (get_fringe_bitmap_data): New function.
6368 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6369 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6370 row. Mark glyph row for fringe update if periodicity changed.
6371
6372 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6373 for fringe update unless it has periodic bitmap.
6374
f16d9837
KH
63752011-05-25 Kenichi Handa <handa@m17n.org>
6376
6377 * xdisp.c (get_next_display_element): Set correct it->face_id for
6378 a static composition.
6379
e1b90ef6
LL
63802011-05-24 Leo Liu <sdl.web@gmail.com>
6381
6382 * deps.mk (fns.o):
6383 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6384
6385 * fns.c (crypto_hash_function, Fsha1): New function.
6386 (Fmd5): Use crypto_hash_function.
6387 (syms_of_fns): Add Ssha1.
6388
7400048f
PE
63892011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6390
6391 * gnutls.c: Remove unused macros.
6392 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6393 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6394 Remove macros that are defined and never used.
6395 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6396
abb71cf4
CY
63972011-05-22 Chong Yidong <cyd@stupidchicken.com>
6398
6399 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6400 (Fx_get_selection_internal): Minor cleanup.
6401 (Fx_own_selection_internal): Rename arguments for consistency with
6402 select.el.
6403
6307db39
PE
64042011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6405
6406 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6407
f3d4e0a4
CY
64082011-05-22 Chong Yidong <cyd@stupidchicken.com>
6409
6410 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6411
4d8ade89
YM
64122011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6413
6414 * dispnew.c (scrolling_window): Don't exclude the case that the
6415 last enabled row in the desired matrix touches the bottom boundary.
6416
32078c8d
GM
64172011-05-21 Glenn Morris <rgm@gnu.org>
6418
6419 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6420 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6421 and add some more files.
32078c8d 6422
7285dc67
EZ
64232011-05-20 Eli Zaretskii <eliz@gnu.org>
6424
6425 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6426 report_file_error introduced by the change from 2011-05-07.
6427
89d1bd22
PE
64282011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6429
6430 * systime.h (Time): Define only if emacs is defined.
6431 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6432 where the include path doesn't have X11/X.h by default. See
6433 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6434
cd394be1 64352011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6436
6437 * composite.c (find_automatic_composition): Fix previous change.
6438
b9704ad9
GM
64392011-05-20 Glenn Morris <rgm@gnu.org>
6440
6441 * lisp.mk: New file, split from Makefile.in.
6442 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6443 (shortlisp): Remove.
6444 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6445
4a720484
GM
64462011-05-19 Glenn Morris <rgm@gnu.org>
6447
6448 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6449 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6450 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6451 (lisp): Set the order to that of loadup.el.
6452 (shortlisp): Make it a copy of $lisp.
6453 (SOME_MACHINE_LISP): Remove.
6454 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6455 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6456
a28d4396
KH
64572011-05-18 Kenichi Handa <handa@m17n.org>
6458
6459 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6460 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6461 (find_automatic_composition): Mostly rewrite for efficiency.
6462
a2b1fa8e
JB
64632011-05-18 Juanma Barranquero <lekktu@gmail.com>
6464
6465 * makefile.w32-in: Update dependencies.
6466
8e1f5610
CS
64672011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6468
6469 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6470 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6471
7025ee00 64722011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6473
cdfa6eab
PE
6474 Fix some integer overflow issues, such as string length overflow.
6475
06d6db33
PE
6476 * insdel.c (count_size_as_multibyte): Check for string overflow.
6477
2b4560a8
PE
6478 * character.c (lisp_string_width): Check for string overflow.
6479 Use EMACS_INT, not int, for string indexes and lengths; in
6480 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6481 the resulting string length overflows an EMACS_INT; instead,
6482 report a string overflow if no precision given. When checking for
6483 precision exhaustion, use a check that cannot possibly have
6484 integer overflow. (Bug#8675)
6485 * character.h (lisp_string_width): Adjust to new signature.
6486
cb93f9be
PE
6487 * alloc.c (string_overflow): New function.
6488 (Fmake_string): Use it. This doesn't change behavior, but saves
6489 a few bytes and will simplify future changes.
6490 * character.c (string_escape_byte8): Likewise.
6491 * lisp.h (string_overflow): New decl.
6492
1a1f3366
PE
6493 Fixups, following up to the user-interface timestamp change.
6494 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6495 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6496 * msdos.c (mouse_get_pos): Likewise.
6497 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6498 * w32gui.h (Time): Define by including "systime.h" rather than by
6499 declaring it ourselves. (Bug#8664)
6500
d4e3e4d3
PE
6501 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6502 * image.c (clear_image_cache): Likewise.
6503
f6a24d19
PE
6504 * term.c (term_mouse_position): Don't assume time_t wraparound.
6505
08dc5ae6
PE
6506 Be more systematic about user-interface timestamps.
6507 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6508 and sometimes 'EMACS_UINT', to represent these timestamps.
6509 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6510 This makes the code easier to follow, and makes it easier to catch
6511 integer overflow bugs such as Bug#8664.
6512 * frame.c (Fmouse_position, Fmouse_pixel_position):
6513 Use Time, not unsigned long, for user-interface timestamps.
6514 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6515 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6516 * keyboard.h (last_event_timestamp): Likewise.
6517 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6518 * menu.h (xmenu_show): Likewise.
6519 * term.c (term_mouse_position): Likewise.
6520 * termhooks.h (struct input_event.timestamp): Likewise.
6521 (struct terminal.mouse_position_hook): Likewise.
6522 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6523 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6524 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6525 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6526 what it was before.
6527 * menu.h, termhooks.h: Include "systime.h", for Time.
6528
8e55734a
PE
6529 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6530 Don't assume that the difference between two unsigned long values
6531 can fit into an integer. At this point, we know button_down_time
6532 <= event->timestamp, so the difference must be nonnegative, so
6533 there's no need to cast the result if double-click-time is
6534 nonnegative, as it should be; check that it's nonnegative, just in
6535 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6536 apart (about 25 days). (Bug#8664)
8e55734a 6537
841f1b75 6538 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6539 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6540
3e26f69c
PE
6541 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6542 that always fit in int. Use a sentinel instead of a counter, to
6543 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6544 * frame.h (struct frame): Use int for menu_bar_items_used
6545 instead of EMACS_INT, since it always fits in int.
3e26f69c 6546
5cc152c0
PE
6547 * menu.c (grow_menu_items): Check for int overflow.
6548
d89eb65e
PE
6549 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6550
5235bd3e
PE
6551 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6552 Before, the code was not consistent. These values cannot exceed
6553 2**31 - 1 so there's no need to make them unsigned.
6554 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6555 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6556 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6557 as modifiers.
6558 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6559
bc827e23
PE
6560 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6561 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6562 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6563 presumably because the widths might not match.
6564
78eb494e
PE
6565 * window.c (size_window): Avoid needless test at loop start.
6566
04f2d78b
CB
65672011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6568
6569 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6570
d2fc7e3d 65712011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6572
6573 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6574
d2fc7e3d 65752011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6576
6577 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6578 `width' to `bar_area_x' and `bar_area_width', respectively.
6579 (x_scroll_run): Take account of fringe background extension.
6580
04f2d78b
CB
6581 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6582 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6583 `bar_area_width', respectively.
6584 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6585 background extension.
6586
79b70037
GM
65872011-05-10 Jim Meyering <meyering@redhat.com>
6588
6589 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6590
2f142cc5
JB
65912011-05-10 Juanma Barranquero <lekktu@gmail.com>
6592
6593 * image.c (Finit_image_library): Return t for built-in image types,
6594 like pbm and xbm. (Bug#8640)
6595
57679c86
AS
65962011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6597
6598 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6599
888c9e86
EZ
66002011-05-07 Eli Zaretskii <eliz@gnu.org>
6601
b0512a1d
EZ
6602 * w32console.c (Fset_screen_color): Doc fix.
6603 (Fget_screen_color): New function.
6604 (syms_of_ntterm): Defsubr it.
6605
7285dc67
EZ
6606 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6607 unlink the temporary file if Fcall_process didn't create it in the
6608 first place.
6609 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6610 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6611 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6612 cue to call_process_cleanup not to close that handle.
6613
4d3fcc8e
BK
66142011-05-07 Ben Key <bkey76@gmail.com>
6615
6616 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6617 one of two shell specific rules, either bootstrap-temacs-CMD or
6618 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6619 to the previous implementation of the bootstrap-temacs rule.
6620 The bootstrap-temacs-CMD rule is similar to the previous
6621 implementation of the bootstrap-temacs rule except that it
6622 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6623 variable.
6624
6625 These changes, along with some changes to nt/configure.bat,
6626 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6627 earlier fix to add support for --cflags and --ldflags options
6628 that include quotes so that it works whether make uses cmd or
6629 sh as the shell.
6630
b4289b64
MA
66312011-05-06 Michael Albinus <michael.albinus@gmx.de>
6632
6633 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6634 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6635 is a constant.
6636 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6637 a string. Handle both cases.
6638 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6639 (Fdbus_register_method): Use Qinvalid_function.
6640
af4c0e28
JB
66412011-05-06 Juanma Barranquero <lekktu@gmail.com>
6642
6643 * makefile.w32-in: Update dependencies.
6644 (LISP_H): Add inttypes.h and stdin.h.
6645 (PROCESS_H): Add unistd.h.
6646
c51453d9
EZ
66472011-05-06 Eli Zaretskii <eliz@gnu.org>
6648
6649 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6650 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6651
8ff0ac3c 66522011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6653
4c4b566b
PE
6654 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6655
aab2b9b5
PE
6656 * term.c (vfatal): Remove stray call to va_end.
6657 It's not needed and the C Standard doesn't allow it here anyway.
6658
c378da0b
PE
6659 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6660 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6661
288b08c7
PE
6662 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6663 bytes.
6664
e3601888
PE
6665 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6666
db6c0e74
PE
6667 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6668
dd5963ea
PE
6669 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6670
88c9450f
PE
6671 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6672
2f9442b8
PE
6673 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6674
c032b5f8
PE
6675 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6676 * charset.c (Fdefine_charset_internal): Don't initialize
6677 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6678 32-bit int (Bug#8600).
a108c10b
PE
6679
6680 * lread.c (read_integer): Be more consistent with string-to-number.
6681 Use string_to_number to do the actual conversion; this avoids
6682 rounding errors and fixes some other screwups. Without this fix,
6683 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6684 (digit_to_number): Move earlier, for benefit of read_integer.
6685 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6686 not a digit in any supported base. (Bug#8602)
a108c10b 6687
ad5f9eea
PE
6688 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6689
aec1708a
PE
6690 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6691 to match comment at start of function. This also removes a
6692 GCC warning about overflow in a 32+64-bit port.
6693
47be4ab5
PE
6694 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6695
371cac43
PE
6696 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6697 Reported by Stefan Monnier in
6698 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6699 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6700 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6701
d01a7826
PE
6702 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6703 (EMACS_UINTPTR): Likewise, with uintptr_t.
6704
7fd47d5c
PE
6705 * lisp.h: Prefer 64-bit EMACS_INT if available.
6706 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6707 on 32-bit hosts that have 64-bit int, so that they can access
6708 large files.
122b0c86
PE
6709 However, temporarily disable this change unless the temporary
6710 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6711
8727937b
PE
6712 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6713
8ac068ac
PE
6714 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6715 This removes an assumption that EMACS_INT and long are the same
6716 width as pointers. The assumption is true for Emacs porting targets
6717 now, but we want to make other targets possible.
6718 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6719 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6720 In the rest of the code, change types of integers that hold casted
6721 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6722 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6723 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6724 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6725 No need to cast type when ORing.
6726 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6727 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6728 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6729 assume EMACS_INT is the same width as char *.
6730 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6731 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6732 Remove no-longer-needed casts.
6733 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6734 (xg_tool_bar_help_callback, xg_make_tool_item):
6735 Use EMACS_INTPTR to hold an integer
6736 that will be cast to void *; this can avoid a GCC warning
6737 if EMACS_INT is not the same width as void *.
6738 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6739 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6740 (current_message_1, set_message_1):
6741 Use a local to convert to proper width without a cast.
6742 * xmenu.c (dialog_selection_callback): Likewise.
6743
ede49d71
PE
6744 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6745 Also, don't assume VALBITS / RAND_BITS is less than 5,
6746 and don't rely on undefined behavior when shifting a 1 left into
6747 the sign bit.
6748 * lisp.h (get_random): Change signature to match.
6749
2f30ecd0
PE
6750 * lread.c (hash_string): Use size_t, not int, for hash computation.
6751 Normally we prefer signed values; but hashing is special, because
6752 it's better to use unsigned division on hash table sizes so that
6753 the remainder is nonnegative. Also, size_t is the natural width
6754 for hashing into memory. The previous code used 'int', which doesn't
6755 retain enough info to hash well into very large tables.
6756 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6757
2a866e7b
PE
6758 * dbusbind.c: Don't possibly lose pointer info when converting.
6759 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6760 Use XPNTR rather than XHASH, so that the high-order bits of
6761 the pointer aren't lost when converting through void *.
6762
51639eac
PE
6763 * eval.c (Fautoload): Don't double-shift a pointer.
6764
92394119
PE
6765 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6766
dbdb9a7c
JB
67672011-05-06 Juanma Barranquero <lekktu@gmail.com>
6768
6769 * gnutls.c (DEF_GNUTLS_FN):
6770 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6771
db7a0b4f
AS
67722011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6773
6774 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6775 marker. (Bug#8610)
6776
cd394be1 67772011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6778
6779 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6780 New version that can reserve upto 2GB of heap space.
6781
f7ff1b0f 67822011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6783
6784 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6785
639c109b
TZ
67862011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6787
6788 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6789 `gnutls_certificate_set_x509_key_file'.
6790
d2127135
JB
67912011-05-05 Juanma Barranquero <lekktu@gmail.com>
6792
6793 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6794 Update dependencies.
6795
e968f4f3
JB
67962011-05-04 Juanma Barranquero <lekktu@gmail.com>
6797
6798 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6799 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6800 Remove unused parameter `fildes'.
6801 * process.c (read_process_output, send_process): Don't pass it.
6802
84d358f0
JB
68032011-05-04 Juanma Barranquero <lekktu@gmail.com>
6804
6805 Fix previous change: the library cache is defined in w32.c.
6806 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6807 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6808
0898ca10
JB
68092011-05-04 Juanma Barranquero <lekktu@gmail.com>
6810
6811 Implement dynamic loading of GnuTLS on Windows.
6812
6813 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6814 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6815 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6816 Declare.
6817
6818 * gnutls.c (Qgnutls_dll): Define.
6819 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6820 (gnutls_*): Declare function pointers.
6821 (init_gnutls_functions): New function to initialize function pointers.
6822 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6823 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6824 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6825 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6826 (emacs_gnutls_write, emacs_gnutls_read)
6827 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6828 (Fgnutls_available_p): New function.
6829 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6830 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6831 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6832
6833 * image.c: Include w32.h.
6834 (Vimage_type_cache): Delete.
6835 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6836 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6837 (w32_delayed_load): Move to w32.c.
6838
6839 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6840
6841 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6842 (w32_delayed_load): Move from image.c. When loading a library, record
6843 its filename in the :loaded-from property of the library id.
6844 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6845 Initialize and staticpro them.
6846 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6847
6848 * process.c: Include lisp.h before w32.h, not after.
6849 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6850 instead of gnutls_record_check_pending.
6851
6852 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6853
ff4de4aa
TZ
68542011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6855
6856 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6857 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6858 as passed in.
6859
abe95abb
JD
68602011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6861
6862 * xterm.c (x_set_frame_alpha): Do not set property on anything
6863 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6864
e16e55d4
JB
68652011-05-02 Juanma Barranquero <lekktu@gmail.com>
6866
6867 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6868
bafcf6a5
JB
68692011-05-02 Juanma Barranquero <lekktu@gmail.com>
6870
6871 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6872 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6873 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6874 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6875 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6876 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6877 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6878 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6879 (Qgnutls_bootprop_callbacks_verify): Make static.
6880
e7a6747f
AS
68812011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6882
19ed11ba
AS
6883 * callproc.c: Indentation fixup.
6884
e7a6747f 6885 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6886 (wait_for_termination, interruptible_wait_for_termination):
6887 Move after wait_for_termination_1.
e7a6747f 6888
1ef14cb4
LMI
68892011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6890
6891 * sysdep.c (interruptible_wait_for_termination): New function
6892 which is like wait_for_termination, but allows keyboard
6893 interruptions.
6894
6895 * callproc.c (Fcall_process): Add (:file "file") as an option for
6896 the STDOUT buffer.
6897 (Fcall_process_region): Ditto.
6898
330d880c
EZ
68992011-04-30 Eli Zaretskii <eliz@gnu.org>
6900
8db90b73
EZ
6901 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6902 rather than `XVECTOR (FOO)->size'.
6903
330d880c
EZ
6904 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6905 inttypes.h, as a gnulib replacement is used if it not available in
6906 system headers.
6907
15cbd324
EZ
69082011-04-21 Eli Zaretskii <eliz@gnu.org>
6909
6910 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6911 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6912 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6913
6914 * coding.c (coding_alloc_by_realloc): Error out if destination
6915 will grow beyond MOST_POSITIVE_FIXNUM.
6916 (decode_coding_emacs_mule): Abort if there isn't enough place in
6917 charbuf for the composition carryover bytes. Reserve an extra
6918 space for up to 2 characters produced in a loop.
6919 (decode_coding_iso_2022): Abort if there isn't enough place in
6920 charbuf for the composition carryover bytes.
6921
69222011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6923
ae940cca
EZ
6924 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6925 aborting when %lld or %lll format is passed.
6926 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6927 %llo or %llx format is passed. (Bug#8545)
6928
03ab8921
EZ
6929 * window.c (window_scroll_line_based): Use a marker instead of
6930 simple variables to record original value of point. (Bug#7952)
6931
afda1437
EZ
6932 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6933 produced by %s or %c overflows available buffer space. (Bug#8545)
6934
f76dee0c
PE
69352011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6936
6937 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6938 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6939
fdc5744d
JB
69402011-04-28 Juanma Barranquero <lekktu@gmail.com>
6941
6942 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6943
638f053a
JB
69442011-04-28 Juanma Barranquero <lekktu@gmail.com>
6945
6946 * keyboard.c (Qdelayed_warnings_hook): Define.
6947 (command_loop_1): Run `delayed-warnings-hook'
6948 if Vdelayed_warnings_list is non-nil.
6949 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6950 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6951
d178f871
EZ
69522011-04-28 Eli Zaretskii <eliz@gnu.org>
6953
6954 * doprnt.c (doprnt): Don't return value smaller than the buffer
6955 size if the message was truncated. (Bug#8545).
6956
b124fd93
JB
69572011-04-28 Juanma Barranquero <lekktu@gmail.com>
6958
6959 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6960 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6961
e810457d
PE
69622011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6963
6964 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6965
ea51cceb
JB
69662011-04-27 Juanma Barranquero <lekktu@gmail.com>
6967
6968 * makefile.w32-in: Update dependencies.
6969
94dcfacf
EZ
69702011-04-27 Eli Zaretskii <eliz@gnu.org>
6971
6972 Improve `doprnt' and its usage. (Bug#8545)
6973 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6974 `format_end'. Remove support for %l as a conversion specifier.
6975 Don't use xrealloc. Improve diagnostics when the %l size modifier
6976 is used. Update the commentary.
6977
6978 * eval.c (verror): Simplify calculation of size_t.
6979
6980 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6981 messages.
6982
f61f41d7
PE
69832011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6984
6985 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6986 change.
6987
96fb4434
PE
69882011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6989
6990 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6991 This makes this file independent of the recent pseudovector change.
6992
671875da 69932011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6994
69e9b5a3
PE
6995 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6996
b5f869a7 6997 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6998 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6999 Remove unused local.
c8926152 7000 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 7001
841a1577 7002 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
7003 GCC 4.6.0 optimizes based on type-based alias analysis.
7004 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
7005 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7006 != &v->size, and therefore "v->size = 1; b->size = 2; return
7007 v->size;" must therefore return 1. This assumption is incorrect
7008 for Emacs, since it type-puns struct Lisp_Vector * with many other
7009 types. To fix this problem, this patch adds a new type struct
f904488f 7010 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
7011 and pseudovectors, and helps optimizing compilers not get fooled
7012 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7013 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
7014 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7015 the size member.
eab3844f
PE
7016 (XSETPVECTYPE): Rewrite in terms of new macro.
7017 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7018 This is a bit clearer, and further avoids the possibility of
7019 undesirable aliasing.
7020 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 7021 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
7022 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7023 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
7024 (ASIZE): Now uses header.size rather than size.
7025 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7026 to avoid the hassle of writing XVECTOR (foo)->header.size.
7027 (struct vectorlike_header): New type.
eab3844f
PE
7028 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7029 object, to help avoid aliasing.
7030 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7031 (SUBRP): Likewise, since Lisp_Subr is a special case.
7032 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7033 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7034 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7035 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7036 changed to be "header.size" and "header.next".
7037 * buffer.h (struct buffer): Likewise.
7038 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7039 * frame.h (struct frame): Likewise.
7040 * process.h (struct Lisp_Process): Likewise.
7041 * termhooks.h (struct terminal): Likewise.
7042 * window.c (struct save_window_data, struct saved_window): Likewise.
7043 * window.h (struct window): Likewise.
7044 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7045 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7046 * buffer.c (init_buffer_once): Likewise.
7047 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7048 special case.
7049 * process.c (Fformat_network_address): Use local var for size,
7050 for brevity.
7051
0df1eac5
PE
7052 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7053
847ab9d1 7054 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7055 * data.c (atof): Remove decl; no longer used or needed.
7056 (digit_to_number): Move to lread.c.
7057 (Fstring_to_number): Use new string_to_number function, to be
7058 consistent with how the Lisp reader treats infinities and NaNs.
7059 Do not assume that floating-point numbers represent EMACS_INT
7060 without losing information; this is not true on most 64-bit hosts.
7061 Avoid double-rounding errors, by insisting on integers when
7062 parsing non-base-10 numbers, as the documentation specifies.
7063 * lisp.h (string_to_number): New decl, replacing ...
7064 (isfloat_string): Remove.
bc0a5c13 7065 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7066 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7067 appears to have been a coding error. Similarly, do not accept
7068 strings like +-1e0 as floating point numbers. Do not report
7069 overflow for integer overflows unless the base is not 10 which
7070 means we have no simple and reliable way to continue.
7071 Break out the floating-point parsing into a new
7072 function string_to_number, so that Fstring_to_number parses
7073 floating point numbers consistently with the Lisp reader.
04f2d78b 7074 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7075 (E_CHAR, EXP_INT): Remove, replacing with ...
7076 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7077 (string_to_number): New function, replacing isfloat_string.
7078 This function checks for valid syntax and produces the resulting
7079 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7080 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7081 so that overflow for non-base-10 numbers is reported only when
7082 there's no portable and simple way to convert to floating point.
452f4150 7083
67769ffc
PE
7084 * textprop.c (set_text_properties_1): Rewrite for clarity,
7085 and to avoid GCC warning about integer overflow.
7086
c20db43f
PE
7087 * intervals.h (struct interval): Use EMACS_INT for members
7088 where EMACS_UINT might cause problems. See
7089 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7090 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7091 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7092 All uses changed.
37aa2f85
PE
7093 (offset_intervals): Tell GCC not to worry about length overflow
7094 when negating a negative length.
c20db43f 7095
2538aa2f
PE
7096 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7097 (overrun_check_free): Likewise.
7098
f2d3008d
PE
7099 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7100 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7101 word size.
7102
ec8df744
PE
7103 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7104 (gnutls_make_error): Rename local to avoid shadowing.
7105 (gnutls_emacs_global_deinit): ifdef out; not used.
7106 (Fgnutls_boot): Use const for pointer to readonly storage.
7107 Comment out unused local. Fix pointer signedness problems.
7108
640ee02d
PE
7109 * lread.c (openp): Don't stuff size_t into an 'int'.
7110 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7111 about possible signed overflow.
7112
6048fb2a
PE
7113 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7114 (GDK_KEY_g): Don't define if already defined.
7115 (xg_prepare_tooltip): Avoid pointer signedness problem.
7116 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7117
fa3c87e1
PE
7118 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7119 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7120
2172544b
PE
7121 * xfns.c (Fx_window_property): Simplify a bit,
7122 to make a bit faster and to avoid GCC 4.6.0 warning.
7123 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7124
9b821a21
PE
7125 * fns.c (internal_equal): Don't assume size_t fits in int.
7126
3c616cfa
PE
7127 * alloc.c (compact_small_strings): Tighten assertion a little.
7128
c2982e87
PE
7129 Replace pEd with more-general pI, and fix some printf arg casts.
7130 * lisp.h (pI): New macro, generalizing old pEd macro to other
7131 conversion specifiers. For example, use "...%"pI"d..." rather
7132 than "...%"pEd"...".
7133 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7134 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7135 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7136 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7137 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7138 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7139 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7140 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7141 64-bit hosts.
7142 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7143 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7144 * print.c (safe_debug_print, print_object): Likewise.
7145 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7146 to int.
6f04d126
PE
7147 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7148 avoiding the 0 flag, which is not portable.
c2982e87
PE
7149 * process.c (Fmake_network_process): Use pI to avoid cast.
7150 * region-cache.c (pp_cache): Likewise.
7151 * xdisp.c (decode_mode_spec): Likewise.
7152 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7153 behavior on 64-bit hosts with printf arg.
6f04d126 7154 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7155 (x_stop_queuing_selection_requests): Likewise.
7156 (x_get_window_property): Don't truncate byte count to an 'int'
7157 when tracing.
0b432f21 7158
5e073ec7
PE
7159 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7160 here, since it parses constructs like leading '-' and spaces,
7161 which are not wanted; and it overflows with large numbers.
7162 Instead, simply match F[0-9]+, which is what is wanted anyway.
7163
36372bf9
PE
7164 * alloc.c: Remove unportable assumptions about struct layout.
7165 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7166 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7167 (allocate_vectorlike, make_pure_vector): Use the new macros,
7168 plus offsetof, to remove unportable assumptions about struct layout.
7169 These assumptions hold on all porting targets that I know of, but
7170 they are not guaranteed, they're easy to remove, and removing them
7171 makes further changes easier.
7172
0b432f21
PE
7173 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7174 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7175 (string_overrun_cookie): Now const. Use initializers that
7176 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7177 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7178 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7179 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7180 multiple of sizeof (EMACS_INT); it need not be, if
7181 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7182 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7183
895009e1
JB
71842011-04-26 Juanma Barranquero <lekktu@gmail.com>
7185
7186 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7187
6a7a1b0b
TZ
71882011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7189
7190 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7191 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7192 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7193
841a1577 71942011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7195
7196 * lisp.h (Qdebug): List symbol.
895009e1 7197 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7198 * keyboard.c (debug-on-event): New variable.
7199 (handle_user_signal): Break into debugger when debug-on-event
7200 matches the current signal symbol.
7201
f2d3ba6f
DN
72022011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7203
7204 * alloc.c (check_sblock, check_string_bytes)
7205 (check_string_free_list): Convert to standard C.
7206
42ce4c63
TZ
72072011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7208
7209 * w32.c (emacs_gnutls_push): Fix typo.
7210
825cd63c
EZ
72112011-04-25 Eli Zaretskii <eliz@gnu.org>
7212
fb11d64d
EZ
7213 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7214 "cast to pointer from integer of different size".
7215
825cd63c
EZ
7216 Improve doprnt and its use in verror. (Bug#8545)
7217 * doprnt.c (doprnt): Document the set of format control sequences
7218 supported by the function. Use SAFE_ALLOCA instead of always
7219 using `alloca'.
7220
7221 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7222 is one byte too soon. Don't use xrealloc; instead xfree and
7223 xmalloc anew.
7224
e061a11b
TZ
72252011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7226
7227 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7228 callbacks stage.
7229
7230 * gnutls.c: Renamed global_initialized to
7231 gnutls_global_initialized. Added internals for the
7232 :verify-hostname-error, :verify-error, and :verify-flags
7233 parameters of `gnutls-boot' and documented those parameters in the
7234 docstring. Start callback support.
9173deec
JB
7235 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7236 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7237 on error. Return error code.
e061a11b
TZ
7238 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7239 (emacs_gnutls_read): Likewise.
7240 (Fgnutls_boot): Return handshake error code.
7241 (emacs_gnutls_handle_error): New function.
7242 (wsaerror_to_errno): Likewise.
7243
7244 * w32.h (emacs_gnutls_pull): Add prototype.
7245 (emacs_gnutls_push): Likewise.
7246
7247 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7248 (emacs_gnutls_push): Likewise.
7249
72502011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7251
7252 * process.c (wait_reading_process_output): Check if GnuTLS
7253 buffered some data internally if no FDs are set for TLS
7254 connections.
7255
7256 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7257 (LIBS): Link to USER_LIBS.
7258 ($(BLD)/gnutls.$(0)): New target.
7259
fa6996bc
EZ
72602011-04-24 Eli Zaretskii <eliz@gnu.org>
7261
eb35682e
EZ
7262 * xdisp.c (handle_single_display_spec): Rename the
7263 display_replaced_before_p argument into display_replaced_p, to
7264 make it consistent with the commentary. Fix typos in the
7265 commentary.
7266
e2ad650c
EZ
7267 * textprop.c (syms_of_textprop): Remove dead code.
7268 (copy_text_properties): Delete obsolete commentary about an
7269 interface that was deleted long ago. Fix typos in the description
7270 of arguments.
7271
1b2de274
EZ
7272 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7273 to changes in oldXMenu/XMenu.h from 2011-04-16.
7274 <menu_help_message, prev_menu_help_message>: Constify.
7275 (IT_menu_make_room): menu->help_text is now `const char **';
7276 adjust.
7277
7278 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7279 to changes in oldXMenu/XMenu.h from 2011-04-16.
7280 (struct XMenu): Declare `help_text' `const char **'.
7281
7282 * xfaces.c <Qunspecified>: Make extern again.
7283
7284 * syntax.c: Include sys/types.h before including regex.h, as
7285 required by Posix.
7286
762b15be
EZ
7287 * doc.c (get_doc_string): Improve the format passed to `error'.
7288
7289 * doprnt.c (doprnt): Improve commentary.
7290
7291 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7292
7293 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7294 them with etags.
7295
f1052e5d
EZ
7296 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7297 changes in globals.h immediately force recompilation.
762b15be
EZ
7298 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7299 $(CURDIR)/s/ms-w32.h.
7300 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7301
fa6996bc
EZ
7302 * character.c (Fchar_direction): Function deleted.
7303 (syms_of_character): Don't defsubr it.
7304 <char-direction-table>: Deleted.
7305
e6c3da20
EZ
73062011-04-23 Eli Zaretskii <eliz@gnu.org>
7307
7308 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7309 * doprnt.c: Include limits.h.
7310 (SIZE_MAX): New macro.
04f2d78b
CB
7311 (doprnt): Return a size_t value. 2nd arg is now size_t.
7312 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7313 Improve overflow protection. Support `l' modifier for integer
7314 conversions. Support %l conversion. Don't assume an EMACS_INT
7315 argument for integer conversions and for %c.
7316
7317 * lisp.h (doprnt): Restore prototype.
7318
7319 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7320 $(SRC)/character.h.
7321
7322 * Makefile.in (base_obj): Add back doprnt.o.
7323
7324 * deps.mk (doprnt.o): Add back prerequisites.
7325 (callint.o): Depend on character.h.
7326
7327 * eval.c (internal_lisp_condition_case): Include the handler
7328 representation in the error message.
7329 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7330 when breaking from the loop.
7331
7332 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7333
7334 * callint.c (Fcall_interactively): When displaying error message
7335 about invalid control letter, pass the character's codepoint, not
7336 a pointer to its multibyte form. Improve display of the character
7337 in octal and display also its hex code.
7338
7339 * character.c (char_string): Use %x to display the (unsigned)
7340 codepoint of an invalid character, to avoid displaying a bogus
7341 negative value.
7342
7343 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7344 `error', not SYMBOL_NAME itself.
7345
7346 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7347 character arguments to `error'.
7348
7349 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7350 to `error' in error message about FINAL_CHAR argument. Make sure
7351 FINAL_CHAR is a character, and use %c when it is passed as
7352 argument to `error'.
7353
4ffd0d6b 73542011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7355
7356 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7357
7358 * w32.c: Include <time.h>.
7359 (sys_localtime): New function.
7360
4ffd0d6b 73612011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7362
7363 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7364
4ffd0d6b 7365 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7366
4ffd0d6b 73672011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7368
4ffd0d6b
GM
7369 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7370 zombies (Bug#8467).
aac0c6e3 7371
04c56954
EZ
73722011-04-19 Eli Zaretskii <eliz@gnu.org>
7373
7374 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7375 gl_state.e_property when gl_state.object is Qt.
7376
7377 * insdel.c (make_gap_larger): Remove limitation of buffer size
7378 to <= INT_MAX.
7379
16a43933
CY
73802011-04-18 Chong Yidong <cyd@stupidchicken.com>
7381
7382 * xdisp.c (lookup_glyphless_char_display)
7383 (produce_glyphless_glyph): Handle cons cell entry in
7384 glyphless-char-display.
7385 (Vglyphless_char_display): Document it.
7386
7387 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7388 glyphless-char-display.
7389
4581706e
CY
73902011-04-17 Chong Yidong <cyd@stupidchicken.com>
7391
7392 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7393
7394 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7395
7396 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7397 definition for no-X builds.
7398
4887c6e2 73992011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7400
fd35b6f9
PE
7401 Static checks with GCC 4.6.0 and non-default toolkits.
7402
5c1ccb01
PE
7403 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7404
006c5daa
PE
7405 * process.c (keyboard_bit_set): Define only if SIGIO.
7406 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7407 (send_process): Repair possible setjmp clobbering.
7408
efc736d3
PE
7409 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7410
4e2fe2e6
PE
7411 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7412
f97334a2
PE
7413 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7414
4e75f29d
PE
7415 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7416 Define only if needed.
7417
90efadd1
PE
7418 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7419 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7420 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7421
3c647824
PE
7422 * dispextern.h (struct redisplay_interface): Rename param
7423 to avoid shadowing.
e264f262 7424 * termhooks.h (struct terminal): Likewise.
761383f4 7425 * xterm.c (xembed_send_message): Likewise.
3c647824 7426
b58c5c4a
PE
7427 * insdel.c (make_gap_smaller): Define only if
7428 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7429
cad59032
PE
7430 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7431 it.
7432
c339dc2e
PE
7433 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7434 so that we aren't warned about unused symbols.
7435
91a3e27b
PE
7436 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7437
399c71d3 7438 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7439
8ffc96f5
PE
7440 * xfns.c (x_real_positions): Mark locals as initialized.
7441
eef9bc79
PE
7442 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7443
098db9dd
PE
7444 * xterm.c: Fix problems found by static analysis with other toolkits.
7445 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7446 (x_dispatch_event): Declare static if USE_GTK, and
7447 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7448 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7449 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7450 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7451 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7452
eb18f6cc
PE
7453 * xmenu.c (menu_help_callback): Pointer type fixes.
7454 Use const pointers when pointing at readonly data. Avoid pointer
7455 signedness clashes.
7456 (FALSE): Remove unused macro.
7457 (update_frame_menubar): Remove unused decl.
7458
1fe72bf8
PE
7459 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7460
60d9e1db
PE
7461 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7462 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7463 (single_menu_item): Rename local to avoid shadowing.
7464
39261c26
PE
7465 * keyboard.c (make_lispy_event): Remove unused local var.
7466
018c5e19
PE
7467 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7468 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7469
63d2b86e
PE
7470 * bitmaps: Change bitmaps from unsigned char back to the X11
7471 compatible char. Avoid the old compiler warnings about
7472 out-of-range initializers by using, for example, '\xab' rather
7473 than 0xab.
7474
aefd87e1
PE
7475 * xgselect.c (xgselect_initialize): Check vs interface
7476 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7477
bf501fb9
PE
7478 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7479
e9829fdf
PE
7480 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7481 to read-only memory.
7482
1086c095
PE
7483 * fns.c (vector): Remove; this old hack is no longer needed.
7484
2baccd04 7485 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7486 Remove unused var.
dde42981 7487 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7488
72391843 7489 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7490
436c16df 7491 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7492 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7493 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7494
92bb796d 7495 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7496 (x_term_init): Remove local to avoid shadowing.
92bb796d 7497
764430a3 7498 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7499
7500 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7501 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7502
d1dfb56c
EZ
75032011-04-16 Eli Zaretskii <eliz@gnu.org>
7504
c4354cb4
EZ
7505 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7506
d1dfb56c
EZ
7507 Fix regex.c, syntax.c and friends for buffers > 2GB.
7508 * syntax.h (struct gl_state_s): Declare character position members
7509 EMACS_INT.
7510
7511 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7512
04f2d78b
CB
7513 * textprop.c (verify_interval_modification, interval_of):
7514 Declare arguments EMACS_INT.
d1dfb56c
EZ
7515
7516 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7517 EMACS_INT.
7518
7519 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7520
7521 * indent.c (Fvertical_motion): Local variable it_start is now
7522 EMACS_INT.
7523
7524 * regex.c (re_match, re_match_2, re_match_2_internal)
7525 (bcmp_translate, regcomp, regexec, print_double_string)
7526 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7527 (re_compile_pattern, re_exec): Declare arguments and local
7528 variables `size_t' and `ssize_t' and return values `regoff_t', as
7529 appropriate.
7530 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7531 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7532 <compile_stack_type>: `size' and `avail' are now `size_t'.
7533
7534 * regex.h <regoff_t>: Use ssize_t, not int.
7535 (re_search, re_search_2, re_match, re_match_2): Arguments that
7536 specify buffer/string position and length are now ssize_t and
7537 size_t. Return type is regoff_t.
7538
613052cd
BK
75392011-04-16 Ben Key <bkey76@gmail.com>
7540
7541 * nsfont.m: Fixed bugs in ns_get_family and
7542 ns_descriptor_to_entity that were caused by using free to
7543 deallocate memory blocks that were allocated by xmalloc (via
7544 xstrdup). This caused Emacs to crash when compiled with
7545 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7546 --enable-checking=xmallocoverrun). xfree is now used to
7547 deallocate these memory blocks.
7548
4170f62f 75492011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7550
71b41406
PE
7551 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7552
9587a89d
PE
7553 emacs_write: Accept and return EMACS_INT for sizes.
7554 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7555 et seq.
7556 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7557 Accept and return EMACS_INT.
7558 (emacs_gnutls_write): Return the number of bytes written on
7559 partial writes.
7560 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7561 (emacs_read, emacs_write): Remove check for negative size, as the
7562 Emacs source code has been audited now.
9587a89d
PE
7563 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7564 (emacs_read, emacs_write): Use it.
273a5f82
PE
7565 * process.c (send_process): Adjust to the new signatures of
7566 emacs_write and emacs_gnutls_write. Do not attempt to store
7567 a byte offset into an 'int'; it might overflow.
9587a89d 7568 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7569
3e047f51
PE
7570 * sound.c: Don't assume sizes fit in 'int'.
7571 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7572 Return EMACS_INT, not int.
3e047f51 7573 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7574 Accept EMACS_INT, not int.
7575 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7576 record read return values.
7577
cc39a9db
BK
75782011-04-15 Ben Key <bkey76@gmail.com>
7579
c9d0ec6d
JB
7580 * keyboard.c (Qundefined): Don't declare static since it is used
7581 in nsfns.m.
7582 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7583 static since they are used in nsfont.m.
cc39a9db 7584
6c60eb9f
SM
75852011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7586
7587 * process.c (Qprocessp): Don't declare static.
7588 * lisp.h (Qprocessp): Declare again.
7589
7990b61a
JB
75902011-04-15 Juanma Barranquero <lekktu@gmail.com>
7591
7592 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7593
5d4cb038
PE
75942011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7595
8bd7b830 7596 Improve C-level modularity by making more things 'static'.
cd64ea1d 7597
e3b27b31
PE
7598 Don't publish debugger-only interfaces to other modules.
7599 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7600 (verify_bytepos, count_markers): Move decls to the only modules
7601 that need them.
7602 * region-cache.h (pp_cache): Likewise.
7603 * window.h (check_all_windows): Likewise.
7604 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7605
5d4cb038
PE
7606 * sysdep.c (croak): Now static, if
7607 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7608 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7609
7610 * alloc.c (refill_memory_reserve): Now static if
7611 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7612 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7613
e87b6180
PE
7614 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7615 Define only if USE_LUCID.
7616
ac64929e
PE
7617 * xrdb.c (x_customization_string, x_rm_string): Now static.
7618
6f37259d
PE
7619 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7620 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7621
1683e3ab
PE
7622 * xdisp.c (draw_row_with_mouse_face): Now static.
7623 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7624
de9c2632
PE
7625 * window.h (check_all_windows): Mark externally visible.
7626
2b96acb7
PE
7627 * window.c (window_deletion_count): Now static.
7628
7629 * undo.c: Make symbols static if they're not exported.
7630 (last_undo_buffer, last_boundary_position, pending_boundary):
7631 Now static.
7632
50436f33
PE
7633 * textprop.c (interval_insert_behind_hooks): Now static.
7634 (interval_insert_in_front_hooks): Likewise.
7635
64520e5c
PE
7636 * term.c: Make symbols static if they're not exported.
7637 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7638 (max_frame_lines, tty_set_terminal_modes):
7639 (tty_reset_terminal_modes, tty_turn_off_highlight):
7640 (get_tty_terminal): Now static.
7641 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7642 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7643 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7644 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7645 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7646
1fa53021
PE
7647 * sysdep.c: Make symbols static if they're not exported.
7648 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7649 Now static.
7650 (sigprocmask_set, full_mask): Remove; unused.
7651 (wait_debugging): Mark as visible.
7652 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7653 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7654
d4b43b22
PE
7655 * syntax.c (syntax_temp): Define only if !__GNUC__.
7656
b7c513d0
PE
7657 * sound.c (current_sound_device, current_sound): Now static.
7658
989b29ad
PE
7659 * search.c (searchbufs, searchbuf_head): Now static.
7660
13a55a78
PE
7661 * scroll.c (scroll_cost): Remove; unused.
7662 * dispextern.h (scroll_cost): Remove decl.
7663
de68a1fc
PE
7664 * region-cache.h (pp_cache): Mark as externally visible.
7665
40ccffa6
PE
7666 * process.c: Make symbols static if they're not exported.
7667 (process_tick, update_tick, create_process, chan_process):
7668 (Vprocess_alist, proc_buffered_char, datagram_access):
7669 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7670 (deactivate_process): Mark defn as static, as well as decl.
7671 * lisp.h (create_process): Remove decl.
7672 * process.h (chan_process, Vprocess_alist): Remove decls.
7673
ad64fc97
PE
7674 * print.c: Make symbols static if they're not exported.
7675 (print_depth, new_backquote_output, being_printed, print_buffer):
7676 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7677 (print_interval, print_number_index, initial_stderr_stream):
7678 Now static.
7679 * lisp.h (Fprinc): Remove decl.
7680 (debug_output_compilation_hack): Mark as externally visible.
7681
adddb265
PE
7682 * sysdep.c (croak): Move decl from here to syssignal.h.
7683 * syssignal.h (croak): Put it here, so the API can be checked when
7684 'croak' is called from dissociate_if_controlling_tty.
7685
1717ede2
PE
7686 * minibuf.c: Make symbols static if they're not exported.
7687 (minibuf_save_list, choose_minibuf_frame): Now static.
7688 * lisp.h (choose_minibuf_frame): Remove decl.
7689
fa5fb2bc
PE
7690 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7691
1e3890d1
PE
7692 * lread.c: Make symbols static if they're not exported.
7693 (read_objects, initial_obarray, oblookup_last_bucket_number):
7694 Now static.
7695 (make_symbol): Remove; unused.
7696 * lisp.h (initial_obarray, make_symbol): Remove decls.
7697
8a1414fa
PE
7698 * keyboard.c: Make symbols static if they're not exported.
7699 (single_kboard, recent_keys_index, total_keys, recent_keys):
7700 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7701 (this_single_command_key_start, echoing, last_auto_save):
7702 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7703 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7704 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7705 (Vlispy_mouse_stem, double_click_count):
7706 Now static.
7707 (force_auto_save_soon): Define only if SIGDANGER.
7708 (ignore_mouse_drag_p): Now static if
7709 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7710 (print_help): Remove; unused.
7711 (stop_character, last_timer_event): Mark as externally visible.
7712 * keyboard.h (ignore_mouse_drag_p): Declare only if
7713 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7714 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7715 * lisp.h (echoing): Remove decl.
7716 (force_auto_save_soon): Declare only if SIGDANGER.
7717 * xdisp.c (redisplay_window): Simplify code, to make it more
7718 obvious that ignore_mouse_drag_p is not accessed if !defined
7719 USE_GTK && !defined HAVE_NS.
7720
93ea6e8f
PE
7721 * intervals.c: Make symbols static if they're not exported.
7722 (merge_properties_sticky, merge_interval_right, delete_interval):
7723 Now static.
7724 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7725
77382fcc
PE
7726 * insdel.c: Make symbols static if they're not exported.
7727 However, leave prepare_to_modify_buffer alone. It's never
7728 called from outside this function, but that appears to be a bug.
7729 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7730 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7731 (adjust_after_replace_noundo): Remove; unused.
7732 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7733 (signal_before_change): Remove decls.
77382fcc 7734
9306c32e
PE
7735 * indent.c (val_compute_motion, val_vmotion): Now static.
7736
cd44d2eb
PE
7737 * image.c: Make symbols static if they're not exported.
7738 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7739 if USE_GTK.
7740 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7741 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7742
ad9a7a06
PE
7743 * fringe.c (standard_bitmaps): Now static.
7744 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7745
81626931
PE
7746 * frame.c: Make symbols static if they're not exported.
7747 (x_report_frame_params, make_terminal_frame): Now static.
7748 (get_frame_param): Now static, unless HAVE_NS.
7749 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7750 (x_get_resource_string): Remove; not used.
7751 * frame.h (make_terminal_frame, x_report_frame_params):
7752 (x_get_resource_string); Remove decls.
7753 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7754 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7755
239f9db9
PE
7756 * font.c, fontset.c: Make symbols static if they're not exported.
7757 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7758 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7759 * font.c (font_close_object): Now static.
7760 * font.h (font_close_object): Remove.
7761 * fontset.c (FONTSET_OBJLIST): Remove.
7762 (free_realized_fontset) #if-0 the body, which does nothing.
7763 (face_suitable_for_char_p): #if-0, as it's never called.
7764 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7765 * xfaces.c (face_at_string_position):
7766 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7767 since 0 is always ASCII.
7768
dfcf3579
PE
7769 * fns.c (weak_hash_tables): Now static.
7770
5045092b
PE
7771 * fileio.c: Make symbols static if they're not exported.
7772 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7773 (Vwrite_region_annotation_buffers): Now static.
7774
57a96f5c
PE
7775 * eval.c: Make symbols static if they're not exported.
7776 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7777 * lisp.h (backtrace_list): Remove decl.
7778
35f08c38
PE
7779 * emacs.c: Make symbols static if they're not exported.
7780 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7781 (fatal_error_code, fatal_error_signal_hook, standard_args):
7782 Now static.
7783 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7784 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7785 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7786 * lisp.h (fatal_error_signal_hook): Remove decl.
7787 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7788
f44bd759
PE
7789 * editfns.c: Move a (normally-unused) function to its only use.
7790 * editfns.c, lisp.h (get_operating_system_release): Remove.
7791 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7792 worth the hassle of breaking this out.
7793
b532497d
PE
7794 * xterm.c: Make symbols static if they're not exported.
7795 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7796 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7797 (x_destroy_window, x_delete_display):
7798 Now static.
7799 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7800 (x_mouse_leave): Remove; unused.
7801 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7802 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7803 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7804 Remove decls.
7805 (x_mouse_leave): Declare only if WINDOWSNT.
7806 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7807 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7808 USE_X_TOOLKIT.
7809
1675728f
PE
7810 * ftxfont.c: Make symbols static if they're not exported.
7811 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7812 HAVE_FREETYPE.
7813 * font.h (ftxfont_driver): Likewise.
7814
e4cebfca
PE
7815 * xfns.c: Make symbols static if they're not exported.
7816 (x_last_font_name, x_display_info_for_name):
7817 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7818 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7819 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7820 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7821 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7822 (last_show_tip_args): Now static.
7823 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7824 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7825 (x_screen_planes): Remove; unused.
7826 * dispextern.h (x_screen_planes): Remove decl.
7827
5bf46f05
PE
7828 * dispnew.c: Make symbols static if they're not exported.
7829 * dispextern.h (redraw_garbaged_frames, scrolling):
7830 (increment_row_positions): Remove.
7831 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7832 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7833 Now static.
7834 (redraw_garbaged_frames): Remove; unused.
7835
435f4c28
PE
7836 * xfaces.c: Make symbols static if they're not exported.
7837 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7838 Remove decls.
7839 * xterm.h (defined_color): Remove decls.
7840 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7841 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7842 (menu_face_changed_default, defined_color, free_realized_face):
7843 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7844 (ascii_face_of_lisp_face): Remove; unused.
7845
8524aef3
PE
7846 * xdisp.c: Make symbols static if they're not exported.
7847 * dispextern.h (scratch_glyph_row, window_box_edges):
7848 (glyph_to_pixel_coords, set_cursor_from_row):
7849 (get_next_display_element, set_iterator_to_next):
7850 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7851 (show_mouse_face): Remove decls
7852 * frame.h (message_buf_print): Likewise.
7853 * lisp.h (pop_message, set_message, check_point_in_composition):
7854 Likewise.
7855 * xterm.h (set_vertical_scroll_bar): Likewise.
7856 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7857 (message_buf_print, scratch_glyph_row, displayed_buffer):
7858 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7859 (get_next_display_element, show_mouse_face, window_box_edges):
7860 (frame_to_window_pixel_xy, check_point_in_composition):
7861 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7862 (glyph_to_pixel_coords): Remove; unused.
7863
16390cd2
PE
7864 * dired.c (file_name_completion): Now static.
7865
7866 * dbusbind.c (xd_in_read_queued_messages): Now static.
7867
a25f4dfa
PE
7868 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7869 * data.c (circular_list_error): Remove.
7870
14a9c8df
PE
7871 * commands.h (last_point_position, last_point_position_buffer):
7872 (last_point_position_window): Remove decls.
7873 * keyboard.c: Make these variables static.
7874
04f2d78b
CB
7875 * coding.h (coding, code_convert_region, encode_coding_gap):
7876 Remove decls.
74ab6df5
PE
7877 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7878 (iso_code_class, detect_coding, code_convert_region): Now static.
7879 (encode_coding_gap): Remove; unused.
7880
38dfbee1
PE
7881 * chartab.c (chartab_chars, chartab_bits): Now static.
7882
a2cb4e63
PE
7883 * charset.h (charset_iso_8859_1): Remove decl.
7884 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7885 Now static.
7886
127198fd
PE
7887 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7888 * ccl.c (Vccl_program_table): Now static.
7889 (check_ccl_update): Remove; unused.
7890
d85b608f
PE
7891 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7892 * category.h: ... from here.
7893 * category.c (check_category_table, set_category_set): Now static.
7894
31cd66f3
PE
7895 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7896 * lisp.h: Remove these decls.
7897
c358e587
PE
7898 * buffer.c (buffer_count): Remove unused var.
7899
e78aecca
PE
7900 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7901 so that it's not optimized away.
7902 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7903 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7904 exported only to the debugger.
7905
e192d7d3 7906 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7907 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7908
92470028
PE
7909 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7910 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7911 was inaccessible from Lisp.
7912 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7913 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7914
244ed907
PE
7915 alloc.c: Import and export fewer symbols, and remove unused items.
7916 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7917 is defined.
7918 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7919 it's not optimized away by whole-program optimization.
7920 (message_enable_multibyte, free_misc): Remove.
7921 (catchlist, handlerlist, mark_backtrace):
7922 Declare only if BYTE_MARK_STACK.
7923 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7924 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7925 (message_enable_multibyte): Remove decl.
7926 (free_misc, interval_free_list, float_block, float_block_index):
7927 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7928 (cons_free_list, last_marked_index):
7929 Now static.
7930 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7931 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7932 (mark_backtrace): Define only if BYTE_MARK_STACK.
7933 * xdisp.c (message_enable_multibyte): Now static.
7934
61c2b50e 7935 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7936 This makes it easier for human readers (and static analyzers)
7937 to see whether these variables are used from other modules.
7938 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7939 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7940 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7941 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7942 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7943 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7944 * xmenu.c, xselect.c:
7945 Declare Q* vars static if they are not used in other modules.
7946 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7947 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7948 Remove decls of unexported vars.
7949 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7950
95c82688
PE
7951 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7952
16a97296
PE
7953 Make Emacs functions such as Fatom 'static' by default.
7954 This makes it easier for human readers (and static analyzers)
7955 to see whether these functions can be called from other modules.
7956 DEFUN now defines a static function. To make the function external
7957 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7958 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7959 (Finit_image_library):
16a97296
PE
7960 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7961 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7962 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7963 Remove decls, since these functions are now static.
7964 (Funintern, Fget_internal_run_time): New decls, since these functions
7965 were already external.
95c82688 7966
16a97296
PE
7967 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7968 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7969 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7970 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7971 * keyboard.c, keymap.c, lread.c:
7972 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7973 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7974 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7975 Mark functions with DEFUE instead of DEFUN,
7976 if they are used in other modules.
7977 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7978 decls for now-static functions.
7979 * buffer.h (Fdelete_overlay): Remove decl.
7980 * callproc.c (Fgetenv_internal): Mark as internal.
7981 * composite.c (Fremove_list_of_text_properties): Remove decl.
7982 (Fcomposition_get_gstring): New forward static decl.
7983 * composite.h (Fcomposite_get_gstring): Remove decl.
7984 * dired.c (Ffile_attributes): New forward static decl.
7985 * doc.c (Fdocumntation_property): New forward static decl.
7986 * eval.c (Ffetch_bytecode): New forward static decl.
7987 (Funintern): Remove extern decl; now in .h file where it belongs.
7988 * fileio.c (Fmake_symbolic_link): New forward static decl.
7989 * image.c (Finit_image_library): New forward static decl.
7990 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7991 * intervals.h (Fprevious_property_change):
7992 (Fremove_list_of_text_properties): Remove decls.
7993 * keyboard.c (Fthis_command_keys): Remove decl.
7994 (Fcommand_execute): New forward static decl.
7995 * keymap.c (Flookup_key): New forward static decl.
7996 (Fcopy_keymap): Now static.
7997 * keymap.h (Flookup_key): Remove decl.
7998 * process.c (Fget_process): New forward static decl.
7999 (Fprocess_datagram_address): Mark as internal.
8000 * syntax.c (Fsyntax_table_p): New forward static decl.
8001 (skip_chars): Remove duplicate decl.
8002 * textprop.c (Fprevious_property_change): New forward static decl.
8003 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8004 Now internal.
8005 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8006 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8007
785bbd42
PE
8008 * editfns.c (Fformat): Remove unreachable code.
8009
8b913b57
AS
80102011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8011
8012 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8013 change. (Bug#8496)
8014
a6744a35
EZ
80152011-04-13 Eli Zaretskii <eliz@gnu.org>
8016
8017 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8018 when at ZV. (Bug#8487)
8019
e7974947
AS
80202011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8021
baad03f0
AS
8022 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8023 (Bug#8437)
8024 * keyboard.c (parse_tool_bar_item): Likewise.
8025 * sound.c (sound_cleanup, alsa_close): Likewise.
8026 * termcap.c (tgetent): Likewise.
8027 * xfns.c (x_default_font_parameter): Likewise.
8028 * xsettings.c (read_and_apply_settings): Likewise.
8029
e7974947
AS
8030 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8031 (overrun_check_free): Protoize.
8032
28272684
PE
80332011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8034
8035 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8036 since callers should never pass a negative size.
8037 Change the signature to match that of plain 'read' and 'write'; see
8038 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8039 * lisp.h: Update prototypes of emacs_write and emacs_read.
8040
11997c76
EZ
80412011-04-11 Eli Zaretskii <eliz@gnu.org>
8042
8043 * xdisp.c (redisplay_window): Don't try to determine the character
8044 position of the scroll margin if the window start point w->startp
e896f03c 8045 is outside the buffer's accessible region. (Bug#8468)
11997c76 8046
8a2cbd72
EZ
80472011-04-10 Eli Zaretskii <eliz@gnu.org>
8048
8049 Fix write-region and its subroutines for buffers > 2GB.
8050 * fileio.c (a_write, e_write): Modify declaration of arguments and
8051 local variables to support buffers larger than 2GB.
8052 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8053
8054 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8055 argument, local variables, and return value.
8056
8057 * lisp.h: Update prototypes of emacs_write and emacs_read.
8058
8059 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8060
4073e537 80612011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8062
1ebfdcb6
PE
8063 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8064
b2ded58d
PE
8065 Fix more problems found by GCC 4.6.0's static checks.
8066
7d66342c
PE
8067 * xdisp.c (vmessage): Use a better test for character truncation.
8068
bbf47d44
PE
8069 * charset.c (load_charset_map): <, not <=, for optimization,
8070 and to avoid potential problems with integer overflow.
9248994d 8071 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8072 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8073 * editfns.c (Fformat): Likewise.
1e69125e 8074 * syntax.c (skip_chars): Likewise.
3befa583 8075
e3019616
PE
8076 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8077 This also lets GCC 4.6.0 generate slightly better loop code.
8078
becfa255
PE
8079 * callint.c (Fcall_interactively): <, not <=, for optimization.
8080 (Fcall_interactively): Count the number of arguments produced,
8081 not the number of arguments given. This is simpler and lets GCC
8082 4.6.0 generate slightly better code.
8083
dae0cd48
PE
8084 * ftfont.c: Distingish more carefully between FcChar8 and char.
8085 The previous code passed unsigned char * to a functions like
8086 strlen and xstrcasecmp that expect char *, which does not
8087 conform to the C standard.
8088 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8089 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8090 char * when the C standard requires it.
8091
76032d70
PE
8092 * keyboard.c (read_char): Remove unused var.
8093
eb3f1cc8
PE
8094 * eval.c: Port to Windows vsnprintf (Bug#8435).
8095 Include <limits.h>.
8096 (SIZE_MAX): Define if the headers do not.
8097 (verror): Do not give up if vsnprintf returns a negative count.
8098 Instead, grow the buffer. This ports to Windows vsnprintf, which
8099 does not conform to C99. Problem reported by Eli Zaretskii.
8100 Also, simplify the allocation scheme, by avoiding the need for
8101 calling realloc, and removing the ALLOCATED variable.
8102
70476b54
PE
8103 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8104
12020a9e
PE
8105 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8106 But keep the doprint source code for now, as we might revamp it
8107 and use it again (Bug#8435).
ea6c7ae6
PE
8108 * lisp.h (doprnt): Remove.
8109 * Makefile.in (base_obj): Remove doprnt.o.
8110 * deps.mk (doprnt.o): Remove.
8111
5fdb398c
PE
8112 error: Print 32- and 64-bit integers portably (Bug#8435).
8113 Without this change, on typical 64-bit hosts error ("...%d...", N)
8114 was used to print both 32- and 64-bit integers N, which relied on
8115 undefined behavior.
61bdb816 8116 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8117 * lisp.h (error, verror): Mark as printf-like functions.
8118 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8119 Report overflow in size calculations when allocating printf buffer.
8120 Do not truncate output string at its first null byte.
8121 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8122 Truncate the output at a character boundary, since vsnprintf does not
8123 do that.
8124 * charset.c (check_iso_charset_parameter): Convert internal
8125 character to string before calling 'error', since %c now has the
8126 printf meaning.
8127 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8128 overflow when computing char to be passed to 'error'. Do not
8129 pass Lisp_Object to 'error'; pass the integer instead.
8130 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8131 formatted with plain %d.
8132
b189fa66
PE
8133 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8134
bff87ef0
PE
8135 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8136
7e2cac20
PE
8137 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8138
ce4d90b5
PE
8139 * xterm.c (x_catch_errors): Remove duplicate declaration.
8140
266c9547
PE
8141 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8142
79c49ad2
PE
8143 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8144
368f4090
JM
81452011-04-10 Jim Meyering <meyering@redhat.com>
8146
8147 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8148 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8149 return ssize_t not "int", and use size_t as the buffer length.
8150 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8151 * gnutls.h: Update declarations.
8152 * process.c (read_process_output): Use ssize_t, to match.
8153 (send_process): Likewise.
8154
a32d4040
CY
81552011-04-09 Chong Yidong <cyd@stupidchicken.com>
8156
8157 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8158
8546720e 81592011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8160
04f2d78b
CB
8161 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8162 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8163
8546720e
GM
8164 * xterm.c (handle_one_xevent):
8165 * xmenu.c (create_and_show_popup_menu):
8166 * xselect.c (x_decline_selection_request)
8167 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8168
0a2f5c1a 81692011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8170
8171 Fix some uses of `int' instead of EMACS_INT.
8172 * search.c (string_match_1, fast_string_match)
8173 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8174 (scan_buffer, find_next_newline_no_quit)
8175 (find_before_next_newline, search_command, Freplace_match)
8176 (Fmatch_data): Make some `int' variables be EMACS_INT.
8177
8178 * xdisp.c (display_count_lines): 3rd argument and return value now
8179 EMACS_INT. All callers changed.
8180 (pint2hrstr): Last argument is now EMACS_INT.
8181
8182 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8183 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8184 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8185 (decode_coding_utf_16, decode_coding_emacs_mule)
8186 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8187 (decode_coding_ccl, decode_coding_charset)
8188 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8189 (decode_coding_iso_2022, decode_coding_emacs_mule)
8190 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8191 <char_offset, last_offset>: Declare EMACS_INT.
8192 (encode_coding_utf_8, encode_coding_utf_16)
8193 (encode_coding_emacs_mule, encode_invocation_designation)
8194 (encode_designation_at_bol, encode_coding_iso_2022)
8195 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8196 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8197 Declare EMACS_INT.
8198 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8199 (encode_invocation_designation): Last argument P_NCHARS is now
8200 EMACS_INT.
8201 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8202 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8203
8204 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8205 All users changed.
8206
8207 * ccl.c (Fccl_execute_on_string): Declare some variables
8208 EMACS_INT.
8209
8546720e 82102011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8211
8212 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8213
4e19a977
CS
82142011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8215
8216 * process.c (Fformat_network_address): Doc fix.
8217
87302331
R
82182011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8219
ee7683eb 8220 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8221
cbb59342
CY
82222011-04-08 Chong Yidong <cyd@stupidchicken.com>
8223
8224 * keyboard.c (read_char): Call Lisp function help-form-show,
8225 instead of using internal_with_output_to_temp_buffer.
8226 (Qhelp_form_show): New var.
e0d38eeb 8227 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8228
8229 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8230
8231 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8232
e67a13ab
CY
82332011-04-06 Chong Yidong <cyd@stupidchicken.com>
8234
04f2d78b
CB
8235 * process.c (Flist_processes): Remove to Lisp.
8236 (list_processes_1): Delete.
e67a13ab 8237
973f782d
EZ
82382011-04-06 Eli Zaretskii <eliz@gnu.org>
8239
7c106b1e
EZ
8240 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8241
973f782d
EZ
8242 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8243
41cf7d1a 82442011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8245
ca23cc88
PE
8246 Fix more problems found by GCC 4.6.0's static checks.
8247
f390e2d5
PE
8248 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8249
42eea0d0
PE
8250 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8251
b69769da 8252 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8253
f9541e84
PE
8254 * xdisp.c (vmessage): Mark as a printf-like function.
8255
13841b55
PE
8256 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8257
c136c10f
PE
8258 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8259
5e2d4a30
PE
8260 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8261 printf-like functions.
8262 (tiff_load): Add casts to remove these marks before passing them
8263 to system-supplied API.
8264
583f48b9
PE
8265 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8266
b25d760e
PE
8267 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8268 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8269 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8270 directly, rather than having caller test rule sign. This avoids
8271 some unnecessary tests.
8272 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8273 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8274 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8275
bc7b6697 8276 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8277 (xfont_open): Avoid unnecessary tests.
bc7b6697 8278
27ccc379
PE
8279 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8280
dcd5c89a
PE
8281 * composite.h, composite.c (composition_gstring_put_cache):
8282 Use EMACS_INT, not int, for length.
8283
b13a45c6
PE
8284 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8285 breaking out part of COMPOSITION_DECODE_RULE.
8286 (COMPOSITION_DECODE_RULE): Use it.
8287 * composite.c (get_composition_id): Remove unused local vars,
8288 by using the new macro.
8289
1e792e4d
PE
8290 * textprop.c (set_text_properties_1): Change while to do-while,
8291 since the condition is always true at first.
8292
dc6c6455 8293 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8294 (interval_deletion_adjustment): Return unsigned value.
8295 All uses changed.
dc6c6455 8296
aba7731a
PE
8297 * process.c (list_processes_1, create_pty, read_process_output):
8298 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8299 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8300 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8301 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8302 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8303
fdfc4bf3
PE
8304 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8305
fca8fe46 8306 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8307 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8308
06a0259a 8309 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8310 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8311 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8312
e7b9e80f
PE
8313 * print.c (print_error_message): Avoid int overflow.
8314
56201685
PE
8315 * font.c (font_list_entities): Redo for clarity,
8316 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8317
78834453 8318 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8319 (font_score): Avoid potential overflow in diff calculation.
78834453 8320
0bc0b309 8321 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8322 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8323
e610eaca
PE
8324 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8325
b895abce
PE
8326 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8327 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8328 can always succeed if overflow has undefined behavior.
8329
1f1d9321 8330 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8331 (wordify): Omit three unnecessary tests.
1f1d9321 8332
c59478bc
PE
8333 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8334 All callers changed. This avoids the need for an unused var.
8335
79b73827
PE
8336 * casefiddle.c (casify_region): Remove var that is set but not used.
8337
a4db5dfe
PE
8338 * dired.c (file_name_completion): Remove var that is set but not used.
8339
43aae36e
PE
8340 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8341
2a47c44d 8342 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8343 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8344
a37c69bf
PE
8345 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8346 Check for integer overflow on size calculations.
8347
328ab8e7
PE
8348 * buffer.c (Fprevious_overlay_change): Remove var that is set
8349 but not used.
8350
e5a2a5cb
PE
8351 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8352 Remove vars that are set but not used.
8d84a6eb 8353 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8354 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8355
a60e5f68
PE
8356 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8357
f661cb61 8358 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8359 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8360
f0397f5a
PE
8361 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8362 that are set but not used.
8363
8664db06 8364 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8365 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8366
6abdaa4a
PE
8367 * xselect.c (x_get_local_selection, x_handle_property_notify):
8368 Remove vars that are set but not used.
8369
0ce7538d 8370 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8371 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8372
9ae848fc
PE
8373 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8374 Remove var that is set but not used.
0b918413
PE
8375 (scroll_bar_windows_size): Now size_t, not int.
8376 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8377 Check for overflow.
9ae848fc 8378
a5a62657
PE
8379 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8380 (map_tty_color) [!defined MSDOS]: Likewise.
8381
5c5cdd39
PE
8382 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8383
66ebf983
PE
8384 * coding.c: Remove vars that are set but not used.
8385 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8386 All callers changed.
8387 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8388 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8389 (decode_coding_charset): Remove vars that are set but not used.
8390
1be4d761
PE
8391 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8392 that is set but not used.
8393
47553fa8
PE
8394 * print.c (print_object): Remove var that is set but not used.
8395
1f7196bf 8396 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8397 The gnulib version avoids calling malloc in the usual case,
8398 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8399 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8400 * filelock.c (current_lock_owner): Likewise.
8401 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8402 * sysdep.c: Include allocator.h, careadlinkat.h.
8403 (emacs_no_realloc_allocator): New static constant.
8404 (emacs_readlink): New function.
fdb61804
PE
8405 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8406 ../lib/careadlinkat.h.
d1fdcab7 8407
f84c17c7
SM
84082011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8409
8410 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8411 first non-nil return value).
8412
ef3862ad
JD
84132011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8414
8415 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8416 if not defined (Bug#8403).
8417
376a7006
JB
84182011-04-02 Juanma Barranquero <lekktu@gmail.com>
8419
8420 * xdisp.c (display_count_lines): Remove parameter `start',
8421 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8422 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8423 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8424 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8425 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8426 and thereabouts. All callers changed.
8427 (get_per_char_metric): Remove parameter `f', unused since
8428 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8429
6ca3801d
JM
84302011-04-02 Jim Meyering <meyering@redhat.com>
8431
8432 do not dereference NULL upon failed strdup
8433 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8434 (ns_get_family): Likewise.
8435
d8e2b5ba
JB
84362011-04-02 Juanma Barranquero <lekktu@gmail.com>
8437
8438 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8439
8c74fcbd
JD
84402011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8441
8442 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8443 later (Bug#8403).
8444
7200d79c
SM
84452011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8446
03408648 8447 Add lexical binding.
7200d79c 8448
03408648
SM
8449 * window.c (Ftemp_output_buffer_show): New fun.
8450 (Fsave_window_excursion):
8451 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8452
8453 * lread.c (lisp_file_lexically_bound_p): New function.
8454 (Fload): Bind Qlexical_binding.
8455 (readevalloop): Remove `evalfun' arg.
8456 Bind Qinternal_interpreter_environment.
8457 (Feval_buffer): Bind Qlexical_binding.
8458 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8459 Mark as dynamic.
8460 (syms_of_lread): Declare `lexical-binding'.
8461
8462 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8463
8464 * keyboard.c (eval_dyn): New fun.
8465 (menu_item_eval_property): Use it.
ca105506
SM
8466
8467 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8468
03408648
SM
8469 * fns.c (concat, mapcar1): Accept byte-code-functions.
8470
8471 * eval.c (Fsetq): Handle lexical vars.
8472 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8473 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8474 (FletX, Flet): Obey lexical binding.
8475 (Fcommandp): Handle closures.
8476 (Feval): New `lexical' arg.
8477 (eval_sub): New function extracted from Feval. Use it almost
8478 everywhere where Feval was used. Look up vars in lexical env.
8479 Handle closures.
8480 (Ffunctionp): Move from subr.el.
8481 (Ffuncall): Handle closures.
8482 (apply_lambda): Remove `eval_flags'.
8483 (funcall_lambda): Handle closures and new byte-code-functions.
8484 (Fspecial_variable_p): New function.
8485 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8486 but without exporting it to Lisp.
23aba0ea 8487
23aba0ea 8488 * doc.c (Fdocumentation, store_function_docstring):
03408648 8489 * data.c (Finteractive_form): Handle closures.
23aba0ea 8490
03408648
SM
8491 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8492 interactive spec.
ba83908c 8493
04f2d78b
CB
8494 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8495 New byte-codes.
03408648
SM
8496 (exec_byte_code): New function extracted from Fbyte_code to handle new
8497 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8498
03408648 8499 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8500
03408648 8501 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8502
e2abce01
JB
85032011-03-31 Juanma Barranquero <lekktu@gmail.com>
8504
8505 * xdisp.c (redisplay_internal): Fix prototype.
8506
63696a73 85072011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8508
63696a73 8509 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8510 (try_scrolling): Use it when setting scroll_limit.
8511 Limit scrolling to 100 screen lines.
63696a73
EZ
8512 (redisplay_window): Even when falling back on "recentering",
8513 position point in the window according to scroll-conservatively,
8514 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8515
8516 (try_scrolling): When point is above the window, allow searching
8517 as far as scroll_max, or one screenful, to compute vertical
8518 distance from PT to the scroll margin position. This prevents
8519 try_scrolling from unnecessarily failing when
8520 scroll-conservatively is set to a value slightly larger than the
8521 window height. Clean up the case of PT below the margin at bottom
8522 of window: scroll_max can no longer be INT_MAX. When aggressive
8523 scrolling is in use, don't let point enter the opposite scroll
8524 margin as result of the scroll.
8525 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8526 threshold of 100 lines for never-recentering scrolling.
8527
e4cc2dfc
JB
85282011-03-31 Juanma Barranquero <lekktu@gmail.com>
8529
8530 * dispextern.h (move_it_by_lines):
8531 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8532 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8533 (message_log_check_duplicate): Remove parameters `prev_bol' and
8534 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8535 (redisplay_internal): Remove parameter `preserve_echo_area',
8536 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8537
8538 * indent.c (Fvertical_motion):
8539 * window.c (window_scroll_pixel_based, Frecenter):
8540 Don't pass `need_y_p' to `move_it_by_lines'.
8541
1c470562
SM
85422011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8543
44f230aa
SM
8544 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8545 steal a few bits to be more compact.
8546 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8547 Remove unneeded casts.
8548
1c470562
SM
8549 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8550
888adce9
ZK
85512011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8552
8553 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8554 binding" message (bug#7967).
8555
f838ed7b
PE
85562011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8557
77861b95
PE
8558 Fix more problems found by GCC 4.6.0's static checks.
8559
de6dbc14
PE
8560 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8561 Remove unused local var.
8562
f838ed7b
PE
8563 * editfns.c (Fmessage_box): Remove unused local var.
8564
792c7b2b
PE
8565 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8566 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8567 Omit unused local vars.
c499e557 8568 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8569 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8570 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8571 Omit unused local var.
8572
ba0165e1
PE
8573 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8574 Don't assume string length fits in int.
32ad8845 8575 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8576 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8577
3c59b4c9
PE
8578 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8579 instead of alloca (Bug#8344).
8580
a3eed478 8581 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8582 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8583
eb4d412d
PE
8584 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8585
1658b401
PE
8586 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8587 concerns.
8588
8589 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8590
8591 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8592
9a2c6e05
PE
8593 * keyboard.c (syms_of_keyboard): Use the same style as later
8594 in this function when indexing through an array. This also
8595 works around GCC bug 48267.
8596
03d0a109
PE
8597 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8598
44f730c8
PE
8599 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8600
fe75f926
PE
8601 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8602 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8603
ffa8c828
PE
8604 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8605 This avoids undefined behavior on integer overflow, and is a bit
8606 more convenient anyway since it is compared to a size_t variable.
8607
c5101a77
PE
8608 Variadic C functions now count arguments with size_t, not int.
8609 This avoids an unnecessary limitation on 64-bit machines, which
8610 caused (substring ...) to crash on large vectors (Bug#8344).
8611 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8612 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8613 All variadic functions and their callers changed accordingly.
c5101a77
PE
8614 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8615 * data.c (arith_driver, float_arith_driver): Likewise.
8616 * editfns.c (general_insert_function): Likewise.
8617 * eval.c (struct backtrace.nargs, interactive_p)
8618 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8619 (funcall_lambda, mark_backtrace): Likewise.
8620 * fns.c (concat): Likewise.
8621 * frame.c (x_set_frame_parameters): Likewise.
8622 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8623 0 if not found, not -1. All callers changed.
8624
dd3f25f7
PE
8625 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8626 (stack_copy_size): Now size_t, not int.
8627 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8628
461c2ab9
JB
86292011-03-28 Juanma Barranquero <lekktu@gmail.com>
8630
8631 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8632 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8633 All callers changed.
8634
8635 * lisp.h (multibyte_char_to_unibyte):
8636 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8637 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8638 * character.h (CHAR_TO_BYTE8):
8639 * cmds.c (internal_self_insert):
8640 * editfns.c (general_insert_function):
8641 * keymap.c (push_key_description):
8642 * search.c (Freplace_match):
8643 * xdisp.c (message_dolog, set_message_1): All callers changed.
8644
f6d62986
SM
86452011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8646
8647 * keyboard.c (safe_run_hook_funcall): New function.
8648 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8649 don't set the hook to nil, but remove the offending function instead.
8650 (Qcommand_hook_internal): Remove, unused.
8651 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8652 Vcommand_hook_internal.
8653
8654 * eval.c (enum run_hooks_condition): Remove.
8655 (funcall_nil, funcall_not): New functions.
8656 (run_hook_with_args): Call each function through a `funcall' argument.
8657 Remove `cond' argument, now redundant.
8658 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8659 (Frun_hook_with_args_until_failure): Adjust accordingly.
8660 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8661
1db5b1ad
JB
86622011-03-28 Juanma Barranquero <lekktu@gmail.com>
8663
8664 * dispextern.h (string_buffer_position): Remove declaration.
8665
8666 * print.c (strout): Remove parameter `multibyte', unused since
8667 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8668
8669 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8670 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8671 All callers changed.
8672
8673 * w32.c (_wsa_errlist): Use braces for struct initializers.
8674
8675 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8676 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8677 All callers changed.
8678 (string_buffer_position): Likewise. Also, make static (it's never
8679 used outside xdisp.c).
8680 (cursor_row_p): Remove parameter `w', unused since
8681 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8682 (decode_mode_spec): Remove parameter `precision', introduced during
8683 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8684 All callers changed.
8685
5ffb62aa
JD
86862011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8687
8688 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8689
461c2ab9 86902011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8691
8692 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8693 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8694 (ns_update_auto_hide_menu_bar): New functions.
8695 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8696 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8697 ns_constrain_all_frames.
8698 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8699 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8700
5c380ffb
JD
87012011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8702
8703 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8704
9af30bdf
GM
87052011-03-27 Glenn Morris <rgm@gnu.org>
8706
8707 * syssignal.h: Replace RETSIGTYPE with void.
8708 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8709 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8710 Replace SIGTYPE with void everywhere.
8711 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8712 * s/template.h (SIGTYPE): Remove commented out definition.
8713
e2abce01
JB
87142011-03-26 Eli Zaretskii <eliz@gnu.org>
8715
8716 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8717 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8718
f868cd8a
JB
87192011-03-26 Juanma Barranquero <lekktu@gmail.com>
8720
59eb0929
JB
8721 * w32.c (read_unc_volume): Use parameter `henum', instead of
8722 global variable `wget_enum_handle'.
8723
8724 * keymap.c (describe_vector): Remove parameters `indices' and
8725 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8726 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8727
f868cd8a
JB
8728 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8729
8730 * keyboard.c (timer_check): Remove parameter `do_it_now',
8731 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8732 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8733 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8734
8735 * keyboard.c (read_char):
8736 * w32menu.c (w32_menu_display_help):
8737 * xmenu.c (show_help_event, menu_help_callback):
8738 Adjust calls to `show_help_echo'.
8739
8740 * gtkutil.c (xg_maybe_add_timer):
8741 * keyboard.c (readable_events):
8742 * process.c (wait_reading_process_output):
8743 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8744
8745 * insdel.c (adjust_markers_gap_motion):
8746 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8747 (gap_left, gap_right): Don't call it.
8748
2ecf6fdb
CY
87492011-03-25 Chong Yidong <cyd@stupidchicken.com>
8750
8751 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8752 incurred during fontification.
8753
6b1f9ba4
JB
87542011-03-25 Juanma Barranquero <lekktu@gmail.com>
8755
8756 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8757 (DEFVAR_PER_BUFFER): Don't pass it.
8758
8759 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8760 (scrolling_window): Don't pass it.
8761
0f4a96b5
JB
87622011-03-25 Juanma Barranquero <lekktu@gmail.com>
8763
8764 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8765
8766 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8767 and `suffix'.
8768 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8769 of variables specific to SELinux and computation of `encoded_absname'.
8770
8771 * image.c (XPutPixel): Remove unused variable `height'.
8772
8773 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8774
8775 * unexw32.c (get_section_info): Remove unused variable `section'.
8776
8777 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8778 (system_process_attributes): Remove unused variable `sess'.
8779 (sys_read): Remove unused variable `err'.
8780
8781 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8782 (w32_wnd_proc): Remove unused variable `isdead'.
8783 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8784 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8785 (x_create_tip_frame): Remove unused variable `tem'.
8786
8787 * w32inevt.c (w32_console_read_socket):
8788 Remove unused variable `no_events'.
8789
8790 * w32term.c (x_draw_composite_glyph_string_foreground):
8791 Remove unused variable `width'.
8792
1149507c
JB
87932011-03-24 Juanma Barranquero <lekktu@gmail.com>
8794
8795 * w32term.c (x_set_glyph_string_clipping):
8796 Don't pass uninitialized region to CombineRgn.
8797
9c88f339
JB
87982011-03-23 Juanma Barranquero <lekktu@gmail.com>
8799
8800 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8801 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8802 (Fx_close_connection): Remove unused variable `i'.
8803
8804 * w32font.c (w32font_draw): Return number of glyphs.
8805 (w32font_open_internal): Remove unused variable `i'.
8806 (w32font_driver): Add missing initializer.
8807
8808 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8809 (fill_in_menu): Remove unused variable `items_added'.
8810
8811 * w32term.c (last_mouse_press_frame): Remove static global variable.
8812 (w32_clip_to_row): Remove unused variable `f'.
8813 (x_delete_terminal): Remove unused variable `i'.
8814
8815 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8816 (NOTHING): Remove unused static global variable.
8817 (uniscribe_check_otf): Remove unused variable `table'.
8818 (uniscribe_font_driver): Add missing initializers.
8819
dee091a3
JD
88202011-03-23 Julien Danjou <julien@danjou.info>
8821
8822 * term.c (Fsuspend_tty, Fresume_tty):
8823 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8824 * window.c (temp_output_buffer_show):
8825 * insdel.c (signal_before_change):
8826 * frame.c (Fhandle_switch_frame):
8827 * fileio.c (Fdo_auto_save):
8828 * emacs.c (Fkill_emacs):
8829 * editfns.c (save_excursion_restore):
8830 * cmds.c (internal_self_insert):
8831 * callint.c (Fcall_interactively):
8832 * buffer.c (Fkill_all_local_variables):
8833 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8834 Use Frun_hooks.
0f4a96b5 8835 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8836 unconditionally since it does the check itself.
dee091a3 8837
2c520ab5 88382011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8839
c9c49752
PE
8840 Fix more problems found by GCC 4.5.2's static checks.
8841
8abc3f12
PE
8842 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8843 the first time through the loop, since we know p0 < p1 then.
8844 This also avoids a gcc -Wstrict-overflow warning.
8845
a2d26660
PE
8846 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8847 leading to a memory leak, possible in functions like
8848 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8849 of objects (Bug#8318).
a2d26660 8850
916c72e9
PE
8851 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8852 that could (at least in theory) be that large.
8853
19ab8a18
PE
8854 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8855 This is less likely to overflow, and avoids undefined behavior if
8856 overflow does occur. All callers changed. Use strtoul to scan
8857 for the unsigned long integer.
b7cbbd6f
PE
8858 (pint2hrstr): Simplify and tune code slightly.
8859 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8860
f0641eff
PE
8861 * scroll.c (do_scrolling): Work around GCC bug 48228.
8862 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8863
7f650bb9
PE
8864 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8865 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8866 (validate_x_resource_name): Simplify count usage.
8867 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8868
37dd57d1
PE
8869 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8870 fail (Bug#8306).
81e56e61 8871
699979fc 8872 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8873
401bf9b4
PE
8874 * process.c (Fmake_network_process): Use socklen_t, not int,
8875 where POSIX says socklen_t is required in portable programs.
8876 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8877 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8878 (Fmake_network_process, server_accept_connection):
8879 (wait_reading_process_output, read_process_output):
8880 Likewise.
8881
b93aacde
PE
8882 * process.c: Rename or move locals to avoid shadowing.
8883 (list_processes_1, Fmake_network_process):
8884 (read_process_output_error_handler, exec_sentinel_error_handler):
8885 Rename or move locals.
4dc343ee 8886 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8887 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8888 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8889 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8890 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8891
af8a867c 8892 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8893 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8894 Include tparam.h instead, since it declares them.
af8a867c
PE
8895 * cm.h (PC): Remove extern decl; tparam.h now does this.
8896 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8897 * terminfo.c: Include tparam.h, to check interfaces.
8898 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8899 (tparam): Adjust signature to match interface in tparam.h;
8900 this removes some undefined behavior. Check that outstring and len
8901 are zero, which they always are with Emacs.
8902 * tparam.h (PC, BC, UP): New extern decls.
8903
0248044d 8904 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8905 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8906
8ff096c1 8907 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8908 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8909 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8910 (ftfont_list): Remove unused local.
49eaafba
PE
8911 (get_adstyle_property, ftfont_pattern_entity):
8912 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8913 Rename locals to avoid shadowing.
8ff096c1 8914
e2be39f6
PE
8915 * xfont.c (xfont_list_family): Mark var as initialized.
8916
c9735e30
PE
8917 * xml.c (make_dom): Now static.
8918
8f5201ae
PE
8919 * composite.c (composition_compute_stop_pos): Rename local to
8920 avoid shadowing.
b246f932
PE
8921 (composition_reseat_it): Remove unused locals.
8922 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8923 (composition_update_it): Mark var as initialized.
11b61122
PE
8924 (find_automatic_composition): Mark vars as initialized,
8925 with a FIXME (Bug#8290).
8f5201ae 8926
760fbc2c
PE
8927 character.h: Rename locals to avoid shadowing.
8928 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8929 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8930 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8931 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8932 to avoid shadowing.
8933
ff08eb85
PE
8934 * textprop.c (property_change_between_p): Remove; unused.
8935
fc7bf025
PE
8936 * intervals.c (interval_start_pos): Now static.
8937
235d7abc
PE
8938 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8939
44f230aa
SM
8940 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8941 Rename locals to avoid shadowing.
3e7d6594 8942
50060332
PE
8943 * sound.c (wav_play, au_play, Fplay_sound_internal):
8944 Fix pointer signedness.
d01f234b 8945 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8946 (wav_play): Initialize a variable to 0, to prevent undefined
8947 behavior (Bug#8278).
50060332 8948
c4fc4e30
PE
8949 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8950
918436ed
PE
8951 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8952
c939f91b
PE
8953 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8954 clobbering (Bug#8298).
b9c7f648
PE
8955 * sysdep.c (sys_subshell): Likewise.
8956 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8957
6bd8c144
PE
8958 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8959 This should get cleaned up, so that child_setup has the
8960 same signature on all platforms.
8961
7710357c 8962 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8963 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8964
c59da222
CY
89652011-03-22 Chong Yidong <cyd@stupidchicken.com>
8966
8967 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8968 not to be necessary, and produces flickering.
8969
66b87493
GM
89702011-03-20 Glenn Morris <rgm@gnu.org>
8971
8972 * config.in: Remove file.
8973
45b6f6d5
JB
89742011-03-20 Juanma Barranquero <lekktu@gmail.com>
8975
8976 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8977 are now in src/globals.h.
8978 (syms_of_minibuf): Remove spurious & from previous change.
8979
cd394be1 89802011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8981
8982 * minibuf.c (completing-read-function): New variable.
8983 (completing-read-default): Rename from completing-read.
8984 (completing-read): Call completing-read-function.
8985
b14e3e21
CY
89862011-03-19 Juanma Barranquero <lekktu@gmail.com>
8987
8988 * xfaces.c (Fx_load_color_file):
8989 Read color file from absolute filename (bug#8250).
8990
f2b726e6
JB
89912011-03-19 Juanma Barranquero <lekktu@gmail.com>
8992
8993 * makefile.w32-in: Update dependencies.
8994
09f6ff02
EZ
89952011-03-17 Eli Zaretskii <eliz@gnu.org>
8996
8997 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8998
29a6015a
PE
89992011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9000
a3a6c54e
PE
9001 Fix more problems found by GCC 4.5.2's static checks.
9002
b766f867
PE
9003 * process.c (make_serial_process_unwind, send_process_trap):
9004 (sigchld_handler): Now static.
9005
be02381c
PE
9006 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9007 That way, the code declares only the vars that it needs.
9008 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9009 * s/cygwin.h (PTY_ITERATION): Likewise.
9010 * s/darwin.h (PTY_ITERATION): Likewise.
9011 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9012
57048744
PE
9013 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9014 * process.c (allocate_pty): Don't declare stb unless it's needed.
9015
7914961c 9016 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
9017 (CONSTANTLIM): Remove; unused.
9018 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9019 Define only if needed.
7914961c 9020
b3967b18
PE
9021 * unexelf.c (unexec): Name an expression,
9022 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
9023 Use a different way to cause a compilation error if anyone uses
9024 n rather than nn, a way that does not involve shadowing.
73366a00 9025 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9026
29a6015a
PE
9027 * deps.mk (unexalpha.o): Remove; unused.
9028
43cfc33e 9029 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9030 * unexec.h: New file.
ce701a33
PE
9031 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9032 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9033 Depend on unexec.h.
9034 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9035 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9036 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9037 Change as necessary to match prototype in unexec.h.
ce701a33 9038
01f44d5a
PE
9039 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9040 shadowing.
4f63c6bb 9041 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9042
a6670b0b
PE
9043 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9044 Rename locals to avoid shadowing.
9045
cef2010d 9046 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9047 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9048
d4d7173a
PE
9049 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9050
f08b802a
PE
9051 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9052 warning when compiling print.c.
9053
3ddb0639
PE
9054 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9055 instead of using an uninitialized var.
5ad03b97 9056 (font_sort_entities): Mark var as initialized.
3ddb0639 9057
170a2692
PE
9058 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9059
e663c700
PE
9060 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9061 pointers to constants.
89bc529a 9062 (font_parse_fcname): Remove unused vars.
7b81e2d0 9063 (font_delete_unmatched): Now static.
ea838e10 9064 (font_get_spec): Remove; unused.
13a547c6
PE
9065 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9066 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9067 Rename or move locals to avoid shadowing.
e663c700 9068
2a80c887 9069 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9070 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9071
1384fa33 9072 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9073 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9074
8b2c52e9
PE
9075 * alloc.c (mark_backtrace): Move decl from here ...
9076 * lisp.h: ... to here, so that it can be checked.
9077
475545b5 9078 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9079 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9080 (lisp_indirect_variable): Name an expression,
9081 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9082 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9083
b1349114 9084 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9085 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9086 Use const pointer when appropriate.
b1349114 9087
a2928364
PE
9088 * lisp.h (get_system_name, get_operating_system_release):
9089 Move decls here, to check interfaces.
9090 * process.c (get_operating_system_release): Move decl to lisp.h.
9091 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9092 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9093 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9094 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9095 (Fformat_time_string, Fencode_time, Finsert_char):
9096 (Ftranslate_region_internal, Fformat):
9097 Rename or remove local vars to avoid shadowing.
9710023e 9098 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9099
a415e694
PE
9100 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9101 avoid shadowing.
9102
8ef4622d
PE
9103 * lisp.h (eassert): Check that the argument compiles, even if
9104 ENABLE_CHECKING is not defined.
9105
946f9a5b
PE
9106 * data.c (Findirect_variable): Name an expression, to avoid
9107 gcc -Wbad-function-cast warning.
112396d6 9108 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9109 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9110 (Fmake_variable_buffer_local, Fmake_local_variable):
9111 Mark variables as initialized.
52746918 9112 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9113
e5aab7e7 9114 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9115 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9116 Rename locals to avoid shadowing.
dff45157
PE
9117 (mark_stack): Move local variables into the #ifdef region where
9118 they're used.
7bc26fdb
PE
9119 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9120 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9121 needed otherwise.
9122 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9123 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9124 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9125
e5aab7e7
PE
9126 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9127 avoids undefined behavior in theory.
9128
4da60324
PE
9129 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9130
88043301
PE
9131 Use functions, not macros, for up- and down-casing (Bug#8254).
9132 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9133 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9134 to use the following functions instead of these macros.
9135 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9136 EMACS_INT, since callers assume the returned value fits in int.
9137 (upcase1): Likewise, for UPCASE_TABLE.
9138 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9139 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9140 the race-condition problem in the old DOWNCASE.
88043301 9141
19ed5445
PE
9142 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9143 Rename locals to avoid shadowing.
9144 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9145 (regex_compile, re_search_2, re_match_2_internal):
9146 Remove unused local vars.
952db0d7
PE
9147 (FREE_VAR): Rewrite so as not to use empty "else",
9148 which gcc can warn about.
da053e48 9149 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9150 (RETALLOC_IF): Define only if needed.
9151 (WORDCHAR_P): Likewise. This one is never needed, but is used
9152 only in a comment talking about a compiler bug, so put inside
9153 the #if 0 of that comment.
9154 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9155 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9156 Remove; unused.
19ed5445 9157
1f3561e4 9158 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9159 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9160 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9161
ded6f8f7
PE
9162 * search.c (simple_search): Remove unused var.
9163
dbd37a95
PE
9164 * dired.c (compile_pattern): Move decl from here ...
9165 * lisp.h: ... to here, so that it can be checked.
9166 (struct re_registers): New forward decl.
9167
7e47afad
PE
9168 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9169
85f24f61
PE
9170 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9171 All uses changed.
9172 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9173 Rename locals to avoid shadowing.
5671df8f 9174 (Fvertical_motion): Mark locals as initialized.
85f24f61 9175
181aa2be 9176 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9177 (casify_region): Mark local as initialized.
181aa2be 9178
930d429c
PE
9179 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9180
7082eac6
PE
9181 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9182 New macros, so that the caller can use some names other than
9183 gcpro1, gcpro2, etc.
9184 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9185 of the new macros.
9186 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9187 argument, for consistency with GCPRO2_VAR, etc: it is now the
9188 prefix of the variable, not the variable itself. All uses
9189 changed.
38b2c076
PE
9190 * dired.c (directory_files_internal, file_name_completion):
9191 Rename locals to avoid shadowing.
9192
15206ed9
PE
9193 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9194 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9195 dired.c's scmp function, had undefined behavior.
9196 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9197 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9198 * buffer.h: ... to here, because these macros use current_buffer,
9199 and the new implementation with inline functions needs to have
9200 current_buffer in scope now, rather than later when the macros
9201 are used.
9202 (downcase, upcase1): New static inline functions.
9203 (DOWNCASE, UPCASE1): Reimplement using these functions.
9204 This avoids undefined behavior in expressions like
9205 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9206 from race conditions in accessing the global variables
9207 case_temp1 and case_temp2.
9208 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9209 * lisp.h (case_temp1, case_temp2): Remove their decls.
9210 * character.h (ASCII_CHAR_P): Move from here ...
9211 * lisp.h: ... to here, so that the inline functions mentioned
9212 above can use them.
9213
4a6bea26
PE
9214 * dired.c (directory_files_internal_unwind): Now static.
9215
f14b7e14
PE
9216 * fileio.c (file_name_as_directory, directory_file_name):
9217 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9218 Now static.
2893f146
PE
9219 (file_name_as_directory): Use const pointers when appropriate.
9220 (Fexpand_file_name): Likewise. In particular, newdir might
9221 point at constant storage, so make it a const pointer.
fd4ead52 9222 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9223 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9224 signedness issues.
f839df0c
PE
9225 (Fset_file_times, Finsert_file_contents, auto_save_error):
9226 Rename locals to avoid shadowing.
f14b7e14 9227
5716756e 9228 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9229 (Ftry_completion, Fall_completions): Rename or remove locals
9230 to avoid shadowing.
5716756e 9231
b4c3046a
PE
9232 * marker.c (bytepos_to_charpos): Remove; unused.
9233
b45db522
PE
9234 * lisp.h (verify_bytepos, count_markers): New decls,
9235 so that gcc does not warn that these functions aren't declared.
9236
85876d07
PE
9237 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9238 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9239 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9240 (copy_text): Remove unused local var.
85876d07 9241
03d78a21 9242 * filelock.c (within_one_second): Now static.
b3dd38ab 9243 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9244
5df8f01b
PE
9245 * buffer.c (fix_overlays_before): Mark locals as initialized.
9246 (fix_start_end_in_overlays): Likewise. This function should be
9247 simplified by using pointers-to-pointers, but that's a different
9248 matter.
b1d876f1 9249 (switch_to_buffer_1): Now static.
8f54f30a
PE
9250 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9251 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9252
a70072c9 9253 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9254 Fix pointer signedness issue.
edced198
PE
9255 (sys_subshell): Mark local as volatile if checking for lint,
9256 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9257 (MAXPATHLEN): Define only if needed.
a70072c9 9258
a0977c44
PE
9259 * process.c (serial_open, serial_configure): Move decls from here ...
9260 * systty.h: ... to here, so that they can be checked.
9261
a884fdcc
PE
9262 * fns.c (get_random, seed_random): Move extern decls from here ...
9263 * lisp.h: ... to here, so that they can be checked.
9264
604efe86 9265 * sysdep.c (reset_io): Now static.
b8950c94 9266 (wait_for_termination_signal): Remove; unused.
604efe86 9267
38fc62d9
PE
9268 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9269 (copy_keymap_item, append_key, push_text_char_description):
9270 Now static.
1004a21a 9271 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9272 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9273 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9274 (describe_map_tree):
9275 Rename locals to avoid shadowing.
38fc62d9 9276
2f2650da
PE
9277 * keyboard.c: Declare functions static if they are not used elsewhere.
9278 (echo_char, echo_dash, cmd_error, top_level_2):
9279 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9280 (read_char, kbd_buffer_get_event, make_lispy_position):
9281 (make_lispy_event, make_lispy_movement, apply_modifiers):
9282 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9283 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9284 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9285 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9286 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9287
a053e86c 9288 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9289 (mark_kboards): Move decl here ...
9290 * alloc.c (mark_kboards): ... from here.
a053e86c 9291
4752793e
PE
9292 * lisp.h (force_auto_save_soon): New decl.
9293
74f10ca7 9294 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9295 (DEFINE_DUMMY_FUNCTION): New macro.
9296 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9297 Use it.
c03cd23f
PE
9298 (main): Add casts to avoid warnings
9299 if GCC considers string literals to be constants.
74f10ca7 9300
022e70d4
PE
9301 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9302
59d6fe83
PE
9303 * dbusbind.c: Pointer signedness fixes.
9304 (xd_signature, xd_append_arg, xd_initialize):
9305 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9306 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9307 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9308 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9309
78320123
PE
9310 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9311 if GCC considers string literals to be constants.
49cebcca 9312 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9313
35ac2a97
SM
93142011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9315
fb103ca9
SM
9316 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9317 (print_preprocess, print_object): New macro to fix last change.
9318
35ac2a97
SM
9319 * print.c (print_preprocess): Don't forget font objects.
9320
62973b41
JB
93212011-03-16 Juanma Barranquero <lekktu@gmail.com>
9322
9323 * emacs.c (USAGE3): Doc fixes.
9324
0e48bb22
AS
93252011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9326
9327 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9328 structure.
9329
7684e57b
JB
93302011-03-14 Juanma Barranquero <lekktu@gmail.com>
9331
9332 * lisp.h (VWindow_system, Qfile_name_history):
9333 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9334 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9335 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9336
9337 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9338 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9339
9340 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9341 * w32console.c (detect_input_pending, read_input_pending)
9342 (encode_terminal_code):
9343 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9344 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9345 (w32_system_caret_y, Qfile_name_history):
9346 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9347 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9348 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9349 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9350 * w32proc.c (Qlocal, report_file_error):
9351 * w32term.c (Vwindow_system, updating_frame):
9352 * w32uniscribe.c (initialized, uniscribe_font_driver):
9353 Remove unneeded extern declarations.
9354
2aa46d6c
CY
93552011-03-14 Chong Yidong <cyd@stupidchicken.com>
9356
c96bbc66 9357 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9358
cffc6f3b
CY
93592011-03-13 Chong Yidong <cyd@stupidchicken.com>
9360
9361 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9362 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9363 These macros can no longer be used for assignment.
9364
44f230aa
SM
9365 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9366 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9367 (record_buffer_markers, fetch_buffer_markers): New functions for
9368 recording and fetching special buffer markers.
9369 (set_buffer_internal_1, set_buffer_temp): Use them.
9370
9371 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9372
9373 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9374
9375 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9376 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9377
9378 * xdisp.c (hscroll_window_tree):
9379 (reconsider_clip_changes): Use PT instead of BUF_PT.
9380
d251f04b
EZ
93812011-03-13 Eli Zaretskii <eliz@gnu.org>
9382
9383 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9384 $(EMACS_ROOT)/lib/intprops.h.
9385
f0c77cd1
PE
93862011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9387
3eca4629
PE
9388 Fix more problems found by GCC 4.5.2's static checks.
9389
7c86ee98
PE
9390 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9391 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9392 (xg_free_frame_widgets): Make it clear that a local variable is
9393 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9394 (gdk_window_get_screen): Make it clear that this macro is needed
9395 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9396 (int_gtk_range_get_value): New function, which avoids a diagnostic
9397 from gcc -Wbad-function-cast.
9398 (xg_set_toolkit_scroll_bar_thumb): Use it.
9399 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9400 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9401 (get_utf8_string, xg_get_file_with_chooser):
9402 Rename locals to avoid shadowing.
9403 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9404
41729b81
PE
9405 * xgselect.c (xg_select): Remove unused var.
9406
f0c77cd1
PE
9407 * image.c (four_corners_best): Mark locals as initialized.
9408 (gif_load): Initialize transparent_p to zero (Bug#8238).
9409 Mark another local as initialized.
ec6cf4c6 9410 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9411
ce0ad53d 9412 * image.c (clear_image_cache): Now static.
d5d5a617 9413 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9414 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9415 (x_edge_detection): Remove unnecessary cast that
9416 gcc -Wbad-function-cast diagnoses.
2037898d 9417 (gif_load): Fix pointer signedness.
6ae141d6
PE
9418 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9419 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9420
33383987 94212011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9422
d32df629
PE
9423 Improve quality of tests for time stamp overflow.
9424 For example, without this patch (encode-time 0 0 0 1 1
9425 1152921504606846976) returns the obviously-bogus value (-948597
9426 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9427 reports time overflow. See
9428 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9429 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9430 * editfns.c: Include limits.h and intprops.h.
9431 (TIME_T_MIN, TIME_T_MAX): New macros.
9432 (time_overflow): Move earlier, to before first use.
9433 (hi_time, lo_time): New functions, for an accurate test for
9434 out-of-range times.
9435 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9436 (Fget_internal_run_time): Don't assume time_t fits in int.
9437 (make_time): Use list2 instead of Fcons twice.
9438 (Fdecode_time): More accurate test for out-of-range times.
9439 (check_tm_member): New function.
9440 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9441 (lisp_time_argument): Don't rely on undefined left-shift and
9442 right-shift behavior when checking for time stamp overflow.
8be6f318 9443
fe31d94c
PE
9444 * editfns.c (time_overflow): New function, refactoring common code.
9445 (Fformat_time_string, Fdecode_time, Fencode_time):
9446 (Fcurrent_time_string): Use it.
9447
8be6f318
PE
9448 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9449 * dired.c (make_time): Move to ...
9450 * editfns.c (make_time): ... here.
9451 * systime.h: Note the move.
9452
09d9db2c 94532011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9454
126bc0dc
YM
9455 * fringe.c (update_window_fringes): Remove unused variables.
9456
c47cbdfd
YM
9457 * unexmacosx.c (copy_data_segment): Also copy __got section.
9458 (Bug#8223)
9459
7ac80be9
EZ
94602011-03-12 Eli Zaretskii <eliz@gnu.org>
9461
c96bbc66 9462 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9463 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9464 Constify `char *' arguments and their references according to
9465 prototypes in tparam.h.
9466
ecb0f94d 9467 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9468
7ac80be9
EZ
9469 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9470 Adapt all references accordingly.
9471
9472 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9473
ef1fd07e
TT
94742011-03-11 Tom Tromey <tromey@redhat.com>
9475
9476 * buffer.c (syms_of_buffer): Remove obsolete comment.
9477
7ef4b50c
EZ
94782011-03-11 Eli Zaretskii <eliz@gnu.org>
9479
9480 * termhooks.h (encode_terminal_code): Declare prototype.
9481
9482 * msdos.c (encode_terminal_code): Don't declare prototype.
9483
9484 * term.c (encode_terminal_code): Now external again, used by
9485 w32console.c and msdos.c.
9486
44f230aa
SM
9487 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9488 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9489
4b1ec863 94902011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9491
1714f52b 9492 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9493
4b1ec863
PE
9494 * fringe.c (update_window_fringes): Mark locals as initialized
9495 (Bug#8227).
9496 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9497
524c7aa6
PE
9498 * alloc.c (mark_fringe_data): Move decl from here ...
9499 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9500 to check its interface.
9501 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9502
a5c0af81 9503 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9504 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9505 (fontset_font): Mark local as initialized.
a9a06e0b 9506 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9507
b4716021
PE
9508 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9509
811e9bac 9510 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9511 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9512 (x_own_selection, Fx_disown_selection_internal): Rename locals
9513 to avoid shadowing.
9514 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9515
7e3ab302
PE
9516 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9517 so that the caller can use some name other than gcpro1.
9518 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9519 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9520 (Fx_backspace_delete_keys_p):
9521 Use them to avoid shadowing, and rename vars to avoid shadowing.
9522 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9523 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9524 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9525 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9526 Remove unused locals.
7e3ab302
PE
9527 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9528 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9529 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9530 macros.
f78faa98 9531
e2b13473
PE
9532 * xterm.h (x_mouse_leave): New decl.
9533
77f23912
PE
9534 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9535 Remove unused functions.
cdf4ba58
PE
9536 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9537 (x_calc_absolute_position): Now static.
7411c686 9538 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9539 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9540 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9541 unless they are used.
38d0b34a
PE
9542 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9543 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9544 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9545 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9546 (x_error_catcher, x_connection_closed, x_error_handler):
9547 (x_error_quitter, xembed_send_message, x_iconify_frame):
9548 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9549 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9550 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9551
44f230aa
SM
9552 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9553 Rename or move locals to avoid shadowing.
6b463e58 9554 (tty_defined_color, merge_face_heights): Now static.
5967d051 9555 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9556 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9557 does not deduce is never used uninitialized.
73719eba
PE
9558 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9559 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9560
426994c3 9561 * terminal.c (store_terminal_param): Now static.
5489860b 9562
032f1620 9563 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9564 (set_frame_menubar): Remove unused local.
d4323972 9565 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9566 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9567 since they might point to immutable storage.
281585b0
PE
9568 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9569 since it's unused otherwise.
032f1620 9570
367c19e5 9571 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9572 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9573 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9574 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9575 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9576 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9577 does not deduce are never used uninitialized.
70739cbe 9578
07b48fa9
PE
9579 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9580
8868a238 9581 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9582 * window.c (window_loop, size_window):
9583 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9584
7e5cf297 9585 * window.c (display_buffer): Now static.
d6550a9f
PE
9586 (size_window): Mark variables that gcc -Wuninitialized
9587 does not deduce are never used uninitialized.
a586633d
PE
9588 * window.h (check_all_windows): New decl, to forestall
9589 gcc -Wmissing-prototypes diagnostic.
5b555da1 9590 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9591
f6095868
PE
9592 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9593 shadowing.
9594 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9595 Include <limits.h>.
9596 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9597 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9598 (load_charset_map): Mark variables that gcc -Wuninitialized
9599 does not deduce are never used uninitialized.
53df7c11 9600 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9601
f38b440c
PE
9602 * coding.c (coding_set_source, coding_set_destination):
9603 Use "else { /* comment */ }" rather than "else /* comment */;"
9604 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9605 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9606 a block, when the outer 'i' will do.
9607 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9608 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9609 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9610 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9611 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9612 Rename locals to avoid shadowing.
9613 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9614 * coding.c (emacs_mule_char, encode_invocation_designation):
9615 Now static, since they're not used elsewhere.
413bb2db 9616 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9617 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9618 (decode_coding_emacs_mule): Mark variables that gcc
9619 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9620 (detect_coding_iso_2022): Initialize a local variable that might
9621 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9622 this initialization is needed. (Bug#8211)
5f58e762
PE
9623 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9624 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9625 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9626 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9627 Remove unused macros.
f38b440c 9628
232b38b9 9629 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9630 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9631 * character.c (string_count_byte8): Likewise.
232b38b9 9632
fb90da1b
PE
9633 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9634 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9635
fb93dbc2
PE
9636 * chartab.c (copy_sub_char_table): Now static, since it's not used
9637 elsewhere.
5c156ace
PE
9638 (sub_char_table_ref_and_range, char_table_ref_and_range):
9639 Rename locals to avoid shadowing.
bbcd0949 9640 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9641
7d3b3862 9642 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9643 (BIDI_BOB): Remove unused macro.
7d3b3862 9644
6be7d3da
PE
9645 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9646 deduce are never used uninitialized.
c2ed9c8b 9647 * term.c (encode_terminal_code): Likewise.
6be7d3da 9648
75f8807f 9649 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9650
50938595
PE
9651 * tparam.h: New file.
9652 * term.c, tparam.h: Include it.
9653 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9654 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9655 Move these decls to tparam.h, and make them agree with what
9656 is actually in tparam.c. The previous trick of using incompatible
9657 decls in different modules does not conform to the C standard.
9658 All callers of tparam changed to use tparam's actual API.
9659 * tparam.c (tparam1, tparam, tgoto):
9660 Use const pointers where appropriate.
9661
fbceeba2
PE
9662 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9663 * cm.h (struct cm): Likewise.
9664 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9665 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9666 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9667 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9668 (turn_on_face, init_tty): Likewise.
9669 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9670
7f3f1250
PE
9671 * term.c (term_mouse_position): Rename local to avoid shadowing.
9672
e6ca6543
PE
9673 * alloc.c (mark_ttys): Move decl from here ...
9674 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9675
c40f8d15
AS
96762011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9677
9678 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9679
cfe0661d
JB
96802011-03-09 Juanma Barranquero <lekktu@gmail.com>
9681
9682 * search.c (compile_pattern_1): Remove argument regp, unused since
9683 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9684 (compile_pattern): Don't pass it.
9685
0afb4571
J
96862011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9687
9688 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9689 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9690 for ! HAVE_GTK3.
9691 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9692
9693 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9694
9695 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9696 gdk_window_get_screen, gdk_window_get_geometry,
9697 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9698 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9699 (xg_get_pixbuf_from_pixmap): New function.
9700 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9701 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9702 Call xg_get_pixbuf_from_pixmap instead of
9703 gdk_pixbuf_get_from_drawable.
9704 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9705 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9706 (xg_check_special_colors): Use GtkStyleContext and its functions
9707 for HAVE_GTK3.
9708 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9709 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9710 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9711 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9712 Call gtk_widget_get_preferred_size.
0afb4571
J
9713 (xg_frame_resized): gdk_window_get_geometry only takes 5
9714 parameters.
44f230aa
SM
9715 (xg_win_to_widget, xg_event_is_for_menubar):
9716 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9717 (xg_set_widget_bg): New function.
9718 (delete_cb): New function.
895009e1 9719 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9720 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9721 (xg_set_background_color): Call xg_set_widget_bg.
9722 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9723 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9724 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9725 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9726 if ! HAVE_GTK3.
9727 (update_frame_tool_bar): Call gtk_widget_hide.
9728 (xg_initialize): Use GDK_KEY_g.
9729
9730 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9731 if ! HAVE_GTK3
9732 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9733
9734 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9735 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9736 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9737
1c2cc4ef
JB
97382011-03-08 Juanma Barranquero <lekktu@gmail.com>
9739
9740 * w32xfns.c (select_palette): Check success of RealizePalette against
9741 GDI_ERROR, not zero.
9742
33383987 9743See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9744
9745;; Local Variables:
9746;; coding: utf-8
aac0c6e3
MR
9747;; End:
9748
2f097256 9749 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9750
9751 This file is part of GNU Emacs.
9752
9753 GNU Emacs is free software: you can redistribute it and/or modify
9754 it under the terms of the GNU General Public License as published by
9755 the Free Software Foundation, either version 3 of the License, or
9756 (at your option) any later version.
9757
9758 GNU Emacs is distributed in the hope that it will be useful,
9759 but WITHOUT ANY WARRANTY; without even the implied warranty of
9760 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9761 GNU General Public License for more details.
9762
9763 You should have received a copy of the GNU General Public License
9764 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.