* src/fns.c (check_hash_table, get_key_arg, maybe_resize_hash_table)
[bpt/emacs.git] / src / ChangeLog
CommitLineData
9eb71b9c
SM
12012-10-01 Stefan Monnier <monnier@iro.umontreal.ca>
2
3 * fns.c (check_hash_table, get_key_arg, maybe_resize_hash_table)
4 (sweep_weak_table): Remove redundant prototypes.
5
b3317662
FP
62012-10-01 Fabrice Popineau <fabrice.popineau@gmail.com>
7
8 * emacs.c: Move the inclusion of TERM_HEADER after including
9 windows.h on WINDOWSNT. This avoids compilation problems with
10 MSVC.
11
f0e5f225
EZ
122012-10-01 Eli Zaretskii <eliz@gnu.org>
13
2d7d1608
EZ
14 * unexw32.c (OFFSET_TO_RVA, RVA_TO_OFFSET)
15 (RVA_TO_SECTION_OFFSET): Encode all macro arguments in parentheses.
16 (RVA_TO_PTR): Cast the result of RVA_TO_OFFSET to 'unsigned char *',
17 as the previous version used 'void *'.
18
19 * ralloc.c (ROUNDUP): Fix last change.
20 (MEM_ROUNDUP): Don't cast MEM_ALIGN, it is already of type
21 'size_t'.
22
f0e5f225
EZ
23 * w32proc.c <disable_itimers>: New static flag.
24 (init_timers): Initialize it to zero, after creating the critical
25 sections used by the timer threads.
26 (term_timers): Set to 1 before deleting the critical sections.
27 (getitimer, setitimer): If disable_itimers is non-zero, return an
28 error indication without doing anything. Reported by Fabrice
29 Popineau <fabrice.popineau@supelec.fr> as part of bug#12544.
4cdfbb89
EZ
30 (alarm) [HAVE_SETITIMER]: Be more conformant to the expected
31 return results.
32 [!HAVE_SETITIMER]: Behave as the previous version that didn't
33 support timers.
f0e5f225
EZ
34
35 * emacs.c (shut_down_emacs) [WINDOWSNT]: Move the call to
36 term_ntproc after all the other bookkeeping, to get timers working
37 as long as possible.
38
82ef37c1
PE
392012-10-01 Paul Eggert <eggert@cs.ucla.edu>
40
b3a4c387
PE
41 * xdisp.c (syms_of_xdisp): Default message-log-max to 1000, not 100.
42 Suggested by Juri Linkov in
43 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00821.html>.
44
b0ab8123
PE
45 Prefer plain 'static' to 'static inline' (Bug#12541).
46 With static functions, modern compilers inline pretty well by
47 themselves; advice from programmers often hurts as much as it helps.
48 On my host (x86-64, Fedora 17, GCC 4.7.2, default 'configure'),
49 this change shrinks the text size of the Emacs executable by 1.1%
50 without affecting CPU significantly in my benchmark.
51 * alloc.c (mem_find, live_string_p, live_cons_p, live_symbol_p)
52 (live_float_p, live_misc_p, live_vector_p, live_buffer_p)
53 (mark_maybe_object, mark_maybe_pointer, bounded_number):
54 * buffer.c (bset_abbrev_mode, bset_abbrev_table)
55 (bset_auto_fill_function, bset_auto_save_file_format)
56 (bset_auto_save_file_name, bset_backed_up, bset_begv_marker)
57 (bset_bidi_display_reordering, bset_buffer_file_coding_system)
58 (bset_cache_long_line_scans, bset_case_fold_search)
59 (bset_ctl_arrow, bset_cursor_in_non_selected_windows)
60 (bset_cursor_type, bset_display_table, bset_extra_line_spacing)
61 (bset_file_format, bset_file_truename, bset_fringe_cursor_alist)
62 (bset_fringe_indicator_alist, bset_fringes_outside_margins)
63 (bset_header_line_format, bset_indicate_buffer_boundaries)
64 (bset_indicate_empty_lines, bset_invisibility_spec)
65 (bset_left_fringe_width, bset_major_mode, bset_mark)
66 (bset_minor_modes, bset_mode_line_format, bset_mode_name)
67 (bset_name, bset_overwrite_mode, bset_pt_marker)
68 (bset_right_fringe_width, bset_save_length)
69 (bset_scroll_bar_width, bset_scroll_down_aggressively)
70 (bset_scroll_up_aggressively, bset_selective_display)
71 (bset_selective_display_ellipses, bset_vertical_scroll_bar_type)
72 (bset_word_wrap, bset_zv_marker, set_buffer_overlays_before)
73 (set_buffer_overlays_after):
74 * category.c (bset_category_table):
75 * charset.c (read_hex):
76 * coding.c (produce_composition, produce_charset)
77 (handle_composition_annotation, handle_charset_annotation)
78 (char_encodable_p):
79 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers)
80 (assign_row, set_frame_matrix_frame, make_current)
81 (add_row_entry):
82 * eval.c (set_specpdl_symbol, set_specpdl_old_value):
83 * fns.c (maybe_resize_hash_table):
84 * frame.c (fset_buffer_predicate, fset_minibuffer_window):
85 * gmalloc.c (register_heapinfo):
86 * image.c (lookup_image_type):
87 * intervals.c (set_interval_object, set_interval_left)
88 (set_interval_right, copy_interval_parent, rotate_right)
89 (rotate_left, balance_possible_root_interval):
90 * keyboard.c (kset_echo_string, kset_kbd_queue)
91 (kset_keyboard_translate_table, kset_last_prefix_arg)
92 (kset_last_repeatable_command, kset_local_function_key_map)
93 (kset_overriding_terminal_local_map, kset_real_last_command)
94 (kset_system_key_syms, clear_event, set_prop):
95 * lread.c (digit_to_number):
96 * marker.c (attach_marker, live_buffer, set_marker_internal):
97 * nsterm.m (ns_compute_glyph_string_overhangs):
98 * process.c (pset_buffer, pset_command)
99 (pset_decode_coding_system, pset_decoding_buf)
100 (pset_encode_coding_system, pset_encoding_buf, pset_filter)
101 (pset_log, pset_mark, pset_name, pset_plist, pset_sentinel)
102 (pset_status, pset_tty_name, pset_type, pset_write_queue):
103 * syntax.c (bset_syntax_table, dec_bytepos):
104 * terminal.c (tset_param_alist):
105 * textprop.c (interval_has_some_properties)
106 (interval_has_some_properties_list):
107 * window.c (wset_combination_limit, wset_dedicated)
108 (wset_display_table, wset_hchild, wset_left_fringe_width)
109 (wset_left_margin_cols, wset_new_normal, wset_new_total)
110 (wset_normal_cols, wset_normal_lines, wset_parent, wset_pointm)
111 (wset_right_fringe_width, wset_right_margin_cols)
112 (wset_scroll_bar_width, wset_start, wset_temslot, wset_vchild)
113 (wset_vertical_scroll_bar_type, wset_window_parameters):
114 * xdisp.c (wset_base_line_number, wset_base_line_pos)
115 (wset_column_number_displayed, wset_region_showing)
116 (window_box_edges, run_window_scroll_functions)
117 (append_glyph_string_lists, prepend_glyph_string_lists)
118 (append_glyph_string, set_glyph_string_background_width)
119 (append_glyph, append_composite_glyph)
120 (take_vertical_position_into_account):
121 * xfaces.c (x_create_gc, x_free_gc, merge_face_vectors)
122 (face_attr_equal_p, lface_equal_p, hash_string_case_insensitive)
123 (lface_hash, lface_same_font_attributes_p, lookup_face):
124 * xml.c (libxml2_loaded_p):
125 * xterm.c (x_set_mode_line_face_gc, x_set_glyph_string_gc)
126 (x_set_glyph_string_clipping, x_clear_glyph_string_rect):
127 Now 'static', not 'static inline'.
128
05584c31
PE
129 * bidi.c: Tune.
130 (bidi_copy_it): Do the whole copy with a single memcpy.
131 (bidi_char_at_pos): Merge the two STRING_CHAR calls into one.
132
86ec63ba
PE
133 Revert the FOLLOW-SYMLINKS change for file-attributes.
134 Doing it right would require several changes to Tramp, and there's
135 not enough time to get that tested before the freeze today.
136 * dired.c (directory_files_internal, Ffile_attributes):
137 Undo last change.
138
82ef37c1
PE
139 * frame.c (x_report_frame_params): Port better to wider ints.
140 Do not assume that EMACS_UINT is the same width as uprintmax_t,
141 or that pointers can be printed in 15 decimal digits.
142 Avoid GCC warnings if EMACS_UINT is wider than a pointer.
143
62aba0d4
FP
1442012-09-30 Fabrice Popineau <fabrice.popineau@supelec.fr>
145
146 Support x64 build on MS-Windows.
147 * w32term.h (SCROLL_BAR_PACK, SCROLL_BAR_UNPACK): Define for x64.
148 (SET_SCROLL_BAR_W32_WINDOW): Cast ID to intptr_t, for
149 compatibility with x64.
5e4daaf3 150 (x_get_focus_frame): Add prototype.
62aba0d4
FP
151
152 * w32term.c (w32_draw_underwave): Don't use GCC extensions for
153 defining an XRectangle structure.
154
155 * w32proc.c (RVA_TO_PTR, w32_executable_type): Fix pointer
156 arithmetics for compatibility with x64.
157
158 * w32menu.c (add_menu_item): Use UINT_PTR instead of UINT, for
159 compatibility with x64.
160
161 * w32heap.h: Adjust prototypes and declarations.
162
163 * w32heap.c (RVA_TO_PTR, allocate_heap, sbrk, init_heap)
164 (round_heap): Use DWORD_PTR, ptrdiff_t and size_t instead of
165 DWORD, long, and unsigned long, for compatibility with x64.
166 (allocate_heap) [_WIN64]: Reserve 32GB of memory.
167 (sbrk): Argument is now of type ptrdiff_t.
168
169 * w32fns.c (HMONITOR): Condition declaration on _WIN32_WINNT being
170 less than 0x0500.
171 (w32_msg_pump): Use WPARAM type for 'result'.
172
173 * w32.c (init_environment, get_emacs_configuration): Support AMD64
174 architecture.
175 (init_ntproc): Cast arguments of _open_osfhandle to intptr_t, for
176 compatibility with x64.
177
178 * vm-limit.c (lim_data): Now size_t.
179 (check_memory_limits): Adjust prototypes of real_morecore and
180 __morecore to receive argument of type ptrdiff_t. Use size_t for
181 five_percent and data_size.
182
183 * unexw32.c: Use DWORD_PTR instead of DWORD for file-scope
184 variables, for compatibility with x64.
185 (rva_to_section, offset_to_section, relocate_offset)
186 (OFFSET_TO_RVA, RVA_TO_OFFSET, RVA_TO_SECTION_OFFSET)
187 (PTR_TO_RVA, RVA_TO_PTR, OFFSET_TO_PTR, get_section_info)
188 (copy_executable_and_dump_data): Use DWORD_PTR instead of DWORD
189 for compatibility with x64.
190
191 * sysdep.c (STDERR_FILENO): Define if not already defined.
192
193 * ralloc.c (real_morecore): Argument type is now ptrdiff_t.
194 (__morecore): Argument type is now ptrdiff_t.
195 (ROUNDUP, MEM_ROUNDUP): Use size_t instead of 'unsigned long'.
196 (relinquish): Use ptrdiff_t type for 'excess'.
197 (r_alloc_sbrk): Argument type is now ptrdiff_t.
198
199 * makefile.w32-in (HEAPSIZE): Get value from EMACS_HEAPSIZE.
200 (bootstrap-temacs-CMD, bootstrap-temacs-SH): Use $(EMACS_PURESIZE)
201 instead of a literal number.
202
203 * gmalloc.c [WINDOWSNT]: Include w32heap.h.
204 (min): Define only if not already defined.
205
206 * frame.c (x_report_frame_params): Use EMACS_UINT for the return
207 value of FRAME_X_WINDOW, to fit a 64-bit pointer on 64-bit Windows
208 hosts.
209
210 * image.c (x_bitmap_pixmap): Return ptrdiff_t, not int, since
211 'bitmaps' is a pointer.
212
213 * dispextern.h (x_bitmap_pixmap): Adjust prototype.
214
215 * alloc.c (gdb_make_enums_visible): Now conditional on __GNUC__.
216
e7a2937b
PE
2172012-09-30 Paul Eggert <eggert@cs.ucla.edu>
218
219 file-attributes has a new optional arg FOLLOW-SYMLINKS.
220 * dired.c (directory_files_internal, Ffile_attributes):
221 New arg follow_symlinks. All uses changed.
222
b43d62ae
SM
2232012-09-30 Stefan Monnier <monnier@iro.umontreal.ca>
224
225 * .gdbinit (xbacktrace): Adjust to recent "struct backtrace" change.
226
c06c382a
EZ
2272012-09-30 Eli Zaretskii <eliz@gnu.org>
228
229 Support atimers and CPU profiler via profile.c on MS-Windows.
230 * w32proc.c (sig_mask, crit_sig): New static variables.
231 (sys_signal): Support SIGALRM and SIGPROF.
232 (sigemptyset, sigaddset, sigfillset, sigprocmask)
b43d62ae 233 (pthread_sigmask, setpgrp): Move here from w32.c. sigaddset,
c06c382a
EZ
234 sigfillset, and sigprocmask are no longer no-ops.
235 (sigismember): New function.
236 (struct itimer_data): New definition.
237 (ticks_now, real_itimer, prof_itimer, clocks_min, crit_real)
238 (crit_prof): New static variables.
239 (MAX_SINGLE_SLEEP): New definition.
240 (timer_loop, stop_timer_thread, term_timers, init_timers)
241 (start_timer_thread, getitimer, setitimer): New functions.
242 (alarm): No longer a no-op, calls setitimer.
243
244 * w32.c (term_ntproc): Call term_timers.
245 (init_ntproc): Make sure all signals are unblocked at startup, to
246 erase any traces of dumping. Call init_timers.
247
248 * w32fns.c (hourglass_timer, HOURGLASS_ID): Remove.
249 Windows-specific code to display the hourglass mouse pointer is no
250 longer used.
251 (w32_wnd_proc): Remove code that handled the WM_TIMER message due
252 to hourglass timer expiration.
253 (start_hourglass, cancel_hourglass, DEFAULT_HOURGLASS_DELAY):
254 Remove, no longer used.
b43d62ae
SM
255 (w32_note_current_window, show_hourglass, hide_hourglass):
256 New functions, in support of hourglass cursor display similar to other
c06c382a
EZ
257 window systems.
258 (syms_of_w32fns): Don't initialize hourglass_timer.
259
260 * xdisp.c (start_hourglass, cancel_hourglass): Now used on
261 WINDOWSNT as well.
262 (start_hourglass) [WINDOWSNT]: Call w32_note_current_window.
263
264 * w32.h (init_timers, term_timers): Add prototypes.
265
95402d5f
KH
2662012-09-30 Kenichi Handa <handa@gnu.org>
267
268 * coding.c (decode_coding_ccl, encode_coding_ccl): Pay attention
269 to the buffer relocation which may be caused by ccl_driver.
270
dd946752
JD
2712012-09-30 Jan Djärv <jan.h.d@swipnet.se>
272
d7e642cc
JD
273 * xfns.c (Fx_file_dialog): Update comment.
274
275 * w32fns.c (Fx_file_dialog): Update comment.
276
277 * nsfns.m (Fns_read_file_name): Add argument DIR_ONLY_P.
278 Initialize panel name field if OSX >= 10.6.
279
280 * fileio.c (Fnext_read_file_uses_dialog_p): Add HAVE_NS.
281
dd946752
JD
282 * nsfns.m (ns_frame_parm_handlers): Add x_set_fullscreen.
283
284 * nsterm.m (NEW_STYLE_FS): New define.
285 (ns_fullscreen_hook, windowWillEnterFullScreen)
286 (windowDidEnterFullScreen, windowWillExitFullScreen)
287 (windowDidExitFullScreen, toggleFullScreen, handleFS)
288 (setFSValue): New functions.
289 (EmacsFSWindow): New implementation.
290 (canBecomeKeyWindow): New function for EmacsFSWindow.
291 (ns_create_terminal): Set fullscreen_hook to ns_fullscreen_hook.
292 (dealloc): Release nonfs_window if in fullscreen.
293 (updateFrameSize:): Call windowDidMove to update top/left.
294 (windowWillResize:toSize:): Check if frame is still maximized.
295 (initFrameFromEmacs:): Initialize fs_state, fs_before_fs,
296 next_maximized, maximized_width, maximized_height and nonfs_window.
297 Call setCollectionBehavior if NEW_STYLE_FS. Initialize bwidth and
298 tbar_height.
299 (windowWillUseStandardFrame:defaultFrame:): Update frame parameter
300 fullscreen. Set maximized_width/height. Act on next_maximized.
301
302 * nsterm.h (MAC_OS_X_VERSION_10_7, MAC_OS_X_VERSION_10_8): New.
303 (EmacsView): Add variables for fullscreen.
304 (handleFS, setFSValue, toggleFullScreen): New in EmacsView.
305 (EmacsFSWindow): New interface for fullscreen.
306
427730eb
JB
3072012-09-30 Juanma Barranquero <lekktu@gmail.com>
308
309 * makefile.w32-in ($(BLD)/profiler.$(O)): Update dependencies.
310
48de8b12
CY
3112012-09-30 Chong Yidong <cyd@gnu.org>
312
313 * fns.c (Frandom): Doc fix.
314
5938d519
MR
3152012-09-30 Martin Rudalics <rudalics@gmx.at>
316
317 * window.c (Vwindow_combination_limit): New default value.
318 (Qwindow_size): New symbol replacing Qtemp_buffer_resize.
319
cb5b0266
PE
3202012-09-30 Paul Eggert <eggert@cs.ucla.edu>
321
322 * syssignal.h (PROFILER_CPU_SUPPORT): Don't define if PROFILING.
323 Suggested by Eli Zaretskii in
324 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00811.html>.
325
84f72efd
EZ
3262012-09-30 Eli Zaretskii <eliz@gnu.org>
327
328 * profiler.c (Fprofiler_cpu_stop): Use timer_settime only if
329 HAVE_TIMER_SETTIME is defined.
330
9d4dcdc9
PE
3312012-09-30 Paul Eggert <eggert@cs.ucla.edu>
332
d89460ed
PE
333 Profiler improvements: more-accurate timers, overflow checks.
334 * profiler.c: Don't include stdio.h, limits.h, sys/time.h,
335 signal.h, setjmp.h. Include systime.h instead.
336 (saturated_add): New function.
337 (record_backtrace, current_sample_interval): Use EMACS_INT, not size_t.
338 (record_backtrace, handle_profiler_signal): Saturate on fixnum overflow.
339 (profiler_timer, profiler_timer_ok) [HAVE_TIMER_SETTIME]:
340 New static vars.
84f72efd 341 (enum profiler_cpu_running): New enum.
d89460ed
PE
342 (profiler_cpu_running): Now of that enum type, not bool.
343 All uses changed to store the new value.
344 (handle_profiler_signal): Rename from sigprof_handler_1,
345 for consistency with other handlers. Do not check whether
346 cpu_log is a hash-table if garbage collecting, since it
347 doesn't matter in that case.
348 (deliver_profiler_signal): Rename from sigprof_handler,
349 for consistency with other handlers.
350 (setup_cpu_timer): New function, with much of what used to be in
351 Fprofiler_cpu_start. Check for out-of-range argument.
352 Prefer timer_settime if available, and prefer
353 thread cputime clocks, then process cputime clocks, then
354 monotonic clocks, to the old realtime clock. Use make_timeval
355 to round more-correctly when falling back to setitimer.
356 (Fprofiler_cpu_start): Use it.
357 (Fprofiler_cpu_stop): Prefer timer_settime if available.
358 Don't assume that passing NULL as the 2nd argument of setitimer
359 is the same as passing a pointer to all-zero storage.
360 Ignore SIGPROF afterwards.
361 (malloc_probe): Saturate at MOST_POSITIVE_FIXNUM.
362 * sysdep.c (emacs_sigaction_init): Also mask out SIGPROF in
363 non-fatal signal handlers. Ignore SIGPROF on startup.
364 * syssignal.h (PROFILER_CPU_SUPPORT): Define this macro here, not
365 in profiler.c, since sysdep.c now uses it.
366
9d4dcdc9
PE
367 * sysdep.c (handle_fatal_signal): Bump backtrace size to 40.
368 Suggested by Eli Zaretskii in
369 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00796.html>.
370
8e5691a0
JB
3712012-09-29 Juanma Barranquero <lekktu@gmail.com>
372
373 * makefile.w32-in ($(BLD)/profiler.$(O)): Update dependencies.
374
e7c1b6ef
SM
3752012-09-29 Stefan Monnier <monnier@iro.umontreal.ca>
376
377 * lisp.h (struct backtrace): Remove indirection for `function' field.
378 * xdisp.c (redisplay_internal):
379 * profiler.c (record_backtrace, sigprof_handler_1):
380 * alloc.c (Fgarbage_collect):
381 * eval.c (interactive_p, Fsignal, eval_sub, Ffuncall, Fbacktrace)
382 (Fbacktrace_frame): Adjust accordingly.
383
e61d39cd 3842012-09-28 Glenn Morris <rgm@gnu.org>
d393cefb
GM
385
386 * eval.c (Frun_hook_with_args, Frun_hook_with_args_until_success)
387 (Frun_hook_with_args_until_failure): Doc fixes.
388
404043ea
EZ
3892012-09-28 Eli Zaretskii <eliz@gnu.org>
390
391 * xdisp.c (syms_of_xdisp) <Qredisplay_internal>: Rename from
392 Qautomatic_redisplay and change the symbol name. All users changed.
393
704d3f45
TM
3942012-09-28 Tomohiro Matsuyama <tomo@cx4a.org>
395
396 * profiler.c (sigprof_handler): Fix race condition.
397
757140ff
GM
3982012-09-28 Glenn Morris <rgm@gnu.org>
399
400 * lread.c (lisp_file_lexically_bound_p): Handle #! lines. (Bug#12528)
401
a615a3ae
PE
4022012-09-27 Paul Eggert <eggert@cs.ucla.edu>
403
404 Check more robustly for timer_settime.
89d17fd0
PE
405 * Makefile.in (LIB_TIMER_TIME): New macro.
406 (LIBES): Add it.
a615a3ae
PE
407 * atimer.c (alarm_timer, alarm_timer_ok, set_alarm, init_atimer):
408 Use HAVE_TIMER_SETTIME, not SIGEV_SIGNAL, to decide whether to
409 call timer_settime.
410
3670daf7
TM
4112012-09-26 Tomohiro Matsuyama <tomo@cx4a.org>
412
413 * profiler.c (Fprofiler_cpu_start): Remove unnecessary flag SA_SIGINFO.
414
6a586b7f
JB
4152012-09-26 Juanma Barranquero <lekktu@gmail.com>
416
417 * makefile.w32-in ($(BLD)/profiler.$(O)): Update dependencies.
418
41c8bfcf
PE
4192012-09-26 Paul Eggert <eggert@cs.ucla.edu>
420
421 * character.h (MAYBE_UNIFY_CHAR): Remove.
422 * charset.c, charset.h (maybe_unify_char): Now static.
423 * charset.c (decode_char): Use maybe_unify_char, not MAYBE_UNIFY_CHAR.
424 Since this stuff is now private to charset.c, there's no need for
425 a public macro and no need to inline by hand.
426
3a880af4
SM
4272012-09-26 Tomohiro Matsuyama <tomo@cx4a.org>
428 Stefan Monnier <monnier@iro.umontreal.ca>
429 Juanma Barranquero <lekktu@gmail.com>
611b7507 430
3a880af4
SM
431 * profiler.c: New file.
432 * Makefile.in (base_obj): Add profiler.o.
611b7507
JB
433 * makefile.w32-in (OBJ2, GLOBAL_SOURCES): Add profiler.c.
434 ($(BLD)/profiler.$(O)): New target.
3a880af4
SM
435 * emacs.c (main): Call syms_of_profiler.
436 * alloc.c (Qautomatic_gc): New constant.
437 (MALLOC_PROBE): New macro.
438 (xmalloc, xzalloc, xrealloc, lisp_malloc, lisp_align_malloc): Use it.
439 (total_bytes_of_live_objects): New function.
440 (Fgarbage_collect): Use it. Record itself in backtrace_list.
441 Call malloc_probe for the memory profiler.
442 (syms_of_alloc): Define Qautomatic_gc.
443 * eval.c (eval_sub, Ffuncall): Reorder assignments to avoid
444 race condition.
445 (struct backtrace): Move definition...
446 * lisp.h (struct backtrace): ..here.
447 (Qautomatic_gc, profiler_memory_running): Declare vars.
448 (malloc_probe, syms_of_profiler): Declare functions.
449 * xdisp.c (Qautomatic_redisplay): New constant.
450 (redisplay_internal): Record itself in backtrace_list.
451 (syms_of_xdisp): Define Qautomatic_redisplay.
611b7507 452
5938d519 4532012-09-25 Eli Zaretskii <eliz@gnu.org>
b67238c2
JB
4542012-09-25 Juanma Barranquero <lekktu@gmail.com>
455
456 * makefile.w32-in ($(BLD)/callproc.$(O)): Update dependencies.
457
e26fd2e4
PE
4582012-09-25 Paul Eggert <eggert@cs.ucla.edu>
459
460 Prefer POSIX timers if available.
461 They avoid a race if the timer is too close to the current time.
462 * atimer.c (alarm_timer, alarm_timer_ok) [SIGEV_SIGNAL]: New static vars.
463 (set_alarm) [SIGEV_SIGNAL]: Use POSIX timers if available.
9180598c 464 (init_atimer) [SIGEV_SIGNAL]: Initialize them.
e26fd2e4 465
eedec3ee
EZ
4662012-09-25 Eli Zaretskii <eliz@gnu.org>
467
468 * coding.c (CHAR_STRING_ADVANCE_NO_UNIFY): Make it an alias of
469 CHAR_STRING_ADVANCE.
470 (STRING_CHAR_ADVANCE_NO_UNIFY): Make it an alias of
471 STRING_CHAR_ADVANCE.
472
aa15c6bb
JB
4732012-09-25 Juanma Barranquero <lekktu@gmail.com>
474
475 Move Vlibrary_cache to emacs.c and reset before dumping.
476
477 * lisp.h (reset_image_types): Declare.
478 [WINDOWSNT] (Vlibrary_cache): Declare.
479
480 * image.c (reset_image_types): New function.
481
482 * emacs.c [WINDOWSNT] (Vlibrary_cache): Move from w32.c.
483 (syms_of_emacs) [WINDOWSNT] <Vlibrary_cache>: Initialize and staticpro.
484 (Fdump_emacs): Reset Vlibrary_cache and image_types.
485
486 * w32.c (Vlibrary_cache): Do not define; moved to emacs.c
487 (globals_of_w32) <Vlibrary_cache>: Do not initialize.
488
489 * w32.h (Vlibrary_cache): Do not declare.
490
54d629be
EZ
4912012-09-25 Eli Zaretskii <eliz@gnu.org>
492
16b22fef
EZ
493 * w32proc.c (sys_signal): Handle all signals defined by the
494 MS-Windows runtime, not just SIGCHLD. Actually install the signal
495 handlers for signals supported by Windows. Don't override
496 term_ntproc as the handler for SIGABRT.
497 (sigaction): Rewrite to call sys_signal instead of duplicating its
498 code.
499 (sys_kill): Improve commentary.
500
501 * w32.c (term_ntproc): Accept (and ignore) one argument, for
502 consistency with a signature of a signal handler. All callers
503 changed.
504 (init_ntproc): Accept an argument DUMPING. If dumping, don't
505 install term_ntproc as a signal handler for SIGABRT, as that
506 should be done by the dumped Emacs.
507
508 * w32.h (init_ntproc, term_ntproc): Adjust prototypes.
509
510 * w32select.c (term_w32select): Protect against repeated
511 invocation by setting clipboard_owner to NULL after calling
512 DestroyWindow.
513
514 * emacs.c (shut_down_emacs, main): Adapt the calls to init_ntproc
515 and term_ntproc to their modified signatures.
516
54d629be
EZ
517 * character.c (char_string, string_char): Remove calls to
518 MAYBE_UNIFY_CHAR. See the discussion starting at
519 http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00433.html
520 for the details.
521
59f7af81
CY
5222012-09-25 Chong Yidong <cyd@gnu.org>
523
524 * xdisp.c (mode_line_inverse_video): Delete obsolete variable.
525
22e8cf4a
SM
5262012-09-24 Stefan Monnier <monnier@iro.umontreal.ca>
527
528 * bytecode.c (exec_byte_code): Signal an error instead of aborting,
529 when encountering an unknown bytecode.
530
578098f3
PE
5312012-09-24 Paul Eggert <eggert@cs.ucla.edu>
532
533 image.c, indent.c: Use bool for booleans.
534 * dispextern.h (struct image_type): Members valid_p, load, init
535 now return bool, not int. All uses changed.
536 * image.c: Omit unnecessary static decls.
537 (x_create_bitmap_mask, x_build_heuristic_mask):
538 Return void, not int, since callers don't care about the return value.
539 (x_create_bitmap_mask, define_image_type, valid_image_p)
540 (struct image_keyword, parse_image_spec, image_spec_value)
541 (check_image_size, image_background)
542 (image_background_transparent, x_clear_image_1)
543 (postprocess_image, lookup_image, x_check_image_size)
544 (x_create_x_image_and_pixmap, xbm_image_p)
545 (Create_Pixmap_From_Bitmap_Data, xbm_read_bitmap_data)
546 (xbm_load_image, xbm_file_p, xbm_load, xpm_lookup_color)
547 (init_xpm_functions, xpm_valid_color_symbols_p, xpm_image_p)
548 (xpm_load, xpm_load_image, lookup_rgb_color, lookup_pixel_color)
549 (x_to_xcolors, x_build_heuristic_mask, pbm_image_p, pbm_load)
550 (png_image_p, init_png_functions, png_load_body, png_load)
551 (jpeg_image_p, init_jpeg_functions, jpeg_load_body, jpeg_load)
552 (tiff_image_p, init_tiff_functions, tiff_load, gif_image_p)
553 (init_gif_functions, gif_load, imagemagick_image_p)
554 (imagemagick_load_image, imagemagick_load, svg_image_p)
555 (init_svg_functions, svg_load, svg_load_image, gs_image_p)
556 (gs_load):
557 * nsimage.m (ns_load_image):
558 * nsterm.m (ns_defined_color):
559 * xfaces.c (tty_lookup_color, tty_defined_color, defined_color):
560 * xfns.c (x_defined_color):
561 * xterm.c (x_alloc_lighter_color_for_widget)
562 (x_alloc_nearest_color_1, x_alloc_nearest_color)
563 (x_alloc_lighter_color):
564 * indent.c (disptab_matches_widthtab, current_column)
565 (scan_for_column, string_display_width, indented_beyond_p)
566 (compute_motion, vmotion, Fvertical_motion):
567 Use bool for booleans.
568
a5f2b6ec
CY
5692012-09-24 Chong Yidong <cyd@gnu.org>
570
571 * chartab.c (Fset_char_table_default): Obsolete function removed.
572
18e27ea8
PE
5732012-09-23 Paul Eggert <eggert@cs.ucla.edu>
574
afea8a8a
PE
575 Move pid_t related decls out of lisp.h.
576 * lisp.h, syswait.h (record_child_status_change, wait_for_termination)
577 (interruptible_wait_for_termination):
578 Move these decls from lisp.h to syswait.h, since they use pid_t.
579 Needed on FreeBSD; see Herbert J. Skuhra in
580 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00571.html>.
581 * callproc.c: Include syswait.h.
582
18e27ea8
PE
583 gnutls.c, gtkutil.c: Use bool for boolean.
584 * gnutls.c (gnutls_global_initialized, init_gnutls_functions)
585 (emacs_gnutls_handle_error):
586 * gtkutil.c (xg_check_special_colors, xg_prepare_tooltip)
587 (xg_hide_tooltip, xg_create_frame_widgets)
588 (create_dialog, xg_uses_old_file_dialog)
589 (xg_get_file_with_chooser, xg_get_file_with_selection)
590 (xg_get_file_name, xg_have_tear_offs, create_menus, xg_create_widget)
591 (xg_item_label_same_p, xg_update_menubar)
592 (xg_modify_menubar_widgets, xg_event_is_for_menubar)
593 (xg_ignore_gtk_scrollbar, xg_set_toolkit_scroll_bar_thumb)
594 (xg_event_is_for_scrollbar, xg_pack_tool_bar, xg_make_tool_item)
595 (is_box_type, xg_tool_item_stale_p, xg_update_tool_bar_sizes)
596 (update_frame_tool_bar, free_frame_tool_bar):
597 * gtkutil.c, w32term.c, xterm.c (x_wm_set_size_hint):
598 * nsmenu.m (ns_update_menubar):
599 * nsmenu.m, w32menu.c, xmenu.c (set_frame_menubar):
600 * xfns.c (Fx_show_tip) [USE_GTK]:
601 Use bool for boolean.
602 * gtkutil.c (xg_update_frame_menubar):
603 * xmenu.c (update_frame_menubar):
604 Return void, not int, since caller ignores return value.
605 * gtkutil.c (xg_change_toolbar_position):
606 Return void, not 1.
607
af0e9f75
JB
6082012-09-23 Juanma Barranquero <lekktu@gmail.com>
609
610 * makefile.w32-in (BLOCKINPUT_H): Remove.
611 (SYSSIGNAL_H): New macro.
612 ($(BLD)/alloc.$(O), $(BLD)/atimer.$(O), $(BLD)/buffer.$(O))
613 ($(BLD)/callproc.$(O), $(BLD)/data.$(O), $(BLD)/dired.$(O))
614 ($(BLD)/dispnew.$(O), $(BLD)/editfns.$(O), $(BLD)/emacs.$(O))
615 ($(BLD)/eval.$(O), $(BLD)/fileio.$(O), $(BLD)/floatfns.$(O))
616 ($(BLD)/fns.$(O), $(BLD)/fontset.$(O), $(BLD)/frame.$(O))
617 ($(BLD)/fringe.$(O), $(BLD)/image.$(O), $(BLD)/insdel.$(O))
618 ($(BLD)/keyboard.$(O), $(BLD)/keymap.$(O), $(BLD)/lread.$(O))
619 ($(BLD)/menu.$(O), $(BLD)/w32inevt.$(O), $(BLD)/w32proc.$(O))
620 ($(BLD)/print.$(O), $(BLD)/process.$(O), $(BLD)/ralloc.$(O))
621 ($(BLD)/search.$(O), $(BLD)/sound.$(O), $(BLD)/sysdep.$(O))
622 ($(BLD)/term.$(O), $(BLD)/window.$(O), $(BLD)/xdisp.$(O))
623 ($(BLD)/xfaces.$(O), $(BLD)/w32fns.$(O), $(BLD)/w32menu.$(O))
624 ($(BLD)/w32term.$(O), $(BLD)/w32select.$(O), $(BLD)/w32reg.$(O))
625 ($(BLD)/w32xfns.$(O)): Update dependencies.
626
5101529e
EZ
6272012-09-23 Eli Zaretskii <eliz@gnu.org>
628
629 * .gdbinit: Set breakpoint on terminate_due_to_signal, not on
630 fatal_error_backtrace.
631
632 * w32proc.c (sys_kill): Undo last change: don't do anything when
633 invoked to deliver SIGABRT to our own process. This is now
634 handled by emacs_raise.
635
2c3ee0ad
JB
6362012-09-23 Juanma Barranquero <lekktu@gmail.com>
637
638 * w32term.c (w32_read_socket): Remove leftover reference to
639 interrupt_input_pending.
640
62a1d661
PE
6412012-09-23 Paul Eggert <eggert@cs.ucla.edu>
642
643 Do not use SA_NODEFER.
644 Problem reported by Dani Moncayo in
645 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00557.html>.
646 * alloc.c (die):
647 * sysdep.c (emacs_abort): Do not reset signal handler.
648 * emacs.c (terminate_due_to_signal): Reset signal handler here.
649 * sysdep.c (init_signals): Do not use SA_NODEFER. It wasn't
650 wanted even on POSIXish hosts, and it doesn't work on Windows.
651
a0942b9a
JD
6522012-09-23 Jan Djärv <jan.h.d@swipnet.se>
653
654 * xterm.c (x_term_init): Call fixup_locale before and after calling
655 gtk_init (Bug#12392).
656
d07ff9db
CY
6572012-09-23 Chong Yidong <cyd@gnu.org>
658
659 * w32.c (w32_delayed_load): Remove LIBRARIES argument; always use
660 Vdynamic_library_alist.
661
662 * gnutls.c (init_gnutls_functions): Caller changed; remove arg.
663 (Fgnutls_available_p): Caller changed.
664
665 * xml.c (init_libxml2_functions, Flibxml_parse_html_region)
666 (Flibxml_parse_xml_region): Likewise.
667
668 * dispextern.h (struct image_type): Remove arg from init function.
669
670 * image.c (Finit_image_library, lookup_image_type)
671 (define_image_type): Remove now-unneeded second arg.
672 (init_xpm_functions, init_png_functions, init_jpeg_functions)
673 (init_tiff_functions, init_gif_functions, init_svg_functions):
674 Arglist and w32_delayed_load calling convention changed.
675 (gs_type): Remove init_gs_functions; there is no such function.
641cfd14 676 (valid_image_p, make_image): Fix caller to lookup_image_type.
d07ff9db 677
4d7e6e51
PE
6782012-09-23 Paul Eggert <eggert@cs.ucla.edu>
679
680 Simplify and avoid signal-handling races (Bug#12471).
681 * alloc.c (die):
682 * sysdep.c (emacs_abort) [HAVE_NTGUI]:
683 Avoid recursive loop if there's a fatal error in the function itself.
684 * atimer.c (pending_atimers):
685 * blockinput.h: Don't include "atimer.h"; no longer needed.
686 (interrupt_input_pending): Remove. All uses removed.
687 pending_signals now counts both atimers and ordinary interrupts.
688 This is less racy than having three separate pending-signal flags.
689 (block_input, unblock_input, totally_unblock_input, unblock_input_to)
690 (input_blocked_p):
691 Rename from their upper-case counterparts BLOCK_INPUT,
692 UNBLOCK_INPUT, TOTALLY_UNBLOCK_INPUT, UNBLOCK_INPUT_TO,
693 INPUT_BLOCKED_P, and turn into functions. All uses changed.
694 This makes it easier to access volatile variables more accurately.
695 (BLOCK_INPUT_RESIGNAL): Remove. All uses replaced by unblock_input ().
696 (input_blocked_p): Prefer this to 'interrupt_input_blocked', as
697 that's more reliable if the code is buggy and sets
698 interrupt_input_blocked to a negative value. All uses changed.
699 * atimer.c (deliver_alarm_signal):
700 Remove. No need to deliver this to the parent; any thread can
701 handle this signal now. All uses replaced by underlying handler.
702 * atimer.c (turn_on_atimers):
703 * dispnew.c (handle_window_change_signal):
704 * emacs.c (handle_danger_signal):
705 * keyboard.c (kbd_buffer_get_event):
706 Don't reestablish signal handler; not needed with sigaction.
707 * blockinput.h (UNBLOCK_INPUT_TO, TOTALLY_UNBLOCK_INPUT)
708 (UNBLOCK_INPUT_TO):
709 Rework to avoid unnecessary accesses to volatile variables.
710 (UNBLOCK_INPUT_TO): Now a function.
711 (totally_unblock_input, unblock_input): New decls.
712 * data.c (handle_arith_signal, deliver_arith_signal): Move to sysdep.c
713 (init_data): Remove. Necessary stuff now done in init_signal.
714 * emacs.c, xdisp.c: Include "atimer.h", since we invoke atimer functions.
715 * emacs.c (handle_fatal_signal, deliver_fatal_signal): Move to sysdep.c.
716 (fatal_error_code): Remove; no longer needed.
717 (terminate_due_to_signal): Rename from fatal_error_backtrace, since
718 it doesn't always backtrace. All uses changed. No need to reset
719 signal to default, since sigaction and/or die does that for us now.
720 Use emacs_raise (FOO), not kill (getpid (), FOO).
721 (main): Check more-accurately whether we're dumping.
722 Move fatal-error setup to sysdep.c
723 * floatfns.c: Do not include "syssignal.h"; no longer needed.
724 * gtkutil.c (xg_get_file_name, xg_get_font):
725 Remove no-longer-needed signal-mask manipulation.
726 * keyboard.c, process.c (POLL_FOR_INPUT):
727 Don't depend on USE_ASYNC_EVENTS, a symbol that is never defined.
728 * keyboard.c (read_avail_input): Remove.
729 All uses replaced by gobble_input.
730 (Ftop_level): Use TOTALLY_UNBLOCK_INPUT rather than open code.
731 (kbd_buffer_store_event_hold, gobble_input):
732 (record_asynch_buffer_change) [USABLE_SIGIO]:
733 (store_user_signal_events):
734 No need to mess with signal mask.
735 (gobble_input): If blocking input and there are terminals, simply
736 set pending_signals to 1 and return. All hooks changed to not
737 worry about whether input is blocked.
738 (process_pending_signals): Clear pending_signals before processing
739 them, in case a signal comes in while we're processing.
740 By convention callers now test pending_signals before calling us.
741 (UNBLOCK_INPUT_TO, unblock_input, totally_unblock_input):
742 New functions, to support changes to blockinput.h.
743 (handle_input_available_signal): Now extern.
744 (reinvoke_input_signal): Remove. All uses replaced by
745 handle_async_input.
746 (quit_count): Now volatile, since a signal handler uses it.
3a880af4
SM
747 (handle_interrupt): Now takes bool IN_SIGNAL_HANDLER as arg.
748 All callers changed. Block SIGINT only if not already blocked.
4d7e6e51
PE
749 Clear sigmask reliably, even if Fsignal returns, which it can.
750 Omit unnecessary accesses to volatile var.
751 (quit_throw_to_read_char): No need to restore sigmask.
752 * keyboard.c (gobble_input, handle_user_signal):
753 * process.c (wait_reading_process_output):
754 Call signal-handling code rather than killing ourselves.
755 * lisp.h: Include <float.h>, for...
756 (IEEE_FLOATING_POINT): New macro, moved here to avoid duplication.
757 (pending_signals): Now volatile.
758 (syms_of_data): Now const if IEEE floating point.
759 (handle_input_available_signal) [USABLE_SIGIO]:
760 (terminate_due_to_signal, record_child_status_change): New decls.
761 * process.c (create_process): Avoid disaster if memory is exhausted
762 while we're processing a vfork, by tightening the critical section
763 around the vfork.
764 (send_process_frame, process_sent_to, handle_pipe_signal)
765 (deliver_pipe_signal): Remove. No longer needed, as Emacs now
766 ignores SIGPIPE.
767 (send_process): No need for setjmp/longjmp any more, since the
768 SIGPIPE stuff is now gone. Instead, report an error if errno
769 is EPIPE.
770 (record_child_status_change): Now extern. PID and W are now args.
771 Return void, not bool. All callers changed.
772 * sysdep.c (wait_debugging) [(BSD_SYSTEM || HPUX) && !defined (__GNU__)]:
773 Remove. All uses removed. This bug should be fixed now in a
774 different way.
775 (wait_for_termination_1): Use waitpid rather than sigsuspend,
776 and record the child status change directly. This avoids the
777 need to futz with the signal mask.
778 (process_fatal_action): Move here from emacs.c.
779 (emacs_sigaction_flags): New function, containing
780 much of what used to be in emacs_sigaction_init.
781 (emacs_sigaction_init): Use it. Block nonfatal system signals that are
782 caught by emacs, to make races less likely.
783 (deliver_process_signal): Rename from handle_on_main_thread.
784 All uses changed.
785 (BACKTRACE_LIMIT_MAX): Now at top level.
786 (thread_backtrace_buffer, threadback_backtrace_pointers):
787 New static vars.
788 (deliver_thread_signal, deliver_fatal_thread_signal):
789 New functions, for more-accurate delivery of thread-specific signals.
790 (handle_fatal_signal, deliver_fatal_signal): Move here from emacs.c.
791 (deliver_arith_signal): Handle in this thread, not
792 in the main thread, since it's triggered by this thread.
793 (maybe_fatal_sig): New function.
794 (init_signals): New arg DUMPING so that we can be more accurate
795 about whether we're dumping. Caller changed.
796 Treat thread-specific signals differently from process-general signals.
797 Block all signals while handling fatal error; that's safer.
798 xsignal from SIGFPE only on non-IEEE hosts, treating it as fatal
799 on IEEE hosts.
800 When batch, ignore SIGHUP, SIGINT, SIGTERM if they were already ignored.
801 Ignore SIGPIPE unless batch.
802 (emacs_backtrace): Output backtrace for the appropriate thread,
803 which is not necessarily the main thread.
804 * syssignal.h: Include <stdbool.h>.
805 (emacs_raise): New macro.
806 * xterm.c (x_connection_signal): Remove; no longer needed
807 now that we use sigaction.
808 (x_connection_closed): No need to mess with sigmask now.
809 (x_initialize): No need to reset SIGPIPE handler here, since
810 init_signals does this for us now.
811
8f4635e9
JD
8122012-09-23 Jan Djärv <jan.h.d@swipnet.se>
813
814 * nsterm.m (ns_dumpglyphs_image): dr is a new rect to draw image into,
fb39b937 815 background rect may be larger (Bug#12245).
8f4635e9 816
3296976d
CY
8172012-09-23 Chong Yidong <cyd@gnu.org>
818
819 * keyboard.c (timer_check): Avoid quitting during Fcopy_sequence.
820
d41e491e
PE
8212012-09-22 Paul Eggert <eggert@cs.ucla.edu>
822
823 * .gdbinit: Just stop at fatal_error_backtrace.
824 See Stefan Monnier's request in
825 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00549.html>.
826 Remove no-longer-used query of system type.
827
c88b867f
CY
8282012-09-22 Chong Yidong <cyd@gnu.org>
829
830 * search.c (Freplace_match): Doc fix (Bug#12325).
831
832 * minibuf.c (Finternal_complete_buffer): Doc fix (Bug#12391).
833
834 * editfns.c (Fline_beginning_position): Doc fix (Bug#12416).
835 (Fline_end_position): Doc fix.
836
837 * cmds.c (Fforward_char, Fbackward_char): Doc fix (Bug#12414).
838
bb4d86b4
CY
8392012-09-22 Chong Yidong <cyd@gnu.org>
840
841 * dispextern.h (struct image_type): Add new slot, storing a type
842 initialization function.
843
844 * image.c (define_image_type): Call the image initializer function
845 if it is defined. Arguments and return value changed.
846 (valid_image_p, make_image): Callers changed.
847 (xbm_type, xpm_type, pbm_type, png_type, jpeg_type, tiff_type)
3a880af4
SM
848 (gif_type, imagemagick_type, svg_type, gs_type):
849 Add initialization functions.
bb4d86b4
CY
850 (Finit_image_library): Call lookup_image_type.
851 (CHECK_LIB_AVAILABLE): Macro deleted.
852 (lookup_image_type): Call define_image_type here, rather than via
853 Finit_image_library, and without using CHECK_LIB_AVAILABLE.
854 (syms_of_image): Move define_image_type calls for xbm_type and
855 pbm_type to lookup_image_type.
856
df9685f3
EZ
8572012-09-22 Eli Zaretskii <eliz@gnu.org>
858
859 * keyboard.c (timer_check_2): Move calculation of 'timers' and
860 'idle_timers' from here ...
861 (timer_check): ... to here. Use Fcopy_sequence to copy the timer
862 lists, to avoid infloops when the timer does something stupid,
863 like reinvoke itself with the same or smaller time-out.
864 (Bug#12447)
865
8e17c9ba
MR
8662012-09-22 Martin Rudalics <rudalics@gmx.at>
867
868 * window.c (Fsplit_window_internal): Handle only Qt value of
869 Vwindow_combination_limit separately.
870 (Qtemp_buffer_resize): New symbol.
3a880af4
SM
871 (Vwindow_combination_limit): New default value.
872 Rewrite doc-string.
8e17c9ba 873
589bd69b
EZ
8742012-09-22 Eli Zaretskii <eliz@gnu.org>
875
876 * xdisp.c (next_overlay_string): Initialize it->end_charpos for
877 the new overlay string. (Bug#10159)
878
01108e3f
PE
8792012-09-22 Paul Eggert <eggert@cs.ucla.edu>
880
881 * emacs.c (shut_down_emacs): Don't assume stderr is buffered,
882 or that fprintf is async-signal-safe. POSIX doesn't require
883 either assumption.
884
82f8cd94
CY
8852012-09-22 Chong Yidong <cyd@gnu.org>
886
887 * buffer.c (Fset_buffer_modified_p): Handle indirect buffers
888 (Bug#8207).
889
3cccbd87
KH
8902012-09-22 Kenichi Handa <handa@gnu.org>
891
892 * composite.c (composition_reseat_it): Handle the case that a
893 grapheme cluster is not covered by a single font (Bug#12352).
894
09c01941
CY
8952012-09-21 Chong Yidong <cyd@gnu.org>
896
897 * image.c (define_image_type): Avoid adding duplicate types to
898 image_types (Bug#12463). Suggested by Jörg Walter.
899
acfa068f 9002012-09-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
e25c1a30
YM
901
902 * unexmacosx.c: Define LC_DATA_IN_CODE if not defined.
903 (print_load_command_name): Add case LC_DATA_IN_CODE.
904 (dump_it) [LC_DATA_IN_CODE]: Call copy_linkedit_data.
905
acfa068f 9062012-09-21 Glenn Morris <rgm@gnu.org>
1e9bbf47
GM
907
908 * eval.c (Frun_hook_with_args_until_success)
909 (Frun_hook_with_args_until_failure): Doc fixes. (Bug#12393)
910
acfa068f 9112012-09-21 Andreas Schwab <schwab@linux-m68k.org>
c6ba4138
AS
912
913 * fileio.c (Ffile_selinux_context): Only call freecon when
914 lgetfilecon succeeded.
915 (Fset_file_selinux_context): Likewise. (Bug#12444)
916
acfa068f 9172012-09-21 Eli Zaretskii <eliz@gnu.org>
aa36e4d2
EZ
918
919 * xdisp.c (try_window_reusing_current_matrix): Under bidi
920 reordering, locate the cursor by calling set_cursor_from_row; if
921 that fails, clear the desired glyph matrix before returning a
922 failure indication to the caller. Fixes leaving garbled display
923 when fast scrolling with a down-key. (Bug#12403)
f2016bea
EZ
924 (compute_stop_pos_backwards): Fix a typo that caused crashes while
925 scrolling through multibyte text.
aa36e4d2 926
e99f70c8
SM
9272012-09-20 Stefan Monnier <monnier@iro.umontreal.ca>
928
929 * alloc.c (mark_object) <PVEC_WINDOW>: Mark prev/next_buffers *after*
930 calling mark_vectorlike since that's the one that marks the window.
931 (mark_discard_killed_buffers): Mark the final cdr.
932 * window.h (struct window): Move prev/next_buffers to the
933 non-standard fields.
934 * window.c (make_window): Initialize prev/next_buffers manually.
935
f75beb47
PE
9362012-09-20 Paul Eggert <eggert@cs.ucla.edu>
937
938 Omit unused arg EXPECTED from socket hooks.
939 * keyboard.c (gobble_input, read_avail_input, tty_read_avail_input):
940 * nsterm.m (ns_term_init):
941 * termhooks.h (struct terminal.read_socket_hook):
942 * w32inevt.c (w32_console_read_socket):
943 * w32term.c (w32_read_socket):
944 * xterm.c (XTread_socket):
945 Omit unused arg EXPECTED. All callers changed.
946 (store_user_signal_events): Return void, not int, since callers no
947 longer care about the return value. All uses changed.
948
b019b76a
JB
9492012-09-20 Juanma Barranquero <lekktu@gmail.com>
950
951 * w32gui.h (XParseGeometry): Do not declare.
952
05642592
PE
9532012-09-19 Paul Eggert <eggert@cs.ucla.edu>
954
e4bce92a
PE
955 * w32inevt.c (w32_console_read_socket): Return -1 on failure, not 0.
956 Ignore 'expected'. See Eli Zaretskii in
957 <http://bugs.gnu.org/12471#8> (last line).
958
05642592
PE
959 * frame.c (read_integer): Remove. All uses replaced by strtol/strtoul.
960 (XParseGeometry): Now static. Substitute extremal values for
961 values that are out of range.
962
e543ae91
JD
9632012-09-19 Jan Djärv <jan.h.d@swipnet.se>
964
965 * w32xfns.c (read_integer, XParseGeometry): Move to frame.c.
966
967 * nsfns.m (XParseGeometry): Remove.
968 (Fx_create_frame): Call x_set_offset to correctly interpret
969 top_pos in geometry.
970
3a880af4 971 * frame.c (read_integer, XParseGeometry): Move from w32xfns.c.
e543ae91
JD
972 (Fx_parse_geometry): If there is a space in string, call
973 Qns_parse_geometry, otherwise do as on other terms (Bug#12368).
974
45ba16c7
EZ
9752012-09-17 Eli Zaretskii <eliz@gnu.org>
976
c8b9f1bc
EZ
977 * search.c (scan_buffer): Use character positions in calls to
978 region_cache_forward and region_cache_backward, not byte
979 positions. (Bug#12196)
980
b4c932a2
EZ
981 * w32term.c (w32_read_socket): Set pending_signals to 1, like
982 xterm.c does. Reported by Daniel Colascione <dancol@dancol.org>.
983
45ba16c7
EZ
984 * ralloc.c (r_alloc_init) [!SYSTEM_MALLOC]: Initialize
985 __malloc_extra_blocks to 32 instead of 64, like alloc.c did in
986 emacs_blocked_malloc, now deleted.
987
eeceac93
PE
9882012-09-17 Paul Eggert <eggert@cs.ucla.edu>
989
990 Remove no-longer-needed Solaris 2.4 vfork bug workaround.
991 The workaround was for improving performance on Solaris 2.4, but
992 is getting in the way now. Emacs will still work if someone is
993 still running Solaris 2.4 in a museum somewhere; Sun dropped
994 support for Solaris 2.4 in 2003.
995 * callproc.c (Fcall_process) [HAVE_WORKING_VFORK]:
996 * process.c (create_process) [HAVE_WORKING_VFORK]:
997 Omit now-unnecessary workaround for the Solaris 2.4 vfork bug,
998 since Emacs no longer uses vfork on that platform.
999
78f83752
GM
10002012-09-17 Glenn Morris <rgm@gnu.org>
1001
1002 * emacs.c: Use COPYRIGHT.
1003
634b8cac
PE
10042012-09-16 Paul Eggert <eggert@cs.ucla.edu>
1005
0caaedb1
PE
1006 Remove configure's --without-sync-input option (Bug#12450).
1007 When auditing signal-handling in preparation for cleaning it up,
1008 I found that SYNC_INPUT has race conditions and would be a real
1009 pain to fix. Since it's an undocumented and deprecated
1010 configure-time option, now seems like a good time to remove it.
1011 Also see <http://bugs.gnu.org/11080#16>.
1012 * alloc.c (_bytes_used, __malloc_extra_blocks, _malloc_internal)
1013 (_free_internal) [!DOUG_LEA_MALLOC]: Remove decls.
1014 (alloc_mutex) [!SYSTEM_MALLOC && !SYNC_INPUT && HAVE_PTHREAD]:
1015 (malloc_hysteresis):
1016 (check_depth) [XMALLOC_OVERRUN_CHECK]:
1017 (MALLOC_BLOCK_INPUT, MALLOC_UNBLOCK_INPUT):
1018 (__malloc_hook, __realloc_hook, __free_hook, BYTES_USED)
1019 (dont_register_blocks, bytes_used_when_reconsidered)
1020 (bytes_used_when_full, emacs_blocked_free, emacs_blocked_malloc)
1021 (emacs_blocked_realloc, reset_malloc_hooks, uninterrupt_malloc):
1022 [!SYSTEM_MALLOC && !SYNC_INPUT]:
1023 Remove. All uses removed.
1024 (MALLOC_BLOCK_INPUT, MALLOC_UNBLOCK_INPUT): Use a different
1025 implementation, one that depends on whether the new macro
1026 XMALLOC_BLOCK_INPUT_CHECK is defined, not on whether SYNC_INPUT
1027 is defined.
1028 * atimer.c (run_timers, handle_alarm_signal):
1029 * keyboard.c (pending_signal, poll_for_input_1, poll_for_input)
1030 (handle_async_input, process_pending_signals)
1031 (handle_input_available_signal, init_keyboard):
1032 * nsterm.m (ns_read_socket):
1033 * process.c (wait_reading_process_output):
1034 * regex.c (immediate_quit, IMMEDIATE_QUIT_CHECK):
1035 * sysdep.c (emacs_sigaction_init) [SA_RESTART]:
1036 (emacs_write):
1037 * xterm.c (XTread_socket):
1038 Assume SYNC_INPUT.
1039 * conf_post.h (SA_RESTART) [IRIX6_5]: Do not #undef.
1040 * eval.c (handling_signal): Remove. All uses removed.
1041 * lisp.h (ELSE_PENDING_SIGNALS): Remove.
1042 All uses replaced with the SYNC_INPUT version.
1043 (reset_malloc_hooks, uninterrupt_malloc, handling_signal):
1044 Remove decls.
1045 * sysdep.c, syssignal.h (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
1046 Now static.
1047
634b8cac
PE
1048 * font.c (Ffont_shape_gstring): Remove unused local.
1049
83da1b55
GM
10502012-09-16 Glenn Morris <rgm@gnu.org>
1051
518650a5
GM
1052 * Makefile.in (clean): No longer run nextstep's clean.
1053
83da1b55
GM
1054 * Makefile.in (ns_appdir, ns_appbindir, ns_appsrc): Remove variables.
1055 (ns_frag): Remove.
1056 (ns-app): Move here from ns.mk, and simplify.
1057 (clean): Simplify nextstep entry.
1058 * ns.mk: Remove file.
1059
85a43e2e
KH
10602012-09-17 Kenichi Handa <handa@gnu.org>
1061
1062 * font.c (Ffont_shape_gstring): Fix previous change; GLYPHs may
1063 not covert the last few charactes.
1064
ba13e616 10652012-09-16 Kenichi Handa <handa@gnu.org>
ea964864
KH
1066
1067 * font.c (Ffont_shape_gstring): Don't adjust grapheme cluster
1068 here, but just check the validity of glyphs in the glyph-string.
1069
a8c729af
MR
10702012-09-16 Martin Rudalics <rudalics@gmx.at>
1071
3a880af4
SM
1072 * window.c (Fwindow_parameter, Fset_window_parameter):
1073 Accept any window as argument (Bug#12452).
a8c729af 1074
c077c059
JD
10752012-09-16 Jan Djärv <jan.h.d@swipnet.se>
1076
1077 * nsfns.m (Fx_open_connection): Move initialization of ns_*_types
1078 to ns_term_init to avoid memory leak.
1079
1080 * nsterm.m (ns_update_begin): Initialize bp after lcokFocus, use
1081 explicit retain/release.
1082 (ns_term_init): Only allow one display. Initialize outerpool and
1083 ns_*_types.
1084
39a57ad0
PE
10852012-09-15 Paul Eggert <eggert@cs.ucla.edu>
1086
1087 Port _setjmp fix to POSIXish hosts as well as Microsoft.
1088 * image.c (_setjmp) [!HAVE__SETJMP]: Restore definition, as
1089 it's needed on POSIXish hosts that lack _setjmp. Attempt to solve
1090 the Microsoft problem in a different way, by altering ../nt/config.nt.
1091
7105c8cb
EZ
10922012-09-15 Eli Zaretskii <eliz@gnu.org>
1093
1094 * w32xfns.c:
1095 * w32uniscribe.c:
1096 * w32term.c:
1097 * w32select.c:
1098 * w32reg.c:
1099 * w32proc.c:
1100 * w32menu.c:
1101 * w32inevt.c:
1102 * w32heap.c:
1103 * w32font.c:
1104 * w32fns.c:
1105 * w32console.c:
1106 * w32.c:
1107 * w16select.c: Remove inclusion of setjmp.h, as it is now included
1108 by lisp.h. This completes removal of setjmp.h inclusion
1109 erroneously announced in the previous commit. (Bug#12446)
1110
1111 * lisp.h [!HAVE__SETJMP, !HAVE_SIGSETJMP]: Make the commentary
1112 more accurate.
1113
1114 * image.c (_setjmp) [!HAVE__SETJMP]: Define only if 'setjmp' is
1115 not defined as a macro. The latter happens on MS-Windows.
1116 (Bug#12446)
1117
0328b6de
PE
11182012-09-15 Paul Eggert <eggert@cs.ucla.edu>
1119
1120 Port better to POSIX hosts lacking _setjmp (Bug#12446).
1121 * lisp.h: Include <setjmp.h> here, since we use its symbols here.
7105c8cb 1122 Some instances of '#include <setjmp.h>' removed, if the
0328b6de
PE
1123 only reason for the instance was because "lisp.h" was included.
1124 (sys_jmp_buf, sys_setjmp, sys_longjmp): New symbols.
1125 Unless otherwise specified, replace all uses of jmp_buf, _setjmp,
1126 and _longjmp with the new symbols. Emacs already uses _setjmp if
1127 available, so this change affects only POSIXish hosts that have
1128 sigsetjmp but not _setjmp, such as some versions of Solaris and
1129 Unixware. (Also, POSIX-2008 marks _setjmp as obsolescent.)
1130 * image.c (_setjmp, _longjmp) [HAVE_PNG && !HAVE__SETJMP]: New macros.
1131 (png_load_body) [HAVE_PNG]:
1132 (PNG_LONGJMP) [HAVE_PNG && PNG_LIBPNG_VER < 10500]:
1133 (PNG_JMPBUF) [HAVE_PNG && PNG_LIBPNG_VER >= 10500]:
1134 Use _setjmp and _longjmp rather than sys_setjmp and sys_longjmp,
1135 since PNG requires jmp_buf. This is the only exception to the
1136 general rule that we now use sys_setjmp and sys_longjmp.
1137 This exception is OK since this code does not change the signal
1138 mask or longjmp out of a signal handler.
1139
2af03429
PE
11402012-09-14 Paul Eggert <eggert@cs.ucla.edu>
1141
1142 * alloc.c [!SYSTEM_MALLOC && !SYNC_INPUT && HAVE_PTHREAD]:
1143 Include "syssignal.h", for 'main_thread'.
1144
2f294edf
DA
11452012-09-14 Dmitry Antipov <dmantipov@yandex.ru>
1146
1147 Avoid out-of-range marker position (Bug#12426).
3a880af4
SM
1148 * insdel.c (replace_range, replace_range_2):
1149 Adjust markers before overlays, as suggested by comments.
2f294edf
DA
1150 (insert_1_both, insert_from_buffer_1, adjust_after_replace):
1151 Remove redundant check before calling offset_intervals.
1152
6b533e9c
MR
11532012-09-14 Martin Rudalics <rudalics@gmx.at>
1154
1155 * xdisp.c (Fformat_mode_line): Unconditionally save/restore
1156 current buffer (Bug#12387).
1157
2a7931e3
JB
11582012-09-14 Juanma Barranquero <lekktu@gmail.com>
1159
1160 * makefile.w32-in ($(BLD)/alloc.$(O)): Update dependencies.
1161
c18e885b
PE
11622012-09-13 Paul Eggert <eggert@cs.ucla.edu>
1163
1164 Use a more backwards-compatible timer format (Bug#12430).
1165 * keyboard.c (decode_timer): Get PSECS from the 8th (origin-0)
1166 vector element, not from the 4th, since PSECS is now at the end.
1167 (Fcurrent_idle_time): Doc fix.
1168
d59a1afb
DA
11692012-09-13 Dmitry Antipov <dmantipov@yandex.ru>
1170
1171 Function to mark objects and remove killed buffers at once.
1172 * alloc.c (discard_killed_buffers): Rename to ...
1173 (mark_discard_killed buffers) ... new name. Add marking
1174 of remaining objects. Fix comment. Adjust users.
1175 (mark_object): Do not touch frame buffer lists here.
1176 * frame.c (delete_frame): Reset frame buffer lists here.
1177
5f0cb45a
PE
11782012-09-13 Paul Eggert <eggert@cs.ucla.edu>
1179
8ea47e3a
PE
1180 Better workaround for GNOME bug when --enable-gcc-warnings.
1181 * emacsgtkfixed.c (G_STATIC_ASSERT): Remove, undoing last change.
1182 Instead, disable -Wunused-local-typedefs. See Dmitry Antipov in
1183 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00335.html>.
1184
4a4bbad2
PE
1185 Simplify SIGIO usage (Bug#12408).
1186 The code that dealt with SIGIO was crufty and confusing, e.g., it
1187 played tricks like "#undef SIGIO" but these tricks were not used
1188 consistently. Simplify mostly by not #undeffing standard symbols,
1189 e.g., use "defined USABLE_SIGIO" (our symbol, which we can define
1190 or not as we please) rather than "defined SIGIO" (standard symbol
1191 that we probably shouldn't #undef).
1192 * conf_post.h [USG5_4]: Do not include <sys/wait.h> here.
1193 Modules that need it can include it.
1194 [USG5_4 && emacs]: Likewise, do not include the streams stuff here.
1195 * dispextern.h (ignore_sigio): New decl.
1196 * emacs.c (shut_down_emacs): Invoke unrequest_sigio
1197 unconditionally, since it's now a no-op if !USABLE_SIGIO.
1198 * emacs.c (shut_down_emacs):
1199 * keyboard.c (kbd_buffer_store_event_hold):
1200 Use ignore_sigio rather than invoking 'signal' directly.
1201 * keyboard.c (USABLE_FIONREAD && USG5_4): Include <sys/filio.h>,
1202 for FIONREAD.
1203 (FIONREAD, SIGIO): Do not #undef.
1204 (tty_read_avail_input): Use #error rather than a syntax error.
1205 * process.c [USG5_4]: Include <sys/stream.h> and <sys/stropts.h>,
1206 for I_PIPE, used by SETUP_SLAVE_PTY.
1207 (DATAGRAM_SOCKETS): Simplify defn, based on USABLE_FIONREAD.
1208 * sysdep.c (croak): Remove; no longer needed. This bit of
1209 temporary code, with Fred N. Fish's comment that it's temporary,
1210 has been in Emacs since at least 1992!
1211 (init_sigio, reset_sigio, request_sigio, unrequest_sigio):
1212 Arrange for them to be no-ops in all cases when ! USABLE_SIGIO.
1213 * syssignal.h (croak): Remove decl.
1214 (SIGIO, SIGPOO, SIGAIO, SIGPTY): Do not #undef; that's too fragile.
1215 * systty.h [!NO_TERMIO]: Do not include <termio.h>; no longer needed
1216 now that we're termios-only.
1217 (FIONREAD, ASYNC) [BROKEN_FIONREAD]: Do not #undef.
1218 * term.c (dissociate_if_controlling_tty): Use #error rather than
1219 a run-time error.
1220
5f0cb45a
PE
1221 Work around GCC and GNOME bugs when --enable-gcc-warnings.
1222 * emacsgtkfixed.c (G_STATIC_ASSERT): Redefine to use 'verify',
1223 to work around GNOME bug 683906.
1224 * image.c (jpeg_load_body) [HAVE_JPEG && lint]: Pacify gcc -Wclobber.
1225 (struct my_jpeg_error_mgr) [HAVE_JPEG && lint]: New member fp.
1226 This works around GCC bug 54561.
1227
40bce90b
PE
12282012-09-12 Paul Eggert <eggert@cs.ucla.edu>
1229
1230 More fixes for 'volatile' and setjmp/longjmp.
1231 * eval.c (Fdefvar, Fcondition_case): Remove unnecessary 'volatile's.
1232 * image.c (struct png_load_context) [HAVE_PNG]: New type.
1233 (png_load_body) [HAVE_PNG]:
1234 (jpeg_load_body) [HAVE_JPEG]:
1235 New function, with most of the old parent function's body.
1236 (png_load) [HAVE_PNG]:
1237 (jpeg_load) [HAVE_JPEG]:
1238 Invoke the new function, to avoid longjmp munging our locals.
1239 (struct my_jpeg_error_mgr) [HAVE_JPEG]: New members cinfo, failure_code.
1240 (my_error_exit) [HAVE_JPEG]: Don't trust 'setjmp' to return 2 when
1241 longjmp is passed 2, as the C standard doesn't guarantee this.
1242 Instead, store the failure code into mgr->failure_code.
1243
bfeae2cf
SM
12442012-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1245
1246 * keyboard.c (read_char, requeued_events_pending_p, Finput_pending_p)
1247 (Fdiscard_input, quit_throw_to_read_char, init_keyboard)
1248 (syms_of_keyboard): Remove support for unread-command-char.
1249
8099e36b
EZ
12502012-09-12 Eli Zaretskii <eliz@gnu.org>
1251
1252 * w32proc.c (sys_kill): If PID is our process ID and the signal is
1253 SIGABRT, call emacs_abort. Avoids silently exiting upon assertion
1254 violation. (Bug#12426)
1255
92547ff9
PE
12562012-09-12 Paul Eggert <eggert@cs.ucla.edu>
1257
1258 * image.c (jpeg_memory_src): Don't assume string len fits in unsigned.
1259
45b82ad0
SM
12602012-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1261
1262 * eval.c: Add `inhibit-debugger'.
1263 (Qinhibit_debugger): New symbol.
1264 (call_debugger): Bind it instead of Qdebug_on_error.
1265 (maybe_call_debugger): Test Vinhibit_debugger.
1266 (syms_of_eval): Define inhibit-debugger.
1267 * xdisp.c (set_message): Don't bind Qinhibit_debug_on_message.
1268 (syms_of_xdisp): Remove inhibit-debug-on-message.
1269
5779a1dc
PE
12702012-09-11 Paul Eggert <eggert@cs.ucla.edu>
1271
50f2e553
PE
1272 Avoid _setjmp/_longjmp problems with local nonvolatile variables.
1273 If a nonvolatile local variable is written before a _longjmp to
1274 the frame containing the variable, and is read after the _longjmp,
1275 the value read is indeterminate. Some local variables of type
1276 'struct handler' and 'struct catchtag' are used in this way, so
1277 mark each of their slots as volatile if the slot can be set before
1278 _longjmp and read afterwards.
1279 * lisp.h (struct handler): var and chosen_clause are now volatile.
1280 (struct catchtag): val, next, and pdlcount are now volatile.
1281
ae1d87e2
PE
1282 * bidi.c (bidi_push_it, bidi_pop_it):
1283 * fns.c (copy_hash_table):
1284 * image.c (define_image_type):
1285 * keyboard.c (kbd_buffer_store_event_hold):
1286 * process.c (Fprocess_send_eof):
1287 * xfaces.c (x_create_gc) [HAVE_NS]:
1288 * xgselect.c (xg_select):
1289 Prefer assignment to memcpy when either will do.
1290
5779a1dc
PE
1291 * alloc.c (discard_killed_buffers): Tune and simplify a bit.
1292 Use pointer-to-a-pointer to simplify and avoid a NILP check each
1293 time an item is removed. No need to mark this function 'inline';
1294 the compiler knows better than we do.
1295
c4c9756b
JD
12962012-09-11 Jan Djärv <jan.h.d@swipnet.se>
1297
1298 * nsterm.m (ns_judge_scroll_bars): Pass NO to updateFrameSize.
1299 (updateFrameSize:): Add delay parameter to updateFrameSize, send it
1300 to change_frame_size (Bug#12388).
1301 (windowDidResize:): Pass YES to updateFrameSize.
1302
1303 * nsterm.h: Add delay parameter to updateFrameSize.
1304
d73e321c
DA
13052012-09-11 Dmitry Antipov <dmantipov@yandex.ru>
1306
1307 Discard killed buffers from deleted window and frame objects.
1308 This reduces an amount of references to killed buffers and
1309 helps GC to reclaim them faster.
1310 * alloc.c (discard_killed_buffers): New function.
1311 (mark_object): Use it for deleted windows and frames.
1312 (mark_object): If symbol's value is set up for a killed buffer
1313 or deleted frame, restore it's global binding.
1314 * data.c (swap_in_global_binding): Add GC notice.
1315 (swap_in_symval_forwarding): Use convenient set_blv_where.
1316 * window.c (wset_next_buffers, wset_prev_buffers): Move ...
1317 * window.h: ... to here.
1318
e578f381
DA
13192012-09-11 Dmitry Antipov <dmantipov@yandex.ru>
1320
1321 Convenient macro to check whether the buffer is live.
1322 * buffer.h (BUFFER_LIVE_P): New macro.
1323 * alloc.c, buffer.c, editfns.c, insdel.c, lread.c, marker.c:
1324 * minibuf.c, print.c, process.c, window.c, xdisp.c: Use it.
1325
3057e615
YM
13262012-09-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1327
1328 * xdisp.c (right_overwritten, right_overwriting): Also handle gstring
1329 composition cases (Bug#12364).
1330
1331 * xterm.c (x_draw_glyph_string): Avoid overwriting inverted left
1332 overhang of succeeding glyphs overlapping box cursor.
1333
1334 * w32term.c (x_draw_glyph_string): Likewise.
1335
6fda35f2
PE
13362012-09-11 Paul Eggert <eggert@cs.ucla.edu>
1337
c990426a
PE
1338 Simplify, document, and port floating-point (Bug#12381).
1339 The porting part of this patch fixes bugs on non-IEEE platforms
1340 with frexp, ldexp, logb.
1341 * data.c, lisp.h (Qdomain_error, Qsingularity_error, Qunderflow_error):
1342 Now static.
1343 * floatfns.c: Simplify discussion of functions that Emacs doesn't
1344 support, by removing commented-out code and briefly listing the
1345 C89 functions excluded. The commented-out stuff was confusing
1346 maintenance, e.g., we thought we needed cbrt but it was commented out.
1347 (logb): Remove decl; no longer needed.
1348 (isfinite): New macro, if not already supplied.
1349 (isnan): Don't replace any existing macro.
1350 (Ffrexp, Fldexp): Define even if !HAVE_COPYSIGN, as frexp and ldexp
1351 are present on all C89 platforms.
1352 (Ffrexp): Do not special-case zero, as frexp does the right thing
1353 for that case.
1354 (Flogb): Do not use logb, as it doesn't have the desired meaning
1355 on hosts that use non-base-2 floating point. Instead, stick with
1356 frexp, which is C89 anyway. Do not pass an infinity or a NaN to
1357 frexp, to avoid getting an unspecified result.
1358
6fda35f2
PE
1359 * xdisp.c (Qinhibit_debug_on_message): Now static.
1360
16130a58
JD
13612012-09-10 Jan Djärv <jan.h.d@swipnet.se>
1362
1363 * nsterm.m (ns_update_begin): Set clip path to whole view by using
1364 NSBezierPath (Bug#12131).
1365
d105a573
CY
13662012-09-10 Chong Yidong <cyd@gnu.org>
1367
1368 * fns.c (Fdelq, Fdelete): Doc fix.
1369
ff55dfe8
PE
13702012-09-10 Paul Eggert <eggert@cs.ucla.edu>
1371
1372 * lisp.h (XSETINT, XSETCONS, XSETVECTOR, XSETSTRING, XSETSYMBOL)
1373 (XSETFLOAT, XSETMISC): Parenthesize macro bodies.
1374
e7032e7c
SM
13752012-09-09 Stefan Monnier <monnier@iro.umontreal.ca>
1376
1377 * lisp.h (make_lisp_ptr): New macro to replace XSET.
1378 (XSETCONS, XSETVECTOR, XSETSTRING, XSETSYMBOL, XSETFLOAT, XSETMISC):
1379 Use it.
1380
e9957956
EZ
13812012-09-09 Eli Zaretskii <eliz@gnu.org>
1382
aba05ce9
EZ
1383 * fringe.c (draw_fringe_bitmap_1): Don't reduce the width of the
1384 left fringe if the window has a left margin. This avoids leaving
1385 traces of the cursor because its leftmost pixel is not drawn over.
1386
e9957956
EZ
1387 * dispnew.c (update_window_line): When the left margin area of a
1388 screen line is updated, set the redraw_fringe_bitmaps_p flag of
1389 that screen line. (Bug#12277)
1390
f6196b87
PE
13912012-09-09 Paul Eggert <eggert@cs.ucla.edu>
1392
1393 Assume C89 or later for math functions (Bug#12381).
1394 This simplifies the code, and makes it a bit smaller and faster,
1395 and (most important) makes it easier to clean up signal handling
1396 since we can stop worring about floating-point exceptions in
1397 library code. That was a problem before C89, but the problem
1398 went away many years ago on all practical Emacs targets.
1399 * data.c, image.c, lread.c, print.c:
1400 Don't include <math.h>; no longer needed.
1401 * data.c, floatfns.c (IEEE_FLOATING_POINT): Don't worry that it
1402 might be autoconfigured, as that never happens.
1403 * data.c (fmod):
1404 * doprnt.c (DBL_MAX_10_EXP):
1405 * print.c (DBL_DIG):
1406 Remove. C89 or later always defines these.
1407 * floatfns.c (HAVE_MATHERR, FLOAT_CHECK_ERRNO, FLOAT_CHECK_DOMAIN)
1408 (in_float, float_error_arg, float_error_arg2, float_error_fn_name)
1409 (arith_error, domain_error, domain_error2):
1410 Remove all this pre-C89 cruft. Do not include <errno.h> as that's
1411 no longer needed -- we simply return what C returns. All uses removed.
1412 (IN_FLOAT, IN_FLOAT2): Remove. All uses replaced with
1413 the wrapped code.
1414 (FLOAT_TO_INT, FLOAT_TO_INT2, range_error, range_error2):
1415 Remove. All uses expanded, as these macros are no longer used
1416 more than once and are now more trouble than they're worth.
1417 (Ftan): Use tan, not sin / cos.
1418 (Flogb): Assume C89 frexp.
1419 (fmod_float): Assume C89 fmod.
1420 (matherr) [HAVE_MATHERR]: Remove; no longer needed.
1421 (init_floatfns): Remove. All uses removed.
1422
9d7f1863
JD
14232012-09-08 Jan Djärv <jan.h.d@swipnet.se>
1424
1425 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Take back
1426 compositeToPoint for OSX < 10.6 (Bug#12390).
1427
eabf0404
PE
14282012-09-08 Paul Eggert <eggert@cs.ucla.edu>
1429
1430 * floatfns.c (Ftan): Use tan (x), not (sin (x) / cos (x)).
1431 This produces more-accurate results.
1432
0b3b1d23
JD
14332012-09-08 Jan Djärv <jan.h.d@swipnet.se>
1434
1435 * nsterm.m (updateFrameSize): Call setFrame: on the view when size
1436 changes (Bug#12088).
1437
6dcef6ec
CY
14382012-09-08 Chong Yidong <cyd@gnu.org>
1439
1440 * syntax.c (Fstring_to_syntax): Doc fix.
1441
aa7d57c5
JD
14422012-09-08 Jan Djärv <jan.h.d@swipnet.se>
1443
1444 * nsterm.m (ns_clip_to_row): Remove code that deals with drawing fringe
1445 in the internal border.
1446 (x_set_window_size): Remove static variables and their usage.
1447 (ns_redraw_scroll_bars): Fix NSTRACE arg.
3a880af4
SM
1448 (ns_after_update_window_line, ns_draw_fringe_bitmap):
1449 Remove fringe/internal border adjustment (Bug#11052).
aa7d57c5
JD
1450 (ns_draw_fringe_bitmap): Make code more like other terms (xterm.c).
1451 (ns_draw_window_cursor): Remove fringe/internal border adjustment.
1452 (ns_fix_rect_ibw): Remove.
1453 (ns_get_glyph_string_clip_rect): Remove call to ns_fix_rect_ibw.
1454 (ns_dumpglyphs_box_or_relief): Ditto.
1455 (ns_maybe_dumpglyphs_background): Remove fringe/internal border
1456 adjustment.
1457 (ns_dumpglyphs_image): Ditto.
fc0c31f8 1458 (ns_dumpglyphs_stretch): Fix coding style. Remove fringe/internal
aa7d57c5
JD
1459 border adjustment.
1460 (ns_set_vertical_scroll_bar): Remove variables barOnVeryLeft/Right and
1461 their usage. Add fringe_extended_p and its use as in other terms.
1462 (ns_judge_scroll_bars): Code style fix. Call updateFrameSize if
1463 scroll bar was removed.
1464 (updateFrameSize): New function.
1465 (windowDidResize): Move code to updateFrameSize and call it.
1466
1467 * nsterm.h (EmacsView): Add updateFrameSize.
1468
1a5432bc
CY
14692012-09-07 Chong Yidong <cyd@gnu.org>
1470
b4f5313e
CY
1471 * textprop.c (Fget_text_property): Minor doc fix (Bug#12323).
1472
1a5432bc
CY
1473 * data.c (Flocal_variable_if_set_p): Doc fix (Bug#10713).
1474
1a4f1e9b
PE
14752012-09-07 Paul Eggert <eggert@cs.ucla.edu>
1476
1477 More signal-handler cleanup (Bug#12327).
eddb36a7
PE
1478 * emacs.c (main): Convert three 'signal' calls to 'sigaction' calls.
1479 Problem introduced when merging patches. Noted by Eli Zaretskii in
1480 <http://bugs.gnu.org/12327#67>.
1a4f1e9b
PE
1481 * floatfns.c: Comment fix.
1482 * lisp.h (force_auto_save_soon): Declare regardless of SIGDANGER.
1483 SIGDANGER might not be in scope so "#ifdef SIGDANGER" is not right,
1484 and anyway the declaration is harmless even if SIGDANGER is not defined.
1485 * syssignal.h (SIGIO): Also #undef if (! defined FIONREAD ||
1486 defined BROKEN_FIONREAD). systty.h formerly did this, but other
1487 source files not surprisingly expected syssignal.h to define, or
1488 not define, SIGIO, and it's cleaner to do it that way, for consistency.
1489 Include <sys/ioctl.h>, for FIONREAD.
1490 * systty.h (SIGIO): Do not #undef here; it's now syssignal.h's job.
1491 This eliminates a problem whereby other files mysteriously had
1492 to include "syssignal.h" before including "systty.h" if they
1493 wanted to use "#ifdef SIGIO".
1494
bc8000ff
EZ
14952012-09-07 Eli Zaretskii <eliz@gnu.org>
1496
3e6d6928
EZ
1497 * w32proc.c (sigaction): New function, emulates Posix 'sigaction'.
1498
1499 * w32.c (sigemptyset): Empty the set.
1500 (sigsetmask, sigmask, sigblock, sigunblock): Remove unused functions.
1501
bc8000ff
EZ
1502 * alloc.c [ENABLE_CHECKING]: Include signal.h, since we need SIGABRT.
1503
b4fa72f2
DA
15042012-09-07 Dmitry Antipov <dmantipov@yandex.ru>
1505
1506 * alloc.c (mark_buffer): Revert unsafe marking optimization.
1507 (mark_object): Likewise for frame objects.
1508
30730c93
PE
15092012-09-07 Paul Eggert <eggert@cs.ucla.edu>
1510
1511 * syssignal.h (handle_on_main_thread): Always declare,
1512 even if FORWARD_SIGNAL_TO_MAIN_THREAD is not defined.
1513 This ports to platforms without HAVE_PTHREAD.
1514
2fe28299
PE
15152012-09-06 Paul Eggert <eggert@cs.ucla.edu>
1516
1517 Signal-handler cleanup (Bug#12327).
1518 Emacs's signal handlers were written in the old 4.2BSD style with
1519 sigblock and sigmask and so forth, and this led to some
1520 inefficiencies and confusion. Rewrite these to use
1521 pthread_sigmask etc. without copying signal sets around. Also,
1522 get rid of the confusing macros 'SIGNAL_THREAD_CHECK' and
1523 'signal', and instead use functions that do not attempt to take
1524 over the system name space. This patch causes Emacs's text
1525 segment to shrink by 0.7% on my platform, Fedora 17 x86-64.
1526 * alloc.c, emacsgtkfixed.c, nsfns.m, widget.c, xmenu.c:
1527 Do not include <signal.h> or "syssignal.h", as these
1528 modules do not use signals.
1529 * atimer.c, callproc.c, data.c, dispnew.c, emacs.c, floatfns.c:
1530 * gtkutil.c, keyboard.c, process.c, sound.c, sysdep.c, term.c, xterm.c:
1531 Do not include <signal.h>, as "syssignal.h" does that for us now.
1532 * atimer.c (sigmask_atimers): New function.
1533 (block_atimers, unblock_atimers): New functions,
1534 replacing the old macros BLOCK_ATIMERS and UNBLOCK_ATIMERS.
1535 All uses replaced.
1536 * conf_post.h [SIGNAL_H_AHB]: Do not include <signal.h>;
1537 no longer needed here.
1538 * emacs.c (main): Inspect existing signal handler with sigaction,
fc0c31f8 1539 so that there's no need to block and unblock SIGHUP.
2fe28299
PE
1540 * sysdep.c (struct save_signal): New member 'action', replacing
1541 old member 'handler'.
1542 (save_signal_handlers, restore_signal_handlers):
1543 Use sigaction instead of 'signal' to save and restore.
1544 (get_set_sighandler, set_sighandler) [!WINDOWSNT]:
1545 New function. All users of 'signal' modified to use set_sighandler
1546 if they're writeonly, and to use sys_signal if they're read+write.
1547 (emacs_sigaction_init, forwarded_signal): New functions.
1548 (sys_signal): Remove. All uses replaced by calls to sigaction
1549 and emacs_sigaction_init, or by direct calls to 'signal'.
1550 (sys_sigmask) [!__GNUC__]: Remove; no longer needed.
1551 (sys_sigblock, sys_sigunblock, sys_sigsetmask): Remove;
1552 all uses replaced by pthread_sigmask etc. calls.
1553 * syssignal.h: Include <signal.h>.
1554 (emacs_sigaction_init, forwarded_signal): New decls.
1555 (SIGMASKTYPE): Remove. All uses replaced by its definiens, sigset_t.
1556 (SIGEMPTYMASK): Remove; all uses replaced by its definiens, empty_mask.
1557 (sigmask, sys_sigmask): Remove; no longer needed.
1558 (sigpause): Remove. All uses replaced by its definiens, sigsuspend.
1559 (sigblock, sigunblock, sigfree):
1560 (sigsetmask) [!defined sigsetmask]:
1561 Remove. All uses replaced by pthread_sigmask.
1562 (signal): Remove. Its remaining uses (with SIG_DFL and SIG_IGN)
1563 no longer need to be replaced, and its typical old uses
1564 are now done via emacs_sigaction_init and sigaction.
1565 (sys_sigblock, sys_sigunblock, sys_sigsetmask): Remove decls.
1566 (sys_sigdel): Remove; unused.
1567 (NSIG): Remove a FIXME; the code's fine. Remove an unnecessary ifdef.
1568
0216c128
EZ
15692012-09-06 Eli Zaretskii <eliz@gnu.org>
1570
1571 * process.c (CAN_HANDLE_MULTIPLE_CHILDREN): Fix a typo that broke
1572 SIGCHLD handling on systems that don't have WNOHANG. (Bug#12327)
1573
c752cfa9
DA
15742012-09-06 Dmitry Antipov <dmantipov@yandex.ru>
1575
1576 Explicitly mark buffer_defaults and buffer_local_symbols.
1577 * alloc.c (Fgarbage_collect): Mark buffer_defaults and
1578 mark_local_symbols here.
1579 (mark_object): If GC_CHECK_MARKED_OBJECTS, simplify checking
1580 since special buffers aren't marked here any more.
1581 (allocate_buffer): Chain new buffer with all_buffers here...
1582 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer): ...and
1583 not here.
1584 (Vbuffer_defaults, Vbuffer_local_symbols): Remove.
1585 (syms_of_buffer): Remove staticpro of the above.
1586 (init_buffer_once): Set names for buffer_defaults and
1587 buffer_local_symbols.
1588
a864ef14
PE
15892012-09-06 Paul Eggert <eggert@cs.ucla.edu>
1590
1591 Use bool for booleans in font-related modules.
1592 * font.c (font_intern_prop, font_style_to_value)
1593 (font_style_symbolic, font_parse_xlfd, font_parse_fcname)
1594 (generate_otf_features, font_check_otf_features, font_check_otf)
1595 (font_match_p, font_list_entities, font_at):
1596 * fontset.c (fontset_id_valid_p, reorder_font_vector
1597 (fontset_find_font, Fset_fontset_font)
1598 (face_suitable_for_char_p) [0]:
1599 * ftfont.c (fc_initialized, ftfont_get_open_type_spec)
1600 (ftfont_open, ftfont_text_extents, ftfont_check_otf):
1601 (m17n_flt_initialized, ftfont_shape_by_flt):
1602 * ftxfont.c (ftxfont_draw_bitmap, ftxfont_draw):
1603 * nsfont.m (nsfont_draw):
1604 * w32font.c (w32font_draw):
1605 * w32term.c (x_draw_glyphless_glyph_string_foreground):
1606 Use bool for booleans.
1607 * font.h: Adjust to above API changes.
1608 (struct font, struct font_driver, struct font_driver_list):
1609 Use bool for booleans.
1610 (struct font): Remove useless member encoding_type.
1611 All users removed.
1612 * fontset.c, xftfont.c: Omit unnecessary static decls.
1613
0699fc18
DA
16142012-09-06 Dmitry Antipov <dmantipov@yandex.ru>
1615
1616 * alloc.c (mark_object): Revert window marking code
1617 since it's unsafe for the Fset_window_configuration.
1618
20ef56db
PE
16192012-09-05 Paul Eggert <eggert@cs.ucla.edu>
1620
2fe28299 1621 Fix race conditions with signal handlers and errno (Bug#12327).
20ef56db
PE
1622 Be more systematic about preserving errno whenever a signal
1623 handler returns, even if it's not in the main thread. Do this by
1624 renaming signal handlers to distinguish between signal delivery
1625 and signal handling. All uses changed.
1626 * atimer.c (deliver_alarm_signal): Rename from alarm_signal_handler.
1627 * data.c (deliver_arith_signal): Rename from arith_error.
1628 * dispnew.c (deliver_window_change_signal): Rename from
1629 window_change_signal.
1630 * emacs.c (deliver_error_signal): Rename from fatal_error_signal.
1631 (deliver_danger_signal) [SIGDANGER]: Rename from memory_warning_signal.
1632 * keyboard.c (deliver_input_available_signal): Rename from
1633 input_available_signal.
1634 (deliver_user_signal): Rename from handle_user_signal.
1635 (deliver_interrupt_signal): Rename from interrupt_signal.
1636 * process.c (deliver_pipe_signal): Rename from send_process_trap.
1637 (deliver_child_signal): Rename from sigchld_handler.
1638 * atimer.c (handle_alarm_signal):
1639 * data.c (handle_arith_signal):
1640 * dispnew.c (handle_window_change_signal):
1641 * emacs.c (handle_fatal_signal, handle_danger_signal):
1642 * keyboard.c (handle_input_available_signal):
1643 * keyboard.c (handle_user_signal, handle_interrupt_signal):
1644 * process.c (handle_pipe_signal, handle_child_signal):
1645 New functions, with the actual signal-handling code taken from the
1646 original respective signal handlers, sans the sporadic attempts to
1647 preserve errno, since that's now done by handle_on_main_thread.
1648 * atimer.c (alarm_signal_handler): Remove unnecessary decl.
1649 * emacs.c, floatfns.c, lisp.h: Remove unused FLOAT_CATCH_SIGKILL cruft.
1650 * emacs.c (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
1651 Move to sysdep.c.
1652 (main) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
1653 Move initialization of main_thread to sysdep.c's init_signals.
1654 * process.c (waitpid) [!WNOHANG]: #define to wait; that's good enough for
1655 our usage, and simplifies the mainline code.
1656 (record_child_status_change): New static function, as a helper
1657 for handle_child_signal, and with most of the old child handler's
1658 contents.
1659 (CAN_HANDLE_MULTIPLE_CHILDREN): New constant.
1660 (handle_child_signal): Use the above.
1661 * sysdep.c (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
1662 Moved here from emacs.c.
1663 (init_signals) [FORWARD_SIGNAL_TO_MAIN_THREAD]: Initialize it;
1664 code moved here from emacs.c's main function.
1665 * sysdep.c, syssignal.h (handle_on_main_thread): New function,
3a880af4
SM
1666 replacing the old SIGNAL_THREAD_CHECK. All uses changed.
1667 This lets callers save and restore errno properly.
20ef56db 1668
e3ccf108
DA
16692012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1670
1671 Remove redundant or unused things here and there.
1672 * lisp.h (CYCLE_CHECK, CHAR_TABLE_TRANSLATE): Remove.
1673 * conf_post.h (RE_TRANSLATE): Use char_table_translate.
1674 * editfns.c (Fcompare_buffer_substrings): Likewise.
1675 * frame.h (struct terminal, struct font_driver_list):
1676 Remove redundant declarations.
1677 * window.h (Qleft, Qright): Likewise.
1678
697e1e39
DA
16792012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1680
1681 Do not mark objects from deleted buffers, windows and frames.
1682 * alloc.c (mark_buffer): Mark just the buffer if it is dead.
1683 (mark_object): Likewise for windows and frames.
1684
c1ca42ca
DA
16852012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1686
1687 * alloc.c (valid_lisp_object_p): Treat killed buffers,
1688 buffer_defaults and buffer_local_symbols as valid objects.
1689 Return special value to denote them.
1690
014d93be
PE
16912012-09-05 Paul Eggert <eggert@cs.ucla.edu>
1692
f75d7a91
PE
1693 * fileio.c, filelock.c, floatfns.c, fns.c: Use bool for boolean.
1694 * fileio.c (auto_saving, auto_save_error_occurred, make_temp_name)
1695 (Fexpand_file_name, barf_or_query_if_file_exists, Fcopy_file)
1696 (file_name_absolute_p, Fsubstitute_in_file_name):
1697 (check_executable, check_writable, Ffile_accessible_directory_p)
1698 (Fset_file_selinux_context, Fdefault_file_modes)
1699 (Finsert_file_contents, choose_write_coding_system)
1700 (Fwrite_region, build_annotations, a_write, e_write)
1701 (Fdo_auto_save):
1702 * filelock.c (boot_time_initialized, get_boot_time)
1703 (get_boot_time_1, lock_file_1, within_one_second):
1704 * floatfns.c (in_float):
1705 * fns.c (concat, internal_equal, Frequire, base64_encode_1)
1706 (base64_decode_1, cmpfn_eql, cmpfn_user_defined)
1707 (sweep_weak_table, sweep_weak_hash_tables, secure_hash):
1708 * lisp.h (struct Lisp_Hash_Table.cmpfn):
1709 * window.c (compare_window_configurations):
1710 Use bool for booleans.
1711 * fileio.c (auto_saving_dir_umask, auto_saving_mode_bits)
1712 (Fdefault_file_modes): Now mode_t, not int, for modes.
1713 (Fdo_auto_save): Set a boolean to 1 rather than using ++.
1714 (internal_delete_file): Now returns void, not a (boolean) int,
1715 since nobody was looking at the return value.
1716 * lisp.h, window.h: Adjust to above API changes.
1717
014d93be
PE
1718 * xdisp.c (set_message): Simplify and reindent last change.
1719
776f29e1
JB
17202012-09-05 Juanma Barranquero <lekktu@gmail.com>
1721
1722 * makefile.w32-in ($(BLD)/sysdep.$(O)): Update dependencies.
1723
7f7e0167
LI
17242012-09-04 Lars Ingebrigtsen <larsi@gnus.org>
1725
1726 * eval.c (call_debugger): Make the function non-static so that we
1727 can call it from set_message.
1728
1729 * xdisp.c (set_message): Implement the new variable `debug-on-message'.
1730 (syms_of_xdisp): Defvar it and `inhibit-debug-on-message'.
1731
cf29dd84
PE
17322012-09-04 Paul Eggert <eggert@cs.ucla.edu>
1733
1734 Give more-useful info on a fatal error (Bug#12328).
1735 * alloc.c [ENABLE_CHECKING]: Do not include <execinfo.h>.
1736 (die) [ENABLE_CHECKING]: Call fatal_error_backtrace instead
1737 of doing the work ourselves.
1738 * emacs.c (fatal_error_signal): Let fatal_error_backtrace
1739 do most of the work.
1740 (fatal_error_backtrace): New function, taken from the guts
1741 of the old fatal_error_signal, but with a new option to output
1742 a backtrace.
1743 (shut_down_emacs) [!DOS_NT]: Use strsignal to give more-useful
1744 info about the signal than just its number.
1745 * lisp.h (fatal_error_backtrace, emacs_backtrace): New decls.
1746 * sysdep.c: Include <execinfo.h>
1747 (emacs_backtrace): New function, taken partly from the previous
1748 code of the 'die' function.
1749 (emacs_abort): Call fatal_error_backtrace rather than abort.
1750
972debf2
SM
17512012-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
1752
1753 * lread.c (readevalloop): Call internal-macroexpand-for-load to perform
1754 eager (load-time) macro-expansion.
1755 * lisp.mk (lisp): Add macroexp.
1756
1088b922
PE
17572012-09-04 Paul Eggert <eggert@cs.ucla.edu>
1758
1759 Simplify redefinition of 'abort' (Bug#12316).
1760 Do not try to redefine the 'abort' function. Instead, redo
1761 the code so that it calls 'emacs_abort' rather than 'abort'.
1762 This removes the need for the NO_ABORT configure-time macro
1763 and makes it easier to change the abort code to do a backtrace.
1764 * .gdbinit: Just stop at emacs_abort, not at w32_abort or abort.
1765 * emacs.c (abort) [!DOS_NT && !NO_ABORT]:
1766 Remove; sysdep.c's emacs_abort now takes its place.
1767 * lisp.h (emacs_abort): New decl. All calls from Emacs code to
1768 'abort' changed to use 'emacs_abort'.
1769 * msdos.c (dos_abort) [defined abort]: Remove; not used.
1770 (abort) [!defined abort]: Rename to ...
1771 (emacs_abort): ... new name.
1772 * sysdep.c (emacs_abort) [!HAVE_NTGUI]: New function, taking
1773 the place of the old 'abort' in emacs.c.
1774 * w32.c, w32fns.c (abort): Do not #undef.
1775 * w32.c (emacs_abort): Rename from w32_abort.
1776
30934d33
EZ
17772012-09-04 Eli Zaretskii <eliz@gnu.org>
1778
1779 * w32uniscribe.c (uniscribe_shape): Reverse the sign of
1780 offsets[j].dv, since the y axis of the screen coordinates points
1781 down, while the y axis of the font definition coordinates points
1782 up. This fixes display of Arabic diacritics such as KASRA and
1783 KASRATAN. (Bug#11860)
1784
af26b72c
PE
17852012-09-04 Paul Eggert <eggert@cs.ucla.edu>
1786
1787 Be more systematic about _setjmp vs setjmp.
1788 * alloc.c (test_setjmp, mark_stack):
1789 * image.c (PNG_LONGJMP) [PNG_LIBPNG_VER < 10500]:
1790 (PNG_JMPBUF) [! (PNG_LIBPNG_VER < 10500)]:
1791 (png_load, my_error_exit, jpeg_load):
1792 * process.c (send_process_trap, send_process):
1793 Uniformly prefer _setjmp and _longjmp to setjmp and longjmp.
1794 The underscored versions are up to 30x faster on some hosts.
1795 Formerly, the code used setjmp+longjmp sometimes and
1796 _setjmp+_longjmp at other times, with no particular reason to
1797 prefer setjmp+longjmp.
1798
26d4541d
PE
17992012-09-03 Paul Eggert <eggert@cs.ucla.edu>
1800
d42f4f0f 1801 Fix minor problem found by static checking.
26d4541d 1802 * buffer.c (Fdelete_all_overlays): Return nil.
26d4541d 1803
c5e28e39
MR
18042012-09-03 Martin Rudalics <rudalics@gmx.at>
1805
1806 * buffer.c (Fdelete_all_overlays): New function.
1807
3eab3ca9
CY
18082012-09-03 Chong Yidong <cyd@gnu.org>
1809
1810 * gtkutil.c: Add extern decl for Qxft.
1811
c04889f8
PE
18122012-09-02 Paul Eggert <eggert@cs.ucla.edu>
1813
1882aa38
PE
1814 * emacs.c, eval.c: Use bool for boolean.
1815 * emacs.c (initialized, inhibit_window_system, running_asynch_code):
1816 (malloc_using_checking) [DOUG_LEA_MALLOC]:
1817 (display_arg) [HAVE_X_WINDOWS || HAVE_NS]:
1818 (noninteractive, no_site_lisp, fatal_error_in_progress, argmatch)
1819 (main, decode_env_path, Fdaemon_initialized):
1820 * eval.c (call_debugger, Finteractive_p, interactive_p):
1821 (unwind_to_catch, Fsignal, wants_debugger, skip_debugger)
1822 (maybe_call_debugger, Fbacktrace):
1823 * process.c (read_process_output, exec_sentinel):
1824 Use bool for booleans.
1825 * emacs.c (shut_down_emacs): Omit unused boolean argument NO_X.
1826 All callers changed.
1827 * eval.c (interactive_p): Omit always-true boolean argument
1828 EXCLUDE_SUBRS_P. All callers changed.
1829 * dispextern.h, lisp.h: Reflect above API changes.
1830 * firstfile.c (dummy): Use the address of 'main', whose signature
1831 won't change, instead of the address of 'initialize', whose
1832 signature just changed from int to bool.
1833 * lisp.h (fatal_error_in_progress): New decl of boolean, moved here ...
1834 * msdos.c (fatal_error_in_progress): ... from here.
1835 * xdisp.c (redisplaying_p): Now a boolean. Set it to 1 instead
1836 of incrementing it.
1837 (redisplay_internal, unwind_redisplay): Simply clear
1838 REDISPLAYING_P when unwinding, instead of saving its previous,
1839 always-false value and then restoring it.
1840
a411ac43
PE
1841 Clean up some extern decls.
1842 Mostly, this hoists extern decls out of .c files and into .h files.
1843 That way, we're more likely to catch errors if the interfaces change.
1844 * alloc.c [USE_GTK]: Include "gtkutil.h" so that we need not
1845 declare xg_mark_data.
1846 * dispextern.h (x_frame_parm_handlers):
1847 * font.h (Qxft):
1848 * lisp.h (Qlexical_binding, Qinternal_interpreter_environment)
1849 (Qextra_light, Qlight, Qsemi_light, Qsemi_bold, Qbold, Qextra_bold)
1850 (Qultra_bold, Qoblique, Qitalic):
1851 Move extern decl here from .c file.
1852 * alloc.c (xg_mark_data) [USE_GTK]:
1853 * doc.c (Qclosure):
1854 * eval.c (Qlexical_binding):
1855 * fns.c (time) [!HAVE_UNISTD_H]:
1856 * gtkutil.c (Qxft, Qnormal, Qextra_light, Qlight, Qsemi_light)
1857 (Qsemi_bold, Qbold, Qextra_bold, Qultra_bold, Qoblique, Qitalic):
1858 * image.c (Vlibrary_cache, QCloaded_from) [HAVE_NTGUI]:
1859 * lread.c (Qinternal_interpreter_environment):
1860 * minibuf.c (Qbuffer):
1861 * process.c (QCfamily, QCfilter):
1862 * widget.c (free_frame_faces):
1863 * xfaces.c (free_frame_menubar) [USE_X_TOOLKIT]:
1864 * xfont.c (x_clear_errors):
1865 * xterm.c (x_frame_parm_handlers):
1866 Remove now-redundant extern decls.
1867 * keyboard.c, keyboard.h (ignore_mouse_drag_p) [USE_GTK || HAVE_NS]:
1868 * xfaces.c (Qultra_light, Qreverse_oblique, Qreverse_italic):
1869 Now static.
1870 * xfaces.c: Remove unnecessary static decls.
1871 * xterm.c (updating_frame): Remove decl of nonexistent object.
1872
c04889f8
PE
1873 * Makefile.in (gl-stamp): Don't scan $(SOME_MACHINE_OBJECTS)
1874 when building globals.h, as the objects that are not built on
1875 this host are not needed to compile C files on this host.
1876
8b339673
JD
18772012-09-02 Jan Djärv <jan.h.d@swipnet.se>
1878
1879 * gtkutil.h: Remove prototype for x_wm_set_size_hint.
1880
1881 * frame.h: Add missing prototype for x_wm_set_size_hint.
1882
a08d4ba7
PE
18832012-09-02 Paul Eggert <eggert@cs.ucla.edu>
1884
1885 * doc.c, editfns.c, insdel.c, intervals.c: Use bool for boolean.
1886 * doc.c (read_bytecode_char, get_doc_string, reread_doc_file)
1887 (Fdocumentation, Fdocumentation_property, Fsnarf_documentation)
1888 (Fsubstitute_command_keys):
1889 * editfns.c (region_limit, find_field, Fconstrain_to_field)
1890 (save_excursion_save, save_excursion_restore)
1891 (disassemble_lisp_time, decode_time_components, emacs_nmemftime)
1892 (format_time_string, general_insert_function)
1893 (make_buffer_string, make_buffer_string_both)
1894 (Fsubst_char_in_region, Ftranslate_region_internal, Fformat):
1895 * insdel.c (check_markers, gap_left, adjust_markers_for_insert)
1896 (copy_text, insert_1, insert_1_both, insert_from_string)
1897 (insert_from_string_before_markers, insert_from_string_1)
1898 (insert_from_buffer, insert_from_buffer_1, replace_range)
1899 (replace_range_2, del_range_1, del_range_byte, del_range_both)
1900 (del_range_2, modify_region):
1901 * intervals.c (intervals_equal, balance_possible_root_interval)
1902 (adjust_intervals_for_insertion, merge_properties_sticky)
1903 (graft_intervals_into_buffer, lookup_char_property)
1904 (adjust_for_invis_intang, set_point_both)
1905 (get_property_and_range, compare_string_intervals)
1906 (set_intervals_multibyte_1, set_intervals_multibyte):
1907 * keyboard.c (decode_timer):
1908 Use bool for boolean.
1909 * intervals.h, lisp.h, systime.h: Reflect above API changes.
1910 * editfns.c (struct info): Use 1-bit unsigned bitfields for booleans.
1911
48c948de
CY
19122012-09-02 Chong Yidong <cyd@gnu.org>
1913
1914 * keymap.c (push_key_description): Print M-TAB as C-M-i
1915 (Bug#11758).
1916
6c49a40b
JB
19172012-09-02 Juanma Barranquero <lekktu@gmail.com>
1918
1919 * makefile.w32-in (CCL_H, W32FONT_H): New macros.
1920 (ATIMER_H, FONT_H, $(BLD)/alloc.$(O), $(BLD)/callproc.$(O))
1921 ($(BLD)/editfns.$(O), $(BLD)/ccl.$(O), $(BLD)/chartab.$(O))
1922 ($(BLD)/coding.$(O), $(BLD)/sysdep.$(O), $(BLD)/fontset.$(O))
1923 ($(BLD)/sysdep.$(O), $(BLD)/w32fns.$(O), $(BLD)/keyboard.$(O))
1924 ($(BLD)/w32term.$(O), $(BLD)/w32menu.$(O), $(BLD)/process.$(O))
1925 ($(BLD)/w32font.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
1926
4dfbd238
EZ
19272012-09-01 Eli Zaretskii <eliz@gnu.org>
1928
7e510e28
EZ
1929 * w32uniscribe.c (uniscribe_shape): Handle correctly the case of
1930 more than one grapheme cluster passed to the shaper: compute the
1931 offset adjustment values separately for each cluster. (Bug#11860)
1932
4dfbd238
EZ
1933 * image.c: Restore mistakenly removed inclusion of w32.h. Without
1934 it, GCC doesn't see prototypes of w32_delayed_load, and complains
1935 about implicit conversions from integer to pointer.
1936
86571ae0
DC
19372012-09-01 Daniel Colascione <dancol@dancol.org>
1938
1939 * w32fns.c (x_display_info_for_name): Prevent crash if w32 window
1940 system used too early.
1941
0e23ef9d
PE
19422012-09-01 Paul Eggert <eggert@cs.ucla.edu>
1943
1944 Better seed support for (random).
1945 * emacs.c (main): Call init_random.
1946 * fns.c (Frandom): Set the seed from a string argument, if given.
1947 Remove long-obsolete Gentzel cruft.
1948 * lisp.h, sysdep.c (seed_random): Now takes address and size, not long.
1949 (init_random): New function.
1950
17a2cbbd
DC
19512012-09-01 Daniel Colascione <dancol@dancol.org>
1952
1953 * xterm.h: Add header guards. Declare x_menubar_window_to_frame.
1954 Remove x_set_frame_alpha, x_bitmap_icon, x_make_frame_visible,
1955 x_make_frame_invisible, x_iconify_frame, x_free_frame_resources,
1956 x_wm_set_size_hint, x_query_colors, x_real_positions,
1957 x_set_menu_bar_lines, x_char_width, x_char_height, x_sync,
1958 x_set_tool_bar_lines, x_activate_menubar, and free_frame_menubar,
1959 all of which have been moved to common code.
1960
1961 * xfaces.c: Include TERM_HEADER instead of listing all possible
1962 window-system headers.
1963
1964 * w32xfns.c (x_sync): Correct definition of x_sync (a no-op here)
1965 to match header.
1966
1967 * w32term.h (FRAME_X_WINDOW): Use FRAME_W32_WINDOW instead of
1968 directly accessing frame internals.
1969
f18cbb28 1970 * w32font.h: Include font.h. Define syms_of_w32font and
17a2cbbd
DC
1971 globals_of_w32font.
1972
1973 * process.c: Include TERM_HEADER instead of listing all possible
1974 window-system headers.
1975
3a880af4
SM
1976 * nsterm.h: Remove declarations now in frame.h.
1977 Define FRAME_X_SCREEN, FRAME_X_VISUAL.
17a2cbbd
DC
1978
1979 * menu.c: Include TERM_HEADER instead of listing all possible
1980 window-system headers.
1981
1982 * keyboard.h: Declare ignore_mouse_drag_p whenever we have a
1983 window system.
1984
1985 * keyboard.c: Include TERM_HEADER instead of listing all possible
1986 window-system headers.
1987
1988 * image.c: Include TERM_HEADER instead of listing all possible
1989 window-system headers. Declare Vlibrary_cache when compiling for
1990 Windows.
1991
1992 * gtkutil.h (xg_list_node_): Include xterm.h to pick up needed
1993 window system declarations.
1994
1995 * frame.h: Move common functions here: set_frame_menubar,
1996 x_set_window_size, x_sync, x_get_focus_frame,
1997 x_set_mouse_position, x_set_mouse_pixel_position,
1998 x_make_frame_visible, x_make_frame_invisible, x_iconify_frame,
1999 x_char_width, x_char_height, x_pixel_width, x_pixel_height,
2000 x_set_frame_alpha, x_set_menu_bar_lines, x_set_tool_bar_lines,
2001 x_activate_menubar, x_real_positions, x_bitmap_icon,
2002 x_set_menu_bar_lines, free_frame_menubar, x_free_frame_resources,
2003 and x_query_colors.
2004
2005 * frame.c: Include TERM_HEADER instead of listing all possible
2006 window-system headers.
2007
2008 * font.c: Include TERM_HEADER instead of listing all possible
2009 window-system headers.
2010
2011 * emacs.c: Include TERM_HEADER.
2012
f18cbb28
EZ
2013 * dispnew.c: Include TERM_HEADER instead of listing all possible
2014 window-system headers.
17a2cbbd 2015
f18cbb28 2016 * ccl.h: Include character.h.
17a2cbbd
DC
2017
2018 * Makefile.in: Define WINDOW_SYSTEM_OBJ to hold objects needed for
2019 the current window system; include in list of objects to link into
2020 Emacs.
2021
c650a5de
DA
20222012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
2023
2024 Remove mark_ttys function and fix tty_display_info initialization.
2025 * lisp.h (mark_ttys): Remove prototype.
2026 * alloc.c (Fgarbage_collect): Remove redundant (and the only) call
2027 to mark_ttys because all possible values of 'top_frame' slot are
2028 the frames which are reachable from Vframe_list.
2029 * term.c (mark_ttys): Remove.
2030 (init_tty): Safely initialize 'top_frame' slot with Qnil.
2031
4e0f6479
DA
20322012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
2033
2034 Change struct frame bitfields from unsigned char to unsigned.
2035 * frame.h (struct frame): Change type of 'display_preempted',
2036 'visible', 'iconified', 'has_minibuffer', 'wants_modeline',
2037 'auto_raise', 'auto_lower', 'no_split', 'explicit_name',
2038 'window_sizes_changed', 'mouse_moved' and 'pointer_invisible'
2039 bitfields from unsigned char to unsigned.
2040
8b96a52c
DA
20412012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
2042
2043 Remove unused member of struct x_output and struct w32_output.
2044 * xterm.h (struct x_output): Remove unused field 'needs_exposure'.
2045 * w32term.h (struct w32_output): Likewise.
2046
b4444c8a
JD
20472012-08-30 Jan Djärv <jan.h.d@swipnet.se>
2048
2049 * gtkutil.c (x_wm_set_size_hint): Use 1 col for base_width so it
2050 does not become zero (Bug#12234).
2051
b98521db
PE
20522012-08-30 Paul Eggert <eggert@cs.ucla.edu>
2053
2054 * dispnew.c (update_frame_1): Pacify gcc -Wstrict-overflow
2055 for GCC 4.7.1 x86-64.
2056
31d02438
GM
20572012-08-30 Glenn Morris <rgm@gnu.org>
2058
2059 * lread.c (init_lread): For out-of-tree builds, only add the
2060 source directory's site-lisp dir to the load-path if it exists,
2061 consistent with in-tree builds. (Bug#12302)
2062
7f8941d8
JD
20632012-08-28 Jan Djärv <jan.h.d@swipnet.se>
2064
2065 * nsmenu.m (initWithContentRect:styleMask:backing:defer:): Initialize
fc0c31f8 2066 button_values to NULL. Call setStykeMask so dialogs get a close button.
7f8941d8
JD
2067 (windowShouldClose:): Set window_closed.
2068 (dealloc): New member, free button_values.
fc0c31f8
JB
2069 (process_dialog:): Make member function. Remove window argument,
2070 replace window with self. Count buttons and allocate and store values
7f8941d8
JD
2071 in button_values.
2072 (addButton:value:row:): value is int with the name tag. Call setTag
fc0c31f8 2073 with tag. Remove return self, declare return value as void.
7f8941d8
JD
2074 (addString:row:): Remove return self, declare return value as void.
2075 (addSplit): Remove return self, declare return value as void.
2076 (clicked:): Remove return self, declare return value as void.
fc0c31f8 2077 Set dialog_return to button_values[seltag]. Code formatting change.
7f8941d8
JD
2078 (initFromContents:isQuestion:): Adjust call to process_dialog.
2079 Code formatting change.
2080 (timeout_handler:): Set timer_fired to YES.
2081 (runDialogAt:): Set timer_fired to NO.
2082 Handle click on close button as quit.
2083
2084 * nsterm.h (EmacsDialogPanel): Make timer_fired BOOL.
2085 Add window_closed and button_values. Add void as return value for
2086 add(Button|String|Split). addButton takes int instead of Lisp_Object.
2087 Add process_dialog as new member.
2088
eada0861 20892012-08-28 Eli Zaretskii <eliz@gnu.org>
19c17fc1 2090
eada0861
GM
2091 * ralloc.c (free_bloc): Don't dereference a 'heap' structure if it
2092 is not one of the heaps we manage. (Bug#12242)
2093
20942012-08-28 Glenn Morris <rgm@gnu.org>
2095
2096 * eval.c (Fcalled_interactively_p): Doc fix. (Bug#11747)
2097
457294dd
MR
20982012-08-28 Martin Rudalics <rudalics@gmx.at>
2099
2100 * window.c (Fset_window_configuration): Remove handling of
37b9743e
MR
2101 auto-buffer-name window parameter. Install revision of reverted
2102 fix.
457294dd 2103
4f2daf31
DA
21042012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
2105
2106 Do not allow to set major mode for a dead buffer.
2107 * buffer.c (Fset_buffer_major_mode): Signal an error
2108 if the buffer is dead.
2109 (Fother_buffer, other_buffer_safely): Remove redundant
2110 nested declaration.
2111
66322887
DA
21122012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
2113
2114 Always use set_buffer_if_live to restore original buffer at unwind.
2115 * buffer.h (record_unwind_current_buffer): New function.
2116 * bytecode.c, dispnew.c, editfns.c, fileio.c, fns.c, insdel.c:
2117 * keyboard.c, keymap.c, minibuf.c, print.c, process.c, textprop.c:
2118 * undo.c, window.c: Adjust users.
2119 * buffer.c (set_buffer_if_live): Fix comment.
2120
a3d794a1
DA
21212012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
2122
2123 Fix usage of set_buffer_internal.
2124 * buffer.h (set_buffer_internal): Make it BUFFER_INLINE.
2125 * buffer.c (set_buffer_if_live): Use set_buffer_internal.
2126 * coding.c (decode_coding): Omit redundant test.
2127 * fileio.c (decide_coding_unwind): Likewise.
2128 * fns.c (secure_hash): Likewise.
2129 * insdel.c (modify_region): Likewise.
2130 * keyboard.c (command_loop_1): Likewise.
2131 * print.c (PRINTFINISH): Likewise.
2132 * xdisp.c (run_window_scroll_functions): Use set_buffer_internal.
2133
59ea14cd
PE
21342012-08-27 Paul Eggert <eggert@cs.ucla.edu>
2135
2136 * dispnew.c: Use bool for boolean.
2137 (frame_garbaged, display_completed, delayed_size_change)
2138 (fonts_changed_p, add_window_display_history)
2139 (add_frame_display_history, verify_row_hash)
2140 (adjust_glyph_matrix, clear_window_matrices, glyph_row_slice_p)
2141 (row_equal_p, realloc_glyph_pool)
2142 (allocate_matrices_for_frame_redisplay)
2143 (showing_window_margins_p)
2144 (adjust_frame_glyphs_for_frame_redisplay)
2145 (build_frame_matrix_from_leaf_window, make_current)
2146 (mirrored_line_dance, mirror_line_dance, update_frame)
2147 (update_window_tree, update_single_window)
2148 (check_current_matrix_flags, update_window, update_text_area)
2149 (update_window_line, set_window_update_flags, scrolling_window)
2150 (update_frame_1, scrolling, buffer_posn_from_coords)
2151 (do_pending_window_change, change_frame_size)
2152 (change_frame_size_1, sit_for):
2153 Use bool for boolean.
2154 (clear_glyph_matrix_rows): Rename from enable_glyph_matrix_rows,
2155 and remove last int (actually boolean) argument, which was always 0.
2156 All callers changed.
2157 * dispextern.h, frame.h, lisp.h: Reflect above API changes.
2158 * dispextern.h (struct composition_it): Use bool for boolean.
2159 (struct glyph_matrix): Don't assume buffer sizes can fit in 'int'.
2160 (struct bidi_it): Use unsigned:1, not int, for boolean prev_was_pdf.
2161 * dired.c (file_name_completion):
2162 Use bool for boolean. (This was missed in an earlier change.)
2163
95072a94
MR
21642012-08-27 Martin Rudalics <rudalics@gmx.at>
2165
2166 * window.c (Fset_window_configuration): Revert first part of
2167 last change.
2168
0f19feff
JD
21692012-08-27 Jan Djärv <jan.h.d@swipnet.se>
2170
2171 * nsterm.h (NSPanel): New class variable dialog_return.
2172
3a880af4
SM
2173 * nsmenu.m (initWithContentRect:styleMask:backing:defer:):
2174 Initialize dialog_return.
0f19feff
JD
2175 (windowShouldClose:): Use stop instead of stopModalWithCode.
2176 (clicked:): Ditto, and also set dialog_return (Bug#12258).
2177 (timeout_handler:): Use stop instead of abortModal. Send a dummy
2178 event.
2179 (runDialogAt:): Make ret Lisp_Object. Set it from dialog_return when
2180 modal loop returns.
2181
f10fe38f
PE
21822012-08-27 Paul Eggert <eggert@cs.ucla.edu>
2183
de1339b0
PE
2184 * composite.c, data.c, dbusbind.c, dired.c: Use bool for booleans.
2185 * composite.c (find_composition, composition_gstring_p)
2186 (composition_reseat_it, find_automatic_composition):
2187 * data.c (let_shadows_buffer_binding_p)
2188 (let_shadows_global_binding_p, set_internal, make_blv)
2189 (Fmake_variable_buffer_local, Fmake_local_variable)
2190 (Fmake_variable_frame_local, arithcompare, cons_to_unsigned)
2191 (cons_to_signed, arith_driver):
2192 * dbusbind.c (xd_in_read_queued_messages):
2193 * dired.c (directory_files_internal, file_name_completion):
2194 Use bool for booleans.
2195 * dired.c (file_name_completion):
2196 * process.h (fd_callback):
2197 Omit int (actually boolean) argument. It wasn't being used.
2198 All uses changed.
2199 * composite.h, lisp.h: Reflect above API changes.
2200
f10fe38f
PE
2201 * cmds.c, coding.c: Use bool for booleans.
2202 * cmds.c (move_point, Fself_insert_command):
2203 * coding.h (struct composition status, struct coding_system):
2204 * coding.c (detect_coding_utf_8, encode_coding_utf_8)
2205 (detect_coding_utf_16, encode_coding_utf_16, detect_coding_emacs_mule)
2206 (emacs_mule_char, decode_coding_emacs_mule)
2207 (encode_coding_emacs_mule, detect_coding_iso_2022)
2208 (decode_coding_iso_2022, encode_invocation_designation)
2209 (encode_designation_at_bol, encode_coding_iso_2022)
2210 (detect_coding_sjis, detect_coding_big5, decode_coding_sjis)
2211 (decode_coding_big5, encode_coding_sjis, encode_coding_big5)
2212 (detect_coding_ccl, encode_coding_ccl, decode_coding_raw_text)
2213 (encode_coding_raw_text, detect_coding_charset)
2214 (decode_coding_charset, encode_coding_charset, detect_eol)
2215 (detect_coding, get_translation_table, produce_chars)
2216 (consume_chars, reused_workbuf_in_use)
2217 (make_conversion_work_buffer, code_conversion_save)
2218 (decode_coding_object, encode_coding_object)
2219 (detect_coding_system, char_encodable_p)
2220 (Funencodable_char_position, code_convert_region)
2221 (code_convert_string, code_convert_string_norecord)
2222 (Fset_coding_system_priority):
2223 * fileio.c (Finsert_file_contents):
2224 Use bool for booleans.
2225 * coding.h, lisp.h: Reflect above API changes.
2226 * coding.c: Remove unnecessary static function decls.
2227 (detect_coding): Use unsigned, not signed, to copy an unsigned field.
2228 (decode_coding, encode_coding, decode_coding_gap): Return 'void',
2229 not a boolean 'int', since callers never look at the return value.
2230 (ALLOC_CONVERSION_WORK_AREA): Assume caller returns 'void', not 'int'.
2231 * coding.h (decoding_buffer_size, encoding_buffer_size)
2232 (emacs_mule_string_char): Remove unused extern decls.
2233 (struct iso_2022_spec, struct coding_system):
2234 Use 'unsigned int : 1' for boolean fields, since there's more than one.
2235 (struct emacs_mule_spec): Remove unused field 'full_support'.
2236 All initializations removed.
2237 * cmds.c (internal_self_insert): Don't assume EMACS_INT fits in 'int'.
2238
5474c384
DA
22392012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
2240
f10fe38f 2241 Fix spare memory change (Bug#12286).
5474c384
DA
2242 * alloc.c (mark_maybe_pointer): Handle MEM_TYPE_SPARE.
2243 (valid_lisp_object_p): Likewise.
2244
c4b6914d
MR
22452012-08-27 Martin Rudalics <rudalics@gmx.at>
2246
2247 * window.c (Fset_window_configuration): Record any window's old
2248 buffer if it's replaced (see Bug#8789). If the new current
2249 buffer doesn't appear in the selected window, go to its old
2250 point (Bug#12208).
2251
35aaa1ea
DA
22522012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
2253
2254 Special MEM_TYPE_SPARE to denote reserved memory.
2255 * alloc.c (enum mem_type): New memory type.
2256 (refill_memory_reserve): Use new type for spare memory.
2257 This prevents live_cons_p and live_string_p from incorrect
2258 detection of uninitialized objects from spare memory as live.
2259
6af64513
PE
22602012-08-26 Paul Eggert <eggert@cs.ucla.edu>
2261
8b2e00a3
PE
2262 Spelling fixes.
2263 * Makefile.in (.PHONY): versioclean -> versionclean.
2264
b52d6985
PE
2265 Remove unused external symbols.
2266 * data.c (Qcons, Qfloat, Qmisc, Qstring, Qvector):
2267 * window.c (Qwindow_valid_p, decode_valid_window):
2268 Now static, not extern.
2269 * data.c (Qinterval): Remove; unused.
2270 (syms_of_data): Do not define 'interval'.
2271 * lisp.h (Qinteger, Qstring, Qmisc, Qvector, Qfloat, Qcons):
2272 * window.h (decode_valid_window):
2273 Remove decls.
2274
d5172d4f
PE
2275 * character.c, charset.c, chartab.c: Use bool for booleans.
2276 * character.c (lisp_string_width, string_count_byte8)
2277 (string_escape_byte8):
2278 * charset.c (charset_map_loaded, load_charset_map, read_hex):
2279 (load_charset_map_from_file, map_charset_chars)
2280 (Fdefine_charset_internal, define_charset_internal)
2281 (Fdeclare_equiv_charset, find_charsets_in_text)
2282 (Ffind_charset_region, char_charset, Fiso_charset):
2283 * chartab.c (sub_char_table_ref, sub_char_table_ref_and_range)
2284 (sub_char_table_set, sub_char_table_set_range)
2285 (char_table_set_range, optimize_sub_char_table)
2286 (map_sub_char_table):
2287 Use bool for boolean.
2288 * character.c (str_to_unibyte): Omit last boolean argument; it was
2289 always 0. All callers changed.
2290 * character.h, charset.h: Adjust to match previous changes.
2291 * character.h (char_printable_p): Remove decl of nonexistent function.
2292 * charset.h (struct charset): Members code_linear_p, iso_chars_96,
2293 ascii_compatible_p, supplementary_p, compact_codes_p, unified_p
2294 are all boolean, so make them single-bit bitfields.
2295
6af64513
PE
2296 * lisp.h (ASET): Remove attempt to detect side effects.
2297 It was meant to be temporary and it often doesn't work,
2298 because when IDX has side effects the behavior of IDX==IDX
2299 is undefined. See Stefan Monnier in
2300 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00762.html>.
2301
e1f29348
BR
23022012-08-26 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
2303
2304 * lisp.h (functionp): New function (extracted from Ffunctionp).
2305 (FUNCTIONP): Use it.
2306 * eval.c (Ffunctionp): Use it.
2307
17c05d74
PE
23082012-08-25 Paul Eggert <eggert@cs.ucla.edu>
2309
0f46bc75
PE
2310 * xgselect.c (xg_select): Use auto storage for the GPollFD buffer
2311 as that's faster and simpler than static storage. Don't bother
2312 with the g_main_context_query overhead if g_main_context_pending
2313 says no events are pending.
2314 (gfds, gfds_size): Remove these static vars.
2315 (xgselect_initialize): Remove; no longer needed.
2316 All uses and decls removed.
2317
ee4c0f69
PE
2318 * emacs.c (fatal_error_signal_hook): Remove.
2319 All uses removed. This leftover from old code was always 0.
2320
17c05d74
PE
2321 * casefiddle.c, casetab.c, category.c: Use bool for boolean.
2322 * casefiddle.c (casify_object, casify_region):
2323 * casetab.c (set_case_table):
2324 * category.c, category.h (word_boundary_p):
2325 * category.h (CHAR_HAS_CATEGORY):
2326 Use bool for booleans, instead of int.
2327
391ceac5
EZ
23282012-08-25 Eli Zaretskii <eliz@gnu.org>
2329
2330 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on $(GNU_LIB)/execinfo.h.
2331
2f221583
PE
23322012-08-25 Paul Eggert <eggert@cs.ucla.edu>
2333
f4a681b0
PE
2334 On assertion failure, print backtrace if available.
2335 * alloc.c [ENABLE_CHECKING]: Include <execinfo.h>.
2336 (die) [ENABLE_CHECKING]: Print a backtrace if available.
2337 * Makefile.in (LIB_EXECINFO): New macro.
2338 (LIBES): Use it.
2339
2f221583
PE
2340 * bytecode.c, callint.c, callproc.c: Use bool for boolean.
2341 * bytecode.c (exec_byte_code):
2342 * callint.c (check_mark, Fcall_interactively):
2343 * callproc.c (Fcall_process, add_env, child_setup, getenv_internal_1)
2344 (getenv_internal, sync_process_alive, call_process_exited):
2345 * lisp.h (USE_SAFE_ALLOCA):
2346 Use bool for booleans, instead of int.
2347 * lisp.h, process.h: Adjust prototypes to match above changes.
2348 * callint.c (Fcall_interactively): Don't assume the mark's
2349 offset fits in 'int'.
2350
37ef52bb
PE
23512012-08-24 Paul Eggert <eggert@cs.ucla.edu>
2352
2353 * buffer.c, buffer.h: Use bool for boolean.
2354 * buffer.c (reset_buffer_local_variables)
2355 (buffer_lisp_local_variables, Fset_buffer_modified_p)
2356 (Frestore_buffer_modified_p, Fset_buffer_multibyte):
2357 (overlays_at, overlays_in, mouse_face_overlay_overlaps)
2358 (overlay_touches_p, overlay_strings, Foverlay_put)
2359 (report_overlay_modification, call_overlay_mod_hooks):
2360 (mmap_enlarge, mmap_set_vars):
2361 * buffer.h (buffer_has_overlays, uppercasep, lowercasep):
2362 Use bool for booleans, instead of int.
2363 * buffer.c (compact_buffer, mmap_free_1): Return void, not int,
2364 since the 1-or-0 return value is always ignored anyway.
2365 (mmap_initialized_p):
2366 * buffer.h (struct buffer_text.inhibit_shrinking): Now bool, not int.
2367 * buffer.h, lisp.h: Adjust prototypes to match above changes.
2368
2cc21167
PE
23692012-08-23 Paul Eggert <eggert@cs.ucla.edu>
2370
2371 * bidi.c: Use bool for boolean.
2372 This is a bit more readable, and makes the text segment of bidi.o
2373 0.4% smaller on my platform (GCC 4.7.1 x86-64, Fedora 15).
2374 Presumably it's faster too.
2375 (bidi_initialized, bidi_ignore_explicit_marks_for_paragraph_level):
2376 Now bool.
2377 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2378 (bidi_unshelve_cache, bidi_init_it, bidi_count_bytes)
2379 (bidi_char_at_pos, bidi_fetch_char, bidi_paragraph_init)
2380 (bidi_explicit_dir_char, bidi_level_of_next_char)
2381 (bidi_find_other_level_edge, bidi_move_to_visually_next):
2382 Use bool for booleans, instead of int.
2383 * dispextern.h (bidi_init_it, bidi_paragraph_init)
2384 (bidi_unshelve_cache): Adjust decls to match code.
2385
7db4ddf4
MR
23862012-08-23 Martin Rudalics <rudalics@gmx.at>
2387
2388 * keyboard.c (Fposn_at_x_y): Do not allow internal window as
2389 argument.
2390
b1bb8011
PE
23912012-08-23 Paul Eggert <eggert@cs.ucla.edu>
2392
2393 * atimer.c, atimer.h (turn_on_atimers): Use bool for boolean.
2394 * atimer.h: Include <stdbool.h>.
2395
ff687885
DN
23962012-08-22 Dan Nicolaescu <dann@gnu.org>
2397
2398 * frame.h (FRAME_W32_P, FRAME_MSDOS_P, FRAME_NS_P): Change to
2399 compile time tests instead of run time tests on systems that do
2400 not use them.
2401 (FRAME_MAC_P): Remove leftover from deleted code.
2402 * frame.c (syms_of_frame): Remove leftover from deleted code.
2403
4ce7a138
JD
24042012-08-22 Jan Djärv <jan.h.d@swipnet.se>
2405
2406 * nsterm.m (insertText:): Don't clear modifiers if code is space.
2407
d733ec6d
PE
24082012-08-22 Paul Eggert <eggert@cs.ucla.edu>
2409
2410 * fontset.c (FONTSET_ADD): Return void, not Lisp_Object.
2411 Otherwise, the compiler complains about (A?B:C) where B is void
fc0c31f8 2412 and C is Lisp_Object. This fixes an incompatibility with Sun C 5.12.
d733ec6d
PE
2413 (fontset_add): Return void, for FONTSET_ADD.
2414
d0d2d26f
PE
24152012-08-21 Paul Eggert <eggert@cs.ucla.edu>
2416
fce31d69
PE
2417 * alloc.c: Use bool for booleans.
2418 (gc_in_progress, abort_on_gc)
2419 (setjmp_tested_p) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
2420 (dont_register_blocks) [GC_MALLOC_CHECK]:
2421 (suppress_checking) [ENABLE_CHECKING]: Now bool, not int.
2422 (check_string_bytes, make_specified_string, memory_full)
2423 (live_string_p, live_cons_p, live_symbol_p, live_float_p)
2424 (live_misc_p, live_vector_p, live_buffer_p, mark_maybe_object)
2425 (mark_stack, valid_pointer_p, make_pure_string)
2426 (Fgarbage_collect, survives_gc_p, gc_sweep):
2427 Use bool for booleans, instead of int.
2428 (test_setjmp) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
2429 Remove unused local.
2430 * alloc.c (PURE_POINTER_P):
2431 * lisp.h (STRING_MULTIBYTE): Document that it returns a boolean.
2432 * editfns.c (Fformat):
2433 * fileio.c (Fexpand_file_name, Fsubstitute_in_file_name)
2434 (Fdo_auto_save):
2435 * fns.c (sweep_weak_table):
2436 * lisp.h (suppress_checking, push_message, survives_gc_p)
2437 (make_pure_string, gc_in_progress, abort_on_gc):
2438 * lread.c (readchar, read1):
2439 * print.c (Fprin1_to_string):
2440 * xdisp.c (push_message):
2441 Use bool for booleans affected directly or indirectly by
2442 alloc.c's changes.
2443
d0d2d26f
PE
2444 Make recently-introduced setters macros.
2445 * fontset.c (set_fontset_id, set_fontset_name, set_fontset_ascii)
2446 (set_fontset_base, set_fontset_frame, set_fontset_nofont_face)
2447 (set_fontset_default, set_fontset_fallback): Rename from their
2448 upper-case counterparts, and make them functions rather than macros.
2449 This is more consistent with the other recently-introduced setters.
2450 These don't need to be inline, since they're local.
2451
d18e2bb6
JD
24522012-08-21 Jan Djärv <jan.h.d@swipnet.se>
2453
2454 * nsterm.m (fd_handler:): Alloc and release a NSAutoreleasePool in
2455 the loop (Bug#12247).
2456
1b9d9d16
PE
24572012-08-21 Paul Eggert <eggert@cs.ucla.edu>
2458
2459 * lisp.h (vcopy): Use memcpy rather than our own loop.
2460 This fixes a performance regression introduced by the recent
2461 addition of vcopy. This means 'vcopy' will need to be modified
2462 for a copying collector, but that's OK. Also, tighten the
2463 checking in the assertion.
2464
b2f09701
EZ
24652012-08-21 Eli Zaretskii <eliz@gnu.org>
2466
2467 * w32uniscribe.c (uniscribe_shape): Fix producing gstring
2468 components for RTL text (Bug#11860). Adjust X-OFFSET of each
2469 non-base glyph for the width of the base character, according to
e1f29348
BR
2470 what x_draw_composite_glyph_string_foreground expects.
2471 Generate WADJUST value according to composition_gstring_width's
b2f09701
EZ
2472 expectations, to produce correct width of the composed character.
2473 Reverse the sign of the DU offset produced by ScriptPlace.
2474
9b994fed
PE
24752012-08-21 Paul Eggert <eggert@cs.ucla.edu>
2476
2477 * dbusbind.c (xd_remove_watch): Do not assume C99 comments.
2478
086ca913
DA
24792012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
2480
2481 Avoid direct writes to contents member of struct Lisp_Vector.
2482 * lisp.h (vcopy): New function to copy data into vector.
2483 * dispnew.c (Fframe_or_buffer_changed_p): Use AREF and ASET.
2484 * fns.c (Ffillarray): Use ASET.
2485 * keyboard.c (timer_check_2): Use AREF and ASET.
2486 (append_tool_bar_item, Frecent_keys): Use vcopy.
2487 * lread.c (read_vector): Use ASET.
2488 * msdos.c (Frecent_doskeys): Use vcopy.
2489 * xface.c (Finternal_copy_lisp_face): Use vcopy.
2490 (Finternal_merge_in_global_face): Use ASET and vcopy.
2491 * xfont.c (xfont_list_pattern): Likewise.
2492
5481664a
MR
24932012-08-21 Martin Rudalics <rudalics@gmx.at>
2494
2495 * window.c (Fwindow_point): For the selected window always return
2496 the position of its buffer's point.
2497 (Fset_window_point): For the selected window always go in its
2498 buffer to the specified position.
2499
6d470bdd
DA
25002012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
2501
2502 Setter macros for fontsets.
2503 * fontset.c (SET_FONTSET_ID, SET_FONTSET_NAME, SET_FONTSET_ASCII)
2504 (SET_FONTSET_BASE, SET_FONTSET_FRAME, SET_FONTSET_NOFONT_FACE)
2505 (SET_FONTSET_DEFAULT, SET_FONTSET_FALLBACK): New macros.
2506 Adjust users.
2507
24564fe1
GM
25082012-08-20 Glenn Morris <rgm@gnu.org>
2509
2510 * Makefile.in (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2511 Don't assume that `ln -f' works.
2512
0a05a035
EZ
25132012-08-20 Eli Zaretskii <eliz@gnu.org>
2514
2515 * .gdbinit: Use "set $dummy = ..." to avoid warnings from GDB 7.5
2516 and later about non-assignments with no effect. See discussion at
2517 http://sourceware.org/ml/gdb-patches/2012-08/msg00518.html for
2518 details.
2519
e46f2325
DA
25202012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
2521
2522 Inline setter functions for Lisp_Objects slots of struct specbinding.
2523 * eval.c (set_specpdl_symbol, set_specpdl_old_value): New functions.
2524 Adjust users.
2525
734fbd86
MR
25262012-08-20 Martin Rudalics <rudalics@gmx.at>
2527
2528 * window.c (select_window): Always make selected window's buffer
2529 current.
2530
f1a95992
DA
25312012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
2532
2533 Use AREF and ASET for docstrings of category tables.
2534 * category.h (CATEGORY_DOCSTRING): Use AREF.
2535 (SET_CATEGORY_DOCSTRING): Use ASET.
2536 * category.c (Fdefine_category): Use SET_CATEGORY_DOCSTRING.
2537
e83064be
DA
25382012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
2539
2540 Inline setter functions for hash table members.
2541 * lisp.h (set_hash_key, set_hash_value, set_hash_next)
2542 (set_hash_hash, set_hash_index): Rename with _slot suffix.
2543 (set_hash_key_and_value, set_hash_index, set_hash_next)
2544 (set_hash_hash): New functions.
2545 * charset.c, fns.c: Adjust users.
2546
4ce60d2e
DA
25472012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
2548
2549 Inline getter and setter functions for per-buffer values.
2550 * buffer.h (per_buffer_default, set_per_buffer_default)
2551 (per_buffer_value, set_per_buffer_value): New functions.
2552 (PER_BUFFER_VALUE, PER_BUFFER_DEFAULT): Remove.
2553 * buffer.c, data.c: Adjust users.
2554
c06c9690
JB
25552012-08-20 Juanma Barranquero <lekktu@gmail.com>
2556
2557 * makefile.w32-in ($(BLD)/vm-limit.$(O)): Update dependencies.
2558
32bd4250
PE
25592012-08-19 Paul Eggert <eggert@cs.ucla.edu>
2560
bad03192 2561 Rely on <config.h> + <unistd.h> to declare 'environ',
b69a6d22
PE
2562 as gnulib does this if the system doesn't.
2563 * callproc.c, editfns.c, process.c (environ) [!USE_CRT_DLL]:
72279493
EZ
2564 Remove declaration. MS-Windows declares it on stdlib.h which is
2565 included by conf_post.h.
b69a6d22
PE
2566 * emacs.c (environ) [DOUG_LEA_MALLOC]:
2567 * vm-limit.c (environ) [ORDINARY_LINK]: Remove decl.
2568 * vm-limit.c: Include <unistd.h>, for 'environ'.
2569
22d7feb2
PE
2570 * unexaix.c, unexcoff.c: Include "mem-limits.h".
2571 (start_of_data): Remove decl; mem-limits.h provides it.
2572
32bd4250
PE
2573 * xdisp.c (handle_invisible_prop): Make it a bit faster
2574 and avoid a gcc -Wmaybe-uninitialized diagnostic.
2575
450809af
CY
25762012-08-19 Chong Yidong <cyd@gnu.org>
2577
2578 * xdisp.c (handle_invisible_prop): Fix ellipses at overlay string
2579 ends (Bug#3874).
2580
9e677988
AS
25812012-08-19 Andreas Schwab <schwab@linux-m68k.org>
2582
6b1319ce
AS
2583 * .gdbinit: Use call instead of set when calling a function in the
2584 inferior.
2585
9e677988
AS
2586 * data.c (set_internal): Don't use set_blv_found.
2587 (Fkill_local_variable): Likewise.
2588
d7191076
AA
25892012-08-18 Alp Aker <alp.tekin.aker@gmail.com>
2590
2591 * nsfont.m (ns_ascii_average_width): Ensure the string
2592 ascii_printable is initialized with a null-terminated character
2593 array. Otherwise, it can contain undesired extra characters.
2594
e757f1c6
PE
25952012-08-18 Paul Eggert <eggert@cs.ucla.edu>
2596
2597 port new setting code to Sun C 5.8 2005/10/13
2598 * chartab.c, lisp.h (char_table_set, char_table_set_range):
2599 Return void, not Lisp_Object. Otherwise, the compiler
2600 complains about (A?B:C) where B is void and C is Lisp_Object
2601 when compiling CHAR_TABLE_SET, due to the recent change to
2602 the API of sub_char_table_set_contents.
2603
a999ce26
CY
26042012-08-18 Chong Yidong <cyd@gnu.org>
2605
2606 * xdisp.c (handle_invisible_prop): Obey TEXT_PROP_MEANS_INVISIBLE
2607 for the string case (Bug#3874).
2608
3f22b86f
PE
26092012-08-18 Paul Eggert <eggert@cs.ucla.edu>
2610
39eb03f1
PE
2611 * buffer.h (BSET): Remove (Bug#12215).
2612 Replace all uses with calls to new setter functions.
2613 (bset_bidi_paragraph_direction, bset_case_canon_table)
2614 (bset_case_eqv_table, bset_directory, bset_display_count)
2615 (bset_display_time, bset_downcase_table)
2616 (bset_enable_multibyte_characters, bset_filename, bset_keymap)
2617 (bset_last_selected_window, bset_local_var_alist)
2618 (bset_mark_active, bset_point_before_scroll, bset_read_only)
2619 (bset_truncate_lines, bset_undo_list, bset_upcase_table)
2620 (bset_width_table):
2621 * buffer.c (bset_abbrev_mode, bset_abbrev_table)
2622 (bset_auto_fill_function, bset_auto_save_file_format)
2623 (bset_auto_save_file_name, bset_backed_up, bset_begv_marker)
2624 (bset_bidi_display_reordering, bset_buffer_file_coding_system)
2625 (bset_cache_long_line_scans, bset_case_fold_search)
2626 (bset_ctl_arrow, bset_cursor_in_non_selected_windows)
2627 (bset_cursor_type, bset_display_table, bset_extra_line_spacing)
2628 (bset_file_format, bset_file_truename, bset_fringe_cursor_alist)
2629 (bset_fringe_indicator_alist, bset_fringes_outside_margins)
2630 (bset_header_line_format, bset_indicate_buffer_boundaries)
2631 (bset_indicate_empty_lines, bset_invisibility_spec)
2632 (bset_left_fringe_width, bset_major_mode, bset_mark)
2633 (bset_minor_modes, bset_mode_line_format, bset_mode_name)
2634 (bset_name, bset_overwrite_mode, bset_pt_marker)
2635 (bset_right_fringe_width, bset_save_length)
2636 (bset_scroll_bar_width, bset_scroll_down_aggressively)
2637 (bset_scroll_up_aggressively, bset_selective_display)
2638 (bset_selective_display_ellipses, bset_vertical_scroll_bar_type)
2639 (bset_word_wrap, bset_zv_marker):
2640 * category.c (bset_category_table):
2641 * syntax.c (bset_syntax_table):
2642 New setter functions.
2643
6a09a33b
PE
2644 * process.h (PSET): Remove (Bug#12215).
2645 Replace all uses with calls to new setter functions.
2646 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2647 (PROCESS_INLINE): New macro.
2648 (pset_childp): New setter function.
2649 (pset_gnutls_cred_type) [HAVE_GNUTLS]: New setter function.
2650 * process.c (PROCESS_INLINE):
2651 Define to EXTERN_INLINE, so that the corresponding functions
2652 are compiled into code.
2653 (pset_buffer, pset_command, pset_decode_coding_system)
2654 (pset_decoding_buf, pset_encode_coding_system)
2655 (pset_encoding_buf, pset_filter, pset_log, pset_mark, pset_name)
2656 (pset_plist, pset_sentinel, pset_status, pset_tty_name)
2657 (pset_type, pset_write_queue): New setter functions.
2658
e8c17b81
PE
2659 * window.h (WSET): Remove (Bug#12215).
2660 Replace all uses with calls to new setter functions.
2661 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2662 (WINDOW_INLINE): New macro.
2663 (wset_buffer, wset_frame, wset_left_col, wset_next, wset_prev)
2664 (wset_redisplay_end_trigger, wset_top_line, wset_total_cols)
2665 (wset_total_lines, wset_vertical_scroll_bar)
2666 (wset_window_end_pos, wset_window_end_valid)
2667 (wset_window_end_vpos): New setter functions.
2668 * window.c (WINDOW_INLINE):
2669 Define to EXTERN_INLINE, so that the corresponding functions
2670 are compiled into code.
2671 (wset_combination_limit, wset_dedicated, wset_display_table)
2672 (wset_hchild, wset_left_fringe_width, wset_left_margin_cols)
2673 (wset_new_normal, wset_new_total, wset_next_buffers)
2674 (wset_normal_cols, wset_normal_lines, wset_parent, wset_pointm)
2675 (wset_prev_buffers, wset_right_fringe_width)
2676 (wset_right_margin_cols, wset_scroll_bar_width, wset_start)
2677 (wset_temslot, wset_vchild, wset_vertical_scroll_bar_type)
2678 (wset_window_parameters):
2679 * xdisp.c (wset_base_line_number, wset_base_line_pos)
2680 (wset_column_number_displayed, wset_region_showing):
2681 New setter functions.
2682
3f22b86f
PE
2683 * termhooks.h (TSET): Remove (Bug#12215).
2684 Replace all uses with calls to new setter functions.
2685 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2686 (TERMHOOKS_INLINE): New macro.
2687 (tset_charset_list, tset_selection_alist): New setter functions.
2688 * terminal.c (TERMHOOKS_INLINE):
2689 Define to EXTERN_INLINE, so that the corresponding functions
2690 are compiled into code.
2691 (tset_param_alist): New setter function.
2692
742af32f
PE
26932012-08-17 Paul Eggert <eggert@cs.ucla.edu>
2694
15dbb4d6
PE
2695 * keyboard.h (KSET): Remove (Bug#12215).
2696 Replace all uses with calls to new setter functions.
2697 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2698 (KEYBOARD_INLINE): New macro.
2699 (kset_default_minibuffer_frame, kset_defining_kbd_macro)
2700 (kset_input_decode_map, kset_last_command, kset_last_kbd_macro)
2701 (kset_prefix_arg, kset_system_key_alist, kset_window_system):
2702 New setter functions.
2703 * keyboard.c (KEYBOARD_INLINE):
2704 Define to EXTERN_INLINE, so that the corresponding functions
2705 are compiled into code.
2706 (kset_echo_string, kset_kbd_queue)
2707 (kset_keyboard_translate_table, kset_last_prefix_arg)
2708 (kset_last_repeatable_command, kset_local_function_key_map)
2709 (kset_overriding_terminal_local_map, kset_real_last_command)
2710 (kset_system_key_syms): New setter functions.
2711
f00af5b1
PE
2712 * frame.h (FSET): Remove (Bug#12215).
2713 Replace all uses with calls to new setter functions.
2714 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2715 (FRAME_INLINE): New macro.
2716 (fset_buffer_list, fset_buried_buffer_list, fset_condemned_scroll_bars)
2717 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
2718 (fset_face_alist, fset_focus_frame, fset_icon_name, fset_menu_bar_items)
2719 (fset_menu_bar_vector, fset_menu_bar_window, fset_name)
2720 (fset_param_alist, fset_root_window, fset_scroll_bars)
2721 (fset_selected_window, fset_title, fset_tool_bar_items)
2722 (fset_tool_bar_position, fset_tool_bar_window): New functions.
2723 * frame.c (FRAME_INLINE):
2724 Define to EXTERN_INLINE, so that the corresponding functions
2725 are compiled into code.
2726 (fset_buffer_predicate, fset_minibuffer_window): New setter functions.
2727
0c94c8d6
PE
2728 A few more naming-convention fixes for getters and setters.
2729 * buffer.c (set_buffer_overlays_before): Move here from buffer.h,
2730 and rename from buffer_overlays_set_before.
2731 (set_buffer_overlays_after): Move here from buffer.h, and rename
2732 from buffer_overlays_set_after.
2733 * buffer.h (buffer_intervals): Rename from buffer_get_intervals.
2734 All uses changed.
2735 (set_buffer_intervals): Rename from buffer_set_intervals.
2736 * intervals.c (set_interval_object): Move here from intervals.h,
2737 and rename from interval_set_object.
2738 (set_interval_left): Move here from intervals.h, and rename from
2739 interval_set_left.
2740 (set_interval_right): Move here from intervals.h, and rename from
2741 interval_set_right.
2742 (copy_interval_parent): Move here from intervals.h, and rename from
2743 interval_copy_parent.
2744 * intervals.h (set_interval_parent): Rename from interval_set_parent.
2745 (set_interval_plist): Rename from interval_set_plist.
2746 Return void, not Lisp_Object, since no caller uses the result.
2747 * lisp.h (string_intervals): Rename from string_get_intervals.
2748 (set_string_intervals): Rename from string_set_intervals.
2749
34dabdb7
PE
2750 * lisp.h (set_char_table_extras): Rename from char_table_set_extras.
2751 (set_char_table_contents): Rename from char_table_set_contents.
0b390a9d 2752 (set_sub_char_table_contents): Rename from sub_char_table_set_contents.
34dabdb7
PE
2753 All uses changed. See the end of
2754 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00549.html>.
2755
742af32f
PE
2756 * lisp.h (CSET): Remove (Bug#12215).
2757 (set_char_table_ascii, set_char_table_defalt, set_char_table_parent)
2758 (set_char_table_purpose): New functions,
2759 replacing CSET. All uses changed. For example, replace
2760 "CSET (XCHAR_TABLE (char_table), parent, parent);" with
c24eb18a 2761 "set_char_table_parent (char_table, parent);".
742af32f
PE
2762 The old version was confusing because it used the same name
2763 'parent' for two different things.
2764
a04e2c62
DA
27652012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
2766
2767 Functions to get and set Lisp_Object fields of buffer-local variables.
2768 * lisp.h (blv_found, set_blv_found, blv_value, set_blv_value)
2769 (set_blv_where, set_blv_defcell, set_blv_valcell): New functions.
2770 (BLV_FOUND, SET_BLV_FOUND, BLV_VALUE, SET_BLV_VALUE): Remove.
2771 * data.c, eval.c, frame.c: Adjust users.
2772
383dcbf9
CY
27732012-08-17 Chong Yidong <cyd@gnu.org>
2774
2775 * xfaces.c (merge_face_vectors): If the target font specfies a
2776 font spec, make the font's attributes take precedence over
2777 directly-specified attributes.
2778 (merge_face_ref): Recognize :font.
2779
44386687
DA
27802012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
2781
2782 Do not use memcpy for copying intervals.
2783 * intervals.c (reproduce_interval): New function.
2784 (reproduce_tree, reproduce_tree_obj): Use it.
2785 (reproduce_tree_obj): Remove prototype.
2786
927c7216
PE
27872012-08-17 Paul Eggert <eggert@cs.ucla.edu>
2788
2789 * lisp.h (duration_to_sec_usec): Remove unused decl.
2790
93044f7b
AA
27912012-08-17 Alp Aker <alp.tekin.aker@gmail.com>
2792
2793 * nsfont.m (ns_ascii_average_width): Send initWithFormat selector
2794 to an allocated instance of NSString, not to the class itself.
2795
9851e4a5
JB
27962012-08-17 Juanma Barranquero <lekktu@gmail.com>
2797
2798 * makefile.w32-in (C_CTYPE_H): New macro.
2799 (LISP_H, $(BLD)/ccl.$(O), $(BLD)/doc.$(O), $(BLD)/w32console.$(O)):
2800 ($(BLD)/fontset.$(O), $(BLD)/frame.$(O), $(BLD)/composite.$(O)):
2801 ($(BLD)/sysdep.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
2802
620f13b0
PE
28032012-08-16 Paul Eggert <eggert@cs.ucla.edu>
2804
2805 Use ASCII tests for character types.
2806 * category.c, dispnew.c, doprnt.c, editfns.c, syntax.c, term.c:
2807 * xfns.c, xterm.c:
2808 Don't include <ctype.h>; was not needed.
2809 * charset.c, doc.c, fileio.c, font.c, frame.c, gtkutil.c, image.c:
2810 * sysdep.c, xfaces.c:
2811 Include <c-ctype.h> instead of <ctype.h>.
2812 * nsterm.m: Include <c-ctype.h>.
2813 * charset.c (read_hex):
2814 * doc.c (Fsnarf_documentation):
2815 * fileio.c (IS_DRIVE) [WINDOWSNT]:
2816 (DRIVE_LETTER) [DOS_NT]:
2817 (Ffile_name_directory, Fexpand_file_name)
2818 (Fsubstitute_in_file_name):
2819 * font.c (font_parse_xlfd, font_parse_fcname):
2820 * frame.c (x_set_font_backend):
2821 * gtkutil.c (xg_get_font):
2822 * image.c (xbm_scan, xpm_scan, pbm_scan_number):
2823 * nsimage.m (hexchar):
2824 * nsterm.m (ns_xlfd_to_fontname):
2825 * sysdep.c (system_process_attributes):
2826 * xfaces.c (hash_string_case_insensitive):
2827 Use C-locale tests instead of locale-specific tests for character
2828 types, since we want the ASCII interpretation here, not the
2829 interpretation suitable for whatever happens to be the current locale.
2830
52162052
MR
28312012-08-16 Martin Rudalics <rudalics@gmx.at>
2832
2833 Consistently check windows for validity/liveness
2834 (Bug#11984, Bug#12025, Bug#12026).
2835 * lisp.h (CHECK_VALID_WINDOW): New macro.
2836 * window.c (decode_window): Rename to decode_live_window.
2837 (decode_valid_window, Fwindow_valid_p): New functions.
2838 (Fwindow_frame, Fframe_root_window, Fwindow_minibuffer_p)
2839 (Fframe_first_window, Fframe_selected_window, Fwindow_parent)
2840 (Fwindow_top_child, Fwindow_left_child, Fwindow_next_sibling)
2841 (Fwindow_prev_sibling, Fwindow_combination_limit)
2842 (Fset_window_combination_limit, Fwindow_use_time)
2843 (Fwindow_total_height, Fwindow_total_width, Fwindow_new_total)
2844 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_left_column)
2845 (Fwindow_top_line, Fwindow_body_height, Fwindow_body_width)
2846 (Fwindow_hscroll, Fset_window_hscroll)
2847 (Fwindow_redisplay_end_trigger)
2848 (Fset_window_redisplay_end_trigger, Fwindow_edges)
2849 (Fwindow_pixel_edges, Fwindow_absolute_pixel_edges)
2850 (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
2851 (Fcoordinates_in_window_p, Fwindow_point, Fwindow_start)
2852 (Fwindow_end, Fset_window_point, Fset_window_start)
2853 (Fpos_visible_in_window_p, Fwindow_line_height)
2854 (Fwindow_dedicated_p, Fset_window_dedicated_p)
2855 (Fwindow_prev_buffers, Fset_window_prev_buffers)
2856 (Fwindow_next_buffers, Fwindow_parameters, Fwindow_parameter)
2857 (Fset_window_parameter, Fwindow_display_table)
2858 (Fset_window_display_table, Fdelete_other_windows_internal)
2859 (Fset_window_buffer, Fset_window_new_total)
2860 (Fset_window_new_normal, Fdelete_window_internal)
2861 (Fwindow_text_height, Fset_window_margins, Fwindow_margins)
2862 (Fset_window_fringes, Fwindow_fringes, Fset_window_scroll_bars)
2863 (Fwindow_scroll_bars): Check whether argument window is a valid or
2864 live window. Update doc-strings.
2865 (syms_of_window): New symbol Qwindow_valid_p.
2866 * keyboard.c (Fposn_at_x_y): Check whether argument
2867 frame_or_window denotes a valid window.
2868
2751c80f
DA
28692012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
2870
2871 Fix previous char table change.
2872 * lisp.h (CHAR_TABLE_SET): Use sub_char_table_set_contents.
2873 * chartab.c (optimize_sub_char_table): Likewise.
2874
032a42c8
CY
28752012-08-16 Chong Yidong <cyd@gnu.org>
2876
a2d19368
CY
2877 * gtkutil.c (xg_get_font): Demand an Xft font (Bug#3228).
2878
032a42c8
CY
2879 * xfont.c (xfont_open):
2880 * xftfont.c (xftfont_open): Set the font's max_width field.
2881
2882 * nsfont.m (nsfont_open): Similar to the Xft backend, set
2883 min_width to space_width and average_width to the average over
2884 printable ASCII characters.
2885 (ns_char_width): Code cleanup.
2886 (ns_ascii_average_width): New utility function.
2887
2888 * font.h (struct font): Update comments.
2889
a098c930
DA
28902012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
2891
032a42c8 2892 Simple interface to set Lisp_Object fields of character tables.
a098c930
DA
2893 * lisp.h (CSET): New macro.
2894 (char_table_set_extras, char_table_set_contents)
2895 (sub_char_table_set_contents): New function.
2896 * casetab.c, category.c, chartab.c, fns.c, fontset.c, search.c:
2897 * syntax.c: Adjust users.
2898
8be3a09c
SM
28992012-08-16 Stefan Monnier <monnier@iro.umontreal.ca>
2900
2901 * eval.c (eval_sub): Bind lexical-binding.
2902 * lread.c (Qlexical_binding): Make non-static.
2903
ac4845a6
JD
29042012-08-15 Jan Djärv <jan.h.d@swipnet.se>
2905
ddee6515
JD
2906 * nsmenu.m (popupSession): Remove.
2907 (pop_down_menu): Remove endModalSession.
2908 (timeout_handler:): New method.
2909 (runDialogAt:): Get next timeout. Start a NSTimer with that timeout.
2910 Call runModalForWindow. Check timer_fired when it returns.
2911 If not set, cancel timer and break out of loop.
2912 Otherwise loop again, with a new timeout.
2913
2914 * nsterm.m: Include fcntl.h if present.
2915 (fd_entry, t_readfds, inNsSelect): Remove.
2916 (select_writefds, select_valid, select_timeout, selfds)
2917 (select_mutex, apploopnr): Add.
2918 (EV_TRAILER): Call kbd_buffer_store_event_hold only if q_event_ptr.
2919 Otherwise call kbd_buffer_store_event.
2920 (ns_send_appdefined): Remove release of fd_entry.
2921 (ns_read_socket): Always send appdefined. Remove inNsSelect check.
2922 Increment and decrement apploopnr.
2923 (ns_select): If no file descriptors, just do a NSTimer.
2924 Otherwise copy read/write masks and start select thread (fd_handler).
2925 Start main loop and wait for application defined event.
2926 Inform select thread to stop selecting after main loop is exited.
2927 (ns_term_init): Create selfds pipe and set non-blocking.
fc0c31f8 2928 Initialize select_mutex. Start the select thread (fd_handler).
ddee6515
JD
2929 (fd_handler:): Loop forever, wait for info from the main thread
2930 to either start or stop selecting. When select returns, send
2931 and appdefined event.
2932 (sendScrollEventAtLoc:fromEvent:): Check if q_event_ptr is set.
2933 If not call kbd_buffer_store_event.
2934
2935 * nsterm.h (EmacsApp): fd_handler takes id argument.
2936 (EmacsDialogPanel): Add timer_fired and timeout_handler.
2937
ac4845a6
JD
2938 * gtkutil.c (xg_mark_data): Use FRAME_X_P.
2939
eb424fe3
EZ
29402012-08-15 Eli Zaretskii <eliz@gnu.org>
2941
2942 * region-cache.c (move_cache_gap): Update gap_len using the actual
2943 growth of the boundaries array. Do not change cache_len.
2944 (Bug#12196)
2945
4e6a86c6
DA
29462012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
2947
2948 Generalize and cleanup font subsystem checks.
2949 * font.h (FONT_DEBUG, font_assert): Remove.
8be3a09c
SM
2950 * font.c, fontset.c, w32font.c, xfont.c, xftfont.c:
2951 Change font_assert to eassert. Use eassert where appropriate.
4e6a86c6 2952
5bf192ca
DA
29532012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
2954
2955 * gtkutil.c (xg_get_font): Use pango_units_to_double.
2956
f2045622
CY
29572012-08-15 Chong Yidong <cyd@gnu.org>
2958
8be3a09c
SM
2959 * gtkutil.c (xg_get_font): Rename from xg_get_font_name.
2960 When using the new font chooser, use gtk_font_chooser_get_font_desc to
2961 extract the font descriptor instead of just the font name.
2962 In that case, return a font spec instead of a string.
f2045622
CY
2963 (x_last_font_name): Move to this file from xfns.c.
2964
2965 * xfns.c (Fx_select_font): The return value can also be a font
2966 spec. Move x_last_font_name management to gtkutil.c.
2967
2968 * xfaces.c: Make font weight and style symbols non-static.
2969
7f6feb56
SM
29702012-08-15 Stefan Monnier <monnier@iro.umontreal.ca>
2971
2972 * minibuf.c (read_minibuf): Ignore caller's inhibit-read-only
2973 (bug#12117).
2974
fecbd8ff
SM
29752012-08-14 Stefan Monnier <monnier@iro.umontreal.ca>
2976
2977 * alloc.c (Fgarbage_collect): Use plural form consistently.
2978
9b8d5165
EZ
29792012-08-14 Eli Zaretskii <eliz@gnu.org>
2980
2981 * keyboard.c (command_loop_1): Reset ignore_mouse_drag_p flag each
2982 iteration through the command loop. Fixes a problem whereby mouse
2983 movements are ignored until the first mouse click.
2984
f5d9e83a
PE
29852012-08-14 Paul Eggert <eggert@cs.ucla.edu>
2986
2987 Use bool, not int, for Lisp booleans.
2988 This is more natural, and on my platform (GCC 4.7.1 x86-64) it
2989 makes Emacs a bit smaller and presumably a bit faster.
2990 * lisp.h: Include <stdbool.h>.
2991 (struct Lisp_Boolfwd, defvar_bool):
2992 * lread.c (defvar_bool): Use bool, not int, for Lisp booleans.
2993 * regex.c [!emacs]: Include <stdbool.h>.
2994 (false, true): Remove; <stdbool.h> does this for us now.
2995
55802e4a
CY
29962012-08-14 Chong Yidong <cyd@gnu.org>
2997
4abcdac8
CY
2998 * character.c (Fcharacterp): Doc fix (Bug#12076).
2999
3000 * data.c (Findirect_variable): Doc fix (Bug#11040).
3001
55802e4a
CY
3002 * chartab.c (Fmap_char_table): Doc fix (Bug#12061).
3003
3004 * editfns.c (Fformat): Doc fix (Bug#12059).
4abcdac8 3005 (Fsave_current_buffer): Doc fix (Bug#11542).
55802e4a 3006
8e99d072
BR
30072012-08-14 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3008
3009 * keyboard.c (access_keymap_keyremap): Accept anonymous functions
3010 (bug#12022).
3011
08908aca
MR
30122012-08-14 Martin Rudalics <rudalics@gmx.at>
3013
3014 * frame.c (make_frame_without_minibuffer, make_minibuffer_frame)
3015 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
3016 * minibuf.c (choose_minibuf_frame, read_minibuf):
3017 * w32fns.c (x_create_tip_frame):
3018 * xfns.c (x_create_tip_frame): Call set_window_buffer instead of
3019 Fset_window_buffer (Bug#11984, Bug#12025, Bug#12026).
3020
56120d6f
PE
30212012-08-14 Paul Eggert <eggert@cs.ucla.edu>
3022
3023 * intervals.c (offset_intervals): Remove obsolete comment.
3024
67b77c0b
AS
30252012-08-14 Andreas Schwab <schwab@linux-m68k.org>
3026
3027 * gtkutil.c (find_rtl_image, update_frame_tool_bar): Use NILP.
3028
f48b82fd
GR
30292012-08-14 Gergely Risko <gergely@risko.hu>
3030
3031 * coding.c (decode_coding): Record buffer modification before
3032 disabling undo_list (Bug#11773).
3033
fd318b54
DA
30342012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
3035
3036 Revert and cleanup some recent overlay changes.
3037 * buffer.h (enum overlay_type): Remove.
3038 (buffer_get_overlays, buffer_set_overlays): Likewise.
3039 (buffer_set_overlays_before, buffer_set_overlays_after):
3040 New function. Adjust users.
3041 (unchain_both): Add eassert.
3042
41a62dd9
DA
30432012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
3044
3045 * gtkutil.c (update_frame_tool_bar): Use EQ where appropriate.
3046
5884c324
PE
30472012-08-14 Paul Eggert <eggert@cs.ucla.edu>
3048
3049 * gtkutil.c (xg_mark_data): Don't assume C99.
3050
ca06f160
JD
30512012-08-13 Jan Djärv <jan.h.d@swipnet.se>
3052
3053 * gtkutil.c (xg_frame_tb_info): New struct.
3054 (TB_INFO_KEY): New define.
3055 (xg_free_frame_widgets): Free xg_frame_tb_info for frame if present.
3056 (xg_mark_data): Mark Lisp_Objects in xg_frame_tb_info.
3057 (xg_create_tool_bar): Allocate and initialize a xg_frame_tb_info
3058 if not present.
3059 (update_frame_tool_bar): Return early if data in xg_frame_tb_info
fc0c31f8 3060 is up to date. Otherwise store new data.
ca06f160
JD
3061 (free_frame_tool_bar): Free xg_frame_tb_info if present.
3062
7864a3f7
DA
30632012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
3064
3065 Use KSET for write access to Lisp_Object members of struct kboard.
3066 * keyboard.h (KSET): New macro.
3067 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
3068 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
3069 * xterm.c: Adjust users.
3070
4c31be61
DA
30712012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
3072
3073 Use BSET for write access to Lisp_Object members of struct buffer.
3074 * buffer.h (BSET): New macro.
3075 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
3076 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
3077 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
3078 * window.c, xdisp.c, xfns.c: Adjust users.
3079
14ae4239
BT
30802012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
3081
3082 * lread.c (syms_of_lread): Initialize Vlexical_binding.
3083
32bcadb4
JD
30842012-08-11 Jan Djärv <jan.h.d@swipnet.se>
3085
3d29b2ce 3086 * nsterm.m (not_in_argv): New function.
fc0c31f8 3087 (application:openFile, application:openTempFile:):
3d29b2ce
JD
3088 (application:openFileWithoutUI:, application:openFiles:): Open file
3089 if not_in_argv returns non-zero (bug#12171).
3090
32bcadb4 3091 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
3092 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
3093 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
3094 (xg_get_font_name): Use those functions/macros here.
3095 Reported by Frans Oilinki <moilinki@gmail.com>.
3096
9ff9402d 30972012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
3098
3099 * unexmacosx.c (copy_data_segment): Copy initialized data in
3100 statically linked libraries from input file rather than memory.
3101
db74a5fc
YM
3102 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
3103 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
3104 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
3105
25e65510
GM
31062012-08-10 Glenn Morris <rgm@gnu.org>
3107
3108 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
3109 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
3110
7961135c
DA
31112012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
3112
3113 Fix last change to allow compilation with low optimization levels.
3114 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
3115 Reported by Jan Djärv <jan.h.d@swipnet.se>.
3116
42b3a444
DA
31172012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
3118
3119 Use common inline syntax in intervals.h.
3120 * intervals.h (INTERVALS_INLINE): New macro.
3121 Change all users from LISP_INLINE.
3122
9fb0c957
DA
31232012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
3124
3125 Define Qnone once for all platforms.
3126 * frame.c (Qnone): Define here.
3127 (syms_of_frame): DEFSYM it.
3128 * lisp.h (Qnone): New declaration.
3129 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
3130 * xfns.c: Remove duplication. Adjust users.
3131
65e8ee52
DA
31322012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
3133
3134 Remove unused macros from intervals.h.
3135 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
3136 * intervals.c: Adjust comment.
3137
9b855fd6
EZ
31382012-08-10 Eli Zaretskii <eliz@gnu.org>
3139
3140 * w32fns.c <w32_unicode_gui>: New static variable.
3141 (globals_of_w32fns): Initialize it according to os_subtype.
3142 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
3143 testing os_subtype.
3144
39cb9e56 31452012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
3146 Eli Zaretskii <eliz@gnu.org>
3147
3148 Fix bug #10299 with Unicode characters sent by customized
3149 keyboards created by MSKLC.
3150 * w32fns.c (INIT_WINDOW_CLASS): New macro.
3151 (w32_init_class): Use it to initialize the Emacs class with either
3152 ANSI or Unicode API calls.
3153 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
3154 later.
3155 (w32_wnd_proc): If the character code sent by WM_CHAR or
3156 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
3157 original message. Call DefWindowProcW on NT and later.
3158
9374581a
GM
31592012-08-10 Glenn Morris <rgm@gnu.org>
3160
4b94e8cf
GM
3161 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
3162
9374581a
GM
3163 * lisp.h (DIRECTORY_SEP): Let configure set it.
3164
a2752828
DA
31652012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
3166
3167 Use TSET for write access to Lisp_Object slots of struct terminal.
3168 * termhooks.h (TSET): New macro.
3169 * coding.c, terminal.c, xselect.c: Adjust users.
3170
cc92c454
SM
31712012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
3172
3173 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
3174 the failing expression, include them in the error message.
3175 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
3176 * lisp.h (internal_condition_case_n): Update declaration.
3177
4cb3e6b3
DA
31782012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
3179
3180 Inline functions to examine and change buffer overlays.
3181 * buffer.c (unchain_both): New function.
3182 * buffer.h (buffer_get_overlays, buffer_set_overlays):
3183 (buffer_has_overlays): New function.
3184 (enum overlay_type): New enum.
3185 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
3186 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
3187
8707c1e5
DA
31882012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
3189
3190 Inline functions to examine and change buffer intervals.
3191 * alloc.c (mark_interval_tree): Remove.
3192 (MARK_INTERVAL_TREE): Simplify.
3193 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
3194 * intervals.c (buffer_balance_intervals): New function.
3195 (graft_intervals_into_buffer): Adjust indentation.
3196 (set_intervals_multibyte): Simplify.
3197 * buffer.h (BUF_INTERVALS): Remove.
3198 (buffer_get_intervals, buffer_set_intervals): New function.
3199 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
3200 * intervals.c, textprop.c: Adjust users.
3201
ad8c997f
DA
32022012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
3203
3204 Inline functions to examine and change string intervals.
3205 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
3206 (string_get_intervals, string_set_intervals): New function.
3207 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
3208 * lread.c, print.c, textprop.c: Adjust users.
3209
32ac3a6b
GM
32102012-08-08 Glenn Morris <rgm@gnu.org>
3211
3212 * lisp.mk (lisp): Remove language/persian.elc.
3213
77c7bcb1
DA
32142012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
3215
3216 Cleanup intervals.
3217 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
3218 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
3219 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
3220 Adjust comment. Move under #if 0.
77c7bcb1
DA
3221 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
3222 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
3223
9c08a8d4
DA
32242012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
3225
3226 Check total length of intervals with eassert.
3227 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
3228 * intervals.c: Change all users to eassert.
3229
26d16b35
EZ
32302012-08-07 Eli Zaretskii <eliz@gnu.org>
3231
14ae4239
BT
3232 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
3233 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
3234 INTERNAL_FIELD in Lisp_Cons.
3235
c644523b
DA
32362012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
3237
3238 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
3239 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
3240 name since all xname users are fixed long time ago. Do not
3241 use INTERNAL_FIELD.
3242 (set_symbol_name, set_symbol_function, set_symbol_plist):
3243 (set_symbol_next, set_overlay_plist): New function.
3244 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
3245 (struct Lisp_Overlay): Likewise.
3246 (CVAR, MVAR, SVAR): Remove.
3247 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
3248 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
3249 * xterm.c: Adjust users.
3250 * .gdbinit: Change to use name field of struct Lisp_Symbol
3251 where appropriate.
3252
6a3d20cc
DA
32532012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
3254
3255 Basic functions to set Lisp_Object and pointer slots of intervals.
3256 * intervals.h (interval_set_parent, interval_set_object):
3257 (interval_set_left, interval_set_right, interval_set_plist):
3258 (interval_copy_parent): New function.
3259 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
3260 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
3261 Adjust indentation.
6a3d20cc
DA
3262 (INTERVAL_SIZE): Remove. Adjust users.
3263 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
3264
4d2b044c
DA
32652012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
3266
3267 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
3268 * process.h (PGET): Remove.
3269 (struct Lisp_Process): Do not use INTERNAL_FIELD.
3270 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
3271
d3d50620
DA
32722012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
3273
3274 Drop WGET and revert read access to Lisp_Objects slots of struct window.
3275 * window.h (WGET): Remove.
3276 (struct window): Do not use INTERNAL_FIELD.
3277 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
3278 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
3279 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
3280 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
3281 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
3282 Adjust users.
3283
d10a51dc
CY
32842012-08-07 Chong Yidong <cyd@gnu.org>
3285
3286 * window.c (Fwindow_edges, Fwindow_pixel_edges)
3287 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
3288 (Fdelete_window_internal): Signal an error if the window is not on
3289 a live frame (Bug#12025).
3290
e69b0960
DA
32912012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
3292
3293 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
3294 * frame.h (FGET): Remove.
3295 (struct frame): Do not use INTERNAL_FIELD.
3296 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
3297 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
3298 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
3299 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
3300
25a20a3a
JB
33012012-08-06 Juanma Barranquero <lekktu@gmail.com>
3302
3303 * w32.c: Silence compiler warnings.
3304 (map_w32_filename): Remove unused variable `is_fat'.
3305 (chase_symlinks): Add parentheses around expression.
3306
1c6f11f4
GM
33072012-08-06 Glenn Morris <rgm@gnu.org>
3308
1db4583a
GM
3309 * sysdep.c: Respect BROKEN_GETWD.
3310
1c6f11f4
GM
3311 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
3312 Let configure handle it.
3313 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
3314
2b90362b
DA
33152012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3316
3317 Use GCALIGNMENT where appropriate.
3318 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
3319 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
3320 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
3321
5f50daf2
EZ
33222012-08-06 Eli Zaretskii <eliz@gnu.org>
3323
14ae4239
BT
3324 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
3325 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 3326
cbcc7007
SM
33272012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
3328
3329 * buffer.h (struct buffer): Revert `indirections' to a simple int;
3330 that should be sufficient for everyone.
3331
4d365fa4
JD
33322012-08-06 Jan Djärv <jan.h.d@swipnet.se>
3333
3334 * keyboard.c (timer_check_2): Add break so timer_check returns next
3335 timeout.
3336
dd86bd82
DA
33372012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3338
3339 Fix Windows build errors introduced after converting to WGET and WSET.
3340 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
3341 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
3342
054e1668
JD
33432012-08-06 Jan Djärv <jan.h.d@swipnet.se>
3344
3345 * nsterm.m (ns_frame_rehighlight): Use FSET.
3346
3347 * nsmenu.m (ns_update_menubar): Use FSET.
3348
21238f11
DA
33492012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3350
3351 Separate read and write access to Lisp_Object slots of Lisp_Process.
3352 * process.h (PGET, PSET): New macros similar to AREF and ASET.
3353 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
3354
077288cf
DA
33552012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3356
3357 Separate read and write access to Lisp_Object slots of struct window.
3358 * window.h (WGET, WSET): New macros similar to AREF and ASET.
3359 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
3360 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
3361 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
3362 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
3363 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
3364 Adjust users.
3365
71688bd7
DA
33662012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3367
3368 Fix Windows build errors introduced after converting to FGET and FSET.
3369 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
3370 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
3371 (w32_judge_scroll_bars): Change to use FSET.
3372 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
3373
f99bac93
DA
33742012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3375
3376 Fix replacement typo.
3377 * window.c (replace_window): Set root_window instead of
3378 selected_window. This fixes a total window subsystem
3379 malfunction reported by Bastien Guerry <bzg@gnu.org>.
3380
8c2a0f2d
GM
33812012-08-06 Glenn Morris <rgm@gnu.org>
3382
3383 * lisp.mk (lisp): Add language/persian.elc.
3384
edd74c35
DA
33852012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3386
3387 Separate read and write access to Lisp_Object slots of struct frame.
3388 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
3389 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
3390 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
3391 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
3392 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
3393
8671676c
AS
33942012-08-05 Andreas Schwab <schwab@linux-m68k.org>
3395
3396 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
3397
663e2b3f
DA
33982012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
3399
3400 Generalize common compile-time constants.
3401 * lisp.h (header_size, bool_header_size, word_size): Now here.
3402 (struct Lisp_Vector): Add comment.
3403 (struct Lisp_Bool_Vector): Move up to define handy constants.
3404 (VECSIZE, PSEUDOVECSIZE): Simplify.
3405 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
3406 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
3407 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
3408 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
3409 * xfont.c, xmenu.c: Use word_size where appropriate.
3410
d32e47af
LM
34112012-08-05 Lawrence Mitchell <wence@gmx.li>
3412
3413 * search.c (Freplace_match): Treat \? in the replacement text
3414 literally (Bug#8161).
3415
e5d9c0d1
CY
34162012-08-05 Chong Yidong <cyd@gnu.org>
3417
3418 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
3419 * frame.c (Vdelete_frame_functions):
3420 * emacs.c (Vkill_emacs_hook): Doc fix.
3421
8da0576b
EZ
34222012-08-04 Eli Zaretskii <eliz@gnu.org>
3423
3424 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
3425 --with-x-toolkit=no builds.
3426 Reported by Carsten Mattner <carstenmattner@gmail.com>.
3427
02676e5d
CY
34282012-08-04 Chong Yidong <cyd@gnu.org>
3429
3430 * syntax.c (Fmodify_syntax_entry): Doc fix.
3431
97147da9
EZ
34322012-08-04 Eli Zaretskii <eliz@gnu.org>
3433
76151e2c
EZ
3434 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
3435 * w32.c (init_environment): Change the default values of many
3436 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
3437 them into environment when they were not already defined.
3438 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 3439 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
3440 (check_windows_init_file): Now external, not static.
3441 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
3442 called when Vload_path is already set up.
3443
3444 * w32.h (check_windows_init_file): Add prototype.
3445
3446 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
3447 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
3448 compatibility with Posix platforms.
3449 (main): Move the call to check_windows_init_file to here from
3450 w32.c.
3451 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
3452 any, in the DEFALT argument into the root of the Emacs build or
3453 installation tree, as appropriate.
3454
3455 * callproc.c (init_callproc_1): Call decode_env_path instead of
3456 doing its equivalent by hand.
3457 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
3458 the code that sets Vexec_path run on MS-Windows.
3459
3460 * lread.c (init_lread): Add comments to #ifdef's.
3461
97147da9
EZ
3462 * msdos.c (dos_set_window_size, IT_update_begin)
3463 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
3464 instead of direct references.
3465
185ee146
PE
34662012-08-04 Paul Eggert <eggert@cs.ucla.edu>
3467
3468 Export DEFAULT_REHASH_* to GDB.
3469 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
3470 Now constants, not macros.
3471
8834c57a
PE
34722012-08-03 Paul Eggert <eggert@cs.ucla.edu>
3473
98c6f1e3
PE
3474 Remove unnecessary casts involving pointers.
3475 These casts are no longer needed now that we assume C89 or later,
3476 since they involve casting to or from void *.
3477 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
3478 (make_pure_float, make_pure_vector):
3479 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
3480 * macros.c (Fstart_kbd_macro):
3481 * menu.c (find_and_return_menu_selection):
3482 * minibuf.c (read_minibuf_noninteractive):
3483 * sysdep.c (closedir):
3484 * xdisp.c (x_produce_glyphs):
3485 * xfaces.c (compare_fonts_by_sort_order):
3486 * xfns.c (x_real_positions, select_visual):
3487 * xselect.c (x_stop_queuing_selection_requests)
3488 (x_get_window_property, x_get_window_property_as_lisp_data):
3489 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
3490 Remove unnecessary pointer casts.
3491 * alloc.c (record_xmalloc): New function.
3492 * lisp.h (record_xmalloc): New decl.
3493 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
3494 more like a function. This is because the pointer cast is not
3495 needed. All uses changed.
3496 * print.c (print_string, print_error_message): Avoid length recalc.
3497
8834c57a
PE
3498 Improve fix for macroexp crash with debugging (Bug#12118).
3499 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
3500 ARRAY_MARK_FLAG when checking subscripts, because ASET is
3501 not supposed to be invoked from the garbage collector.
3502 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
3503 (gc_aset): New function, which is like ASET but can be
3504 used in the garbage collector.
3505 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
3506 (set_hash_index): Use it instead of ASET.
3507
6dad7178
EZ
35082012-08-03 Eli Zaretskii <eliz@gnu.org>
3509
3510 Support symlinks on latest versions of MS-Windows.
3511 * w32.c: Include winioctl.h and aclapi.h.
3512 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
3513 (revert_to_self): Forward declarations of static functions.
3514 <static BOOL g_b_init_get_security_info>:
3515 <g_b_init_create_symbolic_link>: New static flags.
3516 (globals_of_w32): Initialize them to zero.
3517 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
3518 (map_w32_filename): Improve commentary. Simplify switch.
3519 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
3520 headers (most versions of MinGW w32api don't).
3521 (get_security_info, create_symbolic_link)
3522 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
3523 New functions.
3524 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
3525 in the argument file name.
3526 (sys_access): Call unc_volume_file_attributes only if
3527 GetFileAttributes fails with network-related error codes.
3528 (sys_rename): Diagnose renaming of a symlink when the user doesn't
3529 have the required privileges.
14ae4239 3530 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
3531 get_file_security_desc.
3532 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
3533 with addition of handling of symlinks and support for 'lstat'.
3534 If possible, get file's attributes and security information by
6dad7178
EZ
3535 handle, not by name. Produce S_IFLNK bit for symlinks, when
3536 called from 'lstat'.
3537 (stat, lstat): New functions, call 'stat_worker'.
3538 (symlink, readlink, careadlinkat): Rewritten to create and resolve
3539 symlinks when the underlying filesystem supports them.
3540
f162bcc3
PE
35412012-08-02 Paul Eggert <eggert@cs.ucla.edu>
3542
79ea6c20
PE
3543 Fix macroexp crash on Windows with debugging (Bug#12118).
3544 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
3545 checking subscripts; problem introduced with the recent
3546 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
3547 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
3548 since it's used in non-static inline functions now.
3549
c0ce93fd
PE
3550 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
3551 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 3552
f162bcc3
PE
3553 Use C99-style 'extern inline' if available.
3554 * buffer.h (BUFFER_INLINE):
3555 * category.h (CATEGORY_INLINE):
3556 * character.h (CHARACTER_INLINE):
3557 * charset.h (CHARSET_INLINE):
3558 * composite.h (COMPOSITE_INLINE):
3559 * dispextern.h (DISPEXTERN_INLINE):
3560 * lisp.h (LISP_INLINE):
3561 * systime.h (SYSTIME_INLINE):
3562 New macro, replacing 'static inline' in this header.
3563 * buffer.h, category.h, character.h, charset.h, composite.h:
3564 * dispextern.h, lisp.h, systime.h:
3565 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
3566 * alloc.c (LISP_INLINE):
3567 * buffer.c (BUFFER_INLINE):
3568 * category.c (CATEGORY_INLINE):
3569 * character.c (CHARACTER_INLINE):
3570 * charset.c (CHARSET_INLINE):
3571 * composite.c (COMPOSITE_INLINE):
3572 * dispnew.c (DISPEXTERN_INLINE):
3573 * sysdep.c (SYSTIME_INLINE):
3574 Define to EXTERN_INLINE, so that the corresponding functions
3575 are compiled into code.
3576 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
3577 (INLINE_HEADER_END): New macros.
3578 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
3579 since it's used in non-static inline functions now.
a8333d03 3580 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 3581
837b365b
GM
35822012-08-02 Glenn Morris <rgm@gnu.org>
3583
d66b744d
GM
3584 * s/: Remove empty directory.
3585
837b365b
GM
3586 * s/ms-w32.h: Move to ../nt/inc.
3587 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
3588 Update for new ms-w32.h location.
3589
13294f95
PE
35902012-08-02 Paul Eggert <eggert@cs.ucla.edu>
3591
3592 Port to Solaris 8.
3593 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
3594
90df0db3
GM
35952012-08-02 Glenn Morris <rgm@gnu.org>
3596
3597 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
3598 hard-coding the path separator.
3599
4939150c
PE
36002012-08-01 Paul Eggert <eggert@cs.ucla.edu>
3601
3602 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
3603 This how ASET and AREF are supposed to work, and makes
3604 it easier to think about future improvements. See
3605 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
3606 * charset.h (set_charset_attr): New function.
3607 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
3608 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
3609 (aref_addr): New function. All uses of &AREF(...) changed.
3610 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
3611 (set_hash_index): New functions. All lvalue-style uses of
3612 HASH_KEY etc. changed.
3613 * keyboard.c (set_prop): New function. All lvalue-style uses
3614 of PROP changed.
3615
947b2afd
AA
36162012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
3617
3618 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
3619 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
3620 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
3621 * nsfns.m (ns_set_name_as_filename): Likewise.
3622 * nsmenu.m (ns_update_menubar): Likewise.
3623 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
3624
4f5d0325
EZ
36252012-08-01 Eli Zaretskii <eliz@gnu.org>
3626
2008beae
EZ
3627 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
3628 Adapt to latest changes in field names of the corresponding Lisp
288479f6 3629 objects.
2008beae 3630
4f5d0325
EZ
3631 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
3632
fe3cc771
GM
36332012-08-01 Glenn Morris <rgm@gnu.org>
3634
3635 * s/msdos.h: Remove file.
3636 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
3637 * Makefile.in (S_FILE): Remove.
3638 (config_h): Remove S_FILE.
3639
c90acc54
JB
36402012-08-01 Juanma Barranquero <lekktu@gmail.com>
3641
3642 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
3643 Remove; moved to nt/config.nt.
3644
d8a05828
DA
36452012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
3646
3647 Use INTERNAL_FIELD for conses and overlays.
3648 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
3649 Remove obsolete comment.
3650 (MVAR): New macro.
3651 (struct Lisp_Overlay): Use INTERNAL_FIELD.
3652 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
3653
8271d590
DA
36542012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
3655
3656 Use INTERNAL_FIELD for symbols.
3657 * lisp.h (SVAR): New macro. Adjust users.
3658 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
3659 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
3660
3193acd2
DA
36612012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
3662
3663 Use INTERNAL_FIELD for processes.
3664 * process.h (PVAR): New macro. Adjust style.
3665 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
3666 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
3667
3a45383a
DA
36682012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
3669
3670 Use INTERNAL_FIELD for windows.
3671 * window.h (WVAR): New macro.
3672 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
3673 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
3674 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
3675 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
3676 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
3677 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
3678
c1dbc63c
PE
36792012-08-01 Paul Eggert <eggert@cs.ucla.edu>
3680
3681 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
3682
5c0c0e8a
GM
36832012-08-01 Glenn Morris <rgm@gnu.org>
3684
3685 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
3686 Move to configure.ac.
3687
552a99b4
JB
36882012-08-01 Juanma Barranquero <lekktu@gmail.com>
3689
3690 * makefile.w32-in (CONFIG_H): Update dependencies.
3691 (CONF_POST_H): New macro.
3692
3693 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
3694
8d8e2dfe
GM
36952012-07-31 Glenn Morris <rgm@gnu.org>
3696
bc96620a
GM
3697 * Makefile.in (S_FILE): No longer set by configure.
3698
476b1b2d
GM
3699 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
3700 is available.
3701 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
3702
b2c7a106
GM
3703 * process.h (NULL_DEVICE):
3704 * emacs.c (SEPCHAR):
3705 * editfns.c (USER_FULL_NAME): Let configure set them.
3706
d53d062a
GM
3707 * s/README, s/template.h: Remove files.
3708
4515017f
GM
3709 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
3710
8d8e2dfe
GM
3711 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
3712 Move to configure.ac.
3713
5b20b3cc
EZ
37142012-07-31 Eli Zaretskii <eliz@gnu.org>
3715
1e0afd9a
EZ
3716 * .gdbinit (xframe): Adapt to introduction of FVAR and the
3717 resulting renaming of 'struct frame' members.
3718
5b20b3cc
EZ
3719 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
3720
3721 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
3722 after introduction of FVAR.
3723
f1310128
JD
37242012-07-31 Jan Djärv <jan.h.d@swipnet.se>
3725
79e721e0
JD
3726 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
3727
3728 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
3729 instead of compositeToPoint.
3730 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
3731
8d7c7eed 3732 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 3733
e34f7f79
DA
37342012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
3735
3736 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
3737 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 3738 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
3739 (BVAR): Change to use INTERNAL_FIELD.
3740 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
3741 (KVAR): Change to use INTERNAL_FIELD.
3742 * frame.h (FVAR): New macro.
3743 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
3744 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
3745 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
3746 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
3747 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
3748
c09bfb2f
DA
37492012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
3750
3751 Miscellaneous fixes for non-default X toolkits.
3752 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
3753 * xterm.c (x_frame_of_widget): Remove redundant prototype.
3754 Move under #ifdef USE_LUCID.
3755 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
3756 definition and usage to avoid warnings.
3757
14c114ae
JD
37582012-07-31 Jan Djärv <jan.h.d@swipnet.se>
3759
3760 * nsterm.m (openFiles): Fix previous checkin.
3761
3bd21e82
PE
37622012-07-31 Paul Eggert <eggert@cs.ucla.edu>
3763
3764 * indent.c (compute_motion): Remove unused local.
3765
c1529ded
GM
37662012-07-31 Glenn Morris <rgm@gnu.org>
3767
400d5621
GM
3768 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
3769
268e2432
GM
3770 * conf_post.h [USG5_4]:
3771 Move remaining contents of s/usg5-4-common.h here.
3772 * s/usg5-4-common.h: Remove file.
3773
7552f3ee
GM
3774 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
3775 * s/irix6-5.h: Remove file.
3776
6a381852
GM
3777 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
3778 * s/darwin.h: Remove file.
3779
c1529ded
GM
3780 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
3781 * s/hpux10-20.h: Remove file, which is now empty.
3782
b429a4ee
GM
37832012-07-30 Glenn Morris <rgm@gnu.org>
3784
3785 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
3786 * Makefile.in (config_h): Add conf_post.h.
3787 * makefile.w32-in (CONFIG_H): Add conf_post.h.
3788
adff3182
JD
37892012-07-30 Jan Djärv <jan.h.d@swipnet.se>
3790
3791 * nsterm.m (ns_do_open_file): New variable.
b9031d69 3792 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
3793 (openFile, openTempFile, openFileWithoutUI, openFiles):
3794 Open files only if ns_do_open_file.
adff3182 3795
c32af1e4
PE
37962012-07-30 Paul Eggert <eggert@cs.ucla.edu>
3797
7393bcbb
PE
3798 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
3799 This no-op macro hasn't been needed for many years.
3800 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
3801
c32af1e4
PE
3802 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
3803 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
3804 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
3805 gdb_make_enums_visible.
3806 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
3807 (DIRECTORY_SEP): Now a constant, not a macro.
3808
302fc036
EZ
38092012-07-30 Eli Zaretskii <eliz@gnu.org>
3810
3811 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
3812 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
3813
3814 * w32term.c <w32_keyboard_codepage>: Renamed from
3815 keyboard_codepage and now external. All users changed.
3816
3817 * w32term.h: Add declaration of w32_keyboard_codepage.
3818
3819 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
3820 the codepage to translate keys to Unicode. If this argument is
3821 -1, use the value returned by GetConsoleCP. All callers changed.
3822
88fb40b4
PE
38232012-07-30 Paul Eggert <eggert@cs.ucla.edu>
3824
0aee6912
PE
3825 Update .PHONY listings in makefiles.
3826 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
3827 bootstrap-clean, distclean, maintainer-clean, versioclean,
3828 extraclean, frc.
3829
88fb40b4
PE
3830 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
3831 This is a bit clearer. Fix some commentary typos.
3832
0a763bd1
GM
38332012-07-30 Glenn Morris <rgm@gnu.org>
3834
32bac6d6
GM
3835 * s/netbsd.h: Let configure include signal.h if needed.
3836 Remove file, which is now empty.
3837
b65e7c46
GM
3838 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
3839 Let configure set them.
3840 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
3841 No more need to undefine.
0a763bd1 3842
169304bd
AS
38432012-07-30 Andreas Schwab <schwab@linux-m68k.org>
3844
3845 * keymap.c (Fkey_description): Don't remove 0x80 bit from
3846 non-single-byte char when adding meta modifier. (Bug#12090)
3847
6cd7a139
DA
38482012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
3849
3850 Convert safe_call to use variable number of arguments.
3851 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
3852 (safe_call2): Fix comment.
3853 * lisp.h (safe_call): Adjust prototype.
3854 * coding.c (encode_coding_object): Change to use safe_call2.
3855 * xfaces.c (merge_face_heights): Change to use safe_call1.
3856
d34d6ffc
GM
38572012-07-30 Glenn Morris <rgm@gnu.org>
3858
7b8a48e4 3859 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 3860 does that unconditionally. Remove file, which is now empty.
7b8a48e4 3861
d34d6ffc
GM
3862 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
3863 Remove empty files.
3864
03a660a6
PE
38652012-07-30 Paul Eggert <eggert@cs.ucla.edu>
3866
3867 Export to GDB most of lisp.h's remaining object-like macros.
3868 * lisp.h (min, max): Move earlier, because they're used earlier now.
3869 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
3870 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
3871 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
3872 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
3873 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
3874 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
3875 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
3876 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
3877 Now constants, for GDB. They need not be macros.
3878 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
3879 Now constants, for GDB, as well as macros, for static initializers.
3880 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
3881 Move to after the definition of struct Lisp_Char_Table,
3882 since the former now needs that type defined.
3883 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
3884 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
3885 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
3886 New enums, for gdb_make_enums_visible.
3887 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 3888 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
3889 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
3890 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
3891 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
3892 enum maxargs, enum MAX_ALLOCA.
3893 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
3894 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
3895 no longer needed, now that they are done in lisp.h.
3896
e499d0ee
DA
38972012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
3898
3899 Cleanup string bytes checking.
3900 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
3901 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
3902 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
3903 (check_sblock, compact_small_strings): Simplify.
3904
d5040d2d
PE
39052012-07-29 Paul Eggert <eggert@cs.ucla.edu>
3906
3907 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
3908 These macros are confusing and no longer need to be defined, as
3909 the enum values now suffice. All uses replaced with definiens.
3910 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
3911
7f259ae6
JB
39122012-07-29 Juanma Barranquero <lekktu@gmail.com>
3913
3914 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
3915 ($(BLD)/w32console.$(O)): Update dependencies.
3916
7e63e0c3
DA
39172012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
3918
3919 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
3920 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
3921 time. Adjust users.
3922 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
3923
ffd817eb
JD
39242012-07-29 Jan Djärv <jan.h.d@swipnet.se>
3925
3926 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
3927 setting sitelisp (Bug#12010).
3928
417a7a0e
EZ
39292012-07-29 Eli Zaretskii <eliz@gnu.org>
3930
14ae4239 3931 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
3932
3933 * w32heap.c (cache_system_info):
3934 * w32.c (sys_rename):
3935 * w32proc.c (find_child_console, sys_kill): All users changed.
3936
387d4d92
PE
39372012-07-29 Paul Eggert <eggert@cs.ucla.edu>
3938
3939 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
3940
55a6cca6
EZ
39412012-07-29 Eli Zaretskii <eliz@gnu.org>
3942
3943 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
3944
dbcf001c
DA
39452012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
3946
3947 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
3948 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
3949 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 3950
e2688e4a
DA
39512012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
3952
3953 Generalize marker debugging code under MARKER_DEBUG and use eassert.
3954 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
3955 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
3956 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
3957 (replace_range, replace_range_2, del_range_2): Change to eassert.
3958 * marker.c (byte_char_debug_check): Adjust style.
3959
b46a6a83
PE
39602012-07-29 Paul Eggert <eggert@cs.ucla.edu>
3961
3962 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
3963 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
3964 long-ago-commented-out code that talks about "WIN32".
3965 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
3966 All uses changed.
3967
e32a5799
PE
39682012-07-28 Paul Eggert <eggert@cs.ucla.edu>
3969
3970 Use Gnulib stdalign module (Bug#9772, Bug#9960).
3971 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
3972 Simplify by using alignof.
3973 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
3974 * lisp.h: Include <stdalign.h>.
3975 (GCALIGNMENT): New macro and constant.
3976 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
3977 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
3978 (stdalign): New macro, if not already defined.
3979
df81cd29
EZ
39802012-07-28 Eli Zaretskii <eliz@gnu.org>
3981
01bd1b0d
EZ
3982 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
3983 * w32inevt.c: Include w32inevt.h.
3984 (w32_read_console_input): New inline function, calls either
3985 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
3986 w32_console_unicode_input.
3987 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
3988 (w32_kbd_patch_key, key_event): Use the codepage returned by
3989 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
3990 (key_event): use uChar.UnicodeChar only if
3991 w32_console_unicode_input is non-zero.
3992
3993 * w32console.c: Include w32heap.h.
3994 <w32_console_unicode_input>: New global variable.
3995 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
3996 family of Windows, zero otherwise.
3997
3998 * w32inevt.h: Declare w32_console_unicode_input.
3999
df81cd29
EZ
4000 * xdisp.c (init_iterator): Don't reference tip_frame in a build
4001 --without-x. (Bug#11742)
4002
c20fdd9e
PE
40032012-07-27 Paul Eggert <eggert@cs.ucla.edu>
4004
4005 Adjust GDB to reflect pvec_type changes (Bug#12036).
4006 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
4007 2012-07-04 changes to pseudovector representation.
4008 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 4009
32770973 40102012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
4011
4012 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
4013 bus address.
4014 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
4015
3438fe21
EZ
40162012-07-27 Eli Zaretskii <eliz@gnu.org>
4017
bcfbc9de
EZ
4018 * alloc.c (listn): Fix the order the arguments are consed onto the
4019 list.
4020
3438fe21
EZ
4021 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
4022 enumeration constants, as PURE and HEAP are too general, and clash
4023 with other headers and sources, such as gmalloc.c and the
4024 MS-Windows system headers. All users changed.
4025
eeaea515
DA
40262012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
4027
4028 Revert last save_excursion_save and save_excursion_restore changes.
4029 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
4030 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
4031
073c88c2
DA
40322012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
4033
4034 Fix recently-introduced typos in Windows port.
4035 Reported by Martin Rudalics <rudalics@gmx.at>.
4036 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 4037 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 4038
4706125e
PE
40392012-07-27 Paul Eggert <eggert@cs.ucla.edu>
4040
4041 Improve GDB symbol export (Bug#12036).
4042 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
4043 arms of an 'if', not using conditional expressions; otherwise GDB
4044 complains about the types in the unevaluated arm when the argument
4045 is an integer literal.
4046 (xgetint): Simplify expression.
4047 * alloc.c (gdb_make_enums_visible): New constant. This ports to
4048 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
4049 Zaretskii in <http://bugs.gnu.org/12036#13>.
4050 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
4051 needed now that we have gdb_make_enums_visible.
4052 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
4053 (enum enum_USE_LSB_TAG):
4054 New enum types, packaging up enums that need to be exported to GDB.
4055
694b6c97
DA
40562012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
4057
4058 Utility function to make a list from specified amount of objects.
4059 * lisp.h (enum constype): New datatype.
4060 (listn): New prototype.
4061 * alloc.c (listn): New function.
4062 (Fmemory_use_count, syms_of_alloc): Use it.
4063 * buffer.c (syms_of_buffer): Likewise.
4064 * callint.c (syms_of_callint): Likewise.
4065 * charset.c (define_charset_internal): Likewise.
4066 * coding.c (syms_of_coding): Likewise.
4067 * keymap.c (syms_of_keymap): Likewise.
4068 * search.c (syms_of_search): Likewise.
4069 * syntax.c (syms_of_syntax): Likewise.
4070 * w32.c (init_environment): Likewise.
4071 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
4072 * xdisp.c (syms_of_xdisp): Likewise.
4073 * xfns.c (syms_of_xfns): Likewise.
4074
6195f384
DA
40752012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
4076
4077 Fast save_excursion_save and save_excursion_restore.
4078 * lisp.h (struct Lisp_Excursion): New data type.
4079 (PVEC_EXCURSION): New pseudovector type.
4080 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
4081 to deal with it. Adjust comments.
4082 (init_marker, attach_marker): New prototype.
4083 (unchain_marker): Adjust prototype.
4084 * marker.c (attach_marker): Change to global.
4085 (init_marker): New function.
4086 * alloc.c (Fmake_marker, build_marker): Use it.
4087 (build_marker): More easserts.
4088 (mark_object): Handle struct Lisp_Excursion.
4089 * editfns.c (save_excursion_save, save_excursion_restore):
4090 Reimplement to use struct Lisp_Excursion. Add comments.
4091
5eceb8fb
PE
40922012-07-26 Paul Eggert <eggert@cs.ucla.edu>
4093
4094 Fix export of symbols to GDB (Bug#12036).
4095 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
4096 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
4097 emacs.c, as this is a more-suitable home. Had this been done earlier
4098 the fix for 12036 would have avoided some of the problems noted in
4099 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
4100 would have been more obvious.
562157c8
PE
4101 * emacs.c: Do not include <verify.h>; no longer needed.
4102 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
4103 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
4104 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
4105 Remove; now done in lisp.h.
4106 * lisp.h (PUBLISH_TO_GDB): New macro.
4107 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
4108 (DATA_SEG_BITS): Use it.
4109 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
4110 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
4111 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
4112 not be usable in #if. This simplifies things.
4113
d6749401
JB
41142012-07-26 Juanma Barranquero <lekktu@gmail.com>
4115
4116 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
4117
1781b9e9
PE
41182012-07-26 Paul Eggert <eggert@cs.ucla.edu>
4119
d89518db 4120 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
4121 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
4122 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
4123 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
4124 Adjust to changes in lisp.h and emacs.c, by using
4125 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
4126 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
4127 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
4128 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
4129 instead of gdb_valbits.
4130 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
4131 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
4132 instead of gdb_array_mark_flag.
4133 (xboolvector): Get size from $->size, not $->header.size.
4134 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
4135 (xreload, hook-run, hookpost-run): Remove.
4136 * emacs.c: Include <verify.h>.
4137 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
4138 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
4139 Remove.
4140 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
4141 (gdb_USE_LSB_TAG): New enum constants.
4142 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
4143 Also define these as enum constants, so they're visible to GDB.
4144 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
4145 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
4146 as constants, so they're visible to GDB.
4147 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
4148 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
4149 Now enum constants, not macros, so they're visible to GDB.
4150 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
4151 more convenient now. All uses changed.
4152 (VALMASK) [USE_LSB_TAG]: Also define in this case.
4153 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
4154
3628596a
DA
41552012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
4156
4157 Explicitly free restriction data that are not needed anymore.
4158 * editfns.c (save_restriction_restore): Free restriction data.
4159
7abaf5cc
SM
41602012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
4161
4162 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
4163 add argument, tune behavior, and adjust all callers.
4164
71f88e00
PE
41652012-07-25 Paul Eggert <eggert@cs.ucla.edu>
4166
4167 Use typedef for EMACS_INT, EMACS_UINT.
4168 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
4169 than macros. This simplifies debugging in the usual case, since
4170 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
4171 and it allows expressions involving EMACS_INT casts.
4172 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
4173
57ec3034
JD
41742012-07-25 Jan Djärv <jan.h.d@swipnet.se>
4175
4176 * nsterm.m (ns_read_socket): Return early if there is a modal
4177 window (Bug#12043).
4178
8137e7b3
MR
41792012-07-25 Martin Rudalics <rudalics@gmx.at>
4180
4181 * frame.c (Fredirect_frame_focus): In doc-string don't mention
4182 that FOCUS-FRAME can be omitted.
4183
04e9897c
DA
41842012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
4185
4186 Adjust buffer text indirection counters at the end of Fkill_buffer.
4187 * buffer.c (Fkill_buffer): Adjust indirection counters when the
4188 buffer is definitely dead. This should really fix an issue reported
4189 by Christoph Scholtes again. (Bug#12007).
4190 (init_buffer_once): Initialize indirection counters of
4191 buffer_defaults and buffer_local_symbols (for sanity and safety).
4192
8a0484e1
EZ
41932012-07-24 Eli Zaretskii <eliz@gnu.org>
4194
4195 * xdisp.c (init_iterator): Don't compute dimensions of truncation
4196 and continuation glyphs on tooltip frames, leave them at zero.
4197 Avoids continued lines in tooltips. (Bug#11832)
4198
fa691a83
DA
41992012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
4200
4201 Simplify copy_overlay.
04e9897c 4202 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
4203 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
4204
436bc8e0
EZ
42052012-07-23 Eli Zaretskii <eliz@gnu.org>
4206
4207 * print.c (print_object): Don't crash when a frame's name is nil
4208 or invalid. (Bug#12025)
4209
4210 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
4211 it signals an error when a tooltip frame is being created.
4212
d7a7fda3
DA
42132012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
4214
4215 Cleanup miscellaneous objects allocation and initialization.
4216 * alloc.c (allocate_misc): Change to static. Add argument to
4217 specify the subtype. Adjust comment and users.
4218 (build_overlay): New function.
4219 * buffer.c (copy_overlays, Fmake_overlay): Use it.
4220 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
4221 (allocate_misc): Remove prototype.
4222 (build_overlay): Add prototype.
4223
42242012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
4225
4226 Swap buffer text indirection counters in Fbuffer_swap_text.
4227 * buffer.c (Fbuffer_swap_text): Swap indirections too.
4228 This avoids crash reported by Christoph Scholtes at
4229 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
4230
9d7fa573
JD
42312012-07-22 Jan Djärv <jan.h.d@swipnet.se>
4232
4233 * nsmenu.m (Popdown_data): New struct.
4234 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
4235 free Popdown_data.
4236 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
4237 (initWithContentRect): Make imgView and contentView non-static
4238 and autorelease them. Also autorelease img and matrix (Bug#12005).
4239 (dealloc): Remove (Bug#12005).
4240
0dd6d66d
DA
42412012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
4242
4243 Adjust consing_since_gc when objects are explicitly freed.
4244 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
4245 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
4246 (free_cons, free_misc): Subtract object size from consing_since_gc.
4247
d36d71df
DA
42482012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
4249
4250 Simplify and cleanup markers positioning code.
4251 * marker.c (attach_marker): More useful eassert.
4252 (live_buffer, set_marker_internal): New function.
4253 (Fset_marker, set_marker_restricted): Use set_marker_internal.
4254 (set_marker_both, set_marker_restricted_both): Use live_buffer.
4255
fb9ea40f
PE
42562012-07-22 Paul Eggert <eggert@cs.ucla.edu>
4257
4258 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
4259 as it's limited by the amount of memory, not by INT_MAX.
4260
2d5c5f7d
EZ
42612012-07-21 Eli Zaretskii <eliz@gnu.org>
4262
07fb592e
EZ
4263 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
4264 in special-event-map. See the discussion at
4265 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
4266 for the reasons.
4267
37a9eac8 4268 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
4269 info.dwItemData. Fixes crashes on 64-bit Windows.
4270 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 4271
c4328746
JD
42722012-07-21 Jan Djärv <jan.h.d@swipnet.se>
4273
fc0c31f8 4274 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 4275 (conversationIdentifier): Return value is NSInteger.
784051c4 4276 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 4277
6e5d1c12
CY
42782012-07-21 Chong Yidong <cyd@gnu.org>
4279
4280 * window.c (decode_any_window): Signal an error if the window is
4281 on a dead frame (Bug#11984).
4282
9928463d
DA
42832012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
4284
4285 Add indirection counting to speed up Fkill_buffer.
4286 * buffer.h (struct buffer): New member.
4287 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
4288 (Fmake_indirect_buffer): Set indirection counter to -1, increment
4289 base buffer indirection counter.
4290 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
4291 (Fkill_buffer): Adjust indirection counters as needed, don't walk
4292 through buffer list if indirection counter is 0.
4293
f8643a6b
DA
42942012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
4295
4296 Extend the value returned by Fgarbage_collect with heap statistics.
4297 * alloc.c (Qheap): New symbol.
4298 (syms_of_alloc): DEFSYM it.
4299 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
4300 (Fmemory_free): Remove.
4301 (syms_of_alloc): Don't defsubr it.
4302 * buffer.c (Fcompact_buffer): Remove.
4303 (syms_of_buffer): Don't defsubr it.
4304
dac616ff
DA
43052012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
4306
4307 Make maybe_gc inline.
4308 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
4309 * lisp.h (consing_since_gc, gc_relative_threshold)
4310 (memory_full_cons_threshold): Revert declaration.
4311 (maybe_gc): Remove prototype, define as inline.
4312 * alloc.c: Remove old commented-out code.
4313 (consing_since_gc, gc_relative_threshold)
4314 (memory_full_cons_threshold): Revert to global.
4315 (maybe_gc): Remove.
4316
d7ea76b4
DA
43172012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
4318
4319 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
4320 * lisp.h (build_unibyte_string): New function.
4321 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
4322 * sysdep.c, w32fns.c, xfns.c: Use it.
4323 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
4324 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
4325 Adjust users accordingly.
4326 * font.h (font_open_by_name): Adjust prototype.
4327
765e61e3
DA
43282012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
4329
4330 Cleanup calls to Fgarbage_collect.
4331 * lisp.h (maybe_gc): New prototype.
4332 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
4333 Remove declarations.
4334 * alloc.c (maybe_gc): New function.
4335 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
4336 Make them static.
4337 * bytecode.c (MAYBE_GC): Use maybe_gc.
4338 * eval.c (eval_sub, Ffuncall): Likewise.
4339 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
4340 to avoid dependency from auto-save feature.
4341
52b852c7
PE
43422012-07-19 Paul Eggert <eggert@cs.ucla.edu>
4343
4344 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
4345 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
4346 'for_each_per_buffer_object_at'.
4347 All uses changed. It's better to use upper-case for macros that
4348 cannot be implemented as functions, to give the reader a clue
4349 that they're special.
4350
5db81e33
SM
43512012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
4352
4353 * alloc.c (Fgarbage_collect): Tweak docstring.
4354
5b835e1d
DA
43552012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
4356
4357 Tweak the value returned from Fgarbage_collect again.
4358 * alloc.c (Fgarbage_collect): New return value, as confirmed in
4359 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
4360 Adjust documentation.
4361 (total_vector_bytes): Rename to total_vector_slots, adjust
4362 accounting.
4363 (total_free_vector_bytes): Rename to total_free_vector_slots,
4364 adjust accounting.
4365 (Qstring_bytes, Qvector_slots): New symbols.
4366 (syms_of_alloc): DEFSYM them.
4367
9cd47b72
DA
43682012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
4369
4370 Buffer compaction primitive which may be used from Lisp.
4371 * buffer.c (compact_buffer, Fcompact_buffer): New function.
4372 (syms_of_buffer): Register Fcompact_buffer.
4373 * alloc.c (Fgarbage_collect): Use compact_buffer.
4374 * buffer.h (compact_buffer): New prototype.
4375 (struct buffer_text): New member.
4376
d17337e5
DA
43772012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
4378
4379 New macro to iterate over all buffers, miscellaneous cleanups.
4380 * lisp.h (all_buffers): Remove declaration.
4381 * buffer.h (all_buffers): Add declaration, with comment.
4382 (for_each_buffer): New macro.
4383 * alloc.c (Fgarbage_collect, mark_object): Use it.
4384 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
4385 (init_buffer): Likewise.
4386 * data.c (Fset_default): Likewise.
4387 * coding.c (code_conversion_restore): Remove redundant check
4388 for dead buffer.
4389 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
4390
60cfd278
AS
43912012-07-18 Andreas Schwab <schwab@linux-m68k.org>
4392
4393 Fix bug that created negative-length intervals.
4394 * intervals.c (merge_interval_right, merge_interval_left):
4395 Do not zero out this interval if it is absorbed by its children,
4396 as this interval's total length doesn't change in that case. See
4397 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
4398
d06714cb
PE
43992012-07-18 Paul Eggert <eggert@cs.ucla.edu>
4400
83713154
PE
4401 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
4402 when invoking (make-bool-vector N t) and N is a positive
4403 multiple of 8 -- the last 8 bits were mistakenly cleared.
4404
d06714cb
PE
4405 Remove some struct layout assumptions in bool vectors.
4406 * alloc.c (bool_header_size): New constant.
4407 (header_size, word_size): Move earlier, as they're now used earlier.
4408 Use 'word_size' in a few more places, where it's appropriate.
4409 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
4410 padding before the data member of a bool vector.
4411 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
4412 than doing the check by hand with an abort ().
4413
464d5a5e
SM
44142012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4415
5fbc0409
SM
4416 * eval.c (Fdefvar): Don't check constants since we only set the var if
4417 it's not yet defined anyway (bug#11904).
4418
464d5a5e
SM
4419 * lisp.h (last_undo_boundary): Declare new var.
4420 * keyboard.c (command_loop_1): Set it.
4421 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
4422 were auto-added by the command loop (bug#11774).
4423
8dc2e44a
AS
44242012-07-18 Andreas Schwab <schwab@linux-m68k.org>
4425
4426 * w32font.c (Qsymbol): Remove local definition.
4427 (syms_of_w32font): Don't DEFSYM it.
4428
169925ec
DA
44292012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
4430
4431 Fix sweep_vectors to handle large bool vectors correctly.
4432 * alloc.c (sweep_vectors): Account total_vector_bytes for
4433 bool vectors larger than VBLOCK_BYTES_MAX.
4434
5fbfb018
CY
44352012-07-18 Chong Yidong <cyd@gnu.org>
4436
4437 * frame.c (x_set_frame_parameters): Revert bogus change introduced
4438 in 2012-05-25 commit by Paul Eggert (Bug#11738).
4439
3ab6e069
DA
44402012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
4441
4442 Return more descriptive data from Fgarbage_collect.
4443 Suggested by Stefan Monnier in
4444 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
4445 * alloc.c (bounded_number): New function.
4446 (total_buffers, total_vectors): New variable.
4447 (total_string_size): Rename to total_string_bytes, adjust users.
4448 (total_vector_size): Rename to total_vector_bytes, adjust users.
4449 (sweep_vectors): Account total_vectors and total_vector_bytes.
4450 (Fgarbage_collect): New return value. Adjust documentation.
4451 (gc_sweep): Account total_buffers.
4452 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
4453 (VECTOR_SIZE): Remove.
4454 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
4455 (Qinterval, Qmisc): New symbols.
4456 (syms_of_data): Initialize them.
4457 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
4458 (Qcons, Qbuffer): New declarations.
4459
6d02fe5b
PE
44602012-07-17 Paul Eggert <eggert@cs.ucla.edu>
4461
4462 * alloc.c (Fmemory_free): Account for memory-free's own storage.
4463 Round up, not down. Improve doc.
4464
b7ffe040
DA
44652012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
4466
4467 Restore old code in allocate_string_data to avoid Faset breakage.
4468 Reported by Julien Danjou <julien@danjou.info> in
4469 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
4470 * alloc.c (allocate_string_data): Restore old code with minor
4471 adjustments, fix comment to explain this subtle issue.
4472
4dc7c8d5
SM
44732012-07-17 Eli Zaretskii <eliz@gnu.org>
4474
4475 Remove FILE_SYSTEM_CASE.
4476 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
4477
4478 * fileio.c (FILE_SYSTEM_CASE): Don't define.
4479 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
4480 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
4481 call-process-region passes it through expand-file-name.
4482
4483 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
4484
44852012-07-17 Andreas Schwab <schwab@linux-m68k.org>
4486
4487 Fix crash when creating indirect buffer (Bug#11917)
4488 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
4489 Don't handle unbound variables specially if non-zero.
4490 (Fbuffer_local_variables): Pass zero.
4491 (clone_per_buffer_values): Pass non-zero.
4492
44932012-07-17 Andreas Schwab <schwab@linux-m68k.org>
4494
4495 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
4496 to make the loop interruptible.
4497
44982012-07-17 Andreas Schwab <schwab@linux-m68k.org>
4499
4500 * gnutls.c (emacs_gnutls_handshake): Only retry if
4501 GNUTLS_E_INTERRUPTED.
4502
cce7fefc
DA
45032012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
4504
4505 Cleanup and convert miscellaneous checks to eassert.
4506 * alloc.c (mark_interval): Fix comment, partially rephrase
4507 old comment from intervals.h (see below).
4508 * intervals.c (find_interval, adjust_intervals_for_insertion)
4509 (delete_interval, adjust_intervals_for_deletion)
4510 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
4511 Convert to eassert.
4512 (adjust_intervals_for_insertion, make_new_interval):
4513 Remove obsolete and unused code.
4514 * intervals.h (struct interval): Remove obsolete comment.
4515 * textprotp.c (erase_properties): Remove unused code.
4516 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
4517 (Fremove_list_of_text_properties): Convert to eassert.
4518
9ea10cc3
CY
45192012-07-17 Chong Yidong <cyd@gnu.org>
4520
4521 * editfns.c (Finsert_char): Doc fix.
4522
3900d5de
DA
45232012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
4524
4525 Fix previous change to make Fmemory_free always accurate.
4526 * alloc.c (make_interval): Update total_free_intervals.
4527 (make_float): Likewise for total_free_floats.
4528 (free_cons, Fcons): Likewise for total_free_conses.
4529 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
4530 Likewise for total_free_vector_bytes.
4531 (Fmake_symbol): Likewise for total_free_symbols.
4532 (bytes_free): Remove.
4533
7098646f
DA
45342012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
4535
4536 Simple free memory accounting feature.
4537 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
4538 (sweep_vectors): Accumulate size of free vectors.
4539 (Fgarbage_collect): Setup bytes_free.
4540 (Fmemory_free): New function.
4541 (syms_of_alloc): Register it.
4542
22657b40
DA
45432012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
4544
4545 Cleanup overlays checking.
4546 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
4547 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
4548 eassert and OVERLAYP.
4549 (sort_overlays): Change to use OVERLAYP.
4550
ddfc8813
RK
45512012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
4552
4553 * editfns.c (Finsert_char): Make it interactive, and make the
4554 second arg optional. Copy interactive spec and docstring from
4555 ucs-insert.
4556
7c26cf3c
PE
45572012-07-17 Paul Eggert <eggert@cs.ucla.edu>
4558
4559 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
4560 Unlike the other wrapped functions, fabs has an unspecified
4561 effect on errno.
4562
5d127af9
JD
45632012-07-16 Jan Djärv <jan.h.d@swipnet.se>
4564
4565 * nsterm.m (keyDown): Interpret flags without left/right bits
4566 as the left key (Bug#11670).
4567
6a0dd1d7
DA
45682012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
4569
4570 Remove empty and useless init functions.
4571 * lisp.h (init_character_once, init_fns, init_image)
4572 (init_filelock, init_sound): Remove prototype.
4573 * character.c (init_character_once): Remove.
4574 * filelock.c (init_filelock): Likewise.
4575 * fns.c (init_fns): Likewise.
4576 * image.c (init_image): Likewise.
4577 * sound.c (init_sound): Likewise.
4578 * emacs.c (main): Adjust accordingly.
4579
7a6136fd
DA
45802012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
4581
4582 * gtkutil.h: Tiny cleanups.
4583 (use_old_gtk_file_dialog): Remove useless declaration.
4584 (xg_uses_old_file_dialog): Add suggested const attribute.
4585
ce811ad9
EZ
45862012-07-15 Eli Zaretskii <eliz@gnu.org>
4587
4588 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
4589 (bidi_paragraph_init): Use it to limit search forward for a strong
4590 directional character in abnormally large paragraphs full of
4591 neutral or weak characters. (Bug#11943)
4592
c9adfeaa
SF
45932012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
4594
4595 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
4596 the toolbar (Bug#9451).
4597 (xg_make_tool_item): Give the widget event box a transparent
4598 background.
4599
fff62aa9
DA
46002012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
4601
4602 Cleanup basic allocation variables and functions.
4603 * alloc.c (ignore_warnings, init_intervals, init_float)
4604 (init_cons, init_symbol, init_marker): Remove.
4605 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
4606 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
4607 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
4608 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
4609 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
4610 (staticidx, init_alloc_once, init_strings, free_ablock):
4611 Remove redundant initialization.
4612 * fns.c (init_weak_hash_tables): Remove.
4613 * lisp.h (init_weak_hash_tables): Remove prototype.
4614
9730daca
DA
46152012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
4616
4617 Use zero_vector where appropriate.
4618 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
4619 accordingly.
4620 * lisp.h (zero_vector): New declaration.
4621 * font.c (null_vector): Remove.
4622 (syms_of_font): Remove initialization and staticpro.
4623 (font_list_entities, font_find_for_lface): Change to use zero_vector.
4624 * keymap.c (Faccessible_keymaps): Likewise.
4625
2e2d2a13
LL
46262012-07-15 Leo Liu <sdl.web@gmail.com>
4627
4628 * fringe.c: Fix typo in comments.
4629
cd276f6e
LL
46302012-07-14 Leo Liu <sdl.web@gmail.com>
4631
4632 * fringe.c: Add a new bitmap exclamation-mark.
4633
5a1131d9
EZ
46342012-07-14 Eli Zaretskii <eliz@gnu.org>
4635
4636 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
4637
4638 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
4639 (HAVE_MENUS): Don't define, defined by editing config.in with
4640 msdos/sed2v2.inp.
4641 (GMALLOC_INHIBIT_VALLOC): Don't define.
4642 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
4643
22e983b7
JB
46442012-07-14 Juanma Barranquero <lekktu@gmail.com>
4645
4646 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
4647
5b3f250f
GM
46482012-07-14 Glenn Morris <rgm@gnu.org>
4649
4650 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
4651 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
4652 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
4653
33d63ff4
GM
46542012-07-13 Glenn Morris <rgm@gnu.org>
4655
5b633342
GM
4656 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
4657
33d63ff4
GM
4658 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
4659 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
4660
b55b9f85
JD
46612012-07-13 Jan Djärv <jan.h.d@swipnet.se>
4662
0dc8cf50
JD
4663 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
4664 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
4665 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
4666 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
4667 where appropriate.
4668 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
4669 as boolean expression.
4670 (x_set_window_size): Remove unused variable toolbar.
4671 (ns_get_color_default, ns_mod_to_lisp): Remove.
4672 (ns_mouse_position): Remove unused variables xchar and ychar.
4673 (ns_compute_glyph_string_overhangs): Remove unused variable face.
4674 (ns_set_vertical_scroll_bar): Remove unused variable count.
4675 (ns_delete_terminal): Remove unused variable i.
4676 (ns_term_init): Remove unused variables r, g and b.
4677 (mouseDown): Remove unused variable window.
4678 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
4679 (initFrameFromEmacs): Remove unused variable vbextra.
4680 (mouseEntered): Remove unused variables p and dpyinfo.
4681 (mouseExited): Remove unused variables p and r.
4682 (ns_define_frame_cursor, ns_clear_frame_area)
4683 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
4684 (menuDown): Assign [sender tag] to variable and cast the variable.
4685
4686 * nsterm.h (menuDown): Add id as type to argument sender.
4687 (ns_display_info_for_name): Add Lisp_Object argument.
4688 (ns_term_init): Add Lisp_Object argument.
4689 (ns_map_event_to_object): Add void argument.
4690 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
4691 prototype with arguments and only declare if __OBJC__.
4692 (nxatoms_of_nsselect): Add void argument.
4693 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
4694 (ns_alloc_autorelease_pool): Add void argument.
4695 (ns_release_autorelease_pool): Add void* argument.
4696 (ns_get_defaults_value): Add const char* argument.
4697
4698 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
4699 (initFromContents): Use SSDATA where appropriate.
4700 (ns_update_menubar): Add braces to ambigous if-else.
4701 (initWithTitle): Put () around assignment in if statement.
4702 (ns_menu_show): Remove unused variables window and keymap.
4703 (update_frame_tool_bar): Remove unused variable selected_p.
4704 (initWithContentRect): Remove unused variable this_cmd_name.
4705
4706 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
4707 appropriate.
4708 (setXBMColor): Remove unused variable len.
4709 (setPixmapData): Put () around assignment in loop statement.
4710
4711 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
4712 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
4713 where appropriate.
4714 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
4715 around assignment in loop statement.
4716 (nsfont_open): Remove unused variable i.
4717 (nsfont_open): Remove unused variable len.
4718 (nsfont_draw): Remove unused variable cs.
4719
4720 * nsfns.m (x_set_icon_name, ns_set_name_internal)
4721 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
4722 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
4723 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
4724 (Fns_font_name, Fns_perform_service)
4725 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
4726 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
4727 (ns_set_name): Remove unused variable view.
4728 (x_set_menu_bar_lines): Remove unused variable olines.
4729 (x_set_tool_bar_lines): Remove unused variable root_window.
4730 (Fns_list_colors): Put () around assignment in while statement.
4731 (Fns_perform_service): Remove unused variable len.
4732 (Fns_display_usable_bounds): Remove unused variable top.
4733 (syms_of_nsfns): Remove unused variable i.
4734
b55b9f85
JD
4735 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
4736 memcpy (Bug#11907).
4737
ed9265fc 47382012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
4739
4740 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
4741 and free it with DestroyExceptionInfo (Bug#11558).
4742
ef099b57
JB
47432012-07-13 Juanma Barranquero <lekktu@gmail.com>
4744
4745 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
4746 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
4747 Set here, not in nt/config.nt.
4748
ea814a5d
EZ
47492012-07-13 Eli Zaretskii <eliz@gnu.org>
4750
4751 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
4752 cursor overflow into the last glyph on display line when the right
4753 fringe is off. (Bug#11832)
4754
1a952767
PE
47552012-07-13 Paul Eggert <eggert@cs.ucla.edu>
4756
4757 * xdisp.c (produce_special_glyphs): Now static.
4758 * dispextern.h (produce_special_glyphs): Remove decl.
4759
983188fd
GM
47602012-07-13 Glenn Morris <rgm@gnu.org>
4761
8d7c7eed 4762 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
4763 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
4764
983188fd
GM
4765 * s/usg5-4-common.h (USG, USG5):
4766 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
4767 * s/sol2-6.h (SOLARIS2):
4768 * s/irix6-5.h (IRIX6_5):
4769 * s/hpux10-20.h (USG, USG5, HPUX):
4770 * s/gnu-linux.h (USG, GNU_LINUX):
4771 * s/freebsd.h (BSD_SYSTEM):
4772 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
4773 * s/cygwin.h (CYGWIN):
4774 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
4775 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
4776
d1e68667 47772012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
4778
4779 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 4780
6de0e799
GM
47812012-07-13 Glenn Morris <rgm@gnu.org>
4782
739ae010
GM
4783 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
4784
dbee5793
GM
4785 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
4786
6de0e799
GM
4787 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
4788 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
4789
b82da769
GM
47902012-07-12 Glenn Morris <rgm@gnu.org>
4791
4fae5a7a 4792 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
4793
4794 * process.c (init_process_emacs): Rename from init_process.
4795 The old name is also the name of a Mach system call.
4796 * lisp.h, emacs.c: Update for this name change.
4797 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
4798 longer needed.
4799
5a979817
EZ
48002012-07-12 Eli Zaretskii <eliz@gnu.org>
4801
4802 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
4803 memmove call that removes glyphs covered by the left truncation
4804 glyph. Improve commentary.
4805 (display_line): Fix display of continuation glyphs on GUI frames
4806 when the right fringe is turned off and variable-size fonts are
4807 used in the window. Move the code that appends a stretch glyph to
4808 produce_special_glyphs, so that it could be used for truncation
4809 and continuation glyphs alike.
4810 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
4811 glyph of a suitably computed width, to align the special glyphs at
4812 the window margin. Code moved from display_line. (Bug#11832)
4813
3e91a053
GM
48142012-07-12 Glenn Morris <rgm@gnu.org>
4815
ba9e4b84
GM
4816 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
4817
4818 * s/gnu-linux.h, s/hpux10-20.h:
4819 Do not unconditionally define HAVE_XRMSETDATABASE.
4820
3e91a053
GM
4821 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
4822
b300b1f4
PE
48232012-07-12 Paul Eggert <eggert@cs.ucla.edu>
4824
4825 Fix typos that broke OS X build.
4826 Reported by Randal L. Schwartz in
4827 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
4828 * nsterm.m (ns_timeout): Add missing local decl.
4829 (ns_get_color): snprintf -> sprintf, to fix typo.
4830
6e777848
GM
48312012-07-12 Glenn Morris <rgm@gnu.org>
4832
3f922c37
GM
4833 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
4834 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
4835 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
4836 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
4837
0ab7b23a
GM
4838 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
4839 Move PTY_OPEN to configure.
4840
6e777848
GM
4841 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
4842 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
4843 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
4844
4a7edc24
DA
48452012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
4846
4847 Use empty_unibyte_string where applicable.
4848 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
4849 * lread.c (read1): Likewise.
4850 * xsettings.c (syms_of_xsettings): Likewise.
4851
308aab79
GM
48522012-07-12 Glenn Morris <rgm@gnu.org>
4853
42bd1719
GM
4854 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
4855 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
4856 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
4857 * s/hpux10-20.h (RUN_TIME_REMAP):
4858 * s/bsd-common.h (TABDLY): Move to configure.
4859
4860 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
4861
4862 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
4863
ea0bbd17 4864 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 4865 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
4866
4867 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 4868
308aab79
GM
4869 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
4870 * s/template.h: Move NARROWPROTO to configure.
4871
ee1cf5cf
GM
48722012-07-11 Glenn Morris <rgm@gnu.org>
4873
30fe9bf4
GM
4874 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
4875 unused since 2011-01-17 change to systty.h.
4876
ee1cf5cf
GM
4877 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
4878 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
4879 Move HAVE_PTYS and HAVE_SOCKETS to configure.
4880
63e47e07
PE
48812012-07-11 Paul Eggert <eggert@cs.ucla.edu>
4882
4883 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
4884
c43fb4c3
GM
48852012-07-11 Glenn Morris <rgm@gnu.org>
4886
4887 * s/darwin.h, s/gnu-linux.h, s/template.h:
4888 Move INTERRUPT_INPUT to configure.
4889
e8df9267
DA
48902012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
4891
4892 Minor adjustments to interning code.
4893 * lisp.h (intern, intern_c_string): Redefine as static inline
4894 wrappers for intern_1 and intern_c_string_1, respectively.
4895 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
4896 * lread.c (intern_1, intern_c_string_1, oblookup):
4897 Simplify Vobarray checking.
e8df9267
DA
4898 * font.c (font_intern_prop): Likewise. Adjust comment.
4899 * w32font.c (intern_font_name): Likewise.
4900
34348bd4
AS
49012012-07-11 Andreas Schwab <schwab@linux-m68k.org>
4902
d96a1e0c
AS
4903 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
4904
34348bd4
AS
4905 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
4906 of Fcar/Fcdr if possible.
4907 * font.c (check_otf_features): Likewise.
4908 * fontset.c (Fnew_fontset): Likewise.
4909 * gnutls.c (Fgnutls_boot): Likewise.
4910 * minibuf.c (read_minibuf): Likewise.
4911 * msdos.c (IT_set_frame_parameters): Likewise.
4912 * xmenu.c (Fx_popup_dialog): Likewise.
4913 * w32menu.c (Fx_popup_dialog): Likewise.
4914
c8add24e
GM
49152012-07-11 Glenn Morris <rgm@gnu.org>
4916
4b575b3c
GM
4917 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
4918 since nothing has defined it on these platforms.
4919
09f4e3b0
GM
4920 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
4921 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
4922
172bedef
GM
4923 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
4924 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
4925 Move CLASH_DETECTION to configure.
4926
249685df
GM
4927 * s/gnu.h: Remove file, which is now empty.
4928
c8add24e
GM
4929 * s/gnu.h, s/gnu-linux.h:
4930 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
4931
b41253a3
JW
49322012-07-11 John Wiegley <johnw@newartisans.com>
4933
4934 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
4935 function attribute, so we only use it if it exists in the
4936 compiler.
4937
d923b542
DA
49382012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
4939
4940 Avoid call to strlen in fast_c_string_match_ignore_case.
4941 * search.c (fast_c_string_match_ignore_case): Change to use
4942 length argument. Adjust users accordingly.
4943 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
4944
5ebbef1d
PE
49452012-07-11 Paul Eggert <eggert@cs.ucla.edu>
4946
bb352260
PE
4947 Assume mkdir, rmdir.
4948 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
4949 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
4950
57054ddd
PE
4951 Assume rename.
4952 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
4953
b747d3f7
PE
4954 Assume perror.
4955 * s/hpux10-20.h (HAVE_PERROR): Remove.
4956 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
4957 Remove dummy definition, as this problem was obsolete long ago.
4958
5ebbef1d
PE
4959 Assume strerror.
4960 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
4961
984e7f30
DA
49622012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
4963
4964 Avoid calls to strlen in font processing functions.
4965 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
4966 (font_open_by_name): Change to use length argument.
4967 Adjust users accordingly.
d923b542
DA
4968 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
4969 Adjust prototypes.
4970 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
4971 Change to return ptrdiff_t.
984e7f30
DA
4972 (xfont_list_pattern, xfont_match): Use length returned by
4973 xfont_decode_coding_xlfd.
4974 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
4975
20e94fdd
GM
49762012-07-11 Glenn Morris <rgm@gnu.org>
4977
9d596af3
GM
4978 * s/darwin.h, s/freebsd.h, s/netbsd.h:
4979 Move DONT_REOPEN_PTY to configure.
4980
20e94fdd
GM
4981 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
4982 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
4983
e99a530f
PE
49842012-07-10 Paul Eggert <eggert@cs.ucla.edu>
4985
22ffb973
PE
4986 Remove "#define unix" that is no longer needed (Bug#11905).
4987 * s/aix4-2.h (unix): Remove; no longer needed.
4988
e9a9ae03
PE
4989 EMACS_TIME simplification (Bug#11875).
4990 This replaces macros (which typically do not work in GDB)
4991 with functions, typedefs and enums, making the code easier to debug.
4992 The functional style also makes code easier to read and maintain.
4993 * systime.h: Include <sys/time.h> on all hosts, not just if
4994 WINDOWSNT, since 'struct timeval' is needed in general.
4995 (EMACS_TIME): Now a typedef, not a macro.
4996 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
4997 not macros.
4998 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
4999 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
5000 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
5001 (EMACS_TIME_LE): Now functions, not macros.
5002 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
5003 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
5004 which are not functions. All uses rewritten to use:
5005 (make_emacs_time): New function.
5006 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
5007 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
5008 not functions. All uses rewritten to use the following, respectively:
5009 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
5010 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 5011 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
5012 * fileio.c (Fcopy_file):
5013 * xterm.c (XTflash): Get the current time closer to when it's used.
5014 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
5015
ffacb126
PE
5016 * bytecode.c (targets): Suppress -Woverride-init warnings.
5017
e99a530f
PE
5018 Simplify by avoiding confusing use of strncpy etc.
5019 * doc.c (Fsnarf_documentation):
5020 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
5021 * frame.c (Fmake_terminal_frame):
5022 * gtkutil.c (get_utf8_string):
5023 * lread.c (openp):
5024 * nsmenu.m (ns_update_menubar):
5025 * regex.c (regerror):
5026 Prefer memcpy to strncpy and strncat when either will do.
5027 * fileio.c (Fsubstitute_in_file_name):
5028 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
5029 (menu_separator_name_p):
5030 * nsmenu.m (ns_update_menubar):
5031 Prefer memcmp to strncmp when either will do.
5032 * nsterm.m: Include <ftoastr.h>.
5033 (ns_get_color):
5034 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
5035 Prefer snprintf to strncpy.
5036 * nsterm.m (ns_term_init):
5037 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
5038 * nsterm.m (ns_term_init):
5039 Avoid the need for strncpy, by using build_string or
5040 make_unibyte_string directly. Use dtoastr, not snprintf.
5041 * process.c (Fmake_network_process): Diagnose service names that
5042 are too long, rather than silently truncating them or creating
5043 non-null-terminated names.
5044 (Fnetwork_interface_info): Likewise, for interface names.
5045 * sysdep.c (system_process_attributes) [GNU_LINUX]:
5046 Prefer sprintf to strncat.
5047 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
5048 Prefer vsnprintf to vsprintf + strncpy.
5049
c59592b3
GM
50502012-07-10 Glenn Morris <rgm@gnu.org>
5051
5052 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
5053 Clarify fallback case.
5054
7d7bbefd
DA
50552012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
5056
5057 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
5058 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
5059 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 5060 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
5061 where argument type is known to be a Lisp_Cons.
5062
3a4c8000
TT
50632012-07-10 Tom Tromey <tromey@redhat.com>
5064
5065 * bytecode.c (BYTE_CODE_THREADED): New macro.
5066 (BYTE_CODES): New macro. Replaces all old byte-code defines.
5067 (enum byte_code_op): New type.
5068 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
5069 (exec_byte_code): Use them. Use token threading when applicable.
5070
2a0213a6
DA
50712012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
5072
5073 Optimize pure C strings initialization.
5074 * lisp.h (make_pure_string): Fix prototype.
5075 (build_pure_c_string): New function, defined as static inline. This
5076 provides a better opportunity to optimize away calls to strlen when
5077 the function is called with compile-time constant argument.
5078 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
5079 argument, adjust users accordingly. Use build_pure_c_string where
5080 appropriate.
5081 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
5082 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
5083 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
5084
cb1caeaf
DA
50852012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
5086
5087 Avoid calls to strlen in miscellaneous functions.
5088 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
5089 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
5090 * lread.c (openp): Likewise.
5091
c293e30c
DA
50922012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
5093
5094 Avoid calls to strlen in path processing functions.
5095 * fileio.c (file_name_as_directory): Add comment. Change to add
5096 srclen argument and return the length of result. Adjust users
5097 accordingly.
5098 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
5099 swap 1st and 2nd arguments to obey the common convention.
5100 Adjust users accordingly.
c293e30c
DA
5101 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
5102
9e059e3f
GM
51032012-07-10 Glenn Morris <rgm@gnu.org>
5104
d02eb359
GM
5105 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
5106 Move PENDING_OUTPUT_COUNT definition to configure.
5107
882cf227
GM
5108 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
5109 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
5110 * s/gnu.h (DATA_START): Move definitions to configure.
5111
af6e839f
GM
5112 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
5113 We include usg5-4-common.h, which defines them both.
5114
40289a12
GM
5115 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
5116 O_RDONLY already includes it).
5117
9e059e3f
GM
5118 Stop ns builds setting the EMACSLOADPATH environment variable.
5119 * nsterm.m (ns_load_path): Rename from ns_init_paths.
5120 Now it does not set EMACSLOADPATH, just returns the load-path string.
5121 * nsterm.h: Update accordingly.
5122 * lread.c [HAVE_NS]: Include nsterm.h.
5123 (init_lread) [HAVE_NS]: Use ns_load_path.
5124 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
5125
7c4e8ec0
GM
51262012-07-09 Glenn Morris <rgm@gnu.org>
5127
d4f600ff
GM
5128 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
5129 since the included bsd-common.h does so.
5130
cbb31951
GM
5131 Stop ns builds setting the EMACSPATH environment variable.
5132 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
5133 (ns_init_paths): Do not set EMACSPATH.
5134 * nsterm.h (ns_exec_path): Add it.
5135 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
5136 Use ns_exec_path.
5137
7c4e8ec0
GM
5138 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
5139
26bccfae
PE
51402012-07-09 Paul Eggert <eggert@cs.ucla.edu>
5141
a0bee46f
PE
5142 * process.c (wait_reading_process_output): 'waitchannels' was unset
5143 when read_kbd || !NILP (wait_for_cell); fix this.
5144
5994c183
PE
5145 Add GCC-style 'const' attribute to functions that can use it.
5146 * character.h (char_resolve_modifier_mask):
5147 * keyboard.h (make_ctrl_char):
5148 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
5149 (init_character_once, next_almost_prime, init_fns, init_image)
5150 (flush_pending_output, init_sound):
5151 * mem-limits.h (start_of_data):
5152 * menu.h (finish_menu_items):
5153 Add ATTRIBUTE_CONST.
5154 * emacs.c (DEFINE_DUMMY_FUNCTION):
5155 Declare the dummy function with ATTRIBUTE_CONST.
5156 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
5157 Add decls with ATTRIBUTE_CONST.
5158
26bccfae
PE
5159 Minor improvements to make_formatted_string.
5160 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
5161 where int is good enough, as vsprintf returns an int.
5162 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
5163
a8290ec3
DA
51642012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
5165
5166 Use make_formatted_string to avoid double length calculation.
5167 * lisp.h (make_formatted_string): New prototype.
5168 * alloc.c (make_formatted_string): New function.
5169 * buffer.c (Fgenerate_new_buffer_name): Use it.
5170 * dbus.c (syms_of_dbusbind): Likewise.
5171 * editfns.c (Fcurrent_time_zone): Likewise.
5172 * filelock.c (get_boot_time): Likewise.
5173 * frame.c (make_terminal_frame, set_term_frame_name)
5174 (x_report_frame_params): Likewise.
5175 * image.c (gs_load): Likewise.
5176 * minibuf.c (get_minibuffer): Likewise.
5177 * msdos.c (dos_set_window_size): Likewise.
5178 * process.c (make_process): Likewise.
5179 * xdisp.c (ensure_echo_area_buffers): Likewise.
5180 * xsettings.c (apply_xft_settings): Likewise.
5181
d01ba2f1
GM
51822012-07-09 Glenn Morris <rgm@gnu.org>
5183
5184 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
5185 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
5186 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
5187 * nsterm.h (ns_etc_directory): Add it.
5188 * callproc.c [HAVE_NS]: Include nsterm.h.
5189 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
5190
f1f924b6
DA
51912012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
5192
5193 Move marker debugging code under MARKER_DEBUG.
5194 * marker.c (MARKER_DEBUG): Move marker debugging code under
5195 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
5196 for bootstrap with --enable-checking (~3x slowdown reported
5197 by Juanma Barranquero <lekktu@gmail.com>).
5198 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
5199
ab531b66
PE
52002012-07-08 Paul Eggert <eggert@cs.ucla.edu>
5201
5202 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
5203 See <http://bugs.gnu.org/11825#29>.
5204
c4b3bc8a
EZ
52052012-07-08 Eli Zaretskii <eliz@gnu.org>
5206
5207 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
5208 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
5209 (display_line): Add commentary about displaying truncation glyphs
5210 on GUI frames.
5211 (produce_special_glyphs): Move here from term.c.
5212
5213 * term.c (produce_special_glyphs): Move to xdisp.c.
5214
5215 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
5216 section.
c4b3bc8a 5217
b676b881
AS
52182012-07-07 Andreas Schwab <schwab@linux-m68k.org>
5219
f17c5273
AS
5220 * xdisp.c (display_line): Avoid warning about implicit declaration
5221 of FRAME_FONT.
5222
298819b9
AS
5223 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
5224
b676b881
AS
5225 * lisp.h: Remove empty conditional.
5226
6045c4fd
PE
52272012-07-07 Paul Eggert <eggert@cs.ucla.edu>
5228
b3350bf9
PE
5229 * lread.c (load_path_check): Now static.
5230
6045c4fd
PE
5231 Fix some minor --with-ns problems found by static checking.
5232 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
5233 (x_set_font) [!HAVE_X_WINDOWS]:
5234 * image.c (xpm_load_image) [HAVE_NS]:
5235 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
5236 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
5237 Remove unused local.
5238 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
5239 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
5240 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
5241 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
5242 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
5243 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
5244 Fix pointer signedness problem.
5245 * xfaces.c (FRAME_X_FONT_TABLE):
5246 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
5247
929e7845
GM
52482012-07-07 Glenn Morris <rgm@gnu.org>
5249
5250 * lread.c (load_path_check): New function, split from init_lread.
5251 (init_lread): Reorganize. Motivation:
5252 If EMACSLOADPATH is set, check/warn about that rather than the
5253 defaults, which we are not going to use. Hence we can remove
5254 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
5255 Don't warn if site-lisp directories are missing.
5256 If not installed, start from a blank load-path, since
5257 PATH_LOADSEARCH refers to the eventual installation directories.
5258
58dd0aa4
EZ
52592012-07-07 Eli Zaretskii <eliz@gnu.org>
5260
5261 Support truncation and continuation glyphs on GUI frames, when
5262 fringes are disabled. (Bug#11832)
5263 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
5264 continuation glyphs even if on GUI frames.
5265 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
5266 or both, are absent.
5267 (start_display, move_it_in_display_line_to): Handle the case of a
5268 GUI frame without a fringe to display continuation or truncation
5269 glyphs.
5270 (insert_left_trunc_glyphs): Support GUI frames: make sure
5271 truncation glyphs overwrite enough glyphs from the current line to
5272 have sufficient space in pixels.
5273 (display_line): Support truncation and continuation glyphs on GUI
5274 frames. If some spare pixels are left on the line after inserting
5275 the truncation glyphs, fill that space with a stretch glyph of a
5276 suitably computed width.
5277
5278 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
5279 produce_glyphs, to support GUI sessions.
5280
31571fd7
PE
52812012-07-07 Paul Eggert <eggert@cs.ucla.edu>
5282
5a16b9bc
PE
5283 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
5284
f3047c75
PE
5285 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
5286
31571fd7
PE
5287 Do not require float-time's arg to fit in time_t (Bug#11825).
5288 This works better on hosts where time_t is unsigned, and where
5289 float-time is applied to the (negative) difference between two times.
5290 * editfns.c (decode_time_components): Last arg is now double *,
5291 not int *, and means to store all the result as a double, without
5292 worrying about whether the seconds part fits in time_t.
5293 All callers changed.
5294 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
5295 All callers changed.
5296 (Ffloat_time): Do not fail merely because the specified time falls
5297 outside of time_t range.
5298
4516fbef
GM
52992012-07-07 Glenn Morris <rgm@gnu.org>
5300
5301 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
5302 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
5303 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
5304
07adc2c6
JB
53052012-07-07 Juanma Barranquero <lekktu@gmail.com>
5306
5307 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
5308 Update dependencies.
5309
5310 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
5311
fd573f31
PE
53122012-07-06 Paul Eggert <eggert@cs.ucla.edu>
5313
fee5959d
PE
5314 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
5315 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
5316 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
5317 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
5318 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
5319 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
5320
fd573f31
PE
5321 * xfont.c (compare_font_names): Redo to omit the need for casts.
5322
ddadbc0e
AS
53232012-07-06 Andreas Schwab <schwab@linux-m68k.org>
5324
fca8d6b6
AS
5325 * xfns.c (Fx_change_window_property): Doc fix.
5326 * w32fns.c (Fx_change_window_property): Doc fix.
5327
ddadbc0e
AS
5328 * w32fns.c (Fx_window_property): Accept the same arguments as the
5329 X Windows version. Doc fix.
5330 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
5331
ed9265fc 53322012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
5333 Eli Zaretskii <eliz@gnu.org>
5334
5335 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
5336 Windows-specific code from nt/config.nt moved here.
5337 Obsolete settings removed.
5338
216ee680
PE
53392012-07-06 Paul Eggert <eggert@cs.ucla.edu>
5340
5341 * process.c: Avoid unnecessary calls to gettime.
5342 (wait_reading_process_output): Don't get the time of day
5343 when gobbling data immediately and not waiting, as there's no need
5344 for it in that case. This removes a FIXME.
5345
bdd091e4
JD
53462012-07-06 Jan Djärv <jan.h.d@swipnet.se>
5347
5348 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
5349 is defined (Bug#11768).
5350
9d44f8ce
DA
53512012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5352
5353 Fix marker debugging code.
5354 * marker.c (byte_char_debug_check): Do not perform the check
5355 if buffer is not multibyte.
090bd7cb
JB
5356 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
5357 Call byte_char_debug_check with correct arguments.
9d44f8ce 5358
90fc4786
DA
53592012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5360
5361 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
5362 * marker.c (byte_char_debug_check, count_markers):
5363 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
5364 (byte_debug_flag): Remove.
5365 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
5366 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
5367
7b7ae965
DA
53682012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5369
4e57b342
DA
5370 Avoid code repetition in marker-related functions.
5371 * marker.c (attach_marker): New function.
5372 (Fset_marker, set_marker_restricted, set_marker_both)
5373 (set_marker_restricted_both): Use it.
5374 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
5375 Consistently rename charno to charpos.
5376 (marker_position): Add eassert.
5377 (marker_byte_position): Convert to eassert.
5378
53792012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5380
5381 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 5382 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 5383 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 5384
657924ff
DA
53852012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5386
5387 Introduce fast path for the widely used marker operation.
5388 * alloc.c (build_marker): New function.
5389 * lisp.h (build_marker): New prototype.
5390 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
5391 * composite.c (autocmp_chars): Likewise.
5392 * editfns.c (buildmark): Remove.
5393 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
5394 (save_restriction_save): Use build_marker.
5395 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
5396 * window.c (save_window_save): Likewise.
5397
041a49a6
DA
53982012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5399
5400 Do not use Fdelete_overlay in delete_all_overlays
5401 to avoid redundant calls to unchain_overlay.
5402 * buffer.c (drop_overlay): New function.
5403 (delete_all_overlays, Fdelete_overlay): Use it.
5404 * minibuf.c (get_minibuffer): Fix comment.
5405
7dca65a4
PE
54062012-07-06 Paul Eggert <eggert@cs.ucla.edu>
5407
5408 Port to OpenBSD 5.1 amd64.
5409 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
5410 This is needed for OpenBSD, and should be harmless on all BSD systems.
5411 Also, include <sys/sysctl.h>, as it should be available on all
5412 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
5413 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
5414 use p_pid member, not kp_proc.pid.
5415
8eb876e2
GM
54162012-07-06 Glenn Morris <rgm@gnu.org>
5417
5418 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
5419
38182d90
PE
54202012-07-05 Paul Eggert <eggert@cs.ucla.edu>
5421
5422 More xmalloc and related cleanup.
5423 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
5424 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
5425 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
5426 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
5427 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
5428 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
5429 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
5430 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
5431 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
5432 * xterm.c:
5433 Omit needless casts involving void * pointers and allocation.
5434 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
5435 as the former is more robust if P's type is changed.
5436 Prefer xzalloc to xmalloc + memset 0.
5437 Simplify malloc-or-realloc to realloc.
5438 Don't worry about xmalloc returning a null pointer.
5439 Prefer xstrdup to xmalloc + strcpy.
5440 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
5441 growing it.
5442 * keyboard.c (apply_modifiers_uncached): Prefer local array to
5443 alloca of a constant.
5444
6dd5a677
EZ
54452012-07-05 Eli Zaretskii <eliz@gnu.org>
5446
5447 * xdisp.c (display_line): Fix horizontal pixel coordinates when
5448 hscroll is larger than the line width. Fixes long and futile
5449 looping inside extend_face_to_end_of_line (on a TTY) producing
5450 glyphs that are not needed and thrown away.
5451
6b312f0f
DA
54522012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
5453
5454 * marker.c (set_marker_restricted_both): Simplify by using
5455 clip_to_bounds.
5456
f520ef9b
PE
54572012-07-05 Paul Eggert <eggert@cs.ucla.edu>
5458
5459 * editfns.c (region_limit): Simplify by using clip_to_bounds.
5460
383b7c95
JD
54612012-07-05 Jan Djärv <jan.h.d@swipnet.se>
5462
5463 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
5464 not defined (Bug#11768).
5465 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
5466 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
5467 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
5468 followed by gtk_box_set_homogeneous (Bug#11768).
5469 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
5470 (update_theme_scrollbar_width, xg_create_scroll_bar):
5471 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
5472 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
5473 (is_box_type): New function (Bug#11768).
5474 (xg_tool_item_stale_p): Call is_box_type.
5293d758 5475 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
5476 with default display (Bug#11768).
5477
d6e7bf45
EZ
54782012-07-05 Eli Zaretskii <eliz@gnu.org>
5479
5480 * xdisp.c (window_hscroll_limited): New function.
5481 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
5482 coordinates when window's hscroll is set to insanely large
5483 values. (Bug#11857)
5484
431391ec
JB
54852012-07-05 Juanma Barranquero <lekktu@gmail.com>
5486
5487 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
5488 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
5489
23f86fce
DA
54902012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
5491
5492 Cleanup xmalloc.
5493 * lisp.h (xzalloc): New prototype. Omit needless casts.
5494 * alloc.c (xzalloc): New function. Omit needless casts.
5495 * charset.c: Omit needless casts. Convert all calls to
5496 xmalloc with following memset to xzalloc.
5497 * dispnew.c: Likewise.
5498 * fringe.c: Likewise.
5499 * image.c: Likewise.
5500 * sound.c: Likewise.
5501 * term.c: Likewise.
5502 * w32fns.c: Likewise.
5503 * w32font.c: Likewise.
5504 * w32term.c: Likewise.
5505 * xfaces.c: Likewise.
5506 * xfns.c: Likewise.
5507 * xterm.c: Likewise.
5508 * atimer.c: Omit needless casts.
5509 * buffer.c: Likewise.
5510 * callproc.c: Likewise.
5511 * ccl.c: Likewise.
5512 * coding.c: Likewise.
5513 * composite.c: Likewise.
5514 * doc.c: Likewise.
5515 * doprnt.c: Likewise.
5516 * editfns.c: Likewise.
5517 * emacs.c: Likewise.
5518 * eval.c: Likewise.
5519 * filelock.c: Likewise.
5520 * fns.c: Likewise.
5521 * gtkutil.c: Likewise.
5522 * keyboard.c: Likewise.
5523 * lisp.h: Likewise.
5524 * lread.c: Likewise.
5525 * minibuf.c: Likewise.
5526 * msdos.c: Likewise.
5527 * print.c: Likewise.
5528 * process.c: Likewise.
5529 * region-cache.c: Likewise.
5530 * search.c: Likewise.
5531 * sysdep.c: Likewise.
5532 * termcap.c: Likewise.
5533 * terminal.c: Likewise.
5534 * tparam.c: Likewise.
5535 * w16select.c: Likewise.
5536 * w32.c: Likewise.
5537 * w32reg.c: Likewise.
5538 * w32select.c: Likewise.
5539 * w32uniscribe.c: Likewise.
5540 * widget.c: Likewise.
5541 * xdisp.c: Likewise.
5542 * xmenu.c: Likewise.
5543 * xrdb.c: Likewise.
5544 * xselect.c: Likewise.
5545
0497dc44
PE
55462012-07-05 Paul Eggert <eggert@cs.ucla.edu>
5547
5548 * fileio.c (time_error_value): Check the right error number.
5549 Problem reported by Troels Nielsen in
5550 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
5551
356e7178
PE
55522012-07-04 Paul Eggert <eggert@cs.ucla.edu>
5553
4e71fd89
PE
5554 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
5555 This should be fixed in a better way; see Eli Zaretskii in
5556 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
5557 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
5558
f0941253
PE
5559 * fileio.c (time_error_value): Rename from special_mtime.
5560 The old name's problems were noted by Eli Zaretskii in
5561 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
5562
065c9eb4
PE
5563 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
5564 This variable's comment says Emacs needs at least one GDB-visible
5565 symbol of type enum pvec_type, to work around GDB problems.
5566 The symbol's value doesn't matter.
5567
356e7178
PE
5568 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
5569 that causes compilation to fail on pre-C99 compilers.
5570
ed9265fc 55712012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
5572
5573 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
5574 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
5575
3884d954
DA
55762012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
5577
d209e2fb 5578 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
5579 headers for buffer_defaults and buffer_local_symbols.
5580 Reported by Juanma Barranquero <lekktu@gmail.com>.
5581
ee28be33
SM
55822012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
5583
5584 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
5585 * lisp.h (enum pvec_type): Use fewer bits.
5586 (PSEUDOVECTOR_SIZE_BITS): New constant.
5587 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
5588 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
5589 change in pvec_type.
5590 (PSEUDOVECTOR_TYPEP): New macro.
5591 (TYPED_PSEUDOVECTORP): Use it.
5592 * fns.c (internal_equal): Adapt code to extract pvectype.
5593 * emacs.c (gdb_pvec_type): Update type.
5594 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
5595 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
5596 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
5597 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
5598 (sweep_vectors): Use it. Use local var `total_bytes' instead of
5599 abusing vector->header.next.nbytes.
5600 (live_vector_p): Use PVEC_TYPE.
5601 (mark_object): Adapt code to extract pvectype. Use switch.
5602
c7f2cd7f
PE
56032012-07-04 Paul Eggert <eggert@cs.ucla.edu>
5604
5605 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
5606 Tighten new eassert a bit.
5607
8ce70ed2
DA
56082012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
5609
5610 Fix compilation with --enable-gcc-warnings and -O1
5611 optimization level.
5612 * doprnt.c (doprnt): Change type of tem to int, initialize
5613 to avoid compiler warning. Add eassert.
5614 * search.c (simple_search): Initialize match_byte to avoid
5615 compiler warning. Add eassert.
5616
dea7f1e5
PE
56172012-07-04 Paul Eggert <eggert@cs.ucla.edu>
5618
24a212eb
PE
5619 Avoid weird behavior with large horizontal scrolls.
5620 Without this change, for example, large hscroll values would
5621 mess up Emacs's display on Fedora 15 x86, presumably due to
5622 overflows in int calculations in the display code.
5623 Also, if buffers had long lines, Emacs would freeze.
5624 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
5625 (set_window_hscroll): New function, containing the old guts of
5626 Fset_window_hscroll. Return the clipped value.
5627 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
5628 This avoids the need to check against PTRDIFF_MAX.
5629
dea7f1e5
PE
5630 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
5631
76046526
DA
56322012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
5633
5634 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
5635
39adff0d
PE
56362012-07-04 Paul Eggert <eggert@cs.ucla.edu>
5637
63807d47
PE
5638 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
5639 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
5640 since GCC 4.4.6 issues a bogus warning for them.
5641
39adff0d
PE
5642 Fix bugs in file timestamp newness comparisons.
5643 * fileio.c (Ffile_newer_than_file_p):
5644 * lread.c (Fload): Use full timestamp resolution of files,
5645 not just the 1-second resolution, so that files that are only
5646 slightly newer still count as newer.
5647 * fileio.c (Ffile_newer_than_file_p): Don't assume file
5648 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
5649
dbeed9a6
PE
56502012-07-03 Paul Eggert <eggert@cs.ucla.edu>
5651
5652 * fileio.c: Improve handling of file time marker. (Bug#11852)
5653 (special_mtime): New function.
5654 (Finsert_file_contents, Fverify_visited_file_modtime):
5655 Use it to set special mtime values consistently.
5656
636334d6
AS
56572012-07-03 Andreas Schwab <schwab@linux-m68k.org>
5658
5659 * fileio.c (Finsert_file_contents): Properly handle st_mtime
5660 marker for non-existing file. (Bug#11852)
5661
e2017fe2
GM
56622012-07-03 Glenn Morris <rgm@gnu.org>
5663
5664 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
5665 and did not make it into globals.h).
5666
404dbd37
TT
56672012-07-03 Tom Tromey <tromey@redhat.com>
5668
5669 * window.c (Fset_window_margins, Fset_window_fringes)
5670 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
5671 * textprop.c (Fprevious_property_change): No longer static.
5672 * syntax.c (Fsyntax_table_p): No longer static.
5673 * process.c (Fget_process, Fprocess_datagram_address): No longer
5674 static.
5675 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
5676 * keyboard.c (Fcommand_execute): No longer static.
5677 Remove EXFUN.
5678 * insdel.c (Fcombine_after_change_execute): No longer static.
5679 * image.c (Finit_image_library): No longer static.
5680 * fileio.c (Fmake_symbolic_link): No longer static.
5681 * eval.c (Ffetch_bytecode): No longer static.
5682 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
5683 * doc.c (Fdocumentation_property, Fsnarf_documentation):
5684 No longer static.
404dbd37
TT
5685 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
5686 static.
5687 * dired.c (Ffile_attributes): No longer static.
5688 * composite.c (Fcomposition_get_gstring): No longer static.
5689 * callproc.c (Fgetenv_internal): No longer static.
5690
5691 * ccl.h: Remove EXFUNs.
5692 * buffer.h: Remove EXFUNs.
5693 * dispextern.h: Remove EXFUNs.
5694 * intervals.h: Remove EXFUNs.
5695 * fontset.h: Remove EXFUN.
5696 * font.h: Remove EXFUNs.
5697 * dosfns.c (system_process_attributes): Remove EXFUN.
5698 * keymap.h: Remove EXFUNs.
5699 * lisp.h: Remove EXFUNs.
5700 * w32term.h: Remove EXFUNs.
5701 * window.h: Remove EXFUNs.
5702 * xsettings.h: Remove EXFUN.
5703 * xterm.h: Remove EXFUN.
5704
8e4fd1e1
GM
57052012-07-03 Glenn Morris <rgm@gnu.org>
5706
5707 * lisp.h (Frandom): Make it visible to C.
5708 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
5709 buffer for invisible buffers. (Bug#1229)
5710
ca95b3eb
DA
57112012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
5712
5713 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
5714 values which aren't power of 2.
14ae4239
BT
5715 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
5716 Verify it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
5717 accordingly.
5718
7555c33f
SM
57192012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
5720
5721 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
5722
5723 * alloc.c (mark_object): Revert part of last patch to use `switch'.
5724
d12e8f5a
DA
57252012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
5726
5727 * alloc.c (allocate_vector_block): Remove redundant
5728 calls to mallopt if DOUG_LEA_MALLOC is defined.
5729 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
5730 avoid calls to mallopt if zero_vector is returned.
5731
296094c3
DA
57322012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
5733
5734 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
5735 is enabled, avoid dereferencing NULL current_sblock if
5736 running undumped.
5737
36429c89
DA
57382012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
5739
5740 Cleanup basic buffer management.
5741 * buffer.h (struct buffer): Change layout to use generic vector
5742 marking code. Fix some comments. Change type of 'clip_changed'
5743 to bitfield. Remove unused #ifndef old.
5744 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
5745 (GET_OVERLAYS_AT): Fix indentation.
5746 (for_each_per_buffer_object_at): New macro.
5747 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
5748 (Fbuffer_local_variables): Use it.
5749 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
5750 * alloc.c (allocate_buffer): Adjust to match new layout of
5751 struct buffer. Fix comment.
5752 (mark_overlay): New function.
5753 (mark_buffer): Use it. Use mark_vectorlike to mark normal
5754 Lisp area of struct buffer.
5755 (mark_object): Use it. Adjust marking of misc objects
5756 and related comments.
5757
3b3e4cac
PE
57582012-07-02 Paul Eggert <eggert@cs.ucla.edu>
5759
5760 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
5761 wrapper that is not needed because the wrapped code is a no-op (zero
5762 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
5763 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
5764
cf5c0175
DA
57652012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
5766
5767 * alloc.c (mark_buffer): Simplify. Remove prototype.
5768 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 5769 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
5770 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
5771 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 5772
ca26824c
GM
57732012-06-30 Glenn Morris <rgm@gnu.org>
5774
2e4c5312
GM
5775 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
5776
ca26824c
GM
5777 * epaths.in (PATH_SITELOADSEARCH): New.
5778 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
5779 This is rather than relying on --enable-locallisppath elements
5780 having "site-lisp" in their names. (Bug#10208#25, 11658)
5781
0d23c240
EZ
57822012-06-30 Eli Zaretskii <eliz@gnu.org>
5783
c9240d7a
EZ
5784 * w32proc.c (sys_select): Accept and ignore one more argument.
5785
5786 * w32.c (emacs_gnutls_pull): Call select with one more argument.
5787
0d23c240 5788 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 5789 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
5790
5791 * sysdep.c: Don't include dos.h and dosfns.h.
5792
5793 * process.c (sys_select):
5794 * msdos.c (sys_select): Accept one more argument and ignore it.
5795
5796 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
5797 adapt data types and code to that.
5798
5799 * dosfns.c:
5800 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
5801 which clashes with the gnulib function of the same name.
5802
af5a5a98
AS
58032012-06-30 Andreas Schwab <schwab@linux-m68k.org>
5804
c5e4379c
AS
5805 * font.c (font_style_to_value, font_style_symbolic)
5806 (font_prop_validate_style): Add type checks for values in
5807 font_style_table.
5808
af5a5a98
AS
5809 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
5810 argument.
5811 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
5812 uses.
5813
8d38f461
EZ
58142012-06-29 Eli Zaretskii <eliz@gnu.org>
5815
2e5a6631
EZ
5816 * xdisp.c (try_window_id): Undo last change.
5817
8d38f461
EZ
5818 * w32.c (getwd): Adjust commentary about startup_dir.
5819 (init_environment): Always call sys_access, even in non-MSVC
5820 builds. Don't chdir to the directory of the Emacs executable.
5821 This undoes code from 1997 which was justified by the need to
5822 "avoid conflicts when removing and renaming directories". But its
5823 downside was that every relative file name was being interpreted
5824 relative to the directory of the Emacs executable, which can never
5825 be TRT. In particular, it broke sys_access when called with
5826 relative file names.
5827 (sys_access): Map GetLastError to errno.
5828
2af3565e
DA
58292012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
5830
5831 * window.h (struct window): Change type of 'fringes_outside_margins'
5832 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 5833 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
5834 Adjust comment.
5835 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
5836 to ptrdiff_t.
5837
c8d3a25c 58382012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 5839
c8d3a25c
GM
5840 * gnutls.c (emacs_gnutls_handshake):
5841 Add QUIT to make the loop interruptible.
57570cd3 5842
c8d3a25c 58432012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 5844
c8d3a25c
GM
5845 * charset.c (init_charset): Make lack of etc/charsets fatal.
5846
3e984ee8
DA
58472012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
5848
5849 * editfns.c (region_limit): Fix type mismatch.
5850
ef884f23
DA
58512012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
5852
5853 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
5854 undefined. Convert from xassert to eassert.
5855 * nsmenu.m: Convert from xassert to eassert.
5856 * nsterm.m: Likewise.
5857
7d7e0027
SM
58582012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
5859
5860 * editfns.c (region_limit): Clip to narrowing (bug#11770).
5861
aa754e6a
PE
58622012-06-28 Paul Eggert <eggert@cs.ucla.edu>
5863
5864 Avoid integer overflow on scroll-left and scroll-right.
5865 * window.c (HSCROLL_MAX): New macro.
5866 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
5867 overflow when requested scroll falls outside ptrdiff_t range.
5868
80b00b08
DA
58692012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
5870
5871 * window.h (struct window): Change type of 'hscroll',
5872 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
5873 'last_modified' and 'last_overlay_modified' to EMACS_INT.
5874 Adjust users accordingly.
5875 * xdisp.c (try_cursor_movement): Replace type check with eassert.
5876 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
5877 from EMACS_INT to ptrdiff_t.
5878 (make_window): Omit redundant initialization.
5879
62b2bcf6
JB
58802012-06-28 Juanma Barranquero <lekktu@gmail.com>
5881
5882 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
5883
45942c7d
DA
58842012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
5885
5886 * window.h (struct window): Change type of 'use_time' and
5887 'sequence_number' from Lisp_Object to int.
5888 * frame.c (make_frame): Adjust users accordingly.
5889 * print.c (print_object): Likewise.
5890 * window.c (select_window, Fwindow_use_time, make_parent_window)
5891 (make_window): Likewise.
5892
e509cfa6
DA
58932012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
5894
5895 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
5896 enabled with --enable-checking=[all,glyphs] configure option.
5897 Fix GLYPH_DEBUG usage assuming that it may be undefined,
5898 adjust comments accordingly.
5899 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
5900 undefined, adjust comments accordingly.
5901 * image.c: Likewise.
5902 * scroll.c: Likewise.
5903 * w32fns.c: Likewise.
5904 * w32term.c: Likewise.
5905 * xdisp.c: Likewise.
5906 * xfaces.c: Likewise.
5907 * xfns.c: Likewise.
5908 * xterm.c: Likewise.
5909
a54e2c05
DA
59102012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
5911
5912 Generalize run-time debugging checks.
5913 * dispextern.h (XASSERTS): Remove.
5914 * fontset.c (xassert): Remove.
5915 Convert from xassert to eassert.
5916 * alloc.c: Convert from xassert to eassert.
5917 * bidi.c: Likewise.
5918 * dispnew.c: Likewise.
5919 * fns.c: Likewise.
5920 * fringe.c: Likewise.
5921 * ftfont.c: Likewise.
5922 * gtkutil.c: Likewise.
5923 * image.c: Likewise.
5924 * keyboard.c: Likewise.
5925 * menu.c: Likewise.
5926 * process.c: Likewise.
5927 * scroll.c: Likewise.
5928 * sound.c: Likewise.
5929 * term.c: Likewise.
5930 * w32console.c: Likewise.
5931 * w32fns.c: Likewise.
5932 * w32term.c: Likewise.
5933 * window.c: Likewise.
5934 * xdisp.c: Likewise.
5935 * xfaces.c: Likewise.
5936 * xfns.c: Likewise.
5937 * xselect.c: Likewise.
5938 * xterm.c: Likewise.
5939
1ec4b7b2
SM
59402012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
5941
5942 * fns.c (maybe_resize_hash_table): Output message when growing the
5943 purify-hashtable.
5944
2014308a
DA
59452012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
5946
5947 * alloc.c (allocate_string_data): Remove dead code.
5948 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
5949 avoid GCC warning about unused macro.
5950
246155eb
DA
59512012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
5952
5953 * alloc.c (allocate_string): Omit intervals initialization.
5954 * alloc.c (make_uninit_multibyte_string): Initialize intervals
5955 as in make_pure_string and make_pure_c_string.
5956
43184b7b
DA
59572012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
5958
d209e2fb 5959 * alloc.c (allocate_string): Fix last change.
43184b7b 5960
3fe6dd74
DA
59612012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
5962
d209e2fb 5963 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
5964 to memset, add explicit initialization where appropriate.
5965
1ba6038a
GM
59662012-06-27 Glenn Morris <rgm@gnu.org>
5967
5968 * lisp.mk (lisp): Remove paths.elc.
5969
c89926a5
CY
59702012-06-27 Chong Yidong <cyd@gnu.org>
5971
5972 * doc.c (Fsubstitute_command_keys): Fix punctuation.
5973
ed6b3510
JW
59742012-06-26 John Wiegley <johnw@newartisans.com>
5975
1ec4b7b2 5976 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
5977 on Mac OS X Lion: __mod_init_func and __mod_term_func.
5978
ed6b3510
JW
5979 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
5980 when building with Clang.
5981
8edd4a2b
SM
59822012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
5983
5984 * eval.c (Fapply): Allow calling it with a single argument.
5985
f6f62d1b
EZ
59862012-06-26 Eli Zaretskii <eliz@gnu.org>
5987
5988 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
5989 _stricmp and _strnicmp.
5990 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
5991
62efea5e
DA
59922012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
5993
5994 * alloc.c (allocate_window): Zero out non-Lisp part of newly
5995 allocated window.
5996 (allocate_process): Likewise for new process.
8edd4a2b 5997 (allocate_terminal): Change to use offsetof.
62efea5e
DA
5998 (allocate_frame): Likewise.
5999 * frame.c (make_frame): Omit redundant initialization.
6000 * window.c (make_parent_window): Use memset.
6001 (make_window): Omit redundant initialization.
6002 * process.c (make_process): Omit redundant initialization.
6003 * terminal.c (create_terminal): Likewise.
6004
42997f4d
DA
60052012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
6006
6007 * term.c (delete_tty): Remove redundant call to memset.
6008
1130ecfc
DA
60092012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
6010
6011 * alloc.c: Remove build_string.
6012 * lisp.h: Define build_string as static inline. This provides
6013 a better opportunity to optimize away calls to strlen when the
6014 function is called with compile-time constant argument.
6015 * image.c (imagemagick_error): Convert to build_string.
6016 * w32proc.c (sys_spawnve): Likewise.
6017 * xterm.c (x_term_init): Likewise.
6018
cf38a720
PE
60192012-06-26 Paul Eggert <eggert@cs.ucla.edu>
6020
99027bdd
PE
6021 Use sprintf return value instead of invoking strlen on result.
6022 In the old days this wasn't portable, since some sprintf
6023 implementations returned char *. But they died out years ago and
6024 Emacs already assumes sprintf returns int.
6025 Similarly for float_to_string.
6026 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
6027 * ccl.c (ccl_driver):
6028 * character.c (string_escape_byte8):
6029 * data.c (Fnumber_to_string):
6030 * doprnt.c (doprnt):
6031 * print.c (print_object):
6032 * xdisp.c (message_dolog):
6033 * xfns.c (syms_of_xfns):
6034 Use sprintf or float_to_string result to avoid need to call strlen.
6035 * data.c (Fnumber_to_string):
6036 Use make_unibyte_string, since the string must be ASCII.
6037 * lisp.h, print.c (float_to_string): Now returns int length.
6038 * term.c (produce_glyphless_glyph):
6039 Use sprintf result rather than recomputing it.
6040
cf38a720
PE
6041 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
6042 * Makefile.in (ALL_CFLAGS):
6043 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
6044 * gmalloc.c, regex.c: Include <config.h> unconditionally.
6045
3511c784
DA
60462012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
6047
0a08eb21 6048 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
6049 strcasecmp if available.
6050 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
6051
fb7da12e
AS
60522012-06-25 Andreas Schwab <schwab@linux-m68k.org>
6053
6054 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
6055 Avoid comma operator.
6056 * menu.c (push_submenu_start, push_submenu_end)
6057 (push_left_right_boundary, push_menu_pane): Likewise.
6058 * msdos.c (dos_rawgetc): Likewise.
6059
afa2ffd8
DA
60602012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
6061
6062 * xfns.c (xic_create_fontsetname): Remove redundant calls
6063 to memset.
6064
b3b4476b
PE
60652012-06-25 Paul Eggert <eggert@cs.ucla.edu>
6066
4495ff38
PE
6067 * gtkutil.c (get_utf8_string): Remove redundant assignment.
6068 sprintf already null-terminates its output.
6069
b3b4476b
PE
6070 * xfns.c (x_window): Remove redundant cast.
6071
b00876c9
DA
60722012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
6073
6074 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
6075 `const char *' to `char *' to avoid compiler warning.
6076
d188e26b
PE
60772012-06-24 Paul Eggert <eggert@cs.ucla.edu>
6078
885d1d74
PE
6079 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
6080 instead of truncating it to 63 (admittedly a generous limit).
6081
d188e26b
PE
6082 * process.c: Fix spelling and caps in comments.
6083
e2f560b1
DN
60842012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
6085
e86db54b 6086 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
6087 * sysdep.c (setpgrp): Remove definition, not used in this file.
6088
7583a3a1
JB
60892012-06-24 Juanma Barranquero <lekktu@gmail.com>
6090
6091 * makefile.w32-in: Update dependencies.
6092
696056c2
EZ
60932012-06-24 Eli Zaretskii <eliz@gnu.org>
6094
6095 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
6096 (SYSTIME_H): Add nt/inc/sys/time.h.
6097
6098 * systime.h [WINDOWSNT]: Include sys/time.h.
6099
6100 * s/ms-w32.h (struct timespec): Definition moved from
6101 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
6102
845ca893
PE
61032012-06-24 Paul Eggert <eggert@cs.ucla.edu>
6104
6105 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
6106 * buffer.h (buffer_slot_type_mismatch):
6107 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
6108 * eval.c (unwind_to_catch):
6109 * image.c (my_png_error, my_error_exit):
6110 * keyboard.c (quit_throw_to_read_char, user_error)
6111 (Fexit_recursive_edit, Fabort_recursive_edit):
6112 * lisp.h (die, args_out_of_range, args_out_of_range_3)
6113 (wrong_type_argument, buffer_overflow, __executable_start)
6114 (memory_full, buffer_memory_full, string_overflow, Fthrow)
6115 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
6116 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
6117 (fatal):
6118 (child_setup) [!DOS_NT]:
6119 * lread.c (end_of_file_error, invalid_syntax):
6120 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
6121 * puresize.h (pure_write_error):
6122 * search.c (matcher_overflow):
6123 * sound.c (sound_perror, alsa_sound_perror):
6124 * sysdep.c, syssignal.h (croak):
6125 * term.c (maybe_fatal, vfatal):
6126 * textprop.c (text_read_only):
6127 * undo.c (user_error):
6128 * unexmacosx.c (unexec_error):
6129 * xterm.c (x_ins_del_lines, x_delete_glyphs):
6130 Use _Noreturn rather than NO_RETURN.
6131 No need for separate decl merely because of _Noreturn.
6132 * sound.c (sound_warning, parse_sound):
6133 Remove unnecessary forward decls.
6134
f1dd8073
PE
61352012-06-24 Paul Eggert <eggert@cs.ucla.edu>
6136
6137 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
6138 * lisp.h (WAIT_READING_MAX): New macro.
6139 * dispnew.c (Fsleep_for, sit_for):
6140 * keyboard.c (kbd_buffer_get_event):
6141 * process.c (Faccept_process_output):
6142 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
6143 This improves on the previous patch, which introduced a bug
6144 when time_t is unsigned and as wide as intmax_t.
6145 See <http://bugs.gnu.org/9000#51>.
6146
b82c1755
EZ
61472012-06-23 Eli Zaretskii <eliz@gnu.org>
6148
6149 * dispnew.c (sit_for, Fsleep_for):
6150 * keyboard.c (kbd_buffer_get_event):
6151 * process.c (Faccept_process_output): Avoid compiler warnings when
6152 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
6153
ca300656
JB
61542012-06-23 Juanma Barranquero <lekktu@gmail.com>
6155
049ec95b
JB
6156 * makefile.w32-in: Update dependencies.
6157
ca300656
JB
6158 * w32.c (ltime): Add return type and declare static.
6159 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
6160
db7b8d06
PE
61612012-06-23 Paul Eggert <eggert@cs.ucla.edu>
6162
6163 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
6164 Privately reported by Herbert J. Skuhra.
6165 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
6166 All uses changed.
6167 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
6168 not make_lisp_timeval, when the argument is of type EMACS_TIME.
6169
0bd8297f
EZ
61702012-06-23 Eli Zaretskii <eliz@gnu.org>
6171
96512555
EZ
6172 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
6173 last argument of make_unibyte_string.
6174
0bd8297f
EZ
6175 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
6176 language ID in the event parameters.
6177
6178 * w32term.c (w32_read_socket): Put the new keyboard codepage into
6179 event.code, not the obscure "character set ID".
6180
63def6b6
CY
61812012-06-23 Chong Yidong <cyd@gnu.org>
6182
6183 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
6184
e8a02204
EZ
61852012-06-23 Eli Zaretskii <eliz@gnu.org>
6186
388cdec0
EZ
6187 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
6188 * w32.c (fdutimens): New function.
6189
6190 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
6191
6192 * s/ms-w32.h (pselect): Redirect to sys_select.
6193
6194 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
6195
e8a02204
EZ
6196 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
6197 in the logic of incrementing and decrementing the value of
6198 use_relocatable_buffers.
6199
d054f3fb
PE
62002012-06-23 Paul Eggert <eggert@cs.ucla.edu>
6201
6202 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
6203 Privately reported by Herbert J. Skuhra.
6204 [__FreeBSD__]: Remove "*/" typo after "#include".
6205 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
6206 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
6207 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
6208 Don't assume EMACS_TIME and struct timeval are the same type.
6209
d35af63c
PE
62102012-06-22 Paul Eggert <eggert@cs.ucla.edu>
6211
6212 Support higher-resolution time stamps (Bug#9000).
6213 The time stamps are only nanosecond-resolution at the C level,
6214 since that's the best that any real-world system supports now.
6215 But they are picosecond-resolution at the Lisp level, as that's
6216 easy, and leaves room for future OS improvements.
6217
6218 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
6219 (LIBES): Use it.
6220
6221 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
6222 Don't get current time unless it's needed.
6223
6224 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
6225 now provides it if it's absent.
6226 (start_atimer): Port to higher-res time stamps.
6227 Check for time stamp overflow. Don't get current time more
6228 often than is needed.
6229
6230 * buffer.h (struct buffer): Buffer modtime now has high resolution.
6231 Include systime.h, not time.h.
6232 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
6233
6234 * dired.c: Include stat-time.h.
6235 (Ffile-attributes): File times now have higher resolution.
6236
6237 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
6238 (struct image): Timestamp now has higher resolution.
6239
6240 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
6241 has at least microseconds now. All uses removed.
6242 (update_frame, update_single_window, update_window, update_frame_1)
6243 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
927c7216 6244 (duration_to_sec_usec): Remove; no longer needed.
d35af63c
PE
6245
6246 * editfns.c (time_overflow): Now extern.
6247 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
6248 (float-time, Fformat_time_string, Fcurrent_time_string)
6249 (Fcurrent_time_zone): Accept and generate higher-resolution
6250 time stamps.
6251 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
6252 (decode_time_components, lisp_seconds_argument): New functions.
6253 (make_time): Now static.
6254 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
6255 Report an error if the time is invalid, rather than having the caller
6256 do that.
6257
6258 * fileio.c: Include <stat-time.h>
6259 (Fcopy_file): Copy higher-resolution time stamps.
6260 Prefer to set the time stamp via a file descriptor if that works.
6261 (Fset_file_times, Finsert_file_contents, Fwrite_region)
6262 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
6263 (Fvisited_file_modtime, Fset_visited_file_modtime):
6264 Support higher-resolution time stamps.
6265
6266 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
6267
6268 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
6269
6270 * image.c (prepare_image_for_display, clear_image_cache)
6271 (lookup_image): Port to higer-resolution time stamps.
6272
6273 * keyboard.c (start_polling, bind_polling_period):
6274 Check for time stamp overflow.
6275 (read_char, kbd_buffer_get_event, timer_start_idle)
6276 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
6277 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
6278 Port to higher-resolution time stamps. Do not assume time_t is signed.
6279 (decode_timer): New function. Timers are now vectors of length 9,
6280 not 8, to accommodate the picosecond component.
6281 (timer_check_2): Use it.
6282
6283 * nsterm.m (select_timeout, timeval_subtract): Remove.
6284 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
6285 as they're a bit more accurate and handle overflow better.
6286 (ns_select): Change prototype to be compatible with pselect.
6287 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
6288 * nsterm.h (ns_select): Adjust prototype.
6289
6290 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
6291 us-resolution time stamps.
6292 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
6293
6294 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
6295
6296 * lisp.h (time_overflow): New decl.
6297 (wait_reading_process_output): First arg is now intmax_t, not int,
6298 to accommodate larger waits.
6299
6300 * process.h (struct Lisp_Process.read_output_delay):
6301 Now counts nanoseconds, not microseconds.
6302 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
6303 EMACS_HAS_USECS.
6304 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
6305 (wait_reading_process_output):
6306 Port to ns-resolution time stamps.
6307 (Faccept_process_output, wait_reading_process_output):
6308 Check for time stamp overflow. Do not assume time_t is signed.
6309 (select_wrapper): Remove; we now use pselect.
6310 (Fprocess_attributes): Now generates ns-resolution time stamps.
6311
6312 * sysdep.c: Include utimens.h. Don't include utime.h
6313 or worry about struct utimbuf; gnulib does that for us now.
6314 (gettimeofday): Remove; gnulib provides a substitute.
6315 (make_timeval): New function.
6316 (set_file_times): Now sets ns-resolution time stamps.
6317 New arg FD; all uses changed.
6318 (time_from_jiffies, ltime_from_jiffies, get_up_time)
6319 (system_process_attributes):
6320 Now returns ns-resolution time stamp. All uses changed.
6321 Check for time stamp overflow.
6322
6323 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
6324 provides a substitute now.
6325
6326 * systime.h: Include timespec.h rather than sys/time.h and time.h,
6327 since it guarantees struct timespec.
6328 (EMACS_TIME): Now struct timespec, so that we can support
6329 ns-resolution time stamps.
6330 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
6331 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
6332 (EMACS_USECS): Remove.
6333 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
6334 so multiply the arg by 1000 before storing it.
6335 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
6336 New macros.
6337 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
6338 Port to ns-resolution time stamps.
6339 (EMACS_TIME_NEG_P): Remove; replaced by....
6340 (EMACS_TIME_SIGN): New macro.
6341 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
6342 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
6343 (set_file_times, make_time, lisp_time_argument): Adjust signature.
6344 (make_timeval, make_lisp_time, decode_time_components): New decls.
6345 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
6346 that it mishandled time_t overflow. You can't compare by subtracting!
6347 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
6348 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
6349
6350 * term.c: Include <sys/time.h>.
6351 (timeval_to_Time): New function, for proper overflow wraparound.
6352 (term_mouse_position, term_mouse_click): Use it.
6353
6354 * undo.c (record_first_change): Support higher-resolution time stamps
6355 in the undo buffer.
6356 (Fprimitive_undo): Use them when restoring time stamps.
6357
6358 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
6359 (w32_get_internal_run_time):
6360 Port to higher-resolution Emacs time stamps.
6361 (ltime): Now accepts single 64-bit integer, as that's more convenient
6362 for callers.
6363
6364 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
6365
6366 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
6367 for compatibility with pselect. Support ns-resolution time stamps.
6368
6369 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
6370
6371 * xselect.c (wait_for_property_change, x_get_foreign_selection):
6372 Check for time stamp overflow, and support ns-resolution time stamps.
6373
6374 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
6375 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
6376 (timeval_subtract): Remove; no longer needed.
6377 (XTflash, XTring_bell, x_wait_for_event):
6378 Port to ns-resolution time stamps. Don't assume time_t is signed.
6379
b6a92dfe
CY
63802012-06-22 Chong Yidong <cyd@gnu.org>
6381
6382 * xdisp.c (x_consider_frame_title): Revert last change.
6383
d251c37c
EZ
63842012-06-22 Eli Zaretskii <eliz@gnu.org>
6385
6386 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
6387 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
6388 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
6389 staticidx goes up to 1597 out of 1600 = 0x640.)
6390
f10deafb
PE
63912012-06-20 Paul Eggert <eggert@cs.ucla.edu>
6392
6393 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
6394 Otherwise, the umask might be mistakenly 0 while handling input signals.
6395
ec6de1e2
SM
63962012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
6397
6398 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
6399
28be1ada
DA
64002012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
6401
6402 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
6403 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
6404 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
6405 access to `contents' member of Lisp_Vector objects with AREF and ASET
6406 where appropriate.
6407
c6bf3022
CY
64082012-06-19 Chong Yidong <cyd@gnu.org>
6409
6410 * frame.c (delete_frame): When selecting a frame on a different
6411 text terminal, do not alter the terminal's top-frame.
6412
6413 * xdisp.c (format_mode_line_unwind_data): Record the target
6414 frame's selected window and its terminal's top-frame.
6415 (unwind_format_mode_line): Restore them.
6416 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
6417 Callers changed.
6418 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
6419 since tty frames can be explicitly named.
6420 (prepare_menu_bars): Likewise.
6421
6422 * term.c (Ftty_top_frame): New function.
6423
defd4196
PE
64242012-06-18 Paul Eggert <eggert@cs.ucla.edu>
6425
6426 Port byte-code-meter to modern targets.
6427 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
6428 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 6429 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
6430 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
6431 (METER_1, METER_2): Simplify.
6432
1053a871
SM
64332012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
6434
6435 * data.c (Fdefalias): Return `symbol' (bug#11686).
6436
b7e8d081
MR
64372012-06-18 Martin Rudalics <rudalics@gmx.at>
6438
6439 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
6440 gets killed during executing of this function (Bug#11665).
6441 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
6442 (Vkill_buffer_query_functions): In doc-string say that functions
6443 run by this hook should not change the current buffer.
6444
7ea2b339
PE
64452012-06-18 Paul Eggert <eggert@cs.ucla.edu>
6446
6447 Fix recently-introduced process.c problems found by static checking.
6448 * process.c (write_queue_push, write_queue_pop, send_process):
6449 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
6450 (write_queue_pop): Fix pointer signedness problem.
6451 (send_process): Remove unused local.
6452
96a313a1
CY
64532012-06-17 Chong Yidong <cyd@gnu.org>
6454
6455 * xdisp.c (redisplay_internal): No need to redisplay terminal
6456 frames that are not on top.
6457
20ca2e94
TN
64582012-06-17 Troels Nielsen <bn.troels@gmail.com>
6459
6460 * process.c (make_process): Initialize write_queue.
6461 (write_queue_push, write_queue_pop): New functions.
6462 (send_process): Use them to maintain correct ordering of process
6463 writes (Bug#10815).
6464
9a900ca9
PE
64652012-06-17 Paul Eggert <eggert@cs.ucla.edu>
6466
310fbfa8
PE
6467 * lisp.h (eassert): Assume C89 or later.
6468 This removes the need for CHECK.
6469 (CHECK): Remove. Its comments about always evaluating its
6470 argument were confusing, as 'eassert' typically does not evaluate
6471 its argument.
6472
27bb1ca4
PE
6473 * coding.c (produce_chars): Use ptrdiff_t, not int.
6474
9a900ca9
PE
6475 * xterm.c (x_draw_underwave): Check for integer overflow.
6476 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
6477
41b7f8bc 64782012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
6479
6480 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
6481 referenced (Bug#11583).
6482
9b0e3eba
AA
64832012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
6484
6485 Implement wave-style variant of underlining.
6486 * dispextern.h (face_underline_type): New enum.
6487 (face): Add field for underline type.
6488 * nsterm.m (ns_draw_underwave): New function.
6489 (ns_draw_text_decoration): Use it.
6490 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
6491 New functions.
6492 (x_draw_glyph_string): Use them.
6493 * xfaces.c (Qline, Qwave): New Lisp objects.
6494 (check_lface_attrs, merge_face_ref)
1053a871
SM
6495 (Finternal_set_lisp_face_attribute, realize_x_face):
6496 Handle wave-style underline face attributes.
9b0e3eba
AA
6497 * xterm.c (x_draw_underwave): New function.
6498 (x_draw_glyph_string): Use it.
6499
0fb52f11
JB
65002012-06-16 Juanma Barranquero <lekktu@gmail.com>
6501
6502 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
6503 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
6504 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
6505 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
6506 ($(BLD)/w32select.$(O)): Update dependencies.
6507
e5560ff7
AS
65082012-06-16 Andreas Schwab <schwab@linux-m68k.org>
6509
6510 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
6511 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
6512 * character.c (_fetch_multibyte_char_p): Remove.
6513 * alloc.c: Include "character.h" before "buffer.h".
6514 * bidi.c: Likewise.
6515 * buffer.c: Likewise.
6516 * bytecode.c: Likewise.
6517 * callint.c: Likewise.
6518 * callproc.c: Likewise.
6519 * casefiddle.c: Likewise.
6520 * casetab.c: Likewise.
6521 * category.c: Likewise.
6522 * cmds.c: Likewise.
6523 * coding.c: Likewise.
6524 * composite.c: Likewise.
6525 * dired.c: Likewise.
6526 * dispnew.c: Likewise.
6527 * doc.c: Likewise.
6528 * dosfns.c: Likewise.
6529 * editfns.c: Likewise.
6530 * emacs.c: Likewise.
6531 * fileio.c: Likewise.
6532 * filelock.c: Likewise.
6533 * font.c: Likewise.
6534 * fontset.c: Likewise.
6535 * fringe.c: Likewise.
6536 * indent.c: Likewise.
6537 * insdel.c: Likewise.
6538 * intervals.c: Likewise.
6539 * keyboard.c: Likewise.
6540 * keymap.c: Likewise.
6541 * lread.c: Likewise.
6542 * macros.c: Likewise.
6543 * marker.c: Likewise.
6544 * minibuf.c: Likewise.
6545 * nsfns.m: Likewise.
6546 * nsmenu.m: Likewise.
6547 * print.c: Likewise.
6548 * process.c: Likewise.
6549 * regex.c: Likewise.
6550 * region-cache.c: Likewise.
6551 * search.c: Likewise.
6552 * syntax.c: Likewise.
6553 * term.c: Likewise.
6554 * textprop.c: Likewise.
6555 * undo.c: Likewise.
6556 * unexsol.c: Likewise.
6557 * w16select.c: Likewise.
6558 * w32fns.c: Likewise.
6559 * w32menu.c: Likewise.
6560 * window.c: Likewise.
6561 * xdisp.c: Likewise.
6562 * xfns.c: Likewise.
6563 * xmenu.c: Likewise.
6564 * xml.c: Likewise.
6565 * xselect.c: Likewise.
6566
2f07e6af
EZ
65672012-06-16 Eli Zaretskii <eliz@gnu.org>
6568
1053a871
SM
6569 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
6570 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 6571 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
6572 row.
6573 (handle_face_prop): Use chunk-relative overlay string index when
6574 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
6575 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
6576 the rightmost. (Bug#11720)
2f07e6af 6577
29b83cec
AS
65782012-06-16 Andreas Schwab <schwab@linux-m68k.org>
6579
6580 * category.h (CHAR_HAS_CATEGORY): Define as inline.
6581 (CATEGORY_MEMBER): Enforce 1/0 value.
6582 * category.c (_temp_category_set): Remove.
6583
4c5501e9
EZ
65842012-06-16 Eli Zaretskii <eliz@gnu.org>
6585
6586 * window.c (Fdelete_other_windows_internal)
6587 (Fdelete_window_internal): Don't access frame's mouse highlight
6588 info of the initial frame. (Bug#11677)
6589
2b570124
PE
65902012-06-14 Paul Eggert <eggert@cs.ucla.edu>
6591
e93864f9
PE
6592 * .gdbinit (xgetint): Fix recently-introduced paren typo.
6593 Assume USE_2_TAGS_FOR_INTS.
6594 (xreload): Adjust $tagmask width to match recent lisp.h change.
6595
2b570124
PE
6596 Simplify lisp.h in minor ways that should not affect code.
6597 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
6598 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
6599 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
6600 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
6601 (INTTYPEBITS): New macro, for clarity.
6602 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
6603 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
6604 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
6605 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
6606 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
6607
81755f69
JB
66082012-06-13 Juanma Barranquero <lekktu@gmail.com>
6609
6610 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
6611
16192a57
GM
66122012-06-13 Glenn Morris <rgm@gnu.org>
6613
6614 * s/bsd-common.h (BSD4_3):
6615 * s/usg5-4-common.h (USG5_4): No longer define; unused.
6616
646b5f55
AS
66172012-06-13 Andreas Schwab <schwab@linux-m68k.org>
6618
6619 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
6620 instead of union.
6621 (XLI, XIL): Define.
1053a871
SM
6622 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
6623 Use them.
6624 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 6625 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 6626 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
6627 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
6628 * frame.c (delete_frame): Remove outdated comment.
6629 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
6630 USE_LISP_UNION_TYPE.
6631 (Fw32_unregister_hot_key): Likewise.
6632 (Fw32_toggle_lock_key): Likewise.
6633 * w32menu.c (add_menu_item): Likewise.
6634 (w32_menu_display_help): Use XIL instead of checking
6635 USE_LISP_UNION_TYPE.
6636 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
6637 (init_heap): Likewise.
6638 * w32term.c (w32_read_socket): Update comment.
6639
1d3823c9
GM
66402012-06-13 Glenn Morris <rgm@gnu.org>
6641
c62ff706
GM
6642 * s/usg5-4-common.h, src/s/unixware.h:
6643 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
6644
1d3823c9
GM
6645 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
6646
bfe3e0a2
PE
66472012-06-13 Paul Eggert <eggert@cs.ucla.edu>
6648
6649 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
6650 * alloc.c (make_number) [!defined make_number]:
6651 Remove, as lisp.h always defines this now.
6652 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
6653 (roundup_size): Verify that it is a power of 2.
6654 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
6655 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
6656 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
6657 -DUSE_LSB_TAG=0, to override the automatically-selected default.
6658 USE_LSB_TAG now is always defined to be either 0 or 1.
6659 All uses changed.
6660 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
6661 code works fine either way, and efficiency is not a concern here,
6662 as the union type is for debugging, not for production.
6663 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
6664 Use an inline function on all platforms when using the union type,
6665 since this is simpler and 'static inline' can be used portably
6666 within Emacs now.
6667 (LISP_INITIALLY_ZERO): New macro.
6668 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
6669 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
6670
45fa9c0f
GM
66712012-06-12 Glenn Morris <rgm@gnu.org>
6672
b4492cba
GM
6673 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
6674
6675 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 6676
45fa9c0f
GM
6677 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
6678 Move BROKEN_SIGIO to configure.
6679
6680 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
6681 Move NO_TERMIO to configure.
6682
0e25d334
CY
66832012-06-12 Chong Yidong <cyd@gnu.org>
6684
6685 * image.c (imagemagick_load_image): Use MagickFlattenImage if
6686 MagickMergeImageLayers is undefined. Use pixel pusher loop if
6687 MagickExportImagePixels is undefined.
6688
43682bb6
PE
66892012-06-12 Paul Eggert <eggert@cs.ucla.edu>
6690
6691 * image.c (imagemagick_load_image): Remove unused label.
6692
a9be7d2b
GM
66932012-06-11 Glenn Morris <rgm@gnu.org>
6694
6695 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
6696 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
6697 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
6698 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
6699
3017f87f
SM
67002012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
6701
6702 * alloc.c (make_byte_code): New function.
6703 (Fmake_byte_code): Use it. Don't purify here.
6704 * lread.c (read1): Use it as well to avoid extra allocation.
6705
1b9b4cf4
CY
67062012-06-11 Chong Yidong <cyd@gnu.org>
6707
6708 * image.c (imagemagick_load_image): Implement transparency.
6709
95988fcf
AS
67102012-06-10 Andreas Schwab <schwab@linux-m68k.org>
6711
6712 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
6713 account for preceding backslashes. (Bug#11663)
6714
cd4eb164
CY
67152012-06-09 Chong Yidong <cyd@gnu.org>
6716
6717 * term.c: Support italics in capable terminals (Bug#9652).
6718 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
6719 (turn_on_face): Output using TS_enter_italic_mode if available.
6720 Don't handle unused blinking and alt-charset cases.
6721 (turn_off_face): Handle italic case; discard unused tty_blinking_p
6722 and tty_alt_charset_p cases.
6723 (tty_capable_p, init_tty): Support italics.
6724
6725 * termchar.h (struct tty_display_info): Add field for italics.
6726 Remove unused blink field.
6727
6728 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
6729 Handle slant.
6730
6731 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
6732 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
6733 tty_alt_charset_p. Add tty_italic_p.
6734
ff88beb8
MA
67352012-06-09 Michael Albinus <michael.albinus@gmx.de>
6736
6737 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
6738 dbus_type_is_basic if available.
6739 (xd_extract_signed, xd_extract_unsigned): Rename from
6740 extract_signed and extract_unsigned, respectively. Adapt callers.
6741
44286096
CY
67422012-06-09 Chong Yidong <cyd@gnu.org>
6743
1682701f
CY
6744 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
6745
44286096
CY
6746 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
6747 case (Bug#9752).
6748
d86feb17
PE
67492012-06-08 Paul Eggert <eggert@cs.ucla.edu>
6750
6751 * xdisp.c (vmessage): Treat frame message as multibyte.
6752 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
6753 would generate the diagnostic "Making \302\247 buffer-local while
6754 let-bound!".
6755
d5c20fe8
EZ
67562012-06-08 Eli Zaretskii <eliz@gnu.org>
6757
6758 * dispnew.c (showing_window_margins_p): Undo last change, which
6759 was done due to an inadvertent commit.
6760 (adjust_frame_glyphs_for_frame_redisplay): Do call
6761 showing_window_margins_p.
6762
513749ee
SM
67632012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
6764
6765 * eval.c (Fmake_var_non_special): New primitive.
6766 (syms_of_eval): Defsubr it.
6767 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
6768
d4a8f5c1
JB
67692012-06-08 Juanma Barranquero <lekktu@gmail.com>
6770
6771 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
6772 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
6773
8bbbc977
EZ
67742012-06-08 Eli Zaretskii <eliz@gnu.org>
6775
6776 * alloc.c (allocate_vectorlike): Fix last change.
6777
f3372c87
DA
67782012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
6779
6780 Block-based vector allocation of small vectors.
6781 * lisp.h (struct vectorlike_header): New field `nbytes',
6782 adjust comment accordingly.
6783 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
fc0c31f8 6784 to denote vector blocks. Adjust users (live_vector_p,
f3372c87
DA
6785 mark_maybe_pointer, valid_lisp_object_p) accordingly.
6786 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
6787 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
6788 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
6789 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
6790 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
6791 (roundup_size): New constant.
6792 (struct vector_block): New data type.
6793 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 6794 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
6795 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
6796 (sweep_vectors): New functions.
6797 (allocate_vectorlike): Return `zero_vector' as the only vector of
fc0c31f8 6798 0 items. Allocate new vector from block if vector size is less than
f3372c87
DA
6799 or equal to VBLOCK_BYTES_MAX.
6800 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
6801 (init_alloc_once): Add call to init_vectors.
6802
4f18a4ed
SM
68032012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
6804
6805 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
6806
86f158bc
PE
68072012-06-07 Paul Eggert <eggert@cs.ucla.edu>
6808
6809 * doprnt.c (doprnt): Truncate multibyte char correctly.
6810 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
6811 would mishandle a string argument "Xc" if X was a multibyte
6812 character of length 2: it would truncate after X's first byte
6813 rather than including all of X.
6814
c5cfcbe0
CY
68152012-06-06 Chong Yidong <cyd@gnu.org>
6816
6817 * buffer.c (word_wrap): Doc fix.
6818
c05cf390
PE
68192012-06-04 Paul Eggert <eggert@cs.ucla.edu>
6820
6821 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
6822
0c3461de
GM
68232012-06-03 Glenn Morris <rgm@gnu.org>
6824
6825 * xdisp.c (tool-bar-style): Doc fix.
6826
c71232db
UM
68272012-06-03 Ulrich Müller <ulm@gentoo.org>
6828
6829 * Makefile.in (PAXCTL): Define.
6830 (temacs$(EXEEXT)): Disable memory randomization for the temacs
6831 binary via PaX flags if the paxctl utility is available.
6832 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
6833 Restore PaX flags to their default. (Bug#11398)
6834
383f7350
CY
68352012-06-03 Chong Yidong <cyd@gnu.org>
6836
6837 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
6838 buffer (Bug#11226).
6839
5f2c76c6
CY
68402012-06-03 Chong Yidong <cyd@gnu.org>
6841
6842 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
6843 (note_mode_line_or_margin_highlight): If there is no help echo,
6844 use mode-line-default-help-echo. Handle the case where the mouse
6845 position is past the end of the mode line string.
6846
6847 * buffer.c (buffer_local_value_1): New function, split from
6848 Fbuffer_local_value; can return Qunbound.
6849 (Fbuffer_local_value): Use it.
6850 (Vmode_line_format): Docstring tweaks.
6851
773d47f6
PE
68522012-06-02 Paul Eggert <eggert@cs.ucla.edu>
6853
6854 * sysdep.c (system_process_attributes): Improve comment.
6855
f2d6a3df
SM
68562012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
6857
6858 * keyboard.c: Export real-this-command to Elisp.
6859 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
6860 and DEFVAR it. Update all users.
6861
63810350
PE
68622012-06-02 Paul Eggert <eggert@cs.ucla.edu>
6863
7bd5c1f4
PE
6864 * minibuf.c (Fassoc_string): Remove duplicate declaration.
6865
63810350
PE
6866 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
6867 Convert pctcpu and pctmem to Lisp float properly.
6868 Let the compiler fold better, as 100.0/0x8000 is exact.
6869
a2821611
AS
68702012-06-02 Andreas Schwab <schwab@linux-m68k.org>
6871
6872 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
6873 cons_block.
6874
5fceba1d
PE
68752012-06-01 Paul Eggert <eggert@cs.ucla.edu>
6876
6877 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
6878
c98ff5dd
DA
68792012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
6880
6881 For a 'struct window', replace some Lisp_Object fields to
6882 bitfields where appropriate, remove unused fields.
6883 * window.h (struct window): Remove unused 'last_mark_x' and
6884 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
6885 change it's type from Lisp_Object to bitfield.
6886 Change type of 'force_start', 'optional_new_start',
6887 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
fc0c31f8 6888 fields from Lisp_Object to bitfield. Adjust users accordingly.
c98ff5dd 6889
ca34e0be
PE
68902012-05-31 Paul Eggert <eggert@cs.ucla.edu>
6891
6892 Pacify gcc -Wdouble-precision when using Xaw.
6893 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
6894 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
6895 Use 'float' consistently, rather than 'float' in most places
6896 and 'double' in a couple of places.
6897
efc00ab1 68982012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
6899
6900 * xdisp.c (handle_stop): Detect whether we have overlay strings
6901 loaded by testing it->current.overlay_string_index to be
6902 non-negative, instead of checking whether n_overlay_strings is
6903 positive. (Bug#11587)
6904
efc00ab1 69052012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
6906
6907 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
6908
6909 * doc.c (Fsubstitute_command_keys): Doc fix.
6910
efc00ab1 69112012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
6912
6913 * search.c (search_buffer): Remove calls to
6914 r_alloc_inhibit_buffer_relocation, as it is now called by
6915 maybe_unify_char, which was the cause of relocation of buffer text
6916 in bug#11519.
6917
efc00ab1 69182012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
6919
6920 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
6921 for the duration of call to load_charset, to avoid problems with
6922 callers of maybe_unify_char that access buffer text through C
6923 pointers.
6924
6925 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
6926 decrement the inhibition flag, instead of just setting or
6927 resetting it.
6928
ba93a187
PE
69292012-05-31 Paul Eggert <eggert@cs.ucla.edu>
6930
6931 Remove obsolete '#define static' cruft.
6932 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
6933 This #undef was "temporary" in 2000; it is no longer needed
6934 now that '#define static' has gone away.
6935 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
6936 (gray_bitmap_bits): Remove; no longer needed.
6937 All uses replaced with definiens.
6938 * xterm.c: Include "bitmaps/gray.xbm".
6939
9e4bf381
PE
69402012-05-30 Paul Eggert <eggert@cs.ucla.edu>
6941
6942 Clean up __executable_start, monstartup when --enable-profiling.
6943 The following changes affect the code only when profiling.
6944 * dispnew.c (__executable_start): Rename from safe_bcopy.
6945 Define only on platforms that need it.
6946 * emacs.c: Include <sys/gmon.h> when profiling.
6947 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
6948 (__executable_start): Remove decl, since lisp.h does it now.
6949 (safe_bcopy): Remove decl; no longer has that name.
6950 (main): Coalesce #if into single bit of code, for simplicity.
6951 Cast pointers to uintptr_t, since standard libraries want integers
6952 and not pointers.
6953 * lisp.h (__executable_start): New decl.
6954
32d72c2f
GM
69552012-05-31 Glenn Morris <rgm@gnu.org>
6956
6957 * image.c (Fimagemagick_types): Doc fix.
6958
baac5bc7
JM
69592012-05-30 Jim Meyering <meyering@redhat.com>
6960
6961 * callproc.c (Fcall_process_region): Include directory component
6962 in mkstemp error message (Bug#11586).
6963
72cb32cf
PE
69642012-05-30 Paul Eggert <eggert@cs.ucla.edu>
6965
6966 * alloc.c, lisp.h (make_pure_vector): Now static.
6967
61b108cc
SM
69682012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
6969
6970 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
6971 Move to byte-run.el.
6972 (Fautoload): Do the hash-doc more carefully.
6973 * data.c (Fdefalias): Purify definition, except for keymaps.
6974 (Qdefun): Move from eval.c.
6975 * lisp.h (Qdefun): Remove.
6976 * lread.c (read1): Tiny simplification.
6977
471fe23d
TN
69782012-05-29 Troels Nielsen <bn.troels@gmail.com>
6979
934f3f58 6980 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
6981 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
6982 Bug#9642, but explicitly check that the buffer the overlay would
6983 be moved to is live and rearrange lines to make sure that errors
6984 will not put the overlay in an inconsistent state.
6985 (Fdelete_overlay): Cosmetics.
6986
85d0efd1
EZ
69872012-05-28 Eli Zaretskii <eliz@gnu.org>
6988
6989 * w32term.c (my_bring_window_to_top): New function.
6990 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
6991 could be different from the original one.
6992 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
6993 (Bug#11513)
6994
6995 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
6996 by calling BringWindowToTop.
6997
6998 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
6999 (WM_EMACS_END): Increase by one.
7000
da92a98c
PE
70012012-05-28 Paul Eggert <eggert@cs.ucla.edu>
7002
7003 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
7004 This avoids undefined behavior that might cause the eassert
7005 to not catch an out-of-range value.
7006
74d1f848
JB
70072012-05-28 Juanma Barranquero <lekktu@gmail.com>
7008
7009 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
7010 Update dependencies.
7011
9e1a06fc
EZ
70122012-05-27 Eli Zaretskii <eliz@gnu.org>
7013
7014 * bidi.c (bidi_mirror_char): Fix last change.
7015
f3dd7312
AS
70162012-05-27 Andreas Schwab <schwab@linux-m68k.org>
7017
7018 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
7019 when referring to sectname field in printf format.
7020
81899c91
PE
70212012-05-27 Paul Eggert <eggert@cs.ucla.edu>
7022
57b81a9f
PE
7023 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
7024 Only r_alloc_inhibit_buffer_relocation needed to be added;
7025 the others were already declared.
7026
81899c91
PE
7027 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
7028 before checking whether it's out of range. Put the check inside
7029 eassert. See
7030 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
7031
33017faf 70322012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
7033
7034 * callproc.c (Fcall_process): Restore a line that was accidentally
7035 commented out in the 2011-02-13 change (bug#11547).
7036
33017faf 70372012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
7038
7039 * lisp.h [REL_ALLOC]: Add prototypes for external functions
7040 defined on ralloc.c.
7041
7042 * buffer.c [REL_ALLOC]: Remove prototypes of
7043 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
7044 they are now on lisp.h.
7045
7046 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
7047
7048 * search.c (search_buffer): Use it to inhibit relocation of buffer
7049 text while re_search_2 is doing its job, because re_search_2 is
7050 passed C pointers to buffer text. (Bug#11519)
7051
23415acf
EZ
7052 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
7053 Update value to 24.
7054
44e27368
EZ
7055 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
7056 state after an additional call to move_it_in_display_line_to, keep
7057 the values of it->max_ascent and it->max_descent found for the
7058 entire line.
7059 (pos_visible_p): Revert the comparison against bottom_y to what it
7060 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
7061 (Bug#11464)
7062
c1892f11
PE
70632012-05-26 Paul Eggert <eggert@cs.ucla.edu>
7064
7065 Fix coding-related core dumps with gcc -ftrapv.
7066 The code was computing A - B, where A and B are pointers, and B is
7067 random garbage. This can lead to core dumps on platforms that
7068 have special pointer registers, and it also leads to core dumps on
7069 x86-64 when compiled with gcc -ftrapv. The fix is to compute
7070 A - B only when B is initialized properly.
7071 * coding.c (coding_set_source, coding_set_destination): Return void.
7072 (coding_change_source, coding_change_destinations): New functions,
7073 with the old behaviors of coding_set_source and coding_set_destination.
7074 All callers that need an offset changed to use these new functions.
7075
eb7afdad
GM
70762012-05-26 Glenn Morris <rgm@gnu.org>
7077
7078 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
7079
f12fdf02
EZ
70802012-05-26 Eli Zaretskii <eliz@gnu.org>
7081
53a63be6 7082 Extend mouse support on W32 text-mode console.
61b108cc
SM
7083 * xdisp.c (draw_row_with_mouse_face):
7084 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 7085
eb3f6f01 7086 * w32console.c: Include window.h.
61b108cc
SM
7087 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
7088 New functions.
eb3f6f01
EZ
7089 (initialize_w32_display): Initialize mouse-highlight data.
7090
53a63be6
EZ
7091 * w32inevt.c: Include termchar.h and window.h.
7092 (do_mouse_event): Support mouse-autoselect-window. When the mouse
7093 moves, call note_mouse_highlight. If help_echo changed, call
7094 gen_help_event to produce help-echo message in the echo area.
7095 Call clear_mouse_face if mouse_face_hidden is set in the mouse
7096 highlight info.
7097
4cfd81f6
PE
70982012-05-26 Paul Eggert <eggert@cs.ucla.edu>
7099
7100 * lread.c (read1): Simplify slightly to avoid an overflow warning
7101 with GCC 4.7.0 on x86-64.
7102
4446092a
EZ
71032012-05-26 Eli Zaretskii <eliz@gnu.org>
7104
7105 * bidi.c (bidi_mirror_char): Revert last change: an int is
7106 definitely wide enough here.
7107
42b2a986 71082012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 7109
42b2a986 7110 Fix integer width and related bugs (Bug#9874).
eb106a49 7111 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
7112 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
7113 (string_bytes, check_sblock, allocate_string_data):
7114 (compact_small_strings, Fmake_bool_vector, make_string)
7115 (make_unibyte_string, make_multibyte_string)
7116 (make_string_from_bytes, make_specified_string)
7117 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
7118 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
7119 (mark_vectorlike):
7120 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7121 (allocate_pseudovector):
7122 Use int, not EMACS_INT, where int is wide enough.
7123 (inhibit_garbage_collection, Fgarbage_collect):
7124 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7125 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
7126 int might not be wide enough.
7127 (bidi_cache_search, bidi_cache_find, bidi_init_it)
7128 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
7129 (bidi_at_paragraph_end, bidi_find_paragraph_start)
7130 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
7131 (bidi_level_of_next_char, bidi_move_to_visually_next):
7132 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7133 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
7134 (Fkill_buffer, Fset_buffer_major_mode)
7135 (advance_to_char_boundary, Fbuffer_swap_text)
7136 (Fset_buffer_multibyte, overlays_at, overlays_in)
7137 (overlay_touches_p, struct sortvec, record_overlay_string)
7138 (overlay_strings, recenter_overlay_lists)
7139 (adjust_overlays_for_insert, adjust_overlays_for_delete)
7140 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
7141 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
7142 (Foverlay_recenter, last_overlay_modification_hooks_used)
7143 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
7144 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
7145 (validate_region): Omit unnecessary test for b <= e,
7146 since that's guaranteed by the previous test.
d311d28c
PE
7147 (adjust_overlays_for_delete): Avoid pos + length overflow.
7148 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
7149 (report_overlay_modification):
7150 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7151 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
7152 Omit pointer cast, which isn't needed anyway, and doesn't work
7153 after the EMACS_INT -> ptrdiff_t change.
02481186 7154 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
7155 * buffer.h: Adjust decls to match defn changes elsewhere.
7156 (struct buffer_text, struct buffer):
7157 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7158 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
7159 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
7160 not int, to avoid needless 32-bit limit on 64-bit hosts.
7161 (exec_byte_code): Use tighter memory-full test, one that checks
7162 for alloca overflow. Don't compute the address of the object just
7163 before an array, as that's not portable. Use EMACS_INT, not
7164 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
7165 * callint.c (Fcall_interactively):
7166 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7167 * callproc.c (call_process_kill, Fcall_process):
7168 Don't assume pid_t fits into an Emacs fixnum.
7169 (call_process_cleanup, Fcall_process, child_setup):
7170 Don't assume pid_t fits into int.
7171 (call_process_cleanup, Fcall_process, delete_temp_file)
7172 (Fcall_process_region):
7173 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7174 (Fcall_process): Simplify handling of volatile integers.
7175 Use int, not EMACS_INT, where int will do.
7176 * casefiddle.c (casify_object, casify_region, operate_on_word)
7177 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
7178 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7179 (casify_object): Avoid integer overflow when overallocating buffer.
7180 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 7181 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
7182 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
7183 * category.h (CATEGORYP): Don't assume arg is nonnegative.
7184 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
7185 integers are now checked earlier. All uses replaced with XINT.
7186 (ccl_driver):
7187 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7188 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
7189 (ccl_driver, Fregister_code_conversion_map):
7190 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
7191 (resolve_symbol_ccl_program): Check that vector header is in range.
7192 Always copy the vector, so that we can check its contents reliably
7193 now rather than having to recheck each instruction as it's being
7194 executed. Check that vector words fit in 'int'.
7195 (ccl_get_compiled_code, Fregister_ccl_program)
7196 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
7197 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
7198 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
7199 contents are in range.
7200 (Fccl_execute_on_string): Check that status is in range.
7201 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
7202 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
7203 Accept and return EMACS_INT, not int, because callers can pass values
7204 out of 'int' range.
7205 (c_string_width, strwidth, lisp_string_width, chars_in_text)
7206 (multibyte_chars_in_text, parse_str_as_multibyte)
7207 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
7208 (str_as_unibyte, str_to_unibyte, string_count_byte8)
7209 (string_escape_byte8, Fget_byte):
7210 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 7211 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
7212 avoid mishandling large integers.
7213 * character.h: Adjust decls to match defn changes elsewhere.
7214 * charset.c (load_charset_map_from_file, find_charsets_in_text)
7215 (Ffind_charset_region):
7216 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7217 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
7218 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 7219 Don't assume fixnum fits in int.
d311d28c
PE
7220 (load_charset_map_from_vector, Fmap_charset_chars):
7221 Remove now-unnecessary CHECK_NATNUMs.
7222 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
7223 Don't rely on undefined behavior with signed left shift overflow.
7224 Don't assume unsigned int fits into fixnum, or that fixnum fits
7225 into unsigned int. Don't require max_code to be a valid fixnum;
7226 that's not true for gb10830 4-byte on a 32-bit host. Allow
7227 invalid_code to be a cons, for the same reason. Require code_offset
7228 to be a character. Avoid int overflow if max_char is close
7229 to INT_MAX.
7230 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
7231 this is intended anyway and avoids some undefined behavior.
7232 (load_charset_map): Pass unsigned, not int, as 2nd arg of
7233 INDEX_TO_CODE_POINT, as that's what it expects.
7234 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
7235 * charset.h (DECODE_CHAR): Return int, not unsigned;
7236 this is what was intended anyway, and it avoids undefined behavior.
7237 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
7238 integer-overflow issues.
7239 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
7240 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
7241 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
7242 * chartab.c (Fmake_char_table, Fset_char_table_range)
7243 (uniprop_get_decoder, uniprop_get_encoder):
7244 Don't assume fixnum fits in int.
7245 * cmds.c (move_point): New function, that does the gist of
7246 Fforward_char and Fbackward_char, but does so while checking
7247 for integer overflow more accurately.
c96e5d6a 7248 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
7249 (Fforward_line, Fend_of_line, internal_self_insert)
7250 (internal_self_insert):
7251 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7252 Fix a FIXME, by checking for integer overflow when calculating
7253 target_clm and actual_clm.
7254 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 7255 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
7256 (ASSURE_DESTINATION, coding_alloc_by_realloc)
7257 (coding_alloc_by_making_gap, alloc_destination)
7258 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
7259 (encode_coding_utf_16, detect_coding_emacs_mule)
7260 (decode_coding_emacs_mule, encode_coding_emacs_mule)
7261 (detect_coding_iso_2022, decode_coding_iso_2022)
7262 (encode_invocation_designation, encode_designation_at_bol)
7263 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7264 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
7265 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
7266 (encode_coding_ccl, encode_coding_raw_text)
7267 (detect_coding_charset, decode_coding_charset)
7268 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
7269 (produce_composition, produce_charset, produce_annotation)
7270 (decode_coding, handle_composition_annotation)
7271 (handle_charset_annotation, consume_chars, decode_coding_gap)
7272 (decode_coding_object, encode_coding_object, detect_coding_system)
7273 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
7274 (code_convert_region, code_convert_string)
8f50130c
PE
7275 (Fdefine_coding_system_internal)
7276 (coding_set_source, coding_set_destination):
d311d28c
PE
7277 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7278 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
7279 (Fdefine_coding_system_internal):
7280 Don't assume fixnums fit in int.
7281 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 7282 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
7283 (Funencodable_char_position, Fcheck_coding_systems_region)
7284 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 7285 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 7286 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 7287 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 7288 Don't access memory outside of the args array.
d311d28c 7289 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
7290 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
7291 result of ENCODE_CHAR.
d311d28c
PE
7292 * coding.h: Adjust decls to match defn changes elsewhere.
7293 (struct coding_system):
7294 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7295 * composite.c (get_composition_id, find_composition)
7296 (run_composition_function, update_compositions)
7297 (compose_text, composition_gstring_put_cache)
7298 (composition_gstring_p, composition_gstring_width)
7299 (fill_gstring_header, fill_gstring_body, autocmp_chars)
7300 (composition_compute_stop_pos, composition_reseat_it)
7301 (composition_update_it, struct position_record)
7302 (find_automatic_composition, composition_adjust_point)
7303 (Fcomposition_get_gstring, Ffind_composition_internal):
7304 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7305 (update_compositions):
7306 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7307 * composite.h: Adjust decls to match defn changes elsewhere.
7308 (struct composition):
7309 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7310 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
7311 Do not attempt to compute the address of the object just before a
7312 buffer; this is not portable.
7313 (Faref, Faset):
7314 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7315 (Faset): Use int, not EMACS_INT, where int is wide enough.
7316 (Fstring_to_number): Don't assume fixnums fit in int.
7317 (Frem): Don't assume arg is nonnegative.
7318 * dbusbind.c (xd_append_arg): Check for integers out of range.
7319 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 7320 (extract_signed, extract_unsigned): New functions.
243e0530
PE
7321 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
7322 (xd_get_connection_references): Return ptrdiff_t, not int.
7323 All uses changed.
7324 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
7325 (xd_read_message_1):
7326 Use int, not unsigned, where the dbus API uses int.
7327 (Fdbus_message_internal): Don't overflow mtype.
7328 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
7329 * dired.c (directory_files_internal, file_name_completion, scmp)
7330 (file_name_completion_stat):
7331 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7332 (file_name_completion): Don't overflow matchcount.
7333 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
7334 * dispextern.h: Adjust decls to match defn changes elsewhere.
7335 (struct text_pos, struct glyph, struct bidi_saved_info)
7336 (struct bidi_string_data, struct bidi_it, struct composition_it)
7337 (struct it):
7338 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7339 (struct display_pos, struct composition_it, struct it):
7340 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7341 * dispnew.c (increment_matrix_positions)
7342 (increment_row_positions, mode_line_string)
7343 (marginal_area_string):
7344 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 7345 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
7346 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7347 (duration_to_sec_usec): New function, to check for overflow better.
7348 (Fsleep_for, sit_for): Use it.
7349 * doc.c (get_doc_string, store_function_docstring):
7350 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7351 (get_doc_string, Fsnarf_documentation):
7352 Use int, not EMACS_INT, where int is wide enough.
7353 (get_doc_string):
7354 Use SAFE_ALLOCA, not alloca.
7355 Check for overflow when converting EMACS_INT to off_t.
7356 * doprnt.c (doprnt):
7357 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7358 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
7359 Don't assume uid_t fits into fixnum.
7360 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
7361 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
7362 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
7363 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
7364 (general_insert_function)
7365 (Finsert_char, make_buffer_string, make_buffer_string_both)
7366 (update_buffer_properties, Fbuffer_substring)
7367 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
7368 (Fsubst_char_in_region, check_translation)
7369 (Ftranslate_region_internal, save_restriction_restore, Fformat)
7370 (transpose_markers, Ftranspose_regions):
7371 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7372 (clip_to_bounds): Move to lisp.h as an inline function).
7373 (Fconstrain_to_field): Don't assume integers are nonnegative.
7374 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
7375 (Fsubst_char_in_region, Fsave_restriction):
7376 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7377 (Femacs_pid): Don't assume pid_t fits into fixnum.
7378 (lo_time): Use int, not EMACS_INT, when int suffices.
7379 (lisp_time_argument): Check for usec out of range.
7380 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
7381 (Fuser_login_name, Fuser_full_name): Signal an error
7382 if a uid argument is out of range, rather than relying on
7383 undefined behavior.
c8d5c857
PE
7384 (Fformat_time_string): Remove now-unnecessary check.
7385 lisp_time_argument checks for out-of-range usec now.
243e0530 7386 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
7387 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
7388 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
7389 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
7390 (init_cmdargs, Fdump_emacs):
7391 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7392 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
7393 the bottom (typically) 32 bits of the fixnum.
7394 * eval.c (specpdl_size, call_debugger):
7395 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7396 (when_entered_debugger, Fbacktrace_debug):
7397 Don't assume fixnum can fit in int.
7398 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
7399 the object just before a buffer; this is not portable.
7400 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
7401 (grow_specpdl, unbind_to):
7402 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7403 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
7404 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 7405 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
7406 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
7407 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
7408 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7409 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
7410 (a_write, e_write):
7411 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7412 (Fcopy_file, non_regular_nbytes, read_non_regular)
7413 (Finsert_file_contents):
7414 Use int, not EMACS_INT, where int is wide enough.
7415 (READ_BUF_SIZE): Verify that it fits in int.
7416 (Finsert_file_contents): Check that counts are in proper range,
7417 rather than assuming fixnums fit into ptrdiff_t etc.
7418 Don't assume fixnums fit into int.
125b3835 7419 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
7420 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
7421 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
7422 (string_char_to_byte, string_byte_to_char)
7423 (string_make_multibyte, string_to_multibyte)
7424 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
7425 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
7426 (substring_both, Fdelete, internal_equal, Ffillarray)
7427 (Fclear_string, mapcar1)
7428 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
7429 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
7430 (larger_vector, make_hash_table, maybe_resize_hash_table)
7431 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
7432 (Fmaphash, secure_hash):
7433 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7434 (concat): Check for string index and length overflow.
7435 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
7436 (Frequire):
7437 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7438 (larger_vector): New API (vec, incr_min, size_max) replaces old
7439 one (vec, new_size, init). This catches size overflow.
7440 INIT was removed because it was always Qnil.
7441 All callers changed.
7442 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
7443 the upper bound on a hash table index size.
7444 (make_hash_table, maybe_resize_hash_table): Use it.
7445 (secure_hash): Computer start_byte and end_byte only after
7446 they're known to be in ptrdiff_t range.
7447 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
7448 (Ffont_get_glyphs, Ffont_at):
7449 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7450 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
7451 (Flist_fonts, Fopen_font):
7452 Don't assume fixnum can fit in int.
7453 (check_gstring): Don't assume index can fit in int.
7454 (font_match_p): Check that fixnum is a character, not a nonnegative
7455 fixnum, since the later code needs to stuff it into an int.
7456 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
7457 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
7458 conversion overflow issues.
7459 (Fopen_font): Check for integer out of range.
7460 (Ffont_get_glyphs): Don't assume index can fit in int.
7461 * font.h: Adjust decls to match defn changes elsewhere.
7462 * fontset.c (reorder_font_vector): Redo score calculation to avoid
7463 integer overflow.
7464 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
7465 printmax_t, where ptrdiff_t is wide enough.
7466 (Finternal_char_font):
7467 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7468 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
7469 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
7470 (Fset_frame_position, x_set_frame_parameters)
7471 (x_set_line_spacing, x_set_border_width)
7472 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
7473 Check that fixnums are in proper range for system types.
7474 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
7475 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7476 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
7477 Use SAFE_ALLOCA_LISP, not alloca.
7478 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
7479 intptr_t is wide enough.
7480 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
7481 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
7482 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
7483 Check for fixnum out of range.
7484 * ftfont.c (ftfont_list): Don't assume index fits in int.
7485 Check that fixnums are in proper range for system types.
7486 (ftfont_shape_by_flt):
7487 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
7488 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7489 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7490 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
7491 Check that fixnums are in proper range for system types.
7492 * gnutls.h: Adjust decls to match defn changes elsewhere.
7493 * gtkutil.c (xg_dialog_run):
7494 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7495 (update_frame_tool_bar):
7496 Check that fixnums are in proper range for system types.
7497 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 7498 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
7499 * indent.c (last_known_column, last_known_column_point):
7500 (current_column_bol_cache):
7501 (skip_invisible, current_column, check_display_width):
7502 (check_display_width, scan_for_column, current_column_1)
7503 (Findent_to, Fcurrent_indentation, position_indentation)
7504 (indented_beyond_p, Fmove_to_column, compute_motion):
7505 (Fcompute_motion, Fvertical_motion):
7506 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7507 (last_known_column_modified): Use EMACS_INT, not int.
7508 (check_display_width):
7509 (Fcompute_motion):
7510 Check that fixnums and floats are in proper range for system types.
7511 (compute_motion): Don't assume index or fixnum fits in int.
7512 (compute_motion, Fcompute_motion):
7513 Use int, not EMACS_INT, when it is wide enough.
7514 (vmotion): Omit local var start_hpos that is always 0; that way
7515 we don't need to worry about overflow in expressions involving it.
7516 * indent.h: Adjust decls to match defn changes elsewhere.
7517 (struct position):
7518 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7519 Use int, not EMACS_INT, where int is wide enough.
7520 Remove unused members ovstring_chars_done and tab_offset;
7521 all uses removed.
7522 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
7523 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
7524 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
7525 (make_gap, copy_text, insert, insert_and_inherit)
7526 (insert_before_markers, insert_before_markers_and_inherit)
7527 (insert_1, count_combining_before, count_combining_after)
7528 (insert_1_both, insert_from_string)
7529 (insert_from_string_before_markers, insert_from_string_1)
7530 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
7531 (adjust_after_replace, adjust_after_insert, replace_range)
7532 (replace_range_2, del_range, del_range_1, del_range_byte)
7533 (del_range_both, del_range_2, modify_region)
7534 (prepare_to_modify_buffer, signal_before_change)
7535 (signal_after_change, Fcombine_after_change_execute):
7536 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7537 * intervals.c (traverse_intervals, rotate_right, rotate_left)
7538 (balance_an_interval, split_interval_right, split_interval_left)
7539 (find_interval, next_interval, update_interval)
7540 (adjust_intervals_for_insertion, delete_node, delete_interval)
7541 (interval_deletion_adjustment, adjust_intervals_for_deletion)
7542 (static_offset_intervals, offset_intervals)
7543 (merge_interval_right, merge_interval_left, make_new_interval)
7544 (graft_intervals_into_buffer, temp_set_point_both)
7545 (temp_set_point, set_point, adjust_for_invis_intang)
7546 (set_point_both, move_if_not_intangible, get_property_and_range)
7547 (get_local_map, copy_intervals, copy_intervals_to_string)
7548 (compare_string_intervals, set_intervals_multibyte_1):
7549 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7550 * intervals.h: Adjust decls to match defn changes elsewhere.
7551 (struct interval):
7552 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7553 * keyboard.c (this_command_key_count, this_single_command_key_start)
7554 (before_command_key_count, before_command_echo_length, echo_now)
7555 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
7556 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
7557 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
7558 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
7559 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7560 (last_non_minibuf_size, last_point_position, echo_truncate)
7561 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
7562 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
7563 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
7564 (stuff_buffered_input):
7565 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7566 (last_auto_save, command_loop_1, read_char):
7567 Use EMACS_INT, not int, to avoid integer overflow.
7568 (record_char): Avoid overflow in total_keys computation.
7569 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
7570 * keyboard.h: Adjust decls to match defn changes elsewhere.
7571 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
7572 (Fkey_description, Fdescribe_vector, Flookup_key):
7573 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7574 (click_position): New function, to check that positions are in range.
7575 (Fcurrent_active_maps):
7576 (describe_command):
7577 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7578 (Faccessible_keymaps, Fkey_description):
7579 (preferred_sequence_p):
7580 Don't assume fixnum can fit into int.
7581 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
7582 Check for integer overflow in size calculations.
7583 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
7584 avoid mishandling large integers.
7585 * lisp.h: Adjust decls to match defn changes elsewhere.
7586 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
7587 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
7588 (struct Lisp_Marker):
7589 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7590 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
7591 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
7592 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
7593 All callers changed.
7594 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
7595 Assume the arg has valid form, since it always does.
7596 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
7597 unsigned integer system type.
7598 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
7599 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
7600 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7601 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
7602 (duration_to_sec_usec): New decl.
7603 * lread.c (read_from_string_index, read_from_string_index_byte)
7604 (read_from_string_limit, readchar, unreadchar, openp)
7605 (read_internal_start, read1, oblookup):
7606 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7607 (Fload, readevalloop, Feval_buffer, Feval_region):
7608 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7609 (openp): Check for out-of-range argument to 'access'.
7610 (read1): Use int, not EMACS_INT, where int is wide enough.
7611 Don't assume fixnum fits into int.
6efdadfd 7612 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
7613 (read_filtered_event): Use duration_to_sec_usec
7614 to do proper overflow checking on durations.
d311d28c
PE
7615 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
7616 in size calculation.
7617 (Fexecute_kbd_macro):
7618 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7619 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
7620 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
7621 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
7622 (set_marker_both, set_marker_restricted_both, marker_position)
7623 (marker_byte_position, Fbuffer_has_markers_at):
7624 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7625 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 7626 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
7627 It now merely ensures that the menu is large enough, without
7628 necessarily growing it, as this avoids some integer overflow issues.
7629 All callers changed.
7630 (keymap_panes, parse_single_submenu, Fx_popup_menu):
7631 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7632 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
7633 Use SAFE_ALLOCA_LISP, not alloca.
7634 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
7635 to EMACS_INT. Check that fixnums are in proper range for system types.
7636 * minibuf.c (minibuf_prompt_width, string_to_object)
7637 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
7638 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
7639 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7640 (get_minibuffer, read_minibuf_unwind):
7641 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7642 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
7643 this simplifies overflow checking. All callers changed.
7644 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
7645 (Ftest_completion):
7646 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7647 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
7648 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
7649 Check that fixnums are in proper range for system types.
7650 (Fx_create_frame, Fx_show_tip):
7651 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7652 * nsfont.m (ns_findfonts, nsfont_list_family):
7653 Don't assume fixnum fits in long.
7654 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
7655 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7656 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
7657 wide enough.
17fdb222 7658 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
7659 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7660 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
7661 (PRINTDECLARE, PRINTPREPARE):
7662 (strout, print_string):
7663 (print, print_preprocess, print_check_string_charset_prop)
7664 (print_object):
7665 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7666 (PRINTDECLARE):
7667 (temp_output_buffer_setup, Fprin1_to_string, print_object):
7668 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7669 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 7670 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 7671 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
7672 (print_error_message): Use SAFE_ALLOCA, not alloca.
7673 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
7674 (print_depth, new_backquote_output, print_number_index):
7675 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
7676 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
7677 (Fset_process_window_size, Fformat_network_address)
7678 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 7679 (sigchld_handler):
d311d28c 7680 Check that fixnums are in proper range for system types.
d44287d4 7681 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
7682 Check for process-ids out of pid_t range rather than relying on
7683 undefined behavior.
e4d81efc 7684 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
7685 (Fformat_network_address, read_process_output, send_process)
7686 (Fprocess_send_region, status_notify):
7687 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7688 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
7689 (wait_reading_process_output, read_process_output, exec_sentinel):
7690 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7691 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
7692 (Faccept_process_output): Use duration_to_sec_usec to do proper
7693 overflow checking on durations.
dde14581
PE
7694 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
7695 Don't assume pid_t fits in int.
02481186
PE
7696 * process.h (struct Lisp_Process): Members tick and update_tick
7697 are now of type EMACS_INT, not int.
b62b53e8
PE
7698 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
7699 configured --with-wide-int.
d311d28c
PE
7700 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
7701 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
7702 * search.c (looking_at_1, string_match_1):
7703 (fast_string_match, fast_c_string_match_ignore_case)
7704 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
7705 (scan_newline, find_before_next_newline, search_command)
7706 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
7707 (set_search_regs, wordify):
7708 (Freplace_match):
7709 (Fmatch_data):
7710 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7711 (string_match_1, search_buffer, set_search_regs):
7712 (Fmatch_data):
7713 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7714 (wordify): Check for overflow in size calculation.
7715 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
7716 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
7717 Check that fixnums are in proper range for system types.
7718 * sound.c (struct sound_device)
7719 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
7720 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7721 (Fplay_sound_internal):
7722 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 7723 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
7724 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
7725 (Fparse_partial_sexp):
7726 Don't assume fixnums can fit in int.
7727 (struct lisp_parse_state, find_start_pos, find_start_value)
7728 (find_start_value_byte, find_start_begv)
7729 (update_syntax_table, char_quoted, dec_bytepos)
7730 (find_defun_start, prev_char_comend_first, back_comment):
7731 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
7732 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
7733 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7734 (Finternal_describe_syntax_value): Check that match_lisp is a
7735 character, not an integer, since the code stuffs it into int.
7736 (scan_words, scan_sexps_forward):
7737 Check that fixnums are in proper range for system types.
7738 (Fforward_word):
7739 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7740 (scan_sexps_forward):
7741 Use CHARACTERP, not INTEGERP, since the value must fit into int.
7742 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
7743 * syntax.h: Adjust decls to match defn changes elsewhere.
7744 (struct gl_state_s):
7745 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
7746 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
7747 MOST_POSITIVE_FIXNUM.
d311d28c
PE
7748 * sysdep.c (wait_for_termination_1, wait_for_termination)
7749 (interruptible_wait_for_termination, mkdir):
7750 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
7751 (emacs_read, emacs_write):
7752 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
7753 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
7754 and double all fit in int.
d311d28c
PE
7755 * term.c (set_tty_color_mode):
7756 Check that fixnums are in proper range for system types.
7757 * termhooks.h (struct input_event):
7758 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7759 * textprop.c (validate_interval_range, interval_of)
7760 (Fadd_text_properties, set_text_properties_1)
7761 (Fremove_text_properties, Fremove_list_of_text_properties)
7762 (Ftext_property_any, Ftext_property_not_all)
7763 (copy_text_properties, text_property_list, extend_property_ranges)
7764 (verify_interval_modification):
7765 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7766 (Fnext_single_char_property_change)
7767 (Fprevious_single_char_property_change):
7768 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
7769 (copy_text_properties):
7770 Check for integer overflow in index calculation.
d311d28c
PE
7771 * undo.c (last_boundary_position, record_point, record_insert)
7772 (record_delete, record_marker_adjustment, record_change)
7773 (record_property_change):
7774 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7775 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
7776 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7777 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
7778 (Fx_hide_tip, Fx_file_dialog):
7779 * w32menu.c (set_frame_menubar):
7780 Use ptrdiff_t, not int, for consistency with rest of code.
7781 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
7782 (select_window, Fdelete_other_windows_internal)
7783 (window_scroll_pixel_based, window_scroll_line_based)
7784 (Frecenter, Fset_window_configuration):
7785 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7786 (Fset_window_hscroll, run_window_configuration_change_hook)
7787 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 7788 (Fscroll_other_window, Frecenter):
d311d28c
PE
7789 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7790 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
7791 Don't assume fixnum fits in int.
7792 (Fset_window_scroll_bars):
7793 Check that fixnums are in proper range for system types.
7794 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
7795 (string_pos, c_string_pos, number_of_chars, init_iterator)
7796 (in_ellipses_for_invisible_text_p, init_from_display_pos)
7797 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
7798 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
7799 (face_before_or_after_it_pos, handle_invisible_prop)
7800 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
7801 (display_prop_intangible_p, string_buffer_position_lim)
7802 (string_buffer_position, handle_composition_prop, load_overlay_strings)
7803 (get_overlay_strings_1, get_overlay_strings)
7804 (iterate_out_of_display_property, forward_to_next_line_start)
7805 (back_to_previous_visible_line_start, reseat, reseat_to_string)
7806 (get_next_display_element, set_iterator_to_next)
7807 (get_visually_first_element, compute_stop_pos_backwards)
7808 (handle_stop_backwards, next_element_from_buffer)
7809 (move_it_in_display_line_to, move_it_in_display_line)
7810 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7811 (add_to_log, message_dolog, message_log_check_duplicate)
7812 (message2, message2_nolog, message3, message3_nolog
7813 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
7814 (current_message_1, truncate_echo_area, truncate_message_1)
7815 (set_message, set_message_1, store_mode_line_noprop)
7816 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
7817 (text_outside_line_unchanged_p, check_point_in_composition)
7818 (reconsider_clip_changes)
7819 (redisplay_internal, set_cursor_from_row, try_scrolling)
7820 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
7821 (redisplay_window, find_last_unchanged_at_beg_row)
7822 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
7823 (trailing_whitespace_p, find_row_edges, display_line)
7824 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
7825 (display_mode_element, store_mode_line_string)
7826 (pint2str, pint2hrstr, decode_mode_spec)
7827 (display_count_lines, display_string, draw_glyphs)
7828 (x_produce_glyphs, x_insert_glyphs)
7829 (rows_from_pos_range, mouse_face_from_buffer_pos)
7830 (fast_find_string_pos, mouse_face_from_string_pos)
7831 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7832 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7833 (safe_call, init_from_display_pos, handle_fontified_prop)
7834 (handle_single_display_spec, load_overlay_strings)
7835 (with_echo_area_buffer, setup_echo_area_for_printing)
7836 (display_echo_area, echo_area_display)
7837 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
7838 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
7839 (redisplay_window, dump_glyph_row, display_mode_line)
7840 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 7841 (handle_display_spec, display_prop_string_p):
d311d28c
PE
7842 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7843 (handle_single_display_spec, build_desired_tool_bar_string)
7844 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
7845 (get_specified_cursor_type):
7846 Check that fixnums are in proper range for system types.
7847 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
7848 (Flookup_image_map):
7849 Don't assume fixnums fit in int.
7850 (compare_overlay_entries):
7851 Avoid mishandling comparisons due to subtraction overflow.
7852 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
7853 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
7854 (handle_tool_bar_click):
7855 Use int, not unsigned, since we prefer signed and the signedness
7856 doesn't matter here.
7857 (get_next_display_element, next_element_from_display_vector):
7858 Use int, not EMACS_INT, when int is wide enough.
7859 (start_hourglass): Use duration_to_sec_usec to do proper
7860 overflow checking on durations.
7861 * xfaces.c (Fbitmap_spec_p):
7862 Check that fixnums are in proper range for system types.
7863 (compare_fonts_by_sort_order):
7864 Avoid mishandling comparisons due to subtraction overflow.
7865 (Fx_family_fonts, realize_basic_faces):
7866 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7867 (Fx_family_fonts):
7868 Don't assume fixnum fits in int.
7869 Use SAFE_ALLOCA_LISP, not alloca.
7870 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
7871 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
7872 (face_at_buffer_position, face_for_overlay_string)
7873 (face_at_string_position):
7874 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7875 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
7876 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
7877 (Fx_show_tip):
7878 Check that fixnums are in proper range for system types.
7879 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
7880 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
7881 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7882 (Fx_change_window_property): Don't assume fixnums fit in int.
7883 * xfont.c (xfont_chars_supported):
7884 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7885 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
7886 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
7887 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7888 * xml.c (parse_region):
7889 * xrdb.c (magic_file_p):
7890 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7891 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
7892 (x_get_local_selection, x_reply_selection_request)
7893 (x_handle_selection_request, wait_for_property_change):
7894 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7895 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
7896 short is wide enough.
7897 (x_send_client_event): Don't assume fixnum fits in int.
7898 * xterm.c (x_x_to_emacs_modifiers):
7899 Don't assume EMACS_INT overflows nicely into int.
7900 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
7901 may come from Lisp.
7902 (handle_one_xevent): NATNUMP can eval its arg twice.
7903 (x_connection_closed):
7904 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7905 * xterm.h: Adjust decls to match defn changes elsewhere.
7906 (struct scroll_bar): Use struct vectorlike_header
7907 rather than rolling our own approximation.
7908 (SCROLL_BAR_VEC_SIZE): Remove; not used.
7909
c6574eb5
GM
79102012-05-25 Glenn Morris <rgm@gnu.org>
7911
7912 * lisp.mk (lisp): Update for more files being compiled now.
7913
e8d32c7e
SM
79142012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
7915
48def666
SM
7916 * lread.c: Remove `read_pure' which makes no difference.
7917 (read_pure): Remove var.
7918 (unreadpure): Remove function.
7919 (readevalloop): Don't call read_list with -1 flag.
7920 (read1, read_vector): Don't test read_pure any more.
7921 (read_list): Simplify.
7922
e8d32c7e
SM
7923 * fileio.c, character.h: Minor style tweaks.
7924
4b2addb7
DA
79252012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
7926
7927 * window.h (clip_changed): Remove useless declaration.
7928
584461b2
JB
79292012-05-22 Juanma Barranquero <lekktu@gmail.com>
7930
7931 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
7932 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
7933
34374650
PE
79342012-05-22 Paul Eggert <eggert@cs.ucla.edu>
7935
7936 Remove src/m/*.
7937 This directory predates autoconf and is no longer needed nowadays.
7938 Move its few remaining bits of functionality to where they're needed.
7939 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
7940 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
7941 * m/template.h: Remove.
7942 * Makefile.in (M_FILE): Remove. All uses removed.
7943 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
7944 * lisp.h (USE_LSB_TAG):
7945 * mem-limits.h (EXCEEDS_LISP_PTR):
7946 Use VAL_MAX, not VALBITS, in #if.
7947 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
7948 (EMACS_UINT): Define unconditionally now.
7949 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
7950 (BITS_PER_EMACS_INT): New constants, replacing
7951 what used to be in config.h, but not useful in #if.
7952 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
7953 define them any more.
7954 (VAL_MAX): New macro.
7955 (VALMASK): Use it.
7956 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
7957 BITS_PER_EMACS_INT, in #if.
7958 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
7959 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
7960 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
7961 * s/ms-w32.h (DATA_START):
7962 Move here from removed file m/intel386.h.
7963 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
7964 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
7965
261cb4bb
PE
79662012-05-21 Paul Eggert <eggert@cs.ucla.edu>
7967
7968 Assume C89 or later.
7969 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
7970 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
7971 (xrealloc):
7972 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
7973 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
7974 * textprop.c, tparam.c (NULL): Remove.
7975 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
7976 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
7977 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
7978 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
7979 * xterm.c (input_signal_count): Assume volatile works.
7980
ff23cd9f
KB
79812012-05-21 Ken Brown <kbrown@cornell.edu>
7982
7983 * xgselect.c (xg_select): Fix first argument in call to 'select'
7984 (bug#11508).
7985
1b170bc6
KB
79862012-05-20 Ken Brown <kbrown@cornell.edu>
7987
7988 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 7989 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 7990
b2f4d39f
KB
79912012-05-19 Ken Brown <kbrown@cornell.edu>
7992
7993 * xfns.c (x_in_use): Remove `static' qualifier.
7994 * xterm.h (x_in_use): Declare.
7995 * xgselect.c: Include xterm.h.
7996 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
7997 and `display_arg' (bug#9754).
7998
003fdae2
PE
79992012-05-19 Paul Eggert <eggert@cs.ucla.edu>
8000
9232a6d9
PE
8001 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
8002
003fdae2
PE
8003 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
8004 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
8005
784b56e2
EZ
80062012-05-18 Eli Zaretskii <eliz@gnu.org>
8007
8008 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
8009
8010 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 8011 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
8012
8013 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
8014 reference to image_cache->refcount.
8015 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
8016
a0a79cde
JL
80172012-05-17 Juri Linkov <juri@jurta.org>
8018
8019 * search.c (Fword_search_regexp, Fword_search_backward)
8020 (Fword_search_forward, Fword_search_backward_lax)
8021 (Fword_search_forward_lax): Move functions to isearch.el
8022 (bug#10145, bug#11381).
8023
b0572523
PE
80242012-05-16 Paul Eggert <eggert@cs.ucla.edu>
8025
8026 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
8027
9660f5fc
SM
80282012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
8029
8030 * lread.c (init_obarray): Declare Qt and Qnil as special.
8031
4374de83
GM
80322012-05-14 Glenn Morris <rgm@gnu.org>
8033
8034 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 8035 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 8036
dc44c39a
PE
80372012-05-14 Paul Eggert <eggert@cs.ucla.edu>
8038
078c97cb
PE
8039 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
8040
dc44c39a
PE
8041 * unexaix.c: Port to more-recent AIX compilers.
8042 (report_error, report_error_1, make_hdr, copy_sym)
8043 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
8044 Make arguments const char *, not char *, to avoid violations of C
8045 standard and to fix some AIX warnings reported by Gilles Pion.
8046
e18afed7 80472012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
8048
8049 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
8050 already have overlays loaded.
8051 (handle_single_display_spec): Before returning without displaying
8052 fringe bitmap, synchronize the bidi iterator with the main display
8053 iterator, by calling iterate_out_of_display_property.
8054 (iterate_out_of_display_property): Detect buffer iteration by
8055 testing that it->string is a Lisp string.
8056 (get_next_display_element): When the current object is exhausted,
8057 and there's something on it->stack, call set_iterator_to_next to
8058 proceed with what's on the stack, instead of returning zero.
8059 (set_iterator_to_next): If called at the end of a Lisp string,
8060 proceed to consider_string_end without incrementing string
8061 position. Don't increment display vector index past the end of
8062 the display vector. (Bug#11417)
c8fb9dc6
EZ
8063 (pos_visible_p): Don't report a position visible when move_it_to
8064 stopped at the last line of window, which happens to be scanned
8065 backwards by the bidi iteration. (Bug#11464)
ac268e67 8066
e18afed7 80672012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
8068
8069 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
8070 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
8071 are on a TTY, and thus unable to display on the fringes.
8072 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
8073 so we need to signal to the caller that this is a "replacing"
8074 display spec. This fixes display when the spec is invalid or we
8075 are on a TTY.
8076
e18afed7 80772012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
8078
8079 * unexaix.c (make_hdr): Fix typo in prototype.
8080 This bug broke the build on AIX. Problem reported by Gilles Pion.
8081
9d0a235a
MA
80822012-05-14 Michael Albinus <michael.albinus@gmx.de>
8083
8084 * keyboard.c (kbd_buffer_get_event): Read special events also in
8085 batch mode. (Bug#11415)
8086
9e6b06ed
GM
80872012-05-12 Glenn Morris <rgm@gnu.org>
8088
8089 * ns.mk: Update for ns_appbindir no longer having trailing "/".
8090
c1a1d7a3
EZ
80912012-05-12 Eli Zaretskii <eliz@gnu.org>
8092
8093 * lisp.mk (lisp): Add newcomment.elc.
8094
3fe7cdc8
GM
80952012-05-12 Glenn Morris <rgm@gnu.org>
8096
8097 * Makefile.in (MKDIR_P): New, set by configure.
8098 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
8099
53f7d2c0
PE
81002012-05-11 Paul Eggert <eggert@cs.ucla.edu>
8101
8102 Remove unused function hourglass_started.
8103 * dispextern.h (hourglass_started):
8104 * w32fns.c (hourglass_started):
8105 * xdisp.c (hourglass_started): Remove.
8106
75aafb17
JB
81072012-05-10 Juanma Barranquero <lekktu@gmail.com>
8108
8109 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
8110 Update dependencies.
8111
12959e8e
PE
81122012-05-10 Paul Eggert <eggert@cs.ucla.edu>
8113
97107e2e
PE
8114 * xgselect.c (xg_select): Put maxfds+1 into a var.
8115 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
8116
12959e8e
PE
8117 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
8118
836d29b3
DA
81192012-05-10 Dave Abrahams <dave@boostpro.com>
8120
8121 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
8122 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
8123
5cb67954
MA
81242012-05-09 Michael Albinus <michael.albinus@gmx.de>
8125
8126 * dbusbind.c (xd_registered_buses): New internal Lisp object.
8127 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
8128 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
8129 Initialize xd_registered_buses.
8130
3478ec45
PE
81312012-05-09 Paul Eggert <eggert@cs.ucla.edu>
8132
b263a6b0
PE
8133 Untag more efficiently if USE_LSB_TAG.
8134 This is based on a proposal by YAMAMOTO Mitsuharu in
8135 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
8136 For an admittedly artificial (nth 8000 longlist) benchmark on
8137 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
8138 Emacs's overall text size by 1%.
8139 * lisp.h (XUNTAG): New macro.
8140 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
8141 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
8142 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
8143 * eval.c (Fautoload):
8144 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
8145 * frame.h (XFRAME): Use XUNTAG.
8146
3478ec45
PE
8147 Port recent dbusbind.c changes to 32-bit --with-wide-int.
8148 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
8149 Remove unportable assumptions about print widths of types like
8150 dbus_uint32_t.
8151 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
8152 intptr_t when converting between pointer and integer, to avoid GCC
8153 warnings about wrong width.
8154
666b903b 81552012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
8156
8157 * w32proc.c (new_child): Force Windows to reserve only 64KB of
8158 stack for each reader_thread, instead of defaulting to 8MB
8159 determined by the linker. This avoids failures in creating
8160 subprocesses on Windows 7, see the discussion in this thread:
8161 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
8162
b120cc17
JC
81632012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
8164
8165 Fix up display of the *Minibuf-0* buffer in the mini window.
8166 * keyboard.c (read_char): Don't clear the echo area if there's no
8167 message to clear.
8168 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 8169 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 8170
9a4b36f8
MA
81712012-05-07 Michael Albinus <michael.albinus@gmx.de>
8172
8173 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
8174 batch mode.
8175
e5f9458f
CY
81762012-05-06 Chong Yidong <cyd@gnu.org>
8177
8178 * lisp.mk (lisp): Update.
8179
eceeb5fc 81802012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
8181
8182 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
8183
71873e2b
SM
81842012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
8185
8186 * data.c (PUT_ERROR): New macro.
8187 (syms_of_data): Use it. Add new error type `user-error'.
8188 * undo.c (user_error): New function.
8189 (Fprimitive_undo): Use it.
8190 * print.c (print_error_message): Adjust print style for `user-error'.
8191 * keyboard.c (user_error): New function.
8192 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
8193
ab0fa4e4
PE
81942012-05-03 Paul Eggert <eggert@cs.ucla.edu>
8195
8196 Do not limit current-time-string to years 1000..9999.
8197 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
8198 (Fcurrent_time_string): Support any year that is supported by the
8199 underlying localtime representation. Don't use asctime, as it
8200 has undefined behavior for years outside the range -999..9999.
8201
7ed806a7
PE
82022012-05-02 Paul Eggert <eggert@cs.ucla.edu>
8203
8204 Fix race conditions involving setenv, gmtime, localtime, asctime.
8205 Without this fix, interrupts could mess up code that uses these
8206 nonreentrant functions, since setting TZ invalidates existing
8207 tm_zone or tzname values, and since most of these functions return
8208 pointers to static storage.
8209 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
8210 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
8211 Grow the critical sections to include not just invoking
8212 localtime/gmtime, but also accessing these functions' results
8213 including their tm_zone values if any, and any related TZ setting.
8214 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
8215 so that the struct tm is saved in the critical section.
8216 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
8217 motivated by the fact that memory allocation needs to be outside
8218 the critical section.
8219
0c16dfed
DA
82202012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
8221
8222 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
8223 with RESET_INTERVAL.
8224
8225 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8226 Remove duplicated buffer name initialization.
8227
3f83ace8
JM
82282012-05-02 Jim Meyering <jim@meyering.net>
8229
8230 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
8231
c7b8541e
JM
8232 * xfns.c (x_window): Use xstrdup (Bug#11375).
8233
90207a15 82342012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
8235
8236 * xdisp.c (pos_visible_p): If already at a newline from the
8237 display string before the 'while' loop, don't walk back the glyphs
8238 from it3.glyph_row. Solves assertion violation when the display
8239 string begins with a newline (egg.el). (Bug#11367)
8240
b593d6a9
AH
82412012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
8242
8243 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
8244 Move to simple.el.
8245
4737362e
GM
82462012-05-01 Glenn Morris <rgm@gnu.org>
8247
99cf43f9
GM
8248 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
8249 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
8250 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
8251 All were removed before 23.1.
8252
9311dcff
GM
8253 * dispnew.c: Remove HAVE_LIBNCURSES test;
8254 it is always true on relevant platforms.
8255
4d5c6349
GM
8256 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
8257 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
8258
4737362e
GM
8259 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
8260
74dd3a6b
AS
82612012-04-30 Andreas Schwab <schwab@linux-m68k.org>
8262
8263 * .gdbinit (xpr): Remove checks for no longer existing misc types.
8264 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
8265 Remove.
8266
13c379ee
PE
82672012-04-28 Paul Eggert <eggert@cs.ucla.edu>
8268
8269 Do not avoid creating empty evaporating overlays (Bug#9642).
8270 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
8271 That is, do not delete an evaporating overlay if it becomes
8272 empty after its bounds are adjusted to fit within its buffer.
8273 This fix caused other problems, and I'm reverting it until we get
8274 to the bottom of them.
8275
a8e7d6d7 82762012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
8277
8278 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
8279
a8e7d6d7 82802012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
8281
8282 * xdisp.c (pos_visible_p): If the window start position is beyond
8283 ZV, start the display from buffer beginning. Prevents assertion
8284 violation in init_iterator when the minibuffer window is scrolled
8285 via the scroll bar.
8286
8287 * window.c (window_scroll_pixel_based): Likewise.
8288
a8e7d6d7 82892012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
8290
8291 * keymap.c (where_is_internal): Doc fix (Bug#10872).
8292
a8e7d6d7 82932012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
8294
8295 * fileio.c (Fcopy_file, Fset_file_selinux_context):
8296 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
8297
a8e7d6d7 82982012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 8299
b593d6a9
AH
8300 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
8301 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 8302
1c6900d9
EZ
83032012-04-26 Eli Zaretskii <eliz@gnu.org>
8304
4c3fa1d9
EZ
8305 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
8306 display element, check also the underlying string or buffer
8307 character. (Bug#11341)
8308
1c6900d9
EZ
8309 * w32menu.c: Include w32heap.h.
8310 (add_menu_item): If the call to AppendMenuW (via
8311 unicode_append_menu) fails, disable Unicode menus only if we are
8312 running on Windows 9X/Me.
8313
42bf8205
AS
83142012-04-24 Andreas Schwab <schwab@linux-m68k.org>
8315
8316 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
8317 (xgetint): Add missing shift for LSB tags.
8318
b1bac16e
MR
83192012-04-24 Martin Rudalics <rudalics@gmx.at>
8320
8321 * keyboard.c (read_char): Don't wipe echo area for select window
8322 events: These might get delayed via `mouse-autoselect-window'
8323 (Bug#11304).
8324
d69621cc
JB
83252012-04-24 Juanma Barranquero <lekktu@gmail.com>
8326
8327 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
8328 manipulation of :loaded-from data.
8329
02fd101b
JB
83302012-04-23 Juanma Barranquero <lekktu@gmail.com>
8331
8332 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
8333 now a cons (bug#11311).
8334
888bec30
PE
83352012-04-23 Paul Eggert <eggert@cs.ucla.edu>
8336
89a438bd
PE
8337 Do not create empty overlays with the evaporate property (Bug#9642).
8338 * buffer.c (Fmove_overlay): Delete an evaporating overlay
8339 if it becomes empty after its bounds are adjusted to fit within
8340 its buffer. Without this fix, in a nonempty buffer (let ((o
8341 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
8342 yields an empty overlay that has the evaporate property, which is
8343 not supposed to happen.
8344
1068fe4d
PE
8345 Fix minor GTK3 problems found by static checking.
8346 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
8347 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
8348 (struct _EmacsFixedClass, emacs_fixed_get_type):
8349 Move decls here from emacsgtkfixed.h, since they needn't be public.
8350 (emacs_fixed_get_type): Now static.
8351 (emacs_fixed_class_init): Omit unused local.
8352 (emacs_fixed_child_type): Remove; unused.
8353 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
8354 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
8355 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
8356 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
8357 (EMACS_FIXED_GET_CLASS): Remove; unused.
8358 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
8359
888bec30
PE
8360 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
8361 Problem reported by Juanma Barranquero for Windows -Wunused-function.
8362
de85e130
PE
83632012-04-22 Paul Eggert <eggert@cs.ucla.edu>
8364
d0baac98 8365 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 8366 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
8367 (__malloc_size_t, __malloc_ptrdiff_t):
8368 Remove. All uses removed, replaced by the definiens if needed,
8369 since we can assume C89 or better now.
8370 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
8371 (protect_malloc_state, align, get_contiguous_space)
8372 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
8373 (malloc_atfork_handler_child, malloc_enable_thread)
8374 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
8375 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
8376 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
8377 (special_realloc, _realloc_internal_nolock, _realloc_internal)
8378 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
8379 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
8380 Define using prototypes, not old style.
8381 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
8382 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
8383 (align): Don't assume that signed integer overflow wraps around.
8384 Omit unused local var.
8385 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
8386 (_free_internal_nolock, memalign, mallochook, reallochook):
8387 Omit no-longer-needed casts.
8388 (valloc): Use getpagesize, not __getpagesize.
8389 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
8390 (struct hdr): The 'magic' member is now size_t, not unsigned long.
8391
de85e130
PE
8392 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
8393
dcbf5805
MA
83942012-04-22 Michael Albinus <michael.albinus@gmx.de>
8395
8396 Move functions from C to Lisp. Make non-blocking method calls
8397 the default. Implement further D-Bus standard interfaces.
8398
8399 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
8400 (QCdbus_request_name_allow_replacement)
8401 (QCdbus_request_name_replace_existing)
8402 (QCdbus_request_name_do_not_queue)
8403 (QCdbus_request_name_reply_primary_owner)
8404 (QCdbus_request_name_reply_in_queue)
8405 (QCdbus_request_name_reply_exists)
8406 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
8407 (QCdbus_registered_serial, QCdbus_registered_method)
8408 (QCdbus_registered_signal): New Lisp objects.
8409 (XD_DEBUG_MESSAGE): Use sizeof.
8410 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
8411 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
8412 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
8413 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
8414 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
8415 (xd_signature, xd_append_arg): Allow float for integer types.
8416 (xd_get_connection_references): New function.
b593d6a9
AH
8417 (xd_get_connection_address): Rename from xd_initialize.
8418 Return cached address.
dcbf5805
MA
8419 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
8420 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
8421 level.
8422 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 8423 Return number of refcounts.
dcbf5805
MA
8424 (Fdbus_get_unique_name): Make stronger parameter check.
8425 (Fdbus_message_internal): New defun.
8426 (Fdbus_call_method, Fdbus_call_method_asynchronously)
8427 (Fdbus_method_return_internal, Fdbus_method_error_internal)
8428 (Fdbus_send_signal, Fdbus_register_service)
8429 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
8430 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
8431 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
8432 (Vdbus_compiled_version, Vdbus_runtime_version)
8433 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
8434 (Vdbus_message_type_method_return, Vdbus_message_type_error)
8435 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
8436 (Vdbus_registered_buses, Vdbus_registered_objects_table):
8437 Adapt docstring.
dcbf5805 8438
52828e02
PE
84392012-04-22 Paul Eggert <eggert@cs.ucla.edu>
8440
da05bc4c
PE
8441 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
8442 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
8443 Do not assume ptrdiff_t is the same width as 'int'.
8444
52828e02
PE
8445 * alloc.c: Handle unusual debugging option combinations.
8446 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
8447 since the two debugging options are incompatible.
8448 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
8449 is defined.
8450 (mem_init, mem_insert, mem_insert_fixup):
8451 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
8452 (NEED_MEM_INSERT): Remove; no longer needed.
8453
f01769f9
LL
84542012-04-22 Leo Liu <sdl.web@gmail.com>
8455
8456 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
8457
5790543d
PE
84582012-04-22 Paul Eggert <eggert@cs.ucla.edu>
8459
8460 * sysdep.c [__FreeBSD__]: Minor cleanups.
8461 (list_system_processes, system_process_attributes) [__FreeBSD__]:
8462 Use Emacs indenting style more consistently. Avoid some casts.
8463 Use 'double' consistently rather than mixing 'float' and 'double'.
8464
b91b7e4d
EW
84652012-04-21 Eduard Wiebe <usenet@pusto.de>
8466
b593d6a9
AH
8467 * sysdep.c (list_system_processes, system_process_attributes):
8468 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 8469
6114eb15
AS
84702012-04-21 Andreas Schwab <schwab@linux-m68k.org>
8471
8472 * lisp.mk (lisp): Update.
8473
2f38dff7
PE
84742012-04-20 Paul Eggert <eggert@cs.ucla.edu>
8475
8476 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
8477 It is never used otherwise.
8478
4ae29f89
SM
84792012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
8480
8481 * print.c (print_preprocess): Only check print_depth if print-circle
8482 is nil.
8483 (print_object): Check for cycles even when print-circle is nil and
8484 print-gensym is t, but only check print_depth if print-circle is nil.
8485
f30d612a
CY
84862012-04-20 Chong Yidong <cyd@gnu.org>
8487
8488 * process.c (wait_reading_process_output): If EIO occurs on a pty,
8489 set the status to "failed" and ensure that sentinel is run.
8490
c07a4c0b 84912012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
8492
8493 * process.c (Fset_process_inherit_coding_system_flag)
8494 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 8495 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 8496
c07a4c0b 84972012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
8498
8499 * xdisp.c (string_buffer_position_lim): Limit starting position to
8500 BEGV.
8501 (set_cursor_from_row): If called for a mode-line or header-line
8502 row, return zero immediately.
8503 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
8504 farther than the first row after the header line, if any.
8505 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
8506 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
8507
c07a4c0b 85082012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 8509
4ae29f89
SM
8510 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
8511 (bug#11238).
ad3a2b41 8512
c07a4c0b 85132012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 85142012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
8515
8516 configure: new option --enable-gcc-warnings (Bug#11207)
8517 * Makefile.in (C_WARNINGS_SWITCH): Remove.
8518 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
8519 (ALL_CFLAGS): Use new macros rather than old.
8520 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
8521 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
8522 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
8523 -Wunused-result, -Wunused-variable. This should go away once
8524 the Emacs and Gnulib regex code is merged.
8525 (xmalloc, xrealloc): Now static.
8526
aba027e8
PE
85272012-04-17 Paul Eggert <eggert@cs.ucla.edu>
8528
8529 * dired.c (Fsystem_groups): Remove unused local.
8530
e5a36063
GM
85312012-04-17 Glenn Morris <rgm@gnu.org>
8532
8533 * dired.c (Fsystem_users): Doc fix.
8534
316411f0
DA
85352012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
8536
8537 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
8538 (syms_of_dired): Add them.
8539
9426aba4
PE
85402012-04-16 Paul Eggert <eggert@cs.ucla.edu>
8541
b62a57be
PE
8542 Fix minor alloc.c problems found by static checking.
8543 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
8544 New extern decls, to avoid calling undeclared functions.
8545 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
8546 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
8547 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
8548 (NEED_MEM_INSERT): New macro.
8549 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 8550 Remove one incorrect comment and fix another.
b62a57be 8551
3539f31f
PE
8552 Fix minor ralloc.c problems found by static checking.
8553 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
8554 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
8555 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
8556 (r_alloc_sbrk): Now static.
8557
a041960a
PE
8558 Improve ralloc.c interface checking.
8559 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
8560 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
8561 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
8562 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
8563 [REL_ALLOC]: ... to here, to check interface.
8564 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
8565 Remove decls. This fixes an "It stinks!".
8566
9426aba4
PE
8567 * alloc.c (which_symbols): Fix alignment issue / type clash.
8568
d55c12ed
AS
85692012-04-15 Andreas Schwab <schwab@linux-m68k.org>
8570
8571 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
8572 (struct Lisp_Misc_Any): Likewise.
8573 (struct Lisp_Free): Likewise.
8574 * alloc.c (union aligned_Lisp_Symbol): Define.
8575 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
8576 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
8577 (union aligned_Lisp_Misc): Define.
8578 (MARKER_BLOCK_SIZE, struct marker_block): Use union
8579 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 8580 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 8581
b948ce8b
PE
85822012-04-14 Paul Eggert <eggert@cs.ucla.edu>
8583
8584 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
8585 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
8586 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
8587 * s/netbsd.h, s/sol2-6.h:
8588 Remove definition of GC_MARK_STACK, since the default now works.
8589 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
8590 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
8591 no longer the default.
8592 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
8593
35dc09a1 85942012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 8595
35dc09a1
GM
8596 * lread.c (lisp_file_lexically_bound_p):
8597 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 8598
35dc09a1
GM
85992012-04-14 Eli Zaretskii <eliz@gnu.org>
8600
8601 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
8602 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
8603
86042012-04-14 Jan Djärv <jan.h.d@swipnet.se>
8605
8606 * nsterm.m (constrainFrameRect): Always constrain when there is only
8607 one screen (Bug#10962).
8608
bcd86815
KB
86092012-04-13 Ken Brown <kbrown@cornell.edu>
8610
8611 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
8612
c25df26e
RT
86132012-04-13 Reuben Thomas <rrt@sc3d.org>
8614
8615 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
8616
0fc59f1e
DC
86172012-04-11 Daniel Colascione <dancol@dancol.org>
8618
8619 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
8620 against is gone. It's better to use vfork now so that when Cygwin
8621 gains a new, working vfork, we use it automatically (bug#10398).
8622
de8c03dc
SM
86232012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
8624
8625 * window.c (save_window_save): Obey window-point-insertion-type.
8626
2f097256
GM
86272012-04-11 Glenn Morris <rgm@gnu.org>
8628
8629 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
8630
453b951e
SM
86312012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
8632
8633 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
8634
75f1671a 86352012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
8636
8637 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
8638 (force_quit_count): New var.
8639 (handle_interrupt): Use it.
8640
2a8ce227
JB
86412012-04-10 Juanma Barranquero <lekktu@gmail.com>
8642
8643 * w32.c (w32_delayed_load): Record the full path of the library
8644 being loaded (bug#10424).
8645
935396c0
GM
86462012-04-09 Glenn Morris <rgm@gnu.org>
8647
05920a43
GM
8648 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
8649 not just in the obarray, before snarfing them. (Bug#11036)
8650
935396c0
GM
8651 * Makefile.in ($(leimdir)/leim-list.el):
8652 Pass EMACS rather than BUILT_EMACS.
8653
a18ecafa
TZ
86542012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
8655
8656 * process.c (make_process):
8657 * process.h: Add integer `gnutls_handshakes_tried' member to
8658 process struct.
8659
6bbef4e5
JC
8660 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
8661 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
8662
8663 * gnutls.c (gnutls_log_function2i): Convenience log function.
8664 (emacs_gnutls_read): Use new log functions,
8665 `gnutls_handshakes_tried' process member, and
8666 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
8667 attempts per process (connection).
8668
b4d3bc10
CY
86692012-04-09 Chong Yidong <cyd@gnu.org>
8670
8671 * eval.c (Fuser_variable_p, user_variable_p_eh)
8672 (lisp_indirect_variable): Functions deleted.
8673 (Fdefvar): Caller changed.
8674
8675 * callint.c (Finteractive, Fcall_interactively):
8676 * minibuf.c (Fread_variable): Callers changed.
8677
70f4d973
EZ
86782012-04-09 Eli Zaretskii <eliz@gnu.org>
8679
8680 * xdisp.c (set_cursor_from_row): If the display string appears in
8681 the buffer at position that is closer to point than the position
8682 after the display string, display the cursor on the first glyph of
8683 the display string. Fixes cursor display when a 'display' text
8684 property immediately follows invisible text. (Bug#11094)
8685
cb3c2e3e
PE
86862012-04-09 Paul Eggert <eggert@cs.ucla.edu>
8687
8688 composite.c: use 'double' consistently
8689 * composite.c (get_composition_id): Use 'double' consistently
8690 instead of converting 'float' to 'double' and vice versa; this is
8691 easier to understand and avoids a GCC warning.
8692
fd06db5d
GM
86932012-04-09 Glenn Morris <rgm@gnu.org>
8694
50fe702a
GM
8695 * Makefile.in: Generate leim-list with bootstrap-emacs, in
8696 preparation for dumping it with emacs. (Bug#4789)
8697 (leimdir): New variable.
8698 ($(leimdir)/leim-list.el): New rule.
8699 (emacs$(EXEEXT)): Depend on leim-list.el.
8700
fd06db5d
GM
8701 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
8702 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
8703 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
8704
55c131ee
AS
87052012-04-08 Andreas Schwab <schwab@linux-m68k.org>
8706
8707 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
8708 proper alignment.
8709
9209588f
JB
87102012-04-07 Juanma Barranquero <lekktu@gmail.com>
8711
8712 * xml.c (init_libxml2_functions) [WINDOWSNT]:
8713 Remove unused local variable.
8714
e3fb2efb
PE
87152012-04-07 Paul Eggert <eggert@cs.ucla.edu>
8716
8717 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
8718 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
8719 (mark_memory): Mark Lisp_Objects only if pointers might hide in
8720 objects, as mark_maybe_pointer will catch them otherwise.
8721 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
8722 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
8723
b5385551
PE
87242012-04-07 Paul Eggert <eggert@cs.ucla.edu>
8725
8726 Fix typo that broke non-Windows builds.
8727 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
8728
9078ead6
EZ
87292012-04-07 Eli Zaretskii <eliz@gnu.org>
8730
8731 Support building on MS-Windows with libxml2.
8732
8733 * makefile.w32-in (OBJ2): Add xml.$(O).
8734 (GLOBAL_SOURCES): Add xml.c.
8735 ($(BLD)/xml.$(O)): New dependency list.
8736
8737 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
8738 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
8739 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
8740 [!WINDOWSNT]: New macros.
8741 (init_libxml2_functions, libxml2_loaded_p): New functions.
8742 (parse_region): Call fn_xmlCheckVersion instead of using the macro
8743 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
8744 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
8745 Calls xmlCleanupParser only if libxml2 was loaded (or statically
8746 linked in).
6bbef4e5
JC
8747 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
8748 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
8749 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
8750
8751 * emacs.c: Don't include libxml/parser.h.
8752 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
8753 xmlCleanupParser directly.
8754
8755 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
8756
3811fdf3
EZ
87572012-04-07 Eli Zaretskii <eliz@gnu.org>
8758
8759 * indent.c (Fvertical_motion): If there is a display string at
8760 point, use it.vpos to compute how many lines to backtrack after
8761 move_it_to point. (Bug#11133)
8762
2f8e16b2
EZ
87632012-04-06 Eli Zaretskii <eliz@gnu.org>
8764
8765 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
8766 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
8767 about subtle differences between FETCH_CHAR* and STRING_CHAR*
8768 macros related to unification of CJK characters. For the details,
8769 see the discussion following the message here:
8770 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
8771
3d439cd1
CY
87722012-04-04 Chong Yidong <cyd@gnu.org>
8773
8774 * keyboard.c (Vdelayed_warnings_list): Doc fix.
8775
8bc53d00
EZ
87762012-04-01 Eli Zaretskii <eliz@gnu.org>
8777
8778 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
8779 instead of alloca. (Bug#11138)
8780
3b0512a3
AS
87812012-04-01 Andreas Schwab <schwab@linux-m68k.org>
8782
8783 * w32menu.c (is_simple_dialog): Properly check lisp types.
8784 (Bug#11141)
8785
8427ddd2
EZ
87862012-03-31 Eli Zaretskii <eliz@gnu.org>
8787
979022ef
EZ
8788 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
8789 position we get to after a call to move_it_to fails the
8790 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
8791 only if we wind up in a string from display property. (Bug#11063)
8792
a6b1c7cc
EZ
8793 * window.c (Fdelete_other_windows_internal): Invalidate the row
8794 and column information about mouse highlight, so that redisplay
8795 restores it after reallocating the glyph matrices. (Bug#7464)
8796
8427ddd2
EZ
8797 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
8798 string comes from a `display' text property, use the buffer
8799 position of that property as if we actually saw that position in
8800 the row's glyphs.
697ba24b
EZ
8801 (move_it_by_lines): Remove the assertion that
8802 "it->current_x == 0 && it->hpos == 0" which can be legitimately
8803 violated when there's a before-string at the beginning of a line.
8804 (Bug#11063)
8427ddd2 8805
65a0a738
EZ
88062012-03-30 Eli Zaretskii <eliz@gnu.org>
8807
8808 * xdisp.c (append_space_for_newline): If the default face was
8809 remapped, use the remapped face for the appended newline.
8810 (extend_face_to_end_of_line): Use the remapped default face for
8811 extending the face to the end of the line.
8812 (display_line): Call extend_face_to_end_of_line when the default
8813 face was remapped. (Bug#11068)
8814
581355cc
EZ
88152012-03-29 Eli Zaretskii <eliz@gnu.org>
8816
8817 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
8818
e8fc049f
SM
88192012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8820
8821 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
8822
4fb9a543
GM
88232012-03-27 Glenn Morris <rgm@gnu.org>
8824
8825 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
8826 Doc fixes.
8827
679910f1
KH
88282012-03-26 Kenichi Handa <handa@m17n.org>
8829
8830 * dispextern.h (struct glyph): Fix previous change. Change the
8831 bit length of glyphless.ch to 25 (Bug#11082).
8832
90d49b7f
CY
88332012-03-26 Chong Yidong <cyd@gnu.org>
8834
8835 * keyboard.c (Vselection_inhibit_update_commands): New variable.
8836 (command_loop_1): Use it; inhibit selection update for
8837 handle-select-window too (Bug#8996).
8838
f514f6f0
FP
88392012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
8840
e8fc049f 8841 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 8842
bf43fa51
KH
88432012-03-25 Kenichi Handa <handa@m17n.org>
8844
8845 * dispextern.h (struct glyph): Change the bit length of
8846 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
8847
8a0c01dd
EZ
88482012-03-24 Eli Zaretskii <eliz@gnu.org>
8849
8850 * s/ms-w32.h (tzname): Include time.h before redirecting to
8851 _tzname. Fixes the MSVC build. (Bug#9960)
8852
7d1c3a76
AS
88532012-03-24 Andreas Schwab <schwab@linux-m68k.org>
8854
8ed79523
AS
8855 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
8856 characters.
8857
7d1c3a76
AS
8858 * xterm.c (XTread_socket): Only modify handling_signal if
8859 !SYNC_INPUT. (Bug#11080)
8860
e99a9b8b
EZ
88612012-03-23 Eli Zaretskii <eliz@gnu.org>
8862
8863 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
8864 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
8865 when fetching a multibyte character consumes more bytes than
8866 CHAR_BYTES returns, due to unification of CJK characters in
8867 string_char. (Bug#11073)
8868
5063c0e1
TN
88692012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
8870
8871 * process.c (wait_reading_process_output): Handle pty disconnect
8872 by refraining from sending oneself a SIGCHLD (bug#10933).
8873
9f851fbd
CY
88742012-03-22 Chong Yidong <cyd@gnu.org>
8875
8876 * dispextern.h (struct it): New member string_from_prefix_prop_p.
8877
5063c0e1 8878 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
8879 Mark string as coming from a prefix property.
8880 (handle_face_prop): Use default face for prefix strings (Bug#4281).
8881 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
8882
fb5b8aca
CY
88832012-03-21 Chong Yidong <cyd@gnu.org>
8884
8885 * xfaces.c (Vface_remapping_alist): Doc fix.
8886
62356a1b
EZ
88872012-03-20 Eli Zaretskii <eliz@gnu.org>
8888
8889 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
8890 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
8891 Doc fixes.
62356a1b 8892
025de85b
CY
88932012-03-20 Chong Yidong <cyd@gnu.org>
8894
8895 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
8896 to reflect default non-nil value of redisplay-dont-pause.
8897
4827f94e
KH
88982012-03-19 Kenichi Handa <handa@m17n.org>
8899
8900 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
8901 it fit in a valid range (Bug#11003).
8902
e50a24a2
EZ
89032012-03-18 Eli Zaretskii <eliz@gnu.org>
8904
8905 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
8906 that is not from display property, accept the row as a "cursor
8907 row" if one of the string's character has a non-nil `cursor'
8908 property. Fixes cursor positioning when there are newlines in
8909 overlay strings, e.g. in icomplete.el. (Bug#11035)
8910
9af5ed87
PE
89112012-03-12 Paul Eggert <eggert@cs.ucla.edu>
8912
8913 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
8914
d1f55f16
CY
89152012-03-12 Chong Yidong <cyd@gnu.org>
8916
8917 * eval.c (inhibit_lisp_code): Rename from
8918 inhibit_window_configuration_change_hook; move from window.c.
8919
8920 * xfns.c (unwind_create_frame_1, Fx_create_frame):
8921 * window.c (run_window_configuration_change_hook)
8922 (syms_of_window): Callers changed.
8923
66c5eebd
CY
89242012-03-11 Chong Yidong <cyd@gnu.org>
8925
413df973
CY
8926 * keymap.c (Fkey_description): Doc fix (Bug#9700).
8927
66c5eebd
CY
8928 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
8929
1de11f56
CY
89302012-03-10 Chong Yidong <cyd@gnu.org>
8931
8932 * frame.c (other_visible_frames): Don't assume the selected frame
8933 is visible (Bug#10955).
8934
cae07000
SM
89352012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
8936
8937 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
8938
89c94350
JD
89392012-03-08 Jan Djärv <jan.h.d@swipnet.se>
8940
8941 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
8942 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
8943 zero (Bug#10954).
8944
999dd333
GM
89452012-03-03 Glenn Morris <rgm@gnu.org>
8946
01a6dcc8 8947 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 8948
de0100f2
EZ
89492012-03-02 Eli Zaretskii <eliz@gnu.org>
8950
8951 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
8952 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
8953 (redisplay_window, next_element_from_string): Fix typos in
8954 comments.
3e441275
EZ
8955 (redisplay_window): Pass to move_it_vertically the margin in
8956 pixels, not in screen lines.
de0100f2 8957
96a72ee9
GM
89582012-03-02 Glenn Morris <rgm@gnu.org>
8959
8960 * buffer.c (buffer-list-update-hook): Doc fix.
8961
312508d7
EZ
89622012-02-29 Eli Zaretskii <eliz@gnu.org>
8963
8964 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
8965 push_it before setting up the iterator for the first overlay
8966 string, even if we have an empty string loaded.
8967 (next_overlay_string): If there's an empty string on the iterator
8968 stack, pop the stack. (Bug#10903)
8969
27f3c637
PE
89702012-02-25 Paul Eggert <eggert@cs.ucla.edu>
8971
8972 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
8973 Suggested by Stefan Monnier in
8974 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
8975 * alloc.c (widen_to_Lisp_Object): New static function.
8976 (mark_memory): Also mark Lisp_Objects by fetching pointer words
8977 and widening them to Lisp_Objects. This would work even if
8978 USE_LSB_TAG is defined and wide integers are used, which might
8979 happen in a future version of Emacs.
8980
3c9dfce6
CY
89812012-02-25 Chong Yidong <cyd@gnu.org>
8982
fa74b241
CY
8983 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
8984 Doc fix.
8985
3c9dfce6
CY
8986 * xselect.c (Fx_selection_exists_p): Doc fix.
8987 (x_clipboard_manager_save_all): Print an informative message
8988 before saving to clipboard manager.
8989
9486df08
CY
89902012-02-24 Chong Yidong <cyd@gnu.org>
8991
8992 * keyboard.c (process_special_events): Handle all X selection
8993 requests in kbd_buffer, not just the next one (Bug#8869).
8994
f01d3321
CY
89952012-02-23 Chong Yidong <cyd@gnu.org>
8996
8997 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
8998 call when setting menu-bar-lines and tool-bar-lines parameters.
8999 (unwind_create_frame_1): New helper function.
9000
9001 * window.c (inhibit_window_configuration_change_hook): New var.
9002 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 9003 (syms_of_window): Initialize it.
f01d3321 9004
86b847b6
CY
90052012-02-22 Chong Yidong <cyd@gnu.org>
9006
9007 * xterm.c (x_draw_image_relief): Add missing type check for
9008 Vtool_bar_button_margin (Bug#10743).
9009
a59225b1
CY
90102012-02-21 Chong Yidong <cyd@gnu.org>
9011
9012 * fileio.c (Vfile_name_handler_alist): Doc fix.
9013
9014 * buffer.c (Fget_file_buffer): Protect against invalid file
9015 handler return value.
9016
310f5bd4
PE
90172012-02-20 Paul Eggert <eggert@cs.ucla.edu>
9018
cb3a28cc
PE
9019 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
9020 when computing $valmask.
9021
310f5bd4
PE
9022 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
9023 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
9024 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
9025 It's useless in that case, and it can cause problems on hosts
9026 that allocate halves of EMACS_INT values separately.
9027 Reported by Dan Horák. Diagnosed by Andreas Schwab in
9028 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
9029 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
9030 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
9031 it avoids undefined behavior on hosts where shifting right by more
9032 than the word width has undefined behavior.
9033
2375c96a
CY
90342012-02-19 Chong Yidong <cyd@gnu.org>
9035
9036 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
9037 (Funhandled_file_name_directory, Ffile_name_as_directory)
9038 (Fdirectory_file_name, Fexpand_file_name)
9039 (Fsubstitute_in_file_name): Protect against invalid file handler
9040 return values (Bug#10845).
9041
3eb49e71
EZ
90422012-02-18 Eli Zaretskii <eliz@gnu.org>
9043
9044 * .gdbinit (pitx): Fix incorrect references to fields of the
9045 iterator stack.
9046
7b926f3f
CY
90472012-02-17 Chong Yidong <cyd@gnu.org>
9048
9049 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
9050
11273115
PE
90512012-02-15 Paul Eggert <eggert@cs.ucla.edu>
9052
9053 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
9054 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
9055
c3a70e2b
CY
90562012-02-15 Chong Yidong <cyd@gnu.org>
9057
9058 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
9059 marked as special. Also, starting docstrings with * is obsolete.
9060
0ca43699
AS
90612012-02-13 Andreas Schwab <schwab@linux-m68k.org>
9062
9063 * gnutls.c (emacs_gnutls_write): Fix last change.
9064
2e8f3c56
LI
90652012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
9066
9067 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
9068 send_process.
9069
af70074f
SM
90702012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
9071
9072 * keymap.c (Fsingle_key_description): Handle char ranges.
9073
95986d52
CY
90742012-02-12 Chong Yidong <cyd@gnu.org>
9075
afd83bd1
CY
9076 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
9077 as that creates a dangerous corner case.
9078
95986d52
CY
9079 * window.c (Fdelete_window_internal): Invalidate the mouse
9080 highlight (Bug#9904).
9081
bd7da63e
GM
90822012-02-12 Glenn Morris <rgm@gnu.org>
9083
9084 * xselect.c (Fx_own_selection_internal)
9085 (Fx_get_selection_internal, Fx_disown_selection_internal)
9086 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
9087 * nsselect.m (Fx_own_selection_internal)
9088 (Fx_disown_selection_internal, Fx_selection_exists_p)
9089 (Fx_selection_owner_p, Fx_get_selection_internal):
9090 Sync docs and argument specs with the xselect.c versions.
9091
77abcbc2
LI
90922012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
9093
9094 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
9095
90b671e2
EZ
90962012-02-11 Eli Zaretskii <eliz@gnu.org>
9097
1c0ca0b7
EZ
9098 * w32select.c (Fx_selection_exists_p): Sync doc string and
9099 argument list with xselect.c. (Bug#10783)
9100
9101 * w16select.c (Fx_selection_exists_p): Sync doc string and
9102 argument list with xselect.c. (Bug#10783)
90b671e2 9103
49241268
GM
91042012-02-10 Glenn Morris <rgm@gnu.org>
9105
9106 * fns.c (Fsecure_hash): Doc fix.
9107
f998bbe7 91082012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
9109
9110 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
9111
0992bd9c
CY
91122012-02-07 Chong Yidong <cyd@gnu.org>
9113
9114 * buffer.c (Fbuffer_local_variables)
9115 (buffer_lisp_local_variables): Handle unbound vars correctly;
9116 don't let Qunbound leak into Lisp.
9117
af008560
GM
91182012-02-07 Glenn Morris <rgm@gnu.org>
9119
dd605cc4
GM
9120 * image.c (Fimagemagick_types): Doc fix.
9121
af008560
GM
9122 * image.c (imagemagick-render-type): Change it from a lisp object
9123 to an integer. Move the doc here from the lisp manual.
9124 Treat all values not equal to 0 the same.
9125
1449fa1d
CY
91262012-02-06 Chong Yidong <cyd@gnu.org>
9127
9128 * doc.c (store_function_docstring): Avoid applying docstring of
9129 alias to base function (Bug#2603).
9130
3723ec07
AS
91312012-02-04 Andreas Schwab <schwab@linux-m68k.org>
9132
9133 * .gdbinit (pp1, pv1): Remove redundant defines.
9134 (pr): Use pp.
9135
79c1cc1e
CY
91362012-02-04 Chong Yidong <cyd@gnu.org>
9137
9138 * nsterm.m: Declare a global (Bug#10694).
9139
d7f29f8e
EZ
91402012-02-04 Eli Zaretskii <eliz@gnu.org>
9141
cae07000
SM
9142 * w32.c (get_emacs_configuration_options):
9143 Include --enable-checking, if specified, in the return value.
d7f29f8e 9144
3b95a6f9
MR
91452012-02-04 Martin Rudalics <rudalics@gmx.at>
9146
9147 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
9148 after rounding frame sizes. (Bug#9723)
9149
d6fa96a6
EZ
91502012-02-04 Eli Zaretskii <eliz@gnu.org>
9151
9152 * keyboard.c (adjust_point_for_property): Don't position point
9153 before BEGV. (Bug#10696)
9154
df0b2940
PE
91552012-02-03 Paul Eggert <eggert@cs.ucla.edu>
9156
9157 Handle overflow when computing char display width (Bug#9496).
9158 * character.c (char_width): Return EMACS_INT, not int.
9159 (char_width, c_string_width): Check for overflow when
9160 computing the width; this is possible now that individual
9161 characters can have unbounded width. Problem introduced
9162 by merge from Emacs 23 on 2012-01-19.
9163
6bee44d6
MA
91642012-02-02 Michael Albinus <michael.albinus@gmx.de>
9165
9166 * dbusbind.c (Fdbus_register_method): Mention the return value
9167 :ignore in the docstring.
9168
44f92739
GM
91692012-02-02 Glenn Morris <rgm@gnu.org>
9170
1b9f60cc
GM
9171 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
9172
44f92739
GM
9173 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
9174 Unconditionally set to t. (Bug#10673)
9175 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
9176 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
9177 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
9178
c5d3843c
KH
91792012-02-02 Kenichi Handa <handa@m17n.org>
9180
9181 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
9182 0, do not call append_composite_glyph.
9183
159462d4 91842012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
9185
9186 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
9187 NULL (Bug#6988).
9188 (x_produce_glyphs): If the component of a composition is a null
9189 string, set it->pixel_width to 1 to avoid zero-width glyph.
9190
78cef877
EZ
91912012-02-01 Eli Zaretskii <eliz@gnu.org>
9192
9193 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
9194 first 2 arguments are identical. This makes inserting large
9195 output from a subprocess an order of magnitude faster on
9196 MS-Windows, where all sbrk'ed memory is always contiguous.
9197
97897668
GM
91982012-01-31 Glenn Morris <rgm@gnu.org>
9199
9200 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 9201 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
9202 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
9203
31fd3586
GM
92042012-01-29 Glenn Morris <rgm@gnu.org>
9205
9206 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
9207
0e24a8b2
CY
92082012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
9209
9210 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
9211
cc0adcb0
CY
92122012-01-28 Chong Yidong <cyd@gnu.org>
9213
9214 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
9215
acc28cb9
CY
92162012-01-26 Chong Yidong <cyd@gnu.org>
9217
9c69cfb7
CY
9218 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
9219
acc28cb9
CY
9220 * search.c (Fsearch_forward, Fsearch_backward): Document negative
9221 repeat counts (Bug#10507).
9222
48da7392
GM
92232012-01-26 Glenn Morris <rgm@gnu.org>
9224
9225 * lread.c (syms_of_lread): Doc fix.
9226
14af5f7f
CY
92272012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
9228
9229 * coding.c (encode_designation_at_bol): Change return value to
9230 EMACS_INT.
9231
0b21c100
CY
92322012-01-25 Chong Yidong <cyd@gnu.org>
9233
9234 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
9235
3c2907f7
CY
92362012-01-21 Chong Yidong <cyd@gnu.org>
9237
9238 * floatfns.c (Fcopysign): Make the second argument non-optional,
9239 since nil is not allowed anyway.
9240
959ad23f
AS
92412012-01-21 Andreas Schwab <schwab@linux-m68k.org>
9242
9243 * process.c (read_process_output): Use p instead of XPROCESS (proc).
9244 (send_process): Likewise.
9245
34a02f46
MR
92462012-01-19 Martin Rudalics <rudalics@gmx.at>
9247
9248 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
9249 (Vwindow_persistent_parameters): Do not use Qstate.
9250 Rewrite doc-strings.
34a02f46 9251
1259009a 92522012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
9253
9254 * character.c (char_width): New function.
70d4fdf6
GM
9255 (Fchar_width, c_string_width, lisp_string_width):
9256 Use char_width (Bug#9496).
25ed9e61 9257
6a6ee00d
MR
92582012-01-16 Martin Rudalics <rudalics@gmx.at>
9259
9260 * window.c (Vwindow_persistent_parameters): New variable.
9261 (Fset_window_configuration, save_window_save): Handle persistent
9262 window parameters.
9263
c85efaf7
EZ
92642012-01-14 Eli Zaretskii <eliz@gnu.org>
9265
9266 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
9267 thrashing the stack of the thread. (Bug#9087)
9268
5944709e
PE
92692012-01-12 Paul Eggert <eggert@cs.ucla.edu>
9270
9271 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
9272
e71f5d99
EZ
92732012-01-11 Eli Zaretskii <eliz@gnu.org>
9274
9275 * xdisp.c (rows_from_pos_range): Handle the case where the
9276 highlight ends on a newline. (Bug#10464)
9277 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
9278 he end column for display of highlight that ends on a newline
9279 before a R2L line.
9280
ce316182
GM
92812012-01-11 Glenn Morris <rgm@gnu.org>
9282
9283 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
9284 from load-path also when installation-directory is nil. (Bug#10208)
9285
5b43da69
GM
92862012-01-10 Glenn Morris <rgm@gnu.org>
9287
74cc8ff9
GM
9288 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
9289
7d8d6e4e
GM
9290 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
9291 Update template values to be closer to their typical values these days.
5b43da69 9292
a0db8d43
EZ
92932012-01-09 Eli Zaretskii <eliz@gnu.org>
9294
9295 * xdisp.c (rows_from_pos_range): Accept additional argument
9296 DISP_STRING, and accept any glyph in a row whose object is that
9297 string as eligible for mouse highlight. Fixes mouse highlight of
9298 display strings from overlays. (Bug#10464)
9299
9a0115ab 93002012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 9301
b9110d6a 9302 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
9303 * fileio.c (auto_saving_dir_umask): New static var.
9304 (Fmake_directory_internal): Use it.
9305 (do_auto_save_make_dir): Set it, instead of invoking chmod after
9306 creating the directory. The old code temporarily assigns
9307 too-generous permissions to the directory.
9308 (do_auto_save_eh): Clear it.
b9110d6a 9309 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
9310 that the var is always cleared.
9311
6c1bd3f3
EZ
93122012-01-07 Eli Zaretskii <eliz@gnu.org>
9313
9314 * search.c (scan_buffer): Pass character positions to
9315 know_region_cache, not byte positions. (Bug#6540)
9316
069d2b50
L
93172012-01-07 LynX <_LynX@bk.ru> (tiny change)
9318
9319 * w32.c (sys_rename): Report EXDEV when rename of a directory
9320 fails because the target is on another logical disk. (Bug#10284)
9321
75bf0d33
DB
93222012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
9323
9324 * xterm.c (x_embed_request_focus): New function.
9325
9326 * xterm.h: Add prototype.
9327
9328 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
9329
1c6e5a32
GM
93302012-01-05 Glenn Morris <rgm@gnu.org>
9331
9332 * emacs.c (emacs_copyright): Update short copyright year to 2012.
9333
651e947e
EZ
93342012-01-01 Eli Zaretskii <eliz@gnu.org>
9335
9336 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
9337 Load gnutls_transport_set_lowat only if GnuTLS version is below
9338 2.11.1.
9339 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
9340 GnuTLS versions below 2.11.1.
9341
3778cdd8
AL
93422011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
9343
9344 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
9345 to the doc string advising against its use for altering the way
9346 windows are scrolled.
9347
0e5317f7
KH
93482011-12-28 Kenichi Handa <handa@m17n.org>
9349
9350 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
9351 coding-system ASCII compatible only when it does not produce BOM
9352 on encoding (Bug#10383).
9353
93d5ca1f
JD
93542011-12-26 Jan Djärv <jan.h.d@swipnet.se>
9355
9356 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
9357 can scroll.
9358 (create_and_show_popup_menu): Always use menu_position_func for
9359 Gtk3 (Bug#10361).
9360
ca22b785
AS
93612011-12-24 Andreas Schwab <schwab@linux-m68k.org>
9362
9363 * callint.c (Fcall_interactively): Don't truncate prompt string.
9364
d048e1e6
EZ
93652011-12-23 Eli Zaretskii <eliz@gnu.org>
9366
9367 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
9368 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 9369 resumed from there (after widening). (Bug#10360)
d048e1e6 9370
5ccaba1f
JD
93712011-12-22 Jan Djärv <jan.h.d@swipnet.se>
9372
9373 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
9374
204ee57f
JD
93752011-12-21 Jan Djärv <jan.h.d@swipnet.se>
9376
b81d40f0
JB
9377 * nsterm.m (x_free_frame_resources):
9378 Release f->output_data.ns->miniimage.
204ee57f
JD
9379 (ns_index_color): Fix indentation. Do not retain
9380 color_table->colors[i].
9381
9382 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
9383 before returning.
9384
9385 * nsfns.m (x_set_background_color): Assign return value from
9386 ns_index_color to face-background instead of NSColor*.
9387 (ns_implicitly_set_icon_type): Fix indentation.
9388 Change assignment in for loop to comparison.
9389
9390 * emacs.c (ns_pool): New variable.
9391 (main): Assign ns_pool.
9392 (Fkill_emacs): Call ns_release_autorelease_pool.
9393
9394 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
9395 autorelease fdesc, release fdAttrs and tdict.
9396 (ns_get_covering_families): Release charset.
9397 (ns_findfonts): Release NSFontDescriptor created with new.
9398 (ns_uni_to_glyphs): Fix indentation.
9399 (setString): Release attrStr before assigning new value.
9400
c803b2b7
JD
94012011-12-18 Jan Djärv <jan.h.d@swipnet.se>
9402
678f4426
JD
9403 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
9404 and NS_IMPL_COCOA.
9405 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
9406 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
9407
cd394be1 94082011-12-18 David Reitter <reitter@cmu.edu>
678f4426 9409
5fecd5fc
JD
9410 * nsterm.m (ns_term_init): Subscribe for notifications
9411 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
9412 to method trackingNotification in EmacsMenu.
9413
9414 * nsmenu.m (trackingMenu): New variable.
3771cb17 9415 (trackingNotification): New method (from Aquamacs).
5fecd5fc 9416 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 9417 from Aquamacs (Bug#7030).
678f4426
JD
9418
94192011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 9420
c803b2b7
JD
9421 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
9422 (symbol_to_nsstring): Fix indentation.
9423 (ns_symbol_to_pb): New function.
cae07000
SM
9424 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
9425 (Fns_rotate_cut_buffers_internal): Remove.
9426 (Fns_store_selection_internal): Rename from
c803b2b7
JD
9427 Fns_store_cut_buffer_internal.
9428 (ns_get_foreign_selection, Fx_own_selection_internal)
9429 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
9430 (Fns_get_selection_internal, Fns_store_selection_internal):
9431 Use ns_symbol_to_pb and check if return value is nil.
9432 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
9433 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
9434 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
9435 renamed to Sns_store_selection_internal.
9436 (ns_handle_selection_request): Move code to Fx_own_selection_internal
9437 and remove this function.
9438 (ns_handle_selection_clear): Remove, never used.
9439 (Fx_own_selection_internal): Move code from ns_handle_selection_request
9440 here.
9441
e1b01a3a
KB
94422011-12-17 Ken Brown <kbrown@cornell.edu>
9443
9444 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
9445 GID is unknown (Bug#10257).
9446
2adb6e85
PE
94472011-12-17 Paul Eggert <eggert@cs.ucla.edu>
9448
9449 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
9450 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
9451 which caused a build failure on GNU/Linux IA-64. This problem was
9452 introduced by my 2011-10-07 patch.
9453
d1d7b339
JL
94542011-12-15 Juri Linkov <juri@jurta.org>
9455
9456 * image.c (imagemagick_error): New function. (Bug#10112)
9457 (imagemagick_load_image): Comment out `MagickSetResolution' call.
9458 Use `imagemagick_error' where ImageMagick functions return
9459 `MagickFalse'.
9460 (Fimagemagick_types): Add `Fnreverse' to return the list in the
9461 proper order.
9462
100d5755
KH
94632011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9464
9465 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
9466 fill background (Bug#8992).
9467
454592a6
MR
94682011-12-13 Martin Rudalics <rudalics@gmx.at>
9469
9470 * window.c (Vwindow_combination_resize)
9471 (Vwindow_combination_limit): Use t instead of non-nil in
9472 doc-strings.
61d4b438
MR
9473 (Vrecenter_redisplay): Add first sentence of doc-string on
9474 separate line.
53524d93 9475 (Frecenter): Fix doc-string typo.
454592a6 9476
3633e3aa
KH
94772011-12-11 Kenichi Handa <handa@m17n.org>
9478
9479 * coding.c (Funencodable_char_position): Pay attention to the
9480 buffer text relocation (Bug#9389).
9481
7b9d523a 94822011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 9483
7b9d523a
JD
9484 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
9485 gtk_init (Bug#10100).
9486
b73189c6
EZ
94872011-12-10 Eli Zaretskii <eliz@gnu.org>
9488
9489 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
9490 IT->string is nil. (Bug#10263)
9491
f7dfe5d6
JD
94922011-12-10 Jan Djärv <jan.h.d@swipnet.se>
9493
83faebb4
JD
9494 * nsterm.h (x_free_frame_resources): Declare.
9495
f7dfe5d6
JD
9496 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
9497 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
9498
9499 * nsterm.h (ns_get_defaults_value): Declare.
9500
9501 * nsterm.m (ns_default): Call ns_get_defaults_value.
9502
7cd4e72c
EZ
95032011-12-09 Eli Zaretskii <eliz@gnu.org>
9504
9505 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
9506 (Bug#10170)
9507
b34d7317
YM
95082011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9509
9510 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
9511 that where the value of an _OBJC_* symbol points to is in the .bss
9512 section (Bug#10240).
9513
76470ad1
KH
95142011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
9515
9516 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 9517 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 9518
745fff94
KH
95192011-12-08 Kenichi Handa <handa@m17n.org>
9520
9521 * ftfont.c (get_adstyle_property): Fix previous change
9522 (Bug#10233).
9523
6e44397c
JB
95242011-12-07 Juanma Barranquero <lekktu@gmail.com>
9525
9526 * w32.c (init_environment): If no_site_lisp, remove site-lisp
9527 dirs from the default value of EMACSLOADPATH (bug#10208).
9528
7efa6272
GM
95292011-12-07 Glenn Morris <rgm@gnu.org>
9530
9531 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
9532 installation and source directories as well. (Bug#10208)
9533
f6fc4d87
CY
95342011-12-06 Chong Yidong <cyd@gnu.org>
9535
9536 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
9537
2bf26180
GM
95382011-12-06 Glenn Morris <rgm@gnu.org>
9539
9540 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
9541 as an error, not just -1. (Bug#10217)
9542
3a6ad4f0
CY
95432011-12-05 Chong Yidong <cyd@gnu.org>
9544
9545 * keyboard.c (process_special_events): New function.
9546 (swallow_events, Finput_pending_p): Use it (Bug#10195).
9547
75a3b399
PE
95482011-12-05 Paul Eggert <eggert@cs.ucla.edu>
9549
9550 * coding.c (encode_designation_at_bol): Don't use uninitialized
9551 local variable (Bug#9318).
9552
c3c9e25e
KH
95532011-12-05 Kenichi Handa <handa@m17n.org>
9554
9555 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
9556 return Qnil (Bug#8046, Bug#10193).
9557
5eb05ea3
KH
95582011-12-05 Kenichi Handa <handa@m17n.org>
9559
9560 * coding.c (encode_designation_at_bol): New args charbuf_end and
9561 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
9562 (coding_set_source): Return how many bytes coding->source was
9563 relocated.
9564 (coding_set_destination): Return how many bytes
9565 coding->destination was relocated.
9566 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 9567 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
9568
95692011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
9570
9571 * coding.c (CODING_CHAR_CHARSET_P): New macro.
9572 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
9573 macro (Bug#9318).
9574
95752011-12-05 Andreas Schwab <schwab@linux-m68k.org>
9576
9577 The following changes are to fix Bug#9318.
9578
a79703f5 9579 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
9580 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
9581 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 9582 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 9583
7dbda6df
JB
95842011-12-05 Juanma Barranquero <lekktu@gmail.com>
9585
9586 * lisp.h (process_quit_flag): Fix external declaration.
9587
6d5eb5b0
SM
95882011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
9589
9590 Don't macro-inline non-performance-critical code.
9591 * eval.c (process_quit_flag): New function.
9592 * lisp.h (QUIT): Use it.
9593
a0c3fad0
JD
95942011-12-04 Jan Djärv <jan.h.d@swipnet.se>
9595
9596 * nsfns.m (get_geometry_from_preferences): New function.
9597 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
9598
6c07aac2
AS
95992011-12-04 Andreas Schwab <schwab@linux-m68k.org>
9600
9601 * emacs.c (Qkill_emacs): Define.
9602 (syms_of_emacs): Initialize it.
9603 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
9604 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
9605 (quit_throw_to_read_char): Add parameter `from_signal'.
9606 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
9607 * lisp.h (QUIT): Call Fkill_emacs if requested.
9608
c052ead4
JD
96092011-12-03 Jan Djärv <jan.h.d@swipnet.se>
9610
9611 * widget.c (update_wm_hints): Return if wmshell is null.
9612 (widget_update_wm_size_hints): New function.
9613
9614 * widget.h (widget_update_wm_size_hints): Declare.
9615
9616 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
9617 widget_update_wm_size_hints (Bug#10104).
9618
9e49252b
EZ
96192011-12-03 Eli Zaretskii <eliz@gnu.org>
9620
9621 * xdisp.c (handle_invisible_prop): If the invisible text ends just
9622 before a newline, prepare the bidi iterator for consuming the
9623 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 9624 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 9625
02b16839
JL
96262011-12-02 Juri Linkov <juri@jurta.org>
9627
9628 * search.c (Fword_search_regexp): New Lisp function created from
9629 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
9630 (Fword_search_backward, Fword_search_forward)
9631 (Fword_search_backward_lax, Fword_search_forward_lax):
9632 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
9633 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
9634
0068070e
SM
96352011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
9636
9637 * fileio.c (Finsert_file_contents): Move after-change-function call
9638 to before the "handled:" label, since all "goto handled" appear in
9639 cases where the *-change-functions have already been properly called
9640 (bug#10117).
9641
3360a3fc
AS
96422011-12-01 Andreas Schwab <schwab@linux-m68k.org>
9643
9644 * keyboard.c (interrupt_signal): Don't call kill-emacs when
9645 waiting for input. (Bug#10169)
9646
73d6c093
EZ
96472011-11-30 Eli Zaretskii <eliz@gnu.org>
9648
9649 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
9650 verifies glyph row's hash code--we have just reallocated the
9651 glyphs, so their contents can be complete garbage. (Bug#10164)
9652
febe6bea
JB
96532011-11-30 Juanma Barranquero <lekktu@gmail.com>
9654
9655 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
9656
801a4313
EZ
96572011-11-30 Eli Zaretskii <eliz@gnu.org>
9658
9659 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
9660 attributes are tested _before_ calling verify_row_hash, to protect
9661 against GCC re-ordering of the tests. (Bug#10164)
9662
2b56b87e
JD
96632011-11-29 Jan Djärv <jan.h.d@swipnet.se>
9664
9665 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
9666
9667 * xterm.c (handle_one_xevent): Only set async_visible and friends
9668 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 9669 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
9670 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
9671
dbf31225
PE
96722011-11-28 Paul Eggert <eggert@cs.ucla.edu>
9673
9674 Remove GCPRO-related macros that exist only to avoid shadowing locals.
9675 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
9676 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
9677 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
9678 All uses changed to use GCPRO1 etc.
9679 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
9680 Revert to old implementation (i.e., before 2011-03-11).
9681
1305621b
YM
96822011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9683
9684 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
9685 of scroll runs so as to avoid assigning disabled bogus rows and
9686 unnecessary graphics copy operations.
9687
8c9afb46
EZ
96882011-11-27 Eli Zaretskii <eliz@gnu.org>
9689
9690 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
9691 (snprintf) [_MSC_VER]: Redirect to _snprintf.
9692 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
9693 (malloc, free, realloc, calloc): Redirect to e_* only when
9694 compiling Emacs.
9695
9696 * lisp.h (GCTYPEBITS): Move before first use.
9697 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
9698 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
9699 this macro definition.
9700
9701 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
9702 _MSC_VER.
9703
54e9e3bf
JD
97042011-11-27 Jan Djärv <jan.h.d@swipnet.se>
9705
6d5eb5b0
SM
9706 * gtkutil.c (xg_create_frame_widgets):
9707 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
9708 present with Gtk+ 2.0.
9709
83aca1cb
PE
97102011-11-26 Paul Eggert <eggert@cs.ucla.edu>
9711
9712 * fileio.c (Finsert_file_contents): Undo previous change; see
9713 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
9714
5b76caa4
PE
97152011-11-26 Paul Eggert <eggert@cs.ucla.edu>
9716
9717 Rename locals to avoid shadowing.
9718 * fileio.c (Finsert_file_contents):
9719 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
9720 * process.c (wait_reading_process_output):
9721 Rename inner 'proc' to 'p' to avoid shadowing.
9722 Indent for consistency with usual Emacs style.
9723
8c535114
EZ
97242011-11-25 Eli Zaretskii <eliz@gnu.org>
9725
9726 * xdisp.c (redisplay_window): If cursor row is not fully visible
9727 after recentering, and scroll-conservatively is set to a large
9728 number, scroll window by a few more lines to make the cursor fully
9729 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
9730 (start_display): Don't move to the next line if the display should
9731 start at a newline that is part of a display vector or an overlay
9732 string. (Bug#10119)
8c535114 9733
fa4fdb5c
JL
97342011-11-24 Juri Linkov <juri@jurta.org>
9735
9736 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
9737 after the `MagickPingImage' call. (Bug#10112)
9738
90ec88df
CY
97392011-11-23 Chong Yidong <cyd@gnu.org>
9740
9741 * window.c (Fcoordinates_in_window_p): Accept only live windows.
9742
56e2e794
MR
97432011-11-23 Martin Rudalics <rudalics@gmx.at>
9744
9745 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
9746 making another buffer current. (Bug#10114)
9747
b6e64c41
GM
97482011-11-23 Glenn Morris <rgm@gnu.org>
9749
9750 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
9751
6b21de18
CY
97522011-11-23 Chong Yidong <cyd@gnu.org>
9753
9754 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
9755 using it (Bug#5984).
9756
b12cd789
EZ
97572011-11-22 Eli Zaretskii <eliz@gnu.org>
9758
9759 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
9760 and header-lines, as they don't have one computed for them.
9761 (Bug#10098)
9762
9763 * .gdbinit (prow): Make displayed values more self-explaining.
9764 Add row's hash code.
9765
261b6fd4
LMI
97662011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
9767
9768 * process.c (wait_reading_process_output): Fix asynchrounous
9769 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 9770 (wait_reading_process_output): Add comment and URL.
261b6fd4 9771
e7cfd277
JD
97722011-11-21 Jan Djärv <jan.h.d@swipnet.se>
9773
9774 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
9775
a9b9b7f5
CY
97762011-11-21 Chong Yidong <cyd@gnu.org>
9777
9778 * window.c (Fnext_window, Fprevious_window): Doc fix.
9779
b0d15b4f
SM
97802011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
9781
9782 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
9783
fe7a3057
JB
97842011-11-20 Juanma Barranquero <lekktu@gmail.com>
9785
9786 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
9787
d2999b1a
MR
97882011-11-20 Martin Rudalics <rudalics@gmx.at>
9789
9790 * window.c (Fset_window_combination_limit): Rename argument
9791 STATUS to LIMIT.
9792 (Vwindow_combination_limit): Remove "status" from doc-string.
9793
d5ff9cd0
AS
97942011-11-20 Andreas Schwab <schwab@linux-m68k.org>
9795
9796 * m/ibms390.h: Remove.
9797 * m/ibms390x.h: Don't include "ibms390.h".
9798
a5bb9bd3
SM
97992011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
9800
9801 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
9802 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
9803
cd1181db
JB
98042011-11-20 Juanma Barranquero <lekktu@gmail.com>
9805
9806 * casetab.c (Fset_case_table):
9807 * charset.c (Fcharset_after): Fix typos.
9808
615a3b8d 98092011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 9810
17e845af
PE
9811 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
9812 Otherwise, valgrind does not work on some platforms.
9813 Problem reported by Andreas Schwab in
6a0bf43d
PE
9814 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
9815 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
9816 is set, removing the need for VIRT_ADDRESS_VARIES.
9817 (PURE_P): Use a more-efficient implementation that needs just one
9818 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
9819 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
9820 to 4 (xorl, subq, cmpq, setbe).
9821 * alloc.c (pure): Always extern now, since that's the
9822 VIRT_ADDR_VARIES behavior.
9823 (PURE_POINTER_P): Use a single comparison, not two, for
9824 consistency with the new puresize.h.
9825 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
9826 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
9827 Remove VIRT_ADDR_VARIES no longer needed.
9828
f8fe6f96
EZ
98292011-11-19 Eli Zaretskii <eliz@gnu.org>
9830
9831 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
9832 (erase_phys_cursor, update_window_cursor, show_mouse_face)
9833 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
9834 behave as if the cursor position were at the window margin.
9835
9836 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
9837 and the cursor position is out of bounds, behave as if the cursor
9838 position were at the window margin. (Bug#10075)
9839
df05a53c
CY
98402011-11-18 Chong Yidong <cyd@gnu.org>
9841
9842 * window.c (Fwindow_combination_limit): Make first argument
9843 non-optional, since it is meaningless for live windows like the
9844 selected window.
61ccba97 9845
2071918e
DA
98462011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
9847
9848 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
9849
b50a28de
SM
98502011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
9851
9852 * intervals.c: Fix grafting over the whole buffer (bug#10071).
9853 (graft_intervals_into_buffer): Simplify.
9854
015137db
EZ
98552011-11-18 Eli Zaretskii <eliz@gnu.org>
9856
9857 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
9858 hash values of the two rows.
9859 (copy_row_except_pointers): Preserve the used[] arrays and the
9860 hash values of the two rows. (Bug#10035)
68c95424 9861 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
9862
9863 * xdisp.c (row_hash): New function, body extracted from
9864 compute_line_metrics.
9865 (compute_line_metrics): Call row_hash, instead of computing the
9866 hash code inline.
9867
9868 * dispnew.c (verify_row_hash): Call row_hash for computing the
9869 hash code of a row, instead of duplicating code from xdisp.c.
9870
9871 * dispextern.h (row_hash): Add prototype.
9872
a2addb04
TH
98732011-11-18 Tassilo Horn <tassilo@member.fsf.org>
9874
9875 * frame.c (delete_frame): Don't delete the terminal when the last
9876 X frame is closed if emacs is built with GTK toolkit.
9877
df85d315
JB
98782011-11-17 Juanma Barranquero <lekktu@gmail.com>
9879
9880 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
9881
a0c2d0ae
MR
98822011-11-17 Martin Rudalics <rudalics@gmx.at>
9883
9884 * window.c (Vwindow_splits): Rename to
9885 Vwindow_combination_resize. Suggested by Juri Linkov.
9886 (Fsplit_window_internal): Use Vwindow_combination_resize instead
9887 of Vwindow_splits.
9888
58179cce
JB
98892011-11-16 Juanma Barranquero <lekktu@gmail.com>
9890
7877f373
JB
9891 * nsfns.m (Fns_font_name):
9892 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 9893
b6f67890
MR
98942011-11-16 Martin Rudalics <rudalics@gmx.at>
9895
9896 * window.h (window): Rename slot "nest" to "combination_limit".
9897 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
9898 (Fset_window_nest): Rename to Fset_window_combination_limit.
9899 (Vwindow_nest): Rename to Vwindow_combination_limit.
9900 (recombine_windows, make_parent_window, make_window)
9901 (Fsplit_window_internal, saved_window)
9902 (Fset_window_configuration, save_window_save): Rename all
9903 occurrences of window_nest to window_combination_limit.
9904
c7015153
JB
99052011-11-15 Juanma Barranquero <lekktu@gmail.com>
9906
9907 * image.c (imagemagick_load_image): Fix typo.
9908
322ad6ec
EZ
99092011-11-14 Eli Zaretskii <eliz@gnu.org>
9910
9911 * xdisp.c (display_line): Move the call to
9912 highlight_trailing_whitespace before the call to
9913 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
9914 faces of all the glyphs to compute ROW's hash value.
9915 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 9916
f067b8ec
JB
99172011-11-14 Juanma Barranquero <lekktu@gmail.com>
9918
9919 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
9920 just return (bug#10044).
9921
1e5b2111
EZ
99222011-11-12 Eli Zaretskii <eliz@gnu.org>
9923
7ef3cbd5
EZ
9924 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
9925 with user-defined heap size. Bump the default size of the temacs
9926 heap to 27MB, to avoid memory warning when running temacs.
9927 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
9928
1e5b2111
EZ
9929 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
9930 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
9931 (verify_row_hash) [XASSERTS]: New function.
9932 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
9933 that the hash value of glyph rows is correct.
1e5b2111 9934
89d61221
MR
99352011-11-12 Martin Rudalics <rudalics@gmx.at>
9936
9937 * window.h (window): Remove splits slot.
9938 * window.c (Fwindow_splits, Fset_window_splits): Remove.
9939 (Fdelete_other_windows_internal, make_parent_window)
9940 (make_window, Fsplit_window_internal, Fdelete_window_internal)
9941 (Fset_window_configuration, save_window_save): Don't deal with
9942 split status of windows.
9943 (saved_window): Remove splits slot.
9944 (Vwindow_splits): Rewrite doc-string.
9945
97f18cc8
JD
99462011-11-11 Jan Djärv <jan.h.d@swipnet.se>
9947
9948 * xfns.c (unwind_create_frame):
9949 * nsfns.m (unwind_create_frame):
9950 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
9951 Vframe_list (Bug#9999).
9952
22a648b4
DA
99532011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
9954
0b381c7e 9955 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 9956
659afede
KH
99572011-11-11 Kenichi Handa <handa@m17n.org>
9958
9959 * callproc.c (Fcall_process): Set the member dst_multibyte of
9960 process_coding.
9961
9ac0394b
KH
99622011-11-11 Johan Bockgård <bojohan@gnu.org>
9963
9964 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
9965 avoid a crash (bug#9496).
9966
2fbdc249
CY
99672011-11-09 Chong Yidong <cyd@gnu.org>
9968
9969 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
9970 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
9971
ac6b1f81
PE
99722011-11-08 Paul Eggert <eggert@cs.ucla.edu>
9973
9974 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
9975
09db192c
PE
99762011-11-08 Paul Eggert <eggert@cs.ucla.edu>
9977
9978 Avoid some portability problems by eschewing 'extern inline' functions.
9979 The trivial performance wins aren't worth the portability hassles; see
9980 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
9981 et seq.
9982 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
9983 (window_box_width, window_box_left, window_box_left_offset)
9984 (window_box_right, window_box_right_offset): Undo previous change,
9985 by removing the "extern"s.
9986 * intervals.c (adjust_intervals_for_insertion)
9987 (adjust_intervals_for_deletion): Undo previous change,
9988 making these static again.
9989 (offset_intervals, temp_set_point_both, temp_set_point)
9990 (copy_intervals_to_string): No longer inline.
9991 * xdisp.c (window_text_bottom_y, window_box_width)
9992 (window_box_height, window_box_left_offset)
9993 (window_box_right_offset, window_box_left, window_box_right)
9994 (window_box): No longer inline.
9995
105216ed
CY
99962011-11-08 Chong Yidong <cyd@gnu.org>
9997
9998 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
9999 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
10000 Signal an error if not a live window.
105216ed
CY
10001 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
10002 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
10003
ae9e237f
JB
100042011-11-07 Juanma Barranquero <lekktu@gmail.com>
10005
10006 * lisp.h (syms_of_abbrev): Remove declaration.
10007 Reported by CHENG Gao <chenggao@royau.me>.
10008
c7aa8333
EZ
100092011-11-07 Eli Zaretskii <eliz@gnu.org>
10010
10011 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
10012 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
10013 of temacs in GUI mode.
10014
be7f5545
MR
100152011-11-07 Martin Rudalics <rudalics@gmx.at>
10016
10017 * window.h: Declare delete_all_child_windows instead of
10018 delete_all_subwindows.
10019 * window.c (Fwindow_nest, Fset_window_nest)
10020 (Fset_window_new_total, Fset_window_new_normal)
10021 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
10022 (delete_all_subwindows): Rename to delete_all_child_windows.
10023 (Fdelete_other_windows_internal, Fset_window_configuration):
10024 Call delete_all_child_windows instead of delete_all_subwindows.
10025 * frame.c (delete_frame): Call delete_all_child_windows instead
10026 of delete_all_subwindows.
10027
ca78dc43
PE
100282011-11-07 Paul Eggert <eggert@cs.ucla.edu>
10029
10030 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
10031 This is also needed for porting to any host where GC_MARK_STACK is
10032 not GC_MAKE_GCPROS_NOOPS.
10033 (which_symbols): Use it.
10034
a0241d01
KH
100352011-11-07 Kenichi Handa <handa@m17n.org>
10036
10037 * coding.c (coding_set_destination): Check coding->src_pos only
10038 when coding->src_object is a buffer (bug#9910).
10039
10040 * process.c (send_process): Set the member src_multibyte of coding
10041 to 0 (bug#9911) when sending a unibyte text.
10042
10043 * callproc.c (Fcall_process): Set the member src_multibyte of
10044 process_coding to 0 (bug#9912).
10045
a64bfdfa 100462011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
10047
10048 * xmenu.c (cleanup_widget_value_tree): New function.
10049 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
10050 calling free_menubar_widget_value_tree directly (Bug#9830).
10051
cb41b32a
PE
100522011-11-06 Paul Eggert <eggert@cs.ucla.edu>
10053
10054 Fix some portability problems with 'inline'.
10055 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
10056 (window_box_width, window_box_left, window_box_left_offset)
10057 (window_box_right, window_box_right_offset): Declare extern.
10058 Otherwise, these inline functions do not conform to C99 and
10059 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
10060 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
10061 * intervals.c (adjust_intervals_for_insertion)
10062 (adjust_intervals_for_deletion): Now extern, because otherwise the
10063 extern inline functions 'offset_intervals' couldn't refer to it.
10064 (static_offset_intervals): Remove.
10065 (offset_intervals): Rewrite using the old contents of
10066 static_offset_intervals. The old version didn't conform to C99
10067 because an extern inline function contained a reference to an
10068 identifier with static linkage.
10069
b7041366
AS
100702011-11-06 Andreas Schwab <schwab@linux-m68k.org>
10071
10072 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
10073 GC.
10074
88a37c4d
EZ
100752011-11-06 Eli Zaretskii <eliz@gnu.org>
10076
10077 * xdisp.c (init_iterator, reseat_to_string): Don't set the
10078 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
10079 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
10080 return Qleft_to_right.
10081
49745b39
CY
100822011-11-06 Chong Yidong <cyd@gnu.org>
10083
10084 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
10085 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
10086 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
10087 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
10088 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
10089 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
10090 (Fwindow_vscroll): Doc fix.
10091 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
10092 argument, since it makes no sense to pass a live window and for
10093 consistency with window-child.
10094
1f05cd82
CS
100952011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
10096
10097 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
10098 support MSVC.
10099
22610910
JR
101002011-11-05 Jason Rumney <jasonr@gnu.org>
10101
10102 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
10103 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
10104 fonts (Bug#6029).
10105 (add_font_entity_to_list): Fix logic errors in mixed boolean and
10106 bitwise arithmetic preventing use of unicode-sip and non-truetype
10107 opentype fonts.
10108
a06776b2
EZ
101092011-11-05 Eli Zaretskii <eliz@gnu.org>
10110
3ad924ba
EZ
10111 * s/ms-w32.h (fstat, stat, utime): Move redirections to
10112 "emacs"-only part.
10113
a06776b2
EZ
10114 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
10115 initialization code to keep similarity to xfns.c after changes
10116 from 2011-11-05.
10117
c9e7db78
JD
101182011-11-05 Jan Djärv <jan.h.d@swipnet.se>
10119
a97f8f3f
JD
10120 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
10121 (unwind_create_frame): New function (Bug#9943).
10122 (Fx_create_frame): Restructure code to be more similar to the one in
10123 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
10124 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
10125 Move terminal->reference_count++ just before making the frame official
10126 (Bug#9943).
10127
10128 * nsterm.m (x_free_frame_resources): New function.
10129 (x_destroy_window): Move code to x_free_frame_resources.
10130
c9e7db78 10131 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
10132 (Fx_create_frame, x_create_tip_frame):
10133 Move terminal->reference_count++ just before making the frame
75f1671a 10134 official. Move initialization of image_cache_refcount and
c9e7db78
JD
10135 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
10136
a6fc3b5c
EZ
101372011-11-05 Eli Zaretskii <eliz@gnu.org>
10138
10139 Support MSVC build with newer versions of Visual Studio.
10140 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
10141 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
10142 nt/gmake.defs.
10143
10144 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
10145 which are not supported by MSVC.
10146 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
10147 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
10148 bitfields.
10149 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
10150 types in bitfields.
10151 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
10152
10153 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
10154
58179cce 101552011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
10156
10157 Support MSVC build with newer versions of Visual Studio.
10158 * w32.c: Don't include w32api.h for MSVC.
10159 (init_environment) [_MSC_VER]: Call sys_access, not _access.
10160
10161 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
10162 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
10163 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
10164 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
10165 e_* cousins.
10166 (alloca) [_MSC_VER]: Define to _alloca.
10167
10168 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
10169
10170 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
10171
a58c13ed
EZ
101722011-11-04 Eli Zaretskii <eliz@gnu.org>
10173
10174 * xdisp.c (note_mouse_highlight): If either of
10175 previous/next-single-property-change returns nil, treat that as
10176 the beginning or the end of the buffer. (Bug#9955)
10177
fe0b6370
JD
101782011-11-04 Jan Djärv <jan.h.d@swipnet.se>
10179
a58c13ed 10180 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
10181 label is not null (Bug#9951).
10182 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
10183 may be NULL.
10184
89bd5ee1
EZ
101852011-11-04 Eli Zaretskii <eliz@gnu.org>
10186
10187 * window.c (Fwindow_body_size): Mention in the doc string that the
10188 return value is in frame's canonical units. (Bug#9949)
10189
84c3edb9
EZ
101902011-11-03 Eli Zaretskii <eliz@gnu.org>
10191
4e2fb5c7
EZ
10192 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
10193
84c3edb9 10194 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 10195 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 10196 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 10197
bc17a887
EZ
101982011-11-01 Eli Zaretskii <eliz@gnu.org>
10199
10200 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
10201 Don't stop backward scan on the continuation glyph, even though
10202 its CHARPOS is positive.
6d5eb5b0
SM
10203 (mouse_face_from_buffer_pos, note_mouse_highlight):
10204 Rename cover_string to disp_string.
bc17a887 10205
4ee88440
MR
102062011-11-01 Martin Rudalics <rudalics@gmx.at>
10207
10208 * window.c (temp_output_buffer_show): Don't use
10209 Vtemp_buffer_show_specifiers.
10210 (Vtemp_buffer_show_specifiers): Remove unused variable.
10211
c2ff3c02
EZ
102122011-10-30 Eli Zaretskii <eliz@gnu.org>
10213
10214 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
10215 past the beginning of the current glyph matrix.
10216
58179cce 102172011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
10218
10219 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
10220 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
10221 HAVE_GTK3 (Bug#9869).
b77a6a7f 10222
3b574623
JD
10223 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
10224 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
10225
b77a6a7f
JD
10226 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
10227
10228 * xterm.c: Declare x_handle_net_wm_state to return int.
10229 (handle_one_xevent): Check if we are iconified but don't have
10230 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
10231 (get_current_wm_state): Return non-zero if not hidden,
10232 check for _NET_WM_STATE_HIDDEN (Bug#9893).
10233 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
10234 (x_handle_net_wm_state): Return what get_current_wm_state returns.
10235 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
10236
196e41e4
PE
102372011-10-29 Paul Eggert <eggert@cs.ucla.edu>
10238
10239 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
10240 so that this new function doesn't get optimized away by a
10241 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
10242
021f2e1a
AS
102432011-10-29 Andreas Schwab <schwab@linux-m68k.org>
10244
10245 * frame.h (MOUSE_HL_INFO): Remove excess parens.
10246
8b058d44
EZ
102472011-10-29 Eli Zaretskii <eliz@gnu.org>
10248
10249 Fix the `xbytecode' command.
10250 * .gdbinit (xprintbytestr): New command.
b50a28de 10251 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
10252 (xbytecode): Print the byte-code string as well.
10253
4452fb80
EZ
102542011-10-29 Kim Storm <storm@cua.dk>
10255
8b058d44
EZ
10256 * alloc.c (which_symbols): New function.
10257
21b72067
AS
102582011-10-29 Andreas Schwab <schwab@linux-m68k.org>
10259
10260 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
10261 line. (Bug#9903)
10262
83ed7b5c
GM
102632011-10-29 Glenn Morris <rgm@gnu.org>
10264
10265 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
10266 Not clear what it was for, and it causes various bugs. (Bug#9839)
10267
5a7a728b
EZ
102682011-10-28 Eli Zaretskii <eliz@gnu.org>
10269
10270 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
10271 possible random value that matches one of those tested as
10272 condition to clear the mouse face.
10273
d3d0842f
CY
102742011-10-28 Chong Yidong <cyd@gnu.org>
10275
10276 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
10277
31b39d13
DN
102782011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
10279
10280 * window.c (make_window): Initialize phys_cursor_on_p.
10281
9aba6043
SM
102822011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
10283
10284 * lisp.h (struct Lisp_Symbol): Update comments.
10285
c20992f4
JB
102862011-10-28 Juanma Barranquero <lekktu@gmail.com>
10287
10288 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
10289
db4f02f2
EZ
102902011-10-28 Eli Zaretskii <eliz@gnu.org>
10291
10292 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
10293 <oslsachem@gmail.com> for helping to debug this.
10294
10295 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
10296 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
10297 (g_b_init_get_glyph_outline_w): New static variables.
10298 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
10299 (GetGlyphOutlineW_Proc): New typedefs.
10300 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
10301 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
10302 New functions.
10303 (w32font_open_internal, compute_metrics):
10304 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
10305 instead of calling the "wide" APIs directly.
10306
10307 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
10308
10309 * w32.h (syms_of_w32font): Add prototype.
10310
87e68db4
JB
103112011-10-27 Juanma Barranquero <lekktu@gmail.com>
10312
10313 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
10314 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
10315 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
10316 (Fmove_to_window_line): Doc fix.
10317
435c1d67
CY
103182011-10-27 Chong Yidong <cyd@gnu.org>
10319
10320 * process.c (make_process): Set gnutls_state to NULL.
10321
10322 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
10323 non-NULL, regardless of GNUTLS_INITSTAGE.
10324 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
10325 an error. Set process slots as soon as we allocate them.
10326
10327 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
10328
9c6c6f49
CY
103292011-10-27 Chong Yidong <cyd@gnu.org>
10330
9aba6043
SM
10331 * gnutls.c (emacs_gnutls_deinit): New function.
10332 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
10333 (Fgnutls_deinit, Fgnutls_boot): Use it.
10334
10335 * process.c (make_process): Initialize GnuTLS credentials to NULL.
10336 (deactivate_process): Call emacs_gnutls_deinit.
10337
657d08d3
JB
103382011-10-27 Juanma Barranquero <lekktu@gmail.com>
10339
10340 * image.c (x_create_x_image_and_pixmap):
10341 * w32.c (sys_rename, w32_delayed_load):
10342 * w32font.c (fill_in_logfont):
10343 * w32reg.c (x_get_string_resource): Silence compiler warnings.
10344
5430d399
JB
103452011-10-26 Juanma Barranquero <lekktu@gmail.com>
10346
10347 * w32fns.c (w32_default_color_map): New function,
10348 extracted from Fw32_default_color_map.
a7ef684b 10349 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 10350
fe0055fa
PE
103512011-10-25 Paul Eggert <eggert@cs.ucla.edu>
10352
10353 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
10354
e6346438
SM
103552011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
10356
10357 * keyboard.c (test_undefined): New function (bug#9751).
10358 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
10359
e112cc37
ET
103602011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
10361
10362 * sysdep.c (init_sys_modes): Fix the check for the controlling
10363 terminal (Bug#6649).
10364
7b5d6677
EZ
103652011-10-20 Eli Zaretskii <eliz@gnu.org>
10366
10367 * dispextern.h (struct bidi_it): New member next_en_type.
10368
10369 * bidi.c (bidi_line_init): Initialize the next_en_type member.
10370 (bidi_resolve_explicit_1): When next_en_pos is valid for the
10371 current character, check also for next_en_type being WEAK_EN.
10372 (bidi_resolve_weak): Don't enter the expensive loop if the current
10373 position is before next_en_pos. Record the bidi type of the first
10374 non-ET, non-BN character we find, in addition to its position.
10375 (bidi_level_of_next_char): Invalidate next_en_type when
10376 next_en_pos is over-stepped.
10377
7da0b018
PE
103782011-10-20 Paul Eggert <eggert@cs.ucla.edu>
10379
10380 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
10381 * editfns.c: Rewrite current-time-zone so that it invokes
10382 the equivalent of (format-time-string "%Z") to get the time zone name.
10383 This fixes a bug when the time zone name contains characters that
10384 need converting from the system time locale to Emacs internal format.
10385 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
10386 that patch fixed format-time-string to do the conversion, but
10387 I forgot to fix current-time-zone.
10388 (format_time_string): New function, containing most of
10389 what Fformat_time_string used to contain.
10390 (Fformat_time_string): Rewrite in terms of format_time_string.
10391 This doesn't change this function's behavior.
10392 (current-time-zone): Rewrite to use format_time_string.
10393 This fixes the bug reported by Michael Schierl in
10394 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
10395 Jason Rumney's 2007-06-07 change worked around this bug, but
10396 didn't fix it.
10397 * systime.h (tzname, timezone): Remove no-longer-used declarations.
10398
8547b010
EZ
103992011-10-19 Eli Zaretskii <eliz@gnu.org>
10400
10401 * xdisp.c (start_display): If the character at POS is displayed
10402 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
10403 (try_window_reusing_current_matrix): If a line ends in a display
10404 vector or the next line starts in a display vector, continue
10405 redrawing the window even though the character position of
10406 start_row was reached.
8547b010
EZ
10407 (Bug#9771, part 2)
10408
4e948d15
CY
104092011-10-18 Chong Yidong <cyd@gnu.org>
10410
10411 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
10412 with nobreak-char-display too.
10413
4787455f
EZ
104142011-10-18 Eli Zaretskii <eliz@gnu.org>
10415
10416 Fix part 3 of bug#9771.
10417 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
10418 (bidi_resolve_neutral): Don't enter the expensive loop looking for
10419 non-neutral characters if the current character is a paragraph
10420 separator (a.k.a. Newline). This avoids running the same
10421 expensive loop twice, once when we consume the preceding newline
10422 and the other time when the line actually needs to be displayed.
10423 Avoid the loop when we see neutrals on the base embedding level
10424 following a character whose directionality is the same as the
10425 paragraph's. This avoids running the expensive loop when a line
10426 ends in a long sequence of neutrals, like control characters.
10427 Add assertion against STRONG_AL type. Slightly rearrange code
10428 that determines the type of a neutral given the first non-neutral
10429 that follows it.
10430 (bidi_level_of_next_char): Set next_en_pos to zero when
10431 invalidating its info.
10432
2c91f553
EZ
104332011-10-17 Eli Zaretskii <eliz@gnu.org>
10434
10435 * xdisp.c (push_display_prop): Determine whether to record string
10436 or buffer position by IT->string, not by IT->method. Allow
10437 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
10438 (move_it_vertically_backward): Don't look for character position
10439 immediately after the newline when in a continuation line.
10440 (Bug#9771, part 1)
2c91f553 10441
c7b08b0d
MR
104422011-10-15 Martin Rudalics <rudalics@gmx.at>
10443
10444 * window.c (coordinates_in_window): Rewrite and delabelize
10445 vertical border check. (Bug#5357) (Bug#9618)
10446
6b02f655
SM
104472011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
10448
10449 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
10450 errors in XSetWindowBorder (bug#9310).
10451
81d40c92
DA
104522011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
10453
10454 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
10455 avoid crash when xmalloc overrun checking is enabled.
10456
d4172c3b
EZ
104572011-10-13 Eli Zaretskii <eliz@gnu.org>
10458
10459 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
10460 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
10461 cursor motion with <left> and <right> arrow keys.
10462
10463 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
10464 some callers set that themselves.
10465
b00eea75
EZ
104662011-10-12 Eli Zaretskii <eliz@gnu.org>
10467
10468 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
10469 display string and the previous row comes from the same string and
10470 is empty. (Bug#9739) (Bug#9738)
10471
8fe012c4
SM
104722011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
10473
10474 * doc.c (get_doc_string): Encode file name (bug#9735).
10475
0074aef2
EZ
104762011-10-12 Eli Zaretskii <eliz@gnu.org>
10477
79beb178
EZ
10478 * bidi.c (bidi_level_of_next_char):
10479 * xdisp.c (get_visually_first_element): Remove old incorrect
10480 comments regarding the Unicode Line Separator character.
10481
0074aef2
EZ
10482 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
10483
6e4b3fbe
DA
104842011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
10485
10486 * alloc.c (Fgc_status): Do not access beyond zombies array
10487 boundary if nzombies > MAX_ZOMBIES.
10488 * alloc.c (dump_zombies): Add missing format specifier.
10489
0324f3af
PE
104902011-10-12 Paul Eggert <eggert@cs.ucla.edu>
10491
b5525cac
PE
10492 * xdisp.c (set_cursor_from_row): Simplify conditionals,
10493 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
10494
0324f3af
PE
10495 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
10496 Some packages use them to denote characters with modifiers.
10497
e9b5f888
AS
104982011-10-11 Andreas Schwab <schwab@linux-m68k.org>
10499
10500 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
10501 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
10502 matching a pp-number. Rename parameter var to var1.
10503
127827c0
SM
105042011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
10505
10506 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
10507
c8fd3bd0
GM
105082011-10-08 Glenn Morris <rgm@gnu.org>
10509
10510 * callint.c (Fcall_interactively): Give a more explicit error for the
10511 'c' case with a non-character input. (Bug#8479)
10512
352ec8ff
EZ
105132011-10-08 Eli Zaretskii <eliz@gnu.org>
10514
03669ccb
EZ
10515 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
10516 lines.
7061c986
EZ
10517 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
10518 lines that are hscrolled on the left.
03669ccb 10519
352ec8ff
EZ
10520 * dispnew.c (buffer_posn_from_coords): Account for a possible
10521 presence of header-line. (Bug#4426)
10522
a66cfb1c
SM
105232011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
10524
6b02f655
SM
10525 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
10526 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 10527
7c5ee88e
PE
105282011-10-07 Paul Eggert <eggert@cs.ucla.edu>
10529
10530 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
10531 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
10532 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
10533 this makes Emacs dump core during garbage collection on rare
10534 occasions. sizeof is obviously inferior to offsetof here, so
10535 stick with offsetof.
10536 (GC_POINTER_ALIGNMENT): New macro.
10537 (mark_memory): Omit 3rd (offset) arg; caller changed.
10538 Don't assume EMACS_INT alignment is the same as pointer alignment.
10539
df1bbe5b
SM
105402011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
10541
10542 * keyboard.c (read_key_sequence_remapped): New var.
10543 (read_key_sequence): Compute remapping in the right buffer.
10544 (command_loop_1): Use read_key_sequence's remapping directly.
10545
51553db6
SM
105462011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
10547
32c1fffd
SM
10548 * dired.c (file_name_completion): Don't expand file name.
10549 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
10550 before checking file name handler.
10551
51553db6
SM
10552 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
10553 they've been requested explicitly (bug#9591).
10554
b6bd1599 105552011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
10556
10557 * keymap.c (Fsingle_key_description): Use make_specified_string
10558 instead of build_string to build string from push_key_description.
10559 (Bug#5193)
10560
f701dc2a
PE
105612011-09-30 Paul Eggert <eggert@cs.ucla.edu>
10562
4222c55d
PE
10563 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
10564 This fixes a Y2038 bug on 64-bit hosts.
10565 * buffer.c (reset_buffer):
10566 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
10567 (Fclear_buffer_auto_save_failure):
10568 Use 0, not -1, to represent an unset failure time, since time_t
10569 might not be signed.
10570
f701dc2a
PE
10571 Remove dependency on glibc malloc internals.
10572 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
10573 Move back here from lisp.h, but with their new implementations.
10574 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
10575 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
10576 * charset.c (charset_table_init): New static var.
10577 (syms_of_charset): Use it instead of xmalloc. This removes a
10578 dependency on glibc malloc internals. See Eli Zaretskii's comment in
10579 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
10580 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
10581 Move back to alloc.c.
10582 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
10583 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
10584
9ceebf39
JD
105852011-09-30 Jan Djärv <jan.h.d@swipnet.se>
10586
10587 * nsterm.m (windowDidResize): Call x_set_window_size only when
10588 ns_in_resize is true. Otherwise set pixelwidth/height and
10589 call change_frame_size (Bug#9628).
10590
cb993c58
PE
105912011-09-30 Paul Eggert <eggert@cs.ucla.edu>
10592
3930c88b
PE
10593 Port --enable-checking=all to Fedora 14 x86-64.
10594 * charset.c (syms_of_charset): Also account for glibc malloc's
10595 internal overhead when calculating the initial malloc maximum.
10596
cb993c58
PE
10597 Port --enable-checking=all to Fedora 14 x86.
10598 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
10599 Move to lisp.h.
10600 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
10601 (overrun_check_realloc, overrun_check_free):
10602 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
10603 That way, xmalloc returns a properly-aligned pointer even if
10604 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
10605 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
10606 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
10607 into account when calculating the initial malloc maximum.
10608 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
10609 Move here from alloc.c, so that charset.c can use it too.
10610 Properly align; the old code wasn't right for common 32-bit hosts
10611 when configured with --enable-checking=all.
10612 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
10613 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
10614
31bed486
EZ
106152011-09-29 Eli Zaretskii <eliz@gnu.org>
10616
04c70788 10617 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
10618 use EDOM.
10619
fbcaa2f3
EZ
106202011-09-28 Eli Zaretskii <eliz@gnu.org>
10621
10622 * xdisp.c (compute_display_string_end): If there's no display
10623 string at CHARPOS, return -1.
10624
10625 * bidi.c (bidi_fetch_char): When compute_display_string_end
10626 returns a negative value, treat the character as a normal
10627 character not covered by a display string. (Bug#9624)
10628
a239d4e9
JB
106292011-09-28 Juanma Barranquero <lekktu@gmail.com>
10630
10631 * lread.c (Fread_from_string): Fix typo in docstring.
10632
88652fd5
EZ
106332011-09-27 Eli Zaretskii <eliz@gnu.org>
10634
10635 * xdisp.c (handle_invisible_prop): If invisible text ends on a
10636 newline, reseat the iterator instead of bidi-iterating there one
10637 character at a time. (Bug#9610)
32c1fffd
SM
10638 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
10639 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 10640
ed497dd4
AS
106412011-09-27 Andreas Schwab <schwab@linux-m68k.org>
10642
10643 * lread.c (readevalloop): Use correct code for NBSP.
10644 (read1): Likewise. (Bug#9608)
10645
b2bf61aa
MA
106462011-09-25 Michael Albinus <michael.albinus@gmx.de>
10647
10648 * dbusbind.c (Fdbus_register_signal): When service is not
10649 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
10650
32bbb17c
GM
106512011-09-25 Glenn Morris <rgm@gnu.org>
10652
10653 * buffer.c (truncate-lines): Doc fix.
10654
94e0933e
CY
106552011-09-24 Chong Yidong <cyd@stupidchicken.com>
10656
10657 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
10658 (Fset_window_next_buffers): Doc fix.
10659
cddde921
GM
106602011-09-24 Glenn Morris <rgm@gnu.org>
10661
10662 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
10663
1260aef1
PE
106642011-09-24 Paul Eggert <eggert@cs.ucla.edu>
10665
25b4bfa0
PE
10666 Fix minor problems found by static checking.
10667 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
10668 * indent.c (Fvertical_motion): Fix == vs = typo.
10669
e3cbd34b
EZ
106702011-09-24 Eli Zaretskii <eliz@gnu.org>
10671
a66cfb1c
SM
10672 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
10673 Default value is now t. Doc fix.
6bf7006f 10674
e3cbd34b 10675 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 10676 logic when moving up, not only when moving down. Fix the
e3cbd34b 10677 confusing name and values of the it_overshoot_expected variable;
32c1fffd 10678 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
10679
10680 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
10681 CHARPOS is covered by a display string which includes newlines.
10682 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
10683 is covered by a display string with embedded newlines.
10684
a3de0cbd
MA
106852011-09-24 Michael Albinus <michael.albinus@gmx.de>
10686
10687 * dbusbind.c (Fdbus_register_signal): Add match rule to
10688 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
10689 (Fdbus_register_method, Vdbus_registered_objects_table):
10690 Fix docstring.
a3de0cbd 10691
b260039d
JM
106922011-09-24 Jim Meyering <meyering@redhat.com>
10693
32c1fffd 10694 do not ignore write error for any output size
b260039d
JM
10695 The previous change was incomplete.
10696 While it makes emacs --batch detect the vast majority of stdout
10697 write failures, errors were still ignored whenever the output size is
10698 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
10699 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
10700 && echo FAIL: ignored write error
10701 FAIL: ignored write error
10702 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
10703 && echo FAIL: ignored write error
10704 FAIL: ignored write error
10705 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
10706
8eca8a7c
AS
107072011-09-23 Andreas Schwab <schwab@linux-m68k.org>
10708
10709 * emacs.c (Fkill_emacs): In noninteractive mode exit
10710 non-successfully if a write error occurred on stdout. (Bug#9574)
10711
3341db62
EZ
107122011-09-21 Eli Zaretskii <eliz@gnu.org>
10713
10714 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
10715 the xassert test.
10716
10717 * dispextern.h (struct it): Update the comment documenting what
10718 can it->OBJECT be.
10719
8c203dbf
EZ
107202011-09-20 Eli Zaretskii <eliz@gnu.org>
10721
10722 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
10723 a display string, extend search for cursor position to end of row.
10724 (find_row_edges): If the row ends in a newline from a display
10725 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
10726 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
10727 (Fcurrent_bidi_paragraph_direction): Fix search for previous
10728 non-empty line. Fixes confusing cursor motion with arrow keys at
10729 the beginning of a line that starts with whitespace.
8c203dbf 10730
a4824228
LMI
107312011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
10732
10733 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
10734 (bug#9493).
10735
33ed493b
CY
107362011-09-18 Chong Yidong <cyd@stupidchicken.com>
10737
10738 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
10739 boolean (Bug#9154).
10740
56cd55c8
EZ
107412011-09-18 Eli Zaretskii <eliz@gnu.org>
10742
10743 * xdisp.c (display_line): Record maximum and minimum buffer
10744 positions even if no glyphs were produced (e.g., by a zero-width
10745 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
10746 buffer positions that will be removed from the glyph row because
10747 they don't fit.
c02dcedf
EZ
10748 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
10749 column is beyond frame width: don't subtract 1 "pixel" when
10750 computing width of the stretch.
3e62b7e0
EZ
10751 (reseat_at_next_visible_line_start): Undo the change made on
10752 2011-09-17 that saved paragraph information and restored it after
10753 the call to `reseat'. (Bug#9545)
56cd55c8 10754
5ed99d36 107552011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
10756
10757 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
10758 and turn window cursor on if cleared (Bug#9415).
10759
5ed99d36 107602011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
10761
10762 * search.c (boyer_moore): Take unibyte characters from pattern
10763 literally. (Bug#9458)
10764
9bade7b2
EZ
107652011-09-18 Eli Zaretskii <eliz@gnu.org>
10766
10767 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
10768
e5e9d610
PE
107692011-09-18 Paul Eggert <eggert@cs.ucla.edu>
10770
87e4427a
PE
10771 Fix minor problem found by static checking.
10772 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
10773 initialized, to pacify gcc -Wuninitialized.
10774
e5e9d610
PE
10775 * fileio.c: Report proper errno when syscall falls.
10776 (Finsert_file_contents): Save and restore errno,
10777 so that report_file_error outputs the correct diagnostic.
10778 (Fwrite_region) [CLASH_DETECTION]: Likewise.
10779
a1674f0b
EZ
107802011-09-18 Eli Zaretskii <eliz@gnu.org>
10781
10782 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
10783
fbfb6dd4
EZ
107842011-09-17 Eli Zaretskii <eliz@gnu.org>
10785
10786 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
10787 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
10788
bb187662
EZ
107892011-09-17 Eli Zaretskii <eliz@gnu.org>
10790
1137e8b8 10791 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 10792 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
10793
10794 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
10795 (bidi_find_paragraph_start): Search back for paragraph beginning
10796 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
10797 (bidi_move_to_visually_next): Only trigger paragraph-related
10798 computations when the last character is a newline or at EOB, not
10799 just any NEUTRAL_B. (Bug#9470)
10800
bb187662
EZ
10801 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
10802 truncated lines if point is covered by a display string. (Bug#9524)
10803
2e621251
PE
108042011-09-16 Paul Eggert <eggert@cs.ucla.edu>
10805
10806 * xselect.c: Relax test for outgoing X longs (Bug#9498).
10807 (cons_to_x_long): New function.
10808 (lisp_data_to_selection_data): Use it. Correct the test for
10809 short-versus-long data; it was negated. Break out of vector
10810 loop, for efficiency, when a long datum is discovered.
10811
91a15bc6
SM
108122011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
10813
10814 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
10815
b41c3a35
EZ
108162011-09-16 Eli Zaretskii <eliz@gnu.org>
10817
10818 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
10819 GCC PR/17406) by declaring this function with external scope.
10820
7812ba2d
PE
108212011-09-15 Paul Eggert <eggert@cs.ucla.edu>
10822
10823 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
10824 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
10825
cf7edc2a
AS
108262011-09-15 Andreas Schwab <schwab@linux-m68k.org>
10827
10828 * editfns.c (Fformat): Correctly handle text properties on "%%".
10829
bd01620e
EZ
108302011-09-15 Eli Zaretskii <eliz@gnu.org>
10831
10832 * xterm.c (x_draw_composite_glyph_string_foreground):
10833 * w32term.c (x_draw_composite_glyph_string_foreground):
10834 * term.c (encode_terminal_code):
10835 * composite.c (composition_update_it, get_composition_id):
10836 * xdisp.c (get_next_display_element)
10837 (fill_composite_glyph_string): Add comments about special meaning
10838 of TAB characters in a composition.
10839
a02719a3
PE
108402011-09-15 Paul Eggert <eggert@cs.ucla.edu>
10841
10842 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
10843 This occurs when processing a multibyte format.
10844 Problem reported by Wolfgang Jenker.
a02719a3 10845
72589a3c
JB
108462011-09-15 Johan Bockgård <bojohan@gnu.org>
10847
10848 * xdisp.c (try_cursor_movement): Only check for exact match if
10849 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
10850
1c14176c
PE
108512011-09-14 Paul Eggert <eggert@cs.ucla.edu>
10852
10853 Remove unused external symbols.
10854 * dispextern.h (calc_pixel_width_or_height): Remove decl.
10855 * xdisp.c (calc_pixel_width_or_height): Now static.
10856 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
10857 * indent.c (check_display_width):
10858 * w32term.c: Fix comment to match code.
10859 * xterm.c, xterm.h (x_catching_errors): Remove.
10860
d2eea5b5
PE
108612011-09-14 Paul Eggert <eggert@cs.ucla.edu>
10862
10863 * xselect.c: Use signed conversions more consistently (Bug#9498).
10864 (selection_data_to_lisp_data): Assume incoming selection data are
10865 signed integers, not unsigned. This is to be consistent with
10866 outgoing selection data, which was modified to use signed integers
10867 in as part of the fix to Bug#9196 in response to Jan D.'s comment
10868 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
10869 expects long, not unsigned long.
10870
46888499
EZ
108712011-09-14 Eli Zaretskii <eliz@gnu.org>
10872
10873 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
10874 computation of loop end. Reported by Johan Bockgård
10875 <bojohan@gnu.org>.
10876
ef8ef9fb
CY
108772011-09-13 Chong Yidong <cyd@stupidchicken.com>
10878
10879 * frame.c (Fother_visible_frames_p): Function deleted.
10880
fa819fed
EZ
108812011-09-12 Eli Zaretskii <eliz@gnu.org>
10882
10883 * indent.c (compute_motion): Process display vector front to back
10884 rather than the other way around. (Bug#2496)
10885
2ba8e008
SM
108862011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
10887
10888 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
10889
20f53c69
CY
108902011-09-11 Chong Yidong <cyd@stupidchicken.com>
10891
10892 * minibuf.c (Fread_from_minibuffer): Doc fix.
10893
d562d7a4
EZ
108942011-09-11 Eli Zaretskii <eliz@gnu.org>
10895
10896 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
10897 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
10898
1c4d7f3d
LMI
108992011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
10900
10901 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
10902 value for non-existent files.
10903
b885bf36
EZ
109042011-09-11 Eli Zaretskii <eliz@gnu.org>
10905
10906 * fileio.c (Finsert_file_contents): If the file cannot be opened,
10907 set its "size" to -1. This will set the modtime_size field of
10908 the corresponding buffer to -1, which is what
10909 verify-visited-file-modtime expects for files that do not exist.
10910 (Bug#9139)
10911
6612f0bf
PE
109122011-09-11 Paul Eggert <eggert@cs.ucla.edu>
10913
10914 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
10915 here ...
10916 * lisp.h: ... from here. push_key_description is no longer
10917 defined in keyboard.c, so its declaration should not be in
10918 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
10919 logically belongs with push_key_description.
10920
dfb3f755
PE
109212011-09-10 Paul Eggert <eggert@cs.ucla.edu>
10922
10923 * buffer.h: Include <sys/types.h> instead of <time.h>.
10924 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
10925 Problem reported by Herbert J. Skuhra.
10926
3134906c
LMI
109272011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
10928
10929 * xml.c (parse_region): Make the parsing work for
10930 non-comment-starting XML files again (bug#9144).
10931
8d903f4e
AS
109322011-09-10 Andreas Schwab <schwab@linux-m68k.org>
10933
10934 * image.c (gif_load): Fix calculation of bottom and right corner.
10935 (Bug#9468)
10936
80ad64f4
EZ
109372011-09-10 Eli Zaretskii <eliz@gnu.org>
10938
10939 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
10940 redisplay in small windows.
10941
208a048d
EZ
109422011-09-09 Eli Zaretskii <eliz@gnu.org>
10943
10944 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
10945
9b1c252e
MR
109462011-09-08 Martin Rudalics <rudalics@gmx.at>
10947
10948 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
10949 Operate on live windows only.
10950
2949f33b
JB
109512011-09-08 Juanma Barranquero <lekktu@gmail.com>
10952
10953 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
10954
e08dcafd
EZ
109552011-09-07 Eli Zaretskii <eliz@gnu.org>
10956
10957 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
10958 only under bidi iteration.
10959
115b96bd
JD
109602011-09-07 Jan Djärv <jan.h.d@swipnet.se>
10961
10962 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
10963
c8199d0f
PE
109642011-09-06 Paul Eggert <eggert@cs.ucla.edu>
10965
10966 isnan: Fix porting problem to Solaris 10 with bundled gcc.
10967 Without this fix, the command to link temacs failed due to an
10968 undefined symbol __builtin_isnan. This is because
10969 /usr/include/iso/math_c99.h #defines isnan(x) to
10970 __builtin_isnan(x), but the bundled gcc, which identifies itself
10971 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
10972 a __builtin_isnan.
10973 * floatfns.c (isnan): #undef, and then #define to a clone of
10974 what's in data.c.
10975 (Fisnan): Always define, since it's always available now.
10976 (syms_of_floatfns): Always define isnan at the Lisp level.
10977
e39b275c 109782011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
10979
10980 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
10981
b2db44d9 109822011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 10983
f4af5137 10984 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
10985 The previous code assumed that file offsets (off_t values) fit in
10986 EMACS_INT variables, which is not true on typical 32-bit hosts.
10987 The code messed up by falsely reporting buffer overflow in cases
10988 such as (insert-file-contents "big" nil 1 2) into an empty buffer
10989 when "big" contains more than 2**29 bytes, even though this
10990 inserts just one byte and does not overflow the buffer.
10991 (Finsert_file_contents): Store file offsets as off_t
10992 values, not as EMACS_INT values. Check for overflow when
10993 converting between EMACS_INT and off_t. When checking for
10994 buffer overflow or for overlap, take the offsets into account.
10995 Don't use EMACS_INT for small values where int suffices.
10996 When checking for overlap, fix a typo: ZV was used where
10997 ZV_BYTE was intended.
10998 (Fwrite_region): Don't assume off_t fits into 'long'.
10999 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
11000
ecfc0a49
MA
110012011-09-05 Michael Albinus <michael.albinus@gmx.de>
11002
11003 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
11004
6511acf2 110052011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 11006
0999621a 11007 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
11008
11009 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 11010 (esprintf, exprintf, evxprintf): New functions.
62f19c19 11011 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 11012 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
11013 (modify_event_symbol): Do not assume that the length of
11014 name_alist_or_stem is safe to alloca and fits in int.
11015 (Fexecute_extended_command): Likewise for function name and binding.
11016 (Frecursion_depth): Wrap around reliably on integer overflow.
11017 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
11018 since some callers pass EMACS_INT values.
11019 (Fsingle_key_description): Don't crash if symbol name contains more
11020 than MAX_ALLOCA bytes.
11021 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
11022 (get_minibuffer): Arg is now EMACS_INT, not int.
11023 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 11024 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
11025 * window.h (command_loop_level, minibuf_level): Reflect API changes.
11026
2be7d702
PE
11027 * dbusbind.c (signature_cat): New function.
11028 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
11029 Do not overrun buffer; instead, report string overflow.
11030
9d1df220
PE
11031 * dispnew.c (add_window_display_history): Don't overrun buffer.
11032 Truncate instead; this is OK since it's just a log.
11033
33ef5c64
PE
11034 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
11035 even if the time zone offset is outlandishly large.
11036 Don't mishandle offset == INT_MIN.
11037
66c6fdd5
PE
11038 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
11039 when creating daemon; the previous buffer-overflow check was incorrect.
11040
d749b01b
PE
11041 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
11042 which has the guts of the old verror function.
11043
b5cd1905
PE
11044 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
11045 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
11046
6e1a67fb
PE
11047 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
11048 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 11049 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 11050 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
11051 length of string rather than counting it via multiple sprintfs;
11052 that's simpler and more reliable.
c21721cc
PE
11053 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
11054 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
11055 sprintf, in case result does not fit in int.
11056
c57b67fc
PE
11057 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
11058 (fontset_from_font): Print it.
11059
8a401434
PE
11060 * frame.c (tty_frame_count): Now printmax_t, not int.
11061 (make_terminal_frame, set_term_frame_name): Print it.
11062 (x_report_frame_params): In X, window IDs are unsigned long,
11063 not signed long, so print them as unsigned.
11064 (validate_x_resource_name): Check for implausibly long names,
11065 and don't assume name length fits in 'int'.
11066 (x_get_resource_string): Don't blindly alloca invocation name;
11067 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
11068 not fit in int.
11069
6e1a67fb
PE
11070 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
11071 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
11072 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
11073
0df02bf3
PE
11074 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
11075 Use esprintf, not sprintf, in case result does not fit in int.
11076
48e30793
PE
11077 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
11078 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
11079 it as a large positive number.
11080 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
11081 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
11082
a66ff6d8
PE
11083 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
11084 in case result does not fit in int.
11085
aca216ff
PE
11086 * print.c (float_to_string): Detect width overflow more reliably.
11087 (print_object): Make sprintf buffer a bit bigger, to avoid potential
11088 buffer overrun. Don't assume list length fits in 'int'. Treat
11089 print length of 0 as 0, not as infinity; to be consistent with other
11090 uses of print length in this function. Don't overflow print length
11091 index. Don't assume hash table size fits in 'long', or that
11092 vectorlike size fits in 'unsigned long'.
11093
31c286f7
PE
11094 * process.c (make_process): Use printmax_t, not int, to format
11095 process-name gensyms.
11096
55e5faa1
PE
11097 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
11098
80f2e268
PE
11099 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
11100 to avoid potential buffer overrun.
11101
670741ab
PE
11102 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
11103 if X resource line is longer than 512 bytes.
11104
b7163a50
PE
11105 * xfns.c (x_window): Make sprintf buffer a bit bigger
11106 to avoid potential buffer overrun.
11107
ae58ff1f
PE
11108 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
11109
c43c8a6a
PE
11110 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
11111
3f8236f4
PE
111122011-09-04 Paul Eggert <eggert@cs.ucla.edu>
11113
53e9fe90 11114 Integer overflow fixes for scrolling, etc.
6511acf2
PE
11115 Without these, Emacs silently mishandles large integers sometimes.
11116 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
11117 it were "C-u 1 M-x recenter" on a typical 64-bit host.
11118
6511acf2
PE
11119 * xdisp.c (try_window_id): Check Emacs fixnum range before
11120 converting to 'int'.
806add1d 11121
6511acf2 11122 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
11123 Check that an Emacs fixnum is in range before assigning it to 'int'.
11124 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
11125 values converted from Emacs fixnums.
11126 (Frecenter): Don't wrap around a line count if it is out of 'int'
11127 range; instead, treat it as an extreme value.
11128 (Fset_window_configuration, compare_window_configurations):
11129 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
11130
6511acf2
PE
11131 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
11132 that can exceed INT_MAX. Check that EMACS_INT value is in range
11133 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
11134 (match_limit): Don't assume that a fixnum can fit in 'int'.
11135
6511acf2 11136 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
11137 exceed INT_MAX.
11138
6511acf2 11139 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
11140 (Fvertical_motion): Don't wrap around LINES values that don't fit
11141 in 'int'. Instead, treat them as extreme values. This is good
11142 enough for windows, which can't have more than INT_MAX lines anyway.
11143
fcb901a7
LMI
111442011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
11145
0f2f6b6d
LMI
11146 * Require libxml/parser.h to avoid compilation warning.
11147
fcb901a7
LMI
11148 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
11149
11150 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
11151 since this reportedly can destroy thread storage.
11152
6e20a0d4
CY
111532011-08-30 Chong Yidong <cyd@stupidchicken.com>
11154
11155 * syntax.c (find_defun_start): Update all cache variables if
11156 exiting early (Bug#9401).
11157
148ae00e
EZ
111582011-08-30 Eli Zaretskii <eliz@gnu.org>
11159
f6cfbd8f
EZ
11160 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
11161
148ae00e
EZ
11162 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
11163 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
11164 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
11165
11166 * term.c (tty_append_glyph): New function.
11167 (produce_stretch_glyph): Static function and its prototype deleted.
11168
a66cfb1c
SM
11169 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
11170 Add prototypes.
148ae00e 11171
c4a07a4c
PE
111722011-08-29 Paul Eggert <eggert@cs.ucla.edu>
11173
11174 * image.c (parse_image_spec): Check for nonnegative, not for positive,
11175 when checking :margin (Bug#9390).
11176 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 11177 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
11178 so that the name doesn't mislead. All uses changed.
11179
6bc8cd65
JB
111802011-08-28 Johan Bockgård <bojohan@gnu.org>
11181
11182 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
11183 set_tty_hooks.
11184
dca4927e
EZ
111852011-08-27 Eli Zaretskii <eliz@gnu.org>
11186
11187 * xdisp.c (move_it_to): Don't bail out early when reaching
11188 position beyond to_charpos, if we are scanning backwards.
11189 (move_it_vertically_backward): When DY == 0, make sure we get to
11190 the first character in the line after the newline.
11191
f2cad773
PE
111922011-08-27 Paul Eggert <eggert@cs.ucla.edu>
11193
11194 * ccl.c: Improve and simplify overflow checking (Bug#9196).
11195 (ccl_driver): Do not generate an out-of-range pointer.
11196 (Fccl_execute_on_string): Remove unnecessary check for
11197 integer overflow, noted by Stefan Monnier in
11198 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
11199 Remove a FIXME that didn't need fixing.
11200 Simplify the newly-introduced buffer reallocation code.
11201
0cae2cdb
JB
112022011-08-27 Juanma Barranquero <lekktu@gmail.com>
11203
11204 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
11205
5fc295a4 112062011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 11207
70c60eb2 11208 Integer and memory overflow issues (Bug#9196).
726e0ab1 11209
d31850da
PE
11210 * doc.c (get_doc_string): Rework so that
11211 get_doc_string_buffer_size is the actual buffer size, rather than
11212 being 1 less than the actual buffer size; this makes xpalloc more
11213 convenient.
11214
a69fbedb
PE
11215 * image.c (x_allocate_bitmap_record, cache_image):
11216 * xselect.c (Fx_register_dnd_atom):
11217 Simplify previous changes by using xpalloc.
11218
fe5c5d37
PE
11219 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
11220 since either will do and ptrdiff_t is convenient with xpalloc.
11221
0065d054
PE
11222 * charset.c (charset_table_size)
11223 (struct charset_sort_data.priority): Now ptrdiff_t.
11224 (charset_compare): Don't overflow if priorities differ greatly.
11225 (Fsort_charsets): Don't assume list length fits in int.
11226 Check for size-calculation overflow when allocating sort data.
11227 (syms_of_charset): Allocate an initial charset table that is
11228 just under 64 KiB, to avoid problems with glibc malloc and mmap.
11229
11230 * cmds.c (internal_self_insert): Check for size-calculation overflow.
11231
11232 * composite.h (struct composition.glyph_len): Now int, not unsigned.
11233 The actual value is always <= INT_MAX, and leaving it unsigned made
11234 overflow checking harder.
11235
11236 * dispextern.h (struct glyph_matrix.rows_allocated)
11237 (struct face_cache.size): Now ptrdiff_t, for convenience in use
11238 with xpalloc. The values are still always <= INT_MAX.
11239
11240 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
11241
11242 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
11243 (SAFE_NALLOCA): New macro.
11244
11245 * region-cache.c (struct boundary.pos, find_cache_boundary)
11246 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
11247 (set_cache_region, invalidate_region_cache)
11248 (revalidate_region_cache, know_region_cache, region_cache_forward)
11249 (region_cache_backward, pp_cache):
11250 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
11251 so that ptrdiff_t * can be passed to xpalloc.
11252 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
11253 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
11254 (pp_cache): Don't assume cache_len fits in int.
11255 * region-cache.h: Adjust extern decls to match.
11256
11257 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
11258 EMACS_INT, since either will do, for xpalloc.
11259
11260 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
11261 (xnmalloc, xnrealloc, xpalloc): New functions.
11262
726e0ab1
PE
11263 * bidi.c (bidi_shelve_header_size): New constant.
11264 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
11265 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
11266
51f30bc5 11267 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
11268 * buffer.c (overlays_at, overlays_in, record_overlay_string)
11269 (overlay_strings):
11270 Don't update size of array until after memory allocation succeeds,
11271 because xmalloc/xrealloc may not return.
0065d054
PE
11272 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
11273 now that we have proper integer overflow checking.
11274 (record_overlay_string, overlay_strings): Catch overflows when
11275 calculating size of overlay_str_buf.
726e0ab1 11276
0065d054
PE
11277 * callproc.c (Fcall_process): Check for size overflow when
11278 calculating size of args2.
11279 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
11280 Normally we prefer signed values, but sticking with ptrdiff_t would
11281 require adding more-complicated checks.
726e0ab1
PE
11282
11283 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
11284 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
11285 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 11286 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
11287
11288 * character.c (Fstring): Check for size-calculation overflow.
11289
11290 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
11291 unnecessary integer overflow. Check for size overflow.
11292 (encode_coding_object): Don't update size until xmalloc succeeds.
11293
11294 * composite.c (get_composition_id): Check for overflow in glyph
11295 length calculations.
11296
11297 Integer and memory overflow fixes for display code.
11298 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
11299 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
11300 (scrolling_window): Check for overflow in size calculations.
11301 (line_draw_cost, realloc_glyph_pool, add_row_entry):
11302 Don't assume glyph table len fits in int.
11303 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
11304 (row_table_size): Now ptrdiff_t, not int.
11305 (scrolling_window): Avoid overflow in size calculations.
11306 Don't update size until allocation succeeds.
11307 * fns.c (concat): Check for overflow in size calculations.
11308 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
11309 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
11310 (NEXT_ALMOST_PRIME_LIMIT): New constant.
11311
11312 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
11313 (get_doc_string): Check for size calculation overflow.
11314 Don't update size until allocation succeeds.
11315 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
11316 EMACS_INT, where ptrdiff_t will do.
11317 (Fsubstitute_command_keys): Check for string overflow.
11318
11319 * editfns.c (set_time_zone_rule): Don't assume environment length
11320 fits in int.
11321 (message_length): Now ptrdiff_t, not int.
11322 (Fmessage_box): Don't update size until allocation succeeds.
11323 Don't assume message length fits in int.
11324 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
11325
0065d054
PE
11326 * emacs.c (main): Do not reallocate argv, since there is a null at
11327 the end that can be overwritten, and this way there's no need to
11328 worry about size-calculation overflow.
11329 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
11330
11331 * eval.c (init_eval_once, grow_specpdl): Don't update size until
11332 alloc succeeds.
11333 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
11334
11335 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
11336 (x_set_scroll_bar_width, x_figure_window_size):
11337 Check for integer overflow.
11338 (x_set_alpha): Do not assume XINT fits in int.
11339
11340 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
11341 This is for the members text_lines, text_cols, total_lines, total_cols,
11342 where the system imposes an 'int' limit.
11343
11344 * fringe.c (Fdefine_fringe_bitmap):
11345 Don't update size until alloc works.
11346
11347 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
11348 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
11349
11350 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
11351 Check for size-calculation overflow.
11352 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
11353 do, as we prefer signed integers.
11354 (id_to_widget.max_size, id_to_widget.used)
11355 (xg_store_widget_in_map, xg_remove_widget_from_map)
11356 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
11357 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
11358 Use and return ptrdiff_t, not int.
11359 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
11360 * gtkutil.h: Change prototypes to match the above.
11361
11362 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
11363 are duplicate now that they've been promoted to lisp.h.
11364 (x_allocate_bitmap_record, x_alloc_image_color)
11365 (make_image_cache, cache_image, xpm_load):
11366 Don't update size until alloc is done.
11367 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
11368 (x_detect_edges):
3256efce 11369 Check for size calculation overflow.
726e0ab1
PE
11370 (ct_colors_allocated_max): New constant.
11371 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
11372 overflow.
3256efce 11373
726e0ab1
PE
11374 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
11375 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
11376 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
11377 Use ptrdiff_t, not int, to count maps.
11378 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
11379 calculations. Don't update size until allocation succeeds.
11380 Redo calculations to avoid overflow.
726e0ab1
PE
11381 * keyboard.h: Change prototypes to match the above.
11382
11383 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
11384 to count maps.
11385 (current_minor_maps): Check for size calculation overflow.
11386 * keymap.h: Change prototypes to match the above.
11387
11388 * lread.c (read1, init_obarray): Don't update size until alloc done.
11389
11390 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
11391 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
11392
726e0ab1
PE
11393 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
11394 Now ptrdiff_t, not int.
11395 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
11396 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
11397
11398 * process.c (Fnetwork_interface_list): Check for overflow
11399 in size calculation.
11400
11401 * region-cache.c (move_cache_gap): Check for size calculation overflow.
11402
11403 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
11404 overflow. Don't bother calling xmalloc when xrealloc will do.
11405
11406 * search.c (Freplace_match): Check for size calculation overflow.
11407 (Fset_match_data): Don't assume list lengths fit in 'int'.
11408
11409 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
11410 for command line length. Do not attempt to address one before the
11411 beginning of an array, as that's not portable.
11412
11413 * term.c (max_frame_lines): Remove; unused.
11414 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
11415 not int.
11416 (encode_terminal_code, calculate_costs): Check for size
11417 calculation overflow.
11418 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
11419 table lengths and related sizes. Don't update size until alloc
11420 done. Redo calculations to avoid overflow.
11421 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
11422
11423 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
11424 subtracting pointers.
11425 (gobble_line): Check for overflow more carefully. Don't update size
11426 until alloc done.
11427
11428 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
11429 Don't update size until alloc done.
11430 Redo size calculations to avoid overflow.
11431 Check for size calculation overflow.
0065d054 11432 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
11433
11434 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
11435 Use ptrdiff_t, not int, for sizes.
11436 (store_mode_line_noprop_char): Don't update size until alloc done.
11437
0065d054
PE
11438 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
11439 Use ptrdiff_t, not int, for sizes.
11440 (Finternal_make_lisp_face, cache_face):
11441 Check for size calculation overflow.
11442 (cache_face): Treat size calculation overflows as if they were
11443 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
11444
11445 * xfns.c (x_encode_text, x_set_name_internal)
11446 (Fx_change_window_property): Use ptrdiff_t, not int, to count
11447 sizes, since they can exceed INT_MAX in size. Check for size
11448 calculation overflow.
11449
0065d054
PE
11450 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
11451 (xg_select): Check for size calculation overflow.
726e0ab1
PE
11452 Don't update size until alloc done.
11453
0065d054 11454 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 11455 as sprintf is limited to int lengths.
1d526e2f 11456
252c5ee1
PE
11457 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
11458 (X_LONG_MIN): New macros.
864d7ce7
PE
11459 Use them to make the following changes clearer.
11460 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
11461 This change doesn't affect the value now, but it may help remind
11462 future maintainers not to raise the value too much later.
11463 (SELECTION_QUANTUM): Remove, replacing with ...
11464 (selection_quantum): ... new function, which avoids overflow.
11465 All uses changed.
11466 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
11467 assumption that selection length fits in 'int'.
11468 (x_reply_selection_request, x_handle_selection_request)
11469 (x_get_window_property, receive_incremental_selection)
11470 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
11471 (lisp_data_to_selection_data, clean_local_selection_data):
11472 Use ptrdiff_t, not int, to record length of selection.
11473 (x_reply_selection_request, x_get_window_property)
11474 (receive_incremental_selection, x_property_data_to_lisp):
11475 Redo calculations to avoid overflow.
11476 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 11477 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
11478 something.
11479 (x_get_window_property, receive_incremental_selection)
11480 (lisp_data_to_selection_data, x_property_data_to_lisp):
11481 Check for size-calculation overflow.
11482 (x_get_window_property, receive_incremental_selection)
11483 (lisp_data_to_selection_data, Fx_register_dnd_atom):
11484 Don't store size until memory allocation succeeds.
11485 (x_get_window_property): Plug memory leak on memory exhaustion.
11486 Don't double-block input; malloc is safe here. Don't assume 2**34
11487 - 4 fits in unsigned long. Add an xassert to check
11488 XGetWindowProperty overflow. Be more careful about overflow
11489 calculations, and distinguish size from memory overflow better.
11490 (receive_incremental_selection): When tracing, don't assume
11491 unsigned int is less than INT_MAX.
11492 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
11493 harmful) conversions of unsigned short to int.
11494 (lisp_data_to_selection_data): Don't assume that integers
11495 in the range -65535 through -1 fit in an X unsigned short.
11496 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
11497 result parameters unless successful. Rely on cons_to_unsigned
11498 to report problems with elements; the old code wasn't right anyway.
11499 (x_check_property_data): Check for int overflow; we cannot use
11500 a wider type due to X limits.
11501 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
11502
726e0ab1 11503 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 11504
0065d054
PE
11505 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
11506 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
11507 (x_color_cells): Don't store size until memory allocation succeeds.
11508 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 11509 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
11510 (x_term_init): Don't assume length fits in int (sprintf is limited
11511 to int size).
bc18e09d 11512
ebfa62c0
PE
11513 Use ptrdiff_t for composition IDs.
11514 * character.c (lisp_string_width):
11515 * composite.c (composition_table_size, n_compositions)
11516 (get_composition_id, composition_gstring_from_id):
11517 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
11518 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
11519 * window.c (Frecenter):
11520 Use ptrdiff_t, not int, for composition IDs.
11521 * composite.c (get_composition_id): Check for integer overflow.
11522 * composite.h: Adjust prototypes to match the above changes.
11523
d3411f89
PE
11524 Use ptrdiff_t for hash table indexes.
11525 * category.c (hash_get_category_set):
11526 * ccl.c (ccl_driver):
11527 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
11528 * coding.c (coding_system_charset_list, detect_coding_system):
11529 * coding.h (struct coding_system.id):
11530 * composite.c (get_composition_id, gstring_lookup_cache):
11531 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
11532 * image.c (xpm_get_color_table_h):
11533 * lisp.h (hash_lookup, hash_put):
11534 * minibuf.c (Ftest_completion):
11535 Use ptrdiff_t for hash table indexes, not int (which is too
11536 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
11537 32-bit --with-wide-int hosts).
11538
e097a6fa
PE
11539 * charset.c (Fdefine_charset_internal): Check for integer overflow.
11540 Add a FIXME comment about memory leaks.
11541 (syms_of_charset): Don't assume xmalloc returns.
11542
5637687f
PE
11543 Don't assume that stated character widths fit in int.
11544 * character.c (Fchar_width, c_string_width, lisp_string_width):
11545 * character.h (CHAR_WIDTH):
11546 * indent.c (MULTIBYTE_BYTES_WIDTH):
11547 Use sanitize_char_width to avoid undefined and/or bad behavior
11548 with outlandish widths.
a66cfb1c 11549 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
11550 now that we have two such functions. All uses changed.
11551 (sanitize_char_width): New inline function.
11552
a2271ba2
PE
11553 Don't assume that tab-width fits in int.
11554 * character.h (sanitize_width): New inline function.
11555 (SANE_TAB_WIDTH): New macro.
11556 (ASCII_CHAR_WIDTH): Use it.
11557 * indent.c (sane_tab_width): Remove. All uses replaced by
11558 SANE_TAB_WIDTH (current_buffer).
11559 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
11560
18c52557
PE
11561 * fileio.c: Integer overflow issues with file modes.
11562 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
11563
caeeedc1
PE
11564 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
11565 Remove unreachable code.
11566 (read_hex, load_charset_map_from_file): Check for integer overflow.
11567
6df6ae42 11568 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
11569 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
11570 (x_send_scroll_bar_event): Likewise. Check that the size does not
11571 exceed limits imposed by XClientMessageEvent, as well as the usual
11572 ptrdiff_t and size_t limits.
11573
b13995db
PE
11574 * keyboard.c: Overflow, signedness and related fixes.
11575 (make_lispy_movement): Use same integer type in forward decl
11576 that is used in the definition.
11577 (read_key_sequence, keyremap_step):
11578 Change bufsize argument back to int, undoing my 2011-03-30 change.
11579 We prefer signed types, and int is wide enough here.
11580 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
11581 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
11582 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
11583 length, not size_t. Use ptrdiff_t for index, not int.
11584 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
11585 possibility of integer overflow.
11586
13464394
PE
11587 Overflow, signedness and related fixes for images.
11588
11589 * dispextern.h (struct it.stack[0].u.image.image_id)
11590 (struct_it.image_id, struct image.id, struct image_cache.size)
11591 (struct image_cache.used, struct image_cache.ref_count):
11592 * gtkutil.c (update_frame_tool_bar):
11593 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
11594 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
11595 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
11596 * nsmenu.m (update_frame_tool_bar):
11597 * xdisp.c (calc_pixel_width_or_height):
11598 * xfns.c (image_cache_refcount):
11599 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
11600 on typical 64-bit hosts.
11601
11602 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
11603 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
11604 Omit unnecessary casts to int.
11605 (parse_image_spec): Check that integers fall into 'int' range
11606 when the callers expect that.
11607 (image_ascent): Redo ascent calculation to avoid int overflow.
11608 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
11609 (lookup_image): Remove unnecessary tests.
11610 (xbm_image_p): Locals are now of int, not EMACS_INT,
11611 since parse_image_check makes sure they fit into int.
11612 (png_load, gif_load, svg_load_image):
11613 Prefer int to unsigned where either will do.
11614 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
11615 old tiff_error_handler and tiff_warning_handler.
11616 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
11617 stack buffer overflows. It uses only the features of vsnprintf
11618 that are common to both POSIX and native Microsoft.
11619 (tiff_error_handler, tiff_warning_handler): Use it.
11620 (tiff_load, gif_load, imagemagick_load_image):
11621 Don't assume :index value fits in 'int'.
11622 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
11623 (imagemagick_load_image): Check that crop parameters fit into
11624 the integer types that MagickCropImage accepts. Don't assume
11625 Vimagemagick_render_type has a nonnegative value. Don't assume
11626 size_t fits in 'long'.
11627 (gs_load): Use printmax_t to print the widest integers possible.
11628 Check for integer overflow when computing image height and width.
11629
c11821d4
EZ
116302011-08-26 Eli Zaretskii <eliz@gnu.org>
11631
11632 * xdisp.c (redisplay_window): Don't force window start if point
11633 will be invisible in the resulting window. (Bug#9324)
11634
0c95fcf7
EZ
116352011-08-25 Eli Zaretskii <eliz@gnu.org>
11636
11637 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
11638 the display spec is of the form `(space ...)'.
11639 (handle_display_spec): Return the value returned by
11640 handle_single_display_spec, not just 1 or zero.
11641 (handle_single_display_spec): If the display spec is of the form
11642 `(space ...)', and specifies display in the text area, return 2
11643 rather than 1.
fee65a97 11644 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
11645 accurately, and prefer exact match for point under bidi.
11646 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
11647
11648 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
11649 into disp_prop; all users changed.
11650
11651 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
11652 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
11653 for the text covered by the display property.
11654
e4ed06f1
CY
116552011-08-25 Chong Yidong <cyd@stupidchicken.com>
11656
11657 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
11658 Change return value to nil.
11659 (Frecord_buffer): Delete unused function.
11660
f67cdd7f
EZ
116612011-08-24 Eli Zaretskii <eliz@gnu.org>
11662
5980d4c6
EZ
11663 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
11664 buffers, return left-to-right.
8610fe8b
EZ
11665 (set_cursor_from_row): Consider candidate row a win if its glyph
11666 represents a newline and point is on that newline. Fixes cursor
11667 positioning on the newline at EOL of R2L text within L2R
11668 paragraph, and vice versa.
11669 (try_cursor_movement): Check continued rows, in addition to
11670 continuation rows. Fixes unwarranted scroll when point enters a
11671 continued line of R2L text within an L2R paragraph, or vice versa.
11672 (cursor_row_p): Consider the case of point being equal to
11673 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
11674 from the end of a short line to the beginning of a continued line
11675 of R2L text within L2R paragraph.
11676 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
11677 composed characters.
5980d4c6 11678
f67cdd7f
EZ
11679 * bidi.c (bidi_check_type): Use xassert.
11680 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
11681 members.
11682
bca633fb
EZ
116832011-08-23 Eli Zaretskii <eliz@gnu.org>
11684
11685 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
11686 a character.
11687
4a5885a7
CY
116882011-08-23 Chong Yidong <cyd@stupidchicken.com>
11689
11690 * nsfont.m (ns_otf_to_script): Fix typo.
11691
0902a04e
KH
116922011-08-22 Kenichi Handa <handa@m17n.org>
11693
11694 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
11695 extra slot even if the purpose is char-code-property-table.
11696
1a2e6670
EZ
116972011-08-23 Eli Zaretskii <eliz@gnu.org>
11698
8ddde651
EZ
11699 * xdisp.c (redisplay_window): When computing centering_position,
11700 account for the height of the header line. (Bug#8874)
11701
425cc014
EZ
11702 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
11703 instead of CHAR_TO_BYTE. Fixes a crash when a completion
11704 candidate is selected by the mouse, and that candidate has a
11705 composed character under the mouse.
11706
1a2e6670
EZ
11707 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
11708 coordinates reported by pos-visible-in-window-p for a composed
11709 character in column zero.
11710
8b76d6f8
SM
117112011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
11712
11713 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
11714
dac347dd
EZ
117152011-08-22 Eli Zaretskii <eliz@gnu.org>
11716
11717 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
11718 consider it a hit if to_charpos is anywhere in the range of the
11719 composed buffer positions.
11720
e013fb34
CY
117212011-08-22 Chong Yidong <cyd@stupidchicken.com>
11722
11723 * image.c (gif_load): Don't assume that each subimage has the same
11724 dimensions as the base image. Handle disposal method that is
11725 "undefined" by the gif spec (Bug#9335).
11726
bd1ba3e8
CY
117272011-08-20 Chong Yidong <cyd@stupidchicken.com>
11728
11729 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 11730 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 11731
54a1215b
EZ
117322011-08-19 Eli Zaretskii <eliz@gnu.org>
11733
823564e5
EZ
11734 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
11735 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
11736 from an Org mode buffer to a Speedbar frame.
11737
54a1215b
EZ
11738 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
11739 a composition, take its buffer position from IT->cmp_it.charpos.
11740 Fixes cursor positioning at the beginning of a line that begins
11741 with a composed character.
11742
9778ebcc
EZ
117432011-08-18 Eli Zaretskii <eliz@gnu.org>
11744
0be6ee06
EZ
11745 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
11746 character bidirectional type, use STRONG_L instead. Fixes crashes
11747 in a buffer produced by `describe-categories'.
11748
9778ebcc
EZ
11749 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
11750 members before the level stack, so they would be saved and
11751 restored when copying iterator state. Fixes incorrect reordering
11752 around TABs covered by display properties.
11753
156bffbe
AS
117542011-08-18 Andreas Schwab <schwab@linux-m68k.org>
11755
6b02f655 11756 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 11757
72ad093b
CY
117582011-08-17 Chong Yidong <cyd@stupidchicken.com>
11759
11760 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
11761 (internal_condition_case_2, internal_condition_case_n):
11762 Remove unnecessary aborts (Bug#9081).
72ad093b 11763
35774242
EZ
117642011-08-17 Eli Zaretskii <eliz@gnu.org>
11765
11766 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
11767 has no `load' handler, try opening the file locally. (Bug#9311)
11768
db76dd85
KB
117692011-08-16 Ken Brown <kbrown@cornell.edu>
11770
11771 * gmalloc.c: Expand comment.
11772
b215eee5
EZ
117732011-08-16 Eli Zaretskii <eliz@gnu.org>
11774
11775 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
11776 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
11777
a4579d33
KB
117782011-08-16 Ken Brown <kbrown@cornell.edu>
11779
11780 Fix memory allocation problems in Cygwin build (Bug#9273).
11781
11782 * unexcw.c ( __malloc_initialized): Declare external variable.
11783 (fixup_executable): Force the dumped emacs to reinitialize malloc.
11784
8b76d6f8
SM
11785 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
11786 New variables.
a4579d33
KB
11787 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
11788 dumped emacs.
11789 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
11790 in the static heap.
11791 [CYGWIN] (special_realloc): New function.
11792 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
11793 requests to realloc storage in the static heap.
11794
3ebec551
PE
117952011-08-15 Paul Eggert <eggert@cs.ucla.edu>
11796
11797 * bidi.c (bidi_initialize): Remove unused local.
11798
9fd8be00
EZ
117992011-08-15 Eli Zaretskii <eliz@gnu.org>
11800
6b02f655
SM
11801 * bidimirror.h:
11802 * biditype.h: Remove file.
11803 * makefile.w32-in ($(BLD)/bidi.$(O)):
11804 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
11805
11806 * dispextern.h: Fix a typo in the comment to bidi_type_t.
11807
11808 * chartab.c: Improve commentary for the uniprop_table API.
11809
32413314
EZ
11810 * bidi.c (bidi_paragraph_init): Support zero value of
11811 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
11812 (bidi_initialize): Use uniprop_table instead of including
11813 biditype.h and bidimirror.h.
32413314 11814
9fd8be00
EZ
11815 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
11816 coordinates of the iterator when restoring from ppos_it.
11817 (Bug#9296)
11818
5cf2b69b
KH
118192011-08-14 Kenichi Handa <handa@m17n.org>
11820
11821 * process.c (create_process): Call setup_process_coding_systems
72ad093b 11822 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 11823
daf17d00
EZ
118242011-08-14 Eli Zaretskii <eliz@gnu.org>
11825
11826 * xdisp.c (move_it_in_display_line_to): Don't invoke
11827 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
11828 ppos_it. Fixes vertical cursor motion when line beginning is
11829 covered by an image. (Bug#9296)
11830
08e3161a
JD
118312011-08-14 Jan Djärv <jan.h.d@swipnet.se>
11832
11833 * nsterm.h (ns_run_ascript): Declare.
11834 (NSAPP_DATA2_RUNASSCRIPT): Define.
11835
11836 * nsfns.m (as_script, as_result, as_status): New static variables.
11837 (ns_run_ascript): New function.
5e617bc2 11838 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
11839 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
11840 the event loop. Get status from as_status (Bug#7276).
11841
11842 * nsterm.m (sendEvent): If event is NSApplicationDefined and
11843 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
11844 the event loop (Bug#7276).
11845
a3720aa2
AS
118462011-08-14 Andreas Schwab <schwab@linux-m68k.org>
11847
11848 * gnutls.c (QCgnutls_bootprop_priority)
11849 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
11850 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
11851 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
11852 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
11853 (QCgnutls_bootprop_verify_hostname_error)
11854 (QCgnutls_bootprop_callbacks_verify): Rename from
11855 Qgnutls_bootprop_..., all uses changed.
11856
11857 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
11858 uses changed.
11859
0a0d27fb
PE
118602011-08-14 Paul Eggert <eggert@cs.ucla.edu>
11861
19d5c50c
PE
11862 * xfaces.c (Qframe_set_background_mode): Now static.
11863 * dispextern.h (Qframe_set_background_mode): Remove decl.
11864
0a0d27fb
PE
11865 * process.c (Fnetwork_interface_info): Declare local only if needed.
11866
377538cb
JD
118672011-08-13 Jan Djärv <jan.h.d@swipnet.se>
11868
11869 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
11870 (Fnetwork_interface_list): Allocate in increments of bytes instead
11871 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
11872 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
11873 sockaddr.
11874 (struct ifflag_def): notrailers is smart on OSX.
11875 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
11876 Get hardware address with getifaddrs if available.
11877
08fff70c
EZ
118782011-08-12 Eli Zaretskii <eliz@gnu.org>
11879
11880 * xdisp.c (iterate_out_of_display_property): xassert that
11881 IT->position is set to within IT->object's boundaries. Break from
11882 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
11883 when IT->position is set up wrongly due to some bug.
11884 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
11885 (push_display_prop): Allow GET_FROM_STRING as IT->method on
11886 entry. Force push_it to save on the stack the current
11887 buffer/string position, to be restored by pop_it. Fix flags in
11888 the iterator structure wrt the object coming from a display
11889 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
11890 properties. (Bug#9284)
11891
7be1c708 118922011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 11893
7be1c708
CY
11894 * fontset.c (fontset_get_font_group): Add proper type checks.
11895 (Bug#9172)
aac0c6e3 11896
7be1c708 118972011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 11898
7be1c708
CY
11899 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
11900 and LC_VERSION_MIN_MACOSX.
11901 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
11902 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 11903
97bb72a6
EZ
119042011-08-08 Eli Zaretskii <eliz@gnu.org>
11905
11906 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
11907 no-display-properties-and-no-overlays under bidi display.
11908 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 11909 properties and overlays.
97bb72a6 11910
d5617611
CY
119112011-08-08 Chong Yidong <cyd@stupidchicken.com>
11912
37e11a63
CY
11913 * editfns.c (Fset_time_zone_rule): Document relationship with the
11914 setenv function.
11915
d5617611
CY
11916 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
11917 the font entity extracted from the cache (Bug#8109).
11918
58872834
CY
119192011-08-07 Chong Yidong <cyd@stupidchicken.com>
11920
11921 * composite.c (autocmp_chars): Don't reset point. That is done by
11922 restore_point_unwind (Bug#5984).
11923
75bfc667
JL
119242011-08-07 Juri Linkov <juri@jurta.org>
11925
11926 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
11927 to show the arg `TIME' instead of `TIMEVAL'.
11928
d1410150
EZ
119292011-08-06 Eli Zaretskii <eliz@gnu.org>
11930
11931 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
11932 display property strides EOL and includes a newline, as in
11933 longlines-mode. (Bug#9254)
75b771e4
EZ
11934 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
11935 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
11936
11937 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
11938 is non-zero, even if the data buffer is NULL. Fixes a crash in
11939 vertical-motion with longlines-mode. (Bug#9254)
11940
35928349
EZ
119412011-08-05 Eli Zaretskii <eliz@gnu.org>
11942
ec7cc85b
EZ
11943 * bidi.c <bidi_cache_total_alloc>: Now static.
11944 (bidi_initialize): Initialize bidi_cache_total_alloc.
11945
8b76d6f8 11946 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
11947 cache. (Bug#9221)
11948
11949 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
11950 amount allocated this far in `bidi_cache_total_alloc'.
11951 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
11952 non-zero, only free the data buffer without restoring the cache
11953 contents. All callers changed.
11954
11955 * dispextern.h (bidi_unshelve_cache): Update prototype.
11956
11957 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
11958 (move_it_in_display_line, move_it_to)
11959 (move_it_vertically_backward, move_it_by_lines): Replace the call
11960 to xfree to an equivalent call to bidi_unshelve_cache.
11961 (move_it_in_display_line_to): Fix logic of returning
412b6358 11962 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 11963
e2e2423b
EZ
119642011-08-05 Eli Zaretskii <eliz@gnu.org>
11965
11966 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
11967 came from a string character with a `cursor' property. (Bug#9229)
11968
ae9e757a
JD
119692011-08-04 Jan Djärv <jan.h.d@swipnet.se>
11970
11971 * Makefile.in (LIB_PTHREAD): New variable.
11972 (LIBES): Add LIB_PTHREAD (Bug#9216).
11973
11974 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
11975 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
11976
213bd7f2
AS
119772011-08-04 Andreas Schwab <schwab@linux-m68k.org>
11978
6b02f655 11979 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 11980
99aaf75f
JD
119812011-08-04 Jan Djärv <jan.h.d@swipnet.se>
11982
11983 * xterm.c (x_find_topmost_parent): New function.
11984 (x_set_frame_alpha): Find topmost parent window with
11985 x_find_topmost_parent and set the property there also (bug#9181).
11986 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
11987
c74e9d86
PE
119882011-08-04 Paul Eggert <eggert@cs.ucla.edu>
11989
11990 * callproc.c (Fcall_process): Avoid vfork clobbering
11991 the local vars buffer, coding_systems, current_dir.
11992
640c8776
SM
119932011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
11994
11995 * keymap.c (Fmake_composed_keymap): Move to subr.el.
11996
f26d0e4c
PE
119972011-08-03 Paul Eggert <eggert@cs.ucla.edu>
11998
8a10d76c
PE
11999 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
12000 so that it is not optimized away.
12001
f26d0e4c
PE
12002 * xdisp.c (compute_display_string_pos): Remove unused local.
12003
55439c61
EZ
120042011-08-02 Eli Zaretskii <eliz@gnu.org>
12005
12006 Fix slow cursor motion and scrolling in large buffers with
12007 selective display, like Org Mode buffers. (Bug#9218)
12008
12009 * dispextern.h (struct bidi_it): New member disp_prop_p.
12010
12011 * xdisp.c: Remove one-slot cache of display string positions.
12012 (compute_display_string_pos): Accept an additional argument
5e617bc2 12013 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
12014 for a display string or property. If found, set DISP_PROP_P
12015 non-zero.
12016
12017 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
12018 DISP_PROP_P, and pass it to compute_display_string_pos.
12019 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
12020 non-zero. All callers of bidi_fetch_char changed.
12021
fb33fa43
SM
120222011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
12023
12024 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
12025
b099e063
DM
120262010-12-03 Don March <don@ohspite.net>
12027
12028 * keymap.c (Fdefine_key): Fix non-prefix key error message when
12029 last character M-[char] is translated to ESC [char] (bug#7541).
12030
5cc7f7af
KH
120312011-08-02 Kenichi Handa <handa@m17n.org>
12032
d0fffa3f 12033 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
12034
12035 * chartab.c (uniprop_table): Make it non-static.
12036
525d5e6e
EZ
120372011-08-01 Eli Zaretskii <eliz@gnu.org>
12038
12039 * xdisp.c (forward_to_next_line_start): Accept additional argument
12040 BIDI_IT_PREV, and store into it the state of the bidi iterator had
12041 on the newline.
12042 (reseat_at_next_visible_line_start): Use the bidi iterator state
12043 returned by forward_to_next_line_start to restore the state of
12044 it->bidi_it after backing up to previous newline. (Bug#9212)
12045
31011111
AS
120462011-07-30 Andreas Schwab <schwab@linux-m68k.org>
12047
12048 * regex.c (re_comp): Protoize.
12049 (re_exec): Fix return type.
12050 (regexec): Fix type of `ret'. (Bug#9203)
12051
476371c4
PE
120522011-07-28 Paul Eggert <eggert@cs.ucla.edu>
12053
e5d76069
PE
12054 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
12055 This is needed if max-image-size is a floating-point number.
12056
9a79b20c
AS
120572011-07-28 Andreas Schwab <schwab@linux-m68k.org>
12058
12059 * print.c (print_object): Print empty symbol as ##.
12060
12061 * lread.c (read1): Read ## as empty symbol.
12062
d8c2fa78
AA
120632011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
12064
12065 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
12066 setting frame foreground color (Bug#9175).
12067 (x_set_background_color): Likewise.
12068
ffe57a7a
AA
12069 * nsmenu.m (-setText): Size tooltip dimensions precisely to
12070 contents (Bug#9176).
12071 (EmacsTooltip -init): Remove bezels and add shadows to
12072 tooltip windows.
12073
bf3492a5
AA
12074 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
12075 or scroll bar (Bug#8470).
12076
d55e9c53
AA
12077 * nsfont.m (nsfont_open): Remove assignment to voffset and
12078 unnecessary vars hshink, expand, hd, full_height, min_height.
12079 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
12080
12081 * nsterm.h (nsfont_info): Remove voffset field.
12082
d8c2fa78 120832011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
12084
12085 Implement strike-through and overline on NextStep (Bug#8863).
12086
12087 * nsfont.m (nsfont_open): Use underline position provided by font,
12088 instead of hard-coded value of 2.
12089 (nsfont_draw): Call ns_draw_text_decoration instead.
12090
12091 * nsterm.h: Add declaration for ns_draw_text_decoration.
12092
12093 * nsterm.m (ns_draw_text_decoration): New function for drawing
12094 underline, overline, and strike-through.
12095 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
12096 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 12097 accommodate underlining, etc.
4843aac3 12098
4cc60b9b
EZ
120992011-07-28 Eli Zaretskii <eliz@gnu.org>
12100
bc7ece87
EZ
12101 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
12102 default.
4cc60b9b 12103
476371c4
PE
121042011-07-28 Paul Eggert <eggert@cs.ucla.edu>
12105
66606eea
PE
12106 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
12107 Without this fix, if a signal arrives just after memory fills up,
12108 'malloc' might be invoked reentrantly.
12109
476371c4
PE
12110 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
12111 In other words, assume that every image size is allowed, on non-X
12112 hosts. This assumption is probably wrong, but it lets Emacs compile.
12113
f3fcc40d
AS
121142011-07-28 Andreas Schwab <schwab@linux-m68k.org>
12115
12116 * regex.c (re_iswctype): Convert return values to boolean.
12117
350c992f
EZ
121182011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
12119
12120 * xdisp.c (compute_display_string_pos): Don't use cached display
12121 string position if the buffer had its restriction changed.
12122 (Bug#9184)
12123
5266b4bb
PE
121242011-07-28 Paul Eggert <eggert@cs.ucla.edu>
12125
12126 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
12127
2573a837 121282011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 12129
41f55ccd 12130 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 12131
39e378da
PE
12132 * bidi.c: Integer size and overflow fixes.
12133 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
12134 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
12135 (bidi_cache_find_level_change, bidi_cache_ensure_space)
12136 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
12137 (bidi_find_other_level_edge):
12138 Use ptrdiff_t instead of EMACS_INT where either will do.
12139 This works better on 32-bit hosts configured --with-wide-int.
12140 (bidi_cache_ensure_space): Check for size-calculation overflow.
12141 Use % rather than repeated addition, for better worst-case speed.
12142 Don't set bidi_cache_size until after xrealloc returns, because it
12143 might not return.
12144 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
12145 (bidi_cache_ensure_space): Also check that the bidi cache size
12146 does not exceed that of the largest Lisp string or buffer. See Eli
12147 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 12148
5e927815
PE
12149 * alloc.c (__malloc_size_t): Remove.
12150 All uses replaced by size_t. See Andreas Schwab's note
12151 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
12152
ca4aa935
PE
12153 * image.c: Improve checking for integer overflow.
12154 (check_image_size): Assume that f is nonnull, since
12155 it is always nonnull in practice. This is one less thing to
12156 worry about when checking for integer overflow later.
12157 (x_check_image_size): New function, which checks for integer
12158 overflow issues inside X.
12159 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
12160 This removes the need for a memory_full check.
12161 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
12162 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
12163 (xbm_read_bitmap_data): Change locals back to 'int', since
12164 their values must fit in 'int'.
12165 (xpm_load_image, png_load, tiff_load):
12166 Invoke x_create_x_image_and_pixmap earlier,
12167 to avoid much needless work if the image is too large.
12168 (tiff_load): Treat overly large images as if
12169 x_create_x_image_and_pixmap failed, not as malloc failures.
12170 (gs_load): Use x_check_image_size.
12171
5f8f9cc2
PE
12172 * gtkutil.c: Omit integer casts.
12173 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
12174 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
12175
5adf60bc
PE
12176 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
12177
c8907a93
PE
12178 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
12179 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
12180 would wrongly return t on a 64-bit host.
12181
e3c25c68
PE
12182 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
12183 The plain *_OVERFLOW macros run afoul of GCC bug 49705
12184 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
12185 and therefore cause GCC to emit a bogus diagnostic in some cases.
12186
3f791afe
PE
12187 * image.c: Integer signedness and overflow and related fixes.
12188 This is not an exhaustive set of fixes, but it's time to
12189 record what I've got.
12190 (lookup_pixel_color, check_image_size): Remove redundant decls.
12191 (check_image_size): Don't assume that arbitrary EMACS_INT values
12192 fit in 'int', or that arbitrary 'double' values fit in 'int'.
12193 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
12194 (tiff_load, imagemagick_load_image):
12195 Check for overflow in size calculations.
12196 (x_create_x_image_and_pixmap): Remove unnecessary test for
12197 xmalloc returning NULL; that can't happen.
12198 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
12199 (xpm_color_bucket): Use better integer hashing function.
12200 (xpm_cache_color): Don't possibly over-allocate memory.
12201 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
12202 (gif_memory_source):
12203 Use ptrdiff_t, not int or size_t, to record sizes.
12204 (png_load): Don't assume values greater than 2**31 fit in 'int'.
12205 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
12206 either works, as we prefer signed integers.
12207 (tiff_read_from_memory, tiff_write_from_memory):
12208 Return tsize_t, not size_t, since that's what the TIFF API wants.
12209 (tiff_read_from_memory): Don't fail simply because the read would
12210 go past EOF; instead, return a short read.
12211 (tiff_load): Omit no-longer-needed casts.
12212 (Fimagemagick_types): Don't assume size fits into 'int'.
12213
3cc5a532
PE
12214 Improve hashing quality when configured --with-wide-int.
12215 * fns.c (hash_string): New function, taken from sxhash_string.
12216 Do not discard information about ASCII character case; this
12217 discarding is no longer needed.
12218 (sxhash-string): Use it. Change sig to match it. Caller changed.
12219 * lisp.h: Declare it.
12220 * lread.c (hash_string): Remove, since we now use fns.c's version.
12221 The fns.c version returns a wider integer if --with-wide-int is
12222 specified, so this should help the quality of the hashing a bit.
12223
b312a492
PE
12224 * emacs.c: Integer overflow minor fix.
12225 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
12226 Define only if GNU_LINUX.
12227 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
12228
dfd153ae
PE
12229 * dispnew.c: Integer signedness and overflow fixes.
12230 Remove unnecessary forward decls, that were a maintenance hassle.
12231 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
12232 All uses changed.
12233 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
12234 (scrolling_window): Use ptrdiff_t, not int, for byte count.
12235 (prepare_desired_row, line_draw_cost):
12236 Use int, not unsigned, where either works.
12237 (save_current_matrix, restore_current_matrix):
12238 Use ptrdiff_t, not size_t, where either works.
12239 (init_display): Check for overflow more accurately, and without
12240 relying on undefined behavior.
12241
a81d11a3
PE
12242 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
12243 Remove, replacing with the new symbols in lisp.h. All uses changed.
12244 * fileio.c (make_temp_name):
12245 * filelock.c (lock_file_1, lock_file):
12246 * xdisp.c (message_dolog):
12247 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
12248 Use pMd etc. instead.
12249 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
12250 replacing the pWIDE etc. symbols removed from editfns.c.
12251
3300e6fd
PE
12252 * keyboard.h (num_input_events): Now uintmax_t.
12253 This is (very slightly) less likely to mess up due to wraparound.
12254 All uses changed.
12255
fd05c7e9
PE
12256 * buffer.c: Integer signedness fixes.
12257 (alloc_buffer_text, enlarge_buffer_text):
12258 Use ptrdiff_t rather than size_t when either will do, as we prefer
12259 signed integers.
12260
903fe15d
PE
12261 * alloc.c: Integer signedness and overflow fixes.
12262 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
12263 (__malloc_size_t): Default to size_t, not to int.
12264 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
12265 (Fgarbage_collect, mark_object_loop_halt, mark_object):
12266 Prefer ptrdiff_t to size_t when either would do, as we prefer
12267 signed integers.
12268 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
12269 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
12270 Now const. Initialize with values that are in range even if char
12271 is signed.
12272 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
12273 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
12274 These functions do the right thing with sizes > 2**32.
12275 (check_depth): Now ptrdiff_t, not int.
12276 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
12277 Adjust to new way of storing sizes. Check for size overflow bugs
12278 in rest of code.
12279 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
12280 slightly wrong anyway, as it missed one instance of
12281 XMALLOC_OVERRUN_CHECK_OVERHEAD.
12282 (refill_memory_reserve): Omit needless cast to size_t.
12283 (mark_object_loop_halt): Mark as externally visible.
12284
ac82cc6a
PE
12285 * xselect.c: Integer signedness and overflow fixes.
12286 (Fx_register_dnd_atom, x_handle_dnd_message):
12287 Use ptrdiff_t, not size_t, since we prefer signed.
12288 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
12289 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
12290 x_dnd_atoms_size and x_dnd_atoms_length.
12291
c2d1e36d
PE
12292 * doprnt.c: Prefer signed to unsigned when either works.
12293 * eval.c (verror):
12294 * doprnt.c (doprnt):
12295 * lisp.h (doprnt):
12296 * xdisp.c (vmessage):
12297 Use ptrdiff_t, not size_t, when using or implementing doprnt,
12298 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
12299 prefer signed arithmetic to avoid comparison confusion.
12300 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
12301 but is a bit tricky.
12302
0e926e56
PE
12303 Assume freestanding C89 headers, string.h, stdlib.h.
12304 * data.c, doprnt.c, floatfns.c, print.c:
12305 Include float.h unconditionally.
12306 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
12307 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
12308 * regex.c: Likewise for stddef.h, string.h.
12309 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
12310 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
12311 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
12312 (STDC_HEADERS): Remove obsolete defines.
12313 * sysdep.c: Include limits.h unconditionally.
12314
9cfdb3ec
PE
12315 Assume support for memcmp, memcpy, memmove, memset.
12316 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
12317 * regex.c (memcmp, memcpy):
12318 Remove; we assume C89 now.
12319
12320 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
12321 (__malloc_safe_bcopy): Remove; no longer needed.
12322
cf950e6b 12323 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
12324 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
12325 well either way, and we prefer signed to unsigned.
12326
dbf38e02
LMI
123272011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
12328
12329 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
12330 closes the connection while we're reading (bug#9182).
12331
d6f0886c 123322011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 12333
d6f0886c
JD
12334 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
12335 are specified (Bug#9168).
24e0f6b1 12336
2eb1f9e6
PE
123372011-07-25 Paul Eggert <eggert@cs.ucla.edu>
12338
12339 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
12340 Found by GCC static checking and --with-wide-int on a 32-bit host.
12341
22381272 123422011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
12343
12344 * xdisp.c (compute_display_string_pos): Fix logic of caching
12345 previous display string position. Initialize cached_prev_pos to
12346 -1. Fixes slow-down at the beginning of a buffer.
12347
f25e39b4
EZ
123482011-07-24 Eli Zaretskii <eliz@gnu.org>
12349
12350 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
12351 for attrs[LFACE_FONTSET_INDEX].
12352
04c4b52e
PE
123532011-07-23 Paul Eggert <eggert@cs.ucla.edu>
12354
12355 * xml.c (parse_region): Remove unused local
12356 that was recently introduced.
12357
c1734fbd
EZ
123582011-07-23 Eli Zaretskii <eliz@gnu.org>
12359
be18c5a5
EZ
12360 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
12361 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
12362
c1734fbd
EZ
12363 * xdisp.c (move_it_in_display_line_to): Record the best matching
12364 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
12365 exit if none of the characters scanned was an exact match.
12366 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
12367 when exact match is impossible due to invisible text, and the
12368 lines are truncated.
12369
a258d627
JD
123702011-07-23 Jan Djärv <jan.h.d@swipnet.se>
12371
12372 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
12373 for OSX >= 10.7.
12374
b6d5a689
EZ
123752011-07-22 Eli Zaretskii <eliz@gnu.org>
12376
0f74f785
EZ
12377 Fix a significant slow-down of cursor motion with C-n, C-p,
12378 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
12379 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 12380 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
12381 (next_element_from_buffer): Call compute_stop_pos_backwards to
12382 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
12383 base_level_stop.
12384 (reseat): Don't look for prev_stop, as that could mean a very long
12385 run.
12386 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
12387 <cached_disp_overlay_modiff>: Cache for last found display string
12388 position.
551918c1 12389 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
12390 about the same buffer in the same area of character positions, and
12391 the buffer wasn't changed since the time the display string
12392 position was cached.
551918c1 12393
b2d0c91a
EZ
123942011-07-22 Eli Zaretskii <eliz@gnu.org>
12395
12396 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
12397 is an integer, which is important for empty lines. (Bug#9149)
12398
043604ee
CY
123992011-07-22 Chong Yidong <cyd@stupidchicken.com>
12400
12401 * frame.c (Fmodify_frame_parameters): In tty case, update the
12402 default face if necessary (Bug#4238).
12403
da4adb04
CY
124042011-07-21 Chong Yidong <cyd@stupidchicken.com>
12405
12406 * editfns.c (Fstring_to_char): No need to explain what a character
12407 is in the docstring (Bug#6576).
12408
9abd0532
LMI
124092011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
12410
12411 * xml.c (parse_region): Make sure we always return a tree.
12412
36881d16
HK
124132011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
12414
12415 * xml.c (parse_region): If a document contains only comments,
12416 return that, too.
12417
1e98674d
LMI
124182011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
12419
12420 * xml.c (make_dom): Return comments, too.
12421
590bd467
PE
124222011-07-19 Paul Eggert <eggert@cs.ucla.edu>
12423
12424 Port to OpenBSD.
12425 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
12426 and the surrounding thread.
12427 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
12428 rather than fgets, and retry after EINTR. Otherwise, 'emacs
12429 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
12430 timer goes off.
12431 * s/openbsd.h (BROKEN_SIGIO): Define.
12432 * unexelf.c (unexec) [__OpenBSD__]:
12433 Don't update the .mdebug section of the Alpha COFF symbol table.
12434
f41628b2
LMI
124352011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
12436
12437 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
12438 (bug#8460).
12439
b59b67c5
PE
124402011-07-18 Paul Eggert <eggert@cs.ucla.edu>
12441
15e3a074
PE
12442 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
12443 This fixes some race conditions on the permissions of any newly
12444 created file.
12445
41bed37d
PE
12446 * alloc.c (valid_pointer_p): Use pipe, not open.
12447 This fixes some permissions issues when debugging.
12448
b59b67c5
PE
12449 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
12450 If fchown fails to set both uid and gid, try to set just gid,
12451 as that is sometimes allowed. Adjust the file's mode to eliminate
12452 setuid or setgid bits that are inappropriate if fchown fails.
12453
925a6be7
SM
124542011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
12455
12456 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
12457 to compare Lisp_Objects.
12458 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
12459 global_gnutls_log_level, don't mistake it for a Lisp_Object.
12460 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
12461
52968808
AS
124622011-07-17 Andreas Schwab <schwab@linux-m68k.org>
12463
0a6a104b
AS
12464 * lread.c (read_integer): Unread even EOF character.
12465 (read1): Likewise. Properly record start position of symbol.
12466
52968808
AS
12467 * lread.c (read1): Read `#:' as empty uninterned symbol if no
12468 symbol character follows.
12469
9e381cdd
PE
124702011-07-17 Paul Eggert <eggert@cs.ucla.edu>
12471
12472 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
12473 This works around a problem with the previous change to Fcopy_file.
12474 Recent glibc declares fchown with __attribute__((warn_unused_result)),
12475 and without this change, GCC might complain about discarding
12476 fchown's return value.
12477
b5641435
JB
124782011-07-16 Juanma Barranquero <lekktu@gmail.com>
12479
12480 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
12481
a8031457
PE
124822011-07-16 Paul Eggert <eggert@cs.ucla.edu>
12483
12484 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
12485
dd889327
LMI
124862011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
12487
750c33f7
LMI
12488 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
12489 it's used from the C level.
12490
dd889327
LMI
12491 * process.c: Use the same condition for POLL_FOR_INPUT in both
12492 keyboard.c and process.c (bug#1858).
12493
87e86684
LM
124942011-07-09 Lawrence Mitchell <wence@gmx.li>
12495
12496 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
12497 (Fgnutls_boot): Use it.
12498
64348f40
AS
124992011-07-15 Andreas Schwab <schwab@linux-m68k.org>
12500
12501 * doc.c (Fsubstitute_command_keys): Revert last change.
12502
1d698799
LMI
125032011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
12504
f863868c
LMI
12505 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
12506 quotes the next character, and doesn't affect other longer
12507 sequences (bug#8935).
12508
1d698799
LMI
12509 * lread.c (syms_of_lread): Clarify that is isn't only
12510 `eval-buffer' and `eval-defun' that's affected by
12511 `lexical-binding' (bug#8460).
12512
aa4b6df6
EZ
125132011-07-15 Eli Zaretskii <eliz@gnu.org>
12514
12515 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 12516 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 12517
5d856da6
PE
125182011-07-14 Paul Eggert <eggert@cs.ucla.edu>
12519
ad6042bb
PE
12520 Fix minor problems found by static checking.
12521 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
12522 (elsz): Now a signed constant, not a size_t var. We prefer signed
12523 types to unsigned, to avoid integer comparison confusion. Without
12524 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
12525 "cannot optimize loop, the loop counter may overflow", a symptom
12526 of the confusion.
f00bbb22 12527 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
12528 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
12529
6468f31c
LMI
125302011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
12531
49080b10
LMI
12532 * search.c (Fre_search_backward): Mention `case-fold-search' in
12533 all the re_search_* functions (bug#8138).
12534
6468f31c
LMI
12535 * keyboard.c (Fopen_dribble_file): Document when the file is
12536 closed (bug#8056).
12537
c965adc5
EZ
125382011-07-14 Eli Zaretskii <eliz@gnu.org>
12539
df9733bf
EZ
12540 * bidi.c (bidi_dump_cached_states): Fix format of displaying
12541 bidi_cache_idx.
12542
0bb23927
EZ
12543 Support bidi reordering of display and overlay strings.
12544 * xdisp.c (compute_display_string_pos)
12545 (compute_display_string_end): Accept additional argument STRING.
12546 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
12547 (reseat_to_string): Initialize bidi_it->string.s and
12548 bidi_it->string.schars.
12549 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
12550 NULL (avoids a crash in bidi_paragraph_init).
12551 Initialize itb.string.lstring.
0bb23927
EZ
12552 (init_iterator): Call bidi_init_it only of a valid
12553 buffer position was specified. Initialize paragraph_embedding to
12554 L2R.
12555 (reseat_to_string): Initialize the bidi iterator.
12556 (display_string): If we need to ignore text properties of
12557 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
12558 original value of -1 will not work with bidi.)
12559 (compute_display_string_pos): First arg is now struct
12560 `text_pos *'; all callers changed. Support display properties on
12561 Lisp strings.
12562 (compute_display_string_end): Support display properties on Lisp
12563 strings.
12564 (init_iterator, reseat_1, reseat_to_string): Initialize the
12565 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
12566 when iterating on a string not from display properties).
640c8776
SM
12567 (compute_display_string_pos, compute_display_string_end):
12568 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
12569 arrow keys.
12570 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
12571 base_level_stop; instead, set base_level_stop to BEGV.
12572 Fixes crashes in vertical-motion.
0bb23927
EZ
12573 (next_element_from_buffer): Improve commentary for when
12574 the iterator is before prev_stop.
12575 (init_iterator): Initialize bidi_p from the default value of
12576 bidi-display-reordering, not from buffer-local value. Use the
12577 buffer-local value only if initializing for buffer iteration.
12578 (handle_invisible_prop): Support invisible properties on strings
12579 that are being bidi-reordered.
12580 (set_iterator_to_next): Support bidi reordering of C strings and
12581 Lisp strings.
12582 (next_element_from_string): Support bidi reordering of Lisp
12583 strings.
12584 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
12585 (display_string): Support display of R2L glyph rows.
12586 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
12587 (init_iterator): Don't initialize it->bidi_p for strings
12588 here.
12589 (reseat_to_string): Initialize it->bidi_p for strings here.
12590 (next_element_from_string, next_element_from_c_string)
12591 (next_element_from_buffer): Add xassert's for correspondence
12592 between IT's object being iterated and it->bidi_it.string
12593 structure.
12594 (face_before_or_after_it_pos): Support bidi iteration.
12595 (next_element_from_c_string): Handle the case of the first string
12596 character that is not the first one in the visual order.
12597 (get_visually_first_element): New function, refactored from common
12598 parts of next_element_from_buffer, next_element_from_string, and
12599 next_element_from_c_string.
12600 (tool_bar_lines_needed, redisplay_tool_bar)
12601 (display_menu_bar): Force left-to-right direction. Add a FIXME
12602 comment for making that be controlled by a user option.
12603 (push_it, pop_it): Save and restore the state of the
12604 bidi iterator. Save and restore the bidi_p flag.
12605 (pop_it): Iterate out of display property for string iteration as
12606 well.
12607 (iterate_out_of_display_property): Support iteration over strings.
12608 (handle_single_display_spec): Set up it->bidi_it for iteration
12609 over a display string, and call bidi_init_it.
12610 (handle_single_display_spec, next_overlay_string)
12611 (get_overlay_strings_1, push_display_prop): Set up the bidi
12612 iterator for displaying display or overlay strings.
12613 (forward_to_next_line_start): Don't use the shortcut if
12614 bidi-iterating.
12615 (back_to_previous_visible_line_start): If handle_display_prop
12616 pushed the iterator stack, restore the internal state of the bidi
12617 iterator by calling bidi_pop_it same number of times.
12618 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
12619 and we are bidi-iterating, don't decrement the iterator position;
12620 instead, set the first_elt flag in the bidi iterator, to produce
12621 the same effect.
12622 (reseat_1): Remove redundant setting of string_from_display_prop_p.
12623 (push_display_prop): xassert that we are iterating a buffer.
12624 (push_it, pop_it): Save and restore paragraph_embedding member.
12625 (handle_single_display_spec, next_overlay_string)
12626 (get_overlay_strings_1, reseat_1, reseat_to_string)
12627 (push_display_prop): Set up the `unibyte' member of bidi_it.string
12628 correctly. Don't assume unibyte strings are not bidi-reordered.
12629 (compute_display_string_pos)
12630 (compute_display_string_end): Fix handling the case of C string.
12631 (push_it, pop_it): Save and restore from_disp_prop_p.
12632 (handle_single_display_spec, push_display_prop): Set the
12633 from_disp_prop_p flag.
12634 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
12635 (pop_it): Call iterate_out_of_display_property only if we are
12636 popping after iteration over a string that came from a display
12637 property. Fix a typo in popping stretch info. Add an assertion
12638 for verifying that the iterator position is in sync with the bidi
12639 iterator.
12640 (handle_single_display_spec, get_overlay_strings_1)
12641 (push_display_prop): Fix initialization of paragraph direction for
12642 string when that of the parent object is not yet determined.
12643 (reseat_1): Call bidi_init_it to resync the bidi
12644 iterator with IT's position. (Bug#7616)
12645 (find_row_edges): If ROW->start.pos gives position
12646 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
12647 (handle_stop, back_to_previous_visible_line_start, reseat_1):
12648 Reset the from_disp_prop_p flag.
12649 (SAVE_IT, RESTORE_IT): New macros.
12650 (pos_visible_p, face_before_or_after_it_pos)
12651 (back_to_previous_visible_line_start)
12652 (move_it_in_display_line_to, move_it_in_display_line)
12653 (move_it_to, move_it_vertically_backward, move_it_by_lines)
12654 (try_scrolling, redisplay_window, display_line): Use them when
12655 saving a temporary copy of the iterator and restoring it back.
12656 (back_to_previous_visible_line_start, reseat_1)
12657 (init_iterator): Empty the bidi cache "stack".
12658 (move_it_in_display_line_to): If iterator ended up at
12659 EOL, but we never saw any buffer positions smaller than
12660 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
12661 motion in bidi-reordered lines.
12662 (move_it_in_display_line_to): Record prev_method and prev_pos
12663 immediately before the call to set_iterator_to_next. Fixes cursor
12664 motion in bidi-reordered lines with stretch glyphs and strings
12665 displayed in margins. (Bug#8133) (Bug#8867)
12666 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
12667 TO_CHARPOS.
640c8776
SM
12668 (pos_visible_p): Support positions in bidi-reordered lines.
12669 Save and restore bidi cache.
0bb23927
EZ
12670
12671 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
12672 (bidi_paragraph_info): Delete unused struct.
12673 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
12674 (bidi_cache_start): New variable.
12675 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
12676 to zero.
12677 (bidi_cache_fetch_state, bidi_cache_search)
12678 (bidi_cache_find_level_change, bidi_cache_iterator_state)
12679 (bidi_cache_find, bidi_peek_at_next_level)
12680 (bidi_level_of_next_char, bidi_find_other_level_edge)
12681 (bidi_move_to_visually_next): Compare cache index with
12682 bidi_cache_start rather than with zero.
12683 (bidi_fetch_char): Accept new argument STRING; all callers
12684 changed. Support iteration over a string. Support strings with
12685 display properties. Support unibyte strings. Fix the type of
12686 `len' according to what STRING_CHAR_AND_LENGTH expects.
12687 (bidi_paragraph_init, bidi_resolve_explicit_1)
12688 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
12689 (bidi_level_of_next_char, bidi_move_to_visually_next):
12690 Support iteration over a string.
0bb23927
EZ
12691 (bidi_set_sor_type, bidi_resolve_explicit_1)
12692 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
12693 can now be zero (for strings); special values 0 and -1 were
12694 changed to -1 and -2, respectively.
12695 (bidi_char_at_pos): New function.
12696 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
12697 Call it instead of FETCH_MULTIBYTE_CHAR.
12698 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
12699 initialized to valid values.
12700 (bidi_init_it): Don't initialize charpos and bytepos with invalid
12701 values.
12702 (bidi_level_of_next_char): Allow the sentinel "position" to pass
12703 the test for valid cached positions. Fix the logic for looking up
12704 the sentinel state in the cache. GCPRO the Lisp string we are
12705 iterating.
12706 (bidi_push_it, bidi_pop_it): New functions.
12707 (bidi_initialize): Initialize the bidi cache start stack pointer.
12708 (bidi_cache_ensure_space): New function, refactored from part of
12709 bidi_cache_iterator_state. Don't assume the required size is just
12710 one BIDI_CACHE_CHUNK away.
12711 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
12712 (bidi_count_bytes, bidi_char_at_pos): New functions.
12713 (bidi_cache_search): Don't assume bidi_cache_last_idx is
12714 always valid if bidi_cache_idx is valid.
12715 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
12716 is valid if it's going to be used.
12717 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
12718 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
12719 (bidi_cache_find_level_change, bidi_cache_ensure_space)
12720 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
12721 (bidi_find_other_level_edge, bidi_cache_start_stack):
12722 All variables related to cache indices are now EMACS_INT.
c965adc5 12723
0bb23927
EZ
12724 * dispextern.h (struct bidi_string_data): New structure.
12725 (struct bidi_it): New member `string'. Make flag members be 1-bit
12726 fields, and put them last in the struct.
640c8776
SM
12727 (compute_display_string_pos, compute_display_string_end):
12728 Update prototypes.
0bb23927
EZ
12729 (bidi_push_it, bidi_pop_it): Add prototypes.
12730 (struct iterator_stack_entry): New members bidi_p,
12731 paragraph_embedding, and from_disp_prop_p.
12732 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
12733 (bidi_shelve_cache, bidi_unshelve_cache):
12734 Declare prototypes.
0bb23927
EZ
12735
12736 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
12737 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
12738 and vector-like objects.
12739
12740 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
12741 cache around display iteration.
12742
12743 * window.c (Fwindow_end, window_scroll_pixel_based)
12744 (displayed_window_lines, Frecenter): Save and restore the bidi
12745 cache around display iteration.
12746
3bbd2265
LMI
127472011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
12748
12749 * editfns.c (Fdelete_region): Clarify the use of the named
12750 parameters (bug#6788).
12751
adc47434
MR
127522011-07-14 Martin Rudalics <rudalics@gmx.at>
12753
12754 * indent.c (Fvertical_motion): Set and restore w->pointm when
12755 saving and restoring the window's buffer (Bug#9006).
12756
837c31f8
LMI
127572011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
12758
12759 * editfns.c (Fstring_to_char): Clarify just what is returned
12760 (bug#6576). Text by Eli Zaretskii.
12761
ac389d0c
JB
127622011-07-13 Juanma Barranquero <lekktu@gmail.com>
12763
12764 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
12765
0be0ce47
EZ
127662011-07-13 Eli Zaretskii <eliz@gnu.org>
12767
12768 * buffer.c (mmap_find): Fix a typo.
12769
cd18e7e3
JB
127702011-07-13 Johan Bockgård <bojohan@gnu.org>
12771
12772 Fix execution of x selection hooks.
12773 * xselect.c (Qx_lost_selection_functions)
12774 (Qx_sent_selection_functions): New vars.
12775 (syms_of_xselect): DEFSYM them.
12776 (x_handle_selection_request): Pass Qx_sent_selection_functions
12777 rather than Vx_sent_selection_functions to Frun_hook_with_args.
12778 (x_handle_selection_clear,x_clear_frame_selections):
12779 Pass Qx_lost_selection_functions rather than
12780 Vx_lost_selection_functions to Frun_hook_with_args.
12781
47ea7f44
PE
127822011-07-13 Paul Eggert <eggert@cs.ucla.edu>
12783
ac389d0c 12784 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
12785 The old code sometimes used this field without initializing it.
12786
47ea7f44
PE
12787 * alloc.c (gc_sweep): Don't read past end of array.
12788 In theory, the old code could also have corrupted Emacs internals,
12789 though it'd be very unlikely.
12790
bc985c87
AS
127912011-07-12 Andreas Schwab <schwab@linux-m68k.org>
12792
12793 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 12794 argument. (Bug#4026)
bc985c87 12795
0cf34688
LMI
127962011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
12797
b3dadd76
LMI
12798 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
12799 key" (bug#4257).
12800
0cf34688
LMI
12801 * window.c (Fset_window_start): Doc fix (bug#4199).
12802 (Fset_window_hscroll): Ditto.
12803
270768cd
PE
128042011-07-12 Paul Eggert <eggert@cs.ucla.edu>
12805
077e3dda 12806 Fix minor new problems caught by GCC 4.6.1.
270768cd 12807 * term.c (init_tty): Remove unused local.
490011a6 12808 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 12809 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 12810 not used otherwise.
270768cd 12811
b1f58454
CY
128122011-07-12 Chong Yidong <cyd@stupidchicken.com>
12813
12814 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
12815
22b9578d
LMI
128162011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
12817
6e70ab07
LMI
12818 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
12819 are the mini-buffer and the echo area (bug#3320).
12820
22b9578d
LMI
12821 * term.c (init_tty): Remove support for supdup, c10 and perq
12822 terminals, which are no longer supported (bug#1482).
12823
8974cc9f
JB
128242011-07-10 Johan Bockgård <bojohan@gnu.org>
12825
12826 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
12827
a560d974
JD
128282011-07-10 Jan Djärv <jan.h.d@swipnet.se>
12829
12830 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
12831 for non-popups (Bug#3642).
12832
1dae0f0a
AS
128332011-07-10 Andreas Schwab <schwab@linux-m68k.org>
12834
268c2c36 12835 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 12836 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
12837 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
12838 * cm.c (losecursor): Likewise.
1dae0f0a
AS
12839 * data.c (fmod): Likewise.
12840 * dispnew.c (swap_glyphs_in_rows): Likewise.
12841 * emacs.c (memory_warning_signal): Likewise.
12842 * floatfns.c (float_error): Likewise.
12843 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
12844 (otf_open, font_otf_capability, generate_otf_features)
12845 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
12846 Likewise.
12847 * image.c (pbm_read_file): Likewise.
12848 * indent.c (string_display_width): Likewise.
12849 * intervals.c (check_for_interval, search_for_interval)
12850 (inc_interval_count, count_intervals, root_interval)
12851 (adjust_intervals_for_insertion, make_new_interval): Likewise.
12852 * lread.c (defalias): Likewise.
268c2c36 12853 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
12854 * regex.c (set_image_of_range_1, set_image_of_range)
12855 (regex_grow_registers): Likewise.
12856 * sysdep.c (strerror): Likewise.
12857 * termcap.c (valid_filename_p, tprint, main): Likewise.
12858 * tparam.c (main): Likewise.
12859 * unexhp9k800.c (run_time_remap, save_data_space)
12860 (update_file_ptrs, read_header, write_header, calculate_checksum)
12861 (copy_file, copy_rest, display_header): Likewise.
12862 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
12863 Likewise.
12864 * xdisp.c (check_it): Likewise.
12865 * xfaces.c (register_color, unregister_color, unregister_colors):
12866 Likewise.
12867 * xfns.c (print_fontset_result): Likewise.
12868 * xrdb.c (member, fatal, main): Likewise.
12869
99033785
PE
128702011-07-10 Paul Eggert <eggert@cs.ucla.edu>
12871
12872 Fix minor problems found by static checking (Bug#9031).
12873 * chartab.c (char_table_set_range, map_sub_char_table):
12874 Remove unused locals.
12875 (uniprop_table): Now static.
12876 * composite.c (_work_char): Remove unused static var.
12877
9cb2ac56
JB
128782011-07-09 Juanma Barranquero <lekktu@gmail.com>
12879
12880 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
12881
f25661f0
JD
128822011-07-09 Jan Djärv <jan.h.d@swipnet.se>
12883
12884 * gtkutil.c (qttip_cb): Remove code without function.
12885
8278c4fe
EZ
128862011-07-09 Eli Zaretskii <eliz@gnu.org>
12887
12888 * w32.c (pthread_sigmask): New stub.
12889
1692ae2d 128902011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 12891
8a6ebd58 12892 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
12893 sigprocmask is portable only for single-threaded applications, and
12894 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
12895 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
12896 (LIBES): Use it.
12897 * callproc.c (Fcall_process):
12898 * process.c (create_process):
12899 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
12900 Use pthread_sigmask, not sigprocmask.
123403e4 12901
1b854618
JD
129022011-07-08 Jan Djärv <jan.h.d@swipnet.se>
12903
12904 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
12905 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
12906 wrong (Bug#8591).
12907
3fe4b549
JD
129082011-07-08 Jan Djärv <jan.h.d@swipnet.se>
12909
0ce7e563
JD
12910 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
12911 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
12912 (xg_hide_tooltip): Fix comment.
12913
3fe4b549
JD
12914 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
12915 in registerServicesMenuSendTypes.
12916 (validRequestorForSendType): Don't check ns_return_types.
12917
12918 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
12919 ns_return_type.
12920
5df75e47
JR
129212011-07-08 Jason Rumney <jasonr@gnu.org>
12922
22610910
JR
12923 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
12924 SH_SHOW for hidden windows (Bug#5482).
12925
5df75e47
JR
12926 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
12927 frame struct members of non-existent frames (Bug#6284).
12928
699c10bd
JD
129292011-07-08 Jan Djärv <jan.h.d@swipnet.se>
12930
4393663b
JD
12931 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
12932 variable firstTime not needed on OSX >= 10.6.
12933 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
12934 >= 10.5. Use setKnobProportion, setDoubleValue.
12935
12936 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
12937 (MAC_OS_X_VERSION_10_5): Define if not defined.
12938 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
12939 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
12940 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
12941
12942 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 12943 cString and lossyCString on OSX >= 10.4.
4393663b 12944
58179cce 12945 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
12946 sizeToFit on OSX >= 10.2.
12947
12948 * nsimage.m (allocInitFromFile): Don't use deprecated method
12949 bestRepresentationForDevice on OSX >= 10.6.
12950
12951 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
12952 to avoid warning.
12953
12954 * emacs.c: Declare unexec_init_emacs_zone.
12955
a63e0781
JD
12956 * nsgui.h: Fix compiler warning about gnulib redefining verify.
12957
699c10bd
JD
12958 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
12959
12960 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
12961 on svcsMenu (Bug#8842).
12962
12963 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
12964 ns_return_types.
12965 (Fns_list_services): Just return Qnil on 10.6, code not working there.
12966
12967 * nsterm.m (QUTF8_STRING): Declare.
12968 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
12969 (validRequestorForSendType): Return type is (id).
12970 Change indexOfObjectIdenticalTo to indexOfObject.
12971 Check if we have local selection before returning self (Bug#8842).
12972 (writeSelectionToPasteboard): Put local selection into paste board
12973 if we have a local selection (Bug#8842).
12974 (syms_of_nsterm): DEFSYM QUTF8_STRING.
12975
12976 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
12977 (ns_get_local_selection): Declare.
12978
54e10184
LMI
129792011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
12980
9888ff71
LMI
12981 * keymap.c (describe_map_tree): Don't insert a double newline at
12982 the end of the buffer (bug#1169) and return whether we inserted
12983 something.
12984
54e10184
LMI
12985 * callint.c (Fcall_interactively): Change "reading args" to
12986 "providing args" to try to clarify what it does (bug#1010).
12987
15fa4783
KH
129882011-07-07 Kenichi Handa <handa@m17n.org>
12989
12990 * composite.c (composition_compute_stop_pos): Ignore a static
12991 composition starting before CHARPOS (Bug#8915).
12992
12993 * xdisp.c (handle_composition_prop): Likewise.
12994
a8815b00
EZ
129952011-07-07 Eli Zaretskii <eliz@gnu.org>
12996
12997 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
12998 (Bug#9015)
12999
ef7b981d 130002011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
13001
13002 * character.h (unicode_category_t): New enum type.
13003
13004 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
13005 (Qchar_code_property_table): New variable.
13006 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
13007 (UNIPROP_COMPRESSED_FORM_P): New macros.
13008 (char_table_ascii): Uncompress the compressed values.
13009 (sub_char_table_ref): New arg is_uniprop. Callers changed.
13010 Uncompress the compressed values.
ac389d0c 13011 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
13012 (char_table_ref_and_range): Uncompress the compressed values.
13013 (sub_char_table_set): New arg is_uniprop. Callers changed.
13014 Uncompress the compressed values.
13015 (sub_char_table_set_range): Args changed. Callers changed.
13016 (char_table_set_range): Adjuted for the above change.
13017 (map_sub_char_table): Delete args default_val and parent. Add arg
13018 top. Give decoded values to a Lisp function.
640c8776 13019 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
13020 values to a Lisp function. Gcpro more variables.
13021 (uniprop_table_uncompress)
13022 (uniprop_decode_value_run_length): New functions.
13023 (uniprop_decoder, uniprop_decoder_count): New variables.
13024 (uniprop_get_decoder, uniprop_encode_value_character)
13025 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
13026 New functions.
13027 (uniprop_encoder, uniprop_encoder_count): New variables.
13028 (uniprop_get_encoder, uniprop_table)
13029 (Funicode_property_table_internal, Fget_unicode_property_internal)
13030 (Fput_unicode_property_internal): New functions.
13031 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
13032 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 13033 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
13034 char-code-property-alist.
13035
640c8776 13036 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
13037 Vunicode_category_table.
13038
640c8776 13039 * font.c (font_range): Adjust for the change of
c805dec0
KH
13040 Vunicode_category_table.
13041
76b397fb
DN
130422011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
13043
13044 * m/iris4d.h: Remove file, move contents ...
13045 * s/irix6-5.h: ... here.
13046
22b4128e
PE
130472011-07-06 Paul Eggert <eggert@cs.ucla.edu>
13048
13049 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
13050 * alloc.c (mark_buffer):
13051 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
13052 (clone_per_buffer_values): Don't assume that
22b4128e
PE
13053 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
13054 This isn't true in general, and it's particularly not true
13055 if Emacs is configured with --with-wide-int.
13056 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
13057 New macros, used in the buffer.c change.
13058
869795d6
JD
130592011-07-05 Jan Djärv <jan.h.d@swipnet.se>
13060
13061 * xsettings.c: Use both GConf and GSettings if both are available.
13062 (store_config_changed_event): Add comment.
13063 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
13064 (store_tool_bar_style_changed): New functions.
5e617bc2 13065 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
13066 (struct xsettings): Move font inside HAVE_XFT.
13067 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 13068 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 13069 Move inside HAVE_XFT.
640c8776 13070 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
13071 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
13072 also.
13073 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 13074 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 13075 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
13076 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
13077 (parse_settings): Move check for font inside HAVE_XFT.
13078 (read_settings, apply_xft_settings): Add comment.
13079 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
13080 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
13081 call store_font_name_changed.
13082 (xft_settings_event): Add comment.
13083 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
13084 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
13085 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
13086 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
13087 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
13088 (xsettings_get_system_font, xsettings_get_system_normal_font):
13089 Add comment.
869795d6 13090
d8ed26bd
PE
130912011-07-05 Paul Eggert <eggert@cs.ucla.edu>
13092
13093 Random fixes. E.g., (random) never returned negative values.
13094 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
13095 subseconds part to the entropy, as that's a bit more random.
13096 Prefer signed to unsigned, since the signedness doesn't matter and
13097 in general we prefer signed. When given a limit, use a
13098 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
13099 latter isn't right if USE_2_TAGS_FOR_INTS.
13100 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
13101 not 0..VALMASK. Don't discard "excess" bits that random () returns.
13102
cabf1cac
SM
131032011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
13104
13105 * textprop.c (text_property_stickiness):
13106 Obey Vtext_property_default_nonsticky.
13107 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
13108 * w32fns.c (syms_of_w32fns):
13109 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
13110
6e9b2be9
PE
131112011-07-04 Paul Eggert <eggert@cs.ucla.edu>
13112
13113 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
13114 This is more efficient than Ffile_directory_p and avoids a minor race.
13115
90186c68
LMI
131162011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
13117
7c301272
LMI
13118 * buffer.c (Foverlay_put): Say what the return value is
13119 (bug#7835).
13120
c4f2d8d4
LMI
13121 * fileio.c (barf_or_query_if_file_exists): Check first if the file
13122 is a directory before asking whether to use the file name
13123 (bug#7564).
ad637907
LMI
13124 (barf_or_query_if_file_exists): Make the "File is a directory"
13125 error be more correct.
c4f2d8d4 13126
90186c68
LMI
13127 * fns.c (Frequire): Remove the mention of the .gz files, since
13128 that's installation-specific, but keep the mention of
13129 `get-load-suffixes'.
13130
da64016e
PE
131312011-07-04 Paul Eggert <eggert@cs.ucla.edu>
13132
13133 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
13134 Report string overflow if the output is too long.
13135
7d47b580
JB
131362011-07-04 Juanma Barranquero <lekktu@gmail.com>
13137
a555cb87
JB
13138 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
13139 (syms_of_gnutls): Remove duplicate DEFSYM for
13140 Qgnutls_bootprop_verify_hostname_error, an error for
13141 Qgnutls_bootprop_verify_error (which is no longer used).
13142
7d47b580
JB
13143 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
13144 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
13145 Also (re)move comments that are misplaced or no longer relevant.
13146
1e49bfab
LMI
131472011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
13148
13149 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
13150
1485f4c0
CY
131512011-07-03 Chong Yidong <cyd@stupidchicken.com>
13152
13153 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
13154 and background color parameters if they have been changed.
13155
a9ab721e
LMI
131562011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
13157
13158 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
13159
cf7cff57
PE
131602011-07-03 Paul Eggert <eggert@cs.ucla.edu>
13161
2e13213d
PE
13162 * xsettings.c (SYSTEM_FONT): Define only when used.
13163 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
13164
cf7cff57
PE
13165 * keymap.c (access_keymap_1): Now static.
13166
7a8e04f7
CY
131672011-07-02 Chong Yidong <cyd@stupidchicken.com>
13168
13169 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
13170 leave any prefix arg for the up event (Bug#1586).
13171
61352f62
LMI
131722011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
13173
69bb1ef7
LMI
13174 * lread.c (syms_of_lread): Mention single symbols defined by
13175 `defvar' or `defconst' (bug#7154).
13176
61352f62 13177 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 13178 (Frequire): Mention get-load-suffixes.
61352f62 13179
28545e04
MR
131802011-07-02 Martin Rudalics <rudalics@gmx.at>
13181
13182 * window.h (window): Remove clone_number slot.
13183 * window.c (Fwindow_clone_number, Fset_window_clone_number):
13184 Remove.
13185 (make_parent_window, make_window, saved_window)
13186 (Fset_window_configuration, save_window_save): Don't deal with
13187 clone numbers.
13188 * buffer.c (Qclone_number): Remove declaration.
13189 (sort_overlays, overlay_strings): Don't deal with clone numbers.
13190
3349e122
SM
131912011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
13192
13193 Add multiple inheritance to keymaps.
13194 * keymap.c (Fmake_composed_keymap): New function.
13195 (Fset_keymap_parent): Simplify.
13196 (fix_submap_inheritance): Remove.
13197 (access_keymap_1): New function extracted from access_keymap to handle
13198 embedded parents and handle lists of maps.
13199 (access_keymap): Use it.
13200 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
13201 (Fcopy_keymap): Handle embedded parents.
13202 (Fcommand_remapping, define_as_prefix): Simplify.
13203 (Fkey_binding): Simplify.
13204 (syms_of_keymap): Move minibuffer-local-completion-map,
13205 minibuffer-local-filename-completion-map,
13206 minibuffer-local-must-match-map, and
13207 minibuffer-local-filename-must-match-map to Elisp.
13208 (syms_of_keymap): Defsubr make-composed-keymap.
13209 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
13210 (parse_menu_item): Trivial simplification.
13211
3279eb87
GM
132122011-07-01 Glenn Morris <rgm@gnu.org>
13213
13214 * Makefile.in (SETTINGS_LIBS): Fix typo.
13215
39cb9e56 132162011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
13217
13218 * coding.c (Fencode_coding_string): Record the last coding system
13219 used, as the function doc string says (bug#8738).
13220
0949d2b6
JD
132212011-07-01 Jan Djärv <jan.h.d@swipnet.se>
13222
13223 * xsettings.c (store_monospaced_changed): Take new font as arg and
13224 check for change against current_mono_font.
13225 (EMACS_TYPE_SETTINGS): Remove this and related defines.
13226 (emacs_settings_constructor, emacs_settings_get_property)
13227 (emacs_settings_set_property, emacs_settings_class_init)
13228 (emacs_settings_init, gsettings_obj): Remove.
13229 (something_changedCB): New function for HAVE_GSETTINGS.
13230 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
13231 with value as argument.
13232 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
13233 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 13234 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
13235 "changed".
13236
13237 * xgselect.c: Add defined (HAVE_GSETTINGS).
13238 (xgselect_initialize): Ditto.
13239
13240 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
13241 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
13242 xg_select.
13243
bbc6b304
PE
132442011-07-01 Paul Eggert <eggert@cs.ucla.edu>
13245
13246 * eval.c (struct backtrace): Simplify and port the data structure.
13247 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
13248 signed bit field, as this assumption is not portable and it makes
13249 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
13250 "char debug_on_exit : 1" as this is not portable either; instead,
13251 use the portable "unsigned int debug_on_exit : 1". Remove unused
13252 member evalargs. Remove obsolete comments about cc bombing out.
13253
9851bfc5
JD
132542011-06-30 Jan Djärv <jan.h.d@swipnet.se>
13255
51bb811f 13256 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
13257 Let HAVE_GSETTINGS override HAVE_GCONF.
13258 (store_monospaced_changed): New function.
13259 (EMACS_SETTINGS): A new type derived from GObject to handle
13260 GSettings notifications.
13261 (emacs_settings_constructor, emacs_settings_get_property)
13262 (emacs_settings_set_property, emacs_settings_class_init):
13263 New functions.
13264 (gsettings_client, gsettings_obj): New variables.
13265 (GSETTINGS_SCHEMA): New define.
13266 (something_changedCB): Call store_monospaced_changed.
13267 (init_gsettings): New function.
13268 (xsettings_initialize): Call init_gsettings.
13269 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
13270 to NULL.
13271
640c8776 13272 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
13273 GCONF_CFLAGS/LIBS.
13274
5386012d
MR
132752011-06-29 Martin Rudalics <rudalics@gmx.at>
13276
13277 * window.c (resize_root_window, grow_mini_window)
13278 (shrink_mini_window): Rename Qresize_root_window to
13279 Qwindow_resize_root_window and Qresize_root_window_vertically to
13280 Qwindow_resize_root_window_vertically.
13281
f13e0b08
PE
132822011-06-28 Paul Eggert <eggert@cs.ucla.edu>
13283
13284 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
13285
94515237
JB
132862011-06-27 Juanma Barranquero <lekktu@gmail.com>
13287
13288 * makefile.w32-in: Redesign dependencies so they reflect more
13289 clearly which files are directly included by each source file,
13290 and not through other includes.
13291
e43b6e43
MR
132922011-06-27 Martin Rudalics <rudalics@gmx.at>
13293
13294 * buffer.c (Qclone_number): Declare static and DEFSYM it.
13295 (sort_overlays, overlay_strings): When an overlay's clone number
13296 matches the window's clone number process the overlay even if
13297 the overlay's window property doesn't match the current window.
13298
d68443dc
MR
13299 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
13300 (Fwindow_hchild): Rename to Fwindow_left_child.
13301 (Fwindow_next): Rename to Fwindow_next_sibling.
13302 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
13303 (resize_window_check): Rename to window_resize_check.
13304 (resize_window_apply): Rename to window_resize_apply.
13305 (Fresize_window_apply): Rename to Fwindow_resize_apply.
13306 (Fdelete_other_windows_internal, resize_frame_windows)
13307 (Fsplit_window_internal, Fdelete_window_internal)
13308 (grow_mini_window, shrink_mini_window)
13309 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 13310
c7e73be5
JD
133112011-06-26 Jan Djärv <jan.h.d@swipnet.se>
13312
13313 * emacsgtkfixed.h: State that this is only used with Gtk+3.
13314 (emacs_fixed_set_min_size): Remove.
13315 (emacs_fixed_new): Take frame as argument.
13316
13317 * emacsgtkfixed.c: State that this is only used with Gtk+3.
13318 (_EmacsFixedPrivate): Remove minwidth/height.
13319 Add struct frame *f.
13320 (emacs_fixed_init): Initialize priv->f.
13321 (get_parent_class, emacs_fixed_set_min_size): Remove.
13322 (emacs_fixed_new): Set priv->f to argument.
13323 (emacs_fixed_get_preferred_width)
13324 (emacs_fixed_get_preferred_height): Use min_width/height from
13325 frames size_hint to set minimum and natural (Bug#8919).
13326 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
13327 and use min_width/height from frames size_hint to set
13328 min_width/height (Bug#8919).
13329
13330 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
13331 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
13332 Fix indentation.
c7e73be5 13333
cf99dcf8
EZ
133342011-06-26 Eli Zaretskii <eliz@gnu.org>
13335
13336 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
13337 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
13338 called at ZV.
13339
029529ac
CY
133402011-06-26 Chong Yidong <cyd@stupidchicken.com>
13341
13342 * process.c (wait_reading_process_output): Bypass select if
13343 waiting for a cell while ignoring keyboard input, and input is
13344 pending. Suggested by Jan Djärv (Bug#8869).
13345
7a7ef429
PE
133462011-06-25 Paul Eggert <eggert@cs.ucla.edu>
13347
13348 Use gnulib's dup2 module instead of rolling our own.
13349 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
13350
11fdef7d 133512011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
13352
13353 * dispnew.c (scrolling_window): Before scrolling, turn off a
13354 mouse-highlight in the window being scrolled.
13355
cd3520a4
JB
133562011-06-24 Juanma Barranquero <lekktu@gmail.com>
13357
13358 Move DEFSYM to lisp.h and use everywhere.
13359
13360 * character.h (DEFSYM): Move declaration...
13361 * lisp.h (DEFSYM): ...here.
13362
13363 * gnutls.c:
13364 * minibuf.c:
13365 * w32menu.c:
13366 * w32proc.c:
13367 * w32select.c: Don't include character.h.
13368
13369 * alloc.c (syms_of_alloc):
13370 * buffer.c (syms_of_buffer):
13371 * bytecode.c (syms_of_bytecode):
13372 * callint.c (syms_of_callint):
13373 * casefiddle.c (syms_of_casefiddle):
13374 * casetab.c (init_casetab_once):
13375 * category.c (init_category_once, syms_of_category):
13376 * ccl.c (syms_of_ccl):
13377 * cmds.c (syms_of_cmds):
13378 * composite.c (syms_of_composite):
13379 * dbusbind.c (syms_of_dbusbind):
13380 * dired.c (syms_of_dired):
13381 * dispnew.c (syms_of_display):
13382 * doc.c (syms_of_doc):
13383 * editfns.c (syms_of_editfns):
13384 * emacs.c (syms_of_emacs):
13385 * eval.c (syms_of_eval):
13386 * fileio.c (syms_of_fileio):
13387 * fns.c (syms_of_fns):
13388 * frame.c (syms_of_frame):
13389 * fringe.c (syms_of_fringe):
13390 * insdel.c (syms_of_insdel):
13391 * keymap.c (syms_of_keymap):
13392 * lread.c (init_obarray, syms_of_lread):
13393 * macros.c (syms_of_macros):
13394 * msdos.c (syms_of_msdos):
13395 * print.c (syms_of_print):
13396 * process.c (syms_of_process):
13397 * search.c (syms_of_search):
13398 * sound.c (syms_of_sound):
13399 * syntax.c (init_syntax_once, syms_of_syntax):
13400 * terminal.c (syms_of_terminal):
13401 * textprop.c (syms_of_textprop):
13402 * undo.c (syms_of_undo):
13403 * w32.c (globals_of_w32):
13404 * window.c (syms_of_window):
13405 * xdisp.c (syms_of_xdisp):
13406 * xfaces.c (syms_of_xfaces):
13407 * xfns.c (syms_of_xfns):
13408 * xmenu.c (syms_of_xmenu):
13409 * xsettings.c (syms_of_xsettings):
13410 * xterm.c (syms_of_xterm): Use DEFSYM.
13411
4228cf16
TZ
134122011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
13413
cd3520a4 13414 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 13415
7fcccf1e
PE
134162011-06-23 Paul Eggert <eggert@cs.ucla.edu>
13417
7efb4e0e
PE
13418 Integer and buffer overflow fixes (Bug#8873).
13419
ff5844ad
PE
13420 * print.c (printchar, strout): Check for string overflow.
13421 (PRINTPREPARE, printchar, strout):
13422 Don't set size unless allocation succeeds.
13423
90532f02
PE
13424 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
13425 for sizes. Check for string overflow more accurately.
13426 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
13427
6d84508d
PE
13428 * macros.c: Integer and buffer overflow fixes.
13429 * keyboard.h (struct keyboard.kbd_macro_bufsize):
13430 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
13431 Use ptrdiff_t, not int, for sizes.
13432 Don't increment bufsize until after realloc succeeds.
13433 Check for size-calculation overflow.
13434 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
13435
437b2cb4
PE
13436 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
13437
8b9ac8b4
PE
13438 * lread.c: Integer overflow fixes.
13439 (read_integer): Radix is now EMACS_INT, not int,
13440 to improve quality of diagnostics for out-of-range radices.
13441 Calculate buffer size correctly for out-of-range radices.
13442 (read1): Check for integer overflow in radices, and in
13443 read-circle numbers.
82cb60d3
PE
13444 (read_escape): Avoid int overflow.
13445 (Fload, openp, read_buffer_size, read1)
13446 (substitute_object_recurse, read_vector, read_list, map_obarray):
13447 Use ptrdiff_t, not int, for sizes.
13448 (read1): Use EMACS_INT, not int, for sizes.
20270765 13449 Check for size overflow.
8b9ac8b4 13450
7fcccf1e
PE
13451 * image.c (cache_image): Check for size arithmetic overflow.
13452
bfbbd7e7
PE
13453 * lread.c: Integer overflow issues.
13454 (saved_doc_string_size, saved_doc_string_length)
13455 (prev_saved_doc_string_size, prev_saved_doc_string_length):
13456 Now ptrdiff_t, not int.
13457 (read1): Don't assume doc string length fits in int. Check for
13458 out-of-range doc string lengths.
13459 (read_list): Don't assume file position fits in int.
39019e54 13460 (read_escape): Check for hex character overflow.
bfbbd7e7 13461
4e323265
LL
134622011-06-22 Leo Liu <sdl.web@gmail.com>
13463
13464 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
13465 Move to minibuffer.el.
13466
85fece3e
PE
134672011-06-22 Paul Eggert <eggert@cs.ucla.edu>
13468
20b84ce9 13469 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
13470 The following patches are for when GLYPH_DEBUG && !XASSERT.
13471 * dispextern.h (trace_redisplay_p, dump_glyph_string):
13472 * dispnew.c (flush_stdout):
13473 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
13474 Mark as externally visible.
13475 * dispnew.c (check_window_matrix_pointers): Now static.
13476 * dispnew.c (window_to_frame_vpos):
13477 * xfns.c (unwind_create_frame):
13478 * xterm.c (x_check_font): Remove unused local.
13479 * scroll.c (CHECK_BOUNDS):
13480 * xfaces.c (cache_fache): Rename local to avoid shadowing.
13481 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
13482 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
13483 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
13484 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
13485 Now static.
13486 (debug_method_add): Use va_list and vsprintf rather than relying
13487 on undefined behavior with wrong number of arguments.
13488 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
13489 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
13490 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
13491 since we're not interested in debugging glyphs with old libraries.
13492 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
13493 GCC 4.6.0's static checking.
13494
0766b489
PE
134952011-06-22 Paul Eggert <eggert@cs.ucla.edu>
13496
31fd4b32
PE
13497 Integer overflow and signedness fixes (Bug#8873).
13498 A few related buffer overrun fixes, too.
13499
b79e8648
PE
13500 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
13501
0766b489
PE
13502 * dispextern.h (struct face.stipple):
13503 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
13504 (x_bitmap_mask, x_allocate_bitmap_record)
13505 (x_create_bitmap_from_data, x_create_bitmap_from_file)
13506 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
13507 (x_create_bitmap_from_xpm_data):
13508 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
13509 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
13510 (.bitmaps_last):
13511 * xfaces.c (load_pixmap):
13512 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
13513 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
13514 (.bitmaps_last, struct x_output.icon_bitmap):
13515 Use ptrdiff_t, not int, for bitmap indexes.
13516 (x_allocate_bitmap_record): Check for size overflow.
13517 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
13518
b081724f
PE
13519 Use ptrdiff_t, not int, for overlay counts.
13520 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
13521 * editfns.c (overlays_around, get_pos_property):
13522 * textprop.c (get_char_property_and_overlay):
13523 * xdisp.c (next_overlay_change, note_mouse_highlight):
13524 * xfaces.c (face_at_buffer_position):
21514da7
PE
13525 * buffer.c (OVERLAY_COUNT_MAX): New macro.
13526 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
13527 (Fnext_overlay_change, Fprevious_overlay_change)
13528 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 13529 Use ptrdiff_t, not int, for sizes.
21514da7 13530 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 13531
3de73e5e
PE
13532 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
13533
2606c57b
PE
13534 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
13535 (x_session_initialize): Do not assume string length fits in int.
13536
aaafe47a
PE
13537 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
13538 This is unlikely, but can occur if DPI is outlandish.
13539
2674ddc8 13540 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
13541 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
13542
28154962
PE
13543 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
13544 * xrdb.c (magic_file_p, search_magic_path):
13545 Omit last arg SUFFIX; it was always 0. All callers changed.
13546 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
13547
7de51af5
PE
13548 * xfont.c (xfont_match): Avoid need for strlen.
13549
25ed6cc3
PE
13550 * xfns.c: Don't assume strlen fits in int.
13551 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
13552
4eab31dd
PE
13553 * xdisp.c (message_log_check_duplicate): Return intmax_t,
13554 not unsigned long, as we prefer signed integers. All callers changed.
13555 Detect integer overflow in repeat count.
13556 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 13557 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 13558
171e2a58
PE
13559 * termcap.c: Don't assume sizes fit in int and never overflow.
13560 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
13561 (gobble_line): Check for size-calculation overflow.
13562
ad39faca 13563 * minibuf.c (Fread_buffer):
6e5bb2dc 13564 * lread.c (intern, intern_c_string):
74ca2eb3
PE
13565 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
13566 Don't assume string length fits in int.
13567
52c61c22 13568 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
13569 * gtkutil.c (style_changed_cb): Avoid need for strlen.
13570
b5b8c9e5
PE
13571 * font.c: Don't assume string length fits in int.
13572 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
13573 Use ptrdiff_t, not int.
ccd6111c
PE
13574 (font_intern_prop): Don't assume string length fits in int.
13575 Don't assume integer property fits in fixnum.
13576 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 13577
882f0d81 13578 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 13579 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
13580 Reformulate so as not to need the command string.
13581 Invoke gzip -cd rather than gunzip, as it's more portable.
13582 (lock_info_type, lock_file_1, lock_file):
13583 Don't assume pid_t and time_t fit in unsigned long.
13584 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
13585 (current_lock_owner): Prefer signed type for sizes.
13586 Use memcpy, not strncpy, where memcpy is what is really wanted.
13587 Don't assume (via atoi) that time_t and pid_t fit in int.
13588 Check for time_t and/or pid_t out of range, e.g., via a network share.
13589 Don't alloca where an auto var works fine.
13590
93f4cf88
PE
13591 * fileio.c: Fix some integer overflow issues.
13592 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
13593 Don't assume string length fits in int.
13594 (directory_file_name): Don't assume string length fits in long.
13595 (make_temp_name): Don't assume pid fits in int, or that its print
13596 length is less than 20.
13597
f3e92b69
PE
13598 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
13599
1bfdaf10
PE
13600 * coding.c (make_subsidiaries): Don't assume string length fits in int.
13601
35016e9a
PE
13602 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
13603
3d1e65a1
PE
13604 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
13605 We prefer signed integers, even for size calculations.
13606
0b963a93
PE
13607 * emacs.c: Don't assume string length fits in 'int'.
13608 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
13609 (main): Don't invoke strlen when not needed.
13610
573f4b54
PE
13611 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
13612 (XD_DEBUG_MESSAGE): Don't waste a byte.
13613
989f33ba
PE
13614 * callproc.c (getenv_internal_1, getenv_internal)
13615 (Fgetenv_internal):
965d34eb
PE
13616 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
13617
e4d29b33
PE
13618 * lread.c (invalid_syntax): Omit length argument.
13619 All uses changed. This doesn't fix a bug, but it simplifies the
13620 code away from its former Hollerith-constant appearance, and it's
13621 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 13622 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 13623
eb49b136
PE
13624 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
13625 This didn't break anything, but it didn't help either.
13626 It's confusing to put a bogus integer in a place where the actual
13627 value does not matter.
9f62aeb1 13628 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 13629 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 13630
15375a22
PE
13631 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
13632 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
13633 implementation.
b61cc01c
PE
13634 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
13635 We prefer signed types, and the value cannot exceed the EMACS_INT
13636 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
13637 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
13638 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
13639 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 13640
53b2623d
PE
13641 * indent.c (sane_tab_width): New function.
13642 (current_column, scan_for_column, Findent_to, position_indentation)
13643 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 13644 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 13645
51cab52b 13646 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 13647
f2ed8a70
PE
13648 * lisp.h (lint_assume): New macro.
13649 * composite.c (composition_gstring_put_cache):
13650 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
13651
abe80cc6
PE
13652 * editfns.c, insdel.c:
13653 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 13654
b02c740e
PE
13655 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
13656
ebc96716
PE
13657 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
13658
b4e50fa0 13659 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 13660 Use much-faster test for byte-length change.
311d5d7c 13661 Don't assume string byte-length fits in 'int'.
a4cf38e4 13662 Check that character arg fits in 'int'.
85461888 13663 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 13664
c0c1ee9f
PE
13665 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
13666
a498d7f4
PE
13667 * fns.c (concat): Catch string overflow earlier.
13668 Do not rely on integer wraparound.
13669
51cab52b
PE
13670 * dispextern.h (struct it.overlay_strings_charpos)
13671 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
13672 * xdisp.c (forward_to_next_line_start)
13673 (back_to_previous_visible_line_start)
13674 (reseat_at_next_visible_line_start, next_element_from_buffer):
13675 Don't arbitrarily truncate the value of 'selective' to int.
13676
76031fad
PE
13677 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
13678
5eb55db9
PE
13679 * composite.c: Don't truncate sizes to 'int'.
13680 (composition_gstring_p, composition_reseat_it)
13681 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
13682 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
13683 not EMACS_UINT, for indexes.
5eb55db9 13684
0703a717
PE
13685 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
13686
d6202519
PE
13687 * buffer.c: Include <verify.h>.
13688 (struct sortvec.priority, struct sortstr.priority):
8961a454 13689 Now EMACS_INT, not int.
c20998a7 13690 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
13691 (struct sortstr.size, record_overlay_string)
13692 (struct sortstrlist.size, struct sortlist.used):
13693 Don't truncate size to int.
13694 (record_overlay_string): Check for size-calculation overflow.
d6202519 13695 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 13696
d5a19415
JM
136972011-06-22 Jim Meyering <meyering@redhat.com>
13698
029529ac 13699 Don't leak an XBM-image-sized buffer
d5a19415
JM
13700 * image.c (xbm_load): Free the image buffer after using it.
13701
a9041e6c
PE
137022011-06-21 Paul Eggert <eggert@cs.ucla.edu>
13703
13704 Port to Sun C.
13705 * composite.c (find_automatic_composition): Omit needless 'return 0;'
13706 that Sun C diagnosed.
13707 * fns.c (secure_hash): Fix pointer signedness issue.
13708 * intervals.c (static_offset_intervals): New function.
13709 (offset_intervals): Use it.
13710
7f3f739f
LL
137112011-06-21 Leo Liu <sdl.web@gmail.com>
13712
13713 * deps.mk (fns.o):
13714 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
13715 sha512.h.
13716
13717 * fns.c (secure_hash): Rename from crypto_hash_function and change
13718 the first arg to accept symbols.
5b66d427 13719 (Fsecure_hash): New primitive.
7f3f739f
LL
13720 (syms_of_fns): New symbols.
13721
76147d94
DD
137222011-06-20 Deniz Dogan <deniz@dogan.se>
13723
13724 * process.c (Fset_process_buffer): Clarify return value in
13725 docstring.
13726
7d7d0045
CY
137272011-06-18 Chong Yidong <cyd@stupidchicken.com>
13728
13729 * dispnew.c (add_window_display_history): Use BVAR.
13730
13731 * xdisp.c (debug_method_add): Use BVAR.
13732 (check_window_end, dump_glyph_matrix, dump_glyph)
13733 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
13734
13735 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
13736 Likewise.
13737
13738 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
13739 check till after the cache is created in init_frame_faces.
13740
ff2bc410
SM
137412011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
13742
13743 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
13744
28177add
PE
137452011-06-16 Paul Eggert <eggert@cs.ucla.edu>
13746
dd3482fe
PE
13747 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
13748 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
13749 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
13750
393d71f3 13751 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
13752 * fileio.c (Finsert_file_contents):
13753 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
13754 Remove the old (too-loose) buffer overflow checks.
13755 They weren't needed, since make_gap checks for buffer overflow.
13756 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
13757 The old code merely checked for Emacs fixnum overflow, and relied
13758 on undefined (wraparound) behavior. The new code avoids undefined
13759 behavior, and also checks for ptrdiff_t and/or size_t overflow.
13760
2e6813b0 13761 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
13762 Tune. Don't use wider integers than needed. Don't use alloca.
13763 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 13764
599a9e4f
PE
13765 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
13766
99561444
PE
13767 * insdel.c, lisp.h (buffer_overflow): New function.
13768 (insert_from_buffer_1, replace_range, replace_range_2):
13769 * insdel.c (make_gap_larger):
13770 * editfns.c (Finsert_char):
13771 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
13772
28177add
PE
13773 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
13774
e69dafad
PE
137752011-06-15 Paul Eggert <eggert@cs.ucla.edu>
13776
4baa020d 13777 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 13778
b1c46f02
PE
13779 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
13780 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
13781
e69dafad
PE
13782 * fileio.c: Don't assume EMACS_INT fits in off_t.
13783 (emacs_lseek): New static function.
13784 (Finsert_file_contents, Fwrite_region): Use it.
13785 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
13786
566684ea
PE
13787 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
13788
e6966cd6
PE
13789 * fns.c: Don't overflow int when computing a list length.
13790 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
13791 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
13792 truncation on 64-bit hosts. Check for QUIT every
13793 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
13794 faster and is responsive enough.
13795 (Flength): Report an error instead of overflowing an integer.
13796 (Fsafe_length): Return a float if the value is not representable
13797 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 13798 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 13799 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 13800
dd0b0efb
PE
13801 * alloc.c: Check that resized vectors' lengths fit in fixnums.
13802 (header_size, word_size): New constants.
13803 (allocate_vectorlike): Don't check size overflow here.
13804 (allocate_vector): Check it here instead, since this is the only
13805 caller of allocate_vectorlike that could cause overflow.
13806 Check that the new vector's length is representable as a fixnum.
13807
86fe5cfe
PE
13808 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
13809 The previous code was bogus. For example, next_almost_prime (32)
13810 returned 39, which is undesirable as it is a multiple of 3; and
13811 next_almost_prime (24) returned 25, which is a multiple of 5 so
13812 why was the code bothering to check for multiples of 7?
13813
80e88859
PE
13814 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
13815
4a2f0ad6
PE
13816 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
13817
f66c7cf8
PE
13818 Variadic C functions now count arguments with ptrdiff_t.
13819 This partly undoes my 2011-03-30 change, which replaced int with size_t.
13820 Back then I didn't know that the Emacs coding style prefers signed int.
13821 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
13822 were being counted with int, which may truncate counts on 64-bit
13823 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
13824 * lisp.h (struct Lisp_Subr.function.aMANY)
13825 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
13826 Arg counts are now ptrdiff_t, not size_t.
13827 All variadic functions and their callers changed accordingly.
13828 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
13829 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
13830 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
13831 * callint.c (Fcall_interactively): Check arg count for overflow,
13832 to avoid potential buffer overrun. Use signed char, not 'int',
13833 for 'varies' array, so that we needn't bother to check its size
13834 calculation for overflow.
13835 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
13836 * eval.c (apply_lambda):
13837 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
13838 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
13839 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
13840
a1759b76
PE
13841 * callint.c (Fcall_interactively): Don't use index var as event count.
13842
d96be9fc
PE
13843 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
13844 * mem-limits.h (SIZE): Remove; no longer used.
13845
a690a978 13846 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 13847
578c21e6
PE
13848 Remove unnecessary casts.
13849 * xterm.c (x_term_init):
13850 * xfns.c (x_set_border_pixel):
13851 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
13852 These aren't needed now that we assume ANSI C.
13853
96f53c6c
PE
13854 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
13855 It's more likely to cause problems (due to unsigned overflow)
13856 than to cure them.
13857
83c77d31
PE
13858 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
13859
ee2079f1
PE
13860 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
13861
6da65536
PE
13862 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
13863
7147c4a4
PE
13864 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
13865
193e32d9
PE
13866 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
13867
e5533da6
PE
13868 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
13869
9910e595
PE
13870 GLYPH_CODE_FACE returns EMACS_INT, not int.
13871 * dispextern.h (merge_faces):
13872 * xfaces.c (merge_faces):
01103c44
PE
13873 * xdisp.c (get_next_display_element, next_element_from_display_vector):
13874 Don't assume EMACS_INT fits in int.
9910e595 13875
2638320e
PE
13876 * character.h (CHAR_VALID_P): Remove unused parameter.
13877 * fontset.c, lisp.h, xdisp.c: All uses changed.
13878
045eb8d9
PE
13879 * editfns.c (Ftranslate_region_internal): Omit redundant test.
13880
c1f134b5
PE
13881 * fns.c (concat): Minor tuning based on overflow analysis.
13882 This doesn't fix any bugs. Use int to hold character, instead
13883 of constantly refetching from Emacs object. Use XFASTINT, not
13884 XINT, for value known to be a character. Don't bother comparing
13885 a single byte to 0400, as it's always less.
13886
395fcb93 13887 * floatfns.c (Fexpt):
327eeec8
PE
13888 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
13889
abbd3d23
PE
13890 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
13891 for characters.
13892
684a03ef
PE
13893 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
13894
0fed43f3
PE
13895 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
13896 Without this fix, on a 64-bit host (aset S 0 4294967386) would
13897 incorrectly succeed when S was a string, because 4294967386 was
13898 truncated before it was used.
13899
8fd02eb7
PE
13900 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
13901 Otherwise, an out-of-range integer could cause undefined behavior
13902 on a 64-bit host.
13903
f8c86b69
PE
13904 * composite.c: Use int, not EMACS_INT, for characters.
13905 (fill_gstring_body, composition_compute_stop_pos): Use int, not
13906 EMACS_INT, for values that are known to be in character range.
13907 This doesn't fix any bugs but is the usual style inside Emacs and
13908 may generate better code on 32-bit machines.
13909
34206dd2
PE
13910 Make sure a 64-bit char is never passed to ENCODE_CHAR.
13911 This is for reasons similar to the recent CHAR_STRING fix.
13912 * charset.c (Fencode_char): Check that character arg is actually
13913 a character. Pass an int to ENCODE_CHAR.
13914 * charset.h (ENCODE_CHAR): Verify that the character argument is no
13915 wider than 'int', as a compile-time check to prevent future regressions
13916 in this area.
13917
c5958d4c 13918 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
13919
13920 Make sure a 64-bit char is never passed to CHAR_STRING.
13921 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
13922 by silently ignoring the top 32 bits, allowing some values
13923 that were far too large to be valid characters.
13924 * character.h: Include <verify.h>.
13925 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
13926 arguments are no wider than unsigned, as a compile-time check
13927 to prevent future regressions in this area.
13928 * data.c (Faset):
01103c44 13929 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
13930 (Fsubst_char_in_region):
13931 * fns.c (concat):
13932 * xdisp.c (decode_mode_spec_coding):
13933 Adjust to CHAR_STRING's new requirement.
13934 * editfns.c (Finsert_char, Fsubst_char_in_region):
13935 * fns.c (concat): Check that character args are actually
13936 characters. Without this test, these functions did the wrong
13937 thing with wildly out-of-range values on 64-bit hosts.
13938
d37ca623
PE
13939 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
13940 These casts should not be needed on 32-bit hosts, either.
13941 * keyboard.c (read_char):
13942 * lread.c (Fload): Remove casts to unsigned.
13943
ea204efb
PE
13944 * lisp.h (UNSIGNED_CMP): New macro.
13945 This fixes comparison bugs on 64-bit hosts.
13946 (ASCII_CHAR_P): Use it.
13947 * casefiddle.c (casify_object):
01103c44 13948 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
13949 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
13950 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
13951 * dispextern.h (FACE_FROM_ID):
13952 * keyboard.c (read_char): Use UNSIGNED_CMP.
13953
41cb286c
PE
13954 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
13955 not to EMACS_INT, to avoid GCC warning.
13956
4a1b9832
PE
13957 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
13958
55daad71
PE
13959 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
13960 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
13961 isn't needed on 32-bit machines.
8f95c75c 13962
01103c44
PE
13963 * buffer.c (Fgenerate_new_buffer_name):
13964 Use EMACS_INT for count, not int.
0ceccced 13965 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
13966
13967 * data.c (Qcompiled_function): Now static.
13968
c6f072e7
PE
13969 * window.c (window_body_lines): Now static.
13970
20ce5912
PE
13971 * image.c (gif_load): Rename local to avoid shadowing.
13972
9c4c5f81
PE
13973 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
13974 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
13975 * alloc.c (make_save_value): Integer argument is now of type
13976 ptrdiff_t, not int.
13977 (mark_object): Use ptrdiff_t, not int.
13978 * lisp.h (pD): New macro.
13979 * print.c (print_object): Use it.
13980
c0c5c8ae
PE
13981 * alloc.c: Use EMACS_INT, not int, to count objects.
13982 (total_conses, total_markers, total_symbols, total_vector_size)
13983 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
13984 (total_free_floats, total_floats, total_free_intervals)
13985 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
13986 Now EMACS_INT, not int. All uses changed.
13987 (Fgarbage_collect): Compute overall total using a double, so that
13988 integer overflow is less likely to be a problem. Check for overflow
13989 when converting back to an integer.
5a25e253
PE
13990 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
13991 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
13992 These were 'int' variables that could overflow on 64-bit hosts;
13993 they were never used, so remove them instead of repairing them.
211a0b2a 13994 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
13995 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
13996 Previously, this ceilinged at INT_MAX, but that doesn't work on
13997 64-bit machines.
e46bb31a 13998 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 13999
c78baabf 14000 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 14001 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
14002 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
14003 when a (possibly-narrower) signed value would do just as well.
14004 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 14005
c9d624c6
PE
14006 * alloc.c: Catch some string size overflows that we were missing.
14007 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
14008 for convenience in STRING_BYTES_MAX.
14009 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
14010 The definition here is exact; the one in lisp.h was approximate.
14011 (allocate_string_data): Check for string overflow. This catches
14012 some instances we weren't catching before. Also, it catches
14013 size_t overflow on (unusual) hosts where SIZE_MAX <= min
14014 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
14015 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 14016
c9d624c6
PE
14017 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
14018 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 14019 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 14020
353032ce
PE
14021 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
14022
2bccce07
PE
14023 * alloc.c (Fmake_string): Check for out-of-range init.
14024
0ac30604
SM
140252011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
14026
14027 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
14028
c195f2de
JD
140292011-06-14 Jan Djärv <jan.h.d@swipnet.se>
14030
14031 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
14032 xg_get_default_scrollbar_width.
14033
14034 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
14035 (int_gtk_range_get_value): Move to the scroll bar part of the file.
14036 (style_changed_cb): Call update_theme_scrollbar_width and call
14037 x_set_scroll_bar_default_width and xg_frame_set_char_size for
14038 all frames (Bug#8505).
14039 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
14040 Call gtk_window_set_resizable if HAVE_GTK3.
14041 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
14042 and height if HAVE_GTK3 (Bug#8505).
14043 (scroll_bar_width_for_theme): New variable.
14044 (update_theme_scrollbar_width): New function.
14045 (xg_get_default_scrollbar_width): Move code to
14046 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
14047 (xg_initialize): Call update_theme_scrollbar_width.
14048
14049 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
14050
14051 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
14052
e10ac9f1
MR
140532011-06-12 Martin Rudalics <rudalics@gmx.at>
14054
14055 * frame.c (make_frame): Call other_buffer_safely instead of
14056 other_buffer.
14057
14058 * window.c (temp_output_buffer_show): Call display_buffer with
14059 second argument Vtemp_buffer_show_specifiers and reset latter
14060 immediately after the call.
14061 (Vtemp_buffer_show_specifiers): New variable.
14062 (auto_window_vscroll_p, next_screen_context_lines)
14063 (Vscroll_preserve_screen_position): Remove leading asterisks from
14064 doc-strings.
14065
2d3c217e 140662011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 14067
7b7f97e8 14068 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
14069 * buffer.c (Qclone_number): Remove for now, as it's unused.
14070 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
14071 (record_buffer): Remove unused local.
14072 * frame.c (other_visible_frames, frame_buffer_list): Now static.
14073 (set_frame_buffer_list): Remove; unused.
14074 * frame.h (other_visible_frames): Remove decl.
14075 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
14076 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
14077 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
14078 if HAVE_GPM.
14079 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
14080 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
14081 Define only if HAVE_GPM.
14082 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
14083 (update_hints_inhibit): Remove; never set. All uses removed.
14084 * widgetprv.h (emacsFrameClassRec): Remove decl.
14085 * window.c (delete_deletable_window): Now returns void, since it
14086 wasn't returning anything.
14087 (compare_window_configurations): Remove unused locals.
14088 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
14089 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
14090 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
14091 the same widths as pointers. This follows up on the 2011-05-06 patch.
14092 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
14093 * xterm.h: Likewise.
14094 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
14095
1384b89e
JB
140962011-06-12 Juanma Barranquero <lekktu@gmail.com>
14097
14098 * makefile.w32-in: Update dependencies.
14099 (LISP_H): Add lib/intprops.h.
14100
1100a63c
CY
141012011-06-11 Chong Yidong <cyd@stupidchicken.com>
14102
14103 * image.c (gif_load): Add animation frame delay to the metadata.
14104 (syms_of_image): Use DEFSYM. New symbol `delay'.
14105
6198ccd0
MR
141062011-06-11 Martin Rudalics <rudalics@gmx.at>
14107
14108 * window.c (delete_deletable_window): Re-add.
14109 (Fset_window_configuration): Rewrite to handle dead buffers and
14110 consequently deletable windows.
14111 (window_tree, Fwindow_tree): Remove. Supply functionality in
14112 window.el.
14113 (compare_window_configurations): Simplify code.
14114
b6e3633c
AS
141152011-06-11 Andreas Schwab <schwab@linux-m68k.org>
14116
1ab0dee5
AS
14117 * image.c (imagemagick_load_image): Fix type mismatch.
14118 (Fimagemagick_types): Likewise.
14119
b6e3633c
AS
14120 * window.h (replace_buffer_in_windows): Declare.
14121
9397e56f
MR
141222011-06-11 Martin Rudalics <rudalics@gmx.at>
14123
14124 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
14125 Qclone_number. Remove external declaration of Qdelete_window.
14126 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
14127 code.
640c8776
SM
14128 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
14129 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
14130 (Fother_buffer): Rewrite doc-string. Major rewrite for new
14131 buffer list implementation.
14132 (other_buffer_safely): New function.
14133 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
14134 calls to replace_buffer_in_windows and
14135 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
14136 if allowed.
14137 (record_buffer): Inhibit quitting and rewrite using quittable
14138 functions. Run Qbuffer_list_update_hook if allowed.
14139 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
14140 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
14141 Move switch-to-buffer to window.el.
9397e56f
MR
14142 (bury-buffer): Move to window.el.
14143 (Vbuffer_list_update_hook): New variable.
14144
14145 * lisp.h (other_buffer_safely): Add prototype in buffer.c
14146 section.
14147
14148 * window.h (resize_frame_windows): Move up in code.
14149 (Fwindow_frame): Remove EXFUN.
14150 (replace_buffer_in_all_windows): Remove prototype.
14151 (replace_buffer_in_windows_safely): Add prototype.
14152
14153 * window.c: Declare Qdelete_window static again. Move down
14154 declaration of select_count.
14155 (Fnext_window, Fprevious_window): Rewrite doc-strings.
14156 (Fother_window): Move to window.el.
14157 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
14158 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
14159 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
14160 window.el.
14161 (replace_buffer_in_windows): Implement by calling
14162 Qreplace_buffer_in_windows.
14163 (replace_buffer_in_all_windows): Remove with some functionality
14164 moved into replace_buffer_in_windows_safely.
14165 (replace_buffer_in_windows_safely): New function.
14166 (select_window_norecord, select_frame_norecord): Move in front
14167 of run_window_configuration_change_hook. Remove now obsolete
14168 declarations.
640c8776
SM
14169 (Fset_window_buffer): Rewrite doc-string.
14170 Call Qrecord_window_buffer.
9397e56f
MR
14171 (keys_of_window): Move binding for other-window to window.el.
14172
b50691aa
CY
141732011-06-11 Chong Yidong <cyd@stupidchicken.com>
14174
14175 * dispextern.h (struct image): Replace data member, whose int_val
14176 and ptr_val fields were not used by anything, with a single
14177 lisp_val object.
14178
14179 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
14180 (gif_clear_image, gif_load, imagemagick_load_image)
14181 (gs_clear_image, gs_load): Callers changed.
14182
3f754b86
PE
141832011-06-10 Paul Eggert <eggert@cs.ucla.edu>
14184
cca69397
PE
14185 * buffer.h: Include <time.h>, for time_t.
14186 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
14187
109e28d0
PE
14188 Fix minor problems found by static checking.
14189
60737f02
PE
14190 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
14191
4b66faf3
PE
14192 Make identifiers static if they are not used in other modules.
14193 * data.c (Qcompiled_function, Qframe, Qvector):
14194 * image.c (QimageMagick, Qsvg):
14195 * minibuf.c (Qmetadata):
14196 * window.c (resize_window_check, resize_root_window): Now static.
14197 * window.h (resize_window_check, resize_root_window): Remove decls.
14198
109e28d0
PE
14199 * window.c (window_deletion_count, delete_deletable_window):
14200 Remove; unused.
46a4ce9e
PE
14201 (window_body_lines): Now static.
14202 (Fdelete_other_windows_internal): Mark vars as initialized.
14203 Make sure 'resize_failed' is initialized.
14204 (run_window_configuration_change_hook): Rename local to avoid shadowing.
14205 (resize_window_apply): Remove unused local.
14206 * window.h (delete_deletable_window): Remove decl.
14207
109e28d0 14208 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
14209 (imagemagick_load_image): Fix pointer signedness problem by changing
14210 last arg from unsigned char * to char *. All uses changed.
14211 Also, fix a local for similar reasons.
14212 Remove unused locals. Remove locals to avoid shadowing.
14213 (fn_rsvg_handle_free): Remove; unused.
14214 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 14215 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 14216
3f754b86
PE
14217 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
14218
2547adb1
CY
142192011-06-10 Chong Yidong <cyd@stupidchicken.com>
14220
14221 * image.c (gif_load): Fix omitted cast error introduced by
14222 2011-06-06 change.
14223
2c8e37d4
MR
142242011-06-10 Martin Rudalics <rudalics@gmx.at>
14225
14226 * window.h (resize_proportionally, orig_total_lines)
14227 (orig_top_line): Remove from window structure.
14228 (set_window_height, set_window_width, change_window_heights)
14229 (Fdelete_window): Remove prototypes.
14230 (resize_frame_windows): Remove duplicate declaration.
14231
440a42e3
EZ
142322011-06-10 Eli Zaretskii <eliz@gnu.org>
14233
14234 * window.h (resize_frame_windows, resize_window_check)
14235 (delete_deletable_window, resize_root_window)
14236 (resize_frame_windows): Declare prototypes.
14237
14238 * window.c (resize_window_apply): Make definition be "static" to
14239 match the prototype.
14240
562dd5e9
MR
142412011-06-10 Martin Rudalics <rudalics@gmx.at>
14242
14243 * window.c: Remove declarations of Qwindow_size_fixed,
14244 window_min_size_1, window_min_size_2, window_min_size,
14245 size_window, window_fixed_size_p, enlarge_window, delete_window.
14246 Remove static from declaration of Qdelete_window, it's
14247 temporarily needed by Fbury_buffer.
14248 (replace_window): Don't assign orig_top_line and
14249 orig_total_lines.
14250 (Fdelete_window, delete_window): Remove. Window deletion is
14251 handled by window.el.
640c8776
SM
14252 (window_loop): Remove DELETE_OTHER_WINDOWS case.
14253 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
14254 (Fdelete_other_windows): Remove. Deleting other windows is
14255 handled by window.el.
14256 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
14257 handled in window.el.
14258 (window_min_size_2, window_min_size_1, window_min_size): Remove.
14259 Window minimum sizes are handled in window.el.
14260 (shrink_windows, size_window, set_window_height)
14261 (set_window_width, change_window_heights, window_height)
14262 (window_width, CURBEG, CURSIZE, enlarge_window)
14263 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
14264 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
14265 handled in window.el.
14266 (make_dummy_parent): Rename to make_parent_window and give it a
14267 second argument horflag.
14268 (make_window): Don't set resize_proportionally any more.
14269 (Fsplit_window): Remove. Windows are split in window.el.
14270 (save_restore_action, save_restore_orig_size)
14271 (shrink_window_lowest_first, save_restore_orig_size): Remove.
14272 Resize mini windows in window.el.
14273 (grow_mini_window, shrink_mini_window): Implement by calling
14274 Qresize_root_window_vertically, resize_window_check and
14275 resize_window_apply.
640c8776
SM
14276 (saved_window, Fset_window_configuration, save_window_save):
14277 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
14278 resize_proportionally.
14279 (window_min_height, window_min_width): Move to window.el.
14280 (keys_of_window): Move bindings for delete-other-windows,
14281 split-window, delete-window and enlarge-window to window.el.
14282
14283 * buffer.c: Temporarily extern Qdelete_window.
14284 (Fbury_buffer): Temporarily call Qdelete_window instead of
14285 Fdelete_window (Fbury_buffer will move to window.el soon).
14286
14287 * frame.c (set_menu_bar_lines_1): Remove code handling
14288 orig_top_line and orig_total_lines.
14289
14290 * dispnew.c (adjust_frame_glyphs_initially): Don't use
14291 set_window_height but set heights directly.
14292 (change_frame_size_1): Use resize_frame_windows.
14293
14294 * xdisp.c (init_xdisp): Don't use set_window_height but set
14295 heights directly.
14296
640c8776
SM
14297 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
14298 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
14299 run_window_configuration_change_hook.
14300
14301 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
14302 instead of change_window_heights and run
14303 run_window_configuration_change_hook.
14304
1a13852e
MR
143052011-06-09 Martin Rudalics <rudalics@gmx.at>
14306
14307 * window.c (replace_window): Rename second argument REPLACEMENT to
14308 NEW. New third argument SETFLAG. Rewrite.
14309 (delete_window, make_dummy_parent): Call replace_window with
14310 third argument 1.
14311 (window_list_1): Move down in code.
14312 (run_window_configuration_change_hook): Move set_buffer part
14313 before select_frame_norecord part in order to unwind correctly.
14314 Rename count1 to count.
14315 (recombine_windows, delete_deletable_window, resize_root_window)
14316 (Fdelete_other_windows_internal)
14317 (Frun_window_configuration_change_hook, make_parent_window)
14318 (resize_window_check, resize_window_apply, Fresize_window_apply)
14319 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
14320 (Fdelete_window_internal, Fresize_mini_window_internal):
14321 New functions.
1a13852e
MR
14322 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
14323
f3d1777e
MR
143242011-06-08 Martin Rudalics <rudalics@gmx.at>
14325
496e208e
MR
14326 * window.h (window): Add some new members to window structure -
14327 normal_lines, normal_cols, new_total, new_normal, clone_number,
14328 splits, nest, prev_buffers, next_buffers.
14329 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 14330 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 14331
f3d1777e
MR
14332 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
14333 Remove.
496e208e
MR
14334 (make_dummy_parent): Set new members of windows structure.
14335 (make_window): Move down in code. Handle new members of window
14336 structure.
14337 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
14338 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
14339 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
14340 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
14341 (Fset_window_next_buffers, Fset_window_clone_number):
14342 New functions.
496e208e
MR
14343 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
14344 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
14345 Doc-string fixes.
14346 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
14347 Argument WINDOW can be now internal window too.
14348 (Fwindow_use_time): Move up in code.
14349 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
14350 Rewrite doc-string.
14351 (Fset_window_configuration, saved_window)
14352 (Fcurrent_window_configuration, save_window_save): Handle new
14353 members of window structure.
b9e809c2
MR
14354 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
14355 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
14356 (syms_of_window): New Lisp objects Qrecord_window_buffer,
14357 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
14358 Qget_mru_window, Qresize_root_window,
14359 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
14360 Qauto_buffer_name; staticpro them.
f3d1777e 14361
abde8f8c
MR
143622011-06-07 Martin Rudalics <rudalics@gmx.at>
14363
14364 * window.c (Fwindow_total_size, Fwindow_left_column)
14365 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
14366 (Fwindow_list_1): New functions.
14367 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
14368 (Fwindow_width, Fscroll_left, Fscroll_right):
14369 Use window_body_cols instead of window_box_text_cols.
14370 (delete_window, Fset_window_configuration):
14371 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
14372 (delete_all_subwindows): Take a window as argument and not a
14373 structure. Rewrite.
190b47e6
MR
14374 (window_loop): Remove handling of GET_LRU_WINDOW and
14375 GET_LARGEST_WINDOW.
14376 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
14377
14378 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
14379 window_box_text_cols. delete_all_subwindows now takes a
14380 Lisp_Object as argument.
abde8f8c 14381
640c8776
SM
14382 * indent.c (compute_motion, Fcompute_motion):
14383 Use window_body_cols instead of window_box_text_cols.
abde8f8c 14384
fa8a67e6
MR
14385 * frame.c (delete_frame): Call delete_all_subwindows with root
14386 window as argument.
14387
a54e3482
DC
143882011-06-07 Daniel Colascione <dan.colascione@gmail.com>
14389
14390 * fns.c (Fputhash): Document return value.
14391
60002bf5
CY
143922011-06-06 Chong Yidong <cyd@stupidchicken.com>
14393
14394 * image.c (gif_load): Implement gif89a spec "no disposal" method.
14395
0c671da6 143962011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 14397
b862a52a 14398 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 14399
be44ca6c
PE
14400 Check for overflow when converting integer to cons and back.
14401 * charset.c (Fdefine_charset_internal, Fdecode_char):
14402 Use cons_to_unsigned to catch overflow.
14403 (Fencode_char): Use INTEGER_TO_CONS.
14404 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
14405 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
14406 * data.c (long_to_cons, cons_to_long): Remove.
14407 (cons_to_unsigned, cons_to_signed): New functions.
14408 These signal an error for invalid or out-of-range values.
14409 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
14410 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
14411 * font.c (Ffont_variation_glyphs):
14412 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
14413 * lisp.h: Include <intprops.h>.
14414 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
14415 (cons_to_signed, cons_to_unsigned): New decls.
14416 (long_to_cons, cons_to_long): Remove decls.
14417 * undo.c (record_first_change): Use INTEGER_TO_CONS.
14418 (Fprimitive_undo): Use CONS_TO_INTEGER.
14419 * xfns.c (Fx_window_property): Likewise.
14420 * xselect.c: Include <limits.h>.
14421 (x_own_selection, selection_data_to_lisp_data):
14422 Use INTEGER_TO_CONS.
14423 (x_handle_selection_request, x_handle_selection_clear)
14424 (x_get_foreign_selection, Fx_disown_selection_internal)
14425 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
14426 (lisp_data_to_selection_data): Use cons_to_unsigned.
14427 (x_fill_property_data): Use cons_to_signed.
14428 Report values out of range.
14429
d1f3d2af
PE
14430 Check for buffer and string overflow more precisely.
14431 * buffer.h (BUF_BYTES_MAX): New macro.
14432 * lisp.h (STRING_BYTES_MAX): New macro.
14433 * alloc.c (Fmake_string):
14434 * character.c (string_escape_byte8):
14435 * coding.c (coding_alloc_by_realloc):
14436 * doprnt.c (doprnt):
14437 * editfns.c (Fformat):
14438 * eval.c (verror):
14439 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
14440 since they may not be the same number.
14441 * editfns.c (Finsert_char):
14442 * fileio.c (Finsert_file_contents):
14443 Likewise for BUF_BYTES_MAX.
14444
dd52fcea
PE
14445 * image.c: Use ptrdiff_t, not int, for sizes.
14446 (slurp_file): Switch from int to ptrdiff_t.
14447 All uses changed.
14448 (slurp_file): Check that file size fits in both size_t (for
14449 malloc) and ptrdiff_t (for sanity and safety).
14450
7f9bbdbb
PE
14451 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
14452 if b->modtime has its maximal value.
14453
dfe18f82
PE
14454 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
14455
84acfcf0
PE
14456 Don't assume time_t can fit into int.
14457 * buffer.h (struct buffer.modtime): Now time_t, not int.
14458 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
14459 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
14460
ccd9a01a
PE
14461 Minor fixes for signed vs unsigned integers.
14462 * character.h (MAYBE_UNIFY_CHAR):
14463 * charset.c (maybe_unify_char):
14464 * keyboard.c (read_char, reorder_modifiers):
14465 XINT -> XFASTINT, since the integer must be nonnegative.
14466 * ftfont.c (ftfont_spec_pattern):
14467 * keymap.c (access_keymap, silly_event_symbol_error):
14468 XUINT -> XFASTINT, since the integer must be nonnegative.
14469 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
14470 since it makes no difference and we prefer signed.
14471 * keyboard.c (record_char): Use XUINT when all the neighbors do.
14472 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
14473 nonnegative.
14474
d6d100dd
SM
144752011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
14476
14477 * window.h (Fwindow_frame): Declare.
14478
2b6148e4
PE
144792011-06-06 Paul Eggert <eggert@cs.ucla.edu>
14480
14481 * alloc.c: Simplify handling of large-request failures (Bug#8800).
14482 (SPARE_MEMORY): Always define.
14483 (LARGE_REQUEST): Remove.
14484 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
14485
f230ecc9
MR
144862011-06-06 Martin Rudalics <rudalics@gmx.at>
14487
727e958e
MR
14488 * lisp.h: Move EXFUNS for Fframe_root_window,
14489 Fframe_first_window and Fset_frame_selected_window to window.h.
14490
14491 * window.h: Move EXFUNS for Fframe_root_window,
14492 Fframe_first_window and Fset_frame_selected_window here from
14493 lisp.h.
14494
14495 * frame.c (Fwindow_frame, Fframe_first_window)
14496 (Fframe_root_window, Fframe_selected_window)
14497 (Fset_frame_selected_window): Move to window.c.
14498 (Factive_minibuffer_window): Move to minibuf.c.
14499 (Fother_visible_frames_p): New function.
14500
14501 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
14502
f230ecc9
MR
14503 * window.c (decode_window, decode_any_window): Move up in code.
14504 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
14505 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
14506 (Fwindow_buffer): Move up and rewrite doc-string.
14507 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
14508 (Fwindow_prev): New functions.
727e958e
MR
14509 (Fwindow_frame): Move here from frame.c. Accept any window as
14510 argument.
14511 (Fframe_root_window, Fframe_first_window)
14512 (Fframe_selected_window): Move here from frame.c. Accept frame
14513 or arbitrary window as argument. Update doc-strings.
14514 (Fminibuffer_window): Move up in code.
14515 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
14516 (Fset_frame_selected_window): Move here from frame.c.
14517 Marginal rewrite.
727e958e
MR
14518 (Fselected_window, select_window, Fselect_window): Move up in
14519 code. Minor doc-string fixes.
f230ecc9 14520
4d09bcf6
PE
145212011-06-06 Paul Eggert <eggert@cs.ucla.edu>
14522
14523 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
14524 Do not assume that spare memory exists; that assumption is valid
14525 only if SYSTEM_MALLOC.
14526 (LARGE_REQUEST): New macro, so that the issue of large requests
14527 is separated from the issue of spare memory.
14528
810928a2
AS
145292011-06-05 Andreas Schwab <schwab@linux-m68k.org>
14530
172418ad
AS
14531 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
14532 format. (Bug#8806)
14533
43f862f7
AS
14534 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
14535
810928a2
AS
14536 * xfns.c (x_set_scroll_bar_default_width): Move declarations
14537 before statements.
14538
a059fe24
JD
145392011-06-05 Jan Djärv <jan.h.d@swipnet.se>
14540
14541 * gtkutil.c (xg_get_default_scrollbar_width): New function.
14542
14543 * gtkutil.h: Declare xg_get_default_scrollbar_width.
14544
14545 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
14546 min width by calling x_set_scroll_bar_default_width (Bug#8505).
14547
989bf368
JB
145482011-06-05 Juanma Barranquero <lekktu@gmail.com>
14549
14550 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
14551
4b80f674
CY
145522011-06-04 Chong Yidong <cyd@stupidchicken.com>
14553
14554 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
14555 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
14556 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
14557 New error handlers.
4b80f674
CY
14558 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
14559 Obey Vx_select_enable_clipboard_manager. Catch errors in
14560 x_clipboard_manager_save (Bug#8779).
14561 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 14562 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 14563
99a33b77 145642011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
14565
14566 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
14567
99a33b77 145682011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
14569
14570 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
14571 in the current matrix if keep_current_p is non-zero.
14572
8264569d
EZ
145732011-06-04 Eli Zaretskii <eliz@gnu.org>
14574
14575 * bidi.c (bidi_level_of_next_char): Fix last change.
14576
57f97249
EZ
145772011-06-03 Eli Zaretskii <eliz@gnu.org>
14578
fec2107c 14579 Support bidi reordering of text covered by display properties.
57f97249 14580
fec2107c
EZ
14581 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
14582 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
14583 (bidi_cache_search, bidi_cache_iterator_state)
14584 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
14585 (bidi_level_of_next_char, bidi_move_to_visually_next):
14586 Support character positions inside a run of characters covered by a
fec2107c
EZ
14587 display string.
14588 (bidi_paragraph_init, bidi_resolve_explicit_1)
14589 (bidi_level_of_next_char): Call bidi_fetch_char and
14590 bidi_fetch_char_advance instead of FETCH_CHAR and
14591 FETCH_CHAR_ADVANCE.
14592 (bidi_init_it): Initialize new members.
14593 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
14594 definitions.
14595 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
14596 instead of using explicit *_CHAR codes.
d6d100dd
SM
14597 (bidi_resolve_explicit, bidi_resolve_weak):
14598 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
14599 bidirectional text is supported only in multibyte buffers.
14600 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
14601 it to initialize the frame_window_p member of struct bidi_it.
14602 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
14603 (bidi_resolve_explicit, bidi_resolve_weak)
14604 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
14605 bidi_it->nchars is non-positive.
14606 (bidi_level_of_next_char): Don't try to lookup the cache for the
14607 next/previous character if nothing is cached there yet, or if we
14608 were just reseat()'ed to a new position.
c40e2fb2 14609
0e14fe90
EZ
14610 * xdisp.c (set_cursor_from_row): Set start and stop points
14611 according to the row's direction when priming the loop that looks
14612 for the glyph on which to display cursor.
14613 (single_display_spec_intangible_p): Function deleted.
14614 (display_prop_intangible_p): Reimplement to call
14615 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
14616 Accept 3 additional arguments needed by handle_display_spec.
14617 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
14618 values: lists, `(when COND...)' forms, etc.
14619 (single_display_spec_string_p): Support property values that are
14620 lists with the argument STRING its top-level element.
14621 (display_prop_string_p): Fix the condition for processing a
14622 property that is a list to be consistent with handle_display_spec.
fec2107c 14623 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
14624 last portion of handle_display_prop.
14625 (compute_display_string_pos): Accept additional argument
14626 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
14627 value of a `display' property is a "replacing spec".
14628 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
14629 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
14630 the display property, but just return a value indicating whether
14631 the display property will replace the characters it covers.
14632 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
14633 frame_window_p members of struct bidi_it.
d6d100dd
SM
14634 (compute_display_string_pos, compute_display_string_end):
14635 New functions.
fec2107c
EZ
14636 (push_it): Accept second argument POSITION, where pop_it should
14637 jump to continue iteration.
14638 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 14639
fec2107c
EZ
14640 * keyboard.c (adjust_point_for_property): Adjust the call to
14641 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
14642
14643 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
14644 (bidi_init_it): Update prototypes.
14645 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
14646 (compute_display_string_pos, compute_display_string_end):
14647 Declare prototypes.
fec2107c
EZ
14648 (struct bidi_it): New members nchars and disp_pos. ch_len is now
14649 EMACS_INT.
fc6f18ce 14650
40087514 146512011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 14652
57f53182
PE
14653 Malloc failure behavior now depends on size of allocation.
14654 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
14655 * lisp.h: Change signatures accordingly.
14656 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
14657 All callers changed. (Bug#8762)
14658
14659 * gnutls.c: Use Emacs's memory allocators.
14660 Without this change, the gnutls library would invoke malloc etc.
14661 directly, which causes problems on non-SYNC_INPUT hosts, and which
14662 runs afoul of improving memory_full behavior. (Bug#8761)
14663 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
14664 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
14665 xfree instead of the default malloc, realloc, free.
14666 (Fgnutls_boot): No need to check for memory allocation failure,
14667 since xmalloc does that for us.
14668
ac32cd99 14669 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
14670 * category.c (hash_get_category_set):
14671 * ccl.c (ccl_driver):
14672 * charset.c (Fdefine_charset_internal):
14673 * charset.h (struct charset.hash_index):
14674 * composite.c (get_composition_id, gstring_lookup_cache)
14675 (composition_gstring_put_cache):
14676 * composite.h (struct composition.hash_index):
14677 * dispextern.h (struct image.hash):
14678 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
14679 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
14680 (hashfn_equal, hashfn_user_defined, make_hash_table)
14681 (maybe_resize_hash_table, hash_lookup, hash_put)
14682 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
14683 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
14684 (Fsxhash, Fgethash, Fputhash, Fmaphash):
14685 * image.c (make_image, search_image_cache, lookup_image)
14686 (xpm_put_color_table_h):
14687 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 14688 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 14689 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 14690 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
14691 * alloc.c (allocate_vectorlike):
14692 Check for overflow in vector size calculations.
14693 * ccl.c (ccl_driver):
14694 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
14695 * fns.c, image.c: Remove unnecessary static decls that would otherwise
14696 need to be updated by these changes.
40087514
PE
14697 * fns.c (make_hash_table, maybe_resize_hash_table):
14698 Check for integer overflow with large hash tables.
0de4bb68
PE
14699 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
14700 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
14701 (SXHASH_REDUCE): New macro.
14702 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
14703 Use it instead of discarding useful hash info with large hash values.
14704 (sxhash_float): New function.
14705 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
14706 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
14707 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
14708 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
14709 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
14710 Adjust signatures to match updated version of code.
14711 (consing_since_gc): Now EMACS_INT, since a single hash table can
14712 use more than INT_MAX bytes.
14713
698d32e2
DN
147142011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
14715
14716 Make it possible to build with GCC-4.6+ -O2 -flto.
14717
14718 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
14719
fd6fa53f
SM
147202011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
14721
14722 * minibuf.c (get_minibuffer, read_minibuf_unwind):
14723 Call minibuffer-inactive-mode.
14724
864db017
JB
147252011-05-31 Juanma Barranquero <lekktu@gmail.com>
14726
14727 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
14728 Update dependencies.
14729
2ad0baf4
DN
147302011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
14731
14732 * data.c (init_data): Remove code for UTS, this system is not
14733 supported anymore.
14734
4fcc2638
DN
147352011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
14736
14737 Don't force ./temacs to start in terminal mode.
14738
14739 * frame.c (make_initial_frame): Initialize faces in all cases, not
14740 only when CANNOT_DUMP is defined.
14741 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
14742
c56e0fd5
DN
147432011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
14744
14745 * dispnew.c (add_window_display_history): Use const for the string
14746 pointer. Remove declaration, not needed.
14747
333d54da 147482011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 14749
55d4c1b2 14750 Use 'inline', not 'INLINE'.
333d54da 14751 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
14752 * alloc.c, fontset.c (INLINE): Remove.
14753 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
14754 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
14755 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
14756 * gmalloc.c (register_heapinfo): Use inline unconditionally.
14757 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
14758
738db178
DN
147592011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
14760
14761 Make it possible to run ./temacs.
14762
14763 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
14764 syms_of_callproc does the same thing. Remove test for
14765 "initialized", do it in the caller.
14766 * emacs.c (main): Avoid calling set_initial_environment when dumping.
14767
620c53a6
SM
147682011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
14769
14770 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
14771 (read_minibuf): Use get_minibuffer.
14772 (syms_of_minibuf): Use DEFSYM.
14773 (Qmetadata): New var.
14774 * data.c (Qbuffer): Don't make it static.
14775 (syms_of_data): Use DEFSYM.
14776
e003a292
PE
147772011-05-31 Paul Eggert <eggert@cs.ucla.edu>
14778
14779 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
14780 (CCL_CODE_MIN): New macro.
14781
ed008a6d
PE
147822011-05-30 Paul Eggert <eggert@cs.ucla.edu>
14783
3687c2ef
PE
14784 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
14785
ed008a6d
PE
14786 * eval.c (Qdebug): Now static.
14787 * lisp.h (Qdebug): Remove decl. This reverts a part of the
14788 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
14789 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
14790
d66c4c7c
CY
147912011-05-29 Chong Yidong <cyd@stupidchicken.com>
14792
14793 * image.c: Various fixes to ImageMagick code comments.
14794 (Fimagemagick_types): Doc fix.
14795
5fbc2025
PE
147962011-05-29 Paul Eggert <eggert@cs.ucla.edu>
14797
0196f88a
PE
14798 Minor fixes prompted by GCC 4.6.0 warnings.
14799
14800 * xselect.c (converted_selections, conversion_fail_tag): Now static.
14801
5fbc2025
PE
14802 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
14803 (x_clipboard_manager_save_all): Move extern decl to ...
14804 * xterm.h: ... here, so that it can be checked for consistency.
14805
1dd3c2d9
CY
148062011-05-29 Chong Yidong <cyd@stupidchicken.com>
14807
14808 * xselect.c (x_clipboard_manager_save_frame)
14809 (x_clipboard_manager_save_all): New functions.
14810 (Fx_clipboard_manager_save): Lisp function deleted.
14811
14812 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
14813 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
14814
14815 * xterm.h: Update prototype.
14816
5ba6571d
WX
148172011-05-28 William Xu <william.xwl@gmail.com>
14818
14819 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
14820 exiting (Bug#8239).
14821
3eaff834
JM
148222011-05-28 Jim Meyering <meyering@redhat.com>
14823
e1900994 14824 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
14825 * fns.c (to_uchar): Define.
14826 (crypto_hash_function): Use it to convert some newly-signed
14827 variables to unsigned, to avoid sign-extension bugs. For example,
14828 without this change, (md5 "truc") would evaluate to
14829 45723a2aff78ff4fff7fff1114760e62 rather than the expected
14830 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 14831 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 14832
0f6990a7
PE
148332011-05-27 Paul Eggert <eggert@cs.ucla.edu>
14834
14835 Integer overflow fixes.
c8a9ca5a 14836
08686060
PE
14837 * dbusbind.c: Serial number integer overflow fixes.
14838 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
14839 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
14840 to hold a serial number that is too large for a fixnum.
14841 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14842 Check for serial numbers out of range. Decode any serial number
59568bf0 14843 that was so large that it became a float. (Bug#8722)
08686060 14844
2d1fc3c7
PE
14845 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
14846 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14847 Use XFASTINT rather than XUINT when numbers are nonnegative.
14848 (xd_append_arg, Fdbus_method_return_internal):
14849 (Fdbus_method_error_internal): Likewise. Also, for unsigned
14850 arguments, check that Lisp number is nonnegative, rather than
59568bf0 14851 silently wrapping negative numbers around. (Bug#8722)
30217ff0 14852 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 14853 (Bug#8722)
2d1fc3c7 14854
c8a9ca5a
PE
14855 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
14856
519e1d69
PE
14857 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
14858
6df6ae42 14859 ccl: Add integer overflow checks.
30569699
PE
14860 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
14861 (IN_INT_RANGE): New macros.
14862 (ccl_driver): Use them to check for integer overflow when
14863 decoding a CCL program. Many of the new checks are whether XINT (x)
14864 fits in int; it doesn't always, on 64-bit hosts. The new version
14865 doesn't catch all possible integer overflows, but it's an
847044ea 14866 improvement. (Bug#8719)
30569699 14867
c11285dc
PE
14868 * alloc.c (make_event_array): Use XINT, not XUINT.
14869 There's no need for unsigned here.
14870
fdccd48e
PE
14871 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
14872 This follows up to the 2011-05-06 change that substituted uintptr_t
14873 for EMACS_INT. This case wasn't caught back then.
14874
37910ab2
PE
14875 Rework Fformat to avoid integer overflow issues.
14876 * editfns.c: Include <float.h> unconditionally, as it's everywhere
14877 now (part of C89). Include <verify.h>.
14878 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
14879 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
14880 (Fformat): Avoid the prepass trying to compute sizes; it was only
14881 approximate and thus did not catch overflow reliably. Instead, walk
14882 through the format just once, formatting and computing sizes as we go,
14883 checking for integer overflow at every step, and allocating a larger
14884 buffer as needed. Keep track separately whether the format is
14885 multibyte. Keep only the most-recently calculated precision, rather
14886 than them all. Record whether each argument has been converted to
14887 string. Use EMACS_INT, not int, for byte and char and arg counts.
14888 Support field widths and precisions larger than INT_MAX. Avoid
14889 sprintf's undefined behavior with conversion specifications such as %#d
14890 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
14891 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
14892 formatting out-of-range floating point numbers with int
9173deec 14893 formats. (Bug#8668)
37910ab2 14894
2e6578fb
PE
14895 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
14896
0ae6bdee
PE
14897 * data.c: Avoid integer truncation in expressions involving floats.
14898 * data.c: Include <intprops.h>.
14899 (arith_driver): When there's an integer overflow in an expression
14900 involving floating point, convert the integers to floating point
14901 so that the resulting value does not suffer from catastrophic
14902 integer truncation. For example, on a 64-bit host (* 4
14903 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
14904 Do not rely on undefined behavior after integer overflow.
14905
de883a70
PE
14906 merge count_size_as_multibyte, parse_str_to_multibyte
14907 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 14908 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
14909 Check for integer overflow.
14910 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
14911 since it's now a duplicate of the other. This is more of
14912 a character than a buffer op, so better that it's in character.c.
14913 * fns.c, print.c: Adjust to above changes.
14914
2ff916cb
PE
149152011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
14916
14917 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
14918
f1b54466
PE
149192011-05-27 Paul Eggert <eggert@cs.ucla.edu>
14920
fb1ac845
PE
14921 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
14922 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
14923 (x_clipboard_manager_save): Now static.
14924 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
14925
f1b54466
PE
14926 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
14927 (crypto_hash_function): Now static.
14928 Fix pointer signedness problems. Avoid unnecessary initializations.
14929
a9f737ee
CY
149302011-05-27 Chong Yidong <cyd@stupidchicken.com>
14931
14932 * termhooks.h (Vselection_alist): Make it terminal-local.
14933
14934 * terminal.c (create_terminal): Initialize it.
14935
14936 * xselect.c: Support for clipboard managers.
14937 (Vselection_alist): Move to termhooks.h as terminal-local var.
14938 (LOCAL_SELECTION): New macro.
14939 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
14940 (symbol_to_x_atom): Remove gratuitous arg.
14941 (x_handle_selection_request, lisp_data_to_selection_data)
14942 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
14943 (x_own_selection, x_get_local_selection, x_convert_selection):
14944 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
14945 (some_frame_on_display): Delete unused function.
14946 (Fx_own_selection_internal, Fx_get_selection_internal)
14947 (Fx_disown_selection_internal, Fx_selection_owner_p)
14948 (Fx_selection_exists_p): New optional frame arg.
14949 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
14950 (x_handle_selection_clear): Don't treat other terminals with the
14951 same keyboard specially. Use the terminal-local Vselection_alist.
14952 (x_clear_frame_selections): Use Frun_hook_with_args.
14953
14954 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
14955
14956 * xterm.h: Add support for those atoms.
14957
e067f0c1
CY
149582011-05-26 Chong Yidong <cyd@stupidchicken.com>
14959
14960 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
14961 (converted_selections, conversion_fail_tag): New global variables.
14962 (x_selection_request_lisp_error): Free the above.
14963 (x_get_local_selection): Remove unnecessary code.
14964 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
14965 of converted selections stored in converted_selections.
14966 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
14967 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
14968 (x_convert_selection): New function.
14969 (x_handle_selection_event): Simplify.
14970 (x_get_foreign_selection): Don't ignore incoming requests while
14971 waiting for an answer; this will fail when we implement
14972 SAVE_TARGETS, and seems unnecessary anyway.
14973 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
14974 (Vx_sent_selection_functions): Doc fix.
14975
0f4aebc0
LL
149762011-05-26 Leo Liu <sdl.web@gmail.com>
14977
14978 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
14979
e61124cd
YM
149802011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14981
14982 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
14983
14984 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
14985 for fringe update if it has periodic bitmap.
ac389d0c 14986 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
14987 and fringe_bitmap_periodic_p.
14988
14989 * fringe.c (get_fringe_bitmap_data): New function.
14990 (draw_fringe_bitmap_1, update_window_fringes): Use it.
14991 (update_window_fringes): Record periodicity of fringe bitmap in glyph
14992 row. Mark glyph row for fringe update if periodicity changed.
14993
14994 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
14995 for fringe update unless it has periodic bitmap.
14996
f16d9837
KH
149972011-05-25 Kenichi Handa <handa@m17n.org>
14998
14999 * xdisp.c (get_next_display_element): Set correct it->face_id for
15000 a static composition.
15001
e1b90ef6
LL
150022011-05-24 Leo Liu <sdl.web@gmail.com>
15003
15004 * deps.mk (fns.o):
15005 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
15006
15007 * fns.c (crypto_hash_function, Fsha1): New function.
15008 (Fmd5): Use crypto_hash_function.
15009 (syms_of_fns): Add Ssha1.
15010
7400048f
PE
150112011-05-22 Paul Eggert <eggert@cs.ucla.edu>
15012
15013 * gnutls.c: Remove unused macros.
15014 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
15015 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
15016 Remove macros that are defined and never used.
15017 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
15018
abb71cf4
CY
150192011-05-22 Chong Yidong <cyd@stupidchicken.com>
15020
15021 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
15022 (Fx_get_selection_internal): Minor cleanup.
15023 (Fx_own_selection_internal): Rename arguments for consistency with
15024 select.el.
15025
6307db39
PE
150262011-05-22 Paul Eggert <eggert@cs.ucla.edu>
15027
15028 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
15029
f3d4e0a4
CY
150302011-05-22 Chong Yidong <cyd@stupidchicken.com>
15031
15032 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
15033
4d8ade89
YM
150342011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
15035
15036 * dispnew.c (scrolling_window): Don't exclude the case that the
15037 last enabled row in the desired matrix touches the bottom boundary.
15038
32078c8d
GM
150392011-05-21 Glenn Morris <rgm@gnu.org>
15040
15041 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
15042 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
15043 and add some more files.
32078c8d 15044
7285dc67
EZ
150452011-05-20 Eli Zaretskii <eliz@gnu.org>
15046
15047 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
15048 report_file_error introduced by the change from 2011-05-07.
15049
89d1bd22
PE
150502011-05-20 Paul Eggert <eggert@cs.ucla.edu>
15051
15052 * systime.h (Time): Define only if emacs is defined.
15053 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
15054 where the include path doesn't have X11/X.h by default. See
15055 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
15056
cd394be1 150572011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
15058
15059 * composite.c (find_automatic_composition): Fix previous change.
15060
b9704ad9
GM
150612011-05-20 Glenn Morris <rgm@gnu.org>
15062
15063 * lisp.mk: New file, split from Makefile.in.
15064 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
15065 (shortlisp): Remove.
15066 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
15067
4a720484
GM
150682011-05-19 Glenn Morris <rgm@gnu.org>
15069
15070 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
15071 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
15072 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
15073 (lisp): Set the order to that of loadup.el.
15074 (shortlisp): Make it a copy of $lisp.
15075 (SOME_MACHINE_LISP): Remove.
15076 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
15077 Use just $shortlisp, not $SOME_MACHINE_LISP too.
15078
a28d4396
KH
150792011-05-18 Kenichi Handa <handa@m17n.org>
15080
15081 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
15082 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
15083 (find_automatic_composition): Mostly rewrite for efficiency.
15084
a2b1fa8e
JB
150852011-05-18 Juanma Barranquero <lekktu@gmail.com>
15086
15087 * makefile.w32-in: Update dependencies.
15088
8e1f5610
CS
150892011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
15090
15091 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 15092 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 15093
7025ee00 150942011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 15095
cdfa6eab
PE
15096 Fix some integer overflow issues, such as string length overflow.
15097
06d6db33
PE
15098 * insdel.c (count_size_as_multibyte): Check for string overflow.
15099
2b4560a8
PE
15100 * character.c (lisp_string_width): Check for string overflow.
15101 Use EMACS_INT, not int, for string indexes and lengths; in
15102 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
15103 the resulting string length overflows an EMACS_INT; instead,
15104 report a string overflow if no precision given. When checking for
15105 precision exhaustion, use a check that cannot possibly have
15106 integer overflow. (Bug#8675)
15107 * character.h (lisp_string_width): Adjust to new signature.
15108
cb93f9be
PE
15109 * alloc.c (string_overflow): New function.
15110 (Fmake_string): Use it. This doesn't change behavior, but saves
15111 a few bytes and will simplify future changes.
15112 * character.c (string_escape_byte8): Likewise.
15113 * lisp.h (string_overflow): New decl.
15114
1a1f3366
PE
15115 Fixups, following up to the user-interface timestamp change.
15116 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
15117 for UI timestamps, instead of unsigned long.
9fbd6841
PE
15118 * msdos.c (mouse_get_pos): Likewise.
15119 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
15120 * w32gui.h (Time): Define by including "systime.h" rather than by
15121 declaring it ourselves. (Bug#8664)
15122
d4e3e4d3
PE
15123 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
15124 * image.c (clear_image_cache): Likewise.
15125
f6a24d19
PE
15126 * term.c (term_mouse_position): Don't assume time_t wraparound.
15127
08dc5ae6
PE
15128 Be more systematic about user-interface timestamps.
15129 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
15130 and sometimes 'EMACS_UINT', to represent these timestamps.
15131 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
15132 This makes the code easier to follow, and makes it easier to catch
15133 integer overflow bugs such as Bug#8664.
15134 * frame.c (Fmouse_position, Fmouse_pixel_position):
15135 Use Time, not unsigned long, for user-interface timestamps.
15136 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
15137 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
15138 * keyboard.h (last_event_timestamp): Likewise.
15139 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
15140 * menu.h (xmenu_show): Likewise.
15141 * term.c (term_mouse_position): Likewise.
15142 * termhooks.h (struct input_event.timestamp): Likewise.
15143 (struct terminal.mouse_position_hook): Likewise.
15144 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
15145 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
15146 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
15147 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
15148 what it was before.
15149 * menu.h, termhooks.h: Include "systime.h", for Time.
15150
8e55734a
PE
15151 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
15152 Don't assume that the difference between two unsigned long values
15153 can fit into an integer. At this point, we know button_down_time
15154 <= event->timestamp, so the difference must be nonnegative, so
15155 there's no need to cast the result if double-click-time is
15156 nonnegative, as it should be; check that it's nonnegative, just in
15157 case. This bug is triggered when events are more than 2**31 ms
86db42d2 15158 apart (about 25 days). (Bug#8664)
8e55734a 15159
841f1b75 15160 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 15161 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 15162
3e26f69c
PE
15163 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
15164 that always fit in int. Use a sentinel instead of a counter, to
15165 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
15166 * frame.h (struct frame): Use int for menu_bar_items_used
15167 instead of EMACS_INT, since it always fits in int.
3e26f69c 15168
5cc152c0
PE
15169 * menu.c (grow_menu_items): Check for int overflow.
15170
d89eb65e
PE
15171 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
15172
5235bd3e
PE
15173 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
15174 Before, the code was not consistent. These values cannot exceed
15175 2**31 - 1 so there's no need to make them unsigned.
15176 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
15177 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
15178 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
15179 as modifiers.
15180 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
15181
bc827e23
PE
15182 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
15183 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
15184 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
15185 presumably because the widths might not match.
15186
78eb494e
PE
15187 * window.c (size_window): Avoid needless test at loop start.
15188
04f2d78b
CB
151892011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
15190
15191 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
15192
d2fc7e3d 151932011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
15194
15195 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
15196
d2fc7e3d 151972011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
15198
15199 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
15200 `width' to `bar_area_x' and `bar_area_width', respectively.
15201 (x_scroll_run): Take account of fringe background extension.
15202
04f2d78b
CB
15203 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
15204 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
15205 `bar_area_width', respectively.
15206 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
15207 background extension.
15208
79b70037
GM
152092011-05-10 Jim Meyering <meyering@redhat.com>
15210
15211 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
15212
2f142cc5
JB
152132011-05-10 Juanma Barranquero <lekktu@gmail.com>
15214
15215 * image.c (Finit_image_library): Return t for built-in image types,
15216 like pbm and xbm. (Bug#8640)
15217
57679c86
AS
152182011-05-09 Andreas Schwab <schwab@linux-m68k.org>
15219
15220 * w32menu.c (set_frame_menubar): Fix submenu allocation.
15221
888c9e86
EZ
152222011-05-07 Eli Zaretskii <eliz@gnu.org>
15223
b0512a1d
EZ
15224 * w32console.c (Fset_screen_color): Doc fix.
15225 (Fget_screen_color): New function.
15226 (syms_of_ntterm): Defsubr it.
15227
7285dc67
EZ
15228 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
15229 unlink the temporary file if Fcall_process didn't create it in the
15230 first place.
15231 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
15232 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
15233 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
15234 cue to call_process_cleanup not to close that handle.
15235
4d3fcc8e
BK
152362011-05-07 Ben Key <bkey76@gmail.com>
15237
15238 * makefile.w32-in: The bootstrap-temacs rule now makes use of
15239 one of two shell specific rules, either bootstrap-temacs-CMD or
15240 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
15241 to the previous implementation of the bootstrap-temacs rule.
15242 The bootstrap-temacs-CMD rule is similar to the previous
15243 implementation of the bootstrap-temacs rule except that it
15244 makes use of the ESC_CFLAGS variable instead of the CFLAGS
15245 variable.
15246
15247 These changes, along with some changes to nt/configure.bat,
15248 nt/gmake.defs, and nt/nmake.defs, are required to extend my
15249 earlier fix to add support for --cflags and --ldflags options
15250 that include quotes so that it works whether make uses cmd or
15251 sh as the shell.
15252
b4289b64
MA
152532011-05-06 Michael Albinus <michael.albinus@gmx.de>
15254
15255 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
15256 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
15257 is a constant.
15258 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
15259 a string. Handle both cases.
15260 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
15261 (Fdbus_register_method): Use Qinvalid_function.
15262
af4c0e28
JB
152632011-05-06 Juanma Barranquero <lekktu@gmail.com>
15264
15265 * makefile.w32-in: Update dependencies.
15266 (LISP_H): Add inttypes.h and stdin.h.
15267 (PROCESS_H): Add unistd.h.
15268
c51453d9
EZ
152692011-05-06 Eli Zaretskii <eliz@gnu.org>
15270
15271 * lread.c: Include limits.h (fixes the MS-Windows build broken by
15272 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
15273
8ff0ac3c 152742011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 15275
4c4b566b
PE
15276 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
15277
aab2b9b5
PE
15278 * term.c (vfatal): Remove stray call to va_end.
15279 It's not needed and the C Standard doesn't allow it here anyway.
15280
c378da0b
PE
15281 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
15282 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
15283
288b08c7
PE
15284 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
15285 bytes.
15286
e3601888
PE
15287 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
15288
db6c0e74
PE
15289 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
15290
dd5963ea
PE
15291 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
15292
88c9450f
PE
15293 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
15294
2f9442b8
PE
15295 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
15296
c032b5f8
PE
15297 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
15298 * charset.c (Fdefine_charset_internal): Don't initialize
15299 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 15300 32-bit int (Bug#8600).
a108c10b
PE
15301
15302 * lread.c (read_integer): Be more consistent with string-to-number.
15303 Use string_to_number to do the actual conversion; this avoids
15304 rounding errors and fixes some other screwups. Without this fix,
15305 for example, #x1fffffffffffffff was misread as -2305843009213693952.
15306 (digit_to_number): Move earlier, for benefit of read_integer.
15307 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 15308 not a digit in any supported base. (Bug#8602)
a108c10b 15309
ad5f9eea
PE
15310 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
15311
aec1708a
PE
15312 * dispnew.c (scrolling_window): Return 1 if we scrolled,
15313 to match comment at start of function. This also removes a
15314 GCC warning about overflow in a 32+64-bit port.
15315
47be4ab5
PE
15316 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
15317
371cac43
PE
15318 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
15319 Reported by Stefan Monnier in
15320 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
15321 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
15322 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 15323
d01a7826
PE
15324 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
15325 (EMACS_UINTPTR): Likewise, with uintptr_t.
15326
7fd47d5c
PE
15327 * lisp.h: Prefer 64-bit EMACS_INT if available.
15328 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
15329 on 32-bit hosts that have 64-bit int, so that they can access
15330 large files.
122b0c86
PE
15331 However, temporarily disable this change unless the temporary
15332 symbol WIDE_EMACS_INT is defined.
7fd47d5c 15333
8727937b
PE
15334 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
15335
8ac068ac
PE
15336 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
15337 This removes an assumption that EMACS_INT and long are the same
15338 width as pointers. The assumption is true for Emacs porting targets
15339 now, but we want to make other targets possible.
15340 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
15341 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
15342 In the rest of the code, change types of integers that hold casted
15343 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
15344 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
15345 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
15346 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
15347 No need to cast type when ORing.
15348 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
15349 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
15350 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
15351 assume EMACS_INT is the same width as char *.
15352 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
15353 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
15354 Remove no-longer-needed casts.
15355 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
15356 (xg_tool_bar_help_callback, xg_make_tool_item):
15357 Use EMACS_INTPTR to hold an integer
15358 that will be cast to void *; this can avoid a GCC warning
15359 if EMACS_INT is not the same width as void *.
15360 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
15361 * xdisp.c (display_echo_area_1, resize_mini_window_1):
15362 (current_message_1, set_message_1):
15363 Use a local to convert to proper width without a cast.
15364 * xmenu.c (dialog_selection_callback): Likewise.
15365
ede49d71
PE
15366 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
15367 Also, don't assume VALBITS / RAND_BITS is less than 5,
15368 and don't rely on undefined behavior when shifting a 1 left into
15369 the sign bit.
15370 * lisp.h (get_random): Change signature to match.
15371
2f30ecd0
PE
15372 * lread.c (hash_string): Use size_t, not int, for hash computation.
15373 Normally we prefer signed values; but hashing is special, because
15374 it's better to use unsigned division on hash table sizes so that
15375 the remainder is nonnegative. Also, size_t is the natural width
15376 for hashing into memory. The previous code used 'int', which doesn't
15377 retain enough info to hash well into very large tables.
15378 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
15379
2a866e7b
PE
15380 * dbusbind.c: Don't possibly lose pointer info when converting.
15381 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
15382 Use XPNTR rather than XHASH, so that the high-order bits of
15383 the pointer aren't lost when converting through void *.
15384
51639eac
PE
15385 * eval.c (Fautoload): Don't double-shift a pointer.
15386
92394119
PE
15387 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
15388
dbdb9a7c
JB
153892011-05-06 Juanma Barranquero <lekktu@gmail.com>
15390
15391 * gnutls.c (DEF_GNUTLS_FN):
15392 * image.c (DEF_IMGLIB_FN): Make function pointers static.
15393
db7a0b4f
AS
153942011-05-05 Andreas Schwab <schwab@linux-m68k.org>
15395
15396 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
15397 marker. (Bug#8610)
15398
cd394be1 153992011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
15400
15401 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
15402 New version that can reserve upto 2GB of heap space.
15403
f7ff1b0f 154042011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
15405
15406 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
15407
639c109b
TZ
154082011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
15409
15410 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
15411 `gnutls_certificate_set_x509_key_file'.
15412
d2127135
JB
154132011-05-05 Juanma Barranquero <lekktu@gmail.com>
15414
15415 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
15416 Update dependencies.
15417
e968f4f3
JB
154182011-05-04 Juanma Barranquero <lekktu@gmail.com>
15419
15420 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
15421 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
15422 Remove unused parameter `fildes'.
15423 * process.c (read_process_output, send_process): Don't pass it.
15424
84d358f0
JB
154252011-05-04 Juanma Barranquero <lekktu@gmail.com>
15426
15427 Fix previous change: the library cache is defined in w32.c.
15428 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
15429 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
15430
0898ca10
JB
154312011-05-04 Juanma Barranquero <lekktu@gmail.com>
15432
15433 Implement dynamic loading of GnuTLS on Windows.
15434
15435 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
15436 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
15437 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
15438 Declare.
15439
15440 * gnutls.c (Qgnutls_dll): Define.
15441 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
15442 (gnutls_*): Declare function pointers.
15443 (init_gnutls_functions): New function to initialize function pointers.
15444 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
15445 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
15446 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
15447 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
15448 (emacs_gnutls_write, emacs_gnutls_read)
15449 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
15450 (Fgnutls_available_p): New function.
15451 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
15452 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
15453 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
15454
15455 * image.c: Include w32.h.
15456 (Vimage_type_cache): Delete.
15457 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
15458 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
15459 (w32_delayed_load): Move to w32.c.
15460
15461 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
15462
15463 * w32.c (QCloaded_from, Vlibrary_cache): Define.
15464 (w32_delayed_load): Move from image.c. When loading a library, record
15465 its filename in the :loaded-from property of the library id.
15466 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
15467 Initialize and staticpro them.
15468 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
15469
15470 * process.c: Include lisp.h before w32.h, not after.
15471 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
15472 instead of gnutls_record_check_pending.
15473
15474 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
15475
ff4de4aa
TZ
154762011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
15477
15478 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
15479 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
15480 as passed in.
15481
abe95abb
JD
154822011-05-03 Jan Djärv <jan.h.d@swipnet.se>
15483
15484 * xterm.c (x_set_frame_alpha): Do not set property on anything
15485 else than FRAME_X_OUTER_WINDOW (Bug#8608).
15486
e16e55d4
JB
154872011-05-02 Juanma Barranquero <lekktu@gmail.com>
15488
15489 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
15490
bafcf6a5
JB
154912011-05-02 Juanma Barranquero <lekktu@gmail.com>
15492
15493 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
15494 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
15495 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
15496 (gnutls_global_initialized, Qgnutls_bootprop_priority)
15497 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
15498 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
15499 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
15500 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
15501 (Qgnutls_bootprop_callbacks_verify): Make static.
15502
e7a6747f
AS
155032011-05-01 Andreas Schwab <schwab@linux-m68k.org>
15504
19ed11ba
AS
15505 * callproc.c: Indentation fixup.
15506
e7a6747f 15507 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
15508 (wait_for_termination, interruptible_wait_for_termination):
15509 Move after wait_for_termination_1.
e7a6747f 15510
1ef14cb4
LMI
155112011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
15512
15513 * sysdep.c (interruptible_wait_for_termination): New function
15514 which is like wait_for_termination, but allows keyboard
15515 interruptions.
15516
15517 * callproc.c (Fcall_process): Add (:file "file") as an option for
15518 the STDOUT buffer.
15519 (Fcall_process_region): Ditto.
15520
330d880c
EZ
155212011-04-30 Eli Zaretskii <eliz@gnu.org>
15522
8db90b73
EZ
15523 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
15524 rather than `XVECTOR (FOO)->size'.
15525
330d880c
EZ
15526 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
15527 inttypes.h, as a gnulib replacement is used if it not available in
15528 system headers.
15529
15cbd324
EZ
155302011-04-21 Eli Zaretskii <eliz@gnu.org>
15531
15532 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
15533 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
15534 of MOST_POSITIVE_FIXNUM. (Bug#8528)
15535
15536 * coding.c (coding_alloc_by_realloc): Error out if destination
15537 will grow beyond MOST_POSITIVE_FIXNUM.
15538 (decode_coding_emacs_mule): Abort if there isn't enough place in
15539 charbuf for the composition carryover bytes. Reserve an extra
15540 space for up to 2 characters produced in a loop.
15541 (decode_coding_iso_2022): Abort if there isn't enough place in
15542 charbuf for the composition carryover bytes.
15543
155442011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 15545
ae940cca
EZ
15546 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
15547 aborting when %lld or %lll format is passed.
15548 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
15549 %llo or %llx format is passed. (Bug#8545)
15550
03ab8921
EZ
15551 * window.c (window_scroll_line_based): Use a marker instead of
15552 simple variables to record original value of point. (Bug#7952)
15553
afda1437
EZ
15554 * doprnt.c (doprnt): Fix the case where a multibyte sequence
15555 produced by %s or %c overflows available buffer space. (Bug#8545)
15556
f76dee0c
PE
155572011-04-28 Paul Eggert <eggert@cs.ucla.edu>
15558
15559 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 15560 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 15561
fdc5744d
JB
155622011-04-28 Juanma Barranquero <lekktu@gmail.com>
15563
15564 * w32.c (init_environment): Warn about defaulting HOME to C:\.
15565
638f053a
JB
155662011-04-28 Juanma Barranquero <lekktu@gmail.com>
15567
15568 * keyboard.c (Qdelayed_warnings_hook): Define.
15569 (command_loop_1): Run `delayed-warnings-hook'
15570 if Vdelayed_warnings_list is non-nil.
15571 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
15572 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
15573
d178f871
EZ
155742011-04-28 Eli Zaretskii <eliz@gnu.org>
15575
15576 * doprnt.c (doprnt): Don't return value smaller than the buffer
15577 size if the message was truncated. (Bug#8545).
15578
b124fd93
JB
155792011-04-28 Juanma Barranquero <lekktu@gmail.com>
15580
15581 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
15582 (Fx_window_property): #if-0 the whole functions, not just the bodies.
15583
e810457d
PE
155842011-04-27 Paul Eggert <eggert@cs.ucla.edu>
15585
15586 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
15587
ea51cceb
JB
155882011-04-27 Juanma Barranquero <lekktu@gmail.com>
15589
15590 * makefile.w32-in: Update dependencies.
15591
94dcfacf
EZ
155922011-04-27 Eli Zaretskii <eliz@gnu.org>
15593
15594 Improve `doprnt' and its usage. (Bug#8545)
15595 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
15596 `format_end'. Remove support for %l as a conversion specifier.
15597 Don't use xrealloc. Improve diagnostics when the %l size modifier
15598 is used. Update the commentary.
15599
15600 * eval.c (verror): Simplify calculation of size_t.
15601
15602 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
15603 messages.
15604
f61f41d7
PE
156052011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
15606
15607 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
15608 change.
15609
96fb4434
PE
156102011-04-27 Paul Eggert <eggert@cs.ucla.edu>
15611
15612 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
15613 This makes this file independent of the recent pseudovector change.
15614
671875da 156152011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 15616
69e9b5a3
PE
15617 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
15618
b5f869a7 15619 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 15620 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 15621 Remove unused local.
c8926152 15622 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 15623
841a1577 15624 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
15625 GCC 4.6.0 optimizes based on type-based alias analysis.
15626 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
15627 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
15628 != &v->size, and therefore "v->size = 1; b->size = 2; return
15629 v->size;" must therefore return 1. This assumption is incorrect
15630 for Emacs, since it type-puns struct Lisp_Vector * with many other
15631 types. To fix this problem, this patch adds a new type struct
f904488f 15632 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
15633 and pseudovectors, and helps optimizing compilers not get fooled
15634 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
15635 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
15636 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
15637 the size member.
eab3844f
PE
15638 (XSETPVECTYPE): Rewrite in terms of new macro.
15639 (XSETPVECTYPESIZE): New macro, specifying both type and size.
15640 This is a bit clearer, and further avoids the possibility of
15641 undesirable aliasing.
15642 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 15643 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
15644 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
15645 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
15646 (ASIZE): Now uses header.size rather than size.
15647 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
15648 to avoid the hassle of writing XVECTOR (foo)->header.size.
15649 (struct vectorlike_header): New type.
eab3844f
PE
15650 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
15651 object, to help avoid aliasing.
15652 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
15653 (SUBRP): Likewise, since Lisp_Subr is a special case.
15654 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
15655 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
15656 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 15657 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
15658 changed to be "header.size" and "header.next".
15659 * buffer.h (struct buffer): Likewise.
15660 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
15661 * frame.h (struct frame): Likewise.
15662 * process.h (struct Lisp_Process): Likewise.
15663 * termhooks.h (struct terminal): Likewise.
15664 * window.c (struct save_window_data, struct saved_window): Likewise.
15665 * window.h (struct window): Likewise.
15666 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
15667 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
15668 * buffer.c (init_buffer_once): Likewise.
15669 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
15670 special case.
15671 * process.c (Fformat_network_address): Use local var for size,
15672 for brevity.
15673
0df1eac5
PE
15674 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
15675
847ab9d1 15676 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
15677 * data.c (atof): Remove decl; no longer used or needed.
15678 (digit_to_number): Move to lread.c.
15679 (Fstring_to_number): Use new string_to_number function, to be
15680 consistent with how the Lisp reader treats infinities and NaNs.
15681 Do not assume that floating-point numbers represent EMACS_INT
15682 without losing information; this is not true on most 64-bit hosts.
15683 Avoid double-rounding errors, by insisting on integers when
15684 parsing non-base-10 numbers, as the documentation specifies.
15685 * lisp.h (string_to_number): New decl, replacing ...
15686 (isfloat_string): Remove.
bc0a5c13 15687 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 15688 (read1): Do not accept +. and -. as integers; this
452f4150
PE
15689 appears to have been a coding error. Similarly, do not accept
15690 strings like +-1e0 as floating point numbers. Do not report
15691 overflow for integer overflows unless the base is not 10 which
15692 means we have no simple and reliable way to continue.
15693 Break out the floating-point parsing into a new
15694 function string_to_number, so that Fstring_to_number parses
15695 floating point numbers consistently with the Lisp reader.
04f2d78b 15696 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
15697 (E_CHAR, EXP_INT): Remove, replacing with ...
15698 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
15699 (string_to_number): New function, replacing isfloat_string.
15700 This function checks for valid syntax and produces the resulting
15701 Lisp float number too. Rework it so that string-to-number
bc0a5c13 15702 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
15703 so that overflow for non-base-10 numbers is reported only when
15704 there's no portable and simple way to convert to floating point.
452f4150 15705
67769ffc
PE
15706 * textprop.c (set_text_properties_1): Rewrite for clarity,
15707 and to avoid GCC warning about integer overflow.
15708
c20db43f
PE
15709 * intervals.h (struct interval): Use EMACS_INT for members
15710 where EMACS_UINT might cause problems. See
15711 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
15712 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
15713 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
15714 All uses changed.
37aa2f85
PE
15715 (offset_intervals): Tell GCC not to worry about length overflow
15716 when negating a negative length.
c20db43f 15717
2538aa2f
PE
15718 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
15719 (overrun_check_free): Likewise.
15720
f2d3008d
PE
15721 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
15722 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
15723 word size.
15724
ec8df744
PE
15725 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
15726 (gnutls_make_error): Rename local to avoid shadowing.
15727 (gnutls_emacs_global_deinit): ifdef out; not used.
15728 (Fgnutls_boot): Use const for pointer to readonly storage.
15729 Comment out unused local. Fix pointer signedness problems.
15730
640ee02d
PE
15731 * lread.c (openp): Don't stuff size_t into an 'int'.
15732 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
15733 about possible signed overflow.
15734
6048fb2a
PE
15735 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
15736 (GDK_KEY_g): Don't define if already defined.
15737 (xg_prepare_tooltip): Avoid pointer signedness problem.
15738 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
15739
fa3c87e1
PE
15740 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
15741 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
15742
2172544b
PE
15743 * xfns.c (Fx_window_property): Simplify a bit,
15744 to make a bit faster and to avoid GCC 4.6.0 warning.
15745 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
15746
9b821a21
PE
15747 * fns.c (internal_equal): Don't assume size_t fits in int.
15748
3c616cfa
PE
15749 * alloc.c (compact_small_strings): Tighten assertion a little.
15750
c2982e87
PE
15751 Replace pEd with more-general pI, and fix some printf arg casts.
15752 * lisp.h (pI): New macro, generalizing old pEd macro to other
15753 conversion specifiers. For example, use "...%"pI"d..." rather
15754 than "...%"pEd"...".
15755 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 15756 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
15757 * alloc.c (check_pure_size): Don't overflow by converting size to int.
15758 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
15759 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
15760 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
15761 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
15762 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
15763 64-bit hosts.
15764 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
15765 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
15766 * print.c (safe_debug_print, print_object): Likewise.
15767 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
15768 to int.
6f04d126
PE
15769 Use pI instead of if-then-else-abort. Use %p to avoid casts,
15770 avoiding the 0 flag, which is not portable.
c2982e87
PE
15771 * process.c (Fmake_network_process): Use pI to avoid cast.
15772 * region-cache.c (pp_cache): Likewise.
15773 * xdisp.c (decode_mode_spec): Likewise.
15774 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
15775 behavior on 64-bit hosts with printf arg.
6f04d126 15776 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
15777 (x_stop_queuing_selection_requests): Likewise.
15778 (x_get_window_property): Don't truncate byte count to an 'int'
15779 when tracing.
0b432f21 15780
5e073ec7
PE
15781 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
15782 here, since it parses constructs like leading '-' and spaces,
15783 which are not wanted; and it overflows with large numbers.
15784 Instead, simply match F[0-9]+, which is what is wanted anyway.
15785
36372bf9
PE
15786 * alloc.c: Remove unportable assumptions about struct layout.
15787 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
15788 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
15789 (allocate_vectorlike, make_pure_vector): Use the new macros,
15790 plus offsetof, to remove unportable assumptions about struct layout.
15791 These assumptions hold on all porting targets that I know of, but
15792 they are not guaranteed, they're easy to remove, and removing them
15793 makes further changes easier.
15794
0b432f21
PE
15795 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
15796 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
15797 (string_overrun_cookie): Now const. Use initializers that
15798 don't formally overflow signed char, to avoid warnings.
000098c1
PE
15799 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
15800 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
15801 (allocate_buffer): Don't assume sizeof (struct buffer) is a
15802 multiple of sizeof (EMACS_INT); it need not be, if
15803 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 15804 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 15805
895009e1
JB
158062011-04-26 Juanma Barranquero <lekktu@gmail.com>
15807
15808 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
15809
6a7a1b0b
TZ
158102011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
15811
15812 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 15813 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
15814 Reported by Paul Eggert <eggert@cs.ucla.edu>.
15815
841a1577 158162011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
15817
15818 * lisp.h (Qdebug): List symbol.
895009e1 15819 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
15820 * keyboard.c (debug-on-event): New variable.
15821 (handle_user_signal): Break into debugger when debug-on-event
15822 matches the current signal symbol.
15823
f2d3ba6f
DN
158242011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
15825
15826 * alloc.c (check_sblock, check_string_bytes)
15827 (check_string_free_list): Convert to standard C.
15828
42ce4c63
TZ
158292011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
15830
15831 * w32.c (emacs_gnutls_push): Fix typo.
15832
825cd63c
EZ
158332011-04-25 Eli Zaretskii <eliz@gnu.org>
15834
fb11d64d
EZ
15835 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
15836 "cast to pointer from integer of different size".
15837
825cd63c
EZ
15838 Improve doprnt and its use in verror. (Bug#8545)
15839 * doprnt.c (doprnt): Document the set of format control sequences
15840 supported by the function. Use SAFE_ALLOCA instead of always
15841 using `alloca'.
15842
15843 * eval.c (verror): Don't limit the buffer size at size_max-1, that
15844 is one byte too soon. Don't use xrealloc; instead xfree and
15845 xmalloc anew.
15846
e061a11b
TZ
158472011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
15848
15849 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
15850 callbacks stage.
15851
15852 * gnutls.c: Renamed global_initialized to
15853 gnutls_global_initialized. Added internals for the
15854 :verify-hostname-error, :verify-error, and :verify-flags
15855 parameters of `gnutls-boot' and documented those parameters in the
15856 docstring. Start callback support.
9173deec
JB
15857 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
15858 unless a fatal error occurred. Call gnutls_alert_send_appropriate
15859 on error. Return error code.
e061a11b
TZ
15860 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
15861 (emacs_gnutls_read): Likewise.
15862 (Fgnutls_boot): Return handshake error code.
15863 (emacs_gnutls_handle_error): New function.
15864 (wsaerror_to_errno): Likewise.
15865
15866 * w32.h (emacs_gnutls_pull): Add prototype.
15867 (emacs_gnutls_push): Likewise.
15868
15869 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
15870 (emacs_gnutls_push): Likewise.
15871
158722011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
15873
15874 * process.c (wait_reading_process_output): Check if GnuTLS
15875 buffered some data internally if no FDs are set for TLS
15876 connections.
15877
15878 * makefile.w32-in (OBJ2): Add gnutls.$(O).
15879 (LIBS): Link to USER_LIBS.
15880 ($(BLD)/gnutls.$(0)): New target.
15881
fa6996bc
EZ
158822011-04-24 Eli Zaretskii <eliz@gnu.org>
15883
eb35682e
EZ
15884 * xdisp.c (handle_single_display_spec): Rename the
15885 display_replaced_before_p argument into display_replaced_p, to
15886 make it consistent with the commentary. Fix typos in the
15887 commentary.
15888
e2ad650c
EZ
15889 * textprop.c (syms_of_textprop): Remove dead code.
15890 (copy_text_properties): Delete obsolete commentary about an
15891 interface that was deleted long ago. Fix typos in the description
15892 of arguments.
15893
1b2de274
EZ
15894 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
15895 to changes in oldXMenu/XMenu.h from 2011-04-16.
15896 <menu_help_message, prev_menu_help_message>: Constify.
15897 (IT_menu_make_room): menu->help_text is now `const char **';
15898 adjust.
15899
15900 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
15901 to changes in oldXMenu/XMenu.h from 2011-04-16.
15902 (struct XMenu): Declare `help_text' `const char **'.
15903
15904 * xfaces.c <Qunspecified>: Make extern again.
15905
15906 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 15907 required by POSIX.
1b2de274 15908
762b15be
EZ
15909 * doc.c (get_doc_string): Improve the format passed to `error'.
15910
15911 * doprnt.c (doprnt): Improve commentary.
15912
15913 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
15914
15915 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
15916 them with etags.
15917
f1052e5d
EZ
15918 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
15919 changes in globals.h immediately force recompilation.
762b15be
EZ
15920 (TAGS): Depend on $(CURDIR)/m/intel386.h and
15921 $(CURDIR)/s/ms-w32.h.
15922 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 15923
fa6996bc
EZ
15924 * character.c (Fchar_direction): Function deleted.
15925 (syms_of_character): Don't defsubr it.
15926 <char-direction-table>: Deleted.
15927
e6c3da20
EZ
159282011-04-23 Eli Zaretskii <eliz@gnu.org>
15929
15930 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
15931 * doprnt.c: Include limits.h.
15932 (SIZE_MAX): New macro.
04f2d78b
CB
15933 (doprnt): Return a size_t value. 2nd arg is now size_t.
15934 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
15935 Improve overflow protection. Support `l' modifier for integer
15936 conversions. Support %l conversion. Don't assume an EMACS_INT
15937 argument for integer conversions and for %c.
15938
15939 * lisp.h (doprnt): Restore prototype.
15940
15941 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
15942 $(SRC)/character.h.
15943
15944 * Makefile.in (base_obj): Add back doprnt.o.
15945
15946 * deps.mk (doprnt.o): Add back prerequisites.
15947 (callint.o): Depend on character.h.
15948
15949 * eval.c (internal_lisp_condition_case): Include the handler
15950 representation in the error message.
15951 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
15952 when breaking from the loop.
15953
15954 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
15955
15956 * callint.c (Fcall_interactively): When displaying error message
15957 about invalid control letter, pass the character's codepoint, not
15958 a pointer to its multibyte form. Improve display of the character
15959 in octal and display also its hex code.
15960
15961 * character.c (char_string): Use %x to display the (unsigned)
15962 codepoint of an invalid character, to avoid displaying a bogus
15963 negative value.
15964
15965 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
15966 `error', not SYMBOL_NAME itself.
15967
15968 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
15969 character arguments to `error'.
15970
15971 * charset.c (check_iso_charset_parameter): Fix incorrect argument
15972 to `error' in error message about FINAL_CHAR argument. Make sure
15973 FINAL_CHAR is a character, and use %c when it is passed as
15974 argument to `error'.
15975
4ffd0d6b 159762011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
15977
15978 * s/ms-w32.h (localtime): Redirect to sys_localtime.
15979
15980 * w32.c: Include <time.h>.
15981 (sys_localtime): New function.
15982
4ffd0d6b 159832011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
15984
15985 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
15986
4ffd0d6b 15987 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 15988
4ffd0d6b 159892011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 15990
4ffd0d6b
GM
15991 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
15992 zombies (Bug#8467).
aac0c6e3 15993
04c56954
EZ
159942011-04-19 Eli Zaretskii <eliz@gnu.org>
15995
15996 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
15997 gl_state.e_property when gl_state.object is Qt.
15998
15999 * insdel.c (make_gap_larger): Remove limitation of buffer size
16000 to <= INT_MAX.
16001
16a43933
CY
160022011-04-18 Chong Yidong <cyd@stupidchicken.com>
16003
16004 * xdisp.c (lookup_glyphless_char_display)
16005 (produce_glyphless_glyph): Handle cons cell entry in
16006 glyphless-char-display.
16007 (Vglyphless_char_display): Document it.
16008
16009 * term.c (produce_glyphless_glyph): Handle cons cell entry in
16010 glyphless-char-display.
16011
4581706e
CY
160122011-04-17 Chong Yidong <cyd@stupidchicken.com>
16013
16014 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
16015
16016 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
16017
16018 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
16019 definition for no-X builds.
16020
4887c6e2 160212011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 16022
fd35b6f9
PE
16023 Static checks with GCC 4.6.0 and non-default toolkits.
16024
5c1ccb01
PE
16025 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
16026
006c5daa
PE
16027 * process.c (keyboard_bit_set): Define only if SIGIO.
16028 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
16029 (send_process): Repair possible setjmp clobbering.
16030
efc736d3
PE
16031 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
16032
4e2fe2e6
PE
16033 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
16034
f97334a2
PE
16035 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
16036
4e75f29d
PE
16037 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
16038 Define only if needed.
16039
90efadd1
PE
16040 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
16041 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 16042 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 16043
3c647824
PE
16044 * dispextern.h (struct redisplay_interface): Rename param
16045 to avoid shadowing.
e264f262 16046 * termhooks.h (struct terminal): Likewise.
761383f4 16047 * xterm.c (xembed_send_message): Likewise.
3c647824 16048
b58c5c4a
PE
16049 * insdel.c (make_gap_smaller): Define only if
16050 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
16051
cad59032
PE
16052 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
16053 it.
16054
c339dc2e
PE
16055 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
16056 so that we aren't warned about unused symbols.
16057
91a3e27b
PE
16058 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
16059
399c71d3 16060 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 16061
8ffc96f5
PE
16062 * xfns.c (x_real_positions): Mark locals as initialized.
16063
eef9bc79
PE
16064 * xmenu.c (xmenu_show): Don't use uninitialized vars.
16065
098db9dd
PE
16066 * xterm.c: Fix problems found by static analysis with other toolkits.
16067 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
16068 (x_dispatch_event): Declare static if USE_GTK, and
16069 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 16070 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 16071 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
16072 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
16073 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 16074
eb18f6cc
PE
16075 * xmenu.c (menu_help_callback): Pointer type fixes.
16076 Use const pointers when pointing at readonly data. Avoid pointer
16077 signedness clashes.
16078 (FALSE): Remove unused macro.
16079 (update_frame_menubar): Remove unused decl.
16080
1fe72bf8
PE
16081 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
16082
60d9e1db
PE
16083 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
16084 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
16085 (single_menu_item): Rename local to avoid shadowing.
16086
39261c26
PE
16087 * keyboard.c (make_lispy_event): Remove unused local var.
16088
018c5e19
PE
16089 * frame.c, frame.h (x_get_resource_string): Bring this back, but
16090 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
16091
63d2b86e
PE
16092 * bitmaps: Change bitmaps from unsigned char back to the X11
16093 compatible char. Avoid the old compiler warnings about
16094 out-of-range initializers by using, for example, '\xab' rather
16095 than 0xab.
16096
aefd87e1
PE
16097 * xgselect.c (xgselect_initialize): Check vs interface
16098 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
16099
bf501fb9
PE
16100 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
16101
e9829fdf
PE
16102 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
16103 to read-only memory.
16104
1086c095
PE
16105 * fns.c (vector): Remove; this old hack is no longer needed.
16106
2baccd04 16107 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 16108 Remove unused var.
dde42981 16109 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 16110
72391843 16111 * xrdb.c (x_load_resources): Omit unused local.
3565b346 16112
436c16df 16113 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 16114 (x_window): Rename locals to avoid shadowing.
dc5ddd85 16115 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 16116
92bb796d 16117 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 16118 (x_term_init): Remove local to avoid shadowing.
92bb796d 16119
764430a3 16120 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
16121
16122 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
16123 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
16124
d1dfb56c
EZ
161252011-04-16 Eli Zaretskii <eliz@gnu.org>
16126
c4354cb4
EZ
16127 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
16128
d1dfb56c
EZ
16129 Fix regex.c, syntax.c and friends for buffers > 2GB.
16130 * syntax.h (struct gl_state_s): Declare character position members
16131 EMACS_INT.
16132
16133 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
16134
04f2d78b
CB
16135 * textprop.c (verify_interval_modification, interval_of):
16136 Declare arguments EMACS_INT.
d1dfb56c
EZ
16137
16138 * intervals.c (adjust_intervals_for_insertion): Declare arguments
16139 EMACS_INT.
16140
16141 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
16142
16143 * indent.c (Fvertical_motion): Local variable it_start is now
16144 EMACS_INT.
16145
16146 * regex.c (re_match, re_match_2, re_match_2_internal)
16147 (bcmp_translate, regcomp, regexec, print_double_string)
16148 (group_in_compile_stack, re_search, re_search_2, regex_compile)
16149 (re_compile_pattern, re_exec): Declare arguments and local
16150 variables `size_t' and `ssize_t' and return values `regoff_t', as
16151 appropriate.
16152 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
16153 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
16154 <compile_stack_type>: `size' and `avail' are now `size_t'.
16155
16156 * regex.h <regoff_t>: Use ssize_t, not int.
16157 (re_search, re_search_2, re_match, re_match_2): Arguments that
16158 specify buffer/string position and length are now ssize_t and
16159 size_t. Return type is regoff_t.
16160
613052cd
BK
161612011-04-16 Ben Key <bkey76@gmail.com>
16162
16163 * nsfont.m: Fixed bugs in ns_get_family and
16164 ns_descriptor_to_entity that were caused by using free to
16165 deallocate memory blocks that were allocated by xmalloc (via
16166 xstrdup). This caused Emacs to crash when compiled with
16167 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
16168 --enable-checking=xmallocoverrun). xfree is now used to
16169 deallocate these memory blocks.
16170
4170f62f 161712011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 16172
71b41406
PE
16173 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
16174
9587a89d
PE
16175 emacs_write: Accept and return EMACS_INT for sizes.
16176 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
16177 et seq.
16178 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
16179 Accept and return EMACS_INT.
16180 (emacs_gnutls_write): Return the number of bytes written on
16181 partial writes.
16182 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
16183 (emacs_read, emacs_write): Remove check for negative size, as the
16184 Emacs source code has been audited now.
9587a89d
PE
16185 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
16186 (emacs_read, emacs_write): Use it.
273a5f82
PE
16187 * process.c (send_process): Adjust to the new signatures of
16188 emacs_write and emacs_gnutls_write. Do not attempt to store
16189 a byte offset into an 'int'; it might overflow.
9587a89d 16190 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 16191
3e047f51
PE
16192 * sound.c: Don't assume sizes fit in 'int'.
16193 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 16194 Return EMACS_INT, not int.
3e047f51 16195 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
16196 Accept EMACS_INT, not int.
16197 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
16198 record read return values.
16199
cc39a9db
BK
162002011-04-15 Ben Key <bkey76@gmail.com>
16201
c9d0ec6d
JB
16202 * keyboard.c (Qundefined): Don't declare static since it is used
16203 in nsfns.m.
16204 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
16205 static since they are used in nsfont.m.
cc39a9db 16206
6c60eb9f
SM
162072011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
16208
16209 * process.c (Qprocessp): Don't declare static.
16210 * lisp.h (Qprocessp): Declare again.
16211
7990b61a
JB
162122011-04-15 Juanma Barranquero <lekktu@gmail.com>
16213
16214 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
16215
5d4cb038
PE
162162011-04-14 Paul Eggert <eggert@cs.ucla.edu>
16217
8bd7b830 16218 Improve C-level modularity by making more things 'static'.
cd64ea1d 16219
e3b27b31
PE
16220 Don't publish debugger-only interfaces to other modules.
16221 * lisp.h (safe_debug_print, debug_output_compilation_hack):
16222 (verify_bytepos, count_markers): Move decls to the only modules
16223 that need them.
16224 * region-cache.h (pp_cache): Likewise.
16225 * window.h (check_all_windows): Likewise.
16226 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
16227
5d4cb038
PE
16228 * sysdep.c (croak): Now static, if
16229 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
16230 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
16231
16232 * alloc.c (refill_memory_reserve): Now static if
16233 !defined REL_ALLOC || defined SYSTEM_MALLOC.
16234 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 16235
e87b6180
PE
16236 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
16237 Define only if USE_LUCID.
16238
ac64929e
PE
16239 * xrdb.c (x_customization_string, x_rm_string): Now static.
16240
6f37259d
PE
16241 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
16242 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
16243
1683e3ab
PE
16244 * xdisp.c (draw_row_with_mouse_face): Now static.
16245 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
16246
de9c2632
PE
16247 * window.h (check_all_windows): Mark externally visible.
16248
2b96acb7
PE
16249 * window.c (window_deletion_count): Now static.
16250
16251 * undo.c: Make symbols static if they're not exported.
16252 (last_undo_buffer, last_boundary_position, pending_boundary):
16253 Now static.
16254
50436f33
PE
16255 * textprop.c (interval_insert_behind_hooks): Now static.
16256 (interval_insert_in_front_hooks): Likewise.
16257
64520e5c
PE
16258 * term.c: Make symbols static if they're not exported.
16259 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
16260 (max_frame_lines, tty_set_terminal_modes):
16261 (tty_reset_terminal_modes, tty_turn_off_highlight):
16262 (get_tty_terminal): Now static.
16263 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
16264 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 16265 HAVE_WINDOW_SYSTEM.
64520e5c
PE
16266 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
16267 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
16268
1fa53021
PE
16269 * sysdep.c: Make symbols static if they're not exported.
16270 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
16271 Now static.
16272 (sigprocmask_set, full_mask): Remove; unused.
16273 (wait_debugging): Mark as visible.
16274 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
16275 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
16276
d4b43b22
PE
16277 * syntax.c (syntax_temp): Define only if !__GNUC__.
16278
b7c513d0
PE
16279 * sound.c (current_sound_device, current_sound): Now static.
16280
989b29ad
PE
16281 * search.c (searchbufs, searchbuf_head): Now static.
16282
13a55a78
PE
16283 * scroll.c (scroll_cost): Remove; unused.
16284 * dispextern.h (scroll_cost): Remove decl.
16285
de68a1fc
PE
16286 * region-cache.h (pp_cache): Mark as externally visible.
16287
40ccffa6
PE
16288 * process.c: Make symbols static if they're not exported.
16289 (process_tick, update_tick, create_process, chan_process):
16290 (Vprocess_alist, proc_buffered_char, datagram_access):
16291 (fd_callback_data, send_process_frame, process_sent_to): Now static.
16292 (deactivate_process): Mark defn as static, as well as decl.
16293 * lisp.h (create_process): Remove decl.
16294 * process.h (chan_process, Vprocess_alist): Remove decls.
16295
ad64fc97
PE
16296 * print.c: Make symbols static if they're not exported.
16297 (print_depth, new_backquote_output, being_printed, print_buffer):
16298 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
16299 (print_interval, print_number_index, initial_stderr_stream):
16300 Now static.
16301 * lisp.h (Fprinc): Remove decl.
16302 (debug_output_compilation_hack): Mark as externally visible.
16303
adddb265
PE
16304 * sysdep.c (croak): Move decl from here to syssignal.h.
16305 * syssignal.h (croak): Put it here, so the API can be checked when
16306 'croak' is called from dissociate_if_controlling_tty.
16307
1717ede2
PE
16308 * minibuf.c: Make symbols static if they're not exported.
16309 (minibuf_save_list, choose_minibuf_frame): Now static.
16310 * lisp.h (choose_minibuf_frame): Remove decl.
16311
fa5fb2bc
PE
16312 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
16313
1e3890d1
PE
16314 * lread.c: Make symbols static if they're not exported.
16315 (read_objects, initial_obarray, oblookup_last_bucket_number):
16316 Now static.
16317 (make_symbol): Remove; unused.
16318 * lisp.h (initial_obarray, make_symbol): Remove decls.
16319
8a1414fa
PE
16320 * keyboard.c: Make symbols static if they're not exported.
16321 (single_kboard, recent_keys_index, total_keys, recent_keys):
16322 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
16323 (this_single_command_key_start, echoing, last_auto_save):
16324 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
16325 (command_loop, echo_now, keyboard_init_hook, help_char_p):
16326 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
16327 (Vlispy_mouse_stem, double_click_count):
16328 Now static.
16329 (force_auto_save_soon): Define only if SIGDANGER.
16330 (ignore_mouse_drag_p): Now static if
16331 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
16332 (print_help): Remove; unused.
16333 (stop_character, last_timer_event): Mark as externally visible.
16334 * keyboard.h (ignore_mouse_drag_p): Declare only if
16335 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
16336 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
16337 * lisp.h (echoing): Remove decl.
16338 (force_auto_save_soon): Declare only if SIGDANGER.
16339 * xdisp.c (redisplay_window): Simplify code, to make it more
16340 obvious that ignore_mouse_drag_p is not accessed if !defined
16341 USE_GTK && !defined HAVE_NS.
16342
93ea6e8f
PE
16343 * intervals.c: Make symbols static if they're not exported.
16344 (merge_properties_sticky, merge_interval_right, delete_interval):
16345 Now static.
16346 * intervals.h (merge_interval_right, delete_interval): Remove decls.
16347
77382fcc
PE
16348 * insdel.c: Make symbols static if they're not exported.
16349 However, leave prepare_to_modify_buffer alone. It's never
16350 called from outside this function, but that appears to be a bug.
16351 (combine_after_change_list, combine_after_change_buffer):
4889fc82 16352 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
16353 (adjust_after_replace_noundo): Remove; unused.
16354 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 16355 (signal_before_change): Remove decls.
77382fcc 16356
9306c32e
PE
16357 * indent.c (val_compute_motion, val_vmotion): Now static.
16358
cd44d2eb
PE
16359 * image.c: Make symbols static if they're not exported.
16360 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
16361 if USE_GTK.
16362 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
16363 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
16364
ad9a7a06
PE
16365 * fringe.c (standard_bitmaps): Now static.
16366 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
16367
81626931
PE
16368 * frame.c: Make symbols static if they're not exported.
16369 (x_report_frame_params, make_terminal_frame): Now static.
16370 (get_frame_param): Now static, unless HAVE_NS.
16371 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
16372 (x_get_resource_string): Remove; not used.
16373 * frame.h (make_terminal_frame, x_report_frame_params):
16374 (x_get_resource_string); Remove decls.
16375 (x_fullscreen_adjust): Declare only if WINDOWSNT.
16376 * lisp.h (get_frame_param): Declare only if HAVE_NS.
16377
239f9db9
PE
16378 * font.c, fontset.c: Make symbols static if they're not exported.
16379 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
16380 (FACE_SUITABLE_FOR_CHAR_P): Use it.
16381 * font.c (font_close_object): Now static.
16382 * font.h (font_close_object): Remove.
16383 * fontset.c (FONTSET_OBJLIST): Remove.
16384 (free_realized_fontset) #if-0 the body, which does nothing.
16385 (face_suitable_for_char_p): #if-0, as it's never called.
16386 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
16387 * xfaces.c (face_at_string_position):
16388 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
16389 since 0 is always ASCII.
16390
dfcf3579
PE
16391 * fns.c (weak_hash_tables): Now static.
16392
5045092b
PE
16393 * fileio.c: Make symbols static if they're not exported.
16394 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
16395 (Vwrite_region_annotation_buffers): Now static.
16396
57a96f5c
PE
16397 * eval.c: Make symbols static if they're not exported.
16398 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
16399 * lisp.h (backtrace_list): Remove decl.
16400
35f08c38
PE
16401 * emacs.c: Make symbols static if they're not exported.
16402 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
16403 (fatal_error_code, fatal_error_signal_hook, standard_args):
16404 Now static.
16405 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
16406 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
16407 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
16408 * lisp.h (fatal_error_signal_hook): Remove decl.
16409 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
16410
f44bd759
PE
16411 * editfns.c: Move a (normally-unused) function to its only use.
16412 * editfns.c, lisp.h (get_operating_system_release): Remove.
16413 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
16414 worth the hassle of breaking this out.
16415
b532497d
PE
16416 * xterm.c: Make symbols static if they're not exported.
16417 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
16418 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
16419 (x_destroy_window, x_delete_display):
16420 Now static.
16421 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
16422 (x_mouse_leave): Remove; unused.
16423 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
16424 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
16425 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
16426 Remove decls.
16427 (x_mouse_leave): Declare only if WINDOWSNT.
16428 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
16429 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
16430 USE_X_TOOLKIT.
16431
1675728f
PE
16432 * ftxfont.c: Make symbols static if they're not exported.
16433 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
16434 HAVE_FREETYPE.
16435 * font.h (ftxfont_driver): Likewise.
16436
e4cebfca
PE
16437 * xfns.c: Make symbols static if they're not exported.
16438 (x_last_font_name, x_display_info_for_name):
16439 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
16440 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
16441 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
16442 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
16443 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
16444 (last_show_tip_args): Now static.
16445 (xic_defaut_fontset, xic_create_fontsetname): Define only if
16446 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
16447 (x_screen_planes): Remove; unused.
16448 * dispextern.h (x_screen_planes): Remove decl.
16449
5bf46f05
PE
16450 * dispnew.c: Make symbols static if they're not exported.
16451 * dispextern.h (redraw_garbaged_frames, scrolling):
16452 (increment_row_positions): Remove.
16453 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
16454 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
16455 Now static.
16456 (redraw_garbaged_frames): Remove; unused.
16457
435f4c28
PE
16458 * xfaces.c: Make symbols static if they're not exported.
16459 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
16460 Remove decls.
16461 * xterm.h (defined_color): Remove decls.
16462 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
16463 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
16464 (menu_face_changed_default, defined_color, free_realized_face):
16465 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
16466 (ascii_face_of_lisp_face): Remove; unused.
16467
8524aef3
PE
16468 * xdisp.c: Make symbols static if they're not exported.
16469 * dispextern.h (scratch_glyph_row, window_box_edges):
16470 (glyph_to_pixel_coords, set_cursor_from_row):
16471 (get_next_display_element, set_iterator_to_next):
16472 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
16473 (show_mouse_face): Remove decls
16474 * frame.h (message_buf_print): Likewise.
16475 * lisp.h (pop_message, set_message, check_point_in_composition):
16476 Likewise.
16477 * xterm.h (set_vertical_scroll_bar): Likewise.
16478 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
16479 (message_buf_print, scratch_glyph_row, displayed_buffer):
16480 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
16481 (get_next_display_element, show_mouse_face, window_box_edges):
16482 (frame_to_window_pixel_xy, check_point_in_composition):
16483 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
16484 (glyph_to_pixel_coords): Remove; unused.
16485
16390cd2
PE
16486 * dired.c (file_name_completion): Now static.
16487
16488 * dbusbind.c (xd_in_read_queued_messages): Now static.
16489
a25f4dfa
PE
16490 * lisp.h (circular_list_error, FOREACH): Remove; unused.
16491 * data.c (circular_list_error): Remove.
16492
14a9c8df
PE
16493 * commands.h (last_point_position, last_point_position_buffer):
16494 (last_point_position_window): Remove decls.
16495 * keyboard.c: Make these variables static.
16496
04f2d78b
CB
16497 * coding.h (coding, code_convert_region, encode_coding_gap):
16498 Remove decls.
74ab6df5
PE
16499 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
16500 (iso_code_class, detect_coding, code_convert_region): Now static.
16501 (encode_coding_gap): Remove; unused.
16502
38dfbee1
PE
16503 * chartab.c (chartab_chars, chartab_bits): Now static.
16504
a2cb4e63
PE
16505 * charset.h (charset_iso_8859_1): Remove decl.
16506 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
16507 Now static.
16508
127198fd
PE
16509 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
16510 * ccl.c (Vccl_program_table): Now static.
16511 (check_ccl_update): Remove; unused.
16512
d85b608f
PE
16513 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
16514 * category.h: ... from here.
16515 * category.c (check_category_table, set_category_set): Now static.
16516
31cd66f3
PE
16517 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
16518 * lisp.h: Remove these decls.
16519
c358e587
PE
16520 * buffer.c (buffer_count): Remove unused var.
16521
e78aecca
PE
16522 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
16523 so that it's not optimized away.
16524 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
16525 * dispextern.h (bidi_dump_cached_states): Remove, since it's
16526 exported only to the debugger.
16527
e192d7d3 16528 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 16529 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 16530
92470028
PE
16531 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
16532 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
16533 was inaccessible from Lisp.
16534 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
16535 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
16536
244ed907
PE
16537 alloc.c: Import and export fewer symbols, and remove unused items.
16538 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
16539 is defined.
16540 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
16541 it's not optimized away by whole-program optimization.
16542 (message_enable_multibyte, free_misc): Remove.
16543 (catchlist, handlerlist, mark_backtrace):
16544 Declare only if BYTE_MARK_STACK.
16545 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
16546 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
16547 (message_enable_multibyte): Remove decl.
16548 (free_misc, interval_free_list, float_block, float_block_index):
16549 (n_float_blocks, float_free_list, cons_block, cons_block_index):
16550 (cons_free_list, last_marked_index):
16551 Now static.
16552 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
16553 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
16554 (mark_backtrace): Define only if BYTE_MARK_STACK.
16555 * xdisp.c (message_enable_multibyte): Now static.
16556
61c2b50e 16557 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
16558 This makes it easier for human readers (and static analyzers)
16559 to see whether these variables are used from other modules.
16560 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
16561 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
16562 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
16563 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
16564 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
16565 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
16566 * xmenu.c, xselect.c:
16567 Declare Q* vars static if they are not used in other modules.
16568 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
16569 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
16570 Remove decls of unexported vars.
16571 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
16572
95c82688
PE
16573 * lisp.h (DEFINE_FUNC): Make sname 'static'.
16574
16a97296
PE
16575 Make Emacs functions such as Fatom 'static' by default.
16576 This makes it easier for human readers (and static analyzers)
16577 to see whether these functions can be called from other modules.
16578 DEFUN now defines a static function. To make the function external
16579 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
16580 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
16581 (Finit_image_library):
16a97296
PE
16582 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
16583 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
16584 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
16585 Remove decls, since these functions are now static.
16586 (Funintern, Fget_internal_run_time): New decls, since these functions
16587 were already external.
95c82688 16588
16a97296
PE
16589 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
16590 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
16591 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
16592 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
16593 * keyboard.c, keymap.c, lread.c:
16594 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
16595 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
16596 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
16597 Mark functions with DEFUE instead of DEFUN,
16598 if they are used in other modules.
16599 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
16600 decls for now-static functions.
16601 * buffer.h (Fdelete_overlay): Remove decl.
16602 * callproc.c (Fgetenv_internal): Mark as internal.
16603 * composite.c (Fremove_list_of_text_properties): Remove decl.
16604 (Fcomposition_get_gstring): New forward static decl.
16605 * composite.h (Fcomposite_get_gstring): Remove decl.
16606 * dired.c (Ffile_attributes): New forward static decl.
16607 * doc.c (Fdocumntation_property): New forward static decl.
16608 * eval.c (Ffetch_bytecode): New forward static decl.
16609 (Funintern): Remove extern decl; now in .h file where it belongs.
16610 * fileio.c (Fmake_symbolic_link): New forward static decl.
16611 * image.c (Finit_image_library): New forward static decl.
16612 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
16613 * intervals.h (Fprevious_property_change):
16614 (Fremove_list_of_text_properties): Remove decls.
16615 * keyboard.c (Fthis_command_keys): Remove decl.
16616 (Fcommand_execute): New forward static decl.
16617 * keymap.c (Flookup_key): New forward static decl.
16618 (Fcopy_keymap): Now static.
16619 * keymap.h (Flookup_key): Remove decl.
16620 * process.c (Fget_process): New forward static decl.
16621 (Fprocess_datagram_address): Mark as internal.
16622 * syntax.c (Fsyntax_table_p): New forward static decl.
16623 (skip_chars): Remove duplicate decl.
16624 * textprop.c (Fprevious_property_change): New forward static decl.
16625 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
16626 Now internal.
16627 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
16628 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
16629
785bbd42
PE
16630 * editfns.c (Fformat): Remove unreachable code.
16631
8b913b57
AS
166322011-04-14 Andreas Schwab <schwab@linux-m68k.org>
16633
16634 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
16635 change. (Bug#8496)
16636
a6744a35
EZ
166372011-04-13 Eli Zaretskii <eliz@gnu.org>
16638
16639 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
16640 when at ZV. (Bug#8487)
16641
e7974947
AS
166422011-04-12 Andreas Schwab <schwab@linux-m68k.org>
16643
baad03f0
AS
16644 * charset.c (Fclear_charset_maps): Use xfree instead of free.
16645 (Bug#8437)
16646 * keyboard.c (parse_tool_bar_item): Likewise.
16647 * sound.c (sound_cleanup, alsa_close): Likewise.
16648 * termcap.c (tgetent): Likewise.
16649 * xfns.c (x_default_font_parameter): Likewise.
16650 * xsettings.c (read_and_apply_settings): Likewise.
16651
e7974947
AS
16652 * alloc.c (overrun_check_malloc, overrun_check_realloc)
16653 (overrun_check_free): Protoize.
16654
28272684
PE
166552011-04-12 Paul Eggert <eggert@cs.ucla.edu>
16656
16657 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
16658 since callers should never pass a negative size.
16659 Change the signature to match that of plain 'read' and 'write'; see
16660 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
16661 * lisp.h: Update prototypes of emacs_write and emacs_read.
16662
11997c76
EZ
166632011-04-11 Eli Zaretskii <eliz@gnu.org>
16664
16665 * xdisp.c (redisplay_window): Don't try to determine the character
16666 position of the scroll margin if the window start point w->startp
e896f03c 16667 is outside the buffer's accessible region. (Bug#8468)
11997c76 16668
8a2cbd72
EZ
166692011-04-10 Eli Zaretskii <eliz@gnu.org>
16670
16671 Fix write-region and its subroutines for buffers > 2GB.
16672 * fileio.c (a_write, e_write): Modify declaration of arguments and
16673 local variables to support buffers larger than 2GB.
16674 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
16675
16676 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
16677 argument, local variables, and return value.
16678
16679 * lisp.h: Update prototypes of emacs_write and emacs_read.
16680
16681 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
16682
4073e537 166832011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 16684
1ebfdcb6
PE
16685 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
16686
b2ded58d
PE
16687 Fix more problems found by GCC 4.6.0's static checks.
16688
7d66342c
PE
16689 * xdisp.c (vmessage): Use a better test for character truncation.
16690
bbf47d44
PE
16691 * charset.c (load_charset_map): <, not <=, for optimization,
16692 and to avoid potential problems with integer overflow.
9248994d 16693 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 16694 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 16695 * editfns.c (Fformat): Likewise.
1e69125e 16696 * syntax.c (skip_chars): Likewise.
3befa583 16697
e3019616
PE
16698 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
16699 This also lets GCC 4.6.0 generate slightly better loop code.
16700
becfa255
PE
16701 * callint.c (Fcall_interactively): <, not <=, for optimization.
16702 (Fcall_interactively): Count the number of arguments produced,
16703 not the number of arguments given. This is simpler and lets GCC
16704 4.6.0 generate slightly better code.
16705
dae0cd48
PE
16706 * ftfont.c: Distingish more carefully between FcChar8 and char.
16707 The previous code passed unsigned char * to a functions like
16708 strlen and xstrcasecmp that expect char *, which does not
16709 conform to the C standard.
16710 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
16711 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
16712 char * when the C standard requires it.
16713
76032d70
PE
16714 * keyboard.c (read_char): Remove unused var.
16715
eb3f1cc8
PE
16716 * eval.c: Port to Windows vsnprintf (Bug#8435).
16717 Include <limits.h>.
16718 (SIZE_MAX): Define if the headers do not.
16719 (verror): Do not give up if vsnprintf returns a negative count.
16720 Instead, grow the buffer. This ports to Windows vsnprintf, which
16721 does not conform to C99. Problem reported by Eli Zaretskii.
16722 Also, simplify the allocation scheme, by avoiding the need for
16723 calling realloc, and removing the ALLOCATED variable.
16724
70476b54
PE
16725 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
16726
12020a9e
PE
16727 Remove invocations of doprnt, as Emacs now uses vsnprintf.
16728 But keep the doprint source code for now, as we might revamp it
16729 and use it again (Bug#8435).
ea6c7ae6
PE
16730 * lisp.h (doprnt): Remove.
16731 * Makefile.in (base_obj): Remove doprnt.o.
16732 * deps.mk (doprnt.o): Remove.
16733
5fdb398c
PE
16734 error: Print 32- and 64-bit integers portably (Bug#8435).
16735 Without this change, on typical 64-bit hosts error ("...%d...", N)
16736 was used to print both 32- and 64-bit integers N, which relied on
16737 undefined behavior.
61bdb816 16738 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
16739 * lisp.h (error, verror): Mark as printf-like functions.
16740 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
16741 Report overflow in size calculations when allocating printf buffer.
16742 Do not truncate output string at its first null byte.
16743 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
16744 Truncate the output at a character boundary, since vsnprintf does not
16745 do that.
16746 * charset.c (check_iso_charset_parameter): Convert internal
16747 character to string before calling 'error', since %c now has the
16748 printf meaning.
16749 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
16750 overflow when computing char to be passed to 'error'. Do not
16751 pass Lisp_Object to 'error'; pass the integer instead.
16752 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
16753 formatted with plain %d.
16754
b189fa66
PE
16755 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
16756
bff87ef0
PE
16757 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
16758
7e2cac20
PE
16759 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
16760
ce4d90b5
PE
16761 * xterm.c (x_catch_errors): Remove duplicate declaration.
16762
266c9547
PE
16763 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
16764
79c49ad2
PE
16765 * xdisp.c, lisp.h (message_nolog): Remove; unused.
16766
368f4090
JM
167672011-04-10 Jim Meyering <meyering@redhat.com>
16768
16769 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
16770 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
16771 return ssize_t not "int", and use size_t as the buffer length.
16772 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
16773 * gnutls.h: Update declarations.
16774 * process.c (read_process_output): Use ssize_t, to match.
16775 (send_process): Likewise.
16776
a32d4040
CY
167772011-04-09 Chong Yidong <cyd@stupidchicken.com>
16778
16779 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
16780
8546720e 167812011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 16782
04f2d78b
CB
16783 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
16784 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 16785
8546720e
GM
16786 * xterm.c (handle_one_xevent):
16787 * xmenu.c (create_and_show_popup_menu):
16788 * xselect.c (x_decline_selection_request)
16789 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 16790
0a2f5c1a 167912011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
16792
16793 Fix some uses of `int' instead of EMACS_INT.
16794 * search.c (string_match_1, fast_string_match)
16795 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
16796 (scan_buffer, find_next_newline_no_quit)
16797 (find_before_next_newline, search_command, Freplace_match)
16798 (Fmatch_data): Make some `int' variables be EMACS_INT.
16799
16800 * xdisp.c (display_count_lines): 3rd argument and return value now
16801 EMACS_INT. All callers changed.
16802 (pint2hrstr): Last argument is now EMACS_INT.
16803
16804 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
16805 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
16806 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
16807 (decode_coding_utf_16, decode_coding_emacs_mule)
16808 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
16809 (decode_coding_ccl, decode_coding_charset)
16810 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
16811 (decode_coding_iso_2022, decode_coding_emacs_mule)
16812 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
16813 <char_offset, last_offset>: Declare EMACS_INT.
16814 (encode_coding_utf_8, encode_coding_utf_16)
16815 (encode_coding_emacs_mule, encode_invocation_designation)
16816 (encode_designation_at_bol, encode_coding_iso_2022)
16817 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
16818 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
16819 Declare EMACS_INT.
16820 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
16821 (encode_invocation_designation): Last argument P_NCHARS is now
16822 EMACS_INT.
16823 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
16824 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
16825
16826 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
16827 All users changed.
16828
16829 * ccl.c (Fccl_execute_on_string): Declare some variables
16830 EMACS_INT.
16831
8546720e 168322011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
16833
16834 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
16835
4e19a977
CS
168362011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
16837
16838 * process.c (Fformat_network_address): Doc fix.
16839
87302331
R
168402011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
16841
ee7683eb 16842 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 16843
cbb59342
CY
168442011-04-08 Chong Yidong <cyd@stupidchicken.com>
16845
16846 * keyboard.c (read_char): Call Lisp function help-form-show,
16847 instead of using internal_with_output_to_temp_buffer.
16848 (Qhelp_form_show): New var.
e0d38eeb 16849 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
16850
16851 * print.c (internal_with_output_to_temp_buffer): Function deleted.
16852
16853 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
16854
e67a13ab
CY
168552011-04-06 Chong Yidong <cyd@stupidchicken.com>
16856
04f2d78b
CB
16857 * process.c (Flist_processes): Remove to Lisp.
16858 (list_processes_1): Delete.
e67a13ab 16859
973f782d
EZ
168602011-04-06 Eli Zaretskii <eliz@gnu.org>
16861
7c106b1e
EZ
16862 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
16863
973f782d
EZ
16864 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
16865
41cf7d1a 168662011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 16867
ca23cc88
PE
16868 Fix more problems found by GCC 4.6.0's static checks.
16869
f390e2d5
PE
16870 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
16871
42eea0d0
PE
16872 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
16873
b69769da 16874 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 16875
f9541e84
PE
16876 * xdisp.c (vmessage): Mark as a printf-like function.
16877
13841b55
PE
16878 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
16879
c136c10f
PE
16880 * sound.c (sound_warning): Don't crash if arg contains a printf format.
16881
5e2d4a30
PE
16882 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
16883 printf-like functions.
16884 (tiff_load): Add casts to remove these marks before passing them
16885 to system-supplied API.
16886
583f48b9
PE
16887 * eval.c (Fsignal): Remove excess argument to 'fatal'.
16888
b25d760e
PE
16889 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
16890 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
16891 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
16892 directly, rather than having caller test rule sign. This avoids
16893 some unnecessary tests.
16894 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
16895 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
16896 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 16897
bc7b6697 16898 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 16899 (xfont_open): Avoid unnecessary tests.
bc7b6697 16900
27ccc379
PE
16901 * composite.c (composition_gstring_put_cache): Use unsigned integer.
16902
dcd5c89a
PE
16903 * composite.h, composite.c (composition_gstring_put_cache):
16904 Use EMACS_INT, not int, for length.
16905
b13a45c6
PE
16906 * composite.h (COMPOSITION_DECODE_REFS): New macro,
16907 breaking out part of COMPOSITION_DECODE_RULE.
16908 (COMPOSITION_DECODE_RULE): Use it.
16909 * composite.c (get_composition_id): Remove unused local vars,
16910 by using the new macro.
16911
1e792e4d
PE
16912 * textprop.c (set_text_properties_1): Change while to do-while,
16913 since the condition is always true at first.
16914
dc6c6455 16915 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
16916 (interval_deletion_adjustment): Return unsigned value.
16917 All uses changed.
dc6c6455 16918
aba7731a
PE
16919 * process.c (list_processes_1, create_pty, read_process_output):
16920 (exec_sentinel): Remove vars that were set but not used.
afd4052b 16921 (create_pty): Remove unnecessary "volatile"s.
bc57d757 16922 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 16923 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 16924 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 16925
fdfc4bf3
PE
16926 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
16927
fca8fe46 16928 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 16929 (update_syntax_table): Use unsigned instead of int.
fca8fe46 16930
06a0259a 16931 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 16932 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 16933 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 16934
e7b9e80f
PE
16935 * print.c (print_error_message): Avoid int overflow.
16936
56201685
PE
16937 * font.c (font_list_entities): Redo for clarity,
16938 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
16939
78834453 16940 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 16941 (font_score): Avoid potential overflow in diff calculation.
78834453 16942
0bc0b309 16943 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 16944 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 16945
e610eaca
PE
16946 * eval.c (funcall_lambda): Rename local to avoid shadowing.
16947
b895abce
PE
16948 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
16949 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
16950 can always succeed if overflow has undefined behavior.
16951
1f1d9321 16952 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 16953 (wordify): Omit three unnecessary tests.
1f1d9321 16954
c59478bc
PE
16955 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
16956 All callers changed. This avoids the need for an unused var.
16957
79b73827
PE
16958 * casefiddle.c (casify_region): Remove var that is set but not used.
16959
a4db5dfe
PE
16960 * dired.c (file_name_completion): Remove var that is set but not used.
16961
43aae36e
PE
16962 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
16963
2a47c44d 16964 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 16965 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 16966
a37c69bf
PE
16967 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
16968 Check for integer overflow on size calculations.
16969
328ab8e7
PE
16970 * buffer.c (Fprevious_overlay_change): Remove var that is set
16971 but not used.
16972
e5a2a5cb
PE
16973 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
16974 Remove vars that are set but not used.
8d84a6eb 16975 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 16976 (timer_check_2): Mark vars as initialized.
e5a2a5cb 16977
a60e5f68
PE
16978 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
16979
f661cb61 16980 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 16981 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 16982
f0397f5a
PE
16983 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
16984 that are set but not used.
16985
8664db06 16986 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 16987 if XCreateBitmapFromData fails (Bug#8410).
8664db06 16988
6abdaa4a
PE
16989 * xselect.c (x_get_local_selection, x_handle_property_notify):
16990 Remove vars that are set but not used.
16991
0ce7538d 16992 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 16993 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 16994
9ae848fc
PE
16995 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
16996 Remove var that is set but not used.
0b918413
PE
16997 (scroll_bar_windows_size): Now size_t, not int.
16998 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
16999 Check for overflow.
9ae848fc 17000
a5a62657
PE
17001 * xfaces.c (realize_named_face): Remove vars that are set but not used.
17002 (map_tty_color) [!defined MSDOS]: Likewise.
17003
5c5cdd39
PE
17004 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
17005
66ebf983
PE
17006 * coding.c: Remove vars that are set but not used.
17007 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
17008 All callers changed.
17009 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
17010 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
17011 (decode_coding_charset): Remove vars that are set but not used.
17012
1be4d761
PE
17013 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
17014 that is set but not used.
17015
47553fa8
PE
17016 * print.c (print_object): Remove var that is set but not used.
17017
1f7196bf 17018 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
17019 The gnulib version avoids calling malloc in the usual case,
17020 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
17021 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
17022 * filelock.c (current_lock_owner): Likewise.
17023 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
17024 * sysdep.c: Include allocator.h, careadlinkat.h.
17025 (emacs_no_realloc_allocator): New static constant.
17026 (emacs_readlink): New function.
fdb61804
PE
17027 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
17028 ../lib/careadlinkat.h.
d1fdcab7 17029
f84c17c7
SM
170302011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
17031
17032 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
17033 first non-nil return value).
17034
ef3862ad
JD
170352011-04-03 Jan Djärv <jan.h.d@swipnet.se>
17036
17037 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
17038 if not defined (Bug#8403).
17039
376a7006
JB
170402011-04-02 Juanma Barranquero <lekktu@gmail.com>
17041
17042 * xdisp.c (display_count_lines): Remove parameter `start',
17043 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
17044 (get_char_face_and_encoding): Remove parameter `multibyte_p',
17045 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
17046 (fill_stretch_glyph_string): Remove parameters `row' and `area',
17047 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
17048 and thereabouts. All callers changed.
17049 (get_per_char_metric): Remove parameter `f', unused since
17050 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
17051
6ca3801d
JM
170522011-04-02 Jim Meyering <meyering@redhat.com>
17053
17054 do not dereference NULL upon failed strdup
17055 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
17056 (ns_get_family): Likewise.
17057
d8e2b5ba
JB
170582011-04-02 Juanma Barranquero <lekktu@gmail.com>
17059
17060 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
17061
8c74fcbd
JD
170622011-04-02 Jan Djärv <jan.h.d@swipnet.se>
17063
17064 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
17065 later (Bug#8403).
17066
7200d79c
SM
170672011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
17068
03408648 17069 Add lexical binding.
7200d79c 17070
03408648
SM
17071 * window.c (Ftemp_output_buffer_show): New fun.
17072 (Fsave_window_excursion):
17073 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
17074
17075 * lread.c (lisp_file_lexically_bound_p): New function.
17076 (Fload): Bind Qlexical_binding.
17077 (readevalloop): Remove `evalfun' arg.
17078 Bind Qinternal_interpreter_environment.
17079 (Feval_buffer): Bind Qlexical_binding.
17080 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
17081 Mark as dynamic.
17082 (syms_of_lread): Declare `lexical-binding'.
17083
17084 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
17085
17086 * keyboard.c (eval_dyn): New fun.
17087 (menu_item_eval_property): Use it.
ca105506
SM
17088
17089 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 17090
03408648
SM
17091 * fns.c (concat, mapcar1): Accept byte-code-functions.
17092
17093 * eval.c (Fsetq): Handle lexical vars.
17094 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
17095 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
17096 (FletX, Flet): Obey lexical binding.
17097 (Fcommandp): Handle closures.
17098 (Feval): New `lexical' arg.
17099 (eval_sub): New function extracted from Feval. Use it almost
17100 everywhere where Feval was used. Look up vars in lexical env.
17101 Handle closures.
17102 (Ffunctionp): Move from subr.el.
17103 (Ffuncall): Handle closures.
17104 (apply_lambda): Remove `eval_flags'.
17105 (funcall_lambda): Handle closures and new byte-code-functions.
17106 (Fspecial_variable_p): New function.
17107 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
17108 but without exporting it to Lisp.
23aba0ea 17109
23aba0ea 17110 * doc.c (Fdocumentation, store_function_docstring):
03408648 17111 * data.c (Finteractive_form): Handle closures.
23aba0ea 17112
03408648
SM
17113 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
17114 interactive spec.
ba83908c 17115
04f2d78b
CB
17116 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
17117 New byte-codes.
03408648
SM
17118 (exec_byte_code): New function extracted from Fbyte_code to handle new
17119 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 17120
03408648 17121 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 17122
03408648 17123 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 17124
e2abce01
JB
171252011-03-31 Juanma Barranquero <lekktu@gmail.com>
17126
17127 * xdisp.c (redisplay_internal): Fix prototype.
17128
63696a73 171292011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 17130
63696a73 17131 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
17132 (try_scrolling): Use it when setting scroll_limit.
17133 Limit scrolling to 100 screen lines.
63696a73
EZ
17134 (redisplay_window): Even when falling back on "recentering",
17135 position point in the window according to scroll-conservatively,
17136 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
17137
17138 (try_scrolling): When point is above the window, allow searching
17139 as far as scroll_max, or one screenful, to compute vertical
17140 distance from PT to the scroll margin position. This prevents
17141 try_scrolling from unnecessarily failing when
17142 scroll-conservatively is set to a value slightly larger than the
17143 window height. Clean up the case of PT below the margin at bottom
17144 of window: scroll_max can no longer be INT_MAX. When aggressive
17145 scrolling is in use, don't let point enter the opposite scroll
17146 margin as result of the scroll.
17147 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
17148 threshold of 100 lines for never-recentering scrolling.
17149
e4cc2dfc
JB
171502011-03-31 Juanma Barranquero <lekktu@gmail.com>
17151
17152 * dispextern.h (move_it_by_lines):
17153 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
17154 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
17155 (message_log_check_duplicate): Remove parameters `prev_bol' and
17156 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
17157 (redisplay_internal): Remove parameter `preserve_echo_area',
17158 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
17159
17160 * indent.c (Fvertical_motion):
17161 * window.c (window_scroll_pixel_based, Frecenter):
17162 Don't pass `need_y_p' to `move_it_by_lines'.
17163
1c470562
SM
171642011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
17165
44f230aa
SM
17166 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
17167 steal a few bits to be more compact.
17168 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
17169 Remove unneeded casts.
17170
1c470562
SM
17171 * bytecode.c (Fbyte_code): CAR and CDR can GC.
17172
888adce9
ZK
171732011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
17174
17175 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
17176 binding" message (bug#7967).
17177
f838ed7b
PE
171782011-03-30 Paul Eggert <eggert@cs.ucla.edu>
17179
77861b95
PE
17180 Fix more problems found by GCC 4.6.0's static checks.
17181
de6dbc14
PE
17182 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
17183 Remove unused local var.
17184
f838ed7b
PE
17185 * editfns.c (Fmessage_box): Remove unused local var.
17186
792c7b2b
PE
17187 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
17188 (note_mode_line_or_margin_highlight, note_mouse_highlight):
17189 Omit unused local vars.
c499e557 17190 * window.c (shrink_windows): Omit unused local var.
b01a1c29 17191 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
17192 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
17193 Omit unused local var.
17194
ba0165e1
PE
17195 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
17196 Don't assume string length fits in int.
32ad8845 17197 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 17198 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 17199
3c59b4c9
PE
17200 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
17201 instead of alloca (Bug#8344).
17202
a3eed478 17203 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 17204 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 17205
eb4d412d
PE
17206 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
17207
1658b401
PE
17208 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
17209 concerns.
17210
17211 * term.c (produce_glyphless_glyph): Remove unnecessary test.
17212
17213 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 17214
9a2c6e05
PE
17215 * keyboard.c (syms_of_keyboard): Use the same style as later
17216 in this function when indexing through an array. This also
17217 works around GCC bug 48267.
17218
03d0a109
PE
17219 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
17220
44f730c8
PE
17221 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
17222
fe75f926
PE
17223 * chartab.c (sub_char_table_ref_and_range): Redo for slight
17224 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
17225
ffa8c828
PE
17226 * keyboard.c, keyboard.h (num_input_events): Now size_t.
17227 This avoids undefined behavior on integer overflow, and is a bit
17228 more convenient anyway since it is compared to a size_t variable.
17229
c5101a77
PE
17230 Variadic C functions now count arguments with size_t, not int.
17231 This avoids an unnecessary limitation on 64-bit machines, which
17232 caused (substring ...) to crash on large vectors (Bug#8344).
17233 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
17234 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 17235 All variadic functions and their callers changed accordingly.
c5101a77
PE
17236 (struct gcpro.nvars): Now size_t, not int. All uses changed.
17237 * data.c (arith_driver, float_arith_driver): Likewise.
17238 * editfns.c (general_insert_function): Likewise.
17239 * eval.c (struct backtrace.nargs, interactive_p)
17240 (internal_condition_case_n, run_hook_with_args, apply_lambda)
17241 (funcall_lambda, mark_backtrace): Likewise.
17242 * fns.c (concat): Likewise.
17243 * frame.c (x_set_frame_parameters): Likewise.
17244 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
17245 0 if not found, not -1. All callers changed.
17246
dd3f25f7
PE
17247 * alloc.c (garbage_collect): Don't assume stack size fits in int.
17248 (stack_copy_size): Now size_t, not int.
17249 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
17250
461c2ab9
JB
172512011-03-28 Juanma Barranquero <lekktu@gmail.com>
17252
17253 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
17254 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
17255 All callers changed.
17256
17257 * lisp.h (multibyte_char_to_unibyte):
17258 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
17259 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
17260 * character.h (CHAR_TO_BYTE8):
17261 * cmds.c (internal_self_insert):
17262 * editfns.c (general_insert_function):
17263 * keymap.c (push_key_description):
17264 * search.c (Freplace_match):
17265 * xdisp.c (message_dolog, set_message_1): All callers changed.
17266
f6d62986
SM
172672011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
17268
17269 * keyboard.c (safe_run_hook_funcall): New function.
17270 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
17271 don't set the hook to nil, but remove the offending function instead.
17272 (Qcommand_hook_internal): Remove, unused.
17273 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
17274 Vcommand_hook_internal.
17275
17276 * eval.c (enum run_hooks_condition): Remove.
17277 (funcall_nil, funcall_not): New functions.
17278 (run_hook_with_args): Call each function through a `funcall' argument.
17279 Remove `cond' argument, now redundant.
17280 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
17281 (Frun_hook_with_args_until_failure): Adjust accordingly.
17282 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
17283
1db5b1ad
JB
172842011-03-28 Juanma Barranquero <lekktu@gmail.com>
17285
17286 * dispextern.h (string_buffer_position): Remove declaration.
17287
17288 * print.c (strout): Remove parameter `multibyte', unused since
17289 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
17290
17291 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
17292 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
17293 All callers changed.
17294
17295 * w32.c (_wsa_errlist): Use braces for struct initializers.
17296
17297 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
17298 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
17299 All callers changed.
17300 (string_buffer_position): Likewise. Also, make static (it's never
17301 used outside xdisp.c).
17302 (cursor_row_p): Remove parameter `w', unused since
17303 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
17304 (decode_mode_spec): Remove parameter `precision', introduced during
17305 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
17306 All callers changed.
17307
5ffb62aa
JD
173082011-03-27 Jan Djärv <jan.h.d@swipnet.se>
17309
17310 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
17311
461c2ab9 173122011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
17313
17314 * nsterm.m (ns_menu_bar_is_hidden): New variable.
17315 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
17316 (ns_update_auto_hide_menu_bar): New functions.
17317 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
17318 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
17319 ns_constrain_all_frames.
17320 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
17321 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
17322
5c380ffb
JD
173232011-03-27 Jan Djärv <jan.h.d@swipnet.se>
17324
17325 * nsmenu.m (runDialogAt): Remove argument to timer_check.
17326
9af30bdf
GM
173272011-03-27 Glenn Morris <rgm@gnu.org>
17328
17329 * syssignal.h: Replace RETSIGTYPE with void.
17330 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
17331 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
17332 Replace SIGTYPE with void everywhere.
17333 * s/usg5-4-common.h (SIGTYPE): Remove definition.
17334 * s/template.h (SIGTYPE): Remove commented out definition.
17335
e2abce01
JB
173362011-03-26 Eli Zaretskii <eliz@gnu.org>
17337
17338 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
17339 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
17340
f868cd8a
JB
173412011-03-26 Juanma Barranquero <lekktu@gmail.com>
17342
59eb0929
JB
17343 * w32.c (read_unc_volume): Use parameter `henum', instead of
17344 global variable `wget_enum_handle'.
17345
17346 * keymap.c (describe_vector): Remove parameters `indices' and
17347 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
17348 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
17349
f868cd8a
JB
17350 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
17351
17352 * keyboard.c (timer_check): Remove parameter `do_it_now',
17353 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
17354 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
17355 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
17356
17357 * keyboard.c (read_char):
17358 * w32menu.c (w32_menu_display_help):
17359 * xmenu.c (show_help_event, menu_help_callback):
17360 Adjust calls to `show_help_echo'.
17361
17362 * gtkutil.c (xg_maybe_add_timer):
17363 * keyboard.c (readable_events):
17364 * process.c (wait_reading_process_output):
17365 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
17366
17367 * insdel.c (adjust_markers_gap_motion):
17368 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
17369 (gap_left, gap_right): Don't call it.
17370
2ecf6fdb
CY
173712011-03-25 Chong Yidong <cyd@stupidchicken.com>
17372
17373 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
17374 incurred during fontification.
17375
6b1f9ba4
JB
173762011-03-25 Juanma Barranquero <lekktu@gmail.com>
17377
17378 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
17379 (DEFVAR_PER_BUFFER): Don't pass it.
17380
17381 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
17382 (scrolling_window): Don't pass it.
17383
0f4a96b5
JB
173842011-03-25 Juanma Barranquero <lekktu@gmail.com>
17385
17386 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
17387
17388 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
17389 and `suffix'.
17390 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
17391 of variables specific to SELinux and computation of `encoded_absname'.
17392
17393 * image.c (XPutPixel): Remove unused variable `height'.
17394
17395 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
17396
17397 * unexw32.c (get_section_info): Remove unused variable `section'.
17398
17399 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
17400 (system_process_attributes): Remove unused variable `sess'.
17401 (sys_read): Remove unused variable `err'.
17402
17403 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
17404 (w32_wnd_proc): Remove unused variable `isdead'.
17405 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
17406 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
17407 (x_create_tip_frame): Remove unused variable `tem'.
17408
17409 * w32inevt.c (w32_console_read_socket):
17410 Remove unused variable `no_events'.
17411
17412 * w32term.c (x_draw_composite_glyph_string_foreground):
17413 Remove unused variable `width'.
17414
1149507c
JB
174152011-03-24 Juanma Barranquero <lekktu@gmail.com>
17416
17417 * w32term.c (x_set_glyph_string_clipping):
17418 Don't pass uninitialized region to CombineRgn.
17419
9c88f339
JB
174202011-03-23 Juanma Barranquero <lekktu@gmail.com>
17421
17422 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
17423 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
17424 (Fx_close_connection): Remove unused variable `i'.
17425
17426 * w32font.c (w32font_draw): Return number of glyphs.
17427 (w32font_open_internal): Remove unused variable `i'.
17428 (w32font_driver): Add missing initializer.
17429
17430 * w32menu.c (utf8to16): Remove unused variable `utf16'.
17431 (fill_in_menu): Remove unused variable `items_added'.
17432
17433 * w32term.c (last_mouse_press_frame): Remove static global variable.
17434 (w32_clip_to_row): Remove unused variable `f'.
17435 (x_delete_terminal): Remove unused variable `i'.
17436
17437 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
17438 (NOTHING): Remove unused static global variable.
17439 (uniscribe_check_otf): Remove unused variable `table'.
17440 (uniscribe_font_driver): Add missing initializers.
17441
dee091a3
JD
174422011-03-23 Julien Danjou <julien@danjou.info>
17443
17444 * term.c (Fsuspend_tty, Fresume_tty):
17445 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
17446 * window.c (temp_output_buffer_show):
17447 * insdel.c (signal_before_change):
17448 * frame.c (Fhandle_switch_frame):
17449 * fileio.c (Fdo_auto_save):
17450 * emacs.c (Fkill_emacs):
17451 * editfns.c (save_excursion_restore):
17452 * cmds.c (internal_self_insert):
17453 * callint.c (Fcall_interactively):
17454 * buffer.c (Fkill_all_local_variables):
17455 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
17456 Use Frun_hooks.
0f4a96b5 17457 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 17458 unconditionally since it does the check itself.
dee091a3 17459
2c520ab5 174602011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 17461
c9c49752
PE
17462 Fix more problems found by GCC 4.5.2's static checks.
17463
8abc3f12
PE
17464 * coding.c (encode_coding_raw_text): Avoid unnecessary test
17465 the first time through the loop, since we know p0 < p1 then.
17466 This also avoids a gcc -Wstrict-overflow warning.
17467
a2d26660
PE
17468 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
17469 leading to a memory leak, possible in functions like
17470 load_charset_map_from_file that can allocate an unbounded number
b12ef411 17471 of objects (Bug#8318).
a2d26660 17472
916c72e9
PE
17473 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
17474 that could (at least in theory) be that large.
17475
19ab8a18
PE
17476 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
17477 This is less likely to overflow, and avoids undefined behavior if
17478 overflow does occur. All callers changed. Use strtoul to scan
17479 for the unsigned long integer.
b7cbbd6f
PE
17480 (pint2hrstr): Simplify and tune code slightly.
17481 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 17482
f0641eff
PE
17483 * scroll.c (do_scrolling): Work around GCC bug 48228.
17484 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
17485
7f650bb9
PE
17486 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
17487 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
17488 (validate_x_resource_name): Simplify count usage.
17489 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 17490
37dd57d1
PE
17491 * fileio.c (Fcopy_file): Report error if fchown or fchmod
17492 fail (Bug#8306).
81e56e61 17493
699979fc 17494 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 17495
401bf9b4
PE
17496 * process.c (Fmake_network_process): Use socklen_t, not int,
17497 where POSIX says socklen_t is required in portable programs.
17498 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 17499 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
17500 (Fmake_network_process, server_accept_connection):
17501 (wait_reading_process_output, read_process_output):
17502 Likewise.
17503
b93aacde
PE
17504 * process.c: Rename or move locals to avoid shadowing.
17505 (list_processes_1, Fmake_network_process):
17506 (read_process_output_error_handler, exec_sentinel_error_handler):
17507 Rename or move locals.
4dc343ee 17508 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 17509 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 17510 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 17511 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 17512 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 17513
af8a867c 17514 Make tparam.h and terminfo.c consistent.
44f230aa
SM
17515 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
17516 Include tparam.h instead, since it declares them.
af8a867c
PE
17517 * cm.h (PC): Remove extern decl; tparam.h now does this.
17518 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
17519 * terminfo.c: Include tparam.h, to check interfaces.
17520 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
17521 (tparam): Adjust signature to match interface in tparam.h;
17522 this removes some undefined behavior. Check that outstring and len
17523 are zero, which they always are with Emacs.
17524 * tparam.h (PC, BC, UP): New extern decls.
17525
0248044d 17526 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 17527 (xftfont_open): Rename locals to avoid shadowing.
0248044d 17528
8ff096c1 17529 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
17530 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
17531 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 17532 (ftfont_list): Remove unused local.
49eaafba
PE
17533 (get_adstyle_property, ftfont_pattern_entity):
17534 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
17535 Rename locals to avoid shadowing.
8ff096c1 17536
e2be39f6
PE
17537 * xfont.c (xfont_list_family): Mark var as initialized.
17538
c9735e30
PE
17539 * xml.c (make_dom): Now static.
17540
8f5201ae
PE
17541 * composite.c (composition_compute_stop_pos): Rename local to
17542 avoid shadowing.
b246f932
PE
17543 (composition_reseat_it): Remove unused locals.
17544 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 17545 (composition_update_it): Mark var as initialized.
11b61122
PE
17546 (find_automatic_composition): Mark vars as initialized,
17547 with a FIXME (Bug#8290).
8f5201ae 17548
760fbc2c
PE
17549 character.h: Rename locals to avoid shadowing.
17550 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
17551 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
17552 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
17553 (BUF_DEC_POS): Be more systematic about renaming local temporaries
17554 to avoid shadowing.
17555
ff08eb85
PE
17556 * textprop.c (property_change_between_p): Remove; unused.
17557
fc7bf025
PE
17558 * intervals.c (interval_start_pos): Now static.
17559
235d7abc
PE
17560 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
17561
44f230aa
SM
17562 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
17563 Rename locals to avoid shadowing.
3e7d6594 17564
50060332
PE
17565 * sound.c (wav_play, au_play, Fplay_sound_internal):
17566 Fix pointer signedness.
d01f234b 17567 (alsa_choose_format): Remove unused local var.
c83b8872
PE
17568 (wav_play): Initialize a variable to 0, to prevent undefined
17569 behavior (Bug#8278).
50060332 17570
c4fc4e30
PE
17571 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
17572
918436ed
PE
17573 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
17574
c939f91b
PE
17575 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
17576 clobbering (Bug#8298).
b9c7f648
PE
17577 * sysdep.c (sys_subshell): Likewise.
17578 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 17579
6bd8c144
PE
17580 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
17581 This should get cleaned up, so that child_setup has the
17582 same signature on all platforms.
17583
7710357c 17584 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 17585 (relocate_fd): Rename locals to avoid shadowing.
7710357c 17586
c59da222
CY
175872011-03-22 Chong Yidong <cyd@stupidchicken.com>
17588
17589 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
17590 not to be necessary, and produces flickering.
17591
66b87493
GM
175922011-03-20 Glenn Morris <rgm@gnu.org>
17593
17594 * config.in: Remove file.
17595
45b6f6d5
JB
175962011-03-20 Juanma Barranquero <lekktu@gmail.com>
17597
17598 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
17599 are now in src/globals.h.
17600 (syms_of_minibuf): Remove spurious & from previous change.
17601
cd394be1 176022011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
17603
17604 * minibuf.c (completing-read-function): New variable.
17605 (completing-read-default): Rename from completing-read.
17606 (completing-read): Call completing-read-function.
17607
b14e3e21
CY
176082011-03-19 Juanma Barranquero <lekktu@gmail.com>
17609
17610 * xfaces.c (Fx_load_color_file):
17611 Read color file from absolute filename (bug#8250).
17612
f2b726e6
JB
176132011-03-19 Juanma Barranquero <lekktu@gmail.com>
17614
17615 * makefile.w32-in: Update dependencies.
17616
09f6ff02
EZ
176172011-03-17 Eli Zaretskii <eliz@gnu.org>
17618
17619 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
17620
29a6015a
PE
176212011-03-17 Paul Eggert <eggert@cs.ucla.edu>
17622
a3a6c54e
PE
17623 Fix more problems found by GCC 4.5.2's static checks.
17624
b766f867
PE
17625 * process.c (make_serial_process_unwind, send_process_trap):
17626 (sigchld_handler): Now static.
17627
be02381c
PE
17628 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
17629 That way, the code declares only the vars that it needs.
17630 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
17631 * s/cygwin.h (PTY_ITERATION): Likewise.
17632 * s/darwin.h (PTY_ITERATION): Likewise.
17633 * s/gnu-linux.h (PTY_ITERATION): Likewise.
17634
57048744
PE
17635 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
17636 * process.c (allocate_pty): Don't declare stb unless it's needed.
17637
7914961c 17638 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
17639 (CONSTANTLIM): Remove; unused.
17640 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
17641 Define only if needed.
7914961c 17642
b3967b18
PE
17643 * unexelf.c (unexec): Name an expression,
17644 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
17645 Use a different way to cause a compilation error if anyone uses
17646 n rather than nn, a way that does not involve shadowing.
73366a00 17647 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 17648
29a6015a
PE
17649 * deps.mk (unexalpha.o): Remove; unused.
17650
43cfc33e 17651 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 17652 * unexec.h: New file.
ce701a33
PE
17653 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
17654 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
17655 Depend on unexec.h.
17656 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
17657 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
17658 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 17659 Change as necessary to match prototype in unexec.h.
ce701a33 17660
01f44d5a
PE
17661 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
17662 shadowing.
4f63c6bb 17663 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 17664
a6670b0b
PE
17665 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
17666 Rename locals to avoid shadowing.
17667
cef2010d 17668 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 17669 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 17670
d4d7173a
PE
17671 * print.c (Fredirect_debugging_output): Fix pointer signedess.
17672
f08b802a
PE
17673 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
17674 warning when compiling print.c.
17675
3ddb0639
PE
17676 * font.c (font_unparse_fcname): Abort in an "impossible" situation
17677 instead of using an uninitialized var.
5ad03b97 17678 (font_sort_entities): Mark var as initialized.
3ddb0639 17679
170a2692
PE
17680 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
17681
e663c700
PE
17682 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
17683 pointers to constants.
89bc529a 17684 (font_parse_fcname): Remove unused vars.
7b81e2d0 17685 (font_delete_unmatched): Now static.
ea838e10 17686 (font_get_spec): Remove; unused.
13a547c6
PE
17687 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
17688 (font_update_drivers, Ffont_get_glyphs, font_add_log):
17689 Rename or move locals to avoid shadowing.
e663c700 17690
2a80c887 17691 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 17692 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 17693
1384fa33 17694 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 17695 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 17696
8b2c52e9
PE
17697 * alloc.c (mark_backtrace): Move decl from here ...
17698 * lisp.h: ... to here, so that it can be checked.
17699
475545b5 17700 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 17701 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
17702 (lisp_indirect_variable): Name an expression,
17703 to avoid gcc -Wbad-function-cast warning.
1faed8ae 17704 (Fdefvar): Rename locals to avoid shadowing.
475545b5 17705
b1349114 17706 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 17707 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 17708 Use const pointer when appropriate.
b1349114 17709
a2928364
PE
17710 * lisp.h (get_system_name, get_operating_system_release):
17711 Move decls here, to check interfaces.
17712 * process.c (get_operating_system_release): Move decl to lisp.h.
17713 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
17714 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
17715 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
17716 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
17717 (Fformat_time_string, Fencode_time, Finsert_char):
17718 (Ftranslate_region_internal, Fformat):
17719 Rename or remove local vars to avoid shadowing.
9710023e 17720 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 17721
a415e694
PE
17722 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
17723 avoid shadowing.
17724
8ef4622d
PE
17725 * lisp.h (eassert): Check that the argument compiles, even if
17726 ENABLE_CHECKING is not defined.
17727
946f9a5b
PE
17728 * data.c (Findirect_variable): Name an expression, to avoid
17729 gcc -Wbad-function-cast warning.
112396d6 17730 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 17731 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
17732 (Fmake_variable_buffer_local, Fmake_local_variable):
17733 Mark variables as initialized.
52746918 17734 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 17735
e5aab7e7 17736 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
17737 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
17738 Rename locals to avoid shadowing.
dff45157
PE
17739 (mark_stack): Move local variables into the #ifdef region where
17740 they're used.
7bc26fdb
PE
17741 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
17742 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
17743 needed otherwise.
17744 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
17745 (GC_STRING_CHARS): Remove; not used.
d40d4be1 17746 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 17747
e5aab7e7
PE
17748 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
17749 avoids undefined behavior in theory.
17750
4da60324
PE
17751 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
17752
88043301
PE
17753 Use functions, not macros, for up- and down-casing (Bug#8254).
17754 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
17755 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
17756 to use the following functions instead of these macros.
17757 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
17758 EMACS_INT, since callers assume the returned value fits in int.
17759 (upcase1): Likewise, for UPCASE_TABLE.
17760 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 17761 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 17762 the race-condition problem in the old DOWNCASE.
88043301 17763
19ed5445
PE
17764 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
17765 Rename locals to avoid shadowing.
17766 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
17767 (regex_compile, re_search_2, re_match_2_internal):
17768 Remove unused local vars.
952db0d7
PE
17769 (FREE_VAR): Rewrite so as not to use empty "else",
17770 which gcc can warn about.
da053e48 17771 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
17772 (RETALLOC_IF): Define only if needed.
17773 (WORDCHAR_P): Likewise. This one is never needed, but is used
17774 only in a comment talking about a compiler bug, so put inside
17775 the #if 0 of that comment.
17776 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
17777 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
17778 Remove; unused.
19ed5445 17779
1f3561e4 17780 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
17781 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
17782 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 17783
ded6f8f7
PE
17784 * search.c (simple_search): Remove unused var.
17785
dbd37a95
PE
17786 * dired.c (compile_pattern): Move decl from here ...
17787 * lisp.h: ... to here, so that it can be checked.
17788 (struct re_registers): New forward decl.
17789
7e47afad
PE
17790 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
17791
85f24f61
PE
17792 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
17793 All uses changed.
17794 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
17795 Rename locals to avoid shadowing.
5671df8f 17796 (Fvertical_motion): Mark locals as initialized.
85f24f61 17797
181aa2be 17798 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 17799 (casify_region): Mark local as initialized.
181aa2be 17800
930d429c
PE
17801 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
17802
7082eac6
PE
17803 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
17804 New macros, so that the caller can use some names other than
17805 gcpro1, gcpro2, etc.
17806 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
17807 of the new macros.
17808 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
17809 argument, for consistency with GCPRO2_VAR, etc: it is now the
17810 prefix of the variable, not the variable itself. All uses
17811 changed.
38b2c076
PE
17812 * dired.c (directory_files_internal, file_name_completion):
17813 Rename locals to avoid shadowing.
17814
15206ed9
PE
17815 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
17816 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
17817 dired.c's scmp function, had undefined behavior.
17818 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
17819 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
17820 * buffer.h: ... to here, because these macros use current_buffer,
17821 and the new implementation with inline functions needs to have
17822 current_buffer in scope now, rather than later when the macros
17823 are used.
17824 (downcase, upcase1): New static inline functions.
17825 (DOWNCASE, UPCASE1): Reimplement using these functions.
17826 This avoids undefined behavior in expressions like
17827 DOWNCASE (x) == DOWNCASE (y), which previously suffered
17828 from race conditions in accessing the global variables
17829 case_temp1 and case_temp2.
17830 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
17831 * lisp.h (case_temp1, case_temp2): Remove their decls.
17832 * character.h (ASCII_CHAR_P): Move from here ...
17833 * lisp.h: ... to here, so that the inline functions mentioned
17834 above can use them.
17835
4a6bea26
PE
17836 * dired.c (directory_files_internal_unwind): Now static.
17837
f14b7e14
PE
17838 * fileio.c (file_name_as_directory, directory_file_name):
17839 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
17840 Now static.
2893f146
PE
17841 (file_name_as_directory): Use const pointers when appropriate.
17842 (Fexpand_file_name): Likewise. In particular, newdir might
17843 point at constant storage, so make it a const pointer.
fd4ead52 17844 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
17845 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
17846 signedness issues.
f839df0c
PE
17847 (Fset_file_times, Finsert_file_contents, auto_save_error):
17848 Rename locals to avoid shadowing.
f14b7e14 17849
5716756e 17850 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
17851 (Ftry_completion, Fall_completions): Rename or remove locals
17852 to avoid shadowing.
5716756e 17853
b4c3046a
PE
17854 * marker.c (bytepos_to_charpos): Remove; unused.
17855
b45db522
PE
17856 * lisp.h (verify_bytepos, count_markers): New decls,
17857 so that gcc does not warn that these functions aren't declared.
17858
85876d07
PE
17859 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
17860 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 17861 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 17862 (copy_text): Remove unused local var.
85876d07 17863
03d78a21 17864 * filelock.c (within_one_second): Now static.
b3dd38ab 17865 (lock_file_1): Rename local to avoid shadowing.
03d78a21 17866
5df8f01b
PE
17867 * buffer.c (fix_overlays_before): Mark locals as initialized.
17868 (fix_start_end_in_overlays): Likewise. This function should be
17869 simplified by using pointers-to-pointers, but that's a different
17870 matter.
b1d876f1 17871 (switch_to_buffer_1): Now static.
8f54f30a
PE
17872 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
17873 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 17874
a70072c9 17875 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 17876 Fix pointer signedness issue.
edced198
PE
17877 (sys_subshell): Mark local as volatile if checking for lint,
17878 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 17879 (MAXPATHLEN): Define only if needed.
a70072c9 17880
a0977c44
PE
17881 * process.c (serial_open, serial_configure): Move decls from here ...
17882 * systty.h: ... to here, so that they can be checked.
17883
a884fdcc
PE
17884 * fns.c (get_random, seed_random): Move extern decls from here ...
17885 * lisp.h: ... to here, so that they can be checked.
17886
604efe86 17887 * sysdep.c (reset_io): Now static.
b8950c94 17888 (wait_for_termination_signal): Remove; unused.
604efe86 17889
38fc62d9
PE
17890 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
17891 (copy_keymap_item, append_key, push_text_char_description):
17892 Now static.
1004a21a 17893 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 17894 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
17895 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
17896 (describe_map_tree):
17897 Rename locals to avoid shadowing.
38fc62d9 17898
2f2650da
PE
17899 * keyboard.c: Declare functions static if they are not used elsewhere.
17900 (echo_char, echo_dash, cmd_error, top_level_2):
17901 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
17902 (read_char, kbd_buffer_get_event, make_lispy_position):
17903 (make_lispy_event, make_lispy_movement, apply_modifiers):
17904 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
17905 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
17906 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 17907 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 17908 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 17909
a053e86c 17910 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
17911 (mark_kboards): Move decl here ...
17912 * alloc.c (mark_kboards): ... from here.
a053e86c 17913
4752793e
PE
17914 * lisp.h (force_auto_save_soon): New decl.
17915
74f10ca7 17916 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
17917 (DEFINE_DUMMY_FUNCTION): New macro.
17918 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
17919 Use it.
c03cd23f
PE
17920 (main): Add casts to avoid warnings
17921 if GCC considers string literals to be constants.
74f10ca7 17922
022e70d4
PE
17923 * lisp.h (fatal_error_signal): Add decl, since it's exported.
17924
59d6fe83
PE
17925 * dbusbind.c: Pointer signedness fixes.
17926 (xd_signature, xd_append_arg, xd_initialize):
17927 (Fdbus_call_method, Fdbus_call_method_asynchronously):
17928 (Fdbus_method_return_internal, Fdbus_method_error_internal):
17929 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
17930 (Fdbus_register_signal): Use SSDATA when the context wants char *.
17931
78320123
PE
17932 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
17933 if GCC considers string literals to be constants.
49cebcca 17934 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 17935
35ac2a97
SM
179362011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
17937
fb103ca9
SM
17938 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
17939 (print_preprocess, print_object): New macro to fix last change.
17940
35ac2a97
SM
17941 * print.c (print_preprocess): Don't forget font objects.
17942
62973b41
JB
179432011-03-16 Juanma Barranquero <lekktu@gmail.com>
17944
17945 * emacs.c (USAGE3): Doc fixes.
17946
0e48bb22
AS
179472011-03-15 Andreas Schwab <schwab@linux-m68k.org>
17948
17949 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
17950 structure.
17951
7684e57b
JB
179522011-03-14 Juanma Barranquero <lekktu@gmail.com>
17953
17954 * lisp.h (VWindow_system, Qfile_name_history):
17955 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
17956 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
17957 (w32_system_caret_x, w32_system_caret_y): Declare extern.
17958
17959 * w32select.c: Don't #include "keyboard.h".
c96bbc66 17960 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
17961
17962 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
17963 * w32console.c (detect_input_pending, read_input_pending)
17964 (encode_terminal_code):
17965 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
17966 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
17967 (w32_system_caret_y, Qfile_name_history):
17968 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
17969 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
17970 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
17971 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
17972 * w32proc.c (Qlocal, report_file_error):
17973 * w32term.c (Vwindow_system, updating_frame):
17974 * w32uniscribe.c (initialized, uniscribe_font_driver):
17975 Remove unneeded extern declarations.
17976
2aa46d6c
CY
179772011-03-14 Chong Yidong <cyd@stupidchicken.com>
17978
c96bbc66 17979 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 17980
cffc6f3b
CY
179812011-03-13 Chong Yidong <cyd@stupidchicken.com>
17982
17983 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
17984 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
17985 These macros can no longer be used for assignment.
17986
44f230aa
SM
17987 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
17988 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
17989 (record_buffer_markers, fetch_buffer_markers): New functions for
17990 recording and fetching special buffer markers.
17991 (set_buffer_internal_1, set_buffer_temp): Use them.
17992
17993 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
17994
17995 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
17996
17997 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
17998 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
17999
18000 * xdisp.c (hscroll_window_tree):
18001 (reconsider_clip_changes): Use PT instead of BUF_PT.
18002
d251f04b
EZ
180032011-03-13 Eli Zaretskii <eliz@gnu.org>
18004
18005 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
18006 $(EMACS_ROOT)/lib/intprops.h.
18007
f0c77cd1
PE
180082011-03-13 Paul Eggert <eggert@cs.ucla.edu>
18009
3eca4629
PE
18010 Fix more problems found by GCC 4.5.2's static checks.
18011
7c86ee98
PE
18012 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
18013 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
18014 (xg_free_frame_widgets): Make it clear that a local variable is
18015 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
18016 (gdk_window_get_screen): Make it clear that this macro is needed
18017 only if USE_GTK_TOOLTIP.
1e5524e7
PE
18018 (int_gtk_range_get_value): New function, which avoids a diagnostic
18019 from gcc -Wbad-function-cast.
18020 (xg_set_toolkit_scroll_bar_thumb): Use it.
18021 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
18022 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
18023 (get_utf8_string, xg_get_file_with_chooser):
18024 Rename locals to avoid shadowing.
18025 (create_dialog): Move locals to avoid shadowing.
7c86ee98 18026
41729b81
PE
18027 * xgselect.c (xg_select): Remove unused var.
18028
f0c77cd1
PE
18029 * image.c (four_corners_best): Mark locals as initialized.
18030 (gif_load): Initialize transparent_p to zero (Bug#8238).
18031 Mark another local as initialized.
ec6cf4c6 18032 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 18033
ce0ad53d 18034 * image.c (clear_image_cache): Now static.
d5d5a617 18035 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 18036 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
18037 (x_edge_detection): Remove unnecessary cast that
18038 gcc -Wbad-function-cast diagnoses.
2037898d 18039 (gif_load): Fix pointer signedness.
6ae141d6
PE
18040 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
18041 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 18042
33383987 180432011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 18044
d32df629
PE
18045 Improve quality of tests for time stamp overflow.
18046 For example, without this patch (encode-time 0 0 0 1 1
18047 1152921504606846976) returns the obviously-bogus value (-948597
18048 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
18049 reports time overflow. See
18050 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
18051 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
18052 * editfns.c: Include limits.h and intprops.h.
18053 (TIME_T_MIN, TIME_T_MAX): New macros.
18054 (time_overflow): Move earlier, to before first use.
18055 (hi_time, lo_time): New functions, for an accurate test for
18056 out-of-range times.
18057 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
18058 (Fget_internal_run_time): Don't assume time_t fits in int.
18059 (make_time): Use list2 instead of Fcons twice.
18060 (Fdecode_time): More accurate test for out-of-range times.
18061 (check_tm_member): New function.
18062 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
18063 (lisp_time_argument): Don't rely on undefined left-shift and
18064 right-shift behavior when checking for time stamp overflow.
8be6f318 18065
fe31d94c
PE
18066 * editfns.c (time_overflow): New function, refactoring common code.
18067 (Fformat_time_string, Fdecode_time, Fencode_time):
18068 (Fcurrent_time_string): Use it.
18069
8be6f318
PE
18070 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
18071 * dired.c (make_time): Move to ...
18072 * editfns.c (make_time): ... here.
18073 * systime.h: Note the move.
18074
09d9db2c 180752011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 18076
126bc0dc
YM
18077 * fringe.c (update_window_fringes): Remove unused variables.
18078
c47cbdfd
YM
18079 * unexmacosx.c (copy_data_segment): Also copy __got section.
18080 (Bug#8223)
18081
7ac80be9
EZ
180822011-03-12 Eli Zaretskii <eliz@gnu.org>
18083
c96bbc66 18084 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
18085 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
18086 Constify `char *' arguments and their references according to
18087 prototypes in tparam.h.
18088
ecb0f94d 18089 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 18090
7ac80be9
EZ
18091 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
18092 Adapt all references accordingly.
18093
18094 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
18095
ef1fd07e
TT
180962011-03-11 Tom Tromey <tromey@redhat.com>
18097
18098 * buffer.c (syms_of_buffer): Remove obsolete comment.
18099
7ef4b50c
EZ
181002011-03-11 Eli Zaretskii <eliz@gnu.org>
18101
18102 * termhooks.h (encode_terminal_code): Declare prototype.
18103
18104 * msdos.c (encode_terminal_code): Don't declare prototype.
18105
18106 * term.c (encode_terminal_code): Now external again, used by
18107 w32console.c and msdos.c.
18108
44f230aa
SM
18109 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
18110 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 18111
4b1ec863 181122011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 18113
1714f52b 18114 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 18115
4b1ec863
PE
18116 * fringe.c (update_window_fringes): Mark locals as initialized
18117 (Bug#8227).
18118 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 18119
524c7aa6
PE
18120 * alloc.c (mark_fringe_data): Move decl from here ...
18121 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
18122 to check its interface.
18123 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
18124
a5c0af81 18125 * fontset.c (free_realized_fontset): Now static.
7519b8cd 18126 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 18127 (fontset_font): Mark local as initialized.
a9a06e0b 18128 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 18129
b4716021
PE
18130 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
18131
811e9bac 18132 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 18133 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
18134 (x_own_selection, Fx_disown_selection_internal): Rename locals
18135 to avoid shadowing.
18136 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 18137
7e3ab302
PE
18138 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
18139 so that the caller can use some name other than gcpro1.
18140 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
18141 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
18142 (Fx_backspace_delete_keys_p):
18143 Use them to avoid shadowing, and rename vars to avoid shadowing.
18144 (x_decode_color, x_set_name, x_window): Now static.
6b437900 18145 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 18146 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
18147 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
18148 Remove unused locals.
7e3ab302
PE
18149 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
18150 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
18151 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
18152 macros.
f78faa98 18153
e2b13473
PE
18154 * xterm.h (x_mouse_leave): New decl.
18155
77f23912
PE
18156 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
18157 Remove unused functions.
cdf4ba58
PE
18158 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
18159 (x_calc_absolute_position): Now static.
7411c686 18160 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 18161 Don't declare local "event" unless it's used.
ed7bf3a5
PE
18162 (x_iconify_frame, x_free_frame_resources): Don't declare locals
18163 unless they are used.
38d0b34a
PE
18164 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
18165 (x_fatal_error_signal): Remove; not used.
a6067996
PE
18166 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
18167 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
18168 (x_error_catcher, x_connection_closed, x_error_handler):
18169 (x_error_quitter, xembed_send_message, x_iconify_frame):
18170 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 18171 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 18172 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 18173
44f230aa
SM
18174 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
18175 Rename or move locals to avoid shadowing.
6b463e58 18176 (tty_defined_color, merge_face_heights): Now static.
5967d051 18177 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
18178 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
18179 does not deduce is never used uninitialized.
73719eba
PE
18180 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
18181 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 18182
426994c3 18183 * terminal.c (store_terminal_param): Now static.
5489860b 18184
032f1620 18185 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 18186 (set_frame_menubar): Remove unused local.
d4323972 18187 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
18188 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
18189 since they might point to immutable storage.
281585b0
PE
18190 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
18191 since it's unused otherwise.
032f1620 18192
367c19e5 18193 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 18194 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
18195 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
18196 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 18197 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
18198 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
18199 does not deduce are never used uninitialized.
70739cbe 18200
07b48fa9
PE
18201 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
18202
8868a238 18203 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
18204 * window.c (window_loop, size_window):
18205 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 18206
7e5cf297 18207 * window.c (display_buffer): Now static.
d6550a9f
PE
18208 (size_window): Mark variables that gcc -Wuninitialized
18209 does not deduce are never used uninitialized.
a586633d
PE
18210 * window.h (check_all_windows): New decl, to forestall
18211 gcc -Wmissing-prototypes diagnostic.
5b555da1 18212 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 18213
f6095868
PE
18214 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
18215 shadowing.
18216 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
18217 Include <limits.h>.
18218 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
18219 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
18220 (load_charset_map): Mark variables that gcc -Wuninitialized
18221 does not deduce are never used uninitialized.
53df7c11 18222 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 18223
f38b440c
PE
18224 * coding.c (coding_set_source, coding_set_destination):
18225 Use "else { /* comment */ }" rather than "else /* comment */;"
18226 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
18227 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
18228 a block, when the outer 'i' will do.
18229 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
18230 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
18231 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
18232 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
18233 (Fdecode_sjis_char, Fdefine_coding_system_internal):
18234 Rename locals to avoid shadowing.
18235 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
18236 * coding.c (emacs_mule_char, encode_invocation_designation):
18237 Now static, since they're not used elsewhere.
413bb2db 18238 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 18239 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
18240 (decode_coding_emacs_mule): Mark variables that gcc
18241 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
18242 (detect_coding_iso_2022): Initialize a local variable that might
18243 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 18244 this initialization is needed. (Bug#8211)
5f58e762
PE
18245 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
18246 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
18247 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
18248 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
18249 Remove unused macros.
f38b440c 18250
232b38b9 18251 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 18252 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 18253 * character.c (string_count_byte8): Likewise.
232b38b9 18254
fb90da1b
PE
18255 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
18256 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
18257
fb93dbc2
PE
18258 * chartab.c (copy_sub_char_table): Now static, since it's not used
18259 elsewhere.
5c156ace
PE
18260 (sub_char_table_ref_and_range, char_table_ref_and_range):
18261 Rename locals to avoid shadowing.
bbcd0949 18262 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 18263
7d3b3862 18264 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 18265 (BIDI_BOB): Remove unused macro.
7d3b3862 18266
6be7d3da
PE
18267 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
18268 deduce are never used uninitialized.
c2ed9c8b 18269 * term.c (encode_terminal_code): Likewise.
6be7d3da 18270
75f8807f 18271 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 18272
50938595
PE
18273 * tparam.h: New file.
18274 * term.c, tparam.h: Include it.
18275 * deps.mk (term.o, tparam.o): Depend on tparam.h.
18276 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
18277 Move these decls to tparam.h, and make them agree with what
18278 is actually in tparam.c. The previous trick of using incompatible
18279 decls in different modules does not conform to the C standard.
18280 All callers of tparam changed to use tparam's actual API.
18281 * tparam.c (tparam1, tparam, tgoto):
18282 Use const pointers where appropriate.
18283
fbceeba2
PE
18284 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
18285 * cm.h (struct cm): Likewise.
18286 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
18287 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
18288 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
18289 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
18290 (turn_on_face, init_tty): Likewise.
18291 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 18292
7f3f1250
PE
18293 * term.c (term_mouse_position): Rename local to avoid shadowing.
18294
e6ca6543
PE
18295 * alloc.c (mark_ttys): Move decl from here ...
18296 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
18297
c40f8d15
AS
182982011-03-11 Andreas Schwab <schwab@linux-m68k.org>
18299
18300 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
18301
cfe0661d
JB
183022011-03-09 Juanma Barranquero <lekktu@gmail.com>
18303
18304 * search.c (compile_pattern_1): Remove argument regp, unused since
18305 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
18306 (compile_pattern): Don't pass it.
18307
0afb4571
J
183082011-03-08 Jan Djärv <jan.h.d@swipnet.se>
18309
18310 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
18311 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
18312 for ! HAVE_GTK3.
18313 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
18314
18315 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
18316
18317 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
18318 gdk_window_get_screen, gdk_window_get_geometry,
18319 gdk_x11_window_lookup_for_display and GDK_KEY_g.
18320 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
18321 (xg_get_pixbuf_from_pixmap): New function.
18322 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
18323 to Pixmap, take frame as parameter, remove GdkColormap parameter.
18324 Call xg_get_pixbuf_from_pixmap instead of
18325 gdk_pixbuf_get_from_drawable.
18326 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
18327 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
18328 (xg_check_special_colors): Use GtkStyleContext and its functions
18329 for HAVE_GTK3.
18330 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
18331 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
18332 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
18333 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
18334 Call gtk_widget_get_preferred_size.
0afb4571
J
18335 (xg_frame_resized): gdk_window_get_geometry only takes 5
18336 parameters.
44f230aa
SM
18337 (xg_win_to_widget, xg_event_is_for_menubar):
18338 Call gdk_x11_window_lookup_for_display.
0afb4571
J
18339 (xg_set_widget_bg): New function.
18340 (delete_cb): New function.
895009e1 18341 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 18342 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
18343 (xg_set_background_color): Call xg_set_widget_bg.
18344 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
18345 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
18346 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
18347 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
18348 if ! HAVE_GTK3.
18349 (update_frame_tool_bar): Call gtk_widget_hide.
18350 (xg_initialize): Use GDK_KEY_g.
18351
18352 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
18353 if ! HAVE_GTK3
18354 (x_session_initialize): Call gdk_x11_set_sm_client_id.
18355
18356 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
18357 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
18358 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
18359
1c2cc4ef
JB
183602011-03-08 Juanma Barranquero <lekktu@gmail.com>
18361
18362 * w32xfns.c (select_palette): Check success of RealizePalette against
18363 GDI_ERROR, not zero.
18364
33383987 18365See ChangeLog.11 for earlier changes.
aac0c6e3
MR
18366
18367;; Local Variables:
18368;; coding: utf-8
aac0c6e3
MR
18369;; End:
18370
2f097256 18371 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
18372
18373 This file is part of GNU Emacs.
18374
18375 GNU Emacs is free software: you can redistribute it and/or modify
18376 it under the terms of the GNU General Public License as published by
18377 the Free Software Foundation, either version 3 of the License, or
18378 (at your option) any later version.
18379
18380 GNU Emacs is distributed in the hope that it will be useful,
18381 but WITHOUT ANY WARRANTY; without even the implied warranty of
18382 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
18383 GNU General Public License for more details.
18384
18385 You should have received a copy of the GNU General Public License
18386 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.